* nsterm.m (ns_update_begin): If native fullscreen and no toolbar,
[bpt/emacs.git] / src / ChangeLog
CommitLineData
28c76099
JD
12013-10-06 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (ns_update_begin): If native fullscreen and no toolbar,
4 hide toolbar (Bug#15388).
5 (windowDidEnterFullScreen:): If presentation options are zero,
6 set them here (Bug#15388).
7
544a2a80
XF
82013-10-05 Xue Fuqiao <xfq.free@gmail.com>
9
10 * editfns.c (message): Mention batch mode in doc string.
11
a27fd309
JD
122013-10-05 Jan Djärv <jan.h.d@swipnet.se>
13
14 * nsterm.m (check_native_fs): Remove erroneous comment.
15
942f6f82
DA
162013-10-04 Dmitry Antipov <dmantipov@yandex.ru>
17
18 * xdisp.c (redisplay_internal): Simplify because scan_for_column now
19 uses find_newline instead of scan_newline and so doesn't move point.
20
157fec2e
PE
212013-10-04 Paul Eggert <eggert@cs.ucla.edu>
22
4eed3157
PE
23 Use hardware support for byteswapping on glibc x86 etc.
24 On Fedora 19 x86-64, the new bswap_64 needs 1 instruction,
25 whereas the old swap64 needed 30.
26 * fringe.c (init_fringe_bitmap) [WORDS_BIGENDIAN]:
27 * sound.c (le2hl, le2hs, be2hl) [!WINDOWSNT]:
28 Use byteswap.h's macros to swap bytes.
29 * lisp.h (swap16, swap32, swap64): Remove.
30 All uses replaced by bswap_16, bswap_32, bswap_64.
31
157fec2e
PE
32 * bytecode.c (exec_byte_code): Use some more volatile variables
33 to work around local variables getting clobbered by longjmp.
34 Port to pre-C99, which doesn't allow decls after stmts.
35
b52f569d
PE
362013-10-03 Paul Eggert <eggert@cs.ucla.edu>
37
75273afb
PE
38 * lisp.h (eassert): Assume that COND is true when optimizing.
39 In other words, take on the behavior of eassert_and_assume.
40 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
41 (eassert_and_assume): Remove. All uses replaced by eassert.
42
ead45345
PE
43 * xdisp.c (Qglyphless_char): Now static.
44
0a858ebf
PE
45 Adjust to merge from gnulib.
46 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
47 * lisp.h: Include <verify.h>, for 'assume'.
48
b52f569d
PE
49 * eval.c (clobbered_eassert): New macro.
50 (internal_catch, internal_condition_case)
51 (internal_condition_case_1, internal_condition_case_2)
52 (internal_condition_case_n): Use it instead of eassert
53 when the argument contains locals clobbered by longjmp.
54 Don't use clobbered locals outside of clobbered_eassert.
55 (internal_lisp_condition_case): Use a volatile variable
56 to work around a local variable's getting clobbered.
57
adf2aa61
SM
582013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
59
60 * lisp.h (struct handler): Merge struct handler and struct catchtag.
61 (PUSH_HANDLER): New macro.
62 (catchlist): Remove.
63 (handlerlist): Always declare.
64
65 * eval.c (catchlist): Remove (merge with handlerlist).
66 (handlerlist, lisp_eval_depth): Not static any more.
67 (internal_catch, internal_condition_case, internal_condition_case_1)
68 (internal_condition_case_2, internal_condition_case_n):
69 Use PUSH_HANDLER.
70 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
71 handlerlist/catchlist.
72 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
73 handlerlist which can only handle a single condition-case handler at
74 a time.
75 (find_handler_clause): Simplify since we only a single branch here
76 any more.
77
78 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
79 and Bpophandler.
80 (bcall0): New function.
81 (exec_byte_code): Add corresponding cases. Improve error message when
82 encountering an invalid byte-code. Let Bunwind_protect accept
83 a function (rather than a list of expressions) as argument.
84
85 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
86 and make them unconditional now that they're heap-allocated.
87
328a8179
SM
882013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
89
90 * charset.c (Fdecode_char, Fencode_char): Remove description of
91 `restriction' arg. now that it's hidden by advertised-calling-convention.
92
c348360a
JD
932013-10-02 Jan Djärv <jan.h.d@swipnet.se>
94
328a8179
SM
95 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
96 Remove unused variable (from mac-port).
c348360a
JD
97 (macfont_draw): Use s->ybase for correct y position.
98
1a23cd48
DA
992013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
100
101 * frame.h (struct frame): Drop has_minibuffer member because...
102 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
103 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
104
29bf4de4
DA
1052013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
106
107 * window.h (struct window): Prefer enum text_cursor_kinds to int
108 for phys_cursor_type member. Move the latter, phys_cursor_width,
109 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
110 * window.c (replace_window, make_window): Adjust users.
111
a30ddace
DA
1122013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
115 this module is never compiled otherwise.
116
45435f08
AA
1172013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
118
119 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
120 (Bug#15500).
121
92e5298b
EZ
1222013-09-29 Eli Zaretskii <eliz@gnu.org>
123
124 * xdisp.c (get_next_display_element): Don't call face_for_font in
125 a build configured --without-x. (Bug#15484)
126
caa50be2
JD
1272013-09-29 Jan Djärv <jan.h.d@swipnet.se>
128
66d13b20
JD
129 * window.c (calc_absolute_offset): #elif should be #elif defined.
130
caa50be2
JD
131 * frame.c (delete_frame): Block/unblock input to overcome race
132 condition (Bug#15475).
133
d3e2acb6
AP
1342013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
135
136 * frame.c (delete_frame): Record selected frame only after
137 calling Qdelete_frame_functions (Bug#15477).
138
1610938f
JD
1392013-09-28 Jan Djärv <jan.h.d@swipnet.se>
140
141 * nsterm.m (ns_selection_color): Remove.
142 (ns_get_color): Check for ns_selection_(fg|bg)_color using
143 NSColor selectedText(Background)Color. Only for COCOA.
144 (ns_term_init): Remove assignment of ns_selection_color, logic
145 moved to ns_get_color.
146
328a8179 147 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
148 NS_SELECTION_COLOR_DEFAULT.
149 (NS_SELECTION_FG_COLOR_DEFAULT): New.
150
0d2647e6
EZ
1512013-09-28 Eli Zaretskii <eliz@gnu.org>
152
153 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
154 frame' does not have the tool_bar_window member.
155
ba355de0
BR
1562013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
157
158 Signal error when reading an empty byte-code object (Bug#15405)
159 * lread.c (read1): signal error
160 * alloc.c (make_byte_code): eassert header size
161 (sweep_vectors): change an int to size_t
162
4710d6f4
PE
1632013-09-24 Paul Eggert <eggert@cs.ucla.edu>
164
cf647d93
PE
165 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
166 instead of ints, as it's the usual style for offsetof constants. See:
167 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
168
4710d6f4
PE
169 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
170 This is ugly, but it should fix the performance problem for older
171 GCC versions in the short run. I'll look into integrating the
172 Gnulib module for popcount, as a better fix.
173 See the thread starting in:
174 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
175 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
176 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
177 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
178 (popcount_size_t): Use it.
179
10ebac9d
DC
1802013-09-24 Daniel Colascione <dancol@dancol.org>
181
182 * process.c (Fnetwork_interface_info): Fix build break due to
183 vector changes.
184
9da0f50e
PE
1852013-09-24 Paul Eggert <eggert@cs.ucla.edu>
186
187 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
188 Prefer signed to unsigned integers where either will do.
189 No need for 'const' on locals that do not escape.
190 Omit easserts with unnecessary and unportable assumptions about
191 alignment. Avoid unnecessary casts to char *.
192
d6d9cbc1
DA
1932013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
194
195 Use union for the payload of struct Lisp_Vector.
196 This helps to avoid a few glitches dictated by C's aliasing rules.
197 * lisp.h (struct Lisp_Vector): Use union for next and
198 contents member. Adjust comment. Change related users.
199 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
200 Related users changed.
201 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
202 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
203 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
204 * xfaces.c, xfont.c, xmenu.c: Related users changed.
205
ec7bc82f
DA
2062013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
207
208 Optimize glyph row clearing and copying routines.
209 * dispextern.h (struct glyph_row): Change layout of struct
210 glyph_row to help copy_row_except_pointers. Adjust comment.
211 * dispnew.c (null_row): Remove.
212 (clear_glyph_row): Use offsetof and memset to find and clear
213 just the members that need clearing. Adjust comment.
214 (copy_row_except_pointers): Likewise for copying.
215
d160dd0c
PE
2162013-09-24 Paul Eggert <eggert@cs.ucla.edu>
217
7be68de5
PE
218 Some minor cleanups of recently-added bool vector code.
219 * conf_post.h (assume): Always return void. Use lint version
220 only if GCC and MSC versions don't apply.
221 * conf_post.h (assume):
222 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
223 Depend on _MSC_VER, not __MSC_VER, for consistency with
224 the rest of Emacs.
225 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
226 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
227 (bool_vector_binop_driver, count_trailing_zero_bits)
228 (size_t_to_host_endian): Now static, not static inline;
229 the latter isn't needed with modern compilers and doesn't
230 work with older compilers anyway.
231
d160dd0c
PE
232 * alloc.c (valgrind_p): Use bool for boolean.
233
e08813d0
DA
2342013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
235
236 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
237 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
238 (display_last_displayed_message_p, message_buf_print)
239 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
240 Use bool for boolean.
3a6a78fd
DA
241 * dispextern.h (cancel_line, init_desired_glyphs):
242 Remove ancient leftover.
243 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
244 * lisp.h (noninteractive_need_newline): Adjust declaration.
245
5492865b
DA
2462013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
247
248 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
249 Move to...
250 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
251 ...this file and convert the latter to static. Adjust comment.
252 (make_initial_frame):
253 * window.c (init_window_once): Adjust user.
254 * frame.h (last_nonminibuf_frame): Remove declaration.
255 * lisp.h (selected_frame): Likewise.
256 * msdos.c (the_only_display_info): Adjust comment.
257
cd548fa4
EZ
2582013-09-23 Eli Zaretskii <eliz@gnu.org>
259
f03eddbf
EZ
260 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
261 computing the end column of mouse-highlight that comes from
262 display or overlay strings. (Bug#15437)
b519df23
EZ
263 (note_mouse_highlight): Adapt calculation of last argument to
264 mouse_face_from_string_pos to the above change.
f03eddbf 265
cd548fa4
EZ
266 * conf_post.h (__has_builtin): Define to zero, if undefined, on
267 all platforms, not just for clang.
268
8762e524
JD
2692013-09-23 Jan Djärv <jan.h.d@swipnet.se>
270
271 * filelock.c (lock_file_1): Rearrange to remove compiler warning
272 about excess arguments to snprintf.
273
274 * conf_post.h(assume): Use __builtin_unreachable for clang.
275
d4a9284f
JB
2762013-09-23 Juanma Barranquero <lekktu@gmail.com>
277
278 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
279 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
280
a84683fd
DC
2812013-09-23 Daniel Colascione <dancol@dancol.org>
282
283 * alloc.c (USE_VALGRIND): New macro; on by default
284 when ENABLE_CHECKING.
285 (mark_maybe_object,mark_maybe_pointer)
286 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
287 valgrind purposes.
288 (valgrind_p) [USE_VALGRIND]: New variable.
289 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
290
8fef36c6
JD
2912013-09-22 Jan Djärv <jan.h.d@swipnet.se>
292
fb83ea63
JD
293 * process.c (wait_reading_process_output): Change int pnamelen to
294 socklen_t.
295
296 * nsterm.m (setMarkedText:selectedRange:):
297 (deleteWorkingText):
298 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
299 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
300 argument to unsigned long to avoid warning.
301 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
302
8fef36c6
JD
303 * conf_post.h (assume): Fix compiler error: x shall be cond.
304
cd9356f2
DC
3052013-09-22 Daniel Colascione <dancol@dancol.org>
306
307 * xfns.c (x_get_monitor_attributes): Suppress unused variable
308 warning when compiling without a window system.
309
3e0b94e7
DC
3102013-09-22 Daniel Colascione <dancol@dancol.org>
311
312 * data.c (Qbool_vector_p): New symbol.
313 (bool_vector_spare_mask,popcount_size_t_generic)
314 (popcount_size_t_msc,popcount_size_t_gcc)
315 (popcount_size_t)
316 (bool_vector_binop_driver)
317 (count_trailing_zero_bits,size_t_to_host_endian)
318 (Fbool_vector_exclusive_or)
319 (Fbool_vector_union)
320 (Fbool_vector_intersection,Fbool_vector_set_difference)
321 (Fbool_vector_subsetp,Fbool_vector_not)
322 (Fbool_vector_count_matches)
323 (Fbool_vector_count_matches_at): New functions.
324 (syms_of_data): Intern new symbol, functions.
325 * alloc.c (bool_vector_payload_bytes): New function.
326 (Fmake_bool_vector): Instead of calling Fmake_vector,
327 which performs redundant initialization and argument checking,
328 just call allocate_vector ourselves. Make sure we clear any
329 terminating padding to zero.
330 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
331 instead of open-coding the size calculation.
332 (vroundup_ct): New macro.
333 (vroundup): Assume argument >= 0; invoke vroundup_ct.
334 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
335 * composite.c (composition_gstring_put_cache):
336 Change lint_assume to assume.
3e0b94e7
DC
337 * conf_post.h (assume): New macro.
338 (lint_assume): Remove.
339 * dispnew.c (update_frame_1): Change lint_assume to assume.
340 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
341 to assume.
342 * image.c (gif_load): Change lint_assume to assume.
343 * lisp.h (eassert_and_assume): New macro.
344 (Qbool_vector_p): Declare.
345 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
346 (swap16,swap32,swap64): New inline functions.
347 * macfont.c (macfont_shape): Change lint_assume to assume.
348 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
349 * xsettings.c (parse_settings): Use new swap16 and
350 swap32 from lisp.h instead of file-specific macros.
351
76880d88
EZ
3522013-09-22 Eli Zaretskii <eliz@gnu.org>
353
354 * xdisp.c (try_window_id): Don't abort if cursor row could not be
355 found (which can legitimately happen when the glyph row at the
356 window start is disabled in the current_matrix. (Bug#15365)
357
c6cfd910
PE
3582013-09-22 Paul Eggert <eggert@cs.ucla.edu>
359
360 Fix syntax.h bug introduced by recent INLINE change.
361 syntax.h defined an extern inline function SYNTAX_ENTRY that was
362 conditionally compiled one way in some modules, and a different
363 way in others. This doesn't work with extern inline functions,
364 which must have the same definition in all modules, because the
365 defining code might be shared across modules, depending on the
366 implementation. Symptoms reported by Martin Rudalics in:
367 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
368 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
369 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
370 overriding the corresponding functions in syntax.h.
371 * syntax.h (syntax_property_entry, syntax_property_with_flags)
372 (syntax_property): New inline functions.
373 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
374 Rewrite in terms of these new functions.
375
b3f1d119
EZ
3762013-09-21 Eli Zaretskii <eliz@gnu.org>
377
378 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
379 not chars_in_text, whose result depends on the multibyteness of
380 the current buffer. (Bug#15426)
381
00382e8b
PE
3822013-09-20 Paul Eggert <eggert@cs.ucla.edu>
383
e3b29769
PE
384 Port recent change to hosts where pointers aren't 'long'.
385 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
386 Don't assume that pointers are the same width as 'long'.
387 Add a compile-time check that a pointer fits into two X slots.
388
00382e8b
PE
389 A simpler, centralized INLINE.
390 * conf_post.h (INLINE): Define only if not already defined.
391 This allows us to use a single INLINE, defined by one file
392 per executable.
393 * emacs.c (INLINE): Define it.
394 Also, include category.h, charset.h, composite.h, dispextern.h,
395 syntax.h, systime.h, so that their INLINE definitions are expanded
396 properly for Emacs.
397 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
398 * buffer.h, buffer.c (BUFFER_INLINE):
399 * category.h, category.c (CATEGORY_INLINE):
400 * character.h, character.c (CHARACTER_INLINE):
401 * charset.h, charset.c (CHARSET_INLINE):
402 * composite.h, composite.c (COMPOSITE_INLINE):
403 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
404 * frame.h, frame.c (FRAME_INLINE):
405 * intervals.h, intervals.c (INTERVALS_INLINE):
406 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
407 * lisp.h, alloc.c (LISP_INLINE):
408 * process.h, process.c (PROCESS_INLINE):
409 * syntax.h, syntax.c (SYNTAX_INLINE):
410 * systime.h, sysdep.c (SYSTIME_INLINE):
411 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
412 * window.h, window.c (WINDOW_INLINE):
413 Remove. All uses replaced with INLINE.
414
2b943ba6
DA
4152013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
416
417 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
418 to avoid Bug#15398.
419
13d9698a
EZ
4202013-09-19 Eli Zaretskii <eliz@gnu.org>
421
422 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
423 'const char *' to avoid compiler warnings due to similar change in
424 the prototype of x_get_string_resource.
425
ced135eb
DA
4262013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
427
428 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
429 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
430 going to replace static variables below. Adjust comments.
431 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
432 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
433 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
434 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
435 Related users changed.
436 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
437 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
438 last_mouse_movement_time, going to replace static variables below.
439 Adjust comments.
440 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
441 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
442 Remove.
443 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
444 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
445 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
446 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
447 static variables below.
448 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
449 (last_mouse_scroll_bar): Remove.
450 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
451 (mouseExited): Related users changed.
452
091f1e1f
DA
4532013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
454
455 Do not use external array to process X scroll bar messages.
456 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
457 (x_send_scroll_bar_event): Pack window pointer into two slots
458 of XClientMessageEvent if we're 64-bit. Adjust comment.
459 (x_scroll_bar_to_input_event): Unpack accordingly.
460
582ed56c
DA
4612013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Ifdef away recent changes which aren't relevant to NS port.
464 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
465 [!HAVE_NS]: Declare as such.
466 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
467 [!HAVE_NS]: Define as such.
468
18da0d8a
DA
4692013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
470
471 * frame.c (x_redo_mouse_highlight): New function
472 to factor out common code used in W32 and X ports.
473 * dispextern.h (x_redo_mouse_highlight): Add prototype.
474 * xterm.h (struct x_display_info):
475 * w32term.h (struct w32_display_info):
476 * nsterm.h (struct ns_display_info): New members
477 last_mouse_motion_frame, last_mouse_motion_x and
478 last_mouse_motion_y, going to replace static variables below.
479 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
480 (redo_mouse_highlight): Remove.
481 (note_mouse_movement, syms_of_xterm): Adjust user.
482 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
483 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
484 (redo_mouse_highlight): Remove.
485 (note_mouse_movement, syms_of_w32term): Adjust user.
486 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
487 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
488 Remove.
489 (note_mouse_movement, mouseMoved, syms_of_nsterm):
490 * nsfns.m (compute_tip_xy): Adjust user.
491
7a0c745a
DA
4922013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
493
494 * frame.c (x_mouse_grabbed): New function.
495 * dispextern.h (x_mouse_grabbed): Add prototype.
496 (last_mouse_frame): Remove declaration.
497 * xterm.h (struct x_display_info):
498 * w32term.h (struct w32_display_info):
499 * nsterm.h (struct ns_display_info): New member
500 last_mouse_frame, going to replace...
501 * xdisp.c (last_mouse_frame): ...global variable.
502 (note_tool_bar_highlight):
503 * w32term.c (w32_mouse_position, w32_read_socket):
504 * xterm.c (XTmouse_position, handle_one_xevent):
505 Use x_mouse_grabbed.
506 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
507
0791d107
DA
5082013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
509
510 * w32term.c (w32_read_socket): Avoid temporary
511 variables in a call to x_real_positions.
512 * xterm.c (handle_one_xevent): Likewise.
513
2cd98812
DA
5142013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
515
516 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
517 (x_icon_type): Remove prototype.
518 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
519 * frame.c (x_icon_type): Remove.
520 * w32term.c (x_make_frame_visible, x_iconify_frame):
521 * xterm.c (x_make_frame_visible, x_iconify_frame):
522 Use x_set_bitmap_icon to factor out common code.
523
a6c2ee1b
DA
5242013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
525
526 * dispextern.h (check_x_display_info, x_get_string_resource):
527 Declare here just once and unify the latter.
528 * frame.c (check_x_display_info, x_get_string_resource):
529 * nsterm.h (check_x_display_info):
530 * xrdb.c (x_get_string_resource):
531 * xterm.h (check_x_display_info): Remove prototypes.
532 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
533 * w32reg.c (x_get_string_resource): Likewise.
534 (w32_get_rdb_resource): Adjust user.
535
baed3603
DA
5362013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
537
538 * xterm.h (struct x_display_info): New member
539 x_pending_autoraise_frame, going to replace...
540 * xterm.c (pending_autoraise_frame): ...static variable.
541 (x_new_focus_frame, XTread_socket): Adjust users.
542 * w32term.h (struct w32_display_info): New member
543 w32_pending_autoraise_frame, going to replace...
544 * w32term.c (pending_autoraise_frame): ...global variable.
545 (x_new_focus_frame, w32_read_socket): Adjust users.
546
90582f05
GM
5472013-09-17 Glenn Morris <rgm@gnu.org>
548
549 * xdisp.c (message_dolog): If we create *Messages*,
550 switch it to messages-buffer-mode.
551
b7ad2f74
PE
5522013-09-17 Paul Eggert <eggert@cs.ucla.edu>
553
554 Don't overuse 'const' in types of locals.
555 * bidi.c (bidi_count_bytes):
556 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
557 (xg_event_is_for_scrollbar):
558 * xselect.c (x_handle_property_notify)
559 (x_handle_selection_notify, x_handle_dnd_message):
560 * xsettings.c, xsettings.h (xft_settings_event):
561 * xterm.c (x_handle_net_wm_state, handle_one_event)
562 (x_menubar_window_to_frame, x_detect_focus_change)
563 (construct_mouse_click, note_mouse_movement)
564 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
565 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
566 (handle_one_xevent, x_handle_net_wm_state):
567 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
568 (x_handle_dnd_message):
569 Avoid unnecessary 'const', typically the second 'const' in
570 'const foo * const arg', a 'const' that does not affect the API
571 and doesn't significantly help the human reader.
572
19452b86
DA
5732013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
574
575 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
576 only if Glib < 2.36.0.
577 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
578 * xsettings.c (init_gconf, init_gsettings): Do not check
579 for g_type_init.
1893694e
DA
580 * xterm.c (handle_one_xevent): Do not call to x_clear_area
581 if GTK >= 2.7.0.
33b83dd7 582 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 583
6434e343
JD
5842013-09-16 Jan Djärv <jan.h.d@swipnet.se>
585
3f386383
JD
586 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
587 before calling g_type_init.
588
6434e343
JD
589 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
590
591 * nsterm.m (syms_of_nsterm): ... to here.
592
83a119f8
DA
5932013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
594
595 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
596 (ignore_next_mouse_click_timeout): Use Time as X does.
597 (handle_one_xevent): Avoid cast and use unsigned comparison.
598
61582e6a
DA
5992013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Do not copy X event in handle_one_xevent except KeyPress case.
602 Wnen XEvent is processed, it is unlikely to be changed except
603 KeyPress case, so we can avoid copying and use const pointer to
604 const data to make sure that an event is not changed elsewhere.
605 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
606 const' and do not create local copy except for the KeyPress event.
607 Use casts to avoid a few glitches. Adjust formatting. Add comments.
608 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
609 (x_handle_net_wm_state, x_menubar_window_to_frame)
610 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
611 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
612 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
613 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
614 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
615 (x_handle_dnd_message):
616 * xsettings.c (xft_settings_event):
617 Use 'const XEvent * const' where appropriate.
618 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
619
f8eb1572
DA
6202013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
621
622 Fix X event waiting to handle multiple frames.
623 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
624 * xterm.c (pending_event_wait): Remove. Adjust users.
625 (x_detect_focus_change): Pass frame arg.
626 (handle_one_xevent): Find related frame early and clear per-frame
627 wait_event_type only if this is an event for the relevant frame.
628 (x_wait_for_event): Use per-frame wait_event_type.
629
3fa2054e
JD
6302013-09-15 Jan Djärv <jan.h.d@swipnet.se>
631
745d3809
JD
632 * nsfns.m (Fx_create_frame): Fix font driver registration for
633 GNUStep.
634
635 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
636 for syms_of_macfont.
637
3fa2054e
JD
638 * nsterm.m: Include macfont.h.
639 (ns_tmp_flags, ns_tmp_font): Remove.
640 (ns_compute_glyph_string_overhangs): Check for driver Qns.
641 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
642 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
643 (changeFont:): Fix code style. Check for font driver type when
644 getiing font.
645
646 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
647 (f)->descent.
648
649 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
650 (nsfont_open): Set font driver type.
651 Set font->ascent and font->descent. Figure out font instead of
652 ns_tmp_font, and flags instead of ns_tmp_flags.
653 Fix indentation. Remove call to ns_draw_text_decoration,
654 moved to nsterm.
655
656 * nsfns.m: Include macfont.h.
657 (Fx_create_frame): Register macfont driver, make a better default font.
658 (Fns_popup_font_panel): Get font from macfont driver, if used.
659
660 * macfont.m, macfont.h, maccuvs.h: New files.
661
662 * font.h: Declare syms_of_macfont.
663
664 * font.c (syms_of_font): Call syms_of_macfont.
665
666 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
667
0eed0355
DA
6682013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
669
670 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
671 and it is always zero for others, so I assume that this is an ancient
672 leftover which nobody will want to change any more.
673 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
674 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
675 * frame.c (x_set_scroll_bar_width):
676 * w32fns.c (w32_createscrollbar):
677 * w32term.c (w32_set_vertical_scroll_bar):
678 * xfns.c (x_set_scroll_bar_default_width):
679 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
680 (x_scroll_bar_expose): Related users changed.
681
07013c68
DA
6822013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
683
684 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
685 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
686 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
687 Define as such.
c7cc32f7
DA
688 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
689 Define once here...
690 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
691 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
692 Remove unused Xisms.
7f09455e
DA
693 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
694 these modules are never compiled otherwise.
07013c68 695
0df00f59
EZ
6962013-09-14 Eli Zaretskii <eliz@gnu.org>
697
08a209bf 698 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
699 Doc fix. (Bug#15375)
700
fcd42c11
DA
7012013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
702
703 Unify Fx_focus_frame between all ports.
704 * frame.h (x_focus_frame): New prototype.
705 * xfns.c (Fx_focus_frame): Remove.
706 (syms_of_xfns): Do not defsubr it.
707 (x_focus_frame): X implementation.
708 * nsfns.m (Fx_focus_frame): Remove.
709 (syms_of_nsfns): Do not defsubr it.
710 (x_focus_frame): NS implementation.
711 * w32term.c (Fx_focus_frame): Remove.
712 (x_focus_on_frame): Rename to...
713 (x_focus_frame): W32 implementation.
714 * w32term.h (x_focus_on_frame): Remove prototype.
715 * w32fns.c (Fx_focus_frame): Remove.
716 (syms_of_w32fns): Do not defsubr it.
717 * frame.c (Fx_focus_frame): Define here.
718 (syms_of_frame): Defsubr here.
719 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
720
aad3612f
DA
7212013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
722
723 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
724 All of them are replaced with FRAME_DISPLAY_INFO, defined in
725 each port to reference the port-specific window system data.
726 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
727 (FRAME_DISPLAY_INFO): Define.
728 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
729 (FRAME_DISPLAY_INFO): Define. Adjust users.
730 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
731 (FRAME_DISPLAY_INFO): Define. Adjust users.
732 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
733 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
734 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
735 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
736 * xselect.c, xterm.c: All related users changed.
737
9a650e62
DA
7382013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
739
740 * xterm.h (x_window_to_frame, x_any_window_to_frame)
741 (x_menubar_window_to_frame): Remove prototypes.
742 * xfns.c (x_window_to_frame, x_any_window_to_frame)
743 (x_menubar_window_to_frame, x_top_window_to_frame):
744 Move from here...
745 * xterm.c (x_window_to_frame, x_any_window_to_frame)
746 (x_menubar_window_to_frame, x_top_window_to_frame):
747 ...to here and convert all but the last to static.
748
347ae3e1
EZ
7492013-09-12 Eli Zaretskii <eliz@gnu.org>
750
751 * lisp.mk (lisp): Add w32-common-fns.elc.
752
15c6d837
XF
7532013-09-12 Xue Fuqiao <xfq.free@gmail.com>
754
755 * charset.c (char_charset): Document an exception for char-charset.
756
27e90f77
DA
7572013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
758
759 * xterm.h (x_display_info): New field last_user_time...
760 * xterm.c (toplevel): ...to replace static last_user_time.
761 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
762
8ffbc36b
DA
7632013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
764
765 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
766 scroll bar values to prevent thumb from disappear and update comment.
767
5ec0337a
GM
7682013-09-11 Glenn Morris <rgm@gnu.org>
769
770 * emacs.c (usage_message): Possessive apostrophe tweak.
771
fb55b9d1
DA
7722013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
773
8d2db8be
DA
774 * nsterm.m (syms_of_nsterm): Use Qns.
775 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
776 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
777 * xfns.c (x_display_info_for_name, Fx_open_connection):
778 Remove old '#if 0' code.
779 (syms_of_xfns): Use Qx.
fb55b9d1
DA
780 * termhooks.h (fullscreen_hook): Remove the leftover.
781 (struct terminal): Fix typo in comment.
782
927eec55
DA
7832013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
784
785 Cleaning up a few X scroll bar bits.
786 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
787 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
788 New member last_seen_part, going to replace...
789 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
790 (xt_action_hook) [USE_LUCID]: Adjust user.
791 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
792 Lucid-specific scroll bar support.
793 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
794 to int and adjust to use last_seen_part member.
795 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
796 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
797 Initialize last_seen_part.
798
71b28baa
SM
7992013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
800
801 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
802 insert-buffer-substring an empty string.
803
f5dacaae
PE
8042013-09-11 Paul Eggert <eggert@cs.ucla.edu>
805
806 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
807 avoiding a GCC warning.
808
742516e0
DA
8092013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
810
811 Ifdef away frame tool bar code when it is not really used.
812 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
813 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
814 and minimize_tool_bar_window_p under the above.
815 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
816 (fset_tool_bar_window): Likewise.
817 * dispnew.c (clear_current_matrices, clear_desired_matrices)
818 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
819 (change_frame_size_1):
820 * window.c (window_from_coordinates, Frecenter): Adjust users.
821 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
822 code is not really used.
823 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
824 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
825 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
826 [!USE_GTK && !HAVE_NS]: Define as such.
827 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
828 (note_mouse_highlight, expose_frame):
829 * xfns.c (x_set_tool_bar_lines):
830 * xterm.c (handle_one_xevent): Adjust users.
831
73f82c7e
PE
8322013-09-11 Paul Eggert <eggert@cs.ucla.edu>
833
834 Fix corruption with multiple emacsclient -t instances (Bug#15222).
835 This bug was introduced by my 2013-08-26 patch, which incorrectly
836 assumed that the terminfo implementation doesn't use termcap buffers.
837 * term.c (init_tty) [TERMINFO]: Remove optimization, as
838 these buffers apparently are used after all.
839 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
840 (struct tty_display_info): Define members termcap_term_buffer and
841 termcap_strings_buffer even if TERMINFO.
842
53482f41
DA
8432013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
844
845 Fix last change.
846 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
847 'usage' docstring entry to pacify make-docfile.
848
8492013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
850
851 Change comparison functions =, <, >, <=, >= to take many arguments.
852 * data.c: Change comparison functions' interface and implementation.
853 * lisp.h: Make arithcompare available for efficient two arg
854 comparisons.
855 * bytecode.c: Use arithcompare.
856 * fileio.c: Use new interface.
857
533f258f
SM
8582013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
859
860 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
861
8c27f5ff
SM
8622013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
863
864 * eval.c (Feval): Document the new use of `lexical'.
865
0750a308
DA
8662013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
867
868 Review and drop old frame resize hack.
869 * frame.h (struct frame): Remove force_flush_display_p.
870 * dispnew.c (update_frame): Adjust user and don't call
871 flush_frame here. The comment has said that there was an issues
872 with redisplaying fringes, but I don't see any differences with
873 and without this hack. Hopefully we can continue without it.
874 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
875 current frame matrices twice if resized_p is set.
876
83fc0554
DA
8772013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
878
879 Do not populate pure Xism x_sync to other ports.
880 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
881 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
882 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
883 * w32term.h (x_sync): Remove prototype.
884
fd462129
DA
8852013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
886
887 Cleanup frame flushing.
8c27f5ff
SM
888 * dispextern.h (struct redisplay_interface):
889 Drop flush_display_optional because flush_display is enough
fd462129
DA
890 for X and flushing via RIF is just a no-op for others.
891 * frame.h (flush_frame): New function.
892 * dispnew.c (update_frame):
893 * minibuf.c (read_minibuf):
894 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
895 Use it.
896 * keyboard.c (detect_input_pending_run_timers): Do not flush
897 all frames but selected one in redisplay_preserve_echo_area.
898 * nsterm.m (ns_flush): Remove no-op.
899 (ns_redisplay_interface): Adjust user.
900 * w32term.h (x_flush): Remove no-op.
901 (w32_redisplay_interface): Adjust user.
902 * xterm.c (x_flush): Simplify because we do not flush all
903 frames at once any more. Adjust comment.
904 (x_redisplay_interface): Adjust user.
905
4b73fc73
PE
9062013-09-07 Paul Eggert <eggert@cs.ucla.edu>
907
908 Port --without-x --enable-gcc-warnings to Fedora 19.
909 * gfilenotify.c (globals_of_gfilenotify):
910 Call g_type_init only if using an older glib version that needs it.
911
77394d40
DA
9122013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
913
914 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
915 (last_glyphless_glyph_merged_face_id): Remove declarations.
916 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
917 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
918 (last_glyphless_glyph_merged_face_id): Now static.
919 (merge_escape_glyph_face): New function, refactored from...
920 (get_next_display_element): ...here.
921 (merge_glyphless_glyph_face): New function, refactored from...
922 (produce_glyphless_glyph): ...here...
923 * term.c (produce_glyphless_glyph): ...and here.
924
306d67bd
SM
9252013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
926
927 * eval.c (eval_sub): Only call Ffunction if necessary.
928
7f6c6450
DA
9292013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
930
931 Attempt to make redisplay more selective when changing cursor type.
932 * frame.h (struct frame): New bitfield cursor_type_changed.
933 * xdisp.c (cursor_type_changed): Remove.
934 (try_cursor_movement, redisplay_window, try_window_id)
935 (set_frame_cursor_types, try_window_reusing_current_matrix):
936 Adjust to use per-frame bitfield.
937 (redisplay_internal): Look for cursor type change on each visible
938 frame and consider all frames if cursor type has been changed on
939 the frame other than selected. If cursor type has been changed on
940 selected frame only, do not use fast update.
941
bd0443bb
DA
9422013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
943
944 Attempt to make redisplay more selective when changing fonts.
945 * frame.h (struct frame): New bitfield fonts_changed.
946 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
947 (adjust_frame_glyphs): Add prototype.
948 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 949 (adjust_glyphs): Remove because we do not
bd0443bb
DA
950 adjust matrices on all frames at once any more.
951 (adjust_frame_glyphs): Block and unblock input here.
952 (adjust_glyph_matrix): Use fonts_changed.
953 (change_frame_size_1): Use adjust_frame_glyphs.
954 * font.c (font_open_entity): Use fonts_changed.
955 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
956 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
957 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
958 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
959 (shrink_mini_window, Fresize_mini_window_internal)
960 (window_scroll_pixel_based, Fset_window_configuration)
961 (apply_window_adjustment, Fset_window_vscroll):
962 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
963 Use adjust_frame_glyphs.
964 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
965 (try_window_reusing_current_matrix, try_window_id, display_line)
966 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
967 (redisplay_internal): Consider fonts_changed and adjust frame
968 matrices for each frame only if the frame is visible. If font
969 has been changed on some frame during full redisplay, retry
970 only visible frames where the font has been actually changed.
971
b9695828
DA
9722013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
973
974 Cache current header and mode line height for each window.
975 * window.h (struct window): New fields mode_line_height
976 and header_line_height.
977 * window.c (make_window): Initialize them.
978 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
979 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
980 (current_mode_line_height, current_header_line_height):
981 Remove declaration.
982 * xdisp.c (current_mode_line_height, current_header_line_height):
983 Remove.
984 (pos_visible_p, init_xdisp): Adjust user.
985 (redisplay_window): Invalidate mode_line_height and
986 header_line_height if current and desired matrices do not agree.
987
66738305
DA
9882013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
989
990 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
991 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
992
257b3b03
DA
9932013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
994
995 Make --without-x compatible with --enable-gcc-warnings.
996 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
997 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
998 members under HAVE_WINDOW_SYSTEM.
999 * keyboard.c (make_lispy_focus_out): Likewise.
1000 (record_menu_key): Move under HAVE_MENUS.
1001 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
1002 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
1003 (syms_of_xdisp): Adjust user.
1004 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
1005 (start_hourglass, cancel_hourglass):
1006 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
1007 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
1008 and CLEAR_FONT_TABLE_NFONTS.
1009 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
1010 Declare only if HAVE_WINDOW_SYSTEM.
1011 (lface_same_font_attributes_p, clear_face_gcs): Define only
1012 if HAVE_WINDOW_SYSTEM.
1013
98b7f4bd
DA
10142013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1015
1016 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
1017 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
1018 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
1019
a7e43722
SM
10202013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
1021
1022 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
1023
0c90b9ee
PE
10242013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
1027 This fixes a type error on hosts where ptrdiff_t is wider than int.
1028
d99760fa
SM
10292013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1030
6629638e
SM
1031 * keyboard.c (read_key_sequence_vs): New function.
1032 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
1033 common code.
1034
d99760fa
SM
1035 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1036
224e313d
PE
10372013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 Makefile improvements.
1040 * Makefile.in (config.status): Don't use double-colon rules, as
1041 they are not portable according to POSIX. Fix shell typo with `;
1042 I guess this rule has never been tested?
1043 (VCSWITNESS): New macro, to override any environment var.
1044
6d6ed1af
DA
10452013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1046
1047 * xterm.h (struct x_display_info): Do not track X connection
1048 fd separately because it is always available from Display.
1049 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1050 Adjust users.
1051
bc923770
DA
10522013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 * buffer.c (drop_overlay):
1055 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1056 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1057
b1cf96de
DA
10582013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 * buffer.c (Fmake_overlay, Fmove_overlay):
1061 * intervals.c (set_point_from_marker):
1062 * print.c (PRINTPREPARE): Prefer signal_error
1063 to plain error and report unsuitable marker too.
1064
d1fc6c21
DA
10652013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1066
1067 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1068 for 'dragging' member.
d1ae6a0b
DA
1069 (struct x_output): Remove set-but-unused leftovers
1070 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1071 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1072 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1073 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1074 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1075 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1076 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1077 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1078 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1079
0ce9f6de
JD
10802013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1081
1082 * nsfont.m (INVALID_GLYPH): New define.
1083 (nsfont_encode_char): Use INVALID_GLYPH.
1084 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1085
b594a96c
DA
10862013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1087
1088 * xterm.c (x_last_mouse_movement_time): Revert last change.
1089 This code should use XDisplayMotionBufferSize to check display's
1090 motion history first, and there are few other issues as well.
1091 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1092 (handle_one_xevent): Adjust user.
1093
8b098236
MR
10942013-09-02 Martin Rudalics <rudalics@gmx.at>
1095
9718b207
MR
1096 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1097 * frame.c (Flast_nonminibuf_frame): ... to here.
1098 (check_minibuf_window): Don't abort if no window was found
1099 (Bug#15247).
8b098236 1100
84e70bba
DA
11012013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 Use XGetMotionEvents to ask the last mouse motion time from X server.
1104 * xterm.c (X_MOTION_HISTORY): Default to 1.
1105 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1106 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1107 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1108 Ifdef away legacy code.
1109 (XTmouse_position, x_scroll_bar_report_motion):
1110 Use x_last_mouse_movement_time.
fc85e20b
DA
1111 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1112 UnmapNotify event.
84e70bba 1113
1fccc530
DA
11142013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1115
1116 * msdos.c (last_mouse_window): Move to...
1117 (dos_rawgetc): ...this function and adjust comment.
1118 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1119 (mouseMoved): ...this function and adjust comment.
1120 * w32term.c (last_window): Likewise with...
1121 (w32_read_socket): ...this function.
1122 * xterm.c (last_window): Likewise with...
1123 (handle_one_xevent): ...this function.
1124
0ab10992
DA
11252013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1126
b7da754d 1127 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1128 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1129 (handle_one_xevent): ...to here.
1130 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1131 otherwise.
1132
0c7f856e
DA
11332013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1134
1135 * msdos.c (IT_set_terminal_window): Remove no-op.
1136 (initialize_msdos_display): Adjust terminal setup.
1137 * w32console.c (w32con_set_terminal_window): Remove no-op.
1138 (initialize_w32_display): Adjust terminal setup.
1139 * w32term.c (w32_set_terminal_window): Remove no-op.
1140 (w32_create_terminal): Adjust terminal setup.
1141 * xterm.c (XTset_terminal_window): Remove no-op.
1142 (x_create_terminal): Adjust terminal setup.
1143
a892a94c
DA
11442013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1145
1146 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1147 Remove no-ops.
1148 (ns_create_terminal): Adjust terminal setup.
1149 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1150 Remove no-ops.
1151 (w32_create_terminal): Adjust terminal setup.
1152 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1153 Remove no-ops.
1154 (x_create_terminal): Adjust terminal setup.
1155
cf91889a
DA
11562013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1159 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1160 * dispnew.c (buffer_posn_from_coords):
1161 * window.c (Fwindow_end, displayed_window_lines):
1162 * xdisp.c (redisplay_mode_lines): Use it.
1163
5b0891df
JD
11642013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1165
1166 * fontset.c (face_for_char): Check char in the current face font first
1167 if HAVE_NS (Bug#15138).
1168
0a357e98
MR
11692013-08-31 Martin Rudalics <rudalics@gmx.at>
1170
1171 * window.c (temp_output_buffer_show): Make sure window returned
1172 by display_buffer is live (Bug#15213).
1173
9d7693d7
DA
11742013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1175
1176 Minor cleanup to avoid forward declarations.
1177 * coding.h (struct ccl_spec): Remove forward declaration.
1178 * composite.h (toplevel): Include font.h.
1179 (struct composition_it, struct face, struct font_metrics):
1180 Remove forward declaration.
1181 * dispextern.h (struct image, struct atimer): Likewise.
1182 * emacsgtkfixed.h (struct frame): Likewise.
1183 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1184 * font.h (struct font_driver, struct font, struct glyph_string)
1185 (struct face): Remove forward declaration.
1186 * fontset.h (struct face, struct font): Likewise.
1187 * frame.h (toplevel): Style cleanup.
1188 (enum output_method): Move to...
1189 * termhooks.h (enum output_method): ...here.
1190 (struct glyph, struct frame, struct ns_display_info)
1191 (struct x_display_info, struct w32_display_info):
1192 Remove forward declaration.
1193 * xterm.h (toplevel): Include termhooks.h.
1194 (struct font, struct window, struct glyph_matrix, struct frame)
1195 (struct input_event, struct face, struct image): Remove forward
1196 declaration.
1197 * gtkutil.h (struct _widget_value): Likewise.
1198 * keyboard.h (toplevel): Include termhooks.h.
1199 (struct input_event): Remove forward declaration.
1200
032f7451
DA
12012013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1202
1203 * intervals.c (set_point_from_marker): New function.
1204 * editfns.c (Fgoto_char):
1205 * process.c (Finternal_default_process_filter):
1206 * window.c (select_window_1): Use it.
1207 * buffer.h (set_point_from_marker): Add prototype.
1208
3f940c5a
EZ
12092013-08-29 Eli Zaretskii <eliz@gnu.org>
1210
1211 * w32.c (term_winsock): Call release_listen_threads before calling
1212 WSACleanup.
1213 (_sys_wait_accept): Wait for accept event in a loop with a finite
1214 timeout, instead of waiting indefinitely. Will hopefully avoid
1215 hanging during exit because WSACleanup deadlocks waiting for the
1216 event object to be released. (Bug#14333)
1217
1218 * w32proc.c (release_listen_threads): New function, signals all
1219 the reader threads that listen for connections to stop waiting.
1220
1221 * w32.h (release_listen_threads): Add prototype.
1222
101ed2bb
DA
12232013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1224
1225 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1226 field of new marker (for sanity and safety).
20de2834
DA
1227 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1228 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1229
1f5cf200
DA
12302013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1233 (x_after_update_window_line, x_scroll_bar_create):
1234 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1235 (handle_one_xevent, x_clear_frame_area):
1236 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1237 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1238 * xterm.h (x_clear_area): Adjust prototype.
1239
d2b36813
DA
12402013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1241
1242 Hook scanning and indentation functions to find_newline. This helps
1243 to avoid duplicated code and renders more respect to newline cache.
1244 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1245 * cmds.c (Fforward_line):
1246 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1247 Use find_newline and avoid unnecessary point movements.
1248 * search.c (scan_newline): Implement on top of find_newline.
1249
3ec7babc
SM
12502013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1251
1252 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1253 scoped code (bug#11258).
1254
5ab473cd
JD
12552013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1256
1257 * nsterm.m (last_window): New variable.
1258 (EV_TRAILER2): New macro.
1259 (EV_TRAILER): Call EV_TRAILER2.
1260 (mouseMoved:): Add support for mouse-autoselect-window
1261 on nextstep (Bug#6888).
1262
78779650
AS
12632013-08-28 Andreas Schwab <schwab@suse.de>
1264
1265 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1266 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1267 Remove unused macro definitions.
1268 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1269 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1270 Only define if emacs.
78779650 1271
c3c4768d
DA
12722013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1273
1274 Prefer enum glyph_row_area to int where appropriate.
1275 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1276 Fix comment.
1277 (window_box, window_box_width, window_box_left, window_box_left_offset)
1278 (window_box_right, window_box_right_offset): Adjust prototypes.
1279 * xdisp.c (window_box, window_box_width, window_box_left)
1280 (window_box_left_offset, window_box_right, window_box_right_offset):
1281 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1282 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1283 * nsterm.m (ns_clip_to_row):
1284 * w32term.c (w32_clip_to_row):
1285 * xterm.c (x_clip_to_row): Likewise.
1286
6bdcbfe1
DA
12872013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1288
1289 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1290 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1291
50b13cde
PE
12922013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1295 for portability to hosts where /bin/sh has problems.
1296
f60e429a
DA
12972013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 Redesign redisplay interface to drop global output_cursor.
1300 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1301 (toplevel): Remove declaration of output_cursor.
1302 (set_output_cursor, x_cursor_to): Remove prototype.
1303 * window.h (struct window): New member output_cursor.
1304 (output_cursor_to): New function to replace RIF member.
1305 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1306 (update_text_area, set_window_cursor_after_update): Use it.
1307 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1308 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1309 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1310 * w32term.c (x_update_window_begin, x_update_window_end):
1311 * xterm.c (x_update_window_begin, x_update_window_end):
1312 Adjust to use per-window output cursor.
1313
43aac990
PE
13142013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1315
d486344e
PE
1316 Simplify SELECT_TYPE-related code.
1317 Like EMACS_TIME, this portability layer is no longer needed, since
1318 Emacs has been using fd_set as a portability layer for some time.
1319 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1320 (SELECT_TYPE): Remove. All uses changed to fd_set.
1321 (fd_set) [!FD_SET]: New typedef.
1322
43aac990
PE
1323 Simplify EMACS_TIME-related code.
1324 This portability layer is no longer needed, since Emacs has been
1325 using struct timespec as a portability layer for some time.
1326 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1327 Include <time.h> rather than "systime.h"; that's all that's needed now.
1328 * dispnew.c: Include <timespec.h> rather than "systime.h";
1329 that's all that's needed now.
1330 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1331 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1332 TIMESPEC_RESOLUTION.
1333 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1334 LOG10_TIMESPEC_RESOLUTION.
1335 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1336 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1337 (make_emacs_time): Remove. All used changed to make_timespec.
1338 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1339 (current_timespec): Rename from current_emacs_time. All uses changed.
1340 (add_emacs_time): Remove. All uses changed to timespec_add.
1341 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1342 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1343 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1344 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1345 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1346 (current_timespec): Rename from current_emacs_time. All uses changed.
1347 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1348 changed to timespec_cmp.
1349 * xgselect.c: Include <timespec.h>, since our .h files don't.
1350
d350e350
DA
13512013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1352
1353 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1354 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1355 Remove the leftovers.
1356 * gtkutil.c (toplevel): Do not declare Qxft but include
1357 font.h to do so.
1358 * image.c (toplevel): Do not declare Vlibrary_cache because
1359 it's already done in lisp.h.
1360
9fed9729
DA
13612013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1362
1363 * lisp.h (Mouse_HLInfo): Move from here...
1364 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1365 (reset_mouse_highlight): New function.
1366 * msdos.c (dos_set_window_size, IT_update_begin)
1367 (internal_terminal_init):
1368 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1369 (ns_initialize_display_info):
1370 * w32console.c (initialize_w32_display):
1371 * w32term.c (x_update_window_end, x_free_frame_resources)
1372 (w32_initialize_display_info):
1373 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1374 * window.c (Fdelete_other_windows_internal):
1375 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1376 * termchar.h (toplevel):
1377 * xterm.h (toplevel): Include dispextern.h.
1378
f462f075
PE
13792013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 Fix minor problems found by static checking.
1382 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1383 (expect): Avoid nested-if warning.
1384 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1385 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1386 * nsterm.h, nsterm.m (ns_select):
1387 * xgselect.c, xgselect.h (xg_select):
1388 Adjust signature to better match pselect's.
1389 * nsterm.m (ns_select):
1390 Don't set *TIMEOUT, since pselect doesn't.
1391 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1392 diagnostic about assigning const char * to it.
1393 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1394
068f9124
SM
13952013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1396
1397 * lread.c (substitute_object_recurse): Handle hash-tables as well
1398 (bug#15190).
1399
f5adc984
PE
14002013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1401
1fc8eb33
PE
1402 Fix unlikely core dump in init_tty, and simplify terminfo case.
1403 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1404 The old version incorrectly dumped core if malloc returned a
1405 buffer containing only non-NUL bytes.
1406 (init_tty): Do not allocate or free termcap buffers; the
1407 struct does that for us now.
1408 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1409 (struct tty_display_info): Define members termcap_term_buffer and
1410 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1411 use them. Allocate them directly in struct rather than indirectly
1412 via a pointer, to simplify init_tty.
1413
f5adc984
PE
1414 * frame.c (check_minibuf_window): Initialize 'window' properly,
1415 so that Emacs reliably aborts later if 'window' is not initialized.
1416
efec3894
JD
14172013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1418
1419 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1420 of VoidSymbol (Bug#15154).
1421
e1d0341e
DA
14222013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1423
1424 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1425 mouse_face_beg_y and mouse_face_end_y.
1426 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1427 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1428 Adjust users and update comment where appropriate.
1429
bfff6445
MR
14302013-08-26 Martin Rudalics <rudalics@gmx.at>
1431
1432 * frame.c (check_minibuf_window): New function.
068f9124
SM
1433 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1434 Call check_minibuf_window (Bug#15183).
bfff6445 1435
c80016b3
DA
14362013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1437
1438 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1439 because this is the only last cursor data we need to keep and consult.
1440 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1441 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1442 Adjust users.
1443
de396731
DA
14442013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1445
068f9124
SM
1446 Fix recovering from possible decompression error.
1447 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1448 the position where the partially decompressed data ends, and
447218dd 1449 should count how many bytes was produced so far.
de396731
DA
1450 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1451 (unwind_decompress): Really delete partially uncompressed data.
1452 (Fzlib_decompress_region): Take decompressed data size into account.
1453
c76826d9
DA
14542013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1455
1456 * syntax.c (init_syntax_once): Adjust comment and do an early
1457 initialization of Qchar_table_extra_slots just once...
1458 * casetab.c (init_casetab_once):
1459 * category.c (init_category_once):
1460 * character.c (syms_of_character):
1461 * coding.c (syms_of_coding):
1462 * xdisp.c (syms_of_xdisp): ...and omit it here.
1463
b34454d0
EZ
14642013-08-24 Eli Zaretskii <eliz@gnu.org>
1465
11f20add
EZ
1466 * xdisp.c (get_next_display_element): Don't apply to characters
1467 from a display vector the logic of setting it->end_of_box_run_p
1468 suitable for characters from a buffer. (Bug#15175)
1469
b34454d0
EZ
1470 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1471 to handle directories, rather than '_utime' which doesn't.
1472 (Bug#15176)
1473
6e1b469e
JD
14742013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1475
1476 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1477 or fullscreen (Bug#14627).
1478
9c05bccf
PE
14792013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 System-dependent integer overflow fixes.
1482 * process.c (Fset_process_window_size): Signal an error if
1483 the window size is outside the range supported by the lower level.
1484 * sysdep.c (set_window_size): Return negative on error,
1485 nonnegative on success, rather than -1, 0, 1 on not in system,
1486 failure, success. This is simpler. Caller changed.
1487 (serial_configure): Remove unnecessary initialization of local.
1488 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1489 size fits in unsigned long; this isn't true on some 32-bit hosts.
1490 Avoid buffer overrun if some future version of /proc/meminfo has a
1491 variable name longer than 20 bytes.
1492 (system_process_attributes) [__FreeBSD__]:
1493 Don't assume hw.availpages fits in 'int'.
1494
c365c355
PE
14952013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1496
1497 Don't let very long directory names overrun the stack.
1498 Fix some related minor problems involving "//", vfork.
1499 * callproc.c (encode_current_directory): New function.
1500 (call_process): Don't append "/"; not needed.
1501 * fileio.c (file_name_as_directory_slop): New constant.
1502 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1503 this can save the caller having to alloca.
1504 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1505 Use SAFE_ALLOCA, not alloca.
1506 (directory_file_name, Fexpand_file_name): Leave leading "//"
1507 alone, since it can be special even on POSIX platforms.
1508 * callproc.c (call_process):
1509 * process.c (Fformat_network_address):
1510 * sysdep.c (sys_subshell):
1511 Use encode_current_directory rather than rolling our own.
1512 (create_process): No need to encode directory; caller does that now.
1513 * process.h (encode_current_directory): New decl.
1514 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1515 Rework to avoid 'goto xyzzy;'.
1516
6c6014d4
EZ
15172013-08-23 Eli Zaretskii <eliz@gnu.org>
1518
1519 * xdisp.c (handle_face_prop): If the default face was remapped use
1520 the remapped face for strings from prefix properties. (Bug#15155)
1521
9997ec56
DA
15222013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1523
1524 Minor cleanup for redisplay interface and few related functions.
1525 * frame.h (enum text_cursor_kinds): Move from here...
1526 * dispextern.h (enum text_cursor_kinds): ...to here.
1527 (toplevel): Drop unnecessary declarations.
1528 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1529 in update_window_end_hook and draw_window_cursor functions.
1530 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1531 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1532 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1533 * xterm.c (x_update_window_end, x_draw_window_cursor):
1534 * xdisp.c (display_and_set_cursor, update_window_cursor)
1535 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1536 enum text_cursor_kinds where appropriate.
1537
7f780da6
DA
15382013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 Redesign redisplay interface to drop updated_row and updated_area.
1541 * dispextern.h (updated_row, updated_area): Remove declaration.
1542 (struct redisplay_interface): Pass glyph row and row area parameters
1543 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1544 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1545 Adjust prototypes.
1546 * dispnew.c (updated_row, updated_area): Remove.
1547 (redraw_overlapped_rows, update_window_line): Adjust user.
1548 (update_marginal_area, update_text_area): Likewise. Pass updated row
1549 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1550 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1551 Adjust users.
1552
26495794
PE
15532013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * process.c (flush_pending_output): Remove stub.
1556 All uses removed.
1557
4a88129a
PE
15582013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 * callproc.c: Fix race that killed background processes (Bug#15144).
1561 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1562 Record deleted process-id in critical section, not afterwards.
1563 Don't mistakenly kill process created by a call-process invocation
1564 that discards output and does not wait.
1565
0c5307b0
DA
15662013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1567
1568 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1569 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1570 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1571 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1572 to shut up compiler in mark_object.
1573 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1574
0d7c1e66
PE
15752013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1578 We can't portably rely on PTY_OPEN doing that, even if
1579 it calls posix_openpt with O_CLOEXEC.
1580
3f246b65
KH
15812013-08-20 Kenichi Handa <handa@gnu.org>
1582
1583 * character.c (string_char): Improve commentary.
1584
8c2f38aa
PE
15852013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1588 (struct animation_cache): Make signature a flexible array member.
1589 All uses changed. This is a tad slower but may insulate us better
1590 from future changes to ImageMagick.
1591
bb566cea
PE
15922013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 * image.c: Shrink memory needed for animation cache.
1595 (SIGNATURE_DIGESTSIZE): New constant.
1596 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1597 (imagemagick_create_cache): Copy the signature. This saves
1598 several KB of memory that ImageMagick wastes per signature.
1599 Don't bother updating the update_time, as the caller does that now.
1600 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1601 it's a fixed size struct member now.
1602 (imagemagick_get_animation_cache): Always destroy the signature,
1603 as it's now imagemagick_create_cache's responsibility to copy it.
1604 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1605 and use memcmp rather than strcmp.
1606 eassert that ImageMagick returns a signature of the specified length.
1607
6da26928
LMI
16082013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1609
1610 * image.c (imagemagick_get_animation_cache): Don't segfault on
1611 each invocation.
453f4022
LMI
1612 (imagemagick_get_animation_cache): Revert to previous definition
1613 so that it actually works. But keep the memory leak fix.
1614 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1615
22490125
PE
16162013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1617
d0139df5
PE
1618 * image.c: Fix animation cache signature memory leak.
1619 Fix some other minor performance problems while we're at it.
1620 (imagemagick_create_cache): Clear just the members that
1621 need clearing. Don't set update_time, as caller does that now.
1622 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1623 Simplify by using pointer-to-pointer instead of a prev pointer.
1624 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1625 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1626 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1627 it's already a copy. Free the signature probe unless it's cached.
1628
22490125
PE
1629 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1630 This was introduced by my 2013-08-12 fix for Bug#15035.
1631
deb31e75
DA
16322013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1633
1634 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1635 (imagemagick_prune_animation_cache): Now static.
1636
319a4d03
LMI
16372013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1638
1639 * image.c (imagemagick_get_animation_cache): Don't segfault when
1640 pruning all entries.
1641
f747d82e
KB
16422013-08-18 Ken Brown <kbrown@cornell.edu>
1643
1644 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1645 static heap if ENABLE_CHECKING is defined.
1646 (max_bss_sbrk_ptr): New variable.
1647 (bss_sbrk): Use it.
1648 (report_sheap_usage): Report maximum static heap usage instead of
1649 ending static heap usage.
1650
d2c28fab
EZ
16512013-08-17 Eli Zaretskii <eliz@gnu.org>
1652
1653 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1654 of zlib_initialized according to the results of calling
1655 init_zlib_functions.
1656
274ff63f
LMI
16572013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1658
1659 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1660 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1661 (imagemagick_load_image): Remove the ping_wand code, which only
1662 apparently saved time on invalid animated images, and slowed down
1663 everything else. Optimise for the common case.
274ff63f 1664
2bede2ed
XF
16652013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1666
70ff8240
XF
1667 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1668
de179a3e
XF
1669 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1670
2bede2ed
XF
1671 * marker.c (set_marker): Remove documentation of undefined behavior.
1672
703dbeba
LMI
16732013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1674
1675 * image.c (imagemagick_compute_animated_image): Animate correctly
1676 when sub-images are smaller than the main image.
1d18b1e6
LMI
1677 (imagemagick_compute_animated_image): Setting the iterator row to
1678 zero is apparently not allowed.
79670014
LMI
1679 (imagemagick_compute_animated_image): Allow images that say they
1680 have sub-images that are bigger than the main image, but just crop
1681 them.
703dbeba 1682
63216c5e
JD
16832013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1684
1685 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1686
a5b5f73f
LMI
16872013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1688
1689 * image.c (imagemagick_compute_animated_image): Respect the GIF
1690 disposal methods.
1691
0fe73012
KB
16922013-08-15 Ken Brown <kbrown@cornell.edu>
1693
1694 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1695 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1696 needed.
1697
691a357f
PE
16982013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 Fix minor problems found by static checking.
1701 * frame.c (delete_frame):
1702 * xdisp.c (next_element_from_display_vector):
1703 Avoid uninitialized local.
1704 * image.c (imagemagick_compute_animated_image): Port to C89.
1705 Prefer usual GNU indentation style for loops.
1706 Be more careful about bizarrely large sizes, by using ptrdiff_t
1707 instead of int.
1708
42fe2e88
DA
17092013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1710
1711 Fix infinite frame selection loop (Bug#15025).
1712 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1713
d39a3da6
EZ
17142013-08-15 Eli Zaretskii <eliz@gnu.org>
1715
068f9124
SM
1716 * xdisp.c (compute_window_start_on_continuation_line):
1717 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1718 to make sure we end up setting the window start at the leftmost
1719 visible character of the display line. This avoids funky
1720 horizontal shifting because the window start is not kept on the
1721 same position. (Bug#15090)
05426239
EZ
1722 (next_element_from_display_vector): Support 'box' face attribute
1723 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1724
6e856b69
LMI
17252013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1726
1727 * image.c (imagemagick_compute_animated_image): Implement animated
1728 images (bug#14700).
995be755
LMI
1729 (imagemagick_compute_animated_image): Fix some compilation
1730 warnings. Implement a very simple cache to make the animation
1731 usable at all, but it should be replaced with a per-image cache.
6e856b69 1732
d5a1acfa
DA
17332013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1734
1735 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1736 to do `for' loops over alist values.
1737 * buffer.h (FOR_EACH_BUFFER):
1738 * process.c (FOR_EACH_PROCESS): Use it.
1739 (handle_child_signal, status_notify, Fget_buffer_process)
1740 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1741
9c253307
DA
17422013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1743
1744 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1745 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1746 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1747 to xzalloc and so avoid redundant call to memset.
1748 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1749 members because it is allocated with xzalloc and so already zeroed.
1750
05e64f9f
KB
17512013-08-14 Ken Brown <kbrown@cornell.edu>
1752
1753 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1754 (Bug#15094).
1755
5b71542d
DA
17562013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1757
1758 Utility function and macro to copy Lisp string to C string.
1759 * lisp.h (xlispstrdupa): New macro.
1760 (xlispstrdup): New prototype.
1761 * alloc.c (xlispstrdup): New function.
1762 * callint.c (Fcall_interactively):
1763 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1764 (Fsubstitute_in_file_name):
1765 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1766 * image.c (x_create_bitmap_from_file):
1767 * w32term.c (w32_term_init):
1768 * xterm.c (x_term_init): Use xlispstrdup.
1769
71530c97
LMI
17702013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1771
4ce82fb8
LMI
1772 * image.c (imagemagick_load_image): Make animated pictures work.
1773 There's still some problems with background color settings, though
1774 (bug#14700).
1775
71530c97
LMI
1776 * decompress.c (unwind_decompress): Always restore point.
1777
7510a061
XF
17782013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1779
1780 * marker.c (set_marker): Reformat documentation.
1781
01c3051f
PE
17822013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1783
aab1fcdf
PE
1784 * xdisp.c (cursor_type_changed): Now static.
1785
01c3051f
PE
1786 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1787 Use changed. This avoids the need to call xmalloc and for the
1788 caller to call xfree, and avoids memory leaks in some situations.
1789
2084152a
DA
17902013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1791
1792 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1793 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1794 (redisplay_window): If window_end_valid is cleared due to non-zero
1795 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1796 so do not call to try_cursor_movement for that window.
2084152a 1797
02455cb6
DA
17982013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1799
1800 * window.h (struct window): Convert window_end_pos and
1801 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1802 (wset_window_end_pos, wset_window_end_vpos): Remove.
1803 * dispnew.c (adjust_glyph_matrix):
1804 * window.c (Fwindow_end, replace_window, set_window_buffer)
1805 (make_window):
1806 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1807 (set_vertical_scroll_bar, redisplay_window, try_window)
1808 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1809 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1810 (note_mouse_highlight): Adjust users.
1811 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1812 Add comment.
1813
da5707e8
DA
18142013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1815
1816 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1817 * image.c (imagemagick_filename_hint): Use `const char *' and
1818 prefer SSDATA to SDATA to avoid warnings.
1819
25554267
DA
18202013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1821
1822 Cleanup window fringes, margins and scroll bars adjustments.
1823 * window.c (set_window_fringes, set_window_margins)
1824 (set_window_scroll_bars, apply_window_adjustment): New functions.
1825 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1826 (Fset_window_scroll_bars): Use them.
1827
38a2c910
DA
18282013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1829
1830 * window.h (struct window): Convert scroll_bar_width
1831 from Lisp_Object to integer. Adjust comment.
1832 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1833 Adjust users.
1834 * window.c (wset_scroll_bar_width): Remove.
1835 (make_window): Initialize scroll_bar_width.
1836 (Fsplit_window_internal): Use direct assignment.
1837 (Fset_window_configuration, save_window_save):
1838 Convert Lisp_Object to integer and back where appropriate.
1839 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1840 bar was actually changed, and mention this in docstring.
1841
2d065031
PE
18422013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 * decompress.c: Minor simplifications.
1845 (Fzlib_decompress_region): Don't bother verifying
1846 that avail_out <= UINT_MAX, as that was confusing.
1847 Mention the restriction in a comment instead.
1848 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1849
a5bd5abb
JD
18502013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1851
1852 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1853 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1854
66e7901a
LMI
18552013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1856
1857 * image.c (imagemagick_filename_hint): Check for errors in the
1858 alist structure.
1859
2fa611b7
EZ
18602013-08-13 Eli Zaretskii <eliz@gnu.org>
1861
1862 * window.c (Fwindow_margins): Return nil when there's no marginal
1863 area, as per the documented API.
1864
1865 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1866 Fmake_vector, as scroll bar's struct members are not all Lisp
1867 objects now. This avoids crashes in GC.
1868
1869 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1870 bool, so its address could be taken.
1871
8259030d
LMI
18722013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1873
1874 * image.c (imagemagick_filename_hint): New function to possibly
1875 apply `image-content-type-suffixes'.
1876 (imagemagick_load_image): Use it.
1877
866c710e
EZ
18782013-08-13 Eli Zaretskii <eliz@gnu.org>
1879
1880 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1881 if loading zlib failed.
1882
f10490f0
JD
18832013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1884
96311be7
JD
1885 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1886 2013-08-13 checkin below. Change bool to BOOL, rule is:
1887 All Obj-C code uses BOOL, except for interfaces callable from C.
1888
f10490f0
JD
1889 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1890
c8ae93b0
DA
18912013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1892
1893 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1894 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1895 bool instead of BOOL.
1896 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1897 from Lisp_Object to bitfield. Adjust comment.
1898 * w32term.c (x_scroll_bar_create): Adjust user.
1899 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1900 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1901 Use bool for boolean.
1902 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1903 to `unsigned int' when defining a bitfield.
1904
53b64418
PE
19052013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1908
eeaf9bf3
DA
19092013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1910
1911 * window.h (struct window): Convert left_margin_cols and
1912 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1913 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1914 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1915 Adjust users.
1916 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1917 Adjust comment.
1918 (showing_window_margins_p, update_window_line, update_frame_1):
1919 * fringe.c (draw_fringe_bitmap_1):
1920 * xdisp.c (window_box_width): Adjust users.
1921 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1922 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1923 Use direct assignment.
1924 (Fset_window_configuration, save_window_save, Fwindow_margins):
1925 Convert Lisp_Object to integer and back where appropriate.
1926 (Fset_window_margins): Adjust user. Return t if any margin
1927 was actually changed, and mention this in docstring.
1928
956720af
XF
19292013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1930
f73f4ce6 1931 * syntax.c (forward_word):
956720af
XF
1932 * cmds.c (forward_char, backward_char): Mention the optional argument.
1933
9e37ee3b
DA
19342013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1935
1936 * window.h (struct window): Convert left_fringe_width
1937 and right_fringe_width from Lisp_Objects to integers.
1938 Adjust comment.
1939 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1940 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1941 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1942 Remove.
1943 (make_window): Initialize new integer fields to -1.
1944 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1945 (Fset_window_configuration, save_window_save):
1946 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1947 (Fset_window_fringes): Adjust user. Return t if any fringe
1948 was actually changed, and mention this in docstring.
1949
e4375ca7
DA
19502013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1951
1952 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1953 * nsfns.m (x_set_cursor_type):
1954 * w32fns.c (x_set_cursor_type):
1955 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1956 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1957
a45543bc
DA
19582013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1959
1960 * font.c (clear_font_cache): New function, stripped from...
1961 (Fclear_font_cache): ...here, which now uses the function
1962 above. Adjust comment.
1963 * font.h (clear_font_cache): Add prototype.
1964 * xfaces.c (clear_face_cache): Use clear_font_cache.
1965
ae966a86
DA
19662013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1967
1968 * window.c (Fset_window_start): Compare `w', not `window' because
1969 `w' might not be equal to `window' after call to decode_live_window.
1970
297a545b
PE
19712013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1972
1973 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1974 This fixes a problem introduced by the Bug#15035 patch
1975 when using GPG. Reported by Herbert J. Skuhra.
1976
aa942e2b
EZ
19772013-08-12 Eli Zaretskii <eliz@gnu.org>
1978
1979 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1980 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1981 not yet initialized.
1982
7699d09e
LMI
19832013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1984
1985 * decompress.c (Fzlib_decompress_region): Support zlib
1986 decompression, too, and rename.
1987
1d238bc7
PE
19882013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1989
1990 Minor zlib configuration tweaks.
1991 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1992 Don't assume presence of fn_inflateInit2_ zlib internal function.
1993
8a44a184
LMI
19942013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1995
1996 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1997 include the zlib prefix.
1998
594a4307
EZ
19992013-08-12 Eli Zaretskii <eliz@gnu.org>
2000
2001 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
2002 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
2003 define static variables that are pointers to zlib functions to be
2004 dynamically loaded.
2005 (init_zlib_functions) [WINDOWSNT]: New function.
2006 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
2007 New macros.
2008 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
2009 macros instead of invoking the zlib functions directly.
068f9124
SM
2010 (syms_of_decompress): DEFSYM Qzlib_dll.
2011 Staticpro Szlib_available_p.
594a4307 2012
d2e113bc
DA
20132013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
2014
2015 Avoid looping over all frame windows to freeze and unfreeze.
2016 * window.h (struct window): Drop frozen_window_start_p.
2017 (freeze_window_starts): Drop prototype.
2018 * frame.h (struct frame): New frozen_window_starts flag.
2019 (FRAME_WINDOWS_FROZEN): New macro.
2020 * window.c (freeze_window_start, freeze_window_starts):
2021 Remove.
2022 (select_window, replace_window): Adjust users.
2023 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2024 (window_frozen_p): New function.
2025 (redisplay_window): Use it.
2026
94fcd171
PE
20272013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2028
2029 Fix some fd issues when running subprocesses (Bug#15035).
2030 Fix bugs that can leak files or file descriptors on errors.
2031 Don't unlink open temp files, as that's hard for users to diagnose
2032 when things go awry (e.g., temp disk exhausted).
2033 Don't bother to lock temp files. Check for invalid recursion.
2034 * callproc.c (synch_process_fd): Remove. All uses removed.
2035 (synch_process_tempfile): New var or macro.
2036 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2037 New constants.
2038 (record_kill_process): New arg, the temp name. All callers changed.
2039 (delete_temp_file): Now just a simple wrapper around unlink.
2040 (call_process_kill): New arg, the call_process_fd array.
2041 Close them all. Clear synch_process_pid. Remove the temp file,
2042 or arrange for it to be removed.
2043 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2044 that's been moved to synch_process_tempfile. Caller changed.
2045 Do not remove the tempfile; that's now call_process_kill's
2046 responsibility.
2047 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2048 call_process_kill; the caller now does that.
2049 (call_process_cleanup): Do not close the process fd; that's now
2050 call_process_kill's responsibility.
2051 (Fcall_process): Implement via new function call_process, which
2052 has most of the old body of Fcall_process, but with a different API.
2053 (call_process): New function that does not open or close filefd if
2054 it is nonnegative. Record which fds need to be closed, and let
2055 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2056 Signal an error if invoked recursively (could be done via a hook).
2057 Simplify creation of the tempfile in the MSDOS case.
2058 Don't create the output file until after checking for the executable.
2059 Report any failure to open /dev/null.
2060 Don't open /dev/null for writing twice; once is enough.
2061 Don't create pipe if all output is being discarded or sent to file.
2062 Don't worry about setting up the coding system or reading from the
2063 pipe if all output is being discarded.
2064 Hoist fd_error local into top level, to lessen block nesting.
2065 Don't record deleted pid here; now done by Fcall_process_region.
2066 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2067 and note its success in synch_process_tempfile.
2068 Do not leak resources when child_setup fails.
2069 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2070 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2071 (create_temp_file): Now returns open fd, with an additional
2072 Lisp_Object * argument to return the name. All callers changed.
2073 Do not close the file; rewind it instead, and leave it open for
2074 the caller. Do not lock the temp file. Unwind-protect the file
2075 and the file-descriptor.
2076 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2077 If an asynchrounous process, record it here, not in call_process.
2078 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2079 * eval.c (set_unwind_protect): New function.
2080 * fileio.c (write_region): New function, generalized from the
2081 old Fwrite_region. Do not lock temp files.
2082 (Fwrite_region): Use it.
2083 * lisp.h (set_unwind_protect, write_region): New decls.
2084 * process.c: Include <verify.h>.
2085 (make_process): Mark fds as initially closed.
2086 (deleted_pid_list): Now a list of pid-filename pairs.
2087 All uses changed.
2088 (close_process_fd): New function.
2089 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2090 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2091 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2092 (create_process, create_pty, Fmake_serial_process)
2093 (server_accept_connection): Record which fds need to be closed,
2094 and let deactivate_process close them.
2095 (Fmake_network_process): Do not discard the unwind-protect
2096 until it's safe to do so.
2097 (deactivate_process): Close the fds opened by create_process etc.
2098 (Fprocess_send_eof): Adjust to new way of recording open fds.
2099 Report an error if /dev/null can't be opened, instead of aborting.
2100 * process.h (PROCESS_OPEN_FDS): New constant.
2101 (struct Lisp_Process): New member open_fds.
2102 (record_kill_process, record_deleted_pid): Adjust signatures.
2103 (record_deleted_pid): Move decl here ...
2104 * syswait.h (record_deleted_pid): ... from here.
2105
d0e615c3
PE
21062013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2107
2108 * decompress.c: Fix bugs with large buffers and weird inputs.
2109 Tune a bit. Reindent as per usual Emacs style.
2110 (BUFFER_SIZE): Remove.
2111 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2112 more than UINT_MAX bytes. Decompress into the gap instead of into
2113 an auto buffer, as this should avoid copying. Return nil if
2114 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2115 set immediate_quit; we shouldn't trust zlib code that much.
2116
313546eb
LMI
21172013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2118
99a32242
LMI
2119 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2120 errors, and really move the gap to where we want it.
2121
313546eb
LMI
2122 * lisp.h: Include decompress.c support.
2123
2124 * emacs.c (main): Include decompress.c support.
2125
2126 * Makefile.in: Include -lz if present.
2127
d2d699ac
JD
21282013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2129
f90e3ebd
JD
2130 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2131 (initWithTitle:): Initialize frame to 0.
2132 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2133 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2134 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2135
2136 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2137 fillWithWidgetValue:frame:
2138
423d3b3f
JD
2139 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2140 remove memory leak warnings.
2141
d2d699ac
JD
2142 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2143 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2144 menu_pending_title.
2145
2146 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2147 (x_activate_menubar): Update the whole menu.
2148 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2149 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2150 current event is not NSSystemDefined (Bug#15001).
2151 Call ns_check_menu_open only if trackingMenu is 2.
2152 (menuDidClose:): New method, decrease trackingMenu.
2153 (fillWithWidgetValue:setDelegate:): New method.
2154 (fillWithWidgetValue:): Call the above.
2155
2156 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2157
7d652d97
PE
21582013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 Omit some unnecessary casts.
2161 Many of these go back to the old pre-C89 days, when they may have
2162 been needed, but we've been assuming C89 or later for a while now.
2163 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2164 (live_float_p, live_misc_p, live_vector_p):
2165 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2166 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2167 (defvar_per_buffer):
2168 * callint.c (Fcall_interactively):
2169 * doc.c (Fsubstitute_command_keys):
2170 * filelock.c (get_boot_time):
2171 * frame.c (xrdb_get_resource):
2172 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2173 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2174 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2175 (menuitem_highlight_callback, menu_destroy_callback)
2176 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2177 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2178 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2179 (xg_tool_bar_help_callback, tb_size_cb):
2180 * image.c (xpm_alloc_color, png_read_from_memory)
2181 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2182 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2183 (syms_of_image):
2184 * keymap.c (describe_map):
2185 * nsfns.m (Fns_display_monitor_attributes_list):
2186 * nsmenu.m (process_dialog:):
2187 * nsterm.m (hold_event):
2188 * process.c (wait_reading_process_output):
2189 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2190 * scroll.c (do_direct_scrolling, scrolling_1):
2191 * termcap.c (tgetent):
2192 * window.c (check_window_containing, add_window_to_list)
2193 (freeze_window_starts):
2194 * xdisp.c (compare_overlay_entries, vmessage):
2195 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2196 (x_get_monitor_attributes_xrandr)
2197 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2198 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2199 * xfont.c (xfont_match, xfont_open):
2200 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2201 (menubar_selection_callback, menu_position_func)
2202 (popup_selection_callback, create_and_show_popup_menu)
2203 (dialog_selection_callback, create_and_show_dialog):
2204 * xrdb.c (x_get_string_resource):
2205 (main) [TESTRM]:
2206 * xsmfns.c (x_session_check_input):
2207 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2208 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2209 (xaw_jump_callback, xaw_scroll_callback):
2210 Omit unnecessary casts.
2211
9acc1074
PE
22122013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 Minor string-length refactoring.
2215 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2216 * frame.c (make_monitor_attribute_list):
2217 Prefer build_string to strlen + make_string.
2218
361c0eb8
JD
22192013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2220
2221 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2222 don't check minor_code (Bug#14417).
2223
14ba0822
EZ
22242013-08-09 Eli Zaretskii <eliz@gnu.org>
2225
2226 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2227 vertical positions instead. This avoids calling MATRIX_ROW with
2228 row numbers that are possibly beyond valid limits. (Bug#15064)
2229
309f24d1
DA
22302013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2231
2232 Use xstrdup and build_unibyte_string where applicable.
2233 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2234 * xfns.c (x_window):
2235 * xrdb.c (x_get_customization_string):
2236 * xterm.c (xim_initialize):
2237 * w32fns.c (w32_window): Use xstrdup.
2238 (w32_display_monitor_attributes_list):
2239 * emacs.c (init_cmdargs):
2240 * keyboard.c (PUSH_C_STR):
2241 * nsfont.m (nsfont_open):
2242 * sysdep.c (system_process_attributes):
2243 * w32.c (system_process_attributes):
2244 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2245
55902276
EZ
22462013-08-09 Eli Zaretskii <eliz@gnu.org>
2247
2248 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2249 variables of these types so that GDB would know about them, as aid
2250 for debugging fatal exceptions. (Bug#15024) See also
2251 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2252 discussions.
2253
10bf7f5a
JD
22542013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2255
2256 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2257 larger than the NSWindow (Bug#14934).
2258
65620264
DA
22592013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2260
2261 Redesign redisplay interface to drop global variable updated_window.
2262 Always pass currently updated window as a parameter to update routines.
2263 * dispextern.h (updated_window): Remove declaration.
2264 (struct redisplay_interface): Pass window parameter to
2265 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2266 and after_update_window_hook.
2267 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2268 Adjust prototypes.
2269 * dispnew.c (updated_window): Remove.
2270 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2271 (update_window_line): Adjust to match redisplay interface changes.
2272 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2273 (ns_scroll_run, ns_after_update_window_line):
2274 * w32term.c (x_update_window_begin, x_update_window_end)
2275 (x_after_update_window_line, x_scroll_run):
2276 * xterm.c (x_update_window_begin, x_update_window_end)
2277 (x_after_update_window_line, x_scroll_run):
2278 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2279 Likewise. Adjust comments where appropriate.
2280 (x_cursor_to): Simplify because this is always called during window
2281 update (but install debugging check anyway).
2282 (expose_window): Check must_be_updated_p flag to see whether this
2283 function is called during window update.
2284
628fdc56
DA
22852013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2286
2287 Do not reset window modification event counters excessively.
2288 These leftovers and poor man's tricky methods to catch extra
2289 redisplay's attention are no longer needed.
2290 * frame.c (set_menu_bar_lines_1):
2291 * minibuf.c (read_minibuf_unwind):
2292 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2293 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2294 (window_scroll_line_based, Fset_window_configuration):
2295 * xdisp.c (redisplay_window): Do not reset last_modified and
2296 last_overlay_modified counters.
2297
8fd9c92e
JD
22982013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2299
2300 * xselect.c (x_send_client_event): Set send_event and serial, memset
2301 data.l as it might be bigger than data.b. Use 24 bit mask to
2302 XSendEvent (Bug#15034).
2303
0ee18172
EZ
23042013-08-07 Eli Zaretskii <eliz@gnu.org>
2305
2306 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2307 for TTY frames that are not the top frame on their console.
2308 (Bug#14616)
2309
16ddd1a6
MR
23102013-08-07 Martin Rudalics <rudalics@gmx.at>
2311
2312 * w32term.c (w32fullscreen_hook): Really maximize frame when
2313 asked for (Bug#14841).
2314
d2a95ffb
DA
23152013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2316
2317 Prefer selected_window to Fselected_window, likewise for frames.
2318 * buffer.c (Fbuffer_swap_text):
2319 * data.c (Fvariable_binding_locus):
2320 * window.c (run_window_configuration_change_hook): Adjust users.
2321 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2322 Use decode_live_frame.
2323
170da1ec
DA
23242013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2325
2326 Be more careful if selected window shows the buffer other than current,
2327 use window_outdated only if this is not so. This change should also
2328 address some weird issues discussed in Bug#13012.
2329 * window.h (window_outdated): New prototype.
2330 * window.c (window_outdated): Now here. Convert from static and
2331 always assume window's buffer.
2332 (Fwindow_end, Fwindow_line_height): Use it.
2333 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2334 and always assume window's buffer.
2335 (redisplay_window): Adjust user.
e5eefe9b 2336 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2337 check whether mode line should be updated only if selected window
2338 shows current buffer.
2339 (run_window_scroll_functions): Use eassert for debugging check.
2340 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2341
56b5d5b1
DA
23422013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2343
2344 * window.c (window_scroll, window_scroll_pixel_based)
2345 (window_scroll_line_based): Use bool for booleans.
2346
2878ba7e
PE
23472013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 * process.c: Fix minor off-by-one issues in descriptor counts.
2350 This shouldn't fix any real bugs, but it cleans up the code a bit.
2351 (max_process_desc, max_input_desc): -1, not 0, means none.
2352 All uses changed.
2353 (delete_input_desc): New function.
2354 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2355 (deactivate_process): Scan backwards when recomuting max_process_desc;
2356 that should be faster.
2357 (init_process_emacs): Initialize max_input_desc.
2358
e30b79c1
DA
23592013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2360
2361 Use region cache to speedup bidi_find_paragraph_start.
2362 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2363 Rename cache_long_line_scans to cache_long_scans.
2364 * buffer.c (bset_cache_long_line_scans): Rename to
2365 bset_cache_long_scans.
2366 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2367 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2368 into account.
2369 (syms_of_buffer): Rename cache-long-line-scans to
2370 cache-long-scans. Adjust docstring.
2371 * search.c (newline_cache_on_off):
2372 * indent.c (width_run_cache_on_off): Adjust users.
2373 * bidi.c (bidi_paragraph_cache_on_off): New function.
2374 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2375 * insdel.c (prepare_to_modify_buffer):
2376 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2377
00012b86
DA
23782013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2379
2380 Invalidate region caches only if buffer text is going to be changed.
2381 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2382 (modify_text): ...new prototype.
2383 (prepare_to_modify_buffer_1): New prototype.
2384 * textprop.c (modify_region): Rename to...
2385 (modify_text_properties): ...new function.
2386 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2387 (Fremove_list_of_text_properties): Adjust users.
2388 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2389 (modify_text): ...new function.
2390 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2391 (prepare_to_modify_buffer_1): ...new function.
2392 * casefiddle.c (casify_region):
2393 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2394 (Ftranspose_regions): Use modify_text.
2395
dc6c0eda
SM
23962013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2397
2398 * lisp.mk (lisp): Add nadvice.elc.
2399
8f3a2c26
DA
24002013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2401
2402 New macro to iterate over live buffers similar to frames.
2403 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2404 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2405 Declare buffer-related variables here to offload lisp.h.
2406 * buffer.c (Vbuffer_alist): Adjust comment.
2407 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2408 (other_buffer_safely):
2409 * data.c (store_symval_forwarding):
2410 * dispnew.c (Fframe_or_buffer_changed_p):
2411 * fileio.c (Fdo_auto_save):
2412 * filelock.c (unlock_all_files):
2413 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2414
e0fdb694
PE
24152013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2418 * callproc.c (create_temp_file):
2419 * filelock.c (create_lock_file):
2420 Assume mkostemp, since it's now provided by Gnulib.
2421
63f5c6c2
EZ
24222013-08-04 Eli Zaretskii <eliz@gnu.org>
2423
2424 * w32.c (mkostemp): New function.
2425 (mktemp): Remove, no longer used. Most of the code reused in
2426 mkostemp. (Bug#15015)
484ab239 2427 (mktemp): Don't undef.
63f5c6c2 2428
f0b79313
DA
24292013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2430
2431 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2432 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2433 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2434 (free_glyph_pool, check_glyph_memory): Likewise for
2435 all users. Adjust comments where appropriate.
2436
98f638d6
PE
24372013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * composite.h: Minor fixups.
2440 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2441 to fix a misspelling, and change it to an inline function while
2442 we're at it (it need not be a macro). All uses changed.
2443 (composition_method, composition_valid_p):
2444 Rewrite to avoid assignments in if-conditions.
2445
75c59fb3
DA
24462013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2447
2448 Do not use global Lisp_Object in composition macros.
2449 * composite.h (composition_temp): Remove declaration.
2450 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2451 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2452 (compose_region): Remove the leftover.
75c59fb3
DA
2453 * composite.c (composition_temp): Remove.
2454 (run_composition_function, update_compositions)
2455 (composition_compute_stop_pos, composition_adjust_point)
2456 (Ffind_composition_internal):
2457 * coding.c (handle_composition_annotation):
2458 * xdisp.c (handle_composition_prop, check_point_in_composition):
2459 Related users changed.
2460
a10c8269
DA
24612013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2462
2463 Drop FRAME_PTR typedef.
2464 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2465 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2466 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2467 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2468 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2469 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2470 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2471 All related users changed.
2472
a104f656
SM
24732013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2474
2475 * eval.c (default_toplevel_binding): New function.
2476 (Fdefvar): Use it.
2477 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2478 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2479 (syms_of_eval): Export them.
2480 * data.c (Fdefault_value): Micro cleanup.
2481 * term.c (init_tty): Use "false".
2482
4b5c9326
DA
24832013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2484
2485 Fix X GC leak in GTK and raw (no toolkit) X ports.
2486 * xterm.c (x_free_frame_resources): If white and black relief
2487 GCs are allocated, always free them here.
2488 * xfns.c (x_make_gc): Omit redundant initialization.
2489 * widget.c (create_frame_gcs): Remove the leftover.
2490 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2491 in x_free_frame_resources.
2492
b19aa636
JD
24932013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2494
2495 * nsterm.m (windowWillResize:toSize:): Only change title if
2496 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2497 modifying it.
2498 (viewDidEndLiveResize): New method.
2499
2500 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2501 inside NS_IMPL_COCOA.
2502
af1f7e06
DA
25032013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2504
2505 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2506 Do not check whether undo is enabled because record_insert and
2507 record_delete does that themselves.
2508
65b02bb9
DA
25092013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2510
2511 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2512 member which is not really used any more.
2513 (FRAME_XIC_BASE_FONTNAME): Remove.
2514 * xfns.c (xic_free_fontset): Adjust user.
2515 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2516 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2517 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2518 (xdialog_show): Use eassert for debugging check.
7ee0f047 2519 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2520
6318cde0
PE
25212013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2522
2523 * fileio.c, fns.c (merge): Move extern decl from here ...
2524 * lisp.h (merge): ... to here.
2525
6c1a09ba
DA
25262013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2527
2528 Fix last font-related change.
2529 * w32font.h (w32font_list_internal, w32font_match_internal):
2530 Fix prototype.
2531 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2532 (uniscribe_list_family): Adjust to match font API change.
2533 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2534 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2535
f8c20208
DA
25362013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2537
2538 * frame.h (FRAME_MOUSE_UPDATE):
2539 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2540 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2541
fdb396e2
DA
25422013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2543
2544 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2545 * font.h (struct font_driver): Change list, match, and list_family
2546 functions to accept struct frame * as first arg.
068f9124
SM
2547 * font.c (font_score, font_compare, font_sort_entities):
2548 Remove prototypes.
fdb396e2
DA
2549 (font_sort_entities, font_list_entities, font_select_entity):
2550 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2551 match font API change.
2552 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2553 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2554 * ftxfont.c (ftxfont_list, ftxfont_match):
2555 * xftfont.c (xftfont_list, xftfont_match):
2556 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2557 * w32font.c (w32font_list, w32font_match, w32font_list):
2558 (w32font_list_internal, w32_font_match_internal): Likewise.
2559 * xfaces.c (Fx_family_fonts): Adjust user.
2560
52b8a085
DA
25612013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2562
2563 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2564 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2565 only if HAVE_X_WINDOWS is in use.
2566 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2567 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2568 * w32term.c (x_wm_set_icon_position): Likewise.
2569 * w32fns.c (x_icon): Adjust user.
2570
c791c18e
DA
25712013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2572
2573 * xterm.c (last_mouse_press_frame): Remove the
2574 leftover which is not really used any more.
2575 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2576 (x_flush): Call XFlush once per each X display, not frame.
2577 This is better because this code always unconditionally skips
2578 non-X frames in Vframe_list and issues the only XFlush if we
2579 have more than one X frame on the same X display.
2f935d86
DA
2580 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2581 Use bool for booleans.
2582 (x_draw_glyph_string_background, cvt_string_to_pixel):
2583 (cvt_pixel_dtor): Drop unnecessary prototypes.
2584 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2585
f435830e
DA
25862013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2587
2588 Drop unnecessary functions that deals with frame pixel size.
2589 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2590 (x_pixel_height): Drop prototypes.
2591 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2592 (x_pixel_height): Drop implementations.
2593 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2594 which should be always valid for window frame.
2595 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2596 * w32menu.c (Fx_popup_dialog):
2597 * xmenu.c (Fx_popup_dialog): Likewise for both.
2598
84231434
DA
25992013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2600
2601 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2602 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2603 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2604 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2605 and mention nil frame in docstring.
84231434 2606
959067a1
DA
26072013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2608
2609 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2610 (x_figure_window_size): Likewise. Adjust to return long.
2611 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2612 (toplevel): Move Qterminal_live_p to...
2613 * terminal.c (toplevel): ...here, make it static, and...
2614 (syms_of_terminal): ...DEFSYM here.
2615 * frame.h (Qterminal_live_p): Remove declaration.
2616 (make_frame, x_figure_window_size): Adjust prototype.
2617 * nsfns.m (Fx_create_frame): Use long for window flags.
2618
f4b169ce
PE
26192013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2620
2621 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2622 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2623 Do not assume that emacs_close (INT_MAX) is a no-op.
2624
bee6a2c7
DA
26252013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2626
2627 * xfaces.c (make_face_cache): For struct face_cache, prefer
2628 xmalloc to xzalloc and so avoid redundant call to memset.
2629 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2630
d7e6881a
DA
26312013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2632
2633 * fringe.c (draw_window_fringes, update_window_fringes)
2634 (compute_fringe_widths):
2635 * w32term.c (x_draw_glyph_string):
2636 * window.c (candidate_window_p, Frecenter):
2637 * xfaces.c (realize_basic_faces, realize_default_face)
2638 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2639 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2640 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2641 * xmenu.c (Fx_menu_bar_open_internal):
2642 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2643 * xsettings.c (xft_settings_event):
2644 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2645 Use bool for booleans. Adjust style and comments where
2646 appropriate.
2647 * dispextern.h (draw_window_fringes, update_window_fringes)
2648 (compute_fringe_widths):
2649 * xterm.h (x_had_errors_p): Adjust prototype.
2650
ec3058af
DA
26512013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2652
2653 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2654 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2655
218e0637
DA
26562013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2657
2658 * fns.c (toplevel): Remove comment before Fsafe_length because
2659 it checks for QUIT.
2660
e560aba9
PE
26612013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2664
2e5ce5de
EZ
26652013-07-28 Eli Zaretskii <eliz@gnu.org>
2666
2667 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2668 frame which got the message is still alive, before dereferencing
2669 its pointer. (Bug#14970)
2670
2671 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2672 be a live window, before using it as such. (Bug#14970)
2673
e95da6d3
EZ
26742013-07-27 Eli Zaretskii <eliz@gnu.org>
2675
2676 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2677 w32_detect_focus_change instead of doing part of its job by hand.
2678 This fixes the problem whereby FOCUS_OUT events were not sent to
2679 the event queue.
2680
a8f93651
EZ
26812013-07-26 Eli Zaretskii <eliz@gnu.org>
2682
fec92060
EZ
2683 * process.c (Fprocess_list): Doc fix.
2684
a8f93651
EZ
2685 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2686 being re-exposed only if it didn't ask to become visible.
2687 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2688 was previously iconified. (Bug#14841)
2689 (x_iconify_frame): Mark the frame iconified.
2690
d5a7a9d9
PE
26912013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 Fix minor problems found by static checking.
2694 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2695 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2696
56ea7291
SM
26972013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2698
2699 * eval.c (set_specpdl_old_value): New function.
2700 (unbind_to): Minor simplification.
2701 (get_backtrace_frame): New function.
2702 (Fbacktrace_frame): Use it. Add `base' argument.
2703 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2704 (syms_of_eval): Export backtrace-eval.
2705 * xterm.c (x_focus_changed): Simplify.
2706
9d611ffe
PE
27072013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2708
2709 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2710
999c74e3
EZ
27112013-07-24 Eli Zaretskii <eliz@gnu.org>
2712
2713 * xdisp.c (redisplay_window): Instead of moving point out of
2714 scroll margin, reject the force_start method, and try scrolling
2715 instead. (Bug#14780)
2716
198fa217
KB
27172013-07-24 Ken Brown <kbrown@cornell.edu>
2718
2719 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2720 (Bug#14944).
2721
53840e55
PE
27222013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 * eval.c (Fprogn): Do not check that BODY is a proper list.
2725 This undoes the previous change. The check slows down the
2726 interpreter, and is not needed to prevent a crash. See
2727 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2728
60967f56
GM
27292013-07-23 Glenn Morris <rgm@gnu.org>
2730
2731 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2732
9ca960e2
PE
27332013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2734
a29c3e6d
PE
2735 Port to GNU/Linux systems with tinfo but not ncurses.
2736 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2737 to decide whether ncurses is being used. Without this change,
2738 GCC complains about tgetent not being declared, on a system
2739 that has tinfo installed but ncurses not installed.
2740
f274311c
PE
2741 * eval.c (Fprogn): Check that BODY is a proper list.
2742
16b0520a
PE
2743 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2744 * data.c (Fsetq_default):
2745 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2746 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2747 (Fcondition_case):
2748 Tune by taking advantage of the fact that ARGS is always a list
2749 when a function is declared to have UNEVALLED args.
2750
9ca960e2
PE
2751 * emacsgtkfixed.c: Port to GCC 4.6.
2752 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2753
afacaa1b
JB
27542013-07-23 Juanma Barranquero <lekktu@gmail.com>
2755
2756 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2757 here to silence compiler warnings.
2758
368a85a4
PE
27592013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2760
2761 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2762 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2763 from messing up Emacs's 'struct frame' (Bug#14923).
2764
f4e891b5
PE
27652013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2766
2767 * alloc.c (make_save_ptr_ptr): Define this function.
2768 It was inadvertently omitted. It's needed only if
2769 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2770
96c8b65e
JD
27712013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2772
2773 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2774 frame have focus (Bug#14895).
2775
ee010797
PE
27762013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2777
2778 Avoid vfork-related deadlock more cleanly.
2779 * callproc.c (child_setup): When the child's exec fails, output
2780 the program name, as that's more useful. Use O_NONBLOCK to avoid
2781 deadlock.
2782 * process.c (create_process_1): Remove; no longer needed.
2783 (create_process): Remove timer hack; no longer needed, now that
2784 the child avoids deadlock.
2785
f0398ec1 27862013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2787
2788 * image.c (Fimage_flush): Fix doc typo.
2789
b2a069c2
PE
27902013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2791
6496aec9
PE
2792 Fix array bounds violation when pty allocation fails.
2793 * process.c (PTY_NAME_SIZE): New constant.
2794 (pty_name): Remove static variable; it's now auto.
2795 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2796 Take pty_name as an arg rather than using a static variable.
2797 All callers changed.
2798 (create_process): Recover pty_flag from process, not from volatile local.
2799 (create_pty): Stay inside array even when pty allocation fails.
2800 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2801
b2a069c2
PE
2802 * lread.c (Fload): Avoid initialization only when lint checking.
2803 Mention that it's needed only for older GCCs.
2804
99107004
KH
28052013-07-20 Kenichi Handa <handa@gnu.org>
2806
2807 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2808 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2809
6b1b199d
AS
28102013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2811
2812 * lread.c (Fload): Avoid uninitialized warning.
2813
4195afc3
PE
28142013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2815
3f5bef16
PE
2816 Fix some minor file descriptor leaks and related glitches.
2817 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2818 (create_lock_file): Use write, not emacs_write.
2819 * image.c (slurp_file, png_load_body):
2820 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2821 (server_accept_connection):
2822 Don't leak an fd on memory allocation failure.
2823 * image.c (slurp_file): Add a cheap heuristic for growing files.
2824 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2825 as that's what the other routines do. Maybe input need not be
2826 blocked at all, but it's better to be consistent.
2827 Avoid undefined behavior when strlen is zero.
2828
4195afc3
PE
2829 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2830 (NSTATICS): Now a constant; doesn't need to be a macro.
2831
a1aeeffe
RS
28322013-07-19 Richard Stallman <rms@gnu.org>
2833
2834 * coding.c (decode_coding_utf_8): Add simple loop for fast
2835 processing of ASCII characters.
2836
63b34baa
PE
28372013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2840
621dd9ac
EZ
28412013-07-19 Eli Zaretskii <eliz@gnu.org>
2842
2843 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2844 unportable 'struct x_display_info'.
2845 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2846 is a portable type.
2847
1396ac86
PE
28482013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2849
ab9980cd
PE
2850 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2851 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2852 or fscanf fails.
2853 (system_process_attributes): Prefer plain char to unsigned char
2854 when either will do. Clean up properly if interrupted or if
068f9124
SM
2855 memory allocations fail. Don't assume sscanf succeeds.
2856 Remove no-longer-needed workaround to stop GCC from whining.
2857 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2858 bit more carefully.
2859
1396ac86
PE
2860 Fix obscure porting bug with varargs functions.
2861 The code assumed that int is treated like ptrdiff_t in a vararg
2862 function, which is not a portable assumption. There was a similar
2863 -- though these days less likely -- porting problem with various
2864 assumptions that pointers of different types all smell the same as
2865 far as vararg functions is conserved. To make this problem less
2866 likely in the future, redo the API to use varargs functions.
2867 * alloc.c (make_save_value): Remove this vararg function.
2868 All uses changed to ...
2869 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2870 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2871 New functions.
2872 (make_save_ptr): Rename from make_save_pointer, for consistency with
2873 the above. Define only on platforms that need it. All uses changed.
2874
4d19d194
PE
28752013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2876
2877 * keyboard.c: Try to fix typos in previous change.
2878 (DISPLAY_LIST_INFO): New macro.
2879 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2880 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2881
945c5bb1
JB
28822013-07-18 Juanma Barranquero <lekktu@gmail.com>
2883
2884 * keyboard.c (kbd_buffer_get_event):
2885 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2886 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2887
f4b1eb36
PE
28882013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2889
5e679a2c
PE
2890 * filelock.c: Fix unlikely file descriptor leaks.
2891 (get_boot_time_1): Rework to avoid using emacs_open.
2892 This doesn't actually fix a leak, but is better anyway.
2893 (read_lock_data): Use read, not emacs_read.
2894
a8cd4836
PE
2895 * doc.c: Fix minor memory and file descriptor leaks.
2896 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2897 (get_doc_string, Fsnarf_documentation):
2898 Fix file descriptor leak on error.
2899
ef30e638
PE
2900 * term.c: Fix minor fdopen-related file descriptor leaks.
2901 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2902 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2903
f4b1eb36
PE
2904 * charset.c: Fix file descriptor leaks and errno issues.
2905 Include <errno.h>.
2906 (load_charset_map_from_file): Don't leak file descriptor on error.
2907 Use plain record_xmalloc since the allocation is larger than
2908 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2909 of entries.
2910 * eval.c (record_unwind_protect_nothing):
2911 * fileio.c (fclose_unwind):
2912 New functions.
2913 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2914 The replacement doesn't block input, but that no longer seems
2915 necessary.
2916
b648c163
PE
29172013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2918
a0931322
PE
2919 * lread.c: Fix file descriptor leaks and errno issues.
2920 (Fload): Close some races that leaked fds or streams when 'load'
2921 was interrupted.
2922 (Fload, openp): Report error number of last nontrivial failure to open.
2923 ENOENT counts as trivial.
2924 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2925 New functions.
2926 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2927 now that the function is always called with a nonnegative arg.
2928 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2929 All uses replaced with ...
2930 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2931
b648c163
PE
2932 A few more minor file errno-reporting bugs.
2933 * callproc.c (Fcall_process):
2934 * doc.c (Fsnarf_documentation):
2935 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2936 * process.c (set_socket_option):
2937 Don't let a constructor trash errno.
2938 * doc.c: Include <errno.h>.
2939
b1dc4084
JB
29402013-07-16 Juanma Barranquero <lekktu@gmail.com>
2941
2942 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2943
c43843aa
PE
29442013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2945
50a30cce
PE
2946 Fix w32 bug with call-process-region (Bug#14885).
2947 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2948 to Fcall_process when the input is empty. This simplifies the
2949 code a bit. It makes no difference on POSIXish platforms but
2950 apparently it fixes a bug on w32.
2951
44e18199 2952 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2953 * fileio.c (close_file_unwind): Don't close if FD is negative;
2954 this can happen when unwinding a zapped file descriptor.
2955 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2956 in case Emacs runs out of memory between the two unwind-protects.
2957 Don't trash errno when closing FD.
2958 Zap the FD in the specpdl when closing it, instead of deferring
2959 the removal of the unwind-protect; this fixes a bug where a child
2960 function unwinds the stack past us.
2961
27e498e6
PE
2962 New unwind-protect flavors to better type-check C callbacks.
2963 This also lessens the need to write wrappers for callbacks,
2964 and the need for make_save_pointer.
2965 * alloca.c (free_save_value):
2966 * atimer.c (run_all_atimers):
2967 Now extern.
2968 * alloc.c (safe_alloca_unwind):
2969 * atimer.c (unwind_stop_other_atimers):
2970 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2971 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2972 * minibuf.c (choose_minibuf_frame_1):
2973 * process.c (make_serial_process_unwind):
2974 * xdisp.h (pop_message_unwind):
2975 * xselect.c (queue_selection_requests_unwind):
2976 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2977 * alloca.c (record_xmalloc):
2978 Prefer record_unwind_protect_ptr to record_unwind_protect with
2979 make_save_pointer.
2980 * alloca.c (Fgarbage_collect):
2981 Prefer record_unwind_protect_void to passing a dummy.
2982 * buffer.c (restore_buffer):
2983 * window.c (restore_window_configuration):
2984 * xfns.c, w32fns.c (do_unwind_create_frame)
2985 New wrapper. All record-unwind uses of wrappee changed.
2986 * buffer.c (set_buffer_if_live):
2987 * callproc.c (call_process_cleanup, delete_temp_file):
2988 * coding.c (code_conversion_restore):
2989 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2990 * editfns.c (save_excursion_restore)
2991 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2992 (save_restriction_restore):
2993 * eval.c (restore_stack_limits, un_autoload):
2994 * fns.c (require_unwind):
2995 * keyboard.c (recursive_edit_unwind, tracking_off):
2996 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2997 * macros.c (pop_kbd_macro, restore_menu_items):
2998 * nsfns.m (unwind_create_frame):
2999 * print.c (print_unwind):
3000 * process.c (start_process_unwind):
3001 * search.c (unwind_set_match_data):
3002 * window.c (select_window_norecord, select_frame_norecord):
3003 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
3004 (fast_set_selected_frame):
3005 * xfns.c, w32fns.c (unwind_create_tip_frame):
3006 Return void, not a dummy Lisp_Object. All uses changed.
3007 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
3008 * callproc.c (call_process_kill):
3009 * fileio.c (restore_point_unwind, decide_coding_unwind)
3010 (build_annotations_unwind):
3011 * insdel.c (Fcombine_after_change_execute_1):
3012 * keyboard.c (read_char_help_form_unwind):
3013 * menu.c (unuse_menu_items):
3014 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
3015 * sound.c (sound_cleanup):
3016 * xdisp.c (unwind_redisplay):
3017 * xfns.c (clean_up_dialog):
3018 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
3019 Accept no args and return void, instead of accepting and returning
3020 a dummy Lisp_Object. All uses changed.
3021 * cygw32.c (fchdir_unwind):
3022 * fileio.c (close_file_unwind):
3023 * keyboard.c (restore_kboard_configuration):
3024 * lread.c (readevalllop_1):
3025 * process.c (wait_reading_process_output_unwind):
3026 Accept int and return void, rather than accepting an Emacs integer
3027 and returning a dummy object. In some cases this fixes an
3028 unlikely bug when the corresponding int is outside Emacs integer
3029 range. All uses changed.
3030 * dired.c (directory_files_internal_unwind):
3031 * fileio.c (do_auto_save_unwind):
3032 * gtkutil.c (pop_down_dialog):
3033 * insdel.c (reset_var_on_error):
3034 * lread.c (load_unwind):
3035 * xfns.c (clean_up_file_dialog):
3036 * xmenu.c, nsmenu.m (pop_down_menu):
3037 * xmenu.c (cleanup_widget_value_tree):
3038 * xselect.c (wait_for_property_change_unwind):
3039 Accept pointer and return void, rather than accepting an Emacs
3040 save value encapsulating the pointer and returning a dummy object.
3041 All uses changed.
3042 * editfns.c (Fformat): Update the saved pointer directly via
3043 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3044 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3045 (unwind_body): New function.
3046 (record_unwind_protect): First arg is now a function returning void,
3047 not a dummy Lisp_Object.
3048 (record_unwind_protect_ptr, record_unwind_protect_int)
3049 (record_unwind_protect_void): New functions.
3050 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3051 * fileio.c (struct auto_save_unwind): New type.
3052 (do_auto_save_unwind): Use it.
3053 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3054 * insdel.c (struct rvoe_arg): New type.
3055 (reset_var_on_error): Use it.
3056 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3057 New constants.
3058 (specbinding_func): Remove; there are now several such functions.
3059 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3060 (set_unwind_protect_ptr): New function.
3061 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3062
4e604a5d
PE
3063 Be simpler and more consistent about reporting I/O errors.
3064 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3065 Say "Read error" and "Write error", rather than "I/O error", or
3066 "IO error reading", or "IO error writing", when a read or write
3067 error occurs.
3068 * process.c (Fmake_network_process, wait_reading_process_output)
3069 (send_process, Fprocess_send_eof, wait_reading_process_output):
3070 Capitalize diagnostics consistently. Put "failed foo" at the
3071 start of the diagnostic, so that we don't capitalize the
3072 function name "foo". Consistently say "failed" for such
3073 diagnostics.
3074 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3075 All callers changed. This is so it can use report_file_error.
3076 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3077 diagnostics consistently as above.
3078
a9757f6a
PE
3079 * fileio.c (report_file_errno): Fix errno reporting bug.
3080 If the file name is neither null nor a pair, package it up as a
3081 singleton list. All callers changed, both to this function and to
3082 report_file_error. This fixes a bug where the memory allocator
3083 invoked by list1 set errno so that the immediately following
3084 report_file_error reported the wrong errno value.
3085
c43843aa
PE
3086 Fix minor problems found by --enable-gcc-warnings.
3087 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3088 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3089
18c26d81
JD
30902013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3091
3092 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3093 Set event->arg to Qt if switch-event shall be generated.
3094 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3095
3096 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3097
3098 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3099 FOCUS_OUT_EVENT.
3100
3101 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3102 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3103 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3104 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3105 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3106 and there is a focused frame.
3107 (head_table): Add focus-in and focus-out.
3108 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3109 bind to handle-focus-in/out.
3110
3111 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3112 (Fhandle_switch_frame): Call Fhandle_focus_in.
3113 (syms_of_frame): defsubr handle-focus-in/out.
3114
6c6f1994
PE
31152013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3116
c7ddc792
PE
3117 Fix porting bug to older POSIXish platforms (Bug#14862).
3118 * sysdep.c (emacs_pipe): New function, that implements
3119 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3120 This should port better to CentOS 5 and to Mac OS X 10.6.
3121 All calls to pipe2 changed.
3122
6c6f1994
PE
3123 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3124 This makes the code easier to read and the executable a bit smaller.
3125 Do not replace all calls to Fcons that happen to create lists,
3126 just calls that are intended to create lists. For example, when
3127 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3128 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3129 Similarly for list2 through list5.
3130 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3131 * bytecode.c (exec_byte_code):
3132 * callint.c (quotify_arg, Fcall_interactively):
3133 * callproc.c (Fcall_process, create_temp_file):
3134 * charset.c (load_charset_map_from_file)
3135 (Fdefine_charset_internal, init_charset):
3136 * coding.c (get_translation_table, detect_coding_system)
3137 (Fcheck_coding_systems_region)
3138 (Fset_terminal_coding_system_internal)
3139 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3140 * composite.c (update_compositions, Ffind_composition_internal):
3141 * dired.c (directory_files_internal, file_name_completion)
3142 (Fsystem_users):
3143 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3144 * doc.c (Fsnarf_documentation):
3145 * editfns.c (Fmessage_box):
3146 * emacs.c (main):
3147 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3148 (Feval, eval_sub, Ffuncall, apply_lambda):
3149 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3150 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3151 (Fset_file_times, Finsert_file_contents)
3152 (Fchoose_write_coding_system, Fwrite_region):
3153 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3154 * font.c (font_registry_charsets, font_parse_fcname)
3155 (font_prepare_cache, font_update_drivers, Flist_fonts):
3156 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3157 * frame.c (make_frame, Fmake_terminal_frame)
3158 (x_set_frame_parameters, x_report_frame_params)
3159 (x_default_parameter, Fx_parse_geometry):
3160 * ftfont.c (syms_of_ftfont):
3161 * image.c (gif_load):
3162 * keyboard.c (command_loop_1):
3163 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3164 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3165 (Fminor_mode_key_binding, accessible_keymaps_1)
3166 (Faccessible_keymaps, Fwhere_is_internal):
3167 * lread.c (read_emacs_mule_char):
3168 * menu.c (find_and_return_menu_selection):
3169 * minibuf.c (get_minibuffer):
3170 * nsfns.m (Fns_perform_service):
3171 * nsfont.m (ns_script_to_charset):
3172 * nsmenu.m (ns_popup_dialog):
3173 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3174 (Fx_own_selection_internal):
3175 * nsterm.m (append2):
3176 * print.c (Fredirect_debugging_output)
3177 (print_prune_string_charset):
3178 * process.c (Fdelete_process, Fprocess_contact)
3179 (Fformat_network_address, set_socket_option)
3180 (read_and_dispose_of_process_output, write_queue_push)
3181 (send_process, exec_sentinel):
3182 * sound.c (Fplay_sound_internal):
3183 * textprop.c (validate_plist, add_properties)
3184 (Fput_text_property, Fadd_face_text_property)
3185 (copy_text_properties, text_property_list, syms_of_textprop):
3186 * unexaix.c (report_error):
3187 * unexcoff.c (report_error):
3188 * unexsol.c (unexec):
3189 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3190 (Fformat_mode_line, syms_of_xdisp):
3191 * xfaces.c (set_font_frame_param)
3192 (Finternal_lisp_face_attribute_values)
3193 (Finternal_merge_in_global_face, syms_of_xfaces):
3194 * xfns.c (x_default_scroll_bar_color_parameter)
3195 (x_default_font_parameter, x_create_tip_frame):
3196 * xfont.c (xfont_supported_scripts):
3197 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3198 (menu_help_callback, xmenu_show):
3199 * xml.c (make_dom):
3200 * xterm.c (set_wm_state):
3201 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3202 and similarly for list2 through list5.
3203
bafe80ce
PE
32042013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3205
3206 * callproc.c (Fcall_process_region): Fix minor race and tune.
3207 (create_temp_file): New function, with the temp-file-creation part
3208 of the old Fcall_process_region. Use Fcopy_sequence to create the
3209 temp file name, rather than alloca + build_string, for simplicity.
3210 Don't bother to block input around the temp file creation;
068f9124
SM
3211 shouldn't be needed. Simplify use of mktemp.
3212 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3213 this closes an unlikely race where the temp file was not removed.
3214 Use memcpy rather than an open-coded loop.
3215 (Fcall_process_region): Use the new function. If the input is
3216 empty, redirect from /dev/null rather than from a newly created
3217 empty temp file; this avoids unnecessary file system traffic.
3218
4700b5a5
PE
32192013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3220
5c97beae
PE
3221 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3222 Simplify by making this case like the other two. This is a bit
3223 slower on obsolete hosts, but the extra complexity isn't worth it.
3224
4700b5a5
PE
3225 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3226 * process.c (create_process) [!DOS_NT]:
3227 Remove now-unnecessary calls to emacs_close.
3228
f9a74c4c
EZ
32292013-07-13 Eli Zaretskii <eliz@gnu.org>
3230
922ae7ee
EZ
3231 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3232 returning early. (Bug#14850)
3233
f9a74c4c
EZ
3234 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3235 and inhibit-iso-escape-detection attributes of 'undecided'.
3236 (Bug#14822)
3237
5e301d76
PE
32382013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3239
69e0e5ee
PE
3240 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3241 Reported by Herbert J. Skuhra in
3242 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3243
5e301d76
PE
3244 Don't lose top specpdl entry when memory is exhausted.
3245 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3246 specpdl overflow here, to simplify callers; all callers changed.
3247 Always reserve an unused entry at the stack top; this avoids
3248 losing the top entry's information when memory is exhausted.
3249
7e649856
PE
32502013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3251
a773ed9a
PE
3252 Clean up errno reporting and fix some errno-reporting bugs.
3253 * callproc.c (Fcall_process):
3254 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3255 * process.c (create_process, Fmake_network_process):
3256 * unexaix.c (report_error):
3257 * unexcoff.c (report_error):
3258 Be more careful about reporting the errno of failed operations.
3259 The code previously reported the wrong errno sometimes.
3260 Also, prefer report_file_errno to setting errno + report_file_error.
3261 (Fcall_process): Look at openp return value rather than at path,
3262 as that's a bit faster and clearer when there's a numeric predicate.
3263 * fileio.c (report_file_errno): New function, with most of the
3264 old contents of report_file_error.
3265 (report_file_error): Use it.
3266 (Ffile_exists_p, Ffile_accessible_directory_p):
3267 Set errno to 0 when it is junk.
3268 * fileio.c (Faccess_file):
3269 * image.c (x_create_bitmap_from_file):
3270 Use faccessat rather than opening the file, to avoid the hassle of
3271 having a file descriptor open.
3272 * lisp.h (report_file_errno): New decl.
3273 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3274
7e649856
PE
3275 Minor EBADF fixes.
3276 * process.c (create_process, wait_reading_process_output) [AIX]:
3277 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3278 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3279 a multithreaded environment anyway).
3280 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3281
f6774c1a
AS
32822013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3283
3284 * image.c (x_find_image_file): Don't close a remote file handle.
3285
bacba3c2
PE
32862013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 Fix races with threads and file descriptors.
3289 * callproc.c (Fcall_process_region):
3290 * dired.c (open_directory):
3291 * emacs.c (main, Fdaemon_initialized):
3292 * image.c (x_find_image_file):
3293 * inotify.c (Finotify_rm_watch):
3294 * lread.c (Flocate_file_internal):
3295 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3296 * term.c (term_mouse_moveto, init_tty):
3297 * termcap.c (tgetent):
3298 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3299 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3300 * unexhp9k800.c, unexmacosx.c (unexec):
3301 * callproc.c (Fcall_process_region):
3302 Use emacs_close, not close.
3303 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3304 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3305 and posix_close function on current platforms (which all lack them).
3306 (emacs_close): Use it. This should fix the races on GNU/Linux and
3307 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3308 and it should avoid closing random victim file descriptors on
3309 other platforms.
3310
653d4f43
PE
33112013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3312
c8536ec4
PE
3313 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3314 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3315 Touch up doc a bit.
3316
9c203066
PE
3317 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3318 This is for .gdbinit xbacktrace.
3319
653d4f43
PE
3320 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3321 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3322 (emacs_set_tty): Now static.
3323 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3324 * term.c (tty_capable_p, tty_default_color_capabilities)
3325 (get_tty_terminal, term_mouse_movement)
3326 (handle_one_term_event, init_tty, maybe_fatal):
3327 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3328 (tgetent, scan_file, name_match, compare_contin):
3329 * terminal.c (get_terminal):
3330 Use bool for boolean.
3331 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3332 Prefer char to unsigned char if either will do.
3333 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3334 (tty_write_glyphs): Prefer int to unsigned.
3335 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3336 All callers changed.
3337 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3338
45b683a1
PE
33392013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3340
29abe551
PE
3341 Port to C89.
3342 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3343 (B__dummy__): New dummy symbol, to pacify C89.
3344 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3345 they can't grok varargs macros.
3346 * dispnew.c (add_window_display_history)
3347 (add_frame_display_history):
3348 * print.c (print_object):
3349 * xdisp.c (debug_method_add):
3350 Use %p printf format only for void pointers.
3351 * emacs.c (usage_message): New constant, replacing ...
3352 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3353 (main): Adjust to usage reorg.
3354 * fns.c (syms_of_fns):
3355 * profiler.c (syms_of_profiler):
3356 Don't use non-constant struct initializers.
3357 * gnutls.h (gnutls_initstage_t):
3358 * lisp.h (enum Lisp_Fwd_Type):
3359 * lread.c (lisp_file_lexically_bound_p):
3360 * xsettings.c (anonymous enum):
3361 Remove trailing comma.
3362 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3363 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3364 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3365 (DEFUN): Use it.
3366 * regex.c (const_re_char): New type, to pacify strict C89.
3367 All uses of 'const re_char' replaced to use it.
3368 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3369 with glibc when strict C89. This change is imported from gnulib.
3370 All uses changed.
3371 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3372 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3373 Omit GNU_LINUX implementation, since it requires long long.
3374 * xterm.c (x_draw_underwave):
3375 Do not assume the traditional order of struct's members.
3376 (x_term_init): Rewrite to avoid the need for non-constant structure
3377 initializers.
3378
45b683a1 3379 Syntax cleanup, mostly replacing macros with functions.
763a086d 3380 This removes the need for the syntax_temp hack.
45b683a1
PE
3381 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3382 * syntax.c (SYNTAX_INLINE): New macro.
3383 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3384 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3385 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3386 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3387 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3388 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3389 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3390 Now constants, not macros.
3391 (syntax_temp) [!__GNUC__]: Remove.
3392 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3393 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3394 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3395 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3396 Move here from syntax.h; now functions, not macros. Except for the
3397 last function, these are static since only syntax.c uses them.
3398 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3399 All uses changed. Now a function, not a macro; use this fact
3400 to simplify the code.
3401 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3402 compiler bugs; no longer relevant.
3403 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3404 (SYNTAX_INLINE): New macro.
3405 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3406 for the new functions. Use bool for boolean member.
3407 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3408 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3409 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3410 (SETUP_BUFFER_SYNTAX_TABLE):
3411 Now extern inline functions, not macros.
3412 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3413 Remove; all uses replaced by implementation.
3414 (syntax_temp) [!__GNUC__]: Remove decl.
3415 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3416
29be4a50
JD
34172013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3418
3419 * emacs.c (main): Fix syntax error.
3420
954b166e
PE
34212013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3422
3423 Timestamp fixes for undo (Bug#14824).
3424 * atimer.c (schedule_atimer):
3425 * fileio.c (Ffile_newer_than_file_p):
3426 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3427 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3428 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3429 (syms_of_fileio): Remove Sclear_visited_file_name.
3430 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3431 file doesn't exist; this avoids an ambiguity with negative timestamps.
3432 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3433 * systime.h (make_emacs_time, invalid_emacs_time):
3434 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3435 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3436 * undo.c (record_first_change): Push (visited-file-modtime) onto
3437 undo list rather than reimplementing it by hand, incorrectly.
3438
d74647c3
KB
34392013-07-09 Ken Brown <kbrown@cornell.edu>
3440
3441 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3442
3c51b96b
JB
34432013-07-09 Juanma Barranquero <lekktu@gmail.com>
3444
3445 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3446
4ebbdd67
PE
34472013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3448
3449 Handle errno and exit status a bit more carefully.
3450 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3451 number into an exit status. Instead, use EXIT_CANCELED.
3452 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3453 * callproc.c (relocate_fd):
3454 * emacs.c (close_output_streams, main):
3455 * process.c (create_process):
3456 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3457 Use emacs_perror for simplicity.
3458 * callproc.c (relocate_fd, main):
3459 * sysdep.c (sys_subshell):
3460 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3461 (shut_down_emacs): Use emacs_write, not write.
3462 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3463 * fileio.c (Fcopy_file, e_write):
3464 * nsterm.m (ns_select):
3465 * process.c (send_process):
3466 * sound.c (vox_write):
3467 Use emacs_write_sig, not emacs_write.
3468 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3469 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3470 New constants.
3471 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3472 of write.
3473 (emacs_full_write): New function.
3474 (emacs_write): Rewrite to use it.
3475 (emacswrite_sig, emacs_perror): New functions.
3476 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3477
44e18199 34782013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3479
3480 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3481 on NS even if it is present. Pixmap on NS is a void*.
3482
9caab067
PE
34832013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3484
3485 Port to Ubuntu 10 (Bug#14803).
3486 Problem reported by T.V. Raman.
3487 * process.c (close_on_exec, accept4, process_socket):
3488 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3489
1d442672
EZ
34902013-07-07 Eli Zaretskii <eliz@gnu.org>
3491
3492 * w32.c (sys_dup): Declare prototype.
3493
3494 * filelock.c:
3495 * emacs.c:
3496 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3497
067428c1
PE
34982013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3499
3500 Make file descriptors close-on-exec when possible (Bug#14803).
3501 This simplifies Emacs a bit, since it no longer needs to worry
3502 about closing file descriptors by hand in some cases.
3503 It also fixes some unlikely races. Not all such races, as
3504 libraries often open files internally without setting
3505 close-on-exec, but it's an improvement.
3506 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3507 * callproc.c (Fcall_process) [!MSDOS]:
3508 * emacs.c (main) [!DOS_NT]:
3509 * nsterm.m (ns_term_init):
3510 * process.c (create_process):
3511 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3512 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3513 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3514 Prefer mkostemp with O_CLOEXEC to mkstemp.
3515 * callproc.c (relocate_fd) [!WINDOWSNT]:
3516 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3517 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3518 now using pipe2.
3519 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3520 Make the resulting file descriptor close-on-exec.
3521 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3522 * lread.c (load_descriptor_list, load_descriptor_unwind):
3523 Remove; no longer needed. All uses removed.
3524 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3525 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3526 New functions.
3527 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3528 (Fmake_network_process, Fnetwork_interface_list):
3529 (Fnetwork_interface_info, server_accept_connection):
3530 Make newly-created socket close-on-exec.
3531 * sysdep.c (emacs_open, emacs_fopen):
3532 Make new-created descriptor close-on-exec.
3533 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3534 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3535
0da857dd
JD
35362013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3537
3538 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3539 for NS_IMPL_GNUSTEP.
3540
5f86adcd
PE
35412013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 Fix openp errno handling.
3544 * callproc.c (Fcall_process): Preserve openp errno around close.
3545 * lread.c (openp): Set errno when returning -1, as some callers
3546 expect this.
3547
1afb1d07
JD
35482013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3549
3550 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3551
3552 * nsterm.h (NSSavePanel): Update comment.
3553 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3554 (ns_run_file_dialog): Declare.
3555
3556 * nsfns.m: Remove panelOK.
3557 (ns_fd_data): New.
3558 (ns_run_file_dialog): New function.
3559 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3560 event loop, so file dialog is popped up by ns_run_file_dialog, called
3561 by sendEvent (Bug#14578).
3562 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3563
3323c263
EZ
35642013-07-06 Eli Zaretskii <eliz@gnu.org>
3565
fdda0220
EZ
3566 * xdisp.c (default_line_pixel_height): New function.
3567 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3568 (try_cursor_movement, redisplay_window, try_window)
3569 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3570
068f9124
SM
3571 * window.c (window_scroll_pixel_based):
3572 use default_line_pixel_height.
fdda0220
EZ
3573
3574 * dispextern.h (default_line_pixel_height): Add prototype.
3575
3576 * frame.c (x_set_line_spacing): Accept a float value for
3577 line-spacing parameter, per the documentation.
3578
3323c263
EZ
3579 * data.c (Fmultibyte_string_p): Doc fix.
3580
47ba6d43
PE
35812013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3582
406af475
PE
3583 Use emacs_open more consistently when opening files.
3584 This handles EINTR more consistently now, and makes it easier
3585 to introduce other uniform changes to file descriptor handling.
3586 * src/systdio.h: New file.
3587 * src/buffer.c (mmap_init):
3588 * cygw32.c (chdir_to_default_directory):
3589 * dispnew.c (Fopen_termscript):
3590 * emacs.c (Fdaemon_initialized):
3591 * fileio.c (Fdo_auto_save):
3592 * image.c (slurp_file, png_load_body, jpeg_load_body):
3593 * keyboard.c (Fopen_dribble_file):
3594 * lread.c (Fload):
3595 * print.c (Fredirect_debugging_output):
3596 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3597 * termcap.c (tgetent):
3598 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3599 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3600 * w32term.c (w32_initialize) [CYGWIN]:
3601 * xfaces.c (Fx_load_color_file):
3602 Use emacs_open instead of plain open, and emacs_fopen instead of
3603 plain fopen.
3604 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3605 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3606 * callproc.c (default_output_mode): New constant.
3607 (Fcall_process): Use it to call emacs_open instead of plain creat.
3608 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3609 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3610 (emacs_fopen): New function.
3611 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3612 Include <lisp.h>, for emacs_open.
3613 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3614
47ba6d43
PE
3615 Remove duplicate #include directives.
3616 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3617 * xfaces.c:
3618 Don't include stdio.h twice.
3619 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3620 Don't include sys/types.h or stdio.h twice.
3621 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3622 * lread.c: Don't include coding.h twice.
3623 * nsfont.m: Don't include frame.h twice.
3624 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3625 * ralloc.c: Don't include <unistd.h> twice.
3626 * xdisp.c: Don't include font.h twice.
3627 * xterm.c: Don't include fontset.h twice.
3628 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3629
b9ed53d5
PE
36302013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 Scale ImageMagick images more carefully.
3633 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3634 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3635 Be more careful about avoiding undefined behavior after
3636 integer overflow and division by zero.
3637
cf13177e
YM
36382013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3639
3640 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3641 (syms_of_w32fns): DEFSYM them.
3642 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3643 (CCHDEVICENAME): Define macros if not defined.
3644 (struct MONITOR_INFO_EX): New struct.
3645 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3646 (enum_display_monitors_fn): New variable.
3647 (globals_of_w32fns): Initialize it.
3648 (Fx_display_pixel_width, Fx_display_pixel_height)
3649 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3650 multi-monitor setups in docstrings.
3651 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3652 screen size by primary monitor's millimeter per pixel.
3653 (w32_monitor_enum, w32_display_monitor_attributes_list)
3654 (w32_display_monitor_attributes_list_fallback)
3655 (Fw32_display_monitor_attributes_list): New functions.
3656 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3657
3658 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3659 if not defined.
3660 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3661
86dfb7a8
MA
36622013-07-04 Michael Albinus <michael.albinus@gmx.de>
3663
3664 * fileio.c (Qfile_notify_error): New error symbol.
3665
3666 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3667 * inotify.c (inotify_callback, symbol_to_inotifymask)
3668 (Finotify_add_watch, Finotify_rm_watch): Use it.
3669 (inotifyevent_to_event): Exchange order of cookie and file name.
3670 (Finotify_add_watch): Adapt docstring.
3671
3672 * lisp.h (Qfile_notify_error): Declare.
3673
2c1c974b
PE
36742013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3677 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3678 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3679 which did not work (see <http://bugs.gnu.org/14569#307>).
3680 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3681 && (!noninteractive || initialized)). This attempts to thread
3682 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3683
7a35b20f
JB
36842013-07-04 Juanma Barranquero <lekktu@gmail.com>
3685
3686 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3687 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3688
1ce5cd04
PE
36892013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3690
3691 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3692 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3693 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3694 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3695
57f8c490
PE
36962013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3697
3698 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3699 Define to __sys_siglist.
3700
bcffb5ca
EZ
37012013-07-02 Eli Zaretskii <eliz@gnu.org>
3702
3703 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3704 word-wrap, so that overflow-newline-into-fringe would work in
3705 visual-line-mode. (Bug#2749)
3706 (move_it_in_display_line_to): When the last scanned display
3707 element fits exactly on the display line, and
3708 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3709 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3710 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3711 finding buffer position that corresponds to pixel coordinates,
3712 e.g. in buffer_posn_from_coords.
3713
2c41e781
JD
37142013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3715
3716 * process.c (handle_child_signal): Call catch_child_signal if
3717 NS_IMPL_GNUSTEP.
3718
c2418359
PE
37192013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3720
52a9bcae
PE
3721 Don't convert function pointers to void * and back.
3722 It isn't portable C, and it's easy enough to avoid.
3723 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3724 (make_save_value): Add support for SAVE_FUNCPOINTER.
3725 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3726 * print.c (print_object):
3727 Distinguish function from object pointers.
3728 * lisp.h (SAVE_FUNCPOINTER): New constant.
3729 (SAVE_SLOT_BITS): Adjust to it.
3730 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3731 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3732 (voidfuncptr): New typedef.
3733 (struct Lisp_Save_Value): New member data[0].funcpointer.
3734 (XSAVE_FUNCPOINTER): New function.
3735
c2418359
PE
3736 Simplify buildobj processing.
3737 * Makefile.in (buildobj.h): Make it a sequence of strings each
3738 followed by comma, rather than a single string. Put it into a
3739 .tmp file in case there's an error while generating it.
3740 (gl-stamp): Use .tmp for temp files.
3741 (mostlyclean): Clean .tmp files.
3742 * doc.c (buildobj): Move to just the routine that needs it.
3743 It's now an array of strings, so processing is simpler.
3744
8f43ce49
PE
37452013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3748 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3749 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3750 Invoke malloc_enable_thread even when not interactive.
3751 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3752 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3753 in this case, since the underlying bug has now been fixed.
3754
24827db9
JB
37552013-07-01 Juanma Barranquero <lekktu@gmail.com>
3756
3757 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3758 unlinking it (bug#14691).
3759
ef099a94
MN
37602013-06-30 Michal Nazarewicz <mina86@mina86.com>
3761
3762 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3763 before checking whether buffer is modified. This lets
3764 `kill-buffer-query-functions' cancel killing of the buffer or save
3765 its content before `kill-buffer' asks user the "Buffer %s
3766 modified; kill anyway?" question.
3767
9d3f2fc2
JD
37682013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3769
3770 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3771 Let the super performKeyEquivalent deal with them (Bug#14747).
3772
e6c6c8c7
PE
37732013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3774
1d71c1d9
PE
3775 * widget.c (resize_cb): Remove unused local.
3776
8f5f35cc
PE
3777 Do not use GTK 3 if it exists but cannot be compiled.
3778 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3779 * xterm.c (x_error_handler) [!USE_GTK]:
3780 Do not use GTK 3.
3781
e6c6c8c7
PE
3782 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3783
0ba54312
EZ
37842013-06-30 Eli Zaretskii <eliz@gnu.org>
3785
5d1c3286
EZ
3786 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3787 to the valid range of values. (Bug#14753)
3788
0ba54312
EZ
3789 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3790 when moving point by using the current glyph matrix. This avoids
3791 the need to force redisplay when this function is called in a
3792 loop.
3793
9c90cc06
PE
37942013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3795
3796 Fix minor problems found by static checking.
3797 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3798 Redo the latter's body to sidestep GCC parenthesization warnings.
3799 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3800 * coding.c (detect_coding, detect_coding_system):
3801 * coding.h (struct undecided_spec):
3802 Use bool for boolean.
3803 * image.c (QCmax_width, QCmax_height): Now static.
3804 * xdisp.c (Fmove_point_visually): Remove unused local.
3805
4c672a0f
EZ
38062013-06-29 Eli Zaretskii <eliz@gnu.org>
3807
3808 * xdisp.c (Fmove_point_visually): New function.
3809
c1ea3abf
JB
38102013-06-28 Kenichi Handa <handa@gnu.org>
3811
3812 * coding.h (define_coding_undecided_arg_index): New enum.
3813 (coding_attr_index): New members
3814 coding_attr_undecided_inhibit_null_byte_detection,
3815 coding_attr_undecided_inhibit_iso_escape_detection,
3816 coding_attr_undecided_prefer_utf_8.
3817 (undecided_spec): New struct.
3818 (struct coding_system): New member `undecided' of the member
3819 `spec'.
3820
3821 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3822 (detect_coding): Likewise.
3823 (detect_coding_system): Likewise.
3824 (Fdefine_coding_system_internal): New coding system properties
3825 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3826 :prefer-utf-8.
3827 (syms_of_coding): Adjust for coding_arg_undecided_max.
3828
ba3de9e6
PE
38292013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3830
3831 * image.c (x_from_xcolors): Remove unused local.
3832
547c9269
YM
38332013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3834
3835 Defer image data transfer between X client and server until actual
3836 display happens.
3837
3838 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3839 and `mask_img'.
3840
3841 * image.c (Destroy_Image): Remove.
3842 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3843 `mask_p', and `colors_p'. All uses changed.
3844 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3845 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3846 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3847 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3848 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3849 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3850 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3851 (image_get_x_image, image_unget_x_image): New functions or macros.
3852 (image_background, image_background_transparent, x_to_xcolors)
3853 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3854 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3855 instead of Destroy_Image.
3856 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3857 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3858 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3859 (imagemagick_load_image, svg_load_image): Use them instead of
3860 x_create_x_image_and_pixmap, and x_put_x_image followed by
3861 x_destroy_x_image, respectively.
3862 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3863 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3864 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3865 background_transparent fields.
3866 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3867 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3868
dae2f5ef
PE
38692013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3870
3871 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3872 This mostly consists of undoing recent changes.
3873 * callproc.c (Fcall_process):
3874 * process.c (create_process):
3875 Do not worry about catching SIGCHLD here, undoing previous change.
3876 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3877 * process.c, process.h (catch_child_signal):
3878 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3879 * process.c (catch_child_handler): Don't worry about being called
3880 lazily and do not assume caller has blocked SIGCHLD, undoing
3881 previous change. Move first-time stuff back to
3882 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3883 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3884 set lib_child_handler if it's already initialized, which may
3885 help avoid problems on GNUStep.
3886
fa55d2aa
PE
38872013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3888
3889 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3890 * callproc.c (Fcall_process):
3891 * process.c (create_process):
3892 Make sure SIGCHLD is caught before we fork,
3893 since Emacs startup no arranges to catch SIGCHLD.
3894 * process.c (lib_child_handler): Initialize to null, not to
3895 dummy_handler.
3896 (catch_child_signal): Allow self to be called lazily.
3897 Do nothing if it's already been called.
3898 Assume caller has blocked SIGCHLD (all callers do now).
3899 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3900 just before it's really needed.
3901 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3902 since it hasn't been caught yet.
3903
f3f9606c
LMI
39042013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3905
3906 * image.c (compute_image_size): New function to implement
3907 :max-width and :max-height.
3908 (imagemagick_load_image): Use it.
3909
c7041908
PE
39102013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3911
3912 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3913 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3914 Now extern.
3915 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3916 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3917 the SIGCHLD handler, since the code is not atomic and (due to glib)
3918 signals may be arriving now.
3919 * sysdep.c (init_signals): Do not catch child signals here;
3920 'main' now does that later, at a safer time.
3921
f86852b4
PE
39222013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3923
0dfeed58
PE
3924 Clean up SIGCHLD handling a bit (Bug#14569).
3925 * process.c, process.h (catch_child_signal):
3926 Now always extern, even if !NS_IMPL_GNUSTEP.
3927 * process.c (catch_child_signal): Move glib tickler here from
3928 init_process_emacs, so that it's done earlier in Emacs
3929 initialization. Also move the noninteractive && !initialized
3930 check here from init_process_emacs. This is all a bit cleaner for
3931 GNUish platforms, and I hope it works around the Cygwin bug.
3932 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3933 that glib signal handling is tickled before glib creates threads.
3934
f86852b4
PE
3935 * process.c (wait_reading_process_output): Avoid int overflow
3936 when reading more than 2 GiB total from a process.
3937
cbd6509c
PE
39382013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3939
3940 * process.c (create_process): Handle a couple more cases,
3941 i.e., work even if new_argv and wait_child_setup[i] are cached.
3942 Use Fcall_process's style for volatile vars.
3943
9de1114a
AS
39442013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3945
3946 * process.c (create_process): Mark PROCESS volatile.
3947
fbe9e0b9
PE
39482013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 Use C99-style flexible array members if available.
3951 This avoids some subtle aliasing issues, which typically
3952 aren't a problem with GCC but may be a problem elsewhere.
3953 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3954 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3955 In either case, it uses a flexible array member rather than
3956 the old struct hack. All uses changed.
3957 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3958 Adjust to sdata reorganization.
3959 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3960 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3961 that ports better to pre-C99 non-GCC.
3962 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3963 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3964 as the latter has changed.
3965 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3966 and port better to pre-C99 GCC.
3967 * image.c (struct xpm_cached_color):
3968 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3969 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3970 Use FLEXIBLE_ARRAY_MEMBER.
3971 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3972 Move decl to top level so it gets checked against implementation.
3973 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3974 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3975
1fc71008
PE
39762013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3977
3978 * syntax.c: Integer cleanups.
3979 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3980 All uses that need 0-or-2 changed to:
3981 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3982 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3983 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3984 (char_quoted, prev_char_comend_first, back_comment)
3985 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3986 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3987 Use bool for boolean.
3988 (update_syntax_table, skip_chars, skip_syntaxes):
3989 Prefer int to unsigned when either will do.
3990 (back_comment): Return boolean success flag, like forw_comment,
3991 instead of positive-or-minus-1 (which might have overflowed int anyway).
3992 Don't stuff ptrdiff_t into int.
3993 (syntax_spec_code, syntax_code_spec): Now const.
3994 (Fmatching_paren, scan_lists, scan_sexps_forward):
3995 Use enum syntaxcode for syntax code.
3996 (Fmatching_paren): Check that arg is a character, not just an integer.
3997 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3998 (Finternal_describe_syntax_value): Omit no-longer-needed
3999 comparison to 0.
4000 (skip_chars): Use char, not unsigned char, when the distinction
4001 doesn't matter.
4002 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
4003 * bytecode.c (exec_byte_code):
4004 * syntax.c (syntax_spec_code, Fchar_syntax)
4005 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4006 (init_syntax_once):
4007 * syntax.h (SYNTAX_WITH_FLAGS):
4008 Omit unnecessary casts.
4009
b932cad7
EZ
40102013-06-20 Eli Zaretskii <eliz@gnu.org>
4011
4012 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
4013 line dimensions here, to avoid race conditions with the main
4014 thread. (Bug#14062, bug#14630, bug#14669)
4015
4016 * w32term.c (w32_draw_window_cursor): Compute the header line and
4017 mode line dimensions here.
4018 <w32_system_caret_window, w32_system_caret_hdr_height>:
4019 <w32_system_caret_mode_height>: New variables.
4020
4021 * w32term.h: Declare them.
4022
89561f72
PE
40232013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4024
5013fc08
PE
4025 * alloc.c (die): Move "assertion failed" string here ...
4026 * lisp.h (eassert): ... from here. Also, suppress evaluation of
4027 COND when SUPPRESS_CHECKING. This shrinks the executable text
4028 size by 0.8% to 2.2% when configured with --enable-checking,
4029 depending on optimization flags (GCC 4.8.1 x86-64).
4030
89561f72
PE
4031 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
4032
763a086d 40332013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
4034
4035 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4036 base is 2; this is more accurate.
4037
983aeb9a
JB
40382013-06-19 Juanma Barranquero <lekktu@gmail.com>
4039
4040 * sound.c (string_default): Move to !WINDOWSNT section.
4041 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4042
178ba3e6
PE
40432013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4044
bbc51b15
PE
4045 * sound.c: Integer cleanups.
4046 Remove unnecessary forward decls.
4047 (struct sound_device): The 'file' member is now a Lisp_Object, not
4048 a char *, so that we needn't invoke alloca on a huge size.
4049 (Fplay_sound_internal): Adjust to this.
4050 (string_default): New function.
4051 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4052 Use it to adjust to the struct sound_device change.
4053 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4054 (be2hs) [0]: Remove.
4055
178ba3e6
PE
4056 * syntax.c (skip_chars): Don't use uninitialized storage
4057 when searching a multibyte buffer for characters that are not in a
4058 unibyte string that contains non-ASCII characters.
4059
69f60cdc
JD
40602013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4061
4062 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4063 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4064
0d6224d4
PE
40652013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4066
4067 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4068
3c542890
KH
40692013-06-18 Kenichi Handa <handa@gnu.org>
4070
f7e3f7cd
KH
4071 * font.c (Ffont_spec): Signal an error for an invalid font name
4072 (Bug#14648).
3c542890 4073
9349e5f7
PE
40742013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4075
4076 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4077 In particular this ports to 32-bit sparc Sun cc.
4078 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4079 array with a dummy element at specpdl[-1], so that its address can
4080 be taken portably.
4081 (unbind_to): Do not copy the binding; not needed, now that we
4082 copy old_value in the one place where the copy is needed.
4083 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4084 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4085 (union specbinding): Rename from struct specbinding. Redo layout
4086 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4087 which is not portable. With Sun C 5.12 32-bit sparc, the
4088 declaration causes nargs to be an unsigned bitfield, a behavior
4089 that the C standard allows; but Emacs wants nargs to be signed.
4090 The overall type is now a union of structures rather than a
4091 structure of union of structures, and the 'kind' member is now a
4092 bitfield, so that the overall type doesn't grow. All uses changed.
4093 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4094
0a4df6a5
PE
40952013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4096
ec6ecaad
PE
4097 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4098 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4099
0a4df6a5
PE
4100 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4101
7bfe8dbc
EZ
41022013-06-17 Eli Zaretskii <eliz@gnu.org>
4103
4104 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4105 unless we know that the window w's frame is a frame object.
4106 Another attempt at solving bug#14062 and bug#14630.
4107
708e05f6
LMI
41082013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4109
4110 * textprop.c (property_set_type): New enum.
4111 (add_properties): Allow appending/prepending text properties.
4112 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4113 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4114 add_text_properties_1.
4115 (Fadd_face_text_property): New function that calls
4116 add_text_properties_1.
4117
84575e67
PE
41182013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 Move functions from lisp.h to individual modules when possible.
4121 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4122 * alloc.c (XFLOAT_INIT, set_symbol_name):
4123 * buffer.c (CHECK_OVERLAY):
4124 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4125 (set_char_table_parent):
4126 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4127 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4128 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4129 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4130 (set_blv_valcell):
4131 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4132 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4133 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4134 (backtrace_args, backtrace_debug_on_exit):
4135 * floatfns.c (CHECK_FLOAT):
4136 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4137 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4138 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4139 (set_hash_index_slot):
4140 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4141 * marker.c (CHECK_MARKER):
4142 * textprop.c (CHECK_STRING_OR_BUFFER):
4143 * window.c (CHECK_WINDOW_CONFIGURATION):
4144 Move here from lisp.h, and make these functions static rather than
4145 extern inline.
4146 * buffer.c (Qoverlayp):
4147 * data.c (Qsubrp):
4148 * fns.c (Qhash_table_p):
4149 * window.c (Qwindow_configuration_p):
4150 Now static.
4151 * lisp.h: Remove the abovementioned defns and decls.
4152
44e18199 4153 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4154 In lisp.h, prefer functions to function-like macros, and
4155 constants to object-like macros, when either will do. This:
4156 . simplifies use, as there's no more need to worry about
4157 arguments' side effects being evaluated multiple times.
4158 . makes the code easier to debug on some platforms.
4159 However, when using gcc -O0, keep using function-like macros
4160 for a few critical operations, for performance reasons.
4161 This sort of thing isn't needed with gcc -Og, but -Og
4162 is a GCC 4.8 feature and isn't widely-enough available yet.
4163 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4164 Remove enum lsb_bits; no longer needed.
4165 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4166 * buffer.c (Qoverlap):
4167 * data.c (Qsubrp):
4168 * fns.c (Qhash_table_p):
4169 Now extern, so lisp.h can use these symbols.
4170 * dispextern.h: Include character.h, for MAX_CHAR etc.
4171 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4172 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4173 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4174 (GLYPH_CODE_P): Move here from lisp.h.
4175 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4176 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4177 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4178 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4179 XUNTAG now returns void *.
4180 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4181 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4182 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4183 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4184 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4185 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4186 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4187 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4188 New macros, renamed from their sans-lisp_h_ counterparts.
4189 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4190 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4191 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4192 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4193 If compiling via GCC without optimization, define these as macros
4194 in addition to inline functions.
4195 To disable this, compile with -DINLINING=0.
4196 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4197 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4198 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4199 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4200 (INTMASK, VALMASK): Now macros, since static values cannot be
4201 accessed from extern inline functions.
4202 (VALMASK): Also a constant, for benefit of old GDB.
4203 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4204 is INTEGERP, which can fold it in.
5165d44a 4205 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4206 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4207 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4208 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4209 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4210 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4211 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4212 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4213 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4214 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4215 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4216 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4217 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4218 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4219 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4220 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4221 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4222 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4223 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4224 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4225 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4226 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4227 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4228 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4229 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4230 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4231 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4232 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4233 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4234 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4235 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4236 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4237 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4238 Now functions.
4239 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4240 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4241 (VALMASK): Define in one place rather than in two, merging the
4242 USE_LSB_TAG parts; this is simpler.
4243 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4244 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4245 Move up, to avoid use before definition.
4246 Also include "globals.h" earlier, for the same reason.
4247 (make_natnum): New function.
4248 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4249 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4250 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4251 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4252 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4253 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4254 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4255 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4256 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4257 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4258 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4259 (Qwindow_configuration_p, Qimage): New forward declarations.
4260 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4261 (STRING_COPYIN): Remove; unused.
4262 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4263 (xcar_addr, xcdr_addr): New functions. All uses changed.
4264 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4265 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4266 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4267 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4268 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4269 (TYPE_RANGED_INTEGERP): Simplify.
4270 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4271 (setlocale, fixup_locale, synchronize_system_messages_locale)
4272 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4273 Now empty functions, not macros.
4274 (functionp): Return bool, not int.
4275 * window.c (Qwindow_configuration_p): Now extern,
4276 so window.h can use it.
4277 * window.h (Qwindowp): Move decl back to lisp.h.
4278
9583ec36
EZ
42792013-06-15 Eli Zaretskii <eliz@gnu.org>
4280
4281 * xdisp.c (Fline_pixel_height): New function, required for solving
4282 bug #14567.
4283
210272ce
PE
42842013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4287
de0503df
SM
42882013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4289
4290 * lread.c (syms_of_lread):
4291 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4292
afbfe143
KD
42932013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4294
4295 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4296
d177e213
XF
42972013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4298
4299 * fileio.c (expand_file_name): Doc fix.
4300
05e3e412
PE
43012013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4302
f7394b12
PE
4303 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4304 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4305 Wait for self, not for 0. This can't hurt on GNU or similar
4306 system, and may help with Cygwin.
4307
05e3e412
PE
4308 * keyboard.c: Don't use PROP (...) as an lvalue.
4309 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4310 Use set_prop (A, B), not PROP (A) = B.
4311
17dd3097
EZ
43122013-06-10 Eli Zaretskii <eliz@gnu.org>
4313
4314 * xdisp.c (get_it_property): Use it->window instead of generating
4315 a Lisp object from it->w.
4316
52fab9c9
EZ
43172013-06-09 Eli Zaretskii <eliz@gnu.org>
4318
4319 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4320 get-char-property the window that is being rendered, instead of
4321 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4322 (compute_display_string_pos): When W is NULL, use the current
4323 buffer as the object to pass to get-char-property.
4324 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4325 pointer member of the bidi iterator, since no window is pertinent
4326 to this function.
52fab9c9 4327
5bf97bfc
EZ
43282013-06-08 Eli Zaretskii <eliz@gnu.org>
4329
4330 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4331 being displayed, and pass it to compute_display_string_pos.
4332 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4333 (bidi_paragraph_init): All callers changed.
4334
4335 * xdisp.c (init_from_display_pos, init_iterator)
4336 (handle_single_display_spec, next_overlay_string)
4337 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4338 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4339 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4340 (compute_display_string_pos): Accept additional argument, the
4341 window being displayed, and pass it to Fget_char_property.
4342 (Bug#14575)
4343
4344 * dispextern.h (struct bidi_it): New member w, the window being
4345 displayed.
4346 (compute_display_string_pos): Adjust prototype.
4347
5de0e011
JD
43482013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4349
e7b41c4c 4350 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4351
4352 * process.c (wait_reading_process_output): Check for NS before GLIB.
4353 GLIB may be linked in due to rsvg, but ns_select must be called.
4354
5de0e011
JD
4355 * xgselect.c (xg_select): Remove call to window_system_available
4356 and g_main_context_pending at the top, so Gdk events (i.e. file
4357 notify) are processed when Emacs is started with -nw.
4358
a822acff
EZ
43592013-06-07 Eli Zaretskii <eliz@gnu.org>
4360
4361 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4362 (ctagsfiles3): New variable, includes only *.m files.
4363 (TAGS): Use an explicit language name in the regular expressions,
4364 to avoid transformation of '/SOMETHING' by MSYS to
4365 'c:\MSYS\SOMETHING'.
4366
6c0a9ed1
RC
43672013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4368
4369 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4370
9ef6111b
EZ
43712013-06-06 Eli Zaretskii <eliz@gnu.org>
4372
4373 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4374 still need to set the mouse pointer shape and activate help-echo.
4375 (Bug#14558)
4376
7d300d64
PE
43772013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4378
4379 A few porting etc. fixes for the new file monitor code.
4380 See the thread containing
4381 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4382 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4383 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4384 (dir_monitor_callback, Fgfile_rm_watch):
4385 Use assq_no_quit instead of Fassoc, for speed.
4386 (dir_monitor_callback, Fgfile_rm_watch):
4387 eassert that the monitor is a fixnum.
4388 (dir_monitor_callback): No need for CDR_SAFE.
4389 Simplify building of lisp with alternative tails.
4390 (Fgfile_add_watch, Fgfile_rm_watch):
4391 Do not assume glib functions set errno reliably on failure.
4392 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4393 and signal an error otherwise.
4394 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4395 Use Fdelq instead of Fdelete, for speed.
4396
817ebfcf
EZ
43972013-06-05 Eli Zaretskii <eliz@gnu.org>
4398
4399 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4400 don't insist on being invoked on a highlighted tool-bar button.
4401 Avoids losing tool-bar functionality when mouse-highlight is nil.
4402 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4403 Don't highlight when mouse-highlight is nil.
4404 (note_mouse_highlight): When mouse-highlight is nil, don't return
4405 right away; instead, run tool-bar and mode-line highlight
4406 subroutine, clear any existing highlight, and revert the mouse
4407 pointer to its default shape. (Bug#14558)
4408
55577e7c
SM
44092013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4410
4411 * lisp.mk (lisp): Add prog-mode.el.
4412
f019a684
PE
44132013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4414
4415 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4416 * process.c (dummy_handler): New function.
4417 (lib_child_handler): New static var.
4418 (handle_child_signal): Invoke it.
4419 (catch_child_signal): If a library has set up a signal handler,
4420 save it into lib_child_handler.
4421 (init_process_emacs): If using glib and not on Windows, tickle glib's
4422 child-handling code so that it initializes its private SIGCHLD handler.
4423 * syssignal.h (SA_SIGINFO): Default to 0.
4424 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4425 31; it should no longer be needed now.
4426
90db8702
MA
44272013-06-05 Michael Albinus <michael.albinus@gmx.de>
4428
4429 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4430
4431 * gfilenotify.c (globals_of_gfilenotify): New function.
4432 (syms_of_gfilenotify): Move global initialization there.
4433
4434 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4435
bfa3acd6
SM
44362013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4437
4438 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4439 * keyboard.c (menu_bar_items, tool_bar_items):
4440 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4441 not override local keymaps any more.
4442
ba59bd80
EZ
44432013-06-04 Eli Zaretskii <eliz@gnu.org>
4444
4445 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4446
7f203aa1
EZ
44472013-06-03 Eli Zaretskii <eliz@gnu.org>
4448
9337e206
EZ
4449 * w32console.c (initialize_w32_display): Return the dimensions of
4450 the console window via 2 additional arguments, not via the current
4451 frame. This avoids crashes due to overrunning the bounds of
4452 frame's decode_mode_spec_buffer, which is not resized following
4453 the change of the frame dimensions from the initial 10x10.
4454
4455 * w32term.h (w32_initialize_display_info): Adjust prototype.
4456
4457 * term.c (init_tty): Take dimensions of the frame from the values
4458 returned by initialize_w32_display.
4459
7f203aa1
EZ
4460 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4461 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4462 (LIBES): Add $(GFILENOTIFY_LIBS).
4463
4464 * w32inevt.c (handle_file_notifications): Add dummy implementation
4465 for !HAVE_W32NOTIFY.
4466
4467 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4468
55a87246
JD
44692013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4470
4471 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4472
4473 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4474
4475 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4476
3d5ee10a
PE
44772013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4478
4479 Fix minor problems found by static checking.
4480 * data.c (pure_write_error):
4481 Use xsignal2, not Fsignal, as Fsignal might return.
4482 * eval.c (set_backtrace_debug_on_exit): Now static.
4483 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4484 No longer inline. EXTERN_INLINE is needed only for functions
4485 defined in .h files. Reindent function header as per GNU style.
4486 (backtrace_p, backtrace_top, backtrace_next):
4487 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4488 compiler or linker. Add extern decls to pacify gcc -Wall.
4489 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4490 Now static.
4491 * frame.c (free_monitors): Define only on platforms that need it.
4492 * nsterm.m (ns_term_init):
4493 * process.c (catch_child_signal):
4494 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4495 defined on all porting targets these days.
4496 * process.c, process.h (catch_child_signal):
4497 Make it extern only if NS_IMPL_GNUSTEP is defined.
4498
e2d8a6f0
EZ
44992013-06-03 Eli Zaretskii <eliz@gnu.org>
4500
4501 * w32.c (gettimeofday): Make the signature identical to prototype
4502 in nt/inc/sys/time.h.
4503
a8a7c5f6
SM
45042013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4505
4506 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4507 .gdbinit.
4508
4509 * keyboard.c (safe_run_hooks_error): Improve error message.
4510
4511 * data.c (pure_write_error): Add `object' argument.
4512 * puresize.h (CHECK_IMPURE): Use it.
4513
c9628c79
MA
45142013-06-03 Michael Albinus <michael.albinus@gmx.de>
4515
4516 * Makefile.in (NOTIFY_OBJ): New variable.
4517 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4518
4519 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4520 Call syms_of_gfilenotify.
4521
4522 * gfilenotify.c: New file.
4523
4524 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4525 and Qfile_w32notify.
4526 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4527 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4528
4529 * lisp.h: Declare syms_of_gfilenotify.
4530
4531 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4532
2f592f95
SM
45332013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4534
4535 Merge the specpdl and backtrace stacks. Make the structure of the
4536 specpdl entries more obvious via a tagged union of structs.
4537 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4538 (enum specbind_tag): New enum.
4539 (struct specbinding): Make it a tagged union of structs.
4540 Add a case for backtrace records.
4541 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4542 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4543 (backtrace_debug_on_exit): New accessors.
4544 (struct backtrace): Remove.
4545 (struct catchtag): Remove backlist field.
4546 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4547 Move to eval.c.
4548 (Flocal_variable_p): Speed up the common case where the binding is
4549 already loaded.
4550 * eval.c (backtrace_list): Remove.
4551 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4552 (set_backtrace_args, set_backtrace_nargs)
4553 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4554 (backtrace_next): New functions.
4555 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4556 (unwind_to_catch, internal_lisp_condition_case)
4557 (internal_condition_case, internal_condition_case_1)
4558 (internal_condition_case_2, internal_condition_case_n): Don't bother
4559 with backtrace_list any more.
4560 (Fsignal): Adjust to new backtrace format.
4561 (grow_specpdl): Move up.
4562 (record_in_backtrace): New function.
4563 (eval_sub, Ffuncall): Use it.
4564 (apply_lambda): Adjust to new backtrace format.
4565 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4566 data.c.
4567 (specbind): Adjust to new specpdl format. Simplify.
4568 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4569 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4570 backtrace format.
4571 (mark_backtrace): Remove.
4572 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4573 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4574 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4575 Use mark_specpdl.
4576 * profiler.c (record_backtrace): Use get_backtrace.
4577 (handle_profiler_signal): Use backtrace_top_function.
4578 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4579 accessor functions.
4580
c0342369
JD
45812013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4582
4583 * process.h (catch_child_signal): Declare.
4584
4585 * process.c (catch_child_signal): New function.
4586 (init_process_emacs): Call it.
4587
4588 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4589 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4590 NS_IMPL_COCOA.
4591 (x_set_cursor_type): Remove declaration.
4592 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4593 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4594 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4595 (ns_get_color): Use F suffix on float.
4596 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4597 (ns_get_rgb_color): Remove.
4598 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4599 (note_mouse_movement): x and y are CGFloat.
4600 (ns_draw_fringe_bitmap): Remove unused rowY.
4601 Change #if to COCOA && >= 10_6.
4602 (ns_draw_window_cursor): Remove unused overspill.
4603 (ns_draw_underwave): width and x are EamcsCGFloat.
4604 (ns_draw_box): thickness is CGFloat.
4605 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4606 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4607 if not in main thread.
4608 (ns_get_pending_menu_title, ns_check_menu_open)
4609 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4610 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4611 (sendFromMainThread:): New method.
4612 (changeFont:): size is CGFloat.
4613 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4614 Disable warning about permanent text.
4615 (characterIndexForPoint:): Adjust return type depending on GNUStep
4616 version.
4617 (mouseDown:): delta is CGFloat.
4618 (updateFrameSize): Remove unised variable f.
4619 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4620 Cast float to EmacsCGFloat.
4621 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4622 also to -1 when restoring.
4623 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4624 inside NS_IMPL_COCOA.
4625 (toggleFullScreen:): Put call to toggleFullScreen inside
4626 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4627 (setPosition:portion:whole:): por is CGFloat.
4628 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4629 (mouseDown:): Use CGFloat.
4630 (mouseDragged:): Remove unised variable edge.
4631 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4632
4633 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4634 of CGFloat differs.
4635 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4636 when NS_IMPL_GNUSTEP.
4637 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4638 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4639 (EmacsToolbar): Add clearAll. Add tag argument to
4640 addDisplayItemWithImage.
4641 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4642
4643 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4644
4645 * nsmenu.m (ns_update_menubar): Make static.
4646 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4647 (fillWithWidgetValue:): Add cast to SEL for setAction.
4648 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4649 (update_frame_tool_bar): Update code for GNUStep.
4650 (clearAll): New method.
4651 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4652 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4653 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4654 call to insertItemWithItemIdentifier.
4655 (validateVisibleItems): Fix indentation.
4656 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4657 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4658 UtilityWindow to aStyle, remove call to setStyleMask.
4659
4660 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4661
4662 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4663 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4664 Use F suffix on floats.
4665 (ns_char_width): Returns CGFloat.
4666 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4667 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4668 DPSxshow.
4669 (ns_glyph_metrics): CGFloat instead of float.
4670
a0eb10b3
JB
4671 * nsfns.m (x_set_foreground_color, x_set_background_color):
4672 Use EmacsCGFloat.
4673 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4674 remove unused variables.
4675 (Fns_read_file_name): Keep track if panel is for save.
4676 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4677 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4678 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4679 Just return the input if GNUStep.
c0342369
JD
4680 (x_screen_planes): Remove.
4681 (Fxw_color_values): Use EmacsCGFloat
4682 (Fns_display_monitor_attributes_list): Only get screen number for
4683 Cocoa.
ef099a94 4684 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4685 EmacsSavePanel.
4686 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4687 ns_directory_from_panel.
4688
da9aff11
PE
46892013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4690
4691 * process.c (handle_child_signal): Also use WCONTINUED.
4692 This is so that list-processes doesn't mistakenly list the process
4693 as stopped, when the process has actually been continued and is
4694 now running.
4695
0e64479a
PE
46962013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4697
fc186a96
PE
4698 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4699 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4700 not already configured.
4701
0e64479a
PE
4702 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4703
38b787fa
EZ
47042013-05-29 Eli Zaretskii <eliz@gnu.org>
4705
4706 * Makefile.in (mostlyclean): Remove *.res files.
4707
22513e52
SM
47082013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4709
4710 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4711 a buffer (bug#8447).
4712
6ef3db10
EZ
47132013-05-27 Eli Zaretskii <eliz@gnu.org>
4714
4715 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4716 display vector, and we backtrack, handle the case that the
4717 previous character position is also displayed from a display
4718 vector or covered by a display string or image. (Bug#14476)
4719
6799bb26
JD
47202013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4721
4722 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4723 (struct MonitorInfo, free_monitors): Remove.
4724 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4725 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4726 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4727 Qframes, Qsource.
4728
4729 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4730 (struct MonitorInfo, free_monitors): Remove.
4731 (ns_screen_name): Make static.
4732 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4733 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4734 Qframes, Qsource.
4735
4736 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4737 (struct MonitorInfo): New struct.
4738 (free_monitors, make_monitor_attribute_list): Declare.
4739
22513e52
SM
4740 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4741 New Lisp_Object:s.
6799bb26
JD
4742 (free_monitors, make_monitor_attribute_list): New functions.
4743 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4744 Qsource.
4745
38cd43eb
XF
47462013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4747
4748 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4749
2af0948d
SM
47502013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4751
a7eb9b0f
SM
4752 * keyboard.c: Apply keyboard decoding only to events that come directly
4753 from the tty, not from unread-command-events (bug#14368).
4754 (read_event_from_main_queue): New function, extracted from read_char).
4755 (read_decoded_char): Remove.
4756 (read_decoded_event_from_main_queue): New function to replace it.
4757 (read_char): Use it.
4758 (read_key_sequence): Use read_char rather than read_decoded_char.
4759
2af0948d
SM
4760 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4761
1413e9a5
BR
47622013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4763
4764 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4765
e6d2f155
KH
47662013-05-22 Kenichi Handa <handa@gnu.org>
4767
4768 The following changes are to fix the setting of
4769 buffer-file-coding-system on, for instance, C-x RET c unix RET
4770 _FILE_OF_DOS_EOL_TYPE_ RET.
4771
4772 * coding.h (struct coding_system): New member detected_utf8_chars.
4773
4774 * coding.c (detect_coding_utf_8): Count characters and check EOL
4775 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4776 BOM is there.
4777 (setup_coding_system): Do not initialize coding->head_ascii.
4778 (check_ascii): Do not set coding->eol_seen but update it. Do not
4779 call adjust_coding_eol_type here.
1413e9a5
BR
4780 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4781 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4782 of the found coding-system.
4783 (decode_coding_gap): Cancel previous change. Utilize the
4784 character numbers counted by detect_coding_utf_8. Fix detection
4785 of BOM for utf-8.
4786
ab56a6f4 47872013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4788
4789 * search.c (looking_at_1): Only set last_thing_searched if the match
4790 changed the match-data (bug#14281).
4791
ecc3c6ed
DA
47922013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4793
4794 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4795 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4796 (move_it_vertically_backward): Likewise.
4797
5ba8bf35
YM
47982013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4799
4800 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4801 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4802 (Fx_display_mm_width, Fx_display_mm_height):
4803 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4804
91e8418b 4805 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4806 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4807 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4808 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4809 (Fx_display_backing_store, Fx_display_visual_class)
4810 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4811 (Fx_display_grayscale_p, Fx_display_pixel_width)
4812 (Fx_display_pixel_height, Fx_display_planes)
4813 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4814 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4815 (Fx_display_mm_width, Fx_display_mm_height)
4816 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4817 height for all physical monitors as in X11.
4818
fc30d803
SM
4819 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4820 Return pixel width or height for all physical monitors as in X11.
91e8418b 4821
31ff141c
PE
48222013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4823
4824 Port --enable-gcc-warnings to clang.
4825 * bytecode.c (exec_byte_code):
4826 * regex.c:
4827 Redo diagnostic pragmas to pacify clang, too.
4828 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4829 * editfns.c (Fencode_time):
4830 * fileio.c (file_accessible_directory_p):
4831 * font.c (font_unparse_xlfd):
4832 Use '&"string"[index]' instead of '"string" + (index)'.
4833 * undo.c (user_error): Remove; unused.
4834
df065a0b
EZ
48352013-05-16 Eli Zaretskii <eliz@gnu.org>
4836
04d360e7
EZ
4837 * insdel.c (insert_1_both): Document the arguments, instead of
4838 referring to insert_1, which no longer exists.
4839
5bb98290
EZ
4840 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4841 some window, increment windows_or_buffers_changed, so that
4842 *Messages* display in that window is updated. (Bug#14408)
4843
df065a0b
EZ
4844 * w32.c: Include epaths.h.
4845 (init_environment): Use cmdproxy.exe without leading directories.
4846 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4847 case.
4848 (gettimeofday): Adjust signature and return value to Posix
4849 expectations.
4850
4851 * unexw32.c (open_output_file): Delete the existing emacs.exe
4852 before creating it, to break the hard link to the versioned
4853 executable.
4854
4855 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4856 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4857 (FIRSTFILE_OBJ): New variables.
4858 (W32_RES): Rename to EMACSRES. All users changed.
4859 (base_obj): Use $(CM_OBJ).
4860 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4861 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4862 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4863 $(W32_RES_LINK) before $(LIBES).
4864 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4865
1aa8d505
SM
48662013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4867
6e911150
SM
4868 * makefile.w32-in (DOC): Use just "DOC".
4869
4870 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4871
1aa8d505
SM
4872 * process.c: Export default filters and sentinels to Elisp.
4873 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4874 New constants.
4875 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4876 (Fset_process_sentinel, Fformat_network_address):
4877 Default to them instead of nil.
4878 (server_accept_connection): Sentinels can't be nil any more.
4879 (read_and_dispose_of_process_output): New function, extracted from
4880 read_process_output.
4881 (read_process_output): Use it; filters can't be nil.
4882 (Finternal_default_process_filter): New function, extracted from
4883 read_process_output.
4884 (exec_sentinel_unwind): Remove function.
4885 (exec_sentinel): Don't zilch sentinel while running.
4886 (status_notify): Sentinels can't be nil.
4887 (Finternal_default_process_sentinel): New function extracted from
4888 status_notify.
4889 (setup_process_coding_systems): Default filter is not nil any more.
4890 (syms_of_process): Export new Elisp functions and initialize
4891 new constants.
4892 * lisp.h (make_lisp_proc): New function.
4893
5ac2eb34
SM
48942013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4895
4896 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4897
eda9c7d7
EZ
48982013-05-14 Eli Zaretskii <eliz@gnu.org>
4899
4900 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4901 unless we know that the window w is a leaf window.
4902 Another attempt at solving bug#14062.
eda9c7d7 4903
8fdeaad5
JD
49042013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4905
4906 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4907 fdesc (Bug#14375).
4908
44aa9ee6
PE
49092013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4910
4911 * image.c (gif_load): Check that subimages fit (Bug#14345).
4912
759fd763
SM
49132013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4914
4915 * lread.c (skip_dyn_eof): New function.
4916 (read1): Use it to skip the end of a file in response to #@00.
4917
4918 * doc.c (get_doc_string): Slightly relax the sanity checking.
4919
4465bfb4
JD
49202013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4921
4922 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4923 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4924 (MonitorInfo): New struct.
4925 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4926 (Fns_display_monitor_attributes_list): New functions.
4927 (display-usable-bounds): Remove.
4928 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4929 Qsource.
4930
7583e2a0
PE
49312013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4932
4933 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4934 (GTK_CHECK_VERSION): New macro, if not already defined.
4935 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4936 replaced by GTK_CHECK_VERSION.
4937
ad75d77e
PE
49382013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4939
4940 * xterm.h (GTK_PREREQ): New macro.
4941 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4942 to use this macro instead, for consistency and clarity.
4943
07525f77
EZ
49442013-05-08 Eli Zaretskii <eliz@gnu.org>
4945
4946 * xdisp.c (row_for_charpos_p): New function, with code of
4947 cursor_row_p, but accepts an additional argument CHARPOS instead
4948 of using a hardcoded PT.
4949 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4950 (row_containing_pos): Call row_for_charpos_p instead of partially
4951 doing the same. Fixes cursor positioning under longlines-mode
4952 when longlines-show-effect includes more than one newline, when
4953 moving the cursor vertically up.
4954
d901fc8d
JB
49552013-05-08 Juanma Barranquero <lekktu@gmail.com>
4956
4957 * makefile.w32-in (ACL_H): New macro.
4958 ($(BLD)/fileio.$(O)): Update dependencies.
4959
f269bc61
PE
49602013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4961
e7b41c4c 4962 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4963 * Makefile.in (LIB_ACL): New macro.
4964 (LIBACL_LIBS): Remove.
4965 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4966 * fileio.c: Include <acl.h>.
4967 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4968 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4969 !acl_errno_valid.
4970 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4971 it ourselves.
4972
f269bc61
PE
4973 * unexelf.c: Don't assume ElfW (Half) fits in int.
4974 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4975 when dealing with ElfW (Half) values, since they can exceed 2**31
4976 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4977 (entry_address): Omit unused NUM arg. All uses changed.
4978
a261c53e
JL
49792013-05-07 Juri Linkov <juri@jurta.org>
4980
4981 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4982 to the string converted from number with `Fnumber_to_string'.
4983 (Bug#14254)
4984
2b66427d
PE
49852013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4986
4987 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4988 This fixes a problem introduced by my previous change.
4989
15acfe41
GM
49902013-05-07 Glenn Morris <rgm@gnu.org>
4991
4992 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4993
5ea03bf5
JD
49942013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4995
4996 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4997
e0c9d565
PE
49982013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4999
5000 Static checking by GCC 4.8.0.
5001 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
5002 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
5003 (x_get_monitor_attributes_fallback)
5004 (x_get_monitor_attributes_xinerama)
5005 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
5006 Define only if USE_GTK.
5007 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
5008 (x_get_monitor_attributes_fallback): Omit unused locals.
5009 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
5010 Use double, not float, to avoid mixed-mode floating point arithmetic.
5011
4e3f9230
YM
50122013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5013 Jan Djärv <jan.h.d@swipnet.se>
5014
5015 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
5016 (XINERAMA_CFLAGS): New macros.
5017 (ALL_CFLAGS, LIBES): Use them.
5018
5019 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
5020 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
5021 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
5022 (syms_of_xfns): DEFSYM them.
5023 (struct MonitorInfo): New struct.
5024 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
5025 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
5026 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
5027 (x_get_monitor_attributes_xinerama): New functions.
5028 (Fx_display_monitor_attributes_list): New primitive.
5029 (syms_of_xfns): Defsubr it.
5030
5031 * xterm.h (x_display_info): Add Xatom_net_workarea and
5032 Xatom_net_current_desktop.
5033
5034 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5035 and dpyinfo->Xatom_net_current_desktop.
5036
05839b6a
EZ
50372013-05-06 Eli Zaretskii <eliz@gnu.org>
5038
5039 * xdisp.c (pos_visible_p): Use the special code for finding the
5040 beginning of a display property or overlay for any "replacing"
5041 display property, not just for display strings. This solves
5042 incorrect reporting of position by posn-at-point. (Bug#14241)
5043
dc4a2ee0
PE
50442013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5045
5ee94506
PE
5046 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5047 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5048 Verify that ElfW (Half) fits in int.
5049 (fatal): Use same signature as lisp.h.
5050 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5051 configure and build with -DUNEXELF_DEBUG without worrying about
5052 other modules that use DEBUG.
5053 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5054 possibly-wide integers now uses it instead of plain fprintf.
5055 (entry_address): New function, which avoids problems with 32-bit
5056 overflow on 64-bit hosts.
5057 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5058 (round_up): Don't assume the remainder fits in int.
5059 (find_section): Use bool for boolean. Simplify debug code.
5060 (unexec): Don't assume file sizes fit in int or size_t.
5061 Omit unnecessary trailing newline in 'fatal' format.
5062 Use strerror rather than outputting decimal error number.
5063 Remove unused code when emacs is not defined;
5064 this file relies on Emacs now.
5065 Don't assume e_phnum and e_shnum are positive.
5066
dc4a2ee0
PE
5067 * regex.c: Fix problems when DEBUG is defined.
5068 (extract_number, extract_number_and_incr): Define regardless of
5069 whether DEBUG is defined; that's simpler and makes the code less
5070 likely to go stale in the normal case when DEBUG is not defined.
5071 Return int rather than taking an int * arg. All callers changed.
5072 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5073 Remove, replacing with ...
5074 (DEBUG_PRINT): New macro. All callers changed.
5075 (DEBUG_COMPILES_ARGUMENTS): New macro.
5076 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5077 (print_compiled_pattern, print_double_string) [DEBUG]:
5078 Use prototype rather than old-style definition.
5079 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5080 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5081 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5082 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5083 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5084 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5085 This matters only when DEBUG is defined.
5086
14c7ed05
EZ
50872013-05-05 Eli Zaretskii <eliz@gnu.org>
5088
5089 * xdisp.c (set_iterator_to_next): Set the
5090 ignore_overlay_strings_at_pos_p flag only if we are _really_
5091 iterating over an overlay string, as indicated by the
5092 current.overlay_string_index member. (Bug#14306)
5093
e6076b1b
JD
50942013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5095
5096 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5097 to where it is used, to avoid autorelease issues (Bug#14050).
5098
cbee2131
PE
50992013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5102 * fileio.c (syms_of_fileio): Implement this.
5103 * filelock.c (create_lock_file): If symbolic links don't work, so
5104 we use a regular file as a lock file, do not fsync the lock file;
5105 it's not needed.
5106
30c7e542
SM
51072013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5108
5109 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5110 (syms_of_minibuf): Adjust accodingly.
5111 * lread.c (Fread):
5112 * callint.c (Fcall_interactively): Adjust calls accordingly.
5113
5bebd186
EZ
51142013-05-04 Eli Zaretskii <eliz@gnu.org>
5115
5116 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5117 w->contents is a buffer before computing everything else.
5118 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5119
5120 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5121 assertion violations. (Bug#14062)
5122
0fb0a4f3
DR
51232013-05-01 David Reitter <david.reitter@gmail.com>
5124
5125 * nsfns.m (ns_tooltip): Initialize.
5126
9e63b4a5
EZ
51272013-04-28 Eli Zaretskii <eliz@gnu.org>
5128
5129 * coding.c (decode_coding_gap): Don't remove the character before
5130 a newline unless it's a CR character. (Bug#14287)
5131
ad60824e
DN
51322013-04-28 Dan Nicolaescu <dann@gnu.org>
5133
5134 * dispextern.h (struct face): Move enum face_underline_type
5135 earlier so that bitfields can be in the same word.
5136
edbdcec0
JD
51372013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5138
5139 * nsfns.m (handlePanelKeys): New function.
5140 (EmacsOpenPanel:performKeyEquivalent:)
5141 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5142 arrows/function/control and copy/paste keys (Bug#14296).
5143
0208ede7
JL
51442013-04-27 Juri Linkov <juri@jurta.org>
5145
5146 * callint.c (Fcall_interactively): Call `Qread_number' for
5147 interactive code letter `n' instead of using duplicate code.
5148 (Bug#14254)
5149
b8dd59f7
PE
51502013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5151
5152 * systime.h (make_timeval): Declare as 'const'.
5153
8bd722db
KH
51542013-04-27 Kenichi Handa <handa@gnu.org>
5155
5156 * font.c (font_open_entity): Always open a font of manageable
5157 size.
5158
13d0e56f 51592013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5160
f780d632
PE
5161 Port better to AIX (Bug#14258).
5162 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5163 to pacify AIX xlc.
5164
ec509856
KH
51652013-04-24 Kenichi Handa <handa@gnu.org>
5166
5167 * coding.c (decode_coding_iso_2022): When an invalid escape
5168 sequence is encountered, reset the invocation and designation
5169 status to the safest one.
5170
84fc48e5
PE
51712013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5172
5173 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5174 Without this fix, "make distclean" leaves stamp-h1 behind.
5175
806bda47
EC
51762013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5177
5178 * w32fns.c (w32_fullscreen_rect): New function to compute the
5179 window rectangle for the given fullscreen mode.
5180 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5181 longer tunes the window size. This keeps the window's edges flush
5182 with the screen and allows the taskbar to hide itself in fullboth.
5183
5184 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5185 window decorations and uses the entire screen.
5186
5187 * w32term.h (w32_fullscreen_rect) Add prototype.
5188 (struct w32_output): Replace normal_width, normal_height,
5189 normal_top, and normal_left members with a single normal_placement
5190 struct.
5191 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5192 Remove macros.
5193 (FRAME_NORMAL_PLACEMENT): New macro.
5194
9cc2810b
JB
51952013-04-16 Juanma Barranquero <lekktu@gmail.com>
5196
5197 * minibuf.c (Ftest_completion): Silence compiler warning.
5198
fd16b54c
EZ
51992013-04-15 Eli Zaretskii <eliz@gnu.org>
5200
5201 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5202 bug#14062.
fd16b54c
EZ
5203
5204 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5205 parentheses.
5206
5207 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5208 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5209 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5210 parentheses where appropriate.
5211
9e3379a0
PE
52122013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5213
5214 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5215
ddd6b685
EZ
52162013-04-14 Eli Zaretskii <eliz@gnu.org>
5217
5218 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5219 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5220 Mention in the doc string that setting these variables takes
5221 effect only after a call to set-window-buffer. (Bug#14200)
5222
29b79ba1
EZ
52232013-04-13 Eli Zaretskii <eliz@gnu.org>
5224
5225 * indent.c (Fvertical_motion): Don't consider display strings on
5226 overlay strings as display strings on the buffer position we
5227 started from. This prevents vertical cursor motion from jumping
5228 more than one line when there's an overlay string with a display
5229 property at end of line.
5230 Reported by Karl Chen <Karl.Chen@quarl.org> in
5231 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5232
562c6ee9
SM
52332013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5234
5235 * window.c (select_window): `record_buffer' even if window is
5236 already selected (bug#14191).
5237
fcc1fe85
EZ
52382013-04-11 Eli Zaretskii <eliz@gnu.org>
5239
5240 * window.c (Fwindow_end): Test more flags, including the buffer's
5241 last_overlay_modified flag, to determine whether the window's
5242 display is really up-to-date. Prevents the function from
5243 returning a stale value. (Bug#14170)
5244 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5245 current matrix.
5246
f009190a
EZ
52472013-04-10 Eli Zaretskii <eliz@gnu.org>
5248
5249 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5250 garbaged only if it is not already the top frame on its TTY.
5251 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5252 there are GUI frames open in the same session. (Bug#13864)
5253
78ce603d
SM
52542013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5255
5256 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5257 of marking the idle timers directly.
5258
a8036e40
SM
52592013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5260
5261 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5262 tables (bug#14054).
5263
7ffe7ef6
SM
52642013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5265
5266 * window.c (select_window): Don't record_buffer while the invariant is
5267 temporarily broken (bug#14161).
5268
5269 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5270
7d9f6883
EZ
52712013-04-07 Eli Zaretskii <eliz@gnu.org>
5272
5273 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5274
5406cfd9
RF
52752013-04-07 Romain Francoise <romain@orebokech.com>
5276
5277 Ignore additional platform-specific ACL errors (Bug#13702).
5278 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5279 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5280
95c0e83b
JD
52812013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5282
5283 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5284 f->output_data.ns.
5285
876da980
PE
52862013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5287
5288 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5289 This bug was introduced by my 2013-02-25 change that simplified
5290 data_start configuration. Without this change, on GNU/Linux
5291 an Emacs configured with --enable-profiling fails immediately
5292 due to a profiler signal.
5293 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5294 with these flags. On platforms where special flags are needed
5295 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5296 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5297 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5298
7452b7bd
DA
52992013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5300
5301 Get rid of some platform-specific functions examining window
5302 system and its capabilities. This is a partial rework of the
5303 2013-04-05 change.
5304 * lisp.h (have_menus_p): Remove prototype. This function is
5305 replaced with platform-independent window_system_available.
5306 (check_window_system): Move to...
5307 * frame.h (decode_window_system_frame, window_system_available):
5308 ...here, add new prototypes.
5309 * frame.c (window_system_available, decode_window_system_frame):
5310 New functions.
5311 (check_window_system): Platform-independent now.
5312 * xterm.h (x_in_use): Remove declaration.
5313 (check_x_frame):
5314 * w32term.h (check_x_frame):
5315 * nsterm.h (check_x_frame): Remove prototypes. This function
5316 is replaced with platform-independent decode_window_system_frame.
5317 * msdos.c (have_menus_p): Remove.
5318 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5319 Remove platform-specific functions. Use check_window_system,
5320 decode_window_system_frame and check_ns_display_info where
5321 appropriate. Minor style and comment tweaks.
5322 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5323 (check_x_frame): Likewise.
5324 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5325 Likewise.
5326 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5327 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5328 * xmenu.c, xselect.c: All related users changed.
5329
251e9147
KH
53302013-04-03 Kenichi Handa <handa@gnu.org>
5331
5332 The following changes is to optimize the code for reading UTF-8
5333 files.
5334
562c6ee9 5335 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5336 changed. Check EOL format. Do not call adjust_coding_eol_type
5337 here.
5338 (check_utf_8): New function.
5339 (adjust_coding_eol_type): Do nothing if already adjusted.
5340 (detect_coding): Compare the return value of check_ascii with
5341 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5342 (decode_coding_gap): Optimize for valid UTF-8.
5343
8bc369d4
KH
53442013-03-21 Kenichi Handa <handa@gnu.org>
5345
5346 * coding.c (syms_of_coding): Cancel previous change.
5347
5348 * insdel.c (insert_from_gap): Fix previous change.
5349
73931ad1
DA
53502013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5351
5352 Consistently use platform-specific function to detect window system.
5353 * lisp.h (check_window_system): New prototype. This function is
5354 going to replace check_x, check_w32 and check_ns.
5355 (have_menus_p): Mention msdos.c in comment.
5356 * fontset.c (check_window_system_func): Remove. Adjust all users.
5357 * fontset.h (check_window_system_func): Remove prototype.
5358 * nsterm.h (check_ns):
5359 * xterm.h (check_x):
5360 * w32term.h (check_w32): Likewise.
5361 * menu.c (Fx_popup_menu): Use check_window_system.
5362 * msdos.c (check_window_system): Define for MS-DOS.
5363 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5364 * w32fns.c (check_window_system): Likewise for MS-Windows.
5365 * xfns.c (check_window_system): Likewise for X.
5366 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5367 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5368
7216e43b
PE
53692013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5370
5371 Prefer < to > in range checks such as 0 <= i && i < N.
5372 This makes it easier to visualize quantities on a number line.
5373 This patch doesn't apply to all such range checks,
5374 only to the range checks affected by the 2013-03-24 change.
5375 This patch reverts most of the 2013-03-24 change.
5376 * alloc.c (xpalloc, Fgarbage_collect):
5377 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5378 * character.c (string_escape_byte8):
5379 * charset.c (read_hex):
5380 * data.c (cons_to_unsigned):
5381 * dispnew.c (update_frame_1):
5382 * doc.c (Fsubstitute_command_keys):
5383 * doprnt.c (doprnt):
5384 * editfns.c (hi_time, decode_time_components):
5385 * fileio.c (file_offset):
5386 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5387 * font.c (font_intern_prop):
5388 * frame.c (x_set_alpha):
5389 * gtkutil.c (get_utf8_string):
5390 * indent.c (check_display_width):
5391 * keymap.c (Fkey_description):
5392 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5393 * lread.c (read1):
5394 * minibuf.c (read_minibuf_noninteractive):
5395 * process.c (wait_reading_process_output):
5396 * search.c (Freplace_match):
5397 * window.c (get_phys_cursor_glyph):
5398 * xdisp.c (redisplay_internal):
5399 * xsmfns.c (smc_save_yourself_CB):
5400 Prefer < to > for range checks.
5401 * dispnew.c (sit_for): Don't mishandle NaNs.
5402 This fixes a bug introduced in the 2013-03-24 change.
5403 * editfns.c (decode_time_components): Don't hoist comparison.
5404 This fixes another bug introduced in the 2013-03-24 change.
5405
92759988
DA
54062013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5407
5408 * frame.h (struct frame): Drop scroll_bottom_vpos
5409 member becaue all real users are dead long ago.
5410 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5411 * xdisp.c (redisplay_internal): Adjust user.
5412
9a1971bb
GM
54132013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5414
f38ab167
JD
5415 * nsmenu.m (showAtX:Y:for:): setLevel to
5416 NSPopUpMenuWindowLevel (Bug#13998).
5417
6d01f1fe
JD
54182013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5419
5420 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5421 (ns_check_pending_open_menu): Declare.
5422
5423 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5424 (x_activate_menubar): Update the menu with title that matches
5425 ns_get_pending_menu_title, and call
5426 ns_check_pending_openmenu (Bug#12698).
5427 (menuWillOpen:): New method.
5428 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5429
5430 * nsterm.m (menu_will_open_state, menu_mouse_point)
5431 (menu_pending_title): New varaibles.
5432 (ns_get_pending_menu_title, ns_check_menu_open)
5433 (ns_check_pending_open_menu): New functions.
5434
781f4782
DA
54352013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5436
5437 * indent.c (current_column_bol_cache): Remove leftover which is not
5438 used in Fmove_to_column any more.
5439 (current_column, scan_for_column): Adjust users.
5440 * keyboard.c (last_point_position_buffer, last_point_position_window):
5441 Remove leftovers which are not used for recording undo any more.
5442 (command_loop_1, syms_of_keyboard): Adjust users.
5443 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5444 redisplay_window any more.
5445 (move_it_to): Adjust user.
5446
1921c31b
JB
54472013-03-29 Juanma Barranquero <lekktu@gmail.com>
5448
5449 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5450 Update dependencies.
5451
717b8bcd
SM
54522013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5453
5454 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5455 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5456 forward references.
5457
e74aeda8
DA
54582013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5459
5460 * window.h (struct window): Replace hchild, vchild and buffer slots
5461 with the only contents slot. This is possible because each valid
5462 window may have either the child window (in vertical or horizontal
5463 combination) or buffer to display (for the leaf window). Using that,
5464 a lof of operations to traverse and/or change window hierarchies may
5465 be simplified. New member horizontal is used to distinguish between
5466 horizontal and vertical combinations of internal windows.
5467 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5468 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5469 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5470 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5471 Use contents slot, not buffer, where appropriate.
5472 (wset_combination): New function.
5473 (wset_buffer): Add eassert.
5474 (Fframe_first_window): Simplify the loop reaching first window.
5475 (Fwindow_buffer): Use WINDOW_LEAF_P.
5476 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5477 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5478 (unshow_buffer): Convert initial debugging check to eassert.
5479 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5480 (make_parent_window, window_resize_check, window_resize_apply)
5481 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5482 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5483 Adjust to match struct window changes.
5484 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5485 (mark_window_cursors_off, count_windows, get_leaf_windows)
5486 (foreach_window_1): Simplify the loop.
5487 * alloc.c (mark_object): Do not check for the leaf window because
5488 internal windows has no glyph matrices anyway.
5489 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5490 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5491 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5492 (build_frame_matrix_from_window_tree, mirror_make_current)
5493 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5494 (update_window_tree, set_window_update_flags): Simplify the loop.
5495 (sync_window_with_frame_matrix_rows): Enforce live window.
5496 Use contents slot, not buffer, where appropriate.
5497 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5498 and WINDOW_HORIZONTAL_COMBINATION_P.
5499 (make_frame_visible_1): Simplify the loop.
5500 Use contents slot, not buffer, where appropriate.
5501 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5502 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5503 (expose_window_tree): Likewise.
5504 Use contents slot, not buffer, where appropriate.
5505 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5506 to avoid deleted windows. Use contents slot instead of buffer.
5507 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5508 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5509 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5510 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5511
121ab1cd
EZ
55122013-03-28 Eli Zaretskii <eliz@gnu.org>
5513
ef454cf7
EZ
5514 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5515 identify the reasons for assertion violations in bug#14062 and
5516 similar ones.
21e930f8
EZ
5517 (Fx_show_tip): Fix compilation error under
5518 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5519
121ab1cd
EZ
5520 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5521 Reported by <rzl24ozi@gmail.com>.
5522
5c89ca24
DA
55232013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5524
5525 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5526 start marker...
562c6ee9
SM
5527 (unwind_with_echo_area_buffer): ...to restore it here.
5528 This is needed to ensure that...
5c89ca24
DA
5529 (redisplay_window): ...both window markers are valid here,
5530 which is verified by eassert.
5531 * editfns.c (save_excursion_save): Do not assume that
5532 selected_window always displays the buffer.
c7f53895
DA
5533 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5534 Fix comment.
5c89ca24 5535
f557c1b1
SM
55362013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5537
5538 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5539 the upcase table.
5540
40693bba 55412013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5542
5543 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5544
c86f791f
EZ
55452013-03-27 Eli Zaretskii <eliz@gnu.org>
5546
5547 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5548 since MinGW's w32api headers do. This avoids compiler warnings.
5549
5550 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5551 if already defined.
5552
c6e72e17
EZ
55532013-03-26 Eli Zaretskii <eliz@gnu.org>
5554
5555 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5556
54e95010
JD
55572013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5558
5559 * gtkutil.c (style_changed_cb): Check if frame is live and an
5560 X frame (Bug#14038).
5561
b88b62de
EZ
55622013-03-26 Eli Zaretskii <eliz@gnu.org>
5563
a18d7de6
EZ
5564 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5565 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5566 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5567 MinGW64.
8f5e14c8
EZ
5568 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5569 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5570
b88b62de
EZ
5571 Fix incompatibilities between MinGW.org and MinGW64 headers.
5572 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5573
5574 * w32.c (REPARSE_DATA_BUFFER): Guard with
5575 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5576
c074e458
JD
55772013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5578
5579 * xterm.c: Include X11/XKBlib.h
5580 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5581
908589fd
AS
55822013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5583
5584 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5585 written backwards.
5586 * blockinput.h (input_blocked_p): Likewise.
5587 * bytecode.c (exec_byte_code): Likewise.
5588 * callproc.c (call_process_kill, call_process_cleanup)
5589 (Fcall_process): Likewise.
5590 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5591 (Fccl_execute_on_string): Likewise.
5592 * character.c (string_escape_byte8): Likewise.
5593 * charset.c (read_hex): Likewise.
5594 * cm.c (calccost): Likewise.
5595 * data.c (cons_to_unsigned): Likewise.
5596 * dired.c (directory_files_internal, file_name_completion):
5597 Likewise.
5598 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5599 (sit_for): Likewise.
5600 * doc.c (Fsubstitute_command_keys): Likewise.
5601 * doprnt.c (doprnt): Likewise.
5602 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5603 * emacsgtkfixed.c: Likewise.
5604 * fileio.c (file_offset, Fwrite_region): Likewise.
5605 * floatfns.c (Fexpt, fmod_float): Likewise.
5606 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5607 Likewise.
5608 * font.c (font_intern_prop): Likewise.
5609 * frame.c (x_set_alpha): Likewise.
5610 * gtkutil.c (get_utf8_string): Likewise.
5611 * indent.c (check_display_width): Likewise.
5612 * intervals.c (create_root_interval, rotate_right, rotate_left)
5613 (split_interval_right, split_interval_left)
5614 (adjust_intervals_for_insertion, delete_node)
5615 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5616 (merge_interval_right, merge_interval_left, copy_intervals)
5617 (set_intervals_multibyte_1): Likewise.
5618 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5619 * keymap.c (Fkey_description): Likewise.
5620 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5621 * lread.c (openp, read_integer, read1, string_to_number):
5622 Likewise.
5623 * menu.c (ensure_menu_items): Likewise.
5624 * minibuf.c (read_minibuf_noninteractive): Likewise.
5625 * print.c (printchar, strout): Likewise.
5626 * process.c (create_process, Faccept_process_output)
5627 (wait_reading_process_output, read_process_output, send_process)
5628 (wait_reading_process_output): Likewise.
5629 * profiler.c (make_log, handle_profiler_signal): Likewise.
5630 * regex.c (re_exec): Likewise.
5631 * regex.h: Likewise.
5632 * search.c (looking_at_1, Freplace_match): Likewise.
5633 * sysdep.c (get_child_status, procfs_ttyname)
5634 (procfs_get_total_memory): Likewise.
5635 * systime.h (EMACS_TIME_VALID_P): Likewise.
5636 * term.c (dissociate_if_controlling_tty): Likewise.
5637 * window.c (get_phys_cursor_glyph): Likewise.
5638 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5639 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5640 Likewise.
5641 * xfns.c (Fx_window_property): Likewise.
5642 * xmenu.c (set_frame_menubar): Likewise.
5643 * xselect.c (x_get_window_property, x_handle_dnd_message):
5644 Likewise.
5645 * xsmfns.c (smc_save_yourself_CB): Likewise.
5646 * xterm.c (x_scroll_bar_set_handle): Likewise.
5647
2bf7d27a
DA
56482013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5649
5650 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5651 to be optional or nil. Adjust comment and convert it to docstring.
5652 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5653 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5654
a9ebfa0b
PE
56552013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5656
5657 Static checking by GCC 4.8-20130319.
5658 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5659 * process.c (Fset_process_datagram_address)
5660 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5661 * xdisp.c (get_char_face_and_encoding):
5662 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5663 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5664 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5665
4f3576ee
KB
56662013-03-24 Ken Brown <kbrown@cornell.edu>
5667
789b5e9a
KB
5668 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5669 fix compilation on 64-bit Cygwin, where underscores are not
5670 automatically prepended.
5671
4f3576ee
KB
5672 * w32term.c (w32_initialize): Silence compiler warning.
5673
b5b7745f
EZ
56742013-03-23 Eli Zaretskii <eliz@gnu.org>
5675
cdc0d0bd
EZ
5676 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5677 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5678 variables, to save and restore frame dimensions.
5679 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5680 after returning from a 'fullscreen' configuration.
5681 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5682 to avoid races between the main thread and the input thread.
5683
5684 * w32term.h (struct w32_output): New members normal_width,
5685 normal_height, normal_top, normal_left, and prev_fsmode.
5686 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5687 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5688 members of a frame.
5689
b5b7745f
EZ
5690 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5691 'fullscreen' parameter. Always record previous width and height
5692 of the frame, except when switching out of maximized modes, so
5693 that they could be restored correctly, instead of resetting to the
5694 default frame dimensions. Send SC_RESTORE command to the frame,
5695 unless we are going to send SC_MAXIMIZE, to restore the frame
5696 resize hints in the mouse pointer shown by the window manager.
5697 (Bug#14032)
5698
5699 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5700
5701 * lisp.h (get_frame_param): Adjust conditions for prototype
5702 declaration.
5703
a3454eed
KB
57042013-03-22 Ken Brown <kbrown@cornell.edu>
5705
5706 * unexcw.c: Drop unneeded inclusion of w32common.h.
5707 (report_sheap_usage): Declare.
5708 (read_exe_header): Add magic numbers for x86_64.
5709 (fixup_executable): Fix printf format specifier for unsigned long
5710 argument.
5711
5a49b79c
DA
57122013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5713
5714 * frame.h (struct frame): Put menu_bar_window under #ifdef
5715 because this member is not needed when X toolkit is in use.
5716 (fset_menu_bar_window):
5717 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5718 (free_glyphs, update_frame):
5719 * xdisp.c (expose_frame): Likewise.
5720 (display_menu_bar): Likewise. Remove redundant eassert.
5721 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5722 toolkit is in use.
5723
d6723bf7
PE
57242013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5725
7b1123d8
PE
5726 Use functions and constants to manipulate Lisp_Save_Value objects.
5727 This replaces code that used macros and strings and token-pasting.
5728 The change makes the C source a bit easier to follow,
5729 and shrinks the Emacs executable a bit.
5730 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5731 (make_save_value): Change 1st arg from string to enum. All callers
5732 changed.
5733 (INTX): Remove.
5734 (mark_object): Use if, not #if, for GC_MARK_STACK.
5735 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5736 (XSAVE_OBJECT): Now functions, not macros.
5737 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5738 the constant was never used.
5739 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5740 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5741 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5742 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5743 New constants.
5744 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5745 type3 with a single member save_type. All uses changed.
5746 (save_type, set_save_pointer, set_save_integer): New functions.
5747 * print.c (PRINTX): Remove.
5748
d6723bf7
PE
5749 * alloc.c: Remove redundant static declarations.
5750
5f24fa51
DA
57512013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5752
5753 * window.h (struct window): Convert left_col, top_line, total_lines
5754 and total_cols from Lisp_Objects to integers. Adjust comments.
5755 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5756 Remove.
5757 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5758 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5759 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5760 Adjust users where appropriate.
5761
42143acd
DA
57622013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5763
5764 * frame.h (struct frame): Drop resx and resy because the same data is
5765 available from window system-specific output context. Adjust users.
562c6ee9
SM
5766 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5767 New functions to provide defaults when no window system available.
42143acd 5768 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5769 (NUMVAL): Move from xdisp.c.
42143acd
DA
5770 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5771 (Ffont_face_attributes, Fopen_font):
5772 * image.c (gs_load):
5773 * w32font.c (fill_in_logfont):
5774 * xdisp.c (calc_pixel_width_or_height):
5775 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5776 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5777
c0a17406
KH
57782013-03-20 Kenichi Handa <handa@gnu.org>
5779
5780 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5781 to 1 (temporary workaround until a bug related to ASCII
5782 optimization is fixed).
5783
095d384d
DA
57842013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5785
5786 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5787 Signal error if window is not internal. Adjust docstring.
5788 (delete_all_child_windows): Use combination_limit to save the buffer.
5789 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5790 * print.c (syms_of_print): Initialize debugging output not here...
5791 (init_print_once): ...but in a new function here.
5792 * lisp.h (init_print_once): Add prototype.
5793 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5794
748fa866
DA
57952013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5796
5797 * window.c (window_resize_check, window_resize_apply)
5798 (window_from_coordinates, recombine_windows, set_window_buffer)
5799 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5800 (Fsplit_window_internal, Fdelete_window_internal)
5801 (freeze_window_starts): Use bool for booleans.
5802 * window.h (window_frame_coordinates, resize_frame_windows)
5803 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5804
81519fd2
SM
58052013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5806
5807 * dispnew.c (bitch_at_user): Use `user-error'.
5808
6db423a9
KB
58092013-03-17 Ken Brown <kbrown@cornell.edu>
5810
5811 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5812 as return type of image_background. (Bug#13981)
5813 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5814
8f2906f5
JD
58152013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5816
960ce480 5817 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5818 (ns_select): Don't return with result uninitialized.
960ce480 5819
8f2906f5
JD
5820 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5821 and getDirectory.
5822
81519fd2
SM
5823 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5824 New functions.
8f2906f5
JD
5825 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5826 directories. If filename is nil, get directory name (Bug#13932).
5827 Use getFilename and getDirectory.
5828 (getFilename, getDirectory): New methods for EmacsSavePanel and
5829 EmacsOpenPanel.
5830 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5831
cded56c1
PE
58322013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5833
5834 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5835
251e9147 58362013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5837
5838 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5839 (adjust_after_replace): Make it back to static. Delete the third
5840 arg text_at_gap_tail. Cancel the code for handling it.
5841
5842 * coding.h (struct coding_system): New member eol_seen.
5843
5844 * coding.c (detect_ascii): New function.
5845 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5846 when the source bytes are actually scanned. On detecting for
5847 coding_category_utf_8_auto, call detect_ascii instead of scanning
5848 source bytes directly.
5849 (produce_chars): Call insert_from_gap with the new arg 0.
5850 (encode_coding): Likewise.
5851 (decode_coding_gap): Control ASCII optimization by the variable
5852 disable_ascii_optimization instead of #ifndef .. #endif.
5853 Deccode EOL format according to coding->eol_seen.
5854 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5855 variable.
5856
8a44e6d1
KH
5857 * lisp.h (adjust_after_replace): Cancel externing it.
5858 (insert_from_gap): Adjust prototype.
5859
5f795e34
EZ
58602013-03-15 Eli Zaretskii <eliz@gnu.org>
5861
5862 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5863 FULLSCREEN_MAXIMIZED. (Bug#13935)
5864
f258b4be
DA
58652013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5866
5867 * region-cache.c (find_cache_boundary, move_cache_gap)
5868 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5869 Simplify debugging check and convert to eassert. Adjust comment.
5870 (pp_cache): Put under ENABLE_CHECKING.
5871
a5cc4dde
EZ
58722013-03-14 Eli Zaretskii <eliz@gnu.org>
5873
5874 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5875 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5876 and WM_ACTIVATEAPP.
5877 (w32fullscreen_hook): If the frame is visible, reset
5878 f->want_fullscreen flag after changing the frame size. If the
5879 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5880 (Bug#13953)
5881
3fc5e44a
DC
58822013-03-13 Daniel Colascione <dancol@dancol.org>
5883
5884 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5885 too so that these builds can use Cygwin's file conversion
5886 functions. (We've been building and linking cygw32.o all along
5887 and just not using it.)
5888
47d7532e
PE
58892013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5890
5891 File synchronization fixes (Bug#13944).
5892 * Makefile.in (LIB_FDATASYNC): New macro.
5893 (LIBES): Use it.
5894 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5895 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5896 Don't worry about HAVE_FSYNC, since a substitute fsync is
5897 available if the system lacks one.
5898 (Fwrite_regin): Retry fsync if interrupted.
5899
c7ffccaf
EZ
59002013-03-13 Eli Zaretskii <eliz@gnu.org>
5901
4e2df81d 5902 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5903 activated, call w32fullscreen_hook, to make sure the new frame
5904 dimensions are in effect. (Bug#13937)
5905
8a7debc1
DA
59062013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5907
5908 * xdisp.c (init_iterator): Simplify because both character and byte
5909 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5910 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5911 character and byte positions can be obtained from marker.
8a7debc1 5912
7fd8c501
PE
59132013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5914
d9df6f40
PE
5915 Static checking by Sun C 5.12.
5916 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5917 * bytecode.c (exec_byte_code):
5918 * dispnew.c (init_display):
5919 * eval.c (error):
5920 * fileio.c (Fsubstitute_in_file_name):
5921 * keyboard.c (Fevent_convert_list):
5922 * keymap.c (Fsingle_key_description):
5923 * term.c (maybe_fatal, fatal):
5924 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5925 * xsmfns.c (Fhandle_save_session):
5926 Omit unreachable code.
5927 * keymap.c (map_keymap_char_table_item): Cast void * to
5928 a function pointer type; the C Standard requires this.
5929
7fd8c501
PE
5930 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5931 Include <sys/param.h> unconditionally, as that works elsewhere and
5932 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5933 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5934 and FreeBSD now.
5935
a020afb9 5936See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5937
5938;; Local Variables:
5939;; coding: utf-8
aac0c6e3
MR
5940;; End:
5941
ab422c4d 5942 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5943
5944 This file is part of GNU Emacs.
5945
5946 GNU Emacs is free software: you can redistribute it and/or modify
5947 it under the terms of the GNU General Public License as published by
5948 the Free Software Foundation, either version 3 of the License, or
5949 (at your option) any later version.
5950
5951 GNU Emacs is distributed in the hope that it will be useful,
5952 but WITHOUT ANY WARRANTY; without even the implied warranty of
5953 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5954 GNU General Public License for more details.
5955
5956 You should have received a copy of the GNU General Public License
5957 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.