Improve previous interpreter-mode-alist change
[bpt/emacs.git] / src / ChangeLog
CommitLineData
533f258f
SM
12013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
4
8c27f5ff
SM
52013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
6
7 * eval.c (Feval): Document the new use of `lexical'.
8
0750a308
DA
92013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
10
11 Review and drop old frame resize hack.
12 * frame.h (struct frame): Remove force_flush_display_p.
13 * dispnew.c (update_frame): Adjust user and don't call
14 flush_frame here. The comment has said that there was an issues
15 with redisplaying fringes, but I don't see any differences with
16 and without this hack. Hopefully we can continue without it.
17 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
18 current frame matrices twice if resized_p is set.
19
83fc0554
DA
202013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
21
22 Do not populate pure Xism x_sync to other ports.
23 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
24 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
25 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
26 * w32term.h (x_sync): Remove prototype.
27
fd462129
DA
282013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Cleanup frame flushing.
8c27f5ff
SM
31 * dispextern.h (struct redisplay_interface):
32 Drop flush_display_optional because flush_display is enough
fd462129
DA
33 for X and flushing via RIF is just a no-op for others.
34 * frame.h (flush_frame): New function.
35 * dispnew.c (update_frame):
36 * minibuf.c (read_minibuf):
37 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
38 Use it.
39 * keyboard.c (detect_input_pending_run_timers): Do not flush
40 all frames but selected one in redisplay_preserve_echo_area.
41 * nsterm.m (ns_flush): Remove no-op.
42 (ns_redisplay_interface): Adjust user.
43 * w32term.h (x_flush): Remove no-op.
44 (w32_redisplay_interface): Adjust user.
45 * xterm.c (x_flush): Simplify because we do not flush all
46 frames at once any more. Adjust comment.
47 (x_redisplay_interface): Adjust user.
48
4b73fc73
PE
492013-09-07 Paul Eggert <eggert@cs.ucla.edu>
50
51 Port --without-x --enable-gcc-warnings to Fedora 19.
52 * gfilenotify.c (globals_of_gfilenotify):
53 Call g_type_init only if using an older glib version that needs it.
54
77394d40
DA
552013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
56
57 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
58 (last_glyphless_glyph_merged_face_id): Remove declarations.
59 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
60 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
61 (last_glyphless_glyph_merged_face_id): Now static.
62 (merge_escape_glyph_face): New function, refactored from...
63 (get_next_display_element): ...here.
64 (merge_glyphless_glyph_face): New function, refactored from...
65 (produce_glyphless_glyph): ...here...
66 * term.c (produce_glyphless_glyph): ...and here.
67
306d67bd
SM
682013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
69
70 * eval.c (eval_sub): Only call Ffunction if necessary.
71
7f6c6450
DA
722013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
73
74 Attempt to make redisplay more selective when changing cursor type.
75 * frame.h (struct frame): New bitfield cursor_type_changed.
76 * xdisp.c (cursor_type_changed): Remove.
77 (try_cursor_movement, redisplay_window, try_window_id)
78 (set_frame_cursor_types, try_window_reusing_current_matrix):
79 Adjust to use per-frame bitfield.
80 (redisplay_internal): Look for cursor type change on each visible
81 frame and consider all frames if cursor type has been changed on
82 the frame other than selected. If cursor type has been changed on
83 selected frame only, do not use fast update.
84
bd0443bb
DA
852013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Attempt to make redisplay more selective when changing fonts.
88 * frame.h (struct frame): New bitfield fonts_changed.
89 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
90 (adjust_frame_glyphs): Add prototype.
91 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 92 (adjust_glyphs): Remove because we do not
bd0443bb
DA
93 adjust matrices on all frames at once any more.
94 (adjust_frame_glyphs): Block and unblock input here.
95 (adjust_glyph_matrix): Use fonts_changed.
96 (change_frame_size_1): Use adjust_frame_glyphs.
97 * font.c (font_open_entity): Use fonts_changed.
98 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
99 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
100 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
101 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
102 (shrink_mini_window, Fresize_mini_window_internal)
103 (window_scroll_pixel_based, Fset_window_configuration)
104 (apply_window_adjustment, Fset_window_vscroll):
105 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
106 Use adjust_frame_glyphs.
107 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
108 (try_window_reusing_current_matrix, try_window_id, display_line)
109 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
110 (redisplay_internal): Consider fonts_changed and adjust frame
111 matrices for each frame only if the frame is visible. If font
112 has been changed on some frame during full redisplay, retry
113 only visible frames where the font has been actually changed.
114
b9695828
DA
1152013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
116
117 Cache current header and mode line height for each window.
118 * window.h (struct window): New fields mode_line_height
119 and header_line_height.
120 * window.c (make_window): Initialize them.
121 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
122 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
123 (current_mode_line_height, current_header_line_height):
124 Remove declaration.
125 * xdisp.c (current_mode_line_height, current_header_line_height):
126 Remove.
127 (pos_visible_p, init_xdisp): Adjust user.
128 (redisplay_window): Invalidate mode_line_height and
129 header_line_height if current and desired matrices do not agree.
130
66738305
DA
1312013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
132
133 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
134 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
135
257b3b03
DA
1362013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
137
138 Make --without-x compatible with --enable-gcc-warnings.
139 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
140 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
141 members under HAVE_WINDOW_SYSTEM.
142 * keyboard.c (make_lispy_focus_out): Likewise.
143 (record_menu_key): Move under HAVE_MENUS.
144 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
145 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
146 (syms_of_xdisp): Adjust user.
147 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
148 (start_hourglass, cancel_hourglass):
149 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
150 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
151 and CLEAR_FONT_TABLE_NFONTS.
152 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
153 Declare only if HAVE_WINDOW_SYSTEM.
154 (lface_same_font_attributes_p, clear_face_gcs): Define only
155 if HAVE_WINDOW_SYSTEM.
156
98b7f4bd
DA
1572013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
158
159 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
160 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
161 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
162
a7e43722
SM
1632013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
164
165 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
166
0c90b9ee
PE
1672013-09-04 Paul Eggert <eggert@cs.ucla.edu>
168
169 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
170 This fixes a type error on hosts where ptrdiff_t is wider than int.
171
d99760fa
SM
1722013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
173
6629638e
SM
174 * keyboard.c (read_key_sequence_vs): New function.
175 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
176 common code.
177
d99760fa
SM
178 * callint.c (Fcall_interactively): Always return a vector for 'K'.
179
224e313d
PE
1802013-09-04 Paul Eggert <eggert@cs.ucla.edu>
181
182 Makefile improvements.
183 * Makefile.in (config.status): Don't use double-colon rules, as
184 they are not portable according to POSIX. Fix shell typo with `;
185 I guess this rule has never been tested?
186 (VCSWITNESS): New macro, to override any environment var.
187
6d6ed1af
DA
1882013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
189
190 * xterm.h (struct x_display_info): Do not track X connection
191 fd separately because it is always available from Display.
192 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
193 Adjust users.
194
bc923770
DA
1952013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
196
197 * buffer.c (drop_overlay):
198 * fileio.c (restore_point_unwind): Prefer unchain_marker to
199 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
200
b1cf96de
DA
2012013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
202
203 * buffer.c (Fmake_overlay, Fmove_overlay):
204 * intervals.c (set_point_from_marker):
205 * print.c (PRINTPREPARE): Prefer signal_error
206 to plain error and report unsuitable marker too.
207
d1fc6c21
DA
2082013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
209
210 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
211 for 'dragging' member.
d1ae6a0b
DA
212 (struct x_output): Remove set-but-unused leftovers
213 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
214 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
215 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
216 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
217 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
218 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
219 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 220 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 221 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 222
0ce9f6de
JD
2232013-09-03 Jan Djärv <jan.h.d@swipnet.se>
224
225 * nsfont.m (INVALID_GLYPH): New define.
226 (nsfont_encode_char): Use INVALID_GLYPH.
227 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
228
b594a96c
DA
2292013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
230
231 * xterm.c (x_last_mouse_movement_time): Revert last change.
232 This code should use XDisplayMotionBufferSize to check display's
233 motion history first, and there are few other issues as well.
234 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
235 (handle_one_xevent): Adjust user.
236
8b098236
MR
2372013-09-02 Martin Rudalics <rudalics@gmx.at>
238
9718b207
MR
239 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
240 * frame.c (Flast_nonminibuf_frame): ... to here.
241 (check_minibuf_window): Don't abort if no window was found
242 (Bug#15247).
8b098236 243
84e70bba
DA
2442013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Use XGetMotionEvents to ask the last mouse motion time from X server.
247 * xterm.c (X_MOTION_HISTORY): Default to 1.
248 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
249 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
250 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
251 Ifdef away legacy code.
252 (XTmouse_position, x_scroll_bar_report_motion):
253 Use x_last_mouse_movement_time.
fc85e20b
DA
254 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
255 UnmapNotify event.
84e70bba 256
1fccc530
DA
2572013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
258
259 * msdos.c (last_mouse_window): Move to...
260 (dos_rawgetc): ...this function and adjust comment.
261 * nsterm.m (last_window): Rename to last_mouse_window, move to...
262 (mouseMoved): ...this function and adjust comment.
263 * w32term.c (last_window): Likewise with...
264 (w32_read_socket): ...this function.
265 * xterm.c (last_window): Likewise with...
266 (handle_one_xevent): ...this function.
267
0ab10992
DA
2682013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
269
b7da754d 270 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
271 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
272 (handle_one_xevent): ...to here.
273 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
274 otherwise.
275
0c7f856e
DA
2762013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
277
278 * msdos.c (IT_set_terminal_window): Remove no-op.
279 (initialize_msdos_display): Adjust terminal setup.
280 * w32console.c (w32con_set_terminal_window): Remove no-op.
281 (initialize_w32_display): Adjust terminal setup.
282 * w32term.c (w32_set_terminal_window): Remove no-op.
283 (w32_create_terminal): Adjust terminal setup.
284 * xterm.c (XTset_terminal_window): Remove no-op.
285 (x_create_terminal): Adjust terminal setup.
286
a892a94c
DA
2872013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
288
289 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
290 Remove no-ops.
291 (ns_create_terminal): Adjust terminal setup.
292 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
293 Remove no-ops.
294 (w32_create_terminal): Adjust terminal setup.
295 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
296 Remove no-ops.
297 (x_create_terminal): Adjust terminal setup.
298
cf91889a
DA
2992013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
300
301 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
302 (CLIP_TEXT_POS_FROM_MARKER): New macro.
303 * dispnew.c (buffer_posn_from_coords):
304 * window.c (Fwindow_end, displayed_window_lines):
305 * xdisp.c (redisplay_mode_lines): Use it.
306
5b0891df
JD
3072013-09-01 Jan Djärv <jan.h.d@swipnet.se>
308
309 * fontset.c (face_for_char): Check char in the current face font first
310 if HAVE_NS (Bug#15138).
311
0a357e98
MR
3122013-08-31 Martin Rudalics <rudalics@gmx.at>
313
314 * window.c (temp_output_buffer_show): Make sure window returned
315 by display_buffer is live (Bug#15213).
316
9d7693d7
DA
3172013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
318
319 Minor cleanup to avoid forward declarations.
320 * coding.h (struct ccl_spec): Remove forward declaration.
321 * composite.h (toplevel): Include font.h.
322 (struct composition_it, struct face, struct font_metrics):
323 Remove forward declaration.
324 * dispextern.h (struct image, struct atimer): Likewise.
325 * emacsgtkfixed.h (struct frame): Likewise.
326 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
327 * font.h (struct font_driver, struct font, struct glyph_string)
328 (struct face): Remove forward declaration.
329 * fontset.h (struct face, struct font): Likewise.
330 * frame.h (toplevel): Style cleanup.
331 (enum output_method): Move to...
332 * termhooks.h (enum output_method): ...here.
333 (struct glyph, struct frame, struct ns_display_info)
334 (struct x_display_info, struct w32_display_info):
335 Remove forward declaration.
336 * xterm.h (toplevel): Include termhooks.h.
337 (struct font, struct window, struct glyph_matrix, struct frame)
338 (struct input_event, struct face, struct image): Remove forward
339 declaration.
340 * gtkutil.h (struct _widget_value): Likewise.
341 * keyboard.h (toplevel): Include termhooks.h.
342 (struct input_event): Remove forward declaration.
343
032f7451
DA
3442013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
345
346 * intervals.c (set_point_from_marker): New function.
347 * editfns.c (Fgoto_char):
348 * process.c (Finternal_default_process_filter):
349 * window.c (select_window_1): Use it.
350 * buffer.h (set_point_from_marker): Add prototype.
351
3f940c5a
EZ
3522013-08-29 Eli Zaretskii <eliz@gnu.org>
353
354 * w32.c (term_winsock): Call release_listen_threads before calling
355 WSACleanup.
356 (_sys_wait_accept): Wait for accept event in a loop with a finite
357 timeout, instead of waiting indefinitely. Will hopefully avoid
358 hanging during exit because WSACleanup deadlocks waiting for the
359 event object to be released. (Bug#14333)
360
361 * w32proc.c (release_listen_threads): New function, signals all
362 the reader threads that listen for connections to stop waiting.
363
364 * w32.h (release_listen_threads): Add prototype.
365
101ed2bb
DA
3662013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
367
368 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
369 field of new marker (for sanity and safety).
20de2834
DA
370 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
371 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 372
1f5cf200
DA
3732013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
374
375 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
376 (x_after_update_window_line, x_scroll_bar_create):
377 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
378 (handle_one_xevent, x_clear_frame_area):
379 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
380 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
381 * xterm.h (x_clear_area): Adjust prototype.
382
d2b36813
DA
3832013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
384
385 Hook scanning and indentation functions to find_newline. This helps
386 to avoid duplicated code and renders more respect to newline cache.
387 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
388 * cmds.c (Fforward_line):
389 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
390 Use find_newline and avoid unnecessary point movements.
391 * search.c (scan_newline): Implement on top of find_newline.
392
3ec7babc
SM
3932013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
394
395 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
396 scoped code (bug#11258).
397
5ab473cd
JD
3982013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
399
400 * nsterm.m (last_window): New variable.
401 (EV_TRAILER2): New macro.
402 (EV_TRAILER): Call EV_TRAILER2.
403 (mouseMoved:): Add support for mouse-autoselect-window
404 on nextstep (Bug#6888).
405
78779650
AS
4062013-08-28 Andreas Schwab <schwab@suse.de>
407
408 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
409 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
410 Remove unused macro definitions.
411 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
412 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
413 Only define if emacs.
78779650 414
c3c4768d
DA
4152013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
416
417 Prefer enum glyph_row_area to int where appropriate.
418 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
419 Fix comment.
420 (window_box, window_box_width, window_box_left, window_box_left_offset)
421 (window_box_right, window_box_right_offset): Adjust prototypes.
422 * xdisp.c (window_box, window_box_width, window_box_left)
423 (window_box_left_offset, window_box_right, window_box_right_offset):
424 Use enum glyph_row_area. Adjust users and tweak comment where needed.
425 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
426 * nsterm.m (ns_clip_to_row):
427 * w32term.c (w32_clip_to_row):
428 * xterm.c (x_clip_to_row): Likewise.
429
6bdcbfe1
DA
4302013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
431
432 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
433 (Fprevious_overlay_change): Fast path for buffer with no overlays.
434
50b13cde
PE
4352013-08-28 Paul Eggert <eggert@cs.ucla.edu>
436
437 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
438 for portability to hosts where /bin/sh has problems.
439
f60e429a
DA
4402013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
441
442 Redesign redisplay interface to drop global output_cursor.
443 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
444 (toplevel): Remove declaration of output_cursor.
445 (set_output_cursor, x_cursor_to): Remove prototype.
446 * window.h (struct window): New member output_cursor.
447 (output_cursor_to): New function to replace RIF member.
448 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
449 (update_text_area, set_window_cursor_after_update): Use it.
450 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
451 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
452 * nsterm.m (ns_update_window_begin, ns_update_window_end):
453 * w32term.c (x_update_window_begin, x_update_window_end):
454 * xterm.c (x_update_window_begin, x_update_window_end):
455 Adjust to use per-window output cursor.
456
43aac990
PE
4572013-08-27 Paul Eggert <eggert@cs.ucla.edu>
458
d486344e
PE
459 Simplify SELECT_TYPE-related code.
460 Like EMACS_TIME, this portability layer is no longer needed, since
461 Emacs has been using fd_set as a portability layer for some time.
462 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
463 (SELECT_TYPE): Remove. All uses changed to fd_set.
464 (fd_set) [!FD_SET]: New typedef.
465
43aac990
PE
466 Simplify EMACS_TIME-related code.
467 This portability layer is no longer needed, since Emacs has been
468 using struct timespec as a portability layer for some time.
469 * atimer.h, buffer.h, dispextern.h, xgselect.h:
470 Include <time.h> rather than "systime.h"; that's all that's needed now.
471 * dispnew.c: Include <timespec.h> rather than "systime.h";
472 that's all that's needed now.
473 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
474 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
475 TIMESPEC_RESOLUTION.
476 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
477 LOG10_TIMESPEC_RESOLUTION.
478 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
479 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
480 (make_emacs_time): Remove. All used changed to make_timespec.
481 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
482 (current_timespec): Rename from current_emacs_time. All uses changed.
483 (add_emacs_time): Remove. All uses changed to timespec_add.
484 (sub_emacs_time): Remove. All uses change dot timespec_sub.
485 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
486 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
487 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
488 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
489 (current_timespec): Rename from current_emacs_time. All uses changed.
490 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
491 changed to timespec_cmp.
492 * xgselect.c: Include <timespec.h>, since our .h files don't.
493
d350e350
DA
4942013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
495
496 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
497 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
498 Remove the leftovers.
499 * gtkutil.c (toplevel): Do not declare Qxft but include
500 font.h to do so.
501 * image.c (toplevel): Do not declare Vlibrary_cache because
502 it's already done in lisp.h.
503
9fed9729
DA
5042013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
505
506 * lisp.h (Mouse_HLInfo): Move from here...
507 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
508 (reset_mouse_highlight): New function.
509 * msdos.c (dos_set_window_size, IT_update_begin)
510 (internal_terminal_init):
511 * nsterm.m (ns_update_window_end, x_free_frame_resources)
512 (ns_initialize_display_info):
513 * w32console.c (initialize_w32_display):
514 * w32term.c (x_update_window_end, x_free_frame_resources)
515 (w32_initialize_display_info):
516 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
517 * window.c (Fdelete_other_windows_internal):
518 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
519 * termchar.h (toplevel):
520 * xterm.h (toplevel): Include dispextern.h.
521
f462f075
PE
5222013-08-26 Paul Eggert <eggert@cs.ucla.edu>
523
524 Fix minor problems found by static checking.
525 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
526 (expect): Avoid nested-if warning.
527 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
528 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
529 * nsterm.h, nsterm.m (ns_select):
530 * xgselect.c, xgselect.h (xg_select):
531 Adjust signature to better match pselect's.
532 * nsterm.m (ns_select):
533 Don't set *TIMEOUT, since pselect doesn't.
534 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
535 diagnostic about assigning const char * to it.
536 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
537
068f9124
SM
5382013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
539
540 * lread.c (substitute_object_recurse): Handle hash-tables as well
541 (bug#15190).
542
f5adc984
PE
5432013-08-26 Paul Eggert <eggert@cs.ucla.edu>
544
1fc8eb33
PE
545 Fix unlikely core dump in init_tty, and simplify terminfo case.
546 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
547 The old version incorrectly dumped core if malloc returned a
548 buffer containing only non-NUL bytes.
549 (init_tty): Do not allocate or free termcap buffers; the
550 struct does that for us now.
551 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
552 (struct tty_display_info): Define members termcap_term_buffer and
553 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
554 use them. Allocate them directly in struct rather than indirectly
555 via a pointer, to simplify init_tty.
556
f5adc984
PE
557 * frame.c (check_minibuf_window): Initialize 'window' properly,
558 so that Emacs reliably aborts later if 'window' is not initialized.
559
efec3894
JD
5602013-08-26 Jan Djärv <jan.h.d@swipnet.se>
561
562 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
563 of VoidSymbol (Bug#15154).
564
e1d0341e
DA
5652013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
566
567 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
568 mouse_face_beg_y and mouse_face_end_y.
569 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
570 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
571 Adjust users and update comment where appropriate.
572
bfff6445
MR
5732013-08-26 Martin Rudalics <rudalics@gmx.at>
574
575 * frame.c (check_minibuf_window): New function.
068f9124
SM
576 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
577 Call check_minibuf_window (Bug#15183).
bfff6445 578
c80016b3
DA
5792013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
580
581 * window.h (struct window): Replace last_cursor with last_cursor_vpos
582 because this is the only last cursor data we need to keep and consult.
583 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
584 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
585 Adjust users.
586
de396731
DA
5872013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
588
068f9124
SM
589 Fix recovering from possible decompression error.
590 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 591 the position where the partially decompressed data ends, and
447218dd 592 should count how many bytes was produced so far.
de396731
DA
593 * decompress.c (struct decompress_unwind_data): Add nbytes member.
594 (unwind_decompress): Really delete partially uncompressed data.
595 (Fzlib_decompress_region): Take decompressed data size into account.
596
c76826d9
DA
5972013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
598
599 * syntax.c (init_syntax_once): Adjust comment and do an early
600 initialization of Qchar_table_extra_slots just once...
601 * casetab.c (init_casetab_once):
602 * category.c (init_category_once):
603 * character.c (syms_of_character):
604 * coding.c (syms_of_coding):
605 * xdisp.c (syms_of_xdisp): ...and omit it here.
606
b34454d0
EZ
6072013-08-24 Eli Zaretskii <eliz@gnu.org>
608
11f20add
EZ
609 * xdisp.c (get_next_display_element): Don't apply to characters
610 from a display vector the logic of setting it->end_of_box_run_p
611 suitable for characters from a buffer. (Bug#15175)
612
b34454d0
EZ
613 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
614 to handle directories, rather than '_utime' which doesn't.
615 (Bug#15176)
616
6e1b469e
JD
6172013-08-24 Jan Djärv <jan.h.d@swipnet.se>
618
619 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
620 or fullscreen (Bug#14627).
621
9c05bccf
PE
6222013-08-24 Paul Eggert <eggert@cs.ucla.edu>
623
624 System-dependent integer overflow fixes.
625 * process.c (Fset_process_window_size): Signal an error if
626 the window size is outside the range supported by the lower level.
627 * sysdep.c (set_window_size): Return negative on error,
628 nonnegative on success, rather than -1, 0, 1 on not in system,
629 failure, success. This is simpler. Caller changed.
630 (serial_configure): Remove unnecessary initialization of local.
631 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
632 size fits in unsigned long; this isn't true on some 32-bit hosts.
633 Avoid buffer overrun if some future version of /proc/meminfo has a
634 variable name longer than 20 bytes.
635 (system_process_attributes) [__FreeBSD__]:
636 Don't assume hw.availpages fits in 'int'.
637
c365c355
PE
6382013-08-23 Paul Eggert <eggert@cs.ucla.edu>
639
640 Don't let very long directory names overrun the stack.
641 Fix some related minor problems involving "//", vfork.
642 * callproc.c (encode_current_directory): New function.
643 (call_process): Don't append "/"; not needed.
644 * fileio.c (file_name_as_directory_slop): New constant.
645 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
646 this can save the caller having to alloca.
647 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
648 Use SAFE_ALLOCA, not alloca.
649 (directory_file_name, Fexpand_file_name): Leave leading "//"
650 alone, since it can be special even on POSIX platforms.
651 * callproc.c (call_process):
652 * process.c (Fformat_network_address):
653 * sysdep.c (sys_subshell):
654 Use encode_current_directory rather than rolling our own.
655 (create_process): No need to encode directory; caller does that now.
656 * process.h (encode_current_directory): New decl.
657 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
658 Rework to avoid 'goto xyzzy;'.
659
6c6014d4
EZ
6602013-08-23 Eli Zaretskii <eliz@gnu.org>
661
662 * xdisp.c (handle_face_prop): If the default face was remapped use
663 the remapped face for strings from prefix properties. (Bug#15155)
664
9997ec56
DA
6652013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
666
667 Minor cleanup for redisplay interface and few related functions.
668 * frame.h (enum text_cursor_kinds): Move from here...
669 * dispextern.h (enum text_cursor_kinds): ...to here.
670 (toplevel): Drop unnecessary declarations.
671 (struct redisplay_interface): Use bool and enum text_cursor_kinds
672 in update_window_end_hook and draw_window_cursor functions.
673 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
674 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
675 * w32term.c (x_update_window_end,w32_draw_window_cursor):
676 * xterm.c (x_update_window_end, x_draw_window_cursor):
677 * xdisp.c (display_and_set_cursor, update_window_cursor)
678 (update_cursor_in_window_tree, x_update_cursor): Use bool and
679 enum text_cursor_kinds where appropriate.
680
7f780da6
DA
6812013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
682
683 Redesign redisplay interface to drop updated_row and updated_area.
684 * dispextern.h (updated_row, updated_area): Remove declaration.
685 (struct redisplay_interface): Pass glyph row and row area parameters
686 to write_glyphs, insert_glyphs and clear_end_of_line functions.
687 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
688 Adjust prototypes.
689 * dispnew.c (updated_row, updated_area): Remove.
690 (redraw_overlapped_rows, update_window_line): Adjust user.
691 (update_marginal_area, update_text_area): Likewise. Pass updated row
692 as a parameter. Prefer enum glyph_row_area to int where appropriate.
693 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
694 Adjust users.
695
26495794
PE
6962013-08-22 Paul Eggert <eggert@cs.ucla.edu>
697
698 * process.c (flush_pending_output): Remove stub.
699 All uses removed.
700
4a88129a
PE
7012013-08-21 Paul Eggert <eggert@cs.ucla.edu>
702
703 * callproc.c: Fix race that killed background processes (Bug#15144).
704 (call_process): New arg TEMPFILE_INDEX. Callers changed.
705 Record deleted process-id in critical section, not afterwards.
706 Don't mistakenly kill process created by a call-process invocation
707 that discards output and does not wait.
708
0c5307b0
DA
7092013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
710
711 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
712 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
713 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
714 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
715 to shut up compiler in mark_object.
716 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
717
0d7c1e66
PE
7182013-08-21 Paul Eggert <eggert@cs.ucla.edu>
719
720 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
721 We can't portably rely on PTY_OPEN doing that, even if
722 it calls posix_openpt with O_CLOEXEC.
723
3f246b65
KH
7242013-08-20 Kenichi Handa <handa@gnu.org>
725
726 * character.c (string_char): Improve commentary.
727
8c2f38aa
PE
7282013-08-20 Paul Eggert <eggert@cs.ucla.edu>
729
730 * image.c (SIGNATURE_DIGESTSIZE): Remove.
731 (struct animation_cache): Make signature a flexible array member.
732 All uses changed. This is a tad slower but may insulate us better
733 from future changes to ImageMagick.
734
bb566cea
PE
7352013-08-19 Paul Eggert <eggert@cs.ucla.edu>
736
737 * image.c: Shrink memory needed for animation cache.
738 (SIGNATURE_DIGESTSIZE): New constant.
739 (struct animation_cache): Make 'signature' a fixed size array of bytes.
740 (imagemagick_create_cache): Copy the signature. This saves
741 several KB of memory that ImageMagick wastes per signature.
742 Don't bother updating the update_time, as the caller does that now.
743 (imagemagick_prune_animation_cache): Don't destroy the signature, as
744 it's a fixed size struct member now.
745 (imagemagick_get_animation_cache): Always destroy the signature,
746 as it's now imagemagick_create_cache's responsibility to copy it.
747 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
748 and use memcmp rather than strcmp.
749 eassert that ImageMagick returns a signature of the specified length.
750
6da26928
LMI
7512013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
752
753 * image.c (imagemagick_get_animation_cache): Don't segfault on
754 each invocation.
453f4022
LMI
755 (imagemagick_get_animation_cache): Revert to previous definition
756 so that it actually works. But keep the memory leak fix.
757 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 758
22490125
PE
7592013-08-19 Paul Eggert <eggert@cs.ucla.edu>
760
d0139df5
PE
761 * image.c: Fix animation cache signature memory leak.
762 Fix some other minor performance problems while we're at it.
763 (imagemagick_create_cache): Clear just the members that
764 need clearing. Don't set update_time, as caller does that now.
765 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
766 Simplify by using pointer-to-pointer instead of a prev pointer.
767 (imagemagick_prune_animation_cache): Use make_emacs_time rather
768 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
769 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
770 it's already a copy. Free the signature probe unless it's cached.
771
22490125
PE
772 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
773 This was introduced by my 2013-08-12 fix for Bug#15035.
774
deb31e75
DA
7752013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
776
777 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
778 (imagemagick_prune_animation_cache): Now static.
779
319a4d03
LMI
7802013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
781
782 * image.c (imagemagick_get_animation_cache): Don't segfault when
783 pruning all entries.
784
f747d82e
KB
7852013-08-18 Ken Brown <kbrown@cornell.edu>
786
787 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
788 static heap if ENABLE_CHECKING is defined.
789 (max_bss_sbrk_ptr): New variable.
790 (bss_sbrk): Use it.
791 (report_sheap_usage): Report maximum static heap usage instead of
792 ending static heap usage.
793
d2c28fab
EZ
7942013-08-17 Eli Zaretskii <eliz@gnu.org>
795
796 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
797 of zlib_initialized according to the results of calling
798 init_zlib_functions.
799
274ff63f
LMI
8002013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
801
802 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 803 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
804 (imagemagick_load_image): Remove the ping_wand code, which only
805 apparently saved time on invalid animated images, and slowed down
806 everything else. Optimise for the common case.
274ff63f 807
2bede2ed
XF
8082013-08-16 Xue Fuqiao <xfq.free@gmail.com>
809
70ff8240
XF
810 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
811
de179a3e
XF
812 * editfns.c (insert_before_markers): Mention overlay in the doc string.
813
2bede2ed
XF
814 * marker.c (set_marker): Remove documentation of undefined behavior.
815
703dbeba
LMI
8162013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
817
818 * image.c (imagemagick_compute_animated_image): Animate correctly
819 when sub-images are smaller than the main image.
1d18b1e6
LMI
820 (imagemagick_compute_animated_image): Setting the iterator row to
821 zero is apparently not allowed.
79670014
LMI
822 (imagemagick_compute_animated_image): Allow images that say they
823 have sub-images that are bigger than the main image, but just crop
824 them.
703dbeba 825
63216c5e
JD
8262013-08-15 Jan Djärv <jan.h.d@swipnet.se>
827
828 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
829
a5b5f73f
LMI
8302013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
831
832 * image.c (imagemagick_compute_animated_image): Respect the GIF
833 disposal methods.
834
0fe73012
KB
8352013-08-15 Ken Brown <kbrown@cornell.edu>
836
837 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
838 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
839 needed.
840
691a357f
PE
8412013-08-15 Paul Eggert <eggert@cs.ucla.edu>
842
843 Fix minor problems found by static checking.
844 * frame.c (delete_frame):
845 * xdisp.c (next_element_from_display_vector):
846 Avoid uninitialized local.
847 * image.c (imagemagick_compute_animated_image): Port to C89.
848 Prefer usual GNU indentation style for loops.
849 Be more careful about bizarrely large sizes, by using ptrdiff_t
850 instead of int.
851
42fe2e88
DA
8522013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
853
854 Fix infinite frame selection loop (Bug#15025).
855 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
856
d39a3da6
EZ
8572013-08-15 Eli Zaretskii <eliz@gnu.org>
858
068f9124
SM
859 * xdisp.c (compute_window_start_on_continuation_line):
860 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
861 to make sure we end up setting the window start at the leftmost
862 visible character of the display line. This avoids funky
863 horizontal shifting because the window start is not kept on the
864 same position. (Bug#15090)
05426239
EZ
865 (next_element_from_display_vector): Support 'box' face attribute
866 in the face definitions of a display vector. (Bug#15099)
d39a3da6 867
6e856b69
LMI
8682013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
869
870 * image.c (imagemagick_compute_animated_image): Implement animated
871 images (bug#14700).
995be755
LMI
872 (imagemagick_compute_animated_image): Fix some compilation
873 warnings. Implement a very simple cache to make the animation
874 usable at all, but it should be replaced with a per-image cache.
6e856b69 875
d5a1acfa
DA
8762013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
877
878 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
879 to do `for' loops over alist values.
880 * buffer.h (FOR_EACH_BUFFER):
881 * process.c (FOR_EACH_PROCESS): Use it.
882 (handle_child_signal, status_notify, Fget_buffer_process)
883 (kill_buffer_processes): Use FOR_EACH_PROCESS.
884
9c253307
DA
8852013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
886
887 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
888 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
889 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
890 to xzalloc and so avoid redundant call to memset.
891 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
892 members because it is allocated with xzalloc and so already zeroed.
893
05e64f9f
KB
8942013-08-14 Ken Brown <kbrown@cornell.edu>
895
896 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
897 (Bug#15094).
898
5b71542d
DA
8992013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
900
901 Utility function and macro to copy Lisp string to C string.
902 * lisp.h (xlispstrdupa): New macro.
903 (xlispstrdup): New prototype.
904 * alloc.c (xlispstrdup): New function.
905 * callint.c (Fcall_interactively):
906 * fileio.c (Ffile_name_directory, Fexpand_file_name)
907 (Fsubstitute_in_file_name):
908 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
909 * image.c (x_create_bitmap_from_file):
910 * w32term.c (w32_term_init):
911 * xterm.c (x_term_init): Use xlispstrdup.
912
71530c97
LMI
9132013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
914
4ce82fb8
LMI
915 * image.c (imagemagick_load_image): Make animated pictures work.
916 There's still some problems with background color settings, though
917 (bug#14700).
918
71530c97
LMI
919 * decompress.c (unwind_decompress): Always restore point.
920
7510a061
XF
9212013-08-14 Xue Fuqiao <xfq.free@gmail.com>
922
923 * marker.c (set_marker): Reformat documentation.
924
01c3051f
PE
9252013-08-14 Paul Eggert <eggert@cs.ucla.edu>
926
aab1fcdf
PE
927 * xdisp.c (cursor_type_changed): Now static.
928
01c3051f
PE
929 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
930 Use changed. This avoids the need to call xmalloc and for the
931 caller to call xfree, and avoids memory leaks in some situations.
932
2084152a
DA
9332013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
934
935 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
936 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
937 (redisplay_window): If window_end_valid is cleared due to non-zero
938 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
939 so do not call to try_cursor_movement for that window.
2084152a 940
02455cb6
DA
9412013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
942
943 * window.h (struct window): Convert window_end_pos and
944 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
945 (wset_window_end_pos, wset_window_end_vpos): Remove.
946 * dispnew.c (adjust_glyph_matrix):
947 * window.c (Fwindow_end, replace_window, set_window_buffer)
948 (make_window):
949 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
950 (set_vertical_scroll_bar, redisplay_window, try_window)
951 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
952 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
953 (note_mouse_highlight): Adjust users.
954 (try_cursor_movement): Likewise. Convert old precondition to eassert.
955 Add comment.
956
da5707e8
DA
9572013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
958
959 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
960 * image.c (imagemagick_filename_hint): Use `const char *' and
961 prefer SSDATA to SDATA to avoid warnings.
962
25554267
DA
9632013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
964
965 Cleanup window fringes, margins and scroll bars adjustments.
966 * window.c (set_window_fringes, set_window_margins)
967 (set_window_scroll_bars, apply_window_adjustment): New functions.
968 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
969 (Fset_window_scroll_bars): Use them.
970
38a2c910
DA
9712013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
972
973 * window.h (struct window): Convert scroll_bar_width
974 from Lisp_Object to integer. Adjust comment.
975 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
976 Adjust users.
977 * window.c (wset_scroll_bar_width): Remove.
978 (make_window): Initialize scroll_bar_width.
979 (Fsplit_window_internal): Use direct assignment.
980 (Fset_window_configuration, save_window_save):
981 Convert Lisp_Object to integer and back where appropriate.
982 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
983 bar was actually changed, and mention this in docstring.
984
2d065031
PE
9852013-08-13 Paul Eggert <eggert@cs.ucla.edu>
986
987 * decompress.c: Minor simplifications.
988 (Fzlib_decompress_region): Don't bother verifying
989 that avail_out <= UINT_MAX, as that was confusing.
990 Mention the restriction in a comment instead.
991 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
992
a5bd5abb
JD
9932013-08-13 Jan Djärv <jan.h.d@swipnet.se>
994
995 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
996 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
997
66e7901a
LMI
9982013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
999
1000 * image.c (imagemagick_filename_hint): Check for errors in the
1001 alist structure.
1002
2fa611b7
EZ
10032013-08-13 Eli Zaretskii <eliz@gnu.org>
1004
1005 * window.c (Fwindow_margins): Return nil when there's no marginal
1006 area, as per the documented API.
1007
1008 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1009 Fmake_vector, as scroll bar's struct members are not all Lisp
1010 objects now. This avoids crashes in GC.
1011
1012 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1013 bool, so its address could be taken.
1014
8259030d
LMI
10152013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1016
1017 * image.c (imagemagick_filename_hint): New function to possibly
1018 apply `image-content-type-suffixes'.
1019 (imagemagick_load_image): Use it.
1020
866c710e
EZ
10212013-08-13 Eli Zaretskii <eliz@gnu.org>
1022
1023 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1024 if loading zlib failed.
1025
f10490f0
JD
10262013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1027
96311be7
JD
1028 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1029 2013-08-13 checkin below. Change bool to BOOL, rule is:
1030 All Obj-C code uses BOOL, except for interfaces callable from C.
1031
f10490f0
JD
1032 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1033
c8ae93b0
DA
10342013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1037 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1038 bool instead of BOOL.
1039 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1040 from Lisp_Object to bitfield. Adjust comment.
1041 * w32term.c (x_scroll_bar_create): Adjust user.
1042 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1043 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1044 Use bool for boolean.
1045 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1046 to `unsigned int' when defining a bitfield.
1047
53b64418
PE
10482013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1051
eeaf9bf3
DA
10522013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 * window.h (struct window): Convert left_margin_cols and
1055 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1056 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1057 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1058 Adjust users.
1059 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1060 Adjust comment.
1061 (showing_window_margins_p, update_window_line, update_frame_1):
1062 * fringe.c (draw_fringe_bitmap_1):
1063 * xdisp.c (window_box_width): Adjust users.
1064 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1065 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1066 Use direct assignment.
1067 (Fset_window_configuration, save_window_save, Fwindow_margins):
1068 Convert Lisp_Object to integer and back where appropriate.
1069 (Fset_window_margins): Adjust user. Return t if any margin
1070 was actually changed, and mention this in docstring.
1071
956720af
XF
10722013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1073
f73f4ce6 1074 * syntax.c (forward_word):
956720af
XF
1075 * cmds.c (forward_char, backward_char): Mention the optional argument.
1076
9e37ee3b
DA
10772013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1078
1079 * window.h (struct window): Convert left_fringe_width
1080 and right_fringe_width from Lisp_Objects to integers.
1081 Adjust comment.
1082 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1083 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1084 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1085 Remove.
1086 (make_window): Initialize new integer fields to -1.
1087 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1088 (Fset_window_configuration, save_window_save):
1089 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1090 (Fset_window_fringes): Adjust user. Return t if any fringe
1091 was actually changed, and mention this in docstring.
1092
e4375ca7
DA
10932013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1094
1095 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1096 * nsfns.m (x_set_cursor_type):
1097 * w32fns.c (x_set_cursor_type):
1098 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1099 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1100
a45543bc
DA
11012013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 * font.c (clear_font_cache): New function, stripped from...
1104 (Fclear_font_cache): ...here, which now uses the function
1105 above. Adjust comment.
1106 * font.h (clear_font_cache): Add prototype.
1107 * xfaces.c (clear_face_cache): Use clear_font_cache.
1108
ae966a86
DA
11092013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 * window.c (Fset_window_start): Compare `w', not `window' because
1112 `w' might not be equal to `window' after call to decode_live_window.
1113
297a545b
PE
11142013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1117 This fixes a problem introduced by the Bug#15035 patch
1118 when using GPG. Reported by Herbert J. Skuhra.
1119
aa942e2b
EZ
11202013-08-12 Eli Zaretskii <eliz@gnu.org>
1121
1122 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1123 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1124 not yet initialized.
1125
7699d09e
LMI
11262013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1127
1128 * decompress.c (Fzlib_decompress_region): Support zlib
1129 decompression, too, and rename.
1130
1d238bc7
PE
11312013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 Minor zlib configuration tweaks.
1134 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1135 Don't assume presence of fn_inflateInit2_ zlib internal function.
1136
8a44a184
LMI
11372013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1138
1139 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1140 include the zlib prefix.
1141
594a4307
EZ
11422013-08-12 Eli Zaretskii <eliz@gnu.org>
1143
1144 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1145 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1146 define static variables that are pointers to zlib functions to be
1147 dynamically loaded.
1148 (init_zlib_functions) [WINDOWSNT]: New function.
1149 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1150 New macros.
1151 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1152 macros instead of invoking the zlib functions directly.
068f9124
SM
1153 (syms_of_decompress): DEFSYM Qzlib_dll.
1154 Staticpro Szlib_available_p.
594a4307 1155
d2e113bc
DA
11562013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 Avoid looping over all frame windows to freeze and unfreeze.
1159 * window.h (struct window): Drop frozen_window_start_p.
1160 (freeze_window_starts): Drop prototype.
1161 * frame.h (struct frame): New frozen_window_starts flag.
1162 (FRAME_WINDOWS_FROZEN): New macro.
1163 * window.c (freeze_window_start, freeze_window_starts):
1164 Remove.
1165 (select_window, replace_window): Adjust users.
1166 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1167 (window_frozen_p): New function.
1168 (redisplay_window): Use it.
1169
94fcd171
PE
11702013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 Fix some fd issues when running subprocesses (Bug#15035).
1173 Fix bugs that can leak files or file descriptors on errors.
1174 Don't unlink open temp files, as that's hard for users to diagnose
1175 when things go awry (e.g., temp disk exhausted).
1176 Don't bother to lock temp files. Check for invalid recursion.
1177 * callproc.c (synch_process_fd): Remove. All uses removed.
1178 (synch_process_tempfile): New var or macro.
1179 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1180 New constants.
1181 (record_kill_process): New arg, the temp name. All callers changed.
1182 (delete_temp_file): Now just a simple wrapper around unlink.
1183 (call_process_kill): New arg, the call_process_fd array.
1184 Close them all. Clear synch_process_pid. Remove the temp file,
1185 or arrange for it to be removed.
1186 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1187 that's been moved to synch_process_tempfile. Caller changed.
1188 Do not remove the tempfile; that's now call_process_kill's
1189 responsibility.
1190 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1191 call_process_kill; the caller now does that.
1192 (call_process_cleanup): Do not close the process fd; that's now
1193 call_process_kill's responsibility.
1194 (Fcall_process): Implement via new function call_process, which
1195 has most of the old body of Fcall_process, but with a different API.
1196 (call_process): New function that does not open or close filefd if
1197 it is nonnegative. Record which fds need to be closed, and let
1198 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1199 Signal an error if invoked recursively (could be done via a hook).
1200 Simplify creation of the tempfile in the MSDOS case.
1201 Don't create the output file until after checking for the executable.
1202 Report any failure to open /dev/null.
1203 Don't open /dev/null for writing twice; once is enough.
1204 Don't create pipe if all output is being discarded or sent to file.
1205 Don't worry about setting up the coding system or reading from the
1206 pipe if all output is being discarded.
1207 Hoist fd_error local into top level, to lessen block nesting.
1208 Don't record deleted pid here; now done by Fcall_process_region.
1209 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1210 and note its success in synch_process_tempfile.
1211 Do not leak resources when child_setup fails.
1212 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1213 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1214 (create_temp_file): Now returns open fd, with an additional
1215 Lisp_Object * argument to return the name. All callers changed.
1216 Do not close the file; rewind it instead, and leave it open for
1217 the caller. Do not lock the temp file. Unwind-protect the file
1218 and the file-descriptor.
1219 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1220 If an asynchrounous process, record it here, not in call_process.
1221 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1222 * eval.c (set_unwind_protect): New function.
1223 * fileio.c (write_region): New function, generalized from the
1224 old Fwrite_region. Do not lock temp files.
1225 (Fwrite_region): Use it.
1226 * lisp.h (set_unwind_protect, write_region): New decls.
1227 * process.c: Include <verify.h>.
1228 (make_process): Mark fds as initially closed.
1229 (deleted_pid_list): Now a list of pid-filename pairs.
1230 All uses changed.
1231 (close_process_fd): New function.
1232 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1233 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1234 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1235 (create_process, create_pty, Fmake_serial_process)
1236 (server_accept_connection): Record which fds need to be closed,
1237 and let deactivate_process close them.
1238 (Fmake_network_process): Do not discard the unwind-protect
1239 until it's safe to do so.
1240 (deactivate_process): Close the fds opened by create_process etc.
1241 (Fprocess_send_eof): Adjust to new way of recording open fds.
1242 Report an error if /dev/null can't be opened, instead of aborting.
1243 * process.h (PROCESS_OPEN_FDS): New constant.
1244 (struct Lisp_Process): New member open_fds.
1245 (record_kill_process, record_deleted_pid): Adjust signatures.
1246 (record_deleted_pid): Move decl here ...
1247 * syswait.h (record_deleted_pid): ... from here.
1248
d0e615c3
PE
12492013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1250
1251 * decompress.c: Fix bugs with large buffers and weird inputs.
1252 Tune a bit. Reindent as per usual Emacs style.
1253 (BUFFER_SIZE): Remove.
1254 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1255 more than UINT_MAX bytes. Decompress into the gap instead of into
1256 an auto buffer, as this should avoid copying. Return nil if
1257 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1258 set immediate_quit; we shouldn't trust zlib code that much.
1259
313546eb
LMI
12602013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1261
99a32242
LMI
1262 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1263 errors, and really move the gap to where we want it.
1264
313546eb
LMI
1265 * lisp.h: Include decompress.c support.
1266
1267 * emacs.c (main): Include decompress.c support.
1268
1269 * Makefile.in: Include -lz if present.
1270
d2d699ac
JD
12712013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1272
f90e3ebd
JD
1273 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1274 (initWithTitle:): Initialize frame to 0.
1275 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1276 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1277 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1278
1279 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1280 fillWithWidgetValue:frame:
1281
423d3b3f
JD
1282 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1283 remove memory leak warnings.
1284
d2d699ac
JD
1285 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1286 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1287 menu_pending_title.
1288
1289 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1290 (x_activate_menubar): Update the whole menu.
1291 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1292 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1293 current event is not NSSystemDefined (Bug#15001).
1294 Call ns_check_menu_open only if trackingMenu is 2.
1295 (menuDidClose:): New method, decrease trackingMenu.
1296 (fillWithWidgetValue:setDelegate:): New method.
1297 (fillWithWidgetValue:): Call the above.
1298
1299 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1300
7d652d97
PE
13012013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 Omit some unnecessary casts.
1304 Many of these go back to the old pre-C89 days, when they may have
1305 been needed, but we've been assuming C89 or later for a while now.
1306 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1307 (live_float_p, live_misc_p, live_vector_p):
1308 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1309 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1310 (defvar_per_buffer):
1311 * callint.c (Fcall_interactively):
1312 * doc.c (Fsubstitute_command_keys):
1313 * filelock.c (get_boot_time):
1314 * frame.c (xrdb_get_resource):
1315 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1316 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1317 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1318 (menuitem_highlight_callback, menu_destroy_callback)
1319 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1320 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1321 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1322 (xg_tool_bar_help_callback, tb_size_cb):
1323 * image.c (xpm_alloc_color, png_read_from_memory)
1324 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1325 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1326 (syms_of_image):
1327 * keymap.c (describe_map):
1328 * nsfns.m (Fns_display_monitor_attributes_list):
1329 * nsmenu.m (process_dialog:):
1330 * nsterm.m (hold_event):
1331 * process.c (wait_reading_process_output):
1332 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1333 * scroll.c (do_direct_scrolling, scrolling_1):
1334 * termcap.c (tgetent):
1335 * window.c (check_window_containing, add_window_to_list)
1336 (freeze_window_starts):
1337 * xdisp.c (compare_overlay_entries, vmessage):
1338 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1339 (x_get_monitor_attributes_xrandr)
1340 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1341 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1342 * xfont.c (xfont_match, xfont_open):
1343 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1344 (menubar_selection_callback, menu_position_func)
1345 (popup_selection_callback, create_and_show_popup_menu)
1346 (dialog_selection_callback, create_and_show_dialog):
1347 * xrdb.c (x_get_string_resource):
1348 (main) [TESTRM]:
1349 * xsmfns.c (x_session_check_input):
1350 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1351 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1352 (xaw_jump_callback, xaw_scroll_callback):
1353 Omit unnecessary casts.
1354
9acc1074
PE
13552013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 Minor string-length refactoring.
1358 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1359 * frame.c (make_monitor_attribute_list):
1360 Prefer build_string to strlen + make_string.
1361
361c0eb8
JD
13622013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1363
1364 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1365 don't check minor_code (Bug#14417).
1366
14ba0822
EZ
13672013-08-09 Eli Zaretskii <eliz@gnu.org>
1368
1369 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1370 vertical positions instead. This avoids calling MATRIX_ROW with
1371 row numbers that are possibly beyond valid limits. (Bug#15064)
1372
309f24d1
DA
13732013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1374
1375 Use xstrdup and build_unibyte_string where applicable.
1376 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1377 * xfns.c (x_window):
1378 * xrdb.c (x_get_customization_string):
1379 * xterm.c (xim_initialize):
1380 * w32fns.c (w32_window): Use xstrdup.
1381 (w32_display_monitor_attributes_list):
1382 * emacs.c (init_cmdargs):
1383 * keyboard.c (PUSH_C_STR):
1384 * nsfont.m (nsfont_open):
1385 * sysdep.c (system_process_attributes):
1386 * w32.c (system_process_attributes):
1387 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1388
55902276
EZ
13892013-08-09 Eli Zaretskii <eliz@gnu.org>
1390
1391 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1392 variables of these types so that GDB would know about them, as aid
1393 for debugging fatal exceptions. (Bug#15024) See also
1394 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1395 discussions.
1396
10bf7f5a
JD
13972013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1398
1399 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1400 larger than the NSWindow (Bug#14934).
1401
65620264
DA
14022013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1403
1404 Redesign redisplay interface to drop global variable updated_window.
1405 Always pass currently updated window as a parameter to update routines.
1406 * dispextern.h (updated_window): Remove declaration.
1407 (struct redisplay_interface): Pass window parameter to
1408 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1409 and after_update_window_hook.
1410 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1411 Adjust prototypes.
1412 * dispnew.c (updated_window): Remove.
1413 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1414 (update_window_line): Adjust to match redisplay interface changes.
1415 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1416 (ns_scroll_run, ns_after_update_window_line):
1417 * w32term.c (x_update_window_begin, x_update_window_end)
1418 (x_after_update_window_line, x_scroll_run):
1419 * xterm.c (x_update_window_begin, x_update_window_end)
1420 (x_after_update_window_line, x_scroll_run):
1421 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1422 Likewise. Adjust comments where appropriate.
1423 (x_cursor_to): Simplify because this is always called during window
1424 update (but install debugging check anyway).
1425 (expose_window): Check must_be_updated_p flag to see whether this
1426 function is called during window update.
1427
628fdc56
DA
14282013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1429
1430 Do not reset window modification event counters excessively.
1431 These leftovers and poor man's tricky methods to catch extra
1432 redisplay's attention are no longer needed.
1433 * frame.c (set_menu_bar_lines_1):
1434 * minibuf.c (read_minibuf_unwind):
1435 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1436 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1437 (window_scroll_line_based, Fset_window_configuration):
1438 * xdisp.c (redisplay_window): Do not reset last_modified and
1439 last_overlay_modified counters.
1440
8fd9c92e
JD
14412013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1442
1443 * xselect.c (x_send_client_event): Set send_event and serial, memset
1444 data.l as it might be bigger than data.b. Use 24 bit mask to
1445 XSendEvent (Bug#15034).
1446
0ee18172
EZ
14472013-08-07 Eli Zaretskii <eliz@gnu.org>
1448
1449 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1450 for TTY frames that are not the top frame on their console.
1451 (Bug#14616)
1452
16ddd1a6
MR
14532013-08-07 Martin Rudalics <rudalics@gmx.at>
1454
1455 * w32term.c (w32fullscreen_hook): Really maximize frame when
1456 asked for (Bug#14841).
1457
d2a95ffb
DA
14582013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1459
1460 Prefer selected_window to Fselected_window, likewise for frames.
1461 * buffer.c (Fbuffer_swap_text):
1462 * data.c (Fvariable_binding_locus):
1463 * window.c (run_window_configuration_change_hook): Adjust users.
1464 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1465 Use decode_live_frame.
1466
170da1ec
DA
14672013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1468
1469 Be more careful if selected window shows the buffer other than current,
1470 use window_outdated only if this is not so. This change should also
1471 address some weird issues discussed in Bug#13012.
1472 * window.h (window_outdated): New prototype.
1473 * window.c (window_outdated): Now here. Convert from static and
1474 always assume window's buffer.
1475 (Fwindow_end, Fwindow_line_height): Use it.
1476 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1477 and always assume window's buffer.
1478 (redisplay_window): Adjust user.
e5eefe9b 1479 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1480 check whether mode line should be updated only if selected window
1481 shows current buffer.
1482 (run_window_scroll_functions): Use eassert for debugging check.
1483 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1484
56b5d5b1
DA
14852013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1486
1487 * window.c (window_scroll, window_scroll_pixel_based)
1488 (window_scroll_line_based): Use bool for booleans.
1489
2878ba7e
PE
14902013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1491
1492 * process.c: Fix minor off-by-one issues in descriptor counts.
1493 This shouldn't fix any real bugs, but it cleans up the code a bit.
1494 (max_process_desc, max_input_desc): -1, not 0, means none.
1495 All uses changed.
1496 (delete_input_desc): New function.
1497 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1498 (deactivate_process): Scan backwards when recomuting max_process_desc;
1499 that should be faster.
1500 (init_process_emacs): Initialize max_input_desc.
1501
e30b79c1
DA
15022013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1503
1504 Use region cache to speedup bidi_find_paragraph_start.
1505 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1506 Rename cache_long_line_scans to cache_long_scans.
1507 * buffer.c (bset_cache_long_line_scans): Rename to
1508 bset_cache_long_scans.
1509 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1510 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1511 into account.
1512 (syms_of_buffer): Rename cache-long-line-scans to
1513 cache-long-scans. Adjust docstring.
1514 * search.c (newline_cache_on_off):
1515 * indent.c (width_run_cache_on_off): Adjust users.
1516 * bidi.c (bidi_paragraph_cache_on_off): New function.
1517 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1518 * insdel.c (prepare_to_modify_buffer):
1519 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1520
00012b86
DA
15212013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1522
1523 Invalidate region caches only if buffer text is going to be changed.
1524 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1525 (modify_text): ...new prototype.
1526 (prepare_to_modify_buffer_1): New prototype.
1527 * textprop.c (modify_region): Rename to...
1528 (modify_text_properties): ...new function.
1529 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1530 (Fremove_list_of_text_properties): Adjust users.
1531 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1532 (modify_text): ...new function.
1533 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1534 (prepare_to_modify_buffer_1): ...new function.
1535 * casefiddle.c (casify_region):
1536 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1537 (Ftranspose_regions): Use modify_text.
1538
dc6c0eda
SM
15392013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1540
1541 * lisp.mk (lisp): Add nadvice.elc.
1542
8f3a2c26
DA
15432013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1544
1545 New macro to iterate over live buffers similar to frames.
1546 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1547 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1548 Declare buffer-related variables here to offload lisp.h.
1549 * buffer.c (Vbuffer_alist): Adjust comment.
1550 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1551 (other_buffer_safely):
1552 * data.c (store_symval_forwarding):
1553 * dispnew.c (Fframe_or_buffer_changed_p):
1554 * fileio.c (Fdo_auto_save):
1555 * filelock.c (unlock_all_files):
1556 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1557
e0fdb694
PE
15582013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1561 * callproc.c (create_temp_file):
1562 * filelock.c (create_lock_file):
1563 Assume mkostemp, since it's now provided by Gnulib.
1564
63f5c6c2
EZ
15652013-08-04 Eli Zaretskii <eliz@gnu.org>
1566
1567 * w32.c (mkostemp): New function.
1568 (mktemp): Remove, no longer used. Most of the code reused in
1569 mkostemp. (Bug#15015)
484ab239 1570 (mktemp): Don't undef.
63f5c6c2 1571
f0b79313
DA
15722013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1573
1574 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1575 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1576 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1577 (free_glyph_pool, check_glyph_memory): Likewise for
1578 all users. Adjust comments where appropriate.
1579
98f638d6
PE
15802013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 * composite.h: Minor fixups.
1583 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1584 to fix a misspelling, and change it to an inline function while
1585 we're at it (it need not be a macro). All uses changed.
1586 (composition_method, composition_valid_p):
1587 Rewrite to avoid assignments in if-conditions.
1588
75c59fb3
DA
15892013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1590
1591 Do not use global Lisp_Object in composition macros.
1592 * composite.h (composition_temp): Remove declaration.
1593 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1594 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1595 (compose_region): Remove the leftover.
75c59fb3
DA
1596 * composite.c (composition_temp): Remove.
1597 (run_composition_function, update_compositions)
1598 (composition_compute_stop_pos, composition_adjust_point)
1599 (Ffind_composition_internal):
1600 * coding.c (handle_composition_annotation):
1601 * xdisp.c (handle_composition_prop, check_point_in_composition):
1602 Related users changed.
1603
a10c8269
DA
16042013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1605
1606 Drop FRAME_PTR typedef.
1607 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1608 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1609 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1610 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1611 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1612 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1613 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1614 All related users changed.
1615
a104f656
SM
16162013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1617
1618 * eval.c (default_toplevel_binding): New function.
1619 (Fdefvar): Use it.
1620 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1621 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1622 (syms_of_eval): Export them.
1623 * data.c (Fdefault_value): Micro cleanup.
1624 * term.c (init_tty): Use "false".
1625
4b5c9326
DA
16262013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1627
1628 Fix X GC leak in GTK and raw (no toolkit) X ports.
1629 * xterm.c (x_free_frame_resources): If white and black relief
1630 GCs are allocated, always free them here.
1631 * xfns.c (x_make_gc): Omit redundant initialization.
1632 * widget.c (create_frame_gcs): Remove the leftover.
1633 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1634 in x_free_frame_resources.
1635
b19aa636
JD
16362013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1637
1638 * nsterm.m (windowWillResize:toSize:): Only change title if
1639 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1640 modifying it.
1641 (viewDidEndLiveResize): New method.
1642
1643 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1644 inside NS_IMPL_COCOA.
1645
af1f7e06
DA
16462013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1647
1648 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1649 Do not check whether undo is enabled because record_insert and
1650 record_delete does that themselves.
1651
65b02bb9
DA
16522013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1653
1654 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1655 member which is not really used any more.
1656 (FRAME_XIC_BASE_FONTNAME): Remove.
1657 * xfns.c (xic_free_fontset): Adjust user.
1658 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1659 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1660 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1661 (xdialog_show): Use eassert for debugging check.
7ee0f047 1662 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1663
6318cde0
PE
16642013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 * fileio.c, fns.c (merge): Move extern decl from here ...
1667 * lisp.h (merge): ... to here.
1668
6c1a09ba
DA
16692013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1670
1671 Fix last font-related change.
1672 * w32font.h (w32font_list_internal, w32font_match_internal):
1673 Fix prototype.
1674 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1675 (uniscribe_list_family): Adjust to match font API change.
1676 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1677 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1678
f8c20208
DA
16792013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1680
1681 * frame.h (FRAME_MOUSE_UPDATE):
1682 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1683 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1684
fdb396e2
DA
16852013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1686
1687 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1688 * font.h (struct font_driver): Change list, match, and list_family
1689 functions to accept struct frame * as first arg.
068f9124
SM
1690 * font.c (font_score, font_compare, font_sort_entities):
1691 Remove prototypes.
fdb396e2
DA
1692 (font_sort_entities, font_list_entities, font_select_entity):
1693 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1694 match font API change.
1695 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1696 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1697 * ftxfont.c (ftxfont_list, ftxfont_match):
1698 * xftfont.c (xftfont_list, xftfont_match):
1699 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1700 * w32font.c (w32font_list, w32font_match, w32font_list):
1701 (w32font_list_internal, w32_font_match_internal): Likewise.
1702 * xfaces.c (Fx_family_fonts): Adjust user.
1703
52b8a085
DA
17042013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1705
1706 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1707 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1708 only if HAVE_X_WINDOWS is in use.
1709 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1710 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1711 * w32term.c (x_wm_set_icon_position): Likewise.
1712 * w32fns.c (x_icon): Adjust user.
1713
c791c18e
DA
17142013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1715
1716 * xterm.c (last_mouse_press_frame): Remove the
1717 leftover which is not really used any more.
1718 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1719 (x_flush): Call XFlush once per each X display, not frame.
1720 This is better because this code always unconditionally skips
1721 non-X frames in Vframe_list and issues the only XFlush if we
1722 have more than one X frame on the same X display.
2f935d86
DA
1723 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1724 Use bool for booleans.
1725 (x_draw_glyph_string_background, cvt_string_to_pixel):
1726 (cvt_pixel_dtor): Drop unnecessary prototypes.
1727 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1728
f435830e
DA
17292013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1730
1731 Drop unnecessary functions that deals with frame pixel size.
1732 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1733 (x_pixel_height): Drop prototypes.
1734 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1735 (x_pixel_height): Drop implementations.
1736 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1737 which should be always valid for window frame.
1738 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1739 * w32menu.c (Fx_popup_dialog):
1740 * xmenu.c (Fx_popup_dialog): Likewise for both.
1741
84231434
DA
17422013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1743
1744 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1745 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1746 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1747 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1748 and mention nil frame in docstring.
84231434 1749
959067a1
DA
17502013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1751
1752 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1753 (x_figure_window_size): Likewise. Adjust to return long.
1754 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1755 (toplevel): Move Qterminal_live_p to...
1756 * terminal.c (toplevel): ...here, make it static, and...
1757 (syms_of_terminal): ...DEFSYM here.
1758 * frame.h (Qterminal_live_p): Remove declaration.
1759 (make_frame, x_figure_window_size): Adjust prototype.
1760 * nsfns.m (Fx_create_frame): Use long for window flags.
1761
f4b169ce
PE
17622013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1763
1764 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1765 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1766 Do not assume that emacs_close (INT_MAX) is a no-op.
1767
bee6a2c7
DA
17682013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1769
1770 * xfaces.c (make_face_cache): For struct face_cache, prefer
1771 xmalloc to xzalloc and so avoid redundant call to memset.
1772 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1773
d7e6881a
DA
17742013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 * fringe.c (draw_window_fringes, update_window_fringes)
1777 (compute_fringe_widths):
1778 * w32term.c (x_draw_glyph_string):
1779 * window.c (candidate_window_p, Frecenter):
1780 * xfaces.c (realize_basic_faces, realize_default_face)
1781 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1782 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1783 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1784 * xmenu.c (Fx_menu_bar_open_internal):
1785 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1786 * xsettings.c (xft_settings_event):
1787 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1788 Use bool for booleans. Adjust style and comments where
1789 appropriate.
1790 * dispextern.h (draw_window_fringes, update_window_fringes)
1791 (compute_fringe_widths):
1792 * xterm.h (x_had_errors_p): Adjust prototype.
1793
ec3058af
DA
17942013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1795
1796 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1797 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1798
218e0637
DA
17992013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1800
1801 * fns.c (toplevel): Remove comment before Fsafe_length because
1802 it checks for QUIT.
1803
e560aba9
PE
18042013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1807
2e5ce5de
EZ
18082013-07-28 Eli Zaretskii <eliz@gnu.org>
1809
1810 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1811 frame which got the message is still alive, before dereferencing
1812 its pointer. (Bug#14970)
1813
1814 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1815 be a live window, before using it as such. (Bug#14970)
1816
e95da6d3
EZ
18172013-07-27 Eli Zaretskii <eliz@gnu.org>
1818
1819 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1820 w32_detect_focus_change instead of doing part of its job by hand.
1821 This fixes the problem whereby FOCUS_OUT events were not sent to
1822 the event queue.
1823
a8f93651
EZ
18242013-07-26 Eli Zaretskii <eliz@gnu.org>
1825
fec92060
EZ
1826 * process.c (Fprocess_list): Doc fix.
1827
a8f93651
EZ
1828 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1829 being re-exposed only if it didn't ask to become visible.
1830 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1831 was previously iconified. (Bug#14841)
1832 (x_iconify_frame): Mark the frame iconified.
1833
d5a7a9d9
PE
18342013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1835
1836 Fix minor problems found by static checking.
1837 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1838 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1839
56ea7291
SM
18402013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1841
1842 * eval.c (set_specpdl_old_value): New function.
1843 (unbind_to): Minor simplification.
1844 (get_backtrace_frame): New function.
1845 (Fbacktrace_frame): Use it. Add `base' argument.
1846 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1847 (syms_of_eval): Export backtrace-eval.
1848 * xterm.c (x_focus_changed): Simplify.
1849
9d611ffe
PE
18502013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1853
999c74e3
EZ
18542013-07-24 Eli Zaretskii <eliz@gnu.org>
1855
1856 * xdisp.c (redisplay_window): Instead of moving point out of
1857 scroll margin, reject the force_start method, and try scrolling
1858 instead. (Bug#14780)
1859
198fa217
KB
18602013-07-24 Ken Brown <kbrown@cornell.edu>
1861
1862 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1863 (Bug#14944).
1864
53840e55
PE
18652013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * eval.c (Fprogn): Do not check that BODY is a proper list.
1868 This undoes the previous change. The check slows down the
1869 interpreter, and is not needed to prevent a crash. See
1870 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1871
60967f56
GM
18722013-07-23 Glenn Morris <rgm@gnu.org>
1873
1874 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1875
9ca960e2
PE
18762013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1877
a29c3e6d
PE
1878 Port to GNU/Linux systems with tinfo but not ncurses.
1879 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1880 to decide whether ncurses is being used. Without this change,
1881 GCC complains about tgetent not being declared, on a system
1882 that has tinfo installed but ncurses not installed.
1883
f274311c
PE
1884 * eval.c (Fprogn): Check that BODY is a proper list.
1885
16b0520a
PE
1886 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1887 * data.c (Fsetq_default):
1888 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1889 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1890 (Fcondition_case):
1891 Tune by taking advantage of the fact that ARGS is always a list
1892 when a function is declared to have UNEVALLED args.
1893
9ca960e2
PE
1894 * emacsgtkfixed.c: Port to GCC 4.6.
1895 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1896
afacaa1b
JB
18972013-07-23 Juanma Barranquero <lekktu@gmail.com>
1898
1899 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1900 here to silence compiler warnings.
1901
368a85a4
PE
19022013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1905 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1906 from messing up Emacs's 'struct frame' (Bug#14923).
1907
f4e891b5
PE
19082013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 * alloc.c (make_save_ptr_ptr): Define this function.
1911 It was inadvertently omitted. It's needed only if
1912 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1913
96c8b65e
JD
19142013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1915
1916 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1917 frame have focus (Bug#14895).
1918
ee010797
PE
19192013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 Avoid vfork-related deadlock more cleanly.
1922 * callproc.c (child_setup): When the child's exec fails, output
1923 the program name, as that's more useful. Use O_NONBLOCK to avoid
1924 deadlock.
1925 * process.c (create_process_1): Remove; no longer needed.
1926 (create_process): Remove timer hack; no longer needed, now that
1927 the child avoids deadlock.
1928
f0398ec1 19292013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1930
1931 * image.c (Fimage_flush): Fix doc typo.
1932
b2a069c2
PE
19332013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1934
6496aec9
PE
1935 Fix array bounds violation when pty allocation fails.
1936 * process.c (PTY_NAME_SIZE): New constant.
1937 (pty_name): Remove static variable; it's now auto.
1938 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1939 Take pty_name as an arg rather than using a static variable.
1940 All callers changed.
1941 (create_process): Recover pty_flag from process, not from volatile local.
1942 (create_pty): Stay inside array even when pty allocation fails.
1943 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1944
b2a069c2
PE
1945 * lread.c (Fload): Avoid initialization only when lint checking.
1946 Mention that it's needed only for older GCCs.
1947
99107004
KH
19482013-07-20 Kenichi Handa <handa@gnu.org>
1949
1950 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1951 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1952
6b1b199d
AS
19532013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1954
1955 * lread.c (Fload): Avoid uninitialized warning.
1956
4195afc3
PE
19572013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1958
3f5bef16
PE
1959 Fix some minor file descriptor leaks and related glitches.
1960 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1961 (create_lock_file): Use write, not emacs_write.
1962 * image.c (slurp_file, png_load_body):
1963 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1964 (server_accept_connection):
1965 Don't leak an fd on memory allocation failure.
1966 * image.c (slurp_file): Add a cheap heuristic for growing files.
1967 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1968 as that's what the other routines do. Maybe input need not be
1969 blocked at all, but it's better to be consistent.
1970 Avoid undefined behavior when strlen is zero.
1971
4195afc3
PE
1972 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1973 (NSTATICS): Now a constant; doesn't need to be a macro.
1974
a1aeeffe
RS
19752013-07-19 Richard Stallman <rms@gnu.org>
1976
1977 * coding.c (decode_coding_utf_8): Add simple loop for fast
1978 processing of ASCII characters.
1979
63b34baa
PE
19802013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1983
621dd9ac
EZ
19842013-07-19 Eli Zaretskii <eliz@gnu.org>
1985
1986 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1987 unportable 'struct x_display_info'.
1988 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1989 is a portable type.
1990
1396ac86
PE
19912013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1992
ab9980cd
PE
1993 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1994 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1995 or fscanf fails.
1996 (system_process_attributes): Prefer plain char to unsigned char
1997 when either will do. Clean up properly if interrupted or if
068f9124
SM
1998 memory allocations fail. Don't assume sscanf succeeds.
1999 Remove no-longer-needed workaround to stop GCC from whining.
2000 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2001 bit more carefully.
2002
1396ac86
PE
2003 Fix obscure porting bug with varargs functions.
2004 The code assumed that int is treated like ptrdiff_t in a vararg
2005 function, which is not a portable assumption. There was a similar
2006 -- though these days less likely -- porting problem with various
2007 assumptions that pointers of different types all smell the same as
2008 far as vararg functions is conserved. To make this problem less
2009 likely in the future, redo the API to use varargs functions.
2010 * alloc.c (make_save_value): Remove this vararg function.
2011 All uses changed to ...
2012 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2013 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2014 New functions.
2015 (make_save_ptr): Rename from make_save_pointer, for consistency with
2016 the above. Define only on platforms that need it. All uses changed.
2017
4d19d194
PE
20182013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2019
2020 * keyboard.c: Try to fix typos in previous change.
2021 (DISPLAY_LIST_INFO): New macro.
2022 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2023 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2024
945c5bb1
JB
20252013-07-18 Juanma Barranquero <lekktu@gmail.com>
2026
2027 * keyboard.c (kbd_buffer_get_event):
2028 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2029 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2030
f4b1eb36
PE
20312013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2032
5e679a2c
PE
2033 * filelock.c: Fix unlikely file descriptor leaks.
2034 (get_boot_time_1): Rework to avoid using emacs_open.
2035 This doesn't actually fix a leak, but is better anyway.
2036 (read_lock_data): Use read, not emacs_read.
2037
a8cd4836
PE
2038 * doc.c: Fix minor memory and file descriptor leaks.
2039 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2040 (get_doc_string, Fsnarf_documentation):
2041 Fix file descriptor leak on error.
2042
ef30e638
PE
2043 * term.c: Fix minor fdopen-related file descriptor leaks.
2044 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2045 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2046
f4b1eb36
PE
2047 * charset.c: Fix file descriptor leaks and errno issues.
2048 Include <errno.h>.
2049 (load_charset_map_from_file): Don't leak file descriptor on error.
2050 Use plain record_xmalloc since the allocation is larger than
2051 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2052 of entries.
2053 * eval.c (record_unwind_protect_nothing):
2054 * fileio.c (fclose_unwind):
2055 New functions.
2056 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2057 The replacement doesn't block input, but that no longer seems
2058 necessary.
2059
b648c163
PE
20602013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2061
a0931322
PE
2062 * lread.c: Fix file descriptor leaks and errno issues.
2063 (Fload): Close some races that leaked fds or streams when 'load'
2064 was interrupted.
2065 (Fload, openp): Report error number of last nontrivial failure to open.
2066 ENOENT counts as trivial.
2067 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2068 New functions.
2069 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2070 now that the function is always called with a nonnegative arg.
2071 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2072 All uses replaced with ...
2073 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2074
b648c163
PE
2075 A few more minor file errno-reporting bugs.
2076 * callproc.c (Fcall_process):
2077 * doc.c (Fsnarf_documentation):
2078 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2079 * process.c (set_socket_option):
2080 Don't let a constructor trash errno.
2081 * doc.c: Include <errno.h>.
2082
b1dc4084
JB
20832013-07-16 Juanma Barranquero <lekktu@gmail.com>
2084
2085 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2086
c43843aa
PE
20872013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2088
50a30cce
PE
2089 Fix w32 bug with call-process-region (Bug#14885).
2090 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2091 to Fcall_process when the input is empty. This simplifies the
2092 code a bit. It makes no difference on POSIXish platforms but
2093 apparently it fixes a bug on w32.
2094
44e18199 2095 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2096 * fileio.c (close_file_unwind): Don't close if FD is negative;
2097 this can happen when unwinding a zapped file descriptor.
2098 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2099 in case Emacs runs out of memory between the two unwind-protects.
2100 Don't trash errno when closing FD.
2101 Zap the FD in the specpdl when closing it, instead of deferring
2102 the removal of the unwind-protect; this fixes a bug where a child
2103 function unwinds the stack past us.
2104
27e498e6
PE
2105 New unwind-protect flavors to better type-check C callbacks.
2106 This also lessens the need to write wrappers for callbacks,
2107 and the need for make_save_pointer.
2108 * alloca.c (free_save_value):
2109 * atimer.c (run_all_atimers):
2110 Now extern.
2111 * alloc.c (safe_alloca_unwind):
2112 * atimer.c (unwind_stop_other_atimers):
2113 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2114 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2115 * minibuf.c (choose_minibuf_frame_1):
2116 * process.c (make_serial_process_unwind):
2117 * xdisp.h (pop_message_unwind):
2118 * xselect.c (queue_selection_requests_unwind):
2119 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2120 * alloca.c (record_xmalloc):
2121 Prefer record_unwind_protect_ptr to record_unwind_protect with
2122 make_save_pointer.
2123 * alloca.c (Fgarbage_collect):
2124 Prefer record_unwind_protect_void to passing a dummy.
2125 * buffer.c (restore_buffer):
2126 * window.c (restore_window_configuration):
2127 * xfns.c, w32fns.c (do_unwind_create_frame)
2128 New wrapper. All record-unwind uses of wrappee changed.
2129 * buffer.c (set_buffer_if_live):
2130 * callproc.c (call_process_cleanup, delete_temp_file):
2131 * coding.c (code_conversion_restore):
2132 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2133 * editfns.c (save_excursion_restore)
2134 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2135 (save_restriction_restore):
2136 * eval.c (restore_stack_limits, un_autoload):
2137 * fns.c (require_unwind):
2138 * keyboard.c (recursive_edit_unwind, tracking_off):
2139 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2140 * macros.c (pop_kbd_macro, restore_menu_items):
2141 * nsfns.m (unwind_create_frame):
2142 * print.c (print_unwind):
2143 * process.c (start_process_unwind):
2144 * search.c (unwind_set_match_data):
2145 * window.c (select_window_norecord, select_frame_norecord):
2146 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2147 (fast_set_selected_frame):
2148 * xfns.c, w32fns.c (unwind_create_tip_frame):
2149 Return void, not a dummy Lisp_Object. All uses changed.
2150 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2151 * callproc.c (call_process_kill):
2152 * fileio.c (restore_point_unwind, decide_coding_unwind)
2153 (build_annotations_unwind):
2154 * insdel.c (Fcombine_after_change_execute_1):
2155 * keyboard.c (read_char_help_form_unwind):
2156 * menu.c (unuse_menu_items):
2157 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2158 * sound.c (sound_cleanup):
2159 * xdisp.c (unwind_redisplay):
2160 * xfns.c (clean_up_dialog):
2161 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2162 Accept no args and return void, instead of accepting and returning
2163 a dummy Lisp_Object. All uses changed.
2164 * cygw32.c (fchdir_unwind):
2165 * fileio.c (close_file_unwind):
2166 * keyboard.c (restore_kboard_configuration):
2167 * lread.c (readevalllop_1):
2168 * process.c (wait_reading_process_output_unwind):
2169 Accept int and return void, rather than accepting an Emacs integer
2170 and returning a dummy object. In some cases this fixes an
2171 unlikely bug when the corresponding int is outside Emacs integer
2172 range. All uses changed.
2173 * dired.c (directory_files_internal_unwind):
2174 * fileio.c (do_auto_save_unwind):
2175 * gtkutil.c (pop_down_dialog):
2176 * insdel.c (reset_var_on_error):
2177 * lread.c (load_unwind):
2178 * xfns.c (clean_up_file_dialog):
2179 * xmenu.c, nsmenu.m (pop_down_menu):
2180 * xmenu.c (cleanup_widget_value_tree):
2181 * xselect.c (wait_for_property_change_unwind):
2182 Accept pointer and return void, rather than accepting an Emacs
2183 save value encapsulating the pointer and returning a dummy object.
2184 All uses changed.
2185 * editfns.c (Fformat): Update the saved pointer directly via
2186 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2187 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2188 (unwind_body): New function.
2189 (record_unwind_protect): First arg is now a function returning void,
2190 not a dummy Lisp_Object.
2191 (record_unwind_protect_ptr, record_unwind_protect_int)
2192 (record_unwind_protect_void): New functions.
2193 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2194 * fileio.c (struct auto_save_unwind): New type.
2195 (do_auto_save_unwind): Use it.
2196 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2197 * insdel.c (struct rvoe_arg): New type.
2198 (reset_var_on_error): Use it.
2199 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2200 New constants.
2201 (specbinding_func): Remove; there are now several such functions.
2202 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2203 (set_unwind_protect_ptr): New function.
2204 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2205
4e604a5d
PE
2206 Be simpler and more consistent about reporting I/O errors.
2207 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2208 Say "Read error" and "Write error", rather than "I/O error", or
2209 "IO error reading", or "IO error writing", when a read or write
2210 error occurs.
2211 * process.c (Fmake_network_process, wait_reading_process_output)
2212 (send_process, Fprocess_send_eof, wait_reading_process_output):
2213 Capitalize diagnostics consistently. Put "failed foo" at the
2214 start of the diagnostic, so that we don't capitalize the
2215 function name "foo". Consistently say "failed" for such
2216 diagnostics.
2217 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2218 All callers changed. This is so it can use report_file_error.
2219 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2220 diagnostics consistently as above.
2221
a9757f6a
PE
2222 * fileio.c (report_file_errno): Fix errno reporting bug.
2223 If the file name is neither null nor a pair, package it up as a
2224 singleton list. All callers changed, both to this function and to
2225 report_file_error. This fixes a bug where the memory allocator
2226 invoked by list1 set errno so that the immediately following
2227 report_file_error reported the wrong errno value.
2228
c43843aa
PE
2229 Fix minor problems found by --enable-gcc-warnings.
2230 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2231 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2232
18c26d81
JD
22332013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2234
2235 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2236 Set event->arg to Qt if switch-event shall be generated.
2237 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2238
2239 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2240
2241 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2242 FOCUS_OUT_EVENT.
2243
2244 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2245 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2246 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2247 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2248 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2249 and there is a focused frame.
2250 (head_table): Add focus-in and focus-out.
2251 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2252 bind to handle-focus-in/out.
2253
2254 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2255 (Fhandle_switch_frame): Call Fhandle_focus_in.
2256 (syms_of_frame): defsubr handle-focus-in/out.
2257
6c6f1994
PE
22582013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2259
c7ddc792
PE
2260 Fix porting bug to older POSIXish platforms (Bug#14862).
2261 * sysdep.c (emacs_pipe): New function, that implements
2262 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2263 This should port better to CentOS 5 and to Mac OS X 10.6.
2264 All calls to pipe2 changed.
2265
6c6f1994
PE
2266 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2267 This makes the code easier to read and the executable a bit smaller.
2268 Do not replace all calls to Fcons that happen to create lists,
2269 just calls that are intended to create lists. For example, when
2270 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2271 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2272 Similarly for list2 through list5.
2273 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2274 * bytecode.c (exec_byte_code):
2275 * callint.c (quotify_arg, Fcall_interactively):
2276 * callproc.c (Fcall_process, create_temp_file):
2277 * charset.c (load_charset_map_from_file)
2278 (Fdefine_charset_internal, init_charset):
2279 * coding.c (get_translation_table, detect_coding_system)
2280 (Fcheck_coding_systems_region)
2281 (Fset_terminal_coding_system_internal)
2282 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2283 * composite.c (update_compositions, Ffind_composition_internal):
2284 * dired.c (directory_files_internal, file_name_completion)
2285 (Fsystem_users):
2286 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2287 * doc.c (Fsnarf_documentation):
2288 * editfns.c (Fmessage_box):
2289 * emacs.c (main):
2290 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2291 (Feval, eval_sub, Ffuncall, apply_lambda):
2292 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2293 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2294 (Fset_file_times, Finsert_file_contents)
2295 (Fchoose_write_coding_system, Fwrite_region):
2296 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2297 * font.c (font_registry_charsets, font_parse_fcname)
2298 (font_prepare_cache, font_update_drivers, Flist_fonts):
2299 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2300 * frame.c (make_frame, Fmake_terminal_frame)
2301 (x_set_frame_parameters, x_report_frame_params)
2302 (x_default_parameter, Fx_parse_geometry):
2303 * ftfont.c (syms_of_ftfont):
2304 * image.c (gif_load):
2305 * keyboard.c (command_loop_1):
2306 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2307 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2308 (Fminor_mode_key_binding, accessible_keymaps_1)
2309 (Faccessible_keymaps, Fwhere_is_internal):
2310 * lread.c (read_emacs_mule_char):
2311 * menu.c (find_and_return_menu_selection):
2312 * minibuf.c (get_minibuffer):
2313 * nsfns.m (Fns_perform_service):
2314 * nsfont.m (ns_script_to_charset):
2315 * nsmenu.m (ns_popup_dialog):
2316 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2317 (Fx_own_selection_internal):
2318 * nsterm.m (append2):
2319 * print.c (Fredirect_debugging_output)
2320 (print_prune_string_charset):
2321 * process.c (Fdelete_process, Fprocess_contact)
2322 (Fformat_network_address, set_socket_option)
2323 (read_and_dispose_of_process_output, write_queue_push)
2324 (send_process, exec_sentinel):
2325 * sound.c (Fplay_sound_internal):
2326 * textprop.c (validate_plist, add_properties)
2327 (Fput_text_property, Fadd_face_text_property)
2328 (copy_text_properties, text_property_list, syms_of_textprop):
2329 * unexaix.c (report_error):
2330 * unexcoff.c (report_error):
2331 * unexsol.c (unexec):
2332 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2333 (Fformat_mode_line, syms_of_xdisp):
2334 * xfaces.c (set_font_frame_param)
2335 (Finternal_lisp_face_attribute_values)
2336 (Finternal_merge_in_global_face, syms_of_xfaces):
2337 * xfns.c (x_default_scroll_bar_color_parameter)
2338 (x_default_font_parameter, x_create_tip_frame):
2339 * xfont.c (xfont_supported_scripts):
2340 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2341 (menu_help_callback, xmenu_show):
2342 * xml.c (make_dom):
2343 * xterm.c (set_wm_state):
2344 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2345 and similarly for list2 through list5.
2346
bafe80ce
PE
23472013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 * callproc.c (Fcall_process_region): Fix minor race and tune.
2350 (create_temp_file): New function, with the temp-file-creation part
2351 of the old Fcall_process_region. Use Fcopy_sequence to create the
2352 temp file name, rather than alloca + build_string, for simplicity.
2353 Don't bother to block input around the temp file creation;
068f9124
SM
2354 shouldn't be needed. Simplify use of mktemp.
2355 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2356 this closes an unlikely race where the temp file was not removed.
2357 Use memcpy rather than an open-coded loop.
2358 (Fcall_process_region): Use the new function. If the input is
2359 empty, redirect from /dev/null rather than from a newly created
2360 empty temp file; this avoids unnecessary file system traffic.
2361
4700b5a5
PE
23622013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2363
5c97beae
PE
2364 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2365 Simplify by making this case like the other two. This is a bit
2366 slower on obsolete hosts, but the extra complexity isn't worth it.
2367
4700b5a5
PE
2368 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2369 * process.c (create_process) [!DOS_NT]:
2370 Remove now-unnecessary calls to emacs_close.
2371
f9a74c4c
EZ
23722013-07-13 Eli Zaretskii <eliz@gnu.org>
2373
922ae7ee
EZ
2374 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2375 returning early. (Bug#14850)
2376
f9a74c4c
EZ
2377 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2378 and inhibit-iso-escape-detection attributes of 'undecided'.
2379 (Bug#14822)
2380
5e301d76
PE
23812013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2382
69e0e5ee
PE
2383 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2384 Reported by Herbert J. Skuhra in
2385 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2386
5e301d76
PE
2387 Don't lose top specpdl entry when memory is exhausted.
2388 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2389 specpdl overflow here, to simplify callers; all callers changed.
2390 Always reserve an unused entry at the stack top; this avoids
2391 losing the top entry's information when memory is exhausted.
2392
7e649856
PE
23932013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2394
a773ed9a
PE
2395 Clean up errno reporting and fix some errno-reporting bugs.
2396 * callproc.c (Fcall_process):
2397 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2398 * process.c (create_process, Fmake_network_process):
2399 * unexaix.c (report_error):
2400 * unexcoff.c (report_error):
2401 Be more careful about reporting the errno of failed operations.
2402 The code previously reported the wrong errno sometimes.
2403 Also, prefer report_file_errno to setting errno + report_file_error.
2404 (Fcall_process): Look at openp return value rather than at path,
2405 as that's a bit faster and clearer when there's a numeric predicate.
2406 * fileio.c (report_file_errno): New function, with most of the
2407 old contents of report_file_error.
2408 (report_file_error): Use it.
2409 (Ffile_exists_p, Ffile_accessible_directory_p):
2410 Set errno to 0 when it is junk.
2411 * fileio.c (Faccess_file):
2412 * image.c (x_create_bitmap_from_file):
2413 Use faccessat rather than opening the file, to avoid the hassle of
2414 having a file descriptor open.
2415 * lisp.h (report_file_errno): New decl.
2416 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2417
7e649856
PE
2418 Minor EBADF fixes.
2419 * process.c (create_process, wait_reading_process_output) [AIX]:
2420 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2421 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2422 a multithreaded environment anyway).
2423 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2424
f6774c1a
AS
24252013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2426
2427 * image.c (x_find_image_file): Don't close a remote file handle.
2428
bacba3c2
PE
24292013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 Fix races with threads and file descriptors.
2432 * callproc.c (Fcall_process_region):
2433 * dired.c (open_directory):
2434 * emacs.c (main, Fdaemon_initialized):
2435 * image.c (x_find_image_file):
2436 * inotify.c (Finotify_rm_watch):
2437 * lread.c (Flocate_file_internal):
2438 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2439 * term.c (term_mouse_moveto, init_tty):
2440 * termcap.c (tgetent):
2441 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2442 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2443 * unexhp9k800.c, unexmacosx.c (unexec):
2444 * callproc.c (Fcall_process_region):
2445 Use emacs_close, not close.
2446 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2447 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2448 and posix_close function on current platforms (which all lack them).
2449 (emacs_close): Use it. This should fix the races on GNU/Linux and
2450 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2451 and it should avoid closing random victim file descriptors on
2452 other platforms.
2453
653d4f43
PE
24542013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2455
c8536ec4
PE
2456 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2457 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2458 Touch up doc a bit.
2459
9c203066
PE
2460 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2461 This is for .gdbinit xbacktrace.
2462
653d4f43
PE
2463 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2464 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2465 (emacs_set_tty): Now static.
2466 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2467 * term.c (tty_capable_p, tty_default_color_capabilities)
2468 (get_tty_terminal, term_mouse_movement)
2469 (handle_one_term_event, init_tty, maybe_fatal):
2470 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2471 (tgetent, scan_file, name_match, compare_contin):
2472 * terminal.c (get_terminal):
2473 Use bool for boolean.
2474 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2475 Prefer char to unsigned char if either will do.
2476 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2477 (tty_write_glyphs): Prefer int to unsigned.
2478 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2479 All callers changed.
2480 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2481
45b683a1
PE
24822013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2483
29abe551
PE
2484 Port to C89.
2485 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2486 (B__dummy__): New dummy symbol, to pacify C89.
2487 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2488 they can't grok varargs macros.
2489 * dispnew.c (add_window_display_history)
2490 (add_frame_display_history):
2491 * print.c (print_object):
2492 * xdisp.c (debug_method_add):
2493 Use %p printf format only for void pointers.
2494 * emacs.c (usage_message): New constant, replacing ...
2495 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2496 (main): Adjust to usage reorg.
2497 * fns.c (syms_of_fns):
2498 * profiler.c (syms_of_profiler):
2499 Don't use non-constant struct initializers.
2500 * gnutls.h (gnutls_initstage_t):
2501 * lisp.h (enum Lisp_Fwd_Type):
2502 * lread.c (lisp_file_lexically_bound_p):
2503 * xsettings.c (anonymous enum):
2504 Remove trailing comma.
2505 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2506 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2507 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2508 (DEFUN): Use it.
2509 * regex.c (const_re_char): New type, to pacify strict C89.
2510 All uses of 'const re_char' replaced to use it.
2511 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2512 with glibc when strict C89. This change is imported from gnulib.
2513 All uses changed.
2514 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2515 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2516 Omit GNU_LINUX implementation, since it requires long long.
2517 * xterm.c (x_draw_underwave):
2518 Do not assume the traditional order of struct's members.
2519 (x_term_init): Rewrite to avoid the need for non-constant structure
2520 initializers.
2521
45b683a1 2522 Syntax cleanup, mostly replacing macros with functions.
763a086d 2523 This removes the need for the syntax_temp hack.
45b683a1
PE
2524 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2525 * syntax.c (SYNTAX_INLINE): New macro.
2526 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2527 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2528 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2529 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2530 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2531 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2532 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2533 Now constants, not macros.
2534 (syntax_temp) [!__GNUC__]: Remove.
2535 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2536 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2537 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2538 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2539 Move here from syntax.h; now functions, not macros. Except for the
2540 last function, these are static since only syntax.c uses them.
2541 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2542 All uses changed. Now a function, not a macro; use this fact
2543 to simplify the code.
2544 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2545 compiler bugs; no longer relevant.
2546 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2547 (SYNTAX_INLINE): New macro.
2548 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2549 for the new functions. Use bool for boolean member.
2550 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2551 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2552 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2553 (SETUP_BUFFER_SYNTAX_TABLE):
2554 Now extern inline functions, not macros.
2555 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2556 Remove; all uses replaced by implementation.
2557 (syntax_temp) [!__GNUC__]: Remove decl.
2558 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2559
29be4a50
JD
25602013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2561
2562 * emacs.c (main): Fix syntax error.
2563
954b166e
PE
25642013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2565
2566 Timestamp fixes for undo (Bug#14824).
2567 * atimer.c (schedule_atimer):
2568 * fileio.c (Ffile_newer_than_file_p):
2569 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2570 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2571 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2572 (syms_of_fileio): Remove Sclear_visited_file_name.
2573 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2574 file doesn't exist; this avoids an ambiguity with negative timestamps.
2575 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2576 * systime.h (make_emacs_time, invalid_emacs_time):
2577 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2578 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2579 * undo.c (record_first_change): Push (visited-file-modtime) onto
2580 undo list rather than reimplementing it by hand, incorrectly.
2581
d74647c3
KB
25822013-07-09 Ken Brown <kbrown@cornell.edu>
2583
2584 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2585
3c51b96b
JB
25862013-07-09 Juanma Barranquero <lekktu@gmail.com>
2587
2588 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2589
4ebbdd67
PE
25902013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 Handle errno and exit status a bit more carefully.
2593 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2594 number into an exit status. Instead, use EXIT_CANCELED.
2595 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2596 * callproc.c (relocate_fd):
2597 * emacs.c (close_output_streams, main):
2598 * process.c (create_process):
2599 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2600 Use emacs_perror for simplicity.
2601 * callproc.c (relocate_fd, main):
2602 * sysdep.c (sys_subshell):
2603 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2604 (shut_down_emacs): Use emacs_write, not write.
2605 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2606 * fileio.c (Fcopy_file, e_write):
2607 * nsterm.m (ns_select):
2608 * process.c (send_process):
2609 * sound.c (vox_write):
2610 Use emacs_write_sig, not emacs_write.
2611 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2612 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2613 New constants.
2614 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2615 of write.
2616 (emacs_full_write): New function.
2617 (emacs_write): Rewrite to use it.
2618 (emacswrite_sig, emacs_perror): New functions.
2619 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2620
44e18199 26212013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2622
2623 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2624 on NS even if it is present. Pixmap on NS is a void*.
2625
9caab067
PE
26262013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 Port to Ubuntu 10 (Bug#14803).
2629 Problem reported by T.V. Raman.
2630 * process.c (close_on_exec, accept4, process_socket):
2631 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2632
1d442672
EZ
26332013-07-07 Eli Zaretskii <eliz@gnu.org>
2634
2635 * w32.c (sys_dup): Declare prototype.
2636
2637 * filelock.c:
2638 * emacs.c:
2639 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2640
067428c1
PE
26412013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 Make file descriptors close-on-exec when possible (Bug#14803).
2644 This simplifies Emacs a bit, since it no longer needs to worry
2645 about closing file descriptors by hand in some cases.
2646 It also fixes some unlikely races. Not all such races, as
2647 libraries often open files internally without setting
2648 close-on-exec, but it's an improvement.
2649 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2650 * callproc.c (Fcall_process) [!MSDOS]:
2651 * emacs.c (main) [!DOS_NT]:
2652 * nsterm.m (ns_term_init):
2653 * process.c (create_process):
2654 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2655 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2656 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2657 Prefer mkostemp with O_CLOEXEC to mkstemp.
2658 * callproc.c (relocate_fd) [!WINDOWSNT]:
2659 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2660 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2661 now using pipe2.
2662 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2663 Make the resulting file descriptor close-on-exec.
2664 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2665 * lread.c (load_descriptor_list, load_descriptor_unwind):
2666 Remove; no longer needed. All uses removed.
2667 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2668 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2669 New functions.
2670 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2671 (Fmake_network_process, Fnetwork_interface_list):
2672 (Fnetwork_interface_info, server_accept_connection):
2673 Make newly-created socket close-on-exec.
2674 * sysdep.c (emacs_open, emacs_fopen):
2675 Make new-created descriptor close-on-exec.
2676 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2677 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2678
0da857dd
JD
26792013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2680
2681 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2682 for NS_IMPL_GNUSTEP.
2683
5f86adcd
PE
26842013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 Fix openp errno handling.
2687 * callproc.c (Fcall_process): Preserve openp errno around close.
2688 * lread.c (openp): Set errno when returning -1, as some callers
2689 expect this.
2690
1afb1d07
JD
26912013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2692
2693 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2694
2695 * nsterm.h (NSSavePanel): Update comment.
2696 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2697 (ns_run_file_dialog): Declare.
2698
2699 * nsfns.m: Remove panelOK.
2700 (ns_fd_data): New.
2701 (ns_run_file_dialog): New function.
2702 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2703 event loop, so file dialog is popped up by ns_run_file_dialog, called
2704 by sendEvent (Bug#14578).
2705 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2706
3323c263
EZ
27072013-07-06 Eli Zaretskii <eliz@gnu.org>
2708
fdda0220
EZ
2709 * xdisp.c (default_line_pixel_height): New function.
2710 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2711 (try_cursor_movement, redisplay_window, try_window)
2712 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2713
068f9124
SM
2714 * window.c (window_scroll_pixel_based):
2715 use default_line_pixel_height.
fdda0220
EZ
2716
2717 * dispextern.h (default_line_pixel_height): Add prototype.
2718
2719 * frame.c (x_set_line_spacing): Accept a float value for
2720 line-spacing parameter, per the documentation.
2721
3323c263
EZ
2722 * data.c (Fmultibyte_string_p): Doc fix.
2723
47ba6d43
PE
27242013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2725
406af475
PE
2726 Use emacs_open more consistently when opening files.
2727 This handles EINTR more consistently now, and makes it easier
2728 to introduce other uniform changes to file descriptor handling.
2729 * src/systdio.h: New file.
2730 * src/buffer.c (mmap_init):
2731 * cygw32.c (chdir_to_default_directory):
2732 * dispnew.c (Fopen_termscript):
2733 * emacs.c (Fdaemon_initialized):
2734 * fileio.c (Fdo_auto_save):
2735 * image.c (slurp_file, png_load_body, jpeg_load_body):
2736 * keyboard.c (Fopen_dribble_file):
2737 * lread.c (Fload):
2738 * print.c (Fredirect_debugging_output):
2739 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2740 * termcap.c (tgetent):
2741 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2742 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2743 * w32term.c (w32_initialize) [CYGWIN]:
2744 * xfaces.c (Fx_load_color_file):
2745 Use emacs_open instead of plain open, and emacs_fopen instead of
2746 plain fopen.
2747 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2748 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2749 * callproc.c (default_output_mode): New constant.
2750 (Fcall_process): Use it to call emacs_open instead of plain creat.
2751 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2752 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2753 (emacs_fopen): New function.
2754 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2755 Include <lisp.h>, for emacs_open.
2756 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2757
47ba6d43
PE
2758 Remove duplicate #include directives.
2759 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2760 * xfaces.c:
2761 Don't include stdio.h twice.
2762 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2763 Don't include sys/types.h or stdio.h twice.
2764 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2765 * lread.c: Don't include coding.h twice.
2766 * nsfont.m: Don't include frame.h twice.
2767 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2768 * ralloc.c: Don't include <unistd.h> twice.
2769 * xdisp.c: Don't include font.h twice.
2770 * xterm.c: Don't include fontset.h twice.
2771 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2772
b9ed53d5
PE
27732013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2774
2775 Scale ImageMagick images more carefully.
2776 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2777 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2778 Be more careful about avoiding undefined behavior after
2779 integer overflow and division by zero.
2780
cf13177e
YM
27812013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2782
2783 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2784 (syms_of_w32fns): DEFSYM them.
2785 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2786 (CCHDEVICENAME): Define macros if not defined.
2787 (struct MONITOR_INFO_EX): New struct.
2788 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2789 (enum_display_monitors_fn): New variable.
2790 (globals_of_w32fns): Initialize it.
2791 (Fx_display_pixel_width, Fx_display_pixel_height)
2792 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2793 multi-monitor setups in docstrings.
2794 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2795 screen size by primary monitor's millimeter per pixel.
2796 (w32_monitor_enum, w32_display_monitor_attributes_list)
2797 (w32_display_monitor_attributes_list_fallback)
2798 (Fw32_display_monitor_attributes_list): New functions.
2799 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2800
2801 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2802 if not defined.
2803 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2804
86dfb7a8
MA
28052013-07-04 Michael Albinus <michael.albinus@gmx.de>
2806
2807 * fileio.c (Qfile_notify_error): New error symbol.
2808
2809 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2810 * inotify.c (inotify_callback, symbol_to_inotifymask)
2811 (Finotify_add_watch, Finotify_rm_watch): Use it.
2812 (inotifyevent_to_event): Exchange order of cookie and file name.
2813 (Finotify_add_watch): Adapt docstring.
2814
2815 * lisp.h (Qfile_notify_error): Declare.
2816
2c1c974b
PE
28172013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2820 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2821 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2822 which did not work (see <http://bugs.gnu.org/14569#307>).
2823 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2824 && (!noninteractive || initialized)). This attempts to thread
2825 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2826
7a35b20f
JB
28272013-07-04 Juanma Barranquero <lekktu@gmail.com>
2828
2829 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2830 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2831
1ce5cd04
PE
28322013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2835 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2836 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2837 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2838
57f8c490
PE
28392013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2840
2841 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2842 Define to __sys_siglist.
2843
bcffb5ca
EZ
28442013-07-02 Eli Zaretskii <eliz@gnu.org>
2845
2846 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2847 word-wrap, so that overflow-newline-into-fringe would work in
2848 visual-line-mode. (Bug#2749)
2849 (move_it_in_display_line_to): When the last scanned display
2850 element fits exactly on the display line, and
2851 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2852 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2853 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2854 finding buffer position that corresponds to pixel coordinates,
2855 e.g. in buffer_posn_from_coords.
2856
2c41e781
JD
28572013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2858
2859 * process.c (handle_child_signal): Call catch_child_signal if
2860 NS_IMPL_GNUSTEP.
2861
c2418359
PE
28622013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2863
52a9bcae
PE
2864 Don't convert function pointers to void * and back.
2865 It isn't portable C, and it's easy enough to avoid.
2866 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2867 (make_save_value): Add support for SAVE_FUNCPOINTER.
2868 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2869 * print.c (print_object):
2870 Distinguish function from object pointers.
2871 * lisp.h (SAVE_FUNCPOINTER): New constant.
2872 (SAVE_SLOT_BITS): Adjust to it.
2873 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2874 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2875 (voidfuncptr): New typedef.
2876 (struct Lisp_Save_Value): New member data[0].funcpointer.
2877 (XSAVE_FUNCPOINTER): New function.
2878
c2418359
PE
2879 Simplify buildobj processing.
2880 * Makefile.in (buildobj.h): Make it a sequence of strings each
2881 followed by comma, rather than a single string. Put it into a
2882 .tmp file in case there's an error while generating it.
2883 (gl-stamp): Use .tmp for temp files.
2884 (mostlyclean): Clean .tmp files.
2885 * doc.c (buildobj): Move to just the routine that needs it.
2886 It's now an array of strings, so processing is simpler.
2887
8f43ce49
PE
28882013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2889
2890 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2891 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2892 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2893 Invoke malloc_enable_thread even when not interactive.
2894 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2895 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2896 in this case, since the underlying bug has now been fixed.
2897
24827db9
JB
28982013-07-01 Juanma Barranquero <lekktu@gmail.com>
2899
2900 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2901 unlinking it (bug#14691).
2902
ef099a94
MN
29032013-06-30 Michal Nazarewicz <mina86@mina86.com>
2904
2905 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2906 before checking whether buffer is modified. This lets
2907 `kill-buffer-query-functions' cancel killing of the buffer or save
2908 its content before `kill-buffer' asks user the "Buffer %s
2909 modified; kill anyway?" question.
2910
9d3f2fc2
JD
29112013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2912
2913 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2914 Let the super performKeyEquivalent deal with them (Bug#14747).
2915
e6c6c8c7
PE
29162013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2917
1d71c1d9
PE
2918 * widget.c (resize_cb): Remove unused local.
2919
8f5f35cc
PE
2920 Do not use GTK 3 if it exists but cannot be compiled.
2921 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2922 * xterm.c (x_error_handler) [!USE_GTK]:
2923 Do not use GTK 3.
2924
e6c6c8c7
PE
2925 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2926
0ba54312
EZ
29272013-06-30 Eli Zaretskii <eliz@gnu.org>
2928
5d1c3286
EZ
2929 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2930 to the valid range of values. (Bug#14753)
2931
0ba54312
EZ
2932 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2933 when moving point by using the current glyph matrix. This avoids
2934 the need to force redisplay when this function is called in a
2935 loop.
2936
9c90cc06
PE
29372013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2938
2939 Fix minor problems found by static checking.
2940 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2941 Redo the latter's body to sidestep GCC parenthesization warnings.
2942 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2943 * coding.c (detect_coding, detect_coding_system):
2944 * coding.h (struct undecided_spec):
2945 Use bool for boolean.
2946 * image.c (QCmax_width, QCmax_height): Now static.
2947 * xdisp.c (Fmove_point_visually): Remove unused local.
2948
4c672a0f
EZ
29492013-06-29 Eli Zaretskii <eliz@gnu.org>
2950
2951 * xdisp.c (Fmove_point_visually): New function.
2952
c1ea3abf
JB
29532013-06-28 Kenichi Handa <handa@gnu.org>
2954
2955 * coding.h (define_coding_undecided_arg_index): New enum.
2956 (coding_attr_index): New members
2957 coding_attr_undecided_inhibit_null_byte_detection,
2958 coding_attr_undecided_inhibit_iso_escape_detection,
2959 coding_attr_undecided_prefer_utf_8.
2960 (undecided_spec): New struct.
2961 (struct coding_system): New member `undecided' of the member
2962 `spec'.
2963
2964 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2965 (detect_coding): Likewise.
2966 (detect_coding_system): Likewise.
2967 (Fdefine_coding_system_internal): New coding system properties
2968 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2969 :prefer-utf-8.
2970 (syms_of_coding): Adjust for coding_arg_undecided_max.
2971
ba3de9e6
PE
29722013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2973
2974 * image.c (x_from_xcolors): Remove unused local.
2975
547c9269
YM
29762013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2977
2978 Defer image data transfer between X client and server until actual
2979 display happens.
2980
2981 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2982 and `mask_img'.
2983
2984 * image.c (Destroy_Image): Remove.
2985 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2986 `mask_p', and `colors_p'. All uses changed.
2987 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2988 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2989 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2990 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2991 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2992 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2993 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2994 (image_get_x_image, image_unget_x_image): New functions or macros.
2995 (image_background, image_background_transparent, x_to_xcolors)
2996 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2997 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2998 instead of Destroy_Image.
2999 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3000 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3001 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3002 (imagemagick_load_image, svg_load_image): Use them instead of
3003 x_create_x_image_and_pixmap, and x_put_x_image followed by
3004 x_destroy_x_image, respectively.
3005 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3006 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3007 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3008 background_transparent fields.
3009 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3010 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3011
dae2f5ef
PE
30122013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3013
3014 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3015 This mostly consists of undoing recent changes.
3016 * callproc.c (Fcall_process):
3017 * process.c (create_process):
3018 Do not worry about catching SIGCHLD here, undoing previous change.
3019 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3020 * process.c, process.h (catch_child_signal):
3021 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3022 * process.c (catch_child_handler): Don't worry about being called
3023 lazily and do not assume caller has blocked SIGCHLD, undoing
3024 previous change. Move first-time stuff back to
3025 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3026 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3027 set lib_child_handler if it's already initialized, which may
3028 help avoid problems on GNUStep.
3029
fa55d2aa
PE
30302013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3033 * callproc.c (Fcall_process):
3034 * process.c (create_process):
3035 Make sure SIGCHLD is caught before we fork,
3036 since Emacs startup no arranges to catch SIGCHLD.
3037 * process.c (lib_child_handler): Initialize to null, not to
3038 dummy_handler.
3039 (catch_child_signal): Allow self to be called lazily.
3040 Do nothing if it's already been called.
3041 Assume caller has blocked SIGCHLD (all callers do now).
3042 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3043 just before it's really needed.
3044 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3045 since it hasn't been caught yet.
3046
f3f9606c
LMI
30472013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3048
3049 * image.c (compute_image_size): New function to implement
3050 :max-width and :max-height.
3051 (imagemagick_load_image): Use it.
3052
c7041908
PE
30532013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3056 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3057 Now extern.
3058 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3059 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3060 the SIGCHLD handler, since the code is not atomic and (due to glib)
3061 signals may be arriving now.
3062 * sysdep.c (init_signals): Do not catch child signals here;
3063 'main' now does that later, at a safer time.
3064
f86852b4
PE
30652013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3066
0dfeed58
PE
3067 Clean up SIGCHLD handling a bit (Bug#14569).
3068 * process.c, process.h (catch_child_signal):
3069 Now always extern, even if !NS_IMPL_GNUSTEP.
3070 * process.c (catch_child_signal): Move glib tickler here from
3071 init_process_emacs, so that it's done earlier in Emacs
3072 initialization. Also move the noninteractive && !initialized
3073 check here from init_process_emacs. This is all a bit cleaner for
3074 GNUish platforms, and I hope it works around the Cygwin bug.
3075 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3076 that glib signal handling is tickled before glib creates threads.
3077
f86852b4
PE
3078 * process.c (wait_reading_process_output): Avoid int overflow
3079 when reading more than 2 GiB total from a process.
3080
cbd6509c
PE
30812013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * process.c (create_process): Handle a couple more cases,
3084 i.e., work even if new_argv and wait_child_setup[i] are cached.
3085 Use Fcall_process's style for volatile vars.
3086
9de1114a
AS
30872013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3088
3089 * process.c (create_process): Mark PROCESS volatile.
3090
fbe9e0b9
PE
30912013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3092
3093 Use C99-style flexible array members if available.
3094 This avoids some subtle aliasing issues, which typically
3095 aren't a problem with GCC but may be a problem elsewhere.
3096 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3097 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3098 In either case, it uses a flexible array member rather than
3099 the old struct hack. All uses changed.
3100 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3101 Adjust to sdata reorganization.
3102 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3103 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3104 that ports better to pre-C99 non-GCC.
3105 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3106 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3107 as the latter has changed.
3108 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3109 and port better to pre-C99 GCC.
3110 * image.c (struct xpm_cached_color):
3111 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3112 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3113 Use FLEXIBLE_ARRAY_MEMBER.
3114 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3115 Move decl to top level so it gets checked against implementation.
3116 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3117 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3118
1fc71008
PE
31192013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3120
3121 * syntax.c: Integer cleanups.
3122 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3123 All uses that need 0-or-2 changed to:
3124 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3125 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3126 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3127 (char_quoted, prev_char_comend_first, back_comment)
3128 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3129 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3130 Use bool for boolean.
3131 (update_syntax_table, skip_chars, skip_syntaxes):
3132 Prefer int to unsigned when either will do.
3133 (back_comment): Return boolean success flag, like forw_comment,
3134 instead of positive-or-minus-1 (which might have overflowed int anyway).
3135 Don't stuff ptrdiff_t into int.
3136 (syntax_spec_code, syntax_code_spec): Now const.
3137 (Fmatching_paren, scan_lists, scan_sexps_forward):
3138 Use enum syntaxcode for syntax code.
3139 (Fmatching_paren): Check that arg is a character, not just an integer.
3140 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3141 (Finternal_describe_syntax_value): Omit no-longer-needed
3142 comparison to 0.
3143 (skip_chars): Use char, not unsigned char, when the distinction
3144 doesn't matter.
3145 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3146 * bytecode.c (exec_byte_code):
3147 * syntax.c (syntax_spec_code, Fchar_syntax)
3148 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3149 (init_syntax_once):
3150 * syntax.h (SYNTAX_WITH_FLAGS):
3151 Omit unnecessary casts.
3152
b932cad7
EZ
31532013-06-20 Eli Zaretskii <eliz@gnu.org>
3154
3155 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3156 line dimensions here, to avoid race conditions with the main
3157 thread. (Bug#14062, bug#14630, bug#14669)
3158
3159 * w32term.c (w32_draw_window_cursor): Compute the header line and
3160 mode line dimensions here.
3161 <w32_system_caret_window, w32_system_caret_hdr_height>:
3162 <w32_system_caret_mode_height>: New variables.
3163
3164 * w32term.h: Declare them.
3165
89561f72
PE
31662013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3167
5013fc08
PE
3168 * alloc.c (die): Move "assertion failed" string here ...
3169 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3170 COND when SUPPRESS_CHECKING. This shrinks the executable text
3171 size by 0.8% to 2.2% when configured with --enable-checking,
3172 depending on optimization flags (GCC 4.8.1 x86-64).
3173
89561f72
PE
3174 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3175
763a086d 31762013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3177
3178 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3179 base is 2; this is more accurate.
3180
983aeb9a
JB
31812013-06-19 Juanma Barranquero <lekktu@gmail.com>
3182
3183 * sound.c (string_default): Move to !WINDOWSNT section.
3184 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3185
178ba3e6
PE
31862013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3187
bbc51b15
PE
3188 * sound.c: Integer cleanups.
3189 Remove unnecessary forward decls.
3190 (struct sound_device): The 'file' member is now a Lisp_Object, not
3191 a char *, so that we needn't invoke alloca on a huge size.
3192 (Fplay_sound_internal): Adjust to this.
3193 (string_default): New function.
3194 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3195 Use it to adjust to the struct sound_device change.
3196 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3197 (be2hs) [0]: Remove.
3198
178ba3e6
PE
3199 * syntax.c (skip_chars): Don't use uninitialized storage
3200 when searching a multibyte buffer for characters that are not in a
3201 unibyte string that contains non-ASCII characters.
3202
69f60cdc
JD
32032013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3204
3205 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3206 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3207
0d6224d4
PE
32082013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3209
3210 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3211
3c542890
KH
32122013-06-18 Kenichi Handa <handa@gnu.org>
3213
f7e3f7cd
KH
3214 * font.c (Ffont_spec): Signal an error for an invalid font name
3215 (Bug#14648).
3c542890 3216
9349e5f7
PE
32172013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3218
3219 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3220 In particular this ports to 32-bit sparc Sun cc.
3221 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3222 array with a dummy element at specpdl[-1], so that its address can
3223 be taken portably.
3224 (unbind_to): Do not copy the binding; not needed, now that we
3225 copy old_value in the one place where the copy is needed.
3226 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3227 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3228 (union specbinding): Rename from struct specbinding. Redo layout
3229 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3230 which is not portable. With Sun C 5.12 32-bit sparc, the
3231 declaration causes nargs to be an unsigned bitfield, a behavior
3232 that the C standard allows; but Emacs wants nargs to be signed.
3233 The overall type is now a union of structures rather than a
3234 structure of union of structures, and the 'kind' member is now a
3235 bitfield, so that the overall type doesn't grow. All uses changed.
3236 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3237
0a4df6a5
PE
32382013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3239
ec6ecaad
PE
3240 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3241 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3242
0a4df6a5
PE
3243 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3244
7bfe8dbc
EZ
32452013-06-17 Eli Zaretskii <eliz@gnu.org>
3246
3247 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3248 unless we know that the window w's frame is a frame object.
3249 Another attempt at solving bug#14062 and bug#14630.
3250
708e05f6
LMI
32512013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3252
3253 * textprop.c (property_set_type): New enum.
3254 (add_properties): Allow appending/prepending text properties.
3255 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3256 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3257 add_text_properties_1.
3258 (Fadd_face_text_property): New function that calls
3259 add_text_properties_1.
3260
84575e67
PE
32612013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 Move functions from lisp.h to individual modules when possible.
3264 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3265 * alloc.c (XFLOAT_INIT, set_symbol_name):
3266 * buffer.c (CHECK_OVERLAY):
3267 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3268 (set_char_table_parent):
3269 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3270 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3271 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3272 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3273 (set_blv_valcell):
3274 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3275 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3276 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3277 (backtrace_args, backtrace_debug_on_exit):
3278 * floatfns.c (CHECK_FLOAT):
3279 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3280 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3281 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3282 (set_hash_index_slot):
3283 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3284 * marker.c (CHECK_MARKER):
3285 * textprop.c (CHECK_STRING_OR_BUFFER):
3286 * window.c (CHECK_WINDOW_CONFIGURATION):
3287 Move here from lisp.h, and make these functions static rather than
3288 extern inline.
3289 * buffer.c (Qoverlayp):
3290 * data.c (Qsubrp):
3291 * fns.c (Qhash_table_p):
3292 * window.c (Qwindow_configuration_p):
3293 Now static.
3294 * lisp.h: Remove the abovementioned defns and decls.
3295
44e18199 3296 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3297 In lisp.h, prefer functions to function-like macros, and
3298 constants to object-like macros, when either will do. This:
3299 . simplifies use, as there's no more need to worry about
3300 arguments' side effects being evaluated multiple times.
3301 . makes the code easier to debug on some platforms.
3302 However, when using gcc -O0, keep using function-like macros
3303 for a few critical operations, for performance reasons.
3304 This sort of thing isn't needed with gcc -Og, but -Og
3305 is a GCC 4.8 feature and isn't widely-enough available yet.
3306 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3307 Remove enum lsb_bits; no longer needed.
3308 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3309 * buffer.c (Qoverlap):
3310 * data.c (Qsubrp):
3311 * fns.c (Qhash_table_p):
3312 Now extern, so lisp.h can use these symbols.
3313 * dispextern.h: Include character.h, for MAX_CHAR etc.
3314 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3315 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3316 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3317 (GLYPH_CODE_P): Move here from lisp.h.
3318 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3319 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3320 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3321 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3322 XUNTAG now returns void *.
3323 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3324 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3325 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3326 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3327 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3328 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3329 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3330 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3331 New macros, renamed from their sans-lisp_h_ counterparts.
3332 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3333 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3334 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3335 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3336 If compiling via GCC without optimization, define these as macros
3337 in addition to inline functions.
3338 To disable this, compile with -DINLINING=0.
3339 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3340 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3341 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3342 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3343 (INTMASK, VALMASK): Now macros, since static values cannot be
3344 accessed from extern inline functions.
3345 (VALMASK): Also a constant, for benefit of old GDB.
3346 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3347 is INTEGERP, which can fold it in.
5165d44a 3348 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3349 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3350 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3351 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3352 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3353 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3354 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3355 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3356 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3357 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3358 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3359 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3360 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3361 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3362 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3363 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3364 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3365 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3366 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3367 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3368 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3369 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3370 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3371 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3372 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3373 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3374 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3375 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3376 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3377 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3378 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3379 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3380 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3381 Now functions.
3382 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3383 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3384 (VALMASK): Define in one place rather than in two, merging the
3385 USE_LSB_TAG parts; this is simpler.
3386 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3387 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3388 Move up, to avoid use before definition.
3389 Also include "globals.h" earlier, for the same reason.
3390 (make_natnum): New function.
3391 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3392 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3393 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3394 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3395 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3396 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3397 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3398 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3399 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3400 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3401 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3402 (Qwindow_configuration_p, Qimage): New forward declarations.
3403 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3404 (STRING_COPYIN): Remove; unused.
3405 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3406 (xcar_addr, xcdr_addr): New functions. All uses changed.
3407 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3408 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3409 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3410 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3411 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3412 (TYPE_RANGED_INTEGERP): Simplify.
3413 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3414 (setlocale, fixup_locale, synchronize_system_messages_locale)
3415 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3416 Now empty functions, not macros.
3417 (functionp): Return bool, not int.
3418 * window.c (Qwindow_configuration_p): Now extern,
3419 so window.h can use it.
3420 * window.h (Qwindowp): Move decl back to lisp.h.
3421
9583ec36
EZ
34222013-06-15 Eli Zaretskii <eliz@gnu.org>
3423
3424 * xdisp.c (Fline_pixel_height): New function, required for solving
3425 bug #14567.
3426
210272ce
PE
34272013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3428
3429 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3430
de0503df
SM
34312013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3432
3433 * lread.c (syms_of_lread):
3434 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3435
afbfe143
KD
34362013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3437
3438 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3439
d177e213
XF
34402013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3441
3442 * fileio.c (expand_file_name): Doc fix.
3443
05e3e412
PE
34442013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3445
f7394b12
PE
3446 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3447 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3448 Wait for self, not for 0. This can't hurt on GNU or similar
3449 system, and may help with Cygwin.
3450
05e3e412
PE
3451 * keyboard.c: Don't use PROP (...) as an lvalue.
3452 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3453 Use set_prop (A, B), not PROP (A) = B.
3454
17dd3097
EZ
34552013-06-10 Eli Zaretskii <eliz@gnu.org>
3456
3457 * xdisp.c (get_it_property): Use it->window instead of generating
3458 a Lisp object from it->w.
3459
52fab9c9
EZ
34602013-06-09 Eli Zaretskii <eliz@gnu.org>
3461
3462 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3463 get-char-property the window that is being rendered, instead of
3464 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3465 (compute_display_string_pos): When W is NULL, use the current
3466 buffer as the object to pass to get-char-property.
3467 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3468 pointer member of the bidi iterator, since no window is pertinent
3469 to this function.
52fab9c9 3470
5bf97bfc
EZ
34712013-06-08 Eli Zaretskii <eliz@gnu.org>
3472
3473 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3474 being displayed, and pass it to compute_display_string_pos.
3475 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3476 (bidi_paragraph_init): All callers changed.
3477
3478 * xdisp.c (init_from_display_pos, init_iterator)
3479 (handle_single_display_spec, next_overlay_string)
3480 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3481 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3482 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3483 (compute_display_string_pos): Accept additional argument, the
3484 window being displayed, and pass it to Fget_char_property.
3485 (Bug#14575)
3486
3487 * dispextern.h (struct bidi_it): New member w, the window being
3488 displayed.
3489 (compute_display_string_pos): Adjust prototype.
3490
5de0e011
JD
34912013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3492
e7b41c4c 3493 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3494
3495 * process.c (wait_reading_process_output): Check for NS before GLIB.
3496 GLIB may be linked in due to rsvg, but ns_select must be called.
3497
5de0e011
JD
3498 * xgselect.c (xg_select): Remove call to window_system_available
3499 and g_main_context_pending at the top, so Gdk events (i.e. file
3500 notify) are processed when Emacs is started with -nw.
3501
a822acff
EZ
35022013-06-07 Eli Zaretskii <eliz@gnu.org>
3503
3504 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3505 (ctagsfiles3): New variable, includes only *.m files.
3506 (TAGS): Use an explicit language name in the regular expressions,
3507 to avoid transformation of '/SOMETHING' by MSYS to
3508 'c:\MSYS\SOMETHING'.
3509
6c0a9ed1
RC
35102013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3511
3512 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3513
9ef6111b
EZ
35142013-06-06 Eli Zaretskii <eliz@gnu.org>
3515
3516 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3517 still need to set the mouse pointer shape and activate help-echo.
3518 (Bug#14558)
3519
7d300d64
PE
35202013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 A few porting etc. fixes for the new file monitor code.
3523 See the thread containing
3524 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3525 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3526 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3527 (dir_monitor_callback, Fgfile_rm_watch):
3528 Use assq_no_quit instead of Fassoc, for speed.
3529 (dir_monitor_callback, Fgfile_rm_watch):
3530 eassert that the monitor is a fixnum.
3531 (dir_monitor_callback): No need for CDR_SAFE.
3532 Simplify building of lisp with alternative tails.
3533 (Fgfile_add_watch, Fgfile_rm_watch):
3534 Do not assume glib functions set errno reliably on failure.
3535 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3536 and signal an error otherwise.
3537 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3538 Use Fdelq instead of Fdelete, for speed.
3539
817ebfcf
EZ
35402013-06-05 Eli Zaretskii <eliz@gnu.org>
3541
3542 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3543 don't insist on being invoked on a highlighted tool-bar button.
3544 Avoids losing tool-bar functionality when mouse-highlight is nil.
3545 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3546 Don't highlight when mouse-highlight is nil.
3547 (note_mouse_highlight): When mouse-highlight is nil, don't return
3548 right away; instead, run tool-bar and mode-line highlight
3549 subroutine, clear any existing highlight, and revert the mouse
3550 pointer to its default shape. (Bug#14558)
3551
55577e7c
SM
35522013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3553
3554 * lisp.mk (lisp): Add prog-mode.el.
3555
f019a684
PE
35562013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3559 * process.c (dummy_handler): New function.
3560 (lib_child_handler): New static var.
3561 (handle_child_signal): Invoke it.
3562 (catch_child_signal): If a library has set up a signal handler,
3563 save it into lib_child_handler.
3564 (init_process_emacs): If using glib and not on Windows, tickle glib's
3565 child-handling code so that it initializes its private SIGCHLD handler.
3566 * syssignal.h (SA_SIGINFO): Default to 0.
3567 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3568 31; it should no longer be needed now.
3569
90db8702
MA
35702013-06-05 Michael Albinus <michael.albinus@gmx.de>
3571
3572 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3573
3574 * gfilenotify.c (globals_of_gfilenotify): New function.
3575 (syms_of_gfilenotify): Move global initialization there.
3576
3577 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3578
bfa3acd6
SM
35792013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3580
3581 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3582 * keyboard.c (menu_bar_items, tool_bar_items):
3583 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3584 not override local keymaps any more.
3585
ba59bd80
EZ
35862013-06-04 Eli Zaretskii <eliz@gnu.org>
3587
3588 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3589
7f203aa1
EZ
35902013-06-03 Eli Zaretskii <eliz@gnu.org>
3591
9337e206
EZ
3592 * w32console.c (initialize_w32_display): Return the dimensions of
3593 the console window via 2 additional arguments, not via the current
3594 frame. This avoids crashes due to overrunning the bounds of
3595 frame's decode_mode_spec_buffer, which is not resized following
3596 the change of the frame dimensions from the initial 10x10.
3597
3598 * w32term.h (w32_initialize_display_info): Adjust prototype.
3599
3600 * term.c (init_tty): Take dimensions of the frame from the values
3601 returned by initialize_w32_display.
3602
7f203aa1
EZ
3603 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3604 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3605 (LIBES): Add $(GFILENOTIFY_LIBS).
3606
3607 * w32inevt.c (handle_file_notifications): Add dummy implementation
3608 for !HAVE_W32NOTIFY.
3609
3610 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3611
55a87246
JD
36122013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3613
3614 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3615
3616 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3617
3618 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3619
3d5ee10a
PE
36202013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 Fix minor problems found by static checking.
3623 * data.c (pure_write_error):
3624 Use xsignal2, not Fsignal, as Fsignal might return.
3625 * eval.c (set_backtrace_debug_on_exit): Now static.
3626 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3627 No longer inline. EXTERN_INLINE is needed only for functions
3628 defined in .h files. Reindent function header as per GNU style.
3629 (backtrace_p, backtrace_top, backtrace_next):
3630 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3631 compiler or linker. Add extern decls to pacify gcc -Wall.
3632 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3633 Now static.
3634 * frame.c (free_monitors): Define only on platforms that need it.
3635 * nsterm.m (ns_term_init):
3636 * process.c (catch_child_signal):
3637 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3638 defined on all porting targets these days.
3639 * process.c, process.h (catch_child_signal):
3640 Make it extern only if NS_IMPL_GNUSTEP is defined.
3641
e2d8a6f0
EZ
36422013-06-03 Eli Zaretskii <eliz@gnu.org>
3643
3644 * w32.c (gettimeofday): Make the signature identical to prototype
3645 in nt/inc/sys/time.h.
3646
a8a7c5f6
SM
36472013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3648
3649 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3650 .gdbinit.
3651
3652 * keyboard.c (safe_run_hooks_error): Improve error message.
3653
3654 * data.c (pure_write_error): Add `object' argument.
3655 * puresize.h (CHECK_IMPURE): Use it.
3656
c9628c79
MA
36572013-06-03 Michael Albinus <michael.albinus@gmx.de>
3658
3659 * Makefile.in (NOTIFY_OBJ): New variable.
3660 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3661
3662 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3663 Call syms_of_gfilenotify.
3664
3665 * gfilenotify.c: New file.
3666
3667 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3668 and Qfile_w32notify.
3669 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3670 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3671
3672 * lisp.h: Declare syms_of_gfilenotify.
3673
3674 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3675
2f592f95
SM
36762013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3677
3678 Merge the specpdl and backtrace stacks. Make the structure of the
3679 specpdl entries more obvious via a tagged union of structs.
3680 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3681 (enum specbind_tag): New enum.
3682 (struct specbinding): Make it a tagged union of structs.
3683 Add a case for backtrace records.
3684 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3685 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3686 (backtrace_debug_on_exit): New accessors.
3687 (struct backtrace): Remove.
3688 (struct catchtag): Remove backlist field.
3689 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3690 Move to eval.c.
3691 (Flocal_variable_p): Speed up the common case where the binding is
3692 already loaded.
3693 * eval.c (backtrace_list): Remove.
3694 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3695 (set_backtrace_args, set_backtrace_nargs)
3696 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3697 (backtrace_next): New functions.
3698 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3699 (unwind_to_catch, internal_lisp_condition_case)
3700 (internal_condition_case, internal_condition_case_1)
3701 (internal_condition_case_2, internal_condition_case_n): Don't bother
3702 with backtrace_list any more.
3703 (Fsignal): Adjust to new backtrace format.
3704 (grow_specpdl): Move up.
3705 (record_in_backtrace): New function.
3706 (eval_sub, Ffuncall): Use it.
3707 (apply_lambda): Adjust to new backtrace format.
3708 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3709 data.c.
3710 (specbind): Adjust to new specpdl format. Simplify.
3711 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3712 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3713 backtrace format.
3714 (mark_backtrace): Remove.
3715 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3716 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3717 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3718 Use mark_specpdl.
3719 * profiler.c (record_backtrace): Use get_backtrace.
3720 (handle_profiler_signal): Use backtrace_top_function.
3721 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3722 accessor functions.
3723
c0342369
JD
37242013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3725
3726 * process.h (catch_child_signal): Declare.
3727
3728 * process.c (catch_child_signal): New function.
3729 (init_process_emacs): Call it.
3730
3731 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3732 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3733 NS_IMPL_COCOA.
3734 (x_set_cursor_type): Remove declaration.
3735 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3736 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3737 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3738 (ns_get_color): Use F suffix on float.
3739 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3740 (ns_get_rgb_color): Remove.
3741 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3742 (note_mouse_movement): x and y are CGFloat.
3743 (ns_draw_fringe_bitmap): Remove unused rowY.
3744 Change #if to COCOA && >= 10_6.
3745 (ns_draw_window_cursor): Remove unused overspill.
3746 (ns_draw_underwave): width and x are EamcsCGFloat.
3747 (ns_draw_box): thickness is CGFloat.
3748 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3749 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3750 if not in main thread.
3751 (ns_get_pending_menu_title, ns_check_menu_open)
3752 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3753 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3754 (sendFromMainThread:): New method.
3755 (changeFont:): size is CGFloat.
3756 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3757 Disable warning about permanent text.
3758 (characterIndexForPoint:): Adjust return type depending on GNUStep
3759 version.
3760 (mouseDown:): delta is CGFloat.
3761 (updateFrameSize): Remove unised variable f.
3762 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3763 Cast float to EmacsCGFloat.
3764 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3765 also to -1 when restoring.
3766 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3767 inside NS_IMPL_COCOA.
3768 (toggleFullScreen:): Put call to toggleFullScreen inside
3769 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3770 (setPosition:portion:whole:): por is CGFloat.
3771 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3772 (mouseDown:): Use CGFloat.
3773 (mouseDragged:): Remove unised variable edge.
3774 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3775
3776 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3777 of CGFloat differs.
3778 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3779 when NS_IMPL_GNUSTEP.
3780 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3781 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3782 (EmacsToolbar): Add clearAll. Add tag argument to
3783 addDisplayItemWithImage.
3784 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3785
3786 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3787
3788 * nsmenu.m (ns_update_menubar): Make static.
3789 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3790 (fillWithWidgetValue:): Add cast to SEL for setAction.
3791 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3792 (update_frame_tool_bar): Update code for GNUStep.
3793 (clearAll): New method.
3794 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3795 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3796 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3797 call to insertItemWithItemIdentifier.
3798 (validateVisibleItems): Fix indentation.
3799 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3800 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3801 UtilityWindow to aStyle, remove call to setStyleMask.
3802
3803 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3804
3805 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3806 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3807 Use F suffix on floats.
3808 (ns_char_width): Returns CGFloat.
3809 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3810 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3811 DPSxshow.
3812 (ns_glyph_metrics): CGFloat instead of float.
3813
a0eb10b3
JB
3814 * nsfns.m (x_set_foreground_color, x_set_background_color):
3815 Use EmacsCGFloat.
3816 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3817 remove unused variables.
3818 (Fns_read_file_name): Keep track if panel is for save.
3819 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3820 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3821 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3822 Just return the input if GNUStep.
c0342369
JD
3823 (x_screen_planes): Remove.
3824 (Fxw_color_values): Use EmacsCGFloat
3825 (Fns_display_monitor_attributes_list): Only get screen number for
3826 Cocoa.
ef099a94 3827 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3828 EmacsSavePanel.
3829 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3830 ns_directory_from_panel.
3831
da9aff11
PE
38322013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3833
3834 * process.c (handle_child_signal): Also use WCONTINUED.
3835 This is so that list-processes doesn't mistakenly list the process
3836 as stopped, when the process has actually been continued and is
3837 now running.
3838
0e64479a
PE
38392013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3840
fc186a96
PE
3841 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3842 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3843 not already configured.
3844
0e64479a
PE
3845 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3846
38b787fa
EZ
38472013-05-29 Eli Zaretskii <eliz@gnu.org>
3848
3849 * Makefile.in (mostlyclean): Remove *.res files.
3850
22513e52
SM
38512013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3852
3853 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3854 a buffer (bug#8447).
3855
6ef3db10
EZ
38562013-05-27 Eli Zaretskii <eliz@gnu.org>
3857
3858 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3859 display vector, and we backtrack, handle the case that the
3860 previous character position is also displayed from a display
3861 vector or covered by a display string or image. (Bug#14476)
3862
6799bb26
JD
38632013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3864
3865 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3866 (struct MonitorInfo, free_monitors): Remove.
3867 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3868 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3869 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3870 Qframes, Qsource.
3871
3872 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3873 (struct MonitorInfo, free_monitors): Remove.
3874 (ns_screen_name): Make static.
3875 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3876 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3877 Qframes, Qsource.
3878
3879 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3880 (struct MonitorInfo): New struct.
3881 (free_monitors, make_monitor_attribute_list): Declare.
3882
22513e52
SM
3883 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3884 New Lisp_Object:s.
6799bb26
JD
3885 (free_monitors, make_monitor_attribute_list): New functions.
3886 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3887 Qsource.
3888
38cd43eb
XF
38892013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3890
3891 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3892
2af0948d
SM
38932013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3894
a7eb9b0f
SM
3895 * keyboard.c: Apply keyboard decoding only to events that come directly
3896 from the tty, not from unread-command-events (bug#14368).
3897 (read_event_from_main_queue): New function, extracted from read_char).
3898 (read_decoded_char): Remove.
3899 (read_decoded_event_from_main_queue): New function to replace it.
3900 (read_char): Use it.
3901 (read_key_sequence): Use read_char rather than read_decoded_char.
3902
2af0948d
SM
3903 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3904
1413e9a5
BR
39052013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3906
3907 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3908
e6d2f155
KH
39092013-05-22 Kenichi Handa <handa@gnu.org>
3910
3911 The following changes are to fix the setting of
3912 buffer-file-coding-system on, for instance, C-x RET c unix RET
3913 _FILE_OF_DOS_EOL_TYPE_ RET.
3914
3915 * coding.h (struct coding_system): New member detected_utf8_chars.
3916
3917 * coding.c (detect_coding_utf_8): Count characters and check EOL
3918 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3919 BOM is there.
3920 (setup_coding_system): Do not initialize coding->head_ascii.
3921 (check_ascii): Do not set coding->eol_seen but update it. Do not
3922 call adjust_coding_eol_type here.
1413e9a5
BR
3923 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3924 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3925 of the found coding-system.
3926 (decode_coding_gap): Cancel previous change. Utilize the
3927 character numbers counted by detect_coding_utf_8. Fix detection
3928 of BOM for utf-8.
3929
ab56a6f4 39302013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3931
3932 * search.c (looking_at_1): Only set last_thing_searched if the match
3933 changed the match-data (bug#14281).
3934
ecc3c6ed
DA
39352013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3936
3937 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3938 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3939 (move_it_vertically_backward): Likewise.
3940
5ba8bf35
YM
39412013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3942
3943 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3944 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3945 (Fx_display_mm_width, Fx_display_mm_height):
3946 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3947
91e8418b 3948 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3949 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3950 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3951 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3952 (Fx_display_backing_store, Fx_display_visual_class)
3953 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3954 (Fx_display_grayscale_p, Fx_display_pixel_width)
3955 (Fx_display_pixel_height, Fx_display_planes)
3956 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3957 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3958 (Fx_display_mm_width, Fx_display_mm_height)
3959 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3960 height for all physical monitors as in X11.
3961
fc30d803
SM
3962 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3963 Return pixel width or height for all physical monitors as in X11.
91e8418b 3964
31ff141c
PE
39652013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3966
3967 Port --enable-gcc-warnings to clang.
3968 * bytecode.c (exec_byte_code):
3969 * regex.c:
3970 Redo diagnostic pragmas to pacify clang, too.
3971 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3972 * editfns.c (Fencode_time):
3973 * fileio.c (file_accessible_directory_p):
3974 * font.c (font_unparse_xlfd):
3975 Use '&"string"[index]' instead of '"string" + (index)'.
3976 * undo.c (user_error): Remove; unused.
3977
df065a0b
EZ
39782013-05-16 Eli Zaretskii <eliz@gnu.org>
3979
04d360e7
EZ
3980 * insdel.c (insert_1_both): Document the arguments, instead of
3981 referring to insert_1, which no longer exists.
3982
5bb98290
EZ
3983 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3984 some window, increment windows_or_buffers_changed, so that
3985 *Messages* display in that window is updated. (Bug#14408)
3986
df065a0b
EZ
3987 * w32.c: Include epaths.h.
3988 (init_environment): Use cmdproxy.exe without leading directories.
3989 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3990 case.
3991 (gettimeofday): Adjust signature and return value to Posix
3992 expectations.
3993
3994 * unexw32.c (open_output_file): Delete the existing emacs.exe
3995 before creating it, to break the hard link to the versioned
3996 executable.
3997
3998 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3999 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4000 (FIRSTFILE_OBJ): New variables.
4001 (W32_RES): Rename to EMACSRES. All users changed.
4002 (base_obj): Use $(CM_OBJ).
4003 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4004 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4005 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4006 $(W32_RES_LINK) before $(LIBES).
4007 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4008
1aa8d505
SM
40092013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4010
6e911150
SM
4011 * makefile.w32-in (DOC): Use just "DOC".
4012
4013 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4014
1aa8d505
SM
4015 * process.c: Export default filters and sentinels to Elisp.
4016 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4017 New constants.
4018 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4019 (Fset_process_sentinel, Fformat_network_address):
4020 Default to them instead of nil.
4021 (server_accept_connection): Sentinels can't be nil any more.
4022 (read_and_dispose_of_process_output): New function, extracted from
4023 read_process_output.
4024 (read_process_output): Use it; filters can't be nil.
4025 (Finternal_default_process_filter): New function, extracted from
4026 read_process_output.
4027 (exec_sentinel_unwind): Remove function.
4028 (exec_sentinel): Don't zilch sentinel while running.
4029 (status_notify): Sentinels can't be nil.
4030 (Finternal_default_process_sentinel): New function extracted from
4031 status_notify.
4032 (setup_process_coding_systems): Default filter is not nil any more.
4033 (syms_of_process): Export new Elisp functions and initialize
4034 new constants.
4035 * lisp.h (make_lisp_proc): New function.
4036
5ac2eb34
SM
40372013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4038
4039 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4040
eda9c7d7
EZ
40412013-05-14 Eli Zaretskii <eliz@gnu.org>
4042
4043 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4044 unless we know that the window w is a leaf window.
4045 Another attempt at solving bug#14062.
eda9c7d7 4046
8fdeaad5
JD
40472013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4048
4049 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4050 fdesc (Bug#14375).
4051
44aa9ee6
PE
40522013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4053
4054 * image.c (gif_load): Check that subimages fit (Bug#14345).
4055
759fd763
SM
40562013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4057
4058 * lread.c (skip_dyn_eof): New function.
4059 (read1): Use it to skip the end of a file in response to #@00.
4060
4061 * doc.c (get_doc_string): Slightly relax the sanity checking.
4062
4465bfb4
JD
40632013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4064
4065 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4066 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4067 (MonitorInfo): New struct.
4068 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4069 (Fns_display_monitor_attributes_list): New functions.
4070 (display-usable-bounds): Remove.
4071 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4072 Qsource.
4073
7583e2a0
PE
40742013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4075
4076 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4077 (GTK_CHECK_VERSION): New macro, if not already defined.
4078 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4079 replaced by GTK_CHECK_VERSION.
4080
ad75d77e
PE
40812013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4082
4083 * xterm.h (GTK_PREREQ): New macro.
4084 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4085 to use this macro instead, for consistency and clarity.
4086
07525f77
EZ
40872013-05-08 Eli Zaretskii <eliz@gnu.org>
4088
4089 * xdisp.c (row_for_charpos_p): New function, with code of
4090 cursor_row_p, but accepts an additional argument CHARPOS instead
4091 of using a hardcoded PT.
4092 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4093 (row_containing_pos): Call row_for_charpos_p instead of partially
4094 doing the same. Fixes cursor positioning under longlines-mode
4095 when longlines-show-effect includes more than one newline, when
4096 moving the cursor vertically up.
4097
d901fc8d
JB
40982013-05-08 Juanma Barranquero <lekktu@gmail.com>
4099
4100 * makefile.w32-in (ACL_H): New macro.
4101 ($(BLD)/fileio.$(O)): Update dependencies.
4102
f269bc61
PE
41032013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4104
e7b41c4c 4105 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4106 * Makefile.in (LIB_ACL): New macro.
4107 (LIBACL_LIBS): Remove.
4108 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4109 * fileio.c: Include <acl.h>.
4110 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4111 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4112 !acl_errno_valid.
4113 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4114 it ourselves.
4115
f269bc61
PE
4116 * unexelf.c: Don't assume ElfW (Half) fits in int.
4117 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4118 when dealing with ElfW (Half) values, since they can exceed 2**31
4119 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4120 (entry_address): Omit unused NUM arg. All uses changed.
4121
a261c53e
JL
41222013-05-07 Juri Linkov <juri@jurta.org>
4123
4124 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4125 to the string converted from number with `Fnumber_to_string'.
4126 (Bug#14254)
4127
2b66427d
PE
41282013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4131 This fixes a problem introduced by my previous change.
4132
15acfe41
GM
41332013-05-07 Glenn Morris <rgm@gnu.org>
4134
4135 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4136
5ea03bf5
JD
41372013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4138
4139 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4140
e0c9d565
PE
41412013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4142
4143 Static checking by GCC 4.8.0.
4144 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4145 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4146 (x_get_monitor_attributes_fallback)
4147 (x_get_monitor_attributes_xinerama)
4148 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4149 Define only if USE_GTK.
4150 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4151 (x_get_monitor_attributes_fallback): Omit unused locals.
4152 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4153 Use double, not float, to avoid mixed-mode floating point arithmetic.
4154
4e3f9230
YM
41552013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4156 Jan Djärv <jan.h.d@swipnet.se>
4157
4158 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4159 (XINERAMA_CFLAGS): New macros.
4160 (ALL_CFLAGS, LIBES): Use them.
4161
4162 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4163 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4164 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4165 (syms_of_xfns): DEFSYM them.
4166 (struct MonitorInfo): New struct.
4167 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4168 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4169 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4170 (x_get_monitor_attributes_xinerama): New functions.
4171 (Fx_display_monitor_attributes_list): New primitive.
4172 (syms_of_xfns): Defsubr it.
4173
4174 * xterm.h (x_display_info): Add Xatom_net_workarea and
4175 Xatom_net_current_desktop.
4176
4177 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4178 and dpyinfo->Xatom_net_current_desktop.
4179
05839b6a
EZ
41802013-05-06 Eli Zaretskii <eliz@gnu.org>
4181
4182 * xdisp.c (pos_visible_p): Use the special code for finding the
4183 beginning of a display property or overlay for any "replacing"
4184 display property, not just for display strings. This solves
4185 incorrect reporting of position by posn-at-point. (Bug#14241)
4186
dc4a2ee0
PE
41872013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4188
5ee94506
PE
4189 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4190 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4191 Verify that ElfW (Half) fits in int.
4192 (fatal): Use same signature as lisp.h.
4193 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4194 configure and build with -DUNEXELF_DEBUG without worrying about
4195 other modules that use DEBUG.
4196 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4197 possibly-wide integers now uses it instead of plain fprintf.
4198 (entry_address): New function, which avoids problems with 32-bit
4199 overflow on 64-bit hosts.
4200 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4201 (round_up): Don't assume the remainder fits in int.
4202 (find_section): Use bool for boolean. Simplify debug code.
4203 (unexec): Don't assume file sizes fit in int or size_t.
4204 Omit unnecessary trailing newline in 'fatal' format.
4205 Use strerror rather than outputting decimal error number.
4206 Remove unused code when emacs is not defined;
4207 this file relies on Emacs now.
4208 Don't assume e_phnum and e_shnum are positive.
4209
dc4a2ee0
PE
4210 * regex.c: Fix problems when DEBUG is defined.
4211 (extract_number, extract_number_and_incr): Define regardless of
4212 whether DEBUG is defined; that's simpler and makes the code less
4213 likely to go stale in the normal case when DEBUG is not defined.
4214 Return int rather than taking an int * arg. All callers changed.
4215 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4216 Remove, replacing with ...
4217 (DEBUG_PRINT): New macro. All callers changed.
4218 (DEBUG_COMPILES_ARGUMENTS): New macro.
4219 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4220 (print_compiled_pattern, print_double_string) [DEBUG]:
4221 Use prototype rather than old-style definition.
4222 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4223 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4224 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4225 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4226 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4227 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4228 This matters only when DEBUG is defined.
4229
14c7ed05
EZ
42302013-05-05 Eli Zaretskii <eliz@gnu.org>
4231
4232 * xdisp.c (set_iterator_to_next): Set the
4233 ignore_overlay_strings_at_pos_p flag only if we are _really_
4234 iterating over an overlay string, as indicated by the
4235 current.overlay_string_index member. (Bug#14306)
4236
e6076b1b
JD
42372013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4238
4239 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4240 to where it is used, to avoid autorelease issues (Bug#14050).
4241
cbee2131
PE
42422013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4243
4244 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4245 * fileio.c (syms_of_fileio): Implement this.
4246 * filelock.c (create_lock_file): If symbolic links don't work, so
4247 we use a regular file as a lock file, do not fsync the lock file;
4248 it's not needed.
4249
30c7e542
SM
42502013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4251
4252 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4253 (syms_of_minibuf): Adjust accodingly.
4254 * lread.c (Fread):
4255 * callint.c (Fcall_interactively): Adjust calls accordingly.
4256
5bebd186
EZ
42572013-05-04 Eli Zaretskii <eliz@gnu.org>
4258
4259 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4260 w->contents is a buffer before computing everything else.
4261 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4262
4263 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4264 assertion violations. (Bug#14062)
4265
0fb0a4f3
DR
42662013-05-01 David Reitter <david.reitter@gmail.com>
4267
4268 * nsfns.m (ns_tooltip): Initialize.
4269
9e63b4a5
EZ
42702013-04-28 Eli Zaretskii <eliz@gnu.org>
4271
4272 * coding.c (decode_coding_gap): Don't remove the character before
4273 a newline unless it's a CR character. (Bug#14287)
4274
ad60824e
DN
42752013-04-28 Dan Nicolaescu <dann@gnu.org>
4276
4277 * dispextern.h (struct face): Move enum face_underline_type
4278 earlier so that bitfields can be in the same word.
4279
edbdcec0
JD
42802013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4281
4282 * nsfns.m (handlePanelKeys): New function.
4283 (EmacsOpenPanel:performKeyEquivalent:)
4284 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4285 arrows/function/control and copy/paste keys (Bug#14296).
4286
0208ede7
JL
42872013-04-27 Juri Linkov <juri@jurta.org>
4288
4289 * callint.c (Fcall_interactively): Call `Qread_number' for
4290 interactive code letter `n' instead of using duplicate code.
4291 (Bug#14254)
4292
b8dd59f7
PE
42932013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 * systime.h (make_timeval): Declare as 'const'.
4296
8bd722db
KH
42972013-04-27 Kenichi Handa <handa@gnu.org>
4298
4299 * font.c (font_open_entity): Always open a font of manageable
4300 size.
4301
13d0e56f 43022013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4303
f780d632
PE
4304 Port better to AIX (Bug#14258).
4305 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4306 to pacify AIX xlc.
4307
ec509856
KH
43082013-04-24 Kenichi Handa <handa@gnu.org>
4309
4310 * coding.c (decode_coding_iso_2022): When an invalid escape
4311 sequence is encountered, reset the invocation and designation
4312 status to the safest one.
4313
84fc48e5
PE
43142013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4315
4316 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4317 Without this fix, "make distclean" leaves stamp-h1 behind.
4318
806bda47
EC
43192013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4320
4321 * w32fns.c (w32_fullscreen_rect): New function to compute the
4322 window rectangle for the given fullscreen mode.
4323 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4324 longer tunes the window size. This keeps the window's edges flush
4325 with the screen and allows the taskbar to hide itself in fullboth.
4326
4327 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4328 window decorations and uses the entire screen.
4329
4330 * w32term.h (w32_fullscreen_rect) Add prototype.
4331 (struct w32_output): Replace normal_width, normal_height,
4332 normal_top, and normal_left members with a single normal_placement
4333 struct.
4334 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4335 Remove macros.
4336 (FRAME_NORMAL_PLACEMENT): New macro.
4337
9cc2810b
JB
43382013-04-16 Juanma Barranquero <lekktu@gmail.com>
4339
4340 * minibuf.c (Ftest_completion): Silence compiler warning.
4341
fd16b54c
EZ
43422013-04-15 Eli Zaretskii <eliz@gnu.org>
4343
4344 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4345 bug#14062.
fd16b54c
EZ
4346
4347 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4348 parentheses.
4349
4350 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4351 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4352 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4353 parentheses where appropriate.
4354
9e3379a0
PE
43552013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4356
4357 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4358
ddd6b685
EZ
43592013-04-14 Eli Zaretskii <eliz@gnu.org>
4360
4361 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4362 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4363 Mention in the doc string that setting these variables takes
4364 effect only after a call to set-window-buffer. (Bug#14200)
4365
29b79ba1
EZ
43662013-04-13 Eli Zaretskii <eliz@gnu.org>
4367
4368 * indent.c (Fvertical_motion): Don't consider display strings on
4369 overlay strings as display strings on the buffer position we
4370 started from. This prevents vertical cursor motion from jumping
4371 more than one line when there's an overlay string with a display
4372 property at end of line.
4373 Reported by Karl Chen <Karl.Chen@quarl.org> in
4374 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4375
562c6ee9
SM
43762013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4377
4378 * window.c (select_window): `record_buffer' even if window is
4379 already selected (bug#14191).
4380
fcc1fe85
EZ
43812013-04-11 Eli Zaretskii <eliz@gnu.org>
4382
4383 * window.c (Fwindow_end): Test more flags, including the buffer's
4384 last_overlay_modified flag, to determine whether the window's
4385 display is really up-to-date. Prevents the function from
4386 returning a stale value. (Bug#14170)
4387 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4388 current matrix.
4389
f009190a
EZ
43902013-04-10 Eli Zaretskii <eliz@gnu.org>
4391
4392 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4393 garbaged only if it is not already the top frame on its TTY.
4394 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4395 there are GUI frames open in the same session. (Bug#13864)
4396
78ce603d
SM
43972013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4398
4399 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4400 of marking the idle timers directly.
4401
a8036e40
SM
44022013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4403
4404 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4405 tables (bug#14054).
4406
7ffe7ef6
SM
44072013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4408
4409 * window.c (select_window): Don't record_buffer while the invariant is
4410 temporarily broken (bug#14161).
4411
4412 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4413
7d9f6883
EZ
44142013-04-07 Eli Zaretskii <eliz@gnu.org>
4415
4416 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4417
5406cfd9
RF
44182013-04-07 Romain Francoise <romain@orebokech.com>
4419
4420 Ignore additional platform-specific ACL errors (Bug#13702).
4421 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4422 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4423
95c0e83b
JD
44242013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4425
4426 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4427 f->output_data.ns.
4428
876da980
PE
44292013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4430
4431 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4432 This bug was introduced by my 2013-02-25 change that simplified
4433 data_start configuration. Without this change, on GNU/Linux
4434 an Emacs configured with --enable-profiling fails immediately
4435 due to a profiler signal.
4436 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4437 with these flags. On platforms where special flags are needed
4438 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4439 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4440 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4441
7452b7bd
DA
44422013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4443
4444 Get rid of some platform-specific functions examining window
4445 system and its capabilities. This is a partial rework of the
4446 2013-04-05 change.
4447 * lisp.h (have_menus_p): Remove prototype. This function is
4448 replaced with platform-independent window_system_available.
4449 (check_window_system): Move to...
4450 * frame.h (decode_window_system_frame, window_system_available):
4451 ...here, add new prototypes.
4452 * frame.c (window_system_available, decode_window_system_frame):
4453 New functions.
4454 (check_window_system): Platform-independent now.
4455 * xterm.h (x_in_use): Remove declaration.
4456 (check_x_frame):
4457 * w32term.h (check_x_frame):
4458 * nsterm.h (check_x_frame): Remove prototypes. This function
4459 is replaced with platform-independent decode_window_system_frame.
4460 * msdos.c (have_menus_p): Remove.
4461 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4462 Remove platform-specific functions. Use check_window_system,
4463 decode_window_system_frame and check_ns_display_info where
4464 appropriate. Minor style and comment tweaks.
4465 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4466 (check_x_frame): Likewise.
4467 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4468 Likewise.
4469 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4470 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4471 * xmenu.c, xselect.c: All related users changed.
4472
251e9147
KH
44732013-04-03 Kenichi Handa <handa@gnu.org>
4474
4475 The following changes is to optimize the code for reading UTF-8
4476 files.
4477
562c6ee9 4478 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4479 changed. Check EOL format. Do not call adjust_coding_eol_type
4480 here.
4481 (check_utf_8): New function.
4482 (adjust_coding_eol_type): Do nothing if already adjusted.
4483 (detect_coding): Compare the return value of check_ascii with
4484 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4485 (decode_coding_gap): Optimize for valid UTF-8.
4486
8bc369d4
KH
44872013-03-21 Kenichi Handa <handa@gnu.org>
4488
4489 * coding.c (syms_of_coding): Cancel previous change.
4490
4491 * insdel.c (insert_from_gap): Fix previous change.
4492
73931ad1
DA
44932013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4494
4495 Consistently use platform-specific function to detect window system.
4496 * lisp.h (check_window_system): New prototype. This function is
4497 going to replace check_x, check_w32 and check_ns.
4498 (have_menus_p): Mention msdos.c in comment.
4499 * fontset.c (check_window_system_func): Remove. Adjust all users.
4500 * fontset.h (check_window_system_func): Remove prototype.
4501 * nsterm.h (check_ns):
4502 * xterm.h (check_x):
4503 * w32term.h (check_w32): Likewise.
4504 * menu.c (Fx_popup_menu): Use check_window_system.
4505 * msdos.c (check_window_system): Define for MS-DOS.
4506 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4507 * w32fns.c (check_window_system): Likewise for MS-Windows.
4508 * xfns.c (check_window_system): Likewise for X.
4509 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4510 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4511
7216e43b
PE
45122013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 Prefer < to > in range checks such as 0 <= i && i < N.
4515 This makes it easier to visualize quantities on a number line.
4516 This patch doesn't apply to all such range checks,
4517 only to the range checks affected by the 2013-03-24 change.
4518 This patch reverts most of the 2013-03-24 change.
4519 * alloc.c (xpalloc, Fgarbage_collect):
4520 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4521 * character.c (string_escape_byte8):
4522 * charset.c (read_hex):
4523 * data.c (cons_to_unsigned):
4524 * dispnew.c (update_frame_1):
4525 * doc.c (Fsubstitute_command_keys):
4526 * doprnt.c (doprnt):
4527 * editfns.c (hi_time, decode_time_components):
4528 * fileio.c (file_offset):
4529 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4530 * font.c (font_intern_prop):
4531 * frame.c (x_set_alpha):
4532 * gtkutil.c (get_utf8_string):
4533 * indent.c (check_display_width):
4534 * keymap.c (Fkey_description):
4535 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4536 * lread.c (read1):
4537 * minibuf.c (read_minibuf_noninteractive):
4538 * process.c (wait_reading_process_output):
4539 * search.c (Freplace_match):
4540 * window.c (get_phys_cursor_glyph):
4541 * xdisp.c (redisplay_internal):
4542 * xsmfns.c (smc_save_yourself_CB):
4543 Prefer < to > for range checks.
4544 * dispnew.c (sit_for): Don't mishandle NaNs.
4545 This fixes a bug introduced in the 2013-03-24 change.
4546 * editfns.c (decode_time_components): Don't hoist comparison.
4547 This fixes another bug introduced in the 2013-03-24 change.
4548
92759988
DA
45492013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4550
4551 * frame.h (struct frame): Drop scroll_bottom_vpos
4552 member becaue all real users are dead long ago.
4553 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4554 * xdisp.c (redisplay_internal): Adjust user.
4555
9a1971bb
GM
45562013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4557
f38ab167
JD
4558 * nsmenu.m (showAtX:Y:for:): setLevel to
4559 NSPopUpMenuWindowLevel (Bug#13998).
4560
6d01f1fe
JD
45612013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4562
4563 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4564 (ns_check_pending_open_menu): Declare.
4565
4566 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4567 (x_activate_menubar): Update the menu with title that matches
4568 ns_get_pending_menu_title, and call
4569 ns_check_pending_openmenu (Bug#12698).
4570 (menuWillOpen:): New method.
4571 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4572
4573 * nsterm.m (menu_will_open_state, menu_mouse_point)
4574 (menu_pending_title): New varaibles.
4575 (ns_get_pending_menu_title, ns_check_menu_open)
4576 (ns_check_pending_open_menu): New functions.
4577
781f4782
DA
45782013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4579
4580 * indent.c (current_column_bol_cache): Remove leftover which is not
4581 used in Fmove_to_column any more.
4582 (current_column, scan_for_column): Adjust users.
4583 * keyboard.c (last_point_position_buffer, last_point_position_window):
4584 Remove leftovers which are not used for recording undo any more.
4585 (command_loop_1, syms_of_keyboard): Adjust users.
4586 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4587 redisplay_window any more.
4588 (move_it_to): Adjust user.
4589
1921c31b
JB
45902013-03-29 Juanma Barranquero <lekktu@gmail.com>
4591
4592 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4593 Update dependencies.
4594
717b8bcd
SM
45952013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4596
4597 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4598 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4599 forward references.
4600
e74aeda8
DA
46012013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4602
4603 * window.h (struct window): Replace hchild, vchild and buffer slots
4604 with the only contents slot. This is possible because each valid
4605 window may have either the child window (in vertical or horizontal
4606 combination) or buffer to display (for the leaf window). Using that,
4607 a lof of operations to traverse and/or change window hierarchies may
4608 be simplified. New member horizontal is used to distinguish between
4609 horizontal and vertical combinations of internal windows.
4610 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4611 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4612 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4613 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4614 Use contents slot, not buffer, where appropriate.
4615 (wset_combination): New function.
4616 (wset_buffer): Add eassert.
4617 (Fframe_first_window): Simplify the loop reaching first window.
4618 (Fwindow_buffer): Use WINDOW_LEAF_P.
4619 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4620 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4621 (unshow_buffer): Convert initial debugging check to eassert.
4622 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4623 (make_parent_window, window_resize_check, window_resize_apply)
4624 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4625 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4626 Adjust to match struct window changes.
4627 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4628 (mark_window_cursors_off, count_windows, get_leaf_windows)
4629 (foreach_window_1): Simplify the loop.
4630 * alloc.c (mark_object): Do not check for the leaf window because
4631 internal windows has no glyph matrices anyway.
4632 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4633 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4634 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4635 (build_frame_matrix_from_window_tree, mirror_make_current)
4636 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4637 (update_window_tree, set_window_update_flags): Simplify the loop.
4638 (sync_window_with_frame_matrix_rows): Enforce live window.
4639 Use contents slot, not buffer, where appropriate.
4640 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4641 and WINDOW_HORIZONTAL_COMBINATION_P.
4642 (make_frame_visible_1): Simplify the loop.
4643 Use contents slot, not buffer, where appropriate.
4644 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4645 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4646 (expose_window_tree): Likewise.
4647 Use contents slot, not buffer, where appropriate.
4648 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4649 to avoid deleted windows. Use contents slot instead of buffer.
4650 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4651 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4652 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4653 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4654
121ab1cd
EZ
46552013-03-28 Eli Zaretskii <eliz@gnu.org>
4656
ef454cf7
EZ
4657 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4658 identify the reasons for assertion violations in bug#14062 and
4659 similar ones.
21e930f8
EZ
4660 (Fx_show_tip): Fix compilation error under
4661 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4662
121ab1cd
EZ
4663 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4664 Reported by <rzl24ozi@gmail.com>.
4665
5c89ca24
DA
46662013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4667
4668 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4669 start marker...
562c6ee9
SM
4670 (unwind_with_echo_area_buffer): ...to restore it here.
4671 This is needed to ensure that...
5c89ca24
DA
4672 (redisplay_window): ...both window markers are valid here,
4673 which is verified by eassert.
4674 * editfns.c (save_excursion_save): Do not assume that
4675 selected_window always displays the buffer.
c7f53895
DA
4676 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4677 Fix comment.
5c89ca24 4678
f557c1b1
SM
46792013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4680
4681 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4682 the upcase table.
4683
40693bba 46842013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4685
4686 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4687
c86f791f
EZ
46882013-03-27 Eli Zaretskii <eliz@gnu.org>
4689
4690 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4691 since MinGW's w32api headers do. This avoids compiler warnings.
4692
4693 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4694 if already defined.
4695
c6e72e17
EZ
46962013-03-26 Eli Zaretskii <eliz@gnu.org>
4697
4698 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4699
54e95010
JD
47002013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4701
4702 * gtkutil.c (style_changed_cb): Check if frame is live and an
4703 X frame (Bug#14038).
4704
b88b62de
EZ
47052013-03-26 Eli Zaretskii <eliz@gnu.org>
4706
a18d7de6
EZ
4707 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4708 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4709 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4710 MinGW64.
8f5e14c8
EZ
4711 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4712 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4713
b88b62de
EZ
4714 Fix incompatibilities between MinGW.org and MinGW64 headers.
4715 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4716
4717 * w32.c (REPARSE_DATA_BUFFER): Guard with
4718 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4719
c074e458
JD
47202013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4721
4722 * xterm.c: Include X11/XKBlib.h
4723 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4724
908589fd
AS
47252013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4726
4727 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4728 written backwards.
4729 * blockinput.h (input_blocked_p): Likewise.
4730 * bytecode.c (exec_byte_code): Likewise.
4731 * callproc.c (call_process_kill, call_process_cleanup)
4732 (Fcall_process): Likewise.
4733 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4734 (Fccl_execute_on_string): Likewise.
4735 * character.c (string_escape_byte8): Likewise.
4736 * charset.c (read_hex): Likewise.
4737 * cm.c (calccost): Likewise.
4738 * data.c (cons_to_unsigned): Likewise.
4739 * dired.c (directory_files_internal, file_name_completion):
4740 Likewise.
4741 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4742 (sit_for): Likewise.
4743 * doc.c (Fsubstitute_command_keys): Likewise.
4744 * doprnt.c (doprnt): Likewise.
4745 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4746 * emacsgtkfixed.c: Likewise.
4747 * fileio.c (file_offset, Fwrite_region): Likewise.
4748 * floatfns.c (Fexpt, fmod_float): Likewise.
4749 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4750 Likewise.
4751 * font.c (font_intern_prop): Likewise.
4752 * frame.c (x_set_alpha): Likewise.
4753 * gtkutil.c (get_utf8_string): Likewise.
4754 * indent.c (check_display_width): Likewise.
4755 * intervals.c (create_root_interval, rotate_right, rotate_left)
4756 (split_interval_right, split_interval_left)
4757 (adjust_intervals_for_insertion, delete_node)
4758 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4759 (merge_interval_right, merge_interval_left, copy_intervals)
4760 (set_intervals_multibyte_1): Likewise.
4761 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4762 * keymap.c (Fkey_description): Likewise.
4763 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4764 * lread.c (openp, read_integer, read1, string_to_number):
4765 Likewise.
4766 * menu.c (ensure_menu_items): Likewise.
4767 * minibuf.c (read_minibuf_noninteractive): Likewise.
4768 * print.c (printchar, strout): Likewise.
4769 * process.c (create_process, Faccept_process_output)
4770 (wait_reading_process_output, read_process_output, send_process)
4771 (wait_reading_process_output): Likewise.
4772 * profiler.c (make_log, handle_profiler_signal): Likewise.
4773 * regex.c (re_exec): Likewise.
4774 * regex.h: Likewise.
4775 * search.c (looking_at_1, Freplace_match): Likewise.
4776 * sysdep.c (get_child_status, procfs_ttyname)
4777 (procfs_get_total_memory): Likewise.
4778 * systime.h (EMACS_TIME_VALID_P): Likewise.
4779 * term.c (dissociate_if_controlling_tty): Likewise.
4780 * window.c (get_phys_cursor_glyph): Likewise.
4781 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4782 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4783 Likewise.
4784 * xfns.c (Fx_window_property): Likewise.
4785 * xmenu.c (set_frame_menubar): Likewise.
4786 * xselect.c (x_get_window_property, x_handle_dnd_message):
4787 Likewise.
4788 * xsmfns.c (smc_save_yourself_CB): Likewise.
4789 * xterm.c (x_scroll_bar_set_handle): Likewise.
4790
2bf7d27a
DA
47912013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4792
4793 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4794 to be optional or nil. Adjust comment and convert it to docstring.
4795 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4796 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4797
a9ebfa0b
PE
47982013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4799
4800 Static checking by GCC 4.8-20130319.
4801 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4802 * process.c (Fset_process_datagram_address)
4803 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4804 * xdisp.c (get_char_face_and_encoding):
4805 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4806 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4807 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4808
4f3576ee
KB
48092013-03-24 Ken Brown <kbrown@cornell.edu>
4810
789b5e9a
KB
4811 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4812 fix compilation on 64-bit Cygwin, where underscores are not
4813 automatically prepended.
4814
4f3576ee
KB
4815 * w32term.c (w32_initialize): Silence compiler warning.
4816
b5b7745f
EZ
48172013-03-23 Eli Zaretskii <eliz@gnu.org>
4818
cdc0d0bd
EZ
4819 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4820 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4821 variables, to save and restore frame dimensions.
4822 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4823 after returning from a 'fullscreen' configuration.
4824 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4825 to avoid races between the main thread and the input thread.
4826
4827 * w32term.h (struct w32_output): New members normal_width,
4828 normal_height, normal_top, normal_left, and prev_fsmode.
4829 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4830 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4831 members of a frame.
4832
b5b7745f
EZ
4833 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4834 'fullscreen' parameter. Always record previous width and height
4835 of the frame, except when switching out of maximized modes, so
4836 that they could be restored correctly, instead of resetting to the
4837 default frame dimensions. Send SC_RESTORE command to the frame,
4838 unless we are going to send SC_MAXIMIZE, to restore the frame
4839 resize hints in the mouse pointer shown by the window manager.
4840 (Bug#14032)
4841
4842 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4843
4844 * lisp.h (get_frame_param): Adjust conditions for prototype
4845 declaration.
4846
a3454eed
KB
48472013-03-22 Ken Brown <kbrown@cornell.edu>
4848
4849 * unexcw.c: Drop unneeded inclusion of w32common.h.
4850 (report_sheap_usage): Declare.
4851 (read_exe_header): Add magic numbers for x86_64.
4852 (fixup_executable): Fix printf format specifier for unsigned long
4853 argument.
4854
5a49b79c
DA
48552013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4856
4857 * frame.h (struct frame): Put menu_bar_window under #ifdef
4858 because this member is not needed when X toolkit is in use.
4859 (fset_menu_bar_window):
4860 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4861 (free_glyphs, update_frame):
4862 * xdisp.c (expose_frame): Likewise.
4863 (display_menu_bar): Likewise. Remove redundant eassert.
4864 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4865 toolkit is in use.
4866
d6723bf7
PE
48672013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4868
7b1123d8
PE
4869 Use functions and constants to manipulate Lisp_Save_Value objects.
4870 This replaces code that used macros and strings and token-pasting.
4871 The change makes the C source a bit easier to follow,
4872 and shrinks the Emacs executable a bit.
4873 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4874 (make_save_value): Change 1st arg from string to enum. All callers
4875 changed.
4876 (INTX): Remove.
4877 (mark_object): Use if, not #if, for GC_MARK_STACK.
4878 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4879 (XSAVE_OBJECT): Now functions, not macros.
4880 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4881 the constant was never used.
4882 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4883 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4884 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4885 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4886 New constants.
4887 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4888 type3 with a single member save_type. All uses changed.
4889 (save_type, set_save_pointer, set_save_integer): New functions.
4890 * print.c (PRINTX): Remove.
4891
d6723bf7
PE
4892 * alloc.c: Remove redundant static declarations.
4893
5f24fa51
DA
48942013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4895
4896 * window.h (struct window): Convert left_col, top_line, total_lines
4897 and total_cols from Lisp_Objects to integers. Adjust comments.
4898 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4899 Remove.
4900 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4901 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4902 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4903 Adjust users where appropriate.
4904
42143acd
DA
49052013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4906
4907 * frame.h (struct frame): Drop resx and resy because the same data is
4908 available from window system-specific output context. Adjust users.
562c6ee9
SM
4909 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4910 New functions to provide defaults when no window system available.
42143acd 4911 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4912 (NUMVAL): Move from xdisp.c.
42143acd
DA
4913 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4914 (Ffont_face_attributes, Fopen_font):
4915 * image.c (gs_load):
4916 * w32font.c (fill_in_logfont):
4917 * xdisp.c (calc_pixel_width_or_height):
4918 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4919 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4920
c0a17406
KH
49212013-03-20 Kenichi Handa <handa@gnu.org>
4922
4923 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4924 to 1 (temporary workaround until a bug related to ASCII
4925 optimization is fixed).
4926
095d384d
DA
49272013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4928
4929 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4930 Signal error if window is not internal. Adjust docstring.
4931 (delete_all_child_windows): Use combination_limit to save the buffer.
4932 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4933 * print.c (syms_of_print): Initialize debugging output not here...
4934 (init_print_once): ...but in a new function here.
4935 * lisp.h (init_print_once): Add prototype.
4936 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4937
748fa866
DA
49382013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4939
4940 * window.c (window_resize_check, window_resize_apply)
4941 (window_from_coordinates, recombine_windows, set_window_buffer)
4942 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4943 (Fsplit_window_internal, Fdelete_window_internal)
4944 (freeze_window_starts): Use bool for booleans.
4945 * window.h (window_frame_coordinates, resize_frame_windows)
4946 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4947
81519fd2
SM
49482013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4949
4950 * dispnew.c (bitch_at_user): Use `user-error'.
4951
6db423a9
KB
49522013-03-17 Ken Brown <kbrown@cornell.edu>
4953
4954 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4955 as return type of image_background. (Bug#13981)
4956 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4957
8f2906f5
JD
49582013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4959
960ce480 4960 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4961 (ns_select): Don't return with result uninitialized.
960ce480 4962
8f2906f5
JD
4963 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4964 and getDirectory.
4965
81519fd2
SM
4966 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4967 New functions.
8f2906f5
JD
4968 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4969 directories. If filename is nil, get directory name (Bug#13932).
4970 Use getFilename and getDirectory.
4971 (getFilename, getDirectory): New methods for EmacsSavePanel and
4972 EmacsOpenPanel.
4973 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4974
cded56c1
PE
49752013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4976
4977 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4978
251e9147 49792013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4980
4981 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4982 (adjust_after_replace): Make it back to static. Delete the third
4983 arg text_at_gap_tail. Cancel the code for handling it.
4984
4985 * coding.h (struct coding_system): New member eol_seen.
4986
4987 * coding.c (detect_ascii): New function.
4988 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4989 when the source bytes are actually scanned. On detecting for
4990 coding_category_utf_8_auto, call detect_ascii instead of scanning
4991 source bytes directly.
4992 (produce_chars): Call insert_from_gap with the new arg 0.
4993 (encode_coding): Likewise.
4994 (decode_coding_gap): Control ASCII optimization by the variable
4995 disable_ascii_optimization instead of #ifndef .. #endif.
4996 Deccode EOL format according to coding->eol_seen.
4997 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4998 variable.
4999
8a44e6d1
KH
5000 * lisp.h (adjust_after_replace): Cancel externing it.
5001 (insert_from_gap): Adjust prototype.
5002
5f795e34
EZ
50032013-03-15 Eli Zaretskii <eliz@gnu.org>
5004
5005 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5006 FULLSCREEN_MAXIMIZED. (Bug#13935)
5007
f258b4be
DA
50082013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5009
5010 * region-cache.c (find_cache_boundary, move_cache_gap)
5011 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5012 Simplify debugging check and convert to eassert. Adjust comment.
5013 (pp_cache): Put under ENABLE_CHECKING.
5014
a5cc4dde
EZ
50152013-03-14 Eli Zaretskii <eliz@gnu.org>
5016
5017 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5018 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5019 and WM_ACTIVATEAPP.
5020 (w32fullscreen_hook): If the frame is visible, reset
5021 f->want_fullscreen flag after changing the frame size. If the
5022 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5023 (Bug#13953)
5024
3fc5e44a
DC
50252013-03-13 Daniel Colascione <dancol@dancol.org>
5026
5027 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5028 too so that these builds can use Cygwin's file conversion
5029 functions. (We've been building and linking cygw32.o all along
5030 and just not using it.)
5031
47d7532e
PE
50322013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5033
5034 File synchronization fixes (Bug#13944).
5035 * Makefile.in (LIB_FDATASYNC): New macro.
5036 (LIBES): Use it.
5037 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5038 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5039 Don't worry about HAVE_FSYNC, since a substitute fsync is
5040 available if the system lacks one.
5041 (Fwrite_regin): Retry fsync if interrupted.
5042
c7ffccaf
EZ
50432013-03-13 Eli Zaretskii <eliz@gnu.org>
5044
4e2df81d 5045 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5046 activated, call w32fullscreen_hook, to make sure the new frame
5047 dimensions are in effect. (Bug#13937)
5048
8a7debc1
DA
50492013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5050
5051 * xdisp.c (init_iterator): Simplify because both character and byte
5052 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5053 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5054 character and byte positions can be obtained from marker.
8a7debc1 5055
7fd8c501
PE
50562013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5057
d9df6f40
PE
5058 Static checking by Sun C 5.12.
5059 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5060 * bytecode.c (exec_byte_code):
5061 * dispnew.c (init_display):
5062 * eval.c (error):
5063 * fileio.c (Fsubstitute_in_file_name):
5064 * keyboard.c (Fevent_convert_list):
5065 * keymap.c (Fsingle_key_description):
5066 * term.c (maybe_fatal, fatal):
5067 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5068 * xsmfns.c (Fhandle_save_session):
5069 Omit unreachable code.
5070 * keymap.c (map_keymap_char_table_item): Cast void * to
5071 a function pointer type; the C Standard requires this.
5072
7fd8c501
PE
5073 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5074 Include <sys/param.h> unconditionally, as that works elsewhere and
5075 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5076 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5077 and FreeBSD now.
5078
a020afb9 5079See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5080
5081;; Local Variables:
5082;; coding: utf-8
aac0c6e3
MR
5083;; End:
5084
ab422c4d 5085 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5086
5087 This file is part of GNU Emacs.
5088
5089 GNU Emacs is free software: you can redistribute it and/or modify
5090 it under the terms of the GNU General Public License as published by
5091 the Free Software Foundation, either version 3 of the License, or
5092 (at your option) any later version.
5093
5094 GNU Emacs is distributed in the hope that it will be useful,
5095 but WITHOUT ANY WARRANTY; without even the implied warranty of
5096 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5097 GNU General Public License for more details.
5098
5099 You should have received a copy of the GNU General Public License
5100 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.