Fix some fd issues when running subprocesses.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
94fcd171
PE
12013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix some fd issues when running subprocesses (Bug#15035).
4 Fix bugs that can leak files or file descriptors on errors.
5 Don't unlink open temp files, as that's hard for users to diagnose
6 when things go awry (e.g., temp disk exhausted).
7 Don't bother to lock temp files. Check for invalid recursion.
8 * callproc.c (synch_process_fd): Remove. All uses removed.
9 (synch_process_tempfile): New var or macro.
10 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
11 New constants.
12 (record_kill_process): New arg, the temp name. All callers changed.
13 (delete_temp_file): Now just a simple wrapper around unlink.
14 (call_process_kill): New arg, the call_process_fd array.
15 Close them all. Clear synch_process_pid. Remove the temp file,
16 or arrange for it to be removed.
17 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
18 that's been moved to synch_process_tempfile. Caller changed.
19 Do not remove the tempfile; that's now call_process_kill's
20 responsibility.
21 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
22 call_process_kill; the caller now does that.
23 (call_process_cleanup): Do not close the process fd; that's now
24 call_process_kill's responsibility.
25 (Fcall_process): Implement via new function call_process, which
26 has most of the old body of Fcall_process, but with a different API.
27 (call_process): New function that does not open or close filefd if
28 it is nonnegative. Record which fds need to be closed, and let
29 call_process_kill close (and remove the tempfile, on MSDOS) on error.
30 Signal an error if invoked recursively (could be done via a hook).
31 Simplify creation of the tempfile in the MSDOS case.
32 Don't create the output file until after checking for the executable.
33 Report any failure to open /dev/null.
34 Don't open /dev/null for writing twice; once is enough.
35 Don't create pipe if all output is being discarded or sent to file.
36 Don't worry about setting up the coding system or reading from the
37 pipe if all output is being discarded.
38 Hoist fd_error local into top level, to lessen block nesting.
39 Don't record deleted pid here; now done by Fcall_process_region.
40 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
41 and note its success in synch_process_tempfile.
42 Do not leak resources when child_setup fails.
43 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
44 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
45 (create_temp_file): Now returns open fd, with an additional
46 Lisp_Object * argument to return the name. All callers changed.
47 Do not close the file; rewind it instead, and leave it open for
48 the caller. Do not lock the temp file. Unwind-protect the file
49 and the file-descriptor.
50 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
51 If an asynchrounous process, record it here, not in call_process.
52 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
53 * eval.c (set_unwind_protect): New function.
54 * fileio.c (write_region): New function, generalized from the
55 old Fwrite_region. Do not lock temp files.
56 (Fwrite_region): Use it.
57 * lisp.h (set_unwind_protect, write_region): New decls.
58 * process.c: Include <verify.h>.
59 (make_process): Mark fds as initially closed.
60 (deleted_pid_list): Now a list of pid-filename pairs.
61 All uses changed.
62 (close_process_fd): New function.
63 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
64 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
65 New constants. Verify that their number matches PROCESS_OPEN_FDS.
66 (create_process, create_pty, Fmake_serial_process)
67 (server_accept_connection): Record which fds need to be closed,
68 and let deactivate_process close them.
69 (Fmake_network_process): Do not discard the unwind-protect
70 until it's safe to do so.
71 (deactivate_process): Close the fds opened by create_process etc.
72 (Fprocess_send_eof): Adjust to new way of recording open fds.
73 Report an error if /dev/null can't be opened, instead of aborting.
74 * process.h (PROCESS_OPEN_FDS): New constant.
75 (struct Lisp_Process): New member open_fds.
76 (record_kill_process, record_deleted_pid): Adjust signatures.
77 (record_deleted_pid): Move decl here ...
78 * syswait.h (record_deleted_pid): ... from here.
79
d0e615c3
PE
802013-08-11 Paul Eggert <eggert@cs.ucla.edu>
81
82 * decompress.c: Fix bugs with large buffers and weird inputs.
83 Tune a bit. Reindent as per usual Emacs style.
84 (BUFFER_SIZE): Remove.
85 (Fdecompress_gzipped_region): Do not mishandle input buffers with
86 more than UINT_MAX bytes. Decompress into the gap instead of into
87 an auto buffer, as this should avoid copying. Return nil if
88 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
89 set immediate_quit; we shouldn't trust zlib code that much.
90
313546eb
LMI
912013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
92
99a32242
LMI
93 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
94 errors, and really move the gap to where we want it.
95
313546eb
LMI
96 * lisp.h: Include decompress.c support.
97
98 * emacs.c (main): Include decompress.c support.
99
100 * Makefile.in: Include -lz if present.
101
d2d699ac
JD
1022013-08-11 Jan Djärv <jan.h.d@swipnet.se>
103
f90e3ebd
JD
104 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
105 (initWithTitle:): Initialize frame to 0.
106 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
107 (fillWithWidgetValue:frame:): Renamed from
108 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
109
110 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
111 fillWithWidgetValue:frame:
112
423d3b3f
JD
113 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
114 remove memory leak warnings.
115
d2d699ac
JD
116 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
117 (ns_check_menu_open): Handle menu == nil. Remove assignment to
118 menu_pending_title.
119
120 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
121 (x_activate_menubar): Update the whole menu.
122 (trackingNotification:): Call ns_check_menu_open if tracking ends.
123 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
124 current event is not NSSystemDefined (Bug#15001).
125 Call ns_check_menu_open only if trackingMenu is 2.
126 (menuDidClose:): New method, decrease trackingMenu.
127 (fillWithWidgetValue:setDelegate:): New method.
128 (fillWithWidgetValue:): Call the above.
129
130 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
131
7d652d97
PE
1322013-08-11 Paul Eggert <eggert@cs.ucla.edu>
133
134 Omit some unnecessary casts.
135 Many of these go back to the old pre-C89 days, when they may have
136 been needed, but we've been assuming C89 or later for a while now.
137 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
138 (live_float_p, live_misc_p, live_vector_p):
139 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
140 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
141 (defvar_per_buffer):
142 * callint.c (Fcall_interactively):
143 * doc.c (Fsubstitute_command_keys):
144 * filelock.c (get_boot_time):
145 * frame.c (xrdb_get_resource):
146 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
147 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
148 (xg_get_file_name_from_selector, menuitem_destroy_callback)
149 (menuitem_highlight_callback, menu_destroy_callback)
150 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
151 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
152 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
153 (xg_tool_bar_help_callback, tb_size_cb):
154 * image.c (xpm_alloc_color, png_read_from_memory)
155 (png_read_from_file, png_load_body, our_memory_skip_input_data)
156 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
157 (syms_of_image):
158 * keymap.c (describe_map):
159 * nsfns.m (Fns_display_monitor_attributes_list):
160 * nsmenu.m (process_dialog:):
161 * nsterm.m (hold_event):
162 * process.c (wait_reading_process_output):
163 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
164 * scroll.c (do_direct_scrolling, scrolling_1):
165 * termcap.c (tgetent):
166 * window.c (check_window_containing, add_window_to_list)
167 (freeze_window_starts):
168 * xdisp.c (compare_overlay_entries, vmessage):
169 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
170 (x_get_monitor_attributes_xrandr)
171 (Fx_display_monitor_attributes_list, x_display_info_for_name)
172 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
173 * xfont.c (xfont_match, xfont_open):
174 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
175 (menubar_selection_callback, menu_position_func)
176 (popup_selection_callback, create_and_show_popup_menu)
177 (dialog_selection_callback, create_and_show_dialog):
178 * xrdb.c (x_get_string_resource):
179 (main) [TESTRM]:
180 * xsmfns.c (x_session_check_input):
181 * xterm.c (x_draw_glyphless_glyph_string_foreground)
182 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
183 (xaw_jump_callback, xaw_scroll_callback):
184 Omit unnecessary casts.
185
9acc1074
PE
1862013-08-10 Paul Eggert <eggert@cs.ucla.edu>
187
188 Minor string-length refactoring.
189 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
190 * frame.c (make_monitor_attribute_list):
191 Prefer build_string to strlen + make_string.
192
361c0eb8
JD
1932013-08-10 Jan Djärv <jan.h.d@swipnet.se>
194
195 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
196 don't check minor_code (Bug#14417).
197
14ba0822
EZ
1982013-08-09 Eli Zaretskii <eliz@gnu.org>
199
200 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
201 vertical positions instead. This avoids calling MATRIX_ROW with
202 row numbers that are possibly beyond valid limits. (Bug#15064)
203
309f24d1
DA
2042013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
205
206 Use xstrdup and build_unibyte_string where applicable.
207 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
208 * xfns.c (x_window):
209 * xrdb.c (x_get_customization_string):
210 * xterm.c (xim_initialize):
211 * w32fns.c (w32_window): Use xstrdup.
212 (w32_display_monitor_attributes_list):
213 * emacs.c (init_cmdargs):
214 * keyboard.c (PUSH_C_STR):
215 * nsfont.m (nsfont_open):
216 * sysdep.c (system_process_attributes):
217 * w32.c (system_process_attributes):
218 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
219
55902276
EZ
2202013-08-09 Eli Zaretskii <eliz@gnu.org>
221
222 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
223 variables of these types so that GDB would know about them, as aid
224 for debugging fatal exceptions. (Bug#15024) See also
225 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
226 discussions.
227
10bf7f5a
JD
2282013-08-08 Jan Djärv <jan.h.d@swipnet.se>
229
230 * nsterm.m (ns_update_begin): Don't change clip path if it would be
231 larger than the NSWindow (Bug#14934).
232
65620264
DA
2332013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
234
235 Redesign redisplay interface to drop global variable updated_window.
236 Always pass currently updated window as a parameter to update routines.
237 * dispextern.h (updated_window): Remove declaration.
238 (struct redisplay_interface): Pass window parameter to
239 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
240 and after_update_window_hook.
241 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
242 Adjust prototypes.
243 * dispnew.c (updated_window): Remove.
244 (redraw_overlapped_rows, update_marginal_area, update_text_area)
245 (update_window_line): Adjust to match redisplay interface changes.
246 * nsterm.m (ns_update_window_begin, ns_update_window_end)
247 (ns_scroll_run, ns_after_update_window_line):
248 * w32term.c (x_update_window_begin, x_update_window_end)
249 (x_after_update_window_line, x_scroll_run):
250 * xterm.c (x_update_window_begin, x_update_window_end)
251 (x_after_update_window_line, x_scroll_run):
252 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
253 Likewise. Adjust comments where appropriate.
254 (x_cursor_to): Simplify because this is always called during window
255 update (but install debugging check anyway).
256 (expose_window): Check must_be_updated_p flag to see whether this
257 function is called during window update.
258
628fdc56
DA
2592013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
260
261 Do not reset window modification event counters excessively.
262 These leftovers and poor man's tricky methods to catch extra
263 redisplay's attention are no longer needed.
264 * frame.c (set_menu_bar_lines_1):
265 * minibuf.c (read_minibuf_unwind):
266 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
267 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
268 (window_scroll_line_based, Fset_window_configuration):
269 * xdisp.c (redisplay_window): Do not reset last_modified and
270 last_overlay_modified counters.
271
8fd9c92e
JD
2722013-08-07 Jan Djärv <jan.h.d@swipnet.se>
273
274 * xselect.c (x_send_client_event): Set send_event and serial, memset
275 data.l as it might be bigger than data.b. Use 24 bit mask to
276 XSendEvent (Bug#15034).
277
0ee18172
EZ
2782013-08-07 Eli Zaretskii <eliz@gnu.org>
279
280 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
281 for TTY frames that are not the top frame on their console.
282 (Bug#14616)
283
16ddd1a6
MR
2842013-08-07 Martin Rudalics <rudalics@gmx.at>
285
286 * w32term.c (w32fullscreen_hook): Really maximize frame when
287 asked for (Bug#14841).
288
d2a95ffb
DA
2892013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
290
291 Prefer selected_window to Fselected_window, likewise for frames.
292 * buffer.c (Fbuffer_swap_text):
293 * data.c (Fvariable_binding_locus):
294 * window.c (run_window_configuration_change_hook): Adjust users.
295 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
296 Use decode_live_frame.
297
170da1ec
DA
2982013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
299
300 Be more careful if selected window shows the buffer other than current,
301 use window_outdated only if this is not so. This change should also
302 address some weird issues discussed in Bug#13012.
303 * window.h (window_outdated): New prototype.
304 * window.c (window_outdated): Now here. Convert from static and
305 always assume window's buffer.
306 (Fwindow_end, Fwindow_line_height): Use it.
307 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
308 and always assume window's buffer.
309 (redisplay_window): Adjust user.
e5eefe9b 310 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
311 check whether mode line should be updated only if selected window
312 shows current buffer.
313 (run_window_scroll_functions): Use eassert for debugging check.
314 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
315
56b5d5b1
DA
3162013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
317
318 * window.c (window_scroll, window_scroll_pixel_based)
319 (window_scroll_line_based): Use bool for booleans.
320
2878ba7e
PE
3212013-08-06 Paul Eggert <eggert@cs.ucla.edu>
322
323 * process.c: Fix minor off-by-one issues in descriptor counts.
324 This shouldn't fix any real bugs, but it cleans up the code a bit.
325 (max_process_desc, max_input_desc): -1, not 0, means none.
326 All uses changed.
327 (delete_input_desc): New function.
328 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
329 (deactivate_process): Scan backwards when recomuting max_process_desc;
330 that should be faster.
331 (init_process_emacs): Initialize max_input_desc.
332
e30b79c1
DA
3332013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
334
335 Use region cache to speedup bidi_find_paragraph_start.
336 * buffer.h (struct buffer): New member bidi_paragraph_cache.
337 Rename cache_long_line_scans to cache_long_scans.
338 * buffer.c (bset_cache_long_line_scans): Rename to
339 bset_cache_long_scans.
340 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
341 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
342 into account.
343 (syms_of_buffer): Rename cache-long-line-scans to
344 cache-long-scans. Adjust docstring.
345 * search.c (newline_cache_on_off):
346 * indent.c (width_run_cache_on_off): Adjust users.
347 * bidi.c (bidi_paragraph_cache_on_off): New function.
348 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
349 * insdel.c (prepare_to_modify_buffer): Invalidate
350 bidi_paragraph_cache if enabled.
351
00012b86
DA
3522013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
353
354 Invalidate region caches only if buffer text is going to be changed.
355 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
356 (modify_text): ...new prototype.
357 (prepare_to_modify_buffer_1): New prototype.
358 * textprop.c (modify_region): Rename to...
359 (modify_text_properties): ...new function.
360 (add_text_properties_1, set_text_properties, Fremove_text_properties)
361 (Fremove_list_of_text_properties): Adjust users.
362 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
363 (modify_text): ...new function.
364 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
365 (prepare_to_modify_buffer_1): ...new function.
366 * casefiddle.c (casify_region):
367 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
368 (Ftranspose_regions): Use modify_text.
369
dc6c0eda
SM
3702013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
371
372 * lisp.mk (lisp): Add nadvice.elc.
373
8f3a2c26
DA
3742013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
375
376 New macro to iterate over live buffers similar to frames.
377 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
378 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
379 Declare buffer-related variables here to offload lisp.h.
380 * buffer.c (Vbuffer_alist): Adjust comment.
381 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
382 (other_buffer_safely):
383 * data.c (store_symval_forwarding):
384 * dispnew.c (Fframe_or_buffer_changed_p):
385 * fileio.c (Fdo_auto_save):
386 * filelock.c (unlock_all_files):
387 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
388
e0fdb694
PE
3892013-08-04 Paul Eggert <eggert@cs.ucla.edu>
390
391 Fix some minor races in hosts lacking mkostemp (Bug#15015).
392 * callproc.c (create_temp_file):
393 * filelock.c (create_lock_file):
394 Assume mkostemp, since it's now provided by Gnulib.
395
63f5c6c2
EZ
3962013-08-04 Eli Zaretskii <eliz@gnu.org>
397
398 * w32.c (mkostemp): New function.
399 (mktemp): Remove, no longer used. Most of the code reused in
400 mkostemp. (Bug#15015)
484ab239 401 (mktemp): Don't undef.
63f5c6c2 402
f0b79313
DA
4032013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
404
405 * dispnew.c (glyph_matrix_count, glyph_pool_count):
406 Move under GLYPH_DEBUG and ENABLE_CHECKING.
407 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
408 (free_glyph_pool, check_glyph_memory): Likewise for
409 all users. Adjust comments where appropriate.
410
98f638d6
PE
4112013-08-03 Paul Eggert <eggert@cs.ucla.edu>
412
413 * composite.h: Minor fixups.
414 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
415 to fix a misspelling, and change it to an inline function while
416 we're at it (it need not be a macro). All uses changed.
417 (composition_method, composition_valid_p):
418 Rewrite to avoid assignments in if-conditions.
419
75c59fb3
DA
4202013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
421
422 Do not use global Lisp_Object in composition macros.
423 * composite.h (composition_temp): Remove declaration.
424 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
425 (composition_method, composition_valid_p): ...inline functions.
416a3e01 426 (compose_region): Remove the leftover.
75c59fb3
DA
427 * composite.c (composition_temp): Remove.
428 (run_composition_function, update_compositions)
429 (composition_compute_stop_pos, composition_adjust_point)
430 (Ffind_composition_internal):
431 * coding.c (handle_composition_annotation):
432 * xdisp.c (handle_composition_prop, check_point_in_composition):
433 Related users changed.
434
a10c8269
DA
4352013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
436
437 Drop FRAME_PTR typedef.
438 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
439 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
440 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
441 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
442 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
443 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
444 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
445 All related users changed.
446
a104f656
SM
4472013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
448
449 * eval.c (default_toplevel_binding): New function.
450 (Fdefvar): Use it.
451 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
452 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
453 (syms_of_eval): Export them.
454 * data.c (Fdefault_value): Micro cleanup.
455 * term.c (init_tty): Use "false".
456
4b5c9326
DA
4572013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
458
459 Fix X GC leak in GTK and raw (no toolkit) X ports.
460 * xterm.c (x_free_frame_resources): If white and black relief
461 GCs are allocated, always free them here.
462 * xfns.c (x_make_gc): Omit redundant initialization.
463 * widget.c (create_frame_gcs): Remove the leftover.
464 (EmacsFrameDestroy): Do nothing because all GCs are now freed
465 in x_free_frame_resources.
466
b19aa636
JD
4672013-08-02 Jan Djärv <jan.h.d@swipnet.se>
468
469 * nsterm.m (windowWillResize:toSize:): Only change title if
470 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
471 modifying it.
472 (viewDidEndLiveResize): New method.
473
474 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
475 inside NS_IMPL_COCOA.
476
af1f7e06
DA
4772013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
478
479 * insdel.c (adjust_after_replace, replace_range, del_range_2):
480 Do not check whether undo is enabled because record_insert and
481 record_delete does that themselves.
482
65b02bb9
DA
4832013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
484
485 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
486 member which is not really used any more.
487 (FRAME_XIC_BASE_FONTNAME): Remove.
488 * xfns.c (xic_free_fontset): Adjust user.
489 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
490 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
491 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
492 (xdialog_show): Use eassert for debugging check.
7ee0f047 493 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 494
6318cde0
PE
4952013-08-01 Paul Eggert <eggert@cs.ucla.edu>
496
497 * fileio.c, fns.c (merge): Move extern decl from here ...
498 * lisp.h (merge): ... to here.
499
6c1a09ba
DA
5002013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
501
502 Fix last font-related change.
503 * w32font.h (w32font_list_internal, w32font_match_internal):
504 Fix prototype.
505 * w32uniscribe.c (uniscribe_list, uniscribe_match):
506 (uniscribe_list_family): Adjust to match font API change.
507 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
508 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
509
f8c20208
DA
5102013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
511
512 * frame.h (FRAME_MOUSE_UPDATE):
513 * nsterm.m (ns_frame_up_to_date): Omit redundant check
514 whether hlinfo->mouse_face_mouse_frame is non-NULL.
515
fdb396e2
DA
5162013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
517
518 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
519 * font.h (struct font_driver): Change list, match, and list_family
520 functions to accept struct frame * as first arg.
521 * font.c (font_score, font_compare, font_sort_entities): Remove
522 prototypes.
523 (font_sort_entities, font_list_entities, font_select_entity):
524 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
525 match font API change.
526 * xfont.c (xfont_list, xfont_match, xfont_list_family):
527 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
528 * ftxfont.c (ftxfont_list, ftxfont_match):
529 * xftfont.c (xftfont_list, xftfont_match):
530 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
531 * w32font.c (w32font_list, w32font_match, w32font_list):
532 (w32font_list_internal, w32_font_match_internal): Likewise.
533 * xfaces.c (Fx_family_fonts): Adjust user.
534
52b8a085
DA
5352013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
536
537 Do not use pure Xism x_wm_set_icon_position in non-X ports.
538 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
539 only if HAVE_X_WINDOWS is in use.
540 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
541 * nsterm.m (x_wm_set_icon_position): Remove no-op.
542 * w32term.c (x_wm_set_icon_position): Likewise.
543 * w32fns.c (x_icon): Adjust user.
544
c791c18e
DA
5452013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
546
547 * xterm.c (last_mouse_press_frame): Remove the
548 leftover which is not really used any more.
549 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
550 (x_flush): Call XFlush once per each X display, not frame.
551 This is better because this code always unconditionally skips
552 non-X frames in Vframe_list and issues the only XFlush if we
553 have more than one X frame on the same X display.
2f935d86
DA
554 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
555 Use bool for booleans.
556 (x_draw_glyph_string_background, cvt_string_to_pixel):
557 (cvt_pixel_dtor): Drop unnecessary prototypes.
558 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 559
f435830e
DA
5602013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
561
562 Drop unnecessary functions that deals with frame pixel size.
563 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
564 (x_pixel_height): Drop prototypes.
565 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
566 (x_pixel_height): Drop implementations.
567 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
568 which should be always valid for window frame.
569 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
570 * w32menu.c (Fx_popup_dialog):
571 * xmenu.c (Fx_popup_dialog): Likewise for both.
572
84231434
DA
5732013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
574
575 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
576 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
577 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
578 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
579 and mention nil frame in docstring.
84231434 580
959067a1
DA
5812013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
582
583 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
584 (x_figure_window_size): Likewise. Adjust to return long.
585 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
586 (toplevel): Move Qterminal_live_p to...
587 * terminal.c (toplevel): ...here, make it static, and...
588 (syms_of_terminal): ...DEFSYM here.
589 * frame.h (Qterminal_live_p): Remove declaration.
590 (make_frame, x_figure_window_size): Adjust prototype.
591 * nsfns.m (Fx_create_frame): Use long for window flags.
592
f4b169ce
PE
5932013-07-30 Paul Eggert <eggert@cs.ucla.edu>
594
595 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
596 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
597 Do not assume that emacs_close (INT_MAX) is a no-op.
598
bee6a2c7
DA
5992013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
600
601 * xfaces.c (make_face_cache): For struct face_cache, prefer
602 xmalloc to xzalloc and so avoid redundant call to memset.
603 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
604
d7e6881a
DA
6052013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
606
607 * fringe.c (draw_window_fringes, update_window_fringes)
608 (compute_fringe_widths):
609 * w32term.c (x_draw_glyph_string):
610 * window.c (candidate_window_p, Frecenter):
611 * xfaces.c (realize_basic_faces, realize_default_face)
612 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
613 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
614 * xfns.c (x_set_cursor_color, xic_free_xfontset):
615 * xmenu.c (Fx_menu_bar_open_internal):
616 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
617 * xsettings.c (xft_settings_event):
618 * xterm.c (x_draw_glyph_string, x_had_errors_p):
619 Use bool for booleans. Adjust style and comments where
620 appropriate.
621 * dispextern.h (draw_window_fringes, update_window_fringes)
622 (compute_fringe_widths):
623 * xterm.h (x_had_errors_p): Adjust prototype.
624
ec3058af
DA
6252013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
626
627 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
628 CHECK_LIST. Rewrite the loop to avoid useless local variable.
629
218e0637
DA
6302013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
631
632 * fns.c (toplevel): Remove comment before Fsafe_length because
633 it checks for QUIT.
634
e560aba9
PE
6352013-07-28 Paul Eggert <eggert@cs.ucla.edu>
636
637 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
638
2e5ce5de
EZ
6392013-07-28 Eli Zaretskii <eliz@gnu.org>
640
641 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
642 frame which got the message is still alive, before dereferencing
643 its pointer. (Bug#14970)
644
645 * frame.c (delete_frame): Test "this" frame's minibuffer window to
646 be a live window, before using it as such. (Bug#14970)
647
e95da6d3
EZ
6482013-07-27 Eli Zaretskii <eliz@gnu.org>
649
650 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
651 w32_detect_focus_change instead of doing part of its job by hand.
652 This fixes the problem whereby FOCUS_OUT events were not sent to
653 the event queue.
654
a8f93651
EZ
6552013-07-26 Eli Zaretskii <eliz@gnu.org>
656
fec92060
EZ
657 * process.c (Fprocess_list): Doc fix.
658
a8f93651
EZ
659 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
660 being re-exposed only if it didn't ask to become visible.
661 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
662 was previously iconified. (Bug#14841)
663 (x_iconify_frame): Mark the frame iconified.
664
d5a7a9d9
PE
6652013-07-26 Paul Eggert <eggert@cs.ucla.edu>
666
667 Fix minor problems found by static checking.
668 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
669 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
670
56ea7291
SM
6712013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
672
673 * eval.c (set_specpdl_old_value): New function.
674 (unbind_to): Minor simplification.
675 (get_backtrace_frame): New function.
676 (Fbacktrace_frame): Use it. Add `base' argument.
677 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
678 (syms_of_eval): Export backtrace-eval.
679 * xterm.c (x_focus_changed): Simplify.
680
9d611ffe
PE
6812013-07-25 Paul Eggert <eggert@cs.ucla.edu>
682
683 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
684
999c74e3
EZ
6852013-07-24 Eli Zaretskii <eliz@gnu.org>
686
687 * xdisp.c (redisplay_window): Instead of moving point out of
688 scroll margin, reject the force_start method, and try scrolling
689 instead. (Bug#14780)
690
198fa217
KB
6912013-07-24 Ken Brown <kbrown@cornell.edu>
692
693 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
694 (Bug#14944).
695
53840e55
PE
6962013-07-24 Paul Eggert <eggert@cs.ucla.edu>
697
698 * eval.c (Fprogn): Do not check that BODY is a proper list.
699 This undoes the previous change. The check slows down the
700 interpreter, and is not needed to prevent a crash. See
701 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
702
60967f56
GM
7032013-07-23 Glenn Morris <rgm@gnu.org>
704
705 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
706
9ca960e2
PE
7072013-07-23 Paul Eggert <eggert@cs.ucla.edu>
708
a29c3e6d
PE
709 Port to GNU/Linux systems with tinfo but not ncurses.
710 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
711 to decide whether ncurses is being used. Without this change,
712 GCC complains about tgetent not being declared, on a system
713 that has tinfo installed but ncurses not installed.
714
f274311c
PE
715 * eval.c (Fprogn): Check that BODY is a proper list.
716
16b0520a
PE
717 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
718 * data.c (Fsetq_default):
719 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
720 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
721 (Fcondition_case):
722 Tune by taking advantage of the fact that ARGS is always a list
723 when a function is declared to have UNEVALLED args.
724
9ca960e2
PE
725 * emacsgtkfixed.c: Port to GCC 4.6.
726 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
727
afacaa1b
JB
7282013-07-23 Juanma Barranquero <lekktu@gmail.com>
729
730 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
731 here to silence compiler warnings.
732
368a85a4
PE
7332013-07-22 Paul Eggert <eggert@cs.ucla.edu>
734
735 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
736 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
737 from messing up Emacs's 'struct frame' (Bug#14923).
738
f4e891b5
PE
7392013-07-21 Paul Eggert <eggert@cs.ucla.edu>
740
741 * alloc.c (make_save_ptr_ptr): Define this function.
742 It was inadvertently omitted. It's needed only if
743 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
744
96c8b65e
JD
7452013-07-21 Jan Djärv <jan.h.d@swipnet.se>
746
747 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
748 frame have focus (Bug#14895).
749
ee010797
PE
7502013-07-21 Paul Eggert <eggert@cs.ucla.edu>
751
752 Avoid vfork-related deadlock more cleanly.
753 * callproc.c (child_setup): When the child's exec fails, output
754 the program name, as that's more useful. Use O_NONBLOCK to avoid
755 deadlock.
756 * process.c (create_process_1): Remove; no longer needed.
757 (create_process): Remove timer hack; no longer needed, now that
758 the child avoids deadlock.
759
f0398ec1 7602013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
761
762 * image.c (Fimage_flush): Fix doc typo.
763
b2a069c2
PE
7642013-07-20 Paul Eggert <eggert@cs.ucla.edu>
765
6496aec9
PE
766 Fix array bounds violation when pty allocation fails.
767 * process.c (PTY_NAME_SIZE): New constant.
768 (pty_name): Remove static variable; it's now auto.
769 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
770 Take pty_name as an arg rather than using a static variable.
771 All callers changed.
772 (create_process): Recover pty_flag from process, not from volatile local.
773 (create_pty): Stay inside array even when pty allocation fails.
774 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
775
b2a069c2
PE
776 * lread.c (Fload): Avoid initialization only when lint checking.
777 Mention that it's needed only for older GCCs.
778
99107004
KH
7792013-07-20 Kenichi Handa <handa@gnu.org>
780
781 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
782 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
783
6b1b199d
AS
7842013-07-20 Andreas Schwab <schwab@linux-m68k.org>
785
786 * lread.c (Fload): Avoid uninitialized warning.
787
4195afc3
PE
7882013-07-19 Paul Eggert <eggert@cs.ucla.edu>
789
3f5bef16
PE
790 Fix some minor file descriptor leaks and related glitches.
791 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
792 (create_lock_file): Use write, not emacs_write.
793 * image.c (slurp_file, png_load_body):
794 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
795 (server_accept_connection):
796 Don't leak an fd on memory allocation failure.
797 * image.c (slurp_file): Add a cheap heuristic for growing files.
798 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
799 as that's what the other routines do. Maybe input need not be
800 blocked at all, but it's better to be consistent.
801 Avoid undefined behavior when strlen is zero.
802
4195afc3
PE
803 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
804 (NSTATICS): Now a constant; doesn't need to be a macro.
805
a1aeeffe
RS
8062013-07-19 Richard Stallman <rms@gnu.org>
807
808 * coding.c (decode_coding_utf_8): Add simple loop for fast
809 processing of ASCII characters.
810
63b34baa
PE
8112013-07-19 Paul Eggert <eggert@cs.ucla.edu>
812
813 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
814
621dd9ac
EZ
8152013-07-19 Eli Zaretskii <eliz@gnu.org>
816
817 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
818 unportable 'struct x_display_info'.
819 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
820 is a portable type.
821
1396ac86
PE
8222013-07-19 Paul Eggert <eggert@cs.ucla.edu>
823
ab9980cd
PE
824 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
825 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
826 or fscanf fails.
827 (system_process_attributes): Prefer plain char to unsigned char
828 when either will do. Clean up properly if interrupted or if
829 memory allocations fail. Don't assume sscanf succeeds. Remove
830 no-longer-needed workaround to stop GCC from whining. Read
831 command-line once, instead of multiple times. Check read status a
832 bit more carefully.
833
1396ac86
PE
834 Fix obscure porting bug with varargs functions.
835 The code assumed that int is treated like ptrdiff_t in a vararg
836 function, which is not a portable assumption. There was a similar
837 -- though these days less likely -- porting problem with various
838 assumptions that pointers of different types all smell the same as
839 far as vararg functions is conserved. To make this problem less
840 likely in the future, redo the API to use varargs functions.
841 * alloc.c (make_save_value): Remove this vararg function.
842 All uses changed to ...
843 (make_save_int_int_int, make_save_obj_obj_obj_obj)
844 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
845 New functions.
846 (make_save_ptr): Rename from make_save_pointer, for consistency with
847 the above. Define only on platforms that need it. All uses changed.
848
4d19d194
PE
8492013-07-18 Paul Eggert <eggert@cs.ucla.edu>
850
851 * keyboard.c: Try to fix typos in previous change.
852 (DISPLAY_LIST_INFO): New macro.
853 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 854 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 855
945c5bb1
JB
8562013-07-18 Juanma Barranquero <lekktu@gmail.com>
857
858 * keyboard.c (kbd_buffer_get_event):
859 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
860 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
861
f4b1eb36
PE
8622013-07-18 Paul Eggert <eggert@cs.ucla.edu>
863
5e679a2c
PE
864 * filelock.c: Fix unlikely file descriptor leaks.
865 (get_boot_time_1): Rework to avoid using emacs_open.
866 This doesn't actually fix a leak, but is better anyway.
867 (read_lock_data): Use read, not emacs_read.
868
a8cd4836
PE
869 * doc.c: Fix minor memory and file descriptor leaks.
870 * doc.c (get_doc_string): Fix memory leak when doc file absent.
871 (get_doc_string, Fsnarf_documentation):
872 Fix file descriptor leak on error.
873
ef30e638
PE
874 * term.c: Fix minor fdopen-related file descriptor leaks.
875 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
876 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
877
f4b1eb36
PE
878 * charset.c: Fix file descriptor leaks and errno issues.
879 Include <errno.h>.
880 (load_charset_map_from_file): Don't leak file descriptor on error.
881 Use plain record_xmalloc since the allocation is larger than
882 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
883 of entries.
884 * eval.c (record_unwind_protect_nothing):
885 * fileio.c (fclose_unwind):
886 New functions.
887 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
888 The replacement doesn't block input, but that no longer seems
889 necessary.
890
b648c163
PE
8912013-07-17 Paul Eggert <eggert@cs.ucla.edu>
892
a0931322
PE
893 * lread.c: Fix file descriptor leaks and errno issues.
894 (Fload): Close some races that leaked fds or streams when 'load'
895 was interrupted.
896 (Fload, openp): Report error number of last nontrivial failure to open.
897 ENOENT counts as trivial.
898 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
899 New functions.
900 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
901 now that the function is always called with a nonnegative arg.
902 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
903 All uses replaced with ...
904 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
905
b648c163
PE
906 A few more minor file errno-reporting bugs.
907 * callproc.c (Fcall_process):
908 * doc.c (Fsnarf_documentation):
909 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
910 * process.c (set_socket_option):
911 Don't let a constructor trash errno.
912 * doc.c: Include <errno.h>.
913
b1dc4084
JB
9142013-07-16 Juanma Barranquero <lekktu@gmail.com>
915
916 * w32fns.c (unwind_create_tip_frame): Fix declaration.
917
c43843aa
PE
9182013-07-16 Paul Eggert <eggert@cs.ucla.edu>
919
50a30cce
PE
920 Fix w32 bug with call-process-region (Bug#14885).
921 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
922 to Fcall_process when the input is empty. This simplifies the
923 code a bit. It makes no difference on POSIXish platforms but
924 apparently it fixes a bug on w32.
925
44e18199 926 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
927 * fileio.c (close_file_unwind): Don't close if FD is negative;
928 this can happen when unwinding a zapped file descriptor.
929 (Finsert_file_contents): Unwind-protect the fd before the point marker,
930 in case Emacs runs out of memory between the two unwind-protects.
931 Don't trash errno when closing FD.
932 Zap the FD in the specpdl when closing it, instead of deferring
933 the removal of the unwind-protect; this fixes a bug where a child
934 function unwinds the stack past us.
935
27e498e6
PE
936 New unwind-protect flavors to better type-check C callbacks.
937 This also lessens the need to write wrappers for callbacks,
938 and the need for make_save_pointer.
939 * alloca.c (free_save_value):
940 * atimer.c (run_all_atimers):
941 Now extern.
942 * alloc.c (safe_alloca_unwind):
943 * atimer.c (unwind_stop_other_atimers):
944 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
945 * menu.c (cleanup_popup_menu) [HAVE_NS]:
946 * minibuf.c (choose_minibuf_frame_1):
947 * process.c (make_serial_process_unwind):
948 * xdisp.h (pop_message_unwind):
949 * xselect.c (queue_selection_requests_unwind):
950 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
951 * alloca.c (record_xmalloc):
952 Prefer record_unwind_protect_ptr to record_unwind_protect with
953 make_save_pointer.
954 * alloca.c (Fgarbage_collect):
955 Prefer record_unwind_protect_void to passing a dummy.
956 * buffer.c (restore_buffer):
957 * window.c (restore_window_configuration):
958 * xfns.c, w32fns.c (do_unwind_create_frame)
959 New wrapper. All record-unwind uses of wrappee changed.
960 * buffer.c (set_buffer_if_live):
961 * callproc.c (call_process_cleanup, delete_temp_file):
962 * coding.c (code_conversion_restore):
963 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
964 * editfns.c (save_excursion_restore)
965 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
966 (save_restriction_restore):
967 * eval.c (restore_stack_limits, un_autoload):
968 * fns.c (require_unwind):
969 * keyboard.c (recursive_edit_unwind, tracking_off):
970 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
971 * macros.c (pop_kbd_macro, restore_menu_items):
972 * nsfns.m (unwind_create_frame):
973 * print.c (print_unwind):
974 * process.c (start_process_unwind):
975 * search.c (unwind_set_match_data):
976 * window.c (select_window_norecord, select_frame_norecord):
977 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
978 (fast_set_selected_frame):
979 * xfns.c, w32fns.c (unwind_create_tip_frame):
980 Return void, not a dummy Lisp_Object. All uses changed.
981 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
982 * callproc.c (call_process_kill):
983 * fileio.c (restore_point_unwind, decide_coding_unwind)
984 (build_annotations_unwind):
985 * insdel.c (Fcombine_after_change_execute_1):
986 * keyboard.c (read_char_help_form_unwind):
987 * menu.c (unuse_menu_items):
988 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
989 * sound.c (sound_cleanup):
990 * xdisp.c (unwind_redisplay):
991 * xfns.c (clean_up_dialog):
992 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
993 Accept no args and return void, instead of accepting and returning
994 a dummy Lisp_Object. All uses changed.
995 * cygw32.c (fchdir_unwind):
996 * fileio.c (close_file_unwind):
997 * keyboard.c (restore_kboard_configuration):
998 * lread.c (readevalllop_1):
999 * process.c (wait_reading_process_output_unwind):
1000 Accept int and return void, rather than accepting an Emacs integer
1001 and returning a dummy object. In some cases this fixes an
1002 unlikely bug when the corresponding int is outside Emacs integer
1003 range. All uses changed.
1004 * dired.c (directory_files_internal_unwind):
1005 * fileio.c (do_auto_save_unwind):
1006 * gtkutil.c (pop_down_dialog):
1007 * insdel.c (reset_var_on_error):
1008 * lread.c (load_unwind):
1009 * xfns.c (clean_up_file_dialog):
1010 * xmenu.c, nsmenu.m (pop_down_menu):
1011 * xmenu.c (cleanup_widget_value_tree):
1012 * xselect.c (wait_for_property_change_unwind):
1013 Accept pointer and return void, rather than accepting an Emacs
1014 save value encapsulating the pointer and returning a dummy object.
1015 All uses changed.
1016 * editfns.c (Fformat): Update the saved pointer directly via
1017 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1018 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1019 (unwind_body): New function.
1020 (record_unwind_protect): First arg is now a function returning void,
1021 not a dummy Lisp_Object.
1022 (record_unwind_protect_ptr, record_unwind_protect_int)
1023 (record_unwind_protect_void): New functions.
1024 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1025 * fileio.c (struct auto_save_unwind): New type.
1026 (do_auto_save_unwind): Use it.
1027 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1028 * insdel.c (struct rvoe_arg): New type.
1029 (reset_var_on_error): Use it.
1030 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1031 New constants.
1032 (specbinding_func): Remove; there are now several such functions.
1033 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1034 (set_unwind_protect_ptr): New function.
1035 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1036
4e604a5d
PE
1037 Be simpler and more consistent about reporting I/O errors.
1038 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1039 Say "Read error" and "Write error", rather than "I/O error", or
1040 "IO error reading", or "IO error writing", when a read or write
1041 error occurs.
1042 * process.c (Fmake_network_process, wait_reading_process_output)
1043 (send_process, Fprocess_send_eof, wait_reading_process_output):
1044 Capitalize diagnostics consistently. Put "failed foo" at the
1045 start of the diagnostic, so that we don't capitalize the
1046 function name "foo". Consistently say "failed" for such
1047 diagnostics.
1048 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1049 All callers changed. This is so it can use report_file_error.
1050 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1051 diagnostics consistently as above.
1052
a9757f6a
PE
1053 * fileio.c (report_file_errno): Fix errno reporting bug.
1054 If the file name is neither null nor a pair, package it up as a
1055 singleton list. All callers changed, both to this function and to
1056 report_file_error. This fixes a bug where the memory allocator
1057 invoked by list1 set errno so that the immediately following
1058 report_file_error reported the wrong errno value.
1059
c43843aa
PE
1060 Fix minor problems found by --enable-gcc-warnings.
1061 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1062 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1063
18c26d81
JD
10642013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1065
1066 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1067 Set event->arg to Qt if switch-event shall be generated.
1068 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1069
1070 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1071
1072 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1073 FOCUS_OUT_EVENT.
1074
1075 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1076 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1077 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1078 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1079 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1080 and there is a focused frame.
1081 (head_table): Add focus-in and focus-out.
1082 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1083 bind to handle-focus-in/out.
1084
1085 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1086 (Fhandle_switch_frame): Call Fhandle_focus_in.
1087 (syms_of_frame): defsubr handle-focus-in/out.
1088
6c6f1994
PE
10892013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1090
c7ddc792
PE
1091 Fix porting bug to older POSIXish platforms (Bug#14862).
1092 * sysdep.c (emacs_pipe): New function, that implements
1093 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1094 This should port better to CentOS 5 and to Mac OS X 10.6.
1095 All calls to pipe2 changed.
1096
6c6f1994
PE
1097 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1098 This makes the code easier to read and the executable a bit smaller.
1099 Do not replace all calls to Fcons that happen to create lists,
1100 just calls that are intended to create lists. For example, when
1101 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1102 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1103 Similarly for list2 through list5.
1104 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1105 * bytecode.c (exec_byte_code):
1106 * callint.c (quotify_arg, Fcall_interactively):
1107 * callproc.c (Fcall_process, create_temp_file):
1108 * charset.c (load_charset_map_from_file)
1109 (Fdefine_charset_internal, init_charset):
1110 * coding.c (get_translation_table, detect_coding_system)
1111 (Fcheck_coding_systems_region)
1112 (Fset_terminal_coding_system_internal)
1113 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1114 * composite.c (update_compositions, Ffind_composition_internal):
1115 * dired.c (directory_files_internal, file_name_completion)
1116 (Fsystem_users):
1117 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1118 * doc.c (Fsnarf_documentation):
1119 * editfns.c (Fmessage_box):
1120 * emacs.c (main):
1121 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1122 (Feval, eval_sub, Ffuncall, apply_lambda):
1123 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1124 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1125 (Fset_file_times, Finsert_file_contents)
1126 (Fchoose_write_coding_system, Fwrite_region):
1127 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1128 * font.c (font_registry_charsets, font_parse_fcname)
1129 (font_prepare_cache, font_update_drivers, Flist_fonts):
1130 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1131 * frame.c (make_frame, Fmake_terminal_frame)
1132 (x_set_frame_parameters, x_report_frame_params)
1133 (x_default_parameter, Fx_parse_geometry):
1134 * ftfont.c (syms_of_ftfont):
1135 * image.c (gif_load):
1136 * keyboard.c (command_loop_1):
1137 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1138 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1139 (Fminor_mode_key_binding, accessible_keymaps_1)
1140 (Faccessible_keymaps, Fwhere_is_internal):
1141 * lread.c (read_emacs_mule_char):
1142 * menu.c (find_and_return_menu_selection):
1143 * minibuf.c (get_minibuffer):
1144 * nsfns.m (Fns_perform_service):
1145 * nsfont.m (ns_script_to_charset):
1146 * nsmenu.m (ns_popup_dialog):
1147 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1148 (Fx_own_selection_internal):
1149 * nsterm.m (append2):
1150 * print.c (Fredirect_debugging_output)
1151 (print_prune_string_charset):
1152 * process.c (Fdelete_process, Fprocess_contact)
1153 (Fformat_network_address, set_socket_option)
1154 (read_and_dispose_of_process_output, write_queue_push)
1155 (send_process, exec_sentinel):
1156 * sound.c (Fplay_sound_internal):
1157 * textprop.c (validate_plist, add_properties)
1158 (Fput_text_property, Fadd_face_text_property)
1159 (copy_text_properties, text_property_list, syms_of_textprop):
1160 * unexaix.c (report_error):
1161 * unexcoff.c (report_error):
1162 * unexsol.c (unexec):
1163 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1164 (Fformat_mode_line, syms_of_xdisp):
1165 * xfaces.c (set_font_frame_param)
1166 (Finternal_lisp_face_attribute_values)
1167 (Finternal_merge_in_global_face, syms_of_xfaces):
1168 * xfns.c (x_default_scroll_bar_color_parameter)
1169 (x_default_font_parameter, x_create_tip_frame):
1170 * xfont.c (xfont_supported_scripts):
1171 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1172 (menu_help_callback, xmenu_show):
1173 * xml.c (make_dom):
1174 * xterm.c (set_wm_state):
1175 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1176 and similarly for list2 through list5.
1177
bafe80ce
PE
11782013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1179
1180 * callproc.c (Fcall_process_region): Fix minor race and tune.
1181 (create_temp_file): New function, with the temp-file-creation part
1182 of the old Fcall_process_region. Use Fcopy_sequence to create the
1183 temp file name, rather than alloca + build_string, for simplicity.
1184 Don't bother to block input around the temp file creation;
1185 shouldn't be needed. Simplify use of mktemp. Use
1186 record_unwind_protect immediately after creating the temp file;
1187 this closes an unlikely race where the temp file was not removed.
1188 Use memcpy rather than an open-coded loop.
1189 (Fcall_process_region): Use the new function. If the input is
1190 empty, redirect from /dev/null rather than from a newly created
1191 empty temp file; this avoids unnecessary file system traffic.
1192
4700b5a5
PE
11932013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1194
5c97beae
PE
1195 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1196 Simplify by making this case like the other two. This is a bit
1197 slower on obsolete hosts, but the extra complexity isn't worth it.
1198
4700b5a5
PE
1199 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1200 * process.c (create_process) [!DOS_NT]:
1201 Remove now-unnecessary calls to emacs_close.
1202
f9a74c4c
EZ
12032013-07-13 Eli Zaretskii <eliz@gnu.org>
1204
922ae7ee
EZ
1205 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1206 returning early. (Bug#14850)
1207
f9a74c4c
EZ
1208 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1209 and inhibit-iso-escape-detection attributes of 'undecided'.
1210 (Bug#14822)
1211
5e301d76
PE
12122013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1213
69e0e5ee
PE
1214 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1215 Reported by Herbert J. Skuhra in
1216 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1217
5e301d76
PE
1218 Don't lose top specpdl entry when memory is exhausted.
1219 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1220 specpdl overflow here, to simplify callers; all callers changed.
1221 Always reserve an unused entry at the stack top; this avoids
1222 losing the top entry's information when memory is exhausted.
1223
7e649856
PE
12242013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1225
a773ed9a
PE
1226 Clean up errno reporting and fix some errno-reporting bugs.
1227 * callproc.c (Fcall_process):
1228 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1229 * process.c (create_process, Fmake_network_process):
1230 * unexaix.c (report_error):
1231 * unexcoff.c (report_error):
1232 Be more careful about reporting the errno of failed operations.
1233 The code previously reported the wrong errno sometimes.
1234 Also, prefer report_file_errno to setting errno + report_file_error.
1235 (Fcall_process): Look at openp return value rather than at path,
1236 as that's a bit faster and clearer when there's a numeric predicate.
1237 * fileio.c (report_file_errno): New function, with most of the
1238 old contents of report_file_error.
1239 (report_file_error): Use it.
1240 (Ffile_exists_p, Ffile_accessible_directory_p):
1241 Set errno to 0 when it is junk.
1242 * fileio.c (Faccess_file):
1243 * image.c (x_create_bitmap_from_file):
1244 Use faccessat rather than opening the file, to avoid the hassle of
1245 having a file descriptor open.
1246 * lisp.h (report_file_errno): New decl.
1247 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1248
7e649856
PE
1249 Minor EBADF fixes.
1250 * process.c (create_process, wait_reading_process_output) [AIX]:
1251 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1252 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1253 a multithreaded environment anyway).
1254 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1255
f6774c1a
AS
12562013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1257
1258 * image.c (x_find_image_file): Don't close a remote file handle.
1259
bacba3c2
PE
12602013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 Fix races with threads and file descriptors.
1263 * callproc.c (Fcall_process_region):
1264 * dired.c (open_directory):
1265 * emacs.c (main, Fdaemon_initialized):
1266 * image.c (x_find_image_file):
1267 * inotify.c (Finotify_rm_watch):
1268 * lread.c (Flocate_file_internal):
1269 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1270 * term.c (term_mouse_moveto, init_tty):
1271 * termcap.c (tgetent):
1272 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1273 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1274 * unexhp9k800.c, unexmacosx.c (unexec):
1275 * callproc.c (Fcall_process_region):
1276 Use emacs_close, not close.
1277 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1278 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1279 and posix_close function on current platforms (which all lack them).
1280 (emacs_close): Use it. This should fix the races on GNU/Linux and
1281 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1282 and it should avoid closing random victim file descriptors on
1283 other platforms.
1284
653d4f43
PE
12852013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1286
c8536ec4
PE
1287 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1288 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1289 Touch up doc a bit.
1290
9c203066
PE
1291 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1292 This is for .gdbinit xbacktrace.
1293
653d4f43
PE
1294 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1295 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1296 (emacs_set_tty): Now static.
1297 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1298 * term.c (tty_capable_p, tty_default_color_capabilities)
1299 (get_tty_terminal, term_mouse_movement)
1300 (handle_one_term_event, init_tty, maybe_fatal):
1301 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1302 (tgetent, scan_file, name_match, compare_contin):
1303 * terminal.c (get_terminal):
1304 Use bool for boolean.
1305 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1306 Prefer char to unsigned char if either will do.
1307 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1308 (tty_write_glyphs): Prefer int to unsigned.
1309 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1310 All callers changed.
1311 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1312
45b683a1
PE
13132013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1314
29abe551
PE
1315 Port to C89.
1316 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1317 (B__dummy__): New dummy symbol, to pacify C89.
1318 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1319 they can't grok varargs macros.
1320 * dispnew.c (add_window_display_history)
1321 (add_frame_display_history):
1322 * print.c (print_object):
1323 * xdisp.c (debug_method_add):
1324 Use %p printf format only for void pointers.
1325 * emacs.c (usage_message): New constant, replacing ...
1326 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1327 (main): Adjust to usage reorg.
1328 * fns.c (syms_of_fns):
1329 * profiler.c (syms_of_profiler):
1330 Don't use non-constant struct initializers.
1331 * gnutls.h (gnutls_initstage_t):
1332 * lisp.h (enum Lisp_Fwd_Type):
1333 * lread.c (lisp_file_lexically_bound_p):
1334 * xsettings.c (anonymous enum):
1335 Remove trailing comma.
1336 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1337 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1338 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1339 (DEFUN): Use it.
1340 * regex.c (const_re_char): New type, to pacify strict C89.
1341 All uses of 'const re_char' replaced to use it.
1342 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1343 with glibc when strict C89. This change is imported from gnulib.
1344 All uses changed.
1345 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1346 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1347 Omit GNU_LINUX implementation, since it requires long long.
1348 * xterm.c (x_draw_underwave):
1349 Do not assume the traditional order of struct's members.
1350 (x_term_init): Rewrite to avoid the need for non-constant structure
1351 initializers.
1352
45b683a1 1353 Syntax cleanup, mostly replacing macros with functions.
763a086d 1354 This removes the need for the syntax_temp hack.
45b683a1
PE
1355 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1356 * syntax.c (SYNTAX_INLINE): New macro.
1357 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1358 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1359 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1360 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1361 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1362 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1363 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1364 Now constants, not macros.
1365 (syntax_temp) [!__GNUC__]: Remove.
1366 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1367 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1368 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1369 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1370 Move here from syntax.h; now functions, not macros. Except for the
1371 last function, these are static since only syntax.c uses them.
1372 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1373 All uses changed. Now a function, not a macro; use this fact
1374 to simplify the code.
1375 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1376 compiler bugs; no longer relevant.
1377 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1378 (SYNTAX_INLINE): New macro.
1379 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1380 for the new functions. Use bool for boolean member.
1381 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1382 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1383 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1384 (SETUP_BUFFER_SYNTAX_TABLE):
1385 Now extern inline functions, not macros.
1386 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1387 Remove; all uses replaced by implementation.
1388 (syntax_temp) [!__GNUC__]: Remove decl.
1389 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1390
29be4a50
JD
13912013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1392
1393 * emacs.c (main): Fix syntax error.
1394
954b166e
PE
13952013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 Timestamp fixes for undo (Bug#14824).
1398 * atimer.c (schedule_atimer):
1399 * fileio.c (Ffile_newer_than_file_p):
1400 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1401 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1402 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1403 (syms_of_fileio): Remove Sclear_visited_file_name.
1404 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1405 file doesn't exist; this avoids an ambiguity with negative timestamps.
1406 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1407 * systime.h (make_emacs_time, invalid_emacs_time):
1408 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1409 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1410 * undo.c (record_first_change): Push (visited-file-modtime) onto
1411 undo list rather than reimplementing it by hand, incorrectly.
1412
d74647c3
KB
14132013-07-09 Ken Brown <kbrown@cornell.edu>
1414
1415 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1416
3c51b96b
JB
14172013-07-09 Juanma Barranquero <lekktu@gmail.com>
1418
1419 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1420
4ebbdd67
PE
14212013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 Handle errno and exit status a bit more carefully.
1424 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1425 number into an exit status. Instead, use EXIT_CANCELED.
1426 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1427 * callproc.c (relocate_fd):
1428 * emacs.c (close_output_streams, main):
1429 * process.c (create_process):
1430 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1431 Use emacs_perror for simplicity.
1432 * callproc.c (relocate_fd, main):
1433 * sysdep.c (sys_subshell):
1434 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1435 (shut_down_emacs): Use emacs_write, not write.
1436 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1437 * fileio.c (Fcopy_file, e_write):
1438 * nsterm.m (ns_select):
1439 * process.c (send_process):
1440 * sound.c (vox_write):
1441 Use emacs_write_sig, not emacs_write.
1442 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1443 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1444 New constants.
1445 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1446 of write.
1447 (emacs_full_write): New function.
1448 (emacs_write): Rewrite to use it.
1449 (emacswrite_sig, emacs_perror): New functions.
1450 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1451
44e18199 14522013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1453
1454 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1455 on NS even if it is present. Pixmap on NS is a void*.
1456
9caab067
PE
14572013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 Port to Ubuntu 10 (Bug#14803).
1460 Problem reported by T.V. Raman.
1461 * process.c (close_on_exec, accept4, process_socket):
1462 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1463
1d442672
EZ
14642013-07-07 Eli Zaretskii <eliz@gnu.org>
1465
1466 * w32.c (sys_dup): Declare prototype.
1467
1468 * filelock.c:
1469 * emacs.c:
1470 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1471
067428c1
PE
14722013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 Make file descriptors close-on-exec when possible (Bug#14803).
1475 This simplifies Emacs a bit, since it no longer needs to worry
1476 about closing file descriptors by hand in some cases.
1477 It also fixes some unlikely races. Not all such races, as
1478 libraries often open files internally without setting
1479 close-on-exec, but it's an improvement.
1480 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1481 * callproc.c (Fcall_process) [!MSDOS]:
1482 * emacs.c (main) [!DOS_NT]:
1483 * nsterm.m (ns_term_init):
1484 * process.c (create_process):
1485 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1486 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1487 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1488 Prefer mkostemp with O_CLOEXEC to mkstemp.
1489 * callproc.c (relocate_fd) [!WINDOWSNT]:
1490 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1491 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1492 now using pipe2.
1493 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1494 Make the resulting file descriptor close-on-exec.
1495 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1496 * lread.c (load_descriptor_list, load_descriptor_unwind):
1497 Remove; no longer needed. All uses removed.
1498 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1499 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1500 New functions.
1501 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1502 (Fmake_network_process, Fnetwork_interface_list):
1503 (Fnetwork_interface_info, server_accept_connection):
1504 Make newly-created socket close-on-exec.
1505 * sysdep.c (emacs_open, emacs_fopen):
1506 Make new-created descriptor close-on-exec.
1507 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1508 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1509
0da857dd
JD
15102013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1511
1512 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1513 for NS_IMPL_GNUSTEP.
1514
5f86adcd
PE
15152013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 Fix openp errno handling.
1518 * callproc.c (Fcall_process): Preserve openp errno around close.
1519 * lread.c (openp): Set errno when returning -1, as some callers
1520 expect this.
1521
1afb1d07
JD
15222013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1523
1524 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1525
1526 * nsterm.h (NSSavePanel): Update comment.
1527 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1528 (ns_run_file_dialog): Declare.
1529
1530 * nsfns.m: Remove panelOK.
1531 (ns_fd_data): New.
1532 (ns_run_file_dialog): New function.
1533 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1534 event loop, so file dialog is popped up by ns_run_file_dialog, called
1535 by sendEvent (Bug#14578).
1536 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1537
3323c263
EZ
15382013-07-06 Eli Zaretskii <eliz@gnu.org>
1539
fdda0220
EZ
1540 * xdisp.c (default_line_pixel_height): New function.
1541 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1542 (try_cursor_movement, redisplay_window, try_window)
1543 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1544
1545 * window.c (window_scroll_pixel_based): use
1546 default_line_pixel_height.
1547
1548 * dispextern.h (default_line_pixel_height): Add prototype.
1549
1550 * frame.c (x_set_line_spacing): Accept a float value for
1551 line-spacing parameter, per the documentation.
1552
3323c263
EZ
1553 * data.c (Fmultibyte_string_p): Doc fix.
1554
47ba6d43
PE
15552013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1556
406af475
PE
1557 Use emacs_open more consistently when opening files.
1558 This handles EINTR more consistently now, and makes it easier
1559 to introduce other uniform changes to file descriptor handling.
1560 * src/systdio.h: New file.
1561 * src/buffer.c (mmap_init):
1562 * cygw32.c (chdir_to_default_directory):
1563 * dispnew.c (Fopen_termscript):
1564 * emacs.c (Fdaemon_initialized):
1565 * fileio.c (Fdo_auto_save):
1566 * image.c (slurp_file, png_load_body, jpeg_load_body):
1567 * keyboard.c (Fopen_dribble_file):
1568 * lread.c (Fload):
1569 * print.c (Fredirect_debugging_output):
1570 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1571 * termcap.c (tgetent):
1572 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1573 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1574 * w32term.c (w32_initialize) [CYGWIN]:
1575 * xfaces.c (Fx_load_color_file):
1576 Use emacs_open instead of plain open, and emacs_fopen instead of
1577 plain fopen.
1578 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1579 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1580 * callproc.c (default_output_mode): New constant.
1581 (Fcall_process): Use it to call emacs_open instead of plain creat.
1582 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1583 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1584 (emacs_fopen): New function.
1585 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1586 Include <lisp.h>, for emacs_open.
1587 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1588
47ba6d43
PE
1589 Remove duplicate #include directives.
1590 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1591 * xfaces.c:
1592 Don't include stdio.h twice.
1593 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1594 Don't include sys/types.h or stdio.h twice.
1595 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1596 * lread.c: Don't include coding.h twice.
1597 * nsfont.m: Don't include frame.h twice.
1598 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1599 * ralloc.c: Don't include <unistd.h> twice.
1600 * xdisp.c: Don't include font.h twice.
1601 * xterm.c: Don't include fontset.h twice.
1602 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1603
b9ed53d5
PE
16042013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 Scale ImageMagick images more carefully.
1607 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1608 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1609 Be more careful about avoiding undefined behavior after
1610 integer overflow and division by zero.
1611
cf13177e
YM
16122013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1613
1614 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1615 (syms_of_w32fns): DEFSYM them.
1616 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1617 (CCHDEVICENAME): Define macros if not defined.
1618 (struct MONITOR_INFO_EX): New struct.
1619 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1620 (enum_display_monitors_fn): New variable.
1621 (globals_of_w32fns): Initialize it.
1622 (Fx_display_pixel_width, Fx_display_pixel_height)
1623 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1624 multi-monitor setups in docstrings.
1625 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1626 screen size by primary monitor's millimeter per pixel.
1627 (w32_monitor_enum, w32_display_monitor_attributes_list)
1628 (w32_display_monitor_attributes_list_fallback)
1629 (Fw32_display_monitor_attributes_list): New functions.
1630 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1631
1632 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1633 if not defined.
1634 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1635
86dfb7a8
MA
16362013-07-04 Michael Albinus <michael.albinus@gmx.de>
1637
1638 * fileio.c (Qfile_notify_error): New error symbol.
1639
1640 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1641 * inotify.c (inotify_callback, symbol_to_inotifymask)
1642 (Finotify_add_watch, Finotify_rm_watch): Use it.
1643 (inotifyevent_to_event): Exchange order of cookie and file name.
1644 (Finotify_add_watch): Adapt docstring.
1645
1646 * lisp.h (Qfile_notify_error): Declare.
1647
2c1c974b
PE
16482013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1651 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1652 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1653 which did not work (see <http://bugs.gnu.org/14569#307>).
1654 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1655 && (!noninteractive || initialized)). This attempts to thread
1656 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1657
7a35b20f
JB
16582013-07-04 Juanma Barranquero <lekktu@gmail.com>
1659
1660 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1661 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1662
1ce5cd04
PE
16632013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1664
1665 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1666 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1667 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1668 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1669
57f8c490
PE
16702013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1673 Define to __sys_siglist.
1674
bcffb5ca
EZ
16752013-07-02 Eli Zaretskii <eliz@gnu.org>
1676
1677 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1678 word-wrap, so that overflow-newline-into-fringe would work in
1679 visual-line-mode. (Bug#2749)
1680 (move_it_in_display_line_to): When the last scanned display
1681 element fits exactly on the display line, and
1682 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1683 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1684 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1685 finding buffer position that corresponds to pixel coordinates,
1686 e.g. in buffer_posn_from_coords.
1687
2c41e781
JD
16882013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1689
1690 * process.c (handle_child_signal): Call catch_child_signal if
1691 NS_IMPL_GNUSTEP.
1692
c2418359
PE
16932013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1694
52a9bcae
PE
1695 Don't convert function pointers to void * and back.
1696 It isn't portable C, and it's easy enough to avoid.
1697 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1698 (make_save_value): Add support for SAVE_FUNCPOINTER.
1699 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1700 * print.c (print_object):
1701 Distinguish function from object pointers.
1702 * lisp.h (SAVE_FUNCPOINTER): New constant.
1703 (SAVE_SLOT_BITS): Adjust to it.
1704 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1705 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1706 (voidfuncptr): New typedef.
1707 (struct Lisp_Save_Value): New member data[0].funcpointer.
1708 (XSAVE_FUNCPOINTER): New function.
1709
c2418359
PE
1710 Simplify buildobj processing.
1711 * Makefile.in (buildobj.h): Make it a sequence of strings each
1712 followed by comma, rather than a single string. Put it into a
1713 .tmp file in case there's an error while generating it.
1714 (gl-stamp): Use .tmp for temp files.
1715 (mostlyclean): Clean .tmp files.
1716 * doc.c (buildobj): Move to just the routine that needs it.
1717 It's now an array of strings, so processing is simpler.
1718
8f43ce49
PE
17192013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1722 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1723 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1724 Invoke malloc_enable_thread even when not interactive.
1725 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1726 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1727 in this case, since the underlying bug has now been fixed.
1728
24827db9
JB
17292013-07-01 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1732 unlinking it (bug#14691).
1733
ef099a94
MN
17342013-06-30 Michal Nazarewicz <mina86@mina86.com>
1735
1736 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1737 before checking whether buffer is modified. This lets
1738 `kill-buffer-query-functions' cancel killing of the buffer or save
1739 its content before `kill-buffer' asks user the "Buffer %s
1740 modified; kill anyway?" question.
1741
9d3f2fc2
JD
17422013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1743
1744 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1745 Let the super performKeyEquivalent deal with them (Bug#14747).
1746
e6c6c8c7
PE
17472013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1748
1d71c1d9
PE
1749 * widget.c (resize_cb): Remove unused local.
1750
8f5f35cc
PE
1751 Do not use GTK 3 if it exists but cannot be compiled.
1752 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1753 * xterm.c (x_error_handler) [!USE_GTK]:
1754 Do not use GTK 3.
1755
e6c6c8c7
PE
1756 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1757
0ba54312
EZ
17582013-06-30 Eli Zaretskii <eliz@gnu.org>
1759
5d1c3286
EZ
1760 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1761 to the valid range of values. (Bug#14753)
1762
0ba54312
EZ
1763 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1764 when moving point by using the current glyph matrix. This avoids
1765 the need to force redisplay when this function is called in a
1766 loop.
1767
9c90cc06
PE
17682013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 Fix minor problems found by static checking.
1771 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1772 Redo the latter's body to sidestep GCC parenthesization warnings.
1773 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1774 * coding.c (detect_coding, detect_coding_system):
1775 * coding.h (struct undecided_spec):
1776 Use bool for boolean.
1777 * image.c (QCmax_width, QCmax_height): Now static.
1778 * xdisp.c (Fmove_point_visually): Remove unused local.
1779
4c672a0f
EZ
17802013-06-29 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (Fmove_point_visually): New function.
1783
c1ea3abf
JB
17842013-06-28 Kenichi Handa <handa@gnu.org>
1785
1786 * coding.h (define_coding_undecided_arg_index): New enum.
1787 (coding_attr_index): New members
1788 coding_attr_undecided_inhibit_null_byte_detection,
1789 coding_attr_undecided_inhibit_iso_escape_detection,
1790 coding_attr_undecided_prefer_utf_8.
1791 (undecided_spec): New struct.
1792 (struct coding_system): New member `undecided' of the member
1793 `spec'.
1794
1795 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1796 (detect_coding): Likewise.
1797 (detect_coding_system): Likewise.
1798 (Fdefine_coding_system_internal): New coding system properties
1799 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1800 :prefer-utf-8.
1801 (syms_of_coding): Adjust for coding_arg_undecided_max.
1802
ba3de9e6
PE
18032013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1804
1805 * image.c (x_from_xcolors): Remove unused local.
1806
547c9269
YM
18072013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1808
1809 Defer image data transfer between X client and server until actual
1810 display happens.
1811
1812 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1813 and `mask_img'.
1814
1815 * image.c (Destroy_Image): Remove.
1816 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1817 `mask_p', and `colors_p'. All uses changed.
1818 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1819 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1820 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1821 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1822 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1823 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1824 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1825 (image_get_x_image, image_unget_x_image): New functions or macros.
1826 (image_background, image_background_transparent, x_to_xcolors)
1827 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1828 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1829 instead of Destroy_Image.
1830 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1831 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1832 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1833 (imagemagick_load_image, svg_load_image): Use them instead of
1834 x_create_x_image_and_pixmap, and x_put_x_image followed by
1835 x_destroy_x_image, respectively.
1836 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1837 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1838 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1839 background_transparent fields.
1840 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1841 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1842
dae2f5ef
PE
18432013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1846 This mostly consists of undoing recent changes.
1847 * callproc.c (Fcall_process):
1848 * process.c (create_process):
1849 Do not worry about catching SIGCHLD here, undoing previous change.
1850 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1851 * process.c, process.h (catch_child_signal):
1852 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1853 * process.c (catch_child_handler): Don't worry about being called
1854 lazily and do not assume caller has blocked SIGCHLD, undoing
1855 previous change. Move first-time stuff back to
1856 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1857 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1858 set lib_child_handler if it's already initialized, which may
1859 help avoid problems on GNUStep.
1860
fa55d2aa
PE
18612013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1864 * callproc.c (Fcall_process):
1865 * process.c (create_process):
1866 Make sure SIGCHLD is caught before we fork,
1867 since Emacs startup no arranges to catch SIGCHLD.
1868 * process.c (lib_child_handler): Initialize to null, not to
1869 dummy_handler.
1870 (catch_child_signal): Allow self to be called lazily.
1871 Do nothing if it's already been called.
1872 Assume caller has blocked SIGCHLD (all callers do now).
1873 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1874 just before it's really needed.
1875 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1876 since it hasn't been caught yet.
1877
f3f9606c
LMI
18782013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1879
1880 * image.c (compute_image_size): New function to implement
1881 :max-width and :max-height.
1882 (imagemagick_load_image): Use it.
1883
c7041908
PE
18842013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1885
1886 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1887 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1888 Now extern.
1889 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1890 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1891 the SIGCHLD handler, since the code is not atomic and (due to glib)
1892 signals may be arriving now.
1893 * sysdep.c (init_signals): Do not catch child signals here;
1894 'main' now does that later, at a safer time.
1895
f86852b4
PE
18962013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1897
0dfeed58
PE
1898 Clean up SIGCHLD handling a bit (Bug#14569).
1899 * process.c, process.h (catch_child_signal):
1900 Now always extern, even if !NS_IMPL_GNUSTEP.
1901 * process.c (catch_child_signal): Move glib tickler here from
1902 init_process_emacs, so that it's done earlier in Emacs
1903 initialization. Also move the noninteractive && !initialized
1904 check here from init_process_emacs. This is all a bit cleaner for
1905 GNUish platforms, and I hope it works around the Cygwin bug.
1906 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1907 that glib signal handling is tickled before glib creates threads.
1908
f86852b4
PE
1909 * process.c (wait_reading_process_output): Avoid int overflow
1910 when reading more than 2 GiB total from a process.
1911
cbd6509c
PE
19122013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 * process.c (create_process): Handle a couple more cases,
1915 i.e., work even if new_argv and wait_child_setup[i] are cached.
1916 Use Fcall_process's style for volatile vars.
1917
9de1114a
AS
19182013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1919
1920 * process.c (create_process): Mark PROCESS volatile.
1921
fbe9e0b9
PE
19222013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 Use C99-style flexible array members if available.
1925 This avoids some subtle aliasing issues, which typically
1926 aren't a problem with GCC but may be a problem elsewhere.
1927 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1928 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1929 In either case, it uses a flexible array member rather than
1930 the old struct hack. All uses changed.
1931 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1932 Adjust to sdata reorganization.
1933 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1934 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1935 that ports better to pre-C99 non-GCC.
1936 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1937 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1938 as the latter has changed.
1939 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1940 and port better to pre-C99 GCC.
1941 * image.c (struct xpm_cached_color):
1942 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1943 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1944 Use FLEXIBLE_ARRAY_MEMBER.
1945 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1946 Move decl to top level so it gets checked against implementation.
1947 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1948 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1949
1fc71008
PE
19502013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 * syntax.c: Integer cleanups.
1953 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1954 All uses that need 0-or-2 changed to:
1955 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1956 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1957 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1958 (char_quoted, prev_char_comend_first, back_comment)
1959 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1960 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1961 Use bool for boolean.
1962 (update_syntax_table, skip_chars, skip_syntaxes):
1963 Prefer int to unsigned when either will do.
1964 (back_comment): Return boolean success flag, like forw_comment,
1965 instead of positive-or-minus-1 (which might have overflowed int anyway).
1966 Don't stuff ptrdiff_t into int.
1967 (syntax_spec_code, syntax_code_spec): Now const.
1968 (Fmatching_paren, scan_lists, scan_sexps_forward):
1969 Use enum syntaxcode for syntax code.
1970 (Fmatching_paren): Check that arg is a character, not just an integer.
1971 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1972 (Finternal_describe_syntax_value): Omit no-longer-needed
1973 comparison to 0.
1974 (skip_chars): Use char, not unsigned char, when the distinction
1975 doesn't matter.
1976 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1977 * bytecode.c (exec_byte_code):
1978 * syntax.c (syntax_spec_code, Fchar_syntax)
1979 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1980 (init_syntax_once):
1981 * syntax.h (SYNTAX_WITH_FLAGS):
1982 Omit unnecessary casts.
1983
b932cad7
EZ
19842013-06-20 Eli Zaretskii <eliz@gnu.org>
1985
1986 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1987 line dimensions here, to avoid race conditions with the main
1988 thread. (Bug#14062, bug#14630, bug#14669)
1989
1990 * w32term.c (w32_draw_window_cursor): Compute the header line and
1991 mode line dimensions here.
1992 <w32_system_caret_window, w32_system_caret_hdr_height>:
1993 <w32_system_caret_mode_height>: New variables.
1994
1995 * w32term.h: Declare them.
1996
89561f72
PE
19972013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1998
5013fc08
PE
1999 * alloc.c (die): Move "assertion failed" string here ...
2000 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2001 COND when SUPPRESS_CHECKING. This shrinks the executable text
2002 size by 0.8% to 2.2% when configured with --enable-checking,
2003 depending on optimization flags (GCC 4.8.1 x86-64).
2004
89561f72
PE
2005 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2006
763a086d 20072013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2008
2009 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2010 base is 2; this is more accurate.
2011
983aeb9a
JB
20122013-06-19 Juanma Barranquero <lekktu@gmail.com>
2013
2014 * sound.c (string_default): Move to !WINDOWSNT section.
2015 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2016
178ba3e6
PE
20172013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2018
bbc51b15
PE
2019 * sound.c: Integer cleanups.
2020 Remove unnecessary forward decls.
2021 (struct sound_device): The 'file' member is now a Lisp_Object, not
2022 a char *, so that we needn't invoke alloca on a huge size.
2023 (Fplay_sound_internal): Adjust to this.
2024 (string_default): New function.
2025 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2026 Use it to adjust to the struct sound_device change.
2027 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2028 (be2hs) [0]: Remove.
2029
178ba3e6
PE
2030 * syntax.c (skip_chars): Don't use uninitialized storage
2031 when searching a multibyte buffer for characters that are not in a
2032 unibyte string that contains non-ASCII characters.
2033
69f60cdc
JD
20342013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2035
2036 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2037 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2038
0d6224d4
PE
20392013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2040
2041 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2042
3c542890
KH
20432013-06-18 Kenichi Handa <handa@gnu.org>
2044
f7e3f7cd
KH
2045 * font.c (Ffont_spec): Signal an error for an invalid font name
2046 (Bug#14648).
3c542890 2047
9349e5f7
PE
20482013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2051 In particular this ports to 32-bit sparc Sun cc.
2052 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2053 array with a dummy element at specpdl[-1], so that its address can
2054 be taken portably.
2055 (unbind_to): Do not copy the binding; not needed, now that we
2056 copy old_value in the one place where the copy is needed.
2057 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2058 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2059 (union specbinding): Rename from struct specbinding. Redo layout
2060 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2061 which is not portable. With Sun C 5.12 32-bit sparc, the
2062 declaration causes nargs to be an unsigned bitfield, a behavior
2063 that the C standard allows; but Emacs wants nargs to be signed.
2064 The overall type is now a union of structures rather than a
2065 structure of union of structures, and the 'kind' member is now a
2066 bitfield, so that the overall type doesn't grow. All uses changed.
2067 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2068
0a4df6a5
PE
20692013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2070
ec6ecaad
PE
2071 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2072 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2073
0a4df6a5
PE
2074 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2075
7bfe8dbc
EZ
20762013-06-17 Eli Zaretskii <eliz@gnu.org>
2077
2078 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2079 unless we know that the window w's frame is a frame object.
2080 Another attempt at solving bug#14062 and bug#14630.
2081
708e05f6
LMI
20822013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2083
2084 * textprop.c (property_set_type): New enum.
2085 (add_properties): Allow appending/prepending text properties.
2086 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2087 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2088 add_text_properties_1.
2089 (Fadd_face_text_property): New function that calls
2090 add_text_properties_1.
2091
84575e67
PE
20922013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 Move functions from lisp.h to individual modules when possible.
2095 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2096 * alloc.c (XFLOAT_INIT, set_symbol_name):
2097 * buffer.c (CHECK_OVERLAY):
2098 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2099 (set_char_table_parent):
2100 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2101 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2102 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2103 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2104 (set_blv_valcell):
2105 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2106 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2107 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2108 (backtrace_args, backtrace_debug_on_exit):
2109 * floatfns.c (CHECK_FLOAT):
2110 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2111 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2112 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2113 (set_hash_index_slot):
2114 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2115 * marker.c (CHECK_MARKER):
2116 * textprop.c (CHECK_STRING_OR_BUFFER):
2117 * window.c (CHECK_WINDOW_CONFIGURATION):
2118 Move here from lisp.h, and make these functions static rather than
2119 extern inline.
2120 * buffer.c (Qoverlayp):
2121 * data.c (Qsubrp):
2122 * fns.c (Qhash_table_p):
2123 * window.c (Qwindow_configuration_p):
2124 Now static.
2125 * lisp.h: Remove the abovementioned defns and decls.
2126
44e18199 2127 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2128 In lisp.h, prefer functions to function-like macros, and
2129 constants to object-like macros, when either will do. This:
2130 . simplifies use, as there's no more need to worry about
2131 arguments' side effects being evaluated multiple times.
2132 . makes the code easier to debug on some platforms.
2133 However, when using gcc -O0, keep using function-like macros
2134 for a few critical operations, for performance reasons.
2135 This sort of thing isn't needed with gcc -Og, but -Og
2136 is a GCC 4.8 feature and isn't widely-enough available yet.
2137 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2138 Remove enum lsb_bits; no longer needed.
2139 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2140 * buffer.c (Qoverlap):
2141 * data.c (Qsubrp):
2142 * fns.c (Qhash_table_p):
2143 Now extern, so lisp.h can use these symbols.
2144 * dispextern.h: Include character.h, for MAX_CHAR etc.
2145 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2146 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2147 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2148 (GLYPH_CODE_P): Move here from lisp.h.
2149 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2150 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2151 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2152 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2153 XUNTAG now returns void *.
2154 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2155 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2156 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2157 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2158 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2159 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2160 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2161 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2162 New macros, renamed from their sans-lisp_h_ counterparts.
2163 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2164 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2165 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2166 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2167 If compiling via GCC without optimization, define these as macros
2168 in addition to inline functions.
2169 To disable this, compile with -DINLINING=0.
2170 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2171 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2172 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2173 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2174 (INTMASK, VALMASK): Now macros, since static values cannot be
2175 accessed from extern inline functions.
2176 (VALMASK): Also a constant, for benefit of old GDB.
2177 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2178 is INTEGERP, which can fold it in.
5165d44a 2179 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2180 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2181 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2182 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2183 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2184 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2185 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2186 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2187 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2188 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2189 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2190 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2191 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2192 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2193 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2194 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2195 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2196 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2197 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2198 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2199 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2200 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2201 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2202 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2203 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2204 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2205 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2206 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2207 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2208 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2209 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2210 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2211 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2212 Now functions.
2213 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2214 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2215 (VALMASK): Define in one place rather than in two, merging the
2216 USE_LSB_TAG parts; this is simpler.
2217 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2218 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2219 Move up, to avoid use before definition.
2220 Also include "globals.h" earlier, for the same reason.
2221 (make_natnum): New function.
2222 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2223 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2224 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2225 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2226 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2227 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2228 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2229 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2230 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2231 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2232 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2233 (Qwindow_configuration_p, Qimage): New forward declarations.
2234 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2235 (STRING_COPYIN): Remove; unused.
2236 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2237 (xcar_addr, xcdr_addr): New functions. All uses changed.
2238 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2239 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2240 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2241 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2242 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2243 (TYPE_RANGED_INTEGERP): Simplify.
2244 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2245 (setlocale, fixup_locale, synchronize_system_messages_locale)
2246 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2247 Now empty functions, not macros.
2248 (functionp): Return bool, not int.
2249 * window.c (Qwindow_configuration_p): Now extern,
2250 so window.h can use it.
2251 * window.h (Qwindowp): Move decl back to lisp.h.
2252
9583ec36
EZ
22532013-06-15 Eli Zaretskii <eliz@gnu.org>
2254
2255 * xdisp.c (Fline_pixel_height): New function, required for solving
2256 bug #14567.
2257
210272ce
PE
22582013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2261
de0503df
SM
22622013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2263
2264 * lread.c (syms_of_lread):
2265 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2266
afbfe143
KD
22672013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2268
2269 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2270
d177e213
XF
22712013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2272
2273 * fileio.c (expand_file_name): Doc fix.
2274
05e3e412
PE
22752013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2276
f7394b12
PE
2277 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2278 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2279 Wait for self, not for 0. This can't hurt on GNU or similar
2280 system, and may help with Cygwin.
2281
05e3e412
PE
2282 * keyboard.c: Don't use PROP (...) as an lvalue.
2283 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2284 Use set_prop (A, B), not PROP (A) = B.
2285
17dd3097
EZ
22862013-06-10 Eli Zaretskii <eliz@gnu.org>
2287
2288 * xdisp.c (get_it_property): Use it->window instead of generating
2289 a Lisp object from it->w.
2290
52fab9c9
EZ
22912013-06-09 Eli Zaretskii <eliz@gnu.org>
2292
2293 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2294 get-char-property the window that is being rendered, instead of
2295 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2296 (compute_display_string_pos): When W is NULL, use the current
2297 buffer as the object to pass to get-char-property.
2298 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2299 pointer member of the bidi iterator, since no window is pertinent
2300 to this function.
52fab9c9 2301
5bf97bfc
EZ
23022013-06-08 Eli Zaretskii <eliz@gnu.org>
2303
2304 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2305 being displayed, and pass it to compute_display_string_pos.
2306 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2307 (bidi_paragraph_init): All callers changed.
2308
2309 * xdisp.c (init_from_display_pos, init_iterator)
2310 (handle_single_display_spec, next_overlay_string)
2311 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2312 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2313 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2314 (compute_display_string_pos): Accept additional argument, the
2315 window being displayed, and pass it to Fget_char_property.
2316 (Bug#14575)
2317
2318 * dispextern.h (struct bidi_it): New member w, the window being
2319 displayed.
2320 (compute_display_string_pos): Adjust prototype.
2321
5de0e011
JD
23222013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2323
e7b41c4c 2324 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2325
2326 * process.c (wait_reading_process_output): Check for NS before GLIB.
2327 GLIB may be linked in due to rsvg, but ns_select must be called.
2328
5de0e011
JD
2329 * xgselect.c (xg_select): Remove call to window_system_available
2330 and g_main_context_pending at the top, so Gdk events (i.e. file
2331 notify) are processed when Emacs is started with -nw.
2332
a822acff
EZ
23332013-06-07 Eli Zaretskii <eliz@gnu.org>
2334
2335 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2336 (ctagsfiles3): New variable, includes only *.m files.
2337 (TAGS): Use an explicit language name in the regular expressions,
2338 to avoid transformation of '/SOMETHING' by MSYS to
2339 'c:\MSYS\SOMETHING'.
2340
6c0a9ed1
RC
23412013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2342
2343 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2344
9ef6111b
EZ
23452013-06-06 Eli Zaretskii <eliz@gnu.org>
2346
2347 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2348 still need to set the mouse pointer shape and activate help-echo.
2349 (Bug#14558)
2350
7d300d64
PE
23512013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 A few porting etc. fixes for the new file monitor code.
2354 See the thread containing
2355 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2356 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2357 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2358 (dir_monitor_callback, Fgfile_rm_watch):
2359 Use assq_no_quit instead of Fassoc, for speed.
2360 (dir_monitor_callback, Fgfile_rm_watch):
2361 eassert that the monitor is a fixnum.
2362 (dir_monitor_callback): No need for CDR_SAFE.
2363 Simplify building of lisp with alternative tails.
2364 (Fgfile_add_watch, Fgfile_rm_watch):
2365 Do not assume glib functions set errno reliably on failure.
2366 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2367 and signal an error otherwise.
2368 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2369 Use Fdelq instead of Fdelete, for speed.
2370
817ebfcf
EZ
23712013-06-05 Eli Zaretskii <eliz@gnu.org>
2372
2373 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2374 don't insist on being invoked on a highlighted tool-bar button.
2375 Avoids losing tool-bar functionality when mouse-highlight is nil.
2376 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2377 Don't highlight when mouse-highlight is nil.
2378 (note_mouse_highlight): When mouse-highlight is nil, don't return
2379 right away; instead, run tool-bar and mode-line highlight
2380 subroutine, clear any existing highlight, and revert the mouse
2381 pointer to its default shape. (Bug#14558)
2382
55577e7c
SM
23832013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2384
2385 * lisp.mk (lisp): Add prog-mode.el.
2386
f019a684
PE
23872013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2390 * process.c (dummy_handler): New function.
2391 (lib_child_handler): New static var.
2392 (handle_child_signal): Invoke it.
2393 (catch_child_signal): If a library has set up a signal handler,
2394 save it into lib_child_handler.
2395 (init_process_emacs): If using glib and not on Windows, tickle glib's
2396 child-handling code so that it initializes its private SIGCHLD handler.
2397 * syssignal.h (SA_SIGINFO): Default to 0.
2398 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2399 31; it should no longer be needed now.
2400
90db8702
MA
24012013-06-05 Michael Albinus <michael.albinus@gmx.de>
2402
2403 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2404
2405 * gfilenotify.c (globals_of_gfilenotify): New function.
2406 (syms_of_gfilenotify): Move global initialization there.
2407
2408 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2409
bfa3acd6
SM
24102013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2411
2412 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2413 * keyboard.c (menu_bar_items, tool_bar_items):
2414 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2415 not override local keymaps any more.
2416
ba59bd80
EZ
24172013-06-04 Eli Zaretskii <eliz@gnu.org>
2418
2419 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2420
7f203aa1
EZ
24212013-06-03 Eli Zaretskii <eliz@gnu.org>
2422
9337e206
EZ
2423 * w32console.c (initialize_w32_display): Return the dimensions of
2424 the console window via 2 additional arguments, not via the current
2425 frame. This avoids crashes due to overrunning the bounds of
2426 frame's decode_mode_spec_buffer, which is not resized following
2427 the change of the frame dimensions from the initial 10x10.
2428
2429 * w32term.h (w32_initialize_display_info): Adjust prototype.
2430
2431 * term.c (init_tty): Take dimensions of the frame from the values
2432 returned by initialize_w32_display.
2433
7f203aa1
EZ
2434 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2435 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2436 (LIBES): Add $(GFILENOTIFY_LIBS).
2437
2438 * w32inevt.c (handle_file_notifications): Add dummy implementation
2439 for !HAVE_W32NOTIFY.
2440
2441 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2442
55a87246
JD
24432013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2444
2445 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2446
2447 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2448
2449 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2450
3d5ee10a
PE
24512013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 Fix minor problems found by static checking.
2454 * data.c (pure_write_error):
2455 Use xsignal2, not Fsignal, as Fsignal might return.
2456 * eval.c (set_backtrace_debug_on_exit): Now static.
2457 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2458 No longer inline. EXTERN_INLINE is needed only for functions
2459 defined in .h files. Reindent function header as per GNU style.
2460 (backtrace_p, backtrace_top, backtrace_next):
2461 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2462 compiler or linker. Add extern decls to pacify gcc -Wall.
2463 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2464 Now static.
2465 * frame.c (free_monitors): Define only on platforms that need it.
2466 * nsterm.m (ns_term_init):
2467 * process.c (catch_child_signal):
2468 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2469 defined on all porting targets these days.
2470 * process.c, process.h (catch_child_signal):
2471 Make it extern only if NS_IMPL_GNUSTEP is defined.
2472
e2d8a6f0
EZ
24732013-06-03 Eli Zaretskii <eliz@gnu.org>
2474
2475 * w32.c (gettimeofday): Make the signature identical to prototype
2476 in nt/inc/sys/time.h.
2477
a8a7c5f6
SM
24782013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2479
2480 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2481 .gdbinit.
2482
2483 * keyboard.c (safe_run_hooks_error): Improve error message.
2484
2485 * data.c (pure_write_error): Add `object' argument.
2486 * puresize.h (CHECK_IMPURE): Use it.
2487
c9628c79
MA
24882013-06-03 Michael Albinus <michael.albinus@gmx.de>
2489
2490 * Makefile.in (NOTIFY_OBJ): New variable.
2491 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2492
2493 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2494 Call syms_of_gfilenotify.
2495
2496 * gfilenotify.c: New file.
2497
2498 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2499 and Qfile_w32notify.
2500 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2501 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2502
2503 * lisp.h: Declare syms_of_gfilenotify.
2504
2505 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2506
2f592f95
SM
25072013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2508
2509 Merge the specpdl and backtrace stacks. Make the structure of the
2510 specpdl entries more obvious via a tagged union of structs.
2511 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2512 (enum specbind_tag): New enum.
2513 (struct specbinding): Make it a tagged union of structs.
2514 Add a case for backtrace records.
2515 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2516 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2517 (backtrace_debug_on_exit): New accessors.
2518 (struct backtrace): Remove.
2519 (struct catchtag): Remove backlist field.
2520 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2521 Move to eval.c.
2522 (Flocal_variable_p): Speed up the common case where the binding is
2523 already loaded.
2524 * eval.c (backtrace_list): Remove.
2525 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2526 (set_backtrace_args, set_backtrace_nargs)
2527 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2528 (backtrace_next): New functions.
2529 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2530 (unwind_to_catch, internal_lisp_condition_case)
2531 (internal_condition_case, internal_condition_case_1)
2532 (internal_condition_case_2, internal_condition_case_n): Don't bother
2533 with backtrace_list any more.
2534 (Fsignal): Adjust to new backtrace format.
2535 (grow_specpdl): Move up.
2536 (record_in_backtrace): New function.
2537 (eval_sub, Ffuncall): Use it.
2538 (apply_lambda): Adjust to new backtrace format.
2539 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2540 data.c.
2541 (specbind): Adjust to new specpdl format. Simplify.
2542 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2543 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2544 backtrace format.
2545 (mark_backtrace): Remove.
2546 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2547 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2548 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2549 Use mark_specpdl.
2550 * profiler.c (record_backtrace): Use get_backtrace.
2551 (handle_profiler_signal): Use backtrace_top_function.
2552 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2553 accessor functions.
2554
c0342369
JD
25552013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2556
2557 * process.h (catch_child_signal): Declare.
2558
2559 * process.c (catch_child_signal): New function.
2560 (init_process_emacs): Call it.
2561
2562 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2563 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2564 NS_IMPL_COCOA.
2565 (x_set_cursor_type): Remove declaration.
2566 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2567 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2568 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2569 (ns_get_color): Use F suffix on float.
2570 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2571 (ns_get_rgb_color): Remove.
2572 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2573 (note_mouse_movement): x and y are CGFloat.
2574 (ns_draw_fringe_bitmap): Remove unused rowY.
2575 Change #if to COCOA && >= 10_6.
2576 (ns_draw_window_cursor): Remove unused overspill.
2577 (ns_draw_underwave): width and x are EamcsCGFloat.
2578 (ns_draw_box): thickness is CGFloat.
2579 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2580 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2581 if not in main thread.
2582 (ns_get_pending_menu_title, ns_check_menu_open)
2583 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2584 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2585 (sendFromMainThread:): New method.
2586 (changeFont:): size is CGFloat.
2587 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2588 Disable warning about permanent text.
2589 (characterIndexForPoint:): Adjust return type depending on GNUStep
2590 version.
2591 (mouseDown:): delta is CGFloat.
2592 (updateFrameSize): Remove unised variable f.
2593 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2594 Cast float to EmacsCGFloat.
2595 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2596 also to -1 when restoring.
2597 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2598 inside NS_IMPL_COCOA.
2599 (toggleFullScreen:): Put call to toggleFullScreen inside
2600 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2601 (setPosition:portion:whole:): por is CGFloat.
2602 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2603 (mouseDown:): Use CGFloat.
2604 (mouseDragged:): Remove unised variable edge.
2605 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2606
2607 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2608 of CGFloat differs.
2609 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2610 when NS_IMPL_GNUSTEP.
2611 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2612 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2613 (EmacsToolbar): Add clearAll. Add tag argument to
2614 addDisplayItemWithImage.
2615 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2616
2617 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2618
2619 * nsmenu.m (ns_update_menubar): Make static.
2620 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2621 (fillWithWidgetValue:): Add cast to SEL for setAction.
2622 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2623 (update_frame_tool_bar): Update code for GNUStep.
2624 (clearAll): New method.
2625 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2626 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2627 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2628 call to insertItemWithItemIdentifier.
2629 (validateVisibleItems): Fix indentation.
2630 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2631 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2632 UtilityWindow to aStyle, remove call to setStyleMask.
2633
2634 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2635
2636 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2637 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2638 Use F suffix on floats.
2639 (ns_char_width): Returns CGFloat.
2640 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2641 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2642 DPSxshow.
2643 (ns_glyph_metrics): CGFloat instead of float.
2644
a0eb10b3
JB
2645 * nsfns.m (x_set_foreground_color, x_set_background_color):
2646 Use EmacsCGFloat.
2647 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2648 remove unused variables.
2649 (Fns_read_file_name): Keep track if panel is for save.
2650 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2651 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2652 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2653 Just return the input if GNUStep.
c0342369
JD
2654 (x_screen_planes): Remove.
2655 (Fxw_color_values): Use EmacsCGFloat
2656 (Fns_display_monitor_attributes_list): Only get screen number for
2657 Cocoa.
ef099a94 2658 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2659 EmacsSavePanel.
2660 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2661 ns_directory_from_panel.
2662
da9aff11
PE
26632013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2664
2665 * process.c (handle_child_signal): Also use WCONTINUED.
2666 This is so that list-processes doesn't mistakenly list the process
2667 as stopped, when the process has actually been continued and is
2668 now running.
2669
0e64479a
PE
26702013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2671
fc186a96
PE
2672 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2673 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2674 not already configured.
2675
0e64479a
PE
2676 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2677
38b787fa
EZ
26782013-05-29 Eli Zaretskii <eliz@gnu.org>
2679
2680 * Makefile.in (mostlyclean): Remove *.res files.
2681
22513e52
SM
26822013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2683
2684 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2685 a buffer (bug#8447).
2686
6ef3db10
EZ
26872013-05-27 Eli Zaretskii <eliz@gnu.org>
2688
2689 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2690 display vector, and we backtrack, handle the case that the
2691 previous character position is also displayed from a display
2692 vector or covered by a display string or image. (Bug#14476)
2693
6799bb26
JD
26942013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2695
2696 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2697 (struct MonitorInfo, free_monitors): Remove.
2698 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2699 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2700 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2701 Qframes, Qsource.
2702
2703 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2704 (struct MonitorInfo, free_monitors): Remove.
2705 (ns_screen_name): Make static.
2706 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2707 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2708 Qframes, Qsource.
2709
2710 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2711 (struct MonitorInfo): New struct.
2712 (free_monitors, make_monitor_attribute_list): Declare.
2713
22513e52
SM
2714 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2715 New Lisp_Object:s.
6799bb26
JD
2716 (free_monitors, make_monitor_attribute_list): New functions.
2717 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2718 Qsource.
2719
38cd43eb
XF
27202013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2721
2722 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2723
2af0948d
SM
27242013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2725
a7eb9b0f
SM
2726 * keyboard.c: Apply keyboard decoding only to events that come directly
2727 from the tty, not from unread-command-events (bug#14368).
2728 (read_event_from_main_queue): New function, extracted from read_char).
2729 (read_decoded_char): Remove.
2730 (read_decoded_event_from_main_queue): New function to replace it.
2731 (read_char): Use it.
2732 (read_key_sequence): Use read_char rather than read_decoded_char.
2733
2af0948d
SM
2734 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2735
1413e9a5
BR
27362013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2737
2738 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2739
e6d2f155
KH
27402013-05-22 Kenichi Handa <handa@gnu.org>
2741
2742 The following changes are to fix the setting of
2743 buffer-file-coding-system on, for instance, C-x RET c unix RET
2744 _FILE_OF_DOS_EOL_TYPE_ RET.
2745
2746 * coding.h (struct coding_system): New member detected_utf8_chars.
2747
2748 * coding.c (detect_coding_utf_8): Count characters and check EOL
2749 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2750 BOM is there.
2751 (setup_coding_system): Do not initialize coding->head_ascii.
2752 (check_ascii): Do not set coding->eol_seen but update it. Do not
2753 call adjust_coding_eol_type here.
1413e9a5
BR
2754 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2755 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2756 of the found coding-system.
2757 (decode_coding_gap): Cancel previous change. Utilize the
2758 character numbers counted by detect_coding_utf_8. Fix detection
2759 of BOM for utf-8.
2760
ab56a6f4 27612013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2762
2763 * search.c (looking_at_1): Only set last_thing_searched if the match
2764 changed the match-data (bug#14281).
2765
ecc3c6ed
DA
27662013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2767
2768 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2769 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2770 (move_it_vertically_backward): Likewise.
2771
5ba8bf35
YM
27722013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2773
2774 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2775 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2776 (Fx_display_mm_width, Fx_display_mm_height):
2777 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2778
91e8418b 2779 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2780 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2781 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2782 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2783 (Fx_display_backing_store, Fx_display_visual_class)
2784 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2785 (Fx_display_grayscale_p, Fx_display_pixel_width)
2786 (Fx_display_pixel_height, Fx_display_planes)
2787 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2788 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2789 (Fx_display_mm_width, Fx_display_mm_height)
2790 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2791 height for all physical monitors as in X11.
2792
fc30d803
SM
2793 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2794 Return pixel width or height for all physical monitors as in X11.
91e8418b 2795
31ff141c
PE
27962013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2797
2798 Port --enable-gcc-warnings to clang.
2799 * bytecode.c (exec_byte_code):
2800 * regex.c:
2801 Redo diagnostic pragmas to pacify clang, too.
2802 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2803 * editfns.c (Fencode_time):
2804 * fileio.c (file_accessible_directory_p):
2805 * font.c (font_unparse_xlfd):
2806 Use '&"string"[index]' instead of '"string" + (index)'.
2807 * undo.c (user_error): Remove; unused.
2808
df065a0b
EZ
28092013-05-16 Eli Zaretskii <eliz@gnu.org>
2810
04d360e7
EZ
2811 * insdel.c (insert_1_both): Document the arguments, instead of
2812 referring to insert_1, which no longer exists.
2813
5bb98290
EZ
2814 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2815 some window, increment windows_or_buffers_changed, so that
2816 *Messages* display in that window is updated. (Bug#14408)
2817
df065a0b
EZ
2818 * w32.c: Include epaths.h.
2819 (init_environment): Use cmdproxy.exe without leading directories.
2820 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2821 case.
2822 (gettimeofday): Adjust signature and return value to Posix
2823 expectations.
2824
2825 * unexw32.c (open_output_file): Delete the existing emacs.exe
2826 before creating it, to break the hard link to the versioned
2827 executable.
2828
2829 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2830 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2831 (FIRSTFILE_OBJ): New variables.
2832 (W32_RES): Rename to EMACSRES. All users changed.
2833 (base_obj): Use $(CM_OBJ).
2834 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2835 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2836 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2837 $(W32_RES_LINK) before $(LIBES).
2838 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2839
1aa8d505
SM
28402013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2841
6e911150
SM
2842 * makefile.w32-in (DOC): Use just "DOC".
2843
2844 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2845
1aa8d505
SM
2846 * process.c: Export default filters and sentinels to Elisp.
2847 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2848 New constants.
2849 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2850 (Fset_process_sentinel, Fformat_network_address):
2851 Default to them instead of nil.
2852 (server_accept_connection): Sentinels can't be nil any more.
2853 (read_and_dispose_of_process_output): New function, extracted from
2854 read_process_output.
2855 (read_process_output): Use it; filters can't be nil.
2856 (Finternal_default_process_filter): New function, extracted from
2857 read_process_output.
2858 (exec_sentinel_unwind): Remove function.
2859 (exec_sentinel): Don't zilch sentinel while running.
2860 (status_notify): Sentinels can't be nil.
2861 (Finternal_default_process_sentinel): New function extracted from
2862 status_notify.
2863 (setup_process_coding_systems): Default filter is not nil any more.
2864 (syms_of_process): Export new Elisp functions and initialize
2865 new constants.
2866 * lisp.h (make_lisp_proc): New function.
2867
5ac2eb34
SM
28682013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2869
2870 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2871
eda9c7d7
EZ
28722013-05-14 Eli Zaretskii <eliz@gnu.org>
2873
2874 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2875 unless we know that the window w is a leaf window.
2876 Another attempt at solving bug#14062.
eda9c7d7 2877
8fdeaad5
JD
28782013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2879
2880 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2881 fdesc (Bug#14375).
2882
44aa9ee6
PE
28832013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2884
2885 * image.c (gif_load): Check that subimages fit (Bug#14345).
2886
759fd763
SM
28872013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2888
2889 * lread.c (skip_dyn_eof): New function.
2890 (read1): Use it to skip the end of a file in response to #@00.
2891
2892 * doc.c (get_doc_string): Slightly relax the sanity checking.
2893
4465bfb4
JD
28942013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2895
2896 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2897 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2898 (MonitorInfo): New struct.
2899 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2900 (Fns_display_monitor_attributes_list): New functions.
2901 (display-usable-bounds): Remove.
2902 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2903 Qsource.
2904
7583e2a0
PE
29052013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2906
2907 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2908 (GTK_CHECK_VERSION): New macro, if not already defined.
2909 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2910 replaced by GTK_CHECK_VERSION.
2911
ad75d77e
PE
29122013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2913
2914 * xterm.h (GTK_PREREQ): New macro.
2915 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2916 to use this macro instead, for consistency and clarity.
2917
07525f77
EZ
29182013-05-08 Eli Zaretskii <eliz@gnu.org>
2919
2920 * xdisp.c (row_for_charpos_p): New function, with code of
2921 cursor_row_p, but accepts an additional argument CHARPOS instead
2922 of using a hardcoded PT.
2923 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2924 (row_containing_pos): Call row_for_charpos_p instead of partially
2925 doing the same. Fixes cursor positioning under longlines-mode
2926 when longlines-show-effect includes more than one newline, when
2927 moving the cursor vertically up.
2928
d901fc8d
JB
29292013-05-08 Juanma Barranquero <lekktu@gmail.com>
2930
2931 * makefile.w32-in (ACL_H): New macro.
2932 ($(BLD)/fileio.$(O)): Update dependencies.
2933
f269bc61
PE
29342013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2935
e7b41c4c 2936 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2937 * Makefile.in (LIB_ACL): New macro.
2938 (LIBACL_LIBS): Remove.
2939 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2940 * fileio.c: Include <acl.h>.
2941 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2942 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2943 !acl_errno_valid.
2944 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2945 it ourselves.
2946
f269bc61
PE
2947 * unexelf.c: Don't assume ElfW (Half) fits in int.
2948 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2949 when dealing with ElfW (Half) values, since they can exceed 2**31
2950 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2951 (entry_address): Omit unused NUM arg. All uses changed.
2952
a261c53e
JL
29532013-05-07 Juri Linkov <juri@jurta.org>
2954
2955 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2956 to the string converted from number with `Fnumber_to_string'.
2957 (Bug#14254)
2958
2b66427d
PE
29592013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2962 This fixes a problem introduced by my previous change.
2963
15acfe41
GM
29642013-05-07 Glenn Morris <rgm@gnu.org>
2965
2966 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2967
5ea03bf5
JD
29682013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2969
2970 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2971
e0c9d565
PE
29722013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2973
2974 Static checking by GCC 4.8.0.
2975 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2976 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2977 (x_get_monitor_attributes_fallback)
2978 (x_get_monitor_attributes_xinerama)
2979 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2980 Define only if USE_GTK.
2981 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2982 (x_get_monitor_attributes_fallback): Omit unused locals.
2983 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2984 Use double, not float, to avoid mixed-mode floating point arithmetic.
2985
4e3f9230
YM
29862013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2987 Jan Djärv <jan.h.d@swipnet.se>
2988
2989 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2990 (XINERAMA_CFLAGS): New macros.
2991 (ALL_CFLAGS, LIBES): Use them.
2992
2993 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2994 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2995 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2996 (syms_of_xfns): DEFSYM them.
2997 (struct MonitorInfo): New struct.
2998 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2999 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3000 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3001 (x_get_monitor_attributes_xinerama): New functions.
3002 (Fx_display_monitor_attributes_list): New primitive.
3003 (syms_of_xfns): Defsubr it.
3004
3005 * xterm.h (x_display_info): Add Xatom_net_workarea and
3006 Xatom_net_current_desktop.
3007
3008 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3009 and dpyinfo->Xatom_net_current_desktop.
3010
05839b6a
EZ
30112013-05-06 Eli Zaretskii <eliz@gnu.org>
3012
3013 * xdisp.c (pos_visible_p): Use the special code for finding the
3014 beginning of a display property or overlay for any "replacing"
3015 display property, not just for display strings. This solves
3016 incorrect reporting of position by posn-at-point. (Bug#14241)
3017
dc4a2ee0
PE
30182013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3019
5ee94506
PE
3020 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3021 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3022 Verify that ElfW (Half) fits in int.
3023 (fatal): Use same signature as lisp.h.
3024 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3025 configure and build with -DUNEXELF_DEBUG without worrying about
3026 other modules that use DEBUG.
3027 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3028 possibly-wide integers now uses it instead of plain fprintf.
3029 (entry_address): New function, which avoids problems with 32-bit
3030 overflow on 64-bit hosts.
3031 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3032 (round_up): Don't assume the remainder fits in int.
3033 (find_section): Use bool for boolean. Simplify debug code.
3034 (unexec): Don't assume file sizes fit in int or size_t.
3035 Omit unnecessary trailing newline in 'fatal' format.
3036 Use strerror rather than outputting decimal error number.
3037 Remove unused code when emacs is not defined;
3038 this file relies on Emacs now.
3039 Don't assume e_phnum and e_shnum are positive.
3040
dc4a2ee0
PE
3041 * regex.c: Fix problems when DEBUG is defined.
3042 (extract_number, extract_number_and_incr): Define regardless of
3043 whether DEBUG is defined; that's simpler and makes the code less
3044 likely to go stale in the normal case when DEBUG is not defined.
3045 Return int rather than taking an int * arg. All callers changed.
3046 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3047 Remove, replacing with ...
3048 (DEBUG_PRINT): New macro. All callers changed.
3049 (DEBUG_COMPILES_ARGUMENTS): New macro.
3050 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3051 (print_compiled_pattern, print_double_string) [DEBUG]:
3052 Use prototype rather than old-style definition.
3053 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3054 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3055 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3056 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3057 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3058 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3059 This matters only when DEBUG is defined.
3060
14c7ed05
EZ
30612013-05-05 Eli Zaretskii <eliz@gnu.org>
3062
3063 * xdisp.c (set_iterator_to_next): Set the
3064 ignore_overlay_strings_at_pos_p flag only if we are _really_
3065 iterating over an overlay string, as indicated by the
3066 current.overlay_string_index member. (Bug#14306)
3067
e6076b1b
JD
30682013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3069
3070 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3071 to where it is used, to avoid autorelease issues (Bug#14050).
3072
cbee2131
PE
30732013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3076 * fileio.c (syms_of_fileio): Implement this.
3077 * filelock.c (create_lock_file): If symbolic links don't work, so
3078 we use a regular file as a lock file, do not fsync the lock file;
3079 it's not needed.
3080
30c7e542
SM
30812013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3082
3083 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3084 (syms_of_minibuf): Adjust accodingly.
3085 * lread.c (Fread):
3086 * callint.c (Fcall_interactively): Adjust calls accordingly.
3087
5bebd186
EZ
30882013-05-04 Eli Zaretskii <eliz@gnu.org>
3089
3090 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3091 w->contents is a buffer before computing everything else.
3092 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3093
3094 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3095 assertion violations. (Bug#14062)
3096
0fb0a4f3
DR
30972013-05-01 David Reitter <david.reitter@gmail.com>
3098
3099 * nsfns.m (ns_tooltip): Initialize.
3100
9e63b4a5
EZ
31012013-04-28 Eli Zaretskii <eliz@gnu.org>
3102
3103 * coding.c (decode_coding_gap): Don't remove the character before
3104 a newline unless it's a CR character. (Bug#14287)
3105
ad60824e
DN
31062013-04-28 Dan Nicolaescu <dann@gnu.org>
3107
3108 * dispextern.h (struct face): Move enum face_underline_type
3109 earlier so that bitfields can be in the same word.
3110
edbdcec0
JD
31112013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3112
3113 * nsfns.m (handlePanelKeys): New function.
3114 (EmacsOpenPanel:performKeyEquivalent:)
3115 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3116 arrows/function/control and copy/paste keys (Bug#14296).
3117
0208ede7
JL
31182013-04-27 Juri Linkov <juri@jurta.org>
3119
3120 * callint.c (Fcall_interactively): Call `Qread_number' for
3121 interactive code letter `n' instead of using duplicate code.
3122 (Bug#14254)
3123
b8dd59f7
PE
31242013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3125
3126 * systime.h (make_timeval): Declare as 'const'.
3127
8bd722db
KH
31282013-04-27 Kenichi Handa <handa@gnu.org>
3129
3130 * font.c (font_open_entity): Always open a font of manageable
3131 size.
3132
13d0e56f 31332013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3134
f780d632
PE
3135 Port better to AIX (Bug#14258).
3136 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3137 to pacify AIX xlc.
3138
ec509856
KH
31392013-04-24 Kenichi Handa <handa@gnu.org>
3140
3141 * coding.c (decode_coding_iso_2022): When an invalid escape
3142 sequence is encountered, reset the invocation and designation
3143 status to the safest one.
3144
84fc48e5
PE
31452013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3146
3147 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3148 Without this fix, "make distclean" leaves stamp-h1 behind.
3149
806bda47
EC
31502013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3151
3152 * w32fns.c (w32_fullscreen_rect): New function to compute the
3153 window rectangle for the given fullscreen mode.
3154 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3155 longer tunes the window size. This keeps the window's edges flush
3156 with the screen and allows the taskbar to hide itself in fullboth.
3157
3158 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3159 window decorations and uses the entire screen.
3160
3161 * w32term.h (w32_fullscreen_rect) Add prototype.
3162 (struct w32_output): Replace normal_width, normal_height,
3163 normal_top, and normal_left members with a single normal_placement
3164 struct.
3165 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3166 Remove macros.
3167 (FRAME_NORMAL_PLACEMENT): New macro.
3168
9cc2810b
JB
31692013-04-16 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * minibuf.c (Ftest_completion): Silence compiler warning.
3172
fd16b54c
EZ
31732013-04-15 Eli Zaretskii <eliz@gnu.org>
3174
3175 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3176 bug#14062.
fd16b54c
EZ
3177
3178 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3179 parentheses.
3180
3181 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3182 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3183 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3184 parentheses where appropriate.
3185
9e3379a0
PE
31862013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3187
3188 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3189
ddd6b685
EZ
31902013-04-14 Eli Zaretskii <eliz@gnu.org>
3191
3192 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3193 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3194 Mention in the doc string that setting these variables takes
3195 effect only after a call to set-window-buffer. (Bug#14200)
3196
29b79ba1
EZ
31972013-04-13 Eli Zaretskii <eliz@gnu.org>
3198
3199 * indent.c (Fvertical_motion): Don't consider display strings on
3200 overlay strings as display strings on the buffer position we
3201 started from. This prevents vertical cursor motion from jumping
3202 more than one line when there's an overlay string with a display
3203 property at end of line.
3204 Reported by Karl Chen <Karl.Chen@quarl.org> in
3205 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3206
562c6ee9
SM
32072013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3208
3209 * window.c (select_window): `record_buffer' even if window is
3210 already selected (bug#14191).
3211
fcc1fe85
EZ
32122013-04-11 Eli Zaretskii <eliz@gnu.org>
3213
3214 * window.c (Fwindow_end): Test more flags, including the buffer's
3215 last_overlay_modified flag, to determine whether the window's
3216 display is really up-to-date. Prevents the function from
3217 returning a stale value. (Bug#14170)
3218 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3219 current matrix.
3220
f009190a
EZ
32212013-04-10 Eli Zaretskii <eliz@gnu.org>
3222
3223 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3224 garbaged only if it is not already the top frame on its TTY.
3225 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3226 there are GUI frames open in the same session. (Bug#13864)
3227
78ce603d
SM
32282013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3229
3230 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3231 of marking the idle timers directly.
3232
a8036e40
SM
32332013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3234
3235 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3236 tables (bug#14054).
3237
7ffe7ef6
SM
32382013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3239
3240 * window.c (select_window): Don't record_buffer while the invariant is
3241 temporarily broken (bug#14161).
3242
3243 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3244
7d9f6883
EZ
32452013-04-07 Eli Zaretskii <eliz@gnu.org>
3246
3247 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3248
5406cfd9
RF
32492013-04-07 Romain Francoise <romain@orebokech.com>
3250
3251 Ignore additional platform-specific ACL errors (Bug#13702).
3252 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3253 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3254
95c0e83b
JD
32552013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3256
3257 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3258 f->output_data.ns.
3259
876da980
PE
32602013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3263 This bug was introduced by my 2013-02-25 change that simplified
3264 data_start configuration. Without this change, on GNU/Linux
3265 an Emacs configured with --enable-profiling fails immediately
3266 due to a profiler signal.
3267 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3268 with these flags. On platforms where special flags are needed
3269 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3270 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3271 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3272
7452b7bd
DA
32732013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3274
3275 Get rid of some platform-specific functions examining window
3276 system and its capabilities. This is a partial rework of the
3277 2013-04-05 change.
3278 * lisp.h (have_menus_p): Remove prototype. This function is
3279 replaced with platform-independent window_system_available.
3280 (check_window_system): Move to...
3281 * frame.h (decode_window_system_frame, window_system_available):
3282 ...here, add new prototypes.
3283 * frame.c (window_system_available, decode_window_system_frame):
3284 New functions.
3285 (check_window_system): Platform-independent now.
3286 * xterm.h (x_in_use): Remove declaration.
3287 (check_x_frame):
3288 * w32term.h (check_x_frame):
3289 * nsterm.h (check_x_frame): Remove prototypes. This function
3290 is replaced with platform-independent decode_window_system_frame.
3291 * msdos.c (have_menus_p): Remove.
3292 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3293 Remove platform-specific functions. Use check_window_system,
3294 decode_window_system_frame and check_ns_display_info where
3295 appropriate. Minor style and comment tweaks.
3296 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3297 (check_x_frame): Likewise.
3298 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3299 Likewise.
3300 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3301 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3302 * xmenu.c, xselect.c: All related users changed.
3303
251e9147
KH
33042013-04-03 Kenichi Handa <handa@gnu.org>
3305
3306 The following changes is to optimize the code for reading UTF-8
3307 files.
3308
562c6ee9 3309 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3310 changed. Check EOL format. Do not call adjust_coding_eol_type
3311 here.
3312 (check_utf_8): New function.
3313 (adjust_coding_eol_type): Do nothing if already adjusted.
3314 (detect_coding): Compare the return value of check_ascii with
3315 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3316 (decode_coding_gap): Optimize for valid UTF-8.
3317
8bc369d4
KH
33182013-03-21 Kenichi Handa <handa@gnu.org>
3319
3320 * coding.c (syms_of_coding): Cancel previous change.
3321
3322 * insdel.c (insert_from_gap): Fix previous change.
3323
73931ad1
DA
33242013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3325
3326 Consistently use platform-specific function to detect window system.
3327 * lisp.h (check_window_system): New prototype. This function is
3328 going to replace check_x, check_w32 and check_ns.
3329 (have_menus_p): Mention msdos.c in comment.
3330 * fontset.c (check_window_system_func): Remove. Adjust all users.
3331 * fontset.h (check_window_system_func): Remove prototype.
3332 * nsterm.h (check_ns):
3333 * xterm.h (check_x):
3334 * w32term.h (check_w32): Likewise.
3335 * menu.c (Fx_popup_menu): Use check_window_system.
3336 * msdos.c (check_window_system): Define for MS-DOS.
3337 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3338 * w32fns.c (check_window_system): Likewise for MS-Windows.
3339 * xfns.c (check_window_system): Likewise for X.
3340 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3341 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3342
7216e43b
PE
33432013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 Prefer < to > in range checks such as 0 <= i && i < N.
3346 This makes it easier to visualize quantities on a number line.
3347 This patch doesn't apply to all such range checks,
3348 only to the range checks affected by the 2013-03-24 change.
3349 This patch reverts most of the 2013-03-24 change.
3350 * alloc.c (xpalloc, Fgarbage_collect):
3351 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3352 * character.c (string_escape_byte8):
3353 * charset.c (read_hex):
3354 * data.c (cons_to_unsigned):
3355 * dispnew.c (update_frame_1):
3356 * doc.c (Fsubstitute_command_keys):
3357 * doprnt.c (doprnt):
3358 * editfns.c (hi_time, decode_time_components):
3359 * fileio.c (file_offset):
3360 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3361 * font.c (font_intern_prop):
3362 * frame.c (x_set_alpha):
3363 * gtkutil.c (get_utf8_string):
3364 * indent.c (check_display_width):
3365 * keymap.c (Fkey_description):
3366 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3367 * lread.c (read1):
3368 * minibuf.c (read_minibuf_noninteractive):
3369 * process.c (wait_reading_process_output):
3370 * search.c (Freplace_match):
3371 * window.c (get_phys_cursor_glyph):
3372 * xdisp.c (redisplay_internal):
3373 * xsmfns.c (smc_save_yourself_CB):
3374 Prefer < to > for range checks.
3375 * dispnew.c (sit_for): Don't mishandle NaNs.
3376 This fixes a bug introduced in the 2013-03-24 change.
3377 * editfns.c (decode_time_components): Don't hoist comparison.
3378 This fixes another bug introduced in the 2013-03-24 change.
3379
92759988
DA
33802013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3381
3382 * frame.h (struct frame): Drop scroll_bottom_vpos
3383 member becaue all real users are dead long ago.
3384 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3385 * xdisp.c (redisplay_internal): Adjust user.
3386
9a1971bb
GM
33872013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3388
f38ab167
JD
3389 * nsmenu.m (showAtX:Y:for:): setLevel to
3390 NSPopUpMenuWindowLevel (Bug#13998).
3391
6d01f1fe
JD
33922013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3393
3394 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3395 (ns_check_pending_open_menu): Declare.
3396
3397 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3398 (x_activate_menubar): Update the menu with title that matches
3399 ns_get_pending_menu_title, and call
3400 ns_check_pending_openmenu (Bug#12698).
3401 (menuWillOpen:): New method.
3402 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3403
3404 * nsterm.m (menu_will_open_state, menu_mouse_point)
3405 (menu_pending_title): New varaibles.
3406 (ns_get_pending_menu_title, ns_check_menu_open)
3407 (ns_check_pending_open_menu): New functions.
3408
781f4782
DA
34092013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3410
3411 * indent.c (current_column_bol_cache): Remove leftover which is not
3412 used in Fmove_to_column any more.
3413 (current_column, scan_for_column): Adjust users.
3414 * keyboard.c (last_point_position_buffer, last_point_position_window):
3415 Remove leftovers which are not used for recording undo any more.
3416 (command_loop_1, syms_of_keyboard): Adjust users.
3417 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3418 redisplay_window any more.
3419 (move_it_to): Adjust user.
3420
1921c31b
JB
34212013-03-29 Juanma Barranquero <lekktu@gmail.com>
3422
3423 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3424 Update dependencies.
3425
717b8bcd
SM
34262013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3427
3428 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3429 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3430 forward references.
3431
e74aeda8
DA
34322013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3433
3434 * window.h (struct window): Replace hchild, vchild and buffer slots
3435 with the only contents slot. This is possible because each valid
3436 window may have either the child window (in vertical or horizontal
3437 combination) or buffer to display (for the leaf window). Using that,
3438 a lof of operations to traverse and/or change window hierarchies may
3439 be simplified. New member horizontal is used to distinguish between
3440 horizontal and vertical combinations of internal windows.
3441 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3442 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3443 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3444 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3445 Use contents slot, not buffer, where appropriate.
3446 (wset_combination): New function.
3447 (wset_buffer): Add eassert.
3448 (Fframe_first_window): Simplify the loop reaching first window.
3449 (Fwindow_buffer): Use WINDOW_LEAF_P.
3450 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3451 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3452 (unshow_buffer): Convert initial debugging check to eassert.
3453 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3454 (make_parent_window, window_resize_check, window_resize_apply)
3455 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3456 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3457 Adjust to match struct window changes.
3458 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3459 (mark_window_cursors_off, count_windows, get_leaf_windows)
3460 (foreach_window_1): Simplify the loop.
3461 * alloc.c (mark_object): Do not check for the leaf window because
3462 internal windows has no glyph matrices anyway.
3463 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3464 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3465 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3466 (build_frame_matrix_from_window_tree, mirror_make_current)
3467 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3468 (update_window_tree, set_window_update_flags): Simplify the loop.
3469 (sync_window_with_frame_matrix_rows): Enforce live window.
3470 Use contents slot, not buffer, where appropriate.
3471 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3472 and WINDOW_HORIZONTAL_COMBINATION_P.
3473 (make_frame_visible_1): Simplify the loop.
3474 Use contents slot, not buffer, where appropriate.
3475 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3476 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3477 (expose_window_tree): Likewise.
3478 Use contents slot, not buffer, where appropriate.
3479 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3480 to avoid deleted windows. Use contents slot instead of buffer.
3481 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3482 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3483 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3484 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3485
121ab1cd
EZ
34862013-03-28 Eli Zaretskii <eliz@gnu.org>
3487
ef454cf7
EZ
3488 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3489 identify the reasons for assertion violations in bug#14062 and
3490 similar ones.
21e930f8
EZ
3491 (Fx_show_tip): Fix compilation error under
3492 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3493
121ab1cd
EZ
3494 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3495 Reported by <rzl24ozi@gmail.com>.
3496
5c89ca24
DA
34972013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3498
3499 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3500 start marker...
562c6ee9
SM
3501 (unwind_with_echo_area_buffer): ...to restore it here.
3502 This is needed to ensure that...
5c89ca24
DA
3503 (redisplay_window): ...both window markers are valid here,
3504 which is verified by eassert.
3505 * editfns.c (save_excursion_save): Do not assume that
3506 selected_window always displays the buffer.
c7f53895
DA
3507 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3508 Fix comment.
5c89ca24 3509
f557c1b1
SM
35102013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3511
3512 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3513 the upcase table.
3514
40693bba 35152013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3516
3517 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3518
c86f791f
EZ
35192013-03-27 Eli Zaretskii <eliz@gnu.org>
3520
3521 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3522 since MinGW's w32api headers do. This avoids compiler warnings.
3523
3524 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3525 if already defined.
3526
c6e72e17
EZ
35272013-03-26 Eli Zaretskii <eliz@gnu.org>
3528
3529 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3530
54e95010
JD
35312013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3532
3533 * gtkutil.c (style_changed_cb): Check if frame is live and an
3534 X frame (Bug#14038).
3535
b88b62de
EZ
35362013-03-26 Eli Zaretskii <eliz@gnu.org>
3537
a18d7de6
EZ
3538 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3539 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3540 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3541 MinGW64.
8f5e14c8
EZ
3542 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3543 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3544
b88b62de
EZ
3545 Fix incompatibilities between MinGW.org and MinGW64 headers.
3546 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3547
3548 * w32.c (REPARSE_DATA_BUFFER): Guard with
3549 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3550
c074e458
JD
35512013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3552
3553 * xterm.c: Include X11/XKBlib.h
3554 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3555
908589fd
AS
35562013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3557
3558 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3559 written backwards.
3560 * blockinput.h (input_blocked_p): Likewise.
3561 * bytecode.c (exec_byte_code): Likewise.
3562 * callproc.c (call_process_kill, call_process_cleanup)
3563 (Fcall_process): Likewise.
3564 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3565 (Fccl_execute_on_string): Likewise.
3566 * character.c (string_escape_byte8): Likewise.
3567 * charset.c (read_hex): Likewise.
3568 * cm.c (calccost): Likewise.
3569 * data.c (cons_to_unsigned): Likewise.
3570 * dired.c (directory_files_internal, file_name_completion):
3571 Likewise.
3572 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3573 (sit_for): Likewise.
3574 * doc.c (Fsubstitute_command_keys): Likewise.
3575 * doprnt.c (doprnt): Likewise.
3576 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3577 * emacsgtkfixed.c: Likewise.
3578 * fileio.c (file_offset, Fwrite_region): Likewise.
3579 * floatfns.c (Fexpt, fmod_float): Likewise.
3580 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3581 Likewise.
3582 * font.c (font_intern_prop): Likewise.
3583 * frame.c (x_set_alpha): Likewise.
3584 * gtkutil.c (get_utf8_string): Likewise.
3585 * indent.c (check_display_width): Likewise.
3586 * intervals.c (create_root_interval, rotate_right, rotate_left)
3587 (split_interval_right, split_interval_left)
3588 (adjust_intervals_for_insertion, delete_node)
3589 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3590 (merge_interval_right, merge_interval_left, copy_intervals)
3591 (set_intervals_multibyte_1): Likewise.
3592 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3593 * keymap.c (Fkey_description): Likewise.
3594 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3595 * lread.c (openp, read_integer, read1, string_to_number):
3596 Likewise.
3597 * menu.c (ensure_menu_items): Likewise.
3598 * minibuf.c (read_minibuf_noninteractive): Likewise.
3599 * print.c (printchar, strout): Likewise.
3600 * process.c (create_process, Faccept_process_output)
3601 (wait_reading_process_output, read_process_output, send_process)
3602 (wait_reading_process_output): Likewise.
3603 * profiler.c (make_log, handle_profiler_signal): Likewise.
3604 * regex.c (re_exec): Likewise.
3605 * regex.h: Likewise.
3606 * search.c (looking_at_1, Freplace_match): Likewise.
3607 * sysdep.c (get_child_status, procfs_ttyname)
3608 (procfs_get_total_memory): Likewise.
3609 * systime.h (EMACS_TIME_VALID_P): Likewise.
3610 * term.c (dissociate_if_controlling_tty): Likewise.
3611 * window.c (get_phys_cursor_glyph): Likewise.
3612 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3613 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3614 Likewise.
3615 * xfns.c (Fx_window_property): Likewise.
3616 * xmenu.c (set_frame_menubar): Likewise.
3617 * xselect.c (x_get_window_property, x_handle_dnd_message):
3618 Likewise.
3619 * xsmfns.c (smc_save_yourself_CB): Likewise.
3620 * xterm.c (x_scroll_bar_set_handle): Likewise.
3621
2bf7d27a
DA
36222013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3623
3624 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3625 to be optional or nil. Adjust comment and convert it to docstring.
3626 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3627 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3628
a9ebfa0b
PE
36292013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3630
3631 Static checking by GCC 4.8-20130319.
3632 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3633 * process.c (Fset_process_datagram_address)
3634 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3635 * xdisp.c (get_char_face_and_encoding):
3636 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3637 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3638 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3639
4f3576ee
KB
36402013-03-24 Ken Brown <kbrown@cornell.edu>
3641
789b5e9a
KB
3642 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3643 fix compilation on 64-bit Cygwin, where underscores are not
3644 automatically prepended.
3645
4f3576ee
KB
3646 * w32term.c (w32_initialize): Silence compiler warning.
3647
b5b7745f
EZ
36482013-03-23 Eli Zaretskii <eliz@gnu.org>
3649
cdc0d0bd
EZ
3650 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3651 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3652 variables, to save and restore frame dimensions.
3653 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3654 after returning from a 'fullscreen' configuration.
3655 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3656 to avoid races between the main thread and the input thread.
3657
3658 * w32term.h (struct w32_output): New members normal_width,
3659 normal_height, normal_top, normal_left, and prev_fsmode.
3660 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3661 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3662 members of a frame.
3663
b5b7745f
EZ
3664 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3665 'fullscreen' parameter. Always record previous width and height
3666 of the frame, except when switching out of maximized modes, so
3667 that they could be restored correctly, instead of resetting to the
3668 default frame dimensions. Send SC_RESTORE command to the frame,
3669 unless we are going to send SC_MAXIMIZE, to restore the frame
3670 resize hints in the mouse pointer shown by the window manager.
3671 (Bug#14032)
3672
3673 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3674
3675 * lisp.h (get_frame_param): Adjust conditions for prototype
3676 declaration.
3677
a3454eed
KB
36782013-03-22 Ken Brown <kbrown@cornell.edu>
3679
3680 * unexcw.c: Drop unneeded inclusion of w32common.h.
3681 (report_sheap_usage): Declare.
3682 (read_exe_header): Add magic numbers for x86_64.
3683 (fixup_executable): Fix printf format specifier for unsigned long
3684 argument.
3685
5a49b79c
DA
36862013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3687
3688 * frame.h (struct frame): Put menu_bar_window under #ifdef
3689 because this member is not needed when X toolkit is in use.
3690 (fset_menu_bar_window):
3691 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3692 (free_glyphs, update_frame):
3693 * xdisp.c (expose_frame): Likewise.
3694 (display_menu_bar): Likewise. Remove redundant eassert.
3695 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3696 toolkit is in use.
3697
d6723bf7
PE
36982013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3699
7b1123d8
PE
3700 Use functions and constants to manipulate Lisp_Save_Value objects.
3701 This replaces code that used macros and strings and token-pasting.
3702 The change makes the C source a bit easier to follow,
3703 and shrinks the Emacs executable a bit.
3704 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3705 (make_save_value): Change 1st arg from string to enum. All callers
3706 changed.
3707 (INTX): Remove.
3708 (mark_object): Use if, not #if, for GC_MARK_STACK.
3709 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3710 (XSAVE_OBJECT): Now functions, not macros.
3711 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3712 the constant was never used.
3713 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3714 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3715 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3716 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3717 New constants.
3718 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3719 type3 with a single member save_type. All uses changed.
3720 (save_type, set_save_pointer, set_save_integer): New functions.
3721 * print.c (PRINTX): Remove.
3722
d6723bf7
PE
3723 * alloc.c: Remove redundant static declarations.
3724
5f24fa51
DA
37252013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3726
3727 * window.h (struct window): Convert left_col, top_line, total_lines
3728 and total_cols from Lisp_Objects to integers. Adjust comments.
3729 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3730 Remove.
3731 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3732 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3733 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3734 Adjust users where appropriate.
3735
42143acd
DA
37362013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3737
3738 * frame.h (struct frame): Drop resx and resy because the same data is
3739 available from window system-specific output context. Adjust users.
562c6ee9
SM
3740 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3741 New functions to provide defaults when no window system available.
42143acd 3742 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3743 (NUMVAL): Move from xdisp.c.
42143acd
DA
3744 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3745 (Ffont_face_attributes, Fopen_font):
3746 * image.c (gs_load):
3747 * w32font.c (fill_in_logfont):
3748 * xdisp.c (calc_pixel_width_or_height):
3749 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3750 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3751
c0a17406
KH
37522013-03-20 Kenichi Handa <handa@gnu.org>
3753
3754 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3755 to 1 (temporary workaround until a bug related to ASCII
3756 optimization is fixed).
3757
095d384d
DA
37582013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3759
3760 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3761 Signal error if window is not internal. Adjust docstring.
3762 (delete_all_child_windows): Use combination_limit to save the buffer.
3763 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3764 * print.c (syms_of_print): Initialize debugging output not here...
3765 (init_print_once): ...but in a new function here.
3766 * lisp.h (init_print_once): Add prototype.
3767 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3768
748fa866
DA
37692013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3770
3771 * window.c (window_resize_check, window_resize_apply)
3772 (window_from_coordinates, recombine_windows, set_window_buffer)
3773 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3774 (Fsplit_window_internal, Fdelete_window_internal)
3775 (freeze_window_starts): Use bool for booleans.
3776 * window.h (window_frame_coordinates, resize_frame_windows)
3777 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3778
81519fd2
SM
37792013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3780
3781 * dispnew.c (bitch_at_user): Use `user-error'.
3782
6db423a9
KB
37832013-03-17 Ken Brown <kbrown@cornell.edu>
3784
3785 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3786 as return type of image_background. (Bug#13981)
3787 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3788
8f2906f5
JD
37892013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3790
960ce480 3791 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3792 (ns_select): Don't return with result uninitialized.
960ce480 3793
8f2906f5
JD
3794 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3795 and getDirectory.
3796
81519fd2
SM
3797 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3798 New functions.
8f2906f5
JD
3799 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3800 directories. If filename is nil, get directory name (Bug#13932).
3801 Use getFilename and getDirectory.
3802 (getFilename, getDirectory): New methods for EmacsSavePanel and
3803 EmacsOpenPanel.
3804 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3805
cded56c1
PE
38062013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3809
251e9147 38102013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3811
3812 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3813 (adjust_after_replace): Make it back to static. Delete the third
3814 arg text_at_gap_tail. Cancel the code for handling it.
3815
3816 * coding.h (struct coding_system): New member eol_seen.
3817
3818 * coding.c (detect_ascii): New function.
3819 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3820 when the source bytes are actually scanned. On detecting for
3821 coding_category_utf_8_auto, call detect_ascii instead of scanning
3822 source bytes directly.
3823 (produce_chars): Call insert_from_gap with the new arg 0.
3824 (encode_coding): Likewise.
3825 (decode_coding_gap): Control ASCII optimization by the variable
3826 disable_ascii_optimization instead of #ifndef .. #endif.
3827 Deccode EOL format according to coding->eol_seen.
3828 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3829 variable.
3830
8a44e6d1
KH
3831 * lisp.h (adjust_after_replace): Cancel externing it.
3832 (insert_from_gap): Adjust prototype.
3833
5f795e34
EZ
38342013-03-15 Eli Zaretskii <eliz@gnu.org>
3835
3836 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3837 FULLSCREEN_MAXIMIZED. (Bug#13935)
3838
f258b4be
DA
38392013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3840
3841 * region-cache.c (find_cache_boundary, move_cache_gap)
3842 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3843 Simplify debugging check and convert to eassert. Adjust comment.
3844 (pp_cache): Put under ENABLE_CHECKING.
3845
a5cc4dde
EZ
38462013-03-14 Eli Zaretskii <eliz@gnu.org>
3847
3848 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3849 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3850 and WM_ACTIVATEAPP.
3851 (w32fullscreen_hook): If the frame is visible, reset
3852 f->want_fullscreen flag after changing the frame size. If the
3853 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3854 (Bug#13953)
3855
3fc5e44a
DC
38562013-03-13 Daniel Colascione <dancol@dancol.org>
3857
3858 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3859 too so that these builds can use Cygwin's file conversion
3860 functions. (We've been building and linking cygw32.o all along
3861 and just not using it.)
3862
47d7532e
PE
38632013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3864
3865 File synchronization fixes (Bug#13944).
3866 * Makefile.in (LIB_FDATASYNC): New macro.
3867 (LIBES): Use it.
3868 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3869 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3870 Don't worry about HAVE_FSYNC, since a substitute fsync is
3871 available if the system lacks one.
3872 (Fwrite_regin): Retry fsync if interrupted.
3873
c7ffccaf
EZ
38742013-03-13 Eli Zaretskii <eliz@gnu.org>
3875
4e2df81d 3876 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3877 activated, call w32fullscreen_hook, to make sure the new frame
3878 dimensions are in effect. (Bug#13937)
3879
8a7debc1
DA
38802013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3881
3882 * xdisp.c (init_iterator): Simplify because both character and byte
3883 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3884 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3885 character and byte positions can be obtained from marker.
8a7debc1 3886
7fd8c501
PE
38872013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3888
d9df6f40
PE
3889 Static checking by Sun C 5.12.
3890 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3891 * bytecode.c (exec_byte_code):
3892 * dispnew.c (init_display):
3893 * eval.c (error):
3894 * fileio.c (Fsubstitute_in_file_name):
3895 * keyboard.c (Fevent_convert_list):
3896 * keymap.c (Fsingle_key_description):
3897 * term.c (maybe_fatal, fatal):
3898 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3899 * xsmfns.c (Fhandle_save_session):
3900 Omit unreachable code.
3901 * keymap.c (map_keymap_char_table_item): Cast void * to
3902 a function pointer type; the C Standard requires this.
3903
7fd8c501
PE
3904 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3905 Include <sys/param.h> unconditionally, as that works elsewhere and
3906 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3907 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3908 and FreeBSD now.
3909
a020afb9 3910See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3911
3912;; Local Variables:
3913;; coding: utf-8
aac0c6e3
MR
3914;; End:
3915
ab422c4d 3916 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3917
3918 This file is part of GNU Emacs.
3919
3920 GNU Emacs is free software: you can redistribute it and/or modify
3921 it under the terms of the GNU General Public License as published by
3922 the Free Software Foundation, either version 3 of the License, or
3923 (at your option) any later version.
3924
3925 GNU Emacs is distributed in the hope that it will be useful,
3926 but WITHOUT ANY WARRANTY; without even the implied warranty of
3927 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3928 GNU General Public License for more details.
3929
3930 You should have received a copy of the GNU General Public License
3931 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.