Rename :content-type to :format in `create-image'
[bpt/emacs.git] / src / ChangeLog
CommitLineData
66e7901a
LMI
12013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * image.c (imagemagick_filename_hint): Check for errors in the
4 alist structure.
5
2fa611b7
EZ
62013-08-13 Eli Zaretskii <eliz@gnu.org>
7
8 * window.c (Fwindow_margins): Return nil when there's no marginal
9 area, as per the documented API.
10
11 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
12 Fmake_vector, as scroll bar's struct members are not all Lisp
13 objects now. This avoids crashes in GC.
14
15 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
16 bool, so its address could be taken.
17
8259030d
LMI
182013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
19
20 * image.c (imagemagick_filename_hint): New function to possibly
21 apply `image-content-type-suffixes'.
22 (imagemagick_load_image): Use it.
23
866c710e
EZ
242013-08-13 Eli Zaretskii <eliz@gnu.org>
25
26 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
27 if loading zlib failed.
28
f10490f0
JD
292013-08-13 Jan Djärv <jan.h.d@swipnet.se>
30
96311be7
JD
31 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
32 2013-08-13 checkin below. Change bool to BOOL, rule is:
33 All Obj-C code uses BOOL, except for interfaces callable from C.
34
f10490f0
JD
35 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
36
c8ae93b0
DA
372013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
38
39 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
40 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
41 bool instead of BOOL.
42 * w32term.h (struct scroll_bar): Convert fringe_extended_p
43 from Lisp_Object to bitfield. Adjust comment.
44 * w32term.c (x_scroll_bar_create): Adjust user.
45 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
46 * xterm.c (XTset_vertical_scroll_bar): Likewise.
47 Use bool for boolean.
48 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
49 to `unsigned int' when defining a bitfield.
50
53b64418
PE
512013-08-13 Paul Eggert <eggert@cs.ucla.edu>
52
53 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
54
eeaf9bf3
DA
552013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
56
57 * window.h (struct window): Convert left_margin_cols and
58 right_margin_cols from Lisp_Objects to integers. Adjust comment.
59 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
60 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
61 Adjust users.
62 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
63 Adjust comment.
64 (showing_window_margins_p, update_window_line, update_frame_1):
65 * fringe.c (draw_fringe_bitmap_1):
66 * xdisp.c (window_box_width): Adjust users.
67 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
68 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
69 Use direct assignment.
70 (Fset_window_configuration, save_window_save, Fwindow_margins):
71 Convert Lisp_Object to integer and back where appropriate.
72 (Fset_window_margins): Adjust user. Return t if any margin
73 was actually changed, and mention this in docstring.
74
956720af
XF
752013-08-13 Xue Fuqiao <xfq.free@gmail.com>
76
f73f4ce6 77 * syntax.c (forward_word):
956720af
XF
78 * cmds.c (forward_char, backward_char): Mention the optional argument.
79
9e37ee3b
DA
802013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
81
82 * window.h (struct window): Convert left_fringe_width
83 and right_fringe_width from Lisp_Objects to integers.
84 Adjust comment.
85 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
86 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
87 * window.c (wset_left_fringe_width, wset_right_fringe_width):
88 Remove.
89 (make_window): Initialize new integer fields to -1.
90 (Fsplit_window_internal): Use direct assignment.
91 (Fset_window_configuration, save_window_save): Convert
92 Lisp_Object to integer and back where appropriate.
93 (Fset_window_fringes): Adjust user. Return t if any fringe
94 was actually changed, and mention this in docstring.
95
e4375ca7
DA
962013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
97
98 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
99 * nsfns.m (x_set_cursor_type):
100 * w32fns.c (x_set_cursor_type):
101 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
102 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 103
a45543bc
DA
1042013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
105
106 * font.c (clear_font_cache): New function, stripped from...
107 (Fclear_font_cache): ...here, which now uses the function
108 above. Adjust comment.
109 * font.h (clear_font_cache): Add prototype.
110 * xfaces.c (clear_face_cache): Use clear_font_cache.
111
ae966a86
DA
1122013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * window.c (Fset_window_start): Compare `w', not `window' because
115 `w' might not be equal to `window' after call to decode_live_window.
116
297a545b
PE
1172013-08-12 Paul Eggert <eggert@cs.ucla.edu>
118
119 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
120 This fixes a problem introduced by the Bug#15035 patch
121 when using GPG. Reported by Herbert J. Skuhra.
122
aa942e2b
EZ
1232013-08-12 Eli Zaretskii <eliz@gnu.org>
124
125 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
126 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
127 not yet initialized.
128
7699d09e
LMI
1292013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
130
131 * decompress.c (Fzlib_decompress_region): Support zlib
132 decompression, too, and rename.
133
1d238bc7
PE
1342013-08-12 Paul Eggert <eggert@cs.ucla.edu>
135
136 Minor zlib configuration tweaks.
137 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
138 Don't assume presence of fn_inflateInit2_ zlib internal function.
139
8a44a184
LMI
1402013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
141
142 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
143 include the zlib prefix.
144
594a4307
EZ
1452013-08-12 Eli Zaretskii <eliz@gnu.org>
146
147 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
148 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
149 define static variables that are pointers to zlib functions to be
150 dynamically loaded.
151 (init_zlib_functions) [WINDOWSNT]: New function.
152 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
153 New macros.
154 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
155 macros instead of invoking the zlib functions directly.
156 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
157 Szlib_available_p.
158
d2e113bc
DA
1592013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
160
161 Avoid looping over all frame windows to freeze and unfreeze.
162 * window.h (struct window): Drop frozen_window_start_p.
163 (freeze_window_starts): Drop prototype.
164 * frame.h (struct frame): New frozen_window_starts flag.
165 (FRAME_WINDOWS_FROZEN): New macro.
166 * window.c (freeze_window_start, freeze_window_starts):
167 Remove.
168 (select_window, replace_window): Adjust users.
169 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
170 (window_frozen_p): New function.
171 (redisplay_window): Use it.
172
94fcd171
PE
1732013-08-12 Paul Eggert <eggert@cs.ucla.edu>
174
175 Fix some fd issues when running subprocesses (Bug#15035).
176 Fix bugs that can leak files or file descriptors on errors.
177 Don't unlink open temp files, as that's hard for users to diagnose
178 when things go awry (e.g., temp disk exhausted).
179 Don't bother to lock temp files. Check for invalid recursion.
180 * callproc.c (synch_process_fd): Remove. All uses removed.
181 (synch_process_tempfile): New var or macro.
182 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
183 New constants.
184 (record_kill_process): New arg, the temp name. All callers changed.
185 (delete_temp_file): Now just a simple wrapper around unlink.
186 (call_process_kill): New arg, the call_process_fd array.
187 Close them all. Clear synch_process_pid. Remove the temp file,
188 or arrange for it to be removed.
189 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
190 that's been moved to synch_process_tempfile. Caller changed.
191 Do not remove the tempfile; that's now call_process_kill's
192 responsibility.
193 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
194 call_process_kill; the caller now does that.
195 (call_process_cleanup): Do not close the process fd; that's now
196 call_process_kill's responsibility.
197 (Fcall_process): Implement via new function call_process, which
198 has most of the old body of Fcall_process, but with a different API.
199 (call_process): New function that does not open or close filefd if
200 it is nonnegative. Record which fds need to be closed, and let
201 call_process_kill close (and remove the tempfile, on MSDOS) on error.
202 Signal an error if invoked recursively (could be done via a hook).
203 Simplify creation of the tempfile in the MSDOS case.
204 Don't create the output file until after checking for the executable.
205 Report any failure to open /dev/null.
206 Don't open /dev/null for writing twice; once is enough.
207 Don't create pipe if all output is being discarded or sent to file.
208 Don't worry about setting up the coding system or reading from the
209 pipe if all output is being discarded.
210 Hoist fd_error local into top level, to lessen block nesting.
211 Don't record deleted pid here; now done by Fcall_process_region.
212 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
213 and note its success in synch_process_tempfile.
214 Do not leak resources when child_setup fails.
215 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
216 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
217 (create_temp_file): Now returns open fd, with an additional
218 Lisp_Object * argument to return the name. All callers changed.
219 Do not close the file; rewind it instead, and leave it open for
220 the caller. Do not lock the temp file. Unwind-protect the file
221 and the file-descriptor.
222 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
223 If an asynchrounous process, record it here, not in call_process.
224 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
225 * eval.c (set_unwind_protect): New function.
226 * fileio.c (write_region): New function, generalized from the
227 old Fwrite_region. Do not lock temp files.
228 (Fwrite_region): Use it.
229 * lisp.h (set_unwind_protect, write_region): New decls.
230 * process.c: Include <verify.h>.
231 (make_process): Mark fds as initially closed.
232 (deleted_pid_list): Now a list of pid-filename pairs.
233 All uses changed.
234 (close_process_fd): New function.
235 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
236 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
237 New constants. Verify that their number matches PROCESS_OPEN_FDS.
238 (create_process, create_pty, Fmake_serial_process)
239 (server_accept_connection): Record which fds need to be closed,
240 and let deactivate_process close them.
241 (Fmake_network_process): Do not discard the unwind-protect
242 until it's safe to do so.
243 (deactivate_process): Close the fds opened by create_process etc.
244 (Fprocess_send_eof): Adjust to new way of recording open fds.
245 Report an error if /dev/null can't be opened, instead of aborting.
246 * process.h (PROCESS_OPEN_FDS): New constant.
247 (struct Lisp_Process): New member open_fds.
248 (record_kill_process, record_deleted_pid): Adjust signatures.
249 (record_deleted_pid): Move decl here ...
250 * syswait.h (record_deleted_pid): ... from here.
251
d0e615c3
PE
2522013-08-11 Paul Eggert <eggert@cs.ucla.edu>
253
254 * decompress.c: Fix bugs with large buffers and weird inputs.
255 Tune a bit. Reindent as per usual Emacs style.
256 (BUFFER_SIZE): Remove.
257 (Fdecompress_gzipped_region): Do not mishandle input buffers with
258 more than UINT_MAX bytes. Decompress into the gap instead of into
259 an auto buffer, as this should avoid copying. Return nil if
260 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
261 set immediate_quit; we shouldn't trust zlib code that much.
262
313546eb
LMI
2632013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
264
99a32242
LMI
265 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
266 errors, and really move the gap to where we want it.
267
313546eb
LMI
268 * lisp.h: Include decompress.c support.
269
270 * emacs.c (main): Include decompress.c support.
271
272 * Makefile.in: Include -lz if present.
273
d2d699ac
JD
2742013-08-11 Jan Djärv <jan.h.d@swipnet.se>
275
f90e3ebd
JD
276 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
277 (initWithTitle:): Initialize frame to 0.
278 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
279 (fillWithWidgetValue:frame:): Renamed from
280 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
281
282 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
283 fillWithWidgetValue:frame:
284
423d3b3f
JD
285 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
286 remove memory leak warnings.
287
d2d699ac
JD
288 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
289 (ns_check_menu_open): Handle menu == nil. Remove assignment to
290 menu_pending_title.
291
292 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
293 (x_activate_menubar): Update the whole menu.
294 (trackingNotification:): Call ns_check_menu_open if tracking ends.
295 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
296 current event is not NSSystemDefined (Bug#15001).
297 Call ns_check_menu_open only if trackingMenu is 2.
298 (menuDidClose:): New method, decrease trackingMenu.
299 (fillWithWidgetValue:setDelegate:): New method.
300 (fillWithWidgetValue:): Call the above.
301
302 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
303
7d652d97
PE
3042013-08-11 Paul Eggert <eggert@cs.ucla.edu>
305
306 Omit some unnecessary casts.
307 Many of these go back to the old pre-C89 days, when they may have
308 been needed, but we've been assuming C89 or later for a while now.
309 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
310 (live_float_p, live_misc_p, live_vector_p):
311 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
312 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
313 (defvar_per_buffer):
314 * callint.c (Fcall_interactively):
315 * doc.c (Fsubstitute_command_keys):
316 * filelock.c (get_boot_time):
317 * frame.c (xrdb_get_resource):
318 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
319 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
320 (xg_get_file_name_from_selector, menuitem_destroy_callback)
321 (menuitem_highlight_callback, menu_destroy_callback)
322 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
323 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
324 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
325 (xg_tool_bar_help_callback, tb_size_cb):
326 * image.c (xpm_alloc_color, png_read_from_memory)
327 (png_read_from_file, png_load_body, our_memory_skip_input_data)
328 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
329 (syms_of_image):
330 * keymap.c (describe_map):
331 * nsfns.m (Fns_display_monitor_attributes_list):
332 * nsmenu.m (process_dialog:):
333 * nsterm.m (hold_event):
334 * process.c (wait_reading_process_output):
335 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
336 * scroll.c (do_direct_scrolling, scrolling_1):
337 * termcap.c (tgetent):
338 * window.c (check_window_containing, add_window_to_list)
339 (freeze_window_starts):
340 * xdisp.c (compare_overlay_entries, vmessage):
341 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
342 (x_get_monitor_attributes_xrandr)
343 (Fx_display_monitor_attributes_list, x_display_info_for_name)
344 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
345 * xfont.c (xfont_match, xfont_open):
346 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
347 (menubar_selection_callback, menu_position_func)
348 (popup_selection_callback, create_and_show_popup_menu)
349 (dialog_selection_callback, create_and_show_dialog):
350 * xrdb.c (x_get_string_resource):
351 (main) [TESTRM]:
352 * xsmfns.c (x_session_check_input):
353 * xterm.c (x_draw_glyphless_glyph_string_foreground)
354 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
355 (xaw_jump_callback, xaw_scroll_callback):
356 Omit unnecessary casts.
357
9acc1074
PE
3582013-08-10 Paul Eggert <eggert@cs.ucla.edu>
359
360 Minor string-length refactoring.
361 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
362 * frame.c (make_monitor_attribute_list):
363 Prefer build_string to strlen + make_string.
364
361c0eb8
JD
3652013-08-10 Jan Djärv <jan.h.d@swipnet.se>
366
367 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
368 don't check minor_code (Bug#14417).
369
14ba0822
EZ
3702013-08-09 Eli Zaretskii <eliz@gnu.org>
371
372 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
373 vertical positions instead. This avoids calling MATRIX_ROW with
374 row numbers that are possibly beyond valid limits. (Bug#15064)
375
309f24d1
DA
3762013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
377
378 Use xstrdup and build_unibyte_string where applicable.
379 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
380 * xfns.c (x_window):
381 * xrdb.c (x_get_customization_string):
382 * xterm.c (xim_initialize):
383 * w32fns.c (w32_window): Use xstrdup.
384 (w32_display_monitor_attributes_list):
385 * emacs.c (init_cmdargs):
386 * keyboard.c (PUSH_C_STR):
387 * nsfont.m (nsfont_open):
388 * sysdep.c (system_process_attributes):
389 * w32.c (system_process_attributes):
390 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
391
55902276
EZ
3922013-08-09 Eli Zaretskii <eliz@gnu.org>
393
394 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
395 variables of these types so that GDB would know about them, as aid
396 for debugging fatal exceptions. (Bug#15024) See also
397 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
398 discussions.
399
10bf7f5a
JD
4002013-08-08 Jan Djärv <jan.h.d@swipnet.se>
401
402 * nsterm.m (ns_update_begin): Don't change clip path if it would be
403 larger than the NSWindow (Bug#14934).
404
65620264
DA
4052013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
406
407 Redesign redisplay interface to drop global variable updated_window.
408 Always pass currently updated window as a parameter to update routines.
409 * dispextern.h (updated_window): Remove declaration.
410 (struct redisplay_interface): Pass window parameter to
411 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
412 and after_update_window_hook.
413 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
414 Adjust prototypes.
415 * dispnew.c (updated_window): Remove.
416 (redraw_overlapped_rows, update_marginal_area, update_text_area)
417 (update_window_line): Adjust to match redisplay interface changes.
418 * nsterm.m (ns_update_window_begin, ns_update_window_end)
419 (ns_scroll_run, ns_after_update_window_line):
420 * w32term.c (x_update_window_begin, x_update_window_end)
421 (x_after_update_window_line, x_scroll_run):
422 * xterm.c (x_update_window_begin, x_update_window_end)
423 (x_after_update_window_line, x_scroll_run):
424 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
425 Likewise. Adjust comments where appropriate.
426 (x_cursor_to): Simplify because this is always called during window
427 update (but install debugging check anyway).
428 (expose_window): Check must_be_updated_p flag to see whether this
429 function is called during window update.
430
628fdc56
DA
4312013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
432
433 Do not reset window modification event counters excessively.
434 These leftovers and poor man's tricky methods to catch extra
435 redisplay's attention are no longer needed.
436 * frame.c (set_menu_bar_lines_1):
437 * minibuf.c (read_minibuf_unwind):
438 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
439 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
440 (window_scroll_line_based, Fset_window_configuration):
441 * xdisp.c (redisplay_window): Do not reset last_modified and
442 last_overlay_modified counters.
443
8fd9c92e
JD
4442013-08-07 Jan Djärv <jan.h.d@swipnet.se>
445
446 * xselect.c (x_send_client_event): Set send_event and serial, memset
447 data.l as it might be bigger than data.b. Use 24 bit mask to
448 XSendEvent (Bug#15034).
449
0ee18172
EZ
4502013-08-07 Eli Zaretskii <eliz@gnu.org>
451
452 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
453 for TTY frames that are not the top frame on their console.
454 (Bug#14616)
455
16ddd1a6
MR
4562013-08-07 Martin Rudalics <rudalics@gmx.at>
457
458 * w32term.c (w32fullscreen_hook): Really maximize frame when
459 asked for (Bug#14841).
460
d2a95ffb
DA
4612013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Prefer selected_window to Fselected_window, likewise for frames.
464 * buffer.c (Fbuffer_swap_text):
465 * data.c (Fvariable_binding_locus):
466 * window.c (run_window_configuration_change_hook): Adjust users.
467 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
468 Use decode_live_frame.
469
170da1ec
DA
4702013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Be more careful if selected window shows the buffer other than current,
473 use window_outdated only if this is not so. This change should also
474 address some weird issues discussed in Bug#13012.
475 * window.h (window_outdated): New prototype.
476 * window.c (window_outdated): Now here. Convert from static and
477 always assume window's buffer.
478 (Fwindow_end, Fwindow_line_height): Use it.
479 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
480 and always assume window's buffer.
481 (redisplay_window): Adjust user.
e5eefe9b 482 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
483 check whether mode line should be updated only if selected window
484 shows current buffer.
485 (run_window_scroll_functions): Use eassert for debugging check.
486 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
487
56b5d5b1
DA
4882013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
489
490 * window.c (window_scroll, window_scroll_pixel_based)
491 (window_scroll_line_based): Use bool for booleans.
492
2878ba7e
PE
4932013-08-06 Paul Eggert <eggert@cs.ucla.edu>
494
495 * process.c: Fix minor off-by-one issues in descriptor counts.
496 This shouldn't fix any real bugs, but it cleans up the code a bit.
497 (max_process_desc, max_input_desc): -1, not 0, means none.
498 All uses changed.
499 (delete_input_desc): New function.
500 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
501 (deactivate_process): Scan backwards when recomuting max_process_desc;
502 that should be faster.
503 (init_process_emacs): Initialize max_input_desc.
504
e30b79c1
DA
5052013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
506
507 Use region cache to speedup bidi_find_paragraph_start.
508 * buffer.h (struct buffer): New member bidi_paragraph_cache.
509 Rename cache_long_line_scans to cache_long_scans.
510 * buffer.c (bset_cache_long_line_scans): Rename to
511 bset_cache_long_scans.
512 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
513 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
514 into account.
515 (syms_of_buffer): Rename cache-long-line-scans to
516 cache-long-scans. Adjust docstring.
517 * search.c (newline_cache_on_off):
518 * indent.c (width_run_cache_on_off): Adjust users.
519 * bidi.c (bidi_paragraph_cache_on_off): New function.
520 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
521 * insdel.c (prepare_to_modify_buffer): Invalidate
522 bidi_paragraph_cache if enabled.
523
00012b86
DA
5242013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
525
526 Invalidate region caches only if buffer text is going to be changed.
527 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
528 (modify_text): ...new prototype.
529 (prepare_to_modify_buffer_1): New prototype.
530 * textprop.c (modify_region): Rename to...
531 (modify_text_properties): ...new function.
532 (add_text_properties_1, set_text_properties, Fremove_text_properties)
533 (Fremove_list_of_text_properties): Adjust users.
534 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
535 (modify_text): ...new function.
536 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
537 (prepare_to_modify_buffer_1): ...new function.
538 * casefiddle.c (casify_region):
539 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
540 (Ftranspose_regions): Use modify_text.
541
dc6c0eda
SM
5422013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
543
544 * lisp.mk (lisp): Add nadvice.elc.
545
8f3a2c26
DA
5462013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
547
548 New macro to iterate over live buffers similar to frames.
549 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
550 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
551 Declare buffer-related variables here to offload lisp.h.
552 * buffer.c (Vbuffer_alist): Adjust comment.
553 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
554 (other_buffer_safely):
555 * data.c (store_symval_forwarding):
556 * dispnew.c (Fframe_or_buffer_changed_p):
557 * fileio.c (Fdo_auto_save):
558 * filelock.c (unlock_all_files):
559 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
560
e0fdb694
PE
5612013-08-04 Paul Eggert <eggert@cs.ucla.edu>
562
563 Fix some minor races in hosts lacking mkostemp (Bug#15015).
564 * callproc.c (create_temp_file):
565 * filelock.c (create_lock_file):
566 Assume mkostemp, since it's now provided by Gnulib.
567
63f5c6c2
EZ
5682013-08-04 Eli Zaretskii <eliz@gnu.org>
569
570 * w32.c (mkostemp): New function.
571 (mktemp): Remove, no longer used. Most of the code reused in
572 mkostemp. (Bug#15015)
484ab239 573 (mktemp): Don't undef.
63f5c6c2 574
f0b79313
DA
5752013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
576
577 * dispnew.c (glyph_matrix_count, glyph_pool_count):
578 Move under GLYPH_DEBUG and ENABLE_CHECKING.
579 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
580 (free_glyph_pool, check_glyph_memory): Likewise for
581 all users. Adjust comments where appropriate.
582
98f638d6
PE
5832013-08-03 Paul Eggert <eggert@cs.ucla.edu>
584
585 * composite.h: Minor fixups.
586 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
587 to fix a misspelling, and change it to an inline function while
588 we're at it (it need not be a macro). All uses changed.
589 (composition_method, composition_valid_p):
590 Rewrite to avoid assignments in if-conditions.
591
75c59fb3
DA
5922013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
593
594 Do not use global Lisp_Object in composition macros.
595 * composite.h (composition_temp): Remove declaration.
596 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
597 (composition_method, composition_valid_p): ...inline functions.
416a3e01 598 (compose_region): Remove the leftover.
75c59fb3
DA
599 * composite.c (composition_temp): Remove.
600 (run_composition_function, update_compositions)
601 (composition_compute_stop_pos, composition_adjust_point)
602 (Ffind_composition_internal):
603 * coding.c (handle_composition_annotation):
604 * xdisp.c (handle_composition_prop, check_point_in_composition):
605 Related users changed.
606
a10c8269
DA
6072013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
608
609 Drop FRAME_PTR typedef.
610 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
611 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
612 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
613 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
614 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
615 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
616 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
617 All related users changed.
618
a104f656
SM
6192013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
620
621 * eval.c (default_toplevel_binding): New function.
622 (Fdefvar): Use it.
623 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
624 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
625 (syms_of_eval): Export them.
626 * data.c (Fdefault_value): Micro cleanup.
627 * term.c (init_tty): Use "false".
628
4b5c9326
DA
6292013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
630
631 Fix X GC leak in GTK and raw (no toolkit) X ports.
632 * xterm.c (x_free_frame_resources): If white and black relief
633 GCs are allocated, always free them here.
634 * xfns.c (x_make_gc): Omit redundant initialization.
635 * widget.c (create_frame_gcs): Remove the leftover.
636 (EmacsFrameDestroy): Do nothing because all GCs are now freed
637 in x_free_frame_resources.
638
b19aa636
JD
6392013-08-02 Jan Djärv <jan.h.d@swipnet.se>
640
641 * nsterm.m (windowWillResize:toSize:): Only change title if
642 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
643 modifying it.
644 (viewDidEndLiveResize): New method.
645
646 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
647 inside NS_IMPL_COCOA.
648
af1f7e06
DA
6492013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
650
651 * insdel.c (adjust_after_replace, replace_range, del_range_2):
652 Do not check whether undo is enabled because record_insert and
653 record_delete does that themselves.
654
65b02bb9
DA
6552013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
656
657 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
658 member which is not really used any more.
659 (FRAME_XIC_BASE_FONTNAME): Remove.
660 * xfns.c (xic_free_fontset): Adjust user.
661 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
662 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
663 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
664 (xdialog_show): Use eassert for debugging check.
7ee0f047 665 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 666
6318cde0
PE
6672013-08-01 Paul Eggert <eggert@cs.ucla.edu>
668
669 * fileio.c, fns.c (merge): Move extern decl from here ...
670 * lisp.h (merge): ... to here.
671
6c1a09ba
DA
6722013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
673
674 Fix last font-related change.
675 * w32font.h (w32font_list_internal, w32font_match_internal):
676 Fix prototype.
677 * w32uniscribe.c (uniscribe_list, uniscribe_match):
678 (uniscribe_list_family): Adjust to match font API change.
679 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
680 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
681
f8c20208
DA
6822013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
683
684 * frame.h (FRAME_MOUSE_UPDATE):
685 * nsterm.m (ns_frame_up_to_date): Omit redundant check
686 whether hlinfo->mouse_face_mouse_frame is non-NULL.
687
fdb396e2
DA
6882013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
689
690 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
691 * font.h (struct font_driver): Change list, match, and list_family
692 functions to accept struct frame * as first arg.
693 * font.c (font_score, font_compare, font_sort_entities): Remove
694 prototypes.
695 (font_sort_entities, font_list_entities, font_select_entity):
696 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
697 match font API change.
698 * xfont.c (xfont_list, xfont_match, xfont_list_family):
699 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
700 * ftxfont.c (ftxfont_list, ftxfont_match):
701 * xftfont.c (xftfont_list, xftfont_match):
702 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
703 * w32font.c (w32font_list, w32font_match, w32font_list):
704 (w32font_list_internal, w32_font_match_internal): Likewise.
705 * xfaces.c (Fx_family_fonts): Adjust user.
706
52b8a085
DA
7072013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
708
709 Do not use pure Xism x_wm_set_icon_position in non-X ports.
710 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
711 only if HAVE_X_WINDOWS is in use.
712 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
713 * nsterm.m (x_wm_set_icon_position): Remove no-op.
714 * w32term.c (x_wm_set_icon_position): Likewise.
715 * w32fns.c (x_icon): Adjust user.
716
c791c18e
DA
7172013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
718
719 * xterm.c (last_mouse_press_frame): Remove the
720 leftover which is not really used any more.
721 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
722 (x_flush): Call XFlush once per each X display, not frame.
723 This is better because this code always unconditionally skips
724 non-X frames in Vframe_list and issues the only XFlush if we
725 have more than one X frame on the same X display.
2f935d86
DA
726 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
727 Use bool for booleans.
728 (x_draw_glyph_string_background, cvt_string_to_pixel):
729 (cvt_pixel_dtor): Drop unnecessary prototypes.
730 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 731
f435830e
DA
7322013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
733
734 Drop unnecessary functions that deals with frame pixel size.
735 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
736 (x_pixel_height): Drop prototypes.
737 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
738 (x_pixel_height): Drop implementations.
739 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
740 which should be always valid for window frame.
741 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
742 * w32menu.c (Fx_popup_dialog):
743 * xmenu.c (Fx_popup_dialog): Likewise for both.
744
84231434
DA
7452013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
746
747 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
748 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
749 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
750 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
751 and mention nil frame in docstring.
84231434 752
959067a1
DA
7532013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
754
755 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
756 (x_figure_window_size): Likewise. Adjust to return long.
757 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
758 (toplevel): Move Qterminal_live_p to...
759 * terminal.c (toplevel): ...here, make it static, and...
760 (syms_of_terminal): ...DEFSYM here.
761 * frame.h (Qterminal_live_p): Remove declaration.
762 (make_frame, x_figure_window_size): Adjust prototype.
763 * nsfns.m (Fx_create_frame): Use long for window flags.
764
f4b169ce
PE
7652013-07-30 Paul Eggert <eggert@cs.ucla.edu>
766
767 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
768 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
769 Do not assume that emacs_close (INT_MAX) is a no-op.
770
bee6a2c7
DA
7712013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
772
773 * xfaces.c (make_face_cache): For struct face_cache, prefer
774 xmalloc to xzalloc and so avoid redundant call to memset.
775 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
776
d7e6881a
DA
7772013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
778
779 * fringe.c (draw_window_fringes, update_window_fringes)
780 (compute_fringe_widths):
781 * w32term.c (x_draw_glyph_string):
782 * window.c (candidate_window_p, Frecenter):
783 * xfaces.c (realize_basic_faces, realize_default_face)
784 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
785 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
786 * xfns.c (x_set_cursor_color, xic_free_xfontset):
787 * xmenu.c (Fx_menu_bar_open_internal):
788 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
789 * xsettings.c (xft_settings_event):
790 * xterm.c (x_draw_glyph_string, x_had_errors_p):
791 Use bool for booleans. Adjust style and comments where
792 appropriate.
793 * dispextern.h (draw_window_fringes, update_window_fringes)
794 (compute_fringe_widths):
795 * xterm.h (x_had_errors_p): Adjust prototype.
796
ec3058af
DA
7972013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
798
799 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
800 CHECK_LIST. Rewrite the loop to avoid useless local variable.
801
218e0637
DA
8022013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
803
804 * fns.c (toplevel): Remove comment before Fsafe_length because
805 it checks for QUIT.
806
e560aba9
PE
8072013-07-28 Paul Eggert <eggert@cs.ucla.edu>
808
809 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
810
2e5ce5de
EZ
8112013-07-28 Eli Zaretskii <eliz@gnu.org>
812
813 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
814 frame which got the message is still alive, before dereferencing
815 its pointer. (Bug#14970)
816
817 * frame.c (delete_frame): Test "this" frame's minibuffer window to
818 be a live window, before using it as such. (Bug#14970)
819
e95da6d3
EZ
8202013-07-27 Eli Zaretskii <eliz@gnu.org>
821
822 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
823 w32_detect_focus_change instead of doing part of its job by hand.
824 This fixes the problem whereby FOCUS_OUT events were not sent to
825 the event queue.
826
a8f93651
EZ
8272013-07-26 Eli Zaretskii <eliz@gnu.org>
828
fec92060
EZ
829 * process.c (Fprocess_list): Doc fix.
830
a8f93651
EZ
831 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
832 being re-exposed only if it didn't ask to become visible.
833 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
834 was previously iconified. (Bug#14841)
835 (x_iconify_frame): Mark the frame iconified.
836
d5a7a9d9
PE
8372013-07-26 Paul Eggert <eggert@cs.ucla.edu>
838
839 Fix minor problems found by static checking.
840 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
841 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
842
56ea7291
SM
8432013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
844
845 * eval.c (set_specpdl_old_value): New function.
846 (unbind_to): Minor simplification.
847 (get_backtrace_frame): New function.
848 (Fbacktrace_frame): Use it. Add `base' argument.
849 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
850 (syms_of_eval): Export backtrace-eval.
851 * xterm.c (x_focus_changed): Simplify.
852
9d611ffe
PE
8532013-07-25 Paul Eggert <eggert@cs.ucla.edu>
854
855 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
856
999c74e3
EZ
8572013-07-24 Eli Zaretskii <eliz@gnu.org>
858
859 * xdisp.c (redisplay_window): Instead of moving point out of
860 scroll margin, reject the force_start method, and try scrolling
861 instead. (Bug#14780)
862
198fa217
KB
8632013-07-24 Ken Brown <kbrown@cornell.edu>
864
865 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
866 (Bug#14944).
867
53840e55
PE
8682013-07-24 Paul Eggert <eggert@cs.ucla.edu>
869
870 * eval.c (Fprogn): Do not check that BODY is a proper list.
871 This undoes the previous change. The check slows down the
872 interpreter, and is not needed to prevent a crash. See
873 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
874
60967f56
GM
8752013-07-23 Glenn Morris <rgm@gnu.org>
876
877 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
878
9ca960e2
PE
8792013-07-23 Paul Eggert <eggert@cs.ucla.edu>
880
a29c3e6d
PE
881 Port to GNU/Linux systems with tinfo but not ncurses.
882 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
883 to decide whether ncurses is being used. Without this change,
884 GCC complains about tgetent not being declared, on a system
885 that has tinfo installed but ncurses not installed.
886
f274311c
PE
887 * eval.c (Fprogn): Check that BODY is a proper list.
888
16b0520a
PE
889 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
890 * data.c (Fsetq_default):
891 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
892 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
893 (Fcondition_case):
894 Tune by taking advantage of the fact that ARGS is always a list
895 when a function is declared to have UNEVALLED args.
896
9ca960e2
PE
897 * emacsgtkfixed.c: Port to GCC 4.6.
898 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
899
afacaa1b
JB
9002013-07-23 Juanma Barranquero <lekktu@gmail.com>
901
902 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
903 here to silence compiler warnings.
904
368a85a4
PE
9052013-07-22 Paul Eggert <eggert@cs.ucla.edu>
906
907 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
908 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
909 from messing up Emacs's 'struct frame' (Bug#14923).
910
f4e891b5
PE
9112013-07-21 Paul Eggert <eggert@cs.ucla.edu>
912
913 * alloc.c (make_save_ptr_ptr): Define this function.
914 It was inadvertently omitted. It's needed only if
915 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
916
96c8b65e
JD
9172013-07-21 Jan Djärv <jan.h.d@swipnet.se>
918
919 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
920 frame have focus (Bug#14895).
921
ee010797
PE
9222013-07-21 Paul Eggert <eggert@cs.ucla.edu>
923
924 Avoid vfork-related deadlock more cleanly.
925 * callproc.c (child_setup): When the child's exec fails, output
926 the program name, as that's more useful. Use O_NONBLOCK to avoid
927 deadlock.
928 * process.c (create_process_1): Remove; no longer needed.
929 (create_process): Remove timer hack; no longer needed, now that
930 the child avoids deadlock.
931
f0398ec1 9322013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
933
934 * image.c (Fimage_flush): Fix doc typo.
935
b2a069c2
PE
9362013-07-20 Paul Eggert <eggert@cs.ucla.edu>
937
6496aec9
PE
938 Fix array bounds violation when pty allocation fails.
939 * process.c (PTY_NAME_SIZE): New constant.
940 (pty_name): Remove static variable; it's now auto.
941 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
942 Take pty_name as an arg rather than using a static variable.
943 All callers changed.
944 (create_process): Recover pty_flag from process, not from volatile local.
945 (create_pty): Stay inside array even when pty allocation fails.
946 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
947
b2a069c2
PE
948 * lread.c (Fload): Avoid initialization only when lint checking.
949 Mention that it's needed only for older GCCs.
950
99107004
KH
9512013-07-20 Kenichi Handa <handa@gnu.org>
952
953 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
954 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
955
6b1b199d
AS
9562013-07-20 Andreas Schwab <schwab@linux-m68k.org>
957
958 * lread.c (Fload): Avoid uninitialized warning.
959
4195afc3
PE
9602013-07-19 Paul Eggert <eggert@cs.ucla.edu>
961
3f5bef16
PE
962 Fix some minor file descriptor leaks and related glitches.
963 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
964 (create_lock_file): Use write, not emacs_write.
965 * image.c (slurp_file, png_load_body):
966 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
967 (server_accept_connection):
968 Don't leak an fd on memory allocation failure.
969 * image.c (slurp_file): Add a cheap heuristic for growing files.
970 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
971 as that's what the other routines do. Maybe input need not be
972 blocked at all, but it's better to be consistent.
973 Avoid undefined behavior when strlen is zero.
974
4195afc3
PE
975 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
976 (NSTATICS): Now a constant; doesn't need to be a macro.
977
a1aeeffe
RS
9782013-07-19 Richard Stallman <rms@gnu.org>
979
980 * coding.c (decode_coding_utf_8): Add simple loop for fast
981 processing of ASCII characters.
982
63b34baa
PE
9832013-07-19 Paul Eggert <eggert@cs.ucla.edu>
984
985 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
986
621dd9ac
EZ
9872013-07-19 Eli Zaretskii <eliz@gnu.org>
988
989 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
990 unportable 'struct x_display_info'.
991 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
992 is a portable type.
993
1396ac86
PE
9942013-07-19 Paul Eggert <eggert@cs.ucla.edu>
995
ab9980cd
PE
996 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
997 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
998 or fscanf fails.
999 (system_process_attributes): Prefer plain char to unsigned char
1000 when either will do. Clean up properly if interrupted or if
1001 memory allocations fail. Don't assume sscanf succeeds. Remove
1002 no-longer-needed workaround to stop GCC from whining. Read
1003 command-line once, instead of multiple times. Check read status a
1004 bit more carefully.
1005
1396ac86
PE
1006 Fix obscure porting bug with varargs functions.
1007 The code assumed that int is treated like ptrdiff_t in a vararg
1008 function, which is not a portable assumption. There was a similar
1009 -- though these days less likely -- porting problem with various
1010 assumptions that pointers of different types all smell the same as
1011 far as vararg functions is conserved. To make this problem less
1012 likely in the future, redo the API to use varargs functions.
1013 * alloc.c (make_save_value): Remove this vararg function.
1014 All uses changed to ...
1015 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1016 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1017 New functions.
1018 (make_save_ptr): Rename from make_save_pointer, for consistency with
1019 the above. Define only on platforms that need it. All uses changed.
1020
4d19d194
PE
10212013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * keyboard.c: Try to fix typos in previous change.
1024 (DISPLAY_LIST_INFO): New macro.
1025 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1026 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1027
945c5bb1
JB
10282013-07-18 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * keyboard.c (kbd_buffer_get_event):
1031 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1032 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1033
f4b1eb36
PE
10342013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1035
5e679a2c
PE
1036 * filelock.c: Fix unlikely file descriptor leaks.
1037 (get_boot_time_1): Rework to avoid using emacs_open.
1038 This doesn't actually fix a leak, but is better anyway.
1039 (read_lock_data): Use read, not emacs_read.
1040
a8cd4836
PE
1041 * doc.c: Fix minor memory and file descriptor leaks.
1042 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1043 (get_doc_string, Fsnarf_documentation):
1044 Fix file descriptor leak on error.
1045
ef30e638
PE
1046 * term.c: Fix minor fdopen-related file descriptor leaks.
1047 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1048 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1049
f4b1eb36
PE
1050 * charset.c: Fix file descriptor leaks and errno issues.
1051 Include <errno.h>.
1052 (load_charset_map_from_file): Don't leak file descriptor on error.
1053 Use plain record_xmalloc since the allocation is larger than
1054 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1055 of entries.
1056 * eval.c (record_unwind_protect_nothing):
1057 * fileio.c (fclose_unwind):
1058 New functions.
1059 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1060 The replacement doesn't block input, but that no longer seems
1061 necessary.
1062
b648c163
PE
10632013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1064
a0931322
PE
1065 * lread.c: Fix file descriptor leaks and errno issues.
1066 (Fload): Close some races that leaked fds or streams when 'load'
1067 was interrupted.
1068 (Fload, openp): Report error number of last nontrivial failure to open.
1069 ENOENT counts as trivial.
1070 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1071 New functions.
1072 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1073 now that the function is always called with a nonnegative arg.
1074 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1075 All uses replaced with ...
1076 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1077
b648c163
PE
1078 A few more minor file errno-reporting bugs.
1079 * callproc.c (Fcall_process):
1080 * doc.c (Fsnarf_documentation):
1081 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1082 * process.c (set_socket_option):
1083 Don't let a constructor trash errno.
1084 * doc.c: Include <errno.h>.
1085
b1dc4084
JB
10862013-07-16 Juanma Barranquero <lekktu@gmail.com>
1087
1088 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1089
c43843aa
PE
10902013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1091
50a30cce
PE
1092 Fix w32 bug with call-process-region (Bug#14885).
1093 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1094 to Fcall_process when the input is empty. This simplifies the
1095 code a bit. It makes no difference on POSIXish platforms but
1096 apparently it fixes a bug on w32.
1097
44e18199 1098 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1099 * fileio.c (close_file_unwind): Don't close if FD is negative;
1100 this can happen when unwinding a zapped file descriptor.
1101 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1102 in case Emacs runs out of memory between the two unwind-protects.
1103 Don't trash errno when closing FD.
1104 Zap the FD in the specpdl when closing it, instead of deferring
1105 the removal of the unwind-protect; this fixes a bug where a child
1106 function unwinds the stack past us.
1107
27e498e6
PE
1108 New unwind-protect flavors to better type-check C callbacks.
1109 This also lessens the need to write wrappers for callbacks,
1110 and the need for make_save_pointer.
1111 * alloca.c (free_save_value):
1112 * atimer.c (run_all_atimers):
1113 Now extern.
1114 * alloc.c (safe_alloca_unwind):
1115 * atimer.c (unwind_stop_other_atimers):
1116 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1117 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1118 * minibuf.c (choose_minibuf_frame_1):
1119 * process.c (make_serial_process_unwind):
1120 * xdisp.h (pop_message_unwind):
1121 * xselect.c (queue_selection_requests_unwind):
1122 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1123 * alloca.c (record_xmalloc):
1124 Prefer record_unwind_protect_ptr to record_unwind_protect with
1125 make_save_pointer.
1126 * alloca.c (Fgarbage_collect):
1127 Prefer record_unwind_protect_void to passing a dummy.
1128 * buffer.c (restore_buffer):
1129 * window.c (restore_window_configuration):
1130 * xfns.c, w32fns.c (do_unwind_create_frame)
1131 New wrapper. All record-unwind uses of wrappee changed.
1132 * buffer.c (set_buffer_if_live):
1133 * callproc.c (call_process_cleanup, delete_temp_file):
1134 * coding.c (code_conversion_restore):
1135 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1136 * editfns.c (save_excursion_restore)
1137 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1138 (save_restriction_restore):
1139 * eval.c (restore_stack_limits, un_autoload):
1140 * fns.c (require_unwind):
1141 * keyboard.c (recursive_edit_unwind, tracking_off):
1142 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1143 * macros.c (pop_kbd_macro, restore_menu_items):
1144 * nsfns.m (unwind_create_frame):
1145 * print.c (print_unwind):
1146 * process.c (start_process_unwind):
1147 * search.c (unwind_set_match_data):
1148 * window.c (select_window_norecord, select_frame_norecord):
1149 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1150 (fast_set_selected_frame):
1151 * xfns.c, w32fns.c (unwind_create_tip_frame):
1152 Return void, not a dummy Lisp_Object. All uses changed.
1153 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1154 * callproc.c (call_process_kill):
1155 * fileio.c (restore_point_unwind, decide_coding_unwind)
1156 (build_annotations_unwind):
1157 * insdel.c (Fcombine_after_change_execute_1):
1158 * keyboard.c (read_char_help_form_unwind):
1159 * menu.c (unuse_menu_items):
1160 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1161 * sound.c (sound_cleanup):
1162 * xdisp.c (unwind_redisplay):
1163 * xfns.c (clean_up_dialog):
1164 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1165 Accept no args and return void, instead of accepting and returning
1166 a dummy Lisp_Object. All uses changed.
1167 * cygw32.c (fchdir_unwind):
1168 * fileio.c (close_file_unwind):
1169 * keyboard.c (restore_kboard_configuration):
1170 * lread.c (readevalllop_1):
1171 * process.c (wait_reading_process_output_unwind):
1172 Accept int and return void, rather than accepting an Emacs integer
1173 and returning a dummy object. In some cases this fixes an
1174 unlikely bug when the corresponding int is outside Emacs integer
1175 range. All uses changed.
1176 * dired.c (directory_files_internal_unwind):
1177 * fileio.c (do_auto_save_unwind):
1178 * gtkutil.c (pop_down_dialog):
1179 * insdel.c (reset_var_on_error):
1180 * lread.c (load_unwind):
1181 * xfns.c (clean_up_file_dialog):
1182 * xmenu.c, nsmenu.m (pop_down_menu):
1183 * xmenu.c (cleanup_widget_value_tree):
1184 * xselect.c (wait_for_property_change_unwind):
1185 Accept pointer and return void, rather than accepting an Emacs
1186 save value encapsulating the pointer and returning a dummy object.
1187 All uses changed.
1188 * editfns.c (Fformat): Update the saved pointer directly via
1189 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1190 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1191 (unwind_body): New function.
1192 (record_unwind_protect): First arg is now a function returning void,
1193 not a dummy Lisp_Object.
1194 (record_unwind_protect_ptr, record_unwind_protect_int)
1195 (record_unwind_protect_void): New functions.
1196 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1197 * fileio.c (struct auto_save_unwind): New type.
1198 (do_auto_save_unwind): Use it.
1199 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1200 * insdel.c (struct rvoe_arg): New type.
1201 (reset_var_on_error): Use it.
1202 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1203 New constants.
1204 (specbinding_func): Remove; there are now several such functions.
1205 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1206 (set_unwind_protect_ptr): New function.
1207 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1208
4e604a5d
PE
1209 Be simpler and more consistent about reporting I/O errors.
1210 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1211 Say "Read error" and "Write error", rather than "I/O error", or
1212 "IO error reading", or "IO error writing", when a read or write
1213 error occurs.
1214 * process.c (Fmake_network_process, wait_reading_process_output)
1215 (send_process, Fprocess_send_eof, wait_reading_process_output):
1216 Capitalize diagnostics consistently. Put "failed foo" at the
1217 start of the diagnostic, so that we don't capitalize the
1218 function name "foo". Consistently say "failed" for such
1219 diagnostics.
1220 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1221 All callers changed. This is so it can use report_file_error.
1222 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1223 diagnostics consistently as above.
1224
a9757f6a
PE
1225 * fileio.c (report_file_errno): Fix errno reporting bug.
1226 If the file name is neither null nor a pair, package it up as a
1227 singleton list. All callers changed, both to this function and to
1228 report_file_error. This fixes a bug where the memory allocator
1229 invoked by list1 set errno so that the immediately following
1230 report_file_error reported the wrong errno value.
1231
c43843aa
PE
1232 Fix minor problems found by --enable-gcc-warnings.
1233 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1234 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1235
18c26d81
JD
12362013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1239 Set event->arg to Qt if switch-event shall be generated.
1240 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1241
1242 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1243
1244 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1245 FOCUS_OUT_EVENT.
1246
1247 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1248 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1249 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1250 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1251 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1252 and there is a focused frame.
1253 (head_table): Add focus-in and focus-out.
1254 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1255 bind to handle-focus-in/out.
1256
1257 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1258 (Fhandle_switch_frame): Call Fhandle_focus_in.
1259 (syms_of_frame): defsubr handle-focus-in/out.
1260
6c6f1994
PE
12612013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1262
c7ddc792
PE
1263 Fix porting bug to older POSIXish platforms (Bug#14862).
1264 * sysdep.c (emacs_pipe): New function, that implements
1265 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1266 This should port better to CentOS 5 and to Mac OS X 10.6.
1267 All calls to pipe2 changed.
1268
6c6f1994
PE
1269 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1270 This makes the code easier to read and the executable a bit smaller.
1271 Do not replace all calls to Fcons that happen to create lists,
1272 just calls that are intended to create lists. For example, when
1273 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1274 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1275 Similarly for list2 through list5.
1276 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1277 * bytecode.c (exec_byte_code):
1278 * callint.c (quotify_arg, Fcall_interactively):
1279 * callproc.c (Fcall_process, create_temp_file):
1280 * charset.c (load_charset_map_from_file)
1281 (Fdefine_charset_internal, init_charset):
1282 * coding.c (get_translation_table, detect_coding_system)
1283 (Fcheck_coding_systems_region)
1284 (Fset_terminal_coding_system_internal)
1285 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1286 * composite.c (update_compositions, Ffind_composition_internal):
1287 * dired.c (directory_files_internal, file_name_completion)
1288 (Fsystem_users):
1289 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1290 * doc.c (Fsnarf_documentation):
1291 * editfns.c (Fmessage_box):
1292 * emacs.c (main):
1293 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1294 (Feval, eval_sub, Ffuncall, apply_lambda):
1295 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1296 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1297 (Fset_file_times, Finsert_file_contents)
1298 (Fchoose_write_coding_system, Fwrite_region):
1299 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1300 * font.c (font_registry_charsets, font_parse_fcname)
1301 (font_prepare_cache, font_update_drivers, Flist_fonts):
1302 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1303 * frame.c (make_frame, Fmake_terminal_frame)
1304 (x_set_frame_parameters, x_report_frame_params)
1305 (x_default_parameter, Fx_parse_geometry):
1306 * ftfont.c (syms_of_ftfont):
1307 * image.c (gif_load):
1308 * keyboard.c (command_loop_1):
1309 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1310 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1311 (Fminor_mode_key_binding, accessible_keymaps_1)
1312 (Faccessible_keymaps, Fwhere_is_internal):
1313 * lread.c (read_emacs_mule_char):
1314 * menu.c (find_and_return_menu_selection):
1315 * minibuf.c (get_minibuffer):
1316 * nsfns.m (Fns_perform_service):
1317 * nsfont.m (ns_script_to_charset):
1318 * nsmenu.m (ns_popup_dialog):
1319 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1320 (Fx_own_selection_internal):
1321 * nsterm.m (append2):
1322 * print.c (Fredirect_debugging_output)
1323 (print_prune_string_charset):
1324 * process.c (Fdelete_process, Fprocess_contact)
1325 (Fformat_network_address, set_socket_option)
1326 (read_and_dispose_of_process_output, write_queue_push)
1327 (send_process, exec_sentinel):
1328 * sound.c (Fplay_sound_internal):
1329 * textprop.c (validate_plist, add_properties)
1330 (Fput_text_property, Fadd_face_text_property)
1331 (copy_text_properties, text_property_list, syms_of_textprop):
1332 * unexaix.c (report_error):
1333 * unexcoff.c (report_error):
1334 * unexsol.c (unexec):
1335 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1336 (Fformat_mode_line, syms_of_xdisp):
1337 * xfaces.c (set_font_frame_param)
1338 (Finternal_lisp_face_attribute_values)
1339 (Finternal_merge_in_global_face, syms_of_xfaces):
1340 * xfns.c (x_default_scroll_bar_color_parameter)
1341 (x_default_font_parameter, x_create_tip_frame):
1342 * xfont.c (xfont_supported_scripts):
1343 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1344 (menu_help_callback, xmenu_show):
1345 * xml.c (make_dom):
1346 * xterm.c (set_wm_state):
1347 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1348 and similarly for list2 through list5.
1349
bafe80ce
PE
13502013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 * callproc.c (Fcall_process_region): Fix minor race and tune.
1353 (create_temp_file): New function, with the temp-file-creation part
1354 of the old Fcall_process_region. Use Fcopy_sequence to create the
1355 temp file name, rather than alloca + build_string, for simplicity.
1356 Don't bother to block input around the temp file creation;
1357 shouldn't be needed. Simplify use of mktemp. Use
1358 record_unwind_protect immediately after creating the temp file;
1359 this closes an unlikely race where the temp file was not removed.
1360 Use memcpy rather than an open-coded loop.
1361 (Fcall_process_region): Use the new function. If the input is
1362 empty, redirect from /dev/null rather than from a newly created
1363 empty temp file; this avoids unnecessary file system traffic.
1364
4700b5a5
PE
13652013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1366
5c97beae
PE
1367 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1368 Simplify by making this case like the other two. This is a bit
1369 slower on obsolete hosts, but the extra complexity isn't worth it.
1370
4700b5a5
PE
1371 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1372 * process.c (create_process) [!DOS_NT]:
1373 Remove now-unnecessary calls to emacs_close.
1374
f9a74c4c
EZ
13752013-07-13 Eli Zaretskii <eliz@gnu.org>
1376
922ae7ee
EZ
1377 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1378 returning early. (Bug#14850)
1379
f9a74c4c
EZ
1380 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1381 and inhibit-iso-escape-detection attributes of 'undecided'.
1382 (Bug#14822)
1383
5e301d76
PE
13842013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1385
69e0e5ee
PE
1386 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1387 Reported by Herbert J. Skuhra in
1388 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1389
5e301d76
PE
1390 Don't lose top specpdl entry when memory is exhausted.
1391 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1392 specpdl overflow here, to simplify callers; all callers changed.
1393 Always reserve an unused entry at the stack top; this avoids
1394 losing the top entry's information when memory is exhausted.
1395
7e649856
PE
13962013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1397
a773ed9a
PE
1398 Clean up errno reporting and fix some errno-reporting bugs.
1399 * callproc.c (Fcall_process):
1400 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1401 * process.c (create_process, Fmake_network_process):
1402 * unexaix.c (report_error):
1403 * unexcoff.c (report_error):
1404 Be more careful about reporting the errno of failed operations.
1405 The code previously reported the wrong errno sometimes.
1406 Also, prefer report_file_errno to setting errno + report_file_error.
1407 (Fcall_process): Look at openp return value rather than at path,
1408 as that's a bit faster and clearer when there's a numeric predicate.
1409 * fileio.c (report_file_errno): New function, with most of the
1410 old contents of report_file_error.
1411 (report_file_error): Use it.
1412 (Ffile_exists_p, Ffile_accessible_directory_p):
1413 Set errno to 0 when it is junk.
1414 * fileio.c (Faccess_file):
1415 * image.c (x_create_bitmap_from_file):
1416 Use faccessat rather than opening the file, to avoid the hassle of
1417 having a file descriptor open.
1418 * lisp.h (report_file_errno): New decl.
1419 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1420
7e649856
PE
1421 Minor EBADF fixes.
1422 * process.c (create_process, wait_reading_process_output) [AIX]:
1423 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1424 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1425 a multithreaded environment anyway).
1426 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1427
f6774c1a
AS
14282013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1429
1430 * image.c (x_find_image_file): Don't close a remote file handle.
1431
bacba3c2
PE
14322013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 Fix races with threads and file descriptors.
1435 * callproc.c (Fcall_process_region):
1436 * dired.c (open_directory):
1437 * emacs.c (main, Fdaemon_initialized):
1438 * image.c (x_find_image_file):
1439 * inotify.c (Finotify_rm_watch):
1440 * lread.c (Flocate_file_internal):
1441 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1442 * term.c (term_mouse_moveto, init_tty):
1443 * termcap.c (tgetent):
1444 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1445 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1446 * unexhp9k800.c, unexmacosx.c (unexec):
1447 * callproc.c (Fcall_process_region):
1448 Use emacs_close, not close.
1449 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1450 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1451 and posix_close function on current platforms (which all lack them).
1452 (emacs_close): Use it. This should fix the races on GNU/Linux and
1453 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1454 and it should avoid closing random victim file descriptors on
1455 other platforms.
1456
653d4f43
PE
14572013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1458
c8536ec4
PE
1459 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1460 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1461 Touch up doc a bit.
1462
9c203066
PE
1463 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1464 This is for .gdbinit xbacktrace.
1465
653d4f43
PE
1466 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1467 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1468 (emacs_set_tty): Now static.
1469 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1470 * term.c (tty_capable_p, tty_default_color_capabilities)
1471 (get_tty_terminal, term_mouse_movement)
1472 (handle_one_term_event, init_tty, maybe_fatal):
1473 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1474 (tgetent, scan_file, name_match, compare_contin):
1475 * terminal.c (get_terminal):
1476 Use bool for boolean.
1477 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1478 Prefer char to unsigned char if either will do.
1479 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1480 (tty_write_glyphs): Prefer int to unsigned.
1481 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1482 All callers changed.
1483 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1484
45b683a1
PE
14852013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1486
29abe551
PE
1487 Port to C89.
1488 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1489 (B__dummy__): New dummy symbol, to pacify C89.
1490 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1491 they can't grok varargs macros.
1492 * dispnew.c (add_window_display_history)
1493 (add_frame_display_history):
1494 * print.c (print_object):
1495 * xdisp.c (debug_method_add):
1496 Use %p printf format only for void pointers.
1497 * emacs.c (usage_message): New constant, replacing ...
1498 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1499 (main): Adjust to usage reorg.
1500 * fns.c (syms_of_fns):
1501 * profiler.c (syms_of_profiler):
1502 Don't use non-constant struct initializers.
1503 * gnutls.h (gnutls_initstage_t):
1504 * lisp.h (enum Lisp_Fwd_Type):
1505 * lread.c (lisp_file_lexically_bound_p):
1506 * xsettings.c (anonymous enum):
1507 Remove trailing comma.
1508 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1509 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1510 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1511 (DEFUN): Use it.
1512 * regex.c (const_re_char): New type, to pacify strict C89.
1513 All uses of 'const re_char' replaced to use it.
1514 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1515 with glibc when strict C89. This change is imported from gnulib.
1516 All uses changed.
1517 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1518 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1519 Omit GNU_LINUX implementation, since it requires long long.
1520 * xterm.c (x_draw_underwave):
1521 Do not assume the traditional order of struct's members.
1522 (x_term_init): Rewrite to avoid the need for non-constant structure
1523 initializers.
1524
45b683a1 1525 Syntax cleanup, mostly replacing macros with functions.
763a086d 1526 This removes the need for the syntax_temp hack.
45b683a1
PE
1527 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1528 * syntax.c (SYNTAX_INLINE): New macro.
1529 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1530 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1531 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1532 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1533 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1534 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1535 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1536 Now constants, not macros.
1537 (syntax_temp) [!__GNUC__]: Remove.
1538 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1539 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1540 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1541 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1542 Move here from syntax.h; now functions, not macros. Except for the
1543 last function, these are static since only syntax.c uses them.
1544 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1545 All uses changed. Now a function, not a macro; use this fact
1546 to simplify the code.
1547 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1548 compiler bugs; no longer relevant.
1549 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1550 (SYNTAX_INLINE): New macro.
1551 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1552 for the new functions. Use bool for boolean member.
1553 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1554 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1555 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1556 (SETUP_BUFFER_SYNTAX_TABLE):
1557 Now extern inline functions, not macros.
1558 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1559 Remove; all uses replaced by implementation.
1560 (syntax_temp) [!__GNUC__]: Remove decl.
1561 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1562
29be4a50
JD
15632013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1564
1565 * emacs.c (main): Fix syntax error.
1566
954b166e
PE
15672013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 Timestamp fixes for undo (Bug#14824).
1570 * atimer.c (schedule_atimer):
1571 * fileio.c (Ffile_newer_than_file_p):
1572 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1573 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1574 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1575 (syms_of_fileio): Remove Sclear_visited_file_name.
1576 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1577 file doesn't exist; this avoids an ambiguity with negative timestamps.
1578 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1579 * systime.h (make_emacs_time, invalid_emacs_time):
1580 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1581 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1582 * undo.c (record_first_change): Push (visited-file-modtime) onto
1583 undo list rather than reimplementing it by hand, incorrectly.
1584
d74647c3
KB
15852013-07-09 Ken Brown <kbrown@cornell.edu>
1586
1587 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1588
3c51b96b
JB
15892013-07-09 Juanma Barranquero <lekktu@gmail.com>
1590
1591 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1592
4ebbdd67
PE
15932013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1594
1595 Handle errno and exit status a bit more carefully.
1596 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1597 number into an exit status. Instead, use EXIT_CANCELED.
1598 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1599 * callproc.c (relocate_fd):
1600 * emacs.c (close_output_streams, main):
1601 * process.c (create_process):
1602 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1603 Use emacs_perror for simplicity.
1604 * callproc.c (relocate_fd, main):
1605 * sysdep.c (sys_subshell):
1606 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1607 (shut_down_emacs): Use emacs_write, not write.
1608 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1609 * fileio.c (Fcopy_file, e_write):
1610 * nsterm.m (ns_select):
1611 * process.c (send_process):
1612 * sound.c (vox_write):
1613 Use emacs_write_sig, not emacs_write.
1614 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1615 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1616 New constants.
1617 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1618 of write.
1619 (emacs_full_write): New function.
1620 (emacs_write): Rewrite to use it.
1621 (emacswrite_sig, emacs_perror): New functions.
1622 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1623
44e18199 16242013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1625
1626 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1627 on NS even if it is present. Pixmap on NS is a void*.
1628
9caab067
PE
16292013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 Port to Ubuntu 10 (Bug#14803).
1632 Problem reported by T.V. Raman.
1633 * process.c (close_on_exec, accept4, process_socket):
1634 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1635
1d442672
EZ
16362013-07-07 Eli Zaretskii <eliz@gnu.org>
1637
1638 * w32.c (sys_dup): Declare prototype.
1639
1640 * filelock.c:
1641 * emacs.c:
1642 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1643
067428c1
PE
16442013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 Make file descriptors close-on-exec when possible (Bug#14803).
1647 This simplifies Emacs a bit, since it no longer needs to worry
1648 about closing file descriptors by hand in some cases.
1649 It also fixes some unlikely races. Not all such races, as
1650 libraries often open files internally without setting
1651 close-on-exec, but it's an improvement.
1652 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1653 * callproc.c (Fcall_process) [!MSDOS]:
1654 * emacs.c (main) [!DOS_NT]:
1655 * nsterm.m (ns_term_init):
1656 * process.c (create_process):
1657 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1658 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1659 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1660 Prefer mkostemp with O_CLOEXEC to mkstemp.
1661 * callproc.c (relocate_fd) [!WINDOWSNT]:
1662 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1663 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1664 now using pipe2.
1665 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1666 Make the resulting file descriptor close-on-exec.
1667 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1668 * lread.c (load_descriptor_list, load_descriptor_unwind):
1669 Remove; no longer needed. All uses removed.
1670 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1671 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1672 New functions.
1673 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1674 (Fmake_network_process, Fnetwork_interface_list):
1675 (Fnetwork_interface_info, server_accept_connection):
1676 Make newly-created socket close-on-exec.
1677 * sysdep.c (emacs_open, emacs_fopen):
1678 Make new-created descriptor close-on-exec.
1679 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1680 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1681
0da857dd
JD
16822013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1683
1684 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1685 for NS_IMPL_GNUSTEP.
1686
5f86adcd
PE
16872013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 Fix openp errno handling.
1690 * callproc.c (Fcall_process): Preserve openp errno around close.
1691 * lread.c (openp): Set errno when returning -1, as some callers
1692 expect this.
1693
1afb1d07
JD
16942013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1695
1696 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1697
1698 * nsterm.h (NSSavePanel): Update comment.
1699 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1700 (ns_run_file_dialog): Declare.
1701
1702 * nsfns.m: Remove panelOK.
1703 (ns_fd_data): New.
1704 (ns_run_file_dialog): New function.
1705 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1706 event loop, so file dialog is popped up by ns_run_file_dialog, called
1707 by sendEvent (Bug#14578).
1708 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1709
3323c263
EZ
17102013-07-06 Eli Zaretskii <eliz@gnu.org>
1711
fdda0220
EZ
1712 * xdisp.c (default_line_pixel_height): New function.
1713 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1714 (try_cursor_movement, redisplay_window, try_window)
1715 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1716
1717 * window.c (window_scroll_pixel_based): use
1718 default_line_pixel_height.
1719
1720 * dispextern.h (default_line_pixel_height): Add prototype.
1721
1722 * frame.c (x_set_line_spacing): Accept a float value for
1723 line-spacing parameter, per the documentation.
1724
3323c263
EZ
1725 * data.c (Fmultibyte_string_p): Doc fix.
1726
47ba6d43
PE
17272013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1728
406af475
PE
1729 Use emacs_open more consistently when opening files.
1730 This handles EINTR more consistently now, and makes it easier
1731 to introduce other uniform changes to file descriptor handling.
1732 * src/systdio.h: New file.
1733 * src/buffer.c (mmap_init):
1734 * cygw32.c (chdir_to_default_directory):
1735 * dispnew.c (Fopen_termscript):
1736 * emacs.c (Fdaemon_initialized):
1737 * fileio.c (Fdo_auto_save):
1738 * image.c (slurp_file, png_load_body, jpeg_load_body):
1739 * keyboard.c (Fopen_dribble_file):
1740 * lread.c (Fload):
1741 * print.c (Fredirect_debugging_output):
1742 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1743 * termcap.c (tgetent):
1744 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1745 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1746 * w32term.c (w32_initialize) [CYGWIN]:
1747 * xfaces.c (Fx_load_color_file):
1748 Use emacs_open instead of plain open, and emacs_fopen instead of
1749 plain fopen.
1750 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1751 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1752 * callproc.c (default_output_mode): New constant.
1753 (Fcall_process): Use it to call emacs_open instead of plain creat.
1754 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1755 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1756 (emacs_fopen): New function.
1757 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1758 Include <lisp.h>, for emacs_open.
1759 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1760
47ba6d43
PE
1761 Remove duplicate #include directives.
1762 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1763 * xfaces.c:
1764 Don't include stdio.h twice.
1765 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1766 Don't include sys/types.h or stdio.h twice.
1767 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1768 * lread.c: Don't include coding.h twice.
1769 * nsfont.m: Don't include frame.h twice.
1770 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1771 * ralloc.c: Don't include <unistd.h> twice.
1772 * xdisp.c: Don't include font.h twice.
1773 * xterm.c: Don't include fontset.h twice.
1774 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1775
b9ed53d5
PE
17762013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 Scale ImageMagick images more carefully.
1779 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1780 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1781 Be more careful about avoiding undefined behavior after
1782 integer overflow and division by zero.
1783
cf13177e
YM
17842013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1785
1786 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1787 (syms_of_w32fns): DEFSYM them.
1788 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1789 (CCHDEVICENAME): Define macros if not defined.
1790 (struct MONITOR_INFO_EX): New struct.
1791 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1792 (enum_display_monitors_fn): New variable.
1793 (globals_of_w32fns): Initialize it.
1794 (Fx_display_pixel_width, Fx_display_pixel_height)
1795 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1796 multi-monitor setups in docstrings.
1797 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1798 screen size by primary monitor's millimeter per pixel.
1799 (w32_monitor_enum, w32_display_monitor_attributes_list)
1800 (w32_display_monitor_attributes_list_fallback)
1801 (Fw32_display_monitor_attributes_list): New functions.
1802 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1803
1804 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1805 if not defined.
1806 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1807
86dfb7a8
MA
18082013-07-04 Michael Albinus <michael.albinus@gmx.de>
1809
1810 * fileio.c (Qfile_notify_error): New error symbol.
1811
1812 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1813 * inotify.c (inotify_callback, symbol_to_inotifymask)
1814 (Finotify_add_watch, Finotify_rm_watch): Use it.
1815 (inotifyevent_to_event): Exchange order of cookie and file name.
1816 (Finotify_add_watch): Adapt docstring.
1817
1818 * lisp.h (Qfile_notify_error): Declare.
1819
2c1c974b
PE
18202013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1821
1822 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1823 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1824 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1825 which did not work (see <http://bugs.gnu.org/14569#307>).
1826 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1827 && (!noninteractive || initialized)). This attempts to thread
1828 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1829
7a35b20f
JB
18302013-07-04 Juanma Barranquero <lekktu@gmail.com>
1831
1832 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1833 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1834
1ce5cd04
PE
18352013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1838 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1839 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1840 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1841
57f8c490
PE
18422013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1845 Define to __sys_siglist.
1846
bcffb5ca
EZ
18472013-07-02 Eli Zaretskii <eliz@gnu.org>
1848
1849 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1850 word-wrap, so that overflow-newline-into-fringe would work in
1851 visual-line-mode. (Bug#2749)
1852 (move_it_in_display_line_to): When the last scanned display
1853 element fits exactly on the display line, and
1854 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1855 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1856 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1857 finding buffer position that corresponds to pixel coordinates,
1858 e.g. in buffer_posn_from_coords.
1859
2c41e781
JD
18602013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1861
1862 * process.c (handle_child_signal): Call catch_child_signal if
1863 NS_IMPL_GNUSTEP.
1864
c2418359
PE
18652013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1866
52a9bcae
PE
1867 Don't convert function pointers to void * and back.
1868 It isn't portable C, and it's easy enough to avoid.
1869 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1870 (make_save_value): Add support for SAVE_FUNCPOINTER.
1871 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1872 * print.c (print_object):
1873 Distinguish function from object pointers.
1874 * lisp.h (SAVE_FUNCPOINTER): New constant.
1875 (SAVE_SLOT_BITS): Adjust to it.
1876 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1877 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1878 (voidfuncptr): New typedef.
1879 (struct Lisp_Save_Value): New member data[0].funcpointer.
1880 (XSAVE_FUNCPOINTER): New function.
1881
c2418359
PE
1882 Simplify buildobj processing.
1883 * Makefile.in (buildobj.h): Make it a sequence of strings each
1884 followed by comma, rather than a single string. Put it into a
1885 .tmp file in case there's an error while generating it.
1886 (gl-stamp): Use .tmp for temp files.
1887 (mostlyclean): Clean .tmp files.
1888 * doc.c (buildobj): Move to just the routine that needs it.
1889 It's now an array of strings, so processing is simpler.
1890
8f43ce49
PE
18912013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1894 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1895 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1896 Invoke malloc_enable_thread even when not interactive.
1897 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1898 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1899 in this case, since the underlying bug has now been fixed.
1900
24827db9
JB
19012013-07-01 Juanma Barranquero <lekktu@gmail.com>
1902
1903 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1904 unlinking it (bug#14691).
1905
ef099a94
MN
19062013-06-30 Michal Nazarewicz <mina86@mina86.com>
1907
1908 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1909 before checking whether buffer is modified. This lets
1910 `kill-buffer-query-functions' cancel killing of the buffer or save
1911 its content before `kill-buffer' asks user the "Buffer %s
1912 modified; kill anyway?" question.
1913
9d3f2fc2
JD
19142013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1915
1916 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1917 Let the super performKeyEquivalent deal with them (Bug#14747).
1918
e6c6c8c7
PE
19192013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1920
1d71c1d9
PE
1921 * widget.c (resize_cb): Remove unused local.
1922
8f5f35cc
PE
1923 Do not use GTK 3 if it exists but cannot be compiled.
1924 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1925 * xterm.c (x_error_handler) [!USE_GTK]:
1926 Do not use GTK 3.
1927
e6c6c8c7
PE
1928 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1929
0ba54312
EZ
19302013-06-30 Eli Zaretskii <eliz@gnu.org>
1931
5d1c3286
EZ
1932 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1933 to the valid range of values. (Bug#14753)
1934
0ba54312
EZ
1935 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1936 when moving point by using the current glyph matrix. This avoids
1937 the need to force redisplay when this function is called in a
1938 loop.
1939
9c90cc06
PE
19402013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 Fix minor problems found by static checking.
1943 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1944 Redo the latter's body to sidestep GCC parenthesization warnings.
1945 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1946 * coding.c (detect_coding, detect_coding_system):
1947 * coding.h (struct undecided_spec):
1948 Use bool for boolean.
1949 * image.c (QCmax_width, QCmax_height): Now static.
1950 * xdisp.c (Fmove_point_visually): Remove unused local.
1951
4c672a0f
EZ
19522013-06-29 Eli Zaretskii <eliz@gnu.org>
1953
1954 * xdisp.c (Fmove_point_visually): New function.
1955
c1ea3abf
JB
19562013-06-28 Kenichi Handa <handa@gnu.org>
1957
1958 * coding.h (define_coding_undecided_arg_index): New enum.
1959 (coding_attr_index): New members
1960 coding_attr_undecided_inhibit_null_byte_detection,
1961 coding_attr_undecided_inhibit_iso_escape_detection,
1962 coding_attr_undecided_prefer_utf_8.
1963 (undecided_spec): New struct.
1964 (struct coding_system): New member `undecided' of the member
1965 `spec'.
1966
1967 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1968 (detect_coding): Likewise.
1969 (detect_coding_system): Likewise.
1970 (Fdefine_coding_system_internal): New coding system properties
1971 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1972 :prefer-utf-8.
1973 (syms_of_coding): Adjust for coding_arg_undecided_max.
1974
ba3de9e6
PE
19752013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 * image.c (x_from_xcolors): Remove unused local.
1978
547c9269
YM
19792013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1980
1981 Defer image data transfer between X client and server until actual
1982 display happens.
1983
1984 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1985 and `mask_img'.
1986
1987 * image.c (Destroy_Image): Remove.
1988 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1989 `mask_p', and `colors_p'. All uses changed.
1990 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1991 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1992 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1993 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1994 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1995 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1996 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1997 (image_get_x_image, image_unget_x_image): New functions or macros.
1998 (image_background, image_background_transparent, x_to_xcolors)
1999 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2000 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2001 instead of Destroy_Image.
2002 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2003 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2004 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2005 (imagemagick_load_image, svg_load_image): Use them instead of
2006 x_create_x_image_and_pixmap, and x_put_x_image followed by
2007 x_destroy_x_image, respectively.
2008 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2009 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2010 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2011 background_transparent fields.
2012 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2013 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2014
dae2f5ef
PE
20152013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2016
2017 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2018 This mostly consists of undoing recent changes.
2019 * callproc.c (Fcall_process):
2020 * process.c (create_process):
2021 Do not worry about catching SIGCHLD here, undoing previous change.
2022 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2023 * process.c, process.h (catch_child_signal):
2024 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2025 * process.c (catch_child_handler): Don't worry about being called
2026 lazily and do not assume caller has blocked SIGCHLD, undoing
2027 previous change. Move first-time stuff back to
2028 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2029 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2030 set lib_child_handler if it's already initialized, which may
2031 help avoid problems on GNUStep.
2032
fa55d2aa
PE
20332013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2036 * callproc.c (Fcall_process):
2037 * process.c (create_process):
2038 Make sure SIGCHLD is caught before we fork,
2039 since Emacs startup no arranges to catch SIGCHLD.
2040 * process.c (lib_child_handler): Initialize to null, not to
2041 dummy_handler.
2042 (catch_child_signal): Allow self to be called lazily.
2043 Do nothing if it's already been called.
2044 Assume caller has blocked SIGCHLD (all callers do now).
2045 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2046 just before it's really needed.
2047 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2048 since it hasn't been caught yet.
2049
f3f9606c
LMI
20502013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2051
2052 * image.c (compute_image_size): New function to implement
2053 :max-width and :max-height.
2054 (imagemagick_load_image): Use it.
2055
c7041908
PE
20562013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2059 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2060 Now extern.
2061 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2062 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2063 the SIGCHLD handler, since the code is not atomic and (due to glib)
2064 signals may be arriving now.
2065 * sysdep.c (init_signals): Do not catch child signals here;
2066 'main' now does that later, at a safer time.
2067
f86852b4
PE
20682013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2069
0dfeed58
PE
2070 Clean up SIGCHLD handling a bit (Bug#14569).
2071 * process.c, process.h (catch_child_signal):
2072 Now always extern, even if !NS_IMPL_GNUSTEP.
2073 * process.c (catch_child_signal): Move glib tickler here from
2074 init_process_emacs, so that it's done earlier in Emacs
2075 initialization. Also move the noninteractive && !initialized
2076 check here from init_process_emacs. This is all a bit cleaner for
2077 GNUish platforms, and I hope it works around the Cygwin bug.
2078 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2079 that glib signal handling is tickled before glib creates threads.
2080
f86852b4
PE
2081 * process.c (wait_reading_process_output): Avoid int overflow
2082 when reading more than 2 GiB total from a process.
2083
cbd6509c
PE
20842013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 * process.c (create_process): Handle a couple more cases,
2087 i.e., work even if new_argv and wait_child_setup[i] are cached.
2088 Use Fcall_process's style for volatile vars.
2089
9de1114a
AS
20902013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2091
2092 * process.c (create_process): Mark PROCESS volatile.
2093
fbe9e0b9
PE
20942013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 Use C99-style flexible array members if available.
2097 This avoids some subtle aliasing issues, which typically
2098 aren't a problem with GCC but may be a problem elsewhere.
2099 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2100 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2101 In either case, it uses a flexible array member rather than
2102 the old struct hack. All uses changed.
2103 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2104 Adjust to sdata reorganization.
2105 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2106 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2107 that ports better to pre-C99 non-GCC.
2108 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2109 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2110 as the latter has changed.
2111 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2112 and port better to pre-C99 GCC.
2113 * image.c (struct xpm_cached_color):
2114 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2115 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2116 Use FLEXIBLE_ARRAY_MEMBER.
2117 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2118 Move decl to top level so it gets checked against implementation.
2119 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2120 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2121
1fc71008
PE
21222013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 * syntax.c: Integer cleanups.
2125 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2126 All uses that need 0-or-2 changed to:
2127 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2128 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2129 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2130 (char_quoted, prev_char_comend_first, back_comment)
2131 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2132 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2133 Use bool for boolean.
2134 (update_syntax_table, skip_chars, skip_syntaxes):
2135 Prefer int to unsigned when either will do.
2136 (back_comment): Return boolean success flag, like forw_comment,
2137 instead of positive-or-minus-1 (which might have overflowed int anyway).
2138 Don't stuff ptrdiff_t into int.
2139 (syntax_spec_code, syntax_code_spec): Now const.
2140 (Fmatching_paren, scan_lists, scan_sexps_forward):
2141 Use enum syntaxcode for syntax code.
2142 (Fmatching_paren): Check that arg is a character, not just an integer.
2143 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2144 (Finternal_describe_syntax_value): Omit no-longer-needed
2145 comparison to 0.
2146 (skip_chars): Use char, not unsigned char, when the distinction
2147 doesn't matter.
2148 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2149 * bytecode.c (exec_byte_code):
2150 * syntax.c (syntax_spec_code, Fchar_syntax)
2151 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2152 (init_syntax_once):
2153 * syntax.h (SYNTAX_WITH_FLAGS):
2154 Omit unnecessary casts.
2155
b932cad7
EZ
21562013-06-20 Eli Zaretskii <eliz@gnu.org>
2157
2158 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2159 line dimensions here, to avoid race conditions with the main
2160 thread. (Bug#14062, bug#14630, bug#14669)
2161
2162 * w32term.c (w32_draw_window_cursor): Compute the header line and
2163 mode line dimensions here.
2164 <w32_system_caret_window, w32_system_caret_hdr_height>:
2165 <w32_system_caret_mode_height>: New variables.
2166
2167 * w32term.h: Declare them.
2168
89561f72
PE
21692013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2170
5013fc08
PE
2171 * alloc.c (die): Move "assertion failed" string here ...
2172 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2173 COND when SUPPRESS_CHECKING. This shrinks the executable text
2174 size by 0.8% to 2.2% when configured with --enable-checking,
2175 depending on optimization flags (GCC 4.8.1 x86-64).
2176
89561f72
PE
2177 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2178
763a086d 21792013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2180
2181 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2182 base is 2; this is more accurate.
2183
983aeb9a
JB
21842013-06-19 Juanma Barranquero <lekktu@gmail.com>
2185
2186 * sound.c (string_default): Move to !WINDOWSNT section.
2187 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2188
178ba3e6
PE
21892013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2190
bbc51b15
PE
2191 * sound.c: Integer cleanups.
2192 Remove unnecessary forward decls.
2193 (struct sound_device): The 'file' member is now a Lisp_Object, not
2194 a char *, so that we needn't invoke alloca on a huge size.
2195 (Fplay_sound_internal): Adjust to this.
2196 (string_default): New function.
2197 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2198 Use it to adjust to the struct sound_device change.
2199 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2200 (be2hs) [0]: Remove.
2201
178ba3e6
PE
2202 * syntax.c (skip_chars): Don't use uninitialized storage
2203 when searching a multibyte buffer for characters that are not in a
2204 unibyte string that contains non-ASCII characters.
2205
69f60cdc
JD
22062013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2207
2208 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2209 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2210
0d6224d4
PE
22112013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2214
3c542890
KH
22152013-06-18 Kenichi Handa <handa@gnu.org>
2216
f7e3f7cd
KH
2217 * font.c (Ffont_spec): Signal an error for an invalid font name
2218 (Bug#14648).
3c542890 2219
9349e5f7
PE
22202013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2221
2222 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2223 In particular this ports to 32-bit sparc Sun cc.
2224 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2225 array with a dummy element at specpdl[-1], so that its address can
2226 be taken portably.
2227 (unbind_to): Do not copy the binding; not needed, now that we
2228 copy old_value in the one place where the copy is needed.
2229 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2230 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2231 (union specbinding): Rename from struct specbinding. Redo layout
2232 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2233 which is not portable. With Sun C 5.12 32-bit sparc, the
2234 declaration causes nargs to be an unsigned bitfield, a behavior
2235 that the C standard allows; but Emacs wants nargs to be signed.
2236 The overall type is now a union of structures rather than a
2237 structure of union of structures, and the 'kind' member is now a
2238 bitfield, so that the overall type doesn't grow. All uses changed.
2239 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2240
0a4df6a5
PE
22412013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2242
ec6ecaad
PE
2243 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2244 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2245
0a4df6a5
PE
2246 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2247
7bfe8dbc
EZ
22482013-06-17 Eli Zaretskii <eliz@gnu.org>
2249
2250 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2251 unless we know that the window w's frame is a frame object.
2252 Another attempt at solving bug#14062 and bug#14630.
2253
708e05f6
LMI
22542013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2255
2256 * textprop.c (property_set_type): New enum.
2257 (add_properties): Allow appending/prepending text properties.
2258 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2259 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2260 add_text_properties_1.
2261 (Fadd_face_text_property): New function that calls
2262 add_text_properties_1.
2263
84575e67
PE
22642013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2265
2266 Move functions from lisp.h to individual modules when possible.
2267 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2268 * alloc.c (XFLOAT_INIT, set_symbol_name):
2269 * buffer.c (CHECK_OVERLAY):
2270 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2271 (set_char_table_parent):
2272 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2273 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2274 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2275 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2276 (set_blv_valcell):
2277 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2278 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2279 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2280 (backtrace_args, backtrace_debug_on_exit):
2281 * floatfns.c (CHECK_FLOAT):
2282 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2283 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2284 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2285 (set_hash_index_slot):
2286 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2287 * marker.c (CHECK_MARKER):
2288 * textprop.c (CHECK_STRING_OR_BUFFER):
2289 * window.c (CHECK_WINDOW_CONFIGURATION):
2290 Move here from lisp.h, and make these functions static rather than
2291 extern inline.
2292 * buffer.c (Qoverlayp):
2293 * data.c (Qsubrp):
2294 * fns.c (Qhash_table_p):
2295 * window.c (Qwindow_configuration_p):
2296 Now static.
2297 * lisp.h: Remove the abovementioned defns and decls.
2298
44e18199 2299 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2300 In lisp.h, prefer functions to function-like macros, and
2301 constants to object-like macros, when either will do. This:
2302 . simplifies use, as there's no more need to worry about
2303 arguments' side effects being evaluated multiple times.
2304 . makes the code easier to debug on some platforms.
2305 However, when using gcc -O0, keep using function-like macros
2306 for a few critical operations, for performance reasons.
2307 This sort of thing isn't needed with gcc -Og, but -Og
2308 is a GCC 4.8 feature and isn't widely-enough available yet.
2309 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2310 Remove enum lsb_bits; no longer needed.
2311 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2312 * buffer.c (Qoverlap):
2313 * data.c (Qsubrp):
2314 * fns.c (Qhash_table_p):
2315 Now extern, so lisp.h can use these symbols.
2316 * dispextern.h: Include character.h, for MAX_CHAR etc.
2317 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2318 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2319 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2320 (GLYPH_CODE_P): Move here from lisp.h.
2321 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2322 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2323 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2324 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2325 XUNTAG now returns void *.
2326 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2327 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2328 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2329 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2330 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2331 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2332 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2333 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2334 New macros, renamed from their sans-lisp_h_ counterparts.
2335 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2336 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2337 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2338 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2339 If compiling via GCC without optimization, define these as macros
2340 in addition to inline functions.
2341 To disable this, compile with -DINLINING=0.
2342 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2343 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2344 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2345 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2346 (INTMASK, VALMASK): Now macros, since static values cannot be
2347 accessed from extern inline functions.
2348 (VALMASK): Also a constant, for benefit of old GDB.
2349 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2350 is INTEGERP, which can fold it in.
5165d44a 2351 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2352 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2353 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2354 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2355 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2356 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2357 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2358 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2359 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2360 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2361 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2362 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2363 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2364 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2365 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2366 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2367 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2368 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2369 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2370 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2371 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2372 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2373 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2374 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2375 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2376 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2377 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2378 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2379 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2380 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2381 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2382 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2383 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2384 Now functions.
2385 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2386 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2387 (VALMASK): Define in one place rather than in two, merging the
2388 USE_LSB_TAG parts; this is simpler.
2389 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2390 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2391 Move up, to avoid use before definition.
2392 Also include "globals.h" earlier, for the same reason.
2393 (make_natnum): New function.
2394 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2395 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2396 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2397 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2398 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2399 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2400 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2401 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2402 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2403 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2404 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2405 (Qwindow_configuration_p, Qimage): New forward declarations.
2406 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2407 (STRING_COPYIN): Remove; unused.
2408 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2409 (xcar_addr, xcdr_addr): New functions. All uses changed.
2410 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2411 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2412 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2413 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2414 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2415 (TYPE_RANGED_INTEGERP): Simplify.
2416 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2417 (setlocale, fixup_locale, synchronize_system_messages_locale)
2418 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2419 Now empty functions, not macros.
2420 (functionp): Return bool, not int.
2421 * window.c (Qwindow_configuration_p): Now extern,
2422 so window.h can use it.
2423 * window.h (Qwindowp): Move decl back to lisp.h.
2424
9583ec36
EZ
24252013-06-15 Eli Zaretskii <eliz@gnu.org>
2426
2427 * xdisp.c (Fline_pixel_height): New function, required for solving
2428 bug #14567.
2429
210272ce
PE
24302013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2431
2432 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2433
de0503df
SM
24342013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2435
2436 * lread.c (syms_of_lread):
2437 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2438
afbfe143
KD
24392013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2440
2441 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2442
d177e213
XF
24432013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2444
2445 * fileio.c (expand_file_name): Doc fix.
2446
05e3e412
PE
24472013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2448
f7394b12
PE
2449 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2450 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2451 Wait for self, not for 0. This can't hurt on GNU or similar
2452 system, and may help with Cygwin.
2453
05e3e412
PE
2454 * keyboard.c: Don't use PROP (...) as an lvalue.
2455 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2456 Use set_prop (A, B), not PROP (A) = B.
2457
17dd3097
EZ
24582013-06-10 Eli Zaretskii <eliz@gnu.org>
2459
2460 * xdisp.c (get_it_property): Use it->window instead of generating
2461 a Lisp object from it->w.
2462
52fab9c9
EZ
24632013-06-09 Eli Zaretskii <eliz@gnu.org>
2464
2465 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2466 get-char-property the window that is being rendered, instead of
2467 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2468 (compute_display_string_pos): When W is NULL, use the current
2469 buffer as the object to pass to get-char-property.
2470 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2471 pointer member of the bidi iterator, since no window is pertinent
2472 to this function.
52fab9c9 2473
5bf97bfc
EZ
24742013-06-08 Eli Zaretskii <eliz@gnu.org>
2475
2476 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2477 being displayed, and pass it to compute_display_string_pos.
2478 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2479 (bidi_paragraph_init): All callers changed.
2480
2481 * xdisp.c (init_from_display_pos, init_iterator)
2482 (handle_single_display_spec, next_overlay_string)
2483 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2484 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2485 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2486 (compute_display_string_pos): Accept additional argument, the
2487 window being displayed, and pass it to Fget_char_property.
2488 (Bug#14575)
2489
2490 * dispextern.h (struct bidi_it): New member w, the window being
2491 displayed.
2492 (compute_display_string_pos): Adjust prototype.
2493
5de0e011
JD
24942013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2495
e7b41c4c 2496 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2497
2498 * process.c (wait_reading_process_output): Check for NS before GLIB.
2499 GLIB may be linked in due to rsvg, but ns_select must be called.
2500
5de0e011
JD
2501 * xgselect.c (xg_select): Remove call to window_system_available
2502 and g_main_context_pending at the top, so Gdk events (i.e. file
2503 notify) are processed when Emacs is started with -nw.
2504
a822acff
EZ
25052013-06-07 Eli Zaretskii <eliz@gnu.org>
2506
2507 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2508 (ctagsfiles3): New variable, includes only *.m files.
2509 (TAGS): Use an explicit language name in the regular expressions,
2510 to avoid transformation of '/SOMETHING' by MSYS to
2511 'c:\MSYS\SOMETHING'.
2512
6c0a9ed1
RC
25132013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2514
2515 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2516
9ef6111b
EZ
25172013-06-06 Eli Zaretskii <eliz@gnu.org>
2518
2519 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2520 still need to set the mouse pointer shape and activate help-echo.
2521 (Bug#14558)
2522
7d300d64
PE
25232013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2524
2525 A few porting etc. fixes for the new file monitor code.
2526 See the thread containing
2527 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2528 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2529 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2530 (dir_monitor_callback, Fgfile_rm_watch):
2531 Use assq_no_quit instead of Fassoc, for speed.
2532 (dir_monitor_callback, Fgfile_rm_watch):
2533 eassert that the monitor is a fixnum.
2534 (dir_monitor_callback): No need for CDR_SAFE.
2535 Simplify building of lisp with alternative tails.
2536 (Fgfile_add_watch, Fgfile_rm_watch):
2537 Do not assume glib functions set errno reliably on failure.
2538 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2539 and signal an error otherwise.
2540 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2541 Use Fdelq instead of Fdelete, for speed.
2542
817ebfcf
EZ
25432013-06-05 Eli Zaretskii <eliz@gnu.org>
2544
2545 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2546 don't insist on being invoked on a highlighted tool-bar button.
2547 Avoids losing tool-bar functionality when mouse-highlight is nil.
2548 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2549 Don't highlight when mouse-highlight is nil.
2550 (note_mouse_highlight): When mouse-highlight is nil, don't return
2551 right away; instead, run tool-bar and mode-line highlight
2552 subroutine, clear any existing highlight, and revert the mouse
2553 pointer to its default shape. (Bug#14558)
2554
55577e7c
SM
25552013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2556
2557 * lisp.mk (lisp): Add prog-mode.el.
2558
f019a684
PE
25592013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2560
2561 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2562 * process.c (dummy_handler): New function.
2563 (lib_child_handler): New static var.
2564 (handle_child_signal): Invoke it.
2565 (catch_child_signal): If a library has set up a signal handler,
2566 save it into lib_child_handler.
2567 (init_process_emacs): If using glib and not on Windows, tickle glib's
2568 child-handling code so that it initializes its private SIGCHLD handler.
2569 * syssignal.h (SA_SIGINFO): Default to 0.
2570 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2571 31; it should no longer be needed now.
2572
90db8702
MA
25732013-06-05 Michael Albinus <michael.albinus@gmx.de>
2574
2575 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2576
2577 * gfilenotify.c (globals_of_gfilenotify): New function.
2578 (syms_of_gfilenotify): Move global initialization there.
2579
2580 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2581
bfa3acd6
SM
25822013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2583
2584 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2585 * keyboard.c (menu_bar_items, tool_bar_items):
2586 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2587 not override local keymaps any more.
2588
ba59bd80
EZ
25892013-06-04 Eli Zaretskii <eliz@gnu.org>
2590
2591 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2592
7f203aa1
EZ
25932013-06-03 Eli Zaretskii <eliz@gnu.org>
2594
9337e206
EZ
2595 * w32console.c (initialize_w32_display): Return the dimensions of
2596 the console window via 2 additional arguments, not via the current
2597 frame. This avoids crashes due to overrunning the bounds of
2598 frame's decode_mode_spec_buffer, which is not resized following
2599 the change of the frame dimensions from the initial 10x10.
2600
2601 * w32term.h (w32_initialize_display_info): Adjust prototype.
2602
2603 * term.c (init_tty): Take dimensions of the frame from the values
2604 returned by initialize_w32_display.
2605
7f203aa1
EZ
2606 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2607 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2608 (LIBES): Add $(GFILENOTIFY_LIBS).
2609
2610 * w32inevt.c (handle_file_notifications): Add dummy implementation
2611 for !HAVE_W32NOTIFY.
2612
2613 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2614
55a87246
JD
26152013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2616
2617 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2618
2619 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2620
2621 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2622
3d5ee10a
PE
26232013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 Fix minor problems found by static checking.
2626 * data.c (pure_write_error):
2627 Use xsignal2, not Fsignal, as Fsignal might return.
2628 * eval.c (set_backtrace_debug_on_exit): Now static.
2629 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2630 No longer inline. EXTERN_INLINE is needed only for functions
2631 defined in .h files. Reindent function header as per GNU style.
2632 (backtrace_p, backtrace_top, backtrace_next):
2633 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2634 compiler or linker. Add extern decls to pacify gcc -Wall.
2635 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2636 Now static.
2637 * frame.c (free_monitors): Define only on platforms that need it.
2638 * nsterm.m (ns_term_init):
2639 * process.c (catch_child_signal):
2640 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2641 defined on all porting targets these days.
2642 * process.c, process.h (catch_child_signal):
2643 Make it extern only if NS_IMPL_GNUSTEP is defined.
2644
e2d8a6f0
EZ
26452013-06-03 Eli Zaretskii <eliz@gnu.org>
2646
2647 * w32.c (gettimeofday): Make the signature identical to prototype
2648 in nt/inc/sys/time.h.
2649
a8a7c5f6
SM
26502013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2651
2652 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2653 .gdbinit.
2654
2655 * keyboard.c (safe_run_hooks_error): Improve error message.
2656
2657 * data.c (pure_write_error): Add `object' argument.
2658 * puresize.h (CHECK_IMPURE): Use it.
2659
c9628c79
MA
26602013-06-03 Michael Albinus <michael.albinus@gmx.de>
2661
2662 * Makefile.in (NOTIFY_OBJ): New variable.
2663 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2664
2665 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2666 Call syms_of_gfilenotify.
2667
2668 * gfilenotify.c: New file.
2669
2670 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2671 and Qfile_w32notify.
2672 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2673 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2674
2675 * lisp.h: Declare syms_of_gfilenotify.
2676
2677 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2678
2f592f95
SM
26792013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2680
2681 Merge the specpdl and backtrace stacks. Make the structure of the
2682 specpdl entries more obvious via a tagged union of structs.
2683 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2684 (enum specbind_tag): New enum.
2685 (struct specbinding): Make it a tagged union of structs.
2686 Add a case for backtrace records.
2687 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2688 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2689 (backtrace_debug_on_exit): New accessors.
2690 (struct backtrace): Remove.
2691 (struct catchtag): Remove backlist field.
2692 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2693 Move to eval.c.
2694 (Flocal_variable_p): Speed up the common case where the binding is
2695 already loaded.
2696 * eval.c (backtrace_list): Remove.
2697 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2698 (set_backtrace_args, set_backtrace_nargs)
2699 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2700 (backtrace_next): New functions.
2701 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2702 (unwind_to_catch, internal_lisp_condition_case)
2703 (internal_condition_case, internal_condition_case_1)
2704 (internal_condition_case_2, internal_condition_case_n): Don't bother
2705 with backtrace_list any more.
2706 (Fsignal): Adjust to new backtrace format.
2707 (grow_specpdl): Move up.
2708 (record_in_backtrace): New function.
2709 (eval_sub, Ffuncall): Use it.
2710 (apply_lambda): Adjust to new backtrace format.
2711 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2712 data.c.
2713 (specbind): Adjust to new specpdl format. Simplify.
2714 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2715 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2716 backtrace format.
2717 (mark_backtrace): Remove.
2718 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2719 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2720 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2721 Use mark_specpdl.
2722 * profiler.c (record_backtrace): Use get_backtrace.
2723 (handle_profiler_signal): Use backtrace_top_function.
2724 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2725 accessor functions.
2726
c0342369
JD
27272013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2728
2729 * process.h (catch_child_signal): Declare.
2730
2731 * process.c (catch_child_signal): New function.
2732 (init_process_emacs): Call it.
2733
2734 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2735 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2736 NS_IMPL_COCOA.
2737 (x_set_cursor_type): Remove declaration.
2738 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2739 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2740 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2741 (ns_get_color): Use F suffix on float.
2742 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2743 (ns_get_rgb_color): Remove.
2744 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2745 (note_mouse_movement): x and y are CGFloat.
2746 (ns_draw_fringe_bitmap): Remove unused rowY.
2747 Change #if to COCOA && >= 10_6.
2748 (ns_draw_window_cursor): Remove unused overspill.
2749 (ns_draw_underwave): width and x are EamcsCGFloat.
2750 (ns_draw_box): thickness is CGFloat.
2751 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2752 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2753 if not in main thread.
2754 (ns_get_pending_menu_title, ns_check_menu_open)
2755 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2756 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2757 (sendFromMainThread:): New method.
2758 (changeFont:): size is CGFloat.
2759 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2760 Disable warning about permanent text.
2761 (characterIndexForPoint:): Adjust return type depending on GNUStep
2762 version.
2763 (mouseDown:): delta is CGFloat.
2764 (updateFrameSize): Remove unised variable f.
2765 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2766 Cast float to EmacsCGFloat.
2767 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2768 also to -1 when restoring.
2769 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2770 inside NS_IMPL_COCOA.
2771 (toggleFullScreen:): Put call to toggleFullScreen inside
2772 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2773 (setPosition:portion:whole:): por is CGFloat.
2774 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2775 (mouseDown:): Use CGFloat.
2776 (mouseDragged:): Remove unised variable edge.
2777 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2778
2779 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2780 of CGFloat differs.
2781 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2782 when NS_IMPL_GNUSTEP.
2783 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2784 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2785 (EmacsToolbar): Add clearAll. Add tag argument to
2786 addDisplayItemWithImage.
2787 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2788
2789 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2790
2791 * nsmenu.m (ns_update_menubar): Make static.
2792 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2793 (fillWithWidgetValue:): Add cast to SEL for setAction.
2794 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2795 (update_frame_tool_bar): Update code for GNUStep.
2796 (clearAll): New method.
2797 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2798 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2799 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2800 call to insertItemWithItemIdentifier.
2801 (validateVisibleItems): Fix indentation.
2802 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2803 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2804 UtilityWindow to aStyle, remove call to setStyleMask.
2805
2806 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2807
2808 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2809 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2810 Use F suffix on floats.
2811 (ns_char_width): Returns CGFloat.
2812 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2813 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2814 DPSxshow.
2815 (ns_glyph_metrics): CGFloat instead of float.
2816
a0eb10b3
JB
2817 * nsfns.m (x_set_foreground_color, x_set_background_color):
2818 Use EmacsCGFloat.
2819 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2820 remove unused variables.
2821 (Fns_read_file_name): Keep track if panel is for save.
2822 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2823 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2824 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2825 Just return the input if GNUStep.
c0342369
JD
2826 (x_screen_planes): Remove.
2827 (Fxw_color_values): Use EmacsCGFloat
2828 (Fns_display_monitor_attributes_list): Only get screen number for
2829 Cocoa.
ef099a94 2830 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2831 EmacsSavePanel.
2832 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2833 ns_directory_from_panel.
2834
da9aff11
PE
28352013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * process.c (handle_child_signal): Also use WCONTINUED.
2838 This is so that list-processes doesn't mistakenly list the process
2839 as stopped, when the process has actually been continued and is
2840 now running.
2841
0e64479a
PE
28422013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2843
fc186a96
PE
2844 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2845 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2846 not already configured.
2847
0e64479a
PE
2848 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2849
38b787fa
EZ
28502013-05-29 Eli Zaretskii <eliz@gnu.org>
2851
2852 * Makefile.in (mostlyclean): Remove *.res files.
2853
22513e52
SM
28542013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2855
2856 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2857 a buffer (bug#8447).
2858
6ef3db10
EZ
28592013-05-27 Eli Zaretskii <eliz@gnu.org>
2860
2861 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2862 display vector, and we backtrack, handle the case that the
2863 previous character position is also displayed from a display
2864 vector or covered by a display string or image. (Bug#14476)
2865
6799bb26
JD
28662013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2867
2868 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2869 (struct MonitorInfo, free_monitors): Remove.
2870 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2871 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2872 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2873 Qframes, Qsource.
2874
2875 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2876 (struct MonitorInfo, free_monitors): Remove.
2877 (ns_screen_name): Make static.
2878 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2879 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2880 Qframes, Qsource.
2881
2882 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2883 (struct MonitorInfo): New struct.
2884 (free_monitors, make_monitor_attribute_list): Declare.
2885
22513e52
SM
2886 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2887 New Lisp_Object:s.
6799bb26
JD
2888 (free_monitors, make_monitor_attribute_list): New functions.
2889 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2890 Qsource.
2891
38cd43eb
XF
28922013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2893
2894 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2895
2af0948d
SM
28962013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2897
a7eb9b0f
SM
2898 * keyboard.c: Apply keyboard decoding only to events that come directly
2899 from the tty, not from unread-command-events (bug#14368).
2900 (read_event_from_main_queue): New function, extracted from read_char).
2901 (read_decoded_char): Remove.
2902 (read_decoded_event_from_main_queue): New function to replace it.
2903 (read_char): Use it.
2904 (read_key_sequence): Use read_char rather than read_decoded_char.
2905
2af0948d
SM
2906 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2907
1413e9a5
BR
29082013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2909
2910 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2911
e6d2f155
KH
29122013-05-22 Kenichi Handa <handa@gnu.org>
2913
2914 The following changes are to fix the setting of
2915 buffer-file-coding-system on, for instance, C-x RET c unix RET
2916 _FILE_OF_DOS_EOL_TYPE_ RET.
2917
2918 * coding.h (struct coding_system): New member detected_utf8_chars.
2919
2920 * coding.c (detect_coding_utf_8): Count characters and check EOL
2921 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2922 BOM is there.
2923 (setup_coding_system): Do not initialize coding->head_ascii.
2924 (check_ascii): Do not set coding->eol_seen but update it. Do not
2925 call adjust_coding_eol_type here.
1413e9a5
BR
2926 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2927 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2928 of the found coding-system.
2929 (decode_coding_gap): Cancel previous change. Utilize the
2930 character numbers counted by detect_coding_utf_8. Fix detection
2931 of BOM for utf-8.
2932
ab56a6f4 29332013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2934
2935 * search.c (looking_at_1): Only set last_thing_searched if the match
2936 changed the match-data (bug#14281).
2937
ecc3c6ed
DA
29382013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2939
2940 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2941 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2942 (move_it_vertically_backward): Likewise.
2943
5ba8bf35
YM
29442013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2945
2946 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2947 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2948 (Fx_display_mm_width, Fx_display_mm_height):
2949 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2950
91e8418b 2951 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2952 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2953 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2954 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2955 (Fx_display_backing_store, Fx_display_visual_class)
2956 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2957 (Fx_display_grayscale_p, Fx_display_pixel_width)
2958 (Fx_display_pixel_height, Fx_display_planes)
2959 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2960 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2961 (Fx_display_mm_width, Fx_display_mm_height)
2962 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2963 height for all physical monitors as in X11.
2964
fc30d803
SM
2965 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2966 Return pixel width or height for all physical monitors as in X11.
91e8418b 2967
31ff141c
PE
29682013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 Port --enable-gcc-warnings to clang.
2971 * bytecode.c (exec_byte_code):
2972 * regex.c:
2973 Redo diagnostic pragmas to pacify clang, too.
2974 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2975 * editfns.c (Fencode_time):
2976 * fileio.c (file_accessible_directory_p):
2977 * font.c (font_unparse_xlfd):
2978 Use '&"string"[index]' instead of '"string" + (index)'.
2979 * undo.c (user_error): Remove; unused.
2980
df065a0b
EZ
29812013-05-16 Eli Zaretskii <eliz@gnu.org>
2982
04d360e7
EZ
2983 * insdel.c (insert_1_both): Document the arguments, instead of
2984 referring to insert_1, which no longer exists.
2985
5bb98290
EZ
2986 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2987 some window, increment windows_or_buffers_changed, so that
2988 *Messages* display in that window is updated. (Bug#14408)
2989
df065a0b
EZ
2990 * w32.c: Include epaths.h.
2991 (init_environment): Use cmdproxy.exe without leading directories.
2992 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2993 case.
2994 (gettimeofday): Adjust signature and return value to Posix
2995 expectations.
2996
2997 * unexw32.c (open_output_file): Delete the existing emacs.exe
2998 before creating it, to break the hard link to the versioned
2999 executable.
3000
3001 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3002 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3003 (FIRSTFILE_OBJ): New variables.
3004 (W32_RES): Rename to EMACSRES. All users changed.
3005 (base_obj): Use $(CM_OBJ).
3006 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3007 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3008 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3009 $(W32_RES_LINK) before $(LIBES).
3010 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3011
1aa8d505
SM
30122013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3013
6e911150
SM
3014 * makefile.w32-in (DOC): Use just "DOC".
3015
3016 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3017
1aa8d505
SM
3018 * process.c: Export default filters and sentinels to Elisp.
3019 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3020 New constants.
3021 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3022 (Fset_process_sentinel, Fformat_network_address):
3023 Default to them instead of nil.
3024 (server_accept_connection): Sentinels can't be nil any more.
3025 (read_and_dispose_of_process_output): New function, extracted from
3026 read_process_output.
3027 (read_process_output): Use it; filters can't be nil.
3028 (Finternal_default_process_filter): New function, extracted from
3029 read_process_output.
3030 (exec_sentinel_unwind): Remove function.
3031 (exec_sentinel): Don't zilch sentinel while running.
3032 (status_notify): Sentinels can't be nil.
3033 (Finternal_default_process_sentinel): New function extracted from
3034 status_notify.
3035 (setup_process_coding_systems): Default filter is not nil any more.
3036 (syms_of_process): Export new Elisp functions and initialize
3037 new constants.
3038 * lisp.h (make_lisp_proc): New function.
3039
5ac2eb34
SM
30402013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3041
3042 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3043
eda9c7d7
EZ
30442013-05-14 Eli Zaretskii <eliz@gnu.org>
3045
3046 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3047 unless we know that the window w is a leaf window.
3048 Another attempt at solving bug#14062.
eda9c7d7 3049
8fdeaad5
JD
30502013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3051
3052 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3053 fdesc (Bug#14375).
3054
44aa9ee6
PE
30552013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 * image.c (gif_load): Check that subimages fit (Bug#14345).
3058
759fd763
SM
30592013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3060
3061 * lread.c (skip_dyn_eof): New function.
3062 (read1): Use it to skip the end of a file in response to #@00.
3063
3064 * doc.c (get_doc_string): Slightly relax the sanity checking.
3065
4465bfb4
JD
30662013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3067
3068 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3069 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3070 (MonitorInfo): New struct.
3071 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3072 (Fns_display_monitor_attributes_list): New functions.
3073 (display-usable-bounds): Remove.
3074 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3075 Qsource.
3076
7583e2a0
PE
30772013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3078
3079 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3080 (GTK_CHECK_VERSION): New macro, if not already defined.
3081 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3082 replaced by GTK_CHECK_VERSION.
3083
ad75d77e
PE
30842013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3085
3086 * xterm.h (GTK_PREREQ): New macro.
3087 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3088 to use this macro instead, for consistency and clarity.
3089
07525f77
EZ
30902013-05-08 Eli Zaretskii <eliz@gnu.org>
3091
3092 * xdisp.c (row_for_charpos_p): New function, with code of
3093 cursor_row_p, but accepts an additional argument CHARPOS instead
3094 of using a hardcoded PT.
3095 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3096 (row_containing_pos): Call row_for_charpos_p instead of partially
3097 doing the same. Fixes cursor positioning under longlines-mode
3098 when longlines-show-effect includes more than one newline, when
3099 moving the cursor vertically up.
3100
d901fc8d
JB
31012013-05-08 Juanma Barranquero <lekktu@gmail.com>
3102
3103 * makefile.w32-in (ACL_H): New macro.
3104 ($(BLD)/fileio.$(O)): Update dependencies.
3105
f269bc61
PE
31062013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3107
e7b41c4c 3108 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3109 * Makefile.in (LIB_ACL): New macro.
3110 (LIBACL_LIBS): Remove.
3111 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3112 * fileio.c: Include <acl.h>.
3113 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3114 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3115 !acl_errno_valid.
3116 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3117 it ourselves.
3118
f269bc61
PE
3119 * unexelf.c: Don't assume ElfW (Half) fits in int.
3120 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3121 when dealing with ElfW (Half) values, since they can exceed 2**31
3122 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3123 (entry_address): Omit unused NUM arg. All uses changed.
3124
a261c53e
JL
31252013-05-07 Juri Linkov <juri@jurta.org>
3126
3127 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3128 to the string converted from number with `Fnumber_to_string'.
3129 (Bug#14254)
3130
2b66427d
PE
31312013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3134 This fixes a problem introduced by my previous change.
3135
15acfe41
GM
31362013-05-07 Glenn Morris <rgm@gnu.org>
3137
3138 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3139
5ea03bf5
JD
31402013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3141
3142 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3143
e0c9d565
PE
31442013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 Static checking by GCC 4.8.0.
3147 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3148 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3149 (x_get_monitor_attributes_fallback)
3150 (x_get_monitor_attributes_xinerama)
3151 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3152 Define only if USE_GTK.
3153 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3154 (x_get_monitor_attributes_fallback): Omit unused locals.
3155 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3156 Use double, not float, to avoid mixed-mode floating point arithmetic.
3157
4e3f9230
YM
31582013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3159 Jan Djärv <jan.h.d@swipnet.se>
3160
3161 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3162 (XINERAMA_CFLAGS): New macros.
3163 (ALL_CFLAGS, LIBES): Use them.
3164
3165 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3166 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3167 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3168 (syms_of_xfns): DEFSYM them.
3169 (struct MonitorInfo): New struct.
3170 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3171 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3172 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3173 (x_get_monitor_attributes_xinerama): New functions.
3174 (Fx_display_monitor_attributes_list): New primitive.
3175 (syms_of_xfns): Defsubr it.
3176
3177 * xterm.h (x_display_info): Add Xatom_net_workarea and
3178 Xatom_net_current_desktop.
3179
3180 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3181 and dpyinfo->Xatom_net_current_desktop.
3182
05839b6a
EZ
31832013-05-06 Eli Zaretskii <eliz@gnu.org>
3184
3185 * xdisp.c (pos_visible_p): Use the special code for finding the
3186 beginning of a display property or overlay for any "replacing"
3187 display property, not just for display strings. This solves
3188 incorrect reporting of position by posn-at-point. (Bug#14241)
3189
dc4a2ee0
PE
31902013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3191
5ee94506
PE
3192 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3193 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3194 Verify that ElfW (Half) fits in int.
3195 (fatal): Use same signature as lisp.h.
3196 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3197 configure and build with -DUNEXELF_DEBUG without worrying about
3198 other modules that use DEBUG.
3199 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3200 possibly-wide integers now uses it instead of plain fprintf.
3201 (entry_address): New function, which avoids problems with 32-bit
3202 overflow on 64-bit hosts.
3203 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3204 (round_up): Don't assume the remainder fits in int.
3205 (find_section): Use bool for boolean. Simplify debug code.
3206 (unexec): Don't assume file sizes fit in int or size_t.
3207 Omit unnecessary trailing newline in 'fatal' format.
3208 Use strerror rather than outputting decimal error number.
3209 Remove unused code when emacs is not defined;
3210 this file relies on Emacs now.
3211 Don't assume e_phnum and e_shnum are positive.
3212
dc4a2ee0
PE
3213 * regex.c: Fix problems when DEBUG is defined.
3214 (extract_number, extract_number_and_incr): Define regardless of
3215 whether DEBUG is defined; that's simpler and makes the code less
3216 likely to go stale in the normal case when DEBUG is not defined.
3217 Return int rather than taking an int * arg. All callers changed.
3218 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3219 Remove, replacing with ...
3220 (DEBUG_PRINT): New macro. All callers changed.
3221 (DEBUG_COMPILES_ARGUMENTS): New macro.
3222 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3223 (print_compiled_pattern, print_double_string) [DEBUG]:
3224 Use prototype rather than old-style definition.
3225 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3226 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3227 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3228 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3229 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3230 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3231 This matters only when DEBUG is defined.
3232
14c7ed05
EZ
32332013-05-05 Eli Zaretskii <eliz@gnu.org>
3234
3235 * xdisp.c (set_iterator_to_next): Set the
3236 ignore_overlay_strings_at_pos_p flag only if we are _really_
3237 iterating over an overlay string, as indicated by the
3238 current.overlay_string_index member. (Bug#14306)
3239
e6076b1b
JD
32402013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3241
3242 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3243 to where it is used, to avoid autorelease issues (Bug#14050).
3244
cbee2131
PE
32452013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3246
3247 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3248 * fileio.c (syms_of_fileio): Implement this.
3249 * filelock.c (create_lock_file): If symbolic links don't work, so
3250 we use a regular file as a lock file, do not fsync the lock file;
3251 it's not needed.
3252
30c7e542
SM
32532013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3254
3255 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3256 (syms_of_minibuf): Adjust accodingly.
3257 * lread.c (Fread):
3258 * callint.c (Fcall_interactively): Adjust calls accordingly.
3259
5bebd186
EZ
32602013-05-04 Eli Zaretskii <eliz@gnu.org>
3261
3262 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3263 w->contents is a buffer before computing everything else.
3264 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3265
3266 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3267 assertion violations. (Bug#14062)
3268
0fb0a4f3
DR
32692013-05-01 David Reitter <david.reitter@gmail.com>
3270
3271 * nsfns.m (ns_tooltip): Initialize.
3272
9e63b4a5
EZ
32732013-04-28 Eli Zaretskii <eliz@gnu.org>
3274
3275 * coding.c (decode_coding_gap): Don't remove the character before
3276 a newline unless it's a CR character. (Bug#14287)
3277
ad60824e
DN
32782013-04-28 Dan Nicolaescu <dann@gnu.org>
3279
3280 * dispextern.h (struct face): Move enum face_underline_type
3281 earlier so that bitfields can be in the same word.
3282
edbdcec0
JD
32832013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3284
3285 * nsfns.m (handlePanelKeys): New function.
3286 (EmacsOpenPanel:performKeyEquivalent:)
3287 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3288 arrows/function/control and copy/paste keys (Bug#14296).
3289
0208ede7
JL
32902013-04-27 Juri Linkov <juri@jurta.org>
3291
3292 * callint.c (Fcall_interactively): Call `Qread_number' for
3293 interactive code letter `n' instead of using duplicate code.
3294 (Bug#14254)
3295
b8dd59f7
PE
32962013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3297
3298 * systime.h (make_timeval): Declare as 'const'.
3299
8bd722db
KH
33002013-04-27 Kenichi Handa <handa@gnu.org>
3301
3302 * font.c (font_open_entity): Always open a font of manageable
3303 size.
3304
13d0e56f 33052013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3306
f780d632
PE
3307 Port better to AIX (Bug#14258).
3308 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3309 to pacify AIX xlc.
3310
ec509856
KH
33112013-04-24 Kenichi Handa <handa@gnu.org>
3312
3313 * coding.c (decode_coding_iso_2022): When an invalid escape
3314 sequence is encountered, reset the invocation and designation
3315 status to the safest one.
3316
84fc48e5
PE
33172013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3320 Without this fix, "make distclean" leaves stamp-h1 behind.
3321
806bda47
EC
33222013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3323
3324 * w32fns.c (w32_fullscreen_rect): New function to compute the
3325 window rectangle for the given fullscreen mode.
3326 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3327 longer tunes the window size. This keeps the window's edges flush
3328 with the screen and allows the taskbar to hide itself in fullboth.
3329
3330 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3331 window decorations and uses the entire screen.
3332
3333 * w32term.h (w32_fullscreen_rect) Add prototype.
3334 (struct w32_output): Replace normal_width, normal_height,
3335 normal_top, and normal_left members with a single normal_placement
3336 struct.
3337 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3338 Remove macros.
3339 (FRAME_NORMAL_PLACEMENT): New macro.
3340
9cc2810b
JB
33412013-04-16 Juanma Barranquero <lekktu@gmail.com>
3342
3343 * minibuf.c (Ftest_completion): Silence compiler warning.
3344
fd16b54c
EZ
33452013-04-15 Eli Zaretskii <eliz@gnu.org>
3346
3347 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3348 bug#14062.
fd16b54c
EZ
3349
3350 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3351 parentheses.
3352
3353 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3354 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3355 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3356 parentheses where appropriate.
3357
9e3379a0
PE
33582013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3359
3360 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3361
ddd6b685
EZ
33622013-04-14 Eli Zaretskii <eliz@gnu.org>
3363
3364 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3365 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3366 Mention in the doc string that setting these variables takes
3367 effect only after a call to set-window-buffer. (Bug#14200)
3368
29b79ba1
EZ
33692013-04-13 Eli Zaretskii <eliz@gnu.org>
3370
3371 * indent.c (Fvertical_motion): Don't consider display strings on
3372 overlay strings as display strings on the buffer position we
3373 started from. This prevents vertical cursor motion from jumping
3374 more than one line when there's an overlay string with a display
3375 property at end of line.
3376 Reported by Karl Chen <Karl.Chen@quarl.org> in
3377 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3378
562c6ee9
SM
33792013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3380
3381 * window.c (select_window): `record_buffer' even if window is
3382 already selected (bug#14191).
3383
fcc1fe85
EZ
33842013-04-11 Eli Zaretskii <eliz@gnu.org>
3385
3386 * window.c (Fwindow_end): Test more flags, including the buffer's
3387 last_overlay_modified flag, to determine whether the window's
3388 display is really up-to-date. Prevents the function from
3389 returning a stale value. (Bug#14170)
3390 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3391 current matrix.
3392
f009190a
EZ
33932013-04-10 Eli Zaretskii <eliz@gnu.org>
3394
3395 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3396 garbaged only if it is not already the top frame on its TTY.
3397 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3398 there are GUI frames open in the same session. (Bug#13864)
3399
78ce603d
SM
34002013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3401
3402 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3403 of marking the idle timers directly.
3404
a8036e40
SM
34052013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3406
3407 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3408 tables (bug#14054).
3409
7ffe7ef6
SM
34102013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3411
3412 * window.c (select_window): Don't record_buffer while the invariant is
3413 temporarily broken (bug#14161).
3414
3415 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3416
7d9f6883
EZ
34172013-04-07 Eli Zaretskii <eliz@gnu.org>
3418
3419 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3420
5406cfd9
RF
34212013-04-07 Romain Francoise <romain@orebokech.com>
3422
3423 Ignore additional platform-specific ACL errors (Bug#13702).
3424 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3425 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3426
95c0e83b
JD
34272013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3428
3429 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3430 f->output_data.ns.
3431
876da980
PE
34322013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3433
3434 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3435 This bug was introduced by my 2013-02-25 change that simplified
3436 data_start configuration. Without this change, on GNU/Linux
3437 an Emacs configured with --enable-profiling fails immediately
3438 due to a profiler signal.
3439 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3440 with these flags. On platforms where special flags are needed
3441 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3442 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3443 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3444
7452b7bd
DA
34452013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3446
3447 Get rid of some platform-specific functions examining window
3448 system and its capabilities. This is a partial rework of the
3449 2013-04-05 change.
3450 * lisp.h (have_menus_p): Remove prototype. This function is
3451 replaced with platform-independent window_system_available.
3452 (check_window_system): Move to...
3453 * frame.h (decode_window_system_frame, window_system_available):
3454 ...here, add new prototypes.
3455 * frame.c (window_system_available, decode_window_system_frame):
3456 New functions.
3457 (check_window_system): Platform-independent now.
3458 * xterm.h (x_in_use): Remove declaration.
3459 (check_x_frame):
3460 * w32term.h (check_x_frame):
3461 * nsterm.h (check_x_frame): Remove prototypes. This function
3462 is replaced with platform-independent decode_window_system_frame.
3463 * msdos.c (have_menus_p): Remove.
3464 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3465 Remove platform-specific functions. Use check_window_system,
3466 decode_window_system_frame and check_ns_display_info where
3467 appropriate. Minor style and comment tweaks.
3468 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3469 (check_x_frame): Likewise.
3470 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3471 Likewise.
3472 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3473 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3474 * xmenu.c, xselect.c: All related users changed.
3475
251e9147
KH
34762013-04-03 Kenichi Handa <handa@gnu.org>
3477
3478 The following changes is to optimize the code for reading UTF-8
3479 files.
3480
562c6ee9 3481 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3482 changed. Check EOL format. Do not call adjust_coding_eol_type
3483 here.
3484 (check_utf_8): New function.
3485 (adjust_coding_eol_type): Do nothing if already adjusted.
3486 (detect_coding): Compare the return value of check_ascii with
3487 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3488 (decode_coding_gap): Optimize for valid UTF-8.
3489
8bc369d4
KH
34902013-03-21 Kenichi Handa <handa@gnu.org>
3491
3492 * coding.c (syms_of_coding): Cancel previous change.
3493
3494 * insdel.c (insert_from_gap): Fix previous change.
3495
73931ad1
DA
34962013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3497
3498 Consistently use platform-specific function to detect window system.
3499 * lisp.h (check_window_system): New prototype. This function is
3500 going to replace check_x, check_w32 and check_ns.
3501 (have_menus_p): Mention msdos.c in comment.
3502 * fontset.c (check_window_system_func): Remove. Adjust all users.
3503 * fontset.h (check_window_system_func): Remove prototype.
3504 * nsterm.h (check_ns):
3505 * xterm.h (check_x):
3506 * w32term.h (check_w32): Likewise.
3507 * menu.c (Fx_popup_menu): Use check_window_system.
3508 * msdos.c (check_window_system): Define for MS-DOS.
3509 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3510 * w32fns.c (check_window_system): Likewise for MS-Windows.
3511 * xfns.c (check_window_system): Likewise for X.
3512 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3513 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3514
7216e43b
PE
35152013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 Prefer < to > in range checks such as 0 <= i && i < N.
3518 This makes it easier to visualize quantities on a number line.
3519 This patch doesn't apply to all such range checks,
3520 only to the range checks affected by the 2013-03-24 change.
3521 This patch reverts most of the 2013-03-24 change.
3522 * alloc.c (xpalloc, Fgarbage_collect):
3523 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3524 * character.c (string_escape_byte8):
3525 * charset.c (read_hex):
3526 * data.c (cons_to_unsigned):
3527 * dispnew.c (update_frame_1):
3528 * doc.c (Fsubstitute_command_keys):
3529 * doprnt.c (doprnt):
3530 * editfns.c (hi_time, decode_time_components):
3531 * fileio.c (file_offset):
3532 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3533 * font.c (font_intern_prop):
3534 * frame.c (x_set_alpha):
3535 * gtkutil.c (get_utf8_string):
3536 * indent.c (check_display_width):
3537 * keymap.c (Fkey_description):
3538 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3539 * lread.c (read1):
3540 * minibuf.c (read_minibuf_noninteractive):
3541 * process.c (wait_reading_process_output):
3542 * search.c (Freplace_match):
3543 * window.c (get_phys_cursor_glyph):
3544 * xdisp.c (redisplay_internal):
3545 * xsmfns.c (smc_save_yourself_CB):
3546 Prefer < to > for range checks.
3547 * dispnew.c (sit_for): Don't mishandle NaNs.
3548 This fixes a bug introduced in the 2013-03-24 change.
3549 * editfns.c (decode_time_components): Don't hoist comparison.
3550 This fixes another bug introduced in the 2013-03-24 change.
3551
92759988
DA
35522013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3553
3554 * frame.h (struct frame): Drop scroll_bottom_vpos
3555 member becaue all real users are dead long ago.
3556 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3557 * xdisp.c (redisplay_internal): Adjust user.
3558
9a1971bb
GM
35592013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3560
f38ab167
JD
3561 * nsmenu.m (showAtX:Y:for:): setLevel to
3562 NSPopUpMenuWindowLevel (Bug#13998).
3563
6d01f1fe
JD
35642013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3565
3566 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3567 (ns_check_pending_open_menu): Declare.
3568
3569 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3570 (x_activate_menubar): Update the menu with title that matches
3571 ns_get_pending_menu_title, and call
3572 ns_check_pending_openmenu (Bug#12698).
3573 (menuWillOpen:): New method.
3574 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3575
3576 * nsterm.m (menu_will_open_state, menu_mouse_point)
3577 (menu_pending_title): New varaibles.
3578 (ns_get_pending_menu_title, ns_check_menu_open)
3579 (ns_check_pending_open_menu): New functions.
3580
781f4782
DA
35812013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3582
3583 * indent.c (current_column_bol_cache): Remove leftover which is not
3584 used in Fmove_to_column any more.
3585 (current_column, scan_for_column): Adjust users.
3586 * keyboard.c (last_point_position_buffer, last_point_position_window):
3587 Remove leftovers which are not used for recording undo any more.
3588 (command_loop_1, syms_of_keyboard): Adjust users.
3589 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3590 redisplay_window any more.
3591 (move_it_to): Adjust user.
3592
1921c31b
JB
35932013-03-29 Juanma Barranquero <lekktu@gmail.com>
3594
3595 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3596 Update dependencies.
3597
717b8bcd
SM
35982013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3599
3600 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3601 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3602 forward references.
3603
e74aeda8
DA
36042013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3605
3606 * window.h (struct window): Replace hchild, vchild and buffer slots
3607 with the only contents slot. This is possible because each valid
3608 window may have either the child window (in vertical or horizontal
3609 combination) or buffer to display (for the leaf window). Using that,
3610 a lof of operations to traverse and/or change window hierarchies may
3611 be simplified. New member horizontal is used to distinguish between
3612 horizontal and vertical combinations of internal windows.
3613 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3614 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3615 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3616 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3617 Use contents slot, not buffer, where appropriate.
3618 (wset_combination): New function.
3619 (wset_buffer): Add eassert.
3620 (Fframe_first_window): Simplify the loop reaching first window.
3621 (Fwindow_buffer): Use WINDOW_LEAF_P.
3622 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3623 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3624 (unshow_buffer): Convert initial debugging check to eassert.
3625 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3626 (make_parent_window, window_resize_check, window_resize_apply)
3627 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3628 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3629 Adjust to match struct window changes.
3630 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3631 (mark_window_cursors_off, count_windows, get_leaf_windows)
3632 (foreach_window_1): Simplify the loop.
3633 * alloc.c (mark_object): Do not check for the leaf window because
3634 internal windows has no glyph matrices anyway.
3635 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3636 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3637 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3638 (build_frame_matrix_from_window_tree, mirror_make_current)
3639 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3640 (update_window_tree, set_window_update_flags): Simplify the loop.
3641 (sync_window_with_frame_matrix_rows): Enforce live window.
3642 Use contents slot, not buffer, where appropriate.
3643 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3644 and WINDOW_HORIZONTAL_COMBINATION_P.
3645 (make_frame_visible_1): Simplify the loop.
3646 Use contents slot, not buffer, where appropriate.
3647 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3648 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3649 (expose_window_tree): Likewise.
3650 Use contents slot, not buffer, where appropriate.
3651 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3652 to avoid deleted windows. Use contents slot instead of buffer.
3653 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3654 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3655 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3656 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3657
121ab1cd
EZ
36582013-03-28 Eli Zaretskii <eliz@gnu.org>
3659
ef454cf7
EZ
3660 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3661 identify the reasons for assertion violations in bug#14062 and
3662 similar ones.
21e930f8
EZ
3663 (Fx_show_tip): Fix compilation error under
3664 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3665
121ab1cd
EZ
3666 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3667 Reported by <rzl24ozi@gmail.com>.
3668
5c89ca24
DA
36692013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3670
3671 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3672 start marker...
562c6ee9
SM
3673 (unwind_with_echo_area_buffer): ...to restore it here.
3674 This is needed to ensure that...
5c89ca24
DA
3675 (redisplay_window): ...both window markers are valid here,
3676 which is verified by eassert.
3677 * editfns.c (save_excursion_save): Do not assume that
3678 selected_window always displays the buffer.
c7f53895
DA
3679 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3680 Fix comment.
5c89ca24 3681
f557c1b1
SM
36822013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3683
3684 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3685 the upcase table.
3686
40693bba 36872013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3688
3689 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3690
c86f791f
EZ
36912013-03-27 Eli Zaretskii <eliz@gnu.org>
3692
3693 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3694 since MinGW's w32api headers do. This avoids compiler warnings.
3695
3696 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3697 if already defined.
3698
c6e72e17
EZ
36992013-03-26 Eli Zaretskii <eliz@gnu.org>
3700
3701 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3702
54e95010
JD
37032013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3704
3705 * gtkutil.c (style_changed_cb): Check if frame is live and an
3706 X frame (Bug#14038).
3707
b88b62de
EZ
37082013-03-26 Eli Zaretskii <eliz@gnu.org>
3709
a18d7de6
EZ
3710 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3711 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3712 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3713 MinGW64.
8f5e14c8
EZ
3714 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3715 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3716
b88b62de
EZ
3717 Fix incompatibilities between MinGW.org and MinGW64 headers.
3718 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3719
3720 * w32.c (REPARSE_DATA_BUFFER): Guard with
3721 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3722
c074e458
JD
37232013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3724
3725 * xterm.c: Include X11/XKBlib.h
3726 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3727
908589fd
AS
37282013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3729
3730 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3731 written backwards.
3732 * blockinput.h (input_blocked_p): Likewise.
3733 * bytecode.c (exec_byte_code): Likewise.
3734 * callproc.c (call_process_kill, call_process_cleanup)
3735 (Fcall_process): Likewise.
3736 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3737 (Fccl_execute_on_string): Likewise.
3738 * character.c (string_escape_byte8): Likewise.
3739 * charset.c (read_hex): Likewise.
3740 * cm.c (calccost): Likewise.
3741 * data.c (cons_to_unsigned): Likewise.
3742 * dired.c (directory_files_internal, file_name_completion):
3743 Likewise.
3744 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3745 (sit_for): Likewise.
3746 * doc.c (Fsubstitute_command_keys): Likewise.
3747 * doprnt.c (doprnt): Likewise.
3748 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3749 * emacsgtkfixed.c: Likewise.
3750 * fileio.c (file_offset, Fwrite_region): Likewise.
3751 * floatfns.c (Fexpt, fmod_float): Likewise.
3752 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3753 Likewise.
3754 * font.c (font_intern_prop): Likewise.
3755 * frame.c (x_set_alpha): Likewise.
3756 * gtkutil.c (get_utf8_string): Likewise.
3757 * indent.c (check_display_width): Likewise.
3758 * intervals.c (create_root_interval, rotate_right, rotate_left)
3759 (split_interval_right, split_interval_left)
3760 (adjust_intervals_for_insertion, delete_node)
3761 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3762 (merge_interval_right, merge_interval_left, copy_intervals)
3763 (set_intervals_multibyte_1): Likewise.
3764 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3765 * keymap.c (Fkey_description): Likewise.
3766 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3767 * lread.c (openp, read_integer, read1, string_to_number):
3768 Likewise.
3769 * menu.c (ensure_menu_items): Likewise.
3770 * minibuf.c (read_minibuf_noninteractive): Likewise.
3771 * print.c (printchar, strout): Likewise.
3772 * process.c (create_process, Faccept_process_output)
3773 (wait_reading_process_output, read_process_output, send_process)
3774 (wait_reading_process_output): Likewise.
3775 * profiler.c (make_log, handle_profiler_signal): Likewise.
3776 * regex.c (re_exec): Likewise.
3777 * regex.h: Likewise.
3778 * search.c (looking_at_1, Freplace_match): Likewise.
3779 * sysdep.c (get_child_status, procfs_ttyname)
3780 (procfs_get_total_memory): Likewise.
3781 * systime.h (EMACS_TIME_VALID_P): Likewise.
3782 * term.c (dissociate_if_controlling_tty): Likewise.
3783 * window.c (get_phys_cursor_glyph): Likewise.
3784 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3785 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3786 Likewise.
3787 * xfns.c (Fx_window_property): Likewise.
3788 * xmenu.c (set_frame_menubar): Likewise.
3789 * xselect.c (x_get_window_property, x_handle_dnd_message):
3790 Likewise.
3791 * xsmfns.c (smc_save_yourself_CB): Likewise.
3792 * xterm.c (x_scroll_bar_set_handle): Likewise.
3793
2bf7d27a
DA
37942013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3795
3796 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3797 to be optional or nil. Adjust comment and convert it to docstring.
3798 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3799 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3800
a9ebfa0b
PE
38012013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3802
3803 Static checking by GCC 4.8-20130319.
3804 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3805 * process.c (Fset_process_datagram_address)
3806 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3807 * xdisp.c (get_char_face_and_encoding):
3808 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3809 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3810 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3811
4f3576ee
KB
38122013-03-24 Ken Brown <kbrown@cornell.edu>
3813
789b5e9a
KB
3814 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3815 fix compilation on 64-bit Cygwin, where underscores are not
3816 automatically prepended.
3817
4f3576ee
KB
3818 * w32term.c (w32_initialize): Silence compiler warning.
3819
b5b7745f
EZ
38202013-03-23 Eli Zaretskii <eliz@gnu.org>
3821
cdc0d0bd
EZ
3822 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3823 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3824 variables, to save and restore frame dimensions.
3825 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3826 after returning from a 'fullscreen' configuration.
3827 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3828 to avoid races between the main thread and the input thread.
3829
3830 * w32term.h (struct w32_output): New members normal_width,
3831 normal_height, normal_top, normal_left, and prev_fsmode.
3832 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3833 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3834 members of a frame.
3835
b5b7745f
EZ
3836 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3837 'fullscreen' parameter. Always record previous width and height
3838 of the frame, except when switching out of maximized modes, so
3839 that they could be restored correctly, instead of resetting to the
3840 default frame dimensions. Send SC_RESTORE command to the frame,
3841 unless we are going to send SC_MAXIMIZE, to restore the frame
3842 resize hints in the mouse pointer shown by the window manager.
3843 (Bug#14032)
3844
3845 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3846
3847 * lisp.h (get_frame_param): Adjust conditions for prototype
3848 declaration.
3849
a3454eed
KB
38502013-03-22 Ken Brown <kbrown@cornell.edu>
3851
3852 * unexcw.c: Drop unneeded inclusion of w32common.h.
3853 (report_sheap_usage): Declare.
3854 (read_exe_header): Add magic numbers for x86_64.
3855 (fixup_executable): Fix printf format specifier for unsigned long
3856 argument.
3857
5a49b79c
DA
38582013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3859
3860 * frame.h (struct frame): Put menu_bar_window under #ifdef
3861 because this member is not needed when X toolkit is in use.
3862 (fset_menu_bar_window):
3863 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3864 (free_glyphs, update_frame):
3865 * xdisp.c (expose_frame): Likewise.
3866 (display_menu_bar): Likewise. Remove redundant eassert.
3867 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3868 toolkit is in use.
3869
d6723bf7
PE
38702013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3871
7b1123d8
PE
3872 Use functions and constants to manipulate Lisp_Save_Value objects.
3873 This replaces code that used macros and strings and token-pasting.
3874 The change makes the C source a bit easier to follow,
3875 and shrinks the Emacs executable a bit.
3876 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3877 (make_save_value): Change 1st arg from string to enum. All callers
3878 changed.
3879 (INTX): Remove.
3880 (mark_object): Use if, not #if, for GC_MARK_STACK.
3881 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3882 (XSAVE_OBJECT): Now functions, not macros.
3883 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3884 the constant was never used.
3885 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3886 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3887 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3888 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3889 New constants.
3890 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3891 type3 with a single member save_type. All uses changed.
3892 (save_type, set_save_pointer, set_save_integer): New functions.
3893 * print.c (PRINTX): Remove.
3894
d6723bf7
PE
3895 * alloc.c: Remove redundant static declarations.
3896
5f24fa51
DA
38972013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3898
3899 * window.h (struct window): Convert left_col, top_line, total_lines
3900 and total_cols from Lisp_Objects to integers. Adjust comments.
3901 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3902 Remove.
3903 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3904 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3905 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3906 Adjust users where appropriate.
3907
42143acd
DA
39082013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3909
3910 * frame.h (struct frame): Drop resx and resy because the same data is
3911 available from window system-specific output context. Adjust users.
562c6ee9
SM
3912 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3913 New functions to provide defaults when no window system available.
42143acd 3914 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3915 (NUMVAL): Move from xdisp.c.
42143acd
DA
3916 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3917 (Ffont_face_attributes, Fopen_font):
3918 * image.c (gs_load):
3919 * w32font.c (fill_in_logfont):
3920 * xdisp.c (calc_pixel_width_or_height):
3921 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3922 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3923
c0a17406
KH
39242013-03-20 Kenichi Handa <handa@gnu.org>
3925
3926 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3927 to 1 (temporary workaround until a bug related to ASCII
3928 optimization is fixed).
3929
095d384d
DA
39302013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3931
3932 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3933 Signal error if window is not internal. Adjust docstring.
3934 (delete_all_child_windows): Use combination_limit to save the buffer.
3935 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3936 * print.c (syms_of_print): Initialize debugging output not here...
3937 (init_print_once): ...but in a new function here.
3938 * lisp.h (init_print_once): Add prototype.
3939 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3940
748fa866
DA
39412013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3942
3943 * window.c (window_resize_check, window_resize_apply)
3944 (window_from_coordinates, recombine_windows, set_window_buffer)
3945 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3946 (Fsplit_window_internal, Fdelete_window_internal)
3947 (freeze_window_starts): Use bool for booleans.
3948 * window.h (window_frame_coordinates, resize_frame_windows)
3949 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3950
81519fd2
SM
39512013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3952
3953 * dispnew.c (bitch_at_user): Use `user-error'.
3954
6db423a9
KB
39552013-03-17 Ken Brown <kbrown@cornell.edu>
3956
3957 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3958 as return type of image_background. (Bug#13981)
3959 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3960
8f2906f5
JD
39612013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3962
960ce480 3963 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3964 (ns_select): Don't return with result uninitialized.
960ce480 3965
8f2906f5
JD
3966 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3967 and getDirectory.
3968
81519fd2
SM
3969 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3970 New functions.
8f2906f5
JD
3971 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3972 directories. If filename is nil, get directory name (Bug#13932).
3973 Use getFilename and getDirectory.
3974 (getFilename, getDirectory): New methods for EmacsSavePanel and
3975 EmacsOpenPanel.
3976 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3977
cded56c1
PE
39782013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3981
251e9147 39822013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3983
3984 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3985 (adjust_after_replace): Make it back to static. Delete the third
3986 arg text_at_gap_tail. Cancel the code for handling it.
3987
3988 * coding.h (struct coding_system): New member eol_seen.
3989
3990 * coding.c (detect_ascii): New function.
3991 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3992 when the source bytes are actually scanned. On detecting for
3993 coding_category_utf_8_auto, call detect_ascii instead of scanning
3994 source bytes directly.
3995 (produce_chars): Call insert_from_gap with the new arg 0.
3996 (encode_coding): Likewise.
3997 (decode_coding_gap): Control ASCII optimization by the variable
3998 disable_ascii_optimization instead of #ifndef .. #endif.
3999 Deccode EOL format according to coding->eol_seen.
4000 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4001 variable.
4002
8a44e6d1
KH
4003 * lisp.h (adjust_after_replace): Cancel externing it.
4004 (insert_from_gap): Adjust prototype.
4005
5f795e34
EZ
40062013-03-15 Eli Zaretskii <eliz@gnu.org>
4007
4008 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4009 FULLSCREEN_MAXIMIZED. (Bug#13935)
4010
f258b4be
DA
40112013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4012
4013 * region-cache.c (find_cache_boundary, move_cache_gap)
4014 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4015 Simplify debugging check and convert to eassert. Adjust comment.
4016 (pp_cache): Put under ENABLE_CHECKING.
4017
a5cc4dde
EZ
40182013-03-14 Eli Zaretskii <eliz@gnu.org>
4019
4020 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4021 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4022 and WM_ACTIVATEAPP.
4023 (w32fullscreen_hook): If the frame is visible, reset
4024 f->want_fullscreen flag after changing the frame size. If the
4025 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4026 (Bug#13953)
4027
3fc5e44a
DC
40282013-03-13 Daniel Colascione <dancol@dancol.org>
4029
4030 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4031 too so that these builds can use Cygwin's file conversion
4032 functions. (We've been building and linking cygw32.o all along
4033 and just not using it.)
4034
47d7532e
PE
40352013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 File synchronization fixes (Bug#13944).
4038 * Makefile.in (LIB_FDATASYNC): New macro.
4039 (LIBES): Use it.
4040 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4041 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4042 Don't worry about HAVE_FSYNC, since a substitute fsync is
4043 available if the system lacks one.
4044 (Fwrite_regin): Retry fsync if interrupted.
4045
c7ffccaf
EZ
40462013-03-13 Eli Zaretskii <eliz@gnu.org>
4047
4e2df81d 4048 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4049 activated, call w32fullscreen_hook, to make sure the new frame
4050 dimensions are in effect. (Bug#13937)
4051
8a7debc1
DA
40522013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4053
4054 * xdisp.c (init_iterator): Simplify because both character and byte
4055 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4056 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4057 character and byte positions can be obtained from marker.
8a7debc1 4058
7fd8c501
PE
40592013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4060
d9df6f40
PE
4061 Static checking by Sun C 5.12.
4062 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4063 * bytecode.c (exec_byte_code):
4064 * dispnew.c (init_display):
4065 * eval.c (error):
4066 * fileio.c (Fsubstitute_in_file_name):
4067 * keyboard.c (Fevent_convert_list):
4068 * keymap.c (Fsingle_key_description):
4069 * term.c (maybe_fatal, fatal):
4070 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4071 * xsmfns.c (Fhandle_save_session):
4072 Omit unreachable code.
4073 * keymap.c (map_keymap_char_table_item): Cast void * to
4074 a function pointer type; the C Standard requires this.
4075
7fd8c501
PE
4076 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4077 Include <sys/param.h> unconditionally, as that works elsewhere and
4078 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4079 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4080 and FreeBSD now.
4081
a020afb9 4082See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4083
4084;; Local Variables:
4085;; coding: utf-8
aac0c6e3
MR
4086;; End:
4087
ab422c4d 4088 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4089
4090 This file is part of GNU Emacs.
4091
4092 GNU Emacs is free software: you can redistribute it and/or modify
4093 it under the terms of the GNU General Public License as published by
4094 the Free Software Foundation, either version 3 of the License, or
4095 (at your option) any later version.
4096
4097 GNU Emacs is distributed in the hope that it will be useful,
4098 but WITHOUT ANY WARRANTY; without even the implied warranty of
4099 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4100 GNU General Public License for more details.
4101
4102 You should have received a copy of the GNU General Public License
4103 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.