Fix minor problems found by --enable-gcc-warnings.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c43843aa
PE
12013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix minor problems found by --enable-gcc-warnings.
4 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
5 * keyboard.c (kbd_buffer_get_event): Remove unused local.
6
18c26d81
JD
72013-07-16 Jan Djärv <jan.h.d@swipnet.se>
8
9 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
10 Set event->arg to Qt if switch-event shall be generated.
11 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
12
13 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
14
15 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
16 FOCUS_OUT_EVENT.
17
18 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
19 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
20 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
21 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
22 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
23 and there is a focused frame.
24 (head_table): Add focus-in and focus-out.
25 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
26 bind to handle-focus-in/out.
27
28 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
29 (Fhandle_switch_frame): Call Fhandle_focus_in.
30 (syms_of_frame): defsubr handle-focus-in/out.
31
6c6f1994
PE
322013-07-16 Paul Eggert <eggert@cs.ucla.edu>
33
c7ddc792
PE
34 Fix porting bug to older POSIXish platforms (Bug#14862).
35 * sysdep.c (emacs_pipe): New function, that implements
36 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
37 This should port better to CentOS 5 and to Mac OS X 10.6.
38 All calls to pipe2 changed.
39
6c6f1994
PE
40 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
41 This makes the code easier to read and the executable a bit smaller.
42 Do not replace all calls to Fcons that happen to create lists,
43 just calls that are intended to create lists. For example, when
44 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
45 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
46 Similarly for list2 through list5.
47 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
48 * bytecode.c (exec_byte_code):
49 * callint.c (quotify_arg, Fcall_interactively):
50 * callproc.c (Fcall_process, create_temp_file):
51 * charset.c (load_charset_map_from_file)
52 (Fdefine_charset_internal, init_charset):
53 * coding.c (get_translation_table, detect_coding_system)
54 (Fcheck_coding_systems_region)
55 (Fset_terminal_coding_system_internal)
56 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
57 * composite.c (update_compositions, Ffind_composition_internal):
58 * dired.c (directory_files_internal, file_name_completion)
59 (Fsystem_users):
60 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
61 * doc.c (Fsnarf_documentation):
62 * editfns.c (Fmessage_box):
63 * emacs.c (main):
64 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
65 (Feval, eval_sub, Ffuncall, apply_lambda):
66 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
67 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
68 (Fset_file_times, Finsert_file_contents)
69 (Fchoose_write_coding_system, Fwrite_region):
70 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
71 * font.c (font_registry_charsets, font_parse_fcname)
72 (font_prepare_cache, font_update_drivers, Flist_fonts):
73 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
74 * frame.c (make_frame, Fmake_terminal_frame)
75 (x_set_frame_parameters, x_report_frame_params)
76 (x_default_parameter, Fx_parse_geometry):
77 * ftfont.c (syms_of_ftfont):
78 * image.c (gif_load):
79 * keyboard.c (command_loop_1):
80 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
81 (Fcopy_keymap, append_key, Fcurrent_active_maps)
82 (Fminor_mode_key_binding, accessible_keymaps_1)
83 (Faccessible_keymaps, Fwhere_is_internal):
84 * lread.c (read_emacs_mule_char):
85 * menu.c (find_and_return_menu_selection):
86 * minibuf.c (get_minibuffer):
87 * nsfns.m (Fns_perform_service):
88 * nsfont.m (ns_script_to_charset):
89 * nsmenu.m (ns_popup_dialog):
90 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
91 (Fx_own_selection_internal):
92 * nsterm.m (append2):
93 * print.c (Fredirect_debugging_output)
94 (print_prune_string_charset):
95 * process.c (Fdelete_process, Fprocess_contact)
96 (Fformat_network_address, set_socket_option)
97 (read_and_dispose_of_process_output, write_queue_push)
98 (send_process, exec_sentinel):
99 * sound.c (Fplay_sound_internal):
100 * textprop.c (validate_plist, add_properties)
101 (Fput_text_property, Fadd_face_text_property)
102 (copy_text_properties, text_property_list, syms_of_textprop):
103 * unexaix.c (report_error):
104 * unexcoff.c (report_error):
105 * unexsol.c (unexec):
106 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
107 (Fformat_mode_line, syms_of_xdisp):
108 * xfaces.c (set_font_frame_param)
109 (Finternal_lisp_face_attribute_values)
110 (Finternal_merge_in_global_face, syms_of_xfaces):
111 * xfns.c (x_default_scroll_bar_color_parameter)
112 (x_default_font_parameter, x_create_tip_frame):
113 * xfont.c (xfont_supported_scripts):
114 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
115 (menu_help_callback, xmenu_show):
116 * xml.c (make_dom):
117 * xterm.c (set_wm_state):
118 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
119 and similarly for list2 through list5.
120
bafe80ce
PE
1212013-07-15 Paul Eggert <eggert@cs.ucla.edu>
122
123 * callproc.c (Fcall_process_region): Fix minor race and tune.
124 (create_temp_file): New function, with the temp-file-creation part
125 of the old Fcall_process_region. Use Fcopy_sequence to create the
126 temp file name, rather than alloca + build_string, for simplicity.
127 Don't bother to block input around the temp file creation;
128 shouldn't be needed. Simplify use of mktemp. Use
129 record_unwind_protect immediately after creating the temp file;
130 this closes an unlikely race where the temp file was not removed.
131 Use memcpy rather than an open-coded loop.
132 (Fcall_process_region): Use the new function. If the input is
133 empty, redirect from /dev/null rather than from a newly created
134 empty temp file; this avoids unnecessary file system traffic.
135
4700b5a5
PE
1362013-07-14 Paul Eggert <eggert@cs.ucla.edu>
137
5c97beae
PE
138 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
139 Simplify by making this case like the other two. This is a bit
140 slower on obsolete hosts, but the extra complexity isn't worth it.
141
4700b5a5
PE
142 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
143 * process.c (create_process) [!DOS_NT]:
144 Remove now-unnecessary calls to emacs_close.
145
f9a74c4c
EZ
1462013-07-13 Eli Zaretskii <eliz@gnu.org>
147
922ae7ee
EZ
148 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
149 returning early. (Bug#14850)
150
f9a74c4c
EZ
151 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
152 and inhibit-iso-escape-detection attributes of 'undecided'.
153 (Bug#14822)
154
5e301d76
PE
1552013-07-13 Paul Eggert <eggert@cs.ucla.edu>
156
69e0e5ee
PE
157 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
158 Reported by Herbert J. Skuhra in
159 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
160
5e301d76
PE
161 Don't lose top specpdl entry when memory is exhausted.
162 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
163 specpdl overflow here, to simplify callers; all callers changed.
164 Always reserve an unused entry at the stack top; this avoids
165 losing the top entry's information when memory is exhausted.
166
7e649856
PE
1672013-07-12 Paul Eggert <eggert@cs.ucla.edu>
168
a773ed9a
PE
169 Clean up errno reporting and fix some errno-reporting bugs.
170 * callproc.c (Fcall_process):
171 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
172 * process.c (create_process, Fmake_network_process):
173 * unexaix.c (report_error):
174 * unexcoff.c (report_error):
175 Be more careful about reporting the errno of failed operations.
176 The code previously reported the wrong errno sometimes.
177 Also, prefer report_file_errno to setting errno + report_file_error.
178 (Fcall_process): Look at openp return value rather than at path,
179 as that's a bit faster and clearer when there's a numeric predicate.
180 * fileio.c (report_file_errno): New function, with most of the
181 old contents of report_file_error.
182 (report_file_error): Use it.
183 (Ffile_exists_p, Ffile_accessible_directory_p):
184 Set errno to 0 when it is junk.
185 * fileio.c (Faccess_file):
186 * image.c (x_create_bitmap_from_file):
187 Use faccessat rather than opening the file, to avoid the hassle of
188 having a file descriptor open.
189 * lisp.h (report_file_errno): New decl.
190 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
191
7e649856
PE
192 Minor EBADF fixes.
193 * process.c (create_process, wait_reading_process_output) [AIX]:
194 Remove obsolete SIGHUP-related code, as Emacs no longer disables
195 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
196 a multithreaded environment anyway).
197 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
198
f6774c1a
AS
1992013-07-12 Andreas Schwab <schwab@linux-m68k.org>
200
201 * image.c (x_find_image_file): Don't close a remote file handle.
202
bacba3c2
PE
2032013-07-12 Paul Eggert <eggert@cs.ucla.edu>
204
205 Fix races with threads and file descriptors.
206 * callproc.c (Fcall_process_region):
207 * dired.c (open_directory):
208 * emacs.c (main, Fdaemon_initialized):
209 * image.c (x_find_image_file):
210 * inotify.c (Finotify_rm_watch):
211 * lread.c (Flocate_file_internal):
212 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
213 * term.c (term_mouse_moveto, init_tty):
214 * termcap.c (tgetent):
215 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
216 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
217 * unexhp9k800.c, unexmacosx.c (unexec):
218 * callproc.c (Fcall_process_region):
219 Use emacs_close, not close.
220 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
221 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
222 and posix_close function on current platforms (which all lack them).
223 (emacs_close): Use it. This should fix the races on GNU/Linux and
224 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
225 and it should avoid closing random victim file descriptors on
226 other platforms.
227
653d4f43
PE
2282013-07-11 Paul Eggert <eggert@cs.ucla.edu>
229
c8536ec4
PE
230 * inotify.c (uninitialized): Remove. All uses replaced by -1.
231 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
232 Touch up doc a bit.
233
9c203066
PE
234 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
235 This is for .gdbinit xbacktrace.
236
653d4f43
PE
237 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
238 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
239 (emacs_set_tty): Now static.
240 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
241 * term.c (tty_capable_p, tty_default_color_capabilities)
242 (get_tty_terminal, term_mouse_movement)
243 (handle_one_term_event, init_tty, maybe_fatal):
244 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
245 (tgetent, scan_file, name_match, compare_contin):
246 * terminal.c (get_terminal):
247 Use bool for boolean.
248 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
249 Prefer char to unsigned char if either will do.
250 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
251 (tty_write_glyphs): Prefer int to unsigned.
252 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
253 All callers changed.
254 * termcap.c (tprint, main) [TEST]: Remove non-working test.
255
45b683a1
PE
2562013-07-10 Paul Eggert <eggert@cs.ucla.edu>
257
29abe551
PE
258 Port to C89.
259 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
260 (B__dummy__): New dummy symbol, to pacify C89.
261 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
262 they can't grok varargs macros.
263 * dispnew.c (add_window_display_history)
264 (add_frame_display_history):
265 * print.c (print_object):
266 * xdisp.c (debug_method_add):
267 Use %p printf format only for void pointers.
268 * emacs.c (usage_message): New constant, replacing ...
269 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
270 (main): Adjust to usage reorg.
271 * fns.c (syms_of_fns):
272 * profiler.c (syms_of_profiler):
273 Don't use non-constant struct initializers.
274 * gnutls.h (gnutls_initstage_t):
275 * lisp.h (enum Lisp_Fwd_Type):
276 * lread.c (lisp_file_lexically_bound_p):
277 * xsettings.c (anonymous enum):
278 Remove trailing comma.
279 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
280 * lisp.h (ENUM_BF): Use unsigned if pedantic.
281 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
282 (DEFUN): Use it.
283 * regex.c (const_re_char): New type, to pacify strict C89.
284 All uses of 'const re_char' replaced to use it.
285 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
286 with glibc when strict C89. This change is imported from gnulib.
287 All uses changed.
288 (_Restrict_arr_): Rename from __restrict_arr, similarly.
289 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
290 Omit GNU_LINUX implementation, since it requires long long.
291 * xterm.c (x_draw_underwave):
292 Do not assume the traditional order of struct's members.
293 (x_term_init): Rewrite to avoid the need for non-constant structure
294 initializers.
295
45b683a1
PE
296 Syntax cleanup, mostly replacing macros with functions.
297` This removes the need for the syntax_temp hack.
298 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
299 * syntax.c (SYNTAX_INLINE): New macro.
300 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
301 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
302 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
303 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
304 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
305 (SYNTAX_COMEND_FIRST): Now functions, not macros.
306 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
307 Now constants, not macros.
308 (syntax_temp) [!__GNUC__]: Remove.
309 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
310 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
311 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
312 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
313 Move here from syntax.h; now functions, not macros. Except for the
314 last function, these are static since only syntax.c uses them.
315 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
316 All uses changed. Now a function, not a macro; use this fact
317 to simplify the code.
318 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
319 compiler bugs; no longer relevant.
320 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
321 (SYNTAX_INLINE): New macro.
322 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
323 for the new functions. Use bool for boolean member.
324 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
325 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
326 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
327 (SETUP_BUFFER_SYNTAX_TABLE):
328 Now extern inline functions, not macros.
329 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
330 Remove; all uses replaced by implementation.
331 (syntax_temp) [!__GNUC__]: Remove decl.
332 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
333
29be4a50
JD
3342013-07-10 Jan Djärv <jan.h.d@swipnet.se>
335
336 * emacs.c (main): Fix syntax error.
337
954b166e
PE
3382013-07-10 Paul Eggert <eggert@cs.ucla.edu>
339
340 Timestamp fixes for undo (Bug#14824).
341 * atimer.c (schedule_atimer):
342 * fileio.c (Ffile_newer_than_file_p):
343 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
344 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
345 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
346 (syms_of_fileio): Remove Sclear_visited_file_name.
347 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
348 file doesn't exist; this avoids an ambiguity with negative timestamps.
349 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
350 * systime.h (make_emacs_time, invalid_emacs_time):
351 Don't assume struct timespec layout; POSIX doesn't guarantee it.
352 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
353 * undo.c (record_first_change): Push (visited-file-modtime) onto
354 undo list rather than reimplementing it by hand, incorrectly.
355
d74647c3
KB
3562013-07-09 Ken Brown <kbrown@cornell.edu>
357
358 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
359
3c51b96b
JB
3602013-07-09 Juanma Barranquero <lekktu@gmail.com>
361
362 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
363
4ebbdd67
PE
3642013-07-09 Paul Eggert <eggert@cs.ucla.edu>
365
366 Handle errno and exit status a bit more carefully.
367 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
368 number into an exit status. Instead, use EXIT_CANCELED.
369 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
370 * callproc.c (relocate_fd):
371 * emacs.c (close_output_streams, main):
372 * process.c (create_process):
373 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
374 Use emacs_perror for simplicity.
375 * callproc.c (relocate_fd, main):
376 * sysdep.c (sys_subshell):
377 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
378 (shut_down_emacs): Use emacs_write, not write.
379 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
380 * fileio.c (Fcopy_file, e_write):
381 * nsterm.m (ns_select):
382 * process.c (send_process):
383 * sound.c (vox_write):
384 Use emacs_write_sig, not emacs_write.
385 * lisp.h (emacs_write_sig, emacs_perror): New decls.
386 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
387 New constants.
388 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
389 of write.
390 (emacs_full_write): New function.
391 (emacs_write): Rewrite to use it.
392 (emacswrite_sig, emacs_perror): New functions.
393 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
394
e4b1e5af
JD
3952013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change).
396
397 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
398 on NS even if it is present. Pixmap on NS is a void*.
399
9caab067
PE
4002013-07-07 Paul Eggert <eggert@cs.ucla.edu>
401
402 Port to Ubuntu 10 (Bug#14803).
403 Problem reported by T.V. Raman.
404 * process.c (close_on_exec, accept4, process_socket):
405 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
406
1d442672
EZ
4072013-07-07 Eli Zaretskii <eliz@gnu.org>
408
409 * w32.c (sys_dup): Declare prototype.
410
411 * filelock.c:
412 * emacs.c:
413 * callproc.c [WINDOWSNT]: Include sys/socket.h.
414
067428c1
PE
4152013-07-07 Paul Eggert <eggert@cs.ucla.edu>
416
417 Make file descriptors close-on-exec when possible (Bug#14803).
418 This simplifies Emacs a bit, since it no longer needs to worry
419 about closing file descriptors by hand in some cases.
420 It also fixes some unlikely races. Not all such races, as
421 libraries often open files internally without setting
422 close-on-exec, but it's an improvement.
423 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
424 * callproc.c (Fcall_process) [!MSDOS]:
425 * emacs.c (main) [!DOS_NT]:
426 * nsterm.m (ns_term_init):
427 * process.c (create_process):
428 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
429 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
430 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
431 Prefer mkostemp with O_CLOEXEC to mkstemp.
432 * callproc.c (relocate_fd) [!WINDOWSNT]:
433 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
434 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
435 now using pipe2.
436 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
437 Make the resulting file descriptor close-on-exec.
438 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
439 * lread.c (load_descriptor_list, load_descriptor_unwind):
440 Remove; no longer needed. All uses removed.
441 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
442 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
443 New functions.
444 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
445 (Fmake_network_process, Fnetwork_interface_list):
446 (Fnetwork_interface_info, server_accept_connection):
447 Make newly-created socket close-on-exec.
448 * sysdep.c (emacs_open, emacs_fopen):
449 Make new-created descriptor close-on-exec.
450 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
451 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
452
0da857dd
JD
4532013-07-07 Jan Djärv <jan.h.d@swipnet.se>
454
455 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
456 for NS_IMPL_GNUSTEP.
457
5f86adcd
PE
4582013-07-07 Paul Eggert <eggert@cs.ucla.edu>
459
460 Fix openp errno handling.
461 * callproc.c (Fcall_process): Preserve openp errno around close.
462 * lread.c (openp): Set errno when returning -1, as some callers
463 expect this.
464
1afb1d07
JD
4652013-07-06 Jan Djärv <jan.h.d@swipnet.se>
466
467 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
468
469 * nsterm.h (NSSavePanel): Update comment.
470 (NSAPP_DATA2_RUNFILEDIALOG): Define.
471 (ns_run_file_dialog): Declare.
472
473 * nsfns.m: Remove panelOK.
474 (ns_fd_data): New.
475 (ns_run_file_dialog): New function.
476 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
477 event loop, so file dialog is popped up by ns_run_file_dialog, called
478 by sendEvent (Bug#14578).
479 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
480
3323c263
EZ
4812013-07-06 Eli Zaretskii <eliz@gnu.org>
482
fdda0220
EZ
483 * xdisp.c (default_line_pixel_height): New function.
484 (pos_visible_p, move_it_vertically_backward, try_scrolling)
485 (try_cursor_movement, redisplay_window, try_window)
486 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
487
488 * window.c (window_scroll_pixel_based): use
489 default_line_pixel_height.
490
491 * dispextern.h (default_line_pixel_height): Add prototype.
492
493 * frame.c (x_set_line_spacing): Accept a float value for
494 line-spacing parameter, per the documentation.
495
3323c263
EZ
496 * data.c (Fmultibyte_string_p): Doc fix.
497
47ba6d43
PE
4982013-07-05 Paul Eggert <eggert@cs.ucla.edu>
499
406af475
PE
500 Use emacs_open more consistently when opening files.
501 This handles EINTR more consistently now, and makes it easier
502 to introduce other uniform changes to file descriptor handling.
503 * src/systdio.h: New file.
504 * src/buffer.c (mmap_init):
505 * cygw32.c (chdir_to_default_directory):
506 * dispnew.c (Fopen_termscript):
507 * emacs.c (Fdaemon_initialized):
508 * fileio.c (Fdo_auto_save):
509 * image.c (slurp_file, png_load_body, jpeg_load_body):
510 * keyboard.c (Fopen_dribble_file):
511 * lread.c (Fload):
512 * print.c (Fredirect_debugging_output):
513 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
514 * termcap.c (tgetent):
515 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
516 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
517 * w32term.c (w32_initialize) [CYGWIN]:
518 * xfaces.c (Fx_load_color_file):
519 Use emacs_open instead of plain open, and emacs_fopen instead of
520 plain fopen.
521 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
522 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
523 * callproc.c (default_output_mode): New constant.
524 (Fcall_process): Use it to call emacs_open instead of plain creat.
525 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
526 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
527 (emacs_fopen): New function.
528 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
529 Include <lisp.h>, for emacs_open.
530 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
531
47ba6d43
PE
532 Remove duplicate #include directives.
533 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
534 * xfaces.c:
535 Don't include stdio.h twice.
536 * buffer.c [USE_MMAP_FOR_BUFFERS]:
537 Don't include sys/types.h or stdio.h twice.
538 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
539 * lread.c: Don't include coding.h twice.
540 * nsfont.m: Don't include frame.h twice.
541 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
542 * ralloc.c: Don't include <unistd.h> twice.
543 * xdisp.c: Don't include font.h twice.
544 * xterm.c: Don't include fontset.h twice.
545 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
546
b9ed53d5
PE
5472013-07-04 Paul Eggert <eggert@cs.ucla.edu>
548
549 Scale ImageMagick images more carefully.
550 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
551 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
552 Be more careful about avoiding undefined behavior after
553 integer overflow and division by zero.
554
cf13177e
YM
5552013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
556
557 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
558 (syms_of_w32fns): DEFSYM them.
559 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
560 (CCHDEVICENAME): Define macros if not defined.
561 (struct MONITOR_INFO_EX): New struct.
562 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
563 (enum_display_monitors_fn): New variable.
564 (globals_of_w32fns): Initialize it.
565 (Fx_display_pixel_width, Fx_display_pixel_height)
566 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
567 multi-monitor setups in docstrings.
568 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
569 screen size by primary monitor's millimeter per pixel.
570 (w32_monitor_enum, w32_display_monitor_attributes_list)
571 (w32_display_monitor_attributes_list_fallback)
572 (Fw32_display_monitor_attributes_list): New functions.
573 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
574
575 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
576 if not defined.
577 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
578
86dfb7a8
MA
5792013-07-04 Michael Albinus <michael.albinus@gmx.de>
580
581 * fileio.c (Qfile_notify_error): New error symbol.
582
583 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
584 * inotify.c (inotify_callback, symbol_to_inotifymask)
585 (Finotify_add_watch, Finotify_rm_watch): Use it.
586 (inotifyevent_to_event): Exchange order of cookie and file name.
587 (Finotify_add_watch): Adapt docstring.
588
589 * lisp.h (Qfile_notify_error): Declare.
590
2c1c974b
PE
5912013-07-04 Paul Eggert <eggert@cs.ucla.edu>
592
593 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
594 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
595 Do not clear _malloc_thread_enabled_p, undoing the previous change,
596 which did not work (see <http://bugs.gnu.org/14569#307>).
597 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
598 && (!noninteractive || initialized)). This attempts to thread
599 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
600
7a35b20f
JB
6012013-07-04 Juanma Barranquero <lekktu@gmail.com>
602
603 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
604 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
605
1ce5cd04
PE
6062013-07-04 Paul Eggert <eggert@cs.ucla.edu>
607
608 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
609 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
610 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
611 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
612
57f8c490
PE
6132013-07-02 Paul Eggert <eggert@cs.ucla.edu>
614
615 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
616 Define to __sys_siglist.
617
bcffb5ca
EZ
6182013-07-02 Eli Zaretskii <eliz@gnu.org>
619
620 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
621 word-wrap, so that overflow-newline-into-fringe would work in
622 visual-line-mode. (Bug#2749)
623 (move_it_in_display_line_to): When the last scanned display
624 element fits exactly on the display line, and
625 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
626 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
627 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
628 finding buffer position that corresponds to pixel coordinates,
629 e.g. in buffer_posn_from_coords.
630
2c41e781
JD
6312013-07-02 Jan Djärv <jan.h.d@swipnet.se>
632
633 * process.c (handle_child_signal): Call catch_child_signal if
634 NS_IMPL_GNUSTEP.
635
c2418359
PE
6362013-07-02 Paul Eggert <eggert@cs.ucla.edu>
637
52a9bcae
PE
638 Don't convert function pointers to void * and back.
639 It isn't portable C, and it's easy enough to avoid.
640 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
641 (make_save_value): Add support for SAVE_FUNCPOINTER.
642 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
643 * print.c (print_object):
644 Distinguish function from object pointers.
645 * lisp.h (SAVE_FUNCPOINTER): New constant.
646 (SAVE_SLOT_BITS): Adjust to it.
647 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
648 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
649 (voidfuncptr): New typedef.
650 (struct Lisp_Save_Value): New member data[0].funcpointer.
651 (XSAVE_FUNCPOINTER): New function.
652
c2418359
PE
653 Simplify buildobj processing.
654 * Makefile.in (buildobj.h): Make it a sequence of strings each
655 followed by comma, rather than a single string. Put it into a
656 .tmp file in case there's an error while generating it.
657 (gl-stamp): Use .tmp for temp files.
658 (mostlyclean): Clean .tmp files.
659 * doc.c (buildobj): Move to just the routine that needs it.
660 It's now an array of strings, so processing is simpler.
661
8f43ce49
PE
6622013-07-01 Paul Eggert <eggert@cs.ucla.edu>
663
664 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
665 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
666 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
667 Invoke malloc_enable_thread even when not interactive.
668 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
669 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
670 in this case, since the underlying bug has now been fixed.
671
24827db9
JB
6722013-07-01 Juanma Barranquero <lekktu@gmail.com>
673
674 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
675 unlinking it (bug#14691).
676
ef099a94
MN
6772013-06-30 Michal Nazarewicz <mina86@mina86.com>
678
679 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
680 before checking whether buffer is modified. This lets
681 `kill-buffer-query-functions' cancel killing of the buffer or save
682 its content before `kill-buffer' asks user the "Buffer %s
683 modified; kill anyway?" question.
684
9d3f2fc2
JD
6852013-06-30 Jan Djärv <jan.h.d@swipnet.se>
686
687 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
688 Let the super performKeyEquivalent deal with them (Bug#14747).
689
e6c6c8c7
PE
6902013-06-30 Paul Eggert <eggert@cs.ucla.edu>
691
1d71c1d9
PE
692 * widget.c (resize_cb): Remove unused local.
693
8f5f35cc
PE
694 Do not use GTK 3 if it exists but cannot be compiled.
695 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
696 * xterm.c (x_error_handler) [!USE_GTK]:
697 Do not use GTK 3.
698
e6c6c8c7
PE
699 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
700
0ba54312
EZ
7012013-06-30 Eli Zaretskii <eliz@gnu.org>
702
5d1c3286
EZ
703 * intervals.c (get_local_map): Instead of aborting, clip POSITION
704 to the valid range of values. (Bug#14753)
705
0ba54312
EZ
706 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
707 when moving point by using the current glyph matrix. This avoids
708 the need to force redisplay when this function is called in a
709 loop.
710
9c90cc06
PE
7112013-06-29 Paul Eggert <eggert@cs.ucla.edu>
712
713 Fix minor problems found by static checking.
714 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
715 Redo the latter's body to sidestep GCC parenthesization warnings.
716 (setup_coding_system, detect_coding, detect_coding_system): Use them.
717 * coding.c (detect_coding, detect_coding_system):
718 * coding.h (struct undecided_spec):
719 Use bool for boolean.
720 * image.c (QCmax_width, QCmax_height): Now static.
721 * xdisp.c (Fmove_point_visually): Remove unused local.
722
4c672a0f
EZ
7232013-06-29 Eli Zaretskii <eliz@gnu.org>
724
725 * xdisp.c (Fmove_point_visually): New function.
726
c1ea3abf
JB
7272013-06-28 Kenichi Handa <handa@gnu.org>
728
729 * coding.h (define_coding_undecided_arg_index): New enum.
730 (coding_attr_index): New members
731 coding_attr_undecided_inhibit_null_byte_detection,
732 coding_attr_undecided_inhibit_iso_escape_detection,
733 coding_attr_undecided_prefer_utf_8.
734 (undecided_spec): New struct.
735 (struct coding_system): New member `undecided' of the member
736 `spec'.
737
738 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
739 (detect_coding): Likewise.
740 (detect_coding_system): Likewise.
741 (Fdefine_coding_system_internal): New coding system properties
742 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
743 :prefer-utf-8.
744 (syms_of_coding): Adjust for coding_arg_undecided_max.
745
ba3de9e6
PE
7462013-06-28 Paul Eggert <eggert@cs.ucla.edu>
747
748 * image.c (x_from_xcolors): Remove unused local.
749
547c9269
YM
7502013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
751
752 Defer image data transfer between X client and server until actual
753 display happens.
754
755 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
756 and `mask_img'.
757
758 * image.c (Destroy_Image): Remove.
759 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
760 `mask_p', and `colors_p'. All uses changed.
761 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
762 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
763 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
764 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
765 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 766 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
767 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
768 (image_get_x_image, image_unget_x_image): New functions or macros.
769 (image_background, image_background_transparent, x_to_xcolors)
770 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
771 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
772 instead of Destroy_Image.
773 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
774 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
775 (png_load_body, jpeg_load_body, tiff_load, gif_load)
776 (imagemagick_load_image, svg_load_image): Use them instead of
777 x_create_x_image_and_pixmap, and x_put_x_image followed by
778 x_destroy_x_image, respectively.
779 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
780 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
781 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
782 background_transparent fields.
783 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
784 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
785
dae2f5ef
PE
7862013-06-27 Paul Eggert <eggert@cs.ucla.edu>
787
788 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
789 This mostly consists of undoing recent changes.
790 * callproc.c (Fcall_process):
791 * process.c (create_process):
792 Do not worry about catching SIGCHLD here, undoing previous change.
793 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
794 * process.c, process.h (catch_child_signal):
795 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
796 * process.c (catch_child_handler): Don't worry about being called
797 lazily and do not assume caller has blocked SIGCHLD, undoing
798 previous change. Move first-time stuff back to
799 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
800 tickle glib, as that causes Cygwin bootstrap to fail. Do not
801 set lib_child_handler if it's already initialized, which may
802 help avoid problems on GNUStep.
803
fa55d2aa
PE
8042013-06-23 Paul Eggert <eggert@cs.ucla.edu>
805
806 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
807 * callproc.c (Fcall_process):
808 * process.c (create_process):
809 Make sure SIGCHLD is caught before we fork,
810 since Emacs startup no arranges to catch SIGCHLD.
811 * process.c (lib_child_handler): Initialize to null, not to
812 dummy_handler.
813 (catch_child_signal): Allow self to be called lazily.
814 Do nothing if it's already been called.
815 Assume caller has blocked SIGCHLD (all callers do now).
816 * emacs.c (main): Do not catch SIGCHLD here; defer it until
817 just before it's really needed.
818 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
819 since it hasn't been caught yet.
820
f3f9606c
LMI
8212013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
822
823 * image.c (compute_image_size): New function to implement
824 :max-width and :max-height.
825 (imagemagick_load_image): Use it.
826
c7041908
PE
8272013-06-23 Paul Eggert <eggert@cs.ucla.edu>
828
829 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
830 * callproc.c, process.h (block_child_signal, unblock_child_signal):
831 Now extern.
832 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
833 * process.c (catch_child_signal): Block SIGCHLD while futzing with
834 the SIGCHLD handler, since the code is not atomic and (due to glib)
835 signals may be arriving now.
836 * sysdep.c (init_signals): Do not catch child signals here;
837 'main' now does that later, at a safer time.
838
f86852b4
PE
8392013-06-22 Paul Eggert <eggert@cs.ucla.edu>
840
0dfeed58
PE
841 Clean up SIGCHLD handling a bit (Bug#14569).
842 * process.c, process.h (catch_child_signal):
843 Now always extern, even if !NS_IMPL_GNUSTEP.
844 * process.c (catch_child_signal): Move glib tickler here from
845 init_process_emacs, so that it's done earlier in Emacs
846 initialization. Also move the noninteractive && !initialized
847 check here from init_process_emacs. This is all a bit cleaner for
848 GNUish platforms, and I hope it works around the Cygwin bug.
849 * sysdep.c (init_signals): Invoke catch_child_signal here, so
850 that glib signal handling is tickled before glib creates threads.
851
f86852b4
PE
852 * process.c (wait_reading_process_output): Avoid int overflow
853 when reading more than 2 GiB total from a process.
854
cbd6509c
PE
8552013-06-21 Paul Eggert <eggert@cs.ucla.edu>
856
857 * process.c (create_process): Handle a couple more cases,
858 i.e., work even if new_argv and wait_child_setup[i] are cached.
859 Use Fcall_process's style for volatile vars.
860
9de1114a
AS
8612013-06-21 Andreas Schwab <schwab@linux-m68k.org>
862
863 * process.c (create_process): Mark PROCESS volatile.
864
fbe9e0b9
PE
8652013-06-21 Paul Eggert <eggert@cs.ucla.edu>
866
867 Use C99-style flexible array members if available.
868 This avoids some subtle aliasing issues, which typically
869 aren't a problem with GCC but may be a problem elsewhere.
870 * alloc.c (sdata): New typedef, replacing the old struct sdata.
871 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
872 In either case, it uses a flexible array member rather than
873 the old struct hack. All uses changed.
874 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
875 Adjust to sdata reorganization.
876 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
877 Use offsetof (struct, flex_array_member), not sizeof (struct), as
878 that ports better to pre-C99 non-GCC.
879 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
880 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
881 as the latter has changed.
882 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
883 and port better to pre-C99 GCC.
884 * image.c (struct xpm_cached_color):
885 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
886 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
887 Use FLEXIBLE_ARRAY_MEMBER.
888 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
889 Move decl to top level so it gets checked against implementation.
890 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
891 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
892
1fc71008
PE
8932013-06-20 Paul Eggert <eggert@cs.ucla.edu>
894
895 * syntax.c: Integer cleanups.
896 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
897 All uses that need 0-or-2 changed to:
898 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
899 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
900 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
901 (char_quoted, prev_char_comend_first, back_comment)
902 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
903 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
904 Use bool for boolean.
905 (update_syntax_table, skip_chars, skip_syntaxes):
906 Prefer int to unsigned when either will do.
907 (back_comment): Return boolean success flag, like forw_comment,
908 instead of positive-or-minus-1 (which might have overflowed int anyway).
909 Don't stuff ptrdiff_t into int.
910 (syntax_spec_code, syntax_code_spec): Now const.
911 (Fmatching_paren, scan_lists, scan_sexps_forward):
912 Use enum syntaxcode for syntax code.
913 (Fmatching_paren): Check that arg is a character, not just an integer.
914 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
915 (Finternal_describe_syntax_value): Omit no-longer-needed
916 comparison to 0.
917 (skip_chars): Use char, not unsigned char, when the distinction
918 doesn't matter.
919 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
920 * bytecode.c (exec_byte_code):
921 * syntax.c (syntax_spec_code, Fchar_syntax)
922 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
923 (init_syntax_once):
924 * syntax.h (SYNTAX_WITH_FLAGS):
925 Omit unnecessary casts.
926
b932cad7
EZ
9272013-06-20 Eli Zaretskii <eliz@gnu.org>
928
929 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
930 line dimensions here, to avoid race conditions with the main
931 thread. (Bug#14062, bug#14630, bug#14669)
932
933 * w32term.c (w32_draw_window_cursor): Compute the header line and
934 mode line dimensions here.
935 <w32_system_caret_window, w32_system_caret_hdr_height>:
936 <w32_system_caret_mode_height>: New variables.
937
938 * w32term.h: Declare them.
939
89561f72
PE
9402013-06-20 Paul Eggert <eggert@cs.ucla.edu>
941
5013fc08
PE
942 * alloc.c (die): Move "assertion failed" string here ...
943 * lisp.h (eassert): ... from here. Also, suppress evaluation of
944 COND when SUPPRESS_CHECKING. This shrinks the executable text
945 size by 0.8% to 2.2% when configured with --enable-checking,
946 depending on optimization flags (GCC 4.8.1 x86-64).
947
89561f72
PE
948 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
949
9502013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
951
952 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
953 base is 2; this is more accurate.
954
983aeb9a
JB
9552013-06-19 Juanma Barranquero <lekktu@gmail.com>
956
957 * sound.c (string_default): Move to !WINDOWSNT section.
958 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
959
178ba3e6
PE
9602013-06-19 Paul Eggert <eggert@cs.ucla.edu>
961
bbc51b15
PE
962 * sound.c: Integer cleanups.
963 Remove unnecessary forward decls.
964 (struct sound_device): The 'file' member is now a Lisp_Object, not
965 a char *, so that we needn't invoke alloca on a huge size.
966 (Fplay_sound_internal): Adjust to this.
967 (string_default): New function.
968 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
969 Use it to adjust to the struct sound_device change.
970 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
971 (be2hs) [0]: Remove.
972
178ba3e6
PE
973 * syntax.c (skip_chars): Don't use uninitialized storage
974 when searching a multibyte buffer for characters that are not in a
975 unibyte string that contains non-ASCII characters.
976
69f60cdc
JD
9772013-06-18 Jan Djärv <jan.h.d@swipnet.se>
978
979 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
980 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
981
0d6224d4
PE
9822013-06-18 Paul Eggert <eggert@cs.ucla.edu>
983
984 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
985
3c542890
KH
9862013-06-18 Kenichi Handa <handa@gnu.org>
987
f7e3f7cd
KH
988 * font.c (Ffont_spec): Signal an error for an invalid font name
989 (Bug#14648).
3c542890 990
9349e5f7
PE
9912013-06-18 Paul Eggert <eggert@cs.ucla.edu>
992
993 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
994 In particular this ports to 32-bit sparc Sun cc.
995 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
996 array with a dummy element at specpdl[-1], so that its address can
997 be taken portably.
998 (unbind_to): Do not copy the binding; not needed, now that we
999 copy old_value in the one place where the copy is needed.
1000 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1001 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1002 (union specbinding): Rename from struct specbinding. Redo layout
1003 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1004 which is not portable. With Sun C 5.12 32-bit sparc, the
1005 declaration causes nargs to be an unsigned bitfield, a behavior
1006 that the C standard allows; but Emacs wants nargs to be signed.
1007 The overall type is now a union of structures rather than a
1008 structure of union of structures, and the 'kind' member is now a
1009 bitfield, so that the overall type doesn't grow. All uses changed.
1010 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1011
0a4df6a5
PE
10122013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1013
ec6ecaad
PE
1014 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1015 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1016
0a4df6a5
PE
1017 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1018
7bfe8dbc
EZ
10192013-06-17 Eli Zaretskii <eliz@gnu.org>
1020
1021 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1022 unless we know that the window w's frame is a frame object.
1023 Another attempt at solving bug#14062 and bug#14630.
1024
708e05f6
LMI
10252013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1026
1027 * textprop.c (property_set_type): New enum.
1028 (add_properties): Allow appending/prepending text properties.
1029 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1030 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1031 add_text_properties_1.
1032 (Fadd_face_text_property): New function that calls
1033 add_text_properties_1.
1034
84575e67
PE
10352013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 Move functions from lisp.h to individual modules when possible.
1038 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1039 * alloc.c (XFLOAT_INIT, set_symbol_name):
1040 * buffer.c (CHECK_OVERLAY):
1041 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1042 (set_char_table_parent):
1043 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1044 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1045 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1046 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1047 (set_blv_valcell):
1048 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1049 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1050 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1051 (backtrace_args, backtrace_debug_on_exit):
1052 * floatfns.c (CHECK_FLOAT):
1053 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1054 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1055 (set_hash_hash, set_hash_hash_slot, set_hash_index)
1056 (set_hash_index_slot):
1057 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
1058 * marker.c (CHECK_MARKER):
1059 * textprop.c (CHECK_STRING_OR_BUFFER):
1060 * window.c (CHECK_WINDOW_CONFIGURATION):
1061 Move here from lisp.h, and make these functions static rather than
1062 extern inline.
1063 * buffer.c (Qoverlayp):
1064 * data.c (Qsubrp):
1065 * fns.c (Qhash_table_p):
1066 * window.c (Qwindow_configuration_p):
1067 Now static.
1068 * lisp.h: Remove the abovementioned defns and decls.
1069
1070 Use functions, not macros, for XINT etc. (Bug#11935).
1071 In lisp.h, prefer functions to function-like macros, and
1072 constants to object-like macros, when either will do. This:
1073 . simplifies use, as there's no more need to worry about
1074 arguments' side effects being evaluated multiple times.
1075 . makes the code easier to debug on some platforms.
1076 However, when using gcc -O0, keep using function-like macros
1077 for a few critical operations, for performance reasons.
1078 This sort of thing isn't needed with gcc -Og, but -Og
1079 is a GCC 4.8 feature and isn't widely-enough available yet.
1080 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
1081 Remove enum lsb_bits; no longer needed.
1082 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
1083 * buffer.c (Qoverlap):
1084 * data.c (Qsubrp):
1085 * fns.c (Qhash_table_p):
1086 Now extern, so lisp.h can use these symbols.
1087 * dispextern.h: Include character.h, for MAX_CHAR etc.
1088 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1089 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1090 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1091 (GLYPH_CODE_P): Move here from lisp.h.
1092 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1093 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
1094 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
1095 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
1096 XUNTAG now returns void *.
1097 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
1098 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
1099 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
1100 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
1101 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
1102 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
1103 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
1104 (lisp_h_XPNTR, lisp_h_XSYMBOL):
1105 New macros, renamed from their sans-lisp_h_ counterparts.
1106 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
1107 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
1108 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
1109 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
1110 If compiling via GCC without optimization, define these as macros
1111 in addition to inline functions.
1112 To disable this, compile with -DINLINING=0.
1113 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
1114 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
1115 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
1116 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
1117 (INTMASK, VALMASK): Now macros, since static values cannot be
1118 accessed from extern inline functions.
1119 (VALMASK): Also a constant, for benefit of old GDB.
1120 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
1121 is INTEGERP, which can fold it in.
5165d44a 1122 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
1123 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
1124 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
1125 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
1126 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
1127 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
1128 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
1129 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
1130 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
1131 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
1132 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
1133 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
1134 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
1135 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
1136 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
1137 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
1138 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
1139 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
1140 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
1141 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
1142 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
1143 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
1144 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
1145 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
1146 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
1147 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
1148 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
1149 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
1150 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
1151 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
1152 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
1153 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
1154 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
1155 Now functions.
1156 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
1157 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
1158 (VALMASK): Define in one place rather than in two, merging the
1159 USE_LSB_TAG parts; this is simpler.
1160 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
1161 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
1162 Move up, to avoid use before definition.
1163 Also include "globals.h" earlier, for the same reason.
1164 (make_natnum): New function.
1165 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
1166 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
1167 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
1168 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
1169 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
1170 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
1171 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
1172 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
1173 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
1174 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
1175 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
1176 (Qwindow_configuration_p, Qimage): New forward declarations.
1177 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
1178 (STRING_COPYIN): Remove; unused.
1179 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
1180 (xcar_addr, xcdr_addr): New functions. All uses changed.
1181 (IEEE_FLOATING_POINT): Now a constant, not a macro.
1182 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1183 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1184 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1185 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
1186 (TYPE_RANGED_INTEGERP): Simplify.
1187 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
1188 (setlocale, fixup_locale, synchronize_system_messages_locale)
1189 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
1190 Now empty functions, not macros.
1191 (functionp): Return bool, not int.
1192 * window.c (Qwindow_configuration_p): Now extern,
1193 so window.h can use it.
1194 * window.h (Qwindowp): Move decl back to lisp.h.
1195
9583ec36
EZ
11962013-06-15 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (Fline_pixel_height): New function, required for solving
1199 bug #14567.
1200
210272ce
PE
12012013-06-15 Paul Eggert <eggert@cs.ucla.edu>
1202
1203 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
1204
de0503df
SM
12052013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * lread.c (syms_of_lread):
1208 * fns.c (Fprovide): Adjust to new format of after-load-alist.
1209
afbfe143
KD
12102013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
1211
1212 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
1213
d177e213
XF
12142013-06-12 Xue Fuqiao <xfq.free@gmail.com>
1215
1216 * fileio.c (expand_file_name): Doc fix.
1217
05e3e412
PE
12182013-06-11 Paul Eggert <eggert@cs.ucla.edu>
1219
f7394b12
PE
1220 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
1221 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
1222 Wait for self, not for 0. This can't hurt on GNU or similar
1223 system, and may help with Cygwin.
1224
05e3e412
PE
1225 * keyboard.c: Don't use PROP (...) as an lvalue.
1226 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
1227 Use set_prop (A, B), not PROP (A) = B.
1228
17dd3097
EZ
12292013-06-10 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xdisp.c (get_it_property): Use it->window instead of generating
1232 a Lisp object from it->w.
1233
52fab9c9
EZ
12342013-06-09 Eli Zaretskii <eliz@gnu.org>
1235
1236 * xdisp.c (get_it_property): If it->object is a buffer, pass to
1237 get-char-property the window that is being rendered, instead of
1238 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
1239 (compute_display_string_pos): When W is NULL, use the current
1240 buffer as the object to pass to get-char-property.
1241 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
1242 pointer member of the bidi iterator, since no window is pertinent
1243 to this function.
52fab9c9 1244
5bf97bfc
EZ
12452013-06-08 Eli Zaretskii <eliz@gnu.org>
1246
1247 * bidi.c (bidi_fetch_char): Accept additional argument, the window
1248 being displayed, and pass it to compute_display_string_pos.
1249 (bidi_level_of_next_char, bidi_resolve_explicit_1)
1250 (bidi_paragraph_init): All callers changed.
1251
1252 * xdisp.c (init_from_display_pos, init_iterator)
1253 (handle_single_display_spec, next_overlay_string)
1254 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
1255 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
1256 Set bidi_it.w member from it->w.
5bf97bfc
EZ
1257 (compute_display_string_pos): Accept additional argument, the
1258 window being displayed, and pass it to Fget_char_property.
1259 (Bug#14575)
1260
1261 * dispextern.h (struct bidi_it): New member w, the window being
1262 displayed.
1263 (compute_display_string_pos): Adjust prototype.
1264
5de0e011
JD
12652013-06-08 Jan Djärv <jan.h.d@swipnet.se>
1266
e7b41c4c 1267 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
1268
1269 * process.c (wait_reading_process_output): Check for NS before GLIB.
1270 GLIB may be linked in due to rsvg, but ns_select must be called.
1271
5de0e011
JD
1272 * xgselect.c (xg_select): Remove call to window_system_available
1273 and g_main_context_pending at the top, so Gdk events (i.e. file
1274 notify) are processed when Emacs is started with -nw.
1275
a822acff
EZ
12762013-06-07 Eli Zaretskii <eliz@gnu.org>
1277
1278 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
1279 (ctagsfiles3): New variable, includes only *.m files.
1280 (TAGS): Use an explicit language name in the regular expressions,
1281 to avoid transformation of '/SOMETHING' by MSYS to
1282 'c:\MSYS\SOMETHING'.
1283
6c0a9ed1
RC
12842013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
1285
1286 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
1287
9ef6111b
EZ
12882013-06-06 Eli Zaretskii <eliz@gnu.org>
1289
1290 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
1291 still need to set the mouse pointer shape and activate help-echo.
1292 (Bug#14558)
1293
7d300d64
PE
12942013-06-06 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 A few porting etc. fixes for the new file monitor code.
1297 See the thread containing
1298 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
1299 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
1300 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
1301 (dir_monitor_callback, Fgfile_rm_watch):
1302 Use assq_no_quit instead of Fassoc, for speed.
1303 (dir_monitor_callback, Fgfile_rm_watch):
1304 eassert that the monitor is a fixnum.
1305 (dir_monitor_callback): No need for CDR_SAFE.
1306 Simplify building of lisp with alternative tails.
1307 (Fgfile_add_watch, Fgfile_rm_watch):
1308 Do not assume glib functions set errno reliably on failure.
1309 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
1310 and signal an error otherwise.
1311 (Fgfile_rm_watch): Prefer CONSP to !NILP.
1312 Use Fdelq instead of Fdelete, for speed.
1313
817ebfcf
EZ
13142013-06-05 Eli Zaretskii <eliz@gnu.org>
1315
1316 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
1317 don't insist on being invoked on a highlighted tool-bar button.
1318 Avoids losing tool-bar functionality when mouse-highlight is nil.
1319 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
1320 Don't highlight when mouse-highlight is nil.
1321 (note_mouse_highlight): When mouse-highlight is nil, don't return
1322 right away; instead, run tool-bar and mode-line highlight
1323 subroutine, clear any existing highlight, and revert the mouse
1324 pointer to its default shape. (Bug#14558)
1325
55577e7c
SM
13262013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1327
1328 * lisp.mk (lisp): Add prog-mode.el.
1329
f019a684
PE
13302013-06-05 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
1333 * process.c (dummy_handler): New function.
1334 (lib_child_handler): New static var.
1335 (handle_child_signal): Invoke it.
1336 (catch_child_signal): If a library has set up a signal handler,
1337 save it into lib_child_handler.
1338 (init_process_emacs): If using glib and not on Windows, tickle glib's
1339 child-handling code so that it initializes its private SIGCHLD handler.
1340 * syssignal.h (SA_SIGINFO): Default to 0.
1341 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
1342 31; it should no longer be needed now.
1343
90db8702
MA
13442013-06-05 Michael Albinus <michael.albinus@gmx.de>
1345
1346 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
1347
1348 * gfilenotify.c (globals_of_gfilenotify): New function.
1349 (syms_of_gfilenotify): Move global initialization there.
1350
1351 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
1352
bfa3acd6
SM
13532013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1354
1355 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
1356 * keyboard.c (menu_bar_items, tool_bar_items):
1357 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
1358 not override local keymaps any more.
1359
ba59bd80
EZ
13602013-06-04 Eli Zaretskii <eliz@gnu.org>
1361
1362 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
1363
7f203aa1
EZ
13642013-06-03 Eli Zaretskii <eliz@gnu.org>
1365
9337e206
EZ
1366 * w32console.c (initialize_w32_display): Return the dimensions of
1367 the console window via 2 additional arguments, not via the current
1368 frame. This avoids crashes due to overrunning the bounds of
1369 frame's decode_mode_spec_buffer, which is not resized following
1370 the change of the frame dimensions from the initial 10x10.
1371
1372 * w32term.h (w32_initialize_display_info): Adjust prototype.
1373
1374 * term.c (init_tty): Take dimensions of the frame from the values
1375 returned by initialize_w32_display.
1376
7f203aa1
EZ
1377 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
1378 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
1379 (LIBES): Add $(GFILENOTIFY_LIBS).
1380
1381 * w32inevt.c (handle_file_notifications): Add dummy implementation
1382 for !HAVE_W32NOTIFY.
1383
1384 * w32term.c: Wrap code with HAVE_W32NOTIFY.
1385
55a87246
JD
13862013-06-03 Jan Djärv <jan.h.d@swipnet.se>
1387
1388 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
1389
1390 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
1391
1392 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
1393
3d5ee10a
PE
13942013-06-03 Paul Eggert <eggert@cs.ucla.edu>
1395
1396 Fix minor problems found by static checking.
1397 * data.c (pure_write_error):
1398 Use xsignal2, not Fsignal, as Fsignal might return.
1399 * eval.c (set_backtrace_debug_on_exit): Now static.
1400 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
1401 No longer inline. EXTERN_INLINE is needed only for functions
1402 defined in .h files. Reindent function header as per GNU style.
1403 (backtrace_p, backtrace_top, backtrace_next):
1404 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
1405 compiler or linker. Add extern decls to pacify gcc -Wall.
1406 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1407 Now static.
1408 * frame.c (free_monitors): Define only on platforms that need it.
1409 * nsterm.m (ns_term_init):
1410 * process.c (catch_child_signal):
1411 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
1412 defined on all porting targets these days.
1413 * process.c, process.h (catch_child_signal):
1414 Make it extern only if NS_IMPL_GNUSTEP is defined.
1415
e2d8a6f0
EZ
14162013-06-03 Eli Zaretskii <eliz@gnu.org>
1417
1418 * w32.c (gettimeofday): Make the signature identical to prototype
1419 in nt/inc/sys/time.h.
1420
a8a7c5f6
SM
14212013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1422
1423 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
1424 .gdbinit.
1425
1426 * keyboard.c (safe_run_hooks_error): Improve error message.
1427
1428 * data.c (pure_write_error): Add `object' argument.
1429 * puresize.h (CHECK_IMPURE): Use it.
1430
c9628c79
MA
14312013-06-03 Michael Albinus <michael.albinus@gmx.de>
1432
1433 * Makefile.in (NOTIFY_OBJ): New variable.
1434 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
1435
1436 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
1437 Call syms_of_gfilenotify.
1438
1439 * gfilenotify.c: New file.
1440
1441 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
1442 and Qfile_w32notify.
1443 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
1444 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
1445
1446 * lisp.h: Declare syms_of_gfilenotify.
1447
1448 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
1449
2f592f95
SM
14502013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1451
1452 Merge the specpdl and backtrace stacks. Make the structure of the
1453 specpdl entries more obvious via a tagged union of structs.
1454 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
1455 (enum specbind_tag): New enum.
1456 (struct specbinding): Make it a tagged union of structs.
1457 Add a case for backtrace records.
1458 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
1459 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
1460 (backtrace_debug_on_exit): New accessors.
1461 (struct backtrace): Remove.
1462 (struct catchtag): Remove backlist field.
1463 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1464 Move to eval.c.
1465 (Flocal_variable_p): Speed up the common case where the binding is
1466 already loaded.
1467 * eval.c (backtrace_list): Remove.
1468 (set_specpdl_symbol, set_specpdl_old_value): Remove.
1469 (set_backtrace_args, set_backtrace_nargs)
1470 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
1471 (backtrace_next): New functions.
1472 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
1473 (unwind_to_catch, internal_lisp_condition_case)
1474 (internal_condition_case, internal_condition_case_1)
1475 (internal_condition_case_2, internal_condition_case_n): Don't bother
1476 with backtrace_list any more.
1477 (Fsignal): Adjust to new backtrace format.
1478 (grow_specpdl): Move up.
1479 (record_in_backtrace): New function.
1480 (eval_sub, Ffuncall): Use it.
1481 (apply_lambda): Adjust to new backtrace format.
1482 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
1483 data.c.
1484 (specbind): Adjust to new specpdl format. Simplify.
1485 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
1486 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
1487 backtrace format.
1488 (mark_backtrace): Remove.
1489 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
1490 * xdisp.c (redisplay_internal): Use record_in_backtrace.
1491 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
1492 Use mark_specpdl.
1493 * profiler.c (record_backtrace): Use get_backtrace.
1494 (handle_profiler_signal): Use backtrace_top_function.
1495 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
1496 accessor functions.
1497
c0342369
JD
14982013-06-02 Jan Djärv <jan.h.d@swipnet.se>
1499
1500 * process.h (catch_child_signal): Declare.
1501
1502 * process.c (catch_child_signal): New function.
1503 (init_process_emacs): Call it.
1504
1505 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
1506 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
1507 NS_IMPL_COCOA.
1508 (x_set_cursor_type): Remove declaration.
1509 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
1510 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
1511 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
1512 (ns_get_color): Use F suffix on float.
1513 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
1514 (ns_get_rgb_color): Remove.
1515 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
1516 (note_mouse_movement): x and y are CGFloat.
1517 (ns_draw_fringe_bitmap): Remove unused rowY.
1518 Change #if to COCOA && >= 10_6.
1519 (ns_draw_window_cursor): Remove unused overspill.
1520 (ns_draw_underwave): width and x are EamcsCGFloat.
1521 (ns_draw_box): thickness is CGFloat.
1522 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
1523 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
1524 if not in main thread.
1525 (ns_get_pending_menu_title, ns_check_menu_open)
1526 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
1527 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
1528 (sendFromMainThread:): New method.
1529 (changeFont:): size is CGFloat.
1530 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
1531 Disable warning about permanent text.
1532 (characterIndexForPoint:): Adjust return type depending on GNUStep
1533 version.
1534 (mouseDown:): delta is CGFloat.
1535 (updateFrameSize): Remove unised variable f.
1536 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
1537 Cast float to EmacsCGFloat.
1538 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
1539 also to -1 when restoring.
1540 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
1541 inside NS_IMPL_COCOA.
1542 (toggleFullScreen:): Put call to toggleFullScreen inside
1543 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
1544 (setPosition:portion:whole:): por is CGFloat.
1545 (getMouseMotionPart:window:x:y:): Add F suffix to float.
1546 (mouseDown:): Use CGFloat.
1547 (mouseDragged:): Remove unised variable edge.
1548 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
1549
1550 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
1551 of CGFloat differs.
1552 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
1553 when NS_IMPL_GNUSTEP.
1554 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
1555 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
1556 (EmacsToolbar): Add clearAll. Add tag argument to
1557 addDisplayItemWithImage.
1558 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
1559
1560 * nsselect.m (ns_get_local_selection): Remove unused variable type.
1561
1562 * nsmenu.m (ns_update_menubar): Make static.
1563 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
1564 (fillWithWidgetValue:): Add cast to SEL for setAction.
1565 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
1566 (update_frame_tool_bar): Update code for GNUStep.
1567 (clearAll): New method.
1568 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 1569 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 1570 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
1571 call to insertItemWithItemIdentifier.
1572 (validateVisibleItems): Fix indentation.
1573 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
1574 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
1575 UtilityWindow to aStyle, remove call to setStyleMask.
1576
1577 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
1578
1579 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
1580 (ns_charset_covers, ns_get_covering_families, nsfont_open):
1581 Use F suffix on floats.
1582 (ns_char_width): Returns CGFloat.
1583 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 1584 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
1585 DPSxshow.
1586 (ns_glyph_metrics): CGFloat instead of float.
1587
a0eb10b3
JB
1588 * nsfns.m (x_set_foreground_color, x_set_background_color):
1589 Use EmacsCGFloat.
1590 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
1591 remove unused variables.
1592 (Fns_read_file_name): Keep track if panel is for save.
1593 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 1594 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
1595 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
1596 Just return the input if GNUStep.
c0342369
JD
1597 (x_screen_planes): Remove.
1598 (Fxw_color_values): Use EmacsCGFloat
1599 (Fns_display_monitor_attributes_list): Only get screen number for
1600 Cocoa.
ef099a94 1601 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
1602 EmacsSavePanel.
1603 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
1604 ns_directory_from_panel.
1605
da9aff11
PE
16062013-06-01 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 * process.c (handle_child_signal): Also use WCONTINUED.
1609 This is so that list-processes doesn't mistakenly list the process
1610 as stopped, when the process has actually been continued and is
1611 now running.
1612
0e64479a
PE
16132013-05-31 Paul Eggert <eggert@cs.ucla.edu>
1614
fc186a96
PE
1615 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
1616 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
1617 not already configured.
1618
0e64479a
PE
1619 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
1620
38b787fa
EZ
16212013-05-29 Eli Zaretskii <eliz@gnu.org>
1622
1623 * Makefile.in (mostlyclean): Remove *.res files.
1624
22513e52
SM
16252013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
1626
1627 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
1628 a buffer (bug#8447).
1629
6ef3db10
EZ
16302013-05-27 Eli Zaretskii <eliz@gnu.org>
1631
1632 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
1633 display vector, and we backtrack, handle the case that the
1634 previous character position is also displayed from a display
1635 vector or covered by a display string or image. (Bug#14476)
1636
6799bb26
JD
16372013-05-25 Jan Djärv <jan.h.d@swipnet.se>
1638
1639 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
1640 (struct MonitorInfo, free_monitors): Remove.
1641 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
1642 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
1643 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
1644 Qframes, Qsource.
1645
1646 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
1647 (struct MonitorInfo, free_monitors): Remove.
1648 (ns_screen_name): Make static.
1649 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
1650 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
1651 Qframes, Qsource.
1652
1653 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
1654 (struct MonitorInfo): New struct.
1655 (free_monitors, make_monitor_attribute_list): Declare.
1656
22513e52
SM
1657 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1658 New Lisp_Object:s.
6799bb26
JD
1659 (free_monitors, make_monitor_attribute_list): New functions.
1660 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
1661 Qsource.
1662
38cd43eb
XF
16632013-05-25 Xue Fuqiao <xfq.free@gmail.com>
1664
1665 * callproc.c (call_process): Refine the doc string. (Bug#14045)
1666
2af0948d
SM
16672013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
1668
a7eb9b0f
SM
1669 * keyboard.c: Apply keyboard decoding only to events that come directly
1670 from the tty, not from unread-command-events (bug#14368).
1671 (read_event_from_main_queue): New function, extracted from read_char).
1672 (read_decoded_char): Remove.
1673 (read_decoded_event_from_main_queue): New function to replace it.
1674 (read_char): Use it.
1675 (read_key_sequence): Use read_char rather than read_decoded_char.
1676
2af0948d
SM
1677 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
1678
1413e9a5
BR
16792013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1680
1681 * casetab.c (init_casetab_once): Fix last change (bug#14424).
1682
e6d2f155
KH
16832013-05-22 Kenichi Handa <handa@gnu.org>
1684
1685 The following changes are to fix the setting of
1686 buffer-file-coding-system on, for instance, C-x RET c unix RET
1687 _FILE_OF_DOS_EOL_TYPE_ RET.
1688
1689 * coding.h (struct coding_system): New member detected_utf8_chars.
1690
1691 * coding.c (detect_coding_utf_8): Count characters and check EOL
1692 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
1693 BOM is there.
1694 (setup_coding_system): Do not initialize coding->head_ascii.
1695 (check_ascii): Do not set coding->eol_seen but update it. Do not
1696 call adjust_coding_eol_type here.
1413e9a5
BR
1697 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
1698 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
1699 of the found coding-system.
1700 (decode_coding_gap): Cancel previous change. Utilize the
1701 character numbers counted by detect_coding_utf_8. Fix detection
1702 of BOM for utf-8.
1703
ab56a6f4 17042013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
1705
1706 * search.c (looking_at_1): Only set last_thing_searched if the match
1707 changed the match-data (bug#14281).
1708
ecc3c6ed
DA
17092013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
1710
1711 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 1712 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
1713 (move_it_vertically_backward): Likewise.
1714
5ba8bf35
YM
17152013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1716
1717 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 1718 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
1719 (Fx_display_mm_width, Fx_display_mm_height):
1720 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 1721
91e8418b 1722 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 1723 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
1724 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
1725 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
1726 (Fx_display_backing_store, Fx_display_visual_class)
1727 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
1728 (Fx_display_grayscale_p, Fx_display_pixel_width)
1729 (Fx_display_pixel_height, Fx_display_planes)
1730 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
1731 (Fx_display_screens): Don't confuse X11 screens with NS screens.
1732 (Fx_display_mm_width, Fx_display_mm_height)
1733 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
1734 height for all physical monitors as in X11.
1735
fc30d803
SM
1736 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
1737 Return pixel width or height for all physical monitors as in X11.
91e8418b 1738
31ff141c
PE
17392013-05-18 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 Port --enable-gcc-warnings to clang.
1742 * bytecode.c (exec_byte_code):
1743 * regex.c:
1744 Redo diagnostic pragmas to pacify clang, too.
1745 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
1746 * editfns.c (Fencode_time):
1747 * fileio.c (file_accessible_directory_p):
1748 * font.c (font_unparse_xlfd):
1749 Use '&"string"[index]' instead of '"string" + (index)'.
1750 * undo.c (user_error): Remove; unused.
1751
df065a0b
EZ
17522013-05-16 Eli Zaretskii <eliz@gnu.org>
1753
04d360e7
EZ
1754 * insdel.c (insert_1_both): Document the arguments, instead of
1755 referring to insert_1, which no longer exists.
1756
5bb98290
EZ
1757 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
1758 some window, increment windows_or_buffers_changed, so that
1759 *Messages* display in that window is updated. (Bug#14408)
1760
df065a0b
EZ
1761 * w32.c: Include epaths.h.
1762 (init_environment): Use cmdproxy.exe without leading directories.
1763 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
1764 case.
1765 (gettimeofday): Adjust signature and return value to Posix
1766 expectations.
1767
1768 * unexw32.c (open_output_file): Delete the existing emacs.exe
1769 before creating it, to break the hard link to the versioned
1770 executable.
1771
1772 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
1773 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
1774 (FIRSTFILE_OBJ): New variables.
1775 (W32_RES): Rename to EMACSRES. All users changed.
1776 (base_obj): Use $(CM_OBJ).
1777 (ALLOBJS): Use $(FIRSTFILE_OBJ).
1778 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
1779 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
1780 $(W32_RES_LINK) before $(LIBES).
1781 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
1782
1aa8d505
SM
17832013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1784
6e911150
SM
1785 * makefile.w32-in (DOC): Use just "DOC".
1786
1787 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
1788
1aa8d505
SM
1789 * process.c: Export default filters and sentinels to Elisp.
1790 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
1791 New constants.
1792 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
1793 (Fset_process_sentinel, Fformat_network_address):
1794 Default to them instead of nil.
1795 (server_accept_connection): Sentinels can't be nil any more.
1796 (read_and_dispose_of_process_output): New function, extracted from
1797 read_process_output.
1798 (read_process_output): Use it; filters can't be nil.
1799 (Finternal_default_process_filter): New function, extracted from
1800 read_process_output.
1801 (exec_sentinel_unwind): Remove function.
1802 (exec_sentinel): Don't zilch sentinel while running.
1803 (status_notify): Sentinels can't be nil.
1804 (Finternal_default_process_sentinel): New function extracted from
1805 status_notify.
1806 (setup_process_coding_systems): Default filter is not nil any more.
1807 (syms_of_process): Export new Elisp functions and initialize
1808 new constants.
1809 * lisp.h (make_lisp_proc): New function.
1810
5ac2eb34
SM
18112013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1812
1813 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
1814
eda9c7d7
EZ
18152013-05-14 Eli Zaretskii <eliz@gnu.org>
1816
1817 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
1818 unless we know that the window w is a leaf window.
1819 Another attempt at solving bug#14062.
eda9c7d7 1820
8fdeaad5
JD
18212013-05-14 Jan Djärv <jan.h.d@swipnet.se>
1822
1823 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
1824 fdesc (Bug#14375).
1825
44aa9ee6
PE
18262013-05-12 Paul Eggert <eggert@cs.ucla.edu>
1827
1828 * image.c (gif_load): Check that subimages fit (Bug#14345).
1829
759fd763
SM
18302013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
1831
1832 * lread.c (skip_dyn_eof): New function.
1833 (read1): Use it to skip the end of a file in response to #@00.
1834
1835 * doc.c (get_doc_string): Slightly relax the sanity checking.
1836
4465bfb4
JD
18372013-05-09 Jan Djärv <jan.h.d@swipnet.se>
1838
1839 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
1840 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
1841 (MonitorInfo): New struct.
1842 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
1843 (Fns_display_monitor_attributes_list): New functions.
1844 (display-usable-bounds): Remove.
1845 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
1846 Qsource.
1847
7583e2a0
PE
18482013-05-09 Paul Eggert <eggert@cs.ucla.edu>
1849
1850 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
1851 (GTK_CHECK_VERSION): New macro, if not already defined.
1852 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
1853 replaced by GTK_CHECK_VERSION.
1854
ad75d77e
PE
18552013-05-08 Paul Eggert <eggert@cs.ucla.edu>
1856
1857 * xterm.h (GTK_PREREQ): New macro.
1858 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
1859 to use this macro instead, for consistency and clarity.
1860
07525f77
EZ
18612013-05-08 Eli Zaretskii <eliz@gnu.org>
1862
1863 * xdisp.c (row_for_charpos_p): New function, with code of
1864 cursor_row_p, but accepts an additional argument CHARPOS instead
1865 of using a hardcoded PT.
1866 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
1867 (row_containing_pos): Call row_for_charpos_p instead of partially
1868 doing the same. Fixes cursor positioning under longlines-mode
1869 when longlines-show-effect includes more than one newline, when
1870 moving the cursor vertically up.
1871
d901fc8d
JB
18722013-05-08 Juanma Barranquero <lekktu@gmail.com>
1873
1874 * makefile.w32-in (ACL_H): New macro.
1875 ($(BLD)/fileio.$(O)): Update dependencies.
1876
f269bc61
PE
18772013-05-07 Paul Eggert <eggert@cs.ucla.edu>
1878
e7b41c4c 1879 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
1880 * Makefile.in (LIB_ACL): New macro.
1881 (LIBACL_LIBS): Remove.
1882 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
1883 * fileio.c: Include <acl.h>.
1884 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
1885 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
1886 !acl_errno_valid.
1887 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
1888 it ourselves.
1889
f269bc61
PE
1890 * unexelf.c: Don't assume ElfW (Half) fits in int.
1891 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
1892 when dealing with ElfW (Half) values, since they can exceed 2**31
1893 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
1894 (entry_address): Omit unused NUM arg. All uses changed.
1895
a261c53e
JL
18962013-05-07 Juri Linkov <juri@jurta.org>
1897
1898 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
1899 to the string converted from number with `Fnumber_to_string'.
1900 (Bug#14254)
1901
2b66427d
PE
19022013-05-07 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
1905 This fixes a problem introduced by my previous change.
1906
15acfe41
GM
19072013-05-07 Glenn Morris <rgm@gnu.org>
1908
1909 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
1910
5ea03bf5
JD
19112013-05-07 Jan Djärv <jan.h.d@swipnet.se>
1912
1913 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
1914
e0c9d565
PE
19152013-05-07 Paul Eggert <eggert@cs.ucla.edu>
1916
1917 Static checking by GCC 4.8.0.
1918 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
1919 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
1920 (x_get_monitor_attributes_fallback)
1921 (x_get_monitor_attributes_xinerama)
1922 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
1923 Define only if USE_GTK.
1924 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
1925 (x_get_monitor_attributes_fallback): Omit unused locals.
1926 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
1927 Use double, not float, to avoid mixed-mode floating point arithmetic.
1928
4e3f9230
YM
19292013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1930 Jan Djärv <jan.h.d@swipnet.se>
1931
1932 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
1933 (XINERAMA_CFLAGS): New macros.
1934 (ALL_CFLAGS, LIBES): Use them.
1935
1936 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
1937 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
1938 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
1939 (syms_of_xfns): DEFSYM them.
1940 (struct MonitorInfo): New struct.
1941 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
1942 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
1943 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
1944 (x_get_monitor_attributes_xinerama): New functions.
1945 (Fx_display_monitor_attributes_list): New primitive.
1946 (syms_of_xfns): Defsubr it.
1947
1948 * xterm.h (x_display_info): Add Xatom_net_workarea and
1949 Xatom_net_current_desktop.
1950
1951 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
1952 and dpyinfo->Xatom_net_current_desktop.
1953
05839b6a
EZ
19542013-05-06 Eli Zaretskii <eliz@gnu.org>
1955
1956 * xdisp.c (pos_visible_p): Use the special code for finding the
1957 beginning of a display property or overlay for any "replacing"
1958 display property, not just for display strings. This solves
1959 incorrect reporting of position by posn-at-point. (Bug#14241)
1960
dc4a2ee0
PE
19612013-05-06 Paul Eggert <eggert@cs.ucla.edu>
1962
5ee94506
PE
1963 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
1964 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
1965 Verify that ElfW (Half) fits in int.
1966 (fatal): Use same signature as lisp.h.
1967 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
1968 configure and build with -DUNEXELF_DEBUG without worrying about
1969 other modules that use DEBUG.
1970 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
1971 possibly-wide integers now uses it instead of plain fprintf.
1972 (entry_address): New function, which avoids problems with 32-bit
1973 overflow on 64-bit hosts.
1974 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
1975 (round_up): Don't assume the remainder fits in int.
1976 (find_section): Use bool for boolean. Simplify debug code.
1977 (unexec): Don't assume file sizes fit in int or size_t.
1978 Omit unnecessary trailing newline in 'fatal' format.
1979 Use strerror rather than outputting decimal error number.
1980 Remove unused code when emacs is not defined;
1981 this file relies on Emacs now.
1982 Don't assume e_phnum and e_shnum are positive.
1983
dc4a2ee0
PE
1984 * regex.c: Fix problems when DEBUG is defined.
1985 (extract_number, extract_number_and_incr): Define regardless of
1986 whether DEBUG is defined; that's simpler and makes the code less
1987 likely to go stale in the normal case when DEBUG is not defined.
1988 Return int rather than taking an int * arg. All callers changed.
1989 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
1990 Remove, replacing with ...
1991 (DEBUG_PRINT): New macro. All callers changed.
1992 (DEBUG_COMPILES_ARGUMENTS): New macro.
1993 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
1994 (print_compiled_pattern, print_double_string) [DEBUG]:
1995 Use prototype rather than old-style definition.
1996 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
1997 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
1998 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
1999 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2000 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2001 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2002 This matters only when DEBUG is defined.
2003
14c7ed05
EZ
20042013-05-05 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xdisp.c (set_iterator_to_next): Set the
2007 ignore_overlay_strings_at_pos_p flag only if we are _really_
2008 iterating over an overlay string, as indicated by the
2009 current.overlay_string_index member. (Bug#14306)
2010
e6076b1b
JD
20112013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2012
2013 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2014 to where it is used, to avoid autorelease issues (Bug#14050).
2015
cbee2131
PE
20162013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2019 * fileio.c (syms_of_fileio): Implement this.
2020 * filelock.c (create_lock_file): If symbolic links don't work, so
2021 we use a regular file as a lock file, do not fsync the lock file;
2022 it's not needed.
2023
30c7e542
SM
20242013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2025
2026 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2027 (syms_of_minibuf): Adjust accodingly.
2028 * lread.c (Fread):
2029 * callint.c (Fcall_interactively): Adjust calls accordingly.
2030
5bebd186
EZ
20312013-05-04 Eli Zaretskii <eliz@gnu.org>
2032
2033 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2034 w->contents is a buffer before computing everything else.
2035 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2036
2037 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2038 assertion violations. (Bug#14062)
2039
0fb0a4f3
DR
20402013-05-01 David Reitter <david.reitter@gmail.com>
2041
2042 * nsfns.m (ns_tooltip): Initialize.
2043
9e63b4a5
EZ
20442013-04-28 Eli Zaretskii <eliz@gnu.org>
2045
2046 * coding.c (decode_coding_gap): Don't remove the character before
2047 a newline unless it's a CR character. (Bug#14287)
2048
ad60824e
DN
20492013-04-28 Dan Nicolaescu <dann@gnu.org>
2050
2051 * dispextern.h (struct face): Move enum face_underline_type
2052 earlier so that bitfields can be in the same word.
2053
edbdcec0
JD
20542013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2055
2056 * nsfns.m (handlePanelKeys): New function.
2057 (EmacsOpenPanel:performKeyEquivalent:)
2058 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
2059 arrows/function/control and copy/paste keys (Bug#14296).
2060
0208ede7
JL
20612013-04-27 Juri Linkov <juri@jurta.org>
2062
2063 * callint.c (Fcall_interactively): Call `Qread_number' for
2064 interactive code letter `n' instead of using duplicate code.
2065 (Bug#14254)
2066
b8dd59f7
PE
20672013-04-27 Paul Eggert <eggert@cs.ucla.edu>
2068
2069 * systime.h (make_timeval): Declare as 'const'.
2070
8bd722db
KH
20712013-04-27 Kenichi Handa <handa@gnu.org>
2072
2073 * font.c (font_open_entity): Always open a font of manageable
2074 size.
2075
13d0e56f 20762013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 2077
f780d632
PE
2078 Port better to AIX (Bug#14258).
2079 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
2080 to pacify AIX xlc.
2081
ec509856
KH
20822013-04-24 Kenichi Handa <handa@gnu.org>
2083
2084 * coding.c (decode_coding_iso_2022): When an invalid escape
2085 sequence is encountered, reset the invocation and designation
2086 status to the safest one.
2087
84fc48e5
PE
20882013-04-22 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
2091 Without this fix, "make distclean" leaves stamp-h1 behind.
2092
806bda47
EC
20932013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
2094
2095 * w32fns.c (w32_fullscreen_rect): New function to compute the
2096 window rectangle for the given fullscreen mode.
2097 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
2098 longer tunes the window size. This keeps the window's edges flush
2099 with the screen and allows the taskbar to hide itself in fullboth.
2100
2101 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
2102 window decorations and uses the entire screen.
2103
2104 * w32term.h (w32_fullscreen_rect) Add prototype.
2105 (struct w32_output): Replace normal_width, normal_height,
2106 normal_top, and normal_left members with a single normal_placement
2107 struct.
2108 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
2109 Remove macros.
2110 (FRAME_NORMAL_PLACEMENT): New macro.
2111
9cc2810b
JB
21122013-04-16 Juanma Barranquero <lekktu@gmail.com>
2113
2114 * minibuf.c (Ftest_completion): Silence compiler warning.
2115
fd16b54c
EZ
21162013-04-15 Eli Zaretskii <eliz@gnu.org>
2117
2118 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 2119 bug#14062.
fd16b54c
EZ
2120
2121 * frame.h (WINDOW_FRAME): Protect macro and its argument with
2122 parentheses.
2123
2124 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
2125 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
2126 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
2127 parentheses where appropriate.
2128
9e3379a0
PE
21292013-04-14 Paul Eggert <eggert@cs.ucla.edu>
2130
2131 * keyboard.c (timer_start_idle): Remove no-longer-used local.
2132
ddd6b685
EZ
21332013-04-14 Eli Zaretskii <eliz@gnu.org>
2134
2135 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
2136 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
2137 Mention in the doc string that setting these variables takes
2138 effect only after a call to set-window-buffer. (Bug#14200)
2139
29b79ba1
EZ
21402013-04-13 Eli Zaretskii <eliz@gnu.org>
2141
2142 * indent.c (Fvertical_motion): Don't consider display strings on
2143 overlay strings as display strings on the buffer position we
2144 started from. This prevents vertical cursor motion from jumping
2145 more than one line when there's an overlay string with a display
2146 property at end of line.
2147 Reported by Karl Chen <Karl.Chen@quarl.org> in
2148 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
2149
562c6ee9
SM
21502013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
2151
2152 * window.c (select_window): `record_buffer' even if window is
2153 already selected (bug#14191).
2154
fcc1fe85
EZ
21552013-04-11 Eli Zaretskii <eliz@gnu.org>
2156
2157 * window.c (Fwindow_end): Test more flags, including the buffer's
2158 last_overlay_modified flag, to determine whether the window's
2159 display is really up-to-date. Prevents the function from
2160 returning a stale value. (Bug#14170)
2161 (Fwindow_line_height): Fix the test for up-to-date-ness of the
2162 current matrix.
2163
f009190a
EZ
21642013-04-10 Eli Zaretskii <eliz@gnu.org>
2165
2166 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
2167 garbaged only if it is not already the top frame on its TTY.
2168 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
2169 there are GUI frames open in the same session. (Bug#13864)
2170
78ce603d
SM
21712013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
2172
2173 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
2174 of marking the idle timers directly.
2175
a8036e40
SM
21762013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
2177
2178 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
2179 tables (bug#14054).
2180
7ffe7ef6
SM
21812013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
2182
2183 * window.c (select_window): Don't record_buffer while the invariant is
2184 temporarily broken (bug#14161).
2185
2186 * fns.c (Fdelq): Don't assume !NILP => CONSP.
2187
7d9f6883
EZ
21882013-04-07 Eli Zaretskii <eliz@gnu.org>
2189
2190 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
2191
5406cfd9
RF
21922013-04-07 Romain Francoise <romain@orebokech.com>
2193
2194 Ignore additional platform-specific ACL errors (Bug#13702).
2195 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
2196 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
2197
95c0e83b
JD
21982013-03-31 Jan Djärv <jan.h.d@swipnet.se>
2199
2200 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
2201 f->output_data.ns.
2202
876da980
PE
22032013-04-07 Paul Eggert <eggert@cs.ucla.edu>
2204
2205 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
2206 This bug was introduced by my 2013-02-25 change that simplified
2207 data_start configuration. Without this change, on GNU/Linux
2208 an Emacs configured with --enable-profiling fails immediately
2209 due to a profiler signal.
2210 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
2211 with these flags. On platforms where special flags are needed
2212 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
2213 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
2214 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
2215
7452b7bd
DA
22162013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
2217
2218 Get rid of some platform-specific functions examining window
2219 system and its capabilities. This is a partial rework of the
2220 2013-04-05 change.
2221 * lisp.h (have_menus_p): Remove prototype. This function is
2222 replaced with platform-independent window_system_available.
2223 (check_window_system): Move to...
2224 * frame.h (decode_window_system_frame, window_system_available):
2225 ...here, add new prototypes.
2226 * frame.c (window_system_available, decode_window_system_frame):
2227 New functions.
2228 (check_window_system): Platform-independent now.
2229 * xterm.h (x_in_use): Remove declaration.
2230 (check_x_frame):
2231 * w32term.h (check_x_frame):
2232 * nsterm.h (check_x_frame): Remove prototypes. This function
2233 is replaced with platform-independent decode_window_system_frame.
2234 * msdos.c (have_menus_p): Remove.
2235 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
2236 Remove platform-specific functions. Use check_window_system,
2237 decode_window_system_frame and check_ns_display_info where
2238 appropriate. Minor style and comment tweaks.
2239 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
2240 (check_x_frame): Likewise.
2241 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
2242 Likewise.
2243 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
2244 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
2245 * xmenu.c, xselect.c: All related users changed.
2246
251e9147
KH
22472013-04-03 Kenichi Handa <handa@gnu.org>
2248
2249 The following changes is to optimize the code for reading UTF-8
2250 files.
2251
562c6ee9 2252 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
2253 changed. Check EOL format. Do not call adjust_coding_eol_type
2254 here.
2255 (check_utf_8): New function.
2256 (adjust_coding_eol_type): Do nothing if already adjusted.
2257 (detect_coding): Compare the return value of check_ascii with
2258 coding->src_bytes. Call adjust_coding_eol_type if necessary.
2259 (decode_coding_gap): Optimize for valid UTF-8.
2260
8bc369d4
KH
22612013-03-21 Kenichi Handa <handa@gnu.org>
2262
2263 * coding.c (syms_of_coding): Cancel previous change.
2264
2265 * insdel.c (insert_from_gap): Fix previous change.
2266
73931ad1
DA
22672013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
2268
2269 Consistently use platform-specific function to detect window system.
2270 * lisp.h (check_window_system): New prototype. This function is
2271 going to replace check_x, check_w32 and check_ns.
2272 (have_menus_p): Mention msdos.c in comment.
2273 * fontset.c (check_window_system_func): Remove. Adjust all users.
2274 * fontset.h (check_window_system_func): Remove prototype.
2275 * nsterm.h (check_ns):
2276 * xterm.h (check_x):
2277 * w32term.h (check_w32): Likewise.
2278 * menu.c (Fx_popup_menu): Use check_window_system.
2279 * msdos.c (check_window_system): Define for MS-DOS.
2280 * nsfns.m (check_window_system): Define for NS. Adjust all users.
2281 * w32fns.c (check_window_system): Likewise for MS-Windows.
2282 * xfns.c (check_window_system): Likewise for X.
2283 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
2284 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
2285
7216e43b
PE
22862013-04-02 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 Prefer < to > in range checks such as 0 <= i && i < N.
2289 This makes it easier to visualize quantities on a number line.
2290 This patch doesn't apply to all such range checks,
2291 only to the range checks affected by the 2013-03-24 change.
2292 This patch reverts most of the 2013-03-24 change.
2293 * alloc.c (xpalloc, Fgarbage_collect):
2294 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
2295 * character.c (string_escape_byte8):
2296 * charset.c (read_hex):
2297 * data.c (cons_to_unsigned):
2298 * dispnew.c (update_frame_1):
2299 * doc.c (Fsubstitute_command_keys):
2300 * doprnt.c (doprnt):
2301 * editfns.c (hi_time, decode_time_components):
2302 * fileio.c (file_offset):
2303 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2304 * font.c (font_intern_prop):
2305 * frame.c (x_set_alpha):
2306 * gtkutil.c (get_utf8_string):
2307 * indent.c (check_display_width):
2308 * keymap.c (Fkey_description):
2309 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
2310 * lread.c (read1):
2311 * minibuf.c (read_minibuf_noninteractive):
2312 * process.c (wait_reading_process_output):
2313 * search.c (Freplace_match):
2314 * window.c (get_phys_cursor_glyph):
2315 * xdisp.c (redisplay_internal):
2316 * xsmfns.c (smc_save_yourself_CB):
2317 Prefer < to > for range checks.
2318 * dispnew.c (sit_for): Don't mishandle NaNs.
2319 This fixes a bug introduced in the 2013-03-24 change.
2320 * editfns.c (decode_time_components): Don't hoist comparison.
2321 This fixes another bug introduced in the 2013-03-24 change.
2322
92759988
DA
23232013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
2324
2325 * frame.h (struct frame): Drop scroll_bottom_vpos
2326 member becaue all real users are dead long ago.
2327 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
2328 * xdisp.c (redisplay_internal): Adjust user.
2329
9a1971bb
GM
23302013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
2331
f38ab167
JD
2332 * nsmenu.m (showAtX:Y:for:): setLevel to
2333 NSPopUpMenuWindowLevel (Bug#13998).
2334
6d01f1fe
JD
23352013-03-30 Jan Djärv <jan.h.d@swipnet.se>
2336
2337 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
2338 (ns_check_pending_open_menu): Declare.
2339
2340 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
2341 (x_activate_menubar): Update the menu with title that matches
2342 ns_get_pending_menu_title, and call
2343 ns_check_pending_openmenu (Bug#12698).
2344 (menuWillOpen:): New method.
2345 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
2346
2347 * nsterm.m (menu_will_open_state, menu_mouse_point)
2348 (menu_pending_title): New varaibles.
2349 (ns_get_pending_menu_title, ns_check_menu_open)
2350 (ns_check_pending_open_menu): New functions.
2351
781f4782
DA
23522013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
2353
2354 * indent.c (current_column_bol_cache): Remove leftover which is not
2355 used in Fmove_to_column any more.
2356 (current_column, scan_for_column): Adjust users.
2357 * keyboard.c (last_point_position_buffer, last_point_position_window):
2358 Remove leftovers which are not used for recording undo any more.
2359 (command_loop_1, syms_of_keyboard): Adjust users.
2360 * xdisp.c (last_max_ascent): Remove leftover which is not used in
2361 redisplay_window any more.
2362 (move_it_to): Adjust user.
2363
1921c31b
JB
23642013-03-29 Juanma Barranquero <lekktu@gmail.com>
2365
2366 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
2367 Update dependencies.
2368
717b8bcd
SM
23692013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2370
2371 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
2372 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
2373 forward references.
2374
e74aeda8
DA
23752013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2376
2377 * window.h (struct window): Replace hchild, vchild and buffer slots
2378 with the only contents slot. This is possible because each valid
2379 window may have either the child window (in vertical or horizontal
2380 combination) or buffer to display (for the leaf window). Using that,
2381 a lof of operations to traverse and/or change window hierarchies may
2382 be simplified. New member horizontal is used to distinguish between
2383 horizontal and vertical combinations of internal windows.
2384 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
2385 (WINDOW_VERTICAL_COMBINATION_P): New macros.
2386 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
2387 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
2388 Use contents slot, not buffer, where appropriate.
2389 (wset_combination): New function.
2390 (wset_buffer): Add eassert.
2391 (Fframe_first_window): Simplify the loop reaching first window.
2392 (Fwindow_buffer): Use WINDOW_LEAF_P.
2393 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
2394 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
2395 (unshow_buffer): Convert initial debugging check to eassert.
2396 (replace_window, recombine_windows, Fdelete_other_windows_internal)
2397 (make_parent_window, window_resize_check, window_resize_apply)
2398 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
2399 (Fset_window_configuration, delete_all_child_windows, save_window_save):
2400 Adjust to match struct window changes.
2401 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
2402 (mark_window_cursors_off, count_windows, get_leaf_windows)
2403 (foreach_window_1): Simplify the loop.
2404 * alloc.c (mark_object): Do not check for the leaf window because
2405 internal windows has no glyph matrices anyway.
2406 * dispnew.c (clear_window_matrices, showing_window_margins_p)
2407 (allocate_matrices_for_window_redisplay, fake_current_matrices)
2408 (allocate_matrices_for_frame_redisplay, free_window_matrices)
2409 (build_frame_matrix_from_window_tree, mirror_make_current)
2410 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
2411 (update_window_tree, set_window_update_flags): Simplify the loop.
2412 (sync_window_with_frame_matrix_rows): Enforce live window.
2413 Use contents slot, not buffer, where appropriate.
2414 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
2415 and WINDOW_HORIZONTAL_COMBINATION_P.
2416 (make_frame_visible_1): Simplify the loop.
2417 Use contents slot, not buffer, where appropriate.
2418 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
2419 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
2420 (expose_window_tree): Likewise.
2421 Use contents slot, not buffer, where appropriate.
2422 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
2423 to avoid deleted windows. Use contents slot instead of buffer.
2424 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
2425 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
2426 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
2427 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
2428
121ab1cd
EZ
24292013-03-28 Eli Zaretskii <eliz@gnu.org>
2430
ef454cf7
EZ
2431 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
2432 identify the reasons for assertion violations in bug#14062 and
2433 similar ones.
21e930f8
EZ
2434 (Fx_show_tip): Fix compilation error under
2435 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 2436
121ab1cd
EZ
2437 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
2438 Reported by <rzl24ozi@gmail.com>.
2439
5c89ca24
DA
24402013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2441
2442 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
2443 start marker...
562c6ee9
SM
2444 (unwind_with_echo_area_buffer): ...to restore it here.
2445 This is needed to ensure that...
5c89ca24
DA
2446 (redisplay_window): ...both window markers are valid here,
2447 which is verified by eassert.
2448 * editfns.c (save_excursion_save): Do not assume that
2449 selected_window always displays the buffer.
c7f53895
DA
2450 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
2451 Fix comment.
5c89ca24 2452
f557c1b1
SM
24532013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
2454
2455 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
2456 the upcase table.
2457
40693bba 24582013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
2459
2460 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
2461
c86f791f
EZ
24622013-03-27 Eli Zaretskii <eliz@gnu.org>
2463
2464 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
2465 since MinGW's w32api headers do. This avoids compiler warnings.
2466
2467 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
2468 if already defined.
2469
c6e72e17
EZ
24702013-03-26 Eli Zaretskii <eliz@gnu.org>
2471
2472 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
2473
54e95010
JD
24742013-03-26 Jan Djärv <jan.h.d@swipnet.se>
2475
2476 * gtkutil.c (style_changed_cb): Check if frame is live and an
2477 X frame (Bug#14038).
2478
b88b62de
EZ
24792013-03-26 Eli Zaretskii <eliz@gnu.org>
2480
a18d7de6
EZ
2481 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
2482 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
2483 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
2484 MinGW64.
8f5e14c8
EZ
2485 Move inclusion of time.h before sys/time.h, so that MinGW64 could
2486 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 2487
b88b62de
EZ
2488 Fix incompatibilities between MinGW.org and MinGW64 headers.
2489 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
2490
2491 * w32.c (REPARSE_DATA_BUFFER): Guard with
2492 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
2493
c074e458
JD
24942013-03-25 Jan Djärv <jan.h.d@swipnet.se>
2495
2496 * xterm.c: Include X11/XKBlib.h
2497 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
2498
908589fd
AS
24992013-03-24 Andreas Schwab <schwab@linux-m68k.org>
2500
2501 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
2502 written backwards.
2503 * blockinput.h (input_blocked_p): Likewise.
2504 * bytecode.c (exec_byte_code): Likewise.
2505 * callproc.c (call_process_kill, call_process_cleanup)
2506 (Fcall_process): Likewise.
2507 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
2508 (Fccl_execute_on_string): Likewise.
2509 * character.c (string_escape_byte8): Likewise.
2510 * charset.c (read_hex): Likewise.
2511 * cm.c (calccost): Likewise.
2512 * data.c (cons_to_unsigned): Likewise.
2513 * dired.c (directory_files_internal, file_name_completion):
2514 Likewise.
2515 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
2516 (sit_for): Likewise.
2517 * doc.c (Fsubstitute_command_keys): Likewise.
2518 * doprnt.c (doprnt): Likewise.
2519 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
2520 * emacsgtkfixed.c: Likewise.
2521 * fileio.c (file_offset, Fwrite_region): Likewise.
2522 * floatfns.c (Fexpt, fmod_float): Likewise.
2523 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2524 Likewise.
2525 * font.c (font_intern_prop): Likewise.
2526 * frame.c (x_set_alpha): Likewise.
2527 * gtkutil.c (get_utf8_string): Likewise.
2528 * indent.c (check_display_width): Likewise.
2529 * intervals.c (create_root_interval, rotate_right, rotate_left)
2530 (split_interval_right, split_interval_left)
2531 (adjust_intervals_for_insertion, delete_node)
2532 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2533 (merge_interval_right, merge_interval_left, copy_intervals)
2534 (set_intervals_multibyte_1): Likewise.
2535 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
2536 * keymap.c (Fkey_description): Likewise.
2537 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
2538 * lread.c (openp, read_integer, read1, string_to_number):
2539 Likewise.
2540 * menu.c (ensure_menu_items): Likewise.
2541 * minibuf.c (read_minibuf_noninteractive): Likewise.
2542 * print.c (printchar, strout): Likewise.
2543 * process.c (create_process, Faccept_process_output)
2544 (wait_reading_process_output, read_process_output, send_process)
2545 (wait_reading_process_output): Likewise.
2546 * profiler.c (make_log, handle_profiler_signal): Likewise.
2547 * regex.c (re_exec): Likewise.
2548 * regex.h: Likewise.
2549 * search.c (looking_at_1, Freplace_match): Likewise.
2550 * sysdep.c (get_child_status, procfs_ttyname)
2551 (procfs_get_total_memory): Likewise.
2552 * systime.h (EMACS_TIME_VALID_P): Likewise.
2553 * term.c (dissociate_if_controlling_tty): Likewise.
2554 * window.c (get_phys_cursor_glyph): Likewise.
2555 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
2556 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
2557 Likewise.
2558 * xfns.c (Fx_window_property): Likewise.
2559 * xmenu.c (set_frame_menubar): Likewise.
2560 * xselect.c (x_get_window_property, x_handle_dnd_message):
2561 Likewise.
2562 * xsmfns.c (smc_save_yourself_CB): Likewise.
2563 * xterm.c (x_scroll_bar_set_handle): Likewise.
2564
2bf7d27a
DA
25652013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
2566
2567 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
2568 to be optional or nil. Adjust comment and convert it to docstring.
2569 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
2570 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
2571
a9ebfa0b
PE
25722013-03-24 Paul Eggert <eggert@cs.ucla.edu>
2573
2574 Static checking by GCC 4.8-20130319.
2575 * image.c (gif_load): Assume pass < 3 to pacify GCC.
2576 * process.c (Fset_process_datagram_address)
2577 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
2578 * xdisp.c (get_char_face_and_encoding):
2579 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
2580 (get_glyph_face_and_encoding): Prepare face before possibly using it.
2581 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
2582
4f3576ee
KB
25832013-03-24 Ken Brown <kbrown@cornell.edu>
2584
789b5e9a
KB
2585 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
2586 fix compilation on 64-bit Cygwin, where underscores are not
2587 automatically prepended.
2588
4f3576ee
KB
2589 * w32term.c (w32_initialize): Silence compiler warning.
2590
b5b7745f
EZ
25912013-03-23 Eli Zaretskii <eliz@gnu.org>
2592
cdc0d0bd
EZ
2593 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
2594 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
2595 variables, to save and restore frame dimensions.
2596 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
2597 after returning from a 'fullscreen' configuration.
2598 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
2599 to avoid races between the main thread and the input thread.
2600
2601 * w32term.h (struct w32_output): New members normal_width,
2602 normal_height, normal_top, normal_left, and prev_fsmode.
2603 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
2604 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
2605 members of a frame.
2606
b5b7745f
EZ
2607 * w32term.c (w32fullscreen_hook): Record last value of the frame's
2608 'fullscreen' parameter. Always record previous width and height
2609 of the frame, except when switching out of maximized modes, so
2610 that they could be restored correctly, instead of resetting to the
2611 default frame dimensions. Send SC_RESTORE command to the frame,
2612 unless we are going to send SC_MAXIMIZE, to restore the frame
2613 resize hints in the mouse pointer shown by the window manager.
2614 (Bug#14032)
2615
2616 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
2617
2618 * lisp.h (get_frame_param): Adjust conditions for prototype
2619 declaration.
2620
a3454eed
KB
26212013-03-22 Ken Brown <kbrown@cornell.edu>
2622
2623 * unexcw.c: Drop unneeded inclusion of w32common.h.
2624 (report_sheap_usage): Declare.
2625 (read_exe_header): Add magic numbers for x86_64.
2626 (fixup_executable): Fix printf format specifier for unsigned long
2627 argument.
2628
5a49b79c
DA
26292013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
2630
2631 * frame.h (struct frame): Put menu_bar_window under #ifdef
2632 because this member is not needed when X toolkit is in use.
2633 (fset_menu_bar_window):
2634 * dispnew.c (clear_current_matrices, clear_desired_matrices)
2635 (free_glyphs, update_frame):
2636 * xdisp.c (expose_frame): Likewise.
2637 (display_menu_bar): Likewise. Remove redundant eassert.
2638 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
2639 toolkit is in use.
2640
d6723bf7
PE
26412013-03-21 Paul Eggert <eggert@cs.ucla.edu>
2642
7b1123d8
PE
2643 Use functions and constants to manipulate Lisp_Save_Value objects.
2644 This replaces code that used macros and strings and token-pasting.
2645 The change makes the C source a bit easier to follow,
2646 and shrinks the Emacs executable a bit.
2647 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
2648 (make_save_value): Change 1st arg from string to enum. All callers
2649 changed.
2650 (INTX): Remove.
2651 (mark_object): Use if, not #if, for GC_MARK_STACK.
2652 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
2653 (XSAVE_OBJECT): Now functions, not macros.
2654 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
2655 the constant was never used.
2656 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
2657 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
2658 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
2659 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
2660 New constants.
2661 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
2662 type3 with a single member save_type. All uses changed.
2663 (save_type, set_save_pointer, set_save_integer): New functions.
2664 * print.c (PRINTX): Remove.
2665
d6723bf7
PE
2666 * alloc.c: Remove redundant static declarations.
2667
5f24fa51
DA
26682013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
2669
2670 * window.h (struct window): Convert left_col, top_line, total_lines
2671 and total_cols from Lisp_Objects to integers. Adjust comments.
2672 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
2673 Remove.
2674 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
2675 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
2676 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
2677 Adjust users where appropriate.
2678
42143acd
DA
26792013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
2680
2681 * frame.h (struct frame): Drop resx and resy because the same data is
2682 available from window system-specific output context. Adjust users.
562c6ee9
SM
2683 (default_pixels_per_inch_x, default_pixels_per_inch_y):
2684 New functions to provide defaults when no window system available.
42143acd 2685 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 2686 (NUMVAL): Move from xdisp.c.
42143acd
DA
2687 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
2688 (Ffont_face_attributes, Fopen_font):
2689 * image.c (gs_load):
2690 * w32font.c (fill_in_logfont):
2691 * xdisp.c (calc_pixel_width_or_height):
2692 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
2693 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
2694
c0a17406
KH
26952013-03-20 Kenichi Handa <handa@gnu.org>
2696
2697 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
2698 to 1 (temporary workaround until a bug related to ASCII
2699 optimization is fixed).
2700
095d384d
DA
27012013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
2702
2703 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
2704 Signal error if window is not internal. Adjust docstring.
2705 (delete_all_child_windows): Use combination_limit to save the buffer.
2706 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
2707 * print.c (syms_of_print): Initialize debugging output not here...
2708 (init_print_once): ...but in a new function here.
2709 * lisp.h (init_print_once): Add prototype.
2710 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 2711
748fa866
DA
27122013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
2713
2714 * window.c (window_resize_check, window_resize_apply)
2715 (window_from_coordinates, recombine_windows, set_window_buffer)
2716 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
2717 (Fsplit_window_internal, Fdelete_window_internal)
2718 (freeze_window_starts): Use bool for booleans.
2719 * window.h (window_frame_coordinates, resize_frame_windows)
2720 (freeze_window_starts, set_window_buffer): Adjust prototypes.
2721
81519fd2
SM
27222013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
2723
2724 * dispnew.c (bitch_at_user): Use `user-error'.
2725
6db423a9
KB
27262013-03-17 Ken Brown <kbrown@cornell.edu>
2727
2728 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
2729 as return type of image_background. (Bug#13981)
2730 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
2731
8f2906f5
JD
27322013-03-16 Jan Djärv <jan.h.d@swipnet.se>
2733
960ce480 2734 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 2735 (ns_select): Don't return with result uninitialized.
960ce480 2736
8f2906f5
JD
2737 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
2738 and getDirectory.
2739
81519fd2
SM
2740 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
2741 New functions.
8f2906f5
JD
2742 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
2743 directories. If filename is nil, get directory name (Bug#13932).
2744 Use getFilename and getDirectory.
2745 (getFilename, getDirectory): New methods for EmacsSavePanel and
2746 EmacsOpenPanel.
2747 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
2748
cded56c1
PE
27492013-03-15 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 * coding.c (decode_coding_gap): Fix typo caught by static checking.
2752
251e9147 27532013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
2754
2755 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
2756 (adjust_after_replace): Make it back to static. Delete the third
2757 arg text_at_gap_tail. Cancel the code for handling it.
2758
2759 * coding.h (struct coding_system): New member eol_seen.
2760
2761 * coding.c (detect_ascii): New function.
2762 (detect_coding): Set coding->head_ascii and coding->eol_seen only
2763 when the source bytes are actually scanned. On detecting for
2764 coding_category_utf_8_auto, call detect_ascii instead of scanning
2765 source bytes directly.
2766 (produce_chars): Call insert_from_gap with the new arg 0.
2767 (encode_coding): Likewise.
2768 (decode_coding_gap): Control ASCII optimization by the variable
2769 disable_ascii_optimization instead of #ifndef .. #endif.
2770 Deccode EOL format according to coding->eol_seen.
2771 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
2772 variable.
2773
8a44e6d1
KH
2774 * lisp.h (adjust_after_replace): Cancel externing it.
2775 (insert_from_gap): Adjust prototype.
2776
5f795e34
EZ
27772013-03-15 Eli Zaretskii <eliz@gnu.org>
2778
2779 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
2780 FULLSCREEN_MAXIMIZED. (Bug#13935)
2781
f258b4be
DA
27822013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
2783
2784 * region-cache.c (find_cache_boundary, move_cache_gap)
2785 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
2786 Simplify debugging check and convert to eassert. Adjust comment.
2787 (pp_cache): Put under ENABLE_CHECKING.
2788
a5cc4dde
EZ
27892013-03-14 Eli Zaretskii <eliz@gnu.org>
2790
2791 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
2792 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
2793 and WM_ACTIVATEAPP.
2794 (w32fullscreen_hook): If the frame is visible, reset
2795 f->want_fullscreen flag after changing the frame size. If the
2796 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
2797 (Bug#13953)
2798
3fc5e44a
DC
27992013-03-13 Daniel Colascione <dancol@dancol.org>
2800
2801 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
2802 too so that these builds can use Cygwin's file conversion
2803 functions. (We've been building and linking cygw32.o all along
2804 and just not using it.)
2805
47d7532e
PE
28062013-03-13 Paul Eggert <eggert@cs.ucla.edu>
2807
2808 File synchronization fixes (Bug#13944).
2809 * Makefile.in (LIB_FDATASYNC): New macro.
2810 (LIBES): Use it.
2811 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
2812 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
2813 Don't worry about HAVE_FSYNC, since a substitute fsync is
2814 available if the system lacks one.
2815 (Fwrite_regin): Retry fsync if interrupted.
2816
c7ffccaf
EZ
28172013-03-13 Eli Zaretskii <eliz@gnu.org>
2818
4e2df81d 2819 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
2820 activated, call w32fullscreen_hook, to make sure the new frame
2821 dimensions are in effect. (Bug#13937)
2822
8a7debc1
DA
28232013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
2824
2825 * xdisp.c (init_iterator): Simplify because both character and byte
2826 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
2827 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
2828 character and byte positions can be obtained from marker.
8a7debc1 2829
7fd8c501
PE
28302013-03-13 Paul Eggert <eggert@cs.ucla.edu>
2831
d9df6f40
PE
2832 Static checking by Sun C 5.12.
2833 * alloc.c (buffer_memory_full) [REL_ALLOC]:
2834 * bytecode.c (exec_byte_code):
2835 * dispnew.c (init_display):
2836 * eval.c (error):
2837 * fileio.c (Fsubstitute_in_file_name):
2838 * keyboard.c (Fevent_convert_list):
2839 * keymap.c (Fsingle_key_description):
2840 * term.c (maybe_fatal, fatal):
2841 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
2842 * xsmfns.c (Fhandle_save_session):
2843 Omit unreachable code.
2844 * keymap.c (map_keymap_char_table_item): Cast void * to
2845 a function pointer type; the C Standard requires this.
2846
7fd8c501
PE
2847 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
2848 Include <sys/param.h> unconditionally, as that works elsewhere and
2849 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
2850 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
2851 and FreeBSD now.
2852
a020afb9 2853See ChangeLog.12 for earlier changes.
aac0c6e3
MR
2854
2855;; Local Variables:
2856;; coding: utf-8
aac0c6e3
MR
2857;; End:
2858
ab422c4d 2859 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
2860
2861 This file is part of GNU Emacs.
2862
2863 GNU Emacs is free software: you can redistribute it and/or modify
2864 it under the terms of the GNU General Public License as published by
2865 the Free Software Foundation, either version 3 of the License, or
2866 (at your option) any later version.
2867
2868 GNU Emacs is distributed in the hope that it will be useful,
2869 but WITHOUT ANY WARRANTY; without even the implied warranty of
2870 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2871 GNU General Public License for more details.
2872
2873 You should have received a copy of the GNU General Public License
2874 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.