lisp/frameset.el: Various fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dc6c0eda
SM
12013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * lisp.mk (lisp): Add nadvice.elc.
4
8f3a2c26
DA
52013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
6
7 New macro to iterate over live buffers similar to frames.
8 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
9 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
10 Declare buffer-related variables here to offload lisp.h.
11 * buffer.c (Vbuffer_alist): Adjust comment.
12 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
13 (other_buffer_safely):
14 * data.c (store_symval_forwarding):
15 * dispnew.c (Fframe_or_buffer_changed_p):
16 * fileio.c (Fdo_auto_save):
17 * filelock.c (unlock_all_files):
18 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
19
e0fdb694
PE
202013-08-04 Paul Eggert <eggert@cs.ucla.edu>
21
22 Fix some minor races in hosts lacking mkostemp (Bug#15015).
23 * callproc.c (create_temp_file):
24 * filelock.c (create_lock_file):
25 Assume mkostemp, since it's now provided by Gnulib.
26
63f5c6c2
EZ
272013-08-04 Eli Zaretskii <eliz@gnu.org>
28
29 * w32.c (mkostemp): New function.
30 (mktemp): Remove, no longer used. Most of the code reused in
31 mkostemp. (Bug#15015)
484ab239 32 (mktemp): Don't undef.
63f5c6c2 33
f0b79313
DA
342013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
35
36 * dispnew.c (glyph_matrix_count, glyph_pool_count):
37 Move under GLYPH_DEBUG and ENABLE_CHECKING.
38 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
39 (free_glyph_pool, check_glyph_memory): Likewise for
40 all users. Adjust comments where appropriate.
41
98f638d6
PE
422013-08-03 Paul Eggert <eggert@cs.ucla.edu>
43
44 * composite.h: Minor fixups.
45 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
46 to fix a misspelling, and change it to an inline function while
47 we're at it (it need not be a macro). All uses changed.
48 (composition_method, composition_valid_p):
49 Rewrite to avoid assignments in if-conditions.
50
75c59fb3
DA
512013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
52
53 Do not use global Lisp_Object in composition macros.
54 * composite.h (composition_temp): Remove declaration.
55 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
56 (composition_method, composition_valid_p): ...inline functions.
416a3e01 57 (compose_region): Remove the leftover.
75c59fb3
DA
58 * composite.c (composition_temp): Remove.
59 (run_composition_function, update_compositions)
60 (composition_compute_stop_pos, composition_adjust_point)
61 (Ffind_composition_internal):
62 * coding.c (handle_composition_annotation):
63 * xdisp.c (handle_composition_prop, check_point_in_composition):
64 Related users changed.
65
a10c8269
DA
662013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
67
68 Drop FRAME_PTR typedef.
69 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
70 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
71 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
72 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
73 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
74 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
75 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
76 All related users changed.
77
a104f656
SM
782013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
79
80 * eval.c (default_toplevel_binding): New function.
81 (Fdefvar): Use it.
82 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
83 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
84 (syms_of_eval): Export them.
85 * data.c (Fdefault_value): Micro cleanup.
86 * term.c (init_tty): Use "false".
87
4b5c9326
DA
882013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
89
90 Fix X GC leak in GTK and raw (no toolkit) X ports.
91 * xterm.c (x_free_frame_resources): If white and black relief
92 GCs are allocated, always free them here.
93 * xfns.c (x_make_gc): Omit redundant initialization.
94 * widget.c (create_frame_gcs): Remove the leftover.
95 (EmacsFrameDestroy): Do nothing because all GCs are now freed
96 in x_free_frame_resources.
97
b19aa636
JD
982013-08-02 Jan Djärv <jan.h.d@swipnet.se>
99
100 * nsterm.m (windowWillResize:toSize:): Only change title if
101 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
102 modifying it.
103 (viewDidEndLiveResize): New method.
104
105 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
106 inside NS_IMPL_COCOA.
107
af1f7e06
DA
1082013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
109
110 * insdel.c (adjust_after_replace, replace_range, del_range_2):
111 Do not check whether undo is enabled because record_insert and
112 record_delete does that themselves.
113
65b02bb9
DA
1142013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
115
116 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
117 member which is not really used any more.
118 (FRAME_XIC_BASE_FONTNAME): Remove.
119 * xfns.c (xic_free_fontset): Adjust user.
120 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
121 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
122 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
123 (xdialog_show): Use eassert for debugging check.
7ee0f047 124 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 125
6318cde0
PE
1262013-08-01 Paul Eggert <eggert@cs.ucla.edu>
127
128 * fileio.c, fns.c (merge): Move extern decl from here ...
129 * lisp.h (merge): ... to here.
130
6c1a09ba
DA
1312013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
132
133 Fix last font-related change.
134 * w32font.h (w32font_list_internal, w32font_match_internal):
135 Fix prototype.
136 * w32uniscribe.c (uniscribe_list, uniscribe_match):
137 (uniscribe_list_family): Adjust to match font API change.
138 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
139 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
140
f8c20208
DA
1412013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
142
143 * frame.h (FRAME_MOUSE_UPDATE):
144 * nsterm.m (ns_frame_up_to_date): Omit redundant check
145 whether hlinfo->mouse_face_mouse_frame is non-NULL.
146
fdb396e2
DA
1472013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
148
149 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
150 * font.h (struct font_driver): Change list, match, and list_family
151 functions to accept struct frame * as first arg.
152 * font.c (font_score, font_compare, font_sort_entities): Remove
153 prototypes.
154 (font_sort_entities, font_list_entities, font_select_entity):
155 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
156 match font API change.
157 * xfont.c (xfont_list, xfont_match, xfont_list_family):
158 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
159 * ftxfont.c (ftxfont_list, ftxfont_match):
160 * xftfont.c (xftfont_list, xftfont_match):
161 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
162 * w32font.c (w32font_list, w32font_match, w32font_list):
163 (w32font_list_internal, w32_font_match_internal): Likewise.
164 * xfaces.c (Fx_family_fonts): Adjust user.
165
52b8a085
DA
1662013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
167
168 Do not use pure Xism x_wm_set_icon_position in non-X ports.
169 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
170 only if HAVE_X_WINDOWS is in use.
171 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
172 * nsterm.m (x_wm_set_icon_position): Remove no-op.
173 * w32term.c (x_wm_set_icon_position): Likewise.
174 * w32fns.c (x_icon): Adjust user.
175
c791c18e
DA
1762013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
177
178 * xterm.c (last_mouse_press_frame): Remove the
179 leftover which is not really used any more.
180 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
181 (x_flush): Call XFlush once per each X display, not frame.
182 This is better because this code always unconditionally skips
183 non-X frames in Vframe_list and issues the only XFlush if we
184 have more than one X frame on the same X display.
2f935d86
DA
185 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
186 Use bool for booleans.
187 (x_draw_glyph_string_background, cvt_string_to_pixel):
188 (cvt_pixel_dtor): Drop unnecessary prototypes.
189 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 190
f435830e
DA
1912013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
192
193 Drop unnecessary functions that deals with frame pixel size.
194 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
195 (x_pixel_height): Drop prototypes.
196 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
197 (x_pixel_height): Drop implementations.
198 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
199 which should be always valid for window frame.
200 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
201 * w32menu.c (Fx_popup_dialog):
202 * xmenu.c (Fx_popup_dialog): Likewise for both.
203
84231434
DA
2042013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
205
206 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
207 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
208 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
209 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
210 and mention nil frame in docstring.
84231434 211
959067a1
DA
2122013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
213
214 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
215 (x_figure_window_size): Likewise. Adjust to return long.
216 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
217 (toplevel): Move Qterminal_live_p to...
218 * terminal.c (toplevel): ...here, make it static, and...
219 (syms_of_terminal): ...DEFSYM here.
220 * frame.h (Qterminal_live_p): Remove declaration.
221 (make_frame, x_figure_window_size): Adjust prototype.
222 * nsfns.m (Fx_create_frame): Use long for window flags.
223
f4b169ce
PE
2242013-07-30 Paul Eggert <eggert@cs.ucla.edu>
225
226 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
227 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
228 Do not assume that emacs_close (INT_MAX) is a no-op.
229
bee6a2c7
DA
2302013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
231
232 * xfaces.c (make_face_cache): For struct face_cache, prefer
233 xmalloc to xzalloc and so avoid redundant call to memset.
234 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
235
d7e6881a
DA
2362013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
237
238 * fringe.c (draw_window_fringes, update_window_fringes)
239 (compute_fringe_widths):
240 * w32term.c (x_draw_glyph_string):
241 * window.c (candidate_window_p, Frecenter):
242 * xfaces.c (realize_basic_faces, realize_default_face)
243 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
244 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
245 * xfns.c (x_set_cursor_color, xic_free_xfontset):
246 * xmenu.c (Fx_menu_bar_open_internal):
247 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
248 * xsettings.c (xft_settings_event):
249 * xterm.c (x_draw_glyph_string, x_had_errors_p):
250 Use bool for booleans. Adjust style and comments where
251 appropriate.
252 * dispextern.h (draw_window_fringes, update_window_fringes)
253 (compute_fringe_widths):
254 * xterm.h (x_had_errors_p): Adjust prototype.
255
ec3058af
DA
2562013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
257
258 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
259 CHECK_LIST. Rewrite the loop to avoid useless local variable.
260
218e0637
DA
2612013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
262
263 * fns.c (toplevel): Remove comment before Fsafe_length because
264 it checks for QUIT.
265
e560aba9
PE
2662013-07-28 Paul Eggert <eggert@cs.ucla.edu>
267
268 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
269
2e5ce5de
EZ
2702013-07-28 Eli Zaretskii <eliz@gnu.org>
271
272 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
273 frame which got the message is still alive, before dereferencing
274 its pointer. (Bug#14970)
275
276 * frame.c (delete_frame): Test "this" frame's minibuffer window to
277 be a live window, before using it as such. (Bug#14970)
278
e95da6d3
EZ
2792013-07-27 Eli Zaretskii <eliz@gnu.org>
280
281 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
282 w32_detect_focus_change instead of doing part of its job by hand.
283 This fixes the problem whereby FOCUS_OUT events were not sent to
284 the event queue.
285
a8f93651
EZ
2862013-07-26 Eli Zaretskii <eliz@gnu.org>
287
fec92060
EZ
288 * process.c (Fprocess_list): Doc fix.
289
a8f93651
EZ
290 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
291 being re-exposed only if it didn't ask to become visible.
292 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
293 was previously iconified. (Bug#14841)
294 (x_iconify_frame): Mark the frame iconified.
295
d5a7a9d9
PE
2962013-07-26 Paul Eggert <eggert@cs.ucla.edu>
297
298 Fix minor problems found by static checking.
299 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
300 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
301
56ea7291
SM
3022013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
303
304 * eval.c (set_specpdl_old_value): New function.
305 (unbind_to): Minor simplification.
306 (get_backtrace_frame): New function.
307 (Fbacktrace_frame): Use it. Add `base' argument.
308 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
309 (syms_of_eval): Export backtrace-eval.
310 * xterm.c (x_focus_changed): Simplify.
311
9d611ffe
PE
3122013-07-25 Paul Eggert <eggert@cs.ucla.edu>
313
314 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
315
999c74e3
EZ
3162013-07-24 Eli Zaretskii <eliz@gnu.org>
317
318 * xdisp.c (redisplay_window): Instead of moving point out of
319 scroll margin, reject the force_start method, and try scrolling
320 instead. (Bug#14780)
321
198fa217
KB
3222013-07-24 Ken Brown <kbrown@cornell.edu>
323
324 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
325 (Bug#14944).
326
53840e55
PE
3272013-07-24 Paul Eggert <eggert@cs.ucla.edu>
328
329 * eval.c (Fprogn): Do not check that BODY is a proper list.
330 This undoes the previous change. The check slows down the
331 interpreter, and is not needed to prevent a crash. See
332 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
333
60967f56
GM
3342013-07-23 Glenn Morris <rgm@gnu.org>
335
336 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
337
9ca960e2
PE
3382013-07-23 Paul Eggert <eggert@cs.ucla.edu>
339
a29c3e6d
PE
340 Port to GNU/Linux systems with tinfo but not ncurses.
341 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
342 to decide whether ncurses is being used. Without this change,
343 GCC complains about tgetent not being declared, on a system
344 that has tinfo installed but ncurses not installed.
345
f274311c
PE
346 * eval.c (Fprogn): Check that BODY is a proper list.
347
16b0520a
PE
348 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
349 * data.c (Fsetq_default):
350 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
351 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
352 (Fcondition_case):
353 Tune by taking advantage of the fact that ARGS is always a list
354 when a function is declared to have UNEVALLED args.
355
9ca960e2
PE
356 * emacsgtkfixed.c: Port to GCC 4.6.
357 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
358
afacaa1b
JB
3592013-07-23 Juanma Barranquero <lekktu@gmail.com>
360
361 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
362 here to silence compiler warnings.
363
368a85a4
PE
3642013-07-22 Paul Eggert <eggert@cs.ucla.edu>
365
366 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
367 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
368 from messing up Emacs's 'struct frame' (Bug#14923).
369
f4e891b5
PE
3702013-07-21 Paul Eggert <eggert@cs.ucla.edu>
371
372 * alloc.c (make_save_ptr_ptr): Define this function.
373 It was inadvertently omitted. It's needed only if
374 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
375
96c8b65e
JD
3762013-07-21 Jan Djärv <jan.h.d@swipnet.se>
377
378 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
379 frame have focus (Bug#14895).
380
ee010797
PE
3812013-07-21 Paul Eggert <eggert@cs.ucla.edu>
382
383 Avoid vfork-related deadlock more cleanly.
384 * callproc.c (child_setup): When the child's exec fails, output
385 the program name, as that's more useful. Use O_NONBLOCK to avoid
386 deadlock.
387 * process.c (create_process_1): Remove; no longer needed.
388 (create_process): Remove timer hack; no longer needed, now that
389 the child avoids deadlock.
390
f0398ec1 3912013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
392
393 * image.c (Fimage_flush): Fix doc typo.
394
b2a069c2
PE
3952013-07-20 Paul Eggert <eggert@cs.ucla.edu>
396
6496aec9
PE
397 Fix array bounds violation when pty allocation fails.
398 * process.c (PTY_NAME_SIZE): New constant.
399 (pty_name): Remove static variable; it's now auto.
400 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
401 Take pty_name as an arg rather than using a static variable.
402 All callers changed.
403 (create_process): Recover pty_flag from process, not from volatile local.
404 (create_pty): Stay inside array even when pty allocation fails.
405 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
406
b2a069c2
PE
407 * lread.c (Fload): Avoid initialization only when lint checking.
408 Mention that it's needed only for older GCCs.
409
99107004
KH
4102013-07-20 Kenichi Handa <handa@gnu.org>
411
412 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
413 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
414
6b1b199d
AS
4152013-07-20 Andreas Schwab <schwab@linux-m68k.org>
416
417 * lread.c (Fload): Avoid uninitialized warning.
418
4195afc3
PE
4192013-07-19 Paul Eggert <eggert@cs.ucla.edu>
420
3f5bef16
PE
421 Fix some minor file descriptor leaks and related glitches.
422 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
423 (create_lock_file): Use write, not emacs_write.
424 * image.c (slurp_file, png_load_body):
425 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
426 (server_accept_connection):
427 Don't leak an fd on memory allocation failure.
428 * image.c (slurp_file): Add a cheap heuristic for growing files.
429 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
430 as that's what the other routines do. Maybe input need not be
431 blocked at all, but it's better to be consistent.
432 Avoid undefined behavior when strlen is zero.
433
4195afc3
PE
434 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
435 (NSTATICS): Now a constant; doesn't need to be a macro.
436
a1aeeffe
RS
4372013-07-19 Richard Stallman <rms@gnu.org>
438
439 * coding.c (decode_coding_utf_8): Add simple loop for fast
440 processing of ASCII characters.
441
63b34baa
PE
4422013-07-19 Paul Eggert <eggert@cs.ucla.edu>
443
444 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
445
621dd9ac
EZ
4462013-07-19 Eli Zaretskii <eliz@gnu.org>
447
448 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
449 unportable 'struct x_display_info'.
450 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
451 is a portable type.
452
1396ac86
PE
4532013-07-19 Paul Eggert <eggert@cs.ucla.edu>
454
ab9980cd
PE
455 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
456 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
457 or fscanf fails.
458 (system_process_attributes): Prefer plain char to unsigned char
459 when either will do. Clean up properly if interrupted or if
460 memory allocations fail. Don't assume sscanf succeeds. Remove
461 no-longer-needed workaround to stop GCC from whining. Read
462 command-line once, instead of multiple times. Check read status a
463 bit more carefully.
464
1396ac86
PE
465 Fix obscure porting bug with varargs functions.
466 The code assumed that int is treated like ptrdiff_t in a vararg
467 function, which is not a portable assumption. There was a similar
468 -- though these days less likely -- porting problem with various
469 assumptions that pointers of different types all smell the same as
470 far as vararg functions is conserved. To make this problem less
471 likely in the future, redo the API to use varargs functions.
472 * alloc.c (make_save_value): Remove this vararg function.
473 All uses changed to ...
474 (make_save_int_int_int, make_save_obj_obj_obj_obj)
475 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
476 New functions.
477 (make_save_ptr): Rename from make_save_pointer, for consistency with
478 the above. Define only on platforms that need it. All uses changed.
479
4d19d194
PE
4802013-07-18 Paul Eggert <eggert@cs.ucla.edu>
481
482 * keyboard.c: Try to fix typos in previous change.
483 (DISPLAY_LIST_INFO): New macro.
484 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 485 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 486
945c5bb1
JB
4872013-07-18 Juanma Barranquero <lekktu@gmail.com>
488
489 * keyboard.c (kbd_buffer_get_event):
490 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
491 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
492
f4b1eb36
PE
4932013-07-18 Paul Eggert <eggert@cs.ucla.edu>
494
5e679a2c
PE
495 * filelock.c: Fix unlikely file descriptor leaks.
496 (get_boot_time_1): Rework to avoid using emacs_open.
497 This doesn't actually fix a leak, but is better anyway.
498 (read_lock_data): Use read, not emacs_read.
499
a8cd4836
PE
500 * doc.c: Fix minor memory and file descriptor leaks.
501 * doc.c (get_doc_string): Fix memory leak when doc file absent.
502 (get_doc_string, Fsnarf_documentation):
503 Fix file descriptor leak on error.
504
ef30e638
PE
505 * term.c: Fix minor fdopen-related file descriptor leaks.
506 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
507 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
508
f4b1eb36
PE
509 * charset.c: Fix file descriptor leaks and errno issues.
510 Include <errno.h>.
511 (load_charset_map_from_file): Don't leak file descriptor on error.
512 Use plain record_xmalloc since the allocation is larger than
513 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
514 of entries.
515 * eval.c (record_unwind_protect_nothing):
516 * fileio.c (fclose_unwind):
517 New functions.
518 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
519 The replacement doesn't block input, but that no longer seems
520 necessary.
521
b648c163
PE
5222013-07-17 Paul Eggert <eggert@cs.ucla.edu>
523
a0931322
PE
524 * lread.c: Fix file descriptor leaks and errno issues.
525 (Fload): Close some races that leaked fds or streams when 'load'
526 was interrupted.
527 (Fload, openp): Report error number of last nontrivial failure to open.
528 ENOENT counts as trivial.
529 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
530 New functions.
531 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
532 now that the function is always called with a nonnegative arg.
533 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
534 All uses replaced with ...
535 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
536
b648c163
PE
537 A few more minor file errno-reporting bugs.
538 * callproc.c (Fcall_process):
539 * doc.c (Fsnarf_documentation):
540 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
541 * process.c (set_socket_option):
542 Don't let a constructor trash errno.
543 * doc.c: Include <errno.h>.
544
b1dc4084
JB
5452013-07-16 Juanma Barranquero <lekktu@gmail.com>
546
547 * w32fns.c (unwind_create_tip_frame): Fix declaration.
548
c43843aa
PE
5492013-07-16 Paul Eggert <eggert@cs.ucla.edu>
550
50a30cce
PE
551 Fix w32 bug with call-process-region (Bug#14885).
552 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
553 to Fcall_process when the input is empty. This simplifies the
554 code a bit. It makes no difference on POSIXish platforms but
555 apparently it fixes a bug on w32.
556
44e18199 557 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
558 * fileio.c (close_file_unwind): Don't close if FD is negative;
559 this can happen when unwinding a zapped file descriptor.
560 (Finsert_file_contents): Unwind-protect the fd before the point marker,
561 in case Emacs runs out of memory between the two unwind-protects.
562 Don't trash errno when closing FD.
563 Zap the FD in the specpdl when closing it, instead of deferring
564 the removal of the unwind-protect; this fixes a bug where a child
565 function unwinds the stack past us.
566
27e498e6
PE
567 New unwind-protect flavors to better type-check C callbacks.
568 This also lessens the need to write wrappers for callbacks,
569 and the need for make_save_pointer.
570 * alloca.c (free_save_value):
571 * atimer.c (run_all_atimers):
572 Now extern.
573 * alloc.c (safe_alloca_unwind):
574 * atimer.c (unwind_stop_other_atimers):
575 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
576 * menu.c (cleanup_popup_menu) [HAVE_NS]:
577 * minibuf.c (choose_minibuf_frame_1):
578 * process.c (make_serial_process_unwind):
579 * xdisp.h (pop_message_unwind):
580 * xselect.c (queue_selection_requests_unwind):
581 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
582 * alloca.c (record_xmalloc):
583 Prefer record_unwind_protect_ptr to record_unwind_protect with
584 make_save_pointer.
585 * alloca.c (Fgarbage_collect):
586 Prefer record_unwind_protect_void to passing a dummy.
587 * buffer.c (restore_buffer):
588 * window.c (restore_window_configuration):
589 * xfns.c, w32fns.c (do_unwind_create_frame)
590 New wrapper. All record-unwind uses of wrappee changed.
591 * buffer.c (set_buffer_if_live):
592 * callproc.c (call_process_cleanup, delete_temp_file):
593 * coding.c (code_conversion_restore):
594 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
595 * editfns.c (save_excursion_restore)
596 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
597 (save_restriction_restore):
598 * eval.c (restore_stack_limits, un_autoload):
599 * fns.c (require_unwind):
600 * keyboard.c (recursive_edit_unwind, tracking_off):
601 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
602 * macros.c (pop_kbd_macro, restore_menu_items):
603 * nsfns.m (unwind_create_frame):
604 * print.c (print_unwind):
605 * process.c (start_process_unwind):
606 * search.c (unwind_set_match_data):
607 * window.c (select_window_norecord, select_frame_norecord):
608 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
609 (fast_set_selected_frame):
610 * xfns.c, w32fns.c (unwind_create_tip_frame):
611 Return void, not a dummy Lisp_Object. All uses changed.
612 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
613 * callproc.c (call_process_kill):
614 * fileio.c (restore_point_unwind, decide_coding_unwind)
615 (build_annotations_unwind):
616 * insdel.c (Fcombine_after_change_execute_1):
617 * keyboard.c (read_char_help_form_unwind):
618 * menu.c (unuse_menu_items):
619 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
620 * sound.c (sound_cleanup):
621 * xdisp.c (unwind_redisplay):
622 * xfns.c (clean_up_dialog):
623 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
624 Accept no args and return void, instead of accepting and returning
625 a dummy Lisp_Object. All uses changed.
626 * cygw32.c (fchdir_unwind):
627 * fileio.c (close_file_unwind):
628 * keyboard.c (restore_kboard_configuration):
629 * lread.c (readevalllop_1):
630 * process.c (wait_reading_process_output_unwind):
631 Accept int and return void, rather than accepting an Emacs integer
632 and returning a dummy object. In some cases this fixes an
633 unlikely bug when the corresponding int is outside Emacs integer
634 range. All uses changed.
635 * dired.c (directory_files_internal_unwind):
636 * fileio.c (do_auto_save_unwind):
637 * gtkutil.c (pop_down_dialog):
638 * insdel.c (reset_var_on_error):
639 * lread.c (load_unwind):
640 * xfns.c (clean_up_file_dialog):
641 * xmenu.c, nsmenu.m (pop_down_menu):
642 * xmenu.c (cleanup_widget_value_tree):
643 * xselect.c (wait_for_property_change_unwind):
644 Accept pointer and return void, rather than accepting an Emacs
645 save value encapsulating the pointer and returning a dummy object.
646 All uses changed.
647 * editfns.c (Fformat): Update the saved pointer directly via
648 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
649 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
650 (unwind_body): New function.
651 (record_unwind_protect): First arg is now a function returning void,
652 not a dummy Lisp_Object.
653 (record_unwind_protect_ptr, record_unwind_protect_int)
654 (record_unwind_protect_void): New functions.
655 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
656 * fileio.c (struct auto_save_unwind): New type.
657 (do_auto_save_unwind): Use it.
658 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
659 * insdel.c (struct rvoe_arg): New type.
660 (reset_var_on_error): Use it.
661 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
662 New constants.
663 (specbinding_func): Remove; there are now several such functions.
664 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
665 (set_unwind_protect_ptr): New function.
666 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
667
4e604a5d
PE
668 Be simpler and more consistent about reporting I/O errors.
669 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
670 Say "Read error" and "Write error", rather than "I/O error", or
671 "IO error reading", or "IO error writing", when a read or write
672 error occurs.
673 * process.c (Fmake_network_process, wait_reading_process_output)
674 (send_process, Fprocess_send_eof, wait_reading_process_output):
675 Capitalize diagnostics consistently. Put "failed foo" at the
676 start of the diagnostic, so that we don't capitalize the
677 function name "foo". Consistently say "failed" for such
678 diagnostics.
679 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
680 All callers changed. This is so it can use report_file_error.
681 * sysdep.c (serial_open, serial_configure): Capitalize I/O
682 diagnostics consistently as above.
683
a9757f6a
PE
684 * fileio.c (report_file_errno): Fix errno reporting bug.
685 If the file name is neither null nor a pair, package it up as a
686 singleton list. All callers changed, both to this function and to
687 report_file_error. This fixes a bug where the memory allocator
688 invoked by list1 set errno so that the immediately following
689 report_file_error reported the wrong errno value.
690
c43843aa
PE
691 Fix minor problems found by --enable-gcc-warnings.
692 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
693 * keyboard.c (kbd_buffer_get_event): Remove unused local.
694
18c26d81
JD
6952013-07-16 Jan Djärv <jan.h.d@swipnet.se>
696
697 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
698 Set event->arg to Qt if switch-event shall be generated.
699 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
700
701 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
702
703 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
704 FOCUS_OUT_EVENT.
705
706 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
707 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
708 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
709 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 710 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
711 and there is a focused frame.
712 (head_table): Add focus-in and focus-out.
713 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
714 bind to handle-focus-in/out.
715
716 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
717 (Fhandle_switch_frame): Call Fhandle_focus_in.
718 (syms_of_frame): defsubr handle-focus-in/out.
719
6c6f1994
PE
7202013-07-16 Paul Eggert <eggert@cs.ucla.edu>
721
c7ddc792
PE
722 Fix porting bug to older POSIXish platforms (Bug#14862).
723 * sysdep.c (emacs_pipe): New function, that implements
724 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
725 This should port better to CentOS 5 and to Mac OS X 10.6.
726 All calls to pipe2 changed.
727
6c6f1994
PE
728 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
729 This makes the code easier to read and the executable a bit smaller.
730 Do not replace all calls to Fcons that happen to create lists,
731 just calls that are intended to create lists. For example, when
732 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
733 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
734 Similarly for list2 through list5.
735 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
736 * bytecode.c (exec_byte_code):
737 * callint.c (quotify_arg, Fcall_interactively):
738 * callproc.c (Fcall_process, create_temp_file):
739 * charset.c (load_charset_map_from_file)
740 (Fdefine_charset_internal, init_charset):
741 * coding.c (get_translation_table, detect_coding_system)
742 (Fcheck_coding_systems_region)
743 (Fset_terminal_coding_system_internal)
744 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
745 * composite.c (update_compositions, Ffind_composition_internal):
746 * dired.c (directory_files_internal, file_name_completion)
747 (Fsystem_users):
748 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
749 * doc.c (Fsnarf_documentation):
750 * editfns.c (Fmessage_box):
751 * emacs.c (main):
752 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
753 (Feval, eval_sub, Ffuncall, apply_lambda):
754 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
755 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
756 (Fset_file_times, Finsert_file_contents)
757 (Fchoose_write_coding_system, Fwrite_region):
758 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
759 * font.c (font_registry_charsets, font_parse_fcname)
760 (font_prepare_cache, font_update_drivers, Flist_fonts):
761 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
762 * frame.c (make_frame, Fmake_terminal_frame)
763 (x_set_frame_parameters, x_report_frame_params)
764 (x_default_parameter, Fx_parse_geometry):
765 * ftfont.c (syms_of_ftfont):
766 * image.c (gif_load):
767 * keyboard.c (command_loop_1):
768 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
769 (Fcopy_keymap, append_key, Fcurrent_active_maps)
770 (Fminor_mode_key_binding, accessible_keymaps_1)
771 (Faccessible_keymaps, Fwhere_is_internal):
772 * lread.c (read_emacs_mule_char):
773 * menu.c (find_and_return_menu_selection):
774 * minibuf.c (get_minibuffer):
775 * nsfns.m (Fns_perform_service):
776 * nsfont.m (ns_script_to_charset):
777 * nsmenu.m (ns_popup_dialog):
778 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
779 (Fx_own_selection_internal):
780 * nsterm.m (append2):
781 * print.c (Fredirect_debugging_output)
782 (print_prune_string_charset):
783 * process.c (Fdelete_process, Fprocess_contact)
784 (Fformat_network_address, set_socket_option)
785 (read_and_dispose_of_process_output, write_queue_push)
786 (send_process, exec_sentinel):
787 * sound.c (Fplay_sound_internal):
788 * textprop.c (validate_plist, add_properties)
789 (Fput_text_property, Fadd_face_text_property)
790 (copy_text_properties, text_property_list, syms_of_textprop):
791 * unexaix.c (report_error):
792 * unexcoff.c (report_error):
793 * unexsol.c (unexec):
794 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
795 (Fformat_mode_line, syms_of_xdisp):
796 * xfaces.c (set_font_frame_param)
797 (Finternal_lisp_face_attribute_values)
798 (Finternal_merge_in_global_face, syms_of_xfaces):
799 * xfns.c (x_default_scroll_bar_color_parameter)
800 (x_default_font_parameter, x_create_tip_frame):
801 * xfont.c (xfont_supported_scripts):
802 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
803 (menu_help_callback, xmenu_show):
804 * xml.c (make_dom):
805 * xterm.c (set_wm_state):
806 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
807 and similarly for list2 through list5.
808
bafe80ce
PE
8092013-07-15 Paul Eggert <eggert@cs.ucla.edu>
810
811 * callproc.c (Fcall_process_region): Fix minor race and tune.
812 (create_temp_file): New function, with the temp-file-creation part
813 of the old Fcall_process_region. Use Fcopy_sequence to create the
814 temp file name, rather than alloca + build_string, for simplicity.
815 Don't bother to block input around the temp file creation;
816 shouldn't be needed. Simplify use of mktemp. Use
817 record_unwind_protect immediately after creating the temp file;
818 this closes an unlikely race where the temp file was not removed.
819 Use memcpy rather than an open-coded loop.
820 (Fcall_process_region): Use the new function. If the input is
821 empty, redirect from /dev/null rather than from a newly created
822 empty temp file; this avoids unnecessary file system traffic.
823
4700b5a5
PE
8242013-07-14 Paul Eggert <eggert@cs.ucla.edu>
825
5c97beae
PE
826 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
827 Simplify by making this case like the other two. This is a bit
828 slower on obsolete hosts, but the extra complexity isn't worth it.
829
4700b5a5
PE
830 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
831 * process.c (create_process) [!DOS_NT]:
832 Remove now-unnecessary calls to emacs_close.
833
f9a74c4c
EZ
8342013-07-13 Eli Zaretskii <eliz@gnu.org>
835
922ae7ee
EZ
836 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
837 returning early. (Bug#14850)
838
f9a74c4c
EZ
839 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
840 and inhibit-iso-escape-detection attributes of 'undecided'.
841 (Bug#14822)
842
5e301d76
PE
8432013-07-13 Paul Eggert <eggert@cs.ucla.edu>
844
69e0e5ee
PE
845 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
846 Reported by Herbert J. Skuhra in
847 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
848
5e301d76
PE
849 Don't lose top specpdl entry when memory is exhausted.
850 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
851 specpdl overflow here, to simplify callers; all callers changed.
852 Always reserve an unused entry at the stack top; this avoids
853 losing the top entry's information when memory is exhausted.
854
7e649856
PE
8552013-07-12 Paul Eggert <eggert@cs.ucla.edu>
856
a773ed9a
PE
857 Clean up errno reporting and fix some errno-reporting bugs.
858 * callproc.c (Fcall_process):
859 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
860 * process.c (create_process, Fmake_network_process):
861 * unexaix.c (report_error):
862 * unexcoff.c (report_error):
863 Be more careful about reporting the errno of failed operations.
864 The code previously reported the wrong errno sometimes.
865 Also, prefer report_file_errno to setting errno + report_file_error.
866 (Fcall_process): Look at openp return value rather than at path,
867 as that's a bit faster and clearer when there's a numeric predicate.
868 * fileio.c (report_file_errno): New function, with most of the
869 old contents of report_file_error.
870 (report_file_error): Use it.
871 (Ffile_exists_p, Ffile_accessible_directory_p):
872 Set errno to 0 when it is junk.
873 * fileio.c (Faccess_file):
874 * image.c (x_create_bitmap_from_file):
875 Use faccessat rather than opening the file, to avoid the hassle of
876 having a file descriptor open.
877 * lisp.h (report_file_errno): New decl.
878 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
879
7e649856
PE
880 Minor EBADF fixes.
881 * process.c (create_process, wait_reading_process_output) [AIX]:
882 Remove obsolete SIGHUP-related code, as Emacs no longer disables
883 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
884 a multithreaded environment anyway).
885 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
886
f6774c1a
AS
8872013-07-12 Andreas Schwab <schwab@linux-m68k.org>
888
889 * image.c (x_find_image_file): Don't close a remote file handle.
890
bacba3c2
PE
8912013-07-12 Paul Eggert <eggert@cs.ucla.edu>
892
893 Fix races with threads and file descriptors.
894 * callproc.c (Fcall_process_region):
895 * dired.c (open_directory):
896 * emacs.c (main, Fdaemon_initialized):
897 * image.c (x_find_image_file):
898 * inotify.c (Finotify_rm_watch):
899 * lread.c (Flocate_file_internal):
900 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
901 * term.c (term_mouse_moveto, init_tty):
902 * termcap.c (tgetent):
903 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
904 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
905 * unexhp9k800.c, unexmacosx.c (unexec):
906 * callproc.c (Fcall_process_region):
907 Use emacs_close, not close.
908 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
909 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
910 and posix_close function on current platforms (which all lack them).
911 (emacs_close): Use it. This should fix the races on GNU/Linux and
912 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
913 and it should avoid closing random victim file descriptors on
914 other platforms.
915
653d4f43
PE
9162013-07-11 Paul Eggert <eggert@cs.ucla.edu>
917
c8536ec4
PE
918 * inotify.c (uninitialized): Remove. All uses replaced by -1.
919 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
920 Touch up doc a bit.
921
9c203066
PE
922 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
923 This is for .gdbinit xbacktrace.
924
653d4f43
PE
925 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
926 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
927 (emacs_set_tty): Now static.
928 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
929 * term.c (tty_capable_p, tty_default_color_capabilities)
930 (get_tty_terminal, term_mouse_movement)
931 (handle_one_term_event, init_tty, maybe_fatal):
932 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
933 (tgetent, scan_file, name_match, compare_contin):
934 * terminal.c (get_terminal):
935 Use bool for boolean.
936 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
937 Prefer char to unsigned char if either will do.
938 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
939 (tty_write_glyphs): Prefer int to unsigned.
940 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
941 All callers changed.
942 * termcap.c (tprint, main) [TEST]: Remove non-working test.
943
45b683a1
PE
9442013-07-10 Paul Eggert <eggert@cs.ucla.edu>
945
29abe551
PE
946 Port to C89.
947 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
948 (B__dummy__): New dummy symbol, to pacify C89.
949 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
950 they can't grok varargs macros.
951 * dispnew.c (add_window_display_history)
952 (add_frame_display_history):
953 * print.c (print_object):
954 * xdisp.c (debug_method_add):
955 Use %p printf format only for void pointers.
956 * emacs.c (usage_message): New constant, replacing ...
957 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
958 (main): Adjust to usage reorg.
959 * fns.c (syms_of_fns):
960 * profiler.c (syms_of_profiler):
961 Don't use non-constant struct initializers.
962 * gnutls.h (gnutls_initstage_t):
963 * lisp.h (enum Lisp_Fwd_Type):
964 * lread.c (lisp_file_lexically_bound_p):
965 * xsettings.c (anonymous enum):
966 Remove trailing comma.
967 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
968 * lisp.h (ENUM_BF): Use unsigned if pedantic.
969 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
970 (DEFUN): Use it.
971 * regex.c (const_re_char): New type, to pacify strict C89.
972 All uses of 'const re_char' replaced to use it.
973 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
974 with glibc when strict C89. This change is imported from gnulib.
975 All uses changed.
976 (_Restrict_arr_): Rename from __restrict_arr, similarly.
977 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
978 Omit GNU_LINUX implementation, since it requires long long.
979 * xterm.c (x_draw_underwave):
980 Do not assume the traditional order of struct's members.
981 (x_term_init): Rewrite to avoid the need for non-constant structure
982 initializers.
983
45b683a1 984 Syntax cleanup, mostly replacing macros with functions.
763a086d 985 This removes the need for the syntax_temp hack.
45b683a1
PE
986 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
987 * syntax.c (SYNTAX_INLINE): New macro.
988 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
989 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
990 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
991 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
992 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
993 (SYNTAX_COMEND_FIRST): Now functions, not macros.
994 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
995 Now constants, not macros.
996 (syntax_temp) [!__GNUC__]: Remove.
997 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
998 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
999 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1000 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1001 Move here from syntax.h; now functions, not macros. Except for the
1002 last function, these are static since only syntax.c uses them.
1003 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1004 All uses changed. Now a function, not a macro; use this fact
1005 to simplify the code.
1006 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1007 compiler bugs; no longer relevant.
1008 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1009 (SYNTAX_INLINE): New macro.
1010 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1011 for the new functions. Use bool for boolean member.
1012 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1013 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1014 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1015 (SETUP_BUFFER_SYNTAX_TABLE):
1016 Now extern inline functions, not macros.
1017 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1018 Remove; all uses replaced by implementation.
1019 (syntax_temp) [!__GNUC__]: Remove decl.
1020 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1021
29be4a50
JD
10222013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1023
1024 * emacs.c (main): Fix syntax error.
1025
954b166e
PE
10262013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 Timestamp fixes for undo (Bug#14824).
1029 * atimer.c (schedule_atimer):
1030 * fileio.c (Ffile_newer_than_file_p):
1031 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1032 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1033 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1034 (syms_of_fileio): Remove Sclear_visited_file_name.
1035 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1036 file doesn't exist; this avoids an ambiguity with negative timestamps.
1037 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1038 * systime.h (make_emacs_time, invalid_emacs_time):
1039 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1040 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1041 * undo.c (record_first_change): Push (visited-file-modtime) onto
1042 undo list rather than reimplementing it by hand, incorrectly.
1043
d74647c3
KB
10442013-07-09 Ken Brown <kbrown@cornell.edu>
1045
1046 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1047
3c51b96b
JB
10482013-07-09 Juanma Barranquero <lekktu@gmail.com>
1049
1050 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1051
4ebbdd67
PE
10522013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1053
1054 Handle errno and exit status a bit more carefully.
1055 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1056 number into an exit status. Instead, use EXIT_CANCELED.
1057 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1058 * callproc.c (relocate_fd):
1059 * emacs.c (close_output_streams, main):
1060 * process.c (create_process):
1061 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1062 Use emacs_perror for simplicity.
1063 * callproc.c (relocate_fd, main):
1064 * sysdep.c (sys_subshell):
1065 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1066 (shut_down_emacs): Use emacs_write, not write.
1067 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1068 * fileio.c (Fcopy_file, e_write):
1069 * nsterm.m (ns_select):
1070 * process.c (send_process):
1071 * sound.c (vox_write):
1072 Use emacs_write_sig, not emacs_write.
1073 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1074 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1075 New constants.
1076 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1077 of write.
1078 (emacs_full_write): New function.
1079 (emacs_write): Rewrite to use it.
1080 (emacswrite_sig, emacs_perror): New functions.
1081 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1082
44e18199 10832013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1084
1085 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1086 on NS even if it is present. Pixmap on NS is a void*.
1087
9caab067
PE
10882013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 Port to Ubuntu 10 (Bug#14803).
1091 Problem reported by T.V. Raman.
1092 * process.c (close_on_exec, accept4, process_socket):
1093 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1094
1d442672
EZ
10952013-07-07 Eli Zaretskii <eliz@gnu.org>
1096
1097 * w32.c (sys_dup): Declare prototype.
1098
1099 * filelock.c:
1100 * emacs.c:
1101 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1102
067428c1
PE
11032013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1104
1105 Make file descriptors close-on-exec when possible (Bug#14803).
1106 This simplifies Emacs a bit, since it no longer needs to worry
1107 about closing file descriptors by hand in some cases.
1108 It also fixes some unlikely races. Not all such races, as
1109 libraries often open files internally without setting
1110 close-on-exec, but it's an improvement.
1111 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1112 * callproc.c (Fcall_process) [!MSDOS]:
1113 * emacs.c (main) [!DOS_NT]:
1114 * nsterm.m (ns_term_init):
1115 * process.c (create_process):
1116 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1117 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1118 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1119 Prefer mkostemp with O_CLOEXEC to mkstemp.
1120 * callproc.c (relocate_fd) [!WINDOWSNT]:
1121 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1122 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1123 now using pipe2.
1124 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1125 Make the resulting file descriptor close-on-exec.
1126 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1127 * lread.c (load_descriptor_list, load_descriptor_unwind):
1128 Remove; no longer needed. All uses removed.
1129 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1130 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1131 New functions.
1132 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1133 (Fmake_network_process, Fnetwork_interface_list):
1134 (Fnetwork_interface_info, server_accept_connection):
1135 Make newly-created socket close-on-exec.
1136 * sysdep.c (emacs_open, emacs_fopen):
1137 Make new-created descriptor close-on-exec.
1138 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1139 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1140
0da857dd
JD
11412013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1142
1143 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1144 for NS_IMPL_GNUSTEP.
1145
5f86adcd
PE
11462013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 Fix openp errno handling.
1149 * callproc.c (Fcall_process): Preserve openp errno around close.
1150 * lread.c (openp): Set errno when returning -1, as some callers
1151 expect this.
1152
1afb1d07
JD
11532013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1154
1155 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1156
1157 * nsterm.h (NSSavePanel): Update comment.
1158 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1159 (ns_run_file_dialog): Declare.
1160
1161 * nsfns.m: Remove panelOK.
1162 (ns_fd_data): New.
1163 (ns_run_file_dialog): New function.
1164 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1165 event loop, so file dialog is popped up by ns_run_file_dialog, called
1166 by sendEvent (Bug#14578).
1167 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1168
3323c263
EZ
11692013-07-06 Eli Zaretskii <eliz@gnu.org>
1170
fdda0220
EZ
1171 * xdisp.c (default_line_pixel_height): New function.
1172 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1173 (try_cursor_movement, redisplay_window, try_window)
1174 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1175
1176 * window.c (window_scroll_pixel_based): use
1177 default_line_pixel_height.
1178
1179 * dispextern.h (default_line_pixel_height): Add prototype.
1180
1181 * frame.c (x_set_line_spacing): Accept a float value for
1182 line-spacing parameter, per the documentation.
1183
3323c263
EZ
1184 * data.c (Fmultibyte_string_p): Doc fix.
1185
47ba6d43
PE
11862013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1187
406af475
PE
1188 Use emacs_open more consistently when opening files.
1189 This handles EINTR more consistently now, and makes it easier
1190 to introduce other uniform changes to file descriptor handling.
1191 * src/systdio.h: New file.
1192 * src/buffer.c (mmap_init):
1193 * cygw32.c (chdir_to_default_directory):
1194 * dispnew.c (Fopen_termscript):
1195 * emacs.c (Fdaemon_initialized):
1196 * fileio.c (Fdo_auto_save):
1197 * image.c (slurp_file, png_load_body, jpeg_load_body):
1198 * keyboard.c (Fopen_dribble_file):
1199 * lread.c (Fload):
1200 * print.c (Fredirect_debugging_output):
1201 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1202 * termcap.c (tgetent):
1203 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1204 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1205 * w32term.c (w32_initialize) [CYGWIN]:
1206 * xfaces.c (Fx_load_color_file):
1207 Use emacs_open instead of plain open, and emacs_fopen instead of
1208 plain fopen.
1209 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1210 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1211 * callproc.c (default_output_mode): New constant.
1212 (Fcall_process): Use it to call emacs_open instead of plain creat.
1213 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1214 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1215 (emacs_fopen): New function.
1216 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1217 Include <lisp.h>, for emacs_open.
1218 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1219
47ba6d43
PE
1220 Remove duplicate #include directives.
1221 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1222 * xfaces.c:
1223 Don't include stdio.h twice.
1224 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1225 Don't include sys/types.h or stdio.h twice.
1226 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1227 * lread.c: Don't include coding.h twice.
1228 * nsfont.m: Don't include frame.h twice.
1229 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1230 * ralloc.c: Don't include <unistd.h> twice.
1231 * xdisp.c: Don't include font.h twice.
1232 * xterm.c: Don't include fontset.h twice.
1233 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1234
b9ed53d5
PE
12352013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1236
1237 Scale ImageMagick images more carefully.
1238 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1239 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1240 Be more careful about avoiding undefined behavior after
1241 integer overflow and division by zero.
1242
cf13177e
YM
12432013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1244
1245 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1246 (syms_of_w32fns): DEFSYM them.
1247 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1248 (CCHDEVICENAME): Define macros if not defined.
1249 (struct MONITOR_INFO_EX): New struct.
1250 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1251 (enum_display_monitors_fn): New variable.
1252 (globals_of_w32fns): Initialize it.
1253 (Fx_display_pixel_width, Fx_display_pixel_height)
1254 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1255 multi-monitor setups in docstrings.
1256 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1257 screen size by primary monitor's millimeter per pixel.
1258 (w32_monitor_enum, w32_display_monitor_attributes_list)
1259 (w32_display_monitor_attributes_list_fallback)
1260 (Fw32_display_monitor_attributes_list): New functions.
1261 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1262
1263 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1264 if not defined.
1265 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1266
86dfb7a8
MA
12672013-07-04 Michael Albinus <michael.albinus@gmx.de>
1268
1269 * fileio.c (Qfile_notify_error): New error symbol.
1270
1271 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1272 * inotify.c (inotify_callback, symbol_to_inotifymask)
1273 (Finotify_add_watch, Finotify_rm_watch): Use it.
1274 (inotifyevent_to_event): Exchange order of cookie and file name.
1275 (Finotify_add_watch): Adapt docstring.
1276
1277 * lisp.h (Qfile_notify_error): Declare.
1278
2c1c974b
PE
12792013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1282 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1283 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1284 which did not work (see <http://bugs.gnu.org/14569#307>).
1285 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1286 && (!noninteractive || initialized)). This attempts to thread
1287 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1288
7a35b20f
JB
12892013-07-04 Juanma Barranquero <lekktu@gmail.com>
1290
1291 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1292 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1293
1ce5cd04
PE
12942013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1297 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1298 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1299 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1300
57f8c490
PE
13012013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1304 Define to __sys_siglist.
1305
bcffb5ca
EZ
13062013-07-02 Eli Zaretskii <eliz@gnu.org>
1307
1308 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1309 word-wrap, so that overflow-newline-into-fringe would work in
1310 visual-line-mode. (Bug#2749)
1311 (move_it_in_display_line_to): When the last scanned display
1312 element fits exactly on the display line, and
1313 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1314 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1315 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1316 finding buffer position that corresponds to pixel coordinates,
1317 e.g. in buffer_posn_from_coords.
1318
2c41e781
JD
13192013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1320
1321 * process.c (handle_child_signal): Call catch_child_signal if
1322 NS_IMPL_GNUSTEP.
1323
c2418359
PE
13242013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1325
52a9bcae
PE
1326 Don't convert function pointers to void * and back.
1327 It isn't portable C, and it's easy enough to avoid.
1328 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1329 (make_save_value): Add support for SAVE_FUNCPOINTER.
1330 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1331 * print.c (print_object):
1332 Distinguish function from object pointers.
1333 * lisp.h (SAVE_FUNCPOINTER): New constant.
1334 (SAVE_SLOT_BITS): Adjust to it.
1335 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1336 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1337 (voidfuncptr): New typedef.
1338 (struct Lisp_Save_Value): New member data[0].funcpointer.
1339 (XSAVE_FUNCPOINTER): New function.
1340
c2418359
PE
1341 Simplify buildobj processing.
1342 * Makefile.in (buildobj.h): Make it a sequence of strings each
1343 followed by comma, rather than a single string. Put it into a
1344 .tmp file in case there's an error while generating it.
1345 (gl-stamp): Use .tmp for temp files.
1346 (mostlyclean): Clean .tmp files.
1347 * doc.c (buildobj): Move to just the routine that needs it.
1348 It's now an array of strings, so processing is simpler.
1349
8f43ce49
PE
13502013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1353 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1354 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1355 Invoke malloc_enable_thread even when not interactive.
1356 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1357 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1358 in this case, since the underlying bug has now been fixed.
1359
24827db9
JB
13602013-07-01 Juanma Barranquero <lekktu@gmail.com>
1361
1362 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1363 unlinking it (bug#14691).
1364
ef099a94
MN
13652013-06-30 Michal Nazarewicz <mina86@mina86.com>
1366
1367 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1368 before checking whether buffer is modified. This lets
1369 `kill-buffer-query-functions' cancel killing of the buffer or save
1370 its content before `kill-buffer' asks user the "Buffer %s
1371 modified; kill anyway?" question.
1372
9d3f2fc2
JD
13732013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1374
1375 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1376 Let the super performKeyEquivalent deal with them (Bug#14747).
1377
e6c6c8c7
PE
13782013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1379
1d71c1d9
PE
1380 * widget.c (resize_cb): Remove unused local.
1381
8f5f35cc
PE
1382 Do not use GTK 3 if it exists but cannot be compiled.
1383 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1384 * xterm.c (x_error_handler) [!USE_GTK]:
1385 Do not use GTK 3.
1386
e6c6c8c7
PE
1387 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1388
0ba54312
EZ
13892013-06-30 Eli Zaretskii <eliz@gnu.org>
1390
5d1c3286
EZ
1391 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1392 to the valid range of values. (Bug#14753)
1393
0ba54312
EZ
1394 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1395 when moving point by using the current glyph matrix. This avoids
1396 the need to force redisplay when this function is called in a
1397 loop.
1398
9c90cc06
PE
13992013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 Fix minor problems found by static checking.
1402 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1403 Redo the latter's body to sidestep GCC parenthesization warnings.
1404 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1405 * coding.c (detect_coding, detect_coding_system):
1406 * coding.h (struct undecided_spec):
1407 Use bool for boolean.
1408 * image.c (QCmax_width, QCmax_height): Now static.
1409 * xdisp.c (Fmove_point_visually): Remove unused local.
1410
4c672a0f
EZ
14112013-06-29 Eli Zaretskii <eliz@gnu.org>
1412
1413 * xdisp.c (Fmove_point_visually): New function.
1414
c1ea3abf
JB
14152013-06-28 Kenichi Handa <handa@gnu.org>
1416
1417 * coding.h (define_coding_undecided_arg_index): New enum.
1418 (coding_attr_index): New members
1419 coding_attr_undecided_inhibit_null_byte_detection,
1420 coding_attr_undecided_inhibit_iso_escape_detection,
1421 coding_attr_undecided_prefer_utf_8.
1422 (undecided_spec): New struct.
1423 (struct coding_system): New member `undecided' of the member
1424 `spec'.
1425
1426 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1427 (detect_coding): Likewise.
1428 (detect_coding_system): Likewise.
1429 (Fdefine_coding_system_internal): New coding system properties
1430 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1431 :prefer-utf-8.
1432 (syms_of_coding): Adjust for coding_arg_undecided_max.
1433
ba3de9e6
PE
14342013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * image.c (x_from_xcolors): Remove unused local.
1437
547c9269
YM
14382013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1439
1440 Defer image data transfer between X client and server until actual
1441 display happens.
1442
1443 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1444 and `mask_img'.
1445
1446 * image.c (Destroy_Image): Remove.
1447 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1448 `mask_p', and `colors_p'. All uses changed.
1449 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1450 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1451 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1452 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1453 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1454 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1455 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1456 (image_get_x_image, image_unget_x_image): New functions or macros.
1457 (image_background, image_background_transparent, x_to_xcolors)
1458 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1459 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1460 instead of Destroy_Image.
1461 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1462 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1463 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1464 (imagemagick_load_image, svg_load_image): Use them instead of
1465 x_create_x_image_and_pixmap, and x_put_x_image followed by
1466 x_destroy_x_image, respectively.
1467 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1468 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1469 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1470 background_transparent fields.
1471 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1472 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1473
dae2f5ef
PE
14742013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1477 This mostly consists of undoing recent changes.
1478 * callproc.c (Fcall_process):
1479 * process.c (create_process):
1480 Do not worry about catching SIGCHLD here, undoing previous change.
1481 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1482 * process.c, process.h (catch_child_signal):
1483 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1484 * process.c (catch_child_handler): Don't worry about being called
1485 lazily and do not assume caller has blocked SIGCHLD, undoing
1486 previous change. Move first-time stuff back to
1487 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1488 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1489 set lib_child_handler if it's already initialized, which may
1490 help avoid problems on GNUStep.
1491
fa55d2aa
PE
14922013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1495 * callproc.c (Fcall_process):
1496 * process.c (create_process):
1497 Make sure SIGCHLD is caught before we fork,
1498 since Emacs startup no arranges to catch SIGCHLD.
1499 * process.c (lib_child_handler): Initialize to null, not to
1500 dummy_handler.
1501 (catch_child_signal): Allow self to be called lazily.
1502 Do nothing if it's already been called.
1503 Assume caller has blocked SIGCHLD (all callers do now).
1504 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1505 just before it's really needed.
1506 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1507 since it hasn't been caught yet.
1508
f3f9606c
LMI
15092013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1510
1511 * image.c (compute_image_size): New function to implement
1512 :max-width and :max-height.
1513 (imagemagick_load_image): Use it.
1514
c7041908
PE
15152013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1518 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1519 Now extern.
1520 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1521 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1522 the SIGCHLD handler, since the code is not atomic and (due to glib)
1523 signals may be arriving now.
1524 * sysdep.c (init_signals): Do not catch child signals here;
1525 'main' now does that later, at a safer time.
1526
f86852b4
PE
15272013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1528
0dfeed58
PE
1529 Clean up SIGCHLD handling a bit (Bug#14569).
1530 * process.c, process.h (catch_child_signal):
1531 Now always extern, even if !NS_IMPL_GNUSTEP.
1532 * process.c (catch_child_signal): Move glib tickler here from
1533 init_process_emacs, so that it's done earlier in Emacs
1534 initialization. Also move the noninteractive && !initialized
1535 check here from init_process_emacs. This is all a bit cleaner for
1536 GNUish platforms, and I hope it works around the Cygwin bug.
1537 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1538 that glib signal handling is tickled before glib creates threads.
1539
f86852b4
PE
1540 * process.c (wait_reading_process_output): Avoid int overflow
1541 when reading more than 2 GiB total from a process.
1542
cbd6509c
PE
15432013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1544
1545 * process.c (create_process): Handle a couple more cases,
1546 i.e., work even if new_argv and wait_child_setup[i] are cached.
1547 Use Fcall_process's style for volatile vars.
1548
9de1114a
AS
15492013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1550
1551 * process.c (create_process): Mark PROCESS volatile.
1552
fbe9e0b9
PE
15532013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 Use C99-style flexible array members if available.
1556 This avoids some subtle aliasing issues, which typically
1557 aren't a problem with GCC but may be a problem elsewhere.
1558 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1559 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1560 In either case, it uses a flexible array member rather than
1561 the old struct hack. All uses changed.
1562 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1563 Adjust to sdata reorganization.
1564 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1565 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1566 that ports better to pre-C99 non-GCC.
1567 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1568 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1569 as the latter has changed.
1570 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1571 and port better to pre-C99 GCC.
1572 * image.c (struct xpm_cached_color):
1573 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1574 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1575 Use FLEXIBLE_ARRAY_MEMBER.
1576 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1577 Move decl to top level so it gets checked against implementation.
1578 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1579 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1580
1fc71008
PE
15812013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * syntax.c: Integer cleanups.
1584 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1585 All uses that need 0-or-2 changed to:
1586 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1587 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1588 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1589 (char_quoted, prev_char_comend_first, back_comment)
1590 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1591 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1592 Use bool for boolean.
1593 (update_syntax_table, skip_chars, skip_syntaxes):
1594 Prefer int to unsigned when either will do.
1595 (back_comment): Return boolean success flag, like forw_comment,
1596 instead of positive-or-minus-1 (which might have overflowed int anyway).
1597 Don't stuff ptrdiff_t into int.
1598 (syntax_spec_code, syntax_code_spec): Now const.
1599 (Fmatching_paren, scan_lists, scan_sexps_forward):
1600 Use enum syntaxcode for syntax code.
1601 (Fmatching_paren): Check that arg is a character, not just an integer.
1602 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1603 (Finternal_describe_syntax_value): Omit no-longer-needed
1604 comparison to 0.
1605 (skip_chars): Use char, not unsigned char, when the distinction
1606 doesn't matter.
1607 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1608 * bytecode.c (exec_byte_code):
1609 * syntax.c (syntax_spec_code, Fchar_syntax)
1610 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1611 (init_syntax_once):
1612 * syntax.h (SYNTAX_WITH_FLAGS):
1613 Omit unnecessary casts.
1614
b932cad7
EZ
16152013-06-20 Eli Zaretskii <eliz@gnu.org>
1616
1617 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1618 line dimensions here, to avoid race conditions with the main
1619 thread. (Bug#14062, bug#14630, bug#14669)
1620
1621 * w32term.c (w32_draw_window_cursor): Compute the header line and
1622 mode line dimensions here.
1623 <w32_system_caret_window, w32_system_caret_hdr_height>:
1624 <w32_system_caret_mode_height>: New variables.
1625
1626 * w32term.h: Declare them.
1627
89561f72
PE
16282013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1629
5013fc08
PE
1630 * alloc.c (die): Move "assertion failed" string here ...
1631 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1632 COND when SUPPRESS_CHECKING. This shrinks the executable text
1633 size by 0.8% to 2.2% when configured with --enable-checking,
1634 depending on optimization flags (GCC 4.8.1 x86-64).
1635
89561f72
PE
1636 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1637
763a086d 16382013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
1639
1640 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1641 base is 2; this is more accurate.
1642
983aeb9a
JB
16432013-06-19 Juanma Barranquero <lekktu@gmail.com>
1644
1645 * sound.c (string_default): Move to !WINDOWSNT section.
1646 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1647
178ba3e6
PE
16482013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1649
bbc51b15
PE
1650 * sound.c: Integer cleanups.
1651 Remove unnecessary forward decls.
1652 (struct sound_device): The 'file' member is now a Lisp_Object, not
1653 a char *, so that we needn't invoke alloca on a huge size.
1654 (Fplay_sound_internal): Adjust to this.
1655 (string_default): New function.
1656 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1657 Use it to adjust to the struct sound_device change.
1658 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1659 (be2hs) [0]: Remove.
1660
178ba3e6
PE
1661 * syntax.c (skip_chars): Don't use uninitialized storage
1662 when searching a multibyte buffer for characters that are not in a
1663 unibyte string that contains non-ASCII characters.
1664
69f60cdc
JD
16652013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1666
1667 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1668 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1669
0d6224d4
PE
16702013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1673
3c542890
KH
16742013-06-18 Kenichi Handa <handa@gnu.org>
1675
f7e3f7cd
KH
1676 * font.c (Ffont_spec): Signal an error for an invalid font name
1677 (Bug#14648).
3c542890 1678
9349e5f7
PE
16792013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1682 In particular this ports to 32-bit sparc Sun cc.
1683 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1684 array with a dummy element at specpdl[-1], so that its address can
1685 be taken portably.
1686 (unbind_to): Do not copy the binding; not needed, now that we
1687 copy old_value in the one place where the copy is needed.
1688 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1689 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1690 (union specbinding): Rename from struct specbinding. Redo layout
1691 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1692 which is not portable. With Sun C 5.12 32-bit sparc, the
1693 declaration causes nargs to be an unsigned bitfield, a behavior
1694 that the C standard allows; but Emacs wants nargs to be signed.
1695 The overall type is now a union of structures rather than a
1696 structure of union of structures, and the 'kind' member is now a
1697 bitfield, so that the overall type doesn't grow. All uses changed.
1698 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1699
0a4df6a5
PE
17002013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1701
ec6ecaad
PE
1702 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1703 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1704
0a4df6a5
PE
1705 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1706
7bfe8dbc
EZ
17072013-06-17 Eli Zaretskii <eliz@gnu.org>
1708
1709 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1710 unless we know that the window w's frame is a frame object.
1711 Another attempt at solving bug#14062 and bug#14630.
1712
708e05f6
LMI
17132013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1714
1715 * textprop.c (property_set_type): New enum.
1716 (add_properties): Allow appending/prepending text properties.
1717 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1718 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1719 add_text_properties_1.
1720 (Fadd_face_text_property): New function that calls
1721 add_text_properties_1.
1722
84575e67
PE
17232013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 Move functions from lisp.h to individual modules when possible.
1726 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1727 * alloc.c (XFLOAT_INIT, set_symbol_name):
1728 * buffer.c (CHECK_OVERLAY):
1729 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1730 (set_char_table_parent):
1731 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1732 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1733 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1734 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1735 (set_blv_valcell):
1736 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1737 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1738 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1739 (backtrace_args, backtrace_debug_on_exit):
1740 * floatfns.c (CHECK_FLOAT):
1741 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1742 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1743 (set_hash_hash, set_hash_hash_slot, set_hash_index)
1744 (set_hash_index_slot):
1745 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
1746 * marker.c (CHECK_MARKER):
1747 * textprop.c (CHECK_STRING_OR_BUFFER):
1748 * window.c (CHECK_WINDOW_CONFIGURATION):
1749 Move here from lisp.h, and make these functions static rather than
1750 extern inline.
1751 * buffer.c (Qoverlayp):
1752 * data.c (Qsubrp):
1753 * fns.c (Qhash_table_p):
1754 * window.c (Qwindow_configuration_p):
1755 Now static.
1756 * lisp.h: Remove the abovementioned defns and decls.
1757
44e18199 1758 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
1759 In lisp.h, prefer functions to function-like macros, and
1760 constants to object-like macros, when either will do. This:
1761 . simplifies use, as there's no more need to worry about
1762 arguments' side effects being evaluated multiple times.
1763 . makes the code easier to debug on some platforms.
1764 However, when using gcc -O0, keep using function-like macros
1765 for a few critical operations, for performance reasons.
1766 This sort of thing isn't needed with gcc -Og, but -Og
1767 is a GCC 4.8 feature and isn't widely-enough available yet.
1768 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
1769 Remove enum lsb_bits; no longer needed.
1770 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
1771 * buffer.c (Qoverlap):
1772 * data.c (Qsubrp):
1773 * fns.c (Qhash_table_p):
1774 Now extern, so lisp.h can use these symbols.
1775 * dispextern.h: Include character.h, for MAX_CHAR etc.
1776 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1777 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1778 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1779 (GLYPH_CODE_P): Move here from lisp.h.
1780 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1781 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
1782 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
1783 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
1784 XUNTAG now returns void *.
1785 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
1786 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
1787 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
1788 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
1789 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
1790 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
1791 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
1792 (lisp_h_XPNTR, lisp_h_XSYMBOL):
1793 New macros, renamed from their sans-lisp_h_ counterparts.
1794 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
1795 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
1796 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
1797 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
1798 If compiling via GCC without optimization, define these as macros
1799 in addition to inline functions.
1800 To disable this, compile with -DINLINING=0.
1801 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
1802 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
1803 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
1804 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
1805 (INTMASK, VALMASK): Now macros, since static values cannot be
1806 accessed from extern inline functions.
1807 (VALMASK): Also a constant, for benefit of old GDB.
1808 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
1809 is INTEGERP, which can fold it in.
5165d44a 1810 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
1811 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
1812 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
1813 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
1814 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
1815 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
1816 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
1817 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
1818 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
1819 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
1820 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
1821 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
1822 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
1823 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
1824 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
1825 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
1826 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
1827 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
1828 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
1829 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
1830 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
1831 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
1832 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
1833 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
1834 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
1835 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
1836 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
1837 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
1838 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
1839 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
1840 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
1841 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
1842 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
1843 Now functions.
1844 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
1845 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
1846 (VALMASK): Define in one place rather than in two, merging the
1847 USE_LSB_TAG parts; this is simpler.
1848 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
1849 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
1850 Move up, to avoid use before definition.
1851 Also include "globals.h" earlier, for the same reason.
1852 (make_natnum): New function.
1853 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
1854 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
1855 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
1856 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
1857 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
1858 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
1859 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
1860 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
1861 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
1862 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
1863 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
1864 (Qwindow_configuration_p, Qimage): New forward declarations.
1865 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
1866 (STRING_COPYIN): Remove; unused.
1867 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
1868 (xcar_addr, xcdr_addr): New functions. All uses changed.
1869 (IEEE_FLOATING_POINT): Now a constant, not a macro.
1870 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1871 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1872 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1873 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
1874 (TYPE_RANGED_INTEGERP): Simplify.
1875 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
1876 (setlocale, fixup_locale, synchronize_system_messages_locale)
1877 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
1878 Now empty functions, not macros.
1879 (functionp): Return bool, not int.
1880 * window.c (Qwindow_configuration_p): Now extern,
1881 so window.h can use it.
1882 * window.h (Qwindowp): Move decl back to lisp.h.
1883
9583ec36
EZ
18842013-06-15 Eli Zaretskii <eliz@gnu.org>
1885
1886 * xdisp.c (Fline_pixel_height): New function, required for solving
1887 bug #14567.
1888
210272ce
PE
18892013-06-15 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
1892
de0503df
SM
18932013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
1894
1895 * lread.c (syms_of_lread):
1896 * fns.c (Fprovide): Adjust to new format of after-load-alist.
1897
afbfe143
KD
18982013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
1899
1900 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
1901
d177e213
XF
19022013-06-12 Xue Fuqiao <xfq.free@gmail.com>
1903
1904 * fileio.c (expand_file_name): Doc fix.
1905
05e3e412
PE
19062013-06-11 Paul Eggert <eggert@cs.ucla.edu>
1907
f7394b12
PE
1908 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
1909 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
1910 Wait for self, not for 0. This can't hurt on GNU or similar
1911 system, and may help with Cygwin.
1912
05e3e412
PE
1913 * keyboard.c: Don't use PROP (...) as an lvalue.
1914 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
1915 Use set_prop (A, B), not PROP (A) = B.
1916
17dd3097
EZ
19172013-06-10 Eli Zaretskii <eliz@gnu.org>
1918
1919 * xdisp.c (get_it_property): Use it->window instead of generating
1920 a Lisp object from it->w.
1921
52fab9c9
EZ
19222013-06-09 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (get_it_property): If it->object is a buffer, pass to
1925 get-char-property the window that is being rendered, instead of
1926 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
1927 (compute_display_string_pos): When W is NULL, use the current
1928 buffer as the object to pass to get-char-property.
1929 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
1930 pointer member of the bidi iterator, since no window is pertinent
1931 to this function.
52fab9c9 1932
5bf97bfc
EZ
19332013-06-08 Eli Zaretskii <eliz@gnu.org>
1934
1935 * bidi.c (bidi_fetch_char): Accept additional argument, the window
1936 being displayed, and pass it to compute_display_string_pos.
1937 (bidi_level_of_next_char, bidi_resolve_explicit_1)
1938 (bidi_paragraph_init): All callers changed.
1939
1940 * xdisp.c (init_from_display_pos, init_iterator)
1941 (handle_single_display_spec, next_overlay_string)
1942 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
1943 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
1944 Set bidi_it.w member from it->w.
5bf97bfc
EZ
1945 (compute_display_string_pos): Accept additional argument, the
1946 window being displayed, and pass it to Fget_char_property.
1947 (Bug#14575)
1948
1949 * dispextern.h (struct bidi_it): New member w, the window being
1950 displayed.
1951 (compute_display_string_pos): Adjust prototype.
1952
5de0e011
JD
19532013-06-08 Jan Djärv <jan.h.d@swipnet.se>
1954
e7b41c4c 1955 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
1956
1957 * process.c (wait_reading_process_output): Check for NS before GLIB.
1958 GLIB may be linked in due to rsvg, but ns_select must be called.
1959
5de0e011
JD
1960 * xgselect.c (xg_select): Remove call to window_system_available
1961 and g_main_context_pending at the top, so Gdk events (i.e. file
1962 notify) are processed when Emacs is started with -nw.
1963
a822acff
EZ
19642013-06-07 Eli Zaretskii <eliz@gnu.org>
1965
1966 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
1967 (ctagsfiles3): New variable, includes only *.m files.
1968 (TAGS): Use an explicit language name in the regular expressions,
1969 to avoid transformation of '/SOMETHING' by MSYS to
1970 'c:\MSYS\SOMETHING'.
1971
6c0a9ed1
RC
19722013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
1973
1974 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
1975
9ef6111b
EZ
19762013-06-06 Eli Zaretskii <eliz@gnu.org>
1977
1978 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
1979 still need to set the mouse pointer shape and activate help-echo.
1980 (Bug#14558)
1981
7d300d64
PE
19822013-06-06 Paul Eggert <eggert@cs.ucla.edu>
1983
1984 A few porting etc. fixes for the new file monitor code.
1985 See the thread containing
1986 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
1987 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
1988 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
1989 (dir_monitor_callback, Fgfile_rm_watch):
1990 Use assq_no_quit instead of Fassoc, for speed.
1991 (dir_monitor_callback, Fgfile_rm_watch):
1992 eassert that the monitor is a fixnum.
1993 (dir_monitor_callback): No need for CDR_SAFE.
1994 Simplify building of lisp with alternative tails.
1995 (Fgfile_add_watch, Fgfile_rm_watch):
1996 Do not assume glib functions set errno reliably on failure.
1997 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
1998 and signal an error otherwise.
1999 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2000 Use Fdelq instead of Fdelete, for speed.
2001
817ebfcf
EZ
20022013-06-05 Eli Zaretskii <eliz@gnu.org>
2003
2004 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2005 don't insist on being invoked on a highlighted tool-bar button.
2006 Avoids losing tool-bar functionality when mouse-highlight is nil.
2007 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2008 Don't highlight when mouse-highlight is nil.
2009 (note_mouse_highlight): When mouse-highlight is nil, don't return
2010 right away; instead, run tool-bar and mode-line highlight
2011 subroutine, clear any existing highlight, and revert the mouse
2012 pointer to its default shape. (Bug#14558)
2013
55577e7c
SM
20142013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2015
2016 * lisp.mk (lisp): Add prog-mode.el.
2017
f019a684
PE
20182013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2019
2020 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2021 * process.c (dummy_handler): New function.
2022 (lib_child_handler): New static var.
2023 (handle_child_signal): Invoke it.
2024 (catch_child_signal): If a library has set up a signal handler,
2025 save it into lib_child_handler.
2026 (init_process_emacs): If using glib and not on Windows, tickle glib's
2027 child-handling code so that it initializes its private SIGCHLD handler.
2028 * syssignal.h (SA_SIGINFO): Default to 0.
2029 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2030 31; it should no longer be needed now.
2031
90db8702
MA
20322013-06-05 Michael Albinus <michael.albinus@gmx.de>
2033
2034 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2035
2036 * gfilenotify.c (globals_of_gfilenotify): New function.
2037 (syms_of_gfilenotify): Move global initialization there.
2038
2039 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2040
bfa3acd6
SM
20412013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2042
2043 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2044 * keyboard.c (menu_bar_items, tool_bar_items):
2045 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2046 not override local keymaps any more.
2047
ba59bd80
EZ
20482013-06-04 Eli Zaretskii <eliz@gnu.org>
2049
2050 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2051
7f203aa1
EZ
20522013-06-03 Eli Zaretskii <eliz@gnu.org>
2053
9337e206
EZ
2054 * w32console.c (initialize_w32_display): Return the dimensions of
2055 the console window via 2 additional arguments, not via the current
2056 frame. This avoids crashes due to overrunning the bounds of
2057 frame's decode_mode_spec_buffer, which is not resized following
2058 the change of the frame dimensions from the initial 10x10.
2059
2060 * w32term.h (w32_initialize_display_info): Adjust prototype.
2061
2062 * term.c (init_tty): Take dimensions of the frame from the values
2063 returned by initialize_w32_display.
2064
7f203aa1
EZ
2065 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2066 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2067 (LIBES): Add $(GFILENOTIFY_LIBS).
2068
2069 * w32inevt.c (handle_file_notifications): Add dummy implementation
2070 for !HAVE_W32NOTIFY.
2071
2072 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2073
55a87246
JD
20742013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2075
2076 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2077
2078 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2079
2080 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2081
3d5ee10a
PE
20822013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2083
2084 Fix minor problems found by static checking.
2085 * data.c (pure_write_error):
2086 Use xsignal2, not Fsignal, as Fsignal might return.
2087 * eval.c (set_backtrace_debug_on_exit): Now static.
2088 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2089 No longer inline. EXTERN_INLINE is needed only for functions
2090 defined in .h files. Reindent function header as per GNU style.
2091 (backtrace_p, backtrace_top, backtrace_next):
2092 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2093 compiler or linker. Add extern decls to pacify gcc -Wall.
2094 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2095 Now static.
2096 * frame.c (free_monitors): Define only on platforms that need it.
2097 * nsterm.m (ns_term_init):
2098 * process.c (catch_child_signal):
2099 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2100 defined on all porting targets these days.
2101 * process.c, process.h (catch_child_signal):
2102 Make it extern only if NS_IMPL_GNUSTEP is defined.
2103
e2d8a6f0
EZ
21042013-06-03 Eli Zaretskii <eliz@gnu.org>
2105
2106 * w32.c (gettimeofday): Make the signature identical to prototype
2107 in nt/inc/sys/time.h.
2108
a8a7c5f6
SM
21092013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2110
2111 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2112 .gdbinit.
2113
2114 * keyboard.c (safe_run_hooks_error): Improve error message.
2115
2116 * data.c (pure_write_error): Add `object' argument.
2117 * puresize.h (CHECK_IMPURE): Use it.
2118
c9628c79
MA
21192013-06-03 Michael Albinus <michael.albinus@gmx.de>
2120
2121 * Makefile.in (NOTIFY_OBJ): New variable.
2122 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2123
2124 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2125 Call syms_of_gfilenotify.
2126
2127 * gfilenotify.c: New file.
2128
2129 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2130 and Qfile_w32notify.
2131 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2132 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2133
2134 * lisp.h: Declare syms_of_gfilenotify.
2135
2136 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2137
2f592f95
SM
21382013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2139
2140 Merge the specpdl and backtrace stacks. Make the structure of the
2141 specpdl entries more obvious via a tagged union of structs.
2142 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2143 (enum specbind_tag): New enum.
2144 (struct specbinding): Make it a tagged union of structs.
2145 Add a case for backtrace records.
2146 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2147 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2148 (backtrace_debug_on_exit): New accessors.
2149 (struct backtrace): Remove.
2150 (struct catchtag): Remove backlist field.
2151 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2152 Move to eval.c.
2153 (Flocal_variable_p): Speed up the common case where the binding is
2154 already loaded.
2155 * eval.c (backtrace_list): Remove.
2156 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2157 (set_backtrace_args, set_backtrace_nargs)
2158 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2159 (backtrace_next): New functions.
2160 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2161 (unwind_to_catch, internal_lisp_condition_case)
2162 (internal_condition_case, internal_condition_case_1)
2163 (internal_condition_case_2, internal_condition_case_n): Don't bother
2164 with backtrace_list any more.
2165 (Fsignal): Adjust to new backtrace format.
2166 (grow_specpdl): Move up.
2167 (record_in_backtrace): New function.
2168 (eval_sub, Ffuncall): Use it.
2169 (apply_lambda): Adjust to new backtrace format.
2170 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2171 data.c.
2172 (specbind): Adjust to new specpdl format. Simplify.
2173 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2174 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2175 backtrace format.
2176 (mark_backtrace): Remove.
2177 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2178 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2179 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2180 Use mark_specpdl.
2181 * profiler.c (record_backtrace): Use get_backtrace.
2182 (handle_profiler_signal): Use backtrace_top_function.
2183 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2184 accessor functions.
2185
c0342369
JD
21862013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2187
2188 * process.h (catch_child_signal): Declare.
2189
2190 * process.c (catch_child_signal): New function.
2191 (init_process_emacs): Call it.
2192
2193 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2194 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2195 NS_IMPL_COCOA.
2196 (x_set_cursor_type): Remove declaration.
2197 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2198 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2199 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2200 (ns_get_color): Use F suffix on float.
2201 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2202 (ns_get_rgb_color): Remove.
2203 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2204 (note_mouse_movement): x and y are CGFloat.
2205 (ns_draw_fringe_bitmap): Remove unused rowY.
2206 Change #if to COCOA && >= 10_6.
2207 (ns_draw_window_cursor): Remove unused overspill.
2208 (ns_draw_underwave): width and x are EamcsCGFloat.
2209 (ns_draw_box): thickness is CGFloat.
2210 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2211 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2212 if not in main thread.
2213 (ns_get_pending_menu_title, ns_check_menu_open)
2214 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2215 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2216 (sendFromMainThread:): New method.
2217 (changeFont:): size is CGFloat.
2218 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2219 Disable warning about permanent text.
2220 (characterIndexForPoint:): Adjust return type depending on GNUStep
2221 version.
2222 (mouseDown:): delta is CGFloat.
2223 (updateFrameSize): Remove unised variable f.
2224 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2225 Cast float to EmacsCGFloat.
2226 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2227 also to -1 when restoring.
2228 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2229 inside NS_IMPL_COCOA.
2230 (toggleFullScreen:): Put call to toggleFullScreen inside
2231 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2232 (setPosition:portion:whole:): por is CGFloat.
2233 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2234 (mouseDown:): Use CGFloat.
2235 (mouseDragged:): Remove unised variable edge.
2236 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2237
2238 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2239 of CGFloat differs.
2240 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2241 when NS_IMPL_GNUSTEP.
2242 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2243 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2244 (EmacsToolbar): Add clearAll. Add tag argument to
2245 addDisplayItemWithImage.
2246 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2247
2248 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2249
2250 * nsmenu.m (ns_update_menubar): Make static.
2251 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2252 (fillWithWidgetValue:): Add cast to SEL for setAction.
2253 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2254 (update_frame_tool_bar): Update code for GNUStep.
2255 (clearAll): New method.
2256 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2257 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2258 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2259 call to insertItemWithItemIdentifier.
2260 (validateVisibleItems): Fix indentation.
2261 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2262 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2263 UtilityWindow to aStyle, remove call to setStyleMask.
2264
2265 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2266
2267 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2268 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2269 Use F suffix on floats.
2270 (ns_char_width): Returns CGFloat.
2271 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2272 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2273 DPSxshow.
2274 (ns_glyph_metrics): CGFloat instead of float.
2275
a0eb10b3
JB
2276 * nsfns.m (x_set_foreground_color, x_set_background_color):
2277 Use EmacsCGFloat.
2278 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2279 remove unused variables.
2280 (Fns_read_file_name): Keep track if panel is for save.
2281 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2282 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2283 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2284 Just return the input if GNUStep.
c0342369
JD
2285 (x_screen_planes): Remove.
2286 (Fxw_color_values): Use EmacsCGFloat
2287 (Fns_display_monitor_attributes_list): Only get screen number for
2288 Cocoa.
ef099a94 2289 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2290 EmacsSavePanel.
2291 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2292 ns_directory_from_panel.
2293
da9aff11
PE
22942013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2295
2296 * process.c (handle_child_signal): Also use WCONTINUED.
2297 This is so that list-processes doesn't mistakenly list the process
2298 as stopped, when the process has actually been continued and is
2299 now running.
2300
0e64479a
PE
23012013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2302
fc186a96
PE
2303 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2304 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2305 not already configured.
2306
0e64479a
PE
2307 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2308
38b787fa
EZ
23092013-05-29 Eli Zaretskii <eliz@gnu.org>
2310
2311 * Makefile.in (mostlyclean): Remove *.res files.
2312
22513e52
SM
23132013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2314
2315 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2316 a buffer (bug#8447).
2317
6ef3db10
EZ
23182013-05-27 Eli Zaretskii <eliz@gnu.org>
2319
2320 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2321 display vector, and we backtrack, handle the case that the
2322 previous character position is also displayed from a display
2323 vector or covered by a display string or image. (Bug#14476)
2324
6799bb26
JD
23252013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2326
2327 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2328 (struct MonitorInfo, free_monitors): Remove.
2329 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2330 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2331 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2332 Qframes, Qsource.
2333
2334 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2335 (struct MonitorInfo, free_monitors): Remove.
2336 (ns_screen_name): Make static.
2337 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2338 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2339 Qframes, Qsource.
2340
2341 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2342 (struct MonitorInfo): New struct.
2343 (free_monitors, make_monitor_attribute_list): Declare.
2344
22513e52
SM
2345 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2346 New Lisp_Object:s.
6799bb26
JD
2347 (free_monitors, make_monitor_attribute_list): New functions.
2348 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2349 Qsource.
2350
38cd43eb
XF
23512013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2352
2353 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2354
2af0948d
SM
23552013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2356
a7eb9b0f
SM
2357 * keyboard.c: Apply keyboard decoding only to events that come directly
2358 from the tty, not from unread-command-events (bug#14368).
2359 (read_event_from_main_queue): New function, extracted from read_char).
2360 (read_decoded_char): Remove.
2361 (read_decoded_event_from_main_queue): New function to replace it.
2362 (read_char): Use it.
2363 (read_key_sequence): Use read_char rather than read_decoded_char.
2364
2af0948d
SM
2365 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2366
1413e9a5
BR
23672013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2368
2369 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2370
e6d2f155
KH
23712013-05-22 Kenichi Handa <handa@gnu.org>
2372
2373 The following changes are to fix the setting of
2374 buffer-file-coding-system on, for instance, C-x RET c unix RET
2375 _FILE_OF_DOS_EOL_TYPE_ RET.
2376
2377 * coding.h (struct coding_system): New member detected_utf8_chars.
2378
2379 * coding.c (detect_coding_utf_8): Count characters and check EOL
2380 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2381 BOM is there.
2382 (setup_coding_system): Do not initialize coding->head_ascii.
2383 (check_ascii): Do not set coding->eol_seen but update it. Do not
2384 call adjust_coding_eol_type here.
1413e9a5
BR
2385 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2386 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2387 of the found coding-system.
2388 (decode_coding_gap): Cancel previous change. Utilize the
2389 character numbers counted by detect_coding_utf_8. Fix detection
2390 of BOM for utf-8.
2391
ab56a6f4 23922013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2393
2394 * search.c (looking_at_1): Only set last_thing_searched if the match
2395 changed the match-data (bug#14281).
2396
ecc3c6ed
DA
23972013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2398
2399 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2400 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2401 (move_it_vertically_backward): Likewise.
2402
5ba8bf35
YM
24032013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2404
2405 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2406 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2407 (Fx_display_mm_width, Fx_display_mm_height):
2408 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2409
91e8418b 2410 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2411 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2412 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2413 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2414 (Fx_display_backing_store, Fx_display_visual_class)
2415 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2416 (Fx_display_grayscale_p, Fx_display_pixel_width)
2417 (Fx_display_pixel_height, Fx_display_planes)
2418 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2419 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2420 (Fx_display_mm_width, Fx_display_mm_height)
2421 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2422 height for all physical monitors as in X11.
2423
fc30d803
SM
2424 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2425 Return pixel width or height for all physical monitors as in X11.
91e8418b 2426
31ff141c
PE
24272013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2428
2429 Port --enable-gcc-warnings to clang.
2430 * bytecode.c (exec_byte_code):
2431 * regex.c:
2432 Redo diagnostic pragmas to pacify clang, too.
2433 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2434 * editfns.c (Fencode_time):
2435 * fileio.c (file_accessible_directory_p):
2436 * font.c (font_unparse_xlfd):
2437 Use '&"string"[index]' instead of '"string" + (index)'.
2438 * undo.c (user_error): Remove; unused.
2439
df065a0b
EZ
24402013-05-16 Eli Zaretskii <eliz@gnu.org>
2441
04d360e7
EZ
2442 * insdel.c (insert_1_both): Document the arguments, instead of
2443 referring to insert_1, which no longer exists.
2444
5bb98290
EZ
2445 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2446 some window, increment windows_or_buffers_changed, so that
2447 *Messages* display in that window is updated. (Bug#14408)
2448
df065a0b
EZ
2449 * w32.c: Include epaths.h.
2450 (init_environment): Use cmdproxy.exe without leading directories.
2451 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2452 case.
2453 (gettimeofday): Adjust signature and return value to Posix
2454 expectations.
2455
2456 * unexw32.c (open_output_file): Delete the existing emacs.exe
2457 before creating it, to break the hard link to the versioned
2458 executable.
2459
2460 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2461 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2462 (FIRSTFILE_OBJ): New variables.
2463 (W32_RES): Rename to EMACSRES. All users changed.
2464 (base_obj): Use $(CM_OBJ).
2465 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2466 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2467 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2468 $(W32_RES_LINK) before $(LIBES).
2469 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2470
1aa8d505
SM
24712013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2472
6e911150
SM
2473 * makefile.w32-in (DOC): Use just "DOC".
2474
2475 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2476
1aa8d505
SM
2477 * process.c: Export default filters and sentinels to Elisp.
2478 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2479 New constants.
2480 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2481 (Fset_process_sentinel, Fformat_network_address):
2482 Default to them instead of nil.
2483 (server_accept_connection): Sentinels can't be nil any more.
2484 (read_and_dispose_of_process_output): New function, extracted from
2485 read_process_output.
2486 (read_process_output): Use it; filters can't be nil.
2487 (Finternal_default_process_filter): New function, extracted from
2488 read_process_output.
2489 (exec_sentinel_unwind): Remove function.
2490 (exec_sentinel): Don't zilch sentinel while running.
2491 (status_notify): Sentinels can't be nil.
2492 (Finternal_default_process_sentinel): New function extracted from
2493 status_notify.
2494 (setup_process_coding_systems): Default filter is not nil any more.
2495 (syms_of_process): Export new Elisp functions and initialize
2496 new constants.
2497 * lisp.h (make_lisp_proc): New function.
2498
5ac2eb34
SM
24992013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2500
2501 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2502
eda9c7d7
EZ
25032013-05-14 Eli Zaretskii <eliz@gnu.org>
2504
2505 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2506 unless we know that the window w is a leaf window.
2507 Another attempt at solving bug#14062.
eda9c7d7 2508
8fdeaad5
JD
25092013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2510
2511 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2512 fdesc (Bug#14375).
2513
44aa9ee6
PE
25142013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2515
2516 * image.c (gif_load): Check that subimages fit (Bug#14345).
2517
759fd763
SM
25182013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2519
2520 * lread.c (skip_dyn_eof): New function.
2521 (read1): Use it to skip the end of a file in response to #@00.
2522
2523 * doc.c (get_doc_string): Slightly relax the sanity checking.
2524
4465bfb4
JD
25252013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2526
2527 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2528 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2529 (MonitorInfo): New struct.
2530 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2531 (Fns_display_monitor_attributes_list): New functions.
2532 (display-usable-bounds): Remove.
2533 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2534 Qsource.
2535
7583e2a0
PE
25362013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2539 (GTK_CHECK_VERSION): New macro, if not already defined.
2540 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2541 replaced by GTK_CHECK_VERSION.
2542
ad75d77e
PE
25432013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2544
2545 * xterm.h (GTK_PREREQ): New macro.
2546 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2547 to use this macro instead, for consistency and clarity.
2548
07525f77
EZ
25492013-05-08 Eli Zaretskii <eliz@gnu.org>
2550
2551 * xdisp.c (row_for_charpos_p): New function, with code of
2552 cursor_row_p, but accepts an additional argument CHARPOS instead
2553 of using a hardcoded PT.
2554 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2555 (row_containing_pos): Call row_for_charpos_p instead of partially
2556 doing the same. Fixes cursor positioning under longlines-mode
2557 when longlines-show-effect includes more than one newline, when
2558 moving the cursor vertically up.
2559
d901fc8d
JB
25602013-05-08 Juanma Barranquero <lekktu@gmail.com>
2561
2562 * makefile.w32-in (ACL_H): New macro.
2563 ($(BLD)/fileio.$(O)): Update dependencies.
2564
f269bc61
PE
25652013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2566
e7b41c4c 2567 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2568 * Makefile.in (LIB_ACL): New macro.
2569 (LIBACL_LIBS): Remove.
2570 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2571 * fileio.c: Include <acl.h>.
2572 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2573 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2574 !acl_errno_valid.
2575 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2576 it ourselves.
2577
f269bc61
PE
2578 * unexelf.c: Don't assume ElfW (Half) fits in int.
2579 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2580 when dealing with ElfW (Half) values, since they can exceed 2**31
2581 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2582 (entry_address): Omit unused NUM arg. All uses changed.
2583
a261c53e
JL
25842013-05-07 Juri Linkov <juri@jurta.org>
2585
2586 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2587 to the string converted from number with `Fnumber_to_string'.
2588 (Bug#14254)
2589
2b66427d
PE
25902013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2593 This fixes a problem introduced by my previous change.
2594
15acfe41
GM
25952013-05-07 Glenn Morris <rgm@gnu.org>
2596
2597 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2598
5ea03bf5
JD
25992013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2600
2601 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2602
e0c9d565
PE
26032013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 Static checking by GCC 4.8.0.
2606 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2607 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2608 (x_get_monitor_attributes_fallback)
2609 (x_get_monitor_attributes_xinerama)
2610 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2611 Define only if USE_GTK.
2612 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2613 (x_get_monitor_attributes_fallback): Omit unused locals.
2614 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2615 Use double, not float, to avoid mixed-mode floating point arithmetic.
2616
4e3f9230
YM
26172013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2618 Jan Djärv <jan.h.d@swipnet.se>
2619
2620 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2621 (XINERAMA_CFLAGS): New macros.
2622 (ALL_CFLAGS, LIBES): Use them.
2623
2624 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2625 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2626 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2627 (syms_of_xfns): DEFSYM them.
2628 (struct MonitorInfo): New struct.
2629 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2630 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2631 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2632 (x_get_monitor_attributes_xinerama): New functions.
2633 (Fx_display_monitor_attributes_list): New primitive.
2634 (syms_of_xfns): Defsubr it.
2635
2636 * xterm.h (x_display_info): Add Xatom_net_workarea and
2637 Xatom_net_current_desktop.
2638
2639 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2640 and dpyinfo->Xatom_net_current_desktop.
2641
05839b6a
EZ
26422013-05-06 Eli Zaretskii <eliz@gnu.org>
2643
2644 * xdisp.c (pos_visible_p): Use the special code for finding the
2645 beginning of a display property or overlay for any "replacing"
2646 display property, not just for display strings. This solves
2647 incorrect reporting of position by posn-at-point. (Bug#14241)
2648
dc4a2ee0
PE
26492013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2650
5ee94506
PE
2651 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2652 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2653 Verify that ElfW (Half) fits in int.
2654 (fatal): Use same signature as lisp.h.
2655 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2656 configure and build with -DUNEXELF_DEBUG without worrying about
2657 other modules that use DEBUG.
2658 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2659 possibly-wide integers now uses it instead of plain fprintf.
2660 (entry_address): New function, which avoids problems with 32-bit
2661 overflow on 64-bit hosts.
2662 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2663 (round_up): Don't assume the remainder fits in int.
2664 (find_section): Use bool for boolean. Simplify debug code.
2665 (unexec): Don't assume file sizes fit in int or size_t.
2666 Omit unnecessary trailing newline in 'fatal' format.
2667 Use strerror rather than outputting decimal error number.
2668 Remove unused code when emacs is not defined;
2669 this file relies on Emacs now.
2670 Don't assume e_phnum and e_shnum are positive.
2671
dc4a2ee0
PE
2672 * regex.c: Fix problems when DEBUG is defined.
2673 (extract_number, extract_number_and_incr): Define regardless of
2674 whether DEBUG is defined; that's simpler and makes the code less
2675 likely to go stale in the normal case when DEBUG is not defined.
2676 Return int rather than taking an int * arg. All callers changed.
2677 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2678 Remove, replacing with ...
2679 (DEBUG_PRINT): New macro. All callers changed.
2680 (DEBUG_COMPILES_ARGUMENTS): New macro.
2681 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2682 (print_compiled_pattern, print_double_string) [DEBUG]:
2683 Use prototype rather than old-style definition.
2684 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2685 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2686 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2687 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2688 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2689 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2690 This matters only when DEBUG is defined.
2691
14c7ed05
EZ
26922013-05-05 Eli Zaretskii <eliz@gnu.org>
2693
2694 * xdisp.c (set_iterator_to_next): Set the
2695 ignore_overlay_strings_at_pos_p flag only if we are _really_
2696 iterating over an overlay string, as indicated by the
2697 current.overlay_string_index member. (Bug#14306)
2698
e6076b1b
JD
26992013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2700
2701 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2702 to where it is used, to avoid autorelease issues (Bug#14050).
2703
cbee2131
PE
27042013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2707 * fileio.c (syms_of_fileio): Implement this.
2708 * filelock.c (create_lock_file): If symbolic links don't work, so
2709 we use a regular file as a lock file, do not fsync the lock file;
2710 it's not needed.
2711
30c7e542
SM
27122013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2713
2714 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2715 (syms_of_minibuf): Adjust accodingly.
2716 * lread.c (Fread):
2717 * callint.c (Fcall_interactively): Adjust calls accordingly.
2718
5bebd186
EZ
27192013-05-04 Eli Zaretskii <eliz@gnu.org>
2720
2721 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2722 w->contents is a buffer before computing everything else.
2723 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2724
2725 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2726 assertion violations. (Bug#14062)
2727
0fb0a4f3
DR
27282013-05-01 David Reitter <david.reitter@gmail.com>
2729
2730 * nsfns.m (ns_tooltip): Initialize.
2731
9e63b4a5
EZ
27322013-04-28 Eli Zaretskii <eliz@gnu.org>
2733
2734 * coding.c (decode_coding_gap): Don't remove the character before
2735 a newline unless it's a CR character. (Bug#14287)
2736
ad60824e
DN
27372013-04-28 Dan Nicolaescu <dann@gnu.org>
2738
2739 * dispextern.h (struct face): Move enum face_underline_type
2740 earlier so that bitfields can be in the same word.
2741
edbdcec0
JD
27422013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2743
2744 * nsfns.m (handlePanelKeys): New function.
2745 (EmacsOpenPanel:performKeyEquivalent:)
2746 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
2747 arrows/function/control and copy/paste keys (Bug#14296).
2748
0208ede7
JL
27492013-04-27 Juri Linkov <juri@jurta.org>
2750
2751 * callint.c (Fcall_interactively): Call `Qread_number' for
2752 interactive code letter `n' instead of using duplicate code.
2753 (Bug#14254)
2754
b8dd59f7
PE
27552013-04-27 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 * systime.h (make_timeval): Declare as 'const'.
2758
8bd722db
KH
27592013-04-27 Kenichi Handa <handa@gnu.org>
2760
2761 * font.c (font_open_entity): Always open a font of manageable
2762 size.
2763
13d0e56f 27642013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 2765
f780d632
PE
2766 Port better to AIX (Bug#14258).
2767 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
2768 to pacify AIX xlc.
2769
ec509856
KH
27702013-04-24 Kenichi Handa <handa@gnu.org>
2771
2772 * coding.c (decode_coding_iso_2022): When an invalid escape
2773 sequence is encountered, reset the invocation and designation
2774 status to the safest one.
2775
84fc48e5
PE
27762013-04-22 Paul Eggert <eggert@cs.ucla.edu>
2777
2778 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
2779 Without this fix, "make distclean" leaves stamp-h1 behind.
2780
806bda47
EC
27812013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
2782
2783 * w32fns.c (w32_fullscreen_rect): New function to compute the
2784 window rectangle for the given fullscreen mode.
2785 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
2786 longer tunes the window size. This keeps the window's edges flush
2787 with the screen and allows the taskbar to hide itself in fullboth.
2788
2789 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
2790 window decorations and uses the entire screen.
2791
2792 * w32term.h (w32_fullscreen_rect) Add prototype.
2793 (struct w32_output): Replace normal_width, normal_height,
2794 normal_top, and normal_left members with a single normal_placement
2795 struct.
2796 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
2797 Remove macros.
2798 (FRAME_NORMAL_PLACEMENT): New macro.
2799
9cc2810b
JB
28002013-04-16 Juanma Barranquero <lekktu@gmail.com>
2801
2802 * minibuf.c (Ftest_completion): Silence compiler warning.
2803
fd16b54c
EZ
28042013-04-15 Eli Zaretskii <eliz@gnu.org>
2805
2806 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 2807 bug#14062.
fd16b54c
EZ
2808
2809 * frame.h (WINDOW_FRAME): Protect macro and its argument with
2810 parentheses.
2811
2812 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
2813 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
2814 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
2815 parentheses where appropriate.
2816
9e3379a0
PE
28172013-04-14 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 * keyboard.c (timer_start_idle): Remove no-longer-used local.
2820
ddd6b685
EZ
28212013-04-14 Eli Zaretskii <eliz@gnu.org>
2822
2823 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
2824 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
2825 Mention in the doc string that setting these variables takes
2826 effect only after a call to set-window-buffer. (Bug#14200)
2827
29b79ba1
EZ
28282013-04-13 Eli Zaretskii <eliz@gnu.org>
2829
2830 * indent.c (Fvertical_motion): Don't consider display strings on
2831 overlay strings as display strings on the buffer position we
2832 started from. This prevents vertical cursor motion from jumping
2833 more than one line when there's an overlay string with a display
2834 property at end of line.
2835 Reported by Karl Chen <Karl.Chen@quarl.org> in
2836 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
2837
562c6ee9
SM
28382013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
2839
2840 * window.c (select_window): `record_buffer' even if window is
2841 already selected (bug#14191).
2842
fcc1fe85
EZ
28432013-04-11 Eli Zaretskii <eliz@gnu.org>
2844
2845 * window.c (Fwindow_end): Test more flags, including the buffer's
2846 last_overlay_modified flag, to determine whether the window's
2847 display is really up-to-date. Prevents the function from
2848 returning a stale value. (Bug#14170)
2849 (Fwindow_line_height): Fix the test for up-to-date-ness of the
2850 current matrix.
2851
f009190a
EZ
28522013-04-10 Eli Zaretskii <eliz@gnu.org>
2853
2854 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
2855 garbaged only if it is not already the top frame on its TTY.
2856 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
2857 there are GUI frames open in the same session. (Bug#13864)
2858
78ce603d
SM
28592013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
2860
2861 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
2862 of marking the idle timers directly.
2863
a8036e40
SM
28642013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
2865
2866 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
2867 tables (bug#14054).
2868
7ffe7ef6
SM
28692013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
2870
2871 * window.c (select_window): Don't record_buffer while the invariant is
2872 temporarily broken (bug#14161).
2873
2874 * fns.c (Fdelq): Don't assume !NILP => CONSP.
2875
7d9f6883
EZ
28762013-04-07 Eli Zaretskii <eliz@gnu.org>
2877
2878 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
2879
5406cfd9
RF
28802013-04-07 Romain Francoise <romain@orebokech.com>
2881
2882 Ignore additional platform-specific ACL errors (Bug#13702).
2883 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
2884 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
2885
95c0e83b
JD
28862013-03-31 Jan Djärv <jan.h.d@swipnet.se>
2887
2888 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
2889 f->output_data.ns.
2890
876da980
PE
28912013-04-07 Paul Eggert <eggert@cs.ucla.edu>
2892
2893 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
2894 This bug was introduced by my 2013-02-25 change that simplified
2895 data_start configuration. Without this change, on GNU/Linux
2896 an Emacs configured with --enable-profiling fails immediately
2897 due to a profiler signal.
2898 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
2899 with these flags. On platforms where special flags are needed
2900 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
2901 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
2902 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
2903
7452b7bd
DA
29042013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
2905
2906 Get rid of some platform-specific functions examining window
2907 system and its capabilities. This is a partial rework of the
2908 2013-04-05 change.
2909 * lisp.h (have_menus_p): Remove prototype. This function is
2910 replaced with platform-independent window_system_available.
2911 (check_window_system): Move to...
2912 * frame.h (decode_window_system_frame, window_system_available):
2913 ...here, add new prototypes.
2914 * frame.c (window_system_available, decode_window_system_frame):
2915 New functions.
2916 (check_window_system): Platform-independent now.
2917 * xterm.h (x_in_use): Remove declaration.
2918 (check_x_frame):
2919 * w32term.h (check_x_frame):
2920 * nsterm.h (check_x_frame): Remove prototypes. This function
2921 is replaced with platform-independent decode_window_system_frame.
2922 * msdos.c (have_menus_p): Remove.
2923 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
2924 Remove platform-specific functions. Use check_window_system,
2925 decode_window_system_frame and check_ns_display_info where
2926 appropriate. Minor style and comment tweaks.
2927 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
2928 (check_x_frame): Likewise.
2929 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
2930 Likewise.
2931 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
2932 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
2933 * xmenu.c, xselect.c: All related users changed.
2934
251e9147
KH
29352013-04-03 Kenichi Handa <handa@gnu.org>
2936
2937 The following changes is to optimize the code for reading UTF-8
2938 files.
2939
562c6ee9 2940 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
2941 changed. Check EOL format. Do not call adjust_coding_eol_type
2942 here.
2943 (check_utf_8): New function.
2944 (adjust_coding_eol_type): Do nothing if already adjusted.
2945 (detect_coding): Compare the return value of check_ascii with
2946 coding->src_bytes. Call adjust_coding_eol_type if necessary.
2947 (decode_coding_gap): Optimize for valid UTF-8.
2948
8bc369d4
KH
29492013-03-21 Kenichi Handa <handa@gnu.org>
2950
2951 * coding.c (syms_of_coding): Cancel previous change.
2952
2953 * insdel.c (insert_from_gap): Fix previous change.
2954
73931ad1
DA
29552013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
2956
2957 Consistently use platform-specific function to detect window system.
2958 * lisp.h (check_window_system): New prototype. This function is
2959 going to replace check_x, check_w32 and check_ns.
2960 (have_menus_p): Mention msdos.c in comment.
2961 * fontset.c (check_window_system_func): Remove. Adjust all users.
2962 * fontset.h (check_window_system_func): Remove prototype.
2963 * nsterm.h (check_ns):
2964 * xterm.h (check_x):
2965 * w32term.h (check_w32): Likewise.
2966 * menu.c (Fx_popup_menu): Use check_window_system.
2967 * msdos.c (check_window_system): Define for MS-DOS.
2968 * nsfns.m (check_window_system): Define for NS. Adjust all users.
2969 * w32fns.c (check_window_system): Likewise for MS-Windows.
2970 * xfns.c (check_window_system): Likewise for X.
2971 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
2972 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
2973
7216e43b
PE
29742013-04-02 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 Prefer < to > in range checks such as 0 <= i && i < N.
2977 This makes it easier to visualize quantities on a number line.
2978 This patch doesn't apply to all such range checks,
2979 only to the range checks affected by the 2013-03-24 change.
2980 This patch reverts most of the 2013-03-24 change.
2981 * alloc.c (xpalloc, Fgarbage_collect):
2982 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
2983 * character.c (string_escape_byte8):
2984 * charset.c (read_hex):
2985 * data.c (cons_to_unsigned):
2986 * dispnew.c (update_frame_1):
2987 * doc.c (Fsubstitute_command_keys):
2988 * doprnt.c (doprnt):
2989 * editfns.c (hi_time, decode_time_components):
2990 * fileio.c (file_offset):
2991 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2992 * font.c (font_intern_prop):
2993 * frame.c (x_set_alpha):
2994 * gtkutil.c (get_utf8_string):
2995 * indent.c (check_display_width):
2996 * keymap.c (Fkey_description):
2997 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
2998 * lread.c (read1):
2999 * minibuf.c (read_minibuf_noninteractive):
3000 * process.c (wait_reading_process_output):
3001 * search.c (Freplace_match):
3002 * window.c (get_phys_cursor_glyph):
3003 * xdisp.c (redisplay_internal):
3004 * xsmfns.c (smc_save_yourself_CB):
3005 Prefer < to > for range checks.
3006 * dispnew.c (sit_for): Don't mishandle NaNs.
3007 This fixes a bug introduced in the 2013-03-24 change.
3008 * editfns.c (decode_time_components): Don't hoist comparison.
3009 This fixes another bug introduced in the 2013-03-24 change.
3010
92759988
DA
30112013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3012
3013 * frame.h (struct frame): Drop scroll_bottom_vpos
3014 member becaue all real users are dead long ago.
3015 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3016 * xdisp.c (redisplay_internal): Adjust user.
3017
9a1971bb
GM
30182013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3019
f38ab167
JD
3020 * nsmenu.m (showAtX:Y:for:): setLevel to
3021 NSPopUpMenuWindowLevel (Bug#13998).
3022
6d01f1fe
JD
30232013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3024
3025 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3026 (ns_check_pending_open_menu): Declare.
3027
3028 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3029 (x_activate_menubar): Update the menu with title that matches
3030 ns_get_pending_menu_title, and call
3031 ns_check_pending_openmenu (Bug#12698).
3032 (menuWillOpen:): New method.
3033 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3034
3035 * nsterm.m (menu_will_open_state, menu_mouse_point)
3036 (menu_pending_title): New varaibles.
3037 (ns_get_pending_menu_title, ns_check_menu_open)
3038 (ns_check_pending_open_menu): New functions.
3039
781f4782
DA
30402013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3041
3042 * indent.c (current_column_bol_cache): Remove leftover which is not
3043 used in Fmove_to_column any more.
3044 (current_column, scan_for_column): Adjust users.
3045 * keyboard.c (last_point_position_buffer, last_point_position_window):
3046 Remove leftovers which are not used for recording undo any more.
3047 (command_loop_1, syms_of_keyboard): Adjust users.
3048 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3049 redisplay_window any more.
3050 (move_it_to): Adjust user.
3051
1921c31b
JB
30522013-03-29 Juanma Barranquero <lekktu@gmail.com>
3053
3054 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3055 Update dependencies.
3056
717b8bcd
SM
30572013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3058
3059 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3060 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3061 forward references.
3062
e74aeda8
DA
30632013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3064
3065 * window.h (struct window): Replace hchild, vchild and buffer slots
3066 with the only contents slot. This is possible because each valid
3067 window may have either the child window (in vertical or horizontal
3068 combination) or buffer to display (for the leaf window). Using that,
3069 a lof of operations to traverse and/or change window hierarchies may
3070 be simplified. New member horizontal is used to distinguish between
3071 horizontal and vertical combinations of internal windows.
3072 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3073 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3074 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3075 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3076 Use contents slot, not buffer, where appropriate.
3077 (wset_combination): New function.
3078 (wset_buffer): Add eassert.
3079 (Fframe_first_window): Simplify the loop reaching first window.
3080 (Fwindow_buffer): Use WINDOW_LEAF_P.
3081 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3082 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3083 (unshow_buffer): Convert initial debugging check to eassert.
3084 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3085 (make_parent_window, window_resize_check, window_resize_apply)
3086 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3087 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3088 Adjust to match struct window changes.
3089 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3090 (mark_window_cursors_off, count_windows, get_leaf_windows)
3091 (foreach_window_1): Simplify the loop.
3092 * alloc.c (mark_object): Do not check for the leaf window because
3093 internal windows has no glyph matrices anyway.
3094 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3095 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3096 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3097 (build_frame_matrix_from_window_tree, mirror_make_current)
3098 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3099 (update_window_tree, set_window_update_flags): Simplify the loop.
3100 (sync_window_with_frame_matrix_rows): Enforce live window.
3101 Use contents slot, not buffer, where appropriate.
3102 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3103 and WINDOW_HORIZONTAL_COMBINATION_P.
3104 (make_frame_visible_1): Simplify the loop.
3105 Use contents slot, not buffer, where appropriate.
3106 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3107 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3108 (expose_window_tree): Likewise.
3109 Use contents slot, not buffer, where appropriate.
3110 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3111 to avoid deleted windows. Use contents slot instead of buffer.
3112 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3113 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3114 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3115 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3116
121ab1cd
EZ
31172013-03-28 Eli Zaretskii <eliz@gnu.org>
3118
ef454cf7
EZ
3119 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3120 identify the reasons for assertion violations in bug#14062 and
3121 similar ones.
21e930f8
EZ
3122 (Fx_show_tip): Fix compilation error under
3123 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3124
121ab1cd
EZ
3125 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3126 Reported by <rzl24ozi@gmail.com>.
3127
5c89ca24
DA
31282013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3129
3130 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3131 start marker...
562c6ee9
SM
3132 (unwind_with_echo_area_buffer): ...to restore it here.
3133 This is needed to ensure that...
5c89ca24
DA
3134 (redisplay_window): ...both window markers are valid here,
3135 which is verified by eassert.
3136 * editfns.c (save_excursion_save): Do not assume that
3137 selected_window always displays the buffer.
c7f53895
DA
3138 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3139 Fix comment.
5c89ca24 3140
f557c1b1
SM
31412013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3142
3143 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3144 the upcase table.
3145
40693bba 31462013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3147
3148 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3149
c86f791f
EZ
31502013-03-27 Eli Zaretskii <eliz@gnu.org>
3151
3152 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3153 since MinGW's w32api headers do. This avoids compiler warnings.
3154
3155 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3156 if already defined.
3157
c6e72e17
EZ
31582013-03-26 Eli Zaretskii <eliz@gnu.org>
3159
3160 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3161
54e95010
JD
31622013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3163
3164 * gtkutil.c (style_changed_cb): Check if frame is live and an
3165 X frame (Bug#14038).
3166
b88b62de
EZ
31672013-03-26 Eli Zaretskii <eliz@gnu.org>
3168
a18d7de6
EZ
3169 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3170 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3171 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3172 MinGW64.
8f5e14c8
EZ
3173 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3174 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3175
b88b62de
EZ
3176 Fix incompatibilities between MinGW.org and MinGW64 headers.
3177 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3178
3179 * w32.c (REPARSE_DATA_BUFFER): Guard with
3180 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3181
c074e458
JD
31822013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3183
3184 * xterm.c: Include X11/XKBlib.h
3185 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3186
908589fd
AS
31872013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3188
3189 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3190 written backwards.
3191 * blockinput.h (input_blocked_p): Likewise.
3192 * bytecode.c (exec_byte_code): Likewise.
3193 * callproc.c (call_process_kill, call_process_cleanup)
3194 (Fcall_process): Likewise.
3195 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3196 (Fccl_execute_on_string): Likewise.
3197 * character.c (string_escape_byte8): Likewise.
3198 * charset.c (read_hex): Likewise.
3199 * cm.c (calccost): Likewise.
3200 * data.c (cons_to_unsigned): Likewise.
3201 * dired.c (directory_files_internal, file_name_completion):
3202 Likewise.
3203 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3204 (sit_for): Likewise.
3205 * doc.c (Fsubstitute_command_keys): Likewise.
3206 * doprnt.c (doprnt): Likewise.
3207 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3208 * emacsgtkfixed.c: Likewise.
3209 * fileio.c (file_offset, Fwrite_region): Likewise.
3210 * floatfns.c (Fexpt, fmod_float): Likewise.
3211 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3212 Likewise.
3213 * font.c (font_intern_prop): Likewise.
3214 * frame.c (x_set_alpha): Likewise.
3215 * gtkutil.c (get_utf8_string): Likewise.
3216 * indent.c (check_display_width): Likewise.
3217 * intervals.c (create_root_interval, rotate_right, rotate_left)
3218 (split_interval_right, split_interval_left)
3219 (adjust_intervals_for_insertion, delete_node)
3220 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3221 (merge_interval_right, merge_interval_left, copy_intervals)
3222 (set_intervals_multibyte_1): Likewise.
3223 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3224 * keymap.c (Fkey_description): Likewise.
3225 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3226 * lread.c (openp, read_integer, read1, string_to_number):
3227 Likewise.
3228 * menu.c (ensure_menu_items): Likewise.
3229 * minibuf.c (read_minibuf_noninteractive): Likewise.
3230 * print.c (printchar, strout): Likewise.
3231 * process.c (create_process, Faccept_process_output)
3232 (wait_reading_process_output, read_process_output, send_process)
3233 (wait_reading_process_output): Likewise.
3234 * profiler.c (make_log, handle_profiler_signal): Likewise.
3235 * regex.c (re_exec): Likewise.
3236 * regex.h: Likewise.
3237 * search.c (looking_at_1, Freplace_match): Likewise.
3238 * sysdep.c (get_child_status, procfs_ttyname)
3239 (procfs_get_total_memory): Likewise.
3240 * systime.h (EMACS_TIME_VALID_P): Likewise.
3241 * term.c (dissociate_if_controlling_tty): Likewise.
3242 * window.c (get_phys_cursor_glyph): Likewise.
3243 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3244 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3245 Likewise.
3246 * xfns.c (Fx_window_property): Likewise.
3247 * xmenu.c (set_frame_menubar): Likewise.
3248 * xselect.c (x_get_window_property, x_handle_dnd_message):
3249 Likewise.
3250 * xsmfns.c (smc_save_yourself_CB): Likewise.
3251 * xterm.c (x_scroll_bar_set_handle): Likewise.
3252
2bf7d27a
DA
32532013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3254
3255 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3256 to be optional or nil. Adjust comment and convert it to docstring.
3257 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3258 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3259
a9ebfa0b
PE
32602013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 Static checking by GCC 4.8-20130319.
3263 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3264 * process.c (Fset_process_datagram_address)
3265 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3266 * xdisp.c (get_char_face_and_encoding):
3267 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3268 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3269 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3270
4f3576ee
KB
32712013-03-24 Ken Brown <kbrown@cornell.edu>
3272
789b5e9a
KB
3273 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3274 fix compilation on 64-bit Cygwin, where underscores are not
3275 automatically prepended.
3276
4f3576ee
KB
3277 * w32term.c (w32_initialize): Silence compiler warning.
3278
b5b7745f
EZ
32792013-03-23 Eli Zaretskii <eliz@gnu.org>
3280
cdc0d0bd
EZ
3281 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3282 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3283 variables, to save and restore frame dimensions.
3284 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3285 after returning from a 'fullscreen' configuration.
3286 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3287 to avoid races between the main thread and the input thread.
3288
3289 * w32term.h (struct w32_output): New members normal_width,
3290 normal_height, normal_top, normal_left, and prev_fsmode.
3291 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3292 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3293 members of a frame.
3294
b5b7745f
EZ
3295 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3296 'fullscreen' parameter. Always record previous width and height
3297 of the frame, except when switching out of maximized modes, so
3298 that they could be restored correctly, instead of resetting to the
3299 default frame dimensions. Send SC_RESTORE command to the frame,
3300 unless we are going to send SC_MAXIMIZE, to restore the frame
3301 resize hints in the mouse pointer shown by the window manager.
3302 (Bug#14032)
3303
3304 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3305
3306 * lisp.h (get_frame_param): Adjust conditions for prototype
3307 declaration.
3308
a3454eed
KB
33092013-03-22 Ken Brown <kbrown@cornell.edu>
3310
3311 * unexcw.c: Drop unneeded inclusion of w32common.h.
3312 (report_sheap_usage): Declare.
3313 (read_exe_header): Add magic numbers for x86_64.
3314 (fixup_executable): Fix printf format specifier for unsigned long
3315 argument.
3316
5a49b79c
DA
33172013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3318
3319 * frame.h (struct frame): Put menu_bar_window under #ifdef
3320 because this member is not needed when X toolkit is in use.
3321 (fset_menu_bar_window):
3322 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3323 (free_glyphs, update_frame):
3324 * xdisp.c (expose_frame): Likewise.
3325 (display_menu_bar): Likewise. Remove redundant eassert.
3326 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3327 toolkit is in use.
3328
d6723bf7
PE
33292013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3330
7b1123d8
PE
3331 Use functions and constants to manipulate Lisp_Save_Value objects.
3332 This replaces code that used macros and strings and token-pasting.
3333 The change makes the C source a bit easier to follow,
3334 and shrinks the Emacs executable a bit.
3335 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3336 (make_save_value): Change 1st arg from string to enum. All callers
3337 changed.
3338 (INTX): Remove.
3339 (mark_object): Use if, not #if, for GC_MARK_STACK.
3340 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3341 (XSAVE_OBJECT): Now functions, not macros.
3342 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3343 the constant was never used.
3344 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3345 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3346 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3347 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3348 New constants.
3349 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3350 type3 with a single member save_type. All uses changed.
3351 (save_type, set_save_pointer, set_save_integer): New functions.
3352 * print.c (PRINTX): Remove.
3353
d6723bf7
PE
3354 * alloc.c: Remove redundant static declarations.
3355
5f24fa51
DA
33562013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3357
3358 * window.h (struct window): Convert left_col, top_line, total_lines
3359 and total_cols from Lisp_Objects to integers. Adjust comments.
3360 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3361 Remove.
3362 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3363 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3364 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3365 Adjust users where appropriate.
3366
42143acd
DA
33672013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3368
3369 * frame.h (struct frame): Drop resx and resy because the same data is
3370 available from window system-specific output context. Adjust users.
562c6ee9
SM
3371 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3372 New functions to provide defaults when no window system available.
42143acd 3373 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3374 (NUMVAL): Move from xdisp.c.
42143acd
DA
3375 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3376 (Ffont_face_attributes, Fopen_font):
3377 * image.c (gs_load):
3378 * w32font.c (fill_in_logfont):
3379 * xdisp.c (calc_pixel_width_or_height):
3380 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3381 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3382
c0a17406
KH
33832013-03-20 Kenichi Handa <handa@gnu.org>
3384
3385 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3386 to 1 (temporary workaround until a bug related to ASCII
3387 optimization is fixed).
3388
095d384d
DA
33892013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3390
3391 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3392 Signal error if window is not internal. Adjust docstring.
3393 (delete_all_child_windows): Use combination_limit to save the buffer.
3394 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3395 * print.c (syms_of_print): Initialize debugging output not here...
3396 (init_print_once): ...but in a new function here.
3397 * lisp.h (init_print_once): Add prototype.
3398 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3399
748fa866
DA
34002013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3401
3402 * window.c (window_resize_check, window_resize_apply)
3403 (window_from_coordinates, recombine_windows, set_window_buffer)
3404 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3405 (Fsplit_window_internal, Fdelete_window_internal)
3406 (freeze_window_starts): Use bool for booleans.
3407 * window.h (window_frame_coordinates, resize_frame_windows)
3408 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3409
81519fd2
SM
34102013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3411
3412 * dispnew.c (bitch_at_user): Use `user-error'.
3413
6db423a9
KB
34142013-03-17 Ken Brown <kbrown@cornell.edu>
3415
3416 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3417 as return type of image_background. (Bug#13981)
3418 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3419
8f2906f5
JD
34202013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3421
960ce480 3422 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3423 (ns_select): Don't return with result uninitialized.
960ce480 3424
8f2906f5
JD
3425 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3426 and getDirectory.
3427
81519fd2
SM
3428 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3429 New functions.
8f2906f5
JD
3430 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3431 directories. If filename is nil, get directory name (Bug#13932).
3432 Use getFilename and getDirectory.
3433 (getFilename, getDirectory): New methods for EmacsSavePanel and
3434 EmacsOpenPanel.
3435 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3436
cded56c1
PE
34372013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3438
3439 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3440
251e9147 34412013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3442
3443 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3444 (adjust_after_replace): Make it back to static. Delete the third
3445 arg text_at_gap_tail. Cancel the code for handling it.
3446
3447 * coding.h (struct coding_system): New member eol_seen.
3448
3449 * coding.c (detect_ascii): New function.
3450 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3451 when the source bytes are actually scanned. On detecting for
3452 coding_category_utf_8_auto, call detect_ascii instead of scanning
3453 source bytes directly.
3454 (produce_chars): Call insert_from_gap with the new arg 0.
3455 (encode_coding): Likewise.
3456 (decode_coding_gap): Control ASCII optimization by the variable
3457 disable_ascii_optimization instead of #ifndef .. #endif.
3458 Deccode EOL format according to coding->eol_seen.
3459 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3460 variable.
3461
8a44e6d1
KH
3462 * lisp.h (adjust_after_replace): Cancel externing it.
3463 (insert_from_gap): Adjust prototype.
3464
5f795e34
EZ
34652013-03-15 Eli Zaretskii <eliz@gnu.org>
3466
3467 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3468 FULLSCREEN_MAXIMIZED. (Bug#13935)
3469
f258b4be
DA
34702013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3471
3472 * region-cache.c (find_cache_boundary, move_cache_gap)
3473 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3474 Simplify debugging check and convert to eassert. Adjust comment.
3475 (pp_cache): Put under ENABLE_CHECKING.
3476
a5cc4dde
EZ
34772013-03-14 Eli Zaretskii <eliz@gnu.org>
3478
3479 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3480 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3481 and WM_ACTIVATEAPP.
3482 (w32fullscreen_hook): If the frame is visible, reset
3483 f->want_fullscreen flag after changing the frame size. If the
3484 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3485 (Bug#13953)
3486
3fc5e44a
DC
34872013-03-13 Daniel Colascione <dancol@dancol.org>
3488
3489 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3490 too so that these builds can use Cygwin's file conversion
3491 functions. (We've been building and linking cygw32.o all along
3492 and just not using it.)
3493
47d7532e
PE
34942013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3495
3496 File synchronization fixes (Bug#13944).
3497 * Makefile.in (LIB_FDATASYNC): New macro.
3498 (LIBES): Use it.
3499 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3500 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3501 Don't worry about HAVE_FSYNC, since a substitute fsync is
3502 available if the system lacks one.
3503 (Fwrite_regin): Retry fsync if interrupted.
3504
c7ffccaf
EZ
35052013-03-13 Eli Zaretskii <eliz@gnu.org>
3506
4e2df81d 3507 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3508 activated, call w32fullscreen_hook, to make sure the new frame
3509 dimensions are in effect. (Bug#13937)
3510
8a7debc1
DA
35112013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3512
3513 * xdisp.c (init_iterator): Simplify because both character and byte
3514 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3515 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3516 character and byte positions can be obtained from marker.
8a7debc1 3517
7fd8c501
PE
35182013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3519
d9df6f40
PE
3520 Static checking by Sun C 5.12.
3521 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3522 * bytecode.c (exec_byte_code):
3523 * dispnew.c (init_display):
3524 * eval.c (error):
3525 * fileio.c (Fsubstitute_in_file_name):
3526 * keyboard.c (Fevent_convert_list):
3527 * keymap.c (Fsingle_key_description):
3528 * term.c (maybe_fatal, fatal):
3529 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3530 * xsmfns.c (Fhandle_save_session):
3531 Omit unreachable code.
3532 * keymap.c (map_keymap_char_table_item): Cast void * to
3533 a function pointer type; the C Standard requires this.
3534
7fd8c501
PE
3535 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3536 Include <sys/param.h> unconditionally, as that works elsewhere and
3537 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3538 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3539 and FreeBSD now.
3540
a020afb9 3541See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3542
3543;; Local Variables:
3544;; coding: utf-8
aac0c6e3
MR
3545;; End:
3546
ab422c4d 3547 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3548
3549 This file is part of GNU Emacs.
3550
3551 GNU Emacs is free software: you can redistribute it and/or modify
3552 it under the terms of the GNU General Public License as published by
3553 the Free Software Foundation, either version 3 of the License, or
3554 (at your option) any later version.
3555
3556 GNU Emacs is distributed in the hope that it will be useful,
3557 but WITHOUT ANY WARRANTY; without even the implied warranty of
3558 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3559 GNU General Public License for more details.
3560
3561 You should have received a copy of the GNU General Public License
3562 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.