* image.c (imagemagick_load_image): Make animated pictures work.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
71530c97
LMI
12013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
4ce82fb8
LMI
3 * image.c (imagemagick_load_image): Make animated pictures work.
4 There's still some problems with background color settings, though
5 (bug#14700).
6
71530c97
LMI
7 * decompress.c (unwind_decompress): Always restore point.
8
01c3051f
PE
92013-08-14 Paul Eggert <eggert@cs.ucla.edu>
10
aab1fcdf
PE
11 * xdisp.c (cursor_type_changed): Now static.
12
01c3051f
PE
13 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
14 Use changed. This avoids the need to call xmalloc and for the
15 caller to call xfree, and avoids memory leaks in some situations.
16
2084152a
DA
172013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
18
19 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
20 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
21 (redisplay_window): If window_end_valid is cleared due to non-zero
22 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
23 so do not call to try_cursor_movement for that window.
2084152a 24
02455cb6
DA
252013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
26
27 * window.h (struct window): Convert window_end_pos and
28 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
29 (wset_window_end_pos, wset_window_end_vpos): Remove.
30 * dispnew.c (adjust_glyph_matrix):
31 * window.c (Fwindow_end, replace_window, set_window_buffer)
32 (make_window):
33 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
34 (set_vertical_scroll_bar, redisplay_window, try_window)
35 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
36 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
37 (note_mouse_highlight): Adjust users.
38 (try_cursor_movement): Likewise. Convert old precondition to eassert.
39 Add comment.
40
da5707e8
DA
412013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
42
43 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
44 * image.c (imagemagick_filename_hint): Use `const char *' and
45 prefer SSDATA to SDATA to avoid warnings.
46
25554267
DA
472013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
48
49 Cleanup window fringes, margins and scroll bars adjustments.
50 * window.c (set_window_fringes, set_window_margins)
51 (set_window_scroll_bars, apply_window_adjustment): New functions.
52 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
53 (Fset_window_scroll_bars): Use them.
54
38a2c910
DA
552013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
56
57 * window.h (struct window): Convert scroll_bar_width
58 from Lisp_Object to integer. Adjust comment.
59 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
60 Adjust users.
61 * window.c (wset_scroll_bar_width): Remove.
62 (make_window): Initialize scroll_bar_width.
63 (Fsplit_window_internal): Use direct assignment.
64 (Fset_window_configuration, save_window_save):
65 Convert Lisp_Object to integer and back where appropriate.
66 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
67 bar was actually changed, and mention this in docstring.
68
2d065031
PE
692013-08-13 Paul Eggert <eggert@cs.ucla.edu>
70
71 * decompress.c: Minor simplifications.
72 (Fzlib_decompress_region): Don't bother verifying
73 that avail_out <= UINT_MAX, as that was confusing.
74 Mention the restriction in a comment instead.
75 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
76
a5bd5abb
JD
772013-08-13 Jan Djärv <jan.h.d@swipnet.se>
78
79 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
80 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
81
66e7901a
LMI
822013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
83
84 * image.c (imagemagick_filename_hint): Check for errors in the
85 alist structure.
86
2fa611b7
EZ
872013-08-13 Eli Zaretskii <eliz@gnu.org>
88
89 * window.c (Fwindow_margins): Return nil when there's no marginal
90 area, as per the documented API.
91
92 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
93 Fmake_vector, as scroll bar's struct members are not all Lisp
94 objects now. This avoids crashes in GC.
95
96 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
97 bool, so its address could be taken.
98
8259030d
LMI
992013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
100
101 * image.c (imagemagick_filename_hint): New function to possibly
102 apply `image-content-type-suffixes'.
103 (imagemagick_load_image): Use it.
104
866c710e
EZ
1052013-08-13 Eli Zaretskii <eliz@gnu.org>
106
107 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
108 if loading zlib failed.
109
f10490f0
JD
1102013-08-13 Jan Djärv <jan.h.d@swipnet.se>
111
96311be7
JD
112 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
113 2013-08-13 checkin below. Change bool to BOOL, rule is:
114 All Obj-C code uses BOOL, except for interfaces callable from C.
115
f10490f0
JD
116 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
117
c8ae93b0
DA
1182013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
119
120 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
121 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
122 bool instead of BOOL.
123 * w32term.h (struct scroll_bar): Convert fringe_extended_p
124 from Lisp_Object to bitfield. Adjust comment.
125 * w32term.c (x_scroll_bar_create): Adjust user.
126 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
127 * xterm.c (XTset_vertical_scroll_bar): Likewise.
128 Use bool for boolean.
129 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
130 to `unsigned int' when defining a bitfield.
131
53b64418
PE
1322013-08-13 Paul Eggert <eggert@cs.ucla.edu>
133
134 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
135
eeaf9bf3
DA
1362013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
137
138 * window.h (struct window): Convert left_margin_cols and
139 right_margin_cols from Lisp_Objects to integers. Adjust comment.
140 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
141 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
142 Adjust users.
143 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
144 Adjust comment.
145 (showing_window_margins_p, update_window_line, update_frame_1):
146 * fringe.c (draw_fringe_bitmap_1):
147 * xdisp.c (window_box_width): Adjust users.
148 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
149 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
150 Use direct assignment.
151 (Fset_window_configuration, save_window_save, Fwindow_margins):
152 Convert Lisp_Object to integer and back where appropriate.
153 (Fset_window_margins): Adjust user. Return t if any margin
154 was actually changed, and mention this in docstring.
155
956720af
XF
1562013-08-13 Xue Fuqiao <xfq.free@gmail.com>
157
f73f4ce6 158 * syntax.c (forward_word):
956720af
XF
159 * cmds.c (forward_char, backward_char): Mention the optional argument.
160
9e37ee3b
DA
1612013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
162
163 * window.h (struct window): Convert left_fringe_width
164 and right_fringe_width from Lisp_Objects to integers.
165 Adjust comment.
166 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
167 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
168 * window.c (wset_left_fringe_width, wset_right_fringe_width):
169 Remove.
170 (make_window): Initialize new integer fields to -1.
171 (Fsplit_window_internal): Use direct assignment.
172 (Fset_window_configuration, save_window_save): Convert
173 Lisp_Object to integer and back where appropriate.
174 (Fset_window_fringes): Adjust user. Return t if any fringe
175 was actually changed, and mention this in docstring.
176
e4375ca7
DA
1772013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
178
179 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
180 * nsfns.m (x_set_cursor_type):
181 * w32fns.c (x_set_cursor_type):
182 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
183 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 184
a45543bc
DA
1852013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
186
187 * font.c (clear_font_cache): New function, stripped from...
188 (Fclear_font_cache): ...here, which now uses the function
189 above. Adjust comment.
190 * font.h (clear_font_cache): Add prototype.
191 * xfaces.c (clear_face_cache): Use clear_font_cache.
192
ae966a86
DA
1932013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
194
195 * window.c (Fset_window_start): Compare `w', not `window' because
196 `w' might not be equal to `window' after call to decode_live_window.
197
297a545b
PE
1982013-08-12 Paul Eggert <eggert@cs.ucla.edu>
199
200 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
201 This fixes a problem introduced by the Bug#15035 patch
202 when using GPG. Reported by Herbert J. Skuhra.
203
aa942e2b
EZ
2042013-08-12 Eli Zaretskii <eliz@gnu.org>
205
206 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
207 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
208 not yet initialized.
209
7699d09e
LMI
2102013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
211
212 * decompress.c (Fzlib_decompress_region): Support zlib
213 decompression, too, and rename.
214
1d238bc7
PE
2152013-08-12 Paul Eggert <eggert@cs.ucla.edu>
216
217 Minor zlib configuration tweaks.
218 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
219 Don't assume presence of fn_inflateInit2_ zlib internal function.
220
8a44a184
LMI
2212013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
222
223 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
224 include the zlib prefix.
225
594a4307
EZ
2262013-08-12 Eli Zaretskii <eliz@gnu.org>
227
228 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
229 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
230 define static variables that are pointers to zlib functions to be
231 dynamically loaded.
232 (init_zlib_functions) [WINDOWSNT]: New function.
233 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
234 New macros.
235 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
236 macros instead of invoking the zlib functions directly.
237 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
238 Szlib_available_p.
239
d2e113bc
DA
2402013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
241
242 Avoid looping over all frame windows to freeze and unfreeze.
243 * window.h (struct window): Drop frozen_window_start_p.
244 (freeze_window_starts): Drop prototype.
245 * frame.h (struct frame): New frozen_window_starts flag.
246 (FRAME_WINDOWS_FROZEN): New macro.
247 * window.c (freeze_window_start, freeze_window_starts):
248 Remove.
249 (select_window, replace_window): Adjust users.
250 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
251 (window_frozen_p): New function.
252 (redisplay_window): Use it.
253
94fcd171
PE
2542013-08-12 Paul Eggert <eggert@cs.ucla.edu>
255
256 Fix some fd issues when running subprocesses (Bug#15035).
257 Fix bugs that can leak files or file descriptors on errors.
258 Don't unlink open temp files, as that's hard for users to diagnose
259 when things go awry (e.g., temp disk exhausted).
260 Don't bother to lock temp files. Check for invalid recursion.
261 * callproc.c (synch_process_fd): Remove. All uses removed.
262 (synch_process_tempfile): New var or macro.
263 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
264 New constants.
265 (record_kill_process): New arg, the temp name. All callers changed.
266 (delete_temp_file): Now just a simple wrapper around unlink.
267 (call_process_kill): New arg, the call_process_fd array.
268 Close them all. Clear synch_process_pid. Remove the temp file,
269 or arrange for it to be removed.
270 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
271 that's been moved to synch_process_tempfile. Caller changed.
272 Do not remove the tempfile; that's now call_process_kill's
273 responsibility.
274 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
275 call_process_kill; the caller now does that.
276 (call_process_cleanup): Do not close the process fd; that's now
277 call_process_kill's responsibility.
278 (Fcall_process): Implement via new function call_process, which
279 has most of the old body of Fcall_process, but with a different API.
280 (call_process): New function that does not open or close filefd if
281 it is nonnegative. Record which fds need to be closed, and let
282 call_process_kill close (and remove the tempfile, on MSDOS) on error.
283 Signal an error if invoked recursively (could be done via a hook).
284 Simplify creation of the tempfile in the MSDOS case.
285 Don't create the output file until after checking for the executable.
286 Report any failure to open /dev/null.
287 Don't open /dev/null for writing twice; once is enough.
288 Don't create pipe if all output is being discarded or sent to file.
289 Don't worry about setting up the coding system or reading from the
290 pipe if all output is being discarded.
291 Hoist fd_error local into top level, to lessen block nesting.
292 Don't record deleted pid here; now done by Fcall_process_region.
293 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
294 and note its success in synch_process_tempfile.
295 Do not leak resources when child_setup fails.
296 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
297 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
298 (create_temp_file): Now returns open fd, with an additional
299 Lisp_Object * argument to return the name. All callers changed.
300 Do not close the file; rewind it instead, and leave it open for
301 the caller. Do not lock the temp file. Unwind-protect the file
302 and the file-descriptor.
303 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
304 If an asynchrounous process, record it here, not in call_process.
305 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
306 * eval.c (set_unwind_protect): New function.
307 * fileio.c (write_region): New function, generalized from the
308 old Fwrite_region. Do not lock temp files.
309 (Fwrite_region): Use it.
310 * lisp.h (set_unwind_protect, write_region): New decls.
311 * process.c: Include <verify.h>.
312 (make_process): Mark fds as initially closed.
313 (deleted_pid_list): Now a list of pid-filename pairs.
314 All uses changed.
315 (close_process_fd): New function.
316 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
317 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
318 New constants. Verify that their number matches PROCESS_OPEN_FDS.
319 (create_process, create_pty, Fmake_serial_process)
320 (server_accept_connection): Record which fds need to be closed,
321 and let deactivate_process close them.
322 (Fmake_network_process): Do not discard the unwind-protect
323 until it's safe to do so.
324 (deactivate_process): Close the fds opened by create_process etc.
325 (Fprocess_send_eof): Adjust to new way of recording open fds.
326 Report an error if /dev/null can't be opened, instead of aborting.
327 * process.h (PROCESS_OPEN_FDS): New constant.
328 (struct Lisp_Process): New member open_fds.
329 (record_kill_process, record_deleted_pid): Adjust signatures.
330 (record_deleted_pid): Move decl here ...
331 * syswait.h (record_deleted_pid): ... from here.
332
d0e615c3
PE
3332013-08-11 Paul Eggert <eggert@cs.ucla.edu>
334
335 * decompress.c: Fix bugs with large buffers and weird inputs.
336 Tune a bit. Reindent as per usual Emacs style.
337 (BUFFER_SIZE): Remove.
338 (Fdecompress_gzipped_region): Do not mishandle input buffers with
339 more than UINT_MAX bytes. Decompress into the gap instead of into
340 an auto buffer, as this should avoid copying. Return nil if
341 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
342 set immediate_quit; we shouldn't trust zlib code that much.
343
313546eb
LMI
3442013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
345
99a32242
LMI
346 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
347 errors, and really move the gap to where we want it.
348
313546eb
LMI
349 * lisp.h: Include decompress.c support.
350
351 * emacs.c (main): Include decompress.c support.
352
353 * Makefile.in: Include -lz if present.
354
d2d699ac
JD
3552013-08-11 Jan Djärv <jan.h.d@swipnet.se>
356
f90e3ebd
JD
357 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
358 (initWithTitle:): Initialize frame to 0.
359 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
360 (fillWithWidgetValue:frame:): Renamed from
361 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
362
363 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
364 fillWithWidgetValue:frame:
365
423d3b3f
JD
366 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
367 remove memory leak warnings.
368
d2d699ac
JD
369 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
370 (ns_check_menu_open): Handle menu == nil. Remove assignment to
371 menu_pending_title.
372
373 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
374 (x_activate_menubar): Update the whole menu.
375 (trackingNotification:): Call ns_check_menu_open if tracking ends.
376 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
377 current event is not NSSystemDefined (Bug#15001).
378 Call ns_check_menu_open only if trackingMenu is 2.
379 (menuDidClose:): New method, decrease trackingMenu.
380 (fillWithWidgetValue:setDelegate:): New method.
381 (fillWithWidgetValue:): Call the above.
382
383 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
384
7d652d97
PE
3852013-08-11 Paul Eggert <eggert@cs.ucla.edu>
386
387 Omit some unnecessary casts.
388 Many of these go back to the old pre-C89 days, when they may have
389 been needed, but we've been assuming C89 or later for a while now.
390 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
391 (live_float_p, live_misc_p, live_vector_p):
392 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
393 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
394 (defvar_per_buffer):
395 * callint.c (Fcall_interactively):
396 * doc.c (Fsubstitute_command_keys):
397 * filelock.c (get_boot_time):
398 * frame.c (xrdb_get_resource):
399 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
400 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
401 (xg_get_file_name_from_selector, menuitem_destroy_callback)
402 (menuitem_highlight_callback, menu_destroy_callback)
403 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
404 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
405 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
406 (xg_tool_bar_help_callback, tb_size_cb):
407 * image.c (xpm_alloc_color, png_read_from_memory)
408 (png_read_from_file, png_load_body, our_memory_skip_input_data)
409 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
410 (syms_of_image):
411 * keymap.c (describe_map):
412 * nsfns.m (Fns_display_monitor_attributes_list):
413 * nsmenu.m (process_dialog:):
414 * nsterm.m (hold_event):
415 * process.c (wait_reading_process_output):
416 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
417 * scroll.c (do_direct_scrolling, scrolling_1):
418 * termcap.c (tgetent):
419 * window.c (check_window_containing, add_window_to_list)
420 (freeze_window_starts):
421 * xdisp.c (compare_overlay_entries, vmessage):
422 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
423 (x_get_monitor_attributes_xrandr)
424 (Fx_display_monitor_attributes_list, x_display_info_for_name)
425 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
426 * xfont.c (xfont_match, xfont_open):
427 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
428 (menubar_selection_callback, menu_position_func)
429 (popup_selection_callback, create_and_show_popup_menu)
430 (dialog_selection_callback, create_and_show_dialog):
431 * xrdb.c (x_get_string_resource):
432 (main) [TESTRM]:
433 * xsmfns.c (x_session_check_input):
434 * xterm.c (x_draw_glyphless_glyph_string_foreground)
435 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
436 (xaw_jump_callback, xaw_scroll_callback):
437 Omit unnecessary casts.
438
9acc1074
PE
4392013-08-10 Paul Eggert <eggert@cs.ucla.edu>
440
441 Minor string-length refactoring.
442 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
443 * frame.c (make_monitor_attribute_list):
444 Prefer build_string to strlen + make_string.
445
361c0eb8
JD
4462013-08-10 Jan Djärv <jan.h.d@swipnet.se>
447
448 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
449 don't check minor_code (Bug#14417).
450
14ba0822
EZ
4512013-08-09 Eli Zaretskii <eliz@gnu.org>
452
453 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
454 vertical positions instead. This avoids calling MATRIX_ROW with
455 row numbers that are possibly beyond valid limits. (Bug#15064)
456
309f24d1
DA
4572013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
458
459 Use xstrdup and build_unibyte_string where applicable.
460 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
461 * xfns.c (x_window):
462 * xrdb.c (x_get_customization_string):
463 * xterm.c (xim_initialize):
464 * w32fns.c (w32_window): Use xstrdup.
465 (w32_display_monitor_attributes_list):
466 * emacs.c (init_cmdargs):
467 * keyboard.c (PUSH_C_STR):
468 * nsfont.m (nsfont_open):
469 * sysdep.c (system_process_attributes):
470 * w32.c (system_process_attributes):
471 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
472
55902276
EZ
4732013-08-09 Eli Zaretskii <eliz@gnu.org>
474
475 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
476 variables of these types so that GDB would know about them, as aid
477 for debugging fatal exceptions. (Bug#15024) See also
478 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
479 discussions.
480
10bf7f5a
JD
4812013-08-08 Jan Djärv <jan.h.d@swipnet.se>
482
483 * nsterm.m (ns_update_begin): Don't change clip path if it would be
484 larger than the NSWindow (Bug#14934).
485
65620264
DA
4862013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Redesign redisplay interface to drop global variable updated_window.
489 Always pass currently updated window as a parameter to update routines.
490 * dispextern.h (updated_window): Remove declaration.
491 (struct redisplay_interface): Pass window parameter to
492 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
493 and after_update_window_hook.
494 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
495 Adjust prototypes.
496 * dispnew.c (updated_window): Remove.
497 (redraw_overlapped_rows, update_marginal_area, update_text_area)
498 (update_window_line): Adjust to match redisplay interface changes.
499 * nsterm.m (ns_update_window_begin, ns_update_window_end)
500 (ns_scroll_run, ns_after_update_window_line):
501 * w32term.c (x_update_window_begin, x_update_window_end)
502 (x_after_update_window_line, x_scroll_run):
503 * xterm.c (x_update_window_begin, x_update_window_end)
504 (x_after_update_window_line, x_scroll_run):
505 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
506 Likewise. Adjust comments where appropriate.
507 (x_cursor_to): Simplify because this is always called during window
508 update (but install debugging check anyway).
509 (expose_window): Check must_be_updated_p flag to see whether this
510 function is called during window update.
511
628fdc56
DA
5122013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
513
514 Do not reset window modification event counters excessively.
515 These leftovers and poor man's tricky methods to catch extra
516 redisplay's attention are no longer needed.
517 * frame.c (set_menu_bar_lines_1):
518 * minibuf.c (read_minibuf_unwind):
519 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
520 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
521 (window_scroll_line_based, Fset_window_configuration):
522 * xdisp.c (redisplay_window): Do not reset last_modified and
523 last_overlay_modified counters.
524
8fd9c92e
JD
5252013-08-07 Jan Djärv <jan.h.d@swipnet.se>
526
527 * xselect.c (x_send_client_event): Set send_event and serial, memset
528 data.l as it might be bigger than data.b. Use 24 bit mask to
529 XSendEvent (Bug#15034).
530
0ee18172
EZ
5312013-08-07 Eli Zaretskii <eliz@gnu.org>
532
533 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
534 for TTY frames that are not the top frame on their console.
535 (Bug#14616)
536
16ddd1a6
MR
5372013-08-07 Martin Rudalics <rudalics@gmx.at>
538
539 * w32term.c (w32fullscreen_hook): Really maximize frame when
540 asked for (Bug#14841).
541
d2a95ffb
DA
5422013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
543
544 Prefer selected_window to Fselected_window, likewise for frames.
545 * buffer.c (Fbuffer_swap_text):
546 * data.c (Fvariable_binding_locus):
547 * window.c (run_window_configuration_change_hook): Adjust users.
548 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
549 Use decode_live_frame.
550
170da1ec
DA
5512013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
552
553 Be more careful if selected window shows the buffer other than current,
554 use window_outdated only if this is not so. This change should also
555 address some weird issues discussed in Bug#13012.
556 * window.h (window_outdated): New prototype.
557 * window.c (window_outdated): Now here. Convert from static and
558 always assume window's buffer.
559 (Fwindow_end, Fwindow_line_height): Use it.
560 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
561 and always assume window's buffer.
562 (redisplay_window): Adjust user.
e5eefe9b 563 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
564 check whether mode line should be updated only if selected window
565 shows current buffer.
566 (run_window_scroll_functions): Use eassert for debugging check.
567 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
568
56b5d5b1
DA
5692013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
570
571 * window.c (window_scroll, window_scroll_pixel_based)
572 (window_scroll_line_based): Use bool for booleans.
573
2878ba7e
PE
5742013-08-06 Paul Eggert <eggert@cs.ucla.edu>
575
576 * process.c: Fix minor off-by-one issues in descriptor counts.
577 This shouldn't fix any real bugs, but it cleans up the code a bit.
578 (max_process_desc, max_input_desc): -1, not 0, means none.
579 All uses changed.
580 (delete_input_desc): New function.
581 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
582 (deactivate_process): Scan backwards when recomuting max_process_desc;
583 that should be faster.
584 (init_process_emacs): Initialize max_input_desc.
585
e30b79c1
DA
5862013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
587
588 Use region cache to speedup bidi_find_paragraph_start.
589 * buffer.h (struct buffer): New member bidi_paragraph_cache.
590 Rename cache_long_line_scans to cache_long_scans.
591 * buffer.c (bset_cache_long_line_scans): Rename to
592 bset_cache_long_scans.
593 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
594 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
595 into account.
596 (syms_of_buffer): Rename cache-long-line-scans to
597 cache-long-scans. Adjust docstring.
598 * search.c (newline_cache_on_off):
599 * indent.c (width_run_cache_on_off): Adjust users.
600 * bidi.c (bidi_paragraph_cache_on_off): New function.
601 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
602 * insdel.c (prepare_to_modify_buffer): Invalidate
603 bidi_paragraph_cache if enabled.
604
00012b86
DA
6052013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
606
607 Invalidate region caches only if buffer text is going to be changed.
608 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
609 (modify_text): ...new prototype.
610 (prepare_to_modify_buffer_1): New prototype.
611 * textprop.c (modify_region): Rename to...
612 (modify_text_properties): ...new function.
613 (add_text_properties_1, set_text_properties, Fremove_text_properties)
614 (Fremove_list_of_text_properties): Adjust users.
615 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
616 (modify_text): ...new function.
617 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
618 (prepare_to_modify_buffer_1): ...new function.
619 * casefiddle.c (casify_region):
620 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
621 (Ftranspose_regions): Use modify_text.
622
dc6c0eda
SM
6232013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 * lisp.mk (lisp): Add nadvice.elc.
626
8f3a2c26
DA
6272013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
628
629 New macro to iterate over live buffers similar to frames.
630 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
631 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
632 Declare buffer-related variables here to offload lisp.h.
633 * buffer.c (Vbuffer_alist): Adjust comment.
634 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
635 (other_buffer_safely):
636 * data.c (store_symval_forwarding):
637 * dispnew.c (Fframe_or_buffer_changed_p):
638 * fileio.c (Fdo_auto_save):
639 * filelock.c (unlock_all_files):
640 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
641
e0fdb694
PE
6422013-08-04 Paul Eggert <eggert@cs.ucla.edu>
643
644 Fix some minor races in hosts lacking mkostemp (Bug#15015).
645 * callproc.c (create_temp_file):
646 * filelock.c (create_lock_file):
647 Assume mkostemp, since it's now provided by Gnulib.
648
63f5c6c2
EZ
6492013-08-04 Eli Zaretskii <eliz@gnu.org>
650
651 * w32.c (mkostemp): New function.
652 (mktemp): Remove, no longer used. Most of the code reused in
653 mkostemp. (Bug#15015)
484ab239 654 (mktemp): Don't undef.
63f5c6c2 655
f0b79313
DA
6562013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
657
658 * dispnew.c (glyph_matrix_count, glyph_pool_count):
659 Move under GLYPH_DEBUG and ENABLE_CHECKING.
660 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
661 (free_glyph_pool, check_glyph_memory): Likewise for
662 all users. Adjust comments where appropriate.
663
98f638d6
PE
6642013-08-03 Paul Eggert <eggert@cs.ucla.edu>
665
666 * composite.h: Minor fixups.
667 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
668 to fix a misspelling, and change it to an inline function while
669 we're at it (it need not be a macro). All uses changed.
670 (composition_method, composition_valid_p):
671 Rewrite to avoid assignments in if-conditions.
672
75c59fb3
DA
6732013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
674
675 Do not use global Lisp_Object in composition macros.
676 * composite.h (composition_temp): Remove declaration.
677 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
678 (composition_method, composition_valid_p): ...inline functions.
416a3e01 679 (compose_region): Remove the leftover.
75c59fb3
DA
680 * composite.c (composition_temp): Remove.
681 (run_composition_function, update_compositions)
682 (composition_compute_stop_pos, composition_adjust_point)
683 (Ffind_composition_internal):
684 * coding.c (handle_composition_annotation):
685 * xdisp.c (handle_composition_prop, check_point_in_composition):
686 Related users changed.
687
a10c8269
DA
6882013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
689
690 Drop FRAME_PTR typedef.
691 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
692 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
693 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
694 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
695 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
696 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
697 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
698 All related users changed.
699
a104f656
SM
7002013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
701
702 * eval.c (default_toplevel_binding): New function.
703 (Fdefvar): Use it.
704 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
705 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
706 (syms_of_eval): Export them.
707 * data.c (Fdefault_value): Micro cleanup.
708 * term.c (init_tty): Use "false".
709
4b5c9326
DA
7102013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
711
712 Fix X GC leak in GTK and raw (no toolkit) X ports.
713 * xterm.c (x_free_frame_resources): If white and black relief
714 GCs are allocated, always free them here.
715 * xfns.c (x_make_gc): Omit redundant initialization.
716 * widget.c (create_frame_gcs): Remove the leftover.
717 (EmacsFrameDestroy): Do nothing because all GCs are now freed
718 in x_free_frame_resources.
719
b19aa636
JD
7202013-08-02 Jan Djärv <jan.h.d@swipnet.se>
721
722 * nsterm.m (windowWillResize:toSize:): Only change title if
723 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
724 modifying it.
725 (viewDidEndLiveResize): New method.
726
727 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
728 inside NS_IMPL_COCOA.
729
af1f7e06
DA
7302013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
731
732 * insdel.c (adjust_after_replace, replace_range, del_range_2):
733 Do not check whether undo is enabled because record_insert and
734 record_delete does that themselves.
735
65b02bb9
DA
7362013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
737
738 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
739 member which is not really used any more.
740 (FRAME_XIC_BASE_FONTNAME): Remove.
741 * xfns.c (xic_free_fontset): Adjust user.
742 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
743 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
744 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
745 (xdialog_show): Use eassert for debugging check.
7ee0f047 746 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 747
6318cde0
PE
7482013-08-01 Paul Eggert <eggert@cs.ucla.edu>
749
750 * fileio.c, fns.c (merge): Move extern decl from here ...
751 * lisp.h (merge): ... to here.
752
6c1a09ba
DA
7532013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Fix last font-related change.
756 * w32font.h (w32font_list_internal, w32font_match_internal):
757 Fix prototype.
758 * w32uniscribe.c (uniscribe_list, uniscribe_match):
759 (uniscribe_list_family): Adjust to match font API change.
760 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
761 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
762
f8c20208
DA
7632013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
764
765 * frame.h (FRAME_MOUSE_UPDATE):
766 * nsterm.m (ns_frame_up_to_date): Omit redundant check
767 whether hlinfo->mouse_face_mouse_frame is non-NULL.
768
fdb396e2
DA
7692013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
770
771 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
772 * font.h (struct font_driver): Change list, match, and list_family
773 functions to accept struct frame * as first arg.
774 * font.c (font_score, font_compare, font_sort_entities): Remove
775 prototypes.
776 (font_sort_entities, font_list_entities, font_select_entity):
777 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
778 match font API change.
779 * xfont.c (xfont_list, xfont_match, xfont_list_family):
780 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
781 * ftxfont.c (ftxfont_list, ftxfont_match):
782 * xftfont.c (xftfont_list, xftfont_match):
783 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
784 * w32font.c (w32font_list, w32font_match, w32font_list):
785 (w32font_list_internal, w32_font_match_internal): Likewise.
786 * xfaces.c (Fx_family_fonts): Adjust user.
787
52b8a085
DA
7882013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
789
790 Do not use pure Xism x_wm_set_icon_position in non-X ports.
791 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
792 only if HAVE_X_WINDOWS is in use.
793 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
794 * nsterm.m (x_wm_set_icon_position): Remove no-op.
795 * w32term.c (x_wm_set_icon_position): Likewise.
796 * w32fns.c (x_icon): Adjust user.
797
c791c18e
DA
7982013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
799
800 * xterm.c (last_mouse_press_frame): Remove the
801 leftover which is not really used any more.
802 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
803 (x_flush): Call XFlush once per each X display, not frame.
804 This is better because this code always unconditionally skips
805 non-X frames in Vframe_list and issues the only XFlush if we
806 have more than one X frame on the same X display.
2f935d86
DA
807 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
808 Use bool for booleans.
809 (x_draw_glyph_string_background, cvt_string_to_pixel):
810 (cvt_pixel_dtor): Drop unnecessary prototypes.
811 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 812
f435830e
DA
8132013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
814
815 Drop unnecessary functions that deals with frame pixel size.
816 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
817 (x_pixel_height): Drop prototypes.
818 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
819 (x_pixel_height): Drop implementations.
820 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
821 which should be always valid for window frame.
822 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
823 * w32menu.c (Fx_popup_dialog):
824 * xmenu.c (Fx_popup_dialog): Likewise for both.
825
84231434
DA
8262013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
827
828 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
829 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
830 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
831 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
832 and mention nil frame in docstring.
84231434 833
959067a1
DA
8342013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
835
836 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
837 (x_figure_window_size): Likewise. Adjust to return long.
838 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
839 (toplevel): Move Qterminal_live_p to...
840 * terminal.c (toplevel): ...here, make it static, and...
841 (syms_of_terminal): ...DEFSYM here.
842 * frame.h (Qterminal_live_p): Remove declaration.
843 (make_frame, x_figure_window_size): Adjust prototype.
844 * nsfns.m (Fx_create_frame): Use long for window flags.
845
f4b169ce
PE
8462013-07-30 Paul Eggert <eggert@cs.ucla.edu>
847
848 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
849 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
850 Do not assume that emacs_close (INT_MAX) is a no-op.
851
bee6a2c7
DA
8522013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
853
854 * xfaces.c (make_face_cache): For struct face_cache, prefer
855 xmalloc to xzalloc and so avoid redundant call to memset.
856 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
857
d7e6881a
DA
8582013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
859
860 * fringe.c (draw_window_fringes, update_window_fringes)
861 (compute_fringe_widths):
862 * w32term.c (x_draw_glyph_string):
863 * window.c (candidate_window_p, Frecenter):
864 * xfaces.c (realize_basic_faces, realize_default_face)
865 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
866 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
867 * xfns.c (x_set_cursor_color, xic_free_xfontset):
868 * xmenu.c (Fx_menu_bar_open_internal):
869 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
870 * xsettings.c (xft_settings_event):
871 * xterm.c (x_draw_glyph_string, x_had_errors_p):
872 Use bool for booleans. Adjust style and comments where
873 appropriate.
874 * dispextern.h (draw_window_fringes, update_window_fringes)
875 (compute_fringe_widths):
876 * xterm.h (x_had_errors_p): Adjust prototype.
877
ec3058af
DA
8782013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
879
880 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
881 CHECK_LIST. Rewrite the loop to avoid useless local variable.
882
218e0637
DA
8832013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
884
885 * fns.c (toplevel): Remove comment before Fsafe_length because
886 it checks for QUIT.
887
e560aba9
PE
8882013-07-28 Paul Eggert <eggert@cs.ucla.edu>
889
890 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
891
2e5ce5de
EZ
8922013-07-28 Eli Zaretskii <eliz@gnu.org>
893
894 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
895 frame which got the message is still alive, before dereferencing
896 its pointer. (Bug#14970)
897
898 * frame.c (delete_frame): Test "this" frame's minibuffer window to
899 be a live window, before using it as such. (Bug#14970)
900
e95da6d3
EZ
9012013-07-27 Eli Zaretskii <eliz@gnu.org>
902
903 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
904 w32_detect_focus_change instead of doing part of its job by hand.
905 This fixes the problem whereby FOCUS_OUT events were not sent to
906 the event queue.
907
a8f93651
EZ
9082013-07-26 Eli Zaretskii <eliz@gnu.org>
909
fec92060
EZ
910 * process.c (Fprocess_list): Doc fix.
911
a8f93651
EZ
912 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
913 being re-exposed only if it didn't ask to become visible.
914 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
915 was previously iconified. (Bug#14841)
916 (x_iconify_frame): Mark the frame iconified.
917
d5a7a9d9
PE
9182013-07-26 Paul Eggert <eggert@cs.ucla.edu>
919
920 Fix minor problems found by static checking.
921 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
922 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
923
56ea7291
SM
9242013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
925
926 * eval.c (set_specpdl_old_value): New function.
927 (unbind_to): Minor simplification.
928 (get_backtrace_frame): New function.
929 (Fbacktrace_frame): Use it. Add `base' argument.
930 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
931 (syms_of_eval): Export backtrace-eval.
932 * xterm.c (x_focus_changed): Simplify.
933
9d611ffe
PE
9342013-07-25 Paul Eggert <eggert@cs.ucla.edu>
935
936 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
937
999c74e3
EZ
9382013-07-24 Eli Zaretskii <eliz@gnu.org>
939
940 * xdisp.c (redisplay_window): Instead of moving point out of
941 scroll margin, reject the force_start method, and try scrolling
942 instead. (Bug#14780)
943
198fa217
KB
9442013-07-24 Ken Brown <kbrown@cornell.edu>
945
946 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
947 (Bug#14944).
948
53840e55
PE
9492013-07-24 Paul Eggert <eggert@cs.ucla.edu>
950
951 * eval.c (Fprogn): Do not check that BODY is a proper list.
952 This undoes the previous change. The check slows down the
953 interpreter, and is not needed to prevent a crash. See
954 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
955
60967f56
GM
9562013-07-23 Glenn Morris <rgm@gnu.org>
957
958 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
959
9ca960e2
PE
9602013-07-23 Paul Eggert <eggert@cs.ucla.edu>
961
a29c3e6d
PE
962 Port to GNU/Linux systems with tinfo but not ncurses.
963 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
964 to decide whether ncurses is being used. Without this change,
965 GCC complains about tgetent not being declared, on a system
966 that has tinfo installed but ncurses not installed.
967
f274311c
PE
968 * eval.c (Fprogn): Check that BODY is a proper list.
969
16b0520a
PE
970 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
971 * data.c (Fsetq_default):
972 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
973 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
974 (Fcondition_case):
975 Tune by taking advantage of the fact that ARGS is always a list
976 when a function is declared to have UNEVALLED args.
977
9ca960e2
PE
978 * emacsgtkfixed.c: Port to GCC 4.6.
979 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
980
afacaa1b
JB
9812013-07-23 Juanma Barranquero <lekktu@gmail.com>
982
983 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
984 here to silence compiler warnings.
985
368a85a4
PE
9862013-07-22 Paul Eggert <eggert@cs.ucla.edu>
987
988 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
989 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
990 from messing up Emacs's 'struct frame' (Bug#14923).
991
f4e891b5
PE
9922013-07-21 Paul Eggert <eggert@cs.ucla.edu>
993
994 * alloc.c (make_save_ptr_ptr): Define this function.
995 It was inadvertently omitted. It's needed only if
996 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
997
96c8b65e
JD
9982013-07-21 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1001 frame have focus (Bug#14895).
1002
ee010797
PE
10032013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 Avoid vfork-related deadlock more cleanly.
1006 * callproc.c (child_setup): When the child's exec fails, output
1007 the program name, as that's more useful. Use O_NONBLOCK to avoid
1008 deadlock.
1009 * process.c (create_process_1): Remove; no longer needed.
1010 (create_process): Remove timer hack; no longer needed, now that
1011 the child avoids deadlock.
1012
f0398ec1 10132013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1014
1015 * image.c (Fimage_flush): Fix doc typo.
1016
b2a069c2
PE
10172013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1018
6496aec9
PE
1019 Fix array bounds violation when pty allocation fails.
1020 * process.c (PTY_NAME_SIZE): New constant.
1021 (pty_name): Remove static variable; it's now auto.
1022 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1023 Take pty_name as an arg rather than using a static variable.
1024 All callers changed.
1025 (create_process): Recover pty_flag from process, not from volatile local.
1026 (create_pty): Stay inside array even when pty allocation fails.
1027 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1028
b2a069c2
PE
1029 * lread.c (Fload): Avoid initialization only when lint checking.
1030 Mention that it's needed only for older GCCs.
1031
99107004
KH
10322013-07-20 Kenichi Handa <handa@gnu.org>
1033
1034 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1035 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1036
6b1b199d
AS
10372013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1038
1039 * lread.c (Fload): Avoid uninitialized warning.
1040
4195afc3
PE
10412013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1042
3f5bef16
PE
1043 Fix some minor file descriptor leaks and related glitches.
1044 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1045 (create_lock_file): Use write, not emacs_write.
1046 * image.c (slurp_file, png_load_body):
1047 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1048 (server_accept_connection):
1049 Don't leak an fd on memory allocation failure.
1050 * image.c (slurp_file): Add a cheap heuristic for growing files.
1051 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1052 as that's what the other routines do. Maybe input need not be
1053 blocked at all, but it's better to be consistent.
1054 Avoid undefined behavior when strlen is zero.
1055
4195afc3
PE
1056 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1057 (NSTATICS): Now a constant; doesn't need to be a macro.
1058
a1aeeffe
RS
10592013-07-19 Richard Stallman <rms@gnu.org>
1060
1061 * coding.c (decode_coding_utf_8): Add simple loop for fast
1062 processing of ASCII characters.
1063
63b34baa
PE
10642013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1067
621dd9ac
EZ
10682013-07-19 Eli Zaretskii <eliz@gnu.org>
1069
1070 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1071 unportable 'struct x_display_info'.
1072 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1073 is a portable type.
1074
1396ac86
PE
10752013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1076
ab9980cd
PE
1077 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1078 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1079 or fscanf fails.
1080 (system_process_attributes): Prefer plain char to unsigned char
1081 when either will do. Clean up properly if interrupted or if
1082 memory allocations fail. Don't assume sscanf succeeds. Remove
1083 no-longer-needed workaround to stop GCC from whining. Read
1084 command-line once, instead of multiple times. Check read status a
1085 bit more carefully.
1086
1396ac86
PE
1087 Fix obscure porting bug with varargs functions.
1088 The code assumed that int is treated like ptrdiff_t in a vararg
1089 function, which is not a portable assumption. There was a similar
1090 -- though these days less likely -- porting problem with various
1091 assumptions that pointers of different types all smell the same as
1092 far as vararg functions is conserved. To make this problem less
1093 likely in the future, redo the API to use varargs functions.
1094 * alloc.c (make_save_value): Remove this vararg function.
1095 All uses changed to ...
1096 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1097 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1098 New functions.
1099 (make_save_ptr): Rename from make_save_pointer, for consistency with
1100 the above. Define only on platforms that need it. All uses changed.
1101
4d19d194
PE
11022013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 * keyboard.c: Try to fix typos in previous change.
1105 (DISPLAY_LIST_INFO): New macro.
1106 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1107 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1108
945c5bb1
JB
11092013-07-18 Juanma Barranquero <lekktu@gmail.com>
1110
1111 * keyboard.c (kbd_buffer_get_event):
1112 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1113 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1114
f4b1eb36
PE
11152013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1116
5e679a2c
PE
1117 * filelock.c: Fix unlikely file descriptor leaks.
1118 (get_boot_time_1): Rework to avoid using emacs_open.
1119 This doesn't actually fix a leak, but is better anyway.
1120 (read_lock_data): Use read, not emacs_read.
1121
a8cd4836
PE
1122 * doc.c: Fix minor memory and file descriptor leaks.
1123 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1124 (get_doc_string, Fsnarf_documentation):
1125 Fix file descriptor leak on error.
1126
ef30e638
PE
1127 * term.c: Fix minor fdopen-related file descriptor leaks.
1128 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1129 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1130
f4b1eb36
PE
1131 * charset.c: Fix file descriptor leaks and errno issues.
1132 Include <errno.h>.
1133 (load_charset_map_from_file): Don't leak file descriptor on error.
1134 Use plain record_xmalloc since the allocation is larger than
1135 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1136 of entries.
1137 * eval.c (record_unwind_protect_nothing):
1138 * fileio.c (fclose_unwind):
1139 New functions.
1140 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1141 The replacement doesn't block input, but that no longer seems
1142 necessary.
1143
b648c163
PE
11442013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1145
a0931322
PE
1146 * lread.c: Fix file descriptor leaks and errno issues.
1147 (Fload): Close some races that leaked fds or streams when 'load'
1148 was interrupted.
1149 (Fload, openp): Report error number of last nontrivial failure to open.
1150 ENOENT counts as trivial.
1151 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1152 New functions.
1153 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1154 now that the function is always called with a nonnegative arg.
1155 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1156 All uses replaced with ...
1157 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1158
b648c163
PE
1159 A few more minor file errno-reporting bugs.
1160 * callproc.c (Fcall_process):
1161 * doc.c (Fsnarf_documentation):
1162 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1163 * process.c (set_socket_option):
1164 Don't let a constructor trash errno.
1165 * doc.c: Include <errno.h>.
1166
b1dc4084
JB
11672013-07-16 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1170
c43843aa
PE
11712013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1172
50a30cce
PE
1173 Fix w32 bug with call-process-region (Bug#14885).
1174 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1175 to Fcall_process when the input is empty. This simplifies the
1176 code a bit. It makes no difference on POSIXish platforms but
1177 apparently it fixes a bug on w32.
1178
44e18199 1179 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1180 * fileio.c (close_file_unwind): Don't close if FD is negative;
1181 this can happen when unwinding a zapped file descriptor.
1182 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1183 in case Emacs runs out of memory between the two unwind-protects.
1184 Don't trash errno when closing FD.
1185 Zap the FD in the specpdl when closing it, instead of deferring
1186 the removal of the unwind-protect; this fixes a bug where a child
1187 function unwinds the stack past us.
1188
27e498e6
PE
1189 New unwind-protect flavors to better type-check C callbacks.
1190 This also lessens the need to write wrappers for callbacks,
1191 and the need for make_save_pointer.
1192 * alloca.c (free_save_value):
1193 * atimer.c (run_all_atimers):
1194 Now extern.
1195 * alloc.c (safe_alloca_unwind):
1196 * atimer.c (unwind_stop_other_atimers):
1197 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1198 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1199 * minibuf.c (choose_minibuf_frame_1):
1200 * process.c (make_serial_process_unwind):
1201 * xdisp.h (pop_message_unwind):
1202 * xselect.c (queue_selection_requests_unwind):
1203 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1204 * alloca.c (record_xmalloc):
1205 Prefer record_unwind_protect_ptr to record_unwind_protect with
1206 make_save_pointer.
1207 * alloca.c (Fgarbage_collect):
1208 Prefer record_unwind_protect_void to passing a dummy.
1209 * buffer.c (restore_buffer):
1210 * window.c (restore_window_configuration):
1211 * xfns.c, w32fns.c (do_unwind_create_frame)
1212 New wrapper. All record-unwind uses of wrappee changed.
1213 * buffer.c (set_buffer_if_live):
1214 * callproc.c (call_process_cleanup, delete_temp_file):
1215 * coding.c (code_conversion_restore):
1216 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1217 * editfns.c (save_excursion_restore)
1218 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1219 (save_restriction_restore):
1220 * eval.c (restore_stack_limits, un_autoload):
1221 * fns.c (require_unwind):
1222 * keyboard.c (recursive_edit_unwind, tracking_off):
1223 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1224 * macros.c (pop_kbd_macro, restore_menu_items):
1225 * nsfns.m (unwind_create_frame):
1226 * print.c (print_unwind):
1227 * process.c (start_process_unwind):
1228 * search.c (unwind_set_match_data):
1229 * window.c (select_window_norecord, select_frame_norecord):
1230 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1231 (fast_set_selected_frame):
1232 * xfns.c, w32fns.c (unwind_create_tip_frame):
1233 Return void, not a dummy Lisp_Object. All uses changed.
1234 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1235 * callproc.c (call_process_kill):
1236 * fileio.c (restore_point_unwind, decide_coding_unwind)
1237 (build_annotations_unwind):
1238 * insdel.c (Fcombine_after_change_execute_1):
1239 * keyboard.c (read_char_help_form_unwind):
1240 * menu.c (unuse_menu_items):
1241 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1242 * sound.c (sound_cleanup):
1243 * xdisp.c (unwind_redisplay):
1244 * xfns.c (clean_up_dialog):
1245 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1246 Accept no args and return void, instead of accepting and returning
1247 a dummy Lisp_Object. All uses changed.
1248 * cygw32.c (fchdir_unwind):
1249 * fileio.c (close_file_unwind):
1250 * keyboard.c (restore_kboard_configuration):
1251 * lread.c (readevalllop_1):
1252 * process.c (wait_reading_process_output_unwind):
1253 Accept int and return void, rather than accepting an Emacs integer
1254 and returning a dummy object. In some cases this fixes an
1255 unlikely bug when the corresponding int is outside Emacs integer
1256 range. All uses changed.
1257 * dired.c (directory_files_internal_unwind):
1258 * fileio.c (do_auto_save_unwind):
1259 * gtkutil.c (pop_down_dialog):
1260 * insdel.c (reset_var_on_error):
1261 * lread.c (load_unwind):
1262 * xfns.c (clean_up_file_dialog):
1263 * xmenu.c, nsmenu.m (pop_down_menu):
1264 * xmenu.c (cleanup_widget_value_tree):
1265 * xselect.c (wait_for_property_change_unwind):
1266 Accept pointer and return void, rather than accepting an Emacs
1267 save value encapsulating the pointer and returning a dummy object.
1268 All uses changed.
1269 * editfns.c (Fformat): Update the saved pointer directly via
1270 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1271 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1272 (unwind_body): New function.
1273 (record_unwind_protect): First arg is now a function returning void,
1274 not a dummy Lisp_Object.
1275 (record_unwind_protect_ptr, record_unwind_protect_int)
1276 (record_unwind_protect_void): New functions.
1277 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1278 * fileio.c (struct auto_save_unwind): New type.
1279 (do_auto_save_unwind): Use it.
1280 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1281 * insdel.c (struct rvoe_arg): New type.
1282 (reset_var_on_error): Use it.
1283 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1284 New constants.
1285 (specbinding_func): Remove; there are now several such functions.
1286 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1287 (set_unwind_protect_ptr): New function.
1288 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1289
4e604a5d
PE
1290 Be simpler and more consistent about reporting I/O errors.
1291 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1292 Say "Read error" and "Write error", rather than "I/O error", or
1293 "IO error reading", or "IO error writing", when a read or write
1294 error occurs.
1295 * process.c (Fmake_network_process, wait_reading_process_output)
1296 (send_process, Fprocess_send_eof, wait_reading_process_output):
1297 Capitalize diagnostics consistently. Put "failed foo" at the
1298 start of the diagnostic, so that we don't capitalize the
1299 function name "foo". Consistently say "failed" for such
1300 diagnostics.
1301 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1302 All callers changed. This is so it can use report_file_error.
1303 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1304 diagnostics consistently as above.
1305
a9757f6a
PE
1306 * fileio.c (report_file_errno): Fix errno reporting bug.
1307 If the file name is neither null nor a pair, package it up as a
1308 singleton list. All callers changed, both to this function and to
1309 report_file_error. This fixes a bug where the memory allocator
1310 invoked by list1 set errno so that the immediately following
1311 report_file_error reported the wrong errno value.
1312
c43843aa
PE
1313 Fix minor problems found by --enable-gcc-warnings.
1314 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1315 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1316
18c26d81
JD
13172013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1318
1319 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1320 Set event->arg to Qt if switch-event shall be generated.
1321 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1322
1323 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1324
1325 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1326 FOCUS_OUT_EVENT.
1327
1328 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1329 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1330 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1331 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1332 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1333 and there is a focused frame.
1334 (head_table): Add focus-in and focus-out.
1335 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1336 bind to handle-focus-in/out.
1337
1338 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1339 (Fhandle_switch_frame): Call Fhandle_focus_in.
1340 (syms_of_frame): defsubr handle-focus-in/out.
1341
6c6f1994
PE
13422013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1343
c7ddc792
PE
1344 Fix porting bug to older POSIXish platforms (Bug#14862).
1345 * sysdep.c (emacs_pipe): New function, that implements
1346 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1347 This should port better to CentOS 5 and to Mac OS X 10.6.
1348 All calls to pipe2 changed.
1349
6c6f1994
PE
1350 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1351 This makes the code easier to read and the executable a bit smaller.
1352 Do not replace all calls to Fcons that happen to create lists,
1353 just calls that are intended to create lists. For example, when
1354 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1355 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1356 Similarly for list2 through list5.
1357 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1358 * bytecode.c (exec_byte_code):
1359 * callint.c (quotify_arg, Fcall_interactively):
1360 * callproc.c (Fcall_process, create_temp_file):
1361 * charset.c (load_charset_map_from_file)
1362 (Fdefine_charset_internal, init_charset):
1363 * coding.c (get_translation_table, detect_coding_system)
1364 (Fcheck_coding_systems_region)
1365 (Fset_terminal_coding_system_internal)
1366 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1367 * composite.c (update_compositions, Ffind_composition_internal):
1368 * dired.c (directory_files_internal, file_name_completion)
1369 (Fsystem_users):
1370 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1371 * doc.c (Fsnarf_documentation):
1372 * editfns.c (Fmessage_box):
1373 * emacs.c (main):
1374 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1375 (Feval, eval_sub, Ffuncall, apply_lambda):
1376 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1377 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1378 (Fset_file_times, Finsert_file_contents)
1379 (Fchoose_write_coding_system, Fwrite_region):
1380 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1381 * font.c (font_registry_charsets, font_parse_fcname)
1382 (font_prepare_cache, font_update_drivers, Flist_fonts):
1383 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1384 * frame.c (make_frame, Fmake_terminal_frame)
1385 (x_set_frame_parameters, x_report_frame_params)
1386 (x_default_parameter, Fx_parse_geometry):
1387 * ftfont.c (syms_of_ftfont):
1388 * image.c (gif_load):
1389 * keyboard.c (command_loop_1):
1390 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1391 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1392 (Fminor_mode_key_binding, accessible_keymaps_1)
1393 (Faccessible_keymaps, Fwhere_is_internal):
1394 * lread.c (read_emacs_mule_char):
1395 * menu.c (find_and_return_menu_selection):
1396 * minibuf.c (get_minibuffer):
1397 * nsfns.m (Fns_perform_service):
1398 * nsfont.m (ns_script_to_charset):
1399 * nsmenu.m (ns_popup_dialog):
1400 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1401 (Fx_own_selection_internal):
1402 * nsterm.m (append2):
1403 * print.c (Fredirect_debugging_output)
1404 (print_prune_string_charset):
1405 * process.c (Fdelete_process, Fprocess_contact)
1406 (Fformat_network_address, set_socket_option)
1407 (read_and_dispose_of_process_output, write_queue_push)
1408 (send_process, exec_sentinel):
1409 * sound.c (Fplay_sound_internal):
1410 * textprop.c (validate_plist, add_properties)
1411 (Fput_text_property, Fadd_face_text_property)
1412 (copy_text_properties, text_property_list, syms_of_textprop):
1413 * unexaix.c (report_error):
1414 * unexcoff.c (report_error):
1415 * unexsol.c (unexec):
1416 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1417 (Fformat_mode_line, syms_of_xdisp):
1418 * xfaces.c (set_font_frame_param)
1419 (Finternal_lisp_face_attribute_values)
1420 (Finternal_merge_in_global_face, syms_of_xfaces):
1421 * xfns.c (x_default_scroll_bar_color_parameter)
1422 (x_default_font_parameter, x_create_tip_frame):
1423 * xfont.c (xfont_supported_scripts):
1424 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1425 (menu_help_callback, xmenu_show):
1426 * xml.c (make_dom):
1427 * xterm.c (set_wm_state):
1428 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1429 and similarly for list2 through list5.
1430
bafe80ce
PE
14312013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 * callproc.c (Fcall_process_region): Fix minor race and tune.
1434 (create_temp_file): New function, with the temp-file-creation part
1435 of the old Fcall_process_region. Use Fcopy_sequence to create the
1436 temp file name, rather than alloca + build_string, for simplicity.
1437 Don't bother to block input around the temp file creation;
1438 shouldn't be needed. Simplify use of mktemp. Use
1439 record_unwind_protect immediately after creating the temp file;
1440 this closes an unlikely race where the temp file was not removed.
1441 Use memcpy rather than an open-coded loop.
1442 (Fcall_process_region): Use the new function. If the input is
1443 empty, redirect from /dev/null rather than from a newly created
1444 empty temp file; this avoids unnecessary file system traffic.
1445
4700b5a5
PE
14462013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1447
5c97beae
PE
1448 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1449 Simplify by making this case like the other two. This is a bit
1450 slower on obsolete hosts, but the extra complexity isn't worth it.
1451
4700b5a5
PE
1452 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1453 * process.c (create_process) [!DOS_NT]:
1454 Remove now-unnecessary calls to emacs_close.
1455
f9a74c4c
EZ
14562013-07-13 Eli Zaretskii <eliz@gnu.org>
1457
922ae7ee
EZ
1458 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1459 returning early. (Bug#14850)
1460
f9a74c4c
EZ
1461 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1462 and inhibit-iso-escape-detection attributes of 'undecided'.
1463 (Bug#14822)
1464
5e301d76
PE
14652013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1466
69e0e5ee
PE
1467 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1468 Reported by Herbert J. Skuhra in
1469 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1470
5e301d76
PE
1471 Don't lose top specpdl entry when memory is exhausted.
1472 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1473 specpdl overflow here, to simplify callers; all callers changed.
1474 Always reserve an unused entry at the stack top; this avoids
1475 losing the top entry's information when memory is exhausted.
1476
7e649856
PE
14772013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1478
a773ed9a
PE
1479 Clean up errno reporting and fix some errno-reporting bugs.
1480 * callproc.c (Fcall_process):
1481 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1482 * process.c (create_process, Fmake_network_process):
1483 * unexaix.c (report_error):
1484 * unexcoff.c (report_error):
1485 Be more careful about reporting the errno of failed operations.
1486 The code previously reported the wrong errno sometimes.
1487 Also, prefer report_file_errno to setting errno + report_file_error.
1488 (Fcall_process): Look at openp return value rather than at path,
1489 as that's a bit faster and clearer when there's a numeric predicate.
1490 * fileio.c (report_file_errno): New function, with most of the
1491 old contents of report_file_error.
1492 (report_file_error): Use it.
1493 (Ffile_exists_p, Ffile_accessible_directory_p):
1494 Set errno to 0 when it is junk.
1495 * fileio.c (Faccess_file):
1496 * image.c (x_create_bitmap_from_file):
1497 Use faccessat rather than opening the file, to avoid the hassle of
1498 having a file descriptor open.
1499 * lisp.h (report_file_errno): New decl.
1500 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1501
7e649856
PE
1502 Minor EBADF fixes.
1503 * process.c (create_process, wait_reading_process_output) [AIX]:
1504 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1505 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1506 a multithreaded environment anyway).
1507 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1508
f6774c1a
AS
15092013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1510
1511 * image.c (x_find_image_file): Don't close a remote file handle.
1512
bacba3c2
PE
15132013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1514
1515 Fix races with threads and file descriptors.
1516 * callproc.c (Fcall_process_region):
1517 * dired.c (open_directory):
1518 * emacs.c (main, Fdaemon_initialized):
1519 * image.c (x_find_image_file):
1520 * inotify.c (Finotify_rm_watch):
1521 * lread.c (Flocate_file_internal):
1522 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1523 * term.c (term_mouse_moveto, init_tty):
1524 * termcap.c (tgetent):
1525 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1526 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1527 * unexhp9k800.c, unexmacosx.c (unexec):
1528 * callproc.c (Fcall_process_region):
1529 Use emacs_close, not close.
1530 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1531 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1532 and posix_close function on current platforms (which all lack them).
1533 (emacs_close): Use it. This should fix the races on GNU/Linux and
1534 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1535 and it should avoid closing random victim file descriptors on
1536 other platforms.
1537
653d4f43
PE
15382013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1539
c8536ec4
PE
1540 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1541 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1542 Touch up doc a bit.
1543
9c203066
PE
1544 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1545 This is for .gdbinit xbacktrace.
1546
653d4f43
PE
1547 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1548 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1549 (emacs_set_tty): Now static.
1550 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1551 * term.c (tty_capable_p, tty_default_color_capabilities)
1552 (get_tty_terminal, term_mouse_movement)
1553 (handle_one_term_event, init_tty, maybe_fatal):
1554 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1555 (tgetent, scan_file, name_match, compare_contin):
1556 * terminal.c (get_terminal):
1557 Use bool for boolean.
1558 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1559 Prefer char to unsigned char if either will do.
1560 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1561 (tty_write_glyphs): Prefer int to unsigned.
1562 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1563 All callers changed.
1564 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1565
45b683a1
PE
15662013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1567
29abe551
PE
1568 Port to C89.
1569 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1570 (B__dummy__): New dummy symbol, to pacify C89.
1571 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1572 they can't grok varargs macros.
1573 * dispnew.c (add_window_display_history)
1574 (add_frame_display_history):
1575 * print.c (print_object):
1576 * xdisp.c (debug_method_add):
1577 Use %p printf format only for void pointers.
1578 * emacs.c (usage_message): New constant, replacing ...
1579 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1580 (main): Adjust to usage reorg.
1581 * fns.c (syms_of_fns):
1582 * profiler.c (syms_of_profiler):
1583 Don't use non-constant struct initializers.
1584 * gnutls.h (gnutls_initstage_t):
1585 * lisp.h (enum Lisp_Fwd_Type):
1586 * lread.c (lisp_file_lexically_bound_p):
1587 * xsettings.c (anonymous enum):
1588 Remove trailing comma.
1589 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1590 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1591 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1592 (DEFUN): Use it.
1593 * regex.c (const_re_char): New type, to pacify strict C89.
1594 All uses of 'const re_char' replaced to use it.
1595 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1596 with glibc when strict C89. This change is imported from gnulib.
1597 All uses changed.
1598 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1599 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1600 Omit GNU_LINUX implementation, since it requires long long.
1601 * xterm.c (x_draw_underwave):
1602 Do not assume the traditional order of struct's members.
1603 (x_term_init): Rewrite to avoid the need for non-constant structure
1604 initializers.
1605
45b683a1 1606 Syntax cleanup, mostly replacing macros with functions.
763a086d 1607 This removes the need for the syntax_temp hack.
45b683a1
PE
1608 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1609 * syntax.c (SYNTAX_INLINE): New macro.
1610 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1611 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1612 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1613 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1614 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1615 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1616 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1617 Now constants, not macros.
1618 (syntax_temp) [!__GNUC__]: Remove.
1619 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1620 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1621 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1622 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1623 Move here from syntax.h; now functions, not macros. Except for the
1624 last function, these are static since only syntax.c uses them.
1625 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1626 All uses changed. Now a function, not a macro; use this fact
1627 to simplify the code.
1628 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1629 compiler bugs; no longer relevant.
1630 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1631 (SYNTAX_INLINE): New macro.
1632 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1633 for the new functions. Use bool for boolean member.
1634 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1635 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1636 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1637 (SETUP_BUFFER_SYNTAX_TABLE):
1638 Now extern inline functions, not macros.
1639 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1640 Remove; all uses replaced by implementation.
1641 (syntax_temp) [!__GNUC__]: Remove decl.
1642 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1643
29be4a50
JD
16442013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1645
1646 * emacs.c (main): Fix syntax error.
1647
954b166e
PE
16482013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 Timestamp fixes for undo (Bug#14824).
1651 * atimer.c (schedule_atimer):
1652 * fileio.c (Ffile_newer_than_file_p):
1653 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1654 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1655 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1656 (syms_of_fileio): Remove Sclear_visited_file_name.
1657 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1658 file doesn't exist; this avoids an ambiguity with negative timestamps.
1659 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1660 * systime.h (make_emacs_time, invalid_emacs_time):
1661 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1662 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1663 * undo.c (record_first_change): Push (visited-file-modtime) onto
1664 undo list rather than reimplementing it by hand, incorrectly.
1665
d74647c3
KB
16662013-07-09 Ken Brown <kbrown@cornell.edu>
1667
1668 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1669
3c51b96b
JB
16702013-07-09 Juanma Barranquero <lekktu@gmail.com>
1671
1672 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1673
4ebbdd67
PE
16742013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1675
1676 Handle errno and exit status a bit more carefully.
1677 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1678 number into an exit status. Instead, use EXIT_CANCELED.
1679 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1680 * callproc.c (relocate_fd):
1681 * emacs.c (close_output_streams, main):
1682 * process.c (create_process):
1683 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1684 Use emacs_perror for simplicity.
1685 * callproc.c (relocate_fd, main):
1686 * sysdep.c (sys_subshell):
1687 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1688 (shut_down_emacs): Use emacs_write, not write.
1689 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1690 * fileio.c (Fcopy_file, e_write):
1691 * nsterm.m (ns_select):
1692 * process.c (send_process):
1693 * sound.c (vox_write):
1694 Use emacs_write_sig, not emacs_write.
1695 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1696 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1697 New constants.
1698 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1699 of write.
1700 (emacs_full_write): New function.
1701 (emacs_write): Rewrite to use it.
1702 (emacswrite_sig, emacs_perror): New functions.
1703 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1704
44e18199 17052013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1706
1707 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1708 on NS even if it is present. Pixmap on NS is a void*.
1709
9caab067
PE
17102013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 Port to Ubuntu 10 (Bug#14803).
1713 Problem reported by T.V. Raman.
1714 * process.c (close_on_exec, accept4, process_socket):
1715 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1716
1d442672
EZ
17172013-07-07 Eli Zaretskii <eliz@gnu.org>
1718
1719 * w32.c (sys_dup): Declare prototype.
1720
1721 * filelock.c:
1722 * emacs.c:
1723 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1724
067428c1
PE
17252013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1726
1727 Make file descriptors close-on-exec when possible (Bug#14803).
1728 This simplifies Emacs a bit, since it no longer needs to worry
1729 about closing file descriptors by hand in some cases.
1730 It also fixes some unlikely races. Not all such races, as
1731 libraries often open files internally without setting
1732 close-on-exec, but it's an improvement.
1733 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1734 * callproc.c (Fcall_process) [!MSDOS]:
1735 * emacs.c (main) [!DOS_NT]:
1736 * nsterm.m (ns_term_init):
1737 * process.c (create_process):
1738 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1739 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1740 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1741 Prefer mkostemp with O_CLOEXEC to mkstemp.
1742 * callproc.c (relocate_fd) [!WINDOWSNT]:
1743 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1744 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1745 now using pipe2.
1746 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1747 Make the resulting file descriptor close-on-exec.
1748 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1749 * lread.c (load_descriptor_list, load_descriptor_unwind):
1750 Remove; no longer needed. All uses removed.
1751 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1752 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1753 New functions.
1754 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1755 (Fmake_network_process, Fnetwork_interface_list):
1756 (Fnetwork_interface_info, server_accept_connection):
1757 Make newly-created socket close-on-exec.
1758 * sysdep.c (emacs_open, emacs_fopen):
1759 Make new-created descriptor close-on-exec.
1760 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1761 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1762
0da857dd
JD
17632013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1764
1765 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1766 for NS_IMPL_GNUSTEP.
1767
5f86adcd
PE
17682013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 Fix openp errno handling.
1771 * callproc.c (Fcall_process): Preserve openp errno around close.
1772 * lread.c (openp): Set errno when returning -1, as some callers
1773 expect this.
1774
1afb1d07
JD
17752013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1776
1777 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1778
1779 * nsterm.h (NSSavePanel): Update comment.
1780 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1781 (ns_run_file_dialog): Declare.
1782
1783 * nsfns.m: Remove panelOK.
1784 (ns_fd_data): New.
1785 (ns_run_file_dialog): New function.
1786 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1787 event loop, so file dialog is popped up by ns_run_file_dialog, called
1788 by sendEvent (Bug#14578).
1789 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1790
3323c263
EZ
17912013-07-06 Eli Zaretskii <eliz@gnu.org>
1792
fdda0220
EZ
1793 * xdisp.c (default_line_pixel_height): New function.
1794 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1795 (try_cursor_movement, redisplay_window, try_window)
1796 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1797
1798 * window.c (window_scroll_pixel_based): use
1799 default_line_pixel_height.
1800
1801 * dispextern.h (default_line_pixel_height): Add prototype.
1802
1803 * frame.c (x_set_line_spacing): Accept a float value for
1804 line-spacing parameter, per the documentation.
1805
3323c263
EZ
1806 * data.c (Fmultibyte_string_p): Doc fix.
1807
47ba6d43
PE
18082013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1809
406af475
PE
1810 Use emacs_open more consistently when opening files.
1811 This handles EINTR more consistently now, and makes it easier
1812 to introduce other uniform changes to file descriptor handling.
1813 * src/systdio.h: New file.
1814 * src/buffer.c (mmap_init):
1815 * cygw32.c (chdir_to_default_directory):
1816 * dispnew.c (Fopen_termscript):
1817 * emacs.c (Fdaemon_initialized):
1818 * fileio.c (Fdo_auto_save):
1819 * image.c (slurp_file, png_load_body, jpeg_load_body):
1820 * keyboard.c (Fopen_dribble_file):
1821 * lread.c (Fload):
1822 * print.c (Fredirect_debugging_output):
1823 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1824 * termcap.c (tgetent):
1825 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1826 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1827 * w32term.c (w32_initialize) [CYGWIN]:
1828 * xfaces.c (Fx_load_color_file):
1829 Use emacs_open instead of plain open, and emacs_fopen instead of
1830 plain fopen.
1831 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1832 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1833 * callproc.c (default_output_mode): New constant.
1834 (Fcall_process): Use it to call emacs_open instead of plain creat.
1835 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1836 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1837 (emacs_fopen): New function.
1838 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1839 Include <lisp.h>, for emacs_open.
1840 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1841
47ba6d43
PE
1842 Remove duplicate #include directives.
1843 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1844 * xfaces.c:
1845 Don't include stdio.h twice.
1846 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1847 Don't include sys/types.h or stdio.h twice.
1848 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1849 * lread.c: Don't include coding.h twice.
1850 * nsfont.m: Don't include frame.h twice.
1851 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1852 * ralloc.c: Don't include <unistd.h> twice.
1853 * xdisp.c: Don't include font.h twice.
1854 * xterm.c: Don't include fontset.h twice.
1855 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1856
b9ed53d5
PE
18572013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 Scale ImageMagick images more carefully.
1860 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1861 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1862 Be more careful about avoiding undefined behavior after
1863 integer overflow and division by zero.
1864
cf13177e
YM
18652013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1866
1867 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1868 (syms_of_w32fns): DEFSYM them.
1869 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1870 (CCHDEVICENAME): Define macros if not defined.
1871 (struct MONITOR_INFO_EX): New struct.
1872 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1873 (enum_display_monitors_fn): New variable.
1874 (globals_of_w32fns): Initialize it.
1875 (Fx_display_pixel_width, Fx_display_pixel_height)
1876 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1877 multi-monitor setups in docstrings.
1878 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1879 screen size by primary monitor's millimeter per pixel.
1880 (w32_monitor_enum, w32_display_monitor_attributes_list)
1881 (w32_display_monitor_attributes_list_fallback)
1882 (Fw32_display_monitor_attributes_list): New functions.
1883 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1884
1885 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1886 if not defined.
1887 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1888
86dfb7a8
MA
18892013-07-04 Michael Albinus <michael.albinus@gmx.de>
1890
1891 * fileio.c (Qfile_notify_error): New error symbol.
1892
1893 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1894 * inotify.c (inotify_callback, symbol_to_inotifymask)
1895 (Finotify_add_watch, Finotify_rm_watch): Use it.
1896 (inotifyevent_to_event): Exchange order of cookie and file name.
1897 (Finotify_add_watch): Adapt docstring.
1898
1899 * lisp.h (Qfile_notify_error): Declare.
1900
2c1c974b
PE
19012013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1904 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1905 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1906 which did not work (see <http://bugs.gnu.org/14569#307>).
1907 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1908 && (!noninteractive || initialized)). This attempts to thread
1909 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1910
7a35b20f
JB
19112013-07-04 Juanma Barranquero <lekktu@gmail.com>
1912
1913 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1914 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1915
1ce5cd04
PE
19162013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1917
1918 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1919 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1920 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1921 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1922
57f8c490
PE
19232013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1926 Define to __sys_siglist.
1927
bcffb5ca
EZ
19282013-07-02 Eli Zaretskii <eliz@gnu.org>
1929
1930 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1931 word-wrap, so that overflow-newline-into-fringe would work in
1932 visual-line-mode. (Bug#2749)
1933 (move_it_in_display_line_to): When the last scanned display
1934 element fits exactly on the display line, and
1935 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1936 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1937 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1938 finding buffer position that corresponds to pixel coordinates,
1939 e.g. in buffer_posn_from_coords.
1940
2c41e781
JD
19412013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1942
1943 * process.c (handle_child_signal): Call catch_child_signal if
1944 NS_IMPL_GNUSTEP.
1945
c2418359
PE
19462013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1947
52a9bcae
PE
1948 Don't convert function pointers to void * and back.
1949 It isn't portable C, and it's easy enough to avoid.
1950 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1951 (make_save_value): Add support for SAVE_FUNCPOINTER.
1952 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1953 * print.c (print_object):
1954 Distinguish function from object pointers.
1955 * lisp.h (SAVE_FUNCPOINTER): New constant.
1956 (SAVE_SLOT_BITS): Adjust to it.
1957 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1958 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1959 (voidfuncptr): New typedef.
1960 (struct Lisp_Save_Value): New member data[0].funcpointer.
1961 (XSAVE_FUNCPOINTER): New function.
1962
c2418359
PE
1963 Simplify buildobj processing.
1964 * Makefile.in (buildobj.h): Make it a sequence of strings each
1965 followed by comma, rather than a single string. Put it into a
1966 .tmp file in case there's an error while generating it.
1967 (gl-stamp): Use .tmp for temp files.
1968 (mostlyclean): Clean .tmp files.
1969 * doc.c (buildobj): Move to just the routine that needs it.
1970 It's now an array of strings, so processing is simpler.
1971
8f43ce49
PE
19722013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1975 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1976 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1977 Invoke malloc_enable_thread even when not interactive.
1978 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1979 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1980 in this case, since the underlying bug has now been fixed.
1981
24827db9
JB
19822013-07-01 Juanma Barranquero <lekktu@gmail.com>
1983
1984 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1985 unlinking it (bug#14691).
1986
ef099a94
MN
19872013-06-30 Michal Nazarewicz <mina86@mina86.com>
1988
1989 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1990 before checking whether buffer is modified. This lets
1991 `kill-buffer-query-functions' cancel killing of the buffer or save
1992 its content before `kill-buffer' asks user the "Buffer %s
1993 modified; kill anyway?" question.
1994
9d3f2fc2
JD
19952013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1996
1997 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1998 Let the super performKeyEquivalent deal with them (Bug#14747).
1999
e6c6c8c7
PE
20002013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2001
1d71c1d9
PE
2002 * widget.c (resize_cb): Remove unused local.
2003
8f5f35cc
PE
2004 Do not use GTK 3 if it exists but cannot be compiled.
2005 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2006 * xterm.c (x_error_handler) [!USE_GTK]:
2007 Do not use GTK 3.
2008
e6c6c8c7
PE
2009 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2010
0ba54312
EZ
20112013-06-30 Eli Zaretskii <eliz@gnu.org>
2012
5d1c3286
EZ
2013 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2014 to the valid range of values. (Bug#14753)
2015
0ba54312
EZ
2016 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2017 when moving point by using the current glyph matrix. This avoids
2018 the need to force redisplay when this function is called in a
2019 loop.
2020
9c90cc06
PE
20212013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 Fix minor problems found by static checking.
2024 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2025 Redo the latter's body to sidestep GCC parenthesization warnings.
2026 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2027 * coding.c (detect_coding, detect_coding_system):
2028 * coding.h (struct undecided_spec):
2029 Use bool for boolean.
2030 * image.c (QCmax_width, QCmax_height): Now static.
2031 * xdisp.c (Fmove_point_visually): Remove unused local.
2032
4c672a0f
EZ
20332013-06-29 Eli Zaretskii <eliz@gnu.org>
2034
2035 * xdisp.c (Fmove_point_visually): New function.
2036
c1ea3abf
JB
20372013-06-28 Kenichi Handa <handa@gnu.org>
2038
2039 * coding.h (define_coding_undecided_arg_index): New enum.
2040 (coding_attr_index): New members
2041 coding_attr_undecided_inhibit_null_byte_detection,
2042 coding_attr_undecided_inhibit_iso_escape_detection,
2043 coding_attr_undecided_prefer_utf_8.
2044 (undecided_spec): New struct.
2045 (struct coding_system): New member `undecided' of the member
2046 `spec'.
2047
2048 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2049 (detect_coding): Likewise.
2050 (detect_coding_system): Likewise.
2051 (Fdefine_coding_system_internal): New coding system properties
2052 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2053 :prefer-utf-8.
2054 (syms_of_coding): Adjust for coding_arg_undecided_max.
2055
ba3de9e6
PE
20562013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 * image.c (x_from_xcolors): Remove unused local.
2059
547c9269
YM
20602013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2061
2062 Defer image data transfer between X client and server until actual
2063 display happens.
2064
2065 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2066 and `mask_img'.
2067
2068 * image.c (Destroy_Image): Remove.
2069 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2070 `mask_p', and `colors_p'. All uses changed.
2071 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2072 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2073 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2074 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2075 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2076 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2077 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2078 (image_get_x_image, image_unget_x_image): New functions or macros.
2079 (image_background, image_background_transparent, x_to_xcolors)
2080 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2081 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2082 instead of Destroy_Image.
2083 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2084 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2085 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2086 (imagemagick_load_image, svg_load_image): Use them instead of
2087 x_create_x_image_and_pixmap, and x_put_x_image followed by
2088 x_destroy_x_image, respectively.
2089 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2090 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2091 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2092 background_transparent fields.
2093 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2094 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2095
dae2f5ef
PE
20962013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2099 This mostly consists of undoing recent changes.
2100 * callproc.c (Fcall_process):
2101 * process.c (create_process):
2102 Do not worry about catching SIGCHLD here, undoing previous change.
2103 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2104 * process.c, process.h (catch_child_signal):
2105 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2106 * process.c (catch_child_handler): Don't worry about being called
2107 lazily and do not assume caller has blocked SIGCHLD, undoing
2108 previous change. Move first-time stuff back to
2109 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2110 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2111 set lib_child_handler if it's already initialized, which may
2112 help avoid problems on GNUStep.
2113
fa55d2aa
PE
21142013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2117 * callproc.c (Fcall_process):
2118 * process.c (create_process):
2119 Make sure SIGCHLD is caught before we fork,
2120 since Emacs startup no arranges to catch SIGCHLD.
2121 * process.c (lib_child_handler): Initialize to null, not to
2122 dummy_handler.
2123 (catch_child_signal): Allow self to be called lazily.
2124 Do nothing if it's already been called.
2125 Assume caller has blocked SIGCHLD (all callers do now).
2126 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2127 just before it's really needed.
2128 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2129 since it hasn't been caught yet.
2130
f3f9606c
LMI
21312013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2132
2133 * image.c (compute_image_size): New function to implement
2134 :max-width and :max-height.
2135 (imagemagick_load_image): Use it.
2136
c7041908
PE
21372013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2140 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2141 Now extern.
2142 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2143 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2144 the SIGCHLD handler, since the code is not atomic and (due to glib)
2145 signals may be arriving now.
2146 * sysdep.c (init_signals): Do not catch child signals here;
2147 'main' now does that later, at a safer time.
2148
f86852b4
PE
21492013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2150
0dfeed58
PE
2151 Clean up SIGCHLD handling a bit (Bug#14569).
2152 * process.c, process.h (catch_child_signal):
2153 Now always extern, even if !NS_IMPL_GNUSTEP.
2154 * process.c (catch_child_signal): Move glib tickler here from
2155 init_process_emacs, so that it's done earlier in Emacs
2156 initialization. Also move the noninteractive && !initialized
2157 check here from init_process_emacs. This is all a bit cleaner for
2158 GNUish platforms, and I hope it works around the Cygwin bug.
2159 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2160 that glib signal handling is tickled before glib creates threads.
2161
f86852b4
PE
2162 * process.c (wait_reading_process_output): Avoid int overflow
2163 when reading more than 2 GiB total from a process.
2164
cbd6509c
PE
21652013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2166
2167 * process.c (create_process): Handle a couple more cases,
2168 i.e., work even if new_argv and wait_child_setup[i] are cached.
2169 Use Fcall_process's style for volatile vars.
2170
9de1114a
AS
21712013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2172
2173 * process.c (create_process): Mark PROCESS volatile.
2174
fbe9e0b9
PE
21752013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 Use C99-style flexible array members if available.
2178 This avoids some subtle aliasing issues, which typically
2179 aren't a problem with GCC but may be a problem elsewhere.
2180 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2181 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2182 In either case, it uses a flexible array member rather than
2183 the old struct hack. All uses changed.
2184 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2185 Adjust to sdata reorganization.
2186 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2187 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2188 that ports better to pre-C99 non-GCC.
2189 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2190 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2191 as the latter has changed.
2192 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2193 and port better to pre-C99 GCC.
2194 * image.c (struct xpm_cached_color):
2195 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2196 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2197 Use FLEXIBLE_ARRAY_MEMBER.
2198 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2199 Move decl to top level so it gets checked against implementation.
2200 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2201 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2202
1fc71008
PE
22032013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2204
2205 * syntax.c: Integer cleanups.
2206 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2207 All uses that need 0-or-2 changed to:
2208 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2209 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2210 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2211 (char_quoted, prev_char_comend_first, back_comment)
2212 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2213 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2214 Use bool for boolean.
2215 (update_syntax_table, skip_chars, skip_syntaxes):
2216 Prefer int to unsigned when either will do.
2217 (back_comment): Return boolean success flag, like forw_comment,
2218 instead of positive-or-minus-1 (which might have overflowed int anyway).
2219 Don't stuff ptrdiff_t into int.
2220 (syntax_spec_code, syntax_code_spec): Now const.
2221 (Fmatching_paren, scan_lists, scan_sexps_forward):
2222 Use enum syntaxcode for syntax code.
2223 (Fmatching_paren): Check that arg is a character, not just an integer.
2224 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2225 (Finternal_describe_syntax_value): Omit no-longer-needed
2226 comparison to 0.
2227 (skip_chars): Use char, not unsigned char, when the distinction
2228 doesn't matter.
2229 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2230 * bytecode.c (exec_byte_code):
2231 * syntax.c (syntax_spec_code, Fchar_syntax)
2232 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2233 (init_syntax_once):
2234 * syntax.h (SYNTAX_WITH_FLAGS):
2235 Omit unnecessary casts.
2236
b932cad7
EZ
22372013-06-20 Eli Zaretskii <eliz@gnu.org>
2238
2239 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2240 line dimensions here, to avoid race conditions with the main
2241 thread. (Bug#14062, bug#14630, bug#14669)
2242
2243 * w32term.c (w32_draw_window_cursor): Compute the header line and
2244 mode line dimensions here.
2245 <w32_system_caret_window, w32_system_caret_hdr_height>:
2246 <w32_system_caret_mode_height>: New variables.
2247
2248 * w32term.h: Declare them.
2249
89561f72
PE
22502013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2251
5013fc08
PE
2252 * alloc.c (die): Move "assertion failed" string here ...
2253 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2254 COND when SUPPRESS_CHECKING. This shrinks the executable text
2255 size by 0.8% to 2.2% when configured with --enable-checking,
2256 depending on optimization flags (GCC 4.8.1 x86-64).
2257
89561f72
PE
2258 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2259
763a086d 22602013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2261
2262 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2263 base is 2; this is more accurate.
2264
983aeb9a
JB
22652013-06-19 Juanma Barranquero <lekktu@gmail.com>
2266
2267 * sound.c (string_default): Move to !WINDOWSNT section.
2268 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2269
178ba3e6
PE
22702013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2271
bbc51b15
PE
2272 * sound.c: Integer cleanups.
2273 Remove unnecessary forward decls.
2274 (struct sound_device): The 'file' member is now a Lisp_Object, not
2275 a char *, so that we needn't invoke alloca on a huge size.
2276 (Fplay_sound_internal): Adjust to this.
2277 (string_default): New function.
2278 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2279 Use it to adjust to the struct sound_device change.
2280 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2281 (be2hs) [0]: Remove.
2282
178ba3e6
PE
2283 * syntax.c (skip_chars): Don't use uninitialized storage
2284 when searching a multibyte buffer for characters that are not in a
2285 unibyte string that contains non-ASCII characters.
2286
69f60cdc
JD
22872013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2288
2289 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2290 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2291
0d6224d4
PE
22922013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2295
3c542890
KH
22962013-06-18 Kenichi Handa <handa@gnu.org>
2297
f7e3f7cd
KH
2298 * font.c (Ffont_spec): Signal an error for an invalid font name
2299 (Bug#14648).
3c542890 2300
9349e5f7
PE
23012013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2304 In particular this ports to 32-bit sparc Sun cc.
2305 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2306 array with a dummy element at specpdl[-1], so that its address can
2307 be taken portably.
2308 (unbind_to): Do not copy the binding; not needed, now that we
2309 copy old_value in the one place where the copy is needed.
2310 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2311 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2312 (union specbinding): Rename from struct specbinding. Redo layout
2313 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2314 which is not portable. With Sun C 5.12 32-bit sparc, the
2315 declaration causes nargs to be an unsigned bitfield, a behavior
2316 that the C standard allows; but Emacs wants nargs to be signed.
2317 The overall type is now a union of structures rather than a
2318 structure of union of structures, and the 'kind' member is now a
2319 bitfield, so that the overall type doesn't grow. All uses changed.
2320 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2321
0a4df6a5
PE
23222013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2323
ec6ecaad
PE
2324 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2325 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2326
0a4df6a5
PE
2327 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2328
7bfe8dbc
EZ
23292013-06-17 Eli Zaretskii <eliz@gnu.org>
2330
2331 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2332 unless we know that the window w's frame is a frame object.
2333 Another attempt at solving bug#14062 and bug#14630.
2334
708e05f6
LMI
23352013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2336
2337 * textprop.c (property_set_type): New enum.
2338 (add_properties): Allow appending/prepending text properties.
2339 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2340 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2341 add_text_properties_1.
2342 (Fadd_face_text_property): New function that calls
2343 add_text_properties_1.
2344
84575e67
PE
23452013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2346
2347 Move functions from lisp.h to individual modules when possible.
2348 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2349 * alloc.c (XFLOAT_INIT, set_symbol_name):
2350 * buffer.c (CHECK_OVERLAY):
2351 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2352 (set_char_table_parent):
2353 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2354 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2355 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2356 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2357 (set_blv_valcell):
2358 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2359 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2360 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2361 (backtrace_args, backtrace_debug_on_exit):
2362 * floatfns.c (CHECK_FLOAT):
2363 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2364 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2365 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2366 (set_hash_index_slot):
2367 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2368 * marker.c (CHECK_MARKER):
2369 * textprop.c (CHECK_STRING_OR_BUFFER):
2370 * window.c (CHECK_WINDOW_CONFIGURATION):
2371 Move here from lisp.h, and make these functions static rather than
2372 extern inline.
2373 * buffer.c (Qoverlayp):
2374 * data.c (Qsubrp):
2375 * fns.c (Qhash_table_p):
2376 * window.c (Qwindow_configuration_p):
2377 Now static.
2378 * lisp.h: Remove the abovementioned defns and decls.
2379
44e18199 2380 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2381 In lisp.h, prefer functions to function-like macros, and
2382 constants to object-like macros, when either will do. This:
2383 . simplifies use, as there's no more need to worry about
2384 arguments' side effects being evaluated multiple times.
2385 . makes the code easier to debug on some platforms.
2386 However, when using gcc -O0, keep using function-like macros
2387 for a few critical operations, for performance reasons.
2388 This sort of thing isn't needed with gcc -Og, but -Og
2389 is a GCC 4.8 feature and isn't widely-enough available yet.
2390 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2391 Remove enum lsb_bits; no longer needed.
2392 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2393 * buffer.c (Qoverlap):
2394 * data.c (Qsubrp):
2395 * fns.c (Qhash_table_p):
2396 Now extern, so lisp.h can use these symbols.
2397 * dispextern.h: Include character.h, for MAX_CHAR etc.
2398 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2399 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2400 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2401 (GLYPH_CODE_P): Move here from lisp.h.
2402 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2403 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2404 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2405 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2406 XUNTAG now returns void *.
2407 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2408 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2409 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2410 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2411 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2412 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2413 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2414 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2415 New macros, renamed from their sans-lisp_h_ counterparts.
2416 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2417 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2418 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2419 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2420 If compiling via GCC without optimization, define these as macros
2421 in addition to inline functions.
2422 To disable this, compile with -DINLINING=0.
2423 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2424 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2425 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2426 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2427 (INTMASK, VALMASK): Now macros, since static values cannot be
2428 accessed from extern inline functions.
2429 (VALMASK): Also a constant, for benefit of old GDB.
2430 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2431 is INTEGERP, which can fold it in.
5165d44a 2432 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2433 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2434 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2435 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2436 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2437 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2438 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2439 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2440 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2441 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2442 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2443 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2444 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2445 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2446 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2447 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2448 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2449 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2450 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2451 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2452 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2453 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2454 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2455 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2456 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2457 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2458 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2459 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2460 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2461 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2462 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2463 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2464 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2465 Now functions.
2466 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2467 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2468 (VALMASK): Define in one place rather than in two, merging the
2469 USE_LSB_TAG parts; this is simpler.
2470 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2471 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2472 Move up, to avoid use before definition.
2473 Also include "globals.h" earlier, for the same reason.
2474 (make_natnum): New function.
2475 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2476 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2477 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2478 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2479 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2480 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2481 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2482 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2483 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2484 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2485 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2486 (Qwindow_configuration_p, Qimage): New forward declarations.
2487 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2488 (STRING_COPYIN): Remove; unused.
2489 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2490 (xcar_addr, xcdr_addr): New functions. All uses changed.
2491 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2492 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2493 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2494 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2495 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2496 (TYPE_RANGED_INTEGERP): Simplify.
2497 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2498 (setlocale, fixup_locale, synchronize_system_messages_locale)
2499 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2500 Now empty functions, not macros.
2501 (functionp): Return bool, not int.
2502 * window.c (Qwindow_configuration_p): Now extern,
2503 so window.h can use it.
2504 * window.h (Qwindowp): Move decl back to lisp.h.
2505
9583ec36
EZ
25062013-06-15 Eli Zaretskii <eliz@gnu.org>
2507
2508 * xdisp.c (Fline_pixel_height): New function, required for solving
2509 bug #14567.
2510
210272ce
PE
25112013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2514
de0503df
SM
25152013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2516
2517 * lread.c (syms_of_lread):
2518 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2519
afbfe143
KD
25202013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2521
2522 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2523
d177e213
XF
25242013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2525
2526 * fileio.c (expand_file_name): Doc fix.
2527
05e3e412
PE
25282013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2529
f7394b12
PE
2530 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2531 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2532 Wait for self, not for 0. This can't hurt on GNU or similar
2533 system, and may help with Cygwin.
2534
05e3e412
PE
2535 * keyboard.c: Don't use PROP (...) as an lvalue.
2536 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2537 Use set_prop (A, B), not PROP (A) = B.
2538
17dd3097
EZ
25392013-06-10 Eli Zaretskii <eliz@gnu.org>
2540
2541 * xdisp.c (get_it_property): Use it->window instead of generating
2542 a Lisp object from it->w.
2543
52fab9c9
EZ
25442013-06-09 Eli Zaretskii <eliz@gnu.org>
2545
2546 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2547 get-char-property the window that is being rendered, instead of
2548 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2549 (compute_display_string_pos): When W is NULL, use the current
2550 buffer as the object to pass to get-char-property.
2551 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2552 pointer member of the bidi iterator, since no window is pertinent
2553 to this function.
52fab9c9 2554
5bf97bfc
EZ
25552013-06-08 Eli Zaretskii <eliz@gnu.org>
2556
2557 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2558 being displayed, and pass it to compute_display_string_pos.
2559 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2560 (bidi_paragraph_init): All callers changed.
2561
2562 * xdisp.c (init_from_display_pos, init_iterator)
2563 (handle_single_display_spec, next_overlay_string)
2564 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2565 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2566 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2567 (compute_display_string_pos): Accept additional argument, the
2568 window being displayed, and pass it to Fget_char_property.
2569 (Bug#14575)
2570
2571 * dispextern.h (struct bidi_it): New member w, the window being
2572 displayed.
2573 (compute_display_string_pos): Adjust prototype.
2574
5de0e011
JD
25752013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2576
e7b41c4c 2577 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2578
2579 * process.c (wait_reading_process_output): Check for NS before GLIB.
2580 GLIB may be linked in due to rsvg, but ns_select must be called.
2581
5de0e011
JD
2582 * xgselect.c (xg_select): Remove call to window_system_available
2583 and g_main_context_pending at the top, so Gdk events (i.e. file
2584 notify) are processed when Emacs is started with -nw.
2585
a822acff
EZ
25862013-06-07 Eli Zaretskii <eliz@gnu.org>
2587
2588 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2589 (ctagsfiles3): New variable, includes only *.m files.
2590 (TAGS): Use an explicit language name in the regular expressions,
2591 to avoid transformation of '/SOMETHING' by MSYS to
2592 'c:\MSYS\SOMETHING'.
2593
6c0a9ed1
RC
25942013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2595
2596 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2597
9ef6111b
EZ
25982013-06-06 Eli Zaretskii <eliz@gnu.org>
2599
2600 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2601 still need to set the mouse pointer shape and activate help-echo.
2602 (Bug#14558)
2603
7d300d64
PE
26042013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2605
2606 A few porting etc. fixes for the new file monitor code.
2607 See the thread containing
2608 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2609 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2610 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2611 (dir_monitor_callback, Fgfile_rm_watch):
2612 Use assq_no_quit instead of Fassoc, for speed.
2613 (dir_monitor_callback, Fgfile_rm_watch):
2614 eassert that the monitor is a fixnum.
2615 (dir_monitor_callback): No need for CDR_SAFE.
2616 Simplify building of lisp with alternative tails.
2617 (Fgfile_add_watch, Fgfile_rm_watch):
2618 Do not assume glib functions set errno reliably on failure.
2619 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2620 and signal an error otherwise.
2621 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2622 Use Fdelq instead of Fdelete, for speed.
2623
817ebfcf
EZ
26242013-06-05 Eli Zaretskii <eliz@gnu.org>
2625
2626 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2627 don't insist on being invoked on a highlighted tool-bar button.
2628 Avoids losing tool-bar functionality when mouse-highlight is nil.
2629 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2630 Don't highlight when mouse-highlight is nil.
2631 (note_mouse_highlight): When mouse-highlight is nil, don't return
2632 right away; instead, run tool-bar and mode-line highlight
2633 subroutine, clear any existing highlight, and revert the mouse
2634 pointer to its default shape. (Bug#14558)
2635
55577e7c
SM
26362013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2637
2638 * lisp.mk (lisp): Add prog-mode.el.
2639
f019a684
PE
26402013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2643 * process.c (dummy_handler): New function.
2644 (lib_child_handler): New static var.
2645 (handle_child_signal): Invoke it.
2646 (catch_child_signal): If a library has set up a signal handler,
2647 save it into lib_child_handler.
2648 (init_process_emacs): If using glib and not on Windows, tickle glib's
2649 child-handling code so that it initializes its private SIGCHLD handler.
2650 * syssignal.h (SA_SIGINFO): Default to 0.
2651 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2652 31; it should no longer be needed now.
2653
90db8702
MA
26542013-06-05 Michael Albinus <michael.albinus@gmx.de>
2655
2656 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2657
2658 * gfilenotify.c (globals_of_gfilenotify): New function.
2659 (syms_of_gfilenotify): Move global initialization there.
2660
2661 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2662
bfa3acd6
SM
26632013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2664
2665 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2666 * keyboard.c (menu_bar_items, tool_bar_items):
2667 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2668 not override local keymaps any more.
2669
ba59bd80
EZ
26702013-06-04 Eli Zaretskii <eliz@gnu.org>
2671
2672 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2673
7f203aa1
EZ
26742013-06-03 Eli Zaretskii <eliz@gnu.org>
2675
9337e206
EZ
2676 * w32console.c (initialize_w32_display): Return the dimensions of
2677 the console window via 2 additional arguments, not via the current
2678 frame. This avoids crashes due to overrunning the bounds of
2679 frame's decode_mode_spec_buffer, which is not resized following
2680 the change of the frame dimensions from the initial 10x10.
2681
2682 * w32term.h (w32_initialize_display_info): Adjust prototype.
2683
2684 * term.c (init_tty): Take dimensions of the frame from the values
2685 returned by initialize_w32_display.
2686
7f203aa1
EZ
2687 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2688 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2689 (LIBES): Add $(GFILENOTIFY_LIBS).
2690
2691 * w32inevt.c (handle_file_notifications): Add dummy implementation
2692 for !HAVE_W32NOTIFY.
2693
2694 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2695
55a87246
JD
26962013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2697
2698 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2699
2700 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2701
2702 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2703
3d5ee10a
PE
27042013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 Fix minor problems found by static checking.
2707 * data.c (pure_write_error):
2708 Use xsignal2, not Fsignal, as Fsignal might return.
2709 * eval.c (set_backtrace_debug_on_exit): Now static.
2710 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2711 No longer inline. EXTERN_INLINE is needed only for functions
2712 defined in .h files. Reindent function header as per GNU style.
2713 (backtrace_p, backtrace_top, backtrace_next):
2714 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2715 compiler or linker. Add extern decls to pacify gcc -Wall.
2716 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2717 Now static.
2718 * frame.c (free_monitors): Define only on platforms that need it.
2719 * nsterm.m (ns_term_init):
2720 * process.c (catch_child_signal):
2721 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2722 defined on all porting targets these days.
2723 * process.c, process.h (catch_child_signal):
2724 Make it extern only if NS_IMPL_GNUSTEP is defined.
2725
e2d8a6f0
EZ
27262013-06-03 Eli Zaretskii <eliz@gnu.org>
2727
2728 * w32.c (gettimeofday): Make the signature identical to prototype
2729 in nt/inc/sys/time.h.
2730
a8a7c5f6
SM
27312013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2732
2733 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2734 .gdbinit.
2735
2736 * keyboard.c (safe_run_hooks_error): Improve error message.
2737
2738 * data.c (pure_write_error): Add `object' argument.
2739 * puresize.h (CHECK_IMPURE): Use it.
2740
c9628c79
MA
27412013-06-03 Michael Albinus <michael.albinus@gmx.de>
2742
2743 * Makefile.in (NOTIFY_OBJ): New variable.
2744 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2745
2746 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2747 Call syms_of_gfilenotify.
2748
2749 * gfilenotify.c: New file.
2750
2751 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2752 and Qfile_w32notify.
2753 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2754 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2755
2756 * lisp.h: Declare syms_of_gfilenotify.
2757
2758 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2759
2f592f95
SM
27602013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2761
2762 Merge the specpdl and backtrace stacks. Make the structure of the
2763 specpdl entries more obvious via a tagged union of structs.
2764 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2765 (enum specbind_tag): New enum.
2766 (struct specbinding): Make it a tagged union of structs.
2767 Add a case for backtrace records.
2768 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2769 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2770 (backtrace_debug_on_exit): New accessors.
2771 (struct backtrace): Remove.
2772 (struct catchtag): Remove backlist field.
2773 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2774 Move to eval.c.
2775 (Flocal_variable_p): Speed up the common case where the binding is
2776 already loaded.
2777 * eval.c (backtrace_list): Remove.
2778 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2779 (set_backtrace_args, set_backtrace_nargs)
2780 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2781 (backtrace_next): New functions.
2782 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2783 (unwind_to_catch, internal_lisp_condition_case)
2784 (internal_condition_case, internal_condition_case_1)
2785 (internal_condition_case_2, internal_condition_case_n): Don't bother
2786 with backtrace_list any more.
2787 (Fsignal): Adjust to new backtrace format.
2788 (grow_specpdl): Move up.
2789 (record_in_backtrace): New function.
2790 (eval_sub, Ffuncall): Use it.
2791 (apply_lambda): Adjust to new backtrace format.
2792 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2793 data.c.
2794 (specbind): Adjust to new specpdl format. Simplify.
2795 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2796 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2797 backtrace format.
2798 (mark_backtrace): Remove.
2799 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2800 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2801 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2802 Use mark_specpdl.
2803 * profiler.c (record_backtrace): Use get_backtrace.
2804 (handle_profiler_signal): Use backtrace_top_function.
2805 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2806 accessor functions.
2807
c0342369
JD
28082013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2809
2810 * process.h (catch_child_signal): Declare.
2811
2812 * process.c (catch_child_signal): New function.
2813 (init_process_emacs): Call it.
2814
2815 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2816 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2817 NS_IMPL_COCOA.
2818 (x_set_cursor_type): Remove declaration.
2819 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2820 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2821 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2822 (ns_get_color): Use F suffix on float.
2823 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2824 (ns_get_rgb_color): Remove.
2825 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2826 (note_mouse_movement): x and y are CGFloat.
2827 (ns_draw_fringe_bitmap): Remove unused rowY.
2828 Change #if to COCOA && >= 10_6.
2829 (ns_draw_window_cursor): Remove unused overspill.
2830 (ns_draw_underwave): width and x are EamcsCGFloat.
2831 (ns_draw_box): thickness is CGFloat.
2832 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2833 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2834 if not in main thread.
2835 (ns_get_pending_menu_title, ns_check_menu_open)
2836 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2837 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2838 (sendFromMainThread:): New method.
2839 (changeFont:): size is CGFloat.
2840 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2841 Disable warning about permanent text.
2842 (characterIndexForPoint:): Adjust return type depending on GNUStep
2843 version.
2844 (mouseDown:): delta is CGFloat.
2845 (updateFrameSize): Remove unised variable f.
2846 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2847 Cast float to EmacsCGFloat.
2848 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2849 also to -1 when restoring.
2850 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2851 inside NS_IMPL_COCOA.
2852 (toggleFullScreen:): Put call to toggleFullScreen inside
2853 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2854 (setPosition:portion:whole:): por is CGFloat.
2855 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2856 (mouseDown:): Use CGFloat.
2857 (mouseDragged:): Remove unised variable edge.
2858 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2859
2860 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2861 of CGFloat differs.
2862 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2863 when NS_IMPL_GNUSTEP.
2864 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2865 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2866 (EmacsToolbar): Add clearAll. Add tag argument to
2867 addDisplayItemWithImage.
2868 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2869
2870 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2871
2872 * nsmenu.m (ns_update_menubar): Make static.
2873 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2874 (fillWithWidgetValue:): Add cast to SEL for setAction.
2875 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2876 (update_frame_tool_bar): Update code for GNUStep.
2877 (clearAll): New method.
2878 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2879 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2880 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2881 call to insertItemWithItemIdentifier.
2882 (validateVisibleItems): Fix indentation.
2883 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2884 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2885 UtilityWindow to aStyle, remove call to setStyleMask.
2886
2887 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2888
2889 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2890 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2891 Use F suffix on floats.
2892 (ns_char_width): Returns CGFloat.
2893 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2894 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2895 DPSxshow.
2896 (ns_glyph_metrics): CGFloat instead of float.
2897
a0eb10b3
JB
2898 * nsfns.m (x_set_foreground_color, x_set_background_color):
2899 Use EmacsCGFloat.
2900 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2901 remove unused variables.
2902 (Fns_read_file_name): Keep track if panel is for save.
2903 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2904 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2905 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2906 Just return the input if GNUStep.
c0342369
JD
2907 (x_screen_planes): Remove.
2908 (Fxw_color_values): Use EmacsCGFloat
2909 (Fns_display_monitor_attributes_list): Only get screen number for
2910 Cocoa.
ef099a94 2911 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2912 EmacsSavePanel.
2913 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2914 ns_directory_from_panel.
2915
da9aff11
PE
29162013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 * process.c (handle_child_signal): Also use WCONTINUED.
2919 This is so that list-processes doesn't mistakenly list the process
2920 as stopped, when the process has actually been continued and is
2921 now running.
2922
0e64479a
PE
29232013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2924
fc186a96
PE
2925 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2926 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2927 not already configured.
2928
0e64479a
PE
2929 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2930
38b787fa
EZ
29312013-05-29 Eli Zaretskii <eliz@gnu.org>
2932
2933 * Makefile.in (mostlyclean): Remove *.res files.
2934
22513e52
SM
29352013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2936
2937 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2938 a buffer (bug#8447).
2939
6ef3db10
EZ
29402013-05-27 Eli Zaretskii <eliz@gnu.org>
2941
2942 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2943 display vector, and we backtrack, handle the case that the
2944 previous character position is also displayed from a display
2945 vector or covered by a display string or image. (Bug#14476)
2946
6799bb26
JD
29472013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2948
2949 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2950 (struct MonitorInfo, free_monitors): Remove.
2951 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2952 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2953 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2954 Qframes, Qsource.
2955
2956 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2957 (struct MonitorInfo, free_monitors): Remove.
2958 (ns_screen_name): Make static.
2959 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2960 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2961 Qframes, Qsource.
2962
2963 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2964 (struct MonitorInfo): New struct.
2965 (free_monitors, make_monitor_attribute_list): Declare.
2966
22513e52
SM
2967 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2968 New Lisp_Object:s.
6799bb26
JD
2969 (free_monitors, make_monitor_attribute_list): New functions.
2970 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2971 Qsource.
2972
38cd43eb
XF
29732013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2974
2975 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2976
2af0948d
SM
29772013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2978
a7eb9b0f
SM
2979 * keyboard.c: Apply keyboard decoding only to events that come directly
2980 from the tty, not from unread-command-events (bug#14368).
2981 (read_event_from_main_queue): New function, extracted from read_char).
2982 (read_decoded_char): Remove.
2983 (read_decoded_event_from_main_queue): New function to replace it.
2984 (read_char): Use it.
2985 (read_key_sequence): Use read_char rather than read_decoded_char.
2986
2af0948d
SM
2987 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2988
1413e9a5
BR
29892013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2990
2991 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2992
e6d2f155
KH
29932013-05-22 Kenichi Handa <handa@gnu.org>
2994
2995 The following changes are to fix the setting of
2996 buffer-file-coding-system on, for instance, C-x RET c unix RET
2997 _FILE_OF_DOS_EOL_TYPE_ RET.
2998
2999 * coding.h (struct coding_system): New member detected_utf8_chars.
3000
3001 * coding.c (detect_coding_utf_8): Count characters and check EOL
3002 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3003 BOM is there.
3004 (setup_coding_system): Do not initialize coding->head_ascii.
3005 (check_ascii): Do not set coding->eol_seen but update it. Do not
3006 call adjust_coding_eol_type here.
1413e9a5
BR
3007 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3008 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3009 of the found coding-system.
3010 (decode_coding_gap): Cancel previous change. Utilize the
3011 character numbers counted by detect_coding_utf_8. Fix detection
3012 of BOM for utf-8.
3013
ab56a6f4 30142013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3015
3016 * search.c (looking_at_1): Only set last_thing_searched if the match
3017 changed the match-data (bug#14281).
3018
ecc3c6ed
DA
30192013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3020
3021 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3022 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3023 (move_it_vertically_backward): Likewise.
3024
5ba8bf35
YM
30252013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3026
3027 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3028 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3029 (Fx_display_mm_width, Fx_display_mm_height):
3030 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3031
91e8418b 3032 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3033 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3034 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3035 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3036 (Fx_display_backing_store, Fx_display_visual_class)
3037 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3038 (Fx_display_grayscale_p, Fx_display_pixel_width)
3039 (Fx_display_pixel_height, Fx_display_planes)
3040 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3041 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3042 (Fx_display_mm_width, Fx_display_mm_height)
3043 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3044 height for all physical monitors as in X11.
3045
fc30d803
SM
3046 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3047 Return pixel width or height for all physical monitors as in X11.
91e8418b 3048
31ff141c
PE
30492013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 Port --enable-gcc-warnings to clang.
3052 * bytecode.c (exec_byte_code):
3053 * regex.c:
3054 Redo diagnostic pragmas to pacify clang, too.
3055 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3056 * editfns.c (Fencode_time):
3057 * fileio.c (file_accessible_directory_p):
3058 * font.c (font_unparse_xlfd):
3059 Use '&"string"[index]' instead of '"string" + (index)'.
3060 * undo.c (user_error): Remove; unused.
3061
df065a0b
EZ
30622013-05-16 Eli Zaretskii <eliz@gnu.org>
3063
04d360e7
EZ
3064 * insdel.c (insert_1_both): Document the arguments, instead of
3065 referring to insert_1, which no longer exists.
3066
5bb98290
EZ
3067 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3068 some window, increment windows_or_buffers_changed, so that
3069 *Messages* display in that window is updated. (Bug#14408)
3070
df065a0b
EZ
3071 * w32.c: Include epaths.h.
3072 (init_environment): Use cmdproxy.exe without leading directories.
3073 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3074 case.
3075 (gettimeofday): Adjust signature and return value to Posix
3076 expectations.
3077
3078 * unexw32.c (open_output_file): Delete the existing emacs.exe
3079 before creating it, to break the hard link to the versioned
3080 executable.
3081
3082 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3083 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3084 (FIRSTFILE_OBJ): New variables.
3085 (W32_RES): Rename to EMACSRES. All users changed.
3086 (base_obj): Use $(CM_OBJ).
3087 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3088 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3089 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3090 $(W32_RES_LINK) before $(LIBES).
3091 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3092
1aa8d505
SM
30932013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3094
6e911150
SM
3095 * makefile.w32-in (DOC): Use just "DOC".
3096
3097 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3098
1aa8d505
SM
3099 * process.c: Export default filters and sentinels to Elisp.
3100 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3101 New constants.
3102 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3103 (Fset_process_sentinel, Fformat_network_address):
3104 Default to them instead of nil.
3105 (server_accept_connection): Sentinels can't be nil any more.
3106 (read_and_dispose_of_process_output): New function, extracted from
3107 read_process_output.
3108 (read_process_output): Use it; filters can't be nil.
3109 (Finternal_default_process_filter): New function, extracted from
3110 read_process_output.
3111 (exec_sentinel_unwind): Remove function.
3112 (exec_sentinel): Don't zilch sentinel while running.
3113 (status_notify): Sentinels can't be nil.
3114 (Finternal_default_process_sentinel): New function extracted from
3115 status_notify.
3116 (setup_process_coding_systems): Default filter is not nil any more.
3117 (syms_of_process): Export new Elisp functions and initialize
3118 new constants.
3119 * lisp.h (make_lisp_proc): New function.
3120
5ac2eb34
SM
31212013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3122
3123 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3124
eda9c7d7
EZ
31252013-05-14 Eli Zaretskii <eliz@gnu.org>
3126
3127 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3128 unless we know that the window w is a leaf window.
3129 Another attempt at solving bug#14062.
eda9c7d7 3130
8fdeaad5
JD
31312013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3132
3133 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3134 fdesc (Bug#14375).
3135
44aa9ee6
PE
31362013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 * image.c (gif_load): Check that subimages fit (Bug#14345).
3139
759fd763
SM
31402013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3141
3142 * lread.c (skip_dyn_eof): New function.
3143 (read1): Use it to skip the end of a file in response to #@00.
3144
3145 * doc.c (get_doc_string): Slightly relax the sanity checking.
3146
4465bfb4
JD
31472013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3148
3149 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3150 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3151 (MonitorInfo): New struct.
3152 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3153 (Fns_display_monitor_attributes_list): New functions.
3154 (display-usable-bounds): Remove.
3155 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3156 Qsource.
3157
7583e2a0
PE
31582013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3161 (GTK_CHECK_VERSION): New macro, if not already defined.
3162 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3163 replaced by GTK_CHECK_VERSION.
3164
ad75d77e
PE
31652013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 * xterm.h (GTK_PREREQ): New macro.
3168 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3169 to use this macro instead, for consistency and clarity.
3170
07525f77
EZ
31712013-05-08 Eli Zaretskii <eliz@gnu.org>
3172
3173 * xdisp.c (row_for_charpos_p): New function, with code of
3174 cursor_row_p, but accepts an additional argument CHARPOS instead
3175 of using a hardcoded PT.
3176 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3177 (row_containing_pos): Call row_for_charpos_p instead of partially
3178 doing the same. Fixes cursor positioning under longlines-mode
3179 when longlines-show-effect includes more than one newline, when
3180 moving the cursor vertically up.
3181
d901fc8d
JB
31822013-05-08 Juanma Barranquero <lekktu@gmail.com>
3183
3184 * makefile.w32-in (ACL_H): New macro.
3185 ($(BLD)/fileio.$(O)): Update dependencies.
3186
f269bc61
PE
31872013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3188
e7b41c4c 3189 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3190 * Makefile.in (LIB_ACL): New macro.
3191 (LIBACL_LIBS): Remove.
3192 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3193 * fileio.c: Include <acl.h>.
3194 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3195 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3196 !acl_errno_valid.
3197 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3198 it ourselves.
3199
f269bc61
PE
3200 * unexelf.c: Don't assume ElfW (Half) fits in int.
3201 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3202 when dealing with ElfW (Half) values, since they can exceed 2**31
3203 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3204 (entry_address): Omit unused NUM arg. All uses changed.
3205
a261c53e
JL
32062013-05-07 Juri Linkov <juri@jurta.org>
3207
3208 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3209 to the string converted from number with `Fnumber_to_string'.
3210 (Bug#14254)
3211
2b66427d
PE
32122013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3213
3214 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3215 This fixes a problem introduced by my previous change.
3216
15acfe41
GM
32172013-05-07 Glenn Morris <rgm@gnu.org>
3218
3219 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3220
5ea03bf5
JD
32212013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3222
3223 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3224
e0c9d565
PE
32252013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 Static checking by GCC 4.8.0.
3228 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3229 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3230 (x_get_monitor_attributes_fallback)
3231 (x_get_monitor_attributes_xinerama)
3232 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3233 Define only if USE_GTK.
3234 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3235 (x_get_monitor_attributes_fallback): Omit unused locals.
3236 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3237 Use double, not float, to avoid mixed-mode floating point arithmetic.
3238
4e3f9230
YM
32392013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3240 Jan Djärv <jan.h.d@swipnet.se>
3241
3242 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3243 (XINERAMA_CFLAGS): New macros.
3244 (ALL_CFLAGS, LIBES): Use them.
3245
3246 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3247 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3248 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3249 (syms_of_xfns): DEFSYM them.
3250 (struct MonitorInfo): New struct.
3251 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3252 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3253 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3254 (x_get_monitor_attributes_xinerama): New functions.
3255 (Fx_display_monitor_attributes_list): New primitive.
3256 (syms_of_xfns): Defsubr it.
3257
3258 * xterm.h (x_display_info): Add Xatom_net_workarea and
3259 Xatom_net_current_desktop.
3260
3261 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3262 and dpyinfo->Xatom_net_current_desktop.
3263
05839b6a
EZ
32642013-05-06 Eli Zaretskii <eliz@gnu.org>
3265
3266 * xdisp.c (pos_visible_p): Use the special code for finding the
3267 beginning of a display property or overlay for any "replacing"
3268 display property, not just for display strings. This solves
3269 incorrect reporting of position by posn-at-point. (Bug#14241)
3270
dc4a2ee0
PE
32712013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3272
5ee94506
PE
3273 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3274 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3275 Verify that ElfW (Half) fits in int.
3276 (fatal): Use same signature as lisp.h.
3277 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3278 configure and build with -DUNEXELF_DEBUG without worrying about
3279 other modules that use DEBUG.
3280 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3281 possibly-wide integers now uses it instead of plain fprintf.
3282 (entry_address): New function, which avoids problems with 32-bit
3283 overflow on 64-bit hosts.
3284 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3285 (round_up): Don't assume the remainder fits in int.
3286 (find_section): Use bool for boolean. Simplify debug code.
3287 (unexec): Don't assume file sizes fit in int or size_t.
3288 Omit unnecessary trailing newline in 'fatal' format.
3289 Use strerror rather than outputting decimal error number.
3290 Remove unused code when emacs is not defined;
3291 this file relies on Emacs now.
3292 Don't assume e_phnum and e_shnum are positive.
3293
dc4a2ee0
PE
3294 * regex.c: Fix problems when DEBUG is defined.
3295 (extract_number, extract_number_and_incr): Define regardless of
3296 whether DEBUG is defined; that's simpler and makes the code less
3297 likely to go stale in the normal case when DEBUG is not defined.
3298 Return int rather than taking an int * arg. All callers changed.
3299 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3300 Remove, replacing with ...
3301 (DEBUG_PRINT): New macro. All callers changed.
3302 (DEBUG_COMPILES_ARGUMENTS): New macro.
3303 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3304 (print_compiled_pattern, print_double_string) [DEBUG]:
3305 Use prototype rather than old-style definition.
3306 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3307 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3308 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3309 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3310 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3311 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3312 This matters only when DEBUG is defined.
3313
14c7ed05
EZ
33142013-05-05 Eli Zaretskii <eliz@gnu.org>
3315
3316 * xdisp.c (set_iterator_to_next): Set the
3317 ignore_overlay_strings_at_pos_p flag only if we are _really_
3318 iterating over an overlay string, as indicated by the
3319 current.overlay_string_index member. (Bug#14306)
3320
e6076b1b
JD
33212013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3322
3323 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3324 to where it is used, to avoid autorelease issues (Bug#14050).
3325
cbee2131
PE
33262013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3327
3328 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3329 * fileio.c (syms_of_fileio): Implement this.
3330 * filelock.c (create_lock_file): If symbolic links don't work, so
3331 we use a regular file as a lock file, do not fsync the lock file;
3332 it's not needed.
3333
30c7e542
SM
33342013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3335
3336 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3337 (syms_of_minibuf): Adjust accodingly.
3338 * lread.c (Fread):
3339 * callint.c (Fcall_interactively): Adjust calls accordingly.
3340
5bebd186
EZ
33412013-05-04 Eli Zaretskii <eliz@gnu.org>
3342
3343 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3344 w->contents is a buffer before computing everything else.
3345 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3346
3347 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3348 assertion violations. (Bug#14062)
3349
0fb0a4f3
DR
33502013-05-01 David Reitter <david.reitter@gmail.com>
3351
3352 * nsfns.m (ns_tooltip): Initialize.
3353
9e63b4a5
EZ
33542013-04-28 Eli Zaretskii <eliz@gnu.org>
3355
3356 * coding.c (decode_coding_gap): Don't remove the character before
3357 a newline unless it's a CR character. (Bug#14287)
3358
ad60824e
DN
33592013-04-28 Dan Nicolaescu <dann@gnu.org>
3360
3361 * dispextern.h (struct face): Move enum face_underline_type
3362 earlier so that bitfields can be in the same word.
3363
edbdcec0
JD
33642013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3365
3366 * nsfns.m (handlePanelKeys): New function.
3367 (EmacsOpenPanel:performKeyEquivalent:)
3368 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3369 arrows/function/control and copy/paste keys (Bug#14296).
3370
0208ede7
JL
33712013-04-27 Juri Linkov <juri@jurta.org>
3372
3373 * callint.c (Fcall_interactively): Call `Qread_number' for
3374 interactive code letter `n' instead of using duplicate code.
3375 (Bug#14254)
3376
b8dd59f7
PE
33772013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 * systime.h (make_timeval): Declare as 'const'.
3380
8bd722db
KH
33812013-04-27 Kenichi Handa <handa@gnu.org>
3382
3383 * font.c (font_open_entity): Always open a font of manageable
3384 size.
3385
13d0e56f 33862013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3387
f780d632
PE
3388 Port better to AIX (Bug#14258).
3389 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3390 to pacify AIX xlc.
3391
ec509856
KH
33922013-04-24 Kenichi Handa <handa@gnu.org>
3393
3394 * coding.c (decode_coding_iso_2022): When an invalid escape
3395 sequence is encountered, reset the invocation and designation
3396 status to the safest one.
3397
84fc48e5
PE
33982013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3399
3400 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3401 Without this fix, "make distclean" leaves stamp-h1 behind.
3402
806bda47
EC
34032013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3404
3405 * w32fns.c (w32_fullscreen_rect): New function to compute the
3406 window rectangle for the given fullscreen mode.
3407 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3408 longer tunes the window size. This keeps the window's edges flush
3409 with the screen and allows the taskbar to hide itself in fullboth.
3410
3411 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3412 window decorations and uses the entire screen.
3413
3414 * w32term.h (w32_fullscreen_rect) Add prototype.
3415 (struct w32_output): Replace normal_width, normal_height,
3416 normal_top, and normal_left members with a single normal_placement
3417 struct.
3418 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3419 Remove macros.
3420 (FRAME_NORMAL_PLACEMENT): New macro.
3421
9cc2810b
JB
34222013-04-16 Juanma Barranquero <lekktu@gmail.com>
3423
3424 * minibuf.c (Ftest_completion): Silence compiler warning.
3425
fd16b54c
EZ
34262013-04-15 Eli Zaretskii <eliz@gnu.org>
3427
3428 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3429 bug#14062.
fd16b54c
EZ
3430
3431 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3432 parentheses.
3433
3434 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3435 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3436 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3437 parentheses where appropriate.
3438
9e3379a0
PE
34392013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3442
ddd6b685
EZ
34432013-04-14 Eli Zaretskii <eliz@gnu.org>
3444
3445 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3446 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3447 Mention in the doc string that setting these variables takes
3448 effect only after a call to set-window-buffer. (Bug#14200)
3449
29b79ba1
EZ
34502013-04-13 Eli Zaretskii <eliz@gnu.org>
3451
3452 * indent.c (Fvertical_motion): Don't consider display strings on
3453 overlay strings as display strings on the buffer position we
3454 started from. This prevents vertical cursor motion from jumping
3455 more than one line when there's an overlay string with a display
3456 property at end of line.
3457 Reported by Karl Chen <Karl.Chen@quarl.org> in
3458 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3459
562c6ee9
SM
34602013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3461
3462 * window.c (select_window): `record_buffer' even if window is
3463 already selected (bug#14191).
3464
fcc1fe85
EZ
34652013-04-11 Eli Zaretskii <eliz@gnu.org>
3466
3467 * window.c (Fwindow_end): Test more flags, including the buffer's
3468 last_overlay_modified flag, to determine whether the window's
3469 display is really up-to-date. Prevents the function from
3470 returning a stale value. (Bug#14170)
3471 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3472 current matrix.
3473
f009190a
EZ
34742013-04-10 Eli Zaretskii <eliz@gnu.org>
3475
3476 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3477 garbaged only if it is not already the top frame on its TTY.
3478 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3479 there are GUI frames open in the same session. (Bug#13864)
3480
78ce603d
SM
34812013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3482
3483 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3484 of marking the idle timers directly.
3485
a8036e40
SM
34862013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3487
3488 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3489 tables (bug#14054).
3490
7ffe7ef6
SM
34912013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3492
3493 * window.c (select_window): Don't record_buffer while the invariant is
3494 temporarily broken (bug#14161).
3495
3496 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3497
7d9f6883
EZ
34982013-04-07 Eli Zaretskii <eliz@gnu.org>
3499
3500 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3501
5406cfd9
RF
35022013-04-07 Romain Francoise <romain@orebokech.com>
3503
3504 Ignore additional platform-specific ACL errors (Bug#13702).
3505 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3506 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3507
95c0e83b
JD
35082013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3509
3510 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3511 f->output_data.ns.
3512
876da980
PE
35132013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3516 This bug was introduced by my 2013-02-25 change that simplified
3517 data_start configuration. Without this change, on GNU/Linux
3518 an Emacs configured with --enable-profiling fails immediately
3519 due to a profiler signal.
3520 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3521 with these flags. On platforms where special flags are needed
3522 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3523 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3524 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3525
7452b7bd
DA
35262013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3527
3528 Get rid of some platform-specific functions examining window
3529 system and its capabilities. This is a partial rework of the
3530 2013-04-05 change.
3531 * lisp.h (have_menus_p): Remove prototype. This function is
3532 replaced with platform-independent window_system_available.
3533 (check_window_system): Move to...
3534 * frame.h (decode_window_system_frame, window_system_available):
3535 ...here, add new prototypes.
3536 * frame.c (window_system_available, decode_window_system_frame):
3537 New functions.
3538 (check_window_system): Platform-independent now.
3539 * xterm.h (x_in_use): Remove declaration.
3540 (check_x_frame):
3541 * w32term.h (check_x_frame):
3542 * nsterm.h (check_x_frame): Remove prototypes. This function
3543 is replaced with platform-independent decode_window_system_frame.
3544 * msdos.c (have_menus_p): Remove.
3545 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3546 Remove platform-specific functions. Use check_window_system,
3547 decode_window_system_frame and check_ns_display_info where
3548 appropriate. Minor style and comment tweaks.
3549 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3550 (check_x_frame): Likewise.
3551 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3552 Likewise.
3553 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3554 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3555 * xmenu.c, xselect.c: All related users changed.
3556
251e9147
KH
35572013-04-03 Kenichi Handa <handa@gnu.org>
3558
3559 The following changes is to optimize the code for reading UTF-8
3560 files.
3561
562c6ee9 3562 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3563 changed. Check EOL format. Do not call adjust_coding_eol_type
3564 here.
3565 (check_utf_8): New function.
3566 (adjust_coding_eol_type): Do nothing if already adjusted.
3567 (detect_coding): Compare the return value of check_ascii with
3568 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3569 (decode_coding_gap): Optimize for valid UTF-8.
3570
8bc369d4
KH
35712013-03-21 Kenichi Handa <handa@gnu.org>
3572
3573 * coding.c (syms_of_coding): Cancel previous change.
3574
3575 * insdel.c (insert_from_gap): Fix previous change.
3576
73931ad1
DA
35772013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3578
3579 Consistently use platform-specific function to detect window system.
3580 * lisp.h (check_window_system): New prototype. This function is
3581 going to replace check_x, check_w32 and check_ns.
3582 (have_menus_p): Mention msdos.c in comment.
3583 * fontset.c (check_window_system_func): Remove. Adjust all users.
3584 * fontset.h (check_window_system_func): Remove prototype.
3585 * nsterm.h (check_ns):
3586 * xterm.h (check_x):
3587 * w32term.h (check_w32): Likewise.
3588 * menu.c (Fx_popup_menu): Use check_window_system.
3589 * msdos.c (check_window_system): Define for MS-DOS.
3590 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3591 * w32fns.c (check_window_system): Likewise for MS-Windows.
3592 * xfns.c (check_window_system): Likewise for X.
3593 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3594 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3595
7216e43b
PE
35962013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3597
3598 Prefer < to > in range checks such as 0 <= i && i < N.
3599 This makes it easier to visualize quantities on a number line.
3600 This patch doesn't apply to all such range checks,
3601 only to the range checks affected by the 2013-03-24 change.
3602 This patch reverts most of the 2013-03-24 change.
3603 * alloc.c (xpalloc, Fgarbage_collect):
3604 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3605 * character.c (string_escape_byte8):
3606 * charset.c (read_hex):
3607 * data.c (cons_to_unsigned):
3608 * dispnew.c (update_frame_1):
3609 * doc.c (Fsubstitute_command_keys):
3610 * doprnt.c (doprnt):
3611 * editfns.c (hi_time, decode_time_components):
3612 * fileio.c (file_offset):
3613 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3614 * font.c (font_intern_prop):
3615 * frame.c (x_set_alpha):
3616 * gtkutil.c (get_utf8_string):
3617 * indent.c (check_display_width):
3618 * keymap.c (Fkey_description):
3619 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3620 * lread.c (read1):
3621 * minibuf.c (read_minibuf_noninteractive):
3622 * process.c (wait_reading_process_output):
3623 * search.c (Freplace_match):
3624 * window.c (get_phys_cursor_glyph):
3625 * xdisp.c (redisplay_internal):
3626 * xsmfns.c (smc_save_yourself_CB):
3627 Prefer < to > for range checks.
3628 * dispnew.c (sit_for): Don't mishandle NaNs.
3629 This fixes a bug introduced in the 2013-03-24 change.
3630 * editfns.c (decode_time_components): Don't hoist comparison.
3631 This fixes another bug introduced in the 2013-03-24 change.
3632
92759988
DA
36332013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3634
3635 * frame.h (struct frame): Drop scroll_bottom_vpos
3636 member becaue all real users are dead long ago.
3637 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3638 * xdisp.c (redisplay_internal): Adjust user.
3639
9a1971bb
GM
36402013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3641
f38ab167
JD
3642 * nsmenu.m (showAtX:Y:for:): setLevel to
3643 NSPopUpMenuWindowLevel (Bug#13998).
3644
6d01f1fe
JD
36452013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3646
3647 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3648 (ns_check_pending_open_menu): Declare.
3649
3650 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3651 (x_activate_menubar): Update the menu with title that matches
3652 ns_get_pending_menu_title, and call
3653 ns_check_pending_openmenu (Bug#12698).
3654 (menuWillOpen:): New method.
3655 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3656
3657 * nsterm.m (menu_will_open_state, menu_mouse_point)
3658 (menu_pending_title): New varaibles.
3659 (ns_get_pending_menu_title, ns_check_menu_open)
3660 (ns_check_pending_open_menu): New functions.
3661
781f4782
DA
36622013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3663
3664 * indent.c (current_column_bol_cache): Remove leftover which is not
3665 used in Fmove_to_column any more.
3666 (current_column, scan_for_column): Adjust users.
3667 * keyboard.c (last_point_position_buffer, last_point_position_window):
3668 Remove leftovers which are not used for recording undo any more.
3669 (command_loop_1, syms_of_keyboard): Adjust users.
3670 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3671 redisplay_window any more.
3672 (move_it_to): Adjust user.
3673
1921c31b
JB
36742013-03-29 Juanma Barranquero <lekktu@gmail.com>
3675
3676 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3677 Update dependencies.
3678
717b8bcd
SM
36792013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3680
3681 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3682 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3683 forward references.
3684
e74aeda8
DA
36852013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3686
3687 * window.h (struct window): Replace hchild, vchild and buffer slots
3688 with the only contents slot. This is possible because each valid
3689 window may have either the child window (in vertical or horizontal
3690 combination) or buffer to display (for the leaf window). Using that,
3691 a lof of operations to traverse and/or change window hierarchies may
3692 be simplified. New member horizontal is used to distinguish between
3693 horizontal and vertical combinations of internal windows.
3694 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3695 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3696 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3697 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3698 Use contents slot, not buffer, where appropriate.
3699 (wset_combination): New function.
3700 (wset_buffer): Add eassert.
3701 (Fframe_first_window): Simplify the loop reaching first window.
3702 (Fwindow_buffer): Use WINDOW_LEAF_P.
3703 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3704 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3705 (unshow_buffer): Convert initial debugging check to eassert.
3706 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3707 (make_parent_window, window_resize_check, window_resize_apply)
3708 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3709 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3710 Adjust to match struct window changes.
3711 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3712 (mark_window_cursors_off, count_windows, get_leaf_windows)
3713 (foreach_window_1): Simplify the loop.
3714 * alloc.c (mark_object): Do not check for the leaf window because
3715 internal windows has no glyph matrices anyway.
3716 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3717 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3718 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3719 (build_frame_matrix_from_window_tree, mirror_make_current)
3720 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3721 (update_window_tree, set_window_update_flags): Simplify the loop.
3722 (sync_window_with_frame_matrix_rows): Enforce live window.
3723 Use contents slot, not buffer, where appropriate.
3724 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3725 and WINDOW_HORIZONTAL_COMBINATION_P.
3726 (make_frame_visible_1): Simplify the loop.
3727 Use contents slot, not buffer, where appropriate.
3728 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3729 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3730 (expose_window_tree): Likewise.
3731 Use contents slot, not buffer, where appropriate.
3732 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3733 to avoid deleted windows. Use contents slot instead of buffer.
3734 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3735 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3736 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3737 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3738
121ab1cd
EZ
37392013-03-28 Eli Zaretskii <eliz@gnu.org>
3740
ef454cf7
EZ
3741 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3742 identify the reasons for assertion violations in bug#14062 and
3743 similar ones.
21e930f8
EZ
3744 (Fx_show_tip): Fix compilation error under
3745 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3746
121ab1cd
EZ
3747 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3748 Reported by <rzl24ozi@gmail.com>.
3749
5c89ca24
DA
37502013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3751
3752 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3753 start marker...
562c6ee9
SM
3754 (unwind_with_echo_area_buffer): ...to restore it here.
3755 This is needed to ensure that...
5c89ca24
DA
3756 (redisplay_window): ...both window markers are valid here,
3757 which is verified by eassert.
3758 * editfns.c (save_excursion_save): Do not assume that
3759 selected_window always displays the buffer.
c7f53895
DA
3760 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3761 Fix comment.
5c89ca24 3762
f557c1b1
SM
37632013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3764
3765 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3766 the upcase table.
3767
40693bba 37682013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3769
3770 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3771
c86f791f
EZ
37722013-03-27 Eli Zaretskii <eliz@gnu.org>
3773
3774 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3775 since MinGW's w32api headers do. This avoids compiler warnings.
3776
3777 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3778 if already defined.
3779
c6e72e17
EZ
37802013-03-26 Eli Zaretskii <eliz@gnu.org>
3781
3782 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3783
54e95010
JD
37842013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3785
3786 * gtkutil.c (style_changed_cb): Check if frame is live and an
3787 X frame (Bug#14038).
3788
b88b62de
EZ
37892013-03-26 Eli Zaretskii <eliz@gnu.org>
3790
a18d7de6
EZ
3791 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3792 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3793 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3794 MinGW64.
8f5e14c8
EZ
3795 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3796 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3797
b88b62de
EZ
3798 Fix incompatibilities between MinGW.org and MinGW64 headers.
3799 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3800
3801 * w32.c (REPARSE_DATA_BUFFER): Guard with
3802 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3803
c074e458
JD
38042013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3805
3806 * xterm.c: Include X11/XKBlib.h
3807 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3808
908589fd
AS
38092013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3810
3811 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3812 written backwards.
3813 * blockinput.h (input_blocked_p): Likewise.
3814 * bytecode.c (exec_byte_code): Likewise.
3815 * callproc.c (call_process_kill, call_process_cleanup)
3816 (Fcall_process): Likewise.
3817 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3818 (Fccl_execute_on_string): Likewise.
3819 * character.c (string_escape_byte8): Likewise.
3820 * charset.c (read_hex): Likewise.
3821 * cm.c (calccost): Likewise.
3822 * data.c (cons_to_unsigned): Likewise.
3823 * dired.c (directory_files_internal, file_name_completion):
3824 Likewise.
3825 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3826 (sit_for): Likewise.
3827 * doc.c (Fsubstitute_command_keys): Likewise.
3828 * doprnt.c (doprnt): Likewise.
3829 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3830 * emacsgtkfixed.c: Likewise.
3831 * fileio.c (file_offset, Fwrite_region): Likewise.
3832 * floatfns.c (Fexpt, fmod_float): Likewise.
3833 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3834 Likewise.
3835 * font.c (font_intern_prop): Likewise.
3836 * frame.c (x_set_alpha): Likewise.
3837 * gtkutil.c (get_utf8_string): Likewise.
3838 * indent.c (check_display_width): Likewise.
3839 * intervals.c (create_root_interval, rotate_right, rotate_left)
3840 (split_interval_right, split_interval_left)
3841 (adjust_intervals_for_insertion, delete_node)
3842 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3843 (merge_interval_right, merge_interval_left, copy_intervals)
3844 (set_intervals_multibyte_1): Likewise.
3845 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3846 * keymap.c (Fkey_description): Likewise.
3847 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3848 * lread.c (openp, read_integer, read1, string_to_number):
3849 Likewise.
3850 * menu.c (ensure_menu_items): Likewise.
3851 * minibuf.c (read_minibuf_noninteractive): Likewise.
3852 * print.c (printchar, strout): Likewise.
3853 * process.c (create_process, Faccept_process_output)
3854 (wait_reading_process_output, read_process_output, send_process)
3855 (wait_reading_process_output): Likewise.
3856 * profiler.c (make_log, handle_profiler_signal): Likewise.
3857 * regex.c (re_exec): Likewise.
3858 * regex.h: Likewise.
3859 * search.c (looking_at_1, Freplace_match): Likewise.
3860 * sysdep.c (get_child_status, procfs_ttyname)
3861 (procfs_get_total_memory): Likewise.
3862 * systime.h (EMACS_TIME_VALID_P): Likewise.
3863 * term.c (dissociate_if_controlling_tty): Likewise.
3864 * window.c (get_phys_cursor_glyph): Likewise.
3865 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3866 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3867 Likewise.
3868 * xfns.c (Fx_window_property): Likewise.
3869 * xmenu.c (set_frame_menubar): Likewise.
3870 * xselect.c (x_get_window_property, x_handle_dnd_message):
3871 Likewise.
3872 * xsmfns.c (smc_save_yourself_CB): Likewise.
3873 * xterm.c (x_scroll_bar_set_handle): Likewise.
3874
2bf7d27a
DA
38752013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3876
3877 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3878 to be optional or nil. Adjust comment and convert it to docstring.
3879 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3880 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3881
a9ebfa0b
PE
38822013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3883
3884 Static checking by GCC 4.8-20130319.
3885 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3886 * process.c (Fset_process_datagram_address)
3887 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3888 * xdisp.c (get_char_face_and_encoding):
3889 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3890 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3891 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3892
4f3576ee
KB
38932013-03-24 Ken Brown <kbrown@cornell.edu>
3894
789b5e9a
KB
3895 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3896 fix compilation on 64-bit Cygwin, where underscores are not
3897 automatically prepended.
3898
4f3576ee
KB
3899 * w32term.c (w32_initialize): Silence compiler warning.
3900
b5b7745f
EZ
39012013-03-23 Eli Zaretskii <eliz@gnu.org>
3902
cdc0d0bd
EZ
3903 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3904 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3905 variables, to save and restore frame dimensions.
3906 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3907 after returning from a 'fullscreen' configuration.
3908 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3909 to avoid races between the main thread and the input thread.
3910
3911 * w32term.h (struct w32_output): New members normal_width,
3912 normal_height, normal_top, normal_left, and prev_fsmode.
3913 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3914 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3915 members of a frame.
3916
b5b7745f
EZ
3917 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3918 'fullscreen' parameter. Always record previous width and height
3919 of the frame, except when switching out of maximized modes, so
3920 that they could be restored correctly, instead of resetting to the
3921 default frame dimensions. Send SC_RESTORE command to the frame,
3922 unless we are going to send SC_MAXIMIZE, to restore the frame
3923 resize hints in the mouse pointer shown by the window manager.
3924 (Bug#14032)
3925
3926 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3927
3928 * lisp.h (get_frame_param): Adjust conditions for prototype
3929 declaration.
3930
a3454eed
KB
39312013-03-22 Ken Brown <kbrown@cornell.edu>
3932
3933 * unexcw.c: Drop unneeded inclusion of w32common.h.
3934 (report_sheap_usage): Declare.
3935 (read_exe_header): Add magic numbers for x86_64.
3936 (fixup_executable): Fix printf format specifier for unsigned long
3937 argument.
3938
5a49b79c
DA
39392013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3940
3941 * frame.h (struct frame): Put menu_bar_window under #ifdef
3942 because this member is not needed when X toolkit is in use.
3943 (fset_menu_bar_window):
3944 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3945 (free_glyphs, update_frame):
3946 * xdisp.c (expose_frame): Likewise.
3947 (display_menu_bar): Likewise. Remove redundant eassert.
3948 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3949 toolkit is in use.
3950
d6723bf7
PE
39512013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3952
7b1123d8
PE
3953 Use functions and constants to manipulate Lisp_Save_Value objects.
3954 This replaces code that used macros and strings and token-pasting.
3955 The change makes the C source a bit easier to follow,
3956 and shrinks the Emacs executable a bit.
3957 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3958 (make_save_value): Change 1st arg from string to enum. All callers
3959 changed.
3960 (INTX): Remove.
3961 (mark_object): Use if, not #if, for GC_MARK_STACK.
3962 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3963 (XSAVE_OBJECT): Now functions, not macros.
3964 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3965 the constant was never used.
3966 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3967 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3968 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3969 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3970 New constants.
3971 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3972 type3 with a single member save_type. All uses changed.
3973 (save_type, set_save_pointer, set_save_integer): New functions.
3974 * print.c (PRINTX): Remove.
3975
d6723bf7
PE
3976 * alloc.c: Remove redundant static declarations.
3977
5f24fa51
DA
39782013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3979
3980 * window.h (struct window): Convert left_col, top_line, total_lines
3981 and total_cols from Lisp_Objects to integers. Adjust comments.
3982 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3983 Remove.
3984 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3985 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3986 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3987 Adjust users where appropriate.
3988
42143acd
DA
39892013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3990
3991 * frame.h (struct frame): Drop resx and resy because the same data is
3992 available from window system-specific output context. Adjust users.
562c6ee9
SM
3993 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3994 New functions to provide defaults when no window system available.
42143acd 3995 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3996 (NUMVAL): Move from xdisp.c.
42143acd
DA
3997 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3998 (Ffont_face_attributes, Fopen_font):
3999 * image.c (gs_load):
4000 * w32font.c (fill_in_logfont):
4001 * xdisp.c (calc_pixel_width_or_height):
4002 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4003 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4004
c0a17406
KH
40052013-03-20 Kenichi Handa <handa@gnu.org>
4006
4007 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4008 to 1 (temporary workaround until a bug related to ASCII
4009 optimization is fixed).
4010
095d384d
DA
40112013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4012
4013 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4014 Signal error if window is not internal. Adjust docstring.
4015 (delete_all_child_windows): Use combination_limit to save the buffer.
4016 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4017 * print.c (syms_of_print): Initialize debugging output not here...
4018 (init_print_once): ...but in a new function here.
4019 * lisp.h (init_print_once): Add prototype.
4020 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4021
748fa866
DA
40222013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4023
4024 * window.c (window_resize_check, window_resize_apply)
4025 (window_from_coordinates, recombine_windows, set_window_buffer)
4026 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4027 (Fsplit_window_internal, Fdelete_window_internal)
4028 (freeze_window_starts): Use bool for booleans.
4029 * window.h (window_frame_coordinates, resize_frame_windows)
4030 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4031
81519fd2
SM
40322013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4033
4034 * dispnew.c (bitch_at_user): Use `user-error'.
4035
6db423a9
KB
40362013-03-17 Ken Brown <kbrown@cornell.edu>
4037
4038 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4039 as return type of image_background. (Bug#13981)
4040 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4041
8f2906f5
JD
40422013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4043
960ce480 4044 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4045 (ns_select): Don't return with result uninitialized.
960ce480 4046
8f2906f5
JD
4047 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4048 and getDirectory.
4049
81519fd2
SM
4050 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4051 New functions.
8f2906f5
JD
4052 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4053 directories. If filename is nil, get directory name (Bug#13932).
4054 Use getFilename and getDirectory.
4055 (getFilename, getDirectory): New methods for EmacsSavePanel and
4056 EmacsOpenPanel.
4057 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4058
cded56c1
PE
40592013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4060
4061 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4062
251e9147 40632013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4064
4065 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4066 (adjust_after_replace): Make it back to static. Delete the third
4067 arg text_at_gap_tail. Cancel the code for handling it.
4068
4069 * coding.h (struct coding_system): New member eol_seen.
4070
4071 * coding.c (detect_ascii): New function.
4072 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4073 when the source bytes are actually scanned. On detecting for
4074 coding_category_utf_8_auto, call detect_ascii instead of scanning
4075 source bytes directly.
4076 (produce_chars): Call insert_from_gap with the new arg 0.
4077 (encode_coding): Likewise.
4078 (decode_coding_gap): Control ASCII optimization by the variable
4079 disable_ascii_optimization instead of #ifndef .. #endif.
4080 Deccode EOL format according to coding->eol_seen.
4081 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4082 variable.
4083
8a44e6d1
KH
4084 * lisp.h (adjust_after_replace): Cancel externing it.
4085 (insert_from_gap): Adjust prototype.
4086
5f795e34
EZ
40872013-03-15 Eli Zaretskii <eliz@gnu.org>
4088
4089 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4090 FULLSCREEN_MAXIMIZED. (Bug#13935)
4091
f258b4be
DA
40922013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4093
4094 * region-cache.c (find_cache_boundary, move_cache_gap)
4095 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4096 Simplify debugging check and convert to eassert. Adjust comment.
4097 (pp_cache): Put under ENABLE_CHECKING.
4098
a5cc4dde
EZ
40992013-03-14 Eli Zaretskii <eliz@gnu.org>
4100
4101 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4102 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4103 and WM_ACTIVATEAPP.
4104 (w32fullscreen_hook): If the frame is visible, reset
4105 f->want_fullscreen flag after changing the frame size. If the
4106 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4107 (Bug#13953)
4108
3fc5e44a
DC
41092013-03-13 Daniel Colascione <dancol@dancol.org>
4110
4111 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4112 too so that these builds can use Cygwin's file conversion
4113 functions. (We've been building and linking cygw32.o all along
4114 and just not using it.)
4115
47d7532e
PE
41162013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4117
4118 File synchronization fixes (Bug#13944).
4119 * Makefile.in (LIB_FDATASYNC): New macro.
4120 (LIBES): Use it.
4121 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4122 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4123 Don't worry about HAVE_FSYNC, since a substitute fsync is
4124 available if the system lacks one.
4125 (Fwrite_regin): Retry fsync if interrupted.
4126
c7ffccaf
EZ
41272013-03-13 Eli Zaretskii <eliz@gnu.org>
4128
4e2df81d 4129 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4130 activated, call w32fullscreen_hook, to make sure the new frame
4131 dimensions are in effect. (Bug#13937)
4132
8a7debc1
DA
41332013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4134
4135 * xdisp.c (init_iterator): Simplify because both character and byte
4136 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4137 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4138 character and byte positions can be obtained from marker.
8a7debc1 4139
7fd8c501
PE
41402013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4141
d9df6f40
PE
4142 Static checking by Sun C 5.12.
4143 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4144 * bytecode.c (exec_byte_code):
4145 * dispnew.c (init_display):
4146 * eval.c (error):
4147 * fileio.c (Fsubstitute_in_file_name):
4148 * keyboard.c (Fevent_convert_list):
4149 * keymap.c (Fsingle_key_description):
4150 * term.c (maybe_fatal, fatal):
4151 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4152 * xsmfns.c (Fhandle_save_session):
4153 Omit unreachable code.
4154 * keymap.c (map_keymap_char_table_item): Cast void * to
4155 a function pointer type; the C Standard requires this.
4156
7fd8c501
PE
4157 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4158 Include <sys/param.h> unconditionally, as that works elsewhere and
4159 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4160 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4161 and FreeBSD now.
4162
a020afb9 4163See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4164
4165;; Local Variables:
4166;; coding: utf-8
aac0c6e3
MR
4167;; End:
4168
ab422c4d 4169 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4170
4171 This file is part of GNU Emacs.
4172
4173 GNU Emacs is free software: you can redistribute it and/or modify
4174 it under the terms of the GNU General Public License as published by
4175 the Free Software Foundation, either version 3 of the License, or
4176 (at your option) any later version.
4177
4178 GNU Emacs is distributed in the hope that it will be useful,
4179 but WITHOUT ANY WARRANTY; without even the implied warranty of
4180 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4181 GNU General Public License for more details.
4182
4183 You should have received a copy of the GNU General Public License
4184 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.