(imagemagick_compute_animated_image): Fix animated segafault
[bpt/emacs.git] / src / ChangeLog
CommitLineData
703dbeba
LMI
12013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * image.c (imagemagick_compute_animated_image): Animate correctly
4 when sub-images are smaller than the main image.
1d18b1e6
LMI
5 (imagemagick_compute_animated_image): Setting the iterator row to
6 zero is apparently not allowed.
703dbeba 7
63216c5e
JD
82013-08-15 Jan Djärv <jan.h.d@swipnet.se>
9
10 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
11
a5b5f73f
LMI
122013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
13
14 * image.c (imagemagick_compute_animated_image): Respect the GIF
15 disposal methods.
16
0fe73012
KB
172013-08-15 Ken Brown <kbrown@cornell.edu>
18
19 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
20 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
21 needed.
22
691a357f
PE
232013-08-15 Paul Eggert <eggert@cs.ucla.edu>
24
25 Fix minor problems found by static checking.
26 * frame.c (delete_frame):
27 * xdisp.c (next_element_from_display_vector):
28 Avoid uninitialized local.
29 * image.c (imagemagick_compute_animated_image): Port to C89.
30 Prefer usual GNU indentation style for loops.
31 Be more careful about bizarrely large sizes, by using ptrdiff_t
32 instead of int.
33
42fe2e88
DA
342013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
35
36 Fix infinite frame selection loop (Bug#15025).
37 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
38
d39a3da6
EZ
392013-08-15 Eli Zaretskii <eliz@gnu.org>
40
41 * xdisp.c (compute_window_start_on_continuation_line): When
42 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
43 to make sure we end up setting the window start at the leftmost
44 visible character of the display line. This avoids funky
45 horizontal shifting because the window start is not kept on the
46 same position. (Bug#15090)
05426239
EZ
47 (next_element_from_display_vector): Support 'box' face attribute
48 in the face definitions of a display vector. (Bug#15099)
d39a3da6 49
6e856b69
LMI
502013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
51
52 * image.c (imagemagick_compute_animated_image): Implement animated
53 images (bug#14700).
995be755
LMI
54 (imagemagick_compute_animated_image): Fix some compilation
55 warnings. Implement a very simple cache to make the animation
56 usable at all, but it should be replaced with a per-image cache.
6e856b69 57
d5a1acfa
DA
582013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
59
60 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
61 to do `for' loops over alist values.
62 * buffer.h (FOR_EACH_BUFFER):
63 * process.c (FOR_EACH_PROCESS): Use it.
64 (handle_child_signal, status_notify, Fget_buffer_process)
65 (kill_buffer_processes): Use FOR_EACH_PROCESS.
66
9c253307
DA
672013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
68
69 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
70 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
71 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
72 to xzalloc and so avoid redundant call to memset.
73 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
74 members because it is allocated with xzalloc and so already zeroed.
75
05e64f9f
KB
762013-08-14 Ken Brown <kbrown@cornell.edu>
77
78 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
79 (Bug#15094).
80
5b71542d
DA
812013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
82
83 Utility function and macro to copy Lisp string to C string.
84 * lisp.h (xlispstrdupa): New macro.
85 (xlispstrdup): New prototype.
86 * alloc.c (xlispstrdup): New function.
87 * callint.c (Fcall_interactively):
88 * fileio.c (Ffile_name_directory, Fexpand_file_name)
89 (Fsubstitute_in_file_name):
90 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
91 * image.c (x_create_bitmap_from_file):
92 * w32term.c (w32_term_init):
93 * xterm.c (x_term_init): Use xlispstrdup.
94
71530c97
LMI
952013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
96
4ce82fb8
LMI
97 * image.c (imagemagick_load_image): Make animated pictures work.
98 There's still some problems with background color settings, though
99 (bug#14700).
100
71530c97
LMI
101 * decompress.c (unwind_decompress): Always restore point.
102
7510a061
XF
1032013-08-14 Xue Fuqiao <xfq.free@gmail.com>
104
105 * marker.c (set_marker): Reformat documentation.
106
01c3051f
PE
1072013-08-14 Paul Eggert <eggert@cs.ucla.edu>
108
aab1fcdf
PE
109 * xdisp.c (cursor_type_changed): Now static.
110
01c3051f
PE
111 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
112 Use changed. This avoids the need to call xmalloc and for the
113 caller to call xfree, and avoids memory leaks in some situations.
114
2084152a
DA
1152013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
116
117 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
118 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
119 (redisplay_window): If window_end_valid is cleared due to non-zero
120 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
121 so do not call to try_cursor_movement for that window.
2084152a 122
02455cb6
DA
1232013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
124
125 * window.h (struct window): Convert window_end_pos and
126 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
127 (wset_window_end_pos, wset_window_end_vpos): Remove.
128 * dispnew.c (adjust_glyph_matrix):
129 * window.c (Fwindow_end, replace_window, set_window_buffer)
130 (make_window):
131 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
132 (set_vertical_scroll_bar, redisplay_window, try_window)
133 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
134 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
135 (note_mouse_highlight): Adjust users.
136 (try_cursor_movement): Likewise. Convert old precondition to eassert.
137 Add comment.
138
da5707e8
DA
1392013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
140
141 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
142 * image.c (imagemagick_filename_hint): Use `const char *' and
143 prefer SSDATA to SDATA to avoid warnings.
144
25554267
DA
1452013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
146
147 Cleanup window fringes, margins and scroll bars adjustments.
148 * window.c (set_window_fringes, set_window_margins)
149 (set_window_scroll_bars, apply_window_adjustment): New functions.
150 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
151 (Fset_window_scroll_bars): Use them.
152
38a2c910
DA
1532013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
154
155 * window.h (struct window): Convert scroll_bar_width
156 from Lisp_Object to integer. Adjust comment.
157 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
158 Adjust users.
159 * window.c (wset_scroll_bar_width): Remove.
160 (make_window): Initialize scroll_bar_width.
161 (Fsplit_window_internal): Use direct assignment.
162 (Fset_window_configuration, save_window_save):
163 Convert Lisp_Object to integer and back where appropriate.
164 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
165 bar was actually changed, and mention this in docstring.
166
2d065031
PE
1672013-08-13 Paul Eggert <eggert@cs.ucla.edu>
168
169 * decompress.c: Minor simplifications.
170 (Fzlib_decompress_region): Don't bother verifying
171 that avail_out <= UINT_MAX, as that was confusing.
172 Mention the restriction in a comment instead.
173 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
174
a5bd5abb
JD
1752013-08-13 Jan Djärv <jan.h.d@swipnet.se>
176
177 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
178 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
179
66e7901a
LMI
1802013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
181
182 * image.c (imagemagick_filename_hint): Check for errors in the
183 alist structure.
184
2fa611b7
EZ
1852013-08-13 Eli Zaretskii <eliz@gnu.org>
186
187 * window.c (Fwindow_margins): Return nil when there's no marginal
188 area, as per the documented API.
189
190 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
191 Fmake_vector, as scroll bar's struct members are not all Lisp
192 objects now. This avoids crashes in GC.
193
194 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
195 bool, so its address could be taken.
196
8259030d
LMI
1972013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
198
199 * image.c (imagemagick_filename_hint): New function to possibly
200 apply `image-content-type-suffixes'.
201 (imagemagick_load_image): Use it.
202
866c710e
EZ
2032013-08-13 Eli Zaretskii <eliz@gnu.org>
204
205 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
206 if loading zlib failed.
207
f10490f0
JD
2082013-08-13 Jan Djärv <jan.h.d@swipnet.se>
209
96311be7
JD
210 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
211 2013-08-13 checkin below. Change bool to BOOL, rule is:
212 All Obj-C code uses BOOL, except for interfaces callable from C.
213
f10490f0
JD
214 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
215
c8ae93b0
DA
2162013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
217
218 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
219 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
220 bool instead of BOOL.
221 * w32term.h (struct scroll_bar): Convert fringe_extended_p
222 from Lisp_Object to bitfield. Adjust comment.
223 * w32term.c (x_scroll_bar_create): Adjust user.
224 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
225 * xterm.c (XTset_vertical_scroll_bar): Likewise.
226 Use bool for boolean.
227 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
228 to `unsigned int' when defining a bitfield.
229
53b64418
PE
2302013-08-13 Paul Eggert <eggert@cs.ucla.edu>
231
232 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
233
eeaf9bf3
DA
2342013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
235
236 * window.h (struct window): Convert left_margin_cols and
237 right_margin_cols from Lisp_Objects to integers. Adjust comment.
238 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
239 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
240 Adjust users.
241 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
242 Adjust comment.
243 (showing_window_margins_p, update_window_line, update_frame_1):
244 * fringe.c (draw_fringe_bitmap_1):
245 * xdisp.c (window_box_width): Adjust users.
246 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
247 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
248 Use direct assignment.
249 (Fset_window_configuration, save_window_save, Fwindow_margins):
250 Convert Lisp_Object to integer and back where appropriate.
251 (Fset_window_margins): Adjust user. Return t if any margin
252 was actually changed, and mention this in docstring.
253
956720af
XF
2542013-08-13 Xue Fuqiao <xfq.free@gmail.com>
255
f73f4ce6 256 * syntax.c (forward_word):
956720af
XF
257 * cmds.c (forward_char, backward_char): Mention the optional argument.
258
9e37ee3b
DA
2592013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
260
261 * window.h (struct window): Convert left_fringe_width
262 and right_fringe_width from Lisp_Objects to integers.
263 Adjust comment.
264 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
265 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
266 * window.c (wset_left_fringe_width, wset_right_fringe_width):
267 Remove.
268 (make_window): Initialize new integer fields to -1.
269 (Fsplit_window_internal): Use direct assignment.
270 (Fset_window_configuration, save_window_save): Convert
271 Lisp_Object to integer and back where appropriate.
272 (Fset_window_fringes): Adjust user. Return t if any fringe
273 was actually changed, and mention this in docstring.
274
e4375ca7
DA
2752013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
276
277 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
278 * nsfns.m (x_set_cursor_type):
279 * w32fns.c (x_set_cursor_type):
280 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
281 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 282
a45543bc
DA
2832013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
284
285 * font.c (clear_font_cache): New function, stripped from...
286 (Fclear_font_cache): ...here, which now uses the function
287 above. Adjust comment.
288 * font.h (clear_font_cache): Add prototype.
289 * xfaces.c (clear_face_cache): Use clear_font_cache.
290
ae966a86
DA
2912013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
292
293 * window.c (Fset_window_start): Compare `w', not `window' because
294 `w' might not be equal to `window' after call to decode_live_window.
295
297a545b
PE
2962013-08-12 Paul Eggert <eggert@cs.ucla.edu>
297
298 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
299 This fixes a problem introduced by the Bug#15035 patch
300 when using GPG. Reported by Herbert J. Skuhra.
301
aa942e2b
EZ
3022013-08-12 Eli Zaretskii <eliz@gnu.org>
303
304 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
305 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
306 not yet initialized.
307
7699d09e
LMI
3082013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
309
310 * decompress.c (Fzlib_decompress_region): Support zlib
311 decompression, too, and rename.
312
1d238bc7
PE
3132013-08-12 Paul Eggert <eggert@cs.ucla.edu>
314
315 Minor zlib configuration tweaks.
316 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
317 Don't assume presence of fn_inflateInit2_ zlib internal function.
318
8a44a184
LMI
3192013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
320
321 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
322 include the zlib prefix.
323
594a4307
EZ
3242013-08-12 Eli Zaretskii <eliz@gnu.org>
325
326 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
327 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
328 define static variables that are pointers to zlib functions to be
329 dynamically loaded.
330 (init_zlib_functions) [WINDOWSNT]: New function.
331 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
332 New macros.
333 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
334 macros instead of invoking the zlib functions directly.
335 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
336 Szlib_available_p.
337
d2e113bc
DA
3382013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
339
340 Avoid looping over all frame windows to freeze and unfreeze.
341 * window.h (struct window): Drop frozen_window_start_p.
342 (freeze_window_starts): Drop prototype.
343 * frame.h (struct frame): New frozen_window_starts flag.
344 (FRAME_WINDOWS_FROZEN): New macro.
345 * window.c (freeze_window_start, freeze_window_starts):
346 Remove.
347 (select_window, replace_window): Adjust users.
348 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
349 (window_frozen_p): New function.
350 (redisplay_window): Use it.
351
94fcd171
PE
3522013-08-12 Paul Eggert <eggert@cs.ucla.edu>
353
354 Fix some fd issues when running subprocesses (Bug#15035).
355 Fix bugs that can leak files or file descriptors on errors.
356 Don't unlink open temp files, as that's hard for users to diagnose
357 when things go awry (e.g., temp disk exhausted).
358 Don't bother to lock temp files. Check for invalid recursion.
359 * callproc.c (synch_process_fd): Remove. All uses removed.
360 (synch_process_tempfile): New var or macro.
361 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
362 New constants.
363 (record_kill_process): New arg, the temp name. All callers changed.
364 (delete_temp_file): Now just a simple wrapper around unlink.
365 (call_process_kill): New arg, the call_process_fd array.
366 Close them all. Clear synch_process_pid. Remove the temp file,
367 or arrange for it to be removed.
368 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
369 that's been moved to synch_process_tempfile. Caller changed.
370 Do not remove the tempfile; that's now call_process_kill's
371 responsibility.
372 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
373 call_process_kill; the caller now does that.
374 (call_process_cleanup): Do not close the process fd; that's now
375 call_process_kill's responsibility.
376 (Fcall_process): Implement via new function call_process, which
377 has most of the old body of Fcall_process, but with a different API.
378 (call_process): New function that does not open or close filefd if
379 it is nonnegative. Record which fds need to be closed, and let
380 call_process_kill close (and remove the tempfile, on MSDOS) on error.
381 Signal an error if invoked recursively (could be done via a hook).
382 Simplify creation of the tempfile in the MSDOS case.
383 Don't create the output file until after checking for the executable.
384 Report any failure to open /dev/null.
385 Don't open /dev/null for writing twice; once is enough.
386 Don't create pipe if all output is being discarded or sent to file.
387 Don't worry about setting up the coding system or reading from the
388 pipe if all output is being discarded.
389 Hoist fd_error local into top level, to lessen block nesting.
390 Don't record deleted pid here; now done by Fcall_process_region.
391 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
392 and note its success in synch_process_tempfile.
393 Do not leak resources when child_setup fails.
394 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
395 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
396 (create_temp_file): Now returns open fd, with an additional
397 Lisp_Object * argument to return the name. All callers changed.
398 Do not close the file; rewind it instead, and leave it open for
399 the caller. Do not lock the temp file. Unwind-protect the file
400 and the file-descriptor.
401 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
402 If an asynchrounous process, record it here, not in call_process.
403 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
404 * eval.c (set_unwind_protect): New function.
405 * fileio.c (write_region): New function, generalized from the
406 old Fwrite_region. Do not lock temp files.
407 (Fwrite_region): Use it.
408 * lisp.h (set_unwind_protect, write_region): New decls.
409 * process.c: Include <verify.h>.
410 (make_process): Mark fds as initially closed.
411 (deleted_pid_list): Now a list of pid-filename pairs.
412 All uses changed.
413 (close_process_fd): New function.
414 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
415 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
416 New constants. Verify that their number matches PROCESS_OPEN_FDS.
417 (create_process, create_pty, Fmake_serial_process)
418 (server_accept_connection): Record which fds need to be closed,
419 and let deactivate_process close them.
420 (Fmake_network_process): Do not discard the unwind-protect
421 until it's safe to do so.
422 (deactivate_process): Close the fds opened by create_process etc.
423 (Fprocess_send_eof): Adjust to new way of recording open fds.
424 Report an error if /dev/null can't be opened, instead of aborting.
425 * process.h (PROCESS_OPEN_FDS): New constant.
426 (struct Lisp_Process): New member open_fds.
427 (record_kill_process, record_deleted_pid): Adjust signatures.
428 (record_deleted_pid): Move decl here ...
429 * syswait.h (record_deleted_pid): ... from here.
430
d0e615c3
PE
4312013-08-11 Paul Eggert <eggert@cs.ucla.edu>
432
433 * decompress.c: Fix bugs with large buffers and weird inputs.
434 Tune a bit. Reindent as per usual Emacs style.
435 (BUFFER_SIZE): Remove.
436 (Fdecompress_gzipped_region): Do not mishandle input buffers with
437 more than UINT_MAX bytes. Decompress into the gap instead of into
438 an auto buffer, as this should avoid copying. Return nil if
439 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
440 set immediate_quit; we shouldn't trust zlib code that much.
441
313546eb
LMI
4422013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
443
99a32242
LMI
444 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
445 errors, and really move the gap to where we want it.
446
313546eb
LMI
447 * lisp.h: Include decompress.c support.
448
449 * emacs.c (main): Include decompress.c support.
450
451 * Makefile.in: Include -lz if present.
452
d2d699ac
JD
4532013-08-11 Jan Djärv <jan.h.d@swipnet.se>
454
f90e3ebd
JD
455 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
456 (initWithTitle:): Initialize frame to 0.
457 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
458 (fillWithWidgetValue:frame:): Renamed from
459 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
460
461 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
462 fillWithWidgetValue:frame:
463
423d3b3f
JD
464 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
465 remove memory leak warnings.
466
d2d699ac
JD
467 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
468 (ns_check_menu_open): Handle menu == nil. Remove assignment to
469 menu_pending_title.
470
471 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
472 (x_activate_menubar): Update the whole menu.
473 (trackingNotification:): Call ns_check_menu_open if tracking ends.
474 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
475 current event is not NSSystemDefined (Bug#15001).
476 Call ns_check_menu_open only if trackingMenu is 2.
477 (menuDidClose:): New method, decrease trackingMenu.
478 (fillWithWidgetValue:setDelegate:): New method.
479 (fillWithWidgetValue:): Call the above.
480
481 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
482
7d652d97
PE
4832013-08-11 Paul Eggert <eggert@cs.ucla.edu>
484
485 Omit some unnecessary casts.
486 Many of these go back to the old pre-C89 days, when they may have
487 been needed, but we've been assuming C89 or later for a while now.
488 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
489 (live_float_p, live_misc_p, live_vector_p):
490 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
491 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
492 (defvar_per_buffer):
493 * callint.c (Fcall_interactively):
494 * doc.c (Fsubstitute_command_keys):
495 * filelock.c (get_boot_time):
496 * frame.c (xrdb_get_resource):
497 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
498 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
499 (xg_get_file_name_from_selector, menuitem_destroy_callback)
500 (menuitem_highlight_callback, menu_destroy_callback)
501 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
502 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
503 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
504 (xg_tool_bar_help_callback, tb_size_cb):
505 * image.c (xpm_alloc_color, png_read_from_memory)
506 (png_read_from_file, png_load_body, our_memory_skip_input_data)
507 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
508 (syms_of_image):
509 * keymap.c (describe_map):
510 * nsfns.m (Fns_display_monitor_attributes_list):
511 * nsmenu.m (process_dialog:):
512 * nsterm.m (hold_event):
513 * process.c (wait_reading_process_output):
514 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
515 * scroll.c (do_direct_scrolling, scrolling_1):
516 * termcap.c (tgetent):
517 * window.c (check_window_containing, add_window_to_list)
518 (freeze_window_starts):
519 * xdisp.c (compare_overlay_entries, vmessage):
520 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
521 (x_get_monitor_attributes_xrandr)
522 (Fx_display_monitor_attributes_list, x_display_info_for_name)
523 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
524 * xfont.c (xfont_match, xfont_open):
525 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
526 (menubar_selection_callback, menu_position_func)
527 (popup_selection_callback, create_and_show_popup_menu)
528 (dialog_selection_callback, create_and_show_dialog):
529 * xrdb.c (x_get_string_resource):
530 (main) [TESTRM]:
531 * xsmfns.c (x_session_check_input):
532 * xterm.c (x_draw_glyphless_glyph_string_foreground)
533 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
534 (xaw_jump_callback, xaw_scroll_callback):
535 Omit unnecessary casts.
536
9acc1074
PE
5372013-08-10 Paul Eggert <eggert@cs.ucla.edu>
538
539 Minor string-length refactoring.
540 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
541 * frame.c (make_monitor_attribute_list):
542 Prefer build_string to strlen + make_string.
543
361c0eb8
JD
5442013-08-10 Jan Djärv <jan.h.d@swipnet.se>
545
546 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
547 don't check minor_code (Bug#14417).
548
14ba0822
EZ
5492013-08-09 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
552 vertical positions instead. This avoids calling MATRIX_ROW with
553 row numbers that are possibly beyond valid limits. (Bug#15064)
554
309f24d1
DA
5552013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
556
557 Use xstrdup and build_unibyte_string where applicable.
558 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
559 * xfns.c (x_window):
560 * xrdb.c (x_get_customization_string):
561 * xterm.c (xim_initialize):
562 * w32fns.c (w32_window): Use xstrdup.
563 (w32_display_monitor_attributes_list):
564 * emacs.c (init_cmdargs):
565 * keyboard.c (PUSH_C_STR):
566 * nsfont.m (nsfont_open):
567 * sysdep.c (system_process_attributes):
568 * w32.c (system_process_attributes):
569 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
570
55902276
EZ
5712013-08-09 Eli Zaretskii <eliz@gnu.org>
572
573 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
574 variables of these types so that GDB would know about them, as aid
575 for debugging fatal exceptions. (Bug#15024) See also
576 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
577 discussions.
578
10bf7f5a
JD
5792013-08-08 Jan Djärv <jan.h.d@swipnet.se>
580
581 * nsterm.m (ns_update_begin): Don't change clip path if it would be
582 larger than the NSWindow (Bug#14934).
583
65620264
DA
5842013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Redesign redisplay interface to drop global variable updated_window.
587 Always pass currently updated window as a parameter to update routines.
588 * dispextern.h (updated_window): Remove declaration.
589 (struct redisplay_interface): Pass window parameter to
590 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
591 and after_update_window_hook.
592 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
593 Adjust prototypes.
594 * dispnew.c (updated_window): Remove.
595 (redraw_overlapped_rows, update_marginal_area, update_text_area)
596 (update_window_line): Adjust to match redisplay interface changes.
597 * nsterm.m (ns_update_window_begin, ns_update_window_end)
598 (ns_scroll_run, ns_after_update_window_line):
599 * w32term.c (x_update_window_begin, x_update_window_end)
600 (x_after_update_window_line, x_scroll_run):
601 * xterm.c (x_update_window_begin, x_update_window_end)
602 (x_after_update_window_line, x_scroll_run):
603 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
604 Likewise. Adjust comments where appropriate.
605 (x_cursor_to): Simplify because this is always called during window
606 update (but install debugging check anyway).
607 (expose_window): Check must_be_updated_p flag to see whether this
608 function is called during window update.
609
628fdc56
DA
6102013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
611
612 Do not reset window modification event counters excessively.
613 These leftovers and poor man's tricky methods to catch extra
614 redisplay's attention are no longer needed.
615 * frame.c (set_menu_bar_lines_1):
616 * minibuf.c (read_minibuf_unwind):
617 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
618 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
619 (window_scroll_line_based, Fset_window_configuration):
620 * xdisp.c (redisplay_window): Do not reset last_modified and
621 last_overlay_modified counters.
622
8fd9c92e
JD
6232013-08-07 Jan Djärv <jan.h.d@swipnet.se>
624
625 * xselect.c (x_send_client_event): Set send_event and serial, memset
626 data.l as it might be bigger than data.b. Use 24 bit mask to
627 XSendEvent (Bug#15034).
628
0ee18172
EZ
6292013-08-07 Eli Zaretskii <eliz@gnu.org>
630
631 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
632 for TTY frames that are not the top frame on their console.
633 (Bug#14616)
634
16ddd1a6
MR
6352013-08-07 Martin Rudalics <rudalics@gmx.at>
636
637 * w32term.c (w32fullscreen_hook): Really maximize frame when
638 asked for (Bug#14841).
639
d2a95ffb
DA
6402013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
641
642 Prefer selected_window to Fselected_window, likewise for frames.
643 * buffer.c (Fbuffer_swap_text):
644 * data.c (Fvariable_binding_locus):
645 * window.c (run_window_configuration_change_hook): Adjust users.
646 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
647 Use decode_live_frame.
648
170da1ec
DA
6492013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
650
651 Be more careful if selected window shows the buffer other than current,
652 use window_outdated only if this is not so. This change should also
653 address some weird issues discussed in Bug#13012.
654 * window.h (window_outdated): New prototype.
655 * window.c (window_outdated): Now here. Convert from static and
656 always assume window's buffer.
657 (Fwindow_end, Fwindow_line_height): Use it.
658 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
659 and always assume window's buffer.
660 (redisplay_window): Adjust user.
e5eefe9b 661 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
662 check whether mode line should be updated only if selected window
663 shows current buffer.
664 (run_window_scroll_functions): Use eassert for debugging check.
665 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
666
56b5d5b1
DA
6672013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
668
669 * window.c (window_scroll, window_scroll_pixel_based)
670 (window_scroll_line_based): Use bool for booleans.
671
2878ba7e
PE
6722013-08-06 Paul Eggert <eggert@cs.ucla.edu>
673
674 * process.c: Fix minor off-by-one issues in descriptor counts.
675 This shouldn't fix any real bugs, but it cleans up the code a bit.
676 (max_process_desc, max_input_desc): -1, not 0, means none.
677 All uses changed.
678 (delete_input_desc): New function.
679 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
680 (deactivate_process): Scan backwards when recomuting max_process_desc;
681 that should be faster.
682 (init_process_emacs): Initialize max_input_desc.
683
e30b79c1
DA
6842013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
685
686 Use region cache to speedup bidi_find_paragraph_start.
687 * buffer.h (struct buffer): New member bidi_paragraph_cache.
688 Rename cache_long_line_scans to cache_long_scans.
689 * buffer.c (bset_cache_long_line_scans): Rename to
690 bset_cache_long_scans.
691 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
692 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
693 into account.
694 (syms_of_buffer): Rename cache-long-line-scans to
695 cache-long-scans. Adjust docstring.
696 * search.c (newline_cache_on_off):
697 * indent.c (width_run_cache_on_off): Adjust users.
698 * bidi.c (bidi_paragraph_cache_on_off): New function.
699 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
700 * insdel.c (prepare_to_modify_buffer): Invalidate
701 bidi_paragraph_cache if enabled.
702
00012b86
DA
7032013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
704
705 Invalidate region caches only if buffer text is going to be changed.
706 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
707 (modify_text): ...new prototype.
708 (prepare_to_modify_buffer_1): New prototype.
709 * textprop.c (modify_region): Rename to...
710 (modify_text_properties): ...new function.
711 (add_text_properties_1, set_text_properties, Fremove_text_properties)
712 (Fremove_list_of_text_properties): Adjust users.
713 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
714 (modify_text): ...new function.
715 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
716 (prepare_to_modify_buffer_1): ...new function.
717 * casefiddle.c (casify_region):
718 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
719 (Ftranspose_regions): Use modify_text.
720
dc6c0eda
SM
7212013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
722
723 * lisp.mk (lisp): Add nadvice.elc.
724
8f3a2c26
DA
7252013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
726
727 New macro to iterate over live buffers similar to frames.
728 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
729 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
730 Declare buffer-related variables here to offload lisp.h.
731 * buffer.c (Vbuffer_alist): Adjust comment.
732 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
733 (other_buffer_safely):
734 * data.c (store_symval_forwarding):
735 * dispnew.c (Fframe_or_buffer_changed_p):
736 * fileio.c (Fdo_auto_save):
737 * filelock.c (unlock_all_files):
738 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
739
e0fdb694
PE
7402013-08-04 Paul Eggert <eggert@cs.ucla.edu>
741
742 Fix some minor races in hosts lacking mkostemp (Bug#15015).
743 * callproc.c (create_temp_file):
744 * filelock.c (create_lock_file):
745 Assume mkostemp, since it's now provided by Gnulib.
746
63f5c6c2
EZ
7472013-08-04 Eli Zaretskii <eliz@gnu.org>
748
749 * w32.c (mkostemp): New function.
750 (mktemp): Remove, no longer used. Most of the code reused in
751 mkostemp. (Bug#15015)
484ab239 752 (mktemp): Don't undef.
63f5c6c2 753
f0b79313
DA
7542013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
755
756 * dispnew.c (glyph_matrix_count, glyph_pool_count):
757 Move under GLYPH_DEBUG and ENABLE_CHECKING.
758 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
759 (free_glyph_pool, check_glyph_memory): Likewise for
760 all users. Adjust comments where appropriate.
761
98f638d6
PE
7622013-08-03 Paul Eggert <eggert@cs.ucla.edu>
763
764 * composite.h: Minor fixups.
765 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
766 to fix a misspelling, and change it to an inline function while
767 we're at it (it need not be a macro). All uses changed.
768 (composition_method, composition_valid_p):
769 Rewrite to avoid assignments in if-conditions.
770
75c59fb3
DA
7712013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
772
773 Do not use global Lisp_Object in composition macros.
774 * composite.h (composition_temp): Remove declaration.
775 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
776 (composition_method, composition_valid_p): ...inline functions.
416a3e01 777 (compose_region): Remove the leftover.
75c59fb3
DA
778 * composite.c (composition_temp): Remove.
779 (run_composition_function, update_compositions)
780 (composition_compute_stop_pos, composition_adjust_point)
781 (Ffind_composition_internal):
782 * coding.c (handle_composition_annotation):
783 * xdisp.c (handle_composition_prop, check_point_in_composition):
784 Related users changed.
785
a10c8269
DA
7862013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Drop FRAME_PTR typedef.
789 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
790 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
791 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
792 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
793 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
794 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
795 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
796 All related users changed.
797
a104f656
SM
7982013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
799
800 * eval.c (default_toplevel_binding): New function.
801 (Fdefvar): Use it.
802 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
803 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
804 (syms_of_eval): Export them.
805 * data.c (Fdefault_value): Micro cleanup.
806 * term.c (init_tty): Use "false".
807
4b5c9326
DA
8082013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
809
810 Fix X GC leak in GTK and raw (no toolkit) X ports.
811 * xterm.c (x_free_frame_resources): If white and black relief
812 GCs are allocated, always free them here.
813 * xfns.c (x_make_gc): Omit redundant initialization.
814 * widget.c (create_frame_gcs): Remove the leftover.
815 (EmacsFrameDestroy): Do nothing because all GCs are now freed
816 in x_free_frame_resources.
817
b19aa636
JD
8182013-08-02 Jan Djärv <jan.h.d@swipnet.se>
819
820 * nsterm.m (windowWillResize:toSize:): Only change title if
821 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
822 modifying it.
823 (viewDidEndLiveResize): New method.
824
825 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
826 inside NS_IMPL_COCOA.
827
af1f7e06
DA
8282013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
829
830 * insdel.c (adjust_after_replace, replace_range, del_range_2):
831 Do not check whether undo is enabled because record_insert and
832 record_delete does that themselves.
833
65b02bb9
DA
8342013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
835
836 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
837 member which is not really used any more.
838 (FRAME_XIC_BASE_FONTNAME): Remove.
839 * xfns.c (xic_free_fontset): Adjust user.
840 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
841 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
842 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
843 (xdialog_show): Use eassert for debugging check.
7ee0f047 844 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 845
6318cde0
PE
8462013-08-01 Paul Eggert <eggert@cs.ucla.edu>
847
848 * fileio.c, fns.c (merge): Move extern decl from here ...
849 * lisp.h (merge): ... to here.
850
6c1a09ba
DA
8512013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
852
853 Fix last font-related change.
854 * w32font.h (w32font_list_internal, w32font_match_internal):
855 Fix prototype.
856 * w32uniscribe.c (uniscribe_list, uniscribe_match):
857 (uniscribe_list_family): Adjust to match font API change.
858 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
859 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
860
f8c20208
DA
8612013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
862
863 * frame.h (FRAME_MOUSE_UPDATE):
864 * nsterm.m (ns_frame_up_to_date): Omit redundant check
865 whether hlinfo->mouse_face_mouse_frame is non-NULL.
866
fdb396e2
DA
8672013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
868
869 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
870 * font.h (struct font_driver): Change list, match, and list_family
871 functions to accept struct frame * as first arg.
872 * font.c (font_score, font_compare, font_sort_entities): Remove
873 prototypes.
874 (font_sort_entities, font_list_entities, font_select_entity):
875 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
876 match font API change.
877 * xfont.c (xfont_list, xfont_match, xfont_list_family):
878 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
879 * ftxfont.c (ftxfont_list, ftxfont_match):
880 * xftfont.c (xftfont_list, xftfont_match):
881 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
882 * w32font.c (w32font_list, w32font_match, w32font_list):
883 (w32font_list_internal, w32_font_match_internal): Likewise.
884 * xfaces.c (Fx_family_fonts): Adjust user.
885
52b8a085
DA
8862013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
887
888 Do not use pure Xism x_wm_set_icon_position in non-X ports.
889 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
890 only if HAVE_X_WINDOWS is in use.
891 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
892 * nsterm.m (x_wm_set_icon_position): Remove no-op.
893 * w32term.c (x_wm_set_icon_position): Likewise.
894 * w32fns.c (x_icon): Adjust user.
895
c791c18e
DA
8962013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
897
898 * xterm.c (last_mouse_press_frame): Remove the
899 leftover which is not really used any more.
900 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
901 (x_flush): Call XFlush once per each X display, not frame.
902 This is better because this code always unconditionally skips
903 non-X frames in Vframe_list and issues the only XFlush if we
904 have more than one X frame on the same X display.
2f935d86
DA
905 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
906 Use bool for booleans.
907 (x_draw_glyph_string_background, cvt_string_to_pixel):
908 (cvt_pixel_dtor): Drop unnecessary prototypes.
909 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 910
f435830e
DA
9112013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
912
913 Drop unnecessary functions that deals with frame pixel size.
914 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
915 (x_pixel_height): Drop prototypes.
916 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
917 (x_pixel_height): Drop implementations.
918 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
919 which should be always valid for window frame.
920 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
921 * w32menu.c (Fx_popup_dialog):
922 * xmenu.c (Fx_popup_dialog): Likewise for both.
923
84231434
DA
9242013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
925
926 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
927 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
928 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
929 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
930 and mention nil frame in docstring.
84231434 931
959067a1
DA
9322013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
933
934 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
935 (x_figure_window_size): Likewise. Adjust to return long.
936 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
937 (toplevel): Move Qterminal_live_p to...
938 * terminal.c (toplevel): ...here, make it static, and...
939 (syms_of_terminal): ...DEFSYM here.
940 * frame.h (Qterminal_live_p): Remove declaration.
941 (make_frame, x_figure_window_size): Adjust prototype.
942 * nsfns.m (Fx_create_frame): Use long for window flags.
943
f4b169ce
PE
9442013-07-30 Paul Eggert <eggert@cs.ucla.edu>
945
946 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
947 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
948 Do not assume that emacs_close (INT_MAX) is a no-op.
949
bee6a2c7
DA
9502013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
951
952 * xfaces.c (make_face_cache): For struct face_cache, prefer
953 xmalloc to xzalloc and so avoid redundant call to memset.
954 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
955
d7e6881a
DA
9562013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
957
958 * fringe.c (draw_window_fringes, update_window_fringes)
959 (compute_fringe_widths):
960 * w32term.c (x_draw_glyph_string):
961 * window.c (candidate_window_p, Frecenter):
962 * xfaces.c (realize_basic_faces, realize_default_face)
963 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
964 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
965 * xfns.c (x_set_cursor_color, xic_free_xfontset):
966 * xmenu.c (Fx_menu_bar_open_internal):
967 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
968 * xsettings.c (xft_settings_event):
969 * xterm.c (x_draw_glyph_string, x_had_errors_p):
970 Use bool for booleans. Adjust style and comments where
971 appropriate.
972 * dispextern.h (draw_window_fringes, update_window_fringes)
973 (compute_fringe_widths):
974 * xterm.h (x_had_errors_p): Adjust prototype.
975
ec3058af
DA
9762013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
977
978 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
979 CHECK_LIST. Rewrite the loop to avoid useless local variable.
980
218e0637
DA
9812013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
982
983 * fns.c (toplevel): Remove comment before Fsafe_length because
984 it checks for QUIT.
985
e560aba9
PE
9862013-07-28 Paul Eggert <eggert@cs.ucla.edu>
987
988 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
989
2e5ce5de
EZ
9902013-07-28 Eli Zaretskii <eliz@gnu.org>
991
992 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
993 frame which got the message is still alive, before dereferencing
994 its pointer. (Bug#14970)
995
996 * frame.c (delete_frame): Test "this" frame's minibuffer window to
997 be a live window, before using it as such. (Bug#14970)
998
e95da6d3
EZ
9992013-07-27 Eli Zaretskii <eliz@gnu.org>
1000
1001 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1002 w32_detect_focus_change instead of doing part of its job by hand.
1003 This fixes the problem whereby FOCUS_OUT events were not sent to
1004 the event queue.
1005
a8f93651
EZ
10062013-07-26 Eli Zaretskii <eliz@gnu.org>
1007
fec92060
EZ
1008 * process.c (Fprocess_list): Doc fix.
1009
a8f93651
EZ
1010 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1011 being re-exposed only if it didn't ask to become visible.
1012 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1013 was previously iconified. (Bug#14841)
1014 (x_iconify_frame): Mark the frame iconified.
1015
d5a7a9d9
PE
10162013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 Fix minor problems found by static checking.
1019 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1020 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1021
56ea7291
SM
10222013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1023
1024 * eval.c (set_specpdl_old_value): New function.
1025 (unbind_to): Minor simplification.
1026 (get_backtrace_frame): New function.
1027 (Fbacktrace_frame): Use it. Add `base' argument.
1028 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1029 (syms_of_eval): Export backtrace-eval.
1030 * xterm.c (x_focus_changed): Simplify.
1031
9d611ffe
PE
10322013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1035
999c74e3
EZ
10362013-07-24 Eli Zaretskii <eliz@gnu.org>
1037
1038 * xdisp.c (redisplay_window): Instead of moving point out of
1039 scroll margin, reject the force_start method, and try scrolling
1040 instead. (Bug#14780)
1041
198fa217
KB
10422013-07-24 Ken Brown <kbrown@cornell.edu>
1043
1044 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1045 (Bug#14944).
1046
53840e55
PE
10472013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 * eval.c (Fprogn): Do not check that BODY is a proper list.
1050 This undoes the previous change. The check slows down the
1051 interpreter, and is not needed to prevent a crash. See
1052 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1053
60967f56
GM
10542013-07-23 Glenn Morris <rgm@gnu.org>
1055
1056 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1057
9ca960e2
PE
10582013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1059
a29c3e6d
PE
1060 Port to GNU/Linux systems with tinfo but not ncurses.
1061 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1062 to decide whether ncurses is being used. Without this change,
1063 GCC complains about tgetent not being declared, on a system
1064 that has tinfo installed but ncurses not installed.
1065
f274311c
PE
1066 * eval.c (Fprogn): Check that BODY is a proper list.
1067
16b0520a
PE
1068 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1069 * data.c (Fsetq_default):
1070 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1071 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1072 (Fcondition_case):
1073 Tune by taking advantage of the fact that ARGS is always a list
1074 when a function is declared to have UNEVALLED args.
1075
9ca960e2
PE
1076 * emacsgtkfixed.c: Port to GCC 4.6.
1077 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1078
afacaa1b
JB
10792013-07-23 Juanma Barranquero <lekktu@gmail.com>
1080
1081 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1082 here to silence compiler warnings.
1083
368a85a4
PE
10842013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1085
1086 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1087 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1088 from messing up Emacs's 'struct frame' (Bug#14923).
1089
f4e891b5
PE
10902013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * alloc.c (make_save_ptr_ptr): Define this function.
1093 It was inadvertently omitted. It's needed only if
1094 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1095
96c8b65e
JD
10962013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1097
1098 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1099 frame have focus (Bug#14895).
1100
ee010797
PE
11012013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1102
1103 Avoid vfork-related deadlock more cleanly.
1104 * callproc.c (child_setup): When the child's exec fails, output
1105 the program name, as that's more useful. Use O_NONBLOCK to avoid
1106 deadlock.
1107 * process.c (create_process_1): Remove; no longer needed.
1108 (create_process): Remove timer hack; no longer needed, now that
1109 the child avoids deadlock.
1110
f0398ec1 11112013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1112
1113 * image.c (Fimage_flush): Fix doc typo.
1114
b2a069c2
PE
11152013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1116
6496aec9
PE
1117 Fix array bounds violation when pty allocation fails.
1118 * process.c (PTY_NAME_SIZE): New constant.
1119 (pty_name): Remove static variable; it's now auto.
1120 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1121 Take pty_name as an arg rather than using a static variable.
1122 All callers changed.
1123 (create_process): Recover pty_flag from process, not from volatile local.
1124 (create_pty): Stay inside array even when pty allocation fails.
1125 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1126
b2a069c2
PE
1127 * lread.c (Fload): Avoid initialization only when lint checking.
1128 Mention that it's needed only for older GCCs.
1129
99107004
KH
11302013-07-20 Kenichi Handa <handa@gnu.org>
1131
1132 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1133 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1134
6b1b199d
AS
11352013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1136
1137 * lread.c (Fload): Avoid uninitialized warning.
1138
4195afc3
PE
11392013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1140
3f5bef16
PE
1141 Fix some minor file descriptor leaks and related glitches.
1142 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1143 (create_lock_file): Use write, not emacs_write.
1144 * image.c (slurp_file, png_load_body):
1145 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1146 (server_accept_connection):
1147 Don't leak an fd on memory allocation failure.
1148 * image.c (slurp_file): Add a cheap heuristic for growing files.
1149 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1150 as that's what the other routines do. Maybe input need not be
1151 blocked at all, but it's better to be consistent.
1152 Avoid undefined behavior when strlen is zero.
1153
4195afc3
PE
1154 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1155 (NSTATICS): Now a constant; doesn't need to be a macro.
1156
a1aeeffe
RS
11572013-07-19 Richard Stallman <rms@gnu.org>
1158
1159 * coding.c (decode_coding_utf_8): Add simple loop for fast
1160 processing of ASCII characters.
1161
63b34baa
PE
11622013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1165
621dd9ac
EZ
11662013-07-19 Eli Zaretskii <eliz@gnu.org>
1167
1168 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1169 unportable 'struct x_display_info'.
1170 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1171 is a portable type.
1172
1396ac86
PE
11732013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1174
ab9980cd
PE
1175 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1176 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1177 or fscanf fails.
1178 (system_process_attributes): Prefer plain char to unsigned char
1179 when either will do. Clean up properly if interrupted or if
1180 memory allocations fail. Don't assume sscanf succeeds. Remove
1181 no-longer-needed workaround to stop GCC from whining. Read
1182 command-line once, instead of multiple times. Check read status a
1183 bit more carefully.
1184
1396ac86
PE
1185 Fix obscure porting bug with varargs functions.
1186 The code assumed that int is treated like ptrdiff_t in a vararg
1187 function, which is not a portable assumption. There was a similar
1188 -- though these days less likely -- porting problem with various
1189 assumptions that pointers of different types all smell the same as
1190 far as vararg functions is conserved. To make this problem less
1191 likely in the future, redo the API to use varargs functions.
1192 * alloc.c (make_save_value): Remove this vararg function.
1193 All uses changed to ...
1194 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1195 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1196 New functions.
1197 (make_save_ptr): Rename from make_save_pointer, for consistency with
1198 the above. Define only on platforms that need it. All uses changed.
1199
4d19d194
PE
12002013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1201
1202 * keyboard.c: Try to fix typos in previous change.
1203 (DISPLAY_LIST_INFO): New macro.
1204 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1205 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1206
945c5bb1
JB
12072013-07-18 Juanma Barranquero <lekktu@gmail.com>
1208
1209 * keyboard.c (kbd_buffer_get_event):
1210 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1211 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1212
f4b1eb36
PE
12132013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1214
5e679a2c
PE
1215 * filelock.c: Fix unlikely file descriptor leaks.
1216 (get_boot_time_1): Rework to avoid using emacs_open.
1217 This doesn't actually fix a leak, but is better anyway.
1218 (read_lock_data): Use read, not emacs_read.
1219
a8cd4836
PE
1220 * doc.c: Fix minor memory and file descriptor leaks.
1221 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1222 (get_doc_string, Fsnarf_documentation):
1223 Fix file descriptor leak on error.
1224
ef30e638
PE
1225 * term.c: Fix minor fdopen-related file descriptor leaks.
1226 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1227 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1228
f4b1eb36
PE
1229 * charset.c: Fix file descriptor leaks and errno issues.
1230 Include <errno.h>.
1231 (load_charset_map_from_file): Don't leak file descriptor on error.
1232 Use plain record_xmalloc since the allocation is larger than
1233 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1234 of entries.
1235 * eval.c (record_unwind_protect_nothing):
1236 * fileio.c (fclose_unwind):
1237 New functions.
1238 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1239 The replacement doesn't block input, but that no longer seems
1240 necessary.
1241
b648c163
PE
12422013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1243
a0931322
PE
1244 * lread.c: Fix file descriptor leaks and errno issues.
1245 (Fload): Close some races that leaked fds or streams when 'load'
1246 was interrupted.
1247 (Fload, openp): Report error number of last nontrivial failure to open.
1248 ENOENT counts as trivial.
1249 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1250 New functions.
1251 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1252 now that the function is always called with a nonnegative arg.
1253 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1254 All uses replaced with ...
1255 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1256
b648c163
PE
1257 A few more minor file errno-reporting bugs.
1258 * callproc.c (Fcall_process):
1259 * doc.c (Fsnarf_documentation):
1260 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1261 * process.c (set_socket_option):
1262 Don't let a constructor trash errno.
1263 * doc.c: Include <errno.h>.
1264
b1dc4084
JB
12652013-07-16 Juanma Barranquero <lekktu@gmail.com>
1266
1267 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1268
c43843aa
PE
12692013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1270
50a30cce
PE
1271 Fix w32 bug with call-process-region (Bug#14885).
1272 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1273 to Fcall_process when the input is empty. This simplifies the
1274 code a bit. It makes no difference on POSIXish platforms but
1275 apparently it fixes a bug on w32.
1276
44e18199 1277 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1278 * fileio.c (close_file_unwind): Don't close if FD is negative;
1279 this can happen when unwinding a zapped file descriptor.
1280 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1281 in case Emacs runs out of memory between the two unwind-protects.
1282 Don't trash errno when closing FD.
1283 Zap the FD in the specpdl when closing it, instead of deferring
1284 the removal of the unwind-protect; this fixes a bug where a child
1285 function unwinds the stack past us.
1286
27e498e6
PE
1287 New unwind-protect flavors to better type-check C callbacks.
1288 This also lessens the need to write wrappers for callbacks,
1289 and the need for make_save_pointer.
1290 * alloca.c (free_save_value):
1291 * atimer.c (run_all_atimers):
1292 Now extern.
1293 * alloc.c (safe_alloca_unwind):
1294 * atimer.c (unwind_stop_other_atimers):
1295 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1296 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1297 * minibuf.c (choose_minibuf_frame_1):
1298 * process.c (make_serial_process_unwind):
1299 * xdisp.h (pop_message_unwind):
1300 * xselect.c (queue_selection_requests_unwind):
1301 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1302 * alloca.c (record_xmalloc):
1303 Prefer record_unwind_protect_ptr to record_unwind_protect with
1304 make_save_pointer.
1305 * alloca.c (Fgarbage_collect):
1306 Prefer record_unwind_protect_void to passing a dummy.
1307 * buffer.c (restore_buffer):
1308 * window.c (restore_window_configuration):
1309 * xfns.c, w32fns.c (do_unwind_create_frame)
1310 New wrapper. All record-unwind uses of wrappee changed.
1311 * buffer.c (set_buffer_if_live):
1312 * callproc.c (call_process_cleanup, delete_temp_file):
1313 * coding.c (code_conversion_restore):
1314 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1315 * editfns.c (save_excursion_restore)
1316 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1317 (save_restriction_restore):
1318 * eval.c (restore_stack_limits, un_autoload):
1319 * fns.c (require_unwind):
1320 * keyboard.c (recursive_edit_unwind, tracking_off):
1321 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1322 * macros.c (pop_kbd_macro, restore_menu_items):
1323 * nsfns.m (unwind_create_frame):
1324 * print.c (print_unwind):
1325 * process.c (start_process_unwind):
1326 * search.c (unwind_set_match_data):
1327 * window.c (select_window_norecord, select_frame_norecord):
1328 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1329 (fast_set_selected_frame):
1330 * xfns.c, w32fns.c (unwind_create_tip_frame):
1331 Return void, not a dummy Lisp_Object. All uses changed.
1332 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1333 * callproc.c (call_process_kill):
1334 * fileio.c (restore_point_unwind, decide_coding_unwind)
1335 (build_annotations_unwind):
1336 * insdel.c (Fcombine_after_change_execute_1):
1337 * keyboard.c (read_char_help_form_unwind):
1338 * menu.c (unuse_menu_items):
1339 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1340 * sound.c (sound_cleanup):
1341 * xdisp.c (unwind_redisplay):
1342 * xfns.c (clean_up_dialog):
1343 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1344 Accept no args and return void, instead of accepting and returning
1345 a dummy Lisp_Object. All uses changed.
1346 * cygw32.c (fchdir_unwind):
1347 * fileio.c (close_file_unwind):
1348 * keyboard.c (restore_kboard_configuration):
1349 * lread.c (readevalllop_1):
1350 * process.c (wait_reading_process_output_unwind):
1351 Accept int and return void, rather than accepting an Emacs integer
1352 and returning a dummy object. In some cases this fixes an
1353 unlikely bug when the corresponding int is outside Emacs integer
1354 range. All uses changed.
1355 * dired.c (directory_files_internal_unwind):
1356 * fileio.c (do_auto_save_unwind):
1357 * gtkutil.c (pop_down_dialog):
1358 * insdel.c (reset_var_on_error):
1359 * lread.c (load_unwind):
1360 * xfns.c (clean_up_file_dialog):
1361 * xmenu.c, nsmenu.m (pop_down_menu):
1362 * xmenu.c (cleanup_widget_value_tree):
1363 * xselect.c (wait_for_property_change_unwind):
1364 Accept pointer and return void, rather than accepting an Emacs
1365 save value encapsulating the pointer and returning a dummy object.
1366 All uses changed.
1367 * editfns.c (Fformat): Update the saved pointer directly via
1368 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1369 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1370 (unwind_body): New function.
1371 (record_unwind_protect): First arg is now a function returning void,
1372 not a dummy Lisp_Object.
1373 (record_unwind_protect_ptr, record_unwind_protect_int)
1374 (record_unwind_protect_void): New functions.
1375 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1376 * fileio.c (struct auto_save_unwind): New type.
1377 (do_auto_save_unwind): Use it.
1378 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1379 * insdel.c (struct rvoe_arg): New type.
1380 (reset_var_on_error): Use it.
1381 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1382 New constants.
1383 (specbinding_func): Remove; there are now several such functions.
1384 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1385 (set_unwind_protect_ptr): New function.
1386 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1387
4e604a5d
PE
1388 Be simpler and more consistent about reporting I/O errors.
1389 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1390 Say "Read error" and "Write error", rather than "I/O error", or
1391 "IO error reading", or "IO error writing", when a read or write
1392 error occurs.
1393 * process.c (Fmake_network_process, wait_reading_process_output)
1394 (send_process, Fprocess_send_eof, wait_reading_process_output):
1395 Capitalize diagnostics consistently. Put "failed foo" at the
1396 start of the diagnostic, so that we don't capitalize the
1397 function name "foo". Consistently say "failed" for such
1398 diagnostics.
1399 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1400 All callers changed. This is so it can use report_file_error.
1401 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1402 diagnostics consistently as above.
1403
a9757f6a
PE
1404 * fileio.c (report_file_errno): Fix errno reporting bug.
1405 If the file name is neither null nor a pair, package it up as a
1406 singleton list. All callers changed, both to this function and to
1407 report_file_error. This fixes a bug where the memory allocator
1408 invoked by list1 set errno so that the immediately following
1409 report_file_error reported the wrong errno value.
1410
c43843aa
PE
1411 Fix minor problems found by --enable-gcc-warnings.
1412 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1413 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1414
18c26d81
JD
14152013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1416
1417 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1418 Set event->arg to Qt if switch-event shall be generated.
1419 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1420
1421 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1422
1423 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1424 FOCUS_OUT_EVENT.
1425
1426 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1427 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1428 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1429 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1430 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1431 and there is a focused frame.
1432 (head_table): Add focus-in and focus-out.
1433 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1434 bind to handle-focus-in/out.
1435
1436 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1437 (Fhandle_switch_frame): Call Fhandle_focus_in.
1438 (syms_of_frame): defsubr handle-focus-in/out.
1439
6c6f1994
PE
14402013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1441
c7ddc792
PE
1442 Fix porting bug to older POSIXish platforms (Bug#14862).
1443 * sysdep.c (emacs_pipe): New function, that implements
1444 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1445 This should port better to CentOS 5 and to Mac OS X 10.6.
1446 All calls to pipe2 changed.
1447
6c6f1994
PE
1448 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1449 This makes the code easier to read and the executable a bit smaller.
1450 Do not replace all calls to Fcons that happen to create lists,
1451 just calls that are intended to create lists. For example, when
1452 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1453 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1454 Similarly for list2 through list5.
1455 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1456 * bytecode.c (exec_byte_code):
1457 * callint.c (quotify_arg, Fcall_interactively):
1458 * callproc.c (Fcall_process, create_temp_file):
1459 * charset.c (load_charset_map_from_file)
1460 (Fdefine_charset_internal, init_charset):
1461 * coding.c (get_translation_table, detect_coding_system)
1462 (Fcheck_coding_systems_region)
1463 (Fset_terminal_coding_system_internal)
1464 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1465 * composite.c (update_compositions, Ffind_composition_internal):
1466 * dired.c (directory_files_internal, file_name_completion)
1467 (Fsystem_users):
1468 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1469 * doc.c (Fsnarf_documentation):
1470 * editfns.c (Fmessage_box):
1471 * emacs.c (main):
1472 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1473 (Feval, eval_sub, Ffuncall, apply_lambda):
1474 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1475 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1476 (Fset_file_times, Finsert_file_contents)
1477 (Fchoose_write_coding_system, Fwrite_region):
1478 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1479 * font.c (font_registry_charsets, font_parse_fcname)
1480 (font_prepare_cache, font_update_drivers, Flist_fonts):
1481 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1482 * frame.c (make_frame, Fmake_terminal_frame)
1483 (x_set_frame_parameters, x_report_frame_params)
1484 (x_default_parameter, Fx_parse_geometry):
1485 * ftfont.c (syms_of_ftfont):
1486 * image.c (gif_load):
1487 * keyboard.c (command_loop_1):
1488 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1489 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1490 (Fminor_mode_key_binding, accessible_keymaps_1)
1491 (Faccessible_keymaps, Fwhere_is_internal):
1492 * lread.c (read_emacs_mule_char):
1493 * menu.c (find_and_return_menu_selection):
1494 * minibuf.c (get_minibuffer):
1495 * nsfns.m (Fns_perform_service):
1496 * nsfont.m (ns_script_to_charset):
1497 * nsmenu.m (ns_popup_dialog):
1498 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1499 (Fx_own_selection_internal):
1500 * nsterm.m (append2):
1501 * print.c (Fredirect_debugging_output)
1502 (print_prune_string_charset):
1503 * process.c (Fdelete_process, Fprocess_contact)
1504 (Fformat_network_address, set_socket_option)
1505 (read_and_dispose_of_process_output, write_queue_push)
1506 (send_process, exec_sentinel):
1507 * sound.c (Fplay_sound_internal):
1508 * textprop.c (validate_plist, add_properties)
1509 (Fput_text_property, Fadd_face_text_property)
1510 (copy_text_properties, text_property_list, syms_of_textprop):
1511 * unexaix.c (report_error):
1512 * unexcoff.c (report_error):
1513 * unexsol.c (unexec):
1514 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1515 (Fformat_mode_line, syms_of_xdisp):
1516 * xfaces.c (set_font_frame_param)
1517 (Finternal_lisp_face_attribute_values)
1518 (Finternal_merge_in_global_face, syms_of_xfaces):
1519 * xfns.c (x_default_scroll_bar_color_parameter)
1520 (x_default_font_parameter, x_create_tip_frame):
1521 * xfont.c (xfont_supported_scripts):
1522 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1523 (menu_help_callback, xmenu_show):
1524 * xml.c (make_dom):
1525 * xterm.c (set_wm_state):
1526 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1527 and similarly for list2 through list5.
1528
bafe80ce
PE
15292013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * callproc.c (Fcall_process_region): Fix minor race and tune.
1532 (create_temp_file): New function, with the temp-file-creation part
1533 of the old Fcall_process_region. Use Fcopy_sequence to create the
1534 temp file name, rather than alloca + build_string, for simplicity.
1535 Don't bother to block input around the temp file creation;
1536 shouldn't be needed. Simplify use of mktemp. Use
1537 record_unwind_protect immediately after creating the temp file;
1538 this closes an unlikely race where the temp file was not removed.
1539 Use memcpy rather than an open-coded loop.
1540 (Fcall_process_region): Use the new function. If the input is
1541 empty, redirect from /dev/null rather than from a newly created
1542 empty temp file; this avoids unnecessary file system traffic.
1543
4700b5a5
PE
15442013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1545
5c97beae
PE
1546 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1547 Simplify by making this case like the other two. This is a bit
1548 slower on obsolete hosts, but the extra complexity isn't worth it.
1549
4700b5a5
PE
1550 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1551 * process.c (create_process) [!DOS_NT]:
1552 Remove now-unnecessary calls to emacs_close.
1553
f9a74c4c
EZ
15542013-07-13 Eli Zaretskii <eliz@gnu.org>
1555
922ae7ee
EZ
1556 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1557 returning early. (Bug#14850)
1558
f9a74c4c
EZ
1559 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1560 and inhibit-iso-escape-detection attributes of 'undecided'.
1561 (Bug#14822)
1562
5e301d76
PE
15632013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1564
69e0e5ee
PE
1565 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1566 Reported by Herbert J. Skuhra in
1567 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1568
5e301d76
PE
1569 Don't lose top specpdl entry when memory is exhausted.
1570 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1571 specpdl overflow here, to simplify callers; all callers changed.
1572 Always reserve an unused entry at the stack top; this avoids
1573 losing the top entry's information when memory is exhausted.
1574
7e649856
PE
15752013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1576
a773ed9a
PE
1577 Clean up errno reporting and fix some errno-reporting bugs.
1578 * callproc.c (Fcall_process):
1579 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1580 * process.c (create_process, Fmake_network_process):
1581 * unexaix.c (report_error):
1582 * unexcoff.c (report_error):
1583 Be more careful about reporting the errno of failed operations.
1584 The code previously reported the wrong errno sometimes.
1585 Also, prefer report_file_errno to setting errno + report_file_error.
1586 (Fcall_process): Look at openp return value rather than at path,
1587 as that's a bit faster and clearer when there's a numeric predicate.
1588 * fileio.c (report_file_errno): New function, with most of the
1589 old contents of report_file_error.
1590 (report_file_error): Use it.
1591 (Ffile_exists_p, Ffile_accessible_directory_p):
1592 Set errno to 0 when it is junk.
1593 * fileio.c (Faccess_file):
1594 * image.c (x_create_bitmap_from_file):
1595 Use faccessat rather than opening the file, to avoid the hassle of
1596 having a file descriptor open.
1597 * lisp.h (report_file_errno): New decl.
1598 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1599
7e649856
PE
1600 Minor EBADF fixes.
1601 * process.c (create_process, wait_reading_process_output) [AIX]:
1602 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1603 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1604 a multithreaded environment anyway).
1605 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1606
f6774c1a
AS
16072013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1608
1609 * image.c (x_find_image_file): Don't close a remote file handle.
1610
bacba3c2
PE
16112013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1612
1613 Fix races with threads and file descriptors.
1614 * callproc.c (Fcall_process_region):
1615 * dired.c (open_directory):
1616 * emacs.c (main, Fdaemon_initialized):
1617 * image.c (x_find_image_file):
1618 * inotify.c (Finotify_rm_watch):
1619 * lread.c (Flocate_file_internal):
1620 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1621 * term.c (term_mouse_moveto, init_tty):
1622 * termcap.c (tgetent):
1623 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1624 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1625 * unexhp9k800.c, unexmacosx.c (unexec):
1626 * callproc.c (Fcall_process_region):
1627 Use emacs_close, not close.
1628 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1629 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1630 and posix_close function on current platforms (which all lack them).
1631 (emacs_close): Use it. This should fix the races on GNU/Linux and
1632 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1633 and it should avoid closing random victim file descriptors on
1634 other platforms.
1635
653d4f43
PE
16362013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1637
c8536ec4
PE
1638 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1639 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1640 Touch up doc a bit.
1641
9c203066
PE
1642 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1643 This is for .gdbinit xbacktrace.
1644
653d4f43
PE
1645 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1646 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1647 (emacs_set_tty): Now static.
1648 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1649 * term.c (tty_capable_p, tty_default_color_capabilities)
1650 (get_tty_terminal, term_mouse_movement)
1651 (handle_one_term_event, init_tty, maybe_fatal):
1652 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1653 (tgetent, scan_file, name_match, compare_contin):
1654 * terminal.c (get_terminal):
1655 Use bool for boolean.
1656 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1657 Prefer char to unsigned char if either will do.
1658 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1659 (tty_write_glyphs): Prefer int to unsigned.
1660 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1661 All callers changed.
1662 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1663
45b683a1
PE
16642013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1665
29abe551
PE
1666 Port to C89.
1667 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1668 (B__dummy__): New dummy symbol, to pacify C89.
1669 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1670 they can't grok varargs macros.
1671 * dispnew.c (add_window_display_history)
1672 (add_frame_display_history):
1673 * print.c (print_object):
1674 * xdisp.c (debug_method_add):
1675 Use %p printf format only for void pointers.
1676 * emacs.c (usage_message): New constant, replacing ...
1677 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1678 (main): Adjust to usage reorg.
1679 * fns.c (syms_of_fns):
1680 * profiler.c (syms_of_profiler):
1681 Don't use non-constant struct initializers.
1682 * gnutls.h (gnutls_initstage_t):
1683 * lisp.h (enum Lisp_Fwd_Type):
1684 * lread.c (lisp_file_lexically_bound_p):
1685 * xsettings.c (anonymous enum):
1686 Remove trailing comma.
1687 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1688 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1689 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1690 (DEFUN): Use it.
1691 * regex.c (const_re_char): New type, to pacify strict C89.
1692 All uses of 'const re_char' replaced to use it.
1693 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1694 with glibc when strict C89. This change is imported from gnulib.
1695 All uses changed.
1696 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1697 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1698 Omit GNU_LINUX implementation, since it requires long long.
1699 * xterm.c (x_draw_underwave):
1700 Do not assume the traditional order of struct's members.
1701 (x_term_init): Rewrite to avoid the need for non-constant structure
1702 initializers.
1703
45b683a1 1704 Syntax cleanup, mostly replacing macros with functions.
763a086d 1705 This removes the need for the syntax_temp hack.
45b683a1
PE
1706 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1707 * syntax.c (SYNTAX_INLINE): New macro.
1708 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1709 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1710 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1711 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1712 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1713 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1714 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1715 Now constants, not macros.
1716 (syntax_temp) [!__GNUC__]: Remove.
1717 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1718 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1719 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1720 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1721 Move here from syntax.h; now functions, not macros. Except for the
1722 last function, these are static since only syntax.c uses them.
1723 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1724 All uses changed. Now a function, not a macro; use this fact
1725 to simplify the code.
1726 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1727 compiler bugs; no longer relevant.
1728 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1729 (SYNTAX_INLINE): New macro.
1730 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1731 for the new functions. Use bool for boolean member.
1732 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1733 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1734 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1735 (SETUP_BUFFER_SYNTAX_TABLE):
1736 Now extern inline functions, not macros.
1737 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1738 Remove; all uses replaced by implementation.
1739 (syntax_temp) [!__GNUC__]: Remove decl.
1740 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1741
29be4a50
JD
17422013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1743
1744 * emacs.c (main): Fix syntax error.
1745
954b166e
PE
17462013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 Timestamp fixes for undo (Bug#14824).
1749 * atimer.c (schedule_atimer):
1750 * fileio.c (Ffile_newer_than_file_p):
1751 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1752 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1753 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1754 (syms_of_fileio): Remove Sclear_visited_file_name.
1755 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1756 file doesn't exist; this avoids an ambiguity with negative timestamps.
1757 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1758 * systime.h (make_emacs_time, invalid_emacs_time):
1759 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1760 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1761 * undo.c (record_first_change): Push (visited-file-modtime) onto
1762 undo list rather than reimplementing it by hand, incorrectly.
1763
d74647c3
KB
17642013-07-09 Ken Brown <kbrown@cornell.edu>
1765
1766 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1767
3c51b96b
JB
17682013-07-09 Juanma Barranquero <lekktu@gmail.com>
1769
1770 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1771
4ebbdd67
PE
17722013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 Handle errno and exit status a bit more carefully.
1775 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1776 number into an exit status. Instead, use EXIT_CANCELED.
1777 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1778 * callproc.c (relocate_fd):
1779 * emacs.c (close_output_streams, main):
1780 * process.c (create_process):
1781 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1782 Use emacs_perror for simplicity.
1783 * callproc.c (relocate_fd, main):
1784 * sysdep.c (sys_subshell):
1785 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1786 (shut_down_emacs): Use emacs_write, not write.
1787 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1788 * fileio.c (Fcopy_file, e_write):
1789 * nsterm.m (ns_select):
1790 * process.c (send_process):
1791 * sound.c (vox_write):
1792 Use emacs_write_sig, not emacs_write.
1793 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1794 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1795 New constants.
1796 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1797 of write.
1798 (emacs_full_write): New function.
1799 (emacs_write): Rewrite to use it.
1800 (emacswrite_sig, emacs_perror): New functions.
1801 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1802
44e18199 18032013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1804
1805 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1806 on NS even if it is present. Pixmap on NS is a void*.
1807
9caab067
PE
18082013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 Port to Ubuntu 10 (Bug#14803).
1811 Problem reported by T.V. Raman.
1812 * process.c (close_on_exec, accept4, process_socket):
1813 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1814
1d442672
EZ
18152013-07-07 Eli Zaretskii <eliz@gnu.org>
1816
1817 * w32.c (sys_dup): Declare prototype.
1818
1819 * filelock.c:
1820 * emacs.c:
1821 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1822
067428c1
PE
18232013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1824
1825 Make file descriptors close-on-exec when possible (Bug#14803).
1826 This simplifies Emacs a bit, since it no longer needs to worry
1827 about closing file descriptors by hand in some cases.
1828 It also fixes some unlikely races. Not all such races, as
1829 libraries often open files internally without setting
1830 close-on-exec, but it's an improvement.
1831 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1832 * callproc.c (Fcall_process) [!MSDOS]:
1833 * emacs.c (main) [!DOS_NT]:
1834 * nsterm.m (ns_term_init):
1835 * process.c (create_process):
1836 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1837 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1838 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1839 Prefer mkostemp with O_CLOEXEC to mkstemp.
1840 * callproc.c (relocate_fd) [!WINDOWSNT]:
1841 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1842 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1843 now using pipe2.
1844 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1845 Make the resulting file descriptor close-on-exec.
1846 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1847 * lread.c (load_descriptor_list, load_descriptor_unwind):
1848 Remove; no longer needed. All uses removed.
1849 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1850 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1851 New functions.
1852 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1853 (Fmake_network_process, Fnetwork_interface_list):
1854 (Fnetwork_interface_info, server_accept_connection):
1855 Make newly-created socket close-on-exec.
1856 * sysdep.c (emacs_open, emacs_fopen):
1857 Make new-created descriptor close-on-exec.
1858 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1859 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1860
0da857dd
JD
18612013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1862
1863 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1864 for NS_IMPL_GNUSTEP.
1865
5f86adcd
PE
18662013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1867
1868 Fix openp errno handling.
1869 * callproc.c (Fcall_process): Preserve openp errno around close.
1870 * lread.c (openp): Set errno when returning -1, as some callers
1871 expect this.
1872
1afb1d07
JD
18732013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1874
1875 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1876
1877 * nsterm.h (NSSavePanel): Update comment.
1878 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1879 (ns_run_file_dialog): Declare.
1880
1881 * nsfns.m: Remove panelOK.
1882 (ns_fd_data): New.
1883 (ns_run_file_dialog): New function.
1884 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1885 event loop, so file dialog is popped up by ns_run_file_dialog, called
1886 by sendEvent (Bug#14578).
1887 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1888
3323c263
EZ
18892013-07-06 Eli Zaretskii <eliz@gnu.org>
1890
fdda0220
EZ
1891 * xdisp.c (default_line_pixel_height): New function.
1892 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1893 (try_cursor_movement, redisplay_window, try_window)
1894 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1895
1896 * window.c (window_scroll_pixel_based): use
1897 default_line_pixel_height.
1898
1899 * dispextern.h (default_line_pixel_height): Add prototype.
1900
1901 * frame.c (x_set_line_spacing): Accept a float value for
1902 line-spacing parameter, per the documentation.
1903
3323c263
EZ
1904 * data.c (Fmultibyte_string_p): Doc fix.
1905
47ba6d43
PE
19062013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1907
406af475
PE
1908 Use emacs_open more consistently when opening files.
1909 This handles EINTR more consistently now, and makes it easier
1910 to introduce other uniform changes to file descriptor handling.
1911 * src/systdio.h: New file.
1912 * src/buffer.c (mmap_init):
1913 * cygw32.c (chdir_to_default_directory):
1914 * dispnew.c (Fopen_termscript):
1915 * emacs.c (Fdaemon_initialized):
1916 * fileio.c (Fdo_auto_save):
1917 * image.c (slurp_file, png_load_body, jpeg_load_body):
1918 * keyboard.c (Fopen_dribble_file):
1919 * lread.c (Fload):
1920 * print.c (Fredirect_debugging_output):
1921 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1922 * termcap.c (tgetent):
1923 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1924 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1925 * w32term.c (w32_initialize) [CYGWIN]:
1926 * xfaces.c (Fx_load_color_file):
1927 Use emacs_open instead of plain open, and emacs_fopen instead of
1928 plain fopen.
1929 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1930 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1931 * callproc.c (default_output_mode): New constant.
1932 (Fcall_process): Use it to call emacs_open instead of plain creat.
1933 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1934 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1935 (emacs_fopen): New function.
1936 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1937 Include <lisp.h>, for emacs_open.
1938 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1939
47ba6d43
PE
1940 Remove duplicate #include directives.
1941 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1942 * xfaces.c:
1943 Don't include stdio.h twice.
1944 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1945 Don't include sys/types.h or stdio.h twice.
1946 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1947 * lread.c: Don't include coding.h twice.
1948 * nsfont.m: Don't include frame.h twice.
1949 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1950 * ralloc.c: Don't include <unistd.h> twice.
1951 * xdisp.c: Don't include font.h twice.
1952 * xterm.c: Don't include fontset.h twice.
1953 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1954
b9ed53d5
PE
19552013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 Scale ImageMagick images more carefully.
1958 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1959 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1960 Be more careful about avoiding undefined behavior after
1961 integer overflow and division by zero.
1962
cf13177e
YM
19632013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1964
1965 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1966 (syms_of_w32fns): DEFSYM them.
1967 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1968 (CCHDEVICENAME): Define macros if not defined.
1969 (struct MONITOR_INFO_EX): New struct.
1970 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1971 (enum_display_monitors_fn): New variable.
1972 (globals_of_w32fns): Initialize it.
1973 (Fx_display_pixel_width, Fx_display_pixel_height)
1974 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1975 multi-monitor setups in docstrings.
1976 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1977 screen size by primary monitor's millimeter per pixel.
1978 (w32_monitor_enum, w32_display_monitor_attributes_list)
1979 (w32_display_monitor_attributes_list_fallback)
1980 (Fw32_display_monitor_attributes_list): New functions.
1981 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1982
1983 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1984 if not defined.
1985 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1986
86dfb7a8
MA
19872013-07-04 Michael Albinus <michael.albinus@gmx.de>
1988
1989 * fileio.c (Qfile_notify_error): New error symbol.
1990
1991 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1992 * inotify.c (inotify_callback, symbol_to_inotifymask)
1993 (Finotify_add_watch, Finotify_rm_watch): Use it.
1994 (inotifyevent_to_event): Exchange order of cookie and file name.
1995 (Finotify_add_watch): Adapt docstring.
1996
1997 * lisp.h (Qfile_notify_error): Declare.
1998
2c1c974b
PE
19992013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2002 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2003 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2004 which did not work (see <http://bugs.gnu.org/14569#307>).
2005 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2006 && (!noninteractive || initialized)). This attempts to thread
2007 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2008
7a35b20f
JB
20092013-07-04 Juanma Barranquero <lekktu@gmail.com>
2010
2011 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2012 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2013
1ce5cd04
PE
20142013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2017 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2018 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2019 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2020
57f8c490
PE
20212013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2024 Define to __sys_siglist.
2025
bcffb5ca
EZ
20262013-07-02 Eli Zaretskii <eliz@gnu.org>
2027
2028 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2029 word-wrap, so that overflow-newline-into-fringe would work in
2030 visual-line-mode. (Bug#2749)
2031 (move_it_in_display_line_to): When the last scanned display
2032 element fits exactly on the display line, and
2033 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2034 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2035 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2036 finding buffer position that corresponds to pixel coordinates,
2037 e.g. in buffer_posn_from_coords.
2038
2c41e781
JD
20392013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2040
2041 * process.c (handle_child_signal): Call catch_child_signal if
2042 NS_IMPL_GNUSTEP.
2043
c2418359
PE
20442013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2045
52a9bcae
PE
2046 Don't convert function pointers to void * and back.
2047 It isn't portable C, and it's easy enough to avoid.
2048 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2049 (make_save_value): Add support for SAVE_FUNCPOINTER.
2050 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2051 * print.c (print_object):
2052 Distinguish function from object pointers.
2053 * lisp.h (SAVE_FUNCPOINTER): New constant.
2054 (SAVE_SLOT_BITS): Adjust to it.
2055 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2056 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2057 (voidfuncptr): New typedef.
2058 (struct Lisp_Save_Value): New member data[0].funcpointer.
2059 (XSAVE_FUNCPOINTER): New function.
2060
c2418359
PE
2061 Simplify buildobj processing.
2062 * Makefile.in (buildobj.h): Make it a sequence of strings each
2063 followed by comma, rather than a single string. Put it into a
2064 .tmp file in case there's an error while generating it.
2065 (gl-stamp): Use .tmp for temp files.
2066 (mostlyclean): Clean .tmp files.
2067 * doc.c (buildobj): Move to just the routine that needs it.
2068 It's now an array of strings, so processing is simpler.
2069
8f43ce49
PE
20702013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2073 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2074 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2075 Invoke malloc_enable_thread even when not interactive.
2076 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2077 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2078 in this case, since the underlying bug has now been fixed.
2079
24827db9
JB
20802013-07-01 Juanma Barranquero <lekktu@gmail.com>
2081
2082 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2083 unlinking it (bug#14691).
2084
ef099a94
MN
20852013-06-30 Michal Nazarewicz <mina86@mina86.com>
2086
2087 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2088 before checking whether buffer is modified. This lets
2089 `kill-buffer-query-functions' cancel killing of the buffer or save
2090 its content before `kill-buffer' asks user the "Buffer %s
2091 modified; kill anyway?" question.
2092
9d3f2fc2
JD
20932013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2094
2095 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2096 Let the super performKeyEquivalent deal with them (Bug#14747).
2097
e6c6c8c7
PE
20982013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2099
1d71c1d9
PE
2100 * widget.c (resize_cb): Remove unused local.
2101
8f5f35cc
PE
2102 Do not use GTK 3 if it exists but cannot be compiled.
2103 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2104 * xterm.c (x_error_handler) [!USE_GTK]:
2105 Do not use GTK 3.
2106
e6c6c8c7
PE
2107 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2108
0ba54312
EZ
21092013-06-30 Eli Zaretskii <eliz@gnu.org>
2110
5d1c3286
EZ
2111 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2112 to the valid range of values. (Bug#14753)
2113
0ba54312
EZ
2114 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2115 when moving point by using the current glyph matrix. This avoids
2116 the need to force redisplay when this function is called in a
2117 loop.
2118
9c90cc06
PE
21192013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 Fix minor problems found by static checking.
2122 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2123 Redo the latter's body to sidestep GCC parenthesization warnings.
2124 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2125 * coding.c (detect_coding, detect_coding_system):
2126 * coding.h (struct undecided_spec):
2127 Use bool for boolean.
2128 * image.c (QCmax_width, QCmax_height): Now static.
2129 * xdisp.c (Fmove_point_visually): Remove unused local.
2130
4c672a0f
EZ
21312013-06-29 Eli Zaretskii <eliz@gnu.org>
2132
2133 * xdisp.c (Fmove_point_visually): New function.
2134
c1ea3abf
JB
21352013-06-28 Kenichi Handa <handa@gnu.org>
2136
2137 * coding.h (define_coding_undecided_arg_index): New enum.
2138 (coding_attr_index): New members
2139 coding_attr_undecided_inhibit_null_byte_detection,
2140 coding_attr_undecided_inhibit_iso_escape_detection,
2141 coding_attr_undecided_prefer_utf_8.
2142 (undecided_spec): New struct.
2143 (struct coding_system): New member `undecided' of the member
2144 `spec'.
2145
2146 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2147 (detect_coding): Likewise.
2148 (detect_coding_system): Likewise.
2149 (Fdefine_coding_system_internal): New coding system properties
2150 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2151 :prefer-utf-8.
2152 (syms_of_coding): Adjust for coding_arg_undecided_max.
2153
ba3de9e6
PE
21542013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 * image.c (x_from_xcolors): Remove unused local.
2157
547c9269
YM
21582013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2159
2160 Defer image data transfer between X client and server until actual
2161 display happens.
2162
2163 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2164 and `mask_img'.
2165
2166 * image.c (Destroy_Image): Remove.
2167 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2168 `mask_p', and `colors_p'. All uses changed.
2169 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2170 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2171 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2172 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2173 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2174 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2175 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2176 (image_get_x_image, image_unget_x_image): New functions or macros.
2177 (image_background, image_background_transparent, x_to_xcolors)
2178 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2179 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2180 instead of Destroy_Image.
2181 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2182 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2183 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2184 (imagemagick_load_image, svg_load_image): Use them instead of
2185 x_create_x_image_and_pixmap, and x_put_x_image followed by
2186 x_destroy_x_image, respectively.
2187 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2188 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2189 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2190 background_transparent fields.
2191 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2192 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2193
dae2f5ef
PE
21942013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2195
2196 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2197 This mostly consists of undoing recent changes.
2198 * callproc.c (Fcall_process):
2199 * process.c (create_process):
2200 Do not worry about catching SIGCHLD here, undoing previous change.
2201 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2202 * process.c, process.h (catch_child_signal):
2203 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2204 * process.c (catch_child_handler): Don't worry about being called
2205 lazily and do not assume caller has blocked SIGCHLD, undoing
2206 previous change. Move first-time stuff back to
2207 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2208 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2209 set lib_child_handler if it's already initialized, which may
2210 help avoid problems on GNUStep.
2211
fa55d2aa
PE
22122013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2215 * callproc.c (Fcall_process):
2216 * process.c (create_process):
2217 Make sure SIGCHLD is caught before we fork,
2218 since Emacs startup no arranges to catch SIGCHLD.
2219 * process.c (lib_child_handler): Initialize to null, not to
2220 dummy_handler.
2221 (catch_child_signal): Allow self to be called lazily.
2222 Do nothing if it's already been called.
2223 Assume caller has blocked SIGCHLD (all callers do now).
2224 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2225 just before it's really needed.
2226 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2227 since it hasn't been caught yet.
2228
f3f9606c
LMI
22292013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2230
2231 * image.c (compute_image_size): New function to implement
2232 :max-width and :max-height.
2233 (imagemagick_load_image): Use it.
2234
c7041908
PE
22352013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2236
2237 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2238 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2239 Now extern.
2240 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2241 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2242 the SIGCHLD handler, since the code is not atomic and (due to glib)
2243 signals may be arriving now.
2244 * sysdep.c (init_signals): Do not catch child signals here;
2245 'main' now does that later, at a safer time.
2246
f86852b4
PE
22472013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2248
0dfeed58
PE
2249 Clean up SIGCHLD handling a bit (Bug#14569).
2250 * process.c, process.h (catch_child_signal):
2251 Now always extern, even if !NS_IMPL_GNUSTEP.
2252 * process.c (catch_child_signal): Move glib tickler here from
2253 init_process_emacs, so that it's done earlier in Emacs
2254 initialization. Also move the noninteractive && !initialized
2255 check here from init_process_emacs. This is all a bit cleaner for
2256 GNUish platforms, and I hope it works around the Cygwin bug.
2257 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2258 that glib signal handling is tickled before glib creates threads.
2259
f86852b4
PE
2260 * process.c (wait_reading_process_output): Avoid int overflow
2261 when reading more than 2 GiB total from a process.
2262
cbd6509c
PE
22632013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2264
2265 * process.c (create_process): Handle a couple more cases,
2266 i.e., work even if new_argv and wait_child_setup[i] are cached.
2267 Use Fcall_process's style for volatile vars.
2268
9de1114a
AS
22692013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2270
2271 * process.c (create_process): Mark PROCESS volatile.
2272
fbe9e0b9
PE
22732013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2274
2275 Use C99-style flexible array members if available.
2276 This avoids some subtle aliasing issues, which typically
2277 aren't a problem with GCC but may be a problem elsewhere.
2278 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2279 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2280 In either case, it uses a flexible array member rather than
2281 the old struct hack. All uses changed.
2282 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2283 Adjust to sdata reorganization.
2284 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2285 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2286 that ports better to pre-C99 non-GCC.
2287 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2288 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2289 as the latter has changed.
2290 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2291 and port better to pre-C99 GCC.
2292 * image.c (struct xpm_cached_color):
2293 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2294 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2295 Use FLEXIBLE_ARRAY_MEMBER.
2296 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2297 Move decl to top level so it gets checked against implementation.
2298 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2299 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2300
1fc71008
PE
23012013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * syntax.c: Integer cleanups.
2304 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2305 All uses that need 0-or-2 changed to:
2306 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2307 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2308 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2309 (char_quoted, prev_char_comend_first, back_comment)
2310 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2311 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2312 Use bool for boolean.
2313 (update_syntax_table, skip_chars, skip_syntaxes):
2314 Prefer int to unsigned when either will do.
2315 (back_comment): Return boolean success flag, like forw_comment,
2316 instead of positive-or-minus-1 (which might have overflowed int anyway).
2317 Don't stuff ptrdiff_t into int.
2318 (syntax_spec_code, syntax_code_spec): Now const.
2319 (Fmatching_paren, scan_lists, scan_sexps_forward):
2320 Use enum syntaxcode for syntax code.
2321 (Fmatching_paren): Check that arg is a character, not just an integer.
2322 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2323 (Finternal_describe_syntax_value): Omit no-longer-needed
2324 comparison to 0.
2325 (skip_chars): Use char, not unsigned char, when the distinction
2326 doesn't matter.
2327 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2328 * bytecode.c (exec_byte_code):
2329 * syntax.c (syntax_spec_code, Fchar_syntax)
2330 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2331 (init_syntax_once):
2332 * syntax.h (SYNTAX_WITH_FLAGS):
2333 Omit unnecessary casts.
2334
b932cad7
EZ
23352013-06-20 Eli Zaretskii <eliz@gnu.org>
2336
2337 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2338 line dimensions here, to avoid race conditions with the main
2339 thread. (Bug#14062, bug#14630, bug#14669)
2340
2341 * w32term.c (w32_draw_window_cursor): Compute the header line and
2342 mode line dimensions here.
2343 <w32_system_caret_window, w32_system_caret_hdr_height>:
2344 <w32_system_caret_mode_height>: New variables.
2345
2346 * w32term.h: Declare them.
2347
89561f72
PE
23482013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2349
5013fc08
PE
2350 * alloc.c (die): Move "assertion failed" string here ...
2351 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2352 COND when SUPPRESS_CHECKING. This shrinks the executable text
2353 size by 0.8% to 2.2% when configured with --enable-checking,
2354 depending on optimization flags (GCC 4.8.1 x86-64).
2355
89561f72
PE
2356 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2357
763a086d 23582013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2359
2360 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2361 base is 2; this is more accurate.
2362
983aeb9a
JB
23632013-06-19 Juanma Barranquero <lekktu@gmail.com>
2364
2365 * sound.c (string_default): Move to !WINDOWSNT section.
2366 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2367
178ba3e6
PE
23682013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2369
bbc51b15
PE
2370 * sound.c: Integer cleanups.
2371 Remove unnecessary forward decls.
2372 (struct sound_device): The 'file' member is now a Lisp_Object, not
2373 a char *, so that we needn't invoke alloca on a huge size.
2374 (Fplay_sound_internal): Adjust to this.
2375 (string_default): New function.
2376 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2377 Use it to adjust to the struct sound_device change.
2378 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2379 (be2hs) [0]: Remove.
2380
178ba3e6
PE
2381 * syntax.c (skip_chars): Don't use uninitialized storage
2382 when searching a multibyte buffer for characters that are not in a
2383 unibyte string that contains non-ASCII characters.
2384
69f60cdc
JD
23852013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2386
2387 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2388 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2389
0d6224d4
PE
23902013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2391
2392 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2393
3c542890
KH
23942013-06-18 Kenichi Handa <handa@gnu.org>
2395
f7e3f7cd
KH
2396 * font.c (Ffont_spec): Signal an error for an invalid font name
2397 (Bug#14648).
3c542890 2398
9349e5f7
PE
23992013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2400
2401 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2402 In particular this ports to 32-bit sparc Sun cc.
2403 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2404 array with a dummy element at specpdl[-1], so that its address can
2405 be taken portably.
2406 (unbind_to): Do not copy the binding; not needed, now that we
2407 copy old_value in the one place where the copy is needed.
2408 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2409 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2410 (union specbinding): Rename from struct specbinding. Redo layout
2411 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2412 which is not portable. With Sun C 5.12 32-bit sparc, the
2413 declaration causes nargs to be an unsigned bitfield, a behavior
2414 that the C standard allows; but Emacs wants nargs to be signed.
2415 The overall type is now a union of structures rather than a
2416 structure of union of structures, and the 'kind' member is now a
2417 bitfield, so that the overall type doesn't grow. All uses changed.
2418 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2419
0a4df6a5
PE
24202013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2421
ec6ecaad
PE
2422 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2423 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2424
0a4df6a5
PE
2425 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2426
7bfe8dbc
EZ
24272013-06-17 Eli Zaretskii <eliz@gnu.org>
2428
2429 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2430 unless we know that the window w's frame is a frame object.
2431 Another attempt at solving bug#14062 and bug#14630.
2432
708e05f6
LMI
24332013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2434
2435 * textprop.c (property_set_type): New enum.
2436 (add_properties): Allow appending/prepending text properties.
2437 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2438 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2439 add_text_properties_1.
2440 (Fadd_face_text_property): New function that calls
2441 add_text_properties_1.
2442
84575e67
PE
24432013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 Move functions from lisp.h to individual modules when possible.
2446 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2447 * alloc.c (XFLOAT_INIT, set_symbol_name):
2448 * buffer.c (CHECK_OVERLAY):
2449 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2450 (set_char_table_parent):
2451 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2452 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2453 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2454 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2455 (set_blv_valcell):
2456 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2457 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2458 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2459 (backtrace_args, backtrace_debug_on_exit):
2460 * floatfns.c (CHECK_FLOAT):
2461 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2462 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2463 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2464 (set_hash_index_slot):
2465 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2466 * marker.c (CHECK_MARKER):
2467 * textprop.c (CHECK_STRING_OR_BUFFER):
2468 * window.c (CHECK_WINDOW_CONFIGURATION):
2469 Move here from lisp.h, and make these functions static rather than
2470 extern inline.
2471 * buffer.c (Qoverlayp):
2472 * data.c (Qsubrp):
2473 * fns.c (Qhash_table_p):
2474 * window.c (Qwindow_configuration_p):
2475 Now static.
2476 * lisp.h: Remove the abovementioned defns and decls.
2477
44e18199 2478 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2479 In lisp.h, prefer functions to function-like macros, and
2480 constants to object-like macros, when either will do. This:
2481 . simplifies use, as there's no more need to worry about
2482 arguments' side effects being evaluated multiple times.
2483 . makes the code easier to debug on some platforms.
2484 However, when using gcc -O0, keep using function-like macros
2485 for a few critical operations, for performance reasons.
2486 This sort of thing isn't needed with gcc -Og, but -Og
2487 is a GCC 4.8 feature and isn't widely-enough available yet.
2488 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2489 Remove enum lsb_bits; no longer needed.
2490 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2491 * buffer.c (Qoverlap):
2492 * data.c (Qsubrp):
2493 * fns.c (Qhash_table_p):
2494 Now extern, so lisp.h can use these symbols.
2495 * dispextern.h: Include character.h, for MAX_CHAR etc.
2496 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2497 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2498 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2499 (GLYPH_CODE_P): Move here from lisp.h.
2500 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2501 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2502 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2503 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2504 XUNTAG now returns void *.
2505 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2506 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2507 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2508 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2509 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2510 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2511 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2512 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2513 New macros, renamed from their sans-lisp_h_ counterparts.
2514 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2515 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2516 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2517 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2518 If compiling via GCC without optimization, define these as macros
2519 in addition to inline functions.
2520 To disable this, compile with -DINLINING=0.
2521 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2522 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2523 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2524 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2525 (INTMASK, VALMASK): Now macros, since static values cannot be
2526 accessed from extern inline functions.
2527 (VALMASK): Also a constant, for benefit of old GDB.
2528 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2529 is INTEGERP, which can fold it in.
5165d44a 2530 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2531 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2532 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2533 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2534 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2535 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2536 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2537 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2538 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2539 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2540 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2541 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2542 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2543 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2544 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2545 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2546 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2547 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2548 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2549 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2550 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2551 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2552 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2553 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2554 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2555 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2556 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2557 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2558 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2559 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2560 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2561 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2562 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2563 Now functions.
2564 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2565 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2566 (VALMASK): Define in one place rather than in two, merging the
2567 USE_LSB_TAG parts; this is simpler.
2568 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2569 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2570 Move up, to avoid use before definition.
2571 Also include "globals.h" earlier, for the same reason.
2572 (make_natnum): New function.
2573 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2574 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2575 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2576 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2577 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2578 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2579 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2580 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2581 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2582 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2583 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2584 (Qwindow_configuration_p, Qimage): New forward declarations.
2585 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2586 (STRING_COPYIN): Remove; unused.
2587 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2588 (xcar_addr, xcdr_addr): New functions. All uses changed.
2589 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2590 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2591 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2592 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2593 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2594 (TYPE_RANGED_INTEGERP): Simplify.
2595 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2596 (setlocale, fixup_locale, synchronize_system_messages_locale)
2597 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2598 Now empty functions, not macros.
2599 (functionp): Return bool, not int.
2600 * window.c (Qwindow_configuration_p): Now extern,
2601 so window.h can use it.
2602 * window.h (Qwindowp): Move decl back to lisp.h.
2603
9583ec36
EZ
26042013-06-15 Eli Zaretskii <eliz@gnu.org>
2605
2606 * xdisp.c (Fline_pixel_height): New function, required for solving
2607 bug #14567.
2608
210272ce
PE
26092013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2610
2611 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2612
de0503df
SM
26132013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2614
2615 * lread.c (syms_of_lread):
2616 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2617
afbfe143
KD
26182013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2619
2620 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2621
d177e213
XF
26222013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2623
2624 * fileio.c (expand_file_name): Doc fix.
2625
05e3e412
PE
26262013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2627
f7394b12
PE
2628 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2629 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2630 Wait for self, not for 0. This can't hurt on GNU or similar
2631 system, and may help with Cygwin.
2632
05e3e412
PE
2633 * keyboard.c: Don't use PROP (...) as an lvalue.
2634 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2635 Use set_prop (A, B), not PROP (A) = B.
2636
17dd3097
EZ
26372013-06-10 Eli Zaretskii <eliz@gnu.org>
2638
2639 * xdisp.c (get_it_property): Use it->window instead of generating
2640 a Lisp object from it->w.
2641
52fab9c9
EZ
26422013-06-09 Eli Zaretskii <eliz@gnu.org>
2643
2644 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2645 get-char-property the window that is being rendered, instead of
2646 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2647 (compute_display_string_pos): When W is NULL, use the current
2648 buffer as the object to pass to get-char-property.
2649 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2650 pointer member of the bidi iterator, since no window is pertinent
2651 to this function.
52fab9c9 2652
5bf97bfc
EZ
26532013-06-08 Eli Zaretskii <eliz@gnu.org>
2654
2655 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2656 being displayed, and pass it to compute_display_string_pos.
2657 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2658 (bidi_paragraph_init): All callers changed.
2659
2660 * xdisp.c (init_from_display_pos, init_iterator)
2661 (handle_single_display_spec, next_overlay_string)
2662 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2663 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2664 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2665 (compute_display_string_pos): Accept additional argument, the
2666 window being displayed, and pass it to Fget_char_property.
2667 (Bug#14575)
2668
2669 * dispextern.h (struct bidi_it): New member w, the window being
2670 displayed.
2671 (compute_display_string_pos): Adjust prototype.
2672
5de0e011
JD
26732013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2674
e7b41c4c 2675 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2676
2677 * process.c (wait_reading_process_output): Check for NS before GLIB.
2678 GLIB may be linked in due to rsvg, but ns_select must be called.
2679
5de0e011
JD
2680 * xgselect.c (xg_select): Remove call to window_system_available
2681 and g_main_context_pending at the top, so Gdk events (i.e. file
2682 notify) are processed when Emacs is started with -nw.
2683
a822acff
EZ
26842013-06-07 Eli Zaretskii <eliz@gnu.org>
2685
2686 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2687 (ctagsfiles3): New variable, includes only *.m files.
2688 (TAGS): Use an explicit language name in the regular expressions,
2689 to avoid transformation of '/SOMETHING' by MSYS to
2690 'c:\MSYS\SOMETHING'.
2691
6c0a9ed1
RC
26922013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2693
2694 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2695
9ef6111b
EZ
26962013-06-06 Eli Zaretskii <eliz@gnu.org>
2697
2698 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2699 still need to set the mouse pointer shape and activate help-echo.
2700 (Bug#14558)
2701
7d300d64
PE
27022013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 A few porting etc. fixes for the new file monitor code.
2705 See the thread containing
2706 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2707 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2708 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2709 (dir_monitor_callback, Fgfile_rm_watch):
2710 Use assq_no_quit instead of Fassoc, for speed.
2711 (dir_monitor_callback, Fgfile_rm_watch):
2712 eassert that the monitor is a fixnum.
2713 (dir_monitor_callback): No need for CDR_SAFE.
2714 Simplify building of lisp with alternative tails.
2715 (Fgfile_add_watch, Fgfile_rm_watch):
2716 Do not assume glib functions set errno reliably on failure.
2717 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2718 and signal an error otherwise.
2719 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2720 Use Fdelq instead of Fdelete, for speed.
2721
817ebfcf
EZ
27222013-06-05 Eli Zaretskii <eliz@gnu.org>
2723
2724 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2725 don't insist on being invoked on a highlighted tool-bar button.
2726 Avoids losing tool-bar functionality when mouse-highlight is nil.
2727 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2728 Don't highlight when mouse-highlight is nil.
2729 (note_mouse_highlight): When mouse-highlight is nil, don't return
2730 right away; instead, run tool-bar and mode-line highlight
2731 subroutine, clear any existing highlight, and revert the mouse
2732 pointer to its default shape. (Bug#14558)
2733
55577e7c
SM
27342013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2735
2736 * lisp.mk (lisp): Add prog-mode.el.
2737
f019a684
PE
27382013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2741 * process.c (dummy_handler): New function.
2742 (lib_child_handler): New static var.
2743 (handle_child_signal): Invoke it.
2744 (catch_child_signal): If a library has set up a signal handler,
2745 save it into lib_child_handler.
2746 (init_process_emacs): If using glib and not on Windows, tickle glib's
2747 child-handling code so that it initializes its private SIGCHLD handler.
2748 * syssignal.h (SA_SIGINFO): Default to 0.
2749 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2750 31; it should no longer be needed now.
2751
90db8702
MA
27522013-06-05 Michael Albinus <michael.albinus@gmx.de>
2753
2754 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2755
2756 * gfilenotify.c (globals_of_gfilenotify): New function.
2757 (syms_of_gfilenotify): Move global initialization there.
2758
2759 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2760
bfa3acd6
SM
27612013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2762
2763 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2764 * keyboard.c (menu_bar_items, tool_bar_items):
2765 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2766 not override local keymaps any more.
2767
ba59bd80
EZ
27682013-06-04 Eli Zaretskii <eliz@gnu.org>
2769
2770 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2771
7f203aa1
EZ
27722013-06-03 Eli Zaretskii <eliz@gnu.org>
2773
9337e206
EZ
2774 * w32console.c (initialize_w32_display): Return the dimensions of
2775 the console window via 2 additional arguments, not via the current
2776 frame. This avoids crashes due to overrunning the bounds of
2777 frame's decode_mode_spec_buffer, which is not resized following
2778 the change of the frame dimensions from the initial 10x10.
2779
2780 * w32term.h (w32_initialize_display_info): Adjust prototype.
2781
2782 * term.c (init_tty): Take dimensions of the frame from the values
2783 returned by initialize_w32_display.
2784
7f203aa1
EZ
2785 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2786 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2787 (LIBES): Add $(GFILENOTIFY_LIBS).
2788
2789 * w32inevt.c (handle_file_notifications): Add dummy implementation
2790 for !HAVE_W32NOTIFY.
2791
2792 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2793
55a87246
JD
27942013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2795
2796 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2797
2798 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2799
2800 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2801
3d5ee10a
PE
28022013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 Fix minor problems found by static checking.
2805 * data.c (pure_write_error):
2806 Use xsignal2, not Fsignal, as Fsignal might return.
2807 * eval.c (set_backtrace_debug_on_exit): Now static.
2808 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2809 No longer inline. EXTERN_INLINE is needed only for functions
2810 defined in .h files. Reindent function header as per GNU style.
2811 (backtrace_p, backtrace_top, backtrace_next):
2812 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2813 compiler or linker. Add extern decls to pacify gcc -Wall.
2814 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2815 Now static.
2816 * frame.c (free_monitors): Define only on platforms that need it.
2817 * nsterm.m (ns_term_init):
2818 * process.c (catch_child_signal):
2819 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2820 defined on all porting targets these days.
2821 * process.c, process.h (catch_child_signal):
2822 Make it extern only if NS_IMPL_GNUSTEP is defined.
2823
e2d8a6f0
EZ
28242013-06-03 Eli Zaretskii <eliz@gnu.org>
2825
2826 * w32.c (gettimeofday): Make the signature identical to prototype
2827 in nt/inc/sys/time.h.
2828
a8a7c5f6
SM
28292013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2830
2831 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2832 .gdbinit.
2833
2834 * keyboard.c (safe_run_hooks_error): Improve error message.
2835
2836 * data.c (pure_write_error): Add `object' argument.
2837 * puresize.h (CHECK_IMPURE): Use it.
2838
c9628c79
MA
28392013-06-03 Michael Albinus <michael.albinus@gmx.de>
2840
2841 * Makefile.in (NOTIFY_OBJ): New variable.
2842 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2843
2844 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2845 Call syms_of_gfilenotify.
2846
2847 * gfilenotify.c: New file.
2848
2849 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2850 and Qfile_w32notify.
2851 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2852 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2853
2854 * lisp.h: Declare syms_of_gfilenotify.
2855
2856 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2857
2f592f95
SM
28582013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 Merge the specpdl and backtrace stacks. Make the structure of the
2861 specpdl entries more obvious via a tagged union of structs.
2862 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2863 (enum specbind_tag): New enum.
2864 (struct specbinding): Make it a tagged union of structs.
2865 Add a case for backtrace records.
2866 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2867 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2868 (backtrace_debug_on_exit): New accessors.
2869 (struct backtrace): Remove.
2870 (struct catchtag): Remove backlist field.
2871 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2872 Move to eval.c.
2873 (Flocal_variable_p): Speed up the common case where the binding is
2874 already loaded.
2875 * eval.c (backtrace_list): Remove.
2876 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2877 (set_backtrace_args, set_backtrace_nargs)
2878 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2879 (backtrace_next): New functions.
2880 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2881 (unwind_to_catch, internal_lisp_condition_case)
2882 (internal_condition_case, internal_condition_case_1)
2883 (internal_condition_case_2, internal_condition_case_n): Don't bother
2884 with backtrace_list any more.
2885 (Fsignal): Adjust to new backtrace format.
2886 (grow_specpdl): Move up.
2887 (record_in_backtrace): New function.
2888 (eval_sub, Ffuncall): Use it.
2889 (apply_lambda): Adjust to new backtrace format.
2890 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2891 data.c.
2892 (specbind): Adjust to new specpdl format. Simplify.
2893 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2894 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2895 backtrace format.
2896 (mark_backtrace): Remove.
2897 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2898 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2899 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2900 Use mark_specpdl.
2901 * profiler.c (record_backtrace): Use get_backtrace.
2902 (handle_profiler_signal): Use backtrace_top_function.
2903 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2904 accessor functions.
2905
c0342369
JD
29062013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2907
2908 * process.h (catch_child_signal): Declare.
2909
2910 * process.c (catch_child_signal): New function.
2911 (init_process_emacs): Call it.
2912
2913 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2914 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2915 NS_IMPL_COCOA.
2916 (x_set_cursor_type): Remove declaration.
2917 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2918 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2919 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2920 (ns_get_color): Use F suffix on float.
2921 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2922 (ns_get_rgb_color): Remove.
2923 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2924 (note_mouse_movement): x and y are CGFloat.
2925 (ns_draw_fringe_bitmap): Remove unused rowY.
2926 Change #if to COCOA && >= 10_6.
2927 (ns_draw_window_cursor): Remove unused overspill.
2928 (ns_draw_underwave): width and x are EamcsCGFloat.
2929 (ns_draw_box): thickness is CGFloat.
2930 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2931 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2932 if not in main thread.
2933 (ns_get_pending_menu_title, ns_check_menu_open)
2934 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2935 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2936 (sendFromMainThread:): New method.
2937 (changeFont:): size is CGFloat.
2938 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2939 Disable warning about permanent text.
2940 (characterIndexForPoint:): Adjust return type depending on GNUStep
2941 version.
2942 (mouseDown:): delta is CGFloat.
2943 (updateFrameSize): Remove unised variable f.
2944 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2945 Cast float to EmacsCGFloat.
2946 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2947 also to -1 when restoring.
2948 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2949 inside NS_IMPL_COCOA.
2950 (toggleFullScreen:): Put call to toggleFullScreen inside
2951 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2952 (setPosition:portion:whole:): por is CGFloat.
2953 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2954 (mouseDown:): Use CGFloat.
2955 (mouseDragged:): Remove unised variable edge.
2956 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2957
2958 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2959 of CGFloat differs.
2960 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2961 when NS_IMPL_GNUSTEP.
2962 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2963 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2964 (EmacsToolbar): Add clearAll. Add tag argument to
2965 addDisplayItemWithImage.
2966 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2967
2968 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2969
2970 * nsmenu.m (ns_update_menubar): Make static.
2971 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2972 (fillWithWidgetValue:): Add cast to SEL for setAction.
2973 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2974 (update_frame_tool_bar): Update code for GNUStep.
2975 (clearAll): New method.
2976 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2977 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2978 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2979 call to insertItemWithItemIdentifier.
2980 (validateVisibleItems): Fix indentation.
2981 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2982 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2983 UtilityWindow to aStyle, remove call to setStyleMask.
2984
2985 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2986
2987 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2988 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2989 Use F suffix on floats.
2990 (ns_char_width): Returns CGFloat.
2991 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2992 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2993 DPSxshow.
2994 (ns_glyph_metrics): CGFloat instead of float.
2995
a0eb10b3
JB
2996 * nsfns.m (x_set_foreground_color, x_set_background_color):
2997 Use EmacsCGFloat.
2998 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2999 remove unused variables.
3000 (Fns_read_file_name): Keep track if panel is for save.
3001 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3002 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3003 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3004 Just return the input if GNUStep.
c0342369
JD
3005 (x_screen_planes): Remove.
3006 (Fxw_color_values): Use EmacsCGFloat
3007 (Fns_display_monitor_attributes_list): Only get screen number for
3008 Cocoa.
ef099a94 3009 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3010 EmacsSavePanel.
3011 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3012 ns_directory_from_panel.
3013
da9aff11
PE
30142013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3015
3016 * process.c (handle_child_signal): Also use WCONTINUED.
3017 This is so that list-processes doesn't mistakenly list the process
3018 as stopped, when the process has actually been continued and is
3019 now running.
3020
0e64479a
PE
30212013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3022
fc186a96
PE
3023 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3024 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3025 not already configured.
3026
0e64479a
PE
3027 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3028
38b787fa
EZ
30292013-05-29 Eli Zaretskii <eliz@gnu.org>
3030
3031 * Makefile.in (mostlyclean): Remove *.res files.
3032
22513e52
SM
30332013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3034
3035 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3036 a buffer (bug#8447).
3037
6ef3db10
EZ
30382013-05-27 Eli Zaretskii <eliz@gnu.org>
3039
3040 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3041 display vector, and we backtrack, handle the case that the
3042 previous character position is also displayed from a display
3043 vector or covered by a display string or image. (Bug#14476)
3044
6799bb26
JD
30452013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3046
3047 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3048 (struct MonitorInfo, free_monitors): Remove.
3049 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3050 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3051 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3052 Qframes, Qsource.
3053
3054 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3055 (struct MonitorInfo, free_monitors): Remove.
3056 (ns_screen_name): Make static.
3057 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3058 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3059 Qframes, Qsource.
3060
3061 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3062 (struct MonitorInfo): New struct.
3063 (free_monitors, make_monitor_attribute_list): Declare.
3064
22513e52
SM
3065 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3066 New Lisp_Object:s.
6799bb26
JD
3067 (free_monitors, make_monitor_attribute_list): New functions.
3068 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3069 Qsource.
3070
38cd43eb
XF
30712013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3072
3073 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3074
2af0948d
SM
30752013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3076
a7eb9b0f
SM
3077 * keyboard.c: Apply keyboard decoding only to events that come directly
3078 from the tty, not from unread-command-events (bug#14368).
3079 (read_event_from_main_queue): New function, extracted from read_char).
3080 (read_decoded_char): Remove.
3081 (read_decoded_event_from_main_queue): New function to replace it.
3082 (read_char): Use it.
3083 (read_key_sequence): Use read_char rather than read_decoded_char.
3084
2af0948d
SM
3085 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3086
1413e9a5
BR
30872013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3088
3089 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3090
e6d2f155
KH
30912013-05-22 Kenichi Handa <handa@gnu.org>
3092
3093 The following changes are to fix the setting of
3094 buffer-file-coding-system on, for instance, C-x RET c unix RET
3095 _FILE_OF_DOS_EOL_TYPE_ RET.
3096
3097 * coding.h (struct coding_system): New member detected_utf8_chars.
3098
3099 * coding.c (detect_coding_utf_8): Count characters and check EOL
3100 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3101 BOM is there.
3102 (setup_coding_system): Do not initialize coding->head_ascii.
3103 (check_ascii): Do not set coding->eol_seen but update it. Do not
3104 call adjust_coding_eol_type here.
1413e9a5
BR
3105 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3106 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3107 of the found coding-system.
3108 (decode_coding_gap): Cancel previous change. Utilize the
3109 character numbers counted by detect_coding_utf_8. Fix detection
3110 of BOM for utf-8.
3111
ab56a6f4 31122013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3113
3114 * search.c (looking_at_1): Only set last_thing_searched if the match
3115 changed the match-data (bug#14281).
3116
ecc3c6ed
DA
31172013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3118
3119 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3120 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3121 (move_it_vertically_backward): Likewise.
3122
5ba8bf35
YM
31232013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3124
3125 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3126 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3127 (Fx_display_mm_width, Fx_display_mm_height):
3128 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3129
91e8418b 3130 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3131 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3132 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3133 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3134 (Fx_display_backing_store, Fx_display_visual_class)
3135 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3136 (Fx_display_grayscale_p, Fx_display_pixel_width)
3137 (Fx_display_pixel_height, Fx_display_planes)
3138 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3139 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3140 (Fx_display_mm_width, Fx_display_mm_height)
3141 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3142 height for all physical monitors as in X11.
3143
fc30d803
SM
3144 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3145 Return pixel width or height for all physical monitors as in X11.
91e8418b 3146
31ff141c
PE
31472013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 Port --enable-gcc-warnings to clang.
3150 * bytecode.c (exec_byte_code):
3151 * regex.c:
3152 Redo diagnostic pragmas to pacify clang, too.
3153 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3154 * editfns.c (Fencode_time):
3155 * fileio.c (file_accessible_directory_p):
3156 * font.c (font_unparse_xlfd):
3157 Use '&"string"[index]' instead of '"string" + (index)'.
3158 * undo.c (user_error): Remove; unused.
3159
df065a0b
EZ
31602013-05-16 Eli Zaretskii <eliz@gnu.org>
3161
04d360e7
EZ
3162 * insdel.c (insert_1_both): Document the arguments, instead of
3163 referring to insert_1, which no longer exists.
3164
5bb98290
EZ
3165 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3166 some window, increment windows_or_buffers_changed, so that
3167 *Messages* display in that window is updated. (Bug#14408)
3168
df065a0b
EZ
3169 * w32.c: Include epaths.h.
3170 (init_environment): Use cmdproxy.exe without leading directories.
3171 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3172 case.
3173 (gettimeofday): Adjust signature and return value to Posix
3174 expectations.
3175
3176 * unexw32.c (open_output_file): Delete the existing emacs.exe
3177 before creating it, to break the hard link to the versioned
3178 executable.
3179
3180 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3181 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3182 (FIRSTFILE_OBJ): New variables.
3183 (W32_RES): Rename to EMACSRES. All users changed.
3184 (base_obj): Use $(CM_OBJ).
3185 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3186 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3187 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3188 $(W32_RES_LINK) before $(LIBES).
3189 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3190
1aa8d505
SM
31912013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3192
6e911150
SM
3193 * makefile.w32-in (DOC): Use just "DOC".
3194
3195 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3196
1aa8d505
SM
3197 * process.c: Export default filters and sentinels to Elisp.
3198 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3199 New constants.
3200 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3201 (Fset_process_sentinel, Fformat_network_address):
3202 Default to them instead of nil.
3203 (server_accept_connection): Sentinels can't be nil any more.
3204 (read_and_dispose_of_process_output): New function, extracted from
3205 read_process_output.
3206 (read_process_output): Use it; filters can't be nil.
3207 (Finternal_default_process_filter): New function, extracted from
3208 read_process_output.
3209 (exec_sentinel_unwind): Remove function.
3210 (exec_sentinel): Don't zilch sentinel while running.
3211 (status_notify): Sentinels can't be nil.
3212 (Finternal_default_process_sentinel): New function extracted from
3213 status_notify.
3214 (setup_process_coding_systems): Default filter is not nil any more.
3215 (syms_of_process): Export new Elisp functions and initialize
3216 new constants.
3217 * lisp.h (make_lisp_proc): New function.
3218
5ac2eb34
SM
32192013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3220
3221 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3222
eda9c7d7
EZ
32232013-05-14 Eli Zaretskii <eliz@gnu.org>
3224
3225 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3226 unless we know that the window w is a leaf window.
3227 Another attempt at solving bug#14062.
eda9c7d7 3228
8fdeaad5
JD
32292013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3230
3231 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3232 fdesc (Bug#14375).
3233
44aa9ee6
PE
32342013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3235
3236 * image.c (gif_load): Check that subimages fit (Bug#14345).
3237
759fd763
SM
32382013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3239
3240 * lread.c (skip_dyn_eof): New function.
3241 (read1): Use it to skip the end of a file in response to #@00.
3242
3243 * doc.c (get_doc_string): Slightly relax the sanity checking.
3244
4465bfb4
JD
32452013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3246
3247 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3248 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3249 (MonitorInfo): New struct.
3250 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3251 (Fns_display_monitor_attributes_list): New functions.
3252 (display-usable-bounds): Remove.
3253 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3254 Qsource.
3255
7583e2a0
PE
32562013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3259 (GTK_CHECK_VERSION): New macro, if not already defined.
3260 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3261 replaced by GTK_CHECK_VERSION.
3262
ad75d77e
PE
32632013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 * xterm.h (GTK_PREREQ): New macro.
3266 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3267 to use this macro instead, for consistency and clarity.
3268
07525f77
EZ
32692013-05-08 Eli Zaretskii <eliz@gnu.org>
3270
3271 * xdisp.c (row_for_charpos_p): New function, with code of
3272 cursor_row_p, but accepts an additional argument CHARPOS instead
3273 of using a hardcoded PT.
3274 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3275 (row_containing_pos): Call row_for_charpos_p instead of partially
3276 doing the same. Fixes cursor positioning under longlines-mode
3277 when longlines-show-effect includes more than one newline, when
3278 moving the cursor vertically up.
3279
d901fc8d
JB
32802013-05-08 Juanma Barranquero <lekktu@gmail.com>
3281
3282 * makefile.w32-in (ACL_H): New macro.
3283 ($(BLD)/fileio.$(O)): Update dependencies.
3284
f269bc61
PE
32852013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3286
e7b41c4c 3287 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3288 * Makefile.in (LIB_ACL): New macro.
3289 (LIBACL_LIBS): Remove.
3290 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3291 * fileio.c: Include <acl.h>.
3292 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3293 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3294 !acl_errno_valid.
3295 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3296 it ourselves.
3297
f269bc61
PE
3298 * unexelf.c: Don't assume ElfW (Half) fits in int.
3299 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3300 when dealing with ElfW (Half) values, since they can exceed 2**31
3301 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3302 (entry_address): Omit unused NUM arg. All uses changed.
3303
a261c53e
JL
33042013-05-07 Juri Linkov <juri@jurta.org>
3305
3306 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3307 to the string converted from number with `Fnumber_to_string'.
3308 (Bug#14254)
3309
2b66427d
PE
33102013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3313 This fixes a problem introduced by my previous change.
3314
15acfe41
GM
33152013-05-07 Glenn Morris <rgm@gnu.org>
3316
3317 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3318
5ea03bf5
JD
33192013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3320
3321 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3322
e0c9d565
PE
33232013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 Static checking by GCC 4.8.0.
3326 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3327 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3328 (x_get_monitor_attributes_fallback)
3329 (x_get_monitor_attributes_xinerama)
3330 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3331 Define only if USE_GTK.
3332 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3333 (x_get_monitor_attributes_fallback): Omit unused locals.
3334 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3335 Use double, not float, to avoid mixed-mode floating point arithmetic.
3336
4e3f9230
YM
33372013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3338 Jan Djärv <jan.h.d@swipnet.se>
3339
3340 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3341 (XINERAMA_CFLAGS): New macros.
3342 (ALL_CFLAGS, LIBES): Use them.
3343
3344 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3345 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3346 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3347 (syms_of_xfns): DEFSYM them.
3348 (struct MonitorInfo): New struct.
3349 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3350 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3351 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3352 (x_get_monitor_attributes_xinerama): New functions.
3353 (Fx_display_monitor_attributes_list): New primitive.
3354 (syms_of_xfns): Defsubr it.
3355
3356 * xterm.h (x_display_info): Add Xatom_net_workarea and
3357 Xatom_net_current_desktop.
3358
3359 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3360 and dpyinfo->Xatom_net_current_desktop.
3361
05839b6a
EZ
33622013-05-06 Eli Zaretskii <eliz@gnu.org>
3363
3364 * xdisp.c (pos_visible_p): Use the special code for finding the
3365 beginning of a display property or overlay for any "replacing"
3366 display property, not just for display strings. This solves
3367 incorrect reporting of position by posn-at-point. (Bug#14241)
3368
dc4a2ee0
PE
33692013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3370
5ee94506
PE
3371 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3372 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3373 Verify that ElfW (Half) fits in int.
3374 (fatal): Use same signature as lisp.h.
3375 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3376 configure and build with -DUNEXELF_DEBUG without worrying about
3377 other modules that use DEBUG.
3378 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3379 possibly-wide integers now uses it instead of plain fprintf.
3380 (entry_address): New function, which avoids problems with 32-bit
3381 overflow on 64-bit hosts.
3382 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3383 (round_up): Don't assume the remainder fits in int.
3384 (find_section): Use bool for boolean. Simplify debug code.
3385 (unexec): Don't assume file sizes fit in int or size_t.
3386 Omit unnecessary trailing newline in 'fatal' format.
3387 Use strerror rather than outputting decimal error number.
3388 Remove unused code when emacs is not defined;
3389 this file relies on Emacs now.
3390 Don't assume e_phnum and e_shnum are positive.
3391
dc4a2ee0
PE
3392 * regex.c: Fix problems when DEBUG is defined.
3393 (extract_number, extract_number_and_incr): Define regardless of
3394 whether DEBUG is defined; that's simpler and makes the code less
3395 likely to go stale in the normal case when DEBUG is not defined.
3396 Return int rather than taking an int * arg. All callers changed.
3397 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3398 Remove, replacing with ...
3399 (DEBUG_PRINT): New macro. All callers changed.
3400 (DEBUG_COMPILES_ARGUMENTS): New macro.
3401 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3402 (print_compiled_pattern, print_double_string) [DEBUG]:
3403 Use prototype rather than old-style definition.
3404 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3405 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3406 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3407 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3408 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3409 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3410 This matters only when DEBUG is defined.
3411
14c7ed05
EZ
34122013-05-05 Eli Zaretskii <eliz@gnu.org>
3413
3414 * xdisp.c (set_iterator_to_next): Set the
3415 ignore_overlay_strings_at_pos_p flag only if we are _really_
3416 iterating over an overlay string, as indicated by the
3417 current.overlay_string_index member. (Bug#14306)
3418
e6076b1b
JD
34192013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3420
3421 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3422 to where it is used, to avoid autorelease issues (Bug#14050).
3423
cbee2131
PE
34242013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3427 * fileio.c (syms_of_fileio): Implement this.
3428 * filelock.c (create_lock_file): If symbolic links don't work, so
3429 we use a regular file as a lock file, do not fsync the lock file;
3430 it's not needed.
3431
30c7e542
SM
34322013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3433
3434 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3435 (syms_of_minibuf): Adjust accodingly.
3436 * lread.c (Fread):
3437 * callint.c (Fcall_interactively): Adjust calls accordingly.
3438
5bebd186
EZ
34392013-05-04 Eli Zaretskii <eliz@gnu.org>
3440
3441 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3442 w->contents is a buffer before computing everything else.
3443 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3444
3445 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3446 assertion violations. (Bug#14062)
3447
0fb0a4f3
DR
34482013-05-01 David Reitter <david.reitter@gmail.com>
3449
3450 * nsfns.m (ns_tooltip): Initialize.
3451
9e63b4a5
EZ
34522013-04-28 Eli Zaretskii <eliz@gnu.org>
3453
3454 * coding.c (decode_coding_gap): Don't remove the character before
3455 a newline unless it's a CR character. (Bug#14287)
3456
ad60824e
DN
34572013-04-28 Dan Nicolaescu <dann@gnu.org>
3458
3459 * dispextern.h (struct face): Move enum face_underline_type
3460 earlier so that bitfields can be in the same word.
3461
edbdcec0
JD
34622013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3463
3464 * nsfns.m (handlePanelKeys): New function.
3465 (EmacsOpenPanel:performKeyEquivalent:)
3466 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3467 arrows/function/control and copy/paste keys (Bug#14296).
3468
0208ede7
JL
34692013-04-27 Juri Linkov <juri@jurta.org>
3470
3471 * callint.c (Fcall_interactively): Call `Qread_number' for
3472 interactive code letter `n' instead of using duplicate code.
3473 (Bug#14254)
3474
b8dd59f7
PE
34752013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3476
3477 * systime.h (make_timeval): Declare as 'const'.
3478
8bd722db
KH
34792013-04-27 Kenichi Handa <handa@gnu.org>
3480
3481 * font.c (font_open_entity): Always open a font of manageable
3482 size.
3483
13d0e56f 34842013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3485
f780d632
PE
3486 Port better to AIX (Bug#14258).
3487 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3488 to pacify AIX xlc.
3489
ec509856
KH
34902013-04-24 Kenichi Handa <handa@gnu.org>
3491
3492 * coding.c (decode_coding_iso_2022): When an invalid escape
3493 sequence is encountered, reset the invocation and designation
3494 status to the safest one.
3495
84fc48e5
PE
34962013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3497
3498 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3499 Without this fix, "make distclean" leaves stamp-h1 behind.
3500
806bda47
EC
35012013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3502
3503 * w32fns.c (w32_fullscreen_rect): New function to compute the
3504 window rectangle for the given fullscreen mode.
3505 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3506 longer tunes the window size. This keeps the window's edges flush
3507 with the screen and allows the taskbar to hide itself in fullboth.
3508
3509 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3510 window decorations and uses the entire screen.
3511
3512 * w32term.h (w32_fullscreen_rect) Add prototype.
3513 (struct w32_output): Replace normal_width, normal_height,
3514 normal_top, and normal_left members with a single normal_placement
3515 struct.
3516 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3517 Remove macros.
3518 (FRAME_NORMAL_PLACEMENT): New macro.
3519
9cc2810b
JB
35202013-04-16 Juanma Barranquero <lekktu@gmail.com>
3521
3522 * minibuf.c (Ftest_completion): Silence compiler warning.
3523
fd16b54c
EZ
35242013-04-15 Eli Zaretskii <eliz@gnu.org>
3525
3526 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3527 bug#14062.
fd16b54c
EZ
3528
3529 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3530 parentheses.
3531
3532 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3533 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3534 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3535 parentheses where appropriate.
3536
9e3379a0
PE
35372013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3540
ddd6b685
EZ
35412013-04-14 Eli Zaretskii <eliz@gnu.org>
3542
3543 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3544 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3545 Mention in the doc string that setting these variables takes
3546 effect only after a call to set-window-buffer. (Bug#14200)
3547
29b79ba1
EZ
35482013-04-13 Eli Zaretskii <eliz@gnu.org>
3549
3550 * indent.c (Fvertical_motion): Don't consider display strings on
3551 overlay strings as display strings on the buffer position we
3552 started from. This prevents vertical cursor motion from jumping
3553 more than one line when there's an overlay string with a display
3554 property at end of line.
3555 Reported by Karl Chen <Karl.Chen@quarl.org> in
3556 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3557
562c6ee9
SM
35582013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3559
3560 * window.c (select_window): `record_buffer' even if window is
3561 already selected (bug#14191).
3562
fcc1fe85
EZ
35632013-04-11 Eli Zaretskii <eliz@gnu.org>
3564
3565 * window.c (Fwindow_end): Test more flags, including the buffer's
3566 last_overlay_modified flag, to determine whether the window's
3567 display is really up-to-date. Prevents the function from
3568 returning a stale value. (Bug#14170)
3569 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3570 current matrix.
3571
f009190a
EZ
35722013-04-10 Eli Zaretskii <eliz@gnu.org>
3573
3574 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3575 garbaged only if it is not already the top frame on its TTY.
3576 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3577 there are GUI frames open in the same session. (Bug#13864)
3578
78ce603d
SM
35792013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3580
3581 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3582 of marking the idle timers directly.
3583
a8036e40
SM
35842013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3585
3586 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3587 tables (bug#14054).
3588
7ffe7ef6
SM
35892013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * window.c (select_window): Don't record_buffer while the invariant is
3592 temporarily broken (bug#14161).
3593
3594 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3595
7d9f6883
EZ
35962013-04-07 Eli Zaretskii <eliz@gnu.org>
3597
3598 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3599
5406cfd9
RF
36002013-04-07 Romain Francoise <romain@orebokech.com>
3601
3602 Ignore additional platform-specific ACL errors (Bug#13702).
3603 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3604 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3605
95c0e83b
JD
36062013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3607
3608 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3609 f->output_data.ns.
3610
876da980
PE
36112013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3612
3613 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3614 This bug was introduced by my 2013-02-25 change that simplified
3615 data_start configuration. Without this change, on GNU/Linux
3616 an Emacs configured with --enable-profiling fails immediately
3617 due to a profiler signal.
3618 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3619 with these flags. On platforms where special flags are needed
3620 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3621 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3622 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3623
7452b7bd
DA
36242013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3625
3626 Get rid of some platform-specific functions examining window
3627 system and its capabilities. This is a partial rework of the
3628 2013-04-05 change.
3629 * lisp.h (have_menus_p): Remove prototype. This function is
3630 replaced with platform-independent window_system_available.
3631 (check_window_system): Move to...
3632 * frame.h (decode_window_system_frame, window_system_available):
3633 ...here, add new prototypes.
3634 * frame.c (window_system_available, decode_window_system_frame):
3635 New functions.
3636 (check_window_system): Platform-independent now.
3637 * xterm.h (x_in_use): Remove declaration.
3638 (check_x_frame):
3639 * w32term.h (check_x_frame):
3640 * nsterm.h (check_x_frame): Remove prototypes. This function
3641 is replaced with platform-independent decode_window_system_frame.
3642 * msdos.c (have_menus_p): Remove.
3643 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3644 Remove platform-specific functions. Use check_window_system,
3645 decode_window_system_frame and check_ns_display_info where
3646 appropriate. Minor style and comment tweaks.
3647 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3648 (check_x_frame): Likewise.
3649 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3650 Likewise.
3651 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3652 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3653 * xmenu.c, xselect.c: All related users changed.
3654
251e9147
KH
36552013-04-03 Kenichi Handa <handa@gnu.org>
3656
3657 The following changes is to optimize the code for reading UTF-8
3658 files.
3659
562c6ee9 3660 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3661 changed. Check EOL format. Do not call adjust_coding_eol_type
3662 here.
3663 (check_utf_8): New function.
3664 (adjust_coding_eol_type): Do nothing if already adjusted.
3665 (detect_coding): Compare the return value of check_ascii with
3666 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3667 (decode_coding_gap): Optimize for valid UTF-8.
3668
8bc369d4
KH
36692013-03-21 Kenichi Handa <handa@gnu.org>
3670
3671 * coding.c (syms_of_coding): Cancel previous change.
3672
3673 * insdel.c (insert_from_gap): Fix previous change.
3674
73931ad1
DA
36752013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3676
3677 Consistently use platform-specific function to detect window system.
3678 * lisp.h (check_window_system): New prototype. This function is
3679 going to replace check_x, check_w32 and check_ns.
3680 (have_menus_p): Mention msdos.c in comment.
3681 * fontset.c (check_window_system_func): Remove. Adjust all users.
3682 * fontset.h (check_window_system_func): Remove prototype.
3683 * nsterm.h (check_ns):
3684 * xterm.h (check_x):
3685 * w32term.h (check_w32): Likewise.
3686 * menu.c (Fx_popup_menu): Use check_window_system.
3687 * msdos.c (check_window_system): Define for MS-DOS.
3688 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3689 * w32fns.c (check_window_system): Likewise for MS-Windows.
3690 * xfns.c (check_window_system): Likewise for X.
3691 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3692 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3693
7216e43b
PE
36942013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 Prefer < to > in range checks such as 0 <= i && i < N.
3697 This makes it easier to visualize quantities on a number line.
3698 This patch doesn't apply to all such range checks,
3699 only to the range checks affected by the 2013-03-24 change.
3700 This patch reverts most of the 2013-03-24 change.
3701 * alloc.c (xpalloc, Fgarbage_collect):
3702 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3703 * character.c (string_escape_byte8):
3704 * charset.c (read_hex):
3705 * data.c (cons_to_unsigned):
3706 * dispnew.c (update_frame_1):
3707 * doc.c (Fsubstitute_command_keys):
3708 * doprnt.c (doprnt):
3709 * editfns.c (hi_time, decode_time_components):
3710 * fileio.c (file_offset):
3711 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3712 * font.c (font_intern_prop):
3713 * frame.c (x_set_alpha):
3714 * gtkutil.c (get_utf8_string):
3715 * indent.c (check_display_width):
3716 * keymap.c (Fkey_description):
3717 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3718 * lread.c (read1):
3719 * minibuf.c (read_minibuf_noninteractive):
3720 * process.c (wait_reading_process_output):
3721 * search.c (Freplace_match):
3722 * window.c (get_phys_cursor_glyph):
3723 * xdisp.c (redisplay_internal):
3724 * xsmfns.c (smc_save_yourself_CB):
3725 Prefer < to > for range checks.
3726 * dispnew.c (sit_for): Don't mishandle NaNs.
3727 This fixes a bug introduced in the 2013-03-24 change.
3728 * editfns.c (decode_time_components): Don't hoist comparison.
3729 This fixes another bug introduced in the 2013-03-24 change.
3730
92759988
DA
37312013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3732
3733 * frame.h (struct frame): Drop scroll_bottom_vpos
3734 member becaue all real users are dead long ago.
3735 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3736 * xdisp.c (redisplay_internal): Adjust user.
3737
9a1971bb
GM
37382013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3739
f38ab167
JD
3740 * nsmenu.m (showAtX:Y:for:): setLevel to
3741 NSPopUpMenuWindowLevel (Bug#13998).
3742
6d01f1fe
JD
37432013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3744
3745 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3746 (ns_check_pending_open_menu): Declare.
3747
3748 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3749 (x_activate_menubar): Update the menu with title that matches
3750 ns_get_pending_menu_title, and call
3751 ns_check_pending_openmenu (Bug#12698).
3752 (menuWillOpen:): New method.
3753 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3754
3755 * nsterm.m (menu_will_open_state, menu_mouse_point)
3756 (menu_pending_title): New varaibles.
3757 (ns_get_pending_menu_title, ns_check_menu_open)
3758 (ns_check_pending_open_menu): New functions.
3759
781f4782
DA
37602013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3761
3762 * indent.c (current_column_bol_cache): Remove leftover which is not
3763 used in Fmove_to_column any more.
3764 (current_column, scan_for_column): Adjust users.
3765 * keyboard.c (last_point_position_buffer, last_point_position_window):
3766 Remove leftovers which are not used for recording undo any more.
3767 (command_loop_1, syms_of_keyboard): Adjust users.
3768 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3769 redisplay_window any more.
3770 (move_it_to): Adjust user.
3771
1921c31b
JB
37722013-03-29 Juanma Barranquero <lekktu@gmail.com>
3773
3774 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3775 Update dependencies.
3776
717b8bcd
SM
37772013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3778
3779 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3780 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3781 forward references.
3782
e74aeda8
DA
37832013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3784
3785 * window.h (struct window): Replace hchild, vchild and buffer slots
3786 with the only contents slot. This is possible because each valid
3787 window may have either the child window (in vertical or horizontal
3788 combination) or buffer to display (for the leaf window). Using that,
3789 a lof of operations to traverse and/or change window hierarchies may
3790 be simplified. New member horizontal is used to distinguish between
3791 horizontal and vertical combinations of internal windows.
3792 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3793 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3794 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3795 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3796 Use contents slot, not buffer, where appropriate.
3797 (wset_combination): New function.
3798 (wset_buffer): Add eassert.
3799 (Fframe_first_window): Simplify the loop reaching first window.
3800 (Fwindow_buffer): Use WINDOW_LEAF_P.
3801 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3802 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3803 (unshow_buffer): Convert initial debugging check to eassert.
3804 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3805 (make_parent_window, window_resize_check, window_resize_apply)
3806 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3807 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3808 Adjust to match struct window changes.
3809 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3810 (mark_window_cursors_off, count_windows, get_leaf_windows)
3811 (foreach_window_1): Simplify the loop.
3812 * alloc.c (mark_object): Do not check for the leaf window because
3813 internal windows has no glyph matrices anyway.
3814 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3815 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3816 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3817 (build_frame_matrix_from_window_tree, mirror_make_current)
3818 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3819 (update_window_tree, set_window_update_flags): Simplify the loop.
3820 (sync_window_with_frame_matrix_rows): Enforce live window.
3821 Use contents slot, not buffer, where appropriate.
3822 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3823 and WINDOW_HORIZONTAL_COMBINATION_P.
3824 (make_frame_visible_1): Simplify the loop.
3825 Use contents slot, not buffer, where appropriate.
3826 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3827 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3828 (expose_window_tree): Likewise.
3829 Use contents slot, not buffer, where appropriate.
3830 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3831 to avoid deleted windows. Use contents slot instead of buffer.
3832 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3833 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3834 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3835 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3836
121ab1cd
EZ
38372013-03-28 Eli Zaretskii <eliz@gnu.org>
3838
ef454cf7
EZ
3839 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3840 identify the reasons for assertion violations in bug#14062 and
3841 similar ones.
21e930f8
EZ
3842 (Fx_show_tip): Fix compilation error under
3843 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3844
121ab1cd
EZ
3845 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3846 Reported by <rzl24ozi@gmail.com>.
3847
5c89ca24
DA
38482013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3849
3850 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3851 start marker...
562c6ee9
SM
3852 (unwind_with_echo_area_buffer): ...to restore it here.
3853 This is needed to ensure that...
5c89ca24
DA
3854 (redisplay_window): ...both window markers are valid here,
3855 which is verified by eassert.
3856 * editfns.c (save_excursion_save): Do not assume that
3857 selected_window always displays the buffer.
c7f53895
DA
3858 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3859 Fix comment.
5c89ca24 3860
f557c1b1
SM
38612013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3862
3863 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3864 the upcase table.
3865
40693bba 38662013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3867
3868 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3869
c86f791f
EZ
38702013-03-27 Eli Zaretskii <eliz@gnu.org>
3871
3872 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3873 since MinGW's w32api headers do. This avoids compiler warnings.
3874
3875 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3876 if already defined.
3877
c6e72e17
EZ
38782013-03-26 Eli Zaretskii <eliz@gnu.org>
3879
3880 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3881
54e95010
JD
38822013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3883
3884 * gtkutil.c (style_changed_cb): Check if frame is live and an
3885 X frame (Bug#14038).
3886
b88b62de
EZ
38872013-03-26 Eli Zaretskii <eliz@gnu.org>
3888
a18d7de6
EZ
3889 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3890 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3891 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3892 MinGW64.
8f5e14c8
EZ
3893 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3894 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3895
b88b62de
EZ
3896 Fix incompatibilities between MinGW.org and MinGW64 headers.
3897 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3898
3899 * w32.c (REPARSE_DATA_BUFFER): Guard with
3900 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3901
c074e458
JD
39022013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3903
3904 * xterm.c: Include X11/XKBlib.h
3905 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3906
908589fd
AS
39072013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3908
3909 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3910 written backwards.
3911 * blockinput.h (input_blocked_p): Likewise.
3912 * bytecode.c (exec_byte_code): Likewise.
3913 * callproc.c (call_process_kill, call_process_cleanup)
3914 (Fcall_process): Likewise.
3915 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3916 (Fccl_execute_on_string): Likewise.
3917 * character.c (string_escape_byte8): Likewise.
3918 * charset.c (read_hex): Likewise.
3919 * cm.c (calccost): Likewise.
3920 * data.c (cons_to_unsigned): Likewise.
3921 * dired.c (directory_files_internal, file_name_completion):
3922 Likewise.
3923 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3924 (sit_for): Likewise.
3925 * doc.c (Fsubstitute_command_keys): Likewise.
3926 * doprnt.c (doprnt): Likewise.
3927 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3928 * emacsgtkfixed.c: Likewise.
3929 * fileio.c (file_offset, Fwrite_region): Likewise.
3930 * floatfns.c (Fexpt, fmod_float): Likewise.
3931 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3932 Likewise.
3933 * font.c (font_intern_prop): Likewise.
3934 * frame.c (x_set_alpha): Likewise.
3935 * gtkutil.c (get_utf8_string): Likewise.
3936 * indent.c (check_display_width): Likewise.
3937 * intervals.c (create_root_interval, rotate_right, rotate_left)
3938 (split_interval_right, split_interval_left)
3939 (adjust_intervals_for_insertion, delete_node)
3940 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3941 (merge_interval_right, merge_interval_left, copy_intervals)
3942 (set_intervals_multibyte_1): Likewise.
3943 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3944 * keymap.c (Fkey_description): Likewise.
3945 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3946 * lread.c (openp, read_integer, read1, string_to_number):
3947 Likewise.
3948 * menu.c (ensure_menu_items): Likewise.
3949 * minibuf.c (read_minibuf_noninteractive): Likewise.
3950 * print.c (printchar, strout): Likewise.
3951 * process.c (create_process, Faccept_process_output)
3952 (wait_reading_process_output, read_process_output, send_process)
3953 (wait_reading_process_output): Likewise.
3954 * profiler.c (make_log, handle_profiler_signal): Likewise.
3955 * regex.c (re_exec): Likewise.
3956 * regex.h: Likewise.
3957 * search.c (looking_at_1, Freplace_match): Likewise.
3958 * sysdep.c (get_child_status, procfs_ttyname)
3959 (procfs_get_total_memory): Likewise.
3960 * systime.h (EMACS_TIME_VALID_P): Likewise.
3961 * term.c (dissociate_if_controlling_tty): Likewise.
3962 * window.c (get_phys_cursor_glyph): Likewise.
3963 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3964 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3965 Likewise.
3966 * xfns.c (Fx_window_property): Likewise.
3967 * xmenu.c (set_frame_menubar): Likewise.
3968 * xselect.c (x_get_window_property, x_handle_dnd_message):
3969 Likewise.
3970 * xsmfns.c (smc_save_yourself_CB): Likewise.
3971 * xterm.c (x_scroll_bar_set_handle): Likewise.
3972
2bf7d27a
DA
39732013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3974
3975 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3976 to be optional or nil. Adjust comment and convert it to docstring.
3977 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3978 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3979
a9ebfa0b
PE
39802013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 Static checking by GCC 4.8-20130319.
3983 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3984 * process.c (Fset_process_datagram_address)
3985 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3986 * xdisp.c (get_char_face_and_encoding):
3987 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3988 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3989 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3990
4f3576ee
KB
39912013-03-24 Ken Brown <kbrown@cornell.edu>
3992
789b5e9a
KB
3993 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3994 fix compilation on 64-bit Cygwin, where underscores are not
3995 automatically prepended.
3996
4f3576ee
KB
3997 * w32term.c (w32_initialize): Silence compiler warning.
3998
b5b7745f
EZ
39992013-03-23 Eli Zaretskii <eliz@gnu.org>
4000
cdc0d0bd
EZ
4001 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4002 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4003 variables, to save and restore frame dimensions.
4004 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4005 after returning from a 'fullscreen' configuration.
4006 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4007 to avoid races between the main thread and the input thread.
4008
4009 * w32term.h (struct w32_output): New members normal_width,
4010 normal_height, normal_top, normal_left, and prev_fsmode.
4011 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4012 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4013 members of a frame.
4014
b5b7745f
EZ
4015 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4016 'fullscreen' parameter. Always record previous width and height
4017 of the frame, except when switching out of maximized modes, so
4018 that they could be restored correctly, instead of resetting to the
4019 default frame dimensions. Send SC_RESTORE command to the frame,
4020 unless we are going to send SC_MAXIMIZE, to restore the frame
4021 resize hints in the mouse pointer shown by the window manager.
4022 (Bug#14032)
4023
4024 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4025
4026 * lisp.h (get_frame_param): Adjust conditions for prototype
4027 declaration.
4028
a3454eed
KB
40292013-03-22 Ken Brown <kbrown@cornell.edu>
4030
4031 * unexcw.c: Drop unneeded inclusion of w32common.h.
4032 (report_sheap_usage): Declare.
4033 (read_exe_header): Add magic numbers for x86_64.
4034 (fixup_executable): Fix printf format specifier for unsigned long
4035 argument.
4036
5a49b79c
DA
40372013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4038
4039 * frame.h (struct frame): Put menu_bar_window under #ifdef
4040 because this member is not needed when X toolkit is in use.
4041 (fset_menu_bar_window):
4042 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4043 (free_glyphs, update_frame):
4044 * xdisp.c (expose_frame): Likewise.
4045 (display_menu_bar): Likewise. Remove redundant eassert.
4046 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4047 toolkit is in use.
4048
d6723bf7
PE
40492013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4050
7b1123d8
PE
4051 Use functions and constants to manipulate Lisp_Save_Value objects.
4052 This replaces code that used macros and strings and token-pasting.
4053 The change makes the C source a bit easier to follow,
4054 and shrinks the Emacs executable a bit.
4055 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4056 (make_save_value): Change 1st arg from string to enum. All callers
4057 changed.
4058 (INTX): Remove.
4059 (mark_object): Use if, not #if, for GC_MARK_STACK.
4060 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4061 (XSAVE_OBJECT): Now functions, not macros.
4062 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4063 the constant was never used.
4064 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4065 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4066 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4067 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4068 New constants.
4069 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4070 type3 with a single member save_type. All uses changed.
4071 (save_type, set_save_pointer, set_save_integer): New functions.
4072 * print.c (PRINTX): Remove.
4073
d6723bf7
PE
4074 * alloc.c: Remove redundant static declarations.
4075
5f24fa51
DA
40762013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4077
4078 * window.h (struct window): Convert left_col, top_line, total_lines
4079 and total_cols from Lisp_Objects to integers. Adjust comments.
4080 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4081 Remove.
4082 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4083 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4084 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4085 Adjust users where appropriate.
4086
42143acd
DA
40872013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4088
4089 * frame.h (struct frame): Drop resx and resy because the same data is
4090 available from window system-specific output context. Adjust users.
562c6ee9
SM
4091 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4092 New functions to provide defaults when no window system available.
42143acd 4093 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4094 (NUMVAL): Move from xdisp.c.
42143acd
DA
4095 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4096 (Ffont_face_attributes, Fopen_font):
4097 * image.c (gs_load):
4098 * w32font.c (fill_in_logfont):
4099 * xdisp.c (calc_pixel_width_or_height):
4100 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4101 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4102
c0a17406
KH
41032013-03-20 Kenichi Handa <handa@gnu.org>
4104
4105 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4106 to 1 (temporary workaround until a bug related to ASCII
4107 optimization is fixed).
4108
095d384d
DA
41092013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4110
4111 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4112 Signal error if window is not internal. Adjust docstring.
4113 (delete_all_child_windows): Use combination_limit to save the buffer.
4114 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4115 * print.c (syms_of_print): Initialize debugging output not here...
4116 (init_print_once): ...but in a new function here.
4117 * lisp.h (init_print_once): Add prototype.
4118 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4119
748fa866
DA
41202013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4121
4122 * window.c (window_resize_check, window_resize_apply)
4123 (window_from_coordinates, recombine_windows, set_window_buffer)
4124 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4125 (Fsplit_window_internal, Fdelete_window_internal)
4126 (freeze_window_starts): Use bool for booleans.
4127 * window.h (window_frame_coordinates, resize_frame_windows)
4128 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4129
81519fd2
SM
41302013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4131
4132 * dispnew.c (bitch_at_user): Use `user-error'.
4133
6db423a9
KB
41342013-03-17 Ken Brown <kbrown@cornell.edu>
4135
4136 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4137 as return type of image_background. (Bug#13981)
4138 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4139
8f2906f5
JD
41402013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4141
960ce480 4142 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4143 (ns_select): Don't return with result uninitialized.
960ce480 4144
8f2906f5
JD
4145 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4146 and getDirectory.
4147
81519fd2
SM
4148 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4149 New functions.
8f2906f5
JD
4150 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4151 directories. If filename is nil, get directory name (Bug#13932).
4152 Use getFilename and getDirectory.
4153 (getFilename, getDirectory): New methods for EmacsSavePanel and
4154 EmacsOpenPanel.
4155 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4156
cded56c1
PE
41572013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4160
251e9147 41612013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4162
4163 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4164 (adjust_after_replace): Make it back to static. Delete the third
4165 arg text_at_gap_tail. Cancel the code for handling it.
4166
4167 * coding.h (struct coding_system): New member eol_seen.
4168
4169 * coding.c (detect_ascii): New function.
4170 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4171 when the source bytes are actually scanned. On detecting for
4172 coding_category_utf_8_auto, call detect_ascii instead of scanning
4173 source bytes directly.
4174 (produce_chars): Call insert_from_gap with the new arg 0.
4175 (encode_coding): Likewise.
4176 (decode_coding_gap): Control ASCII optimization by the variable
4177 disable_ascii_optimization instead of #ifndef .. #endif.
4178 Deccode EOL format according to coding->eol_seen.
4179 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4180 variable.
4181
8a44e6d1
KH
4182 * lisp.h (adjust_after_replace): Cancel externing it.
4183 (insert_from_gap): Adjust prototype.
4184
5f795e34
EZ
41852013-03-15 Eli Zaretskii <eliz@gnu.org>
4186
4187 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4188 FULLSCREEN_MAXIMIZED. (Bug#13935)
4189
f258b4be
DA
41902013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4191
4192 * region-cache.c (find_cache_boundary, move_cache_gap)
4193 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4194 Simplify debugging check and convert to eassert. Adjust comment.
4195 (pp_cache): Put under ENABLE_CHECKING.
4196
a5cc4dde
EZ
41972013-03-14 Eli Zaretskii <eliz@gnu.org>
4198
4199 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4200 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4201 and WM_ACTIVATEAPP.
4202 (w32fullscreen_hook): If the frame is visible, reset
4203 f->want_fullscreen flag after changing the frame size. If the
4204 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4205 (Bug#13953)
4206
3fc5e44a
DC
42072013-03-13 Daniel Colascione <dancol@dancol.org>
4208
4209 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4210 too so that these builds can use Cygwin's file conversion
4211 functions. (We've been building and linking cygw32.o all along
4212 and just not using it.)
4213
47d7532e
PE
42142013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 File synchronization fixes (Bug#13944).
4217 * Makefile.in (LIB_FDATASYNC): New macro.
4218 (LIBES): Use it.
4219 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4220 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4221 Don't worry about HAVE_FSYNC, since a substitute fsync is
4222 available if the system lacks one.
4223 (Fwrite_regin): Retry fsync if interrupted.
4224
c7ffccaf
EZ
42252013-03-13 Eli Zaretskii <eliz@gnu.org>
4226
4e2df81d 4227 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4228 activated, call w32fullscreen_hook, to make sure the new frame
4229 dimensions are in effect. (Bug#13937)
4230
8a7debc1
DA
42312013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4232
4233 * xdisp.c (init_iterator): Simplify because both character and byte
4234 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4235 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4236 character and byte positions can be obtained from marker.
8a7debc1 4237
7fd8c501
PE
42382013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4239
d9df6f40
PE
4240 Static checking by Sun C 5.12.
4241 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4242 * bytecode.c (exec_byte_code):
4243 * dispnew.c (init_display):
4244 * eval.c (error):
4245 * fileio.c (Fsubstitute_in_file_name):
4246 * keyboard.c (Fevent_convert_list):
4247 * keymap.c (Fsingle_key_description):
4248 * term.c (maybe_fatal, fatal):
4249 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4250 * xsmfns.c (Fhandle_save_session):
4251 Omit unreachable code.
4252 * keymap.c (map_keymap_char_table_item): Cast void * to
4253 a function pointer type; the C Standard requires this.
4254
7fd8c501
PE
4255 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4256 Include <sys/param.h> unconditionally, as that works elsewhere and
4257 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4258 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4259 and FreeBSD now.
4260
a020afb9 4261See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4262
4263;; Local Variables:
4264;; coding: utf-8
aac0c6e3
MR
4265;; End:
4266
ab422c4d 4267 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4268
4269 This file is part of GNU Emacs.
4270
4271 GNU Emacs is free software: you can redistribute it and/or modify
4272 it under the terms of the GNU General Public License as published by
4273 the Free Software Foundation, either version 3 of the License, or
4274 (at your option) any later version.
4275
4276 GNU Emacs is distributed in the hope that it will be useful,
4277 but WITHOUT ANY WARRANTY; without even the implied warranty of
4278 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4279 GNU General Public License for more details.
4280
4281 You should have received a copy of the GNU General Public License
4282 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.