* lread.c (Fload): Avoid initialization only when lint checking.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b2a069c2
PE
12013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lread.c (Fload): Avoid initialization only when lint checking.
4 Mention that it's needed only for older GCCs.
5
99107004
KH
62013-07-20 Kenichi Handa <handa@gnu.org>
7
8 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
9 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
10
6b1b199d
AS
112013-07-20 Andreas Schwab <schwab@linux-m68k.org>
12
13 * lread.c (Fload): Avoid uninitialized warning.
14
4195afc3
PE
152013-07-19 Paul Eggert <eggert@cs.ucla.edu>
16
3f5bef16
PE
17 Fix some minor file descriptor leaks and related glitches.
18 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
19 (create_lock_file): Use write, not emacs_write.
20 * image.c (slurp_file, png_load_body):
21 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
22 (server_accept_connection):
23 Don't leak an fd on memory allocation failure.
24 * image.c (slurp_file): Add a cheap heuristic for growing files.
25 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
26 as that's what the other routines do. Maybe input need not be
27 blocked at all, but it's better to be consistent.
28 Avoid undefined behavior when strlen is zero.
29
4195afc3
PE
30 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
31 (NSTATICS): Now a constant; doesn't need to be a macro.
32
a1aeeffe
RS
332013-07-19 Richard Stallman <rms@gnu.org>
34
35 * coding.c (decode_coding_utf_8): Add simple loop for fast
36 processing of ASCII characters.
37
63b34baa
PE
382013-07-19 Paul Eggert <eggert@cs.ucla.edu>
39
40 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
41
621dd9ac
EZ
422013-07-19 Eli Zaretskii <eliz@gnu.org>
43
44 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
45 unportable 'struct x_display_info'.
46 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
47 is a portable type.
48
1396ac86
PE
492013-07-19 Paul Eggert <eggert@cs.ucla.edu>
50
ab9980cd
PE
51 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
52 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
53 or fscanf fails.
54 (system_process_attributes): Prefer plain char to unsigned char
55 when either will do. Clean up properly if interrupted or if
56 memory allocations fail. Don't assume sscanf succeeds. Remove
57 no-longer-needed workaround to stop GCC from whining. Read
58 command-line once, instead of multiple times. Check read status a
59 bit more carefully.
60
1396ac86
PE
61 Fix obscure porting bug with varargs functions.
62 The code assumed that int is treated like ptrdiff_t in a vararg
63 function, which is not a portable assumption. There was a similar
64 -- though these days less likely -- porting problem with various
65 assumptions that pointers of different types all smell the same as
66 far as vararg functions is conserved. To make this problem less
67 likely in the future, redo the API to use varargs functions.
68 * alloc.c (make_save_value): Remove this vararg function.
69 All uses changed to ...
70 (make_save_int_int_int, make_save_obj_obj_obj_obj)
71 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
72 New functions.
73 (make_save_ptr): Rename from make_save_pointer, for consistency with
74 the above. Define only on platforms that need it. All uses changed.
75
4d19d194
PE
762013-07-18 Paul Eggert <eggert@cs.ucla.edu>
77
78 * keyboard.c: Try to fix typos in previous change.
79 (DISPLAY_LIST_INFO): New macro.
80 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 81 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 82
945c5bb1
JB
832013-07-18 Juanma Barranquero <lekktu@gmail.com>
84
85 * keyboard.c (kbd_buffer_get_event):
86 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
87 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
88
f4b1eb36
PE
892013-07-18 Paul Eggert <eggert@cs.ucla.edu>
90
5e679a2c
PE
91 * filelock.c: Fix unlikely file descriptor leaks.
92 (get_boot_time_1): Rework to avoid using emacs_open.
93 This doesn't actually fix a leak, but is better anyway.
94 (read_lock_data): Use read, not emacs_read.
95
a8cd4836
PE
96 * doc.c: Fix minor memory and file descriptor leaks.
97 * doc.c (get_doc_string): Fix memory leak when doc file absent.
98 (get_doc_string, Fsnarf_documentation):
99 Fix file descriptor leak on error.
100
ef30e638
PE
101 * term.c: Fix minor fdopen-related file descriptor leaks.
102 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
103 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
104
f4b1eb36
PE
105 * charset.c: Fix file descriptor leaks and errno issues.
106 Include <errno.h>.
107 (load_charset_map_from_file): Don't leak file descriptor on error.
108 Use plain record_xmalloc since the allocation is larger than
109 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
110 of entries.
111 * eval.c (record_unwind_protect_nothing):
112 * fileio.c (fclose_unwind):
113 New functions.
114 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
115 The replacement doesn't block input, but that no longer seems
116 necessary.
117
b648c163
PE
1182013-07-17 Paul Eggert <eggert@cs.ucla.edu>
119
a0931322
PE
120 * lread.c: Fix file descriptor leaks and errno issues.
121 (Fload): Close some races that leaked fds or streams when 'load'
122 was interrupted.
123 (Fload, openp): Report error number of last nontrivial failure to open.
124 ENOENT counts as trivial.
125 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
126 New functions.
127 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
128 now that the function is always called with a nonnegative arg.
129 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
130 All uses replaced with ...
131 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
132
b648c163
PE
133 A few more minor file errno-reporting bugs.
134 * callproc.c (Fcall_process):
135 * doc.c (Fsnarf_documentation):
136 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
137 * process.c (set_socket_option):
138 Don't let a constructor trash errno.
139 * doc.c: Include <errno.h>.
140
b1dc4084
JB
1412013-07-16 Juanma Barranquero <lekktu@gmail.com>
142
143 * w32fns.c (unwind_create_tip_frame): Fix declaration.
144
c43843aa
PE
1452013-07-16 Paul Eggert <eggert@cs.ucla.edu>
146
50a30cce
PE
147 Fix w32 bug with call-process-region (Bug#14885).
148 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
149 to Fcall_process when the input is empty. This simplifies the
150 code a bit. It makes no difference on POSIXish platforms but
151 apparently it fixes a bug on w32.
152
153 Fix bug where insert-file-contents closes a file twice. (Bug#14839).
41d48a42
PE
154 * fileio.c (close_file_unwind): Don't close if FD is negative;
155 this can happen when unwinding a zapped file descriptor.
156 (Finsert_file_contents): Unwind-protect the fd before the point marker,
157 in case Emacs runs out of memory between the two unwind-protects.
158 Don't trash errno when closing FD.
159 Zap the FD in the specpdl when closing it, instead of deferring
160 the removal of the unwind-protect; this fixes a bug where a child
161 function unwinds the stack past us.
162
27e498e6
PE
163 New unwind-protect flavors to better type-check C callbacks.
164 This also lessens the need to write wrappers for callbacks,
165 and the need for make_save_pointer.
166 * alloca.c (free_save_value):
167 * atimer.c (run_all_atimers):
168 Now extern.
169 * alloc.c (safe_alloca_unwind):
170 * atimer.c (unwind_stop_other_atimers):
171 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
172 * menu.c (cleanup_popup_menu) [HAVE_NS]:
173 * minibuf.c (choose_minibuf_frame_1):
174 * process.c (make_serial_process_unwind):
175 * xdisp.h (pop_message_unwind):
176 * xselect.c (queue_selection_requests_unwind):
177 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
178 * alloca.c (record_xmalloc):
179 Prefer record_unwind_protect_ptr to record_unwind_protect with
180 make_save_pointer.
181 * alloca.c (Fgarbage_collect):
182 Prefer record_unwind_protect_void to passing a dummy.
183 * buffer.c (restore_buffer):
184 * window.c (restore_window_configuration):
185 * xfns.c, w32fns.c (do_unwind_create_frame)
186 New wrapper. All record-unwind uses of wrappee changed.
187 * buffer.c (set_buffer_if_live):
188 * callproc.c (call_process_cleanup, delete_temp_file):
189 * coding.c (code_conversion_restore):
190 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
191 * editfns.c (save_excursion_restore)
192 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
193 (save_restriction_restore):
194 * eval.c (restore_stack_limits, un_autoload):
195 * fns.c (require_unwind):
196 * keyboard.c (recursive_edit_unwind, tracking_off):
197 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
198 * macros.c (pop_kbd_macro, restore_menu_items):
199 * nsfns.m (unwind_create_frame):
200 * print.c (print_unwind):
201 * process.c (start_process_unwind):
202 * search.c (unwind_set_match_data):
203 * window.c (select_window_norecord, select_frame_norecord):
204 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
205 (fast_set_selected_frame):
206 * xfns.c, w32fns.c (unwind_create_tip_frame):
207 Return void, not a dummy Lisp_Object. All uses changed.
208 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
209 * callproc.c (call_process_kill):
210 * fileio.c (restore_point_unwind, decide_coding_unwind)
211 (build_annotations_unwind):
212 * insdel.c (Fcombine_after_change_execute_1):
213 * keyboard.c (read_char_help_form_unwind):
214 * menu.c (unuse_menu_items):
215 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
216 * sound.c (sound_cleanup):
217 * xdisp.c (unwind_redisplay):
218 * xfns.c (clean_up_dialog):
219 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
220 Accept no args and return void, instead of accepting and returning
221 a dummy Lisp_Object. All uses changed.
222 * cygw32.c (fchdir_unwind):
223 * fileio.c (close_file_unwind):
224 * keyboard.c (restore_kboard_configuration):
225 * lread.c (readevalllop_1):
226 * process.c (wait_reading_process_output_unwind):
227 Accept int and return void, rather than accepting an Emacs integer
228 and returning a dummy object. In some cases this fixes an
229 unlikely bug when the corresponding int is outside Emacs integer
230 range. All uses changed.
231 * dired.c (directory_files_internal_unwind):
232 * fileio.c (do_auto_save_unwind):
233 * gtkutil.c (pop_down_dialog):
234 * insdel.c (reset_var_on_error):
235 * lread.c (load_unwind):
236 * xfns.c (clean_up_file_dialog):
237 * xmenu.c, nsmenu.m (pop_down_menu):
238 * xmenu.c (cleanup_widget_value_tree):
239 * xselect.c (wait_for_property_change_unwind):
240 Accept pointer and return void, rather than accepting an Emacs
241 save value encapsulating the pointer and returning a dummy object.
242 All uses changed.
243 * editfns.c (Fformat): Update the saved pointer directly via
244 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
245 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
246 (unwind_body): New function.
247 (record_unwind_protect): First arg is now a function returning void,
248 not a dummy Lisp_Object.
249 (record_unwind_protect_ptr, record_unwind_protect_int)
250 (record_unwind_protect_void): New functions.
251 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
252 * fileio.c (struct auto_save_unwind): New type.
253 (do_auto_save_unwind): Use it.
254 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
255 * insdel.c (struct rvoe_arg): New type.
256 (reset_var_on_error): Use it.
257 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
258 New constants.
259 (specbinding_func): Remove; there are now several such functions.
260 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
261 (set_unwind_protect_ptr): New function.
262 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
263
4e604a5d
PE
264 Be simpler and more consistent about reporting I/O errors.
265 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
266 Say "Read error" and "Write error", rather than "I/O error", or
267 "IO error reading", or "IO error writing", when a read or write
268 error occurs.
269 * process.c (Fmake_network_process, wait_reading_process_output)
270 (send_process, Fprocess_send_eof, wait_reading_process_output):
271 Capitalize diagnostics consistently. Put "failed foo" at the
272 start of the diagnostic, so that we don't capitalize the
273 function name "foo". Consistently say "failed" for such
274 diagnostics.
275 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
276 All callers changed. This is so it can use report_file_error.
277 * sysdep.c (serial_open, serial_configure): Capitalize I/O
278 diagnostics consistently as above.
279
a9757f6a
PE
280 * fileio.c (report_file_errno): Fix errno reporting bug.
281 If the file name is neither null nor a pair, package it up as a
282 singleton list. All callers changed, both to this function and to
283 report_file_error. This fixes a bug where the memory allocator
284 invoked by list1 set errno so that the immediately following
285 report_file_error reported the wrong errno value.
286
c43843aa
PE
287 Fix minor problems found by --enable-gcc-warnings.
288 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
289 * keyboard.c (kbd_buffer_get_event): Remove unused local.
290
18c26d81
JD
2912013-07-16 Jan Djärv <jan.h.d@swipnet.se>
292
293 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
294 Set event->arg to Qt if switch-event shall be generated.
295 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
296
297 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
298
299 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
300 FOCUS_OUT_EVENT.
301
302 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
303 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
304 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
305 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
306 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
307 and there is a focused frame.
308 (head_table): Add focus-in and focus-out.
309 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
310 bind to handle-focus-in/out.
311
312 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
313 (Fhandle_switch_frame): Call Fhandle_focus_in.
314 (syms_of_frame): defsubr handle-focus-in/out.
315
6c6f1994
PE
3162013-07-16 Paul Eggert <eggert@cs.ucla.edu>
317
c7ddc792
PE
318 Fix porting bug to older POSIXish platforms (Bug#14862).
319 * sysdep.c (emacs_pipe): New function, that implements
320 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
321 This should port better to CentOS 5 and to Mac OS X 10.6.
322 All calls to pipe2 changed.
323
6c6f1994
PE
324 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
325 This makes the code easier to read and the executable a bit smaller.
326 Do not replace all calls to Fcons that happen to create lists,
327 just calls that are intended to create lists. For example, when
328 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
329 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
330 Similarly for list2 through list5.
331 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
332 * bytecode.c (exec_byte_code):
333 * callint.c (quotify_arg, Fcall_interactively):
334 * callproc.c (Fcall_process, create_temp_file):
335 * charset.c (load_charset_map_from_file)
336 (Fdefine_charset_internal, init_charset):
337 * coding.c (get_translation_table, detect_coding_system)
338 (Fcheck_coding_systems_region)
339 (Fset_terminal_coding_system_internal)
340 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
341 * composite.c (update_compositions, Ffind_composition_internal):
342 * dired.c (directory_files_internal, file_name_completion)
343 (Fsystem_users):
344 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
345 * doc.c (Fsnarf_documentation):
346 * editfns.c (Fmessage_box):
347 * emacs.c (main):
348 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
349 (Feval, eval_sub, Ffuncall, apply_lambda):
350 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
351 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
352 (Fset_file_times, Finsert_file_contents)
353 (Fchoose_write_coding_system, Fwrite_region):
354 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
355 * font.c (font_registry_charsets, font_parse_fcname)
356 (font_prepare_cache, font_update_drivers, Flist_fonts):
357 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
358 * frame.c (make_frame, Fmake_terminal_frame)
359 (x_set_frame_parameters, x_report_frame_params)
360 (x_default_parameter, Fx_parse_geometry):
361 * ftfont.c (syms_of_ftfont):
362 * image.c (gif_load):
363 * keyboard.c (command_loop_1):
364 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
365 (Fcopy_keymap, append_key, Fcurrent_active_maps)
366 (Fminor_mode_key_binding, accessible_keymaps_1)
367 (Faccessible_keymaps, Fwhere_is_internal):
368 * lread.c (read_emacs_mule_char):
369 * menu.c (find_and_return_menu_selection):
370 * minibuf.c (get_minibuffer):
371 * nsfns.m (Fns_perform_service):
372 * nsfont.m (ns_script_to_charset):
373 * nsmenu.m (ns_popup_dialog):
374 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
375 (Fx_own_selection_internal):
376 * nsterm.m (append2):
377 * print.c (Fredirect_debugging_output)
378 (print_prune_string_charset):
379 * process.c (Fdelete_process, Fprocess_contact)
380 (Fformat_network_address, set_socket_option)
381 (read_and_dispose_of_process_output, write_queue_push)
382 (send_process, exec_sentinel):
383 * sound.c (Fplay_sound_internal):
384 * textprop.c (validate_plist, add_properties)
385 (Fput_text_property, Fadd_face_text_property)
386 (copy_text_properties, text_property_list, syms_of_textprop):
387 * unexaix.c (report_error):
388 * unexcoff.c (report_error):
389 * unexsol.c (unexec):
390 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
391 (Fformat_mode_line, syms_of_xdisp):
392 * xfaces.c (set_font_frame_param)
393 (Finternal_lisp_face_attribute_values)
394 (Finternal_merge_in_global_face, syms_of_xfaces):
395 * xfns.c (x_default_scroll_bar_color_parameter)
396 (x_default_font_parameter, x_create_tip_frame):
397 * xfont.c (xfont_supported_scripts):
398 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
399 (menu_help_callback, xmenu_show):
400 * xml.c (make_dom):
401 * xterm.c (set_wm_state):
402 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
403 and similarly for list2 through list5.
404
bafe80ce
PE
4052013-07-15 Paul Eggert <eggert@cs.ucla.edu>
406
407 * callproc.c (Fcall_process_region): Fix minor race and tune.
408 (create_temp_file): New function, with the temp-file-creation part
409 of the old Fcall_process_region. Use Fcopy_sequence to create the
410 temp file name, rather than alloca + build_string, for simplicity.
411 Don't bother to block input around the temp file creation;
412 shouldn't be needed. Simplify use of mktemp. Use
413 record_unwind_protect immediately after creating the temp file;
414 this closes an unlikely race where the temp file was not removed.
415 Use memcpy rather than an open-coded loop.
416 (Fcall_process_region): Use the new function. If the input is
417 empty, redirect from /dev/null rather than from a newly created
418 empty temp file; this avoids unnecessary file system traffic.
419
4700b5a5
PE
4202013-07-14 Paul Eggert <eggert@cs.ucla.edu>
421
5c97beae
PE
422 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
423 Simplify by making this case like the other two. This is a bit
424 slower on obsolete hosts, but the extra complexity isn't worth it.
425
4700b5a5
PE
426 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
427 * process.c (create_process) [!DOS_NT]:
428 Remove now-unnecessary calls to emacs_close.
429
f9a74c4c
EZ
4302013-07-13 Eli Zaretskii <eliz@gnu.org>
431
922ae7ee
EZ
432 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
433 returning early. (Bug#14850)
434
f9a74c4c
EZ
435 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
436 and inhibit-iso-escape-detection attributes of 'undecided'.
437 (Bug#14822)
438
5e301d76
PE
4392013-07-13 Paul Eggert <eggert@cs.ucla.edu>
440
69e0e5ee
PE
441 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
442 Reported by Herbert J. Skuhra in
443 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
444
5e301d76
PE
445 Don't lose top specpdl entry when memory is exhausted.
446 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
447 specpdl overflow here, to simplify callers; all callers changed.
448 Always reserve an unused entry at the stack top; this avoids
449 losing the top entry's information when memory is exhausted.
450
7e649856
PE
4512013-07-12 Paul Eggert <eggert@cs.ucla.edu>
452
a773ed9a
PE
453 Clean up errno reporting and fix some errno-reporting bugs.
454 * callproc.c (Fcall_process):
455 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
456 * process.c (create_process, Fmake_network_process):
457 * unexaix.c (report_error):
458 * unexcoff.c (report_error):
459 Be more careful about reporting the errno of failed operations.
460 The code previously reported the wrong errno sometimes.
461 Also, prefer report_file_errno to setting errno + report_file_error.
462 (Fcall_process): Look at openp return value rather than at path,
463 as that's a bit faster and clearer when there's a numeric predicate.
464 * fileio.c (report_file_errno): New function, with most of the
465 old contents of report_file_error.
466 (report_file_error): Use it.
467 (Ffile_exists_p, Ffile_accessible_directory_p):
468 Set errno to 0 when it is junk.
469 * fileio.c (Faccess_file):
470 * image.c (x_create_bitmap_from_file):
471 Use faccessat rather than opening the file, to avoid the hassle of
472 having a file descriptor open.
473 * lisp.h (report_file_errno): New decl.
474 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
475
7e649856
PE
476 Minor EBADF fixes.
477 * process.c (create_process, wait_reading_process_output) [AIX]:
478 Remove obsolete SIGHUP-related code, as Emacs no longer disables
479 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
480 a multithreaded environment anyway).
481 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
482
f6774c1a
AS
4832013-07-12 Andreas Schwab <schwab@linux-m68k.org>
484
485 * image.c (x_find_image_file): Don't close a remote file handle.
486
bacba3c2
PE
4872013-07-12 Paul Eggert <eggert@cs.ucla.edu>
488
489 Fix races with threads and file descriptors.
490 * callproc.c (Fcall_process_region):
491 * dired.c (open_directory):
492 * emacs.c (main, Fdaemon_initialized):
493 * image.c (x_find_image_file):
494 * inotify.c (Finotify_rm_watch):
495 * lread.c (Flocate_file_internal):
496 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
497 * term.c (term_mouse_moveto, init_tty):
498 * termcap.c (tgetent):
499 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
500 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
501 * unexhp9k800.c, unexmacosx.c (unexec):
502 * callproc.c (Fcall_process_region):
503 Use emacs_close, not close.
504 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
505 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
506 and posix_close function on current platforms (which all lack them).
507 (emacs_close): Use it. This should fix the races on GNU/Linux and
508 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
509 and it should avoid closing random victim file descriptors on
510 other platforms.
511
653d4f43
PE
5122013-07-11 Paul Eggert <eggert@cs.ucla.edu>
513
c8536ec4
PE
514 * inotify.c (uninitialized): Remove. All uses replaced by -1.
515 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
516 Touch up doc a bit.
517
9c203066
PE
518 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
519 This is for .gdbinit xbacktrace.
520
653d4f43
PE
521 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
522 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
523 (emacs_set_tty): Now static.
524 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
525 * term.c (tty_capable_p, tty_default_color_capabilities)
526 (get_tty_terminal, term_mouse_movement)
527 (handle_one_term_event, init_tty, maybe_fatal):
528 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
529 (tgetent, scan_file, name_match, compare_contin):
530 * terminal.c (get_terminal):
531 Use bool for boolean.
532 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
533 Prefer char to unsigned char if either will do.
534 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
535 (tty_write_glyphs): Prefer int to unsigned.
536 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
537 All callers changed.
538 * termcap.c (tprint, main) [TEST]: Remove non-working test.
539
45b683a1
PE
5402013-07-10 Paul Eggert <eggert@cs.ucla.edu>
541
29abe551
PE
542 Port to C89.
543 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
544 (B__dummy__): New dummy symbol, to pacify C89.
545 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
546 they can't grok varargs macros.
547 * dispnew.c (add_window_display_history)
548 (add_frame_display_history):
549 * print.c (print_object):
550 * xdisp.c (debug_method_add):
551 Use %p printf format only for void pointers.
552 * emacs.c (usage_message): New constant, replacing ...
553 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
554 (main): Adjust to usage reorg.
555 * fns.c (syms_of_fns):
556 * profiler.c (syms_of_profiler):
557 Don't use non-constant struct initializers.
558 * gnutls.h (gnutls_initstage_t):
559 * lisp.h (enum Lisp_Fwd_Type):
560 * lread.c (lisp_file_lexically_bound_p):
561 * xsettings.c (anonymous enum):
562 Remove trailing comma.
563 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
564 * lisp.h (ENUM_BF): Use unsigned if pedantic.
565 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
566 (DEFUN): Use it.
567 * regex.c (const_re_char): New type, to pacify strict C89.
568 All uses of 'const re_char' replaced to use it.
569 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
570 with glibc when strict C89. This change is imported from gnulib.
571 All uses changed.
572 (_Restrict_arr_): Rename from __restrict_arr, similarly.
573 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
574 Omit GNU_LINUX implementation, since it requires long long.
575 * xterm.c (x_draw_underwave):
576 Do not assume the traditional order of struct's members.
577 (x_term_init): Rewrite to avoid the need for non-constant structure
578 initializers.
579
45b683a1
PE
580 Syntax cleanup, mostly replacing macros with functions.
581` This removes the need for the syntax_temp hack.
582 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
583 * syntax.c (SYNTAX_INLINE): New macro.
584 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
585 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
586 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
587 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
588 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
589 (SYNTAX_COMEND_FIRST): Now functions, not macros.
590 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
591 Now constants, not macros.
592 (syntax_temp) [!__GNUC__]: Remove.
593 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
594 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
595 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
596 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
597 Move here from syntax.h; now functions, not macros. Except for the
598 last function, these are static since only syntax.c uses them.
599 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
600 All uses changed. Now a function, not a macro; use this fact
601 to simplify the code.
602 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
603 compiler bugs; no longer relevant.
604 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
605 (SYNTAX_INLINE): New macro.
606 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
607 for the new functions. Use bool for boolean member.
608 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
609 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
610 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
611 (SETUP_BUFFER_SYNTAX_TABLE):
612 Now extern inline functions, not macros.
613 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
614 Remove; all uses replaced by implementation.
615 (syntax_temp) [!__GNUC__]: Remove decl.
616 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
617
29be4a50
JD
6182013-07-10 Jan Djärv <jan.h.d@swipnet.se>
619
620 * emacs.c (main): Fix syntax error.
621
954b166e
PE
6222013-07-10 Paul Eggert <eggert@cs.ucla.edu>
623
624 Timestamp fixes for undo (Bug#14824).
625 * atimer.c (schedule_atimer):
626 * fileio.c (Ffile_newer_than_file_p):
627 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
628 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
629 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
630 (syms_of_fileio): Remove Sclear_visited_file_name.
631 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
632 file doesn't exist; this avoids an ambiguity with negative timestamps.
633 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
634 * systime.h (make_emacs_time, invalid_emacs_time):
635 Don't assume struct timespec layout; POSIX doesn't guarantee it.
636 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
637 * undo.c (record_first_change): Push (visited-file-modtime) onto
638 undo list rather than reimplementing it by hand, incorrectly.
639
d74647c3
KB
6402013-07-09 Ken Brown <kbrown@cornell.edu>
641
642 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
643
3c51b96b
JB
6442013-07-09 Juanma Barranquero <lekktu@gmail.com>
645
646 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
647
4ebbdd67
PE
6482013-07-09 Paul Eggert <eggert@cs.ucla.edu>
649
650 Handle errno and exit status a bit more carefully.
651 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
652 number into an exit status. Instead, use EXIT_CANCELED.
653 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
654 * callproc.c (relocate_fd):
655 * emacs.c (close_output_streams, main):
656 * process.c (create_process):
657 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
658 Use emacs_perror for simplicity.
659 * callproc.c (relocate_fd, main):
660 * sysdep.c (sys_subshell):
661 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
662 (shut_down_emacs): Use emacs_write, not write.
663 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
664 * fileio.c (Fcopy_file, e_write):
665 * nsterm.m (ns_select):
666 * process.c (send_process):
667 * sound.c (vox_write):
668 Use emacs_write_sig, not emacs_write.
669 * lisp.h (emacs_write_sig, emacs_perror): New decls.
670 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
671 New constants.
672 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
673 of write.
674 (emacs_full_write): New function.
675 (emacs_write): Rewrite to use it.
676 (emacswrite_sig, emacs_perror): New functions.
677 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
678
e4b1e5af
JD
6792013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change).
680
681 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
682 on NS even if it is present. Pixmap on NS is a void*.
683
9caab067
PE
6842013-07-07 Paul Eggert <eggert@cs.ucla.edu>
685
686 Port to Ubuntu 10 (Bug#14803).
687 Problem reported by T.V. Raman.
688 * process.c (close_on_exec, accept4, process_socket):
689 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
690
1d442672
EZ
6912013-07-07 Eli Zaretskii <eliz@gnu.org>
692
693 * w32.c (sys_dup): Declare prototype.
694
695 * filelock.c:
696 * emacs.c:
697 * callproc.c [WINDOWSNT]: Include sys/socket.h.
698
067428c1
PE
6992013-07-07 Paul Eggert <eggert@cs.ucla.edu>
700
701 Make file descriptors close-on-exec when possible (Bug#14803).
702 This simplifies Emacs a bit, since it no longer needs to worry
703 about closing file descriptors by hand in some cases.
704 It also fixes some unlikely races. Not all such races, as
705 libraries often open files internally without setting
706 close-on-exec, but it's an improvement.
707 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
708 * callproc.c (Fcall_process) [!MSDOS]:
709 * emacs.c (main) [!DOS_NT]:
710 * nsterm.m (ns_term_init):
711 * process.c (create_process):
712 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
713 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
714 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
715 Prefer mkostemp with O_CLOEXEC to mkstemp.
716 * callproc.c (relocate_fd) [!WINDOWSNT]:
717 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
718 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
719 now using pipe2.
720 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
721 Make the resulting file descriptor close-on-exec.
722 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
723 * lread.c (load_descriptor_list, load_descriptor_unwind):
724 Remove; no longer needed. All uses removed.
725 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
726 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
727 New functions.
728 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
729 (Fmake_network_process, Fnetwork_interface_list):
730 (Fnetwork_interface_info, server_accept_connection):
731 Make newly-created socket close-on-exec.
732 * sysdep.c (emacs_open, emacs_fopen):
733 Make new-created descriptor close-on-exec.
734 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
735 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
736
0da857dd
JD
7372013-07-07 Jan Djärv <jan.h.d@swipnet.se>
738
739 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
740 for NS_IMPL_GNUSTEP.
741
5f86adcd
PE
7422013-07-07 Paul Eggert <eggert@cs.ucla.edu>
743
744 Fix openp errno handling.
745 * callproc.c (Fcall_process): Preserve openp errno around close.
746 * lread.c (openp): Set errno when returning -1, as some callers
747 expect this.
748
1afb1d07
JD
7492013-07-06 Jan Djärv <jan.h.d@swipnet.se>
750
751 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
752
753 * nsterm.h (NSSavePanel): Update comment.
754 (NSAPP_DATA2_RUNFILEDIALOG): Define.
755 (ns_run_file_dialog): Declare.
756
757 * nsfns.m: Remove panelOK.
758 (ns_fd_data): New.
759 (ns_run_file_dialog): New function.
760 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
761 event loop, so file dialog is popped up by ns_run_file_dialog, called
762 by sendEvent (Bug#14578).
763 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
764
3323c263
EZ
7652013-07-06 Eli Zaretskii <eliz@gnu.org>
766
fdda0220
EZ
767 * xdisp.c (default_line_pixel_height): New function.
768 (pos_visible_p, move_it_vertically_backward, try_scrolling)
769 (try_cursor_movement, redisplay_window, try_window)
770 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
771
772 * window.c (window_scroll_pixel_based): use
773 default_line_pixel_height.
774
775 * dispextern.h (default_line_pixel_height): Add prototype.
776
777 * frame.c (x_set_line_spacing): Accept a float value for
778 line-spacing parameter, per the documentation.
779
3323c263
EZ
780 * data.c (Fmultibyte_string_p): Doc fix.
781
47ba6d43
PE
7822013-07-05 Paul Eggert <eggert@cs.ucla.edu>
783
406af475
PE
784 Use emacs_open more consistently when opening files.
785 This handles EINTR more consistently now, and makes it easier
786 to introduce other uniform changes to file descriptor handling.
787 * src/systdio.h: New file.
788 * src/buffer.c (mmap_init):
789 * cygw32.c (chdir_to_default_directory):
790 * dispnew.c (Fopen_termscript):
791 * emacs.c (Fdaemon_initialized):
792 * fileio.c (Fdo_auto_save):
793 * image.c (slurp_file, png_load_body, jpeg_load_body):
794 * keyboard.c (Fopen_dribble_file):
795 * lread.c (Fload):
796 * print.c (Fredirect_debugging_output):
797 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
798 * termcap.c (tgetent):
799 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
800 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
801 * w32term.c (w32_initialize) [CYGWIN]:
802 * xfaces.c (Fx_load_color_file):
803 Use emacs_open instead of plain open, and emacs_fopen instead of
804 plain fopen.
805 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
806 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
807 * callproc.c (default_output_mode): New constant.
808 (Fcall_process): Use it to call emacs_open instead of plain creat.
809 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
810 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
811 (emacs_fopen): New function.
812 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
813 Include <lisp.h>, for emacs_open.
814 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
815
47ba6d43
PE
816 Remove duplicate #include directives.
817 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
818 * xfaces.c:
819 Don't include stdio.h twice.
820 * buffer.c [USE_MMAP_FOR_BUFFERS]:
821 Don't include sys/types.h or stdio.h twice.
822 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
823 * lread.c: Don't include coding.h twice.
824 * nsfont.m: Don't include frame.h twice.
825 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
826 * ralloc.c: Don't include <unistd.h> twice.
827 * xdisp.c: Don't include font.h twice.
828 * xterm.c: Don't include fontset.h twice.
829 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
830
b9ed53d5
PE
8312013-07-04 Paul Eggert <eggert@cs.ucla.edu>
832
833 Scale ImageMagick images more carefully.
834 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
835 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
836 Be more careful about avoiding undefined behavior after
837 integer overflow and division by zero.
838
cf13177e
YM
8392013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
840
841 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
842 (syms_of_w32fns): DEFSYM them.
843 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
844 (CCHDEVICENAME): Define macros if not defined.
845 (struct MONITOR_INFO_EX): New struct.
846 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
847 (enum_display_monitors_fn): New variable.
848 (globals_of_w32fns): Initialize it.
849 (Fx_display_pixel_width, Fx_display_pixel_height)
850 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
851 multi-monitor setups in docstrings.
852 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
853 screen size by primary monitor's millimeter per pixel.
854 (w32_monitor_enum, w32_display_monitor_attributes_list)
855 (w32_display_monitor_attributes_list_fallback)
856 (Fw32_display_monitor_attributes_list): New functions.
857 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
858
859 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
860 if not defined.
861 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
862
86dfb7a8
MA
8632013-07-04 Michael Albinus <michael.albinus@gmx.de>
864
865 * fileio.c (Qfile_notify_error): New error symbol.
866
867 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
868 * inotify.c (inotify_callback, symbol_to_inotifymask)
869 (Finotify_add_watch, Finotify_rm_watch): Use it.
870 (inotifyevent_to_event): Exchange order of cookie and file name.
871 (Finotify_add_watch): Adapt docstring.
872
873 * lisp.h (Qfile_notify_error): Declare.
874
2c1c974b
PE
8752013-07-04 Paul Eggert <eggert@cs.ucla.edu>
876
877 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
878 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
879 Do not clear _malloc_thread_enabled_p, undoing the previous change,
880 which did not work (see <http://bugs.gnu.org/14569#307>).
881 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
882 && (!noninteractive || initialized)). This attempts to thread
883 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
884
7a35b20f
JB
8852013-07-04 Juanma Barranquero <lekktu@gmail.com>
886
887 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
888 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
889
1ce5cd04
PE
8902013-07-04 Paul Eggert <eggert@cs.ucla.edu>
891
892 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
893 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
894 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
895 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
896
57f8c490
PE
8972013-07-02 Paul Eggert <eggert@cs.ucla.edu>
898
899 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
900 Define to __sys_siglist.
901
bcffb5ca
EZ
9022013-07-02 Eli Zaretskii <eliz@gnu.org>
903
904 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
905 word-wrap, so that overflow-newline-into-fringe would work in
906 visual-line-mode. (Bug#2749)
907 (move_it_in_display_line_to): When the last scanned display
908 element fits exactly on the display line, and
909 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
910 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
911 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
912 finding buffer position that corresponds to pixel coordinates,
913 e.g. in buffer_posn_from_coords.
914
2c41e781
JD
9152013-07-02 Jan Djärv <jan.h.d@swipnet.se>
916
917 * process.c (handle_child_signal): Call catch_child_signal if
918 NS_IMPL_GNUSTEP.
919
c2418359
PE
9202013-07-02 Paul Eggert <eggert@cs.ucla.edu>
921
52a9bcae
PE
922 Don't convert function pointers to void * and back.
923 It isn't portable C, and it's easy enough to avoid.
924 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
925 (make_save_value): Add support for SAVE_FUNCPOINTER.
926 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
927 * print.c (print_object):
928 Distinguish function from object pointers.
929 * lisp.h (SAVE_FUNCPOINTER): New constant.
930 (SAVE_SLOT_BITS): Adjust to it.
931 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
932 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
933 (voidfuncptr): New typedef.
934 (struct Lisp_Save_Value): New member data[0].funcpointer.
935 (XSAVE_FUNCPOINTER): New function.
936
c2418359
PE
937 Simplify buildobj processing.
938 * Makefile.in (buildobj.h): Make it a sequence of strings each
939 followed by comma, rather than a single string. Put it into a
940 .tmp file in case there's an error while generating it.
941 (gl-stamp): Use .tmp for temp files.
942 (mostlyclean): Clean .tmp files.
943 * doc.c (buildobj): Move to just the routine that needs it.
944 It's now an array of strings, so processing is simpler.
945
8f43ce49
PE
9462013-07-01 Paul Eggert <eggert@cs.ucla.edu>
947
948 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
949 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
950 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
951 Invoke malloc_enable_thread even when not interactive.
952 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
953 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
954 in this case, since the underlying bug has now been fixed.
955
24827db9
JB
9562013-07-01 Juanma Barranquero <lekktu@gmail.com>
957
958 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
959 unlinking it (bug#14691).
960
ef099a94
MN
9612013-06-30 Michal Nazarewicz <mina86@mina86.com>
962
963 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
964 before checking whether buffer is modified. This lets
965 `kill-buffer-query-functions' cancel killing of the buffer or save
966 its content before `kill-buffer' asks user the "Buffer %s
967 modified; kill anyway?" question.
968
9d3f2fc2
JD
9692013-06-30 Jan Djärv <jan.h.d@swipnet.se>
970
971 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
972 Let the super performKeyEquivalent deal with them (Bug#14747).
973
e6c6c8c7
PE
9742013-06-30 Paul Eggert <eggert@cs.ucla.edu>
975
1d71c1d9
PE
976 * widget.c (resize_cb): Remove unused local.
977
8f5f35cc
PE
978 Do not use GTK 3 if it exists but cannot be compiled.
979 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
980 * xterm.c (x_error_handler) [!USE_GTK]:
981 Do not use GTK 3.
982
e6c6c8c7
PE
983 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
984
0ba54312
EZ
9852013-06-30 Eli Zaretskii <eliz@gnu.org>
986
5d1c3286
EZ
987 * intervals.c (get_local_map): Instead of aborting, clip POSITION
988 to the valid range of values. (Bug#14753)
989
0ba54312
EZ
990 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
991 when moving point by using the current glyph matrix. This avoids
992 the need to force redisplay when this function is called in a
993 loop.
994
9c90cc06
PE
9952013-06-29 Paul Eggert <eggert@cs.ucla.edu>
996
997 Fix minor problems found by static checking.
998 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
999 Redo the latter's body to sidestep GCC parenthesization warnings.
1000 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1001 * coding.c (detect_coding, detect_coding_system):
1002 * coding.h (struct undecided_spec):
1003 Use bool for boolean.
1004 * image.c (QCmax_width, QCmax_height): Now static.
1005 * xdisp.c (Fmove_point_visually): Remove unused local.
1006
4c672a0f
EZ
10072013-06-29 Eli Zaretskii <eliz@gnu.org>
1008
1009 * xdisp.c (Fmove_point_visually): New function.
1010
c1ea3abf
JB
10112013-06-28 Kenichi Handa <handa@gnu.org>
1012
1013 * coding.h (define_coding_undecided_arg_index): New enum.
1014 (coding_attr_index): New members
1015 coding_attr_undecided_inhibit_null_byte_detection,
1016 coding_attr_undecided_inhibit_iso_escape_detection,
1017 coding_attr_undecided_prefer_utf_8.
1018 (undecided_spec): New struct.
1019 (struct coding_system): New member `undecided' of the member
1020 `spec'.
1021
1022 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1023 (detect_coding): Likewise.
1024 (detect_coding_system): Likewise.
1025 (Fdefine_coding_system_internal): New coding system properties
1026 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1027 :prefer-utf-8.
1028 (syms_of_coding): Adjust for coding_arg_undecided_max.
1029
ba3de9e6
PE
10302013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 * image.c (x_from_xcolors): Remove unused local.
1033
547c9269
YM
10342013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1035
1036 Defer image data transfer between X client and server until actual
1037 display happens.
1038
1039 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1040 and `mask_img'.
1041
1042 * image.c (Destroy_Image): Remove.
1043 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1044 `mask_p', and `colors_p'. All uses changed.
1045 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1046 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1047 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1048 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1049 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1050 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1051 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1052 (image_get_x_image, image_unget_x_image): New functions or macros.
1053 (image_background, image_background_transparent, x_to_xcolors)
1054 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1055 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1056 instead of Destroy_Image.
1057 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1058 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1059 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1060 (imagemagick_load_image, svg_load_image): Use them instead of
1061 x_create_x_image_and_pixmap, and x_put_x_image followed by
1062 x_destroy_x_image, respectively.
1063 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1064 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1065 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1066 background_transparent fields.
1067 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1068 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1069
dae2f5ef
PE
10702013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1073 This mostly consists of undoing recent changes.
1074 * callproc.c (Fcall_process):
1075 * process.c (create_process):
1076 Do not worry about catching SIGCHLD here, undoing previous change.
1077 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1078 * process.c, process.h (catch_child_signal):
1079 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1080 * process.c (catch_child_handler): Don't worry about being called
1081 lazily and do not assume caller has blocked SIGCHLD, undoing
1082 previous change. Move first-time stuff back to
1083 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1084 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1085 set lib_child_handler if it's already initialized, which may
1086 help avoid problems on GNUStep.
1087
fa55d2aa
PE
10882013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1091 * callproc.c (Fcall_process):
1092 * process.c (create_process):
1093 Make sure SIGCHLD is caught before we fork,
1094 since Emacs startup no arranges to catch SIGCHLD.
1095 * process.c (lib_child_handler): Initialize to null, not to
1096 dummy_handler.
1097 (catch_child_signal): Allow self to be called lazily.
1098 Do nothing if it's already been called.
1099 Assume caller has blocked SIGCHLD (all callers do now).
1100 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1101 just before it's really needed.
1102 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1103 since it hasn't been caught yet.
1104
f3f9606c
LMI
11052013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1106
1107 * image.c (compute_image_size): New function to implement
1108 :max-width and :max-height.
1109 (imagemagick_load_image): Use it.
1110
c7041908
PE
11112013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1112
1113 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1114 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1115 Now extern.
1116 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1117 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1118 the SIGCHLD handler, since the code is not atomic and (due to glib)
1119 signals may be arriving now.
1120 * sysdep.c (init_signals): Do not catch child signals here;
1121 'main' now does that later, at a safer time.
1122
f86852b4
PE
11232013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1124
0dfeed58
PE
1125 Clean up SIGCHLD handling a bit (Bug#14569).
1126 * process.c, process.h (catch_child_signal):
1127 Now always extern, even if !NS_IMPL_GNUSTEP.
1128 * process.c (catch_child_signal): Move glib tickler here from
1129 init_process_emacs, so that it's done earlier in Emacs
1130 initialization. Also move the noninteractive && !initialized
1131 check here from init_process_emacs. This is all a bit cleaner for
1132 GNUish platforms, and I hope it works around the Cygwin bug.
1133 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1134 that glib signal handling is tickled before glib creates threads.
1135
f86852b4
PE
1136 * process.c (wait_reading_process_output): Avoid int overflow
1137 when reading more than 2 GiB total from a process.
1138
cbd6509c
PE
11392013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 * process.c (create_process): Handle a couple more cases,
1142 i.e., work even if new_argv and wait_child_setup[i] are cached.
1143 Use Fcall_process's style for volatile vars.
1144
9de1114a
AS
11452013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1146
1147 * process.c (create_process): Mark PROCESS volatile.
1148
fbe9e0b9
PE
11492013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1150
1151 Use C99-style flexible array members if available.
1152 This avoids some subtle aliasing issues, which typically
1153 aren't a problem with GCC but may be a problem elsewhere.
1154 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1155 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1156 In either case, it uses a flexible array member rather than
1157 the old struct hack. All uses changed.
1158 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1159 Adjust to sdata reorganization.
1160 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1161 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1162 that ports better to pre-C99 non-GCC.
1163 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1164 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1165 as the latter has changed.
1166 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1167 and port better to pre-C99 GCC.
1168 * image.c (struct xpm_cached_color):
1169 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1170 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1171 Use FLEXIBLE_ARRAY_MEMBER.
1172 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1173 Move decl to top level so it gets checked against implementation.
1174 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1175 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1176
1fc71008
PE
11772013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * syntax.c: Integer cleanups.
1180 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1181 All uses that need 0-or-2 changed to:
1182 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1183 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1184 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1185 (char_quoted, prev_char_comend_first, back_comment)
1186 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1187 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1188 Use bool for boolean.
1189 (update_syntax_table, skip_chars, skip_syntaxes):
1190 Prefer int to unsigned when either will do.
1191 (back_comment): Return boolean success flag, like forw_comment,
1192 instead of positive-or-minus-1 (which might have overflowed int anyway).
1193 Don't stuff ptrdiff_t into int.
1194 (syntax_spec_code, syntax_code_spec): Now const.
1195 (Fmatching_paren, scan_lists, scan_sexps_forward):
1196 Use enum syntaxcode for syntax code.
1197 (Fmatching_paren): Check that arg is a character, not just an integer.
1198 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1199 (Finternal_describe_syntax_value): Omit no-longer-needed
1200 comparison to 0.
1201 (skip_chars): Use char, not unsigned char, when the distinction
1202 doesn't matter.
1203 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1204 * bytecode.c (exec_byte_code):
1205 * syntax.c (syntax_spec_code, Fchar_syntax)
1206 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1207 (init_syntax_once):
1208 * syntax.h (SYNTAX_WITH_FLAGS):
1209 Omit unnecessary casts.
1210
b932cad7
EZ
12112013-06-20 Eli Zaretskii <eliz@gnu.org>
1212
1213 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1214 line dimensions here, to avoid race conditions with the main
1215 thread. (Bug#14062, bug#14630, bug#14669)
1216
1217 * w32term.c (w32_draw_window_cursor): Compute the header line and
1218 mode line dimensions here.
1219 <w32_system_caret_window, w32_system_caret_hdr_height>:
1220 <w32_system_caret_mode_height>: New variables.
1221
1222 * w32term.h: Declare them.
1223
89561f72
PE
12242013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1225
5013fc08
PE
1226 * alloc.c (die): Move "assertion failed" string here ...
1227 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1228 COND when SUPPRESS_CHECKING. This shrinks the executable text
1229 size by 0.8% to 2.2% when configured with --enable-checking,
1230 depending on optimization flags (GCC 4.8.1 x86-64).
1231
89561f72
PE
1232 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1233
12342013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
1235
1236 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1237 base is 2; this is more accurate.
1238
983aeb9a
JB
12392013-06-19 Juanma Barranquero <lekktu@gmail.com>
1240
1241 * sound.c (string_default): Move to !WINDOWSNT section.
1242 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1243
178ba3e6
PE
12442013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1245
bbc51b15
PE
1246 * sound.c: Integer cleanups.
1247 Remove unnecessary forward decls.
1248 (struct sound_device): The 'file' member is now a Lisp_Object, not
1249 a char *, so that we needn't invoke alloca on a huge size.
1250 (Fplay_sound_internal): Adjust to this.
1251 (string_default): New function.
1252 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1253 Use it to adjust to the struct sound_device change.
1254 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1255 (be2hs) [0]: Remove.
1256
178ba3e6
PE
1257 * syntax.c (skip_chars): Don't use uninitialized storage
1258 when searching a multibyte buffer for characters that are not in a
1259 unibyte string that contains non-ASCII characters.
1260
69f60cdc
JD
12612013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1262
1263 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1264 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1265
0d6224d4
PE
12662013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1269
3c542890
KH
12702013-06-18 Kenichi Handa <handa@gnu.org>
1271
f7e3f7cd
KH
1272 * font.c (Ffont_spec): Signal an error for an invalid font name
1273 (Bug#14648).
3c542890 1274
9349e5f7
PE
12752013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1276
1277 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1278 In particular this ports to 32-bit sparc Sun cc.
1279 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1280 array with a dummy element at specpdl[-1], so that its address can
1281 be taken portably.
1282 (unbind_to): Do not copy the binding; not needed, now that we
1283 copy old_value in the one place where the copy is needed.
1284 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1285 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1286 (union specbinding): Rename from struct specbinding. Redo layout
1287 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1288 which is not portable. With Sun C 5.12 32-bit sparc, the
1289 declaration causes nargs to be an unsigned bitfield, a behavior
1290 that the C standard allows; but Emacs wants nargs to be signed.
1291 The overall type is now a union of structures rather than a
1292 structure of union of structures, and the 'kind' member is now a
1293 bitfield, so that the overall type doesn't grow. All uses changed.
1294 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1295
0a4df6a5
PE
12962013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1297
ec6ecaad
PE
1298 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1299 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1300
0a4df6a5
PE
1301 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1302
7bfe8dbc
EZ
13032013-06-17 Eli Zaretskii <eliz@gnu.org>
1304
1305 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1306 unless we know that the window w's frame is a frame object.
1307 Another attempt at solving bug#14062 and bug#14630.
1308
708e05f6
LMI
13092013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1310
1311 * textprop.c (property_set_type): New enum.
1312 (add_properties): Allow appending/prepending text properties.
1313 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1314 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1315 add_text_properties_1.
1316 (Fadd_face_text_property): New function that calls
1317 add_text_properties_1.
1318
84575e67
PE
13192013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 Move functions from lisp.h to individual modules when possible.
1322 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1323 * alloc.c (XFLOAT_INIT, set_symbol_name):
1324 * buffer.c (CHECK_OVERLAY):
1325 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1326 (set_char_table_parent):
1327 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1328 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1329 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1330 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1331 (set_blv_valcell):
1332 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1333 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1334 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1335 (backtrace_args, backtrace_debug_on_exit):
1336 * floatfns.c (CHECK_FLOAT):
1337 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1338 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1339 (set_hash_hash, set_hash_hash_slot, set_hash_index)
1340 (set_hash_index_slot):
1341 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
1342 * marker.c (CHECK_MARKER):
1343 * textprop.c (CHECK_STRING_OR_BUFFER):
1344 * window.c (CHECK_WINDOW_CONFIGURATION):
1345 Move here from lisp.h, and make these functions static rather than
1346 extern inline.
1347 * buffer.c (Qoverlayp):
1348 * data.c (Qsubrp):
1349 * fns.c (Qhash_table_p):
1350 * window.c (Qwindow_configuration_p):
1351 Now static.
1352 * lisp.h: Remove the abovementioned defns and decls.
1353
1354 Use functions, not macros, for XINT etc. (Bug#11935).
1355 In lisp.h, prefer functions to function-like macros, and
1356 constants to object-like macros, when either will do. This:
1357 . simplifies use, as there's no more need to worry about
1358 arguments' side effects being evaluated multiple times.
1359 . makes the code easier to debug on some platforms.
1360 However, when using gcc -O0, keep using function-like macros
1361 for a few critical operations, for performance reasons.
1362 This sort of thing isn't needed with gcc -Og, but -Og
1363 is a GCC 4.8 feature and isn't widely-enough available yet.
1364 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
1365 Remove enum lsb_bits; no longer needed.
1366 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
1367 * buffer.c (Qoverlap):
1368 * data.c (Qsubrp):
1369 * fns.c (Qhash_table_p):
1370 Now extern, so lisp.h can use these symbols.
1371 * dispextern.h: Include character.h, for MAX_CHAR etc.
1372 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1373 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1374 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1375 (GLYPH_CODE_P): Move here from lisp.h.
1376 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1377 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
1378 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
1379 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
1380 XUNTAG now returns void *.
1381 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
1382 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
1383 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
1384 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
1385 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
1386 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
1387 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
1388 (lisp_h_XPNTR, lisp_h_XSYMBOL):
1389 New macros, renamed from their sans-lisp_h_ counterparts.
1390 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
1391 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
1392 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
1393 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
1394 If compiling via GCC without optimization, define these as macros
1395 in addition to inline functions.
1396 To disable this, compile with -DINLINING=0.
1397 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
1398 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
1399 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
1400 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
1401 (INTMASK, VALMASK): Now macros, since static values cannot be
1402 accessed from extern inline functions.
1403 (VALMASK): Also a constant, for benefit of old GDB.
1404 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
1405 is INTEGERP, which can fold it in.
5165d44a 1406 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
1407 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
1408 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
1409 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
1410 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
1411 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
1412 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
1413 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
1414 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
1415 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
1416 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
1417 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
1418 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
1419 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
1420 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
1421 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
1422 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
1423 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
1424 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
1425 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
1426 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
1427 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
1428 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
1429 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
1430 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
1431 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
1432 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
1433 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
1434 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
1435 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
1436 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
1437 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
1438 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
1439 Now functions.
1440 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
1441 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
1442 (VALMASK): Define in one place rather than in two, merging the
1443 USE_LSB_TAG parts; this is simpler.
1444 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
1445 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
1446 Move up, to avoid use before definition.
1447 Also include "globals.h" earlier, for the same reason.
1448 (make_natnum): New function.
1449 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
1450 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
1451 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
1452 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
1453 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
1454 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
1455 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
1456 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
1457 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
1458 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
1459 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
1460 (Qwindow_configuration_p, Qimage): New forward declarations.
1461 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
1462 (STRING_COPYIN): Remove; unused.
1463 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
1464 (xcar_addr, xcdr_addr): New functions. All uses changed.
1465 (IEEE_FLOATING_POINT): Now a constant, not a macro.
1466 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1467 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1468 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1469 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
1470 (TYPE_RANGED_INTEGERP): Simplify.
1471 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
1472 (setlocale, fixup_locale, synchronize_system_messages_locale)
1473 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
1474 Now empty functions, not macros.
1475 (functionp): Return bool, not int.
1476 * window.c (Qwindow_configuration_p): Now extern,
1477 so window.h can use it.
1478 * window.h (Qwindowp): Move decl back to lisp.h.
1479
9583ec36
EZ
14802013-06-15 Eli Zaretskii <eliz@gnu.org>
1481
1482 * xdisp.c (Fline_pixel_height): New function, required for solving
1483 bug #14567.
1484
210272ce
PE
14852013-06-15 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
1488
de0503df
SM
14892013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
1490
1491 * lread.c (syms_of_lread):
1492 * fns.c (Fprovide): Adjust to new format of after-load-alist.
1493
afbfe143
KD
14942013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
1495
1496 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
1497
d177e213
XF
14982013-06-12 Xue Fuqiao <xfq.free@gmail.com>
1499
1500 * fileio.c (expand_file_name): Doc fix.
1501
05e3e412
PE
15022013-06-11 Paul Eggert <eggert@cs.ucla.edu>
1503
f7394b12
PE
1504 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
1505 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
1506 Wait for self, not for 0. This can't hurt on GNU or similar
1507 system, and may help with Cygwin.
1508
05e3e412
PE
1509 * keyboard.c: Don't use PROP (...) as an lvalue.
1510 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
1511 Use set_prop (A, B), not PROP (A) = B.
1512
17dd3097
EZ
15132013-06-10 Eli Zaretskii <eliz@gnu.org>
1514
1515 * xdisp.c (get_it_property): Use it->window instead of generating
1516 a Lisp object from it->w.
1517
52fab9c9
EZ
15182013-06-09 Eli Zaretskii <eliz@gnu.org>
1519
1520 * xdisp.c (get_it_property): If it->object is a buffer, pass to
1521 get-char-property the window that is being rendered, instead of
1522 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
1523 (compute_display_string_pos): When W is NULL, use the current
1524 buffer as the object to pass to get-char-property.
1525 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
1526 pointer member of the bidi iterator, since no window is pertinent
1527 to this function.
52fab9c9 1528
5bf97bfc
EZ
15292013-06-08 Eli Zaretskii <eliz@gnu.org>
1530
1531 * bidi.c (bidi_fetch_char): Accept additional argument, the window
1532 being displayed, and pass it to compute_display_string_pos.
1533 (bidi_level_of_next_char, bidi_resolve_explicit_1)
1534 (bidi_paragraph_init): All callers changed.
1535
1536 * xdisp.c (init_from_display_pos, init_iterator)
1537 (handle_single_display_spec, next_overlay_string)
1538 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
1539 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
1540 Set bidi_it.w member from it->w.
5bf97bfc
EZ
1541 (compute_display_string_pos): Accept additional argument, the
1542 window being displayed, and pass it to Fget_char_property.
1543 (Bug#14575)
1544
1545 * dispextern.h (struct bidi_it): New member w, the window being
1546 displayed.
1547 (compute_display_string_pos): Adjust prototype.
1548
5de0e011
JD
15492013-06-08 Jan Djärv <jan.h.d@swipnet.se>
1550
e7b41c4c 1551 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
1552
1553 * process.c (wait_reading_process_output): Check for NS before GLIB.
1554 GLIB may be linked in due to rsvg, but ns_select must be called.
1555
5de0e011
JD
1556 * xgselect.c (xg_select): Remove call to window_system_available
1557 and g_main_context_pending at the top, so Gdk events (i.e. file
1558 notify) are processed when Emacs is started with -nw.
1559
a822acff
EZ
15602013-06-07 Eli Zaretskii <eliz@gnu.org>
1561
1562 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
1563 (ctagsfiles3): New variable, includes only *.m files.
1564 (TAGS): Use an explicit language name in the regular expressions,
1565 to avoid transformation of '/SOMETHING' by MSYS to
1566 'c:\MSYS\SOMETHING'.
1567
6c0a9ed1
RC
15682013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
1569
1570 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
1571
9ef6111b
EZ
15722013-06-06 Eli Zaretskii <eliz@gnu.org>
1573
1574 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
1575 still need to set the mouse pointer shape and activate help-echo.
1576 (Bug#14558)
1577
7d300d64
PE
15782013-06-06 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 A few porting etc. fixes for the new file monitor code.
1581 See the thread containing
1582 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
1583 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
1584 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
1585 (dir_monitor_callback, Fgfile_rm_watch):
1586 Use assq_no_quit instead of Fassoc, for speed.
1587 (dir_monitor_callback, Fgfile_rm_watch):
1588 eassert that the monitor is a fixnum.
1589 (dir_monitor_callback): No need for CDR_SAFE.
1590 Simplify building of lisp with alternative tails.
1591 (Fgfile_add_watch, Fgfile_rm_watch):
1592 Do not assume glib functions set errno reliably on failure.
1593 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
1594 and signal an error otherwise.
1595 (Fgfile_rm_watch): Prefer CONSP to !NILP.
1596 Use Fdelq instead of Fdelete, for speed.
1597
817ebfcf
EZ
15982013-06-05 Eli Zaretskii <eliz@gnu.org>
1599
1600 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
1601 don't insist on being invoked on a highlighted tool-bar button.
1602 Avoids losing tool-bar functionality when mouse-highlight is nil.
1603 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
1604 Don't highlight when mouse-highlight is nil.
1605 (note_mouse_highlight): When mouse-highlight is nil, don't return
1606 right away; instead, run tool-bar and mode-line highlight
1607 subroutine, clear any existing highlight, and revert the mouse
1608 pointer to its default shape. (Bug#14558)
1609
55577e7c
SM
16102013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1611
1612 * lisp.mk (lisp): Add prog-mode.el.
1613
f019a684
PE
16142013-06-05 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
1617 * process.c (dummy_handler): New function.
1618 (lib_child_handler): New static var.
1619 (handle_child_signal): Invoke it.
1620 (catch_child_signal): If a library has set up a signal handler,
1621 save it into lib_child_handler.
1622 (init_process_emacs): If using glib and not on Windows, tickle glib's
1623 child-handling code so that it initializes its private SIGCHLD handler.
1624 * syssignal.h (SA_SIGINFO): Default to 0.
1625 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
1626 31; it should no longer be needed now.
1627
90db8702
MA
16282013-06-05 Michael Albinus <michael.albinus@gmx.de>
1629
1630 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
1631
1632 * gfilenotify.c (globals_of_gfilenotify): New function.
1633 (syms_of_gfilenotify): Move global initialization there.
1634
1635 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
1636
bfa3acd6
SM
16372013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1638
1639 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
1640 * keyboard.c (menu_bar_items, tool_bar_items):
1641 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
1642 not override local keymaps any more.
1643
ba59bd80
EZ
16442013-06-04 Eli Zaretskii <eliz@gnu.org>
1645
1646 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
1647
7f203aa1
EZ
16482013-06-03 Eli Zaretskii <eliz@gnu.org>
1649
9337e206
EZ
1650 * w32console.c (initialize_w32_display): Return the dimensions of
1651 the console window via 2 additional arguments, not via the current
1652 frame. This avoids crashes due to overrunning the bounds of
1653 frame's decode_mode_spec_buffer, which is not resized following
1654 the change of the frame dimensions from the initial 10x10.
1655
1656 * w32term.h (w32_initialize_display_info): Adjust prototype.
1657
1658 * term.c (init_tty): Take dimensions of the frame from the values
1659 returned by initialize_w32_display.
1660
7f203aa1
EZ
1661 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
1662 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
1663 (LIBES): Add $(GFILENOTIFY_LIBS).
1664
1665 * w32inevt.c (handle_file_notifications): Add dummy implementation
1666 for !HAVE_W32NOTIFY.
1667
1668 * w32term.c: Wrap code with HAVE_W32NOTIFY.
1669
55a87246
JD
16702013-06-03 Jan Djärv <jan.h.d@swipnet.se>
1671
1672 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
1673
1674 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
1675
1676 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
1677
3d5ee10a
PE
16782013-06-03 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 Fix minor problems found by static checking.
1681 * data.c (pure_write_error):
1682 Use xsignal2, not Fsignal, as Fsignal might return.
1683 * eval.c (set_backtrace_debug_on_exit): Now static.
1684 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
1685 No longer inline. EXTERN_INLINE is needed only for functions
1686 defined in .h files. Reindent function header as per GNU style.
1687 (backtrace_p, backtrace_top, backtrace_next):
1688 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
1689 compiler or linker. Add extern decls to pacify gcc -Wall.
1690 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1691 Now static.
1692 * frame.c (free_monitors): Define only on platforms that need it.
1693 * nsterm.m (ns_term_init):
1694 * process.c (catch_child_signal):
1695 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
1696 defined on all porting targets these days.
1697 * process.c, process.h (catch_child_signal):
1698 Make it extern only if NS_IMPL_GNUSTEP is defined.
1699
e2d8a6f0
EZ
17002013-06-03 Eli Zaretskii <eliz@gnu.org>
1701
1702 * w32.c (gettimeofday): Make the signature identical to prototype
1703 in nt/inc/sys/time.h.
1704
a8a7c5f6
SM
17052013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1706
1707 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
1708 .gdbinit.
1709
1710 * keyboard.c (safe_run_hooks_error): Improve error message.
1711
1712 * data.c (pure_write_error): Add `object' argument.
1713 * puresize.h (CHECK_IMPURE): Use it.
1714
c9628c79
MA
17152013-06-03 Michael Albinus <michael.albinus@gmx.de>
1716
1717 * Makefile.in (NOTIFY_OBJ): New variable.
1718 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
1719
1720 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
1721 Call syms_of_gfilenotify.
1722
1723 * gfilenotify.c: New file.
1724
1725 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
1726 and Qfile_w32notify.
1727 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
1728 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
1729
1730 * lisp.h: Declare syms_of_gfilenotify.
1731
1732 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
1733
2f592f95
SM
17342013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1735
1736 Merge the specpdl and backtrace stacks. Make the structure of the
1737 specpdl entries more obvious via a tagged union of structs.
1738 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
1739 (enum specbind_tag): New enum.
1740 (struct specbinding): Make it a tagged union of structs.
1741 Add a case for backtrace records.
1742 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
1743 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
1744 (backtrace_debug_on_exit): New accessors.
1745 (struct backtrace): Remove.
1746 (struct catchtag): Remove backlist field.
1747 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1748 Move to eval.c.
1749 (Flocal_variable_p): Speed up the common case where the binding is
1750 already loaded.
1751 * eval.c (backtrace_list): Remove.
1752 (set_specpdl_symbol, set_specpdl_old_value): Remove.
1753 (set_backtrace_args, set_backtrace_nargs)
1754 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
1755 (backtrace_next): New functions.
1756 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
1757 (unwind_to_catch, internal_lisp_condition_case)
1758 (internal_condition_case, internal_condition_case_1)
1759 (internal_condition_case_2, internal_condition_case_n): Don't bother
1760 with backtrace_list any more.
1761 (Fsignal): Adjust to new backtrace format.
1762 (grow_specpdl): Move up.
1763 (record_in_backtrace): New function.
1764 (eval_sub, Ffuncall): Use it.
1765 (apply_lambda): Adjust to new backtrace format.
1766 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
1767 data.c.
1768 (specbind): Adjust to new specpdl format. Simplify.
1769 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
1770 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
1771 backtrace format.
1772 (mark_backtrace): Remove.
1773 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
1774 * xdisp.c (redisplay_internal): Use record_in_backtrace.
1775 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
1776 Use mark_specpdl.
1777 * profiler.c (record_backtrace): Use get_backtrace.
1778 (handle_profiler_signal): Use backtrace_top_function.
1779 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
1780 accessor functions.
1781
c0342369
JD
17822013-06-02 Jan Djärv <jan.h.d@swipnet.se>
1783
1784 * process.h (catch_child_signal): Declare.
1785
1786 * process.c (catch_child_signal): New function.
1787 (init_process_emacs): Call it.
1788
1789 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
1790 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
1791 NS_IMPL_COCOA.
1792 (x_set_cursor_type): Remove declaration.
1793 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
1794 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
1795 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
1796 (ns_get_color): Use F suffix on float.
1797 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
1798 (ns_get_rgb_color): Remove.
1799 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
1800 (note_mouse_movement): x and y are CGFloat.
1801 (ns_draw_fringe_bitmap): Remove unused rowY.
1802 Change #if to COCOA && >= 10_6.
1803 (ns_draw_window_cursor): Remove unused overspill.
1804 (ns_draw_underwave): width and x are EamcsCGFloat.
1805 (ns_draw_box): thickness is CGFloat.
1806 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
1807 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
1808 if not in main thread.
1809 (ns_get_pending_menu_title, ns_check_menu_open)
1810 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
1811 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
1812 (sendFromMainThread:): New method.
1813 (changeFont:): size is CGFloat.
1814 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
1815 Disable warning about permanent text.
1816 (characterIndexForPoint:): Adjust return type depending on GNUStep
1817 version.
1818 (mouseDown:): delta is CGFloat.
1819 (updateFrameSize): Remove unised variable f.
1820 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
1821 Cast float to EmacsCGFloat.
1822 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
1823 also to -1 when restoring.
1824 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
1825 inside NS_IMPL_COCOA.
1826 (toggleFullScreen:): Put call to toggleFullScreen inside
1827 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
1828 (setPosition:portion:whole:): por is CGFloat.
1829 (getMouseMotionPart:window:x:y:): Add F suffix to float.
1830 (mouseDown:): Use CGFloat.
1831 (mouseDragged:): Remove unised variable edge.
1832 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
1833
1834 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
1835 of CGFloat differs.
1836 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
1837 when NS_IMPL_GNUSTEP.
1838 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
1839 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
1840 (EmacsToolbar): Add clearAll. Add tag argument to
1841 addDisplayItemWithImage.
1842 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
1843
1844 * nsselect.m (ns_get_local_selection): Remove unused variable type.
1845
1846 * nsmenu.m (ns_update_menubar): Make static.
1847 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
1848 (fillWithWidgetValue:): Add cast to SEL for setAction.
1849 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
1850 (update_frame_tool_bar): Update code for GNUStep.
1851 (clearAll): New method.
1852 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 1853 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 1854 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
1855 call to insertItemWithItemIdentifier.
1856 (validateVisibleItems): Fix indentation.
1857 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
1858 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
1859 UtilityWindow to aStyle, remove call to setStyleMask.
1860
1861 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
1862
1863 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
1864 (ns_charset_covers, ns_get_covering_families, nsfont_open):
1865 Use F suffix on floats.
1866 (ns_char_width): Returns CGFloat.
1867 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 1868 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
1869 DPSxshow.
1870 (ns_glyph_metrics): CGFloat instead of float.
1871
a0eb10b3
JB
1872 * nsfns.m (x_set_foreground_color, x_set_background_color):
1873 Use EmacsCGFloat.
1874 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
1875 remove unused variables.
1876 (Fns_read_file_name): Keep track if panel is for save.
1877 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 1878 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
1879 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
1880 Just return the input if GNUStep.
c0342369
JD
1881 (x_screen_planes): Remove.
1882 (Fxw_color_values): Use EmacsCGFloat
1883 (Fns_display_monitor_attributes_list): Only get screen number for
1884 Cocoa.
ef099a94 1885 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
1886 EmacsSavePanel.
1887 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
1888 ns_directory_from_panel.
1889
da9aff11
PE
18902013-06-01 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 * process.c (handle_child_signal): Also use WCONTINUED.
1893 This is so that list-processes doesn't mistakenly list the process
1894 as stopped, when the process has actually been continued and is
1895 now running.
1896
0e64479a
PE
18972013-05-31 Paul Eggert <eggert@cs.ucla.edu>
1898
fc186a96
PE
1899 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
1900 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
1901 not already configured.
1902
0e64479a
PE
1903 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
1904
38b787fa
EZ
19052013-05-29 Eli Zaretskii <eliz@gnu.org>
1906
1907 * Makefile.in (mostlyclean): Remove *.res files.
1908
22513e52
SM
19092013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
1910
1911 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
1912 a buffer (bug#8447).
1913
6ef3db10
EZ
19142013-05-27 Eli Zaretskii <eliz@gnu.org>
1915
1916 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
1917 display vector, and we backtrack, handle the case that the
1918 previous character position is also displayed from a display
1919 vector or covered by a display string or image. (Bug#14476)
1920
6799bb26
JD
19212013-05-25 Jan Djärv <jan.h.d@swipnet.se>
1922
1923 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
1924 (struct MonitorInfo, free_monitors): Remove.
1925 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
1926 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
1927 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
1928 Qframes, Qsource.
1929
1930 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
1931 (struct MonitorInfo, free_monitors): Remove.
1932 (ns_screen_name): Make static.
1933 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
1934 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
1935 Qframes, Qsource.
1936
1937 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
1938 (struct MonitorInfo): New struct.
1939 (free_monitors, make_monitor_attribute_list): Declare.
1940
22513e52
SM
1941 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1942 New Lisp_Object:s.
6799bb26
JD
1943 (free_monitors, make_monitor_attribute_list): New functions.
1944 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
1945 Qsource.
1946
38cd43eb
XF
19472013-05-25 Xue Fuqiao <xfq.free@gmail.com>
1948
1949 * callproc.c (call_process): Refine the doc string. (Bug#14045)
1950
2af0948d
SM
19512013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
1952
a7eb9b0f
SM
1953 * keyboard.c: Apply keyboard decoding only to events that come directly
1954 from the tty, not from unread-command-events (bug#14368).
1955 (read_event_from_main_queue): New function, extracted from read_char).
1956 (read_decoded_char): Remove.
1957 (read_decoded_event_from_main_queue): New function to replace it.
1958 (read_char): Use it.
1959 (read_key_sequence): Use read_char rather than read_decoded_char.
1960
2af0948d
SM
1961 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
1962
1413e9a5
BR
19632013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1964
1965 * casetab.c (init_casetab_once): Fix last change (bug#14424).
1966
e6d2f155
KH
19672013-05-22 Kenichi Handa <handa@gnu.org>
1968
1969 The following changes are to fix the setting of
1970 buffer-file-coding-system on, for instance, C-x RET c unix RET
1971 _FILE_OF_DOS_EOL_TYPE_ RET.
1972
1973 * coding.h (struct coding_system): New member detected_utf8_chars.
1974
1975 * coding.c (detect_coding_utf_8): Count characters and check EOL
1976 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
1977 BOM is there.
1978 (setup_coding_system): Do not initialize coding->head_ascii.
1979 (check_ascii): Do not set coding->eol_seen but update it. Do not
1980 call adjust_coding_eol_type here.
1413e9a5
BR
1981 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
1982 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
1983 of the found coding-system.
1984 (decode_coding_gap): Cancel previous change. Utilize the
1985 character numbers counted by detect_coding_utf_8. Fix detection
1986 of BOM for utf-8.
1987
ab56a6f4 19882013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
1989
1990 * search.c (looking_at_1): Only set last_thing_searched if the match
1991 changed the match-data (bug#14281).
1992
ecc3c6ed
DA
19932013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
1994
1995 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 1996 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
1997 (move_it_vertically_backward): Likewise.
1998
5ba8bf35
YM
19992013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2000
2001 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2002 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2003 (Fx_display_mm_width, Fx_display_mm_height):
2004 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2005
91e8418b 2006 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2007 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2008 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2009 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2010 (Fx_display_backing_store, Fx_display_visual_class)
2011 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2012 (Fx_display_grayscale_p, Fx_display_pixel_width)
2013 (Fx_display_pixel_height, Fx_display_planes)
2014 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2015 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2016 (Fx_display_mm_width, Fx_display_mm_height)
2017 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2018 height for all physical monitors as in X11.
2019
fc30d803
SM
2020 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2021 Return pixel width or height for all physical monitors as in X11.
91e8418b 2022
31ff141c
PE
20232013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2024
2025 Port --enable-gcc-warnings to clang.
2026 * bytecode.c (exec_byte_code):
2027 * regex.c:
2028 Redo diagnostic pragmas to pacify clang, too.
2029 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2030 * editfns.c (Fencode_time):
2031 * fileio.c (file_accessible_directory_p):
2032 * font.c (font_unparse_xlfd):
2033 Use '&"string"[index]' instead of '"string" + (index)'.
2034 * undo.c (user_error): Remove; unused.
2035
df065a0b
EZ
20362013-05-16 Eli Zaretskii <eliz@gnu.org>
2037
04d360e7
EZ
2038 * insdel.c (insert_1_both): Document the arguments, instead of
2039 referring to insert_1, which no longer exists.
2040
5bb98290
EZ
2041 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2042 some window, increment windows_or_buffers_changed, so that
2043 *Messages* display in that window is updated. (Bug#14408)
2044
df065a0b
EZ
2045 * w32.c: Include epaths.h.
2046 (init_environment): Use cmdproxy.exe without leading directories.
2047 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2048 case.
2049 (gettimeofday): Adjust signature and return value to Posix
2050 expectations.
2051
2052 * unexw32.c (open_output_file): Delete the existing emacs.exe
2053 before creating it, to break the hard link to the versioned
2054 executable.
2055
2056 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2057 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2058 (FIRSTFILE_OBJ): New variables.
2059 (W32_RES): Rename to EMACSRES. All users changed.
2060 (base_obj): Use $(CM_OBJ).
2061 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2062 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2063 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2064 $(W32_RES_LINK) before $(LIBES).
2065 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2066
1aa8d505
SM
20672013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2068
6e911150
SM
2069 * makefile.w32-in (DOC): Use just "DOC".
2070
2071 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2072
1aa8d505
SM
2073 * process.c: Export default filters and sentinels to Elisp.
2074 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2075 New constants.
2076 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2077 (Fset_process_sentinel, Fformat_network_address):
2078 Default to them instead of nil.
2079 (server_accept_connection): Sentinels can't be nil any more.
2080 (read_and_dispose_of_process_output): New function, extracted from
2081 read_process_output.
2082 (read_process_output): Use it; filters can't be nil.
2083 (Finternal_default_process_filter): New function, extracted from
2084 read_process_output.
2085 (exec_sentinel_unwind): Remove function.
2086 (exec_sentinel): Don't zilch sentinel while running.
2087 (status_notify): Sentinels can't be nil.
2088 (Finternal_default_process_sentinel): New function extracted from
2089 status_notify.
2090 (setup_process_coding_systems): Default filter is not nil any more.
2091 (syms_of_process): Export new Elisp functions and initialize
2092 new constants.
2093 * lisp.h (make_lisp_proc): New function.
2094
5ac2eb34
SM
20952013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2096
2097 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2098
eda9c7d7
EZ
20992013-05-14 Eli Zaretskii <eliz@gnu.org>
2100
2101 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2102 unless we know that the window w is a leaf window.
2103 Another attempt at solving bug#14062.
eda9c7d7 2104
8fdeaad5
JD
21052013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2108 fdesc (Bug#14375).
2109
44aa9ee6
PE
21102013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 * image.c (gif_load): Check that subimages fit (Bug#14345).
2113
759fd763
SM
21142013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2115
2116 * lread.c (skip_dyn_eof): New function.
2117 (read1): Use it to skip the end of a file in response to #@00.
2118
2119 * doc.c (get_doc_string): Slightly relax the sanity checking.
2120
4465bfb4
JD
21212013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2122
2123 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2124 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2125 (MonitorInfo): New struct.
2126 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2127 (Fns_display_monitor_attributes_list): New functions.
2128 (display-usable-bounds): Remove.
2129 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2130 Qsource.
2131
7583e2a0
PE
21322013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2135 (GTK_CHECK_VERSION): New macro, if not already defined.
2136 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2137 replaced by GTK_CHECK_VERSION.
2138
ad75d77e
PE
21392013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 * xterm.h (GTK_PREREQ): New macro.
2142 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2143 to use this macro instead, for consistency and clarity.
2144
07525f77
EZ
21452013-05-08 Eli Zaretskii <eliz@gnu.org>
2146
2147 * xdisp.c (row_for_charpos_p): New function, with code of
2148 cursor_row_p, but accepts an additional argument CHARPOS instead
2149 of using a hardcoded PT.
2150 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2151 (row_containing_pos): Call row_for_charpos_p instead of partially
2152 doing the same. Fixes cursor positioning under longlines-mode
2153 when longlines-show-effect includes more than one newline, when
2154 moving the cursor vertically up.
2155
d901fc8d
JB
21562013-05-08 Juanma Barranquero <lekktu@gmail.com>
2157
2158 * makefile.w32-in (ACL_H): New macro.
2159 ($(BLD)/fileio.$(O)): Update dependencies.
2160
f269bc61
PE
21612013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2162
e7b41c4c 2163 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2164 * Makefile.in (LIB_ACL): New macro.
2165 (LIBACL_LIBS): Remove.
2166 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2167 * fileio.c: Include <acl.h>.
2168 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2169 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2170 !acl_errno_valid.
2171 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2172 it ourselves.
2173
f269bc61
PE
2174 * unexelf.c: Don't assume ElfW (Half) fits in int.
2175 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2176 when dealing with ElfW (Half) values, since they can exceed 2**31
2177 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2178 (entry_address): Omit unused NUM arg. All uses changed.
2179
a261c53e
JL
21802013-05-07 Juri Linkov <juri@jurta.org>
2181
2182 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2183 to the string converted from number with `Fnumber_to_string'.
2184 (Bug#14254)
2185
2b66427d
PE
21862013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2189 This fixes a problem introduced by my previous change.
2190
15acfe41
GM
21912013-05-07 Glenn Morris <rgm@gnu.org>
2192
2193 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2194
5ea03bf5
JD
21952013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2196
2197 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2198
e0c9d565
PE
21992013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 Static checking by GCC 4.8.0.
2202 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2203 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2204 (x_get_monitor_attributes_fallback)
2205 (x_get_monitor_attributes_xinerama)
2206 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2207 Define only if USE_GTK.
2208 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2209 (x_get_monitor_attributes_fallback): Omit unused locals.
2210 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2211 Use double, not float, to avoid mixed-mode floating point arithmetic.
2212
4e3f9230
YM
22132013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2214 Jan Djärv <jan.h.d@swipnet.se>
2215
2216 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2217 (XINERAMA_CFLAGS): New macros.
2218 (ALL_CFLAGS, LIBES): Use them.
2219
2220 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2221 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2222 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2223 (syms_of_xfns): DEFSYM them.
2224 (struct MonitorInfo): New struct.
2225 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2226 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2227 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2228 (x_get_monitor_attributes_xinerama): New functions.
2229 (Fx_display_monitor_attributes_list): New primitive.
2230 (syms_of_xfns): Defsubr it.
2231
2232 * xterm.h (x_display_info): Add Xatom_net_workarea and
2233 Xatom_net_current_desktop.
2234
2235 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2236 and dpyinfo->Xatom_net_current_desktop.
2237
05839b6a
EZ
22382013-05-06 Eli Zaretskii <eliz@gnu.org>
2239
2240 * xdisp.c (pos_visible_p): Use the special code for finding the
2241 beginning of a display property or overlay for any "replacing"
2242 display property, not just for display strings. This solves
2243 incorrect reporting of position by posn-at-point. (Bug#14241)
2244
dc4a2ee0
PE
22452013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2246
5ee94506
PE
2247 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2248 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2249 Verify that ElfW (Half) fits in int.
2250 (fatal): Use same signature as lisp.h.
2251 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2252 configure and build with -DUNEXELF_DEBUG without worrying about
2253 other modules that use DEBUG.
2254 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2255 possibly-wide integers now uses it instead of plain fprintf.
2256 (entry_address): New function, which avoids problems with 32-bit
2257 overflow on 64-bit hosts.
2258 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2259 (round_up): Don't assume the remainder fits in int.
2260 (find_section): Use bool for boolean. Simplify debug code.
2261 (unexec): Don't assume file sizes fit in int or size_t.
2262 Omit unnecessary trailing newline in 'fatal' format.
2263 Use strerror rather than outputting decimal error number.
2264 Remove unused code when emacs is not defined;
2265 this file relies on Emacs now.
2266 Don't assume e_phnum and e_shnum are positive.
2267
dc4a2ee0
PE
2268 * regex.c: Fix problems when DEBUG is defined.
2269 (extract_number, extract_number_and_incr): Define regardless of
2270 whether DEBUG is defined; that's simpler and makes the code less
2271 likely to go stale in the normal case when DEBUG is not defined.
2272 Return int rather than taking an int * arg. All callers changed.
2273 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2274 Remove, replacing with ...
2275 (DEBUG_PRINT): New macro. All callers changed.
2276 (DEBUG_COMPILES_ARGUMENTS): New macro.
2277 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2278 (print_compiled_pattern, print_double_string) [DEBUG]:
2279 Use prototype rather than old-style definition.
2280 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2281 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2282 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2283 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2284 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2285 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2286 This matters only when DEBUG is defined.
2287
14c7ed05
EZ
22882013-05-05 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (set_iterator_to_next): Set the
2291 ignore_overlay_strings_at_pos_p flag only if we are _really_
2292 iterating over an overlay string, as indicated by the
2293 current.overlay_string_index member. (Bug#14306)
2294
e6076b1b
JD
22952013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2296
2297 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2298 to where it is used, to avoid autorelease issues (Bug#14050).
2299
cbee2131
PE
23002013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2301
2302 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2303 * fileio.c (syms_of_fileio): Implement this.
2304 * filelock.c (create_lock_file): If symbolic links don't work, so
2305 we use a regular file as a lock file, do not fsync the lock file;
2306 it's not needed.
2307
30c7e542
SM
23082013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2309
2310 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2311 (syms_of_minibuf): Adjust accodingly.
2312 * lread.c (Fread):
2313 * callint.c (Fcall_interactively): Adjust calls accordingly.
2314
5bebd186
EZ
23152013-05-04 Eli Zaretskii <eliz@gnu.org>
2316
2317 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2318 w->contents is a buffer before computing everything else.
2319 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2320
2321 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2322 assertion violations. (Bug#14062)
2323
0fb0a4f3
DR
23242013-05-01 David Reitter <david.reitter@gmail.com>
2325
2326 * nsfns.m (ns_tooltip): Initialize.
2327
9e63b4a5
EZ
23282013-04-28 Eli Zaretskii <eliz@gnu.org>
2329
2330 * coding.c (decode_coding_gap): Don't remove the character before
2331 a newline unless it's a CR character. (Bug#14287)
2332
ad60824e
DN
23332013-04-28 Dan Nicolaescu <dann@gnu.org>
2334
2335 * dispextern.h (struct face): Move enum face_underline_type
2336 earlier so that bitfields can be in the same word.
2337
edbdcec0
JD
23382013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2339
2340 * nsfns.m (handlePanelKeys): New function.
2341 (EmacsOpenPanel:performKeyEquivalent:)
2342 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
2343 arrows/function/control and copy/paste keys (Bug#14296).
2344
0208ede7
JL
23452013-04-27 Juri Linkov <juri@jurta.org>
2346
2347 * callint.c (Fcall_interactively): Call `Qread_number' for
2348 interactive code letter `n' instead of using duplicate code.
2349 (Bug#14254)
2350
b8dd59f7
PE
23512013-04-27 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * systime.h (make_timeval): Declare as 'const'.
2354
8bd722db
KH
23552013-04-27 Kenichi Handa <handa@gnu.org>
2356
2357 * font.c (font_open_entity): Always open a font of manageable
2358 size.
2359
13d0e56f 23602013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 2361
f780d632
PE
2362 Port better to AIX (Bug#14258).
2363 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
2364 to pacify AIX xlc.
2365
ec509856
KH
23662013-04-24 Kenichi Handa <handa@gnu.org>
2367
2368 * coding.c (decode_coding_iso_2022): When an invalid escape
2369 sequence is encountered, reset the invocation and designation
2370 status to the safest one.
2371
84fc48e5
PE
23722013-04-22 Paul Eggert <eggert@cs.ucla.edu>
2373
2374 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
2375 Without this fix, "make distclean" leaves stamp-h1 behind.
2376
806bda47
EC
23772013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
2378
2379 * w32fns.c (w32_fullscreen_rect): New function to compute the
2380 window rectangle for the given fullscreen mode.
2381 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
2382 longer tunes the window size. This keeps the window's edges flush
2383 with the screen and allows the taskbar to hide itself in fullboth.
2384
2385 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
2386 window decorations and uses the entire screen.
2387
2388 * w32term.h (w32_fullscreen_rect) Add prototype.
2389 (struct w32_output): Replace normal_width, normal_height,
2390 normal_top, and normal_left members with a single normal_placement
2391 struct.
2392 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
2393 Remove macros.
2394 (FRAME_NORMAL_PLACEMENT): New macro.
2395
9cc2810b
JB
23962013-04-16 Juanma Barranquero <lekktu@gmail.com>
2397
2398 * minibuf.c (Ftest_completion): Silence compiler warning.
2399
fd16b54c
EZ
24002013-04-15 Eli Zaretskii <eliz@gnu.org>
2401
2402 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 2403 bug#14062.
fd16b54c
EZ
2404
2405 * frame.h (WINDOW_FRAME): Protect macro and its argument with
2406 parentheses.
2407
2408 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
2409 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
2410 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
2411 parentheses where appropriate.
2412
9e3379a0
PE
24132013-04-14 Paul Eggert <eggert@cs.ucla.edu>
2414
2415 * keyboard.c (timer_start_idle): Remove no-longer-used local.
2416
ddd6b685
EZ
24172013-04-14 Eli Zaretskii <eliz@gnu.org>
2418
2419 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
2420 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
2421 Mention in the doc string that setting these variables takes
2422 effect only after a call to set-window-buffer. (Bug#14200)
2423
29b79ba1
EZ
24242013-04-13 Eli Zaretskii <eliz@gnu.org>
2425
2426 * indent.c (Fvertical_motion): Don't consider display strings on
2427 overlay strings as display strings on the buffer position we
2428 started from. This prevents vertical cursor motion from jumping
2429 more than one line when there's an overlay string with a display
2430 property at end of line.
2431 Reported by Karl Chen <Karl.Chen@quarl.org> in
2432 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
2433
562c6ee9
SM
24342013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
2435
2436 * window.c (select_window): `record_buffer' even if window is
2437 already selected (bug#14191).
2438
fcc1fe85
EZ
24392013-04-11 Eli Zaretskii <eliz@gnu.org>
2440
2441 * window.c (Fwindow_end): Test more flags, including the buffer's
2442 last_overlay_modified flag, to determine whether the window's
2443 display is really up-to-date. Prevents the function from
2444 returning a stale value. (Bug#14170)
2445 (Fwindow_line_height): Fix the test for up-to-date-ness of the
2446 current matrix.
2447
f009190a
EZ
24482013-04-10 Eli Zaretskii <eliz@gnu.org>
2449
2450 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
2451 garbaged only if it is not already the top frame on its TTY.
2452 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
2453 there are GUI frames open in the same session. (Bug#13864)
2454
78ce603d
SM
24552013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
2456
2457 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
2458 of marking the idle timers directly.
2459
a8036e40
SM
24602013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
2461
2462 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
2463 tables (bug#14054).
2464
7ffe7ef6
SM
24652013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
2466
2467 * window.c (select_window): Don't record_buffer while the invariant is
2468 temporarily broken (bug#14161).
2469
2470 * fns.c (Fdelq): Don't assume !NILP => CONSP.
2471
7d9f6883
EZ
24722013-04-07 Eli Zaretskii <eliz@gnu.org>
2473
2474 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
2475
5406cfd9
RF
24762013-04-07 Romain Francoise <romain@orebokech.com>
2477
2478 Ignore additional platform-specific ACL errors (Bug#13702).
2479 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
2480 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
2481
95c0e83b
JD
24822013-03-31 Jan Djärv <jan.h.d@swipnet.se>
2483
2484 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
2485 f->output_data.ns.
2486
876da980
PE
24872013-04-07 Paul Eggert <eggert@cs.ucla.edu>
2488
2489 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
2490 This bug was introduced by my 2013-02-25 change that simplified
2491 data_start configuration. Without this change, on GNU/Linux
2492 an Emacs configured with --enable-profiling fails immediately
2493 due to a profiler signal.
2494 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
2495 with these flags. On platforms where special flags are needed
2496 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
2497 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
2498 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
2499
7452b7bd
DA
25002013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
2501
2502 Get rid of some platform-specific functions examining window
2503 system and its capabilities. This is a partial rework of the
2504 2013-04-05 change.
2505 * lisp.h (have_menus_p): Remove prototype. This function is
2506 replaced with platform-independent window_system_available.
2507 (check_window_system): Move to...
2508 * frame.h (decode_window_system_frame, window_system_available):
2509 ...here, add new prototypes.
2510 * frame.c (window_system_available, decode_window_system_frame):
2511 New functions.
2512 (check_window_system): Platform-independent now.
2513 * xterm.h (x_in_use): Remove declaration.
2514 (check_x_frame):
2515 * w32term.h (check_x_frame):
2516 * nsterm.h (check_x_frame): Remove prototypes. This function
2517 is replaced with platform-independent decode_window_system_frame.
2518 * msdos.c (have_menus_p): Remove.
2519 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
2520 Remove platform-specific functions. Use check_window_system,
2521 decode_window_system_frame and check_ns_display_info where
2522 appropriate. Minor style and comment tweaks.
2523 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
2524 (check_x_frame): Likewise.
2525 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
2526 Likewise.
2527 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
2528 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
2529 * xmenu.c, xselect.c: All related users changed.
2530
251e9147
KH
25312013-04-03 Kenichi Handa <handa@gnu.org>
2532
2533 The following changes is to optimize the code for reading UTF-8
2534 files.
2535
562c6ee9 2536 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
2537 changed. Check EOL format. Do not call adjust_coding_eol_type
2538 here.
2539 (check_utf_8): New function.
2540 (adjust_coding_eol_type): Do nothing if already adjusted.
2541 (detect_coding): Compare the return value of check_ascii with
2542 coding->src_bytes. Call adjust_coding_eol_type if necessary.
2543 (decode_coding_gap): Optimize for valid UTF-8.
2544
8bc369d4
KH
25452013-03-21 Kenichi Handa <handa@gnu.org>
2546
2547 * coding.c (syms_of_coding): Cancel previous change.
2548
2549 * insdel.c (insert_from_gap): Fix previous change.
2550
73931ad1
DA
25512013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
2552
2553 Consistently use platform-specific function to detect window system.
2554 * lisp.h (check_window_system): New prototype. This function is
2555 going to replace check_x, check_w32 and check_ns.
2556 (have_menus_p): Mention msdos.c in comment.
2557 * fontset.c (check_window_system_func): Remove. Adjust all users.
2558 * fontset.h (check_window_system_func): Remove prototype.
2559 * nsterm.h (check_ns):
2560 * xterm.h (check_x):
2561 * w32term.h (check_w32): Likewise.
2562 * menu.c (Fx_popup_menu): Use check_window_system.
2563 * msdos.c (check_window_system): Define for MS-DOS.
2564 * nsfns.m (check_window_system): Define for NS. Adjust all users.
2565 * w32fns.c (check_window_system): Likewise for MS-Windows.
2566 * xfns.c (check_window_system): Likewise for X.
2567 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
2568 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
2569
7216e43b
PE
25702013-04-02 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 Prefer < to > in range checks such as 0 <= i && i < N.
2573 This makes it easier to visualize quantities on a number line.
2574 This patch doesn't apply to all such range checks,
2575 only to the range checks affected by the 2013-03-24 change.
2576 This patch reverts most of the 2013-03-24 change.
2577 * alloc.c (xpalloc, Fgarbage_collect):
2578 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
2579 * character.c (string_escape_byte8):
2580 * charset.c (read_hex):
2581 * data.c (cons_to_unsigned):
2582 * dispnew.c (update_frame_1):
2583 * doc.c (Fsubstitute_command_keys):
2584 * doprnt.c (doprnt):
2585 * editfns.c (hi_time, decode_time_components):
2586 * fileio.c (file_offset):
2587 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2588 * font.c (font_intern_prop):
2589 * frame.c (x_set_alpha):
2590 * gtkutil.c (get_utf8_string):
2591 * indent.c (check_display_width):
2592 * keymap.c (Fkey_description):
2593 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
2594 * lread.c (read1):
2595 * minibuf.c (read_minibuf_noninteractive):
2596 * process.c (wait_reading_process_output):
2597 * search.c (Freplace_match):
2598 * window.c (get_phys_cursor_glyph):
2599 * xdisp.c (redisplay_internal):
2600 * xsmfns.c (smc_save_yourself_CB):
2601 Prefer < to > for range checks.
2602 * dispnew.c (sit_for): Don't mishandle NaNs.
2603 This fixes a bug introduced in the 2013-03-24 change.
2604 * editfns.c (decode_time_components): Don't hoist comparison.
2605 This fixes another bug introduced in the 2013-03-24 change.
2606
92759988
DA
26072013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
2608
2609 * frame.h (struct frame): Drop scroll_bottom_vpos
2610 member becaue all real users are dead long ago.
2611 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
2612 * xdisp.c (redisplay_internal): Adjust user.
2613
9a1971bb
GM
26142013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
2615
f38ab167
JD
2616 * nsmenu.m (showAtX:Y:for:): setLevel to
2617 NSPopUpMenuWindowLevel (Bug#13998).
2618
6d01f1fe
JD
26192013-03-30 Jan Djärv <jan.h.d@swipnet.se>
2620
2621 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
2622 (ns_check_pending_open_menu): Declare.
2623
2624 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
2625 (x_activate_menubar): Update the menu with title that matches
2626 ns_get_pending_menu_title, and call
2627 ns_check_pending_openmenu (Bug#12698).
2628 (menuWillOpen:): New method.
2629 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
2630
2631 * nsterm.m (menu_will_open_state, menu_mouse_point)
2632 (menu_pending_title): New varaibles.
2633 (ns_get_pending_menu_title, ns_check_menu_open)
2634 (ns_check_pending_open_menu): New functions.
2635
781f4782
DA
26362013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
2637
2638 * indent.c (current_column_bol_cache): Remove leftover which is not
2639 used in Fmove_to_column any more.
2640 (current_column, scan_for_column): Adjust users.
2641 * keyboard.c (last_point_position_buffer, last_point_position_window):
2642 Remove leftovers which are not used for recording undo any more.
2643 (command_loop_1, syms_of_keyboard): Adjust users.
2644 * xdisp.c (last_max_ascent): Remove leftover which is not used in
2645 redisplay_window any more.
2646 (move_it_to): Adjust user.
2647
1921c31b
JB
26482013-03-29 Juanma Barranquero <lekktu@gmail.com>
2649
2650 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
2651 Update dependencies.
2652
717b8bcd
SM
26532013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2654
2655 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
2656 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
2657 forward references.
2658
e74aeda8
DA
26592013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2660
2661 * window.h (struct window): Replace hchild, vchild and buffer slots
2662 with the only contents slot. This is possible because each valid
2663 window may have either the child window (in vertical or horizontal
2664 combination) or buffer to display (for the leaf window). Using that,
2665 a lof of operations to traverse and/or change window hierarchies may
2666 be simplified. New member horizontal is used to distinguish between
2667 horizontal and vertical combinations of internal windows.
2668 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
2669 (WINDOW_VERTICAL_COMBINATION_P): New macros.
2670 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
2671 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
2672 Use contents slot, not buffer, where appropriate.
2673 (wset_combination): New function.
2674 (wset_buffer): Add eassert.
2675 (Fframe_first_window): Simplify the loop reaching first window.
2676 (Fwindow_buffer): Use WINDOW_LEAF_P.
2677 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
2678 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
2679 (unshow_buffer): Convert initial debugging check to eassert.
2680 (replace_window, recombine_windows, Fdelete_other_windows_internal)
2681 (make_parent_window, window_resize_check, window_resize_apply)
2682 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
2683 (Fset_window_configuration, delete_all_child_windows, save_window_save):
2684 Adjust to match struct window changes.
2685 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
2686 (mark_window_cursors_off, count_windows, get_leaf_windows)
2687 (foreach_window_1): Simplify the loop.
2688 * alloc.c (mark_object): Do not check for the leaf window because
2689 internal windows has no glyph matrices anyway.
2690 * dispnew.c (clear_window_matrices, showing_window_margins_p)
2691 (allocate_matrices_for_window_redisplay, fake_current_matrices)
2692 (allocate_matrices_for_frame_redisplay, free_window_matrices)
2693 (build_frame_matrix_from_window_tree, mirror_make_current)
2694 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
2695 (update_window_tree, set_window_update_flags): Simplify the loop.
2696 (sync_window_with_frame_matrix_rows): Enforce live window.
2697 Use contents slot, not buffer, where appropriate.
2698 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
2699 and WINDOW_HORIZONTAL_COMBINATION_P.
2700 (make_frame_visible_1): Simplify the loop.
2701 Use contents slot, not buffer, where appropriate.
2702 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
2703 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
2704 (expose_window_tree): Likewise.
2705 Use contents slot, not buffer, where appropriate.
2706 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
2707 to avoid deleted windows. Use contents slot instead of buffer.
2708 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
2709 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
2710 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
2711 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
2712
121ab1cd
EZ
27132013-03-28 Eli Zaretskii <eliz@gnu.org>
2714
ef454cf7
EZ
2715 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
2716 identify the reasons for assertion violations in bug#14062 and
2717 similar ones.
21e930f8
EZ
2718 (Fx_show_tip): Fix compilation error under
2719 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 2720
121ab1cd
EZ
2721 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
2722 Reported by <rzl24ozi@gmail.com>.
2723
5c89ca24
DA
27242013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2725
2726 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
2727 start marker...
562c6ee9
SM
2728 (unwind_with_echo_area_buffer): ...to restore it here.
2729 This is needed to ensure that...
5c89ca24
DA
2730 (redisplay_window): ...both window markers are valid here,
2731 which is verified by eassert.
2732 * editfns.c (save_excursion_save): Do not assume that
2733 selected_window always displays the buffer.
c7f53895
DA
2734 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
2735 Fix comment.
5c89ca24 2736
f557c1b1
SM
27372013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
2738
2739 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
2740 the upcase table.
2741
40693bba 27422013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
2743
2744 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
2745
c86f791f
EZ
27462013-03-27 Eli Zaretskii <eliz@gnu.org>
2747
2748 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
2749 since MinGW's w32api headers do. This avoids compiler warnings.
2750
2751 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
2752 if already defined.
2753
c6e72e17
EZ
27542013-03-26 Eli Zaretskii <eliz@gnu.org>
2755
2756 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
2757
54e95010
JD
27582013-03-26 Jan Djärv <jan.h.d@swipnet.se>
2759
2760 * gtkutil.c (style_changed_cb): Check if frame is live and an
2761 X frame (Bug#14038).
2762
b88b62de
EZ
27632013-03-26 Eli Zaretskii <eliz@gnu.org>
2764
a18d7de6
EZ
2765 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
2766 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
2767 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
2768 MinGW64.
8f5e14c8
EZ
2769 Move inclusion of time.h before sys/time.h, so that MinGW64 could
2770 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 2771
b88b62de
EZ
2772 Fix incompatibilities between MinGW.org and MinGW64 headers.
2773 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
2774
2775 * w32.c (REPARSE_DATA_BUFFER): Guard with
2776 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
2777
c074e458
JD
27782013-03-25 Jan Djärv <jan.h.d@swipnet.se>
2779
2780 * xterm.c: Include X11/XKBlib.h
2781 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
2782
908589fd
AS
27832013-03-24 Andreas Schwab <schwab@linux-m68k.org>
2784
2785 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
2786 written backwards.
2787 * blockinput.h (input_blocked_p): Likewise.
2788 * bytecode.c (exec_byte_code): Likewise.
2789 * callproc.c (call_process_kill, call_process_cleanup)
2790 (Fcall_process): Likewise.
2791 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
2792 (Fccl_execute_on_string): Likewise.
2793 * character.c (string_escape_byte8): Likewise.
2794 * charset.c (read_hex): Likewise.
2795 * cm.c (calccost): Likewise.
2796 * data.c (cons_to_unsigned): Likewise.
2797 * dired.c (directory_files_internal, file_name_completion):
2798 Likewise.
2799 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
2800 (sit_for): Likewise.
2801 * doc.c (Fsubstitute_command_keys): Likewise.
2802 * doprnt.c (doprnt): Likewise.
2803 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
2804 * emacsgtkfixed.c: Likewise.
2805 * fileio.c (file_offset, Fwrite_region): Likewise.
2806 * floatfns.c (Fexpt, fmod_float): Likewise.
2807 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2808 Likewise.
2809 * font.c (font_intern_prop): Likewise.
2810 * frame.c (x_set_alpha): Likewise.
2811 * gtkutil.c (get_utf8_string): Likewise.
2812 * indent.c (check_display_width): Likewise.
2813 * intervals.c (create_root_interval, rotate_right, rotate_left)
2814 (split_interval_right, split_interval_left)
2815 (adjust_intervals_for_insertion, delete_node)
2816 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2817 (merge_interval_right, merge_interval_left, copy_intervals)
2818 (set_intervals_multibyte_1): Likewise.
2819 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
2820 * keymap.c (Fkey_description): Likewise.
2821 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
2822 * lread.c (openp, read_integer, read1, string_to_number):
2823 Likewise.
2824 * menu.c (ensure_menu_items): Likewise.
2825 * minibuf.c (read_minibuf_noninteractive): Likewise.
2826 * print.c (printchar, strout): Likewise.
2827 * process.c (create_process, Faccept_process_output)
2828 (wait_reading_process_output, read_process_output, send_process)
2829 (wait_reading_process_output): Likewise.
2830 * profiler.c (make_log, handle_profiler_signal): Likewise.
2831 * regex.c (re_exec): Likewise.
2832 * regex.h: Likewise.
2833 * search.c (looking_at_1, Freplace_match): Likewise.
2834 * sysdep.c (get_child_status, procfs_ttyname)
2835 (procfs_get_total_memory): Likewise.
2836 * systime.h (EMACS_TIME_VALID_P): Likewise.
2837 * term.c (dissociate_if_controlling_tty): Likewise.
2838 * window.c (get_phys_cursor_glyph): Likewise.
2839 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
2840 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
2841 Likewise.
2842 * xfns.c (Fx_window_property): Likewise.
2843 * xmenu.c (set_frame_menubar): Likewise.
2844 * xselect.c (x_get_window_property, x_handle_dnd_message):
2845 Likewise.
2846 * xsmfns.c (smc_save_yourself_CB): Likewise.
2847 * xterm.c (x_scroll_bar_set_handle): Likewise.
2848
2bf7d27a
DA
28492013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
2850
2851 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
2852 to be optional or nil. Adjust comment and convert it to docstring.
2853 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
2854 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
2855
a9ebfa0b
PE
28562013-03-24 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 Static checking by GCC 4.8-20130319.
2859 * image.c (gif_load): Assume pass < 3 to pacify GCC.
2860 * process.c (Fset_process_datagram_address)
2861 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
2862 * xdisp.c (get_char_face_and_encoding):
2863 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
2864 (get_glyph_face_and_encoding): Prepare face before possibly using it.
2865 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
2866
4f3576ee
KB
28672013-03-24 Ken Brown <kbrown@cornell.edu>
2868
789b5e9a
KB
2869 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
2870 fix compilation on 64-bit Cygwin, where underscores are not
2871 automatically prepended.
2872
4f3576ee
KB
2873 * w32term.c (w32_initialize): Silence compiler warning.
2874
b5b7745f
EZ
28752013-03-23 Eli Zaretskii <eliz@gnu.org>
2876
cdc0d0bd
EZ
2877 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
2878 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
2879 variables, to save and restore frame dimensions.
2880 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
2881 after returning from a 'fullscreen' configuration.
2882 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
2883 to avoid races between the main thread and the input thread.
2884
2885 * w32term.h (struct w32_output): New members normal_width,
2886 normal_height, normal_top, normal_left, and prev_fsmode.
2887 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
2888 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
2889 members of a frame.
2890
b5b7745f
EZ
2891 * w32term.c (w32fullscreen_hook): Record last value of the frame's
2892 'fullscreen' parameter. Always record previous width and height
2893 of the frame, except when switching out of maximized modes, so
2894 that they could be restored correctly, instead of resetting to the
2895 default frame dimensions. Send SC_RESTORE command to the frame,
2896 unless we are going to send SC_MAXIMIZE, to restore the frame
2897 resize hints in the mouse pointer shown by the window manager.
2898 (Bug#14032)
2899
2900 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
2901
2902 * lisp.h (get_frame_param): Adjust conditions for prototype
2903 declaration.
2904
a3454eed
KB
29052013-03-22 Ken Brown <kbrown@cornell.edu>
2906
2907 * unexcw.c: Drop unneeded inclusion of w32common.h.
2908 (report_sheap_usage): Declare.
2909 (read_exe_header): Add magic numbers for x86_64.
2910 (fixup_executable): Fix printf format specifier for unsigned long
2911 argument.
2912
5a49b79c
DA
29132013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
2914
2915 * frame.h (struct frame): Put menu_bar_window under #ifdef
2916 because this member is not needed when X toolkit is in use.
2917 (fset_menu_bar_window):
2918 * dispnew.c (clear_current_matrices, clear_desired_matrices)
2919 (free_glyphs, update_frame):
2920 * xdisp.c (expose_frame): Likewise.
2921 (display_menu_bar): Likewise. Remove redundant eassert.
2922 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
2923 toolkit is in use.
2924
d6723bf7
PE
29252013-03-21 Paul Eggert <eggert@cs.ucla.edu>
2926
7b1123d8
PE
2927 Use functions and constants to manipulate Lisp_Save_Value objects.
2928 This replaces code that used macros and strings and token-pasting.
2929 The change makes the C source a bit easier to follow,
2930 and shrinks the Emacs executable a bit.
2931 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
2932 (make_save_value): Change 1st arg from string to enum. All callers
2933 changed.
2934 (INTX): Remove.
2935 (mark_object): Use if, not #if, for GC_MARK_STACK.
2936 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
2937 (XSAVE_OBJECT): Now functions, not macros.
2938 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
2939 the constant was never used.
2940 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
2941 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
2942 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
2943 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
2944 New constants.
2945 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
2946 type3 with a single member save_type. All uses changed.
2947 (save_type, set_save_pointer, set_save_integer): New functions.
2948 * print.c (PRINTX): Remove.
2949
d6723bf7
PE
2950 * alloc.c: Remove redundant static declarations.
2951
5f24fa51
DA
29522013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
2953
2954 * window.h (struct window): Convert left_col, top_line, total_lines
2955 and total_cols from Lisp_Objects to integers. Adjust comments.
2956 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
2957 Remove.
2958 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
2959 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
2960 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
2961 Adjust users where appropriate.
2962
42143acd
DA
29632013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
2964
2965 * frame.h (struct frame): Drop resx and resy because the same data is
2966 available from window system-specific output context. Adjust users.
562c6ee9
SM
2967 (default_pixels_per_inch_x, default_pixels_per_inch_y):
2968 New functions to provide defaults when no window system available.
42143acd 2969 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 2970 (NUMVAL): Move from xdisp.c.
42143acd
DA
2971 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
2972 (Ffont_face_attributes, Fopen_font):
2973 * image.c (gs_load):
2974 * w32font.c (fill_in_logfont):
2975 * xdisp.c (calc_pixel_width_or_height):
2976 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
2977 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
2978
c0a17406
KH
29792013-03-20 Kenichi Handa <handa@gnu.org>
2980
2981 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
2982 to 1 (temporary workaround until a bug related to ASCII
2983 optimization is fixed).
2984
095d384d
DA
29852013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
2986
2987 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
2988 Signal error if window is not internal. Adjust docstring.
2989 (delete_all_child_windows): Use combination_limit to save the buffer.
2990 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
2991 * print.c (syms_of_print): Initialize debugging output not here...
2992 (init_print_once): ...but in a new function here.
2993 * lisp.h (init_print_once): Add prototype.
2994 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 2995
748fa866
DA
29962013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
2997
2998 * window.c (window_resize_check, window_resize_apply)
2999 (window_from_coordinates, recombine_windows, set_window_buffer)
3000 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3001 (Fsplit_window_internal, Fdelete_window_internal)
3002 (freeze_window_starts): Use bool for booleans.
3003 * window.h (window_frame_coordinates, resize_frame_windows)
3004 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3005
81519fd2
SM
30062013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3007
3008 * dispnew.c (bitch_at_user): Use `user-error'.
3009
6db423a9
KB
30102013-03-17 Ken Brown <kbrown@cornell.edu>
3011
3012 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3013 as return type of image_background. (Bug#13981)
3014 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3015
8f2906f5
JD
30162013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3017
960ce480 3018 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3019 (ns_select): Don't return with result uninitialized.
960ce480 3020
8f2906f5
JD
3021 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3022 and getDirectory.
3023
81519fd2
SM
3024 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3025 New functions.
8f2906f5
JD
3026 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3027 directories. If filename is nil, get directory name (Bug#13932).
3028 Use getFilename and getDirectory.
3029 (getFilename, getDirectory): New methods for EmacsSavePanel and
3030 EmacsOpenPanel.
3031 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3032
cded56c1
PE
30332013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3036
251e9147 30372013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3038
3039 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3040 (adjust_after_replace): Make it back to static. Delete the third
3041 arg text_at_gap_tail. Cancel the code for handling it.
3042
3043 * coding.h (struct coding_system): New member eol_seen.
3044
3045 * coding.c (detect_ascii): New function.
3046 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3047 when the source bytes are actually scanned. On detecting for
3048 coding_category_utf_8_auto, call detect_ascii instead of scanning
3049 source bytes directly.
3050 (produce_chars): Call insert_from_gap with the new arg 0.
3051 (encode_coding): Likewise.
3052 (decode_coding_gap): Control ASCII optimization by the variable
3053 disable_ascii_optimization instead of #ifndef .. #endif.
3054 Deccode EOL format according to coding->eol_seen.
3055 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3056 variable.
3057
8a44e6d1
KH
3058 * lisp.h (adjust_after_replace): Cancel externing it.
3059 (insert_from_gap): Adjust prototype.
3060
5f795e34
EZ
30612013-03-15 Eli Zaretskii <eliz@gnu.org>
3062
3063 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3064 FULLSCREEN_MAXIMIZED. (Bug#13935)
3065
f258b4be
DA
30662013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3067
3068 * region-cache.c (find_cache_boundary, move_cache_gap)
3069 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3070 Simplify debugging check and convert to eassert. Adjust comment.
3071 (pp_cache): Put under ENABLE_CHECKING.
3072
a5cc4dde
EZ
30732013-03-14 Eli Zaretskii <eliz@gnu.org>
3074
3075 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3076 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3077 and WM_ACTIVATEAPP.
3078 (w32fullscreen_hook): If the frame is visible, reset
3079 f->want_fullscreen flag after changing the frame size. If the
3080 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3081 (Bug#13953)
3082
3fc5e44a
DC
30832013-03-13 Daniel Colascione <dancol@dancol.org>
3084
3085 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3086 too so that these builds can use Cygwin's file conversion
3087 functions. (We've been building and linking cygw32.o all along
3088 and just not using it.)
3089
47d7532e
PE
30902013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 File synchronization fixes (Bug#13944).
3093 * Makefile.in (LIB_FDATASYNC): New macro.
3094 (LIBES): Use it.
3095 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3096 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3097 Don't worry about HAVE_FSYNC, since a substitute fsync is
3098 available if the system lacks one.
3099 (Fwrite_regin): Retry fsync if interrupted.
3100
c7ffccaf
EZ
31012013-03-13 Eli Zaretskii <eliz@gnu.org>
3102
4e2df81d 3103 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3104 activated, call w32fullscreen_hook, to make sure the new frame
3105 dimensions are in effect. (Bug#13937)
3106
8a7debc1
DA
31072013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3108
3109 * xdisp.c (init_iterator): Simplify because both character and byte
3110 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3111 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3112 character and byte positions can be obtained from marker.
8a7debc1 3113
7fd8c501
PE
31142013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3115
d9df6f40
PE
3116 Static checking by Sun C 5.12.
3117 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3118 * bytecode.c (exec_byte_code):
3119 * dispnew.c (init_display):
3120 * eval.c (error):
3121 * fileio.c (Fsubstitute_in_file_name):
3122 * keyboard.c (Fevent_convert_list):
3123 * keymap.c (Fsingle_key_description):
3124 * term.c (maybe_fatal, fatal):
3125 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3126 * xsmfns.c (Fhandle_save_session):
3127 Omit unreachable code.
3128 * keymap.c (map_keymap_char_table_item): Cast void * to
3129 a function pointer type; the C Standard requires this.
3130
7fd8c501
PE
3131 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3132 Include <sys/param.h> unconditionally, as that works elsewhere and
3133 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3134 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3135 and FreeBSD now.
3136
a020afb9 3137See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3138
3139;; Local Variables:
3140;; coding: utf-8
aac0c6e3
MR
3141;; End:
3142
ab422c4d 3143 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3144
3145 This file is part of GNU Emacs.
3146
3147 GNU Emacs is free software: you can redistribute it and/or modify
3148 it under the terms of the GNU General Public License as published by
3149 the Free Software Foundation, either version 3 of the License, or
3150 (at your option) any later version.
3151
3152 GNU Emacs is distributed in the hope that it will be useful,
3153 but WITHOUT ANY WARRANTY; without even the implied warranty of
3154 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3155 GNU General Public License for more details.
3156
3157 You should have received a copy of the GNU General Public License
3158 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.