* lisp/vc/log-view.el (log-view-diff): Extract `log-view-diff-common',
[bpt/emacs.git] / src / ChangeLog
CommitLineData
84231434
DA
12013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
4 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
5 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
6 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
7 and mention nil frame in docstring.
84231434 8
959067a1
DA
92013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
10
11 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
12 (x_figure_window_size): Likewise. Adjust to return long.
13 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
14 (toplevel): Move Qterminal_live_p to...
15 * terminal.c (toplevel): ...here, make it static, and...
16 (syms_of_terminal): ...DEFSYM here.
17 * frame.h (Qterminal_live_p): Remove declaration.
18 (make_frame, x_figure_window_size): Adjust prototype.
19 * nsfns.m (Fx_create_frame): Use long for window flags.
20
f4b169ce
PE
212013-07-30 Paul Eggert <eggert@cs.ucla.edu>
22
23 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
24 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
25 Do not assume that emacs_close (INT_MAX) is a no-op.
26
bee6a2c7
DA
272013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
28
29 * xfaces.c (make_face_cache): For struct face_cache, prefer
30 xmalloc to xzalloc and so avoid redundant call to memset.
31 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
32
d7e6881a
DA
332013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
34
35 * fringe.c (draw_window_fringes, update_window_fringes)
36 (compute_fringe_widths):
37 * w32term.c (x_draw_glyph_string):
38 * window.c (candidate_window_p, Frecenter):
39 * xfaces.c (realize_basic_faces, realize_default_face)
40 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
41 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
42 * xfns.c (x_set_cursor_color, xic_free_xfontset):
43 * xmenu.c (Fx_menu_bar_open_internal):
44 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
45 * xsettings.c (xft_settings_event):
46 * xterm.c (x_draw_glyph_string, x_had_errors_p):
47 Use bool for booleans. Adjust style and comments where
48 appropriate.
49 * dispextern.h (draw_window_fringes, update_window_fringes)
50 (compute_fringe_widths):
51 * xterm.h (x_had_errors_p): Adjust prototype.
52
ec3058af
DA
532013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
54
55 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
56 CHECK_LIST. Rewrite the loop to avoid useless local variable.
57
218e0637
DA
582013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
59
60 * fns.c (toplevel): Remove comment before Fsafe_length because
61 it checks for QUIT.
62
e560aba9
PE
632013-07-28 Paul Eggert <eggert@cs.ucla.edu>
64
65 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
66
2e5ce5de
EZ
672013-07-28 Eli Zaretskii <eliz@gnu.org>
68
69 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
70 frame which got the message is still alive, before dereferencing
71 its pointer. (Bug#14970)
72
73 * frame.c (delete_frame): Test "this" frame's minibuffer window to
74 be a live window, before using it as such. (Bug#14970)
75
e95da6d3
EZ
762013-07-27 Eli Zaretskii <eliz@gnu.org>
77
78 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
79 w32_detect_focus_change instead of doing part of its job by hand.
80 This fixes the problem whereby FOCUS_OUT events were not sent to
81 the event queue.
82
a8f93651
EZ
832013-07-26 Eli Zaretskii <eliz@gnu.org>
84
fec92060
EZ
85 * process.c (Fprocess_list): Doc fix.
86
a8f93651
EZ
87 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
88 being re-exposed only if it didn't ask to become visible.
89 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
90 was previously iconified. (Bug#14841)
91 (x_iconify_frame): Mark the frame iconified.
92
d5a7a9d9
PE
932013-07-26 Paul Eggert <eggert@cs.ucla.edu>
94
95 Fix minor problems found by static checking.
96 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
97 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
98
56ea7291
SM
992013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * eval.c (set_specpdl_old_value): New function.
102 (unbind_to): Minor simplification.
103 (get_backtrace_frame): New function.
104 (Fbacktrace_frame): Use it. Add `base' argument.
105 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
106 (syms_of_eval): Export backtrace-eval.
107 * xterm.c (x_focus_changed): Simplify.
108
9d611ffe
PE
1092013-07-25 Paul Eggert <eggert@cs.ucla.edu>
110
111 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
112
999c74e3
EZ
1132013-07-24 Eli Zaretskii <eliz@gnu.org>
114
115 * xdisp.c (redisplay_window): Instead of moving point out of
116 scroll margin, reject the force_start method, and try scrolling
117 instead. (Bug#14780)
118
198fa217
KB
1192013-07-24 Ken Brown <kbrown@cornell.edu>
120
121 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
122 (Bug#14944).
123
53840e55
PE
1242013-07-24 Paul Eggert <eggert@cs.ucla.edu>
125
126 * eval.c (Fprogn): Do not check that BODY is a proper list.
127 This undoes the previous change. The check slows down the
128 interpreter, and is not needed to prevent a crash. See
129 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
130
60967f56
GM
1312013-07-23 Glenn Morris <rgm@gnu.org>
132
133 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
134
9ca960e2
PE
1352013-07-23 Paul Eggert <eggert@cs.ucla.edu>
136
a29c3e6d
PE
137 Port to GNU/Linux systems with tinfo but not ncurses.
138 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
139 to decide whether ncurses is being used. Without this change,
140 GCC complains about tgetent not being declared, on a system
141 that has tinfo installed but ncurses not installed.
142
f274311c
PE
143 * eval.c (Fprogn): Check that BODY is a proper list.
144
16b0520a
PE
145 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
146 * data.c (Fsetq_default):
147 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
148 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
149 (Fcondition_case):
150 Tune by taking advantage of the fact that ARGS is always a list
151 when a function is declared to have UNEVALLED args.
152
9ca960e2
PE
153 * emacsgtkfixed.c: Port to GCC 4.6.
154 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
155
afacaa1b
JB
1562013-07-23 Juanma Barranquero <lekktu@gmail.com>
157
158 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
159 here to silence compiler warnings.
160
368a85a4
PE
1612013-07-22 Paul Eggert <eggert@cs.ucla.edu>
162
163 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
164 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
165 from messing up Emacs's 'struct frame' (Bug#14923).
166
f4e891b5
PE
1672013-07-21 Paul Eggert <eggert@cs.ucla.edu>
168
169 * alloc.c (make_save_ptr_ptr): Define this function.
170 It was inadvertently omitted. It's needed only if
171 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
172
96c8b65e
JD
1732013-07-21 Jan Djärv <jan.h.d@swipnet.se>
174
175 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
176 frame have focus (Bug#14895).
177
ee010797
PE
1782013-07-21 Paul Eggert <eggert@cs.ucla.edu>
179
180 Avoid vfork-related deadlock more cleanly.
181 * callproc.c (child_setup): When the child's exec fails, output
182 the program name, as that's more useful. Use O_NONBLOCK to avoid
183 deadlock.
184 * process.c (create_process_1): Remove; no longer needed.
185 (create_process): Remove timer hack; no longer needed, now that
186 the child avoids deadlock.
187
f0398ec1 1882013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
189
190 * image.c (Fimage_flush): Fix doc typo.
191
b2a069c2
PE
1922013-07-20 Paul Eggert <eggert@cs.ucla.edu>
193
6496aec9
PE
194 Fix array bounds violation when pty allocation fails.
195 * process.c (PTY_NAME_SIZE): New constant.
196 (pty_name): Remove static variable; it's now auto.
197 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
198 Take pty_name as an arg rather than using a static variable.
199 All callers changed.
200 (create_process): Recover pty_flag from process, not from volatile local.
201 (create_pty): Stay inside array even when pty allocation fails.
202 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
203
b2a069c2
PE
204 * lread.c (Fload): Avoid initialization only when lint checking.
205 Mention that it's needed only for older GCCs.
206
99107004
KH
2072013-07-20 Kenichi Handa <handa@gnu.org>
208
209 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
210 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
211
6b1b199d
AS
2122013-07-20 Andreas Schwab <schwab@linux-m68k.org>
213
214 * lread.c (Fload): Avoid uninitialized warning.
215
4195afc3
PE
2162013-07-19 Paul Eggert <eggert@cs.ucla.edu>
217
3f5bef16
PE
218 Fix some minor file descriptor leaks and related glitches.
219 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
220 (create_lock_file): Use write, not emacs_write.
221 * image.c (slurp_file, png_load_body):
222 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
223 (server_accept_connection):
224 Don't leak an fd on memory allocation failure.
225 * image.c (slurp_file): Add a cheap heuristic for growing files.
226 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
227 as that's what the other routines do. Maybe input need not be
228 blocked at all, but it's better to be consistent.
229 Avoid undefined behavior when strlen is zero.
230
4195afc3
PE
231 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
232 (NSTATICS): Now a constant; doesn't need to be a macro.
233
a1aeeffe
RS
2342013-07-19 Richard Stallman <rms@gnu.org>
235
236 * coding.c (decode_coding_utf_8): Add simple loop for fast
237 processing of ASCII characters.
238
63b34baa
PE
2392013-07-19 Paul Eggert <eggert@cs.ucla.edu>
240
241 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
242
621dd9ac
EZ
2432013-07-19 Eli Zaretskii <eliz@gnu.org>
244
245 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
246 unportable 'struct x_display_info'.
247 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
248 is a portable type.
249
1396ac86
PE
2502013-07-19 Paul Eggert <eggert@cs.ucla.edu>
251
ab9980cd
PE
252 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
253 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
254 or fscanf fails.
255 (system_process_attributes): Prefer plain char to unsigned char
256 when either will do. Clean up properly if interrupted or if
257 memory allocations fail. Don't assume sscanf succeeds. Remove
258 no-longer-needed workaround to stop GCC from whining. Read
259 command-line once, instead of multiple times. Check read status a
260 bit more carefully.
261
1396ac86
PE
262 Fix obscure porting bug with varargs functions.
263 The code assumed that int is treated like ptrdiff_t in a vararg
264 function, which is not a portable assumption. There was a similar
265 -- though these days less likely -- porting problem with various
266 assumptions that pointers of different types all smell the same as
267 far as vararg functions is conserved. To make this problem less
268 likely in the future, redo the API to use varargs functions.
269 * alloc.c (make_save_value): Remove this vararg function.
270 All uses changed to ...
271 (make_save_int_int_int, make_save_obj_obj_obj_obj)
272 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
273 New functions.
274 (make_save_ptr): Rename from make_save_pointer, for consistency with
275 the above. Define only on platforms that need it. All uses changed.
276
4d19d194
PE
2772013-07-18 Paul Eggert <eggert@cs.ucla.edu>
278
279 * keyboard.c: Try to fix typos in previous change.
280 (DISPLAY_LIST_INFO): New macro.
281 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 282 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 283
945c5bb1
JB
2842013-07-18 Juanma Barranquero <lekktu@gmail.com>
285
286 * keyboard.c (kbd_buffer_get_event):
287 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
288 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
289
f4b1eb36
PE
2902013-07-18 Paul Eggert <eggert@cs.ucla.edu>
291
5e679a2c
PE
292 * filelock.c: Fix unlikely file descriptor leaks.
293 (get_boot_time_1): Rework to avoid using emacs_open.
294 This doesn't actually fix a leak, but is better anyway.
295 (read_lock_data): Use read, not emacs_read.
296
a8cd4836
PE
297 * doc.c: Fix minor memory and file descriptor leaks.
298 * doc.c (get_doc_string): Fix memory leak when doc file absent.
299 (get_doc_string, Fsnarf_documentation):
300 Fix file descriptor leak on error.
301
ef30e638
PE
302 * term.c: Fix minor fdopen-related file descriptor leaks.
303 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
304 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
305
f4b1eb36
PE
306 * charset.c: Fix file descriptor leaks and errno issues.
307 Include <errno.h>.
308 (load_charset_map_from_file): Don't leak file descriptor on error.
309 Use plain record_xmalloc since the allocation is larger than
310 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
311 of entries.
312 * eval.c (record_unwind_protect_nothing):
313 * fileio.c (fclose_unwind):
314 New functions.
315 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
316 The replacement doesn't block input, but that no longer seems
317 necessary.
318
b648c163
PE
3192013-07-17 Paul Eggert <eggert@cs.ucla.edu>
320
a0931322
PE
321 * lread.c: Fix file descriptor leaks and errno issues.
322 (Fload): Close some races that leaked fds or streams when 'load'
323 was interrupted.
324 (Fload, openp): Report error number of last nontrivial failure to open.
325 ENOENT counts as trivial.
326 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
327 New functions.
328 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
329 now that the function is always called with a nonnegative arg.
330 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
331 All uses replaced with ...
332 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
333
b648c163
PE
334 A few more minor file errno-reporting bugs.
335 * callproc.c (Fcall_process):
336 * doc.c (Fsnarf_documentation):
337 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
338 * process.c (set_socket_option):
339 Don't let a constructor trash errno.
340 * doc.c: Include <errno.h>.
341
b1dc4084
JB
3422013-07-16 Juanma Barranquero <lekktu@gmail.com>
343
344 * w32fns.c (unwind_create_tip_frame): Fix declaration.
345
c43843aa
PE
3462013-07-16 Paul Eggert <eggert@cs.ucla.edu>
347
50a30cce
PE
348 Fix w32 bug with call-process-region (Bug#14885).
349 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
350 to Fcall_process when the input is empty. This simplifies the
351 code a bit. It makes no difference on POSIXish platforms but
352 apparently it fixes a bug on w32.
353
354 Fix bug where insert-file-contents closes a file twice. (Bug#14839).
41d48a42
PE
355 * fileio.c (close_file_unwind): Don't close if FD is negative;
356 this can happen when unwinding a zapped file descriptor.
357 (Finsert_file_contents): Unwind-protect the fd before the point marker,
358 in case Emacs runs out of memory between the two unwind-protects.
359 Don't trash errno when closing FD.
360 Zap the FD in the specpdl when closing it, instead of deferring
361 the removal of the unwind-protect; this fixes a bug where a child
362 function unwinds the stack past us.
363
27e498e6
PE
364 New unwind-protect flavors to better type-check C callbacks.
365 This also lessens the need to write wrappers for callbacks,
366 and the need for make_save_pointer.
367 * alloca.c (free_save_value):
368 * atimer.c (run_all_atimers):
369 Now extern.
370 * alloc.c (safe_alloca_unwind):
371 * atimer.c (unwind_stop_other_atimers):
372 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
373 * menu.c (cleanup_popup_menu) [HAVE_NS]:
374 * minibuf.c (choose_minibuf_frame_1):
375 * process.c (make_serial_process_unwind):
376 * xdisp.h (pop_message_unwind):
377 * xselect.c (queue_selection_requests_unwind):
378 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
379 * alloca.c (record_xmalloc):
380 Prefer record_unwind_protect_ptr to record_unwind_protect with
381 make_save_pointer.
382 * alloca.c (Fgarbage_collect):
383 Prefer record_unwind_protect_void to passing a dummy.
384 * buffer.c (restore_buffer):
385 * window.c (restore_window_configuration):
386 * xfns.c, w32fns.c (do_unwind_create_frame)
387 New wrapper. All record-unwind uses of wrappee changed.
388 * buffer.c (set_buffer_if_live):
389 * callproc.c (call_process_cleanup, delete_temp_file):
390 * coding.c (code_conversion_restore):
391 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
392 * editfns.c (save_excursion_restore)
393 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
394 (save_restriction_restore):
395 * eval.c (restore_stack_limits, un_autoload):
396 * fns.c (require_unwind):
397 * keyboard.c (recursive_edit_unwind, tracking_off):
398 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
399 * macros.c (pop_kbd_macro, restore_menu_items):
400 * nsfns.m (unwind_create_frame):
401 * print.c (print_unwind):
402 * process.c (start_process_unwind):
403 * search.c (unwind_set_match_data):
404 * window.c (select_window_norecord, select_frame_norecord):
405 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
406 (fast_set_selected_frame):
407 * xfns.c, w32fns.c (unwind_create_tip_frame):
408 Return void, not a dummy Lisp_Object. All uses changed.
409 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
410 * callproc.c (call_process_kill):
411 * fileio.c (restore_point_unwind, decide_coding_unwind)
412 (build_annotations_unwind):
413 * insdel.c (Fcombine_after_change_execute_1):
414 * keyboard.c (read_char_help_form_unwind):
415 * menu.c (unuse_menu_items):
416 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
417 * sound.c (sound_cleanup):
418 * xdisp.c (unwind_redisplay):
419 * xfns.c (clean_up_dialog):
420 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
421 Accept no args and return void, instead of accepting and returning
422 a dummy Lisp_Object. All uses changed.
423 * cygw32.c (fchdir_unwind):
424 * fileio.c (close_file_unwind):
425 * keyboard.c (restore_kboard_configuration):
426 * lread.c (readevalllop_1):
427 * process.c (wait_reading_process_output_unwind):
428 Accept int and return void, rather than accepting an Emacs integer
429 and returning a dummy object. In some cases this fixes an
430 unlikely bug when the corresponding int is outside Emacs integer
431 range. All uses changed.
432 * dired.c (directory_files_internal_unwind):
433 * fileio.c (do_auto_save_unwind):
434 * gtkutil.c (pop_down_dialog):
435 * insdel.c (reset_var_on_error):
436 * lread.c (load_unwind):
437 * xfns.c (clean_up_file_dialog):
438 * xmenu.c, nsmenu.m (pop_down_menu):
439 * xmenu.c (cleanup_widget_value_tree):
440 * xselect.c (wait_for_property_change_unwind):
441 Accept pointer and return void, rather than accepting an Emacs
442 save value encapsulating the pointer and returning a dummy object.
443 All uses changed.
444 * editfns.c (Fformat): Update the saved pointer directly via
445 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
446 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
447 (unwind_body): New function.
448 (record_unwind_protect): First arg is now a function returning void,
449 not a dummy Lisp_Object.
450 (record_unwind_protect_ptr, record_unwind_protect_int)
451 (record_unwind_protect_void): New functions.
452 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
453 * fileio.c (struct auto_save_unwind): New type.
454 (do_auto_save_unwind): Use it.
455 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
456 * insdel.c (struct rvoe_arg): New type.
457 (reset_var_on_error): Use it.
458 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
459 New constants.
460 (specbinding_func): Remove; there are now several such functions.
461 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
462 (set_unwind_protect_ptr): New function.
463 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
464
4e604a5d
PE
465 Be simpler and more consistent about reporting I/O errors.
466 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
467 Say "Read error" and "Write error", rather than "I/O error", or
468 "IO error reading", or "IO error writing", when a read or write
469 error occurs.
470 * process.c (Fmake_network_process, wait_reading_process_output)
471 (send_process, Fprocess_send_eof, wait_reading_process_output):
472 Capitalize diagnostics consistently. Put "failed foo" at the
473 start of the diagnostic, so that we don't capitalize the
474 function name "foo". Consistently say "failed" for such
475 diagnostics.
476 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
477 All callers changed. This is so it can use report_file_error.
478 * sysdep.c (serial_open, serial_configure): Capitalize I/O
479 diagnostics consistently as above.
480
a9757f6a
PE
481 * fileio.c (report_file_errno): Fix errno reporting bug.
482 If the file name is neither null nor a pair, package it up as a
483 singleton list. All callers changed, both to this function and to
484 report_file_error. This fixes a bug where the memory allocator
485 invoked by list1 set errno so that the immediately following
486 report_file_error reported the wrong errno value.
487
c43843aa
PE
488 Fix minor problems found by --enable-gcc-warnings.
489 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
490 * keyboard.c (kbd_buffer_get_event): Remove unused local.
491
18c26d81
JD
4922013-07-16 Jan Djärv <jan.h.d@swipnet.se>
493
494 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
495 Set event->arg to Qt if switch-event shall be generated.
496 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
497
498 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
499
500 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
501 FOCUS_OUT_EVENT.
502
503 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
504 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
505 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
506 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
507 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
508 and there is a focused frame.
509 (head_table): Add focus-in and focus-out.
510 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
511 bind to handle-focus-in/out.
512
513 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
514 (Fhandle_switch_frame): Call Fhandle_focus_in.
515 (syms_of_frame): defsubr handle-focus-in/out.
516
6c6f1994
PE
5172013-07-16 Paul Eggert <eggert@cs.ucla.edu>
518
c7ddc792
PE
519 Fix porting bug to older POSIXish platforms (Bug#14862).
520 * sysdep.c (emacs_pipe): New function, that implements
521 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
522 This should port better to CentOS 5 and to Mac OS X 10.6.
523 All calls to pipe2 changed.
524
6c6f1994
PE
525 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
526 This makes the code easier to read and the executable a bit smaller.
527 Do not replace all calls to Fcons that happen to create lists,
528 just calls that are intended to create lists. For example, when
529 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
530 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
531 Similarly for list2 through list5.
532 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
533 * bytecode.c (exec_byte_code):
534 * callint.c (quotify_arg, Fcall_interactively):
535 * callproc.c (Fcall_process, create_temp_file):
536 * charset.c (load_charset_map_from_file)
537 (Fdefine_charset_internal, init_charset):
538 * coding.c (get_translation_table, detect_coding_system)
539 (Fcheck_coding_systems_region)
540 (Fset_terminal_coding_system_internal)
541 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
542 * composite.c (update_compositions, Ffind_composition_internal):
543 * dired.c (directory_files_internal, file_name_completion)
544 (Fsystem_users):
545 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
546 * doc.c (Fsnarf_documentation):
547 * editfns.c (Fmessage_box):
548 * emacs.c (main):
549 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
550 (Feval, eval_sub, Ffuncall, apply_lambda):
551 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
552 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
553 (Fset_file_times, Finsert_file_contents)
554 (Fchoose_write_coding_system, Fwrite_region):
555 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
556 * font.c (font_registry_charsets, font_parse_fcname)
557 (font_prepare_cache, font_update_drivers, Flist_fonts):
558 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
559 * frame.c (make_frame, Fmake_terminal_frame)
560 (x_set_frame_parameters, x_report_frame_params)
561 (x_default_parameter, Fx_parse_geometry):
562 * ftfont.c (syms_of_ftfont):
563 * image.c (gif_load):
564 * keyboard.c (command_loop_1):
565 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
566 (Fcopy_keymap, append_key, Fcurrent_active_maps)
567 (Fminor_mode_key_binding, accessible_keymaps_1)
568 (Faccessible_keymaps, Fwhere_is_internal):
569 * lread.c (read_emacs_mule_char):
570 * menu.c (find_and_return_menu_selection):
571 * minibuf.c (get_minibuffer):
572 * nsfns.m (Fns_perform_service):
573 * nsfont.m (ns_script_to_charset):
574 * nsmenu.m (ns_popup_dialog):
575 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
576 (Fx_own_selection_internal):
577 * nsterm.m (append2):
578 * print.c (Fredirect_debugging_output)
579 (print_prune_string_charset):
580 * process.c (Fdelete_process, Fprocess_contact)
581 (Fformat_network_address, set_socket_option)
582 (read_and_dispose_of_process_output, write_queue_push)
583 (send_process, exec_sentinel):
584 * sound.c (Fplay_sound_internal):
585 * textprop.c (validate_plist, add_properties)
586 (Fput_text_property, Fadd_face_text_property)
587 (copy_text_properties, text_property_list, syms_of_textprop):
588 * unexaix.c (report_error):
589 * unexcoff.c (report_error):
590 * unexsol.c (unexec):
591 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
592 (Fformat_mode_line, syms_of_xdisp):
593 * xfaces.c (set_font_frame_param)
594 (Finternal_lisp_face_attribute_values)
595 (Finternal_merge_in_global_face, syms_of_xfaces):
596 * xfns.c (x_default_scroll_bar_color_parameter)
597 (x_default_font_parameter, x_create_tip_frame):
598 * xfont.c (xfont_supported_scripts):
599 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
600 (menu_help_callback, xmenu_show):
601 * xml.c (make_dom):
602 * xterm.c (set_wm_state):
603 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
604 and similarly for list2 through list5.
605
bafe80ce
PE
6062013-07-15 Paul Eggert <eggert@cs.ucla.edu>
607
608 * callproc.c (Fcall_process_region): Fix minor race and tune.
609 (create_temp_file): New function, with the temp-file-creation part
610 of the old Fcall_process_region. Use Fcopy_sequence to create the
611 temp file name, rather than alloca + build_string, for simplicity.
612 Don't bother to block input around the temp file creation;
613 shouldn't be needed. Simplify use of mktemp. Use
614 record_unwind_protect immediately after creating the temp file;
615 this closes an unlikely race where the temp file was not removed.
616 Use memcpy rather than an open-coded loop.
617 (Fcall_process_region): Use the new function. If the input is
618 empty, redirect from /dev/null rather than from a newly created
619 empty temp file; this avoids unnecessary file system traffic.
620
4700b5a5
PE
6212013-07-14 Paul Eggert <eggert@cs.ucla.edu>
622
5c97beae
PE
623 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
624 Simplify by making this case like the other two. This is a bit
625 slower on obsolete hosts, but the extra complexity isn't worth it.
626
4700b5a5
PE
627 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
628 * process.c (create_process) [!DOS_NT]:
629 Remove now-unnecessary calls to emacs_close.
630
f9a74c4c
EZ
6312013-07-13 Eli Zaretskii <eliz@gnu.org>
632
922ae7ee
EZ
633 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
634 returning early. (Bug#14850)
635
f9a74c4c
EZ
636 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
637 and inhibit-iso-escape-detection attributes of 'undecided'.
638 (Bug#14822)
639
5e301d76
PE
6402013-07-13 Paul Eggert <eggert@cs.ucla.edu>
641
69e0e5ee
PE
642 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
643 Reported by Herbert J. Skuhra in
644 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
645
5e301d76
PE
646 Don't lose top specpdl entry when memory is exhausted.
647 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
648 specpdl overflow here, to simplify callers; all callers changed.
649 Always reserve an unused entry at the stack top; this avoids
650 losing the top entry's information when memory is exhausted.
651
7e649856
PE
6522013-07-12 Paul Eggert <eggert@cs.ucla.edu>
653
a773ed9a
PE
654 Clean up errno reporting and fix some errno-reporting bugs.
655 * callproc.c (Fcall_process):
656 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
657 * process.c (create_process, Fmake_network_process):
658 * unexaix.c (report_error):
659 * unexcoff.c (report_error):
660 Be more careful about reporting the errno of failed operations.
661 The code previously reported the wrong errno sometimes.
662 Also, prefer report_file_errno to setting errno + report_file_error.
663 (Fcall_process): Look at openp return value rather than at path,
664 as that's a bit faster and clearer when there's a numeric predicate.
665 * fileio.c (report_file_errno): New function, with most of the
666 old contents of report_file_error.
667 (report_file_error): Use it.
668 (Ffile_exists_p, Ffile_accessible_directory_p):
669 Set errno to 0 when it is junk.
670 * fileio.c (Faccess_file):
671 * image.c (x_create_bitmap_from_file):
672 Use faccessat rather than opening the file, to avoid the hassle of
673 having a file descriptor open.
674 * lisp.h (report_file_errno): New decl.
675 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
676
7e649856
PE
677 Minor EBADF fixes.
678 * process.c (create_process, wait_reading_process_output) [AIX]:
679 Remove obsolete SIGHUP-related code, as Emacs no longer disables
680 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
681 a multithreaded environment anyway).
682 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
683
f6774c1a
AS
6842013-07-12 Andreas Schwab <schwab@linux-m68k.org>
685
686 * image.c (x_find_image_file): Don't close a remote file handle.
687
bacba3c2
PE
6882013-07-12 Paul Eggert <eggert@cs.ucla.edu>
689
690 Fix races with threads and file descriptors.
691 * callproc.c (Fcall_process_region):
692 * dired.c (open_directory):
693 * emacs.c (main, Fdaemon_initialized):
694 * image.c (x_find_image_file):
695 * inotify.c (Finotify_rm_watch):
696 * lread.c (Flocate_file_internal):
697 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
698 * term.c (term_mouse_moveto, init_tty):
699 * termcap.c (tgetent):
700 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
701 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
702 * unexhp9k800.c, unexmacosx.c (unexec):
703 * callproc.c (Fcall_process_region):
704 Use emacs_close, not close.
705 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
706 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
707 and posix_close function on current platforms (which all lack them).
708 (emacs_close): Use it. This should fix the races on GNU/Linux and
709 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
710 and it should avoid closing random victim file descriptors on
711 other platforms.
712
653d4f43
PE
7132013-07-11 Paul Eggert <eggert@cs.ucla.edu>
714
c8536ec4
PE
715 * inotify.c (uninitialized): Remove. All uses replaced by -1.
716 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
717 Touch up doc a bit.
718
9c203066
PE
719 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
720 This is for .gdbinit xbacktrace.
721
653d4f43
PE
722 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
723 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
724 (emacs_set_tty): Now static.
725 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
726 * term.c (tty_capable_p, tty_default_color_capabilities)
727 (get_tty_terminal, term_mouse_movement)
728 (handle_one_term_event, init_tty, maybe_fatal):
729 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
730 (tgetent, scan_file, name_match, compare_contin):
731 * terminal.c (get_terminal):
732 Use bool for boolean.
733 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
734 Prefer char to unsigned char if either will do.
735 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
736 (tty_write_glyphs): Prefer int to unsigned.
737 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
738 All callers changed.
739 * termcap.c (tprint, main) [TEST]: Remove non-working test.
740
45b683a1
PE
7412013-07-10 Paul Eggert <eggert@cs.ucla.edu>
742
29abe551
PE
743 Port to C89.
744 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
745 (B__dummy__): New dummy symbol, to pacify C89.
746 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
747 they can't grok varargs macros.
748 * dispnew.c (add_window_display_history)
749 (add_frame_display_history):
750 * print.c (print_object):
751 * xdisp.c (debug_method_add):
752 Use %p printf format only for void pointers.
753 * emacs.c (usage_message): New constant, replacing ...
754 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
755 (main): Adjust to usage reorg.
756 * fns.c (syms_of_fns):
757 * profiler.c (syms_of_profiler):
758 Don't use non-constant struct initializers.
759 * gnutls.h (gnutls_initstage_t):
760 * lisp.h (enum Lisp_Fwd_Type):
761 * lread.c (lisp_file_lexically_bound_p):
762 * xsettings.c (anonymous enum):
763 Remove trailing comma.
764 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
765 * lisp.h (ENUM_BF): Use unsigned if pedantic.
766 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
767 (DEFUN): Use it.
768 * regex.c (const_re_char): New type, to pacify strict C89.
769 All uses of 'const re_char' replaced to use it.
770 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
771 with glibc when strict C89. This change is imported from gnulib.
772 All uses changed.
773 (_Restrict_arr_): Rename from __restrict_arr, similarly.
774 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
775 Omit GNU_LINUX implementation, since it requires long long.
776 * xterm.c (x_draw_underwave):
777 Do not assume the traditional order of struct's members.
778 (x_term_init): Rewrite to avoid the need for non-constant structure
779 initializers.
780
45b683a1 781 Syntax cleanup, mostly replacing macros with functions.
763a086d 782 This removes the need for the syntax_temp hack.
45b683a1
PE
783 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
784 * syntax.c (SYNTAX_INLINE): New macro.
785 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
786 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
787 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
788 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
789 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
790 (SYNTAX_COMEND_FIRST): Now functions, not macros.
791 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
792 Now constants, not macros.
793 (syntax_temp) [!__GNUC__]: Remove.
794 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
795 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
796 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
797 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
798 Move here from syntax.h; now functions, not macros. Except for the
799 last function, these are static since only syntax.c uses them.
800 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
801 All uses changed. Now a function, not a macro; use this fact
802 to simplify the code.
803 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
804 compiler bugs; no longer relevant.
805 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
806 (SYNTAX_INLINE): New macro.
807 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
808 for the new functions. Use bool for boolean member.
809 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
810 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
811 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
812 (SETUP_BUFFER_SYNTAX_TABLE):
813 Now extern inline functions, not macros.
814 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
815 Remove; all uses replaced by implementation.
816 (syntax_temp) [!__GNUC__]: Remove decl.
817 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
818
29be4a50
JD
8192013-07-10 Jan Djärv <jan.h.d@swipnet.se>
820
821 * emacs.c (main): Fix syntax error.
822
954b166e
PE
8232013-07-10 Paul Eggert <eggert@cs.ucla.edu>
824
825 Timestamp fixes for undo (Bug#14824).
826 * atimer.c (schedule_atimer):
827 * fileio.c (Ffile_newer_than_file_p):
828 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
829 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
830 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
831 (syms_of_fileio): Remove Sclear_visited_file_name.
832 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
833 file doesn't exist; this avoids an ambiguity with negative timestamps.
834 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
835 * systime.h (make_emacs_time, invalid_emacs_time):
836 Don't assume struct timespec layout; POSIX doesn't guarantee it.
837 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
838 * undo.c (record_first_change): Push (visited-file-modtime) onto
839 undo list rather than reimplementing it by hand, incorrectly.
840
d74647c3
KB
8412013-07-09 Ken Brown <kbrown@cornell.edu>
842
843 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
844
3c51b96b
JB
8452013-07-09 Juanma Barranquero <lekktu@gmail.com>
846
847 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
848
4ebbdd67
PE
8492013-07-09 Paul Eggert <eggert@cs.ucla.edu>
850
851 Handle errno and exit status a bit more carefully.
852 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
853 number into an exit status. Instead, use EXIT_CANCELED.
854 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
855 * callproc.c (relocate_fd):
856 * emacs.c (close_output_streams, main):
857 * process.c (create_process):
858 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
859 Use emacs_perror for simplicity.
860 * callproc.c (relocate_fd, main):
861 * sysdep.c (sys_subshell):
862 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
863 (shut_down_emacs): Use emacs_write, not write.
864 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
865 * fileio.c (Fcopy_file, e_write):
866 * nsterm.m (ns_select):
867 * process.c (send_process):
868 * sound.c (vox_write):
869 Use emacs_write_sig, not emacs_write.
870 * lisp.h (emacs_write_sig, emacs_perror): New decls.
871 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
872 New constants.
873 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
874 of write.
875 (emacs_full_write): New function.
876 (emacs_write): Rewrite to use it.
877 (emacswrite_sig, emacs_perror): New functions.
878 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
879
763a086d 8802013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change).
e4b1e5af
JD
881
882 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
883 on NS even if it is present. Pixmap on NS is a void*.
884
9caab067
PE
8852013-07-07 Paul Eggert <eggert@cs.ucla.edu>
886
887 Port to Ubuntu 10 (Bug#14803).
888 Problem reported by T.V. Raman.
889 * process.c (close_on_exec, accept4, process_socket):
890 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
891
1d442672
EZ
8922013-07-07 Eli Zaretskii <eliz@gnu.org>
893
894 * w32.c (sys_dup): Declare prototype.
895
896 * filelock.c:
897 * emacs.c:
898 * callproc.c [WINDOWSNT]: Include sys/socket.h.
899
067428c1
PE
9002013-07-07 Paul Eggert <eggert@cs.ucla.edu>
901
902 Make file descriptors close-on-exec when possible (Bug#14803).
903 This simplifies Emacs a bit, since it no longer needs to worry
904 about closing file descriptors by hand in some cases.
905 It also fixes some unlikely races. Not all such races, as
906 libraries often open files internally without setting
907 close-on-exec, but it's an improvement.
908 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
909 * callproc.c (Fcall_process) [!MSDOS]:
910 * emacs.c (main) [!DOS_NT]:
911 * nsterm.m (ns_term_init):
912 * process.c (create_process):
913 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
914 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
915 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
916 Prefer mkostemp with O_CLOEXEC to mkstemp.
917 * callproc.c (relocate_fd) [!WINDOWSNT]:
918 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
919 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
920 now using pipe2.
921 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
922 Make the resulting file descriptor close-on-exec.
923 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
924 * lread.c (load_descriptor_list, load_descriptor_unwind):
925 Remove; no longer needed. All uses removed.
926 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
927 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
928 New functions.
929 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
930 (Fmake_network_process, Fnetwork_interface_list):
931 (Fnetwork_interface_info, server_accept_connection):
932 Make newly-created socket close-on-exec.
933 * sysdep.c (emacs_open, emacs_fopen):
934 Make new-created descriptor close-on-exec.
935 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
936 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
937
0da857dd
JD
9382013-07-07 Jan Djärv <jan.h.d@swipnet.se>
939
940 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
941 for NS_IMPL_GNUSTEP.
942
5f86adcd
PE
9432013-07-07 Paul Eggert <eggert@cs.ucla.edu>
944
945 Fix openp errno handling.
946 * callproc.c (Fcall_process): Preserve openp errno around close.
947 * lread.c (openp): Set errno when returning -1, as some callers
948 expect this.
949
1afb1d07
JD
9502013-07-06 Jan Djärv <jan.h.d@swipnet.se>
951
952 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
953
954 * nsterm.h (NSSavePanel): Update comment.
955 (NSAPP_DATA2_RUNFILEDIALOG): Define.
956 (ns_run_file_dialog): Declare.
957
958 * nsfns.m: Remove panelOK.
959 (ns_fd_data): New.
960 (ns_run_file_dialog): New function.
961 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
962 event loop, so file dialog is popped up by ns_run_file_dialog, called
963 by sendEvent (Bug#14578).
964 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
965
3323c263
EZ
9662013-07-06 Eli Zaretskii <eliz@gnu.org>
967
fdda0220
EZ
968 * xdisp.c (default_line_pixel_height): New function.
969 (pos_visible_p, move_it_vertically_backward, try_scrolling)
970 (try_cursor_movement, redisplay_window, try_window)
971 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
972
973 * window.c (window_scroll_pixel_based): use
974 default_line_pixel_height.
975
976 * dispextern.h (default_line_pixel_height): Add prototype.
977
978 * frame.c (x_set_line_spacing): Accept a float value for
979 line-spacing parameter, per the documentation.
980
3323c263
EZ
981 * data.c (Fmultibyte_string_p): Doc fix.
982
47ba6d43
PE
9832013-07-05 Paul Eggert <eggert@cs.ucla.edu>
984
406af475
PE
985 Use emacs_open more consistently when opening files.
986 This handles EINTR more consistently now, and makes it easier
987 to introduce other uniform changes to file descriptor handling.
988 * src/systdio.h: New file.
989 * src/buffer.c (mmap_init):
990 * cygw32.c (chdir_to_default_directory):
991 * dispnew.c (Fopen_termscript):
992 * emacs.c (Fdaemon_initialized):
993 * fileio.c (Fdo_auto_save):
994 * image.c (slurp_file, png_load_body, jpeg_load_body):
995 * keyboard.c (Fopen_dribble_file):
996 * lread.c (Fload):
997 * print.c (Fredirect_debugging_output):
998 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
999 * termcap.c (tgetent):
1000 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1001 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1002 * w32term.c (w32_initialize) [CYGWIN]:
1003 * xfaces.c (Fx_load_color_file):
1004 Use emacs_open instead of plain open, and emacs_fopen instead of
1005 plain fopen.
1006 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1007 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1008 * callproc.c (default_output_mode): New constant.
1009 (Fcall_process): Use it to call emacs_open instead of plain creat.
1010 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1011 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1012 (emacs_fopen): New function.
1013 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1014 Include <lisp.h>, for emacs_open.
1015 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1016
47ba6d43
PE
1017 Remove duplicate #include directives.
1018 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1019 * xfaces.c:
1020 Don't include stdio.h twice.
1021 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1022 Don't include sys/types.h or stdio.h twice.
1023 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1024 * lread.c: Don't include coding.h twice.
1025 * nsfont.m: Don't include frame.h twice.
1026 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1027 * ralloc.c: Don't include <unistd.h> twice.
1028 * xdisp.c: Don't include font.h twice.
1029 * xterm.c: Don't include fontset.h twice.
1030 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1031
b9ed53d5
PE
10322013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 Scale ImageMagick images more carefully.
1035 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1036 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1037 Be more careful about avoiding undefined behavior after
1038 integer overflow and division by zero.
1039
cf13177e
YM
10402013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1041
1042 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1043 (syms_of_w32fns): DEFSYM them.
1044 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1045 (CCHDEVICENAME): Define macros if not defined.
1046 (struct MONITOR_INFO_EX): New struct.
1047 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1048 (enum_display_monitors_fn): New variable.
1049 (globals_of_w32fns): Initialize it.
1050 (Fx_display_pixel_width, Fx_display_pixel_height)
1051 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1052 multi-monitor setups in docstrings.
1053 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1054 screen size by primary monitor's millimeter per pixel.
1055 (w32_monitor_enum, w32_display_monitor_attributes_list)
1056 (w32_display_monitor_attributes_list_fallback)
1057 (Fw32_display_monitor_attributes_list): New functions.
1058 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1059
1060 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1061 if not defined.
1062 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1063
86dfb7a8
MA
10642013-07-04 Michael Albinus <michael.albinus@gmx.de>
1065
1066 * fileio.c (Qfile_notify_error): New error symbol.
1067
1068 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1069 * inotify.c (inotify_callback, symbol_to_inotifymask)
1070 (Finotify_add_watch, Finotify_rm_watch): Use it.
1071 (inotifyevent_to_event): Exchange order of cookie and file name.
1072 (Finotify_add_watch): Adapt docstring.
1073
1074 * lisp.h (Qfile_notify_error): Declare.
1075
2c1c974b
PE
10762013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1079 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1080 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1081 which did not work (see <http://bugs.gnu.org/14569#307>).
1082 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1083 && (!noninteractive || initialized)). This attempts to thread
1084 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1085
7a35b20f
JB
10862013-07-04 Juanma Barranquero <lekktu@gmail.com>
1087
1088 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1089 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1090
1ce5cd04
PE
10912013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1094 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1095 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1096 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1097
57f8c490
PE
10982013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1101 Define to __sys_siglist.
1102
bcffb5ca
EZ
11032013-07-02 Eli Zaretskii <eliz@gnu.org>
1104
1105 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1106 word-wrap, so that overflow-newline-into-fringe would work in
1107 visual-line-mode. (Bug#2749)
1108 (move_it_in_display_line_to): When the last scanned display
1109 element fits exactly on the display line, and
1110 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1111 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1112 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1113 finding buffer position that corresponds to pixel coordinates,
1114 e.g. in buffer_posn_from_coords.
1115
2c41e781
JD
11162013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1117
1118 * process.c (handle_child_signal): Call catch_child_signal if
1119 NS_IMPL_GNUSTEP.
1120
c2418359
PE
11212013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1122
52a9bcae
PE
1123 Don't convert function pointers to void * and back.
1124 It isn't portable C, and it's easy enough to avoid.
1125 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1126 (make_save_value): Add support for SAVE_FUNCPOINTER.
1127 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1128 * print.c (print_object):
1129 Distinguish function from object pointers.
1130 * lisp.h (SAVE_FUNCPOINTER): New constant.
1131 (SAVE_SLOT_BITS): Adjust to it.
1132 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1133 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1134 (voidfuncptr): New typedef.
1135 (struct Lisp_Save_Value): New member data[0].funcpointer.
1136 (XSAVE_FUNCPOINTER): New function.
1137
c2418359
PE
1138 Simplify buildobj processing.
1139 * Makefile.in (buildobj.h): Make it a sequence of strings each
1140 followed by comma, rather than a single string. Put it into a
1141 .tmp file in case there's an error while generating it.
1142 (gl-stamp): Use .tmp for temp files.
1143 (mostlyclean): Clean .tmp files.
1144 * doc.c (buildobj): Move to just the routine that needs it.
1145 It's now an array of strings, so processing is simpler.
1146
8f43ce49
PE
11472013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1148
1149 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1150 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1151 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1152 Invoke malloc_enable_thread even when not interactive.
1153 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1154 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1155 in this case, since the underlying bug has now been fixed.
1156
24827db9
JB
11572013-07-01 Juanma Barranquero <lekktu@gmail.com>
1158
1159 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1160 unlinking it (bug#14691).
1161
ef099a94
MN
11622013-06-30 Michal Nazarewicz <mina86@mina86.com>
1163
1164 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1165 before checking whether buffer is modified. This lets
1166 `kill-buffer-query-functions' cancel killing of the buffer or save
1167 its content before `kill-buffer' asks user the "Buffer %s
1168 modified; kill anyway?" question.
1169
9d3f2fc2
JD
11702013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1171
1172 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1173 Let the super performKeyEquivalent deal with them (Bug#14747).
1174
e6c6c8c7
PE
11752013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1176
1d71c1d9
PE
1177 * widget.c (resize_cb): Remove unused local.
1178
8f5f35cc
PE
1179 Do not use GTK 3 if it exists but cannot be compiled.
1180 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1181 * xterm.c (x_error_handler) [!USE_GTK]:
1182 Do not use GTK 3.
1183
e6c6c8c7
PE
1184 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1185
0ba54312
EZ
11862013-06-30 Eli Zaretskii <eliz@gnu.org>
1187
5d1c3286
EZ
1188 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1189 to the valid range of values. (Bug#14753)
1190
0ba54312
EZ
1191 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1192 when moving point by using the current glyph matrix. This avoids
1193 the need to force redisplay when this function is called in a
1194 loop.
1195
9c90cc06
PE
11962013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 Fix minor problems found by static checking.
1199 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1200 Redo the latter's body to sidestep GCC parenthesization warnings.
1201 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1202 * coding.c (detect_coding, detect_coding_system):
1203 * coding.h (struct undecided_spec):
1204 Use bool for boolean.
1205 * image.c (QCmax_width, QCmax_height): Now static.
1206 * xdisp.c (Fmove_point_visually): Remove unused local.
1207
4c672a0f
EZ
12082013-06-29 Eli Zaretskii <eliz@gnu.org>
1209
1210 * xdisp.c (Fmove_point_visually): New function.
1211
c1ea3abf
JB
12122013-06-28 Kenichi Handa <handa@gnu.org>
1213
1214 * coding.h (define_coding_undecided_arg_index): New enum.
1215 (coding_attr_index): New members
1216 coding_attr_undecided_inhibit_null_byte_detection,
1217 coding_attr_undecided_inhibit_iso_escape_detection,
1218 coding_attr_undecided_prefer_utf_8.
1219 (undecided_spec): New struct.
1220 (struct coding_system): New member `undecided' of the member
1221 `spec'.
1222
1223 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1224 (detect_coding): Likewise.
1225 (detect_coding_system): Likewise.
1226 (Fdefine_coding_system_internal): New coding system properties
1227 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1228 :prefer-utf-8.
1229 (syms_of_coding): Adjust for coding_arg_undecided_max.
1230
ba3de9e6
PE
12312013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 * image.c (x_from_xcolors): Remove unused local.
1234
547c9269
YM
12352013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1236
1237 Defer image data transfer between X client and server until actual
1238 display happens.
1239
1240 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1241 and `mask_img'.
1242
1243 * image.c (Destroy_Image): Remove.
1244 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1245 `mask_p', and `colors_p'. All uses changed.
1246 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1247 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1248 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1249 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1250 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1251 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1252 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1253 (image_get_x_image, image_unget_x_image): New functions or macros.
1254 (image_background, image_background_transparent, x_to_xcolors)
1255 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1256 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1257 instead of Destroy_Image.
1258 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1259 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1260 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1261 (imagemagick_load_image, svg_load_image): Use them instead of
1262 x_create_x_image_and_pixmap, and x_put_x_image followed by
1263 x_destroy_x_image, respectively.
1264 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1265 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1266 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1267 background_transparent fields.
1268 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1269 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1270
dae2f5ef
PE
12712013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1274 This mostly consists of undoing recent changes.
1275 * callproc.c (Fcall_process):
1276 * process.c (create_process):
1277 Do not worry about catching SIGCHLD here, undoing previous change.
1278 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1279 * process.c, process.h (catch_child_signal):
1280 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1281 * process.c (catch_child_handler): Don't worry about being called
1282 lazily and do not assume caller has blocked SIGCHLD, undoing
1283 previous change. Move first-time stuff back to
1284 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1285 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1286 set lib_child_handler if it's already initialized, which may
1287 help avoid problems on GNUStep.
1288
fa55d2aa
PE
12892013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1290
1291 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1292 * callproc.c (Fcall_process):
1293 * process.c (create_process):
1294 Make sure SIGCHLD is caught before we fork,
1295 since Emacs startup no arranges to catch SIGCHLD.
1296 * process.c (lib_child_handler): Initialize to null, not to
1297 dummy_handler.
1298 (catch_child_signal): Allow self to be called lazily.
1299 Do nothing if it's already been called.
1300 Assume caller has blocked SIGCHLD (all callers do now).
1301 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1302 just before it's really needed.
1303 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1304 since it hasn't been caught yet.
1305
f3f9606c
LMI
13062013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1307
1308 * image.c (compute_image_size): New function to implement
1309 :max-width and :max-height.
1310 (imagemagick_load_image): Use it.
1311
c7041908
PE
13122013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1315 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1316 Now extern.
1317 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1318 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1319 the SIGCHLD handler, since the code is not atomic and (due to glib)
1320 signals may be arriving now.
1321 * sysdep.c (init_signals): Do not catch child signals here;
1322 'main' now does that later, at a safer time.
1323
f86852b4
PE
13242013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1325
0dfeed58
PE
1326 Clean up SIGCHLD handling a bit (Bug#14569).
1327 * process.c, process.h (catch_child_signal):
1328 Now always extern, even if !NS_IMPL_GNUSTEP.
1329 * process.c (catch_child_signal): Move glib tickler here from
1330 init_process_emacs, so that it's done earlier in Emacs
1331 initialization. Also move the noninteractive && !initialized
1332 check here from init_process_emacs. This is all a bit cleaner for
1333 GNUish platforms, and I hope it works around the Cygwin bug.
1334 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1335 that glib signal handling is tickled before glib creates threads.
1336
f86852b4
PE
1337 * process.c (wait_reading_process_output): Avoid int overflow
1338 when reading more than 2 GiB total from a process.
1339
cbd6509c
PE
13402013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 * process.c (create_process): Handle a couple more cases,
1343 i.e., work even if new_argv and wait_child_setup[i] are cached.
1344 Use Fcall_process's style for volatile vars.
1345
9de1114a
AS
13462013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1347
1348 * process.c (create_process): Mark PROCESS volatile.
1349
fbe9e0b9
PE
13502013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 Use C99-style flexible array members if available.
1353 This avoids some subtle aliasing issues, which typically
1354 aren't a problem with GCC but may be a problem elsewhere.
1355 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1356 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1357 In either case, it uses a flexible array member rather than
1358 the old struct hack. All uses changed.
1359 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1360 Adjust to sdata reorganization.
1361 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1362 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1363 that ports better to pre-C99 non-GCC.
1364 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1365 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1366 as the latter has changed.
1367 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1368 and port better to pre-C99 GCC.
1369 * image.c (struct xpm_cached_color):
1370 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1371 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1372 Use FLEXIBLE_ARRAY_MEMBER.
1373 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1374 Move decl to top level so it gets checked against implementation.
1375 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1376 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1377
1fc71008
PE
13782013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1379
1380 * syntax.c: Integer cleanups.
1381 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1382 All uses that need 0-or-2 changed to:
1383 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1384 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1385 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1386 (char_quoted, prev_char_comend_first, back_comment)
1387 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1388 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1389 Use bool for boolean.
1390 (update_syntax_table, skip_chars, skip_syntaxes):
1391 Prefer int to unsigned when either will do.
1392 (back_comment): Return boolean success flag, like forw_comment,
1393 instead of positive-or-minus-1 (which might have overflowed int anyway).
1394 Don't stuff ptrdiff_t into int.
1395 (syntax_spec_code, syntax_code_spec): Now const.
1396 (Fmatching_paren, scan_lists, scan_sexps_forward):
1397 Use enum syntaxcode for syntax code.
1398 (Fmatching_paren): Check that arg is a character, not just an integer.
1399 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1400 (Finternal_describe_syntax_value): Omit no-longer-needed
1401 comparison to 0.
1402 (skip_chars): Use char, not unsigned char, when the distinction
1403 doesn't matter.
1404 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1405 * bytecode.c (exec_byte_code):
1406 * syntax.c (syntax_spec_code, Fchar_syntax)
1407 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1408 (init_syntax_once):
1409 * syntax.h (SYNTAX_WITH_FLAGS):
1410 Omit unnecessary casts.
1411
b932cad7
EZ
14122013-06-20 Eli Zaretskii <eliz@gnu.org>
1413
1414 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1415 line dimensions here, to avoid race conditions with the main
1416 thread. (Bug#14062, bug#14630, bug#14669)
1417
1418 * w32term.c (w32_draw_window_cursor): Compute the header line and
1419 mode line dimensions here.
1420 <w32_system_caret_window, w32_system_caret_hdr_height>:
1421 <w32_system_caret_mode_height>: New variables.
1422
1423 * w32term.h: Declare them.
1424
89561f72
PE
14252013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1426
5013fc08
PE
1427 * alloc.c (die): Move "assertion failed" string here ...
1428 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1429 COND when SUPPRESS_CHECKING. This shrinks the executable text
1430 size by 0.8% to 2.2% when configured with --enable-checking,
1431 depending on optimization flags (GCC 4.8.1 x86-64).
1432
89561f72
PE
1433 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1434
763a086d 14352013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
1436
1437 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1438 base is 2; this is more accurate.
1439
983aeb9a
JB
14402013-06-19 Juanma Barranquero <lekktu@gmail.com>
1441
1442 * sound.c (string_default): Move to !WINDOWSNT section.
1443 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1444
178ba3e6
PE
14452013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1446
bbc51b15
PE
1447 * sound.c: Integer cleanups.
1448 Remove unnecessary forward decls.
1449 (struct sound_device): The 'file' member is now a Lisp_Object, not
1450 a char *, so that we needn't invoke alloca on a huge size.
1451 (Fplay_sound_internal): Adjust to this.
1452 (string_default): New function.
1453 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1454 Use it to adjust to the struct sound_device change.
1455 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1456 (be2hs) [0]: Remove.
1457
178ba3e6
PE
1458 * syntax.c (skip_chars): Don't use uninitialized storage
1459 when searching a multibyte buffer for characters that are not in a
1460 unibyte string that contains non-ASCII characters.
1461
69f60cdc
JD
14622013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1463
1464 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1465 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1466
0d6224d4
PE
14672013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1468
1469 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1470
3c542890
KH
14712013-06-18 Kenichi Handa <handa@gnu.org>
1472
f7e3f7cd
KH
1473 * font.c (Ffont_spec): Signal an error for an invalid font name
1474 (Bug#14648).
3c542890 1475
9349e5f7
PE
14762013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1477
1478 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1479 In particular this ports to 32-bit sparc Sun cc.
1480 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1481 array with a dummy element at specpdl[-1], so that its address can
1482 be taken portably.
1483 (unbind_to): Do not copy the binding; not needed, now that we
1484 copy old_value in the one place where the copy is needed.
1485 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1486 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1487 (union specbinding): Rename from struct specbinding. Redo layout
1488 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1489 which is not portable. With Sun C 5.12 32-bit sparc, the
1490 declaration causes nargs to be an unsigned bitfield, a behavior
1491 that the C standard allows; but Emacs wants nargs to be signed.
1492 The overall type is now a union of structures rather than a
1493 structure of union of structures, and the 'kind' member is now a
1494 bitfield, so that the overall type doesn't grow. All uses changed.
1495 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1496
0a4df6a5
PE
14972013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1498
ec6ecaad
PE
1499 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1500 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1501
0a4df6a5
PE
1502 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1503
7bfe8dbc
EZ
15042013-06-17 Eli Zaretskii <eliz@gnu.org>
1505
1506 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1507 unless we know that the window w's frame is a frame object.
1508 Another attempt at solving bug#14062 and bug#14630.
1509
708e05f6
LMI
15102013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1511
1512 * textprop.c (property_set_type): New enum.
1513 (add_properties): Allow appending/prepending text properties.
1514 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1515 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1516 add_text_properties_1.
1517 (Fadd_face_text_property): New function that calls
1518 add_text_properties_1.
1519
84575e67
PE
15202013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 Move functions from lisp.h to individual modules when possible.
1523 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1524 * alloc.c (XFLOAT_INIT, set_symbol_name):
1525 * buffer.c (CHECK_OVERLAY):
1526 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1527 (set_char_table_parent):
1528 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1529 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1530 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1531 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1532 (set_blv_valcell):
1533 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1534 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1535 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1536 (backtrace_args, backtrace_debug_on_exit):
1537 * floatfns.c (CHECK_FLOAT):
1538 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1539 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1540 (set_hash_hash, set_hash_hash_slot, set_hash_index)
1541 (set_hash_index_slot):
1542 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
1543 * marker.c (CHECK_MARKER):
1544 * textprop.c (CHECK_STRING_OR_BUFFER):
1545 * window.c (CHECK_WINDOW_CONFIGURATION):
1546 Move here from lisp.h, and make these functions static rather than
1547 extern inline.
1548 * buffer.c (Qoverlayp):
1549 * data.c (Qsubrp):
1550 * fns.c (Qhash_table_p):
1551 * window.c (Qwindow_configuration_p):
1552 Now static.
1553 * lisp.h: Remove the abovementioned defns and decls.
1554
1555 Use functions, not macros, for XINT etc. (Bug#11935).
1556 In lisp.h, prefer functions to function-like macros, and
1557 constants to object-like macros, when either will do. This:
1558 . simplifies use, as there's no more need to worry about
1559 arguments' side effects being evaluated multiple times.
1560 . makes the code easier to debug on some platforms.
1561 However, when using gcc -O0, keep using function-like macros
1562 for a few critical operations, for performance reasons.
1563 This sort of thing isn't needed with gcc -Og, but -Og
1564 is a GCC 4.8 feature and isn't widely-enough available yet.
1565 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
1566 Remove enum lsb_bits; no longer needed.
1567 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
1568 * buffer.c (Qoverlap):
1569 * data.c (Qsubrp):
1570 * fns.c (Qhash_table_p):
1571 Now extern, so lisp.h can use these symbols.
1572 * dispextern.h: Include character.h, for MAX_CHAR etc.
1573 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1574 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1575 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1576 (GLYPH_CODE_P): Move here from lisp.h.
1577 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1578 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
1579 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
1580 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
1581 XUNTAG now returns void *.
1582 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
1583 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
1584 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
1585 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
1586 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
1587 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
1588 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
1589 (lisp_h_XPNTR, lisp_h_XSYMBOL):
1590 New macros, renamed from their sans-lisp_h_ counterparts.
1591 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
1592 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
1593 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
1594 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
1595 If compiling via GCC without optimization, define these as macros
1596 in addition to inline functions.
1597 To disable this, compile with -DINLINING=0.
1598 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
1599 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
1600 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
1601 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
1602 (INTMASK, VALMASK): Now macros, since static values cannot be
1603 accessed from extern inline functions.
1604 (VALMASK): Also a constant, for benefit of old GDB.
1605 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
1606 is INTEGERP, which can fold it in.
5165d44a 1607 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
1608 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
1609 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
1610 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
1611 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
1612 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
1613 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
1614 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
1615 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
1616 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
1617 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
1618 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
1619 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
1620 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
1621 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
1622 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
1623 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
1624 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
1625 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
1626 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
1627 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
1628 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
1629 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
1630 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
1631 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
1632 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
1633 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
1634 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
1635 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
1636 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
1637 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
1638 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
1639 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
1640 Now functions.
1641 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
1642 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
1643 (VALMASK): Define in one place rather than in two, merging the
1644 USE_LSB_TAG parts; this is simpler.
1645 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
1646 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
1647 Move up, to avoid use before definition.
1648 Also include "globals.h" earlier, for the same reason.
1649 (make_natnum): New function.
1650 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
1651 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
1652 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
1653 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
1654 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
1655 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
1656 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
1657 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
1658 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
1659 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
1660 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
1661 (Qwindow_configuration_p, Qimage): New forward declarations.
1662 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
1663 (STRING_COPYIN): Remove; unused.
1664 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
1665 (xcar_addr, xcdr_addr): New functions. All uses changed.
1666 (IEEE_FLOATING_POINT): Now a constant, not a macro.
1667 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1668 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1669 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1670 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
1671 (TYPE_RANGED_INTEGERP): Simplify.
1672 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
1673 (setlocale, fixup_locale, synchronize_system_messages_locale)
1674 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
1675 Now empty functions, not macros.
1676 (functionp): Return bool, not int.
1677 * window.c (Qwindow_configuration_p): Now extern,
1678 so window.h can use it.
1679 * window.h (Qwindowp): Move decl back to lisp.h.
1680
9583ec36
EZ
16812013-06-15 Eli Zaretskii <eliz@gnu.org>
1682
1683 * xdisp.c (Fline_pixel_height): New function, required for solving
1684 bug #14567.
1685
210272ce
PE
16862013-06-15 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
1689
de0503df
SM
16902013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
1691
1692 * lread.c (syms_of_lread):
1693 * fns.c (Fprovide): Adjust to new format of after-load-alist.
1694
afbfe143
KD
16952013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
1696
1697 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
1698
d177e213
XF
16992013-06-12 Xue Fuqiao <xfq.free@gmail.com>
1700
1701 * fileio.c (expand_file_name): Doc fix.
1702
05e3e412
PE
17032013-06-11 Paul Eggert <eggert@cs.ucla.edu>
1704
f7394b12
PE
1705 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
1706 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
1707 Wait for self, not for 0. This can't hurt on GNU or similar
1708 system, and may help with Cygwin.
1709
05e3e412
PE
1710 * keyboard.c: Don't use PROP (...) as an lvalue.
1711 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
1712 Use set_prop (A, B), not PROP (A) = B.
1713
17dd3097
EZ
17142013-06-10 Eli Zaretskii <eliz@gnu.org>
1715
1716 * xdisp.c (get_it_property): Use it->window instead of generating
1717 a Lisp object from it->w.
1718
52fab9c9
EZ
17192013-06-09 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (get_it_property): If it->object is a buffer, pass to
1722 get-char-property the window that is being rendered, instead of
1723 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
1724 (compute_display_string_pos): When W is NULL, use the current
1725 buffer as the object to pass to get-char-property.
1726 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
1727 pointer member of the bidi iterator, since no window is pertinent
1728 to this function.
52fab9c9 1729
5bf97bfc
EZ
17302013-06-08 Eli Zaretskii <eliz@gnu.org>
1731
1732 * bidi.c (bidi_fetch_char): Accept additional argument, the window
1733 being displayed, and pass it to compute_display_string_pos.
1734 (bidi_level_of_next_char, bidi_resolve_explicit_1)
1735 (bidi_paragraph_init): All callers changed.
1736
1737 * xdisp.c (init_from_display_pos, init_iterator)
1738 (handle_single_display_spec, next_overlay_string)
1739 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
1740 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
1741 Set bidi_it.w member from it->w.
5bf97bfc
EZ
1742 (compute_display_string_pos): Accept additional argument, the
1743 window being displayed, and pass it to Fget_char_property.
1744 (Bug#14575)
1745
1746 * dispextern.h (struct bidi_it): New member w, the window being
1747 displayed.
1748 (compute_display_string_pos): Adjust prototype.
1749
5de0e011
JD
17502013-06-08 Jan Djärv <jan.h.d@swipnet.se>
1751
e7b41c4c 1752 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
1753
1754 * process.c (wait_reading_process_output): Check for NS before GLIB.
1755 GLIB may be linked in due to rsvg, but ns_select must be called.
1756
5de0e011
JD
1757 * xgselect.c (xg_select): Remove call to window_system_available
1758 and g_main_context_pending at the top, so Gdk events (i.e. file
1759 notify) are processed when Emacs is started with -nw.
1760
a822acff
EZ
17612013-06-07 Eli Zaretskii <eliz@gnu.org>
1762
1763 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
1764 (ctagsfiles3): New variable, includes only *.m files.
1765 (TAGS): Use an explicit language name in the regular expressions,
1766 to avoid transformation of '/SOMETHING' by MSYS to
1767 'c:\MSYS\SOMETHING'.
1768
6c0a9ed1
RC
17692013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
1770
1771 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
1772
9ef6111b
EZ
17732013-06-06 Eli Zaretskii <eliz@gnu.org>
1774
1775 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
1776 still need to set the mouse pointer shape and activate help-echo.
1777 (Bug#14558)
1778
7d300d64
PE
17792013-06-06 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 A few porting etc. fixes for the new file monitor code.
1782 See the thread containing
1783 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
1784 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
1785 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
1786 (dir_monitor_callback, Fgfile_rm_watch):
1787 Use assq_no_quit instead of Fassoc, for speed.
1788 (dir_monitor_callback, Fgfile_rm_watch):
1789 eassert that the monitor is a fixnum.
1790 (dir_monitor_callback): No need for CDR_SAFE.
1791 Simplify building of lisp with alternative tails.
1792 (Fgfile_add_watch, Fgfile_rm_watch):
1793 Do not assume glib functions set errno reliably on failure.
1794 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
1795 and signal an error otherwise.
1796 (Fgfile_rm_watch): Prefer CONSP to !NILP.
1797 Use Fdelq instead of Fdelete, for speed.
1798
817ebfcf
EZ
17992013-06-05 Eli Zaretskii <eliz@gnu.org>
1800
1801 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
1802 don't insist on being invoked on a highlighted tool-bar button.
1803 Avoids losing tool-bar functionality when mouse-highlight is nil.
1804 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
1805 Don't highlight when mouse-highlight is nil.
1806 (note_mouse_highlight): When mouse-highlight is nil, don't return
1807 right away; instead, run tool-bar and mode-line highlight
1808 subroutine, clear any existing highlight, and revert the mouse
1809 pointer to its default shape. (Bug#14558)
1810
55577e7c
SM
18112013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1812
1813 * lisp.mk (lisp): Add prog-mode.el.
1814
f019a684
PE
18152013-06-05 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
1818 * process.c (dummy_handler): New function.
1819 (lib_child_handler): New static var.
1820 (handle_child_signal): Invoke it.
1821 (catch_child_signal): If a library has set up a signal handler,
1822 save it into lib_child_handler.
1823 (init_process_emacs): If using glib and not on Windows, tickle glib's
1824 child-handling code so that it initializes its private SIGCHLD handler.
1825 * syssignal.h (SA_SIGINFO): Default to 0.
1826 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
1827 31; it should no longer be needed now.
1828
90db8702
MA
18292013-06-05 Michael Albinus <michael.albinus@gmx.de>
1830
1831 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
1832
1833 * gfilenotify.c (globals_of_gfilenotify): New function.
1834 (syms_of_gfilenotify): Move global initialization there.
1835
1836 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
1837
bfa3acd6
SM
18382013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1839
1840 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
1841 * keyboard.c (menu_bar_items, tool_bar_items):
1842 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
1843 not override local keymaps any more.
1844
ba59bd80
EZ
18452013-06-04 Eli Zaretskii <eliz@gnu.org>
1846
1847 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
1848
7f203aa1
EZ
18492013-06-03 Eli Zaretskii <eliz@gnu.org>
1850
9337e206
EZ
1851 * w32console.c (initialize_w32_display): Return the dimensions of
1852 the console window via 2 additional arguments, not via the current
1853 frame. This avoids crashes due to overrunning the bounds of
1854 frame's decode_mode_spec_buffer, which is not resized following
1855 the change of the frame dimensions from the initial 10x10.
1856
1857 * w32term.h (w32_initialize_display_info): Adjust prototype.
1858
1859 * term.c (init_tty): Take dimensions of the frame from the values
1860 returned by initialize_w32_display.
1861
7f203aa1
EZ
1862 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
1863 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
1864 (LIBES): Add $(GFILENOTIFY_LIBS).
1865
1866 * w32inevt.c (handle_file_notifications): Add dummy implementation
1867 for !HAVE_W32NOTIFY.
1868
1869 * w32term.c: Wrap code with HAVE_W32NOTIFY.
1870
55a87246
JD
18712013-06-03 Jan Djärv <jan.h.d@swipnet.se>
1872
1873 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
1874
1875 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
1876
1877 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
1878
3d5ee10a
PE
18792013-06-03 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 Fix minor problems found by static checking.
1882 * data.c (pure_write_error):
1883 Use xsignal2, not Fsignal, as Fsignal might return.
1884 * eval.c (set_backtrace_debug_on_exit): Now static.
1885 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
1886 No longer inline. EXTERN_INLINE is needed only for functions
1887 defined in .h files. Reindent function header as per GNU style.
1888 (backtrace_p, backtrace_top, backtrace_next):
1889 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
1890 compiler or linker. Add extern decls to pacify gcc -Wall.
1891 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1892 Now static.
1893 * frame.c (free_monitors): Define only on platforms that need it.
1894 * nsterm.m (ns_term_init):
1895 * process.c (catch_child_signal):
1896 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
1897 defined on all porting targets these days.
1898 * process.c, process.h (catch_child_signal):
1899 Make it extern only if NS_IMPL_GNUSTEP is defined.
1900
e2d8a6f0
EZ
19012013-06-03 Eli Zaretskii <eliz@gnu.org>
1902
1903 * w32.c (gettimeofday): Make the signature identical to prototype
1904 in nt/inc/sys/time.h.
1905
a8a7c5f6
SM
19062013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1907
1908 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
1909 .gdbinit.
1910
1911 * keyboard.c (safe_run_hooks_error): Improve error message.
1912
1913 * data.c (pure_write_error): Add `object' argument.
1914 * puresize.h (CHECK_IMPURE): Use it.
1915
c9628c79
MA
19162013-06-03 Michael Albinus <michael.albinus@gmx.de>
1917
1918 * Makefile.in (NOTIFY_OBJ): New variable.
1919 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
1920
1921 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
1922 Call syms_of_gfilenotify.
1923
1924 * gfilenotify.c: New file.
1925
1926 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
1927 and Qfile_w32notify.
1928 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
1929 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
1930
1931 * lisp.h: Declare syms_of_gfilenotify.
1932
1933 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
1934
2f592f95
SM
19352013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1936
1937 Merge the specpdl and backtrace stacks. Make the structure of the
1938 specpdl entries more obvious via a tagged union of structs.
1939 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
1940 (enum specbind_tag): New enum.
1941 (struct specbinding): Make it a tagged union of structs.
1942 Add a case for backtrace records.
1943 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
1944 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
1945 (backtrace_debug_on_exit): New accessors.
1946 (struct backtrace): Remove.
1947 (struct catchtag): Remove backlist field.
1948 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1949 Move to eval.c.
1950 (Flocal_variable_p): Speed up the common case where the binding is
1951 already loaded.
1952 * eval.c (backtrace_list): Remove.
1953 (set_specpdl_symbol, set_specpdl_old_value): Remove.
1954 (set_backtrace_args, set_backtrace_nargs)
1955 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
1956 (backtrace_next): New functions.
1957 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
1958 (unwind_to_catch, internal_lisp_condition_case)
1959 (internal_condition_case, internal_condition_case_1)
1960 (internal_condition_case_2, internal_condition_case_n): Don't bother
1961 with backtrace_list any more.
1962 (Fsignal): Adjust to new backtrace format.
1963 (grow_specpdl): Move up.
1964 (record_in_backtrace): New function.
1965 (eval_sub, Ffuncall): Use it.
1966 (apply_lambda): Adjust to new backtrace format.
1967 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
1968 data.c.
1969 (specbind): Adjust to new specpdl format. Simplify.
1970 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
1971 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
1972 backtrace format.
1973 (mark_backtrace): Remove.
1974 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
1975 * xdisp.c (redisplay_internal): Use record_in_backtrace.
1976 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
1977 Use mark_specpdl.
1978 * profiler.c (record_backtrace): Use get_backtrace.
1979 (handle_profiler_signal): Use backtrace_top_function.
1980 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
1981 accessor functions.
1982
c0342369
JD
19832013-06-02 Jan Djärv <jan.h.d@swipnet.se>
1984
1985 * process.h (catch_child_signal): Declare.
1986
1987 * process.c (catch_child_signal): New function.
1988 (init_process_emacs): Call it.
1989
1990 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
1991 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
1992 NS_IMPL_COCOA.
1993 (x_set_cursor_type): Remove declaration.
1994 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
1995 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
1996 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
1997 (ns_get_color): Use F suffix on float.
1998 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
1999 (ns_get_rgb_color): Remove.
2000 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2001 (note_mouse_movement): x and y are CGFloat.
2002 (ns_draw_fringe_bitmap): Remove unused rowY.
2003 Change #if to COCOA && >= 10_6.
2004 (ns_draw_window_cursor): Remove unused overspill.
2005 (ns_draw_underwave): width and x are EamcsCGFloat.
2006 (ns_draw_box): thickness is CGFloat.
2007 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2008 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2009 if not in main thread.
2010 (ns_get_pending_menu_title, ns_check_menu_open)
2011 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2012 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2013 (sendFromMainThread:): New method.
2014 (changeFont:): size is CGFloat.
2015 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2016 Disable warning about permanent text.
2017 (characterIndexForPoint:): Adjust return type depending on GNUStep
2018 version.
2019 (mouseDown:): delta is CGFloat.
2020 (updateFrameSize): Remove unised variable f.
2021 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2022 Cast float to EmacsCGFloat.
2023 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2024 also to -1 when restoring.
2025 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2026 inside NS_IMPL_COCOA.
2027 (toggleFullScreen:): Put call to toggleFullScreen inside
2028 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2029 (setPosition:portion:whole:): por is CGFloat.
2030 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2031 (mouseDown:): Use CGFloat.
2032 (mouseDragged:): Remove unised variable edge.
2033 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2034
2035 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2036 of CGFloat differs.
2037 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2038 when NS_IMPL_GNUSTEP.
2039 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2040 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2041 (EmacsToolbar): Add clearAll. Add tag argument to
2042 addDisplayItemWithImage.
2043 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2044
2045 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2046
2047 * nsmenu.m (ns_update_menubar): Make static.
2048 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2049 (fillWithWidgetValue:): Add cast to SEL for setAction.
2050 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2051 (update_frame_tool_bar): Update code for GNUStep.
2052 (clearAll): New method.
2053 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2054 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2055 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2056 call to insertItemWithItemIdentifier.
2057 (validateVisibleItems): Fix indentation.
2058 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2059 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2060 UtilityWindow to aStyle, remove call to setStyleMask.
2061
2062 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2063
2064 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2065 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2066 Use F suffix on floats.
2067 (ns_char_width): Returns CGFloat.
2068 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2069 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2070 DPSxshow.
2071 (ns_glyph_metrics): CGFloat instead of float.
2072
a0eb10b3
JB
2073 * nsfns.m (x_set_foreground_color, x_set_background_color):
2074 Use EmacsCGFloat.
2075 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2076 remove unused variables.
2077 (Fns_read_file_name): Keep track if panel is for save.
2078 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2079 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2080 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2081 Just return the input if GNUStep.
c0342369
JD
2082 (x_screen_planes): Remove.
2083 (Fxw_color_values): Use EmacsCGFloat
2084 (Fns_display_monitor_attributes_list): Only get screen number for
2085 Cocoa.
ef099a94 2086 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2087 EmacsSavePanel.
2088 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2089 ns_directory_from_panel.
2090
da9aff11
PE
20912013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 * process.c (handle_child_signal): Also use WCONTINUED.
2094 This is so that list-processes doesn't mistakenly list the process
2095 as stopped, when the process has actually been continued and is
2096 now running.
2097
0e64479a
PE
20982013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2099
fc186a96
PE
2100 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2101 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2102 not already configured.
2103
0e64479a
PE
2104 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2105
38b787fa
EZ
21062013-05-29 Eli Zaretskii <eliz@gnu.org>
2107
2108 * Makefile.in (mostlyclean): Remove *.res files.
2109
22513e52
SM
21102013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2111
2112 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2113 a buffer (bug#8447).
2114
6ef3db10
EZ
21152013-05-27 Eli Zaretskii <eliz@gnu.org>
2116
2117 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2118 display vector, and we backtrack, handle the case that the
2119 previous character position is also displayed from a display
2120 vector or covered by a display string or image. (Bug#14476)
2121
6799bb26
JD
21222013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2123
2124 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2125 (struct MonitorInfo, free_monitors): Remove.
2126 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2127 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2128 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2129 Qframes, Qsource.
2130
2131 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2132 (struct MonitorInfo, free_monitors): Remove.
2133 (ns_screen_name): Make static.
2134 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2135 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2136 Qframes, Qsource.
2137
2138 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2139 (struct MonitorInfo): New struct.
2140 (free_monitors, make_monitor_attribute_list): Declare.
2141
22513e52
SM
2142 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2143 New Lisp_Object:s.
6799bb26
JD
2144 (free_monitors, make_monitor_attribute_list): New functions.
2145 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2146 Qsource.
2147
38cd43eb
XF
21482013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2149
2150 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2151
2af0948d
SM
21522013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2153
a7eb9b0f
SM
2154 * keyboard.c: Apply keyboard decoding only to events that come directly
2155 from the tty, not from unread-command-events (bug#14368).
2156 (read_event_from_main_queue): New function, extracted from read_char).
2157 (read_decoded_char): Remove.
2158 (read_decoded_event_from_main_queue): New function to replace it.
2159 (read_char): Use it.
2160 (read_key_sequence): Use read_char rather than read_decoded_char.
2161
2af0948d
SM
2162 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2163
1413e9a5
BR
21642013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2165
2166 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2167
e6d2f155
KH
21682013-05-22 Kenichi Handa <handa@gnu.org>
2169
2170 The following changes are to fix the setting of
2171 buffer-file-coding-system on, for instance, C-x RET c unix RET
2172 _FILE_OF_DOS_EOL_TYPE_ RET.
2173
2174 * coding.h (struct coding_system): New member detected_utf8_chars.
2175
2176 * coding.c (detect_coding_utf_8): Count characters and check EOL
2177 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2178 BOM is there.
2179 (setup_coding_system): Do not initialize coding->head_ascii.
2180 (check_ascii): Do not set coding->eol_seen but update it. Do not
2181 call adjust_coding_eol_type here.
1413e9a5
BR
2182 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2183 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2184 of the found coding-system.
2185 (decode_coding_gap): Cancel previous change. Utilize the
2186 character numbers counted by detect_coding_utf_8. Fix detection
2187 of BOM for utf-8.
2188
ab56a6f4 21892013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2190
2191 * search.c (looking_at_1): Only set last_thing_searched if the match
2192 changed the match-data (bug#14281).
2193
ecc3c6ed
DA
21942013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2195
2196 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2197 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2198 (move_it_vertically_backward): Likewise.
2199
5ba8bf35
YM
22002013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2201
2202 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2203 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2204 (Fx_display_mm_width, Fx_display_mm_height):
2205 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2206
91e8418b 2207 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2208 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2209 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2210 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2211 (Fx_display_backing_store, Fx_display_visual_class)
2212 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2213 (Fx_display_grayscale_p, Fx_display_pixel_width)
2214 (Fx_display_pixel_height, Fx_display_planes)
2215 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2216 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2217 (Fx_display_mm_width, Fx_display_mm_height)
2218 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2219 height for all physical monitors as in X11.
2220
fc30d803
SM
2221 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2222 Return pixel width or height for all physical monitors as in X11.
91e8418b 2223
31ff141c
PE
22242013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2225
2226 Port --enable-gcc-warnings to clang.
2227 * bytecode.c (exec_byte_code):
2228 * regex.c:
2229 Redo diagnostic pragmas to pacify clang, too.
2230 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2231 * editfns.c (Fencode_time):
2232 * fileio.c (file_accessible_directory_p):
2233 * font.c (font_unparse_xlfd):
2234 Use '&"string"[index]' instead of '"string" + (index)'.
2235 * undo.c (user_error): Remove; unused.
2236
df065a0b
EZ
22372013-05-16 Eli Zaretskii <eliz@gnu.org>
2238
04d360e7
EZ
2239 * insdel.c (insert_1_both): Document the arguments, instead of
2240 referring to insert_1, which no longer exists.
2241
5bb98290
EZ
2242 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2243 some window, increment windows_or_buffers_changed, so that
2244 *Messages* display in that window is updated. (Bug#14408)
2245
df065a0b
EZ
2246 * w32.c: Include epaths.h.
2247 (init_environment): Use cmdproxy.exe without leading directories.
2248 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2249 case.
2250 (gettimeofday): Adjust signature and return value to Posix
2251 expectations.
2252
2253 * unexw32.c (open_output_file): Delete the existing emacs.exe
2254 before creating it, to break the hard link to the versioned
2255 executable.
2256
2257 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2258 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2259 (FIRSTFILE_OBJ): New variables.
2260 (W32_RES): Rename to EMACSRES. All users changed.
2261 (base_obj): Use $(CM_OBJ).
2262 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2263 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2264 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2265 $(W32_RES_LINK) before $(LIBES).
2266 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2267
1aa8d505
SM
22682013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2269
6e911150
SM
2270 * makefile.w32-in (DOC): Use just "DOC".
2271
2272 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2273
1aa8d505
SM
2274 * process.c: Export default filters and sentinels to Elisp.
2275 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2276 New constants.
2277 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2278 (Fset_process_sentinel, Fformat_network_address):
2279 Default to them instead of nil.
2280 (server_accept_connection): Sentinels can't be nil any more.
2281 (read_and_dispose_of_process_output): New function, extracted from
2282 read_process_output.
2283 (read_process_output): Use it; filters can't be nil.
2284 (Finternal_default_process_filter): New function, extracted from
2285 read_process_output.
2286 (exec_sentinel_unwind): Remove function.
2287 (exec_sentinel): Don't zilch sentinel while running.
2288 (status_notify): Sentinels can't be nil.
2289 (Finternal_default_process_sentinel): New function extracted from
2290 status_notify.
2291 (setup_process_coding_systems): Default filter is not nil any more.
2292 (syms_of_process): Export new Elisp functions and initialize
2293 new constants.
2294 * lisp.h (make_lisp_proc): New function.
2295
5ac2eb34
SM
22962013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2297
2298 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2299
eda9c7d7
EZ
23002013-05-14 Eli Zaretskii <eliz@gnu.org>
2301
2302 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2303 unless we know that the window w is a leaf window.
2304 Another attempt at solving bug#14062.
eda9c7d7 2305
8fdeaad5
JD
23062013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2307
2308 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2309 fdesc (Bug#14375).
2310
44aa9ee6
PE
23112013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * image.c (gif_load): Check that subimages fit (Bug#14345).
2314
759fd763
SM
23152013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2316
2317 * lread.c (skip_dyn_eof): New function.
2318 (read1): Use it to skip the end of a file in response to #@00.
2319
2320 * doc.c (get_doc_string): Slightly relax the sanity checking.
2321
4465bfb4
JD
23222013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2323
2324 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2325 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2326 (MonitorInfo): New struct.
2327 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2328 (Fns_display_monitor_attributes_list): New functions.
2329 (display-usable-bounds): Remove.
2330 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2331 Qsource.
2332
7583e2a0
PE
23332013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2336 (GTK_CHECK_VERSION): New macro, if not already defined.
2337 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2338 replaced by GTK_CHECK_VERSION.
2339
ad75d77e
PE
23402013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2341
2342 * xterm.h (GTK_PREREQ): New macro.
2343 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2344 to use this macro instead, for consistency and clarity.
2345
07525f77
EZ
23462013-05-08 Eli Zaretskii <eliz@gnu.org>
2347
2348 * xdisp.c (row_for_charpos_p): New function, with code of
2349 cursor_row_p, but accepts an additional argument CHARPOS instead
2350 of using a hardcoded PT.
2351 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2352 (row_containing_pos): Call row_for_charpos_p instead of partially
2353 doing the same. Fixes cursor positioning under longlines-mode
2354 when longlines-show-effect includes more than one newline, when
2355 moving the cursor vertically up.
2356
d901fc8d
JB
23572013-05-08 Juanma Barranquero <lekktu@gmail.com>
2358
2359 * makefile.w32-in (ACL_H): New macro.
2360 ($(BLD)/fileio.$(O)): Update dependencies.
2361
f269bc61
PE
23622013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2363
e7b41c4c 2364 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2365 * Makefile.in (LIB_ACL): New macro.
2366 (LIBACL_LIBS): Remove.
2367 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2368 * fileio.c: Include <acl.h>.
2369 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2370 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2371 !acl_errno_valid.
2372 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2373 it ourselves.
2374
f269bc61
PE
2375 * unexelf.c: Don't assume ElfW (Half) fits in int.
2376 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2377 when dealing with ElfW (Half) values, since they can exceed 2**31
2378 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2379 (entry_address): Omit unused NUM arg. All uses changed.
2380
a261c53e
JL
23812013-05-07 Juri Linkov <juri@jurta.org>
2382
2383 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2384 to the string converted from number with `Fnumber_to_string'.
2385 (Bug#14254)
2386
2b66427d
PE
23872013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2390 This fixes a problem introduced by my previous change.
2391
15acfe41
GM
23922013-05-07 Glenn Morris <rgm@gnu.org>
2393
2394 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2395
5ea03bf5
JD
23962013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2397
2398 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2399
e0c9d565
PE
24002013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 Static checking by GCC 4.8.0.
2403 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2404 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2405 (x_get_monitor_attributes_fallback)
2406 (x_get_monitor_attributes_xinerama)
2407 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2408 Define only if USE_GTK.
2409 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2410 (x_get_monitor_attributes_fallback): Omit unused locals.
2411 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2412 Use double, not float, to avoid mixed-mode floating point arithmetic.
2413
4e3f9230
YM
24142013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2415 Jan Djärv <jan.h.d@swipnet.se>
2416
2417 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2418 (XINERAMA_CFLAGS): New macros.
2419 (ALL_CFLAGS, LIBES): Use them.
2420
2421 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2422 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2423 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2424 (syms_of_xfns): DEFSYM them.
2425 (struct MonitorInfo): New struct.
2426 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2427 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2428 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2429 (x_get_monitor_attributes_xinerama): New functions.
2430 (Fx_display_monitor_attributes_list): New primitive.
2431 (syms_of_xfns): Defsubr it.
2432
2433 * xterm.h (x_display_info): Add Xatom_net_workarea and
2434 Xatom_net_current_desktop.
2435
2436 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2437 and dpyinfo->Xatom_net_current_desktop.
2438
05839b6a
EZ
24392013-05-06 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (pos_visible_p): Use the special code for finding the
2442 beginning of a display property or overlay for any "replacing"
2443 display property, not just for display strings. This solves
2444 incorrect reporting of position by posn-at-point. (Bug#14241)
2445
dc4a2ee0
PE
24462013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2447
5ee94506
PE
2448 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2449 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2450 Verify that ElfW (Half) fits in int.
2451 (fatal): Use same signature as lisp.h.
2452 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2453 configure and build with -DUNEXELF_DEBUG without worrying about
2454 other modules that use DEBUG.
2455 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2456 possibly-wide integers now uses it instead of plain fprintf.
2457 (entry_address): New function, which avoids problems with 32-bit
2458 overflow on 64-bit hosts.
2459 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2460 (round_up): Don't assume the remainder fits in int.
2461 (find_section): Use bool for boolean. Simplify debug code.
2462 (unexec): Don't assume file sizes fit in int or size_t.
2463 Omit unnecessary trailing newline in 'fatal' format.
2464 Use strerror rather than outputting decimal error number.
2465 Remove unused code when emacs is not defined;
2466 this file relies on Emacs now.
2467 Don't assume e_phnum and e_shnum are positive.
2468
dc4a2ee0
PE
2469 * regex.c: Fix problems when DEBUG is defined.
2470 (extract_number, extract_number_and_incr): Define regardless of
2471 whether DEBUG is defined; that's simpler and makes the code less
2472 likely to go stale in the normal case when DEBUG is not defined.
2473 Return int rather than taking an int * arg. All callers changed.
2474 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2475 Remove, replacing with ...
2476 (DEBUG_PRINT): New macro. All callers changed.
2477 (DEBUG_COMPILES_ARGUMENTS): New macro.
2478 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2479 (print_compiled_pattern, print_double_string) [DEBUG]:
2480 Use prototype rather than old-style definition.
2481 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2482 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2483 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2484 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2485 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2486 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2487 This matters only when DEBUG is defined.
2488
14c7ed05
EZ
24892013-05-05 Eli Zaretskii <eliz@gnu.org>
2490
2491 * xdisp.c (set_iterator_to_next): Set the
2492 ignore_overlay_strings_at_pos_p flag only if we are _really_
2493 iterating over an overlay string, as indicated by the
2494 current.overlay_string_index member. (Bug#14306)
2495
e6076b1b
JD
24962013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2497
2498 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2499 to where it is used, to avoid autorelease issues (Bug#14050).
2500
cbee2131
PE
25012013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2504 * fileio.c (syms_of_fileio): Implement this.
2505 * filelock.c (create_lock_file): If symbolic links don't work, so
2506 we use a regular file as a lock file, do not fsync the lock file;
2507 it's not needed.
2508
30c7e542
SM
25092013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2510
2511 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2512 (syms_of_minibuf): Adjust accodingly.
2513 * lread.c (Fread):
2514 * callint.c (Fcall_interactively): Adjust calls accordingly.
2515
5bebd186
EZ
25162013-05-04 Eli Zaretskii <eliz@gnu.org>
2517
2518 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2519 w->contents is a buffer before computing everything else.
2520 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2521
2522 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2523 assertion violations. (Bug#14062)
2524
0fb0a4f3
DR
25252013-05-01 David Reitter <david.reitter@gmail.com>
2526
2527 * nsfns.m (ns_tooltip): Initialize.
2528
9e63b4a5
EZ
25292013-04-28 Eli Zaretskii <eliz@gnu.org>
2530
2531 * coding.c (decode_coding_gap): Don't remove the character before
2532 a newline unless it's a CR character. (Bug#14287)
2533
ad60824e
DN
25342013-04-28 Dan Nicolaescu <dann@gnu.org>
2535
2536 * dispextern.h (struct face): Move enum face_underline_type
2537 earlier so that bitfields can be in the same word.
2538
edbdcec0
JD
25392013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2540
2541 * nsfns.m (handlePanelKeys): New function.
2542 (EmacsOpenPanel:performKeyEquivalent:)
2543 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
2544 arrows/function/control and copy/paste keys (Bug#14296).
2545
0208ede7
JL
25462013-04-27 Juri Linkov <juri@jurta.org>
2547
2548 * callint.c (Fcall_interactively): Call `Qread_number' for
2549 interactive code letter `n' instead of using duplicate code.
2550 (Bug#14254)
2551
b8dd59f7
PE
25522013-04-27 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 * systime.h (make_timeval): Declare as 'const'.
2555
8bd722db
KH
25562013-04-27 Kenichi Handa <handa@gnu.org>
2557
2558 * font.c (font_open_entity): Always open a font of manageable
2559 size.
2560
13d0e56f 25612013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 2562
f780d632
PE
2563 Port better to AIX (Bug#14258).
2564 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
2565 to pacify AIX xlc.
2566
ec509856
KH
25672013-04-24 Kenichi Handa <handa@gnu.org>
2568
2569 * coding.c (decode_coding_iso_2022): When an invalid escape
2570 sequence is encountered, reset the invocation and designation
2571 status to the safest one.
2572
84fc48e5
PE
25732013-04-22 Paul Eggert <eggert@cs.ucla.edu>
2574
2575 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
2576 Without this fix, "make distclean" leaves stamp-h1 behind.
2577
806bda47
EC
25782013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
2579
2580 * w32fns.c (w32_fullscreen_rect): New function to compute the
2581 window rectangle for the given fullscreen mode.
2582 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
2583 longer tunes the window size. This keeps the window's edges flush
2584 with the screen and allows the taskbar to hide itself in fullboth.
2585
2586 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
2587 window decorations and uses the entire screen.
2588
2589 * w32term.h (w32_fullscreen_rect) Add prototype.
2590 (struct w32_output): Replace normal_width, normal_height,
2591 normal_top, and normal_left members with a single normal_placement
2592 struct.
2593 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
2594 Remove macros.
2595 (FRAME_NORMAL_PLACEMENT): New macro.
2596
9cc2810b
JB
25972013-04-16 Juanma Barranquero <lekktu@gmail.com>
2598
2599 * minibuf.c (Ftest_completion): Silence compiler warning.
2600
fd16b54c
EZ
26012013-04-15 Eli Zaretskii <eliz@gnu.org>
2602
2603 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 2604 bug#14062.
fd16b54c
EZ
2605
2606 * frame.h (WINDOW_FRAME): Protect macro and its argument with
2607 parentheses.
2608
2609 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
2610 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
2611 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
2612 parentheses where appropriate.
2613
9e3379a0
PE
26142013-04-14 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 * keyboard.c (timer_start_idle): Remove no-longer-used local.
2617
ddd6b685
EZ
26182013-04-14 Eli Zaretskii <eliz@gnu.org>
2619
2620 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
2621 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
2622 Mention in the doc string that setting these variables takes
2623 effect only after a call to set-window-buffer. (Bug#14200)
2624
29b79ba1
EZ
26252013-04-13 Eli Zaretskii <eliz@gnu.org>
2626
2627 * indent.c (Fvertical_motion): Don't consider display strings on
2628 overlay strings as display strings on the buffer position we
2629 started from. This prevents vertical cursor motion from jumping
2630 more than one line when there's an overlay string with a display
2631 property at end of line.
2632 Reported by Karl Chen <Karl.Chen@quarl.org> in
2633 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
2634
562c6ee9
SM
26352013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
2636
2637 * window.c (select_window): `record_buffer' even if window is
2638 already selected (bug#14191).
2639
fcc1fe85
EZ
26402013-04-11 Eli Zaretskii <eliz@gnu.org>
2641
2642 * window.c (Fwindow_end): Test more flags, including the buffer's
2643 last_overlay_modified flag, to determine whether the window's
2644 display is really up-to-date. Prevents the function from
2645 returning a stale value. (Bug#14170)
2646 (Fwindow_line_height): Fix the test for up-to-date-ness of the
2647 current matrix.
2648
f009190a
EZ
26492013-04-10 Eli Zaretskii <eliz@gnu.org>
2650
2651 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
2652 garbaged only if it is not already the top frame on its TTY.
2653 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
2654 there are GUI frames open in the same session. (Bug#13864)
2655
78ce603d
SM
26562013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
2657
2658 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
2659 of marking the idle timers directly.
2660
a8036e40
SM
26612013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
2662
2663 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
2664 tables (bug#14054).
2665
7ffe7ef6
SM
26662013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
2667
2668 * window.c (select_window): Don't record_buffer while the invariant is
2669 temporarily broken (bug#14161).
2670
2671 * fns.c (Fdelq): Don't assume !NILP => CONSP.
2672
7d9f6883
EZ
26732013-04-07 Eli Zaretskii <eliz@gnu.org>
2674
2675 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
2676
5406cfd9
RF
26772013-04-07 Romain Francoise <romain@orebokech.com>
2678
2679 Ignore additional platform-specific ACL errors (Bug#13702).
2680 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
2681 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
2682
95c0e83b
JD
26832013-03-31 Jan Djärv <jan.h.d@swipnet.se>
2684
2685 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
2686 f->output_data.ns.
2687
876da980
PE
26882013-04-07 Paul Eggert <eggert@cs.ucla.edu>
2689
2690 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
2691 This bug was introduced by my 2013-02-25 change that simplified
2692 data_start configuration. Without this change, on GNU/Linux
2693 an Emacs configured with --enable-profiling fails immediately
2694 due to a profiler signal.
2695 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
2696 with these flags. On platforms where special flags are needed
2697 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
2698 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
2699 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
2700
7452b7bd
DA
27012013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
2702
2703 Get rid of some platform-specific functions examining window
2704 system and its capabilities. This is a partial rework of the
2705 2013-04-05 change.
2706 * lisp.h (have_menus_p): Remove prototype. This function is
2707 replaced with platform-independent window_system_available.
2708 (check_window_system): Move to...
2709 * frame.h (decode_window_system_frame, window_system_available):
2710 ...here, add new prototypes.
2711 * frame.c (window_system_available, decode_window_system_frame):
2712 New functions.
2713 (check_window_system): Platform-independent now.
2714 * xterm.h (x_in_use): Remove declaration.
2715 (check_x_frame):
2716 * w32term.h (check_x_frame):
2717 * nsterm.h (check_x_frame): Remove prototypes. This function
2718 is replaced with platform-independent decode_window_system_frame.
2719 * msdos.c (have_menus_p): Remove.
2720 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
2721 Remove platform-specific functions. Use check_window_system,
2722 decode_window_system_frame and check_ns_display_info where
2723 appropriate. Minor style and comment tweaks.
2724 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
2725 (check_x_frame): Likewise.
2726 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
2727 Likewise.
2728 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
2729 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
2730 * xmenu.c, xselect.c: All related users changed.
2731
251e9147
KH
27322013-04-03 Kenichi Handa <handa@gnu.org>
2733
2734 The following changes is to optimize the code for reading UTF-8
2735 files.
2736
562c6ee9 2737 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
2738 changed. Check EOL format. Do not call adjust_coding_eol_type
2739 here.
2740 (check_utf_8): New function.
2741 (adjust_coding_eol_type): Do nothing if already adjusted.
2742 (detect_coding): Compare the return value of check_ascii with
2743 coding->src_bytes. Call adjust_coding_eol_type if necessary.
2744 (decode_coding_gap): Optimize for valid UTF-8.
2745
8bc369d4
KH
27462013-03-21 Kenichi Handa <handa@gnu.org>
2747
2748 * coding.c (syms_of_coding): Cancel previous change.
2749
2750 * insdel.c (insert_from_gap): Fix previous change.
2751
73931ad1
DA
27522013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
2753
2754 Consistently use platform-specific function to detect window system.
2755 * lisp.h (check_window_system): New prototype. This function is
2756 going to replace check_x, check_w32 and check_ns.
2757 (have_menus_p): Mention msdos.c in comment.
2758 * fontset.c (check_window_system_func): Remove. Adjust all users.
2759 * fontset.h (check_window_system_func): Remove prototype.
2760 * nsterm.h (check_ns):
2761 * xterm.h (check_x):
2762 * w32term.h (check_w32): Likewise.
2763 * menu.c (Fx_popup_menu): Use check_window_system.
2764 * msdos.c (check_window_system): Define for MS-DOS.
2765 * nsfns.m (check_window_system): Define for NS. Adjust all users.
2766 * w32fns.c (check_window_system): Likewise for MS-Windows.
2767 * xfns.c (check_window_system): Likewise for X.
2768 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
2769 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
2770
7216e43b
PE
27712013-04-02 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 Prefer < to > in range checks such as 0 <= i && i < N.
2774 This makes it easier to visualize quantities on a number line.
2775 This patch doesn't apply to all such range checks,
2776 only to the range checks affected by the 2013-03-24 change.
2777 This patch reverts most of the 2013-03-24 change.
2778 * alloc.c (xpalloc, Fgarbage_collect):
2779 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
2780 * character.c (string_escape_byte8):
2781 * charset.c (read_hex):
2782 * data.c (cons_to_unsigned):
2783 * dispnew.c (update_frame_1):
2784 * doc.c (Fsubstitute_command_keys):
2785 * doprnt.c (doprnt):
2786 * editfns.c (hi_time, decode_time_components):
2787 * fileio.c (file_offset):
2788 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2789 * font.c (font_intern_prop):
2790 * frame.c (x_set_alpha):
2791 * gtkutil.c (get_utf8_string):
2792 * indent.c (check_display_width):
2793 * keymap.c (Fkey_description):
2794 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
2795 * lread.c (read1):
2796 * minibuf.c (read_minibuf_noninteractive):
2797 * process.c (wait_reading_process_output):
2798 * search.c (Freplace_match):
2799 * window.c (get_phys_cursor_glyph):
2800 * xdisp.c (redisplay_internal):
2801 * xsmfns.c (smc_save_yourself_CB):
2802 Prefer < to > for range checks.
2803 * dispnew.c (sit_for): Don't mishandle NaNs.
2804 This fixes a bug introduced in the 2013-03-24 change.
2805 * editfns.c (decode_time_components): Don't hoist comparison.
2806 This fixes another bug introduced in the 2013-03-24 change.
2807
92759988
DA
28082013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
2809
2810 * frame.h (struct frame): Drop scroll_bottom_vpos
2811 member becaue all real users are dead long ago.
2812 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
2813 * xdisp.c (redisplay_internal): Adjust user.
2814
9a1971bb
GM
28152013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
2816
f38ab167
JD
2817 * nsmenu.m (showAtX:Y:for:): setLevel to
2818 NSPopUpMenuWindowLevel (Bug#13998).
2819
6d01f1fe
JD
28202013-03-30 Jan Djärv <jan.h.d@swipnet.se>
2821
2822 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
2823 (ns_check_pending_open_menu): Declare.
2824
2825 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
2826 (x_activate_menubar): Update the menu with title that matches
2827 ns_get_pending_menu_title, and call
2828 ns_check_pending_openmenu (Bug#12698).
2829 (menuWillOpen:): New method.
2830 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
2831
2832 * nsterm.m (menu_will_open_state, menu_mouse_point)
2833 (menu_pending_title): New varaibles.
2834 (ns_get_pending_menu_title, ns_check_menu_open)
2835 (ns_check_pending_open_menu): New functions.
2836
781f4782
DA
28372013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
2838
2839 * indent.c (current_column_bol_cache): Remove leftover which is not
2840 used in Fmove_to_column any more.
2841 (current_column, scan_for_column): Adjust users.
2842 * keyboard.c (last_point_position_buffer, last_point_position_window):
2843 Remove leftovers which are not used for recording undo any more.
2844 (command_loop_1, syms_of_keyboard): Adjust users.
2845 * xdisp.c (last_max_ascent): Remove leftover which is not used in
2846 redisplay_window any more.
2847 (move_it_to): Adjust user.
2848
1921c31b
JB
28492013-03-29 Juanma Barranquero <lekktu@gmail.com>
2850
2851 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
2852 Update dependencies.
2853
717b8bcd
SM
28542013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2855
2856 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
2857 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
2858 forward references.
2859
e74aeda8
DA
28602013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2861
2862 * window.h (struct window): Replace hchild, vchild and buffer slots
2863 with the only contents slot. This is possible because each valid
2864 window may have either the child window (in vertical or horizontal
2865 combination) or buffer to display (for the leaf window). Using that,
2866 a lof of operations to traverse and/or change window hierarchies may
2867 be simplified. New member horizontal is used to distinguish between
2868 horizontal and vertical combinations of internal windows.
2869 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
2870 (WINDOW_VERTICAL_COMBINATION_P): New macros.
2871 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
2872 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
2873 Use contents slot, not buffer, where appropriate.
2874 (wset_combination): New function.
2875 (wset_buffer): Add eassert.
2876 (Fframe_first_window): Simplify the loop reaching first window.
2877 (Fwindow_buffer): Use WINDOW_LEAF_P.
2878 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
2879 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
2880 (unshow_buffer): Convert initial debugging check to eassert.
2881 (replace_window, recombine_windows, Fdelete_other_windows_internal)
2882 (make_parent_window, window_resize_check, window_resize_apply)
2883 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
2884 (Fset_window_configuration, delete_all_child_windows, save_window_save):
2885 Adjust to match struct window changes.
2886 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
2887 (mark_window_cursors_off, count_windows, get_leaf_windows)
2888 (foreach_window_1): Simplify the loop.
2889 * alloc.c (mark_object): Do not check for the leaf window because
2890 internal windows has no glyph matrices anyway.
2891 * dispnew.c (clear_window_matrices, showing_window_margins_p)
2892 (allocate_matrices_for_window_redisplay, fake_current_matrices)
2893 (allocate_matrices_for_frame_redisplay, free_window_matrices)
2894 (build_frame_matrix_from_window_tree, mirror_make_current)
2895 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
2896 (update_window_tree, set_window_update_flags): Simplify the loop.
2897 (sync_window_with_frame_matrix_rows): Enforce live window.
2898 Use contents slot, not buffer, where appropriate.
2899 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
2900 and WINDOW_HORIZONTAL_COMBINATION_P.
2901 (make_frame_visible_1): Simplify the loop.
2902 Use contents slot, not buffer, where appropriate.
2903 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
2904 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
2905 (expose_window_tree): Likewise.
2906 Use contents slot, not buffer, where appropriate.
2907 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
2908 to avoid deleted windows. Use contents slot instead of buffer.
2909 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
2910 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
2911 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
2912 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
2913
121ab1cd
EZ
29142013-03-28 Eli Zaretskii <eliz@gnu.org>
2915
ef454cf7
EZ
2916 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
2917 identify the reasons for assertion violations in bug#14062 and
2918 similar ones.
21e930f8
EZ
2919 (Fx_show_tip): Fix compilation error under
2920 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 2921
121ab1cd
EZ
2922 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
2923 Reported by <rzl24ozi@gmail.com>.
2924
5c89ca24
DA
29252013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2926
2927 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
2928 start marker...
562c6ee9
SM
2929 (unwind_with_echo_area_buffer): ...to restore it here.
2930 This is needed to ensure that...
5c89ca24
DA
2931 (redisplay_window): ...both window markers are valid here,
2932 which is verified by eassert.
2933 * editfns.c (save_excursion_save): Do not assume that
2934 selected_window always displays the buffer.
c7f53895
DA
2935 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
2936 Fix comment.
5c89ca24 2937
f557c1b1
SM
29382013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
2939
2940 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
2941 the upcase table.
2942
40693bba 29432013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
2944
2945 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
2946
c86f791f
EZ
29472013-03-27 Eli Zaretskii <eliz@gnu.org>
2948
2949 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
2950 since MinGW's w32api headers do. This avoids compiler warnings.
2951
2952 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
2953 if already defined.
2954
c6e72e17
EZ
29552013-03-26 Eli Zaretskii <eliz@gnu.org>
2956
2957 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
2958
54e95010
JD
29592013-03-26 Jan Djärv <jan.h.d@swipnet.se>
2960
2961 * gtkutil.c (style_changed_cb): Check if frame is live and an
2962 X frame (Bug#14038).
2963
b88b62de
EZ
29642013-03-26 Eli Zaretskii <eliz@gnu.org>
2965
a18d7de6
EZ
2966 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
2967 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
2968 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
2969 MinGW64.
8f5e14c8
EZ
2970 Move inclusion of time.h before sys/time.h, so that MinGW64 could
2971 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 2972
b88b62de
EZ
2973 Fix incompatibilities between MinGW.org and MinGW64 headers.
2974 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
2975
2976 * w32.c (REPARSE_DATA_BUFFER): Guard with
2977 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
2978
c074e458
JD
29792013-03-25 Jan Djärv <jan.h.d@swipnet.se>
2980
2981 * xterm.c: Include X11/XKBlib.h
2982 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
2983
908589fd
AS
29842013-03-24 Andreas Schwab <schwab@linux-m68k.org>
2985
2986 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
2987 written backwards.
2988 * blockinput.h (input_blocked_p): Likewise.
2989 * bytecode.c (exec_byte_code): Likewise.
2990 * callproc.c (call_process_kill, call_process_cleanup)
2991 (Fcall_process): Likewise.
2992 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
2993 (Fccl_execute_on_string): Likewise.
2994 * character.c (string_escape_byte8): Likewise.
2995 * charset.c (read_hex): Likewise.
2996 * cm.c (calccost): Likewise.
2997 * data.c (cons_to_unsigned): Likewise.
2998 * dired.c (directory_files_internal, file_name_completion):
2999 Likewise.
3000 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3001 (sit_for): Likewise.
3002 * doc.c (Fsubstitute_command_keys): Likewise.
3003 * doprnt.c (doprnt): Likewise.
3004 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3005 * emacsgtkfixed.c: Likewise.
3006 * fileio.c (file_offset, Fwrite_region): Likewise.
3007 * floatfns.c (Fexpt, fmod_float): Likewise.
3008 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3009 Likewise.
3010 * font.c (font_intern_prop): Likewise.
3011 * frame.c (x_set_alpha): Likewise.
3012 * gtkutil.c (get_utf8_string): Likewise.
3013 * indent.c (check_display_width): Likewise.
3014 * intervals.c (create_root_interval, rotate_right, rotate_left)
3015 (split_interval_right, split_interval_left)
3016 (adjust_intervals_for_insertion, delete_node)
3017 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3018 (merge_interval_right, merge_interval_left, copy_intervals)
3019 (set_intervals_multibyte_1): Likewise.
3020 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3021 * keymap.c (Fkey_description): Likewise.
3022 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3023 * lread.c (openp, read_integer, read1, string_to_number):
3024 Likewise.
3025 * menu.c (ensure_menu_items): Likewise.
3026 * minibuf.c (read_minibuf_noninteractive): Likewise.
3027 * print.c (printchar, strout): Likewise.
3028 * process.c (create_process, Faccept_process_output)
3029 (wait_reading_process_output, read_process_output, send_process)
3030 (wait_reading_process_output): Likewise.
3031 * profiler.c (make_log, handle_profiler_signal): Likewise.
3032 * regex.c (re_exec): Likewise.
3033 * regex.h: Likewise.
3034 * search.c (looking_at_1, Freplace_match): Likewise.
3035 * sysdep.c (get_child_status, procfs_ttyname)
3036 (procfs_get_total_memory): Likewise.
3037 * systime.h (EMACS_TIME_VALID_P): Likewise.
3038 * term.c (dissociate_if_controlling_tty): Likewise.
3039 * window.c (get_phys_cursor_glyph): Likewise.
3040 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3041 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3042 Likewise.
3043 * xfns.c (Fx_window_property): Likewise.
3044 * xmenu.c (set_frame_menubar): Likewise.
3045 * xselect.c (x_get_window_property, x_handle_dnd_message):
3046 Likewise.
3047 * xsmfns.c (smc_save_yourself_CB): Likewise.
3048 * xterm.c (x_scroll_bar_set_handle): Likewise.
3049
2bf7d27a
DA
30502013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3051
3052 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3053 to be optional or nil. Adjust comment and convert it to docstring.
3054 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3055 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3056
a9ebfa0b
PE
30572013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 Static checking by GCC 4.8-20130319.
3060 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3061 * process.c (Fset_process_datagram_address)
3062 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3063 * xdisp.c (get_char_face_and_encoding):
3064 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3065 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3066 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3067
4f3576ee
KB
30682013-03-24 Ken Brown <kbrown@cornell.edu>
3069
789b5e9a
KB
3070 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3071 fix compilation on 64-bit Cygwin, where underscores are not
3072 automatically prepended.
3073
4f3576ee
KB
3074 * w32term.c (w32_initialize): Silence compiler warning.
3075
b5b7745f
EZ
30762013-03-23 Eli Zaretskii <eliz@gnu.org>
3077
cdc0d0bd
EZ
3078 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3079 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3080 variables, to save and restore frame dimensions.
3081 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3082 after returning from a 'fullscreen' configuration.
3083 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3084 to avoid races between the main thread and the input thread.
3085
3086 * w32term.h (struct w32_output): New members normal_width,
3087 normal_height, normal_top, normal_left, and prev_fsmode.
3088 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3089 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3090 members of a frame.
3091
b5b7745f
EZ
3092 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3093 'fullscreen' parameter. Always record previous width and height
3094 of the frame, except when switching out of maximized modes, so
3095 that they could be restored correctly, instead of resetting to the
3096 default frame dimensions. Send SC_RESTORE command to the frame,
3097 unless we are going to send SC_MAXIMIZE, to restore the frame
3098 resize hints in the mouse pointer shown by the window manager.
3099 (Bug#14032)
3100
3101 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3102
3103 * lisp.h (get_frame_param): Adjust conditions for prototype
3104 declaration.
3105
a3454eed
KB
31062013-03-22 Ken Brown <kbrown@cornell.edu>
3107
3108 * unexcw.c: Drop unneeded inclusion of w32common.h.
3109 (report_sheap_usage): Declare.
3110 (read_exe_header): Add magic numbers for x86_64.
3111 (fixup_executable): Fix printf format specifier for unsigned long
3112 argument.
3113
5a49b79c
DA
31142013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3115
3116 * frame.h (struct frame): Put menu_bar_window under #ifdef
3117 because this member is not needed when X toolkit is in use.
3118 (fset_menu_bar_window):
3119 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3120 (free_glyphs, update_frame):
3121 * xdisp.c (expose_frame): Likewise.
3122 (display_menu_bar): Likewise. Remove redundant eassert.
3123 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3124 toolkit is in use.
3125
d6723bf7
PE
31262013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3127
7b1123d8
PE
3128 Use functions and constants to manipulate Lisp_Save_Value objects.
3129 This replaces code that used macros and strings and token-pasting.
3130 The change makes the C source a bit easier to follow,
3131 and shrinks the Emacs executable a bit.
3132 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3133 (make_save_value): Change 1st arg from string to enum. All callers
3134 changed.
3135 (INTX): Remove.
3136 (mark_object): Use if, not #if, for GC_MARK_STACK.
3137 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3138 (XSAVE_OBJECT): Now functions, not macros.
3139 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3140 the constant was never used.
3141 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3142 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3143 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3144 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3145 New constants.
3146 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3147 type3 with a single member save_type. All uses changed.
3148 (save_type, set_save_pointer, set_save_integer): New functions.
3149 * print.c (PRINTX): Remove.
3150
d6723bf7
PE
3151 * alloc.c: Remove redundant static declarations.
3152
5f24fa51
DA
31532013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3154
3155 * window.h (struct window): Convert left_col, top_line, total_lines
3156 and total_cols from Lisp_Objects to integers. Adjust comments.
3157 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3158 Remove.
3159 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3160 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3161 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3162 Adjust users where appropriate.
3163
42143acd
DA
31642013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3165
3166 * frame.h (struct frame): Drop resx and resy because the same data is
3167 available from window system-specific output context. Adjust users.
562c6ee9
SM
3168 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3169 New functions to provide defaults when no window system available.
42143acd 3170 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3171 (NUMVAL): Move from xdisp.c.
42143acd
DA
3172 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3173 (Ffont_face_attributes, Fopen_font):
3174 * image.c (gs_load):
3175 * w32font.c (fill_in_logfont):
3176 * xdisp.c (calc_pixel_width_or_height):
3177 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3178 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3179
c0a17406
KH
31802013-03-20 Kenichi Handa <handa@gnu.org>
3181
3182 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3183 to 1 (temporary workaround until a bug related to ASCII
3184 optimization is fixed).
3185
095d384d
DA
31862013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3187
3188 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3189 Signal error if window is not internal. Adjust docstring.
3190 (delete_all_child_windows): Use combination_limit to save the buffer.
3191 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3192 * print.c (syms_of_print): Initialize debugging output not here...
3193 (init_print_once): ...but in a new function here.
3194 * lisp.h (init_print_once): Add prototype.
3195 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3196
748fa866
DA
31972013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3198
3199 * window.c (window_resize_check, window_resize_apply)
3200 (window_from_coordinates, recombine_windows, set_window_buffer)
3201 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3202 (Fsplit_window_internal, Fdelete_window_internal)
3203 (freeze_window_starts): Use bool for booleans.
3204 * window.h (window_frame_coordinates, resize_frame_windows)
3205 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3206
81519fd2
SM
32072013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3208
3209 * dispnew.c (bitch_at_user): Use `user-error'.
3210
6db423a9
KB
32112013-03-17 Ken Brown <kbrown@cornell.edu>
3212
3213 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3214 as return type of image_background. (Bug#13981)
3215 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3216
8f2906f5
JD
32172013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3218
960ce480 3219 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3220 (ns_select): Don't return with result uninitialized.
960ce480 3221
8f2906f5
JD
3222 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3223 and getDirectory.
3224
81519fd2
SM
3225 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3226 New functions.
8f2906f5
JD
3227 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3228 directories. If filename is nil, get directory name (Bug#13932).
3229 Use getFilename and getDirectory.
3230 (getFilename, getDirectory): New methods for EmacsSavePanel and
3231 EmacsOpenPanel.
3232 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3233
cded56c1
PE
32342013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3235
3236 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3237
251e9147 32382013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3239
3240 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3241 (adjust_after_replace): Make it back to static. Delete the third
3242 arg text_at_gap_tail. Cancel the code for handling it.
3243
3244 * coding.h (struct coding_system): New member eol_seen.
3245
3246 * coding.c (detect_ascii): New function.
3247 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3248 when the source bytes are actually scanned. On detecting for
3249 coding_category_utf_8_auto, call detect_ascii instead of scanning
3250 source bytes directly.
3251 (produce_chars): Call insert_from_gap with the new arg 0.
3252 (encode_coding): Likewise.
3253 (decode_coding_gap): Control ASCII optimization by the variable
3254 disable_ascii_optimization instead of #ifndef .. #endif.
3255 Deccode EOL format according to coding->eol_seen.
3256 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3257 variable.
3258
8a44e6d1
KH
3259 * lisp.h (adjust_after_replace): Cancel externing it.
3260 (insert_from_gap): Adjust prototype.
3261
5f795e34
EZ
32622013-03-15 Eli Zaretskii <eliz@gnu.org>
3263
3264 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3265 FULLSCREEN_MAXIMIZED. (Bug#13935)
3266
f258b4be
DA
32672013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3268
3269 * region-cache.c (find_cache_boundary, move_cache_gap)
3270 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3271 Simplify debugging check and convert to eassert. Adjust comment.
3272 (pp_cache): Put under ENABLE_CHECKING.
3273
a5cc4dde
EZ
32742013-03-14 Eli Zaretskii <eliz@gnu.org>
3275
3276 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3277 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3278 and WM_ACTIVATEAPP.
3279 (w32fullscreen_hook): If the frame is visible, reset
3280 f->want_fullscreen flag after changing the frame size. If the
3281 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3282 (Bug#13953)
3283
3fc5e44a
DC
32842013-03-13 Daniel Colascione <dancol@dancol.org>
3285
3286 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3287 too so that these builds can use Cygwin's file conversion
3288 functions. (We've been building and linking cygw32.o all along
3289 and just not using it.)
3290
47d7532e
PE
32912013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3292
3293 File synchronization fixes (Bug#13944).
3294 * Makefile.in (LIB_FDATASYNC): New macro.
3295 (LIBES): Use it.
3296 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3297 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3298 Don't worry about HAVE_FSYNC, since a substitute fsync is
3299 available if the system lacks one.
3300 (Fwrite_regin): Retry fsync if interrupted.
3301
c7ffccaf
EZ
33022013-03-13 Eli Zaretskii <eliz@gnu.org>
3303
4e2df81d 3304 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3305 activated, call w32fullscreen_hook, to make sure the new frame
3306 dimensions are in effect. (Bug#13937)
3307
8a7debc1
DA
33082013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3309
3310 * xdisp.c (init_iterator): Simplify because both character and byte
3311 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3312 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3313 character and byte positions can be obtained from marker.
8a7debc1 3314
7fd8c501
PE
33152013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3316
d9df6f40
PE
3317 Static checking by Sun C 5.12.
3318 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3319 * bytecode.c (exec_byte_code):
3320 * dispnew.c (init_display):
3321 * eval.c (error):
3322 * fileio.c (Fsubstitute_in_file_name):
3323 * keyboard.c (Fevent_convert_list):
3324 * keymap.c (Fsingle_key_description):
3325 * term.c (maybe_fatal, fatal):
3326 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3327 * xsmfns.c (Fhandle_save_session):
3328 Omit unreachable code.
3329 * keymap.c (map_keymap_char_table_item): Cast void * to
3330 a function pointer type; the C Standard requires this.
3331
7fd8c501
PE
3332 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3333 Include <sys/param.h> unconditionally, as that works elsewhere and
3334 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3335 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3336 and FreeBSD now.
3337
a020afb9 3338See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3339
3340;; Local Variables:
3341;; coding: utf-8
aac0c6e3
MR
3342;; End:
3343
ab422c4d 3344 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3345
3346 This file is part of GNU Emacs.
3347
3348 GNU Emacs is free software: you can redistribute it and/or modify
3349 it under the terms of the GNU General Public License as published by
3350 the Free Software Foundation, either version 3 of the License, or
3351 (at your option) any later version.
3352
3353 GNU Emacs is distributed in the hope that it will be useful,
3354 but WITHOUT ANY WARRANTY; without even the implied warranty of
3355 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3356 GNU General Public License for more details.
3357
3358 You should have received a copy of the GNU General Public License
3359 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.