Invalidate region caches only if buffer text is going to be changed.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
00012b86
DA
12013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Invalidate region caches only if buffer text is going to be changed.
4 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
5 (modify_text): ...new prototype.
6 (prepare_to_modify_buffer_1): New prototype.
7 * textprop.c (modify_region): Rename to...
8 (modify_text_properties): ...new function.
9 (add_text_properties_1, set_text_properties, Fremove_text_properties)
10 (Fremove_list_of_text_properties): Adjust users.
11 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
12 (modify_text): ...new function.
13 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
14 (prepare_to_modify_buffer_1): ...new function.
15 * casefiddle.c (casify_region):
16 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
17 (Ftranspose_regions): Use modify_text.
18
dc6c0eda
SM
192013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
20
21 * lisp.mk (lisp): Add nadvice.elc.
22
8f3a2c26
DA
232013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
24
25 New macro to iterate over live buffers similar to frames.
26 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
27 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
28 Declare buffer-related variables here to offload lisp.h.
29 * buffer.c (Vbuffer_alist): Adjust comment.
30 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
31 (other_buffer_safely):
32 * data.c (store_symval_forwarding):
33 * dispnew.c (Fframe_or_buffer_changed_p):
34 * fileio.c (Fdo_auto_save):
35 * filelock.c (unlock_all_files):
36 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
37
e0fdb694
PE
382013-08-04 Paul Eggert <eggert@cs.ucla.edu>
39
40 Fix some minor races in hosts lacking mkostemp (Bug#15015).
41 * callproc.c (create_temp_file):
42 * filelock.c (create_lock_file):
43 Assume mkostemp, since it's now provided by Gnulib.
44
63f5c6c2
EZ
452013-08-04 Eli Zaretskii <eliz@gnu.org>
46
47 * w32.c (mkostemp): New function.
48 (mktemp): Remove, no longer used. Most of the code reused in
49 mkostemp. (Bug#15015)
484ab239 50 (mktemp): Don't undef.
63f5c6c2 51
f0b79313
DA
522013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
53
54 * dispnew.c (glyph_matrix_count, glyph_pool_count):
55 Move under GLYPH_DEBUG and ENABLE_CHECKING.
56 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
57 (free_glyph_pool, check_glyph_memory): Likewise for
58 all users. Adjust comments where appropriate.
59
98f638d6
PE
602013-08-03 Paul Eggert <eggert@cs.ucla.edu>
61
62 * composite.h: Minor fixups.
63 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
64 to fix a misspelling, and change it to an inline function while
65 we're at it (it need not be a macro). All uses changed.
66 (composition_method, composition_valid_p):
67 Rewrite to avoid assignments in if-conditions.
68
75c59fb3
DA
692013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
70
71 Do not use global Lisp_Object in composition macros.
72 * composite.h (composition_temp): Remove declaration.
73 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
74 (composition_method, composition_valid_p): ...inline functions.
416a3e01 75 (compose_region): Remove the leftover.
75c59fb3
DA
76 * composite.c (composition_temp): Remove.
77 (run_composition_function, update_compositions)
78 (composition_compute_stop_pos, composition_adjust_point)
79 (Ffind_composition_internal):
80 * coding.c (handle_composition_annotation):
81 * xdisp.c (handle_composition_prop, check_point_in_composition):
82 Related users changed.
83
a10c8269
DA
842013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
85
86 Drop FRAME_PTR typedef.
87 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
88 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
89 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
90 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
91 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
92 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
93 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
94 All related users changed.
95
a104f656
SM
962013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
97
98 * eval.c (default_toplevel_binding): New function.
99 (Fdefvar): Use it.
100 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
101 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
102 (syms_of_eval): Export them.
103 * data.c (Fdefault_value): Micro cleanup.
104 * term.c (init_tty): Use "false".
105
4b5c9326
DA
1062013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
107
108 Fix X GC leak in GTK and raw (no toolkit) X ports.
109 * xterm.c (x_free_frame_resources): If white and black relief
110 GCs are allocated, always free them here.
111 * xfns.c (x_make_gc): Omit redundant initialization.
112 * widget.c (create_frame_gcs): Remove the leftover.
113 (EmacsFrameDestroy): Do nothing because all GCs are now freed
114 in x_free_frame_resources.
115
b19aa636
JD
1162013-08-02 Jan Djärv <jan.h.d@swipnet.se>
117
118 * nsterm.m (windowWillResize:toSize:): Only change title if
119 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
120 modifying it.
121 (viewDidEndLiveResize): New method.
122
123 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
124 inside NS_IMPL_COCOA.
125
af1f7e06
DA
1262013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
127
128 * insdel.c (adjust_after_replace, replace_range, del_range_2):
129 Do not check whether undo is enabled because record_insert and
130 record_delete does that themselves.
131
65b02bb9
DA
1322013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
133
134 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
135 member which is not really used any more.
136 (FRAME_XIC_BASE_FONTNAME): Remove.
137 * xfns.c (xic_free_fontset): Adjust user.
138 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
139 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
140 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
141 (xdialog_show): Use eassert for debugging check.
7ee0f047 142 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 143
6318cde0
PE
1442013-08-01 Paul Eggert <eggert@cs.ucla.edu>
145
146 * fileio.c, fns.c (merge): Move extern decl from here ...
147 * lisp.h (merge): ... to here.
148
6c1a09ba
DA
1492013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
150
151 Fix last font-related change.
152 * w32font.h (w32font_list_internal, w32font_match_internal):
153 Fix prototype.
154 * w32uniscribe.c (uniscribe_list, uniscribe_match):
155 (uniscribe_list_family): Adjust to match font API change.
156 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
157 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
158
f8c20208
DA
1592013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
160
161 * frame.h (FRAME_MOUSE_UPDATE):
162 * nsterm.m (ns_frame_up_to_date): Omit redundant check
163 whether hlinfo->mouse_face_mouse_frame is non-NULL.
164
fdb396e2
DA
1652013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
166
167 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
168 * font.h (struct font_driver): Change list, match, and list_family
169 functions to accept struct frame * as first arg.
170 * font.c (font_score, font_compare, font_sort_entities): Remove
171 prototypes.
172 (font_sort_entities, font_list_entities, font_select_entity):
173 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
174 match font API change.
175 * xfont.c (xfont_list, xfont_match, xfont_list_family):
176 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
177 * ftxfont.c (ftxfont_list, ftxfont_match):
178 * xftfont.c (xftfont_list, xftfont_match):
179 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
180 * w32font.c (w32font_list, w32font_match, w32font_list):
181 (w32font_list_internal, w32_font_match_internal): Likewise.
182 * xfaces.c (Fx_family_fonts): Adjust user.
183
52b8a085
DA
1842013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
185
186 Do not use pure Xism x_wm_set_icon_position in non-X ports.
187 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
188 only if HAVE_X_WINDOWS is in use.
189 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
190 * nsterm.m (x_wm_set_icon_position): Remove no-op.
191 * w32term.c (x_wm_set_icon_position): Likewise.
192 * w32fns.c (x_icon): Adjust user.
193
c791c18e
DA
1942013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
195
196 * xterm.c (last_mouse_press_frame): Remove the
197 leftover which is not really used any more.
198 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
199 (x_flush): Call XFlush once per each X display, not frame.
200 This is better because this code always unconditionally skips
201 non-X frames in Vframe_list and issues the only XFlush if we
202 have more than one X frame on the same X display.
2f935d86
DA
203 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
204 Use bool for booleans.
205 (x_draw_glyph_string_background, cvt_string_to_pixel):
206 (cvt_pixel_dtor): Drop unnecessary prototypes.
207 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 208
f435830e
DA
2092013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
210
211 Drop unnecessary functions that deals with frame pixel size.
212 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
213 (x_pixel_height): Drop prototypes.
214 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
215 (x_pixel_height): Drop implementations.
216 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
217 which should be always valid for window frame.
218 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
219 * w32menu.c (Fx_popup_dialog):
220 * xmenu.c (Fx_popup_dialog): Likewise for both.
221
84231434
DA
2222013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
223
224 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
225 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
226 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
227 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
228 and mention nil frame in docstring.
84231434 229
959067a1
DA
2302013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
231
232 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
233 (x_figure_window_size): Likewise. Adjust to return long.
234 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
235 (toplevel): Move Qterminal_live_p to...
236 * terminal.c (toplevel): ...here, make it static, and...
237 (syms_of_terminal): ...DEFSYM here.
238 * frame.h (Qterminal_live_p): Remove declaration.
239 (make_frame, x_figure_window_size): Adjust prototype.
240 * nsfns.m (Fx_create_frame): Use long for window flags.
241
f4b169ce
PE
2422013-07-30 Paul Eggert <eggert@cs.ucla.edu>
243
244 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
245 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
246 Do not assume that emacs_close (INT_MAX) is a no-op.
247
bee6a2c7
DA
2482013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
249
250 * xfaces.c (make_face_cache): For struct face_cache, prefer
251 xmalloc to xzalloc and so avoid redundant call to memset.
252 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
253
d7e6881a
DA
2542013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
255
256 * fringe.c (draw_window_fringes, update_window_fringes)
257 (compute_fringe_widths):
258 * w32term.c (x_draw_glyph_string):
259 * window.c (candidate_window_p, Frecenter):
260 * xfaces.c (realize_basic_faces, realize_default_face)
261 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
262 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
263 * xfns.c (x_set_cursor_color, xic_free_xfontset):
264 * xmenu.c (Fx_menu_bar_open_internal):
265 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
266 * xsettings.c (xft_settings_event):
267 * xterm.c (x_draw_glyph_string, x_had_errors_p):
268 Use bool for booleans. Adjust style and comments where
269 appropriate.
270 * dispextern.h (draw_window_fringes, update_window_fringes)
271 (compute_fringe_widths):
272 * xterm.h (x_had_errors_p): Adjust prototype.
273
ec3058af
DA
2742013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
275
276 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
277 CHECK_LIST. Rewrite the loop to avoid useless local variable.
278
218e0637
DA
2792013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
280
281 * fns.c (toplevel): Remove comment before Fsafe_length because
282 it checks for QUIT.
283
e560aba9
PE
2842013-07-28 Paul Eggert <eggert@cs.ucla.edu>
285
286 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
287
2e5ce5de
EZ
2882013-07-28 Eli Zaretskii <eliz@gnu.org>
289
290 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
291 frame which got the message is still alive, before dereferencing
292 its pointer. (Bug#14970)
293
294 * frame.c (delete_frame): Test "this" frame's minibuffer window to
295 be a live window, before using it as such. (Bug#14970)
296
e95da6d3
EZ
2972013-07-27 Eli Zaretskii <eliz@gnu.org>
298
299 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
300 w32_detect_focus_change instead of doing part of its job by hand.
301 This fixes the problem whereby FOCUS_OUT events were not sent to
302 the event queue.
303
a8f93651
EZ
3042013-07-26 Eli Zaretskii <eliz@gnu.org>
305
fec92060
EZ
306 * process.c (Fprocess_list): Doc fix.
307
a8f93651
EZ
308 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
309 being re-exposed only if it didn't ask to become visible.
310 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
311 was previously iconified. (Bug#14841)
312 (x_iconify_frame): Mark the frame iconified.
313
d5a7a9d9
PE
3142013-07-26 Paul Eggert <eggert@cs.ucla.edu>
315
316 Fix minor problems found by static checking.
317 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
318 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
319
56ea7291
SM
3202013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
321
322 * eval.c (set_specpdl_old_value): New function.
323 (unbind_to): Minor simplification.
324 (get_backtrace_frame): New function.
325 (Fbacktrace_frame): Use it. Add `base' argument.
326 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
327 (syms_of_eval): Export backtrace-eval.
328 * xterm.c (x_focus_changed): Simplify.
329
9d611ffe
PE
3302013-07-25 Paul Eggert <eggert@cs.ucla.edu>
331
332 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
333
999c74e3
EZ
3342013-07-24 Eli Zaretskii <eliz@gnu.org>
335
336 * xdisp.c (redisplay_window): Instead of moving point out of
337 scroll margin, reject the force_start method, and try scrolling
338 instead. (Bug#14780)
339
198fa217
KB
3402013-07-24 Ken Brown <kbrown@cornell.edu>
341
342 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
343 (Bug#14944).
344
53840e55
PE
3452013-07-24 Paul Eggert <eggert@cs.ucla.edu>
346
347 * eval.c (Fprogn): Do not check that BODY is a proper list.
348 This undoes the previous change. The check slows down the
349 interpreter, and is not needed to prevent a crash. See
350 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
351
60967f56
GM
3522013-07-23 Glenn Morris <rgm@gnu.org>
353
354 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
355
9ca960e2
PE
3562013-07-23 Paul Eggert <eggert@cs.ucla.edu>
357
a29c3e6d
PE
358 Port to GNU/Linux systems with tinfo but not ncurses.
359 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
360 to decide whether ncurses is being used. Without this change,
361 GCC complains about tgetent not being declared, on a system
362 that has tinfo installed but ncurses not installed.
363
f274311c
PE
364 * eval.c (Fprogn): Check that BODY is a proper list.
365
16b0520a
PE
366 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
367 * data.c (Fsetq_default):
368 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
369 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
370 (Fcondition_case):
371 Tune by taking advantage of the fact that ARGS is always a list
372 when a function is declared to have UNEVALLED args.
373
9ca960e2
PE
374 * emacsgtkfixed.c: Port to GCC 4.6.
375 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
376
afacaa1b
JB
3772013-07-23 Juanma Barranquero <lekktu@gmail.com>
378
379 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
380 here to silence compiler warnings.
381
368a85a4
PE
3822013-07-22 Paul Eggert <eggert@cs.ucla.edu>
383
384 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
385 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
386 from messing up Emacs's 'struct frame' (Bug#14923).
387
f4e891b5
PE
3882013-07-21 Paul Eggert <eggert@cs.ucla.edu>
389
390 * alloc.c (make_save_ptr_ptr): Define this function.
391 It was inadvertently omitted. It's needed only if
392 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
393
96c8b65e
JD
3942013-07-21 Jan Djärv <jan.h.d@swipnet.se>
395
396 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
397 frame have focus (Bug#14895).
398
ee010797
PE
3992013-07-21 Paul Eggert <eggert@cs.ucla.edu>
400
401 Avoid vfork-related deadlock more cleanly.
402 * callproc.c (child_setup): When the child's exec fails, output
403 the program name, as that's more useful. Use O_NONBLOCK to avoid
404 deadlock.
405 * process.c (create_process_1): Remove; no longer needed.
406 (create_process): Remove timer hack; no longer needed, now that
407 the child avoids deadlock.
408
f0398ec1 4092013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
410
411 * image.c (Fimage_flush): Fix doc typo.
412
b2a069c2
PE
4132013-07-20 Paul Eggert <eggert@cs.ucla.edu>
414
6496aec9
PE
415 Fix array bounds violation when pty allocation fails.
416 * process.c (PTY_NAME_SIZE): New constant.
417 (pty_name): Remove static variable; it's now auto.
418 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
419 Take pty_name as an arg rather than using a static variable.
420 All callers changed.
421 (create_process): Recover pty_flag from process, not from volatile local.
422 (create_pty): Stay inside array even when pty allocation fails.
423 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
424
b2a069c2
PE
425 * lread.c (Fload): Avoid initialization only when lint checking.
426 Mention that it's needed only for older GCCs.
427
99107004
KH
4282013-07-20 Kenichi Handa <handa@gnu.org>
429
430 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
431 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
432
6b1b199d
AS
4332013-07-20 Andreas Schwab <schwab@linux-m68k.org>
434
435 * lread.c (Fload): Avoid uninitialized warning.
436
4195afc3
PE
4372013-07-19 Paul Eggert <eggert@cs.ucla.edu>
438
3f5bef16
PE
439 Fix some minor file descriptor leaks and related glitches.
440 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
441 (create_lock_file): Use write, not emacs_write.
442 * image.c (slurp_file, png_load_body):
443 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
444 (server_accept_connection):
445 Don't leak an fd on memory allocation failure.
446 * image.c (slurp_file): Add a cheap heuristic for growing files.
447 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
448 as that's what the other routines do. Maybe input need not be
449 blocked at all, but it's better to be consistent.
450 Avoid undefined behavior when strlen is zero.
451
4195afc3
PE
452 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
453 (NSTATICS): Now a constant; doesn't need to be a macro.
454
a1aeeffe
RS
4552013-07-19 Richard Stallman <rms@gnu.org>
456
457 * coding.c (decode_coding_utf_8): Add simple loop for fast
458 processing of ASCII characters.
459
63b34baa
PE
4602013-07-19 Paul Eggert <eggert@cs.ucla.edu>
461
462 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
463
621dd9ac
EZ
4642013-07-19 Eli Zaretskii <eliz@gnu.org>
465
466 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
467 unportable 'struct x_display_info'.
468 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
469 is a portable type.
470
1396ac86
PE
4712013-07-19 Paul Eggert <eggert@cs.ucla.edu>
472
ab9980cd
PE
473 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
474 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
475 or fscanf fails.
476 (system_process_attributes): Prefer plain char to unsigned char
477 when either will do. Clean up properly if interrupted or if
478 memory allocations fail. Don't assume sscanf succeeds. Remove
479 no-longer-needed workaround to stop GCC from whining. Read
480 command-line once, instead of multiple times. Check read status a
481 bit more carefully.
482
1396ac86
PE
483 Fix obscure porting bug with varargs functions.
484 The code assumed that int is treated like ptrdiff_t in a vararg
485 function, which is not a portable assumption. There was a similar
486 -- though these days less likely -- porting problem with various
487 assumptions that pointers of different types all smell the same as
488 far as vararg functions is conserved. To make this problem less
489 likely in the future, redo the API to use varargs functions.
490 * alloc.c (make_save_value): Remove this vararg function.
491 All uses changed to ...
492 (make_save_int_int_int, make_save_obj_obj_obj_obj)
493 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
494 New functions.
495 (make_save_ptr): Rename from make_save_pointer, for consistency with
496 the above. Define only on platforms that need it. All uses changed.
497
4d19d194
PE
4982013-07-18 Paul Eggert <eggert@cs.ucla.edu>
499
500 * keyboard.c: Try to fix typos in previous change.
501 (DISPLAY_LIST_INFO): New macro.
502 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 503 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 504
945c5bb1
JB
5052013-07-18 Juanma Barranquero <lekktu@gmail.com>
506
507 * keyboard.c (kbd_buffer_get_event):
508 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
509 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
510
f4b1eb36
PE
5112013-07-18 Paul Eggert <eggert@cs.ucla.edu>
512
5e679a2c
PE
513 * filelock.c: Fix unlikely file descriptor leaks.
514 (get_boot_time_1): Rework to avoid using emacs_open.
515 This doesn't actually fix a leak, but is better anyway.
516 (read_lock_data): Use read, not emacs_read.
517
a8cd4836
PE
518 * doc.c: Fix minor memory and file descriptor leaks.
519 * doc.c (get_doc_string): Fix memory leak when doc file absent.
520 (get_doc_string, Fsnarf_documentation):
521 Fix file descriptor leak on error.
522
ef30e638
PE
523 * term.c: Fix minor fdopen-related file descriptor leaks.
524 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
525 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
526
f4b1eb36
PE
527 * charset.c: Fix file descriptor leaks and errno issues.
528 Include <errno.h>.
529 (load_charset_map_from_file): Don't leak file descriptor on error.
530 Use plain record_xmalloc since the allocation is larger than
531 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
532 of entries.
533 * eval.c (record_unwind_protect_nothing):
534 * fileio.c (fclose_unwind):
535 New functions.
536 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
537 The replacement doesn't block input, but that no longer seems
538 necessary.
539
b648c163
PE
5402013-07-17 Paul Eggert <eggert@cs.ucla.edu>
541
a0931322
PE
542 * lread.c: Fix file descriptor leaks and errno issues.
543 (Fload): Close some races that leaked fds or streams when 'load'
544 was interrupted.
545 (Fload, openp): Report error number of last nontrivial failure to open.
546 ENOENT counts as trivial.
547 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
548 New functions.
549 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
550 now that the function is always called with a nonnegative arg.
551 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
552 All uses replaced with ...
553 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
554
b648c163
PE
555 A few more minor file errno-reporting bugs.
556 * callproc.c (Fcall_process):
557 * doc.c (Fsnarf_documentation):
558 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
559 * process.c (set_socket_option):
560 Don't let a constructor trash errno.
561 * doc.c: Include <errno.h>.
562
b1dc4084
JB
5632013-07-16 Juanma Barranquero <lekktu@gmail.com>
564
565 * w32fns.c (unwind_create_tip_frame): Fix declaration.
566
c43843aa
PE
5672013-07-16 Paul Eggert <eggert@cs.ucla.edu>
568
50a30cce
PE
569 Fix w32 bug with call-process-region (Bug#14885).
570 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
571 to Fcall_process when the input is empty. This simplifies the
572 code a bit. It makes no difference on POSIXish platforms but
573 apparently it fixes a bug on w32.
574
44e18199 575 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
576 * fileio.c (close_file_unwind): Don't close if FD is negative;
577 this can happen when unwinding a zapped file descriptor.
578 (Finsert_file_contents): Unwind-protect the fd before the point marker,
579 in case Emacs runs out of memory between the two unwind-protects.
580 Don't trash errno when closing FD.
581 Zap the FD in the specpdl when closing it, instead of deferring
582 the removal of the unwind-protect; this fixes a bug where a child
583 function unwinds the stack past us.
584
27e498e6
PE
585 New unwind-protect flavors to better type-check C callbacks.
586 This also lessens the need to write wrappers for callbacks,
587 and the need for make_save_pointer.
588 * alloca.c (free_save_value):
589 * atimer.c (run_all_atimers):
590 Now extern.
591 * alloc.c (safe_alloca_unwind):
592 * atimer.c (unwind_stop_other_atimers):
593 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
594 * menu.c (cleanup_popup_menu) [HAVE_NS]:
595 * minibuf.c (choose_minibuf_frame_1):
596 * process.c (make_serial_process_unwind):
597 * xdisp.h (pop_message_unwind):
598 * xselect.c (queue_selection_requests_unwind):
599 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
600 * alloca.c (record_xmalloc):
601 Prefer record_unwind_protect_ptr to record_unwind_protect with
602 make_save_pointer.
603 * alloca.c (Fgarbage_collect):
604 Prefer record_unwind_protect_void to passing a dummy.
605 * buffer.c (restore_buffer):
606 * window.c (restore_window_configuration):
607 * xfns.c, w32fns.c (do_unwind_create_frame)
608 New wrapper. All record-unwind uses of wrappee changed.
609 * buffer.c (set_buffer_if_live):
610 * callproc.c (call_process_cleanup, delete_temp_file):
611 * coding.c (code_conversion_restore):
612 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
613 * editfns.c (save_excursion_restore)
614 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
615 (save_restriction_restore):
616 * eval.c (restore_stack_limits, un_autoload):
617 * fns.c (require_unwind):
618 * keyboard.c (recursive_edit_unwind, tracking_off):
619 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
620 * macros.c (pop_kbd_macro, restore_menu_items):
621 * nsfns.m (unwind_create_frame):
622 * print.c (print_unwind):
623 * process.c (start_process_unwind):
624 * search.c (unwind_set_match_data):
625 * window.c (select_window_norecord, select_frame_norecord):
626 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
627 (fast_set_selected_frame):
628 * xfns.c, w32fns.c (unwind_create_tip_frame):
629 Return void, not a dummy Lisp_Object. All uses changed.
630 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
631 * callproc.c (call_process_kill):
632 * fileio.c (restore_point_unwind, decide_coding_unwind)
633 (build_annotations_unwind):
634 * insdel.c (Fcombine_after_change_execute_1):
635 * keyboard.c (read_char_help_form_unwind):
636 * menu.c (unuse_menu_items):
637 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
638 * sound.c (sound_cleanup):
639 * xdisp.c (unwind_redisplay):
640 * xfns.c (clean_up_dialog):
641 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
642 Accept no args and return void, instead of accepting and returning
643 a dummy Lisp_Object. All uses changed.
644 * cygw32.c (fchdir_unwind):
645 * fileio.c (close_file_unwind):
646 * keyboard.c (restore_kboard_configuration):
647 * lread.c (readevalllop_1):
648 * process.c (wait_reading_process_output_unwind):
649 Accept int and return void, rather than accepting an Emacs integer
650 and returning a dummy object. In some cases this fixes an
651 unlikely bug when the corresponding int is outside Emacs integer
652 range. All uses changed.
653 * dired.c (directory_files_internal_unwind):
654 * fileio.c (do_auto_save_unwind):
655 * gtkutil.c (pop_down_dialog):
656 * insdel.c (reset_var_on_error):
657 * lread.c (load_unwind):
658 * xfns.c (clean_up_file_dialog):
659 * xmenu.c, nsmenu.m (pop_down_menu):
660 * xmenu.c (cleanup_widget_value_tree):
661 * xselect.c (wait_for_property_change_unwind):
662 Accept pointer and return void, rather than accepting an Emacs
663 save value encapsulating the pointer and returning a dummy object.
664 All uses changed.
665 * editfns.c (Fformat): Update the saved pointer directly via
666 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
667 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
668 (unwind_body): New function.
669 (record_unwind_protect): First arg is now a function returning void,
670 not a dummy Lisp_Object.
671 (record_unwind_protect_ptr, record_unwind_protect_int)
672 (record_unwind_protect_void): New functions.
673 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
674 * fileio.c (struct auto_save_unwind): New type.
675 (do_auto_save_unwind): Use it.
676 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
677 * insdel.c (struct rvoe_arg): New type.
678 (reset_var_on_error): Use it.
679 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
680 New constants.
681 (specbinding_func): Remove; there are now several such functions.
682 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
683 (set_unwind_protect_ptr): New function.
684 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
685
4e604a5d
PE
686 Be simpler and more consistent about reporting I/O errors.
687 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
688 Say "Read error" and "Write error", rather than "I/O error", or
689 "IO error reading", or "IO error writing", when a read or write
690 error occurs.
691 * process.c (Fmake_network_process, wait_reading_process_output)
692 (send_process, Fprocess_send_eof, wait_reading_process_output):
693 Capitalize diagnostics consistently. Put "failed foo" at the
694 start of the diagnostic, so that we don't capitalize the
695 function name "foo". Consistently say "failed" for such
696 diagnostics.
697 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
698 All callers changed. This is so it can use report_file_error.
699 * sysdep.c (serial_open, serial_configure): Capitalize I/O
700 diagnostics consistently as above.
701
a9757f6a
PE
702 * fileio.c (report_file_errno): Fix errno reporting bug.
703 If the file name is neither null nor a pair, package it up as a
704 singleton list. All callers changed, both to this function and to
705 report_file_error. This fixes a bug where the memory allocator
706 invoked by list1 set errno so that the immediately following
707 report_file_error reported the wrong errno value.
708
c43843aa
PE
709 Fix minor problems found by --enable-gcc-warnings.
710 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
711 * keyboard.c (kbd_buffer_get_event): Remove unused local.
712
18c26d81
JD
7132013-07-16 Jan Djärv <jan.h.d@swipnet.se>
714
715 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
716 Set event->arg to Qt if switch-event shall be generated.
717 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
718
719 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
720
721 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
722 FOCUS_OUT_EVENT.
723
724 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
725 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
726 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
727 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 728 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
729 and there is a focused frame.
730 (head_table): Add focus-in and focus-out.
731 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
732 bind to handle-focus-in/out.
733
734 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
735 (Fhandle_switch_frame): Call Fhandle_focus_in.
736 (syms_of_frame): defsubr handle-focus-in/out.
737
6c6f1994
PE
7382013-07-16 Paul Eggert <eggert@cs.ucla.edu>
739
c7ddc792
PE
740 Fix porting bug to older POSIXish platforms (Bug#14862).
741 * sysdep.c (emacs_pipe): New function, that implements
742 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
743 This should port better to CentOS 5 and to Mac OS X 10.6.
744 All calls to pipe2 changed.
745
6c6f1994
PE
746 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
747 This makes the code easier to read and the executable a bit smaller.
748 Do not replace all calls to Fcons that happen to create lists,
749 just calls that are intended to create lists. For example, when
750 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
751 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
752 Similarly for list2 through list5.
753 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
754 * bytecode.c (exec_byte_code):
755 * callint.c (quotify_arg, Fcall_interactively):
756 * callproc.c (Fcall_process, create_temp_file):
757 * charset.c (load_charset_map_from_file)
758 (Fdefine_charset_internal, init_charset):
759 * coding.c (get_translation_table, detect_coding_system)
760 (Fcheck_coding_systems_region)
761 (Fset_terminal_coding_system_internal)
762 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
763 * composite.c (update_compositions, Ffind_composition_internal):
764 * dired.c (directory_files_internal, file_name_completion)
765 (Fsystem_users):
766 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
767 * doc.c (Fsnarf_documentation):
768 * editfns.c (Fmessage_box):
769 * emacs.c (main):
770 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
771 (Feval, eval_sub, Ffuncall, apply_lambda):
772 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
773 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
774 (Fset_file_times, Finsert_file_contents)
775 (Fchoose_write_coding_system, Fwrite_region):
776 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
777 * font.c (font_registry_charsets, font_parse_fcname)
778 (font_prepare_cache, font_update_drivers, Flist_fonts):
779 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
780 * frame.c (make_frame, Fmake_terminal_frame)
781 (x_set_frame_parameters, x_report_frame_params)
782 (x_default_parameter, Fx_parse_geometry):
783 * ftfont.c (syms_of_ftfont):
784 * image.c (gif_load):
785 * keyboard.c (command_loop_1):
786 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
787 (Fcopy_keymap, append_key, Fcurrent_active_maps)
788 (Fminor_mode_key_binding, accessible_keymaps_1)
789 (Faccessible_keymaps, Fwhere_is_internal):
790 * lread.c (read_emacs_mule_char):
791 * menu.c (find_and_return_menu_selection):
792 * minibuf.c (get_minibuffer):
793 * nsfns.m (Fns_perform_service):
794 * nsfont.m (ns_script_to_charset):
795 * nsmenu.m (ns_popup_dialog):
796 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
797 (Fx_own_selection_internal):
798 * nsterm.m (append2):
799 * print.c (Fredirect_debugging_output)
800 (print_prune_string_charset):
801 * process.c (Fdelete_process, Fprocess_contact)
802 (Fformat_network_address, set_socket_option)
803 (read_and_dispose_of_process_output, write_queue_push)
804 (send_process, exec_sentinel):
805 * sound.c (Fplay_sound_internal):
806 * textprop.c (validate_plist, add_properties)
807 (Fput_text_property, Fadd_face_text_property)
808 (copy_text_properties, text_property_list, syms_of_textprop):
809 * unexaix.c (report_error):
810 * unexcoff.c (report_error):
811 * unexsol.c (unexec):
812 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
813 (Fformat_mode_line, syms_of_xdisp):
814 * xfaces.c (set_font_frame_param)
815 (Finternal_lisp_face_attribute_values)
816 (Finternal_merge_in_global_face, syms_of_xfaces):
817 * xfns.c (x_default_scroll_bar_color_parameter)
818 (x_default_font_parameter, x_create_tip_frame):
819 * xfont.c (xfont_supported_scripts):
820 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
821 (menu_help_callback, xmenu_show):
822 * xml.c (make_dom):
823 * xterm.c (set_wm_state):
824 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
825 and similarly for list2 through list5.
826
bafe80ce
PE
8272013-07-15 Paul Eggert <eggert@cs.ucla.edu>
828
829 * callproc.c (Fcall_process_region): Fix minor race and tune.
830 (create_temp_file): New function, with the temp-file-creation part
831 of the old Fcall_process_region. Use Fcopy_sequence to create the
832 temp file name, rather than alloca + build_string, for simplicity.
833 Don't bother to block input around the temp file creation;
834 shouldn't be needed. Simplify use of mktemp. Use
835 record_unwind_protect immediately after creating the temp file;
836 this closes an unlikely race where the temp file was not removed.
837 Use memcpy rather than an open-coded loop.
838 (Fcall_process_region): Use the new function. If the input is
839 empty, redirect from /dev/null rather than from a newly created
840 empty temp file; this avoids unnecessary file system traffic.
841
4700b5a5
PE
8422013-07-14 Paul Eggert <eggert@cs.ucla.edu>
843
5c97beae
PE
844 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
845 Simplify by making this case like the other two. This is a bit
846 slower on obsolete hosts, but the extra complexity isn't worth it.
847
4700b5a5
PE
848 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
849 * process.c (create_process) [!DOS_NT]:
850 Remove now-unnecessary calls to emacs_close.
851
f9a74c4c
EZ
8522013-07-13 Eli Zaretskii <eliz@gnu.org>
853
922ae7ee
EZ
854 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
855 returning early. (Bug#14850)
856
f9a74c4c
EZ
857 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
858 and inhibit-iso-escape-detection attributes of 'undecided'.
859 (Bug#14822)
860
5e301d76
PE
8612013-07-13 Paul Eggert <eggert@cs.ucla.edu>
862
69e0e5ee
PE
863 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
864 Reported by Herbert J. Skuhra in
865 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
866
5e301d76
PE
867 Don't lose top specpdl entry when memory is exhausted.
868 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
869 specpdl overflow here, to simplify callers; all callers changed.
870 Always reserve an unused entry at the stack top; this avoids
871 losing the top entry's information when memory is exhausted.
872
7e649856
PE
8732013-07-12 Paul Eggert <eggert@cs.ucla.edu>
874
a773ed9a
PE
875 Clean up errno reporting and fix some errno-reporting bugs.
876 * callproc.c (Fcall_process):
877 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
878 * process.c (create_process, Fmake_network_process):
879 * unexaix.c (report_error):
880 * unexcoff.c (report_error):
881 Be more careful about reporting the errno of failed operations.
882 The code previously reported the wrong errno sometimes.
883 Also, prefer report_file_errno to setting errno + report_file_error.
884 (Fcall_process): Look at openp return value rather than at path,
885 as that's a bit faster and clearer when there's a numeric predicate.
886 * fileio.c (report_file_errno): New function, with most of the
887 old contents of report_file_error.
888 (report_file_error): Use it.
889 (Ffile_exists_p, Ffile_accessible_directory_p):
890 Set errno to 0 when it is junk.
891 * fileio.c (Faccess_file):
892 * image.c (x_create_bitmap_from_file):
893 Use faccessat rather than opening the file, to avoid the hassle of
894 having a file descriptor open.
895 * lisp.h (report_file_errno): New decl.
896 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
897
7e649856
PE
898 Minor EBADF fixes.
899 * process.c (create_process, wait_reading_process_output) [AIX]:
900 Remove obsolete SIGHUP-related code, as Emacs no longer disables
901 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
902 a multithreaded environment anyway).
903 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
904
f6774c1a
AS
9052013-07-12 Andreas Schwab <schwab@linux-m68k.org>
906
907 * image.c (x_find_image_file): Don't close a remote file handle.
908
bacba3c2
PE
9092013-07-12 Paul Eggert <eggert@cs.ucla.edu>
910
911 Fix races with threads and file descriptors.
912 * callproc.c (Fcall_process_region):
913 * dired.c (open_directory):
914 * emacs.c (main, Fdaemon_initialized):
915 * image.c (x_find_image_file):
916 * inotify.c (Finotify_rm_watch):
917 * lread.c (Flocate_file_internal):
918 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
919 * term.c (term_mouse_moveto, init_tty):
920 * termcap.c (tgetent):
921 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
922 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
923 * unexhp9k800.c, unexmacosx.c (unexec):
924 * callproc.c (Fcall_process_region):
925 Use emacs_close, not close.
926 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
927 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
928 and posix_close function on current platforms (which all lack them).
929 (emacs_close): Use it. This should fix the races on GNU/Linux and
930 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
931 and it should avoid closing random victim file descriptors on
932 other platforms.
933
653d4f43
PE
9342013-07-11 Paul Eggert <eggert@cs.ucla.edu>
935
c8536ec4
PE
936 * inotify.c (uninitialized): Remove. All uses replaced by -1.
937 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
938 Touch up doc a bit.
939
9c203066
PE
940 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
941 This is for .gdbinit xbacktrace.
942
653d4f43
PE
943 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
944 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
945 (emacs_set_tty): Now static.
946 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
947 * term.c (tty_capable_p, tty_default_color_capabilities)
948 (get_tty_terminal, term_mouse_movement)
949 (handle_one_term_event, init_tty, maybe_fatal):
950 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
951 (tgetent, scan_file, name_match, compare_contin):
952 * terminal.c (get_terminal):
953 Use bool for boolean.
954 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
955 Prefer char to unsigned char if either will do.
956 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
957 (tty_write_glyphs): Prefer int to unsigned.
958 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
959 All callers changed.
960 * termcap.c (tprint, main) [TEST]: Remove non-working test.
961
45b683a1
PE
9622013-07-10 Paul Eggert <eggert@cs.ucla.edu>
963
29abe551
PE
964 Port to C89.
965 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
966 (B__dummy__): New dummy symbol, to pacify C89.
967 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
968 they can't grok varargs macros.
969 * dispnew.c (add_window_display_history)
970 (add_frame_display_history):
971 * print.c (print_object):
972 * xdisp.c (debug_method_add):
973 Use %p printf format only for void pointers.
974 * emacs.c (usage_message): New constant, replacing ...
975 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
976 (main): Adjust to usage reorg.
977 * fns.c (syms_of_fns):
978 * profiler.c (syms_of_profiler):
979 Don't use non-constant struct initializers.
980 * gnutls.h (gnutls_initstage_t):
981 * lisp.h (enum Lisp_Fwd_Type):
982 * lread.c (lisp_file_lexically_bound_p):
983 * xsettings.c (anonymous enum):
984 Remove trailing comma.
985 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
986 * lisp.h (ENUM_BF): Use unsigned if pedantic.
987 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
988 (DEFUN): Use it.
989 * regex.c (const_re_char): New type, to pacify strict C89.
990 All uses of 'const re_char' replaced to use it.
991 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
992 with glibc when strict C89. This change is imported from gnulib.
993 All uses changed.
994 (_Restrict_arr_): Rename from __restrict_arr, similarly.
995 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
996 Omit GNU_LINUX implementation, since it requires long long.
997 * xterm.c (x_draw_underwave):
998 Do not assume the traditional order of struct's members.
999 (x_term_init): Rewrite to avoid the need for non-constant structure
1000 initializers.
1001
45b683a1 1002 Syntax cleanup, mostly replacing macros with functions.
763a086d 1003 This removes the need for the syntax_temp hack.
45b683a1
PE
1004 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1005 * syntax.c (SYNTAX_INLINE): New macro.
1006 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1007 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1008 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1009 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1010 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1011 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1012 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1013 Now constants, not macros.
1014 (syntax_temp) [!__GNUC__]: Remove.
1015 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1016 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1017 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1018 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1019 Move here from syntax.h; now functions, not macros. Except for the
1020 last function, these are static since only syntax.c uses them.
1021 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1022 All uses changed. Now a function, not a macro; use this fact
1023 to simplify the code.
1024 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1025 compiler bugs; no longer relevant.
1026 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1027 (SYNTAX_INLINE): New macro.
1028 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1029 for the new functions. Use bool for boolean member.
1030 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1031 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1032 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1033 (SETUP_BUFFER_SYNTAX_TABLE):
1034 Now extern inline functions, not macros.
1035 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1036 Remove; all uses replaced by implementation.
1037 (syntax_temp) [!__GNUC__]: Remove decl.
1038 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1039
29be4a50
JD
10402013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1041
1042 * emacs.c (main): Fix syntax error.
1043
954b166e
PE
10442013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1045
1046 Timestamp fixes for undo (Bug#14824).
1047 * atimer.c (schedule_atimer):
1048 * fileio.c (Ffile_newer_than_file_p):
1049 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1050 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1051 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1052 (syms_of_fileio): Remove Sclear_visited_file_name.
1053 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1054 file doesn't exist; this avoids an ambiguity with negative timestamps.
1055 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1056 * systime.h (make_emacs_time, invalid_emacs_time):
1057 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1058 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1059 * undo.c (record_first_change): Push (visited-file-modtime) onto
1060 undo list rather than reimplementing it by hand, incorrectly.
1061
d74647c3
KB
10622013-07-09 Ken Brown <kbrown@cornell.edu>
1063
1064 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1065
3c51b96b
JB
10662013-07-09 Juanma Barranquero <lekktu@gmail.com>
1067
1068 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1069
4ebbdd67
PE
10702013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 Handle errno and exit status a bit more carefully.
1073 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1074 number into an exit status. Instead, use EXIT_CANCELED.
1075 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1076 * callproc.c (relocate_fd):
1077 * emacs.c (close_output_streams, main):
1078 * process.c (create_process):
1079 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1080 Use emacs_perror for simplicity.
1081 * callproc.c (relocate_fd, main):
1082 * sysdep.c (sys_subshell):
1083 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1084 (shut_down_emacs): Use emacs_write, not write.
1085 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1086 * fileio.c (Fcopy_file, e_write):
1087 * nsterm.m (ns_select):
1088 * process.c (send_process):
1089 * sound.c (vox_write):
1090 Use emacs_write_sig, not emacs_write.
1091 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1092 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1093 New constants.
1094 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1095 of write.
1096 (emacs_full_write): New function.
1097 (emacs_write): Rewrite to use it.
1098 (emacswrite_sig, emacs_perror): New functions.
1099 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1100
44e18199 11012013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1102
1103 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1104 on NS even if it is present. Pixmap on NS is a void*.
1105
9caab067
PE
11062013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1107
1108 Port to Ubuntu 10 (Bug#14803).
1109 Problem reported by T.V. Raman.
1110 * process.c (close_on_exec, accept4, process_socket):
1111 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1112
1d442672
EZ
11132013-07-07 Eli Zaretskii <eliz@gnu.org>
1114
1115 * w32.c (sys_dup): Declare prototype.
1116
1117 * filelock.c:
1118 * emacs.c:
1119 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1120
067428c1
PE
11212013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1122
1123 Make file descriptors close-on-exec when possible (Bug#14803).
1124 This simplifies Emacs a bit, since it no longer needs to worry
1125 about closing file descriptors by hand in some cases.
1126 It also fixes some unlikely races. Not all such races, as
1127 libraries often open files internally without setting
1128 close-on-exec, but it's an improvement.
1129 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1130 * callproc.c (Fcall_process) [!MSDOS]:
1131 * emacs.c (main) [!DOS_NT]:
1132 * nsterm.m (ns_term_init):
1133 * process.c (create_process):
1134 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1135 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1136 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1137 Prefer mkostemp with O_CLOEXEC to mkstemp.
1138 * callproc.c (relocate_fd) [!WINDOWSNT]:
1139 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1140 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1141 now using pipe2.
1142 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1143 Make the resulting file descriptor close-on-exec.
1144 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1145 * lread.c (load_descriptor_list, load_descriptor_unwind):
1146 Remove; no longer needed. All uses removed.
1147 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1148 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1149 New functions.
1150 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1151 (Fmake_network_process, Fnetwork_interface_list):
1152 (Fnetwork_interface_info, server_accept_connection):
1153 Make newly-created socket close-on-exec.
1154 * sysdep.c (emacs_open, emacs_fopen):
1155 Make new-created descriptor close-on-exec.
1156 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1157 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1158
0da857dd
JD
11592013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1160
1161 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1162 for NS_IMPL_GNUSTEP.
1163
5f86adcd
PE
11642013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1165
1166 Fix openp errno handling.
1167 * callproc.c (Fcall_process): Preserve openp errno around close.
1168 * lread.c (openp): Set errno when returning -1, as some callers
1169 expect this.
1170
1afb1d07
JD
11712013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1172
1173 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1174
1175 * nsterm.h (NSSavePanel): Update comment.
1176 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1177 (ns_run_file_dialog): Declare.
1178
1179 * nsfns.m: Remove panelOK.
1180 (ns_fd_data): New.
1181 (ns_run_file_dialog): New function.
1182 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1183 event loop, so file dialog is popped up by ns_run_file_dialog, called
1184 by sendEvent (Bug#14578).
1185 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1186
3323c263
EZ
11872013-07-06 Eli Zaretskii <eliz@gnu.org>
1188
fdda0220
EZ
1189 * xdisp.c (default_line_pixel_height): New function.
1190 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1191 (try_cursor_movement, redisplay_window, try_window)
1192 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1193
1194 * window.c (window_scroll_pixel_based): use
1195 default_line_pixel_height.
1196
1197 * dispextern.h (default_line_pixel_height): Add prototype.
1198
1199 * frame.c (x_set_line_spacing): Accept a float value for
1200 line-spacing parameter, per the documentation.
1201
3323c263
EZ
1202 * data.c (Fmultibyte_string_p): Doc fix.
1203
47ba6d43
PE
12042013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1205
406af475
PE
1206 Use emacs_open more consistently when opening files.
1207 This handles EINTR more consistently now, and makes it easier
1208 to introduce other uniform changes to file descriptor handling.
1209 * src/systdio.h: New file.
1210 * src/buffer.c (mmap_init):
1211 * cygw32.c (chdir_to_default_directory):
1212 * dispnew.c (Fopen_termscript):
1213 * emacs.c (Fdaemon_initialized):
1214 * fileio.c (Fdo_auto_save):
1215 * image.c (slurp_file, png_load_body, jpeg_load_body):
1216 * keyboard.c (Fopen_dribble_file):
1217 * lread.c (Fload):
1218 * print.c (Fredirect_debugging_output):
1219 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1220 * termcap.c (tgetent):
1221 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1222 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1223 * w32term.c (w32_initialize) [CYGWIN]:
1224 * xfaces.c (Fx_load_color_file):
1225 Use emacs_open instead of plain open, and emacs_fopen instead of
1226 plain fopen.
1227 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1228 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1229 * callproc.c (default_output_mode): New constant.
1230 (Fcall_process): Use it to call emacs_open instead of plain creat.
1231 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1232 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1233 (emacs_fopen): New function.
1234 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1235 Include <lisp.h>, for emacs_open.
1236 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1237
47ba6d43
PE
1238 Remove duplicate #include directives.
1239 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1240 * xfaces.c:
1241 Don't include stdio.h twice.
1242 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1243 Don't include sys/types.h or stdio.h twice.
1244 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1245 * lread.c: Don't include coding.h twice.
1246 * nsfont.m: Don't include frame.h twice.
1247 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1248 * ralloc.c: Don't include <unistd.h> twice.
1249 * xdisp.c: Don't include font.h twice.
1250 * xterm.c: Don't include fontset.h twice.
1251 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1252
b9ed53d5
PE
12532013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 Scale ImageMagick images more carefully.
1256 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1257 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1258 Be more careful about avoiding undefined behavior after
1259 integer overflow and division by zero.
1260
cf13177e
YM
12612013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1262
1263 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1264 (syms_of_w32fns): DEFSYM them.
1265 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1266 (CCHDEVICENAME): Define macros if not defined.
1267 (struct MONITOR_INFO_EX): New struct.
1268 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1269 (enum_display_monitors_fn): New variable.
1270 (globals_of_w32fns): Initialize it.
1271 (Fx_display_pixel_width, Fx_display_pixel_height)
1272 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1273 multi-monitor setups in docstrings.
1274 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1275 screen size by primary monitor's millimeter per pixel.
1276 (w32_monitor_enum, w32_display_monitor_attributes_list)
1277 (w32_display_monitor_attributes_list_fallback)
1278 (Fw32_display_monitor_attributes_list): New functions.
1279 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1280
1281 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1282 if not defined.
1283 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1284
86dfb7a8
MA
12852013-07-04 Michael Albinus <michael.albinus@gmx.de>
1286
1287 * fileio.c (Qfile_notify_error): New error symbol.
1288
1289 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1290 * inotify.c (inotify_callback, symbol_to_inotifymask)
1291 (Finotify_add_watch, Finotify_rm_watch): Use it.
1292 (inotifyevent_to_event): Exchange order of cookie and file name.
1293 (Finotify_add_watch): Adapt docstring.
1294
1295 * lisp.h (Qfile_notify_error): Declare.
1296
2c1c974b
PE
12972013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1300 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1301 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1302 which did not work (see <http://bugs.gnu.org/14569#307>).
1303 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1304 && (!noninteractive || initialized)). This attempts to thread
1305 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1306
7a35b20f
JB
13072013-07-04 Juanma Barranquero <lekktu@gmail.com>
1308
1309 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1310 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1311
1ce5cd04
PE
13122013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1315 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1316 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1317 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1318
57f8c490
PE
13192013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1322 Define to __sys_siglist.
1323
bcffb5ca
EZ
13242013-07-02 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1327 word-wrap, so that overflow-newline-into-fringe would work in
1328 visual-line-mode. (Bug#2749)
1329 (move_it_in_display_line_to): When the last scanned display
1330 element fits exactly on the display line, and
1331 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1332 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1333 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1334 finding buffer position that corresponds to pixel coordinates,
1335 e.g. in buffer_posn_from_coords.
1336
2c41e781
JD
13372013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1338
1339 * process.c (handle_child_signal): Call catch_child_signal if
1340 NS_IMPL_GNUSTEP.
1341
c2418359
PE
13422013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1343
52a9bcae
PE
1344 Don't convert function pointers to void * and back.
1345 It isn't portable C, and it's easy enough to avoid.
1346 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1347 (make_save_value): Add support for SAVE_FUNCPOINTER.
1348 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1349 * print.c (print_object):
1350 Distinguish function from object pointers.
1351 * lisp.h (SAVE_FUNCPOINTER): New constant.
1352 (SAVE_SLOT_BITS): Adjust to it.
1353 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1354 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1355 (voidfuncptr): New typedef.
1356 (struct Lisp_Save_Value): New member data[0].funcpointer.
1357 (XSAVE_FUNCPOINTER): New function.
1358
c2418359
PE
1359 Simplify buildobj processing.
1360 * Makefile.in (buildobj.h): Make it a sequence of strings each
1361 followed by comma, rather than a single string. Put it into a
1362 .tmp file in case there's an error while generating it.
1363 (gl-stamp): Use .tmp for temp files.
1364 (mostlyclean): Clean .tmp files.
1365 * doc.c (buildobj): Move to just the routine that needs it.
1366 It's now an array of strings, so processing is simpler.
1367
8f43ce49
PE
13682013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1371 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1372 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1373 Invoke malloc_enable_thread even when not interactive.
1374 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1375 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1376 in this case, since the underlying bug has now been fixed.
1377
24827db9
JB
13782013-07-01 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1381 unlinking it (bug#14691).
1382
ef099a94
MN
13832013-06-30 Michal Nazarewicz <mina86@mina86.com>
1384
1385 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1386 before checking whether buffer is modified. This lets
1387 `kill-buffer-query-functions' cancel killing of the buffer or save
1388 its content before `kill-buffer' asks user the "Buffer %s
1389 modified; kill anyway?" question.
1390
9d3f2fc2
JD
13912013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1392
1393 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1394 Let the super performKeyEquivalent deal with them (Bug#14747).
1395
e6c6c8c7
PE
13962013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1397
1d71c1d9
PE
1398 * widget.c (resize_cb): Remove unused local.
1399
8f5f35cc
PE
1400 Do not use GTK 3 if it exists but cannot be compiled.
1401 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1402 * xterm.c (x_error_handler) [!USE_GTK]:
1403 Do not use GTK 3.
1404
e6c6c8c7
PE
1405 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1406
0ba54312
EZ
14072013-06-30 Eli Zaretskii <eliz@gnu.org>
1408
5d1c3286
EZ
1409 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1410 to the valid range of values. (Bug#14753)
1411
0ba54312
EZ
1412 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1413 when moving point by using the current glyph matrix. This avoids
1414 the need to force redisplay when this function is called in a
1415 loop.
1416
9c90cc06
PE
14172013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 Fix minor problems found by static checking.
1420 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1421 Redo the latter's body to sidestep GCC parenthesization warnings.
1422 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1423 * coding.c (detect_coding, detect_coding_system):
1424 * coding.h (struct undecided_spec):
1425 Use bool for boolean.
1426 * image.c (QCmax_width, QCmax_height): Now static.
1427 * xdisp.c (Fmove_point_visually): Remove unused local.
1428
4c672a0f
EZ
14292013-06-29 Eli Zaretskii <eliz@gnu.org>
1430
1431 * xdisp.c (Fmove_point_visually): New function.
1432
c1ea3abf
JB
14332013-06-28 Kenichi Handa <handa@gnu.org>
1434
1435 * coding.h (define_coding_undecided_arg_index): New enum.
1436 (coding_attr_index): New members
1437 coding_attr_undecided_inhibit_null_byte_detection,
1438 coding_attr_undecided_inhibit_iso_escape_detection,
1439 coding_attr_undecided_prefer_utf_8.
1440 (undecided_spec): New struct.
1441 (struct coding_system): New member `undecided' of the member
1442 `spec'.
1443
1444 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1445 (detect_coding): Likewise.
1446 (detect_coding_system): Likewise.
1447 (Fdefine_coding_system_internal): New coding system properties
1448 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1449 :prefer-utf-8.
1450 (syms_of_coding): Adjust for coding_arg_undecided_max.
1451
ba3de9e6
PE
14522013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 * image.c (x_from_xcolors): Remove unused local.
1455
547c9269
YM
14562013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1457
1458 Defer image data transfer between X client and server until actual
1459 display happens.
1460
1461 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1462 and `mask_img'.
1463
1464 * image.c (Destroy_Image): Remove.
1465 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1466 `mask_p', and `colors_p'. All uses changed.
1467 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1468 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1469 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1470 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1471 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1472 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1473 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1474 (image_get_x_image, image_unget_x_image): New functions or macros.
1475 (image_background, image_background_transparent, x_to_xcolors)
1476 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1477 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1478 instead of Destroy_Image.
1479 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1480 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1481 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1482 (imagemagick_load_image, svg_load_image): Use them instead of
1483 x_create_x_image_and_pixmap, and x_put_x_image followed by
1484 x_destroy_x_image, respectively.
1485 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1486 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1487 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1488 background_transparent fields.
1489 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1490 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1491
dae2f5ef
PE
14922013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1495 This mostly consists of undoing recent changes.
1496 * callproc.c (Fcall_process):
1497 * process.c (create_process):
1498 Do not worry about catching SIGCHLD here, undoing previous change.
1499 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1500 * process.c, process.h (catch_child_signal):
1501 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1502 * process.c (catch_child_handler): Don't worry about being called
1503 lazily and do not assume caller has blocked SIGCHLD, undoing
1504 previous change. Move first-time stuff back to
1505 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1506 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1507 set lib_child_handler if it's already initialized, which may
1508 help avoid problems on GNUStep.
1509
fa55d2aa
PE
15102013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1513 * callproc.c (Fcall_process):
1514 * process.c (create_process):
1515 Make sure SIGCHLD is caught before we fork,
1516 since Emacs startup no arranges to catch SIGCHLD.
1517 * process.c (lib_child_handler): Initialize to null, not to
1518 dummy_handler.
1519 (catch_child_signal): Allow self to be called lazily.
1520 Do nothing if it's already been called.
1521 Assume caller has blocked SIGCHLD (all callers do now).
1522 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1523 just before it's really needed.
1524 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1525 since it hasn't been caught yet.
1526
f3f9606c
LMI
15272013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1528
1529 * image.c (compute_image_size): New function to implement
1530 :max-width and :max-height.
1531 (imagemagick_load_image): Use it.
1532
c7041908
PE
15332013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1534
1535 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1536 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1537 Now extern.
1538 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1539 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1540 the SIGCHLD handler, since the code is not atomic and (due to glib)
1541 signals may be arriving now.
1542 * sysdep.c (init_signals): Do not catch child signals here;
1543 'main' now does that later, at a safer time.
1544
f86852b4
PE
15452013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1546
0dfeed58
PE
1547 Clean up SIGCHLD handling a bit (Bug#14569).
1548 * process.c, process.h (catch_child_signal):
1549 Now always extern, even if !NS_IMPL_GNUSTEP.
1550 * process.c (catch_child_signal): Move glib tickler here from
1551 init_process_emacs, so that it's done earlier in Emacs
1552 initialization. Also move the noninteractive && !initialized
1553 check here from init_process_emacs. This is all a bit cleaner for
1554 GNUish platforms, and I hope it works around the Cygwin bug.
1555 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1556 that glib signal handling is tickled before glib creates threads.
1557
f86852b4
PE
1558 * process.c (wait_reading_process_output): Avoid int overflow
1559 when reading more than 2 GiB total from a process.
1560
cbd6509c
PE
15612013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 * process.c (create_process): Handle a couple more cases,
1564 i.e., work even if new_argv and wait_child_setup[i] are cached.
1565 Use Fcall_process's style for volatile vars.
1566
9de1114a
AS
15672013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1568
1569 * process.c (create_process): Mark PROCESS volatile.
1570
fbe9e0b9
PE
15712013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 Use C99-style flexible array members if available.
1574 This avoids some subtle aliasing issues, which typically
1575 aren't a problem with GCC but may be a problem elsewhere.
1576 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1577 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1578 In either case, it uses a flexible array member rather than
1579 the old struct hack. All uses changed.
1580 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1581 Adjust to sdata reorganization.
1582 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1583 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1584 that ports better to pre-C99 non-GCC.
1585 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1586 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1587 as the latter has changed.
1588 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1589 and port better to pre-C99 GCC.
1590 * image.c (struct xpm_cached_color):
1591 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1592 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1593 Use FLEXIBLE_ARRAY_MEMBER.
1594 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1595 Move decl to top level so it gets checked against implementation.
1596 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1597 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1598
1fc71008
PE
15992013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 * syntax.c: Integer cleanups.
1602 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1603 All uses that need 0-or-2 changed to:
1604 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1605 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1606 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1607 (char_quoted, prev_char_comend_first, back_comment)
1608 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1609 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1610 Use bool for boolean.
1611 (update_syntax_table, skip_chars, skip_syntaxes):
1612 Prefer int to unsigned when either will do.
1613 (back_comment): Return boolean success flag, like forw_comment,
1614 instead of positive-or-minus-1 (which might have overflowed int anyway).
1615 Don't stuff ptrdiff_t into int.
1616 (syntax_spec_code, syntax_code_spec): Now const.
1617 (Fmatching_paren, scan_lists, scan_sexps_forward):
1618 Use enum syntaxcode for syntax code.
1619 (Fmatching_paren): Check that arg is a character, not just an integer.
1620 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1621 (Finternal_describe_syntax_value): Omit no-longer-needed
1622 comparison to 0.
1623 (skip_chars): Use char, not unsigned char, when the distinction
1624 doesn't matter.
1625 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1626 * bytecode.c (exec_byte_code):
1627 * syntax.c (syntax_spec_code, Fchar_syntax)
1628 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1629 (init_syntax_once):
1630 * syntax.h (SYNTAX_WITH_FLAGS):
1631 Omit unnecessary casts.
1632
b932cad7
EZ
16332013-06-20 Eli Zaretskii <eliz@gnu.org>
1634
1635 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1636 line dimensions here, to avoid race conditions with the main
1637 thread. (Bug#14062, bug#14630, bug#14669)
1638
1639 * w32term.c (w32_draw_window_cursor): Compute the header line and
1640 mode line dimensions here.
1641 <w32_system_caret_window, w32_system_caret_hdr_height>:
1642 <w32_system_caret_mode_height>: New variables.
1643
1644 * w32term.h: Declare them.
1645
89561f72
PE
16462013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1647
5013fc08
PE
1648 * alloc.c (die): Move "assertion failed" string here ...
1649 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1650 COND when SUPPRESS_CHECKING. This shrinks the executable text
1651 size by 0.8% to 2.2% when configured with --enable-checking,
1652 depending on optimization flags (GCC 4.8.1 x86-64).
1653
89561f72
PE
1654 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1655
763a086d 16562013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
1657
1658 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1659 base is 2; this is more accurate.
1660
983aeb9a
JB
16612013-06-19 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * sound.c (string_default): Move to !WINDOWSNT section.
1664 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1665
178ba3e6
PE
16662013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1667
bbc51b15
PE
1668 * sound.c: Integer cleanups.
1669 Remove unnecessary forward decls.
1670 (struct sound_device): The 'file' member is now a Lisp_Object, not
1671 a char *, so that we needn't invoke alloca on a huge size.
1672 (Fplay_sound_internal): Adjust to this.
1673 (string_default): New function.
1674 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1675 Use it to adjust to the struct sound_device change.
1676 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1677 (be2hs) [0]: Remove.
1678
178ba3e6
PE
1679 * syntax.c (skip_chars): Don't use uninitialized storage
1680 when searching a multibyte buffer for characters that are not in a
1681 unibyte string that contains non-ASCII characters.
1682
69f60cdc
JD
16832013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1684
1685 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1686 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1687
0d6224d4
PE
16882013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1691
3c542890
KH
16922013-06-18 Kenichi Handa <handa@gnu.org>
1693
f7e3f7cd
KH
1694 * font.c (Ffont_spec): Signal an error for an invalid font name
1695 (Bug#14648).
3c542890 1696
9349e5f7
PE
16972013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1700 In particular this ports to 32-bit sparc Sun cc.
1701 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1702 array with a dummy element at specpdl[-1], so that its address can
1703 be taken portably.
1704 (unbind_to): Do not copy the binding; not needed, now that we
1705 copy old_value in the one place where the copy is needed.
1706 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1707 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1708 (union specbinding): Rename from struct specbinding. Redo layout
1709 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1710 which is not portable. With Sun C 5.12 32-bit sparc, the
1711 declaration causes nargs to be an unsigned bitfield, a behavior
1712 that the C standard allows; but Emacs wants nargs to be signed.
1713 The overall type is now a union of structures rather than a
1714 structure of union of structures, and the 'kind' member is now a
1715 bitfield, so that the overall type doesn't grow. All uses changed.
1716 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1717
0a4df6a5
PE
17182013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1719
ec6ecaad
PE
1720 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1721 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1722
0a4df6a5
PE
1723 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1724
7bfe8dbc
EZ
17252013-06-17 Eli Zaretskii <eliz@gnu.org>
1726
1727 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1728 unless we know that the window w's frame is a frame object.
1729 Another attempt at solving bug#14062 and bug#14630.
1730
708e05f6
LMI
17312013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1732
1733 * textprop.c (property_set_type): New enum.
1734 (add_properties): Allow appending/prepending text properties.
1735 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1736 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1737 add_text_properties_1.
1738 (Fadd_face_text_property): New function that calls
1739 add_text_properties_1.
1740
84575e67
PE
17412013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1742
1743 Move functions from lisp.h to individual modules when possible.
1744 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1745 * alloc.c (XFLOAT_INIT, set_symbol_name):
1746 * buffer.c (CHECK_OVERLAY):
1747 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1748 (set_char_table_parent):
1749 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1750 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1751 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1752 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1753 (set_blv_valcell):
1754 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1755 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1756 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1757 (backtrace_args, backtrace_debug_on_exit):
1758 * floatfns.c (CHECK_FLOAT):
1759 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1760 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1761 (set_hash_hash, set_hash_hash_slot, set_hash_index)
1762 (set_hash_index_slot):
1763 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
1764 * marker.c (CHECK_MARKER):
1765 * textprop.c (CHECK_STRING_OR_BUFFER):
1766 * window.c (CHECK_WINDOW_CONFIGURATION):
1767 Move here from lisp.h, and make these functions static rather than
1768 extern inline.
1769 * buffer.c (Qoverlayp):
1770 * data.c (Qsubrp):
1771 * fns.c (Qhash_table_p):
1772 * window.c (Qwindow_configuration_p):
1773 Now static.
1774 * lisp.h: Remove the abovementioned defns and decls.
1775
44e18199 1776 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
1777 In lisp.h, prefer functions to function-like macros, and
1778 constants to object-like macros, when either will do. This:
1779 . simplifies use, as there's no more need to worry about
1780 arguments' side effects being evaluated multiple times.
1781 . makes the code easier to debug on some platforms.
1782 However, when using gcc -O0, keep using function-like macros
1783 for a few critical operations, for performance reasons.
1784 This sort of thing isn't needed with gcc -Og, but -Og
1785 is a GCC 4.8 feature and isn't widely-enough available yet.
1786 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
1787 Remove enum lsb_bits; no longer needed.
1788 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
1789 * buffer.c (Qoverlap):
1790 * data.c (Qsubrp):
1791 * fns.c (Qhash_table_p):
1792 Now extern, so lisp.h can use these symbols.
1793 * dispextern.h: Include character.h, for MAX_CHAR etc.
1794 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1795 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1796 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1797 (GLYPH_CODE_P): Move here from lisp.h.
1798 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1799 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
1800 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
1801 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
1802 XUNTAG now returns void *.
1803 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
1804 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
1805 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
1806 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
1807 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
1808 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
1809 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
1810 (lisp_h_XPNTR, lisp_h_XSYMBOL):
1811 New macros, renamed from their sans-lisp_h_ counterparts.
1812 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
1813 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
1814 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
1815 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
1816 If compiling via GCC without optimization, define these as macros
1817 in addition to inline functions.
1818 To disable this, compile with -DINLINING=0.
1819 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
1820 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
1821 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
1822 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
1823 (INTMASK, VALMASK): Now macros, since static values cannot be
1824 accessed from extern inline functions.
1825 (VALMASK): Also a constant, for benefit of old GDB.
1826 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
1827 is INTEGERP, which can fold it in.
5165d44a 1828 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
1829 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
1830 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
1831 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
1832 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
1833 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
1834 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
1835 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
1836 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
1837 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
1838 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
1839 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
1840 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
1841 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
1842 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
1843 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
1844 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
1845 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
1846 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
1847 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
1848 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
1849 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
1850 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
1851 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
1852 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
1853 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
1854 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
1855 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
1856 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
1857 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
1858 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
1859 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
1860 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
1861 Now functions.
1862 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
1863 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
1864 (VALMASK): Define in one place rather than in two, merging the
1865 USE_LSB_TAG parts; this is simpler.
1866 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
1867 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
1868 Move up, to avoid use before definition.
1869 Also include "globals.h" earlier, for the same reason.
1870 (make_natnum): New function.
1871 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
1872 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
1873 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
1874 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
1875 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
1876 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
1877 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
1878 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
1879 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
1880 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
1881 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
1882 (Qwindow_configuration_p, Qimage): New forward declarations.
1883 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
1884 (STRING_COPYIN): Remove; unused.
1885 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
1886 (xcar_addr, xcdr_addr): New functions. All uses changed.
1887 (IEEE_FLOATING_POINT): Now a constant, not a macro.
1888 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1889 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1890 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1891 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
1892 (TYPE_RANGED_INTEGERP): Simplify.
1893 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
1894 (setlocale, fixup_locale, synchronize_system_messages_locale)
1895 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
1896 Now empty functions, not macros.
1897 (functionp): Return bool, not int.
1898 * window.c (Qwindow_configuration_p): Now extern,
1899 so window.h can use it.
1900 * window.h (Qwindowp): Move decl back to lisp.h.
1901
9583ec36
EZ
19022013-06-15 Eli Zaretskii <eliz@gnu.org>
1903
1904 * xdisp.c (Fline_pixel_height): New function, required for solving
1905 bug #14567.
1906
210272ce
PE
19072013-06-15 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
1910
de0503df
SM
19112013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
1912
1913 * lread.c (syms_of_lread):
1914 * fns.c (Fprovide): Adjust to new format of after-load-alist.
1915
afbfe143
KD
19162013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
1917
1918 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
1919
d177e213
XF
19202013-06-12 Xue Fuqiao <xfq.free@gmail.com>
1921
1922 * fileio.c (expand_file_name): Doc fix.
1923
05e3e412
PE
19242013-06-11 Paul Eggert <eggert@cs.ucla.edu>
1925
f7394b12
PE
1926 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
1927 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
1928 Wait for self, not for 0. This can't hurt on GNU or similar
1929 system, and may help with Cygwin.
1930
05e3e412
PE
1931 * keyboard.c: Don't use PROP (...) as an lvalue.
1932 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
1933 Use set_prop (A, B), not PROP (A) = B.
1934
17dd3097
EZ
19352013-06-10 Eli Zaretskii <eliz@gnu.org>
1936
1937 * xdisp.c (get_it_property): Use it->window instead of generating
1938 a Lisp object from it->w.
1939
52fab9c9
EZ
19402013-06-09 Eli Zaretskii <eliz@gnu.org>
1941
1942 * xdisp.c (get_it_property): If it->object is a buffer, pass to
1943 get-char-property the window that is being rendered, instead of
1944 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
1945 (compute_display_string_pos): When W is NULL, use the current
1946 buffer as the object to pass to get-char-property.
1947 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
1948 pointer member of the bidi iterator, since no window is pertinent
1949 to this function.
52fab9c9 1950
5bf97bfc
EZ
19512013-06-08 Eli Zaretskii <eliz@gnu.org>
1952
1953 * bidi.c (bidi_fetch_char): Accept additional argument, the window
1954 being displayed, and pass it to compute_display_string_pos.
1955 (bidi_level_of_next_char, bidi_resolve_explicit_1)
1956 (bidi_paragraph_init): All callers changed.
1957
1958 * xdisp.c (init_from_display_pos, init_iterator)
1959 (handle_single_display_spec, next_overlay_string)
1960 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
1961 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
1962 Set bidi_it.w member from it->w.
5bf97bfc
EZ
1963 (compute_display_string_pos): Accept additional argument, the
1964 window being displayed, and pass it to Fget_char_property.
1965 (Bug#14575)
1966
1967 * dispextern.h (struct bidi_it): New member w, the window being
1968 displayed.
1969 (compute_display_string_pos): Adjust prototype.
1970
5de0e011
JD
19712013-06-08 Jan Djärv <jan.h.d@swipnet.se>
1972
e7b41c4c 1973 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
1974
1975 * process.c (wait_reading_process_output): Check for NS before GLIB.
1976 GLIB may be linked in due to rsvg, but ns_select must be called.
1977
5de0e011
JD
1978 * xgselect.c (xg_select): Remove call to window_system_available
1979 and g_main_context_pending at the top, so Gdk events (i.e. file
1980 notify) are processed when Emacs is started with -nw.
1981
a822acff
EZ
19822013-06-07 Eli Zaretskii <eliz@gnu.org>
1983
1984 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
1985 (ctagsfiles3): New variable, includes only *.m files.
1986 (TAGS): Use an explicit language name in the regular expressions,
1987 to avoid transformation of '/SOMETHING' by MSYS to
1988 'c:\MSYS\SOMETHING'.
1989
6c0a9ed1
RC
19902013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
1991
1992 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
1993
9ef6111b
EZ
19942013-06-06 Eli Zaretskii <eliz@gnu.org>
1995
1996 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
1997 still need to set the mouse pointer shape and activate help-echo.
1998 (Bug#14558)
1999
7d300d64
PE
20002013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2001
2002 A few porting etc. fixes for the new file monitor code.
2003 See the thread containing
2004 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2005 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2006 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2007 (dir_monitor_callback, Fgfile_rm_watch):
2008 Use assq_no_quit instead of Fassoc, for speed.
2009 (dir_monitor_callback, Fgfile_rm_watch):
2010 eassert that the monitor is a fixnum.
2011 (dir_monitor_callback): No need for CDR_SAFE.
2012 Simplify building of lisp with alternative tails.
2013 (Fgfile_add_watch, Fgfile_rm_watch):
2014 Do not assume glib functions set errno reliably on failure.
2015 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2016 and signal an error otherwise.
2017 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2018 Use Fdelq instead of Fdelete, for speed.
2019
817ebfcf
EZ
20202013-06-05 Eli Zaretskii <eliz@gnu.org>
2021
2022 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2023 don't insist on being invoked on a highlighted tool-bar button.
2024 Avoids losing tool-bar functionality when mouse-highlight is nil.
2025 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2026 Don't highlight when mouse-highlight is nil.
2027 (note_mouse_highlight): When mouse-highlight is nil, don't return
2028 right away; instead, run tool-bar and mode-line highlight
2029 subroutine, clear any existing highlight, and revert the mouse
2030 pointer to its default shape. (Bug#14558)
2031
55577e7c
SM
20322013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2033
2034 * lisp.mk (lisp): Add prog-mode.el.
2035
f019a684
PE
20362013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2039 * process.c (dummy_handler): New function.
2040 (lib_child_handler): New static var.
2041 (handle_child_signal): Invoke it.
2042 (catch_child_signal): If a library has set up a signal handler,
2043 save it into lib_child_handler.
2044 (init_process_emacs): If using glib and not on Windows, tickle glib's
2045 child-handling code so that it initializes its private SIGCHLD handler.
2046 * syssignal.h (SA_SIGINFO): Default to 0.
2047 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2048 31; it should no longer be needed now.
2049
90db8702
MA
20502013-06-05 Michael Albinus <michael.albinus@gmx.de>
2051
2052 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2053
2054 * gfilenotify.c (globals_of_gfilenotify): New function.
2055 (syms_of_gfilenotify): Move global initialization there.
2056
2057 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2058
bfa3acd6
SM
20592013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2062 * keyboard.c (menu_bar_items, tool_bar_items):
2063 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2064 not override local keymaps any more.
2065
ba59bd80
EZ
20662013-06-04 Eli Zaretskii <eliz@gnu.org>
2067
2068 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2069
7f203aa1
EZ
20702013-06-03 Eli Zaretskii <eliz@gnu.org>
2071
9337e206
EZ
2072 * w32console.c (initialize_w32_display): Return the dimensions of
2073 the console window via 2 additional arguments, not via the current
2074 frame. This avoids crashes due to overrunning the bounds of
2075 frame's decode_mode_spec_buffer, which is not resized following
2076 the change of the frame dimensions from the initial 10x10.
2077
2078 * w32term.h (w32_initialize_display_info): Adjust prototype.
2079
2080 * term.c (init_tty): Take dimensions of the frame from the values
2081 returned by initialize_w32_display.
2082
7f203aa1
EZ
2083 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2084 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2085 (LIBES): Add $(GFILENOTIFY_LIBS).
2086
2087 * w32inevt.c (handle_file_notifications): Add dummy implementation
2088 for !HAVE_W32NOTIFY.
2089
2090 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2091
55a87246
JD
20922013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2093
2094 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2095
2096 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2097
2098 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2099
3d5ee10a
PE
21002013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2101
2102 Fix minor problems found by static checking.
2103 * data.c (pure_write_error):
2104 Use xsignal2, not Fsignal, as Fsignal might return.
2105 * eval.c (set_backtrace_debug_on_exit): Now static.
2106 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2107 No longer inline. EXTERN_INLINE is needed only for functions
2108 defined in .h files. Reindent function header as per GNU style.
2109 (backtrace_p, backtrace_top, backtrace_next):
2110 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2111 compiler or linker. Add extern decls to pacify gcc -Wall.
2112 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2113 Now static.
2114 * frame.c (free_monitors): Define only on platforms that need it.
2115 * nsterm.m (ns_term_init):
2116 * process.c (catch_child_signal):
2117 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2118 defined on all porting targets these days.
2119 * process.c, process.h (catch_child_signal):
2120 Make it extern only if NS_IMPL_GNUSTEP is defined.
2121
e2d8a6f0
EZ
21222013-06-03 Eli Zaretskii <eliz@gnu.org>
2123
2124 * w32.c (gettimeofday): Make the signature identical to prototype
2125 in nt/inc/sys/time.h.
2126
a8a7c5f6
SM
21272013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2128
2129 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2130 .gdbinit.
2131
2132 * keyboard.c (safe_run_hooks_error): Improve error message.
2133
2134 * data.c (pure_write_error): Add `object' argument.
2135 * puresize.h (CHECK_IMPURE): Use it.
2136
c9628c79
MA
21372013-06-03 Michael Albinus <michael.albinus@gmx.de>
2138
2139 * Makefile.in (NOTIFY_OBJ): New variable.
2140 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2141
2142 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2143 Call syms_of_gfilenotify.
2144
2145 * gfilenotify.c: New file.
2146
2147 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2148 and Qfile_w32notify.
2149 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2150 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2151
2152 * lisp.h: Declare syms_of_gfilenotify.
2153
2154 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2155
2f592f95
SM
21562013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2157
2158 Merge the specpdl and backtrace stacks. Make the structure of the
2159 specpdl entries more obvious via a tagged union of structs.
2160 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2161 (enum specbind_tag): New enum.
2162 (struct specbinding): Make it a tagged union of structs.
2163 Add a case for backtrace records.
2164 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2165 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2166 (backtrace_debug_on_exit): New accessors.
2167 (struct backtrace): Remove.
2168 (struct catchtag): Remove backlist field.
2169 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2170 Move to eval.c.
2171 (Flocal_variable_p): Speed up the common case where the binding is
2172 already loaded.
2173 * eval.c (backtrace_list): Remove.
2174 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2175 (set_backtrace_args, set_backtrace_nargs)
2176 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2177 (backtrace_next): New functions.
2178 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2179 (unwind_to_catch, internal_lisp_condition_case)
2180 (internal_condition_case, internal_condition_case_1)
2181 (internal_condition_case_2, internal_condition_case_n): Don't bother
2182 with backtrace_list any more.
2183 (Fsignal): Adjust to new backtrace format.
2184 (grow_specpdl): Move up.
2185 (record_in_backtrace): New function.
2186 (eval_sub, Ffuncall): Use it.
2187 (apply_lambda): Adjust to new backtrace format.
2188 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2189 data.c.
2190 (specbind): Adjust to new specpdl format. Simplify.
2191 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2192 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2193 backtrace format.
2194 (mark_backtrace): Remove.
2195 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2196 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2197 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2198 Use mark_specpdl.
2199 * profiler.c (record_backtrace): Use get_backtrace.
2200 (handle_profiler_signal): Use backtrace_top_function.
2201 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2202 accessor functions.
2203
c0342369
JD
22042013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2205
2206 * process.h (catch_child_signal): Declare.
2207
2208 * process.c (catch_child_signal): New function.
2209 (init_process_emacs): Call it.
2210
2211 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2212 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2213 NS_IMPL_COCOA.
2214 (x_set_cursor_type): Remove declaration.
2215 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2216 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2217 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2218 (ns_get_color): Use F suffix on float.
2219 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2220 (ns_get_rgb_color): Remove.
2221 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2222 (note_mouse_movement): x and y are CGFloat.
2223 (ns_draw_fringe_bitmap): Remove unused rowY.
2224 Change #if to COCOA && >= 10_6.
2225 (ns_draw_window_cursor): Remove unused overspill.
2226 (ns_draw_underwave): width and x are EamcsCGFloat.
2227 (ns_draw_box): thickness is CGFloat.
2228 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2229 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2230 if not in main thread.
2231 (ns_get_pending_menu_title, ns_check_menu_open)
2232 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2233 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2234 (sendFromMainThread:): New method.
2235 (changeFont:): size is CGFloat.
2236 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2237 Disable warning about permanent text.
2238 (characterIndexForPoint:): Adjust return type depending on GNUStep
2239 version.
2240 (mouseDown:): delta is CGFloat.
2241 (updateFrameSize): Remove unised variable f.
2242 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2243 Cast float to EmacsCGFloat.
2244 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2245 also to -1 when restoring.
2246 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2247 inside NS_IMPL_COCOA.
2248 (toggleFullScreen:): Put call to toggleFullScreen inside
2249 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2250 (setPosition:portion:whole:): por is CGFloat.
2251 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2252 (mouseDown:): Use CGFloat.
2253 (mouseDragged:): Remove unised variable edge.
2254 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2255
2256 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2257 of CGFloat differs.
2258 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2259 when NS_IMPL_GNUSTEP.
2260 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2261 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2262 (EmacsToolbar): Add clearAll. Add tag argument to
2263 addDisplayItemWithImage.
2264 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2265
2266 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2267
2268 * nsmenu.m (ns_update_menubar): Make static.
2269 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2270 (fillWithWidgetValue:): Add cast to SEL for setAction.
2271 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2272 (update_frame_tool_bar): Update code for GNUStep.
2273 (clearAll): New method.
2274 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2275 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2276 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2277 call to insertItemWithItemIdentifier.
2278 (validateVisibleItems): Fix indentation.
2279 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2280 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2281 UtilityWindow to aStyle, remove call to setStyleMask.
2282
2283 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2284
2285 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2286 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2287 Use F suffix on floats.
2288 (ns_char_width): Returns CGFloat.
2289 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2290 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2291 DPSxshow.
2292 (ns_glyph_metrics): CGFloat instead of float.
2293
a0eb10b3
JB
2294 * nsfns.m (x_set_foreground_color, x_set_background_color):
2295 Use EmacsCGFloat.
2296 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2297 remove unused variables.
2298 (Fns_read_file_name): Keep track if panel is for save.
2299 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2300 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2301 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2302 Just return the input if GNUStep.
c0342369
JD
2303 (x_screen_planes): Remove.
2304 (Fxw_color_values): Use EmacsCGFloat
2305 (Fns_display_monitor_attributes_list): Only get screen number for
2306 Cocoa.
ef099a94 2307 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2308 EmacsSavePanel.
2309 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2310 ns_directory_from_panel.
2311
da9aff11
PE
23122013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2313
2314 * process.c (handle_child_signal): Also use WCONTINUED.
2315 This is so that list-processes doesn't mistakenly list the process
2316 as stopped, when the process has actually been continued and is
2317 now running.
2318
0e64479a
PE
23192013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2320
fc186a96
PE
2321 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2322 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2323 not already configured.
2324
0e64479a
PE
2325 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2326
38b787fa
EZ
23272013-05-29 Eli Zaretskii <eliz@gnu.org>
2328
2329 * Makefile.in (mostlyclean): Remove *.res files.
2330
22513e52
SM
23312013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2332
2333 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2334 a buffer (bug#8447).
2335
6ef3db10
EZ
23362013-05-27 Eli Zaretskii <eliz@gnu.org>
2337
2338 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2339 display vector, and we backtrack, handle the case that the
2340 previous character position is also displayed from a display
2341 vector or covered by a display string or image. (Bug#14476)
2342
6799bb26
JD
23432013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2344
2345 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2346 (struct MonitorInfo, free_monitors): Remove.
2347 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2348 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2349 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2350 Qframes, Qsource.
2351
2352 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2353 (struct MonitorInfo, free_monitors): Remove.
2354 (ns_screen_name): Make static.
2355 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2356 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2357 Qframes, Qsource.
2358
2359 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2360 (struct MonitorInfo): New struct.
2361 (free_monitors, make_monitor_attribute_list): Declare.
2362
22513e52
SM
2363 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2364 New Lisp_Object:s.
6799bb26
JD
2365 (free_monitors, make_monitor_attribute_list): New functions.
2366 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2367 Qsource.
2368
38cd43eb
XF
23692013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2370
2371 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2372
2af0948d
SM
23732013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2374
a7eb9b0f
SM
2375 * keyboard.c: Apply keyboard decoding only to events that come directly
2376 from the tty, not from unread-command-events (bug#14368).
2377 (read_event_from_main_queue): New function, extracted from read_char).
2378 (read_decoded_char): Remove.
2379 (read_decoded_event_from_main_queue): New function to replace it.
2380 (read_char): Use it.
2381 (read_key_sequence): Use read_char rather than read_decoded_char.
2382
2af0948d
SM
2383 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2384
1413e9a5
BR
23852013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2386
2387 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2388
e6d2f155
KH
23892013-05-22 Kenichi Handa <handa@gnu.org>
2390
2391 The following changes are to fix the setting of
2392 buffer-file-coding-system on, for instance, C-x RET c unix RET
2393 _FILE_OF_DOS_EOL_TYPE_ RET.
2394
2395 * coding.h (struct coding_system): New member detected_utf8_chars.
2396
2397 * coding.c (detect_coding_utf_8): Count characters and check EOL
2398 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2399 BOM is there.
2400 (setup_coding_system): Do not initialize coding->head_ascii.
2401 (check_ascii): Do not set coding->eol_seen but update it. Do not
2402 call adjust_coding_eol_type here.
1413e9a5
BR
2403 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2404 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2405 of the found coding-system.
2406 (decode_coding_gap): Cancel previous change. Utilize the
2407 character numbers counted by detect_coding_utf_8. Fix detection
2408 of BOM for utf-8.
2409
ab56a6f4 24102013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2411
2412 * search.c (looking_at_1): Only set last_thing_searched if the match
2413 changed the match-data (bug#14281).
2414
ecc3c6ed
DA
24152013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2416
2417 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2418 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2419 (move_it_vertically_backward): Likewise.
2420
5ba8bf35
YM
24212013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2422
2423 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2424 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2425 (Fx_display_mm_width, Fx_display_mm_height):
2426 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2427
91e8418b 2428 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2429 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2430 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2431 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2432 (Fx_display_backing_store, Fx_display_visual_class)
2433 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2434 (Fx_display_grayscale_p, Fx_display_pixel_width)
2435 (Fx_display_pixel_height, Fx_display_planes)
2436 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2437 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2438 (Fx_display_mm_width, Fx_display_mm_height)
2439 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2440 height for all physical monitors as in X11.
2441
fc30d803
SM
2442 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2443 Return pixel width or height for all physical monitors as in X11.
91e8418b 2444
31ff141c
PE
24452013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2446
2447 Port --enable-gcc-warnings to clang.
2448 * bytecode.c (exec_byte_code):
2449 * regex.c:
2450 Redo diagnostic pragmas to pacify clang, too.
2451 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2452 * editfns.c (Fencode_time):
2453 * fileio.c (file_accessible_directory_p):
2454 * font.c (font_unparse_xlfd):
2455 Use '&"string"[index]' instead of '"string" + (index)'.
2456 * undo.c (user_error): Remove; unused.
2457
df065a0b
EZ
24582013-05-16 Eli Zaretskii <eliz@gnu.org>
2459
04d360e7
EZ
2460 * insdel.c (insert_1_both): Document the arguments, instead of
2461 referring to insert_1, which no longer exists.
2462
5bb98290
EZ
2463 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2464 some window, increment windows_or_buffers_changed, so that
2465 *Messages* display in that window is updated. (Bug#14408)
2466
df065a0b
EZ
2467 * w32.c: Include epaths.h.
2468 (init_environment): Use cmdproxy.exe without leading directories.
2469 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2470 case.
2471 (gettimeofday): Adjust signature and return value to Posix
2472 expectations.
2473
2474 * unexw32.c (open_output_file): Delete the existing emacs.exe
2475 before creating it, to break the hard link to the versioned
2476 executable.
2477
2478 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2479 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2480 (FIRSTFILE_OBJ): New variables.
2481 (W32_RES): Rename to EMACSRES. All users changed.
2482 (base_obj): Use $(CM_OBJ).
2483 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2484 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2485 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2486 $(W32_RES_LINK) before $(LIBES).
2487 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2488
1aa8d505
SM
24892013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2490
6e911150
SM
2491 * makefile.w32-in (DOC): Use just "DOC".
2492
2493 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2494
1aa8d505
SM
2495 * process.c: Export default filters and sentinels to Elisp.
2496 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2497 New constants.
2498 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2499 (Fset_process_sentinel, Fformat_network_address):
2500 Default to them instead of nil.
2501 (server_accept_connection): Sentinels can't be nil any more.
2502 (read_and_dispose_of_process_output): New function, extracted from
2503 read_process_output.
2504 (read_process_output): Use it; filters can't be nil.
2505 (Finternal_default_process_filter): New function, extracted from
2506 read_process_output.
2507 (exec_sentinel_unwind): Remove function.
2508 (exec_sentinel): Don't zilch sentinel while running.
2509 (status_notify): Sentinels can't be nil.
2510 (Finternal_default_process_sentinel): New function extracted from
2511 status_notify.
2512 (setup_process_coding_systems): Default filter is not nil any more.
2513 (syms_of_process): Export new Elisp functions and initialize
2514 new constants.
2515 * lisp.h (make_lisp_proc): New function.
2516
5ac2eb34
SM
25172013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2518
2519 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2520
eda9c7d7
EZ
25212013-05-14 Eli Zaretskii <eliz@gnu.org>
2522
2523 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2524 unless we know that the window w is a leaf window.
2525 Another attempt at solving bug#14062.
eda9c7d7 2526
8fdeaad5
JD
25272013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2528
2529 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2530 fdesc (Bug#14375).
2531
44aa9ee6
PE
25322013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 * image.c (gif_load): Check that subimages fit (Bug#14345).
2535
759fd763
SM
25362013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2537
2538 * lread.c (skip_dyn_eof): New function.
2539 (read1): Use it to skip the end of a file in response to #@00.
2540
2541 * doc.c (get_doc_string): Slightly relax the sanity checking.
2542
4465bfb4
JD
25432013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2544
2545 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2546 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2547 (MonitorInfo): New struct.
2548 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2549 (Fns_display_monitor_attributes_list): New functions.
2550 (display-usable-bounds): Remove.
2551 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2552 Qsource.
2553
7583e2a0
PE
25542013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2555
2556 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2557 (GTK_CHECK_VERSION): New macro, if not already defined.
2558 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2559 replaced by GTK_CHECK_VERSION.
2560
ad75d77e
PE
25612013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 * xterm.h (GTK_PREREQ): New macro.
2564 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2565 to use this macro instead, for consistency and clarity.
2566
07525f77
EZ
25672013-05-08 Eli Zaretskii <eliz@gnu.org>
2568
2569 * xdisp.c (row_for_charpos_p): New function, with code of
2570 cursor_row_p, but accepts an additional argument CHARPOS instead
2571 of using a hardcoded PT.
2572 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2573 (row_containing_pos): Call row_for_charpos_p instead of partially
2574 doing the same. Fixes cursor positioning under longlines-mode
2575 when longlines-show-effect includes more than one newline, when
2576 moving the cursor vertically up.
2577
d901fc8d
JB
25782013-05-08 Juanma Barranquero <lekktu@gmail.com>
2579
2580 * makefile.w32-in (ACL_H): New macro.
2581 ($(BLD)/fileio.$(O)): Update dependencies.
2582
f269bc61
PE
25832013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2584
e7b41c4c 2585 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2586 * Makefile.in (LIB_ACL): New macro.
2587 (LIBACL_LIBS): Remove.
2588 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2589 * fileio.c: Include <acl.h>.
2590 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2591 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2592 !acl_errno_valid.
2593 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2594 it ourselves.
2595
f269bc61
PE
2596 * unexelf.c: Don't assume ElfW (Half) fits in int.
2597 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2598 when dealing with ElfW (Half) values, since they can exceed 2**31
2599 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2600 (entry_address): Omit unused NUM arg. All uses changed.
2601
a261c53e
JL
26022013-05-07 Juri Linkov <juri@jurta.org>
2603
2604 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2605 to the string converted from number with `Fnumber_to_string'.
2606 (Bug#14254)
2607
2b66427d
PE
26082013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2611 This fixes a problem introduced by my previous change.
2612
15acfe41
GM
26132013-05-07 Glenn Morris <rgm@gnu.org>
2614
2615 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2616
5ea03bf5
JD
26172013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2618
2619 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2620
e0c9d565
PE
26212013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 Static checking by GCC 4.8.0.
2624 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2625 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2626 (x_get_monitor_attributes_fallback)
2627 (x_get_monitor_attributes_xinerama)
2628 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2629 Define only if USE_GTK.
2630 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2631 (x_get_monitor_attributes_fallback): Omit unused locals.
2632 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2633 Use double, not float, to avoid mixed-mode floating point arithmetic.
2634
4e3f9230
YM
26352013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2636 Jan Djärv <jan.h.d@swipnet.se>
2637
2638 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2639 (XINERAMA_CFLAGS): New macros.
2640 (ALL_CFLAGS, LIBES): Use them.
2641
2642 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2643 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2644 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2645 (syms_of_xfns): DEFSYM them.
2646 (struct MonitorInfo): New struct.
2647 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2648 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2649 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2650 (x_get_monitor_attributes_xinerama): New functions.
2651 (Fx_display_monitor_attributes_list): New primitive.
2652 (syms_of_xfns): Defsubr it.
2653
2654 * xterm.h (x_display_info): Add Xatom_net_workarea and
2655 Xatom_net_current_desktop.
2656
2657 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2658 and dpyinfo->Xatom_net_current_desktop.
2659
05839b6a
EZ
26602013-05-06 Eli Zaretskii <eliz@gnu.org>
2661
2662 * xdisp.c (pos_visible_p): Use the special code for finding the
2663 beginning of a display property or overlay for any "replacing"
2664 display property, not just for display strings. This solves
2665 incorrect reporting of position by posn-at-point. (Bug#14241)
2666
dc4a2ee0
PE
26672013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2668
5ee94506
PE
2669 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2670 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2671 Verify that ElfW (Half) fits in int.
2672 (fatal): Use same signature as lisp.h.
2673 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2674 configure and build with -DUNEXELF_DEBUG without worrying about
2675 other modules that use DEBUG.
2676 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2677 possibly-wide integers now uses it instead of plain fprintf.
2678 (entry_address): New function, which avoids problems with 32-bit
2679 overflow on 64-bit hosts.
2680 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2681 (round_up): Don't assume the remainder fits in int.
2682 (find_section): Use bool for boolean. Simplify debug code.
2683 (unexec): Don't assume file sizes fit in int or size_t.
2684 Omit unnecessary trailing newline in 'fatal' format.
2685 Use strerror rather than outputting decimal error number.
2686 Remove unused code when emacs is not defined;
2687 this file relies on Emacs now.
2688 Don't assume e_phnum and e_shnum are positive.
2689
dc4a2ee0
PE
2690 * regex.c: Fix problems when DEBUG is defined.
2691 (extract_number, extract_number_and_incr): Define regardless of
2692 whether DEBUG is defined; that's simpler and makes the code less
2693 likely to go stale in the normal case when DEBUG is not defined.
2694 Return int rather than taking an int * arg. All callers changed.
2695 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2696 Remove, replacing with ...
2697 (DEBUG_PRINT): New macro. All callers changed.
2698 (DEBUG_COMPILES_ARGUMENTS): New macro.
2699 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2700 (print_compiled_pattern, print_double_string) [DEBUG]:
2701 Use prototype rather than old-style definition.
2702 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2703 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2704 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2705 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2706 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2707 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2708 This matters only when DEBUG is defined.
2709
14c7ed05
EZ
27102013-05-05 Eli Zaretskii <eliz@gnu.org>
2711
2712 * xdisp.c (set_iterator_to_next): Set the
2713 ignore_overlay_strings_at_pos_p flag only if we are _really_
2714 iterating over an overlay string, as indicated by the
2715 current.overlay_string_index member. (Bug#14306)
2716
e6076b1b
JD
27172013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2718
2719 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2720 to where it is used, to avoid autorelease issues (Bug#14050).
2721
cbee2131
PE
27222013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2725 * fileio.c (syms_of_fileio): Implement this.
2726 * filelock.c (create_lock_file): If symbolic links don't work, so
2727 we use a regular file as a lock file, do not fsync the lock file;
2728 it's not needed.
2729
30c7e542
SM
27302013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2731
2732 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2733 (syms_of_minibuf): Adjust accodingly.
2734 * lread.c (Fread):
2735 * callint.c (Fcall_interactively): Adjust calls accordingly.
2736
5bebd186
EZ
27372013-05-04 Eli Zaretskii <eliz@gnu.org>
2738
2739 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2740 w->contents is a buffer before computing everything else.
2741 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2742
2743 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2744 assertion violations. (Bug#14062)
2745
0fb0a4f3
DR
27462013-05-01 David Reitter <david.reitter@gmail.com>
2747
2748 * nsfns.m (ns_tooltip): Initialize.
2749
9e63b4a5
EZ
27502013-04-28 Eli Zaretskii <eliz@gnu.org>
2751
2752 * coding.c (decode_coding_gap): Don't remove the character before
2753 a newline unless it's a CR character. (Bug#14287)
2754
ad60824e
DN
27552013-04-28 Dan Nicolaescu <dann@gnu.org>
2756
2757 * dispextern.h (struct face): Move enum face_underline_type
2758 earlier so that bitfields can be in the same word.
2759
edbdcec0
JD
27602013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2761
2762 * nsfns.m (handlePanelKeys): New function.
2763 (EmacsOpenPanel:performKeyEquivalent:)
2764 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
2765 arrows/function/control and copy/paste keys (Bug#14296).
2766
0208ede7
JL
27672013-04-27 Juri Linkov <juri@jurta.org>
2768
2769 * callint.c (Fcall_interactively): Call `Qread_number' for
2770 interactive code letter `n' instead of using duplicate code.
2771 (Bug#14254)
2772
b8dd59f7
PE
27732013-04-27 Paul Eggert <eggert@cs.ucla.edu>
2774
2775 * systime.h (make_timeval): Declare as 'const'.
2776
8bd722db
KH
27772013-04-27 Kenichi Handa <handa@gnu.org>
2778
2779 * font.c (font_open_entity): Always open a font of manageable
2780 size.
2781
13d0e56f 27822013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 2783
f780d632
PE
2784 Port better to AIX (Bug#14258).
2785 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
2786 to pacify AIX xlc.
2787
ec509856
KH
27882013-04-24 Kenichi Handa <handa@gnu.org>
2789
2790 * coding.c (decode_coding_iso_2022): When an invalid escape
2791 sequence is encountered, reset the invocation and designation
2792 status to the safest one.
2793
84fc48e5
PE
27942013-04-22 Paul Eggert <eggert@cs.ucla.edu>
2795
2796 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
2797 Without this fix, "make distclean" leaves stamp-h1 behind.
2798
806bda47
EC
27992013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
2800
2801 * w32fns.c (w32_fullscreen_rect): New function to compute the
2802 window rectangle for the given fullscreen mode.
2803 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
2804 longer tunes the window size. This keeps the window's edges flush
2805 with the screen and allows the taskbar to hide itself in fullboth.
2806
2807 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
2808 window decorations and uses the entire screen.
2809
2810 * w32term.h (w32_fullscreen_rect) Add prototype.
2811 (struct w32_output): Replace normal_width, normal_height,
2812 normal_top, and normal_left members with a single normal_placement
2813 struct.
2814 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
2815 Remove macros.
2816 (FRAME_NORMAL_PLACEMENT): New macro.
2817
9cc2810b
JB
28182013-04-16 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * minibuf.c (Ftest_completion): Silence compiler warning.
2821
fd16b54c
EZ
28222013-04-15 Eli Zaretskii <eliz@gnu.org>
2823
2824 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 2825 bug#14062.
fd16b54c
EZ
2826
2827 * frame.h (WINDOW_FRAME): Protect macro and its argument with
2828 parentheses.
2829
2830 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
2831 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
2832 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
2833 parentheses where appropriate.
2834
9e3379a0
PE
28352013-04-14 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * keyboard.c (timer_start_idle): Remove no-longer-used local.
2838
ddd6b685
EZ
28392013-04-14 Eli Zaretskii <eliz@gnu.org>
2840
2841 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
2842 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
2843 Mention in the doc string that setting these variables takes
2844 effect only after a call to set-window-buffer. (Bug#14200)
2845
29b79ba1
EZ
28462013-04-13 Eli Zaretskii <eliz@gnu.org>
2847
2848 * indent.c (Fvertical_motion): Don't consider display strings on
2849 overlay strings as display strings on the buffer position we
2850 started from. This prevents vertical cursor motion from jumping
2851 more than one line when there's an overlay string with a display
2852 property at end of line.
2853 Reported by Karl Chen <Karl.Chen@quarl.org> in
2854 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
2855
562c6ee9
SM
28562013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
2857
2858 * window.c (select_window): `record_buffer' even if window is
2859 already selected (bug#14191).
2860
fcc1fe85
EZ
28612013-04-11 Eli Zaretskii <eliz@gnu.org>
2862
2863 * window.c (Fwindow_end): Test more flags, including the buffer's
2864 last_overlay_modified flag, to determine whether the window's
2865 display is really up-to-date. Prevents the function from
2866 returning a stale value. (Bug#14170)
2867 (Fwindow_line_height): Fix the test for up-to-date-ness of the
2868 current matrix.
2869
f009190a
EZ
28702013-04-10 Eli Zaretskii <eliz@gnu.org>
2871
2872 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
2873 garbaged only if it is not already the top frame on its TTY.
2874 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
2875 there are GUI frames open in the same session. (Bug#13864)
2876
78ce603d
SM
28772013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
2878
2879 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
2880 of marking the idle timers directly.
2881
a8036e40
SM
28822013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
2883
2884 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
2885 tables (bug#14054).
2886
7ffe7ef6
SM
28872013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
2888
2889 * window.c (select_window): Don't record_buffer while the invariant is
2890 temporarily broken (bug#14161).
2891
2892 * fns.c (Fdelq): Don't assume !NILP => CONSP.
2893
7d9f6883
EZ
28942013-04-07 Eli Zaretskii <eliz@gnu.org>
2895
2896 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
2897
5406cfd9
RF
28982013-04-07 Romain Francoise <romain@orebokech.com>
2899
2900 Ignore additional platform-specific ACL errors (Bug#13702).
2901 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
2902 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
2903
95c0e83b
JD
29042013-03-31 Jan Djärv <jan.h.d@swipnet.se>
2905
2906 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
2907 f->output_data.ns.
2908
876da980
PE
29092013-04-07 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
2912 This bug was introduced by my 2013-02-25 change that simplified
2913 data_start configuration. Without this change, on GNU/Linux
2914 an Emacs configured with --enable-profiling fails immediately
2915 due to a profiler signal.
2916 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
2917 with these flags. On platforms where special flags are needed
2918 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
2919 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
2920 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
2921
7452b7bd
DA
29222013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
2923
2924 Get rid of some platform-specific functions examining window
2925 system and its capabilities. This is a partial rework of the
2926 2013-04-05 change.
2927 * lisp.h (have_menus_p): Remove prototype. This function is
2928 replaced with platform-independent window_system_available.
2929 (check_window_system): Move to...
2930 * frame.h (decode_window_system_frame, window_system_available):
2931 ...here, add new prototypes.
2932 * frame.c (window_system_available, decode_window_system_frame):
2933 New functions.
2934 (check_window_system): Platform-independent now.
2935 * xterm.h (x_in_use): Remove declaration.
2936 (check_x_frame):
2937 * w32term.h (check_x_frame):
2938 * nsterm.h (check_x_frame): Remove prototypes. This function
2939 is replaced with platform-independent decode_window_system_frame.
2940 * msdos.c (have_menus_p): Remove.
2941 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
2942 Remove platform-specific functions. Use check_window_system,
2943 decode_window_system_frame and check_ns_display_info where
2944 appropriate. Minor style and comment tweaks.
2945 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
2946 (check_x_frame): Likewise.
2947 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
2948 Likewise.
2949 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
2950 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
2951 * xmenu.c, xselect.c: All related users changed.
2952
251e9147
KH
29532013-04-03 Kenichi Handa <handa@gnu.org>
2954
2955 The following changes is to optimize the code for reading UTF-8
2956 files.
2957
562c6ee9 2958 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
2959 changed. Check EOL format. Do not call adjust_coding_eol_type
2960 here.
2961 (check_utf_8): New function.
2962 (adjust_coding_eol_type): Do nothing if already adjusted.
2963 (detect_coding): Compare the return value of check_ascii with
2964 coding->src_bytes. Call adjust_coding_eol_type if necessary.
2965 (decode_coding_gap): Optimize for valid UTF-8.
2966
8bc369d4
KH
29672013-03-21 Kenichi Handa <handa@gnu.org>
2968
2969 * coding.c (syms_of_coding): Cancel previous change.
2970
2971 * insdel.c (insert_from_gap): Fix previous change.
2972
73931ad1
DA
29732013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
2974
2975 Consistently use platform-specific function to detect window system.
2976 * lisp.h (check_window_system): New prototype. This function is
2977 going to replace check_x, check_w32 and check_ns.
2978 (have_menus_p): Mention msdos.c in comment.
2979 * fontset.c (check_window_system_func): Remove. Adjust all users.
2980 * fontset.h (check_window_system_func): Remove prototype.
2981 * nsterm.h (check_ns):
2982 * xterm.h (check_x):
2983 * w32term.h (check_w32): Likewise.
2984 * menu.c (Fx_popup_menu): Use check_window_system.
2985 * msdos.c (check_window_system): Define for MS-DOS.
2986 * nsfns.m (check_window_system): Define for NS. Adjust all users.
2987 * w32fns.c (check_window_system): Likewise for MS-Windows.
2988 * xfns.c (check_window_system): Likewise for X.
2989 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
2990 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
2991
7216e43b
PE
29922013-04-02 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 Prefer < to > in range checks such as 0 <= i && i < N.
2995 This makes it easier to visualize quantities on a number line.
2996 This patch doesn't apply to all such range checks,
2997 only to the range checks affected by the 2013-03-24 change.
2998 This patch reverts most of the 2013-03-24 change.
2999 * alloc.c (xpalloc, Fgarbage_collect):
3000 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3001 * character.c (string_escape_byte8):
3002 * charset.c (read_hex):
3003 * data.c (cons_to_unsigned):
3004 * dispnew.c (update_frame_1):
3005 * doc.c (Fsubstitute_command_keys):
3006 * doprnt.c (doprnt):
3007 * editfns.c (hi_time, decode_time_components):
3008 * fileio.c (file_offset):
3009 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3010 * font.c (font_intern_prop):
3011 * frame.c (x_set_alpha):
3012 * gtkutil.c (get_utf8_string):
3013 * indent.c (check_display_width):
3014 * keymap.c (Fkey_description):
3015 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3016 * lread.c (read1):
3017 * minibuf.c (read_minibuf_noninteractive):
3018 * process.c (wait_reading_process_output):
3019 * search.c (Freplace_match):
3020 * window.c (get_phys_cursor_glyph):
3021 * xdisp.c (redisplay_internal):
3022 * xsmfns.c (smc_save_yourself_CB):
3023 Prefer < to > for range checks.
3024 * dispnew.c (sit_for): Don't mishandle NaNs.
3025 This fixes a bug introduced in the 2013-03-24 change.
3026 * editfns.c (decode_time_components): Don't hoist comparison.
3027 This fixes another bug introduced in the 2013-03-24 change.
3028
92759988
DA
30292013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3030
3031 * frame.h (struct frame): Drop scroll_bottom_vpos
3032 member becaue all real users are dead long ago.
3033 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3034 * xdisp.c (redisplay_internal): Adjust user.
3035
9a1971bb
GM
30362013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3037
f38ab167
JD
3038 * nsmenu.m (showAtX:Y:for:): setLevel to
3039 NSPopUpMenuWindowLevel (Bug#13998).
3040
6d01f1fe
JD
30412013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3042
3043 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3044 (ns_check_pending_open_menu): Declare.
3045
3046 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3047 (x_activate_menubar): Update the menu with title that matches
3048 ns_get_pending_menu_title, and call
3049 ns_check_pending_openmenu (Bug#12698).
3050 (menuWillOpen:): New method.
3051 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3052
3053 * nsterm.m (menu_will_open_state, menu_mouse_point)
3054 (menu_pending_title): New varaibles.
3055 (ns_get_pending_menu_title, ns_check_menu_open)
3056 (ns_check_pending_open_menu): New functions.
3057
781f4782
DA
30582013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3059
3060 * indent.c (current_column_bol_cache): Remove leftover which is not
3061 used in Fmove_to_column any more.
3062 (current_column, scan_for_column): Adjust users.
3063 * keyboard.c (last_point_position_buffer, last_point_position_window):
3064 Remove leftovers which are not used for recording undo any more.
3065 (command_loop_1, syms_of_keyboard): Adjust users.
3066 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3067 redisplay_window any more.
3068 (move_it_to): Adjust user.
3069
1921c31b
JB
30702013-03-29 Juanma Barranquero <lekktu@gmail.com>
3071
3072 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3073 Update dependencies.
3074
717b8bcd
SM
30752013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3076
3077 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3078 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3079 forward references.
3080
e74aeda8
DA
30812013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3082
3083 * window.h (struct window): Replace hchild, vchild and buffer slots
3084 with the only contents slot. This is possible because each valid
3085 window may have either the child window (in vertical or horizontal
3086 combination) or buffer to display (for the leaf window). Using that,
3087 a lof of operations to traverse and/or change window hierarchies may
3088 be simplified. New member horizontal is used to distinguish between
3089 horizontal and vertical combinations of internal windows.
3090 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3091 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3092 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3093 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3094 Use contents slot, not buffer, where appropriate.
3095 (wset_combination): New function.
3096 (wset_buffer): Add eassert.
3097 (Fframe_first_window): Simplify the loop reaching first window.
3098 (Fwindow_buffer): Use WINDOW_LEAF_P.
3099 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3100 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3101 (unshow_buffer): Convert initial debugging check to eassert.
3102 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3103 (make_parent_window, window_resize_check, window_resize_apply)
3104 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3105 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3106 Adjust to match struct window changes.
3107 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3108 (mark_window_cursors_off, count_windows, get_leaf_windows)
3109 (foreach_window_1): Simplify the loop.
3110 * alloc.c (mark_object): Do not check for the leaf window because
3111 internal windows has no glyph matrices anyway.
3112 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3113 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3114 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3115 (build_frame_matrix_from_window_tree, mirror_make_current)
3116 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3117 (update_window_tree, set_window_update_flags): Simplify the loop.
3118 (sync_window_with_frame_matrix_rows): Enforce live window.
3119 Use contents slot, not buffer, where appropriate.
3120 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3121 and WINDOW_HORIZONTAL_COMBINATION_P.
3122 (make_frame_visible_1): Simplify the loop.
3123 Use contents slot, not buffer, where appropriate.
3124 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3125 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3126 (expose_window_tree): Likewise.
3127 Use contents slot, not buffer, where appropriate.
3128 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3129 to avoid deleted windows. Use contents slot instead of buffer.
3130 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3131 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3132 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3133 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3134
121ab1cd
EZ
31352013-03-28 Eli Zaretskii <eliz@gnu.org>
3136
ef454cf7
EZ
3137 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3138 identify the reasons for assertion violations in bug#14062 and
3139 similar ones.
21e930f8
EZ
3140 (Fx_show_tip): Fix compilation error under
3141 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3142
121ab1cd
EZ
3143 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3144 Reported by <rzl24ozi@gmail.com>.
3145
5c89ca24
DA
31462013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3147
3148 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3149 start marker...
562c6ee9
SM
3150 (unwind_with_echo_area_buffer): ...to restore it here.
3151 This is needed to ensure that...
5c89ca24
DA
3152 (redisplay_window): ...both window markers are valid here,
3153 which is verified by eassert.
3154 * editfns.c (save_excursion_save): Do not assume that
3155 selected_window always displays the buffer.
c7f53895
DA
3156 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3157 Fix comment.
5c89ca24 3158
f557c1b1
SM
31592013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3160
3161 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3162 the upcase table.
3163
40693bba 31642013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3165
3166 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3167
c86f791f
EZ
31682013-03-27 Eli Zaretskii <eliz@gnu.org>
3169
3170 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3171 since MinGW's w32api headers do. This avoids compiler warnings.
3172
3173 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3174 if already defined.
3175
c6e72e17
EZ
31762013-03-26 Eli Zaretskii <eliz@gnu.org>
3177
3178 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3179
54e95010
JD
31802013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3181
3182 * gtkutil.c (style_changed_cb): Check if frame is live and an
3183 X frame (Bug#14038).
3184
b88b62de
EZ
31852013-03-26 Eli Zaretskii <eliz@gnu.org>
3186
a18d7de6
EZ
3187 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3188 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3189 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3190 MinGW64.
8f5e14c8
EZ
3191 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3192 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3193
b88b62de
EZ
3194 Fix incompatibilities between MinGW.org and MinGW64 headers.
3195 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3196
3197 * w32.c (REPARSE_DATA_BUFFER): Guard with
3198 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3199
c074e458
JD
32002013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3201
3202 * xterm.c: Include X11/XKBlib.h
3203 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3204
908589fd
AS
32052013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3206
3207 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3208 written backwards.
3209 * blockinput.h (input_blocked_p): Likewise.
3210 * bytecode.c (exec_byte_code): Likewise.
3211 * callproc.c (call_process_kill, call_process_cleanup)
3212 (Fcall_process): Likewise.
3213 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3214 (Fccl_execute_on_string): Likewise.
3215 * character.c (string_escape_byte8): Likewise.
3216 * charset.c (read_hex): Likewise.
3217 * cm.c (calccost): Likewise.
3218 * data.c (cons_to_unsigned): Likewise.
3219 * dired.c (directory_files_internal, file_name_completion):
3220 Likewise.
3221 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3222 (sit_for): Likewise.
3223 * doc.c (Fsubstitute_command_keys): Likewise.
3224 * doprnt.c (doprnt): Likewise.
3225 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3226 * emacsgtkfixed.c: Likewise.
3227 * fileio.c (file_offset, Fwrite_region): Likewise.
3228 * floatfns.c (Fexpt, fmod_float): Likewise.
3229 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3230 Likewise.
3231 * font.c (font_intern_prop): Likewise.
3232 * frame.c (x_set_alpha): Likewise.
3233 * gtkutil.c (get_utf8_string): Likewise.
3234 * indent.c (check_display_width): Likewise.
3235 * intervals.c (create_root_interval, rotate_right, rotate_left)
3236 (split_interval_right, split_interval_left)
3237 (adjust_intervals_for_insertion, delete_node)
3238 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3239 (merge_interval_right, merge_interval_left, copy_intervals)
3240 (set_intervals_multibyte_1): Likewise.
3241 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3242 * keymap.c (Fkey_description): Likewise.
3243 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3244 * lread.c (openp, read_integer, read1, string_to_number):
3245 Likewise.
3246 * menu.c (ensure_menu_items): Likewise.
3247 * minibuf.c (read_minibuf_noninteractive): Likewise.
3248 * print.c (printchar, strout): Likewise.
3249 * process.c (create_process, Faccept_process_output)
3250 (wait_reading_process_output, read_process_output, send_process)
3251 (wait_reading_process_output): Likewise.
3252 * profiler.c (make_log, handle_profiler_signal): Likewise.
3253 * regex.c (re_exec): Likewise.
3254 * regex.h: Likewise.
3255 * search.c (looking_at_1, Freplace_match): Likewise.
3256 * sysdep.c (get_child_status, procfs_ttyname)
3257 (procfs_get_total_memory): Likewise.
3258 * systime.h (EMACS_TIME_VALID_P): Likewise.
3259 * term.c (dissociate_if_controlling_tty): Likewise.
3260 * window.c (get_phys_cursor_glyph): Likewise.
3261 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3262 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3263 Likewise.
3264 * xfns.c (Fx_window_property): Likewise.
3265 * xmenu.c (set_frame_menubar): Likewise.
3266 * xselect.c (x_get_window_property, x_handle_dnd_message):
3267 Likewise.
3268 * xsmfns.c (smc_save_yourself_CB): Likewise.
3269 * xterm.c (x_scroll_bar_set_handle): Likewise.
3270
2bf7d27a
DA
32712013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3272
3273 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3274 to be optional or nil. Adjust comment and convert it to docstring.
3275 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3276 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3277
a9ebfa0b
PE
32782013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3279
3280 Static checking by GCC 4.8-20130319.
3281 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3282 * process.c (Fset_process_datagram_address)
3283 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3284 * xdisp.c (get_char_face_and_encoding):
3285 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3286 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3287 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3288
4f3576ee
KB
32892013-03-24 Ken Brown <kbrown@cornell.edu>
3290
789b5e9a
KB
3291 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3292 fix compilation on 64-bit Cygwin, where underscores are not
3293 automatically prepended.
3294
4f3576ee
KB
3295 * w32term.c (w32_initialize): Silence compiler warning.
3296
b5b7745f
EZ
32972013-03-23 Eli Zaretskii <eliz@gnu.org>
3298
cdc0d0bd
EZ
3299 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3300 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3301 variables, to save and restore frame dimensions.
3302 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3303 after returning from a 'fullscreen' configuration.
3304 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3305 to avoid races between the main thread and the input thread.
3306
3307 * w32term.h (struct w32_output): New members normal_width,
3308 normal_height, normal_top, normal_left, and prev_fsmode.
3309 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3310 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3311 members of a frame.
3312
b5b7745f
EZ
3313 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3314 'fullscreen' parameter. Always record previous width and height
3315 of the frame, except when switching out of maximized modes, so
3316 that they could be restored correctly, instead of resetting to the
3317 default frame dimensions. Send SC_RESTORE command to the frame,
3318 unless we are going to send SC_MAXIMIZE, to restore the frame
3319 resize hints in the mouse pointer shown by the window manager.
3320 (Bug#14032)
3321
3322 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3323
3324 * lisp.h (get_frame_param): Adjust conditions for prototype
3325 declaration.
3326
a3454eed
KB
33272013-03-22 Ken Brown <kbrown@cornell.edu>
3328
3329 * unexcw.c: Drop unneeded inclusion of w32common.h.
3330 (report_sheap_usage): Declare.
3331 (read_exe_header): Add magic numbers for x86_64.
3332 (fixup_executable): Fix printf format specifier for unsigned long
3333 argument.
3334
5a49b79c
DA
33352013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3336
3337 * frame.h (struct frame): Put menu_bar_window under #ifdef
3338 because this member is not needed when X toolkit is in use.
3339 (fset_menu_bar_window):
3340 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3341 (free_glyphs, update_frame):
3342 * xdisp.c (expose_frame): Likewise.
3343 (display_menu_bar): Likewise. Remove redundant eassert.
3344 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3345 toolkit is in use.
3346
d6723bf7
PE
33472013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3348
7b1123d8
PE
3349 Use functions and constants to manipulate Lisp_Save_Value objects.
3350 This replaces code that used macros and strings and token-pasting.
3351 The change makes the C source a bit easier to follow,
3352 and shrinks the Emacs executable a bit.
3353 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3354 (make_save_value): Change 1st arg from string to enum. All callers
3355 changed.
3356 (INTX): Remove.
3357 (mark_object): Use if, not #if, for GC_MARK_STACK.
3358 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3359 (XSAVE_OBJECT): Now functions, not macros.
3360 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3361 the constant was never used.
3362 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3363 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3364 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3365 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3366 New constants.
3367 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3368 type3 with a single member save_type. All uses changed.
3369 (save_type, set_save_pointer, set_save_integer): New functions.
3370 * print.c (PRINTX): Remove.
3371
d6723bf7
PE
3372 * alloc.c: Remove redundant static declarations.
3373
5f24fa51
DA
33742013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3375
3376 * window.h (struct window): Convert left_col, top_line, total_lines
3377 and total_cols from Lisp_Objects to integers. Adjust comments.
3378 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3379 Remove.
3380 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3381 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3382 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3383 Adjust users where appropriate.
3384
42143acd
DA
33852013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3386
3387 * frame.h (struct frame): Drop resx and resy because the same data is
3388 available from window system-specific output context. Adjust users.
562c6ee9
SM
3389 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3390 New functions to provide defaults when no window system available.
42143acd 3391 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3392 (NUMVAL): Move from xdisp.c.
42143acd
DA
3393 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3394 (Ffont_face_attributes, Fopen_font):
3395 * image.c (gs_load):
3396 * w32font.c (fill_in_logfont):
3397 * xdisp.c (calc_pixel_width_or_height):
3398 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3399 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3400
c0a17406
KH
34012013-03-20 Kenichi Handa <handa@gnu.org>
3402
3403 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3404 to 1 (temporary workaround until a bug related to ASCII
3405 optimization is fixed).
3406
095d384d
DA
34072013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3408
3409 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3410 Signal error if window is not internal. Adjust docstring.
3411 (delete_all_child_windows): Use combination_limit to save the buffer.
3412 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3413 * print.c (syms_of_print): Initialize debugging output not here...
3414 (init_print_once): ...but in a new function here.
3415 * lisp.h (init_print_once): Add prototype.
3416 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3417
748fa866
DA
34182013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3419
3420 * window.c (window_resize_check, window_resize_apply)
3421 (window_from_coordinates, recombine_windows, set_window_buffer)
3422 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3423 (Fsplit_window_internal, Fdelete_window_internal)
3424 (freeze_window_starts): Use bool for booleans.
3425 * window.h (window_frame_coordinates, resize_frame_windows)
3426 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3427
81519fd2
SM
34282013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3429
3430 * dispnew.c (bitch_at_user): Use `user-error'.
3431
6db423a9
KB
34322013-03-17 Ken Brown <kbrown@cornell.edu>
3433
3434 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3435 as return type of image_background. (Bug#13981)
3436 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3437
8f2906f5
JD
34382013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3439
960ce480 3440 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3441 (ns_select): Don't return with result uninitialized.
960ce480 3442
8f2906f5
JD
3443 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3444 and getDirectory.
3445
81519fd2
SM
3446 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3447 New functions.
8f2906f5
JD
3448 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3449 directories. If filename is nil, get directory name (Bug#13932).
3450 Use getFilename and getDirectory.
3451 (getFilename, getDirectory): New methods for EmacsSavePanel and
3452 EmacsOpenPanel.
3453 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3454
cded56c1
PE
34552013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3456
3457 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3458
251e9147 34592013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3460
3461 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3462 (adjust_after_replace): Make it back to static. Delete the third
3463 arg text_at_gap_tail. Cancel the code for handling it.
3464
3465 * coding.h (struct coding_system): New member eol_seen.
3466
3467 * coding.c (detect_ascii): New function.
3468 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3469 when the source bytes are actually scanned. On detecting for
3470 coding_category_utf_8_auto, call detect_ascii instead of scanning
3471 source bytes directly.
3472 (produce_chars): Call insert_from_gap with the new arg 0.
3473 (encode_coding): Likewise.
3474 (decode_coding_gap): Control ASCII optimization by the variable
3475 disable_ascii_optimization instead of #ifndef .. #endif.
3476 Deccode EOL format according to coding->eol_seen.
3477 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3478 variable.
3479
8a44e6d1
KH
3480 * lisp.h (adjust_after_replace): Cancel externing it.
3481 (insert_from_gap): Adjust prototype.
3482
5f795e34
EZ
34832013-03-15 Eli Zaretskii <eliz@gnu.org>
3484
3485 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3486 FULLSCREEN_MAXIMIZED. (Bug#13935)
3487
f258b4be
DA
34882013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3489
3490 * region-cache.c (find_cache_boundary, move_cache_gap)
3491 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3492 Simplify debugging check and convert to eassert. Adjust comment.
3493 (pp_cache): Put under ENABLE_CHECKING.
3494
a5cc4dde
EZ
34952013-03-14 Eli Zaretskii <eliz@gnu.org>
3496
3497 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3498 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3499 and WM_ACTIVATEAPP.
3500 (w32fullscreen_hook): If the frame is visible, reset
3501 f->want_fullscreen flag after changing the frame size. If the
3502 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3503 (Bug#13953)
3504
3fc5e44a
DC
35052013-03-13 Daniel Colascione <dancol@dancol.org>
3506
3507 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3508 too so that these builds can use Cygwin's file conversion
3509 functions. (We've been building and linking cygw32.o all along
3510 and just not using it.)
3511
47d7532e
PE
35122013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 File synchronization fixes (Bug#13944).
3515 * Makefile.in (LIB_FDATASYNC): New macro.
3516 (LIBES): Use it.
3517 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3518 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3519 Don't worry about HAVE_FSYNC, since a substitute fsync is
3520 available if the system lacks one.
3521 (Fwrite_regin): Retry fsync if interrupted.
3522
c7ffccaf
EZ
35232013-03-13 Eli Zaretskii <eliz@gnu.org>
3524
4e2df81d 3525 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3526 activated, call w32fullscreen_hook, to make sure the new frame
3527 dimensions are in effect. (Bug#13937)
3528
8a7debc1
DA
35292013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3530
3531 * xdisp.c (init_iterator): Simplify because both character and byte
3532 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3533 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3534 character and byte positions can be obtained from marker.
8a7debc1 3535
7fd8c501
PE
35362013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3537
d9df6f40
PE
3538 Static checking by Sun C 5.12.
3539 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3540 * bytecode.c (exec_byte_code):
3541 * dispnew.c (init_display):
3542 * eval.c (error):
3543 * fileio.c (Fsubstitute_in_file_name):
3544 * keyboard.c (Fevent_convert_list):
3545 * keymap.c (Fsingle_key_description):
3546 * term.c (maybe_fatal, fatal):
3547 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3548 * xsmfns.c (Fhandle_save_session):
3549 Omit unreachable code.
3550 * keymap.c (map_keymap_char_table_item): Cast void * to
3551 a function pointer type; the C Standard requires this.
3552
7fd8c501
PE
3553 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3554 Include <sys/param.h> unconditionally, as that works elsewhere and
3555 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3556 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3557 and FreeBSD now.
3558
a020afb9 3559See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3560
3561;; Local Variables:
3562;; coding: utf-8
aac0c6e3
MR
3563;; End:
3564
ab422c4d 3565 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3566
3567 This file is part of GNU Emacs.
3568
3569 GNU Emacs is free software: you can redistribute it and/or modify
3570 it under the terms of the GNU General Public License as published by
3571 the Free Software Foundation, either version 3 of the License, or
3572 (at your option) any later version.
3573
3574 GNU Emacs is distributed in the hope that it will be useful,
3575 but WITHOUT ANY WARRANTY; without even the implied warranty of
3576 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3577 GNU General Public License for more details.
3578
3579 You should have received a copy of the GNU General Public License
3580 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.