(imagemagick_compute_animated_image): Clean up code slightly
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a5b5f73f
LMI
12013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * image.c (imagemagick_compute_animated_image): Respect the GIF
4 disposal methods.
5
0fe73012
KB
62013-08-15 Ken Brown <kbrown@cornell.edu>
7
8 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
9 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
10 needed.
11
691a357f
PE
122013-08-15 Paul Eggert <eggert@cs.ucla.edu>
13
14 Fix minor problems found by static checking.
15 * frame.c (delete_frame):
16 * xdisp.c (next_element_from_display_vector):
17 Avoid uninitialized local.
18 * image.c (imagemagick_compute_animated_image): Port to C89.
19 Prefer usual GNU indentation style for loops.
20 Be more careful about bizarrely large sizes, by using ptrdiff_t
21 instead of int.
22
42fe2e88
DA
232013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
24
25 Fix infinite frame selection loop (Bug#15025).
26 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
27
d39a3da6
EZ
282013-08-15 Eli Zaretskii <eliz@gnu.org>
29
30 * xdisp.c (compute_window_start_on_continuation_line): When
31 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
32 to make sure we end up setting the window start at the leftmost
33 visible character of the display line. This avoids funky
34 horizontal shifting because the window start is not kept on the
35 same position. (Bug#15090)
05426239
EZ
36 (next_element_from_display_vector): Support 'box' face attribute
37 in the face definitions of a display vector. (Bug#15099)
d39a3da6 38
6e856b69
LMI
392013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
40
41 * image.c (imagemagick_compute_animated_image): Implement animated
42 images (bug#14700).
995be755
LMI
43 (imagemagick_compute_animated_image): Fix some compilation
44 warnings. Implement a very simple cache to make the animation
45 usable at all, but it should be replaced with a per-image cache.
6e856b69 46
d5a1acfa
DA
472013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
48
49 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
50 to do `for' loops over alist values.
51 * buffer.h (FOR_EACH_BUFFER):
52 * process.c (FOR_EACH_PROCESS): Use it.
53 (handle_child_signal, status_notify, Fget_buffer_process)
54 (kill_buffer_processes): Use FOR_EACH_PROCESS.
55
9c253307
DA
562013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
57
58 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
59 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
60 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
61 to xzalloc and so avoid redundant call to memset.
62 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
63 members because it is allocated with xzalloc and so already zeroed.
64
05e64f9f
KB
652013-08-14 Ken Brown <kbrown@cornell.edu>
66
67 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
68 (Bug#15094).
69
5b71542d
DA
702013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
71
72 Utility function and macro to copy Lisp string to C string.
73 * lisp.h (xlispstrdupa): New macro.
74 (xlispstrdup): New prototype.
75 * alloc.c (xlispstrdup): New function.
76 * callint.c (Fcall_interactively):
77 * fileio.c (Ffile_name_directory, Fexpand_file_name)
78 (Fsubstitute_in_file_name):
79 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
80 * image.c (x_create_bitmap_from_file):
81 * w32term.c (w32_term_init):
82 * xterm.c (x_term_init): Use xlispstrdup.
83
71530c97
LMI
842013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
85
4ce82fb8
LMI
86 * image.c (imagemagick_load_image): Make animated pictures work.
87 There's still some problems with background color settings, though
88 (bug#14700).
89
71530c97
LMI
90 * decompress.c (unwind_decompress): Always restore point.
91
7510a061
XF
922013-08-14 Xue Fuqiao <xfq.free@gmail.com>
93
94 * marker.c (set_marker): Reformat documentation.
95
01c3051f
PE
962013-08-14 Paul Eggert <eggert@cs.ucla.edu>
97
aab1fcdf
PE
98 * xdisp.c (cursor_type_changed): Now static.
99
01c3051f
PE
100 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
101 Use changed. This avoids the need to call xmalloc and for the
102 caller to call xfree, and avoids memory leaks in some situations.
103
2084152a
DA
1042013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
105
106 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
107 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
108 (redisplay_window): If window_end_valid is cleared due to non-zero
109 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
110 so do not call to try_cursor_movement for that window.
2084152a 111
02455cb6
DA
1122013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * window.h (struct window): Convert window_end_pos and
115 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
116 (wset_window_end_pos, wset_window_end_vpos): Remove.
117 * dispnew.c (adjust_glyph_matrix):
118 * window.c (Fwindow_end, replace_window, set_window_buffer)
119 (make_window):
120 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
121 (set_vertical_scroll_bar, redisplay_window, try_window)
122 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
123 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
124 (note_mouse_highlight): Adjust users.
125 (try_cursor_movement): Likewise. Convert old precondition to eassert.
126 Add comment.
127
da5707e8
DA
1282013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
129
130 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
131 * image.c (imagemagick_filename_hint): Use `const char *' and
132 prefer SSDATA to SDATA to avoid warnings.
133
25554267
DA
1342013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
135
136 Cleanup window fringes, margins and scroll bars adjustments.
137 * window.c (set_window_fringes, set_window_margins)
138 (set_window_scroll_bars, apply_window_adjustment): New functions.
139 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
140 (Fset_window_scroll_bars): Use them.
141
38a2c910
DA
1422013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
143
144 * window.h (struct window): Convert scroll_bar_width
145 from Lisp_Object to integer. Adjust comment.
146 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
147 Adjust users.
148 * window.c (wset_scroll_bar_width): Remove.
149 (make_window): Initialize scroll_bar_width.
150 (Fsplit_window_internal): Use direct assignment.
151 (Fset_window_configuration, save_window_save):
152 Convert Lisp_Object to integer and back where appropriate.
153 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
154 bar was actually changed, and mention this in docstring.
155
2d065031
PE
1562013-08-13 Paul Eggert <eggert@cs.ucla.edu>
157
158 * decompress.c: Minor simplifications.
159 (Fzlib_decompress_region): Don't bother verifying
160 that avail_out <= UINT_MAX, as that was confusing.
161 Mention the restriction in a comment instead.
162 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
163
a5bd5abb
JD
1642013-08-13 Jan Djärv <jan.h.d@swipnet.se>
165
166 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
167 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
168
66e7901a
LMI
1692013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
170
171 * image.c (imagemagick_filename_hint): Check for errors in the
172 alist structure.
173
2fa611b7
EZ
1742013-08-13 Eli Zaretskii <eliz@gnu.org>
175
176 * window.c (Fwindow_margins): Return nil when there's no marginal
177 area, as per the documented API.
178
179 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
180 Fmake_vector, as scroll bar's struct members are not all Lisp
181 objects now. This avoids crashes in GC.
182
183 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
184 bool, so its address could be taken.
185
8259030d
LMI
1862013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
187
188 * image.c (imagemagick_filename_hint): New function to possibly
189 apply `image-content-type-suffixes'.
190 (imagemagick_load_image): Use it.
191
866c710e
EZ
1922013-08-13 Eli Zaretskii <eliz@gnu.org>
193
194 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
195 if loading zlib failed.
196
f10490f0
JD
1972013-08-13 Jan Djärv <jan.h.d@swipnet.se>
198
96311be7
JD
199 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
200 2013-08-13 checkin below. Change bool to BOOL, rule is:
201 All Obj-C code uses BOOL, except for interfaces callable from C.
202
f10490f0
JD
203 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
204
c8ae93b0
DA
2052013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
206
207 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
208 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
209 bool instead of BOOL.
210 * w32term.h (struct scroll_bar): Convert fringe_extended_p
211 from Lisp_Object to bitfield. Adjust comment.
212 * w32term.c (x_scroll_bar_create): Adjust user.
213 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
214 * xterm.c (XTset_vertical_scroll_bar): Likewise.
215 Use bool for boolean.
216 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
217 to `unsigned int' when defining a bitfield.
218
53b64418
PE
2192013-08-13 Paul Eggert <eggert@cs.ucla.edu>
220
221 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
222
eeaf9bf3
DA
2232013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
224
225 * window.h (struct window): Convert left_margin_cols and
226 right_margin_cols from Lisp_Objects to integers. Adjust comment.
227 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
228 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
229 Adjust users.
230 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
231 Adjust comment.
232 (showing_window_margins_p, update_window_line, update_frame_1):
233 * fringe.c (draw_fringe_bitmap_1):
234 * xdisp.c (window_box_width): Adjust users.
235 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
236 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
237 Use direct assignment.
238 (Fset_window_configuration, save_window_save, Fwindow_margins):
239 Convert Lisp_Object to integer and back where appropriate.
240 (Fset_window_margins): Adjust user. Return t if any margin
241 was actually changed, and mention this in docstring.
242
956720af
XF
2432013-08-13 Xue Fuqiao <xfq.free@gmail.com>
244
f73f4ce6 245 * syntax.c (forward_word):
956720af
XF
246 * cmds.c (forward_char, backward_char): Mention the optional argument.
247
9e37ee3b
DA
2482013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
249
250 * window.h (struct window): Convert left_fringe_width
251 and right_fringe_width from Lisp_Objects to integers.
252 Adjust comment.
253 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
254 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
255 * window.c (wset_left_fringe_width, wset_right_fringe_width):
256 Remove.
257 (make_window): Initialize new integer fields to -1.
258 (Fsplit_window_internal): Use direct assignment.
259 (Fset_window_configuration, save_window_save): Convert
260 Lisp_Object to integer and back where appropriate.
261 (Fset_window_fringes): Adjust user. Return t if any fringe
262 was actually changed, and mention this in docstring.
263
e4375ca7
DA
2642013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
265
266 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
267 * nsfns.m (x_set_cursor_type):
268 * w32fns.c (x_set_cursor_type):
269 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
270 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 271
a45543bc
DA
2722013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
273
274 * font.c (clear_font_cache): New function, stripped from...
275 (Fclear_font_cache): ...here, which now uses the function
276 above. Adjust comment.
277 * font.h (clear_font_cache): Add prototype.
278 * xfaces.c (clear_face_cache): Use clear_font_cache.
279
ae966a86
DA
2802013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
281
282 * window.c (Fset_window_start): Compare `w', not `window' because
283 `w' might not be equal to `window' after call to decode_live_window.
284
297a545b
PE
2852013-08-12 Paul Eggert <eggert@cs.ucla.edu>
286
287 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
288 This fixes a problem introduced by the Bug#15035 patch
289 when using GPG. Reported by Herbert J. Skuhra.
290
aa942e2b
EZ
2912013-08-12 Eli Zaretskii <eliz@gnu.org>
292
293 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
294 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
295 not yet initialized.
296
7699d09e
LMI
2972013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
298
299 * decompress.c (Fzlib_decompress_region): Support zlib
300 decompression, too, and rename.
301
1d238bc7
PE
3022013-08-12 Paul Eggert <eggert@cs.ucla.edu>
303
304 Minor zlib configuration tweaks.
305 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
306 Don't assume presence of fn_inflateInit2_ zlib internal function.
307
8a44a184
LMI
3082013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
309
310 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
311 include the zlib prefix.
312
594a4307
EZ
3132013-08-12 Eli Zaretskii <eliz@gnu.org>
314
315 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
316 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
317 define static variables that are pointers to zlib functions to be
318 dynamically loaded.
319 (init_zlib_functions) [WINDOWSNT]: New function.
320 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
321 New macros.
322 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
323 macros instead of invoking the zlib functions directly.
324 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
325 Szlib_available_p.
326
d2e113bc
DA
3272013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Avoid looping over all frame windows to freeze and unfreeze.
330 * window.h (struct window): Drop frozen_window_start_p.
331 (freeze_window_starts): Drop prototype.
332 * frame.h (struct frame): New frozen_window_starts flag.
333 (FRAME_WINDOWS_FROZEN): New macro.
334 * window.c (freeze_window_start, freeze_window_starts):
335 Remove.
336 (select_window, replace_window): Adjust users.
337 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
338 (window_frozen_p): New function.
339 (redisplay_window): Use it.
340
94fcd171
PE
3412013-08-12 Paul Eggert <eggert@cs.ucla.edu>
342
343 Fix some fd issues when running subprocesses (Bug#15035).
344 Fix bugs that can leak files or file descriptors on errors.
345 Don't unlink open temp files, as that's hard for users to diagnose
346 when things go awry (e.g., temp disk exhausted).
347 Don't bother to lock temp files. Check for invalid recursion.
348 * callproc.c (synch_process_fd): Remove. All uses removed.
349 (synch_process_tempfile): New var or macro.
350 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
351 New constants.
352 (record_kill_process): New arg, the temp name. All callers changed.
353 (delete_temp_file): Now just a simple wrapper around unlink.
354 (call_process_kill): New arg, the call_process_fd array.
355 Close them all. Clear synch_process_pid. Remove the temp file,
356 or arrange for it to be removed.
357 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
358 that's been moved to synch_process_tempfile. Caller changed.
359 Do not remove the tempfile; that's now call_process_kill's
360 responsibility.
361 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
362 call_process_kill; the caller now does that.
363 (call_process_cleanup): Do not close the process fd; that's now
364 call_process_kill's responsibility.
365 (Fcall_process): Implement via new function call_process, which
366 has most of the old body of Fcall_process, but with a different API.
367 (call_process): New function that does not open or close filefd if
368 it is nonnegative. Record which fds need to be closed, and let
369 call_process_kill close (and remove the tempfile, on MSDOS) on error.
370 Signal an error if invoked recursively (could be done via a hook).
371 Simplify creation of the tempfile in the MSDOS case.
372 Don't create the output file until after checking for the executable.
373 Report any failure to open /dev/null.
374 Don't open /dev/null for writing twice; once is enough.
375 Don't create pipe if all output is being discarded or sent to file.
376 Don't worry about setting up the coding system or reading from the
377 pipe if all output is being discarded.
378 Hoist fd_error local into top level, to lessen block nesting.
379 Don't record deleted pid here; now done by Fcall_process_region.
380 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
381 and note its success in synch_process_tempfile.
382 Do not leak resources when child_setup fails.
383 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
384 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
385 (create_temp_file): Now returns open fd, with an additional
386 Lisp_Object * argument to return the name. All callers changed.
387 Do not close the file; rewind it instead, and leave it open for
388 the caller. Do not lock the temp file. Unwind-protect the file
389 and the file-descriptor.
390 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
391 If an asynchrounous process, record it here, not in call_process.
392 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
393 * eval.c (set_unwind_protect): New function.
394 * fileio.c (write_region): New function, generalized from the
395 old Fwrite_region. Do not lock temp files.
396 (Fwrite_region): Use it.
397 * lisp.h (set_unwind_protect, write_region): New decls.
398 * process.c: Include <verify.h>.
399 (make_process): Mark fds as initially closed.
400 (deleted_pid_list): Now a list of pid-filename pairs.
401 All uses changed.
402 (close_process_fd): New function.
403 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
404 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
405 New constants. Verify that their number matches PROCESS_OPEN_FDS.
406 (create_process, create_pty, Fmake_serial_process)
407 (server_accept_connection): Record which fds need to be closed,
408 and let deactivate_process close them.
409 (Fmake_network_process): Do not discard the unwind-protect
410 until it's safe to do so.
411 (deactivate_process): Close the fds opened by create_process etc.
412 (Fprocess_send_eof): Adjust to new way of recording open fds.
413 Report an error if /dev/null can't be opened, instead of aborting.
414 * process.h (PROCESS_OPEN_FDS): New constant.
415 (struct Lisp_Process): New member open_fds.
416 (record_kill_process, record_deleted_pid): Adjust signatures.
417 (record_deleted_pid): Move decl here ...
418 * syswait.h (record_deleted_pid): ... from here.
419
d0e615c3
PE
4202013-08-11 Paul Eggert <eggert@cs.ucla.edu>
421
422 * decompress.c: Fix bugs with large buffers and weird inputs.
423 Tune a bit. Reindent as per usual Emacs style.
424 (BUFFER_SIZE): Remove.
425 (Fdecompress_gzipped_region): Do not mishandle input buffers with
426 more than UINT_MAX bytes. Decompress into the gap instead of into
427 an auto buffer, as this should avoid copying. Return nil if
428 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
429 set immediate_quit; we shouldn't trust zlib code that much.
430
313546eb
LMI
4312013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
432
99a32242
LMI
433 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
434 errors, and really move the gap to where we want it.
435
313546eb
LMI
436 * lisp.h: Include decompress.c support.
437
438 * emacs.c (main): Include decompress.c support.
439
440 * Makefile.in: Include -lz if present.
441
d2d699ac
JD
4422013-08-11 Jan Djärv <jan.h.d@swipnet.se>
443
f90e3ebd
JD
444 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
445 (initWithTitle:): Initialize frame to 0.
446 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
447 (fillWithWidgetValue:frame:): Renamed from
448 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
449
450 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
451 fillWithWidgetValue:frame:
452
423d3b3f
JD
453 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
454 remove memory leak warnings.
455
d2d699ac
JD
456 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
457 (ns_check_menu_open): Handle menu == nil. Remove assignment to
458 menu_pending_title.
459
460 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
461 (x_activate_menubar): Update the whole menu.
462 (trackingNotification:): Call ns_check_menu_open if tracking ends.
463 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
464 current event is not NSSystemDefined (Bug#15001).
465 Call ns_check_menu_open only if trackingMenu is 2.
466 (menuDidClose:): New method, decrease trackingMenu.
467 (fillWithWidgetValue:setDelegate:): New method.
468 (fillWithWidgetValue:): Call the above.
469
470 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
471
7d652d97
PE
4722013-08-11 Paul Eggert <eggert@cs.ucla.edu>
473
474 Omit some unnecessary casts.
475 Many of these go back to the old pre-C89 days, when they may have
476 been needed, but we've been assuming C89 or later for a while now.
477 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
478 (live_float_p, live_misc_p, live_vector_p):
479 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
480 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
481 (defvar_per_buffer):
482 * callint.c (Fcall_interactively):
483 * doc.c (Fsubstitute_command_keys):
484 * filelock.c (get_boot_time):
485 * frame.c (xrdb_get_resource):
486 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
487 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
488 (xg_get_file_name_from_selector, menuitem_destroy_callback)
489 (menuitem_highlight_callback, menu_destroy_callback)
490 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
491 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
492 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
493 (xg_tool_bar_help_callback, tb_size_cb):
494 * image.c (xpm_alloc_color, png_read_from_memory)
495 (png_read_from_file, png_load_body, our_memory_skip_input_data)
496 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
497 (syms_of_image):
498 * keymap.c (describe_map):
499 * nsfns.m (Fns_display_monitor_attributes_list):
500 * nsmenu.m (process_dialog:):
501 * nsterm.m (hold_event):
502 * process.c (wait_reading_process_output):
503 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
504 * scroll.c (do_direct_scrolling, scrolling_1):
505 * termcap.c (tgetent):
506 * window.c (check_window_containing, add_window_to_list)
507 (freeze_window_starts):
508 * xdisp.c (compare_overlay_entries, vmessage):
509 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
510 (x_get_monitor_attributes_xrandr)
511 (Fx_display_monitor_attributes_list, x_display_info_for_name)
512 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
513 * xfont.c (xfont_match, xfont_open):
514 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
515 (menubar_selection_callback, menu_position_func)
516 (popup_selection_callback, create_and_show_popup_menu)
517 (dialog_selection_callback, create_and_show_dialog):
518 * xrdb.c (x_get_string_resource):
519 (main) [TESTRM]:
520 * xsmfns.c (x_session_check_input):
521 * xterm.c (x_draw_glyphless_glyph_string_foreground)
522 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
523 (xaw_jump_callback, xaw_scroll_callback):
524 Omit unnecessary casts.
525
9acc1074
PE
5262013-08-10 Paul Eggert <eggert@cs.ucla.edu>
527
528 Minor string-length refactoring.
529 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
530 * frame.c (make_monitor_attribute_list):
531 Prefer build_string to strlen + make_string.
532
361c0eb8
JD
5332013-08-10 Jan Djärv <jan.h.d@swipnet.se>
534
535 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
536 don't check minor_code (Bug#14417).
537
14ba0822
EZ
5382013-08-09 Eli Zaretskii <eliz@gnu.org>
539
540 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
541 vertical positions instead. This avoids calling MATRIX_ROW with
542 row numbers that are possibly beyond valid limits. (Bug#15064)
543
309f24d1
DA
5442013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
545
546 Use xstrdup and build_unibyte_string where applicable.
547 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
548 * xfns.c (x_window):
549 * xrdb.c (x_get_customization_string):
550 * xterm.c (xim_initialize):
551 * w32fns.c (w32_window): Use xstrdup.
552 (w32_display_monitor_attributes_list):
553 * emacs.c (init_cmdargs):
554 * keyboard.c (PUSH_C_STR):
555 * nsfont.m (nsfont_open):
556 * sysdep.c (system_process_attributes):
557 * w32.c (system_process_attributes):
558 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
559
55902276
EZ
5602013-08-09 Eli Zaretskii <eliz@gnu.org>
561
562 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
563 variables of these types so that GDB would know about them, as aid
564 for debugging fatal exceptions. (Bug#15024) See also
565 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
566 discussions.
567
10bf7f5a
JD
5682013-08-08 Jan Djärv <jan.h.d@swipnet.se>
569
570 * nsterm.m (ns_update_begin): Don't change clip path if it would be
571 larger than the NSWindow (Bug#14934).
572
65620264
DA
5732013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
574
575 Redesign redisplay interface to drop global variable updated_window.
576 Always pass currently updated window as a parameter to update routines.
577 * dispextern.h (updated_window): Remove declaration.
578 (struct redisplay_interface): Pass window parameter to
579 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
580 and after_update_window_hook.
581 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
582 Adjust prototypes.
583 * dispnew.c (updated_window): Remove.
584 (redraw_overlapped_rows, update_marginal_area, update_text_area)
585 (update_window_line): Adjust to match redisplay interface changes.
586 * nsterm.m (ns_update_window_begin, ns_update_window_end)
587 (ns_scroll_run, ns_after_update_window_line):
588 * w32term.c (x_update_window_begin, x_update_window_end)
589 (x_after_update_window_line, x_scroll_run):
590 * xterm.c (x_update_window_begin, x_update_window_end)
591 (x_after_update_window_line, x_scroll_run):
592 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
593 Likewise. Adjust comments where appropriate.
594 (x_cursor_to): Simplify because this is always called during window
595 update (but install debugging check anyway).
596 (expose_window): Check must_be_updated_p flag to see whether this
597 function is called during window update.
598
628fdc56
DA
5992013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Do not reset window modification event counters excessively.
602 These leftovers and poor man's tricky methods to catch extra
603 redisplay's attention are no longer needed.
604 * frame.c (set_menu_bar_lines_1):
605 * minibuf.c (read_minibuf_unwind):
606 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
607 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
608 (window_scroll_line_based, Fset_window_configuration):
609 * xdisp.c (redisplay_window): Do not reset last_modified and
610 last_overlay_modified counters.
611
8fd9c92e
JD
6122013-08-07 Jan Djärv <jan.h.d@swipnet.se>
613
614 * xselect.c (x_send_client_event): Set send_event and serial, memset
615 data.l as it might be bigger than data.b. Use 24 bit mask to
616 XSendEvent (Bug#15034).
617
0ee18172
EZ
6182013-08-07 Eli Zaretskii <eliz@gnu.org>
619
620 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
621 for TTY frames that are not the top frame on their console.
622 (Bug#14616)
623
16ddd1a6
MR
6242013-08-07 Martin Rudalics <rudalics@gmx.at>
625
626 * w32term.c (w32fullscreen_hook): Really maximize frame when
627 asked for (Bug#14841).
628
d2a95ffb
DA
6292013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
630
631 Prefer selected_window to Fselected_window, likewise for frames.
632 * buffer.c (Fbuffer_swap_text):
633 * data.c (Fvariable_binding_locus):
634 * window.c (run_window_configuration_change_hook): Adjust users.
635 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
636 Use decode_live_frame.
637
170da1ec
DA
6382013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
639
640 Be more careful if selected window shows the buffer other than current,
641 use window_outdated only if this is not so. This change should also
642 address some weird issues discussed in Bug#13012.
643 * window.h (window_outdated): New prototype.
644 * window.c (window_outdated): Now here. Convert from static and
645 always assume window's buffer.
646 (Fwindow_end, Fwindow_line_height): Use it.
647 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
648 and always assume window's buffer.
649 (redisplay_window): Adjust user.
e5eefe9b 650 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
651 check whether mode line should be updated only if selected window
652 shows current buffer.
653 (run_window_scroll_functions): Use eassert for debugging check.
654 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
655
56b5d5b1
DA
6562013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
657
658 * window.c (window_scroll, window_scroll_pixel_based)
659 (window_scroll_line_based): Use bool for booleans.
660
2878ba7e
PE
6612013-08-06 Paul Eggert <eggert@cs.ucla.edu>
662
663 * process.c: Fix minor off-by-one issues in descriptor counts.
664 This shouldn't fix any real bugs, but it cleans up the code a bit.
665 (max_process_desc, max_input_desc): -1, not 0, means none.
666 All uses changed.
667 (delete_input_desc): New function.
668 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
669 (deactivate_process): Scan backwards when recomuting max_process_desc;
670 that should be faster.
671 (init_process_emacs): Initialize max_input_desc.
672
e30b79c1
DA
6732013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
674
675 Use region cache to speedup bidi_find_paragraph_start.
676 * buffer.h (struct buffer): New member bidi_paragraph_cache.
677 Rename cache_long_line_scans to cache_long_scans.
678 * buffer.c (bset_cache_long_line_scans): Rename to
679 bset_cache_long_scans.
680 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
681 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
682 into account.
683 (syms_of_buffer): Rename cache-long-line-scans to
684 cache-long-scans. Adjust docstring.
685 * search.c (newline_cache_on_off):
686 * indent.c (width_run_cache_on_off): Adjust users.
687 * bidi.c (bidi_paragraph_cache_on_off): New function.
688 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
689 * insdel.c (prepare_to_modify_buffer): Invalidate
690 bidi_paragraph_cache if enabled.
691
00012b86
DA
6922013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
693
694 Invalidate region caches only if buffer text is going to be changed.
695 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
696 (modify_text): ...new prototype.
697 (prepare_to_modify_buffer_1): New prototype.
698 * textprop.c (modify_region): Rename to...
699 (modify_text_properties): ...new function.
700 (add_text_properties_1, set_text_properties, Fremove_text_properties)
701 (Fremove_list_of_text_properties): Adjust users.
702 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
703 (modify_text): ...new function.
704 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
705 (prepare_to_modify_buffer_1): ...new function.
706 * casefiddle.c (casify_region):
707 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
708 (Ftranspose_regions): Use modify_text.
709
dc6c0eda
SM
7102013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
711
712 * lisp.mk (lisp): Add nadvice.elc.
713
8f3a2c26
DA
7142013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
715
716 New macro to iterate over live buffers similar to frames.
717 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
718 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
719 Declare buffer-related variables here to offload lisp.h.
720 * buffer.c (Vbuffer_alist): Adjust comment.
721 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
722 (other_buffer_safely):
723 * data.c (store_symval_forwarding):
724 * dispnew.c (Fframe_or_buffer_changed_p):
725 * fileio.c (Fdo_auto_save):
726 * filelock.c (unlock_all_files):
727 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
728
e0fdb694
PE
7292013-08-04 Paul Eggert <eggert@cs.ucla.edu>
730
731 Fix some minor races in hosts lacking mkostemp (Bug#15015).
732 * callproc.c (create_temp_file):
733 * filelock.c (create_lock_file):
734 Assume mkostemp, since it's now provided by Gnulib.
735
63f5c6c2
EZ
7362013-08-04 Eli Zaretskii <eliz@gnu.org>
737
738 * w32.c (mkostemp): New function.
739 (mktemp): Remove, no longer used. Most of the code reused in
740 mkostemp. (Bug#15015)
484ab239 741 (mktemp): Don't undef.
63f5c6c2 742
f0b79313
DA
7432013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
744
745 * dispnew.c (glyph_matrix_count, glyph_pool_count):
746 Move under GLYPH_DEBUG and ENABLE_CHECKING.
747 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
748 (free_glyph_pool, check_glyph_memory): Likewise for
749 all users. Adjust comments where appropriate.
750
98f638d6
PE
7512013-08-03 Paul Eggert <eggert@cs.ucla.edu>
752
753 * composite.h: Minor fixups.
754 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
755 to fix a misspelling, and change it to an inline function while
756 we're at it (it need not be a macro). All uses changed.
757 (composition_method, composition_valid_p):
758 Rewrite to avoid assignments in if-conditions.
759
75c59fb3
DA
7602013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
761
762 Do not use global Lisp_Object in composition macros.
763 * composite.h (composition_temp): Remove declaration.
764 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
765 (composition_method, composition_valid_p): ...inline functions.
416a3e01 766 (compose_region): Remove the leftover.
75c59fb3
DA
767 * composite.c (composition_temp): Remove.
768 (run_composition_function, update_compositions)
769 (composition_compute_stop_pos, composition_adjust_point)
770 (Ffind_composition_internal):
771 * coding.c (handle_composition_annotation):
772 * xdisp.c (handle_composition_prop, check_point_in_composition):
773 Related users changed.
774
a10c8269
DA
7752013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
776
777 Drop FRAME_PTR typedef.
778 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
779 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
780 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
781 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
782 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
783 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
784 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
785 All related users changed.
786
a104f656
SM
7872013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
788
789 * eval.c (default_toplevel_binding): New function.
790 (Fdefvar): Use it.
791 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
792 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
793 (syms_of_eval): Export them.
794 * data.c (Fdefault_value): Micro cleanup.
795 * term.c (init_tty): Use "false".
796
4b5c9326
DA
7972013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
798
799 Fix X GC leak in GTK and raw (no toolkit) X ports.
800 * xterm.c (x_free_frame_resources): If white and black relief
801 GCs are allocated, always free them here.
802 * xfns.c (x_make_gc): Omit redundant initialization.
803 * widget.c (create_frame_gcs): Remove the leftover.
804 (EmacsFrameDestroy): Do nothing because all GCs are now freed
805 in x_free_frame_resources.
806
b19aa636
JD
8072013-08-02 Jan Djärv <jan.h.d@swipnet.se>
808
809 * nsterm.m (windowWillResize:toSize:): Only change title if
810 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
811 modifying it.
812 (viewDidEndLiveResize): New method.
813
814 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
815 inside NS_IMPL_COCOA.
816
af1f7e06
DA
8172013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
818
819 * insdel.c (adjust_after_replace, replace_range, del_range_2):
820 Do not check whether undo is enabled because record_insert and
821 record_delete does that themselves.
822
65b02bb9
DA
8232013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
824
825 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
826 member which is not really used any more.
827 (FRAME_XIC_BASE_FONTNAME): Remove.
828 * xfns.c (xic_free_fontset): Adjust user.
829 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
830 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
831 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
832 (xdialog_show): Use eassert for debugging check.
7ee0f047 833 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 834
6318cde0
PE
8352013-08-01 Paul Eggert <eggert@cs.ucla.edu>
836
837 * fileio.c, fns.c (merge): Move extern decl from here ...
838 * lisp.h (merge): ... to here.
839
6c1a09ba
DA
8402013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
841
842 Fix last font-related change.
843 * w32font.h (w32font_list_internal, w32font_match_internal):
844 Fix prototype.
845 * w32uniscribe.c (uniscribe_list, uniscribe_match):
846 (uniscribe_list_family): Adjust to match font API change.
847 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
848 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
849
f8c20208
DA
8502013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
851
852 * frame.h (FRAME_MOUSE_UPDATE):
853 * nsterm.m (ns_frame_up_to_date): Omit redundant check
854 whether hlinfo->mouse_face_mouse_frame is non-NULL.
855
fdb396e2
DA
8562013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
857
858 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
859 * font.h (struct font_driver): Change list, match, and list_family
860 functions to accept struct frame * as first arg.
861 * font.c (font_score, font_compare, font_sort_entities): Remove
862 prototypes.
863 (font_sort_entities, font_list_entities, font_select_entity):
864 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
865 match font API change.
866 * xfont.c (xfont_list, xfont_match, xfont_list_family):
867 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
868 * ftxfont.c (ftxfont_list, ftxfont_match):
869 * xftfont.c (xftfont_list, xftfont_match):
870 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
871 * w32font.c (w32font_list, w32font_match, w32font_list):
872 (w32font_list_internal, w32_font_match_internal): Likewise.
873 * xfaces.c (Fx_family_fonts): Adjust user.
874
52b8a085
DA
8752013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
876
877 Do not use pure Xism x_wm_set_icon_position in non-X ports.
878 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
879 only if HAVE_X_WINDOWS is in use.
880 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
881 * nsterm.m (x_wm_set_icon_position): Remove no-op.
882 * w32term.c (x_wm_set_icon_position): Likewise.
883 * w32fns.c (x_icon): Adjust user.
884
c791c18e
DA
8852013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
886
887 * xterm.c (last_mouse_press_frame): Remove the
888 leftover which is not really used any more.
889 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
890 (x_flush): Call XFlush once per each X display, not frame.
891 This is better because this code always unconditionally skips
892 non-X frames in Vframe_list and issues the only XFlush if we
893 have more than one X frame on the same X display.
2f935d86
DA
894 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
895 Use bool for booleans.
896 (x_draw_glyph_string_background, cvt_string_to_pixel):
897 (cvt_pixel_dtor): Drop unnecessary prototypes.
898 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 899
f435830e
DA
9002013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
901
902 Drop unnecessary functions that deals with frame pixel size.
903 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
904 (x_pixel_height): Drop prototypes.
905 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
906 (x_pixel_height): Drop implementations.
907 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
908 which should be always valid for window frame.
909 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
910 * w32menu.c (Fx_popup_dialog):
911 * xmenu.c (Fx_popup_dialog): Likewise for both.
912
84231434
DA
9132013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
914
915 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
916 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
917 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
918 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
919 and mention nil frame in docstring.
84231434 920
959067a1
DA
9212013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
922
923 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
924 (x_figure_window_size): Likewise. Adjust to return long.
925 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
926 (toplevel): Move Qterminal_live_p to...
927 * terminal.c (toplevel): ...here, make it static, and...
928 (syms_of_terminal): ...DEFSYM here.
929 * frame.h (Qterminal_live_p): Remove declaration.
930 (make_frame, x_figure_window_size): Adjust prototype.
931 * nsfns.m (Fx_create_frame): Use long for window flags.
932
f4b169ce
PE
9332013-07-30 Paul Eggert <eggert@cs.ucla.edu>
934
935 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
936 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
937 Do not assume that emacs_close (INT_MAX) is a no-op.
938
bee6a2c7
DA
9392013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
940
941 * xfaces.c (make_face_cache): For struct face_cache, prefer
942 xmalloc to xzalloc and so avoid redundant call to memset.
943 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
944
d7e6881a
DA
9452013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
946
947 * fringe.c (draw_window_fringes, update_window_fringes)
948 (compute_fringe_widths):
949 * w32term.c (x_draw_glyph_string):
950 * window.c (candidate_window_p, Frecenter):
951 * xfaces.c (realize_basic_faces, realize_default_face)
952 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
953 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
954 * xfns.c (x_set_cursor_color, xic_free_xfontset):
955 * xmenu.c (Fx_menu_bar_open_internal):
956 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
957 * xsettings.c (xft_settings_event):
958 * xterm.c (x_draw_glyph_string, x_had_errors_p):
959 Use bool for booleans. Adjust style and comments where
960 appropriate.
961 * dispextern.h (draw_window_fringes, update_window_fringes)
962 (compute_fringe_widths):
963 * xterm.h (x_had_errors_p): Adjust prototype.
964
ec3058af
DA
9652013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
966
967 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
968 CHECK_LIST. Rewrite the loop to avoid useless local variable.
969
218e0637
DA
9702013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
971
972 * fns.c (toplevel): Remove comment before Fsafe_length because
973 it checks for QUIT.
974
e560aba9
PE
9752013-07-28 Paul Eggert <eggert@cs.ucla.edu>
976
977 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
978
2e5ce5de
EZ
9792013-07-28 Eli Zaretskii <eliz@gnu.org>
980
981 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
982 frame which got the message is still alive, before dereferencing
983 its pointer. (Bug#14970)
984
985 * frame.c (delete_frame): Test "this" frame's minibuffer window to
986 be a live window, before using it as such. (Bug#14970)
987
e95da6d3
EZ
9882013-07-27 Eli Zaretskii <eliz@gnu.org>
989
990 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
991 w32_detect_focus_change instead of doing part of its job by hand.
992 This fixes the problem whereby FOCUS_OUT events were not sent to
993 the event queue.
994
a8f93651
EZ
9952013-07-26 Eli Zaretskii <eliz@gnu.org>
996
fec92060
EZ
997 * process.c (Fprocess_list): Doc fix.
998
a8f93651
EZ
999 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1000 being re-exposed only if it didn't ask to become visible.
1001 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1002 was previously iconified. (Bug#14841)
1003 (x_iconify_frame): Mark the frame iconified.
1004
d5a7a9d9
PE
10052013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 Fix minor problems found by static checking.
1008 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1009 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1010
56ea7291
SM
10112013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1012
1013 * eval.c (set_specpdl_old_value): New function.
1014 (unbind_to): Minor simplification.
1015 (get_backtrace_frame): New function.
1016 (Fbacktrace_frame): Use it. Add `base' argument.
1017 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1018 (syms_of_eval): Export backtrace-eval.
1019 * xterm.c (x_focus_changed): Simplify.
1020
9d611ffe
PE
10212013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1024
999c74e3
EZ
10252013-07-24 Eli Zaretskii <eliz@gnu.org>
1026
1027 * xdisp.c (redisplay_window): Instead of moving point out of
1028 scroll margin, reject the force_start method, and try scrolling
1029 instead. (Bug#14780)
1030
198fa217
KB
10312013-07-24 Ken Brown <kbrown@cornell.edu>
1032
1033 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1034 (Bug#14944).
1035
53840e55
PE
10362013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 * eval.c (Fprogn): Do not check that BODY is a proper list.
1039 This undoes the previous change. The check slows down the
1040 interpreter, and is not needed to prevent a crash. See
1041 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1042
60967f56
GM
10432013-07-23 Glenn Morris <rgm@gnu.org>
1044
1045 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1046
9ca960e2
PE
10472013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1048
a29c3e6d
PE
1049 Port to GNU/Linux systems with tinfo but not ncurses.
1050 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1051 to decide whether ncurses is being used. Without this change,
1052 GCC complains about tgetent not being declared, on a system
1053 that has tinfo installed but ncurses not installed.
1054
f274311c
PE
1055 * eval.c (Fprogn): Check that BODY is a proper list.
1056
16b0520a
PE
1057 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1058 * data.c (Fsetq_default):
1059 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1060 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1061 (Fcondition_case):
1062 Tune by taking advantage of the fact that ARGS is always a list
1063 when a function is declared to have UNEVALLED args.
1064
9ca960e2
PE
1065 * emacsgtkfixed.c: Port to GCC 4.6.
1066 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1067
afacaa1b
JB
10682013-07-23 Juanma Barranquero <lekktu@gmail.com>
1069
1070 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1071 here to silence compiler warnings.
1072
368a85a4
PE
10732013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1076 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1077 from messing up Emacs's 'struct frame' (Bug#14923).
1078
f4e891b5
PE
10792013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 * alloc.c (make_save_ptr_ptr): Define this function.
1082 It was inadvertently omitted. It's needed only if
1083 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1084
96c8b65e
JD
10852013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1086
1087 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1088 frame have focus (Bug#14895).
1089
ee010797
PE
10902013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 Avoid vfork-related deadlock more cleanly.
1093 * callproc.c (child_setup): When the child's exec fails, output
1094 the program name, as that's more useful. Use O_NONBLOCK to avoid
1095 deadlock.
1096 * process.c (create_process_1): Remove; no longer needed.
1097 (create_process): Remove timer hack; no longer needed, now that
1098 the child avoids deadlock.
1099
f0398ec1 11002013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1101
1102 * image.c (Fimage_flush): Fix doc typo.
1103
b2a069c2
PE
11042013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1105
6496aec9
PE
1106 Fix array bounds violation when pty allocation fails.
1107 * process.c (PTY_NAME_SIZE): New constant.
1108 (pty_name): Remove static variable; it's now auto.
1109 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1110 Take pty_name as an arg rather than using a static variable.
1111 All callers changed.
1112 (create_process): Recover pty_flag from process, not from volatile local.
1113 (create_pty): Stay inside array even when pty allocation fails.
1114 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1115
b2a069c2
PE
1116 * lread.c (Fload): Avoid initialization only when lint checking.
1117 Mention that it's needed only for older GCCs.
1118
99107004
KH
11192013-07-20 Kenichi Handa <handa@gnu.org>
1120
1121 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1122 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1123
6b1b199d
AS
11242013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1125
1126 * lread.c (Fload): Avoid uninitialized warning.
1127
4195afc3
PE
11282013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1129
3f5bef16
PE
1130 Fix some minor file descriptor leaks and related glitches.
1131 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1132 (create_lock_file): Use write, not emacs_write.
1133 * image.c (slurp_file, png_load_body):
1134 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1135 (server_accept_connection):
1136 Don't leak an fd on memory allocation failure.
1137 * image.c (slurp_file): Add a cheap heuristic for growing files.
1138 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1139 as that's what the other routines do. Maybe input need not be
1140 blocked at all, but it's better to be consistent.
1141 Avoid undefined behavior when strlen is zero.
1142
4195afc3
PE
1143 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1144 (NSTATICS): Now a constant; doesn't need to be a macro.
1145
a1aeeffe
RS
11462013-07-19 Richard Stallman <rms@gnu.org>
1147
1148 * coding.c (decode_coding_utf_8): Add simple loop for fast
1149 processing of ASCII characters.
1150
63b34baa
PE
11512013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1152
1153 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1154
621dd9ac
EZ
11552013-07-19 Eli Zaretskii <eliz@gnu.org>
1156
1157 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1158 unportable 'struct x_display_info'.
1159 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1160 is a portable type.
1161
1396ac86
PE
11622013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1163
ab9980cd
PE
1164 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1165 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1166 or fscanf fails.
1167 (system_process_attributes): Prefer plain char to unsigned char
1168 when either will do. Clean up properly if interrupted or if
1169 memory allocations fail. Don't assume sscanf succeeds. Remove
1170 no-longer-needed workaround to stop GCC from whining. Read
1171 command-line once, instead of multiple times. Check read status a
1172 bit more carefully.
1173
1396ac86
PE
1174 Fix obscure porting bug with varargs functions.
1175 The code assumed that int is treated like ptrdiff_t in a vararg
1176 function, which is not a portable assumption. There was a similar
1177 -- though these days less likely -- porting problem with various
1178 assumptions that pointers of different types all smell the same as
1179 far as vararg functions is conserved. To make this problem less
1180 likely in the future, redo the API to use varargs functions.
1181 * alloc.c (make_save_value): Remove this vararg function.
1182 All uses changed to ...
1183 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1184 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1185 New functions.
1186 (make_save_ptr): Rename from make_save_pointer, for consistency with
1187 the above. Define only on platforms that need it. All uses changed.
1188
4d19d194
PE
11892013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 * keyboard.c: Try to fix typos in previous change.
1192 (DISPLAY_LIST_INFO): New macro.
1193 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1194 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1195
945c5bb1
JB
11962013-07-18 Juanma Barranquero <lekktu@gmail.com>
1197
1198 * keyboard.c (kbd_buffer_get_event):
1199 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1200 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1201
f4b1eb36
PE
12022013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1203
5e679a2c
PE
1204 * filelock.c: Fix unlikely file descriptor leaks.
1205 (get_boot_time_1): Rework to avoid using emacs_open.
1206 This doesn't actually fix a leak, but is better anyway.
1207 (read_lock_data): Use read, not emacs_read.
1208
a8cd4836
PE
1209 * doc.c: Fix minor memory and file descriptor leaks.
1210 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1211 (get_doc_string, Fsnarf_documentation):
1212 Fix file descriptor leak on error.
1213
ef30e638
PE
1214 * term.c: Fix minor fdopen-related file descriptor leaks.
1215 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1216 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1217
f4b1eb36
PE
1218 * charset.c: Fix file descriptor leaks and errno issues.
1219 Include <errno.h>.
1220 (load_charset_map_from_file): Don't leak file descriptor on error.
1221 Use plain record_xmalloc since the allocation is larger than
1222 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1223 of entries.
1224 * eval.c (record_unwind_protect_nothing):
1225 * fileio.c (fclose_unwind):
1226 New functions.
1227 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1228 The replacement doesn't block input, but that no longer seems
1229 necessary.
1230
b648c163
PE
12312013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1232
a0931322
PE
1233 * lread.c: Fix file descriptor leaks and errno issues.
1234 (Fload): Close some races that leaked fds or streams when 'load'
1235 was interrupted.
1236 (Fload, openp): Report error number of last nontrivial failure to open.
1237 ENOENT counts as trivial.
1238 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1239 New functions.
1240 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1241 now that the function is always called with a nonnegative arg.
1242 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1243 All uses replaced with ...
1244 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1245
b648c163
PE
1246 A few more minor file errno-reporting bugs.
1247 * callproc.c (Fcall_process):
1248 * doc.c (Fsnarf_documentation):
1249 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1250 * process.c (set_socket_option):
1251 Don't let a constructor trash errno.
1252 * doc.c: Include <errno.h>.
1253
b1dc4084
JB
12542013-07-16 Juanma Barranquero <lekktu@gmail.com>
1255
1256 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1257
c43843aa
PE
12582013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1259
50a30cce
PE
1260 Fix w32 bug with call-process-region (Bug#14885).
1261 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1262 to Fcall_process when the input is empty. This simplifies the
1263 code a bit. It makes no difference on POSIXish platforms but
1264 apparently it fixes a bug on w32.
1265
44e18199 1266 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1267 * fileio.c (close_file_unwind): Don't close if FD is negative;
1268 this can happen when unwinding a zapped file descriptor.
1269 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1270 in case Emacs runs out of memory between the two unwind-protects.
1271 Don't trash errno when closing FD.
1272 Zap the FD in the specpdl when closing it, instead of deferring
1273 the removal of the unwind-protect; this fixes a bug where a child
1274 function unwinds the stack past us.
1275
27e498e6
PE
1276 New unwind-protect flavors to better type-check C callbacks.
1277 This also lessens the need to write wrappers for callbacks,
1278 and the need for make_save_pointer.
1279 * alloca.c (free_save_value):
1280 * atimer.c (run_all_atimers):
1281 Now extern.
1282 * alloc.c (safe_alloca_unwind):
1283 * atimer.c (unwind_stop_other_atimers):
1284 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1285 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1286 * minibuf.c (choose_minibuf_frame_1):
1287 * process.c (make_serial_process_unwind):
1288 * xdisp.h (pop_message_unwind):
1289 * xselect.c (queue_selection_requests_unwind):
1290 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1291 * alloca.c (record_xmalloc):
1292 Prefer record_unwind_protect_ptr to record_unwind_protect with
1293 make_save_pointer.
1294 * alloca.c (Fgarbage_collect):
1295 Prefer record_unwind_protect_void to passing a dummy.
1296 * buffer.c (restore_buffer):
1297 * window.c (restore_window_configuration):
1298 * xfns.c, w32fns.c (do_unwind_create_frame)
1299 New wrapper. All record-unwind uses of wrappee changed.
1300 * buffer.c (set_buffer_if_live):
1301 * callproc.c (call_process_cleanup, delete_temp_file):
1302 * coding.c (code_conversion_restore):
1303 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1304 * editfns.c (save_excursion_restore)
1305 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1306 (save_restriction_restore):
1307 * eval.c (restore_stack_limits, un_autoload):
1308 * fns.c (require_unwind):
1309 * keyboard.c (recursive_edit_unwind, tracking_off):
1310 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1311 * macros.c (pop_kbd_macro, restore_menu_items):
1312 * nsfns.m (unwind_create_frame):
1313 * print.c (print_unwind):
1314 * process.c (start_process_unwind):
1315 * search.c (unwind_set_match_data):
1316 * window.c (select_window_norecord, select_frame_norecord):
1317 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1318 (fast_set_selected_frame):
1319 * xfns.c, w32fns.c (unwind_create_tip_frame):
1320 Return void, not a dummy Lisp_Object. All uses changed.
1321 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1322 * callproc.c (call_process_kill):
1323 * fileio.c (restore_point_unwind, decide_coding_unwind)
1324 (build_annotations_unwind):
1325 * insdel.c (Fcombine_after_change_execute_1):
1326 * keyboard.c (read_char_help_form_unwind):
1327 * menu.c (unuse_menu_items):
1328 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1329 * sound.c (sound_cleanup):
1330 * xdisp.c (unwind_redisplay):
1331 * xfns.c (clean_up_dialog):
1332 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1333 Accept no args and return void, instead of accepting and returning
1334 a dummy Lisp_Object. All uses changed.
1335 * cygw32.c (fchdir_unwind):
1336 * fileio.c (close_file_unwind):
1337 * keyboard.c (restore_kboard_configuration):
1338 * lread.c (readevalllop_1):
1339 * process.c (wait_reading_process_output_unwind):
1340 Accept int and return void, rather than accepting an Emacs integer
1341 and returning a dummy object. In some cases this fixes an
1342 unlikely bug when the corresponding int is outside Emacs integer
1343 range. All uses changed.
1344 * dired.c (directory_files_internal_unwind):
1345 * fileio.c (do_auto_save_unwind):
1346 * gtkutil.c (pop_down_dialog):
1347 * insdel.c (reset_var_on_error):
1348 * lread.c (load_unwind):
1349 * xfns.c (clean_up_file_dialog):
1350 * xmenu.c, nsmenu.m (pop_down_menu):
1351 * xmenu.c (cleanup_widget_value_tree):
1352 * xselect.c (wait_for_property_change_unwind):
1353 Accept pointer and return void, rather than accepting an Emacs
1354 save value encapsulating the pointer and returning a dummy object.
1355 All uses changed.
1356 * editfns.c (Fformat): Update the saved pointer directly via
1357 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1358 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1359 (unwind_body): New function.
1360 (record_unwind_protect): First arg is now a function returning void,
1361 not a dummy Lisp_Object.
1362 (record_unwind_protect_ptr, record_unwind_protect_int)
1363 (record_unwind_protect_void): New functions.
1364 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1365 * fileio.c (struct auto_save_unwind): New type.
1366 (do_auto_save_unwind): Use it.
1367 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1368 * insdel.c (struct rvoe_arg): New type.
1369 (reset_var_on_error): Use it.
1370 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1371 New constants.
1372 (specbinding_func): Remove; there are now several such functions.
1373 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1374 (set_unwind_protect_ptr): New function.
1375 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1376
4e604a5d
PE
1377 Be simpler and more consistent about reporting I/O errors.
1378 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1379 Say "Read error" and "Write error", rather than "I/O error", or
1380 "IO error reading", or "IO error writing", when a read or write
1381 error occurs.
1382 * process.c (Fmake_network_process, wait_reading_process_output)
1383 (send_process, Fprocess_send_eof, wait_reading_process_output):
1384 Capitalize diagnostics consistently. Put "failed foo" at the
1385 start of the diagnostic, so that we don't capitalize the
1386 function name "foo". Consistently say "failed" for such
1387 diagnostics.
1388 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1389 All callers changed. This is so it can use report_file_error.
1390 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1391 diagnostics consistently as above.
1392
a9757f6a
PE
1393 * fileio.c (report_file_errno): Fix errno reporting bug.
1394 If the file name is neither null nor a pair, package it up as a
1395 singleton list. All callers changed, both to this function and to
1396 report_file_error. This fixes a bug where the memory allocator
1397 invoked by list1 set errno so that the immediately following
1398 report_file_error reported the wrong errno value.
1399
c43843aa
PE
1400 Fix minor problems found by --enable-gcc-warnings.
1401 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1402 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1403
18c26d81
JD
14042013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1405
1406 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1407 Set event->arg to Qt if switch-event shall be generated.
1408 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1409
1410 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1411
1412 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1413 FOCUS_OUT_EVENT.
1414
1415 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1416 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1417 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1418 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1419 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1420 and there is a focused frame.
1421 (head_table): Add focus-in and focus-out.
1422 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1423 bind to handle-focus-in/out.
1424
1425 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1426 (Fhandle_switch_frame): Call Fhandle_focus_in.
1427 (syms_of_frame): defsubr handle-focus-in/out.
1428
6c6f1994
PE
14292013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1430
c7ddc792
PE
1431 Fix porting bug to older POSIXish platforms (Bug#14862).
1432 * sysdep.c (emacs_pipe): New function, that implements
1433 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1434 This should port better to CentOS 5 and to Mac OS X 10.6.
1435 All calls to pipe2 changed.
1436
6c6f1994
PE
1437 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1438 This makes the code easier to read and the executable a bit smaller.
1439 Do not replace all calls to Fcons that happen to create lists,
1440 just calls that are intended to create lists. For example, when
1441 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1442 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1443 Similarly for list2 through list5.
1444 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1445 * bytecode.c (exec_byte_code):
1446 * callint.c (quotify_arg, Fcall_interactively):
1447 * callproc.c (Fcall_process, create_temp_file):
1448 * charset.c (load_charset_map_from_file)
1449 (Fdefine_charset_internal, init_charset):
1450 * coding.c (get_translation_table, detect_coding_system)
1451 (Fcheck_coding_systems_region)
1452 (Fset_terminal_coding_system_internal)
1453 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1454 * composite.c (update_compositions, Ffind_composition_internal):
1455 * dired.c (directory_files_internal, file_name_completion)
1456 (Fsystem_users):
1457 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1458 * doc.c (Fsnarf_documentation):
1459 * editfns.c (Fmessage_box):
1460 * emacs.c (main):
1461 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1462 (Feval, eval_sub, Ffuncall, apply_lambda):
1463 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1464 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1465 (Fset_file_times, Finsert_file_contents)
1466 (Fchoose_write_coding_system, Fwrite_region):
1467 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1468 * font.c (font_registry_charsets, font_parse_fcname)
1469 (font_prepare_cache, font_update_drivers, Flist_fonts):
1470 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1471 * frame.c (make_frame, Fmake_terminal_frame)
1472 (x_set_frame_parameters, x_report_frame_params)
1473 (x_default_parameter, Fx_parse_geometry):
1474 * ftfont.c (syms_of_ftfont):
1475 * image.c (gif_load):
1476 * keyboard.c (command_loop_1):
1477 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1478 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1479 (Fminor_mode_key_binding, accessible_keymaps_1)
1480 (Faccessible_keymaps, Fwhere_is_internal):
1481 * lread.c (read_emacs_mule_char):
1482 * menu.c (find_and_return_menu_selection):
1483 * minibuf.c (get_minibuffer):
1484 * nsfns.m (Fns_perform_service):
1485 * nsfont.m (ns_script_to_charset):
1486 * nsmenu.m (ns_popup_dialog):
1487 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1488 (Fx_own_selection_internal):
1489 * nsterm.m (append2):
1490 * print.c (Fredirect_debugging_output)
1491 (print_prune_string_charset):
1492 * process.c (Fdelete_process, Fprocess_contact)
1493 (Fformat_network_address, set_socket_option)
1494 (read_and_dispose_of_process_output, write_queue_push)
1495 (send_process, exec_sentinel):
1496 * sound.c (Fplay_sound_internal):
1497 * textprop.c (validate_plist, add_properties)
1498 (Fput_text_property, Fadd_face_text_property)
1499 (copy_text_properties, text_property_list, syms_of_textprop):
1500 * unexaix.c (report_error):
1501 * unexcoff.c (report_error):
1502 * unexsol.c (unexec):
1503 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1504 (Fformat_mode_line, syms_of_xdisp):
1505 * xfaces.c (set_font_frame_param)
1506 (Finternal_lisp_face_attribute_values)
1507 (Finternal_merge_in_global_face, syms_of_xfaces):
1508 * xfns.c (x_default_scroll_bar_color_parameter)
1509 (x_default_font_parameter, x_create_tip_frame):
1510 * xfont.c (xfont_supported_scripts):
1511 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1512 (menu_help_callback, xmenu_show):
1513 * xml.c (make_dom):
1514 * xterm.c (set_wm_state):
1515 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1516 and similarly for list2 through list5.
1517
bafe80ce
PE
15182013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 * callproc.c (Fcall_process_region): Fix minor race and tune.
1521 (create_temp_file): New function, with the temp-file-creation part
1522 of the old Fcall_process_region. Use Fcopy_sequence to create the
1523 temp file name, rather than alloca + build_string, for simplicity.
1524 Don't bother to block input around the temp file creation;
1525 shouldn't be needed. Simplify use of mktemp. Use
1526 record_unwind_protect immediately after creating the temp file;
1527 this closes an unlikely race where the temp file was not removed.
1528 Use memcpy rather than an open-coded loop.
1529 (Fcall_process_region): Use the new function. If the input is
1530 empty, redirect from /dev/null rather than from a newly created
1531 empty temp file; this avoids unnecessary file system traffic.
1532
4700b5a5
PE
15332013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1534
5c97beae
PE
1535 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1536 Simplify by making this case like the other two. This is a bit
1537 slower on obsolete hosts, but the extra complexity isn't worth it.
1538
4700b5a5
PE
1539 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1540 * process.c (create_process) [!DOS_NT]:
1541 Remove now-unnecessary calls to emacs_close.
1542
f9a74c4c
EZ
15432013-07-13 Eli Zaretskii <eliz@gnu.org>
1544
922ae7ee
EZ
1545 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1546 returning early. (Bug#14850)
1547
f9a74c4c
EZ
1548 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1549 and inhibit-iso-escape-detection attributes of 'undecided'.
1550 (Bug#14822)
1551
5e301d76
PE
15522013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1553
69e0e5ee
PE
1554 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1555 Reported by Herbert J. Skuhra in
1556 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1557
5e301d76
PE
1558 Don't lose top specpdl entry when memory is exhausted.
1559 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1560 specpdl overflow here, to simplify callers; all callers changed.
1561 Always reserve an unused entry at the stack top; this avoids
1562 losing the top entry's information when memory is exhausted.
1563
7e649856
PE
15642013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1565
a773ed9a
PE
1566 Clean up errno reporting and fix some errno-reporting bugs.
1567 * callproc.c (Fcall_process):
1568 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1569 * process.c (create_process, Fmake_network_process):
1570 * unexaix.c (report_error):
1571 * unexcoff.c (report_error):
1572 Be more careful about reporting the errno of failed operations.
1573 The code previously reported the wrong errno sometimes.
1574 Also, prefer report_file_errno to setting errno + report_file_error.
1575 (Fcall_process): Look at openp return value rather than at path,
1576 as that's a bit faster and clearer when there's a numeric predicate.
1577 * fileio.c (report_file_errno): New function, with most of the
1578 old contents of report_file_error.
1579 (report_file_error): Use it.
1580 (Ffile_exists_p, Ffile_accessible_directory_p):
1581 Set errno to 0 when it is junk.
1582 * fileio.c (Faccess_file):
1583 * image.c (x_create_bitmap_from_file):
1584 Use faccessat rather than opening the file, to avoid the hassle of
1585 having a file descriptor open.
1586 * lisp.h (report_file_errno): New decl.
1587 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1588
7e649856
PE
1589 Minor EBADF fixes.
1590 * process.c (create_process, wait_reading_process_output) [AIX]:
1591 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1592 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1593 a multithreaded environment anyway).
1594 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1595
f6774c1a
AS
15962013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1597
1598 * image.c (x_find_image_file): Don't close a remote file handle.
1599
bacba3c2
PE
16002013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 Fix races with threads and file descriptors.
1603 * callproc.c (Fcall_process_region):
1604 * dired.c (open_directory):
1605 * emacs.c (main, Fdaemon_initialized):
1606 * image.c (x_find_image_file):
1607 * inotify.c (Finotify_rm_watch):
1608 * lread.c (Flocate_file_internal):
1609 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1610 * term.c (term_mouse_moveto, init_tty):
1611 * termcap.c (tgetent):
1612 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1613 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1614 * unexhp9k800.c, unexmacosx.c (unexec):
1615 * callproc.c (Fcall_process_region):
1616 Use emacs_close, not close.
1617 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1618 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1619 and posix_close function on current platforms (which all lack them).
1620 (emacs_close): Use it. This should fix the races on GNU/Linux and
1621 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1622 and it should avoid closing random victim file descriptors on
1623 other platforms.
1624
653d4f43
PE
16252013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1626
c8536ec4
PE
1627 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1628 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1629 Touch up doc a bit.
1630
9c203066
PE
1631 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1632 This is for .gdbinit xbacktrace.
1633
653d4f43
PE
1634 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1635 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1636 (emacs_set_tty): Now static.
1637 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1638 * term.c (tty_capable_p, tty_default_color_capabilities)
1639 (get_tty_terminal, term_mouse_movement)
1640 (handle_one_term_event, init_tty, maybe_fatal):
1641 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1642 (tgetent, scan_file, name_match, compare_contin):
1643 * terminal.c (get_terminal):
1644 Use bool for boolean.
1645 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1646 Prefer char to unsigned char if either will do.
1647 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1648 (tty_write_glyphs): Prefer int to unsigned.
1649 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1650 All callers changed.
1651 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1652
45b683a1
PE
16532013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1654
29abe551
PE
1655 Port to C89.
1656 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1657 (B__dummy__): New dummy symbol, to pacify C89.
1658 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1659 they can't grok varargs macros.
1660 * dispnew.c (add_window_display_history)
1661 (add_frame_display_history):
1662 * print.c (print_object):
1663 * xdisp.c (debug_method_add):
1664 Use %p printf format only for void pointers.
1665 * emacs.c (usage_message): New constant, replacing ...
1666 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1667 (main): Adjust to usage reorg.
1668 * fns.c (syms_of_fns):
1669 * profiler.c (syms_of_profiler):
1670 Don't use non-constant struct initializers.
1671 * gnutls.h (gnutls_initstage_t):
1672 * lisp.h (enum Lisp_Fwd_Type):
1673 * lread.c (lisp_file_lexically_bound_p):
1674 * xsettings.c (anonymous enum):
1675 Remove trailing comma.
1676 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1677 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1678 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1679 (DEFUN): Use it.
1680 * regex.c (const_re_char): New type, to pacify strict C89.
1681 All uses of 'const re_char' replaced to use it.
1682 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1683 with glibc when strict C89. This change is imported from gnulib.
1684 All uses changed.
1685 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1686 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1687 Omit GNU_LINUX implementation, since it requires long long.
1688 * xterm.c (x_draw_underwave):
1689 Do not assume the traditional order of struct's members.
1690 (x_term_init): Rewrite to avoid the need for non-constant structure
1691 initializers.
1692
45b683a1 1693 Syntax cleanup, mostly replacing macros with functions.
763a086d 1694 This removes the need for the syntax_temp hack.
45b683a1
PE
1695 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1696 * syntax.c (SYNTAX_INLINE): New macro.
1697 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1698 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1699 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1700 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1701 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1702 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1703 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1704 Now constants, not macros.
1705 (syntax_temp) [!__GNUC__]: Remove.
1706 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1707 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1708 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1709 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1710 Move here from syntax.h; now functions, not macros. Except for the
1711 last function, these are static since only syntax.c uses them.
1712 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1713 All uses changed. Now a function, not a macro; use this fact
1714 to simplify the code.
1715 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1716 compiler bugs; no longer relevant.
1717 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1718 (SYNTAX_INLINE): New macro.
1719 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1720 for the new functions. Use bool for boolean member.
1721 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1722 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1723 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1724 (SETUP_BUFFER_SYNTAX_TABLE):
1725 Now extern inline functions, not macros.
1726 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1727 Remove; all uses replaced by implementation.
1728 (syntax_temp) [!__GNUC__]: Remove decl.
1729 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1730
29be4a50
JD
17312013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1732
1733 * emacs.c (main): Fix syntax error.
1734
954b166e
PE
17352013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 Timestamp fixes for undo (Bug#14824).
1738 * atimer.c (schedule_atimer):
1739 * fileio.c (Ffile_newer_than_file_p):
1740 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1741 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1742 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1743 (syms_of_fileio): Remove Sclear_visited_file_name.
1744 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1745 file doesn't exist; this avoids an ambiguity with negative timestamps.
1746 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1747 * systime.h (make_emacs_time, invalid_emacs_time):
1748 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1749 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1750 * undo.c (record_first_change): Push (visited-file-modtime) onto
1751 undo list rather than reimplementing it by hand, incorrectly.
1752
d74647c3
KB
17532013-07-09 Ken Brown <kbrown@cornell.edu>
1754
1755 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1756
3c51b96b
JB
17572013-07-09 Juanma Barranquero <lekktu@gmail.com>
1758
1759 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1760
4ebbdd67
PE
17612013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 Handle errno and exit status a bit more carefully.
1764 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1765 number into an exit status. Instead, use EXIT_CANCELED.
1766 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1767 * callproc.c (relocate_fd):
1768 * emacs.c (close_output_streams, main):
1769 * process.c (create_process):
1770 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1771 Use emacs_perror for simplicity.
1772 * callproc.c (relocate_fd, main):
1773 * sysdep.c (sys_subshell):
1774 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1775 (shut_down_emacs): Use emacs_write, not write.
1776 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1777 * fileio.c (Fcopy_file, e_write):
1778 * nsterm.m (ns_select):
1779 * process.c (send_process):
1780 * sound.c (vox_write):
1781 Use emacs_write_sig, not emacs_write.
1782 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1783 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1784 New constants.
1785 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1786 of write.
1787 (emacs_full_write): New function.
1788 (emacs_write): Rewrite to use it.
1789 (emacswrite_sig, emacs_perror): New functions.
1790 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1791
44e18199 17922013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1793
1794 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1795 on NS even if it is present. Pixmap on NS is a void*.
1796
9caab067
PE
17972013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 Port to Ubuntu 10 (Bug#14803).
1800 Problem reported by T.V. Raman.
1801 * process.c (close_on_exec, accept4, process_socket):
1802 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1803
1d442672
EZ
18042013-07-07 Eli Zaretskii <eliz@gnu.org>
1805
1806 * w32.c (sys_dup): Declare prototype.
1807
1808 * filelock.c:
1809 * emacs.c:
1810 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1811
067428c1
PE
18122013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1813
1814 Make file descriptors close-on-exec when possible (Bug#14803).
1815 This simplifies Emacs a bit, since it no longer needs to worry
1816 about closing file descriptors by hand in some cases.
1817 It also fixes some unlikely races. Not all such races, as
1818 libraries often open files internally without setting
1819 close-on-exec, but it's an improvement.
1820 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1821 * callproc.c (Fcall_process) [!MSDOS]:
1822 * emacs.c (main) [!DOS_NT]:
1823 * nsterm.m (ns_term_init):
1824 * process.c (create_process):
1825 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1826 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1827 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1828 Prefer mkostemp with O_CLOEXEC to mkstemp.
1829 * callproc.c (relocate_fd) [!WINDOWSNT]:
1830 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1831 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1832 now using pipe2.
1833 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1834 Make the resulting file descriptor close-on-exec.
1835 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1836 * lread.c (load_descriptor_list, load_descriptor_unwind):
1837 Remove; no longer needed. All uses removed.
1838 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1839 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1840 New functions.
1841 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1842 (Fmake_network_process, Fnetwork_interface_list):
1843 (Fnetwork_interface_info, server_accept_connection):
1844 Make newly-created socket close-on-exec.
1845 * sysdep.c (emacs_open, emacs_fopen):
1846 Make new-created descriptor close-on-exec.
1847 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1848 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1849
0da857dd
JD
18502013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1851
1852 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1853 for NS_IMPL_GNUSTEP.
1854
5f86adcd
PE
18552013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1856
1857 Fix openp errno handling.
1858 * callproc.c (Fcall_process): Preserve openp errno around close.
1859 * lread.c (openp): Set errno when returning -1, as some callers
1860 expect this.
1861
1afb1d07
JD
18622013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1863
1864 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1865
1866 * nsterm.h (NSSavePanel): Update comment.
1867 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1868 (ns_run_file_dialog): Declare.
1869
1870 * nsfns.m: Remove panelOK.
1871 (ns_fd_data): New.
1872 (ns_run_file_dialog): New function.
1873 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1874 event loop, so file dialog is popped up by ns_run_file_dialog, called
1875 by sendEvent (Bug#14578).
1876 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1877
3323c263
EZ
18782013-07-06 Eli Zaretskii <eliz@gnu.org>
1879
fdda0220
EZ
1880 * xdisp.c (default_line_pixel_height): New function.
1881 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1882 (try_cursor_movement, redisplay_window, try_window)
1883 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1884
1885 * window.c (window_scroll_pixel_based): use
1886 default_line_pixel_height.
1887
1888 * dispextern.h (default_line_pixel_height): Add prototype.
1889
1890 * frame.c (x_set_line_spacing): Accept a float value for
1891 line-spacing parameter, per the documentation.
1892
3323c263
EZ
1893 * data.c (Fmultibyte_string_p): Doc fix.
1894
47ba6d43
PE
18952013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1896
406af475
PE
1897 Use emacs_open more consistently when opening files.
1898 This handles EINTR more consistently now, and makes it easier
1899 to introduce other uniform changes to file descriptor handling.
1900 * src/systdio.h: New file.
1901 * src/buffer.c (mmap_init):
1902 * cygw32.c (chdir_to_default_directory):
1903 * dispnew.c (Fopen_termscript):
1904 * emacs.c (Fdaemon_initialized):
1905 * fileio.c (Fdo_auto_save):
1906 * image.c (slurp_file, png_load_body, jpeg_load_body):
1907 * keyboard.c (Fopen_dribble_file):
1908 * lread.c (Fload):
1909 * print.c (Fredirect_debugging_output):
1910 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1911 * termcap.c (tgetent):
1912 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1913 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1914 * w32term.c (w32_initialize) [CYGWIN]:
1915 * xfaces.c (Fx_load_color_file):
1916 Use emacs_open instead of plain open, and emacs_fopen instead of
1917 plain fopen.
1918 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1919 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1920 * callproc.c (default_output_mode): New constant.
1921 (Fcall_process): Use it to call emacs_open instead of plain creat.
1922 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1923 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1924 (emacs_fopen): New function.
1925 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1926 Include <lisp.h>, for emacs_open.
1927 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1928
47ba6d43
PE
1929 Remove duplicate #include directives.
1930 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1931 * xfaces.c:
1932 Don't include stdio.h twice.
1933 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1934 Don't include sys/types.h or stdio.h twice.
1935 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1936 * lread.c: Don't include coding.h twice.
1937 * nsfont.m: Don't include frame.h twice.
1938 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1939 * ralloc.c: Don't include <unistd.h> twice.
1940 * xdisp.c: Don't include font.h twice.
1941 * xterm.c: Don't include fontset.h twice.
1942 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1943
b9ed53d5
PE
19442013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 Scale ImageMagick images more carefully.
1947 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1948 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1949 Be more careful about avoiding undefined behavior after
1950 integer overflow and division by zero.
1951
cf13177e
YM
19522013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1953
1954 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1955 (syms_of_w32fns): DEFSYM them.
1956 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1957 (CCHDEVICENAME): Define macros if not defined.
1958 (struct MONITOR_INFO_EX): New struct.
1959 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1960 (enum_display_monitors_fn): New variable.
1961 (globals_of_w32fns): Initialize it.
1962 (Fx_display_pixel_width, Fx_display_pixel_height)
1963 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1964 multi-monitor setups in docstrings.
1965 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1966 screen size by primary monitor's millimeter per pixel.
1967 (w32_monitor_enum, w32_display_monitor_attributes_list)
1968 (w32_display_monitor_attributes_list_fallback)
1969 (Fw32_display_monitor_attributes_list): New functions.
1970 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1971
1972 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1973 if not defined.
1974 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1975
86dfb7a8
MA
19762013-07-04 Michael Albinus <michael.albinus@gmx.de>
1977
1978 * fileio.c (Qfile_notify_error): New error symbol.
1979
1980 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1981 * inotify.c (inotify_callback, symbol_to_inotifymask)
1982 (Finotify_add_watch, Finotify_rm_watch): Use it.
1983 (inotifyevent_to_event): Exchange order of cookie and file name.
1984 (Finotify_add_watch): Adapt docstring.
1985
1986 * lisp.h (Qfile_notify_error): Declare.
1987
2c1c974b
PE
19882013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1989
1990 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1991 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1992 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1993 which did not work (see <http://bugs.gnu.org/14569#307>).
1994 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1995 && (!noninteractive || initialized)). This attempts to thread
1996 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1997
7a35b20f
JB
19982013-07-04 Juanma Barranquero <lekktu@gmail.com>
1999
2000 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2001 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2002
1ce5cd04
PE
20032013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2006 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2007 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2008 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2009
57f8c490
PE
20102013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2013 Define to __sys_siglist.
2014
bcffb5ca
EZ
20152013-07-02 Eli Zaretskii <eliz@gnu.org>
2016
2017 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2018 word-wrap, so that overflow-newline-into-fringe would work in
2019 visual-line-mode. (Bug#2749)
2020 (move_it_in_display_line_to): When the last scanned display
2021 element fits exactly on the display line, and
2022 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2023 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2024 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2025 finding buffer position that corresponds to pixel coordinates,
2026 e.g. in buffer_posn_from_coords.
2027
2c41e781
JD
20282013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2029
2030 * process.c (handle_child_signal): Call catch_child_signal if
2031 NS_IMPL_GNUSTEP.
2032
c2418359
PE
20332013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2034
52a9bcae
PE
2035 Don't convert function pointers to void * and back.
2036 It isn't portable C, and it's easy enough to avoid.
2037 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2038 (make_save_value): Add support for SAVE_FUNCPOINTER.
2039 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2040 * print.c (print_object):
2041 Distinguish function from object pointers.
2042 * lisp.h (SAVE_FUNCPOINTER): New constant.
2043 (SAVE_SLOT_BITS): Adjust to it.
2044 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2045 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2046 (voidfuncptr): New typedef.
2047 (struct Lisp_Save_Value): New member data[0].funcpointer.
2048 (XSAVE_FUNCPOINTER): New function.
2049
c2418359
PE
2050 Simplify buildobj processing.
2051 * Makefile.in (buildobj.h): Make it a sequence of strings each
2052 followed by comma, rather than a single string. Put it into a
2053 .tmp file in case there's an error while generating it.
2054 (gl-stamp): Use .tmp for temp files.
2055 (mostlyclean): Clean .tmp files.
2056 * doc.c (buildobj): Move to just the routine that needs it.
2057 It's now an array of strings, so processing is simpler.
2058
8f43ce49
PE
20592013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2060
2061 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2062 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2063 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2064 Invoke malloc_enable_thread even when not interactive.
2065 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2066 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2067 in this case, since the underlying bug has now been fixed.
2068
24827db9
JB
20692013-07-01 Juanma Barranquero <lekktu@gmail.com>
2070
2071 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2072 unlinking it (bug#14691).
2073
ef099a94
MN
20742013-06-30 Michal Nazarewicz <mina86@mina86.com>
2075
2076 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2077 before checking whether buffer is modified. This lets
2078 `kill-buffer-query-functions' cancel killing of the buffer or save
2079 its content before `kill-buffer' asks user the "Buffer %s
2080 modified; kill anyway?" question.
2081
9d3f2fc2
JD
20822013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2083
2084 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2085 Let the super performKeyEquivalent deal with them (Bug#14747).
2086
e6c6c8c7
PE
20872013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2088
1d71c1d9
PE
2089 * widget.c (resize_cb): Remove unused local.
2090
8f5f35cc
PE
2091 Do not use GTK 3 if it exists but cannot be compiled.
2092 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2093 * xterm.c (x_error_handler) [!USE_GTK]:
2094 Do not use GTK 3.
2095
e6c6c8c7
PE
2096 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2097
0ba54312
EZ
20982013-06-30 Eli Zaretskii <eliz@gnu.org>
2099
5d1c3286
EZ
2100 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2101 to the valid range of values. (Bug#14753)
2102
0ba54312
EZ
2103 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2104 when moving point by using the current glyph matrix. This avoids
2105 the need to force redisplay when this function is called in a
2106 loop.
2107
9c90cc06
PE
21082013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 Fix minor problems found by static checking.
2111 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2112 Redo the latter's body to sidestep GCC parenthesization warnings.
2113 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2114 * coding.c (detect_coding, detect_coding_system):
2115 * coding.h (struct undecided_spec):
2116 Use bool for boolean.
2117 * image.c (QCmax_width, QCmax_height): Now static.
2118 * xdisp.c (Fmove_point_visually): Remove unused local.
2119
4c672a0f
EZ
21202013-06-29 Eli Zaretskii <eliz@gnu.org>
2121
2122 * xdisp.c (Fmove_point_visually): New function.
2123
c1ea3abf
JB
21242013-06-28 Kenichi Handa <handa@gnu.org>
2125
2126 * coding.h (define_coding_undecided_arg_index): New enum.
2127 (coding_attr_index): New members
2128 coding_attr_undecided_inhibit_null_byte_detection,
2129 coding_attr_undecided_inhibit_iso_escape_detection,
2130 coding_attr_undecided_prefer_utf_8.
2131 (undecided_spec): New struct.
2132 (struct coding_system): New member `undecided' of the member
2133 `spec'.
2134
2135 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2136 (detect_coding): Likewise.
2137 (detect_coding_system): Likewise.
2138 (Fdefine_coding_system_internal): New coding system properties
2139 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2140 :prefer-utf-8.
2141 (syms_of_coding): Adjust for coding_arg_undecided_max.
2142
ba3de9e6
PE
21432013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2144
2145 * image.c (x_from_xcolors): Remove unused local.
2146
547c9269
YM
21472013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2148
2149 Defer image data transfer between X client and server until actual
2150 display happens.
2151
2152 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2153 and `mask_img'.
2154
2155 * image.c (Destroy_Image): Remove.
2156 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2157 `mask_p', and `colors_p'. All uses changed.
2158 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2159 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2160 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2161 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2162 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2163 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2164 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2165 (image_get_x_image, image_unget_x_image): New functions or macros.
2166 (image_background, image_background_transparent, x_to_xcolors)
2167 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2168 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2169 instead of Destroy_Image.
2170 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2171 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2172 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2173 (imagemagick_load_image, svg_load_image): Use them instead of
2174 x_create_x_image_and_pixmap, and x_put_x_image followed by
2175 x_destroy_x_image, respectively.
2176 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2177 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2178 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2179 background_transparent fields.
2180 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2181 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2182
dae2f5ef
PE
21832013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2184
2185 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2186 This mostly consists of undoing recent changes.
2187 * callproc.c (Fcall_process):
2188 * process.c (create_process):
2189 Do not worry about catching SIGCHLD here, undoing previous change.
2190 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2191 * process.c, process.h (catch_child_signal):
2192 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2193 * process.c (catch_child_handler): Don't worry about being called
2194 lazily and do not assume caller has blocked SIGCHLD, undoing
2195 previous change. Move first-time stuff back to
2196 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2197 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2198 set lib_child_handler if it's already initialized, which may
2199 help avoid problems on GNUStep.
2200
fa55d2aa
PE
22012013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2202
2203 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2204 * callproc.c (Fcall_process):
2205 * process.c (create_process):
2206 Make sure SIGCHLD is caught before we fork,
2207 since Emacs startup no arranges to catch SIGCHLD.
2208 * process.c (lib_child_handler): Initialize to null, not to
2209 dummy_handler.
2210 (catch_child_signal): Allow self to be called lazily.
2211 Do nothing if it's already been called.
2212 Assume caller has blocked SIGCHLD (all callers do now).
2213 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2214 just before it's really needed.
2215 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2216 since it hasn't been caught yet.
2217
f3f9606c
LMI
22182013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2219
2220 * image.c (compute_image_size): New function to implement
2221 :max-width and :max-height.
2222 (imagemagick_load_image): Use it.
2223
c7041908
PE
22242013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2225
2226 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2227 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2228 Now extern.
2229 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2230 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2231 the SIGCHLD handler, since the code is not atomic and (due to glib)
2232 signals may be arriving now.
2233 * sysdep.c (init_signals): Do not catch child signals here;
2234 'main' now does that later, at a safer time.
2235
f86852b4
PE
22362013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2237
0dfeed58
PE
2238 Clean up SIGCHLD handling a bit (Bug#14569).
2239 * process.c, process.h (catch_child_signal):
2240 Now always extern, even if !NS_IMPL_GNUSTEP.
2241 * process.c (catch_child_signal): Move glib tickler here from
2242 init_process_emacs, so that it's done earlier in Emacs
2243 initialization. Also move the noninteractive && !initialized
2244 check here from init_process_emacs. This is all a bit cleaner for
2245 GNUish platforms, and I hope it works around the Cygwin bug.
2246 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2247 that glib signal handling is tickled before glib creates threads.
2248
f86852b4
PE
2249 * process.c (wait_reading_process_output): Avoid int overflow
2250 when reading more than 2 GiB total from a process.
2251
cbd6509c
PE
22522013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2253
2254 * process.c (create_process): Handle a couple more cases,
2255 i.e., work even if new_argv and wait_child_setup[i] are cached.
2256 Use Fcall_process's style for volatile vars.
2257
9de1114a
AS
22582013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2259
2260 * process.c (create_process): Mark PROCESS volatile.
2261
fbe9e0b9
PE
22622013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2263
2264 Use C99-style flexible array members if available.
2265 This avoids some subtle aliasing issues, which typically
2266 aren't a problem with GCC but may be a problem elsewhere.
2267 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2268 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2269 In either case, it uses a flexible array member rather than
2270 the old struct hack. All uses changed.
2271 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2272 Adjust to sdata reorganization.
2273 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2274 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2275 that ports better to pre-C99 non-GCC.
2276 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2277 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2278 as the latter has changed.
2279 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2280 and port better to pre-C99 GCC.
2281 * image.c (struct xpm_cached_color):
2282 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2283 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2284 Use FLEXIBLE_ARRAY_MEMBER.
2285 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2286 Move decl to top level so it gets checked against implementation.
2287 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2288 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2289
1fc71008
PE
22902013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2291
2292 * syntax.c: Integer cleanups.
2293 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2294 All uses that need 0-or-2 changed to:
2295 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2296 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2297 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2298 (char_quoted, prev_char_comend_first, back_comment)
2299 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2300 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2301 Use bool for boolean.
2302 (update_syntax_table, skip_chars, skip_syntaxes):
2303 Prefer int to unsigned when either will do.
2304 (back_comment): Return boolean success flag, like forw_comment,
2305 instead of positive-or-minus-1 (which might have overflowed int anyway).
2306 Don't stuff ptrdiff_t into int.
2307 (syntax_spec_code, syntax_code_spec): Now const.
2308 (Fmatching_paren, scan_lists, scan_sexps_forward):
2309 Use enum syntaxcode for syntax code.
2310 (Fmatching_paren): Check that arg is a character, not just an integer.
2311 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2312 (Finternal_describe_syntax_value): Omit no-longer-needed
2313 comparison to 0.
2314 (skip_chars): Use char, not unsigned char, when the distinction
2315 doesn't matter.
2316 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2317 * bytecode.c (exec_byte_code):
2318 * syntax.c (syntax_spec_code, Fchar_syntax)
2319 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2320 (init_syntax_once):
2321 * syntax.h (SYNTAX_WITH_FLAGS):
2322 Omit unnecessary casts.
2323
b932cad7
EZ
23242013-06-20 Eli Zaretskii <eliz@gnu.org>
2325
2326 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2327 line dimensions here, to avoid race conditions with the main
2328 thread. (Bug#14062, bug#14630, bug#14669)
2329
2330 * w32term.c (w32_draw_window_cursor): Compute the header line and
2331 mode line dimensions here.
2332 <w32_system_caret_window, w32_system_caret_hdr_height>:
2333 <w32_system_caret_mode_height>: New variables.
2334
2335 * w32term.h: Declare them.
2336
89561f72
PE
23372013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2338
5013fc08
PE
2339 * alloc.c (die): Move "assertion failed" string here ...
2340 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2341 COND when SUPPRESS_CHECKING. This shrinks the executable text
2342 size by 0.8% to 2.2% when configured with --enable-checking,
2343 depending on optimization flags (GCC 4.8.1 x86-64).
2344
89561f72
PE
2345 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2346
763a086d 23472013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2348
2349 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2350 base is 2; this is more accurate.
2351
983aeb9a
JB
23522013-06-19 Juanma Barranquero <lekktu@gmail.com>
2353
2354 * sound.c (string_default): Move to !WINDOWSNT section.
2355 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2356
178ba3e6
PE
23572013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2358
bbc51b15
PE
2359 * sound.c: Integer cleanups.
2360 Remove unnecessary forward decls.
2361 (struct sound_device): The 'file' member is now a Lisp_Object, not
2362 a char *, so that we needn't invoke alloca on a huge size.
2363 (Fplay_sound_internal): Adjust to this.
2364 (string_default): New function.
2365 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2366 Use it to adjust to the struct sound_device change.
2367 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2368 (be2hs) [0]: Remove.
2369
178ba3e6
PE
2370 * syntax.c (skip_chars): Don't use uninitialized storage
2371 when searching a multibyte buffer for characters that are not in a
2372 unibyte string that contains non-ASCII characters.
2373
69f60cdc
JD
23742013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2375
2376 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2377 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2378
0d6224d4
PE
23792013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2382
3c542890
KH
23832013-06-18 Kenichi Handa <handa@gnu.org>
2384
f7e3f7cd
KH
2385 * font.c (Ffont_spec): Signal an error for an invalid font name
2386 (Bug#14648).
3c542890 2387
9349e5f7
PE
23882013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2391 In particular this ports to 32-bit sparc Sun cc.
2392 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2393 array with a dummy element at specpdl[-1], so that its address can
2394 be taken portably.
2395 (unbind_to): Do not copy the binding; not needed, now that we
2396 copy old_value in the one place where the copy is needed.
2397 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2398 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2399 (union specbinding): Rename from struct specbinding. Redo layout
2400 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2401 which is not portable. With Sun C 5.12 32-bit sparc, the
2402 declaration causes nargs to be an unsigned bitfield, a behavior
2403 that the C standard allows; but Emacs wants nargs to be signed.
2404 The overall type is now a union of structures rather than a
2405 structure of union of structures, and the 'kind' member is now a
2406 bitfield, so that the overall type doesn't grow. All uses changed.
2407 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2408
0a4df6a5
PE
24092013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2410
ec6ecaad
PE
2411 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2412 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2413
0a4df6a5
PE
2414 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2415
7bfe8dbc
EZ
24162013-06-17 Eli Zaretskii <eliz@gnu.org>
2417
2418 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2419 unless we know that the window w's frame is a frame object.
2420 Another attempt at solving bug#14062 and bug#14630.
2421
708e05f6
LMI
24222013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2423
2424 * textprop.c (property_set_type): New enum.
2425 (add_properties): Allow appending/prepending text properties.
2426 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2427 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2428 add_text_properties_1.
2429 (Fadd_face_text_property): New function that calls
2430 add_text_properties_1.
2431
84575e67
PE
24322013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 Move functions from lisp.h to individual modules when possible.
2435 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2436 * alloc.c (XFLOAT_INIT, set_symbol_name):
2437 * buffer.c (CHECK_OVERLAY):
2438 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2439 (set_char_table_parent):
2440 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2441 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2442 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2443 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2444 (set_blv_valcell):
2445 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2446 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2447 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2448 (backtrace_args, backtrace_debug_on_exit):
2449 * floatfns.c (CHECK_FLOAT):
2450 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2451 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2452 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2453 (set_hash_index_slot):
2454 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2455 * marker.c (CHECK_MARKER):
2456 * textprop.c (CHECK_STRING_OR_BUFFER):
2457 * window.c (CHECK_WINDOW_CONFIGURATION):
2458 Move here from lisp.h, and make these functions static rather than
2459 extern inline.
2460 * buffer.c (Qoverlayp):
2461 * data.c (Qsubrp):
2462 * fns.c (Qhash_table_p):
2463 * window.c (Qwindow_configuration_p):
2464 Now static.
2465 * lisp.h: Remove the abovementioned defns and decls.
2466
44e18199 2467 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2468 In lisp.h, prefer functions to function-like macros, and
2469 constants to object-like macros, when either will do. This:
2470 . simplifies use, as there's no more need to worry about
2471 arguments' side effects being evaluated multiple times.
2472 . makes the code easier to debug on some platforms.
2473 However, when using gcc -O0, keep using function-like macros
2474 for a few critical operations, for performance reasons.
2475 This sort of thing isn't needed with gcc -Og, but -Og
2476 is a GCC 4.8 feature and isn't widely-enough available yet.
2477 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2478 Remove enum lsb_bits; no longer needed.
2479 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2480 * buffer.c (Qoverlap):
2481 * data.c (Qsubrp):
2482 * fns.c (Qhash_table_p):
2483 Now extern, so lisp.h can use these symbols.
2484 * dispextern.h: Include character.h, for MAX_CHAR etc.
2485 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2486 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2487 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2488 (GLYPH_CODE_P): Move here from lisp.h.
2489 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2490 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2491 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2492 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2493 XUNTAG now returns void *.
2494 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2495 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2496 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2497 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2498 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2499 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2500 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2501 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2502 New macros, renamed from their sans-lisp_h_ counterparts.
2503 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2504 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2505 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2506 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2507 If compiling via GCC without optimization, define these as macros
2508 in addition to inline functions.
2509 To disable this, compile with -DINLINING=0.
2510 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2511 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2512 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2513 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2514 (INTMASK, VALMASK): Now macros, since static values cannot be
2515 accessed from extern inline functions.
2516 (VALMASK): Also a constant, for benefit of old GDB.
2517 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2518 is INTEGERP, which can fold it in.
5165d44a 2519 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2520 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2521 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2522 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2523 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2524 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2525 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2526 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2527 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2528 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2529 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2530 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2531 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2532 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2533 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2534 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2535 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2536 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2537 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2538 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2539 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2540 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2541 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2542 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2543 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2544 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2545 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2546 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2547 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2548 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2549 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2550 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2551 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2552 Now functions.
2553 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2554 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2555 (VALMASK): Define in one place rather than in two, merging the
2556 USE_LSB_TAG parts; this is simpler.
2557 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2558 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2559 Move up, to avoid use before definition.
2560 Also include "globals.h" earlier, for the same reason.
2561 (make_natnum): New function.
2562 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2563 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2564 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2565 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2566 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2567 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2568 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2569 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2570 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2571 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2572 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2573 (Qwindow_configuration_p, Qimage): New forward declarations.
2574 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2575 (STRING_COPYIN): Remove; unused.
2576 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2577 (xcar_addr, xcdr_addr): New functions. All uses changed.
2578 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2579 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2580 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2581 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2582 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2583 (TYPE_RANGED_INTEGERP): Simplify.
2584 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2585 (setlocale, fixup_locale, synchronize_system_messages_locale)
2586 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2587 Now empty functions, not macros.
2588 (functionp): Return bool, not int.
2589 * window.c (Qwindow_configuration_p): Now extern,
2590 so window.h can use it.
2591 * window.h (Qwindowp): Move decl back to lisp.h.
2592
9583ec36
EZ
25932013-06-15 Eli Zaretskii <eliz@gnu.org>
2594
2595 * xdisp.c (Fline_pixel_height): New function, required for solving
2596 bug #14567.
2597
210272ce
PE
25982013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2599
2600 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2601
de0503df
SM
26022013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2603
2604 * lread.c (syms_of_lread):
2605 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2606
afbfe143
KD
26072013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2608
2609 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2610
d177e213
XF
26112013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2612
2613 * fileio.c (expand_file_name): Doc fix.
2614
05e3e412
PE
26152013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2616
f7394b12
PE
2617 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2618 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2619 Wait for self, not for 0. This can't hurt on GNU or similar
2620 system, and may help with Cygwin.
2621
05e3e412
PE
2622 * keyboard.c: Don't use PROP (...) as an lvalue.
2623 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2624 Use set_prop (A, B), not PROP (A) = B.
2625
17dd3097
EZ
26262013-06-10 Eli Zaretskii <eliz@gnu.org>
2627
2628 * xdisp.c (get_it_property): Use it->window instead of generating
2629 a Lisp object from it->w.
2630
52fab9c9
EZ
26312013-06-09 Eli Zaretskii <eliz@gnu.org>
2632
2633 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2634 get-char-property the window that is being rendered, instead of
2635 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2636 (compute_display_string_pos): When W is NULL, use the current
2637 buffer as the object to pass to get-char-property.
2638 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2639 pointer member of the bidi iterator, since no window is pertinent
2640 to this function.
52fab9c9 2641
5bf97bfc
EZ
26422013-06-08 Eli Zaretskii <eliz@gnu.org>
2643
2644 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2645 being displayed, and pass it to compute_display_string_pos.
2646 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2647 (bidi_paragraph_init): All callers changed.
2648
2649 * xdisp.c (init_from_display_pos, init_iterator)
2650 (handle_single_display_spec, next_overlay_string)
2651 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2652 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2653 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2654 (compute_display_string_pos): Accept additional argument, the
2655 window being displayed, and pass it to Fget_char_property.
2656 (Bug#14575)
2657
2658 * dispextern.h (struct bidi_it): New member w, the window being
2659 displayed.
2660 (compute_display_string_pos): Adjust prototype.
2661
5de0e011
JD
26622013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2663
e7b41c4c 2664 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2665
2666 * process.c (wait_reading_process_output): Check for NS before GLIB.
2667 GLIB may be linked in due to rsvg, but ns_select must be called.
2668
5de0e011
JD
2669 * xgselect.c (xg_select): Remove call to window_system_available
2670 and g_main_context_pending at the top, so Gdk events (i.e. file
2671 notify) are processed when Emacs is started with -nw.
2672
a822acff
EZ
26732013-06-07 Eli Zaretskii <eliz@gnu.org>
2674
2675 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2676 (ctagsfiles3): New variable, includes only *.m files.
2677 (TAGS): Use an explicit language name in the regular expressions,
2678 to avoid transformation of '/SOMETHING' by MSYS to
2679 'c:\MSYS\SOMETHING'.
2680
6c0a9ed1
RC
26812013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2682
2683 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2684
9ef6111b
EZ
26852013-06-06 Eli Zaretskii <eliz@gnu.org>
2686
2687 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2688 still need to set the mouse pointer shape and activate help-echo.
2689 (Bug#14558)
2690
7d300d64
PE
26912013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 A few porting etc. fixes for the new file monitor code.
2694 See the thread containing
2695 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2696 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2697 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2698 (dir_monitor_callback, Fgfile_rm_watch):
2699 Use assq_no_quit instead of Fassoc, for speed.
2700 (dir_monitor_callback, Fgfile_rm_watch):
2701 eassert that the monitor is a fixnum.
2702 (dir_monitor_callback): No need for CDR_SAFE.
2703 Simplify building of lisp with alternative tails.
2704 (Fgfile_add_watch, Fgfile_rm_watch):
2705 Do not assume glib functions set errno reliably on failure.
2706 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2707 and signal an error otherwise.
2708 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2709 Use Fdelq instead of Fdelete, for speed.
2710
817ebfcf
EZ
27112013-06-05 Eli Zaretskii <eliz@gnu.org>
2712
2713 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2714 don't insist on being invoked on a highlighted tool-bar button.
2715 Avoids losing tool-bar functionality when mouse-highlight is nil.
2716 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2717 Don't highlight when mouse-highlight is nil.
2718 (note_mouse_highlight): When mouse-highlight is nil, don't return
2719 right away; instead, run tool-bar and mode-line highlight
2720 subroutine, clear any existing highlight, and revert the mouse
2721 pointer to its default shape. (Bug#14558)
2722
55577e7c
SM
27232013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2724
2725 * lisp.mk (lisp): Add prog-mode.el.
2726
f019a684
PE
27272013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2728
2729 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2730 * process.c (dummy_handler): New function.
2731 (lib_child_handler): New static var.
2732 (handle_child_signal): Invoke it.
2733 (catch_child_signal): If a library has set up a signal handler,
2734 save it into lib_child_handler.
2735 (init_process_emacs): If using glib and not on Windows, tickle glib's
2736 child-handling code so that it initializes its private SIGCHLD handler.
2737 * syssignal.h (SA_SIGINFO): Default to 0.
2738 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2739 31; it should no longer be needed now.
2740
90db8702
MA
27412013-06-05 Michael Albinus <michael.albinus@gmx.de>
2742
2743 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2744
2745 * gfilenotify.c (globals_of_gfilenotify): New function.
2746 (syms_of_gfilenotify): Move global initialization there.
2747
2748 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2749
bfa3acd6
SM
27502013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2751
2752 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2753 * keyboard.c (menu_bar_items, tool_bar_items):
2754 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2755 not override local keymaps any more.
2756
ba59bd80
EZ
27572013-06-04 Eli Zaretskii <eliz@gnu.org>
2758
2759 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2760
7f203aa1
EZ
27612013-06-03 Eli Zaretskii <eliz@gnu.org>
2762
9337e206
EZ
2763 * w32console.c (initialize_w32_display): Return the dimensions of
2764 the console window via 2 additional arguments, not via the current
2765 frame. This avoids crashes due to overrunning the bounds of
2766 frame's decode_mode_spec_buffer, which is not resized following
2767 the change of the frame dimensions from the initial 10x10.
2768
2769 * w32term.h (w32_initialize_display_info): Adjust prototype.
2770
2771 * term.c (init_tty): Take dimensions of the frame from the values
2772 returned by initialize_w32_display.
2773
7f203aa1
EZ
2774 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2775 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2776 (LIBES): Add $(GFILENOTIFY_LIBS).
2777
2778 * w32inevt.c (handle_file_notifications): Add dummy implementation
2779 for !HAVE_W32NOTIFY.
2780
2781 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2782
55a87246
JD
27832013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2784
2785 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2786
2787 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2788
2789 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2790
3d5ee10a
PE
27912013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 Fix minor problems found by static checking.
2794 * data.c (pure_write_error):
2795 Use xsignal2, not Fsignal, as Fsignal might return.
2796 * eval.c (set_backtrace_debug_on_exit): Now static.
2797 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2798 No longer inline. EXTERN_INLINE is needed only for functions
2799 defined in .h files. Reindent function header as per GNU style.
2800 (backtrace_p, backtrace_top, backtrace_next):
2801 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2802 compiler or linker. Add extern decls to pacify gcc -Wall.
2803 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2804 Now static.
2805 * frame.c (free_monitors): Define only on platforms that need it.
2806 * nsterm.m (ns_term_init):
2807 * process.c (catch_child_signal):
2808 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2809 defined on all porting targets these days.
2810 * process.c, process.h (catch_child_signal):
2811 Make it extern only if NS_IMPL_GNUSTEP is defined.
2812
e2d8a6f0
EZ
28132013-06-03 Eli Zaretskii <eliz@gnu.org>
2814
2815 * w32.c (gettimeofday): Make the signature identical to prototype
2816 in nt/inc/sys/time.h.
2817
a8a7c5f6
SM
28182013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2819
2820 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2821 .gdbinit.
2822
2823 * keyboard.c (safe_run_hooks_error): Improve error message.
2824
2825 * data.c (pure_write_error): Add `object' argument.
2826 * puresize.h (CHECK_IMPURE): Use it.
2827
c9628c79
MA
28282013-06-03 Michael Albinus <michael.albinus@gmx.de>
2829
2830 * Makefile.in (NOTIFY_OBJ): New variable.
2831 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2832
2833 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2834 Call syms_of_gfilenotify.
2835
2836 * gfilenotify.c: New file.
2837
2838 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2839 and Qfile_w32notify.
2840 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2841 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2842
2843 * lisp.h: Declare syms_of_gfilenotify.
2844
2845 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2846
2f592f95
SM
28472013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2848
2849 Merge the specpdl and backtrace stacks. Make the structure of the
2850 specpdl entries more obvious via a tagged union of structs.
2851 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2852 (enum specbind_tag): New enum.
2853 (struct specbinding): Make it a tagged union of structs.
2854 Add a case for backtrace records.
2855 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2856 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2857 (backtrace_debug_on_exit): New accessors.
2858 (struct backtrace): Remove.
2859 (struct catchtag): Remove backlist field.
2860 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2861 Move to eval.c.
2862 (Flocal_variable_p): Speed up the common case where the binding is
2863 already loaded.
2864 * eval.c (backtrace_list): Remove.
2865 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2866 (set_backtrace_args, set_backtrace_nargs)
2867 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2868 (backtrace_next): New functions.
2869 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2870 (unwind_to_catch, internal_lisp_condition_case)
2871 (internal_condition_case, internal_condition_case_1)
2872 (internal_condition_case_2, internal_condition_case_n): Don't bother
2873 with backtrace_list any more.
2874 (Fsignal): Adjust to new backtrace format.
2875 (grow_specpdl): Move up.
2876 (record_in_backtrace): New function.
2877 (eval_sub, Ffuncall): Use it.
2878 (apply_lambda): Adjust to new backtrace format.
2879 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2880 data.c.
2881 (specbind): Adjust to new specpdl format. Simplify.
2882 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2883 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2884 backtrace format.
2885 (mark_backtrace): Remove.
2886 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2887 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2888 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2889 Use mark_specpdl.
2890 * profiler.c (record_backtrace): Use get_backtrace.
2891 (handle_profiler_signal): Use backtrace_top_function.
2892 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2893 accessor functions.
2894
c0342369
JD
28952013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2896
2897 * process.h (catch_child_signal): Declare.
2898
2899 * process.c (catch_child_signal): New function.
2900 (init_process_emacs): Call it.
2901
2902 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2903 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2904 NS_IMPL_COCOA.
2905 (x_set_cursor_type): Remove declaration.
2906 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2907 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2908 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2909 (ns_get_color): Use F suffix on float.
2910 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2911 (ns_get_rgb_color): Remove.
2912 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2913 (note_mouse_movement): x and y are CGFloat.
2914 (ns_draw_fringe_bitmap): Remove unused rowY.
2915 Change #if to COCOA && >= 10_6.
2916 (ns_draw_window_cursor): Remove unused overspill.
2917 (ns_draw_underwave): width and x are EamcsCGFloat.
2918 (ns_draw_box): thickness is CGFloat.
2919 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2920 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2921 if not in main thread.
2922 (ns_get_pending_menu_title, ns_check_menu_open)
2923 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2924 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2925 (sendFromMainThread:): New method.
2926 (changeFont:): size is CGFloat.
2927 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2928 Disable warning about permanent text.
2929 (characterIndexForPoint:): Adjust return type depending on GNUStep
2930 version.
2931 (mouseDown:): delta is CGFloat.
2932 (updateFrameSize): Remove unised variable f.
2933 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2934 Cast float to EmacsCGFloat.
2935 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2936 also to -1 when restoring.
2937 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2938 inside NS_IMPL_COCOA.
2939 (toggleFullScreen:): Put call to toggleFullScreen inside
2940 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2941 (setPosition:portion:whole:): por is CGFloat.
2942 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2943 (mouseDown:): Use CGFloat.
2944 (mouseDragged:): Remove unised variable edge.
2945 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2946
2947 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2948 of CGFloat differs.
2949 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2950 when NS_IMPL_GNUSTEP.
2951 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2952 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2953 (EmacsToolbar): Add clearAll. Add tag argument to
2954 addDisplayItemWithImage.
2955 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2956
2957 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2958
2959 * nsmenu.m (ns_update_menubar): Make static.
2960 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2961 (fillWithWidgetValue:): Add cast to SEL for setAction.
2962 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2963 (update_frame_tool_bar): Update code for GNUStep.
2964 (clearAll): New method.
2965 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2966 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2967 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2968 call to insertItemWithItemIdentifier.
2969 (validateVisibleItems): Fix indentation.
2970 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2971 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2972 UtilityWindow to aStyle, remove call to setStyleMask.
2973
2974 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2975
2976 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2977 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2978 Use F suffix on floats.
2979 (ns_char_width): Returns CGFloat.
2980 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2981 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2982 DPSxshow.
2983 (ns_glyph_metrics): CGFloat instead of float.
2984
a0eb10b3
JB
2985 * nsfns.m (x_set_foreground_color, x_set_background_color):
2986 Use EmacsCGFloat.
2987 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2988 remove unused variables.
2989 (Fns_read_file_name): Keep track if panel is for save.
2990 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2991 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2992 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2993 Just return the input if GNUStep.
c0342369
JD
2994 (x_screen_planes): Remove.
2995 (Fxw_color_values): Use EmacsCGFloat
2996 (Fns_display_monitor_attributes_list): Only get screen number for
2997 Cocoa.
ef099a94 2998 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2999 EmacsSavePanel.
3000 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3001 ns_directory_from_panel.
3002
da9aff11
PE
30032013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3004
3005 * process.c (handle_child_signal): Also use WCONTINUED.
3006 This is so that list-processes doesn't mistakenly list the process
3007 as stopped, when the process has actually been continued and is
3008 now running.
3009
0e64479a
PE
30102013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3011
fc186a96
PE
3012 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3013 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3014 not already configured.
3015
0e64479a
PE
3016 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3017
38b787fa
EZ
30182013-05-29 Eli Zaretskii <eliz@gnu.org>
3019
3020 * Makefile.in (mostlyclean): Remove *.res files.
3021
22513e52
SM
30222013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3023
3024 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3025 a buffer (bug#8447).
3026
6ef3db10
EZ
30272013-05-27 Eli Zaretskii <eliz@gnu.org>
3028
3029 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3030 display vector, and we backtrack, handle the case that the
3031 previous character position is also displayed from a display
3032 vector or covered by a display string or image. (Bug#14476)
3033
6799bb26
JD
30342013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3035
3036 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3037 (struct MonitorInfo, free_monitors): Remove.
3038 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3039 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3040 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3041 Qframes, Qsource.
3042
3043 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3044 (struct MonitorInfo, free_monitors): Remove.
3045 (ns_screen_name): Make static.
3046 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3047 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3048 Qframes, Qsource.
3049
3050 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3051 (struct MonitorInfo): New struct.
3052 (free_monitors, make_monitor_attribute_list): Declare.
3053
22513e52
SM
3054 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3055 New Lisp_Object:s.
6799bb26
JD
3056 (free_monitors, make_monitor_attribute_list): New functions.
3057 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3058 Qsource.
3059
38cd43eb
XF
30602013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3061
3062 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3063
2af0948d
SM
30642013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3065
a7eb9b0f
SM
3066 * keyboard.c: Apply keyboard decoding only to events that come directly
3067 from the tty, not from unread-command-events (bug#14368).
3068 (read_event_from_main_queue): New function, extracted from read_char).
3069 (read_decoded_char): Remove.
3070 (read_decoded_event_from_main_queue): New function to replace it.
3071 (read_char): Use it.
3072 (read_key_sequence): Use read_char rather than read_decoded_char.
3073
2af0948d
SM
3074 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3075
1413e9a5
BR
30762013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3077
3078 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3079
e6d2f155
KH
30802013-05-22 Kenichi Handa <handa@gnu.org>
3081
3082 The following changes are to fix the setting of
3083 buffer-file-coding-system on, for instance, C-x RET c unix RET
3084 _FILE_OF_DOS_EOL_TYPE_ RET.
3085
3086 * coding.h (struct coding_system): New member detected_utf8_chars.
3087
3088 * coding.c (detect_coding_utf_8): Count characters and check EOL
3089 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3090 BOM is there.
3091 (setup_coding_system): Do not initialize coding->head_ascii.
3092 (check_ascii): Do not set coding->eol_seen but update it. Do not
3093 call adjust_coding_eol_type here.
1413e9a5
BR
3094 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3095 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3096 of the found coding-system.
3097 (decode_coding_gap): Cancel previous change. Utilize the
3098 character numbers counted by detect_coding_utf_8. Fix detection
3099 of BOM for utf-8.
3100
ab56a6f4 31012013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3102
3103 * search.c (looking_at_1): Only set last_thing_searched if the match
3104 changed the match-data (bug#14281).
3105
ecc3c6ed
DA
31062013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3107
3108 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3109 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3110 (move_it_vertically_backward): Likewise.
3111
5ba8bf35
YM
31122013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3113
3114 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3115 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3116 (Fx_display_mm_width, Fx_display_mm_height):
3117 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3118
91e8418b 3119 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3120 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3121 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3122 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3123 (Fx_display_backing_store, Fx_display_visual_class)
3124 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3125 (Fx_display_grayscale_p, Fx_display_pixel_width)
3126 (Fx_display_pixel_height, Fx_display_planes)
3127 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3128 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3129 (Fx_display_mm_width, Fx_display_mm_height)
3130 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3131 height for all physical monitors as in X11.
3132
fc30d803
SM
3133 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3134 Return pixel width or height for all physical monitors as in X11.
91e8418b 3135
31ff141c
PE
31362013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 Port --enable-gcc-warnings to clang.
3139 * bytecode.c (exec_byte_code):
3140 * regex.c:
3141 Redo diagnostic pragmas to pacify clang, too.
3142 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3143 * editfns.c (Fencode_time):
3144 * fileio.c (file_accessible_directory_p):
3145 * font.c (font_unparse_xlfd):
3146 Use '&"string"[index]' instead of '"string" + (index)'.
3147 * undo.c (user_error): Remove; unused.
3148
df065a0b
EZ
31492013-05-16 Eli Zaretskii <eliz@gnu.org>
3150
04d360e7
EZ
3151 * insdel.c (insert_1_both): Document the arguments, instead of
3152 referring to insert_1, which no longer exists.
3153
5bb98290
EZ
3154 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3155 some window, increment windows_or_buffers_changed, so that
3156 *Messages* display in that window is updated. (Bug#14408)
3157
df065a0b
EZ
3158 * w32.c: Include epaths.h.
3159 (init_environment): Use cmdproxy.exe without leading directories.
3160 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3161 case.
3162 (gettimeofday): Adjust signature and return value to Posix
3163 expectations.
3164
3165 * unexw32.c (open_output_file): Delete the existing emacs.exe
3166 before creating it, to break the hard link to the versioned
3167 executable.
3168
3169 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3170 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3171 (FIRSTFILE_OBJ): New variables.
3172 (W32_RES): Rename to EMACSRES. All users changed.
3173 (base_obj): Use $(CM_OBJ).
3174 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3175 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3176 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3177 $(W32_RES_LINK) before $(LIBES).
3178 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3179
1aa8d505
SM
31802013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3181
6e911150
SM
3182 * makefile.w32-in (DOC): Use just "DOC".
3183
3184 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3185
1aa8d505
SM
3186 * process.c: Export default filters and sentinels to Elisp.
3187 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3188 New constants.
3189 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3190 (Fset_process_sentinel, Fformat_network_address):
3191 Default to them instead of nil.
3192 (server_accept_connection): Sentinels can't be nil any more.
3193 (read_and_dispose_of_process_output): New function, extracted from
3194 read_process_output.
3195 (read_process_output): Use it; filters can't be nil.
3196 (Finternal_default_process_filter): New function, extracted from
3197 read_process_output.
3198 (exec_sentinel_unwind): Remove function.
3199 (exec_sentinel): Don't zilch sentinel while running.
3200 (status_notify): Sentinels can't be nil.
3201 (Finternal_default_process_sentinel): New function extracted from
3202 status_notify.
3203 (setup_process_coding_systems): Default filter is not nil any more.
3204 (syms_of_process): Export new Elisp functions and initialize
3205 new constants.
3206 * lisp.h (make_lisp_proc): New function.
3207
5ac2eb34
SM
32082013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3209
3210 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3211
eda9c7d7
EZ
32122013-05-14 Eli Zaretskii <eliz@gnu.org>
3213
3214 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3215 unless we know that the window w is a leaf window.
3216 Another attempt at solving bug#14062.
eda9c7d7 3217
8fdeaad5
JD
32182013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3219
3220 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3221 fdesc (Bug#14375).
3222
44aa9ee6
PE
32232013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 * image.c (gif_load): Check that subimages fit (Bug#14345).
3226
759fd763
SM
32272013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3228
3229 * lread.c (skip_dyn_eof): New function.
3230 (read1): Use it to skip the end of a file in response to #@00.
3231
3232 * doc.c (get_doc_string): Slightly relax the sanity checking.
3233
4465bfb4
JD
32342013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3235
3236 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3237 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3238 (MonitorInfo): New struct.
3239 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3240 (Fns_display_monitor_attributes_list): New functions.
3241 (display-usable-bounds): Remove.
3242 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3243 Qsource.
3244
7583e2a0
PE
32452013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3246
3247 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3248 (GTK_CHECK_VERSION): New macro, if not already defined.
3249 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3250 replaced by GTK_CHECK_VERSION.
3251
ad75d77e
PE
32522013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3253
3254 * xterm.h (GTK_PREREQ): New macro.
3255 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3256 to use this macro instead, for consistency and clarity.
3257
07525f77
EZ
32582013-05-08 Eli Zaretskii <eliz@gnu.org>
3259
3260 * xdisp.c (row_for_charpos_p): New function, with code of
3261 cursor_row_p, but accepts an additional argument CHARPOS instead
3262 of using a hardcoded PT.
3263 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3264 (row_containing_pos): Call row_for_charpos_p instead of partially
3265 doing the same. Fixes cursor positioning under longlines-mode
3266 when longlines-show-effect includes more than one newline, when
3267 moving the cursor vertically up.
3268
d901fc8d
JB
32692013-05-08 Juanma Barranquero <lekktu@gmail.com>
3270
3271 * makefile.w32-in (ACL_H): New macro.
3272 ($(BLD)/fileio.$(O)): Update dependencies.
3273
f269bc61
PE
32742013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3275
e7b41c4c 3276 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3277 * Makefile.in (LIB_ACL): New macro.
3278 (LIBACL_LIBS): Remove.
3279 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3280 * fileio.c: Include <acl.h>.
3281 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3282 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3283 !acl_errno_valid.
3284 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3285 it ourselves.
3286
f269bc61
PE
3287 * unexelf.c: Don't assume ElfW (Half) fits in int.
3288 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3289 when dealing with ElfW (Half) values, since they can exceed 2**31
3290 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3291 (entry_address): Omit unused NUM arg. All uses changed.
3292
a261c53e
JL
32932013-05-07 Juri Linkov <juri@jurta.org>
3294
3295 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3296 to the string converted from number with `Fnumber_to_string'.
3297 (Bug#14254)
3298
2b66427d
PE
32992013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3302 This fixes a problem introduced by my previous change.
3303
15acfe41
GM
33042013-05-07 Glenn Morris <rgm@gnu.org>
3305
3306 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3307
5ea03bf5
JD
33082013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3309
3310 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3311
e0c9d565
PE
33122013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3313
3314 Static checking by GCC 4.8.0.
3315 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3316 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3317 (x_get_monitor_attributes_fallback)
3318 (x_get_monitor_attributes_xinerama)
3319 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3320 Define only if USE_GTK.
3321 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3322 (x_get_monitor_attributes_fallback): Omit unused locals.
3323 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3324 Use double, not float, to avoid mixed-mode floating point arithmetic.
3325
4e3f9230
YM
33262013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3327 Jan Djärv <jan.h.d@swipnet.se>
3328
3329 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3330 (XINERAMA_CFLAGS): New macros.
3331 (ALL_CFLAGS, LIBES): Use them.
3332
3333 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3334 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3335 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3336 (syms_of_xfns): DEFSYM them.
3337 (struct MonitorInfo): New struct.
3338 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3339 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3340 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3341 (x_get_monitor_attributes_xinerama): New functions.
3342 (Fx_display_monitor_attributes_list): New primitive.
3343 (syms_of_xfns): Defsubr it.
3344
3345 * xterm.h (x_display_info): Add Xatom_net_workarea and
3346 Xatom_net_current_desktop.
3347
3348 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3349 and dpyinfo->Xatom_net_current_desktop.
3350
05839b6a
EZ
33512013-05-06 Eli Zaretskii <eliz@gnu.org>
3352
3353 * xdisp.c (pos_visible_p): Use the special code for finding the
3354 beginning of a display property or overlay for any "replacing"
3355 display property, not just for display strings. This solves
3356 incorrect reporting of position by posn-at-point. (Bug#14241)
3357
dc4a2ee0
PE
33582013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3359
5ee94506
PE
3360 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3361 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3362 Verify that ElfW (Half) fits in int.
3363 (fatal): Use same signature as lisp.h.
3364 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3365 configure and build with -DUNEXELF_DEBUG without worrying about
3366 other modules that use DEBUG.
3367 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3368 possibly-wide integers now uses it instead of plain fprintf.
3369 (entry_address): New function, which avoids problems with 32-bit
3370 overflow on 64-bit hosts.
3371 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3372 (round_up): Don't assume the remainder fits in int.
3373 (find_section): Use bool for boolean. Simplify debug code.
3374 (unexec): Don't assume file sizes fit in int or size_t.
3375 Omit unnecessary trailing newline in 'fatal' format.
3376 Use strerror rather than outputting decimal error number.
3377 Remove unused code when emacs is not defined;
3378 this file relies on Emacs now.
3379 Don't assume e_phnum and e_shnum are positive.
3380
dc4a2ee0
PE
3381 * regex.c: Fix problems when DEBUG is defined.
3382 (extract_number, extract_number_and_incr): Define regardless of
3383 whether DEBUG is defined; that's simpler and makes the code less
3384 likely to go stale in the normal case when DEBUG is not defined.
3385 Return int rather than taking an int * arg. All callers changed.
3386 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3387 Remove, replacing with ...
3388 (DEBUG_PRINT): New macro. All callers changed.
3389 (DEBUG_COMPILES_ARGUMENTS): New macro.
3390 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3391 (print_compiled_pattern, print_double_string) [DEBUG]:
3392 Use prototype rather than old-style definition.
3393 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3394 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3395 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3396 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3397 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3398 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3399 This matters only when DEBUG is defined.
3400
14c7ed05
EZ
34012013-05-05 Eli Zaretskii <eliz@gnu.org>
3402
3403 * xdisp.c (set_iterator_to_next): Set the
3404 ignore_overlay_strings_at_pos_p flag only if we are _really_
3405 iterating over an overlay string, as indicated by the
3406 current.overlay_string_index member. (Bug#14306)
3407
e6076b1b
JD
34082013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3409
3410 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3411 to where it is used, to avoid autorelease issues (Bug#14050).
3412
cbee2131
PE
34132013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3414
3415 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3416 * fileio.c (syms_of_fileio): Implement this.
3417 * filelock.c (create_lock_file): If symbolic links don't work, so
3418 we use a regular file as a lock file, do not fsync the lock file;
3419 it's not needed.
3420
30c7e542
SM
34212013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3422
3423 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3424 (syms_of_minibuf): Adjust accodingly.
3425 * lread.c (Fread):
3426 * callint.c (Fcall_interactively): Adjust calls accordingly.
3427
5bebd186
EZ
34282013-05-04 Eli Zaretskii <eliz@gnu.org>
3429
3430 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3431 w->contents is a buffer before computing everything else.
3432 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3433
3434 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3435 assertion violations. (Bug#14062)
3436
0fb0a4f3
DR
34372013-05-01 David Reitter <david.reitter@gmail.com>
3438
3439 * nsfns.m (ns_tooltip): Initialize.
3440
9e63b4a5
EZ
34412013-04-28 Eli Zaretskii <eliz@gnu.org>
3442
3443 * coding.c (decode_coding_gap): Don't remove the character before
3444 a newline unless it's a CR character. (Bug#14287)
3445
ad60824e
DN
34462013-04-28 Dan Nicolaescu <dann@gnu.org>
3447
3448 * dispextern.h (struct face): Move enum face_underline_type
3449 earlier so that bitfields can be in the same word.
3450
edbdcec0
JD
34512013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3452
3453 * nsfns.m (handlePanelKeys): New function.
3454 (EmacsOpenPanel:performKeyEquivalent:)
3455 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3456 arrows/function/control and copy/paste keys (Bug#14296).
3457
0208ede7
JL
34582013-04-27 Juri Linkov <juri@jurta.org>
3459
3460 * callint.c (Fcall_interactively): Call `Qread_number' for
3461 interactive code letter `n' instead of using duplicate code.
3462 (Bug#14254)
3463
b8dd59f7
PE
34642013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3465
3466 * systime.h (make_timeval): Declare as 'const'.
3467
8bd722db
KH
34682013-04-27 Kenichi Handa <handa@gnu.org>
3469
3470 * font.c (font_open_entity): Always open a font of manageable
3471 size.
3472
13d0e56f 34732013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3474
f780d632
PE
3475 Port better to AIX (Bug#14258).
3476 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3477 to pacify AIX xlc.
3478
ec509856
KH
34792013-04-24 Kenichi Handa <handa@gnu.org>
3480
3481 * coding.c (decode_coding_iso_2022): When an invalid escape
3482 sequence is encountered, reset the invocation and designation
3483 status to the safest one.
3484
84fc48e5
PE
34852013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3486
3487 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3488 Without this fix, "make distclean" leaves stamp-h1 behind.
3489
806bda47
EC
34902013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3491
3492 * w32fns.c (w32_fullscreen_rect): New function to compute the
3493 window rectangle for the given fullscreen mode.
3494 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3495 longer tunes the window size. This keeps the window's edges flush
3496 with the screen and allows the taskbar to hide itself in fullboth.
3497
3498 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3499 window decorations and uses the entire screen.
3500
3501 * w32term.h (w32_fullscreen_rect) Add prototype.
3502 (struct w32_output): Replace normal_width, normal_height,
3503 normal_top, and normal_left members with a single normal_placement
3504 struct.
3505 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3506 Remove macros.
3507 (FRAME_NORMAL_PLACEMENT): New macro.
3508
9cc2810b
JB
35092013-04-16 Juanma Barranquero <lekktu@gmail.com>
3510
3511 * minibuf.c (Ftest_completion): Silence compiler warning.
3512
fd16b54c
EZ
35132013-04-15 Eli Zaretskii <eliz@gnu.org>
3514
3515 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3516 bug#14062.
fd16b54c
EZ
3517
3518 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3519 parentheses.
3520
3521 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3522 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3523 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3524 parentheses where appropriate.
3525
9e3379a0
PE
35262013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3527
3528 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3529
ddd6b685
EZ
35302013-04-14 Eli Zaretskii <eliz@gnu.org>
3531
3532 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3533 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3534 Mention in the doc string that setting these variables takes
3535 effect only after a call to set-window-buffer. (Bug#14200)
3536
29b79ba1
EZ
35372013-04-13 Eli Zaretskii <eliz@gnu.org>
3538
3539 * indent.c (Fvertical_motion): Don't consider display strings on
3540 overlay strings as display strings on the buffer position we
3541 started from. This prevents vertical cursor motion from jumping
3542 more than one line when there's an overlay string with a display
3543 property at end of line.
3544 Reported by Karl Chen <Karl.Chen@quarl.org> in
3545 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3546
562c6ee9
SM
35472013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3548
3549 * window.c (select_window): `record_buffer' even if window is
3550 already selected (bug#14191).
3551
fcc1fe85
EZ
35522013-04-11 Eli Zaretskii <eliz@gnu.org>
3553
3554 * window.c (Fwindow_end): Test more flags, including the buffer's
3555 last_overlay_modified flag, to determine whether the window's
3556 display is really up-to-date. Prevents the function from
3557 returning a stale value. (Bug#14170)
3558 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3559 current matrix.
3560
f009190a
EZ
35612013-04-10 Eli Zaretskii <eliz@gnu.org>
3562
3563 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3564 garbaged only if it is not already the top frame on its TTY.
3565 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3566 there are GUI frames open in the same session. (Bug#13864)
3567
78ce603d
SM
35682013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3569
3570 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3571 of marking the idle timers directly.
3572
a8036e40
SM
35732013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3574
3575 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3576 tables (bug#14054).
3577
7ffe7ef6
SM
35782013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3579
3580 * window.c (select_window): Don't record_buffer while the invariant is
3581 temporarily broken (bug#14161).
3582
3583 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3584
7d9f6883
EZ
35852013-04-07 Eli Zaretskii <eliz@gnu.org>
3586
3587 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3588
5406cfd9
RF
35892013-04-07 Romain Francoise <romain@orebokech.com>
3590
3591 Ignore additional platform-specific ACL errors (Bug#13702).
3592 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3593 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3594
95c0e83b
JD
35952013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3596
3597 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3598 f->output_data.ns.
3599
876da980
PE
36002013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3603 This bug was introduced by my 2013-02-25 change that simplified
3604 data_start configuration. Without this change, on GNU/Linux
3605 an Emacs configured with --enable-profiling fails immediately
3606 due to a profiler signal.
3607 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3608 with these flags. On platforms where special flags are needed
3609 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3610 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3611 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3612
7452b7bd
DA
36132013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3614
3615 Get rid of some platform-specific functions examining window
3616 system and its capabilities. This is a partial rework of the
3617 2013-04-05 change.
3618 * lisp.h (have_menus_p): Remove prototype. This function is
3619 replaced with platform-independent window_system_available.
3620 (check_window_system): Move to...
3621 * frame.h (decode_window_system_frame, window_system_available):
3622 ...here, add new prototypes.
3623 * frame.c (window_system_available, decode_window_system_frame):
3624 New functions.
3625 (check_window_system): Platform-independent now.
3626 * xterm.h (x_in_use): Remove declaration.
3627 (check_x_frame):
3628 * w32term.h (check_x_frame):
3629 * nsterm.h (check_x_frame): Remove prototypes. This function
3630 is replaced with platform-independent decode_window_system_frame.
3631 * msdos.c (have_menus_p): Remove.
3632 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3633 Remove platform-specific functions. Use check_window_system,
3634 decode_window_system_frame and check_ns_display_info where
3635 appropriate. Minor style and comment tweaks.
3636 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3637 (check_x_frame): Likewise.
3638 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3639 Likewise.
3640 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3641 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3642 * xmenu.c, xselect.c: All related users changed.
3643
251e9147
KH
36442013-04-03 Kenichi Handa <handa@gnu.org>
3645
3646 The following changes is to optimize the code for reading UTF-8
3647 files.
3648
562c6ee9 3649 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3650 changed. Check EOL format. Do not call adjust_coding_eol_type
3651 here.
3652 (check_utf_8): New function.
3653 (adjust_coding_eol_type): Do nothing if already adjusted.
3654 (detect_coding): Compare the return value of check_ascii with
3655 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3656 (decode_coding_gap): Optimize for valid UTF-8.
3657
8bc369d4
KH
36582013-03-21 Kenichi Handa <handa@gnu.org>
3659
3660 * coding.c (syms_of_coding): Cancel previous change.
3661
3662 * insdel.c (insert_from_gap): Fix previous change.
3663
73931ad1
DA
36642013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3665
3666 Consistently use platform-specific function to detect window system.
3667 * lisp.h (check_window_system): New prototype. This function is
3668 going to replace check_x, check_w32 and check_ns.
3669 (have_menus_p): Mention msdos.c in comment.
3670 * fontset.c (check_window_system_func): Remove. Adjust all users.
3671 * fontset.h (check_window_system_func): Remove prototype.
3672 * nsterm.h (check_ns):
3673 * xterm.h (check_x):
3674 * w32term.h (check_w32): Likewise.
3675 * menu.c (Fx_popup_menu): Use check_window_system.
3676 * msdos.c (check_window_system): Define for MS-DOS.
3677 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3678 * w32fns.c (check_window_system): Likewise for MS-Windows.
3679 * xfns.c (check_window_system): Likewise for X.
3680 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3681 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3682
7216e43b
PE
36832013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3684
3685 Prefer < to > in range checks such as 0 <= i && i < N.
3686 This makes it easier to visualize quantities on a number line.
3687 This patch doesn't apply to all such range checks,
3688 only to the range checks affected by the 2013-03-24 change.
3689 This patch reverts most of the 2013-03-24 change.
3690 * alloc.c (xpalloc, Fgarbage_collect):
3691 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3692 * character.c (string_escape_byte8):
3693 * charset.c (read_hex):
3694 * data.c (cons_to_unsigned):
3695 * dispnew.c (update_frame_1):
3696 * doc.c (Fsubstitute_command_keys):
3697 * doprnt.c (doprnt):
3698 * editfns.c (hi_time, decode_time_components):
3699 * fileio.c (file_offset):
3700 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3701 * font.c (font_intern_prop):
3702 * frame.c (x_set_alpha):
3703 * gtkutil.c (get_utf8_string):
3704 * indent.c (check_display_width):
3705 * keymap.c (Fkey_description):
3706 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3707 * lread.c (read1):
3708 * minibuf.c (read_minibuf_noninteractive):
3709 * process.c (wait_reading_process_output):
3710 * search.c (Freplace_match):
3711 * window.c (get_phys_cursor_glyph):
3712 * xdisp.c (redisplay_internal):
3713 * xsmfns.c (smc_save_yourself_CB):
3714 Prefer < to > for range checks.
3715 * dispnew.c (sit_for): Don't mishandle NaNs.
3716 This fixes a bug introduced in the 2013-03-24 change.
3717 * editfns.c (decode_time_components): Don't hoist comparison.
3718 This fixes another bug introduced in the 2013-03-24 change.
3719
92759988
DA
37202013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3721
3722 * frame.h (struct frame): Drop scroll_bottom_vpos
3723 member becaue all real users are dead long ago.
3724 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3725 * xdisp.c (redisplay_internal): Adjust user.
3726
9a1971bb
GM
37272013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3728
f38ab167
JD
3729 * nsmenu.m (showAtX:Y:for:): setLevel to
3730 NSPopUpMenuWindowLevel (Bug#13998).
3731
6d01f1fe
JD
37322013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3733
3734 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3735 (ns_check_pending_open_menu): Declare.
3736
3737 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3738 (x_activate_menubar): Update the menu with title that matches
3739 ns_get_pending_menu_title, and call
3740 ns_check_pending_openmenu (Bug#12698).
3741 (menuWillOpen:): New method.
3742 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3743
3744 * nsterm.m (menu_will_open_state, menu_mouse_point)
3745 (menu_pending_title): New varaibles.
3746 (ns_get_pending_menu_title, ns_check_menu_open)
3747 (ns_check_pending_open_menu): New functions.
3748
781f4782
DA
37492013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3750
3751 * indent.c (current_column_bol_cache): Remove leftover which is not
3752 used in Fmove_to_column any more.
3753 (current_column, scan_for_column): Adjust users.
3754 * keyboard.c (last_point_position_buffer, last_point_position_window):
3755 Remove leftovers which are not used for recording undo any more.
3756 (command_loop_1, syms_of_keyboard): Adjust users.
3757 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3758 redisplay_window any more.
3759 (move_it_to): Adjust user.
3760
1921c31b
JB
37612013-03-29 Juanma Barranquero <lekktu@gmail.com>
3762
3763 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3764 Update dependencies.
3765
717b8bcd
SM
37662013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3767
3768 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3769 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3770 forward references.
3771
e74aeda8
DA
37722013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3773
3774 * window.h (struct window): Replace hchild, vchild and buffer slots
3775 with the only contents slot. This is possible because each valid
3776 window may have either the child window (in vertical or horizontal
3777 combination) or buffer to display (for the leaf window). Using that,
3778 a lof of operations to traverse and/or change window hierarchies may
3779 be simplified. New member horizontal is used to distinguish between
3780 horizontal and vertical combinations of internal windows.
3781 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3782 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3783 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3784 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3785 Use contents slot, not buffer, where appropriate.
3786 (wset_combination): New function.
3787 (wset_buffer): Add eassert.
3788 (Fframe_first_window): Simplify the loop reaching first window.
3789 (Fwindow_buffer): Use WINDOW_LEAF_P.
3790 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3791 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3792 (unshow_buffer): Convert initial debugging check to eassert.
3793 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3794 (make_parent_window, window_resize_check, window_resize_apply)
3795 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3796 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3797 Adjust to match struct window changes.
3798 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3799 (mark_window_cursors_off, count_windows, get_leaf_windows)
3800 (foreach_window_1): Simplify the loop.
3801 * alloc.c (mark_object): Do not check for the leaf window because
3802 internal windows has no glyph matrices anyway.
3803 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3804 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3805 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3806 (build_frame_matrix_from_window_tree, mirror_make_current)
3807 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3808 (update_window_tree, set_window_update_flags): Simplify the loop.
3809 (sync_window_with_frame_matrix_rows): Enforce live window.
3810 Use contents slot, not buffer, where appropriate.
3811 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3812 and WINDOW_HORIZONTAL_COMBINATION_P.
3813 (make_frame_visible_1): Simplify the loop.
3814 Use contents slot, not buffer, where appropriate.
3815 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3816 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3817 (expose_window_tree): Likewise.
3818 Use contents slot, not buffer, where appropriate.
3819 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3820 to avoid deleted windows. Use contents slot instead of buffer.
3821 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3822 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3823 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3824 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3825
121ab1cd
EZ
38262013-03-28 Eli Zaretskii <eliz@gnu.org>
3827
ef454cf7
EZ
3828 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3829 identify the reasons for assertion violations in bug#14062 and
3830 similar ones.
21e930f8
EZ
3831 (Fx_show_tip): Fix compilation error under
3832 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3833
121ab1cd
EZ
3834 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3835 Reported by <rzl24ozi@gmail.com>.
3836
5c89ca24
DA
38372013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3838
3839 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3840 start marker...
562c6ee9
SM
3841 (unwind_with_echo_area_buffer): ...to restore it here.
3842 This is needed to ensure that...
5c89ca24
DA
3843 (redisplay_window): ...both window markers are valid here,
3844 which is verified by eassert.
3845 * editfns.c (save_excursion_save): Do not assume that
3846 selected_window always displays the buffer.
c7f53895
DA
3847 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3848 Fix comment.
5c89ca24 3849
f557c1b1
SM
38502013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3851
3852 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3853 the upcase table.
3854
40693bba 38552013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3856
3857 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3858
c86f791f
EZ
38592013-03-27 Eli Zaretskii <eliz@gnu.org>
3860
3861 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3862 since MinGW's w32api headers do. This avoids compiler warnings.
3863
3864 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3865 if already defined.
3866
c6e72e17
EZ
38672013-03-26 Eli Zaretskii <eliz@gnu.org>
3868
3869 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3870
54e95010
JD
38712013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3872
3873 * gtkutil.c (style_changed_cb): Check if frame is live and an
3874 X frame (Bug#14038).
3875
b88b62de
EZ
38762013-03-26 Eli Zaretskii <eliz@gnu.org>
3877
a18d7de6
EZ
3878 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3879 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3880 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3881 MinGW64.
8f5e14c8
EZ
3882 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3883 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3884
b88b62de
EZ
3885 Fix incompatibilities between MinGW.org and MinGW64 headers.
3886 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3887
3888 * w32.c (REPARSE_DATA_BUFFER): Guard with
3889 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3890
c074e458
JD
38912013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3892
3893 * xterm.c: Include X11/XKBlib.h
3894 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3895
908589fd
AS
38962013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3897
3898 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3899 written backwards.
3900 * blockinput.h (input_blocked_p): Likewise.
3901 * bytecode.c (exec_byte_code): Likewise.
3902 * callproc.c (call_process_kill, call_process_cleanup)
3903 (Fcall_process): Likewise.
3904 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3905 (Fccl_execute_on_string): Likewise.
3906 * character.c (string_escape_byte8): Likewise.
3907 * charset.c (read_hex): Likewise.
3908 * cm.c (calccost): Likewise.
3909 * data.c (cons_to_unsigned): Likewise.
3910 * dired.c (directory_files_internal, file_name_completion):
3911 Likewise.
3912 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3913 (sit_for): Likewise.
3914 * doc.c (Fsubstitute_command_keys): Likewise.
3915 * doprnt.c (doprnt): Likewise.
3916 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3917 * emacsgtkfixed.c: Likewise.
3918 * fileio.c (file_offset, Fwrite_region): Likewise.
3919 * floatfns.c (Fexpt, fmod_float): Likewise.
3920 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3921 Likewise.
3922 * font.c (font_intern_prop): Likewise.
3923 * frame.c (x_set_alpha): Likewise.
3924 * gtkutil.c (get_utf8_string): Likewise.
3925 * indent.c (check_display_width): Likewise.
3926 * intervals.c (create_root_interval, rotate_right, rotate_left)
3927 (split_interval_right, split_interval_left)
3928 (adjust_intervals_for_insertion, delete_node)
3929 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3930 (merge_interval_right, merge_interval_left, copy_intervals)
3931 (set_intervals_multibyte_1): Likewise.
3932 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3933 * keymap.c (Fkey_description): Likewise.
3934 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3935 * lread.c (openp, read_integer, read1, string_to_number):
3936 Likewise.
3937 * menu.c (ensure_menu_items): Likewise.
3938 * minibuf.c (read_minibuf_noninteractive): Likewise.
3939 * print.c (printchar, strout): Likewise.
3940 * process.c (create_process, Faccept_process_output)
3941 (wait_reading_process_output, read_process_output, send_process)
3942 (wait_reading_process_output): Likewise.
3943 * profiler.c (make_log, handle_profiler_signal): Likewise.
3944 * regex.c (re_exec): Likewise.
3945 * regex.h: Likewise.
3946 * search.c (looking_at_1, Freplace_match): Likewise.
3947 * sysdep.c (get_child_status, procfs_ttyname)
3948 (procfs_get_total_memory): Likewise.
3949 * systime.h (EMACS_TIME_VALID_P): Likewise.
3950 * term.c (dissociate_if_controlling_tty): Likewise.
3951 * window.c (get_phys_cursor_glyph): Likewise.
3952 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3953 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3954 Likewise.
3955 * xfns.c (Fx_window_property): Likewise.
3956 * xmenu.c (set_frame_menubar): Likewise.
3957 * xselect.c (x_get_window_property, x_handle_dnd_message):
3958 Likewise.
3959 * xsmfns.c (smc_save_yourself_CB): Likewise.
3960 * xterm.c (x_scroll_bar_set_handle): Likewise.
3961
2bf7d27a
DA
39622013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3963
3964 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3965 to be optional or nil. Adjust comment and convert it to docstring.
3966 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3967 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3968
a9ebfa0b
PE
39692013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3970
3971 Static checking by GCC 4.8-20130319.
3972 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3973 * process.c (Fset_process_datagram_address)
3974 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3975 * xdisp.c (get_char_face_and_encoding):
3976 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3977 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3978 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3979
4f3576ee
KB
39802013-03-24 Ken Brown <kbrown@cornell.edu>
3981
789b5e9a
KB
3982 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3983 fix compilation on 64-bit Cygwin, where underscores are not
3984 automatically prepended.
3985
4f3576ee
KB
3986 * w32term.c (w32_initialize): Silence compiler warning.
3987
b5b7745f
EZ
39882013-03-23 Eli Zaretskii <eliz@gnu.org>
3989
cdc0d0bd
EZ
3990 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3991 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3992 variables, to save and restore frame dimensions.
3993 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3994 after returning from a 'fullscreen' configuration.
3995 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3996 to avoid races between the main thread and the input thread.
3997
3998 * w32term.h (struct w32_output): New members normal_width,
3999 normal_height, normal_top, normal_left, and prev_fsmode.
4000 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4001 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4002 members of a frame.
4003
b5b7745f
EZ
4004 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4005 'fullscreen' parameter. Always record previous width and height
4006 of the frame, except when switching out of maximized modes, so
4007 that they could be restored correctly, instead of resetting to the
4008 default frame dimensions. Send SC_RESTORE command to the frame,
4009 unless we are going to send SC_MAXIMIZE, to restore the frame
4010 resize hints in the mouse pointer shown by the window manager.
4011 (Bug#14032)
4012
4013 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4014
4015 * lisp.h (get_frame_param): Adjust conditions for prototype
4016 declaration.
4017
a3454eed
KB
40182013-03-22 Ken Brown <kbrown@cornell.edu>
4019
4020 * unexcw.c: Drop unneeded inclusion of w32common.h.
4021 (report_sheap_usage): Declare.
4022 (read_exe_header): Add magic numbers for x86_64.
4023 (fixup_executable): Fix printf format specifier for unsigned long
4024 argument.
4025
5a49b79c
DA
40262013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4027
4028 * frame.h (struct frame): Put menu_bar_window under #ifdef
4029 because this member is not needed when X toolkit is in use.
4030 (fset_menu_bar_window):
4031 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4032 (free_glyphs, update_frame):
4033 * xdisp.c (expose_frame): Likewise.
4034 (display_menu_bar): Likewise. Remove redundant eassert.
4035 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4036 toolkit is in use.
4037
d6723bf7
PE
40382013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4039
7b1123d8
PE
4040 Use functions and constants to manipulate Lisp_Save_Value objects.
4041 This replaces code that used macros and strings and token-pasting.
4042 The change makes the C source a bit easier to follow,
4043 and shrinks the Emacs executable a bit.
4044 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4045 (make_save_value): Change 1st arg from string to enum. All callers
4046 changed.
4047 (INTX): Remove.
4048 (mark_object): Use if, not #if, for GC_MARK_STACK.
4049 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4050 (XSAVE_OBJECT): Now functions, not macros.
4051 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4052 the constant was never used.
4053 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4054 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4055 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4056 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4057 New constants.
4058 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4059 type3 with a single member save_type. All uses changed.
4060 (save_type, set_save_pointer, set_save_integer): New functions.
4061 * print.c (PRINTX): Remove.
4062
d6723bf7
PE
4063 * alloc.c: Remove redundant static declarations.
4064
5f24fa51
DA
40652013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4066
4067 * window.h (struct window): Convert left_col, top_line, total_lines
4068 and total_cols from Lisp_Objects to integers. Adjust comments.
4069 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4070 Remove.
4071 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4072 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4073 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4074 Adjust users where appropriate.
4075
42143acd
DA
40762013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4077
4078 * frame.h (struct frame): Drop resx and resy because the same data is
4079 available from window system-specific output context. Adjust users.
562c6ee9
SM
4080 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4081 New functions to provide defaults when no window system available.
42143acd 4082 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4083 (NUMVAL): Move from xdisp.c.
42143acd
DA
4084 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4085 (Ffont_face_attributes, Fopen_font):
4086 * image.c (gs_load):
4087 * w32font.c (fill_in_logfont):
4088 * xdisp.c (calc_pixel_width_or_height):
4089 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4090 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4091
c0a17406
KH
40922013-03-20 Kenichi Handa <handa@gnu.org>
4093
4094 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4095 to 1 (temporary workaround until a bug related to ASCII
4096 optimization is fixed).
4097
095d384d
DA
40982013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4099
4100 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4101 Signal error if window is not internal. Adjust docstring.
4102 (delete_all_child_windows): Use combination_limit to save the buffer.
4103 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4104 * print.c (syms_of_print): Initialize debugging output not here...
4105 (init_print_once): ...but in a new function here.
4106 * lisp.h (init_print_once): Add prototype.
4107 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4108
748fa866
DA
41092013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4110
4111 * window.c (window_resize_check, window_resize_apply)
4112 (window_from_coordinates, recombine_windows, set_window_buffer)
4113 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4114 (Fsplit_window_internal, Fdelete_window_internal)
4115 (freeze_window_starts): Use bool for booleans.
4116 * window.h (window_frame_coordinates, resize_frame_windows)
4117 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4118
81519fd2
SM
41192013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4120
4121 * dispnew.c (bitch_at_user): Use `user-error'.
4122
6db423a9
KB
41232013-03-17 Ken Brown <kbrown@cornell.edu>
4124
4125 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4126 as return type of image_background. (Bug#13981)
4127 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4128
8f2906f5
JD
41292013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4130
960ce480 4131 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4132 (ns_select): Don't return with result uninitialized.
960ce480 4133
8f2906f5
JD
4134 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4135 and getDirectory.
4136
81519fd2
SM
4137 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4138 New functions.
8f2906f5
JD
4139 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4140 directories. If filename is nil, get directory name (Bug#13932).
4141 Use getFilename and getDirectory.
4142 (getFilename, getDirectory): New methods for EmacsSavePanel and
4143 EmacsOpenPanel.
4144 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4145
cded56c1
PE
41462013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4149
251e9147 41502013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4151
4152 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4153 (adjust_after_replace): Make it back to static. Delete the third
4154 arg text_at_gap_tail. Cancel the code for handling it.
4155
4156 * coding.h (struct coding_system): New member eol_seen.
4157
4158 * coding.c (detect_ascii): New function.
4159 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4160 when the source bytes are actually scanned. On detecting for
4161 coding_category_utf_8_auto, call detect_ascii instead of scanning
4162 source bytes directly.
4163 (produce_chars): Call insert_from_gap with the new arg 0.
4164 (encode_coding): Likewise.
4165 (decode_coding_gap): Control ASCII optimization by the variable
4166 disable_ascii_optimization instead of #ifndef .. #endif.
4167 Deccode EOL format according to coding->eol_seen.
4168 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4169 variable.
4170
8a44e6d1
KH
4171 * lisp.h (adjust_after_replace): Cancel externing it.
4172 (insert_from_gap): Adjust prototype.
4173
5f795e34
EZ
41742013-03-15 Eli Zaretskii <eliz@gnu.org>
4175
4176 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4177 FULLSCREEN_MAXIMIZED. (Bug#13935)
4178
f258b4be
DA
41792013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4180
4181 * region-cache.c (find_cache_boundary, move_cache_gap)
4182 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4183 Simplify debugging check and convert to eassert. Adjust comment.
4184 (pp_cache): Put under ENABLE_CHECKING.
4185
a5cc4dde
EZ
41862013-03-14 Eli Zaretskii <eliz@gnu.org>
4187
4188 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4189 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4190 and WM_ACTIVATEAPP.
4191 (w32fullscreen_hook): If the frame is visible, reset
4192 f->want_fullscreen flag after changing the frame size. If the
4193 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4194 (Bug#13953)
4195
3fc5e44a
DC
41962013-03-13 Daniel Colascione <dancol@dancol.org>
4197
4198 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4199 too so that these builds can use Cygwin's file conversion
4200 functions. (We've been building and linking cygw32.o all along
4201 and just not using it.)
4202
47d7532e
PE
42032013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4204
4205 File synchronization fixes (Bug#13944).
4206 * Makefile.in (LIB_FDATASYNC): New macro.
4207 (LIBES): Use it.
4208 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4209 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4210 Don't worry about HAVE_FSYNC, since a substitute fsync is
4211 available if the system lacks one.
4212 (Fwrite_regin): Retry fsync if interrupted.
4213
c7ffccaf
EZ
42142013-03-13 Eli Zaretskii <eliz@gnu.org>
4215
4e2df81d 4216 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4217 activated, call w32fullscreen_hook, to make sure the new frame
4218 dimensions are in effect. (Bug#13937)
4219
8a7debc1
DA
42202013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4221
4222 * xdisp.c (init_iterator): Simplify because both character and byte
4223 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4224 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4225 character and byte positions can be obtained from marker.
8a7debc1 4226
7fd8c501
PE
42272013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4228
d9df6f40
PE
4229 Static checking by Sun C 5.12.
4230 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4231 * bytecode.c (exec_byte_code):
4232 * dispnew.c (init_display):
4233 * eval.c (error):
4234 * fileio.c (Fsubstitute_in_file_name):
4235 * keyboard.c (Fevent_convert_list):
4236 * keymap.c (Fsingle_key_description):
4237 * term.c (maybe_fatal, fatal):
4238 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4239 * xsmfns.c (Fhandle_save_session):
4240 Omit unreachable code.
4241 * keymap.c (map_keymap_char_table_item): Cast void * to
4242 a function pointer type; the C Standard requires this.
4243
7fd8c501
PE
4244 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4245 Include <sys/param.h> unconditionally, as that works elsewhere and
4246 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4247 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4248 and FreeBSD now.
4249
a020afb9 4250See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4251
4252;; Local Variables:
4253;; coding: utf-8
aac0c6e3
MR
4254;; End:
4255
ab422c4d 4256 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4257
4258 This file is part of GNU Emacs.
4259
4260 GNU Emacs is free software: you can redistribute it and/or modify
4261 it under the terms of the GNU General Public License as published by
4262 the Free Software Foundation, either version 3 of the License, or
4263 (at your option) any later version.
4264
4265 GNU Emacs is distributed in the hope that it will be useful,
4266 but WITHOUT ANY WARRANTY; without even the implied warranty of
4267 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4268 GNU General Public License for more details.
4269
4270 You should have received a copy of the GNU General Public License
4271 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.