Utility function and macro to copy Lisp string to C string.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5b71542d
DA
12013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Utility function and macro to copy Lisp string to C string.
4 * lisp.h (xlispstrdupa): New macro.
5 (xlispstrdup): New prototype.
6 * alloc.c (xlispstrdup): New function.
7 * callint.c (Fcall_interactively):
8 * fileio.c (Ffile_name_directory, Fexpand_file_name)
9 (Fsubstitute_in_file_name):
10 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
11 * image.c (x_create_bitmap_from_file):
12 * w32term.c (w32_term_init):
13 * xterm.c (x_term_init): Use xlispstrdup.
14
71530c97
LMI
152013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
16
4ce82fb8
LMI
17 * image.c (imagemagick_load_image): Make animated pictures work.
18 There's still some problems with background color settings, though
19 (bug#14700).
20
71530c97
LMI
21 * decompress.c (unwind_decompress): Always restore point.
22
7510a061
XF
232013-08-14 Xue Fuqiao <xfq.free@gmail.com>
24
25 * marker.c (set_marker): Reformat documentation.
26
01c3051f
PE
272013-08-14 Paul Eggert <eggert@cs.ucla.edu>
28
aab1fcdf
PE
29 * xdisp.c (cursor_type_changed): Now static.
30
01c3051f
PE
31 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
32 Use changed. This avoids the need to call xmalloc and for the
33 caller to call xfree, and avoids memory leaks in some situations.
34
2084152a
DA
352013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
36
37 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
38 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
39 (redisplay_window): If window_end_valid is cleared due to non-zero
40 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
41 so do not call to try_cursor_movement for that window.
2084152a 42
02455cb6
DA
432013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
44
45 * window.h (struct window): Convert window_end_pos and
46 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
47 (wset_window_end_pos, wset_window_end_vpos): Remove.
48 * dispnew.c (adjust_glyph_matrix):
49 * window.c (Fwindow_end, replace_window, set_window_buffer)
50 (make_window):
51 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
52 (set_vertical_scroll_bar, redisplay_window, try_window)
53 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
54 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
55 (note_mouse_highlight): Adjust users.
56 (try_cursor_movement): Likewise. Convert old precondition to eassert.
57 Add comment.
58
da5707e8
DA
592013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
60
61 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
62 * image.c (imagemagick_filename_hint): Use `const char *' and
63 prefer SSDATA to SDATA to avoid warnings.
64
25554267
DA
652013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
66
67 Cleanup window fringes, margins and scroll bars adjustments.
68 * window.c (set_window_fringes, set_window_margins)
69 (set_window_scroll_bars, apply_window_adjustment): New functions.
70 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
71 (Fset_window_scroll_bars): Use them.
72
38a2c910
DA
732013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
74
75 * window.h (struct window): Convert scroll_bar_width
76 from Lisp_Object to integer. Adjust comment.
77 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
78 Adjust users.
79 * window.c (wset_scroll_bar_width): Remove.
80 (make_window): Initialize scroll_bar_width.
81 (Fsplit_window_internal): Use direct assignment.
82 (Fset_window_configuration, save_window_save):
83 Convert Lisp_Object to integer and back where appropriate.
84 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
85 bar was actually changed, and mention this in docstring.
86
2d065031
PE
872013-08-13 Paul Eggert <eggert@cs.ucla.edu>
88
89 * decompress.c: Minor simplifications.
90 (Fzlib_decompress_region): Don't bother verifying
91 that avail_out <= UINT_MAX, as that was confusing.
92 Mention the restriction in a comment instead.
93 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
94
a5bd5abb
JD
952013-08-13 Jan Djärv <jan.h.d@swipnet.se>
96
97 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
98 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
99
66e7901a
LMI
1002013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
101
102 * image.c (imagemagick_filename_hint): Check for errors in the
103 alist structure.
104
2fa611b7
EZ
1052013-08-13 Eli Zaretskii <eliz@gnu.org>
106
107 * window.c (Fwindow_margins): Return nil when there's no marginal
108 area, as per the documented API.
109
110 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
111 Fmake_vector, as scroll bar's struct members are not all Lisp
112 objects now. This avoids crashes in GC.
113
114 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
115 bool, so its address could be taken.
116
8259030d
LMI
1172013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
118
119 * image.c (imagemagick_filename_hint): New function to possibly
120 apply `image-content-type-suffixes'.
121 (imagemagick_load_image): Use it.
122
866c710e
EZ
1232013-08-13 Eli Zaretskii <eliz@gnu.org>
124
125 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
126 if loading zlib failed.
127
f10490f0
JD
1282013-08-13 Jan Djärv <jan.h.d@swipnet.se>
129
96311be7
JD
130 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
131 2013-08-13 checkin below. Change bool to BOOL, rule is:
132 All Obj-C code uses BOOL, except for interfaces callable from C.
133
f10490f0
JD
134 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
135
c8ae93b0
DA
1362013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
137
138 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
139 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
140 bool instead of BOOL.
141 * w32term.h (struct scroll_bar): Convert fringe_extended_p
142 from Lisp_Object to bitfield. Adjust comment.
143 * w32term.c (x_scroll_bar_create): Adjust user.
144 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
145 * xterm.c (XTset_vertical_scroll_bar): Likewise.
146 Use bool for boolean.
147 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
148 to `unsigned int' when defining a bitfield.
149
53b64418
PE
1502013-08-13 Paul Eggert <eggert@cs.ucla.edu>
151
152 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
153
eeaf9bf3
DA
1542013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
155
156 * window.h (struct window): Convert left_margin_cols and
157 right_margin_cols from Lisp_Objects to integers. Adjust comment.
158 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
159 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
160 Adjust users.
161 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
162 Adjust comment.
163 (showing_window_margins_p, update_window_line, update_frame_1):
164 * fringe.c (draw_fringe_bitmap_1):
165 * xdisp.c (window_box_width): Adjust users.
166 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
167 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
168 Use direct assignment.
169 (Fset_window_configuration, save_window_save, Fwindow_margins):
170 Convert Lisp_Object to integer and back where appropriate.
171 (Fset_window_margins): Adjust user. Return t if any margin
172 was actually changed, and mention this in docstring.
173
956720af
XF
1742013-08-13 Xue Fuqiao <xfq.free@gmail.com>
175
f73f4ce6 176 * syntax.c (forward_word):
956720af
XF
177 * cmds.c (forward_char, backward_char): Mention the optional argument.
178
9e37ee3b
DA
1792013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
180
181 * window.h (struct window): Convert left_fringe_width
182 and right_fringe_width from Lisp_Objects to integers.
183 Adjust comment.
184 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
185 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
186 * window.c (wset_left_fringe_width, wset_right_fringe_width):
187 Remove.
188 (make_window): Initialize new integer fields to -1.
189 (Fsplit_window_internal): Use direct assignment.
190 (Fset_window_configuration, save_window_save): Convert
191 Lisp_Object to integer and back where appropriate.
192 (Fset_window_fringes): Adjust user. Return t if any fringe
193 was actually changed, and mention this in docstring.
194
e4375ca7
DA
1952013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
196
197 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
198 * nsfns.m (x_set_cursor_type):
199 * w32fns.c (x_set_cursor_type):
200 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
201 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 202
a45543bc
DA
2032013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
204
205 * font.c (clear_font_cache): New function, stripped from...
206 (Fclear_font_cache): ...here, which now uses the function
207 above. Adjust comment.
208 * font.h (clear_font_cache): Add prototype.
209 * xfaces.c (clear_face_cache): Use clear_font_cache.
210
ae966a86
DA
2112013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
212
213 * window.c (Fset_window_start): Compare `w', not `window' because
214 `w' might not be equal to `window' after call to decode_live_window.
215
297a545b
PE
2162013-08-12 Paul Eggert <eggert@cs.ucla.edu>
217
218 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
219 This fixes a problem introduced by the Bug#15035 patch
220 when using GPG. Reported by Herbert J. Skuhra.
221
aa942e2b
EZ
2222013-08-12 Eli Zaretskii <eliz@gnu.org>
223
224 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
225 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
226 not yet initialized.
227
7699d09e
LMI
2282013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
229
230 * decompress.c (Fzlib_decompress_region): Support zlib
231 decompression, too, and rename.
232
1d238bc7
PE
2332013-08-12 Paul Eggert <eggert@cs.ucla.edu>
234
235 Minor zlib configuration tweaks.
236 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
237 Don't assume presence of fn_inflateInit2_ zlib internal function.
238
8a44a184
LMI
2392013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
240
241 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
242 include the zlib prefix.
243
594a4307
EZ
2442013-08-12 Eli Zaretskii <eliz@gnu.org>
245
246 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
247 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
248 define static variables that are pointers to zlib functions to be
249 dynamically loaded.
250 (init_zlib_functions) [WINDOWSNT]: New function.
251 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
252 New macros.
253 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
254 macros instead of invoking the zlib functions directly.
255 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
256 Szlib_available_p.
257
d2e113bc
DA
2582013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
259
260 Avoid looping over all frame windows to freeze and unfreeze.
261 * window.h (struct window): Drop frozen_window_start_p.
262 (freeze_window_starts): Drop prototype.
263 * frame.h (struct frame): New frozen_window_starts flag.
264 (FRAME_WINDOWS_FROZEN): New macro.
265 * window.c (freeze_window_start, freeze_window_starts):
266 Remove.
267 (select_window, replace_window): Adjust users.
268 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
269 (window_frozen_p): New function.
270 (redisplay_window): Use it.
271
94fcd171
PE
2722013-08-12 Paul Eggert <eggert@cs.ucla.edu>
273
274 Fix some fd issues when running subprocesses (Bug#15035).
275 Fix bugs that can leak files or file descriptors on errors.
276 Don't unlink open temp files, as that's hard for users to diagnose
277 when things go awry (e.g., temp disk exhausted).
278 Don't bother to lock temp files. Check for invalid recursion.
279 * callproc.c (synch_process_fd): Remove. All uses removed.
280 (synch_process_tempfile): New var or macro.
281 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
282 New constants.
283 (record_kill_process): New arg, the temp name. All callers changed.
284 (delete_temp_file): Now just a simple wrapper around unlink.
285 (call_process_kill): New arg, the call_process_fd array.
286 Close them all. Clear synch_process_pid. Remove the temp file,
287 or arrange for it to be removed.
288 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
289 that's been moved to synch_process_tempfile. Caller changed.
290 Do not remove the tempfile; that's now call_process_kill's
291 responsibility.
292 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
293 call_process_kill; the caller now does that.
294 (call_process_cleanup): Do not close the process fd; that's now
295 call_process_kill's responsibility.
296 (Fcall_process): Implement via new function call_process, which
297 has most of the old body of Fcall_process, but with a different API.
298 (call_process): New function that does not open or close filefd if
299 it is nonnegative. Record which fds need to be closed, and let
300 call_process_kill close (and remove the tempfile, on MSDOS) on error.
301 Signal an error if invoked recursively (could be done via a hook).
302 Simplify creation of the tempfile in the MSDOS case.
303 Don't create the output file until after checking for the executable.
304 Report any failure to open /dev/null.
305 Don't open /dev/null for writing twice; once is enough.
306 Don't create pipe if all output is being discarded or sent to file.
307 Don't worry about setting up the coding system or reading from the
308 pipe if all output is being discarded.
309 Hoist fd_error local into top level, to lessen block nesting.
310 Don't record deleted pid here; now done by Fcall_process_region.
311 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
312 and note its success in synch_process_tempfile.
313 Do not leak resources when child_setup fails.
314 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
315 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
316 (create_temp_file): Now returns open fd, with an additional
317 Lisp_Object * argument to return the name. All callers changed.
318 Do not close the file; rewind it instead, and leave it open for
319 the caller. Do not lock the temp file. Unwind-protect the file
320 and the file-descriptor.
321 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
322 If an asynchrounous process, record it here, not in call_process.
323 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
324 * eval.c (set_unwind_protect): New function.
325 * fileio.c (write_region): New function, generalized from the
326 old Fwrite_region. Do not lock temp files.
327 (Fwrite_region): Use it.
328 * lisp.h (set_unwind_protect, write_region): New decls.
329 * process.c: Include <verify.h>.
330 (make_process): Mark fds as initially closed.
331 (deleted_pid_list): Now a list of pid-filename pairs.
332 All uses changed.
333 (close_process_fd): New function.
334 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
335 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
336 New constants. Verify that their number matches PROCESS_OPEN_FDS.
337 (create_process, create_pty, Fmake_serial_process)
338 (server_accept_connection): Record which fds need to be closed,
339 and let deactivate_process close them.
340 (Fmake_network_process): Do not discard the unwind-protect
341 until it's safe to do so.
342 (deactivate_process): Close the fds opened by create_process etc.
343 (Fprocess_send_eof): Adjust to new way of recording open fds.
344 Report an error if /dev/null can't be opened, instead of aborting.
345 * process.h (PROCESS_OPEN_FDS): New constant.
346 (struct Lisp_Process): New member open_fds.
347 (record_kill_process, record_deleted_pid): Adjust signatures.
348 (record_deleted_pid): Move decl here ...
349 * syswait.h (record_deleted_pid): ... from here.
350
d0e615c3
PE
3512013-08-11 Paul Eggert <eggert@cs.ucla.edu>
352
353 * decompress.c: Fix bugs with large buffers and weird inputs.
354 Tune a bit. Reindent as per usual Emacs style.
355 (BUFFER_SIZE): Remove.
356 (Fdecompress_gzipped_region): Do not mishandle input buffers with
357 more than UINT_MAX bytes. Decompress into the gap instead of into
358 an auto buffer, as this should avoid copying. Return nil if
359 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
360 set immediate_quit; we shouldn't trust zlib code that much.
361
313546eb
LMI
3622013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
363
99a32242
LMI
364 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
365 errors, and really move the gap to where we want it.
366
313546eb
LMI
367 * lisp.h: Include decompress.c support.
368
369 * emacs.c (main): Include decompress.c support.
370
371 * Makefile.in: Include -lz if present.
372
d2d699ac
JD
3732013-08-11 Jan Djärv <jan.h.d@swipnet.se>
374
f90e3ebd
JD
375 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
376 (initWithTitle:): Initialize frame to 0.
377 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
378 (fillWithWidgetValue:frame:): Renamed from
379 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
380
381 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
382 fillWithWidgetValue:frame:
383
423d3b3f
JD
384 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
385 remove memory leak warnings.
386
d2d699ac
JD
387 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
388 (ns_check_menu_open): Handle menu == nil. Remove assignment to
389 menu_pending_title.
390
391 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
392 (x_activate_menubar): Update the whole menu.
393 (trackingNotification:): Call ns_check_menu_open if tracking ends.
394 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
395 current event is not NSSystemDefined (Bug#15001).
396 Call ns_check_menu_open only if trackingMenu is 2.
397 (menuDidClose:): New method, decrease trackingMenu.
398 (fillWithWidgetValue:setDelegate:): New method.
399 (fillWithWidgetValue:): Call the above.
400
401 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
402
7d652d97
PE
4032013-08-11 Paul Eggert <eggert@cs.ucla.edu>
404
405 Omit some unnecessary casts.
406 Many of these go back to the old pre-C89 days, when they may have
407 been needed, but we've been assuming C89 or later for a while now.
408 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
409 (live_float_p, live_misc_p, live_vector_p):
410 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
411 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
412 (defvar_per_buffer):
413 * callint.c (Fcall_interactively):
414 * doc.c (Fsubstitute_command_keys):
415 * filelock.c (get_boot_time):
416 * frame.c (xrdb_get_resource):
417 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
418 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
419 (xg_get_file_name_from_selector, menuitem_destroy_callback)
420 (menuitem_highlight_callback, menu_destroy_callback)
421 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
422 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
423 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
424 (xg_tool_bar_help_callback, tb_size_cb):
425 * image.c (xpm_alloc_color, png_read_from_memory)
426 (png_read_from_file, png_load_body, our_memory_skip_input_data)
427 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
428 (syms_of_image):
429 * keymap.c (describe_map):
430 * nsfns.m (Fns_display_monitor_attributes_list):
431 * nsmenu.m (process_dialog:):
432 * nsterm.m (hold_event):
433 * process.c (wait_reading_process_output):
434 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
435 * scroll.c (do_direct_scrolling, scrolling_1):
436 * termcap.c (tgetent):
437 * window.c (check_window_containing, add_window_to_list)
438 (freeze_window_starts):
439 * xdisp.c (compare_overlay_entries, vmessage):
440 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
441 (x_get_monitor_attributes_xrandr)
442 (Fx_display_monitor_attributes_list, x_display_info_for_name)
443 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
444 * xfont.c (xfont_match, xfont_open):
445 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
446 (menubar_selection_callback, menu_position_func)
447 (popup_selection_callback, create_and_show_popup_menu)
448 (dialog_selection_callback, create_and_show_dialog):
449 * xrdb.c (x_get_string_resource):
450 (main) [TESTRM]:
451 * xsmfns.c (x_session_check_input):
452 * xterm.c (x_draw_glyphless_glyph_string_foreground)
453 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
454 (xaw_jump_callback, xaw_scroll_callback):
455 Omit unnecessary casts.
456
9acc1074
PE
4572013-08-10 Paul Eggert <eggert@cs.ucla.edu>
458
459 Minor string-length refactoring.
460 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
461 * frame.c (make_monitor_attribute_list):
462 Prefer build_string to strlen + make_string.
463
361c0eb8
JD
4642013-08-10 Jan Djärv <jan.h.d@swipnet.se>
465
466 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
467 don't check minor_code (Bug#14417).
468
14ba0822
EZ
4692013-08-09 Eli Zaretskii <eliz@gnu.org>
470
471 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
472 vertical positions instead. This avoids calling MATRIX_ROW with
473 row numbers that are possibly beyond valid limits. (Bug#15064)
474
309f24d1
DA
4752013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
476
477 Use xstrdup and build_unibyte_string where applicable.
478 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
479 * xfns.c (x_window):
480 * xrdb.c (x_get_customization_string):
481 * xterm.c (xim_initialize):
482 * w32fns.c (w32_window): Use xstrdup.
483 (w32_display_monitor_attributes_list):
484 * emacs.c (init_cmdargs):
485 * keyboard.c (PUSH_C_STR):
486 * nsfont.m (nsfont_open):
487 * sysdep.c (system_process_attributes):
488 * w32.c (system_process_attributes):
489 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
490
55902276
EZ
4912013-08-09 Eli Zaretskii <eliz@gnu.org>
492
493 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
494 variables of these types so that GDB would know about them, as aid
495 for debugging fatal exceptions. (Bug#15024) See also
496 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
497 discussions.
498
10bf7f5a
JD
4992013-08-08 Jan Djärv <jan.h.d@swipnet.se>
500
501 * nsterm.m (ns_update_begin): Don't change clip path if it would be
502 larger than the NSWindow (Bug#14934).
503
65620264
DA
5042013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
505
506 Redesign redisplay interface to drop global variable updated_window.
507 Always pass currently updated window as a parameter to update routines.
508 * dispextern.h (updated_window): Remove declaration.
509 (struct redisplay_interface): Pass window parameter to
510 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
511 and after_update_window_hook.
512 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
513 Adjust prototypes.
514 * dispnew.c (updated_window): Remove.
515 (redraw_overlapped_rows, update_marginal_area, update_text_area)
516 (update_window_line): Adjust to match redisplay interface changes.
517 * nsterm.m (ns_update_window_begin, ns_update_window_end)
518 (ns_scroll_run, ns_after_update_window_line):
519 * w32term.c (x_update_window_begin, x_update_window_end)
520 (x_after_update_window_line, x_scroll_run):
521 * xterm.c (x_update_window_begin, x_update_window_end)
522 (x_after_update_window_line, x_scroll_run):
523 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
524 Likewise. Adjust comments where appropriate.
525 (x_cursor_to): Simplify because this is always called during window
526 update (but install debugging check anyway).
527 (expose_window): Check must_be_updated_p flag to see whether this
528 function is called during window update.
529
628fdc56
DA
5302013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
531
532 Do not reset window modification event counters excessively.
533 These leftovers and poor man's tricky methods to catch extra
534 redisplay's attention are no longer needed.
535 * frame.c (set_menu_bar_lines_1):
536 * minibuf.c (read_minibuf_unwind):
537 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
538 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
539 (window_scroll_line_based, Fset_window_configuration):
540 * xdisp.c (redisplay_window): Do not reset last_modified and
541 last_overlay_modified counters.
542
8fd9c92e
JD
5432013-08-07 Jan Djärv <jan.h.d@swipnet.se>
544
545 * xselect.c (x_send_client_event): Set send_event and serial, memset
546 data.l as it might be bigger than data.b. Use 24 bit mask to
547 XSendEvent (Bug#15034).
548
0ee18172
EZ
5492013-08-07 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
552 for TTY frames that are not the top frame on their console.
553 (Bug#14616)
554
16ddd1a6
MR
5552013-08-07 Martin Rudalics <rudalics@gmx.at>
556
557 * w32term.c (w32fullscreen_hook): Really maximize frame when
558 asked for (Bug#14841).
559
d2a95ffb
DA
5602013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
561
562 Prefer selected_window to Fselected_window, likewise for frames.
563 * buffer.c (Fbuffer_swap_text):
564 * data.c (Fvariable_binding_locus):
565 * window.c (run_window_configuration_change_hook): Adjust users.
566 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
567 Use decode_live_frame.
568
170da1ec
DA
5692013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
570
571 Be more careful if selected window shows the buffer other than current,
572 use window_outdated only if this is not so. This change should also
573 address some weird issues discussed in Bug#13012.
574 * window.h (window_outdated): New prototype.
575 * window.c (window_outdated): Now here. Convert from static and
576 always assume window's buffer.
577 (Fwindow_end, Fwindow_line_height): Use it.
578 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
579 and always assume window's buffer.
580 (redisplay_window): Adjust user.
e5eefe9b 581 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
582 check whether mode line should be updated only if selected window
583 shows current buffer.
584 (run_window_scroll_functions): Use eassert for debugging check.
585 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
586
56b5d5b1
DA
5872013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
588
589 * window.c (window_scroll, window_scroll_pixel_based)
590 (window_scroll_line_based): Use bool for booleans.
591
2878ba7e
PE
5922013-08-06 Paul Eggert <eggert@cs.ucla.edu>
593
594 * process.c: Fix minor off-by-one issues in descriptor counts.
595 This shouldn't fix any real bugs, but it cleans up the code a bit.
596 (max_process_desc, max_input_desc): -1, not 0, means none.
597 All uses changed.
598 (delete_input_desc): New function.
599 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
600 (deactivate_process): Scan backwards when recomuting max_process_desc;
601 that should be faster.
602 (init_process_emacs): Initialize max_input_desc.
603
e30b79c1
DA
6042013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
605
606 Use region cache to speedup bidi_find_paragraph_start.
607 * buffer.h (struct buffer): New member bidi_paragraph_cache.
608 Rename cache_long_line_scans to cache_long_scans.
609 * buffer.c (bset_cache_long_line_scans): Rename to
610 bset_cache_long_scans.
611 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
612 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
613 into account.
614 (syms_of_buffer): Rename cache-long-line-scans to
615 cache-long-scans. Adjust docstring.
616 * search.c (newline_cache_on_off):
617 * indent.c (width_run_cache_on_off): Adjust users.
618 * bidi.c (bidi_paragraph_cache_on_off): New function.
619 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
620 * insdel.c (prepare_to_modify_buffer): Invalidate
621 bidi_paragraph_cache if enabled.
622
00012b86
DA
6232013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
624
625 Invalidate region caches only if buffer text is going to be changed.
626 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
627 (modify_text): ...new prototype.
628 (prepare_to_modify_buffer_1): New prototype.
629 * textprop.c (modify_region): Rename to...
630 (modify_text_properties): ...new function.
631 (add_text_properties_1, set_text_properties, Fremove_text_properties)
632 (Fremove_list_of_text_properties): Adjust users.
633 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
634 (modify_text): ...new function.
635 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
636 (prepare_to_modify_buffer_1): ...new function.
637 * casefiddle.c (casify_region):
638 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
639 (Ftranspose_regions): Use modify_text.
640
dc6c0eda
SM
6412013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
642
643 * lisp.mk (lisp): Add nadvice.elc.
644
8f3a2c26
DA
6452013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
646
647 New macro to iterate over live buffers similar to frames.
648 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
649 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
650 Declare buffer-related variables here to offload lisp.h.
651 * buffer.c (Vbuffer_alist): Adjust comment.
652 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
653 (other_buffer_safely):
654 * data.c (store_symval_forwarding):
655 * dispnew.c (Fframe_or_buffer_changed_p):
656 * fileio.c (Fdo_auto_save):
657 * filelock.c (unlock_all_files):
658 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
659
e0fdb694
PE
6602013-08-04 Paul Eggert <eggert@cs.ucla.edu>
661
662 Fix some minor races in hosts lacking mkostemp (Bug#15015).
663 * callproc.c (create_temp_file):
664 * filelock.c (create_lock_file):
665 Assume mkostemp, since it's now provided by Gnulib.
666
63f5c6c2
EZ
6672013-08-04 Eli Zaretskii <eliz@gnu.org>
668
669 * w32.c (mkostemp): New function.
670 (mktemp): Remove, no longer used. Most of the code reused in
671 mkostemp. (Bug#15015)
484ab239 672 (mktemp): Don't undef.
63f5c6c2 673
f0b79313
DA
6742013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
675
676 * dispnew.c (glyph_matrix_count, glyph_pool_count):
677 Move under GLYPH_DEBUG and ENABLE_CHECKING.
678 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
679 (free_glyph_pool, check_glyph_memory): Likewise for
680 all users. Adjust comments where appropriate.
681
98f638d6
PE
6822013-08-03 Paul Eggert <eggert@cs.ucla.edu>
683
684 * composite.h: Minor fixups.
685 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
686 to fix a misspelling, and change it to an inline function while
687 we're at it (it need not be a macro). All uses changed.
688 (composition_method, composition_valid_p):
689 Rewrite to avoid assignments in if-conditions.
690
75c59fb3
DA
6912013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Do not use global Lisp_Object in composition macros.
694 * composite.h (composition_temp): Remove declaration.
695 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
696 (composition_method, composition_valid_p): ...inline functions.
416a3e01 697 (compose_region): Remove the leftover.
75c59fb3
DA
698 * composite.c (composition_temp): Remove.
699 (run_composition_function, update_compositions)
700 (composition_compute_stop_pos, composition_adjust_point)
701 (Ffind_composition_internal):
702 * coding.c (handle_composition_annotation):
703 * xdisp.c (handle_composition_prop, check_point_in_composition):
704 Related users changed.
705
a10c8269
DA
7062013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
707
708 Drop FRAME_PTR typedef.
709 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
710 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
711 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
712 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
713 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
714 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
715 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
716 All related users changed.
717
a104f656
SM
7182013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
719
720 * eval.c (default_toplevel_binding): New function.
721 (Fdefvar): Use it.
722 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
723 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
724 (syms_of_eval): Export them.
725 * data.c (Fdefault_value): Micro cleanup.
726 * term.c (init_tty): Use "false".
727
4b5c9326
DA
7282013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Fix X GC leak in GTK and raw (no toolkit) X ports.
731 * xterm.c (x_free_frame_resources): If white and black relief
732 GCs are allocated, always free them here.
733 * xfns.c (x_make_gc): Omit redundant initialization.
734 * widget.c (create_frame_gcs): Remove the leftover.
735 (EmacsFrameDestroy): Do nothing because all GCs are now freed
736 in x_free_frame_resources.
737
b19aa636
JD
7382013-08-02 Jan Djärv <jan.h.d@swipnet.se>
739
740 * nsterm.m (windowWillResize:toSize:): Only change title if
741 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
742 modifying it.
743 (viewDidEndLiveResize): New method.
744
745 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
746 inside NS_IMPL_COCOA.
747
af1f7e06
DA
7482013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
749
750 * insdel.c (adjust_after_replace, replace_range, del_range_2):
751 Do not check whether undo is enabled because record_insert and
752 record_delete does that themselves.
753
65b02bb9
DA
7542013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
755
756 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
757 member which is not really used any more.
758 (FRAME_XIC_BASE_FONTNAME): Remove.
759 * xfns.c (xic_free_fontset): Adjust user.
760 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
761 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
762 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
763 (xdialog_show): Use eassert for debugging check.
7ee0f047 764 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 765
6318cde0
PE
7662013-08-01 Paul Eggert <eggert@cs.ucla.edu>
767
768 * fileio.c, fns.c (merge): Move extern decl from here ...
769 * lisp.h (merge): ... to here.
770
6c1a09ba
DA
7712013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
772
773 Fix last font-related change.
774 * w32font.h (w32font_list_internal, w32font_match_internal):
775 Fix prototype.
776 * w32uniscribe.c (uniscribe_list, uniscribe_match):
777 (uniscribe_list_family): Adjust to match font API change.
778 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
779 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
780
f8c20208
DA
7812013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
782
783 * frame.h (FRAME_MOUSE_UPDATE):
784 * nsterm.m (ns_frame_up_to_date): Omit redundant check
785 whether hlinfo->mouse_face_mouse_frame is non-NULL.
786
fdb396e2
DA
7872013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
788
789 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
790 * font.h (struct font_driver): Change list, match, and list_family
791 functions to accept struct frame * as first arg.
792 * font.c (font_score, font_compare, font_sort_entities): Remove
793 prototypes.
794 (font_sort_entities, font_list_entities, font_select_entity):
795 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
796 match font API change.
797 * xfont.c (xfont_list, xfont_match, xfont_list_family):
798 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
799 * ftxfont.c (ftxfont_list, ftxfont_match):
800 * xftfont.c (xftfont_list, xftfont_match):
801 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
802 * w32font.c (w32font_list, w32font_match, w32font_list):
803 (w32font_list_internal, w32_font_match_internal): Likewise.
804 * xfaces.c (Fx_family_fonts): Adjust user.
805
52b8a085
DA
8062013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
807
808 Do not use pure Xism x_wm_set_icon_position in non-X ports.
809 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
810 only if HAVE_X_WINDOWS is in use.
811 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
812 * nsterm.m (x_wm_set_icon_position): Remove no-op.
813 * w32term.c (x_wm_set_icon_position): Likewise.
814 * w32fns.c (x_icon): Adjust user.
815
c791c18e
DA
8162013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
817
818 * xterm.c (last_mouse_press_frame): Remove the
819 leftover which is not really used any more.
820 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
821 (x_flush): Call XFlush once per each X display, not frame.
822 This is better because this code always unconditionally skips
823 non-X frames in Vframe_list and issues the only XFlush if we
824 have more than one X frame on the same X display.
2f935d86
DA
825 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
826 Use bool for booleans.
827 (x_draw_glyph_string_background, cvt_string_to_pixel):
828 (cvt_pixel_dtor): Drop unnecessary prototypes.
829 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 830
f435830e
DA
8312013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
832
833 Drop unnecessary functions that deals with frame pixel size.
834 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
835 (x_pixel_height): Drop prototypes.
836 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
837 (x_pixel_height): Drop implementations.
838 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
839 which should be always valid for window frame.
840 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
841 * w32menu.c (Fx_popup_dialog):
842 * xmenu.c (Fx_popup_dialog): Likewise for both.
843
84231434
DA
8442013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
845
846 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
847 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
848 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
849 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
850 and mention nil frame in docstring.
84231434 851
959067a1
DA
8522013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
853
854 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
855 (x_figure_window_size): Likewise. Adjust to return long.
856 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
857 (toplevel): Move Qterminal_live_p to...
858 * terminal.c (toplevel): ...here, make it static, and...
859 (syms_of_terminal): ...DEFSYM here.
860 * frame.h (Qterminal_live_p): Remove declaration.
861 (make_frame, x_figure_window_size): Adjust prototype.
862 * nsfns.m (Fx_create_frame): Use long for window flags.
863
f4b169ce
PE
8642013-07-30 Paul Eggert <eggert@cs.ucla.edu>
865
866 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
867 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
868 Do not assume that emacs_close (INT_MAX) is a no-op.
869
bee6a2c7
DA
8702013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
871
872 * xfaces.c (make_face_cache): For struct face_cache, prefer
873 xmalloc to xzalloc and so avoid redundant call to memset.
874 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
875
d7e6881a
DA
8762013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
877
878 * fringe.c (draw_window_fringes, update_window_fringes)
879 (compute_fringe_widths):
880 * w32term.c (x_draw_glyph_string):
881 * window.c (candidate_window_p, Frecenter):
882 * xfaces.c (realize_basic_faces, realize_default_face)
883 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
884 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
885 * xfns.c (x_set_cursor_color, xic_free_xfontset):
886 * xmenu.c (Fx_menu_bar_open_internal):
887 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
888 * xsettings.c (xft_settings_event):
889 * xterm.c (x_draw_glyph_string, x_had_errors_p):
890 Use bool for booleans. Adjust style and comments where
891 appropriate.
892 * dispextern.h (draw_window_fringes, update_window_fringes)
893 (compute_fringe_widths):
894 * xterm.h (x_had_errors_p): Adjust prototype.
895
ec3058af
DA
8962013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
897
898 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
899 CHECK_LIST. Rewrite the loop to avoid useless local variable.
900
218e0637
DA
9012013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
902
903 * fns.c (toplevel): Remove comment before Fsafe_length because
904 it checks for QUIT.
905
e560aba9
PE
9062013-07-28 Paul Eggert <eggert@cs.ucla.edu>
907
908 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
909
2e5ce5de
EZ
9102013-07-28 Eli Zaretskii <eliz@gnu.org>
911
912 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
913 frame which got the message is still alive, before dereferencing
914 its pointer. (Bug#14970)
915
916 * frame.c (delete_frame): Test "this" frame's minibuffer window to
917 be a live window, before using it as such. (Bug#14970)
918
e95da6d3
EZ
9192013-07-27 Eli Zaretskii <eliz@gnu.org>
920
921 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
922 w32_detect_focus_change instead of doing part of its job by hand.
923 This fixes the problem whereby FOCUS_OUT events were not sent to
924 the event queue.
925
a8f93651
EZ
9262013-07-26 Eli Zaretskii <eliz@gnu.org>
927
fec92060
EZ
928 * process.c (Fprocess_list): Doc fix.
929
a8f93651
EZ
930 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
931 being re-exposed only if it didn't ask to become visible.
932 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
933 was previously iconified. (Bug#14841)
934 (x_iconify_frame): Mark the frame iconified.
935
d5a7a9d9
PE
9362013-07-26 Paul Eggert <eggert@cs.ucla.edu>
937
938 Fix minor problems found by static checking.
939 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
940 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
941
56ea7291
SM
9422013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
943
944 * eval.c (set_specpdl_old_value): New function.
945 (unbind_to): Minor simplification.
946 (get_backtrace_frame): New function.
947 (Fbacktrace_frame): Use it. Add `base' argument.
948 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
949 (syms_of_eval): Export backtrace-eval.
950 * xterm.c (x_focus_changed): Simplify.
951
9d611ffe
PE
9522013-07-25 Paul Eggert <eggert@cs.ucla.edu>
953
954 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
955
999c74e3
EZ
9562013-07-24 Eli Zaretskii <eliz@gnu.org>
957
958 * xdisp.c (redisplay_window): Instead of moving point out of
959 scroll margin, reject the force_start method, and try scrolling
960 instead. (Bug#14780)
961
198fa217
KB
9622013-07-24 Ken Brown <kbrown@cornell.edu>
963
964 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
965 (Bug#14944).
966
53840e55
PE
9672013-07-24 Paul Eggert <eggert@cs.ucla.edu>
968
969 * eval.c (Fprogn): Do not check that BODY is a proper list.
970 This undoes the previous change. The check slows down the
971 interpreter, and is not needed to prevent a crash. See
972 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
973
60967f56
GM
9742013-07-23 Glenn Morris <rgm@gnu.org>
975
976 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
977
9ca960e2
PE
9782013-07-23 Paul Eggert <eggert@cs.ucla.edu>
979
a29c3e6d
PE
980 Port to GNU/Linux systems with tinfo but not ncurses.
981 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
982 to decide whether ncurses is being used. Without this change,
983 GCC complains about tgetent not being declared, on a system
984 that has tinfo installed but ncurses not installed.
985
f274311c
PE
986 * eval.c (Fprogn): Check that BODY is a proper list.
987
16b0520a
PE
988 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
989 * data.c (Fsetq_default):
990 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
991 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
992 (Fcondition_case):
993 Tune by taking advantage of the fact that ARGS is always a list
994 when a function is declared to have UNEVALLED args.
995
9ca960e2
PE
996 * emacsgtkfixed.c: Port to GCC 4.6.
997 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
998
afacaa1b
JB
9992013-07-23 Juanma Barranquero <lekktu@gmail.com>
1000
1001 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1002 here to silence compiler warnings.
1003
368a85a4
PE
10042013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1007 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1008 from messing up Emacs's 'struct frame' (Bug#14923).
1009
f4e891b5
PE
10102013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 * alloc.c (make_save_ptr_ptr): Define this function.
1013 It was inadvertently omitted. It's needed only if
1014 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1015
96c8b65e
JD
10162013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1017
1018 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1019 frame have focus (Bug#14895).
1020
ee010797
PE
10212013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 Avoid vfork-related deadlock more cleanly.
1024 * callproc.c (child_setup): When the child's exec fails, output
1025 the program name, as that's more useful. Use O_NONBLOCK to avoid
1026 deadlock.
1027 * process.c (create_process_1): Remove; no longer needed.
1028 (create_process): Remove timer hack; no longer needed, now that
1029 the child avoids deadlock.
1030
f0398ec1 10312013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1032
1033 * image.c (Fimage_flush): Fix doc typo.
1034
b2a069c2
PE
10352013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1036
6496aec9
PE
1037 Fix array bounds violation when pty allocation fails.
1038 * process.c (PTY_NAME_SIZE): New constant.
1039 (pty_name): Remove static variable; it's now auto.
1040 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1041 Take pty_name as an arg rather than using a static variable.
1042 All callers changed.
1043 (create_process): Recover pty_flag from process, not from volatile local.
1044 (create_pty): Stay inside array even when pty allocation fails.
1045 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1046
b2a069c2
PE
1047 * lread.c (Fload): Avoid initialization only when lint checking.
1048 Mention that it's needed only for older GCCs.
1049
99107004
KH
10502013-07-20 Kenichi Handa <handa@gnu.org>
1051
1052 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1053 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1054
6b1b199d
AS
10552013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1056
1057 * lread.c (Fload): Avoid uninitialized warning.
1058
4195afc3
PE
10592013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1060
3f5bef16
PE
1061 Fix some minor file descriptor leaks and related glitches.
1062 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1063 (create_lock_file): Use write, not emacs_write.
1064 * image.c (slurp_file, png_load_body):
1065 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1066 (server_accept_connection):
1067 Don't leak an fd on memory allocation failure.
1068 * image.c (slurp_file): Add a cheap heuristic for growing files.
1069 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1070 as that's what the other routines do. Maybe input need not be
1071 blocked at all, but it's better to be consistent.
1072 Avoid undefined behavior when strlen is zero.
1073
4195afc3
PE
1074 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1075 (NSTATICS): Now a constant; doesn't need to be a macro.
1076
a1aeeffe
RS
10772013-07-19 Richard Stallman <rms@gnu.org>
1078
1079 * coding.c (decode_coding_utf_8): Add simple loop for fast
1080 processing of ASCII characters.
1081
63b34baa
PE
10822013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1085
621dd9ac
EZ
10862013-07-19 Eli Zaretskii <eliz@gnu.org>
1087
1088 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1089 unportable 'struct x_display_info'.
1090 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1091 is a portable type.
1092
1396ac86
PE
10932013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1094
ab9980cd
PE
1095 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1096 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1097 or fscanf fails.
1098 (system_process_attributes): Prefer plain char to unsigned char
1099 when either will do. Clean up properly if interrupted or if
1100 memory allocations fail. Don't assume sscanf succeeds. Remove
1101 no-longer-needed workaround to stop GCC from whining. Read
1102 command-line once, instead of multiple times. Check read status a
1103 bit more carefully.
1104
1396ac86
PE
1105 Fix obscure porting bug with varargs functions.
1106 The code assumed that int is treated like ptrdiff_t in a vararg
1107 function, which is not a portable assumption. There was a similar
1108 -- though these days less likely -- porting problem with various
1109 assumptions that pointers of different types all smell the same as
1110 far as vararg functions is conserved. To make this problem less
1111 likely in the future, redo the API to use varargs functions.
1112 * alloc.c (make_save_value): Remove this vararg function.
1113 All uses changed to ...
1114 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1115 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1116 New functions.
1117 (make_save_ptr): Rename from make_save_pointer, for consistency with
1118 the above. Define only on platforms that need it. All uses changed.
1119
4d19d194
PE
11202013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1121
1122 * keyboard.c: Try to fix typos in previous change.
1123 (DISPLAY_LIST_INFO): New macro.
1124 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1125 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1126
945c5bb1
JB
11272013-07-18 Juanma Barranquero <lekktu@gmail.com>
1128
1129 * keyboard.c (kbd_buffer_get_event):
1130 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1131 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1132
f4b1eb36
PE
11332013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1134
5e679a2c
PE
1135 * filelock.c: Fix unlikely file descriptor leaks.
1136 (get_boot_time_1): Rework to avoid using emacs_open.
1137 This doesn't actually fix a leak, but is better anyway.
1138 (read_lock_data): Use read, not emacs_read.
1139
a8cd4836
PE
1140 * doc.c: Fix minor memory and file descriptor leaks.
1141 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1142 (get_doc_string, Fsnarf_documentation):
1143 Fix file descriptor leak on error.
1144
ef30e638
PE
1145 * term.c: Fix minor fdopen-related file descriptor leaks.
1146 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1147 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1148
f4b1eb36
PE
1149 * charset.c: Fix file descriptor leaks and errno issues.
1150 Include <errno.h>.
1151 (load_charset_map_from_file): Don't leak file descriptor on error.
1152 Use plain record_xmalloc since the allocation is larger than
1153 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1154 of entries.
1155 * eval.c (record_unwind_protect_nothing):
1156 * fileio.c (fclose_unwind):
1157 New functions.
1158 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1159 The replacement doesn't block input, but that no longer seems
1160 necessary.
1161
b648c163
PE
11622013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1163
a0931322
PE
1164 * lread.c: Fix file descriptor leaks and errno issues.
1165 (Fload): Close some races that leaked fds or streams when 'load'
1166 was interrupted.
1167 (Fload, openp): Report error number of last nontrivial failure to open.
1168 ENOENT counts as trivial.
1169 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1170 New functions.
1171 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1172 now that the function is always called with a nonnegative arg.
1173 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1174 All uses replaced with ...
1175 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1176
b648c163
PE
1177 A few more minor file errno-reporting bugs.
1178 * callproc.c (Fcall_process):
1179 * doc.c (Fsnarf_documentation):
1180 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1181 * process.c (set_socket_option):
1182 Don't let a constructor trash errno.
1183 * doc.c: Include <errno.h>.
1184
b1dc4084
JB
11852013-07-16 Juanma Barranquero <lekktu@gmail.com>
1186
1187 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1188
c43843aa
PE
11892013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1190
50a30cce
PE
1191 Fix w32 bug with call-process-region (Bug#14885).
1192 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1193 to Fcall_process when the input is empty. This simplifies the
1194 code a bit. It makes no difference on POSIXish platforms but
1195 apparently it fixes a bug on w32.
1196
44e18199 1197 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1198 * fileio.c (close_file_unwind): Don't close if FD is negative;
1199 this can happen when unwinding a zapped file descriptor.
1200 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1201 in case Emacs runs out of memory between the two unwind-protects.
1202 Don't trash errno when closing FD.
1203 Zap the FD in the specpdl when closing it, instead of deferring
1204 the removal of the unwind-protect; this fixes a bug where a child
1205 function unwinds the stack past us.
1206
27e498e6
PE
1207 New unwind-protect flavors to better type-check C callbacks.
1208 This also lessens the need to write wrappers for callbacks,
1209 and the need for make_save_pointer.
1210 * alloca.c (free_save_value):
1211 * atimer.c (run_all_atimers):
1212 Now extern.
1213 * alloc.c (safe_alloca_unwind):
1214 * atimer.c (unwind_stop_other_atimers):
1215 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1216 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1217 * minibuf.c (choose_minibuf_frame_1):
1218 * process.c (make_serial_process_unwind):
1219 * xdisp.h (pop_message_unwind):
1220 * xselect.c (queue_selection_requests_unwind):
1221 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1222 * alloca.c (record_xmalloc):
1223 Prefer record_unwind_protect_ptr to record_unwind_protect with
1224 make_save_pointer.
1225 * alloca.c (Fgarbage_collect):
1226 Prefer record_unwind_protect_void to passing a dummy.
1227 * buffer.c (restore_buffer):
1228 * window.c (restore_window_configuration):
1229 * xfns.c, w32fns.c (do_unwind_create_frame)
1230 New wrapper. All record-unwind uses of wrappee changed.
1231 * buffer.c (set_buffer_if_live):
1232 * callproc.c (call_process_cleanup, delete_temp_file):
1233 * coding.c (code_conversion_restore):
1234 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1235 * editfns.c (save_excursion_restore)
1236 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1237 (save_restriction_restore):
1238 * eval.c (restore_stack_limits, un_autoload):
1239 * fns.c (require_unwind):
1240 * keyboard.c (recursive_edit_unwind, tracking_off):
1241 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1242 * macros.c (pop_kbd_macro, restore_menu_items):
1243 * nsfns.m (unwind_create_frame):
1244 * print.c (print_unwind):
1245 * process.c (start_process_unwind):
1246 * search.c (unwind_set_match_data):
1247 * window.c (select_window_norecord, select_frame_norecord):
1248 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1249 (fast_set_selected_frame):
1250 * xfns.c, w32fns.c (unwind_create_tip_frame):
1251 Return void, not a dummy Lisp_Object. All uses changed.
1252 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1253 * callproc.c (call_process_kill):
1254 * fileio.c (restore_point_unwind, decide_coding_unwind)
1255 (build_annotations_unwind):
1256 * insdel.c (Fcombine_after_change_execute_1):
1257 * keyboard.c (read_char_help_form_unwind):
1258 * menu.c (unuse_menu_items):
1259 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1260 * sound.c (sound_cleanup):
1261 * xdisp.c (unwind_redisplay):
1262 * xfns.c (clean_up_dialog):
1263 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1264 Accept no args and return void, instead of accepting and returning
1265 a dummy Lisp_Object. All uses changed.
1266 * cygw32.c (fchdir_unwind):
1267 * fileio.c (close_file_unwind):
1268 * keyboard.c (restore_kboard_configuration):
1269 * lread.c (readevalllop_1):
1270 * process.c (wait_reading_process_output_unwind):
1271 Accept int and return void, rather than accepting an Emacs integer
1272 and returning a dummy object. In some cases this fixes an
1273 unlikely bug when the corresponding int is outside Emacs integer
1274 range. All uses changed.
1275 * dired.c (directory_files_internal_unwind):
1276 * fileio.c (do_auto_save_unwind):
1277 * gtkutil.c (pop_down_dialog):
1278 * insdel.c (reset_var_on_error):
1279 * lread.c (load_unwind):
1280 * xfns.c (clean_up_file_dialog):
1281 * xmenu.c, nsmenu.m (pop_down_menu):
1282 * xmenu.c (cleanup_widget_value_tree):
1283 * xselect.c (wait_for_property_change_unwind):
1284 Accept pointer and return void, rather than accepting an Emacs
1285 save value encapsulating the pointer and returning a dummy object.
1286 All uses changed.
1287 * editfns.c (Fformat): Update the saved pointer directly via
1288 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1289 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1290 (unwind_body): New function.
1291 (record_unwind_protect): First arg is now a function returning void,
1292 not a dummy Lisp_Object.
1293 (record_unwind_protect_ptr, record_unwind_protect_int)
1294 (record_unwind_protect_void): New functions.
1295 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1296 * fileio.c (struct auto_save_unwind): New type.
1297 (do_auto_save_unwind): Use it.
1298 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1299 * insdel.c (struct rvoe_arg): New type.
1300 (reset_var_on_error): Use it.
1301 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1302 New constants.
1303 (specbinding_func): Remove; there are now several such functions.
1304 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1305 (set_unwind_protect_ptr): New function.
1306 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1307
4e604a5d
PE
1308 Be simpler and more consistent about reporting I/O errors.
1309 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1310 Say "Read error" and "Write error", rather than "I/O error", or
1311 "IO error reading", or "IO error writing", when a read or write
1312 error occurs.
1313 * process.c (Fmake_network_process, wait_reading_process_output)
1314 (send_process, Fprocess_send_eof, wait_reading_process_output):
1315 Capitalize diagnostics consistently. Put "failed foo" at the
1316 start of the diagnostic, so that we don't capitalize the
1317 function name "foo". Consistently say "failed" for such
1318 diagnostics.
1319 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1320 All callers changed. This is so it can use report_file_error.
1321 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1322 diagnostics consistently as above.
1323
a9757f6a
PE
1324 * fileio.c (report_file_errno): Fix errno reporting bug.
1325 If the file name is neither null nor a pair, package it up as a
1326 singleton list. All callers changed, both to this function and to
1327 report_file_error. This fixes a bug where the memory allocator
1328 invoked by list1 set errno so that the immediately following
1329 report_file_error reported the wrong errno value.
1330
c43843aa
PE
1331 Fix minor problems found by --enable-gcc-warnings.
1332 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1333 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1334
18c26d81
JD
13352013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1336
1337 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1338 Set event->arg to Qt if switch-event shall be generated.
1339 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1340
1341 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1342
1343 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1344 FOCUS_OUT_EVENT.
1345
1346 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1347 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1348 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1349 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1350 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1351 and there is a focused frame.
1352 (head_table): Add focus-in and focus-out.
1353 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1354 bind to handle-focus-in/out.
1355
1356 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1357 (Fhandle_switch_frame): Call Fhandle_focus_in.
1358 (syms_of_frame): defsubr handle-focus-in/out.
1359
6c6f1994
PE
13602013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1361
c7ddc792
PE
1362 Fix porting bug to older POSIXish platforms (Bug#14862).
1363 * sysdep.c (emacs_pipe): New function, that implements
1364 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1365 This should port better to CentOS 5 and to Mac OS X 10.6.
1366 All calls to pipe2 changed.
1367
6c6f1994
PE
1368 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1369 This makes the code easier to read and the executable a bit smaller.
1370 Do not replace all calls to Fcons that happen to create lists,
1371 just calls that are intended to create lists. For example, when
1372 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1373 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1374 Similarly for list2 through list5.
1375 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1376 * bytecode.c (exec_byte_code):
1377 * callint.c (quotify_arg, Fcall_interactively):
1378 * callproc.c (Fcall_process, create_temp_file):
1379 * charset.c (load_charset_map_from_file)
1380 (Fdefine_charset_internal, init_charset):
1381 * coding.c (get_translation_table, detect_coding_system)
1382 (Fcheck_coding_systems_region)
1383 (Fset_terminal_coding_system_internal)
1384 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1385 * composite.c (update_compositions, Ffind_composition_internal):
1386 * dired.c (directory_files_internal, file_name_completion)
1387 (Fsystem_users):
1388 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1389 * doc.c (Fsnarf_documentation):
1390 * editfns.c (Fmessage_box):
1391 * emacs.c (main):
1392 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1393 (Feval, eval_sub, Ffuncall, apply_lambda):
1394 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1395 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1396 (Fset_file_times, Finsert_file_contents)
1397 (Fchoose_write_coding_system, Fwrite_region):
1398 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1399 * font.c (font_registry_charsets, font_parse_fcname)
1400 (font_prepare_cache, font_update_drivers, Flist_fonts):
1401 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1402 * frame.c (make_frame, Fmake_terminal_frame)
1403 (x_set_frame_parameters, x_report_frame_params)
1404 (x_default_parameter, Fx_parse_geometry):
1405 * ftfont.c (syms_of_ftfont):
1406 * image.c (gif_load):
1407 * keyboard.c (command_loop_1):
1408 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1409 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1410 (Fminor_mode_key_binding, accessible_keymaps_1)
1411 (Faccessible_keymaps, Fwhere_is_internal):
1412 * lread.c (read_emacs_mule_char):
1413 * menu.c (find_and_return_menu_selection):
1414 * minibuf.c (get_minibuffer):
1415 * nsfns.m (Fns_perform_service):
1416 * nsfont.m (ns_script_to_charset):
1417 * nsmenu.m (ns_popup_dialog):
1418 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1419 (Fx_own_selection_internal):
1420 * nsterm.m (append2):
1421 * print.c (Fredirect_debugging_output)
1422 (print_prune_string_charset):
1423 * process.c (Fdelete_process, Fprocess_contact)
1424 (Fformat_network_address, set_socket_option)
1425 (read_and_dispose_of_process_output, write_queue_push)
1426 (send_process, exec_sentinel):
1427 * sound.c (Fplay_sound_internal):
1428 * textprop.c (validate_plist, add_properties)
1429 (Fput_text_property, Fadd_face_text_property)
1430 (copy_text_properties, text_property_list, syms_of_textprop):
1431 * unexaix.c (report_error):
1432 * unexcoff.c (report_error):
1433 * unexsol.c (unexec):
1434 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1435 (Fformat_mode_line, syms_of_xdisp):
1436 * xfaces.c (set_font_frame_param)
1437 (Finternal_lisp_face_attribute_values)
1438 (Finternal_merge_in_global_face, syms_of_xfaces):
1439 * xfns.c (x_default_scroll_bar_color_parameter)
1440 (x_default_font_parameter, x_create_tip_frame):
1441 * xfont.c (xfont_supported_scripts):
1442 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1443 (menu_help_callback, xmenu_show):
1444 * xml.c (make_dom):
1445 * xterm.c (set_wm_state):
1446 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1447 and similarly for list2 through list5.
1448
bafe80ce
PE
14492013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 * callproc.c (Fcall_process_region): Fix minor race and tune.
1452 (create_temp_file): New function, with the temp-file-creation part
1453 of the old Fcall_process_region. Use Fcopy_sequence to create the
1454 temp file name, rather than alloca + build_string, for simplicity.
1455 Don't bother to block input around the temp file creation;
1456 shouldn't be needed. Simplify use of mktemp. Use
1457 record_unwind_protect immediately after creating the temp file;
1458 this closes an unlikely race where the temp file was not removed.
1459 Use memcpy rather than an open-coded loop.
1460 (Fcall_process_region): Use the new function. If the input is
1461 empty, redirect from /dev/null rather than from a newly created
1462 empty temp file; this avoids unnecessary file system traffic.
1463
4700b5a5
PE
14642013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1465
5c97beae
PE
1466 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1467 Simplify by making this case like the other two. This is a bit
1468 slower on obsolete hosts, but the extra complexity isn't worth it.
1469
4700b5a5
PE
1470 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1471 * process.c (create_process) [!DOS_NT]:
1472 Remove now-unnecessary calls to emacs_close.
1473
f9a74c4c
EZ
14742013-07-13 Eli Zaretskii <eliz@gnu.org>
1475
922ae7ee
EZ
1476 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1477 returning early. (Bug#14850)
1478
f9a74c4c
EZ
1479 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1480 and inhibit-iso-escape-detection attributes of 'undecided'.
1481 (Bug#14822)
1482
5e301d76
PE
14832013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1484
69e0e5ee
PE
1485 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1486 Reported by Herbert J. Skuhra in
1487 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1488
5e301d76
PE
1489 Don't lose top specpdl entry when memory is exhausted.
1490 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1491 specpdl overflow here, to simplify callers; all callers changed.
1492 Always reserve an unused entry at the stack top; this avoids
1493 losing the top entry's information when memory is exhausted.
1494
7e649856
PE
14952013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1496
a773ed9a
PE
1497 Clean up errno reporting and fix some errno-reporting bugs.
1498 * callproc.c (Fcall_process):
1499 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1500 * process.c (create_process, Fmake_network_process):
1501 * unexaix.c (report_error):
1502 * unexcoff.c (report_error):
1503 Be more careful about reporting the errno of failed operations.
1504 The code previously reported the wrong errno sometimes.
1505 Also, prefer report_file_errno to setting errno + report_file_error.
1506 (Fcall_process): Look at openp return value rather than at path,
1507 as that's a bit faster and clearer when there's a numeric predicate.
1508 * fileio.c (report_file_errno): New function, with most of the
1509 old contents of report_file_error.
1510 (report_file_error): Use it.
1511 (Ffile_exists_p, Ffile_accessible_directory_p):
1512 Set errno to 0 when it is junk.
1513 * fileio.c (Faccess_file):
1514 * image.c (x_create_bitmap_from_file):
1515 Use faccessat rather than opening the file, to avoid the hassle of
1516 having a file descriptor open.
1517 * lisp.h (report_file_errno): New decl.
1518 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1519
7e649856
PE
1520 Minor EBADF fixes.
1521 * process.c (create_process, wait_reading_process_output) [AIX]:
1522 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1523 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1524 a multithreaded environment anyway).
1525 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1526
f6774c1a
AS
15272013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1528
1529 * image.c (x_find_image_file): Don't close a remote file handle.
1530
bacba3c2
PE
15312013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 Fix races with threads and file descriptors.
1534 * callproc.c (Fcall_process_region):
1535 * dired.c (open_directory):
1536 * emacs.c (main, Fdaemon_initialized):
1537 * image.c (x_find_image_file):
1538 * inotify.c (Finotify_rm_watch):
1539 * lread.c (Flocate_file_internal):
1540 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1541 * term.c (term_mouse_moveto, init_tty):
1542 * termcap.c (tgetent):
1543 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1544 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1545 * unexhp9k800.c, unexmacosx.c (unexec):
1546 * callproc.c (Fcall_process_region):
1547 Use emacs_close, not close.
1548 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1549 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1550 and posix_close function on current platforms (which all lack them).
1551 (emacs_close): Use it. This should fix the races on GNU/Linux and
1552 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1553 and it should avoid closing random victim file descriptors on
1554 other platforms.
1555
653d4f43
PE
15562013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1557
c8536ec4
PE
1558 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1559 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1560 Touch up doc a bit.
1561
9c203066
PE
1562 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1563 This is for .gdbinit xbacktrace.
1564
653d4f43
PE
1565 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1566 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1567 (emacs_set_tty): Now static.
1568 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1569 * term.c (tty_capable_p, tty_default_color_capabilities)
1570 (get_tty_terminal, term_mouse_movement)
1571 (handle_one_term_event, init_tty, maybe_fatal):
1572 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1573 (tgetent, scan_file, name_match, compare_contin):
1574 * terminal.c (get_terminal):
1575 Use bool for boolean.
1576 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1577 Prefer char to unsigned char if either will do.
1578 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1579 (tty_write_glyphs): Prefer int to unsigned.
1580 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1581 All callers changed.
1582 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1583
45b683a1
PE
15842013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1585
29abe551
PE
1586 Port to C89.
1587 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1588 (B__dummy__): New dummy symbol, to pacify C89.
1589 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1590 they can't grok varargs macros.
1591 * dispnew.c (add_window_display_history)
1592 (add_frame_display_history):
1593 * print.c (print_object):
1594 * xdisp.c (debug_method_add):
1595 Use %p printf format only for void pointers.
1596 * emacs.c (usage_message): New constant, replacing ...
1597 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1598 (main): Adjust to usage reorg.
1599 * fns.c (syms_of_fns):
1600 * profiler.c (syms_of_profiler):
1601 Don't use non-constant struct initializers.
1602 * gnutls.h (gnutls_initstage_t):
1603 * lisp.h (enum Lisp_Fwd_Type):
1604 * lread.c (lisp_file_lexically_bound_p):
1605 * xsettings.c (anonymous enum):
1606 Remove trailing comma.
1607 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1608 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1609 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1610 (DEFUN): Use it.
1611 * regex.c (const_re_char): New type, to pacify strict C89.
1612 All uses of 'const re_char' replaced to use it.
1613 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1614 with glibc when strict C89. This change is imported from gnulib.
1615 All uses changed.
1616 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1617 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1618 Omit GNU_LINUX implementation, since it requires long long.
1619 * xterm.c (x_draw_underwave):
1620 Do not assume the traditional order of struct's members.
1621 (x_term_init): Rewrite to avoid the need for non-constant structure
1622 initializers.
1623
45b683a1 1624 Syntax cleanup, mostly replacing macros with functions.
763a086d 1625 This removes the need for the syntax_temp hack.
45b683a1
PE
1626 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1627 * syntax.c (SYNTAX_INLINE): New macro.
1628 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1629 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1630 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1631 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1632 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1633 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1634 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1635 Now constants, not macros.
1636 (syntax_temp) [!__GNUC__]: Remove.
1637 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1638 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1639 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1640 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1641 Move here from syntax.h; now functions, not macros. Except for the
1642 last function, these are static since only syntax.c uses them.
1643 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1644 All uses changed. Now a function, not a macro; use this fact
1645 to simplify the code.
1646 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1647 compiler bugs; no longer relevant.
1648 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1649 (SYNTAX_INLINE): New macro.
1650 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1651 for the new functions. Use bool for boolean member.
1652 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1653 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1654 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1655 (SETUP_BUFFER_SYNTAX_TABLE):
1656 Now extern inline functions, not macros.
1657 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1658 Remove; all uses replaced by implementation.
1659 (syntax_temp) [!__GNUC__]: Remove decl.
1660 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1661
29be4a50
JD
16622013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1663
1664 * emacs.c (main): Fix syntax error.
1665
954b166e
PE
16662013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1667
1668 Timestamp fixes for undo (Bug#14824).
1669 * atimer.c (schedule_atimer):
1670 * fileio.c (Ffile_newer_than_file_p):
1671 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1672 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1673 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1674 (syms_of_fileio): Remove Sclear_visited_file_name.
1675 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1676 file doesn't exist; this avoids an ambiguity with negative timestamps.
1677 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1678 * systime.h (make_emacs_time, invalid_emacs_time):
1679 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1680 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1681 * undo.c (record_first_change): Push (visited-file-modtime) onto
1682 undo list rather than reimplementing it by hand, incorrectly.
1683
d74647c3
KB
16842013-07-09 Ken Brown <kbrown@cornell.edu>
1685
1686 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1687
3c51b96b
JB
16882013-07-09 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1691
4ebbdd67
PE
16922013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1693
1694 Handle errno and exit status a bit more carefully.
1695 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1696 number into an exit status. Instead, use EXIT_CANCELED.
1697 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1698 * callproc.c (relocate_fd):
1699 * emacs.c (close_output_streams, main):
1700 * process.c (create_process):
1701 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1702 Use emacs_perror for simplicity.
1703 * callproc.c (relocate_fd, main):
1704 * sysdep.c (sys_subshell):
1705 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1706 (shut_down_emacs): Use emacs_write, not write.
1707 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1708 * fileio.c (Fcopy_file, e_write):
1709 * nsterm.m (ns_select):
1710 * process.c (send_process):
1711 * sound.c (vox_write):
1712 Use emacs_write_sig, not emacs_write.
1713 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1714 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1715 New constants.
1716 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1717 of write.
1718 (emacs_full_write): New function.
1719 (emacs_write): Rewrite to use it.
1720 (emacswrite_sig, emacs_perror): New functions.
1721 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1722
44e18199 17232013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1724
1725 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1726 on NS even if it is present. Pixmap on NS is a void*.
1727
9caab067
PE
17282013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 Port to Ubuntu 10 (Bug#14803).
1731 Problem reported by T.V. Raman.
1732 * process.c (close_on_exec, accept4, process_socket):
1733 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1734
1d442672
EZ
17352013-07-07 Eli Zaretskii <eliz@gnu.org>
1736
1737 * w32.c (sys_dup): Declare prototype.
1738
1739 * filelock.c:
1740 * emacs.c:
1741 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1742
067428c1
PE
17432013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 Make file descriptors close-on-exec when possible (Bug#14803).
1746 This simplifies Emacs a bit, since it no longer needs to worry
1747 about closing file descriptors by hand in some cases.
1748 It also fixes some unlikely races. Not all such races, as
1749 libraries often open files internally without setting
1750 close-on-exec, but it's an improvement.
1751 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1752 * callproc.c (Fcall_process) [!MSDOS]:
1753 * emacs.c (main) [!DOS_NT]:
1754 * nsterm.m (ns_term_init):
1755 * process.c (create_process):
1756 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1757 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1758 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1759 Prefer mkostemp with O_CLOEXEC to mkstemp.
1760 * callproc.c (relocate_fd) [!WINDOWSNT]:
1761 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1762 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1763 now using pipe2.
1764 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1765 Make the resulting file descriptor close-on-exec.
1766 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1767 * lread.c (load_descriptor_list, load_descriptor_unwind):
1768 Remove; no longer needed. All uses removed.
1769 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1770 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1771 New functions.
1772 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1773 (Fmake_network_process, Fnetwork_interface_list):
1774 (Fnetwork_interface_info, server_accept_connection):
1775 Make newly-created socket close-on-exec.
1776 * sysdep.c (emacs_open, emacs_fopen):
1777 Make new-created descriptor close-on-exec.
1778 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1779 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1780
0da857dd
JD
17812013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1782
1783 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1784 for NS_IMPL_GNUSTEP.
1785
5f86adcd
PE
17862013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 Fix openp errno handling.
1789 * callproc.c (Fcall_process): Preserve openp errno around close.
1790 * lread.c (openp): Set errno when returning -1, as some callers
1791 expect this.
1792
1afb1d07
JD
17932013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1794
1795 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1796
1797 * nsterm.h (NSSavePanel): Update comment.
1798 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1799 (ns_run_file_dialog): Declare.
1800
1801 * nsfns.m: Remove panelOK.
1802 (ns_fd_data): New.
1803 (ns_run_file_dialog): New function.
1804 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1805 event loop, so file dialog is popped up by ns_run_file_dialog, called
1806 by sendEvent (Bug#14578).
1807 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1808
3323c263
EZ
18092013-07-06 Eli Zaretskii <eliz@gnu.org>
1810
fdda0220
EZ
1811 * xdisp.c (default_line_pixel_height): New function.
1812 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1813 (try_cursor_movement, redisplay_window, try_window)
1814 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1815
1816 * window.c (window_scroll_pixel_based): use
1817 default_line_pixel_height.
1818
1819 * dispextern.h (default_line_pixel_height): Add prototype.
1820
1821 * frame.c (x_set_line_spacing): Accept a float value for
1822 line-spacing parameter, per the documentation.
1823
3323c263
EZ
1824 * data.c (Fmultibyte_string_p): Doc fix.
1825
47ba6d43
PE
18262013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1827
406af475
PE
1828 Use emacs_open more consistently when opening files.
1829 This handles EINTR more consistently now, and makes it easier
1830 to introduce other uniform changes to file descriptor handling.
1831 * src/systdio.h: New file.
1832 * src/buffer.c (mmap_init):
1833 * cygw32.c (chdir_to_default_directory):
1834 * dispnew.c (Fopen_termscript):
1835 * emacs.c (Fdaemon_initialized):
1836 * fileio.c (Fdo_auto_save):
1837 * image.c (slurp_file, png_load_body, jpeg_load_body):
1838 * keyboard.c (Fopen_dribble_file):
1839 * lread.c (Fload):
1840 * print.c (Fredirect_debugging_output):
1841 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1842 * termcap.c (tgetent):
1843 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1844 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1845 * w32term.c (w32_initialize) [CYGWIN]:
1846 * xfaces.c (Fx_load_color_file):
1847 Use emacs_open instead of plain open, and emacs_fopen instead of
1848 plain fopen.
1849 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1850 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1851 * callproc.c (default_output_mode): New constant.
1852 (Fcall_process): Use it to call emacs_open instead of plain creat.
1853 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1854 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1855 (emacs_fopen): New function.
1856 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1857 Include <lisp.h>, for emacs_open.
1858 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1859
47ba6d43
PE
1860 Remove duplicate #include directives.
1861 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1862 * xfaces.c:
1863 Don't include stdio.h twice.
1864 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1865 Don't include sys/types.h or stdio.h twice.
1866 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1867 * lread.c: Don't include coding.h twice.
1868 * nsfont.m: Don't include frame.h twice.
1869 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1870 * ralloc.c: Don't include <unistd.h> twice.
1871 * xdisp.c: Don't include font.h twice.
1872 * xterm.c: Don't include fontset.h twice.
1873 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1874
b9ed53d5
PE
18752013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 Scale ImageMagick images more carefully.
1878 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1879 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1880 Be more careful about avoiding undefined behavior after
1881 integer overflow and division by zero.
1882
cf13177e
YM
18832013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1884
1885 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1886 (syms_of_w32fns): DEFSYM them.
1887 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1888 (CCHDEVICENAME): Define macros if not defined.
1889 (struct MONITOR_INFO_EX): New struct.
1890 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1891 (enum_display_monitors_fn): New variable.
1892 (globals_of_w32fns): Initialize it.
1893 (Fx_display_pixel_width, Fx_display_pixel_height)
1894 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1895 multi-monitor setups in docstrings.
1896 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1897 screen size by primary monitor's millimeter per pixel.
1898 (w32_monitor_enum, w32_display_monitor_attributes_list)
1899 (w32_display_monitor_attributes_list_fallback)
1900 (Fw32_display_monitor_attributes_list): New functions.
1901 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1902
1903 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1904 if not defined.
1905 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1906
86dfb7a8
MA
19072013-07-04 Michael Albinus <michael.albinus@gmx.de>
1908
1909 * fileio.c (Qfile_notify_error): New error symbol.
1910
1911 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1912 * inotify.c (inotify_callback, symbol_to_inotifymask)
1913 (Finotify_add_watch, Finotify_rm_watch): Use it.
1914 (inotifyevent_to_event): Exchange order of cookie and file name.
1915 (Finotify_add_watch): Adapt docstring.
1916
1917 * lisp.h (Qfile_notify_error): Declare.
1918
2c1c974b
PE
19192013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1922 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1923 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1924 which did not work (see <http://bugs.gnu.org/14569#307>).
1925 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1926 && (!noninteractive || initialized)). This attempts to thread
1927 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1928
7a35b20f
JB
19292013-07-04 Juanma Barranquero <lekktu@gmail.com>
1930
1931 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1932 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1933
1ce5cd04
PE
19342013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1937 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1938 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1939 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1940
57f8c490
PE
19412013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1944 Define to __sys_siglist.
1945
bcffb5ca
EZ
19462013-07-02 Eli Zaretskii <eliz@gnu.org>
1947
1948 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1949 word-wrap, so that overflow-newline-into-fringe would work in
1950 visual-line-mode. (Bug#2749)
1951 (move_it_in_display_line_to): When the last scanned display
1952 element fits exactly on the display line, and
1953 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1954 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1955 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1956 finding buffer position that corresponds to pixel coordinates,
1957 e.g. in buffer_posn_from_coords.
1958
2c41e781
JD
19592013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1960
1961 * process.c (handle_child_signal): Call catch_child_signal if
1962 NS_IMPL_GNUSTEP.
1963
c2418359
PE
19642013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1965
52a9bcae
PE
1966 Don't convert function pointers to void * and back.
1967 It isn't portable C, and it's easy enough to avoid.
1968 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1969 (make_save_value): Add support for SAVE_FUNCPOINTER.
1970 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1971 * print.c (print_object):
1972 Distinguish function from object pointers.
1973 * lisp.h (SAVE_FUNCPOINTER): New constant.
1974 (SAVE_SLOT_BITS): Adjust to it.
1975 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1976 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1977 (voidfuncptr): New typedef.
1978 (struct Lisp_Save_Value): New member data[0].funcpointer.
1979 (XSAVE_FUNCPOINTER): New function.
1980
c2418359
PE
1981 Simplify buildobj processing.
1982 * Makefile.in (buildobj.h): Make it a sequence of strings each
1983 followed by comma, rather than a single string. Put it into a
1984 .tmp file in case there's an error while generating it.
1985 (gl-stamp): Use .tmp for temp files.
1986 (mostlyclean): Clean .tmp files.
1987 * doc.c (buildobj): Move to just the routine that needs it.
1988 It's now an array of strings, so processing is simpler.
1989
8f43ce49
PE
19902013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1993 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1994 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1995 Invoke malloc_enable_thread even when not interactive.
1996 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1997 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1998 in this case, since the underlying bug has now been fixed.
1999
24827db9
JB
20002013-07-01 Juanma Barranquero <lekktu@gmail.com>
2001
2002 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2003 unlinking it (bug#14691).
2004
ef099a94
MN
20052013-06-30 Michal Nazarewicz <mina86@mina86.com>
2006
2007 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2008 before checking whether buffer is modified. This lets
2009 `kill-buffer-query-functions' cancel killing of the buffer or save
2010 its content before `kill-buffer' asks user the "Buffer %s
2011 modified; kill anyway?" question.
2012
9d3f2fc2
JD
20132013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2014
2015 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2016 Let the super performKeyEquivalent deal with them (Bug#14747).
2017
e6c6c8c7
PE
20182013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2019
1d71c1d9
PE
2020 * widget.c (resize_cb): Remove unused local.
2021
8f5f35cc
PE
2022 Do not use GTK 3 if it exists but cannot be compiled.
2023 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2024 * xterm.c (x_error_handler) [!USE_GTK]:
2025 Do not use GTK 3.
2026
e6c6c8c7
PE
2027 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2028
0ba54312
EZ
20292013-06-30 Eli Zaretskii <eliz@gnu.org>
2030
5d1c3286
EZ
2031 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2032 to the valid range of values. (Bug#14753)
2033
0ba54312
EZ
2034 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2035 when moving point by using the current glyph matrix. This avoids
2036 the need to force redisplay when this function is called in a
2037 loop.
2038
9c90cc06
PE
20392013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2040
2041 Fix minor problems found by static checking.
2042 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2043 Redo the latter's body to sidestep GCC parenthesization warnings.
2044 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2045 * coding.c (detect_coding, detect_coding_system):
2046 * coding.h (struct undecided_spec):
2047 Use bool for boolean.
2048 * image.c (QCmax_width, QCmax_height): Now static.
2049 * xdisp.c (Fmove_point_visually): Remove unused local.
2050
4c672a0f
EZ
20512013-06-29 Eli Zaretskii <eliz@gnu.org>
2052
2053 * xdisp.c (Fmove_point_visually): New function.
2054
c1ea3abf
JB
20552013-06-28 Kenichi Handa <handa@gnu.org>
2056
2057 * coding.h (define_coding_undecided_arg_index): New enum.
2058 (coding_attr_index): New members
2059 coding_attr_undecided_inhibit_null_byte_detection,
2060 coding_attr_undecided_inhibit_iso_escape_detection,
2061 coding_attr_undecided_prefer_utf_8.
2062 (undecided_spec): New struct.
2063 (struct coding_system): New member `undecided' of the member
2064 `spec'.
2065
2066 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2067 (detect_coding): Likewise.
2068 (detect_coding_system): Likewise.
2069 (Fdefine_coding_system_internal): New coding system properties
2070 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2071 :prefer-utf-8.
2072 (syms_of_coding): Adjust for coding_arg_undecided_max.
2073
ba3de9e6
PE
20742013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2075
2076 * image.c (x_from_xcolors): Remove unused local.
2077
547c9269
YM
20782013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2079
2080 Defer image data transfer between X client and server until actual
2081 display happens.
2082
2083 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2084 and `mask_img'.
2085
2086 * image.c (Destroy_Image): Remove.
2087 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2088 `mask_p', and `colors_p'. All uses changed.
2089 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2090 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2091 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2092 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2093 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2094 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2095 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2096 (image_get_x_image, image_unget_x_image): New functions or macros.
2097 (image_background, image_background_transparent, x_to_xcolors)
2098 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2099 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2100 instead of Destroy_Image.
2101 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2102 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2103 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2104 (imagemagick_load_image, svg_load_image): Use them instead of
2105 x_create_x_image_and_pixmap, and x_put_x_image followed by
2106 x_destroy_x_image, respectively.
2107 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2108 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2109 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2110 background_transparent fields.
2111 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2112 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2113
dae2f5ef
PE
21142013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2117 This mostly consists of undoing recent changes.
2118 * callproc.c (Fcall_process):
2119 * process.c (create_process):
2120 Do not worry about catching SIGCHLD here, undoing previous change.
2121 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2122 * process.c, process.h (catch_child_signal):
2123 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2124 * process.c (catch_child_handler): Don't worry about being called
2125 lazily and do not assume caller has blocked SIGCHLD, undoing
2126 previous change. Move first-time stuff back to
2127 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2128 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2129 set lib_child_handler if it's already initialized, which may
2130 help avoid problems on GNUStep.
2131
fa55d2aa
PE
21322013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2135 * callproc.c (Fcall_process):
2136 * process.c (create_process):
2137 Make sure SIGCHLD is caught before we fork,
2138 since Emacs startup no arranges to catch SIGCHLD.
2139 * process.c (lib_child_handler): Initialize to null, not to
2140 dummy_handler.
2141 (catch_child_signal): Allow self to be called lazily.
2142 Do nothing if it's already been called.
2143 Assume caller has blocked SIGCHLD (all callers do now).
2144 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2145 just before it's really needed.
2146 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2147 since it hasn't been caught yet.
2148
f3f9606c
LMI
21492013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2150
2151 * image.c (compute_image_size): New function to implement
2152 :max-width and :max-height.
2153 (imagemagick_load_image): Use it.
2154
c7041908
PE
21552013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2158 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2159 Now extern.
2160 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2161 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2162 the SIGCHLD handler, since the code is not atomic and (due to glib)
2163 signals may be arriving now.
2164 * sysdep.c (init_signals): Do not catch child signals here;
2165 'main' now does that later, at a safer time.
2166
f86852b4
PE
21672013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2168
0dfeed58
PE
2169 Clean up SIGCHLD handling a bit (Bug#14569).
2170 * process.c, process.h (catch_child_signal):
2171 Now always extern, even if !NS_IMPL_GNUSTEP.
2172 * process.c (catch_child_signal): Move glib tickler here from
2173 init_process_emacs, so that it's done earlier in Emacs
2174 initialization. Also move the noninteractive && !initialized
2175 check here from init_process_emacs. This is all a bit cleaner for
2176 GNUish platforms, and I hope it works around the Cygwin bug.
2177 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2178 that glib signal handling is tickled before glib creates threads.
2179
f86852b4
PE
2180 * process.c (wait_reading_process_output): Avoid int overflow
2181 when reading more than 2 GiB total from a process.
2182
cbd6509c
PE
21832013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2184
2185 * process.c (create_process): Handle a couple more cases,
2186 i.e., work even if new_argv and wait_child_setup[i] are cached.
2187 Use Fcall_process's style for volatile vars.
2188
9de1114a
AS
21892013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2190
2191 * process.c (create_process): Mark PROCESS volatile.
2192
fbe9e0b9
PE
21932013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 Use C99-style flexible array members if available.
2196 This avoids some subtle aliasing issues, which typically
2197 aren't a problem with GCC but may be a problem elsewhere.
2198 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2199 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2200 In either case, it uses a flexible array member rather than
2201 the old struct hack. All uses changed.
2202 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2203 Adjust to sdata reorganization.
2204 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2205 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2206 that ports better to pre-C99 non-GCC.
2207 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2208 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2209 as the latter has changed.
2210 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2211 and port better to pre-C99 GCC.
2212 * image.c (struct xpm_cached_color):
2213 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2214 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2215 Use FLEXIBLE_ARRAY_MEMBER.
2216 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2217 Move decl to top level so it gets checked against implementation.
2218 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2219 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2220
1fc71008
PE
22212013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 * syntax.c: Integer cleanups.
2224 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2225 All uses that need 0-or-2 changed to:
2226 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2227 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2228 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2229 (char_quoted, prev_char_comend_first, back_comment)
2230 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2231 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2232 Use bool for boolean.
2233 (update_syntax_table, skip_chars, skip_syntaxes):
2234 Prefer int to unsigned when either will do.
2235 (back_comment): Return boolean success flag, like forw_comment,
2236 instead of positive-or-minus-1 (which might have overflowed int anyway).
2237 Don't stuff ptrdiff_t into int.
2238 (syntax_spec_code, syntax_code_spec): Now const.
2239 (Fmatching_paren, scan_lists, scan_sexps_forward):
2240 Use enum syntaxcode for syntax code.
2241 (Fmatching_paren): Check that arg is a character, not just an integer.
2242 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2243 (Finternal_describe_syntax_value): Omit no-longer-needed
2244 comparison to 0.
2245 (skip_chars): Use char, not unsigned char, when the distinction
2246 doesn't matter.
2247 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2248 * bytecode.c (exec_byte_code):
2249 * syntax.c (syntax_spec_code, Fchar_syntax)
2250 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2251 (init_syntax_once):
2252 * syntax.h (SYNTAX_WITH_FLAGS):
2253 Omit unnecessary casts.
2254
b932cad7
EZ
22552013-06-20 Eli Zaretskii <eliz@gnu.org>
2256
2257 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2258 line dimensions here, to avoid race conditions with the main
2259 thread. (Bug#14062, bug#14630, bug#14669)
2260
2261 * w32term.c (w32_draw_window_cursor): Compute the header line and
2262 mode line dimensions here.
2263 <w32_system_caret_window, w32_system_caret_hdr_height>:
2264 <w32_system_caret_mode_height>: New variables.
2265
2266 * w32term.h: Declare them.
2267
89561f72
PE
22682013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2269
5013fc08
PE
2270 * alloc.c (die): Move "assertion failed" string here ...
2271 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2272 COND when SUPPRESS_CHECKING. This shrinks the executable text
2273 size by 0.8% to 2.2% when configured with --enable-checking,
2274 depending on optimization flags (GCC 4.8.1 x86-64).
2275
89561f72
PE
2276 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2277
763a086d 22782013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2279
2280 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2281 base is 2; this is more accurate.
2282
983aeb9a
JB
22832013-06-19 Juanma Barranquero <lekktu@gmail.com>
2284
2285 * sound.c (string_default): Move to !WINDOWSNT section.
2286 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2287
178ba3e6
PE
22882013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2289
bbc51b15
PE
2290 * sound.c: Integer cleanups.
2291 Remove unnecessary forward decls.
2292 (struct sound_device): The 'file' member is now a Lisp_Object, not
2293 a char *, so that we needn't invoke alloca on a huge size.
2294 (Fplay_sound_internal): Adjust to this.
2295 (string_default): New function.
2296 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2297 Use it to adjust to the struct sound_device change.
2298 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2299 (be2hs) [0]: Remove.
2300
178ba3e6
PE
2301 * syntax.c (skip_chars): Don't use uninitialized storage
2302 when searching a multibyte buffer for characters that are not in a
2303 unibyte string that contains non-ASCII characters.
2304
69f60cdc
JD
23052013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2306
2307 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2308 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2309
0d6224d4
PE
23102013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2313
3c542890
KH
23142013-06-18 Kenichi Handa <handa@gnu.org>
2315
f7e3f7cd
KH
2316 * font.c (Ffont_spec): Signal an error for an invalid font name
2317 (Bug#14648).
3c542890 2318
9349e5f7
PE
23192013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2322 In particular this ports to 32-bit sparc Sun cc.
2323 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2324 array with a dummy element at specpdl[-1], so that its address can
2325 be taken portably.
2326 (unbind_to): Do not copy the binding; not needed, now that we
2327 copy old_value in the one place where the copy is needed.
2328 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2329 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2330 (union specbinding): Rename from struct specbinding. Redo layout
2331 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2332 which is not portable. With Sun C 5.12 32-bit sparc, the
2333 declaration causes nargs to be an unsigned bitfield, a behavior
2334 that the C standard allows; but Emacs wants nargs to be signed.
2335 The overall type is now a union of structures rather than a
2336 structure of union of structures, and the 'kind' member is now a
2337 bitfield, so that the overall type doesn't grow. All uses changed.
2338 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2339
0a4df6a5
PE
23402013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2341
ec6ecaad
PE
2342 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2343 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2344
0a4df6a5
PE
2345 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2346
7bfe8dbc
EZ
23472013-06-17 Eli Zaretskii <eliz@gnu.org>
2348
2349 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2350 unless we know that the window w's frame is a frame object.
2351 Another attempt at solving bug#14062 and bug#14630.
2352
708e05f6
LMI
23532013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2354
2355 * textprop.c (property_set_type): New enum.
2356 (add_properties): Allow appending/prepending text properties.
2357 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2358 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2359 add_text_properties_1.
2360 (Fadd_face_text_property): New function that calls
2361 add_text_properties_1.
2362
84575e67
PE
23632013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 Move functions from lisp.h to individual modules when possible.
2366 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2367 * alloc.c (XFLOAT_INIT, set_symbol_name):
2368 * buffer.c (CHECK_OVERLAY):
2369 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2370 (set_char_table_parent):
2371 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2372 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2373 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2374 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2375 (set_blv_valcell):
2376 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2377 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2378 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2379 (backtrace_args, backtrace_debug_on_exit):
2380 * floatfns.c (CHECK_FLOAT):
2381 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2382 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2383 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2384 (set_hash_index_slot):
2385 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2386 * marker.c (CHECK_MARKER):
2387 * textprop.c (CHECK_STRING_OR_BUFFER):
2388 * window.c (CHECK_WINDOW_CONFIGURATION):
2389 Move here from lisp.h, and make these functions static rather than
2390 extern inline.
2391 * buffer.c (Qoverlayp):
2392 * data.c (Qsubrp):
2393 * fns.c (Qhash_table_p):
2394 * window.c (Qwindow_configuration_p):
2395 Now static.
2396 * lisp.h: Remove the abovementioned defns and decls.
2397
44e18199 2398 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2399 In lisp.h, prefer functions to function-like macros, and
2400 constants to object-like macros, when either will do. This:
2401 . simplifies use, as there's no more need to worry about
2402 arguments' side effects being evaluated multiple times.
2403 . makes the code easier to debug on some platforms.
2404 However, when using gcc -O0, keep using function-like macros
2405 for a few critical operations, for performance reasons.
2406 This sort of thing isn't needed with gcc -Og, but -Og
2407 is a GCC 4.8 feature and isn't widely-enough available yet.
2408 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2409 Remove enum lsb_bits; no longer needed.
2410 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2411 * buffer.c (Qoverlap):
2412 * data.c (Qsubrp):
2413 * fns.c (Qhash_table_p):
2414 Now extern, so lisp.h can use these symbols.
2415 * dispextern.h: Include character.h, for MAX_CHAR etc.
2416 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2417 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2418 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2419 (GLYPH_CODE_P): Move here from lisp.h.
2420 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2421 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2422 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2423 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2424 XUNTAG now returns void *.
2425 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2426 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2427 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2428 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2429 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2430 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2431 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2432 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2433 New macros, renamed from their sans-lisp_h_ counterparts.
2434 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2435 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2436 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2437 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2438 If compiling via GCC without optimization, define these as macros
2439 in addition to inline functions.
2440 To disable this, compile with -DINLINING=0.
2441 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2442 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2443 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2444 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2445 (INTMASK, VALMASK): Now macros, since static values cannot be
2446 accessed from extern inline functions.
2447 (VALMASK): Also a constant, for benefit of old GDB.
2448 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2449 is INTEGERP, which can fold it in.
5165d44a 2450 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2451 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2452 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2453 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2454 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2455 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2456 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2457 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2458 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2459 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2460 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2461 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2462 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2463 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2464 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2465 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2466 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2467 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2468 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2469 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2470 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2471 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2472 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2473 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2474 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2475 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2476 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2477 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2478 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2479 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2480 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2481 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2482 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2483 Now functions.
2484 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2485 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2486 (VALMASK): Define in one place rather than in two, merging the
2487 USE_LSB_TAG parts; this is simpler.
2488 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2489 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2490 Move up, to avoid use before definition.
2491 Also include "globals.h" earlier, for the same reason.
2492 (make_natnum): New function.
2493 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2494 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2495 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2496 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2497 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2498 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2499 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2500 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2501 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2502 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2503 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2504 (Qwindow_configuration_p, Qimage): New forward declarations.
2505 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2506 (STRING_COPYIN): Remove; unused.
2507 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2508 (xcar_addr, xcdr_addr): New functions. All uses changed.
2509 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2510 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2511 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2512 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2513 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2514 (TYPE_RANGED_INTEGERP): Simplify.
2515 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2516 (setlocale, fixup_locale, synchronize_system_messages_locale)
2517 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2518 Now empty functions, not macros.
2519 (functionp): Return bool, not int.
2520 * window.c (Qwindow_configuration_p): Now extern,
2521 so window.h can use it.
2522 * window.h (Qwindowp): Move decl back to lisp.h.
2523
9583ec36
EZ
25242013-06-15 Eli Zaretskii <eliz@gnu.org>
2525
2526 * xdisp.c (Fline_pixel_height): New function, required for solving
2527 bug #14567.
2528
210272ce
PE
25292013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2532
de0503df
SM
25332013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2534
2535 * lread.c (syms_of_lread):
2536 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2537
afbfe143
KD
25382013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2539
2540 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2541
d177e213
XF
25422013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2543
2544 * fileio.c (expand_file_name): Doc fix.
2545
05e3e412
PE
25462013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2547
f7394b12
PE
2548 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2549 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2550 Wait for self, not for 0. This can't hurt on GNU or similar
2551 system, and may help with Cygwin.
2552
05e3e412
PE
2553 * keyboard.c: Don't use PROP (...) as an lvalue.
2554 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2555 Use set_prop (A, B), not PROP (A) = B.
2556
17dd3097
EZ
25572013-06-10 Eli Zaretskii <eliz@gnu.org>
2558
2559 * xdisp.c (get_it_property): Use it->window instead of generating
2560 a Lisp object from it->w.
2561
52fab9c9
EZ
25622013-06-09 Eli Zaretskii <eliz@gnu.org>
2563
2564 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2565 get-char-property the window that is being rendered, instead of
2566 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2567 (compute_display_string_pos): When W is NULL, use the current
2568 buffer as the object to pass to get-char-property.
2569 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2570 pointer member of the bidi iterator, since no window is pertinent
2571 to this function.
52fab9c9 2572
5bf97bfc
EZ
25732013-06-08 Eli Zaretskii <eliz@gnu.org>
2574
2575 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2576 being displayed, and pass it to compute_display_string_pos.
2577 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2578 (bidi_paragraph_init): All callers changed.
2579
2580 * xdisp.c (init_from_display_pos, init_iterator)
2581 (handle_single_display_spec, next_overlay_string)
2582 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2583 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2584 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2585 (compute_display_string_pos): Accept additional argument, the
2586 window being displayed, and pass it to Fget_char_property.
2587 (Bug#14575)
2588
2589 * dispextern.h (struct bidi_it): New member w, the window being
2590 displayed.
2591 (compute_display_string_pos): Adjust prototype.
2592
5de0e011
JD
25932013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2594
e7b41c4c 2595 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2596
2597 * process.c (wait_reading_process_output): Check for NS before GLIB.
2598 GLIB may be linked in due to rsvg, but ns_select must be called.
2599
5de0e011
JD
2600 * xgselect.c (xg_select): Remove call to window_system_available
2601 and g_main_context_pending at the top, so Gdk events (i.e. file
2602 notify) are processed when Emacs is started with -nw.
2603
a822acff
EZ
26042013-06-07 Eli Zaretskii <eliz@gnu.org>
2605
2606 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2607 (ctagsfiles3): New variable, includes only *.m files.
2608 (TAGS): Use an explicit language name in the regular expressions,
2609 to avoid transformation of '/SOMETHING' by MSYS to
2610 'c:\MSYS\SOMETHING'.
2611
6c0a9ed1
RC
26122013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2613
2614 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2615
9ef6111b
EZ
26162013-06-06 Eli Zaretskii <eliz@gnu.org>
2617
2618 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2619 still need to set the mouse pointer shape and activate help-echo.
2620 (Bug#14558)
2621
7d300d64
PE
26222013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 A few porting etc. fixes for the new file monitor code.
2625 See the thread containing
2626 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2627 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2628 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2629 (dir_monitor_callback, Fgfile_rm_watch):
2630 Use assq_no_quit instead of Fassoc, for speed.
2631 (dir_monitor_callback, Fgfile_rm_watch):
2632 eassert that the monitor is a fixnum.
2633 (dir_monitor_callback): No need for CDR_SAFE.
2634 Simplify building of lisp with alternative tails.
2635 (Fgfile_add_watch, Fgfile_rm_watch):
2636 Do not assume glib functions set errno reliably on failure.
2637 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2638 and signal an error otherwise.
2639 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2640 Use Fdelq instead of Fdelete, for speed.
2641
817ebfcf
EZ
26422013-06-05 Eli Zaretskii <eliz@gnu.org>
2643
2644 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2645 don't insist on being invoked on a highlighted tool-bar button.
2646 Avoids losing tool-bar functionality when mouse-highlight is nil.
2647 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2648 Don't highlight when mouse-highlight is nil.
2649 (note_mouse_highlight): When mouse-highlight is nil, don't return
2650 right away; instead, run tool-bar and mode-line highlight
2651 subroutine, clear any existing highlight, and revert the mouse
2652 pointer to its default shape. (Bug#14558)
2653
55577e7c
SM
26542013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2655
2656 * lisp.mk (lisp): Add prog-mode.el.
2657
f019a684
PE
26582013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2659
2660 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2661 * process.c (dummy_handler): New function.
2662 (lib_child_handler): New static var.
2663 (handle_child_signal): Invoke it.
2664 (catch_child_signal): If a library has set up a signal handler,
2665 save it into lib_child_handler.
2666 (init_process_emacs): If using glib and not on Windows, tickle glib's
2667 child-handling code so that it initializes its private SIGCHLD handler.
2668 * syssignal.h (SA_SIGINFO): Default to 0.
2669 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2670 31; it should no longer be needed now.
2671
90db8702
MA
26722013-06-05 Michael Albinus <michael.albinus@gmx.de>
2673
2674 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2675
2676 * gfilenotify.c (globals_of_gfilenotify): New function.
2677 (syms_of_gfilenotify): Move global initialization there.
2678
2679 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2680
bfa3acd6
SM
26812013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2682
2683 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2684 * keyboard.c (menu_bar_items, tool_bar_items):
2685 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2686 not override local keymaps any more.
2687
ba59bd80
EZ
26882013-06-04 Eli Zaretskii <eliz@gnu.org>
2689
2690 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2691
7f203aa1
EZ
26922013-06-03 Eli Zaretskii <eliz@gnu.org>
2693
9337e206
EZ
2694 * w32console.c (initialize_w32_display): Return the dimensions of
2695 the console window via 2 additional arguments, not via the current
2696 frame. This avoids crashes due to overrunning the bounds of
2697 frame's decode_mode_spec_buffer, which is not resized following
2698 the change of the frame dimensions from the initial 10x10.
2699
2700 * w32term.h (w32_initialize_display_info): Adjust prototype.
2701
2702 * term.c (init_tty): Take dimensions of the frame from the values
2703 returned by initialize_w32_display.
2704
7f203aa1
EZ
2705 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2706 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2707 (LIBES): Add $(GFILENOTIFY_LIBS).
2708
2709 * w32inevt.c (handle_file_notifications): Add dummy implementation
2710 for !HAVE_W32NOTIFY.
2711
2712 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2713
55a87246
JD
27142013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2715
2716 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2717
2718 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2719
2720 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2721
3d5ee10a
PE
27222013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 Fix minor problems found by static checking.
2725 * data.c (pure_write_error):
2726 Use xsignal2, not Fsignal, as Fsignal might return.
2727 * eval.c (set_backtrace_debug_on_exit): Now static.
2728 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2729 No longer inline. EXTERN_INLINE is needed only for functions
2730 defined in .h files. Reindent function header as per GNU style.
2731 (backtrace_p, backtrace_top, backtrace_next):
2732 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2733 compiler or linker. Add extern decls to pacify gcc -Wall.
2734 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2735 Now static.
2736 * frame.c (free_monitors): Define only on platforms that need it.
2737 * nsterm.m (ns_term_init):
2738 * process.c (catch_child_signal):
2739 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2740 defined on all porting targets these days.
2741 * process.c, process.h (catch_child_signal):
2742 Make it extern only if NS_IMPL_GNUSTEP is defined.
2743
e2d8a6f0
EZ
27442013-06-03 Eli Zaretskii <eliz@gnu.org>
2745
2746 * w32.c (gettimeofday): Make the signature identical to prototype
2747 in nt/inc/sys/time.h.
2748
a8a7c5f6
SM
27492013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2750
2751 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2752 .gdbinit.
2753
2754 * keyboard.c (safe_run_hooks_error): Improve error message.
2755
2756 * data.c (pure_write_error): Add `object' argument.
2757 * puresize.h (CHECK_IMPURE): Use it.
2758
c9628c79
MA
27592013-06-03 Michael Albinus <michael.albinus@gmx.de>
2760
2761 * Makefile.in (NOTIFY_OBJ): New variable.
2762 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2763
2764 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2765 Call syms_of_gfilenotify.
2766
2767 * gfilenotify.c: New file.
2768
2769 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2770 and Qfile_w32notify.
2771 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2772 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2773
2774 * lisp.h: Declare syms_of_gfilenotify.
2775
2776 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2777
2f592f95
SM
27782013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2779
2780 Merge the specpdl and backtrace stacks. Make the structure of the
2781 specpdl entries more obvious via a tagged union of structs.
2782 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2783 (enum specbind_tag): New enum.
2784 (struct specbinding): Make it a tagged union of structs.
2785 Add a case for backtrace records.
2786 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2787 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2788 (backtrace_debug_on_exit): New accessors.
2789 (struct backtrace): Remove.
2790 (struct catchtag): Remove backlist field.
2791 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2792 Move to eval.c.
2793 (Flocal_variable_p): Speed up the common case where the binding is
2794 already loaded.
2795 * eval.c (backtrace_list): Remove.
2796 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2797 (set_backtrace_args, set_backtrace_nargs)
2798 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2799 (backtrace_next): New functions.
2800 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2801 (unwind_to_catch, internal_lisp_condition_case)
2802 (internal_condition_case, internal_condition_case_1)
2803 (internal_condition_case_2, internal_condition_case_n): Don't bother
2804 with backtrace_list any more.
2805 (Fsignal): Adjust to new backtrace format.
2806 (grow_specpdl): Move up.
2807 (record_in_backtrace): New function.
2808 (eval_sub, Ffuncall): Use it.
2809 (apply_lambda): Adjust to new backtrace format.
2810 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2811 data.c.
2812 (specbind): Adjust to new specpdl format. Simplify.
2813 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2814 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2815 backtrace format.
2816 (mark_backtrace): Remove.
2817 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2818 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2819 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2820 Use mark_specpdl.
2821 * profiler.c (record_backtrace): Use get_backtrace.
2822 (handle_profiler_signal): Use backtrace_top_function.
2823 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2824 accessor functions.
2825
c0342369
JD
28262013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2827
2828 * process.h (catch_child_signal): Declare.
2829
2830 * process.c (catch_child_signal): New function.
2831 (init_process_emacs): Call it.
2832
2833 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2834 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2835 NS_IMPL_COCOA.
2836 (x_set_cursor_type): Remove declaration.
2837 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2838 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2839 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2840 (ns_get_color): Use F suffix on float.
2841 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2842 (ns_get_rgb_color): Remove.
2843 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2844 (note_mouse_movement): x and y are CGFloat.
2845 (ns_draw_fringe_bitmap): Remove unused rowY.
2846 Change #if to COCOA && >= 10_6.
2847 (ns_draw_window_cursor): Remove unused overspill.
2848 (ns_draw_underwave): width and x are EamcsCGFloat.
2849 (ns_draw_box): thickness is CGFloat.
2850 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2851 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2852 if not in main thread.
2853 (ns_get_pending_menu_title, ns_check_menu_open)
2854 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2855 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2856 (sendFromMainThread:): New method.
2857 (changeFont:): size is CGFloat.
2858 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2859 Disable warning about permanent text.
2860 (characterIndexForPoint:): Adjust return type depending on GNUStep
2861 version.
2862 (mouseDown:): delta is CGFloat.
2863 (updateFrameSize): Remove unised variable f.
2864 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2865 Cast float to EmacsCGFloat.
2866 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2867 also to -1 when restoring.
2868 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2869 inside NS_IMPL_COCOA.
2870 (toggleFullScreen:): Put call to toggleFullScreen inside
2871 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2872 (setPosition:portion:whole:): por is CGFloat.
2873 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2874 (mouseDown:): Use CGFloat.
2875 (mouseDragged:): Remove unised variable edge.
2876 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2877
2878 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2879 of CGFloat differs.
2880 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2881 when NS_IMPL_GNUSTEP.
2882 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2883 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2884 (EmacsToolbar): Add clearAll. Add tag argument to
2885 addDisplayItemWithImage.
2886 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2887
2888 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2889
2890 * nsmenu.m (ns_update_menubar): Make static.
2891 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2892 (fillWithWidgetValue:): Add cast to SEL for setAction.
2893 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2894 (update_frame_tool_bar): Update code for GNUStep.
2895 (clearAll): New method.
2896 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2897 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2898 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2899 call to insertItemWithItemIdentifier.
2900 (validateVisibleItems): Fix indentation.
2901 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2902 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2903 UtilityWindow to aStyle, remove call to setStyleMask.
2904
2905 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2906
2907 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2908 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2909 Use F suffix on floats.
2910 (ns_char_width): Returns CGFloat.
2911 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2912 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2913 DPSxshow.
2914 (ns_glyph_metrics): CGFloat instead of float.
2915
a0eb10b3
JB
2916 * nsfns.m (x_set_foreground_color, x_set_background_color):
2917 Use EmacsCGFloat.
2918 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2919 remove unused variables.
2920 (Fns_read_file_name): Keep track if panel is for save.
2921 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2922 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2923 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2924 Just return the input if GNUStep.
c0342369
JD
2925 (x_screen_planes): Remove.
2926 (Fxw_color_values): Use EmacsCGFloat
2927 (Fns_display_monitor_attributes_list): Only get screen number for
2928 Cocoa.
ef099a94 2929 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2930 EmacsSavePanel.
2931 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2932 ns_directory_from_panel.
2933
da9aff11
PE
29342013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2935
2936 * process.c (handle_child_signal): Also use WCONTINUED.
2937 This is so that list-processes doesn't mistakenly list the process
2938 as stopped, when the process has actually been continued and is
2939 now running.
2940
0e64479a
PE
29412013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2942
fc186a96
PE
2943 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2944 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2945 not already configured.
2946
0e64479a
PE
2947 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2948
38b787fa
EZ
29492013-05-29 Eli Zaretskii <eliz@gnu.org>
2950
2951 * Makefile.in (mostlyclean): Remove *.res files.
2952
22513e52
SM
29532013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2954
2955 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2956 a buffer (bug#8447).
2957
6ef3db10
EZ
29582013-05-27 Eli Zaretskii <eliz@gnu.org>
2959
2960 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2961 display vector, and we backtrack, handle the case that the
2962 previous character position is also displayed from a display
2963 vector or covered by a display string or image. (Bug#14476)
2964
6799bb26
JD
29652013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2966
2967 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2968 (struct MonitorInfo, free_monitors): Remove.
2969 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2970 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2971 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2972 Qframes, Qsource.
2973
2974 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2975 (struct MonitorInfo, free_monitors): Remove.
2976 (ns_screen_name): Make static.
2977 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2978 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2979 Qframes, Qsource.
2980
2981 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2982 (struct MonitorInfo): New struct.
2983 (free_monitors, make_monitor_attribute_list): Declare.
2984
22513e52
SM
2985 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2986 New Lisp_Object:s.
6799bb26
JD
2987 (free_monitors, make_monitor_attribute_list): New functions.
2988 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2989 Qsource.
2990
38cd43eb
XF
29912013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2992
2993 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2994
2af0948d
SM
29952013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2996
a7eb9b0f
SM
2997 * keyboard.c: Apply keyboard decoding only to events that come directly
2998 from the tty, not from unread-command-events (bug#14368).
2999 (read_event_from_main_queue): New function, extracted from read_char).
3000 (read_decoded_char): Remove.
3001 (read_decoded_event_from_main_queue): New function to replace it.
3002 (read_char): Use it.
3003 (read_key_sequence): Use read_char rather than read_decoded_char.
3004
2af0948d
SM
3005 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3006
1413e9a5
BR
30072013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3008
3009 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3010
e6d2f155
KH
30112013-05-22 Kenichi Handa <handa@gnu.org>
3012
3013 The following changes are to fix the setting of
3014 buffer-file-coding-system on, for instance, C-x RET c unix RET
3015 _FILE_OF_DOS_EOL_TYPE_ RET.
3016
3017 * coding.h (struct coding_system): New member detected_utf8_chars.
3018
3019 * coding.c (detect_coding_utf_8): Count characters and check EOL
3020 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3021 BOM is there.
3022 (setup_coding_system): Do not initialize coding->head_ascii.
3023 (check_ascii): Do not set coding->eol_seen but update it. Do not
3024 call adjust_coding_eol_type here.
1413e9a5
BR
3025 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3026 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3027 of the found coding-system.
3028 (decode_coding_gap): Cancel previous change. Utilize the
3029 character numbers counted by detect_coding_utf_8. Fix detection
3030 of BOM for utf-8.
3031
ab56a6f4 30322013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3033
3034 * search.c (looking_at_1): Only set last_thing_searched if the match
3035 changed the match-data (bug#14281).
3036
ecc3c6ed
DA
30372013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3038
3039 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3040 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3041 (move_it_vertically_backward): Likewise.
3042
5ba8bf35
YM
30432013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3044
3045 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3046 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3047 (Fx_display_mm_width, Fx_display_mm_height):
3048 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3049
91e8418b 3050 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3051 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3052 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3053 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3054 (Fx_display_backing_store, Fx_display_visual_class)
3055 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3056 (Fx_display_grayscale_p, Fx_display_pixel_width)
3057 (Fx_display_pixel_height, Fx_display_planes)
3058 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3059 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3060 (Fx_display_mm_width, Fx_display_mm_height)
3061 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3062 height for all physical monitors as in X11.
3063
fc30d803
SM
3064 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3065 Return pixel width or height for all physical monitors as in X11.
91e8418b 3066
31ff141c
PE
30672013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3068
3069 Port --enable-gcc-warnings to clang.
3070 * bytecode.c (exec_byte_code):
3071 * regex.c:
3072 Redo diagnostic pragmas to pacify clang, too.
3073 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3074 * editfns.c (Fencode_time):
3075 * fileio.c (file_accessible_directory_p):
3076 * font.c (font_unparse_xlfd):
3077 Use '&"string"[index]' instead of '"string" + (index)'.
3078 * undo.c (user_error): Remove; unused.
3079
df065a0b
EZ
30802013-05-16 Eli Zaretskii <eliz@gnu.org>
3081
04d360e7
EZ
3082 * insdel.c (insert_1_both): Document the arguments, instead of
3083 referring to insert_1, which no longer exists.
3084
5bb98290
EZ
3085 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3086 some window, increment windows_or_buffers_changed, so that
3087 *Messages* display in that window is updated. (Bug#14408)
3088
df065a0b
EZ
3089 * w32.c: Include epaths.h.
3090 (init_environment): Use cmdproxy.exe without leading directories.
3091 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3092 case.
3093 (gettimeofday): Adjust signature and return value to Posix
3094 expectations.
3095
3096 * unexw32.c (open_output_file): Delete the existing emacs.exe
3097 before creating it, to break the hard link to the versioned
3098 executable.
3099
3100 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3101 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3102 (FIRSTFILE_OBJ): New variables.
3103 (W32_RES): Rename to EMACSRES. All users changed.
3104 (base_obj): Use $(CM_OBJ).
3105 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3106 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3107 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3108 $(W32_RES_LINK) before $(LIBES).
3109 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3110
1aa8d505
SM
31112013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3112
6e911150
SM
3113 * makefile.w32-in (DOC): Use just "DOC".
3114
3115 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3116
1aa8d505
SM
3117 * process.c: Export default filters and sentinels to Elisp.
3118 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3119 New constants.
3120 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3121 (Fset_process_sentinel, Fformat_network_address):
3122 Default to them instead of nil.
3123 (server_accept_connection): Sentinels can't be nil any more.
3124 (read_and_dispose_of_process_output): New function, extracted from
3125 read_process_output.
3126 (read_process_output): Use it; filters can't be nil.
3127 (Finternal_default_process_filter): New function, extracted from
3128 read_process_output.
3129 (exec_sentinel_unwind): Remove function.
3130 (exec_sentinel): Don't zilch sentinel while running.
3131 (status_notify): Sentinels can't be nil.
3132 (Finternal_default_process_sentinel): New function extracted from
3133 status_notify.
3134 (setup_process_coding_systems): Default filter is not nil any more.
3135 (syms_of_process): Export new Elisp functions and initialize
3136 new constants.
3137 * lisp.h (make_lisp_proc): New function.
3138
5ac2eb34
SM
31392013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3140
3141 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3142
eda9c7d7
EZ
31432013-05-14 Eli Zaretskii <eliz@gnu.org>
3144
3145 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3146 unless we know that the window w is a leaf window.
3147 Another attempt at solving bug#14062.
eda9c7d7 3148
8fdeaad5
JD
31492013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3150
3151 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3152 fdesc (Bug#14375).
3153
44aa9ee6
PE
31542013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 * image.c (gif_load): Check that subimages fit (Bug#14345).
3157
759fd763
SM
31582013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3159
3160 * lread.c (skip_dyn_eof): New function.
3161 (read1): Use it to skip the end of a file in response to #@00.
3162
3163 * doc.c (get_doc_string): Slightly relax the sanity checking.
3164
4465bfb4
JD
31652013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3166
3167 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3168 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3169 (MonitorInfo): New struct.
3170 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3171 (Fns_display_monitor_attributes_list): New functions.
3172 (display-usable-bounds): Remove.
3173 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3174 Qsource.
3175
7583e2a0
PE
31762013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3177
3178 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3179 (GTK_CHECK_VERSION): New macro, if not already defined.
3180 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3181 replaced by GTK_CHECK_VERSION.
3182
ad75d77e
PE
31832013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * xterm.h (GTK_PREREQ): New macro.
3186 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3187 to use this macro instead, for consistency and clarity.
3188
07525f77
EZ
31892013-05-08 Eli Zaretskii <eliz@gnu.org>
3190
3191 * xdisp.c (row_for_charpos_p): New function, with code of
3192 cursor_row_p, but accepts an additional argument CHARPOS instead
3193 of using a hardcoded PT.
3194 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3195 (row_containing_pos): Call row_for_charpos_p instead of partially
3196 doing the same. Fixes cursor positioning under longlines-mode
3197 when longlines-show-effect includes more than one newline, when
3198 moving the cursor vertically up.
3199
d901fc8d
JB
32002013-05-08 Juanma Barranquero <lekktu@gmail.com>
3201
3202 * makefile.w32-in (ACL_H): New macro.
3203 ($(BLD)/fileio.$(O)): Update dependencies.
3204
f269bc61
PE
32052013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3206
e7b41c4c 3207 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3208 * Makefile.in (LIB_ACL): New macro.
3209 (LIBACL_LIBS): Remove.
3210 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3211 * fileio.c: Include <acl.h>.
3212 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3213 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3214 !acl_errno_valid.
3215 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3216 it ourselves.
3217
f269bc61
PE
3218 * unexelf.c: Don't assume ElfW (Half) fits in int.
3219 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3220 when dealing with ElfW (Half) values, since they can exceed 2**31
3221 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3222 (entry_address): Omit unused NUM arg. All uses changed.
3223
a261c53e
JL
32242013-05-07 Juri Linkov <juri@jurta.org>
3225
3226 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3227 to the string converted from number with `Fnumber_to_string'.
3228 (Bug#14254)
3229
2b66427d
PE
32302013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3233 This fixes a problem introduced by my previous change.
3234
15acfe41
GM
32352013-05-07 Glenn Morris <rgm@gnu.org>
3236
3237 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3238
5ea03bf5
JD
32392013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3240
3241 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3242
e0c9d565
PE
32432013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 Static checking by GCC 4.8.0.
3246 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3247 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3248 (x_get_monitor_attributes_fallback)
3249 (x_get_monitor_attributes_xinerama)
3250 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3251 Define only if USE_GTK.
3252 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3253 (x_get_monitor_attributes_fallback): Omit unused locals.
3254 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3255 Use double, not float, to avoid mixed-mode floating point arithmetic.
3256
4e3f9230
YM
32572013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3258 Jan Djärv <jan.h.d@swipnet.se>
3259
3260 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3261 (XINERAMA_CFLAGS): New macros.
3262 (ALL_CFLAGS, LIBES): Use them.
3263
3264 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3265 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3266 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3267 (syms_of_xfns): DEFSYM them.
3268 (struct MonitorInfo): New struct.
3269 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3270 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3271 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3272 (x_get_monitor_attributes_xinerama): New functions.
3273 (Fx_display_monitor_attributes_list): New primitive.
3274 (syms_of_xfns): Defsubr it.
3275
3276 * xterm.h (x_display_info): Add Xatom_net_workarea and
3277 Xatom_net_current_desktop.
3278
3279 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3280 and dpyinfo->Xatom_net_current_desktop.
3281
05839b6a
EZ
32822013-05-06 Eli Zaretskii <eliz@gnu.org>
3283
3284 * xdisp.c (pos_visible_p): Use the special code for finding the
3285 beginning of a display property or overlay for any "replacing"
3286 display property, not just for display strings. This solves
3287 incorrect reporting of position by posn-at-point. (Bug#14241)
3288
dc4a2ee0
PE
32892013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3290
5ee94506
PE
3291 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3292 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3293 Verify that ElfW (Half) fits in int.
3294 (fatal): Use same signature as lisp.h.
3295 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3296 configure and build with -DUNEXELF_DEBUG without worrying about
3297 other modules that use DEBUG.
3298 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3299 possibly-wide integers now uses it instead of plain fprintf.
3300 (entry_address): New function, which avoids problems with 32-bit
3301 overflow on 64-bit hosts.
3302 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3303 (round_up): Don't assume the remainder fits in int.
3304 (find_section): Use bool for boolean. Simplify debug code.
3305 (unexec): Don't assume file sizes fit in int or size_t.
3306 Omit unnecessary trailing newline in 'fatal' format.
3307 Use strerror rather than outputting decimal error number.
3308 Remove unused code when emacs is not defined;
3309 this file relies on Emacs now.
3310 Don't assume e_phnum and e_shnum are positive.
3311
dc4a2ee0
PE
3312 * regex.c: Fix problems when DEBUG is defined.
3313 (extract_number, extract_number_and_incr): Define regardless of
3314 whether DEBUG is defined; that's simpler and makes the code less
3315 likely to go stale in the normal case when DEBUG is not defined.
3316 Return int rather than taking an int * arg. All callers changed.
3317 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3318 Remove, replacing with ...
3319 (DEBUG_PRINT): New macro. All callers changed.
3320 (DEBUG_COMPILES_ARGUMENTS): New macro.
3321 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3322 (print_compiled_pattern, print_double_string) [DEBUG]:
3323 Use prototype rather than old-style definition.
3324 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3325 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3326 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3327 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3328 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3329 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3330 This matters only when DEBUG is defined.
3331
14c7ed05
EZ
33322013-05-05 Eli Zaretskii <eliz@gnu.org>
3333
3334 * xdisp.c (set_iterator_to_next): Set the
3335 ignore_overlay_strings_at_pos_p flag only if we are _really_
3336 iterating over an overlay string, as indicated by the
3337 current.overlay_string_index member. (Bug#14306)
3338
e6076b1b
JD
33392013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3340
3341 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3342 to where it is used, to avoid autorelease issues (Bug#14050).
3343
cbee2131
PE
33442013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3345
3346 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3347 * fileio.c (syms_of_fileio): Implement this.
3348 * filelock.c (create_lock_file): If symbolic links don't work, so
3349 we use a regular file as a lock file, do not fsync the lock file;
3350 it's not needed.
3351
30c7e542
SM
33522013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3353
3354 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3355 (syms_of_minibuf): Adjust accodingly.
3356 * lread.c (Fread):
3357 * callint.c (Fcall_interactively): Adjust calls accordingly.
3358
5bebd186
EZ
33592013-05-04 Eli Zaretskii <eliz@gnu.org>
3360
3361 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3362 w->contents is a buffer before computing everything else.
3363 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3364
3365 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3366 assertion violations. (Bug#14062)
3367
0fb0a4f3
DR
33682013-05-01 David Reitter <david.reitter@gmail.com>
3369
3370 * nsfns.m (ns_tooltip): Initialize.
3371
9e63b4a5
EZ
33722013-04-28 Eli Zaretskii <eliz@gnu.org>
3373
3374 * coding.c (decode_coding_gap): Don't remove the character before
3375 a newline unless it's a CR character. (Bug#14287)
3376
ad60824e
DN
33772013-04-28 Dan Nicolaescu <dann@gnu.org>
3378
3379 * dispextern.h (struct face): Move enum face_underline_type
3380 earlier so that bitfields can be in the same word.
3381
edbdcec0
JD
33822013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3383
3384 * nsfns.m (handlePanelKeys): New function.
3385 (EmacsOpenPanel:performKeyEquivalent:)
3386 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3387 arrows/function/control and copy/paste keys (Bug#14296).
3388
0208ede7
JL
33892013-04-27 Juri Linkov <juri@jurta.org>
3390
3391 * callint.c (Fcall_interactively): Call `Qread_number' for
3392 interactive code letter `n' instead of using duplicate code.
3393 (Bug#14254)
3394
b8dd59f7
PE
33952013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 * systime.h (make_timeval): Declare as 'const'.
3398
8bd722db
KH
33992013-04-27 Kenichi Handa <handa@gnu.org>
3400
3401 * font.c (font_open_entity): Always open a font of manageable
3402 size.
3403
13d0e56f 34042013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3405
f780d632
PE
3406 Port better to AIX (Bug#14258).
3407 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3408 to pacify AIX xlc.
3409
ec509856
KH
34102013-04-24 Kenichi Handa <handa@gnu.org>
3411
3412 * coding.c (decode_coding_iso_2022): When an invalid escape
3413 sequence is encountered, reset the invocation and designation
3414 status to the safest one.
3415
84fc48e5
PE
34162013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3417
3418 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3419 Without this fix, "make distclean" leaves stamp-h1 behind.
3420
806bda47
EC
34212013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3422
3423 * w32fns.c (w32_fullscreen_rect): New function to compute the
3424 window rectangle for the given fullscreen mode.
3425 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3426 longer tunes the window size. This keeps the window's edges flush
3427 with the screen and allows the taskbar to hide itself in fullboth.
3428
3429 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3430 window decorations and uses the entire screen.
3431
3432 * w32term.h (w32_fullscreen_rect) Add prototype.
3433 (struct w32_output): Replace normal_width, normal_height,
3434 normal_top, and normal_left members with a single normal_placement
3435 struct.
3436 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3437 Remove macros.
3438 (FRAME_NORMAL_PLACEMENT): New macro.
3439
9cc2810b
JB
34402013-04-16 Juanma Barranquero <lekktu@gmail.com>
3441
3442 * minibuf.c (Ftest_completion): Silence compiler warning.
3443
fd16b54c
EZ
34442013-04-15 Eli Zaretskii <eliz@gnu.org>
3445
3446 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3447 bug#14062.
fd16b54c
EZ
3448
3449 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3450 parentheses.
3451
3452 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3453 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3454 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3455 parentheses where appropriate.
3456
9e3379a0
PE
34572013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3458
3459 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3460
ddd6b685
EZ
34612013-04-14 Eli Zaretskii <eliz@gnu.org>
3462
3463 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3464 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3465 Mention in the doc string that setting these variables takes
3466 effect only after a call to set-window-buffer. (Bug#14200)
3467
29b79ba1
EZ
34682013-04-13 Eli Zaretskii <eliz@gnu.org>
3469
3470 * indent.c (Fvertical_motion): Don't consider display strings on
3471 overlay strings as display strings on the buffer position we
3472 started from. This prevents vertical cursor motion from jumping
3473 more than one line when there's an overlay string with a display
3474 property at end of line.
3475 Reported by Karl Chen <Karl.Chen@quarl.org> in
3476 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3477
562c6ee9
SM
34782013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3479
3480 * window.c (select_window): `record_buffer' even if window is
3481 already selected (bug#14191).
3482
fcc1fe85
EZ
34832013-04-11 Eli Zaretskii <eliz@gnu.org>
3484
3485 * window.c (Fwindow_end): Test more flags, including the buffer's
3486 last_overlay_modified flag, to determine whether the window's
3487 display is really up-to-date. Prevents the function from
3488 returning a stale value. (Bug#14170)
3489 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3490 current matrix.
3491
f009190a
EZ
34922013-04-10 Eli Zaretskii <eliz@gnu.org>
3493
3494 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3495 garbaged only if it is not already the top frame on its TTY.
3496 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3497 there are GUI frames open in the same session. (Bug#13864)
3498
78ce603d
SM
34992013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3500
3501 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3502 of marking the idle timers directly.
3503
a8036e40
SM
35042013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3505
3506 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3507 tables (bug#14054).
3508
7ffe7ef6
SM
35092013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3510
3511 * window.c (select_window): Don't record_buffer while the invariant is
3512 temporarily broken (bug#14161).
3513
3514 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3515
7d9f6883
EZ
35162013-04-07 Eli Zaretskii <eliz@gnu.org>
3517
3518 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3519
5406cfd9
RF
35202013-04-07 Romain Francoise <romain@orebokech.com>
3521
3522 Ignore additional platform-specific ACL errors (Bug#13702).
3523 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3524 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3525
95c0e83b
JD
35262013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3527
3528 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3529 f->output_data.ns.
3530
876da980
PE
35312013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3534 This bug was introduced by my 2013-02-25 change that simplified
3535 data_start configuration. Without this change, on GNU/Linux
3536 an Emacs configured with --enable-profiling fails immediately
3537 due to a profiler signal.
3538 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3539 with these flags. On platforms where special flags are needed
3540 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3541 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3542 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3543
7452b7bd
DA
35442013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3545
3546 Get rid of some platform-specific functions examining window
3547 system and its capabilities. This is a partial rework of the
3548 2013-04-05 change.
3549 * lisp.h (have_menus_p): Remove prototype. This function is
3550 replaced with platform-independent window_system_available.
3551 (check_window_system): Move to...
3552 * frame.h (decode_window_system_frame, window_system_available):
3553 ...here, add new prototypes.
3554 * frame.c (window_system_available, decode_window_system_frame):
3555 New functions.
3556 (check_window_system): Platform-independent now.
3557 * xterm.h (x_in_use): Remove declaration.
3558 (check_x_frame):
3559 * w32term.h (check_x_frame):
3560 * nsterm.h (check_x_frame): Remove prototypes. This function
3561 is replaced with platform-independent decode_window_system_frame.
3562 * msdos.c (have_menus_p): Remove.
3563 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3564 Remove platform-specific functions. Use check_window_system,
3565 decode_window_system_frame and check_ns_display_info where
3566 appropriate. Minor style and comment tweaks.
3567 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3568 (check_x_frame): Likewise.
3569 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3570 Likewise.
3571 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3572 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3573 * xmenu.c, xselect.c: All related users changed.
3574
251e9147
KH
35752013-04-03 Kenichi Handa <handa@gnu.org>
3576
3577 The following changes is to optimize the code for reading UTF-8
3578 files.
3579
562c6ee9 3580 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3581 changed. Check EOL format. Do not call adjust_coding_eol_type
3582 here.
3583 (check_utf_8): New function.
3584 (adjust_coding_eol_type): Do nothing if already adjusted.
3585 (detect_coding): Compare the return value of check_ascii with
3586 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3587 (decode_coding_gap): Optimize for valid UTF-8.
3588
8bc369d4
KH
35892013-03-21 Kenichi Handa <handa@gnu.org>
3590
3591 * coding.c (syms_of_coding): Cancel previous change.
3592
3593 * insdel.c (insert_from_gap): Fix previous change.
3594
73931ad1
DA
35952013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3596
3597 Consistently use platform-specific function to detect window system.
3598 * lisp.h (check_window_system): New prototype. This function is
3599 going to replace check_x, check_w32 and check_ns.
3600 (have_menus_p): Mention msdos.c in comment.
3601 * fontset.c (check_window_system_func): Remove. Adjust all users.
3602 * fontset.h (check_window_system_func): Remove prototype.
3603 * nsterm.h (check_ns):
3604 * xterm.h (check_x):
3605 * w32term.h (check_w32): Likewise.
3606 * menu.c (Fx_popup_menu): Use check_window_system.
3607 * msdos.c (check_window_system): Define for MS-DOS.
3608 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3609 * w32fns.c (check_window_system): Likewise for MS-Windows.
3610 * xfns.c (check_window_system): Likewise for X.
3611 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3612 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3613
7216e43b
PE
36142013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 Prefer < to > in range checks such as 0 <= i && i < N.
3617 This makes it easier to visualize quantities on a number line.
3618 This patch doesn't apply to all such range checks,
3619 only to the range checks affected by the 2013-03-24 change.
3620 This patch reverts most of the 2013-03-24 change.
3621 * alloc.c (xpalloc, Fgarbage_collect):
3622 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3623 * character.c (string_escape_byte8):
3624 * charset.c (read_hex):
3625 * data.c (cons_to_unsigned):
3626 * dispnew.c (update_frame_1):
3627 * doc.c (Fsubstitute_command_keys):
3628 * doprnt.c (doprnt):
3629 * editfns.c (hi_time, decode_time_components):
3630 * fileio.c (file_offset):
3631 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3632 * font.c (font_intern_prop):
3633 * frame.c (x_set_alpha):
3634 * gtkutil.c (get_utf8_string):
3635 * indent.c (check_display_width):
3636 * keymap.c (Fkey_description):
3637 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3638 * lread.c (read1):
3639 * minibuf.c (read_minibuf_noninteractive):
3640 * process.c (wait_reading_process_output):
3641 * search.c (Freplace_match):
3642 * window.c (get_phys_cursor_glyph):
3643 * xdisp.c (redisplay_internal):
3644 * xsmfns.c (smc_save_yourself_CB):
3645 Prefer < to > for range checks.
3646 * dispnew.c (sit_for): Don't mishandle NaNs.
3647 This fixes a bug introduced in the 2013-03-24 change.
3648 * editfns.c (decode_time_components): Don't hoist comparison.
3649 This fixes another bug introduced in the 2013-03-24 change.
3650
92759988
DA
36512013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3652
3653 * frame.h (struct frame): Drop scroll_bottom_vpos
3654 member becaue all real users are dead long ago.
3655 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3656 * xdisp.c (redisplay_internal): Adjust user.
3657
9a1971bb
GM
36582013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3659
f38ab167
JD
3660 * nsmenu.m (showAtX:Y:for:): setLevel to
3661 NSPopUpMenuWindowLevel (Bug#13998).
3662
6d01f1fe
JD
36632013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3664
3665 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3666 (ns_check_pending_open_menu): Declare.
3667
3668 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3669 (x_activate_menubar): Update the menu with title that matches
3670 ns_get_pending_menu_title, and call
3671 ns_check_pending_openmenu (Bug#12698).
3672 (menuWillOpen:): New method.
3673 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3674
3675 * nsterm.m (menu_will_open_state, menu_mouse_point)
3676 (menu_pending_title): New varaibles.
3677 (ns_get_pending_menu_title, ns_check_menu_open)
3678 (ns_check_pending_open_menu): New functions.
3679
781f4782
DA
36802013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3681
3682 * indent.c (current_column_bol_cache): Remove leftover which is not
3683 used in Fmove_to_column any more.
3684 (current_column, scan_for_column): Adjust users.
3685 * keyboard.c (last_point_position_buffer, last_point_position_window):
3686 Remove leftovers which are not used for recording undo any more.
3687 (command_loop_1, syms_of_keyboard): Adjust users.
3688 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3689 redisplay_window any more.
3690 (move_it_to): Adjust user.
3691
1921c31b
JB
36922013-03-29 Juanma Barranquero <lekktu@gmail.com>
3693
3694 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3695 Update dependencies.
3696
717b8bcd
SM
36972013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3698
3699 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3700 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3701 forward references.
3702
e74aeda8
DA
37032013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3704
3705 * window.h (struct window): Replace hchild, vchild and buffer slots
3706 with the only contents slot. This is possible because each valid
3707 window may have either the child window (in vertical or horizontal
3708 combination) or buffer to display (for the leaf window). Using that,
3709 a lof of operations to traverse and/or change window hierarchies may
3710 be simplified. New member horizontal is used to distinguish between
3711 horizontal and vertical combinations of internal windows.
3712 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3713 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3714 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3715 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3716 Use contents slot, not buffer, where appropriate.
3717 (wset_combination): New function.
3718 (wset_buffer): Add eassert.
3719 (Fframe_first_window): Simplify the loop reaching first window.
3720 (Fwindow_buffer): Use WINDOW_LEAF_P.
3721 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3722 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3723 (unshow_buffer): Convert initial debugging check to eassert.
3724 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3725 (make_parent_window, window_resize_check, window_resize_apply)
3726 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3727 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3728 Adjust to match struct window changes.
3729 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3730 (mark_window_cursors_off, count_windows, get_leaf_windows)
3731 (foreach_window_1): Simplify the loop.
3732 * alloc.c (mark_object): Do not check for the leaf window because
3733 internal windows has no glyph matrices anyway.
3734 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3735 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3736 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3737 (build_frame_matrix_from_window_tree, mirror_make_current)
3738 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3739 (update_window_tree, set_window_update_flags): Simplify the loop.
3740 (sync_window_with_frame_matrix_rows): Enforce live window.
3741 Use contents slot, not buffer, where appropriate.
3742 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3743 and WINDOW_HORIZONTAL_COMBINATION_P.
3744 (make_frame_visible_1): Simplify the loop.
3745 Use contents slot, not buffer, where appropriate.
3746 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3747 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3748 (expose_window_tree): Likewise.
3749 Use contents slot, not buffer, where appropriate.
3750 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3751 to avoid deleted windows. Use contents slot instead of buffer.
3752 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3753 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3754 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3755 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3756
121ab1cd
EZ
37572013-03-28 Eli Zaretskii <eliz@gnu.org>
3758
ef454cf7
EZ
3759 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3760 identify the reasons for assertion violations in bug#14062 and
3761 similar ones.
21e930f8
EZ
3762 (Fx_show_tip): Fix compilation error under
3763 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3764
121ab1cd
EZ
3765 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3766 Reported by <rzl24ozi@gmail.com>.
3767
5c89ca24
DA
37682013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3769
3770 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3771 start marker...
562c6ee9
SM
3772 (unwind_with_echo_area_buffer): ...to restore it here.
3773 This is needed to ensure that...
5c89ca24
DA
3774 (redisplay_window): ...both window markers are valid here,
3775 which is verified by eassert.
3776 * editfns.c (save_excursion_save): Do not assume that
3777 selected_window always displays the buffer.
c7f53895
DA
3778 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3779 Fix comment.
5c89ca24 3780
f557c1b1
SM
37812013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3782
3783 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3784 the upcase table.
3785
40693bba 37862013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3787
3788 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3789
c86f791f
EZ
37902013-03-27 Eli Zaretskii <eliz@gnu.org>
3791
3792 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3793 since MinGW's w32api headers do. This avoids compiler warnings.
3794
3795 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3796 if already defined.
3797
c6e72e17
EZ
37982013-03-26 Eli Zaretskii <eliz@gnu.org>
3799
3800 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3801
54e95010
JD
38022013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3803
3804 * gtkutil.c (style_changed_cb): Check if frame is live and an
3805 X frame (Bug#14038).
3806
b88b62de
EZ
38072013-03-26 Eli Zaretskii <eliz@gnu.org>
3808
a18d7de6
EZ
3809 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3810 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3811 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3812 MinGW64.
8f5e14c8
EZ
3813 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3814 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3815
b88b62de
EZ
3816 Fix incompatibilities between MinGW.org and MinGW64 headers.
3817 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3818
3819 * w32.c (REPARSE_DATA_BUFFER): Guard with
3820 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3821
c074e458
JD
38222013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3823
3824 * xterm.c: Include X11/XKBlib.h
3825 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3826
908589fd
AS
38272013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3828
3829 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3830 written backwards.
3831 * blockinput.h (input_blocked_p): Likewise.
3832 * bytecode.c (exec_byte_code): Likewise.
3833 * callproc.c (call_process_kill, call_process_cleanup)
3834 (Fcall_process): Likewise.
3835 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3836 (Fccl_execute_on_string): Likewise.
3837 * character.c (string_escape_byte8): Likewise.
3838 * charset.c (read_hex): Likewise.
3839 * cm.c (calccost): Likewise.
3840 * data.c (cons_to_unsigned): Likewise.
3841 * dired.c (directory_files_internal, file_name_completion):
3842 Likewise.
3843 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3844 (sit_for): Likewise.
3845 * doc.c (Fsubstitute_command_keys): Likewise.
3846 * doprnt.c (doprnt): Likewise.
3847 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3848 * emacsgtkfixed.c: Likewise.
3849 * fileio.c (file_offset, Fwrite_region): Likewise.
3850 * floatfns.c (Fexpt, fmod_float): Likewise.
3851 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3852 Likewise.
3853 * font.c (font_intern_prop): Likewise.
3854 * frame.c (x_set_alpha): Likewise.
3855 * gtkutil.c (get_utf8_string): Likewise.
3856 * indent.c (check_display_width): Likewise.
3857 * intervals.c (create_root_interval, rotate_right, rotate_left)
3858 (split_interval_right, split_interval_left)
3859 (adjust_intervals_for_insertion, delete_node)
3860 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3861 (merge_interval_right, merge_interval_left, copy_intervals)
3862 (set_intervals_multibyte_1): Likewise.
3863 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3864 * keymap.c (Fkey_description): Likewise.
3865 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3866 * lread.c (openp, read_integer, read1, string_to_number):
3867 Likewise.
3868 * menu.c (ensure_menu_items): Likewise.
3869 * minibuf.c (read_minibuf_noninteractive): Likewise.
3870 * print.c (printchar, strout): Likewise.
3871 * process.c (create_process, Faccept_process_output)
3872 (wait_reading_process_output, read_process_output, send_process)
3873 (wait_reading_process_output): Likewise.
3874 * profiler.c (make_log, handle_profiler_signal): Likewise.
3875 * regex.c (re_exec): Likewise.
3876 * regex.h: Likewise.
3877 * search.c (looking_at_1, Freplace_match): Likewise.
3878 * sysdep.c (get_child_status, procfs_ttyname)
3879 (procfs_get_total_memory): Likewise.
3880 * systime.h (EMACS_TIME_VALID_P): Likewise.
3881 * term.c (dissociate_if_controlling_tty): Likewise.
3882 * window.c (get_phys_cursor_glyph): Likewise.
3883 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3884 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3885 Likewise.
3886 * xfns.c (Fx_window_property): Likewise.
3887 * xmenu.c (set_frame_menubar): Likewise.
3888 * xselect.c (x_get_window_property, x_handle_dnd_message):
3889 Likewise.
3890 * xsmfns.c (smc_save_yourself_CB): Likewise.
3891 * xterm.c (x_scroll_bar_set_handle): Likewise.
3892
2bf7d27a
DA
38932013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3894
3895 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3896 to be optional or nil. Adjust comment and convert it to docstring.
3897 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3898 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3899
a9ebfa0b
PE
39002013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3901
3902 Static checking by GCC 4.8-20130319.
3903 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3904 * process.c (Fset_process_datagram_address)
3905 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3906 * xdisp.c (get_char_face_and_encoding):
3907 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3908 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3909 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3910
4f3576ee
KB
39112013-03-24 Ken Brown <kbrown@cornell.edu>
3912
789b5e9a
KB
3913 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3914 fix compilation on 64-bit Cygwin, where underscores are not
3915 automatically prepended.
3916
4f3576ee
KB
3917 * w32term.c (w32_initialize): Silence compiler warning.
3918
b5b7745f
EZ
39192013-03-23 Eli Zaretskii <eliz@gnu.org>
3920
cdc0d0bd
EZ
3921 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3922 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3923 variables, to save and restore frame dimensions.
3924 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3925 after returning from a 'fullscreen' configuration.
3926 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3927 to avoid races between the main thread and the input thread.
3928
3929 * w32term.h (struct w32_output): New members normal_width,
3930 normal_height, normal_top, normal_left, and prev_fsmode.
3931 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3932 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3933 members of a frame.
3934
b5b7745f
EZ
3935 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3936 'fullscreen' parameter. Always record previous width and height
3937 of the frame, except when switching out of maximized modes, so
3938 that they could be restored correctly, instead of resetting to the
3939 default frame dimensions. Send SC_RESTORE command to the frame,
3940 unless we are going to send SC_MAXIMIZE, to restore the frame
3941 resize hints in the mouse pointer shown by the window manager.
3942 (Bug#14032)
3943
3944 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3945
3946 * lisp.h (get_frame_param): Adjust conditions for prototype
3947 declaration.
3948
a3454eed
KB
39492013-03-22 Ken Brown <kbrown@cornell.edu>
3950
3951 * unexcw.c: Drop unneeded inclusion of w32common.h.
3952 (report_sheap_usage): Declare.
3953 (read_exe_header): Add magic numbers for x86_64.
3954 (fixup_executable): Fix printf format specifier for unsigned long
3955 argument.
3956
5a49b79c
DA
39572013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3958
3959 * frame.h (struct frame): Put menu_bar_window under #ifdef
3960 because this member is not needed when X toolkit is in use.
3961 (fset_menu_bar_window):
3962 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3963 (free_glyphs, update_frame):
3964 * xdisp.c (expose_frame): Likewise.
3965 (display_menu_bar): Likewise. Remove redundant eassert.
3966 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3967 toolkit is in use.
3968
d6723bf7
PE
39692013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3970
7b1123d8
PE
3971 Use functions and constants to manipulate Lisp_Save_Value objects.
3972 This replaces code that used macros and strings and token-pasting.
3973 The change makes the C source a bit easier to follow,
3974 and shrinks the Emacs executable a bit.
3975 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3976 (make_save_value): Change 1st arg from string to enum. All callers
3977 changed.
3978 (INTX): Remove.
3979 (mark_object): Use if, not #if, for GC_MARK_STACK.
3980 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3981 (XSAVE_OBJECT): Now functions, not macros.
3982 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3983 the constant was never used.
3984 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3985 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3986 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3987 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3988 New constants.
3989 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3990 type3 with a single member save_type. All uses changed.
3991 (save_type, set_save_pointer, set_save_integer): New functions.
3992 * print.c (PRINTX): Remove.
3993
d6723bf7
PE
3994 * alloc.c: Remove redundant static declarations.
3995
5f24fa51
DA
39962013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3997
3998 * window.h (struct window): Convert left_col, top_line, total_lines
3999 and total_cols from Lisp_Objects to integers. Adjust comments.
4000 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4001 Remove.
4002 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4003 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4004 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4005 Adjust users where appropriate.
4006
42143acd
DA
40072013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4008
4009 * frame.h (struct frame): Drop resx and resy because the same data is
4010 available from window system-specific output context. Adjust users.
562c6ee9
SM
4011 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4012 New functions to provide defaults when no window system available.
42143acd 4013 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4014 (NUMVAL): Move from xdisp.c.
42143acd
DA
4015 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4016 (Ffont_face_attributes, Fopen_font):
4017 * image.c (gs_load):
4018 * w32font.c (fill_in_logfont):
4019 * xdisp.c (calc_pixel_width_or_height):
4020 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4021 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4022
c0a17406
KH
40232013-03-20 Kenichi Handa <handa@gnu.org>
4024
4025 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4026 to 1 (temporary workaround until a bug related to ASCII
4027 optimization is fixed).
4028
095d384d
DA
40292013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4030
4031 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4032 Signal error if window is not internal. Adjust docstring.
4033 (delete_all_child_windows): Use combination_limit to save the buffer.
4034 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4035 * print.c (syms_of_print): Initialize debugging output not here...
4036 (init_print_once): ...but in a new function here.
4037 * lisp.h (init_print_once): Add prototype.
4038 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4039
748fa866
DA
40402013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4041
4042 * window.c (window_resize_check, window_resize_apply)
4043 (window_from_coordinates, recombine_windows, set_window_buffer)
4044 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4045 (Fsplit_window_internal, Fdelete_window_internal)
4046 (freeze_window_starts): Use bool for booleans.
4047 * window.h (window_frame_coordinates, resize_frame_windows)
4048 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4049
81519fd2
SM
40502013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4051
4052 * dispnew.c (bitch_at_user): Use `user-error'.
4053
6db423a9
KB
40542013-03-17 Ken Brown <kbrown@cornell.edu>
4055
4056 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4057 as return type of image_background. (Bug#13981)
4058 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4059
8f2906f5
JD
40602013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4061
960ce480 4062 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4063 (ns_select): Don't return with result uninitialized.
960ce480 4064
8f2906f5
JD
4065 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4066 and getDirectory.
4067
81519fd2
SM
4068 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4069 New functions.
8f2906f5
JD
4070 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4071 directories. If filename is nil, get directory name (Bug#13932).
4072 Use getFilename and getDirectory.
4073 (getFilename, getDirectory): New methods for EmacsSavePanel and
4074 EmacsOpenPanel.
4075 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4076
cded56c1
PE
40772013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4078
4079 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4080
251e9147 40812013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4082
4083 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4084 (adjust_after_replace): Make it back to static. Delete the third
4085 arg text_at_gap_tail. Cancel the code for handling it.
4086
4087 * coding.h (struct coding_system): New member eol_seen.
4088
4089 * coding.c (detect_ascii): New function.
4090 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4091 when the source bytes are actually scanned. On detecting for
4092 coding_category_utf_8_auto, call detect_ascii instead of scanning
4093 source bytes directly.
4094 (produce_chars): Call insert_from_gap with the new arg 0.
4095 (encode_coding): Likewise.
4096 (decode_coding_gap): Control ASCII optimization by the variable
4097 disable_ascii_optimization instead of #ifndef .. #endif.
4098 Deccode EOL format according to coding->eol_seen.
4099 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4100 variable.
4101
8a44e6d1
KH
4102 * lisp.h (adjust_after_replace): Cancel externing it.
4103 (insert_from_gap): Adjust prototype.
4104
5f795e34
EZ
41052013-03-15 Eli Zaretskii <eliz@gnu.org>
4106
4107 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4108 FULLSCREEN_MAXIMIZED. (Bug#13935)
4109
f258b4be
DA
41102013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4111
4112 * region-cache.c (find_cache_boundary, move_cache_gap)
4113 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4114 Simplify debugging check and convert to eassert. Adjust comment.
4115 (pp_cache): Put under ENABLE_CHECKING.
4116
a5cc4dde
EZ
41172013-03-14 Eli Zaretskii <eliz@gnu.org>
4118
4119 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4120 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4121 and WM_ACTIVATEAPP.
4122 (w32fullscreen_hook): If the frame is visible, reset
4123 f->want_fullscreen flag after changing the frame size. If the
4124 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4125 (Bug#13953)
4126
3fc5e44a
DC
41272013-03-13 Daniel Colascione <dancol@dancol.org>
4128
4129 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4130 too so that these builds can use Cygwin's file conversion
4131 functions. (We've been building and linking cygw32.o all along
4132 and just not using it.)
4133
47d7532e
PE
41342013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 File synchronization fixes (Bug#13944).
4137 * Makefile.in (LIB_FDATASYNC): New macro.
4138 (LIBES): Use it.
4139 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4140 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4141 Don't worry about HAVE_FSYNC, since a substitute fsync is
4142 available if the system lacks one.
4143 (Fwrite_regin): Retry fsync if interrupted.
4144
c7ffccaf
EZ
41452013-03-13 Eli Zaretskii <eliz@gnu.org>
4146
4e2df81d 4147 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4148 activated, call w32fullscreen_hook, to make sure the new frame
4149 dimensions are in effect. (Bug#13937)
4150
8a7debc1
DA
41512013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4152
4153 * xdisp.c (init_iterator): Simplify because both character and byte
4154 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4155 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4156 character and byte positions can be obtained from marker.
8a7debc1 4157
7fd8c501
PE
41582013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4159
d9df6f40
PE
4160 Static checking by Sun C 5.12.
4161 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4162 * bytecode.c (exec_byte_code):
4163 * dispnew.c (init_display):
4164 * eval.c (error):
4165 * fileio.c (Fsubstitute_in_file_name):
4166 * keyboard.c (Fevent_convert_list):
4167 * keymap.c (Fsingle_key_description):
4168 * term.c (maybe_fatal, fatal):
4169 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4170 * xsmfns.c (Fhandle_save_session):
4171 Omit unreachable code.
4172 * keymap.c (map_keymap_char_table_item): Cast void * to
4173 a function pointer type; the C Standard requires this.
4174
7fd8c501
PE
4175 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4176 Include <sys/param.h> unconditionally, as that works elsewhere and
4177 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4178 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4179 and FreeBSD now.
4180
a020afb9 4181See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4182
4183;; Local Variables:
4184;; coding: utf-8
aac0c6e3
MR
4185;; End:
4186
ab422c4d 4187 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4188
4189 This file is part of GNU Emacs.
4190
4191 GNU Emacs is free software: you can redistribute it and/or modify
4192 it under the terms of the GNU General Public License as published by
4193 the Free Software Foundation, either version 3 of the License, or
4194 (at your option) any later version.
4195
4196 GNU Emacs is distributed in the hope that it will be useful,
4197 but WITHOUT ANY WARRANTY; without even the implied warranty of
4198 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4199 GNU General Public License for more details.
4200
4201 You should have received a copy of the GNU General Public License
4202 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.