* msdos.c (IT_set_terminal_window): Remove no-op.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0c7f856e
DA
12013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * msdos.c (IT_set_terminal_window): Remove no-op.
4 (initialize_msdos_display): Adjust terminal setup.
5 * w32console.c (w32con_set_terminal_window): Remove no-op.
6 (initialize_w32_display): Adjust terminal setup.
7 * w32term.c (w32_set_terminal_window): Remove no-op.
8 (w32_create_terminal): Adjust terminal setup.
9 * xterm.c (XTset_terminal_window): Remove no-op.
10 (x_create_terminal): Adjust terminal setup.
11
a892a94c
DA
122013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
13
14 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
15 Remove no-ops.
16 (ns_create_terminal): Adjust terminal setup.
17 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
18 Remove no-ops.
19 (w32_create_terminal): Adjust terminal setup.
20 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
21 Remove no-ops.
22 (x_create_terminal): Adjust terminal setup.
23
cf91889a
DA
242013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
25
26 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
27 (CLIP_TEXT_POS_FROM_MARKER): New macro.
28 * dispnew.c (buffer_posn_from_coords):
29 * window.c (Fwindow_end, displayed_window_lines):
30 * xdisp.c (redisplay_mode_lines): Use it.
31
5b0891df
JD
322013-09-01 Jan Djärv <jan.h.d@swipnet.se>
33
34 * fontset.c (face_for_char): Check char in the current face font first
35 if HAVE_NS (Bug#15138).
36
0a357e98
MR
372013-08-31 Martin Rudalics <rudalics@gmx.at>
38
39 * window.c (temp_output_buffer_show): Make sure window returned
40 by display_buffer is live (Bug#15213).
41
9d7693d7
DA
422013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
43
44 Minor cleanup to avoid forward declarations.
45 * coding.h (struct ccl_spec): Remove forward declaration.
46 * composite.h (toplevel): Include font.h.
47 (struct composition_it, struct face, struct font_metrics):
48 Remove forward declaration.
49 * dispextern.h (struct image, struct atimer): Likewise.
50 * emacsgtkfixed.h (struct frame): Likewise.
51 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
52 * font.h (struct font_driver, struct font, struct glyph_string)
53 (struct face): Remove forward declaration.
54 * fontset.h (struct face, struct font): Likewise.
55 * frame.h (toplevel): Style cleanup.
56 (enum output_method): Move to...
57 * termhooks.h (enum output_method): ...here.
58 (struct glyph, struct frame, struct ns_display_info)
59 (struct x_display_info, struct w32_display_info):
60 Remove forward declaration.
61 * xterm.h (toplevel): Include termhooks.h.
62 (struct font, struct window, struct glyph_matrix, struct frame)
63 (struct input_event, struct face, struct image): Remove forward
64 declaration.
65 * gtkutil.h (struct _widget_value): Likewise.
66 * keyboard.h (toplevel): Include termhooks.h.
67 (struct input_event): Remove forward declaration.
68
032f7451
DA
692013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
70
71 * intervals.c (set_point_from_marker): New function.
72 * editfns.c (Fgoto_char):
73 * process.c (Finternal_default_process_filter):
74 * window.c (select_window_1): Use it.
75 * buffer.h (set_point_from_marker): Add prototype.
76
3f940c5a
EZ
772013-08-29 Eli Zaretskii <eliz@gnu.org>
78
79 * w32.c (term_winsock): Call release_listen_threads before calling
80 WSACleanup.
81 (_sys_wait_accept): Wait for accept event in a loop with a finite
82 timeout, instead of waiting indefinitely. Will hopefully avoid
83 hanging during exit because WSACleanup deadlocks waiting for the
84 event object to be released. (Bug#14333)
85
86 * w32proc.c (release_listen_threads): New function, signals all
87 the reader threads that listen for connections to stop waiting.
88
89 * w32.h (release_listen_threads): Add prototype.
90
101ed2bb
DA
912013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
92
93 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
94 field of new marker (for sanity and safety).
20de2834
DA
95 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
96 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 97
1f5cf200
DA
982013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
99
100 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
101 (x_after_update_window_line, x_scroll_bar_create):
102 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
103 (handle_one_xevent, x_clear_frame_area):
104 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
105 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
106 * xterm.h (x_clear_area): Adjust prototype.
107
d2b36813
DA
1082013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Hook scanning and indentation functions to find_newline. This helps
111 to avoid duplicated code and renders more respect to newline cache.
112 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
113 * cmds.c (Fforward_line):
114 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
115 Use find_newline and avoid unnecessary point movements.
116 * search.c (scan_newline): Implement on top of find_newline.
117
3ec7babc
SM
1182013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
119
120 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
121 scoped code (bug#11258).
122
5ab473cd
JD
1232013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
124
125 * nsterm.m (last_window): New variable.
126 (EV_TRAILER2): New macro.
127 (EV_TRAILER): Call EV_TRAILER2.
128 (mouseMoved:): Add support for mouse-autoselect-window
129 on nextstep (Bug#6888).
130
78779650
AS
1312013-08-28 Andreas Schwab <schwab@suse.de>
132
133 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
134 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
135 Remove unused macro definitions.
136 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
137 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
138 Only define if emacs.
78779650 139
c3c4768d
DA
1402013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
141
142 Prefer enum glyph_row_area to int where appropriate.
143 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
144 Fix comment.
145 (window_box, window_box_width, window_box_left, window_box_left_offset)
146 (window_box_right, window_box_right_offset): Adjust prototypes.
147 * xdisp.c (window_box, window_box_width, window_box_left)
148 (window_box_left_offset, window_box_right, window_box_right_offset):
149 Use enum glyph_row_area. Adjust users and tweak comment where needed.
150 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
151 * nsterm.m (ns_clip_to_row):
152 * w32term.c (w32_clip_to_row):
153 * xterm.c (x_clip_to_row): Likewise.
154
6bdcbfe1
DA
1552013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
156
157 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
158 (Fprevious_overlay_change): Fast path for buffer with no overlays.
159
50b13cde
PE
1602013-08-28 Paul Eggert <eggert@cs.ucla.edu>
161
162 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
163 for portability to hosts where /bin/sh has problems.
164
f60e429a
DA
1652013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
166
167 Redesign redisplay interface to drop global output_cursor.
168 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
169 (toplevel): Remove declaration of output_cursor.
170 (set_output_cursor, x_cursor_to): Remove prototype.
171 * window.h (struct window): New member output_cursor.
172 (output_cursor_to): New function to replace RIF member.
173 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
174 (update_text_area, set_window_cursor_after_update): Use it.
175 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
176 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
177 * nsterm.m (ns_update_window_begin, ns_update_window_end):
178 * w32term.c (x_update_window_begin, x_update_window_end):
179 * xterm.c (x_update_window_begin, x_update_window_end):
180 Adjust to use per-window output cursor.
181
43aac990
PE
1822013-08-27 Paul Eggert <eggert@cs.ucla.edu>
183
d486344e
PE
184 Simplify SELECT_TYPE-related code.
185 Like EMACS_TIME, this portability layer is no longer needed, since
186 Emacs has been using fd_set as a portability layer for some time.
187 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
188 (SELECT_TYPE): Remove. All uses changed to fd_set.
189 (fd_set) [!FD_SET]: New typedef.
190
43aac990
PE
191 Simplify EMACS_TIME-related code.
192 This portability layer is no longer needed, since Emacs has been
193 using struct timespec as a portability layer for some time.
194 * atimer.h, buffer.h, dispextern.h, xgselect.h:
195 Include <time.h> rather than "systime.h"; that's all that's needed now.
196 * dispnew.c: Include <timespec.h> rather than "systime.h";
197 that's all that's needed now.
198 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
199 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
200 TIMESPEC_RESOLUTION.
201 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
202 LOG10_TIMESPEC_RESOLUTION.
203 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
204 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
205 (make_emacs_time): Remove. All used changed to make_timespec.
206 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
207 (current_timespec): Rename from current_emacs_time. All uses changed.
208 (add_emacs_time): Remove. All uses changed to timespec_add.
209 (sub_emacs_time): Remove. All uses change dot timespec_sub.
210 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
211 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
212 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
213 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
214 (current_timespec): Rename from current_emacs_time. All uses changed.
215 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
216 changed to timespec_cmp.
217 * xgselect.c: Include <timespec.h>, since our .h files don't.
218
d350e350
DA
2192013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
220
221 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
222 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
223 Remove the leftovers.
224 * gtkutil.c (toplevel): Do not declare Qxft but include
225 font.h to do so.
226 * image.c (toplevel): Do not declare Vlibrary_cache because
227 it's already done in lisp.h.
228
9fed9729
DA
2292013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
230
231 * lisp.h (Mouse_HLInfo): Move from here...
232 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
233 (reset_mouse_highlight): New function.
234 * msdos.c (dos_set_window_size, IT_update_begin)
235 (internal_terminal_init):
236 * nsterm.m (ns_update_window_end, x_free_frame_resources)
237 (ns_initialize_display_info):
238 * w32console.c (initialize_w32_display):
239 * w32term.c (x_update_window_end, x_free_frame_resources)
240 (w32_initialize_display_info):
241 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
242 * window.c (Fdelete_other_windows_internal):
243 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
244 * termchar.h (toplevel):
245 * xterm.h (toplevel): Include dispextern.h.
246
f462f075
PE
2472013-08-26 Paul Eggert <eggert@cs.ucla.edu>
248
249 Fix minor problems found by static checking.
250 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
251 (expect): Avoid nested-if warning.
252 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
253 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
254 * nsterm.h, nsterm.m (ns_select):
255 * xgselect.c, xgselect.h (xg_select):
256 Adjust signature to better match pselect's.
257 * nsterm.m (ns_select):
258 Don't set *TIMEOUT, since pselect doesn't.
259 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
260 diagnostic about assigning const char * to it.
261 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
262
068f9124
SM
2632013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
264
265 * lread.c (substitute_object_recurse): Handle hash-tables as well
266 (bug#15190).
267
f5adc984
PE
2682013-08-26 Paul Eggert <eggert@cs.ucla.edu>
269
1fc8eb33
PE
270 Fix unlikely core dump in init_tty, and simplify terminfo case.
271 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
272 The old version incorrectly dumped core if malloc returned a
273 buffer containing only non-NUL bytes.
274 (init_tty): Do not allocate or free termcap buffers; the
275 struct does that for us now.
276 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
277 (struct tty_display_info): Define members termcap_term_buffer and
278 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
279 use them. Allocate them directly in struct rather than indirectly
280 via a pointer, to simplify init_tty.
281
f5adc984
PE
282 * frame.c (check_minibuf_window): Initialize 'window' properly,
283 so that Emacs reliably aborts later if 'window' is not initialized.
284
efec3894
JD
2852013-08-26 Jan Djärv <jan.h.d@swipnet.se>
286
287 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
288 of VoidSymbol (Bug#15154).
289
e1d0341e
DA
2902013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
291
292 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
293 mouse_face_beg_y and mouse_face_end_y.
294 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
295 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
296 Adjust users and update comment where appropriate.
297
bfff6445
MR
2982013-08-26 Martin Rudalics <rudalics@gmx.at>
299
300 * frame.c (check_minibuf_window): New function.
068f9124
SM
301 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
302 Call check_minibuf_window (Bug#15183).
bfff6445 303
c80016b3
DA
3042013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
305
306 * window.h (struct window): Replace last_cursor with last_cursor_vpos
307 because this is the only last cursor data we need to keep and consult.
308 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
309 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
310 Adjust users.
311
de396731
DA
3122013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
313
068f9124
SM
314 Fix recovering from possible decompression error.
315 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 316 the position where the partially decompressed data ends, and
447218dd 317 should count how many bytes was produced so far.
de396731
DA
318 * decompress.c (struct decompress_unwind_data): Add nbytes member.
319 (unwind_decompress): Really delete partially uncompressed data.
320 (Fzlib_decompress_region): Take decompressed data size into account.
321
c76826d9
DA
3222013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
323
324 * syntax.c (init_syntax_once): Adjust comment and do an early
325 initialization of Qchar_table_extra_slots just once...
326 * casetab.c (init_casetab_once):
327 * category.c (init_category_once):
328 * character.c (syms_of_character):
329 * coding.c (syms_of_coding):
330 * xdisp.c (syms_of_xdisp): ...and omit it here.
331
b34454d0
EZ
3322013-08-24 Eli Zaretskii <eliz@gnu.org>
333
11f20add
EZ
334 * xdisp.c (get_next_display_element): Don't apply to characters
335 from a display vector the logic of setting it->end_of_box_run_p
336 suitable for characters from a buffer. (Bug#15175)
337
b34454d0
EZ
338 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
339 to handle directories, rather than '_utime' which doesn't.
340 (Bug#15176)
341
6e1b469e
JD
3422013-08-24 Jan Djärv <jan.h.d@swipnet.se>
343
344 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
345 or fullscreen (Bug#14627).
346
9c05bccf
PE
3472013-08-24 Paul Eggert <eggert@cs.ucla.edu>
348
349 System-dependent integer overflow fixes.
350 * process.c (Fset_process_window_size): Signal an error if
351 the window size is outside the range supported by the lower level.
352 * sysdep.c (set_window_size): Return negative on error,
353 nonnegative on success, rather than -1, 0, 1 on not in system,
354 failure, success. This is simpler. Caller changed.
355 (serial_configure): Remove unnecessary initialization of local.
356 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
357 size fits in unsigned long; this isn't true on some 32-bit hosts.
358 Avoid buffer overrun if some future version of /proc/meminfo has a
359 variable name longer than 20 bytes.
360 (system_process_attributes) [__FreeBSD__]:
361 Don't assume hw.availpages fits in 'int'.
362
c365c355
PE
3632013-08-23 Paul Eggert <eggert@cs.ucla.edu>
364
365 Don't let very long directory names overrun the stack.
366 Fix some related minor problems involving "//", vfork.
367 * callproc.c (encode_current_directory): New function.
368 (call_process): Don't append "/"; not needed.
369 * fileio.c (file_name_as_directory_slop): New constant.
370 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
371 this can save the caller having to alloca.
372 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
373 Use SAFE_ALLOCA, not alloca.
374 (directory_file_name, Fexpand_file_name): Leave leading "//"
375 alone, since it can be special even on POSIX platforms.
376 * callproc.c (call_process):
377 * process.c (Fformat_network_address):
378 * sysdep.c (sys_subshell):
379 Use encode_current_directory rather than rolling our own.
380 (create_process): No need to encode directory; caller does that now.
381 * process.h (encode_current_directory): New decl.
382 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
383 Rework to avoid 'goto xyzzy;'.
384
6c6014d4
EZ
3852013-08-23 Eli Zaretskii <eliz@gnu.org>
386
387 * xdisp.c (handle_face_prop): If the default face was remapped use
388 the remapped face for strings from prefix properties. (Bug#15155)
389
9997ec56
DA
3902013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
391
392 Minor cleanup for redisplay interface and few related functions.
393 * frame.h (enum text_cursor_kinds): Move from here...
394 * dispextern.h (enum text_cursor_kinds): ...to here.
395 (toplevel): Drop unnecessary declarations.
396 (struct redisplay_interface): Use bool and enum text_cursor_kinds
397 in update_window_end_hook and draw_window_cursor functions.
398 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
399 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
400 * w32term.c (x_update_window_end,w32_draw_window_cursor):
401 * xterm.c (x_update_window_end, x_draw_window_cursor):
402 * xdisp.c (display_and_set_cursor, update_window_cursor)
403 (update_cursor_in_window_tree, x_update_cursor): Use bool and
404 enum text_cursor_kinds where appropriate.
405
7f780da6
DA
4062013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
407
408 Redesign redisplay interface to drop updated_row and updated_area.
409 * dispextern.h (updated_row, updated_area): Remove declaration.
410 (struct redisplay_interface): Pass glyph row and row area parameters
411 to write_glyphs, insert_glyphs and clear_end_of_line functions.
412 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
413 Adjust prototypes.
414 * dispnew.c (updated_row, updated_area): Remove.
415 (redraw_overlapped_rows, update_window_line): Adjust user.
416 (update_marginal_area, update_text_area): Likewise. Pass updated row
417 as a parameter. Prefer enum glyph_row_area to int where appropriate.
418 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
419 Adjust users.
420
26495794
PE
4212013-08-22 Paul Eggert <eggert@cs.ucla.edu>
422
423 * process.c (flush_pending_output): Remove stub.
424 All uses removed.
425
4a88129a
PE
4262013-08-21 Paul Eggert <eggert@cs.ucla.edu>
427
428 * callproc.c: Fix race that killed background processes (Bug#15144).
429 (call_process): New arg TEMPFILE_INDEX. Callers changed.
430 Record deleted process-id in critical section, not afterwards.
431 Don't mistakenly kill process created by a call-process invocation
432 that discards output and does not wait.
433
0c5307b0
DA
4342013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
435
436 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
437 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
438 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
439 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
440 to shut up compiler in mark_object.
441 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
442
0d7c1e66
PE
4432013-08-21 Paul Eggert <eggert@cs.ucla.edu>
444
445 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
446 We can't portably rely on PTY_OPEN doing that, even if
447 it calls posix_openpt with O_CLOEXEC.
448
3f246b65
KH
4492013-08-20 Kenichi Handa <handa@gnu.org>
450
451 * character.c (string_char): Improve commentary.
452
8c2f38aa
PE
4532013-08-20 Paul Eggert <eggert@cs.ucla.edu>
454
455 * image.c (SIGNATURE_DIGESTSIZE): Remove.
456 (struct animation_cache): Make signature a flexible array member.
457 All uses changed. This is a tad slower but may insulate us better
458 from future changes to ImageMagick.
459
bb566cea
PE
4602013-08-19 Paul Eggert <eggert@cs.ucla.edu>
461
462 * image.c: Shrink memory needed for animation cache.
463 (SIGNATURE_DIGESTSIZE): New constant.
464 (struct animation_cache): Make 'signature' a fixed size array of bytes.
465 (imagemagick_create_cache): Copy the signature. This saves
466 several KB of memory that ImageMagick wastes per signature.
467 Don't bother updating the update_time, as the caller does that now.
468 (imagemagick_prune_animation_cache): Don't destroy the signature, as
469 it's a fixed size struct member now.
470 (imagemagick_get_animation_cache): Always destroy the signature,
471 as it's now imagemagick_create_cache's responsibility to copy it.
472 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
473 and use memcmp rather than strcmp.
474 eassert that ImageMagick returns a signature of the specified length.
475
6da26928
LMI
4762013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
477
478 * image.c (imagemagick_get_animation_cache): Don't segfault on
479 each invocation.
453f4022
LMI
480 (imagemagick_get_animation_cache): Revert to previous definition
481 so that it actually works. But keep the memory leak fix.
482 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 483
22490125
PE
4842013-08-19 Paul Eggert <eggert@cs.ucla.edu>
485
d0139df5
PE
486 * image.c: Fix animation cache signature memory leak.
487 Fix some other minor performance problems while we're at it.
488 (imagemagick_create_cache): Clear just the members that
489 need clearing. Don't set update_time, as caller does that now.
490 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
491 Simplify by using pointer-to-pointer instead of a prev pointer.
492 (imagemagick_prune_animation_cache): Use make_emacs_time rather
493 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
494 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
495 it's already a copy. Free the signature probe unless it's cached.
496
22490125
PE
497 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
498 This was introduced by my 2013-08-12 fix for Bug#15035.
499
deb31e75
DA
5002013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
501
502 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
503 (imagemagick_prune_animation_cache): Now static.
504
319a4d03
LMI
5052013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
506
507 * image.c (imagemagick_get_animation_cache): Don't segfault when
508 pruning all entries.
509
f747d82e
KB
5102013-08-18 Ken Brown <kbrown@cornell.edu>
511
512 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
513 static heap if ENABLE_CHECKING is defined.
514 (max_bss_sbrk_ptr): New variable.
515 (bss_sbrk): Use it.
516 (report_sheap_usage): Report maximum static heap usage instead of
517 ending static heap usage.
518
d2c28fab
EZ
5192013-08-17 Eli Zaretskii <eliz@gnu.org>
520
521 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
522 of zlib_initialized according to the results of calling
523 init_zlib_functions.
524
274ff63f
LMI
5252013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
526
527 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 528 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
529 (imagemagick_load_image): Remove the ping_wand code, which only
530 apparently saved time on invalid animated images, and slowed down
531 everything else. Optimise for the common case.
274ff63f 532
2bede2ed
XF
5332013-08-16 Xue Fuqiao <xfq.free@gmail.com>
534
70ff8240
XF
535 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
536
de179a3e
XF
537 * editfns.c (insert_before_markers): Mention overlay in the doc string.
538
2bede2ed
XF
539 * marker.c (set_marker): Remove documentation of undefined behavior.
540
703dbeba
LMI
5412013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
542
543 * image.c (imagemagick_compute_animated_image): Animate correctly
544 when sub-images are smaller than the main image.
1d18b1e6
LMI
545 (imagemagick_compute_animated_image): Setting the iterator row to
546 zero is apparently not allowed.
79670014
LMI
547 (imagemagick_compute_animated_image): Allow images that say they
548 have sub-images that are bigger than the main image, but just crop
549 them.
703dbeba 550
63216c5e
JD
5512013-08-15 Jan Djärv <jan.h.d@swipnet.se>
552
553 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
554
a5b5f73f
LMI
5552013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
556
557 * image.c (imagemagick_compute_animated_image): Respect the GIF
558 disposal methods.
559
0fe73012
KB
5602013-08-15 Ken Brown <kbrown@cornell.edu>
561
562 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
563 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
564 needed.
565
691a357f
PE
5662013-08-15 Paul Eggert <eggert@cs.ucla.edu>
567
568 Fix minor problems found by static checking.
569 * frame.c (delete_frame):
570 * xdisp.c (next_element_from_display_vector):
571 Avoid uninitialized local.
572 * image.c (imagemagick_compute_animated_image): Port to C89.
573 Prefer usual GNU indentation style for loops.
574 Be more careful about bizarrely large sizes, by using ptrdiff_t
575 instead of int.
576
42fe2e88
DA
5772013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
578
579 Fix infinite frame selection loop (Bug#15025).
580 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
581
d39a3da6
EZ
5822013-08-15 Eli Zaretskii <eliz@gnu.org>
583
068f9124
SM
584 * xdisp.c (compute_window_start_on_continuation_line):
585 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
586 to make sure we end up setting the window start at the leftmost
587 visible character of the display line. This avoids funky
588 horizontal shifting because the window start is not kept on the
589 same position. (Bug#15090)
05426239
EZ
590 (next_element_from_display_vector): Support 'box' face attribute
591 in the face definitions of a display vector. (Bug#15099)
d39a3da6 592
6e856b69
LMI
5932013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
594
595 * image.c (imagemagick_compute_animated_image): Implement animated
596 images (bug#14700).
995be755
LMI
597 (imagemagick_compute_animated_image): Fix some compilation
598 warnings. Implement a very simple cache to make the animation
599 usable at all, but it should be replaced with a per-image cache.
6e856b69 600
d5a1acfa
DA
6012013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
602
603 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
604 to do `for' loops over alist values.
605 * buffer.h (FOR_EACH_BUFFER):
606 * process.c (FOR_EACH_PROCESS): Use it.
607 (handle_child_signal, status_notify, Fget_buffer_process)
608 (kill_buffer_processes): Use FOR_EACH_PROCESS.
609
9c253307
DA
6102013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
611
612 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
613 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
614 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
615 to xzalloc and so avoid redundant call to memset.
616 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
617 members because it is allocated with xzalloc and so already zeroed.
618
05e64f9f
KB
6192013-08-14 Ken Brown <kbrown@cornell.edu>
620
621 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
622 (Bug#15094).
623
5b71542d
DA
6242013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
625
626 Utility function and macro to copy Lisp string to C string.
627 * lisp.h (xlispstrdupa): New macro.
628 (xlispstrdup): New prototype.
629 * alloc.c (xlispstrdup): New function.
630 * callint.c (Fcall_interactively):
631 * fileio.c (Ffile_name_directory, Fexpand_file_name)
632 (Fsubstitute_in_file_name):
633 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
634 * image.c (x_create_bitmap_from_file):
635 * w32term.c (w32_term_init):
636 * xterm.c (x_term_init): Use xlispstrdup.
637
71530c97
LMI
6382013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
639
4ce82fb8
LMI
640 * image.c (imagemagick_load_image): Make animated pictures work.
641 There's still some problems with background color settings, though
642 (bug#14700).
643
71530c97
LMI
644 * decompress.c (unwind_decompress): Always restore point.
645
7510a061
XF
6462013-08-14 Xue Fuqiao <xfq.free@gmail.com>
647
648 * marker.c (set_marker): Reformat documentation.
649
01c3051f
PE
6502013-08-14 Paul Eggert <eggert@cs.ucla.edu>
651
aab1fcdf
PE
652 * xdisp.c (cursor_type_changed): Now static.
653
01c3051f
PE
654 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
655 Use changed. This avoids the need to call xmalloc and for the
656 caller to call xfree, and avoids memory leaks in some situations.
657
2084152a
DA
6582013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
659
660 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
661 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
662 (redisplay_window): If window_end_valid is cleared due to non-zero
663 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
664 so do not call to try_cursor_movement for that window.
2084152a 665
02455cb6
DA
6662013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
667
668 * window.h (struct window): Convert window_end_pos and
669 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
670 (wset_window_end_pos, wset_window_end_vpos): Remove.
671 * dispnew.c (adjust_glyph_matrix):
672 * window.c (Fwindow_end, replace_window, set_window_buffer)
673 (make_window):
674 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
675 (set_vertical_scroll_bar, redisplay_window, try_window)
676 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
677 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
678 (note_mouse_highlight): Adjust users.
679 (try_cursor_movement): Likewise. Convert old precondition to eassert.
680 Add comment.
681
da5707e8
DA
6822013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
683
684 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
685 * image.c (imagemagick_filename_hint): Use `const char *' and
686 prefer SSDATA to SDATA to avoid warnings.
687
25554267
DA
6882013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
689
690 Cleanup window fringes, margins and scroll bars adjustments.
691 * window.c (set_window_fringes, set_window_margins)
692 (set_window_scroll_bars, apply_window_adjustment): New functions.
693 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
694 (Fset_window_scroll_bars): Use them.
695
38a2c910
DA
6962013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
697
698 * window.h (struct window): Convert scroll_bar_width
699 from Lisp_Object to integer. Adjust comment.
700 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
701 Adjust users.
702 * window.c (wset_scroll_bar_width): Remove.
703 (make_window): Initialize scroll_bar_width.
704 (Fsplit_window_internal): Use direct assignment.
705 (Fset_window_configuration, save_window_save):
706 Convert Lisp_Object to integer and back where appropriate.
707 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
708 bar was actually changed, and mention this in docstring.
709
2d065031
PE
7102013-08-13 Paul Eggert <eggert@cs.ucla.edu>
711
712 * decompress.c: Minor simplifications.
713 (Fzlib_decompress_region): Don't bother verifying
714 that avail_out <= UINT_MAX, as that was confusing.
715 Mention the restriction in a comment instead.
716 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
717
a5bd5abb
JD
7182013-08-13 Jan Djärv <jan.h.d@swipnet.se>
719
720 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
721 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
722
66e7901a
LMI
7232013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
724
725 * image.c (imagemagick_filename_hint): Check for errors in the
726 alist structure.
727
2fa611b7
EZ
7282013-08-13 Eli Zaretskii <eliz@gnu.org>
729
730 * window.c (Fwindow_margins): Return nil when there's no marginal
731 area, as per the documented API.
732
733 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
734 Fmake_vector, as scroll bar's struct members are not all Lisp
735 objects now. This avoids crashes in GC.
736
737 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
738 bool, so its address could be taken.
739
8259030d
LMI
7402013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
741
742 * image.c (imagemagick_filename_hint): New function to possibly
743 apply `image-content-type-suffixes'.
744 (imagemagick_load_image): Use it.
745
866c710e
EZ
7462013-08-13 Eli Zaretskii <eliz@gnu.org>
747
748 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
749 if loading zlib failed.
750
f10490f0
JD
7512013-08-13 Jan Djärv <jan.h.d@swipnet.se>
752
96311be7
JD
753 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
754 2013-08-13 checkin below. Change bool to BOOL, rule is:
755 All Obj-C code uses BOOL, except for interfaces callable from C.
756
f10490f0
JD
757 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
758
c8ae93b0
DA
7592013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
760
761 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
762 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
763 bool instead of BOOL.
764 * w32term.h (struct scroll_bar): Convert fringe_extended_p
765 from Lisp_Object to bitfield. Adjust comment.
766 * w32term.c (x_scroll_bar_create): Adjust user.
767 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
768 * xterm.c (XTset_vertical_scroll_bar): Likewise.
769 Use bool for boolean.
770 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
771 to `unsigned int' when defining a bitfield.
772
53b64418
PE
7732013-08-13 Paul Eggert <eggert@cs.ucla.edu>
774
775 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
776
eeaf9bf3
DA
7772013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
778
779 * window.h (struct window): Convert left_margin_cols and
780 right_margin_cols from Lisp_Objects to integers. Adjust comment.
781 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
782 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
783 Adjust users.
784 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
785 Adjust comment.
786 (showing_window_margins_p, update_window_line, update_frame_1):
787 * fringe.c (draw_fringe_bitmap_1):
788 * xdisp.c (window_box_width): Adjust users.
789 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
790 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
791 Use direct assignment.
792 (Fset_window_configuration, save_window_save, Fwindow_margins):
793 Convert Lisp_Object to integer and back where appropriate.
794 (Fset_window_margins): Adjust user. Return t if any margin
795 was actually changed, and mention this in docstring.
796
956720af
XF
7972013-08-13 Xue Fuqiao <xfq.free@gmail.com>
798
f73f4ce6 799 * syntax.c (forward_word):
956720af
XF
800 * cmds.c (forward_char, backward_char): Mention the optional argument.
801
9e37ee3b
DA
8022013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
803
804 * window.h (struct window): Convert left_fringe_width
805 and right_fringe_width from Lisp_Objects to integers.
806 Adjust comment.
807 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
808 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
809 * window.c (wset_left_fringe_width, wset_right_fringe_width):
810 Remove.
811 (make_window): Initialize new integer fields to -1.
812 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
813 (Fset_window_configuration, save_window_save):
814 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
815 (Fset_window_fringes): Adjust user. Return t if any fringe
816 was actually changed, and mention this in docstring.
817
e4375ca7
DA
8182013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
819
820 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
821 * nsfns.m (x_set_cursor_type):
822 * w32fns.c (x_set_cursor_type):
823 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
824 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 825
a45543bc
DA
8262013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
827
828 * font.c (clear_font_cache): New function, stripped from...
829 (Fclear_font_cache): ...here, which now uses the function
830 above. Adjust comment.
831 * font.h (clear_font_cache): Add prototype.
832 * xfaces.c (clear_face_cache): Use clear_font_cache.
833
ae966a86
DA
8342013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
835
836 * window.c (Fset_window_start): Compare `w', not `window' because
837 `w' might not be equal to `window' after call to decode_live_window.
838
297a545b
PE
8392013-08-12 Paul Eggert <eggert@cs.ucla.edu>
840
841 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
842 This fixes a problem introduced by the Bug#15035 patch
843 when using GPG. Reported by Herbert J. Skuhra.
844
aa942e2b
EZ
8452013-08-12 Eli Zaretskii <eliz@gnu.org>
846
847 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
848 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
849 not yet initialized.
850
7699d09e
LMI
8512013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
852
853 * decompress.c (Fzlib_decompress_region): Support zlib
854 decompression, too, and rename.
855
1d238bc7
PE
8562013-08-12 Paul Eggert <eggert@cs.ucla.edu>
857
858 Minor zlib configuration tweaks.
859 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
860 Don't assume presence of fn_inflateInit2_ zlib internal function.
861
8a44a184
LMI
8622013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
863
864 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
865 include the zlib prefix.
866
594a4307
EZ
8672013-08-12 Eli Zaretskii <eliz@gnu.org>
868
869 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
870 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
871 define static variables that are pointers to zlib functions to be
872 dynamically loaded.
873 (init_zlib_functions) [WINDOWSNT]: New function.
874 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
875 New macros.
876 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
877 macros instead of invoking the zlib functions directly.
068f9124
SM
878 (syms_of_decompress): DEFSYM Qzlib_dll.
879 Staticpro Szlib_available_p.
594a4307 880
d2e113bc
DA
8812013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
882
883 Avoid looping over all frame windows to freeze and unfreeze.
884 * window.h (struct window): Drop frozen_window_start_p.
885 (freeze_window_starts): Drop prototype.
886 * frame.h (struct frame): New frozen_window_starts flag.
887 (FRAME_WINDOWS_FROZEN): New macro.
888 * window.c (freeze_window_start, freeze_window_starts):
889 Remove.
890 (select_window, replace_window): Adjust users.
891 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
892 (window_frozen_p): New function.
893 (redisplay_window): Use it.
894
94fcd171
PE
8952013-08-12 Paul Eggert <eggert@cs.ucla.edu>
896
897 Fix some fd issues when running subprocesses (Bug#15035).
898 Fix bugs that can leak files or file descriptors on errors.
899 Don't unlink open temp files, as that's hard for users to diagnose
900 when things go awry (e.g., temp disk exhausted).
901 Don't bother to lock temp files. Check for invalid recursion.
902 * callproc.c (synch_process_fd): Remove. All uses removed.
903 (synch_process_tempfile): New var or macro.
904 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
905 New constants.
906 (record_kill_process): New arg, the temp name. All callers changed.
907 (delete_temp_file): Now just a simple wrapper around unlink.
908 (call_process_kill): New arg, the call_process_fd array.
909 Close them all. Clear synch_process_pid. Remove the temp file,
910 or arrange for it to be removed.
911 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
912 that's been moved to synch_process_tempfile. Caller changed.
913 Do not remove the tempfile; that's now call_process_kill's
914 responsibility.
915 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
916 call_process_kill; the caller now does that.
917 (call_process_cleanup): Do not close the process fd; that's now
918 call_process_kill's responsibility.
919 (Fcall_process): Implement via new function call_process, which
920 has most of the old body of Fcall_process, but with a different API.
921 (call_process): New function that does not open or close filefd if
922 it is nonnegative. Record which fds need to be closed, and let
923 call_process_kill close (and remove the tempfile, on MSDOS) on error.
924 Signal an error if invoked recursively (could be done via a hook).
925 Simplify creation of the tempfile in the MSDOS case.
926 Don't create the output file until after checking for the executable.
927 Report any failure to open /dev/null.
928 Don't open /dev/null for writing twice; once is enough.
929 Don't create pipe if all output is being discarded or sent to file.
930 Don't worry about setting up the coding system or reading from the
931 pipe if all output is being discarded.
932 Hoist fd_error local into top level, to lessen block nesting.
933 Don't record deleted pid here; now done by Fcall_process_region.
934 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
935 and note its success in synch_process_tempfile.
936 Do not leak resources when child_setup fails.
937 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
938 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
939 (create_temp_file): Now returns open fd, with an additional
940 Lisp_Object * argument to return the name. All callers changed.
941 Do not close the file; rewind it instead, and leave it open for
942 the caller. Do not lock the temp file. Unwind-protect the file
943 and the file-descriptor.
944 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
945 If an asynchrounous process, record it here, not in call_process.
946 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
947 * eval.c (set_unwind_protect): New function.
948 * fileio.c (write_region): New function, generalized from the
949 old Fwrite_region. Do not lock temp files.
950 (Fwrite_region): Use it.
951 * lisp.h (set_unwind_protect, write_region): New decls.
952 * process.c: Include <verify.h>.
953 (make_process): Mark fds as initially closed.
954 (deleted_pid_list): Now a list of pid-filename pairs.
955 All uses changed.
956 (close_process_fd): New function.
957 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
958 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
959 New constants. Verify that their number matches PROCESS_OPEN_FDS.
960 (create_process, create_pty, Fmake_serial_process)
961 (server_accept_connection): Record which fds need to be closed,
962 and let deactivate_process close them.
963 (Fmake_network_process): Do not discard the unwind-protect
964 until it's safe to do so.
965 (deactivate_process): Close the fds opened by create_process etc.
966 (Fprocess_send_eof): Adjust to new way of recording open fds.
967 Report an error if /dev/null can't be opened, instead of aborting.
968 * process.h (PROCESS_OPEN_FDS): New constant.
969 (struct Lisp_Process): New member open_fds.
970 (record_kill_process, record_deleted_pid): Adjust signatures.
971 (record_deleted_pid): Move decl here ...
972 * syswait.h (record_deleted_pid): ... from here.
973
d0e615c3
PE
9742013-08-11 Paul Eggert <eggert@cs.ucla.edu>
975
976 * decompress.c: Fix bugs with large buffers and weird inputs.
977 Tune a bit. Reindent as per usual Emacs style.
978 (BUFFER_SIZE): Remove.
979 (Fdecompress_gzipped_region): Do not mishandle input buffers with
980 more than UINT_MAX bytes. Decompress into the gap instead of into
981 an auto buffer, as this should avoid copying. Return nil if
982 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
983 set immediate_quit; we shouldn't trust zlib code that much.
984
313546eb
LMI
9852013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
986
99a32242
LMI
987 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
988 errors, and really move the gap to where we want it.
989
313546eb
LMI
990 * lisp.h: Include decompress.c support.
991
992 * emacs.c (main): Include decompress.c support.
993
994 * Makefile.in: Include -lz if present.
995
d2d699ac
JD
9962013-08-11 Jan Djärv <jan.h.d@swipnet.se>
997
f90e3ebd
JD
998 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
999 (initWithTitle:): Initialize frame to 0.
1000 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1001 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1002 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1003
1004 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1005 fillWithWidgetValue:frame:
1006
423d3b3f
JD
1007 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1008 remove memory leak warnings.
1009
d2d699ac
JD
1010 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1011 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1012 menu_pending_title.
1013
1014 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1015 (x_activate_menubar): Update the whole menu.
1016 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1017 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1018 current event is not NSSystemDefined (Bug#15001).
1019 Call ns_check_menu_open only if trackingMenu is 2.
1020 (menuDidClose:): New method, decrease trackingMenu.
1021 (fillWithWidgetValue:setDelegate:): New method.
1022 (fillWithWidgetValue:): Call the above.
1023
1024 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1025
7d652d97
PE
10262013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 Omit some unnecessary casts.
1029 Many of these go back to the old pre-C89 days, when they may have
1030 been needed, but we've been assuming C89 or later for a while now.
1031 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1032 (live_float_p, live_misc_p, live_vector_p):
1033 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1034 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1035 (defvar_per_buffer):
1036 * callint.c (Fcall_interactively):
1037 * doc.c (Fsubstitute_command_keys):
1038 * filelock.c (get_boot_time):
1039 * frame.c (xrdb_get_resource):
1040 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1041 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1042 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1043 (menuitem_highlight_callback, menu_destroy_callback)
1044 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1045 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1046 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1047 (xg_tool_bar_help_callback, tb_size_cb):
1048 * image.c (xpm_alloc_color, png_read_from_memory)
1049 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1050 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1051 (syms_of_image):
1052 * keymap.c (describe_map):
1053 * nsfns.m (Fns_display_monitor_attributes_list):
1054 * nsmenu.m (process_dialog:):
1055 * nsterm.m (hold_event):
1056 * process.c (wait_reading_process_output):
1057 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1058 * scroll.c (do_direct_scrolling, scrolling_1):
1059 * termcap.c (tgetent):
1060 * window.c (check_window_containing, add_window_to_list)
1061 (freeze_window_starts):
1062 * xdisp.c (compare_overlay_entries, vmessage):
1063 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1064 (x_get_monitor_attributes_xrandr)
1065 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1066 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1067 * xfont.c (xfont_match, xfont_open):
1068 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1069 (menubar_selection_callback, menu_position_func)
1070 (popup_selection_callback, create_and_show_popup_menu)
1071 (dialog_selection_callback, create_and_show_dialog):
1072 * xrdb.c (x_get_string_resource):
1073 (main) [TESTRM]:
1074 * xsmfns.c (x_session_check_input):
1075 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1076 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1077 (xaw_jump_callback, xaw_scroll_callback):
1078 Omit unnecessary casts.
1079
9acc1074
PE
10802013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 Minor string-length refactoring.
1083 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1084 * frame.c (make_monitor_attribute_list):
1085 Prefer build_string to strlen + make_string.
1086
361c0eb8
JD
10872013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1088
1089 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1090 don't check minor_code (Bug#14417).
1091
14ba0822
EZ
10922013-08-09 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1095 vertical positions instead. This avoids calling MATRIX_ROW with
1096 row numbers that are possibly beyond valid limits. (Bug#15064)
1097
309f24d1
DA
10982013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1099
1100 Use xstrdup and build_unibyte_string where applicable.
1101 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1102 * xfns.c (x_window):
1103 * xrdb.c (x_get_customization_string):
1104 * xterm.c (xim_initialize):
1105 * w32fns.c (w32_window): Use xstrdup.
1106 (w32_display_monitor_attributes_list):
1107 * emacs.c (init_cmdargs):
1108 * keyboard.c (PUSH_C_STR):
1109 * nsfont.m (nsfont_open):
1110 * sysdep.c (system_process_attributes):
1111 * w32.c (system_process_attributes):
1112 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1113
55902276
EZ
11142013-08-09 Eli Zaretskii <eliz@gnu.org>
1115
1116 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1117 variables of these types so that GDB would know about them, as aid
1118 for debugging fatal exceptions. (Bug#15024) See also
1119 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1120 discussions.
1121
10bf7f5a
JD
11222013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1123
1124 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1125 larger than the NSWindow (Bug#14934).
1126
65620264
DA
11272013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1128
1129 Redesign redisplay interface to drop global variable updated_window.
1130 Always pass currently updated window as a parameter to update routines.
1131 * dispextern.h (updated_window): Remove declaration.
1132 (struct redisplay_interface): Pass window parameter to
1133 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1134 and after_update_window_hook.
1135 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1136 Adjust prototypes.
1137 * dispnew.c (updated_window): Remove.
1138 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1139 (update_window_line): Adjust to match redisplay interface changes.
1140 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1141 (ns_scroll_run, ns_after_update_window_line):
1142 * w32term.c (x_update_window_begin, x_update_window_end)
1143 (x_after_update_window_line, x_scroll_run):
1144 * xterm.c (x_update_window_begin, x_update_window_end)
1145 (x_after_update_window_line, x_scroll_run):
1146 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1147 Likewise. Adjust comments where appropriate.
1148 (x_cursor_to): Simplify because this is always called during window
1149 update (but install debugging check anyway).
1150 (expose_window): Check must_be_updated_p flag to see whether this
1151 function is called during window update.
1152
628fdc56
DA
11532013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 Do not reset window modification event counters excessively.
1156 These leftovers and poor man's tricky methods to catch extra
1157 redisplay's attention are no longer needed.
1158 * frame.c (set_menu_bar_lines_1):
1159 * minibuf.c (read_minibuf_unwind):
1160 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1161 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1162 (window_scroll_line_based, Fset_window_configuration):
1163 * xdisp.c (redisplay_window): Do not reset last_modified and
1164 last_overlay_modified counters.
1165
8fd9c92e
JD
11662013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1167
1168 * xselect.c (x_send_client_event): Set send_event and serial, memset
1169 data.l as it might be bigger than data.b. Use 24 bit mask to
1170 XSendEvent (Bug#15034).
1171
0ee18172
EZ
11722013-08-07 Eli Zaretskii <eliz@gnu.org>
1173
1174 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1175 for TTY frames that are not the top frame on their console.
1176 (Bug#14616)
1177
16ddd1a6
MR
11782013-08-07 Martin Rudalics <rudalics@gmx.at>
1179
1180 * w32term.c (w32fullscreen_hook): Really maximize frame when
1181 asked for (Bug#14841).
1182
d2a95ffb
DA
11832013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1184
1185 Prefer selected_window to Fselected_window, likewise for frames.
1186 * buffer.c (Fbuffer_swap_text):
1187 * data.c (Fvariable_binding_locus):
1188 * window.c (run_window_configuration_change_hook): Adjust users.
1189 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1190 Use decode_live_frame.
1191
170da1ec
DA
11922013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1193
1194 Be more careful if selected window shows the buffer other than current,
1195 use window_outdated only if this is not so. This change should also
1196 address some weird issues discussed in Bug#13012.
1197 * window.h (window_outdated): New prototype.
1198 * window.c (window_outdated): Now here. Convert from static and
1199 always assume window's buffer.
1200 (Fwindow_end, Fwindow_line_height): Use it.
1201 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1202 and always assume window's buffer.
1203 (redisplay_window): Adjust user.
e5eefe9b 1204 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1205 check whether mode line should be updated only if selected window
1206 shows current buffer.
1207 (run_window_scroll_functions): Use eassert for debugging check.
1208 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1209
56b5d5b1
DA
12102013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1211
1212 * window.c (window_scroll, window_scroll_pixel_based)
1213 (window_scroll_line_based): Use bool for booleans.
1214
2878ba7e
PE
12152013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1216
1217 * process.c: Fix minor off-by-one issues in descriptor counts.
1218 This shouldn't fix any real bugs, but it cleans up the code a bit.
1219 (max_process_desc, max_input_desc): -1, not 0, means none.
1220 All uses changed.
1221 (delete_input_desc): New function.
1222 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1223 (deactivate_process): Scan backwards when recomuting max_process_desc;
1224 that should be faster.
1225 (init_process_emacs): Initialize max_input_desc.
1226
e30b79c1
DA
12272013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1228
1229 Use region cache to speedup bidi_find_paragraph_start.
1230 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1231 Rename cache_long_line_scans to cache_long_scans.
1232 * buffer.c (bset_cache_long_line_scans): Rename to
1233 bset_cache_long_scans.
1234 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1235 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1236 into account.
1237 (syms_of_buffer): Rename cache-long-line-scans to
1238 cache-long-scans. Adjust docstring.
1239 * search.c (newline_cache_on_off):
1240 * indent.c (width_run_cache_on_off): Adjust users.
1241 * bidi.c (bidi_paragraph_cache_on_off): New function.
1242 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1243 * insdel.c (prepare_to_modify_buffer):
1244 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1245
00012b86
DA
12462013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1247
1248 Invalidate region caches only if buffer text is going to be changed.
1249 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1250 (modify_text): ...new prototype.
1251 (prepare_to_modify_buffer_1): New prototype.
1252 * textprop.c (modify_region): Rename to...
1253 (modify_text_properties): ...new function.
1254 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1255 (Fremove_list_of_text_properties): Adjust users.
1256 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1257 (modify_text): ...new function.
1258 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1259 (prepare_to_modify_buffer_1): ...new function.
1260 * casefiddle.c (casify_region):
1261 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1262 (Ftranspose_regions): Use modify_text.
1263
dc6c0eda
SM
12642013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1265
1266 * lisp.mk (lisp): Add nadvice.elc.
1267
8f3a2c26
DA
12682013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 New macro to iterate over live buffers similar to frames.
1271 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1272 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1273 Declare buffer-related variables here to offload lisp.h.
1274 * buffer.c (Vbuffer_alist): Adjust comment.
1275 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1276 (other_buffer_safely):
1277 * data.c (store_symval_forwarding):
1278 * dispnew.c (Fframe_or_buffer_changed_p):
1279 * fileio.c (Fdo_auto_save):
1280 * filelock.c (unlock_all_files):
1281 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1282
e0fdb694
PE
12832013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1284
1285 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1286 * callproc.c (create_temp_file):
1287 * filelock.c (create_lock_file):
1288 Assume mkostemp, since it's now provided by Gnulib.
1289
63f5c6c2
EZ
12902013-08-04 Eli Zaretskii <eliz@gnu.org>
1291
1292 * w32.c (mkostemp): New function.
1293 (mktemp): Remove, no longer used. Most of the code reused in
1294 mkostemp. (Bug#15015)
484ab239 1295 (mktemp): Don't undef.
63f5c6c2 1296
f0b79313
DA
12972013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1300 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1301 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1302 (free_glyph_pool, check_glyph_memory): Likewise for
1303 all users. Adjust comments where appropriate.
1304
98f638d6
PE
13052013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1306
1307 * composite.h: Minor fixups.
1308 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1309 to fix a misspelling, and change it to an inline function while
1310 we're at it (it need not be a macro). All uses changed.
1311 (composition_method, composition_valid_p):
1312 Rewrite to avoid assignments in if-conditions.
1313
75c59fb3
DA
13142013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1315
1316 Do not use global Lisp_Object in composition macros.
1317 * composite.h (composition_temp): Remove declaration.
1318 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1319 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1320 (compose_region): Remove the leftover.
75c59fb3
DA
1321 * composite.c (composition_temp): Remove.
1322 (run_composition_function, update_compositions)
1323 (composition_compute_stop_pos, composition_adjust_point)
1324 (Ffind_composition_internal):
1325 * coding.c (handle_composition_annotation):
1326 * xdisp.c (handle_composition_prop, check_point_in_composition):
1327 Related users changed.
1328
a10c8269
DA
13292013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1330
1331 Drop FRAME_PTR typedef.
1332 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1333 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1334 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1335 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1336 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1337 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1338 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1339 All related users changed.
1340
a104f656
SM
13412013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1342
1343 * eval.c (default_toplevel_binding): New function.
1344 (Fdefvar): Use it.
1345 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1346 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1347 (syms_of_eval): Export them.
1348 * data.c (Fdefault_value): Micro cleanup.
1349 * term.c (init_tty): Use "false".
1350
4b5c9326
DA
13512013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1352
1353 Fix X GC leak in GTK and raw (no toolkit) X ports.
1354 * xterm.c (x_free_frame_resources): If white and black relief
1355 GCs are allocated, always free them here.
1356 * xfns.c (x_make_gc): Omit redundant initialization.
1357 * widget.c (create_frame_gcs): Remove the leftover.
1358 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1359 in x_free_frame_resources.
1360
b19aa636
JD
13612013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1362
1363 * nsterm.m (windowWillResize:toSize:): Only change title if
1364 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1365 modifying it.
1366 (viewDidEndLiveResize): New method.
1367
1368 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1369 inside NS_IMPL_COCOA.
1370
af1f7e06
DA
13712013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1372
1373 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1374 Do not check whether undo is enabled because record_insert and
1375 record_delete does that themselves.
1376
65b02bb9
DA
13772013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1378
1379 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1380 member which is not really used any more.
1381 (FRAME_XIC_BASE_FONTNAME): Remove.
1382 * xfns.c (xic_free_fontset): Adjust user.
1383 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1384 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1385 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1386 (xdialog_show): Use eassert for debugging check.
7ee0f047 1387 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1388
6318cde0
PE
13892013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1390
1391 * fileio.c, fns.c (merge): Move extern decl from here ...
1392 * lisp.h (merge): ... to here.
1393
6c1a09ba
DA
13942013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1395
1396 Fix last font-related change.
1397 * w32font.h (w32font_list_internal, w32font_match_internal):
1398 Fix prototype.
1399 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1400 (uniscribe_list_family): Adjust to match font API change.
1401 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1402 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1403
f8c20208
DA
14042013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1405
1406 * frame.h (FRAME_MOUSE_UPDATE):
1407 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1408 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1409
fdb396e2
DA
14102013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1411
1412 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1413 * font.h (struct font_driver): Change list, match, and list_family
1414 functions to accept struct frame * as first arg.
068f9124
SM
1415 * font.c (font_score, font_compare, font_sort_entities):
1416 Remove prototypes.
fdb396e2
DA
1417 (font_sort_entities, font_list_entities, font_select_entity):
1418 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1419 match font API change.
1420 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1421 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1422 * ftxfont.c (ftxfont_list, ftxfont_match):
1423 * xftfont.c (xftfont_list, xftfont_match):
1424 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1425 * w32font.c (w32font_list, w32font_match, w32font_list):
1426 (w32font_list_internal, w32_font_match_internal): Likewise.
1427 * xfaces.c (Fx_family_fonts): Adjust user.
1428
52b8a085
DA
14292013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1430
1431 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1432 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1433 only if HAVE_X_WINDOWS is in use.
1434 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1435 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1436 * w32term.c (x_wm_set_icon_position): Likewise.
1437 * w32fns.c (x_icon): Adjust user.
1438
c791c18e
DA
14392013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1440
1441 * xterm.c (last_mouse_press_frame): Remove the
1442 leftover which is not really used any more.
1443 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1444 (x_flush): Call XFlush once per each X display, not frame.
1445 This is better because this code always unconditionally skips
1446 non-X frames in Vframe_list and issues the only XFlush if we
1447 have more than one X frame on the same X display.
2f935d86
DA
1448 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1449 Use bool for booleans.
1450 (x_draw_glyph_string_background, cvt_string_to_pixel):
1451 (cvt_pixel_dtor): Drop unnecessary prototypes.
1452 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1453
f435830e
DA
14542013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1455
1456 Drop unnecessary functions that deals with frame pixel size.
1457 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1458 (x_pixel_height): Drop prototypes.
1459 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1460 (x_pixel_height): Drop implementations.
1461 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1462 which should be always valid for window frame.
1463 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1464 * w32menu.c (Fx_popup_dialog):
1465 * xmenu.c (Fx_popup_dialog): Likewise for both.
1466
84231434
DA
14672013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1468
1469 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1470 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1471 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1472 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1473 and mention nil frame in docstring.
84231434 1474
959067a1
DA
14752013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1478 (x_figure_window_size): Likewise. Adjust to return long.
1479 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1480 (toplevel): Move Qterminal_live_p to...
1481 * terminal.c (toplevel): ...here, make it static, and...
1482 (syms_of_terminal): ...DEFSYM here.
1483 * frame.h (Qterminal_live_p): Remove declaration.
1484 (make_frame, x_figure_window_size): Adjust prototype.
1485 * nsfns.m (Fx_create_frame): Use long for window flags.
1486
f4b169ce
PE
14872013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1488
1489 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1490 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1491 Do not assume that emacs_close (INT_MAX) is a no-op.
1492
bee6a2c7
DA
14932013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1494
1495 * xfaces.c (make_face_cache): For struct face_cache, prefer
1496 xmalloc to xzalloc and so avoid redundant call to memset.
1497 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1498
d7e6881a
DA
14992013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1500
1501 * fringe.c (draw_window_fringes, update_window_fringes)
1502 (compute_fringe_widths):
1503 * w32term.c (x_draw_glyph_string):
1504 * window.c (candidate_window_p, Frecenter):
1505 * xfaces.c (realize_basic_faces, realize_default_face)
1506 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1507 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1508 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1509 * xmenu.c (Fx_menu_bar_open_internal):
1510 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1511 * xsettings.c (xft_settings_event):
1512 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1513 Use bool for booleans. Adjust style and comments where
1514 appropriate.
1515 * dispextern.h (draw_window_fringes, update_window_fringes)
1516 (compute_fringe_widths):
1517 * xterm.h (x_had_errors_p): Adjust prototype.
1518
ec3058af
DA
15192013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1520
1521 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1522 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1523
218e0637
DA
15242013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1525
1526 * fns.c (toplevel): Remove comment before Fsafe_length because
1527 it checks for QUIT.
1528
e560aba9
PE
15292013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1532
2e5ce5de
EZ
15332013-07-28 Eli Zaretskii <eliz@gnu.org>
1534
1535 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1536 frame which got the message is still alive, before dereferencing
1537 its pointer. (Bug#14970)
1538
1539 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1540 be a live window, before using it as such. (Bug#14970)
1541
e95da6d3
EZ
15422013-07-27 Eli Zaretskii <eliz@gnu.org>
1543
1544 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1545 w32_detect_focus_change instead of doing part of its job by hand.
1546 This fixes the problem whereby FOCUS_OUT events were not sent to
1547 the event queue.
1548
a8f93651
EZ
15492013-07-26 Eli Zaretskii <eliz@gnu.org>
1550
fec92060
EZ
1551 * process.c (Fprocess_list): Doc fix.
1552
a8f93651
EZ
1553 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1554 being re-exposed only if it didn't ask to become visible.
1555 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1556 was previously iconified. (Bug#14841)
1557 (x_iconify_frame): Mark the frame iconified.
1558
d5a7a9d9
PE
15592013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 Fix minor problems found by static checking.
1562 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1563 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1564
56ea7291
SM
15652013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1566
1567 * eval.c (set_specpdl_old_value): New function.
1568 (unbind_to): Minor simplification.
1569 (get_backtrace_frame): New function.
1570 (Fbacktrace_frame): Use it. Add `base' argument.
1571 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1572 (syms_of_eval): Export backtrace-eval.
1573 * xterm.c (x_focus_changed): Simplify.
1574
9d611ffe
PE
15752013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1578
999c74e3
EZ
15792013-07-24 Eli Zaretskii <eliz@gnu.org>
1580
1581 * xdisp.c (redisplay_window): Instead of moving point out of
1582 scroll margin, reject the force_start method, and try scrolling
1583 instead. (Bug#14780)
1584
198fa217
KB
15852013-07-24 Ken Brown <kbrown@cornell.edu>
1586
1587 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1588 (Bug#14944).
1589
53840e55
PE
15902013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1591
1592 * eval.c (Fprogn): Do not check that BODY is a proper list.
1593 This undoes the previous change. The check slows down the
1594 interpreter, and is not needed to prevent a crash. See
1595 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1596
60967f56
GM
15972013-07-23 Glenn Morris <rgm@gnu.org>
1598
1599 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1600
9ca960e2
PE
16012013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1602
a29c3e6d
PE
1603 Port to GNU/Linux systems with tinfo but not ncurses.
1604 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1605 to decide whether ncurses is being used. Without this change,
1606 GCC complains about tgetent not being declared, on a system
1607 that has tinfo installed but ncurses not installed.
1608
f274311c
PE
1609 * eval.c (Fprogn): Check that BODY is a proper list.
1610
16b0520a
PE
1611 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1612 * data.c (Fsetq_default):
1613 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1614 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1615 (Fcondition_case):
1616 Tune by taking advantage of the fact that ARGS is always a list
1617 when a function is declared to have UNEVALLED args.
1618
9ca960e2
PE
1619 * emacsgtkfixed.c: Port to GCC 4.6.
1620 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1621
afacaa1b
JB
16222013-07-23 Juanma Barranquero <lekktu@gmail.com>
1623
1624 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1625 here to silence compiler warnings.
1626
368a85a4
PE
16272013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1628
1629 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1630 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1631 from messing up Emacs's 'struct frame' (Bug#14923).
1632
f4e891b5
PE
16332013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1634
1635 * alloc.c (make_save_ptr_ptr): Define this function.
1636 It was inadvertently omitted. It's needed only if
1637 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1638
96c8b65e
JD
16392013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1640
1641 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1642 frame have focus (Bug#14895).
1643
ee010797
PE
16442013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 Avoid vfork-related deadlock more cleanly.
1647 * callproc.c (child_setup): When the child's exec fails, output
1648 the program name, as that's more useful. Use O_NONBLOCK to avoid
1649 deadlock.
1650 * process.c (create_process_1): Remove; no longer needed.
1651 (create_process): Remove timer hack; no longer needed, now that
1652 the child avoids deadlock.
1653
f0398ec1 16542013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1655
1656 * image.c (Fimage_flush): Fix doc typo.
1657
b2a069c2
PE
16582013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1659
6496aec9
PE
1660 Fix array bounds violation when pty allocation fails.
1661 * process.c (PTY_NAME_SIZE): New constant.
1662 (pty_name): Remove static variable; it's now auto.
1663 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1664 Take pty_name as an arg rather than using a static variable.
1665 All callers changed.
1666 (create_process): Recover pty_flag from process, not from volatile local.
1667 (create_pty): Stay inside array even when pty allocation fails.
1668 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1669
b2a069c2
PE
1670 * lread.c (Fload): Avoid initialization only when lint checking.
1671 Mention that it's needed only for older GCCs.
1672
99107004
KH
16732013-07-20 Kenichi Handa <handa@gnu.org>
1674
1675 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1676 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1677
6b1b199d
AS
16782013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1679
1680 * lread.c (Fload): Avoid uninitialized warning.
1681
4195afc3
PE
16822013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1683
3f5bef16
PE
1684 Fix some minor file descriptor leaks and related glitches.
1685 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1686 (create_lock_file): Use write, not emacs_write.
1687 * image.c (slurp_file, png_load_body):
1688 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1689 (server_accept_connection):
1690 Don't leak an fd on memory allocation failure.
1691 * image.c (slurp_file): Add a cheap heuristic for growing files.
1692 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1693 as that's what the other routines do. Maybe input need not be
1694 blocked at all, but it's better to be consistent.
1695 Avoid undefined behavior when strlen is zero.
1696
4195afc3
PE
1697 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1698 (NSTATICS): Now a constant; doesn't need to be a macro.
1699
a1aeeffe
RS
17002013-07-19 Richard Stallman <rms@gnu.org>
1701
1702 * coding.c (decode_coding_utf_8): Add simple loop for fast
1703 processing of ASCII characters.
1704
63b34baa
PE
17052013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1708
621dd9ac
EZ
17092013-07-19 Eli Zaretskii <eliz@gnu.org>
1710
1711 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1712 unportable 'struct x_display_info'.
1713 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1714 is a portable type.
1715
1396ac86
PE
17162013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1717
ab9980cd
PE
1718 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1719 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1720 or fscanf fails.
1721 (system_process_attributes): Prefer plain char to unsigned char
1722 when either will do. Clean up properly if interrupted or if
068f9124
SM
1723 memory allocations fail. Don't assume sscanf succeeds.
1724 Remove no-longer-needed workaround to stop GCC from whining.
1725 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1726 bit more carefully.
1727
1396ac86
PE
1728 Fix obscure porting bug with varargs functions.
1729 The code assumed that int is treated like ptrdiff_t in a vararg
1730 function, which is not a portable assumption. There was a similar
1731 -- though these days less likely -- porting problem with various
1732 assumptions that pointers of different types all smell the same as
1733 far as vararg functions is conserved. To make this problem less
1734 likely in the future, redo the API to use varargs functions.
1735 * alloc.c (make_save_value): Remove this vararg function.
1736 All uses changed to ...
1737 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1738 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1739 New functions.
1740 (make_save_ptr): Rename from make_save_pointer, for consistency with
1741 the above. Define only on platforms that need it. All uses changed.
1742
4d19d194
PE
17432013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * keyboard.c: Try to fix typos in previous change.
1746 (DISPLAY_LIST_INFO): New macro.
1747 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1748 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1749
945c5bb1
JB
17502013-07-18 Juanma Barranquero <lekktu@gmail.com>
1751
1752 * keyboard.c (kbd_buffer_get_event):
1753 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1754 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1755
f4b1eb36
PE
17562013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1757
5e679a2c
PE
1758 * filelock.c: Fix unlikely file descriptor leaks.
1759 (get_boot_time_1): Rework to avoid using emacs_open.
1760 This doesn't actually fix a leak, but is better anyway.
1761 (read_lock_data): Use read, not emacs_read.
1762
a8cd4836
PE
1763 * doc.c: Fix minor memory and file descriptor leaks.
1764 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1765 (get_doc_string, Fsnarf_documentation):
1766 Fix file descriptor leak on error.
1767
ef30e638
PE
1768 * term.c: Fix minor fdopen-related file descriptor leaks.
1769 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1770 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1771
f4b1eb36
PE
1772 * charset.c: Fix file descriptor leaks and errno issues.
1773 Include <errno.h>.
1774 (load_charset_map_from_file): Don't leak file descriptor on error.
1775 Use plain record_xmalloc since the allocation is larger than
1776 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1777 of entries.
1778 * eval.c (record_unwind_protect_nothing):
1779 * fileio.c (fclose_unwind):
1780 New functions.
1781 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1782 The replacement doesn't block input, but that no longer seems
1783 necessary.
1784
b648c163
PE
17852013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1786
a0931322
PE
1787 * lread.c: Fix file descriptor leaks and errno issues.
1788 (Fload): Close some races that leaked fds or streams when 'load'
1789 was interrupted.
1790 (Fload, openp): Report error number of last nontrivial failure to open.
1791 ENOENT counts as trivial.
1792 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1793 New functions.
1794 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1795 now that the function is always called with a nonnegative arg.
1796 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1797 All uses replaced with ...
1798 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1799
b648c163
PE
1800 A few more minor file errno-reporting bugs.
1801 * callproc.c (Fcall_process):
1802 * doc.c (Fsnarf_documentation):
1803 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1804 * process.c (set_socket_option):
1805 Don't let a constructor trash errno.
1806 * doc.c: Include <errno.h>.
1807
b1dc4084
JB
18082013-07-16 Juanma Barranquero <lekktu@gmail.com>
1809
1810 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1811
c43843aa
PE
18122013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1813
50a30cce
PE
1814 Fix w32 bug with call-process-region (Bug#14885).
1815 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1816 to Fcall_process when the input is empty. This simplifies the
1817 code a bit. It makes no difference on POSIXish platforms but
1818 apparently it fixes a bug on w32.
1819
44e18199 1820 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1821 * fileio.c (close_file_unwind): Don't close if FD is negative;
1822 this can happen when unwinding a zapped file descriptor.
1823 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1824 in case Emacs runs out of memory between the two unwind-protects.
1825 Don't trash errno when closing FD.
1826 Zap the FD in the specpdl when closing it, instead of deferring
1827 the removal of the unwind-protect; this fixes a bug where a child
1828 function unwinds the stack past us.
1829
27e498e6
PE
1830 New unwind-protect flavors to better type-check C callbacks.
1831 This also lessens the need to write wrappers for callbacks,
1832 and the need for make_save_pointer.
1833 * alloca.c (free_save_value):
1834 * atimer.c (run_all_atimers):
1835 Now extern.
1836 * alloc.c (safe_alloca_unwind):
1837 * atimer.c (unwind_stop_other_atimers):
1838 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1839 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1840 * minibuf.c (choose_minibuf_frame_1):
1841 * process.c (make_serial_process_unwind):
1842 * xdisp.h (pop_message_unwind):
1843 * xselect.c (queue_selection_requests_unwind):
1844 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1845 * alloca.c (record_xmalloc):
1846 Prefer record_unwind_protect_ptr to record_unwind_protect with
1847 make_save_pointer.
1848 * alloca.c (Fgarbage_collect):
1849 Prefer record_unwind_protect_void to passing a dummy.
1850 * buffer.c (restore_buffer):
1851 * window.c (restore_window_configuration):
1852 * xfns.c, w32fns.c (do_unwind_create_frame)
1853 New wrapper. All record-unwind uses of wrappee changed.
1854 * buffer.c (set_buffer_if_live):
1855 * callproc.c (call_process_cleanup, delete_temp_file):
1856 * coding.c (code_conversion_restore):
1857 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1858 * editfns.c (save_excursion_restore)
1859 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1860 (save_restriction_restore):
1861 * eval.c (restore_stack_limits, un_autoload):
1862 * fns.c (require_unwind):
1863 * keyboard.c (recursive_edit_unwind, tracking_off):
1864 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1865 * macros.c (pop_kbd_macro, restore_menu_items):
1866 * nsfns.m (unwind_create_frame):
1867 * print.c (print_unwind):
1868 * process.c (start_process_unwind):
1869 * search.c (unwind_set_match_data):
1870 * window.c (select_window_norecord, select_frame_norecord):
1871 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1872 (fast_set_selected_frame):
1873 * xfns.c, w32fns.c (unwind_create_tip_frame):
1874 Return void, not a dummy Lisp_Object. All uses changed.
1875 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1876 * callproc.c (call_process_kill):
1877 * fileio.c (restore_point_unwind, decide_coding_unwind)
1878 (build_annotations_unwind):
1879 * insdel.c (Fcombine_after_change_execute_1):
1880 * keyboard.c (read_char_help_form_unwind):
1881 * menu.c (unuse_menu_items):
1882 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1883 * sound.c (sound_cleanup):
1884 * xdisp.c (unwind_redisplay):
1885 * xfns.c (clean_up_dialog):
1886 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1887 Accept no args and return void, instead of accepting and returning
1888 a dummy Lisp_Object. All uses changed.
1889 * cygw32.c (fchdir_unwind):
1890 * fileio.c (close_file_unwind):
1891 * keyboard.c (restore_kboard_configuration):
1892 * lread.c (readevalllop_1):
1893 * process.c (wait_reading_process_output_unwind):
1894 Accept int and return void, rather than accepting an Emacs integer
1895 and returning a dummy object. In some cases this fixes an
1896 unlikely bug when the corresponding int is outside Emacs integer
1897 range. All uses changed.
1898 * dired.c (directory_files_internal_unwind):
1899 * fileio.c (do_auto_save_unwind):
1900 * gtkutil.c (pop_down_dialog):
1901 * insdel.c (reset_var_on_error):
1902 * lread.c (load_unwind):
1903 * xfns.c (clean_up_file_dialog):
1904 * xmenu.c, nsmenu.m (pop_down_menu):
1905 * xmenu.c (cleanup_widget_value_tree):
1906 * xselect.c (wait_for_property_change_unwind):
1907 Accept pointer and return void, rather than accepting an Emacs
1908 save value encapsulating the pointer and returning a dummy object.
1909 All uses changed.
1910 * editfns.c (Fformat): Update the saved pointer directly via
1911 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1912 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1913 (unwind_body): New function.
1914 (record_unwind_protect): First arg is now a function returning void,
1915 not a dummy Lisp_Object.
1916 (record_unwind_protect_ptr, record_unwind_protect_int)
1917 (record_unwind_protect_void): New functions.
1918 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1919 * fileio.c (struct auto_save_unwind): New type.
1920 (do_auto_save_unwind): Use it.
1921 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1922 * insdel.c (struct rvoe_arg): New type.
1923 (reset_var_on_error): Use it.
1924 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1925 New constants.
1926 (specbinding_func): Remove; there are now several such functions.
1927 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1928 (set_unwind_protect_ptr): New function.
1929 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1930
4e604a5d
PE
1931 Be simpler and more consistent about reporting I/O errors.
1932 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1933 Say "Read error" and "Write error", rather than "I/O error", or
1934 "IO error reading", or "IO error writing", when a read or write
1935 error occurs.
1936 * process.c (Fmake_network_process, wait_reading_process_output)
1937 (send_process, Fprocess_send_eof, wait_reading_process_output):
1938 Capitalize diagnostics consistently. Put "failed foo" at the
1939 start of the diagnostic, so that we don't capitalize the
1940 function name "foo". Consistently say "failed" for such
1941 diagnostics.
1942 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1943 All callers changed. This is so it can use report_file_error.
1944 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1945 diagnostics consistently as above.
1946
a9757f6a
PE
1947 * fileio.c (report_file_errno): Fix errno reporting bug.
1948 If the file name is neither null nor a pair, package it up as a
1949 singleton list. All callers changed, both to this function and to
1950 report_file_error. This fixes a bug where the memory allocator
1951 invoked by list1 set errno so that the immediately following
1952 report_file_error reported the wrong errno value.
1953
c43843aa
PE
1954 Fix minor problems found by --enable-gcc-warnings.
1955 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1956 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1957
18c26d81
JD
19582013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1959
1960 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1961 Set event->arg to Qt if switch-event shall be generated.
1962 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1963
1964 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1965
1966 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1967 FOCUS_OUT_EVENT.
1968
1969 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1970 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1971 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1972 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1973 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1974 and there is a focused frame.
1975 (head_table): Add focus-in and focus-out.
1976 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1977 bind to handle-focus-in/out.
1978
1979 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1980 (Fhandle_switch_frame): Call Fhandle_focus_in.
1981 (syms_of_frame): defsubr handle-focus-in/out.
1982
6c6f1994
PE
19832013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1984
c7ddc792
PE
1985 Fix porting bug to older POSIXish platforms (Bug#14862).
1986 * sysdep.c (emacs_pipe): New function, that implements
1987 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1988 This should port better to CentOS 5 and to Mac OS X 10.6.
1989 All calls to pipe2 changed.
1990
6c6f1994
PE
1991 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1992 This makes the code easier to read and the executable a bit smaller.
1993 Do not replace all calls to Fcons that happen to create lists,
1994 just calls that are intended to create lists. For example, when
1995 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1996 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1997 Similarly for list2 through list5.
1998 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1999 * bytecode.c (exec_byte_code):
2000 * callint.c (quotify_arg, Fcall_interactively):
2001 * callproc.c (Fcall_process, create_temp_file):
2002 * charset.c (load_charset_map_from_file)
2003 (Fdefine_charset_internal, init_charset):
2004 * coding.c (get_translation_table, detect_coding_system)
2005 (Fcheck_coding_systems_region)
2006 (Fset_terminal_coding_system_internal)
2007 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2008 * composite.c (update_compositions, Ffind_composition_internal):
2009 * dired.c (directory_files_internal, file_name_completion)
2010 (Fsystem_users):
2011 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2012 * doc.c (Fsnarf_documentation):
2013 * editfns.c (Fmessage_box):
2014 * emacs.c (main):
2015 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2016 (Feval, eval_sub, Ffuncall, apply_lambda):
2017 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2018 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2019 (Fset_file_times, Finsert_file_contents)
2020 (Fchoose_write_coding_system, Fwrite_region):
2021 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2022 * font.c (font_registry_charsets, font_parse_fcname)
2023 (font_prepare_cache, font_update_drivers, Flist_fonts):
2024 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2025 * frame.c (make_frame, Fmake_terminal_frame)
2026 (x_set_frame_parameters, x_report_frame_params)
2027 (x_default_parameter, Fx_parse_geometry):
2028 * ftfont.c (syms_of_ftfont):
2029 * image.c (gif_load):
2030 * keyboard.c (command_loop_1):
2031 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2032 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2033 (Fminor_mode_key_binding, accessible_keymaps_1)
2034 (Faccessible_keymaps, Fwhere_is_internal):
2035 * lread.c (read_emacs_mule_char):
2036 * menu.c (find_and_return_menu_selection):
2037 * minibuf.c (get_minibuffer):
2038 * nsfns.m (Fns_perform_service):
2039 * nsfont.m (ns_script_to_charset):
2040 * nsmenu.m (ns_popup_dialog):
2041 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2042 (Fx_own_selection_internal):
2043 * nsterm.m (append2):
2044 * print.c (Fredirect_debugging_output)
2045 (print_prune_string_charset):
2046 * process.c (Fdelete_process, Fprocess_contact)
2047 (Fformat_network_address, set_socket_option)
2048 (read_and_dispose_of_process_output, write_queue_push)
2049 (send_process, exec_sentinel):
2050 * sound.c (Fplay_sound_internal):
2051 * textprop.c (validate_plist, add_properties)
2052 (Fput_text_property, Fadd_face_text_property)
2053 (copy_text_properties, text_property_list, syms_of_textprop):
2054 * unexaix.c (report_error):
2055 * unexcoff.c (report_error):
2056 * unexsol.c (unexec):
2057 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2058 (Fformat_mode_line, syms_of_xdisp):
2059 * xfaces.c (set_font_frame_param)
2060 (Finternal_lisp_face_attribute_values)
2061 (Finternal_merge_in_global_face, syms_of_xfaces):
2062 * xfns.c (x_default_scroll_bar_color_parameter)
2063 (x_default_font_parameter, x_create_tip_frame):
2064 * xfont.c (xfont_supported_scripts):
2065 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2066 (menu_help_callback, xmenu_show):
2067 * xml.c (make_dom):
2068 * xterm.c (set_wm_state):
2069 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2070 and similarly for list2 through list5.
2071
bafe80ce
PE
20722013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 * callproc.c (Fcall_process_region): Fix minor race and tune.
2075 (create_temp_file): New function, with the temp-file-creation part
2076 of the old Fcall_process_region. Use Fcopy_sequence to create the
2077 temp file name, rather than alloca + build_string, for simplicity.
2078 Don't bother to block input around the temp file creation;
068f9124
SM
2079 shouldn't be needed. Simplify use of mktemp.
2080 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2081 this closes an unlikely race where the temp file was not removed.
2082 Use memcpy rather than an open-coded loop.
2083 (Fcall_process_region): Use the new function. If the input is
2084 empty, redirect from /dev/null rather than from a newly created
2085 empty temp file; this avoids unnecessary file system traffic.
2086
4700b5a5
PE
20872013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2088
5c97beae
PE
2089 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2090 Simplify by making this case like the other two. This is a bit
2091 slower on obsolete hosts, but the extra complexity isn't worth it.
2092
4700b5a5
PE
2093 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2094 * process.c (create_process) [!DOS_NT]:
2095 Remove now-unnecessary calls to emacs_close.
2096
f9a74c4c
EZ
20972013-07-13 Eli Zaretskii <eliz@gnu.org>
2098
922ae7ee
EZ
2099 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2100 returning early. (Bug#14850)
2101
f9a74c4c
EZ
2102 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2103 and inhibit-iso-escape-detection attributes of 'undecided'.
2104 (Bug#14822)
2105
5e301d76
PE
21062013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2107
69e0e5ee
PE
2108 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2109 Reported by Herbert J. Skuhra in
2110 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2111
5e301d76
PE
2112 Don't lose top specpdl entry when memory is exhausted.
2113 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2114 specpdl overflow here, to simplify callers; all callers changed.
2115 Always reserve an unused entry at the stack top; this avoids
2116 losing the top entry's information when memory is exhausted.
2117
7e649856
PE
21182013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2119
a773ed9a
PE
2120 Clean up errno reporting and fix some errno-reporting bugs.
2121 * callproc.c (Fcall_process):
2122 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2123 * process.c (create_process, Fmake_network_process):
2124 * unexaix.c (report_error):
2125 * unexcoff.c (report_error):
2126 Be more careful about reporting the errno of failed operations.
2127 The code previously reported the wrong errno sometimes.
2128 Also, prefer report_file_errno to setting errno + report_file_error.
2129 (Fcall_process): Look at openp return value rather than at path,
2130 as that's a bit faster and clearer when there's a numeric predicate.
2131 * fileio.c (report_file_errno): New function, with most of the
2132 old contents of report_file_error.
2133 (report_file_error): Use it.
2134 (Ffile_exists_p, Ffile_accessible_directory_p):
2135 Set errno to 0 when it is junk.
2136 * fileio.c (Faccess_file):
2137 * image.c (x_create_bitmap_from_file):
2138 Use faccessat rather than opening the file, to avoid the hassle of
2139 having a file descriptor open.
2140 * lisp.h (report_file_errno): New decl.
2141 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2142
7e649856
PE
2143 Minor EBADF fixes.
2144 * process.c (create_process, wait_reading_process_output) [AIX]:
2145 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2146 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2147 a multithreaded environment anyway).
2148 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2149
f6774c1a
AS
21502013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2151
2152 * image.c (x_find_image_file): Don't close a remote file handle.
2153
bacba3c2
PE
21542013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 Fix races with threads and file descriptors.
2157 * callproc.c (Fcall_process_region):
2158 * dired.c (open_directory):
2159 * emacs.c (main, Fdaemon_initialized):
2160 * image.c (x_find_image_file):
2161 * inotify.c (Finotify_rm_watch):
2162 * lread.c (Flocate_file_internal):
2163 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2164 * term.c (term_mouse_moveto, init_tty):
2165 * termcap.c (tgetent):
2166 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2167 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2168 * unexhp9k800.c, unexmacosx.c (unexec):
2169 * callproc.c (Fcall_process_region):
2170 Use emacs_close, not close.
2171 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2172 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2173 and posix_close function on current platforms (which all lack them).
2174 (emacs_close): Use it. This should fix the races on GNU/Linux and
2175 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2176 and it should avoid closing random victim file descriptors on
2177 other platforms.
2178
653d4f43
PE
21792013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2180
c8536ec4
PE
2181 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2182 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2183 Touch up doc a bit.
2184
9c203066
PE
2185 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2186 This is for .gdbinit xbacktrace.
2187
653d4f43
PE
2188 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2189 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2190 (emacs_set_tty): Now static.
2191 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2192 * term.c (tty_capable_p, tty_default_color_capabilities)
2193 (get_tty_terminal, term_mouse_movement)
2194 (handle_one_term_event, init_tty, maybe_fatal):
2195 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2196 (tgetent, scan_file, name_match, compare_contin):
2197 * terminal.c (get_terminal):
2198 Use bool for boolean.
2199 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2200 Prefer char to unsigned char if either will do.
2201 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2202 (tty_write_glyphs): Prefer int to unsigned.
2203 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2204 All callers changed.
2205 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2206
45b683a1
PE
22072013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2208
29abe551
PE
2209 Port to C89.
2210 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2211 (B__dummy__): New dummy symbol, to pacify C89.
2212 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2213 they can't grok varargs macros.
2214 * dispnew.c (add_window_display_history)
2215 (add_frame_display_history):
2216 * print.c (print_object):
2217 * xdisp.c (debug_method_add):
2218 Use %p printf format only for void pointers.
2219 * emacs.c (usage_message): New constant, replacing ...
2220 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2221 (main): Adjust to usage reorg.
2222 * fns.c (syms_of_fns):
2223 * profiler.c (syms_of_profiler):
2224 Don't use non-constant struct initializers.
2225 * gnutls.h (gnutls_initstage_t):
2226 * lisp.h (enum Lisp_Fwd_Type):
2227 * lread.c (lisp_file_lexically_bound_p):
2228 * xsettings.c (anonymous enum):
2229 Remove trailing comma.
2230 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2231 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2232 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2233 (DEFUN): Use it.
2234 * regex.c (const_re_char): New type, to pacify strict C89.
2235 All uses of 'const re_char' replaced to use it.
2236 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2237 with glibc when strict C89. This change is imported from gnulib.
2238 All uses changed.
2239 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2240 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2241 Omit GNU_LINUX implementation, since it requires long long.
2242 * xterm.c (x_draw_underwave):
2243 Do not assume the traditional order of struct's members.
2244 (x_term_init): Rewrite to avoid the need for non-constant structure
2245 initializers.
2246
45b683a1 2247 Syntax cleanup, mostly replacing macros with functions.
763a086d 2248 This removes the need for the syntax_temp hack.
45b683a1
PE
2249 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2250 * syntax.c (SYNTAX_INLINE): New macro.
2251 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2252 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2253 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2254 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2255 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2256 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2257 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2258 Now constants, not macros.
2259 (syntax_temp) [!__GNUC__]: Remove.
2260 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2261 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2262 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2263 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2264 Move here from syntax.h; now functions, not macros. Except for the
2265 last function, these are static since only syntax.c uses them.
2266 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2267 All uses changed. Now a function, not a macro; use this fact
2268 to simplify the code.
2269 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2270 compiler bugs; no longer relevant.
2271 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2272 (SYNTAX_INLINE): New macro.
2273 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2274 for the new functions. Use bool for boolean member.
2275 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2276 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2277 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2278 (SETUP_BUFFER_SYNTAX_TABLE):
2279 Now extern inline functions, not macros.
2280 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2281 Remove; all uses replaced by implementation.
2282 (syntax_temp) [!__GNUC__]: Remove decl.
2283 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2284
29be4a50
JD
22852013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2286
2287 * emacs.c (main): Fix syntax error.
2288
954b166e
PE
22892013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 Timestamp fixes for undo (Bug#14824).
2292 * atimer.c (schedule_atimer):
2293 * fileio.c (Ffile_newer_than_file_p):
2294 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2295 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2296 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2297 (syms_of_fileio): Remove Sclear_visited_file_name.
2298 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2299 file doesn't exist; this avoids an ambiguity with negative timestamps.
2300 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2301 * systime.h (make_emacs_time, invalid_emacs_time):
2302 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2303 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2304 * undo.c (record_first_change): Push (visited-file-modtime) onto
2305 undo list rather than reimplementing it by hand, incorrectly.
2306
d74647c3
KB
23072013-07-09 Ken Brown <kbrown@cornell.edu>
2308
2309 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2310
3c51b96b
JB
23112013-07-09 Juanma Barranquero <lekktu@gmail.com>
2312
2313 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2314
4ebbdd67
PE
23152013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 Handle errno and exit status a bit more carefully.
2318 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2319 number into an exit status. Instead, use EXIT_CANCELED.
2320 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2321 * callproc.c (relocate_fd):
2322 * emacs.c (close_output_streams, main):
2323 * process.c (create_process):
2324 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2325 Use emacs_perror for simplicity.
2326 * callproc.c (relocate_fd, main):
2327 * sysdep.c (sys_subshell):
2328 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2329 (shut_down_emacs): Use emacs_write, not write.
2330 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2331 * fileio.c (Fcopy_file, e_write):
2332 * nsterm.m (ns_select):
2333 * process.c (send_process):
2334 * sound.c (vox_write):
2335 Use emacs_write_sig, not emacs_write.
2336 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2337 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2338 New constants.
2339 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2340 of write.
2341 (emacs_full_write): New function.
2342 (emacs_write): Rewrite to use it.
2343 (emacswrite_sig, emacs_perror): New functions.
2344 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2345
44e18199 23462013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2347
2348 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2349 on NS even if it is present. Pixmap on NS is a void*.
2350
9caab067
PE
23512013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 Port to Ubuntu 10 (Bug#14803).
2354 Problem reported by T.V. Raman.
2355 * process.c (close_on_exec, accept4, process_socket):
2356 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2357
1d442672
EZ
23582013-07-07 Eli Zaretskii <eliz@gnu.org>
2359
2360 * w32.c (sys_dup): Declare prototype.
2361
2362 * filelock.c:
2363 * emacs.c:
2364 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2365
067428c1
PE
23662013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2367
2368 Make file descriptors close-on-exec when possible (Bug#14803).
2369 This simplifies Emacs a bit, since it no longer needs to worry
2370 about closing file descriptors by hand in some cases.
2371 It also fixes some unlikely races. Not all such races, as
2372 libraries often open files internally without setting
2373 close-on-exec, but it's an improvement.
2374 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2375 * callproc.c (Fcall_process) [!MSDOS]:
2376 * emacs.c (main) [!DOS_NT]:
2377 * nsterm.m (ns_term_init):
2378 * process.c (create_process):
2379 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2380 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2381 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2382 Prefer mkostemp with O_CLOEXEC to mkstemp.
2383 * callproc.c (relocate_fd) [!WINDOWSNT]:
2384 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2385 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2386 now using pipe2.
2387 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2388 Make the resulting file descriptor close-on-exec.
2389 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2390 * lread.c (load_descriptor_list, load_descriptor_unwind):
2391 Remove; no longer needed. All uses removed.
2392 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2393 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2394 New functions.
2395 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2396 (Fmake_network_process, Fnetwork_interface_list):
2397 (Fnetwork_interface_info, server_accept_connection):
2398 Make newly-created socket close-on-exec.
2399 * sysdep.c (emacs_open, emacs_fopen):
2400 Make new-created descriptor close-on-exec.
2401 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2402 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2403
0da857dd
JD
24042013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2405
2406 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2407 for NS_IMPL_GNUSTEP.
2408
5f86adcd
PE
24092013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2410
2411 Fix openp errno handling.
2412 * callproc.c (Fcall_process): Preserve openp errno around close.
2413 * lread.c (openp): Set errno when returning -1, as some callers
2414 expect this.
2415
1afb1d07
JD
24162013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2417
2418 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2419
2420 * nsterm.h (NSSavePanel): Update comment.
2421 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2422 (ns_run_file_dialog): Declare.
2423
2424 * nsfns.m: Remove panelOK.
2425 (ns_fd_data): New.
2426 (ns_run_file_dialog): New function.
2427 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2428 event loop, so file dialog is popped up by ns_run_file_dialog, called
2429 by sendEvent (Bug#14578).
2430 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2431
3323c263
EZ
24322013-07-06 Eli Zaretskii <eliz@gnu.org>
2433
fdda0220
EZ
2434 * xdisp.c (default_line_pixel_height): New function.
2435 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2436 (try_cursor_movement, redisplay_window, try_window)
2437 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2438
068f9124
SM
2439 * window.c (window_scroll_pixel_based):
2440 use default_line_pixel_height.
fdda0220
EZ
2441
2442 * dispextern.h (default_line_pixel_height): Add prototype.
2443
2444 * frame.c (x_set_line_spacing): Accept a float value for
2445 line-spacing parameter, per the documentation.
2446
3323c263
EZ
2447 * data.c (Fmultibyte_string_p): Doc fix.
2448
47ba6d43
PE
24492013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2450
406af475
PE
2451 Use emacs_open more consistently when opening files.
2452 This handles EINTR more consistently now, and makes it easier
2453 to introduce other uniform changes to file descriptor handling.
2454 * src/systdio.h: New file.
2455 * src/buffer.c (mmap_init):
2456 * cygw32.c (chdir_to_default_directory):
2457 * dispnew.c (Fopen_termscript):
2458 * emacs.c (Fdaemon_initialized):
2459 * fileio.c (Fdo_auto_save):
2460 * image.c (slurp_file, png_load_body, jpeg_load_body):
2461 * keyboard.c (Fopen_dribble_file):
2462 * lread.c (Fload):
2463 * print.c (Fredirect_debugging_output):
2464 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2465 * termcap.c (tgetent):
2466 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2467 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2468 * w32term.c (w32_initialize) [CYGWIN]:
2469 * xfaces.c (Fx_load_color_file):
2470 Use emacs_open instead of plain open, and emacs_fopen instead of
2471 plain fopen.
2472 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2473 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2474 * callproc.c (default_output_mode): New constant.
2475 (Fcall_process): Use it to call emacs_open instead of plain creat.
2476 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2477 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2478 (emacs_fopen): New function.
2479 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2480 Include <lisp.h>, for emacs_open.
2481 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2482
47ba6d43
PE
2483 Remove duplicate #include directives.
2484 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2485 * xfaces.c:
2486 Don't include stdio.h twice.
2487 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2488 Don't include sys/types.h or stdio.h twice.
2489 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2490 * lread.c: Don't include coding.h twice.
2491 * nsfont.m: Don't include frame.h twice.
2492 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2493 * ralloc.c: Don't include <unistd.h> twice.
2494 * xdisp.c: Don't include font.h twice.
2495 * xterm.c: Don't include fontset.h twice.
2496 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2497
b9ed53d5
PE
24982013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 Scale ImageMagick images more carefully.
2501 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2502 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2503 Be more careful about avoiding undefined behavior after
2504 integer overflow and division by zero.
2505
cf13177e
YM
25062013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2507
2508 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2509 (syms_of_w32fns): DEFSYM them.
2510 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2511 (CCHDEVICENAME): Define macros if not defined.
2512 (struct MONITOR_INFO_EX): New struct.
2513 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2514 (enum_display_monitors_fn): New variable.
2515 (globals_of_w32fns): Initialize it.
2516 (Fx_display_pixel_width, Fx_display_pixel_height)
2517 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2518 multi-monitor setups in docstrings.
2519 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2520 screen size by primary monitor's millimeter per pixel.
2521 (w32_monitor_enum, w32_display_monitor_attributes_list)
2522 (w32_display_monitor_attributes_list_fallback)
2523 (Fw32_display_monitor_attributes_list): New functions.
2524 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2525
2526 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2527 if not defined.
2528 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2529
86dfb7a8
MA
25302013-07-04 Michael Albinus <michael.albinus@gmx.de>
2531
2532 * fileio.c (Qfile_notify_error): New error symbol.
2533
2534 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2535 * inotify.c (inotify_callback, symbol_to_inotifymask)
2536 (Finotify_add_watch, Finotify_rm_watch): Use it.
2537 (inotifyevent_to_event): Exchange order of cookie and file name.
2538 (Finotify_add_watch): Adapt docstring.
2539
2540 * lisp.h (Qfile_notify_error): Declare.
2541
2c1c974b
PE
25422013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2543
2544 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2545 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2546 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2547 which did not work (see <http://bugs.gnu.org/14569#307>).
2548 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2549 && (!noninteractive || initialized)). This attempts to thread
2550 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2551
7a35b20f
JB
25522013-07-04 Juanma Barranquero <lekktu@gmail.com>
2553
2554 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2555 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2556
1ce5cd04
PE
25572013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2560 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2561 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2562 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2563
57f8c490
PE
25642013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2565
2566 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2567 Define to __sys_siglist.
2568
bcffb5ca
EZ
25692013-07-02 Eli Zaretskii <eliz@gnu.org>
2570
2571 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2572 word-wrap, so that overflow-newline-into-fringe would work in
2573 visual-line-mode. (Bug#2749)
2574 (move_it_in_display_line_to): When the last scanned display
2575 element fits exactly on the display line, and
2576 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2577 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2578 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2579 finding buffer position that corresponds to pixel coordinates,
2580 e.g. in buffer_posn_from_coords.
2581
2c41e781
JD
25822013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2583
2584 * process.c (handle_child_signal): Call catch_child_signal if
2585 NS_IMPL_GNUSTEP.
2586
c2418359
PE
25872013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2588
52a9bcae
PE
2589 Don't convert function pointers to void * and back.
2590 It isn't portable C, and it's easy enough to avoid.
2591 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2592 (make_save_value): Add support for SAVE_FUNCPOINTER.
2593 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2594 * print.c (print_object):
2595 Distinguish function from object pointers.
2596 * lisp.h (SAVE_FUNCPOINTER): New constant.
2597 (SAVE_SLOT_BITS): Adjust to it.
2598 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2599 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2600 (voidfuncptr): New typedef.
2601 (struct Lisp_Save_Value): New member data[0].funcpointer.
2602 (XSAVE_FUNCPOINTER): New function.
2603
c2418359
PE
2604 Simplify buildobj processing.
2605 * Makefile.in (buildobj.h): Make it a sequence of strings each
2606 followed by comma, rather than a single string. Put it into a
2607 .tmp file in case there's an error while generating it.
2608 (gl-stamp): Use .tmp for temp files.
2609 (mostlyclean): Clean .tmp files.
2610 * doc.c (buildobj): Move to just the routine that needs it.
2611 It's now an array of strings, so processing is simpler.
2612
8f43ce49
PE
26132013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2614
2615 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2616 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2617 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2618 Invoke malloc_enable_thread even when not interactive.
2619 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2620 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2621 in this case, since the underlying bug has now been fixed.
2622
24827db9
JB
26232013-07-01 Juanma Barranquero <lekktu@gmail.com>
2624
2625 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2626 unlinking it (bug#14691).
2627
ef099a94
MN
26282013-06-30 Michal Nazarewicz <mina86@mina86.com>
2629
2630 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2631 before checking whether buffer is modified. This lets
2632 `kill-buffer-query-functions' cancel killing of the buffer or save
2633 its content before `kill-buffer' asks user the "Buffer %s
2634 modified; kill anyway?" question.
2635
9d3f2fc2
JD
26362013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2637
2638 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2639 Let the super performKeyEquivalent deal with them (Bug#14747).
2640
e6c6c8c7
PE
26412013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2642
1d71c1d9
PE
2643 * widget.c (resize_cb): Remove unused local.
2644
8f5f35cc
PE
2645 Do not use GTK 3 if it exists but cannot be compiled.
2646 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2647 * xterm.c (x_error_handler) [!USE_GTK]:
2648 Do not use GTK 3.
2649
e6c6c8c7
PE
2650 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2651
0ba54312
EZ
26522013-06-30 Eli Zaretskii <eliz@gnu.org>
2653
5d1c3286
EZ
2654 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2655 to the valid range of values. (Bug#14753)
2656
0ba54312
EZ
2657 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2658 when moving point by using the current glyph matrix. This avoids
2659 the need to force redisplay when this function is called in a
2660 loop.
2661
9c90cc06
PE
26622013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 Fix minor problems found by static checking.
2665 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2666 Redo the latter's body to sidestep GCC parenthesization warnings.
2667 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2668 * coding.c (detect_coding, detect_coding_system):
2669 * coding.h (struct undecided_spec):
2670 Use bool for boolean.
2671 * image.c (QCmax_width, QCmax_height): Now static.
2672 * xdisp.c (Fmove_point_visually): Remove unused local.
2673
4c672a0f
EZ
26742013-06-29 Eli Zaretskii <eliz@gnu.org>
2675
2676 * xdisp.c (Fmove_point_visually): New function.
2677
c1ea3abf
JB
26782013-06-28 Kenichi Handa <handa@gnu.org>
2679
2680 * coding.h (define_coding_undecided_arg_index): New enum.
2681 (coding_attr_index): New members
2682 coding_attr_undecided_inhibit_null_byte_detection,
2683 coding_attr_undecided_inhibit_iso_escape_detection,
2684 coding_attr_undecided_prefer_utf_8.
2685 (undecided_spec): New struct.
2686 (struct coding_system): New member `undecided' of the member
2687 `spec'.
2688
2689 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2690 (detect_coding): Likewise.
2691 (detect_coding_system): Likewise.
2692 (Fdefine_coding_system_internal): New coding system properties
2693 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2694 :prefer-utf-8.
2695 (syms_of_coding): Adjust for coding_arg_undecided_max.
2696
ba3de9e6
PE
26972013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2698
2699 * image.c (x_from_xcolors): Remove unused local.
2700
547c9269
YM
27012013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2702
2703 Defer image data transfer between X client and server until actual
2704 display happens.
2705
2706 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2707 and `mask_img'.
2708
2709 * image.c (Destroy_Image): Remove.
2710 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2711 `mask_p', and `colors_p'. All uses changed.
2712 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2713 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2714 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2715 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2716 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2717 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2718 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2719 (image_get_x_image, image_unget_x_image): New functions or macros.
2720 (image_background, image_background_transparent, x_to_xcolors)
2721 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2722 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2723 instead of Destroy_Image.
2724 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2725 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2726 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2727 (imagemagick_load_image, svg_load_image): Use them instead of
2728 x_create_x_image_and_pixmap, and x_put_x_image followed by
2729 x_destroy_x_image, respectively.
2730 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2731 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2732 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2733 background_transparent fields.
2734 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2735 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2736
dae2f5ef
PE
27372013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2740 This mostly consists of undoing recent changes.
2741 * callproc.c (Fcall_process):
2742 * process.c (create_process):
2743 Do not worry about catching SIGCHLD here, undoing previous change.
2744 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2745 * process.c, process.h (catch_child_signal):
2746 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2747 * process.c (catch_child_handler): Don't worry about being called
2748 lazily and do not assume caller has blocked SIGCHLD, undoing
2749 previous change. Move first-time stuff back to
2750 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2751 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2752 set lib_child_handler if it's already initialized, which may
2753 help avoid problems on GNUStep.
2754
fa55d2aa
PE
27552013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2758 * callproc.c (Fcall_process):
2759 * process.c (create_process):
2760 Make sure SIGCHLD is caught before we fork,
2761 since Emacs startup no arranges to catch SIGCHLD.
2762 * process.c (lib_child_handler): Initialize to null, not to
2763 dummy_handler.
2764 (catch_child_signal): Allow self to be called lazily.
2765 Do nothing if it's already been called.
2766 Assume caller has blocked SIGCHLD (all callers do now).
2767 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2768 just before it's really needed.
2769 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2770 since it hasn't been caught yet.
2771
f3f9606c
LMI
27722013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2773
2774 * image.c (compute_image_size): New function to implement
2775 :max-width and :max-height.
2776 (imagemagick_load_image): Use it.
2777
c7041908
PE
27782013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2779
2780 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2781 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2782 Now extern.
2783 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2784 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2785 the SIGCHLD handler, since the code is not atomic and (due to glib)
2786 signals may be arriving now.
2787 * sysdep.c (init_signals): Do not catch child signals here;
2788 'main' now does that later, at a safer time.
2789
f86852b4
PE
27902013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2791
0dfeed58
PE
2792 Clean up SIGCHLD handling a bit (Bug#14569).
2793 * process.c, process.h (catch_child_signal):
2794 Now always extern, even if !NS_IMPL_GNUSTEP.
2795 * process.c (catch_child_signal): Move glib tickler here from
2796 init_process_emacs, so that it's done earlier in Emacs
2797 initialization. Also move the noninteractive && !initialized
2798 check here from init_process_emacs. This is all a bit cleaner for
2799 GNUish platforms, and I hope it works around the Cygwin bug.
2800 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2801 that glib signal handling is tickled before glib creates threads.
2802
f86852b4
PE
2803 * process.c (wait_reading_process_output): Avoid int overflow
2804 when reading more than 2 GiB total from a process.
2805
cbd6509c
PE
28062013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2807
2808 * process.c (create_process): Handle a couple more cases,
2809 i.e., work even if new_argv and wait_child_setup[i] are cached.
2810 Use Fcall_process's style for volatile vars.
2811
9de1114a
AS
28122013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2813
2814 * process.c (create_process): Mark PROCESS volatile.
2815
fbe9e0b9
PE
28162013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2817
2818 Use C99-style flexible array members if available.
2819 This avoids some subtle aliasing issues, which typically
2820 aren't a problem with GCC but may be a problem elsewhere.
2821 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2822 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2823 In either case, it uses a flexible array member rather than
2824 the old struct hack. All uses changed.
2825 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2826 Adjust to sdata reorganization.
2827 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2828 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2829 that ports better to pre-C99 non-GCC.
2830 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2831 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2832 as the latter has changed.
2833 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2834 and port better to pre-C99 GCC.
2835 * image.c (struct xpm_cached_color):
2836 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2837 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2838 Use FLEXIBLE_ARRAY_MEMBER.
2839 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2840 Move decl to top level so it gets checked against implementation.
2841 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2842 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2843
1fc71008
PE
28442013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2845
2846 * syntax.c: Integer cleanups.
2847 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2848 All uses that need 0-or-2 changed to:
2849 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2850 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2851 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2852 (char_quoted, prev_char_comend_first, back_comment)
2853 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2854 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2855 Use bool for boolean.
2856 (update_syntax_table, skip_chars, skip_syntaxes):
2857 Prefer int to unsigned when either will do.
2858 (back_comment): Return boolean success flag, like forw_comment,
2859 instead of positive-or-minus-1 (which might have overflowed int anyway).
2860 Don't stuff ptrdiff_t into int.
2861 (syntax_spec_code, syntax_code_spec): Now const.
2862 (Fmatching_paren, scan_lists, scan_sexps_forward):
2863 Use enum syntaxcode for syntax code.
2864 (Fmatching_paren): Check that arg is a character, not just an integer.
2865 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2866 (Finternal_describe_syntax_value): Omit no-longer-needed
2867 comparison to 0.
2868 (skip_chars): Use char, not unsigned char, when the distinction
2869 doesn't matter.
2870 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2871 * bytecode.c (exec_byte_code):
2872 * syntax.c (syntax_spec_code, Fchar_syntax)
2873 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2874 (init_syntax_once):
2875 * syntax.h (SYNTAX_WITH_FLAGS):
2876 Omit unnecessary casts.
2877
b932cad7
EZ
28782013-06-20 Eli Zaretskii <eliz@gnu.org>
2879
2880 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2881 line dimensions here, to avoid race conditions with the main
2882 thread. (Bug#14062, bug#14630, bug#14669)
2883
2884 * w32term.c (w32_draw_window_cursor): Compute the header line and
2885 mode line dimensions here.
2886 <w32_system_caret_window, w32_system_caret_hdr_height>:
2887 <w32_system_caret_mode_height>: New variables.
2888
2889 * w32term.h: Declare them.
2890
89561f72
PE
28912013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2892
5013fc08
PE
2893 * alloc.c (die): Move "assertion failed" string here ...
2894 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2895 COND when SUPPRESS_CHECKING. This shrinks the executable text
2896 size by 0.8% to 2.2% when configured with --enable-checking,
2897 depending on optimization flags (GCC 4.8.1 x86-64).
2898
89561f72
PE
2899 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2900
763a086d 29012013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2902
2903 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2904 base is 2; this is more accurate.
2905
983aeb9a
JB
29062013-06-19 Juanma Barranquero <lekktu@gmail.com>
2907
2908 * sound.c (string_default): Move to !WINDOWSNT section.
2909 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2910
178ba3e6
PE
29112013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2912
bbc51b15
PE
2913 * sound.c: Integer cleanups.
2914 Remove unnecessary forward decls.
2915 (struct sound_device): The 'file' member is now a Lisp_Object, not
2916 a char *, so that we needn't invoke alloca on a huge size.
2917 (Fplay_sound_internal): Adjust to this.
2918 (string_default): New function.
2919 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2920 Use it to adjust to the struct sound_device change.
2921 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2922 (be2hs) [0]: Remove.
2923
178ba3e6
PE
2924 * syntax.c (skip_chars): Don't use uninitialized storage
2925 when searching a multibyte buffer for characters that are not in a
2926 unibyte string that contains non-ASCII characters.
2927
69f60cdc
JD
29282013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2929
2930 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2931 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2932
0d6224d4
PE
29332013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2934
2935 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2936
3c542890
KH
29372013-06-18 Kenichi Handa <handa@gnu.org>
2938
f7e3f7cd
KH
2939 * font.c (Ffont_spec): Signal an error for an invalid font name
2940 (Bug#14648).
3c542890 2941
9349e5f7
PE
29422013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2945 In particular this ports to 32-bit sparc Sun cc.
2946 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2947 array with a dummy element at specpdl[-1], so that its address can
2948 be taken portably.
2949 (unbind_to): Do not copy the binding; not needed, now that we
2950 copy old_value in the one place where the copy is needed.
2951 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2952 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2953 (union specbinding): Rename from struct specbinding. Redo layout
2954 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2955 which is not portable. With Sun C 5.12 32-bit sparc, the
2956 declaration causes nargs to be an unsigned bitfield, a behavior
2957 that the C standard allows; but Emacs wants nargs to be signed.
2958 The overall type is now a union of structures rather than a
2959 structure of union of structures, and the 'kind' member is now a
2960 bitfield, so that the overall type doesn't grow. All uses changed.
2961 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2962
0a4df6a5
PE
29632013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2964
ec6ecaad
PE
2965 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2966 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2967
0a4df6a5
PE
2968 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2969
7bfe8dbc
EZ
29702013-06-17 Eli Zaretskii <eliz@gnu.org>
2971
2972 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2973 unless we know that the window w's frame is a frame object.
2974 Another attempt at solving bug#14062 and bug#14630.
2975
708e05f6
LMI
29762013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2977
2978 * textprop.c (property_set_type): New enum.
2979 (add_properties): Allow appending/prepending text properties.
2980 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2981 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2982 add_text_properties_1.
2983 (Fadd_face_text_property): New function that calls
2984 add_text_properties_1.
2985
84575e67
PE
29862013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 Move functions from lisp.h to individual modules when possible.
2989 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2990 * alloc.c (XFLOAT_INIT, set_symbol_name):
2991 * buffer.c (CHECK_OVERLAY):
2992 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2993 (set_char_table_parent):
2994 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2995 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2996 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2997 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2998 (set_blv_valcell):
2999 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3000 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3001 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3002 (backtrace_args, backtrace_debug_on_exit):
3003 * floatfns.c (CHECK_FLOAT):
3004 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3005 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3006 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3007 (set_hash_index_slot):
3008 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3009 * marker.c (CHECK_MARKER):
3010 * textprop.c (CHECK_STRING_OR_BUFFER):
3011 * window.c (CHECK_WINDOW_CONFIGURATION):
3012 Move here from lisp.h, and make these functions static rather than
3013 extern inline.
3014 * buffer.c (Qoverlayp):
3015 * data.c (Qsubrp):
3016 * fns.c (Qhash_table_p):
3017 * window.c (Qwindow_configuration_p):
3018 Now static.
3019 * lisp.h: Remove the abovementioned defns and decls.
3020
44e18199 3021 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3022 In lisp.h, prefer functions to function-like macros, and
3023 constants to object-like macros, when either will do. This:
3024 . simplifies use, as there's no more need to worry about
3025 arguments' side effects being evaluated multiple times.
3026 . makes the code easier to debug on some platforms.
3027 However, when using gcc -O0, keep using function-like macros
3028 for a few critical operations, for performance reasons.
3029 This sort of thing isn't needed with gcc -Og, but -Og
3030 is a GCC 4.8 feature and isn't widely-enough available yet.
3031 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3032 Remove enum lsb_bits; no longer needed.
3033 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3034 * buffer.c (Qoverlap):
3035 * data.c (Qsubrp):
3036 * fns.c (Qhash_table_p):
3037 Now extern, so lisp.h can use these symbols.
3038 * dispextern.h: Include character.h, for MAX_CHAR etc.
3039 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3040 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3041 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3042 (GLYPH_CODE_P): Move here from lisp.h.
3043 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3044 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3045 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3046 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3047 XUNTAG now returns void *.
3048 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3049 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3050 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3051 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3052 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3053 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3054 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3055 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3056 New macros, renamed from their sans-lisp_h_ counterparts.
3057 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3058 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3059 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3060 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3061 If compiling via GCC without optimization, define these as macros
3062 in addition to inline functions.
3063 To disable this, compile with -DINLINING=0.
3064 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3065 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3066 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3067 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3068 (INTMASK, VALMASK): Now macros, since static values cannot be
3069 accessed from extern inline functions.
3070 (VALMASK): Also a constant, for benefit of old GDB.
3071 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3072 is INTEGERP, which can fold it in.
5165d44a 3073 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3074 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3075 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3076 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3077 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3078 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3079 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3080 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3081 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3082 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3083 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3084 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3085 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3086 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3087 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3088 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3089 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3090 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3091 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3092 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3093 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3094 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3095 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3096 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3097 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3098 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3099 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3100 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3101 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3102 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3103 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3104 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3105 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3106 Now functions.
3107 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3108 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3109 (VALMASK): Define in one place rather than in two, merging the
3110 USE_LSB_TAG parts; this is simpler.
3111 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3112 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3113 Move up, to avoid use before definition.
3114 Also include "globals.h" earlier, for the same reason.
3115 (make_natnum): New function.
3116 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3117 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3118 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3119 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3120 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3121 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3122 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3123 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3124 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3125 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3126 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3127 (Qwindow_configuration_p, Qimage): New forward declarations.
3128 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3129 (STRING_COPYIN): Remove; unused.
3130 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3131 (xcar_addr, xcdr_addr): New functions. All uses changed.
3132 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3133 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3134 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3135 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3136 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3137 (TYPE_RANGED_INTEGERP): Simplify.
3138 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3139 (setlocale, fixup_locale, synchronize_system_messages_locale)
3140 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3141 Now empty functions, not macros.
3142 (functionp): Return bool, not int.
3143 * window.c (Qwindow_configuration_p): Now extern,
3144 so window.h can use it.
3145 * window.h (Qwindowp): Move decl back to lisp.h.
3146
9583ec36
EZ
31472013-06-15 Eli Zaretskii <eliz@gnu.org>
3148
3149 * xdisp.c (Fline_pixel_height): New function, required for solving
3150 bug #14567.
3151
210272ce
PE
31522013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3153
3154 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3155
de0503df
SM
31562013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3157
3158 * lread.c (syms_of_lread):
3159 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3160
afbfe143
KD
31612013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3162
3163 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3164
d177e213
XF
31652013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3166
3167 * fileio.c (expand_file_name): Doc fix.
3168
05e3e412
PE
31692013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3170
f7394b12
PE
3171 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3172 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3173 Wait for self, not for 0. This can't hurt on GNU or similar
3174 system, and may help with Cygwin.
3175
05e3e412
PE
3176 * keyboard.c: Don't use PROP (...) as an lvalue.
3177 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3178 Use set_prop (A, B), not PROP (A) = B.
3179
17dd3097
EZ
31802013-06-10 Eli Zaretskii <eliz@gnu.org>
3181
3182 * xdisp.c (get_it_property): Use it->window instead of generating
3183 a Lisp object from it->w.
3184
52fab9c9
EZ
31852013-06-09 Eli Zaretskii <eliz@gnu.org>
3186
3187 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3188 get-char-property the window that is being rendered, instead of
3189 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3190 (compute_display_string_pos): When W is NULL, use the current
3191 buffer as the object to pass to get-char-property.
3192 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3193 pointer member of the bidi iterator, since no window is pertinent
3194 to this function.
52fab9c9 3195
5bf97bfc
EZ
31962013-06-08 Eli Zaretskii <eliz@gnu.org>
3197
3198 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3199 being displayed, and pass it to compute_display_string_pos.
3200 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3201 (bidi_paragraph_init): All callers changed.
3202
3203 * xdisp.c (init_from_display_pos, init_iterator)
3204 (handle_single_display_spec, next_overlay_string)
3205 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3206 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3207 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3208 (compute_display_string_pos): Accept additional argument, the
3209 window being displayed, and pass it to Fget_char_property.
3210 (Bug#14575)
3211
3212 * dispextern.h (struct bidi_it): New member w, the window being
3213 displayed.
3214 (compute_display_string_pos): Adjust prototype.
3215
5de0e011
JD
32162013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3217
e7b41c4c 3218 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3219
3220 * process.c (wait_reading_process_output): Check for NS before GLIB.
3221 GLIB may be linked in due to rsvg, but ns_select must be called.
3222
5de0e011
JD
3223 * xgselect.c (xg_select): Remove call to window_system_available
3224 and g_main_context_pending at the top, so Gdk events (i.e. file
3225 notify) are processed when Emacs is started with -nw.
3226
a822acff
EZ
32272013-06-07 Eli Zaretskii <eliz@gnu.org>
3228
3229 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3230 (ctagsfiles3): New variable, includes only *.m files.
3231 (TAGS): Use an explicit language name in the regular expressions,
3232 to avoid transformation of '/SOMETHING' by MSYS to
3233 'c:\MSYS\SOMETHING'.
3234
6c0a9ed1
RC
32352013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3236
3237 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3238
9ef6111b
EZ
32392013-06-06 Eli Zaretskii <eliz@gnu.org>
3240
3241 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3242 still need to set the mouse pointer shape and activate help-echo.
3243 (Bug#14558)
3244
7d300d64
PE
32452013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3246
3247 A few porting etc. fixes for the new file monitor code.
3248 See the thread containing
3249 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3250 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3251 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3252 (dir_monitor_callback, Fgfile_rm_watch):
3253 Use assq_no_quit instead of Fassoc, for speed.
3254 (dir_monitor_callback, Fgfile_rm_watch):
3255 eassert that the monitor is a fixnum.
3256 (dir_monitor_callback): No need for CDR_SAFE.
3257 Simplify building of lisp with alternative tails.
3258 (Fgfile_add_watch, Fgfile_rm_watch):
3259 Do not assume glib functions set errno reliably on failure.
3260 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3261 and signal an error otherwise.
3262 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3263 Use Fdelq instead of Fdelete, for speed.
3264
817ebfcf
EZ
32652013-06-05 Eli Zaretskii <eliz@gnu.org>
3266
3267 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3268 don't insist on being invoked on a highlighted tool-bar button.
3269 Avoids losing tool-bar functionality when mouse-highlight is nil.
3270 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3271 Don't highlight when mouse-highlight is nil.
3272 (note_mouse_highlight): When mouse-highlight is nil, don't return
3273 right away; instead, run tool-bar and mode-line highlight
3274 subroutine, clear any existing highlight, and revert the mouse
3275 pointer to its default shape. (Bug#14558)
3276
55577e7c
SM
32772013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3278
3279 * lisp.mk (lisp): Add prog-mode.el.
3280
f019a684
PE
32812013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3282
3283 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3284 * process.c (dummy_handler): New function.
3285 (lib_child_handler): New static var.
3286 (handle_child_signal): Invoke it.
3287 (catch_child_signal): If a library has set up a signal handler,
3288 save it into lib_child_handler.
3289 (init_process_emacs): If using glib and not on Windows, tickle glib's
3290 child-handling code so that it initializes its private SIGCHLD handler.
3291 * syssignal.h (SA_SIGINFO): Default to 0.
3292 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3293 31; it should no longer be needed now.
3294
90db8702
MA
32952013-06-05 Michael Albinus <michael.albinus@gmx.de>
3296
3297 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3298
3299 * gfilenotify.c (globals_of_gfilenotify): New function.
3300 (syms_of_gfilenotify): Move global initialization there.
3301
3302 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3303
bfa3acd6
SM
33042013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3305
3306 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3307 * keyboard.c (menu_bar_items, tool_bar_items):
3308 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3309 not override local keymaps any more.
3310
ba59bd80
EZ
33112013-06-04 Eli Zaretskii <eliz@gnu.org>
3312
3313 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3314
7f203aa1
EZ
33152013-06-03 Eli Zaretskii <eliz@gnu.org>
3316
9337e206
EZ
3317 * w32console.c (initialize_w32_display): Return the dimensions of
3318 the console window via 2 additional arguments, not via the current
3319 frame. This avoids crashes due to overrunning the bounds of
3320 frame's decode_mode_spec_buffer, which is not resized following
3321 the change of the frame dimensions from the initial 10x10.
3322
3323 * w32term.h (w32_initialize_display_info): Adjust prototype.
3324
3325 * term.c (init_tty): Take dimensions of the frame from the values
3326 returned by initialize_w32_display.
3327
7f203aa1
EZ
3328 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3329 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3330 (LIBES): Add $(GFILENOTIFY_LIBS).
3331
3332 * w32inevt.c (handle_file_notifications): Add dummy implementation
3333 for !HAVE_W32NOTIFY.
3334
3335 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3336
55a87246
JD
33372013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3338
3339 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3340
3341 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3342
3343 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3344
3d5ee10a
PE
33452013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3346
3347 Fix minor problems found by static checking.
3348 * data.c (pure_write_error):
3349 Use xsignal2, not Fsignal, as Fsignal might return.
3350 * eval.c (set_backtrace_debug_on_exit): Now static.
3351 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3352 No longer inline. EXTERN_INLINE is needed only for functions
3353 defined in .h files. Reindent function header as per GNU style.
3354 (backtrace_p, backtrace_top, backtrace_next):
3355 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3356 compiler or linker. Add extern decls to pacify gcc -Wall.
3357 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3358 Now static.
3359 * frame.c (free_monitors): Define only on platforms that need it.
3360 * nsterm.m (ns_term_init):
3361 * process.c (catch_child_signal):
3362 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3363 defined on all porting targets these days.
3364 * process.c, process.h (catch_child_signal):
3365 Make it extern only if NS_IMPL_GNUSTEP is defined.
3366
e2d8a6f0
EZ
33672013-06-03 Eli Zaretskii <eliz@gnu.org>
3368
3369 * w32.c (gettimeofday): Make the signature identical to prototype
3370 in nt/inc/sys/time.h.
3371
a8a7c5f6
SM
33722013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3373
3374 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3375 .gdbinit.
3376
3377 * keyboard.c (safe_run_hooks_error): Improve error message.
3378
3379 * data.c (pure_write_error): Add `object' argument.
3380 * puresize.h (CHECK_IMPURE): Use it.
3381
c9628c79
MA
33822013-06-03 Michael Albinus <michael.albinus@gmx.de>
3383
3384 * Makefile.in (NOTIFY_OBJ): New variable.
3385 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3386
3387 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3388 Call syms_of_gfilenotify.
3389
3390 * gfilenotify.c: New file.
3391
3392 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3393 and Qfile_w32notify.
3394 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3395 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3396
3397 * lisp.h: Declare syms_of_gfilenotify.
3398
3399 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3400
2f592f95
SM
34012013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3402
3403 Merge the specpdl and backtrace stacks. Make the structure of the
3404 specpdl entries more obvious via a tagged union of structs.
3405 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3406 (enum specbind_tag): New enum.
3407 (struct specbinding): Make it a tagged union of structs.
3408 Add a case for backtrace records.
3409 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3410 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3411 (backtrace_debug_on_exit): New accessors.
3412 (struct backtrace): Remove.
3413 (struct catchtag): Remove backlist field.
3414 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3415 Move to eval.c.
3416 (Flocal_variable_p): Speed up the common case where the binding is
3417 already loaded.
3418 * eval.c (backtrace_list): Remove.
3419 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3420 (set_backtrace_args, set_backtrace_nargs)
3421 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3422 (backtrace_next): New functions.
3423 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3424 (unwind_to_catch, internal_lisp_condition_case)
3425 (internal_condition_case, internal_condition_case_1)
3426 (internal_condition_case_2, internal_condition_case_n): Don't bother
3427 with backtrace_list any more.
3428 (Fsignal): Adjust to new backtrace format.
3429 (grow_specpdl): Move up.
3430 (record_in_backtrace): New function.
3431 (eval_sub, Ffuncall): Use it.
3432 (apply_lambda): Adjust to new backtrace format.
3433 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3434 data.c.
3435 (specbind): Adjust to new specpdl format. Simplify.
3436 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3437 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3438 backtrace format.
3439 (mark_backtrace): Remove.
3440 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3441 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3442 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3443 Use mark_specpdl.
3444 * profiler.c (record_backtrace): Use get_backtrace.
3445 (handle_profiler_signal): Use backtrace_top_function.
3446 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3447 accessor functions.
3448
c0342369
JD
34492013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3450
3451 * process.h (catch_child_signal): Declare.
3452
3453 * process.c (catch_child_signal): New function.
3454 (init_process_emacs): Call it.
3455
3456 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3457 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3458 NS_IMPL_COCOA.
3459 (x_set_cursor_type): Remove declaration.
3460 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3461 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3462 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3463 (ns_get_color): Use F suffix on float.
3464 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3465 (ns_get_rgb_color): Remove.
3466 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3467 (note_mouse_movement): x and y are CGFloat.
3468 (ns_draw_fringe_bitmap): Remove unused rowY.
3469 Change #if to COCOA && >= 10_6.
3470 (ns_draw_window_cursor): Remove unused overspill.
3471 (ns_draw_underwave): width and x are EamcsCGFloat.
3472 (ns_draw_box): thickness is CGFloat.
3473 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3474 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3475 if not in main thread.
3476 (ns_get_pending_menu_title, ns_check_menu_open)
3477 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3478 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3479 (sendFromMainThread:): New method.
3480 (changeFont:): size is CGFloat.
3481 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3482 Disable warning about permanent text.
3483 (characterIndexForPoint:): Adjust return type depending on GNUStep
3484 version.
3485 (mouseDown:): delta is CGFloat.
3486 (updateFrameSize): Remove unised variable f.
3487 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3488 Cast float to EmacsCGFloat.
3489 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3490 also to -1 when restoring.
3491 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3492 inside NS_IMPL_COCOA.
3493 (toggleFullScreen:): Put call to toggleFullScreen inside
3494 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3495 (setPosition:portion:whole:): por is CGFloat.
3496 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3497 (mouseDown:): Use CGFloat.
3498 (mouseDragged:): Remove unised variable edge.
3499 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3500
3501 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3502 of CGFloat differs.
3503 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3504 when NS_IMPL_GNUSTEP.
3505 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3506 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3507 (EmacsToolbar): Add clearAll. Add tag argument to
3508 addDisplayItemWithImage.
3509 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3510
3511 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3512
3513 * nsmenu.m (ns_update_menubar): Make static.
3514 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3515 (fillWithWidgetValue:): Add cast to SEL for setAction.
3516 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3517 (update_frame_tool_bar): Update code for GNUStep.
3518 (clearAll): New method.
3519 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3520 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3521 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3522 call to insertItemWithItemIdentifier.
3523 (validateVisibleItems): Fix indentation.
3524 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3525 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3526 UtilityWindow to aStyle, remove call to setStyleMask.
3527
3528 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3529
3530 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3531 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3532 Use F suffix on floats.
3533 (ns_char_width): Returns CGFloat.
3534 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3535 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3536 DPSxshow.
3537 (ns_glyph_metrics): CGFloat instead of float.
3538
a0eb10b3
JB
3539 * nsfns.m (x_set_foreground_color, x_set_background_color):
3540 Use EmacsCGFloat.
3541 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3542 remove unused variables.
3543 (Fns_read_file_name): Keep track if panel is for save.
3544 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3545 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3546 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3547 Just return the input if GNUStep.
c0342369
JD
3548 (x_screen_planes): Remove.
3549 (Fxw_color_values): Use EmacsCGFloat
3550 (Fns_display_monitor_attributes_list): Only get screen number for
3551 Cocoa.
ef099a94 3552 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3553 EmacsSavePanel.
3554 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3555 ns_directory_from_panel.
3556
da9aff11
PE
35572013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3558
3559 * process.c (handle_child_signal): Also use WCONTINUED.
3560 This is so that list-processes doesn't mistakenly list the process
3561 as stopped, when the process has actually been continued and is
3562 now running.
3563
0e64479a
PE
35642013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3565
fc186a96
PE
3566 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3567 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3568 not already configured.
3569
0e64479a
PE
3570 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3571
38b787fa
EZ
35722013-05-29 Eli Zaretskii <eliz@gnu.org>
3573
3574 * Makefile.in (mostlyclean): Remove *.res files.
3575
22513e52
SM
35762013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3577
3578 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3579 a buffer (bug#8447).
3580
6ef3db10
EZ
35812013-05-27 Eli Zaretskii <eliz@gnu.org>
3582
3583 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3584 display vector, and we backtrack, handle the case that the
3585 previous character position is also displayed from a display
3586 vector or covered by a display string or image. (Bug#14476)
3587
6799bb26
JD
35882013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3589
3590 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3591 (struct MonitorInfo, free_monitors): Remove.
3592 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3593 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3594 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3595 Qframes, Qsource.
3596
3597 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3598 (struct MonitorInfo, free_monitors): Remove.
3599 (ns_screen_name): Make static.
3600 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3601 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3602 Qframes, Qsource.
3603
3604 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3605 (struct MonitorInfo): New struct.
3606 (free_monitors, make_monitor_attribute_list): Declare.
3607
22513e52
SM
3608 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3609 New Lisp_Object:s.
6799bb26
JD
3610 (free_monitors, make_monitor_attribute_list): New functions.
3611 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3612 Qsource.
3613
38cd43eb
XF
36142013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3615
3616 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3617
2af0948d
SM
36182013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3619
a7eb9b0f
SM
3620 * keyboard.c: Apply keyboard decoding only to events that come directly
3621 from the tty, not from unread-command-events (bug#14368).
3622 (read_event_from_main_queue): New function, extracted from read_char).
3623 (read_decoded_char): Remove.
3624 (read_decoded_event_from_main_queue): New function to replace it.
3625 (read_char): Use it.
3626 (read_key_sequence): Use read_char rather than read_decoded_char.
3627
2af0948d
SM
3628 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3629
1413e9a5
BR
36302013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3631
3632 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3633
e6d2f155
KH
36342013-05-22 Kenichi Handa <handa@gnu.org>
3635
3636 The following changes are to fix the setting of
3637 buffer-file-coding-system on, for instance, C-x RET c unix RET
3638 _FILE_OF_DOS_EOL_TYPE_ RET.
3639
3640 * coding.h (struct coding_system): New member detected_utf8_chars.
3641
3642 * coding.c (detect_coding_utf_8): Count characters and check EOL
3643 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3644 BOM is there.
3645 (setup_coding_system): Do not initialize coding->head_ascii.
3646 (check_ascii): Do not set coding->eol_seen but update it. Do not
3647 call adjust_coding_eol_type here.
1413e9a5
BR
3648 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3649 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3650 of the found coding-system.
3651 (decode_coding_gap): Cancel previous change. Utilize the
3652 character numbers counted by detect_coding_utf_8. Fix detection
3653 of BOM for utf-8.
3654
ab56a6f4 36552013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3656
3657 * search.c (looking_at_1): Only set last_thing_searched if the match
3658 changed the match-data (bug#14281).
3659
ecc3c6ed
DA
36602013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3661
3662 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3663 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3664 (move_it_vertically_backward): Likewise.
3665
5ba8bf35
YM
36662013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3667
3668 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3669 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3670 (Fx_display_mm_width, Fx_display_mm_height):
3671 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3672
91e8418b 3673 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3674 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3675 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3676 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3677 (Fx_display_backing_store, Fx_display_visual_class)
3678 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3679 (Fx_display_grayscale_p, Fx_display_pixel_width)
3680 (Fx_display_pixel_height, Fx_display_planes)
3681 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3682 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3683 (Fx_display_mm_width, Fx_display_mm_height)
3684 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3685 height for all physical monitors as in X11.
3686
fc30d803
SM
3687 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3688 Return pixel width or height for all physical monitors as in X11.
91e8418b 3689
31ff141c
PE
36902013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3691
3692 Port --enable-gcc-warnings to clang.
3693 * bytecode.c (exec_byte_code):
3694 * regex.c:
3695 Redo diagnostic pragmas to pacify clang, too.
3696 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3697 * editfns.c (Fencode_time):
3698 * fileio.c (file_accessible_directory_p):
3699 * font.c (font_unparse_xlfd):
3700 Use '&"string"[index]' instead of '"string" + (index)'.
3701 * undo.c (user_error): Remove; unused.
3702
df065a0b
EZ
37032013-05-16 Eli Zaretskii <eliz@gnu.org>
3704
04d360e7
EZ
3705 * insdel.c (insert_1_both): Document the arguments, instead of
3706 referring to insert_1, which no longer exists.
3707
5bb98290
EZ
3708 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3709 some window, increment windows_or_buffers_changed, so that
3710 *Messages* display in that window is updated. (Bug#14408)
3711
df065a0b
EZ
3712 * w32.c: Include epaths.h.
3713 (init_environment): Use cmdproxy.exe without leading directories.
3714 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3715 case.
3716 (gettimeofday): Adjust signature and return value to Posix
3717 expectations.
3718
3719 * unexw32.c (open_output_file): Delete the existing emacs.exe
3720 before creating it, to break the hard link to the versioned
3721 executable.
3722
3723 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3724 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3725 (FIRSTFILE_OBJ): New variables.
3726 (W32_RES): Rename to EMACSRES. All users changed.
3727 (base_obj): Use $(CM_OBJ).
3728 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3729 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3730 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3731 $(W32_RES_LINK) before $(LIBES).
3732 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3733
1aa8d505
SM
37342013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3735
6e911150
SM
3736 * makefile.w32-in (DOC): Use just "DOC".
3737
3738 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3739
1aa8d505
SM
3740 * process.c: Export default filters and sentinels to Elisp.
3741 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3742 New constants.
3743 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3744 (Fset_process_sentinel, Fformat_network_address):
3745 Default to them instead of nil.
3746 (server_accept_connection): Sentinels can't be nil any more.
3747 (read_and_dispose_of_process_output): New function, extracted from
3748 read_process_output.
3749 (read_process_output): Use it; filters can't be nil.
3750 (Finternal_default_process_filter): New function, extracted from
3751 read_process_output.
3752 (exec_sentinel_unwind): Remove function.
3753 (exec_sentinel): Don't zilch sentinel while running.
3754 (status_notify): Sentinels can't be nil.
3755 (Finternal_default_process_sentinel): New function extracted from
3756 status_notify.
3757 (setup_process_coding_systems): Default filter is not nil any more.
3758 (syms_of_process): Export new Elisp functions and initialize
3759 new constants.
3760 * lisp.h (make_lisp_proc): New function.
3761
5ac2eb34
SM
37622013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3763
3764 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3765
eda9c7d7
EZ
37662013-05-14 Eli Zaretskii <eliz@gnu.org>
3767
3768 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3769 unless we know that the window w is a leaf window.
3770 Another attempt at solving bug#14062.
eda9c7d7 3771
8fdeaad5
JD
37722013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3773
3774 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3775 fdesc (Bug#14375).
3776
44aa9ee6
PE
37772013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3778
3779 * image.c (gif_load): Check that subimages fit (Bug#14345).
3780
759fd763
SM
37812013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3782
3783 * lread.c (skip_dyn_eof): New function.
3784 (read1): Use it to skip the end of a file in response to #@00.
3785
3786 * doc.c (get_doc_string): Slightly relax the sanity checking.
3787
4465bfb4
JD
37882013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3789
3790 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3791 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3792 (MonitorInfo): New struct.
3793 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3794 (Fns_display_monitor_attributes_list): New functions.
3795 (display-usable-bounds): Remove.
3796 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3797 Qsource.
3798
7583e2a0
PE
37992013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3800
3801 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3802 (GTK_CHECK_VERSION): New macro, if not already defined.
3803 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3804 replaced by GTK_CHECK_VERSION.
3805
ad75d77e
PE
38062013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 * xterm.h (GTK_PREREQ): New macro.
3809 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3810 to use this macro instead, for consistency and clarity.
3811
07525f77
EZ
38122013-05-08 Eli Zaretskii <eliz@gnu.org>
3813
3814 * xdisp.c (row_for_charpos_p): New function, with code of
3815 cursor_row_p, but accepts an additional argument CHARPOS instead
3816 of using a hardcoded PT.
3817 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3818 (row_containing_pos): Call row_for_charpos_p instead of partially
3819 doing the same. Fixes cursor positioning under longlines-mode
3820 when longlines-show-effect includes more than one newline, when
3821 moving the cursor vertically up.
3822
d901fc8d
JB
38232013-05-08 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * makefile.w32-in (ACL_H): New macro.
3826 ($(BLD)/fileio.$(O)): Update dependencies.
3827
f269bc61
PE
38282013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3829
e7b41c4c 3830 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3831 * Makefile.in (LIB_ACL): New macro.
3832 (LIBACL_LIBS): Remove.
3833 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3834 * fileio.c: Include <acl.h>.
3835 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3836 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3837 !acl_errno_valid.
3838 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3839 it ourselves.
3840
f269bc61
PE
3841 * unexelf.c: Don't assume ElfW (Half) fits in int.
3842 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3843 when dealing with ElfW (Half) values, since they can exceed 2**31
3844 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3845 (entry_address): Omit unused NUM arg. All uses changed.
3846
a261c53e
JL
38472013-05-07 Juri Linkov <juri@jurta.org>
3848
3849 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3850 to the string converted from number with `Fnumber_to_string'.
3851 (Bug#14254)
3852
2b66427d
PE
38532013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3854
3855 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3856 This fixes a problem introduced by my previous change.
3857
15acfe41
GM
38582013-05-07 Glenn Morris <rgm@gnu.org>
3859
3860 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3861
5ea03bf5
JD
38622013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3863
3864 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3865
e0c9d565
PE
38662013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3867
3868 Static checking by GCC 4.8.0.
3869 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3870 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3871 (x_get_monitor_attributes_fallback)
3872 (x_get_monitor_attributes_xinerama)
3873 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3874 Define only if USE_GTK.
3875 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3876 (x_get_monitor_attributes_fallback): Omit unused locals.
3877 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3878 Use double, not float, to avoid mixed-mode floating point arithmetic.
3879
4e3f9230
YM
38802013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3881 Jan Djärv <jan.h.d@swipnet.se>
3882
3883 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3884 (XINERAMA_CFLAGS): New macros.
3885 (ALL_CFLAGS, LIBES): Use them.
3886
3887 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3888 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3889 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3890 (syms_of_xfns): DEFSYM them.
3891 (struct MonitorInfo): New struct.
3892 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3893 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3894 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3895 (x_get_monitor_attributes_xinerama): New functions.
3896 (Fx_display_monitor_attributes_list): New primitive.
3897 (syms_of_xfns): Defsubr it.
3898
3899 * xterm.h (x_display_info): Add Xatom_net_workarea and
3900 Xatom_net_current_desktop.
3901
3902 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3903 and dpyinfo->Xatom_net_current_desktop.
3904
05839b6a
EZ
39052013-05-06 Eli Zaretskii <eliz@gnu.org>
3906
3907 * xdisp.c (pos_visible_p): Use the special code for finding the
3908 beginning of a display property or overlay for any "replacing"
3909 display property, not just for display strings. This solves
3910 incorrect reporting of position by posn-at-point. (Bug#14241)
3911
dc4a2ee0
PE
39122013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3913
5ee94506
PE
3914 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3915 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3916 Verify that ElfW (Half) fits in int.
3917 (fatal): Use same signature as lisp.h.
3918 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3919 configure and build with -DUNEXELF_DEBUG without worrying about
3920 other modules that use DEBUG.
3921 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3922 possibly-wide integers now uses it instead of plain fprintf.
3923 (entry_address): New function, which avoids problems with 32-bit
3924 overflow on 64-bit hosts.
3925 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3926 (round_up): Don't assume the remainder fits in int.
3927 (find_section): Use bool for boolean. Simplify debug code.
3928 (unexec): Don't assume file sizes fit in int or size_t.
3929 Omit unnecessary trailing newline in 'fatal' format.
3930 Use strerror rather than outputting decimal error number.
3931 Remove unused code when emacs is not defined;
3932 this file relies on Emacs now.
3933 Don't assume e_phnum and e_shnum are positive.
3934
dc4a2ee0
PE
3935 * regex.c: Fix problems when DEBUG is defined.
3936 (extract_number, extract_number_and_incr): Define regardless of
3937 whether DEBUG is defined; that's simpler and makes the code less
3938 likely to go stale in the normal case when DEBUG is not defined.
3939 Return int rather than taking an int * arg. All callers changed.
3940 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3941 Remove, replacing with ...
3942 (DEBUG_PRINT): New macro. All callers changed.
3943 (DEBUG_COMPILES_ARGUMENTS): New macro.
3944 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3945 (print_compiled_pattern, print_double_string) [DEBUG]:
3946 Use prototype rather than old-style definition.
3947 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3948 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3949 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3950 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3951 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3952 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3953 This matters only when DEBUG is defined.
3954
14c7ed05
EZ
39552013-05-05 Eli Zaretskii <eliz@gnu.org>
3956
3957 * xdisp.c (set_iterator_to_next): Set the
3958 ignore_overlay_strings_at_pos_p flag only if we are _really_
3959 iterating over an overlay string, as indicated by the
3960 current.overlay_string_index member. (Bug#14306)
3961
e6076b1b
JD
39622013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3963
3964 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3965 to where it is used, to avoid autorelease issues (Bug#14050).
3966
cbee2131
PE
39672013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3968
3969 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3970 * fileio.c (syms_of_fileio): Implement this.
3971 * filelock.c (create_lock_file): If symbolic links don't work, so
3972 we use a regular file as a lock file, do not fsync the lock file;
3973 it's not needed.
3974
30c7e542
SM
39752013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3976
3977 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3978 (syms_of_minibuf): Adjust accodingly.
3979 * lread.c (Fread):
3980 * callint.c (Fcall_interactively): Adjust calls accordingly.
3981
5bebd186
EZ
39822013-05-04 Eli Zaretskii <eliz@gnu.org>
3983
3984 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3985 w->contents is a buffer before computing everything else.
3986 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3987
3988 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3989 assertion violations. (Bug#14062)
3990
0fb0a4f3
DR
39912013-05-01 David Reitter <david.reitter@gmail.com>
3992
3993 * nsfns.m (ns_tooltip): Initialize.
3994
9e63b4a5
EZ
39952013-04-28 Eli Zaretskii <eliz@gnu.org>
3996
3997 * coding.c (decode_coding_gap): Don't remove the character before
3998 a newline unless it's a CR character. (Bug#14287)
3999
ad60824e
DN
40002013-04-28 Dan Nicolaescu <dann@gnu.org>
4001
4002 * dispextern.h (struct face): Move enum face_underline_type
4003 earlier so that bitfields can be in the same word.
4004
edbdcec0
JD
40052013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4006
4007 * nsfns.m (handlePanelKeys): New function.
4008 (EmacsOpenPanel:performKeyEquivalent:)
4009 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4010 arrows/function/control and copy/paste keys (Bug#14296).
4011
0208ede7
JL
40122013-04-27 Juri Linkov <juri@jurta.org>
4013
4014 * callint.c (Fcall_interactively): Call `Qread_number' for
4015 interactive code letter `n' instead of using duplicate code.
4016 (Bug#14254)
4017
b8dd59f7
PE
40182013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4019
4020 * systime.h (make_timeval): Declare as 'const'.
4021
8bd722db
KH
40222013-04-27 Kenichi Handa <handa@gnu.org>
4023
4024 * font.c (font_open_entity): Always open a font of manageable
4025 size.
4026
13d0e56f 40272013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4028
f780d632
PE
4029 Port better to AIX (Bug#14258).
4030 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4031 to pacify AIX xlc.
4032
ec509856
KH
40332013-04-24 Kenichi Handa <handa@gnu.org>
4034
4035 * coding.c (decode_coding_iso_2022): When an invalid escape
4036 sequence is encountered, reset the invocation and designation
4037 status to the safest one.
4038
84fc48e5
PE
40392013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4042 Without this fix, "make distclean" leaves stamp-h1 behind.
4043
806bda47
EC
40442013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4045
4046 * w32fns.c (w32_fullscreen_rect): New function to compute the
4047 window rectangle for the given fullscreen mode.
4048 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4049 longer tunes the window size. This keeps the window's edges flush
4050 with the screen and allows the taskbar to hide itself in fullboth.
4051
4052 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4053 window decorations and uses the entire screen.
4054
4055 * w32term.h (w32_fullscreen_rect) Add prototype.
4056 (struct w32_output): Replace normal_width, normal_height,
4057 normal_top, and normal_left members with a single normal_placement
4058 struct.
4059 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4060 Remove macros.
4061 (FRAME_NORMAL_PLACEMENT): New macro.
4062
9cc2810b
JB
40632013-04-16 Juanma Barranquero <lekktu@gmail.com>
4064
4065 * minibuf.c (Ftest_completion): Silence compiler warning.
4066
fd16b54c
EZ
40672013-04-15 Eli Zaretskii <eliz@gnu.org>
4068
4069 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4070 bug#14062.
fd16b54c
EZ
4071
4072 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4073 parentheses.
4074
4075 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4076 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4077 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4078 parentheses where appropriate.
4079
9e3379a0
PE
40802013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4083
ddd6b685
EZ
40842013-04-14 Eli Zaretskii <eliz@gnu.org>
4085
4086 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4087 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4088 Mention in the doc string that setting these variables takes
4089 effect only after a call to set-window-buffer. (Bug#14200)
4090
29b79ba1
EZ
40912013-04-13 Eli Zaretskii <eliz@gnu.org>
4092
4093 * indent.c (Fvertical_motion): Don't consider display strings on
4094 overlay strings as display strings on the buffer position we
4095 started from. This prevents vertical cursor motion from jumping
4096 more than one line when there's an overlay string with a display
4097 property at end of line.
4098 Reported by Karl Chen <Karl.Chen@quarl.org> in
4099 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4100
562c6ee9
SM
41012013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4102
4103 * window.c (select_window): `record_buffer' even if window is
4104 already selected (bug#14191).
4105
fcc1fe85
EZ
41062013-04-11 Eli Zaretskii <eliz@gnu.org>
4107
4108 * window.c (Fwindow_end): Test more flags, including the buffer's
4109 last_overlay_modified flag, to determine whether the window's
4110 display is really up-to-date. Prevents the function from
4111 returning a stale value. (Bug#14170)
4112 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4113 current matrix.
4114
f009190a
EZ
41152013-04-10 Eli Zaretskii <eliz@gnu.org>
4116
4117 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4118 garbaged only if it is not already the top frame on its TTY.
4119 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4120 there are GUI frames open in the same session. (Bug#13864)
4121
78ce603d
SM
41222013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4123
4124 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4125 of marking the idle timers directly.
4126
a8036e40
SM
41272013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4128
4129 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4130 tables (bug#14054).
4131
7ffe7ef6
SM
41322013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4133
4134 * window.c (select_window): Don't record_buffer while the invariant is
4135 temporarily broken (bug#14161).
4136
4137 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4138
7d9f6883
EZ
41392013-04-07 Eli Zaretskii <eliz@gnu.org>
4140
4141 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4142
5406cfd9
RF
41432013-04-07 Romain Francoise <romain@orebokech.com>
4144
4145 Ignore additional platform-specific ACL errors (Bug#13702).
4146 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4147 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4148
95c0e83b
JD
41492013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4150
4151 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4152 f->output_data.ns.
4153
876da980
PE
41542013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4157 This bug was introduced by my 2013-02-25 change that simplified
4158 data_start configuration. Without this change, on GNU/Linux
4159 an Emacs configured with --enable-profiling fails immediately
4160 due to a profiler signal.
4161 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4162 with these flags. On platforms where special flags are needed
4163 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4164 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4165 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4166
7452b7bd
DA
41672013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4168
4169 Get rid of some platform-specific functions examining window
4170 system and its capabilities. This is a partial rework of the
4171 2013-04-05 change.
4172 * lisp.h (have_menus_p): Remove prototype. This function is
4173 replaced with platform-independent window_system_available.
4174 (check_window_system): Move to...
4175 * frame.h (decode_window_system_frame, window_system_available):
4176 ...here, add new prototypes.
4177 * frame.c (window_system_available, decode_window_system_frame):
4178 New functions.
4179 (check_window_system): Platform-independent now.
4180 * xterm.h (x_in_use): Remove declaration.
4181 (check_x_frame):
4182 * w32term.h (check_x_frame):
4183 * nsterm.h (check_x_frame): Remove prototypes. This function
4184 is replaced with platform-independent decode_window_system_frame.
4185 * msdos.c (have_menus_p): Remove.
4186 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4187 Remove platform-specific functions. Use check_window_system,
4188 decode_window_system_frame and check_ns_display_info where
4189 appropriate. Minor style and comment tweaks.
4190 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4191 (check_x_frame): Likewise.
4192 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4193 Likewise.
4194 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4195 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4196 * xmenu.c, xselect.c: All related users changed.
4197
251e9147
KH
41982013-04-03 Kenichi Handa <handa@gnu.org>
4199
4200 The following changes is to optimize the code for reading UTF-8
4201 files.
4202
562c6ee9 4203 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4204 changed. Check EOL format. Do not call adjust_coding_eol_type
4205 here.
4206 (check_utf_8): New function.
4207 (adjust_coding_eol_type): Do nothing if already adjusted.
4208 (detect_coding): Compare the return value of check_ascii with
4209 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4210 (decode_coding_gap): Optimize for valid UTF-8.
4211
8bc369d4
KH
42122013-03-21 Kenichi Handa <handa@gnu.org>
4213
4214 * coding.c (syms_of_coding): Cancel previous change.
4215
4216 * insdel.c (insert_from_gap): Fix previous change.
4217
73931ad1
DA
42182013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4219
4220 Consistently use platform-specific function to detect window system.
4221 * lisp.h (check_window_system): New prototype. This function is
4222 going to replace check_x, check_w32 and check_ns.
4223 (have_menus_p): Mention msdos.c in comment.
4224 * fontset.c (check_window_system_func): Remove. Adjust all users.
4225 * fontset.h (check_window_system_func): Remove prototype.
4226 * nsterm.h (check_ns):
4227 * xterm.h (check_x):
4228 * w32term.h (check_w32): Likewise.
4229 * menu.c (Fx_popup_menu): Use check_window_system.
4230 * msdos.c (check_window_system): Define for MS-DOS.
4231 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4232 * w32fns.c (check_window_system): Likewise for MS-Windows.
4233 * xfns.c (check_window_system): Likewise for X.
4234 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4235 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4236
7216e43b
PE
42372013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4238
4239 Prefer < to > in range checks such as 0 <= i && i < N.
4240 This makes it easier to visualize quantities on a number line.
4241 This patch doesn't apply to all such range checks,
4242 only to the range checks affected by the 2013-03-24 change.
4243 This patch reverts most of the 2013-03-24 change.
4244 * alloc.c (xpalloc, Fgarbage_collect):
4245 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4246 * character.c (string_escape_byte8):
4247 * charset.c (read_hex):
4248 * data.c (cons_to_unsigned):
4249 * dispnew.c (update_frame_1):
4250 * doc.c (Fsubstitute_command_keys):
4251 * doprnt.c (doprnt):
4252 * editfns.c (hi_time, decode_time_components):
4253 * fileio.c (file_offset):
4254 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4255 * font.c (font_intern_prop):
4256 * frame.c (x_set_alpha):
4257 * gtkutil.c (get_utf8_string):
4258 * indent.c (check_display_width):
4259 * keymap.c (Fkey_description):
4260 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4261 * lread.c (read1):
4262 * minibuf.c (read_minibuf_noninteractive):
4263 * process.c (wait_reading_process_output):
4264 * search.c (Freplace_match):
4265 * window.c (get_phys_cursor_glyph):
4266 * xdisp.c (redisplay_internal):
4267 * xsmfns.c (smc_save_yourself_CB):
4268 Prefer < to > for range checks.
4269 * dispnew.c (sit_for): Don't mishandle NaNs.
4270 This fixes a bug introduced in the 2013-03-24 change.
4271 * editfns.c (decode_time_components): Don't hoist comparison.
4272 This fixes another bug introduced in the 2013-03-24 change.
4273
92759988
DA
42742013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4275
4276 * frame.h (struct frame): Drop scroll_bottom_vpos
4277 member becaue all real users are dead long ago.
4278 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4279 * xdisp.c (redisplay_internal): Adjust user.
4280
9a1971bb
GM
42812013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4282
f38ab167
JD
4283 * nsmenu.m (showAtX:Y:for:): setLevel to
4284 NSPopUpMenuWindowLevel (Bug#13998).
4285
6d01f1fe
JD
42862013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4287
4288 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4289 (ns_check_pending_open_menu): Declare.
4290
4291 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4292 (x_activate_menubar): Update the menu with title that matches
4293 ns_get_pending_menu_title, and call
4294 ns_check_pending_openmenu (Bug#12698).
4295 (menuWillOpen:): New method.
4296 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4297
4298 * nsterm.m (menu_will_open_state, menu_mouse_point)
4299 (menu_pending_title): New varaibles.
4300 (ns_get_pending_menu_title, ns_check_menu_open)
4301 (ns_check_pending_open_menu): New functions.
4302
781f4782
DA
43032013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4304
4305 * indent.c (current_column_bol_cache): Remove leftover which is not
4306 used in Fmove_to_column any more.
4307 (current_column, scan_for_column): Adjust users.
4308 * keyboard.c (last_point_position_buffer, last_point_position_window):
4309 Remove leftovers which are not used for recording undo any more.
4310 (command_loop_1, syms_of_keyboard): Adjust users.
4311 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4312 redisplay_window any more.
4313 (move_it_to): Adjust user.
4314
1921c31b
JB
43152013-03-29 Juanma Barranquero <lekktu@gmail.com>
4316
4317 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4318 Update dependencies.
4319
717b8bcd
SM
43202013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4321
4322 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4323 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4324 forward references.
4325
e74aeda8
DA
43262013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4327
4328 * window.h (struct window): Replace hchild, vchild and buffer slots
4329 with the only contents slot. This is possible because each valid
4330 window may have either the child window (in vertical or horizontal
4331 combination) or buffer to display (for the leaf window). Using that,
4332 a lof of operations to traverse and/or change window hierarchies may
4333 be simplified. New member horizontal is used to distinguish between
4334 horizontal and vertical combinations of internal windows.
4335 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4336 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4337 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4338 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4339 Use contents slot, not buffer, where appropriate.
4340 (wset_combination): New function.
4341 (wset_buffer): Add eassert.
4342 (Fframe_first_window): Simplify the loop reaching first window.
4343 (Fwindow_buffer): Use WINDOW_LEAF_P.
4344 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4345 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4346 (unshow_buffer): Convert initial debugging check to eassert.
4347 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4348 (make_parent_window, window_resize_check, window_resize_apply)
4349 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4350 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4351 Adjust to match struct window changes.
4352 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4353 (mark_window_cursors_off, count_windows, get_leaf_windows)
4354 (foreach_window_1): Simplify the loop.
4355 * alloc.c (mark_object): Do not check for the leaf window because
4356 internal windows has no glyph matrices anyway.
4357 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4358 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4359 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4360 (build_frame_matrix_from_window_tree, mirror_make_current)
4361 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4362 (update_window_tree, set_window_update_flags): Simplify the loop.
4363 (sync_window_with_frame_matrix_rows): Enforce live window.
4364 Use contents slot, not buffer, where appropriate.
4365 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4366 and WINDOW_HORIZONTAL_COMBINATION_P.
4367 (make_frame_visible_1): Simplify the loop.
4368 Use contents slot, not buffer, where appropriate.
4369 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4370 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4371 (expose_window_tree): Likewise.
4372 Use contents slot, not buffer, where appropriate.
4373 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4374 to avoid deleted windows. Use contents slot instead of buffer.
4375 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4376 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4377 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4378 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4379
121ab1cd
EZ
43802013-03-28 Eli Zaretskii <eliz@gnu.org>
4381
ef454cf7
EZ
4382 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4383 identify the reasons for assertion violations in bug#14062 and
4384 similar ones.
21e930f8
EZ
4385 (Fx_show_tip): Fix compilation error under
4386 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4387
121ab1cd
EZ
4388 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4389 Reported by <rzl24ozi@gmail.com>.
4390
5c89ca24
DA
43912013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4392
4393 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4394 start marker...
562c6ee9
SM
4395 (unwind_with_echo_area_buffer): ...to restore it here.
4396 This is needed to ensure that...
5c89ca24
DA
4397 (redisplay_window): ...both window markers are valid here,
4398 which is verified by eassert.
4399 * editfns.c (save_excursion_save): Do not assume that
4400 selected_window always displays the buffer.
c7f53895
DA
4401 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4402 Fix comment.
5c89ca24 4403
f557c1b1
SM
44042013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4405
4406 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4407 the upcase table.
4408
40693bba 44092013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4410
4411 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4412
c86f791f
EZ
44132013-03-27 Eli Zaretskii <eliz@gnu.org>
4414
4415 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4416 since MinGW's w32api headers do. This avoids compiler warnings.
4417
4418 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4419 if already defined.
4420
c6e72e17
EZ
44212013-03-26 Eli Zaretskii <eliz@gnu.org>
4422
4423 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4424
54e95010
JD
44252013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4426
4427 * gtkutil.c (style_changed_cb): Check if frame is live and an
4428 X frame (Bug#14038).
4429
b88b62de
EZ
44302013-03-26 Eli Zaretskii <eliz@gnu.org>
4431
a18d7de6
EZ
4432 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4433 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4434 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4435 MinGW64.
8f5e14c8
EZ
4436 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4437 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4438
b88b62de
EZ
4439 Fix incompatibilities between MinGW.org and MinGW64 headers.
4440 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4441
4442 * w32.c (REPARSE_DATA_BUFFER): Guard with
4443 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4444
c074e458
JD
44452013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4446
4447 * xterm.c: Include X11/XKBlib.h
4448 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4449
908589fd
AS
44502013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4451
4452 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4453 written backwards.
4454 * blockinput.h (input_blocked_p): Likewise.
4455 * bytecode.c (exec_byte_code): Likewise.
4456 * callproc.c (call_process_kill, call_process_cleanup)
4457 (Fcall_process): Likewise.
4458 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4459 (Fccl_execute_on_string): Likewise.
4460 * character.c (string_escape_byte8): Likewise.
4461 * charset.c (read_hex): Likewise.
4462 * cm.c (calccost): Likewise.
4463 * data.c (cons_to_unsigned): Likewise.
4464 * dired.c (directory_files_internal, file_name_completion):
4465 Likewise.
4466 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4467 (sit_for): Likewise.
4468 * doc.c (Fsubstitute_command_keys): Likewise.
4469 * doprnt.c (doprnt): Likewise.
4470 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4471 * emacsgtkfixed.c: Likewise.
4472 * fileio.c (file_offset, Fwrite_region): Likewise.
4473 * floatfns.c (Fexpt, fmod_float): Likewise.
4474 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4475 Likewise.
4476 * font.c (font_intern_prop): Likewise.
4477 * frame.c (x_set_alpha): Likewise.
4478 * gtkutil.c (get_utf8_string): Likewise.
4479 * indent.c (check_display_width): Likewise.
4480 * intervals.c (create_root_interval, rotate_right, rotate_left)
4481 (split_interval_right, split_interval_left)
4482 (adjust_intervals_for_insertion, delete_node)
4483 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4484 (merge_interval_right, merge_interval_left, copy_intervals)
4485 (set_intervals_multibyte_1): Likewise.
4486 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4487 * keymap.c (Fkey_description): Likewise.
4488 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4489 * lread.c (openp, read_integer, read1, string_to_number):
4490 Likewise.
4491 * menu.c (ensure_menu_items): Likewise.
4492 * minibuf.c (read_minibuf_noninteractive): Likewise.
4493 * print.c (printchar, strout): Likewise.
4494 * process.c (create_process, Faccept_process_output)
4495 (wait_reading_process_output, read_process_output, send_process)
4496 (wait_reading_process_output): Likewise.
4497 * profiler.c (make_log, handle_profiler_signal): Likewise.
4498 * regex.c (re_exec): Likewise.
4499 * regex.h: Likewise.
4500 * search.c (looking_at_1, Freplace_match): Likewise.
4501 * sysdep.c (get_child_status, procfs_ttyname)
4502 (procfs_get_total_memory): Likewise.
4503 * systime.h (EMACS_TIME_VALID_P): Likewise.
4504 * term.c (dissociate_if_controlling_tty): Likewise.
4505 * window.c (get_phys_cursor_glyph): Likewise.
4506 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4507 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4508 Likewise.
4509 * xfns.c (Fx_window_property): Likewise.
4510 * xmenu.c (set_frame_menubar): Likewise.
4511 * xselect.c (x_get_window_property, x_handle_dnd_message):
4512 Likewise.
4513 * xsmfns.c (smc_save_yourself_CB): Likewise.
4514 * xterm.c (x_scroll_bar_set_handle): Likewise.
4515
2bf7d27a
DA
45162013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4517
4518 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4519 to be optional or nil. Adjust comment and convert it to docstring.
4520 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4521 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4522
a9ebfa0b
PE
45232013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4524
4525 Static checking by GCC 4.8-20130319.
4526 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4527 * process.c (Fset_process_datagram_address)
4528 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4529 * xdisp.c (get_char_face_and_encoding):
4530 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4531 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4532 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4533
4f3576ee
KB
45342013-03-24 Ken Brown <kbrown@cornell.edu>
4535
789b5e9a
KB
4536 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4537 fix compilation on 64-bit Cygwin, where underscores are not
4538 automatically prepended.
4539
4f3576ee
KB
4540 * w32term.c (w32_initialize): Silence compiler warning.
4541
b5b7745f
EZ
45422013-03-23 Eli Zaretskii <eliz@gnu.org>
4543
cdc0d0bd
EZ
4544 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4545 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4546 variables, to save and restore frame dimensions.
4547 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4548 after returning from a 'fullscreen' configuration.
4549 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4550 to avoid races between the main thread and the input thread.
4551
4552 * w32term.h (struct w32_output): New members normal_width,
4553 normal_height, normal_top, normal_left, and prev_fsmode.
4554 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4555 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4556 members of a frame.
4557
b5b7745f
EZ
4558 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4559 'fullscreen' parameter. Always record previous width and height
4560 of the frame, except when switching out of maximized modes, so
4561 that they could be restored correctly, instead of resetting to the
4562 default frame dimensions. Send SC_RESTORE command to the frame,
4563 unless we are going to send SC_MAXIMIZE, to restore the frame
4564 resize hints in the mouse pointer shown by the window manager.
4565 (Bug#14032)
4566
4567 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4568
4569 * lisp.h (get_frame_param): Adjust conditions for prototype
4570 declaration.
4571
a3454eed
KB
45722013-03-22 Ken Brown <kbrown@cornell.edu>
4573
4574 * unexcw.c: Drop unneeded inclusion of w32common.h.
4575 (report_sheap_usage): Declare.
4576 (read_exe_header): Add magic numbers for x86_64.
4577 (fixup_executable): Fix printf format specifier for unsigned long
4578 argument.
4579
5a49b79c
DA
45802013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4581
4582 * frame.h (struct frame): Put menu_bar_window under #ifdef
4583 because this member is not needed when X toolkit is in use.
4584 (fset_menu_bar_window):
4585 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4586 (free_glyphs, update_frame):
4587 * xdisp.c (expose_frame): Likewise.
4588 (display_menu_bar): Likewise. Remove redundant eassert.
4589 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4590 toolkit is in use.
4591
d6723bf7
PE
45922013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4593
7b1123d8
PE
4594 Use functions and constants to manipulate Lisp_Save_Value objects.
4595 This replaces code that used macros and strings and token-pasting.
4596 The change makes the C source a bit easier to follow,
4597 and shrinks the Emacs executable a bit.
4598 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4599 (make_save_value): Change 1st arg from string to enum. All callers
4600 changed.
4601 (INTX): Remove.
4602 (mark_object): Use if, not #if, for GC_MARK_STACK.
4603 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4604 (XSAVE_OBJECT): Now functions, not macros.
4605 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4606 the constant was never used.
4607 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4608 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4609 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4610 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4611 New constants.
4612 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4613 type3 with a single member save_type. All uses changed.
4614 (save_type, set_save_pointer, set_save_integer): New functions.
4615 * print.c (PRINTX): Remove.
4616
d6723bf7
PE
4617 * alloc.c: Remove redundant static declarations.
4618
5f24fa51
DA
46192013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4620
4621 * window.h (struct window): Convert left_col, top_line, total_lines
4622 and total_cols from Lisp_Objects to integers. Adjust comments.
4623 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4624 Remove.
4625 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4626 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4627 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4628 Adjust users where appropriate.
4629
42143acd
DA
46302013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4631
4632 * frame.h (struct frame): Drop resx and resy because the same data is
4633 available from window system-specific output context. Adjust users.
562c6ee9
SM
4634 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4635 New functions to provide defaults when no window system available.
42143acd 4636 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4637 (NUMVAL): Move from xdisp.c.
42143acd
DA
4638 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4639 (Ffont_face_attributes, Fopen_font):
4640 * image.c (gs_load):
4641 * w32font.c (fill_in_logfont):
4642 * xdisp.c (calc_pixel_width_or_height):
4643 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4644 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4645
c0a17406
KH
46462013-03-20 Kenichi Handa <handa@gnu.org>
4647
4648 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4649 to 1 (temporary workaround until a bug related to ASCII
4650 optimization is fixed).
4651
095d384d
DA
46522013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4653
4654 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4655 Signal error if window is not internal. Adjust docstring.
4656 (delete_all_child_windows): Use combination_limit to save the buffer.
4657 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4658 * print.c (syms_of_print): Initialize debugging output not here...
4659 (init_print_once): ...but in a new function here.
4660 * lisp.h (init_print_once): Add prototype.
4661 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4662
748fa866
DA
46632013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4664
4665 * window.c (window_resize_check, window_resize_apply)
4666 (window_from_coordinates, recombine_windows, set_window_buffer)
4667 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4668 (Fsplit_window_internal, Fdelete_window_internal)
4669 (freeze_window_starts): Use bool for booleans.
4670 * window.h (window_frame_coordinates, resize_frame_windows)
4671 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4672
81519fd2
SM
46732013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4674
4675 * dispnew.c (bitch_at_user): Use `user-error'.
4676
6db423a9
KB
46772013-03-17 Ken Brown <kbrown@cornell.edu>
4678
4679 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4680 as return type of image_background. (Bug#13981)
4681 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4682
8f2906f5
JD
46832013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4684
960ce480 4685 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4686 (ns_select): Don't return with result uninitialized.
960ce480 4687
8f2906f5
JD
4688 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4689 and getDirectory.
4690
81519fd2
SM
4691 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4692 New functions.
8f2906f5
JD
4693 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4694 directories. If filename is nil, get directory name (Bug#13932).
4695 Use getFilename and getDirectory.
4696 (getFilename, getDirectory): New methods for EmacsSavePanel and
4697 EmacsOpenPanel.
4698 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4699
cded56c1
PE
47002013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4701
4702 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4703
251e9147 47042013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4705
4706 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4707 (adjust_after_replace): Make it back to static. Delete the third
4708 arg text_at_gap_tail. Cancel the code for handling it.
4709
4710 * coding.h (struct coding_system): New member eol_seen.
4711
4712 * coding.c (detect_ascii): New function.
4713 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4714 when the source bytes are actually scanned. On detecting for
4715 coding_category_utf_8_auto, call detect_ascii instead of scanning
4716 source bytes directly.
4717 (produce_chars): Call insert_from_gap with the new arg 0.
4718 (encode_coding): Likewise.
4719 (decode_coding_gap): Control ASCII optimization by the variable
4720 disable_ascii_optimization instead of #ifndef .. #endif.
4721 Deccode EOL format according to coding->eol_seen.
4722 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4723 variable.
4724
8a44e6d1
KH
4725 * lisp.h (adjust_after_replace): Cancel externing it.
4726 (insert_from_gap): Adjust prototype.
4727
5f795e34
EZ
47282013-03-15 Eli Zaretskii <eliz@gnu.org>
4729
4730 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4731 FULLSCREEN_MAXIMIZED. (Bug#13935)
4732
f258b4be
DA
47332013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4734
4735 * region-cache.c (find_cache_boundary, move_cache_gap)
4736 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4737 Simplify debugging check and convert to eassert. Adjust comment.
4738 (pp_cache): Put under ENABLE_CHECKING.
4739
a5cc4dde
EZ
47402013-03-14 Eli Zaretskii <eliz@gnu.org>
4741
4742 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4743 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4744 and WM_ACTIVATEAPP.
4745 (w32fullscreen_hook): If the frame is visible, reset
4746 f->want_fullscreen flag after changing the frame size. If the
4747 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4748 (Bug#13953)
4749
3fc5e44a
DC
47502013-03-13 Daniel Colascione <dancol@dancol.org>
4751
4752 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4753 too so that these builds can use Cygwin's file conversion
4754 functions. (We've been building and linking cygw32.o all along
4755 and just not using it.)
4756
47d7532e
PE
47572013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4758
4759 File synchronization fixes (Bug#13944).
4760 * Makefile.in (LIB_FDATASYNC): New macro.
4761 (LIBES): Use it.
4762 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4763 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4764 Don't worry about HAVE_FSYNC, since a substitute fsync is
4765 available if the system lacks one.
4766 (Fwrite_regin): Retry fsync if interrupted.
4767
c7ffccaf
EZ
47682013-03-13 Eli Zaretskii <eliz@gnu.org>
4769
4e2df81d 4770 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4771 activated, call w32fullscreen_hook, to make sure the new frame
4772 dimensions are in effect. (Bug#13937)
4773
8a7debc1
DA
47742013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4775
4776 * xdisp.c (init_iterator): Simplify because both character and byte
4777 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4778 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4779 character and byte positions can be obtained from marker.
8a7debc1 4780
7fd8c501
PE
47812013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4782
d9df6f40
PE
4783 Static checking by Sun C 5.12.
4784 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4785 * bytecode.c (exec_byte_code):
4786 * dispnew.c (init_display):
4787 * eval.c (error):
4788 * fileio.c (Fsubstitute_in_file_name):
4789 * keyboard.c (Fevent_convert_list):
4790 * keymap.c (Fsingle_key_description):
4791 * term.c (maybe_fatal, fatal):
4792 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4793 * xsmfns.c (Fhandle_save_session):
4794 Omit unreachable code.
4795 * keymap.c (map_keymap_char_table_item): Cast void * to
4796 a function pointer type; the C Standard requires this.
4797
7fd8c501
PE
4798 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4799 Include <sys/param.h> unconditionally, as that works elsewhere and
4800 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4801 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4802 and FreeBSD now.
4803
a020afb9 4804See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4805
4806;; Local Variables:
4807;; coding: utf-8
aac0c6e3
MR
4808;; End:
4809
ab422c4d 4810 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4811
4812 This file is part of GNU Emacs.
4813
4814 GNU Emacs is free software: you can redistribute it and/or modify
4815 it under the terms of the GNU General Public License as published by
4816 the Free Software Foundation, either version 3 of the License, or
4817 (at your option) any later version.
4818
4819 GNU Emacs is distributed in the hope that it will be useful,
4820 but WITHOUT ANY WARRANTY; without even the implied warranty of
4821 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4822 GNU General Public License for more details.
4823
4824 You should have received a copy of the GNU General Public License
4825 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.