* data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4710d6f4
PE
12013-09-24 Paul Eggert <eggert@cs.ucla.edu>
2
3 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
4 This is ugly, but it should fix the performance problem for older
5 GCC versions in the short run. I'll look into integrating the
6 Gnulib module for popcount, as a better fix.
7 See the thread starting in:
8 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
9 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
10 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
11 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
12 (popcount_size_t): Use it.
13
10ebac9d
DC
142013-09-24 Daniel Colascione <dancol@dancol.org>
15
16 * process.c (Fnetwork_interface_info): Fix build break due to
17 vector changes.
18
9da0f50e
PE
192013-09-24 Paul Eggert <eggert@cs.ucla.edu>
20
21 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
22 Prefer signed to unsigned integers where either will do.
23 No need for 'const' on locals that do not escape.
24 Omit easserts with unnecessary and unportable assumptions about
25 alignment. Avoid unnecessary casts to char *.
26
d6d9cbc1
DA
272013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
28
29 Use union for the payload of struct Lisp_Vector.
30 This helps to avoid a few glitches dictated by C's aliasing rules.
31 * lisp.h (struct Lisp_Vector): Use union for next and
32 contents member. Adjust comment. Change related users.
33 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
34 Related users changed.
35 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
36 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
37 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
38 * xfaces.c, xfont.c, xmenu.c: Related users changed.
39
ec7bc82f
DA
402013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
41
42 Optimize glyph row clearing and copying routines.
43 * dispextern.h (struct glyph_row): Change layout of struct
44 glyph_row to help copy_row_except_pointers. Adjust comment.
45 * dispnew.c (null_row): Remove.
46 (clear_glyph_row): Use offsetof and memset to find and clear
47 just the members that need clearing. Adjust comment.
48 (copy_row_except_pointers): Likewise for copying.
49
d160dd0c
PE
502013-09-24 Paul Eggert <eggert@cs.ucla.edu>
51
7be68de5
PE
52 Some minor cleanups of recently-added bool vector code.
53 * conf_post.h (assume): Always return void. Use lint version
54 only if GCC and MSC versions don't apply.
55 * conf_post.h (assume):
56 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
57 Depend on _MSC_VER, not __MSC_VER, for consistency with
58 the rest of Emacs.
59 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
60 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
61 (bool_vector_binop_driver, count_trailing_zero_bits)
62 (size_t_to_host_endian): Now static, not static inline;
63 the latter isn't needed with modern compilers and doesn't
64 work with older compilers anyway.
65
d160dd0c
PE
66 * alloc.c (valgrind_p): Use bool for boolean.
67
e08813d0
DA
682013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
69
70 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
71 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
72 (display_last_displayed_message_p, message_buf_print)
73 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
74 Use bool for boolean.
3a6a78fd
DA
75 * dispextern.h (cancel_line, init_desired_glyphs):
76 Remove ancient leftover.
77 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
78 * lisp.h (noninteractive_need_newline): Adjust declaration.
79
5492865b
DA
802013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
81
82 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
83 Move to...
84 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
85 ...this file and convert the latter to static. Adjust comment.
86 (make_initial_frame):
87 * window.c (init_window_once): Adjust user.
88 * frame.h (last_nonminibuf_frame): Remove declaration.
89 * lisp.h (selected_frame): Likewise.
90 * msdos.c (the_only_display_info): Adjust comment.
91
cd548fa4
EZ
922013-09-23 Eli Zaretskii <eliz@gnu.org>
93
f03eddbf
EZ
94 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
95 computing the end column of mouse-highlight that comes from
96 display or overlay strings. (Bug#15437)
b519df23
EZ
97 (note_mouse_highlight): Adapt calculation of last argument to
98 mouse_face_from_string_pos to the above change.
f03eddbf 99
cd548fa4
EZ
100 * conf_post.h (__has_builtin): Define to zero, if undefined, on
101 all platforms, not just for clang.
102
8762e524
JD
1032013-09-23 Jan Djärv <jan.h.d@swipnet.se>
104
105 * filelock.c (lock_file_1): Rearrange to remove compiler warning
106 about excess arguments to snprintf.
107
108 * conf_post.h(assume): Use __builtin_unreachable for clang.
109
d4a9284f
JB
1102013-09-23 Juanma Barranquero <lekktu@gmail.com>
111
112 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
113 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
114
a84683fd
DC
1152013-09-23 Daniel Colascione <dancol@dancol.org>
116
117 * alloc.c (USE_VALGRIND): New macro; on by default
118 when ENABLE_CHECKING.
119 (mark_maybe_object,mark_maybe_pointer)
120 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
121 valgrind purposes.
122 (valgrind_p) [USE_VALGRIND]: New variable.
123 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
124
8fef36c6
JD
1252013-09-22 Jan Djärv <jan.h.d@swipnet.se>
126
fb83ea63
JD
127 * process.c (wait_reading_process_output): Change int pnamelen to
128 socklen_t.
129
130 * nsterm.m (setMarkedText:selectedRange:):
131 (deleteWorkingText):
132 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
133 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
134 argument to unsigned long to avoid warning.
135 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
136
8fef36c6
JD
137 * conf_post.h (assume): Fix compiler error: x shall be cond.
138
cd9356f2
DC
1392013-09-22 Daniel Colascione <dancol@dancol.org>
140
141 * xfns.c (x_get_monitor_attributes): Suppress unused variable
142 warning when compiling without a window system.
143
3e0b94e7
DC
1442013-09-22 Daniel Colascione <dancol@dancol.org>
145
146 * data.c (Qbool_vector_p): New symbol.
147 (bool_vector_spare_mask,popcount_size_t_generic)
148 (popcount_size_t_msc,popcount_size_t_gcc)
149 (popcount_size_t)
150 (bool_vector_binop_driver)
151 (count_trailing_zero_bits,size_t_to_host_endian)
152 (Fbool_vector_exclusive_or)
153 (Fbool_vector_union)
154 (Fbool_vector_intersection,Fbool_vector_set_difference)
155 (Fbool_vector_subsetp,Fbool_vector_not)
156 (Fbool_vector_count_matches)
157 (Fbool_vector_count_matches_at): New functions.
158 (syms_of_data): Intern new symbol, functions.
159 * alloc.c (bool_vector_payload_bytes): New function.
160 (Fmake_bool_vector): Instead of calling Fmake_vector,
161 which performs redundant initialization and argument checking,
162 just call allocate_vector ourselves. Make sure we clear any
163 terminating padding to zero.
164 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
165 instead of open-coding the size calculation.
166 (vroundup_ct): New macro.
167 (vroundup): Assume argument >= 0; invoke vroundup_ct.
168 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
169 * composite.c (composition_gstring_put_cache): Change
170 lint_assume to assume.
171 * conf_post.h (assume): New macro.
172 (lint_assume): Remove.
173 * dispnew.c (update_frame_1): Change lint_assume to assume.
174 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
175 to assume.
176 * image.c (gif_load): Change lint_assume to assume.
177 * lisp.h (eassert_and_assume): New macro.
178 (Qbool_vector_p): Declare.
179 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
180 (swap16,swap32,swap64): New inline functions.
181 * macfont.c (macfont_shape): Change lint_assume to assume.
182 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
183 * xsettings.c (parse_settings): Use new swap16 and
184 swap32 from lisp.h instead of file-specific macros.
185
76880d88
EZ
1862013-09-22 Eli Zaretskii <eliz@gnu.org>
187
188 * xdisp.c (try_window_id): Don't abort if cursor row could not be
189 found (which can legitimately happen when the glyph row at the
190 window start is disabled in the current_matrix. (Bug#15365)
191
c6cfd910
PE
1922013-09-22 Paul Eggert <eggert@cs.ucla.edu>
193
194 Fix syntax.h bug introduced by recent INLINE change.
195 syntax.h defined an extern inline function SYNTAX_ENTRY that was
196 conditionally compiled one way in some modules, and a different
197 way in others. This doesn't work with extern inline functions,
198 which must have the same definition in all modules, because the
199 defining code might be shared across modules, depending on the
200 implementation. Symptoms reported by Martin Rudalics in:
201 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
202 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
203 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
204 overriding the corresponding functions in syntax.h.
205 * syntax.h (syntax_property_entry, syntax_property_with_flags)
206 (syntax_property): New inline functions.
207 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
208 Rewrite in terms of these new functions.
209
b3f1d119
EZ
2102013-09-21 Eli Zaretskii <eliz@gnu.org>
211
212 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
213 not chars_in_text, whose result depends on the multibyteness of
214 the current buffer. (Bug#15426)
215
00382e8b
PE
2162013-09-20 Paul Eggert <eggert@cs.ucla.edu>
217
e3b29769
PE
218 Port recent change to hosts where pointers aren't 'long'.
219 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
220 Don't assume that pointers are the same width as 'long'.
221 Add a compile-time check that a pointer fits into two X slots.
222
00382e8b
PE
223 A simpler, centralized INLINE.
224 * conf_post.h (INLINE): Define only if not already defined.
225 This allows us to use a single INLINE, defined by one file
226 per executable.
227 * emacs.c (INLINE): Define it.
228 Also, include category.h, charset.h, composite.h, dispextern.h,
229 syntax.h, systime.h, so that their INLINE definitions are expanded
230 properly for Emacs.
231 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
232 * buffer.h, buffer.c (BUFFER_INLINE):
233 * category.h, category.c (CATEGORY_INLINE):
234 * character.h, character.c (CHARACTER_INLINE):
235 * charset.h, charset.c (CHARSET_INLINE):
236 * composite.h, composite.c (COMPOSITE_INLINE):
237 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
238 * frame.h, frame.c (FRAME_INLINE):
239 * intervals.h, intervals.c (INTERVALS_INLINE):
240 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
241 * lisp.h, alloc.c (LISP_INLINE):
242 * process.h, process.c (PROCESS_INLINE):
243 * syntax.h, syntax.c (SYNTAX_INLINE):
244 * systime.h, sysdep.c (SYSTIME_INLINE):
245 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
246 * window.h, window.c (WINDOW_INLINE):
247 Remove. All uses replaced with INLINE.
248
2b943ba6
DA
2492013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
250
251 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
252 to avoid Bug#15398.
253
13d9698a
EZ
2542013-09-19 Eli Zaretskii <eliz@gnu.org>
255
256 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
257 'const char *' to avoid compiler warnings due to similar change in
258 the prototype of x_get_string_resource.
259
ced135eb
DA
2602013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
261
262 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
263 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
264 going to replace static variables below. Adjust comments.
265 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
266 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
267 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
268 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
269 Related users changed.
270 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
271 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
272 last_mouse_movement_time, going to replace static variables below.
273 Adjust comments.
274 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
275 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
276 Remove.
277 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
278 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
279 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
280 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
281 static variables below.
282 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
283 (last_mouse_scroll_bar): Remove.
284 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
285 (mouseExited): Related users changed.
286
091f1e1f
DA
2872013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Do not use external array to process X scroll bar messages.
290 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
291 (x_send_scroll_bar_event): Pack window pointer into two slots
292 of XClientMessageEvent if we're 64-bit. Adjust comment.
293 (x_scroll_bar_to_input_event): Unpack accordingly.
294
582ed56c
DA
2952013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
296
297 Ifdef away recent changes which aren't relevant to NS port.
298 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
299 [!HAVE_NS]: Declare as such.
300 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
301 [!HAVE_NS]: Define as such.
302
18da0d8a
DA
3032013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
304
305 * frame.c (x_redo_mouse_highlight): New function
306 to factor out common code used in W32 and X ports.
307 * dispextern.h (x_redo_mouse_highlight): Add prototype.
308 * xterm.h (struct x_display_info):
309 * w32term.h (struct w32_display_info):
310 * nsterm.h (struct ns_display_info): New members
311 last_mouse_motion_frame, last_mouse_motion_x and
312 last_mouse_motion_y, going to replace static variables below.
313 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
314 (redo_mouse_highlight): Remove.
315 (note_mouse_movement, syms_of_xterm): Adjust user.
316 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
317 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
318 (redo_mouse_highlight): Remove.
319 (note_mouse_movement, syms_of_w32term): Adjust user.
320 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
321 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
322 Remove.
323 (note_mouse_movement, mouseMoved, syms_of_nsterm):
324 * nsfns.m (compute_tip_xy): Adjust user.
325
7a0c745a
DA
3262013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
327
328 * frame.c (x_mouse_grabbed): New function.
329 * dispextern.h (x_mouse_grabbed): Add prototype.
330 (last_mouse_frame): Remove declaration.
331 * xterm.h (struct x_display_info):
332 * w32term.h (struct w32_display_info):
333 * nsterm.h (struct ns_display_info): New member
334 last_mouse_frame, going to replace...
335 * xdisp.c (last_mouse_frame): ...global variable.
336 (note_tool_bar_highlight):
337 * w32term.c (w32_mouse_position, w32_read_socket):
338 * xterm.c (XTmouse_position, handle_one_xevent):
339 Use x_mouse_grabbed.
340 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
341
0791d107
DA
3422013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
343
344 * w32term.c (w32_read_socket): Avoid temporary
345 variables in a call to x_real_positions.
346 * xterm.c (handle_one_xevent): Likewise.
347
2cd98812
DA
3482013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
349
350 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
351 (x_icon_type): Remove prototype.
352 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
353 * frame.c (x_icon_type): Remove.
354 * w32term.c (x_make_frame_visible, x_iconify_frame):
355 * xterm.c (x_make_frame_visible, x_iconify_frame):
356 Use x_set_bitmap_icon to factor out common code.
357
a6c2ee1b
DA
3582013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
359
360 * dispextern.h (check_x_display_info, x_get_string_resource):
361 Declare here just once and unify the latter.
362 * frame.c (check_x_display_info, x_get_string_resource):
363 * nsterm.h (check_x_display_info):
364 * xrdb.c (x_get_string_resource):
365 * xterm.h (check_x_display_info): Remove prototypes.
366 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
367 * w32reg.c (x_get_string_resource): Likewise.
368 (w32_get_rdb_resource): Adjust user.
369
baed3603
DA
3702013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
371
372 * xterm.h (struct x_display_info): New member
373 x_pending_autoraise_frame, going to replace...
374 * xterm.c (pending_autoraise_frame): ...static variable.
375 (x_new_focus_frame, XTread_socket): Adjust users.
376 * w32term.h (struct w32_display_info): New member
377 w32_pending_autoraise_frame, going to replace...
378 * w32term.c (pending_autoraise_frame): ...global variable.
379 (x_new_focus_frame, w32_read_socket): Adjust users.
380
90582f05
GM
3812013-09-17 Glenn Morris <rgm@gnu.org>
382
383 * xdisp.c (message_dolog): If we create *Messages*,
384 switch it to messages-buffer-mode.
385
b7ad2f74
PE
3862013-09-17 Paul Eggert <eggert@cs.ucla.edu>
387
388 Don't overuse 'const' in types of locals.
389 * bidi.c (bidi_count_bytes):
390 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
391 (xg_event_is_for_scrollbar):
392 * xselect.c (x_handle_property_notify)
393 (x_handle_selection_notify, x_handle_dnd_message):
394 * xsettings.c, xsettings.h (xft_settings_event):
395 * xterm.c (x_handle_net_wm_state, handle_one_event)
396 (x_menubar_window_to_frame, x_detect_focus_change)
397 (construct_mouse_click, note_mouse_movement)
398 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
399 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
400 (handle_one_xevent, x_handle_net_wm_state):
401 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
402 (x_handle_dnd_message):
403 Avoid unnecessary 'const', typically the second 'const' in
404 'const foo * const arg', a 'const' that does not affect the API
405 and doesn't significantly help the human reader.
406
19452b86
DA
4072013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
408
409 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
410 only if Glib < 2.36.0.
411 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
412 * xsettings.c (init_gconf, init_gsettings): Do not check
413 for g_type_init.
1893694e
DA
414 * xterm.c (handle_one_xevent): Do not call to x_clear_area
415 if GTK >= 2.7.0.
33b83dd7 416 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 417
6434e343
JD
4182013-09-16 Jan Djärv <jan.h.d@swipnet.se>
419
3f386383
JD
420 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
421 before calling g_type_init.
422
6434e343
JD
423 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
424
425 * nsterm.m (syms_of_nsterm): ... to here.
426
83a119f8
DA
4272013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
428
429 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
430 (ignore_next_mouse_click_timeout): Use Time as X does.
431 (handle_one_xevent): Avoid cast and use unsigned comparison.
432
61582e6a
DA
4332013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
434
435 Do not copy X event in handle_one_xevent except KeyPress case.
436 Wnen XEvent is processed, it is unlikely to be changed except
437 KeyPress case, so we can avoid copying and use const pointer to
438 const data to make sure that an event is not changed elsewhere.
439 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
440 const' and do not create local copy except for the KeyPress event.
441 Use casts to avoid a few glitches. Adjust formatting. Add comments.
442 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
443 (x_handle_net_wm_state, x_menubar_window_to_frame)
444 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
445 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
446 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
447 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
448 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
449 (x_handle_dnd_message):
450 * xsettings.c (xft_settings_event):
451 Use 'const XEvent * const' where appropriate.
452 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
453
f8eb1572
DA
4542013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
455
456 Fix X event waiting to handle multiple frames.
457 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
458 * xterm.c (pending_event_wait): Remove. Adjust users.
459 (x_detect_focus_change): Pass frame arg.
460 (handle_one_xevent): Find related frame early and clear per-frame
461 wait_event_type only if this is an event for the relevant frame.
462 (x_wait_for_event): Use per-frame wait_event_type.
463
3fa2054e
JD
4642013-09-15 Jan Djärv <jan.h.d@swipnet.se>
465
745d3809
JD
466 * nsfns.m (Fx_create_frame): Fix font driver registration for
467 GNUStep.
468
469 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
470 for syms_of_macfont.
471
3fa2054e
JD
472 * nsterm.m: Include macfont.h.
473 (ns_tmp_flags, ns_tmp_font): Remove.
474 (ns_compute_glyph_string_overhangs): Check for driver Qns.
475 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
476 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
477 (changeFont:): Fix code style. Check for font driver type when
478 getiing font.
479
480 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
481 (f)->descent.
482
483 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
484 (nsfont_open): Set font driver type.
485 Set font->ascent and font->descent. Figure out font instead of
486 ns_tmp_font, and flags instead of ns_tmp_flags.
487 Fix indentation. Remove call to ns_draw_text_decoration,
488 moved to nsterm.
489
490 * nsfns.m: Include macfont.h.
491 (Fx_create_frame): Register macfont driver, make a better default font.
492 (Fns_popup_font_panel): Get font from macfont driver, if used.
493
494 * macfont.m, macfont.h, maccuvs.h: New files.
495
496 * font.h: Declare syms_of_macfont.
497
498 * font.c (syms_of_font): Call syms_of_macfont.
499
500 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
501
0eed0355
DA
5022013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
503
504 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
505 and it is always zero for others, so I assume that this is an ancient
506 leftover which nobody will want to change any more.
507 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
508 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
509 * frame.c (x_set_scroll_bar_width):
510 * w32fns.c (w32_createscrollbar):
511 * w32term.c (w32_set_vertical_scroll_bar):
512 * xfns.c (x_set_scroll_bar_default_width):
513 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
514 (x_scroll_bar_expose): Related users changed.
515
07013c68
DA
5162013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
517
518 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
519 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
520 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
521 Define as such.
c7cc32f7
DA
522 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
523 Define once here...
524 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
525 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
526 Remove unused Xisms.
7f09455e
DA
527 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
528 these modules are never compiled otherwise.
07013c68 529
0df00f59
EZ
5302013-09-14 Eli Zaretskii <eliz@gnu.org>
531
08a209bf 532 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
533 Doc fix. (Bug#15375)
534
fcd42c11
DA
5352013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
536
537 Unify Fx_focus_frame between all ports.
538 * frame.h (x_focus_frame): New prototype.
539 * xfns.c (Fx_focus_frame): Remove.
540 (syms_of_xfns): Do not defsubr it.
541 (x_focus_frame): X implementation.
542 * nsfns.m (Fx_focus_frame): Remove.
543 (syms_of_nsfns): Do not defsubr it.
544 (x_focus_frame): NS implementation.
545 * w32term.c (Fx_focus_frame): Remove.
546 (x_focus_on_frame): Rename to...
547 (x_focus_frame): W32 implementation.
548 * w32term.h (x_focus_on_frame): Remove prototype.
549 * w32fns.c (Fx_focus_frame): Remove.
550 (syms_of_w32fns): Do not defsubr it.
551 * frame.c (Fx_focus_frame): Define here.
552 (syms_of_frame): Defsubr here.
553 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
554
aad3612f
DA
5552013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
556
557 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
558 All of them are replaced with FRAME_DISPLAY_INFO, defined in
559 each port to reference the port-specific window system data.
560 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
561 (FRAME_DISPLAY_INFO): Define.
562 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
563 (FRAME_DISPLAY_INFO): Define. Adjust users.
564 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
565 (FRAME_DISPLAY_INFO): Define. Adjust users.
566 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
567 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
568 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
569 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
570 * xselect.c, xterm.c: All related users changed.
571
9a650e62
DA
5722013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
573
574 * xterm.h (x_window_to_frame, x_any_window_to_frame)
575 (x_menubar_window_to_frame): Remove prototypes.
576 * xfns.c (x_window_to_frame, x_any_window_to_frame)
577 (x_menubar_window_to_frame, x_top_window_to_frame):
578 Move from here...
579 * xterm.c (x_window_to_frame, x_any_window_to_frame)
580 (x_menubar_window_to_frame, x_top_window_to_frame):
581 ...to here and convert all but the last to static.
582
347ae3e1
EZ
5832013-09-12 Eli Zaretskii <eliz@gnu.org>
584
585 * lisp.mk (lisp): Add w32-common-fns.elc.
586
15c6d837
XF
5872013-09-12 Xue Fuqiao <xfq.free@gmail.com>
588
589 * charset.c (char_charset): Document an exception for char-charset.
590
27e90f77
DA
5912013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
592
593 * xterm.h (x_display_info): New field last_user_time...
594 * xterm.c (toplevel): ...to replace static last_user_time.
595 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
596
8ffbc36b
DA
5972013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
598
599 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
600 scroll bar values to prevent thumb from disappear and update comment.
601
5ec0337a
GM
6022013-09-11 Glenn Morris <rgm@gnu.org>
603
604 * emacs.c (usage_message): Possessive apostrophe tweak.
605
fb55b9d1
DA
6062013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
607
8d2db8be
DA
608 * nsterm.m (syms_of_nsterm): Use Qns.
609 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
610 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
611 * xfns.c (x_display_info_for_name, Fx_open_connection):
612 Remove old '#if 0' code.
613 (syms_of_xfns): Use Qx.
fb55b9d1
DA
614 * termhooks.h (fullscreen_hook): Remove the leftover.
615 (struct terminal): Fix typo in comment.
616
927eec55
DA
6172013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
618
619 Cleaning up a few X scroll bar bits.
620 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
621 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
622 New member last_seen_part, going to replace...
623 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
624 (xt_action_hook) [USE_LUCID]: Adjust user.
625 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
626 Lucid-specific scroll bar support.
627 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
628 to int and adjust to use last_seen_part member.
629 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
630 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
631 Initialize last_seen_part.
632
71b28baa
SM
6332013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
634
635 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
636 insert-buffer-substring an empty string.
637
f5dacaae
PE
6382013-09-11 Paul Eggert <eggert@cs.ucla.edu>
639
640 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
641 avoiding a GCC warning.
642
742516e0
DA
6432013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
644
645 Ifdef away frame tool bar code when it is not really used.
646 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
647 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
648 and minimize_tool_bar_window_p under the above.
649 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
650 (fset_tool_bar_window): Likewise.
651 * dispnew.c (clear_current_matrices, clear_desired_matrices)
652 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
653 (change_frame_size_1):
654 * window.c (window_from_coordinates, Frecenter): Adjust users.
655 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
656 code is not really used.
657 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
658 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
659 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
660 [!USE_GTK && !HAVE_NS]: Define as such.
661 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
662 (note_mouse_highlight, expose_frame):
663 * xfns.c (x_set_tool_bar_lines):
664 * xterm.c (handle_one_xevent): Adjust users.
665
73f82c7e
PE
6662013-09-11 Paul Eggert <eggert@cs.ucla.edu>
667
668 Fix corruption with multiple emacsclient -t instances (Bug#15222).
669 This bug was introduced by my 2013-08-26 patch, which incorrectly
670 assumed that the terminfo implementation doesn't use termcap buffers.
671 * term.c (init_tty) [TERMINFO]: Remove optimization, as
672 these buffers apparently are used after all.
673 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
674 (struct tty_display_info): Define members termcap_term_buffer and
675 termcap_strings_buffer even if TERMINFO.
676
53482f41
DA
6772013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Fix last change.
680 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
681 'usage' docstring entry to pacify make-docfile.
682
6832013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
684
685 Change comparison functions =, <, >, <=, >= to take many arguments.
686 * data.c: Change comparison functions' interface and implementation.
687 * lisp.h: Make arithcompare available for efficient two arg
688 comparisons.
689 * bytecode.c: Use arithcompare.
690 * fileio.c: Use new interface.
691
533f258f
SM
6922013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
695
8c27f5ff
SM
6962013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
697
698 * eval.c (Feval): Document the new use of `lexical'.
699
0750a308
DA
7002013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
701
702 Review and drop old frame resize hack.
703 * frame.h (struct frame): Remove force_flush_display_p.
704 * dispnew.c (update_frame): Adjust user and don't call
705 flush_frame here. The comment has said that there was an issues
706 with redisplaying fringes, but I don't see any differences with
707 and without this hack. Hopefully we can continue without it.
708 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
709 current frame matrices twice if resized_p is set.
710
83fc0554
DA
7112013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
712
713 Do not populate pure Xism x_sync to other ports.
714 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
715 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
716 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
717 * w32term.h (x_sync): Remove prototype.
718
fd462129
DA
7192013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
720
721 Cleanup frame flushing.
8c27f5ff
SM
722 * dispextern.h (struct redisplay_interface):
723 Drop flush_display_optional because flush_display is enough
fd462129
DA
724 for X and flushing via RIF is just a no-op for others.
725 * frame.h (flush_frame): New function.
726 * dispnew.c (update_frame):
727 * minibuf.c (read_minibuf):
728 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
729 Use it.
730 * keyboard.c (detect_input_pending_run_timers): Do not flush
731 all frames but selected one in redisplay_preserve_echo_area.
732 * nsterm.m (ns_flush): Remove no-op.
733 (ns_redisplay_interface): Adjust user.
734 * w32term.h (x_flush): Remove no-op.
735 (w32_redisplay_interface): Adjust user.
736 * xterm.c (x_flush): Simplify because we do not flush all
737 frames at once any more. Adjust comment.
738 (x_redisplay_interface): Adjust user.
739
4b73fc73
PE
7402013-09-07 Paul Eggert <eggert@cs.ucla.edu>
741
742 Port --without-x --enable-gcc-warnings to Fedora 19.
743 * gfilenotify.c (globals_of_gfilenotify):
744 Call g_type_init only if using an older glib version that needs it.
745
77394d40
DA
7462013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
747
748 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
749 (last_glyphless_glyph_merged_face_id): Remove declarations.
750 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
751 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
752 (last_glyphless_glyph_merged_face_id): Now static.
753 (merge_escape_glyph_face): New function, refactored from...
754 (get_next_display_element): ...here.
755 (merge_glyphless_glyph_face): New function, refactored from...
756 (produce_glyphless_glyph): ...here...
757 * term.c (produce_glyphless_glyph): ...and here.
758
306d67bd
SM
7592013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
760
761 * eval.c (eval_sub): Only call Ffunction if necessary.
762
7f6c6450
DA
7632013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
764
765 Attempt to make redisplay more selective when changing cursor type.
766 * frame.h (struct frame): New bitfield cursor_type_changed.
767 * xdisp.c (cursor_type_changed): Remove.
768 (try_cursor_movement, redisplay_window, try_window_id)
769 (set_frame_cursor_types, try_window_reusing_current_matrix):
770 Adjust to use per-frame bitfield.
771 (redisplay_internal): Look for cursor type change on each visible
772 frame and consider all frames if cursor type has been changed on
773 the frame other than selected. If cursor type has been changed on
774 selected frame only, do not use fast update.
775
bd0443bb
DA
7762013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
777
778 Attempt to make redisplay more selective when changing fonts.
779 * frame.h (struct frame): New bitfield fonts_changed.
780 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
781 (adjust_frame_glyphs): Add prototype.
782 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 783 (adjust_glyphs): Remove because we do not
bd0443bb
DA
784 adjust matrices on all frames at once any more.
785 (adjust_frame_glyphs): Block and unblock input here.
786 (adjust_glyph_matrix): Use fonts_changed.
787 (change_frame_size_1): Use adjust_frame_glyphs.
788 * font.c (font_open_entity): Use fonts_changed.
789 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
790 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
791 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
792 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
793 (shrink_mini_window, Fresize_mini_window_internal)
794 (window_scroll_pixel_based, Fset_window_configuration)
795 (apply_window_adjustment, Fset_window_vscroll):
796 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
797 Use adjust_frame_glyphs.
798 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
799 (try_window_reusing_current_matrix, try_window_id, display_line)
800 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
801 (redisplay_internal): Consider fonts_changed and adjust frame
802 matrices for each frame only if the frame is visible. If font
803 has been changed on some frame during full redisplay, retry
804 only visible frames where the font has been actually changed.
805
b9695828
DA
8062013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
807
808 Cache current header and mode line height for each window.
809 * window.h (struct window): New fields mode_line_height
810 and header_line_height.
811 * window.c (make_window): Initialize them.
812 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
813 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
814 (current_mode_line_height, current_header_line_height):
815 Remove declaration.
816 * xdisp.c (current_mode_line_height, current_header_line_height):
817 Remove.
818 (pos_visible_p, init_xdisp): Adjust user.
819 (redisplay_window): Invalidate mode_line_height and
820 header_line_height if current and desired matrices do not agree.
821
66738305
DA
8222013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
823
824 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
825 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
826
257b3b03
DA
8272013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
828
829 Make --without-x compatible with --enable-gcc-warnings.
830 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
831 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
832 members under HAVE_WINDOW_SYSTEM.
833 * keyboard.c (make_lispy_focus_out): Likewise.
834 (record_menu_key): Move under HAVE_MENUS.
835 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
836 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
837 (syms_of_xdisp): Adjust user.
838 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
839 (start_hourglass, cancel_hourglass):
840 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
841 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
842 and CLEAR_FONT_TABLE_NFONTS.
843 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
844 Declare only if HAVE_WINDOW_SYSTEM.
845 (lface_same_font_attributes_p, clear_face_gcs): Define only
846 if HAVE_WINDOW_SYSTEM.
847
98b7f4bd
DA
8482013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
849
850 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
851 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
852 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
853
a7e43722
SM
8542013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
857
0c90b9ee
PE
8582013-09-04 Paul Eggert <eggert@cs.ucla.edu>
859
860 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
861 This fixes a type error on hosts where ptrdiff_t is wider than int.
862
d99760fa
SM
8632013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
864
6629638e
SM
865 * keyboard.c (read_key_sequence_vs): New function.
866 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
867 common code.
868
d99760fa
SM
869 * callint.c (Fcall_interactively): Always return a vector for 'K'.
870
224e313d
PE
8712013-09-04 Paul Eggert <eggert@cs.ucla.edu>
872
873 Makefile improvements.
874 * Makefile.in (config.status): Don't use double-colon rules, as
875 they are not portable according to POSIX. Fix shell typo with `;
876 I guess this rule has never been tested?
877 (VCSWITNESS): New macro, to override any environment var.
878
6d6ed1af
DA
8792013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
880
881 * xterm.h (struct x_display_info): Do not track X connection
882 fd separately because it is always available from Display.
883 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
884 Adjust users.
885
bc923770
DA
8862013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
887
888 * buffer.c (drop_overlay):
889 * fileio.c (restore_point_unwind): Prefer unchain_marker to
890 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
891
b1cf96de
DA
8922013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
893
894 * buffer.c (Fmake_overlay, Fmove_overlay):
895 * intervals.c (set_point_from_marker):
896 * print.c (PRINTPREPARE): Prefer signal_error
897 to plain error and report unsuitable marker too.
898
d1fc6c21
DA
8992013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
900
901 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
902 for 'dragging' member.
d1ae6a0b
DA
903 (struct x_output): Remove set-but-unused leftovers
904 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
905 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
906 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
907 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
908 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
909 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
910 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 911 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 912 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 913
0ce9f6de
JD
9142013-09-03 Jan Djärv <jan.h.d@swipnet.se>
915
916 * nsfont.m (INVALID_GLYPH): New define.
917 (nsfont_encode_char): Use INVALID_GLYPH.
918 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
919
b594a96c
DA
9202013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
921
922 * xterm.c (x_last_mouse_movement_time): Revert last change.
923 This code should use XDisplayMotionBufferSize to check display's
924 motion history first, and there are few other issues as well.
925 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
926 (handle_one_xevent): Adjust user.
927
8b098236
MR
9282013-09-02 Martin Rudalics <rudalics@gmx.at>
929
9718b207
MR
930 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
931 * frame.c (Flast_nonminibuf_frame): ... to here.
932 (check_minibuf_window): Don't abort if no window was found
933 (Bug#15247).
8b098236 934
84e70bba
DA
9352013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Use XGetMotionEvents to ask the last mouse motion time from X server.
938 * xterm.c (X_MOTION_HISTORY): Default to 1.
939 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
940 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
941 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
942 Ifdef away legacy code.
943 (XTmouse_position, x_scroll_bar_report_motion):
944 Use x_last_mouse_movement_time.
fc85e20b
DA
945 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
946 UnmapNotify event.
84e70bba 947
1fccc530
DA
9482013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
949
950 * msdos.c (last_mouse_window): Move to...
951 (dos_rawgetc): ...this function and adjust comment.
952 * nsterm.m (last_window): Rename to last_mouse_window, move to...
953 (mouseMoved): ...this function and adjust comment.
954 * w32term.c (last_window): Likewise with...
955 (w32_read_socket): ...this function.
956 * xterm.c (last_window): Likewise with...
957 (handle_one_xevent): ...this function.
958
0ab10992
DA
9592013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
960
b7da754d 961 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
962 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
963 (handle_one_xevent): ...to here.
964 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
965 otherwise.
966
0c7f856e
DA
9672013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
968
969 * msdos.c (IT_set_terminal_window): Remove no-op.
970 (initialize_msdos_display): Adjust terminal setup.
971 * w32console.c (w32con_set_terminal_window): Remove no-op.
972 (initialize_w32_display): Adjust terminal setup.
973 * w32term.c (w32_set_terminal_window): Remove no-op.
974 (w32_create_terminal): Adjust terminal setup.
975 * xterm.c (XTset_terminal_window): Remove no-op.
976 (x_create_terminal): Adjust terminal setup.
977
a892a94c
DA
9782013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
979
980 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
981 Remove no-ops.
982 (ns_create_terminal): Adjust terminal setup.
983 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
984 Remove no-ops.
985 (w32_create_terminal): Adjust terminal setup.
986 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
987 Remove no-ops.
988 (x_create_terminal): Adjust terminal setup.
989
cf91889a
DA
9902013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
991
992 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
993 (CLIP_TEXT_POS_FROM_MARKER): New macro.
994 * dispnew.c (buffer_posn_from_coords):
995 * window.c (Fwindow_end, displayed_window_lines):
996 * xdisp.c (redisplay_mode_lines): Use it.
997
5b0891df
JD
9982013-09-01 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * fontset.c (face_for_char): Check char in the current face font first
1001 if HAVE_NS (Bug#15138).
1002
0a357e98
MR
10032013-08-31 Martin Rudalics <rudalics@gmx.at>
1004
1005 * window.c (temp_output_buffer_show): Make sure window returned
1006 by display_buffer is live (Bug#15213).
1007
9d7693d7
DA
10082013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1009
1010 Minor cleanup to avoid forward declarations.
1011 * coding.h (struct ccl_spec): Remove forward declaration.
1012 * composite.h (toplevel): Include font.h.
1013 (struct composition_it, struct face, struct font_metrics):
1014 Remove forward declaration.
1015 * dispextern.h (struct image, struct atimer): Likewise.
1016 * emacsgtkfixed.h (struct frame): Likewise.
1017 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1018 * font.h (struct font_driver, struct font, struct glyph_string)
1019 (struct face): Remove forward declaration.
1020 * fontset.h (struct face, struct font): Likewise.
1021 * frame.h (toplevel): Style cleanup.
1022 (enum output_method): Move to...
1023 * termhooks.h (enum output_method): ...here.
1024 (struct glyph, struct frame, struct ns_display_info)
1025 (struct x_display_info, struct w32_display_info):
1026 Remove forward declaration.
1027 * xterm.h (toplevel): Include termhooks.h.
1028 (struct font, struct window, struct glyph_matrix, struct frame)
1029 (struct input_event, struct face, struct image): Remove forward
1030 declaration.
1031 * gtkutil.h (struct _widget_value): Likewise.
1032 * keyboard.h (toplevel): Include termhooks.h.
1033 (struct input_event): Remove forward declaration.
1034
032f7451
DA
10352013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1036
1037 * intervals.c (set_point_from_marker): New function.
1038 * editfns.c (Fgoto_char):
1039 * process.c (Finternal_default_process_filter):
1040 * window.c (select_window_1): Use it.
1041 * buffer.h (set_point_from_marker): Add prototype.
1042
3f940c5a
EZ
10432013-08-29 Eli Zaretskii <eliz@gnu.org>
1044
1045 * w32.c (term_winsock): Call release_listen_threads before calling
1046 WSACleanup.
1047 (_sys_wait_accept): Wait for accept event in a loop with a finite
1048 timeout, instead of waiting indefinitely. Will hopefully avoid
1049 hanging during exit because WSACleanup deadlocks waiting for the
1050 event object to be released. (Bug#14333)
1051
1052 * w32proc.c (release_listen_threads): New function, signals all
1053 the reader threads that listen for connections to stop waiting.
1054
1055 * w32.h (release_listen_threads): Add prototype.
1056
101ed2bb
DA
10572013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1058
1059 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1060 field of new marker (for sanity and safety).
20de2834
DA
1061 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1062 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1063
1f5cf200
DA
10642013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1065
1066 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1067 (x_after_update_window_line, x_scroll_bar_create):
1068 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1069 (handle_one_xevent, x_clear_frame_area):
1070 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1071 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1072 * xterm.h (x_clear_area): Adjust prototype.
1073
d2b36813
DA
10742013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1075
1076 Hook scanning and indentation functions to find_newline. This helps
1077 to avoid duplicated code and renders more respect to newline cache.
1078 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1079 * cmds.c (Fforward_line):
1080 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1081 Use find_newline and avoid unnecessary point movements.
1082 * search.c (scan_newline): Implement on top of find_newline.
1083
3ec7babc
SM
10842013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1085
1086 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1087 scoped code (bug#11258).
1088
5ab473cd
JD
10892013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1090
1091 * nsterm.m (last_window): New variable.
1092 (EV_TRAILER2): New macro.
1093 (EV_TRAILER): Call EV_TRAILER2.
1094 (mouseMoved:): Add support for mouse-autoselect-window
1095 on nextstep (Bug#6888).
1096
78779650
AS
10972013-08-28 Andreas Schwab <schwab@suse.de>
1098
1099 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1100 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1101 Remove unused macro definitions.
1102 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1103 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1104 Only define if emacs.
78779650 1105
c3c4768d
DA
11062013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1107
1108 Prefer enum glyph_row_area to int where appropriate.
1109 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1110 Fix comment.
1111 (window_box, window_box_width, window_box_left, window_box_left_offset)
1112 (window_box_right, window_box_right_offset): Adjust prototypes.
1113 * xdisp.c (window_box, window_box_width, window_box_left)
1114 (window_box_left_offset, window_box_right, window_box_right_offset):
1115 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1116 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1117 * nsterm.m (ns_clip_to_row):
1118 * w32term.c (w32_clip_to_row):
1119 * xterm.c (x_clip_to_row): Likewise.
1120
6bdcbfe1
DA
11212013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1124 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1125
50b13cde
PE
11262013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1129 for portability to hosts where /bin/sh has problems.
1130
f60e429a
DA
11312013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1132
1133 Redesign redisplay interface to drop global output_cursor.
1134 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1135 (toplevel): Remove declaration of output_cursor.
1136 (set_output_cursor, x_cursor_to): Remove prototype.
1137 * window.h (struct window): New member output_cursor.
1138 (output_cursor_to): New function to replace RIF member.
1139 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1140 (update_text_area, set_window_cursor_after_update): Use it.
1141 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1142 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1143 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1144 * w32term.c (x_update_window_begin, x_update_window_end):
1145 * xterm.c (x_update_window_begin, x_update_window_end):
1146 Adjust to use per-window output cursor.
1147
43aac990
PE
11482013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1149
d486344e
PE
1150 Simplify SELECT_TYPE-related code.
1151 Like EMACS_TIME, this portability layer is no longer needed, since
1152 Emacs has been using fd_set as a portability layer for some time.
1153 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1154 (SELECT_TYPE): Remove. All uses changed to fd_set.
1155 (fd_set) [!FD_SET]: New typedef.
1156
43aac990
PE
1157 Simplify EMACS_TIME-related code.
1158 This portability layer is no longer needed, since Emacs has been
1159 using struct timespec as a portability layer for some time.
1160 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1161 Include <time.h> rather than "systime.h"; that's all that's needed now.
1162 * dispnew.c: Include <timespec.h> rather than "systime.h";
1163 that's all that's needed now.
1164 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1165 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1166 TIMESPEC_RESOLUTION.
1167 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1168 LOG10_TIMESPEC_RESOLUTION.
1169 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1170 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1171 (make_emacs_time): Remove. All used changed to make_timespec.
1172 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1173 (current_timespec): Rename from current_emacs_time. All uses changed.
1174 (add_emacs_time): Remove. All uses changed to timespec_add.
1175 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1176 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1177 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1178 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1179 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1180 (current_timespec): Rename from current_emacs_time. All uses changed.
1181 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1182 changed to timespec_cmp.
1183 * xgselect.c: Include <timespec.h>, since our .h files don't.
1184
d350e350
DA
11852013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1186
1187 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1188 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1189 Remove the leftovers.
1190 * gtkutil.c (toplevel): Do not declare Qxft but include
1191 font.h to do so.
1192 * image.c (toplevel): Do not declare Vlibrary_cache because
1193 it's already done in lisp.h.
1194
9fed9729
DA
11952013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1196
1197 * lisp.h (Mouse_HLInfo): Move from here...
1198 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1199 (reset_mouse_highlight): New function.
1200 * msdos.c (dos_set_window_size, IT_update_begin)
1201 (internal_terminal_init):
1202 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1203 (ns_initialize_display_info):
1204 * w32console.c (initialize_w32_display):
1205 * w32term.c (x_update_window_end, x_free_frame_resources)
1206 (w32_initialize_display_info):
1207 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1208 * window.c (Fdelete_other_windows_internal):
1209 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1210 * termchar.h (toplevel):
1211 * xterm.h (toplevel): Include dispextern.h.
1212
f462f075
PE
12132013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1214
1215 Fix minor problems found by static checking.
1216 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1217 (expect): Avoid nested-if warning.
1218 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1219 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1220 * nsterm.h, nsterm.m (ns_select):
1221 * xgselect.c, xgselect.h (xg_select):
1222 Adjust signature to better match pselect's.
1223 * nsterm.m (ns_select):
1224 Don't set *TIMEOUT, since pselect doesn't.
1225 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1226 diagnostic about assigning const char * to it.
1227 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1228
068f9124
SM
12292013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1230
1231 * lread.c (substitute_object_recurse): Handle hash-tables as well
1232 (bug#15190).
1233
f5adc984
PE
12342013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1235
1fc8eb33
PE
1236 Fix unlikely core dump in init_tty, and simplify terminfo case.
1237 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1238 The old version incorrectly dumped core if malloc returned a
1239 buffer containing only non-NUL bytes.
1240 (init_tty): Do not allocate or free termcap buffers; the
1241 struct does that for us now.
1242 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1243 (struct tty_display_info): Define members termcap_term_buffer and
1244 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1245 use them. Allocate them directly in struct rather than indirectly
1246 via a pointer, to simplify init_tty.
1247
f5adc984
PE
1248 * frame.c (check_minibuf_window): Initialize 'window' properly,
1249 so that Emacs reliably aborts later if 'window' is not initialized.
1250
efec3894
JD
12512013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1252
1253 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1254 of VoidSymbol (Bug#15154).
1255
e1d0341e
DA
12562013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1257
1258 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1259 mouse_face_beg_y and mouse_face_end_y.
1260 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1261 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1262 Adjust users and update comment where appropriate.
1263
bfff6445
MR
12642013-08-26 Martin Rudalics <rudalics@gmx.at>
1265
1266 * frame.c (check_minibuf_window): New function.
068f9124
SM
1267 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1268 Call check_minibuf_window (Bug#15183).
bfff6445 1269
c80016b3
DA
12702013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1271
1272 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1273 because this is the only last cursor data we need to keep and consult.
1274 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1275 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1276 Adjust users.
1277
de396731
DA
12782013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1279
068f9124
SM
1280 Fix recovering from possible decompression error.
1281 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1282 the position where the partially decompressed data ends, and
447218dd 1283 should count how many bytes was produced so far.
de396731
DA
1284 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1285 (unwind_decompress): Really delete partially uncompressed data.
1286 (Fzlib_decompress_region): Take decompressed data size into account.
1287
c76826d9
DA
12882013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 * syntax.c (init_syntax_once): Adjust comment and do an early
1291 initialization of Qchar_table_extra_slots just once...
1292 * casetab.c (init_casetab_once):
1293 * category.c (init_category_once):
1294 * character.c (syms_of_character):
1295 * coding.c (syms_of_coding):
1296 * xdisp.c (syms_of_xdisp): ...and omit it here.
1297
b34454d0
EZ
12982013-08-24 Eli Zaretskii <eliz@gnu.org>
1299
11f20add
EZ
1300 * xdisp.c (get_next_display_element): Don't apply to characters
1301 from a display vector the logic of setting it->end_of_box_run_p
1302 suitable for characters from a buffer. (Bug#15175)
1303
b34454d0
EZ
1304 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1305 to handle directories, rather than '_utime' which doesn't.
1306 (Bug#15176)
1307
6e1b469e
JD
13082013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1309
1310 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1311 or fullscreen (Bug#14627).
1312
9c05bccf
PE
13132013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 System-dependent integer overflow fixes.
1316 * process.c (Fset_process_window_size): Signal an error if
1317 the window size is outside the range supported by the lower level.
1318 * sysdep.c (set_window_size): Return negative on error,
1319 nonnegative on success, rather than -1, 0, 1 on not in system,
1320 failure, success. This is simpler. Caller changed.
1321 (serial_configure): Remove unnecessary initialization of local.
1322 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1323 size fits in unsigned long; this isn't true on some 32-bit hosts.
1324 Avoid buffer overrun if some future version of /proc/meminfo has a
1325 variable name longer than 20 bytes.
1326 (system_process_attributes) [__FreeBSD__]:
1327 Don't assume hw.availpages fits in 'int'.
1328
c365c355
PE
13292013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 Don't let very long directory names overrun the stack.
1332 Fix some related minor problems involving "//", vfork.
1333 * callproc.c (encode_current_directory): New function.
1334 (call_process): Don't append "/"; not needed.
1335 * fileio.c (file_name_as_directory_slop): New constant.
1336 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1337 this can save the caller having to alloca.
1338 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1339 Use SAFE_ALLOCA, not alloca.
1340 (directory_file_name, Fexpand_file_name): Leave leading "//"
1341 alone, since it can be special even on POSIX platforms.
1342 * callproc.c (call_process):
1343 * process.c (Fformat_network_address):
1344 * sysdep.c (sys_subshell):
1345 Use encode_current_directory rather than rolling our own.
1346 (create_process): No need to encode directory; caller does that now.
1347 * process.h (encode_current_directory): New decl.
1348 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1349 Rework to avoid 'goto xyzzy;'.
1350
6c6014d4
EZ
13512013-08-23 Eli Zaretskii <eliz@gnu.org>
1352
1353 * xdisp.c (handle_face_prop): If the default face was remapped use
1354 the remapped face for strings from prefix properties. (Bug#15155)
1355
9997ec56
DA
13562013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1357
1358 Minor cleanup for redisplay interface and few related functions.
1359 * frame.h (enum text_cursor_kinds): Move from here...
1360 * dispextern.h (enum text_cursor_kinds): ...to here.
1361 (toplevel): Drop unnecessary declarations.
1362 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1363 in update_window_end_hook and draw_window_cursor functions.
1364 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1365 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1366 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1367 * xterm.c (x_update_window_end, x_draw_window_cursor):
1368 * xdisp.c (display_and_set_cursor, update_window_cursor)
1369 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1370 enum text_cursor_kinds where appropriate.
1371
7f780da6
DA
13722013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 Redesign redisplay interface to drop updated_row and updated_area.
1375 * dispextern.h (updated_row, updated_area): Remove declaration.
1376 (struct redisplay_interface): Pass glyph row and row area parameters
1377 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1378 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1379 Adjust prototypes.
1380 * dispnew.c (updated_row, updated_area): Remove.
1381 (redraw_overlapped_rows, update_window_line): Adjust user.
1382 (update_marginal_area, update_text_area): Likewise. Pass updated row
1383 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1384 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1385 Adjust users.
1386
26495794
PE
13872013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 * process.c (flush_pending_output): Remove stub.
1390 All uses removed.
1391
4a88129a
PE
13922013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 * callproc.c: Fix race that killed background processes (Bug#15144).
1395 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1396 Record deleted process-id in critical section, not afterwards.
1397 Don't mistakenly kill process created by a call-process invocation
1398 that discards output and does not wait.
1399
0c5307b0
DA
14002013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1401
1402 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1403 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1404 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1405 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1406 to shut up compiler in mark_object.
1407 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1408
0d7c1e66
PE
14092013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1412 We can't portably rely on PTY_OPEN doing that, even if
1413 it calls posix_openpt with O_CLOEXEC.
1414
3f246b65
KH
14152013-08-20 Kenichi Handa <handa@gnu.org>
1416
1417 * character.c (string_char): Improve commentary.
1418
8c2f38aa
PE
14192013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1422 (struct animation_cache): Make signature a flexible array member.
1423 All uses changed. This is a tad slower but may insulate us better
1424 from future changes to ImageMagick.
1425
bb566cea
PE
14262013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 * image.c: Shrink memory needed for animation cache.
1429 (SIGNATURE_DIGESTSIZE): New constant.
1430 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1431 (imagemagick_create_cache): Copy the signature. This saves
1432 several KB of memory that ImageMagick wastes per signature.
1433 Don't bother updating the update_time, as the caller does that now.
1434 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1435 it's a fixed size struct member now.
1436 (imagemagick_get_animation_cache): Always destroy the signature,
1437 as it's now imagemagick_create_cache's responsibility to copy it.
1438 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1439 and use memcmp rather than strcmp.
1440 eassert that ImageMagick returns a signature of the specified length.
1441
6da26928
LMI
14422013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1443
1444 * image.c (imagemagick_get_animation_cache): Don't segfault on
1445 each invocation.
453f4022
LMI
1446 (imagemagick_get_animation_cache): Revert to previous definition
1447 so that it actually works. But keep the memory leak fix.
1448 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1449
22490125
PE
14502013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1451
d0139df5
PE
1452 * image.c: Fix animation cache signature memory leak.
1453 Fix some other minor performance problems while we're at it.
1454 (imagemagick_create_cache): Clear just the members that
1455 need clearing. Don't set update_time, as caller does that now.
1456 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1457 Simplify by using pointer-to-pointer instead of a prev pointer.
1458 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1459 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1460 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1461 it's already a copy. Free the signature probe unless it's cached.
1462
22490125
PE
1463 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1464 This was introduced by my 2013-08-12 fix for Bug#15035.
1465
deb31e75
DA
14662013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1467
1468 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1469 (imagemagick_prune_animation_cache): Now static.
1470
319a4d03
LMI
14712013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1472
1473 * image.c (imagemagick_get_animation_cache): Don't segfault when
1474 pruning all entries.
1475
f747d82e
KB
14762013-08-18 Ken Brown <kbrown@cornell.edu>
1477
1478 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1479 static heap if ENABLE_CHECKING is defined.
1480 (max_bss_sbrk_ptr): New variable.
1481 (bss_sbrk): Use it.
1482 (report_sheap_usage): Report maximum static heap usage instead of
1483 ending static heap usage.
1484
d2c28fab
EZ
14852013-08-17 Eli Zaretskii <eliz@gnu.org>
1486
1487 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1488 of zlib_initialized according to the results of calling
1489 init_zlib_functions.
1490
274ff63f
LMI
14912013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1492
1493 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1494 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1495 (imagemagick_load_image): Remove the ping_wand code, which only
1496 apparently saved time on invalid animated images, and slowed down
1497 everything else. Optimise for the common case.
274ff63f 1498
2bede2ed
XF
14992013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1500
70ff8240
XF
1501 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1502
de179a3e
XF
1503 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1504
2bede2ed
XF
1505 * marker.c (set_marker): Remove documentation of undefined behavior.
1506
703dbeba
LMI
15072013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1508
1509 * image.c (imagemagick_compute_animated_image): Animate correctly
1510 when sub-images are smaller than the main image.
1d18b1e6
LMI
1511 (imagemagick_compute_animated_image): Setting the iterator row to
1512 zero is apparently not allowed.
79670014
LMI
1513 (imagemagick_compute_animated_image): Allow images that say they
1514 have sub-images that are bigger than the main image, but just crop
1515 them.
703dbeba 1516
63216c5e
JD
15172013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1518
1519 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1520
a5b5f73f
LMI
15212013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1522
1523 * image.c (imagemagick_compute_animated_image): Respect the GIF
1524 disposal methods.
1525
0fe73012
KB
15262013-08-15 Ken Brown <kbrown@cornell.edu>
1527
1528 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1529 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1530 needed.
1531
691a357f
PE
15322013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1533
1534 Fix minor problems found by static checking.
1535 * frame.c (delete_frame):
1536 * xdisp.c (next_element_from_display_vector):
1537 Avoid uninitialized local.
1538 * image.c (imagemagick_compute_animated_image): Port to C89.
1539 Prefer usual GNU indentation style for loops.
1540 Be more careful about bizarrely large sizes, by using ptrdiff_t
1541 instead of int.
1542
42fe2e88
DA
15432013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1544
1545 Fix infinite frame selection loop (Bug#15025).
1546 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1547
d39a3da6
EZ
15482013-08-15 Eli Zaretskii <eliz@gnu.org>
1549
068f9124
SM
1550 * xdisp.c (compute_window_start_on_continuation_line):
1551 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1552 to make sure we end up setting the window start at the leftmost
1553 visible character of the display line. This avoids funky
1554 horizontal shifting because the window start is not kept on the
1555 same position. (Bug#15090)
05426239
EZ
1556 (next_element_from_display_vector): Support 'box' face attribute
1557 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1558
6e856b69
LMI
15592013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1560
1561 * image.c (imagemagick_compute_animated_image): Implement animated
1562 images (bug#14700).
995be755
LMI
1563 (imagemagick_compute_animated_image): Fix some compilation
1564 warnings. Implement a very simple cache to make the animation
1565 usable at all, but it should be replaced with a per-image cache.
6e856b69 1566
d5a1acfa
DA
15672013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1568
1569 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1570 to do `for' loops over alist values.
1571 * buffer.h (FOR_EACH_BUFFER):
1572 * process.c (FOR_EACH_PROCESS): Use it.
1573 (handle_child_signal, status_notify, Fget_buffer_process)
1574 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1575
9c253307
DA
15762013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1577
1578 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1579 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1580 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1581 to xzalloc and so avoid redundant call to memset.
1582 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1583 members because it is allocated with xzalloc and so already zeroed.
1584
05e64f9f
KB
15852013-08-14 Ken Brown <kbrown@cornell.edu>
1586
1587 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1588 (Bug#15094).
1589
5b71542d
DA
15902013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1591
1592 Utility function and macro to copy Lisp string to C string.
1593 * lisp.h (xlispstrdupa): New macro.
1594 (xlispstrdup): New prototype.
1595 * alloc.c (xlispstrdup): New function.
1596 * callint.c (Fcall_interactively):
1597 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1598 (Fsubstitute_in_file_name):
1599 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1600 * image.c (x_create_bitmap_from_file):
1601 * w32term.c (w32_term_init):
1602 * xterm.c (x_term_init): Use xlispstrdup.
1603
71530c97
LMI
16042013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1605
4ce82fb8
LMI
1606 * image.c (imagemagick_load_image): Make animated pictures work.
1607 There's still some problems with background color settings, though
1608 (bug#14700).
1609
71530c97
LMI
1610 * decompress.c (unwind_decompress): Always restore point.
1611
7510a061
XF
16122013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1613
1614 * marker.c (set_marker): Reformat documentation.
1615
01c3051f
PE
16162013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1617
aab1fcdf
PE
1618 * xdisp.c (cursor_type_changed): Now static.
1619
01c3051f
PE
1620 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1621 Use changed. This avoids the need to call xmalloc and for the
1622 caller to call xfree, and avoids memory leaks in some situations.
1623
2084152a
DA
16242013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1627 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1628 (redisplay_window): If window_end_valid is cleared due to non-zero
1629 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1630 so do not call to try_cursor_movement for that window.
2084152a 1631
02455cb6
DA
16322013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1633
1634 * window.h (struct window): Convert window_end_pos and
1635 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1636 (wset_window_end_pos, wset_window_end_vpos): Remove.
1637 * dispnew.c (adjust_glyph_matrix):
1638 * window.c (Fwindow_end, replace_window, set_window_buffer)
1639 (make_window):
1640 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1641 (set_vertical_scroll_bar, redisplay_window, try_window)
1642 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1643 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1644 (note_mouse_highlight): Adjust users.
1645 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1646 Add comment.
1647
da5707e8
DA
16482013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1649
1650 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1651 * image.c (imagemagick_filename_hint): Use `const char *' and
1652 prefer SSDATA to SDATA to avoid warnings.
1653
25554267
DA
16542013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1655
1656 Cleanup window fringes, margins and scroll bars adjustments.
1657 * window.c (set_window_fringes, set_window_margins)
1658 (set_window_scroll_bars, apply_window_adjustment): New functions.
1659 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1660 (Fset_window_scroll_bars): Use them.
1661
38a2c910
DA
16622013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1663
1664 * window.h (struct window): Convert scroll_bar_width
1665 from Lisp_Object to integer. Adjust comment.
1666 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1667 Adjust users.
1668 * window.c (wset_scroll_bar_width): Remove.
1669 (make_window): Initialize scroll_bar_width.
1670 (Fsplit_window_internal): Use direct assignment.
1671 (Fset_window_configuration, save_window_save):
1672 Convert Lisp_Object to integer and back where appropriate.
1673 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1674 bar was actually changed, and mention this in docstring.
1675
2d065031
PE
16762013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * decompress.c: Minor simplifications.
1679 (Fzlib_decompress_region): Don't bother verifying
1680 that avail_out <= UINT_MAX, as that was confusing.
1681 Mention the restriction in a comment instead.
1682 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1683
a5bd5abb
JD
16842013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1685
1686 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1687 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1688
66e7901a
LMI
16892013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1690
1691 * image.c (imagemagick_filename_hint): Check for errors in the
1692 alist structure.
1693
2fa611b7
EZ
16942013-08-13 Eli Zaretskii <eliz@gnu.org>
1695
1696 * window.c (Fwindow_margins): Return nil when there's no marginal
1697 area, as per the documented API.
1698
1699 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1700 Fmake_vector, as scroll bar's struct members are not all Lisp
1701 objects now. This avoids crashes in GC.
1702
1703 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1704 bool, so its address could be taken.
1705
8259030d
LMI
17062013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1707
1708 * image.c (imagemagick_filename_hint): New function to possibly
1709 apply `image-content-type-suffixes'.
1710 (imagemagick_load_image): Use it.
1711
866c710e
EZ
17122013-08-13 Eli Zaretskii <eliz@gnu.org>
1713
1714 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1715 if loading zlib failed.
1716
f10490f0
JD
17172013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1718
96311be7
JD
1719 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1720 2013-08-13 checkin below. Change bool to BOOL, rule is:
1721 All Obj-C code uses BOOL, except for interfaces callable from C.
1722
f10490f0
JD
1723 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1724
c8ae93b0
DA
17252013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1726
1727 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1728 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1729 bool instead of BOOL.
1730 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1731 from Lisp_Object to bitfield. Adjust comment.
1732 * w32term.c (x_scroll_bar_create): Adjust user.
1733 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1734 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1735 Use bool for boolean.
1736 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1737 to `unsigned int' when defining a bitfield.
1738
53b64418
PE
17392013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1742
eeaf9bf3
DA
17432013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1744
1745 * window.h (struct window): Convert left_margin_cols and
1746 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1747 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1748 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1749 Adjust users.
1750 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1751 Adjust comment.
1752 (showing_window_margins_p, update_window_line, update_frame_1):
1753 * fringe.c (draw_fringe_bitmap_1):
1754 * xdisp.c (window_box_width): Adjust users.
1755 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1756 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1757 Use direct assignment.
1758 (Fset_window_configuration, save_window_save, Fwindow_margins):
1759 Convert Lisp_Object to integer and back where appropriate.
1760 (Fset_window_margins): Adjust user. Return t if any margin
1761 was actually changed, and mention this in docstring.
1762
956720af
XF
17632013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1764
f73f4ce6 1765 * syntax.c (forward_word):
956720af
XF
1766 * cmds.c (forward_char, backward_char): Mention the optional argument.
1767
9e37ee3b
DA
17682013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1769
1770 * window.h (struct window): Convert left_fringe_width
1771 and right_fringe_width from Lisp_Objects to integers.
1772 Adjust comment.
1773 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1774 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1775 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1776 Remove.
1777 (make_window): Initialize new integer fields to -1.
1778 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1779 (Fset_window_configuration, save_window_save):
1780 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1781 (Fset_window_fringes): Adjust user. Return t if any fringe
1782 was actually changed, and mention this in docstring.
1783
e4375ca7
DA
17842013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1785
1786 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1787 * nsfns.m (x_set_cursor_type):
1788 * w32fns.c (x_set_cursor_type):
1789 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1790 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1791
a45543bc
DA
17922013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1793
1794 * font.c (clear_font_cache): New function, stripped from...
1795 (Fclear_font_cache): ...here, which now uses the function
1796 above. Adjust comment.
1797 * font.h (clear_font_cache): Add prototype.
1798 * xfaces.c (clear_face_cache): Use clear_font_cache.
1799
ae966a86
DA
18002013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 * window.c (Fset_window_start): Compare `w', not `window' because
1803 `w' might not be equal to `window' after call to decode_live_window.
1804
297a545b
PE
18052013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1808 This fixes a problem introduced by the Bug#15035 patch
1809 when using GPG. Reported by Herbert J. Skuhra.
1810
aa942e2b
EZ
18112013-08-12 Eli Zaretskii <eliz@gnu.org>
1812
1813 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1814 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1815 not yet initialized.
1816
7699d09e
LMI
18172013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1818
1819 * decompress.c (Fzlib_decompress_region): Support zlib
1820 decompression, too, and rename.
1821
1d238bc7
PE
18222013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1823
1824 Minor zlib configuration tweaks.
1825 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1826 Don't assume presence of fn_inflateInit2_ zlib internal function.
1827
8a44a184
LMI
18282013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1829
1830 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1831 include the zlib prefix.
1832
594a4307
EZ
18332013-08-12 Eli Zaretskii <eliz@gnu.org>
1834
1835 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1836 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1837 define static variables that are pointers to zlib functions to be
1838 dynamically loaded.
1839 (init_zlib_functions) [WINDOWSNT]: New function.
1840 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1841 New macros.
1842 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1843 macros instead of invoking the zlib functions directly.
068f9124
SM
1844 (syms_of_decompress): DEFSYM Qzlib_dll.
1845 Staticpro Szlib_available_p.
594a4307 1846
d2e113bc
DA
18472013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1848
1849 Avoid looping over all frame windows to freeze and unfreeze.
1850 * window.h (struct window): Drop frozen_window_start_p.
1851 (freeze_window_starts): Drop prototype.
1852 * frame.h (struct frame): New frozen_window_starts flag.
1853 (FRAME_WINDOWS_FROZEN): New macro.
1854 * window.c (freeze_window_start, freeze_window_starts):
1855 Remove.
1856 (select_window, replace_window): Adjust users.
1857 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1858 (window_frozen_p): New function.
1859 (redisplay_window): Use it.
1860
94fcd171
PE
18612013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 Fix some fd issues when running subprocesses (Bug#15035).
1864 Fix bugs that can leak files or file descriptors on errors.
1865 Don't unlink open temp files, as that's hard for users to diagnose
1866 when things go awry (e.g., temp disk exhausted).
1867 Don't bother to lock temp files. Check for invalid recursion.
1868 * callproc.c (synch_process_fd): Remove. All uses removed.
1869 (synch_process_tempfile): New var or macro.
1870 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1871 New constants.
1872 (record_kill_process): New arg, the temp name. All callers changed.
1873 (delete_temp_file): Now just a simple wrapper around unlink.
1874 (call_process_kill): New arg, the call_process_fd array.
1875 Close them all. Clear synch_process_pid. Remove the temp file,
1876 or arrange for it to be removed.
1877 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1878 that's been moved to synch_process_tempfile. Caller changed.
1879 Do not remove the tempfile; that's now call_process_kill's
1880 responsibility.
1881 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1882 call_process_kill; the caller now does that.
1883 (call_process_cleanup): Do not close the process fd; that's now
1884 call_process_kill's responsibility.
1885 (Fcall_process): Implement via new function call_process, which
1886 has most of the old body of Fcall_process, but with a different API.
1887 (call_process): New function that does not open or close filefd if
1888 it is nonnegative. Record which fds need to be closed, and let
1889 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1890 Signal an error if invoked recursively (could be done via a hook).
1891 Simplify creation of the tempfile in the MSDOS case.
1892 Don't create the output file until after checking for the executable.
1893 Report any failure to open /dev/null.
1894 Don't open /dev/null for writing twice; once is enough.
1895 Don't create pipe if all output is being discarded or sent to file.
1896 Don't worry about setting up the coding system or reading from the
1897 pipe if all output is being discarded.
1898 Hoist fd_error local into top level, to lessen block nesting.
1899 Don't record deleted pid here; now done by Fcall_process_region.
1900 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1901 and note its success in synch_process_tempfile.
1902 Do not leak resources when child_setup fails.
1903 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1904 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1905 (create_temp_file): Now returns open fd, with an additional
1906 Lisp_Object * argument to return the name. All callers changed.
1907 Do not close the file; rewind it instead, and leave it open for
1908 the caller. Do not lock the temp file. Unwind-protect the file
1909 and the file-descriptor.
1910 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1911 If an asynchrounous process, record it here, not in call_process.
1912 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1913 * eval.c (set_unwind_protect): New function.
1914 * fileio.c (write_region): New function, generalized from the
1915 old Fwrite_region. Do not lock temp files.
1916 (Fwrite_region): Use it.
1917 * lisp.h (set_unwind_protect, write_region): New decls.
1918 * process.c: Include <verify.h>.
1919 (make_process): Mark fds as initially closed.
1920 (deleted_pid_list): Now a list of pid-filename pairs.
1921 All uses changed.
1922 (close_process_fd): New function.
1923 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1924 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1925 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1926 (create_process, create_pty, Fmake_serial_process)
1927 (server_accept_connection): Record which fds need to be closed,
1928 and let deactivate_process close them.
1929 (Fmake_network_process): Do not discard the unwind-protect
1930 until it's safe to do so.
1931 (deactivate_process): Close the fds opened by create_process etc.
1932 (Fprocess_send_eof): Adjust to new way of recording open fds.
1933 Report an error if /dev/null can't be opened, instead of aborting.
1934 * process.h (PROCESS_OPEN_FDS): New constant.
1935 (struct Lisp_Process): New member open_fds.
1936 (record_kill_process, record_deleted_pid): Adjust signatures.
1937 (record_deleted_pid): Move decl here ...
1938 * syswait.h (record_deleted_pid): ... from here.
1939
d0e615c3
PE
19402013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * decompress.c: Fix bugs with large buffers and weird inputs.
1943 Tune a bit. Reindent as per usual Emacs style.
1944 (BUFFER_SIZE): Remove.
1945 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1946 more than UINT_MAX bytes. Decompress into the gap instead of into
1947 an auto buffer, as this should avoid copying. Return nil if
1948 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1949 set immediate_quit; we shouldn't trust zlib code that much.
1950
313546eb
LMI
19512013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1952
99a32242
LMI
1953 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1954 errors, and really move the gap to where we want it.
1955
313546eb
LMI
1956 * lisp.h: Include decompress.c support.
1957
1958 * emacs.c (main): Include decompress.c support.
1959
1960 * Makefile.in: Include -lz if present.
1961
d2d699ac
JD
19622013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1963
f90e3ebd
JD
1964 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1965 (initWithTitle:): Initialize frame to 0.
1966 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1967 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1968 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1969
1970 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1971 fillWithWidgetValue:frame:
1972
423d3b3f
JD
1973 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1974 remove memory leak warnings.
1975
d2d699ac
JD
1976 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1977 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1978 menu_pending_title.
1979
1980 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1981 (x_activate_menubar): Update the whole menu.
1982 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1983 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1984 current event is not NSSystemDefined (Bug#15001).
1985 Call ns_check_menu_open only if trackingMenu is 2.
1986 (menuDidClose:): New method, decrease trackingMenu.
1987 (fillWithWidgetValue:setDelegate:): New method.
1988 (fillWithWidgetValue:): Call the above.
1989
1990 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1991
7d652d97
PE
19922013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 Omit some unnecessary casts.
1995 Many of these go back to the old pre-C89 days, when they may have
1996 been needed, but we've been assuming C89 or later for a while now.
1997 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1998 (live_float_p, live_misc_p, live_vector_p):
1999 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2000 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2001 (defvar_per_buffer):
2002 * callint.c (Fcall_interactively):
2003 * doc.c (Fsubstitute_command_keys):
2004 * filelock.c (get_boot_time):
2005 * frame.c (xrdb_get_resource):
2006 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2007 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2008 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2009 (menuitem_highlight_callback, menu_destroy_callback)
2010 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2011 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2012 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2013 (xg_tool_bar_help_callback, tb_size_cb):
2014 * image.c (xpm_alloc_color, png_read_from_memory)
2015 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2016 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2017 (syms_of_image):
2018 * keymap.c (describe_map):
2019 * nsfns.m (Fns_display_monitor_attributes_list):
2020 * nsmenu.m (process_dialog:):
2021 * nsterm.m (hold_event):
2022 * process.c (wait_reading_process_output):
2023 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2024 * scroll.c (do_direct_scrolling, scrolling_1):
2025 * termcap.c (tgetent):
2026 * window.c (check_window_containing, add_window_to_list)
2027 (freeze_window_starts):
2028 * xdisp.c (compare_overlay_entries, vmessage):
2029 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2030 (x_get_monitor_attributes_xrandr)
2031 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2032 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2033 * xfont.c (xfont_match, xfont_open):
2034 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2035 (menubar_selection_callback, menu_position_func)
2036 (popup_selection_callback, create_and_show_popup_menu)
2037 (dialog_selection_callback, create_and_show_dialog):
2038 * xrdb.c (x_get_string_resource):
2039 (main) [TESTRM]:
2040 * xsmfns.c (x_session_check_input):
2041 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2042 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2043 (xaw_jump_callback, xaw_scroll_callback):
2044 Omit unnecessary casts.
2045
9acc1074
PE
20462013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 Minor string-length refactoring.
2049 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2050 * frame.c (make_monitor_attribute_list):
2051 Prefer build_string to strlen + make_string.
2052
361c0eb8
JD
20532013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2054
2055 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2056 don't check minor_code (Bug#14417).
2057
14ba0822
EZ
20582013-08-09 Eli Zaretskii <eliz@gnu.org>
2059
2060 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2061 vertical positions instead. This avoids calling MATRIX_ROW with
2062 row numbers that are possibly beyond valid limits. (Bug#15064)
2063
309f24d1
DA
20642013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2065
2066 Use xstrdup and build_unibyte_string where applicable.
2067 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2068 * xfns.c (x_window):
2069 * xrdb.c (x_get_customization_string):
2070 * xterm.c (xim_initialize):
2071 * w32fns.c (w32_window): Use xstrdup.
2072 (w32_display_monitor_attributes_list):
2073 * emacs.c (init_cmdargs):
2074 * keyboard.c (PUSH_C_STR):
2075 * nsfont.m (nsfont_open):
2076 * sysdep.c (system_process_attributes):
2077 * w32.c (system_process_attributes):
2078 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2079
55902276
EZ
20802013-08-09 Eli Zaretskii <eliz@gnu.org>
2081
2082 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2083 variables of these types so that GDB would know about them, as aid
2084 for debugging fatal exceptions. (Bug#15024) See also
2085 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2086 discussions.
2087
10bf7f5a
JD
20882013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2089
2090 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2091 larger than the NSWindow (Bug#14934).
2092
65620264
DA
20932013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2094
2095 Redesign redisplay interface to drop global variable updated_window.
2096 Always pass currently updated window as a parameter to update routines.
2097 * dispextern.h (updated_window): Remove declaration.
2098 (struct redisplay_interface): Pass window parameter to
2099 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2100 and after_update_window_hook.
2101 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2102 Adjust prototypes.
2103 * dispnew.c (updated_window): Remove.
2104 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2105 (update_window_line): Adjust to match redisplay interface changes.
2106 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2107 (ns_scroll_run, ns_after_update_window_line):
2108 * w32term.c (x_update_window_begin, x_update_window_end)
2109 (x_after_update_window_line, x_scroll_run):
2110 * xterm.c (x_update_window_begin, x_update_window_end)
2111 (x_after_update_window_line, x_scroll_run):
2112 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2113 Likewise. Adjust comments where appropriate.
2114 (x_cursor_to): Simplify because this is always called during window
2115 update (but install debugging check anyway).
2116 (expose_window): Check must_be_updated_p flag to see whether this
2117 function is called during window update.
2118
628fdc56
DA
21192013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2120
2121 Do not reset window modification event counters excessively.
2122 These leftovers and poor man's tricky methods to catch extra
2123 redisplay's attention are no longer needed.
2124 * frame.c (set_menu_bar_lines_1):
2125 * minibuf.c (read_minibuf_unwind):
2126 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2127 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2128 (window_scroll_line_based, Fset_window_configuration):
2129 * xdisp.c (redisplay_window): Do not reset last_modified and
2130 last_overlay_modified counters.
2131
8fd9c92e
JD
21322013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2133
2134 * xselect.c (x_send_client_event): Set send_event and serial, memset
2135 data.l as it might be bigger than data.b. Use 24 bit mask to
2136 XSendEvent (Bug#15034).
2137
0ee18172
EZ
21382013-08-07 Eli Zaretskii <eliz@gnu.org>
2139
2140 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2141 for TTY frames that are not the top frame on their console.
2142 (Bug#14616)
2143
16ddd1a6
MR
21442013-08-07 Martin Rudalics <rudalics@gmx.at>
2145
2146 * w32term.c (w32fullscreen_hook): Really maximize frame when
2147 asked for (Bug#14841).
2148
d2a95ffb
DA
21492013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2150
2151 Prefer selected_window to Fselected_window, likewise for frames.
2152 * buffer.c (Fbuffer_swap_text):
2153 * data.c (Fvariable_binding_locus):
2154 * window.c (run_window_configuration_change_hook): Adjust users.
2155 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2156 Use decode_live_frame.
2157
170da1ec
DA
21582013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2159
2160 Be more careful if selected window shows the buffer other than current,
2161 use window_outdated only if this is not so. This change should also
2162 address some weird issues discussed in Bug#13012.
2163 * window.h (window_outdated): New prototype.
2164 * window.c (window_outdated): Now here. Convert from static and
2165 always assume window's buffer.
2166 (Fwindow_end, Fwindow_line_height): Use it.
2167 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2168 and always assume window's buffer.
2169 (redisplay_window): Adjust user.
e5eefe9b 2170 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2171 check whether mode line should be updated only if selected window
2172 shows current buffer.
2173 (run_window_scroll_functions): Use eassert for debugging check.
2174 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2175
56b5d5b1
DA
21762013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2177
2178 * window.c (window_scroll, window_scroll_pixel_based)
2179 (window_scroll_line_based): Use bool for booleans.
2180
2878ba7e
PE
21812013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2182
2183 * process.c: Fix minor off-by-one issues in descriptor counts.
2184 This shouldn't fix any real bugs, but it cleans up the code a bit.
2185 (max_process_desc, max_input_desc): -1, not 0, means none.
2186 All uses changed.
2187 (delete_input_desc): New function.
2188 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2189 (deactivate_process): Scan backwards when recomuting max_process_desc;
2190 that should be faster.
2191 (init_process_emacs): Initialize max_input_desc.
2192
e30b79c1
DA
21932013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2194
2195 Use region cache to speedup bidi_find_paragraph_start.
2196 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2197 Rename cache_long_line_scans to cache_long_scans.
2198 * buffer.c (bset_cache_long_line_scans): Rename to
2199 bset_cache_long_scans.
2200 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2201 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2202 into account.
2203 (syms_of_buffer): Rename cache-long-line-scans to
2204 cache-long-scans. Adjust docstring.
2205 * search.c (newline_cache_on_off):
2206 * indent.c (width_run_cache_on_off): Adjust users.
2207 * bidi.c (bidi_paragraph_cache_on_off): New function.
2208 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2209 * insdel.c (prepare_to_modify_buffer):
2210 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2211
00012b86
DA
22122013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2213
2214 Invalidate region caches only if buffer text is going to be changed.
2215 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2216 (modify_text): ...new prototype.
2217 (prepare_to_modify_buffer_1): New prototype.
2218 * textprop.c (modify_region): Rename to...
2219 (modify_text_properties): ...new function.
2220 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2221 (Fremove_list_of_text_properties): Adjust users.
2222 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2223 (modify_text): ...new function.
2224 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2225 (prepare_to_modify_buffer_1): ...new function.
2226 * casefiddle.c (casify_region):
2227 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2228 (Ftranspose_regions): Use modify_text.
2229
dc6c0eda
SM
22302013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2231
2232 * lisp.mk (lisp): Add nadvice.elc.
2233
8f3a2c26
DA
22342013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2235
2236 New macro to iterate over live buffers similar to frames.
2237 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2238 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2239 Declare buffer-related variables here to offload lisp.h.
2240 * buffer.c (Vbuffer_alist): Adjust comment.
2241 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2242 (other_buffer_safely):
2243 * data.c (store_symval_forwarding):
2244 * dispnew.c (Fframe_or_buffer_changed_p):
2245 * fileio.c (Fdo_auto_save):
2246 * filelock.c (unlock_all_files):
2247 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2248
e0fdb694
PE
22492013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2252 * callproc.c (create_temp_file):
2253 * filelock.c (create_lock_file):
2254 Assume mkostemp, since it's now provided by Gnulib.
2255
63f5c6c2
EZ
22562013-08-04 Eli Zaretskii <eliz@gnu.org>
2257
2258 * w32.c (mkostemp): New function.
2259 (mktemp): Remove, no longer used. Most of the code reused in
2260 mkostemp. (Bug#15015)
484ab239 2261 (mktemp): Don't undef.
63f5c6c2 2262
f0b79313
DA
22632013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2264
2265 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2266 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2267 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2268 (free_glyph_pool, check_glyph_memory): Likewise for
2269 all users. Adjust comments where appropriate.
2270
98f638d6
PE
22712013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 * composite.h: Minor fixups.
2274 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2275 to fix a misspelling, and change it to an inline function while
2276 we're at it (it need not be a macro). All uses changed.
2277 (composition_method, composition_valid_p):
2278 Rewrite to avoid assignments in if-conditions.
2279
75c59fb3
DA
22802013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2281
2282 Do not use global Lisp_Object in composition macros.
2283 * composite.h (composition_temp): Remove declaration.
2284 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2285 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2286 (compose_region): Remove the leftover.
75c59fb3
DA
2287 * composite.c (composition_temp): Remove.
2288 (run_composition_function, update_compositions)
2289 (composition_compute_stop_pos, composition_adjust_point)
2290 (Ffind_composition_internal):
2291 * coding.c (handle_composition_annotation):
2292 * xdisp.c (handle_composition_prop, check_point_in_composition):
2293 Related users changed.
2294
a10c8269
DA
22952013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2296
2297 Drop FRAME_PTR typedef.
2298 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2299 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2300 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2301 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2302 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2303 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2304 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2305 All related users changed.
2306
a104f656
SM
23072013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2308
2309 * eval.c (default_toplevel_binding): New function.
2310 (Fdefvar): Use it.
2311 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2312 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2313 (syms_of_eval): Export them.
2314 * data.c (Fdefault_value): Micro cleanup.
2315 * term.c (init_tty): Use "false".
2316
4b5c9326
DA
23172013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2318
2319 Fix X GC leak in GTK and raw (no toolkit) X ports.
2320 * xterm.c (x_free_frame_resources): If white and black relief
2321 GCs are allocated, always free them here.
2322 * xfns.c (x_make_gc): Omit redundant initialization.
2323 * widget.c (create_frame_gcs): Remove the leftover.
2324 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2325 in x_free_frame_resources.
2326
b19aa636
JD
23272013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2328
2329 * nsterm.m (windowWillResize:toSize:): Only change title if
2330 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2331 modifying it.
2332 (viewDidEndLiveResize): New method.
2333
2334 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2335 inside NS_IMPL_COCOA.
2336
af1f7e06
DA
23372013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2338
2339 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2340 Do not check whether undo is enabled because record_insert and
2341 record_delete does that themselves.
2342
65b02bb9
DA
23432013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2344
2345 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2346 member which is not really used any more.
2347 (FRAME_XIC_BASE_FONTNAME): Remove.
2348 * xfns.c (xic_free_fontset): Adjust user.
2349 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2350 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2351 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2352 (xdialog_show): Use eassert for debugging check.
7ee0f047 2353 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2354
6318cde0
PE
23552013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2356
2357 * fileio.c, fns.c (merge): Move extern decl from here ...
2358 * lisp.h (merge): ... to here.
2359
6c1a09ba
DA
23602013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2361
2362 Fix last font-related change.
2363 * w32font.h (w32font_list_internal, w32font_match_internal):
2364 Fix prototype.
2365 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2366 (uniscribe_list_family): Adjust to match font API change.
2367 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2368 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2369
f8c20208
DA
23702013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2371
2372 * frame.h (FRAME_MOUSE_UPDATE):
2373 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2374 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2375
fdb396e2
DA
23762013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2377
2378 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2379 * font.h (struct font_driver): Change list, match, and list_family
2380 functions to accept struct frame * as first arg.
068f9124
SM
2381 * font.c (font_score, font_compare, font_sort_entities):
2382 Remove prototypes.
fdb396e2
DA
2383 (font_sort_entities, font_list_entities, font_select_entity):
2384 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2385 match font API change.
2386 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2387 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2388 * ftxfont.c (ftxfont_list, ftxfont_match):
2389 * xftfont.c (xftfont_list, xftfont_match):
2390 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2391 * w32font.c (w32font_list, w32font_match, w32font_list):
2392 (w32font_list_internal, w32_font_match_internal): Likewise.
2393 * xfaces.c (Fx_family_fonts): Adjust user.
2394
52b8a085
DA
23952013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2396
2397 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2398 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2399 only if HAVE_X_WINDOWS is in use.
2400 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2401 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2402 * w32term.c (x_wm_set_icon_position): Likewise.
2403 * w32fns.c (x_icon): Adjust user.
2404
c791c18e
DA
24052013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2406
2407 * xterm.c (last_mouse_press_frame): Remove the
2408 leftover which is not really used any more.
2409 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2410 (x_flush): Call XFlush once per each X display, not frame.
2411 This is better because this code always unconditionally skips
2412 non-X frames in Vframe_list and issues the only XFlush if we
2413 have more than one X frame on the same X display.
2f935d86
DA
2414 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2415 Use bool for booleans.
2416 (x_draw_glyph_string_background, cvt_string_to_pixel):
2417 (cvt_pixel_dtor): Drop unnecessary prototypes.
2418 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2419
f435830e
DA
24202013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2421
2422 Drop unnecessary functions that deals with frame pixel size.
2423 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2424 (x_pixel_height): Drop prototypes.
2425 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2426 (x_pixel_height): Drop implementations.
2427 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2428 which should be always valid for window frame.
2429 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2430 * w32menu.c (Fx_popup_dialog):
2431 * xmenu.c (Fx_popup_dialog): Likewise for both.
2432
84231434
DA
24332013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2434
2435 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2436 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2437 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2438 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2439 and mention nil frame in docstring.
84231434 2440
959067a1
DA
24412013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2442
2443 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2444 (x_figure_window_size): Likewise. Adjust to return long.
2445 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2446 (toplevel): Move Qterminal_live_p to...
2447 * terminal.c (toplevel): ...here, make it static, and...
2448 (syms_of_terminal): ...DEFSYM here.
2449 * frame.h (Qterminal_live_p): Remove declaration.
2450 (make_frame, x_figure_window_size): Adjust prototype.
2451 * nsfns.m (Fx_create_frame): Use long for window flags.
2452
f4b169ce
PE
24532013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2456 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2457 Do not assume that emacs_close (INT_MAX) is a no-op.
2458
bee6a2c7
DA
24592013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2460
2461 * xfaces.c (make_face_cache): For struct face_cache, prefer
2462 xmalloc to xzalloc and so avoid redundant call to memset.
2463 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2464
d7e6881a
DA
24652013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2466
2467 * fringe.c (draw_window_fringes, update_window_fringes)
2468 (compute_fringe_widths):
2469 * w32term.c (x_draw_glyph_string):
2470 * window.c (candidate_window_p, Frecenter):
2471 * xfaces.c (realize_basic_faces, realize_default_face)
2472 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2473 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2474 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2475 * xmenu.c (Fx_menu_bar_open_internal):
2476 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2477 * xsettings.c (xft_settings_event):
2478 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2479 Use bool for booleans. Adjust style and comments where
2480 appropriate.
2481 * dispextern.h (draw_window_fringes, update_window_fringes)
2482 (compute_fringe_widths):
2483 * xterm.h (x_had_errors_p): Adjust prototype.
2484
ec3058af
DA
24852013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2486
2487 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2488 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2489
218e0637
DA
24902013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2491
2492 * fns.c (toplevel): Remove comment before Fsafe_length because
2493 it checks for QUIT.
2494
e560aba9
PE
24952013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2498
2e5ce5de
EZ
24992013-07-28 Eli Zaretskii <eliz@gnu.org>
2500
2501 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2502 frame which got the message is still alive, before dereferencing
2503 its pointer. (Bug#14970)
2504
2505 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2506 be a live window, before using it as such. (Bug#14970)
2507
e95da6d3
EZ
25082013-07-27 Eli Zaretskii <eliz@gnu.org>
2509
2510 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2511 w32_detect_focus_change instead of doing part of its job by hand.
2512 This fixes the problem whereby FOCUS_OUT events were not sent to
2513 the event queue.
2514
a8f93651
EZ
25152013-07-26 Eli Zaretskii <eliz@gnu.org>
2516
fec92060
EZ
2517 * process.c (Fprocess_list): Doc fix.
2518
a8f93651
EZ
2519 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2520 being re-exposed only if it didn't ask to become visible.
2521 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2522 was previously iconified. (Bug#14841)
2523 (x_iconify_frame): Mark the frame iconified.
2524
d5a7a9d9
PE
25252013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 Fix minor problems found by static checking.
2528 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2529 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2530
56ea7291
SM
25312013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2532
2533 * eval.c (set_specpdl_old_value): New function.
2534 (unbind_to): Minor simplification.
2535 (get_backtrace_frame): New function.
2536 (Fbacktrace_frame): Use it. Add `base' argument.
2537 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2538 (syms_of_eval): Export backtrace-eval.
2539 * xterm.c (x_focus_changed): Simplify.
2540
9d611ffe
PE
25412013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2542
2543 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2544
999c74e3
EZ
25452013-07-24 Eli Zaretskii <eliz@gnu.org>
2546
2547 * xdisp.c (redisplay_window): Instead of moving point out of
2548 scroll margin, reject the force_start method, and try scrolling
2549 instead. (Bug#14780)
2550
198fa217
KB
25512013-07-24 Ken Brown <kbrown@cornell.edu>
2552
2553 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2554 (Bug#14944).
2555
53840e55
PE
25562013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2557
2558 * eval.c (Fprogn): Do not check that BODY is a proper list.
2559 This undoes the previous change. The check slows down the
2560 interpreter, and is not needed to prevent a crash. See
2561 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2562
60967f56
GM
25632013-07-23 Glenn Morris <rgm@gnu.org>
2564
2565 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2566
9ca960e2
PE
25672013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2568
a29c3e6d
PE
2569 Port to GNU/Linux systems with tinfo but not ncurses.
2570 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2571 to decide whether ncurses is being used. Without this change,
2572 GCC complains about tgetent not being declared, on a system
2573 that has tinfo installed but ncurses not installed.
2574
f274311c
PE
2575 * eval.c (Fprogn): Check that BODY is a proper list.
2576
16b0520a
PE
2577 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2578 * data.c (Fsetq_default):
2579 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2580 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2581 (Fcondition_case):
2582 Tune by taking advantage of the fact that ARGS is always a list
2583 when a function is declared to have UNEVALLED args.
2584
9ca960e2
PE
2585 * emacsgtkfixed.c: Port to GCC 4.6.
2586 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2587
afacaa1b
JB
25882013-07-23 Juanma Barranquero <lekktu@gmail.com>
2589
2590 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2591 here to silence compiler warnings.
2592
368a85a4
PE
25932013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2594
2595 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2596 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2597 from messing up Emacs's 'struct frame' (Bug#14923).
2598
f4e891b5
PE
25992013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * alloc.c (make_save_ptr_ptr): Define this function.
2602 It was inadvertently omitted. It's needed only if
2603 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2604
96c8b65e
JD
26052013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2606
2607 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2608 frame have focus (Bug#14895).
2609
ee010797
PE
26102013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 Avoid vfork-related deadlock more cleanly.
2613 * callproc.c (child_setup): When the child's exec fails, output
2614 the program name, as that's more useful. Use O_NONBLOCK to avoid
2615 deadlock.
2616 * process.c (create_process_1): Remove; no longer needed.
2617 (create_process): Remove timer hack; no longer needed, now that
2618 the child avoids deadlock.
2619
f0398ec1 26202013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2621
2622 * image.c (Fimage_flush): Fix doc typo.
2623
b2a069c2
PE
26242013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2625
6496aec9
PE
2626 Fix array bounds violation when pty allocation fails.
2627 * process.c (PTY_NAME_SIZE): New constant.
2628 (pty_name): Remove static variable; it's now auto.
2629 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2630 Take pty_name as an arg rather than using a static variable.
2631 All callers changed.
2632 (create_process): Recover pty_flag from process, not from volatile local.
2633 (create_pty): Stay inside array even when pty allocation fails.
2634 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2635
b2a069c2
PE
2636 * lread.c (Fload): Avoid initialization only when lint checking.
2637 Mention that it's needed only for older GCCs.
2638
99107004
KH
26392013-07-20 Kenichi Handa <handa@gnu.org>
2640
2641 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2642 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2643
6b1b199d
AS
26442013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2645
2646 * lread.c (Fload): Avoid uninitialized warning.
2647
4195afc3
PE
26482013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2649
3f5bef16
PE
2650 Fix some minor file descriptor leaks and related glitches.
2651 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2652 (create_lock_file): Use write, not emacs_write.
2653 * image.c (slurp_file, png_load_body):
2654 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2655 (server_accept_connection):
2656 Don't leak an fd on memory allocation failure.
2657 * image.c (slurp_file): Add a cheap heuristic for growing files.
2658 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2659 as that's what the other routines do. Maybe input need not be
2660 blocked at all, but it's better to be consistent.
2661 Avoid undefined behavior when strlen is zero.
2662
4195afc3
PE
2663 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2664 (NSTATICS): Now a constant; doesn't need to be a macro.
2665
a1aeeffe
RS
26662013-07-19 Richard Stallman <rms@gnu.org>
2667
2668 * coding.c (decode_coding_utf_8): Add simple loop for fast
2669 processing of ASCII characters.
2670
63b34baa
PE
26712013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2674
621dd9ac
EZ
26752013-07-19 Eli Zaretskii <eliz@gnu.org>
2676
2677 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2678 unportable 'struct x_display_info'.
2679 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2680 is a portable type.
2681
1396ac86
PE
26822013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2683
ab9980cd
PE
2684 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2685 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2686 or fscanf fails.
2687 (system_process_attributes): Prefer plain char to unsigned char
2688 when either will do. Clean up properly if interrupted or if
068f9124
SM
2689 memory allocations fail. Don't assume sscanf succeeds.
2690 Remove no-longer-needed workaround to stop GCC from whining.
2691 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2692 bit more carefully.
2693
1396ac86
PE
2694 Fix obscure porting bug with varargs functions.
2695 The code assumed that int is treated like ptrdiff_t in a vararg
2696 function, which is not a portable assumption. There was a similar
2697 -- though these days less likely -- porting problem with various
2698 assumptions that pointers of different types all smell the same as
2699 far as vararg functions is conserved. To make this problem less
2700 likely in the future, redo the API to use varargs functions.
2701 * alloc.c (make_save_value): Remove this vararg function.
2702 All uses changed to ...
2703 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2704 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2705 New functions.
2706 (make_save_ptr): Rename from make_save_pointer, for consistency with
2707 the above. Define only on platforms that need it. All uses changed.
2708
4d19d194
PE
27092013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 * keyboard.c: Try to fix typos in previous change.
2712 (DISPLAY_LIST_INFO): New macro.
2713 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2714 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2715
945c5bb1
JB
27162013-07-18 Juanma Barranquero <lekktu@gmail.com>
2717
2718 * keyboard.c (kbd_buffer_get_event):
2719 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2720 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2721
f4b1eb36
PE
27222013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2723
5e679a2c
PE
2724 * filelock.c: Fix unlikely file descriptor leaks.
2725 (get_boot_time_1): Rework to avoid using emacs_open.
2726 This doesn't actually fix a leak, but is better anyway.
2727 (read_lock_data): Use read, not emacs_read.
2728
a8cd4836
PE
2729 * doc.c: Fix minor memory and file descriptor leaks.
2730 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2731 (get_doc_string, Fsnarf_documentation):
2732 Fix file descriptor leak on error.
2733
ef30e638
PE
2734 * term.c: Fix minor fdopen-related file descriptor leaks.
2735 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2736 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2737
f4b1eb36
PE
2738 * charset.c: Fix file descriptor leaks and errno issues.
2739 Include <errno.h>.
2740 (load_charset_map_from_file): Don't leak file descriptor on error.
2741 Use plain record_xmalloc since the allocation is larger than
2742 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2743 of entries.
2744 * eval.c (record_unwind_protect_nothing):
2745 * fileio.c (fclose_unwind):
2746 New functions.
2747 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2748 The replacement doesn't block input, but that no longer seems
2749 necessary.
2750
b648c163
PE
27512013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2752
a0931322
PE
2753 * lread.c: Fix file descriptor leaks and errno issues.
2754 (Fload): Close some races that leaked fds or streams when 'load'
2755 was interrupted.
2756 (Fload, openp): Report error number of last nontrivial failure to open.
2757 ENOENT counts as trivial.
2758 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2759 New functions.
2760 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2761 now that the function is always called with a nonnegative arg.
2762 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2763 All uses replaced with ...
2764 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2765
b648c163
PE
2766 A few more minor file errno-reporting bugs.
2767 * callproc.c (Fcall_process):
2768 * doc.c (Fsnarf_documentation):
2769 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2770 * process.c (set_socket_option):
2771 Don't let a constructor trash errno.
2772 * doc.c: Include <errno.h>.
2773
b1dc4084
JB
27742013-07-16 Juanma Barranquero <lekktu@gmail.com>
2775
2776 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2777
c43843aa
PE
27782013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2779
50a30cce
PE
2780 Fix w32 bug with call-process-region (Bug#14885).
2781 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2782 to Fcall_process when the input is empty. This simplifies the
2783 code a bit. It makes no difference on POSIXish platforms but
2784 apparently it fixes a bug on w32.
2785
44e18199 2786 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2787 * fileio.c (close_file_unwind): Don't close if FD is negative;
2788 this can happen when unwinding a zapped file descriptor.
2789 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2790 in case Emacs runs out of memory between the two unwind-protects.
2791 Don't trash errno when closing FD.
2792 Zap the FD in the specpdl when closing it, instead of deferring
2793 the removal of the unwind-protect; this fixes a bug where a child
2794 function unwinds the stack past us.
2795
27e498e6
PE
2796 New unwind-protect flavors to better type-check C callbacks.
2797 This also lessens the need to write wrappers for callbacks,
2798 and the need for make_save_pointer.
2799 * alloca.c (free_save_value):
2800 * atimer.c (run_all_atimers):
2801 Now extern.
2802 * alloc.c (safe_alloca_unwind):
2803 * atimer.c (unwind_stop_other_atimers):
2804 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2805 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2806 * minibuf.c (choose_minibuf_frame_1):
2807 * process.c (make_serial_process_unwind):
2808 * xdisp.h (pop_message_unwind):
2809 * xselect.c (queue_selection_requests_unwind):
2810 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2811 * alloca.c (record_xmalloc):
2812 Prefer record_unwind_protect_ptr to record_unwind_protect with
2813 make_save_pointer.
2814 * alloca.c (Fgarbage_collect):
2815 Prefer record_unwind_protect_void to passing a dummy.
2816 * buffer.c (restore_buffer):
2817 * window.c (restore_window_configuration):
2818 * xfns.c, w32fns.c (do_unwind_create_frame)
2819 New wrapper. All record-unwind uses of wrappee changed.
2820 * buffer.c (set_buffer_if_live):
2821 * callproc.c (call_process_cleanup, delete_temp_file):
2822 * coding.c (code_conversion_restore):
2823 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2824 * editfns.c (save_excursion_restore)
2825 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2826 (save_restriction_restore):
2827 * eval.c (restore_stack_limits, un_autoload):
2828 * fns.c (require_unwind):
2829 * keyboard.c (recursive_edit_unwind, tracking_off):
2830 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2831 * macros.c (pop_kbd_macro, restore_menu_items):
2832 * nsfns.m (unwind_create_frame):
2833 * print.c (print_unwind):
2834 * process.c (start_process_unwind):
2835 * search.c (unwind_set_match_data):
2836 * window.c (select_window_norecord, select_frame_norecord):
2837 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2838 (fast_set_selected_frame):
2839 * xfns.c, w32fns.c (unwind_create_tip_frame):
2840 Return void, not a dummy Lisp_Object. All uses changed.
2841 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2842 * callproc.c (call_process_kill):
2843 * fileio.c (restore_point_unwind, decide_coding_unwind)
2844 (build_annotations_unwind):
2845 * insdel.c (Fcombine_after_change_execute_1):
2846 * keyboard.c (read_char_help_form_unwind):
2847 * menu.c (unuse_menu_items):
2848 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2849 * sound.c (sound_cleanup):
2850 * xdisp.c (unwind_redisplay):
2851 * xfns.c (clean_up_dialog):
2852 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2853 Accept no args and return void, instead of accepting and returning
2854 a dummy Lisp_Object. All uses changed.
2855 * cygw32.c (fchdir_unwind):
2856 * fileio.c (close_file_unwind):
2857 * keyboard.c (restore_kboard_configuration):
2858 * lread.c (readevalllop_1):
2859 * process.c (wait_reading_process_output_unwind):
2860 Accept int and return void, rather than accepting an Emacs integer
2861 and returning a dummy object. In some cases this fixes an
2862 unlikely bug when the corresponding int is outside Emacs integer
2863 range. All uses changed.
2864 * dired.c (directory_files_internal_unwind):
2865 * fileio.c (do_auto_save_unwind):
2866 * gtkutil.c (pop_down_dialog):
2867 * insdel.c (reset_var_on_error):
2868 * lread.c (load_unwind):
2869 * xfns.c (clean_up_file_dialog):
2870 * xmenu.c, nsmenu.m (pop_down_menu):
2871 * xmenu.c (cleanup_widget_value_tree):
2872 * xselect.c (wait_for_property_change_unwind):
2873 Accept pointer and return void, rather than accepting an Emacs
2874 save value encapsulating the pointer and returning a dummy object.
2875 All uses changed.
2876 * editfns.c (Fformat): Update the saved pointer directly via
2877 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2878 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2879 (unwind_body): New function.
2880 (record_unwind_protect): First arg is now a function returning void,
2881 not a dummy Lisp_Object.
2882 (record_unwind_protect_ptr, record_unwind_protect_int)
2883 (record_unwind_protect_void): New functions.
2884 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2885 * fileio.c (struct auto_save_unwind): New type.
2886 (do_auto_save_unwind): Use it.
2887 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2888 * insdel.c (struct rvoe_arg): New type.
2889 (reset_var_on_error): Use it.
2890 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2891 New constants.
2892 (specbinding_func): Remove; there are now several such functions.
2893 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2894 (set_unwind_protect_ptr): New function.
2895 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2896
4e604a5d
PE
2897 Be simpler and more consistent about reporting I/O errors.
2898 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2899 Say "Read error" and "Write error", rather than "I/O error", or
2900 "IO error reading", or "IO error writing", when a read or write
2901 error occurs.
2902 * process.c (Fmake_network_process, wait_reading_process_output)
2903 (send_process, Fprocess_send_eof, wait_reading_process_output):
2904 Capitalize diagnostics consistently. Put "failed foo" at the
2905 start of the diagnostic, so that we don't capitalize the
2906 function name "foo". Consistently say "failed" for such
2907 diagnostics.
2908 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2909 All callers changed. This is so it can use report_file_error.
2910 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2911 diagnostics consistently as above.
2912
a9757f6a
PE
2913 * fileio.c (report_file_errno): Fix errno reporting bug.
2914 If the file name is neither null nor a pair, package it up as a
2915 singleton list. All callers changed, both to this function and to
2916 report_file_error. This fixes a bug where the memory allocator
2917 invoked by list1 set errno so that the immediately following
2918 report_file_error reported the wrong errno value.
2919
c43843aa
PE
2920 Fix minor problems found by --enable-gcc-warnings.
2921 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2922 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2923
18c26d81
JD
29242013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2925
2926 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2927 Set event->arg to Qt if switch-event shall be generated.
2928 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2929
2930 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2931
2932 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2933 FOCUS_OUT_EVENT.
2934
2935 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2936 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2937 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2938 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2939 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2940 and there is a focused frame.
2941 (head_table): Add focus-in and focus-out.
2942 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2943 bind to handle-focus-in/out.
2944
2945 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2946 (Fhandle_switch_frame): Call Fhandle_focus_in.
2947 (syms_of_frame): defsubr handle-focus-in/out.
2948
6c6f1994
PE
29492013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2950
c7ddc792
PE
2951 Fix porting bug to older POSIXish platforms (Bug#14862).
2952 * sysdep.c (emacs_pipe): New function, that implements
2953 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2954 This should port better to CentOS 5 and to Mac OS X 10.6.
2955 All calls to pipe2 changed.
2956
6c6f1994
PE
2957 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2958 This makes the code easier to read and the executable a bit smaller.
2959 Do not replace all calls to Fcons that happen to create lists,
2960 just calls that are intended to create lists. For example, when
2961 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2962 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2963 Similarly for list2 through list5.
2964 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2965 * bytecode.c (exec_byte_code):
2966 * callint.c (quotify_arg, Fcall_interactively):
2967 * callproc.c (Fcall_process, create_temp_file):
2968 * charset.c (load_charset_map_from_file)
2969 (Fdefine_charset_internal, init_charset):
2970 * coding.c (get_translation_table, detect_coding_system)
2971 (Fcheck_coding_systems_region)
2972 (Fset_terminal_coding_system_internal)
2973 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2974 * composite.c (update_compositions, Ffind_composition_internal):
2975 * dired.c (directory_files_internal, file_name_completion)
2976 (Fsystem_users):
2977 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2978 * doc.c (Fsnarf_documentation):
2979 * editfns.c (Fmessage_box):
2980 * emacs.c (main):
2981 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2982 (Feval, eval_sub, Ffuncall, apply_lambda):
2983 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2984 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2985 (Fset_file_times, Finsert_file_contents)
2986 (Fchoose_write_coding_system, Fwrite_region):
2987 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2988 * font.c (font_registry_charsets, font_parse_fcname)
2989 (font_prepare_cache, font_update_drivers, Flist_fonts):
2990 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2991 * frame.c (make_frame, Fmake_terminal_frame)
2992 (x_set_frame_parameters, x_report_frame_params)
2993 (x_default_parameter, Fx_parse_geometry):
2994 * ftfont.c (syms_of_ftfont):
2995 * image.c (gif_load):
2996 * keyboard.c (command_loop_1):
2997 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2998 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2999 (Fminor_mode_key_binding, accessible_keymaps_1)
3000 (Faccessible_keymaps, Fwhere_is_internal):
3001 * lread.c (read_emacs_mule_char):
3002 * menu.c (find_and_return_menu_selection):
3003 * minibuf.c (get_minibuffer):
3004 * nsfns.m (Fns_perform_service):
3005 * nsfont.m (ns_script_to_charset):
3006 * nsmenu.m (ns_popup_dialog):
3007 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3008 (Fx_own_selection_internal):
3009 * nsterm.m (append2):
3010 * print.c (Fredirect_debugging_output)
3011 (print_prune_string_charset):
3012 * process.c (Fdelete_process, Fprocess_contact)
3013 (Fformat_network_address, set_socket_option)
3014 (read_and_dispose_of_process_output, write_queue_push)
3015 (send_process, exec_sentinel):
3016 * sound.c (Fplay_sound_internal):
3017 * textprop.c (validate_plist, add_properties)
3018 (Fput_text_property, Fadd_face_text_property)
3019 (copy_text_properties, text_property_list, syms_of_textprop):
3020 * unexaix.c (report_error):
3021 * unexcoff.c (report_error):
3022 * unexsol.c (unexec):
3023 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3024 (Fformat_mode_line, syms_of_xdisp):
3025 * xfaces.c (set_font_frame_param)
3026 (Finternal_lisp_face_attribute_values)
3027 (Finternal_merge_in_global_face, syms_of_xfaces):
3028 * xfns.c (x_default_scroll_bar_color_parameter)
3029 (x_default_font_parameter, x_create_tip_frame):
3030 * xfont.c (xfont_supported_scripts):
3031 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3032 (menu_help_callback, xmenu_show):
3033 * xml.c (make_dom):
3034 * xterm.c (set_wm_state):
3035 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3036 and similarly for list2 through list5.
3037
bafe80ce
PE
30382013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3039
3040 * callproc.c (Fcall_process_region): Fix minor race and tune.
3041 (create_temp_file): New function, with the temp-file-creation part
3042 of the old Fcall_process_region. Use Fcopy_sequence to create the
3043 temp file name, rather than alloca + build_string, for simplicity.
3044 Don't bother to block input around the temp file creation;
068f9124
SM
3045 shouldn't be needed. Simplify use of mktemp.
3046 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3047 this closes an unlikely race where the temp file was not removed.
3048 Use memcpy rather than an open-coded loop.
3049 (Fcall_process_region): Use the new function. If the input is
3050 empty, redirect from /dev/null rather than from a newly created
3051 empty temp file; this avoids unnecessary file system traffic.
3052
4700b5a5
PE
30532013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3054
5c97beae
PE
3055 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3056 Simplify by making this case like the other two. This is a bit
3057 slower on obsolete hosts, but the extra complexity isn't worth it.
3058
4700b5a5
PE
3059 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3060 * process.c (create_process) [!DOS_NT]:
3061 Remove now-unnecessary calls to emacs_close.
3062
f9a74c4c
EZ
30632013-07-13 Eli Zaretskii <eliz@gnu.org>
3064
922ae7ee
EZ
3065 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3066 returning early. (Bug#14850)
3067
f9a74c4c
EZ
3068 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3069 and inhibit-iso-escape-detection attributes of 'undecided'.
3070 (Bug#14822)
3071
5e301d76
PE
30722013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3073
69e0e5ee
PE
3074 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3075 Reported by Herbert J. Skuhra in
3076 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3077
5e301d76
PE
3078 Don't lose top specpdl entry when memory is exhausted.
3079 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3080 specpdl overflow here, to simplify callers; all callers changed.
3081 Always reserve an unused entry at the stack top; this avoids
3082 losing the top entry's information when memory is exhausted.
3083
7e649856
PE
30842013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3085
a773ed9a
PE
3086 Clean up errno reporting and fix some errno-reporting bugs.
3087 * callproc.c (Fcall_process):
3088 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3089 * process.c (create_process, Fmake_network_process):
3090 * unexaix.c (report_error):
3091 * unexcoff.c (report_error):
3092 Be more careful about reporting the errno of failed operations.
3093 The code previously reported the wrong errno sometimes.
3094 Also, prefer report_file_errno to setting errno + report_file_error.
3095 (Fcall_process): Look at openp return value rather than at path,
3096 as that's a bit faster and clearer when there's a numeric predicate.
3097 * fileio.c (report_file_errno): New function, with most of the
3098 old contents of report_file_error.
3099 (report_file_error): Use it.
3100 (Ffile_exists_p, Ffile_accessible_directory_p):
3101 Set errno to 0 when it is junk.
3102 * fileio.c (Faccess_file):
3103 * image.c (x_create_bitmap_from_file):
3104 Use faccessat rather than opening the file, to avoid the hassle of
3105 having a file descriptor open.
3106 * lisp.h (report_file_errno): New decl.
3107 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3108
7e649856
PE
3109 Minor EBADF fixes.
3110 * process.c (create_process, wait_reading_process_output) [AIX]:
3111 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3112 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3113 a multithreaded environment anyway).
3114 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3115
f6774c1a
AS
31162013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3117
3118 * image.c (x_find_image_file): Don't close a remote file handle.
3119
bacba3c2
PE
31202013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 Fix races with threads and file descriptors.
3123 * callproc.c (Fcall_process_region):
3124 * dired.c (open_directory):
3125 * emacs.c (main, Fdaemon_initialized):
3126 * image.c (x_find_image_file):
3127 * inotify.c (Finotify_rm_watch):
3128 * lread.c (Flocate_file_internal):
3129 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3130 * term.c (term_mouse_moveto, init_tty):
3131 * termcap.c (tgetent):
3132 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3133 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3134 * unexhp9k800.c, unexmacosx.c (unexec):
3135 * callproc.c (Fcall_process_region):
3136 Use emacs_close, not close.
3137 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3138 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3139 and posix_close function on current platforms (which all lack them).
3140 (emacs_close): Use it. This should fix the races on GNU/Linux and
3141 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3142 and it should avoid closing random victim file descriptors on
3143 other platforms.
3144
653d4f43
PE
31452013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3146
c8536ec4
PE
3147 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3148 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3149 Touch up doc a bit.
3150
9c203066
PE
3151 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3152 This is for .gdbinit xbacktrace.
3153
653d4f43
PE
3154 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3155 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3156 (emacs_set_tty): Now static.
3157 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3158 * term.c (tty_capable_p, tty_default_color_capabilities)
3159 (get_tty_terminal, term_mouse_movement)
3160 (handle_one_term_event, init_tty, maybe_fatal):
3161 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3162 (tgetent, scan_file, name_match, compare_contin):
3163 * terminal.c (get_terminal):
3164 Use bool for boolean.
3165 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3166 Prefer char to unsigned char if either will do.
3167 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3168 (tty_write_glyphs): Prefer int to unsigned.
3169 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3170 All callers changed.
3171 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3172
45b683a1
PE
31732013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3174
29abe551
PE
3175 Port to C89.
3176 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3177 (B__dummy__): New dummy symbol, to pacify C89.
3178 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3179 they can't grok varargs macros.
3180 * dispnew.c (add_window_display_history)
3181 (add_frame_display_history):
3182 * print.c (print_object):
3183 * xdisp.c (debug_method_add):
3184 Use %p printf format only for void pointers.
3185 * emacs.c (usage_message): New constant, replacing ...
3186 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3187 (main): Adjust to usage reorg.
3188 * fns.c (syms_of_fns):
3189 * profiler.c (syms_of_profiler):
3190 Don't use non-constant struct initializers.
3191 * gnutls.h (gnutls_initstage_t):
3192 * lisp.h (enum Lisp_Fwd_Type):
3193 * lread.c (lisp_file_lexically_bound_p):
3194 * xsettings.c (anonymous enum):
3195 Remove trailing comma.
3196 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3197 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3198 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3199 (DEFUN): Use it.
3200 * regex.c (const_re_char): New type, to pacify strict C89.
3201 All uses of 'const re_char' replaced to use it.
3202 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3203 with glibc when strict C89. This change is imported from gnulib.
3204 All uses changed.
3205 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3206 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3207 Omit GNU_LINUX implementation, since it requires long long.
3208 * xterm.c (x_draw_underwave):
3209 Do not assume the traditional order of struct's members.
3210 (x_term_init): Rewrite to avoid the need for non-constant structure
3211 initializers.
3212
45b683a1 3213 Syntax cleanup, mostly replacing macros with functions.
763a086d 3214 This removes the need for the syntax_temp hack.
45b683a1
PE
3215 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3216 * syntax.c (SYNTAX_INLINE): New macro.
3217 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3218 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3219 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3220 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3221 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3222 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3223 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3224 Now constants, not macros.
3225 (syntax_temp) [!__GNUC__]: Remove.
3226 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3227 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3228 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3229 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3230 Move here from syntax.h; now functions, not macros. Except for the
3231 last function, these are static since only syntax.c uses them.
3232 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3233 All uses changed. Now a function, not a macro; use this fact
3234 to simplify the code.
3235 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3236 compiler bugs; no longer relevant.
3237 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3238 (SYNTAX_INLINE): New macro.
3239 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3240 for the new functions. Use bool for boolean member.
3241 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3242 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3243 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3244 (SETUP_BUFFER_SYNTAX_TABLE):
3245 Now extern inline functions, not macros.
3246 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3247 Remove; all uses replaced by implementation.
3248 (syntax_temp) [!__GNUC__]: Remove decl.
3249 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3250
29be4a50
JD
32512013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3252
3253 * emacs.c (main): Fix syntax error.
3254
954b166e
PE
32552013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3256
3257 Timestamp fixes for undo (Bug#14824).
3258 * atimer.c (schedule_atimer):
3259 * fileio.c (Ffile_newer_than_file_p):
3260 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3261 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3262 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3263 (syms_of_fileio): Remove Sclear_visited_file_name.
3264 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3265 file doesn't exist; this avoids an ambiguity with negative timestamps.
3266 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3267 * systime.h (make_emacs_time, invalid_emacs_time):
3268 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3269 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3270 * undo.c (record_first_change): Push (visited-file-modtime) onto
3271 undo list rather than reimplementing it by hand, incorrectly.
3272
d74647c3
KB
32732013-07-09 Ken Brown <kbrown@cornell.edu>
3274
3275 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3276
3c51b96b
JB
32772013-07-09 Juanma Barranquero <lekktu@gmail.com>
3278
3279 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3280
4ebbdd67
PE
32812013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3282
3283 Handle errno and exit status a bit more carefully.
3284 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3285 number into an exit status. Instead, use EXIT_CANCELED.
3286 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3287 * callproc.c (relocate_fd):
3288 * emacs.c (close_output_streams, main):
3289 * process.c (create_process):
3290 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3291 Use emacs_perror for simplicity.
3292 * callproc.c (relocate_fd, main):
3293 * sysdep.c (sys_subshell):
3294 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3295 (shut_down_emacs): Use emacs_write, not write.
3296 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3297 * fileio.c (Fcopy_file, e_write):
3298 * nsterm.m (ns_select):
3299 * process.c (send_process):
3300 * sound.c (vox_write):
3301 Use emacs_write_sig, not emacs_write.
3302 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3303 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3304 New constants.
3305 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3306 of write.
3307 (emacs_full_write): New function.
3308 (emacs_write): Rewrite to use it.
3309 (emacswrite_sig, emacs_perror): New functions.
3310 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3311
44e18199 33122013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3313
3314 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3315 on NS even if it is present. Pixmap on NS is a void*.
3316
9caab067
PE
33172013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 Port to Ubuntu 10 (Bug#14803).
3320 Problem reported by T.V. Raman.
3321 * process.c (close_on_exec, accept4, process_socket):
3322 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3323
1d442672
EZ
33242013-07-07 Eli Zaretskii <eliz@gnu.org>
3325
3326 * w32.c (sys_dup): Declare prototype.
3327
3328 * filelock.c:
3329 * emacs.c:
3330 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3331
067428c1
PE
33322013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3333
3334 Make file descriptors close-on-exec when possible (Bug#14803).
3335 This simplifies Emacs a bit, since it no longer needs to worry
3336 about closing file descriptors by hand in some cases.
3337 It also fixes some unlikely races. Not all such races, as
3338 libraries often open files internally without setting
3339 close-on-exec, but it's an improvement.
3340 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3341 * callproc.c (Fcall_process) [!MSDOS]:
3342 * emacs.c (main) [!DOS_NT]:
3343 * nsterm.m (ns_term_init):
3344 * process.c (create_process):
3345 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3346 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3347 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3348 Prefer mkostemp with O_CLOEXEC to mkstemp.
3349 * callproc.c (relocate_fd) [!WINDOWSNT]:
3350 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3351 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3352 now using pipe2.
3353 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3354 Make the resulting file descriptor close-on-exec.
3355 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3356 * lread.c (load_descriptor_list, load_descriptor_unwind):
3357 Remove; no longer needed. All uses removed.
3358 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3359 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3360 New functions.
3361 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3362 (Fmake_network_process, Fnetwork_interface_list):
3363 (Fnetwork_interface_info, server_accept_connection):
3364 Make newly-created socket close-on-exec.
3365 * sysdep.c (emacs_open, emacs_fopen):
3366 Make new-created descriptor close-on-exec.
3367 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3368 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3369
0da857dd
JD
33702013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3371
3372 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3373 for NS_IMPL_GNUSTEP.
3374
5f86adcd
PE
33752013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 Fix openp errno handling.
3378 * callproc.c (Fcall_process): Preserve openp errno around close.
3379 * lread.c (openp): Set errno when returning -1, as some callers
3380 expect this.
3381
1afb1d07
JD
33822013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3383
3384 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3385
3386 * nsterm.h (NSSavePanel): Update comment.
3387 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3388 (ns_run_file_dialog): Declare.
3389
3390 * nsfns.m: Remove panelOK.
3391 (ns_fd_data): New.
3392 (ns_run_file_dialog): New function.
3393 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3394 event loop, so file dialog is popped up by ns_run_file_dialog, called
3395 by sendEvent (Bug#14578).
3396 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3397
3323c263
EZ
33982013-07-06 Eli Zaretskii <eliz@gnu.org>
3399
fdda0220
EZ
3400 * xdisp.c (default_line_pixel_height): New function.
3401 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3402 (try_cursor_movement, redisplay_window, try_window)
3403 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3404
068f9124
SM
3405 * window.c (window_scroll_pixel_based):
3406 use default_line_pixel_height.
fdda0220
EZ
3407
3408 * dispextern.h (default_line_pixel_height): Add prototype.
3409
3410 * frame.c (x_set_line_spacing): Accept a float value for
3411 line-spacing parameter, per the documentation.
3412
3323c263
EZ
3413 * data.c (Fmultibyte_string_p): Doc fix.
3414
47ba6d43
PE
34152013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3416
406af475
PE
3417 Use emacs_open more consistently when opening files.
3418 This handles EINTR more consistently now, and makes it easier
3419 to introduce other uniform changes to file descriptor handling.
3420 * src/systdio.h: New file.
3421 * src/buffer.c (mmap_init):
3422 * cygw32.c (chdir_to_default_directory):
3423 * dispnew.c (Fopen_termscript):
3424 * emacs.c (Fdaemon_initialized):
3425 * fileio.c (Fdo_auto_save):
3426 * image.c (slurp_file, png_load_body, jpeg_load_body):
3427 * keyboard.c (Fopen_dribble_file):
3428 * lread.c (Fload):
3429 * print.c (Fredirect_debugging_output):
3430 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3431 * termcap.c (tgetent):
3432 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3433 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3434 * w32term.c (w32_initialize) [CYGWIN]:
3435 * xfaces.c (Fx_load_color_file):
3436 Use emacs_open instead of plain open, and emacs_fopen instead of
3437 plain fopen.
3438 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3439 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3440 * callproc.c (default_output_mode): New constant.
3441 (Fcall_process): Use it to call emacs_open instead of plain creat.
3442 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3443 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3444 (emacs_fopen): New function.
3445 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3446 Include <lisp.h>, for emacs_open.
3447 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3448
47ba6d43
PE
3449 Remove duplicate #include directives.
3450 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3451 * xfaces.c:
3452 Don't include stdio.h twice.
3453 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3454 Don't include sys/types.h or stdio.h twice.
3455 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3456 * lread.c: Don't include coding.h twice.
3457 * nsfont.m: Don't include frame.h twice.
3458 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3459 * ralloc.c: Don't include <unistd.h> twice.
3460 * xdisp.c: Don't include font.h twice.
3461 * xterm.c: Don't include fontset.h twice.
3462 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3463
b9ed53d5
PE
34642013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3465
3466 Scale ImageMagick images more carefully.
3467 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3468 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3469 Be more careful about avoiding undefined behavior after
3470 integer overflow and division by zero.
3471
cf13177e
YM
34722013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3473
3474 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3475 (syms_of_w32fns): DEFSYM them.
3476 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3477 (CCHDEVICENAME): Define macros if not defined.
3478 (struct MONITOR_INFO_EX): New struct.
3479 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3480 (enum_display_monitors_fn): New variable.
3481 (globals_of_w32fns): Initialize it.
3482 (Fx_display_pixel_width, Fx_display_pixel_height)
3483 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3484 multi-monitor setups in docstrings.
3485 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3486 screen size by primary monitor's millimeter per pixel.
3487 (w32_monitor_enum, w32_display_monitor_attributes_list)
3488 (w32_display_monitor_attributes_list_fallback)
3489 (Fw32_display_monitor_attributes_list): New functions.
3490 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3491
3492 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3493 if not defined.
3494 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3495
86dfb7a8
MA
34962013-07-04 Michael Albinus <michael.albinus@gmx.de>
3497
3498 * fileio.c (Qfile_notify_error): New error symbol.
3499
3500 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3501 * inotify.c (inotify_callback, symbol_to_inotifymask)
3502 (Finotify_add_watch, Finotify_rm_watch): Use it.
3503 (inotifyevent_to_event): Exchange order of cookie and file name.
3504 (Finotify_add_watch): Adapt docstring.
3505
3506 * lisp.h (Qfile_notify_error): Declare.
3507
2c1c974b
PE
35082013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3509
3510 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3511 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3512 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3513 which did not work (see <http://bugs.gnu.org/14569#307>).
3514 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3515 && (!noninteractive || initialized)). This attempts to thread
3516 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3517
7a35b20f
JB
35182013-07-04 Juanma Barranquero <lekktu@gmail.com>
3519
3520 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3521 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3522
1ce5cd04
PE
35232013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3526 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3527 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3528 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3529
57f8c490
PE
35302013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3531
3532 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3533 Define to __sys_siglist.
3534
bcffb5ca
EZ
35352013-07-02 Eli Zaretskii <eliz@gnu.org>
3536
3537 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3538 word-wrap, so that overflow-newline-into-fringe would work in
3539 visual-line-mode. (Bug#2749)
3540 (move_it_in_display_line_to): When the last scanned display
3541 element fits exactly on the display line, and
3542 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3543 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3544 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3545 finding buffer position that corresponds to pixel coordinates,
3546 e.g. in buffer_posn_from_coords.
3547
2c41e781
JD
35482013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3549
3550 * process.c (handle_child_signal): Call catch_child_signal if
3551 NS_IMPL_GNUSTEP.
3552
c2418359
PE
35532013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3554
52a9bcae
PE
3555 Don't convert function pointers to void * and back.
3556 It isn't portable C, and it's easy enough to avoid.
3557 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3558 (make_save_value): Add support for SAVE_FUNCPOINTER.
3559 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3560 * print.c (print_object):
3561 Distinguish function from object pointers.
3562 * lisp.h (SAVE_FUNCPOINTER): New constant.
3563 (SAVE_SLOT_BITS): Adjust to it.
3564 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3565 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3566 (voidfuncptr): New typedef.
3567 (struct Lisp_Save_Value): New member data[0].funcpointer.
3568 (XSAVE_FUNCPOINTER): New function.
3569
c2418359
PE
3570 Simplify buildobj processing.
3571 * Makefile.in (buildobj.h): Make it a sequence of strings each
3572 followed by comma, rather than a single string. Put it into a
3573 .tmp file in case there's an error while generating it.
3574 (gl-stamp): Use .tmp for temp files.
3575 (mostlyclean): Clean .tmp files.
3576 * doc.c (buildobj): Move to just the routine that needs it.
3577 It's now an array of strings, so processing is simpler.
3578
8f43ce49
PE
35792013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3580
3581 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3582 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3583 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3584 Invoke malloc_enable_thread even when not interactive.
3585 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3586 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3587 in this case, since the underlying bug has now been fixed.
3588
24827db9
JB
35892013-07-01 Juanma Barranquero <lekktu@gmail.com>
3590
3591 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3592 unlinking it (bug#14691).
3593
ef099a94
MN
35942013-06-30 Michal Nazarewicz <mina86@mina86.com>
3595
3596 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3597 before checking whether buffer is modified. This lets
3598 `kill-buffer-query-functions' cancel killing of the buffer or save
3599 its content before `kill-buffer' asks user the "Buffer %s
3600 modified; kill anyway?" question.
3601
9d3f2fc2
JD
36022013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3603
3604 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3605 Let the super performKeyEquivalent deal with them (Bug#14747).
3606
e6c6c8c7
PE
36072013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3608
1d71c1d9
PE
3609 * widget.c (resize_cb): Remove unused local.
3610
8f5f35cc
PE
3611 Do not use GTK 3 if it exists but cannot be compiled.
3612 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3613 * xterm.c (x_error_handler) [!USE_GTK]:
3614 Do not use GTK 3.
3615
e6c6c8c7
PE
3616 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3617
0ba54312
EZ
36182013-06-30 Eli Zaretskii <eliz@gnu.org>
3619
5d1c3286
EZ
3620 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3621 to the valid range of values. (Bug#14753)
3622
0ba54312
EZ
3623 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3624 when moving point by using the current glyph matrix. This avoids
3625 the need to force redisplay when this function is called in a
3626 loop.
3627
9c90cc06
PE
36282013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Fix minor problems found by static checking.
3631 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3632 Redo the latter's body to sidestep GCC parenthesization warnings.
3633 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3634 * coding.c (detect_coding, detect_coding_system):
3635 * coding.h (struct undecided_spec):
3636 Use bool for boolean.
3637 * image.c (QCmax_width, QCmax_height): Now static.
3638 * xdisp.c (Fmove_point_visually): Remove unused local.
3639
4c672a0f
EZ
36402013-06-29 Eli Zaretskii <eliz@gnu.org>
3641
3642 * xdisp.c (Fmove_point_visually): New function.
3643
c1ea3abf
JB
36442013-06-28 Kenichi Handa <handa@gnu.org>
3645
3646 * coding.h (define_coding_undecided_arg_index): New enum.
3647 (coding_attr_index): New members
3648 coding_attr_undecided_inhibit_null_byte_detection,
3649 coding_attr_undecided_inhibit_iso_escape_detection,
3650 coding_attr_undecided_prefer_utf_8.
3651 (undecided_spec): New struct.
3652 (struct coding_system): New member `undecided' of the member
3653 `spec'.
3654
3655 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3656 (detect_coding): Likewise.
3657 (detect_coding_system): Likewise.
3658 (Fdefine_coding_system_internal): New coding system properties
3659 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3660 :prefer-utf-8.
3661 (syms_of_coding): Adjust for coding_arg_undecided_max.
3662
ba3de9e6
PE
36632013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3664
3665 * image.c (x_from_xcolors): Remove unused local.
3666
547c9269
YM
36672013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3668
3669 Defer image data transfer between X client and server until actual
3670 display happens.
3671
3672 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3673 and `mask_img'.
3674
3675 * image.c (Destroy_Image): Remove.
3676 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3677 `mask_p', and `colors_p'. All uses changed.
3678 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3679 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3680 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3681 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3682 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3683 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3684 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3685 (image_get_x_image, image_unget_x_image): New functions or macros.
3686 (image_background, image_background_transparent, x_to_xcolors)
3687 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3688 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3689 instead of Destroy_Image.
3690 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3691 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3692 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3693 (imagemagick_load_image, svg_load_image): Use them instead of
3694 x_create_x_image_and_pixmap, and x_put_x_image followed by
3695 x_destroy_x_image, respectively.
3696 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3697 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3698 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3699 background_transparent fields.
3700 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3701 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3702
dae2f5ef
PE
37032013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3704
3705 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3706 This mostly consists of undoing recent changes.
3707 * callproc.c (Fcall_process):
3708 * process.c (create_process):
3709 Do not worry about catching SIGCHLD here, undoing previous change.
3710 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3711 * process.c, process.h (catch_child_signal):
3712 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3713 * process.c (catch_child_handler): Don't worry about being called
3714 lazily and do not assume caller has blocked SIGCHLD, undoing
3715 previous change. Move first-time stuff back to
3716 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3717 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3718 set lib_child_handler if it's already initialized, which may
3719 help avoid problems on GNUStep.
3720
fa55d2aa
PE
37212013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3722
3723 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3724 * callproc.c (Fcall_process):
3725 * process.c (create_process):
3726 Make sure SIGCHLD is caught before we fork,
3727 since Emacs startup no arranges to catch SIGCHLD.
3728 * process.c (lib_child_handler): Initialize to null, not to
3729 dummy_handler.
3730 (catch_child_signal): Allow self to be called lazily.
3731 Do nothing if it's already been called.
3732 Assume caller has blocked SIGCHLD (all callers do now).
3733 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3734 just before it's really needed.
3735 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3736 since it hasn't been caught yet.
3737
f3f9606c
LMI
37382013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3739
3740 * image.c (compute_image_size): New function to implement
3741 :max-width and :max-height.
3742 (imagemagick_load_image): Use it.
3743
c7041908
PE
37442013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3745
3746 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3747 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3748 Now extern.
3749 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3750 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3751 the SIGCHLD handler, since the code is not atomic and (due to glib)
3752 signals may be arriving now.
3753 * sysdep.c (init_signals): Do not catch child signals here;
3754 'main' now does that later, at a safer time.
3755
f86852b4
PE
37562013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3757
0dfeed58
PE
3758 Clean up SIGCHLD handling a bit (Bug#14569).
3759 * process.c, process.h (catch_child_signal):
3760 Now always extern, even if !NS_IMPL_GNUSTEP.
3761 * process.c (catch_child_signal): Move glib tickler here from
3762 init_process_emacs, so that it's done earlier in Emacs
3763 initialization. Also move the noninteractive && !initialized
3764 check here from init_process_emacs. This is all a bit cleaner for
3765 GNUish platforms, and I hope it works around the Cygwin bug.
3766 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3767 that glib signal handling is tickled before glib creates threads.
3768
f86852b4
PE
3769 * process.c (wait_reading_process_output): Avoid int overflow
3770 when reading more than 2 GiB total from a process.
3771
cbd6509c
PE
37722013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3773
3774 * process.c (create_process): Handle a couple more cases,
3775 i.e., work even if new_argv and wait_child_setup[i] are cached.
3776 Use Fcall_process's style for volatile vars.
3777
9de1114a
AS
37782013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3779
3780 * process.c (create_process): Mark PROCESS volatile.
3781
fbe9e0b9
PE
37822013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 Use C99-style flexible array members if available.
3785 This avoids some subtle aliasing issues, which typically
3786 aren't a problem with GCC but may be a problem elsewhere.
3787 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3788 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3789 In either case, it uses a flexible array member rather than
3790 the old struct hack. All uses changed.
3791 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3792 Adjust to sdata reorganization.
3793 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3794 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3795 that ports better to pre-C99 non-GCC.
3796 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3797 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3798 as the latter has changed.
3799 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3800 and port better to pre-C99 GCC.
3801 * image.c (struct xpm_cached_color):
3802 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3803 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3804 Use FLEXIBLE_ARRAY_MEMBER.
3805 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3806 Move decl to top level so it gets checked against implementation.
3807 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3808 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3809
1fc71008
PE
38102013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 * syntax.c: Integer cleanups.
3813 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3814 All uses that need 0-or-2 changed to:
3815 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3816 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3817 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3818 (char_quoted, prev_char_comend_first, back_comment)
3819 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3820 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3821 Use bool for boolean.
3822 (update_syntax_table, skip_chars, skip_syntaxes):
3823 Prefer int to unsigned when either will do.
3824 (back_comment): Return boolean success flag, like forw_comment,
3825 instead of positive-or-minus-1 (which might have overflowed int anyway).
3826 Don't stuff ptrdiff_t into int.
3827 (syntax_spec_code, syntax_code_spec): Now const.
3828 (Fmatching_paren, scan_lists, scan_sexps_forward):
3829 Use enum syntaxcode for syntax code.
3830 (Fmatching_paren): Check that arg is a character, not just an integer.
3831 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3832 (Finternal_describe_syntax_value): Omit no-longer-needed
3833 comparison to 0.
3834 (skip_chars): Use char, not unsigned char, when the distinction
3835 doesn't matter.
3836 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3837 * bytecode.c (exec_byte_code):
3838 * syntax.c (syntax_spec_code, Fchar_syntax)
3839 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3840 (init_syntax_once):
3841 * syntax.h (SYNTAX_WITH_FLAGS):
3842 Omit unnecessary casts.
3843
b932cad7
EZ
38442013-06-20 Eli Zaretskii <eliz@gnu.org>
3845
3846 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3847 line dimensions here, to avoid race conditions with the main
3848 thread. (Bug#14062, bug#14630, bug#14669)
3849
3850 * w32term.c (w32_draw_window_cursor): Compute the header line and
3851 mode line dimensions here.
3852 <w32_system_caret_window, w32_system_caret_hdr_height>:
3853 <w32_system_caret_mode_height>: New variables.
3854
3855 * w32term.h: Declare them.
3856
89561f72
PE
38572013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3858
5013fc08
PE
3859 * alloc.c (die): Move "assertion failed" string here ...
3860 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3861 COND when SUPPRESS_CHECKING. This shrinks the executable text
3862 size by 0.8% to 2.2% when configured with --enable-checking,
3863 depending on optimization flags (GCC 4.8.1 x86-64).
3864
89561f72
PE
3865 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3866
763a086d 38672013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3868
3869 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3870 base is 2; this is more accurate.
3871
983aeb9a
JB
38722013-06-19 Juanma Barranquero <lekktu@gmail.com>
3873
3874 * sound.c (string_default): Move to !WINDOWSNT section.
3875 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3876
178ba3e6
PE
38772013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3878
bbc51b15
PE
3879 * sound.c: Integer cleanups.
3880 Remove unnecessary forward decls.
3881 (struct sound_device): The 'file' member is now a Lisp_Object, not
3882 a char *, so that we needn't invoke alloca on a huge size.
3883 (Fplay_sound_internal): Adjust to this.
3884 (string_default): New function.
3885 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3886 Use it to adjust to the struct sound_device change.
3887 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3888 (be2hs) [0]: Remove.
3889
178ba3e6
PE
3890 * syntax.c (skip_chars): Don't use uninitialized storage
3891 when searching a multibyte buffer for characters that are not in a
3892 unibyte string that contains non-ASCII characters.
3893
69f60cdc
JD
38942013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3895
3896 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3897 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3898
0d6224d4
PE
38992013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3900
3901 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3902
3c542890
KH
39032013-06-18 Kenichi Handa <handa@gnu.org>
3904
f7e3f7cd
KH
3905 * font.c (Ffont_spec): Signal an error for an invalid font name
3906 (Bug#14648).
3c542890 3907
9349e5f7
PE
39082013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3909
3910 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3911 In particular this ports to 32-bit sparc Sun cc.
3912 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3913 array with a dummy element at specpdl[-1], so that its address can
3914 be taken portably.
3915 (unbind_to): Do not copy the binding; not needed, now that we
3916 copy old_value in the one place where the copy is needed.
3917 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3918 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3919 (union specbinding): Rename from struct specbinding. Redo layout
3920 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3921 which is not portable. With Sun C 5.12 32-bit sparc, the
3922 declaration causes nargs to be an unsigned bitfield, a behavior
3923 that the C standard allows; but Emacs wants nargs to be signed.
3924 The overall type is now a union of structures rather than a
3925 structure of union of structures, and the 'kind' member is now a
3926 bitfield, so that the overall type doesn't grow. All uses changed.
3927 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3928
0a4df6a5
PE
39292013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3930
ec6ecaad
PE
3931 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3932 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3933
0a4df6a5
PE
3934 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3935
7bfe8dbc
EZ
39362013-06-17 Eli Zaretskii <eliz@gnu.org>
3937
3938 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3939 unless we know that the window w's frame is a frame object.
3940 Another attempt at solving bug#14062 and bug#14630.
3941
708e05f6
LMI
39422013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3943
3944 * textprop.c (property_set_type): New enum.
3945 (add_properties): Allow appending/prepending text properties.
3946 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3947 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3948 add_text_properties_1.
3949 (Fadd_face_text_property): New function that calls
3950 add_text_properties_1.
3951
84575e67
PE
39522013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 Move functions from lisp.h to individual modules when possible.
3955 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3956 * alloc.c (XFLOAT_INIT, set_symbol_name):
3957 * buffer.c (CHECK_OVERLAY):
3958 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3959 (set_char_table_parent):
3960 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3961 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3962 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3963 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3964 (set_blv_valcell):
3965 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3966 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3967 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3968 (backtrace_args, backtrace_debug_on_exit):
3969 * floatfns.c (CHECK_FLOAT):
3970 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3971 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3972 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3973 (set_hash_index_slot):
3974 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3975 * marker.c (CHECK_MARKER):
3976 * textprop.c (CHECK_STRING_OR_BUFFER):
3977 * window.c (CHECK_WINDOW_CONFIGURATION):
3978 Move here from lisp.h, and make these functions static rather than
3979 extern inline.
3980 * buffer.c (Qoverlayp):
3981 * data.c (Qsubrp):
3982 * fns.c (Qhash_table_p):
3983 * window.c (Qwindow_configuration_p):
3984 Now static.
3985 * lisp.h: Remove the abovementioned defns and decls.
3986
44e18199 3987 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3988 In lisp.h, prefer functions to function-like macros, and
3989 constants to object-like macros, when either will do. This:
3990 . simplifies use, as there's no more need to worry about
3991 arguments' side effects being evaluated multiple times.
3992 . makes the code easier to debug on some platforms.
3993 However, when using gcc -O0, keep using function-like macros
3994 for a few critical operations, for performance reasons.
3995 This sort of thing isn't needed with gcc -Og, but -Og
3996 is a GCC 4.8 feature and isn't widely-enough available yet.
3997 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3998 Remove enum lsb_bits; no longer needed.
3999 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4000 * buffer.c (Qoverlap):
4001 * data.c (Qsubrp):
4002 * fns.c (Qhash_table_p):
4003 Now extern, so lisp.h can use these symbols.
4004 * dispextern.h: Include character.h, for MAX_CHAR etc.
4005 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4006 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4007 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4008 (GLYPH_CODE_P): Move here from lisp.h.
4009 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4010 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4011 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4012 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4013 XUNTAG now returns void *.
4014 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4015 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4016 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4017 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4018 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4019 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4020 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4021 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4022 New macros, renamed from their sans-lisp_h_ counterparts.
4023 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4024 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4025 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4026 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4027 If compiling via GCC without optimization, define these as macros
4028 in addition to inline functions.
4029 To disable this, compile with -DINLINING=0.
4030 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4031 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4032 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4033 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4034 (INTMASK, VALMASK): Now macros, since static values cannot be
4035 accessed from extern inline functions.
4036 (VALMASK): Also a constant, for benefit of old GDB.
4037 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4038 is INTEGERP, which can fold it in.
5165d44a 4039 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4040 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4041 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4042 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4043 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4044 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4045 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4046 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4047 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4048 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4049 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4050 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4051 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4052 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4053 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4054 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4055 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4056 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4057 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4058 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4059 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4060 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4061 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4062 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4063 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4064 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4065 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4066 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4067 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4068 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4069 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4070 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4071 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4072 Now functions.
4073 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4074 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4075 (VALMASK): Define in one place rather than in two, merging the
4076 USE_LSB_TAG parts; this is simpler.
4077 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4078 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4079 Move up, to avoid use before definition.
4080 Also include "globals.h" earlier, for the same reason.
4081 (make_natnum): New function.
4082 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4083 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4084 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4085 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4086 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4087 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4088 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4089 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4090 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4091 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4092 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4093 (Qwindow_configuration_p, Qimage): New forward declarations.
4094 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4095 (STRING_COPYIN): Remove; unused.
4096 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4097 (xcar_addr, xcdr_addr): New functions. All uses changed.
4098 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4099 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4100 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4101 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4102 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4103 (TYPE_RANGED_INTEGERP): Simplify.
4104 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4105 (setlocale, fixup_locale, synchronize_system_messages_locale)
4106 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4107 Now empty functions, not macros.
4108 (functionp): Return bool, not int.
4109 * window.c (Qwindow_configuration_p): Now extern,
4110 so window.h can use it.
4111 * window.h (Qwindowp): Move decl back to lisp.h.
4112
9583ec36
EZ
41132013-06-15 Eli Zaretskii <eliz@gnu.org>
4114
4115 * xdisp.c (Fline_pixel_height): New function, required for solving
4116 bug #14567.
4117
210272ce
PE
41182013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4121
de0503df
SM
41222013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4123
4124 * lread.c (syms_of_lread):
4125 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4126
afbfe143
KD
41272013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4128
4129 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4130
d177e213
XF
41312013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4132
4133 * fileio.c (expand_file_name): Doc fix.
4134
05e3e412
PE
41352013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4136
f7394b12
PE
4137 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4138 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4139 Wait for self, not for 0. This can't hurt on GNU or similar
4140 system, and may help with Cygwin.
4141
05e3e412
PE
4142 * keyboard.c: Don't use PROP (...) as an lvalue.
4143 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4144 Use set_prop (A, B), not PROP (A) = B.
4145
17dd3097
EZ
41462013-06-10 Eli Zaretskii <eliz@gnu.org>
4147
4148 * xdisp.c (get_it_property): Use it->window instead of generating
4149 a Lisp object from it->w.
4150
52fab9c9
EZ
41512013-06-09 Eli Zaretskii <eliz@gnu.org>
4152
4153 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4154 get-char-property the window that is being rendered, instead of
4155 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4156 (compute_display_string_pos): When W is NULL, use the current
4157 buffer as the object to pass to get-char-property.
4158 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4159 pointer member of the bidi iterator, since no window is pertinent
4160 to this function.
52fab9c9 4161
5bf97bfc
EZ
41622013-06-08 Eli Zaretskii <eliz@gnu.org>
4163
4164 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4165 being displayed, and pass it to compute_display_string_pos.
4166 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4167 (bidi_paragraph_init): All callers changed.
4168
4169 * xdisp.c (init_from_display_pos, init_iterator)
4170 (handle_single_display_spec, next_overlay_string)
4171 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4172 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4173 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4174 (compute_display_string_pos): Accept additional argument, the
4175 window being displayed, and pass it to Fget_char_property.
4176 (Bug#14575)
4177
4178 * dispextern.h (struct bidi_it): New member w, the window being
4179 displayed.
4180 (compute_display_string_pos): Adjust prototype.
4181
5de0e011
JD
41822013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4183
e7b41c4c 4184 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4185
4186 * process.c (wait_reading_process_output): Check for NS before GLIB.
4187 GLIB may be linked in due to rsvg, but ns_select must be called.
4188
5de0e011
JD
4189 * xgselect.c (xg_select): Remove call to window_system_available
4190 and g_main_context_pending at the top, so Gdk events (i.e. file
4191 notify) are processed when Emacs is started with -nw.
4192
a822acff
EZ
41932013-06-07 Eli Zaretskii <eliz@gnu.org>
4194
4195 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4196 (ctagsfiles3): New variable, includes only *.m files.
4197 (TAGS): Use an explicit language name in the regular expressions,
4198 to avoid transformation of '/SOMETHING' by MSYS to
4199 'c:\MSYS\SOMETHING'.
4200
6c0a9ed1
RC
42012013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4202
4203 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4204
9ef6111b
EZ
42052013-06-06 Eli Zaretskii <eliz@gnu.org>
4206
4207 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4208 still need to set the mouse pointer shape and activate help-echo.
4209 (Bug#14558)
4210
7d300d64
PE
42112013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 A few porting etc. fixes for the new file monitor code.
4214 See the thread containing
4215 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4216 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4217 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4218 (dir_monitor_callback, Fgfile_rm_watch):
4219 Use assq_no_quit instead of Fassoc, for speed.
4220 (dir_monitor_callback, Fgfile_rm_watch):
4221 eassert that the monitor is a fixnum.
4222 (dir_monitor_callback): No need for CDR_SAFE.
4223 Simplify building of lisp with alternative tails.
4224 (Fgfile_add_watch, Fgfile_rm_watch):
4225 Do not assume glib functions set errno reliably on failure.
4226 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4227 and signal an error otherwise.
4228 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4229 Use Fdelq instead of Fdelete, for speed.
4230
817ebfcf
EZ
42312013-06-05 Eli Zaretskii <eliz@gnu.org>
4232
4233 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4234 don't insist on being invoked on a highlighted tool-bar button.
4235 Avoids losing tool-bar functionality when mouse-highlight is nil.
4236 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4237 Don't highlight when mouse-highlight is nil.
4238 (note_mouse_highlight): When mouse-highlight is nil, don't return
4239 right away; instead, run tool-bar and mode-line highlight
4240 subroutine, clear any existing highlight, and revert the mouse
4241 pointer to its default shape. (Bug#14558)
4242
55577e7c
SM
42432013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 * lisp.mk (lisp): Add prog-mode.el.
4246
f019a684
PE
42472013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4250 * process.c (dummy_handler): New function.
4251 (lib_child_handler): New static var.
4252 (handle_child_signal): Invoke it.
4253 (catch_child_signal): If a library has set up a signal handler,
4254 save it into lib_child_handler.
4255 (init_process_emacs): If using glib and not on Windows, tickle glib's
4256 child-handling code so that it initializes its private SIGCHLD handler.
4257 * syssignal.h (SA_SIGINFO): Default to 0.
4258 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4259 31; it should no longer be needed now.
4260
90db8702
MA
42612013-06-05 Michael Albinus <michael.albinus@gmx.de>
4262
4263 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4264
4265 * gfilenotify.c (globals_of_gfilenotify): New function.
4266 (syms_of_gfilenotify): Move global initialization there.
4267
4268 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4269
bfa3acd6
SM
42702013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4271
4272 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4273 * keyboard.c (menu_bar_items, tool_bar_items):
4274 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4275 not override local keymaps any more.
4276
ba59bd80
EZ
42772013-06-04 Eli Zaretskii <eliz@gnu.org>
4278
4279 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4280
7f203aa1
EZ
42812013-06-03 Eli Zaretskii <eliz@gnu.org>
4282
9337e206
EZ
4283 * w32console.c (initialize_w32_display): Return the dimensions of
4284 the console window via 2 additional arguments, not via the current
4285 frame. This avoids crashes due to overrunning the bounds of
4286 frame's decode_mode_spec_buffer, which is not resized following
4287 the change of the frame dimensions from the initial 10x10.
4288
4289 * w32term.h (w32_initialize_display_info): Adjust prototype.
4290
4291 * term.c (init_tty): Take dimensions of the frame from the values
4292 returned by initialize_w32_display.
4293
7f203aa1
EZ
4294 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4295 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4296 (LIBES): Add $(GFILENOTIFY_LIBS).
4297
4298 * w32inevt.c (handle_file_notifications): Add dummy implementation
4299 for !HAVE_W32NOTIFY.
4300
4301 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4302
55a87246
JD
43032013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4304
4305 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4306
4307 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4308
4309 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4310
3d5ee10a
PE
43112013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4312
4313 Fix minor problems found by static checking.
4314 * data.c (pure_write_error):
4315 Use xsignal2, not Fsignal, as Fsignal might return.
4316 * eval.c (set_backtrace_debug_on_exit): Now static.
4317 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4318 No longer inline. EXTERN_INLINE is needed only for functions
4319 defined in .h files. Reindent function header as per GNU style.
4320 (backtrace_p, backtrace_top, backtrace_next):
4321 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4322 compiler or linker. Add extern decls to pacify gcc -Wall.
4323 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4324 Now static.
4325 * frame.c (free_monitors): Define only on platforms that need it.
4326 * nsterm.m (ns_term_init):
4327 * process.c (catch_child_signal):
4328 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4329 defined on all porting targets these days.
4330 * process.c, process.h (catch_child_signal):
4331 Make it extern only if NS_IMPL_GNUSTEP is defined.
4332
e2d8a6f0
EZ
43332013-06-03 Eli Zaretskii <eliz@gnu.org>
4334
4335 * w32.c (gettimeofday): Make the signature identical to prototype
4336 in nt/inc/sys/time.h.
4337
a8a7c5f6
SM
43382013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4339
4340 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4341 .gdbinit.
4342
4343 * keyboard.c (safe_run_hooks_error): Improve error message.
4344
4345 * data.c (pure_write_error): Add `object' argument.
4346 * puresize.h (CHECK_IMPURE): Use it.
4347
c9628c79
MA
43482013-06-03 Michael Albinus <michael.albinus@gmx.de>
4349
4350 * Makefile.in (NOTIFY_OBJ): New variable.
4351 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4352
4353 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4354 Call syms_of_gfilenotify.
4355
4356 * gfilenotify.c: New file.
4357
4358 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4359 and Qfile_w32notify.
4360 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4361 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4362
4363 * lisp.h: Declare syms_of_gfilenotify.
4364
4365 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4366
2f592f95
SM
43672013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4368
4369 Merge the specpdl and backtrace stacks. Make the structure of the
4370 specpdl entries more obvious via a tagged union of structs.
4371 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4372 (enum specbind_tag): New enum.
4373 (struct specbinding): Make it a tagged union of structs.
4374 Add a case for backtrace records.
4375 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4376 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4377 (backtrace_debug_on_exit): New accessors.
4378 (struct backtrace): Remove.
4379 (struct catchtag): Remove backlist field.
4380 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4381 Move to eval.c.
4382 (Flocal_variable_p): Speed up the common case where the binding is
4383 already loaded.
4384 * eval.c (backtrace_list): Remove.
4385 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4386 (set_backtrace_args, set_backtrace_nargs)
4387 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4388 (backtrace_next): New functions.
4389 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4390 (unwind_to_catch, internal_lisp_condition_case)
4391 (internal_condition_case, internal_condition_case_1)
4392 (internal_condition_case_2, internal_condition_case_n): Don't bother
4393 with backtrace_list any more.
4394 (Fsignal): Adjust to new backtrace format.
4395 (grow_specpdl): Move up.
4396 (record_in_backtrace): New function.
4397 (eval_sub, Ffuncall): Use it.
4398 (apply_lambda): Adjust to new backtrace format.
4399 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4400 data.c.
4401 (specbind): Adjust to new specpdl format. Simplify.
4402 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4403 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4404 backtrace format.
4405 (mark_backtrace): Remove.
4406 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4407 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4408 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4409 Use mark_specpdl.
4410 * profiler.c (record_backtrace): Use get_backtrace.
4411 (handle_profiler_signal): Use backtrace_top_function.
4412 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4413 accessor functions.
4414
c0342369
JD
44152013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4416
4417 * process.h (catch_child_signal): Declare.
4418
4419 * process.c (catch_child_signal): New function.
4420 (init_process_emacs): Call it.
4421
4422 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4423 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4424 NS_IMPL_COCOA.
4425 (x_set_cursor_type): Remove declaration.
4426 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4427 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4428 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4429 (ns_get_color): Use F suffix on float.
4430 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4431 (ns_get_rgb_color): Remove.
4432 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4433 (note_mouse_movement): x and y are CGFloat.
4434 (ns_draw_fringe_bitmap): Remove unused rowY.
4435 Change #if to COCOA && >= 10_6.
4436 (ns_draw_window_cursor): Remove unused overspill.
4437 (ns_draw_underwave): width and x are EamcsCGFloat.
4438 (ns_draw_box): thickness is CGFloat.
4439 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4440 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4441 if not in main thread.
4442 (ns_get_pending_menu_title, ns_check_menu_open)
4443 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4444 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4445 (sendFromMainThread:): New method.
4446 (changeFont:): size is CGFloat.
4447 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4448 Disable warning about permanent text.
4449 (characterIndexForPoint:): Adjust return type depending on GNUStep
4450 version.
4451 (mouseDown:): delta is CGFloat.
4452 (updateFrameSize): Remove unised variable f.
4453 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4454 Cast float to EmacsCGFloat.
4455 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4456 also to -1 when restoring.
4457 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4458 inside NS_IMPL_COCOA.
4459 (toggleFullScreen:): Put call to toggleFullScreen inside
4460 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4461 (setPosition:portion:whole:): por is CGFloat.
4462 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4463 (mouseDown:): Use CGFloat.
4464 (mouseDragged:): Remove unised variable edge.
4465 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4466
4467 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4468 of CGFloat differs.
4469 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4470 when NS_IMPL_GNUSTEP.
4471 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4472 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4473 (EmacsToolbar): Add clearAll. Add tag argument to
4474 addDisplayItemWithImage.
4475 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4476
4477 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4478
4479 * nsmenu.m (ns_update_menubar): Make static.
4480 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4481 (fillWithWidgetValue:): Add cast to SEL for setAction.
4482 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4483 (update_frame_tool_bar): Update code for GNUStep.
4484 (clearAll): New method.
4485 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4486 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4487 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4488 call to insertItemWithItemIdentifier.
4489 (validateVisibleItems): Fix indentation.
4490 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4491 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4492 UtilityWindow to aStyle, remove call to setStyleMask.
4493
4494 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4495
4496 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4497 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4498 Use F suffix on floats.
4499 (ns_char_width): Returns CGFloat.
4500 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4501 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4502 DPSxshow.
4503 (ns_glyph_metrics): CGFloat instead of float.
4504
a0eb10b3
JB
4505 * nsfns.m (x_set_foreground_color, x_set_background_color):
4506 Use EmacsCGFloat.
4507 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4508 remove unused variables.
4509 (Fns_read_file_name): Keep track if panel is for save.
4510 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4511 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4512 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4513 Just return the input if GNUStep.
c0342369
JD
4514 (x_screen_planes): Remove.
4515 (Fxw_color_values): Use EmacsCGFloat
4516 (Fns_display_monitor_attributes_list): Only get screen number for
4517 Cocoa.
ef099a94 4518 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4519 EmacsSavePanel.
4520 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4521 ns_directory_from_panel.
4522
da9aff11
PE
45232013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4524
4525 * process.c (handle_child_signal): Also use WCONTINUED.
4526 This is so that list-processes doesn't mistakenly list the process
4527 as stopped, when the process has actually been continued and is
4528 now running.
4529
0e64479a
PE
45302013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4531
fc186a96
PE
4532 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4533 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4534 not already configured.
4535
0e64479a
PE
4536 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4537
38b787fa
EZ
45382013-05-29 Eli Zaretskii <eliz@gnu.org>
4539
4540 * Makefile.in (mostlyclean): Remove *.res files.
4541
22513e52
SM
45422013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4543
4544 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4545 a buffer (bug#8447).
4546
6ef3db10
EZ
45472013-05-27 Eli Zaretskii <eliz@gnu.org>
4548
4549 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4550 display vector, and we backtrack, handle the case that the
4551 previous character position is also displayed from a display
4552 vector or covered by a display string or image. (Bug#14476)
4553
6799bb26
JD
45542013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4555
4556 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4557 (struct MonitorInfo, free_monitors): Remove.
4558 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4559 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4560 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4561 Qframes, Qsource.
4562
4563 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4564 (struct MonitorInfo, free_monitors): Remove.
4565 (ns_screen_name): Make static.
4566 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4567 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4568 Qframes, Qsource.
4569
4570 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4571 (struct MonitorInfo): New struct.
4572 (free_monitors, make_monitor_attribute_list): Declare.
4573
22513e52
SM
4574 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4575 New Lisp_Object:s.
6799bb26
JD
4576 (free_monitors, make_monitor_attribute_list): New functions.
4577 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4578 Qsource.
4579
38cd43eb
XF
45802013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4581
4582 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4583
2af0948d
SM
45842013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4585
a7eb9b0f
SM
4586 * keyboard.c: Apply keyboard decoding only to events that come directly
4587 from the tty, not from unread-command-events (bug#14368).
4588 (read_event_from_main_queue): New function, extracted from read_char).
4589 (read_decoded_char): Remove.
4590 (read_decoded_event_from_main_queue): New function to replace it.
4591 (read_char): Use it.
4592 (read_key_sequence): Use read_char rather than read_decoded_char.
4593
2af0948d
SM
4594 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4595
1413e9a5
BR
45962013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4597
4598 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4599
e6d2f155
KH
46002013-05-22 Kenichi Handa <handa@gnu.org>
4601
4602 The following changes are to fix the setting of
4603 buffer-file-coding-system on, for instance, C-x RET c unix RET
4604 _FILE_OF_DOS_EOL_TYPE_ RET.
4605
4606 * coding.h (struct coding_system): New member detected_utf8_chars.
4607
4608 * coding.c (detect_coding_utf_8): Count characters and check EOL
4609 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4610 BOM is there.
4611 (setup_coding_system): Do not initialize coding->head_ascii.
4612 (check_ascii): Do not set coding->eol_seen but update it. Do not
4613 call adjust_coding_eol_type here.
1413e9a5
BR
4614 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4615 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4616 of the found coding-system.
4617 (decode_coding_gap): Cancel previous change. Utilize the
4618 character numbers counted by detect_coding_utf_8. Fix detection
4619 of BOM for utf-8.
4620
ab56a6f4 46212013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4622
4623 * search.c (looking_at_1): Only set last_thing_searched if the match
4624 changed the match-data (bug#14281).
4625
ecc3c6ed
DA
46262013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4627
4628 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4629 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4630 (move_it_vertically_backward): Likewise.
4631
5ba8bf35
YM
46322013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4633
4634 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4635 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4636 (Fx_display_mm_width, Fx_display_mm_height):
4637 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4638
91e8418b 4639 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4640 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4641 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4642 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4643 (Fx_display_backing_store, Fx_display_visual_class)
4644 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4645 (Fx_display_grayscale_p, Fx_display_pixel_width)
4646 (Fx_display_pixel_height, Fx_display_planes)
4647 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4648 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4649 (Fx_display_mm_width, Fx_display_mm_height)
4650 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4651 height for all physical monitors as in X11.
4652
fc30d803
SM
4653 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4654 Return pixel width or height for all physical monitors as in X11.
91e8418b 4655
31ff141c
PE
46562013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4657
4658 Port --enable-gcc-warnings to clang.
4659 * bytecode.c (exec_byte_code):
4660 * regex.c:
4661 Redo diagnostic pragmas to pacify clang, too.
4662 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4663 * editfns.c (Fencode_time):
4664 * fileio.c (file_accessible_directory_p):
4665 * font.c (font_unparse_xlfd):
4666 Use '&"string"[index]' instead of '"string" + (index)'.
4667 * undo.c (user_error): Remove; unused.
4668
df065a0b
EZ
46692013-05-16 Eli Zaretskii <eliz@gnu.org>
4670
04d360e7
EZ
4671 * insdel.c (insert_1_both): Document the arguments, instead of
4672 referring to insert_1, which no longer exists.
4673
5bb98290
EZ
4674 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4675 some window, increment windows_or_buffers_changed, so that
4676 *Messages* display in that window is updated. (Bug#14408)
4677
df065a0b
EZ
4678 * w32.c: Include epaths.h.
4679 (init_environment): Use cmdproxy.exe without leading directories.
4680 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4681 case.
4682 (gettimeofday): Adjust signature and return value to Posix
4683 expectations.
4684
4685 * unexw32.c (open_output_file): Delete the existing emacs.exe
4686 before creating it, to break the hard link to the versioned
4687 executable.
4688
4689 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4690 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4691 (FIRSTFILE_OBJ): New variables.
4692 (W32_RES): Rename to EMACSRES. All users changed.
4693 (base_obj): Use $(CM_OBJ).
4694 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4695 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4696 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4697 $(W32_RES_LINK) before $(LIBES).
4698 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4699
1aa8d505
SM
47002013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4701
6e911150
SM
4702 * makefile.w32-in (DOC): Use just "DOC".
4703
4704 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4705
1aa8d505
SM
4706 * process.c: Export default filters and sentinels to Elisp.
4707 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4708 New constants.
4709 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4710 (Fset_process_sentinel, Fformat_network_address):
4711 Default to them instead of nil.
4712 (server_accept_connection): Sentinels can't be nil any more.
4713 (read_and_dispose_of_process_output): New function, extracted from
4714 read_process_output.
4715 (read_process_output): Use it; filters can't be nil.
4716 (Finternal_default_process_filter): New function, extracted from
4717 read_process_output.
4718 (exec_sentinel_unwind): Remove function.
4719 (exec_sentinel): Don't zilch sentinel while running.
4720 (status_notify): Sentinels can't be nil.
4721 (Finternal_default_process_sentinel): New function extracted from
4722 status_notify.
4723 (setup_process_coding_systems): Default filter is not nil any more.
4724 (syms_of_process): Export new Elisp functions and initialize
4725 new constants.
4726 * lisp.h (make_lisp_proc): New function.
4727
5ac2eb34
SM
47282013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4729
4730 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4731
eda9c7d7
EZ
47322013-05-14 Eli Zaretskii <eliz@gnu.org>
4733
4734 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4735 unless we know that the window w is a leaf window.
4736 Another attempt at solving bug#14062.
eda9c7d7 4737
8fdeaad5
JD
47382013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4739
4740 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4741 fdesc (Bug#14375).
4742
44aa9ee6
PE
47432013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4744
4745 * image.c (gif_load): Check that subimages fit (Bug#14345).
4746
759fd763
SM
47472013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4748
4749 * lread.c (skip_dyn_eof): New function.
4750 (read1): Use it to skip the end of a file in response to #@00.
4751
4752 * doc.c (get_doc_string): Slightly relax the sanity checking.
4753
4465bfb4
JD
47542013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4755
4756 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4757 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4758 (MonitorInfo): New struct.
4759 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4760 (Fns_display_monitor_attributes_list): New functions.
4761 (display-usable-bounds): Remove.
4762 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4763 Qsource.
4764
7583e2a0
PE
47652013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4768 (GTK_CHECK_VERSION): New macro, if not already defined.
4769 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4770 replaced by GTK_CHECK_VERSION.
4771
ad75d77e
PE
47722013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4773
4774 * xterm.h (GTK_PREREQ): New macro.
4775 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4776 to use this macro instead, for consistency and clarity.
4777
07525f77
EZ
47782013-05-08 Eli Zaretskii <eliz@gnu.org>
4779
4780 * xdisp.c (row_for_charpos_p): New function, with code of
4781 cursor_row_p, but accepts an additional argument CHARPOS instead
4782 of using a hardcoded PT.
4783 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4784 (row_containing_pos): Call row_for_charpos_p instead of partially
4785 doing the same. Fixes cursor positioning under longlines-mode
4786 when longlines-show-effect includes more than one newline, when
4787 moving the cursor vertically up.
4788
d901fc8d
JB
47892013-05-08 Juanma Barranquero <lekktu@gmail.com>
4790
4791 * makefile.w32-in (ACL_H): New macro.
4792 ($(BLD)/fileio.$(O)): Update dependencies.
4793
f269bc61
PE
47942013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4795
e7b41c4c 4796 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4797 * Makefile.in (LIB_ACL): New macro.
4798 (LIBACL_LIBS): Remove.
4799 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4800 * fileio.c: Include <acl.h>.
4801 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4802 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4803 !acl_errno_valid.
4804 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4805 it ourselves.
4806
f269bc61
PE
4807 * unexelf.c: Don't assume ElfW (Half) fits in int.
4808 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4809 when dealing with ElfW (Half) values, since they can exceed 2**31
4810 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4811 (entry_address): Omit unused NUM arg. All uses changed.
4812
a261c53e
JL
48132013-05-07 Juri Linkov <juri@jurta.org>
4814
4815 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4816 to the string converted from number with `Fnumber_to_string'.
4817 (Bug#14254)
4818
2b66427d
PE
48192013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4822 This fixes a problem introduced by my previous change.
4823
15acfe41
GM
48242013-05-07 Glenn Morris <rgm@gnu.org>
4825
4826 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4827
5ea03bf5
JD
48282013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4829
4830 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4831
e0c9d565
PE
48322013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4833
4834 Static checking by GCC 4.8.0.
4835 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4836 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4837 (x_get_monitor_attributes_fallback)
4838 (x_get_monitor_attributes_xinerama)
4839 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4840 Define only if USE_GTK.
4841 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4842 (x_get_monitor_attributes_fallback): Omit unused locals.
4843 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4844 Use double, not float, to avoid mixed-mode floating point arithmetic.
4845
4e3f9230
YM
48462013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4847 Jan Djärv <jan.h.d@swipnet.se>
4848
4849 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4850 (XINERAMA_CFLAGS): New macros.
4851 (ALL_CFLAGS, LIBES): Use them.
4852
4853 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4854 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4855 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4856 (syms_of_xfns): DEFSYM them.
4857 (struct MonitorInfo): New struct.
4858 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4859 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4860 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4861 (x_get_monitor_attributes_xinerama): New functions.
4862 (Fx_display_monitor_attributes_list): New primitive.
4863 (syms_of_xfns): Defsubr it.
4864
4865 * xterm.h (x_display_info): Add Xatom_net_workarea and
4866 Xatom_net_current_desktop.
4867
4868 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4869 and dpyinfo->Xatom_net_current_desktop.
4870
05839b6a
EZ
48712013-05-06 Eli Zaretskii <eliz@gnu.org>
4872
4873 * xdisp.c (pos_visible_p): Use the special code for finding the
4874 beginning of a display property or overlay for any "replacing"
4875 display property, not just for display strings. This solves
4876 incorrect reporting of position by posn-at-point. (Bug#14241)
4877
dc4a2ee0
PE
48782013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4879
5ee94506
PE
4880 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4881 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4882 Verify that ElfW (Half) fits in int.
4883 (fatal): Use same signature as lisp.h.
4884 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4885 configure and build with -DUNEXELF_DEBUG without worrying about
4886 other modules that use DEBUG.
4887 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4888 possibly-wide integers now uses it instead of plain fprintf.
4889 (entry_address): New function, which avoids problems with 32-bit
4890 overflow on 64-bit hosts.
4891 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4892 (round_up): Don't assume the remainder fits in int.
4893 (find_section): Use bool for boolean. Simplify debug code.
4894 (unexec): Don't assume file sizes fit in int or size_t.
4895 Omit unnecessary trailing newline in 'fatal' format.
4896 Use strerror rather than outputting decimal error number.
4897 Remove unused code when emacs is not defined;
4898 this file relies on Emacs now.
4899 Don't assume e_phnum and e_shnum are positive.
4900
dc4a2ee0
PE
4901 * regex.c: Fix problems when DEBUG is defined.
4902 (extract_number, extract_number_and_incr): Define regardless of
4903 whether DEBUG is defined; that's simpler and makes the code less
4904 likely to go stale in the normal case when DEBUG is not defined.
4905 Return int rather than taking an int * arg. All callers changed.
4906 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4907 Remove, replacing with ...
4908 (DEBUG_PRINT): New macro. All callers changed.
4909 (DEBUG_COMPILES_ARGUMENTS): New macro.
4910 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4911 (print_compiled_pattern, print_double_string) [DEBUG]:
4912 Use prototype rather than old-style definition.
4913 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4914 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4915 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4916 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4917 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4918 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4919 This matters only when DEBUG is defined.
4920
14c7ed05
EZ
49212013-05-05 Eli Zaretskii <eliz@gnu.org>
4922
4923 * xdisp.c (set_iterator_to_next): Set the
4924 ignore_overlay_strings_at_pos_p flag only if we are _really_
4925 iterating over an overlay string, as indicated by the
4926 current.overlay_string_index member. (Bug#14306)
4927
e6076b1b
JD
49282013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4929
4930 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4931 to where it is used, to avoid autorelease issues (Bug#14050).
4932
cbee2131
PE
49332013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4934
4935 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4936 * fileio.c (syms_of_fileio): Implement this.
4937 * filelock.c (create_lock_file): If symbolic links don't work, so
4938 we use a regular file as a lock file, do not fsync the lock file;
4939 it's not needed.
4940
30c7e542
SM
49412013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4942
4943 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4944 (syms_of_minibuf): Adjust accodingly.
4945 * lread.c (Fread):
4946 * callint.c (Fcall_interactively): Adjust calls accordingly.
4947
5bebd186
EZ
49482013-05-04 Eli Zaretskii <eliz@gnu.org>
4949
4950 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4951 w->contents is a buffer before computing everything else.
4952 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4953
4954 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4955 assertion violations. (Bug#14062)
4956
0fb0a4f3
DR
49572013-05-01 David Reitter <david.reitter@gmail.com>
4958
4959 * nsfns.m (ns_tooltip): Initialize.
4960
9e63b4a5
EZ
49612013-04-28 Eli Zaretskii <eliz@gnu.org>
4962
4963 * coding.c (decode_coding_gap): Don't remove the character before
4964 a newline unless it's a CR character. (Bug#14287)
4965
ad60824e
DN
49662013-04-28 Dan Nicolaescu <dann@gnu.org>
4967
4968 * dispextern.h (struct face): Move enum face_underline_type
4969 earlier so that bitfields can be in the same word.
4970
edbdcec0
JD
49712013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4972
4973 * nsfns.m (handlePanelKeys): New function.
4974 (EmacsOpenPanel:performKeyEquivalent:)
4975 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4976 arrows/function/control and copy/paste keys (Bug#14296).
4977
0208ede7
JL
49782013-04-27 Juri Linkov <juri@jurta.org>
4979
4980 * callint.c (Fcall_interactively): Call `Qread_number' for
4981 interactive code letter `n' instead of using duplicate code.
4982 (Bug#14254)
4983
b8dd59f7
PE
49842013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4985
4986 * systime.h (make_timeval): Declare as 'const'.
4987
8bd722db
KH
49882013-04-27 Kenichi Handa <handa@gnu.org>
4989
4990 * font.c (font_open_entity): Always open a font of manageable
4991 size.
4992
13d0e56f 49932013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4994
f780d632
PE
4995 Port better to AIX (Bug#14258).
4996 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4997 to pacify AIX xlc.
4998
ec509856
KH
49992013-04-24 Kenichi Handa <handa@gnu.org>
5000
5001 * coding.c (decode_coding_iso_2022): When an invalid escape
5002 sequence is encountered, reset the invocation and designation
5003 status to the safest one.
5004
84fc48e5
PE
50052013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5006
5007 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5008 Without this fix, "make distclean" leaves stamp-h1 behind.
5009
806bda47
EC
50102013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5011
5012 * w32fns.c (w32_fullscreen_rect): New function to compute the
5013 window rectangle for the given fullscreen mode.
5014 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5015 longer tunes the window size. This keeps the window's edges flush
5016 with the screen and allows the taskbar to hide itself in fullboth.
5017
5018 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5019 window decorations and uses the entire screen.
5020
5021 * w32term.h (w32_fullscreen_rect) Add prototype.
5022 (struct w32_output): Replace normal_width, normal_height,
5023 normal_top, and normal_left members with a single normal_placement
5024 struct.
5025 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5026 Remove macros.
5027 (FRAME_NORMAL_PLACEMENT): New macro.
5028
9cc2810b
JB
50292013-04-16 Juanma Barranquero <lekktu@gmail.com>
5030
5031 * minibuf.c (Ftest_completion): Silence compiler warning.
5032
fd16b54c
EZ
50332013-04-15 Eli Zaretskii <eliz@gnu.org>
5034
5035 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5036 bug#14062.
fd16b54c
EZ
5037
5038 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5039 parentheses.
5040
5041 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5042 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5043 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5044 parentheses where appropriate.
5045
9e3379a0
PE
50462013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5047
5048 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5049
ddd6b685
EZ
50502013-04-14 Eli Zaretskii <eliz@gnu.org>
5051
5052 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5053 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5054 Mention in the doc string that setting these variables takes
5055 effect only after a call to set-window-buffer. (Bug#14200)
5056
29b79ba1
EZ
50572013-04-13 Eli Zaretskii <eliz@gnu.org>
5058
5059 * indent.c (Fvertical_motion): Don't consider display strings on
5060 overlay strings as display strings on the buffer position we
5061 started from. This prevents vertical cursor motion from jumping
5062 more than one line when there's an overlay string with a display
5063 property at end of line.
5064 Reported by Karl Chen <Karl.Chen@quarl.org> in
5065 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5066
562c6ee9
SM
50672013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5068
5069 * window.c (select_window): `record_buffer' even if window is
5070 already selected (bug#14191).
5071
fcc1fe85
EZ
50722013-04-11 Eli Zaretskii <eliz@gnu.org>
5073
5074 * window.c (Fwindow_end): Test more flags, including the buffer's
5075 last_overlay_modified flag, to determine whether the window's
5076 display is really up-to-date. Prevents the function from
5077 returning a stale value. (Bug#14170)
5078 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5079 current matrix.
5080
f009190a
EZ
50812013-04-10 Eli Zaretskii <eliz@gnu.org>
5082
5083 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5084 garbaged only if it is not already the top frame on its TTY.
5085 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5086 there are GUI frames open in the same session. (Bug#13864)
5087
78ce603d
SM
50882013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5089
5090 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5091 of marking the idle timers directly.
5092
a8036e40
SM
50932013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5094
5095 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5096 tables (bug#14054).
5097
7ffe7ef6
SM
50982013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5099
5100 * window.c (select_window): Don't record_buffer while the invariant is
5101 temporarily broken (bug#14161).
5102
5103 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5104
7d9f6883
EZ
51052013-04-07 Eli Zaretskii <eliz@gnu.org>
5106
5107 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5108
5406cfd9
RF
51092013-04-07 Romain Francoise <romain@orebokech.com>
5110
5111 Ignore additional platform-specific ACL errors (Bug#13702).
5112 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5113 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5114
95c0e83b
JD
51152013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5116
5117 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5118 f->output_data.ns.
5119
876da980
PE
51202013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5121
5122 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5123 This bug was introduced by my 2013-02-25 change that simplified
5124 data_start configuration. Without this change, on GNU/Linux
5125 an Emacs configured with --enable-profiling fails immediately
5126 due to a profiler signal.
5127 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5128 with these flags. On platforms where special flags are needed
5129 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5130 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5131 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5132
7452b7bd
DA
51332013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5134
5135 Get rid of some platform-specific functions examining window
5136 system and its capabilities. This is a partial rework of the
5137 2013-04-05 change.
5138 * lisp.h (have_menus_p): Remove prototype. This function is
5139 replaced with platform-independent window_system_available.
5140 (check_window_system): Move to...
5141 * frame.h (decode_window_system_frame, window_system_available):
5142 ...here, add new prototypes.
5143 * frame.c (window_system_available, decode_window_system_frame):
5144 New functions.
5145 (check_window_system): Platform-independent now.
5146 * xterm.h (x_in_use): Remove declaration.
5147 (check_x_frame):
5148 * w32term.h (check_x_frame):
5149 * nsterm.h (check_x_frame): Remove prototypes. This function
5150 is replaced with platform-independent decode_window_system_frame.
5151 * msdos.c (have_menus_p): Remove.
5152 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5153 Remove platform-specific functions. Use check_window_system,
5154 decode_window_system_frame and check_ns_display_info where
5155 appropriate. Minor style and comment tweaks.
5156 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5157 (check_x_frame): Likewise.
5158 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5159 Likewise.
5160 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5161 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5162 * xmenu.c, xselect.c: All related users changed.
5163
251e9147
KH
51642013-04-03 Kenichi Handa <handa@gnu.org>
5165
5166 The following changes is to optimize the code for reading UTF-8
5167 files.
5168
562c6ee9 5169 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5170 changed. Check EOL format. Do not call adjust_coding_eol_type
5171 here.
5172 (check_utf_8): New function.
5173 (adjust_coding_eol_type): Do nothing if already adjusted.
5174 (detect_coding): Compare the return value of check_ascii with
5175 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5176 (decode_coding_gap): Optimize for valid UTF-8.
5177
8bc369d4
KH
51782013-03-21 Kenichi Handa <handa@gnu.org>
5179
5180 * coding.c (syms_of_coding): Cancel previous change.
5181
5182 * insdel.c (insert_from_gap): Fix previous change.
5183
73931ad1
DA
51842013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5185
5186 Consistently use platform-specific function to detect window system.
5187 * lisp.h (check_window_system): New prototype. This function is
5188 going to replace check_x, check_w32 and check_ns.
5189 (have_menus_p): Mention msdos.c in comment.
5190 * fontset.c (check_window_system_func): Remove. Adjust all users.
5191 * fontset.h (check_window_system_func): Remove prototype.
5192 * nsterm.h (check_ns):
5193 * xterm.h (check_x):
5194 * w32term.h (check_w32): Likewise.
5195 * menu.c (Fx_popup_menu): Use check_window_system.
5196 * msdos.c (check_window_system): Define for MS-DOS.
5197 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5198 * w32fns.c (check_window_system): Likewise for MS-Windows.
5199 * xfns.c (check_window_system): Likewise for X.
5200 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5201 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5202
7216e43b
PE
52032013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5204
5205 Prefer < to > in range checks such as 0 <= i && i < N.
5206 This makes it easier to visualize quantities on a number line.
5207 This patch doesn't apply to all such range checks,
5208 only to the range checks affected by the 2013-03-24 change.
5209 This patch reverts most of the 2013-03-24 change.
5210 * alloc.c (xpalloc, Fgarbage_collect):
5211 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5212 * character.c (string_escape_byte8):
5213 * charset.c (read_hex):
5214 * data.c (cons_to_unsigned):
5215 * dispnew.c (update_frame_1):
5216 * doc.c (Fsubstitute_command_keys):
5217 * doprnt.c (doprnt):
5218 * editfns.c (hi_time, decode_time_components):
5219 * fileio.c (file_offset):
5220 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5221 * font.c (font_intern_prop):
5222 * frame.c (x_set_alpha):
5223 * gtkutil.c (get_utf8_string):
5224 * indent.c (check_display_width):
5225 * keymap.c (Fkey_description):
5226 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5227 * lread.c (read1):
5228 * minibuf.c (read_minibuf_noninteractive):
5229 * process.c (wait_reading_process_output):
5230 * search.c (Freplace_match):
5231 * window.c (get_phys_cursor_glyph):
5232 * xdisp.c (redisplay_internal):
5233 * xsmfns.c (smc_save_yourself_CB):
5234 Prefer < to > for range checks.
5235 * dispnew.c (sit_for): Don't mishandle NaNs.
5236 This fixes a bug introduced in the 2013-03-24 change.
5237 * editfns.c (decode_time_components): Don't hoist comparison.
5238 This fixes another bug introduced in the 2013-03-24 change.
5239
92759988
DA
52402013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5241
5242 * frame.h (struct frame): Drop scroll_bottom_vpos
5243 member becaue all real users are dead long ago.
5244 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5245 * xdisp.c (redisplay_internal): Adjust user.
5246
9a1971bb
GM
52472013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5248
f38ab167
JD
5249 * nsmenu.m (showAtX:Y:for:): setLevel to
5250 NSPopUpMenuWindowLevel (Bug#13998).
5251
6d01f1fe
JD
52522013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5253
5254 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5255 (ns_check_pending_open_menu): Declare.
5256
5257 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5258 (x_activate_menubar): Update the menu with title that matches
5259 ns_get_pending_menu_title, and call
5260 ns_check_pending_openmenu (Bug#12698).
5261 (menuWillOpen:): New method.
5262 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5263
5264 * nsterm.m (menu_will_open_state, menu_mouse_point)
5265 (menu_pending_title): New varaibles.
5266 (ns_get_pending_menu_title, ns_check_menu_open)
5267 (ns_check_pending_open_menu): New functions.
5268
781f4782
DA
52692013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5270
5271 * indent.c (current_column_bol_cache): Remove leftover which is not
5272 used in Fmove_to_column any more.
5273 (current_column, scan_for_column): Adjust users.
5274 * keyboard.c (last_point_position_buffer, last_point_position_window):
5275 Remove leftovers which are not used for recording undo any more.
5276 (command_loop_1, syms_of_keyboard): Adjust users.
5277 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5278 redisplay_window any more.
5279 (move_it_to): Adjust user.
5280
1921c31b
JB
52812013-03-29 Juanma Barranquero <lekktu@gmail.com>
5282
5283 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5284 Update dependencies.
5285
717b8bcd
SM
52862013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5287
5288 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5289 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5290 forward references.
5291
e74aeda8
DA
52922013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5293
5294 * window.h (struct window): Replace hchild, vchild and buffer slots
5295 with the only contents slot. This is possible because each valid
5296 window may have either the child window (in vertical or horizontal
5297 combination) or buffer to display (for the leaf window). Using that,
5298 a lof of operations to traverse and/or change window hierarchies may
5299 be simplified. New member horizontal is used to distinguish between
5300 horizontal and vertical combinations of internal windows.
5301 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5302 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5303 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5304 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5305 Use contents slot, not buffer, where appropriate.
5306 (wset_combination): New function.
5307 (wset_buffer): Add eassert.
5308 (Fframe_first_window): Simplify the loop reaching first window.
5309 (Fwindow_buffer): Use WINDOW_LEAF_P.
5310 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5311 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5312 (unshow_buffer): Convert initial debugging check to eassert.
5313 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5314 (make_parent_window, window_resize_check, window_resize_apply)
5315 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5316 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5317 Adjust to match struct window changes.
5318 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5319 (mark_window_cursors_off, count_windows, get_leaf_windows)
5320 (foreach_window_1): Simplify the loop.
5321 * alloc.c (mark_object): Do not check for the leaf window because
5322 internal windows has no glyph matrices anyway.
5323 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5324 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5325 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5326 (build_frame_matrix_from_window_tree, mirror_make_current)
5327 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5328 (update_window_tree, set_window_update_flags): Simplify the loop.
5329 (sync_window_with_frame_matrix_rows): Enforce live window.
5330 Use contents slot, not buffer, where appropriate.
5331 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5332 and WINDOW_HORIZONTAL_COMBINATION_P.
5333 (make_frame_visible_1): Simplify the loop.
5334 Use contents slot, not buffer, where appropriate.
5335 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5336 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5337 (expose_window_tree): Likewise.
5338 Use contents slot, not buffer, where appropriate.
5339 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5340 to avoid deleted windows. Use contents slot instead of buffer.
5341 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5342 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5343 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5344 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5345
121ab1cd
EZ
53462013-03-28 Eli Zaretskii <eliz@gnu.org>
5347
ef454cf7
EZ
5348 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5349 identify the reasons for assertion violations in bug#14062 and
5350 similar ones.
21e930f8
EZ
5351 (Fx_show_tip): Fix compilation error under
5352 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5353
121ab1cd
EZ
5354 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5355 Reported by <rzl24ozi@gmail.com>.
5356
5c89ca24
DA
53572013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5358
5359 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5360 start marker...
562c6ee9
SM
5361 (unwind_with_echo_area_buffer): ...to restore it here.
5362 This is needed to ensure that...
5c89ca24
DA
5363 (redisplay_window): ...both window markers are valid here,
5364 which is verified by eassert.
5365 * editfns.c (save_excursion_save): Do not assume that
5366 selected_window always displays the buffer.
c7f53895
DA
5367 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5368 Fix comment.
5c89ca24 5369
f557c1b1
SM
53702013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5371
5372 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5373 the upcase table.
5374
40693bba 53752013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5376
5377 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5378
c86f791f
EZ
53792013-03-27 Eli Zaretskii <eliz@gnu.org>
5380
5381 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5382 since MinGW's w32api headers do. This avoids compiler warnings.
5383
5384 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5385 if already defined.
5386
c6e72e17
EZ
53872013-03-26 Eli Zaretskii <eliz@gnu.org>
5388
5389 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5390
54e95010
JD
53912013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5392
5393 * gtkutil.c (style_changed_cb): Check if frame is live and an
5394 X frame (Bug#14038).
5395
b88b62de
EZ
53962013-03-26 Eli Zaretskii <eliz@gnu.org>
5397
a18d7de6
EZ
5398 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5399 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5400 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5401 MinGW64.
8f5e14c8
EZ
5402 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5403 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5404
b88b62de
EZ
5405 Fix incompatibilities between MinGW.org and MinGW64 headers.
5406 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5407
5408 * w32.c (REPARSE_DATA_BUFFER): Guard with
5409 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5410
c074e458
JD
54112013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5412
5413 * xterm.c: Include X11/XKBlib.h
5414 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5415
908589fd
AS
54162013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5417
5418 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5419 written backwards.
5420 * blockinput.h (input_blocked_p): Likewise.
5421 * bytecode.c (exec_byte_code): Likewise.
5422 * callproc.c (call_process_kill, call_process_cleanup)
5423 (Fcall_process): Likewise.
5424 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5425 (Fccl_execute_on_string): Likewise.
5426 * character.c (string_escape_byte8): Likewise.
5427 * charset.c (read_hex): Likewise.
5428 * cm.c (calccost): Likewise.
5429 * data.c (cons_to_unsigned): Likewise.
5430 * dired.c (directory_files_internal, file_name_completion):
5431 Likewise.
5432 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5433 (sit_for): Likewise.
5434 * doc.c (Fsubstitute_command_keys): Likewise.
5435 * doprnt.c (doprnt): Likewise.
5436 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5437 * emacsgtkfixed.c: Likewise.
5438 * fileio.c (file_offset, Fwrite_region): Likewise.
5439 * floatfns.c (Fexpt, fmod_float): Likewise.
5440 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5441 Likewise.
5442 * font.c (font_intern_prop): Likewise.
5443 * frame.c (x_set_alpha): Likewise.
5444 * gtkutil.c (get_utf8_string): Likewise.
5445 * indent.c (check_display_width): Likewise.
5446 * intervals.c (create_root_interval, rotate_right, rotate_left)
5447 (split_interval_right, split_interval_left)
5448 (adjust_intervals_for_insertion, delete_node)
5449 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5450 (merge_interval_right, merge_interval_left, copy_intervals)
5451 (set_intervals_multibyte_1): Likewise.
5452 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5453 * keymap.c (Fkey_description): Likewise.
5454 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5455 * lread.c (openp, read_integer, read1, string_to_number):
5456 Likewise.
5457 * menu.c (ensure_menu_items): Likewise.
5458 * minibuf.c (read_minibuf_noninteractive): Likewise.
5459 * print.c (printchar, strout): Likewise.
5460 * process.c (create_process, Faccept_process_output)
5461 (wait_reading_process_output, read_process_output, send_process)
5462 (wait_reading_process_output): Likewise.
5463 * profiler.c (make_log, handle_profiler_signal): Likewise.
5464 * regex.c (re_exec): Likewise.
5465 * regex.h: Likewise.
5466 * search.c (looking_at_1, Freplace_match): Likewise.
5467 * sysdep.c (get_child_status, procfs_ttyname)
5468 (procfs_get_total_memory): Likewise.
5469 * systime.h (EMACS_TIME_VALID_P): Likewise.
5470 * term.c (dissociate_if_controlling_tty): Likewise.
5471 * window.c (get_phys_cursor_glyph): Likewise.
5472 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5473 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5474 Likewise.
5475 * xfns.c (Fx_window_property): Likewise.
5476 * xmenu.c (set_frame_menubar): Likewise.
5477 * xselect.c (x_get_window_property, x_handle_dnd_message):
5478 Likewise.
5479 * xsmfns.c (smc_save_yourself_CB): Likewise.
5480 * xterm.c (x_scroll_bar_set_handle): Likewise.
5481
2bf7d27a
DA
54822013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5483
5484 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5485 to be optional or nil. Adjust comment and convert it to docstring.
5486 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5487 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5488
a9ebfa0b
PE
54892013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5490
5491 Static checking by GCC 4.8-20130319.
5492 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5493 * process.c (Fset_process_datagram_address)
5494 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5495 * xdisp.c (get_char_face_and_encoding):
5496 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5497 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5498 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5499
4f3576ee
KB
55002013-03-24 Ken Brown <kbrown@cornell.edu>
5501
789b5e9a
KB
5502 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5503 fix compilation on 64-bit Cygwin, where underscores are not
5504 automatically prepended.
5505
4f3576ee
KB
5506 * w32term.c (w32_initialize): Silence compiler warning.
5507
b5b7745f
EZ
55082013-03-23 Eli Zaretskii <eliz@gnu.org>
5509
cdc0d0bd
EZ
5510 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5511 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5512 variables, to save and restore frame dimensions.
5513 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5514 after returning from a 'fullscreen' configuration.
5515 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5516 to avoid races between the main thread and the input thread.
5517
5518 * w32term.h (struct w32_output): New members normal_width,
5519 normal_height, normal_top, normal_left, and prev_fsmode.
5520 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5521 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5522 members of a frame.
5523
b5b7745f
EZ
5524 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5525 'fullscreen' parameter. Always record previous width and height
5526 of the frame, except when switching out of maximized modes, so
5527 that they could be restored correctly, instead of resetting to the
5528 default frame dimensions. Send SC_RESTORE command to the frame,
5529 unless we are going to send SC_MAXIMIZE, to restore the frame
5530 resize hints in the mouse pointer shown by the window manager.
5531 (Bug#14032)
5532
5533 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5534
5535 * lisp.h (get_frame_param): Adjust conditions for prototype
5536 declaration.
5537
a3454eed
KB
55382013-03-22 Ken Brown <kbrown@cornell.edu>
5539
5540 * unexcw.c: Drop unneeded inclusion of w32common.h.
5541 (report_sheap_usage): Declare.
5542 (read_exe_header): Add magic numbers for x86_64.
5543 (fixup_executable): Fix printf format specifier for unsigned long
5544 argument.
5545
5a49b79c
DA
55462013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5547
5548 * frame.h (struct frame): Put menu_bar_window under #ifdef
5549 because this member is not needed when X toolkit is in use.
5550 (fset_menu_bar_window):
5551 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5552 (free_glyphs, update_frame):
5553 * xdisp.c (expose_frame): Likewise.
5554 (display_menu_bar): Likewise. Remove redundant eassert.
5555 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5556 toolkit is in use.
5557
d6723bf7
PE
55582013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5559
7b1123d8
PE
5560 Use functions and constants to manipulate Lisp_Save_Value objects.
5561 This replaces code that used macros and strings and token-pasting.
5562 The change makes the C source a bit easier to follow,
5563 and shrinks the Emacs executable a bit.
5564 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5565 (make_save_value): Change 1st arg from string to enum. All callers
5566 changed.
5567 (INTX): Remove.
5568 (mark_object): Use if, not #if, for GC_MARK_STACK.
5569 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5570 (XSAVE_OBJECT): Now functions, not macros.
5571 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5572 the constant was never used.
5573 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5574 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5575 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5576 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5577 New constants.
5578 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5579 type3 with a single member save_type. All uses changed.
5580 (save_type, set_save_pointer, set_save_integer): New functions.
5581 * print.c (PRINTX): Remove.
5582
d6723bf7
PE
5583 * alloc.c: Remove redundant static declarations.
5584
5f24fa51
DA
55852013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5586
5587 * window.h (struct window): Convert left_col, top_line, total_lines
5588 and total_cols from Lisp_Objects to integers. Adjust comments.
5589 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5590 Remove.
5591 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5592 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5593 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5594 Adjust users where appropriate.
5595
42143acd
DA
55962013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5597
5598 * frame.h (struct frame): Drop resx and resy because the same data is
5599 available from window system-specific output context. Adjust users.
562c6ee9
SM
5600 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5601 New functions to provide defaults when no window system available.
42143acd 5602 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5603 (NUMVAL): Move from xdisp.c.
42143acd
DA
5604 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5605 (Ffont_face_attributes, Fopen_font):
5606 * image.c (gs_load):
5607 * w32font.c (fill_in_logfont):
5608 * xdisp.c (calc_pixel_width_or_height):
5609 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5610 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5611
c0a17406
KH
56122013-03-20 Kenichi Handa <handa@gnu.org>
5613
5614 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5615 to 1 (temporary workaround until a bug related to ASCII
5616 optimization is fixed).
5617
095d384d
DA
56182013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5619
5620 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5621 Signal error if window is not internal. Adjust docstring.
5622 (delete_all_child_windows): Use combination_limit to save the buffer.
5623 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5624 * print.c (syms_of_print): Initialize debugging output not here...
5625 (init_print_once): ...but in a new function here.
5626 * lisp.h (init_print_once): Add prototype.
5627 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5628
748fa866
DA
56292013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5630
5631 * window.c (window_resize_check, window_resize_apply)
5632 (window_from_coordinates, recombine_windows, set_window_buffer)
5633 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5634 (Fsplit_window_internal, Fdelete_window_internal)
5635 (freeze_window_starts): Use bool for booleans.
5636 * window.h (window_frame_coordinates, resize_frame_windows)
5637 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5638
81519fd2
SM
56392013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5640
5641 * dispnew.c (bitch_at_user): Use `user-error'.
5642
6db423a9
KB
56432013-03-17 Ken Brown <kbrown@cornell.edu>
5644
5645 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5646 as return type of image_background. (Bug#13981)
5647 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5648
8f2906f5
JD
56492013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5650
960ce480 5651 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5652 (ns_select): Don't return with result uninitialized.
960ce480 5653
8f2906f5
JD
5654 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5655 and getDirectory.
5656
81519fd2
SM
5657 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5658 New functions.
8f2906f5
JD
5659 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5660 directories. If filename is nil, get directory name (Bug#13932).
5661 Use getFilename and getDirectory.
5662 (getFilename, getDirectory): New methods for EmacsSavePanel and
5663 EmacsOpenPanel.
5664 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5665
cded56c1
PE
56662013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5667
5668 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5669
251e9147 56702013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5671
5672 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5673 (adjust_after_replace): Make it back to static. Delete the third
5674 arg text_at_gap_tail. Cancel the code for handling it.
5675
5676 * coding.h (struct coding_system): New member eol_seen.
5677
5678 * coding.c (detect_ascii): New function.
5679 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5680 when the source bytes are actually scanned. On detecting for
5681 coding_category_utf_8_auto, call detect_ascii instead of scanning
5682 source bytes directly.
5683 (produce_chars): Call insert_from_gap with the new arg 0.
5684 (encode_coding): Likewise.
5685 (decode_coding_gap): Control ASCII optimization by the variable
5686 disable_ascii_optimization instead of #ifndef .. #endif.
5687 Deccode EOL format according to coding->eol_seen.
5688 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5689 variable.
5690
8a44e6d1
KH
5691 * lisp.h (adjust_after_replace): Cancel externing it.
5692 (insert_from_gap): Adjust prototype.
5693
5f795e34
EZ
56942013-03-15 Eli Zaretskii <eliz@gnu.org>
5695
5696 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5697 FULLSCREEN_MAXIMIZED. (Bug#13935)
5698
f258b4be
DA
56992013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5700
5701 * region-cache.c (find_cache_boundary, move_cache_gap)
5702 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5703 Simplify debugging check and convert to eassert. Adjust comment.
5704 (pp_cache): Put under ENABLE_CHECKING.
5705
a5cc4dde
EZ
57062013-03-14 Eli Zaretskii <eliz@gnu.org>
5707
5708 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5709 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5710 and WM_ACTIVATEAPP.
5711 (w32fullscreen_hook): If the frame is visible, reset
5712 f->want_fullscreen flag after changing the frame size. If the
5713 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5714 (Bug#13953)
5715
3fc5e44a
DC
57162013-03-13 Daniel Colascione <dancol@dancol.org>
5717
5718 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5719 too so that these builds can use Cygwin's file conversion
5720 functions. (We've been building and linking cygw32.o all along
5721 and just not using it.)
5722
47d7532e
PE
57232013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5724
5725 File synchronization fixes (Bug#13944).
5726 * Makefile.in (LIB_FDATASYNC): New macro.
5727 (LIBES): Use it.
5728 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5729 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5730 Don't worry about HAVE_FSYNC, since a substitute fsync is
5731 available if the system lacks one.
5732 (Fwrite_regin): Retry fsync if interrupted.
5733
c7ffccaf
EZ
57342013-03-13 Eli Zaretskii <eliz@gnu.org>
5735
4e2df81d 5736 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5737 activated, call w32fullscreen_hook, to make sure the new frame
5738 dimensions are in effect. (Bug#13937)
5739
8a7debc1
DA
57402013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5741
5742 * xdisp.c (init_iterator): Simplify because both character and byte
5743 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5744 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5745 character and byte positions can be obtained from marker.
8a7debc1 5746
7fd8c501
PE
57472013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5748
d9df6f40
PE
5749 Static checking by Sun C 5.12.
5750 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5751 * bytecode.c (exec_byte_code):
5752 * dispnew.c (init_display):
5753 * eval.c (error):
5754 * fileio.c (Fsubstitute_in_file_name):
5755 * keyboard.c (Fevent_convert_list):
5756 * keymap.c (Fsingle_key_description):
5757 * term.c (maybe_fatal, fatal):
5758 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5759 * xsmfns.c (Fhandle_save_session):
5760 Omit unreachable code.
5761 * keymap.c (map_keymap_char_table_item): Cast void * to
5762 a function pointer type; the C Standard requires this.
5763
7fd8c501
PE
5764 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5765 Include <sys/param.h> unconditionally, as that works elsewhere and
5766 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5767 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5768 and FreeBSD now.
5769
a020afb9 5770See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5771
5772;; Local Variables:
5773;; coding: utf-8
aac0c6e3
MR
5774;; End:
5775
ab422c4d 5776 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5777
5778 This file is part of GNU Emacs.
5779
5780 GNU Emacs is free software: you can redistribute it and/or modify
5781 it under the terms of the GNU General Public License as published by
5782 the Free Software Foundation, either version 3 of the License, or
5783 (at your option) any later version.
5784
5785 GNU Emacs is distributed in the hope that it will be useful,
5786 but WITHOUT ANY WARRANTY; without even the implied warranty of
5787 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5788 GNU General Public License for more details.
5789
5790 You should have received a copy of the GNU General Public License
5791 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.