MS-Windows follow-up to 2013-10-10T01:03:11Z!rgm@gnu.org: support giflib 5.x.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a5dab159
EZ
12013-10-10 Eli Zaretskii <eliz@gnu.org>
2
3 * image.c (GIFLIB_MAJOR): Define to 4 if undefined.
4 (GIFLIB_MINOR, GIFLIB_RELEASE): Define to zero if undefined.
5 (GifErrorString) [GIFLIB_MAJOR >= 5]: Define a function pointer.
6 (gif_load): For giflib v5.x and later, display the error message
7 produced by giflib when its functions fail.
8 (syms_of_image) <Qlibgif_version> [HAVE_NTGUI]: New DEFSYM.
9 (Bug#15531)
10
6bbe6da8
DA
112013-10-10 Dmitry Antipov <dmantipov@yandex.ru>
12
13 * keyboard.c (last_event_timestamp): Remove. For X selection and
14 GTK popup menus, it may be obtained from per-frame X display info.
15 (kbd_buffer_store_event_hold, kbd_buffer_get_event)
16 (process_special_events): Adjust users.
17 * keyboard.h (last_event_timestamp): Remove declaration.
18 * xmenu.c (xmenu_show, create_and_show_popup_menu): Lost last arg.
19 Use FRAME_DISPLAY_INFO (f)->last_user_time for gtk_menu_popup.
20 * menu.h (xmenu_show): Adjust prototype.
21 * menu.c (Fx_popup_menu): Adjust user.
22 * xselect.c (x_own_selection, x_get_foreign_selection)
23 (Fx_disown_selection_internal): Use dpyinfo->last_user_time.
24
1afcba63
DA
252013-10-10 Dmitry Antipov <dmantipov@yandex.ru>
26
27 * keyboard.c (init_kboard): Now static. Add arg
28 to denote window system. Adjust comment.
29 (init_keyboard): Adjust user.
30 (allocate_kboard): New function.
31 (syms_of_keyboard):
32 * nsterm.m (ns_term_init):
33 * term.c (init_tty):
34 * w32term.c (w32_create_terminal):
35 * xterm.c (x_term_init): Use it.
36 * keyboard.h (init_kboard): Remove prototype.
37 (allocate_kboard): Add prototype.
38
f3606ef7
BF
392013-10-10 Barry Fishman <barry_fishman@acm.org> (tiny change)
40
41 * image.c (GIFLIB_MAJOR): Ensure it's defined.
42 (DGifOpen, DGifOpenFileName): Handle giflib 5 syntax. (Bug#15531)
43
e20bb249
PE
442013-10-09 Paul Eggert <eggert@cs.ucla.edu>
45
46 * fns.c (sxhash_bool_vector): Fix buffer read overrun.
47
9f6a18d2
EZ
482013-10-09 Eli Zaretskii <eliz@gnu.org>
49
50 * term.c (tty_menu_activate): Flush the output stream after
51 showing the cursor, and don't mark the frame garbaged at exit from
52 the function. Fixes redisplay glitches when moving from one menu
53 to another.
54
0486beac
JD
552013-10-09 Jan Djärv <jan.h.d@swipnet.se>
56
57 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Check input for valid UTF-8
58 or throw error (Bug#15570).
59
0d5d3029
PE
602013-10-09 Paul Eggert <eggert@cs.ucla.edu>
61
ab7ce978
PE
62 * intervals.c (temp_set_point_both): Move test into 'eassert',
63 for speed.
64
0d5d3029
PE
65 * lisp.h (eassert): Don't use 'assume'.
66 Sometimes 'assume' wins in performance, and sometimes it loses,
67 so it shouldn't be used all the time. Perhaps we need two
68 flavors of 'eassert', one for where 'assume' is far more likely
69 to help or to hurt; but that can be done later.
1afcba63 70 Problem reported by Dmitry Antipov in
0d5d3029
PE
71 <http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00276.html>.
72 Also, don't include <verify.h>; no longer needed.
73
fa022909
GM
742013-10-09 Glenn Morris <rgm@gnu.org>
75
76 * eval.c (Fcond): Doc tweak.
77
051277bf
EZ
782013-10-09 Eli Zaretskii <eliz@gnu.org>
79
80 * xfaces.c (x_free_gc) [HAVE_X_WINDOWS, HAVE_NTGUI]: Don't pass
81 expressions with side effects to eassert. (Bug#15565)
82
79804536
SM
832013-10-09 Stefan Monnier <monnier@iro.umontreal.ca>
84
85 * fns.c (hashfn_user_defined): Allow hash functions to return any
86 Lisp_Object.
87
3b158d11
PE
882013-10-08 Paul Eggert <eggert@cs.ucla.edu>
89
90 Fix minor problems found by static checking.
91 * dispnew.c (save_current_matrix): Omit unnecessary casts.
92 * dispnew.c (update_frame_with_menu): Mark debug local as used.
93 * keyboard.c, keyboard.h (Qmouse_movement): Now static.
94 * keyboard.c (read_menu_command): Remove unused local.
95 * lisp.h (read_menu_command): New decl.
96 * menu.c, menu.h (menu_item_width): Arg is now unsigned char *, for
97 benefit of STRING_CHAR_AND_LENGTH. All uses changed.
98 Return ptrdiff_t, not int.
99 * term.c (tty_menu_struct): 'allocated' member is now ptrdiff_t,
100 not int, for benefit of xpalloc.
101 (tty_menu_create, tty_menu_make_room): Simplify by using xzalloc
102 and xpalloc.
103 (have_menus_p): Remove; unused.
104 (tty_menu_add_pane, tty_menu_add_selection): Change signedness of
105 local char * pointer to pacify STRING_CHAR_AND_LENGTH.
106 (tty_menu_add_selection, tty_menu_locate, tty_meny_destroy):
107 Now static.
108 (save_and_enable_current_matrix): Omit unnecessary casts.
109 (read_menu_input): Omit local extern decl (now in lisp.h).
110 Don't access uninitialized storage if mouse_get_xy fails.
111 (tty_menu_activate): Mark local as initialized, for lint.
112 (tty_menu_activate, tty_meny_show): Remove unused locals.
113
4ed77415
EZ
1142013-10-08 Eli Zaretskii <eliz@gnu.org>
115
116 Support menus on text-mode terminals.
117 * xterm.h (xw_popup_dialog): Add prototype.
118
119 * xmenu.c (Fx_popup_dialog): Function moved to menu.c.
120 (xmenu_show): Block input here, instead in Fx_popup_menu.
121 (xw_popup_dialog): New function, with X-specific bits of popup
122 dialogs.
123
124 * xdisp.c (deep_copy_glyph_row, display_tty_menu_item): New
125 functions.
126
127 * window.c (Fset_window_configuration): Use run-time tests of the
128 frame type instead of compile-time conditionals, when menu-bar
129 lines are considered.
130
131 * w32term.h (w32con_hide_cursor, w32con_show_cursor)
132 (w32_popup_dialog): New prototypes.
133
134 * w32menu.c (Fx_popup_dialog): Function deleted.
135 (w32_popup_dialog): New function, with w32 specific bits of popup
136 dialogs. Block input here.
137
138 * w32inevt.c (w32_console_read_socket): Minor change to add
139 debugging TTY events.
140
141 * w32fns.c (show_hourglass): If returning early because the frame
142 is not a GUI frame, unblock input.
143
144 * w32console.c (w32con_hide_cursor, w32con_show_cursor, cursorX)
145 (cursorY): New functions.
146
147 * termhooks.h (cursorX, cursorY): Prototypes of functions on
148 WINDOWSNT, macros that call curX and curY elsewhere.
149
150 * termchar.h (struct tty_display_info) <showing_menu>: New flag.
151
152 * term.c (tty_hide_cursor, tty_show_cursor) [WINDOWSNT]: Call w32
153 specific function to hide and show cursor on a text-mode terminal.
154 (tty_menu_struct, struct tty_menu_state): New structures.
155 (tty_menu_create, tty_menu_make_room, tty_menu_search_pane)
156 (tty_menu_calc_size, mouse_get_xy, tty_menu_display)
157 (have_menus_p, tty_menu_add_pane, tty_menu_add_selection)
158 (tty_menu_locate, save_and_enable_current_matrix)
159 (restore_desired_matrix, screen_update, read_menu_input)
160 (tty_menu_activate, tty_menu_destroy, tty_menu_help_callback)
161 (tty_pop_down_menu, tty_menu_last_menubar_item)
162 (tty_menu_new_item_coords, tty_menu_show): New functions.
163 (syms_of_term): New DEFSYMs for tty-menu-* symbols.
164
165 * nsterm.h (ns_popup_dialog): Adjust prototype.
166
167 * nsmenu.m (ns_menu_show): Block and unblock input here, instead
168 of in x-popup-menu.
169 (ns_popup_dialog): Adapt order of arguments to the other
170 *_menu_show implementations.
171 (Fx_popup_dialog): Function deleted.
172
173 * msdos.c (x_set_menu_bar_lines): Delete unused function.
174
175 * menu.h (tty_menu_show, menu_item_width): provide prototypes.
176
177 * menu.c (have_boxes): New function.
178 (single_keymap_panes): Use it instead of a compile-time
179 conditional.
180 (single_menu_item): Use run-time tests of the frame type instead
181 of compile-time conditionals.
182 (encode_menu_string): New function.
183 (list_of_items, list_of_panes): Use it instead of ENCODE_STRING
184 the macro, since different types of frame need different encoding
185 of menu items.
186 (digest_single_submenu): Use run-time tests of frame type instead
187 of, or in addition to, compile-time conditionals.
188 (menu_item_width, Fmenu_bar_menu_at_x_y): New functions.
189 (Fx_popup_menu): Detect when the function is called from keyboard
190 on a TTY. Don't barf when invoked on a text-mode frame. Check
191 frame type at run time, instead of compile-time conditionals for
192 invoking terminal-specific menu-show functions. Call
193 tty_menu_show on text-mode frames.
194 (Fx_popup_dialog): Moved here from xmenu.c. Test frame types at
195 run time to determine which alternative to invoke; support dialogs
196 on TTYs.
197
198 * keyboard.h <Qmouse_movement>: Declare.
199
200 * keyboard.c <Qmouse_movement>: Now extern.
201 <Qecho_keystrokes>: New static variable.
202 (read_key_sequence): Accept an additional argument, a flag to
203 prevent redisplay during reading of the key sequence. All callers
204 changed.
205 (read_menu_command): New function.
206 (read_char): When COMMANDFLAG is -2, do not redisplay and do not
207 autosave.
208 (toolkit_menubar_in_use): New function.
209 (make_lispy_event): Use it instead of a compile-time test.
210
211 * fns.c (Fyes_or_no_p) [HAVE_MENUS]: Don't condition on
212 window-system being available.
213
214 * editfns.c (Fmessage_box) [HAVE_MENUS]: Don't condition the call
215 to x-popup-dialog on the frame type, they all now support popup
216 dialogs.
217
218 * dispnew.c (save_current_matrix): Save the margin areas.
219 (restore_current_matrix): Restore margin areas.
220 (update_frame_with_menu): New function.
221
222 * dispextern.h (display_tty_menu_item, update_frame_with_menu):
223 Add prototypes.
224
225 * alloc.c (make_save_ptr): Now compiled unconditionally.
226
ecab13d4
DA
2272013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * dispnew.c (set_window_update_flags): Add buffer arg. Adjust comment.
230 (redraw_frame, update_frame): Adjust users.
231 * dispextern.h (set_window_update_flags): Adjust prototype.
232 * xdisp.c (redisplay_internal): When updating all frames with zero
233 windows_or_buffers_changed, assume that only the windows that shows
234 current buffer should be really updated.
235
f8498081
DA
2362013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
237
238 Do not allocate huge temporary memory areas and objects while encoding
239 for file I/O, thus reducing an enormous memory usage for large buffers.
240 See http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00180.html.
241 * coding.h (struct coding_system): New member raw_destination.
242 * coding.c (setup_coding_system): Initialize it to zero.
243 (encode_coding_object): If raw_destination is set, do not create
244 dst_object. Add comment.
245 * fileio.c (toplevel): New constant E_WRITE_MAX.
246 (e_write): Do not encode more than E_WRITE_MAX characters per one loop
247 iteration. Use raw_destination if E_WRITE_MAX characters is encoded.
248
d180bde8
JD
2492013-10-08 Jan Djärv <jan.h.d@swipnet.se>
250
251 * nsterm.m (windowDidExitFullScreen:):
252 (toggleFullScreen:): Change NS_IMPL_COCOA to HAVE_NATIVE_FS.
253
87c4314d
PE
2542013-10-08 Paul Eggert <eggert@cs.ucla.edu>
255
18978362
PE
256 Fix race where emacs aborts when sent SIGTERM (Bug#15534).
257 * keyboard.c (unblock_input_to): Don't process pending signals
258 if a fatal error is in progress.
259
87c4314d
PE
260 * lisp.h (bits_word, BITS_WORD_MAX): New type and macro.
261 All uses of 'size_t' and 'SIZE_MAX' changed to use them, when
262 they're talking about words in Lisp bool vectors.
263 (BITS_PER_BITS_WORD): Rename from BITS_PER_SIZE_T. All uses changed.
1142cc2a
PE
264 * data.c (popcount_bits_word): Rename from popcount_size_t.
265 (bits_word_to_host_endian): Rename from size_t_to_host_endian.
266 All uses changed.
87c4314d 267
595e113b
PE
2682013-10-07 Paul Eggert <eggert@cs.ucla.edu>
269
270 Improve support for popcount and counting trailing zeros (Bug#15550).
271 * data.c: Include <count-one-bits.h>, <count-trailing-zeros.h>.
272 (USE_MSC_POPCOUNT, POPCOUNT_STATIC_INLINE)
273 (NEED_GENERIC_POPCOUNT, popcount_size_t_generic)
274 (popcount_size_t_msc, popcount_size_t_gcc):
275 Remove; now done by Gnulib.
276 (popcount_size_t): Now a macro that defers to Gnulib.
277 (count_trailing_zero_bits): Return int, for consistency with
278 Gnulib and because Emacs prefers signed to unsigned int.
279 Don't assume that size_t is either unsigned int or unsigned long
280 or unsigned long long.
281 (size_t_to_host_endian): Do not assume that size_t is either
282 exactly 32 or exactly 64 bits wide.
283 * lisp.h (BITS_PER_SIZE_T): Define consistently with BITS_PER_LONG
284 etc., so that it's now an enum constant, not a macro.
285 No need to assume that it's either 32 or 64.
286
ddb317ba
JD
2872013-10-07 Jan Djärv <jan.h.d@swipnet.se>
288
289 * nsterm.m (windowDidEnterFullScreen:): setPresentationOptions only
290 on >= 10.7.
291
bd74250f
DA
2922013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
293
294 * insdel.c (insert_from_gap): Prefer ptrdiff_t to int where needed.
764636db 295 * xdisp.c (handle_fontified_prop): Likewise. Use bool for boolean.
bd74250f 296
223752d7
PE
2972013-10-07 Paul Eggert <eggert@cs.ucla.edu>
298
299 emacs_read and emacs_write now use void *, not char *.
300 * alloc.c (valid_pointer_p) [!WINDOWSNT]: Remove now-unnecessary cast.
301 * sysdep.c (emacs_read, emacs_write, emacs_write_sig):
302 Buffer arg is now void *, not char *. This matches plain
303 'read' and 'write' better, and avoids a constraint violation
304 on Solaris 9 with Oracle Studio.
305
3c439e0a
DA
3062013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
307
308 * alloc.c (Fmake_string): For ASCII char initializer, prefer
309 memset to explicit loop. Otherwise copy largest possible chunk
310 from initialized to uninitialized part, thus allowing the longer
311 memcpy runs and reducing the number of loop iterations.
312
28c76099
JD
3132013-10-06 Jan Djärv <jan.h.d@swipnet.se>
314
315 * nsterm.m (ns_update_begin): If native fullscreen and no toolbar,
316 hide toolbar (Bug#15388).
317 (windowDidEnterFullScreen:): If presentation options are zero,
318 set them here (Bug#15388).
a3e9050c
JD
319 (ns_update_auto_hide_menu_bar): Remove runtime check.
320 Don't auto hide dock unless menubar is also auto hidden.
28c76099 321
544a2a80
XF
3222013-10-05 Xue Fuqiao <xfq.free@gmail.com>
323
324 * editfns.c (message): Mention batch mode in doc string.
325
a27fd309
JD
3262013-10-05 Jan Djärv <jan.h.d@swipnet.se>
327
328 * nsterm.m (check_native_fs): Remove erroneous comment.
329
942f6f82
DA
3302013-10-04 Dmitry Antipov <dmantipov@yandex.ru>
331
332 * xdisp.c (redisplay_internal): Simplify because scan_for_column now
333 uses find_newline instead of scan_newline and so doesn't move point.
334
157fec2e
PE
3352013-10-04 Paul Eggert <eggert@cs.ucla.edu>
336
4eed3157
PE
337 Use hardware support for byteswapping on glibc x86 etc.
338 On Fedora 19 x86-64, the new bswap_64 needs 1 instruction,
339 whereas the old swap64 needed 30.
340 * fringe.c (init_fringe_bitmap) [WORDS_BIGENDIAN]:
341 * sound.c (le2hl, le2hs, be2hl) [!WINDOWSNT]:
342 Use byteswap.h's macros to swap bytes.
343 * lisp.h (swap16, swap32, swap64): Remove.
344 All uses replaced by bswap_16, bswap_32, bswap_64.
345
157fec2e
PE
346 * bytecode.c (exec_byte_code): Use some more volatile variables
347 to work around local variables getting clobbered by longjmp.
348 Port to pre-C99, which doesn't allow decls after stmts.
349
b52f569d
PE
3502013-10-03 Paul Eggert <eggert@cs.ucla.edu>
351
75273afb
PE
352 * lisp.h (eassert): Assume that COND is true when optimizing.
353 In other words, take on the behavior of eassert_and_assume.
354 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
355 (eassert_and_assume): Remove. All uses replaced by eassert.
356
ead45345
PE
357 * xdisp.c (Qglyphless_char): Now static.
358
0a858ebf
PE
359 Adjust to merge from gnulib.
360 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
361 * lisp.h: Include <verify.h>, for 'assume'.
362
b52f569d
PE
363 * eval.c (clobbered_eassert): New macro.
364 (internal_catch, internal_condition_case)
365 (internal_condition_case_1, internal_condition_case_2)
366 (internal_condition_case_n): Use it instead of eassert
367 when the argument contains locals clobbered by longjmp.
368 Don't use clobbered locals outside of clobbered_eassert.
369 (internal_lisp_condition_case): Use a volatile variable
370 to work around a local variable's getting clobbered.
371
adf2aa61
SM
3722013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
373
374 * lisp.h (struct handler): Merge struct handler and struct catchtag.
375 (PUSH_HANDLER): New macro.
376 (catchlist): Remove.
377 (handlerlist): Always declare.
378
379 * eval.c (catchlist): Remove (merge with handlerlist).
380 (handlerlist, lisp_eval_depth): Not static any more.
381 (internal_catch, internal_condition_case, internal_condition_case_1)
382 (internal_condition_case_2, internal_condition_case_n):
383 Use PUSH_HANDLER.
384 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
385 handlerlist/catchlist.
386 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
387 handlerlist which can only handle a single condition-case handler at
388 a time.
389 (find_handler_clause): Simplify since we only a single branch here
390 any more.
391
392 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
393 and Bpophandler.
394 (bcall0): New function.
395 (exec_byte_code): Add corresponding cases. Improve error message when
396 encountering an invalid byte-code. Let Bunwind_protect accept
397 a function (rather than a list of expressions) as argument.
398
399 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
400 and make them unconditional now that they're heap-allocated.
401
328a8179
SM
4022013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
403
404 * charset.c (Fdecode_char, Fencode_char): Remove description of
405 `restriction' arg. now that it's hidden by advertised-calling-convention.
406
c348360a
JD
4072013-10-02 Jan Djärv <jan.h.d@swipnet.se>
408
328a8179
SM
409 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
410 Remove unused variable (from mac-port).
c348360a
JD
411 (macfont_draw): Use s->ybase for correct y position.
412
1a23cd48
DA
4132013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
414
415 * frame.h (struct frame): Drop has_minibuffer member because...
416 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
417 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
418
29bf4de4
DA
4192013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
420
421 * window.h (struct window): Prefer enum text_cursor_kinds to int
422 for phys_cursor_type member. Move the latter, phys_cursor_width,
423 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
424 * window.c (replace_window, make_window): Adjust users.
425
a30ddace
DA
4262013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
427
428 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
429 this module is never compiled otherwise.
430
45435f08
AA
4312013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
432
433 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
434 (Bug#15500).
435
92e5298b
EZ
4362013-09-29 Eli Zaretskii <eliz@gnu.org>
437
438 * xdisp.c (get_next_display_element): Don't call face_for_font in
439 a build configured --without-x. (Bug#15484)
440
caa50be2
JD
4412013-09-29 Jan Djärv <jan.h.d@swipnet.se>
442
66d13b20
JD
443 * window.c (calc_absolute_offset): #elif should be #elif defined.
444
caa50be2
JD
445 * frame.c (delete_frame): Block/unblock input to overcome race
446 condition (Bug#15475).
447
d3e2acb6
AP
4482013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
449
450 * frame.c (delete_frame): Record selected frame only after
451 calling Qdelete_frame_functions (Bug#15477).
452
1610938f
JD
4532013-09-28 Jan Djärv <jan.h.d@swipnet.se>
454
455 * nsterm.m (ns_selection_color): Remove.
456 (ns_get_color): Check for ns_selection_(fg|bg)_color using
457 NSColor selectedText(Background)Color. Only for COCOA.
458 (ns_term_init): Remove assignment of ns_selection_color, logic
459 moved to ns_get_color.
460
328a8179 461 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
462 NS_SELECTION_COLOR_DEFAULT.
463 (NS_SELECTION_FG_COLOR_DEFAULT): New.
464
0d2647e6
EZ
4652013-09-28 Eli Zaretskii <eliz@gnu.org>
466
467 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
468 frame' does not have the tool_bar_window member.
469
ba355de0
BR
4702013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
471
472 Signal error when reading an empty byte-code object (Bug#15405)
473 * lread.c (read1): signal error
474 * alloc.c (make_byte_code): eassert header size
475 (sweep_vectors): change an int to size_t
476
4710d6f4
PE
4772013-09-24 Paul Eggert <eggert@cs.ucla.edu>
478
cf647d93
PE
479 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
480 instead of ints, as it's the usual style for offsetof constants. See:
481 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
482
4710d6f4
PE
483 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
484 This is ugly, but it should fix the performance problem for older
485 GCC versions in the short run. I'll look into integrating the
486 Gnulib module for popcount, as a better fix.
487 See the thread starting in:
488 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
489 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
490 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
491 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
492 (popcount_size_t): Use it.
493
10ebac9d
DC
4942013-09-24 Daniel Colascione <dancol@dancol.org>
495
496 * process.c (Fnetwork_interface_info): Fix build break due to
497 vector changes.
498
9da0f50e
PE
4992013-09-24 Paul Eggert <eggert@cs.ucla.edu>
500
501 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
502 Prefer signed to unsigned integers where either will do.
503 No need for 'const' on locals that do not escape.
504 Omit easserts with unnecessary and unportable assumptions about
505 alignment. Avoid unnecessary casts to char *.
506
d6d9cbc1
DA
5072013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
508
509 Use union for the payload of struct Lisp_Vector.
510 This helps to avoid a few glitches dictated by C's aliasing rules.
511 * lisp.h (struct Lisp_Vector): Use union for next and
512 contents member. Adjust comment. Change related users.
513 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
514 Related users changed.
515 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
516 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
517 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
518 * xfaces.c, xfont.c, xmenu.c: Related users changed.
519
ec7bc82f
DA
5202013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
521
522 Optimize glyph row clearing and copying routines.
523 * dispextern.h (struct glyph_row): Change layout of struct
524 glyph_row to help copy_row_except_pointers. Adjust comment.
525 * dispnew.c (null_row): Remove.
526 (clear_glyph_row): Use offsetof and memset to find and clear
527 just the members that need clearing. Adjust comment.
528 (copy_row_except_pointers): Likewise for copying.
529
d160dd0c
PE
5302013-09-24 Paul Eggert <eggert@cs.ucla.edu>
531
7be68de5
PE
532 Some minor cleanups of recently-added bool vector code.
533 * conf_post.h (assume): Always return void. Use lint version
534 only if GCC and MSC versions don't apply.
535 * conf_post.h (assume):
536 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
537 Depend on _MSC_VER, not __MSC_VER, for consistency with
538 the rest of Emacs.
539 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
540 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
541 (bool_vector_binop_driver, count_trailing_zero_bits)
542 (size_t_to_host_endian): Now static, not static inline;
543 the latter isn't needed with modern compilers and doesn't
544 work with older compilers anyway.
545
d160dd0c
PE
546 * alloc.c (valgrind_p): Use bool for boolean.
547
e08813d0
DA
5482013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
549
550 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
551 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
552 (display_last_displayed_message_p, message_buf_print)
553 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
554 Use bool for boolean.
3a6a78fd
DA
555 * dispextern.h (cancel_line, init_desired_glyphs):
556 Remove ancient leftover.
557 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
558 * lisp.h (noninteractive_need_newline): Adjust declaration.
559
5492865b
DA
5602013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
561
562 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
563 Move to...
564 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
565 ...this file and convert the latter to static. Adjust comment.
566 (make_initial_frame):
567 * window.c (init_window_once): Adjust user.
568 * frame.h (last_nonminibuf_frame): Remove declaration.
569 * lisp.h (selected_frame): Likewise.
570 * msdos.c (the_only_display_info): Adjust comment.
571
cd548fa4
EZ
5722013-09-23 Eli Zaretskii <eliz@gnu.org>
573
f03eddbf
EZ
574 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
575 computing the end column of mouse-highlight that comes from
576 display or overlay strings. (Bug#15437)
b519df23
EZ
577 (note_mouse_highlight): Adapt calculation of last argument to
578 mouse_face_from_string_pos to the above change.
f03eddbf 579
cd548fa4
EZ
580 * conf_post.h (__has_builtin): Define to zero, if undefined, on
581 all platforms, not just for clang.
582
8762e524
JD
5832013-09-23 Jan Djärv <jan.h.d@swipnet.se>
584
585 * filelock.c (lock_file_1): Rearrange to remove compiler warning
586 about excess arguments to snprintf.
587
588 * conf_post.h(assume): Use __builtin_unreachable for clang.
589
d4a9284f
JB
5902013-09-23 Juanma Barranquero <lekktu@gmail.com>
591
592 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
593 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
594
a84683fd
DC
5952013-09-23 Daniel Colascione <dancol@dancol.org>
596
597 * alloc.c (USE_VALGRIND): New macro; on by default
598 when ENABLE_CHECKING.
599 (mark_maybe_object,mark_maybe_pointer)
600 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
601 valgrind purposes.
602 (valgrind_p) [USE_VALGRIND]: New variable.
603 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
604
8fef36c6
JD
6052013-09-22 Jan Djärv <jan.h.d@swipnet.se>
606
fb83ea63
JD
607 * process.c (wait_reading_process_output): Change int pnamelen to
608 socklen_t.
609
610 * nsterm.m (setMarkedText:selectedRange:):
611 (deleteWorkingText):
612 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
613 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
614 argument to unsigned long to avoid warning.
615 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
616
8fef36c6
JD
617 * conf_post.h (assume): Fix compiler error: x shall be cond.
618
cd9356f2
DC
6192013-09-22 Daniel Colascione <dancol@dancol.org>
620
621 * xfns.c (x_get_monitor_attributes): Suppress unused variable
622 warning when compiling without a window system.
623
3e0b94e7
DC
6242013-09-22 Daniel Colascione <dancol@dancol.org>
625
626 * data.c (Qbool_vector_p): New symbol.
627 (bool_vector_spare_mask,popcount_size_t_generic)
628 (popcount_size_t_msc,popcount_size_t_gcc)
629 (popcount_size_t)
630 (bool_vector_binop_driver)
631 (count_trailing_zero_bits,size_t_to_host_endian)
632 (Fbool_vector_exclusive_or)
633 (Fbool_vector_union)
634 (Fbool_vector_intersection,Fbool_vector_set_difference)
635 (Fbool_vector_subsetp,Fbool_vector_not)
636 (Fbool_vector_count_matches)
637 (Fbool_vector_count_matches_at): New functions.
638 (syms_of_data): Intern new symbol, functions.
639 * alloc.c (bool_vector_payload_bytes): New function.
640 (Fmake_bool_vector): Instead of calling Fmake_vector,
641 which performs redundant initialization and argument checking,
642 just call allocate_vector ourselves. Make sure we clear any
643 terminating padding to zero.
644 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
645 instead of open-coding the size calculation.
646 (vroundup_ct): New macro.
647 (vroundup): Assume argument >= 0; invoke vroundup_ct.
648 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
649 * composite.c (composition_gstring_put_cache):
650 Change lint_assume to assume.
3e0b94e7
DC
651 * conf_post.h (assume): New macro.
652 (lint_assume): Remove.
653 * dispnew.c (update_frame_1): Change lint_assume to assume.
654 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
655 to assume.
656 * image.c (gif_load): Change lint_assume to assume.
657 * lisp.h (eassert_and_assume): New macro.
658 (Qbool_vector_p): Declare.
659 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
660 (swap16,swap32,swap64): New inline functions.
661 * macfont.c (macfont_shape): Change lint_assume to assume.
662 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
663 * xsettings.c (parse_settings): Use new swap16 and
664 swap32 from lisp.h instead of file-specific macros.
665
76880d88
EZ
6662013-09-22 Eli Zaretskii <eliz@gnu.org>
667
668 * xdisp.c (try_window_id): Don't abort if cursor row could not be
669 found (which can legitimately happen when the glyph row at the
670 window start is disabled in the current_matrix. (Bug#15365)
671
c6cfd910
PE
6722013-09-22 Paul Eggert <eggert@cs.ucla.edu>
673
674 Fix syntax.h bug introduced by recent INLINE change.
675 syntax.h defined an extern inline function SYNTAX_ENTRY that was
676 conditionally compiled one way in some modules, and a different
677 way in others. This doesn't work with extern inline functions,
678 which must have the same definition in all modules, because the
679 defining code might be shared across modules, depending on the
680 implementation. Symptoms reported by Martin Rudalics in:
681 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
682 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
683 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
684 overriding the corresponding functions in syntax.h.
685 * syntax.h (syntax_property_entry, syntax_property_with_flags)
686 (syntax_property): New inline functions.
687 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
688 Rewrite in terms of these new functions.
689
b3f1d119
EZ
6902013-09-21 Eli Zaretskii <eliz@gnu.org>
691
692 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
693 not chars_in_text, whose result depends on the multibyteness of
694 the current buffer. (Bug#15426)
695
00382e8b
PE
6962013-09-20 Paul Eggert <eggert@cs.ucla.edu>
697
e3b29769
PE
698 Port recent change to hosts where pointers aren't 'long'.
699 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
700 Don't assume that pointers are the same width as 'long'.
701 Add a compile-time check that a pointer fits into two X slots.
702
00382e8b
PE
703 A simpler, centralized INLINE.
704 * conf_post.h (INLINE): Define only if not already defined.
705 This allows us to use a single INLINE, defined by one file
706 per executable.
707 * emacs.c (INLINE): Define it.
708 Also, include category.h, charset.h, composite.h, dispextern.h,
709 syntax.h, systime.h, so that their INLINE definitions are expanded
710 properly for Emacs.
711 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
712 * buffer.h, buffer.c (BUFFER_INLINE):
713 * category.h, category.c (CATEGORY_INLINE):
714 * character.h, character.c (CHARACTER_INLINE):
715 * charset.h, charset.c (CHARSET_INLINE):
716 * composite.h, composite.c (COMPOSITE_INLINE):
717 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
718 * frame.h, frame.c (FRAME_INLINE):
719 * intervals.h, intervals.c (INTERVALS_INLINE):
720 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
721 * lisp.h, alloc.c (LISP_INLINE):
722 * process.h, process.c (PROCESS_INLINE):
723 * syntax.h, syntax.c (SYNTAX_INLINE):
724 * systime.h, sysdep.c (SYSTIME_INLINE):
725 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
726 * window.h, window.c (WINDOW_INLINE):
727 Remove. All uses replaced with INLINE.
728
2b943ba6
DA
7292013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
730
731 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
732 to avoid Bug#15398.
733
13d9698a
EZ
7342013-09-19 Eli Zaretskii <eliz@gnu.org>
735
736 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
737 'const char *' to avoid compiler warnings due to similar change in
738 the prototype of x_get_string_resource.
739
ced135eb
DA
7402013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
741
742 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
743 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
744 going to replace static variables below. Adjust comments.
745 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
746 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
747 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
748 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
749 Related users changed.
750 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
751 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
752 last_mouse_movement_time, going to replace static variables below.
753 Adjust comments.
754 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
755 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
756 Remove.
757 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
758 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
759 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
760 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
761 static variables below.
762 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
763 (last_mouse_scroll_bar): Remove.
764 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
765 (mouseExited): Related users changed.
766
091f1e1f
DA
7672013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
768
769 Do not use external array to process X scroll bar messages.
770 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
771 (x_send_scroll_bar_event): Pack window pointer into two slots
772 of XClientMessageEvent if we're 64-bit. Adjust comment.
773 (x_scroll_bar_to_input_event): Unpack accordingly.
774
582ed56c
DA
7752013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
776
777 Ifdef away recent changes which aren't relevant to NS port.
778 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
779 [!HAVE_NS]: Declare as such.
780 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
781 [!HAVE_NS]: Define as such.
782
18da0d8a
DA
7832013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
784
785 * frame.c (x_redo_mouse_highlight): New function
786 to factor out common code used in W32 and X ports.
787 * dispextern.h (x_redo_mouse_highlight): Add prototype.
788 * xterm.h (struct x_display_info):
789 * w32term.h (struct w32_display_info):
790 * nsterm.h (struct ns_display_info): New members
791 last_mouse_motion_frame, last_mouse_motion_x and
792 last_mouse_motion_y, going to replace static variables below.
793 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
794 (redo_mouse_highlight): Remove.
795 (note_mouse_movement, syms_of_xterm): Adjust user.
796 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
797 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
798 (redo_mouse_highlight): Remove.
799 (note_mouse_movement, syms_of_w32term): Adjust user.
800 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
801 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
802 Remove.
803 (note_mouse_movement, mouseMoved, syms_of_nsterm):
804 * nsfns.m (compute_tip_xy): Adjust user.
805
7a0c745a
DA
8062013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
807
808 * frame.c (x_mouse_grabbed): New function.
809 * dispextern.h (x_mouse_grabbed): Add prototype.
810 (last_mouse_frame): Remove declaration.
811 * xterm.h (struct x_display_info):
812 * w32term.h (struct w32_display_info):
813 * nsterm.h (struct ns_display_info): New member
814 last_mouse_frame, going to replace...
815 * xdisp.c (last_mouse_frame): ...global variable.
816 (note_tool_bar_highlight):
817 * w32term.c (w32_mouse_position, w32_read_socket):
818 * xterm.c (XTmouse_position, handle_one_xevent):
819 Use x_mouse_grabbed.
820 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
821
0791d107
DA
8222013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
823
824 * w32term.c (w32_read_socket): Avoid temporary
825 variables in a call to x_real_positions.
826 * xterm.c (handle_one_xevent): Likewise.
827
2cd98812
DA
8282013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
829
830 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
831 (x_icon_type): Remove prototype.
832 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
833 * frame.c (x_icon_type): Remove.
834 * w32term.c (x_make_frame_visible, x_iconify_frame):
835 * xterm.c (x_make_frame_visible, x_iconify_frame):
836 Use x_set_bitmap_icon to factor out common code.
837
a6c2ee1b
DA
8382013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
839
840 * dispextern.h (check_x_display_info, x_get_string_resource):
841 Declare here just once and unify the latter.
842 * frame.c (check_x_display_info, x_get_string_resource):
843 * nsterm.h (check_x_display_info):
844 * xrdb.c (x_get_string_resource):
845 * xterm.h (check_x_display_info): Remove prototypes.
846 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
847 * w32reg.c (x_get_string_resource): Likewise.
848 (w32_get_rdb_resource): Adjust user.
849
baed3603
DA
8502013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
851
852 * xterm.h (struct x_display_info): New member
853 x_pending_autoraise_frame, going to replace...
854 * xterm.c (pending_autoraise_frame): ...static variable.
855 (x_new_focus_frame, XTread_socket): Adjust users.
856 * w32term.h (struct w32_display_info): New member
857 w32_pending_autoraise_frame, going to replace...
858 * w32term.c (pending_autoraise_frame): ...global variable.
859 (x_new_focus_frame, w32_read_socket): Adjust users.
860
90582f05
GM
8612013-09-17 Glenn Morris <rgm@gnu.org>
862
863 * xdisp.c (message_dolog): If we create *Messages*,
864 switch it to messages-buffer-mode.
865
b7ad2f74
PE
8662013-09-17 Paul Eggert <eggert@cs.ucla.edu>
867
868 Don't overuse 'const' in types of locals.
869 * bidi.c (bidi_count_bytes):
870 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
871 (xg_event_is_for_scrollbar):
872 * xselect.c (x_handle_property_notify)
873 (x_handle_selection_notify, x_handle_dnd_message):
874 * xsettings.c, xsettings.h (xft_settings_event):
875 * xterm.c (x_handle_net_wm_state, handle_one_event)
876 (x_menubar_window_to_frame, x_detect_focus_change)
877 (construct_mouse_click, note_mouse_movement)
878 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
879 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
880 (handle_one_xevent, x_handle_net_wm_state):
881 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
882 (x_handle_dnd_message):
883 Avoid unnecessary 'const', typically the second 'const' in
884 'const foo * const arg', a 'const' that does not affect the API
885 and doesn't significantly help the human reader.
886
19452b86
DA
8872013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
888
889 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
890 only if Glib < 2.36.0.
891 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
892 * xsettings.c (init_gconf, init_gsettings): Do not check
893 for g_type_init.
1893694e
DA
894 * xterm.c (handle_one_xevent): Do not call to x_clear_area
895 if GTK >= 2.7.0.
33b83dd7 896 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 897
6434e343
JD
8982013-09-16 Jan Djärv <jan.h.d@swipnet.se>
899
3f386383
JD
900 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
901 before calling g_type_init.
902
6434e343
JD
903 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
904
905 * nsterm.m (syms_of_nsterm): ... to here.
906
83a119f8
DA
9072013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
908
909 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
910 (ignore_next_mouse_click_timeout): Use Time as X does.
911 (handle_one_xevent): Avoid cast and use unsigned comparison.
912
61582e6a
DA
9132013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
914
915 Do not copy X event in handle_one_xevent except KeyPress case.
916 Wnen XEvent is processed, it is unlikely to be changed except
917 KeyPress case, so we can avoid copying and use const pointer to
918 const data to make sure that an event is not changed elsewhere.
919 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
920 const' and do not create local copy except for the KeyPress event.
921 Use casts to avoid a few glitches. Adjust formatting. Add comments.
922 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
923 (x_handle_net_wm_state, x_menubar_window_to_frame)
924 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
925 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
926 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
927 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
928 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
929 (x_handle_dnd_message):
930 * xsettings.c (xft_settings_event):
931 Use 'const XEvent * const' where appropriate.
932 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
933
f8eb1572
DA
9342013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
935
936 Fix X event waiting to handle multiple frames.
937 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
938 * xterm.c (pending_event_wait): Remove. Adjust users.
939 (x_detect_focus_change): Pass frame arg.
940 (handle_one_xevent): Find related frame early and clear per-frame
941 wait_event_type only if this is an event for the relevant frame.
942 (x_wait_for_event): Use per-frame wait_event_type.
943
3fa2054e
JD
9442013-09-15 Jan Djärv <jan.h.d@swipnet.se>
945
745d3809
JD
946 * nsfns.m (Fx_create_frame): Fix font driver registration for
947 GNUStep.
948
949 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
950 for syms_of_macfont.
951
3fa2054e
JD
952 * nsterm.m: Include macfont.h.
953 (ns_tmp_flags, ns_tmp_font): Remove.
954 (ns_compute_glyph_string_overhangs): Check for driver Qns.
955 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
956 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
957 (changeFont:): Fix code style. Check for font driver type when
958 getiing font.
959
960 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
961 (f)->descent.
962
963 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
964 (nsfont_open): Set font driver type.
965 Set font->ascent and font->descent. Figure out font instead of
966 ns_tmp_font, and flags instead of ns_tmp_flags.
967 Fix indentation. Remove call to ns_draw_text_decoration,
968 moved to nsterm.
969
970 * nsfns.m: Include macfont.h.
971 (Fx_create_frame): Register macfont driver, make a better default font.
972 (Fns_popup_font_panel): Get font from macfont driver, if used.
973
974 * macfont.m, macfont.h, maccuvs.h: New files.
975
976 * font.h: Declare syms_of_macfont.
977
978 * font.c (syms_of_font): Call syms_of_macfont.
979
980 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
981
0eed0355
DA
9822013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
983
984 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
985 and it is always zero for others, so I assume that this is an ancient
986 leftover which nobody will want to change any more.
987 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
988 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
989 * frame.c (x_set_scroll_bar_width):
990 * w32fns.c (w32_createscrollbar):
991 * w32term.c (w32_set_vertical_scroll_bar):
992 * xfns.c (x_set_scroll_bar_default_width):
993 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
994 (x_scroll_bar_expose): Related users changed.
995
07013c68
DA
9962013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
997
998 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
999 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
1000 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
1001 Define as such.
c7cc32f7
DA
1002 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
1003 Define once here...
1004 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
1005 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
1006 Remove unused Xisms.
7f09455e
DA
1007 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
1008 these modules are never compiled otherwise.
07013c68 1009
0df00f59
EZ
10102013-09-14 Eli Zaretskii <eliz@gnu.org>
1011
08a209bf 1012 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
1013 Doc fix. (Bug#15375)
1014
fcd42c11
DA
10152013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1016
1017 Unify Fx_focus_frame between all ports.
1018 * frame.h (x_focus_frame): New prototype.
1019 * xfns.c (Fx_focus_frame): Remove.
1020 (syms_of_xfns): Do not defsubr it.
1021 (x_focus_frame): X implementation.
1022 * nsfns.m (Fx_focus_frame): Remove.
1023 (syms_of_nsfns): Do not defsubr it.
1024 (x_focus_frame): NS implementation.
1025 * w32term.c (Fx_focus_frame): Remove.
1026 (x_focus_on_frame): Rename to...
1027 (x_focus_frame): W32 implementation.
1028 * w32term.h (x_focus_on_frame): Remove prototype.
1029 * w32fns.c (Fx_focus_frame): Remove.
1030 (syms_of_w32fns): Do not defsubr it.
1031 * frame.c (Fx_focus_frame): Define here.
1032 (syms_of_frame): Defsubr here.
1033 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
1034
aad3612f
DA
10352013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1036
1037 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
1038 All of them are replaced with FRAME_DISPLAY_INFO, defined in
1039 each port to reference the port-specific window system data.
1040 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
1041 (FRAME_DISPLAY_INFO): Define.
1042 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
1043 (FRAME_DISPLAY_INFO): Define. Adjust users.
1044 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
1045 (FRAME_DISPLAY_INFO): Define. Adjust users.
1046 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
1047 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
1048 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
1049 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
1050 * xselect.c, xterm.c: All related users changed.
1051
9a650e62
DA
10522013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 * xterm.h (x_window_to_frame, x_any_window_to_frame)
1055 (x_menubar_window_to_frame): Remove prototypes.
1056 * xfns.c (x_window_to_frame, x_any_window_to_frame)
1057 (x_menubar_window_to_frame, x_top_window_to_frame):
1058 Move from here...
1059 * xterm.c (x_window_to_frame, x_any_window_to_frame)
1060 (x_menubar_window_to_frame, x_top_window_to_frame):
1061 ...to here and convert all but the last to static.
1062
347ae3e1
EZ
10632013-09-12 Eli Zaretskii <eliz@gnu.org>
1064
1065 * lisp.mk (lisp): Add w32-common-fns.elc.
1066
15c6d837
XF
10672013-09-12 Xue Fuqiao <xfq.free@gmail.com>
1068
1069 * charset.c (char_charset): Document an exception for char-charset.
1070
27e90f77
DA
10712013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1072
1073 * xterm.h (x_display_info): New field last_user_time...
1074 * xterm.c (toplevel): ...to replace static last_user_time.
1075 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
1076
8ffbc36b
DA
10772013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1078
1079 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
1080 scroll bar values to prevent thumb from disappear and update comment.
1081
5ec0337a
GM
10822013-09-11 Glenn Morris <rgm@gnu.org>
1083
1084 * emacs.c (usage_message): Possessive apostrophe tweak.
1085
fb55b9d1
DA
10862013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1087
8d2db8be
DA
1088 * nsterm.m (syms_of_nsterm): Use Qns.
1089 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
1090 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
1091 * xfns.c (x_display_info_for_name, Fx_open_connection):
1092 Remove old '#if 0' code.
1093 (syms_of_xfns): Use Qx.
fb55b9d1
DA
1094 * termhooks.h (fullscreen_hook): Remove the leftover.
1095 (struct terminal): Fix typo in comment.
1096
927eec55
DA
10972013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Cleaning up a few X scroll bar bits.
1100 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
1101 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1102 New member last_seen_part, going to replace...
1103 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
1104 (xt_action_hook) [USE_LUCID]: Adjust user.
1105 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
1106 Lucid-specific scroll bar support.
1107 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
1108 to int and adjust to use last_seen_part member.
1109 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
1110 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1111 Initialize last_seen_part.
1112
71b28baa
SM
11132013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1114
1115 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
1116 insert-buffer-substring an empty string.
1117
f5dacaae
PE
11182013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
1121 avoiding a GCC warning.
1122
742516e0
DA
11232013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1124
1125 Ifdef away frame tool bar code when it is not really used.
1126 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
1127 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
1128 and minimize_tool_bar_window_p under the above.
1129 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1130 (fset_tool_bar_window): Likewise.
1131 * dispnew.c (clear_current_matrices, clear_desired_matrices)
1132 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
1133 (change_frame_size_1):
1134 * window.c (window_from_coordinates, Frecenter): Adjust users.
1135 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
1136 code is not really used.
1137 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
1138 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
1139 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
1140 [!USE_GTK && !HAVE_NS]: Define as such.
1141 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
1142 (note_mouse_highlight, expose_frame):
1143 * xfns.c (x_set_tool_bar_lines):
1144 * xterm.c (handle_one_xevent): Adjust users.
1145
73f82c7e
PE
11462013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 Fix corruption with multiple emacsclient -t instances (Bug#15222).
1149 This bug was introduced by my 2013-08-26 patch, which incorrectly
1150 assumed that the terminfo implementation doesn't use termcap buffers.
1151 * term.c (init_tty) [TERMINFO]: Remove optimization, as
1152 these buffers apparently are used after all.
1153 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
1154 (struct tty_display_info): Define members termcap_term_buffer and
1155 termcap_strings_buffer even if TERMINFO.
1156
53482f41
DA
11572013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1158
1159 Fix last change.
1160 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
1161 'usage' docstring entry to pacify make-docfile.
1162
11632013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
1164
1165 Change comparison functions =, <, >, <=, >= to take many arguments.
1166 * data.c: Change comparison functions' interface and implementation.
1167 * lisp.h: Make arithcompare available for efficient two arg
1168 comparisons.
1169 * bytecode.c: Use arithcompare.
1170 * fileio.c: Use new interface.
1171
533f258f
SM
11722013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1173
1174 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
1175
8c27f5ff
SM
11762013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
1177
1178 * eval.c (Feval): Document the new use of `lexical'.
1179
0750a308
DA
11802013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1181
1182 Review and drop old frame resize hack.
1183 * frame.h (struct frame): Remove force_flush_display_p.
1184 * dispnew.c (update_frame): Adjust user and don't call
1185 flush_frame here. The comment has said that there was an issues
1186 with redisplaying fringes, but I don't see any differences with
1187 and without this hack. Hopefully we can continue without it.
1188 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
1189 current frame matrices twice if resized_p is set.
1190
83fc0554
DA
11912013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1192
1193 Do not populate pure Xism x_sync to other ports.
1194 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
1195 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
1196 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
1197 * w32term.h (x_sync): Remove prototype.
1198
fd462129
DA
11992013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1200
1201 Cleanup frame flushing.
8c27f5ff
SM
1202 * dispextern.h (struct redisplay_interface):
1203 Drop flush_display_optional because flush_display is enough
fd462129
DA
1204 for X and flushing via RIF is just a no-op for others.
1205 * frame.h (flush_frame): New function.
1206 * dispnew.c (update_frame):
1207 * minibuf.c (read_minibuf):
1208 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
1209 Use it.
1210 * keyboard.c (detect_input_pending_run_timers): Do not flush
1211 all frames but selected one in redisplay_preserve_echo_area.
1212 * nsterm.m (ns_flush): Remove no-op.
1213 (ns_redisplay_interface): Adjust user.
1214 * w32term.h (x_flush): Remove no-op.
1215 (w32_redisplay_interface): Adjust user.
1216 * xterm.c (x_flush): Simplify because we do not flush all
1217 frames at once any more. Adjust comment.
1218 (x_redisplay_interface): Adjust user.
1219
4b73fc73
PE
12202013-09-07 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 Port --without-x --enable-gcc-warnings to Fedora 19.
1223 * gfilenotify.c (globals_of_gfilenotify):
1224 Call g_type_init only if using an older glib version that needs it.
1225
77394d40
DA
12262013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1227
1228 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1229 (last_glyphless_glyph_merged_face_id): Remove declarations.
1230 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
1231 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1232 (last_glyphless_glyph_merged_face_id): Now static.
1233 (merge_escape_glyph_face): New function, refactored from...
1234 (get_next_display_element): ...here.
1235 (merge_glyphless_glyph_face): New function, refactored from...
1236 (produce_glyphless_glyph): ...here...
1237 * term.c (produce_glyphless_glyph): ...and here.
1238
306d67bd
SM
12392013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
1240
1241 * eval.c (eval_sub): Only call Ffunction if necessary.
1242
7f6c6450
DA
12432013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1244
1245 Attempt to make redisplay more selective when changing cursor type.
1246 * frame.h (struct frame): New bitfield cursor_type_changed.
1247 * xdisp.c (cursor_type_changed): Remove.
1248 (try_cursor_movement, redisplay_window, try_window_id)
1249 (set_frame_cursor_types, try_window_reusing_current_matrix):
1250 Adjust to use per-frame bitfield.
1251 (redisplay_internal): Look for cursor type change on each visible
1252 frame and consider all frames if cursor type has been changed on
1253 the frame other than selected. If cursor type has been changed on
1254 selected frame only, do not use fast update.
1255
bd0443bb
DA
12562013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1257
1258 Attempt to make redisplay more selective when changing fonts.
1259 * frame.h (struct frame): New bitfield fonts_changed.
1260 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
1261 (adjust_frame_glyphs): Add prototype.
1262 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 1263 (adjust_glyphs): Remove because we do not
bd0443bb
DA
1264 adjust matrices on all frames at once any more.
1265 (adjust_frame_glyphs): Block and unblock input here.
1266 (adjust_glyph_matrix): Use fonts_changed.
1267 (change_frame_size_1): Use adjust_frame_glyphs.
1268 * font.c (font_open_entity): Use fonts_changed.
1269 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
1270 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1271 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
1272 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
1273 (shrink_mini_window, Fresize_mini_window_internal)
1274 (window_scroll_pixel_based, Fset_window_configuration)
1275 (apply_window_adjustment, Fset_window_vscroll):
1276 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1277 Use adjust_frame_glyphs.
1278 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
1279 (try_window_reusing_current_matrix, try_window_id, display_line)
1280 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
1281 (redisplay_internal): Consider fonts_changed and adjust frame
1282 matrices for each frame only if the frame is visible. If font
1283 has been changed on some frame during full redisplay, retry
1284 only visible frames where the font has been actually changed.
1285
b9695828
DA
12862013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1287
1288 Cache current header and mode line height for each window.
1289 * window.h (struct window): New fields mode_line_height
1290 and header_line_height.
1291 * window.c (make_window): Initialize them.
1292 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
1293 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
1294 (current_mode_line_height, current_header_line_height):
1295 Remove declaration.
1296 * xdisp.c (current_mode_line_height, current_header_line_height):
1297 Remove.
1298 (pos_visible_p, init_xdisp): Adjust user.
1299 (redisplay_window): Invalidate mode_line_height and
1300 header_line_height if current and desired matrices do not agree.
1301
66738305
DA
13022013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1303
1304 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
1305 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
1306
257b3b03
DA
13072013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1308
1309 Make --without-x compatible with --enable-gcc-warnings.
1310 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
1311 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
1312 members under HAVE_WINDOW_SYSTEM.
1313 * keyboard.c (make_lispy_focus_out): Likewise.
1314 (record_menu_key): Move under HAVE_MENUS.
1315 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
1316 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
1317 (syms_of_xdisp): Adjust user.
1318 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
1319 (start_hourglass, cancel_hourglass):
1320 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
1321 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
1322 and CLEAR_FONT_TABLE_NFONTS.
1323 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
1324 Declare only if HAVE_WINDOW_SYSTEM.
1325 (lface_same_font_attributes_p, clear_face_gcs): Define only
1326 if HAVE_WINDOW_SYSTEM.
1327
98b7f4bd
DA
13282013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1329
1330 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
1331 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
1332 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
1333
a7e43722
SM
13342013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
1335
1336 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
1337
0c90b9ee
PE
13382013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
1341 This fixes a type error on hosts where ptrdiff_t is wider than int.
1342
d99760fa
SM
13432013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1344
6629638e
SM
1345 * keyboard.c (read_key_sequence_vs): New function.
1346 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
1347 common code.
1348
d99760fa
SM
1349 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1350
224e313d
PE
13512013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1352
1353 Makefile improvements.
1354 * Makefile.in (config.status): Don't use double-colon rules, as
1355 they are not portable according to POSIX. Fix shell typo with `;
1356 I guess this rule has never been tested?
1357 (VCSWITNESS): New macro, to override any environment var.
1358
6d6ed1af
DA
13592013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1360
1361 * xterm.h (struct x_display_info): Do not track X connection
1362 fd separately because it is always available from Display.
1363 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1364 Adjust users.
1365
bc923770
DA
13662013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1367
1368 * buffer.c (drop_overlay):
1369 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1370 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1371
b1cf96de
DA
13722013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 * buffer.c (Fmake_overlay, Fmove_overlay):
1375 * intervals.c (set_point_from_marker):
1376 * print.c (PRINTPREPARE): Prefer signal_error
1377 to plain error and report unsuitable marker too.
1378
d1fc6c21
DA
13792013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1380
1381 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1382 for 'dragging' member.
d1ae6a0b
DA
1383 (struct x_output): Remove set-but-unused leftovers
1384 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1385 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1386 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1387 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1388 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1389 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1390 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1391 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1392 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1393
0ce9f6de
JD
13942013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1395
1396 * nsfont.m (INVALID_GLYPH): New define.
1397 (nsfont_encode_char): Use INVALID_GLYPH.
1398 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1399
b594a96c
DA
14002013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1401
1402 * xterm.c (x_last_mouse_movement_time): Revert last change.
1403 This code should use XDisplayMotionBufferSize to check display's
1404 motion history first, and there are few other issues as well.
1405 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1406 (handle_one_xevent): Adjust user.
1407
8b098236
MR
14082013-09-02 Martin Rudalics <rudalics@gmx.at>
1409
9718b207
MR
1410 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1411 * frame.c (Flast_nonminibuf_frame): ... to here.
1412 (check_minibuf_window): Don't abort if no window was found
1413 (Bug#15247).
8b098236 1414
84e70bba
DA
14152013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1416
1417 Use XGetMotionEvents to ask the last mouse motion time from X server.
1418 * xterm.c (X_MOTION_HISTORY): Default to 1.
1419 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1420 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1421 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1422 Ifdef away legacy code.
1423 (XTmouse_position, x_scroll_bar_report_motion):
1424 Use x_last_mouse_movement_time.
fc85e20b
DA
1425 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1426 UnmapNotify event.
84e70bba 1427
1fccc530
DA
14282013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1429
1430 * msdos.c (last_mouse_window): Move to...
1431 (dos_rawgetc): ...this function and adjust comment.
1432 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1433 (mouseMoved): ...this function and adjust comment.
1434 * w32term.c (last_window): Likewise with...
1435 (w32_read_socket): ...this function.
1436 * xterm.c (last_window): Likewise with...
1437 (handle_one_xevent): ...this function.
1438
0ab10992
DA
14392013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1440
b7da754d 1441 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1442 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1443 (handle_one_xevent): ...to here.
1444 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1445 otherwise.
1446
0c7f856e
DA
14472013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1448
1449 * msdos.c (IT_set_terminal_window): Remove no-op.
1450 (initialize_msdos_display): Adjust terminal setup.
1451 * w32console.c (w32con_set_terminal_window): Remove no-op.
1452 (initialize_w32_display): Adjust terminal setup.
1453 * w32term.c (w32_set_terminal_window): Remove no-op.
1454 (w32_create_terminal): Adjust terminal setup.
1455 * xterm.c (XTset_terminal_window): Remove no-op.
1456 (x_create_terminal): Adjust terminal setup.
1457
a892a94c
DA
14582013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1459
1460 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1461 Remove no-ops.
1462 (ns_create_terminal): Adjust terminal setup.
1463 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1464 Remove no-ops.
1465 (w32_create_terminal): Adjust terminal setup.
1466 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1467 Remove no-ops.
1468 (x_create_terminal): Adjust terminal setup.
1469
cf91889a
DA
14702013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1471
1472 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1473 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1474 * dispnew.c (buffer_posn_from_coords):
1475 * window.c (Fwindow_end, displayed_window_lines):
1476 * xdisp.c (redisplay_mode_lines): Use it.
1477
5b0891df
JD
14782013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1479
1480 * fontset.c (face_for_char): Check char in the current face font first
1481 if HAVE_NS (Bug#15138).
1482
0a357e98
MR
14832013-08-31 Martin Rudalics <rudalics@gmx.at>
1484
1485 * window.c (temp_output_buffer_show): Make sure window returned
1486 by display_buffer is live (Bug#15213).
1487
9d7693d7
DA
14882013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1489
1490 Minor cleanup to avoid forward declarations.
1491 * coding.h (struct ccl_spec): Remove forward declaration.
1492 * composite.h (toplevel): Include font.h.
1493 (struct composition_it, struct face, struct font_metrics):
1494 Remove forward declaration.
1495 * dispextern.h (struct image, struct atimer): Likewise.
1496 * emacsgtkfixed.h (struct frame): Likewise.
1497 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1498 * font.h (struct font_driver, struct font, struct glyph_string)
1499 (struct face): Remove forward declaration.
1500 * fontset.h (struct face, struct font): Likewise.
1501 * frame.h (toplevel): Style cleanup.
1502 (enum output_method): Move to...
1503 * termhooks.h (enum output_method): ...here.
1504 (struct glyph, struct frame, struct ns_display_info)
1505 (struct x_display_info, struct w32_display_info):
1506 Remove forward declaration.
1507 * xterm.h (toplevel): Include termhooks.h.
1508 (struct font, struct window, struct glyph_matrix, struct frame)
1509 (struct input_event, struct face, struct image): Remove forward
1510 declaration.
1511 * gtkutil.h (struct _widget_value): Likewise.
1512 * keyboard.h (toplevel): Include termhooks.h.
1513 (struct input_event): Remove forward declaration.
1514
032f7451
DA
15152013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1516
1517 * intervals.c (set_point_from_marker): New function.
1518 * editfns.c (Fgoto_char):
1519 * process.c (Finternal_default_process_filter):
1520 * window.c (select_window_1): Use it.
1521 * buffer.h (set_point_from_marker): Add prototype.
1522
3f940c5a
EZ
15232013-08-29 Eli Zaretskii <eliz@gnu.org>
1524
1525 * w32.c (term_winsock): Call release_listen_threads before calling
1526 WSACleanup.
1527 (_sys_wait_accept): Wait for accept event in a loop with a finite
1528 timeout, instead of waiting indefinitely. Will hopefully avoid
1529 hanging during exit because WSACleanup deadlocks waiting for the
1530 event object to be released. (Bug#14333)
1531
1532 * w32proc.c (release_listen_threads): New function, signals all
1533 the reader threads that listen for connections to stop waiting.
1534
1535 * w32.h (release_listen_threads): Add prototype.
1536
101ed2bb
DA
15372013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1538
1539 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1540 field of new marker (for sanity and safety).
20de2834
DA
1541 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1542 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1543
1f5cf200
DA
15442013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1545
1546 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1547 (x_after_update_window_line, x_scroll_bar_create):
1548 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1549 (handle_one_xevent, x_clear_frame_area):
1550 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1551 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1552 * xterm.h (x_clear_area): Adjust prototype.
1553
d2b36813
DA
15542013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1555
1556 Hook scanning and indentation functions to find_newline. This helps
1557 to avoid duplicated code and renders more respect to newline cache.
1558 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1559 * cmds.c (Fforward_line):
1560 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1561 Use find_newline and avoid unnecessary point movements.
1562 * search.c (scan_newline): Implement on top of find_newline.
1563
3ec7babc
SM
15642013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1565
1566 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1567 scoped code (bug#11258).
1568
5ab473cd
JD
15692013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1570
1571 * nsterm.m (last_window): New variable.
1572 (EV_TRAILER2): New macro.
1573 (EV_TRAILER): Call EV_TRAILER2.
1574 (mouseMoved:): Add support for mouse-autoselect-window
1575 on nextstep (Bug#6888).
1576
78779650
AS
15772013-08-28 Andreas Schwab <schwab@suse.de>
1578
1579 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1580 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1581 Remove unused macro definitions.
1582 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1583 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1584 Only define if emacs.
78779650 1585
c3c4768d
DA
15862013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1587
1588 Prefer enum glyph_row_area to int where appropriate.
1589 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1590 Fix comment.
1591 (window_box, window_box_width, window_box_left, window_box_left_offset)
1592 (window_box_right, window_box_right_offset): Adjust prototypes.
1593 * xdisp.c (window_box, window_box_width, window_box_left)
1594 (window_box_left_offset, window_box_right, window_box_right_offset):
1595 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1596 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1597 * nsterm.m (ns_clip_to_row):
1598 * w32term.c (w32_clip_to_row):
1599 * xterm.c (x_clip_to_row): Likewise.
1600
6bdcbfe1
DA
16012013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1602
1603 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1604 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1605
50b13cde
PE
16062013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1609 for portability to hosts where /bin/sh has problems.
1610
f60e429a
DA
16112013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1612
1613 Redesign redisplay interface to drop global output_cursor.
1614 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1615 (toplevel): Remove declaration of output_cursor.
1616 (set_output_cursor, x_cursor_to): Remove prototype.
1617 * window.h (struct window): New member output_cursor.
1618 (output_cursor_to): New function to replace RIF member.
1619 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1620 (update_text_area, set_window_cursor_after_update): Use it.
1621 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1622 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1623 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1624 * w32term.c (x_update_window_begin, x_update_window_end):
1625 * xterm.c (x_update_window_begin, x_update_window_end):
1626 Adjust to use per-window output cursor.
1627
43aac990
PE
16282013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1629
d486344e
PE
1630 Simplify SELECT_TYPE-related code.
1631 Like EMACS_TIME, this portability layer is no longer needed, since
1632 Emacs has been using fd_set as a portability layer for some time.
1633 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1634 (SELECT_TYPE): Remove. All uses changed to fd_set.
1635 (fd_set) [!FD_SET]: New typedef.
1636
43aac990
PE
1637 Simplify EMACS_TIME-related code.
1638 This portability layer is no longer needed, since Emacs has been
1639 using struct timespec as a portability layer for some time.
1640 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1641 Include <time.h> rather than "systime.h"; that's all that's needed now.
1642 * dispnew.c: Include <timespec.h> rather than "systime.h";
1643 that's all that's needed now.
1644 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1645 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1646 TIMESPEC_RESOLUTION.
1647 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1648 LOG10_TIMESPEC_RESOLUTION.
1649 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1650 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1651 (make_emacs_time): Remove. All used changed to make_timespec.
1652 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1653 (current_timespec): Rename from current_emacs_time. All uses changed.
1654 (add_emacs_time): Remove. All uses changed to timespec_add.
1655 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1656 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1657 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1658 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1659 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1660 (current_timespec): Rename from current_emacs_time. All uses changed.
1661 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1662 changed to timespec_cmp.
1663 * xgselect.c: Include <timespec.h>, since our .h files don't.
1664
d350e350
DA
16652013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1668 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1669 Remove the leftovers.
1670 * gtkutil.c (toplevel): Do not declare Qxft but include
1671 font.h to do so.
1672 * image.c (toplevel): Do not declare Vlibrary_cache because
1673 it's already done in lisp.h.
1674
9fed9729
DA
16752013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1676
1677 * lisp.h (Mouse_HLInfo): Move from here...
1678 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1679 (reset_mouse_highlight): New function.
1680 * msdos.c (dos_set_window_size, IT_update_begin)
1681 (internal_terminal_init):
1682 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1683 (ns_initialize_display_info):
1684 * w32console.c (initialize_w32_display):
1685 * w32term.c (x_update_window_end, x_free_frame_resources)
1686 (w32_initialize_display_info):
1687 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1688 * window.c (Fdelete_other_windows_internal):
1689 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1690 * termchar.h (toplevel):
1691 * xterm.h (toplevel): Include dispextern.h.
1692
f462f075
PE
16932013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 Fix minor problems found by static checking.
1696 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1697 (expect): Avoid nested-if warning.
1698 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1699 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1700 * nsterm.h, nsterm.m (ns_select):
1701 * xgselect.c, xgselect.h (xg_select):
1702 Adjust signature to better match pselect's.
1703 * nsterm.m (ns_select):
1704 Don't set *TIMEOUT, since pselect doesn't.
1705 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1706 diagnostic about assigning const char * to it.
1707 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1708
068f9124
SM
17092013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1710
1711 * lread.c (substitute_object_recurse): Handle hash-tables as well
1712 (bug#15190).
1713
f5adc984
PE
17142013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1715
1fc8eb33
PE
1716 Fix unlikely core dump in init_tty, and simplify terminfo case.
1717 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1718 The old version incorrectly dumped core if malloc returned a
1719 buffer containing only non-NUL bytes.
1720 (init_tty): Do not allocate or free termcap buffers; the
1721 struct does that for us now.
1722 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1723 (struct tty_display_info): Define members termcap_term_buffer and
1724 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1725 use them. Allocate them directly in struct rather than indirectly
1726 via a pointer, to simplify init_tty.
1727
f5adc984
PE
1728 * frame.c (check_minibuf_window): Initialize 'window' properly,
1729 so that Emacs reliably aborts later if 'window' is not initialized.
1730
efec3894
JD
17312013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1732
1733 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1734 of VoidSymbol (Bug#15154).
1735
e1d0341e
DA
17362013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1737
1738 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1739 mouse_face_beg_y and mouse_face_end_y.
1740 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1741 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1742 Adjust users and update comment where appropriate.
1743
bfff6445
MR
17442013-08-26 Martin Rudalics <rudalics@gmx.at>
1745
1746 * frame.c (check_minibuf_window): New function.
068f9124
SM
1747 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1748 Call check_minibuf_window (Bug#15183).
bfff6445 1749
c80016b3
DA
17502013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1751
1752 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1753 because this is the only last cursor data we need to keep and consult.
1754 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1755 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1756 Adjust users.
1757
de396731
DA
17582013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1759
068f9124
SM
1760 Fix recovering from possible decompression error.
1761 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1762 the position where the partially decompressed data ends, and
447218dd 1763 should count how many bytes was produced so far.
de396731
DA
1764 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1765 (unwind_decompress): Really delete partially uncompressed data.
1766 (Fzlib_decompress_region): Take decompressed data size into account.
1767
c76826d9
DA
17682013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1769
1770 * syntax.c (init_syntax_once): Adjust comment and do an early
1771 initialization of Qchar_table_extra_slots just once...
1772 * casetab.c (init_casetab_once):
1773 * category.c (init_category_once):
1774 * character.c (syms_of_character):
1775 * coding.c (syms_of_coding):
1776 * xdisp.c (syms_of_xdisp): ...and omit it here.
1777
b34454d0
EZ
17782013-08-24 Eli Zaretskii <eliz@gnu.org>
1779
11f20add
EZ
1780 * xdisp.c (get_next_display_element): Don't apply to characters
1781 from a display vector the logic of setting it->end_of_box_run_p
1782 suitable for characters from a buffer. (Bug#15175)
1783
b34454d0
EZ
1784 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1785 to handle directories, rather than '_utime' which doesn't.
1786 (Bug#15176)
1787
6e1b469e
JD
17882013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1789
1790 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1791 or fullscreen (Bug#14627).
1792
9c05bccf
PE
17932013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1794
1795 System-dependent integer overflow fixes.
1796 * process.c (Fset_process_window_size): Signal an error if
1797 the window size is outside the range supported by the lower level.
1798 * sysdep.c (set_window_size): Return negative on error,
1799 nonnegative on success, rather than -1, 0, 1 on not in system,
1800 failure, success. This is simpler. Caller changed.
1801 (serial_configure): Remove unnecessary initialization of local.
1802 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1803 size fits in unsigned long; this isn't true on some 32-bit hosts.
1804 Avoid buffer overrun if some future version of /proc/meminfo has a
1805 variable name longer than 20 bytes.
1806 (system_process_attributes) [__FreeBSD__]:
1807 Don't assume hw.availpages fits in 'int'.
1808
c365c355
PE
18092013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 Don't let very long directory names overrun the stack.
1812 Fix some related minor problems involving "//", vfork.
1813 * callproc.c (encode_current_directory): New function.
1814 (call_process): Don't append "/"; not needed.
1815 * fileio.c (file_name_as_directory_slop): New constant.
1816 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1817 this can save the caller having to alloca.
1818 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1819 Use SAFE_ALLOCA, not alloca.
1820 (directory_file_name, Fexpand_file_name): Leave leading "//"
1821 alone, since it can be special even on POSIX platforms.
1822 * callproc.c (call_process):
1823 * process.c (Fformat_network_address):
1824 * sysdep.c (sys_subshell):
1825 Use encode_current_directory rather than rolling our own.
1826 (create_process): No need to encode directory; caller does that now.
1827 * process.h (encode_current_directory): New decl.
1828 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1829 Rework to avoid 'goto xyzzy;'.
1830
6c6014d4
EZ
18312013-08-23 Eli Zaretskii <eliz@gnu.org>
1832
1833 * xdisp.c (handle_face_prop): If the default face was remapped use
1834 the remapped face for strings from prefix properties. (Bug#15155)
1835
9997ec56
DA
18362013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1837
1838 Minor cleanup for redisplay interface and few related functions.
1839 * frame.h (enum text_cursor_kinds): Move from here...
1840 * dispextern.h (enum text_cursor_kinds): ...to here.
1841 (toplevel): Drop unnecessary declarations.
1842 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1843 in update_window_end_hook and draw_window_cursor functions.
1844 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1845 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1846 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1847 * xterm.c (x_update_window_end, x_draw_window_cursor):
1848 * xdisp.c (display_and_set_cursor, update_window_cursor)
1849 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1850 enum text_cursor_kinds where appropriate.
1851
7f780da6
DA
18522013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1853
1854 Redesign redisplay interface to drop updated_row and updated_area.
1855 * dispextern.h (updated_row, updated_area): Remove declaration.
1856 (struct redisplay_interface): Pass glyph row and row area parameters
1857 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1858 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1859 Adjust prototypes.
1860 * dispnew.c (updated_row, updated_area): Remove.
1861 (redraw_overlapped_rows, update_window_line): Adjust user.
1862 (update_marginal_area, update_text_area): Likewise. Pass updated row
1863 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1864 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1865 Adjust users.
1866
26495794
PE
18672013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 * process.c (flush_pending_output): Remove stub.
1870 All uses removed.
1871
4a88129a
PE
18722013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 * callproc.c: Fix race that killed background processes (Bug#15144).
1875 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1876 Record deleted process-id in critical section, not afterwards.
1877 Don't mistakenly kill process created by a call-process invocation
1878 that discards output and does not wait.
1879
0c5307b0
DA
18802013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1881
1882 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1883 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1884 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1885 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1886 to shut up compiler in mark_object.
1887 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1888
0d7c1e66
PE
18892013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1892 We can't portably rely on PTY_OPEN doing that, even if
1893 it calls posix_openpt with O_CLOEXEC.
1894
3f246b65
KH
18952013-08-20 Kenichi Handa <handa@gnu.org>
1896
1897 * character.c (string_char): Improve commentary.
1898
8c2f38aa
PE
18992013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1902 (struct animation_cache): Make signature a flexible array member.
1903 All uses changed. This is a tad slower but may insulate us better
1904 from future changes to ImageMagick.
1905
bb566cea
PE
19062013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * image.c: Shrink memory needed for animation cache.
1909 (SIGNATURE_DIGESTSIZE): New constant.
1910 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1911 (imagemagick_create_cache): Copy the signature. This saves
1912 several KB of memory that ImageMagick wastes per signature.
1913 Don't bother updating the update_time, as the caller does that now.
1914 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1915 it's a fixed size struct member now.
1916 (imagemagick_get_animation_cache): Always destroy the signature,
1917 as it's now imagemagick_create_cache's responsibility to copy it.
1918 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1919 and use memcmp rather than strcmp.
1920 eassert that ImageMagick returns a signature of the specified length.
1921
6da26928
LMI
19222013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1923
1924 * image.c (imagemagick_get_animation_cache): Don't segfault on
1925 each invocation.
453f4022
LMI
1926 (imagemagick_get_animation_cache): Revert to previous definition
1927 so that it actually works. But keep the memory leak fix.
1928 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1929
22490125
PE
19302013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1931
d0139df5
PE
1932 * image.c: Fix animation cache signature memory leak.
1933 Fix some other minor performance problems while we're at it.
1934 (imagemagick_create_cache): Clear just the members that
1935 need clearing. Don't set update_time, as caller does that now.
1936 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1937 Simplify by using pointer-to-pointer instead of a prev pointer.
1938 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1939 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1940 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1941 it's already a copy. Free the signature probe unless it's cached.
1942
22490125
PE
1943 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1944 This was introduced by my 2013-08-12 fix for Bug#15035.
1945
deb31e75
DA
19462013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1947
1948 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1949 (imagemagick_prune_animation_cache): Now static.
1950
319a4d03
LMI
19512013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1952
1953 * image.c (imagemagick_get_animation_cache): Don't segfault when
1954 pruning all entries.
1955
f747d82e
KB
19562013-08-18 Ken Brown <kbrown@cornell.edu>
1957
1958 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1959 static heap if ENABLE_CHECKING is defined.
1960 (max_bss_sbrk_ptr): New variable.
1961 (bss_sbrk): Use it.
1962 (report_sheap_usage): Report maximum static heap usage instead of
1963 ending static heap usage.
1964
d2c28fab
EZ
19652013-08-17 Eli Zaretskii <eliz@gnu.org>
1966
1967 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1968 of zlib_initialized according to the results of calling
1969 init_zlib_functions.
1970
274ff63f
LMI
19712013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1972
1973 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1974 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1975 (imagemagick_load_image): Remove the ping_wand code, which only
1976 apparently saved time on invalid animated images, and slowed down
1977 everything else. Optimise for the common case.
274ff63f 1978
2bede2ed
XF
19792013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1980
70ff8240
XF
1981 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1982
de179a3e
XF
1983 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1984
2bede2ed
XF
1985 * marker.c (set_marker): Remove documentation of undefined behavior.
1986
703dbeba
LMI
19872013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1988
1989 * image.c (imagemagick_compute_animated_image): Animate correctly
1990 when sub-images are smaller than the main image.
1d18b1e6
LMI
1991 (imagemagick_compute_animated_image): Setting the iterator row to
1992 zero is apparently not allowed.
79670014
LMI
1993 (imagemagick_compute_animated_image): Allow images that say they
1994 have sub-images that are bigger than the main image, but just crop
1995 them.
703dbeba 1996
63216c5e
JD
19972013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1998
1999 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
2000
a5b5f73f
LMI
20012013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2002
2003 * image.c (imagemagick_compute_animated_image): Respect the GIF
2004 disposal methods.
2005
0fe73012
KB
20062013-08-15 Ken Brown <kbrown@cornell.edu>
2007
2008 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
2009 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
2010 needed.
2011
691a357f
PE
20122013-08-15 Paul Eggert <eggert@cs.ucla.edu>
2013
2014 Fix minor problems found by static checking.
2015 * frame.c (delete_frame):
2016 * xdisp.c (next_element_from_display_vector):
2017 Avoid uninitialized local.
2018 * image.c (imagemagick_compute_animated_image): Port to C89.
2019 Prefer usual GNU indentation style for loops.
2020 Be more careful about bizarrely large sizes, by using ptrdiff_t
2021 instead of int.
2022
42fe2e88
DA
20232013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2024
2025 Fix infinite frame selection loop (Bug#15025).
2026 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
2027
d39a3da6
EZ
20282013-08-15 Eli Zaretskii <eliz@gnu.org>
2029
068f9124
SM
2030 * xdisp.c (compute_window_start_on_continuation_line):
2031 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
2032 to make sure we end up setting the window start at the leftmost
2033 visible character of the display line. This avoids funky
2034 horizontal shifting because the window start is not kept on the
2035 same position. (Bug#15090)
05426239
EZ
2036 (next_element_from_display_vector): Support 'box' face attribute
2037 in the face definitions of a display vector. (Bug#15099)
d39a3da6 2038
6e856b69
LMI
20392013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2040
2041 * image.c (imagemagick_compute_animated_image): Implement animated
2042 images (bug#14700).
995be755
LMI
2043 (imagemagick_compute_animated_image): Fix some compilation
2044 warnings. Implement a very simple cache to make the animation
2045 usable at all, but it should be replaced with a per-image cache.
6e856b69 2046
d5a1acfa
DA
20472013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2048
2049 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
2050 to do `for' loops over alist values.
2051 * buffer.h (FOR_EACH_BUFFER):
2052 * process.c (FOR_EACH_PROCESS): Use it.
2053 (handle_child_signal, status_notify, Fget_buffer_process)
2054 (kill_buffer_processes): Use FOR_EACH_PROCESS.
2055
9c253307
DA
20562013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2057
2058 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
2059 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
2060 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
2061 to xzalloc and so avoid redundant call to memset.
2062 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
2063 members because it is allocated with xzalloc and so already zeroed.
2064
05e64f9f
KB
20652013-08-14 Ken Brown <kbrown@cornell.edu>
2066
2067 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
2068 (Bug#15094).
2069
5b71542d
DA
20702013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2071
2072 Utility function and macro to copy Lisp string to C string.
2073 * lisp.h (xlispstrdupa): New macro.
2074 (xlispstrdup): New prototype.
2075 * alloc.c (xlispstrdup): New function.
2076 * callint.c (Fcall_interactively):
2077 * fileio.c (Ffile_name_directory, Fexpand_file_name)
2078 (Fsubstitute_in_file_name):
2079 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
2080 * image.c (x_create_bitmap_from_file):
2081 * w32term.c (w32_term_init):
2082 * xterm.c (x_term_init): Use xlispstrdup.
2083
71530c97
LMI
20842013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2085
4ce82fb8
LMI
2086 * image.c (imagemagick_load_image): Make animated pictures work.
2087 There's still some problems with background color settings, though
2088 (bug#14700).
2089
71530c97
LMI
2090 * decompress.c (unwind_decompress): Always restore point.
2091
7510a061
XF
20922013-08-14 Xue Fuqiao <xfq.free@gmail.com>
2093
2094 * marker.c (set_marker): Reformat documentation.
2095
01c3051f
PE
20962013-08-14 Paul Eggert <eggert@cs.ucla.edu>
2097
aab1fcdf
PE
2098 * xdisp.c (cursor_type_changed): Now static.
2099
01c3051f
PE
2100 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
2101 Use changed. This avoids the need to call xmalloc and for the
2102 caller to call xfree, and avoids memory leaks in some situations.
2103
2084152a
DA
21042013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2105
2106 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
2107 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
2108 (redisplay_window): If window_end_valid is cleared due to non-zero
2109 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
2110 so do not call to try_cursor_movement for that window.
2084152a 2111
02455cb6
DA
21122013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2113
2114 * window.h (struct window): Convert window_end_pos and
2115 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
2116 (wset_window_end_pos, wset_window_end_vpos): Remove.
2117 * dispnew.c (adjust_glyph_matrix):
2118 * window.c (Fwindow_end, replace_window, set_window_buffer)
2119 (make_window):
2120 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
2121 (set_vertical_scroll_bar, redisplay_window, try_window)
2122 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
2123 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
2124 (note_mouse_highlight): Adjust users.
2125 (try_cursor_movement): Likewise. Convert old precondition to eassert.
2126 Add comment.
2127
da5707e8
DA
21282013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2129
2130 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
2131 * image.c (imagemagick_filename_hint): Use `const char *' and
2132 prefer SSDATA to SDATA to avoid warnings.
2133
25554267
DA
21342013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2135
2136 Cleanup window fringes, margins and scroll bars adjustments.
2137 * window.c (set_window_fringes, set_window_margins)
2138 (set_window_scroll_bars, apply_window_adjustment): New functions.
2139 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
2140 (Fset_window_scroll_bars): Use them.
2141
38a2c910
DA
21422013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2143
2144 * window.h (struct window): Convert scroll_bar_width
2145 from Lisp_Object to integer. Adjust comment.
2146 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
2147 Adjust users.
2148 * window.c (wset_scroll_bar_width): Remove.
2149 (make_window): Initialize scroll_bar_width.
2150 (Fsplit_window_internal): Use direct assignment.
2151 (Fset_window_configuration, save_window_save):
2152 Convert Lisp_Object to integer and back where appropriate.
2153 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
2154 bar was actually changed, and mention this in docstring.
2155
2d065031
PE
21562013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * decompress.c: Minor simplifications.
2159 (Fzlib_decompress_region): Don't bother verifying
2160 that avail_out <= UINT_MAX, as that was confusing.
2161 Mention the restriction in a comment instead.
2162 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
2163
a5bd5abb
JD
21642013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2165
2166 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
2167 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
2168
66e7901a
LMI
21692013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2170
2171 * image.c (imagemagick_filename_hint): Check for errors in the
2172 alist structure.
2173
2fa611b7
EZ
21742013-08-13 Eli Zaretskii <eliz@gnu.org>
2175
2176 * window.c (Fwindow_margins): Return nil when there's no marginal
2177 area, as per the documented API.
2178
2179 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
2180 Fmake_vector, as scroll bar's struct members are not all Lisp
2181 objects now. This avoids crashes in GC.
2182
2183 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
2184 bool, so its address could be taken.
2185
8259030d
LMI
21862013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2187
2188 * image.c (imagemagick_filename_hint): New function to possibly
2189 apply `image-content-type-suffixes'.
2190 (imagemagick_load_image): Use it.
2191
866c710e
EZ
21922013-08-13 Eli Zaretskii <eliz@gnu.org>
2193
2194 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
2195 if loading zlib failed.
2196
f10490f0
JD
21972013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2198
96311be7
JD
2199 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
2200 2013-08-13 checkin below. Change bool to BOOL, rule is:
2201 All Obj-C code uses BOOL, except for interfaces callable from C.
2202
f10490f0
JD
2203 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
2204
c8ae93b0
DA
22052013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2206
2207 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
2208 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
2209 bool instead of BOOL.
2210 * w32term.h (struct scroll_bar): Convert fringe_extended_p
2211 from Lisp_Object to bitfield. Adjust comment.
2212 * w32term.c (x_scroll_bar_create): Adjust user.
2213 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
2214 * xterm.c (XTset_vertical_scroll_bar): Likewise.
2215 Use bool for boolean.
2216 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
2217 to `unsigned int' when defining a bitfield.
2218
53b64418
PE
22192013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
2222
eeaf9bf3
DA
22232013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2224
2225 * window.h (struct window): Convert left_margin_cols and
2226 right_margin_cols from Lisp_Objects to integers. Adjust comment.
2227 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
2228 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
2229 Adjust users.
2230 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
2231 Adjust comment.
2232 (showing_window_margins_p, update_window_line, update_frame_1):
2233 * fringe.c (draw_fringe_bitmap_1):
2234 * xdisp.c (window_box_width): Adjust users.
2235 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
2236 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
2237 Use direct assignment.
2238 (Fset_window_configuration, save_window_save, Fwindow_margins):
2239 Convert Lisp_Object to integer and back where appropriate.
2240 (Fset_window_margins): Adjust user. Return t if any margin
2241 was actually changed, and mention this in docstring.
2242
956720af
XF
22432013-08-13 Xue Fuqiao <xfq.free@gmail.com>
2244
f73f4ce6 2245 * syntax.c (forward_word):
956720af
XF
2246 * cmds.c (forward_char, backward_char): Mention the optional argument.
2247
9e37ee3b
DA
22482013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2249
2250 * window.h (struct window): Convert left_fringe_width
2251 and right_fringe_width from Lisp_Objects to integers.
2252 Adjust comment.
2253 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
2254 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
2255 * window.c (wset_left_fringe_width, wset_right_fringe_width):
2256 Remove.
2257 (make_window): Initialize new integer fields to -1.
2258 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
2259 (Fset_window_configuration, save_window_save):
2260 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
2261 (Fset_window_fringes): Adjust user. Return t if any fringe
2262 was actually changed, and mention this in docstring.
2263
e4375ca7
DA
22642013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2265
2266 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
2267 * nsfns.m (x_set_cursor_type):
2268 * w32fns.c (x_set_cursor_type):
2269 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
2270 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 2271
a45543bc
DA
22722013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2273
2274 * font.c (clear_font_cache): New function, stripped from...
2275 (Fclear_font_cache): ...here, which now uses the function
2276 above. Adjust comment.
2277 * font.h (clear_font_cache): Add prototype.
2278 * xfaces.c (clear_face_cache): Use clear_font_cache.
2279
ae966a86
DA
22802013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2281
2282 * window.c (Fset_window_start): Compare `w', not `window' because
2283 `w' might not be equal to `window' after call to decode_live_window.
2284
297a545b
PE
22852013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
2288 This fixes a problem introduced by the Bug#15035 patch
2289 when using GPG. Reported by Herbert J. Skuhra.
2290
aa942e2b
EZ
22912013-08-12 Eli Zaretskii <eliz@gnu.org>
2292
2293 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
2294 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
2295 not yet initialized.
2296
7699d09e
LMI
22972013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2298
2299 * decompress.c (Fzlib_decompress_region): Support zlib
2300 decompression, too, and rename.
2301
1d238bc7
PE
23022013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 Minor zlib configuration tweaks.
2305 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
2306 Don't assume presence of fn_inflateInit2_ zlib internal function.
2307
8a44a184
LMI
23082013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2309
2310 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
2311 include the zlib prefix.
2312
594a4307
EZ
23132013-08-12 Eli Zaretskii <eliz@gnu.org>
2314
2315 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
2316 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
2317 define static variables that are pointers to zlib functions to be
2318 dynamically loaded.
2319 (init_zlib_functions) [WINDOWSNT]: New function.
2320 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
2321 New macros.
2322 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
2323 macros instead of invoking the zlib functions directly.
068f9124
SM
2324 (syms_of_decompress): DEFSYM Qzlib_dll.
2325 Staticpro Szlib_available_p.
594a4307 2326
d2e113bc
DA
23272013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
2328
2329 Avoid looping over all frame windows to freeze and unfreeze.
2330 * window.h (struct window): Drop frozen_window_start_p.
2331 (freeze_window_starts): Drop prototype.
2332 * frame.h (struct frame): New frozen_window_starts flag.
2333 (FRAME_WINDOWS_FROZEN): New macro.
2334 * window.c (freeze_window_start, freeze_window_starts):
2335 Remove.
2336 (select_window, replace_window): Adjust users.
2337 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2338 (window_frozen_p): New function.
2339 (redisplay_window): Use it.
2340
94fcd171
PE
23412013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 Fix some fd issues when running subprocesses (Bug#15035).
2344 Fix bugs that can leak files or file descriptors on errors.
2345 Don't unlink open temp files, as that's hard for users to diagnose
2346 when things go awry (e.g., temp disk exhausted).
2347 Don't bother to lock temp files. Check for invalid recursion.
2348 * callproc.c (synch_process_fd): Remove. All uses removed.
2349 (synch_process_tempfile): New var or macro.
2350 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2351 New constants.
2352 (record_kill_process): New arg, the temp name. All callers changed.
2353 (delete_temp_file): Now just a simple wrapper around unlink.
2354 (call_process_kill): New arg, the call_process_fd array.
2355 Close them all. Clear synch_process_pid. Remove the temp file,
2356 or arrange for it to be removed.
2357 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2358 that's been moved to synch_process_tempfile. Caller changed.
2359 Do not remove the tempfile; that's now call_process_kill's
2360 responsibility.
2361 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2362 call_process_kill; the caller now does that.
2363 (call_process_cleanup): Do not close the process fd; that's now
2364 call_process_kill's responsibility.
2365 (Fcall_process): Implement via new function call_process, which
2366 has most of the old body of Fcall_process, but with a different API.
2367 (call_process): New function that does not open or close filefd if
2368 it is nonnegative. Record which fds need to be closed, and let
2369 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2370 Signal an error if invoked recursively (could be done via a hook).
2371 Simplify creation of the tempfile in the MSDOS case.
2372 Don't create the output file until after checking for the executable.
2373 Report any failure to open /dev/null.
2374 Don't open /dev/null for writing twice; once is enough.
2375 Don't create pipe if all output is being discarded or sent to file.
2376 Don't worry about setting up the coding system or reading from the
2377 pipe if all output is being discarded.
2378 Hoist fd_error local into top level, to lessen block nesting.
2379 Don't record deleted pid here; now done by Fcall_process_region.
2380 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2381 and note its success in synch_process_tempfile.
2382 Do not leak resources when child_setup fails.
2383 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2384 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2385 (create_temp_file): Now returns open fd, with an additional
2386 Lisp_Object * argument to return the name. All callers changed.
2387 Do not close the file; rewind it instead, and leave it open for
2388 the caller. Do not lock the temp file. Unwind-protect the file
2389 and the file-descriptor.
2390 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2391 If an asynchrounous process, record it here, not in call_process.
2392 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2393 * eval.c (set_unwind_protect): New function.
2394 * fileio.c (write_region): New function, generalized from the
2395 old Fwrite_region. Do not lock temp files.
2396 (Fwrite_region): Use it.
2397 * lisp.h (set_unwind_protect, write_region): New decls.
2398 * process.c: Include <verify.h>.
2399 (make_process): Mark fds as initially closed.
2400 (deleted_pid_list): Now a list of pid-filename pairs.
2401 All uses changed.
2402 (close_process_fd): New function.
2403 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2404 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2405 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2406 (create_process, create_pty, Fmake_serial_process)
2407 (server_accept_connection): Record which fds need to be closed,
2408 and let deactivate_process close them.
2409 (Fmake_network_process): Do not discard the unwind-protect
2410 until it's safe to do so.
2411 (deactivate_process): Close the fds opened by create_process etc.
2412 (Fprocess_send_eof): Adjust to new way of recording open fds.
2413 Report an error if /dev/null can't be opened, instead of aborting.
2414 * process.h (PROCESS_OPEN_FDS): New constant.
2415 (struct Lisp_Process): New member open_fds.
2416 (record_kill_process, record_deleted_pid): Adjust signatures.
2417 (record_deleted_pid): Move decl here ...
2418 * syswait.h (record_deleted_pid): ... from here.
2419
d0e615c3
PE
24202013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 * decompress.c: Fix bugs with large buffers and weird inputs.
2423 Tune a bit. Reindent as per usual Emacs style.
2424 (BUFFER_SIZE): Remove.
2425 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2426 more than UINT_MAX bytes. Decompress into the gap instead of into
2427 an auto buffer, as this should avoid copying. Return nil if
2428 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2429 set immediate_quit; we shouldn't trust zlib code that much.
2430
313546eb
LMI
24312013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2432
99a32242
LMI
2433 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2434 errors, and really move the gap to where we want it.
2435
313546eb
LMI
2436 * lisp.h: Include decompress.c support.
2437
2438 * emacs.c (main): Include decompress.c support.
2439
2440 * Makefile.in: Include -lz if present.
2441
d2d699ac
JD
24422013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2443
f90e3ebd
JD
2444 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2445 (initWithTitle:): Initialize frame to 0.
2446 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2447 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2448 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2449
2450 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2451 fillWithWidgetValue:frame:
2452
423d3b3f
JD
2453 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2454 remove memory leak warnings.
2455
d2d699ac
JD
2456 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2457 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2458 menu_pending_title.
2459
2460 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2461 (x_activate_menubar): Update the whole menu.
2462 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2463 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2464 current event is not NSSystemDefined (Bug#15001).
2465 Call ns_check_menu_open only if trackingMenu is 2.
2466 (menuDidClose:): New method, decrease trackingMenu.
2467 (fillWithWidgetValue:setDelegate:): New method.
2468 (fillWithWidgetValue:): Call the above.
2469
2470 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2471
7d652d97
PE
24722013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 Omit some unnecessary casts.
2475 Many of these go back to the old pre-C89 days, when they may have
2476 been needed, but we've been assuming C89 or later for a while now.
2477 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2478 (live_float_p, live_misc_p, live_vector_p):
2479 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2480 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2481 (defvar_per_buffer):
2482 * callint.c (Fcall_interactively):
2483 * doc.c (Fsubstitute_command_keys):
2484 * filelock.c (get_boot_time):
2485 * frame.c (xrdb_get_resource):
2486 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2487 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2488 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2489 (menuitem_highlight_callback, menu_destroy_callback)
2490 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2491 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2492 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2493 (xg_tool_bar_help_callback, tb_size_cb):
2494 * image.c (xpm_alloc_color, png_read_from_memory)
2495 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2496 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2497 (syms_of_image):
2498 * keymap.c (describe_map):
2499 * nsfns.m (Fns_display_monitor_attributes_list):
2500 * nsmenu.m (process_dialog:):
2501 * nsterm.m (hold_event):
2502 * process.c (wait_reading_process_output):
2503 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2504 * scroll.c (do_direct_scrolling, scrolling_1):
2505 * termcap.c (tgetent):
2506 * window.c (check_window_containing, add_window_to_list)
2507 (freeze_window_starts):
2508 * xdisp.c (compare_overlay_entries, vmessage):
2509 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2510 (x_get_monitor_attributes_xrandr)
2511 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2512 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2513 * xfont.c (xfont_match, xfont_open):
2514 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2515 (menubar_selection_callback, menu_position_func)
2516 (popup_selection_callback, create_and_show_popup_menu)
2517 (dialog_selection_callback, create_and_show_dialog):
2518 * xrdb.c (x_get_string_resource):
2519 (main) [TESTRM]:
2520 * xsmfns.c (x_session_check_input):
2521 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2522 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2523 (xaw_jump_callback, xaw_scroll_callback):
2524 Omit unnecessary casts.
2525
9acc1074
PE
25262013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2527
2528 Minor string-length refactoring.
2529 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2530 * frame.c (make_monitor_attribute_list):
2531 Prefer build_string to strlen + make_string.
2532
361c0eb8
JD
25332013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2534
2535 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2536 don't check minor_code (Bug#14417).
2537
14ba0822
EZ
25382013-08-09 Eli Zaretskii <eliz@gnu.org>
2539
2540 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2541 vertical positions instead. This avoids calling MATRIX_ROW with
2542 row numbers that are possibly beyond valid limits. (Bug#15064)
2543
309f24d1
DA
25442013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2545
2546 Use xstrdup and build_unibyte_string where applicable.
2547 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2548 * xfns.c (x_window):
2549 * xrdb.c (x_get_customization_string):
2550 * xterm.c (xim_initialize):
2551 * w32fns.c (w32_window): Use xstrdup.
2552 (w32_display_monitor_attributes_list):
2553 * emacs.c (init_cmdargs):
2554 * keyboard.c (PUSH_C_STR):
2555 * nsfont.m (nsfont_open):
2556 * sysdep.c (system_process_attributes):
2557 * w32.c (system_process_attributes):
2558 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2559
55902276
EZ
25602013-08-09 Eli Zaretskii <eliz@gnu.org>
2561
2562 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2563 variables of these types so that GDB would know about them, as aid
2564 for debugging fatal exceptions. (Bug#15024) See also
2565 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2566 discussions.
2567
10bf7f5a
JD
25682013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2569
2570 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2571 larger than the NSWindow (Bug#14934).
2572
65620264
DA
25732013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2574
2575 Redesign redisplay interface to drop global variable updated_window.
2576 Always pass currently updated window as a parameter to update routines.
2577 * dispextern.h (updated_window): Remove declaration.
2578 (struct redisplay_interface): Pass window parameter to
2579 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2580 and after_update_window_hook.
2581 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2582 Adjust prototypes.
2583 * dispnew.c (updated_window): Remove.
2584 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2585 (update_window_line): Adjust to match redisplay interface changes.
2586 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2587 (ns_scroll_run, ns_after_update_window_line):
2588 * w32term.c (x_update_window_begin, x_update_window_end)
2589 (x_after_update_window_line, x_scroll_run):
2590 * xterm.c (x_update_window_begin, x_update_window_end)
2591 (x_after_update_window_line, x_scroll_run):
2592 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2593 Likewise. Adjust comments where appropriate.
2594 (x_cursor_to): Simplify because this is always called during window
2595 update (but install debugging check anyway).
2596 (expose_window): Check must_be_updated_p flag to see whether this
2597 function is called during window update.
2598
628fdc56
DA
25992013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2600
2601 Do not reset window modification event counters excessively.
2602 These leftovers and poor man's tricky methods to catch extra
2603 redisplay's attention are no longer needed.
2604 * frame.c (set_menu_bar_lines_1):
2605 * minibuf.c (read_minibuf_unwind):
2606 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2607 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2608 (window_scroll_line_based, Fset_window_configuration):
2609 * xdisp.c (redisplay_window): Do not reset last_modified and
2610 last_overlay_modified counters.
2611
8fd9c92e
JD
26122013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2613
2614 * xselect.c (x_send_client_event): Set send_event and serial, memset
2615 data.l as it might be bigger than data.b. Use 24 bit mask to
2616 XSendEvent (Bug#15034).
2617
0ee18172
EZ
26182013-08-07 Eli Zaretskii <eliz@gnu.org>
2619
2620 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2621 for TTY frames that are not the top frame on their console.
2622 (Bug#14616)
2623
16ddd1a6
MR
26242013-08-07 Martin Rudalics <rudalics@gmx.at>
2625
2626 * w32term.c (w32fullscreen_hook): Really maximize frame when
2627 asked for (Bug#14841).
2628
d2a95ffb
DA
26292013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2630
2631 Prefer selected_window to Fselected_window, likewise for frames.
2632 * buffer.c (Fbuffer_swap_text):
2633 * data.c (Fvariable_binding_locus):
2634 * window.c (run_window_configuration_change_hook): Adjust users.
2635 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2636 Use decode_live_frame.
2637
170da1ec
DA
26382013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2639
2640 Be more careful if selected window shows the buffer other than current,
2641 use window_outdated only if this is not so. This change should also
2642 address some weird issues discussed in Bug#13012.
2643 * window.h (window_outdated): New prototype.
2644 * window.c (window_outdated): Now here. Convert from static and
2645 always assume window's buffer.
2646 (Fwindow_end, Fwindow_line_height): Use it.
2647 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2648 and always assume window's buffer.
2649 (redisplay_window): Adjust user.
e5eefe9b 2650 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2651 check whether mode line should be updated only if selected window
2652 shows current buffer.
2653 (run_window_scroll_functions): Use eassert for debugging check.
2654 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2655
56b5d5b1
DA
26562013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2657
2658 * window.c (window_scroll, window_scroll_pixel_based)
2659 (window_scroll_line_based): Use bool for booleans.
2660
2878ba7e
PE
26612013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 * process.c: Fix minor off-by-one issues in descriptor counts.
2664 This shouldn't fix any real bugs, but it cleans up the code a bit.
2665 (max_process_desc, max_input_desc): -1, not 0, means none.
2666 All uses changed.
2667 (delete_input_desc): New function.
2668 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2669 (deactivate_process): Scan backwards when recomuting max_process_desc;
2670 that should be faster.
2671 (init_process_emacs): Initialize max_input_desc.
2672
e30b79c1
DA
26732013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2674
2675 Use region cache to speedup bidi_find_paragraph_start.
2676 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2677 Rename cache_long_line_scans to cache_long_scans.
2678 * buffer.c (bset_cache_long_line_scans): Rename to
2679 bset_cache_long_scans.
2680 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2681 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2682 into account.
2683 (syms_of_buffer): Rename cache-long-line-scans to
2684 cache-long-scans. Adjust docstring.
2685 * search.c (newline_cache_on_off):
2686 * indent.c (width_run_cache_on_off): Adjust users.
2687 * bidi.c (bidi_paragraph_cache_on_off): New function.
2688 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2689 * insdel.c (prepare_to_modify_buffer):
2690 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2691
00012b86
DA
26922013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2693
2694 Invalidate region caches only if buffer text is going to be changed.
2695 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2696 (modify_text): ...new prototype.
2697 (prepare_to_modify_buffer_1): New prototype.
2698 * textprop.c (modify_region): Rename to...
2699 (modify_text_properties): ...new function.
2700 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2701 (Fremove_list_of_text_properties): Adjust users.
2702 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2703 (modify_text): ...new function.
2704 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2705 (prepare_to_modify_buffer_1): ...new function.
2706 * casefiddle.c (casify_region):
2707 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2708 (Ftranspose_regions): Use modify_text.
2709
dc6c0eda
SM
27102013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2711
2712 * lisp.mk (lisp): Add nadvice.elc.
2713
8f3a2c26
DA
27142013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2715
2716 New macro to iterate over live buffers similar to frames.
2717 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2718 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2719 Declare buffer-related variables here to offload lisp.h.
2720 * buffer.c (Vbuffer_alist): Adjust comment.
2721 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2722 (other_buffer_safely):
2723 * data.c (store_symval_forwarding):
2724 * dispnew.c (Fframe_or_buffer_changed_p):
2725 * fileio.c (Fdo_auto_save):
2726 * filelock.c (unlock_all_files):
2727 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2728
e0fdb694
PE
27292013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2730
2731 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2732 * callproc.c (create_temp_file):
2733 * filelock.c (create_lock_file):
2734 Assume mkostemp, since it's now provided by Gnulib.
2735
63f5c6c2
EZ
27362013-08-04 Eli Zaretskii <eliz@gnu.org>
2737
2738 * w32.c (mkostemp): New function.
2739 (mktemp): Remove, no longer used. Most of the code reused in
2740 mkostemp. (Bug#15015)
484ab239 2741 (mktemp): Don't undef.
63f5c6c2 2742
f0b79313
DA
27432013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2744
2745 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2746 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2747 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2748 (free_glyph_pool, check_glyph_memory): Likewise for
2749 all users. Adjust comments where appropriate.
2750
98f638d6
PE
27512013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2752
2753 * composite.h: Minor fixups.
2754 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2755 to fix a misspelling, and change it to an inline function while
2756 we're at it (it need not be a macro). All uses changed.
2757 (composition_method, composition_valid_p):
2758 Rewrite to avoid assignments in if-conditions.
2759
75c59fb3
DA
27602013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2761
2762 Do not use global Lisp_Object in composition macros.
2763 * composite.h (composition_temp): Remove declaration.
2764 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2765 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2766 (compose_region): Remove the leftover.
75c59fb3
DA
2767 * composite.c (composition_temp): Remove.
2768 (run_composition_function, update_compositions)
2769 (composition_compute_stop_pos, composition_adjust_point)
2770 (Ffind_composition_internal):
2771 * coding.c (handle_composition_annotation):
2772 * xdisp.c (handle_composition_prop, check_point_in_composition):
2773 Related users changed.
2774
a10c8269
DA
27752013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2776
2777 Drop FRAME_PTR typedef.
2778 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2779 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2780 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2781 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2782 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2783 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2784 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2785 All related users changed.
2786
a104f656
SM
27872013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2788
2789 * eval.c (default_toplevel_binding): New function.
2790 (Fdefvar): Use it.
2791 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2792 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2793 (syms_of_eval): Export them.
2794 * data.c (Fdefault_value): Micro cleanup.
2795 * term.c (init_tty): Use "false".
2796
4b5c9326
DA
27972013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2798
2799 Fix X GC leak in GTK and raw (no toolkit) X ports.
2800 * xterm.c (x_free_frame_resources): If white and black relief
2801 GCs are allocated, always free them here.
2802 * xfns.c (x_make_gc): Omit redundant initialization.
2803 * widget.c (create_frame_gcs): Remove the leftover.
2804 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2805 in x_free_frame_resources.
2806
b19aa636
JD
28072013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2808
2809 * nsterm.m (windowWillResize:toSize:): Only change title if
2810 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2811 modifying it.
2812 (viewDidEndLiveResize): New method.
2813
2814 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2815 inside NS_IMPL_COCOA.
2816
af1f7e06
DA
28172013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2818
2819 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2820 Do not check whether undo is enabled because record_insert and
2821 record_delete does that themselves.
2822
65b02bb9
DA
28232013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2824
2825 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2826 member which is not really used any more.
2827 (FRAME_XIC_BASE_FONTNAME): Remove.
2828 * xfns.c (xic_free_fontset): Adjust user.
2829 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2830 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2831 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2832 (xdialog_show): Use eassert for debugging check.
7ee0f047 2833 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2834
6318cde0
PE
28352013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * fileio.c, fns.c (merge): Move extern decl from here ...
2838 * lisp.h (merge): ... to here.
2839
6c1a09ba
DA
28402013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2841
2842 Fix last font-related change.
2843 * w32font.h (w32font_list_internal, w32font_match_internal):
2844 Fix prototype.
2845 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2846 (uniscribe_list_family): Adjust to match font API change.
2847 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2848 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2849
f8c20208
DA
28502013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2851
2852 * frame.h (FRAME_MOUSE_UPDATE):
2853 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2854 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2855
fdb396e2
DA
28562013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2857
2858 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2859 * font.h (struct font_driver): Change list, match, and list_family
2860 functions to accept struct frame * as first arg.
068f9124
SM
2861 * font.c (font_score, font_compare, font_sort_entities):
2862 Remove prototypes.
fdb396e2
DA
2863 (font_sort_entities, font_list_entities, font_select_entity):
2864 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2865 match font API change.
2866 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2867 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2868 * ftxfont.c (ftxfont_list, ftxfont_match):
2869 * xftfont.c (xftfont_list, xftfont_match):
2870 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2871 * w32font.c (w32font_list, w32font_match, w32font_list):
2872 (w32font_list_internal, w32_font_match_internal): Likewise.
2873 * xfaces.c (Fx_family_fonts): Adjust user.
2874
52b8a085
DA
28752013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2876
2877 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2878 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2879 only if HAVE_X_WINDOWS is in use.
2880 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2881 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2882 * w32term.c (x_wm_set_icon_position): Likewise.
2883 * w32fns.c (x_icon): Adjust user.
2884
c791c18e
DA
28852013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2886
2887 * xterm.c (last_mouse_press_frame): Remove the
2888 leftover which is not really used any more.
2889 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2890 (x_flush): Call XFlush once per each X display, not frame.
2891 This is better because this code always unconditionally skips
2892 non-X frames in Vframe_list and issues the only XFlush if we
2893 have more than one X frame on the same X display.
2f935d86
DA
2894 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2895 Use bool for booleans.
2896 (x_draw_glyph_string_background, cvt_string_to_pixel):
2897 (cvt_pixel_dtor): Drop unnecessary prototypes.
2898 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2899
f435830e
DA
29002013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2901
2902 Drop unnecessary functions that deals with frame pixel size.
2903 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2904 (x_pixel_height): Drop prototypes.
2905 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2906 (x_pixel_height): Drop implementations.
2907 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2908 which should be always valid for window frame.
2909 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2910 * w32menu.c (Fx_popup_dialog):
2911 * xmenu.c (Fx_popup_dialog): Likewise for both.
2912
84231434
DA
29132013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2914
2915 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2916 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2917 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2918 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2919 and mention nil frame in docstring.
84231434 2920
959067a1
DA
29212013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2922
2923 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2924 (x_figure_window_size): Likewise. Adjust to return long.
2925 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2926 (toplevel): Move Qterminal_live_p to...
2927 * terminal.c (toplevel): ...here, make it static, and...
2928 (syms_of_terminal): ...DEFSYM here.
2929 * frame.h (Qterminal_live_p): Remove declaration.
2930 (make_frame, x_figure_window_size): Adjust prototype.
2931 * nsfns.m (Fx_create_frame): Use long for window flags.
2932
f4b169ce
PE
29332013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2934
2935 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2936 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2937 Do not assume that emacs_close (INT_MAX) is a no-op.
2938
bee6a2c7
DA
29392013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2940
2941 * xfaces.c (make_face_cache): For struct face_cache, prefer
2942 xmalloc to xzalloc and so avoid redundant call to memset.
2943 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2944
d7e6881a
DA
29452013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2946
2947 * fringe.c (draw_window_fringes, update_window_fringes)
2948 (compute_fringe_widths):
2949 * w32term.c (x_draw_glyph_string):
2950 * window.c (candidate_window_p, Frecenter):
2951 * xfaces.c (realize_basic_faces, realize_default_face)
2952 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2953 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2954 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2955 * xmenu.c (Fx_menu_bar_open_internal):
2956 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2957 * xsettings.c (xft_settings_event):
2958 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2959 Use bool for booleans. Adjust style and comments where
2960 appropriate.
2961 * dispextern.h (draw_window_fringes, update_window_fringes)
2962 (compute_fringe_widths):
2963 * xterm.h (x_had_errors_p): Adjust prototype.
2964
ec3058af
DA
29652013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2966
2967 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2968 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2969
218e0637
DA
29702013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2971
2972 * fns.c (toplevel): Remove comment before Fsafe_length because
2973 it checks for QUIT.
2974
e560aba9
PE
29752013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2978
2e5ce5de
EZ
29792013-07-28 Eli Zaretskii <eliz@gnu.org>
2980
2981 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2982 frame which got the message is still alive, before dereferencing
2983 its pointer. (Bug#14970)
2984
2985 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2986 be a live window, before using it as such. (Bug#14970)
2987
e95da6d3
EZ
29882013-07-27 Eli Zaretskii <eliz@gnu.org>
2989
2990 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2991 w32_detect_focus_change instead of doing part of its job by hand.
2992 This fixes the problem whereby FOCUS_OUT events were not sent to
2993 the event queue.
2994
a8f93651
EZ
29952013-07-26 Eli Zaretskii <eliz@gnu.org>
2996
fec92060
EZ
2997 * process.c (Fprocess_list): Doc fix.
2998
a8f93651
EZ
2999 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
3000 being re-exposed only if it didn't ask to become visible.
3001 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
3002 was previously iconified. (Bug#14841)
3003 (x_iconify_frame): Mark the frame iconified.
3004
d5a7a9d9
PE
30052013-07-26 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 Fix minor problems found by static checking.
3008 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
3009 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
3010
56ea7291
SM
30112013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3012
3013 * eval.c (set_specpdl_old_value): New function.
3014 (unbind_to): Minor simplification.
3015 (get_backtrace_frame): New function.
3016 (Fbacktrace_frame): Use it. Add `base' argument.
3017 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
3018 (syms_of_eval): Export backtrace-eval.
3019 * xterm.c (x_focus_changed): Simplify.
3020
9d611ffe
PE
30212013-07-25 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
3024
999c74e3
EZ
30252013-07-24 Eli Zaretskii <eliz@gnu.org>
3026
3027 * xdisp.c (redisplay_window): Instead of moving point out of
3028 scroll margin, reject the force_start method, and try scrolling
3029 instead. (Bug#14780)
3030
198fa217
KB
30312013-07-24 Ken Brown <kbrown@cornell.edu>
3032
3033 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
3034 (Bug#14944).
3035
53840e55
PE
30362013-07-24 Paul Eggert <eggert@cs.ucla.edu>
3037
3038 * eval.c (Fprogn): Do not check that BODY is a proper list.
3039 This undoes the previous change. The check slows down the
3040 interpreter, and is not needed to prevent a crash. See
3041 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
3042
60967f56
GM
30432013-07-23 Glenn Morris <rgm@gnu.org>
3044
3045 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
3046
9ca960e2
PE
30472013-07-23 Paul Eggert <eggert@cs.ucla.edu>
3048
a29c3e6d
PE
3049 Port to GNU/Linux systems with tinfo but not ncurses.
3050 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
3051 to decide whether ncurses is being used. Without this change,
3052 GCC complains about tgetent not being declared, on a system
3053 that has tinfo installed but ncurses not installed.
3054
f274311c
PE
3055 * eval.c (Fprogn): Check that BODY is a proper list.
3056
16b0520a
PE
3057 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
3058 * data.c (Fsetq_default):
3059 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
3060 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
3061 (Fcondition_case):
3062 Tune by taking advantage of the fact that ARGS is always a list
3063 when a function is declared to have UNEVALLED args.
3064
9ca960e2
PE
3065 * emacsgtkfixed.c: Port to GCC 4.6.
3066 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
3067
afacaa1b
JB
30682013-07-23 Juanma Barranquero <lekktu@gmail.com>
3069
3070 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
3071 here to silence compiler warnings.
3072
368a85a4
PE
30732013-07-22 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
3076 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
3077 from messing up Emacs's 'struct frame' (Bug#14923).
3078
f4e891b5
PE
30792013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3080
3081 * alloc.c (make_save_ptr_ptr): Define this function.
3082 It was inadvertently omitted. It's needed only if
3083 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
3084
96c8b65e
JD
30852013-07-21 Jan Djärv <jan.h.d@swipnet.se>
3086
3087 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
3088 frame have focus (Bug#14895).
3089
ee010797
PE
30902013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 Avoid vfork-related deadlock more cleanly.
3093 * callproc.c (child_setup): When the child's exec fails, output
3094 the program name, as that's more useful. Use O_NONBLOCK to avoid
3095 deadlock.
3096 * process.c (create_process_1): Remove; no longer needed.
3097 (create_process): Remove timer hack; no longer needed, now that
3098 the child avoids deadlock.
3099
f0398ec1 31002013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
3101
3102 * image.c (Fimage_flush): Fix doc typo.
3103
b2a069c2
PE
31042013-07-20 Paul Eggert <eggert@cs.ucla.edu>
3105
6496aec9
PE
3106 Fix array bounds violation when pty allocation fails.
3107 * process.c (PTY_NAME_SIZE): New constant.
3108 (pty_name): Remove static variable; it's now auto.
3109 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
3110 Take pty_name as an arg rather than using a static variable.
3111 All callers changed.
3112 (create_process): Recover pty_flag from process, not from volatile local.
3113 (create_pty): Stay inside array even when pty allocation fails.
3114 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
3115
b2a069c2
PE
3116 * lread.c (Fload): Avoid initialization only when lint checking.
3117 Mention that it's needed only for older GCCs.
3118
99107004
KH
31192013-07-20 Kenichi Handa <handa@gnu.org>
3120
3121 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
3122 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
3123
6b1b199d
AS
31242013-07-20 Andreas Schwab <schwab@linux-m68k.org>
3125
3126 * lread.c (Fload): Avoid uninitialized warning.
3127
4195afc3
PE
31282013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3129
3f5bef16
PE
3130 Fix some minor file descriptor leaks and related glitches.
3131 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
3132 (create_lock_file): Use write, not emacs_write.
3133 * image.c (slurp_file, png_load_body):
3134 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
3135 (server_accept_connection):
3136 Don't leak an fd on memory allocation failure.
3137 * image.c (slurp_file): Add a cheap heuristic for growing files.
3138 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
3139 as that's what the other routines do. Maybe input need not be
3140 blocked at all, but it's better to be consistent.
3141 Avoid undefined behavior when strlen is zero.
3142
4195afc3
PE
3143 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
3144 (NSTATICS): Now a constant; doesn't need to be a macro.
3145
a1aeeffe
RS
31462013-07-19 Richard Stallman <rms@gnu.org>
3147
3148 * coding.c (decode_coding_utf_8): Add simple loop for fast
3149 processing of ASCII characters.
3150
63b34baa
PE
31512013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
3154
621dd9ac
EZ
31552013-07-19 Eli Zaretskii <eliz@gnu.org>
3156
3157 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
3158 unportable 'struct x_display_info'.
3159 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
3160 is a portable type.
3161
1396ac86
PE
31622013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3163
ab9980cd
PE
3164 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
3165 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
3166 or fscanf fails.
3167 (system_process_attributes): Prefer plain char to unsigned char
3168 when either will do. Clean up properly if interrupted or if
068f9124
SM
3169 memory allocations fail. Don't assume sscanf succeeds.
3170 Remove no-longer-needed workaround to stop GCC from whining.
3171 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
3172 bit more carefully.
3173
1396ac86
PE
3174 Fix obscure porting bug with varargs functions.
3175 The code assumed that int is treated like ptrdiff_t in a vararg
3176 function, which is not a portable assumption. There was a similar
3177 -- though these days less likely -- porting problem with various
3178 assumptions that pointers of different types all smell the same as
3179 far as vararg functions is conserved. To make this problem less
3180 likely in the future, redo the API to use varargs functions.
3181 * alloc.c (make_save_value): Remove this vararg function.
3182 All uses changed to ...
3183 (make_save_int_int_int, make_save_obj_obj_obj_obj)
3184 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
3185 New functions.
3186 (make_save_ptr): Rename from make_save_pointer, for consistency with
3187 the above. Define only on platforms that need it. All uses changed.
3188
4d19d194
PE
31892013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 * keyboard.c: Try to fix typos in previous change.
3192 (DISPLAY_LIST_INFO): New macro.
3193 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 3194 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 3195
945c5bb1
JB
31962013-07-18 Juanma Barranquero <lekktu@gmail.com>
3197
3198 * keyboard.c (kbd_buffer_get_event):
3199 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
3200 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
3201
f4b1eb36
PE
32022013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3203
5e679a2c
PE
3204 * filelock.c: Fix unlikely file descriptor leaks.
3205 (get_boot_time_1): Rework to avoid using emacs_open.
3206 This doesn't actually fix a leak, but is better anyway.
3207 (read_lock_data): Use read, not emacs_read.
3208
a8cd4836
PE
3209 * doc.c: Fix minor memory and file descriptor leaks.
3210 * doc.c (get_doc_string): Fix memory leak when doc file absent.
3211 (get_doc_string, Fsnarf_documentation):
3212 Fix file descriptor leak on error.
3213
ef30e638
PE
3214 * term.c: Fix minor fdopen-related file descriptor leaks.
3215 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
3216 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
3217
f4b1eb36
PE
3218 * charset.c: Fix file descriptor leaks and errno issues.
3219 Include <errno.h>.
3220 (load_charset_map_from_file): Don't leak file descriptor on error.
3221 Use plain record_xmalloc since the allocation is larger than
3222 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
3223 of entries.
3224 * eval.c (record_unwind_protect_nothing):
3225 * fileio.c (fclose_unwind):
3226 New functions.
3227 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
3228 The replacement doesn't block input, but that no longer seems
3229 necessary.
3230
b648c163
PE
32312013-07-17 Paul Eggert <eggert@cs.ucla.edu>
3232
a0931322
PE
3233 * lread.c: Fix file descriptor leaks and errno issues.
3234 (Fload): Close some races that leaked fds or streams when 'load'
3235 was interrupted.
3236 (Fload, openp): Report error number of last nontrivial failure to open.
3237 ENOENT counts as trivial.
3238 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
3239 New functions.
3240 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
3241 now that the function is always called with a nonnegative arg.
3242 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
3243 All uses replaced with ...
3244 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
3245
b648c163
PE
3246 A few more minor file errno-reporting bugs.
3247 * callproc.c (Fcall_process):
3248 * doc.c (Fsnarf_documentation):
3249 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
3250 * process.c (set_socket_option):
3251 Don't let a constructor trash errno.
3252 * doc.c: Include <errno.h>.
3253
b1dc4084
JB
32542013-07-16 Juanma Barranquero <lekktu@gmail.com>
3255
3256 * w32fns.c (unwind_create_tip_frame): Fix declaration.
3257
c43843aa
PE
32582013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3259
50a30cce
PE
3260 Fix w32 bug with call-process-region (Bug#14885).
3261 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
3262 to Fcall_process when the input is empty. This simplifies the
3263 code a bit. It makes no difference on POSIXish platforms but
3264 apparently it fixes a bug on w32.
3265
44e18199 3266 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
3267 * fileio.c (close_file_unwind): Don't close if FD is negative;
3268 this can happen when unwinding a zapped file descriptor.
3269 (Finsert_file_contents): Unwind-protect the fd before the point marker,
3270 in case Emacs runs out of memory between the two unwind-protects.
3271 Don't trash errno when closing FD.
3272 Zap the FD in the specpdl when closing it, instead of deferring
3273 the removal of the unwind-protect; this fixes a bug where a child
3274 function unwinds the stack past us.
3275
27e498e6
PE
3276 New unwind-protect flavors to better type-check C callbacks.
3277 This also lessens the need to write wrappers for callbacks,
3278 and the need for make_save_pointer.
3279 * alloca.c (free_save_value):
3280 * atimer.c (run_all_atimers):
3281 Now extern.
3282 * alloc.c (safe_alloca_unwind):
3283 * atimer.c (unwind_stop_other_atimers):
3284 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
3285 * menu.c (cleanup_popup_menu) [HAVE_NS]:
3286 * minibuf.c (choose_minibuf_frame_1):
3287 * process.c (make_serial_process_unwind):
3288 * xdisp.h (pop_message_unwind):
3289 * xselect.c (queue_selection_requests_unwind):
3290 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
3291 * alloca.c (record_xmalloc):
3292 Prefer record_unwind_protect_ptr to record_unwind_protect with
3293 make_save_pointer.
3294 * alloca.c (Fgarbage_collect):
3295 Prefer record_unwind_protect_void to passing a dummy.
3296 * buffer.c (restore_buffer):
3297 * window.c (restore_window_configuration):
3298 * xfns.c, w32fns.c (do_unwind_create_frame)
3299 New wrapper. All record-unwind uses of wrappee changed.
3300 * buffer.c (set_buffer_if_live):
3301 * callproc.c (call_process_cleanup, delete_temp_file):
3302 * coding.c (code_conversion_restore):
3303 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
3304 * editfns.c (save_excursion_restore)
3305 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
3306 (save_restriction_restore):
3307 * eval.c (restore_stack_limits, un_autoload):
3308 * fns.c (require_unwind):
3309 * keyboard.c (recursive_edit_unwind, tracking_off):
3310 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
3311 * macros.c (pop_kbd_macro, restore_menu_items):
3312 * nsfns.m (unwind_create_frame):
3313 * print.c (print_unwind):
3314 * process.c (start_process_unwind):
3315 * search.c (unwind_set_match_data):
3316 * window.c (select_window_norecord, select_frame_norecord):
3317 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
3318 (fast_set_selected_frame):
3319 * xfns.c, w32fns.c (unwind_create_tip_frame):
3320 Return void, not a dummy Lisp_Object. All uses changed.
3321 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
3322 * callproc.c (call_process_kill):
3323 * fileio.c (restore_point_unwind, decide_coding_unwind)
3324 (build_annotations_unwind):
3325 * insdel.c (Fcombine_after_change_execute_1):
3326 * keyboard.c (read_char_help_form_unwind):
3327 * menu.c (unuse_menu_items):
3328 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
3329 * sound.c (sound_cleanup):
3330 * xdisp.c (unwind_redisplay):
3331 * xfns.c (clean_up_dialog):
3332 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
3333 Accept no args and return void, instead of accepting and returning
3334 a dummy Lisp_Object. All uses changed.
3335 * cygw32.c (fchdir_unwind):
3336 * fileio.c (close_file_unwind):
3337 * keyboard.c (restore_kboard_configuration):
3338 * lread.c (readevalllop_1):
3339 * process.c (wait_reading_process_output_unwind):
3340 Accept int and return void, rather than accepting an Emacs integer
3341 and returning a dummy object. In some cases this fixes an
3342 unlikely bug when the corresponding int is outside Emacs integer
3343 range. All uses changed.
3344 * dired.c (directory_files_internal_unwind):
3345 * fileio.c (do_auto_save_unwind):
3346 * gtkutil.c (pop_down_dialog):
3347 * insdel.c (reset_var_on_error):
3348 * lread.c (load_unwind):
3349 * xfns.c (clean_up_file_dialog):
3350 * xmenu.c, nsmenu.m (pop_down_menu):
3351 * xmenu.c (cleanup_widget_value_tree):
3352 * xselect.c (wait_for_property_change_unwind):
3353 Accept pointer and return void, rather than accepting an Emacs
3354 save value encapsulating the pointer and returning a dummy object.
3355 All uses changed.
3356 * editfns.c (Fformat): Update the saved pointer directly via
3357 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3358 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3359 (unwind_body): New function.
3360 (record_unwind_protect): First arg is now a function returning void,
3361 not a dummy Lisp_Object.
3362 (record_unwind_protect_ptr, record_unwind_protect_int)
3363 (record_unwind_protect_void): New functions.
3364 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3365 * fileio.c (struct auto_save_unwind): New type.
3366 (do_auto_save_unwind): Use it.
3367 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3368 * insdel.c (struct rvoe_arg): New type.
3369 (reset_var_on_error): Use it.
3370 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3371 New constants.
3372 (specbinding_func): Remove; there are now several such functions.
3373 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3374 (set_unwind_protect_ptr): New function.
3375 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3376
4e604a5d
PE
3377 Be simpler and more consistent about reporting I/O errors.
3378 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3379 Say "Read error" and "Write error", rather than "I/O error", or
3380 "IO error reading", or "IO error writing", when a read or write
3381 error occurs.
3382 * process.c (Fmake_network_process, wait_reading_process_output)
3383 (send_process, Fprocess_send_eof, wait_reading_process_output):
3384 Capitalize diagnostics consistently. Put "failed foo" at the
3385 start of the diagnostic, so that we don't capitalize the
3386 function name "foo". Consistently say "failed" for such
3387 diagnostics.
3388 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3389 All callers changed. This is so it can use report_file_error.
3390 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3391 diagnostics consistently as above.
3392
a9757f6a
PE
3393 * fileio.c (report_file_errno): Fix errno reporting bug.
3394 If the file name is neither null nor a pair, package it up as a
3395 singleton list. All callers changed, both to this function and to
3396 report_file_error. This fixes a bug where the memory allocator
3397 invoked by list1 set errno so that the immediately following
3398 report_file_error reported the wrong errno value.
3399
c43843aa
PE
3400 Fix minor problems found by --enable-gcc-warnings.
3401 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3402 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3403
18c26d81
JD
34042013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3405
3406 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3407 Set event->arg to Qt if switch-event shall be generated.
3408 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3409
3410 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3411
3412 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3413 FOCUS_OUT_EVENT.
3414
3415 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3416 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3417 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3418 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3419 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3420 and there is a focused frame.
3421 (head_table): Add focus-in and focus-out.
3422 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3423 bind to handle-focus-in/out.
3424
3425 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3426 (Fhandle_switch_frame): Call Fhandle_focus_in.
3427 (syms_of_frame): defsubr handle-focus-in/out.
3428
6c6f1994
PE
34292013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3430
c7ddc792
PE
3431 Fix porting bug to older POSIXish platforms (Bug#14862).
3432 * sysdep.c (emacs_pipe): New function, that implements
3433 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3434 This should port better to CentOS 5 and to Mac OS X 10.6.
3435 All calls to pipe2 changed.
3436
6c6f1994
PE
3437 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3438 This makes the code easier to read and the executable a bit smaller.
3439 Do not replace all calls to Fcons that happen to create lists,
3440 just calls that are intended to create lists. For example, when
3441 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3442 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3443 Similarly for list2 through list5.
3444 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3445 * bytecode.c (exec_byte_code):
3446 * callint.c (quotify_arg, Fcall_interactively):
3447 * callproc.c (Fcall_process, create_temp_file):
3448 * charset.c (load_charset_map_from_file)
3449 (Fdefine_charset_internal, init_charset):
3450 * coding.c (get_translation_table, detect_coding_system)
3451 (Fcheck_coding_systems_region)
3452 (Fset_terminal_coding_system_internal)
3453 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3454 * composite.c (update_compositions, Ffind_composition_internal):
3455 * dired.c (directory_files_internal, file_name_completion)
3456 (Fsystem_users):
3457 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3458 * doc.c (Fsnarf_documentation):
3459 * editfns.c (Fmessage_box):
3460 * emacs.c (main):
3461 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3462 (Feval, eval_sub, Ffuncall, apply_lambda):
3463 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3464 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3465 (Fset_file_times, Finsert_file_contents)
3466 (Fchoose_write_coding_system, Fwrite_region):
3467 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3468 * font.c (font_registry_charsets, font_parse_fcname)
3469 (font_prepare_cache, font_update_drivers, Flist_fonts):
3470 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3471 * frame.c (make_frame, Fmake_terminal_frame)
3472 (x_set_frame_parameters, x_report_frame_params)
3473 (x_default_parameter, Fx_parse_geometry):
3474 * ftfont.c (syms_of_ftfont):
3475 * image.c (gif_load):
3476 * keyboard.c (command_loop_1):
3477 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3478 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3479 (Fminor_mode_key_binding, accessible_keymaps_1)
3480 (Faccessible_keymaps, Fwhere_is_internal):
3481 * lread.c (read_emacs_mule_char):
3482 * menu.c (find_and_return_menu_selection):
3483 * minibuf.c (get_minibuffer):
3484 * nsfns.m (Fns_perform_service):
3485 * nsfont.m (ns_script_to_charset):
3486 * nsmenu.m (ns_popup_dialog):
3487 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3488 (Fx_own_selection_internal):
3489 * nsterm.m (append2):
3490 * print.c (Fredirect_debugging_output)
3491 (print_prune_string_charset):
3492 * process.c (Fdelete_process, Fprocess_contact)
3493 (Fformat_network_address, set_socket_option)
3494 (read_and_dispose_of_process_output, write_queue_push)
3495 (send_process, exec_sentinel):
3496 * sound.c (Fplay_sound_internal):
3497 * textprop.c (validate_plist, add_properties)
3498 (Fput_text_property, Fadd_face_text_property)
3499 (copy_text_properties, text_property_list, syms_of_textprop):
3500 * unexaix.c (report_error):
3501 * unexcoff.c (report_error):
3502 * unexsol.c (unexec):
3503 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3504 (Fformat_mode_line, syms_of_xdisp):
3505 * xfaces.c (set_font_frame_param)
3506 (Finternal_lisp_face_attribute_values)
3507 (Finternal_merge_in_global_face, syms_of_xfaces):
3508 * xfns.c (x_default_scroll_bar_color_parameter)
3509 (x_default_font_parameter, x_create_tip_frame):
3510 * xfont.c (xfont_supported_scripts):
3511 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3512 (menu_help_callback, xmenu_show):
3513 * xml.c (make_dom):
3514 * xterm.c (set_wm_state):
3515 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3516 and similarly for list2 through list5.
3517
bafe80ce
PE
35182013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3519
3520 * callproc.c (Fcall_process_region): Fix minor race and tune.
3521 (create_temp_file): New function, with the temp-file-creation part
3522 of the old Fcall_process_region. Use Fcopy_sequence to create the
3523 temp file name, rather than alloca + build_string, for simplicity.
3524 Don't bother to block input around the temp file creation;
068f9124
SM
3525 shouldn't be needed. Simplify use of mktemp.
3526 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3527 this closes an unlikely race where the temp file was not removed.
3528 Use memcpy rather than an open-coded loop.
3529 (Fcall_process_region): Use the new function. If the input is
3530 empty, redirect from /dev/null rather than from a newly created
3531 empty temp file; this avoids unnecessary file system traffic.
3532
4700b5a5
PE
35332013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3534
5c97beae
PE
3535 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3536 Simplify by making this case like the other two. This is a bit
3537 slower on obsolete hosts, but the extra complexity isn't worth it.
3538
4700b5a5
PE
3539 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3540 * process.c (create_process) [!DOS_NT]:
3541 Remove now-unnecessary calls to emacs_close.
3542
f9a74c4c
EZ
35432013-07-13 Eli Zaretskii <eliz@gnu.org>
3544
922ae7ee
EZ
3545 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3546 returning early. (Bug#14850)
3547
f9a74c4c
EZ
3548 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3549 and inhibit-iso-escape-detection attributes of 'undecided'.
3550 (Bug#14822)
3551
5e301d76
PE
35522013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3553
69e0e5ee
PE
3554 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3555 Reported by Herbert J. Skuhra in
3556 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3557
5e301d76
PE
3558 Don't lose top specpdl entry when memory is exhausted.
3559 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3560 specpdl overflow here, to simplify callers; all callers changed.
3561 Always reserve an unused entry at the stack top; this avoids
3562 losing the top entry's information when memory is exhausted.
3563
7e649856
PE
35642013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3565
a773ed9a
PE
3566 Clean up errno reporting and fix some errno-reporting bugs.
3567 * callproc.c (Fcall_process):
3568 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3569 * process.c (create_process, Fmake_network_process):
3570 * unexaix.c (report_error):
3571 * unexcoff.c (report_error):
3572 Be more careful about reporting the errno of failed operations.
3573 The code previously reported the wrong errno sometimes.
3574 Also, prefer report_file_errno to setting errno + report_file_error.
3575 (Fcall_process): Look at openp return value rather than at path,
3576 as that's a bit faster and clearer when there's a numeric predicate.
3577 * fileio.c (report_file_errno): New function, with most of the
3578 old contents of report_file_error.
3579 (report_file_error): Use it.
3580 (Ffile_exists_p, Ffile_accessible_directory_p):
3581 Set errno to 0 when it is junk.
3582 * fileio.c (Faccess_file):
3583 * image.c (x_create_bitmap_from_file):
3584 Use faccessat rather than opening the file, to avoid the hassle of
3585 having a file descriptor open.
3586 * lisp.h (report_file_errno): New decl.
3587 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3588
7e649856
PE
3589 Minor EBADF fixes.
3590 * process.c (create_process, wait_reading_process_output) [AIX]:
3591 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3592 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3593 a multithreaded environment anyway).
3594 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3595
f6774c1a
AS
35962013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3597
3598 * image.c (x_find_image_file): Don't close a remote file handle.
3599
bacba3c2
PE
36002013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 Fix races with threads and file descriptors.
3603 * callproc.c (Fcall_process_region):
3604 * dired.c (open_directory):
3605 * emacs.c (main, Fdaemon_initialized):
3606 * image.c (x_find_image_file):
3607 * inotify.c (Finotify_rm_watch):
3608 * lread.c (Flocate_file_internal):
3609 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3610 * term.c (term_mouse_moveto, init_tty):
3611 * termcap.c (tgetent):
3612 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3613 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3614 * unexhp9k800.c, unexmacosx.c (unexec):
3615 * callproc.c (Fcall_process_region):
3616 Use emacs_close, not close.
3617 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3618 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3619 and posix_close function on current platforms (which all lack them).
3620 (emacs_close): Use it. This should fix the races on GNU/Linux and
3621 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3622 and it should avoid closing random victim file descriptors on
3623 other platforms.
3624
653d4f43
PE
36252013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3626
c8536ec4
PE
3627 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3628 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3629 Touch up doc a bit.
3630
9c203066
PE
3631 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3632 This is for .gdbinit xbacktrace.
3633
653d4f43
PE
3634 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3635 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3636 (emacs_set_tty): Now static.
3637 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3638 * term.c (tty_capable_p, tty_default_color_capabilities)
3639 (get_tty_terminal, term_mouse_movement)
3640 (handle_one_term_event, init_tty, maybe_fatal):
3641 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3642 (tgetent, scan_file, name_match, compare_contin):
3643 * terminal.c (get_terminal):
3644 Use bool for boolean.
3645 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3646 Prefer char to unsigned char if either will do.
3647 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3648 (tty_write_glyphs): Prefer int to unsigned.
3649 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3650 All callers changed.
3651 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3652
45b683a1
PE
36532013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3654
29abe551
PE
3655 Port to C89.
3656 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3657 (B__dummy__): New dummy symbol, to pacify C89.
3658 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3659 they can't grok varargs macros.
3660 * dispnew.c (add_window_display_history)
3661 (add_frame_display_history):
3662 * print.c (print_object):
3663 * xdisp.c (debug_method_add):
3664 Use %p printf format only for void pointers.
3665 * emacs.c (usage_message): New constant, replacing ...
3666 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3667 (main): Adjust to usage reorg.
3668 * fns.c (syms_of_fns):
3669 * profiler.c (syms_of_profiler):
3670 Don't use non-constant struct initializers.
3671 * gnutls.h (gnutls_initstage_t):
3672 * lisp.h (enum Lisp_Fwd_Type):
3673 * lread.c (lisp_file_lexically_bound_p):
3674 * xsettings.c (anonymous enum):
3675 Remove trailing comma.
3676 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3677 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3678 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3679 (DEFUN): Use it.
3680 * regex.c (const_re_char): New type, to pacify strict C89.
3681 All uses of 'const re_char' replaced to use it.
3682 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3683 with glibc when strict C89. This change is imported from gnulib.
3684 All uses changed.
3685 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3686 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3687 Omit GNU_LINUX implementation, since it requires long long.
3688 * xterm.c (x_draw_underwave):
3689 Do not assume the traditional order of struct's members.
3690 (x_term_init): Rewrite to avoid the need for non-constant structure
3691 initializers.
3692
45b683a1 3693 Syntax cleanup, mostly replacing macros with functions.
763a086d 3694 This removes the need for the syntax_temp hack.
45b683a1
PE
3695 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3696 * syntax.c (SYNTAX_INLINE): New macro.
3697 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3698 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3699 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3700 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3701 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3702 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3703 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3704 Now constants, not macros.
3705 (syntax_temp) [!__GNUC__]: Remove.
3706 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3707 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3708 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3709 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3710 Move here from syntax.h; now functions, not macros. Except for the
3711 last function, these are static since only syntax.c uses them.
3712 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3713 All uses changed. Now a function, not a macro; use this fact
3714 to simplify the code.
3715 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3716 compiler bugs; no longer relevant.
3717 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3718 (SYNTAX_INLINE): New macro.
3719 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3720 for the new functions. Use bool for boolean member.
3721 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3722 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3723 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3724 (SETUP_BUFFER_SYNTAX_TABLE):
3725 Now extern inline functions, not macros.
3726 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3727 Remove; all uses replaced by implementation.
3728 (syntax_temp) [!__GNUC__]: Remove decl.
3729 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3730
29be4a50
JD
37312013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3732
3733 * emacs.c (main): Fix syntax error.
3734
954b166e
PE
37352013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 Timestamp fixes for undo (Bug#14824).
3738 * atimer.c (schedule_atimer):
3739 * fileio.c (Ffile_newer_than_file_p):
3740 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3741 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3742 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3743 (syms_of_fileio): Remove Sclear_visited_file_name.
3744 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3745 file doesn't exist; this avoids an ambiguity with negative timestamps.
3746 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3747 * systime.h (make_emacs_time, invalid_emacs_time):
3748 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3749 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3750 * undo.c (record_first_change): Push (visited-file-modtime) onto
3751 undo list rather than reimplementing it by hand, incorrectly.
3752
d74647c3
KB
37532013-07-09 Ken Brown <kbrown@cornell.edu>
3754
3755 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3756
3c51b96b
JB
37572013-07-09 Juanma Barranquero <lekktu@gmail.com>
3758
3759 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3760
4ebbdd67
PE
37612013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3762
3763 Handle errno and exit status a bit more carefully.
3764 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3765 number into an exit status. Instead, use EXIT_CANCELED.
3766 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3767 * callproc.c (relocate_fd):
3768 * emacs.c (close_output_streams, main):
3769 * process.c (create_process):
3770 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3771 Use emacs_perror for simplicity.
3772 * callproc.c (relocate_fd, main):
3773 * sysdep.c (sys_subshell):
3774 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3775 (shut_down_emacs): Use emacs_write, not write.
3776 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3777 * fileio.c (Fcopy_file, e_write):
3778 * nsterm.m (ns_select):
3779 * process.c (send_process):
3780 * sound.c (vox_write):
3781 Use emacs_write_sig, not emacs_write.
3782 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3783 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3784 New constants.
3785 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3786 of write.
3787 (emacs_full_write): New function.
3788 (emacs_write): Rewrite to use it.
3789 (emacswrite_sig, emacs_perror): New functions.
3790 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3791
44e18199 37922013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3793
3794 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3795 on NS even if it is present. Pixmap on NS is a void*.
3796
9caab067
PE
37972013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 Port to Ubuntu 10 (Bug#14803).
3800 Problem reported by T.V. Raman.
3801 * process.c (close_on_exec, accept4, process_socket):
3802 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3803
1d442672
EZ
38042013-07-07 Eli Zaretskii <eliz@gnu.org>
3805
3806 * w32.c (sys_dup): Declare prototype.
3807
3808 * filelock.c:
3809 * emacs.c:
3810 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3811
067428c1
PE
38122013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 Make file descriptors close-on-exec when possible (Bug#14803).
3815 This simplifies Emacs a bit, since it no longer needs to worry
3816 about closing file descriptors by hand in some cases.
3817 It also fixes some unlikely races. Not all such races, as
3818 libraries often open files internally without setting
3819 close-on-exec, but it's an improvement.
3820 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3821 * callproc.c (Fcall_process) [!MSDOS]:
3822 * emacs.c (main) [!DOS_NT]:
3823 * nsterm.m (ns_term_init):
3824 * process.c (create_process):
3825 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3826 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3827 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3828 Prefer mkostemp with O_CLOEXEC to mkstemp.
3829 * callproc.c (relocate_fd) [!WINDOWSNT]:
3830 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3831 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3832 now using pipe2.
3833 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3834 Make the resulting file descriptor close-on-exec.
3835 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3836 * lread.c (load_descriptor_list, load_descriptor_unwind):
3837 Remove; no longer needed. All uses removed.
3838 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3839 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3840 New functions.
3841 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3842 (Fmake_network_process, Fnetwork_interface_list):
3843 (Fnetwork_interface_info, server_accept_connection):
3844 Make newly-created socket close-on-exec.
3845 * sysdep.c (emacs_open, emacs_fopen):
3846 Make new-created descriptor close-on-exec.
3847 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3848 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3849
0da857dd
JD
38502013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3851
3852 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3853 for NS_IMPL_GNUSTEP.
3854
5f86adcd
PE
38552013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3856
3857 Fix openp errno handling.
3858 * callproc.c (Fcall_process): Preserve openp errno around close.
3859 * lread.c (openp): Set errno when returning -1, as some callers
3860 expect this.
3861
1afb1d07
JD
38622013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3863
3864 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3865
3866 * nsterm.h (NSSavePanel): Update comment.
3867 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3868 (ns_run_file_dialog): Declare.
3869
3870 * nsfns.m: Remove panelOK.
3871 (ns_fd_data): New.
3872 (ns_run_file_dialog): New function.
3873 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3874 event loop, so file dialog is popped up by ns_run_file_dialog, called
3875 by sendEvent (Bug#14578).
3876 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3877
3323c263
EZ
38782013-07-06 Eli Zaretskii <eliz@gnu.org>
3879
fdda0220
EZ
3880 * xdisp.c (default_line_pixel_height): New function.
3881 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3882 (try_cursor_movement, redisplay_window, try_window)
3883 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3884
068f9124
SM
3885 * window.c (window_scroll_pixel_based):
3886 use default_line_pixel_height.
fdda0220
EZ
3887
3888 * dispextern.h (default_line_pixel_height): Add prototype.
3889
3890 * frame.c (x_set_line_spacing): Accept a float value for
3891 line-spacing parameter, per the documentation.
3892
3323c263
EZ
3893 * data.c (Fmultibyte_string_p): Doc fix.
3894
47ba6d43
PE
38952013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3896
406af475
PE
3897 Use emacs_open more consistently when opening files.
3898 This handles EINTR more consistently now, and makes it easier
3899 to introduce other uniform changes to file descriptor handling.
3900 * src/systdio.h: New file.
3901 * src/buffer.c (mmap_init):
3902 * cygw32.c (chdir_to_default_directory):
3903 * dispnew.c (Fopen_termscript):
3904 * emacs.c (Fdaemon_initialized):
3905 * fileio.c (Fdo_auto_save):
3906 * image.c (slurp_file, png_load_body, jpeg_load_body):
3907 * keyboard.c (Fopen_dribble_file):
3908 * lread.c (Fload):
3909 * print.c (Fredirect_debugging_output):
3910 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3911 * termcap.c (tgetent):
3912 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3913 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3914 * w32term.c (w32_initialize) [CYGWIN]:
3915 * xfaces.c (Fx_load_color_file):
3916 Use emacs_open instead of plain open, and emacs_fopen instead of
3917 plain fopen.
3918 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3919 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3920 * callproc.c (default_output_mode): New constant.
3921 (Fcall_process): Use it to call emacs_open instead of plain creat.
3922 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3923 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3924 (emacs_fopen): New function.
3925 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3926 Include <lisp.h>, for emacs_open.
3927 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3928
47ba6d43
PE
3929 Remove duplicate #include directives.
3930 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3931 * xfaces.c:
3932 Don't include stdio.h twice.
3933 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3934 Don't include sys/types.h or stdio.h twice.
3935 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3936 * lread.c: Don't include coding.h twice.
3937 * nsfont.m: Don't include frame.h twice.
3938 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3939 * ralloc.c: Don't include <unistd.h> twice.
3940 * xdisp.c: Don't include font.h twice.
3941 * xterm.c: Don't include fontset.h twice.
3942 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3943
b9ed53d5
PE
39442013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 Scale ImageMagick images more carefully.
3947 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3948 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3949 Be more careful about avoiding undefined behavior after
3950 integer overflow and division by zero.
3951
cf13177e
YM
39522013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3953
3954 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3955 (syms_of_w32fns): DEFSYM them.
3956 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3957 (CCHDEVICENAME): Define macros if not defined.
3958 (struct MONITOR_INFO_EX): New struct.
3959 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3960 (enum_display_monitors_fn): New variable.
3961 (globals_of_w32fns): Initialize it.
3962 (Fx_display_pixel_width, Fx_display_pixel_height)
3963 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3964 multi-monitor setups in docstrings.
3965 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3966 screen size by primary monitor's millimeter per pixel.
3967 (w32_monitor_enum, w32_display_monitor_attributes_list)
3968 (w32_display_monitor_attributes_list_fallback)
3969 (Fw32_display_monitor_attributes_list): New functions.
3970 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3971
3972 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3973 if not defined.
3974 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3975
86dfb7a8
MA
39762013-07-04 Michael Albinus <michael.albinus@gmx.de>
3977
3978 * fileio.c (Qfile_notify_error): New error symbol.
3979
3980 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3981 * inotify.c (inotify_callback, symbol_to_inotifymask)
3982 (Finotify_add_watch, Finotify_rm_watch): Use it.
3983 (inotifyevent_to_event): Exchange order of cookie and file name.
3984 (Finotify_add_watch): Adapt docstring.
3985
3986 * lisp.h (Qfile_notify_error): Declare.
3987
2c1c974b
PE
39882013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3989
3990 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3991 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3992 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3993 which did not work (see <http://bugs.gnu.org/14569#307>).
3994 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3995 && (!noninteractive || initialized)). This attempts to thread
3996 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3997
7a35b20f
JB
39982013-07-04 Juanma Barranquero <lekktu@gmail.com>
3999
4000 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
4001 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
4002
1ce5cd04
PE
40032013-07-04 Paul Eggert <eggert@cs.ucla.edu>
4004
4005 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
4006 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4007 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
4008 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
4009
57f8c490
PE
40102013-07-02 Paul Eggert <eggert@cs.ucla.edu>
4011
4012 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
4013 Define to __sys_siglist.
4014
bcffb5ca
EZ
40152013-07-02 Eli Zaretskii <eliz@gnu.org>
4016
4017 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
4018 word-wrap, so that overflow-newline-into-fringe would work in
4019 visual-line-mode. (Bug#2749)
4020 (move_it_in_display_line_to): When the last scanned display
4021 element fits exactly on the display line, and
4022 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
4023 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
4024 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
4025 finding buffer position that corresponds to pixel coordinates,
4026 e.g. in buffer_posn_from_coords.
4027
2c41e781
JD
40282013-07-02 Jan Djärv <jan.h.d@swipnet.se>
4029
4030 * process.c (handle_child_signal): Call catch_child_signal if
4031 NS_IMPL_GNUSTEP.
4032
c2418359
PE
40332013-07-02 Paul Eggert <eggert@cs.ucla.edu>
4034
52a9bcae
PE
4035 Don't convert function pointers to void * and back.
4036 It isn't portable C, and it's easy enough to avoid.
4037 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
4038 (make_save_value): Add support for SAVE_FUNCPOINTER.
4039 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
4040 * print.c (print_object):
4041 Distinguish function from object pointers.
4042 * lisp.h (SAVE_FUNCPOINTER): New constant.
4043 (SAVE_SLOT_BITS): Adjust to it.
4044 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
4045 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
4046 (voidfuncptr): New typedef.
4047 (struct Lisp_Save_Value): New member data[0].funcpointer.
4048 (XSAVE_FUNCPOINTER): New function.
4049
c2418359
PE
4050 Simplify buildobj processing.
4051 * Makefile.in (buildobj.h): Make it a sequence of strings each
4052 followed by comma, rather than a single string. Put it into a
4053 .tmp file in case there's an error while generating it.
4054 (gl-stamp): Use .tmp for temp files.
4055 (mostlyclean): Clean .tmp files.
4056 * doc.c (buildobj): Move to just the routine that needs it.
4057 It's now an array of strings, so processing is simpler.
4058
8f43ce49
PE
40592013-07-01 Paul Eggert <eggert@cs.ucla.edu>
4060
4061 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
4062 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
4063 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4064 Invoke malloc_enable_thread even when not interactive.
4065 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
4066 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
4067 in this case, since the underlying bug has now been fixed.
4068
24827db9
JB
40692013-07-01 Juanma Barranquero <lekktu@gmail.com>
4070
4071 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
4072 unlinking it (bug#14691).
4073
ef099a94
MN
40742013-06-30 Michal Nazarewicz <mina86@mina86.com>
4075
4076 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
4077 before checking whether buffer is modified. This lets
4078 `kill-buffer-query-functions' cancel killing of the buffer or save
4079 its content before `kill-buffer' asks user the "Buffer %s
4080 modified; kill anyway?" question.
4081
9d3f2fc2
JD
40822013-06-30 Jan Djärv <jan.h.d@swipnet.se>
4083
4084 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
4085 Let the super performKeyEquivalent deal with them (Bug#14747).
4086
e6c6c8c7
PE
40872013-06-30 Paul Eggert <eggert@cs.ucla.edu>
4088
1d71c1d9
PE
4089 * widget.c (resize_cb): Remove unused local.
4090
8f5f35cc
PE
4091 Do not use GTK 3 if it exists but cannot be compiled.
4092 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
4093 * xterm.c (x_error_handler) [!USE_GTK]:
4094 Do not use GTK 3.
4095
e6c6c8c7
PE
4096 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
4097
0ba54312
EZ
40982013-06-30 Eli Zaretskii <eliz@gnu.org>
4099
5d1c3286
EZ
4100 * intervals.c (get_local_map): Instead of aborting, clip POSITION
4101 to the valid range of values. (Bug#14753)
4102
0ba54312
EZ
4103 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
4104 when moving point by using the current glyph matrix. This avoids
4105 the need to force redisplay when this function is called in a
4106 loop.
4107
9c90cc06
PE
41082013-06-29 Paul Eggert <eggert@cs.ucla.edu>
4109
4110 Fix minor problems found by static checking.
4111 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
4112 Redo the latter's body to sidestep GCC parenthesization warnings.
4113 (setup_coding_system, detect_coding, detect_coding_system): Use them.
4114 * coding.c (detect_coding, detect_coding_system):
4115 * coding.h (struct undecided_spec):
4116 Use bool for boolean.
4117 * image.c (QCmax_width, QCmax_height): Now static.
4118 * xdisp.c (Fmove_point_visually): Remove unused local.
4119
4c672a0f
EZ
41202013-06-29 Eli Zaretskii <eliz@gnu.org>
4121
4122 * xdisp.c (Fmove_point_visually): New function.
4123
c1ea3abf
JB
41242013-06-28 Kenichi Handa <handa@gnu.org>
4125
4126 * coding.h (define_coding_undecided_arg_index): New enum.
4127 (coding_attr_index): New members
4128 coding_attr_undecided_inhibit_null_byte_detection,
4129 coding_attr_undecided_inhibit_iso_escape_detection,
4130 coding_attr_undecided_prefer_utf_8.
4131 (undecided_spec): New struct.
4132 (struct coding_system): New member `undecided' of the member
4133 `spec'.
4134
4135 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
4136 (detect_coding): Likewise.
4137 (detect_coding_system): Likewise.
4138 (Fdefine_coding_system_internal): New coding system properties
4139 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
4140 :prefer-utf-8.
4141 (syms_of_coding): Adjust for coding_arg_undecided_max.
4142
ba3de9e6
PE
41432013-06-28 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 * image.c (x_from_xcolors): Remove unused local.
4146
547c9269
YM
41472013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4148
4149 Defer image data transfer between X client and server until actual
4150 display happens.
4151
4152 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
4153 and `mask_img'.
4154
4155 * image.c (Destroy_Image): Remove.
4156 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
4157 `mask_p', and `colors_p'. All uses changed.
4158 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
4159 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
4160 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
4161 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
4162 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 4163 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
4164 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
4165 (image_get_x_image, image_unget_x_image): New functions or macros.
4166 (image_background, image_background_transparent, x_to_xcolors)
4167 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
4168 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
4169 instead of Destroy_Image.
4170 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
4171 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
4172 (png_load_body, jpeg_load_body, tiff_load, gif_load)
4173 (imagemagick_load_image, svg_load_image): Use them instead of
4174 x_create_x_image_and_pixmap, and x_put_x_image followed by
4175 x_destroy_x_image, respectively.
4176 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
4177 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
4178 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
4179 background_transparent fields.
4180 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
4181 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
4182
dae2f5ef
PE
41832013-06-27 Paul Eggert <eggert@cs.ucla.edu>
4184
4185 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
4186 This mostly consists of undoing recent changes.
4187 * callproc.c (Fcall_process):
4188 * process.c (create_process):
4189 Do not worry about catching SIGCHLD here, undoing previous change.
4190 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
4191 * process.c, process.h (catch_child_signal):
4192 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
4193 * process.c (catch_child_handler): Don't worry about being called
4194 lazily and do not assume caller has blocked SIGCHLD, undoing
4195 previous change. Move first-time stuff back to
4196 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
4197 tickle glib, as that causes Cygwin bootstrap to fail. Do not
4198 set lib_child_handler if it's already initialized, which may
4199 help avoid problems on GNUStep.
4200
fa55d2aa
PE
42012013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
4204 * callproc.c (Fcall_process):
4205 * process.c (create_process):
4206 Make sure SIGCHLD is caught before we fork,
4207 since Emacs startup no arranges to catch SIGCHLD.
4208 * process.c (lib_child_handler): Initialize to null, not to
4209 dummy_handler.
4210 (catch_child_signal): Allow self to be called lazily.
4211 Do nothing if it's already been called.
4212 Assume caller has blocked SIGCHLD (all callers do now).
4213 * emacs.c (main): Do not catch SIGCHLD here; defer it until
4214 just before it's really needed.
4215 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
4216 since it hasn't been caught yet.
4217
f3f9606c
LMI
42182013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
4219
4220 * image.c (compute_image_size): New function to implement
4221 :max-width and :max-height.
4222 (imagemagick_load_image): Use it.
4223
c7041908
PE
42242013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4225
4226 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
4227 * callproc.c, process.h (block_child_signal, unblock_child_signal):
4228 Now extern.
4229 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
4230 * process.c (catch_child_signal): Block SIGCHLD while futzing with
4231 the SIGCHLD handler, since the code is not atomic and (due to glib)
4232 signals may be arriving now.
4233 * sysdep.c (init_signals): Do not catch child signals here;
4234 'main' now does that later, at a safer time.
4235
f86852b4
PE
42362013-06-22 Paul Eggert <eggert@cs.ucla.edu>
4237
0dfeed58
PE
4238 Clean up SIGCHLD handling a bit (Bug#14569).
4239 * process.c, process.h (catch_child_signal):
4240 Now always extern, even if !NS_IMPL_GNUSTEP.
4241 * process.c (catch_child_signal): Move glib tickler here from
4242 init_process_emacs, so that it's done earlier in Emacs
4243 initialization. Also move the noninteractive && !initialized
4244 check here from init_process_emacs. This is all a bit cleaner for
4245 GNUish platforms, and I hope it works around the Cygwin bug.
4246 * sysdep.c (init_signals): Invoke catch_child_signal here, so
4247 that glib signal handling is tickled before glib creates threads.
4248
f86852b4
PE
4249 * process.c (wait_reading_process_output): Avoid int overflow
4250 when reading more than 2 GiB total from a process.
4251
cbd6509c
PE
42522013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4253
4254 * process.c (create_process): Handle a couple more cases,
4255 i.e., work even if new_argv and wait_child_setup[i] are cached.
4256 Use Fcall_process's style for volatile vars.
4257
9de1114a
AS
42582013-06-21 Andreas Schwab <schwab@linux-m68k.org>
4259
4260 * process.c (create_process): Mark PROCESS volatile.
4261
fbe9e0b9
PE
42622013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4263
4264 Use C99-style flexible array members if available.
4265 This avoids some subtle aliasing issues, which typically
4266 aren't a problem with GCC but may be a problem elsewhere.
4267 * alloc.c (sdata): New typedef, replacing the old struct sdata.
4268 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
4269 In either case, it uses a flexible array member rather than
4270 the old struct hack. All uses changed.
4271 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
4272 Adjust to sdata reorganization.
4273 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
4274 Use offsetof (struct, flex_array_member), not sizeof (struct), as
4275 that ports better to pre-C99 non-GCC.
4276 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
4277 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
4278 as the latter has changed.
4279 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
4280 and port better to pre-C99 GCC.
4281 * image.c (struct xpm_cached_color):
4282 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
4283 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
4284 Use FLEXIBLE_ARRAY_MEMBER.
4285 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
4286 Move decl to top level so it gets checked against implementation.
4287 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
4288 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
4289
1fc71008
PE
42902013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 * syntax.c: Integer cleanups.
4293 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
4294 All uses that need 0-or-2 changed to:
4295 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
4296 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
4297 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
4298 (char_quoted, prev_char_comend_first, back_comment)
4299 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4300 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
4301 Use bool for boolean.
4302 (update_syntax_table, skip_chars, skip_syntaxes):
4303 Prefer int to unsigned when either will do.
4304 (back_comment): Return boolean success flag, like forw_comment,
4305 instead of positive-or-minus-1 (which might have overflowed int anyway).
4306 Don't stuff ptrdiff_t into int.
4307 (syntax_spec_code, syntax_code_spec): Now const.
4308 (Fmatching_paren, scan_lists, scan_sexps_forward):
4309 Use enum syntaxcode for syntax code.
4310 (Fmatching_paren): Check that arg is a character, not just an integer.
4311 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
4312 (Finternal_describe_syntax_value): Omit no-longer-needed
4313 comparison to 0.
4314 (skip_chars): Use char, not unsigned char, when the distinction
4315 doesn't matter.
4316 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
4317 * bytecode.c (exec_byte_code):
4318 * syntax.c (syntax_spec_code, Fchar_syntax)
4319 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4320 (init_syntax_once):
4321 * syntax.h (SYNTAX_WITH_FLAGS):
4322 Omit unnecessary casts.
4323
b932cad7
EZ
43242013-06-20 Eli Zaretskii <eliz@gnu.org>
4325
4326 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
4327 line dimensions here, to avoid race conditions with the main
4328 thread. (Bug#14062, bug#14630, bug#14669)
4329
4330 * w32term.c (w32_draw_window_cursor): Compute the header line and
4331 mode line dimensions here.
4332 <w32_system_caret_window, w32_system_caret_hdr_height>:
4333 <w32_system_caret_mode_height>: New variables.
4334
4335 * w32term.h: Declare them.
4336
89561f72
PE
43372013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4338
5013fc08
PE
4339 * alloc.c (die): Move "assertion failed" string here ...
4340 * lisp.h (eassert): ... from here. Also, suppress evaluation of
4341 COND when SUPPRESS_CHECKING. This shrinks the executable text
4342 size by 0.8% to 2.2% when configured with --enable-checking,
4343 depending on optimization flags (GCC 4.8.1 x86-64).
4344
89561f72
PE
4345 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
4346
763a086d 43472013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
4348
4349 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4350 base is 2; this is more accurate.
4351
983aeb9a
JB
43522013-06-19 Juanma Barranquero <lekktu@gmail.com>
4353
4354 * sound.c (string_default): Move to !WINDOWSNT section.
4355 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4356
178ba3e6
PE
43572013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4358
bbc51b15
PE
4359 * sound.c: Integer cleanups.
4360 Remove unnecessary forward decls.
4361 (struct sound_device): The 'file' member is now a Lisp_Object, not
4362 a char *, so that we needn't invoke alloca on a huge size.
4363 (Fplay_sound_internal): Adjust to this.
4364 (string_default): New function.
4365 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4366 Use it to adjust to the struct sound_device change.
4367 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4368 (be2hs) [0]: Remove.
4369
178ba3e6
PE
4370 * syntax.c (skip_chars): Don't use uninitialized storage
4371 when searching a multibyte buffer for characters that are not in a
4372 unibyte string that contains non-ASCII characters.
4373
69f60cdc
JD
43742013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4375
4376 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4377 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4378
0d6224d4
PE
43792013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4380
4381 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4382
3c542890
KH
43832013-06-18 Kenichi Handa <handa@gnu.org>
4384
f7e3f7cd
KH
4385 * font.c (Ffont_spec): Signal an error for an invalid font name
4386 (Bug#14648).
3c542890 4387
9349e5f7
PE
43882013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4389
4390 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4391 In particular this ports to 32-bit sparc Sun cc.
4392 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4393 array with a dummy element at specpdl[-1], so that its address can
4394 be taken portably.
4395 (unbind_to): Do not copy the binding; not needed, now that we
4396 copy old_value in the one place where the copy is needed.
4397 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4398 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4399 (union specbinding): Rename from struct specbinding. Redo layout
4400 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4401 which is not portable. With Sun C 5.12 32-bit sparc, the
4402 declaration causes nargs to be an unsigned bitfield, a behavior
4403 that the C standard allows; but Emacs wants nargs to be signed.
4404 The overall type is now a union of structures rather than a
4405 structure of union of structures, and the 'kind' member is now a
4406 bitfield, so that the overall type doesn't grow. All uses changed.
4407 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4408
0a4df6a5
PE
44092013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4410
ec6ecaad
PE
4411 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4412 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4413
0a4df6a5
PE
4414 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4415
7bfe8dbc
EZ
44162013-06-17 Eli Zaretskii <eliz@gnu.org>
4417
4418 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4419 unless we know that the window w's frame is a frame object.
4420 Another attempt at solving bug#14062 and bug#14630.
4421
708e05f6
LMI
44222013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4423
4424 * textprop.c (property_set_type): New enum.
4425 (add_properties): Allow appending/prepending text properties.
4426 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4427 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4428 add_text_properties_1.
4429 (Fadd_face_text_property): New function that calls
4430 add_text_properties_1.
4431
84575e67
PE
44322013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4433
4434 Move functions from lisp.h to individual modules when possible.
4435 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4436 * alloc.c (XFLOAT_INIT, set_symbol_name):
4437 * buffer.c (CHECK_OVERLAY):
4438 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4439 (set_char_table_parent):
4440 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4441 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4442 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4443 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4444 (set_blv_valcell):
4445 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4446 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4447 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4448 (backtrace_args, backtrace_debug_on_exit):
4449 * floatfns.c (CHECK_FLOAT):
4450 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4451 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4452 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4453 (set_hash_index_slot):
4454 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4455 * marker.c (CHECK_MARKER):
4456 * textprop.c (CHECK_STRING_OR_BUFFER):
4457 * window.c (CHECK_WINDOW_CONFIGURATION):
4458 Move here from lisp.h, and make these functions static rather than
4459 extern inline.
4460 * buffer.c (Qoverlayp):
4461 * data.c (Qsubrp):
4462 * fns.c (Qhash_table_p):
4463 * window.c (Qwindow_configuration_p):
4464 Now static.
4465 * lisp.h: Remove the abovementioned defns and decls.
4466
44e18199 4467 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4468 In lisp.h, prefer functions to function-like macros, and
4469 constants to object-like macros, when either will do. This:
4470 . simplifies use, as there's no more need to worry about
4471 arguments' side effects being evaluated multiple times.
4472 . makes the code easier to debug on some platforms.
4473 However, when using gcc -O0, keep using function-like macros
4474 for a few critical operations, for performance reasons.
4475 This sort of thing isn't needed with gcc -Og, but -Og
4476 is a GCC 4.8 feature and isn't widely-enough available yet.
4477 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4478 Remove enum lsb_bits; no longer needed.
4479 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4480 * buffer.c (Qoverlap):
4481 * data.c (Qsubrp):
4482 * fns.c (Qhash_table_p):
4483 Now extern, so lisp.h can use these symbols.
4484 * dispextern.h: Include character.h, for MAX_CHAR etc.
4485 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4486 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4487 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4488 (GLYPH_CODE_P): Move here from lisp.h.
4489 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4490 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4491 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4492 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4493 XUNTAG now returns void *.
4494 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4495 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4496 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4497 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4498 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4499 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4500 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4501 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4502 New macros, renamed from their sans-lisp_h_ counterparts.
4503 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4504 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4505 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4506 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4507 If compiling via GCC without optimization, define these as macros
4508 in addition to inline functions.
4509 To disable this, compile with -DINLINING=0.
4510 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4511 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4512 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4513 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4514 (INTMASK, VALMASK): Now macros, since static values cannot be
4515 accessed from extern inline functions.
4516 (VALMASK): Also a constant, for benefit of old GDB.
4517 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4518 is INTEGERP, which can fold it in.
5165d44a 4519 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4520 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4521 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4522 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4523 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4524 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4525 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4526 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4527 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4528 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4529 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4530 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4531 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4532 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4533 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4534 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4535 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4536 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4537 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4538 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4539 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4540 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4541 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4542 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4543 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4544 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4545 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4546 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4547 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4548 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4549 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4550 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4551 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4552 Now functions.
4553 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4554 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4555 (VALMASK): Define in one place rather than in two, merging the
4556 USE_LSB_TAG parts; this is simpler.
4557 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4558 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4559 Move up, to avoid use before definition.
4560 Also include "globals.h" earlier, for the same reason.
4561 (make_natnum): New function.
4562 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4563 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4564 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4565 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4566 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4567 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4568 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4569 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4570 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4571 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4572 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4573 (Qwindow_configuration_p, Qimage): New forward declarations.
4574 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4575 (STRING_COPYIN): Remove; unused.
4576 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4577 (xcar_addr, xcdr_addr): New functions. All uses changed.
4578 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4579 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4580 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4581 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4582 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4583 (TYPE_RANGED_INTEGERP): Simplify.
4584 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4585 (setlocale, fixup_locale, synchronize_system_messages_locale)
4586 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4587 Now empty functions, not macros.
4588 (functionp): Return bool, not int.
4589 * window.c (Qwindow_configuration_p): Now extern,
4590 so window.h can use it.
4591 * window.h (Qwindowp): Move decl back to lisp.h.
4592
9583ec36
EZ
45932013-06-15 Eli Zaretskii <eliz@gnu.org>
4594
4595 * xdisp.c (Fline_pixel_height): New function, required for solving
4596 bug #14567.
4597
210272ce
PE
45982013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4601
de0503df
SM
46022013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4603
4604 * lread.c (syms_of_lread):
4605 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4606
afbfe143
KD
46072013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4608
4609 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4610
d177e213
XF
46112013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4612
4613 * fileio.c (expand_file_name): Doc fix.
4614
05e3e412
PE
46152013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4616
f7394b12
PE
4617 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4618 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4619 Wait for self, not for 0. This can't hurt on GNU or similar
4620 system, and may help with Cygwin.
4621
05e3e412
PE
4622 * keyboard.c: Don't use PROP (...) as an lvalue.
4623 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4624 Use set_prop (A, B), not PROP (A) = B.
4625
17dd3097
EZ
46262013-06-10 Eli Zaretskii <eliz@gnu.org>
4627
4628 * xdisp.c (get_it_property): Use it->window instead of generating
4629 a Lisp object from it->w.
4630
52fab9c9
EZ
46312013-06-09 Eli Zaretskii <eliz@gnu.org>
4632
4633 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4634 get-char-property the window that is being rendered, instead of
4635 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4636 (compute_display_string_pos): When W is NULL, use the current
4637 buffer as the object to pass to get-char-property.
4638 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4639 pointer member of the bidi iterator, since no window is pertinent
4640 to this function.
52fab9c9 4641
5bf97bfc
EZ
46422013-06-08 Eli Zaretskii <eliz@gnu.org>
4643
4644 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4645 being displayed, and pass it to compute_display_string_pos.
4646 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4647 (bidi_paragraph_init): All callers changed.
4648
4649 * xdisp.c (init_from_display_pos, init_iterator)
4650 (handle_single_display_spec, next_overlay_string)
4651 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4652 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4653 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4654 (compute_display_string_pos): Accept additional argument, the
4655 window being displayed, and pass it to Fget_char_property.
4656 (Bug#14575)
4657
4658 * dispextern.h (struct bidi_it): New member w, the window being
4659 displayed.
4660 (compute_display_string_pos): Adjust prototype.
4661
5de0e011
JD
46622013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4663
e7b41c4c 4664 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4665
4666 * process.c (wait_reading_process_output): Check for NS before GLIB.
4667 GLIB may be linked in due to rsvg, but ns_select must be called.
4668
5de0e011
JD
4669 * xgselect.c (xg_select): Remove call to window_system_available
4670 and g_main_context_pending at the top, so Gdk events (i.e. file
4671 notify) are processed when Emacs is started with -nw.
4672
a822acff
EZ
46732013-06-07 Eli Zaretskii <eliz@gnu.org>
4674
4675 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4676 (ctagsfiles3): New variable, includes only *.m files.
4677 (TAGS): Use an explicit language name in the regular expressions,
4678 to avoid transformation of '/SOMETHING' by MSYS to
4679 'c:\MSYS\SOMETHING'.
4680
6c0a9ed1
RC
46812013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4682
4683 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4684
9ef6111b
EZ
46852013-06-06 Eli Zaretskii <eliz@gnu.org>
4686
4687 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4688 still need to set the mouse pointer shape and activate help-echo.
4689 (Bug#14558)
4690
7d300d64
PE
46912013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 A few porting etc. fixes for the new file monitor code.
4694 See the thread containing
4695 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4696 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4697 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4698 (dir_monitor_callback, Fgfile_rm_watch):
4699 Use assq_no_quit instead of Fassoc, for speed.
4700 (dir_monitor_callback, Fgfile_rm_watch):
4701 eassert that the monitor is a fixnum.
4702 (dir_monitor_callback): No need for CDR_SAFE.
4703 Simplify building of lisp with alternative tails.
4704 (Fgfile_add_watch, Fgfile_rm_watch):
4705 Do not assume glib functions set errno reliably on failure.
4706 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4707 and signal an error otherwise.
4708 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4709 Use Fdelq instead of Fdelete, for speed.
4710
817ebfcf
EZ
47112013-06-05 Eli Zaretskii <eliz@gnu.org>
4712
4713 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4714 don't insist on being invoked on a highlighted tool-bar button.
4715 Avoids losing tool-bar functionality when mouse-highlight is nil.
4716 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4717 Don't highlight when mouse-highlight is nil.
4718 (note_mouse_highlight): When mouse-highlight is nil, don't return
4719 right away; instead, run tool-bar and mode-line highlight
4720 subroutine, clear any existing highlight, and revert the mouse
4721 pointer to its default shape. (Bug#14558)
4722
55577e7c
SM
47232013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4724
4725 * lisp.mk (lisp): Add prog-mode.el.
4726
f019a684
PE
47272013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4728
4729 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4730 * process.c (dummy_handler): New function.
4731 (lib_child_handler): New static var.
4732 (handle_child_signal): Invoke it.
4733 (catch_child_signal): If a library has set up a signal handler,
4734 save it into lib_child_handler.
4735 (init_process_emacs): If using glib and not on Windows, tickle glib's
4736 child-handling code so that it initializes its private SIGCHLD handler.
4737 * syssignal.h (SA_SIGINFO): Default to 0.
4738 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4739 31; it should no longer be needed now.
4740
90db8702
MA
47412013-06-05 Michael Albinus <michael.albinus@gmx.de>
4742
4743 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4744
4745 * gfilenotify.c (globals_of_gfilenotify): New function.
4746 (syms_of_gfilenotify): Move global initialization there.
4747
4748 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4749
bfa3acd6
SM
47502013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4751
4752 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4753 * keyboard.c (menu_bar_items, tool_bar_items):
4754 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4755 not override local keymaps any more.
4756
ba59bd80
EZ
47572013-06-04 Eli Zaretskii <eliz@gnu.org>
4758
4759 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4760
7f203aa1
EZ
47612013-06-03 Eli Zaretskii <eliz@gnu.org>
4762
9337e206
EZ
4763 * w32console.c (initialize_w32_display): Return the dimensions of
4764 the console window via 2 additional arguments, not via the current
4765 frame. This avoids crashes due to overrunning the bounds of
4766 frame's decode_mode_spec_buffer, which is not resized following
4767 the change of the frame dimensions from the initial 10x10.
4768
4769 * w32term.h (w32_initialize_display_info): Adjust prototype.
4770
4771 * term.c (init_tty): Take dimensions of the frame from the values
4772 returned by initialize_w32_display.
4773
7f203aa1
EZ
4774 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4775 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4776 (LIBES): Add $(GFILENOTIFY_LIBS).
4777
4778 * w32inevt.c (handle_file_notifications): Add dummy implementation
4779 for !HAVE_W32NOTIFY.
4780
4781 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4782
55a87246
JD
47832013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4784
4785 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4786
4787 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4788
4789 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4790
3d5ee10a
PE
47912013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 Fix minor problems found by static checking.
4794 * data.c (pure_write_error):
4795 Use xsignal2, not Fsignal, as Fsignal might return.
4796 * eval.c (set_backtrace_debug_on_exit): Now static.
4797 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4798 No longer inline. EXTERN_INLINE is needed only for functions
4799 defined in .h files. Reindent function header as per GNU style.
4800 (backtrace_p, backtrace_top, backtrace_next):
4801 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4802 compiler or linker. Add extern decls to pacify gcc -Wall.
4803 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4804 Now static.
4805 * frame.c (free_monitors): Define only on platforms that need it.
4806 * nsterm.m (ns_term_init):
4807 * process.c (catch_child_signal):
4808 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4809 defined on all porting targets these days.
4810 * process.c, process.h (catch_child_signal):
4811 Make it extern only if NS_IMPL_GNUSTEP is defined.
4812
e2d8a6f0
EZ
48132013-06-03 Eli Zaretskii <eliz@gnu.org>
4814
4815 * w32.c (gettimeofday): Make the signature identical to prototype
4816 in nt/inc/sys/time.h.
4817
a8a7c5f6
SM
48182013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4819
4820 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4821 .gdbinit.
4822
4823 * keyboard.c (safe_run_hooks_error): Improve error message.
4824
4825 * data.c (pure_write_error): Add `object' argument.
4826 * puresize.h (CHECK_IMPURE): Use it.
4827
c9628c79
MA
48282013-06-03 Michael Albinus <michael.albinus@gmx.de>
4829
4830 * Makefile.in (NOTIFY_OBJ): New variable.
4831 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4832
4833 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4834 Call syms_of_gfilenotify.
4835
4836 * gfilenotify.c: New file.
4837
4838 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4839 and Qfile_w32notify.
4840 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4841 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4842
4843 * lisp.h: Declare syms_of_gfilenotify.
4844
4845 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4846
2f592f95
SM
48472013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4848
4849 Merge the specpdl and backtrace stacks. Make the structure of the
4850 specpdl entries more obvious via a tagged union of structs.
4851 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4852 (enum specbind_tag): New enum.
4853 (struct specbinding): Make it a tagged union of structs.
4854 Add a case for backtrace records.
4855 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4856 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4857 (backtrace_debug_on_exit): New accessors.
4858 (struct backtrace): Remove.
4859 (struct catchtag): Remove backlist field.
4860 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4861 Move to eval.c.
4862 (Flocal_variable_p): Speed up the common case where the binding is
4863 already loaded.
4864 * eval.c (backtrace_list): Remove.
4865 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4866 (set_backtrace_args, set_backtrace_nargs)
4867 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4868 (backtrace_next): New functions.
4869 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4870 (unwind_to_catch, internal_lisp_condition_case)
4871 (internal_condition_case, internal_condition_case_1)
4872 (internal_condition_case_2, internal_condition_case_n): Don't bother
4873 with backtrace_list any more.
4874 (Fsignal): Adjust to new backtrace format.
4875 (grow_specpdl): Move up.
4876 (record_in_backtrace): New function.
4877 (eval_sub, Ffuncall): Use it.
4878 (apply_lambda): Adjust to new backtrace format.
4879 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4880 data.c.
4881 (specbind): Adjust to new specpdl format. Simplify.
4882 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4883 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4884 backtrace format.
4885 (mark_backtrace): Remove.
4886 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4887 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4888 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4889 Use mark_specpdl.
4890 * profiler.c (record_backtrace): Use get_backtrace.
4891 (handle_profiler_signal): Use backtrace_top_function.
4892 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4893 accessor functions.
4894
c0342369
JD
48952013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4896
4897 * process.h (catch_child_signal): Declare.
4898
4899 * process.c (catch_child_signal): New function.
4900 (init_process_emacs): Call it.
4901
4902 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4903 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4904 NS_IMPL_COCOA.
4905 (x_set_cursor_type): Remove declaration.
4906 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4907 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4908 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4909 (ns_get_color): Use F suffix on float.
4910 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4911 (ns_get_rgb_color): Remove.
4912 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4913 (note_mouse_movement): x and y are CGFloat.
4914 (ns_draw_fringe_bitmap): Remove unused rowY.
4915 Change #if to COCOA && >= 10_6.
4916 (ns_draw_window_cursor): Remove unused overspill.
4917 (ns_draw_underwave): width and x are EamcsCGFloat.
4918 (ns_draw_box): thickness is CGFloat.
4919 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4920 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4921 if not in main thread.
4922 (ns_get_pending_menu_title, ns_check_menu_open)
4923 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4924 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4925 (sendFromMainThread:): New method.
4926 (changeFont:): size is CGFloat.
4927 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4928 Disable warning about permanent text.
4929 (characterIndexForPoint:): Adjust return type depending on GNUStep
4930 version.
4931 (mouseDown:): delta is CGFloat.
4932 (updateFrameSize): Remove unised variable f.
4933 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4934 Cast float to EmacsCGFloat.
4935 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4936 also to -1 when restoring.
4937 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4938 inside NS_IMPL_COCOA.
4939 (toggleFullScreen:): Put call to toggleFullScreen inside
4940 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4941 (setPosition:portion:whole:): por is CGFloat.
4942 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4943 (mouseDown:): Use CGFloat.
4944 (mouseDragged:): Remove unised variable edge.
4945 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4946
4947 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4948 of CGFloat differs.
4949 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4950 when NS_IMPL_GNUSTEP.
4951 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4952 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4953 (EmacsToolbar): Add clearAll. Add tag argument to
4954 addDisplayItemWithImage.
4955 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4956
4957 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4958
4959 * nsmenu.m (ns_update_menubar): Make static.
4960 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4961 (fillWithWidgetValue:): Add cast to SEL for setAction.
4962 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4963 (update_frame_tool_bar): Update code for GNUStep.
4964 (clearAll): New method.
4965 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4966 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4967 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4968 call to insertItemWithItemIdentifier.
4969 (validateVisibleItems): Fix indentation.
4970 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4971 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4972 UtilityWindow to aStyle, remove call to setStyleMask.
4973
4974 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4975
4976 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4977 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4978 Use F suffix on floats.
4979 (ns_char_width): Returns CGFloat.
4980 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4981 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4982 DPSxshow.
4983 (ns_glyph_metrics): CGFloat instead of float.
4984
a0eb10b3
JB
4985 * nsfns.m (x_set_foreground_color, x_set_background_color):
4986 Use EmacsCGFloat.
4987 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4988 remove unused variables.
4989 (Fns_read_file_name): Keep track if panel is for save.
4990 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4991 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4992 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4993 Just return the input if GNUStep.
c0342369
JD
4994 (x_screen_planes): Remove.
4995 (Fxw_color_values): Use EmacsCGFloat
4996 (Fns_display_monitor_attributes_list): Only get screen number for
4997 Cocoa.
ef099a94 4998 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4999 EmacsSavePanel.
5000 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
5001 ns_directory_from_panel.
5002
da9aff11
PE
50032013-06-01 Paul Eggert <eggert@cs.ucla.edu>
5004
5005 * process.c (handle_child_signal): Also use WCONTINUED.
5006 This is so that list-processes doesn't mistakenly list the process
5007 as stopped, when the process has actually been continued and is
5008 now running.
5009
0e64479a
PE
50102013-05-31 Paul Eggert <eggert@cs.ucla.edu>
5011
fc186a96
PE
5012 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
5013 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
5014 not already configured.
5015
0e64479a
PE
5016 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
5017
38b787fa
EZ
50182013-05-29 Eli Zaretskii <eliz@gnu.org>
5019
5020 * Makefile.in (mostlyclean): Remove *.res files.
5021
22513e52
SM
50222013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
5023
5024 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
5025 a buffer (bug#8447).
5026
6ef3db10
EZ
50272013-05-27 Eli Zaretskii <eliz@gnu.org>
5028
5029 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
5030 display vector, and we backtrack, handle the case that the
5031 previous character position is also displayed from a display
5032 vector or covered by a display string or image. (Bug#14476)
5033
6799bb26
JD
50342013-05-25 Jan Djärv <jan.h.d@swipnet.se>
5035
5036 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
5037 (struct MonitorInfo, free_monitors): Remove.
5038 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
5039 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
5040 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5041 Qframes, Qsource.
5042
5043 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
5044 (struct MonitorInfo, free_monitors): Remove.
5045 (ns_screen_name): Make static.
5046 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
5047 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5048 Qframes, Qsource.
5049
5050 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5051 (struct MonitorInfo): New struct.
5052 (free_monitors, make_monitor_attribute_list): Declare.
5053
22513e52
SM
5054 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
5055 New Lisp_Object:s.
6799bb26
JD
5056 (free_monitors, make_monitor_attribute_list): New functions.
5057 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
5058 Qsource.
5059
38cd43eb
XF
50602013-05-25 Xue Fuqiao <xfq.free@gmail.com>
5061
5062 * callproc.c (call_process): Refine the doc string. (Bug#14045)
5063
2af0948d
SM
50642013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
5065
a7eb9b0f
SM
5066 * keyboard.c: Apply keyboard decoding only to events that come directly
5067 from the tty, not from unread-command-events (bug#14368).
5068 (read_event_from_main_queue): New function, extracted from read_char).
5069 (read_decoded_char): Remove.
5070 (read_decoded_event_from_main_queue): New function to replace it.
5071 (read_char): Use it.
5072 (read_key_sequence): Use read_char rather than read_decoded_char.
5073
2af0948d
SM
5074 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
5075
1413e9a5
BR
50762013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
5077
5078 * casetab.c (init_casetab_once): Fix last change (bug#14424).
5079
e6d2f155
KH
50802013-05-22 Kenichi Handa <handa@gnu.org>
5081
5082 The following changes are to fix the setting of
5083 buffer-file-coding-system on, for instance, C-x RET c unix RET
5084 _FILE_OF_DOS_EOL_TYPE_ RET.
5085
5086 * coding.h (struct coding_system): New member detected_utf8_chars.
5087
5088 * coding.c (detect_coding_utf_8): Count characters and check EOL
5089 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
5090 BOM is there.
5091 (setup_coding_system): Do not initialize coding->head_ascii.
5092 (check_ascii): Do not set coding->eol_seen but update it. Do not
5093 call adjust_coding_eol_type here.
1413e9a5
BR
5094 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
5095 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
5096 of the found coding-system.
5097 (decode_coding_gap): Cancel previous change. Utilize the
5098 character numbers counted by detect_coding_utf_8. Fix detection
5099 of BOM for utf-8.
5100
ab56a6f4 51012013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
5102
5103 * search.c (looking_at_1): Only set last_thing_searched if the match
5104 changed the match-data (bug#14281).
5105
ecc3c6ed
DA
51062013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
5107
5108 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 5109 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
5110 (move_it_vertically_backward): Likewise.
5111
5ba8bf35
YM
51122013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5113
5114 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 5115 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
5116 (Fx_display_mm_width, Fx_display_mm_height):
5117 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 5118
91e8418b 5119 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 5120 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
5121 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
5122 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
5123 (Fx_display_backing_store, Fx_display_visual_class)
5124 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
5125 (Fx_display_grayscale_p, Fx_display_pixel_width)
5126 (Fx_display_pixel_height, Fx_display_planes)
5127 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
5128 (Fx_display_screens): Don't confuse X11 screens with NS screens.
5129 (Fx_display_mm_width, Fx_display_mm_height)
5130 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
5131 height for all physical monitors as in X11.
5132
fc30d803
SM
5133 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
5134 Return pixel width or height for all physical monitors as in X11.
91e8418b 5135
31ff141c
PE
51362013-05-18 Paul Eggert <eggert@cs.ucla.edu>
5137
5138 Port --enable-gcc-warnings to clang.
5139 * bytecode.c (exec_byte_code):
5140 * regex.c:
5141 Redo diagnostic pragmas to pacify clang, too.
5142 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
5143 * editfns.c (Fencode_time):
5144 * fileio.c (file_accessible_directory_p):
5145 * font.c (font_unparse_xlfd):
5146 Use '&"string"[index]' instead of '"string" + (index)'.
5147 * undo.c (user_error): Remove; unused.
5148
df065a0b
EZ
51492013-05-16 Eli Zaretskii <eliz@gnu.org>
5150
04d360e7
EZ
5151 * insdel.c (insert_1_both): Document the arguments, instead of
5152 referring to insert_1, which no longer exists.
5153
5bb98290
EZ
5154 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
5155 some window, increment windows_or_buffers_changed, so that
5156 *Messages* display in that window is updated. (Bug#14408)
5157
df065a0b
EZ
5158 * w32.c: Include epaths.h.
5159 (init_environment): Use cmdproxy.exe without leading directories.
5160 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
5161 case.
5162 (gettimeofday): Adjust signature and return value to Posix
5163 expectations.
5164
5165 * unexw32.c (open_output_file): Delete the existing emacs.exe
5166 before creating it, to break the hard link to the versioned
5167 executable.
5168
5169 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
5170 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
5171 (FIRSTFILE_OBJ): New variables.
5172 (W32_RES): Rename to EMACSRES. All users changed.
5173 (base_obj): Use $(CM_OBJ).
5174 (ALLOBJS): Use $(FIRSTFILE_OBJ).
5175 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
5176 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
5177 $(W32_RES_LINK) before $(LIBES).
5178 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
5179
1aa8d505
SM
51802013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5181
6e911150
SM
5182 * makefile.w32-in (DOC): Use just "DOC".
5183
5184 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
5185
1aa8d505
SM
5186 * process.c: Export default filters and sentinels to Elisp.
5187 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
5188 New constants.
5189 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
5190 (Fset_process_sentinel, Fformat_network_address):
5191 Default to them instead of nil.
5192 (server_accept_connection): Sentinels can't be nil any more.
5193 (read_and_dispose_of_process_output): New function, extracted from
5194 read_process_output.
5195 (read_process_output): Use it; filters can't be nil.
5196 (Finternal_default_process_filter): New function, extracted from
5197 read_process_output.
5198 (exec_sentinel_unwind): Remove function.
5199 (exec_sentinel): Don't zilch sentinel while running.
5200 (status_notify): Sentinels can't be nil.
5201 (Finternal_default_process_sentinel): New function extracted from
5202 status_notify.
5203 (setup_process_coding_systems): Default filter is not nil any more.
5204 (syms_of_process): Export new Elisp functions and initialize
5205 new constants.
5206 * lisp.h (make_lisp_proc): New function.
5207
5ac2eb34
SM
52082013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5209
5210 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
5211
eda9c7d7
EZ
52122013-05-14 Eli Zaretskii <eliz@gnu.org>
5213
5214 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
5215 unless we know that the window w is a leaf window.
5216 Another attempt at solving bug#14062.
eda9c7d7 5217
8fdeaad5
JD
52182013-05-14 Jan Djärv <jan.h.d@swipnet.se>
5219
5220 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
5221 fdesc (Bug#14375).
5222
44aa9ee6
PE
52232013-05-12 Paul Eggert <eggert@cs.ucla.edu>
5224
5225 * image.c (gif_load): Check that subimages fit (Bug#14345).
5226
759fd763
SM
52272013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
5228
5229 * lread.c (skip_dyn_eof): New function.
5230 (read1): Use it to skip the end of a file in response to #@00.
5231
5232 * doc.c (get_doc_string): Slightly relax the sanity checking.
5233
4465bfb4
JD
52342013-05-09 Jan Djärv <jan.h.d@swipnet.se>
5235
5236 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
5237 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5238 (MonitorInfo): New struct.
5239 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
5240 (Fns_display_monitor_attributes_list): New functions.
5241 (display-usable-bounds): Remove.
5242 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
5243 Qsource.
5244
7583e2a0
PE
52452013-05-09 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
5248 (GTK_CHECK_VERSION): New macro, if not already defined.
5249 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
5250 replaced by GTK_CHECK_VERSION.
5251
ad75d77e
PE
52522013-05-08 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 * xterm.h (GTK_PREREQ): New macro.
5255 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
5256 to use this macro instead, for consistency and clarity.
5257
07525f77
EZ
52582013-05-08 Eli Zaretskii <eliz@gnu.org>
5259
5260 * xdisp.c (row_for_charpos_p): New function, with code of
5261 cursor_row_p, but accepts an additional argument CHARPOS instead
5262 of using a hardcoded PT.
5263 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
5264 (row_containing_pos): Call row_for_charpos_p instead of partially
5265 doing the same. Fixes cursor positioning under longlines-mode
5266 when longlines-show-effect includes more than one newline, when
5267 moving the cursor vertically up.
5268
d901fc8d
JB
52692013-05-08 Juanma Barranquero <lekktu@gmail.com>
5270
5271 * makefile.w32-in (ACL_H): New macro.
5272 ($(BLD)/fileio.$(O)): Update dependencies.
5273
f269bc61
PE
52742013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5275
e7b41c4c 5276 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
5277 * Makefile.in (LIB_ACL): New macro.
5278 (LIBACL_LIBS): Remove.
5279 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
5280 * fileio.c: Include <acl.h>.
5281 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
5282 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
5283 !acl_errno_valid.
5284 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
5285 it ourselves.
5286
f269bc61
PE
5287 * unexelf.c: Don't assume ElfW (Half) fits in int.
5288 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
5289 when dealing with ElfW (Half) values, since they can exceed 2**31
5290 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
5291 (entry_address): Omit unused NUM arg. All uses changed.
5292
a261c53e
JL
52932013-05-07 Juri Linkov <juri@jurta.org>
5294
5295 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
5296 to the string converted from number with `Fnumber_to_string'.
5297 (Bug#14254)
5298
2b66427d
PE
52992013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5300
5301 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
5302 This fixes a problem introduced by my previous change.
5303
15acfe41
GM
53042013-05-07 Glenn Morris <rgm@gnu.org>
5305
5306 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
5307
5ea03bf5
JD
53082013-05-07 Jan Djärv <jan.h.d@swipnet.se>
5309
5310 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
5311
e0c9d565
PE
53122013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5313
5314 Static checking by GCC 4.8.0.
5315 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
5316 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
5317 (x_get_monitor_attributes_fallback)
5318 (x_get_monitor_attributes_xinerama)
5319 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
5320 Define only if USE_GTK.
5321 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
5322 (x_get_monitor_attributes_fallback): Omit unused locals.
5323 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
5324 Use double, not float, to avoid mixed-mode floating point arithmetic.
5325
4e3f9230
YM
53262013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5327 Jan Djärv <jan.h.d@swipnet.se>
5328
5329 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
5330 (XINERAMA_CFLAGS): New macros.
5331 (ALL_CFLAGS, LIBES): Use them.
5332
5333 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
5334 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
5335 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
5336 (syms_of_xfns): DEFSYM them.
5337 (struct MonitorInfo): New struct.
5338 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
5339 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
5340 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
5341 (x_get_monitor_attributes_xinerama): New functions.
5342 (Fx_display_monitor_attributes_list): New primitive.
5343 (syms_of_xfns): Defsubr it.
5344
5345 * xterm.h (x_display_info): Add Xatom_net_workarea and
5346 Xatom_net_current_desktop.
5347
5348 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5349 and dpyinfo->Xatom_net_current_desktop.
5350
05839b6a
EZ
53512013-05-06 Eli Zaretskii <eliz@gnu.org>
5352
5353 * xdisp.c (pos_visible_p): Use the special code for finding the
5354 beginning of a display property or overlay for any "replacing"
5355 display property, not just for display strings. This solves
5356 incorrect reporting of position by posn-at-point. (Bug#14241)
5357
dc4a2ee0
PE
53582013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5359
5ee94506
PE
5360 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5361 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5362 Verify that ElfW (Half) fits in int.
5363 (fatal): Use same signature as lisp.h.
5364 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5365 configure and build with -DUNEXELF_DEBUG without worrying about
5366 other modules that use DEBUG.
5367 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5368 possibly-wide integers now uses it instead of plain fprintf.
5369 (entry_address): New function, which avoids problems with 32-bit
5370 overflow on 64-bit hosts.
5371 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5372 (round_up): Don't assume the remainder fits in int.
5373 (find_section): Use bool for boolean. Simplify debug code.
5374 (unexec): Don't assume file sizes fit in int or size_t.
5375 Omit unnecessary trailing newline in 'fatal' format.
5376 Use strerror rather than outputting decimal error number.
5377 Remove unused code when emacs is not defined;
5378 this file relies on Emacs now.
5379 Don't assume e_phnum and e_shnum are positive.
5380
dc4a2ee0
PE
5381 * regex.c: Fix problems when DEBUG is defined.
5382 (extract_number, extract_number_and_incr): Define regardless of
5383 whether DEBUG is defined; that's simpler and makes the code less
5384 likely to go stale in the normal case when DEBUG is not defined.
5385 Return int rather than taking an int * arg. All callers changed.
5386 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5387 Remove, replacing with ...
5388 (DEBUG_PRINT): New macro. All callers changed.
5389 (DEBUG_COMPILES_ARGUMENTS): New macro.
5390 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5391 (print_compiled_pattern, print_double_string) [DEBUG]:
5392 Use prototype rather than old-style definition.
5393 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5394 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5395 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5396 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5397 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5398 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5399 This matters only when DEBUG is defined.
5400
14c7ed05
EZ
54012013-05-05 Eli Zaretskii <eliz@gnu.org>
5402
5403 * xdisp.c (set_iterator_to_next): Set the
5404 ignore_overlay_strings_at_pos_p flag only if we are _really_
5405 iterating over an overlay string, as indicated by the
5406 current.overlay_string_index member. (Bug#14306)
5407
e6076b1b
JD
54082013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5409
5410 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5411 to where it is used, to avoid autorelease issues (Bug#14050).
5412
cbee2131
PE
54132013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5414
5415 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5416 * fileio.c (syms_of_fileio): Implement this.
5417 * filelock.c (create_lock_file): If symbolic links don't work, so
5418 we use a regular file as a lock file, do not fsync the lock file;
5419 it's not needed.
5420
30c7e542
SM
54212013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5422
5423 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5424 (syms_of_minibuf): Adjust accodingly.
5425 * lread.c (Fread):
5426 * callint.c (Fcall_interactively): Adjust calls accordingly.
5427
5bebd186
EZ
54282013-05-04 Eli Zaretskii <eliz@gnu.org>
5429
5430 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5431 w->contents is a buffer before computing everything else.
5432 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5433
5434 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5435 assertion violations. (Bug#14062)
5436
0fb0a4f3
DR
54372013-05-01 David Reitter <david.reitter@gmail.com>
5438
5439 * nsfns.m (ns_tooltip): Initialize.
5440
9e63b4a5
EZ
54412013-04-28 Eli Zaretskii <eliz@gnu.org>
5442
5443 * coding.c (decode_coding_gap): Don't remove the character before
5444 a newline unless it's a CR character. (Bug#14287)
5445
ad60824e
DN
54462013-04-28 Dan Nicolaescu <dann@gnu.org>
5447
5448 * dispextern.h (struct face): Move enum face_underline_type
5449 earlier so that bitfields can be in the same word.
5450
edbdcec0
JD
54512013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5452
5453 * nsfns.m (handlePanelKeys): New function.
5454 (EmacsOpenPanel:performKeyEquivalent:)
5455 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5456 arrows/function/control and copy/paste keys (Bug#14296).
5457
0208ede7
JL
54582013-04-27 Juri Linkov <juri@jurta.org>
5459
5460 * callint.c (Fcall_interactively): Call `Qread_number' for
5461 interactive code letter `n' instead of using duplicate code.
5462 (Bug#14254)
5463
b8dd59f7
PE
54642013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5465
5466 * systime.h (make_timeval): Declare as 'const'.
5467
8bd722db
KH
54682013-04-27 Kenichi Handa <handa@gnu.org>
5469
5470 * font.c (font_open_entity): Always open a font of manageable
5471 size.
5472
13d0e56f 54732013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5474
f780d632
PE
5475 Port better to AIX (Bug#14258).
5476 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5477 to pacify AIX xlc.
5478
ec509856
KH
54792013-04-24 Kenichi Handa <handa@gnu.org>
5480
5481 * coding.c (decode_coding_iso_2022): When an invalid escape
5482 sequence is encountered, reset the invocation and designation
5483 status to the safest one.
5484
84fc48e5
PE
54852013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5486
5487 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5488 Without this fix, "make distclean" leaves stamp-h1 behind.
5489
806bda47
EC
54902013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5491
5492 * w32fns.c (w32_fullscreen_rect): New function to compute the
5493 window rectangle for the given fullscreen mode.
5494 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5495 longer tunes the window size. This keeps the window's edges flush
5496 with the screen and allows the taskbar to hide itself in fullboth.
5497
5498 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5499 window decorations and uses the entire screen.
5500
5501 * w32term.h (w32_fullscreen_rect) Add prototype.
5502 (struct w32_output): Replace normal_width, normal_height,
5503 normal_top, and normal_left members with a single normal_placement
5504 struct.
5505 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5506 Remove macros.
5507 (FRAME_NORMAL_PLACEMENT): New macro.
5508
9cc2810b
JB
55092013-04-16 Juanma Barranquero <lekktu@gmail.com>
5510
5511 * minibuf.c (Ftest_completion): Silence compiler warning.
5512
fd16b54c
EZ
55132013-04-15 Eli Zaretskii <eliz@gnu.org>
5514
5515 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5516 bug#14062.
fd16b54c
EZ
5517
5518 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5519 parentheses.
5520
5521 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5522 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5523 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5524 parentheses where appropriate.
5525
9e3379a0
PE
55262013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5527
5528 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5529
ddd6b685
EZ
55302013-04-14 Eli Zaretskii <eliz@gnu.org>
5531
5532 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5533 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5534 Mention in the doc string that setting these variables takes
5535 effect only after a call to set-window-buffer. (Bug#14200)
5536
29b79ba1
EZ
55372013-04-13 Eli Zaretskii <eliz@gnu.org>
5538
5539 * indent.c (Fvertical_motion): Don't consider display strings on
5540 overlay strings as display strings on the buffer position we
5541 started from. This prevents vertical cursor motion from jumping
5542 more than one line when there's an overlay string with a display
5543 property at end of line.
5544 Reported by Karl Chen <Karl.Chen@quarl.org> in
5545 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5546
562c6ee9
SM
55472013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5548
5549 * window.c (select_window): `record_buffer' even if window is
5550 already selected (bug#14191).
5551
fcc1fe85
EZ
55522013-04-11 Eli Zaretskii <eliz@gnu.org>
5553
5554 * window.c (Fwindow_end): Test more flags, including the buffer's
5555 last_overlay_modified flag, to determine whether the window's
5556 display is really up-to-date. Prevents the function from
5557 returning a stale value. (Bug#14170)
5558 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5559 current matrix.
5560
f009190a
EZ
55612013-04-10 Eli Zaretskii <eliz@gnu.org>
5562
5563 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5564 garbaged only if it is not already the top frame on its TTY.
5565 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5566 there are GUI frames open in the same session. (Bug#13864)
5567
78ce603d
SM
55682013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5569
5570 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5571 of marking the idle timers directly.
5572
a8036e40
SM
55732013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5574
5575 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5576 tables (bug#14054).
5577
7ffe7ef6
SM
55782013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5579
5580 * window.c (select_window): Don't record_buffer while the invariant is
5581 temporarily broken (bug#14161).
5582
5583 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5584
7d9f6883
EZ
55852013-04-07 Eli Zaretskii <eliz@gnu.org>
5586
5587 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5588
5406cfd9
RF
55892013-04-07 Romain Francoise <romain@orebokech.com>
5590
5591 Ignore additional platform-specific ACL errors (Bug#13702).
5592 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5593 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5594
95c0e83b
JD
55952013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5596
5597 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5598 f->output_data.ns.
5599
876da980
PE
56002013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5601
5602 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5603 This bug was introduced by my 2013-02-25 change that simplified
5604 data_start configuration. Without this change, on GNU/Linux
5605 an Emacs configured with --enable-profiling fails immediately
5606 due to a profiler signal.
5607 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5608 with these flags. On platforms where special flags are needed
5609 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5610 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5611 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5612
7452b7bd
DA
56132013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5614
5615 Get rid of some platform-specific functions examining window
5616 system and its capabilities. This is a partial rework of the
5617 2013-04-05 change.
5618 * lisp.h (have_menus_p): Remove prototype. This function is
5619 replaced with platform-independent window_system_available.
5620 (check_window_system): Move to...
5621 * frame.h (decode_window_system_frame, window_system_available):
5622 ...here, add new prototypes.
5623 * frame.c (window_system_available, decode_window_system_frame):
5624 New functions.
5625 (check_window_system): Platform-independent now.
5626 * xterm.h (x_in_use): Remove declaration.
5627 (check_x_frame):
5628 * w32term.h (check_x_frame):
5629 * nsterm.h (check_x_frame): Remove prototypes. This function
5630 is replaced with platform-independent decode_window_system_frame.
5631 * msdos.c (have_menus_p): Remove.
5632 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5633 Remove platform-specific functions. Use check_window_system,
5634 decode_window_system_frame and check_ns_display_info where
5635 appropriate. Minor style and comment tweaks.
5636 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5637 (check_x_frame): Likewise.
5638 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5639 Likewise.
5640 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5641 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5642 * xmenu.c, xselect.c: All related users changed.
5643
251e9147
KH
56442013-04-03 Kenichi Handa <handa@gnu.org>
5645
5646 The following changes is to optimize the code for reading UTF-8
5647 files.
5648
562c6ee9 5649 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5650 changed. Check EOL format. Do not call adjust_coding_eol_type
5651 here.
5652 (check_utf_8): New function.
5653 (adjust_coding_eol_type): Do nothing if already adjusted.
5654 (detect_coding): Compare the return value of check_ascii with
5655 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5656 (decode_coding_gap): Optimize for valid UTF-8.
5657
8bc369d4
KH
56582013-03-21 Kenichi Handa <handa@gnu.org>
5659
5660 * coding.c (syms_of_coding): Cancel previous change.
5661
5662 * insdel.c (insert_from_gap): Fix previous change.
5663
73931ad1
DA
56642013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5665
5666 Consistently use platform-specific function to detect window system.
5667 * lisp.h (check_window_system): New prototype. This function is
5668 going to replace check_x, check_w32 and check_ns.
5669 (have_menus_p): Mention msdos.c in comment.
5670 * fontset.c (check_window_system_func): Remove. Adjust all users.
5671 * fontset.h (check_window_system_func): Remove prototype.
5672 * nsterm.h (check_ns):
5673 * xterm.h (check_x):
5674 * w32term.h (check_w32): Likewise.
5675 * menu.c (Fx_popup_menu): Use check_window_system.
5676 * msdos.c (check_window_system): Define for MS-DOS.
5677 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5678 * w32fns.c (check_window_system): Likewise for MS-Windows.
5679 * xfns.c (check_window_system): Likewise for X.
5680 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5681 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5682
7216e43b
PE
56832013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5684
5685 Prefer < to > in range checks such as 0 <= i && i < N.
5686 This makes it easier to visualize quantities on a number line.
5687 This patch doesn't apply to all such range checks,
5688 only to the range checks affected by the 2013-03-24 change.
5689 This patch reverts most of the 2013-03-24 change.
5690 * alloc.c (xpalloc, Fgarbage_collect):
5691 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5692 * character.c (string_escape_byte8):
5693 * charset.c (read_hex):
5694 * data.c (cons_to_unsigned):
5695 * dispnew.c (update_frame_1):
5696 * doc.c (Fsubstitute_command_keys):
5697 * doprnt.c (doprnt):
5698 * editfns.c (hi_time, decode_time_components):
5699 * fileio.c (file_offset):
5700 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5701 * font.c (font_intern_prop):
5702 * frame.c (x_set_alpha):
5703 * gtkutil.c (get_utf8_string):
5704 * indent.c (check_display_width):
5705 * keymap.c (Fkey_description):
5706 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5707 * lread.c (read1):
5708 * minibuf.c (read_minibuf_noninteractive):
5709 * process.c (wait_reading_process_output):
5710 * search.c (Freplace_match):
5711 * window.c (get_phys_cursor_glyph):
5712 * xdisp.c (redisplay_internal):
5713 * xsmfns.c (smc_save_yourself_CB):
5714 Prefer < to > for range checks.
5715 * dispnew.c (sit_for): Don't mishandle NaNs.
5716 This fixes a bug introduced in the 2013-03-24 change.
5717 * editfns.c (decode_time_components): Don't hoist comparison.
5718 This fixes another bug introduced in the 2013-03-24 change.
5719
92759988
DA
57202013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5721
5722 * frame.h (struct frame): Drop scroll_bottom_vpos
5723 member becaue all real users are dead long ago.
5724 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5725 * xdisp.c (redisplay_internal): Adjust user.
5726
9a1971bb
GM
57272013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5728
f38ab167
JD
5729 * nsmenu.m (showAtX:Y:for:): setLevel to
5730 NSPopUpMenuWindowLevel (Bug#13998).
5731
6d01f1fe
JD
57322013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5733
5734 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5735 (ns_check_pending_open_menu): Declare.
5736
5737 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5738 (x_activate_menubar): Update the menu with title that matches
5739 ns_get_pending_menu_title, and call
5740 ns_check_pending_openmenu (Bug#12698).
5741 (menuWillOpen:): New method.
5742 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5743
5744 * nsterm.m (menu_will_open_state, menu_mouse_point)
5745 (menu_pending_title): New varaibles.
5746 (ns_get_pending_menu_title, ns_check_menu_open)
5747 (ns_check_pending_open_menu): New functions.
5748
781f4782
DA
57492013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5750
5751 * indent.c (current_column_bol_cache): Remove leftover which is not
5752 used in Fmove_to_column any more.
5753 (current_column, scan_for_column): Adjust users.
5754 * keyboard.c (last_point_position_buffer, last_point_position_window):
5755 Remove leftovers which are not used for recording undo any more.
5756 (command_loop_1, syms_of_keyboard): Adjust users.
5757 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5758 redisplay_window any more.
5759 (move_it_to): Adjust user.
5760
1921c31b
JB
57612013-03-29 Juanma Barranquero <lekktu@gmail.com>
5762
5763 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5764 Update dependencies.
5765
717b8bcd
SM
57662013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5767
5768 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5769 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5770 forward references.
5771
e74aeda8
DA
57722013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5773
5774 * window.h (struct window): Replace hchild, vchild and buffer slots
5775 with the only contents slot. This is possible because each valid
5776 window may have either the child window (in vertical or horizontal
5777 combination) or buffer to display (for the leaf window). Using that,
5778 a lof of operations to traverse and/or change window hierarchies may
5779 be simplified. New member horizontal is used to distinguish between
5780 horizontal and vertical combinations of internal windows.
5781 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5782 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5783 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5784 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5785 Use contents slot, not buffer, where appropriate.
5786 (wset_combination): New function.
5787 (wset_buffer): Add eassert.
5788 (Fframe_first_window): Simplify the loop reaching first window.
5789 (Fwindow_buffer): Use WINDOW_LEAF_P.
5790 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5791 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5792 (unshow_buffer): Convert initial debugging check to eassert.
5793 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5794 (make_parent_window, window_resize_check, window_resize_apply)
5795 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5796 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5797 Adjust to match struct window changes.
5798 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5799 (mark_window_cursors_off, count_windows, get_leaf_windows)
5800 (foreach_window_1): Simplify the loop.
5801 * alloc.c (mark_object): Do not check for the leaf window because
5802 internal windows has no glyph matrices anyway.
5803 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5804 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5805 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5806 (build_frame_matrix_from_window_tree, mirror_make_current)
5807 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5808 (update_window_tree, set_window_update_flags): Simplify the loop.
5809 (sync_window_with_frame_matrix_rows): Enforce live window.
5810 Use contents slot, not buffer, where appropriate.
5811 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5812 and WINDOW_HORIZONTAL_COMBINATION_P.
5813 (make_frame_visible_1): Simplify the loop.
5814 Use contents slot, not buffer, where appropriate.
5815 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5816 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5817 (expose_window_tree): Likewise.
5818 Use contents slot, not buffer, where appropriate.
5819 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5820 to avoid deleted windows. Use contents slot instead of buffer.
5821 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5822 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5823 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5824 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5825
121ab1cd
EZ
58262013-03-28 Eli Zaretskii <eliz@gnu.org>
5827
ef454cf7
EZ
5828 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5829 identify the reasons for assertion violations in bug#14062 and
5830 similar ones.
21e930f8
EZ
5831 (Fx_show_tip): Fix compilation error under
5832 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5833
121ab1cd
EZ
5834 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5835 Reported by <rzl24ozi@gmail.com>.
5836
5c89ca24
DA
58372013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5838
5839 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5840 start marker...
562c6ee9
SM
5841 (unwind_with_echo_area_buffer): ...to restore it here.
5842 This is needed to ensure that...
5c89ca24
DA
5843 (redisplay_window): ...both window markers are valid here,
5844 which is verified by eassert.
5845 * editfns.c (save_excursion_save): Do not assume that
5846 selected_window always displays the buffer.
c7f53895
DA
5847 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5848 Fix comment.
5c89ca24 5849
f557c1b1
SM
58502013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5851
5852 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5853 the upcase table.
5854
40693bba 58552013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5856
5857 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5858
c86f791f
EZ
58592013-03-27 Eli Zaretskii <eliz@gnu.org>
5860
5861 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5862 since MinGW's w32api headers do. This avoids compiler warnings.
5863
5864 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5865 if already defined.
5866
c6e72e17
EZ
58672013-03-26 Eli Zaretskii <eliz@gnu.org>
5868
5869 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5870
54e95010
JD
58712013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5872
5873 * gtkutil.c (style_changed_cb): Check if frame is live and an
5874 X frame (Bug#14038).
5875
b88b62de
EZ
58762013-03-26 Eli Zaretskii <eliz@gnu.org>
5877
a18d7de6
EZ
5878 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5879 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5880 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5881 MinGW64.
8f5e14c8
EZ
5882 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5883 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5884
b88b62de
EZ
5885 Fix incompatibilities between MinGW.org and MinGW64 headers.
5886 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5887
5888 * w32.c (REPARSE_DATA_BUFFER): Guard with
5889 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5890
c074e458
JD
58912013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5892
5893 * xterm.c: Include X11/XKBlib.h
5894 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5895
908589fd
AS
58962013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5897
5898 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5899 written backwards.
5900 * blockinput.h (input_blocked_p): Likewise.
5901 * bytecode.c (exec_byte_code): Likewise.
5902 * callproc.c (call_process_kill, call_process_cleanup)
5903 (Fcall_process): Likewise.
5904 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5905 (Fccl_execute_on_string): Likewise.
5906 * character.c (string_escape_byte8): Likewise.
5907 * charset.c (read_hex): Likewise.
5908 * cm.c (calccost): Likewise.
5909 * data.c (cons_to_unsigned): Likewise.
5910 * dired.c (directory_files_internal, file_name_completion):
5911 Likewise.
5912 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5913 (sit_for): Likewise.
5914 * doc.c (Fsubstitute_command_keys): Likewise.
5915 * doprnt.c (doprnt): Likewise.
5916 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5917 * emacsgtkfixed.c: Likewise.
5918 * fileio.c (file_offset, Fwrite_region): Likewise.
5919 * floatfns.c (Fexpt, fmod_float): Likewise.
5920 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5921 Likewise.
5922 * font.c (font_intern_prop): Likewise.
5923 * frame.c (x_set_alpha): Likewise.
5924 * gtkutil.c (get_utf8_string): Likewise.
5925 * indent.c (check_display_width): Likewise.
5926 * intervals.c (create_root_interval, rotate_right, rotate_left)
5927 (split_interval_right, split_interval_left)
5928 (adjust_intervals_for_insertion, delete_node)
5929 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5930 (merge_interval_right, merge_interval_left, copy_intervals)
5931 (set_intervals_multibyte_1): Likewise.
5932 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5933 * keymap.c (Fkey_description): Likewise.
5934 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5935 * lread.c (openp, read_integer, read1, string_to_number):
5936 Likewise.
5937 * menu.c (ensure_menu_items): Likewise.
5938 * minibuf.c (read_minibuf_noninteractive): Likewise.
5939 * print.c (printchar, strout): Likewise.
5940 * process.c (create_process, Faccept_process_output)
5941 (wait_reading_process_output, read_process_output, send_process)
5942 (wait_reading_process_output): Likewise.
5943 * profiler.c (make_log, handle_profiler_signal): Likewise.
5944 * regex.c (re_exec): Likewise.
5945 * regex.h: Likewise.
5946 * search.c (looking_at_1, Freplace_match): Likewise.
5947 * sysdep.c (get_child_status, procfs_ttyname)
5948 (procfs_get_total_memory): Likewise.
5949 * systime.h (EMACS_TIME_VALID_P): Likewise.
5950 * term.c (dissociate_if_controlling_tty): Likewise.
5951 * window.c (get_phys_cursor_glyph): Likewise.
5952 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5953 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5954 Likewise.
5955 * xfns.c (Fx_window_property): Likewise.
5956 * xmenu.c (set_frame_menubar): Likewise.
5957 * xselect.c (x_get_window_property, x_handle_dnd_message):
5958 Likewise.
5959 * xsmfns.c (smc_save_yourself_CB): Likewise.
5960 * xterm.c (x_scroll_bar_set_handle): Likewise.
5961
2bf7d27a
DA
59622013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5963
5964 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5965 to be optional or nil. Adjust comment and convert it to docstring.
5966 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5967 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5968
a9ebfa0b
PE
59692013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5970
5971 Static checking by GCC 4.8-20130319.
5972 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5973 * process.c (Fset_process_datagram_address)
5974 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5975 * xdisp.c (get_char_face_and_encoding):
5976 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5977 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5978 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5979
4f3576ee
KB
59802013-03-24 Ken Brown <kbrown@cornell.edu>
5981
789b5e9a
KB
5982 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5983 fix compilation on 64-bit Cygwin, where underscores are not
5984 automatically prepended.
5985
4f3576ee
KB
5986 * w32term.c (w32_initialize): Silence compiler warning.
5987
b5b7745f
EZ
59882013-03-23 Eli Zaretskii <eliz@gnu.org>
5989
cdc0d0bd
EZ
5990 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5991 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5992 variables, to save and restore frame dimensions.
5993 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5994 after returning from a 'fullscreen' configuration.
5995 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5996 to avoid races between the main thread and the input thread.
5997
5998 * w32term.h (struct w32_output): New members normal_width,
5999 normal_height, normal_top, normal_left, and prev_fsmode.
6000 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
6001 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
6002 members of a frame.
6003
b5b7745f
EZ
6004 * w32term.c (w32fullscreen_hook): Record last value of the frame's
6005 'fullscreen' parameter. Always record previous width and height
6006 of the frame, except when switching out of maximized modes, so
6007 that they could be restored correctly, instead of resetting to the
6008 default frame dimensions. Send SC_RESTORE command to the frame,
6009 unless we are going to send SC_MAXIMIZE, to restore the frame
6010 resize hints in the mouse pointer shown by the window manager.
6011 (Bug#14032)
6012
6013 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
6014
6015 * lisp.h (get_frame_param): Adjust conditions for prototype
6016 declaration.
6017
a3454eed
KB
60182013-03-22 Ken Brown <kbrown@cornell.edu>
6019
6020 * unexcw.c: Drop unneeded inclusion of w32common.h.
6021 (report_sheap_usage): Declare.
6022 (read_exe_header): Add magic numbers for x86_64.
6023 (fixup_executable): Fix printf format specifier for unsigned long
6024 argument.
6025
5a49b79c
DA
60262013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
6027
6028 * frame.h (struct frame): Put menu_bar_window under #ifdef
6029 because this member is not needed when X toolkit is in use.
6030 (fset_menu_bar_window):
6031 * dispnew.c (clear_current_matrices, clear_desired_matrices)
6032 (free_glyphs, update_frame):
6033 * xdisp.c (expose_frame): Likewise.
6034 (display_menu_bar): Likewise. Remove redundant eassert.
6035 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
6036 toolkit is in use.
6037
d6723bf7
PE
60382013-03-21 Paul Eggert <eggert@cs.ucla.edu>
6039
7b1123d8
PE
6040 Use functions and constants to manipulate Lisp_Save_Value objects.
6041 This replaces code that used macros and strings and token-pasting.
6042 The change makes the C source a bit easier to follow,
6043 and shrinks the Emacs executable a bit.
6044 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
6045 (make_save_value): Change 1st arg from string to enum. All callers
6046 changed.
6047 (INTX): Remove.
6048 (mark_object): Use if, not #if, for GC_MARK_STACK.
6049 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
6050 (XSAVE_OBJECT): Now functions, not macros.
6051 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
6052 the constant was never used.
6053 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
6054 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
6055 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
6056 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
6057 New constants.
6058 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
6059 type3 with a single member save_type. All uses changed.
6060 (save_type, set_save_pointer, set_save_integer): New functions.
6061 * print.c (PRINTX): Remove.
6062
d6723bf7
PE
6063 * alloc.c: Remove redundant static declarations.
6064
5f24fa51
DA
60652013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6066
6067 * window.h (struct window): Convert left_col, top_line, total_lines
6068 and total_cols from Lisp_Objects to integers. Adjust comments.
6069 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
6070 Remove.
6071 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
6072 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
6073 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
6074 Adjust users where appropriate.
6075
42143acd
DA
60762013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6077
6078 * frame.h (struct frame): Drop resx and resy because the same data is
6079 available from window system-specific output context. Adjust users.
562c6ee9
SM
6080 (default_pixels_per_inch_x, default_pixels_per_inch_y):
6081 New functions to provide defaults when no window system available.
42143acd 6082 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 6083 (NUMVAL): Move from xdisp.c.
42143acd
DA
6084 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
6085 (Ffont_face_attributes, Fopen_font):
6086 * image.c (gs_load):
6087 * w32font.c (fill_in_logfont):
6088 * xdisp.c (calc_pixel_width_or_height):
6089 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
6090 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
6091
c0a17406
KH
60922013-03-20 Kenichi Handa <handa@gnu.org>
6093
6094 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
6095 to 1 (temporary workaround until a bug related to ASCII
6096 optimization is fixed).
6097
095d384d
DA
60982013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
6099
6100 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
6101 Signal error if window is not internal. Adjust docstring.
6102 (delete_all_child_windows): Use combination_limit to save the buffer.
6103 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
6104 * print.c (syms_of_print): Initialize debugging output not here...
6105 (init_print_once): ...but in a new function here.
6106 * lisp.h (init_print_once): Add prototype.
6107 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 6108
748fa866
DA
61092013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
6110
6111 * window.c (window_resize_check, window_resize_apply)
6112 (window_from_coordinates, recombine_windows, set_window_buffer)
6113 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
6114 (Fsplit_window_internal, Fdelete_window_internal)
6115 (freeze_window_starts): Use bool for booleans.
6116 * window.h (window_frame_coordinates, resize_frame_windows)
6117 (freeze_window_starts, set_window_buffer): Adjust prototypes.
6118
81519fd2
SM
61192013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
6120
6121 * dispnew.c (bitch_at_user): Use `user-error'.
6122
6db423a9
KB
61232013-03-17 Ken Brown <kbrown@cornell.edu>
6124
6125 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
6126 as return type of image_background. (Bug#13981)
6127 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
6128
8f2906f5
JD
61292013-03-16 Jan Djärv <jan.h.d@swipnet.se>
6130
960ce480 6131 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 6132 (ns_select): Don't return with result uninitialized.
960ce480 6133
8f2906f5
JD
6134 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
6135 and getDirectory.
6136
81519fd2
SM
6137 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
6138 New functions.
8f2906f5
JD
6139 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
6140 directories. If filename is nil, get directory name (Bug#13932).
6141 Use getFilename and getDirectory.
6142 (getFilename, getDirectory): New methods for EmacsSavePanel and
6143 EmacsOpenPanel.
6144 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
6145
cded56c1
PE
61462013-03-15 Paul Eggert <eggert@cs.ucla.edu>
6147
6148 * coding.c (decode_coding_gap): Fix typo caught by static checking.
6149
251e9147 61502013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
6151
6152 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
6153 (adjust_after_replace): Make it back to static. Delete the third
6154 arg text_at_gap_tail. Cancel the code for handling it.
6155
6156 * coding.h (struct coding_system): New member eol_seen.
6157
6158 * coding.c (detect_ascii): New function.
6159 (detect_coding): Set coding->head_ascii and coding->eol_seen only
6160 when the source bytes are actually scanned. On detecting for
6161 coding_category_utf_8_auto, call detect_ascii instead of scanning
6162 source bytes directly.
6163 (produce_chars): Call insert_from_gap with the new arg 0.
6164 (encode_coding): Likewise.
6165 (decode_coding_gap): Control ASCII optimization by the variable
6166 disable_ascii_optimization instead of #ifndef .. #endif.
6167 Deccode EOL format according to coding->eol_seen.
6168 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
6169 variable.
6170
8a44e6d1
KH
6171 * lisp.h (adjust_after_replace): Cancel externing it.
6172 (insert_from_gap): Adjust prototype.
6173
5f795e34
EZ
61742013-03-15 Eli Zaretskii <eliz@gnu.org>
6175
6176 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
6177 FULLSCREEN_MAXIMIZED. (Bug#13935)
6178
f258b4be
DA
61792013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
6180
6181 * region-cache.c (find_cache_boundary, move_cache_gap)
6182 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
6183 Simplify debugging check and convert to eassert. Adjust comment.
6184 (pp_cache): Put under ENABLE_CHECKING.
6185
a5cc4dde
EZ
61862013-03-14 Eli Zaretskii <eliz@gnu.org>
6187
6188 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
6189 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
6190 and WM_ACTIVATEAPP.
6191 (w32fullscreen_hook): If the frame is visible, reset
6192 f->want_fullscreen flag after changing the frame size. If the
6193 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
6194 (Bug#13953)
6195
3fc5e44a
DC
61962013-03-13 Daniel Colascione <dancol@dancol.org>
6197
6198 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
6199 too so that these builds can use Cygwin's file conversion
6200 functions. (We've been building and linking cygw32.o all along
6201 and just not using it.)
6202
47d7532e
PE
62032013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6204
6205 File synchronization fixes (Bug#13944).
6206 * Makefile.in (LIB_FDATASYNC): New macro.
6207 (LIBES): Use it.
6208 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
6209 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
6210 Don't worry about HAVE_FSYNC, since a substitute fsync is
6211 available if the system lacks one.
6212 (Fwrite_regin): Retry fsync if interrupted.
6213
c7ffccaf
EZ
62142013-03-13 Eli Zaretskii <eliz@gnu.org>
6215
4e2df81d 6216 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
6217 activated, call w32fullscreen_hook, to make sure the new frame
6218 dimensions are in effect. (Bug#13937)
6219
8a7debc1
DA
62202013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
6221
6222 * xdisp.c (init_iterator): Simplify because both character and byte
6223 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
6224 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
6225 character and byte positions can be obtained from marker.
8a7debc1 6226
7fd8c501
PE
62272013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6228
d9df6f40
PE
6229 Static checking by Sun C 5.12.
6230 * alloc.c (buffer_memory_full) [REL_ALLOC]:
6231 * bytecode.c (exec_byte_code):
6232 * dispnew.c (init_display):
6233 * eval.c (error):
6234 * fileio.c (Fsubstitute_in_file_name):
6235 * keyboard.c (Fevent_convert_list):
6236 * keymap.c (Fsingle_key_description):
6237 * term.c (maybe_fatal, fatal):
6238 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
6239 * xsmfns.c (Fhandle_save_session):
6240 Omit unreachable code.
6241 * keymap.c (map_keymap_char_table_item): Cast void * to
6242 a function pointer type; the C Standard requires this.
6243
7fd8c501
PE
6244 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
6245 Include <sys/param.h> unconditionally, as that works elsewhere and
6246 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
6247 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
6248 and FreeBSD now.
6249
a020afb9 6250See ChangeLog.12 for earlier changes.
aac0c6e3
MR
6251
6252;; Local Variables:
6253;; coding: utf-8
aac0c6e3
MR
6254;; End:
6255
ab422c4d 6256 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
6257
6258 This file is part of GNU Emacs.
6259
6260 GNU Emacs is free software: you can redistribute it and/or modify
6261 it under the terms of the GNU General Public License as published by
6262 the Free Software Foundation, either version 3 of the License, or
6263 (at your option) any later version.
6264
6265 GNU Emacs is distributed in the hope that it will be useful,
6266 but WITHOUT ANY WARRANTY; without even the implied warranty of
6267 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6268 GNU General Public License for more details.
6269
6270 You should have received a copy of the GNU General Public License
6271 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.