* lisp/minibuffer.el: Make minibuffer-complete call completion-in-region
[bpt/emacs.git] / src / ChangeLog
CommitLineData
77394d40
DA
12013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
4 (last_glyphless_glyph_merged_face_id): Remove declarations.
5 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
6 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
7 (last_glyphless_glyph_merged_face_id): Now static.
8 (merge_escape_glyph_face): New function, refactored from...
9 (get_next_display_element): ...here.
10 (merge_glyphless_glyph_face): New function, refactored from...
11 (produce_glyphless_glyph): ...here...
12 * term.c (produce_glyphless_glyph): ...and here.
13
306d67bd
SM
142013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
15
16 * eval.c (eval_sub): Only call Ffunction if necessary.
17
7f6c6450
DA
182013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
19
20 Attempt to make redisplay more selective when changing cursor type.
21 * frame.h (struct frame): New bitfield cursor_type_changed.
22 * xdisp.c (cursor_type_changed): Remove.
23 (try_cursor_movement, redisplay_window, try_window_id)
24 (set_frame_cursor_types, try_window_reusing_current_matrix):
25 Adjust to use per-frame bitfield.
26 (redisplay_internal): Look for cursor type change on each visible
27 frame and consider all frames if cursor type has been changed on
28 the frame other than selected. If cursor type has been changed on
29 selected frame only, do not use fast update.
30
bd0443bb
DA
312013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
32
33 Attempt to make redisplay more selective when changing fonts.
34 * frame.h (struct frame): New bitfield fonts_changed.
35 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
36 (adjust_frame_glyphs): Add prototype.
37 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 38 (adjust_glyphs): Remove because we do not
bd0443bb
DA
39 adjust matrices on all frames at once any more.
40 (adjust_frame_glyphs): Block and unblock input here.
41 (adjust_glyph_matrix): Use fonts_changed.
42 (change_frame_size_1): Use adjust_frame_glyphs.
43 * font.c (font_open_entity): Use fonts_changed.
44 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
45 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
46 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
47 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
48 (shrink_mini_window, Fresize_mini_window_internal)
49 (window_scroll_pixel_based, Fset_window_configuration)
50 (apply_window_adjustment, Fset_window_vscroll):
51 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
52 Use adjust_frame_glyphs.
53 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
54 (try_window_reusing_current_matrix, try_window_id, display_line)
55 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
56 (redisplay_internal): Consider fonts_changed and adjust frame
57 matrices for each frame only if the frame is visible. If font
58 has been changed on some frame during full redisplay, retry
59 only visible frames where the font has been actually changed.
60
b9695828
DA
612013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
62
63 Cache current header and mode line height for each window.
64 * window.h (struct window): New fields mode_line_height
65 and header_line_height.
66 * window.c (make_window): Initialize them.
67 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
68 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
69 (current_mode_line_height, current_header_line_height):
70 Remove declaration.
71 * xdisp.c (current_mode_line_height, current_header_line_height):
72 Remove.
73 (pos_visible_p, init_xdisp): Adjust user.
74 (redisplay_window): Invalidate mode_line_height and
75 header_line_height if current and desired matrices do not agree.
76
66738305
DA
772013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
78
79 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
80 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
81
257b3b03
DA
822013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
83
84 Make --without-x compatible with --enable-gcc-warnings.
85 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
86 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
87 members under HAVE_WINDOW_SYSTEM.
88 * keyboard.c (make_lispy_focus_out): Likewise.
89 (record_menu_key): Move under HAVE_MENUS.
90 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
91 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
92 (syms_of_xdisp): Adjust user.
93 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
94 (start_hourglass, cancel_hourglass):
95 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
96 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
97 and CLEAR_FONT_TABLE_NFONTS.
98 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
99 Declare only if HAVE_WINDOW_SYSTEM.
100 (lface_same_font_attributes_p, clear_face_gcs): Define only
101 if HAVE_WINDOW_SYSTEM.
102
98b7f4bd
DA
1032013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
104
105 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
106 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
107 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
108
a7e43722
SM
1092013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
110
111 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
112
0c90b9ee
PE
1132013-09-04 Paul Eggert <eggert@cs.ucla.edu>
114
115 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
116 This fixes a type error on hosts where ptrdiff_t is wider than int.
117
d99760fa
SM
1182013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
119
6629638e
SM
120 * keyboard.c (read_key_sequence_vs): New function.
121 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
122 common code.
123
d99760fa
SM
124 * callint.c (Fcall_interactively): Always return a vector for 'K'.
125
224e313d
PE
1262013-09-04 Paul Eggert <eggert@cs.ucla.edu>
127
128 Makefile improvements.
129 * Makefile.in (config.status): Don't use double-colon rules, as
130 they are not portable according to POSIX. Fix shell typo with `;
131 I guess this rule has never been tested?
132 (VCSWITNESS): New macro, to override any environment var.
133
6d6ed1af
DA
1342013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
135
136 * xterm.h (struct x_display_info): Do not track X connection
137 fd separately because it is always available from Display.
138 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
139 Adjust users.
140
bc923770
DA
1412013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
142
143 * buffer.c (drop_overlay):
144 * fileio.c (restore_point_unwind): Prefer unchain_marker to
145 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
146
b1cf96de
DA
1472013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
148
149 * buffer.c (Fmake_overlay, Fmove_overlay):
150 * intervals.c (set_point_from_marker):
151 * print.c (PRINTPREPARE): Prefer signal_error
152 to plain error and report unsuitable marker too.
153
d1fc6c21
DA
1542013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
155
156 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
157 for 'dragging' member.
d1ae6a0b
DA
158 (struct x_output): Remove set-but-unused leftovers
159 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
160 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
161 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
162 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
163 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
164 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
165 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 166 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 167 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 168
0ce9f6de
JD
1692013-09-03 Jan Djärv <jan.h.d@swipnet.se>
170
171 * nsfont.m (INVALID_GLYPH): New define.
172 (nsfont_encode_char): Use INVALID_GLYPH.
173 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
174
b594a96c
DA
1752013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
176
177 * xterm.c (x_last_mouse_movement_time): Revert last change.
178 This code should use XDisplayMotionBufferSize to check display's
179 motion history first, and there are few other issues as well.
180 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
181 (handle_one_xevent): Adjust user.
182
8b098236
MR
1832013-09-02 Martin Rudalics <rudalics@gmx.at>
184
9718b207
MR
185 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
186 * frame.c (Flast_nonminibuf_frame): ... to here.
187 (check_minibuf_window): Don't abort if no window was found
188 (Bug#15247).
8b098236 189
84e70bba
DA
1902013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
191
192 Use XGetMotionEvents to ask the last mouse motion time from X server.
193 * xterm.c (X_MOTION_HISTORY): Default to 1.
194 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
195 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
196 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
197 Ifdef away legacy code.
198 (XTmouse_position, x_scroll_bar_report_motion):
199 Use x_last_mouse_movement_time.
fc85e20b
DA
200 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
201 UnmapNotify event.
84e70bba 202
1fccc530
DA
2032013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
204
205 * msdos.c (last_mouse_window): Move to...
206 (dos_rawgetc): ...this function and adjust comment.
207 * nsterm.m (last_window): Rename to last_mouse_window, move to...
208 (mouseMoved): ...this function and adjust comment.
209 * w32term.c (last_window): Likewise with...
210 (w32_read_socket): ...this function.
211 * xterm.c (last_window): Likewise with...
212 (handle_one_xevent): ...this function.
213
0ab10992
DA
2142013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
215
b7da754d 216 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
217 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
218 (handle_one_xevent): ...to here.
219 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
220 otherwise.
221
0c7f856e
DA
2222013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
223
224 * msdos.c (IT_set_terminal_window): Remove no-op.
225 (initialize_msdos_display): Adjust terminal setup.
226 * w32console.c (w32con_set_terminal_window): Remove no-op.
227 (initialize_w32_display): Adjust terminal setup.
228 * w32term.c (w32_set_terminal_window): Remove no-op.
229 (w32_create_terminal): Adjust terminal setup.
230 * xterm.c (XTset_terminal_window): Remove no-op.
231 (x_create_terminal): Adjust terminal setup.
232
a892a94c
DA
2332013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
234
235 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
236 Remove no-ops.
237 (ns_create_terminal): Adjust terminal setup.
238 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
239 Remove no-ops.
240 (w32_create_terminal): Adjust terminal setup.
241 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
242 Remove no-ops.
243 (x_create_terminal): Adjust terminal setup.
244
cf91889a
DA
2452013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
246
247 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
248 (CLIP_TEXT_POS_FROM_MARKER): New macro.
249 * dispnew.c (buffer_posn_from_coords):
250 * window.c (Fwindow_end, displayed_window_lines):
251 * xdisp.c (redisplay_mode_lines): Use it.
252
5b0891df
JD
2532013-09-01 Jan Djärv <jan.h.d@swipnet.se>
254
255 * fontset.c (face_for_char): Check char in the current face font first
256 if HAVE_NS (Bug#15138).
257
0a357e98
MR
2582013-08-31 Martin Rudalics <rudalics@gmx.at>
259
260 * window.c (temp_output_buffer_show): Make sure window returned
261 by display_buffer is live (Bug#15213).
262
9d7693d7
DA
2632013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Minor cleanup to avoid forward declarations.
266 * coding.h (struct ccl_spec): Remove forward declaration.
267 * composite.h (toplevel): Include font.h.
268 (struct composition_it, struct face, struct font_metrics):
269 Remove forward declaration.
270 * dispextern.h (struct image, struct atimer): Likewise.
271 * emacsgtkfixed.h (struct frame): Likewise.
272 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
273 * font.h (struct font_driver, struct font, struct glyph_string)
274 (struct face): Remove forward declaration.
275 * fontset.h (struct face, struct font): Likewise.
276 * frame.h (toplevel): Style cleanup.
277 (enum output_method): Move to...
278 * termhooks.h (enum output_method): ...here.
279 (struct glyph, struct frame, struct ns_display_info)
280 (struct x_display_info, struct w32_display_info):
281 Remove forward declaration.
282 * xterm.h (toplevel): Include termhooks.h.
283 (struct font, struct window, struct glyph_matrix, struct frame)
284 (struct input_event, struct face, struct image): Remove forward
285 declaration.
286 * gtkutil.h (struct _widget_value): Likewise.
287 * keyboard.h (toplevel): Include termhooks.h.
288 (struct input_event): Remove forward declaration.
289
032f7451
DA
2902013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
291
292 * intervals.c (set_point_from_marker): New function.
293 * editfns.c (Fgoto_char):
294 * process.c (Finternal_default_process_filter):
295 * window.c (select_window_1): Use it.
296 * buffer.h (set_point_from_marker): Add prototype.
297
3f940c5a
EZ
2982013-08-29 Eli Zaretskii <eliz@gnu.org>
299
300 * w32.c (term_winsock): Call release_listen_threads before calling
301 WSACleanup.
302 (_sys_wait_accept): Wait for accept event in a loop with a finite
303 timeout, instead of waiting indefinitely. Will hopefully avoid
304 hanging during exit because WSACleanup deadlocks waiting for the
305 event object to be released. (Bug#14333)
306
307 * w32proc.c (release_listen_threads): New function, signals all
308 the reader threads that listen for connections to stop waiting.
309
310 * w32.h (release_listen_threads): Add prototype.
311
101ed2bb
DA
3122013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
313
314 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
315 field of new marker (for sanity and safety).
20de2834
DA
316 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
317 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 318
1f5cf200
DA
3192013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
320
321 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
322 (x_after_update_window_line, x_scroll_bar_create):
323 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
324 (handle_one_xevent, x_clear_frame_area):
325 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
326 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
327 * xterm.h (x_clear_area): Adjust prototype.
328
d2b36813
DA
3292013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
330
331 Hook scanning and indentation functions to find_newline. This helps
332 to avoid duplicated code and renders more respect to newline cache.
333 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
334 * cmds.c (Fforward_line):
335 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
336 Use find_newline and avoid unnecessary point movements.
337 * search.c (scan_newline): Implement on top of find_newline.
338
3ec7babc
SM
3392013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
340
341 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
342 scoped code (bug#11258).
343
5ab473cd
JD
3442013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
345
346 * nsterm.m (last_window): New variable.
347 (EV_TRAILER2): New macro.
348 (EV_TRAILER): Call EV_TRAILER2.
349 (mouseMoved:): Add support for mouse-autoselect-window
350 on nextstep (Bug#6888).
351
78779650
AS
3522013-08-28 Andreas Schwab <schwab@suse.de>
353
354 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
355 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
356 Remove unused macro definitions.
357 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
358 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
359 Only define if emacs.
78779650 360
c3c4768d
DA
3612013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
362
363 Prefer enum glyph_row_area to int where appropriate.
364 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
365 Fix comment.
366 (window_box, window_box_width, window_box_left, window_box_left_offset)
367 (window_box_right, window_box_right_offset): Adjust prototypes.
368 * xdisp.c (window_box, window_box_width, window_box_left)
369 (window_box_left_offset, window_box_right, window_box_right_offset):
370 Use enum glyph_row_area. Adjust users and tweak comment where needed.
371 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
372 * nsterm.m (ns_clip_to_row):
373 * w32term.c (w32_clip_to_row):
374 * xterm.c (x_clip_to_row): Likewise.
375
6bdcbfe1
DA
3762013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
377
378 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
379 (Fprevious_overlay_change): Fast path for buffer with no overlays.
380
50b13cde
PE
3812013-08-28 Paul Eggert <eggert@cs.ucla.edu>
382
383 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
384 for portability to hosts where /bin/sh has problems.
385
f60e429a
DA
3862013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
387
388 Redesign redisplay interface to drop global output_cursor.
389 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
390 (toplevel): Remove declaration of output_cursor.
391 (set_output_cursor, x_cursor_to): Remove prototype.
392 * window.h (struct window): New member output_cursor.
393 (output_cursor_to): New function to replace RIF member.
394 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
395 (update_text_area, set_window_cursor_after_update): Use it.
396 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
397 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
398 * nsterm.m (ns_update_window_begin, ns_update_window_end):
399 * w32term.c (x_update_window_begin, x_update_window_end):
400 * xterm.c (x_update_window_begin, x_update_window_end):
401 Adjust to use per-window output cursor.
402
43aac990
PE
4032013-08-27 Paul Eggert <eggert@cs.ucla.edu>
404
d486344e
PE
405 Simplify SELECT_TYPE-related code.
406 Like EMACS_TIME, this portability layer is no longer needed, since
407 Emacs has been using fd_set as a portability layer for some time.
408 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
409 (SELECT_TYPE): Remove. All uses changed to fd_set.
410 (fd_set) [!FD_SET]: New typedef.
411
43aac990
PE
412 Simplify EMACS_TIME-related code.
413 This portability layer is no longer needed, since Emacs has been
414 using struct timespec as a portability layer for some time.
415 * atimer.h, buffer.h, dispextern.h, xgselect.h:
416 Include <time.h> rather than "systime.h"; that's all that's needed now.
417 * dispnew.c: Include <timespec.h> rather than "systime.h";
418 that's all that's needed now.
419 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
420 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
421 TIMESPEC_RESOLUTION.
422 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
423 LOG10_TIMESPEC_RESOLUTION.
424 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
425 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
426 (make_emacs_time): Remove. All used changed to make_timespec.
427 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
428 (current_timespec): Rename from current_emacs_time. All uses changed.
429 (add_emacs_time): Remove. All uses changed to timespec_add.
430 (sub_emacs_time): Remove. All uses change dot timespec_sub.
431 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
432 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
433 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
434 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
435 (current_timespec): Rename from current_emacs_time. All uses changed.
436 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
437 changed to timespec_cmp.
438 * xgselect.c: Include <timespec.h>, since our .h files don't.
439
d350e350
DA
4402013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
441
442 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
443 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
444 Remove the leftovers.
445 * gtkutil.c (toplevel): Do not declare Qxft but include
446 font.h to do so.
447 * image.c (toplevel): Do not declare Vlibrary_cache because
448 it's already done in lisp.h.
449
9fed9729
DA
4502013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
451
452 * lisp.h (Mouse_HLInfo): Move from here...
453 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
454 (reset_mouse_highlight): New function.
455 * msdos.c (dos_set_window_size, IT_update_begin)
456 (internal_terminal_init):
457 * nsterm.m (ns_update_window_end, x_free_frame_resources)
458 (ns_initialize_display_info):
459 * w32console.c (initialize_w32_display):
460 * w32term.c (x_update_window_end, x_free_frame_resources)
461 (w32_initialize_display_info):
462 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
463 * window.c (Fdelete_other_windows_internal):
464 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
465 * termchar.h (toplevel):
466 * xterm.h (toplevel): Include dispextern.h.
467
f462f075
PE
4682013-08-26 Paul Eggert <eggert@cs.ucla.edu>
469
470 Fix minor problems found by static checking.
471 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
472 (expect): Avoid nested-if warning.
473 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
474 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
475 * nsterm.h, nsterm.m (ns_select):
476 * xgselect.c, xgselect.h (xg_select):
477 Adjust signature to better match pselect's.
478 * nsterm.m (ns_select):
479 Don't set *TIMEOUT, since pselect doesn't.
480 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
481 diagnostic about assigning const char * to it.
482 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
483
068f9124
SM
4842013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
485
486 * lread.c (substitute_object_recurse): Handle hash-tables as well
487 (bug#15190).
488
f5adc984
PE
4892013-08-26 Paul Eggert <eggert@cs.ucla.edu>
490
1fc8eb33
PE
491 Fix unlikely core dump in init_tty, and simplify terminfo case.
492 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
493 The old version incorrectly dumped core if malloc returned a
494 buffer containing only non-NUL bytes.
495 (init_tty): Do not allocate or free termcap buffers; the
496 struct does that for us now.
497 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
498 (struct tty_display_info): Define members termcap_term_buffer and
499 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
500 use them. Allocate them directly in struct rather than indirectly
501 via a pointer, to simplify init_tty.
502
f5adc984
PE
503 * frame.c (check_minibuf_window): Initialize 'window' properly,
504 so that Emacs reliably aborts later if 'window' is not initialized.
505
efec3894
JD
5062013-08-26 Jan Djärv <jan.h.d@swipnet.se>
507
508 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
509 of VoidSymbol (Bug#15154).
510
e1d0341e
DA
5112013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
512
513 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
514 mouse_face_beg_y and mouse_face_end_y.
515 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
516 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
517 Adjust users and update comment where appropriate.
518
bfff6445
MR
5192013-08-26 Martin Rudalics <rudalics@gmx.at>
520
521 * frame.c (check_minibuf_window): New function.
068f9124
SM
522 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
523 Call check_minibuf_window (Bug#15183).
bfff6445 524
c80016b3
DA
5252013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
526
527 * window.h (struct window): Replace last_cursor with last_cursor_vpos
528 because this is the only last cursor data we need to keep and consult.
529 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
530 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
531 Adjust users.
532
de396731
DA
5332013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
534
068f9124
SM
535 Fix recovering from possible decompression error.
536 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 537 the position where the partially decompressed data ends, and
447218dd 538 should count how many bytes was produced so far.
de396731
DA
539 * decompress.c (struct decompress_unwind_data): Add nbytes member.
540 (unwind_decompress): Really delete partially uncompressed data.
541 (Fzlib_decompress_region): Take decompressed data size into account.
542
c76826d9
DA
5432013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
544
545 * syntax.c (init_syntax_once): Adjust comment and do an early
546 initialization of Qchar_table_extra_slots just once...
547 * casetab.c (init_casetab_once):
548 * category.c (init_category_once):
549 * character.c (syms_of_character):
550 * coding.c (syms_of_coding):
551 * xdisp.c (syms_of_xdisp): ...and omit it here.
552
b34454d0
EZ
5532013-08-24 Eli Zaretskii <eliz@gnu.org>
554
11f20add
EZ
555 * xdisp.c (get_next_display_element): Don't apply to characters
556 from a display vector the logic of setting it->end_of_box_run_p
557 suitable for characters from a buffer. (Bug#15175)
558
b34454d0
EZ
559 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
560 to handle directories, rather than '_utime' which doesn't.
561 (Bug#15176)
562
6e1b469e
JD
5632013-08-24 Jan Djärv <jan.h.d@swipnet.se>
564
565 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
566 or fullscreen (Bug#14627).
567
9c05bccf
PE
5682013-08-24 Paul Eggert <eggert@cs.ucla.edu>
569
570 System-dependent integer overflow fixes.
571 * process.c (Fset_process_window_size): Signal an error if
572 the window size is outside the range supported by the lower level.
573 * sysdep.c (set_window_size): Return negative on error,
574 nonnegative on success, rather than -1, 0, 1 on not in system,
575 failure, success. This is simpler. Caller changed.
576 (serial_configure): Remove unnecessary initialization of local.
577 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
578 size fits in unsigned long; this isn't true on some 32-bit hosts.
579 Avoid buffer overrun if some future version of /proc/meminfo has a
580 variable name longer than 20 bytes.
581 (system_process_attributes) [__FreeBSD__]:
582 Don't assume hw.availpages fits in 'int'.
583
c365c355
PE
5842013-08-23 Paul Eggert <eggert@cs.ucla.edu>
585
586 Don't let very long directory names overrun the stack.
587 Fix some related minor problems involving "//", vfork.
588 * callproc.c (encode_current_directory): New function.
589 (call_process): Don't append "/"; not needed.
590 * fileio.c (file_name_as_directory_slop): New constant.
591 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
592 this can save the caller having to alloca.
593 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
594 Use SAFE_ALLOCA, not alloca.
595 (directory_file_name, Fexpand_file_name): Leave leading "//"
596 alone, since it can be special even on POSIX platforms.
597 * callproc.c (call_process):
598 * process.c (Fformat_network_address):
599 * sysdep.c (sys_subshell):
600 Use encode_current_directory rather than rolling our own.
601 (create_process): No need to encode directory; caller does that now.
602 * process.h (encode_current_directory): New decl.
603 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
604 Rework to avoid 'goto xyzzy;'.
605
6c6014d4
EZ
6062013-08-23 Eli Zaretskii <eliz@gnu.org>
607
608 * xdisp.c (handle_face_prop): If the default face was remapped use
609 the remapped face for strings from prefix properties. (Bug#15155)
610
9997ec56
DA
6112013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
612
613 Minor cleanup for redisplay interface and few related functions.
614 * frame.h (enum text_cursor_kinds): Move from here...
615 * dispextern.h (enum text_cursor_kinds): ...to here.
616 (toplevel): Drop unnecessary declarations.
617 (struct redisplay_interface): Use bool and enum text_cursor_kinds
618 in update_window_end_hook and draw_window_cursor functions.
619 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
620 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
621 * w32term.c (x_update_window_end,w32_draw_window_cursor):
622 * xterm.c (x_update_window_end, x_draw_window_cursor):
623 * xdisp.c (display_and_set_cursor, update_window_cursor)
624 (update_cursor_in_window_tree, x_update_cursor): Use bool and
625 enum text_cursor_kinds where appropriate.
626
7f780da6
DA
6272013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
628
629 Redesign redisplay interface to drop updated_row and updated_area.
630 * dispextern.h (updated_row, updated_area): Remove declaration.
631 (struct redisplay_interface): Pass glyph row and row area parameters
632 to write_glyphs, insert_glyphs and clear_end_of_line functions.
633 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
634 Adjust prototypes.
635 * dispnew.c (updated_row, updated_area): Remove.
636 (redraw_overlapped_rows, update_window_line): Adjust user.
637 (update_marginal_area, update_text_area): Likewise. Pass updated row
638 as a parameter. Prefer enum glyph_row_area to int where appropriate.
639 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
640 Adjust users.
641
26495794
PE
6422013-08-22 Paul Eggert <eggert@cs.ucla.edu>
643
644 * process.c (flush_pending_output): Remove stub.
645 All uses removed.
646
4a88129a
PE
6472013-08-21 Paul Eggert <eggert@cs.ucla.edu>
648
649 * callproc.c: Fix race that killed background processes (Bug#15144).
650 (call_process): New arg TEMPFILE_INDEX. Callers changed.
651 Record deleted process-id in critical section, not afterwards.
652 Don't mistakenly kill process created by a call-process invocation
653 that discards output and does not wait.
654
0c5307b0
DA
6552013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
656
657 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
658 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
659 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
660 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
661 to shut up compiler in mark_object.
662 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
663
0d7c1e66
PE
6642013-08-21 Paul Eggert <eggert@cs.ucla.edu>
665
666 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
667 We can't portably rely on PTY_OPEN doing that, even if
668 it calls posix_openpt with O_CLOEXEC.
669
3f246b65
KH
6702013-08-20 Kenichi Handa <handa@gnu.org>
671
672 * character.c (string_char): Improve commentary.
673
8c2f38aa
PE
6742013-08-20 Paul Eggert <eggert@cs.ucla.edu>
675
676 * image.c (SIGNATURE_DIGESTSIZE): Remove.
677 (struct animation_cache): Make signature a flexible array member.
678 All uses changed. This is a tad slower but may insulate us better
679 from future changes to ImageMagick.
680
bb566cea
PE
6812013-08-19 Paul Eggert <eggert@cs.ucla.edu>
682
683 * image.c: Shrink memory needed for animation cache.
684 (SIGNATURE_DIGESTSIZE): New constant.
685 (struct animation_cache): Make 'signature' a fixed size array of bytes.
686 (imagemagick_create_cache): Copy the signature. This saves
687 several KB of memory that ImageMagick wastes per signature.
688 Don't bother updating the update_time, as the caller does that now.
689 (imagemagick_prune_animation_cache): Don't destroy the signature, as
690 it's a fixed size struct member now.
691 (imagemagick_get_animation_cache): Always destroy the signature,
692 as it's now imagemagick_create_cache's responsibility to copy it.
693 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
694 and use memcmp rather than strcmp.
695 eassert that ImageMagick returns a signature of the specified length.
696
6da26928
LMI
6972013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
698
699 * image.c (imagemagick_get_animation_cache): Don't segfault on
700 each invocation.
453f4022
LMI
701 (imagemagick_get_animation_cache): Revert to previous definition
702 so that it actually works. But keep the memory leak fix.
703 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 704
22490125
PE
7052013-08-19 Paul Eggert <eggert@cs.ucla.edu>
706
d0139df5
PE
707 * image.c: Fix animation cache signature memory leak.
708 Fix some other minor performance problems while we're at it.
709 (imagemagick_create_cache): Clear just the members that
710 need clearing. Don't set update_time, as caller does that now.
711 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
712 Simplify by using pointer-to-pointer instead of a prev pointer.
713 (imagemagick_prune_animation_cache): Use make_emacs_time rather
714 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
715 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
716 it's already a copy. Free the signature probe unless it's cached.
717
22490125
PE
718 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
719 This was introduced by my 2013-08-12 fix for Bug#15035.
720
deb31e75
DA
7212013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
722
723 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
724 (imagemagick_prune_animation_cache): Now static.
725
319a4d03
LMI
7262013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
727
728 * image.c (imagemagick_get_animation_cache): Don't segfault when
729 pruning all entries.
730
f747d82e
KB
7312013-08-18 Ken Brown <kbrown@cornell.edu>
732
733 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
734 static heap if ENABLE_CHECKING is defined.
735 (max_bss_sbrk_ptr): New variable.
736 (bss_sbrk): Use it.
737 (report_sheap_usage): Report maximum static heap usage instead of
738 ending static heap usage.
739
d2c28fab
EZ
7402013-08-17 Eli Zaretskii <eliz@gnu.org>
741
742 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
743 of zlib_initialized according to the results of calling
744 init_zlib_functions.
745
274ff63f
LMI
7462013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
747
748 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 749 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
750 (imagemagick_load_image): Remove the ping_wand code, which only
751 apparently saved time on invalid animated images, and slowed down
752 everything else. Optimise for the common case.
274ff63f 753
2bede2ed
XF
7542013-08-16 Xue Fuqiao <xfq.free@gmail.com>
755
70ff8240
XF
756 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
757
de179a3e
XF
758 * editfns.c (insert_before_markers): Mention overlay in the doc string.
759
2bede2ed
XF
760 * marker.c (set_marker): Remove documentation of undefined behavior.
761
703dbeba
LMI
7622013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
763
764 * image.c (imagemagick_compute_animated_image): Animate correctly
765 when sub-images are smaller than the main image.
1d18b1e6
LMI
766 (imagemagick_compute_animated_image): Setting the iterator row to
767 zero is apparently not allowed.
79670014
LMI
768 (imagemagick_compute_animated_image): Allow images that say they
769 have sub-images that are bigger than the main image, but just crop
770 them.
703dbeba 771
63216c5e
JD
7722013-08-15 Jan Djärv <jan.h.d@swipnet.se>
773
774 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
775
a5b5f73f
LMI
7762013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
777
778 * image.c (imagemagick_compute_animated_image): Respect the GIF
779 disposal methods.
780
0fe73012
KB
7812013-08-15 Ken Brown <kbrown@cornell.edu>
782
783 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
784 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
785 needed.
786
691a357f
PE
7872013-08-15 Paul Eggert <eggert@cs.ucla.edu>
788
789 Fix minor problems found by static checking.
790 * frame.c (delete_frame):
791 * xdisp.c (next_element_from_display_vector):
792 Avoid uninitialized local.
793 * image.c (imagemagick_compute_animated_image): Port to C89.
794 Prefer usual GNU indentation style for loops.
795 Be more careful about bizarrely large sizes, by using ptrdiff_t
796 instead of int.
797
42fe2e88
DA
7982013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
799
800 Fix infinite frame selection loop (Bug#15025).
801 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
802
d39a3da6
EZ
8032013-08-15 Eli Zaretskii <eliz@gnu.org>
804
068f9124
SM
805 * xdisp.c (compute_window_start_on_continuation_line):
806 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
807 to make sure we end up setting the window start at the leftmost
808 visible character of the display line. This avoids funky
809 horizontal shifting because the window start is not kept on the
810 same position. (Bug#15090)
05426239
EZ
811 (next_element_from_display_vector): Support 'box' face attribute
812 in the face definitions of a display vector. (Bug#15099)
d39a3da6 813
6e856b69
LMI
8142013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
815
816 * image.c (imagemagick_compute_animated_image): Implement animated
817 images (bug#14700).
995be755
LMI
818 (imagemagick_compute_animated_image): Fix some compilation
819 warnings. Implement a very simple cache to make the animation
820 usable at all, but it should be replaced with a per-image cache.
6e856b69 821
d5a1acfa
DA
8222013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
823
824 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
825 to do `for' loops over alist values.
826 * buffer.h (FOR_EACH_BUFFER):
827 * process.c (FOR_EACH_PROCESS): Use it.
828 (handle_child_signal, status_notify, Fget_buffer_process)
829 (kill_buffer_processes): Use FOR_EACH_PROCESS.
830
9c253307
DA
8312013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
832
833 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
834 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
835 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
836 to xzalloc and so avoid redundant call to memset.
837 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
838 members because it is allocated with xzalloc and so already zeroed.
839
05e64f9f
KB
8402013-08-14 Ken Brown <kbrown@cornell.edu>
841
842 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
843 (Bug#15094).
844
5b71542d
DA
8452013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
846
847 Utility function and macro to copy Lisp string to C string.
848 * lisp.h (xlispstrdupa): New macro.
849 (xlispstrdup): New prototype.
850 * alloc.c (xlispstrdup): New function.
851 * callint.c (Fcall_interactively):
852 * fileio.c (Ffile_name_directory, Fexpand_file_name)
853 (Fsubstitute_in_file_name):
854 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
855 * image.c (x_create_bitmap_from_file):
856 * w32term.c (w32_term_init):
857 * xterm.c (x_term_init): Use xlispstrdup.
858
71530c97
LMI
8592013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
860
4ce82fb8
LMI
861 * image.c (imagemagick_load_image): Make animated pictures work.
862 There's still some problems with background color settings, though
863 (bug#14700).
864
71530c97
LMI
865 * decompress.c (unwind_decompress): Always restore point.
866
7510a061
XF
8672013-08-14 Xue Fuqiao <xfq.free@gmail.com>
868
869 * marker.c (set_marker): Reformat documentation.
870
01c3051f
PE
8712013-08-14 Paul Eggert <eggert@cs.ucla.edu>
872
aab1fcdf
PE
873 * xdisp.c (cursor_type_changed): Now static.
874
01c3051f
PE
875 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
876 Use changed. This avoids the need to call xmalloc and for the
877 caller to call xfree, and avoids memory leaks in some situations.
878
2084152a
DA
8792013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
880
881 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
882 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
883 (redisplay_window): If window_end_valid is cleared due to non-zero
884 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
885 so do not call to try_cursor_movement for that window.
2084152a 886
02455cb6
DA
8872013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
888
889 * window.h (struct window): Convert window_end_pos and
890 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
891 (wset_window_end_pos, wset_window_end_vpos): Remove.
892 * dispnew.c (adjust_glyph_matrix):
893 * window.c (Fwindow_end, replace_window, set_window_buffer)
894 (make_window):
895 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
896 (set_vertical_scroll_bar, redisplay_window, try_window)
897 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
898 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
899 (note_mouse_highlight): Adjust users.
900 (try_cursor_movement): Likewise. Convert old precondition to eassert.
901 Add comment.
902
da5707e8
DA
9032013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
904
905 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
906 * image.c (imagemagick_filename_hint): Use `const char *' and
907 prefer SSDATA to SDATA to avoid warnings.
908
25554267
DA
9092013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
910
911 Cleanup window fringes, margins and scroll bars adjustments.
912 * window.c (set_window_fringes, set_window_margins)
913 (set_window_scroll_bars, apply_window_adjustment): New functions.
914 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
915 (Fset_window_scroll_bars): Use them.
916
38a2c910
DA
9172013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
918
919 * window.h (struct window): Convert scroll_bar_width
920 from Lisp_Object to integer. Adjust comment.
921 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
922 Adjust users.
923 * window.c (wset_scroll_bar_width): Remove.
924 (make_window): Initialize scroll_bar_width.
925 (Fsplit_window_internal): Use direct assignment.
926 (Fset_window_configuration, save_window_save):
927 Convert Lisp_Object to integer and back where appropriate.
928 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
929 bar was actually changed, and mention this in docstring.
930
2d065031
PE
9312013-08-13 Paul Eggert <eggert@cs.ucla.edu>
932
933 * decompress.c: Minor simplifications.
934 (Fzlib_decompress_region): Don't bother verifying
935 that avail_out <= UINT_MAX, as that was confusing.
936 Mention the restriction in a comment instead.
937 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
938
a5bd5abb
JD
9392013-08-13 Jan Djärv <jan.h.d@swipnet.se>
940
941 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
942 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
943
66e7901a
LMI
9442013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
945
946 * image.c (imagemagick_filename_hint): Check for errors in the
947 alist structure.
948
2fa611b7
EZ
9492013-08-13 Eli Zaretskii <eliz@gnu.org>
950
951 * window.c (Fwindow_margins): Return nil when there's no marginal
952 area, as per the documented API.
953
954 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
955 Fmake_vector, as scroll bar's struct members are not all Lisp
956 objects now. This avoids crashes in GC.
957
958 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
959 bool, so its address could be taken.
960
8259030d
LMI
9612013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
962
963 * image.c (imagemagick_filename_hint): New function to possibly
964 apply `image-content-type-suffixes'.
965 (imagemagick_load_image): Use it.
966
866c710e
EZ
9672013-08-13 Eli Zaretskii <eliz@gnu.org>
968
969 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
970 if loading zlib failed.
971
f10490f0
JD
9722013-08-13 Jan Djärv <jan.h.d@swipnet.se>
973
96311be7
JD
974 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
975 2013-08-13 checkin below. Change bool to BOOL, rule is:
976 All Obj-C code uses BOOL, except for interfaces callable from C.
977
f10490f0
JD
978 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
979
c8ae93b0
DA
9802013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
981
982 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
983 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
984 bool instead of BOOL.
985 * w32term.h (struct scroll_bar): Convert fringe_extended_p
986 from Lisp_Object to bitfield. Adjust comment.
987 * w32term.c (x_scroll_bar_create): Adjust user.
988 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
989 * xterm.c (XTset_vertical_scroll_bar): Likewise.
990 Use bool for boolean.
991 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
992 to `unsigned int' when defining a bitfield.
993
53b64418
PE
9942013-08-13 Paul Eggert <eggert@cs.ucla.edu>
995
996 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
997
eeaf9bf3
DA
9982013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 * window.h (struct window): Convert left_margin_cols and
1001 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1002 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1003 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1004 Adjust users.
1005 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1006 Adjust comment.
1007 (showing_window_margins_p, update_window_line, update_frame_1):
1008 * fringe.c (draw_fringe_bitmap_1):
1009 * xdisp.c (window_box_width): Adjust users.
1010 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1011 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1012 Use direct assignment.
1013 (Fset_window_configuration, save_window_save, Fwindow_margins):
1014 Convert Lisp_Object to integer and back where appropriate.
1015 (Fset_window_margins): Adjust user. Return t if any margin
1016 was actually changed, and mention this in docstring.
1017
956720af
XF
10182013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1019
f73f4ce6 1020 * syntax.c (forward_word):
956720af
XF
1021 * cmds.c (forward_char, backward_char): Mention the optional argument.
1022
9e37ee3b
DA
10232013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1024
1025 * window.h (struct window): Convert left_fringe_width
1026 and right_fringe_width from Lisp_Objects to integers.
1027 Adjust comment.
1028 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1029 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1030 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1031 Remove.
1032 (make_window): Initialize new integer fields to -1.
1033 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1034 (Fset_window_configuration, save_window_save):
1035 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1036 (Fset_window_fringes): Adjust user. Return t if any fringe
1037 was actually changed, and mention this in docstring.
1038
e4375ca7
DA
10392013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1040
1041 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1042 * nsfns.m (x_set_cursor_type):
1043 * w32fns.c (x_set_cursor_type):
1044 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1045 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1046
a45543bc
DA
10472013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1048
1049 * font.c (clear_font_cache): New function, stripped from...
1050 (Fclear_font_cache): ...here, which now uses the function
1051 above. Adjust comment.
1052 * font.h (clear_font_cache): Add prototype.
1053 * xfaces.c (clear_face_cache): Use clear_font_cache.
1054
ae966a86
DA
10552013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1056
1057 * window.c (Fset_window_start): Compare `w', not `window' because
1058 `w' might not be equal to `window' after call to decode_live_window.
1059
297a545b
PE
10602013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1063 This fixes a problem introduced by the Bug#15035 patch
1064 when using GPG. Reported by Herbert J. Skuhra.
1065
aa942e2b
EZ
10662013-08-12 Eli Zaretskii <eliz@gnu.org>
1067
1068 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1069 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1070 not yet initialized.
1071
7699d09e
LMI
10722013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1073
1074 * decompress.c (Fzlib_decompress_region): Support zlib
1075 decompression, too, and rename.
1076
1d238bc7
PE
10772013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1078
1079 Minor zlib configuration tweaks.
1080 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1081 Don't assume presence of fn_inflateInit2_ zlib internal function.
1082
8a44a184
LMI
10832013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1084
1085 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1086 include the zlib prefix.
1087
594a4307
EZ
10882013-08-12 Eli Zaretskii <eliz@gnu.org>
1089
1090 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1091 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1092 define static variables that are pointers to zlib functions to be
1093 dynamically loaded.
1094 (init_zlib_functions) [WINDOWSNT]: New function.
1095 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1096 New macros.
1097 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1098 macros instead of invoking the zlib functions directly.
068f9124
SM
1099 (syms_of_decompress): DEFSYM Qzlib_dll.
1100 Staticpro Szlib_available_p.
594a4307 1101
d2e113bc
DA
11022013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1103
1104 Avoid looping over all frame windows to freeze and unfreeze.
1105 * window.h (struct window): Drop frozen_window_start_p.
1106 (freeze_window_starts): Drop prototype.
1107 * frame.h (struct frame): New frozen_window_starts flag.
1108 (FRAME_WINDOWS_FROZEN): New macro.
1109 * window.c (freeze_window_start, freeze_window_starts):
1110 Remove.
1111 (select_window, replace_window): Adjust users.
1112 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1113 (window_frozen_p): New function.
1114 (redisplay_window): Use it.
1115
94fcd171
PE
11162013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 Fix some fd issues when running subprocesses (Bug#15035).
1119 Fix bugs that can leak files or file descriptors on errors.
1120 Don't unlink open temp files, as that's hard for users to diagnose
1121 when things go awry (e.g., temp disk exhausted).
1122 Don't bother to lock temp files. Check for invalid recursion.
1123 * callproc.c (synch_process_fd): Remove. All uses removed.
1124 (synch_process_tempfile): New var or macro.
1125 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1126 New constants.
1127 (record_kill_process): New arg, the temp name. All callers changed.
1128 (delete_temp_file): Now just a simple wrapper around unlink.
1129 (call_process_kill): New arg, the call_process_fd array.
1130 Close them all. Clear synch_process_pid. Remove the temp file,
1131 or arrange for it to be removed.
1132 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1133 that's been moved to synch_process_tempfile. Caller changed.
1134 Do not remove the tempfile; that's now call_process_kill's
1135 responsibility.
1136 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1137 call_process_kill; the caller now does that.
1138 (call_process_cleanup): Do not close the process fd; that's now
1139 call_process_kill's responsibility.
1140 (Fcall_process): Implement via new function call_process, which
1141 has most of the old body of Fcall_process, but with a different API.
1142 (call_process): New function that does not open or close filefd if
1143 it is nonnegative. Record which fds need to be closed, and let
1144 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1145 Signal an error if invoked recursively (could be done via a hook).
1146 Simplify creation of the tempfile in the MSDOS case.
1147 Don't create the output file until after checking for the executable.
1148 Report any failure to open /dev/null.
1149 Don't open /dev/null for writing twice; once is enough.
1150 Don't create pipe if all output is being discarded or sent to file.
1151 Don't worry about setting up the coding system or reading from the
1152 pipe if all output is being discarded.
1153 Hoist fd_error local into top level, to lessen block nesting.
1154 Don't record deleted pid here; now done by Fcall_process_region.
1155 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1156 and note its success in synch_process_tempfile.
1157 Do not leak resources when child_setup fails.
1158 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1159 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1160 (create_temp_file): Now returns open fd, with an additional
1161 Lisp_Object * argument to return the name. All callers changed.
1162 Do not close the file; rewind it instead, and leave it open for
1163 the caller. Do not lock the temp file. Unwind-protect the file
1164 and the file-descriptor.
1165 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1166 If an asynchrounous process, record it here, not in call_process.
1167 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1168 * eval.c (set_unwind_protect): New function.
1169 * fileio.c (write_region): New function, generalized from the
1170 old Fwrite_region. Do not lock temp files.
1171 (Fwrite_region): Use it.
1172 * lisp.h (set_unwind_protect, write_region): New decls.
1173 * process.c: Include <verify.h>.
1174 (make_process): Mark fds as initially closed.
1175 (deleted_pid_list): Now a list of pid-filename pairs.
1176 All uses changed.
1177 (close_process_fd): New function.
1178 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1179 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1180 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1181 (create_process, create_pty, Fmake_serial_process)
1182 (server_accept_connection): Record which fds need to be closed,
1183 and let deactivate_process close them.
1184 (Fmake_network_process): Do not discard the unwind-protect
1185 until it's safe to do so.
1186 (deactivate_process): Close the fds opened by create_process etc.
1187 (Fprocess_send_eof): Adjust to new way of recording open fds.
1188 Report an error if /dev/null can't be opened, instead of aborting.
1189 * process.h (PROCESS_OPEN_FDS): New constant.
1190 (struct Lisp_Process): New member open_fds.
1191 (record_kill_process, record_deleted_pid): Adjust signatures.
1192 (record_deleted_pid): Move decl here ...
1193 * syswait.h (record_deleted_pid): ... from here.
1194
d0e615c3
PE
11952013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 * decompress.c: Fix bugs with large buffers and weird inputs.
1198 Tune a bit. Reindent as per usual Emacs style.
1199 (BUFFER_SIZE): Remove.
1200 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1201 more than UINT_MAX bytes. Decompress into the gap instead of into
1202 an auto buffer, as this should avoid copying. Return nil if
1203 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1204 set immediate_quit; we shouldn't trust zlib code that much.
1205
313546eb
LMI
12062013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1207
99a32242
LMI
1208 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1209 errors, and really move the gap to where we want it.
1210
313546eb
LMI
1211 * lisp.h: Include decompress.c support.
1212
1213 * emacs.c (main): Include decompress.c support.
1214
1215 * Makefile.in: Include -lz if present.
1216
d2d699ac
JD
12172013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1218
f90e3ebd
JD
1219 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1220 (initWithTitle:): Initialize frame to 0.
1221 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1222 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1223 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1224
1225 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1226 fillWithWidgetValue:frame:
1227
423d3b3f
JD
1228 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1229 remove memory leak warnings.
1230
d2d699ac
JD
1231 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1232 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1233 menu_pending_title.
1234
1235 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1236 (x_activate_menubar): Update the whole menu.
1237 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1238 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1239 current event is not NSSystemDefined (Bug#15001).
1240 Call ns_check_menu_open only if trackingMenu is 2.
1241 (menuDidClose:): New method, decrease trackingMenu.
1242 (fillWithWidgetValue:setDelegate:): New method.
1243 (fillWithWidgetValue:): Call the above.
1244
1245 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1246
7d652d97
PE
12472013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 Omit some unnecessary casts.
1250 Many of these go back to the old pre-C89 days, when they may have
1251 been needed, but we've been assuming C89 or later for a while now.
1252 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1253 (live_float_p, live_misc_p, live_vector_p):
1254 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1255 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1256 (defvar_per_buffer):
1257 * callint.c (Fcall_interactively):
1258 * doc.c (Fsubstitute_command_keys):
1259 * filelock.c (get_boot_time):
1260 * frame.c (xrdb_get_resource):
1261 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1262 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1263 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1264 (menuitem_highlight_callback, menu_destroy_callback)
1265 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1266 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1267 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1268 (xg_tool_bar_help_callback, tb_size_cb):
1269 * image.c (xpm_alloc_color, png_read_from_memory)
1270 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1271 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1272 (syms_of_image):
1273 * keymap.c (describe_map):
1274 * nsfns.m (Fns_display_monitor_attributes_list):
1275 * nsmenu.m (process_dialog:):
1276 * nsterm.m (hold_event):
1277 * process.c (wait_reading_process_output):
1278 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1279 * scroll.c (do_direct_scrolling, scrolling_1):
1280 * termcap.c (tgetent):
1281 * window.c (check_window_containing, add_window_to_list)
1282 (freeze_window_starts):
1283 * xdisp.c (compare_overlay_entries, vmessage):
1284 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1285 (x_get_monitor_attributes_xrandr)
1286 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1287 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1288 * xfont.c (xfont_match, xfont_open):
1289 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1290 (menubar_selection_callback, menu_position_func)
1291 (popup_selection_callback, create_and_show_popup_menu)
1292 (dialog_selection_callback, create_and_show_dialog):
1293 * xrdb.c (x_get_string_resource):
1294 (main) [TESTRM]:
1295 * xsmfns.c (x_session_check_input):
1296 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1297 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1298 (xaw_jump_callback, xaw_scroll_callback):
1299 Omit unnecessary casts.
1300
9acc1074
PE
13012013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 Minor string-length refactoring.
1304 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1305 * frame.c (make_monitor_attribute_list):
1306 Prefer build_string to strlen + make_string.
1307
361c0eb8
JD
13082013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1309
1310 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1311 don't check minor_code (Bug#14417).
1312
14ba0822
EZ
13132013-08-09 Eli Zaretskii <eliz@gnu.org>
1314
1315 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1316 vertical positions instead. This avoids calling MATRIX_ROW with
1317 row numbers that are possibly beyond valid limits. (Bug#15064)
1318
309f24d1
DA
13192013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1320
1321 Use xstrdup and build_unibyte_string where applicable.
1322 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1323 * xfns.c (x_window):
1324 * xrdb.c (x_get_customization_string):
1325 * xterm.c (xim_initialize):
1326 * w32fns.c (w32_window): Use xstrdup.
1327 (w32_display_monitor_attributes_list):
1328 * emacs.c (init_cmdargs):
1329 * keyboard.c (PUSH_C_STR):
1330 * nsfont.m (nsfont_open):
1331 * sysdep.c (system_process_attributes):
1332 * w32.c (system_process_attributes):
1333 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1334
55902276
EZ
13352013-08-09 Eli Zaretskii <eliz@gnu.org>
1336
1337 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1338 variables of these types so that GDB would know about them, as aid
1339 for debugging fatal exceptions. (Bug#15024) See also
1340 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1341 discussions.
1342
10bf7f5a
JD
13432013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1344
1345 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1346 larger than the NSWindow (Bug#14934).
1347
65620264
DA
13482013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1349
1350 Redesign redisplay interface to drop global variable updated_window.
1351 Always pass currently updated window as a parameter to update routines.
1352 * dispextern.h (updated_window): Remove declaration.
1353 (struct redisplay_interface): Pass window parameter to
1354 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1355 and after_update_window_hook.
1356 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1357 Adjust prototypes.
1358 * dispnew.c (updated_window): Remove.
1359 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1360 (update_window_line): Adjust to match redisplay interface changes.
1361 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1362 (ns_scroll_run, ns_after_update_window_line):
1363 * w32term.c (x_update_window_begin, x_update_window_end)
1364 (x_after_update_window_line, x_scroll_run):
1365 * xterm.c (x_update_window_begin, x_update_window_end)
1366 (x_after_update_window_line, x_scroll_run):
1367 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1368 Likewise. Adjust comments where appropriate.
1369 (x_cursor_to): Simplify because this is always called during window
1370 update (but install debugging check anyway).
1371 (expose_window): Check must_be_updated_p flag to see whether this
1372 function is called during window update.
1373
628fdc56
DA
13742013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1375
1376 Do not reset window modification event counters excessively.
1377 These leftovers and poor man's tricky methods to catch extra
1378 redisplay's attention are no longer needed.
1379 * frame.c (set_menu_bar_lines_1):
1380 * minibuf.c (read_minibuf_unwind):
1381 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1382 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1383 (window_scroll_line_based, Fset_window_configuration):
1384 * xdisp.c (redisplay_window): Do not reset last_modified and
1385 last_overlay_modified counters.
1386
8fd9c92e
JD
13872013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1388
1389 * xselect.c (x_send_client_event): Set send_event and serial, memset
1390 data.l as it might be bigger than data.b. Use 24 bit mask to
1391 XSendEvent (Bug#15034).
1392
0ee18172
EZ
13932013-08-07 Eli Zaretskii <eliz@gnu.org>
1394
1395 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1396 for TTY frames that are not the top frame on their console.
1397 (Bug#14616)
1398
16ddd1a6
MR
13992013-08-07 Martin Rudalics <rudalics@gmx.at>
1400
1401 * w32term.c (w32fullscreen_hook): Really maximize frame when
1402 asked for (Bug#14841).
1403
d2a95ffb
DA
14042013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1405
1406 Prefer selected_window to Fselected_window, likewise for frames.
1407 * buffer.c (Fbuffer_swap_text):
1408 * data.c (Fvariable_binding_locus):
1409 * window.c (run_window_configuration_change_hook): Adjust users.
1410 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1411 Use decode_live_frame.
1412
170da1ec
DA
14132013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1414
1415 Be more careful if selected window shows the buffer other than current,
1416 use window_outdated only if this is not so. This change should also
1417 address some weird issues discussed in Bug#13012.
1418 * window.h (window_outdated): New prototype.
1419 * window.c (window_outdated): Now here. Convert from static and
1420 always assume window's buffer.
1421 (Fwindow_end, Fwindow_line_height): Use it.
1422 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1423 and always assume window's buffer.
1424 (redisplay_window): Adjust user.
e5eefe9b 1425 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1426 check whether mode line should be updated only if selected window
1427 shows current buffer.
1428 (run_window_scroll_functions): Use eassert for debugging check.
1429 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1430
56b5d5b1
DA
14312013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1432
1433 * window.c (window_scroll, window_scroll_pixel_based)
1434 (window_scroll_line_based): Use bool for booleans.
1435
2878ba7e
PE
14362013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 * process.c: Fix minor off-by-one issues in descriptor counts.
1439 This shouldn't fix any real bugs, but it cleans up the code a bit.
1440 (max_process_desc, max_input_desc): -1, not 0, means none.
1441 All uses changed.
1442 (delete_input_desc): New function.
1443 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1444 (deactivate_process): Scan backwards when recomuting max_process_desc;
1445 that should be faster.
1446 (init_process_emacs): Initialize max_input_desc.
1447
e30b79c1
DA
14482013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1449
1450 Use region cache to speedup bidi_find_paragraph_start.
1451 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1452 Rename cache_long_line_scans to cache_long_scans.
1453 * buffer.c (bset_cache_long_line_scans): Rename to
1454 bset_cache_long_scans.
1455 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1456 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1457 into account.
1458 (syms_of_buffer): Rename cache-long-line-scans to
1459 cache-long-scans. Adjust docstring.
1460 * search.c (newline_cache_on_off):
1461 * indent.c (width_run_cache_on_off): Adjust users.
1462 * bidi.c (bidi_paragraph_cache_on_off): New function.
1463 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1464 * insdel.c (prepare_to_modify_buffer):
1465 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1466
00012b86
DA
14672013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1468
1469 Invalidate region caches only if buffer text is going to be changed.
1470 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1471 (modify_text): ...new prototype.
1472 (prepare_to_modify_buffer_1): New prototype.
1473 * textprop.c (modify_region): Rename to...
1474 (modify_text_properties): ...new function.
1475 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1476 (Fremove_list_of_text_properties): Adjust users.
1477 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1478 (modify_text): ...new function.
1479 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1480 (prepare_to_modify_buffer_1): ...new function.
1481 * casefiddle.c (casify_region):
1482 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1483 (Ftranspose_regions): Use modify_text.
1484
dc6c0eda
SM
14852013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1486
1487 * lisp.mk (lisp): Add nadvice.elc.
1488
8f3a2c26
DA
14892013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1490
1491 New macro to iterate over live buffers similar to frames.
1492 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1493 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1494 Declare buffer-related variables here to offload lisp.h.
1495 * buffer.c (Vbuffer_alist): Adjust comment.
1496 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1497 (other_buffer_safely):
1498 * data.c (store_symval_forwarding):
1499 * dispnew.c (Fframe_or_buffer_changed_p):
1500 * fileio.c (Fdo_auto_save):
1501 * filelock.c (unlock_all_files):
1502 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1503
e0fdb694
PE
15042013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1507 * callproc.c (create_temp_file):
1508 * filelock.c (create_lock_file):
1509 Assume mkostemp, since it's now provided by Gnulib.
1510
63f5c6c2
EZ
15112013-08-04 Eli Zaretskii <eliz@gnu.org>
1512
1513 * w32.c (mkostemp): New function.
1514 (mktemp): Remove, no longer used. Most of the code reused in
1515 mkostemp. (Bug#15015)
484ab239 1516 (mktemp): Don't undef.
63f5c6c2 1517
f0b79313
DA
15182013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1519
1520 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1521 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1522 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1523 (free_glyph_pool, check_glyph_memory): Likewise for
1524 all users. Adjust comments where appropriate.
1525
98f638d6
PE
15262013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 * composite.h: Minor fixups.
1529 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1530 to fix a misspelling, and change it to an inline function while
1531 we're at it (it need not be a macro). All uses changed.
1532 (composition_method, composition_valid_p):
1533 Rewrite to avoid assignments in if-conditions.
1534
75c59fb3
DA
15352013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1536
1537 Do not use global Lisp_Object in composition macros.
1538 * composite.h (composition_temp): Remove declaration.
1539 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1540 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1541 (compose_region): Remove the leftover.
75c59fb3
DA
1542 * composite.c (composition_temp): Remove.
1543 (run_composition_function, update_compositions)
1544 (composition_compute_stop_pos, composition_adjust_point)
1545 (Ffind_composition_internal):
1546 * coding.c (handle_composition_annotation):
1547 * xdisp.c (handle_composition_prop, check_point_in_composition):
1548 Related users changed.
1549
a10c8269
DA
15502013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1551
1552 Drop FRAME_PTR typedef.
1553 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1554 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1555 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1556 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1557 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1558 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1559 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1560 All related users changed.
1561
a104f656
SM
15622013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1563
1564 * eval.c (default_toplevel_binding): New function.
1565 (Fdefvar): Use it.
1566 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1567 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1568 (syms_of_eval): Export them.
1569 * data.c (Fdefault_value): Micro cleanup.
1570 * term.c (init_tty): Use "false".
1571
4b5c9326
DA
15722013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1573
1574 Fix X GC leak in GTK and raw (no toolkit) X ports.
1575 * xterm.c (x_free_frame_resources): If white and black relief
1576 GCs are allocated, always free them here.
1577 * xfns.c (x_make_gc): Omit redundant initialization.
1578 * widget.c (create_frame_gcs): Remove the leftover.
1579 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1580 in x_free_frame_resources.
1581
b19aa636
JD
15822013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1583
1584 * nsterm.m (windowWillResize:toSize:): Only change title if
1585 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1586 modifying it.
1587 (viewDidEndLiveResize): New method.
1588
1589 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1590 inside NS_IMPL_COCOA.
1591
af1f7e06
DA
15922013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1593
1594 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1595 Do not check whether undo is enabled because record_insert and
1596 record_delete does that themselves.
1597
65b02bb9
DA
15982013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1599
1600 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1601 member which is not really used any more.
1602 (FRAME_XIC_BASE_FONTNAME): Remove.
1603 * xfns.c (xic_free_fontset): Adjust user.
1604 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1605 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1606 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1607 (xdialog_show): Use eassert for debugging check.
7ee0f047 1608 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1609
6318cde0
PE
16102013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1611
1612 * fileio.c, fns.c (merge): Move extern decl from here ...
1613 * lisp.h (merge): ... to here.
1614
6c1a09ba
DA
16152013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1616
1617 Fix last font-related change.
1618 * w32font.h (w32font_list_internal, w32font_match_internal):
1619 Fix prototype.
1620 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1621 (uniscribe_list_family): Adjust to match font API change.
1622 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1623 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1624
f8c20208
DA
16252013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1626
1627 * frame.h (FRAME_MOUSE_UPDATE):
1628 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1629 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1630
fdb396e2
DA
16312013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1632
1633 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1634 * font.h (struct font_driver): Change list, match, and list_family
1635 functions to accept struct frame * as first arg.
068f9124
SM
1636 * font.c (font_score, font_compare, font_sort_entities):
1637 Remove prototypes.
fdb396e2
DA
1638 (font_sort_entities, font_list_entities, font_select_entity):
1639 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1640 match font API change.
1641 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1642 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1643 * ftxfont.c (ftxfont_list, ftxfont_match):
1644 * xftfont.c (xftfont_list, xftfont_match):
1645 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1646 * w32font.c (w32font_list, w32font_match, w32font_list):
1647 (w32font_list_internal, w32_font_match_internal): Likewise.
1648 * xfaces.c (Fx_family_fonts): Adjust user.
1649
52b8a085
DA
16502013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1651
1652 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1653 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1654 only if HAVE_X_WINDOWS is in use.
1655 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1656 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1657 * w32term.c (x_wm_set_icon_position): Likewise.
1658 * w32fns.c (x_icon): Adjust user.
1659
c791c18e
DA
16602013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1661
1662 * xterm.c (last_mouse_press_frame): Remove the
1663 leftover which is not really used any more.
1664 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1665 (x_flush): Call XFlush once per each X display, not frame.
1666 This is better because this code always unconditionally skips
1667 non-X frames in Vframe_list and issues the only XFlush if we
1668 have more than one X frame on the same X display.
2f935d86
DA
1669 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1670 Use bool for booleans.
1671 (x_draw_glyph_string_background, cvt_string_to_pixel):
1672 (cvt_pixel_dtor): Drop unnecessary prototypes.
1673 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1674
f435830e
DA
16752013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1676
1677 Drop unnecessary functions that deals with frame pixel size.
1678 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1679 (x_pixel_height): Drop prototypes.
1680 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1681 (x_pixel_height): Drop implementations.
1682 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1683 which should be always valid for window frame.
1684 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1685 * w32menu.c (Fx_popup_dialog):
1686 * xmenu.c (Fx_popup_dialog): Likewise for both.
1687
84231434
DA
16882013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1689
1690 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1691 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1692 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1693 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1694 and mention nil frame in docstring.
84231434 1695
959067a1
DA
16962013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1697
1698 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1699 (x_figure_window_size): Likewise. Adjust to return long.
1700 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1701 (toplevel): Move Qterminal_live_p to...
1702 * terminal.c (toplevel): ...here, make it static, and...
1703 (syms_of_terminal): ...DEFSYM here.
1704 * frame.h (Qterminal_live_p): Remove declaration.
1705 (make_frame, x_figure_window_size): Adjust prototype.
1706 * nsfns.m (Fx_create_frame): Use long for window flags.
1707
f4b169ce
PE
17082013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1711 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1712 Do not assume that emacs_close (INT_MAX) is a no-op.
1713
bee6a2c7
DA
17142013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1715
1716 * xfaces.c (make_face_cache): For struct face_cache, prefer
1717 xmalloc to xzalloc and so avoid redundant call to memset.
1718 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1719
d7e6881a
DA
17202013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1721
1722 * fringe.c (draw_window_fringes, update_window_fringes)
1723 (compute_fringe_widths):
1724 * w32term.c (x_draw_glyph_string):
1725 * window.c (candidate_window_p, Frecenter):
1726 * xfaces.c (realize_basic_faces, realize_default_face)
1727 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1728 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1729 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1730 * xmenu.c (Fx_menu_bar_open_internal):
1731 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1732 * xsettings.c (xft_settings_event):
1733 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1734 Use bool for booleans. Adjust style and comments where
1735 appropriate.
1736 * dispextern.h (draw_window_fringes, update_window_fringes)
1737 (compute_fringe_widths):
1738 * xterm.h (x_had_errors_p): Adjust prototype.
1739
ec3058af
DA
17402013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1741
1742 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1743 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1744
218e0637
DA
17452013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1746
1747 * fns.c (toplevel): Remove comment before Fsafe_length because
1748 it checks for QUIT.
1749
e560aba9
PE
17502013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1753
2e5ce5de
EZ
17542013-07-28 Eli Zaretskii <eliz@gnu.org>
1755
1756 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1757 frame which got the message is still alive, before dereferencing
1758 its pointer. (Bug#14970)
1759
1760 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1761 be a live window, before using it as such. (Bug#14970)
1762
e95da6d3
EZ
17632013-07-27 Eli Zaretskii <eliz@gnu.org>
1764
1765 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1766 w32_detect_focus_change instead of doing part of its job by hand.
1767 This fixes the problem whereby FOCUS_OUT events were not sent to
1768 the event queue.
1769
a8f93651
EZ
17702013-07-26 Eli Zaretskii <eliz@gnu.org>
1771
fec92060
EZ
1772 * process.c (Fprocess_list): Doc fix.
1773
a8f93651
EZ
1774 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1775 being re-exposed only if it didn't ask to become visible.
1776 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1777 was previously iconified. (Bug#14841)
1778 (x_iconify_frame): Mark the frame iconified.
1779
d5a7a9d9
PE
17802013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 Fix minor problems found by static checking.
1783 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1784 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1785
56ea7291
SM
17862013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1787
1788 * eval.c (set_specpdl_old_value): New function.
1789 (unbind_to): Minor simplification.
1790 (get_backtrace_frame): New function.
1791 (Fbacktrace_frame): Use it. Add `base' argument.
1792 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1793 (syms_of_eval): Export backtrace-eval.
1794 * xterm.c (x_focus_changed): Simplify.
1795
9d611ffe
PE
17962013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1799
999c74e3
EZ
18002013-07-24 Eli Zaretskii <eliz@gnu.org>
1801
1802 * xdisp.c (redisplay_window): Instead of moving point out of
1803 scroll margin, reject the force_start method, and try scrolling
1804 instead. (Bug#14780)
1805
198fa217
KB
18062013-07-24 Ken Brown <kbrown@cornell.edu>
1807
1808 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1809 (Bug#14944).
1810
53840e55
PE
18112013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 * eval.c (Fprogn): Do not check that BODY is a proper list.
1814 This undoes the previous change. The check slows down the
1815 interpreter, and is not needed to prevent a crash. See
1816 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1817
60967f56
GM
18182013-07-23 Glenn Morris <rgm@gnu.org>
1819
1820 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1821
9ca960e2
PE
18222013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1823
a29c3e6d
PE
1824 Port to GNU/Linux systems with tinfo but not ncurses.
1825 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1826 to decide whether ncurses is being used. Without this change,
1827 GCC complains about tgetent not being declared, on a system
1828 that has tinfo installed but ncurses not installed.
1829
f274311c
PE
1830 * eval.c (Fprogn): Check that BODY is a proper list.
1831
16b0520a
PE
1832 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1833 * data.c (Fsetq_default):
1834 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1835 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1836 (Fcondition_case):
1837 Tune by taking advantage of the fact that ARGS is always a list
1838 when a function is declared to have UNEVALLED args.
1839
9ca960e2
PE
1840 * emacsgtkfixed.c: Port to GCC 4.6.
1841 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1842
afacaa1b
JB
18432013-07-23 Juanma Barranquero <lekktu@gmail.com>
1844
1845 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1846 here to silence compiler warnings.
1847
368a85a4
PE
18482013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1849
1850 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1851 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1852 from messing up Emacs's 'struct frame' (Bug#14923).
1853
f4e891b5
PE
18542013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1855
1856 * alloc.c (make_save_ptr_ptr): Define this function.
1857 It was inadvertently omitted. It's needed only if
1858 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1859
96c8b65e
JD
18602013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1861
1862 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1863 frame have focus (Bug#14895).
1864
ee010797
PE
18652013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 Avoid vfork-related deadlock more cleanly.
1868 * callproc.c (child_setup): When the child's exec fails, output
1869 the program name, as that's more useful. Use O_NONBLOCK to avoid
1870 deadlock.
1871 * process.c (create_process_1): Remove; no longer needed.
1872 (create_process): Remove timer hack; no longer needed, now that
1873 the child avoids deadlock.
1874
f0398ec1 18752013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1876
1877 * image.c (Fimage_flush): Fix doc typo.
1878
b2a069c2
PE
18792013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1880
6496aec9
PE
1881 Fix array bounds violation when pty allocation fails.
1882 * process.c (PTY_NAME_SIZE): New constant.
1883 (pty_name): Remove static variable; it's now auto.
1884 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1885 Take pty_name as an arg rather than using a static variable.
1886 All callers changed.
1887 (create_process): Recover pty_flag from process, not from volatile local.
1888 (create_pty): Stay inside array even when pty allocation fails.
1889 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1890
b2a069c2
PE
1891 * lread.c (Fload): Avoid initialization only when lint checking.
1892 Mention that it's needed only for older GCCs.
1893
99107004
KH
18942013-07-20 Kenichi Handa <handa@gnu.org>
1895
1896 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1897 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1898
6b1b199d
AS
18992013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1900
1901 * lread.c (Fload): Avoid uninitialized warning.
1902
4195afc3
PE
19032013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1904
3f5bef16
PE
1905 Fix some minor file descriptor leaks and related glitches.
1906 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1907 (create_lock_file): Use write, not emacs_write.
1908 * image.c (slurp_file, png_load_body):
1909 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1910 (server_accept_connection):
1911 Don't leak an fd on memory allocation failure.
1912 * image.c (slurp_file): Add a cheap heuristic for growing files.
1913 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1914 as that's what the other routines do. Maybe input need not be
1915 blocked at all, but it's better to be consistent.
1916 Avoid undefined behavior when strlen is zero.
1917
4195afc3
PE
1918 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1919 (NSTATICS): Now a constant; doesn't need to be a macro.
1920
a1aeeffe
RS
19212013-07-19 Richard Stallman <rms@gnu.org>
1922
1923 * coding.c (decode_coding_utf_8): Add simple loop for fast
1924 processing of ASCII characters.
1925
63b34baa
PE
19262013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1929
621dd9ac
EZ
19302013-07-19 Eli Zaretskii <eliz@gnu.org>
1931
1932 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1933 unportable 'struct x_display_info'.
1934 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1935 is a portable type.
1936
1396ac86
PE
19372013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1938
ab9980cd
PE
1939 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1940 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1941 or fscanf fails.
1942 (system_process_attributes): Prefer plain char to unsigned char
1943 when either will do. Clean up properly if interrupted or if
068f9124
SM
1944 memory allocations fail. Don't assume sscanf succeeds.
1945 Remove no-longer-needed workaround to stop GCC from whining.
1946 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1947 bit more carefully.
1948
1396ac86
PE
1949 Fix obscure porting bug with varargs functions.
1950 The code assumed that int is treated like ptrdiff_t in a vararg
1951 function, which is not a portable assumption. There was a similar
1952 -- though these days less likely -- porting problem with various
1953 assumptions that pointers of different types all smell the same as
1954 far as vararg functions is conserved. To make this problem less
1955 likely in the future, redo the API to use varargs functions.
1956 * alloc.c (make_save_value): Remove this vararg function.
1957 All uses changed to ...
1958 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1959 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1960 New functions.
1961 (make_save_ptr): Rename from make_save_pointer, for consistency with
1962 the above. Define only on platforms that need it. All uses changed.
1963
4d19d194
PE
19642013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 * keyboard.c: Try to fix typos in previous change.
1967 (DISPLAY_LIST_INFO): New macro.
1968 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1969 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1970
945c5bb1
JB
19712013-07-18 Juanma Barranquero <lekktu@gmail.com>
1972
1973 * keyboard.c (kbd_buffer_get_event):
1974 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1975 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1976
f4b1eb36
PE
19772013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1978
5e679a2c
PE
1979 * filelock.c: Fix unlikely file descriptor leaks.
1980 (get_boot_time_1): Rework to avoid using emacs_open.
1981 This doesn't actually fix a leak, but is better anyway.
1982 (read_lock_data): Use read, not emacs_read.
1983
a8cd4836
PE
1984 * doc.c: Fix minor memory and file descriptor leaks.
1985 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1986 (get_doc_string, Fsnarf_documentation):
1987 Fix file descriptor leak on error.
1988
ef30e638
PE
1989 * term.c: Fix minor fdopen-related file descriptor leaks.
1990 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1991 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1992
f4b1eb36
PE
1993 * charset.c: Fix file descriptor leaks and errno issues.
1994 Include <errno.h>.
1995 (load_charset_map_from_file): Don't leak file descriptor on error.
1996 Use plain record_xmalloc since the allocation is larger than
1997 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1998 of entries.
1999 * eval.c (record_unwind_protect_nothing):
2000 * fileio.c (fclose_unwind):
2001 New functions.
2002 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2003 The replacement doesn't block input, but that no longer seems
2004 necessary.
2005
b648c163
PE
20062013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2007
a0931322
PE
2008 * lread.c: Fix file descriptor leaks and errno issues.
2009 (Fload): Close some races that leaked fds or streams when 'load'
2010 was interrupted.
2011 (Fload, openp): Report error number of last nontrivial failure to open.
2012 ENOENT counts as trivial.
2013 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2014 New functions.
2015 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2016 now that the function is always called with a nonnegative arg.
2017 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2018 All uses replaced with ...
2019 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2020
b648c163
PE
2021 A few more minor file errno-reporting bugs.
2022 * callproc.c (Fcall_process):
2023 * doc.c (Fsnarf_documentation):
2024 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2025 * process.c (set_socket_option):
2026 Don't let a constructor trash errno.
2027 * doc.c: Include <errno.h>.
2028
b1dc4084
JB
20292013-07-16 Juanma Barranquero <lekktu@gmail.com>
2030
2031 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2032
c43843aa
PE
20332013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2034
50a30cce
PE
2035 Fix w32 bug with call-process-region (Bug#14885).
2036 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2037 to Fcall_process when the input is empty. This simplifies the
2038 code a bit. It makes no difference on POSIXish platforms but
2039 apparently it fixes a bug on w32.
2040
44e18199 2041 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2042 * fileio.c (close_file_unwind): Don't close if FD is negative;
2043 this can happen when unwinding a zapped file descriptor.
2044 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2045 in case Emacs runs out of memory between the two unwind-protects.
2046 Don't trash errno when closing FD.
2047 Zap the FD in the specpdl when closing it, instead of deferring
2048 the removal of the unwind-protect; this fixes a bug where a child
2049 function unwinds the stack past us.
2050
27e498e6
PE
2051 New unwind-protect flavors to better type-check C callbacks.
2052 This also lessens the need to write wrappers for callbacks,
2053 and the need for make_save_pointer.
2054 * alloca.c (free_save_value):
2055 * atimer.c (run_all_atimers):
2056 Now extern.
2057 * alloc.c (safe_alloca_unwind):
2058 * atimer.c (unwind_stop_other_atimers):
2059 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2060 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2061 * minibuf.c (choose_minibuf_frame_1):
2062 * process.c (make_serial_process_unwind):
2063 * xdisp.h (pop_message_unwind):
2064 * xselect.c (queue_selection_requests_unwind):
2065 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2066 * alloca.c (record_xmalloc):
2067 Prefer record_unwind_protect_ptr to record_unwind_protect with
2068 make_save_pointer.
2069 * alloca.c (Fgarbage_collect):
2070 Prefer record_unwind_protect_void to passing a dummy.
2071 * buffer.c (restore_buffer):
2072 * window.c (restore_window_configuration):
2073 * xfns.c, w32fns.c (do_unwind_create_frame)
2074 New wrapper. All record-unwind uses of wrappee changed.
2075 * buffer.c (set_buffer_if_live):
2076 * callproc.c (call_process_cleanup, delete_temp_file):
2077 * coding.c (code_conversion_restore):
2078 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2079 * editfns.c (save_excursion_restore)
2080 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2081 (save_restriction_restore):
2082 * eval.c (restore_stack_limits, un_autoload):
2083 * fns.c (require_unwind):
2084 * keyboard.c (recursive_edit_unwind, tracking_off):
2085 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2086 * macros.c (pop_kbd_macro, restore_menu_items):
2087 * nsfns.m (unwind_create_frame):
2088 * print.c (print_unwind):
2089 * process.c (start_process_unwind):
2090 * search.c (unwind_set_match_data):
2091 * window.c (select_window_norecord, select_frame_norecord):
2092 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2093 (fast_set_selected_frame):
2094 * xfns.c, w32fns.c (unwind_create_tip_frame):
2095 Return void, not a dummy Lisp_Object. All uses changed.
2096 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2097 * callproc.c (call_process_kill):
2098 * fileio.c (restore_point_unwind, decide_coding_unwind)
2099 (build_annotations_unwind):
2100 * insdel.c (Fcombine_after_change_execute_1):
2101 * keyboard.c (read_char_help_form_unwind):
2102 * menu.c (unuse_menu_items):
2103 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2104 * sound.c (sound_cleanup):
2105 * xdisp.c (unwind_redisplay):
2106 * xfns.c (clean_up_dialog):
2107 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2108 Accept no args and return void, instead of accepting and returning
2109 a dummy Lisp_Object. All uses changed.
2110 * cygw32.c (fchdir_unwind):
2111 * fileio.c (close_file_unwind):
2112 * keyboard.c (restore_kboard_configuration):
2113 * lread.c (readevalllop_1):
2114 * process.c (wait_reading_process_output_unwind):
2115 Accept int and return void, rather than accepting an Emacs integer
2116 and returning a dummy object. In some cases this fixes an
2117 unlikely bug when the corresponding int is outside Emacs integer
2118 range. All uses changed.
2119 * dired.c (directory_files_internal_unwind):
2120 * fileio.c (do_auto_save_unwind):
2121 * gtkutil.c (pop_down_dialog):
2122 * insdel.c (reset_var_on_error):
2123 * lread.c (load_unwind):
2124 * xfns.c (clean_up_file_dialog):
2125 * xmenu.c, nsmenu.m (pop_down_menu):
2126 * xmenu.c (cleanup_widget_value_tree):
2127 * xselect.c (wait_for_property_change_unwind):
2128 Accept pointer and return void, rather than accepting an Emacs
2129 save value encapsulating the pointer and returning a dummy object.
2130 All uses changed.
2131 * editfns.c (Fformat): Update the saved pointer directly via
2132 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2133 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2134 (unwind_body): New function.
2135 (record_unwind_protect): First arg is now a function returning void,
2136 not a dummy Lisp_Object.
2137 (record_unwind_protect_ptr, record_unwind_protect_int)
2138 (record_unwind_protect_void): New functions.
2139 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2140 * fileio.c (struct auto_save_unwind): New type.
2141 (do_auto_save_unwind): Use it.
2142 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2143 * insdel.c (struct rvoe_arg): New type.
2144 (reset_var_on_error): Use it.
2145 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2146 New constants.
2147 (specbinding_func): Remove; there are now several such functions.
2148 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2149 (set_unwind_protect_ptr): New function.
2150 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2151
4e604a5d
PE
2152 Be simpler and more consistent about reporting I/O errors.
2153 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2154 Say "Read error" and "Write error", rather than "I/O error", or
2155 "IO error reading", or "IO error writing", when a read or write
2156 error occurs.
2157 * process.c (Fmake_network_process, wait_reading_process_output)
2158 (send_process, Fprocess_send_eof, wait_reading_process_output):
2159 Capitalize diagnostics consistently. Put "failed foo" at the
2160 start of the diagnostic, so that we don't capitalize the
2161 function name "foo". Consistently say "failed" for such
2162 diagnostics.
2163 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2164 All callers changed. This is so it can use report_file_error.
2165 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2166 diagnostics consistently as above.
2167
a9757f6a
PE
2168 * fileio.c (report_file_errno): Fix errno reporting bug.
2169 If the file name is neither null nor a pair, package it up as a
2170 singleton list. All callers changed, both to this function and to
2171 report_file_error. This fixes a bug where the memory allocator
2172 invoked by list1 set errno so that the immediately following
2173 report_file_error reported the wrong errno value.
2174
c43843aa
PE
2175 Fix minor problems found by --enable-gcc-warnings.
2176 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2177 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2178
18c26d81
JD
21792013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2180
2181 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2182 Set event->arg to Qt if switch-event shall be generated.
2183 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2184
2185 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2186
2187 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2188 FOCUS_OUT_EVENT.
2189
2190 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2191 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2192 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2193 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2194 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2195 and there is a focused frame.
2196 (head_table): Add focus-in and focus-out.
2197 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2198 bind to handle-focus-in/out.
2199
2200 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2201 (Fhandle_switch_frame): Call Fhandle_focus_in.
2202 (syms_of_frame): defsubr handle-focus-in/out.
2203
6c6f1994
PE
22042013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2205
c7ddc792
PE
2206 Fix porting bug to older POSIXish platforms (Bug#14862).
2207 * sysdep.c (emacs_pipe): New function, that implements
2208 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2209 This should port better to CentOS 5 and to Mac OS X 10.6.
2210 All calls to pipe2 changed.
2211
6c6f1994
PE
2212 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2213 This makes the code easier to read and the executable a bit smaller.
2214 Do not replace all calls to Fcons that happen to create lists,
2215 just calls that are intended to create lists. For example, when
2216 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2217 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2218 Similarly for list2 through list5.
2219 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2220 * bytecode.c (exec_byte_code):
2221 * callint.c (quotify_arg, Fcall_interactively):
2222 * callproc.c (Fcall_process, create_temp_file):
2223 * charset.c (load_charset_map_from_file)
2224 (Fdefine_charset_internal, init_charset):
2225 * coding.c (get_translation_table, detect_coding_system)
2226 (Fcheck_coding_systems_region)
2227 (Fset_terminal_coding_system_internal)
2228 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2229 * composite.c (update_compositions, Ffind_composition_internal):
2230 * dired.c (directory_files_internal, file_name_completion)
2231 (Fsystem_users):
2232 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2233 * doc.c (Fsnarf_documentation):
2234 * editfns.c (Fmessage_box):
2235 * emacs.c (main):
2236 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2237 (Feval, eval_sub, Ffuncall, apply_lambda):
2238 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2239 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2240 (Fset_file_times, Finsert_file_contents)
2241 (Fchoose_write_coding_system, Fwrite_region):
2242 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2243 * font.c (font_registry_charsets, font_parse_fcname)
2244 (font_prepare_cache, font_update_drivers, Flist_fonts):
2245 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2246 * frame.c (make_frame, Fmake_terminal_frame)
2247 (x_set_frame_parameters, x_report_frame_params)
2248 (x_default_parameter, Fx_parse_geometry):
2249 * ftfont.c (syms_of_ftfont):
2250 * image.c (gif_load):
2251 * keyboard.c (command_loop_1):
2252 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2253 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2254 (Fminor_mode_key_binding, accessible_keymaps_1)
2255 (Faccessible_keymaps, Fwhere_is_internal):
2256 * lread.c (read_emacs_mule_char):
2257 * menu.c (find_and_return_menu_selection):
2258 * minibuf.c (get_minibuffer):
2259 * nsfns.m (Fns_perform_service):
2260 * nsfont.m (ns_script_to_charset):
2261 * nsmenu.m (ns_popup_dialog):
2262 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2263 (Fx_own_selection_internal):
2264 * nsterm.m (append2):
2265 * print.c (Fredirect_debugging_output)
2266 (print_prune_string_charset):
2267 * process.c (Fdelete_process, Fprocess_contact)
2268 (Fformat_network_address, set_socket_option)
2269 (read_and_dispose_of_process_output, write_queue_push)
2270 (send_process, exec_sentinel):
2271 * sound.c (Fplay_sound_internal):
2272 * textprop.c (validate_plist, add_properties)
2273 (Fput_text_property, Fadd_face_text_property)
2274 (copy_text_properties, text_property_list, syms_of_textprop):
2275 * unexaix.c (report_error):
2276 * unexcoff.c (report_error):
2277 * unexsol.c (unexec):
2278 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2279 (Fformat_mode_line, syms_of_xdisp):
2280 * xfaces.c (set_font_frame_param)
2281 (Finternal_lisp_face_attribute_values)
2282 (Finternal_merge_in_global_face, syms_of_xfaces):
2283 * xfns.c (x_default_scroll_bar_color_parameter)
2284 (x_default_font_parameter, x_create_tip_frame):
2285 * xfont.c (xfont_supported_scripts):
2286 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2287 (menu_help_callback, xmenu_show):
2288 * xml.c (make_dom):
2289 * xterm.c (set_wm_state):
2290 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2291 and similarly for list2 through list5.
2292
bafe80ce
PE
22932013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * callproc.c (Fcall_process_region): Fix minor race and tune.
2296 (create_temp_file): New function, with the temp-file-creation part
2297 of the old Fcall_process_region. Use Fcopy_sequence to create the
2298 temp file name, rather than alloca + build_string, for simplicity.
2299 Don't bother to block input around the temp file creation;
068f9124
SM
2300 shouldn't be needed. Simplify use of mktemp.
2301 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2302 this closes an unlikely race where the temp file was not removed.
2303 Use memcpy rather than an open-coded loop.
2304 (Fcall_process_region): Use the new function. If the input is
2305 empty, redirect from /dev/null rather than from a newly created
2306 empty temp file; this avoids unnecessary file system traffic.
2307
4700b5a5
PE
23082013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2309
5c97beae
PE
2310 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2311 Simplify by making this case like the other two. This is a bit
2312 slower on obsolete hosts, but the extra complexity isn't worth it.
2313
4700b5a5
PE
2314 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2315 * process.c (create_process) [!DOS_NT]:
2316 Remove now-unnecessary calls to emacs_close.
2317
f9a74c4c
EZ
23182013-07-13 Eli Zaretskii <eliz@gnu.org>
2319
922ae7ee
EZ
2320 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2321 returning early. (Bug#14850)
2322
f9a74c4c
EZ
2323 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2324 and inhibit-iso-escape-detection attributes of 'undecided'.
2325 (Bug#14822)
2326
5e301d76
PE
23272013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2328
69e0e5ee
PE
2329 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2330 Reported by Herbert J. Skuhra in
2331 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2332
5e301d76
PE
2333 Don't lose top specpdl entry when memory is exhausted.
2334 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2335 specpdl overflow here, to simplify callers; all callers changed.
2336 Always reserve an unused entry at the stack top; this avoids
2337 losing the top entry's information when memory is exhausted.
2338
7e649856
PE
23392013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2340
a773ed9a
PE
2341 Clean up errno reporting and fix some errno-reporting bugs.
2342 * callproc.c (Fcall_process):
2343 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2344 * process.c (create_process, Fmake_network_process):
2345 * unexaix.c (report_error):
2346 * unexcoff.c (report_error):
2347 Be more careful about reporting the errno of failed operations.
2348 The code previously reported the wrong errno sometimes.
2349 Also, prefer report_file_errno to setting errno + report_file_error.
2350 (Fcall_process): Look at openp return value rather than at path,
2351 as that's a bit faster and clearer when there's a numeric predicate.
2352 * fileio.c (report_file_errno): New function, with most of the
2353 old contents of report_file_error.
2354 (report_file_error): Use it.
2355 (Ffile_exists_p, Ffile_accessible_directory_p):
2356 Set errno to 0 when it is junk.
2357 * fileio.c (Faccess_file):
2358 * image.c (x_create_bitmap_from_file):
2359 Use faccessat rather than opening the file, to avoid the hassle of
2360 having a file descriptor open.
2361 * lisp.h (report_file_errno): New decl.
2362 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2363
7e649856
PE
2364 Minor EBADF fixes.
2365 * process.c (create_process, wait_reading_process_output) [AIX]:
2366 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2367 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2368 a multithreaded environment anyway).
2369 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2370
f6774c1a
AS
23712013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2372
2373 * image.c (x_find_image_file): Don't close a remote file handle.
2374
bacba3c2
PE
23752013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2376
2377 Fix races with threads and file descriptors.
2378 * callproc.c (Fcall_process_region):
2379 * dired.c (open_directory):
2380 * emacs.c (main, Fdaemon_initialized):
2381 * image.c (x_find_image_file):
2382 * inotify.c (Finotify_rm_watch):
2383 * lread.c (Flocate_file_internal):
2384 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2385 * term.c (term_mouse_moveto, init_tty):
2386 * termcap.c (tgetent):
2387 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2388 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2389 * unexhp9k800.c, unexmacosx.c (unexec):
2390 * callproc.c (Fcall_process_region):
2391 Use emacs_close, not close.
2392 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2393 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2394 and posix_close function on current platforms (which all lack them).
2395 (emacs_close): Use it. This should fix the races on GNU/Linux and
2396 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2397 and it should avoid closing random victim file descriptors on
2398 other platforms.
2399
653d4f43
PE
24002013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2401
c8536ec4
PE
2402 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2403 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2404 Touch up doc a bit.
2405
9c203066
PE
2406 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2407 This is for .gdbinit xbacktrace.
2408
653d4f43
PE
2409 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2410 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2411 (emacs_set_tty): Now static.
2412 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2413 * term.c (tty_capable_p, tty_default_color_capabilities)
2414 (get_tty_terminal, term_mouse_movement)
2415 (handle_one_term_event, init_tty, maybe_fatal):
2416 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2417 (tgetent, scan_file, name_match, compare_contin):
2418 * terminal.c (get_terminal):
2419 Use bool for boolean.
2420 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2421 Prefer char to unsigned char if either will do.
2422 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2423 (tty_write_glyphs): Prefer int to unsigned.
2424 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2425 All callers changed.
2426 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2427
45b683a1
PE
24282013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2429
29abe551
PE
2430 Port to C89.
2431 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2432 (B__dummy__): New dummy symbol, to pacify C89.
2433 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2434 they can't grok varargs macros.
2435 * dispnew.c (add_window_display_history)
2436 (add_frame_display_history):
2437 * print.c (print_object):
2438 * xdisp.c (debug_method_add):
2439 Use %p printf format only for void pointers.
2440 * emacs.c (usage_message): New constant, replacing ...
2441 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2442 (main): Adjust to usage reorg.
2443 * fns.c (syms_of_fns):
2444 * profiler.c (syms_of_profiler):
2445 Don't use non-constant struct initializers.
2446 * gnutls.h (gnutls_initstage_t):
2447 * lisp.h (enum Lisp_Fwd_Type):
2448 * lread.c (lisp_file_lexically_bound_p):
2449 * xsettings.c (anonymous enum):
2450 Remove trailing comma.
2451 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2452 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2453 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2454 (DEFUN): Use it.
2455 * regex.c (const_re_char): New type, to pacify strict C89.
2456 All uses of 'const re_char' replaced to use it.
2457 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2458 with glibc when strict C89. This change is imported from gnulib.
2459 All uses changed.
2460 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2461 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2462 Omit GNU_LINUX implementation, since it requires long long.
2463 * xterm.c (x_draw_underwave):
2464 Do not assume the traditional order of struct's members.
2465 (x_term_init): Rewrite to avoid the need for non-constant structure
2466 initializers.
2467
45b683a1 2468 Syntax cleanup, mostly replacing macros with functions.
763a086d 2469 This removes the need for the syntax_temp hack.
45b683a1
PE
2470 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2471 * syntax.c (SYNTAX_INLINE): New macro.
2472 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2473 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2474 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2475 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2476 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2477 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2478 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2479 Now constants, not macros.
2480 (syntax_temp) [!__GNUC__]: Remove.
2481 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2482 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2483 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2484 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2485 Move here from syntax.h; now functions, not macros. Except for the
2486 last function, these are static since only syntax.c uses them.
2487 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2488 All uses changed. Now a function, not a macro; use this fact
2489 to simplify the code.
2490 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2491 compiler bugs; no longer relevant.
2492 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2493 (SYNTAX_INLINE): New macro.
2494 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2495 for the new functions. Use bool for boolean member.
2496 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2497 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2498 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2499 (SETUP_BUFFER_SYNTAX_TABLE):
2500 Now extern inline functions, not macros.
2501 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2502 Remove; all uses replaced by implementation.
2503 (syntax_temp) [!__GNUC__]: Remove decl.
2504 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2505
29be4a50
JD
25062013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2507
2508 * emacs.c (main): Fix syntax error.
2509
954b166e
PE
25102013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2511
2512 Timestamp fixes for undo (Bug#14824).
2513 * atimer.c (schedule_atimer):
2514 * fileio.c (Ffile_newer_than_file_p):
2515 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2516 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2517 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2518 (syms_of_fileio): Remove Sclear_visited_file_name.
2519 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2520 file doesn't exist; this avoids an ambiguity with negative timestamps.
2521 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2522 * systime.h (make_emacs_time, invalid_emacs_time):
2523 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2524 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2525 * undo.c (record_first_change): Push (visited-file-modtime) onto
2526 undo list rather than reimplementing it by hand, incorrectly.
2527
d74647c3
KB
25282013-07-09 Ken Brown <kbrown@cornell.edu>
2529
2530 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2531
3c51b96b
JB
25322013-07-09 Juanma Barranquero <lekktu@gmail.com>
2533
2534 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2535
4ebbdd67
PE
25362013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 Handle errno and exit status a bit more carefully.
2539 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2540 number into an exit status. Instead, use EXIT_CANCELED.
2541 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2542 * callproc.c (relocate_fd):
2543 * emacs.c (close_output_streams, main):
2544 * process.c (create_process):
2545 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2546 Use emacs_perror for simplicity.
2547 * callproc.c (relocate_fd, main):
2548 * sysdep.c (sys_subshell):
2549 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2550 (shut_down_emacs): Use emacs_write, not write.
2551 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2552 * fileio.c (Fcopy_file, e_write):
2553 * nsterm.m (ns_select):
2554 * process.c (send_process):
2555 * sound.c (vox_write):
2556 Use emacs_write_sig, not emacs_write.
2557 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2558 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2559 New constants.
2560 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2561 of write.
2562 (emacs_full_write): New function.
2563 (emacs_write): Rewrite to use it.
2564 (emacswrite_sig, emacs_perror): New functions.
2565 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2566
44e18199 25672013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2568
2569 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2570 on NS even if it is present. Pixmap on NS is a void*.
2571
9caab067
PE
25722013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2573
2574 Port to Ubuntu 10 (Bug#14803).
2575 Problem reported by T.V. Raman.
2576 * process.c (close_on_exec, accept4, process_socket):
2577 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2578
1d442672
EZ
25792013-07-07 Eli Zaretskii <eliz@gnu.org>
2580
2581 * w32.c (sys_dup): Declare prototype.
2582
2583 * filelock.c:
2584 * emacs.c:
2585 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2586
067428c1
PE
25872013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 Make file descriptors close-on-exec when possible (Bug#14803).
2590 This simplifies Emacs a bit, since it no longer needs to worry
2591 about closing file descriptors by hand in some cases.
2592 It also fixes some unlikely races. Not all such races, as
2593 libraries often open files internally without setting
2594 close-on-exec, but it's an improvement.
2595 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2596 * callproc.c (Fcall_process) [!MSDOS]:
2597 * emacs.c (main) [!DOS_NT]:
2598 * nsterm.m (ns_term_init):
2599 * process.c (create_process):
2600 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2601 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2602 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2603 Prefer mkostemp with O_CLOEXEC to mkstemp.
2604 * callproc.c (relocate_fd) [!WINDOWSNT]:
2605 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2606 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2607 now using pipe2.
2608 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2609 Make the resulting file descriptor close-on-exec.
2610 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2611 * lread.c (load_descriptor_list, load_descriptor_unwind):
2612 Remove; no longer needed. All uses removed.
2613 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2614 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2615 New functions.
2616 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2617 (Fmake_network_process, Fnetwork_interface_list):
2618 (Fnetwork_interface_info, server_accept_connection):
2619 Make newly-created socket close-on-exec.
2620 * sysdep.c (emacs_open, emacs_fopen):
2621 Make new-created descriptor close-on-exec.
2622 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2623 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2624
0da857dd
JD
26252013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2626
2627 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2628 for NS_IMPL_GNUSTEP.
2629
5f86adcd
PE
26302013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2631
2632 Fix openp errno handling.
2633 * callproc.c (Fcall_process): Preserve openp errno around close.
2634 * lread.c (openp): Set errno when returning -1, as some callers
2635 expect this.
2636
1afb1d07
JD
26372013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2638
2639 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2640
2641 * nsterm.h (NSSavePanel): Update comment.
2642 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2643 (ns_run_file_dialog): Declare.
2644
2645 * nsfns.m: Remove panelOK.
2646 (ns_fd_data): New.
2647 (ns_run_file_dialog): New function.
2648 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2649 event loop, so file dialog is popped up by ns_run_file_dialog, called
2650 by sendEvent (Bug#14578).
2651 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2652
3323c263
EZ
26532013-07-06 Eli Zaretskii <eliz@gnu.org>
2654
fdda0220
EZ
2655 * xdisp.c (default_line_pixel_height): New function.
2656 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2657 (try_cursor_movement, redisplay_window, try_window)
2658 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2659
068f9124
SM
2660 * window.c (window_scroll_pixel_based):
2661 use default_line_pixel_height.
fdda0220
EZ
2662
2663 * dispextern.h (default_line_pixel_height): Add prototype.
2664
2665 * frame.c (x_set_line_spacing): Accept a float value for
2666 line-spacing parameter, per the documentation.
2667
3323c263
EZ
2668 * data.c (Fmultibyte_string_p): Doc fix.
2669
47ba6d43
PE
26702013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2671
406af475
PE
2672 Use emacs_open more consistently when opening files.
2673 This handles EINTR more consistently now, and makes it easier
2674 to introduce other uniform changes to file descriptor handling.
2675 * src/systdio.h: New file.
2676 * src/buffer.c (mmap_init):
2677 * cygw32.c (chdir_to_default_directory):
2678 * dispnew.c (Fopen_termscript):
2679 * emacs.c (Fdaemon_initialized):
2680 * fileio.c (Fdo_auto_save):
2681 * image.c (slurp_file, png_load_body, jpeg_load_body):
2682 * keyboard.c (Fopen_dribble_file):
2683 * lread.c (Fload):
2684 * print.c (Fredirect_debugging_output):
2685 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2686 * termcap.c (tgetent):
2687 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2688 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2689 * w32term.c (w32_initialize) [CYGWIN]:
2690 * xfaces.c (Fx_load_color_file):
2691 Use emacs_open instead of plain open, and emacs_fopen instead of
2692 plain fopen.
2693 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2694 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2695 * callproc.c (default_output_mode): New constant.
2696 (Fcall_process): Use it to call emacs_open instead of plain creat.
2697 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2698 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2699 (emacs_fopen): New function.
2700 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2701 Include <lisp.h>, for emacs_open.
2702 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2703
47ba6d43
PE
2704 Remove duplicate #include directives.
2705 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2706 * xfaces.c:
2707 Don't include stdio.h twice.
2708 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2709 Don't include sys/types.h or stdio.h twice.
2710 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2711 * lread.c: Don't include coding.h twice.
2712 * nsfont.m: Don't include frame.h twice.
2713 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2714 * ralloc.c: Don't include <unistd.h> twice.
2715 * xdisp.c: Don't include font.h twice.
2716 * xterm.c: Don't include fontset.h twice.
2717 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2718
b9ed53d5
PE
27192013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 Scale ImageMagick images more carefully.
2722 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2723 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2724 Be more careful about avoiding undefined behavior after
2725 integer overflow and division by zero.
2726
cf13177e
YM
27272013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2728
2729 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2730 (syms_of_w32fns): DEFSYM them.
2731 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2732 (CCHDEVICENAME): Define macros if not defined.
2733 (struct MONITOR_INFO_EX): New struct.
2734 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2735 (enum_display_monitors_fn): New variable.
2736 (globals_of_w32fns): Initialize it.
2737 (Fx_display_pixel_width, Fx_display_pixel_height)
2738 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2739 multi-monitor setups in docstrings.
2740 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2741 screen size by primary monitor's millimeter per pixel.
2742 (w32_monitor_enum, w32_display_monitor_attributes_list)
2743 (w32_display_monitor_attributes_list_fallback)
2744 (Fw32_display_monitor_attributes_list): New functions.
2745 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2746
2747 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2748 if not defined.
2749 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2750
86dfb7a8
MA
27512013-07-04 Michael Albinus <michael.albinus@gmx.de>
2752
2753 * fileio.c (Qfile_notify_error): New error symbol.
2754
2755 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2756 * inotify.c (inotify_callback, symbol_to_inotifymask)
2757 (Finotify_add_watch, Finotify_rm_watch): Use it.
2758 (inotifyevent_to_event): Exchange order of cookie and file name.
2759 (Finotify_add_watch): Adapt docstring.
2760
2761 * lisp.h (Qfile_notify_error): Declare.
2762
2c1c974b
PE
27632013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2764
2765 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2766 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2767 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2768 which did not work (see <http://bugs.gnu.org/14569#307>).
2769 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2770 && (!noninteractive || initialized)). This attempts to thread
2771 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2772
7a35b20f
JB
27732013-07-04 Juanma Barranquero <lekktu@gmail.com>
2774
2775 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2776 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2777
1ce5cd04
PE
27782013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2779
2780 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2781 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2782 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2783 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2784
57f8c490
PE
27852013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2788 Define to __sys_siglist.
2789
bcffb5ca
EZ
27902013-07-02 Eli Zaretskii <eliz@gnu.org>
2791
2792 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2793 word-wrap, so that overflow-newline-into-fringe would work in
2794 visual-line-mode. (Bug#2749)
2795 (move_it_in_display_line_to): When the last scanned display
2796 element fits exactly on the display line, and
2797 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2798 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2799 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2800 finding buffer position that corresponds to pixel coordinates,
2801 e.g. in buffer_posn_from_coords.
2802
2c41e781
JD
28032013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2804
2805 * process.c (handle_child_signal): Call catch_child_signal if
2806 NS_IMPL_GNUSTEP.
2807
c2418359
PE
28082013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2809
52a9bcae
PE
2810 Don't convert function pointers to void * and back.
2811 It isn't portable C, and it's easy enough to avoid.
2812 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2813 (make_save_value): Add support for SAVE_FUNCPOINTER.
2814 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2815 * print.c (print_object):
2816 Distinguish function from object pointers.
2817 * lisp.h (SAVE_FUNCPOINTER): New constant.
2818 (SAVE_SLOT_BITS): Adjust to it.
2819 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2820 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2821 (voidfuncptr): New typedef.
2822 (struct Lisp_Save_Value): New member data[0].funcpointer.
2823 (XSAVE_FUNCPOINTER): New function.
2824
c2418359
PE
2825 Simplify buildobj processing.
2826 * Makefile.in (buildobj.h): Make it a sequence of strings each
2827 followed by comma, rather than a single string. Put it into a
2828 .tmp file in case there's an error while generating it.
2829 (gl-stamp): Use .tmp for temp files.
2830 (mostlyclean): Clean .tmp files.
2831 * doc.c (buildobj): Move to just the routine that needs it.
2832 It's now an array of strings, so processing is simpler.
2833
8f43ce49
PE
28342013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2837 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2838 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2839 Invoke malloc_enable_thread even when not interactive.
2840 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2841 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2842 in this case, since the underlying bug has now been fixed.
2843
24827db9
JB
28442013-07-01 Juanma Barranquero <lekktu@gmail.com>
2845
2846 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2847 unlinking it (bug#14691).
2848
ef099a94
MN
28492013-06-30 Michal Nazarewicz <mina86@mina86.com>
2850
2851 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2852 before checking whether buffer is modified. This lets
2853 `kill-buffer-query-functions' cancel killing of the buffer or save
2854 its content before `kill-buffer' asks user the "Buffer %s
2855 modified; kill anyway?" question.
2856
9d3f2fc2
JD
28572013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2858
2859 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2860 Let the super performKeyEquivalent deal with them (Bug#14747).
2861
e6c6c8c7
PE
28622013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2863
1d71c1d9
PE
2864 * widget.c (resize_cb): Remove unused local.
2865
8f5f35cc
PE
2866 Do not use GTK 3 if it exists but cannot be compiled.
2867 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2868 * xterm.c (x_error_handler) [!USE_GTK]:
2869 Do not use GTK 3.
2870
e6c6c8c7
PE
2871 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2872
0ba54312
EZ
28732013-06-30 Eli Zaretskii <eliz@gnu.org>
2874
5d1c3286
EZ
2875 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2876 to the valid range of values. (Bug#14753)
2877
0ba54312
EZ
2878 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2879 when moving point by using the current glyph matrix. This avoids
2880 the need to force redisplay when this function is called in a
2881 loop.
2882
9c90cc06
PE
28832013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2884
2885 Fix minor problems found by static checking.
2886 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2887 Redo the latter's body to sidestep GCC parenthesization warnings.
2888 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2889 * coding.c (detect_coding, detect_coding_system):
2890 * coding.h (struct undecided_spec):
2891 Use bool for boolean.
2892 * image.c (QCmax_width, QCmax_height): Now static.
2893 * xdisp.c (Fmove_point_visually): Remove unused local.
2894
4c672a0f
EZ
28952013-06-29 Eli Zaretskii <eliz@gnu.org>
2896
2897 * xdisp.c (Fmove_point_visually): New function.
2898
c1ea3abf
JB
28992013-06-28 Kenichi Handa <handa@gnu.org>
2900
2901 * coding.h (define_coding_undecided_arg_index): New enum.
2902 (coding_attr_index): New members
2903 coding_attr_undecided_inhibit_null_byte_detection,
2904 coding_attr_undecided_inhibit_iso_escape_detection,
2905 coding_attr_undecided_prefer_utf_8.
2906 (undecided_spec): New struct.
2907 (struct coding_system): New member `undecided' of the member
2908 `spec'.
2909
2910 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2911 (detect_coding): Likewise.
2912 (detect_coding_system): Likewise.
2913 (Fdefine_coding_system_internal): New coding system properties
2914 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2915 :prefer-utf-8.
2916 (syms_of_coding): Adjust for coding_arg_undecided_max.
2917
ba3de9e6
PE
29182013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2919
2920 * image.c (x_from_xcolors): Remove unused local.
2921
547c9269
YM
29222013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2923
2924 Defer image data transfer between X client and server until actual
2925 display happens.
2926
2927 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2928 and `mask_img'.
2929
2930 * image.c (Destroy_Image): Remove.
2931 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2932 `mask_p', and `colors_p'. All uses changed.
2933 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2934 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2935 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2936 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2937 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2938 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2939 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2940 (image_get_x_image, image_unget_x_image): New functions or macros.
2941 (image_background, image_background_transparent, x_to_xcolors)
2942 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2943 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2944 instead of Destroy_Image.
2945 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2946 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2947 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2948 (imagemagick_load_image, svg_load_image): Use them instead of
2949 x_create_x_image_and_pixmap, and x_put_x_image followed by
2950 x_destroy_x_image, respectively.
2951 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2952 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2953 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2954 background_transparent fields.
2955 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2956 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2957
dae2f5ef
PE
29582013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2959
2960 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2961 This mostly consists of undoing recent changes.
2962 * callproc.c (Fcall_process):
2963 * process.c (create_process):
2964 Do not worry about catching SIGCHLD here, undoing previous change.
2965 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2966 * process.c, process.h (catch_child_signal):
2967 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2968 * process.c (catch_child_handler): Don't worry about being called
2969 lazily and do not assume caller has blocked SIGCHLD, undoing
2970 previous change. Move first-time stuff back to
2971 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2972 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2973 set lib_child_handler if it's already initialized, which may
2974 help avoid problems on GNUStep.
2975
fa55d2aa
PE
29762013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2977
2978 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2979 * callproc.c (Fcall_process):
2980 * process.c (create_process):
2981 Make sure SIGCHLD is caught before we fork,
2982 since Emacs startup no arranges to catch SIGCHLD.
2983 * process.c (lib_child_handler): Initialize to null, not to
2984 dummy_handler.
2985 (catch_child_signal): Allow self to be called lazily.
2986 Do nothing if it's already been called.
2987 Assume caller has blocked SIGCHLD (all callers do now).
2988 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2989 just before it's really needed.
2990 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2991 since it hasn't been caught yet.
2992
f3f9606c
LMI
29932013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2994
2995 * image.c (compute_image_size): New function to implement
2996 :max-width and :max-height.
2997 (imagemagick_load_image): Use it.
2998
c7041908
PE
29992013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3002 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3003 Now extern.
3004 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3005 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3006 the SIGCHLD handler, since the code is not atomic and (due to glib)
3007 signals may be arriving now.
3008 * sysdep.c (init_signals): Do not catch child signals here;
3009 'main' now does that later, at a safer time.
3010
f86852b4
PE
30112013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3012
0dfeed58
PE
3013 Clean up SIGCHLD handling a bit (Bug#14569).
3014 * process.c, process.h (catch_child_signal):
3015 Now always extern, even if !NS_IMPL_GNUSTEP.
3016 * process.c (catch_child_signal): Move glib tickler here from
3017 init_process_emacs, so that it's done earlier in Emacs
3018 initialization. Also move the noninteractive && !initialized
3019 check here from init_process_emacs. This is all a bit cleaner for
3020 GNUish platforms, and I hope it works around the Cygwin bug.
3021 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3022 that glib signal handling is tickled before glib creates threads.
3023
f86852b4
PE
3024 * process.c (wait_reading_process_output): Avoid int overflow
3025 when reading more than 2 GiB total from a process.
3026
cbd6509c
PE
30272013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3028
3029 * process.c (create_process): Handle a couple more cases,
3030 i.e., work even if new_argv and wait_child_setup[i] are cached.
3031 Use Fcall_process's style for volatile vars.
3032
9de1114a
AS
30332013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3034
3035 * process.c (create_process): Mark PROCESS volatile.
3036
fbe9e0b9
PE
30372013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 Use C99-style flexible array members if available.
3040 This avoids some subtle aliasing issues, which typically
3041 aren't a problem with GCC but may be a problem elsewhere.
3042 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3043 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3044 In either case, it uses a flexible array member rather than
3045 the old struct hack. All uses changed.
3046 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3047 Adjust to sdata reorganization.
3048 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3049 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3050 that ports better to pre-C99 non-GCC.
3051 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3052 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3053 as the latter has changed.
3054 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3055 and port better to pre-C99 GCC.
3056 * image.c (struct xpm_cached_color):
3057 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3058 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3059 Use FLEXIBLE_ARRAY_MEMBER.
3060 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3061 Move decl to top level so it gets checked against implementation.
3062 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3063 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3064
1fc71008
PE
30652013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3066
3067 * syntax.c: Integer cleanups.
3068 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3069 All uses that need 0-or-2 changed to:
3070 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3071 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3072 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3073 (char_quoted, prev_char_comend_first, back_comment)
3074 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3075 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3076 Use bool for boolean.
3077 (update_syntax_table, skip_chars, skip_syntaxes):
3078 Prefer int to unsigned when either will do.
3079 (back_comment): Return boolean success flag, like forw_comment,
3080 instead of positive-or-minus-1 (which might have overflowed int anyway).
3081 Don't stuff ptrdiff_t into int.
3082 (syntax_spec_code, syntax_code_spec): Now const.
3083 (Fmatching_paren, scan_lists, scan_sexps_forward):
3084 Use enum syntaxcode for syntax code.
3085 (Fmatching_paren): Check that arg is a character, not just an integer.
3086 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3087 (Finternal_describe_syntax_value): Omit no-longer-needed
3088 comparison to 0.
3089 (skip_chars): Use char, not unsigned char, when the distinction
3090 doesn't matter.
3091 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3092 * bytecode.c (exec_byte_code):
3093 * syntax.c (syntax_spec_code, Fchar_syntax)
3094 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3095 (init_syntax_once):
3096 * syntax.h (SYNTAX_WITH_FLAGS):
3097 Omit unnecessary casts.
3098
b932cad7
EZ
30992013-06-20 Eli Zaretskii <eliz@gnu.org>
3100
3101 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3102 line dimensions here, to avoid race conditions with the main
3103 thread. (Bug#14062, bug#14630, bug#14669)
3104
3105 * w32term.c (w32_draw_window_cursor): Compute the header line and
3106 mode line dimensions here.
3107 <w32_system_caret_window, w32_system_caret_hdr_height>:
3108 <w32_system_caret_mode_height>: New variables.
3109
3110 * w32term.h: Declare them.
3111
89561f72
PE
31122013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3113
5013fc08
PE
3114 * alloc.c (die): Move "assertion failed" string here ...
3115 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3116 COND when SUPPRESS_CHECKING. This shrinks the executable text
3117 size by 0.8% to 2.2% when configured with --enable-checking,
3118 depending on optimization flags (GCC 4.8.1 x86-64).
3119
89561f72
PE
3120 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3121
763a086d 31222013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3123
3124 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3125 base is 2; this is more accurate.
3126
983aeb9a
JB
31272013-06-19 Juanma Barranquero <lekktu@gmail.com>
3128
3129 * sound.c (string_default): Move to !WINDOWSNT section.
3130 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3131
178ba3e6
PE
31322013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3133
bbc51b15
PE
3134 * sound.c: Integer cleanups.
3135 Remove unnecessary forward decls.
3136 (struct sound_device): The 'file' member is now a Lisp_Object, not
3137 a char *, so that we needn't invoke alloca on a huge size.
3138 (Fplay_sound_internal): Adjust to this.
3139 (string_default): New function.
3140 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3141 Use it to adjust to the struct sound_device change.
3142 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3143 (be2hs) [0]: Remove.
3144
178ba3e6
PE
3145 * syntax.c (skip_chars): Don't use uninitialized storage
3146 when searching a multibyte buffer for characters that are not in a
3147 unibyte string that contains non-ASCII characters.
3148
69f60cdc
JD
31492013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3150
3151 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3152 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3153
0d6224d4
PE
31542013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3157
3c542890
KH
31582013-06-18 Kenichi Handa <handa@gnu.org>
3159
f7e3f7cd
KH
3160 * font.c (Ffont_spec): Signal an error for an invalid font name
3161 (Bug#14648).
3c542890 3162
9349e5f7
PE
31632013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3166 In particular this ports to 32-bit sparc Sun cc.
3167 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3168 array with a dummy element at specpdl[-1], so that its address can
3169 be taken portably.
3170 (unbind_to): Do not copy the binding; not needed, now that we
3171 copy old_value in the one place where the copy is needed.
3172 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3173 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3174 (union specbinding): Rename from struct specbinding. Redo layout
3175 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3176 which is not portable. With Sun C 5.12 32-bit sparc, the
3177 declaration causes nargs to be an unsigned bitfield, a behavior
3178 that the C standard allows; but Emacs wants nargs to be signed.
3179 The overall type is now a union of structures rather than a
3180 structure of union of structures, and the 'kind' member is now a
3181 bitfield, so that the overall type doesn't grow. All uses changed.
3182 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3183
0a4df6a5
PE
31842013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3185
ec6ecaad
PE
3186 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3187 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3188
0a4df6a5
PE
3189 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3190
7bfe8dbc
EZ
31912013-06-17 Eli Zaretskii <eliz@gnu.org>
3192
3193 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3194 unless we know that the window w's frame is a frame object.
3195 Another attempt at solving bug#14062 and bug#14630.
3196
708e05f6
LMI
31972013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3198
3199 * textprop.c (property_set_type): New enum.
3200 (add_properties): Allow appending/prepending text properties.
3201 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3202 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3203 add_text_properties_1.
3204 (Fadd_face_text_property): New function that calls
3205 add_text_properties_1.
3206
84575e67
PE
32072013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 Move functions from lisp.h to individual modules when possible.
3210 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3211 * alloc.c (XFLOAT_INIT, set_symbol_name):
3212 * buffer.c (CHECK_OVERLAY):
3213 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3214 (set_char_table_parent):
3215 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3216 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3217 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3218 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3219 (set_blv_valcell):
3220 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3221 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3222 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3223 (backtrace_args, backtrace_debug_on_exit):
3224 * floatfns.c (CHECK_FLOAT):
3225 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3226 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3227 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3228 (set_hash_index_slot):
3229 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3230 * marker.c (CHECK_MARKER):
3231 * textprop.c (CHECK_STRING_OR_BUFFER):
3232 * window.c (CHECK_WINDOW_CONFIGURATION):
3233 Move here from lisp.h, and make these functions static rather than
3234 extern inline.
3235 * buffer.c (Qoverlayp):
3236 * data.c (Qsubrp):
3237 * fns.c (Qhash_table_p):
3238 * window.c (Qwindow_configuration_p):
3239 Now static.
3240 * lisp.h: Remove the abovementioned defns and decls.
3241
44e18199 3242 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3243 In lisp.h, prefer functions to function-like macros, and
3244 constants to object-like macros, when either will do. This:
3245 . simplifies use, as there's no more need to worry about
3246 arguments' side effects being evaluated multiple times.
3247 . makes the code easier to debug on some platforms.
3248 However, when using gcc -O0, keep using function-like macros
3249 for a few critical operations, for performance reasons.
3250 This sort of thing isn't needed with gcc -Og, but -Og
3251 is a GCC 4.8 feature and isn't widely-enough available yet.
3252 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3253 Remove enum lsb_bits; no longer needed.
3254 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3255 * buffer.c (Qoverlap):
3256 * data.c (Qsubrp):
3257 * fns.c (Qhash_table_p):
3258 Now extern, so lisp.h can use these symbols.
3259 * dispextern.h: Include character.h, for MAX_CHAR etc.
3260 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3261 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3262 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3263 (GLYPH_CODE_P): Move here from lisp.h.
3264 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3265 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3266 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3267 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3268 XUNTAG now returns void *.
3269 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3270 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3271 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3272 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3273 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3274 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3275 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3276 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3277 New macros, renamed from their sans-lisp_h_ counterparts.
3278 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3279 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3280 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3281 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3282 If compiling via GCC without optimization, define these as macros
3283 in addition to inline functions.
3284 To disable this, compile with -DINLINING=0.
3285 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3286 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3287 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3288 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3289 (INTMASK, VALMASK): Now macros, since static values cannot be
3290 accessed from extern inline functions.
3291 (VALMASK): Also a constant, for benefit of old GDB.
3292 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3293 is INTEGERP, which can fold it in.
5165d44a 3294 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3295 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3296 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3297 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3298 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3299 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3300 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3301 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3302 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3303 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3304 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3305 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3306 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3307 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3308 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3309 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3310 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3311 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3312 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3313 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3314 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3315 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3316 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3317 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3318 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3319 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3320 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3321 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3322 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3323 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3324 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3325 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3326 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3327 Now functions.
3328 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3329 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3330 (VALMASK): Define in one place rather than in two, merging the
3331 USE_LSB_TAG parts; this is simpler.
3332 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3333 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3334 Move up, to avoid use before definition.
3335 Also include "globals.h" earlier, for the same reason.
3336 (make_natnum): New function.
3337 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3338 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3339 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3340 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3341 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3342 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3343 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3344 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3345 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3346 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3347 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3348 (Qwindow_configuration_p, Qimage): New forward declarations.
3349 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3350 (STRING_COPYIN): Remove; unused.
3351 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3352 (xcar_addr, xcdr_addr): New functions. All uses changed.
3353 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3354 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3355 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3356 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3357 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3358 (TYPE_RANGED_INTEGERP): Simplify.
3359 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3360 (setlocale, fixup_locale, synchronize_system_messages_locale)
3361 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3362 Now empty functions, not macros.
3363 (functionp): Return bool, not int.
3364 * window.c (Qwindow_configuration_p): Now extern,
3365 so window.h can use it.
3366 * window.h (Qwindowp): Move decl back to lisp.h.
3367
9583ec36
EZ
33682013-06-15 Eli Zaretskii <eliz@gnu.org>
3369
3370 * xdisp.c (Fline_pixel_height): New function, required for solving
3371 bug #14567.
3372
210272ce
PE
33732013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3374
3375 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3376
de0503df
SM
33772013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3378
3379 * lread.c (syms_of_lread):
3380 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3381
afbfe143
KD
33822013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3383
3384 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3385
d177e213
XF
33862013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3387
3388 * fileio.c (expand_file_name): Doc fix.
3389
05e3e412
PE
33902013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3391
f7394b12
PE
3392 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3393 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3394 Wait for self, not for 0. This can't hurt on GNU or similar
3395 system, and may help with Cygwin.
3396
05e3e412
PE
3397 * keyboard.c: Don't use PROP (...) as an lvalue.
3398 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3399 Use set_prop (A, B), not PROP (A) = B.
3400
17dd3097
EZ
34012013-06-10 Eli Zaretskii <eliz@gnu.org>
3402
3403 * xdisp.c (get_it_property): Use it->window instead of generating
3404 a Lisp object from it->w.
3405
52fab9c9
EZ
34062013-06-09 Eli Zaretskii <eliz@gnu.org>
3407
3408 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3409 get-char-property the window that is being rendered, instead of
3410 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3411 (compute_display_string_pos): When W is NULL, use the current
3412 buffer as the object to pass to get-char-property.
3413 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3414 pointer member of the bidi iterator, since no window is pertinent
3415 to this function.
52fab9c9 3416
5bf97bfc
EZ
34172013-06-08 Eli Zaretskii <eliz@gnu.org>
3418
3419 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3420 being displayed, and pass it to compute_display_string_pos.
3421 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3422 (bidi_paragraph_init): All callers changed.
3423
3424 * xdisp.c (init_from_display_pos, init_iterator)
3425 (handle_single_display_spec, next_overlay_string)
3426 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3427 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3428 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3429 (compute_display_string_pos): Accept additional argument, the
3430 window being displayed, and pass it to Fget_char_property.
3431 (Bug#14575)
3432
3433 * dispextern.h (struct bidi_it): New member w, the window being
3434 displayed.
3435 (compute_display_string_pos): Adjust prototype.
3436
5de0e011
JD
34372013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3438
e7b41c4c 3439 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3440
3441 * process.c (wait_reading_process_output): Check for NS before GLIB.
3442 GLIB may be linked in due to rsvg, but ns_select must be called.
3443
5de0e011
JD
3444 * xgselect.c (xg_select): Remove call to window_system_available
3445 and g_main_context_pending at the top, so Gdk events (i.e. file
3446 notify) are processed when Emacs is started with -nw.
3447
a822acff
EZ
34482013-06-07 Eli Zaretskii <eliz@gnu.org>
3449
3450 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3451 (ctagsfiles3): New variable, includes only *.m files.
3452 (TAGS): Use an explicit language name in the regular expressions,
3453 to avoid transformation of '/SOMETHING' by MSYS to
3454 'c:\MSYS\SOMETHING'.
3455
6c0a9ed1
RC
34562013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3457
3458 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3459
9ef6111b
EZ
34602013-06-06 Eli Zaretskii <eliz@gnu.org>
3461
3462 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3463 still need to set the mouse pointer shape and activate help-echo.
3464 (Bug#14558)
3465
7d300d64
PE
34662013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 A few porting etc. fixes for the new file monitor code.
3469 See the thread containing
3470 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3471 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3472 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3473 (dir_monitor_callback, Fgfile_rm_watch):
3474 Use assq_no_quit instead of Fassoc, for speed.
3475 (dir_monitor_callback, Fgfile_rm_watch):
3476 eassert that the monitor is a fixnum.
3477 (dir_monitor_callback): No need for CDR_SAFE.
3478 Simplify building of lisp with alternative tails.
3479 (Fgfile_add_watch, Fgfile_rm_watch):
3480 Do not assume glib functions set errno reliably on failure.
3481 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3482 and signal an error otherwise.
3483 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3484 Use Fdelq instead of Fdelete, for speed.
3485
817ebfcf
EZ
34862013-06-05 Eli Zaretskii <eliz@gnu.org>
3487
3488 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3489 don't insist on being invoked on a highlighted tool-bar button.
3490 Avoids losing tool-bar functionality when mouse-highlight is nil.
3491 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3492 Don't highlight when mouse-highlight is nil.
3493 (note_mouse_highlight): When mouse-highlight is nil, don't return
3494 right away; instead, run tool-bar and mode-line highlight
3495 subroutine, clear any existing highlight, and revert the mouse
3496 pointer to its default shape. (Bug#14558)
3497
55577e7c
SM
34982013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3499
3500 * lisp.mk (lisp): Add prog-mode.el.
3501
f019a684
PE
35022013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3505 * process.c (dummy_handler): New function.
3506 (lib_child_handler): New static var.
3507 (handle_child_signal): Invoke it.
3508 (catch_child_signal): If a library has set up a signal handler,
3509 save it into lib_child_handler.
3510 (init_process_emacs): If using glib and not on Windows, tickle glib's
3511 child-handling code so that it initializes its private SIGCHLD handler.
3512 * syssignal.h (SA_SIGINFO): Default to 0.
3513 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3514 31; it should no longer be needed now.
3515
90db8702
MA
35162013-06-05 Michael Albinus <michael.albinus@gmx.de>
3517
3518 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3519
3520 * gfilenotify.c (globals_of_gfilenotify): New function.
3521 (syms_of_gfilenotify): Move global initialization there.
3522
3523 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3524
bfa3acd6
SM
35252013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3526
3527 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3528 * keyboard.c (menu_bar_items, tool_bar_items):
3529 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3530 not override local keymaps any more.
3531
ba59bd80
EZ
35322013-06-04 Eli Zaretskii <eliz@gnu.org>
3533
3534 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3535
7f203aa1
EZ
35362013-06-03 Eli Zaretskii <eliz@gnu.org>
3537
9337e206
EZ
3538 * w32console.c (initialize_w32_display): Return the dimensions of
3539 the console window via 2 additional arguments, not via the current
3540 frame. This avoids crashes due to overrunning the bounds of
3541 frame's decode_mode_spec_buffer, which is not resized following
3542 the change of the frame dimensions from the initial 10x10.
3543
3544 * w32term.h (w32_initialize_display_info): Adjust prototype.
3545
3546 * term.c (init_tty): Take dimensions of the frame from the values
3547 returned by initialize_w32_display.
3548
7f203aa1
EZ
3549 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3550 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3551 (LIBES): Add $(GFILENOTIFY_LIBS).
3552
3553 * w32inevt.c (handle_file_notifications): Add dummy implementation
3554 for !HAVE_W32NOTIFY.
3555
3556 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3557
55a87246
JD
35582013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3559
3560 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3561
3562 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3563
3564 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3565
3d5ee10a
PE
35662013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3567
3568 Fix minor problems found by static checking.
3569 * data.c (pure_write_error):
3570 Use xsignal2, not Fsignal, as Fsignal might return.
3571 * eval.c (set_backtrace_debug_on_exit): Now static.
3572 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3573 No longer inline. EXTERN_INLINE is needed only for functions
3574 defined in .h files. Reindent function header as per GNU style.
3575 (backtrace_p, backtrace_top, backtrace_next):
3576 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3577 compiler or linker. Add extern decls to pacify gcc -Wall.
3578 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3579 Now static.
3580 * frame.c (free_monitors): Define only on platforms that need it.
3581 * nsterm.m (ns_term_init):
3582 * process.c (catch_child_signal):
3583 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3584 defined on all porting targets these days.
3585 * process.c, process.h (catch_child_signal):
3586 Make it extern only if NS_IMPL_GNUSTEP is defined.
3587
e2d8a6f0
EZ
35882013-06-03 Eli Zaretskii <eliz@gnu.org>
3589
3590 * w32.c (gettimeofday): Make the signature identical to prototype
3591 in nt/inc/sys/time.h.
3592
a8a7c5f6
SM
35932013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3594
3595 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3596 .gdbinit.
3597
3598 * keyboard.c (safe_run_hooks_error): Improve error message.
3599
3600 * data.c (pure_write_error): Add `object' argument.
3601 * puresize.h (CHECK_IMPURE): Use it.
3602
c9628c79
MA
36032013-06-03 Michael Albinus <michael.albinus@gmx.de>
3604
3605 * Makefile.in (NOTIFY_OBJ): New variable.
3606 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3607
3608 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3609 Call syms_of_gfilenotify.
3610
3611 * gfilenotify.c: New file.
3612
3613 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3614 and Qfile_w32notify.
3615 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3616 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3617
3618 * lisp.h: Declare syms_of_gfilenotify.
3619
3620 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3621
2f592f95
SM
36222013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3623
3624 Merge the specpdl and backtrace stacks. Make the structure of the
3625 specpdl entries more obvious via a tagged union of structs.
3626 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3627 (enum specbind_tag): New enum.
3628 (struct specbinding): Make it a tagged union of structs.
3629 Add a case for backtrace records.
3630 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3631 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3632 (backtrace_debug_on_exit): New accessors.
3633 (struct backtrace): Remove.
3634 (struct catchtag): Remove backlist field.
3635 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3636 Move to eval.c.
3637 (Flocal_variable_p): Speed up the common case where the binding is
3638 already loaded.
3639 * eval.c (backtrace_list): Remove.
3640 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3641 (set_backtrace_args, set_backtrace_nargs)
3642 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3643 (backtrace_next): New functions.
3644 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3645 (unwind_to_catch, internal_lisp_condition_case)
3646 (internal_condition_case, internal_condition_case_1)
3647 (internal_condition_case_2, internal_condition_case_n): Don't bother
3648 with backtrace_list any more.
3649 (Fsignal): Adjust to new backtrace format.
3650 (grow_specpdl): Move up.
3651 (record_in_backtrace): New function.
3652 (eval_sub, Ffuncall): Use it.
3653 (apply_lambda): Adjust to new backtrace format.
3654 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3655 data.c.
3656 (specbind): Adjust to new specpdl format. Simplify.
3657 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3658 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3659 backtrace format.
3660 (mark_backtrace): Remove.
3661 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3662 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3663 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3664 Use mark_specpdl.
3665 * profiler.c (record_backtrace): Use get_backtrace.
3666 (handle_profiler_signal): Use backtrace_top_function.
3667 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3668 accessor functions.
3669
c0342369
JD
36702013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3671
3672 * process.h (catch_child_signal): Declare.
3673
3674 * process.c (catch_child_signal): New function.
3675 (init_process_emacs): Call it.
3676
3677 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3678 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3679 NS_IMPL_COCOA.
3680 (x_set_cursor_type): Remove declaration.
3681 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3682 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3683 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3684 (ns_get_color): Use F suffix on float.
3685 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3686 (ns_get_rgb_color): Remove.
3687 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3688 (note_mouse_movement): x and y are CGFloat.
3689 (ns_draw_fringe_bitmap): Remove unused rowY.
3690 Change #if to COCOA && >= 10_6.
3691 (ns_draw_window_cursor): Remove unused overspill.
3692 (ns_draw_underwave): width and x are EamcsCGFloat.
3693 (ns_draw_box): thickness is CGFloat.
3694 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3695 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3696 if not in main thread.
3697 (ns_get_pending_menu_title, ns_check_menu_open)
3698 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3699 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3700 (sendFromMainThread:): New method.
3701 (changeFont:): size is CGFloat.
3702 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3703 Disable warning about permanent text.
3704 (characterIndexForPoint:): Adjust return type depending on GNUStep
3705 version.
3706 (mouseDown:): delta is CGFloat.
3707 (updateFrameSize): Remove unised variable f.
3708 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3709 Cast float to EmacsCGFloat.
3710 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3711 also to -1 when restoring.
3712 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3713 inside NS_IMPL_COCOA.
3714 (toggleFullScreen:): Put call to toggleFullScreen inside
3715 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3716 (setPosition:portion:whole:): por is CGFloat.
3717 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3718 (mouseDown:): Use CGFloat.
3719 (mouseDragged:): Remove unised variable edge.
3720 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3721
3722 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3723 of CGFloat differs.
3724 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3725 when NS_IMPL_GNUSTEP.
3726 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3727 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3728 (EmacsToolbar): Add clearAll. Add tag argument to
3729 addDisplayItemWithImage.
3730 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3731
3732 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3733
3734 * nsmenu.m (ns_update_menubar): Make static.
3735 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3736 (fillWithWidgetValue:): Add cast to SEL for setAction.
3737 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3738 (update_frame_tool_bar): Update code for GNUStep.
3739 (clearAll): New method.
3740 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3741 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3742 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3743 call to insertItemWithItemIdentifier.
3744 (validateVisibleItems): Fix indentation.
3745 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3746 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3747 UtilityWindow to aStyle, remove call to setStyleMask.
3748
3749 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3750
3751 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3752 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3753 Use F suffix on floats.
3754 (ns_char_width): Returns CGFloat.
3755 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3756 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3757 DPSxshow.
3758 (ns_glyph_metrics): CGFloat instead of float.
3759
a0eb10b3
JB
3760 * nsfns.m (x_set_foreground_color, x_set_background_color):
3761 Use EmacsCGFloat.
3762 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3763 remove unused variables.
3764 (Fns_read_file_name): Keep track if panel is for save.
3765 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3766 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3767 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3768 Just return the input if GNUStep.
c0342369
JD
3769 (x_screen_planes): Remove.
3770 (Fxw_color_values): Use EmacsCGFloat
3771 (Fns_display_monitor_attributes_list): Only get screen number for
3772 Cocoa.
ef099a94 3773 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3774 EmacsSavePanel.
3775 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3776 ns_directory_from_panel.
3777
da9aff11
PE
37782013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3779
3780 * process.c (handle_child_signal): Also use WCONTINUED.
3781 This is so that list-processes doesn't mistakenly list the process
3782 as stopped, when the process has actually been continued and is
3783 now running.
3784
0e64479a
PE
37852013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3786
fc186a96
PE
3787 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3788 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3789 not already configured.
3790
0e64479a
PE
3791 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3792
38b787fa
EZ
37932013-05-29 Eli Zaretskii <eliz@gnu.org>
3794
3795 * Makefile.in (mostlyclean): Remove *.res files.
3796
22513e52
SM
37972013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3798
3799 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3800 a buffer (bug#8447).
3801
6ef3db10
EZ
38022013-05-27 Eli Zaretskii <eliz@gnu.org>
3803
3804 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3805 display vector, and we backtrack, handle the case that the
3806 previous character position is also displayed from a display
3807 vector or covered by a display string or image. (Bug#14476)
3808
6799bb26
JD
38092013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3810
3811 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3812 (struct MonitorInfo, free_monitors): Remove.
3813 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3814 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3815 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3816 Qframes, Qsource.
3817
3818 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3819 (struct MonitorInfo, free_monitors): Remove.
3820 (ns_screen_name): Make static.
3821 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3822 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3823 Qframes, Qsource.
3824
3825 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3826 (struct MonitorInfo): New struct.
3827 (free_monitors, make_monitor_attribute_list): Declare.
3828
22513e52
SM
3829 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3830 New Lisp_Object:s.
6799bb26
JD
3831 (free_monitors, make_monitor_attribute_list): New functions.
3832 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3833 Qsource.
3834
38cd43eb
XF
38352013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3836
3837 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3838
2af0948d
SM
38392013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3840
a7eb9b0f
SM
3841 * keyboard.c: Apply keyboard decoding only to events that come directly
3842 from the tty, not from unread-command-events (bug#14368).
3843 (read_event_from_main_queue): New function, extracted from read_char).
3844 (read_decoded_char): Remove.
3845 (read_decoded_event_from_main_queue): New function to replace it.
3846 (read_char): Use it.
3847 (read_key_sequence): Use read_char rather than read_decoded_char.
3848
2af0948d
SM
3849 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3850
1413e9a5
BR
38512013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3852
3853 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3854
e6d2f155
KH
38552013-05-22 Kenichi Handa <handa@gnu.org>
3856
3857 The following changes are to fix the setting of
3858 buffer-file-coding-system on, for instance, C-x RET c unix RET
3859 _FILE_OF_DOS_EOL_TYPE_ RET.
3860
3861 * coding.h (struct coding_system): New member detected_utf8_chars.
3862
3863 * coding.c (detect_coding_utf_8): Count characters and check EOL
3864 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3865 BOM is there.
3866 (setup_coding_system): Do not initialize coding->head_ascii.
3867 (check_ascii): Do not set coding->eol_seen but update it. Do not
3868 call adjust_coding_eol_type here.
1413e9a5
BR
3869 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3870 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3871 of the found coding-system.
3872 (decode_coding_gap): Cancel previous change. Utilize the
3873 character numbers counted by detect_coding_utf_8. Fix detection
3874 of BOM for utf-8.
3875
ab56a6f4 38762013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3877
3878 * search.c (looking_at_1): Only set last_thing_searched if the match
3879 changed the match-data (bug#14281).
3880
ecc3c6ed
DA
38812013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3882
3883 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3884 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3885 (move_it_vertically_backward): Likewise.
3886
5ba8bf35
YM
38872013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3888
3889 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3890 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3891 (Fx_display_mm_width, Fx_display_mm_height):
3892 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3893
91e8418b 3894 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3895 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3896 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3897 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3898 (Fx_display_backing_store, Fx_display_visual_class)
3899 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3900 (Fx_display_grayscale_p, Fx_display_pixel_width)
3901 (Fx_display_pixel_height, Fx_display_planes)
3902 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3903 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3904 (Fx_display_mm_width, Fx_display_mm_height)
3905 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3906 height for all physical monitors as in X11.
3907
fc30d803
SM
3908 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3909 Return pixel width or height for all physical monitors as in X11.
91e8418b 3910
31ff141c
PE
39112013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 Port --enable-gcc-warnings to clang.
3914 * bytecode.c (exec_byte_code):
3915 * regex.c:
3916 Redo diagnostic pragmas to pacify clang, too.
3917 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3918 * editfns.c (Fencode_time):
3919 * fileio.c (file_accessible_directory_p):
3920 * font.c (font_unparse_xlfd):
3921 Use '&"string"[index]' instead of '"string" + (index)'.
3922 * undo.c (user_error): Remove; unused.
3923
df065a0b
EZ
39242013-05-16 Eli Zaretskii <eliz@gnu.org>
3925
04d360e7
EZ
3926 * insdel.c (insert_1_both): Document the arguments, instead of
3927 referring to insert_1, which no longer exists.
3928
5bb98290
EZ
3929 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3930 some window, increment windows_or_buffers_changed, so that
3931 *Messages* display in that window is updated. (Bug#14408)
3932
df065a0b
EZ
3933 * w32.c: Include epaths.h.
3934 (init_environment): Use cmdproxy.exe without leading directories.
3935 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3936 case.
3937 (gettimeofday): Adjust signature and return value to Posix
3938 expectations.
3939
3940 * unexw32.c (open_output_file): Delete the existing emacs.exe
3941 before creating it, to break the hard link to the versioned
3942 executable.
3943
3944 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3945 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3946 (FIRSTFILE_OBJ): New variables.
3947 (W32_RES): Rename to EMACSRES. All users changed.
3948 (base_obj): Use $(CM_OBJ).
3949 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3950 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3951 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3952 $(W32_RES_LINK) before $(LIBES).
3953 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3954
1aa8d505
SM
39552013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3956
6e911150
SM
3957 * makefile.w32-in (DOC): Use just "DOC".
3958
3959 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3960
1aa8d505
SM
3961 * process.c: Export default filters and sentinels to Elisp.
3962 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3963 New constants.
3964 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3965 (Fset_process_sentinel, Fformat_network_address):
3966 Default to them instead of nil.
3967 (server_accept_connection): Sentinels can't be nil any more.
3968 (read_and_dispose_of_process_output): New function, extracted from
3969 read_process_output.
3970 (read_process_output): Use it; filters can't be nil.
3971 (Finternal_default_process_filter): New function, extracted from
3972 read_process_output.
3973 (exec_sentinel_unwind): Remove function.
3974 (exec_sentinel): Don't zilch sentinel while running.
3975 (status_notify): Sentinels can't be nil.
3976 (Finternal_default_process_sentinel): New function extracted from
3977 status_notify.
3978 (setup_process_coding_systems): Default filter is not nil any more.
3979 (syms_of_process): Export new Elisp functions and initialize
3980 new constants.
3981 * lisp.h (make_lisp_proc): New function.
3982
5ac2eb34
SM
39832013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3984
3985 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3986
eda9c7d7
EZ
39872013-05-14 Eli Zaretskii <eliz@gnu.org>
3988
3989 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3990 unless we know that the window w is a leaf window.
3991 Another attempt at solving bug#14062.
eda9c7d7 3992
8fdeaad5
JD
39932013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3994
3995 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3996 fdesc (Bug#14375).
3997
44aa9ee6
PE
39982013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3999
4000 * image.c (gif_load): Check that subimages fit (Bug#14345).
4001
759fd763
SM
40022013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4003
4004 * lread.c (skip_dyn_eof): New function.
4005 (read1): Use it to skip the end of a file in response to #@00.
4006
4007 * doc.c (get_doc_string): Slightly relax the sanity checking.
4008
4465bfb4
JD
40092013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4010
4011 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4012 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4013 (MonitorInfo): New struct.
4014 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4015 (Fns_display_monitor_attributes_list): New functions.
4016 (display-usable-bounds): Remove.
4017 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4018 Qsource.
4019
7583e2a0
PE
40202013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4023 (GTK_CHECK_VERSION): New macro, if not already defined.
4024 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4025 replaced by GTK_CHECK_VERSION.
4026
ad75d77e
PE
40272013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4028
4029 * xterm.h (GTK_PREREQ): New macro.
4030 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4031 to use this macro instead, for consistency and clarity.
4032
07525f77
EZ
40332013-05-08 Eli Zaretskii <eliz@gnu.org>
4034
4035 * xdisp.c (row_for_charpos_p): New function, with code of
4036 cursor_row_p, but accepts an additional argument CHARPOS instead
4037 of using a hardcoded PT.
4038 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4039 (row_containing_pos): Call row_for_charpos_p instead of partially
4040 doing the same. Fixes cursor positioning under longlines-mode
4041 when longlines-show-effect includes more than one newline, when
4042 moving the cursor vertically up.
4043
d901fc8d
JB
40442013-05-08 Juanma Barranquero <lekktu@gmail.com>
4045
4046 * makefile.w32-in (ACL_H): New macro.
4047 ($(BLD)/fileio.$(O)): Update dependencies.
4048
f269bc61
PE
40492013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4050
e7b41c4c 4051 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4052 * Makefile.in (LIB_ACL): New macro.
4053 (LIBACL_LIBS): Remove.
4054 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4055 * fileio.c: Include <acl.h>.
4056 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4057 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4058 !acl_errno_valid.
4059 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4060 it ourselves.
4061
f269bc61
PE
4062 * unexelf.c: Don't assume ElfW (Half) fits in int.
4063 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4064 when dealing with ElfW (Half) values, since they can exceed 2**31
4065 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4066 (entry_address): Omit unused NUM arg. All uses changed.
4067
a261c53e
JL
40682013-05-07 Juri Linkov <juri@jurta.org>
4069
4070 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4071 to the string converted from number with `Fnumber_to_string'.
4072 (Bug#14254)
4073
2b66427d
PE
40742013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4075
4076 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4077 This fixes a problem introduced by my previous change.
4078
15acfe41
GM
40792013-05-07 Glenn Morris <rgm@gnu.org>
4080
4081 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4082
5ea03bf5
JD
40832013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4084
4085 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4086
e0c9d565
PE
40872013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 Static checking by GCC 4.8.0.
4090 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4091 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4092 (x_get_monitor_attributes_fallback)
4093 (x_get_monitor_attributes_xinerama)
4094 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4095 Define only if USE_GTK.
4096 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4097 (x_get_monitor_attributes_fallback): Omit unused locals.
4098 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4099 Use double, not float, to avoid mixed-mode floating point arithmetic.
4100
4e3f9230
YM
41012013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4102 Jan Djärv <jan.h.d@swipnet.se>
4103
4104 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4105 (XINERAMA_CFLAGS): New macros.
4106 (ALL_CFLAGS, LIBES): Use them.
4107
4108 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4109 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4110 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4111 (syms_of_xfns): DEFSYM them.
4112 (struct MonitorInfo): New struct.
4113 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4114 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4115 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4116 (x_get_monitor_attributes_xinerama): New functions.
4117 (Fx_display_monitor_attributes_list): New primitive.
4118 (syms_of_xfns): Defsubr it.
4119
4120 * xterm.h (x_display_info): Add Xatom_net_workarea and
4121 Xatom_net_current_desktop.
4122
4123 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4124 and dpyinfo->Xatom_net_current_desktop.
4125
05839b6a
EZ
41262013-05-06 Eli Zaretskii <eliz@gnu.org>
4127
4128 * xdisp.c (pos_visible_p): Use the special code for finding the
4129 beginning of a display property or overlay for any "replacing"
4130 display property, not just for display strings. This solves
4131 incorrect reporting of position by posn-at-point. (Bug#14241)
4132
dc4a2ee0
PE
41332013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4134
5ee94506
PE
4135 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4136 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4137 Verify that ElfW (Half) fits in int.
4138 (fatal): Use same signature as lisp.h.
4139 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4140 configure and build with -DUNEXELF_DEBUG without worrying about
4141 other modules that use DEBUG.
4142 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4143 possibly-wide integers now uses it instead of plain fprintf.
4144 (entry_address): New function, which avoids problems with 32-bit
4145 overflow on 64-bit hosts.
4146 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4147 (round_up): Don't assume the remainder fits in int.
4148 (find_section): Use bool for boolean. Simplify debug code.
4149 (unexec): Don't assume file sizes fit in int or size_t.
4150 Omit unnecessary trailing newline in 'fatal' format.
4151 Use strerror rather than outputting decimal error number.
4152 Remove unused code when emacs is not defined;
4153 this file relies on Emacs now.
4154 Don't assume e_phnum and e_shnum are positive.
4155
dc4a2ee0
PE
4156 * regex.c: Fix problems when DEBUG is defined.
4157 (extract_number, extract_number_and_incr): Define regardless of
4158 whether DEBUG is defined; that's simpler and makes the code less
4159 likely to go stale in the normal case when DEBUG is not defined.
4160 Return int rather than taking an int * arg. All callers changed.
4161 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4162 Remove, replacing with ...
4163 (DEBUG_PRINT): New macro. All callers changed.
4164 (DEBUG_COMPILES_ARGUMENTS): New macro.
4165 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4166 (print_compiled_pattern, print_double_string) [DEBUG]:
4167 Use prototype rather than old-style definition.
4168 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4169 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4170 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4171 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4172 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4173 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4174 This matters only when DEBUG is defined.
4175
14c7ed05
EZ
41762013-05-05 Eli Zaretskii <eliz@gnu.org>
4177
4178 * xdisp.c (set_iterator_to_next): Set the
4179 ignore_overlay_strings_at_pos_p flag only if we are _really_
4180 iterating over an overlay string, as indicated by the
4181 current.overlay_string_index member. (Bug#14306)
4182
e6076b1b
JD
41832013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4184
4185 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4186 to where it is used, to avoid autorelease issues (Bug#14050).
4187
cbee2131
PE
41882013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4189
4190 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4191 * fileio.c (syms_of_fileio): Implement this.
4192 * filelock.c (create_lock_file): If symbolic links don't work, so
4193 we use a regular file as a lock file, do not fsync the lock file;
4194 it's not needed.
4195
30c7e542
SM
41962013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4197
4198 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4199 (syms_of_minibuf): Adjust accodingly.
4200 * lread.c (Fread):
4201 * callint.c (Fcall_interactively): Adjust calls accordingly.
4202
5bebd186
EZ
42032013-05-04 Eli Zaretskii <eliz@gnu.org>
4204
4205 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4206 w->contents is a buffer before computing everything else.
4207 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4208
4209 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4210 assertion violations. (Bug#14062)
4211
0fb0a4f3
DR
42122013-05-01 David Reitter <david.reitter@gmail.com>
4213
4214 * nsfns.m (ns_tooltip): Initialize.
4215
9e63b4a5
EZ
42162013-04-28 Eli Zaretskii <eliz@gnu.org>
4217
4218 * coding.c (decode_coding_gap): Don't remove the character before
4219 a newline unless it's a CR character. (Bug#14287)
4220
ad60824e
DN
42212013-04-28 Dan Nicolaescu <dann@gnu.org>
4222
4223 * dispextern.h (struct face): Move enum face_underline_type
4224 earlier so that bitfields can be in the same word.
4225
edbdcec0
JD
42262013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4227
4228 * nsfns.m (handlePanelKeys): New function.
4229 (EmacsOpenPanel:performKeyEquivalent:)
4230 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4231 arrows/function/control and copy/paste keys (Bug#14296).
4232
0208ede7
JL
42332013-04-27 Juri Linkov <juri@jurta.org>
4234
4235 * callint.c (Fcall_interactively): Call `Qread_number' for
4236 interactive code letter `n' instead of using duplicate code.
4237 (Bug#14254)
4238
b8dd59f7
PE
42392013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4240
4241 * systime.h (make_timeval): Declare as 'const'.
4242
8bd722db
KH
42432013-04-27 Kenichi Handa <handa@gnu.org>
4244
4245 * font.c (font_open_entity): Always open a font of manageable
4246 size.
4247
13d0e56f 42482013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4249
f780d632
PE
4250 Port better to AIX (Bug#14258).
4251 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4252 to pacify AIX xlc.
4253
ec509856
KH
42542013-04-24 Kenichi Handa <handa@gnu.org>
4255
4256 * coding.c (decode_coding_iso_2022): When an invalid escape
4257 sequence is encountered, reset the invocation and designation
4258 status to the safest one.
4259
84fc48e5
PE
42602013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4261
4262 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4263 Without this fix, "make distclean" leaves stamp-h1 behind.
4264
806bda47
EC
42652013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4266
4267 * w32fns.c (w32_fullscreen_rect): New function to compute the
4268 window rectangle for the given fullscreen mode.
4269 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4270 longer tunes the window size. This keeps the window's edges flush
4271 with the screen and allows the taskbar to hide itself in fullboth.
4272
4273 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4274 window decorations and uses the entire screen.
4275
4276 * w32term.h (w32_fullscreen_rect) Add prototype.
4277 (struct w32_output): Replace normal_width, normal_height,
4278 normal_top, and normal_left members with a single normal_placement
4279 struct.
4280 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4281 Remove macros.
4282 (FRAME_NORMAL_PLACEMENT): New macro.
4283
9cc2810b
JB
42842013-04-16 Juanma Barranquero <lekktu@gmail.com>
4285
4286 * minibuf.c (Ftest_completion): Silence compiler warning.
4287
fd16b54c
EZ
42882013-04-15 Eli Zaretskii <eliz@gnu.org>
4289
4290 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4291 bug#14062.
fd16b54c
EZ
4292
4293 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4294 parentheses.
4295
4296 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4297 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4298 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4299 parentheses where appropriate.
4300
9e3379a0
PE
43012013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4302
4303 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4304
ddd6b685
EZ
43052013-04-14 Eli Zaretskii <eliz@gnu.org>
4306
4307 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4308 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4309 Mention in the doc string that setting these variables takes
4310 effect only after a call to set-window-buffer. (Bug#14200)
4311
29b79ba1
EZ
43122013-04-13 Eli Zaretskii <eliz@gnu.org>
4313
4314 * indent.c (Fvertical_motion): Don't consider display strings on
4315 overlay strings as display strings on the buffer position we
4316 started from. This prevents vertical cursor motion from jumping
4317 more than one line when there's an overlay string with a display
4318 property at end of line.
4319 Reported by Karl Chen <Karl.Chen@quarl.org> in
4320 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4321
562c6ee9
SM
43222013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4323
4324 * window.c (select_window): `record_buffer' even if window is
4325 already selected (bug#14191).
4326
fcc1fe85
EZ
43272013-04-11 Eli Zaretskii <eliz@gnu.org>
4328
4329 * window.c (Fwindow_end): Test more flags, including the buffer's
4330 last_overlay_modified flag, to determine whether the window's
4331 display is really up-to-date. Prevents the function from
4332 returning a stale value. (Bug#14170)
4333 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4334 current matrix.
4335
f009190a
EZ
43362013-04-10 Eli Zaretskii <eliz@gnu.org>
4337
4338 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4339 garbaged only if it is not already the top frame on its TTY.
4340 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4341 there are GUI frames open in the same session. (Bug#13864)
4342
78ce603d
SM
43432013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4344
4345 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4346 of marking the idle timers directly.
4347
a8036e40
SM
43482013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4349
4350 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4351 tables (bug#14054).
4352
7ffe7ef6
SM
43532013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4354
4355 * window.c (select_window): Don't record_buffer while the invariant is
4356 temporarily broken (bug#14161).
4357
4358 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4359
7d9f6883
EZ
43602013-04-07 Eli Zaretskii <eliz@gnu.org>
4361
4362 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4363
5406cfd9
RF
43642013-04-07 Romain Francoise <romain@orebokech.com>
4365
4366 Ignore additional platform-specific ACL errors (Bug#13702).
4367 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4368 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4369
95c0e83b
JD
43702013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4371
4372 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4373 f->output_data.ns.
4374
876da980
PE
43752013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4376
4377 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4378 This bug was introduced by my 2013-02-25 change that simplified
4379 data_start configuration. Without this change, on GNU/Linux
4380 an Emacs configured with --enable-profiling fails immediately
4381 due to a profiler signal.
4382 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4383 with these flags. On platforms where special flags are needed
4384 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4385 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4386 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4387
7452b7bd
DA
43882013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4389
4390 Get rid of some platform-specific functions examining window
4391 system and its capabilities. This is a partial rework of the
4392 2013-04-05 change.
4393 * lisp.h (have_menus_p): Remove prototype. This function is
4394 replaced with platform-independent window_system_available.
4395 (check_window_system): Move to...
4396 * frame.h (decode_window_system_frame, window_system_available):
4397 ...here, add new prototypes.
4398 * frame.c (window_system_available, decode_window_system_frame):
4399 New functions.
4400 (check_window_system): Platform-independent now.
4401 * xterm.h (x_in_use): Remove declaration.
4402 (check_x_frame):
4403 * w32term.h (check_x_frame):
4404 * nsterm.h (check_x_frame): Remove prototypes. This function
4405 is replaced with platform-independent decode_window_system_frame.
4406 * msdos.c (have_menus_p): Remove.
4407 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4408 Remove platform-specific functions. Use check_window_system,
4409 decode_window_system_frame and check_ns_display_info where
4410 appropriate. Minor style and comment tweaks.
4411 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4412 (check_x_frame): Likewise.
4413 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4414 Likewise.
4415 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4416 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4417 * xmenu.c, xselect.c: All related users changed.
4418
251e9147
KH
44192013-04-03 Kenichi Handa <handa@gnu.org>
4420
4421 The following changes is to optimize the code for reading UTF-8
4422 files.
4423
562c6ee9 4424 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4425 changed. Check EOL format. Do not call adjust_coding_eol_type
4426 here.
4427 (check_utf_8): New function.
4428 (adjust_coding_eol_type): Do nothing if already adjusted.
4429 (detect_coding): Compare the return value of check_ascii with
4430 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4431 (decode_coding_gap): Optimize for valid UTF-8.
4432
8bc369d4
KH
44332013-03-21 Kenichi Handa <handa@gnu.org>
4434
4435 * coding.c (syms_of_coding): Cancel previous change.
4436
4437 * insdel.c (insert_from_gap): Fix previous change.
4438
73931ad1
DA
44392013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4440
4441 Consistently use platform-specific function to detect window system.
4442 * lisp.h (check_window_system): New prototype. This function is
4443 going to replace check_x, check_w32 and check_ns.
4444 (have_menus_p): Mention msdos.c in comment.
4445 * fontset.c (check_window_system_func): Remove. Adjust all users.
4446 * fontset.h (check_window_system_func): Remove prototype.
4447 * nsterm.h (check_ns):
4448 * xterm.h (check_x):
4449 * w32term.h (check_w32): Likewise.
4450 * menu.c (Fx_popup_menu): Use check_window_system.
4451 * msdos.c (check_window_system): Define for MS-DOS.
4452 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4453 * w32fns.c (check_window_system): Likewise for MS-Windows.
4454 * xfns.c (check_window_system): Likewise for X.
4455 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4456 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4457
7216e43b
PE
44582013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4459
4460 Prefer < to > in range checks such as 0 <= i && i < N.
4461 This makes it easier to visualize quantities on a number line.
4462 This patch doesn't apply to all such range checks,
4463 only to the range checks affected by the 2013-03-24 change.
4464 This patch reverts most of the 2013-03-24 change.
4465 * alloc.c (xpalloc, Fgarbage_collect):
4466 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4467 * character.c (string_escape_byte8):
4468 * charset.c (read_hex):
4469 * data.c (cons_to_unsigned):
4470 * dispnew.c (update_frame_1):
4471 * doc.c (Fsubstitute_command_keys):
4472 * doprnt.c (doprnt):
4473 * editfns.c (hi_time, decode_time_components):
4474 * fileio.c (file_offset):
4475 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4476 * font.c (font_intern_prop):
4477 * frame.c (x_set_alpha):
4478 * gtkutil.c (get_utf8_string):
4479 * indent.c (check_display_width):
4480 * keymap.c (Fkey_description):
4481 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4482 * lread.c (read1):
4483 * minibuf.c (read_minibuf_noninteractive):
4484 * process.c (wait_reading_process_output):
4485 * search.c (Freplace_match):
4486 * window.c (get_phys_cursor_glyph):
4487 * xdisp.c (redisplay_internal):
4488 * xsmfns.c (smc_save_yourself_CB):
4489 Prefer < to > for range checks.
4490 * dispnew.c (sit_for): Don't mishandle NaNs.
4491 This fixes a bug introduced in the 2013-03-24 change.
4492 * editfns.c (decode_time_components): Don't hoist comparison.
4493 This fixes another bug introduced in the 2013-03-24 change.
4494
92759988
DA
44952013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4496
4497 * frame.h (struct frame): Drop scroll_bottom_vpos
4498 member becaue all real users are dead long ago.
4499 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4500 * xdisp.c (redisplay_internal): Adjust user.
4501
9a1971bb
GM
45022013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4503
f38ab167
JD
4504 * nsmenu.m (showAtX:Y:for:): setLevel to
4505 NSPopUpMenuWindowLevel (Bug#13998).
4506
6d01f1fe
JD
45072013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4508
4509 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4510 (ns_check_pending_open_menu): Declare.
4511
4512 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4513 (x_activate_menubar): Update the menu with title that matches
4514 ns_get_pending_menu_title, and call
4515 ns_check_pending_openmenu (Bug#12698).
4516 (menuWillOpen:): New method.
4517 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4518
4519 * nsterm.m (menu_will_open_state, menu_mouse_point)
4520 (menu_pending_title): New varaibles.
4521 (ns_get_pending_menu_title, ns_check_menu_open)
4522 (ns_check_pending_open_menu): New functions.
4523
781f4782
DA
45242013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4525
4526 * indent.c (current_column_bol_cache): Remove leftover which is not
4527 used in Fmove_to_column any more.
4528 (current_column, scan_for_column): Adjust users.
4529 * keyboard.c (last_point_position_buffer, last_point_position_window):
4530 Remove leftovers which are not used for recording undo any more.
4531 (command_loop_1, syms_of_keyboard): Adjust users.
4532 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4533 redisplay_window any more.
4534 (move_it_to): Adjust user.
4535
1921c31b
JB
45362013-03-29 Juanma Barranquero <lekktu@gmail.com>
4537
4538 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4539 Update dependencies.
4540
717b8bcd
SM
45412013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4542
4543 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4544 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4545 forward references.
4546
e74aeda8
DA
45472013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4548
4549 * window.h (struct window): Replace hchild, vchild and buffer slots
4550 with the only contents slot. This is possible because each valid
4551 window may have either the child window (in vertical or horizontal
4552 combination) or buffer to display (for the leaf window). Using that,
4553 a lof of operations to traverse and/or change window hierarchies may
4554 be simplified. New member horizontal is used to distinguish between
4555 horizontal and vertical combinations of internal windows.
4556 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4557 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4558 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4559 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4560 Use contents slot, not buffer, where appropriate.
4561 (wset_combination): New function.
4562 (wset_buffer): Add eassert.
4563 (Fframe_first_window): Simplify the loop reaching first window.
4564 (Fwindow_buffer): Use WINDOW_LEAF_P.
4565 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4566 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4567 (unshow_buffer): Convert initial debugging check to eassert.
4568 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4569 (make_parent_window, window_resize_check, window_resize_apply)
4570 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4571 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4572 Adjust to match struct window changes.
4573 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4574 (mark_window_cursors_off, count_windows, get_leaf_windows)
4575 (foreach_window_1): Simplify the loop.
4576 * alloc.c (mark_object): Do not check for the leaf window because
4577 internal windows has no glyph matrices anyway.
4578 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4579 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4580 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4581 (build_frame_matrix_from_window_tree, mirror_make_current)
4582 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4583 (update_window_tree, set_window_update_flags): Simplify the loop.
4584 (sync_window_with_frame_matrix_rows): Enforce live window.
4585 Use contents slot, not buffer, where appropriate.
4586 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4587 and WINDOW_HORIZONTAL_COMBINATION_P.
4588 (make_frame_visible_1): Simplify the loop.
4589 Use contents slot, not buffer, where appropriate.
4590 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4591 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4592 (expose_window_tree): Likewise.
4593 Use contents slot, not buffer, where appropriate.
4594 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4595 to avoid deleted windows. Use contents slot instead of buffer.
4596 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4597 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4598 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4599 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4600
121ab1cd
EZ
46012013-03-28 Eli Zaretskii <eliz@gnu.org>
4602
ef454cf7
EZ
4603 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4604 identify the reasons for assertion violations in bug#14062 and
4605 similar ones.
21e930f8
EZ
4606 (Fx_show_tip): Fix compilation error under
4607 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4608
121ab1cd
EZ
4609 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4610 Reported by <rzl24ozi@gmail.com>.
4611
5c89ca24
DA
46122013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4613
4614 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4615 start marker...
562c6ee9
SM
4616 (unwind_with_echo_area_buffer): ...to restore it here.
4617 This is needed to ensure that...
5c89ca24
DA
4618 (redisplay_window): ...both window markers are valid here,
4619 which is verified by eassert.
4620 * editfns.c (save_excursion_save): Do not assume that
4621 selected_window always displays the buffer.
c7f53895
DA
4622 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4623 Fix comment.
5c89ca24 4624
f557c1b1
SM
46252013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4626
4627 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4628 the upcase table.
4629
40693bba 46302013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4631
4632 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4633
c86f791f
EZ
46342013-03-27 Eli Zaretskii <eliz@gnu.org>
4635
4636 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4637 since MinGW's w32api headers do. This avoids compiler warnings.
4638
4639 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4640 if already defined.
4641
c6e72e17
EZ
46422013-03-26 Eli Zaretskii <eliz@gnu.org>
4643
4644 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4645
54e95010
JD
46462013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4647
4648 * gtkutil.c (style_changed_cb): Check if frame is live and an
4649 X frame (Bug#14038).
4650
b88b62de
EZ
46512013-03-26 Eli Zaretskii <eliz@gnu.org>
4652
a18d7de6
EZ
4653 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4654 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4655 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4656 MinGW64.
8f5e14c8
EZ
4657 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4658 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4659
b88b62de
EZ
4660 Fix incompatibilities between MinGW.org and MinGW64 headers.
4661 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4662
4663 * w32.c (REPARSE_DATA_BUFFER): Guard with
4664 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4665
c074e458
JD
46662013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4667
4668 * xterm.c: Include X11/XKBlib.h
4669 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4670
908589fd
AS
46712013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4672
4673 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4674 written backwards.
4675 * blockinput.h (input_blocked_p): Likewise.
4676 * bytecode.c (exec_byte_code): Likewise.
4677 * callproc.c (call_process_kill, call_process_cleanup)
4678 (Fcall_process): Likewise.
4679 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4680 (Fccl_execute_on_string): Likewise.
4681 * character.c (string_escape_byte8): Likewise.
4682 * charset.c (read_hex): Likewise.
4683 * cm.c (calccost): Likewise.
4684 * data.c (cons_to_unsigned): Likewise.
4685 * dired.c (directory_files_internal, file_name_completion):
4686 Likewise.
4687 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4688 (sit_for): Likewise.
4689 * doc.c (Fsubstitute_command_keys): Likewise.
4690 * doprnt.c (doprnt): Likewise.
4691 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4692 * emacsgtkfixed.c: Likewise.
4693 * fileio.c (file_offset, Fwrite_region): Likewise.
4694 * floatfns.c (Fexpt, fmod_float): Likewise.
4695 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4696 Likewise.
4697 * font.c (font_intern_prop): Likewise.
4698 * frame.c (x_set_alpha): Likewise.
4699 * gtkutil.c (get_utf8_string): Likewise.
4700 * indent.c (check_display_width): Likewise.
4701 * intervals.c (create_root_interval, rotate_right, rotate_left)
4702 (split_interval_right, split_interval_left)
4703 (adjust_intervals_for_insertion, delete_node)
4704 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4705 (merge_interval_right, merge_interval_left, copy_intervals)
4706 (set_intervals_multibyte_1): Likewise.
4707 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4708 * keymap.c (Fkey_description): Likewise.
4709 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4710 * lread.c (openp, read_integer, read1, string_to_number):
4711 Likewise.
4712 * menu.c (ensure_menu_items): Likewise.
4713 * minibuf.c (read_minibuf_noninteractive): Likewise.
4714 * print.c (printchar, strout): Likewise.
4715 * process.c (create_process, Faccept_process_output)
4716 (wait_reading_process_output, read_process_output, send_process)
4717 (wait_reading_process_output): Likewise.
4718 * profiler.c (make_log, handle_profiler_signal): Likewise.
4719 * regex.c (re_exec): Likewise.
4720 * regex.h: Likewise.
4721 * search.c (looking_at_1, Freplace_match): Likewise.
4722 * sysdep.c (get_child_status, procfs_ttyname)
4723 (procfs_get_total_memory): Likewise.
4724 * systime.h (EMACS_TIME_VALID_P): Likewise.
4725 * term.c (dissociate_if_controlling_tty): Likewise.
4726 * window.c (get_phys_cursor_glyph): Likewise.
4727 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4728 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4729 Likewise.
4730 * xfns.c (Fx_window_property): Likewise.
4731 * xmenu.c (set_frame_menubar): Likewise.
4732 * xselect.c (x_get_window_property, x_handle_dnd_message):
4733 Likewise.
4734 * xsmfns.c (smc_save_yourself_CB): Likewise.
4735 * xterm.c (x_scroll_bar_set_handle): Likewise.
4736
2bf7d27a
DA
47372013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4738
4739 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4740 to be optional or nil. Adjust comment and convert it to docstring.
4741 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4742 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4743
a9ebfa0b
PE
47442013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4745
4746 Static checking by GCC 4.8-20130319.
4747 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4748 * process.c (Fset_process_datagram_address)
4749 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4750 * xdisp.c (get_char_face_and_encoding):
4751 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4752 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4753 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4754
4f3576ee
KB
47552013-03-24 Ken Brown <kbrown@cornell.edu>
4756
789b5e9a
KB
4757 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4758 fix compilation on 64-bit Cygwin, where underscores are not
4759 automatically prepended.
4760
4f3576ee
KB
4761 * w32term.c (w32_initialize): Silence compiler warning.
4762
b5b7745f
EZ
47632013-03-23 Eli Zaretskii <eliz@gnu.org>
4764
cdc0d0bd
EZ
4765 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4766 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4767 variables, to save and restore frame dimensions.
4768 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4769 after returning from a 'fullscreen' configuration.
4770 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4771 to avoid races between the main thread and the input thread.
4772
4773 * w32term.h (struct w32_output): New members normal_width,
4774 normal_height, normal_top, normal_left, and prev_fsmode.
4775 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4776 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4777 members of a frame.
4778
b5b7745f
EZ
4779 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4780 'fullscreen' parameter. Always record previous width and height
4781 of the frame, except when switching out of maximized modes, so
4782 that they could be restored correctly, instead of resetting to the
4783 default frame dimensions. Send SC_RESTORE command to the frame,
4784 unless we are going to send SC_MAXIMIZE, to restore the frame
4785 resize hints in the mouse pointer shown by the window manager.
4786 (Bug#14032)
4787
4788 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4789
4790 * lisp.h (get_frame_param): Adjust conditions for prototype
4791 declaration.
4792
a3454eed
KB
47932013-03-22 Ken Brown <kbrown@cornell.edu>
4794
4795 * unexcw.c: Drop unneeded inclusion of w32common.h.
4796 (report_sheap_usage): Declare.
4797 (read_exe_header): Add magic numbers for x86_64.
4798 (fixup_executable): Fix printf format specifier for unsigned long
4799 argument.
4800
5a49b79c
DA
48012013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4802
4803 * frame.h (struct frame): Put menu_bar_window under #ifdef
4804 because this member is not needed when X toolkit is in use.
4805 (fset_menu_bar_window):
4806 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4807 (free_glyphs, update_frame):
4808 * xdisp.c (expose_frame): Likewise.
4809 (display_menu_bar): Likewise. Remove redundant eassert.
4810 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4811 toolkit is in use.
4812
d6723bf7
PE
48132013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4814
7b1123d8
PE
4815 Use functions and constants to manipulate Lisp_Save_Value objects.
4816 This replaces code that used macros and strings and token-pasting.
4817 The change makes the C source a bit easier to follow,
4818 and shrinks the Emacs executable a bit.
4819 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4820 (make_save_value): Change 1st arg from string to enum. All callers
4821 changed.
4822 (INTX): Remove.
4823 (mark_object): Use if, not #if, for GC_MARK_STACK.
4824 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4825 (XSAVE_OBJECT): Now functions, not macros.
4826 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4827 the constant was never used.
4828 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4829 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4830 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4831 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4832 New constants.
4833 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4834 type3 with a single member save_type. All uses changed.
4835 (save_type, set_save_pointer, set_save_integer): New functions.
4836 * print.c (PRINTX): Remove.
4837
d6723bf7
PE
4838 * alloc.c: Remove redundant static declarations.
4839
5f24fa51
DA
48402013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4841
4842 * window.h (struct window): Convert left_col, top_line, total_lines
4843 and total_cols from Lisp_Objects to integers. Adjust comments.
4844 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4845 Remove.
4846 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4847 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4848 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4849 Adjust users where appropriate.
4850
42143acd
DA
48512013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4852
4853 * frame.h (struct frame): Drop resx and resy because the same data is
4854 available from window system-specific output context. Adjust users.
562c6ee9
SM
4855 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4856 New functions to provide defaults when no window system available.
42143acd 4857 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4858 (NUMVAL): Move from xdisp.c.
42143acd
DA
4859 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4860 (Ffont_face_attributes, Fopen_font):
4861 * image.c (gs_load):
4862 * w32font.c (fill_in_logfont):
4863 * xdisp.c (calc_pixel_width_or_height):
4864 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4865 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4866
c0a17406
KH
48672013-03-20 Kenichi Handa <handa@gnu.org>
4868
4869 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4870 to 1 (temporary workaround until a bug related to ASCII
4871 optimization is fixed).
4872
095d384d
DA
48732013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4874
4875 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4876 Signal error if window is not internal. Adjust docstring.
4877 (delete_all_child_windows): Use combination_limit to save the buffer.
4878 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4879 * print.c (syms_of_print): Initialize debugging output not here...
4880 (init_print_once): ...but in a new function here.
4881 * lisp.h (init_print_once): Add prototype.
4882 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4883
748fa866
DA
48842013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4885
4886 * window.c (window_resize_check, window_resize_apply)
4887 (window_from_coordinates, recombine_windows, set_window_buffer)
4888 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4889 (Fsplit_window_internal, Fdelete_window_internal)
4890 (freeze_window_starts): Use bool for booleans.
4891 * window.h (window_frame_coordinates, resize_frame_windows)
4892 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4893
81519fd2
SM
48942013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4895
4896 * dispnew.c (bitch_at_user): Use `user-error'.
4897
6db423a9
KB
48982013-03-17 Ken Brown <kbrown@cornell.edu>
4899
4900 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4901 as return type of image_background. (Bug#13981)
4902 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4903
8f2906f5
JD
49042013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4905
960ce480 4906 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4907 (ns_select): Don't return with result uninitialized.
960ce480 4908
8f2906f5
JD
4909 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4910 and getDirectory.
4911
81519fd2
SM
4912 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4913 New functions.
8f2906f5
JD
4914 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4915 directories. If filename is nil, get directory name (Bug#13932).
4916 Use getFilename and getDirectory.
4917 (getFilename, getDirectory): New methods for EmacsSavePanel and
4918 EmacsOpenPanel.
4919 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4920
cded56c1
PE
49212013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4922
4923 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4924
251e9147 49252013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4926
4927 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4928 (adjust_after_replace): Make it back to static. Delete the third
4929 arg text_at_gap_tail. Cancel the code for handling it.
4930
4931 * coding.h (struct coding_system): New member eol_seen.
4932
4933 * coding.c (detect_ascii): New function.
4934 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4935 when the source bytes are actually scanned. On detecting for
4936 coding_category_utf_8_auto, call detect_ascii instead of scanning
4937 source bytes directly.
4938 (produce_chars): Call insert_from_gap with the new arg 0.
4939 (encode_coding): Likewise.
4940 (decode_coding_gap): Control ASCII optimization by the variable
4941 disable_ascii_optimization instead of #ifndef .. #endif.
4942 Deccode EOL format according to coding->eol_seen.
4943 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4944 variable.
4945
8a44e6d1
KH
4946 * lisp.h (adjust_after_replace): Cancel externing it.
4947 (insert_from_gap): Adjust prototype.
4948
5f795e34
EZ
49492013-03-15 Eli Zaretskii <eliz@gnu.org>
4950
4951 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4952 FULLSCREEN_MAXIMIZED. (Bug#13935)
4953
f258b4be
DA
49542013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4955
4956 * region-cache.c (find_cache_boundary, move_cache_gap)
4957 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4958 Simplify debugging check and convert to eassert. Adjust comment.
4959 (pp_cache): Put under ENABLE_CHECKING.
4960
a5cc4dde
EZ
49612013-03-14 Eli Zaretskii <eliz@gnu.org>
4962
4963 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4964 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4965 and WM_ACTIVATEAPP.
4966 (w32fullscreen_hook): If the frame is visible, reset
4967 f->want_fullscreen flag after changing the frame size. If the
4968 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4969 (Bug#13953)
4970
3fc5e44a
DC
49712013-03-13 Daniel Colascione <dancol@dancol.org>
4972
4973 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4974 too so that these builds can use Cygwin's file conversion
4975 functions. (We've been building and linking cygw32.o all along
4976 and just not using it.)
4977
47d7532e
PE
49782013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4979
4980 File synchronization fixes (Bug#13944).
4981 * Makefile.in (LIB_FDATASYNC): New macro.
4982 (LIBES): Use it.
4983 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4984 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4985 Don't worry about HAVE_FSYNC, since a substitute fsync is
4986 available if the system lacks one.
4987 (Fwrite_regin): Retry fsync if interrupted.
4988
c7ffccaf
EZ
49892013-03-13 Eli Zaretskii <eliz@gnu.org>
4990
4e2df81d 4991 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4992 activated, call w32fullscreen_hook, to make sure the new frame
4993 dimensions are in effect. (Bug#13937)
4994
8a7debc1
DA
49952013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4996
4997 * xdisp.c (init_iterator): Simplify because both character and byte
4998 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4999 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5000 character and byte positions can be obtained from marker.
8a7debc1 5001
7fd8c501
PE
50022013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5003
d9df6f40
PE
5004 Static checking by Sun C 5.12.
5005 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5006 * bytecode.c (exec_byte_code):
5007 * dispnew.c (init_display):
5008 * eval.c (error):
5009 * fileio.c (Fsubstitute_in_file_name):
5010 * keyboard.c (Fevent_convert_list):
5011 * keymap.c (Fsingle_key_description):
5012 * term.c (maybe_fatal, fatal):
5013 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5014 * xsmfns.c (Fhandle_save_session):
5015 Omit unreachable code.
5016 * keymap.c (map_keymap_char_table_item): Cast void * to
5017 a function pointer type; the C Standard requires this.
5018
7fd8c501
PE
5019 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5020 Include <sys/param.h> unconditionally, as that works elsewhere and
5021 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5022 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5023 and FreeBSD now.
5024
a020afb9 5025See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5026
5027;; Local Variables:
5028;; coding: utf-8
aac0c6e3
MR
5029;; End:
5030
ab422c4d 5031 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5032
5033 This file is part of GNU Emacs.
5034
5035 GNU Emacs is free software: you can redistribute it and/or modify
5036 it under the terms of the GNU General Public License as published by
5037 the Free Software Foundation, either version 3 of the License, or
5038 (at your option) any later version.
5039
5040 GNU Emacs is distributed in the hope that it will be useful,
5041 but WITHOUT ANY WARRANTY; without even the implied warranty of
5042 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5043 GNU General Public License for more details.
5044
5045 You should have received a copy of the GNU General Public License
5046 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.