Redesign redisplay interface to drop global output_cursor.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f60e429a
DA
12013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Redesign redisplay interface to drop global output_cursor.
4 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
5 (toplevel): Remove declaration of output_cursor.
6 (set_output_cursor, x_cursor_to): Remove prototype.
7 * window.h (struct window): New member output_cursor.
8 (output_cursor_to): New function to replace RIF member.
9 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
10 (update_text_area, set_window_cursor_after_update): Use it.
11 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
12 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
13 * nsterm.m (ns_update_window_begin, ns_update_window_end):
14 * w32term.c (x_update_window_begin, x_update_window_end):
15 * xterm.c (x_update_window_begin, x_update_window_end):
16 Adjust to use per-window output cursor.
17
43aac990
PE
182013-08-27 Paul Eggert <eggert@cs.ucla.edu>
19
d486344e
PE
20 Simplify SELECT_TYPE-related code.
21 Like EMACS_TIME, this portability layer is no longer needed, since
22 Emacs has been using fd_set as a portability layer for some time.
23 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
24 (SELECT_TYPE): Remove. All uses changed to fd_set.
25 (fd_set) [!FD_SET]: New typedef.
26
43aac990
PE
27 Simplify EMACS_TIME-related code.
28 This portability layer is no longer needed, since Emacs has been
29 using struct timespec as a portability layer for some time.
30 * atimer.h, buffer.h, dispextern.h, xgselect.h:
31 Include <time.h> rather than "systime.h"; that's all that's needed now.
32 * dispnew.c: Include <timespec.h> rather than "systime.h";
33 that's all that's needed now.
34 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
35 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
36 TIMESPEC_RESOLUTION.
37 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
38 LOG10_TIMESPEC_RESOLUTION.
39 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
40 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
41 (make_emacs_time): Remove. All used changed to make_timespec.
42 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
43 (current_timespec): Rename from current_emacs_time. All uses changed.
44 (add_emacs_time): Remove. All uses changed to timespec_add.
45 (sub_emacs_time): Remove. All uses change dot timespec_sub.
46 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
47 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
48 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
49 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
50 (current_timespec): Rename from current_emacs_time. All uses changed.
51 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
52 changed to timespec_cmp.
53 * xgselect.c: Include <timespec.h>, since our .h files don't.
54
d350e350
DA
552013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
56
57 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
58 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
59 Remove the leftovers.
60 * gtkutil.c (toplevel): Do not declare Qxft but include
61 font.h to do so.
62 * image.c (toplevel): Do not declare Vlibrary_cache because
63 it's already done in lisp.h.
64
9fed9729
DA
652013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
66
67 * lisp.h (Mouse_HLInfo): Move from here...
68 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
69 (reset_mouse_highlight): New function.
70 * msdos.c (dos_set_window_size, IT_update_begin)
71 (internal_terminal_init):
72 * nsterm.m (ns_update_window_end, x_free_frame_resources)
73 (ns_initialize_display_info):
74 * w32console.c (initialize_w32_display):
75 * w32term.c (x_update_window_end, x_free_frame_resources)
76 (w32_initialize_display_info):
77 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
78 * window.c (Fdelete_other_windows_internal):
79 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
80 * termchar.h (toplevel):
81 * xterm.h (toplevel): Include dispextern.h.
82
f462f075
PE
832013-08-26 Paul Eggert <eggert@cs.ucla.edu>
84
85 Fix minor problems found by static checking.
86 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
87 (expect): Avoid nested-if warning.
88 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
89 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
90 * nsterm.h, nsterm.m (ns_select):
91 * xgselect.c, xgselect.h (xg_select):
92 Adjust signature to better match pselect's.
93 * nsterm.m (ns_select):
94 Don't set *TIMEOUT, since pselect doesn't.
95 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
96 diagnostic about assigning const char * to it.
97 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
98
068f9124
SM
992013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * lread.c (substitute_object_recurse): Handle hash-tables as well
102 (bug#15190).
103
f5adc984
PE
1042013-08-26 Paul Eggert <eggert@cs.ucla.edu>
105
1fc8eb33
PE
106 Fix unlikely core dump in init_tty, and simplify terminfo case.
107 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
108 The old version incorrectly dumped core if malloc returned a
109 buffer containing only non-NUL bytes.
110 (init_tty): Do not allocate or free termcap buffers; the
111 struct does that for us now.
112 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
113 (struct tty_display_info): Define members termcap_term_buffer and
114 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
115 use them. Allocate them directly in struct rather than indirectly
116 via a pointer, to simplify init_tty.
117
f5adc984
PE
118 * frame.c (check_minibuf_window): Initialize 'window' properly,
119 so that Emacs reliably aborts later if 'window' is not initialized.
120
efec3894
JD
1212013-08-26 Jan Djärv <jan.h.d@swipnet.se>
122
123 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
124 of VoidSymbol (Bug#15154).
125
e1d0341e
DA
1262013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
127
128 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
129 mouse_face_beg_y and mouse_face_end_y.
130 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
131 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
132 Adjust users and update comment where appropriate.
133
bfff6445
MR
1342013-08-26 Martin Rudalics <rudalics@gmx.at>
135
136 * frame.c (check_minibuf_window): New function.
068f9124
SM
137 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
138 Call check_minibuf_window (Bug#15183).
bfff6445 139
c80016b3
DA
1402013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
141
142 * window.h (struct window): Replace last_cursor with last_cursor_vpos
143 because this is the only last cursor data we need to keep and consult.
144 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
145 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
146 Adjust users.
147
de396731
DA
1482013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
149
068f9124
SM
150 Fix recovering from possible decompression error.
151 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 152 the position where the partially decompressed data ends, and
447218dd 153 should count how many bytes was produced so far.
de396731
DA
154 * decompress.c (struct decompress_unwind_data): Add nbytes member.
155 (unwind_decompress): Really delete partially uncompressed data.
156 (Fzlib_decompress_region): Take decompressed data size into account.
157
c76826d9
DA
1582013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
159
160 * syntax.c (init_syntax_once): Adjust comment and do an early
161 initialization of Qchar_table_extra_slots just once...
162 * casetab.c (init_casetab_once):
163 * category.c (init_category_once):
164 * character.c (syms_of_character):
165 * coding.c (syms_of_coding):
166 * xdisp.c (syms_of_xdisp): ...and omit it here.
167
b34454d0
EZ
1682013-08-24 Eli Zaretskii <eliz@gnu.org>
169
11f20add
EZ
170 * xdisp.c (get_next_display_element): Don't apply to characters
171 from a display vector the logic of setting it->end_of_box_run_p
172 suitable for characters from a buffer. (Bug#15175)
173
b34454d0
EZ
174 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
175 to handle directories, rather than '_utime' which doesn't.
176 (Bug#15176)
177
6e1b469e
JD
1782013-08-24 Jan Djärv <jan.h.d@swipnet.se>
179
180 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
181 or fullscreen (Bug#14627).
182
9c05bccf
PE
1832013-08-24 Paul Eggert <eggert@cs.ucla.edu>
184
185 System-dependent integer overflow fixes.
186 * process.c (Fset_process_window_size): Signal an error if
187 the window size is outside the range supported by the lower level.
188 * sysdep.c (set_window_size): Return negative on error,
189 nonnegative on success, rather than -1, 0, 1 on not in system,
190 failure, success. This is simpler. Caller changed.
191 (serial_configure): Remove unnecessary initialization of local.
192 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
193 size fits in unsigned long; this isn't true on some 32-bit hosts.
194 Avoid buffer overrun if some future version of /proc/meminfo has a
195 variable name longer than 20 bytes.
196 (system_process_attributes) [__FreeBSD__]:
197 Don't assume hw.availpages fits in 'int'.
198
c365c355
PE
1992013-08-23 Paul Eggert <eggert@cs.ucla.edu>
200
201 Don't let very long directory names overrun the stack.
202 Fix some related minor problems involving "//", vfork.
203 * callproc.c (encode_current_directory): New function.
204 (call_process): Don't append "/"; not needed.
205 * fileio.c (file_name_as_directory_slop): New constant.
206 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
207 this can save the caller having to alloca.
208 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
209 Use SAFE_ALLOCA, not alloca.
210 (directory_file_name, Fexpand_file_name): Leave leading "//"
211 alone, since it can be special even on POSIX platforms.
212 * callproc.c (call_process):
213 * process.c (Fformat_network_address):
214 * sysdep.c (sys_subshell):
215 Use encode_current_directory rather than rolling our own.
216 (create_process): No need to encode directory; caller does that now.
217 * process.h (encode_current_directory): New decl.
218 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
219 Rework to avoid 'goto xyzzy;'.
220
6c6014d4
EZ
2212013-08-23 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (handle_face_prop): If the default face was remapped use
224 the remapped face for strings from prefix properties. (Bug#15155)
225
9997ec56
DA
2262013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
227
228 Minor cleanup for redisplay interface and few related functions.
229 * frame.h (enum text_cursor_kinds): Move from here...
230 * dispextern.h (enum text_cursor_kinds): ...to here.
231 (toplevel): Drop unnecessary declarations.
232 (struct redisplay_interface): Use bool and enum text_cursor_kinds
233 in update_window_end_hook and draw_window_cursor functions.
234 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
235 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
236 * w32term.c (x_update_window_end,w32_draw_window_cursor):
237 * xterm.c (x_update_window_end, x_draw_window_cursor):
238 * xdisp.c (display_and_set_cursor, update_window_cursor)
239 (update_cursor_in_window_tree, x_update_cursor): Use bool and
240 enum text_cursor_kinds where appropriate.
241
7f780da6
DA
2422013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
243
244 Redesign redisplay interface to drop updated_row and updated_area.
245 * dispextern.h (updated_row, updated_area): Remove declaration.
246 (struct redisplay_interface): Pass glyph row and row area parameters
247 to write_glyphs, insert_glyphs and clear_end_of_line functions.
248 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
249 Adjust prototypes.
250 * dispnew.c (updated_row, updated_area): Remove.
251 (redraw_overlapped_rows, update_window_line): Adjust user.
252 (update_marginal_area, update_text_area): Likewise. Pass updated row
253 as a parameter. Prefer enum glyph_row_area to int where appropriate.
254 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
255 Adjust users.
256
26495794
PE
2572013-08-22 Paul Eggert <eggert@cs.ucla.edu>
258
259 * process.c (flush_pending_output): Remove stub.
260 All uses removed.
261
4a88129a
PE
2622013-08-21 Paul Eggert <eggert@cs.ucla.edu>
263
264 * callproc.c: Fix race that killed background processes (Bug#15144).
265 (call_process): New arg TEMPFILE_INDEX. Callers changed.
266 Record deleted process-id in critical section, not afterwards.
267 Don't mistakenly kill process created by a call-process invocation
268 that discards output and does not wait.
269
0c5307b0
DA
2702013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
271
272 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
273 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
274 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
275 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
276 to shut up compiler in mark_object.
277 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
278
0d7c1e66
PE
2792013-08-21 Paul Eggert <eggert@cs.ucla.edu>
280
281 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
282 We can't portably rely on PTY_OPEN doing that, even if
283 it calls posix_openpt with O_CLOEXEC.
284
3f246b65
KH
2852013-08-20 Kenichi Handa <handa@gnu.org>
286
287 * character.c (string_char): Improve commentary.
288
8c2f38aa
PE
2892013-08-20 Paul Eggert <eggert@cs.ucla.edu>
290
291 * image.c (SIGNATURE_DIGESTSIZE): Remove.
292 (struct animation_cache): Make signature a flexible array member.
293 All uses changed. This is a tad slower but may insulate us better
294 from future changes to ImageMagick.
295
bb566cea
PE
2962013-08-19 Paul Eggert <eggert@cs.ucla.edu>
297
298 * image.c: Shrink memory needed for animation cache.
299 (SIGNATURE_DIGESTSIZE): New constant.
300 (struct animation_cache): Make 'signature' a fixed size array of bytes.
301 (imagemagick_create_cache): Copy the signature. This saves
302 several KB of memory that ImageMagick wastes per signature.
303 Don't bother updating the update_time, as the caller does that now.
304 (imagemagick_prune_animation_cache): Don't destroy the signature, as
305 it's a fixed size struct member now.
306 (imagemagick_get_animation_cache): Always destroy the signature,
307 as it's now imagemagick_create_cache's responsibility to copy it.
308 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
309 and use memcmp rather than strcmp.
310 eassert that ImageMagick returns a signature of the specified length.
311
6da26928
LMI
3122013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
313
314 * image.c (imagemagick_get_animation_cache): Don't segfault on
315 each invocation.
453f4022
LMI
316 (imagemagick_get_animation_cache): Revert to previous definition
317 so that it actually works. But keep the memory leak fix.
318 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 319
22490125
PE
3202013-08-19 Paul Eggert <eggert@cs.ucla.edu>
321
d0139df5
PE
322 * image.c: Fix animation cache signature memory leak.
323 Fix some other minor performance problems while we're at it.
324 (imagemagick_create_cache): Clear just the members that
325 need clearing. Don't set update_time, as caller does that now.
326 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
327 Simplify by using pointer-to-pointer instead of a prev pointer.
328 (imagemagick_prune_animation_cache): Use make_emacs_time rather
329 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
330 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
331 it's already a copy. Free the signature probe unless it's cached.
332
22490125
PE
333 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
334 This was introduced by my 2013-08-12 fix for Bug#15035.
335
deb31e75
DA
3362013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
337
338 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
339 (imagemagick_prune_animation_cache): Now static.
340
319a4d03
LMI
3412013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
342
343 * image.c (imagemagick_get_animation_cache): Don't segfault when
344 pruning all entries.
345
f747d82e
KB
3462013-08-18 Ken Brown <kbrown@cornell.edu>
347
348 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
349 static heap if ENABLE_CHECKING is defined.
350 (max_bss_sbrk_ptr): New variable.
351 (bss_sbrk): Use it.
352 (report_sheap_usage): Report maximum static heap usage instead of
353 ending static heap usage.
354
d2c28fab
EZ
3552013-08-17 Eli Zaretskii <eliz@gnu.org>
356
357 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
358 of zlib_initialized according to the results of calling
359 init_zlib_functions.
360
274ff63f
LMI
3612013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
362
363 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 364 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
365 (imagemagick_load_image): Remove the ping_wand code, which only
366 apparently saved time on invalid animated images, and slowed down
367 everything else. Optimise for the common case.
274ff63f 368
2bede2ed
XF
3692013-08-16 Xue Fuqiao <xfq.free@gmail.com>
370
70ff8240
XF
371 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
372
de179a3e
XF
373 * editfns.c (insert_before_markers): Mention overlay in the doc string.
374
2bede2ed
XF
375 * marker.c (set_marker): Remove documentation of undefined behavior.
376
703dbeba
LMI
3772013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
378
379 * image.c (imagemagick_compute_animated_image): Animate correctly
380 when sub-images are smaller than the main image.
1d18b1e6
LMI
381 (imagemagick_compute_animated_image): Setting the iterator row to
382 zero is apparently not allowed.
79670014
LMI
383 (imagemagick_compute_animated_image): Allow images that say they
384 have sub-images that are bigger than the main image, but just crop
385 them.
703dbeba 386
63216c5e
JD
3872013-08-15 Jan Djärv <jan.h.d@swipnet.se>
388
389 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
390
a5b5f73f
LMI
3912013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
392
393 * image.c (imagemagick_compute_animated_image): Respect the GIF
394 disposal methods.
395
0fe73012
KB
3962013-08-15 Ken Brown <kbrown@cornell.edu>
397
398 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
399 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
400 needed.
401
691a357f
PE
4022013-08-15 Paul Eggert <eggert@cs.ucla.edu>
403
404 Fix minor problems found by static checking.
405 * frame.c (delete_frame):
406 * xdisp.c (next_element_from_display_vector):
407 Avoid uninitialized local.
408 * image.c (imagemagick_compute_animated_image): Port to C89.
409 Prefer usual GNU indentation style for loops.
410 Be more careful about bizarrely large sizes, by using ptrdiff_t
411 instead of int.
412
42fe2e88
DA
4132013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
414
415 Fix infinite frame selection loop (Bug#15025).
416 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
417
d39a3da6
EZ
4182013-08-15 Eli Zaretskii <eliz@gnu.org>
419
068f9124
SM
420 * xdisp.c (compute_window_start_on_continuation_line):
421 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
422 to make sure we end up setting the window start at the leftmost
423 visible character of the display line. This avoids funky
424 horizontal shifting because the window start is not kept on the
425 same position. (Bug#15090)
05426239
EZ
426 (next_element_from_display_vector): Support 'box' face attribute
427 in the face definitions of a display vector. (Bug#15099)
d39a3da6 428
6e856b69
LMI
4292013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
430
431 * image.c (imagemagick_compute_animated_image): Implement animated
432 images (bug#14700).
995be755
LMI
433 (imagemagick_compute_animated_image): Fix some compilation
434 warnings. Implement a very simple cache to make the animation
435 usable at all, but it should be replaced with a per-image cache.
6e856b69 436
d5a1acfa
DA
4372013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
438
439 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
440 to do `for' loops over alist values.
441 * buffer.h (FOR_EACH_BUFFER):
442 * process.c (FOR_EACH_PROCESS): Use it.
443 (handle_child_signal, status_notify, Fget_buffer_process)
444 (kill_buffer_processes): Use FOR_EACH_PROCESS.
445
9c253307
DA
4462013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
447
448 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
449 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
450 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
451 to xzalloc and so avoid redundant call to memset.
452 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
453 members because it is allocated with xzalloc and so already zeroed.
454
05e64f9f
KB
4552013-08-14 Ken Brown <kbrown@cornell.edu>
456
457 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
458 (Bug#15094).
459
5b71542d
DA
4602013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
461
462 Utility function and macro to copy Lisp string to C string.
463 * lisp.h (xlispstrdupa): New macro.
464 (xlispstrdup): New prototype.
465 * alloc.c (xlispstrdup): New function.
466 * callint.c (Fcall_interactively):
467 * fileio.c (Ffile_name_directory, Fexpand_file_name)
468 (Fsubstitute_in_file_name):
469 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
470 * image.c (x_create_bitmap_from_file):
471 * w32term.c (w32_term_init):
472 * xterm.c (x_term_init): Use xlispstrdup.
473
71530c97
LMI
4742013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
475
4ce82fb8
LMI
476 * image.c (imagemagick_load_image): Make animated pictures work.
477 There's still some problems with background color settings, though
478 (bug#14700).
479
71530c97
LMI
480 * decompress.c (unwind_decompress): Always restore point.
481
7510a061
XF
4822013-08-14 Xue Fuqiao <xfq.free@gmail.com>
483
484 * marker.c (set_marker): Reformat documentation.
485
01c3051f
PE
4862013-08-14 Paul Eggert <eggert@cs.ucla.edu>
487
aab1fcdf
PE
488 * xdisp.c (cursor_type_changed): Now static.
489
01c3051f
PE
490 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
491 Use changed. This avoids the need to call xmalloc and for the
492 caller to call xfree, and avoids memory leaks in some situations.
493
2084152a
DA
4942013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
495
496 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
497 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
498 (redisplay_window): If window_end_valid is cleared due to non-zero
499 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
500 so do not call to try_cursor_movement for that window.
2084152a 501
02455cb6
DA
5022013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
503
504 * window.h (struct window): Convert window_end_pos and
505 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
506 (wset_window_end_pos, wset_window_end_vpos): Remove.
507 * dispnew.c (adjust_glyph_matrix):
508 * window.c (Fwindow_end, replace_window, set_window_buffer)
509 (make_window):
510 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
511 (set_vertical_scroll_bar, redisplay_window, try_window)
512 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
513 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
514 (note_mouse_highlight): Adjust users.
515 (try_cursor_movement): Likewise. Convert old precondition to eassert.
516 Add comment.
517
da5707e8
DA
5182013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
521 * image.c (imagemagick_filename_hint): Use `const char *' and
522 prefer SSDATA to SDATA to avoid warnings.
523
25554267
DA
5242013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
525
526 Cleanup window fringes, margins and scroll bars adjustments.
527 * window.c (set_window_fringes, set_window_margins)
528 (set_window_scroll_bars, apply_window_adjustment): New functions.
529 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
530 (Fset_window_scroll_bars): Use them.
531
38a2c910
DA
5322013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
533
534 * window.h (struct window): Convert scroll_bar_width
535 from Lisp_Object to integer. Adjust comment.
536 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
537 Adjust users.
538 * window.c (wset_scroll_bar_width): Remove.
539 (make_window): Initialize scroll_bar_width.
540 (Fsplit_window_internal): Use direct assignment.
541 (Fset_window_configuration, save_window_save):
542 Convert Lisp_Object to integer and back where appropriate.
543 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
544 bar was actually changed, and mention this in docstring.
545
2d065031
PE
5462013-08-13 Paul Eggert <eggert@cs.ucla.edu>
547
548 * decompress.c: Minor simplifications.
549 (Fzlib_decompress_region): Don't bother verifying
550 that avail_out <= UINT_MAX, as that was confusing.
551 Mention the restriction in a comment instead.
552 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
553
a5bd5abb
JD
5542013-08-13 Jan Djärv <jan.h.d@swipnet.se>
555
556 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
557 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
558
66e7901a
LMI
5592013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
560
561 * image.c (imagemagick_filename_hint): Check for errors in the
562 alist structure.
563
2fa611b7
EZ
5642013-08-13 Eli Zaretskii <eliz@gnu.org>
565
566 * window.c (Fwindow_margins): Return nil when there's no marginal
567 area, as per the documented API.
568
569 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
570 Fmake_vector, as scroll bar's struct members are not all Lisp
571 objects now. This avoids crashes in GC.
572
573 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
574 bool, so its address could be taken.
575
8259030d
LMI
5762013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
577
578 * image.c (imagemagick_filename_hint): New function to possibly
579 apply `image-content-type-suffixes'.
580 (imagemagick_load_image): Use it.
581
866c710e
EZ
5822013-08-13 Eli Zaretskii <eliz@gnu.org>
583
584 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
585 if loading zlib failed.
586
f10490f0
JD
5872013-08-13 Jan Djärv <jan.h.d@swipnet.se>
588
96311be7
JD
589 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
590 2013-08-13 checkin below. Change bool to BOOL, rule is:
591 All Obj-C code uses BOOL, except for interfaces callable from C.
592
f10490f0
JD
593 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
594
c8ae93b0
DA
5952013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
596
597 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
598 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
599 bool instead of BOOL.
600 * w32term.h (struct scroll_bar): Convert fringe_extended_p
601 from Lisp_Object to bitfield. Adjust comment.
602 * w32term.c (x_scroll_bar_create): Adjust user.
603 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
604 * xterm.c (XTset_vertical_scroll_bar): Likewise.
605 Use bool for boolean.
606 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
607 to `unsigned int' when defining a bitfield.
608
53b64418
PE
6092013-08-13 Paul Eggert <eggert@cs.ucla.edu>
610
611 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
612
eeaf9bf3
DA
6132013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
614
615 * window.h (struct window): Convert left_margin_cols and
616 right_margin_cols from Lisp_Objects to integers. Adjust comment.
617 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
618 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
619 Adjust users.
620 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
621 Adjust comment.
622 (showing_window_margins_p, update_window_line, update_frame_1):
623 * fringe.c (draw_fringe_bitmap_1):
624 * xdisp.c (window_box_width): Adjust users.
625 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
626 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
627 Use direct assignment.
628 (Fset_window_configuration, save_window_save, Fwindow_margins):
629 Convert Lisp_Object to integer and back where appropriate.
630 (Fset_window_margins): Adjust user. Return t if any margin
631 was actually changed, and mention this in docstring.
632
956720af
XF
6332013-08-13 Xue Fuqiao <xfq.free@gmail.com>
634
f73f4ce6 635 * syntax.c (forward_word):
956720af
XF
636 * cmds.c (forward_char, backward_char): Mention the optional argument.
637
9e37ee3b
DA
6382013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
639
640 * window.h (struct window): Convert left_fringe_width
641 and right_fringe_width from Lisp_Objects to integers.
642 Adjust comment.
643 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
644 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
645 * window.c (wset_left_fringe_width, wset_right_fringe_width):
646 Remove.
647 (make_window): Initialize new integer fields to -1.
648 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
649 (Fset_window_configuration, save_window_save):
650 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
651 (Fset_window_fringes): Adjust user. Return t if any fringe
652 was actually changed, and mention this in docstring.
653
e4375ca7
DA
6542013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
655
656 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
657 * nsfns.m (x_set_cursor_type):
658 * w32fns.c (x_set_cursor_type):
659 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
660 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 661
a45543bc
DA
6622013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
663
664 * font.c (clear_font_cache): New function, stripped from...
665 (Fclear_font_cache): ...here, which now uses the function
666 above. Adjust comment.
667 * font.h (clear_font_cache): Add prototype.
668 * xfaces.c (clear_face_cache): Use clear_font_cache.
669
ae966a86
DA
6702013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
671
672 * window.c (Fset_window_start): Compare `w', not `window' because
673 `w' might not be equal to `window' after call to decode_live_window.
674
297a545b
PE
6752013-08-12 Paul Eggert <eggert@cs.ucla.edu>
676
677 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
678 This fixes a problem introduced by the Bug#15035 patch
679 when using GPG. Reported by Herbert J. Skuhra.
680
aa942e2b
EZ
6812013-08-12 Eli Zaretskii <eliz@gnu.org>
682
683 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
684 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
685 not yet initialized.
686
7699d09e
LMI
6872013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
688
689 * decompress.c (Fzlib_decompress_region): Support zlib
690 decompression, too, and rename.
691
1d238bc7
PE
6922013-08-12 Paul Eggert <eggert@cs.ucla.edu>
693
694 Minor zlib configuration tweaks.
695 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
696 Don't assume presence of fn_inflateInit2_ zlib internal function.
697
8a44a184
LMI
6982013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
699
700 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
701 include the zlib prefix.
702
594a4307
EZ
7032013-08-12 Eli Zaretskii <eliz@gnu.org>
704
705 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
706 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
707 define static variables that are pointers to zlib functions to be
708 dynamically loaded.
709 (init_zlib_functions) [WINDOWSNT]: New function.
710 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
711 New macros.
712 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
713 macros instead of invoking the zlib functions directly.
068f9124
SM
714 (syms_of_decompress): DEFSYM Qzlib_dll.
715 Staticpro Szlib_available_p.
594a4307 716
d2e113bc
DA
7172013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
718
719 Avoid looping over all frame windows to freeze and unfreeze.
720 * window.h (struct window): Drop frozen_window_start_p.
721 (freeze_window_starts): Drop prototype.
722 * frame.h (struct frame): New frozen_window_starts flag.
723 (FRAME_WINDOWS_FROZEN): New macro.
724 * window.c (freeze_window_start, freeze_window_starts):
725 Remove.
726 (select_window, replace_window): Adjust users.
727 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
728 (window_frozen_p): New function.
729 (redisplay_window): Use it.
730
94fcd171
PE
7312013-08-12 Paul Eggert <eggert@cs.ucla.edu>
732
733 Fix some fd issues when running subprocesses (Bug#15035).
734 Fix bugs that can leak files or file descriptors on errors.
735 Don't unlink open temp files, as that's hard for users to diagnose
736 when things go awry (e.g., temp disk exhausted).
737 Don't bother to lock temp files. Check for invalid recursion.
738 * callproc.c (synch_process_fd): Remove. All uses removed.
739 (synch_process_tempfile): New var or macro.
740 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
741 New constants.
742 (record_kill_process): New arg, the temp name. All callers changed.
743 (delete_temp_file): Now just a simple wrapper around unlink.
744 (call_process_kill): New arg, the call_process_fd array.
745 Close them all. Clear synch_process_pid. Remove the temp file,
746 or arrange for it to be removed.
747 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
748 that's been moved to synch_process_tempfile. Caller changed.
749 Do not remove the tempfile; that's now call_process_kill's
750 responsibility.
751 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
752 call_process_kill; the caller now does that.
753 (call_process_cleanup): Do not close the process fd; that's now
754 call_process_kill's responsibility.
755 (Fcall_process): Implement via new function call_process, which
756 has most of the old body of Fcall_process, but with a different API.
757 (call_process): New function that does not open or close filefd if
758 it is nonnegative. Record which fds need to be closed, and let
759 call_process_kill close (and remove the tempfile, on MSDOS) on error.
760 Signal an error if invoked recursively (could be done via a hook).
761 Simplify creation of the tempfile in the MSDOS case.
762 Don't create the output file until after checking for the executable.
763 Report any failure to open /dev/null.
764 Don't open /dev/null for writing twice; once is enough.
765 Don't create pipe if all output is being discarded or sent to file.
766 Don't worry about setting up the coding system or reading from the
767 pipe if all output is being discarded.
768 Hoist fd_error local into top level, to lessen block nesting.
769 Don't record deleted pid here; now done by Fcall_process_region.
770 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
771 and note its success in synch_process_tempfile.
772 Do not leak resources when child_setup fails.
773 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
774 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
775 (create_temp_file): Now returns open fd, with an additional
776 Lisp_Object * argument to return the name. All callers changed.
777 Do not close the file; rewind it instead, and leave it open for
778 the caller. Do not lock the temp file. Unwind-protect the file
779 and the file-descriptor.
780 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
781 If an asynchrounous process, record it here, not in call_process.
782 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
783 * eval.c (set_unwind_protect): New function.
784 * fileio.c (write_region): New function, generalized from the
785 old Fwrite_region. Do not lock temp files.
786 (Fwrite_region): Use it.
787 * lisp.h (set_unwind_protect, write_region): New decls.
788 * process.c: Include <verify.h>.
789 (make_process): Mark fds as initially closed.
790 (deleted_pid_list): Now a list of pid-filename pairs.
791 All uses changed.
792 (close_process_fd): New function.
793 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
794 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
795 New constants. Verify that their number matches PROCESS_OPEN_FDS.
796 (create_process, create_pty, Fmake_serial_process)
797 (server_accept_connection): Record which fds need to be closed,
798 and let deactivate_process close them.
799 (Fmake_network_process): Do not discard the unwind-protect
800 until it's safe to do so.
801 (deactivate_process): Close the fds opened by create_process etc.
802 (Fprocess_send_eof): Adjust to new way of recording open fds.
803 Report an error if /dev/null can't be opened, instead of aborting.
804 * process.h (PROCESS_OPEN_FDS): New constant.
805 (struct Lisp_Process): New member open_fds.
806 (record_kill_process, record_deleted_pid): Adjust signatures.
807 (record_deleted_pid): Move decl here ...
808 * syswait.h (record_deleted_pid): ... from here.
809
d0e615c3
PE
8102013-08-11 Paul Eggert <eggert@cs.ucla.edu>
811
812 * decompress.c: Fix bugs with large buffers and weird inputs.
813 Tune a bit. Reindent as per usual Emacs style.
814 (BUFFER_SIZE): Remove.
815 (Fdecompress_gzipped_region): Do not mishandle input buffers with
816 more than UINT_MAX bytes. Decompress into the gap instead of into
817 an auto buffer, as this should avoid copying. Return nil if
818 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
819 set immediate_quit; we shouldn't trust zlib code that much.
820
313546eb
LMI
8212013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
822
99a32242
LMI
823 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
824 errors, and really move the gap to where we want it.
825
313546eb
LMI
826 * lisp.h: Include decompress.c support.
827
828 * emacs.c (main): Include decompress.c support.
829
830 * Makefile.in: Include -lz if present.
831
d2d699ac
JD
8322013-08-11 Jan Djärv <jan.h.d@swipnet.se>
833
f90e3ebd
JD
834 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
835 (initWithTitle:): Initialize frame to 0.
836 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 837 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
838 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
839
840 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
841 fillWithWidgetValue:frame:
842
423d3b3f
JD
843 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
844 remove memory leak warnings.
845
d2d699ac
JD
846 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
847 (ns_check_menu_open): Handle menu == nil. Remove assignment to
848 menu_pending_title.
849
850 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
851 (x_activate_menubar): Update the whole menu.
852 (trackingNotification:): Call ns_check_menu_open if tracking ends.
853 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
854 current event is not NSSystemDefined (Bug#15001).
855 Call ns_check_menu_open only if trackingMenu is 2.
856 (menuDidClose:): New method, decrease trackingMenu.
857 (fillWithWidgetValue:setDelegate:): New method.
858 (fillWithWidgetValue:): Call the above.
859
860 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
861
7d652d97
PE
8622013-08-11 Paul Eggert <eggert@cs.ucla.edu>
863
864 Omit some unnecessary casts.
865 Many of these go back to the old pre-C89 days, when they may have
866 been needed, but we've been assuming C89 or later for a while now.
867 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
868 (live_float_p, live_misc_p, live_vector_p):
869 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
870 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
871 (defvar_per_buffer):
872 * callint.c (Fcall_interactively):
873 * doc.c (Fsubstitute_command_keys):
874 * filelock.c (get_boot_time):
875 * frame.c (xrdb_get_resource):
876 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
877 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
878 (xg_get_file_name_from_selector, menuitem_destroy_callback)
879 (menuitem_highlight_callback, menu_destroy_callback)
880 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
881 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
882 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
883 (xg_tool_bar_help_callback, tb_size_cb):
884 * image.c (xpm_alloc_color, png_read_from_memory)
885 (png_read_from_file, png_load_body, our_memory_skip_input_data)
886 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
887 (syms_of_image):
888 * keymap.c (describe_map):
889 * nsfns.m (Fns_display_monitor_attributes_list):
890 * nsmenu.m (process_dialog:):
891 * nsterm.m (hold_event):
892 * process.c (wait_reading_process_output):
893 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
894 * scroll.c (do_direct_scrolling, scrolling_1):
895 * termcap.c (tgetent):
896 * window.c (check_window_containing, add_window_to_list)
897 (freeze_window_starts):
898 * xdisp.c (compare_overlay_entries, vmessage):
899 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
900 (x_get_monitor_attributes_xrandr)
901 (Fx_display_monitor_attributes_list, x_display_info_for_name)
902 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
903 * xfont.c (xfont_match, xfont_open):
904 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
905 (menubar_selection_callback, menu_position_func)
906 (popup_selection_callback, create_and_show_popup_menu)
907 (dialog_selection_callback, create_and_show_dialog):
908 * xrdb.c (x_get_string_resource):
909 (main) [TESTRM]:
910 * xsmfns.c (x_session_check_input):
911 * xterm.c (x_draw_glyphless_glyph_string_foreground)
912 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
913 (xaw_jump_callback, xaw_scroll_callback):
914 Omit unnecessary casts.
915
9acc1074
PE
9162013-08-10 Paul Eggert <eggert@cs.ucla.edu>
917
918 Minor string-length refactoring.
919 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
920 * frame.c (make_monitor_attribute_list):
921 Prefer build_string to strlen + make_string.
922
361c0eb8
JD
9232013-08-10 Jan Djärv <jan.h.d@swipnet.se>
924
925 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
926 don't check minor_code (Bug#14417).
927
14ba0822
EZ
9282013-08-09 Eli Zaretskii <eliz@gnu.org>
929
930 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
931 vertical positions instead. This avoids calling MATRIX_ROW with
932 row numbers that are possibly beyond valid limits. (Bug#15064)
933
309f24d1
DA
9342013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
935
936 Use xstrdup and build_unibyte_string where applicable.
937 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
938 * xfns.c (x_window):
939 * xrdb.c (x_get_customization_string):
940 * xterm.c (xim_initialize):
941 * w32fns.c (w32_window): Use xstrdup.
942 (w32_display_monitor_attributes_list):
943 * emacs.c (init_cmdargs):
944 * keyboard.c (PUSH_C_STR):
945 * nsfont.m (nsfont_open):
946 * sysdep.c (system_process_attributes):
947 * w32.c (system_process_attributes):
948 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
949
55902276
EZ
9502013-08-09 Eli Zaretskii <eliz@gnu.org>
951
952 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
953 variables of these types so that GDB would know about them, as aid
954 for debugging fatal exceptions. (Bug#15024) See also
955 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
956 discussions.
957
10bf7f5a
JD
9582013-08-08 Jan Djärv <jan.h.d@swipnet.se>
959
960 * nsterm.m (ns_update_begin): Don't change clip path if it would be
961 larger than the NSWindow (Bug#14934).
962
65620264
DA
9632013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
964
965 Redesign redisplay interface to drop global variable updated_window.
966 Always pass currently updated window as a parameter to update routines.
967 * dispextern.h (updated_window): Remove declaration.
968 (struct redisplay_interface): Pass window parameter to
969 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
970 and after_update_window_hook.
971 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
972 Adjust prototypes.
973 * dispnew.c (updated_window): Remove.
974 (redraw_overlapped_rows, update_marginal_area, update_text_area)
975 (update_window_line): Adjust to match redisplay interface changes.
976 * nsterm.m (ns_update_window_begin, ns_update_window_end)
977 (ns_scroll_run, ns_after_update_window_line):
978 * w32term.c (x_update_window_begin, x_update_window_end)
979 (x_after_update_window_line, x_scroll_run):
980 * xterm.c (x_update_window_begin, x_update_window_end)
981 (x_after_update_window_line, x_scroll_run):
982 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
983 Likewise. Adjust comments where appropriate.
984 (x_cursor_to): Simplify because this is always called during window
985 update (but install debugging check anyway).
986 (expose_window): Check must_be_updated_p flag to see whether this
987 function is called during window update.
988
628fdc56
DA
9892013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
990
991 Do not reset window modification event counters excessively.
992 These leftovers and poor man's tricky methods to catch extra
993 redisplay's attention are no longer needed.
994 * frame.c (set_menu_bar_lines_1):
995 * minibuf.c (read_minibuf_unwind):
996 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
997 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
998 (window_scroll_line_based, Fset_window_configuration):
999 * xdisp.c (redisplay_window): Do not reset last_modified and
1000 last_overlay_modified counters.
1001
8fd9c92e
JD
10022013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1003
1004 * xselect.c (x_send_client_event): Set send_event and serial, memset
1005 data.l as it might be bigger than data.b. Use 24 bit mask to
1006 XSendEvent (Bug#15034).
1007
0ee18172
EZ
10082013-08-07 Eli Zaretskii <eliz@gnu.org>
1009
1010 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1011 for TTY frames that are not the top frame on their console.
1012 (Bug#14616)
1013
16ddd1a6
MR
10142013-08-07 Martin Rudalics <rudalics@gmx.at>
1015
1016 * w32term.c (w32fullscreen_hook): Really maximize frame when
1017 asked for (Bug#14841).
1018
d2a95ffb
DA
10192013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1020
1021 Prefer selected_window to Fselected_window, likewise for frames.
1022 * buffer.c (Fbuffer_swap_text):
1023 * data.c (Fvariable_binding_locus):
1024 * window.c (run_window_configuration_change_hook): Adjust users.
1025 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1026 Use decode_live_frame.
1027
170da1ec
DA
10282013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1029
1030 Be more careful if selected window shows the buffer other than current,
1031 use window_outdated only if this is not so. This change should also
1032 address some weird issues discussed in Bug#13012.
1033 * window.h (window_outdated): New prototype.
1034 * window.c (window_outdated): Now here. Convert from static and
1035 always assume window's buffer.
1036 (Fwindow_end, Fwindow_line_height): Use it.
1037 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1038 and always assume window's buffer.
1039 (redisplay_window): Adjust user.
e5eefe9b 1040 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1041 check whether mode line should be updated only if selected window
1042 shows current buffer.
1043 (run_window_scroll_functions): Use eassert for debugging check.
1044 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1045
56b5d5b1
DA
10462013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 * window.c (window_scroll, window_scroll_pixel_based)
1049 (window_scroll_line_based): Use bool for booleans.
1050
2878ba7e
PE
10512013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1052
1053 * process.c: Fix minor off-by-one issues in descriptor counts.
1054 This shouldn't fix any real bugs, but it cleans up the code a bit.
1055 (max_process_desc, max_input_desc): -1, not 0, means none.
1056 All uses changed.
1057 (delete_input_desc): New function.
1058 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1059 (deactivate_process): Scan backwards when recomuting max_process_desc;
1060 that should be faster.
1061 (init_process_emacs): Initialize max_input_desc.
1062
e30b79c1
DA
10632013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1064
1065 Use region cache to speedup bidi_find_paragraph_start.
1066 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1067 Rename cache_long_line_scans to cache_long_scans.
1068 * buffer.c (bset_cache_long_line_scans): Rename to
1069 bset_cache_long_scans.
1070 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1071 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1072 into account.
1073 (syms_of_buffer): Rename cache-long-line-scans to
1074 cache-long-scans. Adjust docstring.
1075 * search.c (newline_cache_on_off):
1076 * indent.c (width_run_cache_on_off): Adjust users.
1077 * bidi.c (bidi_paragraph_cache_on_off): New function.
1078 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1079 * insdel.c (prepare_to_modify_buffer):
1080 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1081
00012b86
DA
10822013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 Invalidate region caches only if buffer text is going to be changed.
1085 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1086 (modify_text): ...new prototype.
1087 (prepare_to_modify_buffer_1): New prototype.
1088 * textprop.c (modify_region): Rename to...
1089 (modify_text_properties): ...new function.
1090 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1091 (Fremove_list_of_text_properties): Adjust users.
1092 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1093 (modify_text): ...new function.
1094 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1095 (prepare_to_modify_buffer_1): ...new function.
1096 * casefiddle.c (casify_region):
1097 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1098 (Ftranspose_regions): Use modify_text.
1099
dc6c0eda
SM
11002013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1101
1102 * lisp.mk (lisp): Add nadvice.elc.
1103
8f3a2c26
DA
11042013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1105
1106 New macro to iterate over live buffers similar to frames.
1107 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1108 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1109 Declare buffer-related variables here to offload lisp.h.
1110 * buffer.c (Vbuffer_alist): Adjust comment.
1111 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1112 (other_buffer_safely):
1113 * data.c (store_symval_forwarding):
1114 * dispnew.c (Fframe_or_buffer_changed_p):
1115 * fileio.c (Fdo_auto_save):
1116 * filelock.c (unlock_all_files):
1117 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1118
e0fdb694
PE
11192013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1122 * callproc.c (create_temp_file):
1123 * filelock.c (create_lock_file):
1124 Assume mkostemp, since it's now provided by Gnulib.
1125
63f5c6c2
EZ
11262013-08-04 Eli Zaretskii <eliz@gnu.org>
1127
1128 * w32.c (mkostemp): New function.
1129 (mktemp): Remove, no longer used. Most of the code reused in
1130 mkostemp. (Bug#15015)
484ab239 1131 (mktemp): Don't undef.
63f5c6c2 1132
f0b79313
DA
11332013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1134
1135 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1136 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1137 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1138 (free_glyph_pool, check_glyph_memory): Likewise for
1139 all users. Adjust comments where appropriate.
1140
98f638d6
PE
11412013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1142
1143 * composite.h: Minor fixups.
1144 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1145 to fix a misspelling, and change it to an inline function while
1146 we're at it (it need not be a macro). All uses changed.
1147 (composition_method, composition_valid_p):
1148 Rewrite to avoid assignments in if-conditions.
1149
75c59fb3
DA
11502013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1151
1152 Do not use global Lisp_Object in composition macros.
1153 * composite.h (composition_temp): Remove declaration.
1154 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1155 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1156 (compose_region): Remove the leftover.
75c59fb3
DA
1157 * composite.c (composition_temp): Remove.
1158 (run_composition_function, update_compositions)
1159 (composition_compute_stop_pos, composition_adjust_point)
1160 (Ffind_composition_internal):
1161 * coding.c (handle_composition_annotation):
1162 * xdisp.c (handle_composition_prop, check_point_in_composition):
1163 Related users changed.
1164
a10c8269
DA
11652013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1166
1167 Drop FRAME_PTR typedef.
1168 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1169 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1170 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1171 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1172 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1173 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1174 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1175 All related users changed.
1176
a104f656
SM
11772013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 * eval.c (default_toplevel_binding): New function.
1180 (Fdefvar): Use it.
1181 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1182 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1183 (syms_of_eval): Export them.
1184 * data.c (Fdefault_value): Micro cleanup.
1185 * term.c (init_tty): Use "false".
1186
4b5c9326
DA
11872013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1188
1189 Fix X GC leak in GTK and raw (no toolkit) X ports.
1190 * xterm.c (x_free_frame_resources): If white and black relief
1191 GCs are allocated, always free them here.
1192 * xfns.c (x_make_gc): Omit redundant initialization.
1193 * widget.c (create_frame_gcs): Remove the leftover.
1194 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1195 in x_free_frame_resources.
1196
b19aa636
JD
11972013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1198
1199 * nsterm.m (windowWillResize:toSize:): Only change title if
1200 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1201 modifying it.
1202 (viewDidEndLiveResize): New method.
1203
1204 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1205 inside NS_IMPL_COCOA.
1206
af1f7e06
DA
12072013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1208
1209 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1210 Do not check whether undo is enabled because record_insert and
1211 record_delete does that themselves.
1212
65b02bb9
DA
12132013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1214
1215 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1216 member which is not really used any more.
1217 (FRAME_XIC_BASE_FONTNAME): Remove.
1218 * xfns.c (xic_free_fontset): Adjust user.
1219 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1220 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1221 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1222 (xdialog_show): Use eassert for debugging check.
7ee0f047 1223 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1224
6318cde0
PE
12252013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 * fileio.c, fns.c (merge): Move extern decl from here ...
1228 * lisp.h (merge): ... to here.
1229
6c1a09ba
DA
12302013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 Fix last font-related change.
1233 * w32font.h (w32font_list_internal, w32font_match_internal):
1234 Fix prototype.
1235 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1236 (uniscribe_list_family): Adjust to match font API change.
1237 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1238 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1239
f8c20208
DA
12402013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1241
1242 * frame.h (FRAME_MOUSE_UPDATE):
1243 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1244 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1245
fdb396e2
DA
12462013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1247
1248 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1249 * font.h (struct font_driver): Change list, match, and list_family
1250 functions to accept struct frame * as first arg.
068f9124
SM
1251 * font.c (font_score, font_compare, font_sort_entities):
1252 Remove prototypes.
fdb396e2
DA
1253 (font_sort_entities, font_list_entities, font_select_entity):
1254 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1255 match font API change.
1256 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1257 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1258 * ftxfont.c (ftxfont_list, ftxfont_match):
1259 * xftfont.c (xftfont_list, xftfont_match):
1260 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1261 * w32font.c (w32font_list, w32font_match, w32font_list):
1262 (w32font_list_internal, w32_font_match_internal): Likewise.
1263 * xfaces.c (Fx_family_fonts): Adjust user.
1264
52b8a085
DA
12652013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1266
1267 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1268 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1269 only if HAVE_X_WINDOWS is in use.
1270 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1271 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1272 * w32term.c (x_wm_set_icon_position): Likewise.
1273 * w32fns.c (x_icon): Adjust user.
1274
c791c18e
DA
12752013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1276
1277 * xterm.c (last_mouse_press_frame): Remove the
1278 leftover which is not really used any more.
1279 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1280 (x_flush): Call XFlush once per each X display, not frame.
1281 This is better because this code always unconditionally skips
1282 non-X frames in Vframe_list and issues the only XFlush if we
1283 have more than one X frame on the same X display.
2f935d86
DA
1284 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1285 Use bool for booleans.
1286 (x_draw_glyph_string_background, cvt_string_to_pixel):
1287 (cvt_pixel_dtor): Drop unnecessary prototypes.
1288 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1289
f435830e
DA
12902013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1291
1292 Drop unnecessary functions that deals with frame pixel size.
1293 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1294 (x_pixel_height): Drop prototypes.
1295 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1296 (x_pixel_height): Drop implementations.
1297 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1298 which should be always valid for window frame.
1299 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1300 * w32menu.c (Fx_popup_dialog):
1301 * xmenu.c (Fx_popup_dialog): Likewise for both.
1302
84231434
DA
13032013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1304
1305 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1306 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1307 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1308 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1309 and mention nil frame in docstring.
84231434 1310
959067a1
DA
13112013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1312
1313 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1314 (x_figure_window_size): Likewise. Adjust to return long.
1315 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1316 (toplevel): Move Qterminal_live_p to...
1317 * terminal.c (toplevel): ...here, make it static, and...
1318 (syms_of_terminal): ...DEFSYM here.
1319 * frame.h (Qterminal_live_p): Remove declaration.
1320 (make_frame, x_figure_window_size): Adjust prototype.
1321 * nsfns.m (Fx_create_frame): Use long for window flags.
1322
f4b169ce
PE
13232013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1326 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1327 Do not assume that emacs_close (INT_MAX) is a no-op.
1328
bee6a2c7
DA
13292013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1330
1331 * xfaces.c (make_face_cache): For struct face_cache, prefer
1332 xmalloc to xzalloc and so avoid redundant call to memset.
1333 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1334
d7e6881a
DA
13352013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 * fringe.c (draw_window_fringes, update_window_fringes)
1338 (compute_fringe_widths):
1339 * w32term.c (x_draw_glyph_string):
1340 * window.c (candidate_window_p, Frecenter):
1341 * xfaces.c (realize_basic_faces, realize_default_face)
1342 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1343 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1344 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1345 * xmenu.c (Fx_menu_bar_open_internal):
1346 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1347 * xsettings.c (xft_settings_event):
1348 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1349 Use bool for booleans. Adjust style and comments where
1350 appropriate.
1351 * dispextern.h (draw_window_fringes, update_window_fringes)
1352 (compute_fringe_widths):
1353 * xterm.h (x_had_errors_p): Adjust prototype.
1354
ec3058af
DA
13552013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1356
1357 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1358 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1359
218e0637
DA
13602013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 * fns.c (toplevel): Remove comment before Fsafe_length because
1363 it checks for QUIT.
1364
e560aba9
PE
13652013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1368
2e5ce5de
EZ
13692013-07-28 Eli Zaretskii <eliz@gnu.org>
1370
1371 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1372 frame which got the message is still alive, before dereferencing
1373 its pointer. (Bug#14970)
1374
1375 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1376 be a live window, before using it as such. (Bug#14970)
1377
e95da6d3
EZ
13782013-07-27 Eli Zaretskii <eliz@gnu.org>
1379
1380 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1381 w32_detect_focus_change instead of doing part of its job by hand.
1382 This fixes the problem whereby FOCUS_OUT events were not sent to
1383 the event queue.
1384
a8f93651
EZ
13852013-07-26 Eli Zaretskii <eliz@gnu.org>
1386
fec92060
EZ
1387 * process.c (Fprocess_list): Doc fix.
1388
a8f93651
EZ
1389 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1390 being re-exposed only if it didn't ask to become visible.
1391 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1392 was previously iconified. (Bug#14841)
1393 (x_iconify_frame): Mark the frame iconified.
1394
d5a7a9d9
PE
13952013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 Fix minor problems found by static checking.
1398 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1399 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1400
56ea7291
SM
14012013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1402
1403 * eval.c (set_specpdl_old_value): New function.
1404 (unbind_to): Minor simplification.
1405 (get_backtrace_frame): New function.
1406 (Fbacktrace_frame): Use it. Add `base' argument.
1407 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1408 (syms_of_eval): Export backtrace-eval.
1409 * xterm.c (x_focus_changed): Simplify.
1410
9d611ffe
PE
14112013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1414
999c74e3
EZ
14152013-07-24 Eli Zaretskii <eliz@gnu.org>
1416
1417 * xdisp.c (redisplay_window): Instead of moving point out of
1418 scroll margin, reject the force_start method, and try scrolling
1419 instead. (Bug#14780)
1420
198fa217
KB
14212013-07-24 Ken Brown <kbrown@cornell.edu>
1422
1423 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1424 (Bug#14944).
1425
53840e55
PE
14262013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 * eval.c (Fprogn): Do not check that BODY is a proper list.
1429 This undoes the previous change. The check slows down the
1430 interpreter, and is not needed to prevent a crash. See
1431 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1432
60967f56
GM
14332013-07-23 Glenn Morris <rgm@gnu.org>
1434
1435 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1436
9ca960e2
PE
14372013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1438
a29c3e6d
PE
1439 Port to GNU/Linux systems with tinfo but not ncurses.
1440 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1441 to decide whether ncurses is being used. Without this change,
1442 GCC complains about tgetent not being declared, on a system
1443 that has tinfo installed but ncurses not installed.
1444
f274311c
PE
1445 * eval.c (Fprogn): Check that BODY is a proper list.
1446
16b0520a
PE
1447 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1448 * data.c (Fsetq_default):
1449 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1450 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1451 (Fcondition_case):
1452 Tune by taking advantage of the fact that ARGS is always a list
1453 when a function is declared to have UNEVALLED args.
1454
9ca960e2
PE
1455 * emacsgtkfixed.c: Port to GCC 4.6.
1456 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1457
afacaa1b
JB
14582013-07-23 Juanma Barranquero <lekktu@gmail.com>
1459
1460 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1461 here to silence compiler warnings.
1462
368a85a4
PE
14632013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1466 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1467 from messing up Emacs's 'struct frame' (Bug#14923).
1468
f4e891b5
PE
14692013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1470
1471 * alloc.c (make_save_ptr_ptr): Define this function.
1472 It was inadvertently omitted. It's needed only if
1473 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1474
96c8b65e
JD
14752013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1476
1477 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1478 frame have focus (Bug#14895).
1479
ee010797
PE
14802013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 Avoid vfork-related deadlock more cleanly.
1483 * callproc.c (child_setup): When the child's exec fails, output
1484 the program name, as that's more useful. Use O_NONBLOCK to avoid
1485 deadlock.
1486 * process.c (create_process_1): Remove; no longer needed.
1487 (create_process): Remove timer hack; no longer needed, now that
1488 the child avoids deadlock.
1489
f0398ec1 14902013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1491
1492 * image.c (Fimage_flush): Fix doc typo.
1493
b2a069c2
PE
14942013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1495
6496aec9
PE
1496 Fix array bounds violation when pty allocation fails.
1497 * process.c (PTY_NAME_SIZE): New constant.
1498 (pty_name): Remove static variable; it's now auto.
1499 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1500 Take pty_name as an arg rather than using a static variable.
1501 All callers changed.
1502 (create_process): Recover pty_flag from process, not from volatile local.
1503 (create_pty): Stay inside array even when pty allocation fails.
1504 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1505
b2a069c2
PE
1506 * lread.c (Fload): Avoid initialization only when lint checking.
1507 Mention that it's needed only for older GCCs.
1508
99107004
KH
15092013-07-20 Kenichi Handa <handa@gnu.org>
1510
1511 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1512 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1513
6b1b199d
AS
15142013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1515
1516 * lread.c (Fload): Avoid uninitialized warning.
1517
4195afc3
PE
15182013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1519
3f5bef16
PE
1520 Fix some minor file descriptor leaks and related glitches.
1521 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1522 (create_lock_file): Use write, not emacs_write.
1523 * image.c (slurp_file, png_load_body):
1524 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1525 (server_accept_connection):
1526 Don't leak an fd on memory allocation failure.
1527 * image.c (slurp_file): Add a cheap heuristic for growing files.
1528 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1529 as that's what the other routines do. Maybe input need not be
1530 blocked at all, but it's better to be consistent.
1531 Avoid undefined behavior when strlen is zero.
1532
4195afc3
PE
1533 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1534 (NSTATICS): Now a constant; doesn't need to be a macro.
1535
a1aeeffe
RS
15362013-07-19 Richard Stallman <rms@gnu.org>
1537
1538 * coding.c (decode_coding_utf_8): Add simple loop for fast
1539 processing of ASCII characters.
1540
63b34baa
PE
15412013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1544
621dd9ac
EZ
15452013-07-19 Eli Zaretskii <eliz@gnu.org>
1546
1547 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1548 unportable 'struct x_display_info'.
1549 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1550 is a portable type.
1551
1396ac86
PE
15522013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1553
ab9980cd
PE
1554 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1555 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1556 or fscanf fails.
1557 (system_process_attributes): Prefer plain char to unsigned char
1558 when either will do. Clean up properly if interrupted or if
068f9124
SM
1559 memory allocations fail. Don't assume sscanf succeeds.
1560 Remove no-longer-needed workaround to stop GCC from whining.
1561 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1562 bit more carefully.
1563
1396ac86
PE
1564 Fix obscure porting bug with varargs functions.
1565 The code assumed that int is treated like ptrdiff_t in a vararg
1566 function, which is not a portable assumption. There was a similar
1567 -- though these days less likely -- porting problem with various
1568 assumptions that pointers of different types all smell the same as
1569 far as vararg functions is conserved. To make this problem less
1570 likely in the future, redo the API to use varargs functions.
1571 * alloc.c (make_save_value): Remove this vararg function.
1572 All uses changed to ...
1573 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1574 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1575 New functions.
1576 (make_save_ptr): Rename from make_save_pointer, for consistency with
1577 the above. Define only on platforms that need it. All uses changed.
1578
4d19d194
PE
15792013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 * keyboard.c: Try to fix typos in previous change.
1582 (DISPLAY_LIST_INFO): New macro.
1583 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1584 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1585
945c5bb1
JB
15862013-07-18 Juanma Barranquero <lekktu@gmail.com>
1587
1588 * keyboard.c (kbd_buffer_get_event):
1589 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1590 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1591
f4b1eb36
PE
15922013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1593
5e679a2c
PE
1594 * filelock.c: Fix unlikely file descriptor leaks.
1595 (get_boot_time_1): Rework to avoid using emacs_open.
1596 This doesn't actually fix a leak, but is better anyway.
1597 (read_lock_data): Use read, not emacs_read.
1598
a8cd4836
PE
1599 * doc.c: Fix minor memory and file descriptor leaks.
1600 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1601 (get_doc_string, Fsnarf_documentation):
1602 Fix file descriptor leak on error.
1603
ef30e638
PE
1604 * term.c: Fix minor fdopen-related file descriptor leaks.
1605 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1606 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1607
f4b1eb36
PE
1608 * charset.c: Fix file descriptor leaks and errno issues.
1609 Include <errno.h>.
1610 (load_charset_map_from_file): Don't leak file descriptor on error.
1611 Use plain record_xmalloc since the allocation is larger than
1612 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1613 of entries.
1614 * eval.c (record_unwind_protect_nothing):
1615 * fileio.c (fclose_unwind):
1616 New functions.
1617 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1618 The replacement doesn't block input, but that no longer seems
1619 necessary.
1620
b648c163
PE
16212013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1622
a0931322
PE
1623 * lread.c: Fix file descriptor leaks and errno issues.
1624 (Fload): Close some races that leaked fds or streams when 'load'
1625 was interrupted.
1626 (Fload, openp): Report error number of last nontrivial failure to open.
1627 ENOENT counts as trivial.
1628 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1629 New functions.
1630 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1631 now that the function is always called with a nonnegative arg.
1632 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1633 All uses replaced with ...
1634 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1635
b648c163
PE
1636 A few more minor file errno-reporting bugs.
1637 * callproc.c (Fcall_process):
1638 * doc.c (Fsnarf_documentation):
1639 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1640 * process.c (set_socket_option):
1641 Don't let a constructor trash errno.
1642 * doc.c: Include <errno.h>.
1643
b1dc4084
JB
16442013-07-16 Juanma Barranquero <lekktu@gmail.com>
1645
1646 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1647
c43843aa
PE
16482013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1649
50a30cce
PE
1650 Fix w32 bug with call-process-region (Bug#14885).
1651 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1652 to Fcall_process when the input is empty. This simplifies the
1653 code a bit. It makes no difference on POSIXish platforms but
1654 apparently it fixes a bug on w32.
1655
44e18199 1656 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1657 * fileio.c (close_file_unwind): Don't close if FD is negative;
1658 this can happen when unwinding a zapped file descriptor.
1659 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1660 in case Emacs runs out of memory between the two unwind-protects.
1661 Don't trash errno when closing FD.
1662 Zap the FD in the specpdl when closing it, instead of deferring
1663 the removal of the unwind-protect; this fixes a bug where a child
1664 function unwinds the stack past us.
1665
27e498e6
PE
1666 New unwind-protect flavors to better type-check C callbacks.
1667 This also lessens the need to write wrappers for callbacks,
1668 and the need for make_save_pointer.
1669 * alloca.c (free_save_value):
1670 * atimer.c (run_all_atimers):
1671 Now extern.
1672 * alloc.c (safe_alloca_unwind):
1673 * atimer.c (unwind_stop_other_atimers):
1674 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1675 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1676 * minibuf.c (choose_minibuf_frame_1):
1677 * process.c (make_serial_process_unwind):
1678 * xdisp.h (pop_message_unwind):
1679 * xselect.c (queue_selection_requests_unwind):
1680 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1681 * alloca.c (record_xmalloc):
1682 Prefer record_unwind_protect_ptr to record_unwind_protect with
1683 make_save_pointer.
1684 * alloca.c (Fgarbage_collect):
1685 Prefer record_unwind_protect_void to passing a dummy.
1686 * buffer.c (restore_buffer):
1687 * window.c (restore_window_configuration):
1688 * xfns.c, w32fns.c (do_unwind_create_frame)
1689 New wrapper. All record-unwind uses of wrappee changed.
1690 * buffer.c (set_buffer_if_live):
1691 * callproc.c (call_process_cleanup, delete_temp_file):
1692 * coding.c (code_conversion_restore):
1693 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1694 * editfns.c (save_excursion_restore)
1695 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1696 (save_restriction_restore):
1697 * eval.c (restore_stack_limits, un_autoload):
1698 * fns.c (require_unwind):
1699 * keyboard.c (recursive_edit_unwind, tracking_off):
1700 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1701 * macros.c (pop_kbd_macro, restore_menu_items):
1702 * nsfns.m (unwind_create_frame):
1703 * print.c (print_unwind):
1704 * process.c (start_process_unwind):
1705 * search.c (unwind_set_match_data):
1706 * window.c (select_window_norecord, select_frame_norecord):
1707 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1708 (fast_set_selected_frame):
1709 * xfns.c, w32fns.c (unwind_create_tip_frame):
1710 Return void, not a dummy Lisp_Object. All uses changed.
1711 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1712 * callproc.c (call_process_kill):
1713 * fileio.c (restore_point_unwind, decide_coding_unwind)
1714 (build_annotations_unwind):
1715 * insdel.c (Fcombine_after_change_execute_1):
1716 * keyboard.c (read_char_help_form_unwind):
1717 * menu.c (unuse_menu_items):
1718 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1719 * sound.c (sound_cleanup):
1720 * xdisp.c (unwind_redisplay):
1721 * xfns.c (clean_up_dialog):
1722 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1723 Accept no args and return void, instead of accepting and returning
1724 a dummy Lisp_Object. All uses changed.
1725 * cygw32.c (fchdir_unwind):
1726 * fileio.c (close_file_unwind):
1727 * keyboard.c (restore_kboard_configuration):
1728 * lread.c (readevalllop_1):
1729 * process.c (wait_reading_process_output_unwind):
1730 Accept int and return void, rather than accepting an Emacs integer
1731 and returning a dummy object. In some cases this fixes an
1732 unlikely bug when the corresponding int is outside Emacs integer
1733 range. All uses changed.
1734 * dired.c (directory_files_internal_unwind):
1735 * fileio.c (do_auto_save_unwind):
1736 * gtkutil.c (pop_down_dialog):
1737 * insdel.c (reset_var_on_error):
1738 * lread.c (load_unwind):
1739 * xfns.c (clean_up_file_dialog):
1740 * xmenu.c, nsmenu.m (pop_down_menu):
1741 * xmenu.c (cleanup_widget_value_tree):
1742 * xselect.c (wait_for_property_change_unwind):
1743 Accept pointer and return void, rather than accepting an Emacs
1744 save value encapsulating the pointer and returning a dummy object.
1745 All uses changed.
1746 * editfns.c (Fformat): Update the saved pointer directly via
1747 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1748 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1749 (unwind_body): New function.
1750 (record_unwind_protect): First arg is now a function returning void,
1751 not a dummy Lisp_Object.
1752 (record_unwind_protect_ptr, record_unwind_protect_int)
1753 (record_unwind_protect_void): New functions.
1754 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1755 * fileio.c (struct auto_save_unwind): New type.
1756 (do_auto_save_unwind): Use it.
1757 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1758 * insdel.c (struct rvoe_arg): New type.
1759 (reset_var_on_error): Use it.
1760 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1761 New constants.
1762 (specbinding_func): Remove; there are now several such functions.
1763 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1764 (set_unwind_protect_ptr): New function.
1765 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1766
4e604a5d
PE
1767 Be simpler and more consistent about reporting I/O errors.
1768 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1769 Say "Read error" and "Write error", rather than "I/O error", or
1770 "IO error reading", or "IO error writing", when a read or write
1771 error occurs.
1772 * process.c (Fmake_network_process, wait_reading_process_output)
1773 (send_process, Fprocess_send_eof, wait_reading_process_output):
1774 Capitalize diagnostics consistently. Put "failed foo" at the
1775 start of the diagnostic, so that we don't capitalize the
1776 function name "foo". Consistently say "failed" for such
1777 diagnostics.
1778 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1779 All callers changed. This is so it can use report_file_error.
1780 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1781 diagnostics consistently as above.
1782
a9757f6a
PE
1783 * fileio.c (report_file_errno): Fix errno reporting bug.
1784 If the file name is neither null nor a pair, package it up as a
1785 singleton list. All callers changed, both to this function and to
1786 report_file_error. This fixes a bug where the memory allocator
1787 invoked by list1 set errno so that the immediately following
1788 report_file_error reported the wrong errno value.
1789
c43843aa
PE
1790 Fix minor problems found by --enable-gcc-warnings.
1791 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1792 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1793
18c26d81
JD
17942013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1795
1796 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1797 Set event->arg to Qt if switch-event shall be generated.
1798 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1799
1800 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1801
1802 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1803 FOCUS_OUT_EVENT.
1804
1805 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1806 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1807 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1808 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1809 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1810 and there is a focused frame.
1811 (head_table): Add focus-in and focus-out.
1812 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1813 bind to handle-focus-in/out.
1814
1815 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1816 (Fhandle_switch_frame): Call Fhandle_focus_in.
1817 (syms_of_frame): defsubr handle-focus-in/out.
1818
6c6f1994
PE
18192013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1820
c7ddc792
PE
1821 Fix porting bug to older POSIXish platforms (Bug#14862).
1822 * sysdep.c (emacs_pipe): New function, that implements
1823 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1824 This should port better to CentOS 5 and to Mac OS X 10.6.
1825 All calls to pipe2 changed.
1826
6c6f1994
PE
1827 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1828 This makes the code easier to read and the executable a bit smaller.
1829 Do not replace all calls to Fcons that happen to create lists,
1830 just calls that are intended to create lists. For example, when
1831 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1832 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1833 Similarly for list2 through list5.
1834 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1835 * bytecode.c (exec_byte_code):
1836 * callint.c (quotify_arg, Fcall_interactively):
1837 * callproc.c (Fcall_process, create_temp_file):
1838 * charset.c (load_charset_map_from_file)
1839 (Fdefine_charset_internal, init_charset):
1840 * coding.c (get_translation_table, detect_coding_system)
1841 (Fcheck_coding_systems_region)
1842 (Fset_terminal_coding_system_internal)
1843 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1844 * composite.c (update_compositions, Ffind_composition_internal):
1845 * dired.c (directory_files_internal, file_name_completion)
1846 (Fsystem_users):
1847 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1848 * doc.c (Fsnarf_documentation):
1849 * editfns.c (Fmessage_box):
1850 * emacs.c (main):
1851 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1852 (Feval, eval_sub, Ffuncall, apply_lambda):
1853 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1854 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1855 (Fset_file_times, Finsert_file_contents)
1856 (Fchoose_write_coding_system, Fwrite_region):
1857 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1858 * font.c (font_registry_charsets, font_parse_fcname)
1859 (font_prepare_cache, font_update_drivers, Flist_fonts):
1860 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1861 * frame.c (make_frame, Fmake_terminal_frame)
1862 (x_set_frame_parameters, x_report_frame_params)
1863 (x_default_parameter, Fx_parse_geometry):
1864 * ftfont.c (syms_of_ftfont):
1865 * image.c (gif_load):
1866 * keyboard.c (command_loop_1):
1867 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1868 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1869 (Fminor_mode_key_binding, accessible_keymaps_1)
1870 (Faccessible_keymaps, Fwhere_is_internal):
1871 * lread.c (read_emacs_mule_char):
1872 * menu.c (find_and_return_menu_selection):
1873 * minibuf.c (get_minibuffer):
1874 * nsfns.m (Fns_perform_service):
1875 * nsfont.m (ns_script_to_charset):
1876 * nsmenu.m (ns_popup_dialog):
1877 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1878 (Fx_own_selection_internal):
1879 * nsterm.m (append2):
1880 * print.c (Fredirect_debugging_output)
1881 (print_prune_string_charset):
1882 * process.c (Fdelete_process, Fprocess_contact)
1883 (Fformat_network_address, set_socket_option)
1884 (read_and_dispose_of_process_output, write_queue_push)
1885 (send_process, exec_sentinel):
1886 * sound.c (Fplay_sound_internal):
1887 * textprop.c (validate_plist, add_properties)
1888 (Fput_text_property, Fadd_face_text_property)
1889 (copy_text_properties, text_property_list, syms_of_textprop):
1890 * unexaix.c (report_error):
1891 * unexcoff.c (report_error):
1892 * unexsol.c (unexec):
1893 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1894 (Fformat_mode_line, syms_of_xdisp):
1895 * xfaces.c (set_font_frame_param)
1896 (Finternal_lisp_face_attribute_values)
1897 (Finternal_merge_in_global_face, syms_of_xfaces):
1898 * xfns.c (x_default_scroll_bar_color_parameter)
1899 (x_default_font_parameter, x_create_tip_frame):
1900 * xfont.c (xfont_supported_scripts):
1901 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1902 (menu_help_callback, xmenu_show):
1903 * xml.c (make_dom):
1904 * xterm.c (set_wm_state):
1905 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1906 and similarly for list2 through list5.
1907
bafe80ce
PE
19082013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 * callproc.c (Fcall_process_region): Fix minor race and tune.
1911 (create_temp_file): New function, with the temp-file-creation part
1912 of the old Fcall_process_region. Use Fcopy_sequence to create the
1913 temp file name, rather than alloca + build_string, for simplicity.
1914 Don't bother to block input around the temp file creation;
068f9124
SM
1915 shouldn't be needed. Simplify use of mktemp.
1916 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
1917 this closes an unlikely race where the temp file was not removed.
1918 Use memcpy rather than an open-coded loop.
1919 (Fcall_process_region): Use the new function. If the input is
1920 empty, redirect from /dev/null rather than from a newly created
1921 empty temp file; this avoids unnecessary file system traffic.
1922
4700b5a5
PE
19232013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1924
5c97beae
PE
1925 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1926 Simplify by making this case like the other two. This is a bit
1927 slower on obsolete hosts, but the extra complexity isn't worth it.
1928
4700b5a5
PE
1929 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1930 * process.c (create_process) [!DOS_NT]:
1931 Remove now-unnecessary calls to emacs_close.
1932
f9a74c4c
EZ
19332013-07-13 Eli Zaretskii <eliz@gnu.org>
1934
922ae7ee
EZ
1935 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1936 returning early. (Bug#14850)
1937
f9a74c4c
EZ
1938 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1939 and inhibit-iso-escape-detection attributes of 'undecided'.
1940 (Bug#14822)
1941
5e301d76
PE
19422013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1943
69e0e5ee
PE
1944 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1945 Reported by Herbert J. Skuhra in
1946 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1947
5e301d76
PE
1948 Don't lose top specpdl entry when memory is exhausted.
1949 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1950 specpdl overflow here, to simplify callers; all callers changed.
1951 Always reserve an unused entry at the stack top; this avoids
1952 losing the top entry's information when memory is exhausted.
1953
7e649856
PE
19542013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1955
a773ed9a
PE
1956 Clean up errno reporting and fix some errno-reporting bugs.
1957 * callproc.c (Fcall_process):
1958 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1959 * process.c (create_process, Fmake_network_process):
1960 * unexaix.c (report_error):
1961 * unexcoff.c (report_error):
1962 Be more careful about reporting the errno of failed operations.
1963 The code previously reported the wrong errno sometimes.
1964 Also, prefer report_file_errno to setting errno + report_file_error.
1965 (Fcall_process): Look at openp return value rather than at path,
1966 as that's a bit faster and clearer when there's a numeric predicate.
1967 * fileio.c (report_file_errno): New function, with most of the
1968 old contents of report_file_error.
1969 (report_file_error): Use it.
1970 (Ffile_exists_p, Ffile_accessible_directory_p):
1971 Set errno to 0 when it is junk.
1972 * fileio.c (Faccess_file):
1973 * image.c (x_create_bitmap_from_file):
1974 Use faccessat rather than opening the file, to avoid the hassle of
1975 having a file descriptor open.
1976 * lisp.h (report_file_errno): New decl.
1977 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1978
7e649856
PE
1979 Minor EBADF fixes.
1980 * process.c (create_process, wait_reading_process_output) [AIX]:
1981 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1982 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1983 a multithreaded environment anyway).
1984 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1985
f6774c1a
AS
19862013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1987
1988 * image.c (x_find_image_file): Don't close a remote file handle.
1989
bacba3c2
PE
19902013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 Fix races with threads and file descriptors.
1993 * callproc.c (Fcall_process_region):
1994 * dired.c (open_directory):
1995 * emacs.c (main, Fdaemon_initialized):
1996 * image.c (x_find_image_file):
1997 * inotify.c (Finotify_rm_watch):
1998 * lread.c (Flocate_file_internal):
1999 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2000 * term.c (term_mouse_moveto, init_tty):
2001 * termcap.c (tgetent):
2002 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2003 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2004 * unexhp9k800.c, unexmacosx.c (unexec):
2005 * callproc.c (Fcall_process_region):
2006 Use emacs_close, not close.
2007 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2008 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2009 and posix_close function on current platforms (which all lack them).
2010 (emacs_close): Use it. This should fix the races on GNU/Linux and
2011 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2012 and it should avoid closing random victim file descriptors on
2013 other platforms.
2014
653d4f43
PE
20152013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2016
c8536ec4
PE
2017 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2018 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2019 Touch up doc a bit.
2020
9c203066
PE
2021 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2022 This is for .gdbinit xbacktrace.
2023
653d4f43
PE
2024 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2025 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2026 (emacs_set_tty): Now static.
2027 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2028 * term.c (tty_capable_p, tty_default_color_capabilities)
2029 (get_tty_terminal, term_mouse_movement)
2030 (handle_one_term_event, init_tty, maybe_fatal):
2031 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2032 (tgetent, scan_file, name_match, compare_contin):
2033 * terminal.c (get_terminal):
2034 Use bool for boolean.
2035 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2036 Prefer char to unsigned char if either will do.
2037 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2038 (tty_write_glyphs): Prefer int to unsigned.
2039 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2040 All callers changed.
2041 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2042
45b683a1
PE
20432013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2044
29abe551
PE
2045 Port to C89.
2046 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2047 (B__dummy__): New dummy symbol, to pacify C89.
2048 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2049 they can't grok varargs macros.
2050 * dispnew.c (add_window_display_history)
2051 (add_frame_display_history):
2052 * print.c (print_object):
2053 * xdisp.c (debug_method_add):
2054 Use %p printf format only for void pointers.
2055 * emacs.c (usage_message): New constant, replacing ...
2056 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2057 (main): Adjust to usage reorg.
2058 * fns.c (syms_of_fns):
2059 * profiler.c (syms_of_profiler):
2060 Don't use non-constant struct initializers.
2061 * gnutls.h (gnutls_initstage_t):
2062 * lisp.h (enum Lisp_Fwd_Type):
2063 * lread.c (lisp_file_lexically_bound_p):
2064 * xsettings.c (anonymous enum):
2065 Remove trailing comma.
2066 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2067 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2068 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2069 (DEFUN): Use it.
2070 * regex.c (const_re_char): New type, to pacify strict C89.
2071 All uses of 'const re_char' replaced to use it.
2072 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2073 with glibc when strict C89. This change is imported from gnulib.
2074 All uses changed.
2075 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2076 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2077 Omit GNU_LINUX implementation, since it requires long long.
2078 * xterm.c (x_draw_underwave):
2079 Do not assume the traditional order of struct's members.
2080 (x_term_init): Rewrite to avoid the need for non-constant structure
2081 initializers.
2082
45b683a1 2083 Syntax cleanup, mostly replacing macros with functions.
763a086d 2084 This removes the need for the syntax_temp hack.
45b683a1
PE
2085 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2086 * syntax.c (SYNTAX_INLINE): New macro.
2087 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2088 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2089 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2090 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2091 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2092 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2093 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2094 Now constants, not macros.
2095 (syntax_temp) [!__GNUC__]: Remove.
2096 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2097 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2098 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2099 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2100 Move here from syntax.h; now functions, not macros. Except for the
2101 last function, these are static since only syntax.c uses them.
2102 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2103 All uses changed. Now a function, not a macro; use this fact
2104 to simplify the code.
2105 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2106 compiler bugs; no longer relevant.
2107 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2108 (SYNTAX_INLINE): New macro.
2109 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2110 for the new functions. Use bool for boolean member.
2111 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2112 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2113 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2114 (SETUP_BUFFER_SYNTAX_TABLE):
2115 Now extern inline functions, not macros.
2116 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2117 Remove; all uses replaced by implementation.
2118 (syntax_temp) [!__GNUC__]: Remove decl.
2119 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2120
29be4a50
JD
21212013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2122
2123 * emacs.c (main): Fix syntax error.
2124
954b166e
PE
21252013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2126
2127 Timestamp fixes for undo (Bug#14824).
2128 * atimer.c (schedule_atimer):
2129 * fileio.c (Ffile_newer_than_file_p):
2130 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2131 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2132 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2133 (syms_of_fileio): Remove Sclear_visited_file_name.
2134 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2135 file doesn't exist; this avoids an ambiguity with negative timestamps.
2136 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2137 * systime.h (make_emacs_time, invalid_emacs_time):
2138 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2139 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2140 * undo.c (record_first_change): Push (visited-file-modtime) onto
2141 undo list rather than reimplementing it by hand, incorrectly.
2142
d74647c3
KB
21432013-07-09 Ken Brown <kbrown@cornell.edu>
2144
2145 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2146
3c51b96b
JB
21472013-07-09 Juanma Barranquero <lekktu@gmail.com>
2148
2149 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2150
4ebbdd67
PE
21512013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2152
2153 Handle errno and exit status a bit more carefully.
2154 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2155 number into an exit status. Instead, use EXIT_CANCELED.
2156 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2157 * callproc.c (relocate_fd):
2158 * emacs.c (close_output_streams, main):
2159 * process.c (create_process):
2160 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2161 Use emacs_perror for simplicity.
2162 * callproc.c (relocate_fd, main):
2163 * sysdep.c (sys_subshell):
2164 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2165 (shut_down_emacs): Use emacs_write, not write.
2166 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2167 * fileio.c (Fcopy_file, e_write):
2168 * nsterm.m (ns_select):
2169 * process.c (send_process):
2170 * sound.c (vox_write):
2171 Use emacs_write_sig, not emacs_write.
2172 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2173 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2174 New constants.
2175 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2176 of write.
2177 (emacs_full_write): New function.
2178 (emacs_write): Rewrite to use it.
2179 (emacswrite_sig, emacs_perror): New functions.
2180 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2181
44e18199 21822013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2183
2184 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2185 on NS even if it is present. Pixmap on NS is a void*.
2186
9caab067
PE
21872013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 Port to Ubuntu 10 (Bug#14803).
2190 Problem reported by T.V. Raman.
2191 * process.c (close_on_exec, accept4, process_socket):
2192 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2193
1d442672
EZ
21942013-07-07 Eli Zaretskii <eliz@gnu.org>
2195
2196 * w32.c (sys_dup): Declare prototype.
2197
2198 * filelock.c:
2199 * emacs.c:
2200 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2201
067428c1
PE
22022013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 Make file descriptors close-on-exec when possible (Bug#14803).
2205 This simplifies Emacs a bit, since it no longer needs to worry
2206 about closing file descriptors by hand in some cases.
2207 It also fixes some unlikely races. Not all such races, as
2208 libraries often open files internally without setting
2209 close-on-exec, but it's an improvement.
2210 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2211 * callproc.c (Fcall_process) [!MSDOS]:
2212 * emacs.c (main) [!DOS_NT]:
2213 * nsterm.m (ns_term_init):
2214 * process.c (create_process):
2215 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2216 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2217 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2218 Prefer mkostemp with O_CLOEXEC to mkstemp.
2219 * callproc.c (relocate_fd) [!WINDOWSNT]:
2220 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2221 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2222 now using pipe2.
2223 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2224 Make the resulting file descriptor close-on-exec.
2225 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2226 * lread.c (load_descriptor_list, load_descriptor_unwind):
2227 Remove; no longer needed. All uses removed.
2228 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2229 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2230 New functions.
2231 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2232 (Fmake_network_process, Fnetwork_interface_list):
2233 (Fnetwork_interface_info, server_accept_connection):
2234 Make newly-created socket close-on-exec.
2235 * sysdep.c (emacs_open, emacs_fopen):
2236 Make new-created descriptor close-on-exec.
2237 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2238 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2239
0da857dd
JD
22402013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2241
2242 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2243 for NS_IMPL_GNUSTEP.
2244
5f86adcd
PE
22452013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 Fix openp errno handling.
2248 * callproc.c (Fcall_process): Preserve openp errno around close.
2249 * lread.c (openp): Set errno when returning -1, as some callers
2250 expect this.
2251
1afb1d07
JD
22522013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2253
2254 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2255
2256 * nsterm.h (NSSavePanel): Update comment.
2257 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2258 (ns_run_file_dialog): Declare.
2259
2260 * nsfns.m: Remove panelOK.
2261 (ns_fd_data): New.
2262 (ns_run_file_dialog): New function.
2263 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2264 event loop, so file dialog is popped up by ns_run_file_dialog, called
2265 by sendEvent (Bug#14578).
2266 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2267
3323c263
EZ
22682013-07-06 Eli Zaretskii <eliz@gnu.org>
2269
fdda0220
EZ
2270 * xdisp.c (default_line_pixel_height): New function.
2271 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2272 (try_cursor_movement, redisplay_window, try_window)
2273 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2274
068f9124
SM
2275 * window.c (window_scroll_pixel_based):
2276 use default_line_pixel_height.
fdda0220
EZ
2277
2278 * dispextern.h (default_line_pixel_height): Add prototype.
2279
2280 * frame.c (x_set_line_spacing): Accept a float value for
2281 line-spacing parameter, per the documentation.
2282
3323c263
EZ
2283 * data.c (Fmultibyte_string_p): Doc fix.
2284
47ba6d43
PE
22852013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2286
406af475
PE
2287 Use emacs_open more consistently when opening files.
2288 This handles EINTR more consistently now, and makes it easier
2289 to introduce other uniform changes to file descriptor handling.
2290 * src/systdio.h: New file.
2291 * src/buffer.c (mmap_init):
2292 * cygw32.c (chdir_to_default_directory):
2293 * dispnew.c (Fopen_termscript):
2294 * emacs.c (Fdaemon_initialized):
2295 * fileio.c (Fdo_auto_save):
2296 * image.c (slurp_file, png_load_body, jpeg_load_body):
2297 * keyboard.c (Fopen_dribble_file):
2298 * lread.c (Fload):
2299 * print.c (Fredirect_debugging_output):
2300 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2301 * termcap.c (tgetent):
2302 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2303 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2304 * w32term.c (w32_initialize) [CYGWIN]:
2305 * xfaces.c (Fx_load_color_file):
2306 Use emacs_open instead of plain open, and emacs_fopen instead of
2307 plain fopen.
2308 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2309 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2310 * callproc.c (default_output_mode): New constant.
2311 (Fcall_process): Use it to call emacs_open instead of plain creat.
2312 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2313 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2314 (emacs_fopen): New function.
2315 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2316 Include <lisp.h>, for emacs_open.
2317 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2318
47ba6d43
PE
2319 Remove duplicate #include directives.
2320 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2321 * xfaces.c:
2322 Don't include stdio.h twice.
2323 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2324 Don't include sys/types.h or stdio.h twice.
2325 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2326 * lread.c: Don't include coding.h twice.
2327 * nsfont.m: Don't include frame.h twice.
2328 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2329 * ralloc.c: Don't include <unistd.h> twice.
2330 * xdisp.c: Don't include font.h twice.
2331 * xterm.c: Don't include fontset.h twice.
2332 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2333
b9ed53d5
PE
23342013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2335
2336 Scale ImageMagick images more carefully.
2337 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2338 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2339 Be more careful about avoiding undefined behavior after
2340 integer overflow and division by zero.
2341
cf13177e
YM
23422013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2343
2344 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2345 (syms_of_w32fns): DEFSYM them.
2346 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2347 (CCHDEVICENAME): Define macros if not defined.
2348 (struct MONITOR_INFO_EX): New struct.
2349 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2350 (enum_display_monitors_fn): New variable.
2351 (globals_of_w32fns): Initialize it.
2352 (Fx_display_pixel_width, Fx_display_pixel_height)
2353 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2354 multi-monitor setups in docstrings.
2355 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2356 screen size by primary monitor's millimeter per pixel.
2357 (w32_monitor_enum, w32_display_monitor_attributes_list)
2358 (w32_display_monitor_attributes_list_fallback)
2359 (Fw32_display_monitor_attributes_list): New functions.
2360 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2361
2362 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2363 if not defined.
2364 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2365
86dfb7a8
MA
23662013-07-04 Michael Albinus <michael.albinus@gmx.de>
2367
2368 * fileio.c (Qfile_notify_error): New error symbol.
2369
2370 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2371 * inotify.c (inotify_callback, symbol_to_inotifymask)
2372 (Finotify_add_watch, Finotify_rm_watch): Use it.
2373 (inotifyevent_to_event): Exchange order of cookie and file name.
2374 (Finotify_add_watch): Adapt docstring.
2375
2376 * lisp.h (Qfile_notify_error): Declare.
2377
2c1c974b
PE
23782013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2381 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2382 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2383 which did not work (see <http://bugs.gnu.org/14569#307>).
2384 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2385 && (!noninteractive || initialized)). This attempts to thread
2386 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2387
7a35b20f
JB
23882013-07-04 Juanma Barranquero <lekktu@gmail.com>
2389
2390 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2391 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2392
1ce5cd04
PE
23932013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2396 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2397 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2398 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2399
57f8c490
PE
24002013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2403 Define to __sys_siglist.
2404
bcffb5ca
EZ
24052013-07-02 Eli Zaretskii <eliz@gnu.org>
2406
2407 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2408 word-wrap, so that overflow-newline-into-fringe would work in
2409 visual-line-mode. (Bug#2749)
2410 (move_it_in_display_line_to): When the last scanned display
2411 element fits exactly on the display line, and
2412 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2413 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2414 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2415 finding buffer position that corresponds to pixel coordinates,
2416 e.g. in buffer_posn_from_coords.
2417
2c41e781
JD
24182013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2419
2420 * process.c (handle_child_signal): Call catch_child_signal if
2421 NS_IMPL_GNUSTEP.
2422
c2418359
PE
24232013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2424
52a9bcae
PE
2425 Don't convert function pointers to void * and back.
2426 It isn't portable C, and it's easy enough to avoid.
2427 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2428 (make_save_value): Add support for SAVE_FUNCPOINTER.
2429 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2430 * print.c (print_object):
2431 Distinguish function from object pointers.
2432 * lisp.h (SAVE_FUNCPOINTER): New constant.
2433 (SAVE_SLOT_BITS): Adjust to it.
2434 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2435 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2436 (voidfuncptr): New typedef.
2437 (struct Lisp_Save_Value): New member data[0].funcpointer.
2438 (XSAVE_FUNCPOINTER): New function.
2439
c2418359
PE
2440 Simplify buildobj processing.
2441 * Makefile.in (buildobj.h): Make it a sequence of strings each
2442 followed by comma, rather than a single string. Put it into a
2443 .tmp file in case there's an error while generating it.
2444 (gl-stamp): Use .tmp for temp files.
2445 (mostlyclean): Clean .tmp files.
2446 * doc.c (buildobj): Move to just the routine that needs it.
2447 It's now an array of strings, so processing is simpler.
2448
8f43ce49
PE
24492013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2450
2451 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2452 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2453 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2454 Invoke malloc_enable_thread even when not interactive.
2455 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2456 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2457 in this case, since the underlying bug has now been fixed.
2458
24827db9
JB
24592013-07-01 Juanma Barranquero <lekktu@gmail.com>
2460
2461 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2462 unlinking it (bug#14691).
2463
ef099a94
MN
24642013-06-30 Michal Nazarewicz <mina86@mina86.com>
2465
2466 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2467 before checking whether buffer is modified. This lets
2468 `kill-buffer-query-functions' cancel killing of the buffer or save
2469 its content before `kill-buffer' asks user the "Buffer %s
2470 modified; kill anyway?" question.
2471
9d3f2fc2
JD
24722013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2473
2474 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2475 Let the super performKeyEquivalent deal with them (Bug#14747).
2476
e6c6c8c7
PE
24772013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2478
1d71c1d9
PE
2479 * widget.c (resize_cb): Remove unused local.
2480
8f5f35cc
PE
2481 Do not use GTK 3 if it exists but cannot be compiled.
2482 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2483 * xterm.c (x_error_handler) [!USE_GTK]:
2484 Do not use GTK 3.
2485
e6c6c8c7
PE
2486 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2487
0ba54312
EZ
24882013-06-30 Eli Zaretskii <eliz@gnu.org>
2489
5d1c3286
EZ
2490 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2491 to the valid range of values. (Bug#14753)
2492
0ba54312
EZ
2493 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2494 when moving point by using the current glyph matrix. This avoids
2495 the need to force redisplay when this function is called in a
2496 loop.
2497
9c90cc06
PE
24982013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 Fix minor problems found by static checking.
2501 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2502 Redo the latter's body to sidestep GCC parenthesization warnings.
2503 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2504 * coding.c (detect_coding, detect_coding_system):
2505 * coding.h (struct undecided_spec):
2506 Use bool for boolean.
2507 * image.c (QCmax_width, QCmax_height): Now static.
2508 * xdisp.c (Fmove_point_visually): Remove unused local.
2509
4c672a0f
EZ
25102013-06-29 Eli Zaretskii <eliz@gnu.org>
2511
2512 * xdisp.c (Fmove_point_visually): New function.
2513
c1ea3abf
JB
25142013-06-28 Kenichi Handa <handa@gnu.org>
2515
2516 * coding.h (define_coding_undecided_arg_index): New enum.
2517 (coding_attr_index): New members
2518 coding_attr_undecided_inhibit_null_byte_detection,
2519 coding_attr_undecided_inhibit_iso_escape_detection,
2520 coding_attr_undecided_prefer_utf_8.
2521 (undecided_spec): New struct.
2522 (struct coding_system): New member `undecided' of the member
2523 `spec'.
2524
2525 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2526 (detect_coding): Likewise.
2527 (detect_coding_system): Likewise.
2528 (Fdefine_coding_system_internal): New coding system properties
2529 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2530 :prefer-utf-8.
2531 (syms_of_coding): Adjust for coding_arg_undecided_max.
2532
ba3de9e6
PE
25332013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2534
2535 * image.c (x_from_xcolors): Remove unused local.
2536
547c9269
YM
25372013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2538
2539 Defer image data transfer between X client and server until actual
2540 display happens.
2541
2542 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2543 and `mask_img'.
2544
2545 * image.c (Destroy_Image): Remove.
2546 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2547 `mask_p', and `colors_p'. All uses changed.
2548 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2549 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2550 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2551 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2552 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2553 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2554 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2555 (image_get_x_image, image_unget_x_image): New functions or macros.
2556 (image_background, image_background_transparent, x_to_xcolors)
2557 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2558 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2559 instead of Destroy_Image.
2560 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2561 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2562 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2563 (imagemagick_load_image, svg_load_image): Use them instead of
2564 x_create_x_image_and_pixmap, and x_put_x_image followed by
2565 x_destroy_x_image, respectively.
2566 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2567 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2568 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2569 background_transparent fields.
2570 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2571 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2572
dae2f5ef
PE
25732013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2574
2575 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2576 This mostly consists of undoing recent changes.
2577 * callproc.c (Fcall_process):
2578 * process.c (create_process):
2579 Do not worry about catching SIGCHLD here, undoing previous change.
2580 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2581 * process.c, process.h (catch_child_signal):
2582 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2583 * process.c (catch_child_handler): Don't worry about being called
2584 lazily and do not assume caller has blocked SIGCHLD, undoing
2585 previous change. Move first-time stuff back to
2586 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2587 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2588 set lib_child_handler if it's already initialized, which may
2589 help avoid problems on GNUStep.
2590
fa55d2aa
PE
25912013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2594 * callproc.c (Fcall_process):
2595 * process.c (create_process):
2596 Make sure SIGCHLD is caught before we fork,
2597 since Emacs startup no arranges to catch SIGCHLD.
2598 * process.c (lib_child_handler): Initialize to null, not to
2599 dummy_handler.
2600 (catch_child_signal): Allow self to be called lazily.
2601 Do nothing if it's already been called.
2602 Assume caller has blocked SIGCHLD (all callers do now).
2603 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2604 just before it's really needed.
2605 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2606 since it hasn't been caught yet.
2607
f3f9606c
LMI
26082013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2609
2610 * image.c (compute_image_size): New function to implement
2611 :max-width and :max-height.
2612 (imagemagick_load_image): Use it.
2613
c7041908
PE
26142013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2617 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2618 Now extern.
2619 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2620 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2621 the SIGCHLD handler, since the code is not atomic and (due to glib)
2622 signals may be arriving now.
2623 * sysdep.c (init_signals): Do not catch child signals here;
2624 'main' now does that later, at a safer time.
2625
f86852b4
PE
26262013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2627
0dfeed58
PE
2628 Clean up SIGCHLD handling a bit (Bug#14569).
2629 * process.c, process.h (catch_child_signal):
2630 Now always extern, even if !NS_IMPL_GNUSTEP.
2631 * process.c (catch_child_signal): Move glib tickler here from
2632 init_process_emacs, so that it's done earlier in Emacs
2633 initialization. Also move the noninteractive && !initialized
2634 check here from init_process_emacs. This is all a bit cleaner for
2635 GNUish platforms, and I hope it works around the Cygwin bug.
2636 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2637 that glib signal handling is tickled before glib creates threads.
2638
f86852b4
PE
2639 * process.c (wait_reading_process_output): Avoid int overflow
2640 when reading more than 2 GiB total from a process.
2641
cbd6509c
PE
26422013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 * process.c (create_process): Handle a couple more cases,
2645 i.e., work even if new_argv and wait_child_setup[i] are cached.
2646 Use Fcall_process's style for volatile vars.
2647
9de1114a
AS
26482013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2649
2650 * process.c (create_process): Mark PROCESS volatile.
2651
fbe9e0b9
PE
26522013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2653
2654 Use C99-style flexible array members if available.
2655 This avoids some subtle aliasing issues, which typically
2656 aren't a problem with GCC but may be a problem elsewhere.
2657 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2658 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2659 In either case, it uses a flexible array member rather than
2660 the old struct hack. All uses changed.
2661 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2662 Adjust to sdata reorganization.
2663 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2664 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2665 that ports better to pre-C99 non-GCC.
2666 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2667 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2668 as the latter has changed.
2669 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2670 and port better to pre-C99 GCC.
2671 * image.c (struct xpm_cached_color):
2672 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2673 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2674 Use FLEXIBLE_ARRAY_MEMBER.
2675 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2676 Move decl to top level so it gets checked against implementation.
2677 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2678 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2679
1fc71008
PE
26802013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 * syntax.c: Integer cleanups.
2683 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2684 All uses that need 0-or-2 changed to:
2685 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2686 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2687 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2688 (char_quoted, prev_char_comend_first, back_comment)
2689 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2690 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2691 Use bool for boolean.
2692 (update_syntax_table, skip_chars, skip_syntaxes):
2693 Prefer int to unsigned when either will do.
2694 (back_comment): Return boolean success flag, like forw_comment,
2695 instead of positive-or-minus-1 (which might have overflowed int anyway).
2696 Don't stuff ptrdiff_t into int.
2697 (syntax_spec_code, syntax_code_spec): Now const.
2698 (Fmatching_paren, scan_lists, scan_sexps_forward):
2699 Use enum syntaxcode for syntax code.
2700 (Fmatching_paren): Check that arg is a character, not just an integer.
2701 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2702 (Finternal_describe_syntax_value): Omit no-longer-needed
2703 comparison to 0.
2704 (skip_chars): Use char, not unsigned char, when the distinction
2705 doesn't matter.
2706 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2707 * bytecode.c (exec_byte_code):
2708 * syntax.c (syntax_spec_code, Fchar_syntax)
2709 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2710 (init_syntax_once):
2711 * syntax.h (SYNTAX_WITH_FLAGS):
2712 Omit unnecessary casts.
2713
b932cad7
EZ
27142013-06-20 Eli Zaretskii <eliz@gnu.org>
2715
2716 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2717 line dimensions here, to avoid race conditions with the main
2718 thread. (Bug#14062, bug#14630, bug#14669)
2719
2720 * w32term.c (w32_draw_window_cursor): Compute the header line and
2721 mode line dimensions here.
2722 <w32_system_caret_window, w32_system_caret_hdr_height>:
2723 <w32_system_caret_mode_height>: New variables.
2724
2725 * w32term.h: Declare them.
2726
89561f72
PE
27272013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2728
5013fc08
PE
2729 * alloc.c (die): Move "assertion failed" string here ...
2730 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2731 COND when SUPPRESS_CHECKING. This shrinks the executable text
2732 size by 0.8% to 2.2% when configured with --enable-checking,
2733 depending on optimization flags (GCC 4.8.1 x86-64).
2734
89561f72
PE
2735 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2736
763a086d 27372013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2738
2739 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2740 base is 2; this is more accurate.
2741
983aeb9a
JB
27422013-06-19 Juanma Barranquero <lekktu@gmail.com>
2743
2744 * sound.c (string_default): Move to !WINDOWSNT section.
2745 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2746
178ba3e6
PE
27472013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2748
bbc51b15
PE
2749 * sound.c: Integer cleanups.
2750 Remove unnecessary forward decls.
2751 (struct sound_device): The 'file' member is now a Lisp_Object, not
2752 a char *, so that we needn't invoke alloca on a huge size.
2753 (Fplay_sound_internal): Adjust to this.
2754 (string_default): New function.
2755 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2756 Use it to adjust to the struct sound_device change.
2757 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2758 (be2hs) [0]: Remove.
2759
178ba3e6
PE
2760 * syntax.c (skip_chars): Don't use uninitialized storage
2761 when searching a multibyte buffer for characters that are not in a
2762 unibyte string that contains non-ASCII characters.
2763
69f60cdc
JD
27642013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2765
2766 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2767 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2768
0d6224d4
PE
27692013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2770
2771 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2772
3c542890
KH
27732013-06-18 Kenichi Handa <handa@gnu.org>
2774
f7e3f7cd
KH
2775 * font.c (Ffont_spec): Signal an error for an invalid font name
2776 (Bug#14648).
3c542890 2777
9349e5f7
PE
27782013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2779
2780 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2781 In particular this ports to 32-bit sparc Sun cc.
2782 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2783 array with a dummy element at specpdl[-1], so that its address can
2784 be taken portably.
2785 (unbind_to): Do not copy the binding; not needed, now that we
2786 copy old_value in the one place where the copy is needed.
2787 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2788 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2789 (union specbinding): Rename from struct specbinding. Redo layout
2790 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2791 which is not portable. With Sun C 5.12 32-bit sparc, the
2792 declaration causes nargs to be an unsigned bitfield, a behavior
2793 that the C standard allows; but Emacs wants nargs to be signed.
2794 The overall type is now a union of structures rather than a
2795 structure of union of structures, and the 'kind' member is now a
2796 bitfield, so that the overall type doesn't grow. All uses changed.
2797 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2798
0a4df6a5
PE
27992013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2800
ec6ecaad
PE
2801 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2802 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2803
0a4df6a5
PE
2804 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2805
7bfe8dbc
EZ
28062013-06-17 Eli Zaretskii <eliz@gnu.org>
2807
2808 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2809 unless we know that the window w's frame is a frame object.
2810 Another attempt at solving bug#14062 and bug#14630.
2811
708e05f6
LMI
28122013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2813
2814 * textprop.c (property_set_type): New enum.
2815 (add_properties): Allow appending/prepending text properties.
2816 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2817 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2818 add_text_properties_1.
2819 (Fadd_face_text_property): New function that calls
2820 add_text_properties_1.
2821
84575e67
PE
28222013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2823
2824 Move functions from lisp.h to individual modules when possible.
2825 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2826 * alloc.c (XFLOAT_INIT, set_symbol_name):
2827 * buffer.c (CHECK_OVERLAY):
2828 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2829 (set_char_table_parent):
2830 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2831 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2832 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2833 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2834 (set_blv_valcell):
2835 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2836 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2837 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2838 (backtrace_args, backtrace_debug_on_exit):
2839 * floatfns.c (CHECK_FLOAT):
2840 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2841 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2842 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2843 (set_hash_index_slot):
2844 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2845 * marker.c (CHECK_MARKER):
2846 * textprop.c (CHECK_STRING_OR_BUFFER):
2847 * window.c (CHECK_WINDOW_CONFIGURATION):
2848 Move here from lisp.h, and make these functions static rather than
2849 extern inline.
2850 * buffer.c (Qoverlayp):
2851 * data.c (Qsubrp):
2852 * fns.c (Qhash_table_p):
2853 * window.c (Qwindow_configuration_p):
2854 Now static.
2855 * lisp.h: Remove the abovementioned defns and decls.
2856
44e18199 2857 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2858 In lisp.h, prefer functions to function-like macros, and
2859 constants to object-like macros, when either will do. This:
2860 . simplifies use, as there's no more need to worry about
2861 arguments' side effects being evaluated multiple times.
2862 . makes the code easier to debug on some platforms.
2863 However, when using gcc -O0, keep using function-like macros
2864 for a few critical operations, for performance reasons.
2865 This sort of thing isn't needed with gcc -Og, but -Og
2866 is a GCC 4.8 feature and isn't widely-enough available yet.
2867 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2868 Remove enum lsb_bits; no longer needed.
2869 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2870 * buffer.c (Qoverlap):
2871 * data.c (Qsubrp):
2872 * fns.c (Qhash_table_p):
2873 Now extern, so lisp.h can use these symbols.
2874 * dispextern.h: Include character.h, for MAX_CHAR etc.
2875 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2876 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2877 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2878 (GLYPH_CODE_P): Move here from lisp.h.
2879 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2880 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2881 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2882 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2883 XUNTAG now returns void *.
2884 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2885 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2886 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2887 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2888 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2889 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2890 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2891 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2892 New macros, renamed from their sans-lisp_h_ counterparts.
2893 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2894 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2895 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2896 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2897 If compiling via GCC without optimization, define these as macros
2898 in addition to inline functions.
2899 To disable this, compile with -DINLINING=0.
2900 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2901 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2902 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2903 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2904 (INTMASK, VALMASK): Now macros, since static values cannot be
2905 accessed from extern inline functions.
2906 (VALMASK): Also a constant, for benefit of old GDB.
2907 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2908 is INTEGERP, which can fold it in.
5165d44a 2909 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2910 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2911 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2912 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2913 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2914 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2915 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2916 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2917 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2918 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2919 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2920 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2921 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2922 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2923 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2924 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2925 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2926 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2927 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2928 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2929 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2930 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2931 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2932 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2933 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2934 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2935 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2936 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2937 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2938 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2939 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2940 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2941 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2942 Now functions.
2943 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2944 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2945 (VALMASK): Define in one place rather than in two, merging the
2946 USE_LSB_TAG parts; this is simpler.
2947 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2948 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2949 Move up, to avoid use before definition.
2950 Also include "globals.h" earlier, for the same reason.
2951 (make_natnum): New function.
2952 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2953 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2954 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2955 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2956 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2957 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2958 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2959 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2960 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2961 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2962 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2963 (Qwindow_configuration_p, Qimage): New forward declarations.
2964 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2965 (STRING_COPYIN): Remove; unused.
2966 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2967 (xcar_addr, xcdr_addr): New functions. All uses changed.
2968 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2969 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2970 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2971 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2972 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2973 (TYPE_RANGED_INTEGERP): Simplify.
2974 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2975 (setlocale, fixup_locale, synchronize_system_messages_locale)
2976 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2977 Now empty functions, not macros.
2978 (functionp): Return bool, not int.
2979 * window.c (Qwindow_configuration_p): Now extern,
2980 so window.h can use it.
2981 * window.h (Qwindowp): Move decl back to lisp.h.
2982
9583ec36
EZ
29832013-06-15 Eli Zaretskii <eliz@gnu.org>
2984
2985 * xdisp.c (Fline_pixel_height): New function, required for solving
2986 bug #14567.
2987
210272ce
PE
29882013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2989
2990 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2991
de0503df
SM
29922013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2993
2994 * lread.c (syms_of_lread):
2995 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2996
afbfe143
KD
29972013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2998
2999 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3000
d177e213
XF
30012013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3002
3003 * fileio.c (expand_file_name): Doc fix.
3004
05e3e412
PE
30052013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3006
f7394b12
PE
3007 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3008 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3009 Wait for self, not for 0. This can't hurt on GNU or similar
3010 system, and may help with Cygwin.
3011
05e3e412
PE
3012 * keyboard.c: Don't use PROP (...) as an lvalue.
3013 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3014 Use set_prop (A, B), not PROP (A) = B.
3015
17dd3097
EZ
30162013-06-10 Eli Zaretskii <eliz@gnu.org>
3017
3018 * xdisp.c (get_it_property): Use it->window instead of generating
3019 a Lisp object from it->w.
3020
52fab9c9
EZ
30212013-06-09 Eli Zaretskii <eliz@gnu.org>
3022
3023 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3024 get-char-property the window that is being rendered, instead of
3025 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3026 (compute_display_string_pos): When W is NULL, use the current
3027 buffer as the object to pass to get-char-property.
3028 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3029 pointer member of the bidi iterator, since no window is pertinent
3030 to this function.
52fab9c9 3031
5bf97bfc
EZ
30322013-06-08 Eli Zaretskii <eliz@gnu.org>
3033
3034 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3035 being displayed, and pass it to compute_display_string_pos.
3036 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3037 (bidi_paragraph_init): All callers changed.
3038
3039 * xdisp.c (init_from_display_pos, init_iterator)
3040 (handle_single_display_spec, next_overlay_string)
3041 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3042 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3043 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3044 (compute_display_string_pos): Accept additional argument, the
3045 window being displayed, and pass it to Fget_char_property.
3046 (Bug#14575)
3047
3048 * dispextern.h (struct bidi_it): New member w, the window being
3049 displayed.
3050 (compute_display_string_pos): Adjust prototype.
3051
5de0e011
JD
30522013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3053
e7b41c4c 3054 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3055
3056 * process.c (wait_reading_process_output): Check for NS before GLIB.
3057 GLIB may be linked in due to rsvg, but ns_select must be called.
3058
5de0e011
JD
3059 * xgselect.c (xg_select): Remove call to window_system_available
3060 and g_main_context_pending at the top, so Gdk events (i.e. file
3061 notify) are processed when Emacs is started with -nw.
3062
a822acff
EZ
30632013-06-07 Eli Zaretskii <eliz@gnu.org>
3064
3065 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3066 (ctagsfiles3): New variable, includes only *.m files.
3067 (TAGS): Use an explicit language name in the regular expressions,
3068 to avoid transformation of '/SOMETHING' by MSYS to
3069 'c:\MSYS\SOMETHING'.
3070
6c0a9ed1
RC
30712013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3072
3073 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3074
9ef6111b
EZ
30752013-06-06 Eli Zaretskii <eliz@gnu.org>
3076
3077 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3078 still need to set the mouse pointer shape and activate help-echo.
3079 (Bug#14558)
3080
7d300d64
PE
30812013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 A few porting etc. fixes for the new file monitor code.
3084 See the thread containing
3085 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3086 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3087 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3088 (dir_monitor_callback, Fgfile_rm_watch):
3089 Use assq_no_quit instead of Fassoc, for speed.
3090 (dir_monitor_callback, Fgfile_rm_watch):
3091 eassert that the monitor is a fixnum.
3092 (dir_monitor_callback): No need for CDR_SAFE.
3093 Simplify building of lisp with alternative tails.
3094 (Fgfile_add_watch, Fgfile_rm_watch):
3095 Do not assume glib functions set errno reliably on failure.
3096 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3097 and signal an error otherwise.
3098 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3099 Use Fdelq instead of Fdelete, for speed.
3100
817ebfcf
EZ
31012013-06-05 Eli Zaretskii <eliz@gnu.org>
3102
3103 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3104 don't insist on being invoked on a highlighted tool-bar button.
3105 Avoids losing tool-bar functionality when mouse-highlight is nil.
3106 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3107 Don't highlight when mouse-highlight is nil.
3108 (note_mouse_highlight): When mouse-highlight is nil, don't return
3109 right away; instead, run tool-bar and mode-line highlight
3110 subroutine, clear any existing highlight, and revert the mouse
3111 pointer to its default shape. (Bug#14558)
3112
55577e7c
SM
31132013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3114
3115 * lisp.mk (lisp): Add prog-mode.el.
3116
f019a684
PE
31172013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3118
3119 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3120 * process.c (dummy_handler): New function.
3121 (lib_child_handler): New static var.
3122 (handle_child_signal): Invoke it.
3123 (catch_child_signal): If a library has set up a signal handler,
3124 save it into lib_child_handler.
3125 (init_process_emacs): If using glib and not on Windows, tickle glib's
3126 child-handling code so that it initializes its private SIGCHLD handler.
3127 * syssignal.h (SA_SIGINFO): Default to 0.
3128 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3129 31; it should no longer be needed now.
3130
90db8702
MA
31312013-06-05 Michael Albinus <michael.albinus@gmx.de>
3132
3133 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3134
3135 * gfilenotify.c (globals_of_gfilenotify): New function.
3136 (syms_of_gfilenotify): Move global initialization there.
3137
3138 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3139
bfa3acd6
SM
31402013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3141
3142 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3143 * keyboard.c (menu_bar_items, tool_bar_items):
3144 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3145 not override local keymaps any more.
3146
ba59bd80
EZ
31472013-06-04 Eli Zaretskii <eliz@gnu.org>
3148
3149 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3150
7f203aa1
EZ
31512013-06-03 Eli Zaretskii <eliz@gnu.org>
3152
9337e206
EZ
3153 * w32console.c (initialize_w32_display): Return the dimensions of
3154 the console window via 2 additional arguments, not via the current
3155 frame. This avoids crashes due to overrunning the bounds of
3156 frame's decode_mode_spec_buffer, which is not resized following
3157 the change of the frame dimensions from the initial 10x10.
3158
3159 * w32term.h (w32_initialize_display_info): Adjust prototype.
3160
3161 * term.c (init_tty): Take dimensions of the frame from the values
3162 returned by initialize_w32_display.
3163
7f203aa1
EZ
3164 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3165 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3166 (LIBES): Add $(GFILENOTIFY_LIBS).
3167
3168 * w32inevt.c (handle_file_notifications): Add dummy implementation
3169 for !HAVE_W32NOTIFY.
3170
3171 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3172
55a87246
JD
31732013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3174
3175 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3176
3177 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3178
3179 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3180
3d5ee10a
PE
31812013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3182
3183 Fix minor problems found by static checking.
3184 * data.c (pure_write_error):
3185 Use xsignal2, not Fsignal, as Fsignal might return.
3186 * eval.c (set_backtrace_debug_on_exit): Now static.
3187 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3188 No longer inline. EXTERN_INLINE is needed only for functions
3189 defined in .h files. Reindent function header as per GNU style.
3190 (backtrace_p, backtrace_top, backtrace_next):
3191 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3192 compiler or linker. Add extern decls to pacify gcc -Wall.
3193 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3194 Now static.
3195 * frame.c (free_monitors): Define only on platforms that need it.
3196 * nsterm.m (ns_term_init):
3197 * process.c (catch_child_signal):
3198 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3199 defined on all porting targets these days.
3200 * process.c, process.h (catch_child_signal):
3201 Make it extern only if NS_IMPL_GNUSTEP is defined.
3202
e2d8a6f0
EZ
32032013-06-03 Eli Zaretskii <eliz@gnu.org>
3204
3205 * w32.c (gettimeofday): Make the signature identical to prototype
3206 in nt/inc/sys/time.h.
3207
a8a7c5f6
SM
32082013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3209
3210 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3211 .gdbinit.
3212
3213 * keyboard.c (safe_run_hooks_error): Improve error message.
3214
3215 * data.c (pure_write_error): Add `object' argument.
3216 * puresize.h (CHECK_IMPURE): Use it.
3217
c9628c79
MA
32182013-06-03 Michael Albinus <michael.albinus@gmx.de>
3219
3220 * Makefile.in (NOTIFY_OBJ): New variable.
3221 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3222
3223 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3224 Call syms_of_gfilenotify.
3225
3226 * gfilenotify.c: New file.
3227
3228 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3229 and Qfile_w32notify.
3230 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3231 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3232
3233 * lisp.h: Declare syms_of_gfilenotify.
3234
3235 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3236
2f592f95
SM
32372013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3238
3239 Merge the specpdl and backtrace stacks. Make the structure of the
3240 specpdl entries more obvious via a tagged union of structs.
3241 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3242 (enum specbind_tag): New enum.
3243 (struct specbinding): Make it a tagged union of structs.
3244 Add a case for backtrace records.
3245 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3246 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3247 (backtrace_debug_on_exit): New accessors.
3248 (struct backtrace): Remove.
3249 (struct catchtag): Remove backlist field.
3250 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3251 Move to eval.c.
3252 (Flocal_variable_p): Speed up the common case where the binding is
3253 already loaded.
3254 * eval.c (backtrace_list): Remove.
3255 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3256 (set_backtrace_args, set_backtrace_nargs)
3257 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3258 (backtrace_next): New functions.
3259 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3260 (unwind_to_catch, internal_lisp_condition_case)
3261 (internal_condition_case, internal_condition_case_1)
3262 (internal_condition_case_2, internal_condition_case_n): Don't bother
3263 with backtrace_list any more.
3264 (Fsignal): Adjust to new backtrace format.
3265 (grow_specpdl): Move up.
3266 (record_in_backtrace): New function.
3267 (eval_sub, Ffuncall): Use it.
3268 (apply_lambda): Adjust to new backtrace format.
3269 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3270 data.c.
3271 (specbind): Adjust to new specpdl format. Simplify.
3272 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3273 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3274 backtrace format.
3275 (mark_backtrace): Remove.
3276 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3277 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3278 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3279 Use mark_specpdl.
3280 * profiler.c (record_backtrace): Use get_backtrace.
3281 (handle_profiler_signal): Use backtrace_top_function.
3282 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3283 accessor functions.
3284
c0342369
JD
32852013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3286
3287 * process.h (catch_child_signal): Declare.
3288
3289 * process.c (catch_child_signal): New function.
3290 (init_process_emacs): Call it.
3291
3292 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3293 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3294 NS_IMPL_COCOA.
3295 (x_set_cursor_type): Remove declaration.
3296 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3297 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3298 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3299 (ns_get_color): Use F suffix on float.
3300 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3301 (ns_get_rgb_color): Remove.
3302 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3303 (note_mouse_movement): x and y are CGFloat.
3304 (ns_draw_fringe_bitmap): Remove unused rowY.
3305 Change #if to COCOA && >= 10_6.
3306 (ns_draw_window_cursor): Remove unused overspill.
3307 (ns_draw_underwave): width and x are EamcsCGFloat.
3308 (ns_draw_box): thickness is CGFloat.
3309 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3310 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3311 if not in main thread.
3312 (ns_get_pending_menu_title, ns_check_menu_open)
3313 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3314 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3315 (sendFromMainThread:): New method.
3316 (changeFont:): size is CGFloat.
3317 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3318 Disable warning about permanent text.
3319 (characterIndexForPoint:): Adjust return type depending on GNUStep
3320 version.
3321 (mouseDown:): delta is CGFloat.
3322 (updateFrameSize): Remove unised variable f.
3323 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3324 Cast float to EmacsCGFloat.
3325 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3326 also to -1 when restoring.
3327 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3328 inside NS_IMPL_COCOA.
3329 (toggleFullScreen:): Put call to toggleFullScreen inside
3330 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3331 (setPosition:portion:whole:): por is CGFloat.
3332 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3333 (mouseDown:): Use CGFloat.
3334 (mouseDragged:): Remove unised variable edge.
3335 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3336
3337 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3338 of CGFloat differs.
3339 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3340 when NS_IMPL_GNUSTEP.
3341 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3342 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3343 (EmacsToolbar): Add clearAll. Add tag argument to
3344 addDisplayItemWithImage.
3345 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3346
3347 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3348
3349 * nsmenu.m (ns_update_menubar): Make static.
3350 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3351 (fillWithWidgetValue:): Add cast to SEL for setAction.
3352 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3353 (update_frame_tool_bar): Update code for GNUStep.
3354 (clearAll): New method.
3355 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3356 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3357 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3358 call to insertItemWithItemIdentifier.
3359 (validateVisibleItems): Fix indentation.
3360 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3361 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3362 UtilityWindow to aStyle, remove call to setStyleMask.
3363
3364 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3365
3366 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3367 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3368 Use F suffix on floats.
3369 (ns_char_width): Returns CGFloat.
3370 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3371 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3372 DPSxshow.
3373 (ns_glyph_metrics): CGFloat instead of float.
3374
a0eb10b3
JB
3375 * nsfns.m (x_set_foreground_color, x_set_background_color):
3376 Use EmacsCGFloat.
3377 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3378 remove unused variables.
3379 (Fns_read_file_name): Keep track if panel is for save.
3380 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3381 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3382 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3383 Just return the input if GNUStep.
c0342369
JD
3384 (x_screen_planes): Remove.
3385 (Fxw_color_values): Use EmacsCGFloat
3386 (Fns_display_monitor_attributes_list): Only get screen number for
3387 Cocoa.
ef099a94 3388 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3389 EmacsSavePanel.
3390 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3391 ns_directory_from_panel.
3392
da9aff11
PE
33932013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3394
3395 * process.c (handle_child_signal): Also use WCONTINUED.
3396 This is so that list-processes doesn't mistakenly list the process
3397 as stopped, when the process has actually been continued and is
3398 now running.
3399
0e64479a
PE
34002013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3401
fc186a96
PE
3402 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3403 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3404 not already configured.
3405
0e64479a
PE
3406 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3407
38b787fa
EZ
34082013-05-29 Eli Zaretskii <eliz@gnu.org>
3409
3410 * Makefile.in (mostlyclean): Remove *.res files.
3411
22513e52
SM
34122013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3413
3414 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3415 a buffer (bug#8447).
3416
6ef3db10
EZ
34172013-05-27 Eli Zaretskii <eliz@gnu.org>
3418
3419 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3420 display vector, and we backtrack, handle the case that the
3421 previous character position is also displayed from a display
3422 vector or covered by a display string or image. (Bug#14476)
3423
6799bb26
JD
34242013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3425
3426 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3427 (struct MonitorInfo, free_monitors): Remove.
3428 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3429 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3430 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3431 Qframes, Qsource.
3432
3433 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3434 (struct MonitorInfo, free_monitors): Remove.
3435 (ns_screen_name): Make static.
3436 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3437 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3438 Qframes, Qsource.
3439
3440 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3441 (struct MonitorInfo): New struct.
3442 (free_monitors, make_monitor_attribute_list): Declare.
3443
22513e52
SM
3444 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3445 New Lisp_Object:s.
6799bb26
JD
3446 (free_monitors, make_monitor_attribute_list): New functions.
3447 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3448 Qsource.
3449
38cd43eb
XF
34502013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3451
3452 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3453
2af0948d
SM
34542013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3455
a7eb9b0f
SM
3456 * keyboard.c: Apply keyboard decoding only to events that come directly
3457 from the tty, not from unread-command-events (bug#14368).
3458 (read_event_from_main_queue): New function, extracted from read_char).
3459 (read_decoded_char): Remove.
3460 (read_decoded_event_from_main_queue): New function to replace it.
3461 (read_char): Use it.
3462 (read_key_sequence): Use read_char rather than read_decoded_char.
3463
2af0948d
SM
3464 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3465
1413e9a5
BR
34662013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3467
3468 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3469
e6d2f155
KH
34702013-05-22 Kenichi Handa <handa@gnu.org>
3471
3472 The following changes are to fix the setting of
3473 buffer-file-coding-system on, for instance, C-x RET c unix RET
3474 _FILE_OF_DOS_EOL_TYPE_ RET.
3475
3476 * coding.h (struct coding_system): New member detected_utf8_chars.
3477
3478 * coding.c (detect_coding_utf_8): Count characters and check EOL
3479 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3480 BOM is there.
3481 (setup_coding_system): Do not initialize coding->head_ascii.
3482 (check_ascii): Do not set coding->eol_seen but update it. Do not
3483 call adjust_coding_eol_type here.
1413e9a5
BR
3484 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3485 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3486 of the found coding-system.
3487 (decode_coding_gap): Cancel previous change. Utilize the
3488 character numbers counted by detect_coding_utf_8. Fix detection
3489 of BOM for utf-8.
3490
ab56a6f4 34912013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3492
3493 * search.c (looking_at_1): Only set last_thing_searched if the match
3494 changed the match-data (bug#14281).
3495
ecc3c6ed
DA
34962013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3497
3498 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3499 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3500 (move_it_vertically_backward): Likewise.
3501
5ba8bf35
YM
35022013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3503
3504 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3505 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3506 (Fx_display_mm_width, Fx_display_mm_height):
3507 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3508
91e8418b 3509 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3510 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3511 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3512 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3513 (Fx_display_backing_store, Fx_display_visual_class)
3514 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3515 (Fx_display_grayscale_p, Fx_display_pixel_width)
3516 (Fx_display_pixel_height, Fx_display_planes)
3517 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3518 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3519 (Fx_display_mm_width, Fx_display_mm_height)
3520 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3521 height for all physical monitors as in X11.
3522
fc30d803
SM
3523 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3524 Return pixel width or height for all physical monitors as in X11.
91e8418b 3525
31ff141c
PE
35262013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3527
3528 Port --enable-gcc-warnings to clang.
3529 * bytecode.c (exec_byte_code):
3530 * regex.c:
3531 Redo diagnostic pragmas to pacify clang, too.
3532 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3533 * editfns.c (Fencode_time):
3534 * fileio.c (file_accessible_directory_p):
3535 * font.c (font_unparse_xlfd):
3536 Use '&"string"[index]' instead of '"string" + (index)'.
3537 * undo.c (user_error): Remove; unused.
3538
df065a0b
EZ
35392013-05-16 Eli Zaretskii <eliz@gnu.org>
3540
04d360e7
EZ
3541 * insdel.c (insert_1_both): Document the arguments, instead of
3542 referring to insert_1, which no longer exists.
3543
5bb98290
EZ
3544 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3545 some window, increment windows_or_buffers_changed, so that
3546 *Messages* display in that window is updated. (Bug#14408)
3547
df065a0b
EZ
3548 * w32.c: Include epaths.h.
3549 (init_environment): Use cmdproxy.exe without leading directories.
3550 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3551 case.
3552 (gettimeofday): Adjust signature and return value to Posix
3553 expectations.
3554
3555 * unexw32.c (open_output_file): Delete the existing emacs.exe
3556 before creating it, to break the hard link to the versioned
3557 executable.
3558
3559 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3560 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3561 (FIRSTFILE_OBJ): New variables.
3562 (W32_RES): Rename to EMACSRES. All users changed.
3563 (base_obj): Use $(CM_OBJ).
3564 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3565 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3566 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3567 $(W32_RES_LINK) before $(LIBES).
3568 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3569
1aa8d505
SM
35702013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3571
6e911150
SM
3572 * makefile.w32-in (DOC): Use just "DOC".
3573
3574 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3575
1aa8d505
SM
3576 * process.c: Export default filters and sentinels to Elisp.
3577 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3578 New constants.
3579 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3580 (Fset_process_sentinel, Fformat_network_address):
3581 Default to them instead of nil.
3582 (server_accept_connection): Sentinels can't be nil any more.
3583 (read_and_dispose_of_process_output): New function, extracted from
3584 read_process_output.
3585 (read_process_output): Use it; filters can't be nil.
3586 (Finternal_default_process_filter): New function, extracted from
3587 read_process_output.
3588 (exec_sentinel_unwind): Remove function.
3589 (exec_sentinel): Don't zilch sentinel while running.
3590 (status_notify): Sentinels can't be nil.
3591 (Finternal_default_process_sentinel): New function extracted from
3592 status_notify.
3593 (setup_process_coding_systems): Default filter is not nil any more.
3594 (syms_of_process): Export new Elisp functions and initialize
3595 new constants.
3596 * lisp.h (make_lisp_proc): New function.
3597
5ac2eb34
SM
35982013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3599
3600 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3601
eda9c7d7
EZ
36022013-05-14 Eli Zaretskii <eliz@gnu.org>
3603
3604 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3605 unless we know that the window w is a leaf window.
3606 Another attempt at solving bug#14062.
eda9c7d7 3607
8fdeaad5
JD
36082013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3609
3610 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3611 fdesc (Bug#14375).
3612
44aa9ee6
PE
36132013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3614
3615 * image.c (gif_load): Check that subimages fit (Bug#14345).
3616
759fd763
SM
36172013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3618
3619 * lread.c (skip_dyn_eof): New function.
3620 (read1): Use it to skip the end of a file in response to #@00.
3621
3622 * doc.c (get_doc_string): Slightly relax the sanity checking.
3623
4465bfb4
JD
36242013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3625
3626 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3627 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3628 (MonitorInfo): New struct.
3629 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3630 (Fns_display_monitor_attributes_list): New functions.
3631 (display-usable-bounds): Remove.
3632 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3633 Qsource.
3634
7583e2a0
PE
36352013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3636
3637 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3638 (GTK_CHECK_VERSION): New macro, if not already defined.
3639 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3640 replaced by GTK_CHECK_VERSION.
3641
ad75d77e
PE
36422013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3643
3644 * xterm.h (GTK_PREREQ): New macro.
3645 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3646 to use this macro instead, for consistency and clarity.
3647
07525f77
EZ
36482013-05-08 Eli Zaretskii <eliz@gnu.org>
3649
3650 * xdisp.c (row_for_charpos_p): New function, with code of
3651 cursor_row_p, but accepts an additional argument CHARPOS instead
3652 of using a hardcoded PT.
3653 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3654 (row_containing_pos): Call row_for_charpos_p instead of partially
3655 doing the same. Fixes cursor positioning under longlines-mode
3656 when longlines-show-effect includes more than one newline, when
3657 moving the cursor vertically up.
3658
d901fc8d
JB
36592013-05-08 Juanma Barranquero <lekktu@gmail.com>
3660
3661 * makefile.w32-in (ACL_H): New macro.
3662 ($(BLD)/fileio.$(O)): Update dependencies.
3663
f269bc61
PE
36642013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3665
e7b41c4c 3666 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3667 * Makefile.in (LIB_ACL): New macro.
3668 (LIBACL_LIBS): Remove.
3669 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3670 * fileio.c: Include <acl.h>.
3671 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3672 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3673 !acl_errno_valid.
3674 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3675 it ourselves.
3676
f269bc61
PE
3677 * unexelf.c: Don't assume ElfW (Half) fits in int.
3678 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3679 when dealing with ElfW (Half) values, since they can exceed 2**31
3680 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3681 (entry_address): Omit unused NUM arg. All uses changed.
3682
a261c53e
JL
36832013-05-07 Juri Linkov <juri@jurta.org>
3684
3685 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3686 to the string converted from number with `Fnumber_to_string'.
3687 (Bug#14254)
3688
2b66427d
PE
36892013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3690
3691 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3692 This fixes a problem introduced by my previous change.
3693
15acfe41
GM
36942013-05-07 Glenn Morris <rgm@gnu.org>
3695
3696 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3697
5ea03bf5
JD
36982013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3699
3700 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3701
e0c9d565
PE
37022013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 Static checking by GCC 4.8.0.
3705 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3706 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3707 (x_get_monitor_attributes_fallback)
3708 (x_get_monitor_attributes_xinerama)
3709 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3710 Define only if USE_GTK.
3711 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3712 (x_get_monitor_attributes_fallback): Omit unused locals.
3713 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3714 Use double, not float, to avoid mixed-mode floating point arithmetic.
3715
4e3f9230
YM
37162013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3717 Jan Djärv <jan.h.d@swipnet.se>
3718
3719 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3720 (XINERAMA_CFLAGS): New macros.
3721 (ALL_CFLAGS, LIBES): Use them.
3722
3723 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3724 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3725 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3726 (syms_of_xfns): DEFSYM them.
3727 (struct MonitorInfo): New struct.
3728 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3729 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3730 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3731 (x_get_monitor_attributes_xinerama): New functions.
3732 (Fx_display_monitor_attributes_list): New primitive.
3733 (syms_of_xfns): Defsubr it.
3734
3735 * xterm.h (x_display_info): Add Xatom_net_workarea and
3736 Xatom_net_current_desktop.
3737
3738 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3739 and dpyinfo->Xatom_net_current_desktop.
3740
05839b6a
EZ
37412013-05-06 Eli Zaretskii <eliz@gnu.org>
3742
3743 * xdisp.c (pos_visible_p): Use the special code for finding the
3744 beginning of a display property or overlay for any "replacing"
3745 display property, not just for display strings. This solves
3746 incorrect reporting of position by posn-at-point. (Bug#14241)
3747
dc4a2ee0
PE
37482013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3749
5ee94506
PE
3750 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3751 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3752 Verify that ElfW (Half) fits in int.
3753 (fatal): Use same signature as lisp.h.
3754 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3755 configure and build with -DUNEXELF_DEBUG without worrying about
3756 other modules that use DEBUG.
3757 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3758 possibly-wide integers now uses it instead of plain fprintf.
3759 (entry_address): New function, which avoids problems with 32-bit
3760 overflow on 64-bit hosts.
3761 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3762 (round_up): Don't assume the remainder fits in int.
3763 (find_section): Use bool for boolean. Simplify debug code.
3764 (unexec): Don't assume file sizes fit in int or size_t.
3765 Omit unnecessary trailing newline in 'fatal' format.
3766 Use strerror rather than outputting decimal error number.
3767 Remove unused code when emacs is not defined;
3768 this file relies on Emacs now.
3769 Don't assume e_phnum and e_shnum are positive.
3770
dc4a2ee0
PE
3771 * regex.c: Fix problems when DEBUG is defined.
3772 (extract_number, extract_number_and_incr): Define regardless of
3773 whether DEBUG is defined; that's simpler and makes the code less
3774 likely to go stale in the normal case when DEBUG is not defined.
3775 Return int rather than taking an int * arg. All callers changed.
3776 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3777 Remove, replacing with ...
3778 (DEBUG_PRINT): New macro. All callers changed.
3779 (DEBUG_COMPILES_ARGUMENTS): New macro.
3780 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3781 (print_compiled_pattern, print_double_string) [DEBUG]:
3782 Use prototype rather than old-style definition.
3783 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3784 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3785 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3786 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3787 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3788 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3789 This matters only when DEBUG is defined.
3790
14c7ed05
EZ
37912013-05-05 Eli Zaretskii <eliz@gnu.org>
3792
3793 * xdisp.c (set_iterator_to_next): Set the
3794 ignore_overlay_strings_at_pos_p flag only if we are _really_
3795 iterating over an overlay string, as indicated by the
3796 current.overlay_string_index member. (Bug#14306)
3797
e6076b1b
JD
37982013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3799
3800 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3801 to where it is used, to avoid autorelease issues (Bug#14050).
3802
cbee2131
PE
38032013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3804
3805 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3806 * fileio.c (syms_of_fileio): Implement this.
3807 * filelock.c (create_lock_file): If symbolic links don't work, so
3808 we use a regular file as a lock file, do not fsync the lock file;
3809 it's not needed.
3810
30c7e542
SM
38112013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3812
3813 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3814 (syms_of_minibuf): Adjust accodingly.
3815 * lread.c (Fread):
3816 * callint.c (Fcall_interactively): Adjust calls accordingly.
3817
5bebd186
EZ
38182013-05-04 Eli Zaretskii <eliz@gnu.org>
3819
3820 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3821 w->contents is a buffer before computing everything else.
3822 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3823
3824 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3825 assertion violations. (Bug#14062)
3826
0fb0a4f3
DR
38272013-05-01 David Reitter <david.reitter@gmail.com>
3828
3829 * nsfns.m (ns_tooltip): Initialize.
3830
9e63b4a5
EZ
38312013-04-28 Eli Zaretskii <eliz@gnu.org>
3832
3833 * coding.c (decode_coding_gap): Don't remove the character before
3834 a newline unless it's a CR character. (Bug#14287)
3835
ad60824e
DN
38362013-04-28 Dan Nicolaescu <dann@gnu.org>
3837
3838 * dispextern.h (struct face): Move enum face_underline_type
3839 earlier so that bitfields can be in the same word.
3840
edbdcec0
JD
38412013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3842
3843 * nsfns.m (handlePanelKeys): New function.
3844 (EmacsOpenPanel:performKeyEquivalent:)
3845 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3846 arrows/function/control and copy/paste keys (Bug#14296).
3847
0208ede7
JL
38482013-04-27 Juri Linkov <juri@jurta.org>
3849
3850 * callint.c (Fcall_interactively): Call `Qread_number' for
3851 interactive code letter `n' instead of using duplicate code.
3852 (Bug#14254)
3853
b8dd59f7
PE
38542013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3855
3856 * systime.h (make_timeval): Declare as 'const'.
3857
8bd722db
KH
38582013-04-27 Kenichi Handa <handa@gnu.org>
3859
3860 * font.c (font_open_entity): Always open a font of manageable
3861 size.
3862
13d0e56f 38632013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3864
f780d632
PE
3865 Port better to AIX (Bug#14258).
3866 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3867 to pacify AIX xlc.
3868
ec509856
KH
38692013-04-24 Kenichi Handa <handa@gnu.org>
3870
3871 * coding.c (decode_coding_iso_2022): When an invalid escape
3872 sequence is encountered, reset the invocation and designation
3873 status to the safest one.
3874
84fc48e5
PE
38752013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3878 Without this fix, "make distclean" leaves stamp-h1 behind.
3879
806bda47
EC
38802013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3881
3882 * w32fns.c (w32_fullscreen_rect): New function to compute the
3883 window rectangle for the given fullscreen mode.
3884 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3885 longer tunes the window size. This keeps the window's edges flush
3886 with the screen and allows the taskbar to hide itself in fullboth.
3887
3888 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3889 window decorations and uses the entire screen.
3890
3891 * w32term.h (w32_fullscreen_rect) Add prototype.
3892 (struct w32_output): Replace normal_width, normal_height,
3893 normal_top, and normal_left members with a single normal_placement
3894 struct.
3895 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3896 Remove macros.
3897 (FRAME_NORMAL_PLACEMENT): New macro.
3898
9cc2810b
JB
38992013-04-16 Juanma Barranquero <lekktu@gmail.com>
3900
3901 * minibuf.c (Ftest_completion): Silence compiler warning.
3902
fd16b54c
EZ
39032013-04-15 Eli Zaretskii <eliz@gnu.org>
3904
3905 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3906 bug#14062.
fd16b54c
EZ
3907
3908 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3909 parentheses.
3910
3911 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3912 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3913 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3914 parentheses where appropriate.
3915
9e3379a0
PE
39162013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3917
3918 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3919
ddd6b685
EZ
39202013-04-14 Eli Zaretskii <eliz@gnu.org>
3921
3922 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3923 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3924 Mention in the doc string that setting these variables takes
3925 effect only after a call to set-window-buffer. (Bug#14200)
3926
29b79ba1
EZ
39272013-04-13 Eli Zaretskii <eliz@gnu.org>
3928
3929 * indent.c (Fvertical_motion): Don't consider display strings on
3930 overlay strings as display strings on the buffer position we
3931 started from. This prevents vertical cursor motion from jumping
3932 more than one line when there's an overlay string with a display
3933 property at end of line.
3934 Reported by Karl Chen <Karl.Chen@quarl.org> in
3935 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3936
562c6ee9
SM
39372013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3938
3939 * window.c (select_window): `record_buffer' even if window is
3940 already selected (bug#14191).
3941
fcc1fe85
EZ
39422013-04-11 Eli Zaretskii <eliz@gnu.org>
3943
3944 * window.c (Fwindow_end): Test more flags, including the buffer's
3945 last_overlay_modified flag, to determine whether the window's
3946 display is really up-to-date. Prevents the function from
3947 returning a stale value. (Bug#14170)
3948 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3949 current matrix.
3950
f009190a
EZ
39512013-04-10 Eli Zaretskii <eliz@gnu.org>
3952
3953 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3954 garbaged only if it is not already the top frame on its TTY.
3955 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3956 there are GUI frames open in the same session. (Bug#13864)
3957
78ce603d
SM
39582013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3959
3960 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3961 of marking the idle timers directly.
3962
a8036e40
SM
39632013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3964
3965 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3966 tables (bug#14054).
3967
7ffe7ef6
SM
39682013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3969
3970 * window.c (select_window): Don't record_buffer while the invariant is
3971 temporarily broken (bug#14161).
3972
3973 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3974
7d9f6883
EZ
39752013-04-07 Eli Zaretskii <eliz@gnu.org>
3976
3977 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3978
5406cfd9
RF
39792013-04-07 Romain Francoise <romain@orebokech.com>
3980
3981 Ignore additional platform-specific ACL errors (Bug#13702).
3982 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3983 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3984
95c0e83b
JD
39852013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3986
3987 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3988 f->output_data.ns.
3989
876da980
PE
39902013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3993 This bug was introduced by my 2013-02-25 change that simplified
3994 data_start configuration. Without this change, on GNU/Linux
3995 an Emacs configured with --enable-profiling fails immediately
3996 due to a profiler signal.
3997 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3998 with these flags. On platforms where special flags are needed
3999 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4000 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4001 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4002
7452b7bd
DA
40032013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4004
4005 Get rid of some platform-specific functions examining window
4006 system and its capabilities. This is a partial rework of the
4007 2013-04-05 change.
4008 * lisp.h (have_menus_p): Remove prototype. This function is
4009 replaced with platform-independent window_system_available.
4010 (check_window_system): Move to...
4011 * frame.h (decode_window_system_frame, window_system_available):
4012 ...here, add new prototypes.
4013 * frame.c (window_system_available, decode_window_system_frame):
4014 New functions.
4015 (check_window_system): Platform-independent now.
4016 * xterm.h (x_in_use): Remove declaration.
4017 (check_x_frame):
4018 * w32term.h (check_x_frame):
4019 * nsterm.h (check_x_frame): Remove prototypes. This function
4020 is replaced with platform-independent decode_window_system_frame.
4021 * msdos.c (have_menus_p): Remove.
4022 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4023 Remove platform-specific functions. Use check_window_system,
4024 decode_window_system_frame and check_ns_display_info where
4025 appropriate. Minor style and comment tweaks.
4026 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4027 (check_x_frame): Likewise.
4028 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4029 Likewise.
4030 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4031 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4032 * xmenu.c, xselect.c: All related users changed.
4033
251e9147
KH
40342013-04-03 Kenichi Handa <handa@gnu.org>
4035
4036 The following changes is to optimize the code for reading UTF-8
4037 files.
4038
562c6ee9 4039 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4040 changed. Check EOL format. Do not call adjust_coding_eol_type
4041 here.
4042 (check_utf_8): New function.
4043 (adjust_coding_eol_type): Do nothing if already adjusted.
4044 (detect_coding): Compare the return value of check_ascii with
4045 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4046 (decode_coding_gap): Optimize for valid UTF-8.
4047
8bc369d4
KH
40482013-03-21 Kenichi Handa <handa@gnu.org>
4049
4050 * coding.c (syms_of_coding): Cancel previous change.
4051
4052 * insdel.c (insert_from_gap): Fix previous change.
4053
73931ad1
DA
40542013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4055
4056 Consistently use platform-specific function to detect window system.
4057 * lisp.h (check_window_system): New prototype. This function is
4058 going to replace check_x, check_w32 and check_ns.
4059 (have_menus_p): Mention msdos.c in comment.
4060 * fontset.c (check_window_system_func): Remove. Adjust all users.
4061 * fontset.h (check_window_system_func): Remove prototype.
4062 * nsterm.h (check_ns):
4063 * xterm.h (check_x):
4064 * w32term.h (check_w32): Likewise.
4065 * menu.c (Fx_popup_menu): Use check_window_system.
4066 * msdos.c (check_window_system): Define for MS-DOS.
4067 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4068 * w32fns.c (check_window_system): Likewise for MS-Windows.
4069 * xfns.c (check_window_system): Likewise for X.
4070 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4071 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4072
7216e43b
PE
40732013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4074
4075 Prefer < to > in range checks such as 0 <= i && i < N.
4076 This makes it easier to visualize quantities on a number line.
4077 This patch doesn't apply to all such range checks,
4078 only to the range checks affected by the 2013-03-24 change.
4079 This patch reverts most of the 2013-03-24 change.
4080 * alloc.c (xpalloc, Fgarbage_collect):
4081 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4082 * character.c (string_escape_byte8):
4083 * charset.c (read_hex):
4084 * data.c (cons_to_unsigned):
4085 * dispnew.c (update_frame_1):
4086 * doc.c (Fsubstitute_command_keys):
4087 * doprnt.c (doprnt):
4088 * editfns.c (hi_time, decode_time_components):
4089 * fileio.c (file_offset):
4090 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4091 * font.c (font_intern_prop):
4092 * frame.c (x_set_alpha):
4093 * gtkutil.c (get_utf8_string):
4094 * indent.c (check_display_width):
4095 * keymap.c (Fkey_description):
4096 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4097 * lread.c (read1):
4098 * minibuf.c (read_minibuf_noninteractive):
4099 * process.c (wait_reading_process_output):
4100 * search.c (Freplace_match):
4101 * window.c (get_phys_cursor_glyph):
4102 * xdisp.c (redisplay_internal):
4103 * xsmfns.c (smc_save_yourself_CB):
4104 Prefer < to > for range checks.
4105 * dispnew.c (sit_for): Don't mishandle NaNs.
4106 This fixes a bug introduced in the 2013-03-24 change.
4107 * editfns.c (decode_time_components): Don't hoist comparison.
4108 This fixes another bug introduced in the 2013-03-24 change.
4109
92759988
DA
41102013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4111
4112 * frame.h (struct frame): Drop scroll_bottom_vpos
4113 member becaue all real users are dead long ago.
4114 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4115 * xdisp.c (redisplay_internal): Adjust user.
4116
9a1971bb
GM
41172013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4118
f38ab167
JD
4119 * nsmenu.m (showAtX:Y:for:): setLevel to
4120 NSPopUpMenuWindowLevel (Bug#13998).
4121
6d01f1fe
JD
41222013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4123
4124 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4125 (ns_check_pending_open_menu): Declare.
4126
4127 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4128 (x_activate_menubar): Update the menu with title that matches
4129 ns_get_pending_menu_title, and call
4130 ns_check_pending_openmenu (Bug#12698).
4131 (menuWillOpen:): New method.
4132 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4133
4134 * nsterm.m (menu_will_open_state, menu_mouse_point)
4135 (menu_pending_title): New varaibles.
4136 (ns_get_pending_menu_title, ns_check_menu_open)
4137 (ns_check_pending_open_menu): New functions.
4138
781f4782
DA
41392013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4140
4141 * indent.c (current_column_bol_cache): Remove leftover which is not
4142 used in Fmove_to_column any more.
4143 (current_column, scan_for_column): Adjust users.
4144 * keyboard.c (last_point_position_buffer, last_point_position_window):
4145 Remove leftovers which are not used for recording undo any more.
4146 (command_loop_1, syms_of_keyboard): Adjust users.
4147 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4148 redisplay_window any more.
4149 (move_it_to): Adjust user.
4150
1921c31b
JB
41512013-03-29 Juanma Barranquero <lekktu@gmail.com>
4152
4153 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4154 Update dependencies.
4155
717b8bcd
SM
41562013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4157
4158 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4159 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4160 forward references.
4161
e74aeda8
DA
41622013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4163
4164 * window.h (struct window): Replace hchild, vchild and buffer slots
4165 with the only contents slot. This is possible because each valid
4166 window may have either the child window (in vertical or horizontal
4167 combination) or buffer to display (for the leaf window). Using that,
4168 a lof of operations to traverse and/or change window hierarchies may
4169 be simplified. New member horizontal is used to distinguish between
4170 horizontal and vertical combinations of internal windows.
4171 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4172 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4173 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4174 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4175 Use contents slot, not buffer, where appropriate.
4176 (wset_combination): New function.
4177 (wset_buffer): Add eassert.
4178 (Fframe_first_window): Simplify the loop reaching first window.
4179 (Fwindow_buffer): Use WINDOW_LEAF_P.
4180 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4181 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4182 (unshow_buffer): Convert initial debugging check to eassert.
4183 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4184 (make_parent_window, window_resize_check, window_resize_apply)
4185 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4186 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4187 Adjust to match struct window changes.
4188 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4189 (mark_window_cursors_off, count_windows, get_leaf_windows)
4190 (foreach_window_1): Simplify the loop.
4191 * alloc.c (mark_object): Do not check for the leaf window because
4192 internal windows has no glyph matrices anyway.
4193 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4194 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4195 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4196 (build_frame_matrix_from_window_tree, mirror_make_current)
4197 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4198 (update_window_tree, set_window_update_flags): Simplify the loop.
4199 (sync_window_with_frame_matrix_rows): Enforce live window.
4200 Use contents slot, not buffer, where appropriate.
4201 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4202 and WINDOW_HORIZONTAL_COMBINATION_P.
4203 (make_frame_visible_1): Simplify the loop.
4204 Use contents slot, not buffer, where appropriate.
4205 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4206 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4207 (expose_window_tree): Likewise.
4208 Use contents slot, not buffer, where appropriate.
4209 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4210 to avoid deleted windows. Use contents slot instead of buffer.
4211 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4212 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4213 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4214 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4215
121ab1cd
EZ
42162013-03-28 Eli Zaretskii <eliz@gnu.org>
4217
ef454cf7
EZ
4218 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4219 identify the reasons for assertion violations in bug#14062 and
4220 similar ones.
21e930f8
EZ
4221 (Fx_show_tip): Fix compilation error under
4222 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4223
121ab1cd
EZ
4224 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4225 Reported by <rzl24ozi@gmail.com>.
4226
5c89ca24
DA
42272013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4228
4229 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4230 start marker...
562c6ee9
SM
4231 (unwind_with_echo_area_buffer): ...to restore it here.
4232 This is needed to ensure that...
5c89ca24
DA
4233 (redisplay_window): ...both window markers are valid here,
4234 which is verified by eassert.
4235 * editfns.c (save_excursion_save): Do not assume that
4236 selected_window always displays the buffer.
c7f53895
DA
4237 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4238 Fix comment.
5c89ca24 4239
f557c1b1
SM
42402013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4241
4242 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4243 the upcase table.
4244
40693bba 42452013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4246
4247 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4248
c86f791f
EZ
42492013-03-27 Eli Zaretskii <eliz@gnu.org>
4250
4251 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4252 since MinGW's w32api headers do. This avoids compiler warnings.
4253
4254 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4255 if already defined.
4256
c6e72e17
EZ
42572013-03-26 Eli Zaretskii <eliz@gnu.org>
4258
4259 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4260
54e95010
JD
42612013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4262
4263 * gtkutil.c (style_changed_cb): Check if frame is live and an
4264 X frame (Bug#14038).
4265
b88b62de
EZ
42662013-03-26 Eli Zaretskii <eliz@gnu.org>
4267
a18d7de6
EZ
4268 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4269 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4270 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4271 MinGW64.
8f5e14c8
EZ
4272 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4273 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4274
b88b62de
EZ
4275 Fix incompatibilities between MinGW.org and MinGW64 headers.
4276 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4277
4278 * w32.c (REPARSE_DATA_BUFFER): Guard with
4279 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4280
c074e458
JD
42812013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4282
4283 * xterm.c: Include X11/XKBlib.h
4284 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4285
908589fd
AS
42862013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4287
4288 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4289 written backwards.
4290 * blockinput.h (input_blocked_p): Likewise.
4291 * bytecode.c (exec_byte_code): Likewise.
4292 * callproc.c (call_process_kill, call_process_cleanup)
4293 (Fcall_process): Likewise.
4294 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4295 (Fccl_execute_on_string): Likewise.
4296 * character.c (string_escape_byte8): Likewise.
4297 * charset.c (read_hex): Likewise.
4298 * cm.c (calccost): Likewise.
4299 * data.c (cons_to_unsigned): Likewise.
4300 * dired.c (directory_files_internal, file_name_completion):
4301 Likewise.
4302 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4303 (sit_for): Likewise.
4304 * doc.c (Fsubstitute_command_keys): Likewise.
4305 * doprnt.c (doprnt): Likewise.
4306 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4307 * emacsgtkfixed.c: Likewise.
4308 * fileio.c (file_offset, Fwrite_region): Likewise.
4309 * floatfns.c (Fexpt, fmod_float): Likewise.
4310 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4311 Likewise.
4312 * font.c (font_intern_prop): Likewise.
4313 * frame.c (x_set_alpha): Likewise.
4314 * gtkutil.c (get_utf8_string): Likewise.
4315 * indent.c (check_display_width): Likewise.
4316 * intervals.c (create_root_interval, rotate_right, rotate_left)
4317 (split_interval_right, split_interval_left)
4318 (adjust_intervals_for_insertion, delete_node)
4319 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4320 (merge_interval_right, merge_interval_left, copy_intervals)
4321 (set_intervals_multibyte_1): Likewise.
4322 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4323 * keymap.c (Fkey_description): Likewise.
4324 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4325 * lread.c (openp, read_integer, read1, string_to_number):
4326 Likewise.
4327 * menu.c (ensure_menu_items): Likewise.
4328 * minibuf.c (read_minibuf_noninteractive): Likewise.
4329 * print.c (printchar, strout): Likewise.
4330 * process.c (create_process, Faccept_process_output)
4331 (wait_reading_process_output, read_process_output, send_process)
4332 (wait_reading_process_output): Likewise.
4333 * profiler.c (make_log, handle_profiler_signal): Likewise.
4334 * regex.c (re_exec): Likewise.
4335 * regex.h: Likewise.
4336 * search.c (looking_at_1, Freplace_match): Likewise.
4337 * sysdep.c (get_child_status, procfs_ttyname)
4338 (procfs_get_total_memory): Likewise.
4339 * systime.h (EMACS_TIME_VALID_P): Likewise.
4340 * term.c (dissociate_if_controlling_tty): Likewise.
4341 * window.c (get_phys_cursor_glyph): Likewise.
4342 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4343 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4344 Likewise.
4345 * xfns.c (Fx_window_property): Likewise.
4346 * xmenu.c (set_frame_menubar): Likewise.
4347 * xselect.c (x_get_window_property, x_handle_dnd_message):
4348 Likewise.
4349 * xsmfns.c (smc_save_yourself_CB): Likewise.
4350 * xterm.c (x_scroll_bar_set_handle): Likewise.
4351
2bf7d27a
DA
43522013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4353
4354 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4355 to be optional or nil. Adjust comment and convert it to docstring.
4356 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4357 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4358
a9ebfa0b
PE
43592013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4360
4361 Static checking by GCC 4.8-20130319.
4362 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4363 * process.c (Fset_process_datagram_address)
4364 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4365 * xdisp.c (get_char_face_and_encoding):
4366 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4367 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4368 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4369
4f3576ee
KB
43702013-03-24 Ken Brown <kbrown@cornell.edu>
4371
789b5e9a
KB
4372 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4373 fix compilation on 64-bit Cygwin, where underscores are not
4374 automatically prepended.
4375
4f3576ee
KB
4376 * w32term.c (w32_initialize): Silence compiler warning.
4377
b5b7745f
EZ
43782013-03-23 Eli Zaretskii <eliz@gnu.org>
4379
cdc0d0bd
EZ
4380 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4381 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4382 variables, to save and restore frame dimensions.
4383 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4384 after returning from a 'fullscreen' configuration.
4385 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4386 to avoid races between the main thread and the input thread.
4387
4388 * w32term.h (struct w32_output): New members normal_width,
4389 normal_height, normal_top, normal_left, and prev_fsmode.
4390 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4391 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4392 members of a frame.
4393
b5b7745f
EZ
4394 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4395 'fullscreen' parameter. Always record previous width and height
4396 of the frame, except when switching out of maximized modes, so
4397 that they could be restored correctly, instead of resetting to the
4398 default frame dimensions. Send SC_RESTORE command to the frame,
4399 unless we are going to send SC_MAXIMIZE, to restore the frame
4400 resize hints in the mouse pointer shown by the window manager.
4401 (Bug#14032)
4402
4403 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4404
4405 * lisp.h (get_frame_param): Adjust conditions for prototype
4406 declaration.
4407
a3454eed
KB
44082013-03-22 Ken Brown <kbrown@cornell.edu>
4409
4410 * unexcw.c: Drop unneeded inclusion of w32common.h.
4411 (report_sheap_usage): Declare.
4412 (read_exe_header): Add magic numbers for x86_64.
4413 (fixup_executable): Fix printf format specifier for unsigned long
4414 argument.
4415
5a49b79c
DA
44162013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4417
4418 * frame.h (struct frame): Put menu_bar_window under #ifdef
4419 because this member is not needed when X toolkit is in use.
4420 (fset_menu_bar_window):
4421 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4422 (free_glyphs, update_frame):
4423 * xdisp.c (expose_frame): Likewise.
4424 (display_menu_bar): Likewise. Remove redundant eassert.
4425 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4426 toolkit is in use.
4427
d6723bf7
PE
44282013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4429
7b1123d8
PE
4430 Use functions and constants to manipulate Lisp_Save_Value objects.
4431 This replaces code that used macros and strings and token-pasting.
4432 The change makes the C source a bit easier to follow,
4433 and shrinks the Emacs executable a bit.
4434 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4435 (make_save_value): Change 1st arg from string to enum. All callers
4436 changed.
4437 (INTX): Remove.
4438 (mark_object): Use if, not #if, for GC_MARK_STACK.
4439 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4440 (XSAVE_OBJECT): Now functions, not macros.
4441 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4442 the constant was never used.
4443 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4444 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4445 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4446 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4447 New constants.
4448 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4449 type3 with a single member save_type. All uses changed.
4450 (save_type, set_save_pointer, set_save_integer): New functions.
4451 * print.c (PRINTX): Remove.
4452
d6723bf7
PE
4453 * alloc.c: Remove redundant static declarations.
4454
5f24fa51
DA
44552013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4456
4457 * window.h (struct window): Convert left_col, top_line, total_lines
4458 and total_cols from Lisp_Objects to integers. Adjust comments.
4459 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4460 Remove.
4461 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4462 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4463 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4464 Adjust users where appropriate.
4465
42143acd
DA
44662013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4467
4468 * frame.h (struct frame): Drop resx and resy because the same data is
4469 available from window system-specific output context. Adjust users.
562c6ee9
SM
4470 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4471 New functions to provide defaults when no window system available.
42143acd 4472 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4473 (NUMVAL): Move from xdisp.c.
42143acd
DA
4474 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4475 (Ffont_face_attributes, Fopen_font):
4476 * image.c (gs_load):
4477 * w32font.c (fill_in_logfont):
4478 * xdisp.c (calc_pixel_width_or_height):
4479 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4480 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4481
c0a17406
KH
44822013-03-20 Kenichi Handa <handa@gnu.org>
4483
4484 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4485 to 1 (temporary workaround until a bug related to ASCII
4486 optimization is fixed).
4487
095d384d
DA
44882013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4489
4490 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4491 Signal error if window is not internal. Adjust docstring.
4492 (delete_all_child_windows): Use combination_limit to save the buffer.
4493 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4494 * print.c (syms_of_print): Initialize debugging output not here...
4495 (init_print_once): ...but in a new function here.
4496 * lisp.h (init_print_once): Add prototype.
4497 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4498
748fa866
DA
44992013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4500
4501 * window.c (window_resize_check, window_resize_apply)
4502 (window_from_coordinates, recombine_windows, set_window_buffer)
4503 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4504 (Fsplit_window_internal, Fdelete_window_internal)
4505 (freeze_window_starts): Use bool for booleans.
4506 * window.h (window_frame_coordinates, resize_frame_windows)
4507 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4508
81519fd2
SM
45092013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4510
4511 * dispnew.c (bitch_at_user): Use `user-error'.
4512
6db423a9
KB
45132013-03-17 Ken Brown <kbrown@cornell.edu>
4514
4515 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4516 as return type of image_background. (Bug#13981)
4517 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4518
8f2906f5
JD
45192013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4520
960ce480 4521 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4522 (ns_select): Don't return with result uninitialized.
960ce480 4523
8f2906f5
JD
4524 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4525 and getDirectory.
4526
81519fd2
SM
4527 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4528 New functions.
8f2906f5
JD
4529 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4530 directories. If filename is nil, get directory name (Bug#13932).
4531 Use getFilename and getDirectory.
4532 (getFilename, getDirectory): New methods for EmacsSavePanel and
4533 EmacsOpenPanel.
4534 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4535
cded56c1
PE
45362013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4539
251e9147 45402013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4541
4542 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4543 (adjust_after_replace): Make it back to static. Delete the third
4544 arg text_at_gap_tail. Cancel the code for handling it.
4545
4546 * coding.h (struct coding_system): New member eol_seen.
4547
4548 * coding.c (detect_ascii): New function.
4549 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4550 when the source bytes are actually scanned. On detecting for
4551 coding_category_utf_8_auto, call detect_ascii instead of scanning
4552 source bytes directly.
4553 (produce_chars): Call insert_from_gap with the new arg 0.
4554 (encode_coding): Likewise.
4555 (decode_coding_gap): Control ASCII optimization by the variable
4556 disable_ascii_optimization instead of #ifndef .. #endif.
4557 Deccode EOL format according to coding->eol_seen.
4558 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4559 variable.
4560
8a44e6d1
KH
4561 * lisp.h (adjust_after_replace): Cancel externing it.
4562 (insert_from_gap): Adjust prototype.
4563
5f795e34
EZ
45642013-03-15 Eli Zaretskii <eliz@gnu.org>
4565
4566 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4567 FULLSCREEN_MAXIMIZED. (Bug#13935)
4568
f258b4be
DA
45692013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4570
4571 * region-cache.c (find_cache_boundary, move_cache_gap)
4572 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4573 Simplify debugging check and convert to eassert. Adjust comment.
4574 (pp_cache): Put under ENABLE_CHECKING.
4575
a5cc4dde
EZ
45762013-03-14 Eli Zaretskii <eliz@gnu.org>
4577
4578 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4579 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4580 and WM_ACTIVATEAPP.
4581 (w32fullscreen_hook): If the frame is visible, reset
4582 f->want_fullscreen flag after changing the frame size. If the
4583 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4584 (Bug#13953)
4585
3fc5e44a
DC
45862013-03-13 Daniel Colascione <dancol@dancol.org>
4587
4588 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4589 too so that these builds can use Cygwin's file conversion
4590 functions. (We've been building and linking cygw32.o all along
4591 and just not using it.)
4592
47d7532e
PE
45932013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4594
4595 File synchronization fixes (Bug#13944).
4596 * Makefile.in (LIB_FDATASYNC): New macro.
4597 (LIBES): Use it.
4598 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4599 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4600 Don't worry about HAVE_FSYNC, since a substitute fsync is
4601 available if the system lacks one.
4602 (Fwrite_regin): Retry fsync if interrupted.
4603
c7ffccaf
EZ
46042013-03-13 Eli Zaretskii <eliz@gnu.org>
4605
4e2df81d 4606 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4607 activated, call w32fullscreen_hook, to make sure the new frame
4608 dimensions are in effect. (Bug#13937)
4609
8a7debc1
DA
46102013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4611
4612 * xdisp.c (init_iterator): Simplify because both character and byte
4613 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4614 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4615 character and byte positions can be obtained from marker.
8a7debc1 4616
7fd8c501
PE
46172013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4618
d9df6f40
PE
4619 Static checking by Sun C 5.12.
4620 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4621 * bytecode.c (exec_byte_code):
4622 * dispnew.c (init_display):
4623 * eval.c (error):
4624 * fileio.c (Fsubstitute_in_file_name):
4625 * keyboard.c (Fevent_convert_list):
4626 * keymap.c (Fsingle_key_description):
4627 * term.c (maybe_fatal, fatal):
4628 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4629 * xsmfns.c (Fhandle_save_session):
4630 Omit unreachable code.
4631 * keymap.c (map_keymap_char_table_item): Cast void * to
4632 a function pointer type; the C Standard requires this.
4633
7fd8c501
PE
4634 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4635 Include <sys/param.h> unconditionally, as that works elsewhere and
4636 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4637 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4638 and FreeBSD now.
4639
a020afb9 4640See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4641
4642;; Local Variables:
4643;; coding: utf-8
aac0c6e3
MR
4644;; End:
4645
ab422c4d 4646 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4647
4648 This file is part of GNU Emacs.
4649
4650 GNU Emacs is free software: you can redistribute it and/or modify
4651 it under the terms of the GNU General Public License as published by
4652 the Free Software Foundation, either version 3 of the License, or
4653 (at your option) any later version.
4654
4655 GNU Emacs is distributed in the hope that it will be useful,
4656 but WITHOUT ANY WARRANTY; without even the implied warranty of
4657 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4658 GNU General Public License for more details.
4659
4660 You should have received a copy of the GNU General Public License
4661 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.