Fix infinite frame selection loop (Bug#15025).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
42fe2e88
DA
12013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Fix infinite frame selection loop (Bug#15025).
4 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
5
d39a3da6
EZ
62013-08-15 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (compute_window_start_on_continuation_line): When
9 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
10 to make sure we end up setting the window start at the leftmost
11 visible character of the display line. This avoids funky
12 horizontal shifting because the window start is not kept on the
13 same position. (Bug#15090)
05426239
EZ
14 (next_element_from_display_vector): Support 'box' face attribute
15 in the face definitions of a display vector. (Bug#15099)
d39a3da6 16
6e856b69
LMI
172013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
18
19 * image.c (imagemagick_compute_animated_image): Implement animated
20 images (bug#14700).
21
d5a1acfa
DA
222013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
23
24 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
25 to do `for' loops over alist values.
26 * buffer.h (FOR_EACH_BUFFER):
27 * process.c (FOR_EACH_PROCESS): Use it.
28 (handle_child_signal, status_notify, Fget_buffer_process)
29 (kill_buffer_processes): Use FOR_EACH_PROCESS.
30
9c253307
DA
312013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
32
33 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
34 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
35 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
36 to xzalloc and so avoid redundant call to memset.
37 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
38 members because it is allocated with xzalloc and so already zeroed.
39
05e64f9f
KB
402013-08-14 Ken Brown <kbrown@cornell.edu>
41
42 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
43 (Bug#15094).
44
5b71542d
DA
452013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
46
47 Utility function and macro to copy Lisp string to C string.
48 * lisp.h (xlispstrdupa): New macro.
49 (xlispstrdup): New prototype.
50 * alloc.c (xlispstrdup): New function.
51 * callint.c (Fcall_interactively):
52 * fileio.c (Ffile_name_directory, Fexpand_file_name)
53 (Fsubstitute_in_file_name):
54 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
55 * image.c (x_create_bitmap_from_file):
56 * w32term.c (w32_term_init):
57 * xterm.c (x_term_init): Use xlispstrdup.
58
71530c97
LMI
592013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
60
4ce82fb8
LMI
61 * image.c (imagemagick_load_image): Make animated pictures work.
62 There's still some problems with background color settings, though
63 (bug#14700).
64
71530c97
LMI
65 * decompress.c (unwind_decompress): Always restore point.
66
7510a061
XF
672013-08-14 Xue Fuqiao <xfq.free@gmail.com>
68
69 * marker.c (set_marker): Reformat documentation.
70
01c3051f
PE
712013-08-14 Paul Eggert <eggert@cs.ucla.edu>
72
aab1fcdf
PE
73 * xdisp.c (cursor_type_changed): Now static.
74
01c3051f
PE
75 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
76 Use changed. This avoids the need to call xmalloc and for the
77 caller to call xfree, and avoids memory leaks in some situations.
78
2084152a
DA
792013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
80
81 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
82 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
83 (redisplay_window): If window_end_valid is cleared due to non-zero
84 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
85 so do not call to try_cursor_movement for that window.
2084152a 86
02455cb6
DA
872013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
88
89 * window.h (struct window): Convert window_end_pos and
90 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
91 (wset_window_end_pos, wset_window_end_vpos): Remove.
92 * dispnew.c (adjust_glyph_matrix):
93 * window.c (Fwindow_end, replace_window, set_window_buffer)
94 (make_window):
95 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
96 (set_vertical_scroll_bar, redisplay_window, try_window)
97 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
98 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
99 (note_mouse_highlight): Adjust users.
100 (try_cursor_movement): Likewise. Convert old precondition to eassert.
101 Add comment.
102
da5707e8
DA
1032013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
104
105 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
106 * image.c (imagemagick_filename_hint): Use `const char *' and
107 prefer SSDATA to SDATA to avoid warnings.
108
25554267
DA
1092013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Cleanup window fringes, margins and scroll bars adjustments.
112 * window.c (set_window_fringes, set_window_margins)
113 (set_window_scroll_bars, apply_window_adjustment): New functions.
114 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
115 (Fset_window_scroll_bars): Use them.
116
38a2c910
DA
1172013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
118
119 * window.h (struct window): Convert scroll_bar_width
120 from Lisp_Object to integer. Adjust comment.
121 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
122 Adjust users.
123 * window.c (wset_scroll_bar_width): Remove.
124 (make_window): Initialize scroll_bar_width.
125 (Fsplit_window_internal): Use direct assignment.
126 (Fset_window_configuration, save_window_save):
127 Convert Lisp_Object to integer and back where appropriate.
128 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
129 bar was actually changed, and mention this in docstring.
130
2d065031
PE
1312013-08-13 Paul Eggert <eggert@cs.ucla.edu>
132
133 * decompress.c: Minor simplifications.
134 (Fzlib_decompress_region): Don't bother verifying
135 that avail_out <= UINT_MAX, as that was confusing.
136 Mention the restriction in a comment instead.
137 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
138
a5bd5abb
JD
1392013-08-13 Jan Djärv <jan.h.d@swipnet.se>
140
141 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
142 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
143
66e7901a
LMI
1442013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
145
146 * image.c (imagemagick_filename_hint): Check for errors in the
147 alist structure.
148
2fa611b7
EZ
1492013-08-13 Eli Zaretskii <eliz@gnu.org>
150
151 * window.c (Fwindow_margins): Return nil when there's no marginal
152 area, as per the documented API.
153
154 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
155 Fmake_vector, as scroll bar's struct members are not all Lisp
156 objects now. This avoids crashes in GC.
157
158 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
159 bool, so its address could be taken.
160
8259030d
LMI
1612013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
162
163 * image.c (imagemagick_filename_hint): New function to possibly
164 apply `image-content-type-suffixes'.
165 (imagemagick_load_image): Use it.
166
866c710e
EZ
1672013-08-13 Eli Zaretskii <eliz@gnu.org>
168
169 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
170 if loading zlib failed.
171
f10490f0
JD
1722013-08-13 Jan Djärv <jan.h.d@swipnet.se>
173
96311be7
JD
174 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
175 2013-08-13 checkin below. Change bool to BOOL, rule is:
176 All Obj-C code uses BOOL, except for interfaces callable from C.
177
f10490f0
JD
178 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
179
c8ae93b0
DA
1802013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
181
182 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
183 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
184 bool instead of BOOL.
185 * w32term.h (struct scroll_bar): Convert fringe_extended_p
186 from Lisp_Object to bitfield. Adjust comment.
187 * w32term.c (x_scroll_bar_create): Adjust user.
188 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
189 * xterm.c (XTset_vertical_scroll_bar): Likewise.
190 Use bool for boolean.
191 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
192 to `unsigned int' when defining a bitfield.
193
53b64418
PE
1942013-08-13 Paul Eggert <eggert@cs.ucla.edu>
195
196 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
197
eeaf9bf3
DA
1982013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
199
200 * window.h (struct window): Convert left_margin_cols and
201 right_margin_cols from Lisp_Objects to integers. Adjust comment.
202 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
203 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
204 Adjust users.
205 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
206 Adjust comment.
207 (showing_window_margins_p, update_window_line, update_frame_1):
208 * fringe.c (draw_fringe_bitmap_1):
209 * xdisp.c (window_box_width): Adjust users.
210 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
211 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
212 Use direct assignment.
213 (Fset_window_configuration, save_window_save, Fwindow_margins):
214 Convert Lisp_Object to integer and back where appropriate.
215 (Fset_window_margins): Adjust user. Return t if any margin
216 was actually changed, and mention this in docstring.
217
956720af
XF
2182013-08-13 Xue Fuqiao <xfq.free@gmail.com>
219
f73f4ce6 220 * syntax.c (forward_word):
956720af
XF
221 * cmds.c (forward_char, backward_char): Mention the optional argument.
222
9e37ee3b
DA
2232013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
224
225 * window.h (struct window): Convert left_fringe_width
226 and right_fringe_width from Lisp_Objects to integers.
227 Adjust comment.
228 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
229 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
230 * window.c (wset_left_fringe_width, wset_right_fringe_width):
231 Remove.
232 (make_window): Initialize new integer fields to -1.
233 (Fsplit_window_internal): Use direct assignment.
234 (Fset_window_configuration, save_window_save): Convert
235 Lisp_Object to integer and back where appropriate.
236 (Fset_window_fringes): Adjust user. Return t if any fringe
237 was actually changed, and mention this in docstring.
238
e4375ca7
DA
2392013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
240
241 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
242 * nsfns.m (x_set_cursor_type):
243 * w32fns.c (x_set_cursor_type):
244 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
245 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 246
a45543bc
DA
2472013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
248
249 * font.c (clear_font_cache): New function, stripped from...
250 (Fclear_font_cache): ...here, which now uses the function
251 above. Adjust comment.
252 * font.h (clear_font_cache): Add prototype.
253 * xfaces.c (clear_face_cache): Use clear_font_cache.
254
ae966a86
DA
2552013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
256
257 * window.c (Fset_window_start): Compare `w', not `window' because
258 `w' might not be equal to `window' after call to decode_live_window.
259
297a545b
PE
2602013-08-12 Paul Eggert <eggert@cs.ucla.edu>
261
262 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
263 This fixes a problem introduced by the Bug#15035 patch
264 when using GPG. Reported by Herbert J. Skuhra.
265
aa942e2b
EZ
2662013-08-12 Eli Zaretskii <eliz@gnu.org>
267
268 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
269 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
270 not yet initialized.
271
7699d09e
LMI
2722013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
273
274 * decompress.c (Fzlib_decompress_region): Support zlib
275 decompression, too, and rename.
276
1d238bc7
PE
2772013-08-12 Paul Eggert <eggert@cs.ucla.edu>
278
279 Minor zlib configuration tweaks.
280 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
281 Don't assume presence of fn_inflateInit2_ zlib internal function.
282
8a44a184
LMI
2832013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
284
285 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
286 include the zlib prefix.
287
594a4307
EZ
2882013-08-12 Eli Zaretskii <eliz@gnu.org>
289
290 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
291 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
292 define static variables that are pointers to zlib functions to be
293 dynamically loaded.
294 (init_zlib_functions) [WINDOWSNT]: New function.
295 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
296 New macros.
297 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
298 macros instead of invoking the zlib functions directly.
299 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
300 Szlib_available_p.
301
d2e113bc
DA
3022013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
303
304 Avoid looping over all frame windows to freeze and unfreeze.
305 * window.h (struct window): Drop frozen_window_start_p.
306 (freeze_window_starts): Drop prototype.
307 * frame.h (struct frame): New frozen_window_starts flag.
308 (FRAME_WINDOWS_FROZEN): New macro.
309 * window.c (freeze_window_start, freeze_window_starts):
310 Remove.
311 (select_window, replace_window): Adjust users.
312 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
313 (window_frozen_p): New function.
314 (redisplay_window): Use it.
315
94fcd171
PE
3162013-08-12 Paul Eggert <eggert@cs.ucla.edu>
317
318 Fix some fd issues when running subprocesses (Bug#15035).
319 Fix bugs that can leak files or file descriptors on errors.
320 Don't unlink open temp files, as that's hard for users to diagnose
321 when things go awry (e.g., temp disk exhausted).
322 Don't bother to lock temp files. Check for invalid recursion.
323 * callproc.c (synch_process_fd): Remove. All uses removed.
324 (synch_process_tempfile): New var or macro.
325 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
326 New constants.
327 (record_kill_process): New arg, the temp name. All callers changed.
328 (delete_temp_file): Now just a simple wrapper around unlink.
329 (call_process_kill): New arg, the call_process_fd array.
330 Close them all. Clear synch_process_pid. Remove the temp file,
331 or arrange for it to be removed.
332 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
333 that's been moved to synch_process_tempfile. Caller changed.
334 Do not remove the tempfile; that's now call_process_kill's
335 responsibility.
336 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
337 call_process_kill; the caller now does that.
338 (call_process_cleanup): Do not close the process fd; that's now
339 call_process_kill's responsibility.
340 (Fcall_process): Implement via new function call_process, which
341 has most of the old body of Fcall_process, but with a different API.
342 (call_process): New function that does not open or close filefd if
343 it is nonnegative. Record which fds need to be closed, and let
344 call_process_kill close (and remove the tempfile, on MSDOS) on error.
345 Signal an error if invoked recursively (could be done via a hook).
346 Simplify creation of the tempfile in the MSDOS case.
347 Don't create the output file until after checking for the executable.
348 Report any failure to open /dev/null.
349 Don't open /dev/null for writing twice; once is enough.
350 Don't create pipe if all output is being discarded or sent to file.
351 Don't worry about setting up the coding system or reading from the
352 pipe if all output is being discarded.
353 Hoist fd_error local into top level, to lessen block nesting.
354 Don't record deleted pid here; now done by Fcall_process_region.
355 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
356 and note its success in synch_process_tempfile.
357 Do not leak resources when child_setup fails.
358 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
359 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
360 (create_temp_file): Now returns open fd, with an additional
361 Lisp_Object * argument to return the name. All callers changed.
362 Do not close the file; rewind it instead, and leave it open for
363 the caller. Do not lock the temp file. Unwind-protect the file
364 and the file-descriptor.
365 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
366 If an asynchrounous process, record it here, not in call_process.
367 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
368 * eval.c (set_unwind_protect): New function.
369 * fileio.c (write_region): New function, generalized from the
370 old Fwrite_region. Do not lock temp files.
371 (Fwrite_region): Use it.
372 * lisp.h (set_unwind_protect, write_region): New decls.
373 * process.c: Include <verify.h>.
374 (make_process): Mark fds as initially closed.
375 (deleted_pid_list): Now a list of pid-filename pairs.
376 All uses changed.
377 (close_process_fd): New function.
378 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
379 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
380 New constants. Verify that their number matches PROCESS_OPEN_FDS.
381 (create_process, create_pty, Fmake_serial_process)
382 (server_accept_connection): Record which fds need to be closed,
383 and let deactivate_process close them.
384 (Fmake_network_process): Do not discard the unwind-protect
385 until it's safe to do so.
386 (deactivate_process): Close the fds opened by create_process etc.
387 (Fprocess_send_eof): Adjust to new way of recording open fds.
388 Report an error if /dev/null can't be opened, instead of aborting.
389 * process.h (PROCESS_OPEN_FDS): New constant.
390 (struct Lisp_Process): New member open_fds.
391 (record_kill_process, record_deleted_pid): Adjust signatures.
392 (record_deleted_pid): Move decl here ...
393 * syswait.h (record_deleted_pid): ... from here.
394
d0e615c3
PE
3952013-08-11 Paul Eggert <eggert@cs.ucla.edu>
396
397 * decompress.c: Fix bugs with large buffers and weird inputs.
398 Tune a bit. Reindent as per usual Emacs style.
399 (BUFFER_SIZE): Remove.
400 (Fdecompress_gzipped_region): Do not mishandle input buffers with
401 more than UINT_MAX bytes. Decompress into the gap instead of into
402 an auto buffer, as this should avoid copying. Return nil if
403 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
404 set immediate_quit; we shouldn't trust zlib code that much.
405
313546eb
LMI
4062013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
407
99a32242
LMI
408 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
409 errors, and really move the gap to where we want it.
410
313546eb
LMI
411 * lisp.h: Include decompress.c support.
412
413 * emacs.c (main): Include decompress.c support.
414
415 * Makefile.in: Include -lz if present.
416
d2d699ac
JD
4172013-08-11 Jan Djärv <jan.h.d@swipnet.se>
418
f90e3ebd
JD
419 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
420 (initWithTitle:): Initialize frame to 0.
421 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
422 (fillWithWidgetValue:frame:): Renamed from
423 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
424
425 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
426 fillWithWidgetValue:frame:
427
423d3b3f
JD
428 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
429 remove memory leak warnings.
430
d2d699ac
JD
431 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
432 (ns_check_menu_open): Handle menu == nil. Remove assignment to
433 menu_pending_title.
434
435 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
436 (x_activate_menubar): Update the whole menu.
437 (trackingNotification:): Call ns_check_menu_open if tracking ends.
438 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
439 current event is not NSSystemDefined (Bug#15001).
440 Call ns_check_menu_open only if trackingMenu is 2.
441 (menuDidClose:): New method, decrease trackingMenu.
442 (fillWithWidgetValue:setDelegate:): New method.
443 (fillWithWidgetValue:): Call the above.
444
445 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
446
7d652d97
PE
4472013-08-11 Paul Eggert <eggert@cs.ucla.edu>
448
449 Omit some unnecessary casts.
450 Many of these go back to the old pre-C89 days, when they may have
451 been needed, but we've been assuming C89 or later for a while now.
452 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
453 (live_float_p, live_misc_p, live_vector_p):
454 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
455 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
456 (defvar_per_buffer):
457 * callint.c (Fcall_interactively):
458 * doc.c (Fsubstitute_command_keys):
459 * filelock.c (get_boot_time):
460 * frame.c (xrdb_get_resource):
461 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
462 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
463 (xg_get_file_name_from_selector, menuitem_destroy_callback)
464 (menuitem_highlight_callback, menu_destroy_callback)
465 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
466 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
467 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
468 (xg_tool_bar_help_callback, tb_size_cb):
469 * image.c (xpm_alloc_color, png_read_from_memory)
470 (png_read_from_file, png_load_body, our_memory_skip_input_data)
471 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
472 (syms_of_image):
473 * keymap.c (describe_map):
474 * nsfns.m (Fns_display_monitor_attributes_list):
475 * nsmenu.m (process_dialog:):
476 * nsterm.m (hold_event):
477 * process.c (wait_reading_process_output):
478 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
479 * scroll.c (do_direct_scrolling, scrolling_1):
480 * termcap.c (tgetent):
481 * window.c (check_window_containing, add_window_to_list)
482 (freeze_window_starts):
483 * xdisp.c (compare_overlay_entries, vmessage):
484 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
485 (x_get_monitor_attributes_xrandr)
486 (Fx_display_monitor_attributes_list, x_display_info_for_name)
487 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
488 * xfont.c (xfont_match, xfont_open):
489 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
490 (menubar_selection_callback, menu_position_func)
491 (popup_selection_callback, create_and_show_popup_menu)
492 (dialog_selection_callback, create_and_show_dialog):
493 * xrdb.c (x_get_string_resource):
494 (main) [TESTRM]:
495 * xsmfns.c (x_session_check_input):
496 * xterm.c (x_draw_glyphless_glyph_string_foreground)
497 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
498 (xaw_jump_callback, xaw_scroll_callback):
499 Omit unnecessary casts.
500
9acc1074
PE
5012013-08-10 Paul Eggert <eggert@cs.ucla.edu>
502
503 Minor string-length refactoring.
504 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
505 * frame.c (make_monitor_attribute_list):
506 Prefer build_string to strlen + make_string.
507
361c0eb8
JD
5082013-08-10 Jan Djärv <jan.h.d@swipnet.se>
509
510 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
511 don't check minor_code (Bug#14417).
512
14ba0822
EZ
5132013-08-09 Eli Zaretskii <eliz@gnu.org>
514
515 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
516 vertical positions instead. This avoids calling MATRIX_ROW with
517 row numbers that are possibly beyond valid limits. (Bug#15064)
518
309f24d1
DA
5192013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
520
521 Use xstrdup and build_unibyte_string where applicable.
522 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
523 * xfns.c (x_window):
524 * xrdb.c (x_get_customization_string):
525 * xterm.c (xim_initialize):
526 * w32fns.c (w32_window): Use xstrdup.
527 (w32_display_monitor_attributes_list):
528 * emacs.c (init_cmdargs):
529 * keyboard.c (PUSH_C_STR):
530 * nsfont.m (nsfont_open):
531 * sysdep.c (system_process_attributes):
532 * w32.c (system_process_attributes):
533 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
534
55902276
EZ
5352013-08-09 Eli Zaretskii <eliz@gnu.org>
536
537 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
538 variables of these types so that GDB would know about them, as aid
539 for debugging fatal exceptions. (Bug#15024) See also
540 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
541 discussions.
542
10bf7f5a
JD
5432013-08-08 Jan Djärv <jan.h.d@swipnet.se>
544
545 * nsterm.m (ns_update_begin): Don't change clip path if it would be
546 larger than the NSWindow (Bug#14934).
547
65620264
DA
5482013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
549
550 Redesign redisplay interface to drop global variable updated_window.
551 Always pass currently updated window as a parameter to update routines.
552 * dispextern.h (updated_window): Remove declaration.
553 (struct redisplay_interface): Pass window parameter to
554 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
555 and after_update_window_hook.
556 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
557 Adjust prototypes.
558 * dispnew.c (updated_window): Remove.
559 (redraw_overlapped_rows, update_marginal_area, update_text_area)
560 (update_window_line): Adjust to match redisplay interface changes.
561 * nsterm.m (ns_update_window_begin, ns_update_window_end)
562 (ns_scroll_run, ns_after_update_window_line):
563 * w32term.c (x_update_window_begin, x_update_window_end)
564 (x_after_update_window_line, x_scroll_run):
565 * xterm.c (x_update_window_begin, x_update_window_end)
566 (x_after_update_window_line, x_scroll_run):
567 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
568 Likewise. Adjust comments where appropriate.
569 (x_cursor_to): Simplify because this is always called during window
570 update (but install debugging check anyway).
571 (expose_window): Check must_be_updated_p flag to see whether this
572 function is called during window update.
573
628fdc56
DA
5742013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
575
576 Do not reset window modification event counters excessively.
577 These leftovers and poor man's tricky methods to catch extra
578 redisplay's attention are no longer needed.
579 * frame.c (set_menu_bar_lines_1):
580 * minibuf.c (read_minibuf_unwind):
581 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
582 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
583 (window_scroll_line_based, Fset_window_configuration):
584 * xdisp.c (redisplay_window): Do not reset last_modified and
585 last_overlay_modified counters.
586
8fd9c92e
JD
5872013-08-07 Jan Djärv <jan.h.d@swipnet.se>
588
589 * xselect.c (x_send_client_event): Set send_event and serial, memset
590 data.l as it might be bigger than data.b. Use 24 bit mask to
591 XSendEvent (Bug#15034).
592
0ee18172
EZ
5932013-08-07 Eli Zaretskii <eliz@gnu.org>
594
595 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
596 for TTY frames that are not the top frame on their console.
597 (Bug#14616)
598
16ddd1a6
MR
5992013-08-07 Martin Rudalics <rudalics@gmx.at>
600
601 * w32term.c (w32fullscreen_hook): Really maximize frame when
602 asked for (Bug#14841).
603
d2a95ffb
DA
6042013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
605
606 Prefer selected_window to Fselected_window, likewise for frames.
607 * buffer.c (Fbuffer_swap_text):
608 * data.c (Fvariable_binding_locus):
609 * window.c (run_window_configuration_change_hook): Adjust users.
610 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
611 Use decode_live_frame.
612
170da1ec
DA
6132013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
614
615 Be more careful if selected window shows the buffer other than current,
616 use window_outdated only if this is not so. This change should also
617 address some weird issues discussed in Bug#13012.
618 * window.h (window_outdated): New prototype.
619 * window.c (window_outdated): Now here. Convert from static and
620 always assume window's buffer.
621 (Fwindow_end, Fwindow_line_height): Use it.
622 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
623 and always assume window's buffer.
624 (redisplay_window): Adjust user.
e5eefe9b 625 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
626 check whether mode line should be updated only if selected window
627 shows current buffer.
628 (run_window_scroll_functions): Use eassert for debugging check.
629 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
630
56b5d5b1
DA
6312013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
632
633 * window.c (window_scroll, window_scroll_pixel_based)
634 (window_scroll_line_based): Use bool for booleans.
635
2878ba7e
PE
6362013-08-06 Paul Eggert <eggert@cs.ucla.edu>
637
638 * process.c: Fix minor off-by-one issues in descriptor counts.
639 This shouldn't fix any real bugs, but it cleans up the code a bit.
640 (max_process_desc, max_input_desc): -1, not 0, means none.
641 All uses changed.
642 (delete_input_desc): New function.
643 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
644 (deactivate_process): Scan backwards when recomuting max_process_desc;
645 that should be faster.
646 (init_process_emacs): Initialize max_input_desc.
647
e30b79c1
DA
6482013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
649
650 Use region cache to speedup bidi_find_paragraph_start.
651 * buffer.h (struct buffer): New member bidi_paragraph_cache.
652 Rename cache_long_line_scans to cache_long_scans.
653 * buffer.c (bset_cache_long_line_scans): Rename to
654 bset_cache_long_scans.
655 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
656 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
657 into account.
658 (syms_of_buffer): Rename cache-long-line-scans to
659 cache-long-scans. Adjust docstring.
660 * search.c (newline_cache_on_off):
661 * indent.c (width_run_cache_on_off): Adjust users.
662 * bidi.c (bidi_paragraph_cache_on_off): New function.
663 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
664 * insdel.c (prepare_to_modify_buffer): Invalidate
665 bidi_paragraph_cache if enabled.
666
00012b86
DA
6672013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
668
669 Invalidate region caches only if buffer text is going to be changed.
670 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
671 (modify_text): ...new prototype.
672 (prepare_to_modify_buffer_1): New prototype.
673 * textprop.c (modify_region): Rename to...
674 (modify_text_properties): ...new function.
675 (add_text_properties_1, set_text_properties, Fremove_text_properties)
676 (Fremove_list_of_text_properties): Adjust users.
677 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
678 (modify_text): ...new function.
679 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
680 (prepare_to_modify_buffer_1): ...new function.
681 * casefiddle.c (casify_region):
682 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
683 (Ftranspose_regions): Use modify_text.
684
dc6c0eda
SM
6852013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
686
687 * lisp.mk (lisp): Add nadvice.elc.
688
8f3a2c26
DA
6892013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
690
691 New macro to iterate over live buffers similar to frames.
692 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
693 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
694 Declare buffer-related variables here to offload lisp.h.
695 * buffer.c (Vbuffer_alist): Adjust comment.
696 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
697 (other_buffer_safely):
698 * data.c (store_symval_forwarding):
699 * dispnew.c (Fframe_or_buffer_changed_p):
700 * fileio.c (Fdo_auto_save):
701 * filelock.c (unlock_all_files):
702 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
703
e0fdb694
PE
7042013-08-04 Paul Eggert <eggert@cs.ucla.edu>
705
706 Fix some minor races in hosts lacking mkostemp (Bug#15015).
707 * callproc.c (create_temp_file):
708 * filelock.c (create_lock_file):
709 Assume mkostemp, since it's now provided by Gnulib.
710
63f5c6c2
EZ
7112013-08-04 Eli Zaretskii <eliz@gnu.org>
712
713 * w32.c (mkostemp): New function.
714 (mktemp): Remove, no longer used. Most of the code reused in
715 mkostemp. (Bug#15015)
484ab239 716 (mktemp): Don't undef.
63f5c6c2 717
f0b79313
DA
7182013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
719
720 * dispnew.c (glyph_matrix_count, glyph_pool_count):
721 Move under GLYPH_DEBUG and ENABLE_CHECKING.
722 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
723 (free_glyph_pool, check_glyph_memory): Likewise for
724 all users. Adjust comments where appropriate.
725
98f638d6
PE
7262013-08-03 Paul Eggert <eggert@cs.ucla.edu>
727
728 * composite.h: Minor fixups.
729 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
730 to fix a misspelling, and change it to an inline function while
731 we're at it (it need not be a macro). All uses changed.
732 (composition_method, composition_valid_p):
733 Rewrite to avoid assignments in if-conditions.
734
75c59fb3
DA
7352013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
736
737 Do not use global Lisp_Object in composition macros.
738 * composite.h (composition_temp): Remove declaration.
739 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
740 (composition_method, composition_valid_p): ...inline functions.
416a3e01 741 (compose_region): Remove the leftover.
75c59fb3
DA
742 * composite.c (composition_temp): Remove.
743 (run_composition_function, update_compositions)
744 (composition_compute_stop_pos, composition_adjust_point)
745 (Ffind_composition_internal):
746 * coding.c (handle_composition_annotation):
747 * xdisp.c (handle_composition_prop, check_point_in_composition):
748 Related users changed.
749
a10c8269
DA
7502013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
751
752 Drop FRAME_PTR typedef.
753 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
754 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
755 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
756 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
757 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
758 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
759 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
760 All related users changed.
761
a104f656
SM
7622013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
763
764 * eval.c (default_toplevel_binding): New function.
765 (Fdefvar): Use it.
766 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
767 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
768 (syms_of_eval): Export them.
769 * data.c (Fdefault_value): Micro cleanup.
770 * term.c (init_tty): Use "false".
771
4b5c9326
DA
7722013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
773
774 Fix X GC leak in GTK and raw (no toolkit) X ports.
775 * xterm.c (x_free_frame_resources): If white and black relief
776 GCs are allocated, always free them here.
777 * xfns.c (x_make_gc): Omit redundant initialization.
778 * widget.c (create_frame_gcs): Remove the leftover.
779 (EmacsFrameDestroy): Do nothing because all GCs are now freed
780 in x_free_frame_resources.
781
b19aa636
JD
7822013-08-02 Jan Djärv <jan.h.d@swipnet.se>
783
784 * nsterm.m (windowWillResize:toSize:): Only change title if
785 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
786 modifying it.
787 (viewDidEndLiveResize): New method.
788
789 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
790 inside NS_IMPL_COCOA.
791
af1f7e06
DA
7922013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
793
794 * insdel.c (adjust_after_replace, replace_range, del_range_2):
795 Do not check whether undo is enabled because record_insert and
796 record_delete does that themselves.
797
65b02bb9
DA
7982013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
799
800 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
801 member which is not really used any more.
802 (FRAME_XIC_BASE_FONTNAME): Remove.
803 * xfns.c (xic_free_fontset): Adjust user.
804 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
805 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
806 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
807 (xdialog_show): Use eassert for debugging check.
7ee0f047 808 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 809
6318cde0
PE
8102013-08-01 Paul Eggert <eggert@cs.ucla.edu>
811
812 * fileio.c, fns.c (merge): Move extern decl from here ...
813 * lisp.h (merge): ... to here.
814
6c1a09ba
DA
8152013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
816
817 Fix last font-related change.
818 * w32font.h (w32font_list_internal, w32font_match_internal):
819 Fix prototype.
820 * w32uniscribe.c (uniscribe_list, uniscribe_match):
821 (uniscribe_list_family): Adjust to match font API change.
822 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
823 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
824
f8c20208
DA
8252013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
826
827 * frame.h (FRAME_MOUSE_UPDATE):
828 * nsterm.m (ns_frame_up_to_date): Omit redundant check
829 whether hlinfo->mouse_face_mouse_frame is non-NULL.
830
fdb396e2
DA
8312013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
832
833 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
834 * font.h (struct font_driver): Change list, match, and list_family
835 functions to accept struct frame * as first arg.
836 * font.c (font_score, font_compare, font_sort_entities): Remove
837 prototypes.
838 (font_sort_entities, font_list_entities, font_select_entity):
839 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
840 match font API change.
841 * xfont.c (xfont_list, xfont_match, xfont_list_family):
842 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
843 * ftxfont.c (ftxfont_list, ftxfont_match):
844 * xftfont.c (xftfont_list, xftfont_match):
845 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
846 * w32font.c (w32font_list, w32font_match, w32font_list):
847 (w32font_list_internal, w32_font_match_internal): Likewise.
848 * xfaces.c (Fx_family_fonts): Adjust user.
849
52b8a085
DA
8502013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
851
852 Do not use pure Xism x_wm_set_icon_position in non-X ports.
853 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
854 only if HAVE_X_WINDOWS is in use.
855 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
856 * nsterm.m (x_wm_set_icon_position): Remove no-op.
857 * w32term.c (x_wm_set_icon_position): Likewise.
858 * w32fns.c (x_icon): Adjust user.
859
c791c18e
DA
8602013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
861
862 * xterm.c (last_mouse_press_frame): Remove the
863 leftover which is not really used any more.
864 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
865 (x_flush): Call XFlush once per each X display, not frame.
866 This is better because this code always unconditionally skips
867 non-X frames in Vframe_list and issues the only XFlush if we
868 have more than one X frame on the same X display.
2f935d86
DA
869 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
870 Use bool for booleans.
871 (x_draw_glyph_string_background, cvt_string_to_pixel):
872 (cvt_pixel_dtor): Drop unnecessary prototypes.
873 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 874
f435830e
DA
8752013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
876
877 Drop unnecessary functions that deals with frame pixel size.
878 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
879 (x_pixel_height): Drop prototypes.
880 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
881 (x_pixel_height): Drop implementations.
882 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
883 which should be always valid for window frame.
884 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
885 * w32menu.c (Fx_popup_dialog):
886 * xmenu.c (Fx_popup_dialog): Likewise for both.
887
84231434
DA
8882013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
889
890 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
891 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
892 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
893 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
894 and mention nil frame in docstring.
84231434 895
959067a1
DA
8962013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
897
898 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
899 (x_figure_window_size): Likewise. Adjust to return long.
900 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
901 (toplevel): Move Qterminal_live_p to...
902 * terminal.c (toplevel): ...here, make it static, and...
903 (syms_of_terminal): ...DEFSYM here.
904 * frame.h (Qterminal_live_p): Remove declaration.
905 (make_frame, x_figure_window_size): Adjust prototype.
906 * nsfns.m (Fx_create_frame): Use long for window flags.
907
f4b169ce
PE
9082013-07-30 Paul Eggert <eggert@cs.ucla.edu>
909
910 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
911 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
912 Do not assume that emacs_close (INT_MAX) is a no-op.
913
bee6a2c7
DA
9142013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
915
916 * xfaces.c (make_face_cache): For struct face_cache, prefer
917 xmalloc to xzalloc and so avoid redundant call to memset.
918 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
919
d7e6881a
DA
9202013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
921
922 * fringe.c (draw_window_fringes, update_window_fringes)
923 (compute_fringe_widths):
924 * w32term.c (x_draw_glyph_string):
925 * window.c (candidate_window_p, Frecenter):
926 * xfaces.c (realize_basic_faces, realize_default_face)
927 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
928 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
929 * xfns.c (x_set_cursor_color, xic_free_xfontset):
930 * xmenu.c (Fx_menu_bar_open_internal):
931 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
932 * xsettings.c (xft_settings_event):
933 * xterm.c (x_draw_glyph_string, x_had_errors_p):
934 Use bool for booleans. Adjust style and comments where
935 appropriate.
936 * dispextern.h (draw_window_fringes, update_window_fringes)
937 (compute_fringe_widths):
938 * xterm.h (x_had_errors_p): Adjust prototype.
939
ec3058af
DA
9402013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
941
942 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
943 CHECK_LIST. Rewrite the loop to avoid useless local variable.
944
218e0637
DA
9452013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
946
947 * fns.c (toplevel): Remove comment before Fsafe_length because
948 it checks for QUIT.
949
e560aba9
PE
9502013-07-28 Paul Eggert <eggert@cs.ucla.edu>
951
952 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
953
2e5ce5de
EZ
9542013-07-28 Eli Zaretskii <eliz@gnu.org>
955
956 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
957 frame which got the message is still alive, before dereferencing
958 its pointer. (Bug#14970)
959
960 * frame.c (delete_frame): Test "this" frame's minibuffer window to
961 be a live window, before using it as such. (Bug#14970)
962
e95da6d3
EZ
9632013-07-27 Eli Zaretskii <eliz@gnu.org>
964
965 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
966 w32_detect_focus_change instead of doing part of its job by hand.
967 This fixes the problem whereby FOCUS_OUT events were not sent to
968 the event queue.
969
a8f93651
EZ
9702013-07-26 Eli Zaretskii <eliz@gnu.org>
971
fec92060
EZ
972 * process.c (Fprocess_list): Doc fix.
973
a8f93651
EZ
974 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
975 being re-exposed only if it didn't ask to become visible.
976 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
977 was previously iconified. (Bug#14841)
978 (x_iconify_frame): Mark the frame iconified.
979
d5a7a9d9
PE
9802013-07-26 Paul Eggert <eggert@cs.ucla.edu>
981
982 Fix minor problems found by static checking.
983 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
984 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
985
56ea7291
SM
9862013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
987
988 * eval.c (set_specpdl_old_value): New function.
989 (unbind_to): Minor simplification.
990 (get_backtrace_frame): New function.
991 (Fbacktrace_frame): Use it. Add `base' argument.
992 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
993 (syms_of_eval): Export backtrace-eval.
994 * xterm.c (x_focus_changed): Simplify.
995
9d611ffe
PE
9962013-07-25 Paul Eggert <eggert@cs.ucla.edu>
997
998 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
999
999c74e3
EZ
10002013-07-24 Eli Zaretskii <eliz@gnu.org>
1001
1002 * xdisp.c (redisplay_window): Instead of moving point out of
1003 scroll margin, reject the force_start method, and try scrolling
1004 instead. (Bug#14780)
1005
198fa217
KB
10062013-07-24 Ken Brown <kbrown@cornell.edu>
1007
1008 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1009 (Bug#14944).
1010
53840e55
PE
10112013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 * eval.c (Fprogn): Do not check that BODY is a proper list.
1014 This undoes the previous change. The check slows down the
1015 interpreter, and is not needed to prevent a crash. See
1016 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1017
60967f56
GM
10182013-07-23 Glenn Morris <rgm@gnu.org>
1019
1020 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1021
9ca960e2
PE
10222013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1023
a29c3e6d
PE
1024 Port to GNU/Linux systems with tinfo but not ncurses.
1025 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1026 to decide whether ncurses is being used. Without this change,
1027 GCC complains about tgetent not being declared, on a system
1028 that has tinfo installed but ncurses not installed.
1029
f274311c
PE
1030 * eval.c (Fprogn): Check that BODY is a proper list.
1031
16b0520a
PE
1032 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1033 * data.c (Fsetq_default):
1034 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1035 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1036 (Fcondition_case):
1037 Tune by taking advantage of the fact that ARGS is always a list
1038 when a function is declared to have UNEVALLED args.
1039
9ca960e2
PE
1040 * emacsgtkfixed.c: Port to GCC 4.6.
1041 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1042
afacaa1b
JB
10432013-07-23 Juanma Barranquero <lekktu@gmail.com>
1044
1045 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1046 here to silence compiler warnings.
1047
368a85a4
PE
10482013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1051 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1052 from messing up Emacs's 'struct frame' (Bug#14923).
1053
f4e891b5
PE
10542013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 * alloc.c (make_save_ptr_ptr): Define this function.
1057 It was inadvertently omitted. It's needed only if
1058 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1059
96c8b65e
JD
10602013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1061
1062 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1063 frame have focus (Bug#14895).
1064
ee010797
PE
10652013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 Avoid vfork-related deadlock more cleanly.
1068 * callproc.c (child_setup): When the child's exec fails, output
1069 the program name, as that's more useful. Use O_NONBLOCK to avoid
1070 deadlock.
1071 * process.c (create_process_1): Remove; no longer needed.
1072 (create_process): Remove timer hack; no longer needed, now that
1073 the child avoids deadlock.
1074
f0398ec1 10752013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1076
1077 * image.c (Fimage_flush): Fix doc typo.
1078
b2a069c2
PE
10792013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1080
6496aec9
PE
1081 Fix array bounds violation when pty allocation fails.
1082 * process.c (PTY_NAME_SIZE): New constant.
1083 (pty_name): Remove static variable; it's now auto.
1084 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1085 Take pty_name as an arg rather than using a static variable.
1086 All callers changed.
1087 (create_process): Recover pty_flag from process, not from volatile local.
1088 (create_pty): Stay inside array even when pty allocation fails.
1089 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1090
b2a069c2
PE
1091 * lread.c (Fload): Avoid initialization only when lint checking.
1092 Mention that it's needed only for older GCCs.
1093
99107004
KH
10942013-07-20 Kenichi Handa <handa@gnu.org>
1095
1096 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1097 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1098
6b1b199d
AS
10992013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1100
1101 * lread.c (Fload): Avoid uninitialized warning.
1102
4195afc3
PE
11032013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1104
3f5bef16
PE
1105 Fix some minor file descriptor leaks and related glitches.
1106 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1107 (create_lock_file): Use write, not emacs_write.
1108 * image.c (slurp_file, png_load_body):
1109 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1110 (server_accept_connection):
1111 Don't leak an fd on memory allocation failure.
1112 * image.c (slurp_file): Add a cheap heuristic for growing files.
1113 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1114 as that's what the other routines do. Maybe input need not be
1115 blocked at all, but it's better to be consistent.
1116 Avoid undefined behavior when strlen is zero.
1117
4195afc3
PE
1118 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1119 (NSTATICS): Now a constant; doesn't need to be a macro.
1120
a1aeeffe
RS
11212013-07-19 Richard Stallman <rms@gnu.org>
1122
1123 * coding.c (decode_coding_utf_8): Add simple loop for fast
1124 processing of ASCII characters.
1125
63b34baa
PE
11262013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1129
621dd9ac
EZ
11302013-07-19 Eli Zaretskii <eliz@gnu.org>
1131
1132 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1133 unportable 'struct x_display_info'.
1134 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1135 is a portable type.
1136
1396ac86
PE
11372013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1138
ab9980cd
PE
1139 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1140 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1141 or fscanf fails.
1142 (system_process_attributes): Prefer plain char to unsigned char
1143 when either will do. Clean up properly if interrupted or if
1144 memory allocations fail. Don't assume sscanf succeeds. Remove
1145 no-longer-needed workaround to stop GCC from whining. Read
1146 command-line once, instead of multiple times. Check read status a
1147 bit more carefully.
1148
1396ac86
PE
1149 Fix obscure porting bug with varargs functions.
1150 The code assumed that int is treated like ptrdiff_t in a vararg
1151 function, which is not a portable assumption. There was a similar
1152 -- though these days less likely -- porting problem with various
1153 assumptions that pointers of different types all smell the same as
1154 far as vararg functions is conserved. To make this problem less
1155 likely in the future, redo the API to use varargs functions.
1156 * alloc.c (make_save_value): Remove this vararg function.
1157 All uses changed to ...
1158 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1159 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1160 New functions.
1161 (make_save_ptr): Rename from make_save_pointer, for consistency with
1162 the above. Define only on platforms that need it. All uses changed.
1163
4d19d194
PE
11642013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1165
1166 * keyboard.c: Try to fix typos in previous change.
1167 (DISPLAY_LIST_INFO): New macro.
1168 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1169 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1170
945c5bb1
JB
11712013-07-18 Juanma Barranquero <lekktu@gmail.com>
1172
1173 * keyboard.c (kbd_buffer_get_event):
1174 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1175 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1176
f4b1eb36
PE
11772013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1178
5e679a2c
PE
1179 * filelock.c: Fix unlikely file descriptor leaks.
1180 (get_boot_time_1): Rework to avoid using emacs_open.
1181 This doesn't actually fix a leak, but is better anyway.
1182 (read_lock_data): Use read, not emacs_read.
1183
a8cd4836
PE
1184 * doc.c: Fix minor memory and file descriptor leaks.
1185 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1186 (get_doc_string, Fsnarf_documentation):
1187 Fix file descriptor leak on error.
1188
ef30e638
PE
1189 * term.c: Fix minor fdopen-related file descriptor leaks.
1190 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1191 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1192
f4b1eb36
PE
1193 * charset.c: Fix file descriptor leaks and errno issues.
1194 Include <errno.h>.
1195 (load_charset_map_from_file): Don't leak file descriptor on error.
1196 Use plain record_xmalloc since the allocation is larger than
1197 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1198 of entries.
1199 * eval.c (record_unwind_protect_nothing):
1200 * fileio.c (fclose_unwind):
1201 New functions.
1202 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1203 The replacement doesn't block input, but that no longer seems
1204 necessary.
1205
b648c163
PE
12062013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1207
a0931322
PE
1208 * lread.c: Fix file descriptor leaks and errno issues.
1209 (Fload): Close some races that leaked fds or streams when 'load'
1210 was interrupted.
1211 (Fload, openp): Report error number of last nontrivial failure to open.
1212 ENOENT counts as trivial.
1213 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1214 New functions.
1215 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1216 now that the function is always called with a nonnegative arg.
1217 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1218 All uses replaced with ...
1219 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1220
b648c163
PE
1221 A few more minor file errno-reporting bugs.
1222 * callproc.c (Fcall_process):
1223 * doc.c (Fsnarf_documentation):
1224 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1225 * process.c (set_socket_option):
1226 Don't let a constructor trash errno.
1227 * doc.c: Include <errno.h>.
1228
b1dc4084
JB
12292013-07-16 Juanma Barranquero <lekktu@gmail.com>
1230
1231 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1232
c43843aa
PE
12332013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1234
50a30cce
PE
1235 Fix w32 bug with call-process-region (Bug#14885).
1236 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1237 to Fcall_process when the input is empty. This simplifies the
1238 code a bit. It makes no difference on POSIXish platforms but
1239 apparently it fixes a bug on w32.
1240
44e18199 1241 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1242 * fileio.c (close_file_unwind): Don't close if FD is negative;
1243 this can happen when unwinding a zapped file descriptor.
1244 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1245 in case Emacs runs out of memory between the two unwind-protects.
1246 Don't trash errno when closing FD.
1247 Zap the FD in the specpdl when closing it, instead of deferring
1248 the removal of the unwind-protect; this fixes a bug where a child
1249 function unwinds the stack past us.
1250
27e498e6
PE
1251 New unwind-protect flavors to better type-check C callbacks.
1252 This also lessens the need to write wrappers for callbacks,
1253 and the need for make_save_pointer.
1254 * alloca.c (free_save_value):
1255 * atimer.c (run_all_atimers):
1256 Now extern.
1257 * alloc.c (safe_alloca_unwind):
1258 * atimer.c (unwind_stop_other_atimers):
1259 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1260 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1261 * minibuf.c (choose_minibuf_frame_1):
1262 * process.c (make_serial_process_unwind):
1263 * xdisp.h (pop_message_unwind):
1264 * xselect.c (queue_selection_requests_unwind):
1265 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1266 * alloca.c (record_xmalloc):
1267 Prefer record_unwind_protect_ptr to record_unwind_protect with
1268 make_save_pointer.
1269 * alloca.c (Fgarbage_collect):
1270 Prefer record_unwind_protect_void to passing a dummy.
1271 * buffer.c (restore_buffer):
1272 * window.c (restore_window_configuration):
1273 * xfns.c, w32fns.c (do_unwind_create_frame)
1274 New wrapper. All record-unwind uses of wrappee changed.
1275 * buffer.c (set_buffer_if_live):
1276 * callproc.c (call_process_cleanup, delete_temp_file):
1277 * coding.c (code_conversion_restore):
1278 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1279 * editfns.c (save_excursion_restore)
1280 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1281 (save_restriction_restore):
1282 * eval.c (restore_stack_limits, un_autoload):
1283 * fns.c (require_unwind):
1284 * keyboard.c (recursive_edit_unwind, tracking_off):
1285 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1286 * macros.c (pop_kbd_macro, restore_menu_items):
1287 * nsfns.m (unwind_create_frame):
1288 * print.c (print_unwind):
1289 * process.c (start_process_unwind):
1290 * search.c (unwind_set_match_data):
1291 * window.c (select_window_norecord, select_frame_norecord):
1292 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1293 (fast_set_selected_frame):
1294 * xfns.c, w32fns.c (unwind_create_tip_frame):
1295 Return void, not a dummy Lisp_Object. All uses changed.
1296 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1297 * callproc.c (call_process_kill):
1298 * fileio.c (restore_point_unwind, decide_coding_unwind)
1299 (build_annotations_unwind):
1300 * insdel.c (Fcombine_after_change_execute_1):
1301 * keyboard.c (read_char_help_form_unwind):
1302 * menu.c (unuse_menu_items):
1303 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1304 * sound.c (sound_cleanup):
1305 * xdisp.c (unwind_redisplay):
1306 * xfns.c (clean_up_dialog):
1307 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1308 Accept no args and return void, instead of accepting and returning
1309 a dummy Lisp_Object. All uses changed.
1310 * cygw32.c (fchdir_unwind):
1311 * fileio.c (close_file_unwind):
1312 * keyboard.c (restore_kboard_configuration):
1313 * lread.c (readevalllop_1):
1314 * process.c (wait_reading_process_output_unwind):
1315 Accept int and return void, rather than accepting an Emacs integer
1316 and returning a dummy object. In some cases this fixes an
1317 unlikely bug when the corresponding int is outside Emacs integer
1318 range. All uses changed.
1319 * dired.c (directory_files_internal_unwind):
1320 * fileio.c (do_auto_save_unwind):
1321 * gtkutil.c (pop_down_dialog):
1322 * insdel.c (reset_var_on_error):
1323 * lread.c (load_unwind):
1324 * xfns.c (clean_up_file_dialog):
1325 * xmenu.c, nsmenu.m (pop_down_menu):
1326 * xmenu.c (cleanup_widget_value_tree):
1327 * xselect.c (wait_for_property_change_unwind):
1328 Accept pointer and return void, rather than accepting an Emacs
1329 save value encapsulating the pointer and returning a dummy object.
1330 All uses changed.
1331 * editfns.c (Fformat): Update the saved pointer directly via
1332 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1333 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1334 (unwind_body): New function.
1335 (record_unwind_protect): First arg is now a function returning void,
1336 not a dummy Lisp_Object.
1337 (record_unwind_protect_ptr, record_unwind_protect_int)
1338 (record_unwind_protect_void): New functions.
1339 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1340 * fileio.c (struct auto_save_unwind): New type.
1341 (do_auto_save_unwind): Use it.
1342 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1343 * insdel.c (struct rvoe_arg): New type.
1344 (reset_var_on_error): Use it.
1345 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1346 New constants.
1347 (specbinding_func): Remove; there are now several such functions.
1348 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1349 (set_unwind_protect_ptr): New function.
1350 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1351
4e604a5d
PE
1352 Be simpler and more consistent about reporting I/O errors.
1353 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1354 Say "Read error" and "Write error", rather than "I/O error", or
1355 "IO error reading", or "IO error writing", when a read or write
1356 error occurs.
1357 * process.c (Fmake_network_process, wait_reading_process_output)
1358 (send_process, Fprocess_send_eof, wait_reading_process_output):
1359 Capitalize diagnostics consistently. Put "failed foo" at the
1360 start of the diagnostic, so that we don't capitalize the
1361 function name "foo". Consistently say "failed" for such
1362 diagnostics.
1363 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1364 All callers changed. This is so it can use report_file_error.
1365 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1366 diagnostics consistently as above.
1367
a9757f6a
PE
1368 * fileio.c (report_file_errno): Fix errno reporting bug.
1369 If the file name is neither null nor a pair, package it up as a
1370 singleton list. All callers changed, both to this function and to
1371 report_file_error. This fixes a bug where the memory allocator
1372 invoked by list1 set errno so that the immediately following
1373 report_file_error reported the wrong errno value.
1374
c43843aa
PE
1375 Fix minor problems found by --enable-gcc-warnings.
1376 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1377 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1378
18c26d81
JD
13792013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1380
1381 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1382 Set event->arg to Qt if switch-event shall be generated.
1383 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1384
1385 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1386
1387 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1388 FOCUS_OUT_EVENT.
1389
1390 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1391 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1392 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1393 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1394 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1395 and there is a focused frame.
1396 (head_table): Add focus-in and focus-out.
1397 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1398 bind to handle-focus-in/out.
1399
1400 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1401 (Fhandle_switch_frame): Call Fhandle_focus_in.
1402 (syms_of_frame): defsubr handle-focus-in/out.
1403
6c6f1994
PE
14042013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1405
c7ddc792
PE
1406 Fix porting bug to older POSIXish platforms (Bug#14862).
1407 * sysdep.c (emacs_pipe): New function, that implements
1408 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1409 This should port better to CentOS 5 and to Mac OS X 10.6.
1410 All calls to pipe2 changed.
1411
6c6f1994
PE
1412 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1413 This makes the code easier to read and the executable a bit smaller.
1414 Do not replace all calls to Fcons that happen to create lists,
1415 just calls that are intended to create lists. For example, when
1416 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1417 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1418 Similarly for list2 through list5.
1419 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1420 * bytecode.c (exec_byte_code):
1421 * callint.c (quotify_arg, Fcall_interactively):
1422 * callproc.c (Fcall_process, create_temp_file):
1423 * charset.c (load_charset_map_from_file)
1424 (Fdefine_charset_internal, init_charset):
1425 * coding.c (get_translation_table, detect_coding_system)
1426 (Fcheck_coding_systems_region)
1427 (Fset_terminal_coding_system_internal)
1428 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1429 * composite.c (update_compositions, Ffind_composition_internal):
1430 * dired.c (directory_files_internal, file_name_completion)
1431 (Fsystem_users):
1432 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1433 * doc.c (Fsnarf_documentation):
1434 * editfns.c (Fmessage_box):
1435 * emacs.c (main):
1436 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1437 (Feval, eval_sub, Ffuncall, apply_lambda):
1438 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1439 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1440 (Fset_file_times, Finsert_file_contents)
1441 (Fchoose_write_coding_system, Fwrite_region):
1442 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1443 * font.c (font_registry_charsets, font_parse_fcname)
1444 (font_prepare_cache, font_update_drivers, Flist_fonts):
1445 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1446 * frame.c (make_frame, Fmake_terminal_frame)
1447 (x_set_frame_parameters, x_report_frame_params)
1448 (x_default_parameter, Fx_parse_geometry):
1449 * ftfont.c (syms_of_ftfont):
1450 * image.c (gif_load):
1451 * keyboard.c (command_loop_1):
1452 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1453 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1454 (Fminor_mode_key_binding, accessible_keymaps_1)
1455 (Faccessible_keymaps, Fwhere_is_internal):
1456 * lread.c (read_emacs_mule_char):
1457 * menu.c (find_and_return_menu_selection):
1458 * minibuf.c (get_minibuffer):
1459 * nsfns.m (Fns_perform_service):
1460 * nsfont.m (ns_script_to_charset):
1461 * nsmenu.m (ns_popup_dialog):
1462 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1463 (Fx_own_selection_internal):
1464 * nsterm.m (append2):
1465 * print.c (Fredirect_debugging_output)
1466 (print_prune_string_charset):
1467 * process.c (Fdelete_process, Fprocess_contact)
1468 (Fformat_network_address, set_socket_option)
1469 (read_and_dispose_of_process_output, write_queue_push)
1470 (send_process, exec_sentinel):
1471 * sound.c (Fplay_sound_internal):
1472 * textprop.c (validate_plist, add_properties)
1473 (Fput_text_property, Fadd_face_text_property)
1474 (copy_text_properties, text_property_list, syms_of_textprop):
1475 * unexaix.c (report_error):
1476 * unexcoff.c (report_error):
1477 * unexsol.c (unexec):
1478 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1479 (Fformat_mode_line, syms_of_xdisp):
1480 * xfaces.c (set_font_frame_param)
1481 (Finternal_lisp_face_attribute_values)
1482 (Finternal_merge_in_global_face, syms_of_xfaces):
1483 * xfns.c (x_default_scroll_bar_color_parameter)
1484 (x_default_font_parameter, x_create_tip_frame):
1485 * xfont.c (xfont_supported_scripts):
1486 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1487 (menu_help_callback, xmenu_show):
1488 * xml.c (make_dom):
1489 * xterm.c (set_wm_state):
1490 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1491 and similarly for list2 through list5.
1492
bafe80ce
PE
14932013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 * callproc.c (Fcall_process_region): Fix minor race and tune.
1496 (create_temp_file): New function, with the temp-file-creation part
1497 of the old Fcall_process_region. Use Fcopy_sequence to create the
1498 temp file name, rather than alloca + build_string, for simplicity.
1499 Don't bother to block input around the temp file creation;
1500 shouldn't be needed. Simplify use of mktemp. Use
1501 record_unwind_protect immediately after creating the temp file;
1502 this closes an unlikely race where the temp file was not removed.
1503 Use memcpy rather than an open-coded loop.
1504 (Fcall_process_region): Use the new function. If the input is
1505 empty, redirect from /dev/null rather than from a newly created
1506 empty temp file; this avoids unnecessary file system traffic.
1507
4700b5a5
PE
15082013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1509
5c97beae
PE
1510 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1511 Simplify by making this case like the other two. This is a bit
1512 slower on obsolete hosts, but the extra complexity isn't worth it.
1513
4700b5a5
PE
1514 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1515 * process.c (create_process) [!DOS_NT]:
1516 Remove now-unnecessary calls to emacs_close.
1517
f9a74c4c
EZ
15182013-07-13 Eli Zaretskii <eliz@gnu.org>
1519
922ae7ee
EZ
1520 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1521 returning early. (Bug#14850)
1522
f9a74c4c
EZ
1523 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1524 and inhibit-iso-escape-detection attributes of 'undecided'.
1525 (Bug#14822)
1526
5e301d76
PE
15272013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1528
69e0e5ee
PE
1529 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1530 Reported by Herbert J. Skuhra in
1531 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1532
5e301d76
PE
1533 Don't lose top specpdl entry when memory is exhausted.
1534 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1535 specpdl overflow here, to simplify callers; all callers changed.
1536 Always reserve an unused entry at the stack top; this avoids
1537 losing the top entry's information when memory is exhausted.
1538
7e649856
PE
15392013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1540
a773ed9a
PE
1541 Clean up errno reporting and fix some errno-reporting bugs.
1542 * callproc.c (Fcall_process):
1543 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1544 * process.c (create_process, Fmake_network_process):
1545 * unexaix.c (report_error):
1546 * unexcoff.c (report_error):
1547 Be more careful about reporting the errno of failed operations.
1548 The code previously reported the wrong errno sometimes.
1549 Also, prefer report_file_errno to setting errno + report_file_error.
1550 (Fcall_process): Look at openp return value rather than at path,
1551 as that's a bit faster and clearer when there's a numeric predicate.
1552 * fileio.c (report_file_errno): New function, with most of the
1553 old contents of report_file_error.
1554 (report_file_error): Use it.
1555 (Ffile_exists_p, Ffile_accessible_directory_p):
1556 Set errno to 0 when it is junk.
1557 * fileio.c (Faccess_file):
1558 * image.c (x_create_bitmap_from_file):
1559 Use faccessat rather than opening the file, to avoid the hassle of
1560 having a file descriptor open.
1561 * lisp.h (report_file_errno): New decl.
1562 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1563
7e649856
PE
1564 Minor EBADF fixes.
1565 * process.c (create_process, wait_reading_process_output) [AIX]:
1566 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1567 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1568 a multithreaded environment anyway).
1569 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1570
f6774c1a
AS
15712013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1572
1573 * image.c (x_find_image_file): Don't close a remote file handle.
1574
bacba3c2
PE
15752013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 Fix races with threads and file descriptors.
1578 * callproc.c (Fcall_process_region):
1579 * dired.c (open_directory):
1580 * emacs.c (main, Fdaemon_initialized):
1581 * image.c (x_find_image_file):
1582 * inotify.c (Finotify_rm_watch):
1583 * lread.c (Flocate_file_internal):
1584 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1585 * term.c (term_mouse_moveto, init_tty):
1586 * termcap.c (tgetent):
1587 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1588 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1589 * unexhp9k800.c, unexmacosx.c (unexec):
1590 * callproc.c (Fcall_process_region):
1591 Use emacs_close, not close.
1592 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1593 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1594 and posix_close function on current platforms (which all lack them).
1595 (emacs_close): Use it. This should fix the races on GNU/Linux and
1596 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1597 and it should avoid closing random victim file descriptors on
1598 other platforms.
1599
653d4f43
PE
16002013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1601
c8536ec4
PE
1602 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1603 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1604 Touch up doc a bit.
1605
9c203066
PE
1606 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1607 This is for .gdbinit xbacktrace.
1608
653d4f43
PE
1609 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1610 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1611 (emacs_set_tty): Now static.
1612 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1613 * term.c (tty_capable_p, tty_default_color_capabilities)
1614 (get_tty_terminal, term_mouse_movement)
1615 (handle_one_term_event, init_tty, maybe_fatal):
1616 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1617 (tgetent, scan_file, name_match, compare_contin):
1618 * terminal.c (get_terminal):
1619 Use bool for boolean.
1620 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1621 Prefer char to unsigned char if either will do.
1622 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1623 (tty_write_glyphs): Prefer int to unsigned.
1624 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1625 All callers changed.
1626 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1627
45b683a1
PE
16282013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1629
29abe551
PE
1630 Port to C89.
1631 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1632 (B__dummy__): New dummy symbol, to pacify C89.
1633 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1634 they can't grok varargs macros.
1635 * dispnew.c (add_window_display_history)
1636 (add_frame_display_history):
1637 * print.c (print_object):
1638 * xdisp.c (debug_method_add):
1639 Use %p printf format only for void pointers.
1640 * emacs.c (usage_message): New constant, replacing ...
1641 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1642 (main): Adjust to usage reorg.
1643 * fns.c (syms_of_fns):
1644 * profiler.c (syms_of_profiler):
1645 Don't use non-constant struct initializers.
1646 * gnutls.h (gnutls_initstage_t):
1647 * lisp.h (enum Lisp_Fwd_Type):
1648 * lread.c (lisp_file_lexically_bound_p):
1649 * xsettings.c (anonymous enum):
1650 Remove trailing comma.
1651 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1652 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1653 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1654 (DEFUN): Use it.
1655 * regex.c (const_re_char): New type, to pacify strict C89.
1656 All uses of 'const re_char' replaced to use it.
1657 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1658 with glibc when strict C89. This change is imported from gnulib.
1659 All uses changed.
1660 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1661 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1662 Omit GNU_LINUX implementation, since it requires long long.
1663 * xterm.c (x_draw_underwave):
1664 Do not assume the traditional order of struct's members.
1665 (x_term_init): Rewrite to avoid the need for non-constant structure
1666 initializers.
1667
45b683a1 1668 Syntax cleanup, mostly replacing macros with functions.
763a086d 1669 This removes the need for the syntax_temp hack.
45b683a1
PE
1670 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1671 * syntax.c (SYNTAX_INLINE): New macro.
1672 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1673 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1674 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1675 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1676 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1677 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1678 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1679 Now constants, not macros.
1680 (syntax_temp) [!__GNUC__]: Remove.
1681 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1682 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1683 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1684 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1685 Move here from syntax.h; now functions, not macros. Except for the
1686 last function, these are static since only syntax.c uses them.
1687 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1688 All uses changed. Now a function, not a macro; use this fact
1689 to simplify the code.
1690 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1691 compiler bugs; no longer relevant.
1692 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1693 (SYNTAX_INLINE): New macro.
1694 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1695 for the new functions. Use bool for boolean member.
1696 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1697 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1698 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1699 (SETUP_BUFFER_SYNTAX_TABLE):
1700 Now extern inline functions, not macros.
1701 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1702 Remove; all uses replaced by implementation.
1703 (syntax_temp) [!__GNUC__]: Remove decl.
1704 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1705
29be4a50
JD
17062013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1707
1708 * emacs.c (main): Fix syntax error.
1709
954b166e
PE
17102013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 Timestamp fixes for undo (Bug#14824).
1713 * atimer.c (schedule_atimer):
1714 * fileio.c (Ffile_newer_than_file_p):
1715 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1716 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1717 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1718 (syms_of_fileio): Remove Sclear_visited_file_name.
1719 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1720 file doesn't exist; this avoids an ambiguity with negative timestamps.
1721 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1722 * systime.h (make_emacs_time, invalid_emacs_time):
1723 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1724 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1725 * undo.c (record_first_change): Push (visited-file-modtime) onto
1726 undo list rather than reimplementing it by hand, incorrectly.
1727
d74647c3
KB
17282013-07-09 Ken Brown <kbrown@cornell.edu>
1729
1730 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1731
3c51b96b
JB
17322013-07-09 Juanma Barranquero <lekktu@gmail.com>
1733
1734 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1735
4ebbdd67
PE
17362013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1737
1738 Handle errno and exit status a bit more carefully.
1739 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1740 number into an exit status. Instead, use EXIT_CANCELED.
1741 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1742 * callproc.c (relocate_fd):
1743 * emacs.c (close_output_streams, main):
1744 * process.c (create_process):
1745 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1746 Use emacs_perror for simplicity.
1747 * callproc.c (relocate_fd, main):
1748 * sysdep.c (sys_subshell):
1749 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1750 (shut_down_emacs): Use emacs_write, not write.
1751 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1752 * fileio.c (Fcopy_file, e_write):
1753 * nsterm.m (ns_select):
1754 * process.c (send_process):
1755 * sound.c (vox_write):
1756 Use emacs_write_sig, not emacs_write.
1757 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1758 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1759 New constants.
1760 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1761 of write.
1762 (emacs_full_write): New function.
1763 (emacs_write): Rewrite to use it.
1764 (emacswrite_sig, emacs_perror): New functions.
1765 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1766
44e18199 17672013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1768
1769 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1770 on NS even if it is present. Pixmap on NS is a void*.
1771
9caab067
PE
17722013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 Port to Ubuntu 10 (Bug#14803).
1775 Problem reported by T.V. Raman.
1776 * process.c (close_on_exec, accept4, process_socket):
1777 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1778
1d442672
EZ
17792013-07-07 Eli Zaretskii <eliz@gnu.org>
1780
1781 * w32.c (sys_dup): Declare prototype.
1782
1783 * filelock.c:
1784 * emacs.c:
1785 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1786
067428c1
PE
17872013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 Make file descriptors close-on-exec when possible (Bug#14803).
1790 This simplifies Emacs a bit, since it no longer needs to worry
1791 about closing file descriptors by hand in some cases.
1792 It also fixes some unlikely races. Not all such races, as
1793 libraries often open files internally without setting
1794 close-on-exec, but it's an improvement.
1795 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1796 * callproc.c (Fcall_process) [!MSDOS]:
1797 * emacs.c (main) [!DOS_NT]:
1798 * nsterm.m (ns_term_init):
1799 * process.c (create_process):
1800 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1801 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1802 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1803 Prefer mkostemp with O_CLOEXEC to mkstemp.
1804 * callproc.c (relocate_fd) [!WINDOWSNT]:
1805 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1806 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1807 now using pipe2.
1808 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1809 Make the resulting file descriptor close-on-exec.
1810 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1811 * lread.c (load_descriptor_list, load_descriptor_unwind):
1812 Remove; no longer needed. All uses removed.
1813 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1814 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1815 New functions.
1816 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1817 (Fmake_network_process, Fnetwork_interface_list):
1818 (Fnetwork_interface_info, server_accept_connection):
1819 Make newly-created socket close-on-exec.
1820 * sysdep.c (emacs_open, emacs_fopen):
1821 Make new-created descriptor close-on-exec.
1822 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1823 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1824
0da857dd
JD
18252013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1826
1827 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1828 for NS_IMPL_GNUSTEP.
1829
5f86adcd
PE
18302013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1831
1832 Fix openp errno handling.
1833 * callproc.c (Fcall_process): Preserve openp errno around close.
1834 * lread.c (openp): Set errno when returning -1, as some callers
1835 expect this.
1836
1afb1d07
JD
18372013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1838
1839 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1840
1841 * nsterm.h (NSSavePanel): Update comment.
1842 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1843 (ns_run_file_dialog): Declare.
1844
1845 * nsfns.m: Remove panelOK.
1846 (ns_fd_data): New.
1847 (ns_run_file_dialog): New function.
1848 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1849 event loop, so file dialog is popped up by ns_run_file_dialog, called
1850 by sendEvent (Bug#14578).
1851 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1852
3323c263
EZ
18532013-07-06 Eli Zaretskii <eliz@gnu.org>
1854
fdda0220
EZ
1855 * xdisp.c (default_line_pixel_height): New function.
1856 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1857 (try_cursor_movement, redisplay_window, try_window)
1858 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1859
1860 * window.c (window_scroll_pixel_based): use
1861 default_line_pixel_height.
1862
1863 * dispextern.h (default_line_pixel_height): Add prototype.
1864
1865 * frame.c (x_set_line_spacing): Accept a float value for
1866 line-spacing parameter, per the documentation.
1867
3323c263
EZ
1868 * data.c (Fmultibyte_string_p): Doc fix.
1869
47ba6d43
PE
18702013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1871
406af475
PE
1872 Use emacs_open more consistently when opening files.
1873 This handles EINTR more consistently now, and makes it easier
1874 to introduce other uniform changes to file descriptor handling.
1875 * src/systdio.h: New file.
1876 * src/buffer.c (mmap_init):
1877 * cygw32.c (chdir_to_default_directory):
1878 * dispnew.c (Fopen_termscript):
1879 * emacs.c (Fdaemon_initialized):
1880 * fileio.c (Fdo_auto_save):
1881 * image.c (slurp_file, png_load_body, jpeg_load_body):
1882 * keyboard.c (Fopen_dribble_file):
1883 * lread.c (Fload):
1884 * print.c (Fredirect_debugging_output):
1885 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1886 * termcap.c (tgetent):
1887 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1888 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1889 * w32term.c (w32_initialize) [CYGWIN]:
1890 * xfaces.c (Fx_load_color_file):
1891 Use emacs_open instead of plain open, and emacs_fopen instead of
1892 plain fopen.
1893 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1894 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1895 * callproc.c (default_output_mode): New constant.
1896 (Fcall_process): Use it to call emacs_open instead of plain creat.
1897 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1898 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1899 (emacs_fopen): New function.
1900 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1901 Include <lisp.h>, for emacs_open.
1902 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1903
47ba6d43
PE
1904 Remove duplicate #include directives.
1905 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1906 * xfaces.c:
1907 Don't include stdio.h twice.
1908 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1909 Don't include sys/types.h or stdio.h twice.
1910 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1911 * lread.c: Don't include coding.h twice.
1912 * nsfont.m: Don't include frame.h twice.
1913 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1914 * ralloc.c: Don't include <unistd.h> twice.
1915 * xdisp.c: Don't include font.h twice.
1916 * xterm.c: Don't include fontset.h twice.
1917 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1918
b9ed53d5
PE
19192013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 Scale ImageMagick images more carefully.
1922 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1923 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1924 Be more careful about avoiding undefined behavior after
1925 integer overflow and division by zero.
1926
cf13177e
YM
19272013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1928
1929 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1930 (syms_of_w32fns): DEFSYM them.
1931 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1932 (CCHDEVICENAME): Define macros if not defined.
1933 (struct MONITOR_INFO_EX): New struct.
1934 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1935 (enum_display_monitors_fn): New variable.
1936 (globals_of_w32fns): Initialize it.
1937 (Fx_display_pixel_width, Fx_display_pixel_height)
1938 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1939 multi-monitor setups in docstrings.
1940 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1941 screen size by primary monitor's millimeter per pixel.
1942 (w32_monitor_enum, w32_display_monitor_attributes_list)
1943 (w32_display_monitor_attributes_list_fallback)
1944 (Fw32_display_monitor_attributes_list): New functions.
1945 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1946
1947 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1948 if not defined.
1949 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1950
86dfb7a8
MA
19512013-07-04 Michael Albinus <michael.albinus@gmx.de>
1952
1953 * fileio.c (Qfile_notify_error): New error symbol.
1954
1955 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1956 * inotify.c (inotify_callback, symbol_to_inotifymask)
1957 (Finotify_add_watch, Finotify_rm_watch): Use it.
1958 (inotifyevent_to_event): Exchange order of cookie and file name.
1959 (Finotify_add_watch): Adapt docstring.
1960
1961 * lisp.h (Qfile_notify_error): Declare.
1962
2c1c974b
PE
19632013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1964
1965 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1966 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1967 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1968 which did not work (see <http://bugs.gnu.org/14569#307>).
1969 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1970 && (!noninteractive || initialized)). This attempts to thread
1971 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1972
7a35b20f
JB
19732013-07-04 Juanma Barranquero <lekktu@gmail.com>
1974
1975 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1976 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1977
1ce5cd04
PE
19782013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1979
1980 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1981 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1982 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1983 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1984
57f8c490
PE
19852013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1988 Define to __sys_siglist.
1989
bcffb5ca
EZ
19902013-07-02 Eli Zaretskii <eliz@gnu.org>
1991
1992 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1993 word-wrap, so that overflow-newline-into-fringe would work in
1994 visual-line-mode. (Bug#2749)
1995 (move_it_in_display_line_to): When the last scanned display
1996 element fits exactly on the display line, and
1997 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1998 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1999 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2000 finding buffer position that corresponds to pixel coordinates,
2001 e.g. in buffer_posn_from_coords.
2002
2c41e781
JD
20032013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2004
2005 * process.c (handle_child_signal): Call catch_child_signal if
2006 NS_IMPL_GNUSTEP.
2007
c2418359
PE
20082013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2009
52a9bcae
PE
2010 Don't convert function pointers to void * and back.
2011 It isn't portable C, and it's easy enough to avoid.
2012 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2013 (make_save_value): Add support for SAVE_FUNCPOINTER.
2014 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2015 * print.c (print_object):
2016 Distinguish function from object pointers.
2017 * lisp.h (SAVE_FUNCPOINTER): New constant.
2018 (SAVE_SLOT_BITS): Adjust to it.
2019 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2020 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2021 (voidfuncptr): New typedef.
2022 (struct Lisp_Save_Value): New member data[0].funcpointer.
2023 (XSAVE_FUNCPOINTER): New function.
2024
c2418359
PE
2025 Simplify buildobj processing.
2026 * Makefile.in (buildobj.h): Make it a sequence of strings each
2027 followed by comma, rather than a single string. Put it into a
2028 .tmp file in case there's an error while generating it.
2029 (gl-stamp): Use .tmp for temp files.
2030 (mostlyclean): Clean .tmp files.
2031 * doc.c (buildobj): Move to just the routine that needs it.
2032 It's now an array of strings, so processing is simpler.
2033
8f43ce49
PE
20342013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2037 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2038 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2039 Invoke malloc_enable_thread even when not interactive.
2040 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2041 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2042 in this case, since the underlying bug has now been fixed.
2043
24827db9
JB
20442013-07-01 Juanma Barranquero <lekktu@gmail.com>
2045
2046 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2047 unlinking it (bug#14691).
2048
ef099a94
MN
20492013-06-30 Michal Nazarewicz <mina86@mina86.com>
2050
2051 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2052 before checking whether buffer is modified. This lets
2053 `kill-buffer-query-functions' cancel killing of the buffer or save
2054 its content before `kill-buffer' asks user the "Buffer %s
2055 modified; kill anyway?" question.
2056
9d3f2fc2
JD
20572013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2058
2059 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2060 Let the super performKeyEquivalent deal with them (Bug#14747).
2061
e6c6c8c7
PE
20622013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2063
1d71c1d9
PE
2064 * widget.c (resize_cb): Remove unused local.
2065
8f5f35cc
PE
2066 Do not use GTK 3 if it exists but cannot be compiled.
2067 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2068 * xterm.c (x_error_handler) [!USE_GTK]:
2069 Do not use GTK 3.
2070
e6c6c8c7
PE
2071 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2072
0ba54312
EZ
20732013-06-30 Eli Zaretskii <eliz@gnu.org>
2074
5d1c3286
EZ
2075 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2076 to the valid range of values. (Bug#14753)
2077
0ba54312
EZ
2078 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2079 when moving point by using the current glyph matrix. This avoids
2080 the need to force redisplay when this function is called in a
2081 loop.
2082
9c90cc06
PE
20832013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2084
2085 Fix minor problems found by static checking.
2086 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2087 Redo the latter's body to sidestep GCC parenthesization warnings.
2088 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2089 * coding.c (detect_coding, detect_coding_system):
2090 * coding.h (struct undecided_spec):
2091 Use bool for boolean.
2092 * image.c (QCmax_width, QCmax_height): Now static.
2093 * xdisp.c (Fmove_point_visually): Remove unused local.
2094
4c672a0f
EZ
20952013-06-29 Eli Zaretskii <eliz@gnu.org>
2096
2097 * xdisp.c (Fmove_point_visually): New function.
2098
c1ea3abf
JB
20992013-06-28 Kenichi Handa <handa@gnu.org>
2100
2101 * coding.h (define_coding_undecided_arg_index): New enum.
2102 (coding_attr_index): New members
2103 coding_attr_undecided_inhibit_null_byte_detection,
2104 coding_attr_undecided_inhibit_iso_escape_detection,
2105 coding_attr_undecided_prefer_utf_8.
2106 (undecided_spec): New struct.
2107 (struct coding_system): New member `undecided' of the member
2108 `spec'.
2109
2110 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2111 (detect_coding): Likewise.
2112 (detect_coding_system): Likewise.
2113 (Fdefine_coding_system_internal): New coding system properties
2114 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2115 :prefer-utf-8.
2116 (syms_of_coding): Adjust for coding_arg_undecided_max.
2117
ba3de9e6
PE
21182013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 * image.c (x_from_xcolors): Remove unused local.
2121
547c9269
YM
21222013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2123
2124 Defer image data transfer between X client and server until actual
2125 display happens.
2126
2127 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2128 and `mask_img'.
2129
2130 * image.c (Destroy_Image): Remove.
2131 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2132 `mask_p', and `colors_p'. All uses changed.
2133 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2134 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2135 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2136 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2137 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2138 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2139 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2140 (image_get_x_image, image_unget_x_image): New functions or macros.
2141 (image_background, image_background_transparent, x_to_xcolors)
2142 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2143 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2144 instead of Destroy_Image.
2145 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2146 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2147 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2148 (imagemagick_load_image, svg_load_image): Use them instead of
2149 x_create_x_image_and_pixmap, and x_put_x_image followed by
2150 x_destroy_x_image, respectively.
2151 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2152 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2153 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2154 background_transparent fields.
2155 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2156 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2157
dae2f5ef
PE
21582013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2161 This mostly consists of undoing recent changes.
2162 * callproc.c (Fcall_process):
2163 * process.c (create_process):
2164 Do not worry about catching SIGCHLD here, undoing previous change.
2165 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2166 * process.c, process.h (catch_child_signal):
2167 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2168 * process.c (catch_child_handler): Don't worry about being called
2169 lazily and do not assume caller has blocked SIGCHLD, undoing
2170 previous change. Move first-time stuff back to
2171 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2172 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2173 set lib_child_handler if it's already initialized, which may
2174 help avoid problems on GNUStep.
2175
fa55d2aa
PE
21762013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2179 * callproc.c (Fcall_process):
2180 * process.c (create_process):
2181 Make sure SIGCHLD is caught before we fork,
2182 since Emacs startup no arranges to catch SIGCHLD.
2183 * process.c (lib_child_handler): Initialize to null, not to
2184 dummy_handler.
2185 (catch_child_signal): Allow self to be called lazily.
2186 Do nothing if it's already been called.
2187 Assume caller has blocked SIGCHLD (all callers do now).
2188 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2189 just before it's really needed.
2190 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2191 since it hasn't been caught yet.
2192
f3f9606c
LMI
21932013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2194
2195 * image.c (compute_image_size): New function to implement
2196 :max-width and :max-height.
2197 (imagemagick_load_image): Use it.
2198
c7041908
PE
21992013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2202 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2203 Now extern.
2204 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2205 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2206 the SIGCHLD handler, since the code is not atomic and (due to glib)
2207 signals may be arriving now.
2208 * sysdep.c (init_signals): Do not catch child signals here;
2209 'main' now does that later, at a safer time.
2210
f86852b4
PE
22112013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2212
0dfeed58
PE
2213 Clean up SIGCHLD handling a bit (Bug#14569).
2214 * process.c, process.h (catch_child_signal):
2215 Now always extern, even if !NS_IMPL_GNUSTEP.
2216 * process.c (catch_child_signal): Move glib tickler here from
2217 init_process_emacs, so that it's done earlier in Emacs
2218 initialization. Also move the noninteractive && !initialized
2219 check here from init_process_emacs. This is all a bit cleaner for
2220 GNUish platforms, and I hope it works around the Cygwin bug.
2221 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2222 that glib signal handling is tickled before glib creates threads.
2223
f86852b4
PE
2224 * process.c (wait_reading_process_output): Avoid int overflow
2225 when reading more than 2 GiB total from a process.
2226
cbd6509c
PE
22272013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2228
2229 * process.c (create_process): Handle a couple more cases,
2230 i.e., work even if new_argv and wait_child_setup[i] are cached.
2231 Use Fcall_process's style for volatile vars.
2232
9de1114a
AS
22332013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2234
2235 * process.c (create_process): Mark PROCESS volatile.
2236
fbe9e0b9
PE
22372013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2238
2239 Use C99-style flexible array members if available.
2240 This avoids some subtle aliasing issues, which typically
2241 aren't a problem with GCC but may be a problem elsewhere.
2242 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2243 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2244 In either case, it uses a flexible array member rather than
2245 the old struct hack. All uses changed.
2246 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2247 Adjust to sdata reorganization.
2248 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2249 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2250 that ports better to pre-C99 non-GCC.
2251 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2252 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2253 as the latter has changed.
2254 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2255 and port better to pre-C99 GCC.
2256 * image.c (struct xpm_cached_color):
2257 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2258 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2259 Use FLEXIBLE_ARRAY_MEMBER.
2260 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2261 Move decl to top level so it gets checked against implementation.
2262 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2263 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2264
1fc71008
PE
22652013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2266
2267 * syntax.c: Integer cleanups.
2268 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2269 All uses that need 0-or-2 changed to:
2270 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2271 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2272 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2273 (char_quoted, prev_char_comend_first, back_comment)
2274 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2275 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2276 Use bool for boolean.
2277 (update_syntax_table, skip_chars, skip_syntaxes):
2278 Prefer int to unsigned when either will do.
2279 (back_comment): Return boolean success flag, like forw_comment,
2280 instead of positive-or-minus-1 (which might have overflowed int anyway).
2281 Don't stuff ptrdiff_t into int.
2282 (syntax_spec_code, syntax_code_spec): Now const.
2283 (Fmatching_paren, scan_lists, scan_sexps_forward):
2284 Use enum syntaxcode for syntax code.
2285 (Fmatching_paren): Check that arg is a character, not just an integer.
2286 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2287 (Finternal_describe_syntax_value): Omit no-longer-needed
2288 comparison to 0.
2289 (skip_chars): Use char, not unsigned char, when the distinction
2290 doesn't matter.
2291 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2292 * bytecode.c (exec_byte_code):
2293 * syntax.c (syntax_spec_code, Fchar_syntax)
2294 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2295 (init_syntax_once):
2296 * syntax.h (SYNTAX_WITH_FLAGS):
2297 Omit unnecessary casts.
2298
b932cad7
EZ
22992013-06-20 Eli Zaretskii <eliz@gnu.org>
2300
2301 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2302 line dimensions here, to avoid race conditions with the main
2303 thread. (Bug#14062, bug#14630, bug#14669)
2304
2305 * w32term.c (w32_draw_window_cursor): Compute the header line and
2306 mode line dimensions here.
2307 <w32_system_caret_window, w32_system_caret_hdr_height>:
2308 <w32_system_caret_mode_height>: New variables.
2309
2310 * w32term.h: Declare them.
2311
89561f72
PE
23122013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2313
5013fc08
PE
2314 * alloc.c (die): Move "assertion failed" string here ...
2315 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2316 COND when SUPPRESS_CHECKING. This shrinks the executable text
2317 size by 0.8% to 2.2% when configured with --enable-checking,
2318 depending on optimization flags (GCC 4.8.1 x86-64).
2319
89561f72
PE
2320 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2321
763a086d 23222013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2323
2324 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2325 base is 2; this is more accurate.
2326
983aeb9a
JB
23272013-06-19 Juanma Barranquero <lekktu@gmail.com>
2328
2329 * sound.c (string_default): Move to !WINDOWSNT section.
2330 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2331
178ba3e6
PE
23322013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2333
bbc51b15
PE
2334 * sound.c: Integer cleanups.
2335 Remove unnecessary forward decls.
2336 (struct sound_device): The 'file' member is now a Lisp_Object, not
2337 a char *, so that we needn't invoke alloca on a huge size.
2338 (Fplay_sound_internal): Adjust to this.
2339 (string_default): New function.
2340 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2341 Use it to adjust to the struct sound_device change.
2342 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2343 (be2hs) [0]: Remove.
2344
178ba3e6
PE
2345 * syntax.c (skip_chars): Don't use uninitialized storage
2346 when searching a multibyte buffer for characters that are not in a
2347 unibyte string that contains non-ASCII characters.
2348
69f60cdc
JD
23492013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2350
2351 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2352 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2353
0d6224d4
PE
23542013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2357
3c542890
KH
23582013-06-18 Kenichi Handa <handa@gnu.org>
2359
f7e3f7cd
KH
2360 * font.c (Ffont_spec): Signal an error for an invalid font name
2361 (Bug#14648).
3c542890 2362
9349e5f7
PE
23632013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2366 In particular this ports to 32-bit sparc Sun cc.
2367 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2368 array with a dummy element at specpdl[-1], so that its address can
2369 be taken portably.
2370 (unbind_to): Do not copy the binding; not needed, now that we
2371 copy old_value in the one place where the copy is needed.
2372 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2373 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2374 (union specbinding): Rename from struct specbinding. Redo layout
2375 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2376 which is not portable. With Sun C 5.12 32-bit sparc, the
2377 declaration causes nargs to be an unsigned bitfield, a behavior
2378 that the C standard allows; but Emacs wants nargs to be signed.
2379 The overall type is now a union of structures rather than a
2380 structure of union of structures, and the 'kind' member is now a
2381 bitfield, so that the overall type doesn't grow. All uses changed.
2382 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2383
0a4df6a5
PE
23842013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2385
ec6ecaad
PE
2386 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2387 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2388
0a4df6a5
PE
2389 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2390
7bfe8dbc
EZ
23912013-06-17 Eli Zaretskii <eliz@gnu.org>
2392
2393 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2394 unless we know that the window w's frame is a frame object.
2395 Another attempt at solving bug#14062 and bug#14630.
2396
708e05f6
LMI
23972013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2398
2399 * textprop.c (property_set_type): New enum.
2400 (add_properties): Allow appending/prepending text properties.
2401 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2402 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2403 add_text_properties_1.
2404 (Fadd_face_text_property): New function that calls
2405 add_text_properties_1.
2406
84575e67
PE
24072013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2408
2409 Move functions from lisp.h to individual modules when possible.
2410 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2411 * alloc.c (XFLOAT_INIT, set_symbol_name):
2412 * buffer.c (CHECK_OVERLAY):
2413 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2414 (set_char_table_parent):
2415 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2416 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2417 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2418 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2419 (set_blv_valcell):
2420 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2421 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2422 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2423 (backtrace_args, backtrace_debug_on_exit):
2424 * floatfns.c (CHECK_FLOAT):
2425 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2426 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2427 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2428 (set_hash_index_slot):
2429 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2430 * marker.c (CHECK_MARKER):
2431 * textprop.c (CHECK_STRING_OR_BUFFER):
2432 * window.c (CHECK_WINDOW_CONFIGURATION):
2433 Move here from lisp.h, and make these functions static rather than
2434 extern inline.
2435 * buffer.c (Qoverlayp):
2436 * data.c (Qsubrp):
2437 * fns.c (Qhash_table_p):
2438 * window.c (Qwindow_configuration_p):
2439 Now static.
2440 * lisp.h: Remove the abovementioned defns and decls.
2441
44e18199 2442 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2443 In lisp.h, prefer functions to function-like macros, and
2444 constants to object-like macros, when either will do. This:
2445 . simplifies use, as there's no more need to worry about
2446 arguments' side effects being evaluated multiple times.
2447 . makes the code easier to debug on some platforms.
2448 However, when using gcc -O0, keep using function-like macros
2449 for a few critical operations, for performance reasons.
2450 This sort of thing isn't needed with gcc -Og, but -Og
2451 is a GCC 4.8 feature and isn't widely-enough available yet.
2452 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2453 Remove enum lsb_bits; no longer needed.
2454 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2455 * buffer.c (Qoverlap):
2456 * data.c (Qsubrp):
2457 * fns.c (Qhash_table_p):
2458 Now extern, so lisp.h can use these symbols.
2459 * dispextern.h: Include character.h, for MAX_CHAR etc.
2460 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2461 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2462 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2463 (GLYPH_CODE_P): Move here from lisp.h.
2464 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2465 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2466 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2467 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2468 XUNTAG now returns void *.
2469 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2470 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2471 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2472 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2473 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2474 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2475 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2476 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2477 New macros, renamed from their sans-lisp_h_ counterparts.
2478 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2479 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2480 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2481 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2482 If compiling via GCC without optimization, define these as macros
2483 in addition to inline functions.
2484 To disable this, compile with -DINLINING=0.
2485 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2486 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2487 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2488 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2489 (INTMASK, VALMASK): Now macros, since static values cannot be
2490 accessed from extern inline functions.
2491 (VALMASK): Also a constant, for benefit of old GDB.
2492 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2493 is INTEGERP, which can fold it in.
5165d44a 2494 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2495 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2496 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2497 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2498 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2499 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2500 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2501 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2502 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2503 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2504 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2505 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2506 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2507 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2508 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2509 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2510 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2511 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2512 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2513 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2514 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2515 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2516 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2517 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2518 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2519 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2520 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2521 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2522 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2523 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2524 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2525 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2526 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2527 Now functions.
2528 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2529 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2530 (VALMASK): Define in one place rather than in two, merging the
2531 USE_LSB_TAG parts; this is simpler.
2532 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2533 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2534 Move up, to avoid use before definition.
2535 Also include "globals.h" earlier, for the same reason.
2536 (make_natnum): New function.
2537 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2538 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2539 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2540 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2541 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2542 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2543 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2544 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2545 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2546 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2547 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2548 (Qwindow_configuration_p, Qimage): New forward declarations.
2549 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2550 (STRING_COPYIN): Remove; unused.
2551 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2552 (xcar_addr, xcdr_addr): New functions. All uses changed.
2553 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2554 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2555 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2556 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2557 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2558 (TYPE_RANGED_INTEGERP): Simplify.
2559 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2560 (setlocale, fixup_locale, synchronize_system_messages_locale)
2561 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2562 Now empty functions, not macros.
2563 (functionp): Return bool, not int.
2564 * window.c (Qwindow_configuration_p): Now extern,
2565 so window.h can use it.
2566 * window.h (Qwindowp): Move decl back to lisp.h.
2567
9583ec36
EZ
25682013-06-15 Eli Zaretskii <eliz@gnu.org>
2569
2570 * xdisp.c (Fline_pixel_height): New function, required for solving
2571 bug #14567.
2572
210272ce
PE
25732013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2574
2575 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2576
de0503df
SM
25772013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2578
2579 * lread.c (syms_of_lread):
2580 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2581
afbfe143
KD
25822013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2583
2584 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2585
d177e213
XF
25862013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2587
2588 * fileio.c (expand_file_name): Doc fix.
2589
05e3e412
PE
25902013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2591
f7394b12
PE
2592 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2593 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2594 Wait for self, not for 0. This can't hurt on GNU or similar
2595 system, and may help with Cygwin.
2596
05e3e412
PE
2597 * keyboard.c: Don't use PROP (...) as an lvalue.
2598 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2599 Use set_prop (A, B), not PROP (A) = B.
2600
17dd3097
EZ
26012013-06-10 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xdisp.c (get_it_property): Use it->window instead of generating
2604 a Lisp object from it->w.
2605
52fab9c9
EZ
26062013-06-09 Eli Zaretskii <eliz@gnu.org>
2607
2608 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2609 get-char-property the window that is being rendered, instead of
2610 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2611 (compute_display_string_pos): When W is NULL, use the current
2612 buffer as the object to pass to get-char-property.
2613 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2614 pointer member of the bidi iterator, since no window is pertinent
2615 to this function.
52fab9c9 2616
5bf97bfc
EZ
26172013-06-08 Eli Zaretskii <eliz@gnu.org>
2618
2619 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2620 being displayed, and pass it to compute_display_string_pos.
2621 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2622 (bidi_paragraph_init): All callers changed.
2623
2624 * xdisp.c (init_from_display_pos, init_iterator)
2625 (handle_single_display_spec, next_overlay_string)
2626 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2627 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2628 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2629 (compute_display_string_pos): Accept additional argument, the
2630 window being displayed, and pass it to Fget_char_property.
2631 (Bug#14575)
2632
2633 * dispextern.h (struct bidi_it): New member w, the window being
2634 displayed.
2635 (compute_display_string_pos): Adjust prototype.
2636
5de0e011
JD
26372013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2638
e7b41c4c 2639 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2640
2641 * process.c (wait_reading_process_output): Check for NS before GLIB.
2642 GLIB may be linked in due to rsvg, but ns_select must be called.
2643
5de0e011
JD
2644 * xgselect.c (xg_select): Remove call to window_system_available
2645 and g_main_context_pending at the top, so Gdk events (i.e. file
2646 notify) are processed when Emacs is started with -nw.
2647
a822acff
EZ
26482013-06-07 Eli Zaretskii <eliz@gnu.org>
2649
2650 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2651 (ctagsfiles3): New variable, includes only *.m files.
2652 (TAGS): Use an explicit language name in the regular expressions,
2653 to avoid transformation of '/SOMETHING' by MSYS to
2654 'c:\MSYS\SOMETHING'.
2655
6c0a9ed1
RC
26562013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2657
2658 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2659
9ef6111b
EZ
26602013-06-06 Eli Zaretskii <eliz@gnu.org>
2661
2662 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2663 still need to set the mouse pointer shape and activate help-echo.
2664 (Bug#14558)
2665
7d300d64
PE
26662013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 A few porting etc. fixes for the new file monitor code.
2669 See the thread containing
2670 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2671 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2672 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2673 (dir_monitor_callback, Fgfile_rm_watch):
2674 Use assq_no_quit instead of Fassoc, for speed.
2675 (dir_monitor_callback, Fgfile_rm_watch):
2676 eassert that the monitor is a fixnum.
2677 (dir_monitor_callback): No need for CDR_SAFE.
2678 Simplify building of lisp with alternative tails.
2679 (Fgfile_add_watch, Fgfile_rm_watch):
2680 Do not assume glib functions set errno reliably on failure.
2681 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2682 and signal an error otherwise.
2683 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2684 Use Fdelq instead of Fdelete, for speed.
2685
817ebfcf
EZ
26862013-06-05 Eli Zaretskii <eliz@gnu.org>
2687
2688 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2689 don't insist on being invoked on a highlighted tool-bar button.
2690 Avoids losing tool-bar functionality when mouse-highlight is nil.
2691 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2692 Don't highlight when mouse-highlight is nil.
2693 (note_mouse_highlight): When mouse-highlight is nil, don't return
2694 right away; instead, run tool-bar and mode-line highlight
2695 subroutine, clear any existing highlight, and revert the mouse
2696 pointer to its default shape. (Bug#14558)
2697
55577e7c
SM
26982013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2699
2700 * lisp.mk (lisp): Add prog-mode.el.
2701
f019a684
PE
27022013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2705 * process.c (dummy_handler): New function.
2706 (lib_child_handler): New static var.
2707 (handle_child_signal): Invoke it.
2708 (catch_child_signal): If a library has set up a signal handler,
2709 save it into lib_child_handler.
2710 (init_process_emacs): If using glib and not on Windows, tickle glib's
2711 child-handling code so that it initializes its private SIGCHLD handler.
2712 * syssignal.h (SA_SIGINFO): Default to 0.
2713 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2714 31; it should no longer be needed now.
2715
90db8702
MA
27162013-06-05 Michael Albinus <michael.albinus@gmx.de>
2717
2718 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2719
2720 * gfilenotify.c (globals_of_gfilenotify): New function.
2721 (syms_of_gfilenotify): Move global initialization there.
2722
2723 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2724
bfa3acd6
SM
27252013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2726
2727 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2728 * keyboard.c (menu_bar_items, tool_bar_items):
2729 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2730 not override local keymaps any more.
2731
ba59bd80
EZ
27322013-06-04 Eli Zaretskii <eliz@gnu.org>
2733
2734 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2735
7f203aa1
EZ
27362013-06-03 Eli Zaretskii <eliz@gnu.org>
2737
9337e206
EZ
2738 * w32console.c (initialize_w32_display): Return the dimensions of
2739 the console window via 2 additional arguments, not via the current
2740 frame. This avoids crashes due to overrunning the bounds of
2741 frame's decode_mode_spec_buffer, which is not resized following
2742 the change of the frame dimensions from the initial 10x10.
2743
2744 * w32term.h (w32_initialize_display_info): Adjust prototype.
2745
2746 * term.c (init_tty): Take dimensions of the frame from the values
2747 returned by initialize_w32_display.
2748
7f203aa1
EZ
2749 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2750 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2751 (LIBES): Add $(GFILENOTIFY_LIBS).
2752
2753 * w32inevt.c (handle_file_notifications): Add dummy implementation
2754 for !HAVE_W32NOTIFY.
2755
2756 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2757
55a87246
JD
27582013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2759
2760 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2761
2762 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2763
2764 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2765
3d5ee10a
PE
27662013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 Fix minor problems found by static checking.
2769 * data.c (pure_write_error):
2770 Use xsignal2, not Fsignal, as Fsignal might return.
2771 * eval.c (set_backtrace_debug_on_exit): Now static.
2772 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2773 No longer inline. EXTERN_INLINE is needed only for functions
2774 defined in .h files. Reindent function header as per GNU style.
2775 (backtrace_p, backtrace_top, backtrace_next):
2776 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2777 compiler or linker. Add extern decls to pacify gcc -Wall.
2778 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2779 Now static.
2780 * frame.c (free_monitors): Define only on platforms that need it.
2781 * nsterm.m (ns_term_init):
2782 * process.c (catch_child_signal):
2783 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2784 defined on all porting targets these days.
2785 * process.c, process.h (catch_child_signal):
2786 Make it extern only if NS_IMPL_GNUSTEP is defined.
2787
e2d8a6f0
EZ
27882013-06-03 Eli Zaretskii <eliz@gnu.org>
2789
2790 * w32.c (gettimeofday): Make the signature identical to prototype
2791 in nt/inc/sys/time.h.
2792
a8a7c5f6
SM
27932013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2794
2795 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2796 .gdbinit.
2797
2798 * keyboard.c (safe_run_hooks_error): Improve error message.
2799
2800 * data.c (pure_write_error): Add `object' argument.
2801 * puresize.h (CHECK_IMPURE): Use it.
2802
c9628c79
MA
28032013-06-03 Michael Albinus <michael.albinus@gmx.de>
2804
2805 * Makefile.in (NOTIFY_OBJ): New variable.
2806 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2807
2808 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2809 Call syms_of_gfilenotify.
2810
2811 * gfilenotify.c: New file.
2812
2813 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2814 and Qfile_w32notify.
2815 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2816 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2817
2818 * lisp.h: Declare syms_of_gfilenotify.
2819
2820 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2821
2f592f95
SM
28222013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2823
2824 Merge the specpdl and backtrace stacks. Make the structure of the
2825 specpdl entries more obvious via a tagged union of structs.
2826 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2827 (enum specbind_tag): New enum.
2828 (struct specbinding): Make it a tagged union of structs.
2829 Add a case for backtrace records.
2830 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2831 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2832 (backtrace_debug_on_exit): New accessors.
2833 (struct backtrace): Remove.
2834 (struct catchtag): Remove backlist field.
2835 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2836 Move to eval.c.
2837 (Flocal_variable_p): Speed up the common case where the binding is
2838 already loaded.
2839 * eval.c (backtrace_list): Remove.
2840 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2841 (set_backtrace_args, set_backtrace_nargs)
2842 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2843 (backtrace_next): New functions.
2844 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2845 (unwind_to_catch, internal_lisp_condition_case)
2846 (internal_condition_case, internal_condition_case_1)
2847 (internal_condition_case_2, internal_condition_case_n): Don't bother
2848 with backtrace_list any more.
2849 (Fsignal): Adjust to new backtrace format.
2850 (grow_specpdl): Move up.
2851 (record_in_backtrace): New function.
2852 (eval_sub, Ffuncall): Use it.
2853 (apply_lambda): Adjust to new backtrace format.
2854 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2855 data.c.
2856 (specbind): Adjust to new specpdl format. Simplify.
2857 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2858 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2859 backtrace format.
2860 (mark_backtrace): Remove.
2861 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2862 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2863 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2864 Use mark_specpdl.
2865 * profiler.c (record_backtrace): Use get_backtrace.
2866 (handle_profiler_signal): Use backtrace_top_function.
2867 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2868 accessor functions.
2869
c0342369
JD
28702013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2871
2872 * process.h (catch_child_signal): Declare.
2873
2874 * process.c (catch_child_signal): New function.
2875 (init_process_emacs): Call it.
2876
2877 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2878 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2879 NS_IMPL_COCOA.
2880 (x_set_cursor_type): Remove declaration.
2881 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2882 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2883 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2884 (ns_get_color): Use F suffix on float.
2885 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2886 (ns_get_rgb_color): Remove.
2887 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2888 (note_mouse_movement): x and y are CGFloat.
2889 (ns_draw_fringe_bitmap): Remove unused rowY.
2890 Change #if to COCOA && >= 10_6.
2891 (ns_draw_window_cursor): Remove unused overspill.
2892 (ns_draw_underwave): width and x are EamcsCGFloat.
2893 (ns_draw_box): thickness is CGFloat.
2894 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2895 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2896 if not in main thread.
2897 (ns_get_pending_menu_title, ns_check_menu_open)
2898 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2899 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2900 (sendFromMainThread:): New method.
2901 (changeFont:): size is CGFloat.
2902 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2903 Disable warning about permanent text.
2904 (characterIndexForPoint:): Adjust return type depending on GNUStep
2905 version.
2906 (mouseDown:): delta is CGFloat.
2907 (updateFrameSize): Remove unised variable f.
2908 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2909 Cast float to EmacsCGFloat.
2910 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2911 also to -1 when restoring.
2912 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2913 inside NS_IMPL_COCOA.
2914 (toggleFullScreen:): Put call to toggleFullScreen inside
2915 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2916 (setPosition:portion:whole:): por is CGFloat.
2917 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2918 (mouseDown:): Use CGFloat.
2919 (mouseDragged:): Remove unised variable edge.
2920 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2921
2922 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2923 of CGFloat differs.
2924 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2925 when NS_IMPL_GNUSTEP.
2926 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2927 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2928 (EmacsToolbar): Add clearAll. Add tag argument to
2929 addDisplayItemWithImage.
2930 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2931
2932 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2933
2934 * nsmenu.m (ns_update_menubar): Make static.
2935 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2936 (fillWithWidgetValue:): Add cast to SEL for setAction.
2937 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2938 (update_frame_tool_bar): Update code for GNUStep.
2939 (clearAll): New method.
2940 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2941 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2942 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2943 call to insertItemWithItemIdentifier.
2944 (validateVisibleItems): Fix indentation.
2945 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2946 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2947 UtilityWindow to aStyle, remove call to setStyleMask.
2948
2949 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2950
2951 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2952 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2953 Use F suffix on floats.
2954 (ns_char_width): Returns CGFloat.
2955 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2956 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2957 DPSxshow.
2958 (ns_glyph_metrics): CGFloat instead of float.
2959
a0eb10b3
JB
2960 * nsfns.m (x_set_foreground_color, x_set_background_color):
2961 Use EmacsCGFloat.
2962 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2963 remove unused variables.
2964 (Fns_read_file_name): Keep track if panel is for save.
2965 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2966 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2967 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2968 Just return the input if GNUStep.
c0342369
JD
2969 (x_screen_planes): Remove.
2970 (Fxw_color_values): Use EmacsCGFloat
2971 (Fns_display_monitor_attributes_list): Only get screen number for
2972 Cocoa.
ef099a94 2973 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2974 EmacsSavePanel.
2975 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2976 ns_directory_from_panel.
2977
da9aff11
PE
29782013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2979
2980 * process.c (handle_child_signal): Also use WCONTINUED.
2981 This is so that list-processes doesn't mistakenly list the process
2982 as stopped, when the process has actually been continued and is
2983 now running.
2984
0e64479a
PE
29852013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2986
fc186a96
PE
2987 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2988 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2989 not already configured.
2990
0e64479a
PE
2991 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2992
38b787fa
EZ
29932013-05-29 Eli Zaretskii <eliz@gnu.org>
2994
2995 * Makefile.in (mostlyclean): Remove *.res files.
2996
22513e52
SM
29972013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2998
2999 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3000 a buffer (bug#8447).
3001
6ef3db10
EZ
30022013-05-27 Eli Zaretskii <eliz@gnu.org>
3003
3004 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3005 display vector, and we backtrack, handle the case that the
3006 previous character position is also displayed from a display
3007 vector or covered by a display string or image. (Bug#14476)
3008
6799bb26
JD
30092013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3010
3011 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3012 (struct MonitorInfo, free_monitors): Remove.
3013 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3014 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3015 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3016 Qframes, Qsource.
3017
3018 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3019 (struct MonitorInfo, free_monitors): Remove.
3020 (ns_screen_name): Make static.
3021 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3022 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3023 Qframes, Qsource.
3024
3025 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3026 (struct MonitorInfo): New struct.
3027 (free_monitors, make_monitor_attribute_list): Declare.
3028
22513e52
SM
3029 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3030 New Lisp_Object:s.
6799bb26
JD
3031 (free_monitors, make_monitor_attribute_list): New functions.
3032 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3033 Qsource.
3034
38cd43eb
XF
30352013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3036
3037 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3038
2af0948d
SM
30392013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3040
a7eb9b0f
SM
3041 * keyboard.c: Apply keyboard decoding only to events that come directly
3042 from the tty, not from unread-command-events (bug#14368).
3043 (read_event_from_main_queue): New function, extracted from read_char).
3044 (read_decoded_char): Remove.
3045 (read_decoded_event_from_main_queue): New function to replace it.
3046 (read_char): Use it.
3047 (read_key_sequence): Use read_char rather than read_decoded_char.
3048
2af0948d
SM
3049 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3050
1413e9a5
BR
30512013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3052
3053 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3054
e6d2f155
KH
30552013-05-22 Kenichi Handa <handa@gnu.org>
3056
3057 The following changes are to fix the setting of
3058 buffer-file-coding-system on, for instance, C-x RET c unix RET
3059 _FILE_OF_DOS_EOL_TYPE_ RET.
3060
3061 * coding.h (struct coding_system): New member detected_utf8_chars.
3062
3063 * coding.c (detect_coding_utf_8): Count characters and check EOL
3064 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3065 BOM is there.
3066 (setup_coding_system): Do not initialize coding->head_ascii.
3067 (check_ascii): Do not set coding->eol_seen but update it. Do not
3068 call adjust_coding_eol_type here.
1413e9a5
BR
3069 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3070 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3071 of the found coding-system.
3072 (decode_coding_gap): Cancel previous change. Utilize the
3073 character numbers counted by detect_coding_utf_8. Fix detection
3074 of BOM for utf-8.
3075
ab56a6f4 30762013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3077
3078 * search.c (looking_at_1): Only set last_thing_searched if the match
3079 changed the match-data (bug#14281).
3080
ecc3c6ed
DA
30812013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3082
3083 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3084 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3085 (move_it_vertically_backward): Likewise.
3086
5ba8bf35
YM
30872013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3088
3089 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3090 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3091 (Fx_display_mm_width, Fx_display_mm_height):
3092 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3093
91e8418b 3094 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3095 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3096 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3097 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3098 (Fx_display_backing_store, Fx_display_visual_class)
3099 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3100 (Fx_display_grayscale_p, Fx_display_pixel_width)
3101 (Fx_display_pixel_height, Fx_display_planes)
3102 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3103 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3104 (Fx_display_mm_width, Fx_display_mm_height)
3105 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3106 height for all physical monitors as in X11.
3107
fc30d803
SM
3108 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3109 Return pixel width or height for all physical monitors as in X11.
91e8418b 3110
31ff141c
PE
31112013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 Port --enable-gcc-warnings to clang.
3114 * bytecode.c (exec_byte_code):
3115 * regex.c:
3116 Redo diagnostic pragmas to pacify clang, too.
3117 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3118 * editfns.c (Fencode_time):
3119 * fileio.c (file_accessible_directory_p):
3120 * font.c (font_unparse_xlfd):
3121 Use '&"string"[index]' instead of '"string" + (index)'.
3122 * undo.c (user_error): Remove; unused.
3123
df065a0b
EZ
31242013-05-16 Eli Zaretskii <eliz@gnu.org>
3125
04d360e7
EZ
3126 * insdel.c (insert_1_both): Document the arguments, instead of
3127 referring to insert_1, which no longer exists.
3128
5bb98290
EZ
3129 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3130 some window, increment windows_or_buffers_changed, so that
3131 *Messages* display in that window is updated. (Bug#14408)
3132
df065a0b
EZ
3133 * w32.c: Include epaths.h.
3134 (init_environment): Use cmdproxy.exe without leading directories.
3135 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3136 case.
3137 (gettimeofday): Adjust signature and return value to Posix
3138 expectations.
3139
3140 * unexw32.c (open_output_file): Delete the existing emacs.exe
3141 before creating it, to break the hard link to the versioned
3142 executable.
3143
3144 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3145 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3146 (FIRSTFILE_OBJ): New variables.
3147 (W32_RES): Rename to EMACSRES. All users changed.
3148 (base_obj): Use $(CM_OBJ).
3149 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3150 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3151 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3152 $(W32_RES_LINK) before $(LIBES).
3153 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3154
1aa8d505
SM
31552013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3156
6e911150
SM
3157 * makefile.w32-in (DOC): Use just "DOC".
3158
3159 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3160
1aa8d505
SM
3161 * process.c: Export default filters and sentinels to Elisp.
3162 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3163 New constants.
3164 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3165 (Fset_process_sentinel, Fformat_network_address):
3166 Default to them instead of nil.
3167 (server_accept_connection): Sentinels can't be nil any more.
3168 (read_and_dispose_of_process_output): New function, extracted from
3169 read_process_output.
3170 (read_process_output): Use it; filters can't be nil.
3171 (Finternal_default_process_filter): New function, extracted from
3172 read_process_output.
3173 (exec_sentinel_unwind): Remove function.
3174 (exec_sentinel): Don't zilch sentinel while running.
3175 (status_notify): Sentinels can't be nil.
3176 (Finternal_default_process_sentinel): New function extracted from
3177 status_notify.
3178 (setup_process_coding_systems): Default filter is not nil any more.
3179 (syms_of_process): Export new Elisp functions and initialize
3180 new constants.
3181 * lisp.h (make_lisp_proc): New function.
3182
5ac2eb34
SM
31832013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3184
3185 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3186
eda9c7d7
EZ
31872013-05-14 Eli Zaretskii <eliz@gnu.org>
3188
3189 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3190 unless we know that the window w is a leaf window.
3191 Another attempt at solving bug#14062.
eda9c7d7 3192
8fdeaad5
JD
31932013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3194
3195 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3196 fdesc (Bug#14375).
3197
44aa9ee6
PE
31982013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3199
3200 * image.c (gif_load): Check that subimages fit (Bug#14345).
3201
759fd763
SM
32022013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3203
3204 * lread.c (skip_dyn_eof): New function.
3205 (read1): Use it to skip the end of a file in response to #@00.
3206
3207 * doc.c (get_doc_string): Slightly relax the sanity checking.
3208
4465bfb4
JD
32092013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3210
3211 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3212 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3213 (MonitorInfo): New struct.
3214 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3215 (Fns_display_monitor_attributes_list): New functions.
3216 (display-usable-bounds): Remove.
3217 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3218 Qsource.
3219
7583e2a0
PE
32202013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3221
3222 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3223 (GTK_CHECK_VERSION): New macro, if not already defined.
3224 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3225 replaced by GTK_CHECK_VERSION.
3226
ad75d77e
PE
32272013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3228
3229 * xterm.h (GTK_PREREQ): New macro.
3230 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3231 to use this macro instead, for consistency and clarity.
3232
07525f77
EZ
32332013-05-08 Eli Zaretskii <eliz@gnu.org>
3234
3235 * xdisp.c (row_for_charpos_p): New function, with code of
3236 cursor_row_p, but accepts an additional argument CHARPOS instead
3237 of using a hardcoded PT.
3238 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3239 (row_containing_pos): Call row_for_charpos_p instead of partially
3240 doing the same. Fixes cursor positioning under longlines-mode
3241 when longlines-show-effect includes more than one newline, when
3242 moving the cursor vertically up.
3243
d901fc8d
JB
32442013-05-08 Juanma Barranquero <lekktu@gmail.com>
3245
3246 * makefile.w32-in (ACL_H): New macro.
3247 ($(BLD)/fileio.$(O)): Update dependencies.
3248
f269bc61
PE
32492013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3250
e7b41c4c 3251 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3252 * Makefile.in (LIB_ACL): New macro.
3253 (LIBACL_LIBS): Remove.
3254 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3255 * fileio.c: Include <acl.h>.
3256 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3257 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3258 !acl_errno_valid.
3259 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3260 it ourselves.
3261
f269bc61
PE
3262 * unexelf.c: Don't assume ElfW (Half) fits in int.
3263 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3264 when dealing with ElfW (Half) values, since they can exceed 2**31
3265 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3266 (entry_address): Omit unused NUM arg. All uses changed.
3267
a261c53e
JL
32682013-05-07 Juri Linkov <juri@jurta.org>
3269
3270 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3271 to the string converted from number with `Fnumber_to_string'.
3272 (Bug#14254)
3273
2b66427d
PE
32742013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3277 This fixes a problem introduced by my previous change.
3278
15acfe41
GM
32792013-05-07 Glenn Morris <rgm@gnu.org>
3280
3281 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3282
5ea03bf5
JD
32832013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3284
3285 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3286
e0c9d565
PE
32872013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3288
3289 Static checking by GCC 4.8.0.
3290 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3291 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3292 (x_get_monitor_attributes_fallback)
3293 (x_get_monitor_attributes_xinerama)
3294 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3295 Define only if USE_GTK.
3296 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3297 (x_get_monitor_attributes_fallback): Omit unused locals.
3298 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3299 Use double, not float, to avoid mixed-mode floating point arithmetic.
3300
4e3f9230
YM
33012013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3302 Jan Djärv <jan.h.d@swipnet.se>
3303
3304 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3305 (XINERAMA_CFLAGS): New macros.
3306 (ALL_CFLAGS, LIBES): Use them.
3307
3308 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3309 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3310 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3311 (syms_of_xfns): DEFSYM them.
3312 (struct MonitorInfo): New struct.
3313 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3314 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3315 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3316 (x_get_monitor_attributes_xinerama): New functions.
3317 (Fx_display_monitor_attributes_list): New primitive.
3318 (syms_of_xfns): Defsubr it.
3319
3320 * xterm.h (x_display_info): Add Xatom_net_workarea and
3321 Xatom_net_current_desktop.
3322
3323 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3324 and dpyinfo->Xatom_net_current_desktop.
3325
05839b6a
EZ
33262013-05-06 Eli Zaretskii <eliz@gnu.org>
3327
3328 * xdisp.c (pos_visible_p): Use the special code for finding the
3329 beginning of a display property or overlay for any "replacing"
3330 display property, not just for display strings. This solves
3331 incorrect reporting of position by posn-at-point. (Bug#14241)
3332
dc4a2ee0
PE
33332013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3334
5ee94506
PE
3335 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3336 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3337 Verify that ElfW (Half) fits in int.
3338 (fatal): Use same signature as lisp.h.
3339 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3340 configure and build with -DUNEXELF_DEBUG without worrying about
3341 other modules that use DEBUG.
3342 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3343 possibly-wide integers now uses it instead of plain fprintf.
3344 (entry_address): New function, which avoids problems with 32-bit
3345 overflow on 64-bit hosts.
3346 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3347 (round_up): Don't assume the remainder fits in int.
3348 (find_section): Use bool for boolean. Simplify debug code.
3349 (unexec): Don't assume file sizes fit in int or size_t.
3350 Omit unnecessary trailing newline in 'fatal' format.
3351 Use strerror rather than outputting decimal error number.
3352 Remove unused code when emacs is not defined;
3353 this file relies on Emacs now.
3354 Don't assume e_phnum and e_shnum are positive.
3355
dc4a2ee0
PE
3356 * regex.c: Fix problems when DEBUG is defined.
3357 (extract_number, extract_number_and_incr): Define regardless of
3358 whether DEBUG is defined; that's simpler and makes the code less
3359 likely to go stale in the normal case when DEBUG is not defined.
3360 Return int rather than taking an int * arg. All callers changed.
3361 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3362 Remove, replacing with ...
3363 (DEBUG_PRINT): New macro. All callers changed.
3364 (DEBUG_COMPILES_ARGUMENTS): New macro.
3365 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3366 (print_compiled_pattern, print_double_string) [DEBUG]:
3367 Use prototype rather than old-style definition.
3368 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3369 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3370 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3371 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3372 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3373 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3374 This matters only when DEBUG is defined.
3375
14c7ed05
EZ
33762013-05-05 Eli Zaretskii <eliz@gnu.org>
3377
3378 * xdisp.c (set_iterator_to_next): Set the
3379 ignore_overlay_strings_at_pos_p flag only if we are _really_
3380 iterating over an overlay string, as indicated by the
3381 current.overlay_string_index member. (Bug#14306)
3382
e6076b1b
JD
33832013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3384
3385 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3386 to where it is used, to avoid autorelease issues (Bug#14050).
3387
cbee2131
PE
33882013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3389
3390 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3391 * fileio.c (syms_of_fileio): Implement this.
3392 * filelock.c (create_lock_file): If symbolic links don't work, so
3393 we use a regular file as a lock file, do not fsync the lock file;
3394 it's not needed.
3395
30c7e542
SM
33962013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3397
3398 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3399 (syms_of_minibuf): Adjust accodingly.
3400 * lread.c (Fread):
3401 * callint.c (Fcall_interactively): Adjust calls accordingly.
3402
5bebd186
EZ
34032013-05-04 Eli Zaretskii <eliz@gnu.org>
3404
3405 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3406 w->contents is a buffer before computing everything else.
3407 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3408
3409 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3410 assertion violations. (Bug#14062)
3411
0fb0a4f3
DR
34122013-05-01 David Reitter <david.reitter@gmail.com>
3413
3414 * nsfns.m (ns_tooltip): Initialize.
3415
9e63b4a5
EZ
34162013-04-28 Eli Zaretskii <eliz@gnu.org>
3417
3418 * coding.c (decode_coding_gap): Don't remove the character before
3419 a newline unless it's a CR character. (Bug#14287)
3420
ad60824e
DN
34212013-04-28 Dan Nicolaescu <dann@gnu.org>
3422
3423 * dispextern.h (struct face): Move enum face_underline_type
3424 earlier so that bitfields can be in the same word.
3425
edbdcec0
JD
34262013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3427
3428 * nsfns.m (handlePanelKeys): New function.
3429 (EmacsOpenPanel:performKeyEquivalent:)
3430 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3431 arrows/function/control and copy/paste keys (Bug#14296).
3432
0208ede7
JL
34332013-04-27 Juri Linkov <juri@jurta.org>
3434
3435 * callint.c (Fcall_interactively): Call `Qread_number' for
3436 interactive code letter `n' instead of using duplicate code.
3437 (Bug#14254)
3438
b8dd59f7
PE
34392013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 * systime.h (make_timeval): Declare as 'const'.
3442
8bd722db
KH
34432013-04-27 Kenichi Handa <handa@gnu.org>
3444
3445 * font.c (font_open_entity): Always open a font of manageable
3446 size.
3447
13d0e56f 34482013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3449
f780d632
PE
3450 Port better to AIX (Bug#14258).
3451 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3452 to pacify AIX xlc.
3453
ec509856
KH
34542013-04-24 Kenichi Handa <handa@gnu.org>
3455
3456 * coding.c (decode_coding_iso_2022): When an invalid escape
3457 sequence is encountered, reset the invocation and designation
3458 status to the safest one.
3459
84fc48e5
PE
34602013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3461
3462 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3463 Without this fix, "make distclean" leaves stamp-h1 behind.
3464
806bda47
EC
34652013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3466
3467 * w32fns.c (w32_fullscreen_rect): New function to compute the
3468 window rectangle for the given fullscreen mode.
3469 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3470 longer tunes the window size. This keeps the window's edges flush
3471 with the screen and allows the taskbar to hide itself in fullboth.
3472
3473 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3474 window decorations and uses the entire screen.
3475
3476 * w32term.h (w32_fullscreen_rect) Add prototype.
3477 (struct w32_output): Replace normal_width, normal_height,
3478 normal_top, and normal_left members with a single normal_placement
3479 struct.
3480 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3481 Remove macros.
3482 (FRAME_NORMAL_PLACEMENT): New macro.
3483
9cc2810b
JB
34842013-04-16 Juanma Barranquero <lekktu@gmail.com>
3485
3486 * minibuf.c (Ftest_completion): Silence compiler warning.
3487
fd16b54c
EZ
34882013-04-15 Eli Zaretskii <eliz@gnu.org>
3489
3490 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3491 bug#14062.
fd16b54c
EZ
3492
3493 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3494 parentheses.
3495
3496 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3497 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3498 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3499 parentheses where appropriate.
3500
9e3379a0
PE
35012013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3502
3503 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3504
ddd6b685
EZ
35052013-04-14 Eli Zaretskii <eliz@gnu.org>
3506
3507 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3508 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3509 Mention in the doc string that setting these variables takes
3510 effect only after a call to set-window-buffer. (Bug#14200)
3511
29b79ba1
EZ
35122013-04-13 Eli Zaretskii <eliz@gnu.org>
3513
3514 * indent.c (Fvertical_motion): Don't consider display strings on
3515 overlay strings as display strings on the buffer position we
3516 started from. This prevents vertical cursor motion from jumping
3517 more than one line when there's an overlay string with a display
3518 property at end of line.
3519 Reported by Karl Chen <Karl.Chen@quarl.org> in
3520 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3521
562c6ee9
SM
35222013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3523
3524 * window.c (select_window): `record_buffer' even if window is
3525 already selected (bug#14191).
3526
fcc1fe85
EZ
35272013-04-11 Eli Zaretskii <eliz@gnu.org>
3528
3529 * window.c (Fwindow_end): Test more flags, including the buffer's
3530 last_overlay_modified flag, to determine whether the window's
3531 display is really up-to-date. Prevents the function from
3532 returning a stale value. (Bug#14170)
3533 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3534 current matrix.
3535
f009190a
EZ
35362013-04-10 Eli Zaretskii <eliz@gnu.org>
3537
3538 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3539 garbaged only if it is not already the top frame on its TTY.
3540 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3541 there are GUI frames open in the same session. (Bug#13864)
3542
78ce603d
SM
35432013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3544
3545 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3546 of marking the idle timers directly.
3547
a8036e40
SM
35482013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3549
3550 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3551 tables (bug#14054).
3552
7ffe7ef6
SM
35532013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3554
3555 * window.c (select_window): Don't record_buffer while the invariant is
3556 temporarily broken (bug#14161).
3557
3558 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3559
7d9f6883
EZ
35602013-04-07 Eli Zaretskii <eliz@gnu.org>
3561
3562 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3563
5406cfd9
RF
35642013-04-07 Romain Francoise <romain@orebokech.com>
3565
3566 Ignore additional platform-specific ACL errors (Bug#13702).
3567 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3568 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3569
95c0e83b
JD
35702013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3571
3572 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3573 f->output_data.ns.
3574
876da980
PE
35752013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3576
3577 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3578 This bug was introduced by my 2013-02-25 change that simplified
3579 data_start configuration. Without this change, on GNU/Linux
3580 an Emacs configured with --enable-profiling fails immediately
3581 due to a profiler signal.
3582 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3583 with these flags. On platforms where special flags are needed
3584 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3585 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3586 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3587
7452b7bd
DA
35882013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3589
3590 Get rid of some platform-specific functions examining window
3591 system and its capabilities. This is a partial rework of the
3592 2013-04-05 change.
3593 * lisp.h (have_menus_p): Remove prototype. This function is
3594 replaced with platform-independent window_system_available.
3595 (check_window_system): Move to...
3596 * frame.h (decode_window_system_frame, window_system_available):
3597 ...here, add new prototypes.
3598 * frame.c (window_system_available, decode_window_system_frame):
3599 New functions.
3600 (check_window_system): Platform-independent now.
3601 * xterm.h (x_in_use): Remove declaration.
3602 (check_x_frame):
3603 * w32term.h (check_x_frame):
3604 * nsterm.h (check_x_frame): Remove prototypes. This function
3605 is replaced with platform-independent decode_window_system_frame.
3606 * msdos.c (have_menus_p): Remove.
3607 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3608 Remove platform-specific functions. Use check_window_system,
3609 decode_window_system_frame and check_ns_display_info where
3610 appropriate. Minor style and comment tweaks.
3611 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3612 (check_x_frame): Likewise.
3613 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3614 Likewise.
3615 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3616 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3617 * xmenu.c, xselect.c: All related users changed.
3618
251e9147
KH
36192013-04-03 Kenichi Handa <handa@gnu.org>
3620
3621 The following changes is to optimize the code for reading UTF-8
3622 files.
3623
562c6ee9 3624 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3625 changed. Check EOL format. Do not call adjust_coding_eol_type
3626 here.
3627 (check_utf_8): New function.
3628 (adjust_coding_eol_type): Do nothing if already adjusted.
3629 (detect_coding): Compare the return value of check_ascii with
3630 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3631 (decode_coding_gap): Optimize for valid UTF-8.
3632
8bc369d4
KH
36332013-03-21 Kenichi Handa <handa@gnu.org>
3634
3635 * coding.c (syms_of_coding): Cancel previous change.
3636
3637 * insdel.c (insert_from_gap): Fix previous change.
3638
73931ad1
DA
36392013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3640
3641 Consistently use platform-specific function to detect window system.
3642 * lisp.h (check_window_system): New prototype. This function is
3643 going to replace check_x, check_w32 and check_ns.
3644 (have_menus_p): Mention msdos.c in comment.
3645 * fontset.c (check_window_system_func): Remove. Adjust all users.
3646 * fontset.h (check_window_system_func): Remove prototype.
3647 * nsterm.h (check_ns):
3648 * xterm.h (check_x):
3649 * w32term.h (check_w32): Likewise.
3650 * menu.c (Fx_popup_menu): Use check_window_system.
3651 * msdos.c (check_window_system): Define for MS-DOS.
3652 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3653 * w32fns.c (check_window_system): Likewise for MS-Windows.
3654 * xfns.c (check_window_system): Likewise for X.
3655 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3656 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3657
7216e43b
PE
36582013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3659
3660 Prefer < to > in range checks such as 0 <= i && i < N.
3661 This makes it easier to visualize quantities on a number line.
3662 This patch doesn't apply to all such range checks,
3663 only to the range checks affected by the 2013-03-24 change.
3664 This patch reverts most of the 2013-03-24 change.
3665 * alloc.c (xpalloc, Fgarbage_collect):
3666 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3667 * character.c (string_escape_byte8):
3668 * charset.c (read_hex):
3669 * data.c (cons_to_unsigned):
3670 * dispnew.c (update_frame_1):
3671 * doc.c (Fsubstitute_command_keys):
3672 * doprnt.c (doprnt):
3673 * editfns.c (hi_time, decode_time_components):
3674 * fileio.c (file_offset):
3675 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3676 * font.c (font_intern_prop):
3677 * frame.c (x_set_alpha):
3678 * gtkutil.c (get_utf8_string):
3679 * indent.c (check_display_width):
3680 * keymap.c (Fkey_description):
3681 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3682 * lread.c (read1):
3683 * minibuf.c (read_minibuf_noninteractive):
3684 * process.c (wait_reading_process_output):
3685 * search.c (Freplace_match):
3686 * window.c (get_phys_cursor_glyph):
3687 * xdisp.c (redisplay_internal):
3688 * xsmfns.c (smc_save_yourself_CB):
3689 Prefer < to > for range checks.
3690 * dispnew.c (sit_for): Don't mishandle NaNs.
3691 This fixes a bug introduced in the 2013-03-24 change.
3692 * editfns.c (decode_time_components): Don't hoist comparison.
3693 This fixes another bug introduced in the 2013-03-24 change.
3694
92759988
DA
36952013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3696
3697 * frame.h (struct frame): Drop scroll_bottom_vpos
3698 member becaue all real users are dead long ago.
3699 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3700 * xdisp.c (redisplay_internal): Adjust user.
3701
9a1971bb
GM
37022013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3703
f38ab167
JD
3704 * nsmenu.m (showAtX:Y:for:): setLevel to
3705 NSPopUpMenuWindowLevel (Bug#13998).
3706
6d01f1fe
JD
37072013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3708
3709 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3710 (ns_check_pending_open_menu): Declare.
3711
3712 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3713 (x_activate_menubar): Update the menu with title that matches
3714 ns_get_pending_menu_title, and call
3715 ns_check_pending_openmenu (Bug#12698).
3716 (menuWillOpen:): New method.
3717 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3718
3719 * nsterm.m (menu_will_open_state, menu_mouse_point)
3720 (menu_pending_title): New varaibles.
3721 (ns_get_pending_menu_title, ns_check_menu_open)
3722 (ns_check_pending_open_menu): New functions.
3723
781f4782
DA
37242013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3725
3726 * indent.c (current_column_bol_cache): Remove leftover which is not
3727 used in Fmove_to_column any more.
3728 (current_column, scan_for_column): Adjust users.
3729 * keyboard.c (last_point_position_buffer, last_point_position_window):
3730 Remove leftovers which are not used for recording undo any more.
3731 (command_loop_1, syms_of_keyboard): Adjust users.
3732 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3733 redisplay_window any more.
3734 (move_it_to): Adjust user.
3735
1921c31b
JB
37362013-03-29 Juanma Barranquero <lekktu@gmail.com>
3737
3738 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3739 Update dependencies.
3740
717b8bcd
SM
37412013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3742
3743 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3744 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3745 forward references.
3746
e74aeda8
DA
37472013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3748
3749 * window.h (struct window): Replace hchild, vchild and buffer slots
3750 with the only contents slot. This is possible because each valid
3751 window may have either the child window (in vertical or horizontal
3752 combination) or buffer to display (for the leaf window). Using that,
3753 a lof of operations to traverse and/or change window hierarchies may
3754 be simplified. New member horizontal is used to distinguish between
3755 horizontal and vertical combinations of internal windows.
3756 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3757 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3758 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3759 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3760 Use contents slot, not buffer, where appropriate.
3761 (wset_combination): New function.
3762 (wset_buffer): Add eassert.
3763 (Fframe_first_window): Simplify the loop reaching first window.
3764 (Fwindow_buffer): Use WINDOW_LEAF_P.
3765 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3766 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3767 (unshow_buffer): Convert initial debugging check to eassert.
3768 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3769 (make_parent_window, window_resize_check, window_resize_apply)
3770 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3771 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3772 Adjust to match struct window changes.
3773 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3774 (mark_window_cursors_off, count_windows, get_leaf_windows)
3775 (foreach_window_1): Simplify the loop.
3776 * alloc.c (mark_object): Do not check for the leaf window because
3777 internal windows has no glyph matrices anyway.
3778 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3779 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3780 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3781 (build_frame_matrix_from_window_tree, mirror_make_current)
3782 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3783 (update_window_tree, set_window_update_flags): Simplify the loop.
3784 (sync_window_with_frame_matrix_rows): Enforce live window.
3785 Use contents slot, not buffer, where appropriate.
3786 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3787 and WINDOW_HORIZONTAL_COMBINATION_P.
3788 (make_frame_visible_1): Simplify the loop.
3789 Use contents slot, not buffer, where appropriate.
3790 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3791 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3792 (expose_window_tree): Likewise.
3793 Use contents slot, not buffer, where appropriate.
3794 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3795 to avoid deleted windows. Use contents slot instead of buffer.
3796 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3797 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3798 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3799 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3800
121ab1cd
EZ
38012013-03-28 Eli Zaretskii <eliz@gnu.org>
3802
ef454cf7
EZ
3803 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3804 identify the reasons for assertion violations in bug#14062 and
3805 similar ones.
21e930f8
EZ
3806 (Fx_show_tip): Fix compilation error under
3807 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3808
121ab1cd
EZ
3809 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3810 Reported by <rzl24ozi@gmail.com>.
3811
5c89ca24
DA
38122013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3813
3814 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3815 start marker...
562c6ee9
SM
3816 (unwind_with_echo_area_buffer): ...to restore it here.
3817 This is needed to ensure that...
5c89ca24
DA
3818 (redisplay_window): ...both window markers are valid here,
3819 which is verified by eassert.
3820 * editfns.c (save_excursion_save): Do not assume that
3821 selected_window always displays the buffer.
c7f53895
DA
3822 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3823 Fix comment.
5c89ca24 3824
f557c1b1
SM
38252013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3826
3827 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3828 the upcase table.
3829
40693bba 38302013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3831
3832 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3833
c86f791f
EZ
38342013-03-27 Eli Zaretskii <eliz@gnu.org>
3835
3836 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3837 since MinGW's w32api headers do. This avoids compiler warnings.
3838
3839 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3840 if already defined.
3841
c6e72e17
EZ
38422013-03-26 Eli Zaretskii <eliz@gnu.org>
3843
3844 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3845
54e95010
JD
38462013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3847
3848 * gtkutil.c (style_changed_cb): Check if frame is live and an
3849 X frame (Bug#14038).
3850
b88b62de
EZ
38512013-03-26 Eli Zaretskii <eliz@gnu.org>
3852
a18d7de6
EZ
3853 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3854 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3855 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3856 MinGW64.
8f5e14c8
EZ
3857 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3858 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3859
b88b62de
EZ
3860 Fix incompatibilities between MinGW.org and MinGW64 headers.
3861 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3862
3863 * w32.c (REPARSE_DATA_BUFFER): Guard with
3864 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3865
c074e458
JD
38662013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3867
3868 * xterm.c: Include X11/XKBlib.h
3869 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3870
908589fd
AS
38712013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3872
3873 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3874 written backwards.
3875 * blockinput.h (input_blocked_p): Likewise.
3876 * bytecode.c (exec_byte_code): Likewise.
3877 * callproc.c (call_process_kill, call_process_cleanup)
3878 (Fcall_process): Likewise.
3879 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3880 (Fccl_execute_on_string): Likewise.
3881 * character.c (string_escape_byte8): Likewise.
3882 * charset.c (read_hex): Likewise.
3883 * cm.c (calccost): Likewise.
3884 * data.c (cons_to_unsigned): Likewise.
3885 * dired.c (directory_files_internal, file_name_completion):
3886 Likewise.
3887 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3888 (sit_for): Likewise.
3889 * doc.c (Fsubstitute_command_keys): Likewise.
3890 * doprnt.c (doprnt): Likewise.
3891 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3892 * emacsgtkfixed.c: Likewise.
3893 * fileio.c (file_offset, Fwrite_region): Likewise.
3894 * floatfns.c (Fexpt, fmod_float): Likewise.
3895 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3896 Likewise.
3897 * font.c (font_intern_prop): Likewise.
3898 * frame.c (x_set_alpha): Likewise.
3899 * gtkutil.c (get_utf8_string): Likewise.
3900 * indent.c (check_display_width): Likewise.
3901 * intervals.c (create_root_interval, rotate_right, rotate_left)
3902 (split_interval_right, split_interval_left)
3903 (adjust_intervals_for_insertion, delete_node)
3904 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3905 (merge_interval_right, merge_interval_left, copy_intervals)
3906 (set_intervals_multibyte_1): Likewise.
3907 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3908 * keymap.c (Fkey_description): Likewise.
3909 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3910 * lread.c (openp, read_integer, read1, string_to_number):
3911 Likewise.
3912 * menu.c (ensure_menu_items): Likewise.
3913 * minibuf.c (read_minibuf_noninteractive): Likewise.
3914 * print.c (printchar, strout): Likewise.
3915 * process.c (create_process, Faccept_process_output)
3916 (wait_reading_process_output, read_process_output, send_process)
3917 (wait_reading_process_output): Likewise.
3918 * profiler.c (make_log, handle_profiler_signal): Likewise.
3919 * regex.c (re_exec): Likewise.
3920 * regex.h: Likewise.
3921 * search.c (looking_at_1, Freplace_match): Likewise.
3922 * sysdep.c (get_child_status, procfs_ttyname)
3923 (procfs_get_total_memory): Likewise.
3924 * systime.h (EMACS_TIME_VALID_P): Likewise.
3925 * term.c (dissociate_if_controlling_tty): Likewise.
3926 * window.c (get_phys_cursor_glyph): Likewise.
3927 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3928 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3929 Likewise.
3930 * xfns.c (Fx_window_property): Likewise.
3931 * xmenu.c (set_frame_menubar): Likewise.
3932 * xselect.c (x_get_window_property, x_handle_dnd_message):
3933 Likewise.
3934 * xsmfns.c (smc_save_yourself_CB): Likewise.
3935 * xterm.c (x_scroll_bar_set_handle): Likewise.
3936
2bf7d27a
DA
39372013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3938
3939 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3940 to be optional or nil. Adjust comment and convert it to docstring.
3941 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3942 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3943
a9ebfa0b
PE
39442013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 Static checking by GCC 4.8-20130319.
3947 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3948 * process.c (Fset_process_datagram_address)
3949 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3950 * xdisp.c (get_char_face_and_encoding):
3951 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3952 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3953 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3954
4f3576ee
KB
39552013-03-24 Ken Brown <kbrown@cornell.edu>
3956
789b5e9a
KB
3957 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3958 fix compilation on 64-bit Cygwin, where underscores are not
3959 automatically prepended.
3960
4f3576ee
KB
3961 * w32term.c (w32_initialize): Silence compiler warning.
3962
b5b7745f
EZ
39632013-03-23 Eli Zaretskii <eliz@gnu.org>
3964
cdc0d0bd
EZ
3965 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3966 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3967 variables, to save and restore frame dimensions.
3968 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3969 after returning from a 'fullscreen' configuration.
3970 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3971 to avoid races between the main thread and the input thread.
3972
3973 * w32term.h (struct w32_output): New members normal_width,
3974 normal_height, normal_top, normal_left, and prev_fsmode.
3975 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3976 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3977 members of a frame.
3978
b5b7745f
EZ
3979 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3980 'fullscreen' parameter. Always record previous width and height
3981 of the frame, except when switching out of maximized modes, so
3982 that they could be restored correctly, instead of resetting to the
3983 default frame dimensions. Send SC_RESTORE command to the frame,
3984 unless we are going to send SC_MAXIMIZE, to restore the frame
3985 resize hints in the mouse pointer shown by the window manager.
3986 (Bug#14032)
3987
3988 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3989
3990 * lisp.h (get_frame_param): Adjust conditions for prototype
3991 declaration.
3992
a3454eed
KB
39932013-03-22 Ken Brown <kbrown@cornell.edu>
3994
3995 * unexcw.c: Drop unneeded inclusion of w32common.h.
3996 (report_sheap_usage): Declare.
3997 (read_exe_header): Add magic numbers for x86_64.
3998 (fixup_executable): Fix printf format specifier for unsigned long
3999 argument.
4000
5a49b79c
DA
40012013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4002
4003 * frame.h (struct frame): Put menu_bar_window under #ifdef
4004 because this member is not needed when X toolkit is in use.
4005 (fset_menu_bar_window):
4006 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4007 (free_glyphs, update_frame):
4008 * xdisp.c (expose_frame): Likewise.
4009 (display_menu_bar): Likewise. Remove redundant eassert.
4010 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4011 toolkit is in use.
4012
d6723bf7
PE
40132013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4014
7b1123d8
PE
4015 Use functions and constants to manipulate Lisp_Save_Value objects.
4016 This replaces code that used macros and strings and token-pasting.
4017 The change makes the C source a bit easier to follow,
4018 and shrinks the Emacs executable a bit.
4019 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4020 (make_save_value): Change 1st arg from string to enum. All callers
4021 changed.
4022 (INTX): Remove.
4023 (mark_object): Use if, not #if, for GC_MARK_STACK.
4024 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4025 (XSAVE_OBJECT): Now functions, not macros.
4026 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4027 the constant was never used.
4028 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4029 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4030 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4031 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4032 New constants.
4033 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4034 type3 with a single member save_type. All uses changed.
4035 (save_type, set_save_pointer, set_save_integer): New functions.
4036 * print.c (PRINTX): Remove.
4037
d6723bf7
PE
4038 * alloc.c: Remove redundant static declarations.
4039
5f24fa51
DA
40402013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4041
4042 * window.h (struct window): Convert left_col, top_line, total_lines
4043 and total_cols from Lisp_Objects to integers. Adjust comments.
4044 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4045 Remove.
4046 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4047 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4048 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4049 Adjust users where appropriate.
4050
42143acd
DA
40512013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4052
4053 * frame.h (struct frame): Drop resx and resy because the same data is
4054 available from window system-specific output context. Adjust users.
562c6ee9
SM
4055 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4056 New functions to provide defaults when no window system available.
42143acd 4057 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4058 (NUMVAL): Move from xdisp.c.
42143acd
DA
4059 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4060 (Ffont_face_attributes, Fopen_font):
4061 * image.c (gs_load):
4062 * w32font.c (fill_in_logfont):
4063 * xdisp.c (calc_pixel_width_or_height):
4064 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4065 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4066
c0a17406
KH
40672013-03-20 Kenichi Handa <handa@gnu.org>
4068
4069 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4070 to 1 (temporary workaround until a bug related to ASCII
4071 optimization is fixed).
4072
095d384d
DA
40732013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4074
4075 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4076 Signal error if window is not internal. Adjust docstring.
4077 (delete_all_child_windows): Use combination_limit to save the buffer.
4078 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4079 * print.c (syms_of_print): Initialize debugging output not here...
4080 (init_print_once): ...but in a new function here.
4081 * lisp.h (init_print_once): Add prototype.
4082 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4083
748fa866
DA
40842013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4085
4086 * window.c (window_resize_check, window_resize_apply)
4087 (window_from_coordinates, recombine_windows, set_window_buffer)
4088 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4089 (Fsplit_window_internal, Fdelete_window_internal)
4090 (freeze_window_starts): Use bool for booleans.
4091 * window.h (window_frame_coordinates, resize_frame_windows)
4092 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4093
81519fd2
SM
40942013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4095
4096 * dispnew.c (bitch_at_user): Use `user-error'.
4097
6db423a9
KB
40982013-03-17 Ken Brown <kbrown@cornell.edu>
4099
4100 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4101 as return type of image_background. (Bug#13981)
4102 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4103
8f2906f5
JD
41042013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4105
960ce480 4106 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4107 (ns_select): Don't return with result uninitialized.
960ce480 4108
8f2906f5
JD
4109 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4110 and getDirectory.
4111
81519fd2
SM
4112 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4113 New functions.
8f2906f5
JD
4114 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4115 directories. If filename is nil, get directory name (Bug#13932).
4116 Use getFilename and getDirectory.
4117 (getFilename, getDirectory): New methods for EmacsSavePanel and
4118 EmacsOpenPanel.
4119 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4120
cded56c1
PE
41212013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4122
4123 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4124
251e9147 41252013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4126
4127 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4128 (adjust_after_replace): Make it back to static. Delete the third
4129 arg text_at_gap_tail. Cancel the code for handling it.
4130
4131 * coding.h (struct coding_system): New member eol_seen.
4132
4133 * coding.c (detect_ascii): New function.
4134 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4135 when the source bytes are actually scanned. On detecting for
4136 coding_category_utf_8_auto, call detect_ascii instead of scanning
4137 source bytes directly.
4138 (produce_chars): Call insert_from_gap with the new arg 0.
4139 (encode_coding): Likewise.
4140 (decode_coding_gap): Control ASCII optimization by the variable
4141 disable_ascii_optimization instead of #ifndef .. #endif.
4142 Deccode EOL format according to coding->eol_seen.
4143 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4144 variable.
4145
8a44e6d1
KH
4146 * lisp.h (adjust_after_replace): Cancel externing it.
4147 (insert_from_gap): Adjust prototype.
4148
5f795e34
EZ
41492013-03-15 Eli Zaretskii <eliz@gnu.org>
4150
4151 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4152 FULLSCREEN_MAXIMIZED. (Bug#13935)
4153
f258b4be
DA
41542013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4155
4156 * region-cache.c (find_cache_boundary, move_cache_gap)
4157 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4158 Simplify debugging check and convert to eassert. Adjust comment.
4159 (pp_cache): Put under ENABLE_CHECKING.
4160
a5cc4dde
EZ
41612013-03-14 Eli Zaretskii <eliz@gnu.org>
4162
4163 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4164 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4165 and WM_ACTIVATEAPP.
4166 (w32fullscreen_hook): If the frame is visible, reset
4167 f->want_fullscreen flag after changing the frame size. If the
4168 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4169 (Bug#13953)
4170
3fc5e44a
DC
41712013-03-13 Daniel Colascione <dancol@dancol.org>
4172
4173 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4174 too so that these builds can use Cygwin's file conversion
4175 functions. (We've been building and linking cygw32.o all along
4176 and just not using it.)
4177
47d7532e
PE
41782013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4179
4180 File synchronization fixes (Bug#13944).
4181 * Makefile.in (LIB_FDATASYNC): New macro.
4182 (LIBES): Use it.
4183 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4184 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4185 Don't worry about HAVE_FSYNC, since a substitute fsync is
4186 available if the system lacks one.
4187 (Fwrite_regin): Retry fsync if interrupted.
4188
c7ffccaf
EZ
41892013-03-13 Eli Zaretskii <eliz@gnu.org>
4190
4e2df81d 4191 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4192 activated, call w32fullscreen_hook, to make sure the new frame
4193 dimensions are in effect. (Bug#13937)
4194
8a7debc1
DA
41952013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4196
4197 * xdisp.c (init_iterator): Simplify because both character and byte
4198 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4199 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4200 character and byte positions can be obtained from marker.
8a7debc1 4201
7fd8c501
PE
42022013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4203
d9df6f40
PE
4204 Static checking by Sun C 5.12.
4205 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4206 * bytecode.c (exec_byte_code):
4207 * dispnew.c (init_display):
4208 * eval.c (error):
4209 * fileio.c (Fsubstitute_in_file_name):
4210 * keyboard.c (Fevent_convert_list):
4211 * keymap.c (Fsingle_key_description):
4212 * term.c (maybe_fatal, fatal):
4213 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4214 * xsmfns.c (Fhandle_save_session):
4215 Omit unreachable code.
4216 * keymap.c (map_keymap_char_table_item): Cast void * to
4217 a function pointer type; the C Standard requires this.
4218
7fd8c501
PE
4219 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4220 Include <sys/param.h> unconditionally, as that works elsewhere and
4221 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4222 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4223 and FreeBSD now.
4224
a020afb9 4225See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4226
4227;; Local Variables:
4228;; coding: utf-8
aac0c6e3
MR
4229;; End:
4230
ab422c4d 4231 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4232
4233 This file is part of GNU Emacs.
4234
4235 GNU Emacs is free software: you can redistribute it and/or modify
4236 it under the terms of the GNU General Public License as published by
4237 the Free Software Foundation, either version 3 of the License, or
4238 (at your option) any later version.
4239
4240 GNU Emacs is distributed in the hope that it will be useful,
4241 but WITHOUT ANY WARRANTY; without even the implied warranty of
4242 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4243 GNU General Public License for more details.
4244
4245 You should have received a copy of the GNU General Public License
4246 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.