Further image.c compilation warning fixes
[bpt/emacs.git] / src / ChangeLog
CommitLineData
42fe2e88
DA
12013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Fix infinite frame selection loop (Bug#15025).
4 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
5
d39a3da6
EZ
62013-08-15 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (compute_window_start_on_continuation_line): When
9 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
10 to make sure we end up setting the window start at the leftmost
11 visible character of the display line. This avoids funky
12 horizontal shifting because the window start is not kept on the
13 same position. (Bug#15090)
05426239
EZ
14 (next_element_from_display_vector): Support 'box' face attribute
15 in the face definitions of a display vector. (Bug#15099)
d39a3da6 16
6e856b69
LMI
172013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
18
19 * image.c (imagemagick_compute_animated_image): Implement animated
20 images (bug#14700).
995be755
LMI
21 (imagemagick_compute_animated_image): Fix some compilation
22 warnings. Implement a very simple cache to make the animation
23 usable at all, but it should be replaced with a per-image cache.
6e856b69 24
d5a1acfa
DA
252013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
26
27 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
28 to do `for' loops over alist values.
29 * buffer.h (FOR_EACH_BUFFER):
30 * process.c (FOR_EACH_PROCESS): Use it.
31 (handle_child_signal, status_notify, Fget_buffer_process)
32 (kill_buffer_processes): Use FOR_EACH_PROCESS.
33
9c253307
DA
342013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
35
36 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
37 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
38 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
39 to xzalloc and so avoid redundant call to memset.
40 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
41 members because it is allocated with xzalloc and so already zeroed.
42
05e64f9f
KB
432013-08-14 Ken Brown <kbrown@cornell.edu>
44
45 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
46 (Bug#15094).
47
5b71542d
DA
482013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
49
50 Utility function and macro to copy Lisp string to C string.
51 * lisp.h (xlispstrdupa): New macro.
52 (xlispstrdup): New prototype.
53 * alloc.c (xlispstrdup): New function.
54 * callint.c (Fcall_interactively):
55 * fileio.c (Ffile_name_directory, Fexpand_file_name)
56 (Fsubstitute_in_file_name):
57 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
58 * image.c (x_create_bitmap_from_file):
59 * w32term.c (w32_term_init):
60 * xterm.c (x_term_init): Use xlispstrdup.
61
71530c97
LMI
622013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
63
4ce82fb8
LMI
64 * image.c (imagemagick_load_image): Make animated pictures work.
65 There's still some problems with background color settings, though
66 (bug#14700).
67
71530c97
LMI
68 * decompress.c (unwind_decompress): Always restore point.
69
7510a061
XF
702013-08-14 Xue Fuqiao <xfq.free@gmail.com>
71
72 * marker.c (set_marker): Reformat documentation.
73
01c3051f
PE
742013-08-14 Paul Eggert <eggert@cs.ucla.edu>
75
aab1fcdf
PE
76 * xdisp.c (cursor_type_changed): Now static.
77
01c3051f
PE
78 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
79 Use changed. This avoids the need to call xmalloc and for the
80 caller to call xfree, and avoids memory leaks in some situations.
81
2084152a
DA
822013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
83
84 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
85 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
86 (redisplay_window): If window_end_valid is cleared due to non-zero
87 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
88 so do not call to try_cursor_movement for that window.
2084152a 89
02455cb6
DA
902013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
91
92 * window.h (struct window): Convert window_end_pos and
93 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
94 (wset_window_end_pos, wset_window_end_vpos): Remove.
95 * dispnew.c (adjust_glyph_matrix):
96 * window.c (Fwindow_end, replace_window, set_window_buffer)
97 (make_window):
98 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
99 (set_vertical_scroll_bar, redisplay_window, try_window)
100 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
101 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
102 (note_mouse_highlight): Adjust users.
103 (try_cursor_movement): Likewise. Convert old precondition to eassert.
104 Add comment.
105
da5707e8
DA
1062013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
107
108 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
109 * image.c (imagemagick_filename_hint): Use `const char *' and
110 prefer SSDATA to SDATA to avoid warnings.
111
25554267
DA
1122013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
113
114 Cleanup window fringes, margins and scroll bars adjustments.
115 * window.c (set_window_fringes, set_window_margins)
116 (set_window_scroll_bars, apply_window_adjustment): New functions.
117 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
118 (Fset_window_scroll_bars): Use them.
119
38a2c910
DA
1202013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
121
122 * window.h (struct window): Convert scroll_bar_width
123 from Lisp_Object to integer. Adjust comment.
124 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
125 Adjust users.
126 * window.c (wset_scroll_bar_width): Remove.
127 (make_window): Initialize scroll_bar_width.
128 (Fsplit_window_internal): Use direct assignment.
129 (Fset_window_configuration, save_window_save):
130 Convert Lisp_Object to integer and back where appropriate.
131 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
132 bar was actually changed, and mention this in docstring.
133
2d065031
PE
1342013-08-13 Paul Eggert <eggert@cs.ucla.edu>
135
136 * decompress.c: Minor simplifications.
137 (Fzlib_decompress_region): Don't bother verifying
138 that avail_out <= UINT_MAX, as that was confusing.
139 Mention the restriction in a comment instead.
140 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
141
a5bd5abb
JD
1422013-08-13 Jan Djärv <jan.h.d@swipnet.se>
143
144 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
145 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
146
66e7901a
LMI
1472013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
148
149 * image.c (imagemagick_filename_hint): Check for errors in the
150 alist structure.
151
2fa611b7
EZ
1522013-08-13 Eli Zaretskii <eliz@gnu.org>
153
154 * window.c (Fwindow_margins): Return nil when there's no marginal
155 area, as per the documented API.
156
157 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
158 Fmake_vector, as scroll bar's struct members are not all Lisp
159 objects now. This avoids crashes in GC.
160
161 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
162 bool, so its address could be taken.
163
8259030d
LMI
1642013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
165
166 * image.c (imagemagick_filename_hint): New function to possibly
167 apply `image-content-type-suffixes'.
168 (imagemagick_load_image): Use it.
169
866c710e
EZ
1702013-08-13 Eli Zaretskii <eliz@gnu.org>
171
172 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
173 if loading zlib failed.
174
f10490f0
JD
1752013-08-13 Jan Djärv <jan.h.d@swipnet.se>
176
96311be7
JD
177 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
178 2013-08-13 checkin below. Change bool to BOOL, rule is:
179 All Obj-C code uses BOOL, except for interfaces callable from C.
180
f10490f0
JD
181 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
182
c8ae93b0
DA
1832013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
184
185 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
186 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
187 bool instead of BOOL.
188 * w32term.h (struct scroll_bar): Convert fringe_extended_p
189 from Lisp_Object to bitfield. Adjust comment.
190 * w32term.c (x_scroll_bar_create): Adjust user.
191 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
192 * xterm.c (XTset_vertical_scroll_bar): Likewise.
193 Use bool for boolean.
194 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
195 to `unsigned int' when defining a bitfield.
196
53b64418
PE
1972013-08-13 Paul Eggert <eggert@cs.ucla.edu>
198
199 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
200
eeaf9bf3
DA
2012013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
202
203 * window.h (struct window): Convert left_margin_cols and
204 right_margin_cols from Lisp_Objects to integers. Adjust comment.
205 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
206 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
207 Adjust users.
208 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
209 Adjust comment.
210 (showing_window_margins_p, update_window_line, update_frame_1):
211 * fringe.c (draw_fringe_bitmap_1):
212 * xdisp.c (window_box_width): Adjust users.
213 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
214 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
215 Use direct assignment.
216 (Fset_window_configuration, save_window_save, Fwindow_margins):
217 Convert Lisp_Object to integer and back where appropriate.
218 (Fset_window_margins): Adjust user. Return t if any margin
219 was actually changed, and mention this in docstring.
220
956720af
XF
2212013-08-13 Xue Fuqiao <xfq.free@gmail.com>
222
f73f4ce6 223 * syntax.c (forward_word):
956720af
XF
224 * cmds.c (forward_char, backward_char): Mention the optional argument.
225
9e37ee3b
DA
2262013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
227
228 * window.h (struct window): Convert left_fringe_width
229 and right_fringe_width from Lisp_Objects to integers.
230 Adjust comment.
231 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
232 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
233 * window.c (wset_left_fringe_width, wset_right_fringe_width):
234 Remove.
235 (make_window): Initialize new integer fields to -1.
236 (Fsplit_window_internal): Use direct assignment.
237 (Fset_window_configuration, save_window_save): Convert
238 Lisp_Object to integer and back where appropriate.
239 (Fset_window_fringes): Adjust user. Return t if any fringe
240 was actually changed, and mention this in docstring.
241
e4375ca7
DA
2422013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
243
244 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
245 * nsfns.m (x_set_cursor_type):
246 * w32fns.c (x_set_cursor_type):
247 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
248 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 249
a45543bc
DA
2502013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
251
252 * font.c (clear_font_cache): New function, stripped from...
253 (Fclear_font_cache): ...here, which now uses the function
254 above. Adjust comment.
255 * font.h (clear_font_cache): Add prototype.
256 * xfaces.c (clear_face_cache): Use clear_font_cache.
257
ae966a86
DA
2582013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
259
260 * window.c (Fset_window_start): Compare `w', not `window' because
261 `w' might not be equal to `window' after call to decode_live_window.
262
297a545b
PE
2632013-08-12 Paul Eggert <eggert@cs.ucla.edu>
264
265 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
266 This fixes a problem introduced by the Bug#15035 patch
267 when using GPG. Reported by Herbert J. Skuhra.
268
aa942e2b
EZ
2692013-08-12 Eli Zaretskii <eliz@gnu.org>
270
271 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
272 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
273 not yet initialized.
274
7699d09e
LMI
2752013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
276
277 * decompress.c (Fzlib_decompress_region): Support zlib
278 decompression, too, and rename.
279
1d238bc7
PE
2802013-08-12 Paul Eggert <eggert@cs.ucla.edu>
281
282 Minor zlib configuration tweaks.
283 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
284 Don't assume presence of fn_inflateInit2_ zlib internal function.
285
8a44a184
LMI
2862013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
287
288 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
289 include the zlib prefix.
290
594a4307
EZ
2912013-08-12 Eli Zaretskii <eliz@gnu.org>
292
293 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
294 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
295 define static variables that are pointers to zlib functions to be
296 dynamically loaded.
297 (init_zlib_functions) [WINDOWSNT]: New function.
298 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
299 New macros.
300 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
301 macros instead of invoking the zlib functions directly.
302 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
303 Szlib_available_p.
304
d2e113bc
DA
3052013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
306
307 Avoid looping over all frame windows to freeze and unfreeze.
308 * window.h (struct window): Drop frozen_window_start_p.
309 (freeze_window_starts): Drop prototype.
310 * frame.h (struct frame): New frozen_window_starts flag.
311 (FRAME_WINDOWS_FROZEN): New macro.
312 * window.c (freeze_window_start, freeze_window_starts):
313 Remove.
314 (select_window, replace_window): Adjust users.
315 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
316 (window_frozen_p): New function.
317 (redisplay_window): Use it.
318
94fcd171
PE
3192013-08-12 Paul Eggert <eggert@cs.ucla.edu>
320
321 Fix some fd issues when running subprocesses (Bug#15035).
322 Fix bugs that can leak files or file descriptors on errors.
323 Don't unlink open temp files, as that's hard for users to diagnose
324 when things go awry (e.g., temp disk exhausted).
325 Don't bother to lock temp files. Check for invalid recursion.
326 * callproc.c (synch_process_fd): Remove. All uses removed.
327 (synch_process_tempfile): New var or macro.
328 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
329 New constants.
330 (record_kill_process): New arg, the temp name. All callers changed.
331 (delete_temp_file): Now just a simple wrapper around unlink.
332 (call_process_kill): New arg, the call_process_fd array.
333 Close them all. Clear synch_process_pid. Remove the temp file,
334 or arrange for it to be removed.
335 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
336 that's been moved to synch_process_tempfile. Caller changed.
337 Do not remove the tempfile; that's now call_process_kill's
338 responsibility.
339 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
340 call_process_kill; the caller now does that.
341 (call_process_cleanup): Do not close the process fd; that's now
342 call_process_kill's responsibility.
343 (Fcall_process): Implement via new function call_process, which
344 has most of the old body of Fcall_process, but with a different API.
345 (call_process): New function that does not open or close filefd if
346 it is nonnegative. Record which fds need to be closed, and let
347 call_process_kill close (and remove the tempfile, on MSDOS) on error.
348 Signal an error if invoked recursively (could be done via a hook).
349 Simplify creation of the tempfile in the MSDOS case.
350 Don't create the output file until after checking for the executable.
351 Report any failure to open /dev/null.
352 Don't open /dev/null for writing twice; once is enough.
353 Don't create pipe if all output is being discarded or sent to file.
354 Don't worry about setting up the coding system or reading from the
355 pipe if all output is being discarded.
356 Hoist fd_error local into top level, to lessen block nesting.
357 Don't record deleted pid here; now done by Fcall_process_region.
358 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
359 and note its success in synch_process_tempfile.
360 Do not leak resources when child_setup fails.
361 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
362 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
363 (create_temp_file): Now returns open fd, with an additional
364 Lisp_Object * argument to return the name. All callers changed.
365 Do not close the file; rewind it instead, and leave it open for
366 the caller. Do not lock the temp file. Unwind-protect the file
367 and the file-descriptor.
368 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
369 If an asynchrounous process, record it here, not in call_process.
370 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
371 * eval.c (set_unwind_protect): New function.
372 * fileio.c (write_region): New function, generalized from the
373 old Fwrite_region. Do not lock temp files.
374 (Fwrite_region): Use it.
375 * lisp.h (set_unwind_protect, write_region): New decls.
376 * process.c: Include <verify.h>.
377 (make_process): Mark fds as initially closed.
378 (deleted_pid_list): Now a list of pid-filename pairs.
379 All uses changed.
380 (close_process_fd): New function.
381 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
382 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
383 New constants. Verify that their number matches PROCESS_OPEN_FDS.
384 (create_process, create_pty, Fmake_serial_process)
385 (server_accept_connection): Record which fds need to be closed,
386 and let deactivate_process close them.
387 (Fmake_network_process): Do not discard the unwind-protect
388 until it's safe to do so.
389 (deactivate_process): Close the fds opened by create_process etc.
390 (Fprocess_send_eof): Adjust to new way of recording open fds.
391 Report an error if /dev/null can't be opened, instead of aborting.
392 * process.h (PROCESS_OPEN_FDS): New constant.
393 (struct Lisp_Process): New member open_fds.
394 (record_kill_process, record_deleted_pid): Adjust signatures.
395 (record_deleted_pid): Move decl here ...
396 * syswait.h (record_deleted_pid): ... from here.
397
d0e615c3
PE
3982013-08-11 Paul Eggert <eggert@cs.ucla.edu>
399
400 * decompress.c: Fix bugs with large buffers and weird inputs.
401 Tune a bit. Reindent as per usual Emacs style.
402 (BUFFER_SIZE): Remove.
403 (Fdecompress_gzipped_region): Do not mishandle input buffers with
404 more than UINT_MAX bytes. Decompress into the gap instead of into
405 an auto buffer, as this should avoid copying. Return nil if
406 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
407 set immediate_quit; we shouldn't trust zlib code that much.
408
313546eb
LMI
4092013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
410
99a32242
LMI
411 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
412 errors, and really move the gap to where we want it.
413
313546eb
LMI
414 * lisp.h: Include decompress.c support.
415
416 * emacs.c (main): Include decompress.c support.
417
418 * Makefile.in: Include -lz if present.
419
d2d699ac
JD
4202013-08-11 Jan Djärv <jan.h.d@swipnet.se>
421
f90e3ebd
JD
422 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
423 (initWithTitle:): Initialize frame to 0.
424 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
425 (fillWithWidgetValue:frame:): Renamed from
426 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
427
428 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
429 fillWithWidgetValue:frame:
430
423d3b3f
JD
431 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
432 remove memory leak warnings.
433
d2d699ac
JD
434 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
435 (ns_check_menu_open): Handle menu == nil. Remove assignment to
436 menu_pending_title.
437
438 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
439 (x_activate_menubar): Update the whole menu.
440 (trackingNotification:): Call ns_check_menu_open if tracking ends.
441 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
442 current event is not NSSystemDefined (Bug#15001).
443 Call ns_check_menu_open only if trackingMenu is 2.
444 (menuDidClose:): New method, decrease trackingMenu.
445 (fillWithWidgetValue:setDelegate:): New method.
446 (fillWithWidgetValue:): Call the above.
447
448 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
449
7d652d97
PE
4502013-08-11 Paul Eggert <eggert@cs.ucla.edu>
451
452 Omit some unnecessary casts.
453 Many of these go back to the old pre-C89 days, when they may have
454 been needed, but we've been assuming C89 or later for a while now.
455 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
456 (live_float_p, live_misc_p, live_vector_p):
457 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
458 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
459 (defvar_per_buffer):
460 * callint.c (Fcall_interactively):
461 * doc.c (Fsubstitute_command_keys):
462 * filelock.c (get_boot_time):
463 * frame.c (xrdb_get_resource):
464 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
465 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
466 (xg_get_file_name_from_selector, menuitem_destroy_callback)
467 (menuitem_highlight_callback, menu_destroy_callback)
468 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
469 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
470 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
471 (xg_tool_bar_help_callback, tb_size_cb):
472 * image.c (xpm_alloc_color, png_read_from_memory)
473 (png_read_from_file, png_load_body, our_memory_skip_input_data)
474 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
475 (syms_of_image):
476 * keymap.c (describe_map):
477 * nsfns.m (Fns_display_monitor_attributes_list):
478 * nsmenu.m (process_dialog:):
479 * nsterm.m (hold_event):
480 * process.c (wait_reading_process_output):
481 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
482 * scroll.c (do_direct_scrolling, scrolling_1):
483 * termcap.c (tgetent):
484 * window.c (check_window_containing, add_window_to_list)
485 (freeze_window_starts):
486 * xdisp.c (compare_overlay_entries, vmessage):
487 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
488 (x_get_monitor_attributes_xrandr)
489 (Fx_display_monitor_attributes_list, x_display_info_for_name)
490 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
491 * xfont.c (xfont_match, xfont_open):
492 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
493 (menubar_selection_callback, menu_position_func)
494 (popup_selection_callback, create_and_show_popup_menu)
495 (dialog_selection_callback, create_and_show_dialog):
496 * xrdb.c (x_get_string_resource):
497 (main) [TESTRM]:
498 * xsmfns.c (x_session_check_input):
499 * xterm.c (x_draw_glyphless_glyph_string_foreground)
500 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
501 (xaw_jump_callback, xaw_scroll_callback):
502 Omit unnecessary casts.
503
9acc1074
PE
5042013-08-10 Paul Eggert <eggert@cs.ucla.edu>
505
506 Minor string-length refactoring.
507 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
508 * frame.c (make_monitor_attribute_list):
509 Prefer build_string to strlen + make_string.
510
361c0eb8
JD
5112013-08-10 Jan Djärv <jan.h.d@swipnet.se>
512
513 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
514 don't check minor_code (Bug#14417).
515
14ba0822
EZ
5162013-08-09 Eli Zaretskii <eliz@gnu.org>
517
518 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
519 vertical positions instead. This avoids calling MATRIX_ROW with
520 row numbers that are possibly beyond valid limits. (Bug#15064)
521
309f24d1
DA
5222013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
523
524 Use xstrdup and build_unibyte_string where applicable.
525 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
526 * xfns.c (x_window):
527 * xrdb.c (x_get_customization_string):
528 * xterm.c (xim_initialize):
529 * w32fns.c (w32_window): Use xstrdup.
530 (w32_display_monitor_attributes_list):
531 * emacs.c (init_cmdargs):
532 * keyboard.c (PUSH_C_STR):
533 * nsfont.m (nsfont_open):
534 * sysdep.c (system_process_attributes):
535 * w32.c (system_process_attributes):
536 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
537
55902276
EZ
5382013-08-09 Eli Zaretskii <eliz@gnu.org>
539
540 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
541 variables of these types so that GDB would know about them, as aid
542 for debugging fatal exceptions. (Bug#15024) See also
543 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
544 discussions.
545
10bf7f5a
JD
5462013-08-08 Jan Djärv <jan.h.d@swipnet.se>
547
548 * nsterm.m (ns_update_begin): Don't change clip path if it would be
549 larger than the NSWindow (Bug#14934).
550
65620264
DA
5512013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
552
553 Redesign redisplay interface to drop global variable updated_window.
554 Always pass currently updated window as a parameter to update routines.
555 * dispextern.h (updated_window): Remove declaration.
556 (struct redisplay_interface): Pass window parameter to
557 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
558 and after_update_window_hook.
559 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
560 Adjust prototypes.
561 * dispnew.c (updated_window): Remove.
562 (redraw_overlapped_rows, update_marginal_area, update_text_area)
563 (update_window_line): Adjust to match redisplay interface changes.
564 * nsterm.m (ns_update_window_begin, ns_update_window_end)
565 (ns_scroll_run, ns_after_update_window_line):
566 * w32term.c (x_update_window_begin, x_update_window_end)
567 (x_after_update_window_line, x_scroll_run):
568 * xterm.c (x_update_window_begin, x_update_window_end)
569 (x_after_update_window_line, x_scroll_run):
570 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
571 Likewise. Adjust comments where appropriate.
572 (x_cursor_to): Simplify because this is always called during window
573 update (but install debugging check anyway).
574 (expose_window): Check must_be_updated_p flag to see whether this
575 function is called during window update.
576
628fdc56
DA
5772013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
578
579 Do not reset window modification event counters excessively.
580 These leftovers and poor man's tricky methods to catch extra
581 redisplay's attention are no longer needed.
582 * frame.c (set_menu_bar_lines_1):
583 * minibuf.c (read_minibuf_unwind):
584 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
585 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
586 (window_scroll_line_based, Fset_window_configuration):
587 * xdisp.c (redisplay_window): Do not reset last_modified and
588 last_overlay_modified counters.
589
8fd9c92e
JD
5902013-08-07 Jan Djärv <jan.h.d@swipnet.se>
591
592 * xselect.c (x_send_client_event): Set send_event and serial, memset
593 data.l as it might be bigger than data.b. Use 24 bit mask to
594 XSendEvent (Bug#15034).
595
0ee18172
EZ
5962013-08-07 Eli Zaretskii <eliz@gnu.org>
597
598 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
599 for TTY frames that are not the top frame on their console.
600 (Bug#14616)
601
16ddd1a6
MR
6022013-08-07 Martin Rudalics <rudalics@gmx.at>
603
604 * w32term.c (w32fullscreen_hook): Really maximize frame when
605 asked for (Bug#14841).
606
d2a95ffb
DA
6072013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
608
609 Prefer selected_window to Fselected_window, likewise for frames.
610 * buffer.c (Fbuffer_swap_text):
611 * data.c (Fvariable_binding_locus):
612 * window.c (run_window_configuration_change_hook): Adjust users.
613 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
614 Use decode_live_frame.
615
170da1ec
DA
6162013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
617
618 Be more careful if selected window shows the buffer other than current,
619 use window_outdated only if this is not so. This change should also
620 address some weird issues discussed in Bug#13012.
621 * window.h (window_outdated): New prototype.
622 * window.c (window_outdated): Now here. Convert from static and
623 always assume window's buffer.
624 (Fwindow_end, Fwindow_line_height): Use it.
625 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
626 and always assume window's buffer.
627 (redisplay_window): Adjust user.
e5eefe9b 628 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
629 check whether mode line should be updated only if selected window
630 shows current buffer.
631 (run_window_scroll_functions): Use eassert for debugging check.
632 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
633
56b5d5b1
DA
6342013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
635
636 * window.c (window_scroll, window_scroll_pixel_based)
637 (window_scroll_line_based): Use bool for booleans.
638
2878ba7e
PE
6392013-08-06 Paul Eggert <eggert@cs.ucla.edu>
640
641 * process.c: Fix minor off-by-one issues in descriptor counts.
642 This shouldn't fix any real bugs, but it cleans up the code a bit.
643 (max_process_desc, max_input_desc): -1, not 0, means none.
644 All uses changed.
645 (delete_input_desc): New function.
646 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
647 (deactivate_process): Scan backwards when recomuting max_process_desc;
648 that should be faster.
649 (init_process_emacs): Initialize max_input_desc.
650
e30b79c1
DA
6512013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
652
653 Use region cache to speedup bidi_find_paragraph_start.
654 * buffer.h (struct buffer): New member bidi_paragraph_cache.
655 Rename cache_long_line_scans to cache_long_scans.
656 * buffer.c (bset_cache_long_line_scans): Rename to
657 bset_cache_long_scans.
658 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
659 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
660 into account.
661 (syms_of_buffer): Rename cache-long-line-scans to
662 cache-long-scans. Adjust docstring.
663 * search.c (newline_cache_on_off):
664 * indent.c (width_run_cache_on_off): Adjust users.
665 * bidi.c (bidi_paragraph_cache_on_off): New function.
666 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
667 * insdel.c (prepare_to_modify_buffer): Invalidate
668 bidi_paragraph_cache if enabled.
669
00012b86
DA
6702013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
671
672 Invalidate region caches only if buffer text is going to be changed.
673 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
674 (modify_text): ...new prototype.
675 (prepare_to_modify_buffer_1): New prototype.
676 * textprop.c (modify_region): Rename to...
677 (modify_text_properties): ...new function.
678 (add_text_properties_1, set_text_properties, Fremove_text_properties)
679 (Fremove_list_of_text_properties): Adjust users.
680 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
681 (modify_text): ...new function.
682 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
683 (prepare_to_modify_buffer_1): ...new function.
684 * casefiddle.c (casify_region):
685 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
686 (Ftranspose_regions): Use modify_text.
687
dc6c0eda
SM
6882013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
689
690 * lisp.mk (lisp): Add nadvice.elc.
691
8f3a2c26
DA
6922013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
693
694 New macro to iterate over live buffers similar to frames.
695 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
696 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
697 Declare buffer-related variables here to offload lisp.h.
698 * buffer.c (Vbuffer_alist): Adjust comment.
699 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
700 (other_buffer_safely):
701 * data.c (store_symval_forwarding):
702 * dispnew.c (Fframe_or_buffer_changed_p):
703 * fileio.c (Fdo_auto_save):
704 * filelock.c (unlock_all_files):
705 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
706
e0fdb694
PE
7072013-08-04 Paul Eggert <eggert@cs.ucla.edu>
708
709 Fix some minor races in hosts lacking mkostemp (Bug#15015).
710 * callproc.c (create_temp_file):
711 * filelock.c (create_lock_file):
712 Assume mkostemp, since it's now provided by Gnulib.
713
63f5c6c2
EZ
7142013-08-04 Eli Zaretskii <eliz@gnu.org>
715
716 * w32.c (mkostemp): New function.
717 (mktemp): Remove, no longer used. Most of the code reused in
718 mkostemp. (Bug#15015)
484ab239 719 (mktemp): Don't undef.
63f5c6c2 720
f0b79313
DA
7212013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
722
723 * dispnew.c (glyph_matrix_count, glyph_pool_count):
724 Move under GLYPH_DEBUG and ENABLE_CHECKING.
725 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
726 (free_glyph_pool, check_glyph_memory): Likewise for
727 all users. Adjust comments where appropriate.
728
98f638d6
PE
7292013-08-03 Paul Eggert <eggert@cs.ucla.edu>
730
731 * composite.h: Minor fixups.
732 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
733 to fix a misspelling, and change it to an inline function while
734 we're at it (it need not be a macro). All uses changed.
735 (composition_method, composition_valid_p):
736 Rewrite to avoid assignments in if-conditions.
737
75c59fb3
DA
7382013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
739
740 Do not use global Lisp_Object in composition macros.
741 * composite.h (composition_temp): Remove declaration.
742 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
743 (composition_method, composition_valid_p): ...inline functions.
416a3e01 744 (compose_region): Remove the leftover.
75c59fb3
DA
745 * composite.c (composition_temp): Remove.
746 (run_composition_function, update_compositions)
747 (composition_compute_stop_pos, composition_adjust_point)
748 (Ffind_composition_internal):
749 * coding.c (handle_composition_annotation):
750 * xdisp.c (handle_composition_prop, check_point_in_composition):
751 Related users changed.
752
a10c8269
DA
7532013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Drop FRAME_PTR typedef.
756 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
757 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
758 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
759 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
760 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
761 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
762 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
763 All related users changed.
764
a104f656
SM
7652013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
766
767 * eval.c (default_toplevel_binding): New function.
768 (Fdefvar): Use it.
769 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
770 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
771 (syms_of_eval): Export them.
772 * data.c (Fdefault_value): Micro cleanup.
773 * term.c (init_tty): Use "false".
774
4b5c9326
DA
7752013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
776
777 Fix X GC leak in GTK and raw (no toolkit) X ports.
778 * xterm.c (x_free_frame_resources): If white and black relief
779 GCs are allocated, always free them here.
780 * xfns.c (x_make_gc): Omit redundant initialization.
781 * widget.c (create_frame_gcs): Remove the leftover.
782 (EmacsFrameDestroy): Do nothing because all GCs are now freed
783 in x_free_frame_resources.
784
b19aa636
JD
7852013-08-02 Jan Djärv <jan.h.d@swipnet.se>
786
787 * nsterm.m (windowWillResize:toSize:): Only change title if
788 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
789 modifying it.
790 (viewDidEndLiveResize): New method.
791
792 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
793 inside NS_IMPL_COCOA.
794
af1f7e06
DA
7952013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
796
797 * insdel.c (adjust_after_replace, replace_range, del_range_2):
798 Do not check whether undo is enabled because record_insert and
799 record_delete does that themselves.
800
65b02bb9
DA
8012013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
802
803 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
804 member which is not really used any more.
805 (FRAME_XIC_BASE_FONTNAME): Remove.
806 * xfns.c (xic_free_fontset): Adjust user.
807 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
808 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
809 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
810 (xdialog_show): Use eassert for debugging check.
7ee0f047 811 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 812
6318cde0
PE
8132013-08-01 Paul Eggert <eggert@cs.ucla.edu>
814
815 * fileio.c, fns.c (merge): Move extern decl from here ...
816 * lisp.h (merge): ... to here.
817
6c1a09ba
DA
8182013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
819
820 Fix last font-related change.
821 * w32font.h (w32font_list_internal, w32font_match_internal):
822 Fix prototype.
823 * w32uniscribe.c (uniscribe_list, uniscribe_match):
824 (uniscribe_list_family): Adjust to match font API change.
825 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
826 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
827
f8c20208
DA
8282013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
829
830 * frame.h (FRAME_MOUSE_UPDATE):
831 * nsterm.m (ns_frame_up_to_date): Omit redundant check
832 whether hlinfo->mouse_face_mouse_frame is non-NULL.
833
fdb396e2
DA
8342013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
835
836 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
837 * font.h (struct font_driver): Change list, match, and list_family
838 functions to accept struct frame * as first arg.
839 * font.c (font_score, font_compare, font_sort_entities): Remove
840 prototypes.
841 (font_sort_entities, font_list_entities, font_select_entity):
842 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
843 match font API change.
844 * xfont.c (xfont_list, xfont_match, xfont_list_family):
845 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
846 * ftxfont.c (ftxfont_list, ftxfont_match):
847 * xftfont.c (xftfont_list, xftfont_match):
848 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
849 * w32font.c (w32font_list, w32font_match, w32font_list):
850 (w32font_list_internal, w32_font_match_internal): Likewise.
851 * xfaces.c (Fx_family_fonts): Adjust user.
852
52b8a085
DA
8532013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
854
855 Do not use pure Xism x_wm_set_icon_position in non-X ports.
856 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
857 only if HAVE_X_WINDOWS is in use.
858 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
859 * nsterm.m (x_wm_set_icon_position): Remove no-op.
860 * w32term.c (x_wm_set_icon_position): Likewise.
861 * w32fns.c (x_icon): Adjust user.
862
c791c18e
DA
8632013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
864
865 * xterm.c (last_mouse_press_frame): Remove the
866 leftover which is not really used any more.
867 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
868 (x_flush): Call XFlush once per each X display, not frame.
869 This is better because this code always unconditionally skips
870 non-X frames in Vframe_list and issues the only XFlush if we
871 have more than one X frame on the same X display.
2f935d86
DA
872 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
873 Use bool for booleans.
874 (x_draw_glyph_string_background, cvt_string_to_pixel):
875 (cvt_pixel_dtor): Drop unnecessary prototypes.
876 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 877
f435830e
DA
8782013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
879
880 Drop unnecessary functions that deals with frame pixel size.
881 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
882 (x_pixel_height): Drop prototypes.
883 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
884 (x_pixel_height): Drop implementations.
885 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
886 which should be always valid for window frame.
887 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
888 * w32menu.c (Fx_popup_dialog):
889 * xmenu.c (Fx_popup_dialog): Likewise for both.
890
84231434
DA
8912013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
892
893 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
894 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
895 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
896 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
897 and mention nil frame in docstring.
84231434 898
959067a1
DA
8992013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
900
901 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
902 (x_figure_window_size): Likewise. Adjust to return long.
903 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
904 (toplevel): Move Qterminal_live_p to...
905 * terminal.c (toplevel): ...here, make it static, and...
906 (syms_of_terminal): ...DEFSYM here.
907 * frame.h (Qterminal_live_p): Remove declaration.
908 (make_frame, x_figure_window_size): Adjust prototype.
909 * nsfns.m (Fx_create_frame): Use long for window flags.
910
f4b169ce
PE
9112013-07-30 Paul Eggert <eggert@cs.ucla.edu>
912
913 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
914 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
915 Do not assume that emacs_close (INT_MAX) is a no-op.
916
bee6a2c7
DA
9172013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
918
919 * xfaces.c (make_face_cache): For struct face_cache, prefer
920 xmalloc to xzalloc and so avoid redundant call to memset.
921 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
922
d7e6881a
DA
9232013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
924
925 * fringe.c (draw_window_fringes, update_window_fringes)
926 (compute_fringe_widths):
927 * w32term.c (x_draw_glyph_string):
928 * window.c (candidate_window_p, Frecenter):
929 * xfaces.c (realize_basic_faces, realize_default_face)
930 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
931 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
932 * xfns.c (x_set_cursor_color, xic_free_xfontset):
933 * xmenu.c (Fx_menu_bar_open_internal):
934 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
935 * xsettings.c (xft_settings_event):
936 * xterm.c (x_draw_glyph_string, x_had_errors_p):
937 Use bool for booleans. Adjust style and comments where
938 appropriate.
939 * dispextern.h (draw_window_fringes, update_window_fringes)
940 (compute_fringe_widths):
941 * xterm.h (x_had_errors_p): Adjust prototype.
942
ec3058af
DA
9432013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
944
945 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
946 CHECK_LIST. Rewrite the loop to avoid useless local variable.
947
218e0637
DA
9482013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
949
950 * fns.c (toplevel): Remove comment before Fsafe_length because
951 it checks for QUIT.
952
e560aba9
PE
9532013-07-28 Paul Eggert <eggert@cs.ucla.edu>
954
955 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
956
2e5ce5de
EZ
9572013-07-28 Eli Zaretskii <eliz@gnu.org>
958
959 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
960 frame which got the message is still alive, before dereferencing
961 its pointer. (Bug#14970)
962
963 * frame.c (delete_frame): Test "this" frame's minibuffer window to
964 be a live window, before using it as such. (Bug#14970)
965
e95da6d3
EZ
9662013-07-27 Eli Zaretskii <eliz@gnu.org>
967
968 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
969 w32_detect_focus_change instead of doing part of its job by hand.
970 This fixes the problem whereby FOCUS_OUT events were not sent to
971 the event queue.
972
a8f93651
EZ
9732013-07-26 Eli Zaretskii <eliz@gnu.org>
974
fec92060
EZ
975 * process.c (Fprocess_list): Doc fix.
976
a8f93651
EZ
977 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
978 being re-exposed only if it didn't ask to become visible.
979 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
980 was previously iconified. (Bug#14841)
981 (x_iconify_frame): Mark the frame iconified.
982
d5a7a9d9
PE
9832013-07-26 Paul Eggert <eggert@cs.ucla.edu>
984
985 Fix minor problems found by static checking.
986 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
987 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
988
56ea7291
SM
9892013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
990
991 * eval.c (set_specpdl_old_value): New function.
992 (unbind_to): Minor simplification.
993 (get_backtrace_frame): New function.
994 (Fbacktrace_frame): Use it. Add `base' argument.
995 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
996 (syms_of_eval): Export backtrace-eval.
997 * xterm.c (x_focus_changed): Simplify.
998
9d611ffe
PE
9992013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1000
1001 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1002
999c74e3
EZ
10032013-07-24 Eli Zaretskii <eliz@gnu.org>
1004
1005 * xdisp.c (redisplay_window): Instead of moving point out of
1006 scroll margin, reject the force_start method, and try scrolling
1007 instead. (Bug#14780)
1008
198fa217
KB
10092013-07-24 Ken Brown <kbrown@cornell.edu>
1010
1011 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1012 (Bug#14944).
1013
53840e55
PE
10142013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1015
1016 * eval.c (Fprogn): Do not check that BODY is a proper list.
1017 This undoes the previous change. The check slows down the
1018 interpreter, and is not needed to prevent a crash. See
1019 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1020
60967f56
GM
10212013-07-23 Glenn Morris <rgm@gnu.org>
1022
1023 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1024
9ca960e2
PE
10252013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1026
a29c3e6d
PE
1027 Port to GNU/Linux systems with tinfo but not ncurses.
1028 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1029 to decide whether ncurses is being used. Without this change,
1030 GCC complains about tgetent not being declared, on a system
1031 that has tinfo installed but ncurses not installed.
1032
f274311c
PE
1033 * eval.c (Fprogn): Check that BODY is a proper list.
1034
16b0520a
PE
1035 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1036 * data.c (Fsetq_default):
1037 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1038 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1039 (Fcondition_case):
1040 Tune by taking advantage of the fact that ARGS is always a list
1041 when a function is declared to have UNEVALLED args.
1042
9ca960e2
PE
1043 * emacsgtkfixed.c: Port to GCC 4.6.
1044 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1045
afacaa1b
JB
10462013-07-23 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1049 here to silence compiler warnings.
1050
368a85a4
PE
10512013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1052
1053 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1054 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1055 from messing up Emacs's 'struct frame' (Bug#14923).
1056
f4e891b5
PE
10572013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 * alloc.c (make_save_ptr_ptr): Define this function.
1060 It was inadvertently omitted. It's needed only if
1061 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1062
96c8b65e
JD
10632013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1064
1065 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1066 frame have focus (Bug#14895).
1067
ee010797
PE
10682013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 Avoid vfork-related deadlock more cleanly.
1071 * callproc.c (child_setup): When the child's exec fails, output
1072 the program name, as that's more useful. Use O_NONBLOCK to avoid
1073 deadlock.
1074 * process.c (create_process_1): Remove; no longer needed.
1075 (create_process): Remove timer hack; no longer needed, now that
1076 the child avoids deadlock.
1077
f0398ec1 10782013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1079
1080 * image.c (Fimage_flush): Fix doc typo.
1081
b2a069c2
PE
10822013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1083
6496aec9
PE
1084 Fix array bounds violation when pty allocation fails.
1085 * process.c (PTY_NAME_SIZE): New constant.
1086 (pty_name): Remove static variable; it's now auto.
1087 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1088 Take pty_name as an arg rather than using a static variable.
1089 All callers changed.
1090 (create_process): Recover pty_flag from process, not from volatile local.
1091 (create_pty): Stay inside array even when pty allocation fails.
1092 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1093
b2a069c2
PE
1094 * lread.c (Fload): Avoid initialization only when lint checking.
1095 Mention that it's needed only for older GCCs.
1096
99107004
KH
10972013-07-20 Kenichi Handa <handa@gnu.org>
1098
1099 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1100 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1101
6b1b199d
AS
11022013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1103
1104 * lread.c (Fload): Avoid uninitialized warning.
1105
4195afc3
PE
11062013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1107
3f5bef16
PE
1108 Fix some minor file descriptor leaks and related glitches.
1109 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1110 (create_lock_file): Use write, not emacs_write.
1111 * image.c (slurp_file, png_load_body):
1112 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1113 (server_accept_connection):
1114 Don't leak an fd on memory allocation failure.
1115 * image.c (slurp_file): Add a cheap heuristic for growing files.
1116 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1117 as that's what the other routines do. Maybe input need not be
1118 blocked at all, but it's better to be consistent.
1119 Avoid undefined behavior when strlen is zero.
1120
4195afc3
PE
1121 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1122 (NSTATICS): Now a constant; doesn't need to be a macro.
1123
a1aeeffe
RS
11242013-07-19 Richard Stallman <rms@gnu.org>
1125
1126 * coding.c (decode_coding_utf_8): Add simple loop for fast
1127 processing of ASCII characters.
1128
63b34baa
PE
11292013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1132
621dd9ac
EZ
11332013-07-19 Eli Zaretskii <eliz@gnu.org>
1134
1135 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1136 unportable 'struct x_display_info'.
1137 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1138 is a portable type.
1139
1396ac86
PE
11402013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1141
ab9980cd
PE
1142 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1143 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1144 or fscanf fails.
1145 (system_process_attributes): Prefer plain char to unsigned char
1146 when either will do. Clean up properly if interrupted or if
1147 memory allocations fail. Don't assume sscanf succeeds. Remove
1148 no-longer-needed workaround to stop GCC from whining. Read
1149 command-line once, instead of multiple times. Check read status a
1150 bit more carefully.
1151
1396ac86
PE
1152 Fix obscure porting bug with varargs functions.
1153 The code assumed that int is treated like ptrdiff_t in a vararg
1154 function, which is not a portable assumption. There was a similar
1155 -- though these days less likely -- porting problem with various
1156 assumptions that pointers of different types all smell the same as
1157 far as vararg functions is conserved. To make this problem less
1158 likely in the future, redo the API to use varargs functions.
1159 * alloc.c (make_save_value): Remove this vararg function.
1160 All uses changed to ...
1161 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1162 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1163 New functions.
1164 (make_save_ptr): Rename from make_save_pointer, for consistency with
1165 the above. Define only on platforms that need it. All uses changed.
1166
4d19d194
PE
11672013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 * keyboard.c: Try to fix typos in previous change.
1170 (DISPLAY_LIST_INFO): New macro.
1171 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1172 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1173
945c5bb1
JB
11742013-07-18 Juanma Barranquero <lekktu@gmail.com>
1175
1176 * keyboard.c (kbd_buffer_get_event):
1177 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1178 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1179
f4b1eb36
PE
11802013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1181
5e679a2c
PE
1182 * filelock.c: Fix unlikely file descriptor leaks.
1183 (get_boot_time_1): Rework to avoid using emacs_open.
1184 This doesn't actually fix a leak, but is better anyway.
1185 (read_lock_data): Use read, not emacs_read.
1186
a8cd4836
PE
1187 * doc.c: Fix minor memory and file descriptor leaks.
1188 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1189 (get_doc_string, Fsnarf_documentation):
1190 Fix file descriptor leak on error.
1191
ef30e638
PE
1192 * term.c: Fix minor fdopen-related file descriptor leaks.
1193 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1194 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1195
f4b1eb36
PE
1196 * charset.c: Fix file descriptor leaks and errno issues.
1197 Include <errno.h>.
1198 (load_charset_map_from_file): Don't leak file descriptor on error.
1199 Use plain record_xmalloc since the allocation is larger than
1200 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1201 of entries.
1202 * eval.c (record_unwind_protect_nothing):
1203 * fileio.c (fclose_unwind):
1204 New functions.
1205 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1206 The replacement doesn't block input, but that no longer seems
1207 necessary.
1208
b648c163
PE
12092013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1210
a0931322
PE
1211 * lread.c: Fix file descriptor leaks and errno issues.
1212 (Fload): Close some races that leaked fds or streams when 'load'
1213 was interrupted.
1214 (Fload, openp): Report error number of last nontrivial failure to open.
1215 ENOENT counts as trivial.
1216 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1217 New functions.
1218 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1219 now that the function is always called with a nonnegative arg.
1220 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1221 All uses replaced with ...
1222 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1223
b648c163
PE
1224 A few more minor file errno-reporting bugs.
1225 * callproc.c (Fcall_process):
1226 * doc.c (Fsnarf_documentation):
1227 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1228 * process.c (set_socket_option):
1229 Don't let a constructor trash errno.
1230 * doc.c: Include <errno.h>.
1231
b1dc4084
JB
12322013-07-16 Juanma Barranquero <lekktu@gmail.com>
1233
1234 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1235
c43843aa
PE
12362013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1237
50a30cce
PE
1238 Fix w32 bug with call-process-region (Bug#14885).
1239 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1240 to Fcall_process when the input is empty. This simplifies the
1241 code a bit. It makes no difference on POSIXish platforms but
1242 apparently it fixes a bug on w32.
1243
44e18199 1244 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1245 * fileio.c (close_file_unwind): Don't close if FD is negative;
1246 this can happen when unwinding a zapped file descriptor.
1247 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1248 in case Emacs runs out of memory between the two unwind-protects.
1249 Don't trash errno when closing FD.
1250 Zap the FD in the specpdl when closing it, instead of deferring
1251 the removal of the unwind-protect; this fixes a bug where a child
1252 function unwinds the stack past us.
1253
27e498e6
PE
1254 New unwind-protect flavors to better type-check C callbacks.
1255 This also lessens the need to write wrappers for callbacks,
1256 and the need for make_save_pointer.
1257 * alloca.c (free_save_value):
1258 * atimer.c (run_all_atimers):
1259 Now extern.
1260 * alloc.c (safe_alloca_unwind):
1261 * atimer.c (unwind_stop_other_atimers):
1262 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1263 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1264 * minibuf.c (choose_minibuf_frame_1):
1265 * process.c (make_serial_process_unwind):
1266 * xdisp.h (pop_message_unwind):
1267 * xselect.c (queue_selection_requests_unwind):
1268 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1269 * alloca.c (record_xmalloc):
1270 Prefer record_unwind_protect_ptr to record_unwind_protect with
1271 make_save_pointer.
1272 * alloca.c (Fgarbage_collect):
1273 Prefer record_unwind_protect_void to passing a dummy.
1274 * buffer.c (restore_buffer):
1275 * window.c (restore_window_configuration):
1276 * xfns.c, w32fns.c (do_unwind_create_frame)
1277 New wrapper. All record-unwind uses of wrappee changed.
1278 * buffer.c (set_buffer_if_live):
1279 * callproc.c (call_process_cleanup, delete_temp_file):
1280 * coding.c (code_conversion_restore):
1281 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1282 * editfns.c (save_excursion_restore)
1283 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1284 (save_restriction_restore):
1285 * eval.c (restore_stack_limits, un_autoload):
1286 * fns.c (require_unwind):
1287 * keyboard.c (recursive_edit_unwind, tracking_off):
1288 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1289 * macros.c (pop_kbd_macro, restore_menu_items):
1290 * nsfns.m (unwind_create_frame):
1291 * print.c (print_unwind):
1292 * process.c (start_process_unwind):
1293 * search.c (unwind_set_match_data):
1294 * window.c (select_window_norecord, select_frame_norecord):
1295 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1296 (fast_set_selected_frame):
1297 * xfns.c, w32fns.c (unwind_create_tip_frame):
1298 Return void, not a dummy Lisp_Object. All uses changed.
1299 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1300 * callproc.c (call_process_kill):
1301 * fileio.c (restore_point_unwind, decide_coding_unwind)
1302 (build_annotations_unwind):
1303 * insdel.c (Fcombine_after_change_execute_1):
1304 * keyboard.c (read_char_help_form_unwind):
1305 * menu.c (unuse_menu_items):
1306 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1307 * sound.c (sound_cleanup):
1308 * xdisp.c (unwind_redisplay):
1309 * xfns.c (clean_up_dialog):
1310 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1311 Accept no args and return void, instead of accepting and returning
1312 a dummy Lisp_Object. All uses changed.
1313 * cygw32.c (fchdir_unwind):
1314 * fileio.c (close_file_unwind):
1315 * keyboard.c (restore_kboard_configuration):
1316 * lread.c (readevalllop_1):
1317 * process.c (wait_reading_process_output_unwind):
1318 Accept int and return void, rather than accepting an Emacs integer
1319 and returning a dummy object. In some cases this fixes an
1320 unlikely bug when the corresponding int is outside Emacs integer
1321 range. All uses changed.
1322 * dired.c (directory_files_internal_unwind):
1323 * fileio.c (do_auto_save_unwind):
1324 * gtkutil.c (pop_down_dialog):
1325 * insdel.c (reset_var_on_error):
1326 * lread.c (load_unwind):
1327 * xfns.c (clean_up_file_dialog):
1328 * xmenu.c, nsmenu.m (pop_down_menu):
1329 * xmenu.c (cleanup_widget_value_tree):
1330 * xselect.c (wait_for_property_change_unwind):
1331 Accept pointer and return void, rather than accepting an Emacs
1332 save value encapsulating the pointer and returning a dummy object.
1333 All uses changed.
1334 * editfns.c (Fformat): Update the saved pointer directly via
1335 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1336 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1337 (unwind_body): New function.
1338 (record_unwind_protect): First arg is now a function returning void,
1339 not a dummy Lisp_Object.
1340 (record_unwind_protect_ptr, record_unwind_protect_int)
1341 (record_unwind_protect_void): New functions.
1342 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1343 * fileio.c (struct auto_save_unwind): New type.
1344 (do_auto_save_unwind): Use it.
1345 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1346 * insdel.c (struct rvoe_arg): New type.
1347 (reset_var_on_error): Use it.
1348 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1349 New constants.
1350 (specbinding_func): Remove; there are now several such functions.
1351 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1352 (set_unwind_protect_ptr): New function.
1353 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1354
4e604a5d
PE
1355 Be simpler and more consistent about reporting I/O errors.
1356 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1357 Say "Read error" and "Write error", rather than "I/O error", or
1358 "IO error reading", or "IO error writing", when a read or write
1359 error occurs.
1360 * process.c (Fmake_network_process, wait_reading_process_output)
1361 (send_process, Fprocess_send_eof, wait_reading_process_output):
1362 Capitalize diagnostics consistently. Put "failed foo" at the
1363 start of the diagnostic, so that we don't capitalize the
1364 function name "foo". Consistently say "failed" for such
1365 diagnostics.
1366 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1367 All callers changed. This is so it can use report_file_error.
1368 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1369 diagnostics consistently as above.
1370
a9757f6a
PE
1371 * fileio.c (report_file_errno): Fix errno reporting bug.
1372 If the file name is neither null nor a pair, package it up as a
1373 singleton list. All callers changed, both to this function and to
1374 report_file_error. This fixes a bug where the memory allocator
1375 invoked by list1 set errno so that the immediately following
1376 report_file_error reported the wrong errno value.
1377
c43843aa
PE
1378 Fix minor problems found by --enable-gcc-warnings.
1379 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1380 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1381
18c26d81
JD
13822013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1383
1384 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1385 Set event->arg to Qt if switch-event shall be generated.
1386 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1387
1388 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1389
1390 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1391 FOCUS_OUT_EVENT.
1392
1393 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1394 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1395 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1396 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1397 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1398 and there is a focused frame.
1399 (head_table): Add focus-in and focus-out.
1400 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1401 bind to handle-focus-in/out.
1402
1403 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1404 (Fhandle_switch_frame): Call Fhandle_focus_in.
1405 (syms_of_frame): defsubr handle-focus-in/out.
1406
6c6f1994
PE
14072013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1408
c7ddc792
PE
1409 Fix porting bug to older POSIXish platforms (Bug#14862).
1410 * sysdep.c (emacs_pipe): New function, that implements
1411 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1412 This should port better to CentOS 5 and to Mac OS X 10.6.
1413 All calls to pipe2 changed.
1414
6c6f1994
PE
1415 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1416 This makes the code easier to read and the executable a bit smaller.
1417 Do not replace all calls to Fcons that happen to create lists,
1418 just calls that are intended to create lists. For example, when
1419 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1420 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1421 Similarly for list2 through list5.
1422 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1423 * bytecode.c (exec_byte_code):
1424 * callint.c (quotify_arg, Fcall_interactively):
1425 * callproc.c (Fcall_process, create_temp_file):
1426 * charset.c (load_charset_map_from_file)
1427 (Fdefine_charset_internal, init_charset):
1428 * coding.c (get_translation_table, detect_coding_system)
1429 (Fcheck_coding_systems_region)
1430 (Fset_terminal_coding_system_internal)
1431 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1432 * composite.c (update_compositions, Ffind_composition_internal):
1433 * dired.c (directory_files_internal, file_name_completion)
1434 (Fsystem_users):
1435 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1436 * doc.c (Fsnarf_documentation):
1437 * editfns.c (Fmessage_box):
1438 * emacs.c (main):
1439 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1440 (Feval, eval_sub, Ffuncall, apply_lambda):
1441 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1442 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1443 (Fset_file_times, Finsert_file_contents)
1444 (Fchoose_write_coding_system, Fwrite_region):
1445 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1446 * font.c (font_registry_charsets, font_parse_fcname)
1447 (font_prepare_cache, font_update_drivers, Flist_fonts):
1448 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1449 * frame.c (make_frame, Fmake_terminal_frame)
1450 (x_set_frame_parameters, x_report_frame_params)
1451 (x_default_parameter, Fx_parse_geometry):
1452 * ftfont.c (syms_of_ftfont):
1453 * image.c (gif_load):
1454 * keyboard.c (command_loop_1):
1455 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1456 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1457 (Fminor_mode_key_binding, accessible_keymaps_1)
1458 (Faccessible_keymaps, Fwhere_is_internal):
1459 * lread.c (read_emacs_mule_char):
1460 * menu.c (find_and_return_menu_selection):
1461 * minibuf.c (get_minibuffer):
1462 * nsfns.m (Fns_perform_service):
1463 * nsfont.m (ns_script_to_charset):
1464 * nsmenu.m (ns_popup_dialog):
1465 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1466 (Fx_own_selection_internal):
1467 * nsterm.m (append2):
1468 * print.c (Fredirect_debugging_output)
1469 (print_prune_string_charset):
1470 * process.c (Fdelete_process, Fprocess_contact)
1471 (Fformat_network_address, set_socket_option)
1472 (read_and_dispose_of_process_output, write_queue_push)
1473 (send_process, exec_sentinel):
1474 * sound.c (Fplay_sound_internal):
1475 * textprop.c (validate_plist, add_properties)
1476 (Fput_text_property, Fadd_face_text_property)
1477 (copy_text_properties, text_property_list, syms_of_textprop):
1478 * unexaix.c (report_error):
1479 * unexcoff.c (report_error):
1480 * unexsol.c (unexec):
1481 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1482 (Fformat_mode_line, syms_of_xdisp):
1483 * xfaces.c (set_font_frame_param)
1484 (Finternal_lisp_face_attribute_values)
1485 (Finternal_merge_in_global_face, syms_of_xfaces):
1486 * xfns.c (x_default_scroll_bar_color_parameter)
1487 (x_default_font_parameter, x_create_tip_frame):
1488 * xfont.c (xfont_supported_scripts):
1489 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1490 (menu_help_callback, xmenu_show):
1491 * xml.c (make_dom):
1492 * xterm.c (set_wm_state):
1493 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1494 and similarly for list2 through list5.
1495
bafe80ce
PE
14962013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * callproc.c (Fcall_process_region): Fix minor race and tune.
1499 (create_temp_file): New function, with the temp-file-creation part
1500 of the old Fcall_process_region. Use Fcopy_sequence to create the
1501 temp file name, rather than alloca + build_string, for simplicity.
1502 Don't bother to block input around the temp file creation;
1503 shouldn't be needed. Simplify use of mktemp. Use
1504 record_unwind_protect immediately after creating the temp file;
1505 this closes an unlikely race where the temp file was not removed.
1506 Use memcpy rather than an open-coded loop.
1507 (Fcall_process_region): Use the new function. If the input is
1508 empty, redirect from /dev/null rather than from a newly created
1509 empty temp file; this avoids unnecessary file system traffic.
1510
4700b5a5
PE
15112013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1512
5c97beae
PE
1513 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1514 Simplify by making this case like the other two. This is a bit
1515 slower on obsolete hosts, but the extra complexity isn't worth it.
1516
4700b5a5
PE
1517 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1518 * process.c (create_process) [!DOS_NT]:
1519 Remove now-unnecessary calls to emacs_close.
1520
f9a74c4c
EZ
15212013-07-13 Eli Zaretskii <eliz@gnu.org>
1522
922ae7ee
EZ
1523 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1524 returning early. (Bug#14850)
1525
f9a74c4c
EZ
1526 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1527 and inhibit-iso-escape-detection attributes of 'undecided'.
1528 (Bug#14822)
1529
5e301d76
PE
15302013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1531
69e0e5ee
PE
1532 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1533 Reported by Herbert J. Skuhra in
1534 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1535
5e301d76
PE
1536 Don't lose top specpdl entry when memory is exhausted.
1537 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1538 specpdl overflow here, to simplify callers; all callers changed.
1539 Always reserve an unused entry at the stack top; this avoids
1540 losing the top entry's information when memory is exhausted.
1541
7e649856
PE
15422013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1543
a773ed9a
PE
1544 Clean up errno reporting and fix some errno-reporting bugs.
1545 * callproc.c (Fcall_process):
1546 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1547 * process.c (create_process, Fmake_network_process):
1548 * unexaix.c (report_error):
1549 * unexcoff.c (report_error):
1550 Be more careful about reporting the errno of failed operations.
1551 The code previously reported the wrong errno sometimes.
1552 Also, prefer report_file_errno to setting errno + report_file_error.
1553 (Fcall_process): Look at openp return value rather than at path,
1554 as that's a bit faster and clearer when there's a numeric predicate.
1555 * fileio.c (report_file_errno): New function, with most of the
1556 old contents of report_file_error.
1557 (report_file_error): Use it.
1558 (Ffile_exists_p, Ffile_accessible_directory_p):
1559 Set errno to 0 when it is junk.
1560 * fileio.c (Faccess_file):
1561 * image.c (x_create_bitmap_from_file):
1562 Use faccessat rather than opening the file, to avoid the hassle of
1563 having a file descriptor open.
1564 * lisp.h (report_file_errno): New decl.
1565 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1566
7e649856
PE
1567 Minor EBADF fixes.
1568 * process.c (create_process, wait_reading_process_output) [AIX]:
1569 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1570 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1571 a multithreaded environment anyway).
1572 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1573
f6774c1a
AS
15742013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1575
1576 * image.c (x_find_image_file): Don't close a remote file handle.
1577
bacba3c2
PE
15782013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 Fix races with threads and file descriptors.
1581 * callproc.c (Fcall_process_region):
1582 * dired.c (open_directory):
1583 * emacs.c (main, Fdaemon_initialized):
1584 * image.c (x_find_image_file):
1585 * inotify.c (Finotify_rm_watch):
1586 * lread.c (Flocate_file_internal):
1587 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1588 * term.c (term_mouse_moveto, init_tty):
1589 * termcap.c (tgetent):
1590 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1591 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1592 * unexhp9k800.c, unexmacosx.c (unexec):
1593 * callproc.c (Fcall_process_region):
1594 Use emacs_close, not close.
1595 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1596 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1597 and posix_close function on current platforms (which all lack them).
1598 (emacs_close): Use it. This should fix the races on GNU/Linux and
1599 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1600 and it should avoid closing random victim file descriptors on
1601 other platforms.
1602
653d4f43
PE
16032013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1604
c8536ec4
PE
1605 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1606 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1607 Touch up doc a bit.
1608
9c203066
PE
1609 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1610 This is for .gdbinit xbacktrace.
1611
653d4f43
PE
1612 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1613 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1614 (emacs_set_tty): Now static.
1615 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1616 * term.c (tty_capable_p, tty_default_color_capabilities)
1617 (get_tty_terminal, term_mouse_movement)
1618 (handle_one_term_event, init_tty, maybe_fatal):
1619 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1620 (tgetent, scan_file, name_match, compare_contin):
1621 * terminal.c (get_terminal):
1622 Use bool for boolean.
1623 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1624 Prefer char to unsigned char if either will do.
1625 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1626 (tty_write_glyphs): Prefer int to unsigned.
1627 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1628 All callers changed.
1629 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1630
45b683a1
PE
16312013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1632
29abe551
PE
1633 Port to C89.
1634 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1635 (B__dummy__): New dummy symbol, to pacify C89.
1636 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1637 they can't grok varargs macros.
1638 * dispnew.c (add_window_display_history)
1639 (add_frame_display_history):
1640 * print.c (print_object):
1641 * xdisp.c (debug_method_add):
1642 Use %p printf format only for void pointers.
1643 * emacs.c (usage_message): New constant, replacing ...
1644 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1645 (main): Adjust to usage reorg.
1646 * fns.c (syms_of_fns):
1647 * profiler.c (syms_of_profiler):
1648 Don't use non-constant struct initializers.
1649 * gnutls.h (gnutls_initstage_t):
1650 * lisp.h (enum Lisp_Fwd_Type):
1651 * lread.c (lisp_file_lexically_bound_p):
1652 * xsettings.c (anonymous enum):
1653 Remove trailing comma.
1654 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1655 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1656 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1657 (DEFUN): Use it.
1658 * regex.c (const_re_char): New type, to pacify strict C89.
1659 All uses of 'const re_char' replaced to use it.
1660 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1661 with glibc when strict C89. This change is imported from gnulib.
1662 All uses changed.
1663 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1664 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1665 Omit GNU_LINUX implementation, since it requires long long.
1666 * xterm.c (x_draw_underwave):
1667 Do not assume the traditional order of struct's members.
1668 (x_term_init): Rewrite to avoid the need for non-constant structure
1669 initializers.
1670
45b683a1 1671 Syntax cleanup, mostly replacing macros with functions.
763a086d 1672 This removes the need for the syntax_temp hack.
45b683a1
PE
1673 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1674 * syntax.c (SYNTAX_INLINE): New macro.
1675 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1676 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1677 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1678 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1679 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1680 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1681 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1682 Now constants, not macros.
1683 (syntax_temp) [!__GNUC__]: Remove.
1684 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1685 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1686 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1687 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1688 Move here from syntax.h; now functions, not macros. Except for the
1689 last function, these are static since only syntax.c uses them.
1690 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1691 All uses changed. Now a function, not a macro; use this fact
1692 to simplify the code.
1693 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1694 compiler bugs; no longer relevant.
1695 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1696 (SYNTAX_INLINE): New macro.
1697 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1698 for the new functions. Use bool for boolean member.
1699 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1700 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1701 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1702 (SETUP_BUFFER_SYNTAX_TABLE):
1703 Now extern inline functions, not macros.
1704 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1705 Remove; all uses replaced by implementation.
1706 (syntax_temp) [!__GNUC__]: Remove decl.
1707 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1708
29be4a50
JD
17092013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1710
1711 * emacs.c (main): Fix syntax error.
1712
954b166e
PE
17132013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 Timestamp fixes for undo (Bug#14824).
1716 * atimer.c (schedule_atimer):
1717 * fileio.c (Ffile_newer_than_file_p):
1718 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1719 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1720 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1721 (syms_of_fileio): Remove Sclear_visited_file_name.
1722 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1723 file doesn't exist; this avoids an ambiguity with negative timestamps.
1724 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1725 * systime.h (make_emacs_time, invalid_emacs_time):
1726 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1727 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1728 * undo.c (record_first_change): Push (visited-file-modtime) onto
1729 undo list rather than reimplementing it by hand, incorrectly.
1730
d74647c3
KB
17312013-07-09 Ken Brown <kbrown@cornell.edu>
1732
1733 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1734
3c51b96b
JB
17352013-07-09 Juanma Barranquero <lekktu@gmail.com>
1736
1737 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1738
4ebbdd67
PE
17392013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 Handle errno and exit status a bit more carefully.
1742 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1743 number into an exit status. Instead, use EXIT_CANCELED.
1744 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1745 * callproc.c (relocate_fd):
1746 * emacs.c (close_output_streams, main):
1747 * process.c (create_process):
1748 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1749 Use emacs_perror for simplicity.
1750 * callproc.c (relocate_fd, main):
1751 * sysdep.c (sys_subshell):
1752 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1753 (shut_down_emacs): Use emacs_write, not write.
1754 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1755 * fileio.c (Fcopy_file, e_write):
1756 * nsterm.m (ns_select):
1757 * process.c (send_process):
1758 * sound.c (vox_write):
1759 Use emacs_write_sig, not emacs_write.
1760 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1761 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1762 New constants.
1763 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1764 of write.
1765 (emacs_full_write): New function.
1766 (emacs_write): Rewrite to use it.
1767 (emacswrite_sig, emacs_perror): New functions.
1768 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1769
44e18199 17702013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1771
1772 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1773 on NS even if it is present. Pixmap on NS is a void*.
1774
9caab067
PE
17752013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 Port to Ubuntu 10 (Bug#14803).
1778 Problem reported by T.V. Raman.
1779 * process.c (close_on_exec, accept4, process_socket):
1780 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1781
1d442672
EZ
17822013-07-07 Eli Zaretskii <eliz@gnu.org>
1783
1784 * w32.c (sys_dup): Declare prototype.
1785
1786 * filelock.c:
1787 * emacs.c:
1788 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1789
067428c1
PE
17902013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1791
1792 Make file descriptors close-on-exec when possible (Bug#14803).
1793 This simplifies Emacs a bit, since it no longer needs to worry
1794 about closing file descriptors by hand in some cases.
1795 It also fixes some unlikely races. Not all such races, as
1796 libraries often open files internally without setting
1797 close-on-exec, but it's an improvement.
1798 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1799 * callproc.c (Fcall_process) [!MSDOS]:
1800 * emacs.c (main) [!DOS_NT]:
1801 * nsterm.m (ns_term_init):
1802 * process.c (create_process):
1803 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1804 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1805 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1806 Prefer mkostemp with O_CLOEXEC to mkstemp.
1807 * callproc.c (relocate_fd) [!WINDOWSNT]:
1808 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1809 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1810 now using pipe2.
1811 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1812 Make the resulting file descriptor close-on-exec.
1813 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1814 * lread.c (load_descriptor_list, load_descriptor_unwind):
1815 Remove; no longer needed. All uses removed.
1816 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1817 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1818 New functions.
1819 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1820 (Fmake_network_process, Fnetwork_interface_list):
1821 (Fnetwork_interface_info, server_accept_connection):
1822 Make newly-created socket close-on-exec.
1823 * sysdep.c (emacs_open, emacs_fopen):
1824 Make new-created descriptor close-on-exec.
1825 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1826 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1827
0da857dd
JD
18282013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1829
1830 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1831 for NS_IMPL_GNUSTEP.
1832
5f86adcd
PE
18332013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1834
1835 Fix openp errno handling.
1836 * callproc.c (Fcall_process): Preserve openp errno around close.
1837 * lread.c (openp): Set errno when returning -1, as some callers
1838 expect this.
1839
1afb1d07
JD
18402013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1841
1842 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1843
1844 * nsterm.h (NSSavePanel): Update comment.
1845 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1846 (ns_run_file_dialog): Declare.
1847
1848 * nsfns.m: Remove panelOK.
1849 (ns_fd_data): New.
1850 (ns_run_file_dialog): New function.
1851 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1852 event loop, so file dialog is popped up by ns_run_file_dialog, called
1853 by sendEvent (Bug#14578).
1854 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1855
3323c263
EZ
18562013-07-06 Eli Zaretskii <eliz@gnu.org>
1857
fdda0220
EZ
1858 * xdisp.c (default_line_pixel_height): New function.
1859 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1860 (try_cursor_movement, redisplay_window, try_window)
1861 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1862
1863 * window.c (window_scroll_pixel_based): use
1864 default_line_pixel_height.
1865
1866 * dispextern.h (default_line_pixel_height): Add prototype.
1867
1868 * frame.c (x_set_line_spacing): Accept a float value for
1869 line-spacing parameter, per the documentation.
1870
3323c263
EZ
1871 * data.c (Fmultibyte_string_p): Doc fix.
1872
47ba6d43
PE
18732013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1874
406af475
PE
1875 Use emacs_open more consistently when opening files.
1876 This handles EINTR more consistently now, and makes it easier
1877 to introduce other uniform changes to file descriptor handling.
1878 * src/systdio.h: New file.
1879 * src/buffer.c (mmap_init):
1880 * cygw32.c (chdir_to_default_directory):
1881 * dispnew.c (Fopen_termscript):
1882 * emacs.c (Fdaemon_initialized):
1883 * fileio.c (Fdo_auto_save):
1884 * image.c (slurp_file, png_load_body, jpeg_load_body):
1885 * keyboard.c (Fopen_dribble_file):
1886 * lread.c (Fload):
1887 * print.c (Fredirect_debugging_output):
1888 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1889 * termcap.c (tgetent):
1890 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1891 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1892 * w32term.c (w32_initialize) [CYGWIN]:
1893 * xfaces.c (Fx_load_color_file):
1894 Use emacs_open instead of plain open, and emacs_fopen instead of
1895 plain fopen.
1896 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1897 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1898 * callproc.c (default_output_mode): New constant.
1899 (Fcall_process): Use it to call emacs_open instead of plain creat.
1900 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1901 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1902 (emacs_fopen): New function.
1903 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1904 Include <lisp.h>, for emacs_open.
1905 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1906
47ba6d43
PE
1907 Remove duplicate #include directives.
1908 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1909 * xfaces.c:
1910 Don't include stdio.h twice.
1911 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1912 Don't include sys/types.h or stdio.h twice.
1913 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1914 * lread.c: Don't include coding.h twice.
1915 * nsfont.m: Don't include frame.h twice.
1916 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1917 * ralloc.c: Don't include <unistd.h> twice.
1918 * xdisp.c: Don't include font.h twice.
1919 * xterm.c: Don't include fontset.h twice.
1920 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1921
b9ed53d5
PE
19222013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 Scale ImageMagick images more carefully.
1925 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1926 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1927 Be more careful about avoiding undefined behavior after
1928 integer overflow and division by zero.
1929
cf13177e
YM
19302013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1931
1932 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1933 (syms_of_w32fns): DEFSYM them.
1934 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1935 (CCHDEVICENAME): Define macros if not defined.
1936 (struct MONITOR_INFO_EX): New struct.
1937 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1938 (enum_display_monitors_fn): New variable.
1939 (globals_of_w32fns): Initialize it.
1940 (Fx_display_pixel_width, Fx_display_pixel_height)
1941 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1942 multi-monitor setups in docstrings.
1943 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1944 screen size by primary monitor's millimeter per pixel.
1945 (w32_monitor_enum, w32_display_monitor_attributes_list)
1946 (w32_display_monitor_attributes_list_fallback)
1947 (Fw32_display_monitor_attributes_list): New functions.
1948 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1949
1950 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1951 if not defined.
1952 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1953
86dfb7a8
MA
19542013-07-04 Michael Albinus <michael.albinus@gmx.de>
1955
1956 * fileio.c (Qfile_notify_error): New error symbol.
1957
1958 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1959 * inotify.c (inotify_callback, symbol_to_inotifymask)
1960 (Finotify_add_watch, Finotify_rm_watch): Use it.
1961 (inotifyevent_to_event): Exchange order of cookie and file name.
1962 (Finotify_add_watch): Adapt docstring.
1963
1964 * lisp.h (Qfile_notify_error): Declare.
1965
2c1c974b
PE
19662013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1967
1968 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1969 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1970 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1971 which did not work (see <http://bugs.gnu.org/14569#307>).
1972 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1973 && (!noninteractive || initialized)). This attempts to thread
1974 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1975
7a35b20f
JB
19762013-07-04 Juanma Barranquero <lekktu@gmail.com>
1977
1978 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1979 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1980
1ce5cd04
PE
19812013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1984 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1985 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1986 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1987
57f8c490
PE
19882013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1989
1990 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1991 Define to __sys_siglist.
1992
bcffb5ca
EZ
19932013-07-02 Eli Zaretskii <eliz@gnu.org>
1994
1995 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1996 word-wrap, so that overflow-newline-into-fringe would work in
1997 visual-line-mode. (Bug#2749)
1998 (move_it_in_display_line_to): When the last scanned display
1999 element fits exactly on the display line, and
2000 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2001 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2002 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2003 finding buffer position that corresponds to pixel coordinates,
2004 e.g. in buffer_posn_from_coords.
2005
2c41e781
JD
20062013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2007
2008 * process.c (handle_child_signal): Call catch_child_signal if
2009 NS_IMPL_GNUSTEP.
2010
c2418359
PE
20112013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2012
52a9bcae
PE
2013 Don't convert function pointers to void * and back.
2014 It isn't portable C, and it's easy enough to avoid.
2015 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2016 (make_save_value): Add support for SAVE_FUNCPOINTER.
2017 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2018 * print.c (print_object):
2019 Distinguish function from object pointers.
2020 * lisp.h (SAVE_FUNCPOINTER): New constant.
2021 (SAVE_SLOT_BITS): Adjust to it.
2022 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2023 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2024 (voidfuncptr): New typedef.
2025 (struct Lisp_Save_Value): New member data[0].funcpointer.
2026 (XSAVE_FUNCPOINTER): New function.
2027
c2418359
PE
2028 Simplify buildobj processing.
2029 * Makefile.in (buildobj.h): Make it a sequence of strings each
2030 followed by comma, rather than a single string. Put it into a
2031 .tmp file in case there's an error while generating it.
2032 (gl-stamp): Use .tmp for temp files.
2033 (mostlyclean): Clean .tmp files.
2034 * doc.c (buildobj): Move to just the routine that needs it.
2035 It's now an array of strings, so processing is simpler.
2036
8f43ce49
PE
20372013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2040 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2041 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2042 Invoke malloc_enable_thread even when not interactive.
2043 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2044 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2045 in this case, since the underlying bug has now been fixed.
2046
24827db9
JB
20472013-07-01 Juanma Barranquero <lekktu@gmail.com>
2048
2049 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2050 unlinking it (bug#14691).
2051
ef099a94
MN
20522013-06-30 Michal Nazarewicz <mina86@mina86.com>
2053
2054 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2055 before checking whether buffer is modified. This lets
2056 `kill-buffer-query-functions' cancel killing of the buffer or save
2057 its content before `kill-buffer' asks user the "Buffer %s
2058 modified; kill anyway?" question.
2059
9d3f2fc2
JD
20602013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2061
2062 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2063 Let the super performKeyEquivalent deal with them (Bug#14747).
2064
e6c6c8c7
PE
20652013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2066
1d71c1d9
PE
2067 * widget.c (resize_cb): Remove unused local.
2068
8f5f35cc
PE
2069 Do not use GTK 3 if it exists but cannot be compiled.
2070 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2071 * xterm.c (x_error_handler) [!USE_GTK]:
2072 Do not use GTK 3.
2073
e6c6c8c7
PE
2074 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2075
0ba54312
EZ
20762013-06-30 Eli Zaretskii <eliz@gnu.org>
2077
5d1c3286
EZ
2078 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2079 to the valid range of values. (Bug#14753)
2080
0ba54312
EZ
2081 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2082 when moving point by using the current glyph matrix. This avoids
2083 the need to force redisplay when this function is called in a
2084 loop.
2085
9c90cc06
PE
20862013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2087
2088 Fix minor problems found by static checking.
2089 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2090 Redo the latter's body to sidestep GCC parenthesization warnings.
2091 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2092 * coding.c (detect_coding, detect_coding_system):
2093 * coding.h (struct undecided_spec):
2094 Use bool for boolean.
2095 * image.c (QCmax_width, QCmax_height): Now static.
2096 * xdisp.c (Fmove_point_visually): Remove unused local.
2097
4c672a0f
EZ
20982013-06-29 Eli Zaretskii <eliz@gnu.org>
2099
2100 * xdisp.c (Fmove_point_visually): New function.
2101
c1ea3abf
JB
21022013-06-28 Kenichi Handa <handa@gnu.org>
2103
2104 * coding.h (define_coding_undecided_arg_index): New enum.
2105 (coding_attr_index): New members
2106 coding_attr_undecided_inhibit_null_byte_detection,
2107 coding_attr_undecided_inhibit_iso_escape_detection,
2108 coding_attr_undecided_prefer_utf_8.
2109 (undecided_spec): New struct.
2110 (struct coding_system): New member `undecided' of the member
2111 `spec'.
2112
2113 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2114 (detect_coding): Likewise.
2115 (detect_coding_system): Likewise.
2116 (Fdefine_coding_system_internal): New coding system properties
2117 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2118 :prefer-utf-8.
2119 (syms_of_coding): Adjust for coding_arg_undecided_max.
2120
ba3de9e6
PE
21212013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 * image.c (x_from_xcolors): Remove unused local.
2124
547c9269
YM
21252013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2126
2127 Defer image data transfer between X client and server until actual
2128 display happens.
2129
2130 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2131 and `mask_img'.
2132
2133 * image.c (Destroy_Image): Remove.
2134 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2135 `mask_p', and `colors_p'. All uses changed.
2136 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2137 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2138 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2139 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2140 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2141 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2142 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2143 (image_get_x_image, image_unget_x_image): New functions or macros.
2144 (image_background, image_background_transparent, x_to_xcolors)
2145 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2146 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2147 instead of Destroy_Image.
2148 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2149 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2150 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2151 (imagemagick_load_image, svg_load_image): Use them instead of
2152 x_create_x_image_and_pixmap, and x_put_x_image followed by
2153 x_destroy_x_image, respectively.
2154 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2155 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2156 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2157 background_transparent fields.
2158 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2159 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2160
dae2f5ef
PE
21612013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2164 This mostly consists of undoing recent changes.
2165 * callproc.c (Fcall_process):
2166 * process.c (create_process):
2167 Do not worry about catching SIGCHLD here, undoing previous change.
2168 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2169 * process.c, process.h (catch_child_signal):
2170 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2171 * process.c (catch_child_handler): Don't worry about being called
2172 lazily and do not assume caller has blocked SIGCHLD, undoing
2173 previous change. Move first-time stuff back to
2174 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2175 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2176 set lib_child_handler if it's already initialized, which may
2177 help avoid problems on GNUStep.
2178
fa55d2aa
PE
21792013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2182 * callproc.c (Fcall_process):
2183 * process.c (create_process):
2184 Make sure SIGCHLD is caught before we fork,
2185 since Emacs startup no arranges to catch SIGCHLD.
2186 * process.c (lib_child_handler): Initialize to null, not to
2187 dummy_handler.
2188 (catch_child_signal): Allow self to be called lazily.
2189 Do nothing if it's already been called.
2190 Assume caller has blocked SIGCHLD (all callers do now).
2191 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2192 just before it's really needed.
2193 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2194 since it hasn't been caught yet.
2195
f3f9606c
LMI
21962013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2197
2198 * image.c (compute_image_size): New function to implement
2199 :max-width and :max-height.
2200 (imagemagick_load_image): Use it.
2201
c7041908
PE
22022013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2205 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2206 Now extern.
2207 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2208 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2209 the SIGCHLD handler, since the code is not atomic and (due to glib)
2210 signals may be arriving now.
2211 * sysdep.c (init_signals): Do not catch child signals here;
2212 'main' now does that later, at a safer time.
2213
f86852b4
PE
22142013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2215
0dfeed58
PE
2216 Clean up SIGCHLD handling a bit (Bug#14569).
2217 * process.c, process.h (catch_child_signal):
2218 Now always extern, even if !NS_IMPL_GNUSTEP.
2219 * process.c (catch_child_signal): Move glib tickler here from
2220 init_process_emacs, so that it's done earlier in Emacs
2221 initialization. Also move the noninteractive && !initialized
2222 check here from init_process_emacs. This is all a bit cleaner for
2223 GNUish platforms, and I hope it works around the Cygwin bug.
2224 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2225 that glib signal handling is tickled before glib creates threads.
2226
f86852b4
PE
2227 * process.c (wait_reading_process_output): Avoid int overflow
2228 when reading more than 2 GiB total from a process.
2229
cbd6509c
PE
22302013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2231
2232 * process.c (create_process): Handle a couple more cases,
2233 i.e., work even if new_argv and wait_child_setup[i] are cached.
2234 Use Fcall_process's style for volatile vars.
2235
9de1114a
AS
22362013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2237
2238 * process.c (create_process): Mark PROCESS volatile.
2239
fbe9e0b9
PE
22402013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 Use C99-style flexible array members if available.
2243 This avoids some subtle aliasing issues, which typically
2244 aren't a problem with GCC but may be a problem elsewhere.
2245 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2246 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2247 In either case, it uses a flexible array member rather than
2248 the old struct hack. All uses changed.
2249 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2250 Adjust to sdata reorganization.
2251 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2252 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2253 that ports better to pre-C99 non-GCC.
2254 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2255 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2256 as the latter has changed.
2257 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2258 and port better to pre-C99 GCC.
2259 * image.c (struct xpm_cached_color):
2260 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2261 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2262 Use FLEXIBLE_ARRAY_MEMBER.
2263 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2264 Move decl to top level so it gets checked against implementation.
2265 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2266 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2267
1fc71008
PE
22682013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2269
2270 * syntax.c: Integer cleanups.
2271 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2272 All uses that need 0-or-2 changed to:
2273 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2274 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2275 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2276 (char_quoted, prev_char_comend_first, back_comment)
2277 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2278 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2279 Use bool for boolean.
2280 (update_syntax_table, skip_chars, skip_syntaxes):
2281 Prefer int to unsigned when either will do.
2282 (back_comment): Return boolean success flag, like forw_comment,
2283 instead of positive-or-minus-1 (which might have overflowed int anyway).
2284 Don't stuff ptrdiff_t into int.
2285 (syntax_spec_code, syntax_code_spec): Now const.
2286 (Fmatching_paren, scan_lists, scan_sexps_forward):
2287 Use enum syntaxcode for syntax code.
2288 (Fmatching_paren): Check that arg is a character, not just an integer.
2289 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2290 (Finternal_describe_syntax_value): Omit no-longer-needed
2291 comparison to 0.
2292 (skip_chars): Use char, not unsigned char, when the distinction
2293 doesn't matter.
2294 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2295 * bytecode.c (exec_byte_code):
2296 * syntax.c (syntax_spec_code, Fchar_syntax)
2297 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2298 (init_syntax_once):
2299 * syntax.h (SYNTAX_WITH_FLAGS):
2300 Omit unnecessary casts.
2301
b932cad7
EZ
23022013-06-20 Eli Zaretskii <eliz@gnu.org>
2303
2304 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2305 line dimensions here, to avoid race conditions with the main
2306 thread. (Bug#14062, bug#14630, bug#14669)
2307
2308 * w32term.c (w32_draw_window_cursor): Compute the header line and
2309 mode line dimensions here.
2310 <w32_system_caret_window, w32_system_caret_hdr_height>:
2311 <w32_system_caret_mode_height>: New variables.
2312
2313 * w32term.h: Declare them.
2314
89561f72
PE
23152013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2316
5013fc08
PE
2317 * alloc.c (die): Move "assertion failed" string here ...
2318 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2319 COND when SUPPRESS_CHECKING. This shrinks the executable text
2320 size by 0.8% to 2.2% when configured with --enable-checking,
2321 depending on optimization flags (GCC 4.8.1 x86-64).
2322
89561f72
PE
2323 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2324
763a086d 23252013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2326
2327 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2328 base is 2; this is more accurate.
2329
983aeb9a
JB
23302013-06-19 Juanma Barranquero <lekktu@gmail.com>
2331
2332 * sound.c (string_default): Move to !WINDOWSNT section.
2333 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2334
178ba3e6
PE
23352013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2336
bbc51b15
PE
2337 * sound.c: Integer cleanups.
2338 Remove unnecessary forward decls.
2339 (struct sound_device): The 'file' member is now a Lisp_Object, not
2340 a char *, so that we needn't invoke alloca on a huge size.
2341 (Fplay_sound_internal): Adjust to this.
2342 (string_default): New function.
2343 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2344 Use it to adjust to the struct sound_device change.
2345 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2346 (be2hs) [0]: Remove.
2347
178ba3e6
PE
2348 * syntax.c (skip_chars): Don't use uninitialized storage
2349 when searching a multibyte buffer for characters that are not in a
2350 unibyte string that contains non-ASCII characters.
2351
69f60cdc
JD
23522013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2353
2354 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2355 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2356
0d6224d4
PE
23572013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2360
3c542890
KH
23612013-06-18 Kenichi Handa <handa@gnu.org>
2362
f7e3f7cd
KH
2363 * font.c (Ffont_spec): Signal an error for an invalid font name
2364 (Bug#14648).
3c542890 2365
9349e5f7
PE
23662013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2367
2368 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2369 In particular this ports to 32-bit sparc Sun cc.
2370 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2371 array with a dummy element at specpdl[-1], so that its address can
2372 be taken portably.
2373 (unbind_to): Do not copy the binding; not needed, now that we
2374 copy old_value in the one place where the copy is needed.
2375 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2376 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2377 (union specbinding): Rename from struct specbinding. Redo layout
2378 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2379 which is not portable. With Sun C 5.12 32-bit sparc, the
2380 declaration causes nargs to be an unsigned bitfield, a behavior
2381 that the C standard allows; but Emacs wants nargs to be signed.
2382 The overall type is now a union of structures rather than a
2383 structure of union of structures, and the 'kind' member is now a
2384 bitfield, so that the overall type doesn't grow. All uses changed.
2385 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2386
0a4df6a5
PE
23872013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2388
ec6ecaad
PE
2389 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2390 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2391
0a4df6a5
PE
2392 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2393
7bfe8dbc
EZ
23942013-06-17 Eli Zaretskii <eliz@gnu.org>
2395
2396 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2397 unless we know that the window w's frame is a frame object.
2398 Another attempt at solving bug#14062 and bug#14630.
2399
708e05f6
LMI
24002013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2401
2402 * textprop.c (property_set_type): New enum.
2403 (add_properties): Allow appending/prepending text properties.
2404 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2405 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2406 add_text_properties_1.
2407 (Fadd_face_text_property): New function that calls
2408 add_text_properties_1.
2409
84575e67
PE
24102013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 Move functions from lisp.h to individual modules when possible.
2413 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2414 * alloc.c (XFLOAT_INIT, set_symbol_name):
2415 * buffer.c (CHECK_OVERLAY):
2416 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2417 (set_char_table_parent):
2418 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2419 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2420 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2421 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2422 (set_blv_valcell):
2423 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2424 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2425 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2426 (backtrace_args, backtrace_debug_on_exit):
2427 * floatfns.c (CHECK_FLOAT):
2428 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2429 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2430 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2431 (set_hash_index_slot):
2432 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2433 * marker.c (CHECK_MARKER):
2434 * textprop.c (CHECK_STRING_OR_BUFFER):
2435 * window.c (CHECK_WINDOW_CONFIGURATION):
2436 Move here from lisp.h, and make these functions static rather than
2437 extern inline.
2438 * buffer.c (Qoverlayp):
2439 * data.c (Qsubrp):
2440 * fns.c (Qhash_table_p):
2441 * window.c (Qwindow_configuration_p):
2442 Now static.
2443 * lisp.h: Remove the abovementioned defns and decls.
2444
44e18199 2445 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2446 In lisp.h, prefer functions to function-like macros, and
2447 constants to object-like macros, when either will do. This:
2448 . simplifies use, as there's no more need to worry about
2449 arguments' side effects being evaluated multiple times.
2450 . makes the code easier to debug on some platforms.
2451 However, when using gcc -O0, keep using function-like macros
2452 for a few critical operations, for performance reasons.
2453 This sort of thing isn't needed with gcc -Og, but -Og
2454 is a GCC 4.8 feature and isn't widely-enough available yet.
2455 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2456 Remove enum lsb_bits; no longer needed.
2457 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2458 * buffer.c (Qoverlap):
2459 * data.c (Qsubrp):
2460 * fns.c (Qhash_table_p):
2461 Now extern, so lisp.h can use these symbols.
2462 * dispextern.h: Include character.h, for MAX_CHAR etc.
2463 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2464 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2465 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2466 (GLYPH_CODE_P): Move here from lisp.h.
2467 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2468 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2469 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2470 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2471 XUNTAG now returns void *.
2472 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2473 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2474 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2475 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2476 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2477 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2478 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2479 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2480 New macros, renamed from their sans-lisp_h_ counterparts.
2481 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2482 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2483 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2484 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2485 If compiling via GCC without optimization, define these as macros
2486 in addition to inline functions.
2487 To disable this, compile with -DINLINING=0.
2488 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2489 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2490 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2491 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2492 (INTMASK, VALMASK): Now macros, since static values cannot be
2493 accessed from extern inline functions.
2494 (VALMASK): Also a constant, for benefit of old GDB.
2495 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2496 is INTEGERP, which can fold it in.
5165d44a 2497 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2498 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2499 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2500 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2501 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2502 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2503 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2504 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2505 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2506 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2507 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2508 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2509 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2510 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2511 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2512 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2513 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2514 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2515 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2516 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2517 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2518 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2519 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2520 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2521 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2522 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2523 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2524 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2525 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2526 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2527 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2528 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2529 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2530 Now functions.
2531 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2532 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2533 (VALMASK): Define in one place rather than in two, merging the
2534 USE_LSB_TAG parts; this is simpler.
2535 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2536 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2537 Move up, to avoid use before definition.
2538 Also include "globals.h" earlier, for the same reason.
2539 (make_natnum): New function.
2540 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2541 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2542 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2543 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2544 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2545 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2546 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2547 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2548 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2549 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2550 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2551 (Qwindow_configuration_p, Qimage): New forward declarations.
2552 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2553 (STRING_COPYIN): Remove; unused.
2554 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2555 (xcar_addr, xcdr_addr): New functions. All uses changed.
2556 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2557 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2558 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2559 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2560 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2561 (TYPE_RANGED_INTEGERP): Simplify.
2562 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2563 (setlocale, fixup_locale, synchronize_system_messages_locale)
2564 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2565 Now empty functions, not macros.
2566 (functionp): Return bool, not int.
2567 * window.c (Qwindow_configuration_p): Now extern,
2568 so window.h can use it.
2569 * window.h (Qwindowp): Move decl back to lisp.h.
2570
9583ec36
EZ
25712013-06-15 Eli Zaretskii <eliz@gnu.org>
2572
2573 * xdisp.c (Fline_pixel_height): New function, required for solving
2574 bug #14567.
2575
210272ce
PE
25762013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2577
2578 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2579
de0503df
SM
25802013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2581
2582 * lread.c (syms_of_lread):
2583 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2584
afbfe143
KD
25852013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2586
2587 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2588
d177e213
XF
25892013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2590
2591 * fileio.c (expand_file_name): Doc fix.
2592
05e3e412
PE
25932013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2594
f7394b12
PE
2595 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2596 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2597 Wait for self, not for 0. This can't hurt on GNU or similar
2598 system, and may help with Cygwin.
2599
05e3e412
PE
2600 * keyboard.c: Don't use PROP (...) as an lvalue.
2601 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2602 Use set_prop (A, B), not PROP (A) = B.
2603
17dd3097
EZ
26042013-06-10 Eli Zaretskii <eliz@gnu.org>
2605
2606 * xdisp.c (get_it_property): Use it->window instead of generating
2607 a Lisp object from it->w.
2608
52fab9c9
EZ
26092013-06-09 Eli Zaretskii <eliz@gnu.org>
2610
2611 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2612 get-char-property the window that is being rendered, instead of
2613 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2614 (compute_display_string_pos): When W is NULL, use the current
2615 buffer as the object to pass to get-char-property.
2616 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2617 pointer member of the bidi iterator, since no window is pertinent
2618 to this function.
52fab9c9 2619
5bf97bfc
EZ
26202013-06-08 Eli Zaretskii <eliz@gnu.org>
2621
2622 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2623 being displayed, and pass it to compute_display_string_pos.
2624 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2625 (bidi_paragraph_init): All callers changed.
2626
2627 * xdisp.c (init_from_display_pos, init_iterator)
2628 (handle_single_display_spec, next_overlay_string)
2629 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2630 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2631 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2632 (compute_display_string_pos): Accept additional argument, the
2633 window being displayed, and pass it to Fget_char_property.
2634 (Bug#14575)
2635
2636 * dispextern.h (struct bidi_it): New member w, the window being
2637 displayed.
2638 (compute_display_string_pos): Adjust prototype.
2639
5de0e011
JD
26402013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2641
e7b41c4c 2642 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2643
2644 * process.c (wait_reading_process_output): Check for NS before GLIB.
2645 GLIB may be linked in due to rsvg, but ns_select must be called.
2646
5de0e011
JD
2647 * xgselect.c (xg_select): Remove call to window_system_available
2648 and g_main_context_pending at the top, so Gdk events (i.e. file
2649 notify) are processed when Emacs is started with -nw.
2650
a822acff
EZ
26512013-06-07 Eli Zaretskii <eliz@gnu.org>
2652
2653 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2654 (ctagsfiles3): New variable, includes only *.m files.
2655 (TAGS): Use an explicit language name in the regular expressions,
2656 to avoid transformation of '/SOMETHING' by MSYS to
2657 'c:\MSYS\SOMETHING'.
2658
6c0a9ed1
RC
26592013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2660
2661 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2662
9ef6111b
EZ
26632013-06-06 Eli Zaretskii <eliz@gnu.org>
2664
2665 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2666 still need to set the mouse pointer shape and activate help-echo.
2667 (Bug#14558)
2668
7d300d64
PE
26692013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2670
2671 A few porting etc. fixes for the new file monitor code.
2672 See the thread containing
2673 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2674 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2675 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2676 (dir_monitor_callback, Fgfile_rm_watch):
2677 Use assq_no_quit instead of Fassoc, for speed.
2678 (dir_monitor_callback, Fgfile_rm_watch):
2679 eassert that the monitor is a fixnum.
2680 (dir_monitor_callback): No need for CDR_SAFE.
2681 Simplify building of lisp with alternative tails.
2682 (Fgfile_add_watch, Fgfile_rm_watch):
2683 Do not assume glib functions set errno reliably on failure.
2684 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2685 and signal an error otherwise.
2686 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2687 Use Fdelq instead of Fdelete, for speed.
2688
817ebfcf
EZ
26892013-06-05 Eli Zaretskii <eliz@gnu.org>
2690
2691 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2692 don't insist on being invoked on a highlighted tool-bar button.
2693 Avoids losing tool-bar functionality when mouse-highlight is nil.
2694 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2695 Don't highlight when mouse-highlight is nil.
2696 (note_mouse_highlight): When mouse-highlight is nil, don't return
2697 right away; instead, run tool-bar and mode-line highlight
2698 subroutine, clear any existing highlight, and revert the mouse
2699 pointer to its default shape. (Bug#14558)
2700
55577e7c
SM
27012013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2702
2703 * lisp.mk (lisp): Add prog-mode.el.
2704
f019a684
PE
27052013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2706
2707 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2708 * process.c (dummy_handler): New function.
2709 (lib_child_handler): New static var.
2710 (handle_child_signal): Invoke it.
2711 (catch_child_signal): If a library has set up a signal handler,
2712 save it into lib_child_handler.
2713 (init_process_emacs): If using glib and not on Windows, tickle glib's
2714 child-handling code so that it initializes its private SIGCHLD handler.
2715 * syssignal.h (SA_SIGINFO): Default to 0.
2716 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2717 31; it should no longer be needed now.
2718
90db8702
MA
27192013-06-05 Michael Albinus <michael.albinus@gmx.de>
2720
2721 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2722
2723 * gfilenotify.c (globals_of_gfilenotify): New function.
2724 (syms_of_gfilenotify): Move global initialization there.
2725
2726 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2727
bfa3acd6
SM
27282013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2729
2730 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2731 * keyboard.c (menu_bar_items, tool_bar_items):
2732 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2733 not override local keymaps any more.
2734
ba59bd80
EZ
27352013-06-04 Eli Zaretskii <eliz@gnu.org>
2736
2737 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2738
7f203aa1
EZ
27392013-06-03 Eli Zaretskii <eliz@gnu.org>
2740
9337e206
EZ
2741 * w32console.c (initialize_w32_display): Return the dimensions of
2742 the console window via 2 additional arguments, not via the current
2743 frame. This avoids crashes due to overrunning the bounds of
2744 frame's decode_mode_spec_buffer, which is not resized following
2745 the change of the frame dimensions from the initial 10x10.
2746
2747 * w32term.h (w32_initialize_display_info): Adjust prototype.
2748
2749 * term.c (init_tty): Take dimensions of the frame from the values
2750 returned by initialize_w32_display.
2751
7f203aa1
EZ
2752 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2753 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2754 (LIBES): Add $(GFILENOTIFY_LIBS).
2755
2756 * w32inevt.c (handle_file_notifications): Add dummy implementation
2757 for !HAVE_W32NOTIFY.
2758
2759 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2760
55a87246
JD
27612013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2762
2763 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2764
2765 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2766
2767 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2768
3d5ee10a
PE
27692013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2770
2771 Fix minor problems found by static checking.
2772 * data.c (pure_write_error):
2773 Use xsignal2, not Fsignal, as Fsignal might return.
2774 * eval.c (set_backtrace_debug_on_exit): Now static.
2775 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2776 No longer inline. EXTERN_INLINE is needed only for functions
2777 defined in .h files. Reindent function header as per GNU style.
2778 (backtrace_p, backtrace_top, backtrace_next):
2779 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2780 compiler or linker. Add extern decls to pacify gcc -Wall.
2781 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2782 Now static.
2783 * frame.c (free_monitors): Define only on platforms that need it.
2784 * nsterm.m (ns_term_init):
2785 * process.c (catch_child_signal):
2786 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2787 defined on all porting targets these days.
2788 * process.c, process.h (catch_child_signal):
2789 Make it extern only if NS_IMPL_GNUSTEP is defined.
2790
e2d8a6f0
EZ
27912013-06-03 Eli Zaretskii <eliz@gnu.org>
2792
2793 * w32.c (gettimeofday): Make the signature identical to prototype
2794 in nt/inc/sys/time.h.
2795
a8a7c5f6
SM
27962013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2797
2798 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2799 .gdbinit.
2800
2801 * keyboard.c (safe_run_hooks_error): Improve error message.
2802
2803 * data.c (pure_write_error): Add `object' argument.
2804 * puresize.h (CHECK_IMPURE): Use it.
2805
c9628c79
MA
28062013-06-03 Michael Albinus <michael.albinus@gmx.de>
2807
2808 * Makefile.in (NOTIFY_OBJ): New variable.
2809 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2810
2811 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2812 Call syms_of_gfilenotify.
2813
2814 * gfilenotify.c: New file.
2815
2816 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2817 and Qfile_w32notify.
2818 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2819 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2820
2821 * lisp.h: Declare syms_of_gfilenotify.
2822
2823 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2824
2f592f95
SM
28252013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2826
2827 Merge the specpdl and backtrace stacks. Make the structure of the
2828 specpdl entries more obvious via a tagged union of structs.
2829 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2830 (enum specbind_tag): New enum.
2831 (struct specbinding): Make it a tagged union of structs.
2832 Add a case for backtrace records.
2833 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2834 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2835 (backtrace_debug_on_exit): New accessors.
2836 (struct backtrace): Remove.
2837 (struct catchtag): Remove backlist field.
2838 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2839 Move to eval.c.
2840 (Flocal_variable_p): Speed up the common case where the binding is
2841 already loaded.
2842 * eval.c (backtrace_list): Remove.
2843 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2844 (set_backtrace_args, set_backtrace_nargs)
2845 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2846 (backtrace_next): New functions.
2847 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2848 (unwind_to_catch, internal_lisp_condition_case)
2849 (internal_condition_case, internal_condition_case_1)
2850 (internal_condition_case_2, internal_condition_case_n): Don't bother
2851 with backtrace_list any more.
2852 (Fsignal): Adjust to new backtrace format.
2853 (grow_specpdl): Move up.
2854 (record_in_backtrace): New function.
2855 (eval_sub, Ffuncall): Use it.
2856 (apply_lambda): Adjust to new backtrace format.
2857 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2858 data.c.
2859 (specbind): Adjust to new specpdl format. Simplify.
2860 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2861 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2862 backtrace format.
2863 (mark_backtrace): Remove.
2864 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2865 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2866 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2867 Use mark_specpdl.
2868 * profiler.c (record_backtrace): Use get_backtrace.
2869 (handle_profiler_signal): Use backtrace_top_function.
2870 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2871 accessor functions.
2872
c0342369
JD
28732013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2874
2875 * process.h (catch_child_signal): Declare.
2876
2877 * process.c (catch_child_signal): New function.
2878 (init_process_emacs): Call it.
2879
2880 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2881 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2882 NS_IMPL_COCOA.
2883 (x_set_cursor_type): Remove declaration.
2884 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2885 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2886 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2887 (ns_get_color): Use F suffix on float.
2888 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2889 (ns_get_rgb_color): Remove.
2890 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2891 (note_mouse_movement): x and y are CGFloat.
2892 (ns_draw_fringe_bitmap): Remove unused rowY.
2893 Change #if to COCOA && >= 10_6.
2894 (ns_draw_window_cursor): Remove unused overspill.
2895 (ns_draw_underwave): width and x are EamcsCGFloat.
2896 (ns_draw_box): thickness is CGFloat.
2897 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2898 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2899 if not in main thread.
2900 (ns_get_pending_menu_title, ns_check_menu_open)
2901 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2902 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2903 (sendFromMainThread:): New method.
2904 (changeFont:): size is CGFloat.
2905 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2906 Disable warning about permanent text.
2907 (characterIndexForPoint:): Adjust return type depending on GNUStep
2908 version.
2909 (mouseDown:): delta is CGFloat.
2910 (updateFrameSize): Remove unised variable f.
2911 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2912 Cast float to EmacsCGFloat.
2913 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2914 also to -1 when restoring.
2915 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2916 inside NS_IMPL_COCOA.
2917 (toggleFullScreen:): Put call to toggleFullScreen inside
2918 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2919 (setPosition:portion:whole:): por is CGFloat.
2920 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2921 (mouseDown:): Use CGFloat.
2922 (mouseDragged:): Remove unised variable edge.
2923 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2924
2925 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2926 of CGFloat differs.
2927 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2928 when NS_IMPL_GNUSTEP.
2929 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2930 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2931 (EmacsToolbar): Add clearAll. Add tag argument to
2932 addDisplayItemWithImage.
2933 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2934
2935 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2936
2937 * nsmenu.m (ns_update_menubar): Make static.
2938 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2939 (fillWithWidgetValue:): Add cast to SEL for setAction.
2940 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2941 (update_frame_tool_bar): Update code for GNUStep.
2942 (clearAll): New method.
2943 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2944 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2945 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2946 call to insertItemWithItemIdentifier.
2947 (validateVisibleItems): Fix indentation.
2948 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2949 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2950 UtilityWindow to aStyle, remove call to setStyleMask.
2951
2952 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2953
2954 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2955 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2956 Use F suffix on floats.
2957 (ns_char_width): Returns CGFloat.
2958 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2959 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2960 DPSxshow.
2961 (ns_glyph_metrics): CGFloat instead of float.
2962
a0eb10b3
JB
2963 * nsfns.m (x_set_foreground_color, x_set_background_color):
2964 Use EmacsCGFloat.
2965 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2966 remove unused variables.
2967 (Fns_read_file_name): Keep track if panel is for save.
2968 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2969 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2970 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2971 Just return the input if GNUStep.
c0342369
JD
2972 (x_screen_planes): Remove.
2973 (Fxw_color_values): Use EmacsCGFloat
2974 (Fns_display_monitor_attributes_list): Only get screen number for
2975 Cocoa.
ef099a94 2976 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2977 EmacsSavePanel.
2978 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2979 ns_directory_from_panel.
2980
da9aff11
PE
29812013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2982
2983 * process.c (handle_child_signal): Also use WCONTINUED.
2984 This is so that list-processes doesn't mistakenly list the process
2985 as stopped, when the process has actually been continued and is
2986 now running.
2987
0e64479a
PE
29882013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2989
fc186a96
PE
2990 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2991 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2992 not already configured.
2993
0e64479a
PE
2994 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2995
38b787fa
EZ
29962013-05-29 Eli Zaretskii <eliz@gnu.org>
2997
2998 * Makefile.in (mostlyclean): Remove *.res files.
2999
22513e52
SM
30002013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3001
3002 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3003 a buffer (bug#8447).
3004
6ef3db10
EZ
30052013-05-27 Eli Zaretskii <eliz@gnu.org>
3006
3007 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3008 display vector, and we backtrack, handle the case that the
3009 previous character position is also displayed from a display
3010 vector or covered by a display string or image. (Bug#14476)
3011
6799bb26
JD
30122013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3013
3014 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3015 (struct MonitorInfo, free_monitors): Remove.
3016 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3017 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3018 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3019 Qframes, Qsource.
3020
3021 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3022 (struct MonitorInfo, free_monitors): Remove.
3023 (ns_screen_name): Make static.
3024 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3025 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3026 Qframes, Qsource.
3027
3028 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3029 (struct MonitorInfo): New struct.
3030 (free_monitors, make_monitor_attribute_list): Declare.
3031
22513e52
SM
3032 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3033 New Lisp_Object:s.
6799bb26
JD
3034 (free_monitors, make_monitor_attribute_list): New functions.
3035 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3036 Qsource.
3037
38cd43eb
XF
30382013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3039
3040 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3041
2af0948d
SM
30422013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3043
a7eb9b0f
SM
3044 * keyboard.c: Apply keyboard decoding only to events that come directly
3045 from the tty, not from unread-command-events (bug#14368).
3046 (read_event_from_main_queue): New function, extracted from read_char).
3047 (read_decoded_char): Remove.
3048 (read_decoded_event_from_main_queue): New function to replace it.
3049 (read_char): Use it.
3050 (read_key_sequence): Use read_char rather than read_decoded_char.
3051
2af0948d
SM
3052 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3053
1413e9a5
BR
30542013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3055
3056 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3057
e6d2f155
KH
30582013-05-22 Kenichi Handa <handa@gnu.org>
3059
3060 The following changes are to fix the setting of
3061 buffer-file-coding-system on, for instance, C-x RET c unix RET
3062 _FILE_OF_DOS_EOL_TYPE_ RET.
3063
3064 * coding.h (struct coding_system): New member detected_utf8_chars.
3065
3066 * coding.c (detect_coding_utf_8): Count characters and check EOL
3067 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3068 BOM is there.
3069 (setup_coding_system): Do not initialize coding->head_ascii.
3070 (check_ascii): Do not set coding->eol_seen but update it. Do not
3071 call adjust_coding_eol_type here.
1413e9a5
BR
3072 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3073 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3074 of the found coding-system.
3075 (decode_coding_gap): Cancel previous change. Utilize the
3076 character numbers counted by detect_coding_utf_8. Fix detection
3077 of BOM for utf-8.
3078
ab56a6f4 30792013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3080
3081 * search.c (looking_at_1): Only set last_thing_searched if the match
3082 changed the match-data (bug#14281).
3083
ecc3c6ed
DA
30842013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3085
3086 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3087 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3088 (move_it_vertically_backward): Likewise.
3089
5ba8bf35
YM
30902013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3091
3092 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3093 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3094 (Fx_display_mm_width, Fx_display_mm_height):
3095 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3096
91e8418b 3097 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3098 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3099 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3100 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3101 (Fx_display_backing_store, Fx_display_visual_class)
3102 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3103 (Fx_display_grayscale_p, Fx_display_pixel_width)
3104 (Fx_display_pixel_height, Fx_display_planes)
3105 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3106 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3107 (Fx_display_mm_width, Fx_display_mm_height)
3108 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3109 height for all physical monitors as in X11.
3110
fc30d803
SM
3111 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3112 Return pixel width or height for all physical monitors as in X11.
91e8418b 3113
31ff141c
PE
31142013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3115
3116 Port --enable-gcc-warnings to clang.
3117 * bytecode.c (exec_byte_code):
3118 * regex.c:
3119 Redo diagnostic pragmas to pacify clang, too.
3120 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3121 * editfns.c (Fencode_time):
3122 * fileio.c (file_accessible_directory_p):
3123 * font.c (font_unparse_xlfd):
3124 Use '&"string"[index]' instead of '"string" + (index)'.
3125 * undo.c (user_error): Remove; unused.
3126
df065a0b
EZ
31272013-05-16 Eli Zaretskii <eliz@gnu.org>
3128
04d360e7
EZ
3129 * insdel.c (insert_1_both): Document the arguments, instead of
3130 referring to insert_1, which no longer exists.
3131
5bb98290
EZ
3132 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3133 some window, increment windows_or_buffers_changed, so that
3134 *Messages* display in that window is updated. (Bug#14408)
3135
df065a0b
EZ
3136 * w32.c: Include epaths.h.
3137 (init_environment): Use cmdproxy.exe without leading directories.
3138 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3139 case.
3140 (gettimeofday): Adjust signature and return value to Posix
3141 expectations.
3142
3143 * unexw32.c (open_output_file): Delete the existing emacs.exe
3144 before creating it, to break the hard link to the versioned
3145 executable.
3146
3147 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3148 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3149 (FIRSTFILE_OBJ): New variables.
3150 (W32_RES): Rename to EMACSRES. All users changed.
3151 (base_obj): Use $(CM_OBJ).
3152 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3153 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3154 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3155 $(W32_RES_LINK) before $(LIBES).
3156 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3157
1aa8d505
SM
31582013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3159
6e911150
SM
3160 * makefile.w32-in (DOC): Use just "DOC".
3161
3162 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3163
1aa8d505
SM
3164 * process.c: Export default filters and sentinels to Elisp.
3165 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3166 New constants.
3167 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3168 (Fset_process_sentinel, Fformat_network_address):
3169 Default to them instead of nil.
3170 (server_accept_connection): Sentinels can't be nil any more.
3171 (read_and_dispose_of_process_output): New function, extracted from
3172 read_process_output.
3173 (read_process_output): Use it; filters can't be nil.
3174 (Finternal_default_process_filter): New function, extracted from
3175 read_process_output.
3176 (exec_sentinel_unwind): Remove function.
3177 (exec_sentinel): Don't zilch sentinel while running.
3178 (status_notify): Sentinels can't be nil.
3179 (Finternal_default_process_sentinel): New function extracted from
3180 status_notify.
3181 (setup_process_coding_systems): Default filter is not nil any more.
3182 (syms_of_process): Export new Elisp functions and initialize
3183 new constants.
3184 * lisp.h (make_lisp_proc): New function.
3185
5ac2eb34
SM
31862013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3187
3188 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3189
eda9c7d7
EZ
31902013-05-14 Eli Zaretskii <eliz@gnu.org>
3191
3192 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3193 unless we know that the window w is a leaf window.
3194 Another attempt at solving bug#14062.
eda9c7d7 3195
8fdeaad5
JD
31962013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3197
3198 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3199 fdesc (Bug#14375).
3200
44aa9ee6
PE
32012013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3202
3203 * image.c (gif_load): Check that subimages fit (Bug#14345).
3204
759fd763
SM
32052013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3206
3207 * lread.c (skip_dyn_eof): New function.
3208 (read1): Use it to skip the end of a file in response to #@00.
3209
3210 * doc.c (get_doc_string): Slightly relax the sanity checking.
3211
4465bfb4
JD
32122013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3213
3214 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3215 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3216 (MonitorInfo): New struct.
3217 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3218 (Fns_display_monitor_attributes_list): New functions.
3219 (display-usable-bounds): Remove.
3220 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3221 Qsource.
3222
7583e2a0
PE
32232013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3226 (GTK_CHECK_VERSION): New macro, if not already defined.
3227 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3228 replaced by GTK_CHECK_VERSION.
3229
ad75d77e
PE
32302013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 * xterm.h (GTK_PREREQ): New macro.
3233 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3234 to use this macro instead, for consistency and clarity.
3235
07525f77
EZ
32362013-05-08 Eli Zaretskii <eliz@gnu.org>
3237
3238 * xdisp.c (row_for_charpos_p): New function, with code of
3239 cursor_row_p, but accepts an additional argument CHARPOS instead
3240 of using a hardcoded PT.
3241 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3242 (row_containing_pos): Call row_for_charpos_p instead of partially
3243 doing the same. Fixes cursor positioning under longlines-mode
3244 when longlines-show-effect includes more than one newline, when
3245 moving the cursor vertically up.
3246
d901fc8d
JB
32472013-05-08 Juanma Barranquero <lekktu@gmail.com>
3248
3249 * makefile.w32-in (ACL_H): New macro.
3250 ($(BLD)/fileio.$(O)): Update dependencies.
3251
f269bc61
PE
32522013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3253
e7b41c4c 3254 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3255 * Makefile.in (LIB_ACL): New macro.
3256 (LIBACL_LIBS): Remove.
3257 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3258 * fileio.c: Include <acl.h>.
3259 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3260 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3261 !acl_errno_valid.
3262 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3263 it ourselves.
3264
f269bc61
PE
3265 * unexelf.c: Don't assume ElfW (Half) fits in int.
3266 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3267 when dealing with ElfW (Half) values, since they can exceed 2**31
3268 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3269 (entry_address): Omit unused NUM arg. All uses changed.
3270
a261c53e
JL
32712013-05-07 Juri Linkov <juri@jurta.org>
3272
3273 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3274 to the string converted from number with `Fnumber_to_string'.
3275 (Bug#14254)
3276
2b66427d
PE
32772013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3280 This fixes a problem introduced by my previous change.
3281
15acfe41
GM
32822013-05-07 Glenn Morris <rgm@gnu.org>
3283
3284 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3285
5ea03bf5
JD
32862013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3287
3288 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3289
e0c9d565
PE
32902013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3291
3292 Static checking by GCC 4.8.0.
3293 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3294 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3295 (x_get_monitor_attributes_fallback)
3296 (x_get_monitor_attributes_xinerama)
3297 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3298 Define only if USE_GTK.
3299 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3300 (x_get_monitor_attributes_fallback): Omit unused locals.
3301 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3302 Use double, not float, to avoid mixed-mode floating point arithmetic.
3303
4e3f9230
YM
33042013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3305 Jan Djärv <jan.h.d@swipnet.se>
3306
3307 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3308 (XINERAMA_CFLAGS): New macros.
3309 (ALL_CFLAGS, LIBES): Use them.
3310
3311 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3312 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3313 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3314 (syms_of_xfns): DEFSYM them.
3315 (struct MonitorInfo): New struct.
3316 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3317 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3318 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3319 (x_get_monitor_attributes_xinerama): New functions.
3320 (Fx_display_monitor_attributes_list): New primitive.
3321 (syms_of_xfns): Defsubr it.
3322
3323 * xterm.h (x_display_info): Add Xatom_net_workarea and
3324 Xatom_net_current_desktop.
3325
3326 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3327 and dpyinfo->Xatom_net_current_desktop.
3328
05839b6a
EZ
33292013-05-06 Eli Zaretskii <eliz@gnu.org>
3330
3331 * xdisp.c (pos_visible_p): Use the special code for finding the
3332 beginning of a display property or overlay for any "replacing"
3333 display property, not just for display strings. This solves
3334 incorrect reporting of position by posn-at-point. (Bug#14241)
3335
dc4a2ee0
PE
33362013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3337
5ee94506
PE
3338 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3339 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3340 Verify that ElfW (Half) fits in int.
3341 (fatal): Use same signature as lisp.h.
3342 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3343 configure and build with -DUNEXELF_DEBUG without worrying about
3344 other modules that use DEBUG.
3345 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3346 possibly-wide integers now uses it instead of plain fprintf.
3347 (entry_address): New function, which avoids problems with 32-bit
3348 overflow on 64-bit hosts.
3349 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3350 (round_up): Don't assume the remainder fits in int.
3351 (find_section): Use bool for boolean. Simplify debug code.
3352 (unexec): Don't assume file sizes fit in int or size_t.
3353 Omit unnecessary trailing newline in 'fatal' format.
3354 Use strerror rather than outputting decimal error number.
3355 Remove unused code when emacs is not defined;
3356 this file relies on Emacs now.
3357 Don't assume e_phnum and e_shnum are positive.
3358
dc4a2ee0
PE
3359 * regex.c: Fix problems when DEBUG is defined.
3360 (extract_number, extract_number_and_incr): Define regardless of
3361 whether DEBUG is defined; that's simpler and makes the code less
3362 likely to go stale in the normal case when DEBUG is not defined.
3363 Return int rather than taking an int * arg. All callers changed.
3364 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3365 Remove, replacing with ...
3366 (DEBUG_PRINT): New macro. All callers changed.
3367 (DEBUG_COMPILES_ARGUMENTS): New macro.
3368 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3369 (print_compiled_pattern, print_double_string) [DEBUG]:
3370 Use prototype rather than old-style definition.
3371 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3372 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3373 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3374 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3375 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3376 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3377 This matters only when DEBUG is defined.
3378
14c7ed05
EZ
33792013-05-05 Eli Zaretskii <eliz@gnu.org>
3380
3381 * xdisp.c (set_iterator_to_next): Set the
3382 ignore_overlay_strings_at_pos_p flag only if we are _really_
3383 iterating over an overlay string, as indicated by the
3384 current.overlay_string_index member. (Bug#14306)
3385
e6076b1b
JD
33862013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3387
3388 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3389 to where it is used, to avoid autorelease issues (Bug#14050).
3390
cbee2131
PE
33912013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3392
3393 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3394 * fileio.c (syms_of_fileio): Implement this.
3395 * filelock.c (create_lock_file): If symbolic links don't work, so
3396 we use a regular file as a lock file, do not fsync the lock file;
3397 it's not needed.
3398
30c7e542
SM
33992013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3400
3401 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3402 (syms_of_minibuf): Adjust accodingly.
3403 * lread.c (Fread):
3404 * callint.c (Fcall_interactively): Adjust calls accordingly.
3405
5bebd186
EZ
34062013-05-04 Eli Zaretskii <eliz@gnu.org>
3407
3408 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3409 w->contents is a buffer before computing everything else.
3410 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3411
3412 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3413 assertion violations. (Bug#14062)
3414
0fb0a4f3
DR
34152013-05-01 David Reitter <david.reitter@gmail.com>
3416
3417 * nsfns.m (ns_tooltip): Initialize.
3418
9e63b4a5
EZ
34192013-04-28 Eli Zaretskii <eliz@gnu.org>
3420
3421 * coding.c (decode_coding_gap): Don't remove the character before
3422 a newline unless it's a CR character. (Bug#14287)
3423
ad60824e
DN
34242013-04-28 Dan Nicolaescu <dann@gnu.org>
3425
3426 * dispextern.h (struct face): Move enum face_underline_type
3427 earlier so that bitfields can be in the same word.
3428
edbdcec0
JD
34292013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3430
3431 * nsfns.m (handlePanelKeys): New function.
3432 (EmacsOpenPanel:performKeyEquivalent:)
3433 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3434 arrows/function/control and copy/paste keys (Bug#14296).
3435
0208ede7
JL
34362013-04-27 Juri Linkov <juri@jurta.org>
3437
3438 * callint.c (Fcall_interactively): Call `Qread_number' for
3439 interactive code letter `n' instead of using duplicate code.
3440 (Bug#14254)
3441
b8dd59f7
PE
34422013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 * systime.h (make_timeval): Declare as 'const'.
3445
8bd722db
KH
34462013-04-27 Kenichi Handa <handa@gnu.org>
3447
3448 * font.c (font_open_entity): Always open a font of manageable
3449 size.
3450
13d0e56f 34512013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3452
f780d632
PE
3453 Port better to AIX (Bug#14258).
3454 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3455 to pacify AIX xlc.
3456
ec509856
KH
34572013-04-24 Kenichi Handa <handa@gnu.org>
3458
3459 * coding.c (decode_coding_iso_2022): When an invalid escape
3460 sequence is encountered, reset the invocation and designation
3461 status to the safest one.
3462
84fc48e5
PE
34632013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3464
3465 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3466 Without this fix, "make distclean" leaves stamp-h1 behind.
3467
806bda47
EC
34682013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3469
3470 * w32fns.c (w32_fullscreen_rect): New function to compute the
3471 window rectangle for the given fullscreen mode.
3472 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3473 longer tunes the window size. This keeps the window's edges flush
3474 with the screen and allows the taskbar to hide itself in fullboth.
3475
3476 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3477 window decorations and uses the entire screen.
3478
3479 * w32term.h (w32_fullscreen_rect) Add prototype.
3480 (struct w32_output): Replace normal_width, normal_height,
3481 normal_top, and normal_left members with a single normal_placement
3482 struct.
3483 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3484 Remove macros.
3485 (FRAME_NORMAL_PLACEMENT): New macro.
3486
9cc2810b
JB
34872013-04-16 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * minibuf.c (Ftest_completion): Silence compiler warning.
3490
fd16b54c
EZ
34912013-04-15 Eli Zaretskii <eliz@gnu.org>
3492
3493 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3494 bug#14062.
fd16b54c
EZ
3495
3496 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3497 parentheses.
3498
3499 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3500 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3501 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3502 parentheses where appropriate.
3503
9e3379a0
PE
35042013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3505
3506 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3507
ddd6b685
EZ
35082013-04-14 Eli Zaretskii <eliz@gnu.org>
3509
3510 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3511 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3512 Mention in the doc string that setting these variables takes
3513 effect only after a call to set-window-buffer. (Bug#14200)
3514
29b79ba1
EZ
35152013-04-13 Eli Zaretskii <eliz@gnu.org>
3516
3517 * indent.c (Fvertical_motion): Don't consider display strings on
3518 overlay strings as display strings on the buffer position we
3519 started from. This prevents vertical cursor motion from jumping
3520 more than one line when there's an overlay string with a display
3521 property at end of line.
3522 Reported by Karl Chen <Karl.Chen@quarl.org> in
3523 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3524
562c6ee9
SM
35252013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3526
3527 * window.c (select_window): `record_buffer' even if window is
3528 already selected (bug#14191).
3529
fcc1fe85
EZ
35302013-04-11 Eli Zaretskii <eliz@gnu.org>
3531
3532 * window.c (Fwindow_end): Test more flags, including the buffer's
3533 last_overlay_modified flag, to determine whether the window's
3534 display is really up-to-date. Prevents the function from
3535 returning a stale value. (Bug#14170)
3536 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3537 current matrix.
3538
f009190a
EZ
35392013-04-10 Eli Zaretskii <eliz@gnu.org>
3540
3541 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3542 garbaged only if it is not already the top frame on its TTY.
3543 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3544 there are GUI frames open in the same session. (Bug#13864)
3545
78ce603d
SM
35462013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3547
3548 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3549 of marking the idle timers directly.
3550
a8036e40
SM
35512013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3552
3553 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3554 tables (bug#14054).
3555
7ffe7ef6
SM
35562013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3557
3558 * window.c (select_window): Don't record_buffer while the invariant is
3559 temporarily broken (bug#14161).
3560
3561 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3562
7d9f6883
EZ
35632013-04-07 Eli Zaretskii <eliz@gnu.org>
3564
3565 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3566
5406cfd9
RF
35672013-04-07 Romain Francoise <romain@orebokech.com>
3568
3569 Ignore additional platform-specific ACL errors (Bug#13702).
3570 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3571 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3572
95c0e83b
JD
35732013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3574
3575 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3576 f->output_data.ns.
3577
876da980
PE
35782013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3579
3580 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3581 This bug was introduced by my 2013-02-25 change that simplified
3582 data_start configuration. Without this change, on GNU/Linux
3583 an Emacs configured with --enable-profiling fails immediately
3584 due to a profiler signal.
3585 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3586 with these flags. On platforms where special flags are needed
3587 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3588 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3589 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3590
7452b7bd
DA
35912013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3592
3593 Get rid of some platform-specific functions examining window
3594 system and its capabilities. This is a partial rework of the
3595 2013-04-05 change.
3596 * lisp.h (have_menus_p): Remove prototype. This function is
3597 replaced with platform-independent window_system_available.
3598 (check_window_system): Move to...
3599 * frame.h (decode_window_system_frame, window_system_available):
3600 ...here, add new prototypes.
3601 * frame.c (window_system_available, decode_window_system_frame):
3602 New functions.
3603 (check_window_system): Platform-independent now.
3604 * xterm.h (x_in_use): Remove declaration.
3605 (check_x_frame):
3606 * w32term.h (check_x_frame):
3607 * nsterm.h (check_x_frame): Remove prototypes. This function
3608 is replaced with platform-independent decode_window_system_frame.
3609 * msdos.c (have_menus_p): Remove.
3610 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3611 Remove platform-specific functions. Use check_window_system,
3612 decode_window_system_frame and check_ns_display_info where
3613 appropriate. Minor style and comment tweaks.
3614 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3615 (check_x_frame): Likewise.
3616 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3617 Likewise.
3618 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3619 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3620 * xmenu.c, xselect.c: All related users changed.
3621
251e9147
KH
36222013-04-03 Kenichi Handa <handa@gnu.org>
3623
3624 The following changes is to optimize the code for reading UTF-8
3625 files.
3626
562c6ee9 3627 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3628 changed. Check EOL format. Do not call adjust_coding_eol_type
3629 here.
3630 (check_utf_8): New function.
3631 (adjust_coding_eol_type): Do nothing if already adjusted.
3632 (detect_coding): Compare the return value of check_ascii with
3633 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3634 (decode_coding_gap): Optimize for valid UTF-8.
3635
8bc369d4
KH
36362013-03-21 Kenichi Handa <handa@gnu.org>
3637
3638 * coding.c (syms_of_coding): Cancel previous change.
3639
3640 * insdel.c (insert_from_gap): Fix previous change.
3641
73931ad1
DA
36422013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3643
3644 Consistently use platform-specific function to detect window system.
3645 * lisp.h (check_window_system): New prototype. This function is
3646 going to replace check_x, check_w32 and check_ns.
3647 (have_menus_p): Mention msdos.c in comment.
3648 * fontset.c (check_window_system_func): Remove. Adjust all users.
3649 * fontset.h (check_window_system_func): Remove prototype.
3650 * nsterm.h (check_ns):
3651 * xterm.h (check_x):
3652 * w32term.h (check_w32): Likewise.
3653 * menu.c (Fx_popup_menu): Use check_window_system.
3654 * msdos.c (check_window_system): Define for MS-DOS.
3655 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3656 * w32fns.c (check_window_system): Likewise for MS-Windows.
3657 * xfns.c (check_window_system): Likewise for X.
3658 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3659 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3660
7216e43b
PE
36612013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 Prefer < to > in range checks such as 0 <= i && i < N.
3664 This makes it easier to visualize quantities on a number line.
3665 This patch doesn't apply to all such range checks,
3666 only to the range checks affected by the 2013-03-24 change.
3667 This patch reverts most of the 2013-03-24 change.
3668 * alloc.c (xpalloc, Fgarbage_collect):
3669 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3670 * character.c (string_escape_byte8):
3671 * charset.c (read_hex):
3672 * data.c (cons_to_unsigned):
3673 * dispnew.c (update_frame_1):
3674 * doc.c (Fsubstitute_command_keys):
3675 * doprnt.c (doprnt):
3676 * editfns.c (hi_time, decode_time_components):
3677 * fileio.c (file_offset):
3678 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3679 * font.c (font_intern_prop):
3680 * frame.c (x_set_alpha):
3681 * gtkutil.c (get_utf8_string):
3682 * indent.c (check_display_width):
3683 * keymap.c (Fkey_description):
3684 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3685 * lread.c (read1):
3686 * minibuf.c (read_minibuf_noninteractive):
3687 * process.c (wait_reading_process_output):
3688 * search.c (Freplace_match):
3689 * window.c (get_phys_cursor_glyph):
3690 * xdisp.c (redisplay_internal):
3691 * xsmfns.c (smc_save_yourself_CB):
3692 Prefer < to > for range checks.
3693 * dispnew.c (sit_for): Don't mishandle NaNs.
3694 This fixes a bug introduced in the 2013-03-24 change.
3695 * editfns.c (decode_time_components): Don't hoist comparison.
3696 This fixes another bug introduced in the 2013-03-24 change.
3697
92759988
DA
36982013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3699
3700 * frame.h (struct frame): Drop scroll_bottom_vpos
3701 member becaue all real users are dead long ago.
3702 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3703 * xdisp.c (redisplay_internal): Adjust user.
3704
9a1971bb
GM
37052013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3706
f38ab167
JD
3707 * nsmenu.m (showAtX:Y:for:): setLevel to
3708 NSPopUpMenuWindowLevel (Bug#13998).
3709
6d01f1fe
JD
37102013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3711
3712 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3713 (ns_check_pending_open_menu): Declare.
3714
3715 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3716 (x_activate_menubar): Update the menu with title that matches
3717 ns_get_pending_menu_title, and call
3718 ns_check_pending_openmenu (Bug#12698).
3719 (menuWillOpen:): New method.
3720 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3721
3722 * nsterm.m (menu_will_open_state, menu_mouse_point)
3723 (menu_pending_title): New varaibles.
3724 (ns_get_pending_menu_title, ns_check_menu_open)
3725 (ns_check_pending_open_menu): New functions.
3726
781f4782
DA
37272013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3728
3729 * indent.c (current_column_bol_cache): Remove leftover which is not
3730 used in Fmove_to_column any more.
3731 (current_column, scan_for_column): Adjust users.
3732 * keyboard.c (last_point_position_buffer, last_point_position_window):
3733 Remove leftovers which are not used for recording undo any more.
3734 (command_loop_1, syms_of_keyboard): Adjust users.
3735 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3736 redisplay_window any more.
3737 (move_it_to): Adjust user.
3738
1921c31b
JB
37392013-03-29 Juanma Barranquero <lekktu@gmail.com>
3740
3741 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3742 Update dependencies.
3743
717b8bcd
SM
37442013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3745
3746 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3747 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3748 forward references.
3749
e74aeda8
DA
37502013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3751
3752 * window.h (struct window): Replace hchild, vchild and buffer slots
3753 with the only contents slot. This is possible because each valid
3754 window may have either the child window (in vertical or horizontal
3755 combination) or buffer to display (for the leaf window). Using that,
3756 a lof of operations to traverse and/or change window hierarchies may
3757 be simplified. New member horizontal is used to distinguish between
3758 horizontal and vertical combinations of internal windows.
3759 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3760 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3761 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3762 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3763 Use contents slot, not buffer, where appropriate.
3764 (wset_combination): New function.
3765 (wset_buffer): Add eassert.
3766 (Fframe_first_window): Simplify the loop reaching first window.
3767 (Fwindow_buffer): Use WINDOW_LEAF_P.
3768 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3769 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3770 (unshow_buffer): Convert initial debugging check to eassert.
3771 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3772 (make_parent_window, window_resize_check, window_resize_apply)
3773 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3774 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3775 Adjust to match struct window changes.
3776 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3777 (mark_window_cursors_off, count_windows, get_leaf_windows)
3778 (foreach_window_1): Simplify the loop.
3779 * alloc.c (mark_object): Do not check for the leaf window because
3780 internal windows has no glyph matrices anyway.
3781 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3782 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3783 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3784 (build_frame_matrix_from_window_tree, mirror_make_current)
3785 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3786 (update_window_tree, set_window_update_flags): Simplify the loop.
3787 (sync_window_with_frame_matrix_rows): Enforce live window.
3788 Use contents slot, not buffer, where appropriate.
3789 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3790 and WINDOW_HORIZONTAL_COMBINATION_P.
3791 (make_frame_visible_1): Simplify the loop.
3792 Use contents slot, not buffer, where appropriate.
3793 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3794 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3795 (expose_window_tree): Likewise.
3796 Use contents slot, not buffer, where appropriate.
3797 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3798 to avoid deleted windows. Use contents slot instead of buffer.
3799 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3800 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3801 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3802 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3803
121ab1cd
EZ
38042013-03-28 Eli Zaretskii <eliz@gnu.org>
3805
ef454cf7
EZ
3806 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3807 identify the reasons for assertion violations in bug#14062 and
3808 similar ones.
21e930f8
EZ
3809 (Fx_show_tip): Fix compilation error under
3810 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3811
121ab1cd
EZ
3812 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3813 Reported by <rzl24ozi@gmail.com>.
3814
5c89ca24
DA
38152013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3816
3817 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3818 start marker...
562c6ee9
SM
3819 (unwind_with_echo_area_buffer): ...to restore it here.
3820 This is needed to ensure that...
5c89ca24
DA
3821 (redisplay_window): ...both window markers are valid here,
3822 which is verified by eassert.
3823 * editfns.c (save_excursion_save): Do not assume that
3824 selected_window always displays the buffer.
c7f53895
DA
3825 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3826 Fix comment.
5c89ca24 3827
f557c1b1
SM
38282013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3829
3830 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3831 the upcase table.
3832
40693bba 38332013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3834
3835 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3836
c86f791f
EZ
38372013-03-27 Eli Zaretskii <eliz@gnu.org>
3838
3839 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3840 since MinGW's w32api headers do. This avoids compiler warnings.
3841
3842 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3843 if already defined.
3844
c6e72e17
EZ
38452013-03-26 Eli Zaretskii <eliz@gnu.org>
3846
3847 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3848
54e95010
JD
38492013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3850
3851 * gtkutil.c (style_changed_cb): Check if frame is live and an
3852 X frame (Bug#14038).
3853
b88b62de
EZ
38542013-03-26 Eli Zaretskii <eliz@gnu.org>
3855
a18d7de6
EZ
3856 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3857 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3858 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3859 MinGW64.
8f5e14c8
EZ
3860 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3861 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3862
b88b62de
EZ
3863 Fix incompatibilities between MinGW.org and MinGW64 headers.
3864 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3865
3866 * w32.c (REPARSE_DATA_BUFFER): Guard with
3867 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3868
c074e458
JD
38692013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3870
3871 * xterm.c: Include X11/XKBlib.h
3872 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3873
908589fd
AS
38742013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3875
3876 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3877 written backwards.
3878 * blockinput.h (input_blocked_p): Likewise.
3879 * bytecode.c (exec_byte_code): Likewise.
3880 * callproc.c (call_process_kill, call_process_cleanup)
3881 (Fcall_process): Likewise.
3882 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3883 (Fccl_execute_on_string): Likewise.
3884 * character.c (string_escape_byte8): Likewise.
3885 * charset.c (read_hex): Likewise.
3886 * cm.c (calccost): Likewise.
3887 * data.c (cons_to_unsigned): Likewise.
3888 * dired.c (directory_files_internal, file_name_completion):
3889 Likewise.
3890 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3891 (sit_for): Likewise.
3892 * doc.c (Fsubstitute_command_keys): Likewise.
3893 * doprnt.c (doprnt): Likewise.
3894 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3895 * emacsgtkfixed.c: Likewise.
3896 * fileio.c (file_offset, Fwrite_region): Likewise.
3897 * floatfns.c (Fexpt, fmod_float): Likewise.
3898 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3899 Likewise.
3900 * font.c (font_intern_prop): Likewise.
3901 * frame.c (x_set_alpha): Likewise.
3902 * gtkutil.c (get_utf8_string): Likewise.
3903 * indent.c (check_display_width): Likewise.
3904 * intervals.c (create_root_interval, rotate_right, rotate_left)
3905 (split_interval_right, split_interval_left)
3906 (adjust_intervals_for_insertion, delete_node)
3907 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3908 (merge_interval_right, merge_interval_left, copy_intervals)
3909 (set_intervals_multibyte_1): Likewise.
3910 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3911 * keymap.c (Fkey_description): Likewise.
3912 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3913 * lread.c (openp, read_integer, read1, string_to_number):
3914 Likewise.
3915 * menu.c (ensure_menu_items): Likewise.
3916 * minibuf.c (read_minibuf_noninteractive): Likewise.
3917 * print.c (printchar, strout): Likewise.
3918 * process.c (create_process, Faccept_process_output)
3919 (wait_reading_process_output, read_process_output, send_process)
3920 (wait_reading_process_output): Likewise.
3921 * profiler.c (make_log, handle_profiler_signal): Likewise.
3922 * regex.c (re_exec): Likewise.
3923 * regex.h: Likewise.
3924 * search.c (looking_at_1, Freplace_match): Likewise.
3925 * sysdep.c (get_child_status, procfs_ttyname)
3926 (procfs_get_total_memory): Likewise.
3927 * systime.h (EMACS_TIME_VALID_P): Likewise.
3928 * term.c (dissociate_if_controlling_tty): Likewise.
3929 * window.c (get_phys_cursor_glyph): Likewise.
3930 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3931 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3932 Likewise.
3933 * xfns.c (Fx_window_property): Likewise.
3934 * xmenu.c (set_frame_menubar): Likewise.
3935 * xselect.c (x_get_window_property, x_handle_dnd_message):
3936 Likewise.
3937 * xsmfns.c (smc_save_yourself_CB): Likewise.
3938 * xterm.c (x_scroll_bar_set_handle): Likewise.
3939
2bf7d27a
DA
39402013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3941
3942 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3943 to be optional or nil. Adjust comment and convert it to docstring.
3944 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3945 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3946
a9ebfa0b
PE
39472013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3948
3949 Static checking by GCC 4.8-20130319.
3950 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3951 * process.c (Fset_process_datagram_address)
3952 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3953 * xdisp.c (get_char_face_and_encoding):
3954 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3955 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3956 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3957
4f3576ee
KB
39582013-03-24 Ken Brown <kbrown@cornell.edu>
3959
789b5e9a
KB
3960 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3961 fix compilation on 64-bit Cygwin, where underscores are not
3962 automatically prepended.
3963
4f3576ee
KB
3964 * w32term.c (w32_initialize): Silence compiler warning.
3965
b5b7745f
EZ
39662013-03-23 Eli Zaretskii <eliz@gnu.org>
3967
cdc0d0bd
EZ
3968 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3969 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3970 variables, to save and restore frame dimensions.
3971 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3972 after returning from a 'fullscreen' configuration.
3973 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3974 to avoid races between the main thread and the input thread.
3975
3976 * w32term.h (struct w32_output): New members normal_width,
3977 normal_height, normal_top, normal_left, and prev_fsmode.
3978 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3979 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3980 members of a frame.
3981
b5b7745f
EZ
3982 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3983 'fullscreen' parameter. Always record previous width and height
3984 of the frame, except when switching out of maximized modes, so
3985 that they could be restored correctly, instead of resetting to the
3986 default frame dimensions. Send SC_RESTORE command to the frame,
3987 unless we are going to send SC_MAXIMIZE, to restore the frame
3988 resize hints in the mouse pointer shown by the window manager.
3989 (Bug#14032)
3990
3991 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3992
3993 * lisp.h (get_frame_param): Adjust conditions for prototype
3994 declaration.
3995
a3454eed
KB
39962013-03-22 Ken Brown <kbrown@cornell.edu>
3997
3998 * unexcw.c: Drop unneeded inclusion of w32common.h.
3999 (report_sheap_usage): Declare.
4000 (read_exe_header): Add magic numbers for x86_64.
4001 (fixup_executable): Fix printf format specifier for unsigned long
4002 argument.
4003
5a49b79c
DA
40042013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4005
4006 * frame.h (struct frame): Put menu_bar_window under #ifdef
4007 because this member is not needed when X toolkit is in use.
4008 (fset_menu_bar_window):
4009 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4010 (free_glyphs, update_frame):
4011 * xdisp.c (expose_frame): Likewise.
4012 (display_menu_bar): Likewise. Remove redundant eassert.
4013 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4014 toolkit is in use.
4015
d6723bf7
PE
40162013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4017
7b1123d8
PE
4018 Use functions and constants to manipulate Lisp_Save_Value objects.
4019 This replaces code that used macros and strings and token-pasting.
4020 The change makes the C source a bit easier to follow,
4021 and shrinks the Emacs executable a bit.
4022 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4023 (make_save_value): Change 1st arg from string to enum. All callers
4024 changed.
4025 (INTX): Remove.
4026 (mark_object): Use if, not #if, for GC_MARK_STACK.
4027 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4028 (XSAVE_OBJECT): Now functions, not macros.
4029 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4030 the constant was never used.
4031 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4032 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4033 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4034 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4035 New constants.
4036 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4037 type3 with a single member save_type. All uses changed.
4038 (save_type, set_save_pointer, set_save_integer): New functions.
4039 * print.c (PRINTX): Remove.
4040
d6723bf7
PE
4041 * alloc.c: Remove redundant static declarations.
4042
5f24fa51
DA
40432013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4044
4045 * window.h (struct window): Convert left_col, top_line, total_lines
4046 and total_cols from Lisp_Objects to integers. Adjust comments.
4047 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4048 Remove.
4049 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4050 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4051 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4052 Adjust users where appropriate.
4053
42143acd
DA
40542013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4055
4056 * frame.h (struct frame): Drop resx and resy because the same data is
4057 available from window system-specific output context. Adjust users.
562c6ee9
SM
4058 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4059 New functions to provide defaults when no window system available.
42143acd 4060 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4061 (NUMVAL): Move from xdisp.c.
42143acd
DA
4062 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4063 (Ffont_face_attributes, Fopen_font):
4064 * image.c (gs_load):
4065 * w32font.c (fill_in_logfont):
4066 * xdisp.c (calc_pixel_width_or_height):
4067 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4068 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4069
c0a17406
KH
40702013-03-20 Kenichi Handa <handa@gnu.org>
4071
4072 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4073 to 1 (temporary workaround until a bug related to ASCII
4074 optimization is fixed).
4075
095d384d
DA
40762013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4077
4078 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4079 Signal error if window is not internal. Adjust docstring.
4080 (delete_all_child_windows): Use combination_limit to save the buffer.
4081 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4082 * print.c (syms_of_print): Initialize debugging output not here...
4083 (init_print_once): ...but in a new function here.
4084 * lisp.h (init_print_once): Add prototype.
4085 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4086
748fa866
DA
40872013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4088
4089 * window.c (window_resize_check, window_resize_apply)
4090 (window_from_coordinates, recombine_windows, set_window_buffer)
4091 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4092 (Fsplit_window_internal, Fdelete_window_internal)
4093 (freeze_window_starts): Use bool for booleans.
4094 * window.h (window_frame_coordinates, resize_frame_windows)
4095 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4096
81519fd2
SM
40972013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4098
4099 * dispnew.c (bitch_at_user): Use `user-error'.
4100
6db423a9
KB
41012013-03-17 Ken Brown <kbrown@cornell.edu>
4102
4103 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4104 as return type of image_background. (Bug#13981)
4105 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4106
8f2906f5
JD
41072013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4108
960ce480 4109 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4110 (ns_select): Don't return with result uninitialized.
960ce480 4111
8f2906f5
JD
4112 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4113 and getDirectory.
4114
81519fd2
SM
4115 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4116 New functions.
8f2906f5
JD
4117 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4118 directories. If filename is nil, get directory name (Bug#13932).
4119 Use getFilename and getDirectory.
4120 (getFilename, getDirectory): New methods for EmacsSavePanel and
4121 EmacsOpenPanel.
4122 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4123
cded56c1
PE
41242013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4125
4126 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4127
251e9147 41282013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4129
4130 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4131 (adjust_after_replace): Make it back to static. Delete the third
4132 arg text_at_gap_tail. Cancel the code for handling it.
4133
4134 * coding.h (struct coding_system): New member eol_seen.
4135
4136 * coding.c (detect_ascii): New function.
4137 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4138 when the source bytes are actually scanned. On detecting for
4139 coding_category_utf_8_auto, call detect_ascii instead of scanning
4140 source bytes directly.
4141 (produce_chars): Call insert_from_gap with the new arg 0.
4142 (encode_coding): Likewise.
4143 (decode_coding_gap): Control ASCII optimization by the variable
4144 disable_ascii_optimization instead of #ifndef .. #endif.
4145 Deccode EOL format according to coding->eol_seen.
4146 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4147 variable.
4148
8a44e6d1
KH
4149 * lisp.h (adjust_after_replace): Cancel externing it.
4150 (insert_from_gap): Adjust prototype.
4151
5f795e34
EZ
41522013-03-15 Eli Zaretskii <eliz@gnu.org>
4153
4154 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4155 FULLSCREEN_MAXIMIZED. (Bug#13935)
4156
f258b4be
DA
41572013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4158
4159 * region-cache.c (find_cache_boundary, move_cache_gap)
4160 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4161 Simplify debugging check and convert to eassert. Adjust comment.
4162 (pp_cache): Put under ENABLE_CHECKING.
4163
a5cc4dde
EZ
41642013-03-14 Eli Zaretskii <eliz@gnu.org>
4165
4166 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4167 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4168 and WM_ACTIVATEAPP.
4169 (w32fullscreen_hook): If the frame is visible, reset
4170 f->want_fullscreen flag after changing the frame size. If the
4171 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4172 (Bug#13953)
4173
3fc5e44a
DC
41742013-03-13 Daniel Colascione <dancol@dancol.org>
4175
4176 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4177 too so that these builds can use Cygwin's file conversion
4178 functions. (We've been building and linking cygw32.o all along
4179 and just not using it.)
4180
47d7532e
PE
41812013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4182
4183 File synchronization fixes (Bug#13944).
4184 * Makefile.in (LIB_FDATASYNC): New macro.
4185 (LIBES): Use it.
4186 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4187 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4188 Don't worry about HAVE_FSYNC, since a substitute fsync is
4189 available if the system lacks one.
4190 (Fwrite_regin): Retry fsync if interrupted.
4191
c7ffccaf
EZ
41922013-03-13 Eli Zaretskii <eliz@gnu.org>
4193
4e2df81d 4194 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4195 activated, call w32fullscreen_hook, to make sure the new frame
4196 dimensions are in effect. (Bug#13937)
4197
8a7debc1
DA
41982013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4199
4200 * xdisp.c (init_iterator): Simplify because both character and byte
4201 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4202 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4203 character and byte positions can be obtained from marker.
8a7debc1 4204
7fd8c501
PE
42052013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4206
d9df6f40
PE
4207 Static checking by Sun C 5.12.
4208 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4209 * bytecode.c (exec_byte_code):
4210 * dispnew.c (init_display):
4211 * eval.c (error):
4212 * fileio.c (Fsubstitute_in_file_name):
4213 * keyboard.c (Fevent_convert_list):
4214 * keymap.c (Fsingle_key_description):
4215 * term.c (maybe_fatal, fatal):
4216 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4217 * xsmfns.c (Fhandle_save_session):
4218 Omit unreachable code.
4219 * keymap.c (map_keymap_char_table_item): Cast void * to
4220 a function pointer type; the C Standard requires this.
4221
7fd8c501
PE
4222 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4223 Include <sys/param.h> unconditionally, as that works elsewhere and
4224 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4225 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4226 and FreeBSD now.
4227
a020afb9 4228See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4229
4230;; Local Variables:
4231;; coding: utf-8
aac0c6e3
MR
4232;; End:
4233
ab422c4d 4234 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4235
4236 This file is part of GNU Emacs.
4237
4238 GNU Emacs is free software: you can redistribute it and/or modify
4239 it under the terms of the GNU General Public License as published by
4240 the Free Software Foundation, either version 3 of the License, or
4241 (at your option) any later version.
4242
4243 GNU Emacs is distributed in the hope that it will be useful,
4244 but WITHOUT ANY WARRANTY; without even the implied warranty of
4245 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4246 GNU General Public License for more details.
4247
4248 You should have received a copy of the GNU General Public License
4249 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.