* nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d2d699ac
JD
12013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
4 (ns_check_menu_open): Handle menu == nil. Remove assignment to
5 menu_pending_title.
6
7 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
8 (x_activate_menubar): Update the whole menu.
9 (trackingNotification:): Call ns_check_menu_open if tracking ends.
10 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
11 current event is not NSSystemDefined (Bug#15001).
12 Call ns_check_menu_open only if trackingMenu is 2.
13 (menuDidClose:): New method, decrease trackingMenu.
14 (fillWithWidgetValue:setDelegate:): New method.
15 (fillWithWidgetValue:): Call the above.
16
17 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
18
7d652d97
PE
192013-08-11 Paul Eggert <eggert@cs.ucla.edu>
20
21 Omit some unnecessary casts.
22 Many of these go back to the old pre-C89 days, when they may have
23 been needed, but we've been assuming C89 or later for a while now.
24 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
25 (live_float_p, live_misc_p, live_vector_p):
26 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
27 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
28 (defvar_per_buffer):
29 * callint.c (Fcall_interactively):
30 * doc.c (Fsubstitute_command_keys):
31 * filelock.c (get_boot_time):
32 * frame.c (xrdb_get_resource):
33 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
34 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
35 (xg_get_file_name_from_selector, menuitem_destroy_callback)
36 (menuitem_highlight_callback, menu_destroy_callback)
37 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
38 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
39 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
40 (xg_tool_bar_help_callback, tb_size_cb):
41 * image.c (xpm_alloc_color, png_read_from_memory)
42 (png_read_from_file, png_load_body, our_memory_skip_input_data)
43 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
44 (syms_of_image):
45 * keymap.c (describe_map):
46 * nsfns.m (Fns_display_monitor_attributes_list):
47 * nsmenu.m (process_dialog:):
48 * nsterm.m (hold_event):
49 * process.c (wait_reading_process_output):
50 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
51 * scroll.c (do_direct_scrolling, scrolling_1):
52 * termcap.c (tgetent):
53 * window.c (check_window_containing, add_window_to_list)
54 (freeze_window_starts):
55 * xdisp.c (compare_overlay_entries, vmessage):
56 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
57 (x_get_monitor_attributes_xrandr)
58 (Fx_display_monitor_attributes_list, x_display_info_for_name)
59 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
60 * xfont.c (xfont_match, xfont_open):
61 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
62 (menubar_selection_callback, menu_position_func)
63 (popup_selection_callback, create_and_show_popup_menu)
64 (dialog_selection_callback, create_and_show_dialog):
65 * xrdb.c (x_get_string_resource):
66 (main) [TESTRM]:
67 * xsmfns.c (x_session_check_input):
68 * xterm.c (x_draw_glyphless_glyph_string_foreground)
69 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
70 (xaw_jump_callback, xaw_scroll_callback):
71 Omit unnecessary casts.
72
9acc1074
PE
732013-08-10 Paul Eggert <eggert@cs.ucla.edu>
74
75 Minor string-length refactoring.
76 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
77 * frame.c (make_monitor_attribute_list):
78 Prefer build_string to strlen + make_string.
79
361c0eb8
JD
802013-08-10 Jan Djärv <jan.h.d@swipnet.se>
81
82 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
83 don't check minor_code (Bug#14417).
84
14ba0822
EZ
852013-08-09 Eli Zaretskii <eliz@gnu.org>
86
87 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
88 vertical positions instead. This avoids calling MATRIX_ROW with
89 row numbers that are possibly beyond valid limits. (Bug#15064)
90
309f24d1
DA
912013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
92
93 Use xstrdup and build_unibyte_string where applicable.
94 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
95 * xfns.c (x_window):
96 * xrdb.c (x_get_customization_string):
97 * xterm.c (xim_initialize):
98 * w32fns.c (w32_window): Use xstrdup.
99 (w32_display_monitor_attributes_list):
100 * emacs.c (init_cmdargs):
101 * keyboard.c (PUSH_C_STR):
102 * nsfont.m (nsfont_open):
103 * sysdep.c (system_process_attributes):
104 * w32.c (system_process_attributes):
105 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
106
55902276
EZ
1072013-08-09 Eli Zaretskii <eliz@gnu.org>
108
109 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
110 variables of these types so that GDB would know about them, as aid
111 for debugging fatal exceptions. (Bug#15024) See also
112 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
113 discussions.
114
10bf7f5a
JD
1152013-08-08 Jan Djärv <jan.h.d@swipnet.se>
116
117 * nsterm.m (ns_update_begin): Don't change clip path if it would be
118 larger than the NSWindow (Bug#14934).
119
65620264
DA
1202013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
121
122 Redesign redisplay interface to drop global variable updated_window.
123 Always pass currently updated window as a parameter to update routines.
124 * dispextern.h (updated_window): Remove declaration.
125 (struct redisplay_interface): Pass window parameter to
126 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
127 and after_update_window_hook.
128 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
129 Adjust prototypes.
130 * dispnew.c (updated_window): Remove.
131 (redraw_overlapped_rows, update_marginal_area, update_text_area)
132 (update_window_line): Adjust to match redisplay interface changes.
133 * nsterm.m (ns_update_window_begin, ns_update_window_end)
134 (ns_scroll_run, ns_after_update_window_line):
135 * w32term.c (x_update_window_begin, x_update_window_end)
136 (x_after_update_window_line, x_scroll_run):
137 * xterm.c (x_update_window_begin, x_update_window_end)
138 (x_after_update_window_line, x_scroll_run):
139 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
140 Likewise. Adjust comments where appropriate.
141 (x_cursor_to): Simplify because this is always called during window
142 update (but install debugging check anyway).
143 (expose_window): Check must_be_updated_p flag to see whether this
144 function is called during window update.
145
628fdc56
DA
1462013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
147
148 Do not reset window modification event counters excessively.
149 These leftovers and poor man's tricky methods to catch extra
150 redisplay's attention are no longer needed.
151 * frame.c (set_menu_bar_lines_1):
152 * minibuf.c (read_minibuf_unwind):
153 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
154 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
155 (window_scroll_line_based, Fset_window_configuration):
156 * xdisp.c (redisplay_window): Do not reset last_modified and
157 last_overlay_modified counters.
158
8fd9c92e
JD
1592013-08-07 Jan Djärv <jan.h.d@swipnet.se>
160
161 * xselect.c (x_send_client_event): Set send_event and serial, memset
162 data.l as it might be bigger than data.b. Use 24 bit mask to
163 XSendEvent (Bug#15034).
164
0ee18172
EZ
1652013-08-07 Eli Zaretskii <eliz@gnu.org>
166
167 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
168 for TTY frames that are not the top frame on their console.
169 (Bug#14616)
170
16ddd1a6
MR
1712013-08-07 Martin Rudalics <rudalics@gmx.at>
172
173 * w32term.c (w32fullscreen_hook): Really maximize frame when
174 asked for (Bug#14841).
175
d2a95ffb
DA
1762013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
177
178 Prefer selected_window to Fselected_window, likewise for frames.
179 * buffer.c (Fbuffer_swap_text):
180 * data.c (Fvariable_binding_locus):
181 * window.c (run_window_configuration_change_hook): Adjust users.
182 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
183 Use decode_live_frame.
184
170da1ec
DA
1852013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
186
187 Be more careful if selected window shows the buffer other than current,
188 use window_outdated only if this is not so. This change should also
189 address some weird issues discussed in Bug#13012.
190 * window.h (window_outdated): New prototype.
191 * window.c (window_outdated): Now here. Convert from static and
192 always assume window's buffer.
193 (Fwindow_end, Fwindow_line_height): Use it.
194 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
195 and always assume window's buffer.
196 (redisplay_window): Adjust user.
e5eefe9b 197 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
198 check whether mode line should be updated only if selected window
199 shows current buffer.
200 (run_window_scroll_functions): Use eassert for debugging check.
201 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
202
56b5d5b1
DA
2032013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
204
205 * window.c (window_scroll, window_scroll_pixel_based)
206 (window_scroll_line_based): Use bool for booleans.
207
2878ba7e
PE
2082013-08-06 Paul Eggert <eggert@cs.ucla.edu>
209
210 * process.c: Fix minor off-by-one issues in descriptor counts.
211 This shouldn't fix any real bugs, but it cleans up the code a bit.
212 (max_process_desc, max_input_desc): -1, not 0, means none.
213 All uses changed.
214 (delete_input_desc): New function.
215 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
216 (deactivate_process): Scan backwards when recomuting max_process_desc;
217 that should be faster.
218 (init_process_emacs): Initialize max_input_desc.
219
e30b79c1
DA
2202013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
221
222 Use region cache to speedup bidi_find_paragraph_start.
223 * buffer.h (struct buffer): New member bidi_paragraph_cache.
224 Rename cache_long_line_scans to cache_long_scans.
225 * buffer.c (bset_cache_long_line_scans): Rename to
226 bset_cache_long_scans.
227 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
228 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
229 into account.
230 (syms_of_buffer): Rename cache-long-line-scans to
231 cache-long-scans. Adjust docstring.
232 * search.c (newline_cache_on_off):
233 * indent.c (width_run_cache_on_off): Adjust users.
234 * bidi.c (bidi_paragraph_cache_on_off): New function.
235 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
236 * insdel.c (prepare_to_modify_buffer): Invalidate
237 bidi_paragraph_cache if enabled.
238
00012b86
DA
2392013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
240
241 Invalidate region caches only if buffer text is going to be changed.
242 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
243 (modify_text): ...new prototype.
244 (prepare_to_modify_buffer_1): New prototype.
245 * textprop.c (modify_region): Rename to...
246 (modify_text_properties): ...new function.
247 (add_text_properties_1, set_text_properties, Fremove_text_properties)
248 (Fremove_list_of_text_properties): Adjust users.
249 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
250 (modify_text): ...new function.
251 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
252 (prepare_to_modify_buffer_1): ...new function.
253 * casefiddle.c (casify_region):
254 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
255 (Ftranspose_regions): Use modify_text.
256
dc6c0eda
SM
2572013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
258
259 * lisp.mk (lisp): Add nadvice.elc.
260
8f3a2c26
DA
2612013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
262
263 New macro to iterate over live buffers similar to frames.
264 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
265 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
266 Declare buffer-related variables here to offload lisp.h.
267 * buffer.c (Vbuffer_alist): Adjust comment.
268 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
269 (other_buffer_safely):
270 * data.c (store_symval_forwarding):
271 * dispnew.c (Fframe_or_buffer_changed_p):
272 * fileio.c (Fdo_auto_save):
273 * filelock.c (unlock_all_files):
274 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
275
e0fdb694
PE
2762013-08-04 Paul Eggert <eggert@cs.ucla.edu>
277
278 Fix some minor races in hosts lacking mkostemp (Bug#15015).
279 * callproc.c (create_temp_file):
280 * filelock.c (create_lock_file):
281 Assume mkostemp, since it's now provided by Gnulib.
282
63f5c6c2
EZ
2832013-08-04 Eli Zaretskii <eliz@gnu.org>
284
285 * w32.c (mkostemp): New function.
286 (mktemp): Remove, no longer used. Most of the code reused in
287 mkostemp. (Bug#15015)
484ab239 288 (mktemp): Don't undef.
63f5c6c2 289
f0b79313
DA
2902013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
291
292 * dispnew.c (glyph_matrix_count, glyph_pool_count):
293 Move under GLYPH_DEBUG and ENABLE_CHECKING.
294 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
295 (free_glyph_pool, check_glyph_memory): Likewise for
296 all users. Adjust comments where appropriate.
297
98f638d6
PE
2982013-08-03 Paul Eggert <eggert@cs.ucla.edu>
299
300 * composite.h: Minor fixups.
301 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
302 to fix a misspelling, and change it to an inline function while
303 we're at it (it need not be a macro). All uses changed.
304 (composition_method, composition_valid_p):
305 Rewrite to avoid assignments in if-conditions.
306
75c59fb3
DA
3072013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
308
309 Do not use global Lisp_Object in composition macros.
310 * composite.h (composition_temp): Remove declaration.
311 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
312 (composition_method, composition_valid_p): ...inline functions.
416a3e01 313 (compose_region): Remove the leftover.
75c59fb3
DA
314 * composite.c (composition_temp): Remove.
315 (run_composition_function, update_compositions)
316 (composition_compute_stop_pos, composition_adjust_point)
317 (Ffind_composition_internal):
318 * coding.c (handle_composition_annotation):
319 * xdisp.c (handle_composition_prop, check_point_in_composition):
320 Related users changed.
321
a10c8269
DA
3222013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
323
324 Drop FRAME_PTR typedef.
325 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
326 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
327 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
328 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
329 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
330 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
331 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
332 All related users changed.
333
a104f656
SM
3342013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
335
336 * eval.c (default_toplevel_binding): New function.
337 (Fdefvar): Use it.
338 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
339 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
340 (syms_of_eval): Export them.
341 * data.c (Fdefault_value): Micro cleanup.
342 * term.c (init_tty): Use "false".
343
4b5c9326
DA
3442013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Fix X GC leak in GTK and raw (no toolkit) X ports.
347 * xterm.c (x_free_frame_resources): If white and black relief
348 GCs are allocated, always free them here.
349 * xfns.c (x_make_gc): Omit redundant initialization.
350 * widget.c (create_frame_gcs): Remove the leftover.
351 (EmacsFrameDestroy): Do nothing because all GCs are now freed
352 in x_free_frame_resources.
353
b19aa636
JD
3542013-08-02 Jan Djärv <jan.h.d@swipnet.se>
355
356 * nsterm.m (windowWillResize:toSize:): Only change title if
357 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
358 modifying it.
359 (viewDidEndLiveResize): New method.
360
361 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
362 inside NS_IMPL_COCOA.
363
af1f7e06
DA
3642013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
365
366 * insdel.c (adjust_after_replace, replace_range, del_range_2):
367 Do not check whether undo is enabled because record_insert and
368 record_delete does that themselves.
369
65b02bb9
DA
3702013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
371
372 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
373 member which is not really used any more.
374 (FRAME_XIC_BASE_FONTNAME): Remove.
375 * xfns.c (xic_free_fontset): Adjust user.
376 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
377 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
378 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
379 (xdialog_show): Use eassert for debugging check.
7ee0f047 380 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 381
6318cde0
PE
3822013-08-01 Paul Eggert <eggert@cs.ucla.edu>
383
384 * fileio.c, fns.c (merge): Move extern decl from here ...
385 * lisp.h (merge): ... to here.
386
6c1a09ba
DA
3872013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
388
389 Fix last font-related change.
390 * w32font.h (w32font_list_internal, w32font_match_internal):
391 Fix prototype.
392 * w32uniscribe.c (uniscribe_list, uniscribe_match):
393 (uniscribe_list_family): Adjust to match font API change.
394 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
395 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
396
f8c20208
DA
3972013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
398
399 * frame.h (FRAME_MOUSE_UPDATE):
400 * nsterm.m (ns_frame_up_to_date): Omit redundant check
401 whether hlinfo->mouse_face_mouse_frame is non-NULL.
402
fdb396e2
DA
4032013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
404
405 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
406 * font.h (struct font_driver): Change list, match, and list_family
407 functions to accept struct frame * as first arg.
408 * font.c (font_score, font_compare, font_sort_entities): Remove
409 prototypes.
410 (font_sort_entities, font_list_entities, font_select_entity):
411 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
412 match font API change.
413 * xfont.c (xfont_list, xfont_match, xfont_list_family):
414 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
415 * ftxfont.c (ftxfont_list, ftxfont_match):
416 * xftfont.c (xftfont_list, xftfont_match):
417 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
418 * w32font.c (w32font_list, w32font_match, w32font_list):
419 (w32font_list_internal, w32_font_match_internal): Likewise.
420 * xfaces.c (Fx_family_fonts): Adjust user.
421
52b8a085
DA
4222013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
423
424 Do not use pure Xism x_wm_set_icon_position in non-X ports.
425 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
426 only if HAVE_X_WINDOWS is in use.
427 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
428 * nsterm.m (x_wm_set_icon_position): Remove no-op.
429 * w32term.c (x_wm_set_icon_position): Likewise.
430 * w32fns.c (x_icon): Adjust user.
431
c791c18e
DA
4322013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
433
434 * xterm.c (last_mouse_press_frame): Remove the
435 leftover which is not really used any more.
436 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
437 (x_flush): Call XFlush once per each X display, not frame.
438 This is better because this code always unconditionally skips
439 non-X frames in Vframe_list and issues the only XFlush if we
440 have more than one X frame on the same X display.
2f935d86
DA
441 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
442 Use bool for booleans.
443 (x_draw_glyph_string_background, cvt_string_to_pixel):
444 (cvt_pixel_dtor): Drop unnecessary prototypes.
445 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 446
f435830e
DA
4472013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
448
449 Drop unnecessary functions that deals with frame pixel size.
450 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
451 (x_pixel_height): Drop prototypes.
452 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
453 (x_pixel_height): Drop implementations.
454 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
455 which should be always valid for window frame.
456 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
457 * w32menu.c (Fx_popup_dialog):
458 * xmenu.c (Fx_popup_dialog): Likewise for both.
459
84231434
DA
4602013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
461
462 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
463 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
464 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
465 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
466 and mention nil frame in docstring.
84231434 467
959067a1
DA
4682013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
469
470 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
471 (x_figure_window_size): Likewise. Adjust to return long.
472 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
473 (toplevel): Move Qterminal_live_p to...
474 * terminal.c (toplevel): ...here, make it static, and...
475 (syms_of_terminal): ...DEFSYM here.
476 * frame.h (Qterminal_live_p): Remove declaration.
477 (make_frame, x_figure_window_size): Adjust prototype.
478 * nsfns.m (Fx_create_frame): Use long for window flags.
479
f4b169ce
PE
4802013-07-30 Paul Eggert <eggert@cs.ucla.edu>
481
482 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
483 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
484 Do not assume that emacs_close (INT_MAX) is a no-op.
485
bee6a2c7
DA
4862013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
487
488 * xfaces.c (make_face_cache): For struct face_cache, prefer
489 xmalloc to xzalloc and so avoid redundant call to memset.
490 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
491
d7e6881a
DA
4922013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
493
494 * fringe.c (draw_window_fringes, update_window_fringes)
495 (compute_fringe_widths):
496 * w32term.c (x_draw_glyph_string):
497 * window.c (candidate_window_p, Frecenter):
498 * xfaces.c (realize_basic_faces, realize_default_face)
499 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
500 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
501 * xfns.c (x_set_cursor_color, xic_free_xfontset):
502 * xmenu.c (Fx_menu_bar_open_internal):
503 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
504 * xsettings.c (xft_settings_event):
505 * xterm.c (x_draw_glyph_string, x_had_errors_p):
506 Use bool for booleans. Adjust style and comments where
507 appropriate.
508 * dispextern.h (draw_window_fringes, update_window_fringes)
509 (compute_fringe_widths):
510 * xterm.h (x_had_errors_p): Adjust prototype.
511
ec3058af
DA
5122013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
513
514 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
515 CHECK_LIST. Rewrite the loop to avoid useless local variable.
516
218e0637
DA
5172013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
518
519 * fns.c (toplevel): Remove comment before Fsafe_length because
520 it checks for QUIT.
521
e560aba9
PE
5222013-07-28 Paul Eggert <eggert@cs.ucla.edu>
523
524 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
525
2e5ce5de
EZ
5262013-07-28 Eli Zaretskii <eliz@gnu.org>
527
528 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
529 frame which got the message is still alive, before dereferencing
530 its pointer. (Bug#14970)
531
532 * frame.c (delete_frame): Test "this" frame's minibuffer window to
533 be a live window, before using it as such. (Bug#14970)
534
e95da6d3
EZ
5352013-07-27 Eli Zaretskii <eliz@gnu.org>
536
537 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
538 w32_detect_focus_change instead of doing part of its job by hand.
539 This fixes the problem whereby FOCUS_OUT events were not sent to
540 the event queue.
541
a8f93651
EZ
5422013-07-26 Eli Zaretskii <eliz@gnu.org>
543
fec92060
EZ
544 * process.c (Fprocess_list): Doc fix.
545
a8f93651
EZ
546 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
547 being re-exposed only if it didn't ask to become visible.
548 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
549 was previously iconified. (Bug#14841)
550 (x_iconify_frame): Mark the frame iconified.
551
d5a7a9d9
PE
5522013-07-26 Paul Eggert <eggert@cs.ucla.edu>
553
554 Fix minor problems found by static checking.
555 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
556 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
557
56ea7291
SM
5582013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
559
560 * eval.c (set_specpdl_old_value): New function.
561 (unbind_to): Minor simplification.
562 (get_backtrace_frame): New function.
563 (Fbacktrace_frame): Use it. Add `base' argument.
564 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
565 (syms_of_eval): Export backtrace-eval.
566 * xterm.c (x_focus_changed): Simplify.
567
9d611ffe
PE
5682013-07-25 Paul Eggert <eggert@cs.ucla.edu>
569
570 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
571
999c74e3
EZ
5722013-07-24 Eli Zaretskii <eliz@gnu.org>
573
574 * xdisp.c (redisplay_window): Instead of moving point out of
575 scroll margin, reject the force_start method, and try scrolling
576 instead. (Bug#14780)
577
198fa217
KB
5782013-07-24 Ken Brown <kbrown@cornell.edu>
579
580 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
581 (Bug#14944).
582
53840e55
PE
5832013-07-24 Paul Eggert <eggert@cs.ucla.edu>
584
585 * eval.c (Fprogn): Do not check that BODY is a proper list.
586 This undoes the previous change. The check slows down the
587 interpreter, and is not needed to prevent a crash. See
588 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
589
60967f56
GM
5902013-07-23 Glenn Morris <rgm@gnu.org>
591
592 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
593
9ca960e2
PE
5942013-07-23 Paul Eggert <eggert@cs.ucla.edu>
595
a29c3e6d
PE
596 Port to GNU/Linux systems with tinfo but not ncurses.
597 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
598 to decide whether ncurses is being used. Without this change,
599 GCC complains about tgetent not being declared, on a system
600 that has tinfo installed but ncurses not installed.
601
f274311c
PE
602 * eval.c (Fprogn): Check that BODY is a proper list.
603
16b0520a
PE
604 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
605 * data.c (Fsetq_default):
606 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
607 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
608 (Fcondition_case):
609 Tune by taking advantage of the fact that ARGS is always a list
610 when a function is declared to have UNEVALLED args.
611
9ca960e2
PE
612 * emacsgtkfixed.c: Port to GCC 4.6.
613 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
614
afacaa1b
JB
6152013-07-23 Juanma Barranquero <lekktu@gmail.com>
616
617 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
618 here to silence compiler warnings.
619
368a85a4
PE
6202013-07-22 Paul Eggert <eggert@cs.ucla.edu>
621
622 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
623 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
624 from messing up Emacs's 'struct frame' (Bug#14923).
625
f4e891b5
PE
6262013-07-21 Paul Eggert <eggert@cs.ucla.edu>
627
628 * alloc.c (make_save_ptr_ptr): Define this function.
629 It was inadvertently omitted. It's needed only if
630 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
631
96c8b65e
JD
6322013-07-21 Jan Djärv <jan.h.d@swipnet.se>
633
634 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
635 frame have focus (Bug#14895).
636
ee010797
PE
6372013-07-21 Paul Eggert <eggert@cs.ucla.edu>
638
639 Avoid vfork-related deadlock more cleanly.
640 * callproc.c (child_setup): When the child's exec fails, output
641 the program name, as that's more useful. Use O_NONBLOCK to avoid
642 deadlock.
643 * process.c (create_process_1): Remove; no longer needed.
644 (create_process): Remove timer hack; no longer needed, now that
645 the child avoids deadlock.
646
f0398ec1 6472013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
648
649 * image.c (Fimage_flush): Fix doc typo.
650
b2a069c2
PE
6512013-07-20 Paul Eggert <eggert@cs.ucla.edu>
652
6496aec9
PE
653 Fix array bounds violation when pty allocation fails.
654 * process.c (PTY_NAME_SIZE): New constant.
655 (pty_name): Remove static variable; it's now auto.
656 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
657 Take pty_name as an arg rather than using a static variable.
658 All callers changed.
659 (create_process): Recover pty_flag from process, not from volatile local.
660 (create_pty): Stay inside array even when pty allocation fails.
661 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
662
b2a069c2
PE
663 * lread.c (Fload): Avoid initialization only when lint checking.
664 Mention that it's needed only for older GCCs.
665
99107004
KH
6662013-07-20 Kenichi Handa <handa@gnu.org>
667
668 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
669 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
670
6b1b199d
AS
6712013-07-20 Andreas Schwab <schwab@linux-m68k.org>
672
673 * lread.c (Fload): Avoid uninitialized warning.
674
4195afc3
PE
6752013-07-19 Paul Eggert <eggert@cs.ucla.edu>
676
3f5bef16
PE
677 Fix some minor file descriptor leaks and related glitches.
678 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
679 (create_lock_file): Use write, not emacs_write.
680 * image.c (slurp_file, png_load_body):
681 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
682 (server_accept_connection):
683 Don't leak an fd on memory allocation failure.
684 * image.c (slurp_file): Add a cheap heuristic for growing files.
685 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
686 as that's what the other routines do. Maybe input need not be
687 blocked at all, but it's better to be consistent.
688 Avoid undefined behavior when strlen is zero.
689
4195afc3
PE
690 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
691 (NSTATICS): Now a constant; doesn't need to be a macro.
692
a1aeeffe
RS
6932013-07-19 Richard Stallman <rms@gnu.org>
694
695 * coding.c (decode_coding_utf_8): Add simple loop for fast
696 processing of ASCII characters.
697
63b34baa
PE
6982013-07-19 Paul Eggert <eggert@cs.ucla.edu>
699
700 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
701
621dd9ac
EZ
7022013-07-19 Eli Zaretskii <eliz@gnu.org>
703
704 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
705 unportable 'struct x_display_info'.
706 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
707 is a portable type.
708
1396ac86
PE
7092013-07-19 Paul Eggert <eggert@cs.ucla.edu>
710
ab9980cd
PE
711 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
712 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
713 or fscanf fails.
714 (system_process_attributes): Prefer plain char to unsigned char
715 when either will do. Clean up properly if interrupted or if
716 memory allocations fail. Don't assume sscanf succeeds. Remove
717 no-longer-needed workaround to stop GCC from whining. Read
718 command-line once, instead of multiple times. Check read status a
719 bit more carefully.
720
1396ac86
PE
721 Fix obscure porting bug with varargs functions.
722 The code assumed that int is treated like ptrdiff_t in a vararg
723 function, which is not a portable assumption. There was a similar
724 -- though these days less likely -- porting problem with various
725 assumptions that pointers of different types all smell the same as
726 far as vararg functions is conserved. To make this problem less
727 likely in the future, redo the API to use varargs functions.
728 * alloc.c (make_save_value): Remove this vararg function.
729 All uses changed to ...
730 (make_save_int_int_int, make_save_obj_obj_obj_obj)
731 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
732 New functions.
733 (make_save_ptr): Rename from make_save_pointer, for consistency with
734 the above. Define only on platforms that need it. All uses changed.
735
4d19d194
PE
7362013-07-18 Paul Eggert <eggert@cs.ucla.edu>
737
738 * keyboard.c: Try to fix typos in previous change.
739 (DISPLAY_LIST_INFO): New macro.
740 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 741 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 742
945c5bb1
JB
7432013-07-18 Juanma Barranquero <lekktu@gmail.com>
744
745 * keyboard.c (kbd_buffer_get_event):
746 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
747 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
748
f4b1eb36
PE
7492013-07-18 Paul Eggert <eggert@cs.ucla.edu>
750
5e679a2c
PE
751 * filelock.c: Fix unlikely file descriptor leaks.
752 (get_boot_time_1): Rework to avoid using emacs_open.
753 This doesn't actually fix a leak, but is better anyway.
754 (read_lock_data): Use read, not emacs_read.
755
a8cd4836
PE
756 * doc.c: Fix minor memory and file descriptor leaks.
757 * doc.c (get_doc_string): Fix memory leak when doc file absent.
758 (get_doc_string, Fsnarf_documentation):
759 Fix file descriptor leak on error.
760
ef30e638
PE
761 * term.c: Fix minor fdopen-related file descriptor leaks.
762 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
763 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
764
f4b1eb36
PE
765 * charset.c: Fix file descriptor leaks and errno issues.
766 Include <errno.h>.
767 (load_charset_map_from_file): Don't leak file descriptor on error.
768 Use plain record_xmalloc since the allocation is larger than
769 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
770 of entries.
771 * eval.c (record_unwind_protect_nothing):
772 * fileio.c (fclose_unwind):
773 New functions.
774 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
775 The replacement doesn't block input, but that no longer seems
776 necessary.
777
b648c163
PE
7782013-07-17 Paul Eggert <eggert@cs.ucla.edu>
779
a0931322
PE
780 * lread.c: Fix file descriptor leaks and errno issues.
781 (Fload): Close some races that leaked fds or streams when 'load'
782 was interrupted.
783 (Fload, openp): Report error number of last nontrivial failure to open.
784 ENOENT counts as trivial.
785 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
786 New functions.
787 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
788 now that the function is always called with a nonnegative arg.
789 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
790 All uses replaced with ...
791 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
792
b648c163
PE
793 A few more minor file errno-reporting bugs.
794 * callproc.c (Fcall_process):
795 * doc.c (Fsnarf_documentation):
796 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
797 * process.c (set_socket_option):
798 Don't let a constructor trash errno.
799 * doc.c: Include <errno.h>.
800
b1dc4084
JB
8012013-07-16 Juanma Barranquero <lekktu@gmail.com>
802
803 * w32fns.c (unwind_create_tip_frame): Fix declaration.
804
c43843aa
PE
8052013-07-16 Paul Eggert <eggert@cs.ucla.edu>
806
50a30cce
PE
807 Fix w32 bug with call-process-region (Bug#14885).
808 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
809 to Fcall_process when the input is empty. This simplifies the
810 code a bit. It makes no difference on POSIXish platforms but
811 apparently it fixes a bug on w32.
812
44e18199 813 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
814 * fileio.c (close_file_unwind): Don't close if FD is negative;
815 this can happen when unwinding a zapped file descriptor.
816 (Finsert_file_contents): Unwind-protect the fd before the point marker,
817 in case Emacs runs out of memory between the two unwind-protects.
818 Don't trash errno when closing FD.
819 Zap the FD in the specpdl when closing it, instead of deferring
820 the removal of the unwind-protect; this fixes a bug where a child
821 function unwinds the stack past us.
822
27e498e6
PE
823 New unwind-protect flavors to better type-check C callbacks.
824 This also lessens the need to write wrappers for callbacks,
825 and the need for make_save_pointer.
826 * alloca.c (free_save_value):
827 * atimer.c (run_all_atimers):
828 Now extern.
829 * alloc.c (safe_alloca_unwind):
830 * atimer.c (unwind_stop_other_atimers):
831 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
832 * menu.c (cleanup_popup_menu) [HAVE_NS]:
833 * minibuf.c (choose_minibuf_frame_1):
834 * process.c (make_serial_process_unwind):
835 * xdisp.h (pop_message_unwind):
836 * xselect.c (queue_selection_requests_unwind):
837 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
838 * alloca.c (record_xmalloc):
839 Prefer record_unwind_protect_ptr to record_unwind_protect with
840 make_save_pointer.
841 * alloca.c (Fgarbage_collect):
842 Prefer record_unwind_protect_void to passing a dummy.
843 * buffer.c (restore_buffer):
844 * window.c (restore_window_configuration):
845 * xfns.c, w32fns.c (do_unwind_create_frame)
846 New wrapper. All record-unwind uses of wrappee changed.
847 * buffer.c (set_buffer_if_live):
848 * callproc.c (call_process_cleanup, delete_temp_file):
849 * coding.c (code_conversion_restore):
850 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
851 * editfns.c (save_excursion_restore)
852 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
853 (save_restriction_restore):
854 * eval.c (restore_stack_limits, un_autoload):
855 * fns.c (require_unwind):
856 * keyboard.c (recursive_edit_unwind, tracking_off):
857 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
858 * macros.c (pop_kbd_macro, restore_menu_items):
859 * nsfns.m (unwind_create_frame):
860 * print.c (print_unwind):
861 * process.c (start_process_unwind):
862 * search.c (unwind_set_match_data):
863 * window.c (select_window_norecord, select_frame_norecord):
864 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
865 (fast_set_selected_frame):
866 * xfns.c, w32fns.c (unwind_create_tip_frame):
867 Return void, not a dummy Lisp_Object. All uses changed.
868 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
869 * callproc.c (call_process_kill):
870 * fileio.c (restore_point_unwind, decide_coding_unwind)
871 (build_annotations_unwind):
872 * insdel.c (Fcombine_after_change_execute_1):
873 * keyboard.c (read_char_help_form_unwind):
874 * menu.c (unuse_menu_items):
875 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
876 * sound.c (sound_cleanup):
877 * xdisp.c (unwind_redisplay):
878 * xfns.c (clean_up_dialog):
879 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
880 Accept no args and return void, instead of accepting and returning
881 a dummy Lisp_Object. All uses changed.
882 * cygw32.c (fchdir_unwind):
883 * fileio.c (close_file_unwind):
884 * keyboard.c (restore_kboard_configuration):
885 * lread.c (readevalllop_1):
886 * process.c (wait_reading_process_output_unwind):
887 Accept int and return void, rather than accepting an Emacs integer
888 and returning a dummy object. In some cases this fixes an
889 unlikely bug when the corresponding int is outside Emacs integer
890 range. All uses changed.
891 * dired.c (directory_files_internal_unwind):
892 * fileio.c (do_auto_save_unwind):
893 * gtkutil.c (pop_down_dialog):
894 * insdel.c (reset_var_on_error):
895 * lread.c (load_unwind):
896 * xfns.c (clean_up_file_dialog):
897 * xmenu.c, nsmenu.m (pop_down_menu):
898 * xmenu.c (cleanup_widget_value_tree):
899 * xselect.c (wait_for_property_change_unwind):
900 Accept pointer and return void, rather than accepting an Emacs
901 save value encapsulating the pointer and returning a dummy object.
902 All uses changed.
903 * editfns.c (Fformat): Update the saved pointer directly via
904 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
905 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
906 (unwind_body): New function.
907 (record_unwind_protect): First arg is now a function returning void,
908 not a dummy Lisp_Object.
909 (record_unwind_protect_ptr, record_unwind_protect_int)
910 (record_unwind_protect_void): New functions.
911 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
912 * fileio.c (struct auto_save_unwind): New type.
913 (do_auto_save_unwind): Use it.
914 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
915 * insdel.c (struct rvoe_arg): New type.
916 (reset_var_on_error): Use it.
917 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
918 New constants.
919 (specbinding_func): Remove; there are now several such functions.
920 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
921 (set_unwind_protect_ptr): New function.
922 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
923
4e604a5d
PE
924 Be simpler and more consistent about reporting I/O errors.
925 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
926 Say "Read error" and "Write error", rather than "I/O error", or
927 "IO error reading", or "IO error writing", when a read or write
928 error occurs.
929 * process.c (Fmake_network_process, wait_reading_process_output)
930 (send_process, Fprocess_send_eof, wait_reading_process_output):
931 Capitalize diagnostics consistently. Put "failed foo" at the
932 start of the diagnostic, so that we don't capitalize the
933 function name "foo". Consistently say "failed" for such
934 diagnostics.
935 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
936 All callers changed. This is so it can use report_file_error.
937 * sysdep.c (serial_open, serial_configure): Capitalize I/O
938 diagnostics consistently as above.
939
a9757f6a
PE
940 * fileio.c (report_file_errno): Fix errno reporting bug.
941 If the file name is neither null nor a pair, package it up as a
942 singleton list. All callers changed, both to this function and to
943 report_file_error. This fixes a bug where the memory allocator
944 invoked by list1 set errno so that the immediately following
945 report_file_error reported the wrong errno value.
946
c43843aa
PE
947 Fix minor problems found by --enable-gcc-warnings.
948 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
949 * keyboard.c (kbd_buffer_get_event): Remove unused local.
950
18c26d81
JD
9512013-07-16 Jan Djärv <jan.h.d@swipnet.se>
952
953 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
954 Set event->arg to Qt if switch-event shall be generated.
955 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
956
957 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
958
959 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
960 FOCUS_OUT_EVENT.
961
962 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
963 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
964 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
965 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 966 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
967 and there is a focused frame.
968 (head_table): Add focus-in and focus-out.
969 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
970 bind to handle-focus-in/out.
971
972 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
973 (Fhandle_switch_frame): Call Fhandle_focus_in.
974 (syms_of_frame): defsubr handle-focus-in/out.
975
6c6f1994
PE
9762013-07-16 Paul Eggert <eggert@cs.ucla.edu>
977
c7ddc792
PE
978 Fix porting bug to older POSIXish platforms (Bug#14862).
979 * sysdep.c (emacs_pipe): New function, that implements
980 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
981 This should port better to CentOS 5 and to Mac OS X 10.6.
982 All calls to pipe2 changed.
983
6c6f1994
PE
984 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
985 This makes the code easier to read and the executable a bit smaller.
986 Do not replace all calls to Fcons that happen to create lists,
987 just calls that are intended to create lists. For example, when
988 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
989 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
990 Similarly for list2 through list5.
991 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
992 * bytecode.c (exec_byte_code):
993 * callint.c (quotify_arg, Fcall_interactively):
994 * callproc.c (Fcall_process, create_temp_file):
995 * charset.c (load_charset_map_from_file)
996 (Fdefine_charset_internal, init_charset):
997 * coding.c (get_translation_table, detect_coding_system)
998 (Fcheck_coding_systems_region)
999 (Fset_terminal_coding_system_internal)
1000 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1001 * composite.c (update_compositions, Ffind_composition_internal):
1002 * dired.c (directory_files_internal, file_name_completion)
1003 (Fsystem_users):
1004 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1005 * doc.c (Fsnarf_documentation):
1006 * editfns.c (Fmessage_box):
1007 * emacs.c (main):
1008 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1009 (Feval, eval_sub, Ffuncall, apply_lambda):
1010 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1011 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1012 (Fset_file_times, Finsert_file_contents)
1013 (Fchoose_write_coding_system, Fwrite_region):
1014 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1015 * font.c (font_registry_charsets, font_parse_fcname)
1016 (font_prepare_cache, font_update_drivers, Flist_fonts):
1017 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1018 * frame.c (make_frame, Fmake_terminal_frame)
1019 (x_set_frame_parameters, x_report_frame_params)
1020 (x_default_parameter, Fx_parse_geometry):
1021 * ftfont.c (syms_of_ftfont):
1022 * image.c (gif_load):
1023 * keyboard.c (command_loop_1):
1024 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1025 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1026 (Fminor_mode_key_binding, accessible_keymaps_1)
1027 (Faccessible_keymaps, Fwhere_is_internal):
1028 * lread.c (read_emacs_mule_char):
1029 * menu.c (find_and_return_menu_selection):
1030 * minibuf.c (get_minibuffer):
1031 * nsfns.m (Fns_perform_service):
1032 * nsfont.m (ns_script_to_charset):
1033 * nsmenu.m (ns_popup_dialog):
1034 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1035 (Fx_own_selection_internal):
1036 * nsterm.m (append2):
1037 * print.c (Fredirect_debugging_output)
1038 (print_prune_string_charset):
1039 * process.c (Fdelete_process, Fprocess_contact)
1040 (Fformat_network_address, set_socket_option)
1041 (read_and_dispose_of_process_output, write_queue_push)
1042 (send_process, exec_sentinel):
1043 * sound.c (Fplay_sound_internal):
1044 * textprop.c (validate_plist, add_properties)
1045 (Fput_text_property, Fadd_face_text_property)
1046 (copy_text_properties, text_property_list, syms_of_textprop):
1047 * unexaix.c (report_error):
1048 * unexcoff.c (report_error):
1049 * unexsol.c (unexec):
1050 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1051 (Fformat_mode_line, syms_of_xdisp):
1052 * xfaces.c (set_font_frame_param)
1053 (Finternal_lisp_face_attribute_values)
1054 (Finternal_merge_in_global_face, syms_of_xfaces):
1055 * xfns.c (x_default_scroll_bar_color_parameter)
1056 (x_default_font_parameter, x_create_tip_frame):
1057 * xfont.c (xfont_supported_scripts):
1058 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1059 (menu_help_callback, xmenu_show):
1060 * xml.c (make_dom):
1061 * xterm.c (set_wm_state):
1062 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1063 and similarly for list2 through list5.
1064
bafe80ce
PE
10652013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 * callproc.c (Fcall_process_region): Fix minor race and tune.
1068 (create_temp_file): New function, with the temp-file-creation part
1069 of the old Fcall_process_region. Use Fcopy_sequence to create the
1070 temp file name, rather than alloca + build_string, for simplicity.
1071 Don't bother to block input around the temp file creation;
1072 shouldn't be needed. Simplify use of mktemp. Use
1073 record_unwind_protect immediately after creating the temp file;
1074 this closes an unlikely race where the temp file was not removed.
1075 Use memcpy rather than an open-coded loop.
1076 (Fcall_process_region): Use the new function. If the input is
1077 empty, redirect from /dev/null rather than from a newly created
1078 empty temp file; this avoids unnecessary file system traffic.
1079
4700b5a5
PE
10802013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1081
5c97beae
PE
1082 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1083 Simplify by making this case like the other two. This is a bit
1084 slower on obsolete hosts, but the extra complexity isn't worth it.
1085
4700b5a5
PE
1086 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1087 * process.c (create_process) [!DOS_NT]:
1088 Remove now-unnecessary calls to emacs_close.
1089
f9a74c4c
EZ
10902013-07-13 Eli Zaretskii <eliz@gnu.org>
1091
922ae7ee
EZ
1092 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1093 returning early. (Bug#14850)
1094
f9a74c4c
EZ
1095 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1096 and inhibit-iso-escape-detection attributes of 'undecided'.
1097 (Bug#14822)
1098
5e301d76
PE
10992013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1100
69e0e5ee
PE
1101 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1102 Reported by Herbert J. Skuhra in
1103 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1104
5e301d76
PE
1105 Don't lose top specpdl entry when memory is exhausted.
1106 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1107 specpdl overflow here, to simplify callers; all callers changed.
1108 Always reserve an unused entry at the stack top; this avoids
1109 losing the top entry's information when memory is exhausted.
1110
7e649856
PE
11112013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1112
a773ed9a
PE
1113 Clean up errno reporting and fix some errno-reporting bugs.
1114 * callproc.c (Fcall_process):
1115 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1116 * process.c (create_process, Fmake_network_process):
1117 * unexaix.c (report_error):
1118 * unexcoff.c (report_error):
1119 Be more careful about reporting the errno of failed operations.
1120 The code previously reported the wrong errno sometimes.
1121 Also, prefer report_file_errno to setting errno + report_file_error.
1122 (Fcall_process): Look at openp return value rather than at path,
1123 as that's a bit faster and clearer when there's a numeric predicate.
1124 * fileio.c (report_file_errno): New function, with most of the
1125 old contents of report_file_error.
1126 (report_file_error): Use it.
1127 (Ffile_exists_p, Ffile_accessible_directory_p):
1128 Set errno to 0 when it is junk.
1129 * fileio.c (Faccess_file):
1130 * image.c (x_create_bitmap_from_file):
1131 Use faccessat rather than opening the file, to avoid the hassle of
1132 having a file descriptor open.
1133 * lisp.h (report_file_errno): New decl.
1134 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1135
7e649856
PE
1136 Minor EBADF fixes.
1137 * process.c (create_process, wait_reading_process_output) [AIX]:
1138 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1139 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1140 a multithreaded environment anyway).
1141 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1142
f6774c1a
AS
11432013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1144
1145 * image.c (x_find_image_file): Don't close a remote file handle.
1146
bacba3c2
PE
11472013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1148
1149 Fix races with threads and file descriptors.
1150 * callproc.c (Fcall_process_region):
1151 * dired.c (open_directory):
1152 * emacs.c (main, Fdaemon_initialized):
1153 * image.c (x_find_image_file):
1154 * inotify.c (Finotify_rm_watch):
1155 * lread.c (Flocate_file_internal):
1156 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1157 * term.c (term_mouse_moveto, init_tty):
1158 * termcap.c (tgetent):
1159 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1160 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1161 * unexhp9k800.c, unexmacosx.c (unexec):
1162 * callproc.c (Fcall_process_region):
1163 Use emacs_close, not close.
1164 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1165 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1166 and posix_close function on current platforms (which all lack them).
1167 (emacs_close): Use it. This should fix the races on GNU/Linux and
1168 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1169 and it should avoid closing random victim file descriptors on
1170 other platforms.
1171
653d4f43
PE
11722013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1173
c8536ec4
PE
1174 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1175 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1176 Touch up doc a bit.
1177
9c203066
PE
1178 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1179 This is for .gdbinit xbacktrace.
1180
653d4f43
PE
1181 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1182 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1183 (emacs_set_tty): Now static.
1184 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1185 * term.c (tty_capable_p, tty_default_color_capabilities)
1186 (get_tty_terminal, term_mouse_movement)
1187 (handle_one_term_event, init_tty, maybe_fatal):
1188 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1189 (tgetent, scan_file, name_match, compare_contin):
1190 * terminal.c (get_terminal):
1191 Use bool for boolean.
1192 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1193 Prefer char to unsigned char if either will do.
1194 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1195 (tty_write_glyphs): Prefer int to unsigned.
1196 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1197 All callers changed.
1198 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1199
45b683a1
PE
12002013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1201
29abe551
PE
1202 Port to C89.
1203 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1204 (B__dummy__): New dummy symbol, to pacify C89.
1205 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1206 they can't grok varargs macros.
1207 * dispnew.c (add_window_display_history)
1208 (add_frame_display_history):
1209 * print.c (print_object):
1210 * xdisp.c (debug_method_add):
1211 Use %p printf format only for void pointers.
1212 * emacs.c (usage_message): New constant, replacing ...
1213 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1214 (main): Adjust to usage reorg.
1215 * fns.c (syms_of_fns):
1216 * profiler.c (syms_of_profiler):
1217 Don't use non-constant struct initializers.
1218 * gnutls.h (gnutls_initstage_t):
1219 * lisp.h (enum Lisp_Fwd_Type):
1220 * lread.c (lisp_file_lexically_bound_p):
1221 * xsettings.c (anonymous enum):
1222 Remove trailing comma.
1223 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1224 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1225 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1226 (DEFUN): Use it.
1227 * regex.c (const_re_char): New type, to pacify strict C89.
1228 All uses of 'const re_char' replaced to use it.
1229 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1230 with glibc when strict C89. This change is imported from gnulib.
1231 All uses changed.
1232 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1233 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1234 Omit GNU_LINUX implementation, since it requires long long.
1235 * xterm.c (x_draw_underwave):
1236 Do not assume the traditional order of struct's members.
1237 (x_term_init): Rewrite to avoid the need for non-constant structure
1238 initializers.
1239
45b683a1 1240 Syntax cleanup, mostly replacing macros with functions.
763a086d 1241 This removes the need for the syntax_temp hack.
45b683a1
PE
1242 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1243 * syntax.c (SYNTAX_INLINE): New macro.
1244 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1245 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1246 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1247 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1248 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1249 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1250 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1251 Now constants, not macros.
1252 (syntax_temp) [!__GNUC__]: Remove.
1253 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1254 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1255 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1256 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1257 Move here from syntax.h; now functions, not macros. Except for the
1258 last function, these are static since only syntax.c uses them.
1259 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1260 All uses changed. Now a function, not a macro; use this fact
1261 to simplify the code.
1262 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1263 compiler bugs; no longer relevant.
1264 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1265 (SYNTAX_INLINE): New macro.
1266 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1267 for the new functions. Use bool for boolean member.
1268 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1269 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1270 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1271 (SETUP_BUFFER_SYNTAX_TABLE):
1272 Now extern inline functions, not macros.
1273 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1274 Remove; all uses replaced by implementation.
1275 (syntax_temp) [!__GNUC__]: Remove decl.
1276 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1277
29be4a50
JD
12782013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1279
1280 * emacs.c (main): Fix syntax error.
1281
954b166e
PE
12822013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Timestamp fixes for undo (Bug#14824).
1285 * atimer.c (schedule_atimer):
1286 * fileio.c (Ffile_newer_than_file_p):
1287 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1288 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1289 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1290 (syms_of_fileio): Remove Sclear_visited_file_name.
1291 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1292 file doesn't exist; this avoids an ambiguity with negative timestamps.
1293 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1294 * systime.h (make_emacs_time, invalid_emacs_time):
1295 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1296 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1297 * undo.c (record_first_change): Push (visited-file-modtime) onto
1298 undo list rather than reimplementing it by hand, incorrectly.
1299
d74647c3
KB
13002013-07-09 Ken Brown <kbrown@cornell.edu>
1301
1302 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1303
3c51b96b
JB
13042013-07-09 Juanma Barranquero <lekktu@gmail.com>
1305
1306 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1307
4ebbdd67
PE
13082013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 Handle errno and exit status a bit more carefully.
1311 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1312 number into an exit status. Instead, use EXIT_CANCELED.
1313 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1314 * callproc.c (relocate_fd):
1315 * emacs.c (close_output_streams, main):
1316 * process.c (create_process):
1317 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1318 Use emacs_perror for simplicity.
1319 * callproc.c (relocate_fd, main):
1320 * sysdep.c (sys_subshell):
1321 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1322 (shut_down_emacs): Use emacs_write, not write.
1323 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1324 * fileio.c (Fcopy_file, e_write):
1325 * nsterm.m (ns_select):
1326 * process.c (send_process):
1327 * sound.c (vox_write):
1328 Use emacs_write_sig, not emacs_write.
1329 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1330 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1331 New constants.
1332 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1333 of write.
1334 (emacs_full_write): New function.
1335 (emacs_write): Rewrite to use it.
1336 (emacswrite_sig, emacs_perror): New functions.
1337 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1338
44e18199 13392013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1340
1341 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1342 on NS even if it is present. Pixmap on NS is a void*.
1343
9caab067
PE
13442013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 Port to Ubuntu 10 (Bug#14803).
1347 Problem reported by T.V. Raman.
1348 * process.c (close_on_exec, accept4, process_socket):
1349 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1350
1d442672
EZ
13512013-07-07 Eli Zaretskii <eliz@gnu.org>
1352
1353 * w32.c (sys_dup): Declare prototype.
1354
1355 * filelock.c:
1356 * emacs.c:
1357 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1358
067428c1
PE
13592013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 Make file descriptors close-on-exec when possible (Bug#14803).
1362 This simplifies Emacs a bit, since it no longer needs to worry
1363 about closing file descriptors by hand in some cases.
1364 It also fixes some unlikely races. Not all such races, as
1365 libraries often open files internally without setting
1366 close-on-exec, but it's an improvement.
1367 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1368 * callproc.c (Fcall_process) [!MSDOS]:
1369 * emacs.c (main) [!DOS_NT]:
1370 * nsterm.m (ns_term_init):
1371 * process.c (create_process):
1372 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1373 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1374 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1375 Prefer mkostemp with O_CLOEXEC to mkstemp.
1376 * callproc.c (relocate_fd) [!WINDOWSNT]:
1377 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1378 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1379 now using pipe2.
1380 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1381 Make the resulting file descriptor close-on-exec.
1382 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1383 * lread.c (load_descriptor_list, load_descriptor_unwind):
1384 Remove; no longer needed. All uses removed.
1385 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1386 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1387 New functions.
1388 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1389 (Fmake_network_process, Fnetwork_interface_list):
1390 (Fnetwork_interface_info, server_accept_connection):
1391 Make newly-created socket close-on-exec.
1392 * sysdep.c (emacs_open, emacs_fopen):
1393 Make new-created descriptor close-on-exec.
1394 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1395 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1396
0da857dd
JD
13972013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1398
1399 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1400 for NS_IMPL_GNUSTEP.
1401
5f86adcd
PE
14022013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1403
1404 Fix openp errno handling.
1405 * callproc.c (Fcall_process): Preserve openp errno around close.
1406 * lread.c (openp): Set errno when returning -1, as some callers
1407 expect this.
1408
1afb1d07
JD
14092013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1410
1411 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1412
1413 * nsterm.h (NSSavePanel): Update comment.
1414 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1415 (ns_run_file_dialog): Declare.
1416
1417 * nsfns.m: Remove panelOK.
1418 (ns_fd_data): New.
1419 (ns_run_file_dialog): New function.
1420 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1421 event loop, so file dialog is popped up by ns_run_file_dialog, called
1422 by sendEvent (Bug#14578).
1423 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1424
3323c263
EZ
14252013-07-06 Eli Zaretskii <eliz@gnu.org>
1426
fdda0220
EZ
1427 * xdisp.c (default_line_pixel_height): New function.
1428 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1429 (try_cursor_movement, redisplay_window, try_window)
1430 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1431
1432 * window.c (window_scroll_pixel_based): use
1433 default_line_pixel_height.
1434
1435 * dispextern.h (default_line_pixel_height): Add prototype.
1436
1437 * frame.c (x_set_line_spacing): Accept a float value for
1438 line-spacing parameter, per the documentation.
1439
3323c263
EZ
1440 * data.c (Fmultibyte_string_p): Doc fix.
1441
47ba6d43
PE
14422013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1443
406af475
PE
1444 Use emacs_open more consistently when opening files.
1445 This handles EINTR more consistently now, and makes it easier
1446 to introduce other uniform changes to file descriptor handling.
1447 * src/systdio.h: New file.
1448 * src/buffer.c (mmap_init):
1449 * cygw32.c (chdir_to_default_directory):
1450 * dispnew.c (Fopen_termscript):
1451 * emacs.c (Fdaemon_initialized):
1452 * fileio.c (Fdo_auto_save):
1453 * image.c (slurp_file, png_load_body, jpeg_load_body):
1454 * keyboard.c (Fopen_dribble_file):
1455 * lread.c (Fload):
1456 * print.c (Fredirect_debugging_output):
1457 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1458 * termcap.c (tgetent):
1459 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1460 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1461 * w32term.c (w32_initialize) [CYGWIN]:
1462 * xfaces.c (Fx_load_color_file):
1463 Use emacs_open instead of plain open, and emacs_fopen instead of
1464 plain fopen.
1465 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1466 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1467 * callproc.c (default_output_mode): New constant.
1468 (Fcall_process): Use it to call emacs_open instead of plain creat.
1469 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1470 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1471 (emacs_fopen): New function.
1472 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1473 Include <lisp.h>, for emacs_open.
1474 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1475
47ba6d43
PE
1476 Remove duplicate #include directives.
1477 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1478 * xfaces.c:
1479 Don't include stdio.h twice.
1480 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1481 Don't include sys/types.h or stdio.h twice.
1482 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1483 * lread.c: Don't include coding.h twice.
1484 * nsfont.m: Don't include frame.h twice.
1485 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1486 * ralloc.c: Don't include <unistd.h> twice.
1487 * xdisp.c: Don't include font.h twice.
1488 * xterm.c: Don't include fontset.h twice.
1489 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1490
b9ed53d5
PE
14912013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 Scale ImageMagick images more carefully.
1494 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1495 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1496 Be more careful about avoiding undefined behavior after
1497 integer overflow and division by zero.
1498
cf13177e
YM
14992013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1500
1501 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1502 (syms_of_w32fns): DEFSYM them.
1503 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1504 (CCHDEVICENAME): Define macros if not defined.
1505 (struct MONITOR_INFO_EX): New struct.
1506 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1507 (enum_display_monitors_fn): New variable.
1508 (globals_of_w32fns): Initialize it.
1509 (Fx_display_pixel_width, Fx_display_pixel_height)
1510 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1511 multi-monitor setups in docstrings.
1512 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1513 screen size by primary monitor's millimeter per pixel.
1514 (w32_monitor_enum, w32_display_monitor_attributes_list)
1515 (w32_display_monitor_attributes_list_fallback)
1516 (Fw32_display_monitor_attributes_list): New functions.
1517 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1518
1519 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1520 if not defined.
1521 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1522
86dfb7a8
MA
15232013-07-04 Michael Albinus <michael.albinus@gmx.de>
1524
1525 * fileio.c (Qfile_notify_error): New error symbol.
1526
1527 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1528 * inotify.c (inotify_callback, symbol_to_inotifymask)
1529 (Finotify_add_watch, Finotify_rm_watch): Use it.
1530 (inotifyevent_to_event): Exchange order of cookie and file name.
1531 (Finotify_add_watch): Adapt docstring.
1532
1533 * lisp.h (Qfile_notify_error): Declare.
1534
2c1c974b
PE
15352013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1536
1537 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1538 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1539 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1540 which did not work (see <http://bugs.gnu.org/14569#307>).
1541 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1542 && (!noninteractive || initialized)). This attempts to thread
1543 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1544
7a35b20f
JB
15452013-07-04 Juanma Barranquero <lekktu@gmail.com>
1546
1547 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1548 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1549
1ce5cd04
PE
15502013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1551
1552 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1553 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1554 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1555 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1556
57f8c490
PE
15572013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1560 Define to __sys_siglist.
1561
bcffb5ca
EZ
15622013-07-02 Eli Zaretskii <eliz@gnu.org>
1563
1564 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1565 word-wrap, so that overflow-newline-into-fringe would work in
1566 visual-line-mode. (Bug#2749)
1567 (move_it_in_display_line_to): When the last scanned display
1568 element fits exactly on the display line, and
1569 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1570 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1571 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1572 finding buffer position that corresponds to pixel coordinates,
1573 e.g. in buffer_posn_from_coords.
1574
2c41e781
JD
15752013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1576
1577 * process.c (handle_child_signal): Call catch_child_signal if
1578 NS_IMPL_GNUSTEP.
1579
c2418359
PE
15802013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1581
52a9bcae
PE
1582 Don't convert function pointers to void * and back.
1583 It isn't portable C, and it's easy enough to avoid.
1584 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1585 (make_save_value): Add support for SAVE_FUNCPOINTER.
1586 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1587 * print.c (print_object):
1588 Distinguish function from object pointers.
1589 * lisp.h (SAVE_FUNCPOINTER): New constant.
1590 (SAVE_SLOT_BITS): Adjust to it.
1591 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1592 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1593 (voidfuncptr): New typedef.
1594 (struct Lisp_Save_Value): New member data[0].funcpointer.
1595 (XSAVE_FUNCPOINTER): New function.
1596
c2418359
PE
1597 Simplify buildobj processing.
1598 * Makefile.in (buildobj.h): Make it a sequence of strings each
1599 followed by comma, rather than a single string. Put it into a
1600 .tmp file in case there's an error while generating it.
1601 (gl-stamp): Use .tmp for temp files.
1602 (mostlyclean): Clean .tmp files.
1603 * doc.c (buildobj): Move to just the routine that needs it.
1604 It's now an array of strings, so processing is simpler.
1605
8f43ce49
PE
16062013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1609 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1610 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1611 Invoke malloc_enable_thread even when not interactive.
1612 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1613 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1614 in this case, since the underlying bug has now been fixed.
1615
24827db9
JB
16162013-07-01 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1619 unlinking it (bug#14691).
1620
ef099a94
MN
16212013-06-30 Michal Nazarewicz <mina86@mina86.com>
1622
1623 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1624 before checking whether buffer is modified. This lets
1625 `kill-buffer-query-functions' cancel killing of the buffer or save
1626 its content before `kill-buffer' asks user the "Buffer %s
1627 modified; kill anyway?" question.
1628
9d3f2fc2
JD
16292013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1630
1631 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1632 Let the super performKeyEquivalent deal with them (Bug#14747).
1633
e6c6c8c7
PE
16342013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1635
1d71c1d9
PE
1636 * widget.c (resize_cb): Remove unused local.
1637
8f5f35cc
PE
1638 Do not use GTK 3 if it exists but cannot be compiled.
1639 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1640 * xterm.c (x_error_handler) [!USE_GTK]:
1641 Do not use GTK 3.
1642
e6c6c8c7
PE
1643 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1644
0ba54312
EZ
16452013-06-30 Eli Zaretskii <eliz@gnu.org>
1646
5d1c3286
EZ
1647 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1648 to the valid range of values. (Bug#14753)
1649
0ba54312
EZ
1650 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1651 when moving point by using the current glyph matrix. This avoids
1652 the need to force redisplay when this function is called in a
1653 loop.
1654
9c90cc06
PE
16552013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 Fix minor problems found by static checking.
1658 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1659 Redo the latter's body to sidestep GCC parenthesization warnings.
1660 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1661 * coding.c (detect_coding, detect_coding_system):
1662 * coding.h (struct undecided_spec):
1663 Use bool for boolean.
1664 * image.c (QCmax_width, QCmax_height): Now static.
1665 * xdisp.c (Fmove_point_visually): Remove unused local.
1666
4c672a0f
EZ
16672013-06-29 Eli Zaretskii <eliz@gnu.org>
1668
1669 * xdisp.c (Fmove_point_visually): New function.
1670
c1ea3abf
JB
16712013-06-28 Kenichi Handa <handa@gnu.org>
1672
1673 * coding.h (define_coding_undecided_arg_index): New enum.
1674 (coding_attr_index): New members
1675 coding_attr_undecided_inhibit_null_byte_detection,
1676 coding_attr_undecided_inhibit_iso_escape_detection,
1677 coding_attr_undecided_prefer_utf_8.
1678 (undecided_spec): New struct.
1679 (struct coding_system): New member `undecided' of the member
1680 `spec'.
1681
1682 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1683 (detect_coding): Likewise.
1684 (detect_coding_system): Likewise.
1685 (Fdefine_coding_system_internal): New coding system properties
1686 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1687 :prefer-utf-8.
1688 (syms_of_coding): Adjust for coding_arg_undecided_max.
1689
ba3de9e6
PE
16902013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 * image.c (x_from_xcolors): Remove unused local.
1693
547c9269
YM
16942013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1695
1696 Defer image data transfer between X client and server until actual
1697 display happens.
1698
1699 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1700 and `mask_img'.
1701
1702 * image.c (Destroy_Image): Remove.
1703 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1704 `mask_p', and `colors_p'. All uses changed.
1705 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1706 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1707 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1708 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1709 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1710 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1711 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1712 (image_get_x_image, image_unget_x_image): New functions or macros.
1713 (image_background, image_background_transparent, x_to_xcolors)
1714 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1715 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1716 instead of Destroy_Image.
1717 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1718 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1719 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1720 (imagemagick_load_image, svg_load_image): Use them instead of
1721 x_create_x_image_and_pixmap, and x_put_x_image followed by
1722 x_destroy_x_image, respectively.
1723 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1724 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1725 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1726 background_transparent fields.
1727 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1728 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1729
dae2f5ef
PE
17302013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1733 This mostly consists of undoing recent changes.
1734 * callproc.c (Fcall_process):
1735 * process.c (create_process):
1736 Do not worry about catching SIGCHLD here, undoing previous change.
1737 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1738 * process.c, process.h (catch_child_signal):
1739 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1740 * process.c (catch_child_handler): Don't worry about being called
1741 lazily and do not assume caller has blocked SIGCHLD, undoing
1742 previous change. Move first-time stuff back to
1743 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1744 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1745 set lib_child_handler if it's already initialized, which may
1746 help avoid problems on GNUStep.
1747
fa55d2aa
PE
17482013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1749
1750 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1751 * callproc.c (Fcall_process):
1752 * process.c (create_process):
1753 Make sure SIGCHLD is caught before we fork,
1754 since Emacs startup no arranges to catch SIGCHLD.
1755 * process.c (lib_child_handler): Initialize to null, not to
1756 dummy_handler.
1757 (catch_child_signal): Allow self to be called lazily.
1758 Do nothing if it's already been called.
1759 Assume caller has blocked SIGCHLD (all callers do now).
1760 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1761 just before it's really needed.
1762 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1763 since it hasn't been caught yet.
1764
f3f9606c
LMI
17652013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1766
1767 * image.c (compute_image_size): New function to implement
1768 :max-width and :max-height.
1769 (imagemagick_load_image): Use it.
1770
c7041908
PE
17712013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1774 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1775 Now extern.
1776 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1777 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1778 the SIGCHLD handler, since the code is not atomic and (due to glib)
1779 signals may be arriving now.
1780 * sysdep.c (init_signals): Do not catch child signals here;
1781 'main' now does that later, at a safer time.
1782
f86852b4
PE
17832013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1784
0dfeed58
PE
1785 Clean up SIGCHLD handling a bit (Bug#14569).
1786 * process.c, process.h (catch_child_signal):
1787 Now always extern, even if !NS_IMPL_GNUSTEP.
1788 * process.c (catch_child_signal): Move glib tickler here from
1789 init_process_emacs, so that it's done earlier in Emacs
1790 initialization. Also move the noninteractive && !initialized
1791 check here from init_process_emacs. This is all a bit cleaner for
1792 GNUish platforms, and I hope it works around the Cygwin bug.
1793 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1794 that glib signal handling is tickled before glib creates threads.
1795
f86852b4
PE
1796 * process.c (wait_reading_process_output): Avoid int overflow
1797 when reading more than 2 GiB total from a process.
1798
cbd6509c
PE
17992013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * process.c (create_process): Handle a couple more cases,
1802 i.e., work even if new_argv and wait_child_setup[i] are cached.
1803 Use Fcall_process's style for volatile vars.
1804
9de1114a
AS
18052013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1806
1807 * process.c (create_process): Mark PROCESS volatile.
1808
fbe9e0b9
PE
18092013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 Use C99-style flexible array members if available.
1812 This avoids some subtle aliasing issues, which typically
1813 aren't a problem with GCC but may be a problem elsewhere.
1814 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1815 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1816 In either case, it uses a flexible array member rather than
1817 the old struct hack. All uses changed.
1818 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1819 Adjust to sdata reorganization.
1820 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1821 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1822 that ports better to pre-C99 non-GCC.
1823 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1824 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1825 as the latter has changed.
1826 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1827 and port better to pre-C99 GCC.
1828 * image.c (struct xpm_cached_color):
1829 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1830 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1831 Use FLEXIBLE_ARRAY_MEMBER.
1832 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1833 Move decl to top level so it gets checked against implementation.
1834 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1835 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1836
1fc71008
PE
18372013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 * syntax.c: Integer cleanups.
1840 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1841 All uses that need 0-or-2 changed to:
1842 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1843 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1844 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1845 (char_quoted, prev_char_comend_first, back_comment)
1846 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1847 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1848 Use bool for boolean.
1849 (update_syntax_table, skip_chars, skip_syntaxes):
1850 Prefer int to unsigned when either will do.
1851 (back_comment): Return boolean success flag, like forw_comment,
1852 instead of positive-or-minus-1 (which might have overflowed int anyway).
1853 Don't stuff ptrdiff_t into int.
1854 (syntax_spec_code, syntax_code_spec): Now const.
1855 (Fmatching_paren, scan_lists, scan_sexps_forward):
1856 Use enum syntaxcode for syntax code.
1857 (Fmatching_paren): Check that arg is a character, not just an integer.
1858 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1859 (Finternal_describe_syntax_value): Omit no-longer-needed
1860 comparison to 0.
1861 (skip_chars): Use char, not unsigned char, when the distinction
1862 doesn't matter.
1863 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1864 * bytecode.c (exec_byte_code):
1865 * syntax.c (syntax_spec_code, Fchar_syntax)
1866 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1867 (init_syntax_once):
1868 * syntax.h (SYNTAX_WITH_FLAGS):
1869 Omit unnecessary casts.
1870
b932cad7
EZ
18712013-06-20 Eli Zaretskii <eliz@gnu.org>
1872
1873 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1874 line dimensions here, to avoid race conditions with the main
1875 thread. (Bug#14062, bug#14630, bug#14669)
1876
1877 * w32term.c (w32_draw_window_cursor): Compute the header line and
1878 mode line dimensions here.
1879 <w32_system_caret_window, w32_system_caret_hdr_height>:
1880 <w32_system_caret_mode_height>: New variables.
1881
1882 * w32term.h: Declare them.
1883
89561f72
PE
18842013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1885
5013fc08
PE
1886 * alloc.c (die): Move "assertion failed" string here ...
1887 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1888 COND when SUPPRESS_CHECKING. This shrinks the executable text
1889 size by 0.8% to 2.2% when configured with --enable-checking,
1890 depending on optimization flags (GCC 4.8.1 x86-64).
1891
89561f72
PE
1892 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1893
763a086d 18942013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
1895
1896 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1897 base is 2; this is more accurate.
1898
983aeb9a
JB
18992013-06-19 Juanma Barranquero <lekktu@gmail.com>
1900
1901 * sound.c (string_default): Move to !WINDOWSNT section.
1902 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1903
178ba3e6
PE
19042013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1905
bbc51b15
PE
1906 * sound.c: Integer cleanups.
1907 Remove unnecessary forward decls.
1908 (struct sound_device): The 'file' member is now a Lisp_Object, not
1909 a char *, so that we needn't invoke alloca on a huge size.
1910 (Fplay_sound_internal): Adjust to this.
1911 (string_default): New function.
1912 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1913 Use it to adjust to the struct sound_device change.
1914 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1915 (be2hs) [0]: Remove.
1916
178ba3e6
PE
1917 * syntax.c (skip_chars): Don't use uninitialized storage
1918 when searching a multibyte buffer for characters that are not in a
1919 unibyte string that contains non-ASCII characters.
1920
69f60cdc
JD
19212013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1922
1923 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1924 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1925
0d6224d4
PE
19262013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1929
3c542890
KH
19302013-06-18 Kenichi Handa <handa@gnu.org>
1931
f7e3f7cd
KH
1932 * font.c (Ffont_spec): Signal an error for an invalid font name
1933 (Bug#14648).
3c542890 1934
9349e5f7
PE
19352013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1938 In particular this ports to 32-bit sparc Sun cc.
1939 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1940 array with a dummy element at specpdl[-1], so that its address can
1941 be taken portably.
1942 (unbind_to): Do not copy the binding; not needed, now that we
1943 copy old_value in the one place where the copy is needed.
1944 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1945 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1946 (union specbinding): Rename from struct specbinding. Redo layout
1947 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1948 which is not portable. With Sun C 5.12 32-bit sparc, the
1949 declaration causes nargs to be an unsigned bitfield, a behavior
1950 that the C standard allows; but Emacs wants nargs to be signed.
1951 The overall type is now a union of structures rather than a
1952 structure of union of structures, and the 'kind' member is now a
1953 bitfield, so that the overall type doesn't grow. All uses changed.
1954 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1955
0a4df6a5
PE
19562013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1957
ec6ecaad
PE
1958 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1959 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1960
0a4df6a5
PE
1961 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1962
7bfe8dbc
EZ
19632013-06-17 Eli Zaretskii <eliz@gnu.org>
1964
1965 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1966 unless we know that the window w's frame is a frame object.
1967 Another attempt at solving bug#14062 and bug#14630.
1968
708e05f6
LMI
19692013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1970
1971 * textprop.c (property_set_type): New enum.
1972 (add_properties): Allow appending/prepending text properties.
1973 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1974 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1975 add_text_properties_1.
1976 (Fadd_face_text_property): New function that calls
1977 add_text_properties_1.
1978
84575e67
PE
19792013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1980
1981 Move functions from lisp.h to individual modules when possible.
1982 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1983 * alloc.c (XFLOAT_INIT, set_symbol_name):
1984 * buffer.c (CHECK_OVERLAY):
1985 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1986 (set_char_table_parent):
1987 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1988 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1989 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1990 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1991 (set_blv_valcell):
1992 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1993 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1994 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1995 (backtrace_args, backtrace_debug_on_exit):
1996 * floatfns.c (CHECK_FLOAT):
1997 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1998 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1999 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2000 (set_hash_index_slot):
2001 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2002 * marker.c (CHECK_MARKER):
2003 * textprop.c (CHECK_STRING_OR_BUFFER):
2004 * window.c (CHECK_WINDOW_CONFIGURATION):
2005 Move here from lisp.h, and make these functions static rather than
2006 extern inline.
2007 * buffer.c (Qoverlayp):
2008 * data.c (Qsubrp):
2009 * fns.c (Qhash_table_p):
2010 * window.c (Qwindow_configuration_p):
2011 Now static.
2012 * lisp.h: Remove the abovementioned defns and decls.
2013
44e18199 2014 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2015 In lisp.h, prefer functions to function-like macros, and
2016 constants to object-like macros, when either will do. This:
2017 . simplifies use, as there's no more need to worry about
2018 arguments' side effects being evaluated multiple times.
2019 . makes the code easier to debug on some platforms.
2020 However, when using gcc -O0, keep using function-like macros
2021 for a few critical operations, for performance reasons.
2022 This sort of thing isn't needed with gcc -Og, but -Og
2023 is a GCC 4.8 feature and isn't widely-enough available yet.
2024 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2025 Remove enum lsb_bits; no longer needed.
2026 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2027 * buffer.c (Qoverlap):
2028 * data.c (Qsubrp):
2029 * fns.c (Qhash_table_p):
2030 Now extern, so lisp.h can use these symbols.
2031 * dispextern.h: Include character.h, for MAX_CHAR etc.
2032 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2033 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2034 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2035 (GLYPH_CODE_P): Move here from lisp.h.
2036 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2037 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2038 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2039 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2040 XUNTAG now returns void *.
2041 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2042 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2043 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2044 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2045 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2046 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2047 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2048 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2049 New macros, renamed from their sans-lisp_h_ counterparts.
2050 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2051 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2052 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2053 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2054 If compiling via GCC without optimization, define these as macros
2055 in addition to inline functions.
2056 To disable this, compile with -DINLINING=0.
2057 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2058 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2059 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2060 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2061 (INTMASK, VALMASK): Now macros, since static values cannot be
2062 accessed from extern inline functions.
2063 (VALMASK): Also a constant, for benefit of old GDB.
2064 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2065 is INTEGERP, which can fold it in.
5165d44a 2066 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2067 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2068 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2069 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2070 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2071 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2072 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2073 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2074 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2075 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2076 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2077 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2078 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2079 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2080 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2081 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2082 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2083 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2084 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2085 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2086 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2087 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2088 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2089 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2090 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2091 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2092 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2093 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2094 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2095 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2096 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2097 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2098 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2099 Now functions.
2100 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2101 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2102 (VALMASK): Define in one place rather than in two, merging the
2103 USE_LSB_TAG parts; this is simpler.
2104 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2105 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2106 Move up, to avoid use before definition.
2107 Also include "globals.h" earlier, for the same reason.
2108 (make_natnum): New function.
2109 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2110 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2111 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2112 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2113 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2114 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2115 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2116 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2117 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2118 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2119 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2120 (Qwindow_configuration_p, Qimage): New forward declarations.
2121 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2122 (STRING_COPYIN): Remove; unused.
2123 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2124 (xcar_addr, xcdr_addr): New functions. All uses changed.
2125 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2126 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2127 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2128 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2129 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2130 (TYPE_RANGED_INTEGERP): Simplify.
2131 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2132 (setlocale, fixup_locale, synchronize_system_messages_locale)
2133 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2134 Now empty functions, not macros.
2135 (functionp): Return bool, not int.
2136 * window.c (Qwindow_configuration_p): Now extern,
2137 so window.h can use it.
2138 * window.h (Qwindowp): Move decl back to lisp.h.
2139
9583ec36
EZ
21402013-06-15 Eli Zaretskii <eliz@gnu.org>
2141
2142 * xdisp.c (Fline_pixel_height): New function, required for solving
2143 bug #14567.
2144
210272ce
PE
21452013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2146
2147 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2148
de0503df
SM
21492013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2150
2151 * lread.c (syms_of_lread):
2152 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2153
afbfe143
KD
21542013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2155
2156 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2157
d177e213
XF
21582013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2159
2160 * fileio.c (expand_file_name): Doc fix.
2161
05e3e412
PE
21622013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2163
f7394b12
PE
2164 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2165 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2166 Wait for self, not for 0. This can't hurt on GNU or similar
2167 system, and may help with Cygwin.
2168
05e3e412
PE
2169 * keyboard.c: Don't use PROP (...) as an lvalue.
2170 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2171 Use set_prop (A, B), not PROP (A) = B.
2172
17dd3097
EZ
21732013-06-10 Eli Zaretskii <eliz@gnu.org>
2174
2175 * xdisp.c (get_it_property): Use it->window instead of generating
2176 a Lisp object from it->w.
2177
52fab9c9
EZ
21782013-06-09 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2181 get-char-property the window that is being rendered, instead of
2182 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2183 (compute_display_string_pos): When W is NULL, use the current
2184 buffer as the object to pass to get-char-property.
2185 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2186 pointer member of the bidi iterator, since no window is pertinent
2187 to this function.
52fab9c9 2188
5bf97bfc
EZ
21892013-06-08 Eli Zaretskii <eliz@gnu.org>
2190
2191 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2192 being displayed, and pass it to compute_display_string_pos.
2193 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2194 (bidi_paragraph_init): All callers changed.
2195
2196 * xdisp.c (init_from_display_pos, init_iterator)
2197 (handle_single_display_spec, next_overlay_string)
2198 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2199 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2200 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2201 (compute_display_string_pos): Accept additional argument, the
2202 window being displayed, and pass it to Fget_char_property.
2203 (Bug#14575)
2204
2205 * dispextern.h (struct bidi_it): New member w, the window being
2206 displayed.
2207 (compute_display_string_pos): Adjust prototype.
2208
5de0e011
JD
22092013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2210
e7b41c4c 2211 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2212
2213 * process.c (wait_reading_process_output): Check for NS before GLIB.
2214 GLIB may be linked in due to rsvg, but ns_select must be called.
2215
5de0e011
JD
2216 * xgselect.c (xg_select): Remove call to window_system_available
2217 and g_main_context_pending at the top, so Gdk events (i.e. file
2218 notify) are processed when Emacs is started with -nw.
2219
a822acff
EZ
22202013-06-07 Eli Zaretskii <eliz@gnu.org>
2221
2222 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2223 (ctagsfiles3): New variable, includes only *.m files.
2224 (TAGS): Use an explicit language name in the regular expressions,
2225 to avoid transformation of '/SOMETHING' by MSYS to
2226 'c:\MSYS\SOMETHING'.
2227
6c0a9ed1
RC
22282013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2229
2230 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2231
9ef6111b
EZ
22322013-06-06 Eli Zaretskii <eliz@gnu.org>
2233
2234 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2235 still need to set the mouse pointer shape and activate help-echo.
2236 (Bug#14558)
2237
7d300d64
PE
22382013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 A few porting etc. fixes for the new file monitor code.
2241 See the thread containing
2242 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2243 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2244 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2245 (dir_monitor_callback, Fgfile_rm_watch):
2246 Use assq_no_quit instead of Fassoc, for speed.
2247 (dir_monitor_callback, Fgfile_rm_watch):
2248 eassert that the monitor is a fixnum.
2249 (dir_monitor_callback): No need for CDR_SAFE.
2250 Simplify building of lisp with alternative tails.
2251 (Fgfile_add_watch, Fgfile_rm_watch):
2252 Do not assume glib functions set errno reliably on failure.
2253 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2254 and signal an error otherwise.
2255 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2256 Use Fdelq instead of Fdelete, for speed.
2257
817ebfcf
EZ
22582013-06-05 Eli Zaretskii <eliz@gnu.org>
2259
2260 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2261 don't insist on being invoked on a highlighted tool-bar button.
2262 Avoids losing tool-bar functionality when mouse-highlight is nil.
2263 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2264 Don't highlight when mouse-highlight is nil.
2265 (note_mouse_highlight): When mouse-highlight is nil, don't return
2266 right away; instead, run tool-bar and mode-line highlight
2267 subroutine, clear any existing highlight, and revert the mouse
2268 pointer to its default shape. (Bug#14558)
2269
55577e7c
SM
22702013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2271
2272 * lisp.mk (lisp): Add prog-mode.el.
2273
f019a684
PE
22742013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2277 * process.c (dummy_handler): New function.
2278 (lib_child_handler): New static var.
2279 (handle_child_signal): Invoke it.
2280 (catch_child_signal): If a library has set up a signal handler,
2281 save it into lib_child_handler.
2282 (init_process_emacs): If using glib and not on Windows, tickle glib's
2283 child-handling code so that it initializes its private SIGCHLD handler.
2284 * syssignal.h (SA_SIGINFO): Default to 0.
2285 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2286 31; it should no longer be needed now.
2287
90db8702
MA
22882013-06-05 Michael Albinus <michael.albinus@gmx.de>
2289
2290 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2291
2292 * gfilenotify.c (globals_of_gfilenotify): New function.
2293 (syms_of_gfilenotify): Move global initialization there.
2294
2295 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2296
bfa3acd6
SM
22972013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2298
2299 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2300 * keyboard.c (menu_bar_items, tool_bar_items):
2301 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2302 not override local keymaps any more.
2303
ba59bd80
EZ
23042013-06-04 Eli Zaretskii <eliz@gnu.org>
2305
2306 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2307
7f203aa1
EZ
23082013-06-03 Eli Zaretskii <eliz@gnu.org>
2309
9337e206
EZ
2310 * w32console.c (initialize_w32_display): Return the dimensions of
2311 the console window via 2 additional arguments, not via the current
2312 frame. This avoids crashes due to overrunning the bounds of
2313 frame's decode_mode_spec_buffer, which is not resized following
2314 the change of the frame dimensions from the initial 10x10.
2315
2316 * w32term.h (w32_initialize_display_info): Adjust prototype.
2317
2318 * term.c (init_tty): Take dimensions of the frame from the values
2319 returned by initialize_w32_display.
2320
7f203aa1
EZ
2321 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2322 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2323 (LIBES): Add $(GFILENOTIFY_LIBS).
2324
2325 * w32inevt.c (handle_file_notifications): Add dummy implementation
2326 for !HAVE_W32NOTIFY.
2327
2328 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2329
55a87246
JD
23302013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2331
2332 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2333
2334 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2335
2336 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2337
3d5ee10a
PE
23382013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2339
2340 Fix minor problems found by static checking.
2341 * data.c (pure_write_error):
2342 Use xsignal2, not Fsignal, as Fsignal might return.
2343 * eval.c (set_backtrace_debug_on_exit): Now static.
2344 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2345 No longer inline. EXTERN_INLINE is needed only for functions
2346 defined in .h files. Reindent function header as per GNU style.
2347 (backtrace_p, backtrace_top, backtrace_next):
2348 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2349 compiler or linker. Add extern decls to pacify gcc -Wall.
2350 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2351 Now static.
2352 * frame.c (free_monitors): Define only on platforms that need it.
2353 * nsterm.m (ns_term_init):
2354 * process.c (catch_child_signal):
2355 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2356 defined on all porting targets these days.
2357 * process.c, process.h (catch_child_signal):
2358 Make it extern only if NS_IMPL_GNUSTEP is defined.
2359
e2d8a6f0
EZ
23602013-06-03 Eli Zaretskii <eliz@gnu.org>
2361
2362 * w32.c (gettimeofday): Make the signature identical to prototype
2363 in nt/inc/sys/time.h.
2364
a8a7c5f6
SM
23652013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2366
2367 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2368 .gdbinit.
2369
2370 * keyboard.c (safe_run_hooks_error): Improve error message.
2371
2372 * data.c (pure_write_error): Add `object' argument.
2373 * puresize.h (CHECK_IMPURE): Use it.
2374
c9628c79
MA
23752013-06-03 Michael Albinus <michael.albinus@gmx.de>
2376
2377 * Makefile.in (NOTIFY_OBJ): New variable.
2378 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2379
2380 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2381 Call syms_of_gfilenotify.
2382
2383 * gfilenotify.c: New file.
2384
2385 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2386 and Qfile_w32notify.
2387 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2388 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2389
2390 * lisp.h: Declare syms_of_gfilenotify.
2391
2392 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2393
2f592f95
SM
23942013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2395
2396 Merge the specpdl and backtrace stacks. Make the structure of the
2397 specpdl entries more obvious via a tagged union of structs.
2398 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2399 (enum specbind_tag): New enum.
2400 (struct specbinding): Make it a tagged union of structs.
2401 Add a case for backtrace records.
2402 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2403 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2404 (backtrace_debug_on_exit): New accessors.
2405 (struct backtrace): Remove.
2406 (struct catchtag): Remove backlist field.
2407 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2408 Move to eval.c.
2409 (Flocal_variable_p): Speed up the common case where the binding is
2410 already loaded.
2411 * eval.c (backtrace_list): Remove.
2412 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2413 (set_backtrace_args, set_backtrace_nargs)
2414 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2415 (backtrace_next): New functions.
2416 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2417 (unwind_to_catch, internal_lisp_condition_case)
2418 (internal_condition_case, internal_condition_case_1)
2419 (internal_condition_case_2, internal_condition_case_n): Don't bother
2420 with backtrace_list any more.
2421 (Fsignal): Adjust to new backtrace format.
2422 (grow_specpdl): Move up.
2423 (record_in_backtrace): New function.
2424 (eval_sub, Ffuncall): Use it.
2425 (apply_lambda): Adjust to new backtrace format.
2426 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2427 data.c.
2428 (specbind): Adjust to new specpdl format. Simplify.
2429 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2430 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2431 backtrace format.
2432 (mark_backtrace): Remove.
2433 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2434 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2435 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2436 Use mark_specpdl.
2437 * profiler.c (record_backtrace): Use get_backtrace.
2438 (handle_profiler_signal): Use backtrace_top_function.
2439 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2440 accessor functions.
2441
c0342369
JD
24422013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2443
2444 * process.h (catch_child_signal): Declare.
2445
2446 * process.c (catch_child_signal): New function.
2447 (init_process_emacs): Call it.
2448
2449 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2450 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2451 NS_IMPL_COCOA.
2452 (x_set_cursor_type): Remove declaration.
2453 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2454 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2455 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2456 (ns_get_color): Use F suffix on float.
2457 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2458 (ns_get_rgb_color): Remove.
2459 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2460 (note_mouse_movement): x and y are CGFloat.
2461 (ns_draw_fringe_bitmap): Remove unused rowY.
2462 Change #if to COCOA && >= 10_6.
2463 (ns_draw_window_cursor): Remove unused overspill.
2464 (ns_draw_underwave): width and x are EamcsCGFloat.
2465 (ns_draw_box): thickness is CGFloat.
2466 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2467 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2468 if not in main thread.
2469 (ns_get_pending_menu_title, ns_check_menu_open)
2470 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2471 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2472 (sendFromMainThread:): New method.
2473 (changeFont:): size is CGFloat.
2474 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2475 Disable warning about permanent text.
2476 (characterIndexForPoint:): Adjust return type depending on GNUStep
2477 version.
2478 (mouseDown:): delta is CGFloat.
2479 (updateFrameSize): Remove unised variable f.
2480 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2481 Cast float to EmacsCGFloat.
2482 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2483 also to -1 when restoring.
2484 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2485 inside NS_IMPL_COCOA.
2486 (toggleFullScreen:): Put call to toggleFullScreen inside
2487 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2488 (setPosition:portion:whole:): por is CGFloat.
2489 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2490 (mouseDown:): Use CGFloat.
2491 (mouseDragged:): Remove unised variable edge.
2492 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2493
2494 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2495 of CGFloat differs.
2496 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2497 when NS_IMPL_GNUSTEP.
2498 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2499 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2500 (EmacsToolbar): Add clearAll. Add tag argument to
2501 addDisplayItemWithImage.
2502 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2503
2504 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2505
2506 * nsmenu.m (ns_update_menubar): Make static.
2507 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2508 (fillWithWidgetValue:): Add cast to SEL for setAction.
2509 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2510 (update_frame_tool_bar): Update code for GNUStep.
2511 (clearAll): New method.
2512 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2513 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2514 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2515 call to insertItemWithItemIdentifier.
2516 (validateVisibleItems): Fix indentation.
2517 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2518 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2519 UtilityWindow to aStyle, remove call to setStyleMask.
2520
2521 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2522
2523 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2524 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2525 Use F suffix on floats.
2526 (ns_char_width): Returns CGFloat.
2527 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2528 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2529 DPSxshow.
2530 (ns_glyph_metrics): CGFloat instead of float.
2531
a0eb10b3
JB
2532 * nsfns.m (x_set_foreground_color, x_set_background_color):
2533 Use EmacsCGFloat.
2534 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2535 remove unused variables.
2536 (Fns_read_file_name): Keep track if panel is for save.
2537 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2538 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2539 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2540 Just return the input if GNUStep.
c0342369
JD
2541 (x_screen_planes): Remove.
2542 (Fxw_color_values): Use EmacsCGFloat
2543 (Fns_display_monitor_attributes_list): Only get screen number for
2544 Cocoa.
ef099a94 2545 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2546 EmacsSavePanel.
2547 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2548 ns_directory_from_panel.
2549
da9aff11
PE
25502013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 * process.c (handle_child_signal): Also use WCONTINUED.
2553 This is so that list-processes doesn't mistakenly list the process
2554 as stopped, when the process has actually been continued and is
2555 now running.
2556
0e64479a
PE
25572013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2558
fc186a96
PE
2559 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2560 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2561 not already configured.
2562
0e64479a
PE
2563 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2564
38b787fa
EZ
25652013-05-29 Eli Zaretskii <eliz@gnu.org>
2566
2567 * Makefile.in (mostlyclean): Remove *.res files.
2568
22513e52
SM
25692013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2570
2571 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2572 a buffer (bug#8447).
2573
6ef3db10
EZ
25742013-05-27 Eli Zaretskii <eliz@gnu.org>
2575
2576 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2577 display vector, and we backtrack, handle the case that the
2578 previous character position is also displayed from a display
2579 vector or covered by a display string or image. (Bug#14476)
2580
6799bb26
JD
25812013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2582
2583 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2584 (struct MonitorInfo, free_monitors): Remove.
2585 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2586 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2587 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2588 Qframes, Qsource.
2589
2590 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2591 (struct MonitorInfo, free_monitors): Remove.
2592 (ns_screen_name): Make static.
2593 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2594 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2595 Qframes, Qsource.
2596
2597 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2598 (struct MonitorInfo): New struct.
2599 (free_monitors, make_monitor_attribute_list): Declare.
2600
22513e52
SM
2601 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2602 New Lisp_Object:s.
6799bb26
JD
2603 (free_monitors, make_monitor_attribute_list): New functions.
2604 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2605 Qsource.
2606
38cd43eb
XF
26072013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2608
2609 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2610
2af0948d
SM
26112013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2612
a7eb9b0f
SM
2613 * keyboard.c: Apply keyboard decoding only to events that come directly
2614 from the tty, not from unread-command-events (bug#14368).
2615 (read_event_from_main_queue): New function, extracted from read_char).
2616 (read_decoded_char): Remove.
2617 (read_decoded_event_from_main_queue): New function to replace it.
2618 (read_char): Use it.
2619 (read_key_sequence): Use read_char rather than read_decoded_char.
2620
2af0948d
SM
2621 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2622
1413e9a5
BR
26232013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2624
2625 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2626
e6d2f155
KH
26272013-05-22 Kenichi Handa <handa@gnu.org>
2628
2629 The following changes are to fix the setting of
2630 buffer-file-coding-system on, for instance, C-x RET c unix RET
2631 _FILE_OF_DOS_EOL_TYPE_ RET.
2632
2633 * coding.h (struct coding_system): New member detected_utf8_chars.
2634
2635 * coding.c (detect_coding_utf_8): Count characters and check EOL
2636 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2637 BOM is there.
2638 (setup_coding_system): Do not initialize coding->head_ascii.
2639 (check_ascii): Do not set coding->eol_seen but update it. Do not
2640 call adjust_coding_eol_type here.
1413e9a5
BR
2641 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2642 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2643 of the found coding-system.
2644 (decode_coding_gap): Cancel previous change. Utilize the
2645 character numbers counted by detect_coding_utf_8. Fix detection
2646 of BOM for utf-8.
2647
ab56a6f4 26482013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2649
2650 * search.c (looking_at_1): Only set last_thing_searched if the match
2651 changed the match-data (bug#14281).
2652
ecc3c6ed
DA
26532013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2654
2655 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2656 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2657 (move_it_vertically_backward): Likewise.
2658
5ba8bf35
YM
26592013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2660
2661 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2662 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2663 (Fx_display_mm_width, Fx_display_mm_height):
2664 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2665
91e8418b 2666 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2667 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2668 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2669 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2670 (Fx_display_backing_store, Fx_display_visual_class)
2671 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2672 (Fx_display_grayscale_p, Fx_display_pixel_width)
2673 (Fx_display_pixel_height, Fx_display_planes)
2674 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2675 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2676 (Fx_display_mm_width, Fx_display_mm_height)
2677 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2678 height for all physical monitors as in X11.
2679
fc30d803
SM
2680 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2681 Return pixel width or height for all physical monitors as in X11.
91e8418b 2682
31ff141c
PE
26832013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2684
2685 Port --enable-gcc-warnings to clang.
2686 * bytecode.c (exec_byte_code):
2687 * regex.c:
2688 Redo diagnostic pragmas to pacify clang, too.
2689 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2690 * editfns.c (Fencode_time):
2691 * fileio.c (file_accessible_directory_p):
2692 * font.c (font_unparse_xlfd):
2693 Use '&"string"[index]' instead of '"string" + (index)'.
2694 * undo.c (user_error): Remove; unused.
2695
df065a0b
EZ
26962013-05-16 Eli Zaretskii <eliz@gnu.org>
2697
04d360e7
EZ
2698 * insdel.c (insert_1_both): Document the arguments, instead of
2699 referring to insert_1, which no longer exists.
2700
5bb98290
EZ
2701 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2702 some window, increment windows_or_buffers_changed, so that
2703 *Messages* display in that window is updated. (Bug#14408)
2704
df065a0b
EZ
2705 * w32.c: Include epaths.h.
2706 (init_environment): Use cmdproxy.exe without leading directories.
2707 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2708 case.
2709 (gettimeofday): Adjust signature and return value to Posix
2710 expectations.
2711
2712 * unexw32.c (open_output_file): Delete the existing emacs.exe
2713 before creating it, to break the hard link to the versioned
2714 executable.
2715
2716 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2717 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2718 (FIRSTFILE_OBJ): New variables.
2719 (W32_RES): Rename to EMACSRES. All users changed.
2720 (base_obj): Use $(CM_OBJ).
2721 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2722 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2723 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2724 $(W32_RES_LINK) before $(LIBES).
2725 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2726
1aa8d505
SM
27272013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2728
6e911150
SM
2729 * makefile.w32-in (DOC): Use just "DOC".
2730
2731 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2732
1aa8d505
SM
2733 * process.c: Export default filters and sentinels to Elisp.
2734 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2735 New constants.
2736 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2737 (Fset_process_sentinel, Fformat_network_address):
2738 Default to them instead of nil.
2739 (server_accept_connection): Sentinels can't be nil any more.
2740 (read_and_dispose_of_process_output): New function, extracted from
2741 read_process_output.
2742 (read_process_output): Use it; filters can't be nil.
2743 (Finternal_default_process_filter): New function, extracted from
2744 read_process_output.
2745 (exec_sentinel_unwind): Remove function.
2746 (exec_sentinel): Don't zilch sentinel while running.
2747 (status_notify): Sentinels can't be nil.
2748 (Finternal_default_process_sentinel): New function extracted from
2749 status_notify.
2750 (setup_process_coding_systems): Default filter is not nil any more.
2751 (syms_of_process): Export new Elisp functions and initialize
2752 new constants.
2753 * lisp.h (make_lisp_proc): New function.
2754
5ac2eb34
SM
27552013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2756
2757 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2758
eda9c7d7
EZ
27592013-05-14 Eli Zaretskii <eliz@gnu.org>
2760
2761 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2762 unless we know that the window w is a leaf window.
2763 Another attempt at solving bug#14062.
eda9c7d7 2764
8fdeaad5
JD
27652013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2766
2767 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2768 fdesc (Bug#14375).
2769
44aa9ee6
PE
27702013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 * image.c (gif_load): Check that subimages fit (Bug#14345).
2773
759fd763
SM
27742013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2775
2776 * lread.c (skip_dyn_eof): New function.
2777 (read1): Use it to skip the end of a file in response to #@00.
2778
2779 * doc.c (get_doc_string): Slightly relax the sanity checking.
2780
4465bfb4
JD
27812013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2782
2783 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2784 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2785 (MonitorInfo): New struct.
2786 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2787 (Fns_display_monitor_attributes_list): New functions.
2788 (display-usable-bounds): Remove.
2789 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2790 Qsource.
2791
7583e2a0
PE
27922013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2793
2794 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2795 (GTK_CHECK_VERSION): New macro, if not already defined.
2796 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2797 replaced by GTK_CHECK_VERSION.
2798
ad75d77e
PE
27992013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 * xterm.h (GTK_PREREQ): New macro.
2802 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2803 to use this macro instead, for consistency and clarity.
2804
07525f77
EZ
28052013-05-08 Eli Zaretskii <eliz@gnu.org>
2806
2807 * xdisp.c (row_for_charpos_p): New function, with code of
2808 cursor_row_p, but accepts an additional argument CHARPOS instead
2809 of using a hardcoded PT.
2810 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2811 (row_containing_pos): Call row_for_charpos_p instead of partially
2812 doing the same. Fixes cursor positioning under longlines-mode
2813 when longlines-show-effect includes more than one newline, when
2814 moving the cursor vertically up.
2815
d901fc8d
JB
28162013-05-08 Juanma Barranquero <lekktu@gmail.com>
2817
2818 * makefile.w32-in (ACL_H): New macro.
2819 ($(BLD)/fileio.$(O)): Update dependencies.
2820
f269bc61
PE
28212013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2822
e7b41c4c 2823 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2824 * Makefile.in (LIB_ACL): New macro.
2825 (LIBACL_LIBS): Remove.
2826 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2827 * fileio.c: Include <acl.h>.
2828 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2829 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2830 !acl_errno_valid.
2831 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2832 it ourselves.
2833
f269bc61
PE
2834 * unexelf.c: Don't assume ElfW (Half) fits in int.
2835 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2836 when dealing with ElfW (Half) values, since they can exceed 2**31
2837 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2838 (entry_address): Omit unused NUM arg. All uses changed.
2839
a261c53e
JL
28402013-05-07 Juri Linkov <juri@jurta.org>
2841
2842 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2843 to the string converted from number with `Fnumber_to_string'.
2844 (Bug#14254)
2845
2b66427d
PE
28462013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2849 This fixes a problem introduced by my previous change.
2850
15acfe41
GM
28512013-05-07 Glenn Morris <rgm@gnu.org>
2852
2853 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2854
5ea03bf5
JD
28552013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2856
2857 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2858
e0c9d565
PE
28592013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 Static checking by GCC 4.8.0.
2862 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2863 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2864 (x_get_monitor_attributes_fallback)
2865 (x_get_monitor_attributes_xinerama)
2866 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2867 Define only if USE_GTK.
2868 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2869 (x_get_monitor_attributes_fallback): Omit unused locals.
2870 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2871 Use double, not float, to avoid mixed-mode floating point arithmetic.
2872
4e3f9230
YM
28732013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2874 Jan Djärv <jan.h.d@swipnet.se>
2875
2876 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2877 (XINERAMA_CFLAGS): New macros.
2878 (ALL_CFLAGS, LIBES): Use them.
2879
2880 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2881 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2882 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2883 (syms_of_xfns): DEFSYM them.
2884 (struct MonitorInfo): New struct.
2885 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2886 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2887 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2888 (x_get_monitor_attributes_xinerama): New functions.
2889 (Fx_display_monitor_attributes_list): New primitive.
2890 (syms_of_xfns): Defsubr it.
2891
2892 * xterm.h (x_display_info): Add Xatom_net_workarea and
2893 Xatom_net_current_desktop.
2894
2895 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2896 and dpyinfo->Xatom_net_current_desktop.
2897
05839b6a
EZ
28982013-05-06 Eli Zaretskii <eliz@gnu.org>
2899
2900 * xdisp.c (pos_visible_p): Use the special code for finding the
2901 beginning of a display property or overlay for any "replacing"
2902 display property, not just for display strings. This solves
2903 incorrect reporting of position by posn-at-point. (Bug#14241)
2904
dc4a2ee0
PE
29052013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2906
5ee94506
PE
2907 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2908 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2909 Verify that ElfW (Half) fits in int.
2910 (fatal): Use same signature as lisp.h.
2911 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2912 configure and build with -DUNEXELF_DEBUG without worrying about
2913 other modules that use DEBUG.
2914 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2915 possibly-wide integers now uses it instead of plain fprintf.
2916 (entry_address): New function, which avoids problems with 32-bit
2917 overflow on 64-bit hosts.
2918 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2919 (round_up): Don't assume the remainder fits in int.
2920 (find_section): Use bool for boolean. Simplify debug code.
2921 (unexec): Don't assume file sizes fit in int or size_t.
2922 Omit unnecessary trailing newline in 'fatal' format.
2923 Use strerror rather than outputting decimal error number.
2924 Remove unused code when emacs is not defined;
2925 this file relies on Emacs now.
2926 Don't assume e_phnum and e_shnum are positive.
2927
dc4a2ee0
PE
2928 * regex.c: Fix problems when DEBUG is defined.
2929 (extract_number, extract_number_and_incr): Define regardless of
2930 whether DEBUG is defined; that's simpler and makes the code less
2931 likely to go stale in the normal case when DEBUG is not defined.
2932 Return int rather than taking an int * arg. All callers changed.
2933 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2934 Remove, replacing with ...
2935 (DEBUG_PRINT): New macro. All callers changed.
2936 (DEBUG_COMPILES_ARGUMENTS): New macro.
2937 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2938 (print_compiled_pattern, print_double_string) [DEBUG]:
2939 Use prototype rather than old-style definition.
2940 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2941 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2942 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2943 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2944 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2945 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2946 This matters only when DEBUG is defined.
2947
14c7ed05
EZ
29482013-05-05 Eli Zaretskii <eliz@gnu.org>
2949
2950 * xdisp.c (set_iterator_to_next): Set the
2951 ignore_overlay_strings_at_pos_p flag only if we are _really_
2952 iterating over an overlay string, as indicated by the
2953 current.overlay_string_index member. (Bug#14306)
2954
e6076b1b
JD
29552013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2956
2957 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2958 to where it is used, to avoid autorelease issues (Bug#14050).
2959
cbee2131
PE
29602013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2961
2962 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2963 * fileio.c (syms_of_fileio): Implement this.
2964 * filelock.c (create_lock_file): If symbolic links don't work, so
2965 we use a regular file as a lock file, do not fsync the lock file;
2966 it's not needed.
2967
30c7e542
SM
29682013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2969
2970 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2971 (syms_of_minibuf): Adjust accodingly.
2972 * lread.c (Fread):
2973 * callint.c (Fcall_interactively): Adjust calls accordingly.
2974
5bebd186
EZ
29752013-05-04 Eli Zaretskii <eliz@gnu.org>
2976
2977 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2978 w->contents is a buffer before computing everything else.
2979 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2980
2981 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2982 assertion violations. (Bug#14062)
2983
0fb0a4f3
DR
29842013-05-01 David Reitter <david.reitter@gmail.com>
2985
2986 * nsfns.m (ns_tooltip): Initialize.
2987
9e63b4a5
EZ
29882013-04-28 Eli Zaretskii <eliz@gnu.org>
2989
2990 * coding.c (decode_coding_gap): Don't remove the character before
2991 a newline unless it's a CR character. (Bug#14287)
2992
ad60824e
DN
29932013-04-28 Dan Nicolaescu <dann@gnu.org>
2994
2995 * dispextern.h (struct face): Move enum face_underline_type
2996 earlier so that bitfields can be in the same word.
2997
edbdcec0
JD
29982013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2999
3000 * nsfns.m (handlePanelKeys): New function.
3001 (EmacsOpenPanel:performKeyEquivalent:)
3002 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3003 arrows/function/control and copy/paste keys (Bug#14296).
3004
0208ede7
JL
30052013-04-27 Juri Linkov <juri@jurta.org>
3006
3007 * callint.c (Fcall_interactively): Call `Qread_number' for
3008 interactive code letter `n' instead of using duplicate code.
3009 (Bug#14254)
3010
b8dd59f7
PE
30112013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 * systime.h (make_timeval): Declare as 'const'.
3014
8bd722db
KH
30152013-04-27 Kenichi Handa <handa@gnu.org>
3016
3017 * font.c (font_open_entity): Always open a font of manageable
3018 size.
3019
13d0e56f 30202013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3021
f780d632
PE
3022 Port better to AIX (Bug#14258).
3023 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3024 to pacify AIX xlc.
3025
ec509856
KH
30262013-04-24 Kenichi Handa <handa@gnu.org>
3027
3028 * coding.c (decode_coding_iso_2022): When an invalid escape
3029 sequence is encountered, reset the invocation and designation
3030 status to the safest one.
3031
84fc48e5
PE
30322013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3033
3034 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3035 Without this fix, "make distclean" leaves stamp-h1 behind.
3036
806bda47
EC
30372013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3038
3039 * w32fns.c (w32_fullscreen_rect): New function to compute the
3040 window rectangle for the given fullscreen mode.
3041 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3042 longer tunes the window size. This keeps the window's edges flush
3043 with the screen and allows the taskbar to hide itself in fullboth.
3044
3045 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3046 window decorations and uses the entire screen.
3047
3048 * w32term.h (w32_fullscreen_rect) Add prototype.
3049 (struct w32_output): Replace normal_width, normal_height,
3050 normal_top, and normal_left members with a single normal_placement
3051 struct.
3052 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3053 Remove macros.
3054 (FRAME_NORMAL_PLACEMENT): New macro.
3055
9cc2810b
JB
30562013-04-16 Juanma Barranquero <lekktu@gmail.com>
3057
3058 * minibuf.c (Ftest_completion): Silence compiler warning.
3059
fd16b54c
EZ
30602013-04-15 Eli Zaretskii <eliz@gnu.org>
3061
3062 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3063 bug#14062.
fd16b54c
EZ
3064
3065 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3066 parentheses.
3067
3068 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3069 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3070 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3071 parentheses where appropriate.
3072
9e3379a0
PE
30732013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3076
ddd6b685
EZ
30772013-04-14 Eli Zaretskii <eliz@gnu.org>
3078
3079 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3080 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3081 Mention in the doc string that setting these variables takes
3082 effect only after a call to set-window-buffer. (Bug#14200)
3083
29b79ba1
EZ
30842013-04-13 Eli Zaretskii <eliz@gnu.org>
3085
3086 * indent.c (Fvertical_motion): Don't consider display strings on
3087 overlay strings as display strings on the buffer position we
3088 started from. This prevents vertical cursor motion from jumping
3089 more than one line when there's an overlay string with a display
3090 property at end of line.
3091 Reported by Karl Chen <Karl.Chen@quarl.org> in
3092 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3093
562c6ee9
SM
30942013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3095
3096 * window.c (select_window): `record_buffer' even if window is
3097 already selected (bug#14191).
3098
fcc1fe85
EZ
30992013-04-11 Eli Zaretskii <eliz@gnu.org>
3100
3101 * window.c (Fwindow_end): Test more flags, including the buffer's
3102 last_overlay_modified flag, to determine whether the window's
3103 display is really up-to-date. Prevents the function from
3104 returning a stale value. (Bug#14170)
3105 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3106 current matrix.
3107
f009190a
EZ
31082013-04-10 Eli Zaretskii <eliz@gnu.org>
3109
3110 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3111 garbaged only if it is not already the top frame on its TTY.
3112 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3113 there are GUI frames open in the same session. (Bug#13864)
3114
78ce603d
SM
31152013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3116
3117 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3118 of marking the idle timers directly.
3119
a8036e40
SM
31202013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3121
3122 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3123 tables (bug#14054).
3124
7ffe7ef6
SM
31252013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3126
3127 * window.c (select_window): Don't record_buffer while the invariant is
3128 temporarily broken (bug#14161).
3129
3130 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3131
7d9f6883
EZ
31322013-04-07 Eli Zaretskii <eliz@gnu.org>
3133
3134 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3135
5406cfd9
RF
31362013-04-07 Romain Francoise <romain@orebokech.com>
3137
3138 Ignore additional platform-specific ACL errors (Bug#13702).
3139 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3140 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3141
95c0e83b
JD
31422013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3143
3144 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3145 f->output_data.ns.
3146
876da980
PE
31472013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3150 This bug was introduced by my 2013-02-25 change that simplified
3151 data_start configuration. Without this change, on GNU/Linux
3152 an Emacs configured with --enable-profiling fails immediately
3153 due to a profiler signal.
3154 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3155 with these flags. On platforms where special flags are needed
3156 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3157 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3158 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3159
7452b7bd
DA
31602013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3161
3162 Get rid of some platform-specific functions examining window
3163 system and its capabilities. This is a partial rework of the
3164 2013-04-05 change.
3165 * lisp.h (have_menus_p): Remove prototype. This function is
3166 replaced with platform-independent window_system_available.
3167 (check_window_system): Move to...
3168 * frame.h (decode_window_system_frame, window_system_available):
3169 ...here, add new prototypes.
3170 * frame.c (window_system_available, decode_window_system_frame):
3171 New functions.
3172 (check_window_system): Platform-independent now.
3173 * xterm.h (x_in_use): Remove declaration.
3174 (check_x_frame):
3175 * w32term.h (check_x_frame):
3176 * nsterm.h (check_x_frame): Remove prototypes. This function
3177 is replaced with platform-independent decode_window_system_frame.
3178 * msdos.c (have_menus_p): Remove.
3179 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3180 Remove platform-specific functions. Use check_window_system,
3181 decode_window_system_frame and check_ns_display_info where
3182 appropriate. Minor style and comment tweaks.
3183 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3184 (check_x_frame): Likewise.
3185 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3186 Likewise.
3187 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3188 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3189 * xmenu.c, xselect.c: All related users changed.
3190
251e9147
KH
31912013-04-03 Kenichi Handa <handa@gnu.org>
3192
3193 The following changes is to optimize the code for reading UTF-8
3194 files.
3195
562c6ee9 3196 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3197 changed. Check EOL format. Do not call adjust_coding_eol_type
3198 here.
3199 (check_utf_8): New function.
3200 (adjust_coding_eol_type): Do nothing if already adjusted.
3201 (detect_coding): Compare the return value of check_ascii with
3202 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3203 (decode_coding_gap): Optimize for valid UTF-8.
3204
8bc369d4
KH
32052013-03-21 Kenichi Handa <handa@gnu.org>
3206
3207 * coding.c (syms_of_coding): Cancel previous change.
3208
3209 * insdel.c (insert_from_gap): Fix previous change.
3210
73931ad1
DA
32112013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3212
3213 Consistently use platform-specific function to detect window system.
3214 * lisp.h (check_window_system): New prototype. This function is
3215 going to replace check_x, check_w32 and check_ns.
3216 (have_menus_p): Mention msdos.c in comment.
3217 * fontset.c (check_window_system_func): Remove. Adjust all users.
3218 * fontset.h (check_window_system_func): Remove prototype.
3219 * nsterm.h (check_ns):
3220 * xterm.h (check_x):
3221 * w32term.h (check_w32): Likewise.
3222 * menu.c (Fx_popup_menu): Use check_window_system.
3223 * msdos.c (check_window_system): Define for MS-DOS.
3224 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3225 * w32fns.c (check_window_system): Likewise for MS-Windows.
3226 * xfns.c (check_window_system): Likewise for X.
3227 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3228 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3229
7216e43b
PE
32302013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 Prefer < to > in range checks such as 0 <= i && i < N.
3233 This makes it easier to visualize quantities on a number line.
3234 This patch doesn't apply to all such range checks,
3235 only to the range checks affected by the 2013-03-24 change.
3236 This patch reverts most of the 2013-03-24 change.
3237 * alloc.c (xpalloc, Fgarbage_collect):
3238 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3239 * character.c (string_escape_byte8):
3240 * charset.c (read_hex):
3241 * data.c (cons_to_unsigned):
3242 * dispnew.c (update_frame_1):
3243 * doc.c (Fsubstitute_command_keys):
3244 * doprnt.c (doprnt):
3245 * editfns.c (hi_time, decode_time_components):
3246 * fileio.c (file_offset):
3247 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3248 * font.c (font_intern_prop):
3249 * frame.c (x_set_alpha):
3250 * gtkutil.c (get_utf8_string):
3251 * indent.c (check_display_width):
3252 * keymap.c (Fkey_description):
3253 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3254 * lread.c (read1):
3255 * minibuf.c (read_minibuf_noninteractive):
3256 * process.c (wait_reading_process_output):
3257 * search.c (Freplace_match):
3258 * window.c (get_phys_cursor_glyph):
3259 * xdisp.c (redisplay_internal):
3260 * xsmfns.c (smc_save_yourself_CB):
3261 Prefer < to > for range checks.
3262 * dispnew.c (sit_for): Don't mishandle NaNs.
3263 This fixes a bug introduced in the 2013-03-24 change.
3264 * editfns.c (decode_time_components): Don't hoist comparison.
3265 This fixes another bug introduced in the 2013-03-24 change.
3266
92759988
DA
32672013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3268
3269 * frame.h (struct frame): Drop scroll_bottom_vpos
3270 member becaue all real users are dead long ago.
3271 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3272 * xdisp.c (redisplay_internal): Adjust user.
3273
9a1971bb
GM
32742013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3275
f38ab167
JD
3276 * nsmenu.m (showAtX:Y:for:): setLevel to
3277 NSPopUpMenuWindowLevel (Bug#13998).
3278
6d01f1fe
JD
32792013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3280
3281 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3282 (ns_check_pending_open_menu): Declare.
3283
3284 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3285 (x_activate_menubar): Update the menu with title that matches
3286 ns_get_pending_menu_title, and call
3287 ns_check_pending_openmenu (Bug#12698).
3288 (menuWillOpen:): New method.
3289 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3290
3291 * nsterm.m (menu_will_open_state, menu_mouse_point)
3292 (menu_pending_title): New varaibles.
3293 (ns_get_pending_menu_title, ns_check_menu_open)
3294 (ns_check_pending_open_menu): New functions.
3295
781f4782
DA
32962013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3297
3298 * indent.c (current_column_bol_cache): Remove leftover which is not
3299 used in Fmove_to_column any more.
3300 (current_column, scan_for_column): Adjust users.
3301 * keyboard.c (last_point_position_buffer, last_point_position_window):
3302 Remove leftovers which are not used for recording undo any more.
3303 (command_loop_1, syms_of_keyboard): Adjust users.
3304 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3305 redisplay_window any more.
3306 (move_it_to): Adjust user.
3307
1921c31b
JB
33082013-03-29 Juanma Barranquero <lekktu@gmail.com>
3309
3310 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3311 Update dependencies.
3312
717b8bcd
SM
33132013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3314
3315 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3316 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3317 forward references.
3318
e74aeda8
DA
33192013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3320
3321 * window.h (struct window): Replace hchild, vchild and buffer slots
3322 with the only contents slot. This is possible because each valid
3323 window may have either the child window (in vertical or horizontal
3324 combination) or buffer to display (for the leaf window). Using that,
3325 a lof of operations to traverse and/or change window hierarchies may
3326 be simplified. New member horizontal is used to distinguish between
3327 horizontal and vertical combinations of internal windows.
3328 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3329 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3330 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3331 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3332 Use contents slot, not buffer, where appropriate.
3333 (wset_combination): New function.
3334 (wset_buffer): Add eassert.
3335 (Fframe_first_window): Simplify the loop reaching first window.
3336 (Fwindow_buffer): Use WINDOW_LEAF_P.
3337 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3338 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3339 (unshow_buffer): Convert initial debugging check to eassert.
3340 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3341 (make_parent_window, window_resize_check, window_resize_apply)
3342 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3343 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3344 Adjust to match struct window changes.
3345 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3346 (mark_window_cursors_off, count_windows, get_leaf_windows)
3347 (foreach_window_1): Simplify the loop.
3348 * alloc.c (mark_object): Do not check for the leaf window because
3349 internal windows has no glyph matrices anyway.
3350 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3351 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3352 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3353 (build_frame_matrix_from_window_tree, mirror_make_current)
3354 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3355 (update_window_tree, set_window_update_flags): Simplify the loop.
3356 (sync_window_with_frame_matrix_rows): Enforce live window.
3357 Use contents slot, not buffer, where appropriate.
3358 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3359 and WINDOW_HORIZONTAL_COMBINATION_P.
3360 (make_frame_visible_1): Simplify the loop.
3361 Use contents slot, not buffer, where appropriate.
3362 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3363 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3364 (expose_window_tree): Likewise.
3365 Use contents slot, not buffer, where appropriate.
3366 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3367 to avoid deleted windows. Use contents slot instead of buffer.
3368 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3369 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3370 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3371 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3372
121ab1cd
EZ
33732013-03-28 Eli Zaretskii <eliz@gnu.org>
3374
ef454cf7
EZ
3375 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3376 identify the reasons for assertion violations in bug#14062 and
3377 similar ones.
21e930f8
EZ
3378 (Fx_show_tip): Fix compilation error under
3379 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3380
121ab1cd
EZ
3381 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3382 Reported by <rzl24ozi@gmail.com>.
3383
5c89ca24
DA
33842013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3385
3386 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3387 start marker...
562c6ee9
SM
3388 (unwind_with_echo_area_buffer): ...to restore it here.
3389 This is needed to ensure that...
5c89ca24
DA
3390 (redisplay_window): ...both window markers are valid here,
3391 which is verified by eassert.
3392 * editfns.c (save_excursion_save): Do not assume that
3393 selected_window always displays the buffer.
c7f53895
DA
3394 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3395 Fix comment.
5c89ca24 3396
f557c1b1
SM
33972013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3398
3399 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3400 the upcase table.
3401
40693bba 34022013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3403
3404 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3405
c86f791f
EZ
34062013-03-27 Eli Zaretskii <eliz@gnu.org>
3407
3408 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3409 since MinGW's w32api headers do. This avoids compiler warnings.
3410
3411 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3412 if already defined.
3413
c6e72e17
EZ
34142013-03-26 Eli Zaretskii <eliz@gnu.org>
3415
3416 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3417
54e95010
JD
34182013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3419
3420 * gtkutil.c (style_changed_cb): Check if frame is live and an
3421 X frame (Bug#14038).
3422
b88b62de
EZ
34232013-03-26 Eli Zaretskii <eliz@gnu.org>
3424
a18d7de6
EZ
3425 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3426 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3427 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3428 MinGW64.
8f5e14c8
EZ
3429 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3430 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3431
b88b62de
EZ
3432 Fix incompatibilities between MinGW.org and MinGW64 headers.
3433 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3434
3435 * w32.c (REPARSE_DATA_BUFFER): Guard with
3436 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3437
c074e458
JD
34382013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3439
3440 * xterm.c: Include X11/XKBlib.h
3441 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3442
908589fd
AS
34432013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3444
3445 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3446 written backwards.
3447 * blockinput.h (input_blocked_p): Likewise.
3448 * bytecode.c (exec_byte_code): Likewise.
3449 * callproc.c (call_process_kill, call_process_cleanup)
3450 (Fcall_process): Likewise.
3451 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3452 (Fccl_execute_on_string): Likewise.
3453 * character.c (string_escape_byte8): Likewise.
3454 * charset.c (read_hex): Likewise.
3455 * cm.c (calccost): Likewise.
3456 * data.c (cons_to_unsigned): Likewise.
3457 * dired.c (directory_files_internal, file_name_completion):
3458 Likewise.
3459 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3460 (sit_for): Likewise.
3461 * doc.c (Fsubstitute_command_keys): Likewise.
3462 * doprnt.c (doprnt): Likewise.
3463 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3464 * emacsgtkfixed.c: Likewise.
3465 * fileio.c (file_offset, Fwrite_region): Likewise.
3466 * floatfns.c (Fexpt, fmod_float): Likewise.
3467 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3468 Likewise.
3469 * font.c (font_intern_prop): Likewise.
3470 * frame.c (x_set_alpha): Likewise.
3471 * gtkutil.c (get_utf8_string): Likewise.
3472 * indent.c (check_display_width): Likewise.
3473 * intervals.c (create_root_interval, rotate_right, rotate_left)
3474 (split_interval_right, split_interval_left)
3475 (adjust_intervals_for_insertion, delete_node)
3476 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3477 (merge_interval_right, merge_interval_left, copy_intervals)
3478 (set_intervals_multibyte_1): Likewise.
3479 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3480 * keymap.c (Fkey_description): Likewise.
3481 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3482 * lread.c (openp, read_integer, read1, string_to_number):
3483 Likewise.
3484 * menu.c (ensure_menu_items): Likewise.
3485 * minibuf.c (read_minibuf_noninteractive): Likewise.
3486 * print.c (printchar, strout): Likewise.
3487 * process.c (create_process, Faccept_process_output)
3488 (wait_reading_process_output, read_process_output, send_process)
3489 (wait_reading_process_output): Likewise.
3490 * profiler.c (make_log, handle_profiler_signal): Likewise.
3491 * regex.c (re_exec): Likewise.
3492 * regex.h: Likewise.
3493 * search.c (looking_at_1, Freplace_match): Likewise.
3494 * sysdep.c (get_child_status, procfs_ttyname)
3495 (procfs_get_total_memory): Likewise.
3496 * systime.h (EMACS_TIME_VALID_P): Likewise.
3497 * term.c (dissociate_if_controlling_tty): Likewise.
3498 * window.c (get_phys_cursor_glyph): Likewise.
3499 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3500 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3501 Likewise.
3502 * xfns.c (Fx_window_property): Likewise.
3503 * xmenu.c (set_frame_menubar): Likewise.
3504 * xselect.c (x_get_window_property, x_handle_dnd_message):
3505 Likewise.
3506 * xsmfns.c (smc_save_yourself_CB): Likewise.
3507 * xterm.c (x_scroll_bar_set_handle): Likewise.
3508
2bf7d27a
DA
35092013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3510
3511 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3512 to be optional or nil. Adjust comment and convert it to docstring.
3513 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3514 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3515
a9ebfa0b
PE
35162013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3517
3518 Static checking by GCC 4.8-20130319.
3519 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3520 * process.c (Fset_process_datagram_address)
3521 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3522 * xdisp.c (get_char_face_and_encoding):
3523 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3524 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3525 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3526
4f3576ee
KB
35272013-03-24 Ken Brown <kbrown@cornell.edu>
3528
789b5e9a
KB
3529 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3530 fix compilation on 64-bit Cygwin, where underscores are not
3531 automatically prepended.
3532
4f3576ee
KB
3533 * w32term.c (w32_initialize): Silence compiler warning.
3534
b5b7745f
EZ
35352013-03-23 Eli Zaretskii <eliz@gnu.org>
3536
cdc0d0bd
EZ
3537 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3538 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3539 variables, to save and restore frame dimensions.
3540 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3541 after returning from a 'fullscreen' configuration.
3542 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3543 to avoid races between the main thread and the input thread.
3544
3545 * w32term.h (struct w32_output): New members normal_width,
3546 normal_height, normal_top, normal_left, and prev_fsmode.
3547 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3548 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3549 members of a frame.
3550
b5b7745f
EZ
3551 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3552 'fullscreen' parameter. Always record previous width and height
3553 of the frame, except when switching out of maximized modes, so
3554 that they could be restored correctly, instead of resetting to the
3555 default frame dimensions. Send SC_RESTORE command to the frame,
3556 unless we are going to send SC_MAXIMIZE, to restore the frame
3557 resize hints in the mouse pointer shown by the window manager.
3558 (Bug#14032)
3559
3560 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3561
3562 * lisp.h (get_frame_param): Adjust conditions for prototype
3563 declaration.
3564
a3454eed
KB
35652013-03-22 Ken Brown <kbrown@cornell.edu>
3566
3567 * unexcw.c: Drop unneeded inclusion of w32common.h.
3568 (report_sheap_usage): Declare.
3569 (read_exe_header): Add magic numbers for x86_64.
3570 (fixup_executable): Fix printf format specifier for unsigned long
3571 argument.
3572
5a49b79c
DA
35732013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3574
3575 * frame.h (struct frame): Put menu_bar_window under #ifdef
3576 because this member is not needed when X toolkit is in use.
3577 (fset_menu_bar_window):
3578 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3579 (free_glyphs, update_frame):
3580 * xdisp.c (expose_frame): Likewise.
3581 (display_menu_bar): Likewise. Remove redundant eassert.
3582 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3583 toolkit is in use.
3584
d6723bf7
PE
35852013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3586
7b1123d8
PE
3587 Use functions and constants to manipulate Lisp_Save_Value objects.
3588 This replaces code that used macros and strings and token-pasting.
3589 The change makes the C source a bit easier to follow,
3590 and shrinks the Emacs executable a bit.
3591 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3592 (make_save_value): Change 1st arg from string to enum. All callers
3593 changed.
3594 (INTX): Remove.
3595 (mark_object): Use if, not #if, for GC_MARK_STACK.
3596 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3597 (XSAVE_OBJECT): Now functions, not macros.
3598 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3599 the constant was never used.
3600 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3601 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3602 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3603 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3604 New constants.
3605 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3606 type3 with a single member save_type. All uses changed.
3607 (save_type, set_save_pointer, set_save_integer): New functions.
3608 * print.c (PRINTX): Remove.
3609
d6723bf7
PE
3610 * alloc.c: Remove redundant static declarations.
3611
5f24fa51
DA
36122013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3613
3614 * window.h (struct window): Convert left_col, top_line, total_lines
3615 and total_cols from Lisp_Objects to integers. Adjust comments.
3616 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3617 Remove.
3618 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3619 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3620 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3621 Adjust users where appropriate.
3622
42143acd
DA
36232013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3624
3625 * frame.h (struct frame): Drop resx and resy because the same data is
3626 available from window system-specific output context. Adjust users.
562c6ee9
SM
3627 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3628 New functions to provide defaults when no window system available.
42143acd 3629 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3630 (NUMVAL): Move from xdisp.c.
42143acd
DA
3631 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3632 (Ffont_face_attributes, Fopen_font):
3633 * image.c (gs_load):
3634 * w32font.c (fill_in_logfont):
3635 * xdisp.c (calc_pixel_width_or_height):
3636 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3637 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3638
c0a17406
KH
36392013-03-20 Kenichi Handa <handa@gnu.org>
3640
3641 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3642 to 1 (temporary workaround until a bug related to ASCII
3643 optimization is fixed).
3644
095d384d
DA
36452013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3646
3647 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3648 Signal error if window is not internal. Adjust docstring.
3649 (delete_all_child_windows): Use combination_limit to save the buffer.
3650 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3651 * print.c (syms_of_print): Initialize debugging output not here...
3652 (init_print_once): ...but in a new function here.
3653 * lisp.h (init_print_once): Add prototype.
3654 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3655
748fa866
DA
36562013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3657
3658 * window.c (window_resize_check, window_resize_apply)
3659 (window_from_coordinates, recombine_windows, set_window_buffer)
3660 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3661 (Fsplit_window_internal, Fdelete_window_internal)
3662 (freeze_window_starts): Use bool for booleans.
3663 * window.h (window_frame_coordinates, resize_frame_windows)
3664 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3665
81519fd2
SM
36662013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3667
3668 * dispnew.c (bitch_at_user): Use `user-error'.
3669
6db423a9
KB
36702013-03-17 Ken Brown <kbrown@cornell.edu>
3671
3672 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3673 as return type of image_background. (Bug#13981)
3674 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3675
8f2906f5
JD
36762013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3677
960ce480 3678 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3679 (ns_select): Don't return with result uninitialized.
960ce480 3680
8f2906f5
JD
3681 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3682 and getDirectory.
3683
81519fd2
SM
3684 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3685 New functions.
8f2906f5
JD
3686 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3687 directories. If filename is nil, get directory name (Bug#13932).
3688 Use getFilename and getDirectory.
3689 (getFilename, getDirectory): New methods for EmacsSavePanel and
3690 EmacsOpenPanel.
3691 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3692
cded56c1
PE
36932013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3696
251e9147 36972013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3698
3699 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3700 (adjust_after_replace): Make it back to static. Delete the third
3701 arg text_at_gap_tail. Cancel the code for handling it.
3702
3703 * coding.h (struct coding_system): New member eol_seen.
3704
3705 * coding.c (detect_ascii): New function.
3706 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3707 when the source bytes are actually scanned. On detecting for
3708 coding_category_utf_8_auto, call detect_ascii instead of scanning
3709 source bytes directly.
3710 (produce_chars): Call insert_from_gap with the new arg 0.
3711 (encode_coding): Likewise.
3712 (decode_coding_gap): Control ASCII optimization by the variable
3713 disable_ascii_optimization instead of #ifndef .. #endif.
3714 Deccode EOL format according to coding->eol_seen.
3715 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3716 variable.
3717
8a44e6d1
KH
3718 * lisp.h (adjust_after_replace): Cancel externing it.
3719 (insert_from_gap): Adjust prototype.
3720
5f795e34
EZ
37212013-03-15 Eli Zaretskii <eliz@gnu.org>
3722
3723 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3724 FULLSCREEN_MAXIMIZED. (Bug#13935)
3725
f258b4be
DA
37262013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3727
3728 * region-cache.c (find_cache_boundary, move_cache_gap)
3729 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3730 Simplify debugging check and convert to eassert. Adjust comment.
3731 (pp_cache): Put under ENABLE_CHECKING.
3732
a5cc4dde
EZ
37332013-03-14 Eli Zaretskii <eliz@gnu.org>
3734
3735 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3736 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3737 and WM_ACTIVATEAPP.
3738 (w32fullscreen_hook): If the frame is visible, reset
3739 f->want_fullscreen flag after changing the frame size. If the
3740 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3741 (Bug#13953)
3742
3fc5e44a
DC
37432013-03-13 Daniel Colascione <dancol@dancol.org>
3744
3745 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3746 too so that these builds can use Cygwin's file conversion
3747 functions. (We've been building and linking cygw32.o all along
3748 and just not using it.)
3749
47d7532e
PE
37502013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3751
3752 File synchronization fixes (Bug#13944).
3753 * Makefile.in (LIB_FDATASYNC): New macro.
3754 (LIBES): Use it.
3755 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3756 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3757 Don't worry about HAVE_FSYNC, since a substitute fsync is
3758 available if the system lacks one.
3759 (Fwrite_regin): Retry fsync if interrupted.
3760
c7ffccaf
EZ
37612013-03-13 Eli Zaretskii <eliz@gnu.org>
3762
4e2df81d 3763 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3764 activated, call w32fullscreen_hook, to make sure the new frame
3765 dimensions are in effect. (Bug#13937)
3766
8a7debc1
DA
37672013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3768
3769 * xdisp.c (init_iterator): Simplify because both character and byte
3770 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3771 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3772 character and byte positions can be obtained from marker.
8a7debc1 3773
7fd8c501
PE
37742013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3775
d9df6f40
PE
3776 Static checking by Sun C 5.12.
3777 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3778 * bytecode.c (exec_byte_code):
3779 * dispnew.c (init_display):
3780 * eval.c (error):
3781 * fileio.c (Fsubstitute_in_file_name):
3782 * keyboard.c (Fevent_convert_list):
3783 * keymap.c (Fsingle_key_description):
3784 * term.c (maybe_fatal, fatal):
3785 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3786 * xsmfns.c (Fhandle_save_session):
3787 Omit unreachable code.
3788 * keymap.c (map_keymap_char_table_item): Cast void * to
3789 a function pointer type; the C Standard requires this.
3790
7fd8c501
PE
3791 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3792 Include <sys/param.h> unconditionally, as that works elsewhere and
3793 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3794 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3795 and FreeBSD now.
3796
a020afb9 3797See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3798
3799;; Local Variables:
3800;; coding: utf-8
aac0c6e3
MR
3801;; End:
3802
ab422c4d 3803 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3804
3805 This file is part of GNU Emacs.
3806
3807 GNU Emacs is free software: you can redistribute it and/or modify
3808 it under the terms of the GNU General Public License as published by
3809 the Free Software Foundation, either version 3 of the License, or
3810 (at your option) any later version.
3811
3812 GNU Emacs is distributed in the hope that it will be useful,
3813 but WITHOUT ANY WARRANTY; without even the implied warranty of
3814 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3815 GNU General Public License for more details.
3816
3817 You should have received a copy of the GNU General Public License
3818 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.