* decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
53b64418
PE
12013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2
3 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
4
eeaf9bf3
DA
52013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
6
7 * window.h (struct window): Convert left_margin_cols and
8 right_margin_cols from Lisp_Objects to integers. Adjust comment.
9 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
10 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
11 Adjust users.
12 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
13 Adjust comment.
14 (showing_window_margins_p, update_window_line, update_frame_1):
15 * fringe.c (draw_fringe_bitmap_1):
16 * xdisp.c (window_box_width): Adjust users.
17 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
18 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
19 Use direct assignment.
20 (Fset_window_configuration, save_window_save, Fwindow_margins):
21 Convert Lisp_Object to integer and back where appropriate.
22 (Fset_window_margins): Adjust user. Return t if any margin
23 was actually changed, and mention this in docstring.
24
956720af
XF
252013-08-13 Xue Fuqiao <xfq.free@gmail.com>
26
f73f4ce6 27 * syntax.c (forward_word):
956720af
XF
28 * cmds.c (forward_char, backward_char): Mention the optional argument.
29
9e37ee3b
DA
302013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
31
32 * window.h (struct window): Convert left_fringe_width
33 and right_fringe_width from Lisp_Objects to integers.
34 Adjust comment.
35 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
36 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
37 * window.c (wset_left_fringe_width, wset_right_fringe_width):
38 Remove.
39 (make_window): Initialize new integer fields to -1.
40 (Fsplit_window_internal): Use direct assignment.
41 (Fset_window_configuration, save_window_save): Convert
42 Lisp_Object to integer and back where appropriate.
43 (Fset_window_fringes): Adjust user. Return t if any fringe
44 was actually changed, and mention this in docstring.
45
e4375ca7
DA
462013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
47
48 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
49 * nsfns.m (x_set_cursor_type):
50 * w32fns.c (x_set_cursor_type):
51 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
52 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 53
a45543bc
DA
542013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
55
56 * font.c (clear_font_cache): New function, stripped from...
57 (Fclear_font_cache): ...here, which now uses the function
58 above. Adjust comment.
59 * font.h (clear_font_cache): Add prototype.
60 * xfaces.c (clear_face_cache): Use clear_font_cache.
61
ae966a86
DA
622013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
63
64 * window.c (Fset_window_start): Compare `w', not `window' because
65 `w' might not be equal to `window' after call to decode_live_window.
66
297a545b
PE
672013-08-12 Paul Eggert <eggert@cs.ucla.edu>
68
69 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
70 This fixes a problem introduced by the Bug#15035 patch
71 when using GPG. Reported by Herbert J. Skuhra.
72
aa942e2b
EZ
732013-08-12 Eli Zaretskii <eliz@gnu.org>
74
75 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
76 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
77 not yet initialized.
78
7699d09e
LMI
792013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
80
81 * decompress.c (Fzlib_decompress_region): Support zlib
82 decompression, too, and rename.
83
1d238bc7
PE
842013-08-12 Paul Eggert <eggert@cs.ucla.edu>
85
86 Minor zlib configuration tweaks.
87 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
88 Don't assume presence of fn_inflateInit2_ zlib internal function.
89
8a44a184
LMI
902013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
91
92 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
93 include the zlib prefix.
94
594a4307
EZ
952013-08-12 Eli Zaretskii <eliz@gnu.org>
96
97 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
98 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
99 define static variables that are pointers to zlib functions to be
100 dynamically loaded.
101 (init_zlib_functions) [WINDOWSNT]: New function.
102 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
103 New macros.
104 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
105 macros instead of invoking the zlib functions directly.
106 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
107 Szlib_available_p.
108
d2e113bc
DA
1092013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Avoid looping over all frame windows to freeze and unfreeze.
112 * window.h (struct window): Drop frozen_window_start_p.
113 (freeze_window_starts): Drop prototype.
114 * frame.h (struct frame): New frozen_window_starts flag.
115 (FRAME_WINDOWS_FROZEN): New macro.
116 * window.c (freeze_window_start, freeze_window_starts):
117 Remove.
118 (select_window, replace_window): Adjust users.
119 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
120 (window_frozen_p): New function.
121 (redisplay_window): Use it.
122
94fcd171
PE
1232013-08-12 Paul Eggert <eggert@cs.ucla.edu>
124
125 Fix some fd issues when running subprocesses (Bug#15035).
126 Fix bugs that can leak files or file descriptors on errors.
127 Don't unlink open temp files, as that's hard for users to diagnose
128 when things go awry (e.g., temp disk exhausted).
129 Don't bother to lock temp files. Check for invalid recursion.
130 * callproc.c (synch_process_fd): Remove. All uses removed.
131 (synch_process_tempfile): New var or macro.
132 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
133 New constants.
134 (record_kill_process): New arg, the temp name. All callers changed.
135 (delete_temp_file): Now just a simple wrapper around unlink.
136 (call_process_kill): New arg, the call_process_fd array.
137 Close them all. Clear synch_process_pid. Remove the temp file,
138 or arrange for it to be removed.
139 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
140 that's been moved to synch_process_tempfile. Caller changed.
141 Do not remove the tempfile; that's now call_process_kill's
142 responsibility.
143 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
144 call_process_kill; the caller now does that.
145 (call_process_cleanup): Do not close the process fd; that's now
146 call_process_kill's responsibility.
147 (Fcall_process): Implement via new function call_process, which
148 has most of the old body of Fcall_process, but with a different API.
149 (call_process): New function that does not open or close filefd if
150 it is nonnegative. Record which fds need to be closed, and let
151 call_process_kill close (and remove the tempfile, on MSDOS) on error.
152 Signal an error if invoked recursively (could be done via a hook).
153 Simplify creation of the tempfile in the MSDOS case.
154 Don't create the output file until after checking for the executable.
155 Report any failure to open /dev/null.
156 Don't open /dev/null for writing twice; once is enough.
157 Don't create pipe if all output is being discarded or sent to file.
158 Don't worry about setting up the coding system or reading from the
159 pipe if all output is being discarded.
160 Hoist fd_error local into top level, to lessen block nesting.
161 Don't record deleted pid here; now done by Fcall_process_region.
162 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
163 and note its success in synch_process_tempfile.
164 Do not leak resources when child_setup fails.
165 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
166 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
167 (create_temp_file): Now returns open fd, with an additional
168 Lisp_Object * argument to return the name. All callers changed.
169 Do not close the file; rewind it instead, and leave it open for
170 the caller. Do not lock the temp file. Unwind-protect the file
171 and the file-descriptor.
172 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
173 If an asynchrounous process, record it here, not in call_process.
174 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
175 * eval.c (set_unwind_protect): New function.
176 * fileio.c (write_region): New function, generalized from the
177 old Fwrite_region. Do not lock temp files.
178 (Fwrite_region): Use it.
179 * lisp.h (set_unwind_protect, write_region): New decls.
180 * process.c: Include <verify.h>.
181 (make_process): Mark fds as initially closed.
182 (deleted_pid_list): Now a list of pid-filename pairs.
183 All uses changed.
184 (close_process_fd): New function.
185 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
186 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
187 New constants. Verify that their number matches PROCESS_OPEN_FDS.
188 (create_process, create_pty, Fmake_serial_process)
189 (server_accept_connection): Record which fds need to be closed,
190 and let deactivate_process close them.
191 (Fmake_network_process): Do not discard the unwind-protect
192 until it's safe to do so.
193 (deactivate_process): Close the fds opened by create_process etc.
194 (Fprocess_send_eof): Adjust to new way of recording open fds.
195 Report an error if /dev/null can't be opened, instead of aborting.
196 * process.h (PROCESS_OPEN_FDS): New constant.
197 (struct Lisp_Process): New member open_fds.
198 (record_kill_process, record_deleted_pid): Adjust signatures.
199 (record_deleted_pid): Move decl here ...
200 * syswait.h (record_deleted_pid): ... from here.
201
d0e615c3
PE
2022013-08-11 Paul Eggert <eggert@cs.ucla.edu>
203
204 * decompress.c: Fix bugs with large buffers and weird inputs.
205 Tune a bit. Reindent as per usual Emacs style.
206 (BUFFER_SIZE): Remove.
207 (Fdecompress_gzipped_region): Do not mishandle input buffers with
208 more than UINT_MAX bytes. Decompress into the gap instead of into
209 an auto buffer, as this should avoid copying. Return nil if
210 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
211 set immediate_quit; we shouldn't trust zlib code that much.
212
313546eb
LMI
2132013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
214
99a32242
LMI
215 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
216 errors, and really move the gap to where we want it.
217
313546eb
LMI
218 * lisp.h: Include decompress.c support.
219
220 * emacs.c (main): Include decompress.c support.
221
222 * Makefile.in: Include -lz if present.
223
d2d699ac
JD
2242013-08-11 Jan Djärv <jan.h.d@swipnet.se>
225
f90e3ebd
JD
226 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
227 (initWithTitle:): Initialize frame to 0.
228 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
229 (fillWithWidgetValue:frame:): Renamed from
230 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
231
232 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
233 fillWithWidgetValue:frame:
234
423d3b3f
JD
235 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
236 remove memory leak warnings.
237
d2d699ac
JD
238 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
239 (ns_check_menu_open): Handle menu == nil. Remove assignment to
240 menu_pending_title.
241
242 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
243 (x_activate_menubar): Update the whole menu.
244 (trackingNotification:): Call ns_check_menu_open if tracking ends.
245 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
246 current event is not NSSystemDefined (Bug#15001).
247 Call ns_check_menu_open only if trackingMenu is 2.
248 (menuDidClose:): New method, decrease trackingMenu.
249 (fillWithWidgetValue:setDelegate:): New method.
250 (fillWithWidgetValue:): Call the above.
251
252 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
253
7d652d97
PE
2542013-08-11 Paul Eggert <eggert@cs.ucla.edu>
255
256 Omit some unnecessary casts.
257 Many of these go back to the old pre-C89 days, when they may have
258 been needed, but we've been assuming C89 or later for a while now.
259 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
260 (live_float_p, live_misc_p, live_vector_p):
261 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
262 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
263 (defvar_per_buffer):
264 * callint.c (Fcall_interactively):
265 * doc.c (Fsubstitute_command_keys):
266 * filelock.c (get_boot_time):
267 * frame.c (xrdb_get_resource):
268 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
269 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
270 (xg_get_file_name_from_selector, menuitem_destroy_callback)
271 (menuitem_highlight_callback, menu_destroy_callback)
272 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
273 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
274 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
275 (xg_tool_bar_help_callback, tb_size_cb):
276 * image.c (xpm_alloc_color, png_read_from_memory)
277 (png_read_from_file, png_load_body, our_memory_skip_input_data)
278 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
279 (syms_of_image):
280 * keymap.c (describe_map):
281 * nsfns.m (Fns_display_monitor_attributes_list):
282 * nsmenu.m (process_dialog:):
283 * nsterm.m (hold_event):
284 * process.c (wait_reading_process_output):
285 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
286 * scroll.c (do_direct_scrolling, scrolling_1):
287 * termcap.c (tgetent):
288 * window.c (check_window_containing, add_window_to_list)
289 (freeze_window_starts):
290 * xdisp.c (compare_overlay_entries, vmessage):
291 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
292 (x_get_monitor_attributes_xrandr)
293 (Fx_display_monitor_attributes_list, x_display_info_for_name)
294 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
295 * xfont.c (xfont_match, xfont_open):
296 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
297 (menubar_selection_callback, menu_position_func)
298 (popup_selection_callback, create_and_show_popup_menu)
299 (dialog_selection_callback, create_and_show_dialog):
300 * xrdb.c (x_get_string_resource):
301 (main) [TESTRM]:
302 * xsmfns.c (x_session_check_input):
303 * xterm.c (x_draw_glyphless_glyph_string_foreground)
304 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
305 (xaw_jump_callback, xaw_scroll_callback):
306 Omit unnecessary casts.
307
9acc1074
PE
3082013-08-10 Paul Eggert <eggert@cs.ucla.edu>
309
310 Minor string-length refactoring.
311 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
312 * frame.c (make_monitor_attribute_list):
313 Prefer build_string to strlen + make_string.
314
361c0eb8
JD
3152013-08-10 Jan Djärv <jan.h.d@swipnet.se>
316
317 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
318 don't check minor_code (Bug#14417).
319
14ba0822
EZ
3202013-08-09 Eli Zaretskii <eliz@gnu.org>
321
322 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
323 vertical positions instead. This avoids calling MATRIX_ROW with
324 row numbers that are possibly beyond valid limits. (Bug#15064)
325
309f24d1
DA
3262013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
327
328 Use xstrdup and build_unibyte_string where applicable.
329 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
330 * xfns.c (x_window):
331 * xrdb.c (x_get_customization_string):
332 * xterm.c (xim_initialize):
333 * w32fns.c (w32_window): Use xstrdup.
334 (w32_display_monitor_attributes_list):
335 * emacs.c (init_cmdargs):
336 * keyboard.c (PUSH_C_STR):
337 * nsfont.m (nsfont_open):
338 * sysdep.c (system_process_attributes):
339 * w32.c (system_process_attributes):
340 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
341
55902276
EZ
3422013-08-09 Eli Zaretskii <eliz@gnu.org>
343
344 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
345 variables of these types so that GDB would know about them, as aid
346 for debugging fatal exceptions. (Bug#15024) See also
347 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
348 discussions.
349
10bf7f5a
JD
3502013-08-08 Jan Djärv <jan.h.d@swipnet.se>
351
352 * nsterm.m (ns_update_begin): Don't change clip path if it would be
353 larger than the NSWindow (Bug#14934).
354
65620264
DA
3552013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Redesign redisplay interface to drop global variable updated_window.
358 Always pass currently updated window as a parameter to update routines.
359 * dispextern.h (updated_window): Remove declaration.
360 (struct redisplay_interface): Pass window parameter to
361 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
362 and after_update_window_hook.
363 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
364 Adjust prototypes.
365 * dispnew.c (updated_window): Remove.
366 (redraw_overlapped_rows, update_marginal_area, update_text_area)
367 (update_window_line): Adjust to match redisplay interface changes.
368 * nsterm.m (ns_update_window_begin, ns_update_window_end)
369 (ns_scroll_run, ns_after_update_window_line):
370 * w32term.c (x_update_window_begin, x_update_window_end)
371 (x_after_update_window_line, x_scroll_run):
372 * xterm.c (x_update_window_begin, x_update_window_end)
373 (x_after_update_window_line, x_scroll_run):
374 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
375 Likewise. Adjust comments where appropriate.
376 (x_cursor_to): Simplify because this is always called during window
377 update (but install debugging check anyway).
378 (expose_window): Check must_be_updated_p flag to see whether this
379 function is called during window update.
380
628fdc56
DA
3812013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
382
383 Do not reset window modification event counters excessively.
384 These leftovers and poor man's tricky methods to catch extra
385 redisplay's attention are no longer needed.
386 * frame.c (set_menu_bar_lines_1):
387 * minibuf.c (read_minibuf_unwind):
388 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
389 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
390 (window_scroll_line_based, Fset_window_configuration):
391 * xdisp.c (redisplay_window): Do not reset last_modified and
392 last_overlay_modified counters.
393
8fd9c92e
JD
3942013-08-07 Jan Djärv <jan.h.d@swipnet.se>
395
396 * xselect.c (x_send_client_event): Set send_event and serial, memset
397 data.l as it might be bigger than data.b. Use 24 bit mask to
398 XSendEvent (Bug#15034).
399
0ee18172
EZ
4002013-08-07 Eli Zaretskii <eliz@gnu.org>
401
402 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
403 for TTY frames that are not the top frame on their console.
404 (Bug#14616)
405
16ddd1a6
MR
4062013-08-07 Martin Rudalics <rudalics@gmx.at>
407
408 * w32term.c (w32fullscreen_hook): Really maximize frame when
409 asked for (Bug#14841).
410
d2a95ffb
DA
4112013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
412
413 Prefer selected_window to Fselected_window, likewise for frames.
414 * buffer.c (Fbuffer_swap_text):
415 * data.c (Fvariable_binding_locus):
416 * window.c (run_window_configuration_change_hook): Adjust users.
417 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
418 Use decode_live_frame.
419
170da1ec
DA
4202013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
421
422 Be more careful if selected window shows the buffer other than current,
423 use window_outdated only if this is not so. This change should also
424 address some weird issues discussed in Bug#13012.
425 * window.h (window_outdated): New prototype.
426 * window.c (window_outdated): Now here. Convert from static and
427 always assume window's buffer.
428 (Fwindow_end, Fwindow_line_height): Use it.
429 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
430 and always assume window's buffer.
431 (redisplay_window): Adjust user.
e5eefe9b 432 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
433 check whether mode line should be updated only if selected window
434 shows current buffer.
435 (run_window_scroll_functions): Use eassert for debugging check.
436 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
437
56b5d5b1
DA
4382013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
439
440 * window.c (window_scroll, window_scroll_pixel_based)
441 (window_scroll_line_based): Use bool for booleans.
442
2878ba7e
PE
4432013-08-06 Paul Eggert <eggert@cs.ucla.edu>
444
445 * process.c: Fix minor off-by-one issues in descriptor counts.
446 This shouldn't fix any real bugs, but it cleans up the code a bit.
447 (max_process_desc, max_input_desc): -1, not 0, means none.
448 All uses changed.
449 (delete_input_desc): New function.
450 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
451 (deactivate_process): Scan backwards when recomuting max_process_desc;
452 that should be faster.
453 (init_process_emacs): Initialize max_input_desc.
454
e30b79c1
DA
4552013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
456
457 Use region cache to speedup bidi_find_paragraph_start.
458 * buffer.h (struct buffer): New member bidi_paragraph_cache.
459 Rename cache_long_line_scans to cache_long_scans.
460 * buffer.c (bset_cache_long_line_scans): Rename to
461 bset_cache_long_scans.
462 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
463 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
464 into account.
465 (syms_of_buffer): Rename cache-long-line-scans to
466 cache-long-scans. Adjust docstring.
467 * search.c (newline_cache_on_off):
468 * indent.c (width_run_cache_on_off): Adjust users.
469 * bidi.c (bidi_paragraph_cache_on_off): New function.
470 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
471 * insdel.c (prepare_to_modify_buffer): Invalidate
472 bidi_paragraph_cache if enabled.
473
00012b86
DA
4742013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
475
476 Invalidate region caches only if buffer text is going to be changed.
477 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
478 (modify_text): ...new prototype.
479 (prepare_to_modify_buffer_1): New prototype.
480 * textprop.c (modify_region): Rename to...
481 (modify_text_properties): ...new function.
482 (add_text_properties_1, set_text_properties, Fremove_text_properties)
483 (Fremove_list_of_text_properties): Adjust users.
484 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
485 (modify_text): ...new function.
486 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
487 (prepare_to_modify_buffer_1): ...new function.
488 * casefiddle.c (casify_region):
489 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
490 (Ftranspose_regions): Use modify_text.
491
dc6c0eda
SM
4922013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
493
494 * lisp.mk (lisp): Add nadvice.elc.
495
8f3a2c26
DA
4962013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
497
498 New macro to iterate over live buffers similar to frames.
499 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
500 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
501 Declare buffer-related variables here to offload lisp.h.
502 * buffer.c (Vbuffer_alist): Adjust comment.
503 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
504 (other_buffer_safely):
505 * data.c (store_symval_forwarding):
506 * dispnew.c (Fframe_or_buffer_changed_p):
507 * fileio.c (Fdo_auto_save):
508 * filelock.c (unlock_all_files):
509 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
510
e0fdb694
PE
5112013-08-04 Paul Eggert <eggert@cs.ucla.edu>
512
513 Fix some minor races in hosts lacking mkostemp (Bug#15015).
514 * callproc.c (create_temp_file):
515 * filelock.c (create_lock_file):
516 Assume mkostemp, since it's now provided by Gnulib.
517
63f5c6c2
EZ
5182013-08-04 Eli Zaretskii <eliz@gnu.org>
519
520 * w32.c (mkostemp): New function.
521 (mktemp): Remove, no longer used. Most of the code reused in
522 mkostemp. (Bug#15015)
484ab239 523 (mktemp): Don't undef.
63f5c6c2 524
f0b79313
DA
5252013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
526
527 * dispnew.c (glyph_matrix_count, glyph_pool_count):
528 Move under GLYPH_DEBUG and ENABLE_CHECKING.
529 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
530 (free_glyph_pool, check_glyph_memory): Likewise for
531 all users. Adjust comments where appropriate.
532
98f638d6
PE
5332013-08-03 Paul Eggert <eggert@cs.ucla.edu>
534
535 * composite.h: Minor fixups.
536 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
537 to fix a misspelling, and change it to an inline function while
538 we're at it (it need not be a macro). All uses changed.
539 (composition_method, composition_valid_p):
540 Rewrite to avoid assignments in if-conditions.
541
75c59fb3
DA
5422013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
543
544 Do not use global Lisp_Object in composition macros.
545 * composite.h (composition_temp): Remove declaration.
546 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
547 (composition_method, composition_valid_p): ...inline functions.
416a3e01 548 (compose_region): Remove the leftover.
75c59fb3
DA
549 * composite.c (composition_temp): Remove.
550 (run_composition_function, update_compositions)
551 (composition_compute_stop_pos, composition_adjust_point)
552 (Ffind_composition_internal):
553 * coding.c (handle_composition_annotation):
554 * xdisp.c (handle_composition_prop, check_point_in_composition):
555 Related users changed.
556
a10c8269
DA
5572013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
558
559 Drop FRAME_PTR typedef.
560 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
561 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
562 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
563 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
564 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
565 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
566 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
567 All related users changed.
568
a104f656
SM
5692013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
570
571 * eval.c (default_toplevel_binding): New function.
572 (Fdefvar): Use it.
573 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
574 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
575 (syms_of_eval): Export them.
576 * data.c (Fdefault_value): Micro cleanup.
577 * term.c (init_tty): Use "false".
578
4b5c9326
DA
5792013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
580
581 Fix X GC leak in GTK and raw (no toolkit) X ports.
582 * xterm.c (x_free_frame_resources): If white and black relief
583 GCs are allocated, always free them here.
584 * xfns.c (x_make_gc): Omit redundant initialization.
585 * widget.c (create_frame_gcs): Remove the leftover.
586 (EmacsFrameDestroy): Do nothing because all GCs are now freed
587 in x_free_frame_resources.
588
b19aa636
JD
5892013-08-02 Jan Djärv <jan.h.d@swipnet.se>
590
591 * nsterm.m (windowWillResize:toSize:): Only change title if
592 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
593 modifying it.
594 (viewDidEndLiveResize): New method.
595
596 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
597 inside NS_IMPL_COCOA.
598
af1f7e06
DA
5992013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
600
601 * insdel.c (adjust_after_replace, replace_range, del_range_2):
602 Do not check whether undo is enabled because record_insert and
603 record_delete does that themselves.
604
65b02bb9
DA
6052013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
606
607 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
608 member which is not really used any more.
609 (FRAME_XIC_BASE_FONTNAME): Remove.
610 * xfns.c (xic_free_fontset): Adjust user.
611 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
612 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
613 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
614 (xdialog_show): Use eassert for debugging check.
7ee0f047 615 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 616
6318cde0
PE
6172013-08-01 Paul Eggert <eggert@cs.ucla.edu>
618
619 * fileio.c, fns.c (merge): Move extern decl from here ...
620 * lisp.h (merge): ... to here.
621
6c1a09ba
DA
6222013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
623
624 Fix last font-related change.
625 * w32font.h (w32font_list_internal, w32font_match_internal):
626 Fix prototype.
627 * w32uniscribe.c (uniscribe_list, uniscribe_match):
628 (uniscribe_list_family): Adjust to match font API change.
629 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
630 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
631
f8c20208
DA
6322013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
633
634 * frame.h (FRAME_MOUSE_UPDATE):
635 * nsterm.m (ns_frame_up_to_date): Omit redundant check
636 whether hlinfo->mouse_face_mouse_frame is non-NULL.
637
fdb396e2
DA
6382013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
639
640 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
641 * font.h (struct font_driver): Change list, match, and list_family
642 functions to accept struct frame * as first arg.
643 * font.c (font_score, font_compare, font_sort_entities): Remove
644 prototypes.
645 (font_sort_entities, font_list_entities, font_select_entity):
646 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
647 match font API change.
648 * xfont.c (xfont_list, xfont_match, xfont_list_family):
649 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
650 * ftxfont.c (ftxfont_list, ftxfont_match):
651 * xftfont.c (xftfont_list, xftfont_match):
652 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
653 * w32font.c (w32font_list, w32font_match, w32font_list):
654 (w32font_list_internal, w32_font_match_internal): Likewise.
655 * xfaces.c (Fx_family_fonts): Adjust user.
656
52b8a085
DA
6572013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
658
659 Do not use pure Xism x_wm_set_icon_position in non-X ports.
660 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
661 only if HAVE_X_WINDOWS is in use.
662 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
663 * nsterm.m (x_wm_set_icon_position): Remove no-op.
664 * w32term.c (x_wm_set_icon_position): Likewise.
665 * w32fns.c (x_icon): Adjust user.
666
c791c18e
DA
6672013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
668
669 * xterm.c (last_mouse_press_frame): Remove the
670 leftover which is not really used any more.
671 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
672 (x_flush): Call XFlush once per each X display, not frame.
673 This is better because this code always unconditionally skips
674 non-X frames in Vframe_list and issues the only XFlush if we
675 have more than one X frame on the same X display.
2f935d86
DA
676 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
677 Use bool for booleans.
678 (x_draw_glyph_string_background, cvt_string_to_pixel):
679 (cvt_pixel_dtor): Drop unnecessary prototypes.
680 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 681
f435830e
DA
6822013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
683
684 Drop unnecessary functions that deals with frame pixel size.
685 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
686 (x_pixel_height): Drop prototypes.
687 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
688 (x_pixel_height): Drop implementations.
689 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
690 which should be always valid for window frame.
691 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
692 * w32menu.c (Fx_popup_dialog):
693 * xmenu.c (Fx_popup_dialog): Likewise for both.
694
84231434
DA
6952013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
696
697 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
698 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
699 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
700 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
701 and mention nil frame in docstring.
84231434 702
959067a1
DA
7032013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
704
705 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
706 (x_figure_window_size): Likewise. Adjust to return long.
707 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
708 (toplevel): Move Qterminal_live_p to...
709 * terminal.c (toplevel): ...here, make it static, and...
710 (syms_of_terminal): ...DEFSYM here.
711 * frame.h (Qterminal_live_p): Remove declaration.
712 (make_frame, x_figure_window_size): Adjust prototype.
713 * nsfns.m (Fx_create_frame): Use long for window flags.
714
f4b169ce
PE
7152013-07-30 Paul Eggert <eggert@cs.ucla.edu>
716
717 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
718 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
719 Do not assume that emacs_close (INT_MAX) is a no-op.
720
bee6a2c7
DA
7212013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
722
723 * xfaces.c (make_face_cache): For struct face_cache, prefer
724 xmalloc to xzalloc and so avoid redundant call to memset.
725 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
726
d7e6881a
DA
7272013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
728
729 * fringe.c (draw_window_fringes, update_window_fringes)
730 (compute_fringe_widths):
731 * w32term.c (x_draw_glyph_string):
732 * window.c (candidate_window_p, Frecenter):
733 * xfaces.c (realize_basic_faces, realize_default_face)
734 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
735 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
736 * xfns.c (x_set_cursor_color, xic_free_xfontset):
737 * xmenu.c (Fx_menu_bar_open_internal):
738 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
739 * xsettings.c (xft_settings_event):
740 * xterm.c (x_draw_glyph_string, x_had_errors_p):
741 Use bool for booleans. Adjust style and comments where
742 appropriate.
743 * dispextern.h (draw_window_fringes, update_window_fringes)
744 (compute_fringe_widths):
745 * xterm.h (x_had_errors_p): Adjust prototype.
746
ec3058af
DA
7472013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
748
749 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
750 CHECK_LIST. Rewrite the loop to avoid useless local variable.
751
218e0637
DA
7522013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
753
754 * fns.c (toplevel): Remove comment before Fsafe_length because
755 it checks for QUIT.
756
e560aba9
PE
7572013-07-28 Paul Eggert <eggert@cs.ucla.edu>
758
759 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
760
2e5ce5de
EZ
7612013-07-28 Eli Zaretskii <eliz@gnu.org>
762
763 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
764 frame which got the message is still alive, before dereferencing
765 its pointer. (Bug#14970)
766
767 * frame.c (delete_frame): Test "this" frame's minibuffer window to
768 be a live window, before using it as such. (Bug#14970)
769
e95da6d3
EZ
7702013-07-27 Eli Zaretskii <eliz@gnu.org>
771
772 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
773 w32_detect_focus_change instead of doing part of its job by hand.
774 This fixes the problem whereby FOCUS_OUT events were not sent to
775 the event queue.
776
a8f93651
EZ
7772013-07-26 Eli Zaretskii <eliz@gnu.org>
778
fec92060
EZ
779 * process.c (Fprocess_list): Doc fix.
780
a8f93651
EZ
781 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
782 being re-exposed only if it didn't ask to become visible.
783 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
784 was previously iconified. (Bug#14841)
785 (x_iconify_frame): Mark the frame iconified.
786
d5a7a9d9
PE
7872013-07-26 Paul Eggert <eggert@cs.ucla.edu>
788
789 Fix minor problems found by static checking.
790 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
791 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
792
56ea7291
SM
7932013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
794
795 * eval.c (set_specpdl_old_value): New function.
796 (unbind_to): Minor simplification.
797 (get_backtrace_frame): New function.
798 (Fbacktrace_frame): Use it. Add `base' argument.
799 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
800 (syms_of_eval): Export backtrace-eval.
801 * xterm.c (x_focus_changed): Simplify.
802
9d611ffe
PE
8032013-07-25 Paul Eggert <eggert@cs.ucla.edu>
804
805 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
806
999c74e3
EZ
8072013-07-24 Eli Zaretskii <eliz@gnu.org>
808
809 * xdisp.c (redisplay_window): Instead of moving point out of
810 scroll margin, reject the force_start method, and try scrolling
811 instead. (Bug#14780)
812
198fa217
KB
8132013-07-24 Ken Brown <kbrown@cornell.edu>
814
815 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
816 (Bug#14944).
817
53840e55
PE
8182013-07-24 Paul Eggert <eggert@cs.ucla.edu>
819
820 * eval.c (Fprogn): Do not check that BODY is a proper list.
821 This undoes the previous change. The check slows down the
822 interpreter, and is not needed to prevent a crash. See
823 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
824
60967f56
GM
8252013-07-23 Glenn Morris <rgm@gnu.org>
826
827 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
828
9ca960e2
PE
8292013-07-23 Paul Eggert <eggert@cs.ucla.edu>
830
a29c3e6d
PE
831 Port to GNU/Linux systems with tinfo but not ncurses.
832 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
833 to decide whether ncurses is being used. Without this change,
834 GCC complains about tgetent not being declared, on a system
835 that has tinfo installed but ncurses not installed.
836
f274311c
PE
837 * eval.c (Fprogn): Check that BODY is a proper list.
838
16b0520a
PE
839 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
840 * data.c (Fsetq_default):
841 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
842 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
843 (Fcondition_case):
844 Tune by taking advantage of the fact that ARGS is always a list
845 when a function is declared to have UNEVALLED args.
846
9ca960e2
PE
847 * emacsgtkfixed.c: Port to GCC 4.6.
848 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
849
afacaa1b
JB
8502013-07-23 Juanma Barranquero <lekktu@gmail.com>
851
852 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
853 here to silence compiler warnings.
854
368a85a4
PE
8552013-07-22 Paul Eggert <eggert@cs.ucla.edu>
856
857 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
858 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
859 from messing up Emacs's 'struct frame' (Bug#14923).
860
f4e891b5
PE
8612013-07-21 Paul Eggert <eggert@cs.ucla.edu>
862
863 * alloc.c (make_save_ptr_ptr): Define this function.
864 It was inadvertently omitted. It's needed only if
865 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
866
96c8b65e
JD
8672013-07-21 Jan Djärv <jan.h.d@swipnet.se>
868
869 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
870 frame have focus (Bug#14895).
871
ee010797
PE
8722013-07-21 Paul Eggert <eggert@cs.ucla.edu>
873
874 Avoid vfork-related deadlock more cleanly.
875 * callproc.c (child_setup): When the child's exec fails, output
876 the program name, as that's more useful. Use O_NONBLOCK to avoid
877 deadlock.
878 * process.c (create_process_1): Remove; no longer needed.
879 (create_process): Remove timer hack; no longer needed, now that
880 the child avoids deadlock.
881
f0398ec1 8822013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
883
884 * image.c (Fimage_flush): Fix doc typo.
885
b2a069c2
PE
8862013-07-20 Paul Eggert <eggert@cs.ucla.edu>
887
6496aec9
PE
888 Fix array bounds violation when pty allocation fails.
889 * process.c (PTY_NAME_SIZE): New constant.
890 (pty_name): Remove static variable; it's now auto.
891 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
892 Take pty_name as an arg rather than using a static variable.
893 All callers changed.
894 (create_process): Recover pty_flag from process, not from volatile local.
895 (create_pty): Stay inside array even when pty allocation fails.
896 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
897
b2a069c2
PE
898 * lread.c (Fload): Avoid initialization only when lint checking.
899 Mention that it's needed only for older GCCs.
900
99107004
KH
9012013-07-20 Kenichi Handa <handa@gnu.org>
902
903 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
904 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
905
6b1b199d
AS
9062013-07-20 Andreas Schwab <schwab@linux-m68k.org>
907
908 * lread.c (Fload): Avoid uninitialized warning.
909
4195afc3
PE
9102013-07-19 Paul Eggert <eggert@cs.ucla.edu>
911
3f5bef16
PE
912 Fix some minor file descriptor leaks and related glitches.
913 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
914 (create_lock_file): Use write, not emacs_write.
915 * image.c (slurp_file, png_load_body):
916 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
917 (server_accept_connection):
918 Don't leak an fd on memory allocation failure.
919 * image.c (slurp_file): Add a cheap heuristic for growing files.
920 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
921 as that's what the other routines do. Maybe input need not be
922 blocked at all, but it's better to be consistent.
923 Avoid undefined behavior when strlen is zero.
924
4195afc3
PE
925 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
926 (NSTATICS): Now a constant; doesn't need to be a macro.
927
a1aeeffe
RS
9282013-07-19 Richard Stallman <rms@gnu.org>
929
930 * coding.c (decode_coding_utf_8): Add simple loop for fast
931 processing of ASCII characters.
932
63b34baa
PE
9332013-07-19 Paul Eggert <eggert@cs.ucla.edu>
934
935 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
936
621dd9ac
EZ
9372013-07-19 Eli Zaretskii <eliz@gnu.org>
938
939 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
940 unportable 'struct x_display_info'.
941 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
942 is a portable type.
943
1396ac86
PE
9442013-07-19 Paul Eggert <eggert@cs.ucla.edu>
945
ab9980cd
PE
946 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
947 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
948 or fscanf fails.
949 (system_process_attributes): Prefer plain char to unsigned char
950 when either will do. Clean up properly if interrupted or if
951 memory allocations fail. Don't assume sscanf succeeds. Remove
952 no-longer-needed workaround to stop GCC from whining. Read
953 command-line once, instead of multiple times. Check read status a
954 bit more carefully.
955
1396ac86
PE
956 Fix obscure porting bug with varargs functions.
957 The code assumed that int is treated like ptrdiff_t in a vararg
958 function, which is not a portable assumption. There was a similar
959 -- though these days less likely -- porting problem with various
960 assumptions that pointers of different types all smell the same as
961 far as vararg functions is conserved. To make this problem less
962 likely in the future, redo the API to use varargs functions.
963 * alloc.c (make_save_value): Remove this vararg function.
964 All uses changed to ...
965 (make_save_int_int_int, make_save_obj_obj_obj_obj)
966 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
967 New functions.
968 (make_save_ptr): Rename from make_save_pointer, for consistency with
969 the above. Define only on platforms that need it. All uses changed.
970
4d19d194
PE
9712013-07-18 Paul Eggert <eggert@cs.ucla.edu>
972
973 * keyboard.c: Try to fix typos in previous change.
974 (DISPLAY_LIST_INFO): New macro.
975 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 976 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 977
945c5bb1
JB
9782013-07-18 Juanma Barranquero <lekktu@gmail.com>
979
980 * keyboard.c (kbd_buffer_get_event):
981 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
982 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
983
f4b1eb36
PE
9842013-07-18 Paul Eggert <eggert@cs.ucla.edu>
985
5e679a2c
PE
986 * filelock.c: Fix unlikely file descriptor leaks.
987 (get_boot_time_1): Rework to avoid using emacs_open.
988 This doesn't actually fix a leak, but is better anyway.
989 (read_lock_data): Use read, not emacs_read.
990
a8cd4836
PE
991 * doc.c: Fix minor memory and file descriptor leaks.
992 * doc.c (get_doc_string): Fix memory leak when doc file absent.
993 (get_doc_string, Fsnarf_documentation):
994 Fix file descriptor leak on error.
995
ef30e638
PE
996 * term.c: Fix minor fdopen-related file descriptor leaks.
997 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
998 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
999
f4b1eb36
PE
1000 * charset.c: Fix file descriptor leaks and errno issues.
1001 Include <errno.h>.
1002 (load_charset_map_from_file): Don't leak file descriptor on error.
1003 Use plain record_xmalloc since the allocation is larger than
1004 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1005 of entries.
1006 * eval.c (record_unwind_protect_nothing):
1007 * fileio.c (fclose_unwind):
1008 New functions.
1009 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1010 The replacement doesn't block input, but that no longer seems
1011 necessary.
1012
b648c163
PE
10132013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1014
a0931322
PE
1015 * lread.c: Fix file descriptor leaks and errno issues.
1016 (Fload): Close some races that leaked fds or streams when 'load'
1017 was interrupted.
1018 (Fload, openp): Report error number of last nontrivial failure to open.
1019 ENOENT counts as trivial.
1020 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1021 New functions.
1022 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1023 now that the function is always called with a nonnegative arg.
1024 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1025 All uses replaced with ...
1026 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1027
b648c163
PE
1028 A few more minor file errno-reporting bugs.
1029 * callproc.c (Fcall_process):
1030 * doc.c (Fsnarf_documentation):
1031 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1032 * process.c (set_socket_option):
1033 Don't let a constructor trash errno.
1034 * doc.c: Include <errno.h>.
1035
b1dc4084
JB
10362013-07-16 Juanma Barranquero <lekktu@gmail.com>
1037
1038 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1039
c43843aa
PE
10402013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1041
50a30cce
PE
1042 Fix w32 bug with call-process-region (Bug#14885).
1043 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1044 to Fcall_process when the input is empty. This simplifies the
1045 code a bit. It makes no difference on POSIXish platforms but
1046 apparently it fixes a bug on w32.
1047
44e18199 1048 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1049 * fileio.c (close_file_unwind): Don't close if FD is negative;
1050 this can happen when unwinding a zapped file descriptor.
1051 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1052 in case Emacs runs out of memory between the two unwind-protects.
1053 Don't trash errno when closing FD.
1054 Zap the FD in the specpdl when closing it, instead of deferring
1055 the removal of the unwind-protect; this fixes a bug where a child
1056 function unwinds the stack past us.
1057
27e498e6
PE
1058 New unwind-protect flavors to better type-check C callbacks.
1059 This also lessens the need to write wrappers for callbacks,
1060 and the need for make_save_pointer.
1061 * alloca.c (free_save_value):
1062 * atimer.c (run_all_atimers):
1063 Now extern.
1064 * alloc.c (safe_alloca_unwind):
1065 * atimer.c (unwind_stop_other_atimers):
1066 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1067 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1068 * minibuf.c (choose_minibuf_frame_1):
1069 * process.c (make_serial_process_unwind):
1070 * xdisp.h (pop_message_unwind):
1071 * xselect.c (queue_selection_requests_unwind):
1072 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1073 * alloca.c (record_xmalloc):
1074 Prefer record_unwind_protect_ptr to record_unwind_protect with
1075 make_save_pointer.
1076 * alloca.c (Fgarbage_collect):
1077 Prefer record_unwind_protect_void to passing a dummy.
1078 * buffer.c (restore_buffer):
1079 * window.c (restore_window_configuration):
1080 * xfns.c, w32fns.c (do_unwind_create_frame)
1081 New wrapper. All record-unwind uses of wrappee changed.
1082 * buffer.c (set_buffer_if_live):
1083 * callproc.c (call_process_cleanup, delete_temp_file):
1084 * coding.c (code_conversion_restore):
1085 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1086 * editfns.c (save_excursion_restore)
1087 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1088 (save_restriction_restore):
1089 * eval.c (restore_stack_limits, un_autoload):
1090 * fns.c (require_unwind):
1091 * keyboard.c (recursive_edit_unwind, tracking_off):
1092 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1093 * macros.c (pop_kbd_macro, restore_menu_items):
1094 * nsfns.m (unwind_create_frame):
1095 * print.c (print_unwind):
1096 * process.c (start_process_unwind):
1097 * search.c (unwind_set_match_data):
1098 * window.c (select_window_norecord, select_frame_norecord):
1099 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1100 (fast_set_selected_frame):
1101 * xfns.c, w32fns.c (unwind_create_tip_frame):
1102 Return void, not a dummy Lisp_Object. All uses changed.
1103 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1104 * callproc.c (call_process_kill):
1105 * fileio.c (restore_point_unwind, decide_coding_unwind)
1106 (build_annotations_unwind):
1107 * insdel.c (Fcombine_after_change_execute_1):
1108 * keyboard.c (read_char_help_form_unwind):
1109 * menu.c (unuse_menu_items):
1110 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1111 * sound.c (sound_cleanup):
1112 * xdisp.c (unwind_redisplay):
1113 * xfns.c (clean_up_dialog):
1114 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1115 Accept no args and return void, instead of accepting and returning
1116 a dummy Lisp_Object. All uses changed.
1117 * cygw32.c (fchdir_unwind):
1118 * fileio.c (close_file_unwind):
1119 * keyboard.c (restore_kboard_configuration):
1120 * lread.c (readevalllop_1):
1121 * process.c (wait_reading_process_output_unwind):
1122 Accept int and return void, rather than accepting an Emacs integer
1123 and returning a dummy object. In some cases this fixes an
1124 unlikely bug when the corresponding int is outside Emacs integer
1125 range. All uses changed.
1126 * dired.c (directory_files_internal_unwind):
1127 * fileio.c (do_auto_save_unwind):
1128 * gtkutil.c (pop_down_dialog):
1129 * insdel.c (reset_var_on_error):
1130 * lread.c (load_unwind):
1131 * xfns.c (clean_up_file_dialog):
1132 * xmenu.c, nsmenu.m (pop_down_menu):
1133 * xmenu.c (cleanup_widget_value_tree):
1134 * xselect.c (wait_for_property_change_unwind):
1135 Accept pointer and return void, rather than accepting an Emacs
1136 save value encapsulating the pointer and returning a dummy object.
1137 All uses changed.
1138 * editfns.c (Fformat): Update the saved pointer directly via
1139 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1140 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1141 (unwind_body): New function.
1142 (record_unwind_protect): First arg is now a function returning void,
1143 not a dummy Lisp_Object.
1144 (record_unwind_protect_ptr, record_unwind_protect_int)
1145 (record_unwind_protect_void): New functions.
1146 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1147 * fileio.c (struct auto_save_unwind): New type.
1148 (do_auto_save_unwind): Use it.
1149 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1150 * insdel.c (struct rvoe_arg): New type.
1151 (reset_var_on_error): Use it.
1152 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1153 New constants.
1154 (specbinding_func): Remove; there are now several such functions.
1155 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1156 (set_unwind_protect_ptr): New function.
1157 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1158
4e604a5d
PE
1159 Be simpler and more consistent about reporting I/O errors.
1160 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1161 Say "Read error" and "Write error", rather than "I/O error", or
1162 "IO error reading", or "IO error writing", when a read or write
1163 error occurs.
1164 * process.c (Fmake_network_process, wait_reading_process_output)
1165 (send_process, Fprocess_send_eof, wait_reading_process_output):
1166 Capitalize diagnostics consistently. Put "failed foo" at the
1167 start of the diagnostic, so that we don't capitalize the
1168 function name "foo". Consistently say "failed" for such
1169 diagnostics.
1170 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1171 All callers changed. This is so it can use report_file_error.
1172 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1173 diagnostics consistently as above.
1174
a9757f6a
PE
1175 * fileio.c (report_file_errno): Fix errno reporting bug.
1176 If the file name is neither null nor a pair, package it up as a
1177 singleton list. All callers changed, both to this function and to
1178 report_file_error. This fixes a bug where the memory allocator
1179 invoked by list1 set errno so that the immediately following
1180 report_file_error reported the wrong errno value.
1181
c43843aa
PE
1182 Fix minor problems found by --enable-gcc-warnings.
1183 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1184 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1185
18c26d81
JD
11862013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1187
1188 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1189 Set event->arg to Qt if switch-event shall be generated.
1190 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1191
1192 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1193
1194 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1195 FOCUS_OUT_EVENT.
1196
1197 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1198 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1199 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1200 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1201 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1202 and there is a focused frame.
1203 (head_table): Add focus-in and focus-out.
1204 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1205 bind to handle-focus-in/out.
1206
1207 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1208 (Fhandle_switch_frame): Call Fhandle_focus_in.
1209 (syms_of_frame): defsubr handle-focus-in/out.
1210
6c6f1994
PE
12112013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1212
c7ddc792
PE
1213 Fix porting bug to older POSIXish platforms (Bug#14862).
1214 * sysdep.c (emacs_pipe): New function, that implements
1215 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1216 This should port better to CentOS 5 and to Mac OS X 10.6.
1217 All calls to pipe2 changed.
1218
6c6f1994
PE
1219 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1220 This makes the code easier to read and the executable a bit smaller.
1221 Do not replace all calls to Fcons that happen to create lists,
1222 just calls that are intended to create lists. For example, when
1223 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1224 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1225 Similarly for list2 through list5.
1226 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1227 * bytecode.c (exec_byte_code):
1228 * callint.c (quotify_arg, Fcall_interactively):
1229 * callproc.c (Fcall_process, create_temp_file):
1230 * charset.c (load_charset_map_from_file)
1231 (Fdefine_charset_internal, init_charset):
1232 * coding.c (get_translation_table, detect_coding_system)
1233 (Fcheck_coding_systems_region)
1234 (Fset_terminal_coding_system_internal)
1235 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1236 * composite.c (update_compositions, Ffind_composition_internal):
1237 * dired.c (directory_files_internal, file_name_completion)
1238 (Fsystem_users):
1239 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1240 * doc.c (Fsnarf_documentation):
1241 * editfns.c (Fmessage_box):
1242 * emacs.c (main):
1243 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1244 (Feval, eval_sub, Ffuncall, apply_lambda):
1245 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1246 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1247 (Fset_file_times, Finsert_file_contents)
1248 (Fchoose_write_coding_system, Fwrite_region):
1249 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1250 * font.c (font_registry_charsets, font_parse_fcname)
1251 (font_prepare_cache, font_update_drivers, Flist_fonts):
1252 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1253 * frame.c (make_frame, Fmake_terminal_frame)
1254 (x_set_frame_parameters, x_report_frame_params)
1255 (x_default_parameter, Fx_parse_geometry):
1256 * ftfont.c (syms_of_ftfont):
1257 * image.c (gif_load):
1258 * keyboard.c (command_loop_1):
1259 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1260 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1261 (Fminor_mode_key_binding, accessible_keymaps_1)
1262 (Faccessible_keymaps, Fwhere_is_internal):
1263 * lread.c (read_emacs_mule_char):
1264 * menu.c (find_and_return_menu_selection):
1265 * minibuf.c (get_minibuffer):
1266 * nsfns.m (Fns_perform_service):
1267 * nsfont.m (ns_script_to_charset):
1268 * nsmenu.m (ns_popup_dialog):
1269 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1270 (Fx_own_selection_internal):
1271 * nsterm.m (append2):
1272 * print.c (Fredirect_debugging_output)
1273 (print_prune_string_charset):
1274 * process.c (Fdelete_process, Fprocess_contact)
1275 (Fformat_network_address, set_socket_option)
1276 (read_and_dispose_of_process_output, write_queue_push)
1277 (send_process, exec_sentinel):
1278 * sound.c (Fplay_sound_internal):
1279 * textprop.c (validate_plist, add_properties)
1280 (Fput_text_property, Fadd_face_text_property)
1281 (copy_text_properties, text_property_list, syms_of_textprop):
1282 * unexaix.c (report_error):
1283 * unexcoff.c (report_error):
1284 * unexsol.c (unexec):
1285 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1286 (Fformat_mode_line, syms_of_xdisp):
1287 * xfaces.c (set_font_frame_param)
1288 (Finternal_lisp_face_attribute_values)
1289 (Finternal_merge_in_global_face, syms_of_xfaces):
1290 * xfns.c (x_default_scroll_bar_color_parameter)
1291 (x_default_font_parameter, x_create_tip_frame):
1292 * xfont.c (xfont_supported_scripts):
1293 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1294 (menu_help_callback, xmenu_show):
1295 * xml.c (make_dom):
1296 * xterm.c (set_wm_state):
1297 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1298 and similarly for list2 through list5.
1299
bafe80ce
PE
13002013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * callproc.c (Fcall_process_region): Fix minor race and tune.
1303 (create_temp_file): New function, with the temp-file-creation part
1304 of the old Fcall_process_region. Use Fcopy_sequence to create the
1305 temp file name, rather than alloca + build_string, for simplicity.
1306 Don't bother to block input around the temp file creation;
1307 shouldn't be needed. Simplify use of mktemp. Use
1308 record_unwind_protect immediately after creating the temp file;
1309 this closes an unlikely race where the temp file was not removed.
1310 Use memcpy rather than an open-coded loop.
1311 (Fcall_process_region): Use the new function. If the input is
1312 empty, redirect from /dev/null rather than from a newly created
1313 empty temp file; this avoids unnecessary file system traffic.
1314
4700b5a5
PE
13152013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1316
5c97beae
PE
1317 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1318 Simplify by making this case like the other two. This is a bit
1319 slower on obsolete hosts, but the extra complexity isn't worth it.
1320
4700b5a5
PE
1321 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1322 * process.c (create_process) [!DOS_NT]:
1323 Remove now-unnecessary calls to emacs_close.
1324
f9a74c4c
EZ
13252013-07-13 Eli Zaretskii <eliz@gnu.org>
1326
922ae7ee
EZ
1327 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1328 returning early. (Bug#14850)
1329
f9a74c4c
EZ
1330 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1331 and inhibit-iso-escape-detection attributes of 'undecided'.
1332 (Bug#14822)
1333
5e301d76
PE
13342013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1335
69e0e5ee
PE
1336 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1337 Reported by Herbert J. Skuhra in
1338 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1339
5e301d76
PE
1340 Don't lose top specpdl entry when memory is exhausted.
1341 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1342 specpdl overflow here, to simplify callers; all callers changed.
1343 Always reserve an unused entry at the stack top; this avoids
1344 losing the top entry's information when memory is exhausted.
1345
7e649856
PE
13462013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1347
a773ed9a
PE
1348 Clean up errno reporting and fix some errno-reporting bugs.
1349 * callproc.c (Fcall_process):
1350 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1351 * process.c (create_process, Fmake_network_process):
1352 * unexaix.c (report_error):
1353 * unexcoff.c (report_error):
1354 Be more careful about reporting the errno of failed operations.
1355 The code previously reported the wrong errno sometimes.
1356 Also, prefer report_file_errno to setting errno + report_file_error.
1357 (Fcall_process): Look at openp return value rather than at path,
1358 as that's a bit faster and clearer when there's a numeric predicate.
1359 * fileio.c (report_file_errno): New function, with most of the
1360 old contents of report_file_error.
1361 (report_file_error): Use it.
1362 (Ffile_exists_p, Ffile_accessible_directory_p):
1363 Set errno to 0 when it is junk.
1364 * fileio.c (Faccess_file):
1365 * image.c (x_create_bitmap_from_file):
1366 Use faccessat rather than opening the file, to avoid the hassle of
1367 having a file descriptor open.
1368 * lisp.h (report_file_errno): New decl.
1369 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1370
7e649856
PE
1371 Minor EBADF fixes.
1372 * process.c (create_process, wait_reading_process_output) [AIX]:
1373 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1374 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1375 a multithreaded environment anyway).
1376 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1377
f6774c1a
AS
13782013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1379
1380 * image.c (x_find_image_file): Don't close a remote file handle.
1381
bacba3c2
PE
13822013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 Fix races with threads and file descriptors.
1385 * callproc.c (Fcall_process_region):
1386 * dired.c (open_directory):
1387 * emacs.c (main, Fdaemon_initialized):
1388 * image.c (x_find_image_file):
1389 * inotify.c (Finotify_rm_watch):
1390 * lread.c (Flocate_file_internal):
1391 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1392 * term.c (term_mouse_moveto, init_tty):
1393 * termcap.c (tgetent):
1394 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1395 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1396 * unexhp9k800.c, unexmacosx.c (unexec):
1397 * callproc.c (Fcall_process_region):
1398 Use emacs_close, not close.
1399 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1400 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1401 and posix_close function on current platforms (which all lack them).
1402 (emacs_close): Use it. This should fix the races on GNU/Linux and
1403 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1404 and it should avoid closing random victim file descriptors on
1405 other platforms.
1406
653d4f43
PE
14072013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1408
c8536ec4
PE
1409 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1410 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1411 Touch up doc a bit.
1412
9c203066
PE
1413 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1414 This is for .gdbinit xbacktrace.
1415
653d4f43
PE
1416 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1417 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1418 (emacs_set_tty): Now static.
1419 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1420 * term.c (tty_capable_p, tty_default_color_capabilities)
1421 (get_tty_terminal, term_mouse_movement)
1422 (handle_one_term_event, init_tty, maybe_fatal):
1423 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1424 (tgetent, scan_file, name_match, compare_contin):
1425 * terminal.c (get_terminal):
1426 Use bool for boolean.
1427 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1428 Prefer char to unsigned char if either will do.
1429 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1430 (tty_write_glyphs): Prefer int to unsigned.
1431 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1432 All callers changed.
1433 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1434
45b683a1
PE
14352013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1436
29abe551
PE
1437 Port to C89.
1438 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1439 (B__dummy__): New dummy symbol, to pacify C89.
1440 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1441 they can't grok varargs macros.
1442 * dispnew.c (add_window_display_history)
1443 (add_frame_display_history):
1444 * print.c (print_object):
1445 * xdisp.c (debug_method_add):
1446 Use %p printf format only for void pointers.
1447 * emacs.c (usage_message): New constant, replacing ...
1448 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1449 (main): Adjust to usage reorg.
1450 * fns.c (syms_of_fns):
1451 * profiler.c (syms_of_profiler):
1452 Don't use non-constant struct initializers.
1453 * gnutls.h (gnutls_initstage_t):
1454 * lisp.h (enum Lisp_Fwd_Type):
1455 * lread.c (lisp_file_lexically_bound_p):
1456 * xsettings.c (anonymous enum):
1457 Remove trailing comma.
1458 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1459 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1460 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1461 (DEFUN): Use it.
1462 * regex.c (const_re_char): New type, to pacify strict C89.
1463 All uses of 'const re_char' replaced to use it.
1464 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1465 with glibc when strict C89. This change is imported from gnulib.
1466 All uses changed.
1467 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1468 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1469 Omit GNU_LINUX implementation, since it requires long long.
1470 * xterm.c (x_draw_underwave):
1471 Do not assume the traditional order of struct's members.
1472 (x_term_init): Rewrite to avoid the need for non-constant structure
1473 initializers.
1474
45b683a1 1475 Syntax cleanup, mostly replacing macros with functions.
763a086d 1476 This removes the need for the syntax_temp hack.
45b683a1
PE
1477 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1478 * syntax.c (SYNTAX_INLINE): New macro.
1479 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1480 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1481 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1482 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1483 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1484 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1485 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1486 Now constants, not macros.
1487 (syntax_temp) [!__GNUC__]: Remove.
1488 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1489 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1490 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1491 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1492 Move here from syntax.h; now functions, not macros. Except for the
1493 last function, these are static since only syntax.c uses them.
1494 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1495 All uses changed. Now a function, not a macro; use this fact
1496 to simplify the code.
1497 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1498 compiler bugs; no longer relevant.
1499 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1500 (SYNTAX_INLINE): New macro.
1501 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1502 for the new functions. Use bool for boolean member.
1503 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1504 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1505 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1506 (SETUP_BUFFER_SYNTAX_TABLE):
1507 Now extern inline functions, not macros.
1508 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1509 Remove; all uses replaced by implementation.
1510 (syntax_temp) [!__GNUC__]: Remove decl.
1511 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1512
29be4a50
JD
15132013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1514
1515 * emacs.c (main): Fix syntax error.
1516
954b166e
PE
15172013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 Timestamp fixes for undo (Bug#14824).
1520 * atimer.c (schedule_atimer):
1521 * fileio.c (Ffile_newer_than_file_p):
1522 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1523 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1524 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1525 (syms_of_fileio): Remove Sclear_visited_file_name.
1526 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1527 file doesn't exist; this avoids an ambiguity with negative timestamps.
1528 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1529 * systime.h (make_emacs_time, invalid_emacs_time):
1530 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1531 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1532 * undo.c (record_first_change): Push (visited-file-modtime) onto
1533 undo list rather than reimplementing it by hand, incorrectly.
1534
d74647c3
KB
15352013-07-09 Ken Brown <kbrown@cornell.edu>
1536
1537 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1538
3c51b96b
JB
15392013-07-09 Juanma Barranquero <lekktu@gmail.com>
1540
1541 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1542
4ebbdd67
PE
15432013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1544
1545 Handle errno and exit status a bit more carefully.
1546 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1547 number into an exit status. Instead, use EXIT_CANCELED.
1548 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1549 * callproc.c (relocate_fd):
1550 * emacs.c (close_output_streams, main):
1551 * process.c (create_process):
1552 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1553 Use emacs_perror for simplicity.
1554 * callproc.c (relocate_fd, main):
1555 * sysdep.c (sys_subshell):
1556 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1557 (shut_down_emacs): Use emacs_write, not write.
1558 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1559 * fileio.c (Fcopy_file, e_write):
1560 * nsterm.m (ns_select):
1561 * process.c (send_process):
1562 * sound.c (vox_write):
1563 Use emacs_write_sig, not emacs_write.
1564 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1565 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1566 New constants.
1567 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1568 of write.
1569 (emacs_full_write): New function.
1570 (emacs_write): Rewrite to use it.
1571 (emacswrite_sig, emacs_perror): New functions.
1572 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1573
44e18199 15742013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1575
1576 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1577 on NS even if it is present. Pixmap on NS is a void*.
1578
9caab067
PE
15792013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 Port to Ubuntu 10 (Bug#14803).
1582 Problem reported by T.V. Raman.
1583 * process.c (close_on_exec, accept4, process_socket):
1584 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1585
1d442672
EZ
15862013-07-07 Eli Zaretskii <eliz@gnu.org>
1587
1588 * w32.c (sys_dup): Declare prototype.
1589
1590 * filelock.c:
1591 * emacs.c:
1592 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1593
067428c1
PE
15942013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 Make file descriptors close-on-exec when possible (Bug#14803).
1597 This simplifies Emacs a bit, since it no longer needs to worry
1598 about closing file descriptors by hand in some cases.
1599 It also fixes some unlikely races. Not all such races, as
1600 libraries often open files internally without setting
1601 close-on-exec, but it's an improvement.
1602 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1603 * callproc.c (Fcall_process) [!MSDOS]:
1604 * emacs.c (main) [!DOS_NT]:
1605 * nsterm.m (ns_term_init):
1606 * process.c (create_process):
1607 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1608 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1609 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1610 Prefer mkostemp with O_CLOEXEC to mkstemp.
1611 * callproc.c (relocate_fd) [!WINDOWSNT]:
1612 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1613 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1614 now using pipe2.
1615 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1616 Make the resulting file descriptor close-on-exec.
1617 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1618 * lread.c (load_descriptor_list, load_descriptor_unwind):
1619 Remove; no longer needed. All uses removed.
1620 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1621 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1622 New functions.
1623 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1624 (Fmake_network_process, Fnetwork_interface_list):
1625 (Fnetwork_interface_info, server_accept_connection):
1626 Make newly-created socket close-on-exec.
1627 * sysdep.c (emacs_open, emacs_fopen):
1628 Make new-created descriptor close-on-exec.
1629 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1630 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1631
0da857dd
JD
16322013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1633
1634 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1635 for NS_IMPL_GNUSTEP.
1636
5f86adcd
PE
16372013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1638
1639 Fix openp errno handling.
1640 * callproc.c (Fcall_process): Preserve openp errno around close.
1641 * lread.c (openp): Set errno when returning -1, as some callers
1642 expect this.
1643
1afb1d07
JD
16442013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1645
1646 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1647
1648 * nsterm.h (NSSavePanel): Update comment.
1649 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1650 (ns_run_file_dialog): Declare.
1651
1652 * nsfns.m: Remove panelOK.
1653 (ns_fd_data): New.
1654 (ns_run_file_dialog): New function.
1655 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1656 event loop, so file dialog is popped up by ns_run_file_dialog, called
1657 by sendEvent (Bug#14578).
1658 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1659
3323c263
EZ
16602013-07-06 Eli Zaretskii <eliz@gnu.org>
1661
fdda0220
EZ
1662 * xdisp.c (default_line_pixel_height): New function.
1663 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1664 (try_cursor_movement, redisplay_window, try_window)
1665 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1666
1667 * window.c (window_scroll_pixel_based): use
1668 default_line_pixel_height.
1669
1670 * dispextern.h (default_line_pixel_height): Add prototype.
1671
1672 * frame.c (x_set_line_spacing): Accept a float value for
1673 line-spacing parameter, per the documentation.
1674
3323c263
EZ
1675 * data.c (Fmultibyte_string_p): Doc fix.
1676
47ba6d43
PE
16772013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1678
406af475
PE
1679 Use emacs_open more consistently when opening files.
1680 This handles EINTR more consistently now, and makes it easier
1681 to introduce other uniform changes to file descriptor handling.
1682 * src/systdio.h: New file.
1683 * src/buffer.c (mmap_init):
1684 * cygw32.c (chdir_to_default_directory):
1685 * dispnew.c (Fopen_termscript):
1686 * emacs.c (Fdaemon_initialized):
1687 * fileio.c (Fdo_auto_save):
1688 * image.c (slurp_file, png_load_body, jpeg_load_body):
1689 * keyboard.c (Fopen_dribble_file):
1690 * lread.c (Fload):
1691 * print.c (Fredirect_debugging_output):
1692 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1693 * termcap.c (tgetent):
1694 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1695 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1696 * w32term.c (w32_initialize) [CYGWIN]:
1697 * xfaces.c (Fx_load_color_file):
1698 Use emacs_open instead of plain open, and emacs_fopen instead of
1699 plain fopen.
1700 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1701 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1702 * callproc.c (default_output_mode): New constant.
1703 (Fcall_process): Use it to call emacs_open instead of plain creat.
1704 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1705 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1706 (emacs_fopen): New function.
1707 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1708 Include <lisp.h>, for emacs_open.
1709 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1710
47ba6d43
PE
1711 Remove duplicate #include directives.
1712 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1713 * xfaces.c:
1714 Don't include stdio.h twice.
1715 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1716 Don't include sys/types.h or stdio.h twice.
1717 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1718 * lread.c: Don't include coding.h twice.
1719 * nsfont.m: Don't include frame.h twice.
1720 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1721 * ralloc.c: Don't include <unistd.h> twice.
1722 * xdisp.c: Don't include font.h twice.
1723 * xterm.c: Don't include fontset.h twice.
1724 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1725
b9ed53d5
PE
17262013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 Scale ImageMagick images more carefully.
1729 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1730 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1731 Be more careful about avoiding undefined behavior after
1732 integer overflow and division by zero.
1733
cf13177e
YM
17342013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1735
1736 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1737 (syms_of_w32fns): DEFSYM them.
1738 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1739 (CCHDEVICENAME): Define macros if not defined.
1740 (struct MONITOR_INFO_EX): New struct.
1741 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1742 (enum_display_monitors_fn): New variable.
1743 (globals_of_w32fns): Initialize it.
1744 (Fx_display_pixel_width, Fx_display_pixel_height)
1745 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1746 multi-monitor setups in docstrings.
1747 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1748 screen size by primary monitor's millimeter per pixel.
1749 (w32_monitor_enum, w32_display_monitor_attributes_list)
1750 (w32_display_monitor_attributes_list_fallback)
1751 (Fw32_display_monitor_attributes_list): New functions.
1752 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1753
1754 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1755 if not defined.
1756 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1757
86dfb7a8
MA
17582013-07-04 Michael Albinus <michael.albinus@gmx.de>
1759
1760 * fileio.c (Qfile_notify_error): New error symbol.
1761
1762 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1763 * inotify.c (inotify_callback, symbol_to_inotifymask)
1764 (Finotify_add_watch, Finotify_rm_watch): Use it.
1765 (inotifyevent_to_event): Exchange order of cookie and file name.
1766 (Finotify_add_watch): Adapt docstring.
1767
1768 * lisp.h (Qfile_notify_error): Declare.
1769
2c1c974b
PE
17702013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1773 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1774 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1775 which did not work (see <http://bugs.gnu.org/14569#307>).
1776 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1777 && (!noninteractive || initialized)). This attempts to thread
1778 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1779
7a35b20f
JB
17802013-07-04 Juanma Barranquero <lekktu@gmail.com>
1781
1782 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1783 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1784
1ce5cd04
PE
17852013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1788 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1789 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1790 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1791
57f8c490
PE
17922013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1795 Define to __sys_siglist.
1796
bcffb5ca
EZ
17972013-07-02 Eli Zaretskii <eliz@gnu.org>
1798
1799 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1800 word-wrap, so that overflow-newline-into-fringe would work in
1801 visual-line-mode. (Bug#2749)
1802 (move_it_in_display_line_to): When the last scanned display
1803 element fits exactly on the display line, and
1804 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1805 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1806 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1807 finding buffer position that corresponds to pixel coordinates,
1808 e.g. in buffer_posn_from_coords.
1809
2c41e781
JD
18102013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1811
1812 * process.c (handle_child_signal): Call catch_child_signal if
1813 NS_IMPL_GNUSTEP.
1814
c2418359
PE
18152013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1816
52a9bcae
PE
1817 Don't convert function pointers to void * and back.
1818 It isn't portable C, and it's easy enough to avoid.
1819 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1820 (make_save_value): Add support for SAVE_FUNCPOINTER.
1821 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1822 * print.c (print_object):
1823 Distinguish function from object pointers.
1824 * lisp.h (SAVE_FUNCPOINTER): New constant.
1825 (SAVE_SLOT_BITS): Adjust to it.
1826 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1827 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1828 (voidfuncptr): New typedef.
1829 (struct Lisp_Save_Value): New member data[0].funcpointer.
1830 (XSAVE_FUNCPOINTER): New function.
1831
c2418359
PE
1832 Simplify buildobj processing.
1833 * Makefile.in (buildobj.h): Make it a sequence of strings each
1834 followed by comma, rather than a single string. Put it into a
1835 .tmp file in case there's an error while generating it.
1836 (gl-stamp): Use .tmp for temp files.
1837 (mostlyclean): Clean .tmp files.
1838 * doc.c (buildobj): Move to just the routine that needs it.
1839 It's now an array of strings, so processing is simpler.
1840
8f43ce49
PE
18412013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1844 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1845 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1846 Invoke malloc_enable_thread even when not interactive.
1847 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1848 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1849 in this case, since the underlying bug has now been fixed.
1850
24827db9
JB
18512013-07-01 Juanma Barranquero <lekktu@gmail.com>
1852
1853 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1854 unlinking it (bug#14691).
1855
ef099a94
MN
18562013-06-30 Michal Nazarewicz <mina86@mina86.com>
1857
1858 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1859 before checking whether buffer is modified. This lets
1860 `kill-buffer-query-functions' cancel killing of the buffer or save
1861 its content before `kill-buffer' asks user the "Buffer %s
1862 modified; kill anyway?" question.
1863
9d3f2fc2
JD
18642013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1865
1866 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1867 Let the super performKeyEquivalent deal with them (Bug#14747).
1868
e6c6c8c7
PE
18692013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1870
1d71c1d9
PE
1871 * widget.c (resize_cb): Remove unused local.
1872
8f5f35cc
PE
1873 Do not use GTK 3 if it exists but cannot be compiled.
1874 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1875 * xterm.c (x_error_handler) [!USE_GTK]:
1876 Do not use GTK 3.
1877
e6c6c8c7
PE
1878 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1879
0ba54312
EZ
18802013-06-30 Eli Zaretskii <eliz@gnu.org>
1881
5d1c3286
EZ
1882 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1883 to the valid range of values. (Bug#14753)
1884
0ba54312
EZ
1885 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1886 when moving point by using the current glyph matrix. This avoids
1887 the need to force redisplay when this function is called in a
1888 loop.
1889
9c90cc06
PE
18902013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 Fix minor problems found by static checking.
1893 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1894 Redo the latter's body to sidestep GCC parenthesization warnings.
1895 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1896 * coding.c (detect_coding, detect_coding_system):
1897 * coding.h (struct undecided_spec):
1898 Use bool for boolean.
1899 * image.c (QCmax_width, QCmax_height): Now static.
1900 * xdisp.c (Fmove_point_visually): Remove unused local.
1901
4c672a0f
EZ
19022013-06-29 Eli Zaretskii <eliz@gnu.org>
1903
1904 * xdisp.c (Fmove_point_visually): New function.
1905
c1ea3abf
JB
19062013-06-28 Kenichi Handa <handa@gnu.org>
1907
1908 * coding.h (define_coding_undecided_arg_index): New enum.
1909 (coding_attr_index): New members
1910 coding_attr_undecided_inhibit_null_byte_detection,
1911 coding_attr_undecided_inhibit_iso_escape_detection,
1912 coding_attr_undecided_prefer_utf_8.
1913 (undecided_spec): New struct.
1914 (struct coding_system): New member `undecided' of the member
1915 `spec'.
1916
1917 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1918 (detect_coding): Likewise.
1919 (detect_coding_system): Likewise.
1920 (Fdefine_coding_system_internal): New coding system properties
1921 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1922 :prefer-utf-8.
1923 (syms_of_coding): Adjust for coding_arg_undecided_max.
1924
ba3de9e6
PE
19252013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * image.c (x_from_xcolors): Remove unused local.
1928
547c9269
YM
19292013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1930
1931 Defer image data transfer between X client and server until actual
1932 display happens.
1933
1934 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1935 and `mask_img'.
1936
1937 * image.c (Destroy_Image): Remove.
1938 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1939 `mask_p', and `colors_p'. All uses changed.
1940 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1941 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1942 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1943 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1944 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1945 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1946 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1947 (image_get_x_image, image_unget_x_image): New functions or macros.
1948 (image_background, image_background_transparent, x_to_xcolors)
1949 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1950 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1951 instead of Destroy_Image.
1952 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1953 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1954 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1955 (imagemagick_load_image, svg_load_image): Use them instead of
1956 x_create_x_image_and_pixmap, and x_put_x_image followed by
1957 x_destroy_x_image, respectively.
1958 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1959 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1960 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1961 background_transparent fields.
1962 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1963 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1964
dae2f5ef
PE
19652013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1968 This mostly consists of undoing recent changes.
1969 * callproc.c (Fcall_process):
1970 * process.c (create_process):
1971 Do not worry about catching SIGCHLD here, undoing previous change.
1972 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1973 * process.c, process.h (catch_child_signal):
1974 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1975 * process.c (catch_child_handler): Don't worry about being called
1976 lazily and do not assume caller has blocked SIGCHLD, undoing
1977 previous change. Move first-time stuff back to
1978 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1979 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1980 set lib_child_handler if it's already initialized, which may
1981 help avoid problems on GNUStep.
1982
fa55d2aa
PE
19832013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1986 * callproc.c (Fcall_process):
1987 * process.c (create_process):
1988 Make sure SIGCHLD is caught before we fork,
1989 since Emacs startup no arranges to catch SIGCHLD.
1990 * process.c (lib_child_handler): Initialize to null, not to
1991 dummy_handler.
1992 (catch_child_signal): Allow self to be called lazily.
1993 Do nothing if it's already been called.
1994 Assume caller has blocked SIGCHLD (all callers do now).
1995 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1996 just before it's really needed.
1997 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1998 since it hasn't been caught yet.
1999
f3f9606c
LMI
20002013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2001
2002 * image.c (compute_image_size): New function to implement
2003 :max-width and :max-height.
2004 (imagemagick_load_image): Use it.
2005
c7041908
PE
20062013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2007
2008 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2009 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2010 Now extern.
2011 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2012 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2013 the SIGCHLD handler, since the code is not atomic and (due to glib)
2014 signals may be arriving now.
2015 * sysdep.c (init_signals): Do not catch child signals here;
2016 'main' now does that later, at a safer time.
2017
f86852b4
PE
20182013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2019
0dfeed58
PE
2020 Clean up SIGCHLD handling a bit (Bug#14569).
2021 * process.c, process.h (catch_child_signal):
2022 Now always extern, even if !NS_IMPL_GNUSTEP.
2023 * process.c (catch_child_signal): Move glib tickler here from
2024 init_process_emacs, so that it's done earlier in Emacs
2025 initialization. Also move the noninteractive && !initialized
2026 check here from init_process_emacs. This is all a bit cleaner for
2027 GNUish platforms, and I hope it works around the Cygwin bug.
2028 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2029 that glib signal handling is tickled before glib creates threads.
2030
f86852b4
PE
2031 * process.c (wait_reading_process_output): Avoid int overflow
2032 when reading more than 2 GiB total from a process.
2033
cbd6509c
PE
20342013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 * process.c (create_process): Handle a couple more cases,
2037 i.e., work even if new_argv and wait_child_setup[i] are cached.
2038 Use Fcall_process's style for volatile vars.
2039
9de1114a
AS
20402013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2041
2042 * process.c (create_process): Mark PROCESS volatile.
2043
fbe9e0b9
PE
20442013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 Use C99-style flexible array members if available.
2047 This avoids some subtle aliasing issues, which typically
2048 aren't a problem with GCC but may be a problem elsewhere.
2049 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2050 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2051 In either case, it uses a flexible array member rather than
2052 the old struct hack. All uses changed.
2053 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2054 Adjust to sdata reorganization.
2055 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2056 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2057 that ports better to pre-C99 non-GCC.
2058 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2059 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2060 as the latter has changed.
2061 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2062 and port better to pre-C99 GCC.
2063 * image.c (struct xpm_cached_color):
2064 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2065 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2066 Use FLEXIBLE_ARRAY_MEMBER.
2067 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2068 Move decl to top level so it gets checked against implementation.
2069 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2070 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2071
1fc71008
PE
20722013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 * syntax.c: Integer cleanups.
2075 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2076 All uses that need 0-or-2 changed to:
2077 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2078 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2079 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2080 (char_quoted, prev_char_comend_first, back_comment)
2081 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2082 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2083 Use bool for boolean.
2084 (update_syntax_table, skip_chars, skip_syntaxes):
2085 Prefer int to unsigned when either will do.
2086 (back_comment): Return boolean success flag, like forw_comment,
2087 instead of positive-or-minus-1 (which might have overflowed int anyway).
2088 Don't stuff ptrdiff_t into int.
2089 (syntax_spec_code, syntax_code_spec): Now const.
2090 (Fmatching_paren, scan_lists, scan_sexps_forward):
2091 Use enum syntaxcode for syntax code.
2092 (Fmatching_paren): Check that arg is a character, not just an integer.
2093 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2094 (Finternal_describe_syntax_value): Omit no-longer-needed
2095 comparison to 0.
2096 (skip_chars): Use char, not unsigned char, when the distinction
2097 doesn't matter.
2098 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2099 * bytecode.c (exec_byte_code):
2100 * syntax.c (syntax_spec_code, Fchar_syntax)
2101 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2102 (init_syntax_once):
2103 * syntax.h (SYNTAX_WITH_FLAGS):
2104 Omit unnecessary casts.
2105
b932cad7
EZ
21062013-06-20 Eli Zaretskii <eliz@gnu.org>
2107
2108 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2109 line dimensions here, to avoid race conditions with the main
2110 thread. (Bug#14062, bug#14630, bug#14669)
2111
2112 * w32term.c (w32_draw_window_cursor): Compute the header line and
2113 mode line dimensions here.
2114 <w32_system_caret_window, w32_system_caret_hdr_height>:
2115 <w32_system_caret_mode_height>: New variables.
2116
2117 * w32term.h: Declare them.
2118
89561f72
PE
21192013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2120
5013fc08
PE
2121 * alloc.c (die): Move "assertion failed" string here ...
2122 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2123 COND when SUPPRESS_CHECKING. This shrinks the executable text
2124 size by 0.8% to 2.2% when configured with --enable-checking,
2125 depending on optimization flags (GCC 4.8.1 x86-64).
2126
89561f72
PE
2127 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2128
763a086d 21292013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2130
2131 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2132 base is 2; this is more accurate.
2133
983aeb9a
JB
21342013-06-19 Juanma Barranquero <lekktu@gmail.com>
2135
2136 * sound.c (string_default): Move to !WINDOWSNT section.
2137 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2138
178ba3e6
PE
21392013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2140
bbc51b15
PE
2141 * sound.c: Integer cleanups.
2142 Remove unnecessary forward decls.
2143 (struct sound_device): The 'file' member is now a Lisp_Object, not
2144 a char *, so that we needn't invoke alloca on a huge size.
2145 (Fplay_sound_internal): Adjust to this.
2146 (string_default): New function.
2147 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2148 Use it to adjust to the struct sound_device change.
2149 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2150 (be2hs) [0]: Remove.
2151
178ba3e6
PE
2152 * syntax.c (skip_chars): Don't use uninitialized storage
2153 when searching a multibyte buffer for characters that are not in a
2154 unibyte string that contains non-ASCII characters.
2155
69f60cdc
JD
21562013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2157
2158 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2159 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2160
0d6224d4
PE
21612013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2164
3c542890
KH
21652013-06-18 Kenichi Handa <handa@gnu.org>
2166
f7e3f7cd
KH
2167 * font.c (Ffont_spec): Signal an error for an invalid font name
2168 (Bug#14648).
3c542890 2169
9349e5f7
PE
21702013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2171
2172 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2173 In particular this ports to 32-bit sparc Sun cc.
2174 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2175 array with a dummy element at specpdl[-1], so that its address can
2176 be taken portably.
2177 (unbind_to): Do not copy the binding; not needed, now that we
2178 copy old_value in the one place where the copy is needed.
2179 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2180 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2181 (union specbinding): Rename from struct specbinding. Redo layout
2182 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2183 which is not portable. With Sun C 5.12 32-bit sparc, the
2184 declaration causes nargs to be an unsigned bitfield, a behavior
2185 that the C standard allows; but Emacs wants nargs to be signed.
2186 The overall type is now a union of structures rather than a
2187 structure of union of structures, and the 'kind' member is now a
2188 bitfield, so that the overall type doesn't grow. All uses changed.
2189 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2190
0a4df6a5
PE
21912013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2192
ec6ecaad
PE
2193 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2194 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2195
0a4df6a5
PE
2196 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2197
7bfe8dbc
EZ
21982013-06-17 Eli Zaretskii <eliz@gnu.org>
2199
2200 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2201 unless we know that the window w's frame is a frame object.
2202 Another attempt at solving bug#14062 and bug#14630.
2203
708e05f6
LMI
22042013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2205
2206 * textprop.c (property_set_type): New enum.
2207 (add_properties): Allow appending/prepending text properties.
2208 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2209 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2210 add_text_properties_1.
2211 (Fadd_face_text_property): New function that calls
2212 add_text_properties_1.
2213
84575e67
PE
22142013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2215
2216 Move functions from lisp.h to individual modules when possible.
2217 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2218 * alloc.c (XFLOAT_INIT, set_symbol_name):
2219 * buffer.c (CHECK_OVERLAY):
2220 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2221 (set_char_table_parent):
2222 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2223 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2224 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2225 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2226 (set_blv_valcell):
2227 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2228 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2229 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2230 (backtrace_args, backtrace_debug_on_exit):
2231 * floatfns.c (CHECK_FLOAT):
2232 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2233 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2234 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2235 (set_hash_index_slot):
2236 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2237 * marker.c (CHECK_MARKER):
2238 * textprop.c (CHECK_STRING_OR_BUFFER):
2239 * window.c (CHECK_WINDOW_CONFIGURATION):
2240 Move here from lisp.h, and make these functions static rather than
2241 extern inline.
2242 * buffer.c (Qoverlayp):
2243 * data.c (Qsubrp):
2244 * fns.c (Qhash_table_p):
2245 * window.c (Qwindow_configuration_p):
2246 Now static.
2247 * lisp.h: Remove the abovementioned defns and decls.
2248
44e18199 2249 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2250 In lisp.h, prefer functions to function-like macros, and
2251 constants to object-like macros, when either will do. This:
2252 . simplifies use, as there's no more need to worry about
2253 arguments' side effects being evaluated multiple times.
2254 . makes the code easier to debug on some platforms.
2255 However, when using gcc -O0, keep using function-like macros
2256 for a few critical operations, for performance reasons.
2257 This sort of thing isn't needed with gcc -Og, but -Og
2258 is a GCC 4.8 feature and isn't widely-enough available yet.
2259 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2260 Remove enum lsb_bits; no longer needed.
2261 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2262 * buffer.c (Qoverlap):
2263 * data.c (Qsubrp):
2264 * fns.c (Qhash_table_p):
2265 Now extern, so lisp.h can use these symbols.
2266 * dispextern.h: Include character.h, for MAX_CHAR etc.
2267 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2268 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2269 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2270 (GLYPH_CODE_P): Move here from lisp.h.
2271 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2272 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2273 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2274 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2275 XUNTAG now returns void *.
2276 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2277 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2278 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2279 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2280 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2281 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2282 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2283 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2284 New macros, renamed from their sans-lisp_h_ counterparts.
2285 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2286 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2287 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2288 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2289 If compiling via GCC without optimization, define these as macros
2290 in addition to inline functions.
2291 To disable this, compile with -DINLINING=0.
2292 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2293 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2294 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2295 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2296 (INTMASK, VALMASK): Now macros, since static values cannot be
2297 accessed from extern inline functions.
2298 (VALMASK): Also a constant, for benefit of old GDB.
2299 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2300 is INTEGERP, which can fold it in.
5165d44a 2301 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2302 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2303 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2304 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2305 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2306 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2307 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2308 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2309 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2310 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2311 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2312 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2313 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2314 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2315 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2316 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2317 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2318 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2319 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2320 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2321 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2322 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2323 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2324 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2325 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2326 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2327 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2328 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2329 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2330 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2331 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2332 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2333 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2334 Now functions.
2335 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2336 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2337 (VALMASK): Define in one place rather than in two, merging the
2338 USE_LSB_TAG parts; this is simpler.
2339 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2340 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2341 Move up, to avoid use before definition.
2342 Also include "globals.h" earlier, for the same reason.
2343 (make_natnum): New function.
2344 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2345 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2346 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2347 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2348 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2349 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2350 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2351 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2352 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2353 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2354 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2355 (Qwindow_configuration_p, Qimage): New forward declarations.
2356 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2357 (STRING_COPYIN): Remove; unused.
2358 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2359 (xcar_addr, xcdr_addr): New functions. All uses changed.
2360 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2361 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2362 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2363 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2364 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2365 (TYPE_RANGED_INTEGERP): Simplify.
2366 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2367 (setlocale, fixup_locale, synchronize_system_messages_locale)
2368 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2369 Now empty functions, not macros.
2370 (functionp): Return bool, not int.
2371 * window.c (Qwindow_configuration_p): Now extern,
2372 so window.h can use it.
2373 * window.h (Qwindowp): Move decl back to lisp.h.
2374
9583ec36
EZ
23752013-06-15 Eli Zaretskii <eliz@gnu.org>
2376
2377 * xdisp.c (Fline_pixel_height): New function, required for solving
2378 bug #14567.
2379
210272ce
PE
23802013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2383
de0503df
SM
23842013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2385
2386 * lread.c (syms_of_lread):
2387 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2388
afbfe143
KD
23892013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2390
2391 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2392
d177e213
XF
23932013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2394
2395 * fileio.c (expand_file_name): Doc fix.
2396
05e3e412
PE
23972013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2398
f7394b12
PE
2399 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2400 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2401 Wait for self, not for 0. This can't hurt on GNU or similar
2402 system, and may help with Cygwin.
2403
05e3e412
PE
2404 * keyboard.c: Don't use PROP (...) as an lvalue.
2405 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2406 Use set_prop (A, B), not PROP (A) = B.
2407
17dd3097
EZ
24082013-06-10 Eli Zaretskii <eliz@gnu.org>
2409
2410 * xdisp.c (get_it_property): Use it->window instead of generating
2411 a Lisp object from it->w.
2412
52fab9c9
EZ
24132013-06-09 Eli Zaretskii <eliz@gnu.org>
2414
2415 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2416 get-char-property the window that is being rendered, instead of
2417 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2418 (compute_display_string_pos): When W is NULL, use the current
2419 buffer as the object to pass to get-char-property.
2420 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2421 pointer member of the bidi iterator, since no window is pertinent
2422 to this function.
52fab9c9 2423
5bf97bfc
EZ
24242013-06-08 Eli Zaretskii <eliz@gnu.org>
2425
2426 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2427 being displayed, and pass it to compute_display_string_pos.
2428 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2429 (bidi_paragraph_init): All callers changed.
2430
2431 * xdisp.c (init_from_display_pos, init_iterator)
2432 (handle_single_display_spec, next_overlay_string)
2433 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2434 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2435 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2436 (compute_display_string_pos): Accept additional argument, the
2437 window being displayed, and pass it to Fget_char_property.
2438 (Bug#14575)
2439
2440 * dispextern.h (struct bidi_it): New member w, the window being
2441 displayed.
2442 (compute_display_string_pos): Adjust prototype.
2443
5de0e011
JD
24442013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2445
e7b41c4c 2446 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2447
2448 * process.c (wait_reading_process_output): Check for NS before GLIB.
2449 GLIB may be linked in due to rsvg, but ns_select must be called.
2450
5de0e011
JD
2451 * xgselect.c (xg_select): Remove call to window_system_available
2452 and g_main_context_pending at the top, so Gdk events (i.e. file
2453 notify) are processed when Emacs is started with -nw.
2454
a822acff
EZ
24552013-06-07 Eli Zaretskii <eliz@gnu.org>
2456
2457 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2458 (ctagsfiles3): New variable, includes only *.m files.
2459 (TAGS): Use an explicit language name in the regular expressions,
2460 to avoid transformation of '/SOMETHING' by MSYS to
2461 'c:\MSYS\SOMETHING'.
2462
6c0a9ed1
RC
24632013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2464
2465 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2466
9ef6111b
EZ
24672013-06-06 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2470 still need to set the mouse pointer shape and activate help-echo.
2471 (Bug#14558)
2472
7d300d64
PE
24732013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 A few porting etc. fixes for the new file monitor code.
2476 See the thread containing
2477 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2478 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2479 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2480 (dir_monitor_callback, Fgfile_rm_watch):
2481 Use assq_no_quit instead of Fassoc, for speed.
2482 (dir_monitor_callback, Fgfile_rm_watch):
2483 eassert that the monitor is a fixnum.
2484 (dir_monitor_callback): No need for CDR_SAFE.
2485 Simplify building of lisp with alternative tails.
2486 (Fgfile_add_watch, Fgfile_rm_watch):
2487 Do not assume glib functions set errno reliably on failure.
2488 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2489 and signal an error otherwise.
2490 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2491 Use Fdelq instead of Fdelete, for speed.
2492
817ebfcf
EZ
24932013-06-05 Eli Zaretskii <eliz@gnu.org>
2494
2495 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2496 don't insist on being invoked on a highlighted tool-bar button.
2497 Avoids losing tool-bar functionality when mouse-highlight is nil.
2498 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2499 Don't highlight when mouse-highlight is nil.
2500 (note_mouse_highlight): When mouse-highlight is nil, don't return
2501 right away; instead, run tool-bar and mode-line highlight
2502 subroutine, clear any existing highlight, and revert the mouse
2503 pointer to its default shape. (Bug#14558)
2504
55577e7c
SM
25052013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2506
2507 * lisp.mk (lisp): Add prog-mode.el.
2508
f019a684
PE
25092013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2512 * process.c (dummy_handler): New function.
2513 (lib_child_handler): New static var.
2514 (handle_child_signal): Invoke it.
2515 (catch_child_signal): If a library has set up a signal handler,
2516 save it into lib_child_handler.
2517 (init_process_emacs): If using glib and not on Windows, tickle glib's
2518 child-handling code so that it initializes its private SIGCHLD handler.
2519 * syssignal.h (SA_SIGINFO): Default to 0.
2520 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2521 31; it should no longer be needed now.
2522
90db8702
MA
25232013-06-05 Michael Albinus <michael.albinus@gmx.de>
2524
2525 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2526
2527 * gfilenotify.c (globals_of_gfilenotify): New function.
2528 (syms_of_gfilenotify): Move global initialization there.
2529
2530 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2531
bfa3acd6
SM
25322013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2533
2534 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2535 * keyboard.c (menu_bar_items, tool_bar_items):
2536 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2537 not override local keymaps any more.
2538
ba59bd80
EZ
25392013-06-04 Eli Zaretskii <eliz@gnu.org>
2540
2541 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2542
7f203aa1
EZ
25432013-06-03 Eli Zaretskii <eliz@gnu.org>
2544
9337e206
EZ
2545 * w32console.c (initialize_w32_display): Return the dimensions of
2546 the console window via 2 additional arguments, not via the current
2547 frame. This avoids crashes due to overrunning the bounds of
2548 frame's decode_mode_spec_buffer, which is not resized following
2549 the change of the frame dimensions from the initial 10x10.
2550
2551 * w32term.h (w32_initialize_display_info): Adjust prototype.
2552
2553 * term.c (init_tty): Take dimensions of the frame from the values
2554 returned by initialize_w32_display.
2555
7f203aa1
EZ
2556 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2557 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2558 (LIBES): Add $(GFILENOTIFY_LIBS).
2559
2560 * w32inevt.c (handle_file_notifications): Add dummy implementation
2561 for !HAVE_W32NOTIFY.
2562
2563 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2564
55a87246
JD
25652013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2566
2567 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2568
2569 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2570
2571 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2572
3d5ee10a
PE
25732013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2574
2575 Fix minor problems found by static checking.
2576 * data.c (pure_write_error):
2577 Use xsignal2, not Fsignal, as Fsignal might return.
2578 * eval.c (set_backtrace_debug_on_exit): Now static.
2579 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2580 No longer inline. EXTERN_INLINE is needed only for functions
2581 defined in .h files. Reindent function header as per GNU style.
2582 (backtrace_p, backtrace_top, backtrace_next):
2583 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2584 compiler or linker. Add extern decls to pacify gcc -Wall.
2585 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2586 Now static.
2587 * frame.c (free_monitors): Define only on platforms that need it.
2588 * nsterm.m (ns_term_init):
2589 * process.c (catch_child_signal):
2590 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2591 defined on all porting targets these days.
2592 * process.c, process.h (catch_child_signal):
2593 Make it extern only if NS_IMPL_GNUSTEP is defined.
2594
e2d8a6f0
EZ
25952013-06-03 Eli Zaretskii <eliz@gnu.org>
2596
2597 * w32.c (gettimeofday): Make the signature identical to prototype
2598 in nt/inc/sys/time.h.
2599
a8a7c5f6
SM
26002013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2601
2602 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2603 .gdbinit.
2604
2605 * keyboard.c (safe_run_hooks_error): Improve error message.
2606
2607 * data.c (pure_write_error): Add `object' argument.
2608 * puresize.h (CHECK_IMPURE): Use it.
2609
c9628c79
MA
26102013-06-03 Michael Albinus <michael.albinus@gmx.de>
2611
2612 * Makefile.in (NOTIFY_OBJ): New variable.
2613 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2614
2615 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2616 Call syms_of_gfilenotify.
2617
2618 * gfilenotify.c: New file.
2619
2620 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2621 and Qfile_w32notify.
2622 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2623 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2624
2625 * lisp.h: Declare syms_of_gfilenotify.
2626
2627 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2628
2f592f95
SM
26292013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2630
2631 Merge the specpdl and backtrace stacks. Make the structure of the
2632 specpdl entries more obvious via a tagged union of structs.
2633 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2634 (enum specbind_tag): New enum.
2635 (struct specbinding): Make it a tagged union of structs.
2636 Add a case for backtrace records.
2637 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2638 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2639 (backtrace_debug_on_exit): New accessors.
2640 (struct backtrace): Remove.
2641 (struct catchtag): Remove backlist field.
2642 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2643 Move to eval.c.
2644 (Flocal_variable_p): Speed up the common case where the binding is
2645 already loaded.
2646 * eval.c (backtrace_list): Remove.
2647 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2648 (set_backtrace_args, set_backtrace_nargs)
2649 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2650 (backtrace_next): New functions.
2651 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2652 (unwind_to_catch, internal_lisp_condition_case)
2653 (internal_condition_case, internal_condition_case_1)
2654 (internal_condition_case_2, internal_condition_case_n): Don't bother
2655 with backtrace_list any more.
2656 (Fsignal): Adjust to new backtrace format.
2657 (grow_specpdl): Move up.
2658 (record_in_backtrace): New function.
2659 (eval_sub, Ffuncall): Use it.
2660 (apply_lambda): Adjust to new backtrace format.
2661 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2662 data.c.
2663 (specbind): Adjust to new specpdl format. Simplify.
2664 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2665 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2666 backtrace format.
2667 (mark_backtrace): Remove.
2668 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2669 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2670 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2671 Use mark_specpdl.
2672 * profiler.c (record_backtrace): Use get_backtrace.
2673 (handle_profiler_signal): Use backtrace_top_function.
2674 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2675 accessor functions.
2676
c0342369
JD
26772013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2678
2679 * process.h (catch_child_signal): Declare.
2680
2681 * process.c (catch_child_signal): New function.
2682 (init_process_emacs): Call it.
2683
2684 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2685 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2686 NS_IMPL_COCOA.
2687 (x_set_cursor_type): Remove declaration.
2688 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2689 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2690 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2691 (ns_get_color): Use F suffix on float.
2692 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2693 (ns_get_rgb_color): Remove.
2694 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2695 (note_mouse_movement): x and y are CGFloat.
2696 (ns_draw_fringe_bitmap): Remove unused rowY.
2697 Change #if to COCOA && >= 10_6.
2698 (ns_draw_window_cursor): Remove unused overspill.
2699 (ns_draw_underwave): width and x are EamcsCGFloat.
2700 (ns_draw_box): thickness is CGFloat.
2701 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2702 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2703 if not in main thread.
2704 (ns_get_pending_menu_title, ns_check_menu_open)
2705 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2706 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2707 (sendFromMainThread:): New method.
2708 (changeFont:): size is CGFloat.
2709 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2710 Disable warning about permanent text.
2711 (characterIndexForPoint:): Adjust return type depending on GNUStep
2712 version.
2713 (mouseDown:): delta is CGFloat.
2714 (updateFrameSize): Remove unised variable f.
2715 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2716 Cast float to EmacsCGFloat.
2717 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2718 also to -1 when restoring.
2719 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2720 inside NS_IMPL_COCOA.
2721 (toggleFullScreen:): Put call to toggleFullScreen inside
2722 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2723 (setPosition:portion:whole:): por is CGFloat.
2724 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2725 (mouseDown:): Use CGFloat.
2726 (mouseDragged:): Remove unised variable edge.
2727 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2728
2729 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2730 of CGFloat differs.
2731 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2732 when NS_IMPL_GNUSTEP.
2733 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2734 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2735 (EmacsToolbar): Add clearAll. Add tag argument to
2736 addDisplayItemWithImage.
2737 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2738
2739 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2740
2741 * nsmenu.m (ns_update_menubar): Make static.
2742 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2743 (fillWithWidgetValue:): Add cast to SEL for setAction.
2744 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2745 (update_frame_tool_bar): Update code for GNUStep.
2746 (clearAll): New method.
2747 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2748 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2749 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2750 call to insertItemWithItemIdentifier.
2751 (validateVisibleItems): Fix indentation.
2752 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2753 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2754 UtilityWindow to aStyle, remove call to setStyleMask.
2755
2756 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2757
2758 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2759 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2760 Use F suffix on floats.
2761 (ns_char_width): Returns CGFloat.
2762 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2763 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2764 DPSxshow.
2765 (ns_glyph_metrics): CGFloat instead of float.
2766
a0eb10b3
JB
2767 * nsfns.m (x_set_foreground_color, x_set_background_color):
2768 Use EmacsCGFloat.
2769 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2770 remove unused variables.
2771 (Fns_read_file_name): Keep track if panel is for save.
2772 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2773 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2774 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2775 Just return the input if GNUStep.
c0342369
JD
2776 (x_screen_planes): Remove.
2777 (Fxw_color_values): Use EmacsCGFloat
2778 (Fns_display_monitor_attributes_list): Only get screen number for
2779 Cocoa.
ef099a94 2780 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2781 EmacsSavePanel.
2782 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2783 ns_directory_from_panel.
2784
da9aff11
PE
27852013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 * process.c (handle_child_signal): Also use WCONTINUED.
2788 This is so that list-processes doesn't mistakenly list the process
2789 as stopped, when the process has actually been continued and is
2790 now running.
2791
0e64479a
PE
27922013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2793
fc186a96
PE
2794 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2795 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2796 not already configured.
2797
0e64479a
PE
2798 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2799
38b787fa
EZ
28002013-05-29 Eli Zaretskii <eliz@gnu.org>
2801
2802 * Makefile.in (mostlyclean): Remove *.res files.
2803
22513e52
SM
28042013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2805
2806 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2807 a buffer (bug#8447).
2808
6ef3db10
EZ
28092013-05-27 Eli Zaretskii <eliz@gnu.org>
2810
2811 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2812 display vector, and we backtrack, handle the case that the
2813 previous character position is also displayed from a display
2814 vector or covered by a display string or image. (Bug#14476)
2815
6799bb26
JD
28162013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2817
2818 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2819 (struct MonitorInfo, free_monitors): Remove.
2820 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2821 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2822 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2823 Qframes, Qsource.
2824
2825 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2826 (struct MonitorInfo, free_monitors): Remove.
2827 (ns_screen_name): Make static.
2828 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2829 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2830 Qframes, Qsource.
2831
2832 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2833 (struct MonitorInfo): New struct.
2834 (free_monitors, make_monitor_attribute_list): Declare.
2835
22513e52
SM
2836 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2837 New Lisp_Object:s.
6799bb26
JD
2838 (free_monitors, make_monitor_attribute_list): New functions.
2839 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2840 Qsource.
2841
38cd43eb
XF
28422013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2843
2844 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2845
2af0948d
SM
28462013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2847
a7eb9b0f
SM
2848 * keyboard.c: Apply keyboard decoding only to events that come directly
2849 from the tty, not from unread-command-events (bug#14368).
2850 (read_event_from_main_queue): New function, extracted from read_char).
2851 (read_decoded_char): Remove.
2852 (read_decoded_event_from_main_queue): New function to replace it.
2853 (read_char): Use it.
2854 (read_key_sequence): Use read_char rather than read_decoded_char.
2855
2af0948d
SM
2856 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2857
1413e9a5
BR
28582013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2859
2860 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2861
e6d2f155
KH
28622013-05-22 Kenichi Handa <handa@gnu.org>
2863
2864 The following changes are to fix the setting of
2865 buffer-file-coding-system on, for instance, C-x RET c unix RET
2866 _FILE_OF_DOS_EOL_TYPE_ RET.
2867
2868 * coding.h (struct coding_system): New member detected_utf8_chars.
2869
2870 * coding.c (detect_coding_utf_8): Count characters and check EOL
2871 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2872 BOM is there.
2873 (setup_coding_system): Do not initialize coding->head_ascii.
2874 (check_ascii): Do not set coding->eol_seen but update it. Do not
2875 call adjust_coding_eol_type here.
1413e9a5
BR
2876 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2877 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2878 of the found coding-system.
2879 (decode_coding_gap): Cancel previous change. Utilize the
2880 character numbers counted by detect_coding_utf_8. Fix detection
2881 of BOM for utf-8.
2882
ab56a6f4 28832013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2884
2885 * search.c (looking_at_1): Only set last_thing_searched if the match
2886 changed the match-data (bug#14281).
2887
ecc3c6ed
DA
28882013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2889
2890 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2891 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2892 (move_it_vertically_backward): Likewise.
2893
5ba8bf35
YM
28942013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2895
2896 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2897 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2898 (Fx_display_mm_width, Fx_display_mm_height):
2899 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2900
91e8418b 2901 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2902 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2903 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2904 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2905 (Fx_display_backing_store, Fx_display_visual_class)
2906 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2907 (Fx_display_grayscale_p, Fx_display_pixel_width)
2908 (Fx_display_pixel_height, Fx_display_planes)
2909 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2910 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2911 (Fx_display_mm_width, Fx_display_mm_height)
2912 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2913 height for all physical monitors as in X11.
2914
fc30d803
SM
2915 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2916 Return pixel width or height for all physical monitors as in X11.
91e8418b 2917
31ff141c
PE
29182013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2919
2920 Port --enable-gcc-warnings to clang.
2921 * bytecode.c (exec_byte_code):
2922 * regex.c:
2923 Redo diagnostic pragmas to pacify clang, too.
2924 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2925 * editfns.c (Fencode_time):
2926 * fileio.c (file_accessible_directory_p):
2927 * font.c (font_unparse_xlfd):
2928 Use '&"string"[index]' instead of '"string" + (index)'.
2929 * undo.c (user_error): Remove; unused.
2930
df065a0b
EZ
29312013-05-16 Eli Zaretskii <eliz@gnu.org>
2932
04d360e7
EZ
2933 * insdel.c (insert_1_both): Document the arguments, instead of
2934 referring to insert_1, which no longer exists.
2935
5bb98290
EZ
2936 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2937 some window, increment windows_or_buffers_changed, so that
2938 *Messages* display in that window is updated. (Bug#14408)
2939
df065a0b
EZ
2940 * w32.c: Include epaths.h.
2941 (init_environment): Use cmdproxy.exe without leading directories.
2942 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2943 case.
2944 (gettimeofday): Adjust signature and return value to Posix
2945 expectations.
2946
2947 * unexw32.c (open_output_file): Delete the existing emacs.exe
2948 before creating it, to break the hard link to the versioned
2949 executable.
2950
2951 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2952 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2953 (FIRSTFILE_OBJ): New variables.
2954 (W32_RES): Rename to EMACSRES. All users changed.
2955 (base_obj): Use $(CM_OBJ).
2956 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2957 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2958 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2959 $(W32_RES_LINK) before $(LIBES).
2960 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2961
1aa8d505
SM
29622013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2963
6e911150
SM
2964 * makefile.w32-in (DOC): Use just "DOC".
2965
2966 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2967
1aa8d505
SM
2968 * process.c: Export default filters and sentinels to Elisp.
2969 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2970 New constants.
2971 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2972 (Fset_process_sentinel, Fformat_network_address):
2973 Default to them instead of nil.
2974 (server_accept_connection): Sentinels can't be nil any more.
2975 (read_and_dispose_of_process_output): New function, extracted from
2976 read_process_output.
2977 (read_process_output): Use it; filters can't be nil.
2978 (Finternal_default_process_filter): New function, extracted from
2979 read_process_output.
2980 (exec_sentinel_unwind): Remove function.
2981 (exec_sentinel): Don't zilch sentinel while running.
2982 (status_notify): Sentinels can't be nil.
2983 (Finternal_default_process_sentinel): New function extracted from
2984 status_notify.
2985 (setup_process_coding_systems): Default filter is not nil any more.
2986 (syms_of_process): Export new Elisp functions and initialize
2987 new constants.
2988 * lisp.h (make_lisp_proc): New function.
2989
5ac2eb34
SM
29902013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2991
2992 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2993
eda9c7d7
EZ
29942013-05-14 Eli Zaretskii <eliz@gnu.org>
2995
2996 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2997 unless we know that the window w is a leaf window.
2998 Another attempt at solving bug#14062.
eda9c7d7 2999
8fdeaad5
JD
30002013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3001
3002 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3003 fdesc (Bug#14375).
3004
44aa9ee6
PE
30052013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 * image.c (gif_load): Check that subimages fit (Bug#14345).
3008
759fd763
SM
30092013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3010
3011 * lread.c (skip_dyn_eof): New function.
3012 (read1): Use it to skip the end of a file in response to #@00.
3013
3014 * doc.c (get_doc_string): Slightly relax the sanity checking.
3015
4465bfb4
JD
30162013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3017
3018 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3019 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3020 (MonitorInfo): New struct.
3021 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3022 (Fns_display_monitor_attributes_list): New functions.
3023 (display-usable-bounds): Remove.
3024 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3025 Qsource.
3026
7583e2a0
PE
30272013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3028
3029 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3030 (GTK_CHECK_VERSION): New macro, if not already defined.
3031 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3032 replaced by GTK_CHECK_VERSION.
3033
ad75d77e
PE
30342013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3035
3036 * xterm.h (GTK_PREREQ): New macro.
3037 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3038 to use this macro instead, for consistency and clarity.
3039
07525f77
EZ
30402013-05-08 Eli Zaretskii <eliz@gnu.org>
3041
3042 * xdisp.c (row_for_charpos_p): New function, with code of
3043 cursor_row_p, but accepts an additional argument CHARPOS instead
3044 of using a hardcoded PT.
3045 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3046 (row_containing_pos): Call row_for_charpos_p instead of partially
3047 doing the same. Fixes cursor positioning under longlines-mode
3048 when longlines-show-effect includes more than one newline, when
3049 moving the cursor vertically up.
3050
d901fc8d
JB
30512013-05-08 Juanma Barranquero <lekktu@gmail.com>
3052
3053 * makefile.w32-in (ACL_H): New macro.
3054 ($(BLD)/fileio.$(O)): Update dependencies.
3055
f269bc61
PE
30562013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3057
e7b41c4c 3058 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3059 * Makefile.in (LIB_ACL): New macro.
3060 (LIBACL_LIBS): Remove.
3061 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3062 * fileio.c: Include <acl.h>.
3063 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3064 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3065 !acl_errno_valid.
3066 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3067 it ourselves.
3068
f269bc61
PE
3069 * unexelf.c: Don't assume ElfW (Half) fits in int.
3070 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3071 when dealing with ElfW (Half) values, since they can exceed 2**31
3072 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3073 (entry_address): Omit unused NUM arg. All uses changed.
3074
a261c53e
JL
30752013-05-07 Juri Linkov <juri@jurta.org>
3076
3077 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3078 to the string converted from number with `Fnumber_to_string'.
3079 (Bug#14254)
3080
2b66427d
PE
30812013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3084 This fixes a problem introduced by my previous change.
3085
15acfe41
GM
30862013-05-07 Glenn Morris <rgm@gnu.org>
3087
3088 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3089
5ea03bf5
JD
30902013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3091
3092 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3093
e0c9d565
PE
30942013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 Static checking by GCC 4.8.0.
3097 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3098 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3099 (x_get_monitor_attributes_fallback)
3100 (x_get_monitor_attributes_xinerama)
3101 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3102 Define only if USE_GTK.
3103 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3104 (x_get_monitor_attributes_fallback): Omit unused locals.
3105 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3106 Use double, not float, to avoid mixed-mode floating point arithmetic.
3107
4e3f9230
YM
31082013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3109 Jan Djärv <jan.h.d@swipnet.se>
3110
3111 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3112 (XINERAMA_CFLAGS): New macros.
3113 (ALL_CFLAGS, LIBES): Use them.
3114
3115 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3116 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3117 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3118 (syms_of_xfns): DEFSYM them.
3119 (struct MonitorInfo): New struct.
3120 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3121 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3122 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3123 (x_get_monitor_attributes_xinerama): New functions.
3124 (Fx_display_monitor_attributes_list): New primitive.
3125 (syms_of_xfns): Defsubr it.
3126
3127 * xterm.h (x_display_info): Add Xatom_net_workarea and
3128 Xatom_net_current_desktop.
3129
3130 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3131 and dpyinfo->Xatom_net_current_desktop.
3132
05839b6a
EZ
31332013-05-06 Eli Zaretskii <eliz@gnu.org>
3134
3135 * xdisp.c (pos_visible_p): Use the special code for finding the
3136 beginning of a display property or overlay for any "replacing"
3137 display property, not just for display strings. This solves
3138 incorrect reporting of position by posn-at-point. (Bug#14241)
3139
dc4a2ee0
PE
31402013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3141
5ee94506
PE
3142 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3143 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3144 Verify that ElfW (Half) fits in int.
3145 (fatal): Use same signature as lisp.h.
3146 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3147 configure and build with -DUNEXELF_DEBUG without worrying about
3148 other modules that use DEBUG.
3149 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3150 possibly-wide integers now uses it instead of plain fprintf.
3151 (entry_address): New function, which avoids problems with 32-bit
3152 overflow on 64-bit hosts.
3153 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3154 (round_up): Don't assume the remainder fits in int.
3155 (find_section): Use bool for boolean. Simplify debug code.
3156 (unexec): Don't assume file sizes fit in int or size_t.
3157 Omit unnecessary trailing newline in 'fatal' format.
3158 Use strerror rather than outputting decimal error number.
3159 Remove unused code when emacs is not defined;
3160 this file relies on Emacs now.
3161 Don't assume e_phnum and e_shnum are positive.
3162
dc4a2ee0
PE
3163 * regex.c: Fix problems when DEBUG is defined.
3164 (extract_number, extract_number_and_incr): Define regardless of
3165 whether DEBUG is defined; that's simpler and makes the code less
3166 likely to go stale in the normal case when DEBUG is not defined.
3167 Return int rather than taking an int * arg. All callers changed.
3168 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3169 Remove, replacing with ...
3170 (DEBUG_PRINT): New macro. All callers changed.
3171 (DEBUG_COMPILES_ARGUMENTS): New macro.
3172 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3173 (print_compiled_pattern, print_double_string) [DEBUG]:
3174 Use prototype rather than old-style definition.
3175 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3176 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3177 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3178 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3179 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3180 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3181 This matters only when DEBUG is defined.
3182
14c7ed05
EZ
31832013-05-05 Eli Zaretskii <eliz@gnu.org>
3184
3185 * xdisp.c (set_iterator_to_next): Set the
3186 ignore_overlay_strings_at_pos_p flag only if we are _really_
3187 iterating over an overlay string, as indicated by the
3188 current.overlay_string_index member. (Bug#14306)
3189
e6076b1b
JD
31902013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3191
3192 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3193 to where it is used, to avoid autorelease issues (Bug#14050).
3194
cbee2131
PE
31952013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3196
3197 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3198 * fileio.c (syms_of_fileio): Implement this.
3199 * filelock.c (create_lock_file): If symbolic links don't work, so
3200 we use a regular file as a lock file, do not fsync the lock file;
3201 it's not needed.
3202
30c7e542
SM
32032013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3204
3205 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3206 (syms_of_minibuf): Adjust accodingly.
3207 * lread.c (Fread):
3208 * callint.c (Fcall_interactively): Adjust calls accordingly.
3209
5bebd186
EZ
32102013-05-04 Eli Zaretskii <eliz@gnu.org>
3211
3212 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3213 w->contents is a buffer before computing everything else.
3214 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3215
3216 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3217 assertion violations. (Bug#14062)
3218
0fb0a4f3
DR
32192013-05-01 David Reitter <david.reitter@gmail.com>
3220
3221 * nsfns.m (ns_tooltip): Initialize.
3222
9e63b4a5
EZ
32232013-04-28 Eli Zaretskii <eliz@gnu.org>
3224
3225 * coding.c (decode_coding_gap): Don't remove the character before
3226 a newline unless it's a CR character. (Bug#14287)
3227
ad60824e
DN
32282013-04-28 Dan Nicolaescu <dann@gnu.org>
3229
3230 * dispextern.h (struct face): Move enum face_underline_type
3231 earlier so that bitfields can be in the same word.
3232
edbdcec0
JD
32332013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3234
3235 * nsfns.m (handlePanelKeys): New function.
3236 (EmacsOpenPanel:performKeyEquivalent:)
3237 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3238 arrows/function/control and copy/paste keys (Bug#14296).
3239
0208ede7
JL
32402013-04-27 Juri Linkov <juri@jurta.org>
3241
3242 * callint.c (Fcall_interactively): Call `Qread_number' for
3243 interactive code letter `n' instead of using duplicate code.
3244 (Bug#14254)
3245
b8dd59f7
PE
32462013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 * systime.h (make_timeval): Declare as 'const'.
3249
8bd722db
KH
32502013-04-27 Kenichi Handa <handa@gnu.org>
3251
3252 * font.c (font_open_entity): Always open a font of manageable
3253 size.
3254
13d0e56f 32552013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3256
f780d632
PE
3257 Port better to AIX (Bug#14258).
3258 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3259 to pacify AIX xlc.
3260
ec509856
KH
32612013-04-24 Kenichi Handa <handa@gnu.org>
3262
3263 * coding.c (decode_coding_iso_2022): When an invalid escape
3264 sequence is encountered, reset the invocation and designation
3265 status to the safest one.
3266
84fc48e5
PE
32672013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3268
3269 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3270 Without this fix, "make distclean" leaves stamp-h1 behind.
3271
806bda47
EC
32722013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3273
3274 * w32fns.c (w32_fullscreen_rect): New function to compute the
3275 window rectangle for the given fullscreen mode.
3276 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3277 longer tunes the window size. This keeps the window's edges flush
3278 with the screen and allows the taskbar to hide itself in fullboth.
3279
3280 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3281 window decorations and uses the entire screen.
3282
3283 * w32term.h (w32_fullscreen_rect) Add prototype.
3284 (struct w32_output): Replace normal_width, normal_height,
3285 normal_top, and normal_left members with a single normal_placement
3286 struct.
3287 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3288 Remove macros.
3289 (FRAME_NORMAL_PLACEMENT): New macro.
3290
9cc2810b
JB
32912013-04-16 Juanma Barranquero <lekktu@gmail.com>
3292
3293 * minibuf.c (Ftest_completion): Silence compiler warning.
3294
fd16b54c
EZ
32952013-04-15 Eli Zaretskii <eliz@gnu.org>
3296
3297 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3298 bug#14062.
fd16b54c
EZ
3299
3300 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3301 parentheses.
3302
3303 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3304 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3305 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3306 parentheses where appropriate.
3307
9e3379a0
PE
33082013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3311
ddd6b685
EZ
33122013-04-14 Eli Zaretskii <eliz@gnu.org>
3313
3314 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3315 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3316 Mention in the doc string that setting these variables takes
3317 effect only after a call to set-window-buffer. (Bug#14200)
3318
29b79ba1
EZ
33192013-04-13 Eli Zaretskii <eliz@gnu.org>
3320
3321 * indent.c (Fvertical_motion): Don't consider display strings on
3322 overlay strings as display strings on the buffer position we
3323 started from. This prevents vertical cursor motion from jumping
3324 more than one line when there's an overlay string with a display
3325 property at end of line.
3326 Reported by Karl Chen <Karl.Chen@quarl.org> in
3327 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3328
562c6ee9
SM
33292013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3330
3331 * window.c (select_window): `record_buffer' even if window is
3332 already selected (bug#14191).
3333
fcc1fe85
EZ
33342013-04-11 Eli Zaretskii <eliz@gnu.org>
3335
3336 * window.c (Fwindow_end): Test more flags, including the buffer's
3337 last_overlay_modified flag, to determine whether the window's
3338 display is really up-to-date. Prevents the function from
3339 returning a stale value. (Bug#14170)
3340 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3341 current matrix.
3342
f009190a
EZ
33432013-04-10 Eli Zaretskii <eliz@gnu.org>
3344
3345 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3346 garbaged only if it is not already the top frame on its TTY.
3347 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3348 there are GUI frames open in the same session. (Bug#13864)
3349
78ce603d
SM
33502013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3351
3352 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3353 of marking the idle timers directly.
3354
a8036e40
SM
33552013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3356
3357 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3358 tables (bug#14054).
3359
7ffe7ef6
SM
33602013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3361
3362 * window.c (select_window): Don't record_buffer while the invariant is
3363 temporarily broken (bug#14161).
3364
3365 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3366
7d9f6883
EZ
33672013-04-07 Eli Zaretskii <eliz@gnu.org>
3368
3369 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3370
5406cfd9
RF
33712013-04-07 Romain Francoise <romain@orebokech.com>
3372
3373 Ignore additional platform-specific ACL errors (Bug#13702).
3374 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3375 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3376
95c0e83b
JD
33772013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3378
3379 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3380 f->output_data.ns.
3381
876da980
PE
33822013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3385 This bug was introduced by my 2013-02-25 change that simplified
3386 data_start configuration. Without this change, on GNU/Linux
3387 an Emacs configured with --enable-profiling fails immediately
3388 due to a profiler signal.
3389 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3390 with these flags. On platforms where special flags are needed
3391 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3392 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3393 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3394
7452b7bd
DA
33952013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3396
3397 Get rid of some platform-specific functions examining window
3398 system and its capabilities. This is a partial rework of the
3399 2013-04-05 change.
3400 * lisp.h (have_menus_p): Remove prototype. This function is
3401 replaced with platform-independent window_system_available.
3402 (check_window_system): Move to...
3403 * frame.h (decode_window_system_frame, window_system_available):
3404 ...here, add new prototypes.
3405 * frame.c (window_system_available, decode_window_system_frame):
3406 New functions.
3407 (check_window_system): Platform-independent now.
3408 * xterm.h (x_in_use): Remove declaration.
3409 (check_x_frame):
3410 * w32term.h (check_x_frame):
3411 * nsterm.h (check_x_frame): Remove prototypes. This function
3412 is replaced with platform-independent decode_window_system_frame.
3413 * msdos.c (have_menus_p): Remove.
3414 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3415 Remove platform-specific functions. Use check_window_system,
3416 decode_window_system_frame and check_ns_display_info where
3417 appropriate. Minor style and comment tweaks.
3418 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3419 (check_x_frame): Likewise.
3420 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3421 Likewise.
3422 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3423 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3424 * xmenu.c, xselect.c: All related users changed.
3425
251e9147
KH
34262013-04-03 Kenichi Handa <handa@gnu.org>
3427
3428 The following changes is to optimize the code for reading UTF-8
3429 files.
3430
562c6ee9 3431 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3432 changed. Check EOL format. Do not call adjust_coding_eol_type
3433 here.
3434 (check_utf_8): New function.
3435 (adjust_coding_eol_type): Do nothing if already adjusted.
3436 (detect_coding): Compare the return value of check_ascii with
3437 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3438 (decode_coding_gap): Optimize for valid UTF-8.
3439
8bc369d4
KH
34402013-03-21 Kenichi Handa <handa@gnu.org>
3441
3442 * coding.c (syms_of_coding): Cancel previous change.
3443
3444 * insdel.c (insert_from_gap): Fix previous change.
3445
73931ad1
DA
34462013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3447
3448 Consistently use platform-specific function to detect window system.
3449 * lisp.h (check_window_system): New prototype. This function is
3450 going to replace check_x, check_w32 and check_ns.
3451 (have_menus_p): Mention msdos.c in comment.
3452 * fontset.c (check_window_system_func): Remove. Adjust all users.
3453 * fontset.h (check_window_system_func): Remove prototype.
3454 * nsterm.h (check_ns):
3455 * xterm.h (check_x):
3456 * w32term.h (check_w32): Likewise.
3457 * menu.c (Fx_popup_menu): Use check_window_system.
3458 * msdos.c (check_window_system): Define for MS-DOS.
3459 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3460 * w32fns.c (check_window_system): Likewise for MS-Windows.
3461 * xfns.c (check_window_system): Likewise for X.
3462 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3463 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3464
7216e43b
PE
34652013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3466
3467 Prefer < to > in range checks such as 0 <= i && i < N.
3468 This makes it easier to visualize quantities on a number line.
3469 This patch doesn't apply to all such range checks,
3470 only to the range checks affected by the 2013-03-24 change.
3471 This patch reverts most of the 2013-03-24 change.
3472 * alloc.c (xpalloc, Fgarbage_collect):
3473 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3474 * character.c (string_escape_byte8):
3475 * charset.c (read_hex):
3476 * data.c (cons_to_unsigned):
3477 * dispnew.c (update_frame_1):
3478 * doc.c (Fsubstitute_command_keys):
3479 * doprnt.c (doprnt):
3480 * editfns.c (hi_time, decode_time_components):
3481 * fileio.c (file_offset):
3482 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3483 * font.c (font_intern_prop):
3484 * frame.c (x_set_alpha):
3485 * gtkutil.c (get_utf8_string):
3486 * indent.c (check_display_width):
3487 * keymap.c (Fkey_description):
3488 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3489 * lread.c (read1):
3490 * minibuf.c (read_minibuf_noninteractive):
3491 * process.c (wait_reading_process_output):
3492 * search.c (Freplace_match):
3493 * window.c (get_phys_cursor_glyph):
3494 * xdisp.c (redisplay_internal):
3495 * xsmfns.c (smc_save_yourself_CB):
3496 Prefer < to > for range checks.
3497 * dispnew.c (sit_for): Don't mishandle NaNs.
3498 This fixes a bug introduced in the 2013-03-24 change.
3499 * editfns.c (decode_time_components): Don't hoist comparison.
3500 This fixes another bug introduced in the 2013-03-24 change.
3501
92759988
DA
35022013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3503
3504 * frame.h (struct frame): Drop scroll_bottom_vpos
3505 member becaue all real users are dead long ago.
3506 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3507 * xdisp.c (redisplay_internal): Adjust user.
3508
9a1971bb
GM
35092013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3510
f38ab167
JD
3511 * nsmenu.m (showAtX:Y:for:): setLevel to
3512 NSPopUpMenuWindowLevel (Bug#13998).
3513
6d01f1fe
JD
35142013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3515
3516 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3517 (ns_check_pending_open_menu): Declare.
3518
3519 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3520 (x_activate_menubar): Update the menu with title that matches
3521 ns_get_pending_menu_title, and call
3522 ns_check_pending_openmenu (Bug#12698).
3523 (menuWillOpen:): New method.
3524 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3525
3526 * nsterm.m (menu_will_open_state, menu_mouse_point)
3527 (menu_pending_title): New varaibles.
3528 (ns_get_pending_menu_title, ns_check_menu_open)
3529 (ns_check_pending_open_menu): New functions.
3530
781f4782
DA
35312013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3532
3533 * indent.c (current_column_bol_cache): Remove leftover which is not
3534 used in Fmove_to_column any more.
3535 (current_column, scan_for_column): Adjust users.
3536 * keyboard.c (last_point_position_buffer, last_point_position_window):
3537 Remove leftovers which are not used for recording undo any more.
3538 (command_loop_1, syms_of_keyboard): Adjust users.
3539 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3540 redisplay_window any more.
3541 (move_it_to): Adjust user.
3542
1921c31b
JB
35432013-03-29 Juanma Barranquero <lekktu@gmail.com>
3544
3545 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3546 Update dependencies.
3547
717b8bcd
SM
35482013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3549
3550 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3551 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3552 forward references.
3553
e74aeda8
DA
35542013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3555
3556 * window.h (struct window): Replace hchild, vchild and buffer slots
3557 with the only contents slot. This is possible because each valid
3558 window may have either the child window (in vertical or horizontal
3559 combination) or buffer to display (for the leaf window). Using that,
3560 a lof of operations to traverse and/or change window hierarchies may
3561 be simplified. New member horizontal is used to distinguish between
3562 horizontal and vertical combinations of internal windows.
3563 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3564 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3565 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3566 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3567 Use contents slot, not buffer, where appropriate.
3568 (wset_combination): New function.
3569 (wset_buffer): Add eassert.
3570 (Fframe_first_window): Simplify the loop reaching first window.
3571 (Fwindow_buffer): Use WINDOW_LEAF_P.
3572 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3573 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3574 (unshow_buffer): Convert initial debugging check to eassert.
3575 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3576 (make_parent_window, window_resize_check, window_resize_apply)
3577 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3578 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3579 Adjust to match struct window changes.
3580 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3581 (mark_window_cursors_off, count_windows, get_leaf_windows)
3582 (foreach_window_1): Simplify the loop.
3583 * alloc.c (mark_object): Do not check for the leaf window because
3584 internal windows has no glyph matrices anyway.
3585 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3586 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3587 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3588 (build_frame_matrix_from_window_tree, mirror_make_current)
3589 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3590 (update_window_tree, set_window_update_flags): Simplify the loop.
3591 (sync_window_with_frame_matrix_rows): Enforce live window.
3592 Use contents slot, not buffer, where appropriate.
3593 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3594 and WINDOW_HORIZONTAL_COMBINATION_P.
3595 (make_frame_visible_1): Simplify the loop.
3596 Use contents slot, not buffer, where appropriate.
3597 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3598 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3599 (expose_window_tree): Likewise.
3600 Use contents slot, not buffer, where appropriate.
3601 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3602 to avoid deleted windows. Use contents slot instead of buffer.
3603 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3604 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3605 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3606 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3607
121ab1cd
EZ
36082013-03-28 Eli Zaretskii <eliz@gnu.org>
3609
ef454cf7
EZ
3610 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3611 identify the reasons for assertion violations in bug#14062 and
3612 similar ones.
21e930f8
EZ
3613 (Fx_show_tip): Fix compilation error under
3614 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3615
121ab1cd
EZ
3616 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3617 Reported by <rzl24ozi@gmail.com>.
3618
5c89ca24
DA
36192013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3620
3621 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3622 start marker...
562c6ee9
SM
3623 (unwind_with_echo_area_buffer): ...to restore it here.
3624 This is needed to ensure that...
5c89ca24
DA
3625 (redisplay_window): ...both window markers are valid here,
3626 which is verified by eassert.
3627 * editfns.c (save_excursion_save): Do not assume that
3628 selected_window always displays the buffer.
c7f53895
DA
3629 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3630 Fix comment.
5c89ca24 3631
f557c1b1
SM
36322013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3633
3634 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3635 the upcase table.
3636
40693bba 36372013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3638
3639 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3640
c86f791f
EZ
36412013-03-27 Eli Zaretskii <eliz@gnu.org>
3642
3643 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3644 since MinGW's w32api headers do. This avoids compiler warnings.
3645
3646 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3647 if already defined.
3648
c6e72e17
EZ
36492013-03-26 Eli Zaretskii <eliz@gnu.org>
3650
3651 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3652
54e95010
JD
36532013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3654
3655 * gtkutil.c (style_changed_cb): Check if frame is live and an
3656 X frame (Bug#14038).
3657
b88b62de
EZ
36582013-03-26 Eli Zaretskii <eliz@gnu.org>
3659
a18d7de6
EZ
3660 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3661 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3662 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3663 MinGW64.
8f5e14c8
EZ
3664 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3665 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3666
b88b62de
EZ
3667 Fix incompatibilities between MinGW.org and MinGW64 headers.
3668 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3669
3670 * w32.c (REPARSE_DATA_BUFFER): Guard with
3671 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3672
c074e458
JD
36732013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3674
3675 * xterm.c: Include X11/XKBlib.h
3676 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3677
908589fd
AS
36782013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3679
3680 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3681 written backwards.
3682 * blockinput.h (input_blocked_p): Likewise.
3683 * bytecode.c (exec_byte_code): Likewise.
3684 * callproc.c (call_process_kill, call_process_cleanup)
3685 (Fcall_process): Likewise.
3686 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3687 (Fccl_execute_on_string): Likewise.
3688 * character.c (string_escape_byte8): Likewise.
3689 * charset.c (read_hex): Likewise.
3690 * cm.c (calccost): Likewise.
3691 * data.c (cons_to_unsigned): Likewise.
3692 * dired.c (directory_files_internal, file_name_completion):
3693 Likewise.
3694 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3695 (sit_for): Likewise.
3696 * doc.c (Fsubstitute_command_keys): Likewise.
3697 * doprnt.c (doprnt): Likewise.
3698 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3699 * emacsgtkfixed.c: Likewise.
3700 * fileio.c (file_offset, Fwrite_region): Likewise.
3701 * floatfns.c (Fexpt, fmod_float): Likewise.
3702 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3703 Likewise.
3704 * font.c (font_intern_prop): Likewise.
3705 * frame.c (x_set_alpha): Likewise.
3706 * gtkutil.c (get_utf8_string): Likewise.
3707 * indent.c (check_display_width): Likewise.
3708 * intervals.c (create_root_interval, rotate_right, rotate_left)
3709 (split_interval_right, split_interval_left)
3710 (adjust_intervals_for_insertion, delete_node)
3711 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3712 (merge_interval_right, merge_interval_left, copy_intervals)
3713 (set_intervals_multibyte_1): Likewise.
3714 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3715 * keymap.c (Fkey_description): Likewise.
3716 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3717 * lread.c (openp, read_integer, read1, string_to_number):
3718 Likewise.
3719 * menu.c (ensure_menu_items): Likewise.
3720 * minibuf.c (read_minibuf_noninteractive): Likewise.
3721 * print.c (printchar, strout): Likewise.
3722 * process.c (create_process, Faccept_process_output)
3723 (wait_reading_process_output, read_process_output, send_process)
3724 (wait_reading_process_output): Likewise.
3725 * profiler.c (make_log, handle_profiler_signal): Likewise.
3726 * regex.c (re_exec): Likewise.
3727 * regex.h: Likewise.
3728 * search.c (looking_at_1, Freplace_match): Likewise.
3729 * sysdep.c (get_child_status, procfs_ttyname)
3730 (procfs_get_total_memory): Likewise.
3731 * systime.h (EMACS_TIME_VALID_P): Likewise.
3732 * term.c (dissociate_if_controlling_tty): Likewise.
3733 * window.c (get_phys_cursor_glyph): Likewise.
3734 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3735 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3736 Likewise.
3737 * xfns.c (Fx_window_property): Likewise.
3738 * xmenu.c (set_frame_menubar): Likewise.
3739 * xselect.c (x_get_window_property, x_handle_dnd_message):
3740 Likewise.
3741 * xsmfns.c (smc_save_yourself_CB): Likewise.
3742 * xterm.c (x_scroll_bar_set_handle): Likewise.
3743
2bf7d27a
DA
37442013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3745
3746 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3747 to be optional or nil. Adjust comment and convert it to docstring.
3748 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3749 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3750
a9ebfa0b
PE
37512013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3752
3753 Static checking by GCC 4.8-20130319.
3754 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3755 * process.c (Fset_process_datagram_address)
3756 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3757 * xdisp.c (get_char_face_and_encoding):
3758 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3759 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3760 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3761
4f3576ee
KB
37622013-03-24 Ken Brown <kbrown@cornell.edu>
3763
789b5e9a
KB
3764 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3765 fix compilation on 64-bit Cygwin, where underscores are not
3766 automatically prepended.
3767
4f3576ee
KB
3768 * w32term.c (w32_initialize): Silence compiler warning.
3769
b5b7745f
EZ
37702013-03-23 Eli Zaretskii <eliz@gnu.org>
3771
cdc0d0bd
EZ
3772 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3773 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3774 variables, to save and restore frame dimensions.
3775 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3776 after returning from a 'fullscreen' configuration.
3777 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3778 to avoid races between the main thread and the input thread.
3779
3780 * w32term.h (struct w32_output): New members normal_width,
3781 normal_height, normal_top, normal_left, and prev_fsmode.
3782 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3783 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3784 members of a frame.
3785
b5b7745f
EZ
3786 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3787 'fullscreen' parameter. Always record previous width and height
3788 of the frame, except when switching out of maximized modes, so
3789 that they could be restored correctly, instead of resetting to the
3790 default frame dimensions. Send SC_RESTORE command to the frame,
3791 unless we are going to send SC_MAXIMIZE, to restore the frame
3792 resize hints in the mouse pointer shown by the window manager.
3793 (Bug#14032)
3794
3795 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3796
3797 * lisp.h (get_frame_param): Adjust conditions for prototype
3798 declaration.
3799
a3454eed
KB
38002013-03-22 Ken Brown <kbrown@cornell.edu>
3801
3802 * unexcw.c: Drop unneeded inclusion of w32common.h.
3803 (report_sheap_usage): Declare.
3804 (read_exe_header): Add magic numbers for x86_64.
3805 (fixup_executable): Fix printf format specifier for unsigned long
3806 argument.
3807
5a49b79c
DA
38082013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3809
3810 * frame.h (struct frame): Put menu_bar_window under #ifdef
3811 because this member is not needed when X toolkit is in use.
3812 (fset_menu_bar_window):
3813 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3814 (free_glyphs, update_frame):
3815 * xdisp.c (expose_frame): Likewise.
3816 (display_menu_bar): Likewise. Remove redundant eassert.
3817 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3818 toolkit is in use.
3819
d6723bf7
PE
38202013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3821
7b1123d8
PE
3822 Use functions and constants to manipulate Lisp_Save_Value objects.
3823 This replaces code that used macros and strings and token-pasting.
3824 The change makes the C source a bit easier to follow,
3825 and shrinks the Emacs executable a bit.
3826 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3827 (make_save_value): Change 1st arg from string to enum. All callers
3828 changed.
3829 (INTX): Remove.
3830 (mark_object): Use if, not #if, for GC_MARK_STACK.
3831 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3832 (XSAVE_OBJECT): Now functions, not macros.
3833 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3834 the constant was never used.
3835 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3836 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3837 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3838 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3839 New constants.
3840 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3841 type3 with a single member save_type. All uses changed.
3842 (save_type, set_save_pointer, set_save_integer): New functions.
3843 * print.c (PRINTX): Remove.
3844
d6723bf7
PE
3845 * alloc.c: Remove redundant static declarations.
3846
5f24fa51
DA
38472013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3848
3849 * window.h (struct window): Convert left_col, top_line, total_lines
3850 and total_cols from Lisp_Objects to integers. Adjust comments.
3851 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3852 Remove.
3853 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3854 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3855 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3856 Adjust users where appropriate.
3857
42143acd
DA
38582013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3859
3860 * frame.h (struct frame): Drop resx and resy because the same data is
3861 available from window system-specific output context. Adjust users.
562c6ee9
SM
3862 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3863 New functions to provide defaults when no window system available.
42143acd 3864 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3865 (NUMVAL): Move from xdisp.c.
42143acd
DA
3866 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3867 (Ffont_face_attributes, Fopen_font):
3868 * image.c (gs_load):
3869 * w32font.c (fill_in_logfont):
3870 * xdisp.c (calc_pixel_width_or_height):
3871 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3872 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3873
c0a17406
KH
38742013-03-20 Kenichi Handa <handa@gnu.org>
3875
3876 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3877 to 1 (temporary workaround until a bug related to ASCII
3878 optimization is fixed).
3879
095d384d
DA
38802013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3881
3882 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3883 Signal error if window is not internal. Adjust docstring.
3884 (delete_all_child_windows): Use combination_limit to save the buffer.
3885 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3886 * print.c (syms_of_print): Initialize debugging output not here...
3887 (init_print_once): ...but in a new function here.
3888 * lisp.h (init_print_once): Add prototype.
3889 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3890
748fa866
DA
38912013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3892
3893 * window.c (window_resize_check, window_resize_apply)
3894 (window_from_coordinates, recombine_windows, set_window_buffer)
3895 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3896 (Fsplit_window_internal, Fdelete_window_internal)
3897 (freeze_window_starts): Use bool for booleans.
3898 * window.h (window_frame_coordinates, resize_frame_windows)
3899 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3900
81519fd2
SM
39012013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3902
3903 * dispnew.c (bitch_at_user): Use `user-error'.
3904
6db423a9
KB
39052013-03-17 Ken Brown <kbrown@cornell.edu>
3906
3907 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3908 as return type of image_background. (Bug#13981)
3909 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3910
8f2906f5
JD
39112013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3912
960ce480 3913 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3914 (ns_select): Don't return with result uninitialized.
960ce480 3915
8f2906f5
JD
3916 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3917 and getDirectory.
3918
81519fd2
SM
3919 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3920 New functions.
8f2906f5
JD
3921 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3922 directories. If filename is nil, get directory name (Bug#13932).
3923 Use getFilename and getDirectory.
3924 (getFilename, getDirectory): New methods for EmacsSavePanel and
3925 EmacsOpenPanel.
3926 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3927
cded56c1
PE
39282013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3929
3930 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3931
251e9147 39322013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3933
3934 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3935 (adjust_after_replace): Make it back to static. Delete the third
3936 arg text_at_gap_tail. Cancel the code for handling it.
3937
3938 * coding.h (struct coding_system): New member eol_seen.
3939
3940 * coding.c (detect_ascii): New function.
3941 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3942 when the source bytes are actually scanned. On detecting for
3943 coding_category_utf_8_auto, call detect_ascii instead of scanning
3944 source bytes directly.
3945 (produce_chars): Call insert_from_gap with the new arg 0.
3946 (encode_coding): Likewise.
3947 (decode_coding_gap): Control ASCII optimization by the variable
3948 disable_ascii_optimization instead of #ifndef .. #endif.
3949 Deccode EOL format according to coding->eol_seen.
3950 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3951 variable.
3952
8a44e6d1
KH
3953 * lisp.h (adjust_after_replace): Cancel externing it.
3954 (insert_from_gap): Adjust prototype.
3955
5f795e34
EZ
39562013-03-15 Eli Zaretskii <eliz@gnu.org>
3957
3958 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3959 FULLSCREEN_MAXIMIZED. (Bug#13935)
3960
f258b4be
DA
39612013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3962
3963 * region-cache.c (find_cache_boundary, move_cache_gap)
3964 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3965 Simplify debugging check and convert to eassert. Adjust comment.
3966 (pp_cache): Put under ENABLE_CHECKING.
3967
a5cc4dde
EZ
39682013-03-14 Eli Zaretskii <eliz@gnu.org>
3969
3970 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3971 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3972 and WM_ACTIVATEAPP.
3973 (w32fullscreen_hook): If the frame is visible, reset
3974 f->want_fullscreen flag after changing the frame size. If the
3975 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3976 (Bug#13953)
3977
3fc5e44a
DC
39782013-03-13 Daniel Colascione <dancol@dancol.org>
3979
3980 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3981 too so that these builds can use Cygwin's file conversion
3982 functions. (We've been building and linking cygw32.o all along
3983 and just not using it.)
3984
47d7532e
PE
39852013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3986
3987 File synchronization fixes (Bug#13944).
3988 * Makefile.in (LIB_FDATASYNC): New macro.
3989 (LIBES): Use it.
3990 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3991 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3992 Don't worry about HAVE_FSYNC, since a substitute fsync is
3993 available if the system lacks one.
3994 (Fwrite_regin): Retry fsync if interrupted.
3995
c7ffccaf
EZ
39962013-03-13 Eli Zaretskii <eliz@gnu.org>
3997
4e2df81d 3998 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3999 activated, call w32fullscreen_hook, to make sure the new frame
4000 dimensions are in effect. (Bug#13937)
4001
8a7debc1
DA
40022013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4003
4004 * xdisp.c (init_iterator): Simplify because both character and byte
4005 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4006 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4007 character and byte positions can be obtained from marker.
8a7debc1 4008
7fd8c501
PE
40092013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4010
d9df6f40
PE
4011 Static checking by Sun C 5.12.
4012 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4013 * bytecode.c (exec_byte_code):
4014 * dispnew.c (init_display):
4015 * eval.c (error):
4016 * fileio.c (Fsubstitute_in_file_name):
4017 * keyboard.c (Fevent_convert_list):
4018 * keymap.c (Fsingle_key_description):
4019 * term.c (maybe_fatal, fatal):
4020 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4021 * xsmfns.c (Fhandle_save_session):
4022 Omit unreachable code.
4023 * keymap.c (map_keymap_char_table_item): Cast void * to
4024 a function pointer type; the C Standard requires this.
4025
7fd8c501
PE
4026 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4027 Include <sys/param.h> unconditionally, as that works elsewhere and
4028 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4029 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4030 and FreeBSD now.
4031
a020afb9 4032See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4033
4034;; Local Variables:
4035;; coding: utf-8
aac0c6e3
MR
4036;; End:
4037
ab422c4d 4038 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4039
4040 This file is part of GNU Emacs.
4041
4042 GNU Emacs is free software: you can redistribute it and/or modify
4043 it under the terms of the GNU General Public License as published by
4044 the Free Software Foundation, either version 3 of the License, or
4045 (at your option) any later version.
4046
4047 GNU Emacs is distributed in the hope that it will be useful,
4048 but WITHOUT ANY WARRANTY; without even the implied warranty of
4049 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4050 GNU General Public License for more details.
4051
4052 You should have received a copy of the GNU General Public License
4053 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.