Do not copy X event in handle_one_xevent except KeyPress case.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
61582e6a
DA
12013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Do not copy X event in handle_one_xevent except KeyPress case.
4 Wnen XEvent is processed, it is unlikely to be changed except
5 KeyPress case, so we can avoid copying and use const pointer to
6 const data to make sure that an event is not changed elsewhere.
7 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
8 const' and do not create local copy except for the KeyPress event.
9 Use casts to avoid a few glitches. Adjust formatting. Add comments.
10 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
11 (x_handle_net_wm_state, x_menubar_window_to_frame)
12 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
13 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
14 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
15 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
16 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
17 (x_handle_dnd_message):
18 * xsettings.c (xft_settings_event):
19 Use 'const XEvent * const' where appropriate.
20 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
21
f8eb1572
DA
222013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
23
24 Fix X event waiting to handle multiple frames.
25 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
26 * xterm.c (pending_event_wait): Remove. Adjust users.
27 (x_detect_focus_change): Pass frame arg.
28 (handle_one_xevent): Find related frame early and clear per-frame
29 wait_event_type only if this is an event for the relevant frame.
30 (x_wait_for_event): Use per-frame wait_event_type.
31
3fa2054e
JD
322013-09-15 Jan Djärv <jan.h.d@swipnet.se>
33
745d3809
JD
34 * nsfns.m (Fx_create_frame): Fix font driver registration for
35 GNUStep.
36
37 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
38 for syms_of_macfont.
39
3fa2054e
JD
40 * nsterm.m: Include macfont.h.
41 (ns_tmp_flags, ns_tmp_font): Remove.
42 (ns_compute_glyph_string_overhangs): Check for driver Qns.
43 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
44 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
45 (changeFont:): Fix code style. Check for font driver type when
46 getiing font.
47
48 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
49 (f)->descent.
50
51 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
52 (nsfont_open): Set font driver type.
53 Set font->ascent and font->descent. Figure out font instead of
54 ns_tmp_font, and flags instead of ns_tmp_flags.
55 Fix indentation. Remove call to ns_draw_text_decoration,
56 moved to nsterm.
57
58 * nsfns.m: Include macfont.h.
59 (Fx_create_frame): Register macfont driver, make a better default font.
60 (Fns_popup_font_panel): Get font from macfont driver, if used.
61
62 * macfont.m, macfont.h, maccuvs.h: New files.
63
64 * font.h: Declare syms_of_macfont.
65
66 * font.c (syms_of_font): Call syms_of_macfont.
67
68 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
69
0eed0355
DA
702013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
71
72 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
73 and it is always zero for others, so I assume that this is an ancient
74 leftover which nobody will want to change any more.
75 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
76 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
77 * frame.c (x_set_scroll_bar_width):
78 * w32fns.c (w32_createscrollbar):
79 * w32term.c (w32_set_vertical_scroll_bar):
80 * xfns.c (x_set_scroll_bar_default_width):
81 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
82 (x_scroll_bar_expose): Related users changed.
83
07013c68
DA
842013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
85
86 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
87 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
88 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
89 Define as such.
c7cc32f7
DA
90 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
91 Define once here...
92 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
93 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
94 Remove unused Xisms.
7f09455e
DA
95 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
96 these modules are never compiled otherwise.
07013c68 97
0df00f59
EZ
982013-09-14 Eli Zaretskii <eliz@gnu.org>
99
08a209bf 100 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
101 Doc fix. (Bug#15375)
102
fcd42c11
DA
1032013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
104
105 Unify Fx_focus_frame between all ports.
106 * frame.h (x_focus_frame): New prototype.
107 * xfns.c (Fx_focus_frame): Remove.
108 (syms_of_xfns): Do not defsubr it.
109 (x_focus_frame): X implementation.
110 * nsfns.m (Fx_focus_frame): Remove.
111 (syms_of_nsfns): Do not defsubr it.
112 (x_focus_frame): NS implementation.
113 * w32term.c (Fx_focus_frame): Remove.
114 (x_focus_on_frame): Rename to...
115 (x_focus_frame): W32 implementation.
116 * w32term.h (x_focus_on_frame): Remove prototype.
117 * w32fns.c (Fx_focus_frame): Remove.
118 (syms_of_w32fns): Do not defsubr it.
119 * frame.c (Fx_focus_frame): Define here.
120 (syms_of_frame): Defsubr here.
121 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
122
aad3612f
DA
1232013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
124
125 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
126 All of them are replaced with FRAME_DISPLAY_INFO, defined in
127 each port to reference the port-specific window system data.
128 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
129 (FRAME_DISPLAY_INFO): Define.
130 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
131 (FRAME_DISPLAY_INFO): Define. Adjust users.
132 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
133 (FRAME_DISPLAY_INFO): Define. Adjust users.
134 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
135 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
136 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
137 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
138 * xselect.c, xterm.c: All related users changed.
139
9a650e62
DA
1402013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
141
142 * xterm.h (x_window_to_frame, x_any_window_to_frame)
143 (x_menubar_window_to_frame): Remove prototypes.
144 * xfns.c (x_window_to_frame, x_any_window_to_frame)
145 (x_menubar_window_to_frame, x_top_window_to_frame):
146 Move from here...
147 * xterm.c (x_window_to_frame, x_any_window_to_frame)
148 (x_menubar_window_to_frame, x_top_window_to_frame):
149 ...to here and convert all but the last to static.
150
347ae3e1
EZ
1512013-09-12 Eli Zaretskii <eliz@gnu.org>
152
153 * lisp.mk (lisp): Add w32-common-fns.elc.
154
15c6d837
XF
1552013-09-12 Xue Fuqiao <xfq.free@gmail.com>
156
157 * charset.c (char_charset): Document an exception for char-charset.
158
27e90f77
DA
1592013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
160
161 * xterm.h (x_display_info): New field last_user_time...
162 * xterm.c (toplevel): ...to replace static last_user_time.
163 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
164
8ffbc36b
DA
1652013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
166
167 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
168 scroll bar values to prevent thumb from disappear and update comment.
169
5ec0337a
GM
1702013-09-11 Glenn Morris <rgm@gnu.org>
171
172 * emacs.c (usage_message): Possessive apostrophe tweak.
173
fb55b9d1
DA
1742013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
175
8d2db8be
DA
176 * nsterm.m (syms_of_nsterm): Use Qns.
177 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
178 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
179 * xfns.c (x_display_info_for_name, Fx_open_connection):
180 Remove old '#if 0' code.
181 (syms_of_xfns): Use Qx.
fb55b9d1
DA
182 * termhooks.h (fullscreen_hook): Remove the leftover.
183 (struct terminal): Fix typo in comment.
184
927eec55
DA
1852013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
186
187 Cleaning up a few X scroll bar bits.
188 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
189 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
190 New member last_seen_part, going to replace...
191 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
192 (xt_action_hook) [USE_LUCID]: Adjust user.
193 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
194 Lucid-specific scroll bar support.
195 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
196 to int and adjust to use last_seen_part member.
197 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
198 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
199 Initialize last_seen_part.
200
71b28baa
SM
2012013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
202
203 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
204 insert-buffer-substring an empty string.
205
f5dacaae
PE
2062013-09-11 Paul Eggert <eggert@cs.ucla.edu>
207
208 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
209 avoiding a GCC warning.
210
742516e0
DA
2112013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
212
213 Ifdef away frame tool bar code when it is not really used.
214 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
215 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
216 and minimize_tool_bar_window_p under the above.
217 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
218 (fset_tool_bar_window): Likewise.
219 * dispnew.c (clear_current_matrices, clear_desired_matrices)
220 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
221 (change_frame_size_1):
222 * window.c (window_from_coordinates, Frecenter): Adjust users.
223 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
224 code is not really used.
225 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
226 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
227 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
228 [!USE_GTK && !HAVE_NS]: Define as such.
229 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
230 (note_mouse_highlight, expose_frame):
231 * xfns.c (x_set_tool_bar_lines):
232 * xterm.c (handle_one_xevent): Adjust users.
233
73f82c7e
PE
2342013-09-11 Paul Eggert <eggert@cs.ucla.edu>
235
236 Fix corruption with multiple emacsclient -t instances (Bug#15222).
237 This bug was introduced by my 2013-08-26 patch, which incorrectly
238 assumed that the terminfo implementation doesn't use termcap buffers.
239 * term.c (init_tty) [TERMINFO]: Remove optimization, as
240 these buffers apparently are used after all.
241 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
242 (struct tty_display_info): Define members termcap_term_buffer and
243 termcap_strings_buffer even if TERMINFO.
244
53482f41
DA
2452013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
246
247 Fix last change.
248 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
249 'usage' docstring entry to pacify make-docfile.
250
2512013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
252
253 Change comparison functions =, <, >, <=, >= to take many arguments.
254 * data.c: Change comparison functions' interface and implementation.
255 * lisp.h: Make arithcompare available for efficient two arg
256 comparisons.
257 * bytecode.c: Use arithcompare.
258 * fileio.c: Use new interface.
259
533f258f
SM
2602013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
261
262 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
263
8c27f5ff
SM
2642013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
265
266 * eval.c (Feval): Document the new use of `lexical'.
267
0750a308
DA
2682013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
269
270 Review and drop old frame resize hack.
271 * frame.h (struct frame): Remove force_flush_display_p.
272 * dispnew.c (update_frame): Adjust user and don't call
273 flush_frame here. The comment has said that there was an issues
274 with redisplaying fringes, but I don't see any differences with
275 and without this hack. Hopefully we can continue without it.
276 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
277 current frame matrices twice if resized_p is set.
278
83fc0554
DA
2792013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
280
281 Do not populate pure Xism x_sync to other ports.
282 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
283 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
284 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
285 * w32term.h (x_sync): Remove prototype.
286
fd462129
DA
2872013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Cleanup frame flushing.
8c27f5ff
SM
290 * dispextern.h (struct redisplay_interface):
291 Drop flush_display_optional because flush_display is enough
fd462129
DA
292 for X and flushing via RIF is just a no-op for others.
293 * frame.h (flush_frame): New function.
294 * dispnew.c (update_frame):
295 * minibuf.c (read_minibuf):
296 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
297 Use it.
298 * keyboard.c (detect_input_pending_run_timers): Do not flush
299 all frames but selected one in redisplay_preserve_echo_area.
300 * nsterm.m (ns_flush): Remove no-op.
301 (ns_redisplay_interface): Adjust user.
302 * w32term.h (x_flush): Remove no-op.
303 (w32_redisplay_interface): Adjust user.
304 * xterm.c (x_flush): Simplify because we do not flush all
305 frames at once any more. Adjust comment.
306 (x_redisplay_interface): Adjust user.
307
4b73fc73
PE
3082013-09-07 Paul Eggert <eggert@cs.ucla.edu>
309
310 Port --without-x --enable-gcc-warnings to Fedora 19.
311 * gfilenotify.c (globals_of_gfilenotify):
312 Call g_type_init only if using an older glib version that needs it.
313
77394d40
DA
3142013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
315
316 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
317 (last_glyphless_glyph_merged_face_id): Remove declarations.
318 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
319 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
320 (last_glyphless_glyph_merged_face_id): Now static.
321 (merge_escape_glyph_face): New function, refactored from...
322 (get_next_display_element): ...here.
323 (merge_glyphless_glyph_face): New function, refactored from...
324 (produce_glyphless_glyph): ...here...
325 * term.c (produce_glyphless_glyph): ...and here.
326
306d67bd
SM
3272013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
328
329 * eval.c (eval_sub): Only call Ffunction if necessary.
330
7f6c6450
DA
3312013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
332
333 Attempt to make redisplay more selective when changing cursor type.
334 * frame.h (struct frame): New bitfield cursor_type_changed.
335 * xdisp.c (cursor_type_changed): Remove.
336 (try_cursor_movement, redisplay_window, try_window_id)
337 (set_frame_cursor_types, try_window_reusing_current_matrix):
338 Adjust to use per-frame bitfield.
339 (redisplay_internal): Look for cursor type change on each visible
340 frame and consider all frames if cursor type has been changed on
341 the frame other than selected. If cursor type has been changed on
342 selected frame only, do not use fast update.
343
bd0443bb
DA
3442013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Attempt to make redisplay more selective when changing fonts.
347 * frame.h (struct frame): New bitfield fonts_changed.
348 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
349 (adjust_frame_glyphs): Add prototype.
350 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 351 (adjust_glyphs): Remove because we do not
bd0443bb
DA
352 adjust matrices on all frames at once any more.
353 (adjust_frame_glyphs): Block and unblock input here.
354 (adjust_glyph_matrix): Use fonts_changed.
355 (change_frame_size_1): Use adjust_frame_glyphs.
356 * font.c (font_open_entity): Use fonts_changed.
357 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
358 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
359 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
360 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
361 (shrink_mini_window, Fresize_mini_window_internal)
362 (window_scroll_pixel_based, Fset_window_configuration)
363 (apply_window_adjustment, Fset_window_vscroll):
364 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
365 Use adjust_frame_glyphs.
366 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
367 (try_window_reusing_current_matrix, try_window_id, display_line)
368 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
369 (redisplay_internal): Consider fonts_changed and adjust frame
370 matrices for each frame only if the frame is visible. If font
371 has been changed on some frame during full redisplay, retry
372 only visible frames where the font has been actually changed.
373
b9695828
DA
3742013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
375
376 Cache current header and mode line height for each window.
377 * window.h (struct window): New fields mode_line_height
378 and header_line_height.
379 * window.c (make_window): Initialize them.
380 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
381 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
382 (current_mode_line_height, current_header_line_height):
383 Remove declaration.
384 * xdisp.c (current_mode_line_height, current_header_line_height):
385 Remove.
386 (pos_visible_p, init_xdisp): Adjust user.
387 (redisplay_window): Invalidate mode_line_height and
388 header_line_height if current and desired matrices do not agree.
389
66738305
DA
3902013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
391
392 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
393 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
394
257b3b03
DA
3952013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
396
397 Make --without-x compatible with --enable-gcc-warnings.
398 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
399 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
400 members under HAVE_WINDOW_SYSTEM.
401 * keyboard.c (make_lispy_focus_out): Likewise.
402 (record_menu_key): Move under HAVE_MENUS.
403 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
404 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
405 (syms_of_xdisp): Adjust user.
406 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
407 (start_hourglass, cancel_hourglass):
408 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
409 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
410 and CLEAR_FONT_TABLE_NFONTS.
411 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
412 Declare only if HAVE_WINDOW_SYSTEM.
413 (lface_same_font_attributes_p, clear_face_gcs): Define only
414 if HAVE_WINDOW_SYSTEM.
415
98b7f4bd
DA
4162013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
417
418 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
419 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
420 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
421
a7e43722
SM
4222013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
423
424 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
425
0c90b9ee
PE
4262013-09-04 Paul Eggert <eggert@cs.ucla.edu>
427
428 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
429 This fixes a type error on hosts where ptrdiff_t is wider than int.
430
d99760fa
SM
4312013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
432
6629638e
SM
433 * keyboard.c (read_key_sequence_vs): New function.
434 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
435 common code.
436
d99760fa
SM
437 * callint.c (Fcall_interactively): Always return a vector for 'K'.
438
224e313d
PE
4392013-09-04 Paul Eggert <eggert@cs.ucla.edu>
440
441 Makefile improvements.
442 * Makefile.in (config.status): Don't use double-colon rules, as
443 they are not portable according to POSIX. Fix shell typo with `;
444 I guess this rule has never been tested?
445 (VCSWITNESS): New macro, to override any environment var.
446
6d6ed1af
DA
4472013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
448
449 * xterm.h (struct x_display_info): Do not track X connection
450 fd separately because it is always available from Display.
451 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
452 Adjust users.
453
bc923770
DA
4542013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
455
456 * buffer.c (drop_overlay):
457 * fileio.c (restore_point_unwind): Prefer unchain_marker to
458 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
459
b1cf96de
DA
4602013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
461
462 * buffer.c (Fmake_overlay, Fmove_overlay):
463 * intervals.c (set_point_from_marker):
464 * print.c (PRINTPREPARE): Prefer signal_error
465 to plain error and report unsuitable marker too.
466
d1fc6c21
DA
4672013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
468
469 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
470 for 'dragging' member.
d1ae6a0b
DA
471 (struct x_output): Remove set-but-unused leftovers
472 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
473 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
474 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
475 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
476 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
477 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
478 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 479 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 480 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 481
0ce9f6de
JD
4822013-09-03 Jan Djärv <jan.h.d@swipnet.se>
483
484 * nsfont.m (INVALID_GLYPH): New define.
485 (nsfont_encode_char): Use INVALID_GLYPH.
486 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
487
b594a96c
DA
4882013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
489
490 * xterm.c (x_last_mouse_movement_time): Revert last change.
491 This code should use XDisplayMotionBufferSize to check display's
492 motion history first, and there are few other issues as well.
493 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
494 (handle_one_xevent): Adjust user.
495
8b098236
MR
4962013-09-02 Martin Rudalics <rudalics@gmx.at>
497
9718b207
MR
498 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
499 * frame.c (Flast_nonminibuf_frame): ... to here.
500 (check_minibuf_window): Don't abort if no window was found
501 (Bug#15247).
8b098236 502
84e70bba
DA
5032013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
504
505 Use XGetMotionEvents to ask the last mouse motion time from X server.
506 * xterm.c (X_MOTION_HISTORY): Default to 1.
507 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
508 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
509 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
510 Ifdef away legacy code.
511 (XTmouse_position, x_scroll_bar_report_motion):
512 Use x_last_mouse_movement_time.
fc85e20b
DA
513 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
514 UnmapNotify event.
84e70bba 515
1fccc530
DA
5162013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
517
518 * msdos.c (last_mouse_window): Move to...
519 (dos_rawgetc): ...this function and adjust comment.
520 * nsterm.m (last_window): Rename to last_mouse_window, move to...
521 (mouseMoved): ...this function and adjust comment.
522 * w32term.c (last_window): Likewise with...
523 (w32_read_socket): ...this function.
524 * xterm.c (last_window): Likewise with...
525 (handle_one_xevent): ...this function.
526
0ab10992
DA
5272013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
528
b7da754d 529 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
530 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
531 (handle_one_xevent): ...to here.
532 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
533 otherwise.
534
0c7f856e
DA
5352013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
536
537 * msdos.c (IT_set_terminal_window): Remove no-op.
538 (initialize_msdos_display): Adjust terminal setup.
539 * w32console.c (w32con_set_terminal_window): Remove no-op.
540 (initialize_w32_display): Adjust terminal setup.
541 * w32term.c (w32_set_terminal_window): Remove no-op.
542 (w32_create_terminal): Adjust terminal setup.
543 * xterm.c (XTset_terminal_window): Remove no-op.
544 (x_create_terminal): Adjust terminal setup.
545
a892a94c
DA
5462013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
547
548 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
549 Remove no-ops.
550 (ns_create_terminal): Adjust terminal setup.
551 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
552 Remove no-ops.
553 (w32_create_terminal): Adjust terminal setup.
554 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
555 Remove no-ops.
556 (x_create_terminal): Adjust terminal setup.
557
cf91889a
DA
5582013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
559
560 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
561 (CLIP_TEXT_POS_FROM_MARKER): New macro.
562 * dispnew.c (buffer_posn_from_coords):
563 * window.c (Fwindow_end, displayed_window_lines):
564 * xdisp.c (redisplay_mode_lines): Use it.
565
5b0891df
JD
5662013-09-01 Jan Djärv <jan.h.d@swipnet.se>
567
568 * fontset.c (face_for_char): Check char in the current face font first
569 if HAVE_NS (Bug#15138).
570
0a357e98
MR
5712013-08-31 Martin Rudalics <rudalics@gmx.at>
572
573 * window.c (temp_output_buffer_show): Make sure window returned
574 by display_buffer is live (Bug#15213).
575
9d7693d7
DA
5762013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
577
578 Minor cleanup to avoid forward declarations.
579 * coding.h (struct ccl_spec): Remove forward declaration.
580 * composite.h (toplevel): Include font.h.
581 (struct composition_it, struct face, struct font_metrics):
582 Remove forward declaration.
583 * dispextern.h (struct image, struct atimer): Likewise.
584 * emacsgtkfixed.h (struct frame): Likewise.
585 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
586 * font.h (struct font_driver, struct font, struct glyph_string)
587 (struct face): Remove forward declaration.
588 * fontset.h (struct face, struct font): Likewise.
589 * frame.h (toplevel): Style cleanup.
590 (enum output_method): Move to...
591 * termhooks.h (enum output_method): ...here.
592 (struct glyph, struct frame, struct ns_display_info)
593 (struct x_display_info, struct w32_display_info):
594 Remove forward declaration.
595 * xterm.h (toplevel): Include termhooks.h.
596 (struct font, struct window, struct glyph_matrix, struct frame)
597 (struct input_event, struct face, struct image): Remove forward
598 declaration.
599 * gtkutil.h (struct _widget_value): Likewise.
600 * keyboard.h (toplevel): Include termhooks.h.
601 (struct input_event): Remove forward declaration.
602
032f7451
DA
6032013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
604
605 * intervals.c (set_point_from_marker): New function.
606 * editfns.c (Fgoto_char):
607 * process.c (Finternal_default_process_filter):
608 * window.c (select_window_1): Use it.
609 * buffer.h (set_point_from_marker): Add prototype.
610
3f940c5a
EZ
6112013-08-29 Eli Zaretskii <eliz@gnu.org>
612
613 * w32.c (term_winsock): Call release_listen_threads before calling
614 WSACleanup.
615 (_sys_wait_accept): Wait for accept event in a loop with a finite
616 timeout, instead of waiting indefinitely. Will hopefully avoid
617 hanging during exit because WSACleanup deadlocks waiting for the
618 event object to be released. (Bug#14333)
619
620 * w32proc.c (release_listen_threads): New function, signals all
621 the reader threads that listen for connections to stop waiting.
622
623 * w32.h (release_listen_threads): Add prototype.
624
101ed2bb
DA
6252013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
626
627 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
628 field of new marker (for sanity and safety).
20de2834
DA
629 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
630 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 631
1f5cf200
DA
6322013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
633
634 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
635 (x_after_update_window_line, x_scroll_bar_create):
636 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
637 (handle_one_xevent, x_clear_frame_area):
638 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
639 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
640 * xterm.h (x_clear_area): Adjust prototype.
641
d2b36813
DA
6422013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
643
644 Hook scanning and indentation functions to find_newline. This helps
645 to avoid duplicated code and renders more respect to newline cache.
646 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
647 * cmds.c (Fforward_line):
648 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
649 Use find_newline and avoid unnecessary point movements.
650 * search.c (scan_newline): Implement on top of find_newline.
651
3ec7babc
SM
6522013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
653
654 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
655 scoped code (bug#11258).
656
5ab473cd
JD
6572013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
658
659 * nsterm.m (last_window): New variable.
660 (EV_TRAILER2): New macro.
661 (EV_TRAILER): Call EV_TRAILER2.
662 (mouseMoved:): Add support for mouse-autoselect-window
663 on nextstep (Bug#6888).
664
78779650
AS
6652013-08-28 Andreas Schwab <schwab@suse.de>
666
667 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
668 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
669 Remove unused macro definitions.
670 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
671 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
672 Only define if emacs.
78779650 673
c3c4768d
DA
6742013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
675
676 Prefer enum glyph_row_area to int where appropriate.
677 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
678 Fix comment.
679 (window_box, window_box_width, window_box_left, window_box_left_offset)
680 (window_box_right, window_box_right_offset): Adjust prototypes.
681 * xdisp.c (window_box, window_box_width, window_box_left)
682 (window_box_left_offset, window_box_right, window_box_right_offset):
683 Use enum glyph_row_area. Adjust users and tweak comment where needed.
684 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
685 * nsterm.m (ns_clip_to_row):
686 * w32term.c (w32_clip_to_row):
687 * xterm.c (x_clip_to_row): Likewise.
688
6bdcbfe1
DA
6892013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
690
691 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
692 (Fprevious_overlay_change): Fast path for buffer with no overlays.
693
50b13cde
PE
6942013-08-28 Paul Eggert <eggert@cs.ucla.edu>
695
696 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
697 for portability to hosts where /bin/sh has problems.
698
f60e429a
DA
6992013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
700
701 Redesign redisplay interface to drop global output_cursor.
702 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
703 (toplevel): Remove declaration of output_cursor.
704 (set_output_cursor, x_cursor_to): Remove prototype.
705 * window.h (struct window): New member output_cursor.
706 (output_cursor_to): New function to replace RIF member.
707 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
708 (update_text_area, set_window_cursor_after_update): Use it.
709 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
710 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
711 * nsterm.m (ns_update_window_begin, ns_update_window_end):
712 * w32term.c (x_update_window_begin, x_update_window_end):
713 * xterm.c (x_update_window_begin, x_update_window_end):
714 Adjust to use per-window output cursor.
715
43aac990
PE
7162013-08-27 Paul Eggert <eggert@cs.ucla.edu>
717
d486344e
PE
718 Simplify SELECT_TYPE-related code.
719 Like EMACS_TIME, this portability layer is no longer needed, since
720 Emacs has been using fd_set as a portability layer for some time.
721 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
722 (SELECT_TYPE): Remove. All uses changed to fd_set.
723 (fd_set) [!FD_SET]: New typedef.
724
43aac990
PE
725 Simplify EMACS_TIME-related code.
726 This portability layer is no longer needed, since Emacs has been
727 using struct timespec as a portability layer for some time.
728 * atimer.h, buffer.h, dispextern.h, xgselect.h:
729 Include <time.h> rather than "systime.h"; that's all that's needed now.
730 * dispnew.c: Include <timespec.h> rather than "systime.h";
731 that's all that's needed now.
732 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
733 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
734 TIMESPEC_RESOLUTION.
735 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
736 LOG10_TIMESPEC_RESOLUTION.
737 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
738 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
739 (make_emacs_time): Remove. All used changed to make_timespec.
740 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
741 (current_timespec): Rename from current_emacs_time. All uses changed.
742 (add_emacs_time): Remove. All uses changed to timespec_add.
743 (sub_emacs_time): Remove. All uses change dot timespec_sub.
744 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
745 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
746 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
747 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
748 (current_timespec): Rename from current_emacs_time. All uses changed.
749 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
750 changed to timespec_cmp.
751 * xgselect.c: Include <timespec.h>, since our .h files don't.
752
d350e350
DA
7532013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
754
755 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
756 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
757 Remove the leftovers.
758 * gtkutil.c (toplevel): Do not declare Qxft but include
759 font.h to do so.
760 * image.c (toplevel): Do not declare Vlibrary_cache because
761 it's already done in lisp.h.
762
9fed9729
DA
7632013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
764
765 * lisp.h (Mouse_HLInfo): Move from here...
766 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
767 (reset_mouse_highlight): New function.
768 * msdos.c (dos_set_window_size, IT_update_begin)
769 (internal_terminal_init):
770 * nsterm.m (ns_update_window_end, x_free_frame_resources)
771 (ns_initialize_display_info):
772 * w32console.c (initialize_w32_display):
773 * w32term.c (x_update_window_end, x_free_frame_resources)
774 (w32_initialize_display_info):
775 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
776 * window.c (Fdelete_other_windows_internal):
777 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
778 * termchar.h (toplevel):
779 * xterm.h (toplevel): Include dispextern.h.
780
f462f075
PE
7812013-08-26 Paul Eggert <eggert@cs.ucla.edu>
782
783 Fix minor problems found by static checking.
784 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
785 (expect): Avoid nested-if warning.
786 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
787 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
788 * nsterm.h, nsterm.m (ns_select):
789 * xgselect.c, xgselect.h (xg_select):
790 Adjust signature to better match pselect's.
791 * nsterm.m (ns_select):
792 Don't set *TIMEOUT, since pselect doesn't.
793 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
794 diagnostic about assigning const char * to it.
795 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
796
068f9124
SM
7972013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
798
799 * lread.c (substitute_object_recurse): Handle hash-tables as well
800 (bug#15190).
801
f5adc984
PE
8022013-08-26 Paul Eggert <eggert@cs.ucla.edu>
803
1fc8eb33
PE
804 Fix unlikely core dump in init_tty, and simplify terminfo case.
805 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
806 The old version incorrectly dumped core if malloc returned a
807 buffer containing only non-NUL bytes.
808 (init_tty): Do not allocate or free termcap buffers; the
809 struct does that for us now.
810 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
811 (struct tty_display_info): Define members termcap_term_buffer and
812 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
813 use them. Allocate them directly in struct rather than indirectly
814 via a pointer, to simplify init_tty.
815
f5adc984
PE
816 * frame.c (check_minibuf_window): Initialize 'window' properly,
817 so that Emacs reliably aborts later if 'window' is not initialized.
818
efec3894
JD
8192013-08-26 Jan Djärv <jan.h.d@swipnet.se>
820
821 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
822 of VoidSymbol (Bug#15154).
823
e1d0341e
DA
8242013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
825
826 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
827 mouse_face_beg_y and mouse_face_end_y.
828 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
829 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
830 Adjust users and update comment where appropriate.
831
bfff6445
MR
8322013-08-26 Martin Rudalics <rudalics@gmx.at>
833
834 * frame.c (check_minibuf_window): New function.
068f9124
SM
835 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
836 Call check_minibuf_window (Bug#15183).
bfff6445 837
c80016b3
DA
8382013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
839
840 * window.h (struct window): Replace last_cursor with last_cursor_vpos
841 because this is the only last cursor data we need to keep and consult.
842 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
843 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
844 Adjust users.
845
de396731
DA
8462013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
847
068f9124
SM
848 Fix recovering from possible decompression error.
849 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 850 the position where the partially decompressed data ends, and
447218dd 851 should count how many bytes was produced so far.
de396731
DA
852 * decompress.c (struct decompress_unwind_data): Add nbytes member.
853 (unwind_decompress): Really delete partially uncompressed data.
854 (Fzlib_decompress_region): Take decompressed data size into account.
855
c76826d9
DA
8562013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
857
858 * syntax.c (init_syntax_once): Adjust comment and do an early
859 initialization of Qchar_table_extra_slots just once...
860 * casetab.c (init_casetab_once):
861 * category.c (init_category_once):
862 * character.c (syms_of_character):
863 * coding.c (syms_of_coding):
864 * xdisp.c (syms_of_xdisp): ...and omit it here.
865
b34454d0
EZ
8662013-08-24 Eli Zaretskii <eliz@gnu.org>
867
11f20add
EZ
868 * xdisp.c (get_next_display_element): Don't apply to characters
869 from a display vector the logic of setting it->end_of_box_run_p
870 suitable for characters from a buffer. (Bug#15175)
871
b34454d0
EZ
872 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
873 to handle directories, rather than '_utime' which doesn't.
874 (Bug#15176)
875
6e1b469e
JD
8762013-08-24 Jan Djärv <jan.h.d@swipnet.se>
877
878 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
879 or fullscreen (Bug#14627).
880
9c05bccf
PE
8812013-08-24 Paul Eggert <eggert@cs.ucla.edu>
882
883 System-dependent integer overflow fixes.
884 * process.c (Fset_process_window_size): Signal an error if
885 the window size is outside the range supported by the lower level.
886 * sysdep.c (set_window_size): Return negative on error,
887 nonnegative on success, rather than -1, 0, 1 on not in system,
888 failure, success. This is simpler. Caller changed.
889 (serial_configure): Remove unnecessary initialization of local.
890 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
891 size fits in unsigned long; this isn't true on some 32-bit hosts.
892 Avoid buffer overrun if some future version of /proc/meminfo has a
893 variable name longer than 20 bytes.
894 (system_process_attributes) [__FreeBSD__]:
895 Don't assume hw.availpages fits in 'int'.
896
c365c355
PE
8972013-08-23 Paul Eggert <eggert@cs.ucla.edu>
898
899 Don't let very long directory names overrun the stack.
900 Fix some related minor problems involving "//", vfork.
901 * callproc.c (encode_current_directory): New function.
902 (call_process): Don't append "/"; not needed.
903 * fileio.c (file_name_as_directory_slop): New constant.
904 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
905 this can save the caller having to alloca.
906 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
907 Use SAFE_ALLOCA, not alloca.
908 (directory_file_name, Fexpand_file_name): Leave leading "//"
909 alone, since it can be special even on POSIX platforms.
910 * callproc.c (call_process):
911 * process.c (Fformat_network_address):
912 * sysdep.c (sys_subshell):
913 Use encode_current_directory rather than rolling our own.
914 (create_process): No need to encode directory; caller does that now.
915 * process.h (encode_current_directory): New decl.
916 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
917 Rework to avoid 'goto xyzzy;'.
918
6c6014d4
EZ
9192013-08-23 Eli Zaretskii <eliz@gnu.org>
920
921 * xdisp.c (handle_face_prop): If the default face was remapped use
922 the remapped face for strings from prefix properties. (Bug#15155)
923
9997ec56
DA
9242013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
925
926 Minor cleanup for redisplay interface and few related functions.
927 * frame.h (enum text_cursor_kinds): Move from here...
928 * dispextern.h (enum text_cursor_kinds): ...to here.
929 (toplevel): Drop unnecessary declarations.
930 (struct redisplay_interface): Use bool and enum text_cursor_kinds
931 in update_window_end_hook and draw_window_cursor functions.
932 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
933 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
934 * w32term.c (x_update_window_end,w32_draw_window_cursor):
935 * xterm.c (x_update_window_end, x_draw_window_cursor):
936 * xdisp.c (display_and_set_cursor, update_window_cursor)
937 (update_cursor_in_window_tree, x_update_cursor): Use bool and
938 enum text_cursor_kinds where appropriate.
939
7f780da6
DA
9402013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
941
942 Redesign redisplay interface to drop updated_row and updated_area.
943 * dispextern.h (updated_row, updated_area): Remove declaration.
944 (struct redisplay_interface): Pass glyph row and row area parameters
945 to write_glyphs, insert_glyphs and clear_end_of_line functions.
946 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
947 Adjust prototypes.
948 * dispnew.c (updated_row, updated_area): Remove.
949 (redraw_overlapped_rows, update_window_line): Adjust user.
950 (update_marginal_area, update_text_area): Likewise. Pass updated row
951 as a parameter. Prefer enum glyph_row_area to int where appropriate.
952 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
953 Adjust users.
954
26495794
PE
9552013-08-22 Paul Eggert <eggert@cs.ucla.edu>
956
957 * process.c (flush_pending_output): Remove stub.
958 All uses removed.
959
4a88129a
PE
9602013-08-21 Paul Eggert <eggert@cs.ucla.edu>
961
962 * callproc.c: Fix race that killed background processes (Bug#15144).
963 (call_process): New arg TEMPFILE_INDEX. Callers changed.
964 Record deleted process-id in critical section, not afterwards.
965 Don't mistakenly kill process created by a call-process invocation
966 that discards output and does not wait.
967
0c5307b0
DA
9682013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
969
970 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
971 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
972 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
973 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
974 to shut up compiler in mark_object.
975 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
976
0d7c1e66
PE
9772013-08-21 Paul Eggert <eggert@cs.ucla.edu>
978
979 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
980 We can't portably rely on PTY_OPEN doing that, even if
981 it calls posix_openpt with O_CLOEXEC.
982
3f246b65
KH
9832013-08-20 Kenichi Handa <handa@gnu.org>
984
985 * character.c (string_char): Improve commentary.
986
8c2f38aa
PE
9872013-08-20 Paul Eggert <eggert@cs.ucla.edu>
988
989 * image.c (SIGNATURE_DIGESTSIZE): Remove.
990 (struct animation_cache): Make signature a flexible array member.
991 All uses changed. This is a tad slower but may insulate us better
992 from future changes to ImageMagick.
993
bb566cea
PE
9942013-08-19 Paul Eggert <eggert@cs.ucla.edu>
995
996 * image.c: Shrink memory needed for animation cache.
997 (SIGNATURE_DIGESTSIZE): New constant.
998 (struct animation_cache): Make 'signature' a fixed size array of bytes.
999 (imagemagick_create_cache): Copy the signature. This saves
1000 several KB of memory that ImageMagick wastes per signature.
1001 Don't bother updating the update_time, as the caller does that now.
1002 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1003 it's a fixed size struct member now.
1004 (imagemagick_get_animation_cache): Always destroy the signature,
1005 as it's now imagemagick_create_cache's responsibility to copy it.
1006 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1007 and use memcmp rather than strcmp.
1008 eassert that ImageMagick returns a signature of the specified length.
1009
6da26928
LMI
10102013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1011
1012 * image.c (imagemagick_get_animation_cache): Don't segfault on
1013 each invocation.
453f4022
LMI
1014 (imagemagick_get_animation_cache): Revert to previous definition
1015 so that it actually works. But keep the memory leak fix.
1016 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1017
22490125
PE
10182013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1019
d0139df5
PE
1020 * image.c: Fix animation cache signature memory leak.
1021 Fix some other minor performance problems while we're at it.
1022 (imagemagick_create_cache): Clear just the members that
1023 need clearing. Don't set update_time, as caller does that now.
1024 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1025 Simplify by using pointer-to-pointer instead of a prev pointer.
1026 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1027 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1028 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1029 it's already a copy. Free the signature probe unless it's cached.
1030
22490125
PE
1031 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1032 This was introduced by my 2013-08-12 fix for Bug#15035.
1033
deb31e75
DA
10342013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1037 (imagemagick_prune_animation_cache): Now static.
1038
319a4d03
LMI
10392013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1040
1041 * image.c (imagemagick_get_animation_cache): Don't segfault when
1042 pruning all entries.
1043
f747d82e
KB
10442013-08-18 Ken Brown <kbrown@cornell.edu>
1045
1046 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1047 static heap if ENABLE_CHECKING is defined.
1048 (max_bss_sbrk_ptr): New variable.
1049 (bss_sbrk): Use it.
1050 (report_sheap_usage): Report maximum static heap usage instead of
1051 ending static heap usage.
1052
d2c28fab
EZ
10532013-08-17 Eli Zaretskii <eliz@gnu.org>
1054
1055 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1056 of zlib_initialized according to the results of calling
1057 init_zlib_functions.
1058
274ff63f
LMI
10592013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1060
1061 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1062 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1063 (imagemagick_load_image): Remove the ping_wand code, which only
1064 apparently saved time on invalid animated images, and slowed down
1065 everything else. Optimise for the common case.
274ff63f 1066
2bede2ed
XF
10672013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1068
70ff8240
XF
1069 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1070
de179a3e
XF
1071 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1072
2bede2ed
XF
1073 * marker.c (set_marker): Remove documentation of undefined behavior.
1074
703dbeba
LMI
10752013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1076
1077 * image.c (imagemagick_compute_animated_image): Animate correctly
1078 when sub-images are smaller than the main image.
1d18b1e6
LMI
1079 (imagemagick_compute_animated_image): Setting the iterator row to
1080 zero is apparently not allowed.
79670014
LMI
1081 (imagemagick_compute_animated_image): Allow images that say they
1082 have sub-images that are bigger than the main image, but just crop
1083 them.
703dbeba 1084
63216c5e
JD
10852013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1086
1087 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1088
a5b5f73f
LMI
10892013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1090
1091 * image.c (imagemagick_compute_animated_image): Respect the GIF
1092 disposal methods.
1093
0fe73012
KB
10942013-08-15 Ken Brown <kbrown@cornell.edu>
1095
1096 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1097 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1098 needed.
1099
691a357f
PE
11002013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 Fix minor problems found by static checking.
1103 * frame.c (delete_frame):
1104 * xdisp.c (next_element_from_display_vector):
1105 Avoid uninitialized local.
1106 * image.c (imagemagick_compute_animated_image): Port to C89.
1107 Prefer usual GNU indentation style for loops.
1108 Be more careful about bizarrely large sizes, by using ptrdiff_t
1109 instead of int.
1110
42fe2e88
DA
11112013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1112
1113 Fix infinite frame selection loop (Bug#15025).
1114 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1115
d39a3da6
EZ
11162013-08-15 Eli Zaretskii <eliz@gnu.org>
1117
068f9124
SM
1118 * xdisp.c (compute_window_start_on_continuation_line):
1119 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1120 to make sure we end up setting the window start at the leftmost
1121 visible character of the display line. This avoids funky
1122 horizontal shifting because the window start is not kept on the
1123 same position. (Bug#15090)
05426239
EZ
1124 (next_element_from_display_vector): Support 'box' face attribute
1125 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1126
6e856b69
LMI
11272013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1128
1129 * image.c (imagemagick_compute_animated_image): Implement animated
1130 images (bug#14700).
995be755
LMI
1131 (imagemagick_compute_animated_image): Fix some compilation
1132 warnings. Implement a very simple cache to make the animation
1133 usable at all, but it should be replaced with a per-image cache.
6e856b69 1134
d5a1acfa
DA
11352013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1136
1137 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1138 to do `for' loops over alist values.
1139 * buffer.h (FOR_EACH_BUFFER):
1140 * process.c (FOR_EACH_PROCESS): Use it.
1141 (handle_child_signal, status_notify, Fget_buffer_process)
1142 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1143
9c253307
DA
11442013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1145
1146 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1147 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1148 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1149 to xzalloc and so avoid redundant call to memset.
1150 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1151 members because it is allocated with xzalloc and so already zeroed.
1152
05e64f9f
KB
11532013-08-14 Ken Brown <kbrown@cornell.edu>
1154
1155 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1156 (Bug#15094).
1157
5b71542d
DA
11582013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1159
1160 Utility function and macro to copy Lisp string to C string.
1161 * lisp.h (xlispstrdupa): New macro.
1162 (xlispstrdup): New prototype.
1163 * alloc.c (xlispstrdup): New function.
1164 * callint.c (Fcall_interactively):
1165 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1166 (Fsubstitute_in_file_name):
1167 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1168 * image.c (x_create_bitmap_from_file):
1169 * w32term.c (w32_term_init):
1170 * xterm.c (x_term_init): Use xlispstrdup.
1171
71530c97
LMI
11722013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1173
4ce82fb8
LMI
1174 * image.c (imagemagick_load_image): Make animated pictures work.
1175 There's still some problems with background color settings, though
1176 (bug#14700).
1177
71530c97
LMI
1178 * decompress.c (unwind_decompress): Always restore point.
1179
7510a061
XF
11802013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1181
1182 * marker.c (set_marker): Reformat documentation.
1183
01c3051f
PE
11842013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1185
aab1fcdf
PE
1186 * xdisp.c (cursor_type_changed): Now static.
1187
01c3051f
PE
1188 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1189 Use changed. This avoids the need to call xmalloc and for the
1190 caller to call xfree, and avoids memory leaks in some situations.
1191
2084152a
DA
11922013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1193
1194 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1195 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1196 (redisplay_window): If window_end_valid is cleared due to non-zero
1197 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1198 so do not call to try_cursor_movement for that window.
2084152a 1199
02455cb6
DA
12002013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1201
1202 * window.h (struct window): Convert window_end_pos and
1203 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1204 (wset_window_end_pos, wset_window_end_vpos): Remove.
1205 * dispnew.c (adjust_glyph_matrix):
1206 * window.c (Fwindow_end, replace_window, set_window_buffer)
1207 (make_window):
1208 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1209 (set_vertical_scroll_bar, redisplay_window, try_window)
1210 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1211 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1212 (note_mouse_highlight): Adjust users.
1213 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1214 Add comment.
1215
da5707e8
DA
12162013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1219 * image.c (imagemagick_filename_hint): Use `const char *' and
1220 prefer SSDATA to SDATA to avoid warnings.
1221
25554267
DA
12222013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 Cleanup window fringes, margins and scroll bars adjustments.
1225 * window.c (set_window_fringes, set_window_margins)
1226 (set_window_scroll_bars, apply_window_adjustment): New functions.
1227 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1228 (Fset_window_scroll_bars): Use them.
1229
38a2c910
DA
12302013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 * window.h (struct window): Convert scroll_bar_width
1233 from Lisp_Object to integer. Adjust comment.
1234 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1235 Adjust users.
1236 * window.c (wset_scroll_bar_width): Remove.
1237 (make_window): Initialize scroll_bar_width.
1238 (Fsplit_window_internal): Use direct assignment.
1239 (Fset_window_configuration, save_window_save):
1240 Convert Lisp_Object to integer and back where appropriate.
1241 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1242 bar was actually changed, and mention this in docstring.
1243
2d065031
PE
12442013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * decompress.c: Minor simplifications.
1247 (Fzlib_decompress_region): Don't bother verifying
1248 that avail_out <= UINT_MAX, as that was confusing.
1249 Mention the restriction in a comment instead.
1250 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1251
a5bd5abb
JD
12522013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1253
1254 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1255 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1256
66e7901a
LMI
12572013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1258
1259 * image.c (imagemagick_filename_hint): Check for errors in the
1260 alist structure.
1261
2fa611b7
EZ
12622013-08-13 Eli Zaretskii <eliz@gnu.org>
1263
1264 * window.c (Fwindow_margins): Return nil when there's no marginal
1265 area, as per the documented API.
1266
1267 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1268 Fmake_vector, as scroll bar's struct members are not all Lisp
1269 objects now. This avoids crashes in GC.
1270
1271 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1272 bool, so its address could be taken.
1273
8259030d
LMI
12742013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1275
1276 * image.c (imagemagick_filename_hint): New function to possibly
1277 apply `image-content-type-suffixes'.
1278 (imagemagick_load_image): Use it.
1279
866c710e
EZ
12802013-08-13 Eli Zaretskii <eliz@gnu.org>
1281
1282 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1283 if loading zlib failed.
1284
f10490f0
JD
12852013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1286
96311be7
JD
1287 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1288 2013-08-13 checkin below. Change bool to BOOL, rule is:
1289 All Obj-C code uses BOOL, except for interfaces callable from C.
1290
f10490f0
JD
1291 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1292
c8ae93b0
DA
12932013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1294
1295 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1296 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1297 bool instead of BOOL.
1298 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1299 from Lisp_Object to bitfield. Adjust comment.
1300 * w32term.c (x_scroll_bar_create): Adjust user.
1301 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1302 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1303 Use bool for boolean.
1304 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1305 to `unsigned int' when defining a bitfield.
1306
53b64418
PE
13072013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1310
eeaf9bf3
DA
13112013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1312
1313 * window.h (struct window): Convert left_margin_cols and
1314 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1315 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1316 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1317 Adjust users.
1318 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1319 Adjust comment.
1320 (showing_window_margins_p, update_window_line, update_frame_1):
1321 * fringe.c (draw_fringe_bitmap_1):
1322 * xdisp.c (window_box_width): Adjust users.
1323 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1324 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1325 Use direct assignment.
1326 (Fset_window_configuration, save_window_save, Fwindow_margins):
1327 Convert Lisp_Object to integer and back where appropriate.
1328 (Fset_window_margins): Adjust user. Return t if any margin
1329 was actually changed, and mention this in docstring.
1330
956720af
XF
13312013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1332
f73f4ce6 1333 * syntax.c (forward_word):
956720af
XF
1334 * cmds.c (forward_char, backward_char): Mention the optional argument.
1335
9e37ee3b
DA
13362013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1337
1338 * window.h (struct window): Convert left_fringe_width
1339 and right_fringe_width from Lisp_Objects to integers.
1340 Adjust comment.
1341 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1342 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1343 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1344 Remove.
1345 (make_window): Initialize new integer fields to -1.
1346 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1347 (Fset_window_configuration, save_window_save):
1348 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1349 (Fset_window_fringes): Adjust user. Return t if any fringe
1350 was actually changed, and mention this in docstring.
1351
e4375ca7
DA
13522013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1353
1354 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1355 * nsfns.m (x_set_cursor_type):
1356 * w32fns.c (x_set_cursor_type):
1357 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1358 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1359
a45543bc
DA
13602013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 * font.c (clear_font_cache): New function, stripped from...
1363 (Fclear_font_cache): ...here, which now uses the function
1364 above. Adjust comment.
1365 * font.h (clear_font_cache): Add prototype.
1366 * xfaces.c (clear_face_cache): Use clear_font_cache.
1367
ae966a86
DA
13682013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1369
1370 * window.c (Fset_window_start): Compare `w', not `window' because
1371 `w' might not be equal to `window' after call to decode_live_window.
1372
297a545b
PE
13732013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1376 This fixes a problem introduced by the Bug#15035 patch
1377 when using GPG. Reported by Herbert J. Skuhra.
1378
aa942e2b
EZ
13792013-08-12 Eli Zaretskii <eliz@gnu.org>
1380
1381 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1382 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1383 not yet initialized.
1384
7699d09e
LMI
13852013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1386
1387 * decompress.c (Fzlib_decompress_region): Support zlib
1388 decompression, too, and rename.
1389
1d238bc7
PE
13902013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 Minor zlib configuration tweaks.
1393 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1394 Don't assume presence of fn_inflateInit2_ zlib internal function.
1395
8a44a184
LMI
13962013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1397
1398 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1399 include the zlib prefix.
1400
594a4307
EZ
14012013-08-12 Eli Zaretskii <eliz@gnu.org>
1402
1403 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1404 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1405 define static variables that are pointers to zlib functions to be
1406 dynamically loaded.
1407 (init_zlib_functions) [WINDOWSNT]: New function.
1408 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1409 New macros.
1410 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1411 macros instead of invoking the zlib functions directly.
068f9124
SM
1412 (syms_of_decompress): DEFSYM Qzlib_dll.
1413 Staticpro Szlib_available_p.
594a4307 1414
d2e113bc
DA
14152013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1416
1417 Avoid looping over all frame windows to freeze and unfreeze.
1418 * window.h (struct window): Drop frozen_window_start_p.
1419 (freeze_window_starts): Drop prototype.
1420 * frame.h (struct frame): New frozen_window_starts flag.
1421 (FRAME_WINDOWS_FROZEN): New macro.
1422 * window.c (freeze_window_start, freeze_window_starts):
1423 Remove.
1424 (select_window, replace_window): Adjust users.
1425 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1426 (window_frozen_p): New function.
1427 (redisplay_window): Use it.
1428
94fcd171
PE
14292013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1430
1431 Fix some fd issues when running subprocesses (Bug#15035).
1432 Fix bugs that can leak files or file descriptors on errors.
1433 Don't unlink open temp files, as that's hard for users to diagnose
1434 when things go awry (e.g., temp disk exhausted).
1435 Don't bother to lock temp files. Check for invalid recursion.
1436 * callproc.c (synch_process_fd): Remove. All uses removed.
1437 (synch_process_tempfile): New var or macro.
1438 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1439 New constants.
1440 (record_kill_process): New arg, the temp name. All callers changed.
1441 (delete_temp_file): Now just a simple wrapper around unlink.
1442 (call_process_kill): New arg, the call_process_fd array.
1443 Close them all. Clear synch_process_pid. Remove the temp file,
1444 or arrange for it to be removed.
1445 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1446 that's been moved to synch_process_tempfile. Caller changed.
1447 Do not remove the tempfile; that's now call_process_kill's
1448 responsibility.
1449 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1450 call_process_kill; the caller now does that.
1451 (call_process_cleanup): Do not close the process fd; that's now
1452 call_process_kill's responsibility.
1453 (Fcall_process): Implement via new function call_process, which
1454 has most of the old body of Fcall_process, but with a different API.
1455 (call_process): New function that does not open or close filefd if
1456 it is nonnegative. Record which fds need to be closed, and let
1457 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1458 Signal an error if invoked recursively (could be done via a hook).
1459 Simplify creation of the tempfile in the MSDOS case.
1460 Don't create the output file until after checking for the executable.
1461 Report any failure to open /dev/null.
1462 Don't open /dev/null for writing twice; once is enough.
1463 Don't create pipe if all output is being discarded or sent to file.
1464 Don't worry about setting up the coding system or reading from the
1465 pipe if all output is being discarded.
1466 Hoist fd_error local into top level, to lessen block nesting.
1467 Don't record deleted pid here; now done by Fcall_process_region.
1468 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1469 and note its success in synch_process_tempfile.
1470 Do not leak resources when child_setup fails.
1471 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1472 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1473 (create_temp_file): Now returns open fd, with an additional
1474 Lisp_Object * argument to return the name. All callers changed.
1475 Do not close the file; rewind it instead, and leave it open for
1476 the caller. Do not lock the temp file. Unwind-protect the file
1477 and the file-descriptor.
1478 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1479 If an asynchrounous process, record it here, not in call_process.
1480 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1481 * eval.c (set_unwind_protect): New function.
1482 * fileio.c (write_region): New function, generalized from the
1483 old Fwrite_region. Do not lock temp files.
1484 (Fwrite_region): Use it.
1485 * lisp.h (set_unwind_protect, write_region): New decls.
1486 * process.c: Include <verify.h>.
1487 (make_process): Mark fds as initially closed.
1488 (deleted_pid_list): Now a list of pid-filename pairs.
1489 All uses changed.
1490 (close_process_fd): New function.
1491 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1492 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1493 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1494 (create_process, create_pty, Fmake_serial_process)
1495 (server_accept_connection): Record which fds need to be closed,
1496 and let deactivate_process close them.
1497 (Fmake_network_process): Do not discard the unwind-protect
1498 until it's safe to do so.
1499 (deactivate_process): Close the fds opened by create_process etc.
1500 (Fprocess_send_eof): Adjust to new way of recording open fds.
1501 Report an error if /dev/null can't be opened, instead of aborting.
1502 * process.h (PROCESS_OPEN_FDS): New constant.
1503 (struct Lisp_Process): New member open_fds.
1504 (record_kill_process, record_deleted_pid): Adjust signatures.
1505 (record_deleted_pid): Move decl here ...
1506 * syswait.h (record_deleted_pid): ... from here.
1507
d0e615c3
PE
15082013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1509
1510 * decompress.c: Fix bugs with large buffers and weird inputs.
1511 Tune a bit. Reindent as per usual Emacs style.
1512 (BUFFER_SIZE): Remove.
1513 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1514 more than UINT_MAX bytes. Decompress into the gap instead of into
1515 an auto buffer, as this should avoid copying. Return nil if
1516 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1517 set immediate_quit; we shouldn't trust zlib code that much.
1518
313546eb
LMI
15192013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1520
99a32242
LMI
1521 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1522 errors, and really move the gap to where we want it.
1523
313546eb
LMI
1524 * lisp.h: Include decompress.c support.
1525
1526 * emacs.c (main): Include decompress.c support.
1527
1528 * Makefile.in: Include -lz if present.
1529
d2d699ac
JD
15302013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1531
f90e3ebd
JD
1532 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1533 (initWithTitle:): Initialize frame to 0.
1534 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1535 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1536 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1537
1538 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1539 fillWithWidgetValue:frame:
1540
423d3b3f
JD
1541 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1542 remove memory leak warnings.
1543
d2d699ac
JD
1544 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1545 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1546 menu_pending_title.
1547
1548 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1549 (x_activate_menubar): Update the whole menu.
1550 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1551 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1552 current event is not NSSystemDefined (Bug#15001).
1553 Call ns_check_menu_open only if trackingMenu is 2.
1554 (menuDidClose:): New method, decrease trackingMenu.
1555 (fillWithWidgetValue:setDelegate:): New method.
1556 (fillWithWidgetValue:): Call the above.
1557
1558 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1559
7d652d97
PE
15602013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 Omit some unnecessary casts.
1563 Many of these go back to the old pre-C89 days, when they may have
1564 been needed, but we've been assuming C89 or later for a while now.
1565 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1566 (live_float_p, live_misc_p, live_vector_p):
1567 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1568 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1569 (defvar_per_buffer):
1570 * callint.c (Fcall_interactively):
1571 * doc.c (Fsubstitute_command_keys):
1572 * filelock.c (get_boot_time):
1573 * frame.c (xrdb_get_resource):
1574 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1575 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1576 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1577 (menuitem_highlight_callback, menu_destroy_callback)
1578 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1579 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1580 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1581 (xg_tool_bar_help_callback, tb_size_cb):
1582 * image.c (xpm_alloc_color, png_read_from_memory)
1583 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1584 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1585 (syms_of_image):
1586 * keymap.c (describe_map):
1587 * nsfns.m (Fns_display_monitor_attributes_list):
1588 * nsmenu.m (process_dialog:):
1589 * nsterm.m (hold_event):
1590 * process.c (wait_reading_process_output):
1591 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1592 * scroll.c (do_direct_scrolling, scrolling_1):
1593 * termcap.c (tgetent):
1594 * window.c (check_window_containing, add_window_to_list)
1595 (freeze_window_starts):
1596 * xdisp.c (compare_overlay_entries, vmessage):
1597 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1598 (x_get_monitor_attributes_xrandr)
1599 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1600 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1601 * xfont.c (xfont_match, xfont_open):
1602 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1603 (menubar_selection_callback, menu_position_func)
1604 (popup_selection_callback, create_and_show_popup_menu)
1605 (dialog_selection_callback, create_and_show_dialog):
1606 * xrdb.c (x_get_string_resource):
1607 (main) [TESTRM]:
1608 * xsmfns.c (x_session_check_input):
1609 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1610 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1611 (xaw_jump_callback, xaw_scroll_callback):
1612 Omit unnecessary casts.
1613
9acc1074
PE
16142013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 Minor string-length refactoring.
1617 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1618 * frame.c (make_monitor_attribute_list):
1619 Prefer build_string to strlen + make_string.
1620
361c0eb8
JD
16212013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1622
1623 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1624 don't check minor_code (Bug#14417).
1625
14ba0822
EZ
16262013-08-09 Eli Zaretskii <eliz@gnu.org>
1627
1628 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1629 vertical positions instead. This avoids calling MATRIX_ROW with
1630 row numbers that are possibly beyond valid limits. (Bug#15064)
1631
309f24d1
DA
16322013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1633
1634 Use xstrdup and build_unibyte_string where applicable.
1635 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1636 * xfns.c (x_window):
1637 * xrdb.c (x_get_customization_string):
1638 * xterm.c (xim_initialize):
1639 * w32fns.c (w32_window): Use xstrdup.
1640 (w32_display_monitor_attributes_list):
1641 * emacs.c (init_cmdargs):
1642 * keyboard.c (PUSH_C_STR):
1643 * nsfont.m (nsfont_open):
1644 * sysdep.c (system_process_attributes):
1645 * w32.c (system_process_attributes):
1646 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1647
55902276
EZ
16482013-08-09 Eli Zaretskii <eliz@gnu.org>
1649
1650 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1651 variables of these types so that GDB would know about them, as aid
1652 for debugging fatal exceptions. (Bug#15024) See also
1653 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1654 discussions.
1655
10bf7f5a
JD
16562013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1657
1658 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1659 larger than the NSWindow (Bug#14934).
1660
65620264
DA
16612013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1662
1663 Redesign redisplay interface to drop global variable updated_window.
1664 Always pass currently updated window as a parameter to update routines.
1665 * dispextern.h (updated_window): Remove declaration.
1666 (struct redisplay_interface): Pass window parameter to
1667 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1668 and after_update_window_hook.
1669 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1670 Adjust prototypes.
1671 * dispnew.c (updated_window): Remove.
1672 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1673 (update_window_line): Adjust to match redisplay interface changes.
1674 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1675 (ns_scroll_run, ns_after_update_window_line):
1676 * w32term.c (x_update_window_begin, x_update_window_end)
1677 (x_after_update_window_line, x_scroll_run):
1678 * xterm.c (x_update_window_begin, x_update_window_end)
1679 (x_after_update_window_line, x_scroll_run):
1680 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1681 Likewise. Adjust comments where appropriate.
1682 (x_cursor_to): Simplify because this is always called during window
1683 update (but install debugging check anyway).
1684 (expose_window): Check must_be_updated_p flag to see whether this
1685 function is called during window update.
1686
628fdc56
DA
16872013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1688
1689 Do not reset window modification event counters excessively.
1690 These leftovers and poor man's tricky methods to catch extra
1691 redisplay's attention are no longer needed.
1692 * frame.c (set_menu_bar_lines_1):
1693 * minibuf.c (read_minibuf_unwind):
1694 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1695 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1696 (window_scroll_line_based, Fset_window_configuration):
1697 * xdisp.c (redisplay_window): Do not reset last_modified and
1698 last_overlay_modified counters.
1699
8fd9c92e
JD
17002013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1701
1702 * xselect.c (x_send_client_event): Set send_event and serial, memset
1703 data.l as it might be bigger than data.b. Use 24 bit mask to
1704 XSendEvent (Bug#15034).
1705
0ee18172
EZ
17062013-08-07 Eli Zaretskii <eliz@gnu.org>
1707
1708 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1709 for TTY frames that are not the top frame on their console.
1710 (Bug#14616)
1711
16ddd1a6
MR
17122013-08-07 Martin Rudalics <rudalics@gmx.at>
1713
1714 * w32term.c (w32fullscreen_hook): Really maximize frame when
1715 asked for (Bug#14841).
1716
d2a95ffb
DA
17172013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1718
1719 Prefer selected_window to Fselected_window, likewise for frames.
1720 * buffer.c (Fbuffer_swap_text):
1721 * data.c (Fvariable_binding_locus):
1722 * window.c (run_window_configuration_change_hook): Adjust users.
1723 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1724 Use decode_live_frame.
1725
170da1ec
DA
17262013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1727
1728 Be more careful if selected window shows the buffer other than current,
1729 use window_outdated only if this is not so. This change should also
1730 address some weird issues discussed in Bug#13012.
1731 * window.h (window_outdated): New prototype.
1732 * window.c (window_outdated): Now here. Convert from static and
1733 always assume window's buffer.
1734 (Fwindow_end, Fwindow_line_height): Use it.
1735 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1736 and always assume window's buffer.
1737 (redisplay_window): Adjust user.
e5eefe9b 1738 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1739 check whether mode line should be updated only if selected window
1740 shows current buffer.
1741 (run_window_scroll_functions): Use eassert for debugging check.
1742 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1743
56b5d5b1
DA
17442013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1745
1746 * window.c (window_scroll, window_scroll_pixel_based)
1747 (window_scroll_line_based): Use bool for booleans.
1748
2878ba7e
PE
17492013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * process.c: Fix minor off-by-one issues in descriptor counts.
1752 This shouldn't fix any real bugs, but it cleans up the code a bit.
1753 (max_process_desc, max_input_desc): -1, not 0, means none.
1754 All uses changed.
1755 (delete_input_desc): New function.
1756 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1757 (deactivate_process): Scan backwards when recomuting max_process_desc;
1758 that should be faster.
1759 (init_process_emacs): Initialize max_input_desc.
1760
e30b79c1
DA
17612013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1762
1763 Use region cache to speedup bidi_find_paragraph_start.
1764 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1765 Rename cache_long_line_scans to cache_long_scans.
1766 * buffer.c (bset_cache_long_line_scans): Rename to
1767 bset_cache_long_scans.
1768 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1769 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1770 into account.
1771 (syms_of_buffer): Rename cache-long-line-scans to
1772 cache-long-scans. Adjust docstring.
1773 * search.c (newline_cache_on_off):
1774 * indent.c (width_run_cache_on_off): Adjust users.
1775 * bidi.c (bidi_paragraph_cache_on_off): New function.
1776 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1777 * insdel.c (prepare_to_modify_buffer):
1778 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1779
00012b86
DA
17802013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1781
1782 Invalidate region caches only if buffer text is going to be changed.
1783 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1784 (modify_text): ...new prototype.
1785 (prepare_to_modify_buffer_1): New prototype.
1786 * textprop.c (modify_region): Rename to...
1787 (modify_text_properties): ...new function.
1788 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1789 (Fremove_list_of_text_properties): Adjust users.
1790 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1791 (modify_text): ...new function.
1792 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1793 (prepare_to_modify_buffer_1): ...new function.
1794 * casefiddle.c (casify_region):
1795 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1796 (Ftranspose_regions): Use modify_text.
1797
dc6c0eda
SM
17982013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1799
1800 * lisp.mk (lisp): Add nadvice.elc.
1801
8f3a2c26
DA
18022013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1803
1804 New macro to iterate over live buffers similar to frames.
1805 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1806 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1807 Declare buffer-related variables here to offload lisp.h.
1808 * buffer.c (Vbuffer_alist): Adjust comment.
1809 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1810 (other_buffer_safely):
1811 * data.c (store_symval_forwarding):
1812 * dispnew.c (Fframe_or_buffer_changed_p):
1813 * fileio.c (Fdo_auto_save):
1814 * filelock.c (unlock_all_files):
1815 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1816
e0fdb694
PE
18172013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1818
1819 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1820 * callproc.c (create_temp_file):
1821 * filelock.c (create_lock_file):
1822 Assume mkostemp, since it's now provided by Gnulib.
1823
63f5c6c2
EZ
18242013-08-04 Eli Zaretskii <eliz@gnu.org>
1825
1826 * w32.c (mkostemp): New function.
1827 (mktemp): Remove, no longer used. Most of the code reused in
1828 mkostemp. (Bug#15015)
484ab239 1829 (mktemp): Don't undef.
63f5c6c2 1830
f0b79313
DA
18312013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1832
1833 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1834 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1835 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1836 (free_glyph_pool, check_glyph_memory): Likewise for
1837 all users. Adjust comments where appropriate.
1838
98f638d6
PE
18392013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * composite.h: Minor fixups.
1842 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1843 to fix a misspelling, and change it to an inline function while
1844 we're at it (it need not be a macro). All uses changed.
1845 (composition_method, composition_valid_p):
1846 Rewrite to avoid assignments in if-conditions.
1847
75c59fb3
DA
18482013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1849
1850 Do not use global Lisp_Object in composition macros.
1851 * composite.h (composition_temp): Remove declaration.
1852 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1853 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1854 (compose_region): Remove the leftover.
75c59fb3
DA
1855 * composite.c (composition_temp): Remove.
1856 (run_composition_function, update_compositions)
1857 (composition_compute_stop_pos, composition_adjust_point)
1858 (Ffind_composition_internal):
1859 * coding.c (handle_composition_annotation):
1860 * xdisp.c (handle_composition_prop, check_point_in_composition):
1861 Related users changed.
1862
a10c8269
DA
18632013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1864
1865 Drop FRAME_PTR typedef.
1866 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1867 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1868 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1869 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1870 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1871 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1872 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1873 All related users changed.
1874
a104f656
SM
18752013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1876
1877 * eval.c (default_toplevel_binding): New function.
1878 (Fdefvar): Use it.
1879 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1880 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1881 (syms_of_eval): Export them.
1882 * data.c (Fdefault_value): Micro cleanup.
1883 * term.c (init_tty): Use "false".
1884
4b5c9326
DA
18852013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1886
1887 Fix X GC leak in GTK and raw (no toolkit) X ports.
1888 * xterm.c (x_free_frame_resources): If white and black relief
1889 GCs are allocated, always free them here.
1890 * xfns.c (x_make_gc): Omit redundant initialization.
1891 * widget.c (create_frame_gcs): Remove the leftover.
1892 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1893 in x_free_frame_resources.
1894
b19aa636
JD
18952013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1896
1897 * nsterm.m (windowWillResize:toSize:): Only change title if
1898 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1899 modifying it.
1900 (viewDidEndLiveResize): New method.
1901
1902 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1903 inside NS_IMPL_COCOA.
1904
af1f7e06
DA
19052013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1906
1907 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1908 Do not check whether undo is enabled because record_insert and
1909 record_delete does that themselves.
1910
65b02bb9
DA
19112013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1912
1913 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1914 member which is not really used any more.
1915 (FRAME_XIC_BASE_FONTNAME): Remove.
1916 * xfns.c (xic_free_fontset): Adjust user.
1917 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1918 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1919 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1920 (xdialog_show): Use eassert for debugging check.
7ee0f047 1921 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1922
6318cde0
PE
19232013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 * fileio.c, fns.c (merge): Move extern decl from here ...
1926 * lisp.h (merge): ... to here.
1927
6c1a09ba
DA
19282013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1929
1930 Fix last font-related change.
1931 * w32font.h (w32font_list_internal, w32font_match_internal):
1932 Fix prototype.
1933 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1934 (uniscribe_list_family): Adjust to match font API change.
1935 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1936 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1937
f8c20208
DA
19382013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1939
1940 * frame.h (FRAME_MOUSE_UPDATE):
1941 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1942 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1943
fdb396e2
DA
19442013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1945
1946 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1947 * font.h (struct font_driver): Change list, match, and list_family
1948 functions to accept struct frame * as first arg.
068f9124
SM
1949 * font.c (font_score, font_compare, font_sort_entities):
1950 Remove prototypes.
fdb396e2
DA
1951 (font_sort_entities, font_list_entities, font_select_entity):
1952 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1953 match font API change.
1954 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1955 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1956 * ftxfont.c (ftxfont_list, ftxfont_match):
1957 * xftfont.c (xftfont_list, xftfont_match):
1958 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1959 * w32font.c (w32font_list, w32font_match, w32font_list):
1960 (w32font_list_internal, w32_font_match_internal): Likewise.
1961 * xfaces.c (Fx_family_fonts): Adjust user.
1962
52b8a085
DA
19632013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1964
1965 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1966 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1967 only if HAVE_X_WINDOWS is in use.
1968 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1969 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1970 * w32term.c (x_wm_set_icon_position): Likewise.
1971 * w32fns.c (x_icon): Adjust user.
1972
c791c18e
DA
19732013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1974
1975 * xterm.c (last_mouse_press_frame): Remove the
1976 leftover which is not really used any more.
1977 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1978 (x_flush): Call XFlush once per each X display, not frame.
1979 This is better because this code always unconditionally skips
1980 non-X frames in Vframe_list and issues the only XFlush if we
1981 have more than one X frame on the same X display.
2f935d86
DA
1982 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1983 Use bool for booleans.
1984 (x_draw_glyph_string_background, cvt_string_to_pixel):
1985 (cvt_pixel_dtor): Drop unnecessary prototypes.
1986 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1987
f435830e
DA
19882013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1989
1990 Drop unnecessary functions that deals with frame pixel size.
1991 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1992 (x_pixel_height): Drop prototypes.
1993 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1994 (x_pixel_height): Drop implementations.
1995 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1996 which should be always valid for window frame.
1997 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1998 * w32menu.c (Fx_popup_dialog):
1999 * xmenu.c (Fx_popup_dialog): Likewise for both.
2000
84231434
DA
20012013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2002
2003 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2004 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2005 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2006 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2007 and mention nil frame in docstring.
84231434 2008
959067a1
DA
20092013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2010
2011 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2012 (x_figure_window_size): Likewise. Adjust to return long.
2013 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2014 (toplevel): Move Qterminal_live_p to...
2015 * terminal.c (toplevel): ...here, make it static, and...
2016 (syms_of_terminal): ...DEFSYM here.
2017 * frame.h (Qterminal_live_p): Remove declaration.
2018 (make_frame, x_figure_window_size): Adjust prototype.
2019 * nsfns.m (Fx_create_frame): Use long for window flags.
2020
f4b169ce
PE
20212013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2024 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2025 Do not assume that emacs_close (INT_MAX) is a no-op.
2026
bee6a2c7
DA
20272013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2028
2029 * xfaces.c (make_face_cache): For struct face_cache, prefer
2030 xmalloc to xzalloc and so avoid redundant call to memset.
2031 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2032
d7e6881a
DA
20332013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2034
2035 * fringe.c (draw_window_fringes, update_window_fringes)
2036 (compute_fringe_widths):
2037 * w32term.c (x_draw_glyph_string):
2038 * window.c (candidate_window_p, Frecenter):
2039 * xfaces.c (realize_basic_faces, realize_default_face)
2040 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2041 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2042 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2043 * xmenu.c (Fx_menu_bar_open_internal):
2044 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2045 * xsettings.c (xft_settings_event):
2046 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2047 Use bool for booleans. Adjust style and comments where
2048 appropriate.
2049 * dispextern.h (draw_window_fringes, update_window_fringes)
2050 (compute_fringe_widths):
2051 * xterm.h (x_had_errors_p): Adjust prototype.
2052
ec3058af
DA
20532013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2054
2055 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2056 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2057
218e0637
DA
20582013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2059
2060 * fns.c (toplevel): Remove comment before Fsafe_length because
2061 it checks for QUIT.
2062
e560aba9
PE
20632013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2066
2e5ce5de
EZ
20672013-07-28 Eli Zaretskii <eliz@gnu.org>
2068
2069 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2070 frame which got the message is still alive, before dereferencing
2071 its pointer. (Bug#14970)
2072
2073 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2074 be a live window, before using it as such. (Bug#14970)
2075
e95da6d3
EZ
20762013-07-27 Eli Zaretskii <eliz@gnu.org>
2077
2078 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2079 w32_detect_focus_change instead of doing part of its job by hand.
2080 This fixes the problem whereby FOCUS_OUT events were not sent to
2081 the event queue.
2082
a8f93651
EZ
20832013-07-26 Eli Zaretskii <eliz@gnu.org>
2084
fec92060
EZ
2085 * process.c (Fprocess_list): Doc fix.
2086
a8f93651
EZ
2087 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2088 being re-exposed only if it didn't ask to become visible.
2089 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2090 was previously iconified. (Bug#14841)
2091 (x_iconify_frame): Mark the frame iconified.
2092
d5a7a9d9
PE
20932013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2094
2095 Fix minor problems found by static checking.
2096 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2097 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2098
56ea7291
SM
20992013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2100
2101 * eval.c (set_specpdl_old_value): New function.
2102 (unbind_to): Minor simplification.
2103 (get_backtrace_frame): New function.
2104 (Fbacktrace_frame): Use it. Add `base' argument.
2105 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2106 (syms_of_eval): Export backtrace-eval.
2107 * xterm.c (x_focus_changed): Simplify.
2108
9d611ffe
PE
21092013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2112
999c74e3
EZ
21132013-07-24 Eli Zaretskii <eliz@gnu.org>
2114
2115 * xdisp.c (redisplay_window): Instead of moving point out of
2116 scroll margin, reject the force_start method, and try scrolling
2117 instead. (Bug#14780)
2118
198fa217
KB
21192013-07-24 Ken Brown <kbrown@cornell.edu>
2120
2121 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2122 (Bug#14944).
2123
53840e55
PE
21242013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 * eval.c (Fprogn): Do not check that BODY is a proper list.
2127 This undoes the previous change. The check slows down the
2128 interpreter, and is not needed to prevent a crash. See
2129 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2130
60967f56
GM
21312013-07-23 Glenn Morris <rgm@gnu.org>
2132
2133 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2134
9ca960e2
PE
21352013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2136
a29c3e6d
PE
2137 Port to GNU/Linux systems with tinfo but not ncurses.
2138 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2139 to decide whether ncurses is being used. Without this change,
2140 GCC complains about tgetent not being declared, on a system
2141 that has tinfo installed but ncurses not installed.
2142
f274311c
PE
2143 * eval.c (Fprogn): Check that BODY is a proper list.
2144
16b0520a
PE
2145 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2146 * data.c (Fsetq_default):
2147 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2148 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2149 (Fcondition_case):
2150 Tune by taking advantage of the fact that ARGS is always a list
2151 when a function is declared to have UNEVALLED args.
2152
9ca960e2
PE
2153 * emacsgtkfixed.c: Port to GCC 4.6.
2154 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2155
afacaa1b
JB
21562013-07-23 Juanma Barranquero <lekktu@gmail.com>
2157
2158 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2159 here to silence compiler warnings.
2160
368a85a4
PE
21612013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2164 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2165 from messing up Emacs's 'struct frame' (Bug#14923).
2166
f4e891b5
PE
21672013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2168
2169 * alloc.c (make_save_ptr_ptr): Define this function.
2170 It was inadvertently omitted. It's needed only if
2171 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2172
96c8b65e
JD
21732013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2174
2175 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2176 frame have focus (Bug#14895).
2177
ee010797
PE
21782013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 Avoid vfork-related deadlock more cleanly.
2181 * callproc.c (child_setup): When the child's exec fails, output
2182 the program name, as that's more useful. Use O_NONBLOCK to avoid
2183 deadlock.
2184 * process.c (create_process_1): Remove; no longer needed.
2185 (create_process): Remove timer hack; no longer needed, now that
2186 the child avoids deadlock.
2187
f0398ec1 21882013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2189
2190 * image.c (Fimage_flush): Fix doc typo.
2191
b2a069c2
PE
21922013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2193
6496aec9
PE
2194 Fix array bounds violation when pty allocation fails.
2195 * process.c (PTY_NAME_SIZE): New constant.
2196 (pty_name): Remove static variable; it's now auto.
2197 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2198 Take pty_name as an arg rather than using a static variable.
2199 All callers changed.
2200 (create_process): Recover pty_flag from process, not from volatile local.
2201 (create_pty): Stay inside array even when pty allocation fails.
2202 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2203
b2a069c2
PE
2204 * lread.c (Fload): Avoid initialization only when lint checking.
2205 Mention that it's needed only for older GCCs.
2206
99107004
KH
22072013-07-20 Kenichi Handa <handa@gnu.org>
2208
2209 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2210 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2211
6b1b199d
AS
22122013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2213
2214 * lread.c (Fload): Avoid uninitialized warning.
2215
4195afc3
PE
22162013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2217
3f5bef16
PE
2218 Fix some minor file descriptor leaks and related glitches.
2219 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2220 (create_lock_file): Use write, not emacs_write.
2221 * image.c (slurp_file, png_load_body):
2222 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2223 (server_accept_connection):
2224 Don't leak an fd on memory allocation failure.
2225 * image.c (slurp_file): Add a cheap heuristic for growing files.
2226 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2227 as that's what the other routines do. Maybe input need not be
2228 blocked at all, but it's better to be consistent.
2229 Avoid undefined behavior when strlen is zero.
2230
4195afc3
PE
2231 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2232 (NSTATICS): Now a constant; doesn't need to be a macro.
2233
a1aeeffe
RS
22342013-07-19 Richard Stallman <rms@gnu.org>
2235
2236 * coding.c (decode_coding_utf_8): Add simple loop for fast
2237 processing of ASCII characters.
2238
63b34baa
PE
22392013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2242
621dd9ac
EZ
22432013-07-19 Eli Zaretskii <eliz@gnu.org>
2244
2245 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2246 unportable 'struct x_display_info'.
2247 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2248 is a portable type.
2249
1396ac86
PE
22502013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2251
ab9980cd
PE
2252 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2253 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2254 or fscanf fails.
2255 (system_process_attributes): Prefer plain char to unsigned char
2256 when either will do. Clean up properly if interrupted or if
068f9124
SM
2257 memory allocations fail. Don't assume sscanf succeeds.
2258 Remove no-longer-needed workaround to stop GCC from whining.
2259 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2260 bit more carefully.
2261
1396ac86
PE
2262 Fix obscure porting bug with varargs functions.
2263 The code assumed that int is treated like ptrdiff_t in a vararg
2264 function, which is not a portable assumption. There was a similar
2265 -- though these days less likely -- porting problem with various
2266 assumptions that pointers of different types all smell the same as
2267 far as vararg functions is conserved. To make this problem less
2268 likely in the future, redo the API to use varargs functions.
2269 * alloc.c (make_save_value): Remove this vararg function.
2270 All uses changed to ...
2271 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2272 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2273 New functions.
2274 (make_save_ptr): Rename from make_save_pointer, for consistency with
2275 the above. Define only on platforms that need it. All uses changed.
2276
4d19d194
PE
22772013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * keyboard.c: Try to fix typos in previous change.
2280 (DISPLAY_LIST_INFO): New macro.
2281 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2282 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2283
945c5bb1
JB
22842013-07-18 Juanma Barranquero <lekktu@gmail.com>
2285
2286 * keyboard.c (kbd_buffer_get_event):
2287 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2288 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2289
f4b1eb36
PE
22902013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2291
5e679a2c
PE
2292 * filelock.c: Fix unlikely file descriptor leaks.
2293 (get_boot_time_1): Rework to avoid using emacs_open.
2294 This doesn't actually fix a leak, but is better anyway.
2295 (read_lock_data): Use read, not emacs_read.
2296
a8cd4836
PE
2297 * doc.c: Fix minor memory and file descriptor leaks.
2298 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2299 (get_doc_string, Fsnarf_documentation):
2300 Fix file descriptor leak on error.
2301
ef30e638
PE
2302 * term.c: Fix minor fdopen-related file descriptor leaks.
2303 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2304 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2305
f4b1eb36
PE
2306 * charset.c: Fix file descriptor leaks and errno issues.
2307 Include <errno.h>.
2308 (load_charset_map_from_file): Don't leak file descriptor on error.
2309 Use plain record_xmalloc since the allocation is larger than
2310 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2311 of entries.
2312 * eval.c (record_unwind_protect_nothing):
2313 * fileio.c (fclose_unwind):
2314 New functions.
2315 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2316 The replacement doesn't block input, but that no longer seems
2317 necessary.
2318
b648c163
PE
23192013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2320
a0931322
PE
2321 * lread.c: Fix file descriptor leaks and errno issues.
2322 (Fload): Close some races that leaked fds or streams when 'load'
2323 was interrupted.
2324 (Fload, openp): Report error number of last nontrivial failure to open.
2325 ENOENT counts as trivial.
2326 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2327 New functions.
2328 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2329 now that the function is always called with a nonnegative arg.
2330 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2331 All uses replaced with ...
2332 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2333
b648c163
PE
2334 A few more minor file errno-reporting bugs.
2335 * callproc.c (Fcall_process):
2336 * doc.c (Fsnarf_documentation):
2337 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2338 * process.c (set_socket_option):
2339 Don't let a constructor trash errno.
2340 * doc.c: Include <errno.h>.
2341
b1dc4084
JB
23422013-07-16 Juanma Barranquero <lekktu@gmail.com>
2343
2344 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2345
c43843aa
PE
23462013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2347
50a30cce
PE
2348 Fix w32 bug with call-process-region (Bug#14885).
2349 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2350 to Fcall_process when the input is empty. This simplifies the
2351 code a bit. It makes no difference on POSIXish platforms but
2352 apparently it fixes a bug on w32.
2353
44e18199 2354 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2355 * fileio.c (close_file_unwind): Don't close if FD is negative;
2356 this can happen when unwinding a zapped file descriptor.
2357 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2358 in case Emacs runs out of memory between the two unwind-protects.
2359 Don't trash errno when closing FD.
2360 Zap the FD in the specpdl when closing it, instead of deferring
2361 the removal of the unwind-protect; this fixes a bug where a child
2362 function unwinds the stack past us.
2363
27e498e6
PE
2364 New unwind-protect flavors to better type-check C callbacks.
2365 This also lessens the need to write wrappers for callbacks,
2366 and the need for make_save_pointer.
2367 * alloca.c (free_save_value):
2368 * atimer.c (run_all_atimers):
2369 Now extern.
2370 * alloc.c (safe_alloca_unwind):
2371 * atimer.c (unwind_stop_other_atimers):
2372 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2373 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2374 * minibuf.c (choose_minibuf_frame_1):
2375 * process.c (make_serial_process_unwind):
2376 * xdisp.h (pop_message_unwind):
2377 * xselect.c (queue_selection_requests_unwind):
2378 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2379 * alloca.c (record_xmalloc):
2380 Prefer record_unwind_protect_ptr to record_unwind_protect with
2381 make_save_pointer.
2382 * alloca.c (Fgarbage_collect):
2383 Prefer record_unwind_protect_void to passing a dummy.
2384 * buffer.c (restore_buffer):
2385 * window.c (restore_window_configuration):
2386 * xfns.c, w32fns.c (do_unwind_create_frame)
2387 New wrapper. All record-unwind uses of wrappee changed.
2388 * buffer.c (set_buffer_if_live):
2389 * callproc.c (call_process_cleanup, delete_temp_file):
2390 * coding.c (code_conversion_restore):
2391 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2392 * editfns.c (save_excursion_restore)
2393 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2394 (save_restriction_restore):
2395 * eval.c (restore_stack_limits, un_autoload):
2396 * fns.c (require_unwind):
2397 * keyboard.c (recursive_edit_unwind, tracking_off):
2398 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2399 * macros.c (pop_kbd_macro, restore_menu_items):
2400 * nsfns.m (unwind_create_frame):
2401 * print.c (print_unwind):
2402 * process.c (start_process_unwind):
2403 * search.c (unwind_set_match_data):
2404 * window.c (select_window_norecord, select_frame_norecord):
2405 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2406 (fast_set_selected_frame):
2407 * xfns.c, w32fns.c (unwind_create_tip_frame):
2408 Return void, not a dummy Lisp_Object. All uses changed.
2409 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2410 * callproc.c (call_process_kill):
2411 * fileio.c (restore_point_unwind, decide_coding_unwind)
2412 (build_annotations_unwind):
2413 * insdel.c (Fcombine_after_change_execute_1):
2414 * keyboard.c (read_char_help_form_unwind):
2415 * menu.c (unuse_menu_items):
2416 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2417 * sound.c (sound_cleanup):
2418 * xdisp.c (unwind_redisplay):
2419 * xfns.c (clean_up_dialog):
2420 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2421 Accept no args and return void, instead of accepting and returning
2422 a dummy Lisp_Object. All uses changed.
2423 * cygw32.c (fchdir_unwind):
2424 * fileio.c (close_file_unwind):
2425 * keyboard.c (restore_kboard_configuration):
2426 * lread.c (readevalllop_1):
2427 * process.c (wait_reading_process_output_unwind):
2428 Accept int and return void, rather than accepting an Emacs integer
2429 and returning a dummy object. In some cases this fixes an
2430 unlikely bug when the corresponding int is outside Emacs integer
2431 range. All uses changed.
2432 * dired.c (directory_files_internal_unwind):
2433 * fileio.c (do_auto_save_unwind):
2434 * gtkutil.c (pop_down_dialog):
2435 * insdel.c (reset_var_on_error):
2436 * lread.c (load_unwind):
2437 * xfns.c (clean_up_file_dialog):
2438 * xmenu.c, nsmenu.m (pop_down_menu):
2439 * xmenu.c (cleanup_widget_value_tree):
2440 * xselect.c (wait_for_property_change_unwind):
2441 Accept pointer and return void, rather than accepting an Emacs
2442 save value encapsulating the pointer and returning a dummy object.
2443 All uses changed.
2444 * editfns.c (Fformat): Update the saved pointer directly via
2445 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2446 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2447 (unwind_body): New function.
2448 (record_unwind_protect): First arg is now a function returning void,
2449 not a dummy Lisp_Object.
2450 (record_unwind_protect_ptr, record_unwind_protect_int)
2451 (record_unwind_protect_void): New functions.
2452 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2453 * fileio.c (struct auto_save_unwind): New type.
2454 (do_auto_save_unwind): Use it.
2455 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2456 * insdel.c (struct rvoe_arg): New type.
2457 (reset_var_on_error): Use it.
2458 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2459 New constants.
2460 (specbinding_func): Remove; there are now several such functions.
2461 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2462 (set_unwind_protect_ptr): New function.
2463 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2464
4e604a5d
PE
2465 Be simpler and more consistent about reporting I/O errors.
2466 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2467 Say "Read error" and "Write error", rather than "I/O error", or
2468 "IO error reading", or "IO error writing", when a read or write
2469 error occurs.
2470 * process.c (Fmake_network_process, wait_reading_process_output)
2471 (send_process, Fprocess_send_eof, wait_reading_process_output):
2472 Capitalize diagnostics consistently. Put "failed foo" at the
2473 start of the diagnostic, so that we don't capitalize the
2474 function name "foo". Consistently say "failed" for such
2475 diagnostics.
2476 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2477 All callers changed. This is so it can use report_file_error.
2478 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2479 diagnostics consistently as above.
2480
a9757f6a
PE
2481 * fileio.c (report_file_errno): Fix errno reporting bug.
2482 If the file name is neither null nor a pair, package it up as a
2483 singleton list. All callers changed, both to this function and to
2484 report_file_error. This fixes a bug where the memory allocator
2485 invoked by list1 set errno so that the immediately following
2486 report_file_error reported the wrong errno value.
2487
c43843aa
PE
2488 Fix minor problems found by --enable-gcc-warnings.
2489 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2490 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2491
18c26d81
JD
24922013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2493
2494 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2495 Set event->arg to Qt if switch-event shall be generated.
2496 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2497
2498 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2499
2500 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2501 FOCUS_OUT_EVENT.
2502
2503 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2504 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2505 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2506 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2507 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2508 and there is a focused frame.
2509 (head_table): Add focus-in and focus-out.
2510 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2511 bind to handle-focus-in/out.
2512
2513 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2514 (Fhandle_switch_frame): Call Fhandle_focus_in.
2515 (syms_of_frame): defsubr handle-focus-in/out.
2516
6c6f1994
PE
25172013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2518
c7ddc792
PE
2519 Fix porting bug to older POSIXish platforms (Bug#14862).
2520 * sysdep.c (emacs_pipe): New function, that implements
2521 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2522 This should port better to CentOS 5 and to Mac OS X 10.6.
2523 All calls to pipe2 changed.
2524
6c6f1994
PE
2525 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2526 This makes the code easier to read and the executable a bit smaller.
2527 Do not replace all calls to Fcons that happen to create lists,
2528 just calls that are intended to create lists. For example, when
2529 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2530 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2531 Similarly for list2 through list5.
2532 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2533 * bytecode.c (exec_byte_code):
2534 * callint.c (quotify_arg, Fcall_interactively):
2535 * callproc.c (Fcall_process, create_temp_file):
2536 * charset.c (load_charset_map_from_file)
2537 (Fdefine_charset_internal, init_charset):
2538 * coding.c (get_translation_table, detect_coding_system)
2539 (Fcheck_coding_systems_region)
2540 (Fset_terminal_coding_system_internal)
2541 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2542 * composite.c (update_compositions, Ffind_composition_internal):
2543 * dired.c (directory_files_internal, file_name_completion)
2544 (Fsystem_users):
2545 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2546 * doc.c (Fsnarf_documentation):
2547 * editfns.c (Fmessage_box):
2548 * emacs.c (main):
2549 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2550 (Feval, eval_sub, Ffuncall, apply_lambda):
2551 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2552 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2553 (Fset_file_times, Finsert_file_contents)
2554 (Fchoose_write_coding_system, Fwrite_region):
2555 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2556 * font.c (font_registry_charsets, font_parse_fcname)
2557 (font_prepare_cache, font_update_drivers, Flist_fonts):
2558 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2559 * frame.c (make_frame, Fmake_terminal_frame)
2560 (x_set_frame_parameters, x_report_frame_params)
2561 (x_default_parameter, Fx_parse_geometry):
2562 * ftfont.c (syms_of_ftfont):
2563 * image.c (gif_load):
2564 * keyboard.c (command_loop_1):
2565 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2566 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2567 (Fminor_mode_key_binding, accessible_keymaps_1)
2568 (Faccessible_keymaps, Fwhere_is_internal):
2569 * lread.c (read_emacs_mule_char):
2570 * menu.c (find_and_return_menu_selection):
2571 * minibuf.c (get_minibuffer):
2572 * nsfns.m (Fns_perform_service):
2573 * nsfont.m (ns_script_to_charset):
2574 * nsmenu.m (ns_popup_dialog):
2575 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2576 (Fx_own_selection_internal):
2577 * nsterm.m (append2):
2578 * print.c (Fredirect_debugging_output)
2579 (print_prune_string_charset):
2580 * process.c (Fdelete_process, Fprocess_contact)
2581 (Fformat_network_address, set_socket_option)
2582 (read_and_dispose_of_process_output, write_queue_push)
2583 (send_process, exec_sentinel):
2584 * sound.c (Fplay_sound_internal):
2585 * textprop.c (validate_plist, add_properties)
2586 (Fput_text_property, Fadd_face_text_property)
2587 (copy_text_properties, text_property_list, syms_of_textprop):
2588 * unexaix.c (report_error):
2589 * unexcoff.c (report_error):
2590 * unexsol.c (unexec):
2591 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2592 (Fformat_mode_line, syms_of_xdisp):
2593 * xfaces.c (set_font_frame_param)
2594 (Finternal_lisp_face_attribute_values)
2595 (Finternal_merge_in_global_face, syms_of_xfaces):
2596 * xfns.c (x_default_scroll_bar_color_parameter)
2597 (x_default_font_parameter, x_create_tip_frame):
2598 * xfont.c (xfont_supported_scripts):
2599 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2600 (menu_help_callback, xmenu_show):
2601 * xml.c (make_dom):
2602 * xterm.c (set_wm_state):
2603 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2604 and similarly for list2 through list5.
2605
bafe80ce
PE
26062013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * callproc.c (Fcall_process_region): Fix minor race and tune.
2609 (create_temp_file): New function, with the temp-file-creation part
2610 of the old Fcall_process_region. Use Fcopy_sequence to create the
2611 temp file name, rather than alloca + build_string, for simplicity.
2612 Don't bother to block input around the temp file creation;
068f9124
SM
2613 shouldn't be needed. Simplify use of mktemp.
2614 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2615 this closes an unlikely race where the temp file was not removed.
2616 Use memcpy rather than an open-coded loop.
2617 (Fcall_process_region): Use the new function. If the input is
2618 empty, redirect from /dev/null rather than from a newly created
2619 empty temp file; this avoids unnecessary file system traffic.
2620
4700b5a5
PE
26212013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2622
5c97beae
PE
2623 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2624 Simplify by making this case like the other two. This is a bit
2625 slower on obsolete hosts, but the extra complexity isn't worth it.
2626
4700b5a5
PE
2627 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2628 * process.c (create_process) [!DOS_NT]:
2629 Remove now-unnecessary calls to emacs_close.
2630
f9a74c4c
EZ
26312013-07-13 Eli Zaretskii <eliz@gnu.org>
2632
922ae7ee
EZ
2633 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2634 returning early. (Bug#14850)
2635
f9a74c4c
EZ
2636 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2637 and inhibit-iso-escape-detection attributes of 'undecided'.
2638 (Bug#14822)
2639
5e301d76
PE
26402013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2641
69e0e5ee
PE
2642 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2643 Reported by Herbert J. Skuhra in
2644 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2645
5e301d76
PE
2646 Don't lose top specpdl entry when memory is exhausted.
2647 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2648 specpdl overflow here, to simplify callers; all callers changed.
2649 Always reserve an unused entry at the stack top; this avoids
2650 losing the top entry's information when memory is exhausted.
2651
7e649856
PE
26522013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2653
a773ed9a
PE
2654 Clean up errno reporting and fix some errno-reporting bugs.
2655 * callproc.c (Fcall_process):
2656 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2657 * process.c (create_process, Fmake_network_process):
2658 * unexaix.c (report_error):
2659 * unexcoff.c (report_error):
2660 Be more careful about reporting the errno of failed operations.
2661 The code previously reported the wrong errno sometimes.
2662 Also, prefer report_file_errno to setting errno + report_file_error.
2663 (Fcall_process): Look at openp return value rather than at path,
2664 as that's a bit faster and clearer when there's a numeric predicate.
2665 * fileio.c (report_file_errno): New function, with most of the
2666 old contents of report_file_error.
2667 (report_file_error): Use it.
2668 (Ffile_exists_p, Ffile_accessible_directory_p):
2669 Set errno to 0 when it is junk.
2670 * fileio.c (Faccess_file):
2671 * image.c (x_create_bitmap_from_file):
2672 Use faccessat rather than opening the file, to avoid the hassle of
2673 having a file descriptor open.
2674 * lisp.h (report_file_errno): New decl.
2675 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2676
7e649856
PE
2677 Minor EBADF fixes.
2678 * process.c (create_process, wait_reading_process_output) [AIX]:
2679 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2680 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2681 a multithreaded environment anyway).
2682 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2683
f6774c1a
AS
26842013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2685
2686 * image.c (x_find_image_file): Don't close a remote file handle.
2687
bacba3c2
PE
26882013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2689
2690 Fix races with threads and file descriptors.
2691 * callproc.c (Fcall_process_region):
2692 * dired.c (open_directory):
2693 * emacs.c (main, Fdaemon_initialized):
2694 * image.c (x_find_image_file):
2695 * inotify.c (Finotify_rm_watch):
2696 * lread.c (Flocate_file_internal):
2697 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2698 * term.c (term_mouse_moveto, init_tty):
2699 * termcap.c (tgetent):
2700 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2701 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2702 * unexhp9k800.c, unexmacosx.c (unexec):
2703 * callproc.c (Fcall_process_region):
2704 Use emacs_close, not close.
2705 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2706 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2707 and posix_close function on current platforms (which all lack them).
2708 (emacs_close): Use it. This should fix the races on GNU/Linux and
2709 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2710 and it should avoid closing random victim file descriptors on
2711 other platforms.
2712
653d4f43
PE
27132013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2714
c8536ec4
PE
2715 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2716 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2717 Touch up doc a bit.
2718
9c203066
PE
2719 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2720 This is for .gdbinit xbacktrace.
2721
653d4f43
PE
2722 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2723 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2724 (emacs_set_tty): Now static.
2725 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2726 * term.c (tty_capable_p, tty_default_color_capabilities)
2727 (get_tty_terminal, term_mouse_movement)
2728 (handle_one_term_event, init_tty, maybe_fatal):
2729 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2730 (tgetent, scan_file, name_match, compare_contin):
2731 * terminal.c (get_terminal):
2732 Use bool for boolean.
2733 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2734 Prefer char to unsigned char if either will do.
2735 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2736 (tty_write_glyphs): Prefer int to unsigned.
2737 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2738 All callers changed.
2739 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2740
45b683a1
PE
27412013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2742
29abe551
PE
2743 Port to C89.
2744 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2745 (B__dummy__): New dummy symbol, to pacify C89.
2746 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2747 they can't grok varargs macros.
2748 * dispnew.c (add_window_display_history)
2749 (add_frame_display_history):
2750 * print.c (print_object):
2751 * xdisp.c (debug_method_add):
2752 Use %p printf format only for void pointers.
2753 * emacs.c (usage_message): New constant, replacing ...
2754 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2755 (main): Adjust to usage reorg.
2756 * fns.c (syms_of_fns):
2757 * profiler.c (syms_of_profiler):
2758 Don't use non-constant struct initializers.
2759 * gnutls.h (gnutls_initstage_t):
2760 * lisp.h (enum Lisp_Fwd_Type):
2761 * lread.c (lisp_file_lexically_bound_p):
2762 * xsettings.c (anonymous enum):
2763 Remove trailing comma.
2764 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2765 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2766 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2767 (DEFUN): Use it.
2768 * regex.c (const_re_char): New type, to pacify strict C89.
2769 All uses of 'const re_char' replaced to use it.
2770 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2771 with glibc when strict C89. This change is imported from gnulib.
2772 All uses changed.
2773 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2774 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2775 Omit GNU_LINUX implementation, since it requires long long.
2776 * xterm.c (x_draw_underwave):
2777 Do not assume the traditional order of struct's members.
2778 (x_term_init): Rewrite to avoid the need for non-constant structure
2779 initializers.
2780
45b683a1 2781 Syntax cleanup, mostly replacing macros with functions.
763a086d 2782 This removes the need for the syntax_temp hack.
45b683a1
PE
2783 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2784 * syntax.c (SYNTAX_INLINE): New macro.
2785 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2786 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2787 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2788 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2789 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2790 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2791 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2792 Now constants, not macros.
2793 (syntax_temp) [!__GNUC__]: Remove.
2794 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2795 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2796 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2797 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2798 Move here from syntax.h; now functions, not macros. Except for the
2799 last function, these are static since only syntax.c uses them.
2800 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2801 All uses changed. Now a function, not a macro; use this fact
2802 to simplify the code.
2803 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2804 compiler bugs; no longer relevant.
2805 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2806 (SYNTAX_INLINE): New macro.
2807 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2808 for the new functions. Use bool for boolean member.
2809 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2810 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2811 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2812 (SETUP_BUFFER_SYNTAX_TABLE):
2813 Now extern inline functions, not macros.
2814 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2815 Remove; all uses replaced by implementation.
2816 (syntax_temp) [!__GNUC__]: Remove decl.
2817 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2818
29be4a50
JD
28192013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2820
2821 * emacs.c (main): Fix syntax error.
2822
954b166e
PE
28232013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2824
2825 Timestamp fixes for undo (Bug#14824).
2826 * atimer.c (schedule_atimer):
2827 * fileio.c (Ffile_newer_than_file_p):
2828 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2829 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2830 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2831 (syms_of_fileio): Remove Sclear_visited_file_name.
2832 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2833 file doesn't exist; this avoids an ambiguity with negative timestamps.
2834 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2835 * systime.h (make_emacs_time, invalid_emacs_time):
2836 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2837 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2838 * undo.c (record_first_change): Push (visited-file-modtime) onto
2839 undo list rather than reimplementing it by hand, incorrectly.
2840
d74647c3
KB
28412013-07-09 Ken Brown <kbrown@cornell.edu>
2842
2843 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2844
3c51b96b
JB
28452013-07-09 Juanma Barranquero <lekktu@gmail.com>
2846
2847 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2848
4ebbdd67
PE
28492013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2850
2851 Handle errno and exit status a bit more carefully.
2852 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2853 number into an exit status. Instead, use EXIT_CANCELED.
2854 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2855 * callproc.c (relocate_fd):
2856 * emacs.c (close_output_streams, main):
2857 * process.c (create_process):
2858 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2859 Use emacs_perror for simplicity.
2860 * callproc.c (relocate_fd, main):
2861 * sysdep.c (sys_subshell):
2862 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2863 (shut_down_emacs): Use emacs_write, not write.
2864 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2865 * fileio.c (Fcopy_file, e_write):
2866 * nsterm.m (ns_select):
2867 * process.c (send_process):
2868 * sound.c (vox_write):
2869 Use emacs_write_sig, not emacs_write.
2870 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2871 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2872 New constants.
2873 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2874 of write.
2875 (emacs_full_write): New function.
2876 (emacs_write): Rewrite to use it.
2877 (emacswrite_sig, emacs_perror): New functions.
2878 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2879
44e18199 28802013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2881
2882 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2883 on NS even if it is present. Pixmap on NS is a void*.
2884
9caab067
PE
28852013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 Port to Ubuntu 10 (Bug#14803).
2888 Problem reported by T.V. Raman.
2889 * process.c (close_on_exec, accept4, process_socket):
2890 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2891
1d442672
EZ
28922013-07-07 Eli Zaretskii <eliz@gnu.org>
2893
2894 * w32.c (sys_dup): Declare prototype.
2895
2896 * filelock.c:
2897 * emacs.c:
2898 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2899
067428c1
PE
29002013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2901
2902 Make file descriptors close-on-exec when possible (Bug#14803).
2903 This simplifies Emacs a bit, since it no longer needs to worry
2904 about closing file descriptors by hand in some cases.
2905 It also fixes some unlikely races. Not all such races, as
2906 libraries often open files internally without setting
2907 close-on-exec, but it's an improvement.
2908 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2909 * callproc.c (Fcall_process) [!MSDOS]:
2910 * emacs.c (main) [!DOS_NT]:
2911 * nsterm.m (ns_term_init):
2912 * process.c (create_process):
2913 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2914 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2915 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2916 Prefer mkostemp with O_CLOEXEC to mkstemp.
2917 * callproc.c (relocate_fd) [!WINDOWSNT]:
2918 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2919 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2920 now using pipe2.
2921 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2922 Make the resulting file descriptor close-on-exec.
2923 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2924 * lread.c (load_descriptor_list, load_descriptor_unwind):
2925 Remove; no longer needed. All uses removed.
2926 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2927 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2928 New functions.
2929 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2930 (Fmake_network_process, Fnetwork_interface_list):
2931 (Fnetwork_interface_info, server_accept_connection):
2932 Make newly-created socket close-on-exec.
2933 * sysdep.c (emacs_open, emacs_fopen):
2934 Make new-created descriptor close-on-exec.
2935 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2936 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2937
0da857dd
JD
29382013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2939
2940 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2941 for NS_IMPL_GNUSTEP.
2942
5f86adcd
PE
29432013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2944
2945 Fix openp errno handling.
2946 * callproc.c (Fcall_process): Preserve openp errno around close.
2947 * lread.c (openp): Set errno when returning -1, as some callers
2948 expect this.
2949
1afb1d07
JD
29502013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2951
2952 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2953
2954 * nsterm.h (NSSavePanel): Update comment.
2955 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2956 (ns_run_file_dialog): Declare.
2957
2958 * nsfns.m: Remove panelOK.
2959 (ns_fd_data): New.
2960 (ns_run_file_dialog): New function.
2961 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2962 event loop, so file dialog is popped up by ns_run_file_dialog, called
2963 by sendEvent (Bug#14578).
2964 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2965
3323c263
EZ
29662013-07-06 Eli Zaretskii <eliz@gnu.org>
2967
fdda0220
EZ
2968 * xdisp.c (default_line_pixel_height): New function.
2969 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2970 (try_cursor_movement, redisplay_window, try_window)
2971 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2972
068f9124
SM
2973 * window.c (window_scroll_pixel_based):
2974 use default_line_pixel_height.
fdda0220
EZ
2975
2976 * dispextern.h (default_line_pixel_height): Add prototype.
2977
2978 * frame.c (x_set_line_spacing): Accept a float value for
2979 line-spacing parameter, per the documentation.
2980
3323c263
EZ
2981 * data.c (Fmultibyte_string_p): Doc fix.
2982
47ba6d43
PE
29832013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2984
406af475
PE
2985 Use emacs_open more consistently when opening files.
2986 This handles EINTR more consistently now, and makes it easier
2987 to introduce other uniform changes to file descriptor handling.
2988 * src/systdio.h: New file.
2989 * src/buffer.c (mmap_init):
2990 * cygw32.c (chdir_to_default_directory):
2991 * dispnew.c (Fopen_termscript):
2992 * emacs.c (Fdaemon_initialized):
2993 * fileio.c (Fdo_auto_save):
2994 * image.c (slurp_file, png_load_body, jpeg_load_body):
2995 * keyboard.c (Fopen_dribble_file):
2996 * lread.c (Fload):
2997 * print.c (Fredirect_debugging_output):
2998 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2999 * termcap.c (tgetent):
3000 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3001 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3002 * w32term.c (w32_initialize) [CYGWIN]:
3003 * xfaces.c (Fx_load_color_file):
3004 Use emacs_open instead of plain open, and emacs_fopen instead of
3005 plain fopen.
3006 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3007 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3008 * callproc.c (default_output_mode): New constant.
3009 (Fcall_process): Use it to call emacs_open instead of plain creat.
3010 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3011 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3012 (emacs_fopen): New function.
3013 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3014 Include <lisp.h>, for emacs_open.
3015 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3016
47ba6d43
PE
3017 Remove duplicate #include directives.
3018 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3019 * xfaces.c:
3020 Don't include stdio.h twice.
3021 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3022 Don't include sys/types.h or stdio.h twice.
3023 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3024 * lread.c: Don't include coding.h twice.
3025 * nsfont.m: Don't include frame.h twice.
3026 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3027 * ralloc.c: Don't include <unistd.h> twice.
3028 * xdisp.c: Don't include font.h twice.
3029 * xterm.c: Don't include fontset.h twice.
3030 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3031
b9ed53d5
PE
30322013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3033
3034 Scale ImageMagick images more carefully.
3035 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3036 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3037 Be more careful about avoiding undefined behavior after
3038 integer overflow and division by zero.
3039
cf13177e
YM
30402013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3041
3042 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3043 (syms_of_w32fns): DEFSYM them.
3044 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3045 (CCHDEVICENAME): Define macros if not defined.
3046 (struct MONITOR_INFO_EX): New struct.
3047 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3048 (enum_display_monitors_fn): New variable.
3049 (globals_of_w32fns): Initialize it.
3050 (Fx_display_pixel_width, Fx_display_pixel_height)
3051 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3052 multi-monitor setups in docstrings.
3053 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3054 screen size by primary monitor's millimeter per pixel.
3055 (w32_monitor_enum, w32_display_monitor_attributes_list)
3056 (w32_display_monitor_attributes_list_fallback)
3057 (Fw32_display_monitor_attributes_list): New functions.
3058 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3059
3060 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3061 if not defined.
3062 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3063
86dfb7a8
MA
30642013-07-04 Michael Albinus <michael.albinus@gmx.de>
3065
3066 * fileio.c (Qfile_notify_error): New error symbol.
3067
3068 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3069 * inotify.c (inotify_callback, symbol_to_inotifymask)
3070 (Finotify_add_watch, Finotify_rm_watch): Use it.
3071 (inotifyevent_to_event): Exchange order of cookie and file name.
3072 (Finotify_add_watch): Adapt docstring.
3073
3074 * lisp.h (Qfile_notify_error): Declare.
3075
2c1c974b
PE
30762013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3079 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3080 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3081 which did not work (see <http://bugs.gnu.org/14569#307>).
3082 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3083 && (!noninteractive || initialized)). This attempts to thread
3084 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3085
7a35b20f
JB
30862013-07-04 Juanma Barranquero <lekktu@gmail.com>
3087
3088 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3089 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3090
1ce5cd04
PE
30912013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3092
3093 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3094 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3095 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3096 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3097
57f8c490
PE
30982013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3099
3100 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3101 Define to __sys_siglist.
3102
bcffb5ca
EZ
31032013-07-02 Eli Zaretskii <eliz@gnu.org>
3104
3105 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3106 word-wrap, so that overflow-newline-into-fringe would work in
3107 visual-line-mode. (Bug#2749)
3108 (move_it_in_display_line_to): When the last scanned display
3109 element fits exactly on the display line, and
3110 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3111 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3112 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3113 finding buffer position that corresponds to pixel coordinates,
3114 e.g. in buffer_posn_from_coords.
3115
2c41e781
JD
31162013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3117
3118 * process.c (handle_child_signal): Call catch_child_signal if
3119 NS_IMPL_GNUSTEP.
3120
c2418359
PE
31212013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3122
52a9bcae
PE
3123 Don't convert function pointers to void * and back.
3124 It isn't portable C, and it's easy enough to avoid.
3125 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3126 (make_save_value): Add support for SAVE_FUNCPOINTER.
3127 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3128 * print.c (print_object):
3129 Distinguish function from object pointers.
3130 * lisp.h (SAVE_FUNCPOINTER): New constant.
3131 (SAVE_SLOT_BITS): Adjust to it.
3132 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3133 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3134 (voidfuncptr): New typedef.
3135 (struct Lisp_Save_Value): New member data[0].funcpointer.
3136 (XSAVE_FUNCPOINTER): New function.
3137
c2418359
PE
3138 Simplify buildobj processing.
3139 * Makefile.in (buildobj.h): Make it a sequence of strings each
3140 followed by comma, rather than a single string. Put it into a
3141 .tmp file in case there's an error while generating it.
3142 (gl-stamp): Use .tmp for temp files.
3143 (mostlyclean): Clean .tmp files.
3144 * doc.c (buildobj): Move to just the routine that needs it.
3145 It's now an array of strings, so processing is simpler.
3146
8f43ce49
PE
31472013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3150 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3151 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3152 Invoke malloc_enable_thread even when not interactive.
3153 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3154 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3155 in this case, since the underlying bug has now been fixed.
3156
24827db9
JB
31572013-07-01 Juanma Barranquero <lekktu@gmail.com>
3158
3159 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3160 unlinking it (bug#14691).
3161
ef099a94
MN
31622013-06-30 Michal Nazarewicz <mina86@mina86.com>
3163
3164 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3165 before checking whether buffer is modified. This lets
3166 `kill-buffer-query-functions' cancel killing of the buffer or save
3167 its content before `kill-buffer' asks user the "Buffer %s
3168 modified; kill anyway?" question.
3169
9d3f2fc2
JD
31702013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3171
3172 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3173 Let the super performKeyEquivalent deal with them (Bug#14747).
3174
e6c6c8c7
PE
31752013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3176
1d71c1d9
PE
3177 * widget.c (resize_cb): Remove unused local.
3178
8f5f35cc
PE
3179 Do not use GTK 3 if it exists but cannot be compiled.
3180 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3181 * xterm.c (x_error_handler) [!USE_GTK]:
3182 Do not use GTK 3.
3183
e6c6c8c7
PE
3184 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3185
0ba54312
EZ
31862013-06-30 Eli Zaretskii <eliz@gnu.org>
3187
5d1c3286
EZ
3188 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3189 to the valid range of values. (Bug#14753)
3190
0ba54312
EZ
3191 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3192 when moving point by using the current glyph matrix. This avoids
3193 the need to force redisplay when this function is called in a
3194 loop.
3195
9c90cc06
PE
31962013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3197
3198 Fix minor problems found by static checking.
3199 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3200 Redo the latter's body to sidestep GCC parenthesization warnings.
3201 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3202 * coding.c (detect_coding, detect_coding_system):
3203 * coding.h (struct undecided_spec):
3204 Use bool for boolean.
3205 * image.c (QCmax_width, QCmax_height): Now static.
3206 * xdisp.c (Fmove_point_visually): Remove unused local.
3207
4c672a0f
EZ
32082013-06-29 Eli Zaretskii <eliz@gnu.org>
3209
3210 * xdisp.c (Fmove_point_visually): New function.
3211
c1ea3abf
JB
32122013-06-28 Kenichi Handa <handa@gnu.org>
3213
3214 * coding.h (define_coding_undecided_arg_index): New enum.
3215 (coding_attr_index): New members
3216 coding_attr_undecided_inhibit_null_byte_detection,
3217 coding_attr_undecided_inhibit_iso_escape_detection,
3218 coding_attr_undecided_prefer_utf_8.
3219 (undecided_spec): New struct.
3220 (struct coding_system): New member `undecided' of the member
3221 `spec'.
3222
3223 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3224 (detect_coding): Likewise.
3225 (detect_coding_system): Likewise.
3226 (Fdefine_coding_system_internal): New coding system properties
3227 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3228 :prefer-utf-8.
3229 (syms_of_coding): Adjust for coding_arg_undecided_max.
3230
ba3de9e6
PE
32312013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 * image.c (x_from_xcolors): Remove unused local.
3234
547c9269
YM
32352013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3236
3237 Defer image data transfer between X client and server until actual
3238 display happens.
3239
3240 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3241 and `mask_img'.
3242
3243 * image.c (Destroy_Image): Remove.
3244 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3245 `mask_p', and `colors_p'. All uses changed.
3246 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3247 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3248 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3249 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3250 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3251 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3252 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3253 (image_get_x_image, image_unget_x_image): New functions or macros.
3254 (image_background, image_background_transparent, x_to_xcolors)
3255 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3256 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3257 instead of Destroy_Image.
3258 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3259 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3260 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3261 (imagemagick_load_image, svg_load_image): Use them instead of
3262 x_create_x_image_and_pixmap, and x_put_x_image followed by
3263 x_destroy_x_image, respectively.
3264 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3265 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3266 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3267 background_transparent fields.
3268 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3269 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3270
dae2f5ef
PE
32712013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3272
3273 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3274 This mostly consists of undoing recent changes.
3275 * callproc.c (Fcall_process):
3276 * process.c (create_process):
3277 Do not worry about catching SIGCHLD here, undoing previous change.
3278 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3279 * process.c, process.h (catch_child_signal):
3280 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3281 * process.c (catch_child_handler): Don't worry about being called
3282 lazily and do not assume caller has blocked SIGCHLD, undoing
3283 previous change. Move first-time stuff back to
3284 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3285 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3286 set lib_child_handler if it's already initialized, which may
3287 help avoid problems on GNUStep.
3288
fa55d2aa
PE
32892013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3290
3291 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3292 * callproc.c (Fcall_process):
3293 * process.c (create_process):
3294 Make sure SIGCHLD is caught before we fork,
3295 since Emacs startup no arranges to catch SIGCHLD.
3296 * process.c (lib_child_handler): Initialize to null, not to
3297 dummy_handler.
3298 (catch_child_signal): Allow self to be called lazily.
3299 Do nothing if it's already been called.
3300 Assume caller has blocked SIGCHLD (all callers do now).
3301 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3302 just before it's really needed.
3303 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3304 since it hasn't been caught yet.
3305
f3f9606c
LMI
33062013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3307
3308 * image.c (compute_image_size): New function to implement
3309 :max-width and :max-height.
3310 (imagemagick_load_image): Use it.
3311
c7041908
PE
33122013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3313
3314 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3315 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3316 Now extern.
3317 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3318 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3319 the SIGCHLD handler, since the code is not atomic and (due to glib)
3320 signals may be arriving now.
3321 * sysdep.c (init_signals): Do not catch child signals here;
3322 'main' now does that later, at a safer time.
3323
f86852b4
PE
33242013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3325
0dfeed58
PE
3326 Clean up SIGCHLD handling a bit (Bug#14569).
3327 * process.c, process.h (catch_child_signal):
3328 Now always extern, even if !NS_IMPL_GNUSTEP.
3329 * process.c (catch_child_signal): Move glib tickler here from
3330 init_process_emacs, so that it's done earlier in Emacs
3331 initialization. Also move the noninteractive && !initialized
3332 check here from init_process_emacs. This is all a bit cleaner for
3333 GNUish platforms, and I hope it works around the Cygwin bug.
3334 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3335 that glib signal handling is tickled before glib creates threads.
3336
f86852b4
PE
3337 * process.c (wait_reading_process_output): Avoid int overflow
3338 when reading more than 2 GiB total from a process.
3339
cbd6509c
PE
33402013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * process.c (create_process): Handle a couple more cases,
3343 i.e., work even if new_argv and wait_child_setup[i] are cached.
3344 Use Fcall_process's style for volatile vars.
3345
9de1114a
AS
33462013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3347
3348 * process.c (create_process): Mark PROCESS volatile.
3349
fbe9e0b9
PE
33502013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3351
3352 Use C99-style flexible array members if available.
3353 This avoids some subtle aliasing issues, which typically
3354 aren't a problem with GCC but may be a problem elsewhere.
3355 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3356 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3357 In either case, it uses a flexible array member rather than
3358 the old struct hack. All uses changed.
3359 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3360 Adjust to sdata reorganization.
3361 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3362 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3363 that ports better to pre-C99 non-GCC.
3364 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3365 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3366 as the latter has changed.
3367 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3368 and port better to pre-C99 GCC.
3369 * image.c (struct xpm_cached_color):
3370 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3371 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3372 Use FLEXIBLE_ARRAY_MEMBER.
3373 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3374 Move decl to top level so it gets checked against implementation.
3375 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3376 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3377
1fc71008
PE
33782013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 * syntax.c: Integer cleanups.
3381 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3382 All uses that need 0-or-2 changed to:
3383 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3384 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3385 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3386 (char_quoted, prev_char_comend_first, back_comment)
3387 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3388 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3389 Use bool for boolean.
3390 (update_syntax_table, skip_chars, skip_syntaxes):
3391 Prefer int to unsigned when either will do.
3392 (back_comment): Return boolean success flag, like forw_comment,
3393 instead of positive-or-minus-1 (which might have overflowed int anyway).
3394 Don't stuff ptrdiff_t into int.
3395 (syntax_spec_code, syntax_code_spec): Now const.
3396 (Fmatching_paren, scan_lists, scan_sexps_forward):
3397 Use enum syntaxcode for syntax code.
3398 (Fmatching_paren): Check that arg is a character, not just an integer.
3399 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3400 (Finternal_describe_syntax_value): Omit no-longer-needed
3401 comparison to 0.
3402 (skip_chars): Use char, not unsigned char, when the distinction
3403 doesn't matter.
3404 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3405 * bytecode.c (exec_byte_code):
3406 * syntax.c (syntax_spec_code, Fchar_syntax)
3407 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3408 (init_syntax_once):
3409 * syntax.h (SYNTAX_WITH_FLAGS):
3410 Omit unnecessary casts.
3411
b932cad7
EZ
34122013-06-20 Eli Zaretskii <eliz@gnu.org>
3413
3414 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3415 line dimensions here, to avoid race conditions with the main
3416 thread. (Bug#14062, bug#14630, bug#14669)
3417
3418 * w32term.c (w32_draw_window_cursor): Compute the header line and
3419 mode line dimensions here.
3420 <w32_system_caret_window, w32_system_caret_hdr_height>:
3421 <w32_system_caret_mode_height>: New variables.
3422
3423 * w32term.h: Declare them.
3424
89561f72
PE
34252013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3426
5013fc08
PE
3427 * alloc.c (die): Move "assertion failed" string here ...
3428 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3429 COND when SUPPRESS_CHECKING. This shrinks the executable text
3430 size by 0.8% to 2.2% when configured with --enable-checking,
3431 depending on optimization flags (GCC 4.8.1 x86-64).
3432
89561f72
PE
3433 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3434
763a086d 34352013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3436
3437 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3438 base is 2; this is more accurate.
3439
983aeb9a
JB
34402013-06-19 Juanma Barranquero <lekktu@gmail.com>
3441
3442 * sound.c (string_default): Move to !WINDOWSNT section.
3443 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3444
178ba3e6
PE
34452013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3446
bbc51b15
PE
3447 * sound.c: Integer cleanups.
3448 Remove unnecessary forward decls.
3449 (struct sound_device): The 'file' member is now a Lisp_Object, not
3450 a char *, so that we needn't invoke alloca on a huge size.
3451 (Fplay_sound_internal): Adjust to this.
3452 (string_default): New function.
3453 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3454 Use it to adjust to the struct sound_device change.
3455 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3456 (be2hs) [0]: Remove.
3457
178ba3e6
PE
3458 * syntax.c (skip_chars): Don't use uninitialized storage
3459 when searching a multibyte buffer for characters that are not in a
3460 unibyte string that contains non-ASCII characters.
3461
69f60cdc
JD
34622013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3463
3464 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3465 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3466
0d6224d4
PE
34672013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3468
3469 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3470
3c542890
KH
34712013-06-18 Kenichi Handa <handa@gnu.org>
3472
f7e3f7cd
KH
3473 * font.c (Ffont_spec): Signal an error for an invalid font name
3474 (Bug#14648).
3c542890 3475
9349e5f7
PE
34762013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3477
3478 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3479 In particular this ports to 32-bit sparc Sun cc.
3480 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3481 array with a dummy element at specpdl[-1], so that its address can
3482 be taken portably.
3483 (unbind_to): Do not copy the binding; not needed, now that we
3484 copy old_value in the one place where the copy is needed.
3485 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3486 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3487 (union specbinding): Rename from struct specbinding. Redo layout
3488 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3489 which is not portable. With Sun C 5.12 32-bit sparc, the
3490 declaration causes nargs to be an unsigned bitfield, a behavior
3491 that the C standard allows; but Emacs wants nargs to be signed.
3492 The overall type is now a union of structures rather than a
3493 structure of union of structures, and the 'kind' member is now a
3494 bitfield, so that the overall type doesn't grow. All uses changed.
3495 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3496
0a4df6a5
PE
34972013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3498
ec6ecaad
PE
3499 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3500 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3501
0a4df6a5
PE
3502 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3503
7bfe8dbc
EZ
35042013-06-17 Eli Zaretskii <eliz@gnu.org>
3505
3506 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3507 unless we know that the window w's frame is a frame object.
3508 Another attempt at solving bug#14062 and bug#14630.
3509
708e05f6
LMI
35102013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3511
3512 * textprop.c (property_set_type): New enum.
3513 (add_properties): Allow appending/prepending text properties.
3514 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3515 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3516 add_text_properties_1.
3517 (Fadd_face_text_property): New function that calls
3518 add_text_properties_1.
3519
84575e67
PE
35202013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 Move functions from lisp.h to individual modules when possible.
3523 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3524 * alloc.c (XFLOAT_INIT, set_symbol_name):
3525 * buffer.c (CHECK_OVERLAY):
3526 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3527 (set_char_table_parent):
3528 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3529 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3530 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3531 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3532 (set_blv_valcell):
3533 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3534 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3535 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3536 (backtrace_args, backtrace_debug_on_exit):
3537 * floatfns.c (CHECK_FLOAT):
3538 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3539 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3540 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3541 (set_hash_index_slot):
3542 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3543 * marker.c (CHECK_MARKER):
3544 * textprop.c (CHECK_STRING_OR_BUFFER):
3545 * window.c (CHECK_WINDOW_CONFIGURATION):
3546 Move here from lisp.h, and make these functions static rather than
3547 extern inline.
3548 * buffer.c (Qoverlayp):
3549 * data.c (Qsubrp):
3550 * fns.c (Qhash_table_p):
3551 * window.c (Qwindow_configuration_p):
3552 Now static.
3553 * lisp.h: Remove the abovementioned defns and decls.
3554
44e18199 3555 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3556 In lisp.h, prefer functions to function-like macros, and
3557 constants to object-like macros, when either will do. This:
3558 . simplifies use, as there's no more need to worry about
3559 arguments' side effects being evaluated multiple times.
3560 . makes the code easier to debug on some platforms.
3561 However, when using gcc -O0, keep using function-like macros
3562 for a few critical operations, for performance reasons.
3563 This sort of thing isn't needed with gcc -Og, but -Og
3564 is a GCC 4.8 feature and isn't widely-enough available yet.
3565 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3566 Remove enum lsb_bits; no longer needed.
3567 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3568 * buffer.c (Qoverlap):
3569 * data.c (Qsubrp):
3570 * fns.c (Qhash_table_p):
3571 Now extern, so lisp.h can use these symbols.
3572 * dispextern.h: Include character.h, for MAX_CHAR etc.
3573 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3574 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3575 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3576 (GLYPH_CODE_P): Move here from lisp.h.
3577 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3578 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3579 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3580 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3581 XUNTAG now returns void *.
3582 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3583 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3584 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3585 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3586 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3587 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3588 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3589 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3590 New macros, renamed from their sans-lisp_h_ counterparts.
3591 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3592 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3593 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3594 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3595 If compiling via GCC without optimization, define these as macros
3596 in addition to inline functions.
3597 To disable this, compile with -DINLINING=0.
3598 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3599 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3600 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3601 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3602 (INTMASK, VALMASK): Now macros, since static values cannot be
3603 accessed from extern inline functions.
3604 (VALMASK): Also a constant, for benefit of old GDB.
3605 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3606 is INTEGERP, which can fold it in.
5165d44a 3607 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3608 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3609 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3610 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3611 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3612 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3613 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3614 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3615 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3616 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3617 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3618 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3619 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3620 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3621 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3622 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3623 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3624 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3625 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3626 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3627 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3628 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3629 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3630 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3631 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3632 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3633 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3634 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3635 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3636 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3637 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3638 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3639 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3640 Now functions.
3641 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3642 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3643 (VALMASK): Define in one place rather than in two, merging the
3644 USE_LSB_TAG parts; this is simpler.
3645 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3646 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3647 Move up, to avoid use before definition.
3648 Also include "globals.h" earlier, for the same reason.
3649 (make_natnum): New function.
3650 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3651 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3652 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3653 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3654 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3655 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3656 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3657 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3658 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3659 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3660 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3661 (Qwindow_configuration_p, Qimage): New forward declarations.
3662 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3663 (STRING_COPYIN): Remove; unused.
3664 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3665 (xcar_addr, xcdr_addr): New functions. All uses changed.
3666 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3667 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3668 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3669 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3670 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3671 (TYPE_RANGED_INTEGERP): Simplify.
3672 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3673 (setlocale, fixup_locale, synchronize_system_messages_locale)
3674 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3675 Now empty functions, not macros.
3676 (functionp): Return bool, not int.
3677 * window.c (Qwindow_configuration_p): Now extern,
3678 so window.h can use it.
3679 * window.h (Qwindowp): Move decl back to lisp.h.
3680
9583ec36
EZ
36812013-06-15 Eli Zaretskii <eliz@gnu.org>
3682
3683 * xdisp.c (Fline_pixel_height): New function, required for solving
3684 bug #14567.
3685
210272ce
PE
36862013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3687
3688 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3689
de0503df
SM
36902013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3691
3692 * lread.c (syms_of_lread):
3693 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3694
afbfe143
KD
36952013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3696
3697 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3698
d177e213
XF
36992013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3700
3701 * fileio.c (expand_file_name): Doc fix.
3702
05e3e412
PE
37032013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3704
f7394b12
PE
3705 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3706 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3707 Wait for self, not for 0. This can't hurt on GNU or similar
3708 system, and may help with Cygwin.
3709
05e3e412
PE
3710 * keyboard.c: Don't use PROP (...) as an lvalue.
3711 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3712 Use set_prop (A, B), not PROP (A) = B.
3713
17dd3097
EZ
37142013-06-10 Eli Zaretskii <eliz@gnu.org>
3715
3716 * xdisp.c (get_it_property): Use it->window instead of generating
3717 a Lisp object from it->w.
3718
52fab9c9
EZ
37192013-06-09 Eli Zaretskii <eliz@gnu.org>
3720
3721 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3722 get-char-property the window that is being rendered, instead of
3723 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3724 (compute_display_string_pos): When W is NULL, use the current
3725 buffer as the object to pass to get-char-property.
3726 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3727 pointer member of the bidi iterator, since no window is pertinent
3728 to this function.
52fab9c9 3729
5bf97bfc
EZ
37302013-06-08 Eli Zaretskii <eliz@gnu.org>
3731
3732 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3733 being displayed, and pass it to compute_display_string_pos.
3734 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3735 (bidi_paragraph_init): All callers changed.
3736
3737 * xdisp.c (init_from_display_pos, init_iterator)
3738 (handle_single_display_spec, next_overlay_string)
3739 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3740 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3741 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3742 (compute_display_string_pos): Accept additional argument, the
3743 window being displayed, and pass it to Fget_char_property.
3744 (Bug#14575)
3745
3746 * dispextern.h (struct bidi_it): New member w, the window being
3747 displayed.
3748 (compute_display_string_pos): Adjust prototype.
3749
5de0e011
JD
37502013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3751
e7b41c4c 3752 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3753
3754 * process.c (wait_reading_process_output): Check for NS before GLIB.
3755 GLIB may be linked in due to rsvg, but ns_select must be called.
3756
5de0e011
JD
3757 * xgselect.c (xg_select): Remove call to window_system_available
3758 and g_main_context_pending at the top, so Gdk events (i.e. file
3759 notify) are processed when Emacs is started with -nw.
3760
a822acff
EZ
37612013-06-07 Eli Zaretskii <eliz@gnu.org>
3762
3763 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3764 (ctagsfiles3): New variable, includes only *.m files.
3765 (TAGS): Use an explicit language name in the regular expressions,
3766 to avoid transformation of '/SOMETHING' by MSYS to
3767 'c:\MSYS\SOMETHING'.
3768
6c0a9ed1
RC
37692013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3770
3771 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3772
9ef6111b
EZ
37732013-06-06 Eli Zaretskii <eliz@gnu.org>
3774
3775 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3776 still need to set the mouse pointer shape and activate help-echo.
3777 (Bug#14558)
3778
7d300d64
PE
37792013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3780
3781 A few porting etc. fixes for the new file monitor code.
3782 See the thread containing
3783 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3784 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3785 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3786 (dir_monitor_callback, Fgfile_rm_watch):
3787 Use assq_no_quit instead of Fassoc, for speed.
3788 (dir_monitor_callback, Fgfile_rm_watch):
3789 eassert that the monitor is a fixnum.
3790 (dir_monitor_callback): No need for CDR_SAFE.
3791 Simplify building of lisp with alternative tails.
3792 (Fgfile_add_watch, Fgfile_rm_watch):
3793 Do not assume glib functions set errno reliably on failure.
3794 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3795 and signal an error otherwise.
3796 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3797 Use Fdelq instead of Fdelete, for speed.
3798
817ebfcf
EZ
37992013-06-05 Eli Zaretskii <eliz@gnu.org>
3800
3801 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3802 don't insist on being invoked on a highlighted tool-bar button.
3803 Avoids losing tool-bar functionality when mouse-highlight is nil.
3804 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3805 Don't highlight when mouse-highlight is nil.
3806 (note_mouse_highlight): When mouse-highlight is nil, don't return
3807 right away; instead, run tool-bar and mode-line highlight
3808 subroutine, clear any existing highlight, and revert the mouse
3809 pointer to its default shape. (Bug#14558)
3810
55577e7c
SM
38112013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3812
3813 * lisp.mk (lisp): Add prog-mode.el.
3814
f019a684
PE
38152013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3816
3817 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3818 * process.c (dummy_handler): New function.
3819 (lib_child_handler): New static var.
3820 (handle_child_signal): Invoke it.
3821 (catch_child_signal): If a library has set up a signal handler,
3822 save it into lib_child_handler.
3823 (init_process_emacs): If using glib and not on Windows, tickle glib's
3824 child-handling code so that it initializes its private SIGCHLD handler.
3825 * syssignal.h (SA_SIGINFO): Default to 0.
3826 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3827 31; it should no longer be needed now.
3828
90db8702
MA
38292013-06-05 Michael Albinus <michael.albinus@gmx.de>
3830
3831 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3832
3833 * gfilenotify.c (globals_of_gfilenotify): New function.
3834 (syms_of_gfilenotify): Move global initialization there.
3835
3836 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3837
bfa3acd6
SM
38382013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3839
3840 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3841 * keyboard.c (menu_bar_items, tool_bar_items):
3842 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3843 not override local keymaps any more.
3844
ba59bd80
EZ
38452013-06-04 Eli Zaretskii <eliz@gnu.org>
3846
3847 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3848
7f203aa1
EZ
38492013-06-03 Eli Zaretskii <eliz@gnu.org>
3850
9337e206
EZ
3851 * w32console.c (initialize_w32_display): Return the dimensions of
3852 the console window via 2 additional arguments, not via the current
3853 frame. This avoids crashes due to overrunning the bounds of
3854 frame's decode_mode_spec_buffer, which is not resized following
3855 the change of the frame dimensions from the initial 10x10.
3856
3857 * w32term.h (w32_initialize_display_info): Adjust prototype.
3858
3859 * term.c (init_tty): Take dimensions of the frame from the values
3860 returned by initialize_w32_display.
3861
7f203aa1
EZ
3862 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3863 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3864 (LIBES): Add $(GFILENOTIFY_LIBS).
3865
3866 * w32inevt.c (handle_file_notifications): Add dummy implementation
3867 for !HAVE_W32NOTIFY.
3868
3869 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3870
55a87246
JD
38712013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3872
3873 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3874
3875 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3876
3877 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3878
3d5ee10a
PE
38792013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 Fix minor problems found by static checking.
3882 * data.c (pure_write_error):
3883 Use xsignal2, not Fsignal, as Fsignal might return.
3884 * eval.c (set_backtrace_debug_on_exit): Now static.
3885 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3886 No longer inline. EXTERN_INLINE is needed only for functions
3887 defined in .h files. Reindent function header as per GNU style.
3888 (backtrace_p, backtrace_top, backtrace_next):
3889 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3890 compiler or linker. Add extern decls to pacify gcc -Wall.
3891 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3892 Now static.
3893 * frame.c (free_monitors): Define only on platforms that need it.
3894 * nsterm.m (ns_term_init):
3895 * process.c (catch_child_signal):
3896 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3897 defined on all porting targets these days.
3898 * process.c, process.h (catch_child_signal):
3899 Make it extern only if NS_IMPL_GNUSTEP is defined.
3900
e2d8a6f0
EZ
39012013-06-03 Eli Zaretskii <eliz@gnu.org>
3902
3903 * w32.c (gettimeofday): Make the signature identical to prototype
3904 in nt/inc/sys/time.h.
3905
a8a7c5f6
SM
39062013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3907
3908 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3909 .gdbinit.
3910
3911 * keyboard.c (safe_run_hooks_error): Improve error message.
3912
3913 * data.c (pure_write_error): Add `object' argument.
3914 * puresize.h (CHECK_IMPURE): Use it.
3915
c9628c79
MA
39162013-06-03 Michael Albinus <michael.albinus@gmx.de>
3917
3918 * Makefile.in (NOTIFY_OBJ): New variable.
3919 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3920
3921 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3922 Call syms_of_gfilenotify.
3923
3924 * gfilenotify.c: New file.
3925
3926 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3927 and Qfile_w32notify.
3928 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3929 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3930
3931 * lisp.h: Declare syms_of_gfilenotify.
3932
3933 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3934
2f592f95
SM
39352013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3936
3937 Merge the specpdl and backtrace stacks. Make the structure of the
3938 specpdl entries more obvious via a tagged union of structs.
3939 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3940 (enum specbind_tag): New enum.
3941 (struct specbinding): Make it a tagged union of structs.
3942 Add a case for backtrace records.
3943 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3944 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3945 (backtrace_debug_on_exit): New accessors.
3946 (struct backtrace): Remove.
3947 (struct catchtag): Remove backlist field.
3948 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3949 Move to eval.c.
3950 (Flocal_variable_p): Speed up the common case where the binding is
3951 already loaded.
3952 * eval.c (backtrace_list): Remove.
3953 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3954 (set_backtrace_args, set_backtrace_nargs)
3955 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3956 (backtrace_next): New functions.
3957 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3958 (unwind_to_catch, internal_lisp_condition_case)
3959 (internal_condition_case, internal_condition_case_1)
3960 (internal_condition_case_2, internal_condition_case_n): Don't bother
3961 with backtrace_list any more.
3962 (Fsignal): Adjust to new backtrace format.
3963 (grow_specpdl): Move up.
3964 (record_in_backtrace): New function.
3965 (eval_sub, Ffuncall): Use it.
3966 (apply_lambda): Adjust to new backtrace format.
3967 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3968 data.c.
3969 (specbind): Adjust to new specpdl format. Simplify.
3970 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3971 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3972 backtrace format.
3973 (mark_backtrace): Remove.
3974 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3975 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3976 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3977 Use mark_specpdl.
3978 * profiler.c (record_backtrace): Use get_backtrace.
3979 (handle_profiler_signal): Use backtrace_top_function.
3980 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3981 accessor functions.
3982
c0342369
JD
39832013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3984
3985 * process.h (catch_child_signal): Declare.
3986
3987 * process.c (catch_child_signal): New function.
3988 (init_process_emacs): Call it.
3989
3990 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3991 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3992 NS_IMPL_COCOA.
3993 (x_set_cursor_type): Remove declaration.
3994 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3995 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3996 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3997 (ns_get_color): Use F suffix on float.
3998 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3999 (ns_get_rgb_color): Remove.
4000 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4001 (note_mouse_movement): x and y are CGFloat.
4002 (ns_draw_fringe_bitmap): Remove unused rowY.
4003 Change #if to COCOA && >= 10_6.
4004 (ns_draw_window_cursor): Remove unused overspill.
4005 (ns_draw_underwave): width and x are EamcsCGFloat.
4006 (ns_draw_box): thickness is CGFloat.
4007 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4008 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4009 if not in main thread.
4010 (ns_get_pending_menu_title, ns_check_menu_open)
4011 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4012 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4013 (sendFromMainThread:): New method.
4014 (changeFont:): size is CGFloat.
4015 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4016 Disable warning about permanent text.
4017 (characterIndexForPoint:): Adjust return type depending on GNUStep
4018 version.
4019 (mouseDown:): delta is CGFloat.
4020 (updateFrameSize): Remove unised variable f.
4021 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4022 Cast float to EmacsCGFloat.
4023 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4024 also to -1 when restoring.
4025 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4026 inside NS_IMPL_COCOA.
4027 (toggleFullScreen:): Put call to toggleFullScreen inside
4028 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4029 (setPosition:portion:whole:): por is CGFloat.
4030 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4031 (mouseDown:): Use CGFloat.
4032 (mouseDragged:): Remove unised variable edge.
4033 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4034
4035 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4036 of CGFloat differs.
4037 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4038 when NS_IMPL_GNUSTEP.
4039 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4040 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4041 (EmacsToolbar): Add clearAll. Add tag argument to
4042 addDisplayItemWithImage.
4043 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4044
4045 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4046
4047 * nsmenu.m (ns_update_menubar): Make static.
4048 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4049 (fillWithWidgetValue:): Add cast to SEL for setAction.
4050 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4051 (update_frame_tool_bar): Update code for GNUStep.
4052 (clearAll): New method.
4053 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4054 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4055 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4056 call to insertItemWithItemIdentifier.
4057 (validateVisibleItems): Fix indentation.
4058 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4059 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4060 UtilityWindow to aStyle, remove call to setStyleMask.
4061
4062 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4063
4064 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4065 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4066 Use F suffix on floats.
4067 (ns_char_width): Returns CGFloat.
4068 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4069 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4070 DPSxshow.
4071 (ns_glyph_metrics): CGFloat instead of float.
4072
a0eb10b3
JB
4073 * nsfns.m (x_set_foreground_color, x_set_background_color):
4074 Use EmacsCGFloat.
4075 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4076 remove unused variables.
4077 (Fns_read_file_name): Keep track if panel is for save.
4078 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4079 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4080 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4081 Just return the input if GNUStep.
c0342369
JD
4082 (x_screen_planes): Remove.
4083 (Fxw_color_values): Use EmacsCGFloat
4084 (Fns_display_monitor_attributes_list): Only get screen number for
4085 Cocoa.
ef099a94 4086 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4087 EmacsSavePanel.
4088 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4089 ns_directory_from_panel.
4090
da9aff11
PE
40912013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4092
4093 * process.c (handle_child_signal): Also use WCONTINUED.
4094 This is so that list-processes doesn't mistakenly list the process
4095 as stopped, when the process has actually been continued and is
4096 now running.
4097
0e64479a
PE
40982013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4099
fc186a96
PE
4100 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4101 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4102 not already configured.
4103
0e64479a
PE
4104 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4105
38b787fa
EZ
41062013-05-29 Eli Zaretskii <eliz@gnu.org>
4107
4108 * Makefile.in (mostlyclean): Remove *.res files.
4109
22513e52
SM
41102013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4111
4112 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4113 a buffer (bug#8447).
4114
6ef3db10
EZ
41152013-05-27 Eli Zaretskii <eliz@gnu.org>
4116
4117 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4118 display vector, and we backtrack, handle the case that the
4119 previous character position is also displayed from a display
4120 vector or covered by a display string or image. (Bug#14476)
4121
6799bb26
JD
41222013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4123
4124 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4125 (struct MonitorInfo, free_monitors): Remove.
4126 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4127 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4128 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4129 Qframes, Qsource.
4130
4131 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4132 (struct MonitorInfo, free_monitors): Remove.
4133 (ns_screen_name): Make static.
4134 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4135 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4136 Qframes, Qsource.
4137
4138 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4139 (struct MonitorInfo): New struct.
4140 (free_monitors, make_monitor_attribute_list): Declare.
4141
22513e52
SM
4142 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4143 New Lisp_Object:s.
6799bb26
JD
4144 (free_monitors, make_monitor_attribute_list): New functions.
4145 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4146 Qsource.
4147
38cd43eb
XF
41482013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4149
4150 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4151
2af0948d
SM
41522013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4153
a7eb9b0f
SM
4154 * keyboard.c: Apply keyboard decoding only to events that come directly
4155 from the tty, not from unread-command-events (bug#14368).
4156 (read_event_from_main_queue): New function, extracted from read_char).
4157 (read_decoded_char): Remove.
4158 (read_decoded_event_from_main_queue): New function to replace it.
4159 (read_char): Use it.
4160 (read_key_sequence): Use read_char rather than read_decoded_char.
4161
2af0948d
SM
4162 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4163
1413e9a5
BR
41642013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4165
4166 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4167
e6d2f155
KH
41682013-05-22 Kenichi Handa <handa@gnu.org>
4169
4170 The following changes are to fix the setting of
4171 buffer-file-coding-system on, for instance, C-x RET c unix RET
4172 _FILE_OF_DOS_EOL_TYPE_ RET.
4173
4174 * coding.h (struct coding_system): New member detected_utf8_chars.
4175
4176 * coding.c (detect_coding_utf_8): Count characters and check EOL
4177 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4178 BOM is there.
4179 (setup_coding_system): Do not initialize coding->head_ascii.
4180 (check_ascii): Do not set coding->eol_seen but update it. Do not
4181 call adjust_coding_eol_type here.
1413e9a5
BR
4182 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4183 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4184 of the found coding-system.
4185 (decode_coding_gap): Cancel previous change. Utilize the
4186 character numbers counted by detect_coding_utf_8. Fix detection
4187 of BOM for utf-8.
4188
ab56a6f4 41892013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4190
4191 * search.c (looking_at_1): Only set last_thing_searched if the match
4192 changed the match-data (bug#14281).
4193
ecc3c6ed
DA
41942013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4195
4196 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4197 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4198 (move_it_vertically_backward): Likewise.
4199
5ba8bf35
YM
42002013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4201
4202 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4203 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4204 (Fx_display_mm_width, Fx_display_mm_height):
4205 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4206
91e8418b 4207 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4208 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4209 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4210 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4211 (Fx_display_backing_store, Fx_display_visual_class)
4212 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4213 (Fx_display_grayscale_p, Fx_display_pixel_width)
4214 (Fx_display_pixel_height, Fx_display_planes)
4215 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4216 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4217 (Fx_display_mm_width, Fx_display_mm_height)
4218 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4219 height for all physical monitors as in X11.
4220
fc30d803
SM
4221 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4222 Return pixel width or height for all physical monitors as in X11.
91e8418b 4223
31ff141c
PE
42242013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4225
4226 Port --enable-gcc-warnings to clang.
4227 * bytecode.c (exec_byte_code):
4228 * regex.c:
4229 Redo diagnostic pragmas to pacify clang, too.
4230 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4231 * editfns.c (Fencode_time):
4232 * fileio.c (file_accessible_directory_p):
4233 * font.c (font_unparse_xlfd):
4234 Use '&"string"[index]' instead of '"string" + (index)'.
4235 * undo.c (user_error): Remove; unused.
4236
df065a0b
EZ
42372013-05-16 Eli Zaretskii <eliz@gnu.org>
4238
04d360e7
EZ
4239 * insdel.c (insert_1_both): Document the arguments, instead of
4240 referring to insert_1, which no longer exists.
4241
5bb98290
EZ
4242 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4243 some window, increment windows_or_buffers_changed, so that
4244 *Messages* display in that window is updated. (Bug#14408)
4245
df065a0b
EZ
4246 * w32.c: Include epaths.h.
4247 (init_environment): Use cmdproxy.exe without leading directories.
4248 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4249 case.
4250 (gettimeofday): Adjust signature and return value to Posix
4251 expectations.
4252
4253 * unexw32.c (open_output_file): Delete the existing emacs.exe
4254 before creating it, to break the hard link to the versioned
4255 executable.
4256
4257 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4258 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4259 (FIRSTFILE_OBJ): New variables.
4260 (W32_RES): Rename to EMACSRES. All users changed.
4261 (base_obj): Use $(CM_OBJ).
4262 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4263 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4264 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4265 $(W32_RES_LINK) before $(LIBES).
4266 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4267
1aa8d505
SM
42682013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4269
6e911150
SM
4270 * makefile.w32-in (DOC): Use just "DOC".
4271
4272 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4273
1aa8d505
SM
4274 * process.c: Export default filters and sentinels to Elisp.
4275 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4276 New constants.
4277 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4278 (Fset_process_sentinel, Fformat_network_address):
4279 Default to them instead of nil.
4280 (server_accept_connection): Sentinels can't be nil any more.
4281 (read_and_dispose_of_process_output): New function, extracted from
4282 read_process_output.
4283 (read_process_output): Use it; filters can't be nil.
4284 (Finternal_default_process_filter): New function, extracted from
4285 read_process_output.
4286 (exec_sentinel_unwind): Remove function.
4287 (exec_sentinel): Don't zilch sentinel while running.
4288 (status_notify): Sentinels can't be nil.
4289 (Finternal_default_process_sentinel): New function extracted from
4290 status_notify.
4291 (setup_process_coding_systems): Default filter is not nil any more.
4292 (syms_of_process): Export new Elisp functions and initialize
4293 new constants.
4294 * lisp.h (make_lisp_proc): New function.
4295
5ac2eb34
SM
42962013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4297
4298 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4299
eda9c7d7
EZ
43002013-05-14 Eli Zaretskii <eliz@gnu.org>
4301
4302 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4303 unless we know that the window w is a leaf window.
4304 Another attempt at solving bug#14062.
eda9c7d7 4305
8fdeaad5
JD
43062013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4307
4308 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4309 fdesc (Bug#14375).
4310
44aa9ee6
PE
43112013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4312
4313 * image.c (gif_load): Check that subimages fit (Bug#14345).
4314
759fd763
SM
43152013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4316
4317 * lread.c (skip_dyn_eof): New function.
4318 (read1): Use it to skip the end of a file in response to #@00.
4319
4320 * doc.c (get_doc_string): Slightly relax the sanity checking.
4321
4465bfb4
JD
43222013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4323
4324 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4325 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4326 (MonitorInfo): New struct.
4327 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4328 (Fns_display_monitor_attributes_list): New functions.
4329 (display-usable-bounds): Remove.
4330 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4331 Qsource.
4332
7583e2a0
PE
43332013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4334
4335 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4336 (GTK_CHECK_VERSION): New macro, if not already defined.
4337 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4338 replaced by GTK_CHECK_VERSION.
4339
ad75d77e
PE
43402013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4341
4342 * xterm.h (GTK_PREREQ): New macro.
4343 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4344 to use this macro instead, for consistency and clarity.
4345
07525f77
EZ
43462013-05-08 Eli Zaretskii <eliz@gnu.org>
4347
4348 * xdisp.c (row_for_charpos_p): New function, with code of
4349 cursor_row_p, but accepts an additional argument CHARPOS instead
4350 of using a hardcoded PT.
4351 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4352 (row_containing_pos): Call row_for_charpos_p instead of partially
4353 doing the same. Fixes cursor positioning under longlines-mode
4354 when longlines-show-effect includes more than one newline, when
4355 moving the cursor vertically up.
4356
d901fc8d
JB
43572013-05-08 Juanma Barranquero <lekktu@gmail.com>
4358
4359 * makefile.w32-in (ACL_H): New macro.
4360 ($(BLD)/fileio.$(O)): Update dependencies.
4361
f269bc61
PE
43622013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4363
e7b41c4c 4364 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4365 * Makefile.in (LIB_ACL): New macro.
4366 (LIBACL_LIBS): Remove.
4367 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4368 * fileio.c: Include <acl.h>.
4369 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4370 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4371 !acl_errno_valid.
4372 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4373 it ourselves.
4374
f269bc61
PE
4375 * unexelf.c: Don't assume ElfW (Half) fits in int.
4376 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4377 when dealing with ElfW (Half) values, since they can exceed 2**31
4378 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4379 (entry_address): Omit unused NUM arg. All uses changed.
4380
a261c53e
JL
43812013-05-07 Juri Linkov <juri@jurta.org>
4382
4383 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4384 to the string converted from number with `Fnumber_to_string'.
4385 (Bug#14254)
4386
2b66427d
PE
43872013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4388
4389 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4390 This fixes a problem introduced by my previous change.
4391
15acfe41
GM
43922013-05-07 Glenn Morris <rgm@gnu.org>
4393
4394 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4395
5ea03bf5
JD
43962013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4397
4398 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4399
e0c9d565
PE
44002013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4401
4402 Static checking by GCC 4.8.0.
4403 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4404 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4405 (x_get_monitor_attributes_fallback)
4406 (x_get_monitor_attributes_xinerama)
4407 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4408 Define only if USE_GTK.
4409 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4410 (x_get_monitor_attributes_fallback): Omit unused locals.
4411 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4412 Use double, not float, to avoid mixed-mode floating point arithmetic.
4413
4e3f9230
YM
44142013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4415 Jan Djärv <jan.h.d@swipnet.se>
4416
4417 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4418 (XINERAMA_CFLAGS): New macros.
4419 (ALL_CFLAGS, LIBES): Use them.
4420
4421 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4422 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4423 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4424 (syms_of_xfns): DEFSYM them.
4425 (struct MonitorInfo): New struct.
4426 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4427 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4428 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4429 (x_get_monitor_attributes_xinerama): New functions.
4430 (Fx_display_monitor_attributes_list): New primitive.
4431 (syms_of_xfns): Defsubr it.
4432
4433 * xterm.h (x_display_info): Add Xatom_net_workarea and
4434 Xatom_net_current_desktop.
4435
4436 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4437 and dpyinfo->Xatom_net_current_desktop.
4438
05839b6a
EZ
44392013-05-06 Eli Zaretskii <eliz@gnu.org>
4440
4441 * xdisp.c (pos_visible_p): Use the special code for finding the
4442 beginning of a display property or overlay for any "replacing"
4443 display property, not just for display strings. This solves
4444 incorrect reporting of position by posn-at-point. (Bug#14241)
4445
dc4a2ee0
PE
44462013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4447
5ee94506
PE
4448 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4449 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4450 Verify that ElfW (Half) fits in int.
4451 (fatal): Use same signature as lisp.h.
4452 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4453 configure and build with -DUNEXELF_DEBUG without worrying about
4454 other modules that use DEBUG.
4455 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4456 possibly-wide integers now uses it instead of plain fprintf.
4457 (entry_address): New function, which avoids problems with 32-bit
4458 overflow on 64-bit hosts.
4459 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4460 (round_up): Don't assume the remainder fits in int.
4461 (find_section): Use bool for boolean. Simplify debug code.
4462 (unexec): Don't assume file sizes fit in int or size_t.
4463 Omit unnecessary trailing newline in 'fatal' format.
4464 Use strerror rather than outputting decimal error number.
4465 Remove unused code when emacs is not defined;
4466 this file relies on Emacs now.
4467 Don't assume e_phnum and e_shnum are positive.
4468
dc4a2ee0
PE
4469 * regex.c: Fix problems when DEBUG is defined.
4470 (extract_number, extract_number_and_incr): Define regardless of
4471 whether DEBUG is defined; that's simpler and makes the code less
4472 likely to go stale in the normal case when DEBUG is not defined.
4473 Return int rather than taking an int * arg. All callers changed.
4474 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4475 Remove, replacing with ...
4476 (DEBUG_PRINT): New macro. All callers changed.
4477 (DEBUG_COMPILES_ARGUMENTS): New macro.
4478 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4479 (print_compiled_pattern, print_double_string) [DEBUG]:
4480 Use prototype rather than old-style definition.
4481 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4482 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4483 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4484 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4485 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4486 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4487 This matters only when DEBUG is defined.
4488
14c7ed05
EZ
44892013-05-05 Eli Zaretskii <eliz@gnu.org>
4490
4491 * xdisp.c (set_iterator_to_next): Set the
4492 ignore_overlay_strings_at_pos_p flag only if we are _really_
4493 iterating over an overlay string, as indicated by the
4494 current.overlay_string_index member. (Bug#14306)
4495
e6076b1b
JD
44962013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4497
4498 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4499 to where it is used, to avoid autorelease issues (Bug#14050).
4500
cbee2131
PE
45012013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4502
4503 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4504 * fileio.c (syms_of_fileio): Implement this.
4505 * filelock.c (create_lock_file): If symbolic links don't work, so
4506 we use a regular file as a lock file, do not fsync the lock file;
4507 it's not needed.
4508
30c7e542
SM
45092013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4510
4511 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4512 (syms_of_minibuf): Adjust accodingly.
4513 * lread.c (Fread):
4514 * callint.c (Fcall_interactively): Adjust calls accordingly.
4515
5bebd186
EZ
45162013-05-04 Eli Zaretskii <eliz@gnu.org>
4517
4518 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4519 w->contents is a buffer before computing everything else.
4520 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4521
4522 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4523 assertion violations. (Bug#14062)
4524
0fb0a4f3
DR
45252013-05-01 David Reitter <david.reitter@gmail.com>
4526
4527 * nsfns.m (ns_tooltip): Initialize.
4528
9e63b4a5
EZ
45292013-04-28 Eli Zaretskii <eliz@gnu.org>
4530
4531 * coding.c (decode_coding_gap): Don't remove the character before
4532 a newline unless it's a CR character. (Bug#14287)
4533
ad60824e
DN
45342013-04-28 Dan Nicolaescu <dann@gnu.org>
4535
4536 * dispextern.h (struct face): Move enum face_underline_type
4537 earlier so that bitfields can be in the same word.
4538
edbdcec0
JD
45392013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4540
4541 * nsfns.m (handlePanelKeys): New function.
4542 (EmacsOpenPanel:performKeyEquivalent:)
4543 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4544 arrows/function/control and copy/paste keys (Bug#14296).
4545
0208ede7
JL
45462013-04-27 Juri Linkov <juri@jurta.org>
4547
4548 * callint.c (Fcall_interactively): Call `Qread_number' for
4549 interactive code letter `n' instead of using duplicate code.
4550 (Bug#14254)
4551
b8dd59f7
PE
45522013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4553
4554 * systime.h (make_timeval): Declare as 'const'.
4555
8bd722db
KH
45562013-04-27 Kenichi Handa <handa@gnu.org>
4557
4558 * font.c (font_open_entity): Always open a font of manageable
4559 size.
4560
13d0e56f 45612013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4562
f780d632
PE
4563 Port better to AIX (Bug#14258).
4564 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4565 to pacify AIX xlc.
4566
ec509856
KH
45672013-04-24 Kenichi Handa <handa@gnu.org>
4568
4569 * coding.c (decode_coding_iso_2022): When an invalid escape
4570 sequence is encountered, reset the invocation and designation
4571 status to the safest one.
4572
84fc48e5
PE
45732013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4574
4575 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4576 Without this fix, "make distclean" leaves stamp-h1 behind.
4577
806bda47
EC
45782013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4579
4580 * w32fns.c (w32_fullscreen_rect): New function to compute the
4581 window rectangle for the given fullscreen mode.
4582 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4583 longer tunes the window size. This keeps the window's edges flush
4584 with the screen and allows the taskbar to hide itself in fullboth.
4585
4586 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4587 window decorations and uses the entire screen.
4588
4589 * w32term.h (w32_fullscreen_rect) Add prototype.
4590 (struct w32_output): Replace normal_width, normal_height,
4591 normal_top, and normal_left members with a single normal_placement
4592 struct.
4593 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4594 Remove macros.
4595 (FRAME_NORMAL_PLACEMENT): New macro.
4596
9cc2810b
JB
45972013-04-16 Juanma Barranquero <lekktu@gmail.com>
4598
4599 * minibuf.c (Ftest_completion): Silence compiler warning.
4600
fd16b54c
EZ
46012013-04-15 Eli Zaretskii <eliz@gnu.org>
4602
4603 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4604 bug#14062.
fd16b54c
EZ
4605
4606 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4607 parentheses.
4608
4609 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4610 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4611 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4612 parentheses where appropriate.
4613
9e3379a0
PE
46142013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4615
4616 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4617
ddd6b685
EZ
46182013-04-14 Eli Zaretskii <eliz@gnu.org>
4619
4620 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4621 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4622 Mention in the doc string that setting these variables takes
4623 effect only after a call to set-window-buffer. (Bug#14200)
4624
29b79ba1
EZ
46252013-04-13 Eli Zaretskii <eliz@gnu.org>
4626
4627 * indent.c (Fvertical_motion): Don't consider display strings on
4628 overlay strings as display strings on the buffer position we
4629 started from. This prevents vertical cursor motion from jumping
4630 more than one line when there's an overlay string with a display
4631 property at end of line.
4632 Reported by Karl Chen <Karl.Chen@quarl.org> in
4633 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4634
562c6ee9
SM
46352013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4636
4637 * window.c (select_window): `record_buffer' even if window is
4638 already selected (bug#14191).
4639
fcc1fe85
EZ
46402013-04-11 Eli Zaretskii <eliz@gnu.org>
4641
4642 * window.c (Fwindow_end): Test more flags, including the buffer's
4643 last_overlay_modified flag, to determine whether the window's
4644 display is really up-to-date. Prevents the function from
4645 returning a stale value. (Bug#14170)
4646 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4647 current matrix.
4648
f009190a
EZ
46492013-04-10 Eli Zaretskii <eliz@gnu.org>
4650
4651 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4652 garbaged only if it is not already the top frame on its TTY.
4653 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4654 there are GUI frames open in the same session. (Bug#13864)
4655
78ce603d
SM
46562013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4657
4658 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4659 of marking the idle timers directly.
4660
a8036e40
SM
46612013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4662
4663 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4664 tables (bug#14054).
4665
7ffe7ef6
SM
46662013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4667
4668 * window.c (select_window): Don't record_buffer while the invariant is
4669 temporarily broken (bug#14161).
4670
4671 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4672
7d9f6883
EZ
46732013-04-07 Eli Zaretskii <eliz@gnu.org>
4674
4675 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4676
5406cfd9
RF
46772013-04-07 Romain Francoise <romain@orebokech.com>
4678
4679 Ignore additional platform-specific ACL errors (Bug#13702).
4680 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4681 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4682
95c0e83b
JD
46832013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4684
4685 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4686 f->output_data.ns.
4687
876da980
PE
46882013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4689
4690 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4691 This bug was introduced by my 2013-02-25 change that simplified
4692 data_start configuration. Without this change, on GNU/Linux
4693 an Emacs configured with --enable-profiling fails immediately
4694 due to a profiler signal.
4695 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4696 with these flags. On platforms where special flags are needed
4697 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4698 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4699 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4700
7452b7bd
DA
47012013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4702
4703 Get rid of some platform-specific functions examining window
4704 system and its capabilities. This is a partial rework of the
4705 2013-04-05 change.
4706 * lisp.h (have_menus_p): Remove prototype. This function is
4707 replaced with platform-independent window_system_available.
4708 (check_window_system): Move to...
4709 * frame.h (decode_window_system_frame, window_system_available):
4710 ...here, add new prototypes.
4711 * frame.c (window_system_available, decode_window_system_frame):
4712 New functions.
4713 (check_window_system): Platform-independent now.
4714 * xterm.h (x_in_use): Remove declaration.
4715 (check_x_frame):
4716 * w32term.h (check_x_frame):
4717 * nsterm.h (check_x_frame): Remove prototypes. This function
4718 is replaced with platform-independent decode_window_system_frame.
4719 * msdos.c (have_menus_p): Remove.
4720 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4721 Remove platform-specific functions. Use check_window_system,
4722 decode_window_system_frame and check_ns_display_info where
4723 appropriate. Minor style and comment tweaks.
4724 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4725 (check_x_frame): Likewise.
4726 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4727 Likewise.
4728 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4729 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4730 * xmenu.c, xselect.c: All related users changed.
4731
251e9147
KH
47322013-04-03 Kenichi Handa <handa@gnu.org>
4733
4734 The following changes is to optimize the code for reading UTF-8
4735 files.
4736
562c6ee9 4737 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4738 changed. Check EOL format. Do not call adjust_coding_eol_type
4739 here.
4740 (check_utf_8): New function.
4741 (adjust_coding_eol_type): Do nothing if already adjusted.
4742 (detect_coding): Compare the return value of check_ascii with
4743 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4744 (decode_coding_gap): Optimize for valid UTF-8.
4745
8bc369d4
KH
47462013-03-21 Kenichi Handa <handa@gnu.org>
4747
4748 * coding.c (syms_of_coding): Cancel previous change.
4749
4750 * insdel.c (insert_from_gap): Fix previous change.
4751
73931ad1
DA
47522013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4753
4754 Consistently use platform-specific function to detect window system.
4755 * lisp.h (check_window_system): New prototype. This function is
4756 going to replace check_x, check_w32 and check_ns.
4757 (have_menus_p): Mention msdos.c in comment.
4758 * fontset.c (check_window_system_func): Remove. Adjust all users.
4759 * fontset.h (check_window_system_func): Remove prototype.
4760 * nsterm.h (check_ns):
4761 * xterm.h (check_x):
4762 * w32term.h (check_w32): Likewise.
4763 * menu.c (Fx_popup_menu): Use check_window_system.
4764 * msdos.c (check_window_system): Define for MS-DOS.
4765 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4766 * w32fns.c (check_window_system): Likewise for MS-Windows.
4767 * xfns.c (check_window_system): Likewise for X.
4768 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4769 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4770
7216e43b
PE
47712013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4772
4773 Prefer < to > in range checks such as 0 <= i && i < N.
4774 This makes it easier to visualize quantities on a number line.
4775 This patch doesn't apply to all such range checks,
4776 only to the range checks affected by the 2013-03-24 change.
4777 This patch reverts most of the 2013-03-24 change.
4778 * alloc.c (xpalloc, Fgarbage_collect):
4779 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4780 * character.c (string_escape_byte8):
4781 * charset.c (read_hex):
4782 * data.c (cons_to_unsigned):
4783 * dispnew.c (update_frame_1):
4784 * doc.c (Fsubstitute_command_keys):
4785 * doprnt.c (doprnt):
4786 * editfns.c (hi_time, decode_time_components):
4787 * fileio.c (file_offset):
4788 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4789 * font.c (font_intern_prop):
4790 * frame.c (x_set_alpha):
4791 * gtkutil.c (get_utf8_string):
4792 * indent.c (check_display_width):
4793 * keymap.c (Fkey_description):
4794 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4795 * lread.c (read1):
4796 * minibuf.c (read_minibuf_noninteractive):
4797 * process.c (wait_reading_process_output):
4798 * search.c (Freplace_match):
4799 * window.c (get_phys_cursor_glyph):
4800 * xdisp.c (redisplay_internal):
4801 * xsmfns.c (smc_save_yourself_CB):
4802 Prefer < to > for range checks.
4803 * dispnew.c (sit_for): Don't mishandle NaNs.
4804 This fixes a bug introduced in the 2013-03-24 change.
4805 * editfns.c (decode_time_components): Don't hoist comparison.
4806 This fixes another bug introduced in the 2013-03-24 change.
4807
92759988
DA
48082013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4809
4810 * frame.h (struct frame): Drop scroll_bottom_vpos
4811 member becaue all real users are dead long ago.
4812 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4813 * xdisp.c (redisplay_internal): Adjust user.
4814
9a1971bb
GM
48152013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4816
f38ab167
JD
4817 * nsmenu.m (showAtX:Y:for:): setLevel to
4818 NSPopUpMenuWindowLevel (Bug#13998).
4819
6d01f1fe
JD
48202013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4821
4822 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4823 (ns_check_pending_open_menu): Declare.
4824
4825 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4826 (x_activate_menubar): Update the menu with title that matches
4827 ns_get_pending_menu_title, and call
4828 ns_check_pending_openmenu (Bug#12698).
4829 (menuWillOpen:): New method.
4830 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4831
4832 * nsterm.m (menu_will_open_state, menu_mouse_point)
4833 (menu_pending_title): New varaibles.
4834 (ns_get_pending_menu_title, ns_check_menu_open)
4835 (ns_check_pending_open_menu): New functions.
4836
781f4782
DA
48372013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4838
4839 * indent.c (current_column_bol_cache): Remove leftover which is not
4840 used in Fmove_to_column any more.
4841 (current_column, scan_for_column): Adjust users.
4842 * keyboard.c (last_point_position_buffer, last_point_position_window):
4843 Remove leftovers which are not used for recording undo any more.
4844 (command_loop_1, syms_of_keyboard): Adjust users.
4845 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4846 redisplay_window any more.
4847 (move_it_to): Adjust user.
4848
1921c31b
JB
48492013-03-29 Juanma Barranquero <lekktu@gmail.com>
4850
4851 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4852 Update dependencies.
4853
717b8bcd
SM
48542013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4855
4856 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4857 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4858 forward references.
4859
e74aeda8
DA
48602013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4861
4862 * window.h (struct window): Replace hchild, vchild and buffer slots
4863 with the only contents slot. This is possible because each valid
4864 window may have either the child window (in vertical or horizontal
4865 combination) or buffer to display (for the leaf window). Using that,
4866 a lof of operations to traverse and/or change window hierarchies may
4867 be simplified. New member horizontal is used to distinguish between
4868 horizontal and vertical combinations of internal windows.
4869 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4870 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4871 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4872 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4873 Use contents slot, not buffer, where appropriate.
4874 (wset_combination): New function.
4875 (wset_buffer): Add eassert.
4876 (Fframe_first_window): Simplify the loop reaching first window.
4877 (Fwindow_buffer): Use WINDOW_LEAF_P.
4878 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4879 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4880 (unshow_buffer): Convert initial debugging check to eassert.
4881 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4882 (make_parent_window, window_resize_check, window_resize_apply)
4883 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4884 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4885 Adjust to match struct window changes.
4886 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4887 (mark_window_cursors_off, count_windows, get_leaf_windows)
4888 (foreach_window_1): Simplify the loop.
4889 * alloc.c (mark_object): Do not check for the leaf window because
4890 internal windows has no glyph matrices anyway.
4891 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4892 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4893 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4894 (build_frame_matrix_from_window_tree, mirror_make_current)
4895 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4896 (update_window_tree, set_window_update_flags): Simplify the loop.
4897 (sync_window_with_frame_matrix_rows): Enforce live window.
4898 Use contents slot, not buffer, where appropriate.
4899 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4900 and WINDOW_HORIZONTAL_COMBINATION_P.
4901 (make_frame_visible_1): Simplify the loop.
4902 Use contents slot, not buffer, where appropriate.
4903 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4904 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4905 (expose_window_tree): Likewise.
4906 Use contents slot, not buffer, where appropriate.
4907 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4908 to avoid deleted windows. Use contents slot instead of buffer.
4909 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4910 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4911 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4912 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4913
121ab1cd
EZ
49142013-03-28 Eli Zaretskii <eliz@gnu.org>
4915
ef454cf7
EZ
4916 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4917 identify the reasons for assertion violations in bug#14062 and
4918 similar ones.
21e930f8
EZ
4919 (Fx_show_tip): Fix compilation error under
4920 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4921
121ab1cd
EZ
4922 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4923 Reported by <rzl24ozi@gmail.com>.
4924
5c89ca24
DA
49252013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4926
4927 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4928 start marker...
562c6ee9
SM
4929 (unwind_with_echo_area_buffer): ...to restore it here.
4930 This is needed to ensure that...
5c89ca24
DA
4931 (redisplay_window): ...both window markers are valid here,
4932 which is verified by eassert.
4933 * editfns.c (save_excursion_save): Do not assume that
4934 selected_window always displays the buffer.
c7f53895
DA
4935 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4936 Fix comment.
5c89ca24 4937
f557c1b1
SM
49382013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4939
4940 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4941 the upcase table.
4942
40693bba 49432013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4944
4945 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4946
c86f791f
EZ
49472013-03-27 Eli Zaretskii <eliz@gnu.org>
4948
4949 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4950 since MinGW's w32api headers do. This avoids compiler warnings.
4951
4952 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4953 if already defined.
4954
c6e72e17
EZ
49552013-03-26 Eli Zaretskii <eliz@gnu.org>
4956
4957 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4958
54e95010
JD
49592013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4960
4961 * gtkutil.c (style_changed_cb): Check if frame is live and an
4962 X frame (Bug#14038).
4963
b88b62de
EZ
49642013-03-26 Eli Zaretskii <eliz@gnu.org>
4965
a18d7de6
EZ
4966 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4967 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4968 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4969 MinGW64.
8f5e14c8
EZ
4970 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4971 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4972
b88b62de
EZ
4973 Fix incompatibilities between MinGW.org and MinGW64 headers.
4974 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4975
4976 * w32.c (REPARSE_DATA_BUFFER): Guard with
4977 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4978
c074e458
JD
49792013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4980
4981 * xterm.c: Include X11/XKBlib.h
4982 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4983
908589fd
AS
49842013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4985
4986 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4987 written backwards.
4988 * blockinput.h (input_blocked_p): Likewise.
4989 * bytecode.c (exec_byte_code): Likewise.
4990 * callproc.c (call_process_kill, call_process_cleanup)
4991 (Fcall_process): Likewise.
4992 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4993 (Fccl_execute_on_string): Likewise.
4994 * character.c (string_escape_byte8): Likewise.
4995 * charset.c (read_hex): Likewise.
4996 * cm.c (calccost): Likewise.
4997 * data.c (cons_to_unsigned): Likewise.
4998 * dired.c (directory_files_internal, file_name_completion):
4999 Likewise.
5000 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5001 (sit_for): Likewise.
5002 * doc.c (Fsubstitute_command_keys): Likewise.
5003 * doprnt.c (doprnt): Likewise.
5004 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5005 * emacsgtkfixed.c: Likewise.
5006 * fileio.c (file_offset, Fwrite_region): Likewise.
5007 * floatfns.c (Fexpt, fmod_float): Likewise.
5008 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5009 Likewise.
5010 * font.c (font_intern_prop): Likewise.
5011 * frame.c (x_set_alpha): Likewise.
5012 * gtkutil.c (get_utf8_string): Likewise.
5013 * indent.c (check_display_width): Likewise.
5014 * intervals.c (create_root_interval, rotate_right, rotate_left)
5015 (split_interval_right, split_interval_left)
5016 (adjust_intervals_for_insertion, delete_node)
5017 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5018 (merge_interval_right, merge_interval_left, copy_intervals)
5019 (set_intervals_multibyte_1): Likewise.
5020 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5021 * keymap.c (Fkey_description): Likewise.
5022 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5023 * lread.c (openp, read_integer, read1, string_to_number):
5024 Likewise.
5025 * menu.c (ensure_menu_items): Likewise.
5026 * minibuf.c (read_minibuf_noninteractive): Likewise.
5027 * print.c (printchar, strout): Likewise.
5028 * process.c (create_process, Faccept_process_output)
5029 (wait_reading_process_output, read_process_output, send_process)
5030 (wait_reading_process_output): Likewise.
5031 * profiler.c (make_log, handle_profiler_signal): Likewise.
5032 * regex.c (re_exec): Likewise.
5033 * regex.h: Likewise.
5034 * search.c (looking_at_1, Freplace_match): Likewise.
5035 * sysdep.c (get_child_status, procfs_ttyname)
5036 (procfs_get_total_memory): Likewise.
5037 * systime.h (EMACS_TIME_VALID_P): Likewise.
5038 * term.c (dissociate_if_controlling_tty): Likewise.
5039 * window.c (get_phys_cursor_glyph): Likewise.
5040 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5041 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5042 Likewise.
5043 * xfns.c (Fx_window_property): Likewise.
5044 * xmenu.c (set_frame_menubar): Likewise.
5045 * xselect.c (x_get_window_property, x_handle_dnd_message):
5046 Likewise.
5047 * xsmfns.c (smc_save_yourself_CB): Likewise.
5048 * xterm.c (x_scroll_bar_set_handle): Likewise.
5049
2bf7d27a
DA
50502013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5051
5052 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5053 to be optional or nil. Adjust comment and convert it to docstring.
5054 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5055 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5056
a9ebfa0b
PE
50572013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5058
5059 Static checking by GCC 4.8-20130319.
5060 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5061 * process.c (Fset_process_datagram_address)
5062 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5063 * xdisp.c (get_char_face_and_encoding):
5064 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5065 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5066 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5067
4f3576ee
KB
50682013-03-24 Ken Brown <kbrown@cornell.edu>
5069
789b5e9a
KB
5070 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5071 fix compilation on 64-bit Cygwin, where underscores are not
5072 automatically prepended.
5073
4f3576ee
KB
5074 * w32term.c (w32_initialize): Silence compiler warning.
5075
b5b7745f
EZ
50762013-03-23 Eli Zaretskii <eliz@gnu.org>
5077
cdc0d0bd
EZ
5078 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5079 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5080 variables, to save and restore frame dimensions.
5081 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5082 after returning from a 'fullscreen' configuration.
5083 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5084 to avoid races between the main thread and the input thread.
5085
5086 * w32term.h (struct w32_output): New members normal_width,
5087 normal_height, normal_top, normal_left, and prev_fsmode.
5088 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5089 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5090 members of a frame.
5091
b5b7745f
EZ
5092 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5093 'fullscreen' parameter. Always record previous width and height
5094 of the frame, except when switching out of maximized modes, so
5095 that they could be restored correctly, instead of resetting to the
5096 default frame dimensions. Send SC_RESTORE command to the frame,
5097 unless we are going to send SC_MAXIMIZE, to restore the frame
5098 resize hints in the mouse pointer shown by the window manager.
5099 (Bug#14032)
5100
5101 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5102
5103 * lisp.h (get_frame_param): Adjust conditions for prototype
5104 declaration.
5105
a3454eed
KB
51062013-03-22 Ken Brown <kbrown@cornell.edu>
5107
5108 * unexcw.c: Drop unneeded inclusion of w32common.h.
5109 (report_sheap_usage): Declare.
5110 (read_exe_header): Add magic numbers for x86_64.
5111 (fixup_executable): Fix printf format specifier for unsigned long
5112 argument.
5113
5a49b79c
DA
51142013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5115
5116 * frame.h (struct frame): Put menu_bar_window under #ifdef
5117 because this member is not needed when X toolkit is in use.
5118 (fset_menu_bar_window):
5119 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5120 (free_glyphs, update_frame):
5121 * xdisp.c (expose_frame): Likewise.
5122 (display_menu_bar): Likewise. Remove redundant eassert.
5123 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5124 toolkit is in use.
5125
d6723bf7
PE
51262013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5127
7b1123d8
PE
5128 Use functions and constants to manipulate Lisp_Save_Value objects.
5129 This replaces code that used macros and strings and token-pasting.
5130 The change makes the C source a bit easier to follow,
5131 and shrinks the Emacs executable a bit.
5132 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5133 (make_save_value): Change 1st arg from string to enum. All callers
5134 changed.
5135 (INTX): Remove.
5136 (mark_object): Use if, not #if, for GC_MARK_STACK.
5137 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5138 (XSAVE_OBJECT): Now functions, not macros.
5139 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5140 the constant was never used.
5141 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5142 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5143 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5144 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5145 New constants.
5146 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5147 type3 with a single member save_type. All uses changed.
5148 (save_type, set_save_pointer, set_save_integer): New functions.
5149 * print.c (PRINTX): Remove.
5150
d6723bf7
PE
5151 * alloc.c: Remove redundant static declarations.
5152
5f24fa51
DA
51532013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5154
5155 * window.h (struct window): Convert left_col, top_line, total_lines
5156 and total_cols from Lisp_Objects to integers. Adjust comments.
5157 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5158 Remove.
5159 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5160 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5161 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5162 Adjust users where appropriate.
5163
42143acd
DA
51642013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5165
5166 * frame.h (struct frame): Drop resx and resy because the same data is
5167 available from window system-specific output context. Adjust users.
562c6ee9
SM
5168 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5169 New functions to provide defaults when no window system available.
42143acd 5170 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5171 (NUMVAL): Move from xdisp.c.
42143acd
DA
5172 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5173 (Ffont_face_attributes, Fopen_font):
5174 * image.c (gs_load):
5175 * w32font.c (fill_in_logfont):
5176 * xdisp.c (calc_pixel_width_or_height):
5177 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5178 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5179
c0a17406
KH
51802013-03-20 Kenichi Handa <handa@gnu.org>
5181
5182 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5183 to 1 (temporary workaround until a bug related to ASCII
5184 optimization is fixed).
5185
095d384d
DA
51862013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5187
5188 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5189 Signal error if window is not internal. Adjust docstring.
5190 (delete_all_child_windows): Use combination_limit to save the buffer.
5191 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5192 * print.c (syms_of_print): Initialize debugging output not here...
5193 (init_print_once): ...but in a new function here.
5194 * lisp.h (init_print_once): Add prototype.
5195 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5196
748fa866
DA
51972013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5198
5199 * window.c (window_resize_check, window_resize_apply)
5200 (window_from_coordinates, recombine_windows, set_window_buffer)
5201 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5202 (Fsplit_window_internal, Fdelete_window_internal)
5203 (freeze_window_starts): Use bool for booleans.
5204 * window.h (window_frame_coordinates, resize_frame_windows)
5205 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5206
81519fd2
SM
52072013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5208
5209 * dispnew.c (bitch_at_user): Use `user-error'.
5210
6db423a9
KB
52112013-03-17 Ken Brown <kbrown@cornell.edu>
5212
5213 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5214 as return type of image_background. (Bug#13981)
5215 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5216
8f2906f5
JD
52172013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5218
960ce480 5219 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5220 (ns_select): Don't return with result uninitialized.
960ce480 5221
8f2906f5
JD
5222 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5223 and getDirectory.
5224
81519fd2
SM
5225 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5226 New functions.
8f2906f5
JD
5227 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5228 directories. If filename is nil, get directory name (Bug#13932).
5229 Use getFilename and getDirectory.
5230 (getFilename, getDirectory): New methods for EmacsSavePanel and
5231 EmacsOpenPanel.
5232 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5233
cded56c1
PE
52342013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5235
5236 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5237
251e9147 52382013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5239
5240 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5241 (adjust_after_replace): Make it back to static. Delete the third
5242 arg text_at_gap_tail. Cancel the code for handling it.
5243
5244 * coding.h (struct coding_system): New member eol_seen.
5245
5246 * coding.c (detect_ascii): New function.
5247 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5248 when the source bytes are actually scanned. On detecting for
5249 coding_category_utf_8_auto, call detect_ascii instead of scanning
5250 source bytes directly.
5251 (produce_chars): Call insert_from_gap with the new arg 0.
5252 (encode_coding): Likewise.
5253 (decode_coding_gap): Control ASCII optimization by the variable
5254 disable_ascii_optimization instead of #ifndef .. #endif.
5255 Deccode EOL format according to coding->eol_seen.
5256 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5257 variable.
5258
8a44e6d1
KH
5259 * lisp.h (adjust_after_replace): Cancel externing it.
5260 (insert_from_gap): Adjust prototype.
5261
5f795e34
EZ
52622013-03-15 Eli Zaretskii <eliz@gnu.org>
5263
5264 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5265 FULLSCREEN_MAXIMIZED. (Bug#13935)
5266
f258b4be
DA
52672013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5268
5269 * region-cache.c (find_cache_boundary, move_cache_gap)
5270 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5271 Simplify debugging check and convert to eassert. Adjust comment.
5272 (pp_cache): Put under ENABLE_CHECKING.
5273
a5cc4dde
EZ
52742013-03-14 Eli Zaretskii <eliz@gnu.org>
5275
5276 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5277 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5278 and WM_ACTIVATEAPP.
5279 (w32fullscreen_hook): If the frame is visible, reset
5280 f->want_fullscreen flag after changing the frame size. If the
5281 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5282 (Bug#13953)
5283
3fc5e44a
DC
52842013-03-13 Daniel Colascione <dancol@dancol.org>
5285
5286 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5287 too so that these builds can use Cygwin's file conversion
5288 functions. (We've been building and linking cygw32.o all along
5289 and just not using it.)
5290
47d7532e
PE
52912013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5292
5293 File synchronization fixes (Bug#13944).
5294 * Makefile.in (LIB_FDATASYNC): New macro.
5295 (LIBES): Use it.
5296 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5297 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5298 Don't worry about HAVE_FSYNC, since a substitute fsync is
5299 available if the system lacks one.
5300 (Fwrite_regin): Retry fsync if interrupted.
5301
c7ffccaf
EZ
53022013-03-13 Eli Zaretskii <eliz@gnu.org>
5303
4e2df81d 5304 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5305 activated, call w32fullscreen_hook, to make sure the new frame
5306 dimensions are in effect. (Bug#13937)
5307
8a7debc1
DA
53082013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5309
5310 * xdisp.c (init_iterator): Simplify because both character and byte
5311 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5312 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5313 character and byte positions can be obtained from marker.
8a7debc1 5314
7fd8c501
PE
53152013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5316
d9df6f40
PE
5317 Static checking by Sun C 5.12.
5318 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5319 * bytecode.c (exec_byte_code):
5320 * dispnew.c (init_display):
5321 * eval.c (error):
5322 * fileio.c (Fsubstitute_in_file_name):
5323 * keyboard.c (Fevent_convert_list):
5324 * keymap.c (Fsingle_key_description):
5325 * term.c (maybe_fatal, fatal):
5326 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5327 * xsmfns.c (Fhandle_save_session):
5328 Omit unreachable code.
5329 * keymap.c (map_keymap_char_table_item): Cast void * to
5330 a function pointer type; the C Standard requires this.
5331
7fd8c501
PE
5332 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5333 Include <sys/param.h> unconditionally, as that works elsewhere and
5334 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5335 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5336 and FreeBSD now.
5337
a020afb9 5338See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5339
5340;; Local Variables:
5341;; coding: utf-8
aac0c6e3
MR
5342;; End:
5343
ab422c4d 5344 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5345
5346 This file is part of GNU Emacs.
5347
5348 GNU Emacs is free software: you can redistribute it and/or modify
5349 it under the terms of the GNU General Public License as published by
5350 the Free Software Foundation, either version 3 of the License, or
5351 (at your option) any later version.
5352
5353 GNU Emacs is distributed in the hope that it will be useful,
5354 but WITHOUT ANY WARRANTY; without even the implied warranty of
5355 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5356 GNU General Public License for more details.
5357
5358 You should have received a copy of the GNU General Public License
5359 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.