Fix minor problems found by static checking.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
691a357f
PE
12013-08-15 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix minor problems found by static checking.
4 * frame.c (delete_frame):
5 * xdisp.c (next_element_from_display_vector):
6 Avoid uninitialized local.
7 * image.c (imagemagick_compute_animated_image): Port to C89.
8 Prefer usual GNU indentation style for loops.
9 Be more careful about bizarrely large sizes, by using ptrdiff_t
10 instead of int.
11
42fe2e88
DA
122013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
13
14 Fix infinite frame selection loop (Bug#15025).
15 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
16
d39a3da6
EZ
172013-08-15 Eli Zaretskii <eliz@gnu.org>
18
19 * xdisp.c (compute_window_start_on_continuation_line): When
20 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
21 to make sure we end up setting the window start at the leftmost
22 visible character of the display line. This avoids funky
23 horizontal shifting because the window start is not kept on the
24 same position. (Bug#15090)
05426239
EZ
25 (next_element_from_display_vector): Support 'box' face attribute
26 in the face definitions of a display vector. (Bug#15099)
d39a3da6 27
6e856b69
LMI
282013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
29
30 * image.c (imagemagick_compute_animated_image): Implement animated
31 images (bug#14700).
995be755
LMI
32 (imagemagick_compute_animated_image): Fix some compilation
33 warnings. Implement a very simple cache to make the animation
34 usable at all, but it should be replaced with a per-image cache.
6e856b69 35
d5a1acfa
DA
362013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
37
38 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
39 to do `for' loops over alist values.
40 * buffer.h (FOR_EACH_BUFFER):
41 * process.c (FOR_EACH_PROCESS): Use it.
42 (handle_child_signal, status_notify, Fget_buffer_process)
43 (kill_buffer_processes): Use FOR_EACH_PROCESS.
44
9c253307
DA
452013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
46
47 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
48 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
49 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
50 to xzalloc and so avoid redundant call to memset.
51 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
52 members because it is allocated with xzalloc and so already zeroed.
53
05e64f9f
KB
542013-08-14 Ken Brown <kbrown@cornell.edu>
55
56 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
57 (Bug#15094).
58
5b71542d
DA
592013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
60
61 Utility function and macro to copy Lisp string to C string.
62 * lisp.h (xlispstrdupa): New macro.
63 (xlispstrdup): New prototype.
64 * alloc.c (xlispstrdup): New function.
65 * callint.c (Fcall_interactively):
66 * fileio.c (Ffile_name_directory, Fexpand_file_name)
67 (Fsubstitute_in_file_name):
68 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
69 * image.c (x_create_bitmap_from_file):
70 * w32term.c (w32_term_init):
71 * xterm.c (x_term_init): Use xlispstrdup.
72
71530c97
LMI
732013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
74
4ce82fb8
LMI
75 * image.c (imagemagick_load_image): Make animated pictures work.
76 There's still some problems with background color settings, though
77 (bug#14700).
78
71530c97
LMI
79 * decompress.c (unwind_decompress): Always restore point.
80
7510a061
XF
812013-08-14 Xue Fuqiao <xfq.free@gmail.com>
82
83 * marker.c (set_marker): Reformat documentation.
84
01c3051f
PE
852013-08-14 Paul Eggert <eggert@cs.ucla.edu>
86
aab1fcdf
PE
87 * xdisp.c (cursor_type_changed): Now static.
88
01c3051f
PE
89 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
90 Use changed. This avoids the need to call xmalloc and for the
91 caller to call xfree, and avoids memory leaks in some situations.
92
2084152a
DA
932013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
94
95 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
96 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
97 (redisplay_window): If window_end_valid is cleared due to non-zero
98 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
99 so do not call to try_cursor_movement for that window.
2084152a 100
02455cb6
DA
1012013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
102
103 * window.h (struct window): Convert window_end_pos and
104 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
105 (wset_window_end_pos, wset_window_end_vpos): Remove.
106 * dispnew.c (adjust_glyph_matrix):
107 * window.c (Fwindow_end, replace_window, set_window_buffer)
108 (make_window):
109 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
110 (set_vertical_scroll_bar, redisplay_window, try_window)
111 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
112 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
113 (note_mouse_highlight): Adjust users.
114 (try_cursor_movement): Likewise. Convert old precondition to eassert.
115 Add comment.
116
da5707e8
DA
1172013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
118
119 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
120 * image.c (imagemagick_filename_hint): Use `const char *' and
121 prefer SSDATA to SDATA to avoid warnings.
122
25554267
DA
1232013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
124
125 Cleanup window fringes, margins and scroll bars adjustments.
126 * window.c (set_window_fringes, set_window_margins)
127 (set_window_scroll_bars, apply_window_adjustment): New functions.
128 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
129 (Fset_window_scroll_bars): Use them.
130
38a2c910
DA
1312013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
132
133 * window.h (struct window): Convert scroll_bar_width
134 from Lisp_Object to integer. Adjust comment.
135 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
136 Adjust users.
137 * window.c (wset_scroll_bar_width): Remove.
138 (make_window): Initialize scroll_bar_width.
139 (Fsplit_window_internal): Use direct assignment.
140 (Fset_window_configuration, save_window_save):
141 Convert Lisp_Object to integer and back where appropriate.
142 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
143 bar was actually changed, and mention this in docstring.
144
2d065031
PE
1452013-08-13 Paul Eggert <eggert@cs.ucla.edu>
146
147 * decompress.c: Minor simplifications.
148 (Fzlib_decompress_region): Don't bother verifying
149 that avail_out <= UINT_MAX, as that was confusing.
150 Mention the restriction in a comment instead.
151 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
152
a5bd5abb
JD
1532013-08-13 Jan Djärv <jan.h.d@swipnet.se>
154
155 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
156 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
157
66e7901a
LMI
1582013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
159
160 * image.c (imagemagick_filename_hint): Check for errors in the
161 alist structure.
162
2fa611b7
EZ
1632013-08-13 Eli Zaretskii <eliz@gnu.org>
164
165 * window.c (Fwindow_margins): Return nil when there's no marginal
166 area, as per the documented API.
167
168 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
169 Fmake_vector, as scroll bar's struct members are not all Lisp
170 objects now. This avoids crashes in GC.
171
172 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
173 bool, so its address could be taken.
174
8259030d
LMI
1752013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
176
177 * image.c (imagemagick_filename_hint): New function to possibly
178 apply `image-content-type-suffixes'.
179 (imagemagick_load_image): Use it.
180
866c710e
EZ
1812013-08-13 Eli Zaretskii <eliz@gnu.org>
182
183 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
184 if loading zlib failed.
185
f10490f0
JD
1862013-08-13 Jan Djärv <jan.h.d@swipnet.se>
187
96311be7
JD
188 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
189 2013-08-13 checkin below. Change bool to BOOL, rule is:
190 All Obj-C code uses BOOL, except for interfaces callable from C.
191
f10490f0
JD
192 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
193
c8ae93b0
DA
1942013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
195
196 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
197 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
198 bool instead of BOOL.
199 * w32term.h (struct scroll_bar): Convert fringe_extended_p
200 from Lisp_Object to bitfield. Adjust comment.
201 * w32term.c (x_scroll_bar_create): Adjust user.
202 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
203 * xterm.c (XTset_vertical_scroll_bar): Likewise.
204 Use bool for boolean.
205 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
206 to `unsigned int' when defining a bitfield.
207
53b64418
PE
2082013-08-13 Paul Eggert <eggert@cs.ucla.edu>
209
210 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
211
eeaf9bf3
DA
2122013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
213
214 * window.h (struct window): Convert left_margin_cols and
215 right_margin_cols from Lisp_Objects to integers. Adjust comment.
216 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
217 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
218 Adjust users.
219 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
220 Adjust comment.
221 (showing_window_margins_p, update_window_line, update_frame_1):
222 * fringe.c (draw_fringe_bitmap_1):
223 * xdisp.c (window_box_width): Adjust users.
224 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
225 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
226 Use direct assignment.
227 (Fset_window_configuration, save_window_save, Fwindow_margins):
228 Convert Lisp_Object to integer and back where appropriate.
229 (Fset_window_margins): Adjust user. Return t if any margin
230 was actually changed, and mention this in docstring.
231
956720af
XF
2322013-08-13 Xue Fuqiao <xfq.free@gmail.com>
233
f73f4ce6 234 * syntax.c (forward_word):
956720af
XF
235 * cmds.c (forward_char, backward_char): Mention the optional argument.
236
9e37ee3b
DA
2372013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
238
239 * window.h (struct window): Convert left_fringe_width
240 and right_fringe_width from Lisp_Objects to integers.
241 Adjust comment.
242 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
243 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
244 * window.c (wset_left_fringe_width, wset_right_fringe_width):
245 Remove.
246 (make_window): Initialize new integer fields to -1.
247 (Fsplit_window_internal): Use direct assignment.
248 (Fset_window_configuration, save_window_save): Convert
249 Lisp_Object to integer and back where appropriate.
250 (Fset_window_fringes): Adjust user. Return t if any fringe
251 was actually changed, and mention this in docstring.
252
e4375ca7
DA
2532013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
254
255 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
256 * nsfns.m (x_set_cursor_type):
257 * w32fns.c (x_set_cursor_type):
258 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
259 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 260
a45543bc
DA
2612013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
262
263 * font.c (clear_font_cache): New function, stripped from...
264 (Fclear_font_cache): ...here, which now uses the function
265 above. Adjust comment.
266 * font.h (clear_font_cache): Add prototype.
267 * xfaces.c (clear_face_cache): Use clear_font_cache.
268
ae966a86
DA
2692013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
270
271 * window.c (Fset_window_start): Compare `w', not `window' because
272 `w' might not be equal to `window' after call to decode_live_window.
273
297a545b
PE
2742013-08-12 Paul Eggert <eggert@cs.ucla.edu>
275
276 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
277 This fixes a problem introduced by the Bug#15035 patch
278 when using GPG. Reported by Herbert J. Skuhra.
279
aa942e2b
EZ
2802013-08-12 Eli Zaretskii <eliz@gnu.org>
281
282 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
283 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
284 not yet initialized.
285
7699d09e
LMI
2862013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
287
288 * decompress.c (Fzlib_decompress_region): Support zlib
289 decompression, too, and rename.
290
1d238bc7
PE
2912013-08-12 Paul Eggert <eggert@cs.ucla.edu>
292
293 Minor zlib configuration tweaks.
294 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
295 Don't assume presence of fn_inflateInit2_ zlib internal function.
296
8a44a184
LMI
2972013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
298
299 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
300 include the zlib prefix.
301
594a4307
EZ
3022013-08-12 Eli Zaretskii <eliz@gnu.org>
303
304 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
305 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
306 define static variables that are pointers to zlib functions to be
307 dynamically loaded.
308 (init_zlib_functions) [WINDOWSNT]: New function.
309 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
310 New macros.
311 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
312 macros instead of invoking the zlib functions directly.
313 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
314 Szlib_available_p.
315
d2e113bc
DA
3162013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
317
318 Avoid looping over all frame windows to freeze and unfreeze.
319 * window.h (struct window): Drop frozen_window_start_p.
320 (freeze_window_starts): Drop prototype.
321 * frame.h (struct frame): New frozen_window_starts flag.
322 (FRAME_WINDOWS_FROZEN): New macro.
323 * window.c (freeze_window_start, freeze_window_starts):
324 Remove.
325 (select_window, replace_window): Adjust users.
326 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
327 (window_frozen_p): New function.
328 (redisplay_window): Use it.
329
94fcd171
PE
3302013-08-12 Paul Eggert <eggert@cs.ucla.edu>
331
332 Fix some fd issues when running subprocesses (Bug#15035).
333 Fix bugs that can leak files or file descriptors on errors.
334 Don't unlink open temp files, as that's hard for users to diagnose
335 when things go awry (e.g., temp disk exhausted).
336 Don't bother to lock temp files. Check for invalid recursion.
337 * callproc.c (synch_process_fd): Remove. All uses removed.
338 (synch_process_tempfile): New var or macro.
339 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
340 New constants.
341 (record_kill_process): New arg, the temp name. All callers changed.
342 (delete_temp_file): Now just a simple wrapper around unlink.
343 (call_process_kill): New arg, the call_process_fd array.
344 Close them all. Clear synch_process_pid. Remove the temp file,
345 or arrange for it to be removed.
346 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
347 that's been moved to synch_process_tempfile. Caller changed.
348 Do not remove the tempfile; that's now call_process_kill's
349 responsibility.
350 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
351 call_process_kill; the caller now does that.
352 (call_process_cleanup): Do not close the process fd; that's now
353 call_process_kill's responsibility.
354 (Fcall_process): Implement via new function call_process, which
355 has most of the old body of Fcall_process, but with a different API.
356 (call_process): New function that does not open or close filefd if
357 it is nonnegative. Record which fds need to be closed, and let
358 call_process_kill close (and remove the tempfile, on MSDOS) on error.
359 Signal an error if invoked recursively (could be done via a hook).
360 Simplify creation of the tempfile in the MSDOS case.
361 Don't create the output file until after checking for the executable.
362 Report any failure to open /dev/null.
363 Don't open /dev/null for writing twice; once is enough.
364 Don't create pipe if all output is being discarded or sent to file.
365 Don't worry about setting up the coding system or reading from the
366 pipe if all output is being discarded.
367 Hoist fd_error local into top level, to lessen block nesting.
368 Don't record deleted pid here; now done by Fcall_process_region.
369 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
370 and note its success in synch_process_tempfile.
371 Do not leak resources when child_setup fails.
372 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
373 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
374 (create_temp_file): Now returns open fd, with an additional
375 Lisp_Object * argument to return the name. All callers changed.
376 Do not close the file; rewind it instead, and leave it open for
377 the caller. Do not lock the temp file. Unwind-protect the file
378 and the file-descriptor.
379 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
380 If an asynchrounous process, record it here, not in call_process.
381 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
382 * eval.c (set_unwind_protect): New function.
383 * fileio.c (write_region): New function, generalized from the
384 old Fwrite_region. Do not lock temp files.
385 (Fwrite_region): Use it.
386 * lisp.h (set_unwind_protect, write_region): New decls.
387 * process.c: Include <verify.h>.
388 (make_process): Mark fds as initially closed.
389 (deleted_pid_list): Now a list of pid-filename pairs.
390 All uses changed.
391 (close_process_fd): New function.
392 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
393 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
394 New constants. Verify that their number matches PROCESS_OPEN_FDS.
395 (create_process, create_pty, Fmake_serial_process)
396 (server_accept_connection): Record which fds need to be closed,
397 and let deactivate_process close them.
398 (Fmake_network_process): Do not discard the unwind-protect
399 until it's safe to do so.
400 (deactivate_process): Close the fds opened by create_process etc.
401 (Fprocess_send_eof): Adjust to new way of recording open fds.
402 Report an error if /dev/null can't be opened, instead of aborting.
403 * process.h (PROCESS_OPEN_FDS): New constant.
404 (struct Lisp_Process): New member open_fds.
405 (record_kill_process, record_deleted_pid): Adjust signatures.
406 (record_deleted_pid): Move decl here ...
407 * syswait.h (record_deleted_pid): ... from here.
408
d0e615c3
PE
4092013-08-11 Paul Eggert <eggert@cs.ucla.edu>
410
411 * decompress.c: Fix bugs with large buffers and weird inputs.
412 Tune a bit. Reindent as per usual Emacs style.
413 (BUFFER_SIZE): Remove.
414 (Fdecompress_gzipped_region): Do not mishandle input buffers with
415 more than UINT_MAX bytes. Decompress into the gap instead of into
416 an auto buffer, as this should avoid copying. Return nil if
417 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
418 set immediate_quit; we shouldn't trust zlib code that much.
419
313546eb
LMI
4202013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
421
99a32242
LMI
422 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
423 errors, and really move the gap to where we want it.
424
313546eb
LMI
425 * lisp.h: Include decompress.c support.
426
427 * emacs.c (main): Include decompress.c support.
428
429 * Makefile.in: Include -lz if present.
430
d2d699ac
JD
4312013-08-11 Jan Djärv <jan.h.d@swipnet.se>
432
f90e3ebd
JD
433 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
434 (initWithTitle:): Initialize frame to 0.
435 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
436 (fillWithWidgetValue:frame:): Renamed from
437 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
438
439 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
440 fillWithWidgetValue:frame:
441
423d3b3f
JD
442 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
443 remove memory leak warnings.
444
d2d699ac
JD
445 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
446 (ns_check_menu_open): Handle menu == nil. Remove assignment to
447 menu_pending_title.
448
449 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
450 (x_activate_menubar): Update the whole menu.
451 (trackingNotification:): Call ns_check_menu_open if tracking ends.
452 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
453 current event is not NSSystemDefined (Bug#15001).
454 Call ns_check_menu_open only if trackingMenu is 2.
455 (menuDidClose:): New method, decrease trackingMenu.
456 (fillWithWidgetValue:setDelegate:): New method.
457 (fillWithWidgetValue:): Call the above.
458
459 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
460
7d652d97
PE
4612013-08-11 Paul Eggert <eggert@cs.ucla.edu>
462
463 Omit some unnecessary casts.
464 Many of these go back to the old pre-C89 days, when they may have
465 been needed, but we've been assuming C89 or later for a while now.
466 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
467 (live_float_p, live_misc_p, live_vector_p):
468 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
469 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
470 (defvar_per_buffer):
471 * callint.c (Fcall_interactively):
472 * doc.c (Fsubstitute_command_keys):
473 * filelock.c (get_boot_time):
474 * frame.c (xrdb_get_resource):
475 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
476 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
477 (xg_get_file_name_from_selector, menuitem_destroy_callback)
478 (menuitem_highlight_callback, menu_destroy_callback)
479 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
480 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
481 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
482 (xg_tool_bar_help_callback, tb_size_cb):
483 * image.c (xpm_alloc_color, png_read_from_memory)
484 (png_read_from_file, png_load_body, our_memory_skip_input_data)
485 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
486 (syms_of_image):
487 * keymap.c (describe_map):
488 * nsfns.m (Fns_display_monitor_attributes_list):
489 * nsmenu.m (process_dialog:):
490 * nsterm.m (hold_event):
491 * process.c (wait_reading_process_output):
492 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
493 * scroll.c (do_direct_scrolling, scrolling_1):
494 * termcap.c (tgetent):
495 * window.c (check_window_containing, add_window_to_list)
496 (freeze_window_starts):
497 * xdisp.c (compare_overlay_entries, vmessage):
498 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
499 (x_get_monitor_attributes_xrandr)
500 (Fx_display_monitor_attributes_list, x_display_info_for_name)
501 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
502 * xfont.c (xfont_match, xfont_open):
503 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
504 (menubar_selection_callback, menu_position_func)
505 (popup_selection_callback, create_and_show_popup_menu)
506 (dialog_selection_callback, create_and_show_dialog):
507 * xrdb.c (x_get_string_resource):
508 (main) [TESTRM]:
509 * xsmfns.c (x_session_check_input):
510 * xterm.c (x_draw_glyphless_glyph_string_foreground)
511 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
512 (xaw_jump_callback, xaw_scroll_callback):
513 Omit unnecessary casts.
514
9acc1074
PE
5152013-08-10 Paul Eggert <eggert@cs.ucla.edu>
516
517 Minor string-length refactoring.
518 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
519 * frame.c (make_monitor_attribute_list):
520 Prefer build_string to strlen + make_string.
521
361c0eb8
JD
5222013-08-10 Jan Djärv <jan.h.d@swipnet.se>
523
524 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
525 don't check minor_code (Bug#14417).
526
14ba0822
EZ
5272013-08-09 Eli Zaretskii <eliz@gnu.org>
528
529 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
530 vertical positions instead. This avoids calling MATRIX_ROW with
531 row numbers that are possibly beyond valid limits. (Bug#15064)
532
309f24d1
DA
5332013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
534
535 Use xstrdup and build_unibyte_string where applicable.
536 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
537 * xfns.c (x_window):
538 * xrdb.c (x_get_customization_string):
539 * xterm.c (xim_initialize):
540 * w32fns.c (w32_window): Use xstrdup.
541 (w32_display_monitor_attributes_list):
542 * emacs.c (init_cmdargs):
543 * keyboard.c (PUSH_C_STR):
544 * nsfont.m (nsfont_open):
545 * sysdep.c (system_process_attributes):
546 * w32.c (system_process_attributes):
547 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
548
55902276
EZ
5492013-08-09 Eli Zaretskii <eliz@gnu.org>
550
551 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
552 variables of these types so that GDB would know about them, as aid
553 for debugging fatal exceptions. (Bug#15024) See also
554 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
555 discussions.
556
10bf7f5a
JD
5572013-08-08 Jan Djärv <jan.h.d@swipnet.se>
558
559 * nsterm.m (ns_update_begin): Don't change clip path if it would be
560 larger than the NSWindow (Bug#14934).
561
65620264
DA
5622013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
563
564 Redesign redisplay interface to drop global variable updated_window.
565 Always pass currently updated window as a parameter to update routines.
566 * dispextern.h (updated_window): Remove declaration.
567 (struct redisplay_interface): Pass window parameter to
568 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
569 and after_update_window_hook.
570 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
571 Adjust prototypes.
572 * dispnew.c (updated_window): Remove.
573 (redraw_overlapped_rows, update_marginal_area, update_text_area)
574 (update_window_line): Adjust to match redisplay interface changes.
575 * nsterm.m (ns_update_window_begin, ns_update_window_end)
576 (ns_scroll_run, ns_after_update_window_line):
577 * w32term.c (x_update_window_begin, x_update_window_end)
578 (x_after_update_window_line, x_scroll_run):
579 * xterm.c (x_update_window_begin, x_update_window_end)
580 (x_after_update_window_line, x_scroll_run):
581 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
582 Likewise. Adjust comments where appropriate.
583 (x_cursor_to): Simplify because this is always called during window
584 update (but install debugging check anyway).
585 (expose_window): Check must_be_updated_p flag to see whether this
586 function is called during window update.
587
628fdc56
DA
5882013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
589
590 Do not reset window modification event counters excessively.
591 These leftovers and poor man's tricky methods to catch extra
592 redisplay's attention are no longer needed.
593 * frame.c (set_menu_bar_lines_1):
594 * minibuf.c (read_minibuf_unwind):
595 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
596 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
597 (window_scroll_line_based, Fset_window_configuration):
598 * xdisp.c (redisplay_window): Do not reset last_modified and
599 last_overlay_modified counters.
600
8fd9c92e
JD
6012013-08-07 Jan Djärv <jan.h.d@swipnet.se>
602
603 * xselect.c (x_send_client_event): Set send_event and serial, memset
604 data.l as it might be bigger than data.b. Use 24 bit mask to
605 XSendEvent (Bug#15034).
606
0ee18172
EZ
6072013-08-07 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
610 for TTY frames that are not the top frame on their console.
611 (Bug#14616)
612
16ddd1a6
MR
6132013-08-07 Martin Rudalics <rudalics@gmx.at>
614
615 * w32term.c (w32fullscreen_hook): Really maximize frame when
616 asked for (Bug#14841).
617
d2a95ffb
DA
6182013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
619
620 Prefer selected_window to Fselected_window, likewise for frames.
621 * buffer.c (Fbuffer_swap_text):
622 * data.c (Fvariable_binding_locus):
623 * window.c (run_window_configuration_change_hook): Adjust users.
624 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
625 Use decode_live_frame.
626
170da1ec
DA
6272013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
628
629 Be more careful if selected window shows the buffer other than current,
630 use window_outdated only if this is not so. This change should also
631 address some weird issues discussed in Bug#13012.
632 * window.h (window_outdated): New prototype.
633 * window.c (window_outdated): Now here. Convert from static and
634 always assume window's buffer.
635 (Fwindow_end, Fwindow_line_height): Use it.
636 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
637 and always assume window's buffer.
638 (redisplay_window): Adjust user.
e5eefe9b 639 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
640 check whether mode line should be updated only if selected window
641 shows current buffer.
642 (run_window_scroll_functions): Use eassert for debugging check.
643 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
644
56b5d5b1
DA
6452013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
646
647 * window.c (window_scroll, window_scroll_pixel_based)
648 (window_scroll_line_based): Use bool for booleans.
649
2878ba7e
PE
6502013-08-06 Paul Eggert <eggert@cs.ucla.edu>
651
652 * process.c: Fix minor off-by-one issues in descriptor counts.
653 This shouldn't fix any real bugs, but it cleans up the code a bit.
654 (max_process_desc, max_input_desc): -1, not 0, means none.
655 All uses changed.
656 (delete_input_desc): New function.
657 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
658 (deactivate_process): Scan backwards when recomuting max_process_desc;
659 that should be faster.
660 (init_process_emacs): Initialize max_input_desc.
661
e30b79c1
DA
6622013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
663
664 Use region cache to speedup bidi_find_paragraph_start.
665 * buffer.h (struct buffer): New member bidi_paragraph_cache.
666 Rename cache_long_line_scans to cache_long_scans.
667 * buffer.c (bset_cache_long_line_scans): Rename to
668 bset_cache_long_scans.
669 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
670 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
671 into account.
672 (syms_of_buffer): Rename cache-long-line-scans to
673 cache-long-scans. Adjust docstring.
674 * search.c (newline_cache_on_off):
675 * indent.c (width_run_cache_on_off): Adjust users.
676 * bidi.c (bidi_paragraph_cache_on_off): New function.
677 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
678 * insdel.c (prepare_to_modify_buffer): Invalidate
679 bidi_paragraph_cache if enabled.
680
00012b86
DA
6812013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
682
683 Invalidate region caches only if buffer text is going to be changed.
684 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
685 (modify_text): ...new prototype.
686 (prepare_to_modify_buffer_1): New prototype.
687 * textprop.c (modify_region): Rename to...
688 (modify_text_properties): ...new function.
689 (add_text_properties_1, set_text_properties, Fremove_text_properties)
690 (Fremove_list_of_text_properties): Adjust users.
691 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
692 (modify_text): ...new function.
693 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
694 (prepare_to_modify_buffer_1): ...new function.
695 * casefiddle.c (casify_region):
696 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
697 (Ftranspose_regions): Use modify_text.
698
dc6c0eda
SM
6992013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
700
701 * lisp.mk (lisp): Add nadvice.elc.
702
8f3a2c26
DA
7032013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
704
705 New macro to iterate over live buffers similar to frames.
706 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
707 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
708 Declare buffer-related variables here to offload lisp.h.
709 * buffer.c (Vbuffer_alist): Adjust comment.
710 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
711 (other_buffer_safely):
712 * data.c (store_symval_forwarding):
713 * dispnew.c (Fframe_or_buffer_changed_p):
714 * fileio.c (Fdo_auto_save):
715 * filelock.c (unlock_all_files):
716 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
717
e0fdb694
PE
7182013-08-04 Paul Eggert <eggert@cs.ucla.edu>
719
720 Fix some minor races in hosts lacking mkostemp (Bug#15015).
721 * callproc.c (create_temp_file):
722 * filelock.c (create_lock_file):
723 Assume mkostemp, since it's now provided by Gnulib.
724
63f5c6c2
EZ
7252013-08-04 Eli Zaretskii <eliz@gnu.org>
726
727 * w32.c (mkostemp): New function.
728 (mktemp): Remove, no longer used. Most of the code reused in
729 mkostemp. (Bug#15015)
484ab239 730 (mktemp): Don't undef.
63f5c6c2 731
f0b79313
DA
7322013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
733
734 * dispnew.c (glyph_matrix_count, glyph_pool_count):
735 Move under GLYPH_DEBUG and ENABLE_CHECKING.
736 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
737 (free_glyph_pool, check_glyph_memory): Likewise for
738 all users. Adjust comments where appropriate.
739
98f638d6
PE
7402013-08-03 Paul Eggert <eggert@cs.ucla.edu>
741
742 * composite.h: Minor fixups.
743 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
744 to fix a misspelling, and change it to an inline function while
745 we're at it (it need not be a macro). All uses changed.
746 (composition_method, composition_valid_p):
747 Rewrite to avoid assignments in if-conditions.
748
75c59fb3
DA
7492013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
750
751 Do not use global Lisp_Object in composition macros.
752 * composite.h (composition_temp): Remove declaration.
753 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
754 (composition_method, composition_valid_p): ...inline functions.
416a3e01 755 (compose_region): Remove the leftover.
75c59fb3
DA
756 * composite.c (composition_temp): Remove.
757 (run_composition_function, update_compositions)
758 (composition_compute_stop_pos, composition_adjust_point)
759 (Ffind_composition_internal):
760 * coding.c (handle_composition_annotation):
761 * xdisp.c (handle_composition_prop, check_point_in_composition):
762 Related users changed.
763
a10c8269
DA
7642013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
765
766 Drop FRAME_PTR typedef.
767 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
768 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
769 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
770 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
771 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
772 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
773 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
774 All related users changed.
775
a104f656
SM
7762013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
777
778 * eval.c (default_toplevel_binding): New function.
779 (Fdefvar): Use it.
780 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
781 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
782 (syms_of_eval): Export them.
783 * data.c (Fdefault_value): Micro cleanup.
784 * term.c (init_tty): Use "false".
785
4b5c9326
DA
7862013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Fix X GC leak in GTK and raw (no toolkit) X ports.
789 * xterm.c (x_free_frame_resources): If white and black relief
790 GCs are allocated, always free them here.
791 * xfns.c (x_make_gc): Omit redundant initialization.
792 * widget.c (create_frame_gcs): Remove the leftover.
793 (EmacsFrameDestroy): Do nothing because all GCs are now freed
794 in x_free_frame_resources.
795
b19aa636
JD
7962013-08-02 Jan Djärv <jan.h.d@swipnet.se>
797
798 * nsterm.m (windowWillResize:toSize:): Only change title if
799 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
800 modifying it.
801 (viewDidEndLiveResize): New method.
802
803 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
804 inside NS_IMPL_COCOA.
805
af1f7e06
DA
8062013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
807
808 * insdel.c (adjust_after_replace, replace_range, del_range_2):
809 Do not check whether undo is enabled because record_insert and
810 record_delete does that themselves.
811
65b02bb9
DA
8122013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
813
814 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
815 member which is not really used any more.
816 (FRAME_XIC_BASE_FONTNAME): Remove.
817 * xfns.c (xic_free_fontset): Adjust user.
818 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
819 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
820 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
821 (xdialog_show): Use eassert for debugging check.
7ee0f047 822 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 823
6318cde0
PE
8242013-08-01 Paul Eggert <eggert@cs.ucla.edu>
825
826 * fileio.c, fns.c (merge): Move extern decl from here ...
827 * lisp.h (merge): ... to here.
828
6c1a09ba
DA
8292013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
830
831 Fix last font-related change.
832 * w32font.h (w32font_list_internal, w32font_match_internal):
833 Fix prototype.
834 * w32uniscribe.c (uniscribe_list, uniscribe_match):
835 (uniscribe_list_family): Adjust to match font API change.
836 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
837 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
838
f8c20208
DA
8392013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
840
841 * frame.h (FRAME_MOUSE_UPDATE):
842 * nsterm.m (ns_frame_up_to_date): Omit redundant check
843 whether hlinfo->mouse_face_mouse_frame is non-NULL.
844
fdb396e2
DA
8452013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
846
847 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
848 * font.h (struct font_driver): Change list, match, and list_family
849 functions to accept struct frame * as first arg.
850 * font.c (font_score, font_compare, font_sort_entities): Remove
851 prototypes.
852 (font_sort_entities, font_list_entities, font_select_entity):
853 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
854 match font API change.
855 * xfont.c (xfont_list, xfont_match, xfont_list_family):
856 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
857 * ftxfont.c (ftxfont_list, ftxfont_match):
858 * xftfont.c (xftfont_list, xftfont_match):
859 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
860 * w32font.c (w32font_list, w32font_match, w32font_list):
861 (w32font_list_internal, w32_font_match_internal): Likewise.
862 * xfaces.c (Fx_family_fonts): Adjust user.
863
52b8a085
DA
8642013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
865
866 Do not use pure Xism x_wm_set_icon_position in non-X ports.
867 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
868 only if HAVE_X_WINDOWS is in use.
869 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
870 * nsterm.m (x_wm_set_icon_position): Remove no-op.
871 * w32term.c (x_wm_set_icon_position): Likewise.
872 * w32fns.c (x_icon): Adjust user.
873
c791c18e
DA
8742013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
875
876 * xterm.c (last_mouse_press_frame): Remove the
877 leftover which is not really used any more.
878 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
879 (x_flush): Call XFlush once per each X display, not frame.
880 This is better because this code always unconditionally skips
881 non-X frames in Vframe_list and issues the only XFlush if we
882 have more than one X frame on the same X display.
2f935d86
DA
883 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
884 Use bool for booleans.
885 (x_draw_glyph_string_background, cvt_string_to_pixel):
886 (cvt_pixel_dtor): Drop unnecessary prototypes.
887 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 888
f435830e
DA
8892013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
890
891 Drop unnecessary functions that deals with frame pixel size.
892 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
893 (x_pixel_height): Drop prototypes.
894 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
895 (x_pixel_height): Drop implementations.
896 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
897 which should be always valid for window frame.
898 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
899 * w32menu.c (Fx_popup_dialog):
900 * xmenu.c (Fx_popup_dialog): Likewise for both.
901
84231434
DA
9022013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
903
904 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
905 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
906 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
907 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
908 and mention nil frame in docstring.
84231434 909
959067a1
DA
9102013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
911
912 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
913 (x_figure_window_size): Likewise. Adjust to return long.
914 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
915 (toplevel): Move Qterminal_live_p to...
916 * terminal.c (toplevel): ...here, make it static, and...
917 (syms_of_terminal): ...DEFSYM here.
918 * frame.h (Qterminal_live_p): Remove declaration.
919 (make_frame, x_figure_window_size): Adjust prototype.
920 * nsfns.m (Fx_create_frame): Use long for window flags.
921
f4b169ce
PE
9222013-07-30 Paul Eggert <eggert@cs.ucla.edu>
923
924 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
925 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
926 Do not assume that emacs_close (INT_MAX) is a no-op.
927
bee6a2c7
DA
9282013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
929
930 * xfaces.c (make_face_cache): For struct face_cache, prefer
931 xmalloc to xzalloc and so avoid redundant call to memset.
932 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
933
d7e6881a
DA
9342013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
935
936 * fringe.c (draw_window_fringes, update_window_fringes)
937 (compute_fringe_widths):
938 * w32term.c (x_draw_glyph_string):
939 * window.c (candidate_window_p, Frecenter):
940 * xfaces.c (realize_basic_faces, realize_default_face)
941 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
942 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
943 * xfns.c (x_set_cursor_color, xic_free_xfontset):
944 * xmenu.c (Fx_menu_bar_open_internal):
945 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
946 * xsettings.c (xft_settings_event):
947 * xterm.c (x_draw_glyph_string, x_had_errors_p):
948 Use bool for booleans. Adjust style and comments where
949 appropriate.
950 * dispextern.h (draw_window_fringes, update_window_fringes)
951 (compute_fringe_widths):
952 * xterm.h (x_had_errors_p): Adjust prototype.
953
ec3058af
DA
9542013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
955
956 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
957 CHECK_LIST. Rewrite the loop to avoid useless local variable.
958
218e0637
DA
9592013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
960
961 * fns.c (toplevel): Remove comment before Fsafe_length because
962 it checks for QUIT.
963
e560aba9
PE
9642013-07-28 Paul Eggert <eggert@cs.ucla.edu>
965
966 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
967
2e5ce5de
EZ
9682013-07-28 Eli Zaretskii <eliz@gnu.org>
969
970 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
971 frame which got the message is still alive, before dereferencing
972 its pointer. (Bug#14970)
973
974 * frame.c (delete_frame): Test "this" frame's minibuffer window to
975 be a live window, before using it as such. (Bug#14970)
976
e95da6d3
EZ
9772013-07-27 Eli Zaretskii <eliz@gnu.org>
978
979 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
980 w32_detect_focus_change instead of doing part of its job by hand.
981 This fixes the problem whereby FOCUS_OUT events were not sent to
982 the event queue.
983
a8f93651
EZ
9842013-07-26 Eli Zaretskii <eliz@gnu.org>
985
fec92060
EZ
986 * process.c (Fprocess_list): Doc fix.
987
a8f93651
EZ
988 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
989 being re-exposed only if it didn't ask to become visible.
990 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
991 was previously iconified. (Bug#14841)
992 (x_iconify_frame): Mark the frame iconified.
993
d5a7a9d9
PE
9942013-07-26 Paul Eggert <eggert@cs.ucla.edu>
995
996 Fix minor problems found by static checking.
997 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
998 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
999
56ea7291
SM
10002013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1001
1002 * eval.c (set_specpdl_old_value): New function.
1003 (unbind_to): Minor simplification.
1004 (get_backtrace_frame): New function.
1005 (Fbacktrace_frame): Use it. Add `base' argument.
1006 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1007 (syms_of_eval): Export backtrace-eval.
1008 * xterm.c (x_focus_changed): Simplify.
1009
9d611ffe
PE
10102013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1013
999c74e3
EZ
10142013-07-24 Eli Zaretskii <eliz@gnu.org>
1015
1016 * xdisp.c (redisplay_window): Instead of moving point out of
1017 scroll margin, reject the force_start method, and try scrolling
1018 instead. (Bug#14780)
1019
198fa217
KB
10202013-07-24 Ken Brown <kbrown@cornell.edu>
1021
1022 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1023 (Bug#14944).
1024
53840e55
PE
10252013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1026
1027 * eval.c (Fprogn): Do not check that BODY is a proper list.
1028 This undoes the previous change. The check slows down the
1029 interpreter, and is not needed to prevent a crash. See
1030 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1031
60967f56
GM
10322013-07-23 Glenn Morris <rgm@gnu.org>
1033
1034 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1035
9ca960e2
PE
10362013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1037
a29c3e6d
PE
1038 Port to GNU/Linux systems with tinfo but not ncurses.
1039 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1040 to decide whether ncurses is being used. Without this change,
1041 GCC complains about tgetent not being declared, on a system
1042 that has tinfo installed but ncurses not installed.
1043
f274311c
PE
1044 * eval.c (Fprogn): Check that BODY is a proper list.
1045
16b0520a
PE
1046 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1047 * data.c (Fsetq_default):
1048 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1049 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1050 (Fcondition_case):
1051 Tune by taking advantage of the fact that ARGS is always a list
1052 when a function is declared to have UNEVALLED args.
1053
9ca960e2
PE
1054 * emacsgtkfixed.c: Port to GCC 4.6.
1055 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1056
afacaa1b
JB
10572013-07-23 Juanma Barranquero <lekktu@gmail.com>
1058
1059 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1060 here to silence compiler warnings.
1061
368a85a4
PE
10622013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1065 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1066 from messing up Emacs's 'struct frame' (Bug#14923).
1067
f4e891b5
PE
10682013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 * alloc.c (make_save_ptr_ptr): Define this function.
1071 It was inadvertently omitted. It's needed only if
1072 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1073
96c8b65e
JD
10742013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1075
1076 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1077 frame have focus (Bug#14895).
1078
ee010797
PE
10792013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Avoid vfork-related deadlock more cleanly.
1082 * callproc.c (child_setup): When the child's exec fails, output
1083 the program name, as that's more useful. Use O_NONBLOCK to avoid
1084 deadlock.
1085 * process.c (create_process_1): Remove; no longer needed.
1086 (create_process): Remove timer hack; no longer needed, now that
1087 the child avoids deadlock.
1088
f0398ec1 10892013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1090
1091 * image.c (Fimage_flush): Fix doc typo.
1092
b2a069c2
PE
10932013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1094
6496aec9
PE
1095 Fix array bounds violation when pty allocation fails.
1096 * process.c (PTY_NAME_SIZE): New constant.
1097 (pty_name): Remove static variable; it's now auto.
1098 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1099 Take pty_name as an arg rather than using a static variable.
1100 All callers changed.
1101 (create_process): Recover pty_flag from process, not from volatile local.
1102 (create_pty): Stay inside array even when pty allocation fails.
1103 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1104
b2a069c2
PE
1105 * lread.c (Fload): Avoid initialization only when lint checking.
1106 Mention that it's needed only for older GCCs.
1107
99107004
KH
11082013-07-20 Kenichi Handa <handa@gnu.org>
1109
1110 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1111 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1112
6b1b199d
AS
11132013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1114
1115 * lread.c (Fload): Avoid uninitialized warning.
1116
4195afc3
PE
11172013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1118
3f5bef16
PE
1119 Fix some minor file descriptor leaks and related glitches.
1120 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1121 (create_lock_file): Use write, not emacs_write.
1122 * image.c (slurp_file, png_load_body):
1123 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1124 (server_accept_connection):
1125 Don't leak an fd on memory allocation failure.
1126 * image.c (slurp_file): Add a cheap heuristic for growing files.
1127 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1128 as that's what the other routines do. Maybe input need not be
1129 blocked at all, but it's better to be consistent.
1130 Avoid undefined behavior when strlen is zero.
1131
4195afc3
PE
1132 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1133 (NSTATICS): Now a constant; doesn't need to be a macro.
1134
a1aeeffe
RS
11352013-07-19 Richard Stallman <rms@gnu.org>
1136
1137 * coding.c (decode_coding_utf_8): Add simple loop for fast
1138 processing of ASCII characters.
1139
63b34baa
PE
11402013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1143
621dd9ac
EZ
11442013-07-19 Eli Zaretskii <eliz@gnu.org>
1145
1146 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1147 unportable 'struct x_display_info'.
1148 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1149 is a portable type.
1150
1396ac86
PE
11512013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1152
ab9980cd
PE
1153 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1154 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1155 or fscanf fails.
1156 (system_process_attributes): Prefer plain char to unsigned char
1157 when either will do. Clean up properly if interrupted or if
1158 memory allocations fail. Don't assume sscanf succeeds. Remove
1159 no-longer-needed workaround to stop GCC from whining. Read
1160 command-line once, instead of multiple times. Check read status a
1161 bit more carefully.
1162
1396ac86
PE
1163 Fix obscure porting bug with varargs functions.
1164 The code assumed that int is treated like ptrdiff_t in a vararg
1165 function, which is not a portable assumption. There was a similar
1166 -- though these days less likely -- porting problem with various
1167 assumptions that pointers of different types all smell the same as
1168 far as vararg functions is conserved. To make this problem less
1169 likely in the future, redo the API to use varargs functions.
1170 * alloc.c (make_save_value): Remove this vararg function.
1171 All uses changed to ...
1172 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1173 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1174 New functions.
1175 (make_save_ptr): Rename from make_save_pointer, for consistency with
1176 the above. Define only on platforms that need it. All uses changed.
1177
4d19d194
PE
11782013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1179
1180 * keyboard.c: Try to fix typos in previous change.
1181 (DISPLAY_LIST_INFO): New macro.
1182 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1183 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1184
945c5bb1
JB
11852013-07-18 Juanma Barranquero <lekktu@gmail.com>
1186
1187 * keyboard.c (kbd_buffer_get_event):
1188 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1189 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1190
f4b1eb36
PE
11912013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1192
5e679a2c
PE
1193 * filelock.c: Fix unlikely file descriptor leaks.
1194 (get_boot_time_1): Rework to avoid using emacs_open.
1195 This doesn't actually fix a leak, but is better anyway.
1196 (read_lock_data): Use read, not emacs_read.
1197
a8cd4836
PE
1198 * doc.c: Fix minor memory and file descriptor leaks.
1199 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1200 (get_doc_string, Fsnarf_documentation):
1201 Fix file descriptor leak on error.
1202
ef30e638
PE
1203 * term.c: Fix minor fdopen-related file descriptor leaks.
1204 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1205 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1206
f4b1eb36
PE
1207 * charset.c: Fix file descriptor leaks and errno issues.
1208 Include <errno.h>.
1209 (load_charset_map_from_file): Don't leak file descriptor on error.
1210 Use plain record_xmalloc since the allocation is larger than
1211 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1212 of entries.
1213 * eval.c (record_unwind_protect_nothing):
1214 * fileio.c (fclose_unwind):
1215 New functions.
1216 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1217 The replacement doesn't block input, but that no longer seems
1218 necessary.
1219
b648c163
PE
12202013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1221
a0931322
PE
1222 * lread.c: Fix file descriptor leaks and errno issues.
1223 (Fload): Close some races that leaked fds or streams when 'load'
1224 was interrupted.
1225 (Fload, openp): Report error number of last nontrivial failure to open.
1226 ENOENT counts as trivial.
1227 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1228 New functions.
1229 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1230 now that the function is always called with a nonnegative arg.
1231 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1232 All uses replaced with ...
1233 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1234
b648c163
PE
1235 A few more minor file errno-reporting bugs.
1236 * callproc.c (Fcall_process):
1237 * doc.c (Fsnarf_documentation):
1238 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1239 * process.c (set_socket_option):
1240 Don't let a constructor trash errno.
1241 * doc.c: Include <errno.h>.
1242
b1dc4084
JB
12432013-07-16 Juanma Barranquero <lekktu@gmail.com>
1244
1245 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1246
c43843aa
PE
12472013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1248
50a30cce
PE
1249 Fix w32 bug with call-process-region (Bug#14885).
1250 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1251 to Fcall_process when the input is empty. This simplifies the
1252 code a bit. It makes no difference on POSIXish platforms but
1253 apparently it fixes a bug on w32.
1254
44e18199 1255 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1256 * fileio.c (close_file_unwind): Don't close if FD is negative;
1257 this can happen when unwinding a zapped file descriptor.
1258 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1259 in case Emacs runs out of memory between the two unwind-protects.
1260 Don't trash errno when closing FD.
1261 Zap the FD in the specpdl when closing it, instead of deferring
1262 the removal of the unwind-protect; this fixes a bug where a child
1263 function unwinds the stack past us.
1264
27e498e6
PE
1265 New unwind-protect flavors to better type-check C callbacks.
1266 This also lessens the need to write wrappers for callbacks,
1267 and the need for make_save_pointer.
1268 * alloca.c (free_save_value):
1269 * atimer.c (run_all_atimers):
1270 Now extern.
1271 * alloc.c (safe_alloca_unwind):
1272 * atimer.c (unwind_stop_other_atimers):
1273 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1274 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1275 * minibuf.c (choose_minibuf_frame_1):
1276 * process.c (make_serial_process_unwind):
1277 * xdisp.h (pop_message_unwind):
1278 * xselect.c (queue_selection_requests_unwind):
1279 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1280 * alloca.c (record_xmalloc):
1281 Prefer record_unwind_protect_ptr to record_unwind_protect with
1282 make_save_pointer.
1283 * alloca.c (Fgarbage_collect):
1284 Prefer record_unwind_protect_void to passing a dummy.
1285 * buffer.c (restore_buffer):
1286 * window.c (restore_window_configuration):
1287 * xfns.c, w32fns.c (do_unwind_create_frame)
1288 New wrapper. All record-unwind uses of wrappee changed.
1289 * buffer.c (set_buffer_if_live):
1290 * callproc.c (call_process_cleanup, delete_temp_file):
1291 * coding.c (code_conversion_restore):
1292 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1293 * editfns.c (save_excursion_restore)
1294 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1295 (save_restriction_restore):
1296 * eval.c (restore_stack_limits, un_autoload):
1297 * fns.c (require_unwind):
1298 * keyboard.c (recursive_edit_unwind, tracking_off):
1299 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1300 * macros.c (pop_kbd_macro, restore_menu_items):
1301 * nsfns.m (unwind_create_frame):
1302 * print.c (print_unwind):
1303 * process.c (start_process_unwind):
1304 * search.c (unwind_set_match_data):
1305 * window.c (select_window_norecord, select_frame_norecord):
1306 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1307 (fast_set_selected_frame):
1308 * xfns.c, w32fns.c (unwind_create_tip_frame):
1309 Return void, not a dummy Lisp_Object. All uses changed.
1310 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1311 * callproc.c (call_process_kill):
1312 * fileio.c (restore_point_unwind, decide_coding_unwind)
1313 (build_annotations_unwind):
1314 * insdel.c (Fcombine_after_change_execute_1):
1315 * keyboard.c (read_char_help_form_unwind):
1316 * menu.c (unuse_menu_items):
1317 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1318 * sound.c (sound_cleanup):
1319 * xdisp.c (unwind_redisplay):
1320 * xfns.c (clean_up_dialog):
1321 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1322 Accept no args and return void, instead of accepting and returning
1323 a dummy Lisp_Object. All uses changed.
1324 * cygw32.c (fchdir_unwind):
1325 * fileio.c (close_file_unwind):
1326 * keyboard.c (restore_kboard_configuration):
1327 * lread.c (readevalllop_1):
1328 * process.c (wait_reading_process_output_unwind):
1329 Accept int and return void, rather than accepting an Emacs integer
1330 and returning a dummy object. In some cases this fixes an
1331 unlikely bug when the corresponding int is outside Emacs integer
1332 range. All uses changed.
1333 * dired.c (directory_files_internal_unwind):
1334 * fileio.c (do_auto_save_unwind):
1335 * gtkutil.c (pop_down_dialog):
1336 * insdel.c (reset_var_on_error):
1337 * lread.c (load_unwind):
1338 * xfns.c (clean_up_file_dialog):
1339 * xmenu.c, nsmenu.m (pop_down_menu):
1340 * xmenu.c (cleanup_widget_value_tree):
1341 * xselect.c (wait_for_property_change_unwind):
1342 Accept pointer and return void, rather than accepting an Emacs
1343 save value encapsulating the pointer and returning a dummy object.
1344 All uses changed.
1345 * editfns.c (Fformat): Update the saved pointer directly via
1346 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1347 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1348 (unwind_body): New function.
1349 (record_unwind_protect): First arg is now a function returning void,
1350 not a dummy Lisp_Object.
1351 (record_unwind_protect_ptr, record_unwind_protect_int)
1352 (record_unwind_protect_void): New functions.
1353 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1354 * fileio.c (struct auto_save_unwind): New type.
1355 (do_auto_save_unwind): Use it.
1356 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1357 * insdel.c (struct rvoe_arg): New type.
1358 (reset_var_on_error): Use it.
1359 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1360 New constants.
1361 (specbinding_func): Remove; there are now several such functions.
1362 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1363 (set_unwind_protect_ptr): New function.
1364 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1365
4e604a5d
PE
1366 Be simpler and more consistent about reporting I/O errors.
1367 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1368 Say "Read error" and "Write error", rather than "I/O error", or
1369 "IO error reading", or "IO error writing", when a read or write
1370 error occurs.
1371 * process.c (Fmake_network_process, wait_reading_process_output)
1372 (send_process, Fprocess_send_eof, wait_reading_process_output):
1373 Capitalize diagnostics consistently. Put "failed foo" at the
1374 start of the diagnostic, so that we don't capitalize the
1375 function name "foo". Consistently say "failed" for such
1376 diagnostics.
1377 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1378 All callers changed. This is so it can use report_file_error.
1379 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1380 diagnostics consistently as above.
1381
a9757f6a
PE
1382 * fileio.c (report_file_errno): Fix errno reporting bug.
1383 If the file name is neither null nor a pair, package it up as a
1384 singleton list. All callers changed, both to this function and to
1385 report_file_error. This fixes a bug where the memory allocator
1386 invoked by list1 set errno so that the immediately following
1387 report_file_error reported the wrong errno value.
1388
c43843aa
PE
1389 Fix minor problems found by --enable-gcc-warnings.
1390 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1391 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1392
18c26d81
JD
13932013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1394
1395 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1396 Set event->arg to Qt if switch-event shall be generated.
1397 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1398
1399 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1400
1401 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1402 FOCUS_OUT_EVENT.
1403
1404 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1405 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1406 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1407 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1408 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1409 and there is a focused frame.
1410 (head_table): Add focus-in and focus-out.
1411 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1412 bind to handle-focus-in/out.
1413
1414 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1415 (Fhandle_switch_frame): Call Fhandle_focus_in.
1416 (syms_of_frame): defsubr handle-focus-in/out.
1417
6c6f1994
PE
14182013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1419
c7ddc792
PE
1420 Fix porting bug to older POSIXish platforms (Bug#14862).
1421 * sysdep.c (emacs_pipe): New function, that implements
1422 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1423 This should port better to CentOS 5 and to Mac OS X 10.6.
1424 All calls to pipe2 changed.
1425
6c6f1994
PE
1426 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1427 This makes the code easier to read and the executable a bit smaller.
1428 Do not replace all calls to Fcons that happen to create lists,
1429 just calls that are intended to create lists. For example, when
1430 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1431 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1432 Similarly for list2 through list5.
1433 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1434 * bytecode.c (exec_byte_code):
1435 * callint.c (quotify_arg, Fcall_interactively):
1436 * callproc.c (Fcall_process, create_temp_file):
1437 * charset.c (load_charset_map_from_file)
1438 (Fdefine_charset_internal, init_charset):
1439 * coding.c (get_translation_table, detect_coding_system)
1440 (Fcheck_coding_systems_region)
1441 (Fset_terminal_coding_system_internal)
1442 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1443 * composite.c (update_compositions, Ffind_composition_internal):
1444 * dired.c (directory_files_internal, file_name_completion)
1445 (Fsystem_users):
1446 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1447 * doc.c (Fsnarf_documentation):
1448 * editfns.c (Fmessage_box):
1449 * emacs.c (main):
1450 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1451 (Feval, eval_sub, Ffuncall, apply_lambda):
1452 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1453 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1454 (Fset_file_times, Finsert_file_contents)
1455 (Fchoose_write_coding_system, Fwrite_region):
1456 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1457 * font.c (font_registry_charsets, font_parse_fcname)
1458 (font_prepare_cache, font_update_drivers, Flist_fonts):
1459 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1460 * frame.c (make_frame, Fmake_terminal_frame)
1461 (x_set_frame_parameters, x_report_frame_params)
1462 (x_default_parameter, Fx_parse_geometry):
1463 * ftfont.c (syms_of_ftfont):
1464 * image.c (gif_load):
1465 * keyboard.c (command_loop_1):
1466 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1467 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1468 (Fminor_mode_key_binding, accessible_keymaps_1)
1469 (Faccessible_keymaps, Fwhere_is_internal):
1470 * lread.c (read_emacs_mule_char):
1471 * menu.c (find_and_return_menu_selection):
1472 * minibuf.c (get_minibuffer):
1473 * nsfns.m (Fns_perform_service):
1474 * nsfont.m (ns_script_to_charset):
1475 * nsmenu.m (ns_popup_dialog):
1476 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1477 (Fx_own_selection_internal):
1478 * nsterm.m (append2):
1479 * print.c (Fredirect_debugging_output)
1480 (print_prune_string_charset):
1481 * process.c (Fdelete_process, Fprocess_contact)
1482 (Fformat_network_address, set_socket_option)
1483 (read_and_dispose_of_process_output, write_queue_push)
1484 (send_process, exec_sentinel):
1485 * sound.c (Fplay_sound_internal):
1486 * textprop.c (validate_plist, add_properties)
1487 (Fput_text_property, Fadd_face_text_property)
1488 (copy_text_properties, text_property_list, syms_of_textprop):
1489 * unexaix.c (report_error):
1490 * unexcoff.c (report_error):
1491 * unexsol.c (unexec):
1492 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1493 (Fformat_mode_line, syms_of_xdisp):
1494 * xfaces.c (set_font_frame_param)
1495 (Finternal_lisp_face_attribute_values)
1496 (Finternal_merge_in_global_face, syms_of_xfaces):
1497 * xfns.c (x_default_scroll_bar_color_parameter)
1498 (x_default_font_parameter, x_create_tip_frame):
1499 * xfont.c (xfont_supported_scripts):
1500 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1501 (menu_help_callback, xmenu_show):
1502 * xml.c (make_dom):
1503 * xterm.c (set_wm_state):
1504 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1505 and similarly for list2 through list5.
1506
bafe80ce
PE
15072013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * callproc.c (Fcall_process_region): Fix minor race and tune.
1510 (create_temp_file): New function, with the temp-file-creation part
1511 of the old Fcall_process_region. Use Fcopy_sequence to create the
1512 temp file name, rather than alloca + build_string, for simplicity.
1513 Don't bother to block input around the temp file creation;
1514 shouldn't be needed. Simplify use of mktemp. Use
1515 record_unwind_protect immediately after creating the temp file;
1516 this closes an unlikely race where the temp file was not removed.
1517 Use memcpy rather than an open-coded loop.
1518 (Fcall_process_region): Use the new function. If the input is
1519 empty, redirect from /dev/null rather than from a newly created
1520 empty temp file; this avoids unnecessary file system traffic.
1521
4700b5a5
PE
15222013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1523
5c97beae
PE
1524 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1525 Simplify by making this case like the other two. This is a bit
1526 slower on obsolete hosts, but the extra complexity isn't worth it.
1527
4700b5a5
PE
1528 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1529 * process.c (create_process) [!DOS_NT]:
1530 Remove now-unnecessary calls to emacs_close.
1531
f9a74c4c
EZ
15322013-07-13 Eli Zaretskii <eliz@gnu.org>
1533
922ae7ee
EZ
1534 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1535 returning early. (Bug#14850)
1536
f9a74c4c
EZ
1537 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1538 and inhibit-iso-escape-detection attributes of 'undecided'.
1539 (Bug#14822)
1540
5e301d76
PE
15412013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1542
69e0e5ee
PE
1543 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1544 Reported by Herbert J. Skuhra in
1545 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1546
5e301d76
PE
1547 Don't lose top specpdl entry when memory is exhausted.
1548 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1549 specpdl overflow here, to simplify callers; all callers changed.
1550 Always reserve an unused entry at the stack top; this avoids
1551 losing the top entry's information when memory is exhausted.
1552
7e649856
PE
15532013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1554
a773ed9a
PE
1555 Clean up errno reporting and fix some errno-reporting bugs.
1556 * callproc.c (Fcall_process):
1557 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1558 * process.c (create_process, Fmake_network_process):
1559 * unexaix.c (report_error):
1560 * unexcoff.c (report_error):
1561 Be more careful about reporting the errno of failed operations.
1562 The code previously reported the wrong errno sometimes.
1563 Also, prefer report_file_errno to setting errno + report_file_error.
1564 (Fcall_process): Look at openp return value rather than at path,
1565 as that's a bit faster and clearer when there's a numeric predicate.
1566 * fileio.c (report_file_errno): New function, with most of the
1567 old contents of report_file_error.
1568 (report_file_error): Use it.
1569 (Ffile_exists_p, Ffile_accessible_directory_p):
1570 Set errno to 0 when it is junk.
1571 * fileio.c (Faccess_file):
1572 * image.c (x_create_bitmap_from_file):
1573 Use faccessat rather than opening the file, to avoid the hassle of
1574 having a file descriptor open.
1575 * lisp.h (report_file_errno): New decl.
1576 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1577
7e649856
PE
1578 Minor EBADF fixes.
1579 * process.c (create_process, wait_reading_process_output) [AIX]:
1580 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1581 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1582 a multithreaded environment anyway).
1583 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1584
f6774c1a
AS
15852013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1586
1587 * image.c (x_find_image_file): Don't close a remote file handle.
1588
bacba3c2
PE
15892013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 Fix races with threads and file descriptors.
1592 * callproc.c (Fcall_process_region):
1593 * dired.c (open_directory):
1594 * emacs.c (main, Fdaemon_initialized):
1595 * image.c (x_find_image_file):
1596 * inotify.c (Finotify_rm_watch):
1597 * lread.c (Flocate_file_internal):
1598 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1599 * term.c (term_mouse_moveto, init_tty):
1600 * termcap.c (tgetent):
1601 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1602 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1603 * unexhp9k800.c, unexmacosx.c (unexec):
1604 * callproc.c (Fcall_process_region):
1605 Use emacs_close, not close.
1606 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1607 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1608 and posix_close function on current platforms (which all lack them).
1609 (emacs_close): Use it. This should fix the races on GNU/Linux and
1610 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1611 and it should avoid closing random victim file descriptors on
1612 other platforms.
1613
653d4f43
PE
16142013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1615
c8536ec4
PE
1616 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1617 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1618 Touch up doc a bit.
1619
9c203066
PE
1620 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1621 This is for .gdbinit xbacktrace.
1622
653d4f43
PE
1623 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1624 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1625 (emacs_set_tty): Now static.
1626 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1627 * term.c (tty_capable_p, tty_default_color_capabilities)
1628 (get_tty_terminal, term_mouse_movement)
1629 (handle_one_term_event, init_tty, maybe_fatal):
1630 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1631 (tgetent, scan_file, name_match, compare_contin):
1632 * terminal.c (get_terminal):
1633 Use bool for boolean.
1634 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1635 Prefer char to unsigned char if either will do.
1636 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1637 (tty_write_glyphs): Prefer int to unsigned.
1638 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1639 All callers changed.
1640 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1641
45b683a1
PE
16422013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1643
29abe551
PE
1644 Port to C89.
1645 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1646 (B__dummy__): New dummy symbol, to pacify C89.
1647 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1648 they can't grok varargs macros.
1649 * dispnew.c (add_window_display_history)
1650 (add_frame_display_history):
1651 * print.c (print_object):
1652 * xdisp.c (debug_method_add):
1653 Use %p printf format only for void pointers.
1654 * emacs.c (usage_message): New constant, replacing ...
1655 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1656 (main): Adjust to usage reorg.
1657 * fns.c (syms_of_fns):
1658 * profiler.c (syms_of_profiler):
1659 Don't use non-constant struct initializers.
1660 * gnutls.h (gnutls_initstage_t):
1661 * lisp.h (enum Lisp_Fwd_Type):
1662 * lread.c (lisp_file_lexically_bound_p):
1663 * xsettings.c (anonymous enum):
1664 Remove trailing comma.
1665 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1666 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1667 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1668 (DEFUN): Use it.
1669 * regex.c (const_re_char): New type, to pacify strict C89.
1670 All uses of 'const re_char' replaced to use it.
1671 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1672 with glibc when strict C89. This change is imported from gnulib.
1673 All uses changed.
1674 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1675 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1676 Omit GNU_LINUX implementation, since it requires long long.
1677 * xterm.c (x_draw_underwave):
1678 Do not assume the traditional order of struct's members.
1679 (x_term_init): Rewrite to avoid the need for non-constant structure
1680 initializers.
1681
45b683a1 1682 Syntax cleanup, mostly replacing macros with functions.
763a086d 1683 This removes the need for the syntax_temp hack.
45b683a1
PE
1684 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1685 * syntax.c (SYNTAX_INLINE): New macro.
1686 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1687 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1688 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1689 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1690 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1691 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1692 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1693 Now constants, not macros.
1694 (syntax_temp) [!__GNUC__]: Remove.
1695 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1696 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1697 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1698 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1699 Move here from syntax.h; now functions, not macros. Except for the
1700 last function, these are static since only syntax.c uses them.
1701 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1702 All uses changed. Now a function, not a macro; use this fact
1703 to simplify the code.
1704 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1705 compiler bugs; no longer relevant.
1706 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1707 (SYNTAX_INLINE): New macro.
1708 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1709 for the new functions. Use bool for boolean member.
1710 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1711 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1712 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1713 (SETUP_BUFFER_SYNTAX_TABLE):
1714 Now extern inline functions, not macros.
1715 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1716 Remove; all uses replaced by implementation.
1717 (syntax_temp) [!__GNUC__]: Remove decl.
1718 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1719
29be4a50
JD
17202013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1721
1722 * emacs.c (main): Fix syntax error.
1723
954b166e
PE
17242013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 Timestamp fixes for undo (Bug#14824).
1727 * atimer.c (schedule_atimer):
1728 * fileio.c (Ffile_newer_than_file_p):
1729 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1730 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1731 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1732 (syms_of_fileio): Remove Sclear_visited_file_name.
1733 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1734 file doesn't exist; this avoids an ambiguity with negative timestamps.
1735 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1736 * systime.h (make_emacs_time, invalid_emacs_time):
1737 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1738 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1739 * undo.c (record_first_change): Push (visited-file-modtime) onto
1740 undo list rather than reimplementing it by hand, incorrectly.
1741
d74647c3
KB
17422013-07-09 Ken Brown <kbrown@cornell.edu>
1743
1744 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1745
3c51b96b
JB
17462013-07-09 Juanma Barranquero <lekktu@gmail.com>
1747
1748 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1749
4ebbdd67
PE
17502013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 Handle errno and exit status a bit more carefully.
1753 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1754 number into an exit status. Instead, use EXIT_CANCELED.
1755 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1756 * callproc.c (relocate_fd):
1757 * emacs.c (close_output_streams, main):
1758 * process.c (create_process):
1759 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1760 Use emacs_perror for simplicity.
1761 * callproc.c (relocate_fd, main):
1762 * sysdep.c (sys_subshell):
1763 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1764 (shut_down_emacs): Use emacs_write, not write.
1765 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1766 * fileio.c (Fcopy_file, e_write):
1767 * nsterm.m (ns_select):
1768 * process.c (send_process):
1769 * sound.c (vox_write):
1770 Use emacs_write_sig, not emacs_write.
1771 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1772 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1773 New constants.
1774 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1775 of write.
1776 (emacs_full_write): New function.
1777 (emacs_write): Rewrite to use it.
1778 (emacswrite_sig, emacs_perror): New functions.
1779 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1780
44e18199 17812013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1782
1783 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1784 on NS even if it is present. Pixmap on NS is a void*.
1785
9caab067
PE
17862013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 Port to Ubuntu 10 (Bug#14803).
1789 Problem reported by T.V. Raman.
1790 * process.c (close_on_exec, accept4, process_socket):
1791 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1792
1d442672
EZ
17932013-07-07 Eli Zaretskii <eliz@gnu.org>
1794
1795 * w32.c (sys_dup): Declare prototype.
1796
1797 * filelock.c:
1798 * emacs.c:
1799 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1800
067428c1
PE
18012013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 Make file descriptors close-on-exec when possible (Bug#14803).
1804 This simplifies Emacs a bit, since it no longer needs to worry
1805 about closing file descriptors by hand in some cases.
1806 It also fixes some unlikely races. Not all such races, as
1807 libraries often open files internally without setting
1808 close-on-exec, but it's an improvement.
1809 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1810 * callproc.c (Fcall_process) [!MSDOS]:
1811 * emacs.c (main) [!DOS_NT]:
1812 * nsterm.m (ns_term_init):
1813 * process.c (create_process):
1814 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1815 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1816 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1817 Prefer mkostemp with O_CLOEXEC to mkstemp.
1818 * callproc.c (relocate_fd) [!WINDOWSNT]:
1819 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1820 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1821 now using pipe2.
1822 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1823 Make the resulting file descriptor close-on-exec.
1824 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1825 * lread.c (load_descriptor_list, load_descriptor_unwind):
1826 Remove; no longer needed. All uses removed.
1827 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1828 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1829 New functions.
1830 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1831 (Fmake_network_process, Fnetwork_interface_list):
1832 (Fnetwork_interface_info, server_accept_connection):
1833 Make newly-created socket close-on-exec.
1834 * sysdep.c (emacs_open, emacs_fopen):
1835 Make new-created descriptor close-on-exec.
1836 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1837 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1838
0da857dd
JD
18392013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1840
1841 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1842 for NS_IMPL_GNUSTEP.
1843
5f86adcd
PE
18442013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 Fix openp errno handling.
1847 * callproc.c (Fcall_process): Preserve openp errno around close.
1848 * lread.c (openp): Set errno when returning -1, as some callers
1849 expect this.
1850
1afb1d07
JD
18512013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1852
1853 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1854
1855 * nsterm.h (NSSavePanel): Update comment.
1856 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1857 (ns_run_file_dialog): Declare.
1858
1859 * nsfns.m: Remove panelOK.
1860 (ns_fd_data): New.
1861 (ns_run_file_dialog): New function.
1862 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1863 event loop, so file dialog is popped up by ns_run_file_dialog, called
1864 by sendEvent (Bug#14578).
1865 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1866
3323c263
EZ
18672013-07-06 Eli Zaretskii <eliz@gnu.org>
1868
fdda0220
EZ
1869 * xdisp.c (default_line_pixel_height): New function.
1870 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1871 (try_cursor_movement, redisplay_window, try_window)
1872 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1873
1874 * window.c (window_scroll_pixel_based): use
1875 default_line_pixel_height.
1876
1877 * dispextern.h (default_line_pixel_height): Add prototype.
1878
1879 * frame.c (x_set_line_spacing): Accept a float value for
1880 line-spacing parameter, per the documentation.
1881
3323c263
EZ
1882 * data.c (Fmultibyte_string_p): Doc fix.
1883
47ba6d43
PE
18842013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1885
406af475
PE
1886 Use emacs_open more consistently when opening files.
1887 This handles EINTR more consistently now, and makes it easier
1888 to introduce other uniform changes to file descriptor handling.
1889 * src/systdio.h: New file.
1890 * src/buffer.c (mmap_init):
1891 * cygw32.c (chdir_to_default_directory):
1892 * dispnew.c (Fopen_termscript):
1893 * emacs.c (Fdaemon_initialized):
1894 * fileio.c (Fdo_auto_save):
1895 * image.c (slurp_file, png_load_body, jpeg_load_body):
1896 * keyboard.c (Fopen_dribble_file):
1897 * lread.c (Fload):
1898 * print.c (Fredirect_debugging_output):
1899 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1900 * termcap.c (tgetent):
1901 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1902 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1903 * w32term.c (w32_initialize) [CYGWIN]:
1904 * xfaces.c (Fx_load_color_file):
1905 Use emacs_open instead of plain open, and emacs_fopen instead of
1906 plain fopen.
1907 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1908 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1909 * callproc.c (default_output_mode): New constant.
1910 (Fcall_process): Use it to call emacs_open instead of plain creat.
1911 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1912 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1913 (emacs_fopen): New function.
1914 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1915 Include <lisp.h>, for emacs_open.
1916 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1917
47ba6d43
PE
1918 Remove duplicate #include directives.
1919 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1920 * xfaces.c:
1921 Don't include stdio.h twice.
1922 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1923 Don't include sys/types.h or stdio.h twice.
1924 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1925 * lread.c: Don't include coding.h twice.
1926 * nsfont.m: Don't include frame.h twice.
1927 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1928 * ralloc.c: Don't include <unistd.h> twice.
1929 * xdisp.c: Don't include font.h twice.
1930 * xterm.c: Don't include fontset.h twice.
1931 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1932
b9ed53d5
PE
19332013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1934
1935 Scale ImageMagick images more carefully.
1936 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1937 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1938 Be more careful about avoiding undefined behavior after
1939 integer overflow and division by zero.
1940
cf13177e
YM
19412013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1942
1943 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1944 (syms_of_w32fns): DEFSYM them.
1945 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1946 (CCHDEVICENAME): Define macros if not defined.
1947 (struct MONITOR_INFO_EX): New struct.
1948 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1949 (enum_display_monitors_fn): New variable.
1950 (globals_of_w32fns): Initialize it.
1951 (Fx_display_pixel_width, Fx_display_pixel_height)
1952 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1953 multi-monitor setups in docstrings.
1954 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1955 screen size by primary monitor's millimeter per pixel.
1956 (w32_monitor_enum, w32_display_monitor_attributes_list)
1957 (w32_display_monitor_attributes_list_fallback)
1958 (Fw32_display_monitor_attributes_list): New functions.
1959 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1960
1961 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1962 if not defined.
1963 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1964
86dfb7a8
MA
19652013-07-04 Michael Albinus <michael.albinus@gmx.de>
1966
1967 * fileio.c (Qfile_notify_error): New error symbol.
1968
1969 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1970 * inotify.c (inotify_callback, symbol_to_inotifymask)
1971 (Finotify_add_watch, Finotify_rm_watch): Use it.
1972 (inotifyevent_to_event): Exchange order of cookie and file name.
1973 (Finotify_add_watch): Adapt docstring.
1974
1975 * lisp.h (Qfile_notify_error): Declare.
1976
2c1c974b
PE
19772013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1980 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1981 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1982 which did not work (see <http://bugs.gnu.org/14569#307>).
1983 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1984 && (!noninteractive || initialized)). This attempts to thread
1985 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1986
7a35b20f
JB
19872013-07-04 Juanma Barranquero <lekktu@gmail.com>
1988
1989 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1990 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1991
1ce5cd04
PE
19922013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1995 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1996 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1997 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1998
57f8c490
PE
19992013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2002 Define to __sys_siglist.
2003
bcffb5ca
EZ
20042013-07-02 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2007 word-wrap, so that overflow-newline-into-fringe would work in
2008 visual-line-mode. (Bug#2749)
2009 (move_it_in_display_line_to): When the last scanned display
2010 element fits exactly on the display line, and
2011 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2012 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2013 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2014 finding buffer position that corresponds to pixel coordinates,
2015 e.g. in buffer_posn_from_coords.
2016
2c41e781
JD
20172013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2018
2019 * process.c (handle_child_signal): Call catch_child_signal if
2020 NS_IMPL_GNUSTEP.
2021
c2418359
PE
20222013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2023
52a9bcae
PE
2024 Don't convert function pointers to void * and back.
2025 It isn't portable C, and it's easy enough to avoid.
2026 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2027 (make_save_value): Add support for SAVE_FUNCPOINTER.
2028 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2029 * print.c (print_object):
2030 Distinguish function from object pointers.
2031 * lisp.h (SAVE_FUNCPOINTER): New constant.
2032 (SAVE_SLOT_BITS): Adjust to it.
2033 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2034 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2035 (voidfuncptr): New typedef.
2036 (struct Lisp_Save_Value): New member data[0].funcpointer.
2037 (XSAVE_FUNCPOINTER): New function.
2038
c2418359
PE
2039 Simplify buildobj processing.
2040 * Makefile.in (buildobj.h): Make it a sequence of strings each
2041 followed by comma, rather than a single string. Put it into a
2042 .tmp file in case there's an error while generating it.
2043 (gl-stamp): Use .tmp for temp files.
2044 (mostlyclean): Clean .tmp files.
2045 * doc.c (buildobj): Move to just the routine that needs it.
2046 It's now an array of strings, so processing is simpler.
2047
8f43ce49
PE
20482013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2051 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2052 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2053 Invoke malloc_enable_thread even when not interactive.
2054 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2055 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2056 in this case, since the underlying bug has now been fixed.
2057
24827db9
JB
20582013-07-01 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2061 unlinking it (bug#14691).
2062
ef099a94
MN
20632013-06-30 Michal Nazarewicz <mina86@mina86.com>
2064
2065 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2066 before checking whether buffer is modified. This lets
2067 `kill-buffer-query-functions' cancel killing of the buffer or save
2068 its content before `kill-buffer' asks user the "Buffer %s
2069 modified; kill anyway?" question.
2070
9d3f2fc2
JD
20712013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2072
2073 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2074 Let the super performKeyEquivalent deal with them (Bug#14747).
2075
e6c6c8c7
PE
20762013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2077
1d71c1d9
PE
2078 * widget.c (resize_cb): Remove unused local.
2079
8f5f35cc
PE
2080 Do not use GTK 3 if it exists but cannot be compiled.
2081 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2082 * xterm.c (x_error_handler) [!USE_GTK]:
2083 Do not use GTK 3.
2084
e6c6c8c7
PE
2085 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2086
0ba54312
EZ
20872013-06-30 Eli Zaretskii <eliz@gnu.org>
2088
5d1c3286
EZ
2089 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2090 to the valid range of values. (Bug#14753)
2091
0ba54312
EZ
2092 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2093 when moving point by using the current glyph matrix. This avoids
2094 the need to force redisplay when this function is called in a
2095 loop.
2096
9c90cc06
PE
20972013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 Fix minor problems found by static checking.
2100 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2101 Redo the latter's body to sidestep GCC parenthesization warnings.
2102 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2103 * coding.c (detect_coding, detect_coding_system):
2104 * coding.h (struct undecided_spec):
2105 Use bool for boolean.
2106 * image.c (QCmax_width, QCmax_height): Now static.
2107 * xdisp.c (Fmove_point_visually): Remove unused local.
2108
4c672a0f
EZ
21092013-06-29 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (Fmove_point_visually): New function.
2112
c1ea3abf
JB
21132013-06-28 Kenichi Handa <handa@gnu.org>
2114
2115 * coding.h (define_coding_undecided_arg_index): New enum.
2116 (coding_attr_index): New members
2117 coding_attr_undecided_inhibit_null_byte_detection,
2118 coding_attr_undecided_inhibit_iso_escape_detection,
2119 coding_attr_undecided_prefer_utf_8.
2120 (undecided_spec): New struct.
2121 (struct coding_system): New member `undecided' of the member
2122 `spec'.
2123
2124 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2125 (detect_coding): Likewise.
2126 (detect_coding_system): Likewise.
2127 (Fdefine_coding_system_internal): New coding system properties
2128 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2129 :prefer-utf-8.
2130 (syms_of_coding): Adjust for coding_arg_undecided_max.
2131
ba3de9e6
PE
21322013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 * image.c (x_from_xcolors): Remove unused local.
2135
547c9269
YM
21362013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2137
2138 Defer image data transfer between X client and server until actual
2139 display happens.
2140
2141 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2142 and `mask_img'.
2143
2144 * image.c (Destroy_Image): Remove.
2145 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2146 `mask_p', and `colors_p'. All uses changed.
2147 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2148 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2149 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2150 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2151 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2152 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2153 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2154 (image_get_x_image, image_unget_x_image): New functions or macros.
2155 (image_background, image_background_transparent, x_to_xcolors)
2156 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2157 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2158 instead of Destroy_Image.
2159 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2160 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2161 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2162 (imagemagick_load_image, svg_load_image): Use them instead of
2163 x_create_x_image_and_pixmap, and x_put_x_image followed by
2164 x_destroy_x_image, respectively.
2165 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2166 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2167 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2168 background_transparent fields.
2169 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2170 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2171
dae2f5ef
PE
21722013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2175 This mostly consists of undoing recent changes.
2176 * callproc.c (Fcall_process):
2177 * process.c (create_process):
2178 Do not worry about catching SIGCHLD here, undoing previous change.
2179 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2180 * process.c, process.h (catch_child_signal):
2181 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2182 * process.c (catch_child_handler): Don't worry about being called
2183 lazily and do not assume caller has blocked SIGCHLD, undoing
2184 previous change. Move first-time stuff back to
2185 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2186 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2187 set lib_child_handler if it's already initialized, which may
2188 help avoid problems on GNUStep.
2189
fa55d2aa
PE
21902013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2191
2192 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2193 * callproc.c (Fcall_process):
2194 * process.c (create_process):
2195 Make sure SIGCHLD is caught before we fork,
2196 since Emacs startup no arranges to catch SIGCHLD.
2197 * process.c (lib_child_handler): Initialize to null, not to
2198 dummy_handler.
2199 (catch_child_signal): Allow self to be called lazily.
2200 Do nothing if it's already been called.
2201 Assume caller has blocked SIGCHLD (all callers do now).
2202 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2203 just before it's really needed.
2204 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2205 since it hasn't been caught yet.
2206
f3f9606c
LMI
22072013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2208
2209 * image.c (compute_image_size): New function to implement
2210 :max-width and :max-height.
2211 (imagemagick_load_image): Use it.
2212
c7041908
PE
22132013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2214
2215 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2216 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2217 Now extern.
2218 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2219 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2220 the SIGCHLD handler, since the code is not atomic and (due to glib)
2221 signals may be arriving now.
2222 * sysdep.c (init_signals): Do not catch child signals here;
2223 'main' now does that later, at a safer time.
2224
f86852b4
PE
22252013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2226
0dfeed58
PE
2227 Clean up SIGCHLD handling a bit (Bug#14569).
2228 * process.c, process.h (catch_child_signal):
2229 Now always extern, even if !NS_IMPL_GNUSTEP.
2230 * process.c (catch_child_signal): Move glib tickler here from
2231 init_process_emacs, so that it's done earlier in Emacs
2232 initialization. Also move the noninteractive && !initialized
2233 check here from init_process_emacs. This is all a bit cleaner for
2234 GNUish platforms, and I hope it works around the Cygwin bug.
2235 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2236 that glib signal handling is tickled before glib creates threads.
2237
f86852b4
PE
2238 * process.c (wait_reading_process_output): Avoid int overflow
2239 when reading more than 2 GiB total from a process.
2240
cbd6509c
PE
22412013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 * process.c (create_process): Handle a couple more cases,
2244 i.e., work even if new_argv and wait_child_setup[i] are cached.
2245 Use Fcall_process's style for volatile vars.
2246
9de1114a
AS
22472013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2248
2249 * process.c (create_process): Mark PROCESS volatile.
2250
fbe9e0b9
PE
22512013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 Use C99-style flexible array members if available.
2254 This avoids some subtle aliasing issues, which typically
2255 aren't a problem with GCC but may be a problem elsewhere.
2256 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2257 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2258 In either case, it uses a flexible array member rather than
2259 the old struct hack. All uses changed.
2260 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2261 Adjust to sdata reorganization.
2262 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2263 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2264 that ports better to pre-C99 non-GCC.
2265 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2266 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2267 as the latter has changed.
2268 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2269 and port better to pre-C99 GCC.
2270 * image.c (struct xpm_cached_color):
2271 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2272 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2273 Use FLEXIBLE_ARRAY_MEMBER.
2274 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2275 Move decl to top level so it gets checked against implementation.
2276 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2277 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2278
1fc71008
PE
22792013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 * syntax.c: Integer cleanups.
2282 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2283 All uses that need 0-or-2 changed to:
2284 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2285 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2286 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2287 (char_quoted, prev_char_comend_first, back_comment)
2288 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2289 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2290 Use bool for boolean.
2291 (update_syntax_table, skip_chars, skip_syntaxes):
2292 Prefer int to unsigned when either will do.
2293 (back_comment): Return boolean success flag, like forw_comment,
2294 instead of positive-or-minus-1 (which might have overflowed int anyway).
2295 Don't stuff ptrdiff_t into int.
2296 (syntax_spec_code, syntax_code_spec): Now const.
2297 (Fmatching_paren, scan_lists, scan_sexps_forward):
2298 Use enum syntaxcode for syntax code.
2299 (Fmatching_paren): Check that arg is a character, not just an integer.
2300 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2301 (Finternal_describe_syntax_value): Omit no-longer-needed
2302 comparison to 0.
2303 (skip_chars): Use char, not unsigned char, when the distinction
2304 doesn't matter.
2305 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2306 * bytecode.c (exec_byte_code):
2307 * syntax.c (syntax_spec_code, Fchar_syntax)
2308 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2309 (init_syntax_once):
2310 * syntax.h (SYNTAX_WITH_FLAGS):
2311 Omit unnecessary casts.
2312
b932cad7
EZ
23132013-06-20 Eli Zaretskii <eliz@gnu.org>
2314
2315 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2316 line dimensions here, to avoid race conditions with the main
2317 thread. (Bug#14062, bug#14630, bug#14669)
2318
2319 * w32term.c (w32_draw_window_cursor): Compute the header line and
2320 mode line dimensions here.
2321 <w32_system_caret_window, w32_system_caret_hdr_height>:
2322 <w32_system_caret_mode_height>: New variables.
2323
2324 * w32term.h: Declare them.
2325
89561f72
PE
23262013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2327
5013fc08
PE
2328 * alloc.c (die): Move "assertion failed" string here ...
2329 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2330 COND when SUPPRESS_CHECKING. This shrinks the executable text
2331 size by 0.8% to 2.2% when configured with --enable-checking,
2332 depending on optimization flags (GCC 4.8.1 x86-64).
2333
89561f72
PE
2334 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2335
763a086d 23362013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2337
2338 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2339 base is 2; this is more accurate.
2340
983aeb9a
JB
23412013-06-19 Juanma Barranquero <lekktu@gmail.com>
2342
2343 * sound.c (string_default): Move to !WINDOWSNT section.
2344 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2345
178ba3e6
PE
23462013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2347
bbc51b15
PE
2348 * sound.c: Integer cleanups.
2349 Remove unnecessary forward decls.
2350 (struct sound_device): The 'file' member is now a Lisp_Object, not
2351 a char *, so that we needn't invoke alloca on a huge size.
2352 (Fplay_sound_internal): Adjust to this.
2353 (string_default): New function.
2354 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2355 Use it to adjust to the struct sound_device change.
2356 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2357 (be2hs) [0]: Remove.
2358
178ba3e6
PE
2359 * syntax.c (skip_chars): Don't use uninitialized storage
2360 when searching a multibyte buffer for characters that are not in a
2361 unibyte string that contains non-ASCII characters.
2362
69f60cdc
JD
23632013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2364
2365 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2366 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2367
0d6224d4
PE
23682013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2371
3c542890
KH
23722013-06-18 Kenichi Handa <handa@gnu.org>
2373
f7e3f7cd
KH
2374 * font.c (Ffont_spec): Signal an error for an invalid font name
2375 (Bug#14648).
3c542890 2376
9349e5f7
PE
23772013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2378
2379 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2380 In particular this ports to 32-bit sparc Sun cc.
2381 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2382 array with a dummy element at specpdl[-1], so that its address can
2383 be taken portably.
2384 (unbind_to): Do not copy the binding; not needed, now that we
2385 copy old_value in the one place where the copy is needed.
2386 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2387 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2388 (union specbinding): Rename from struct specbinding. Redo layout
2389 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2390 which is not portable. With Sun C 5.12 32-bit sparc, the
2391 declaration causes nargs to be an unsigned bitfield, a behavior
2392 that the C standard allows; but Emacs wants nargs to be signed.
2393 The overall type is now a union of structures rather than a
2394 structure of union of structures, and the 'kind' member is now a
2395 bitfield, so that the overall type doesn't grow. All uses changed.
2396 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2397
0a4df6a5
PE
23982013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2399
ec6ecaad
PE
2400 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2401 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2402
0a4df6a5
PE
2403 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2404
7bfe8dbc
EZ
24052013-06-17 Eli Zaretskii <eliz@gnu.org>
2406
2407 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2408 unless we know that the window w's frame is a frame object.
2409 Another attempt at solving bug#14062 and bug#14630.
2410
708e05f6
LMI
24112013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2412
2413 * textprop.c (property_set_type): New enum.
2414 (add_properties): Allow appending/prepending text properties.
2415 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2416 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2417 add_text_properties_1.
2418 (Fadd_face_text_property): New function that calls
2419 add_text_properties_1.
2420
84575e67
PE
24212013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 Move functions from lisp.h to individual modules when possible.
2424 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2425 * alloc.c (XFLOAT_INIT, set_symbol_name):
2426 * buffer.c (CHECK_OVERLAY):
2427 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2428 (set_char_table_parent):
2429 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2430 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2431 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2432 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2433 (set_blv_valcell):
2434 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2435 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2436 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2437 (backtrace_args, backtrace_debug_on_exit):
2438 * floatfns.c (CHECK_FLOAT):
2439 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2440 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2441 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2442 (set_hash_index_slot):
2443 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2444 * marker.c (CHECK_MARKER):
2445 * textprop.c (CHECK_STRING_OR_BUFFER):
2446 * window.c (CHECK_WINDOW_CONFIGURATION):
2447 Move here from lisp.h, and make these functions static rather than
2448 extern inline.
2449 * buffer.c (Qoverlayp):
2450 * data.c (Qsubrp):
2451 * fns.c (Qhash_table_p):
2452 * window.c (Qwindow_configuration_p):
2453 Now static.
2454 * lisp.h: Remove the abovementioned defns and decls.
2455
44e18199 2456 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2457 In lisp.h, prefer functions to function-like macros, and
2458 constants to object-like macros, when either will do. This:
2459 . simplifies use, as there's no more need to worry about
2460 arguments' side effects being evaluated multiple times.
2461 . makes the code easier to debug on some platforms.
2462 However, when using gcc -O0, keep using function-like macros
2463 for a few critical operations, for performance reasons.
2464 This sort of thing isn't needed with gcc -Og, but -Og
2465 is a GCC 4.8 feature and isn't widely-enough available yet.
2466 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2467 Remove enum lsb_bits; no longer needed.
2468 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2469 * buffer.c (Qoverlap):
2470 * data.c (Qsubrp):
2471 * fns.c (Qhash_table_p):
2472 Now extern, so lisp.h can use these symbols.
2473 * dispextern.h: Include character.h, for MAX_CHAR etc.
2474 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2475 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2476 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2477 (GLYPH_CODE_P): Move here from lisp.h.
2478 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2479 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2480 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2481 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2482 XUNTAG now returns void *.
2483 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2484 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2485 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2486 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2487 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2488 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2489 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2490 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2491 New macros, renamed from their sans-lisp_h_ counterparts.
2492 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2493 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2494 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2495 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2496 If compiling via GCC without optimization, define these as macros
2497 in addition to inline functions.
2498 To disable this, compile with -DINLINING=0.
2499 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2500 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2501 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2502 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2503 (INTMASK, VALMASK): Now macros, since static values cannot be
2504 accessed from extern inline functions.
2505 (VALMASK): Also a constant, for benefit of old GDB.
2506 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2507 is INTEGERP, which can fold it in.
5165d44a 2508 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2509 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2510 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2511 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2512 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2513 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2514 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2515 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2516 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2517 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2518 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2519 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2520 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2521 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2522 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2523 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2524 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2525 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2526 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2527 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2528 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2529 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2530 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2531 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2532 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2533 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2534 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2535 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2536 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2537 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2538 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2539 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2540 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2541 Now functions.
2542 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2543 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2544 (VALMASK): Define in one place rather than in two, merging the
2545 USE_LSB_TAG parts; this is simpler.
2546 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2547 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2548 Move up, to avoid use before definition.
2549 Also include "globals.h" earlier, for the same reason.
2550 (make_natnum): New function.
2551 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2552 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2553 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2554 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2555 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2556 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2557 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2558 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2559 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2560 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2561 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2562 (Qwindow_configuration_p, Qimage): New forward declarations.
2563 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2564 (STRING_COPYIN): Remove; unused.
2565 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2566 (xcar_addr, xcdr_addr): New functions. All uses changed.
2567 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2568 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2569 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2570 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2571 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2572 (TYPE_RANGED_INTEGERP): Simplify.
2573 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2574 (setlocale, fixup_locale, synchronize_system_messages_locale)
2575 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2576 Now empty functions, not macros.
2577 (functionp): Return bool, not int.
2578 * window.c (Qwindow_configuration_p): Now extern,
2579 so window.h can use it.
2580 * window.h (Qwindowp): Move decl back to lisp.h.
2581
9583ec36
EZ
25822013-06-15 Eli Zaretskii <eliz@gnu.org>
2583
2584 * xdisp.c (Fline_pixel_height): New function, required for solving
2585 bug #14567.
2586
210272ce
PE
25872013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2590
de0503df
SM
25912013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2592
2593 * lread.c (syms_of_lread):
2594 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2595
afbfe143
KD
25962013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2597
2598 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2599
d177e213
XF
26002013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2601
2602 * fileio.c (expand_file_name): Doc fix.
2603
05e3e412
PE
26042013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2605
f7394b12
PE
2606 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2607 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2608 Wait for self, not for 0. This can't hurt on GNU or similar
2609 system, and may help with Cygwin.
2610
05e3e412
PE
2611 * keyboard.c: Don't use PROP (...) as an lvalue.
2612 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2613 Use set_prop (A, B), not PROP (A) = B.
2614
17dd3097
EZ
26152013-06-10 Eli Zaretskii <eliz@gnu.org>
2616
2617 * xdisp.c (get_it_property): Use it->window instead of generating
2618 a Lisp object from it->w.
2619
52fab9c9
EZ
26202013-06-09 Eli Zaretskii <eliz@gnu.org>
2621
2622 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2623 get-char-property the window that is being rendered, instead of
2624 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2625 (compute_display_string_pos): When W is NULL, use the current
2626 buffer as the object to pass to get-char-property.
2627 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2628 pointer member of the bidi iterator, since no window is pertinent
2629 to this function.
52fab9c9 2630
5bf97bfc
EZ
26312013-06-08 Eli Zaretskii <eliz@gnu.org>
2632
2633 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2634 being displayed, and pass it to compute_display_string_pos.
2635 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2636 (bidi_paragraph_init): All callers changed.
2637
2638 * xdisp.c (init_from_display_pos, init_iterator)
2639 (handle_single_display_spec, next_overlay_string)
2640 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2641 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2642 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2643 (compute_display_string_pos): Accept additional argument, the
2644 window being displayed, and pass it to Fget_char_property.
2645 (Bug#14575)
2646
2647 * dispextern.h (struct bidi_it): New member w, the window being
2648 displayed.
2649 (compute_display_string_pos): Adjust prototype.
2650
5de0e011
JD
26512013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2652
e7b41c4c 2653 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2654
2655 * process.c (wait_reading_process_output): Check for NS before GLIB.
2656 GLIB may be linked in due to rsvg, but ns_select must be called.
2657
5de0e011
JD
2658 * xgselect.c (xg_select): Remove call to window_system_available
2659 and g_main_context_pending at the top, so Gdk events (i.e. file
2660 notify) are processed when Emacs is started with -nw.
2661
a822acff
EZ
26622013-06-07 Eli Zaretskii <eliz@gnu.org>
2663
2664 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2665 (ctagsfiles3): New variable, includes only *.m files.
2666 (TAGS): Use an explicit language name in the regular expressions,
2667 to avoid transformation of '/SOMETHING' by MSYS to
2668 'c:\MSYS\SOMETHING'.
2669
6c0a9ed1
RC
26702013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2671
2672 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2673
9ef6111b
EZ
26742013-06-06 Eli Zaretskii <eliz@gnu.org>
2675
2676 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2677 still need to set the mouse pointer shape and activate help-echo.
2678 (Bug#14558)
2679
7d300d64
PE
26802013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 A few porting etc. fixes for the new file monitor code.
2683 See the thread containing
2684 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2685 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2686 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2687 (dir_monitor_callback, Fgfile_rm_watch):
2688 Use assq_no_quit instead of Fassoc, for speed.
2689 (dir_monitor_callback, Fgfile_rm_watch):
2690 eassert that the monitor is a fixnum.
2691 (dir_monitor_callback): No need for CDR_SAFE.
2692 Simplify building of lisp with alternative tails.
2693 (Fgfile_add_watch, Fgfile_rm_watch):
2694 Do not assume glib functions set errno reliably on failure.
2695 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2696 and signal an error otherwise.
2697 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2698 Use Fdelq instead of Fdelete, for speed.
2699
817ebfcf
EZ
27002013-06-05 Eli Zaretskii <eliz@gnu.org>
2701
2702 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2703 don't insist on being invoked on a highlighted tool-bar button.
2704 Avoids losing tool-bar functionality when mouse-highlight is nil.
2705 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2706 Don't highlight when mouse-highlight is nil.
2707 (note_mouse_highlight): When mouse-highlight is nil, don't return
2708 right away; instead, run tool-bar and mode-line highlight
2709 subroutine, clear any existing highlight, and revert the mouse
2710 pointer to its default shape. (Bug#14558)
2711
55577e7c
SM
27122013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2713
2714 * lisp.mk (lisp): Add prog-mode.el.
2715
f019a684
PE
27162013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2717
2718 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2719 * process.c (dummy_handler): New function.
2720 (lib_child_handler): New static var.
2721 (handle_child_signal): Invoke it.
2722 (catch_child_signal): If a library has set up a signal handler,
2723 save it into lib_child_handler.
2724 (init_process_emacs): If using glib and not on Windows, tickle glib's
2725 child-handling code so that it initializes its private SIGCHLD handler.
2726 * syssignal.h (SA_SIGINFO): Default to 0.
2727 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2728 31; it should no longer be needed now.
2729
90db8702
MA
27302013-06-05 Michael Albinus <michael.albinus@gmx.de>
2731
2732 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2733
2734 * gfilenotify.c (globals_of_gfilenotify): New function.
2735 (syms_of_gfilenotify): Move global initialization there.
2736
2737 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2738
bfa3acd6
SM
27392013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2740
2741 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2742 * keyboard.c (menu_bar_items, tool_bar_items):
2743 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2744 not override local keymaps any more.
2745
ba59bd80
EZ
27462013-06-04 Eli Zaretskii <eliz@gnu.org>
2747
2748 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2749
7f203aa1
EZ
27502013-06-03 Eli Zaretskii <eliz@gnu.org>
2751
9337e206
EZ
2752 * w32console.c (initialize_w32_display): Return the dimensions of
2753 the console window via 2 additional arguments, not via the current
2754 frame. This avoids crashes due to overrunning the bounds of
2755 frame's decode_mode_spec_buffer, which is not resized following
2756 the change of the frame dimensions from the initial 10x10.
2757
2758 * w32term.h (w32_initialize_display_info): Adjust prototype.
2759
2760 * term.c (init_tty): Take dimensions of the frame from the values
2761 returned by initialize_w32_display.
2762
7f203aa1
EZ
2763 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2764 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2765 (LIBES): Add $(GFILENOTIFY_LIBS).
2766
2767 * w32inevt.c (handle_file_notifications): Add dummy implementation
2768 for !HAVE_W32NOTIFY.
2769
2770 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2771
55a87246
JD
27722013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2773
2774 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2775
2776 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2777
2778 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2779
3d5ee10a
PE
27802013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 Fix minor problems found by static checking.
2783 * data.c (pure_write_error):
2784 Use xsignal2, not Fsignal, as Fsignal might return.
2785 * eval.c (set_backtrace_debug_on_exit): Now static.
2786 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2787 No longer inline. EXTERN_INLINE is needed only for functions
2788 defined in .h files. Reindent function header as per GNU style.
2789 (backtrace_p, backtrace_top, backtrace_next):
2790 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2791 compiler or linker. Add extern decls to pacify gcc -Wall.
2792 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2793 Now static.
2794 * frame.c (free_monitors): Define only on platforms that need it.
2795 * nsterm.m (ns_term_init):
2796 * process.c (catch_child_signal):
2797 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2798 defined on all porting targets these days.
2799 * process.c, process.h (catch_child_signal):
2800 Make it extern only if NS_IMPL_GNUSTEP is defined.
2801
e2d8a6f0
EZ
28022013-06-03 Eli Zaretskii <eliz@gnu.org>
2803
2804 * w32.c (gettimeofday): Make the signature identical to prototype
2805 in nt/inc/sys/time.h.
2806
a8a7c5f6
SM
28072013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2808
2809 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2810 .gdbinit.
2811
2812 * keyboard.c (safe_run_hooks_error): Improve error message.
2813
2814 * data.c (pure_write_error): Add `object' argument.
2815 * puresize.h (CHECK_IMPURE): Use it.
2816
c9628c79
MA
28172013-06-03 Michael Albinus <michael.albinus@gmx.de>
2818
2819 * Makefile.in (NOTIFY_OBJ): New variable.
2820 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2821
2822 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2823 Call syms_of_gfilenotify.
2824
2825 * gfilenotify.c: New file.
2826
2827 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2828 and Qfile_w32notify.
2829 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2830 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2831
2832 * lisp.h: Declare syms_of_gfilenotify.
2833
2834 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2835
2f592f95
SM
28362013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2837
2838 Merge the specpdl and backtrace stacks. Make the structure of the
2839 specpdl entries more obvious via a tagged union of structs.
2840 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2841 (enum specbind_tag): New enum.
2842 (struct specbinding): Make it a tagged union of structs.
2843 Add a case for backtrace records.
2844 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2845 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2846 (backtrace_debug_on_exit): New accessors.
2847 (struct backtrace): Remove.
2848 (struct catchtag): Remove backlist field.
2849 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2850 Move to eval.c.
2851 (Flocal_variable_p): Speed up the common case where the binding is
2852 already loaded.
2853 * eval.c (backtrace_list): Remove.
2854 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2855 (set_backtrace_args, set_backtrace_nargs)
2856 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2857 (backtrace_next): New functions.
2858 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2859 (unwind_to_catch, internal_lisp_condition_case)
2860 (internal_condition_case, internal_condition_case_1)
2861 (internal_condition_case_2, internal_condition_case_n): Don't bother
2862 with backtrace_list any more.
2863 (Fsignal): Adjust to new backtrace format.
2864 (grow_specpdl): Move up.
2865 (record_in_backtrace): New function.
2866 (eval_sub, Ffuncall): Use it.
2867 (apply_lambda): Adjust to new backtrace format.
2868 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2869 data.c.
2870 (specbind): Adjust to new specpdl format. Simplify.
2871 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2872 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2873 backtrace format.
2874 (mark_backtrace): Remove.
2875 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2876 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2877 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2878 Use mark_specpdl.
2879 * profiler.c (record_backtrace): Use get_backtrace.
2880 (handle_profiler_signal): Use backtrace_top_function.
2881 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2882 accessor functions.
2883
c0342369
JD
28842013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2885
2886 * process.h (catch_child_signal): Declare.
2887
2888 * process.c (catch_child_signal): New function.
2889 (init_process_emacs): Call it.
2890
2891 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2892 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2893 NS_IMPL_COCOA.
2894 (x_set_cursor_type): Remove declaration.
2895 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2896 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2897 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2898 (ns_get_color): Use F suffix on float.
2899 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2900 (ns_get_rgb_color): Remove.
2901 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2902 (note_mouse_movement): x and y are CGFloat.
2903 (ns_draw_fringe_bitmap): Remove unused rowY.
2904 Change #if to COCOA && >= 10_6.
2905 (ns_draw_window_cursor): Remove unused overspill.
2906 (ns_draw_underwave): width and x are EamcsCGFloat.
2907 (ns_draw_box): thickness is CGFloat.
2908 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2909 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2910 if not in main thread.
2911 (ns_get_pending_menu_title, ns_check_menu_open)
2912 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2913 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2914 (sendFromMainThread:): New method.
2915 (changeFont:): size is CGFloat.
2916 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2917 Disable warning about permanent text.
2918 (characterIndexForPoint:): Adjust return type depending on GNUStep
2919 version.
2920 (mouseDown:): delta is CGFloat.
2921 (updateFrameSize): Remove unised variable f.
2922 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2923 Cast float to EmacsCGFloat.
2924 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2925 also to -1 when restoring.
2926 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2927 inside NS_IMPL_COCOA.
2928 (toggleFullScreen:): Put call to toggleFullScreen inside
2929 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2930 (setPosition:portion:whole:): por is CGFloat.
2931 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2932 (mouseDown:): Use CGFloat.
2933 (mouseDragged:): Remove unised variable edge.
2934 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2935
2936 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2937 of CGFloat differs.
2938 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2939 when NS_IMPL_GNUSTEP.
2940 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2941 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2942 (EmacsToolbar): Add clearAll. Add tag argument to
2943 addDisplayItemWithImage.
2944 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2945
2946 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2947
2948 * nsmenu.m (ns_update_menubar): Make static.
2949 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2950 (fillWithWidgetValue:): Add cast to SEL for setAction.
2951 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2952 (update_frame_tool_bar): Update code for GNUStep.
2953 (clearAll): New method.
2954 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2955 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2956 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2957 call to insertItemWithItemIdentifier.
2958 (validateVisibleItems): Fix indentation.
2959 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2960 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2961 UtilityWindow to aStyle, remove call to setStyleMask.
2962
2963 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2964
2965 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2966 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2967 Use F suffix on floats.
2968 (ns_char_width): Returns CGFloat.
2969 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2970 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2971 DPSxshow.
2972 (ns_glyph_metrics): CGFloat instead of float.
2973
a0eb10b3
JB
2974 * nsfns.m (x_set_foreground_color, x_set_background_color):
2975 Use EmacsCGFloat.
2976 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2977 remove unused variables.
2978 (Fns_read_file_name): Keep track if panel is for save.
2979 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2980 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2981 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2982 Just return the input if GNUStep.
c0342369
JD
2983 (x_screen_planes): Remove.
2984 (Fxw_color_values): Use EmacsCGFloat
2985 (Fns_display_monitor_attributes_list): Only get screen number for
2986 Cocoa.
ef099a94 2987 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2988 EmacsSavePanel.
2989 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2990 ns_directory_from_panel.
2991
da9aff11
PE
29922013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 * process.c (handle_child_signal): Also use WCONTINUED.
2995 This is so that list-processes doesn't mistakenly list the process
2996 as stopped, when the process has actually been continued and is
2997 now running.
2998
0e64479a
PE
29992013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3000
fc186a96
PE
3001 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3002 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3003 not already configured.
3004
0e64479a
PE
3005 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3006
38b787fa
EZ
30072013-05-29 Eli Zaretskii <eliz@gnu.org>
3008
3009 * Makefile.in (mostlyclean): Remove *.res files.
3010
22513e52
SM
30112013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3012
3013 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3014 a buffer (bug#8447).
3015
6ef3db10
EZ
30162013-05-27 Eli Zaretskii <eliz@gnu.org>
3017
3018 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3019 display vector, and we backtrack, handle the case that the
3020 previous character position is also displayed from a display
3021 vector or covered by a display string or image. (Bug#14476)
3022
6799bb26
JD
30232013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3024
3025 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3026 (struct MonitorInfo, free_monitors): Remove.
3027 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3028 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3029 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3030 Qframes, Qsource.
3031
3032 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3033 (struct MonitorInfo, free_monitors): Remove.
3034 (ns_screen_name): Make static.
3035 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3036 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3037 Qframes, Qsource.
3038
3039 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3040 (struct MonitorInfo): New struct.
3041 (free_monitors, make_monitor_attribute_list): Declare.
3042
22513e52
SM
3043 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3044 New Lisp_Object:s.
6799bb26
JD
3045 (free_monitors, make_monitor_attribute_list): New functions.
3046 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3047 Qsource.
3048
38cd43eb
XF
30492013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3050
3051 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3052
2af0948d
SM
30532013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3054
a7eb9b0f
SM
3055 * keyboard.c: Apply keyboard decoding only to events that come directly
3056 from the tty, not from unread-command-events (bug#14368).
3057 (read_event_from_main_queue): New function, extracted from read_char).
3058 (read_decoded_char): Remove.
3059 (read_decoded_event_from_main_queue): New function to replace it.
3060 (read_char): Use it.
3061 (read_key_sequence): Use read_char rather than read_decoded_char.
3062
2af0948d
SM
3063 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3064
1413e9a5
BR
30652013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3066
3067 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3068
e6d2f155
KH
30692013-05-22 Kenichi Handa <handa@gnu.org>
3070
3071 The following changes are to fix the setting of
3072 buffer-file-coding-system on, for instance, C-x RET c unix RET
3073 _FILE_OF_DOS_EOL_TYPE_ RET.
3074
3075 * coding.h (struct coding_system): New member detected_utf8_chars.
3076
3077 * coding.c (detect_coding_utf_8): Count characters and check EOL
3078 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3079 BOM is there.
3080 (setup_coding_system): Do not initialize coding->head_ascii.
3081 (check_ascii): Do not set coding->eol_seen but update it. Do not
3082 call adjust_coding_eol_type here.
1413e9a5
BR
3083 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3084 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3085 of the found coding-system.
3086 (decode_coding_gap): Cancel previous change. Utilize the
3087 character numbers counted by detect_coding_utf_8. Fix detection
3088 of BOM for utf-8.
3089
ab56a6f4 30902013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3091
3092 * search.c (looking_at_1): Only set last_thing_searched if the match
3093 changed the match-data (bug#14281).
3094
ecc3c6ed
DA
30952013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3096
3097 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3098 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3099 (move_it_vertically_backward): Likewise.
3100
5ba8bf35
YM
31012013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3102
3103 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3104 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3105 (Fx_display_mm_width, Fx_display_mm_height):
3106 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3107
91e8418b 3108 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3109 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3110 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3111 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3112 (Fx_display_backing_store, Fx_display_visual_class)
3113 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3114 (Fx_display_grayscale_p, Fx_display_pixel_width)
3115 (Fx_display_pixel_height, Fx_display_planes)
3116 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3117 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3118 (Fx_display_mm_width, Fx_display_mm_height)
3119 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3120 height for all physical monitors as in X11.
3121
fc30d803
SM
3122 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3123 Return pixel width or height for all physical monitors as in X11.
91e8418b 3124
31ff141c
PE
31252013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 Port --enable-gcc-warnings to clang.
3128 * bytecode.c (exec_byte_code):
3129 * regex.c:
3130 Redo diagnostic pragmas to pacify clang, too.
3131 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3132 * editfns.c (Fencode_time):
3133 * fileio.c (file_accessible_directory_p):
3134 * font.c (font_unparse_xlfd):
3135 Use '&"string"[index]' instead of '"string" + (index)'.
3136 * undo.c (user_error): Remove; unused.
3137
df065a0b
EZ
31382013-05-16 Eli Zaretskii <eliz@gnu.org>
3139
04d360e7
EZ
3140 * insdel.c (insert_1_both): Document the arguments, instead of
3141 referring to insert_1, which no longer exists.
3142
5bb98290
EZ
3143 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3144 some window, increment windows_or_buffers_changed, so that
3145 *Messages* display in that window is updated. (Bug#14408)
3146
df065a0b
EZ
3147 * w32.c: Include epaths.h.
3148 (init_environment): Use cmdproxy.exe without leading directories.
3149 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3150 case.
3151 (gettimeofday): Adjust signature and return value to Posix
3152 expectations.
3153
3154 * unexw32.c (open_output_file): Delete the existing emacs.exe
3155 before creating it, to break the hard link to the versioned
3156 executable.
3157
3158 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3159 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3160 (FIRSTFILE_OBJ): New variables.
3161 (W32_RES): Rename to EMACSRES. All users changed.
3162 (base_obj): Use $(CM_OBJ).
3163 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3164 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3165 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3166 $(W32_RES_LINK) before $(LIBES).
3167 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3168
1aa8d505
SM
31692013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3170
6e911150
SM
3171 * makefile.w32-in (DOC): Use just "DOC".
3172
3173 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3174
1aa8d505
SM
3175 * process.c: Export default filters and sentinels to Elisp.
3176 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3177 New constants.
3178 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3179 (Fset_process_sentinel, Fformat_network_address):
3180 Default to them instead of nil.
3181 (server_accept_connection): Sentinels can't be nil any more.
3182 (read_and_dispose_of_process_output): New function, extracted from
3183 read_process_output.
3184 (read_process_output): Use it; filters can't be nil.
3185 (Finternal_default_process_filter): New function, extracted from
3186 read_process_output.
3187 (exec_sentinel_unwind): Remove function.
3188 (exec_sentinel): Don't zilch sentinel while running.
3189 (status_notify): Sentinels can't be nil.
3190 (Finternal_default_process_sentinel): New function extracted from
3191 status_notify.
3192 (setup_process_coding_systems): Default filter is not nil any more.
3193 (syms_of_process): Export new Elisp functions and initialize
3194 new constants.
3195 * lisp.h (make_lisp_proc): New function.
3196
5ac2eb34
SM
31972013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3198
3199 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3200
eda9c7d7
EZ
32012013-05-14 Eli Zaretskii <eliz@gnu.org>
3202
3203 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3204 unless we know that the window w is a leaf window.
3205 Another attempt at solving bug#14062.
eda9c7d7 3206
8fdeaad5
JD
32072013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3208
3209 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3210 fdesc (Bug#14375).
3211
44aa9ee6
PE
32122013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3213
3214 * image.c (gif_load): Check that subimages fit (Bug#14345).
3215
759fd763
SM
32162013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3217
3218 * lread.c (skip_dyn_eof): New function.
3219 (read1): Use it to skip the end of a file in response to #@00.
3220
3221 * doc.c (get_doc_string): Slightly relax the sanity checking.
3222
4465bfb4
JD
32232013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3224
3225 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3226 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3227 (MonitorInfo): New struct.
3228 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3229 (Fns_display_monitor_attributes_list): New functions.
3230 (display-usable-bounds): Remove.
3231 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3232 Qsource.
3233
7583e2a0
PE
32342013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3235
3236 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3237 (GTK_CHECK_VERSION): New macro, if not already defined.
3238 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3239 replaced by GTK_CHECK_VERSION.
3240
ad75d77e
PE
32412013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 * xterm.h (GTK_PREREQ): New macro.
3244 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3245 to use this macro instead, for consistency and clarity.
3246
07525f77
EZ
32472013-05-08 Eli Zaretskii <eliz@gnu.org>
3248
3249 * xdisp.c (row_for_charpos_p): New function, with code of
3250 cursor_row_p, but accepts an additional argument CHARPOS instead
3251 of using a hardcoded PT.
3252 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3253 (row_containing_pos): Call row_for_charpos_p instead of partially
3254 doing the same. Fixes cursor positioning under longlines-mode
3255 when longlines-show-effect includes more than one newline, when
3256 moving the cursor vertically up.
3257
d901fc8d
JB
32582013-05-08 Juanma Barranquero <lekktu@gmail.com>
3259
3260 * makefile.w32-in (ACL_H): New macro.
3261 ($(BLD)/fileio.$(O)): Update dependencies.
3262
f269bc61
PE
32632013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3264
e7b41c4c 3265 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3266 * Makefile.in (LIB_ACL): New macro.
3267 (LIBACL_LIBS): Remove.
3268 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3269 * fileio.c: Include <acl.h>.
3270 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3271 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3272 !acl_errno_valid.
3273 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3274 it ourselves.
3275
f269bc61
PE
3276 * unexelf.c: Don't assume ElfW (Half) fits in int.
3277 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3278 when dealing with ElfW (Half) values, since they can exceed 2**31
3279 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3280 (entry_address): Omit unused NUM arg. All uses changed.
3281
a261c53e
JL
32822013-05-07 Juri Linkov <juri@jurta.org>
3283
3284 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3285 to the string converted from number with `Fnumber_to_string'.
3286 (Bug#14254)
3287
2b66427d
PE
32882013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3289
3290 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3291 This fixes a problem introduced by my previous change.
3292
15acfe41
GM
32932013-05-07 Glenn Morris <rgm@gnu.org>
3294
3295 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3296
5ea03bf5
JD
32972013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3298
3299 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3300
e0c9d565
PE
33012013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3302
3303 Static checking by GCC 4.8.0.
3304 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3305 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3306 (x_get_monitor_attributes_fallback)
3307 (x_get_monitor_attributes_xinerama)
3308 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3309 Define only if USE_GTK.
3310 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3311 (x_get_monitor_attributes_fallback): Omit unused locals.
3312 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3313 Use double, not float, to avoid mixed-mode floating point arithmetic.
3314
4e3f9230
YM
33152013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3316 Jan Djärv <jan.h.d@swipnet.se>
3317
3318 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3319 (XINERAMA_CFLAGS): New macros.
3320 (ALL_CFLAGS, LIBES): Use them.
3321
3322 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3323 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3324 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3325 (syms_of_xfns): DEFSYM them.
3326 (struct MonitorInfo): New struct.
3327 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3328 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3329 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3330 (x_get_monitor_attributes_xinerama): New functions.
3331 (Fx_display_monitor_attributes_list): New primitive.
3332 (syms_of_xfns): Defsubr it.
3333
3334 * xterm.h (x_display_info): Add Xatom_net_workarea and
3335 Xatom_net_current_desktop.
3336
3337 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3338 and dpyinfo->Xatom_net_current_desktop.
3339
05839b6a
EZ
33402013-05-06 Eli Zaretskii <eliz@gnu.org>
3341
3342 * xdisp.c (pos_visible_p): Use the special code for finding the
3343 beginning of a display property or overlay for any "replacing"
3344 display property, not just for display strings. This solves
3345 incorrect reporting of position by posn-at-point. (Bug#14241)
3346
dc4a2ee0
PE
33472013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3348
5ee94506
PE
3349 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3350 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3351 Verify that ElfW (Half) fits in int.
3352 (fatal): Use same signature as lisp.h.
3353 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3354 configure and build with -DUNEXELF_DEBUG without worrying about
3355 other modules that use DEBUG.
3356 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3357 possibly-wide integers now uses it instead of plain fprintf.
3358 (entry_address): New function, which avoids problems with 32-bit
3359 overflow on 64-bit hosts.
3360 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3361 (round_up): Don't assume the remainder fits in int.
3362 (find_section): Use bool for boolean. Simplify debug code.
3363 (unexec): Don't assume file sizes fit in int or size_t.
3364 Omit unnecessary trailing newline in 'fatal' format.
3365 Use strerror rather than outputting decimal error number.
3366 Remove unused code when emacs is not defined;
3367 this file relies on Emacs now.
3368 Don't assume e_phnum and e_shnum are positive.
3369
dc4a2ee0
PE
3370 * regex.c: Fix problems when DEBUG is defined.
3371 (extract_number, extract_number_and_incr): Define regardless of
3372 whether DEBUG is defined; that's simpler and makes the code less
3373 likely to go stale in the normal case when DEBUG is not defined.
3374 Return int rather than taking an int * arg. All callers changed.
3375 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3376 Remove, replacing with ...
3377 (DEBUG_PRINT): New macro. All callers changed.
3378 (DEBUG_COMPILES_ARGUMENTS): New macro.
3379 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3380 (print_compiled_pattern, print_double_string) [DEBUG]:
3381 Use prototype rather than old-style definition.
3382 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3383 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3384 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3385 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3386 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3387 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3388 This matters only when DEBUG is defined.
3389
14c7ed05
EZ
33902013-05-05 Eli Zaretskii <eliz@gnu.org>
3391
3392 * xdisp.c (set_iterator_to_next): Set the
3393 ignore_overlay_strings_at_pos_p flag only if we are _really_
3394 iterating over an overlay string, as indicated by the
3395 current.overlay_string_index member. (Bug#14306)
3396
e6076b1b
JD
33972013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3398
3399 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3400 to where it is used, to avoid autorelease issues (Bug#14050).
3401
cbee2131
PE
34022013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3405 * fileio.c (syms_of_fileio): Implement this.
3406 * filelock.c (create_lock_file): If symbolic links don't work, so
3407 we use a regular file as a lock file, do not fsync the lock file;
3408 it's not needed.
3409
30c7e542
SM
34102013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3411
3412 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3413 (syms_of_minibuf): Adjust accodingly.
3414 * lread.c (Fread):
3415 * callint.c (Fcall_interactively): Adjust calls accordingly.
3416
5bebd186
EZ
34172013-05-04 Eli Zaretskii <eliz@gnu.org>
3418
3419 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3420 w->contents is a buffer before computing everything else.
3421 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3422
3423 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3424 assertion violations. (Bug#14062)
3425
0fb0a4f3
DR
34262013-05-01 David Reitter <david.reitter@gmail.com>
3427
3428 * nsfns.m (ns_tooltip): Initialize.
3429
9e63b4a5
EZ
34302013-04-28 Eli Zaretskii <eliz@gnu.org>
3431
3432 * coding.c (decode_coding_gap): Don't remove the character before
3433 a newline unless it's a CR character. (Bug#14287)
3434
ad60824e
DN
34352013-04-28 Dan Nicolaescu <dann@gnu.org>
3436
3437 * dispextern.h (struct face): Move enum face_underline_type
3438 earlier so that bitfields can be in the same word.
3439
edbdcec0
JD
34402013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3441
3442 * nsfns.m (handlePanelKeys): New function.
3443 (EmacsOpenPanel:performKeyEquivalent:)
3444 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3445 arrows/function/control and copy/paste keys (Bug#14296).
3446
0208ede7
JL
34472013-04-27 Juri Linkov <juri@jurta.org>
3448
3449 * callint.c (Fcall_interactively): Call `Qread_number' for
3450 interactive code letter `n' instead of using duplicate code.
3451 (Bug#14254)
3452
b8dd59f7
PE
34532013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 * systime.h (make_timeval): Declare as 'const'.
3456
8bd722db
KH
34572013-04-27 Kenichi Handa <handa@gnu.org>
3458
3459 * font.c (font_open_entity): Always open a font of manageable
3460 size.
3461
13d0e56f 34622013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3463
f780d632
PE
3464 Port better to AIX (Bug#14258).
3465 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3466 to pacify AIX xlc.
3467
ec509856
KH
34682013-04-24 Kenichi Handa <handa@gnu.org>
3469
3470 * coding.c (decode_coding_iso_2022): When an invalid escape
3471 sequence is encountered, reset the invocation and designation
3472 status to the safest one.
3473
84fc48e5
PE
34742013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3475
3476 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3477 Without this fix, "make distclean" leaves stamp-h1 behind.
3478
806bda47
EC
34792013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3480
3481 * w32fns.c (w32_fullscreen_rect): New function to compute the
3482 window rectangle for the given fullscreen mode.
3483 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3484 longer tunes the window size. This keeps the window's edges flush
3485 with the screen and allows the taskbar to hide itself in fullboth.
3486
3487 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3488 window decorations and uses the entire screen.
3489
3490 * w32term.h (w32_fullscreen_rect) Add prototype.
3491 (struct w32_output): Replace normal_width, normal_height,
3492 normal_top, and normal_left members with a single normal_placement
3493 struct.
3494 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3495 Remove macros.
3496 (FRAME_NORMAL_PLACEMENT): New macro.
3497
9cc2810b
JB
34982013-04-16 Juanma Barranquero <lekktu@gmail.com>
3499
3500 * minibuf.c (Ftest_completion): Silence compiler warning.
3501
fd16b54c
EZ
35022013-04-15 Eli Zaretskii <eliz@gnu.org>
3503
3504 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3505 bug#14062.
fd16b54c
EZ
3506
3507 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3508 parentheses.
3509
3510 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3511 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3512 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3513 parentheses where appropriate.
3514
9e3379a0
PE
35152013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3518
ddd6b685
EZ
35192013-04-14 Eli Zaretskii <eliz@gnu.org>
3520
3521 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3522 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3523 Mention in the doc string that setting these variables takes
3524 effect only after a call to set-window-buffer. (Bug#14200)
3525
29b79ba1
EZ
35262013-04-13 Eli Zaretskii <eliz@gnu.org>
3527
3528 * indent.c (Fvertical_motion): Don't consider display strings on
3529 overlay strings as display strings on the buffer position we
3530 started from. This prevents vertical cursor motion from jumping
3531 more than one line when there's an overlay string with a display
3532 property at end of line.
3533 Reported by Karl Chen <Karl.Chen@quarl.org> in
3534 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3535
562c6ee9
SM
35362013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3537
3538 * window.c (select_window): `record_buffer' even if window is
3539 already selected (bug#14191).
3540
fcc1fe85
EZ
35412013-04-11 Eli Zaretskii <eliz@gnu.org>
3542
3543 * window.c (Fwindow_end): Test more flags, including the buffer's
3544 last_overlay_modified flag, to determine whether the window's
3545 display is really up-to-date. Prevents the function from
3546 returning a stale value. (Bug#14170)
3547 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3548 current matrix.
3549
f009190a
EZ
35502013-04-10 Eli Zaretskii <eliz@gnu.org>
3551
3552 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3553 garbaged only if it is not already the top frame on its TTY.
3554 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3555 there are GUI frames open in the same session. (Bug#13864)
3556
78ce603d
SM
35572013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3558
3559 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3560 of marking the idle timers directly.
3561
a8036e40
SM
35622013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3563
3564 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3565 tables (bug#14054).
3566
7ffe7ef6
SM
35672013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3568
3569 * window.c (select_window): Don't record_buffer while the invariant is
3570 temporarily broken (bug#14161).
3571
3572 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3573
7d9f6883
EZ
35742013-04-07 Eli Zaretskii <eliz@gnu.org>
3575
3576 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3577
5406cfd9
RF
35782013-04-07 Romain Francoise <romain@orebokech.com>
3579
3580 Ignore additional platform-specific ACL errors (Bug#13702).
3581 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3582 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3583
95c0e83b
JD
35842013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3585
3586 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3587 f->output_data.ns.
3588
876da980
PE
35892013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3592 This bug was introduced by my 2013-02-25 change that simplified
3593 data_start configuration. Without this change, on GNU/Linux
3594 an Emacs configured with --enable-profiling fails immediately
3595 due to a profiler signal.
3596 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3597 with these flags. On platforms where special flags are needed
3598 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3599 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3600 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3601
7452b7bd
DA
36022013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3603
3604 Get rid of some platform-specific functions examining window
3605 system and its capabilities. This is a partial rework of the
3606 2013-04-05 change.
3607 * lisp.h (have_menus_p): Remove prototype. This function is
3608 replaced with platform-independent window_system_available.
3609 (check_window_system): Move to...
3610 * frame.h (decode_window_system_frame, window_system_available):
3611 ...here, add new prototypes.
3612 * frame.c (window_system_available, decode_window_system_frame):
3613 New functions.
3614 (check_window_system): Platform-independent now.
3615 * xterm.h (x_in_use): Remove declaration.
3616 (check_x_frame):
3617 * w32term.h (check_x_frame):
3618 * nsterm.h (check_x_frame): Remove prototypes. This function
3619 is replaced with platform-independent decode_window_system_frame.
3620 * msdos.c (have_menus_p): Remove.
3621 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3622 Remove platform-specific functions. Use check_window_system,
3623 decode_window_system_frame and check_ns_display_info where
3624 appropriate. Minor style and comment tweaks.
3625 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3626 (check_x_frame): Likewise.
3627 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3628 Likewise.
3629 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3630 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3631 * xmenu.c, xselect.c: All related users changed.
3632
251e9147
KH
36332013-04-03 Kenichi Handa <handa@gnu.org>
3634
3635 The following changes is to optimize the code for reading UTF-8
3636 files.
3637
562c6ee9 3638 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3639 changed. Check EOL format. Do not call adjust_coding_eol_type
3640 here.
3641 (check_utf_8): New function.
3642 (adjust_coding_eol_type): Do nothing if already adjusted.
3643 (detect_coding): Compare the return value of check_ascii with
3644 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3645 (decode_coding_gap): Optimize for valid UTF-8.
3646
8bc369d4
KH
36472013-03-21 Kenichi Handa <handa@gnu.org>
3648
3649 * coding.c (syms_of_coding): Cancel previous change.
3650
3651 * insdel.c (insert_from_gap): Fix previous change.
3652
73931ad1
DA
36532013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3654
3655 Consistently use platform-specific function to detect window system.
3656 * lisp.h (check_window_system): New prototype. This function is
3657 going to replace check_x, check_w32 and check_ns.
3658 (have_menus_p): Mention msdos.c in comment.
3659 * fontset.c (check_window_system_func): Remove. Adjust all users.
3660 * fontset.h (check_window_system_func): Remove prototype.
3661 * nsterm.h (check_ns):
3662 * xterm.h (check_x):
3663 * w32term.h (check_w32): Likewise.
3664 * menu.c (Fx_popup_menu): Use check_window_system.
3665 * msdos.c (check_window_system): Define for MS-DOS.
3666 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3667 * w32fns.c (check_window_system): Likewise for MS-Windows.
3668 * xfns.c (check_window_system): Likewise for X.
3669 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3670 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3671
7216e43b
PE
36722013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3673
3674 Prefer < to > in range checks such as 0 <= i && i < N.
3675 This makes it easier to visualize quantities on a number line.
3676 This patch doesn't apply to all such range checks,
3677 only to the range checks affected by the 2013-03-24 change.
3678 This patch reverts most of the 2013-03-24 change.
3679 * alloc.c (xpalloc, Fgarbage_collect):
3680 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3681 * character.c (string_escape_byte8):
3682 * charset.c (read_hex):
3683 * data.c (cons_to_unsigned):
3684 * dispnew.c (update_frame_1):
3685 * doc.c (Fsubstitute_command_keys):
3686 * doprnt.c (doprnt):
3687 * editfns.c (hi_time, decode_time_components):
3688 * fileio.c (file_offset):
3689 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3690 * font.c (font_intern_prop):
3691 * frame.c (x_set_alpha):
3692 * gtkutil.c (get_utf8_string):
3693 * indent.c (check_display_width):
3694 * keymap.c (Fkey_description):
3695 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3696 * lread.c (read1):
3697 * minibuf.c (read_minibuf_noninteractive):
3698 * process.c (wait_reading_process_output):
3699 * search.c (Freplace_match):
3700 * window.c (get_phys_cursor_glyph):
3701 * xdisp.c (redisplay_internal):
3702 * xsmfns.c (smc_save_yourself_CB):
3703 Prefer < to > for range checks.
3704 * dispnew.c (sit_for): Don't mishandle NaNs.
3705 This fixes a bug introduced in the 2013-03-24 change.
3706 * editfns.c (decode_time_components): Don't hoist comparison.
3707 This fixes another bug introduced in the 2013-03-24 change.
3708
92759988
DA
37092013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3710
3711 * frame.h (struct frame): Drop scroll_bottom_vpos
3712 member becaue all real users are dead long ago.
3713 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3714 * xdisp.c (redisplay_internal): Adjust user.
3715
9a1971bb
GM
37162013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3717
f38ab167
JD
3718 * nsmenu.m (showAtX:Y:for:): setLevel to
3719 NSPopUpMenuWindowLevel (Bug#13998).
3720
6d01f1fe
JD
37212013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3722
3723 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3724 (ns_check_pending_open_menu): Declare.
3725
3726 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3727 (x_activate_menubar): Update the menu with title that matches
3728 ns_get_pending_menu_title, and call
3729 ns_check_pending_openmenu (Bug#12698).
3730 (menuWillOpen:): New method.
3731 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3732
3733 * nsterm.m (menu_will_open_state, menu_mouse_point)
3734 (menu_pending_title): New varaibles.
3735 (ns_get_pending_menu_title, ns_check_menu_open)
3736 (ns_check_pending_open_menu): New functions.
3737
781f4782
DA
37382013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3739
3740 * indent.c (current_column_bol_cache): Remove leftover which is not
3741 used in Fmove_to_column any more.
3742 (current_column, scan_for_column): Adjust users.
3743 * keyboard.c (last_point_position_buffer, last_point_position_window):
3744 Remove leftovers which are not used for recording undo any more.
3745 (command_loop_1, syms_of_keyboard): Adjust users.
3746 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3747 redisplay_window any more.
3748 (move_it_to): Adjust user.
3749
1921c31b
JB
37502013-03-29 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3753 Update dependencies.
3754
717b8bcd
SM
37552013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3756
3757 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3758 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3759 forward references.
3760
e74aeda8
DA
37612013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3762
3763 * window.h (struct window): Replace hchild, vchild and buffer slots
3764 with the only contents slot. This is possible because each valid
3765 window may have either the child window (in vertical or horizontal
3766 combination) or buffer to display (for the leaf window). Using that,
3767 a lof of operations to traverse and/or change window hierarchies may
3768 be simplified. New member horizontal is used to distinguish between
3769 horizontal and vertical combinations of internal windows.
3770 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3771 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3772 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3773 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3774 Use contents slot, not buffer, where appropriate.
3775 (wset_combination): New function.
3776 (wset_buffer): Add eassert.
3777 (Fframe_first_window): Simplify the loop reaching first window.
3778 (Fwindow_buffer): Use WINDOW_LEAF_P.
3779 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3780 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3781 (unshow_buffer): Convert initial debugging check to eassert.
3782 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3783 (make_parent_window, window_resize_check, window_resize_apply)
3784 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3785 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3786 Adjust to match struct window changes.
3787 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3788 (mark_window_cursors_off, count_windows, get_leaf_windows)
3789 (foreach_window_1): Simplify the loop.
3790 * alloc.c (mark_object): Do not check for the leaf window because
3791 internal windows has no glyph matrices anyway.
3792 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3793 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3794 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3795 (build_frame_matrix_from_window_tree, mirror_make_current)
3796 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3797 (update_window_tree, set_window_update_flags): Simplify the loop.
3798 (sync_window_with_frame_matrix_rows): Enforce live window.
3799 Use contents slot, not buffer, where appropriate.
3800 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3801 and WINDOW_HORIZONTAL_COMBINATION_P.
3802 (make_frame_visible_1): Simplify the loop.
3803 Use contents slot, not buffer, where appropriate.
3804 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3805 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3806 (expose_window_tree): Likewise.
3807 Use contents slot, not buffer, where appropriate.
3808 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3809 to avoid deleted windows. Use contents slot instead of buffer.
3810 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3811 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3812 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3813 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3814
121ab1cd
EZ
38152013-03-28 Eli Zaretskii <eliz@gnu.org>
3816
ef454cf7
EZ
3817 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3818 identify the reasons for assertion violations in bug#14062 and
3819 similar ones.
21e930f8
EZ
3820 (Fx_show_tip): Fix compilation error under
3821 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3822
121ab1cd
EZ
3823 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3824 Reported by <rzl24ozi@gmail.com>.
3825
5c89ca24
DA
38262013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3827
3828 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3829 start marker...
562c6ee9
SM
3830 (unwind_with_echo_area_buffer): ...to restore it here.
3831 This is needed to ensure that...
5c89ca24
DA
3832 (redisplay_window): ...both window markers are valid here,
3833 which is verified by eassert.
3834 * editfns.c (save_excursion_save): Do not assume that
3835 selected_window always displays the buffer.
c7f53895
DA
3836 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3837 Fix comment.
5c89ca24 3838
f557c1b1
SM
38392013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3840
3841 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3842 the upcase table.
3843
40693bba 38442013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3845
3846 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3847
c86f791f
EZ
38482013-03-27 Eli Zaretskii <eliz@gnu.org>
3849
3850 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3851 since MinGW's w32api headers do. This avoids compiler warnings.
3852
3853 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3854 if already defined.
3855
c6e72e17
EZ
38562013-03-26 Eli Zaretskii <eliz@gnu.org>
3857
3858 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3859
54e95010
JD
38602013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3861
3862 * gtkutil.c (style_changed_cb): Check if frame is live and an
3863 X frame (Bug#14038).
3864
b88b62de
EZ
38652013-03-26 Eli Zaretskii <eliz@gnu.org>
3866
a18d7de6
EZ
3867 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3868 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3869 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3870 MinGW64.
8f5e14c8
EZ
3871 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3872 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3873
b88b62de
EZ
3874 Fix incompatibilities between MinGW.org and MinGW64 headers.
3875 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3876
3877 * w32.c (REPARSE_DATA_BUFFER): Guard with
3878 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3879
c074e458
JD
38802013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3881
3882 * xterm.c: Include X11/XKBlib.h
3883 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3884
908589fd
AS
38852013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3886
3887 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3888 written backwards.
3889 * blockinput.h (input_blocked_p): Likewise.
3890 * bytecode.c (exec_byte_code): Likewise.
3891 * callproc.c (call_process_kill, call_process_cleanup)
3892 (Fcall_process): Likewise.
3893 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3894 (Fccl_execute_on_string): Likewise.
3895 * character.c (string_escape_byte8): Likewise.
3896 * charset.c (read_hex): Likewise.
3897 * cm.c (calccost): Likewise.
3898 * data.c (cons_to_unsigned): Likewise.
3899 * dired.c (directory_files_internal, file_name_completion):
3900 Likewise.
3901 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3902 (sit_for): Likewise.
3903 * doc.c (Fsubstitute_command_keys): Likewise.
3904 * doprnt.c (doprnt): Likewise.
3905 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3906 * emacsgtkfixed.c: Likewise.
3907 * fileio.c (file_offset, Fwrite_region): Likewise.
3908 * floatfns.c (Fexpt, fmod_float): Likewise.
3909 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3910 Likewise.
3911 * font.c (font_intern_prop): Likewise.
3912 * frame.c (x_set_alpha): Likewise.
3913 * gtkutil.c (get_utf8_string): Likewise.
3914 * indent.c (check_display_width): Likewise.
3915 * intervals.c (create_root_interval, rotate_right, rotate_left)
3916 (split_interval_right, split_interval_left)
3917 (adjust_intervals_for_insertion, delete_node)
3918 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3919 (merge_interval_right, merge_interval_left, copy_intervals)
3920 (set_intervals_multibyte_1): Likewise.
3921 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3922 * keymap.c (Fkey_description): Likewise.
3923 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3924 * lread.c (openp, read_integer, read1, string_to_number):
3925 Likewise.
3926 * menu.c (ensure_menu_items): Likewise.
3927 * minibuf.c (read_minibuf_noninteractive): Likewise.
3928 * print.c (printchar, strout): Likewise.
3929 * process.c (create_process, Faccept_process_output)
3930 (wait_reading_process_output, read_process_output, send_process)
3931 (wait_reading_process_output): Likewise.
3932 * profiler.c (make_log, handle_profiler_signal): Likewise.
3933 * regex.c (re_exec): Likewise.
3934 * regex.h: Likewise.
3935 * search.c (looking_at_1, Freplace_match): Likewise.
3936 * sysdep.c (get_child_status, procfs_ttyname)
3937 (procfs_get_total_memory): Likewise.
3938 * systime.h (EMACS_TIME_VALID_P): Likewise.
3939 * term.c (dissociate_if_controlling_tty): Likewise.
3940 * window.c (get_phys_cursor_glyph): Likewise.
3941 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3942 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3943 Likewise.
3944 * xfns.c (Fx_window_property): Likewise.
3945 * xmenu.c (set_frame_menubar): Likewise.
3946 * xselect.c (x_get_window_property, x_handle_dnd_message):
3947 Likewise.
3948 * xsmfns.c (smc_save_yourself_CB): Likewise.
3949 * xterm.c (x_scroll_bar_set_handle): Likewise.
3950
2bf7d27a
DA
39512013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3952
3953 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3954 to be optional or nil. Adjust comment and convert it to docstring.
3955 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3956 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3957
a9ebfa0b
PE
39582013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3959
3960 Static checking by GCC 4.8-20130319.
3961 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3962 * process.c (Fset_process_datagram_address)
3963 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3964 * xdisp.c (get_char_face_and_encoding):
3965 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3966 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3967 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3968
4f3576ee
KB
39692013-03-24 Ken Brown <kbrown@cornell.edu>
3970
789b5e9a
KB
3971 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3972 fix compilation on 64-bit Cygwin, where underscores are not
3973 automatically prepended.
3974
4f3576ee
KB
3975 * w32term.c (w32_initialize): Silence compiler warning.
3976
b5b7745f
EZ
39772013-03-23 Eli Zaretskii <eliz@gnu.org>
3978
cdc0d0bd
EZ
3979 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3980 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3981 variables, to save and restore frame dimensions.
3982 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3983 after returning from a 'fullscreen' configuration.
3984 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3985 to avoid races between the main thread and the input thread.
3986
3987 * w32term.h (struct w32_output): New members normal_width,
3988 normal_height, normal_top, normal_left, and prev_fsmode.
3989 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3990 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3991 members of a frame.
3992
b5b7745f
EZ
3993 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3994 'fullscreen' parameter. Always record previous width and height
3995 of the frame, except when switching out of maximized modes, so
3996 that they could be restored correctly, instead of resetting to the
3997 default frame dimensions. Send SC_RESTORE command to the frame,
3998 unless we are going to send SC_MAXIMIZE, to restore the frame
3999 resize hints in the mouse pointer shown by the window manager.
4000 (Bug#14032)
4001
4002 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4003
4004 * lisp.h (get_frame_param): Adjust conditions for prototype
4005 declaration.
4006
a3454eed
KB
40072013-03-22 Ken Brown <kbrown@cornell.edu>
4008
4009 * unexcw.c: Drop unneeded inclusion of w32common.h.
4010 (report_sheap_usage): Declare.
4011 (read_exe_header): Add magic numbers for x86_64.
4012 (fixup_executable): Fix printf format specifier for unsigned long
4013 argument.
4014
5a49b79c
DA
40152013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4016
4017 * frame.h (struct frame): Put menu_bar_window under #ifdef
4018 because this member is not needed when X toolkit is in use.
4019 (fset_menu_bar_window):
4020 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4021 (free_glyphs, update_frame):
4022 * xdisp.c (expose_frame): Likewise.
4023 (display_menu_bar): Likewise. Remove redundant eassert.
4024 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4025 toolkit is in use.
4026
d6723bf7
PE
40272013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4028
7b1123d8
PE
4029 Use functions and constants to manipulate Lisp_Save_Value objects.
4030 This replaces code that used macros and strings and token-pasting.
4031 The change makes the C source a bit easier to follow,
4032 and shrinks the Emacs executable a bit.
4033 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4034 (make_save_value): Change 1st arg from string to enum. All callers
4035 changed.
4036 (INTX): Remove.
4037 (mark_object): Use if, not #if, for GC_MARK_STACK.
4038 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4039 (XSAVE_OBJECT): Now functions, not macros.
4040 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4041 the constant was never used.
4042 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4043 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4044 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4045 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4046 New constants.
4047 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4048 type3 with a single member save_type. All uses changed.
4049 (save_type, set_save_pointer, set_save_integer): New functions.
4050 * print.c (PRINTX): Remove.
4051
d6723bf7
PE
4052 * alloc.c: Remove redundant static declarations.
4053
5f24fa51
DA
40542013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4055
4056 * window.h (struct window): Convert left_col, top_line, total_lines
4057 and total_cols from Lisp_Objects to integers. Adjust comments.
4058 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4059 Remove.
4060 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4061 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4062 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4063 Adjust users where appropriate.
4064
42143acd
DA
40652013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4066
4067 * frame.h (struct frame): Drop resx and resy because the same data is
4068 available from window system-specific output context. Adjust users.
562c6ee9
SM
4069 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4070 New functions to provide defaults when no window system available.
42143acd 4071 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4072 (NUMVAL): Move from xdisp.c.
42143acd
DA
4073 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4074 (Ffont_face_attributes, Fopen_font):
4075 * image.c (gs_load):
4076 * w32font.c (fill_in_logfont):
4077 * xdisp.c (calc_pixel_width_or_height):
4078 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4079 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4080
c0a17406
KH
40812013-03-20 Kenichi Handa <handa@gnu.org>
4082
4083 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4084 to 1 (temporary workaround until a bug related to ASCII
4085 optimization is fixed).
4086
095d384d
DA
40872013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4088
4089 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4090 Signal error if window is not internal. Adjust docstring.
4091 (delete_all_child_windows): Use combination_limit to save the buffer.
4092 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4093 * print.c (syms_of_print): Initialize debugging output not here...
4094 (init_print_once): ...but in a new function here.
4095 * lisp.h (init_print_once): Add prototype.
4096 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4097
748fa866
DA
40982013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4099
4100 * window.c (window_resize_check, window_resize_apply)
4101 (window_from_coordinates, recombine_windows, set_window_buffer)
4102 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4103 (Fsplit_window_internal, Fdelete_window_internal)
4104 (freeze_window_starts): Use bool for booleans.
4105 * window.h (window_frame_coordinates, resize_frame_windows)
4106 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4107
81519fd2
SM
41082013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4109
4110 * dispnew.c (bitch_at_user): Use `user-error'.
4111
6db423a9
KB
41122013-03-17 Ken Brown <kbrown@cornell.edu>
4113
4114 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4115 as return type of image_background. (Bug#13981)
4116 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4117
8f2906f5
JD
41182013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4119
960ce480 4120 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4121 (ns_select): Don't return with result uninitialized.
960ce480 4122
8f2906f5
JD
4123 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4124 and getDirectory.
4125
81519fd2
SM
4126 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4127 New functions.
8f2906f5
JD
4128 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4129 directories. If filename is nil, get directory name (Bug#13932).
4130 Use getFilename and getDirectory.
4131 (getFilename, getDirectory): New methods for EmacsSavePanel and
4132 EmacsOpenPanel.
4133 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4134
cded56c1
PE
41352013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4136
4137 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4138
251e9147 41392013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4140
4141 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4142 (adjust_after_replace): Make it back to static. Delete the third
4143 arg text_at_gap_tail. Cancel the code for handling it.
4144
4145 * coding.h (struct coding_system): New member eol_seen.
4146
4147 * coding.c (detect_ascii): New function.
4148 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4149 when the source bytes are actually scanned. On detecting for
4150 coding_category_utf_8_auto, call detect_ascii instead of scanning
4151 source bytes directly.
4152 (produce_chars): Call insert_from_gap with the new arg 0.
4153 (encode_coding): Likewise.
4154 (decode_coding_gap): Control ASCII optimization by the variable
4155 disable_ascii_optimization instead of #ifndef .. #endif.
4156 Deccode EOL format according to coding->eol_seen.
4157 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4158 variable.
4159
8a44e6d1
KH
4160 * lisp.h (adjust_after_replace): Cancel externing it.
4161 (insert_from_gap): Adjust prototype.
4162
5f795e34
EZ
41632013-03-15 Eli Zaretskii <eliz@gnu.org>
4164
4165 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4166 FULLSCREEN_MAXIMIZED. (Bug#13935)
4167
f258b4be
DA
41682013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4169
4170 * region-cache.c (find_cache_boundary, move_cache_gap)
4171 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4172 Simplify debugging check and convert to eassert. Adjust comment.
4173 (pp_cache): Put under ENABLE_CHECKING.
4174
a5cc4dde
EZ
41752013-03-14 Eli Zaretskii <eliz@gnu.org>
4176
4177 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4178 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4179 and WM_ACTIVATEAPP.
4180 (w32fullscreen_hook): If the frame is visible, reset
4181 f->want_fullscreen flag after changing the frame size. If the
4182 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4183 (Bug#13953)
4184
3fc5e44a
DC
41852013-03-13 Daniel Colascione <dancol@dancol.org>
4186
4187 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4188 too so that these builds can use Cygwin's file conversion
4189 functions. (We've been building and linking cygw32.o all along
4190 and just not using it.)
4191
47d7532e
PE
41922013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4193
4194 File synchronization fixes (Bug#13944).
4195 * Makefile.in (LIB_FDATASYNC): New macro.
4196 (LIBES): Use it.
4197 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4198 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4199 Don't worry about HAVE_FSYNC, since a substitute fsync is
4200 available if the system lacks one.
4201 (Fwrite_regin): Retry fsync if interrupted.
4202
c7ffccaf
EZ
42032013-03-13 Eli Zaretskii <eliz@gnu.org>
4204
4e2df81d 4205 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4206 activated, call w32fullscreen_hook, to make sure the new frame
4207 dimensions are in effect. (Bug#13937)
4208
8a7debc1
DA
42092013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4210
4211 * xdisp.c (init_iterator): Simplify because both character and byte
4212 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4213 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4214 character and byte positions can be obtained from marker.
8a7debc1 4215
7fd8c501
PE
42162013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4217
d9df6f40
PE
4218 Static checking by Sun C 5.12.
4219 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4220 * bytecode.c (exec_byte_code):
4221 * dispnew.c (init_display):
4222 * eval.c (error):
4223 * fileio.c (Fsubstitute_in_file_name):
4224 * keyboard.c (Fevent_convert_list):
4225 * keymap.c (Fsingle_key_description):
4226 * term.c (maybe_fatal, fatal):
4227 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4228 * xsmfns.c (Fhandle_save_session):
4229 Omit unreachable code.
4230 * keymap.c (map_keymap_char_table_item): Cast void * to
4231 a function pointer type; the C Standard requires this.
4232
7fd8c501
PE
4233 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4234 Include <sys/param.h> unconditionally, as that works elsewhere and
4235 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4236 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4237 and FreeBSD now.
4238
a020afb9 4239See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4240
4241;; Local Variables:
4242;; coding: utf-8
aac0c6e3
MR
4243;; End:
4244
ab422c4d 4245 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4246
4247 This file is part of GNU Emacs.
4248
4249 GNU Emacs is free software: you can redistribute it and/or modify
4250 it under the terms of the GNU General Public License as published by
4251 the Free Software Foundation, either version 3 of the License, or
4252 (at your option) any later version.
4253
4254 GNU Emacs is distributed in the hope that it will be useful,
4255 but WITHOUT ANY WARRANTY; without even the implied warranty of
4256 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4257 GNU General Public License for more details.
4258
4259 You should have received a copy of the GNU General Public License
4260 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.