System-dependent integer overflow fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9c05bccf
PE
12013-08-24 Paul Eggert <eggert@cs.ucla.edu>
2
3 System-dependent integer overflow fixes.
4 * process.c (Fset_process_window_size): Signal an error if
5 the window size is outside the range supported by the lower level.
6 * sysdep.c (set_window_size): Return negative on error,
7 nonnegative on success, rather than -1, 0, 1 on not in system,
8 failure, success. This is simpler. Caller changed.
9 (serial_configure): Remove unnecessary initialization of local.
10 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
11 size fits in unsigned long; this isn't true on some 32-bit hosts.
12 Avoid buffer overrun if some future version of /proc/meminfo has a
13 variable name longer than 20 bytes.
14 (system_process_attributes) [__FreeBSD__]:
15 Don't assume hw.availpages fits in 'int'.
16
c365c355
PE
172013-08-23 Paul Eggert <eggert@cs.ucla.edu>
18
19 Don't let very long directory names overrun the stack.
20 Fix some related minor problems involving "//", vfork.
21 * callproc.c (encode_current_directory): New function.
22 (call_process): Don't append "/"; not needed.
23 * fileio.c (file_name_as_directory_slop): New constant.
24 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
25 this can save the caller having to alloca.
26 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
27 Use SAFE_ALLOCA, not alloca.
28 (directory_file_name, Fexpand_file_name): Leave leading "//"
29 alone, since it can be special even on POSIX platforms.
30 * callproc.c (call_process):
31 * process.c (Fformat_network_address):
32 * sysdep.c (sys_subshell):
33 Use encode_current_directory rather than rolling our own.
34 (create_process): No need to encode directory; caller does that now.
35 * process.h (encode_current_directory): New decl.
36 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
37 Rework to avoid 'goto xyzzy;'.
38
6c6014d4
EZ
392013-08-23 Eli Zaretskii <eliz@gnu.org>
40
41 * xdisp.c (handle_face_prop): If the default face was remapped use
42 the remapped face for strings from prefix properties. (Bug#15155)
43
9997ec56
DA
442013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
45
46 Minor cleanup for redisplay interface and few related functions.
47 * frame.h (enum text_cursor_kinds): Move from here...
48 * dispextern.h (enum text_cursor_kinds): ...to here.
49 (toplevel): Drop unnecessary declarations.
50 (struct redisplay_interface): Use bool and enum text_cursor_kinds
51 in update_window_end_hook and draw_window_cursor functions.
52 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
53 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
54 * w32term.c (x_update_window_end,w32_draw_window_cursor):
55 * xterm.c (x_update_window_end, x_draw_window_cursor):
56 * xdisp.c (display_and_set_cursor, update_window_cursor)
57 (update_cursor_in_window_tree, x_update_cursor): Use bool and
58 enum text_cursor_kinds where appropriate.
59
7f780da6
DA
602013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
61
62 Redesign redisplay interface to drop updated_row and updated_area.
63 * dispextern.h (updated_row, updated_area): Remove declaration.
64 (struct redisplay_interface): Pass glyph row and row area parameters
65 to write_glyphs, insert_glyphs and clear_end_of_line functions.
66 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
67 Adjust prototypes.
68 * dispnew.c (updated_row, updated_area): Remove.
69 (redraw_overlapped_rows, update_window_line): Adjust user.
70 (update_marginal_area, update_text_area): Likewise. Pass updated row
71 as a parameter. Prefer enum glyph_row_area to int where appropriate.
72 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
73 Adjust users.
74
26495794
PE
752013-08-22 Paul Eggert <eggert@cs.ucla.edu>
76
77 * process.c (flush_pending_output): Remove stub.
78 All uses removed.
79
4a88129a
PE
802013-08-21 Paul Eggert <eggert@cs.ucla.edu>
81
82 * callproc.c: Fix race that killed background processes (Bug#15144).
83 (call_process): New arg TEMPFILE_INDEX. Callers changed.
84 Record deleted process-id in critical section, not afterwards.
85 Don't mistakenly kill process created by a call-process invocation
86 that discards output and does not wait.
87
0c5307b0
DA
882013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
89
90 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
91 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
92 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
93 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
94 to shut up compiler in mark_object.
95 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
96
0d7c1e66
PE
972013-08-21 Paul Eggert <eggert@cs.ucla.edu>
98
99 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
100 We can't portably rely on PTY_OPEN doing that, even if
101 it calls posix_openpt with O_CLOEXEC.
102
3f246b65
KH
1032013-08-20 Kenichi Handa <handa@gnu.org>
104
105 * character.c (string_char): Improve commentary.
106
8c2f38aa
PE
1072013-08-20 Paul Eggert <eggert@cs.ucla.edu>
108
109 * image.c (SIGNATURE_DIGESTSIZE): Remove.
110 (struct animation_cache): Make signature a flexible array member.
111 All uses changed. This is a tad slower but may insulate us better
112 from future changes to ImageMagick.
113
bb566cea
PE
1142013-08-19 Paul Eggert <eggert@cs.ucla.edu>
115
116 * image.c: Shrink memory needed for animation cache.
117 (SIGNATURE_DIGESTSIZE): New constant.
118 (struct animation_cache): Make 'signature' a fixed size array of bytes.
119 (imagemagick_create_cache): Copy the signature. This saves
120 several KB of memory that ImageMagick wastes per signature.
121 Don't bother updating the update_time, as the caller does that now.
122 (imagemagick_prune_animation_cache): Don't destroy the signature, as
123 it's a fixed size struct member now.
124 (imagemagick_get_animation_cache): Always destroy the signature,
125 as it's now imagemagick_create_cache's responsibility to copy it.
126 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
127 and use memcmp rather than strcmp.
128 eassert that ImageMagick returns a signature of the specified length.
129
6da26928
LMI
1302013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
131
132 * image.c (imagemagick_get_animation_cache): Don't segfault on
133 each invocation.
453f4022
LMI
134 (imagemagick_get_animation_cache): Revert to previous definition
135 so that it actually works. But keep the memory leak fix.
136 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 137
22490125
PE
1382013-08-19 Paul Eggert <eggert@cs.ucla.edu>
139
d0139df5
PE
140 * image.c: Fix animation cache signature memory leak.
141 Fix some other minor performance problems while we're at it.
142 (imagemagick_create_cache): Clear just the members that
143 need clearing. Don't set update_time, as caller does that now.
144 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
145 Simplify by using pointer-to-pointer instead of a prev pointer.
146 (imagemagick_prune_animation_cache): Use make_emacs_time rather
147 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
148 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
149 it's already a copy. Free the signature probe unless it's cached.
150
22490125
PE
151 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
152 This was introduced by my 2013-08-12 fix for Bug#15035.
153
deb31e75
DA
1542013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
155
156 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
157 (imagemagick_prune_animation_cache): Now static.
158
319a4d03
LMI
1592013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
160
161 * image.c (imagemagick_get_animation_cache): Don't segfault when
162 pruning all entries.
163
f747d82e
KB
1642013-08-18 Ken Brown <kbrown@cornell.edu>
165
166 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
167 static heap if ENABLE_CHECKING is defined.
168 (max_bss_sbrk_ptr): New variable.
169 (bss_sbrk): Use it.
170 (report_sheap_usage): Report maximum static heap usage instead of
171 ending static heap usage.
172
d2c28fab
EZ
1732013-08-17 Eli Zaretskii <eliz@gnu.org>
174
175 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
176 of zlib_initialized according to the results of calling
177 init_zlib_functions.
178
274ff63f
LMI
1792013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
180
181 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 182 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
183 (imagemagick_load_image): Remove the ping_wand code, which only
184 apparently saved time on invalid animated images, and slowed down
185 everything else. Optimise for the common case.
274ff63f 186
2bede2ed
XF
1872013-08-16 Xue Fuqiao <xfq.free@gmail.com>
188
70ff8240
XF
189 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
190
de179a3e
XF
191 * editfns.c (insert_before_markers): Mention overlay in the doc string.
192
2bede2ed
XF
193 * marker.c (set_marker): Remove documentation of undefined behavior.
194
703dbeba
LMI
1952013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
196
197 * image.c (imagemagick_compute_animated_image): Animate correctly
198 when sub-images are smaller than the main image.
1d18b1e6
LMI
199 (imagemagick_compute_animated_image): Setting the iterator row to
200 zero is apparently not allowed.
79670014
LMI
201 (imagemagick_compute_animated_image): Allow images that say they
202 have sub-images that are bigger than the main image, but just crop
203 them.
703dbeba 204
63216c5e
JD
2052013-08-15 Jan Djärv <jan.h.d@swipnet.se>
206
207 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
208
a5b5f73f
LMI
2092013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
210
211 * image.c (imagemagick_compute_animated_image): Respect the GIF
212 disposal methods.
213
0fe73012
KB
2142013-08-15 Ken Brown <kbrown@cornell.edu>
215
216 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
217 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
218 needed.
219
691a357f
PE
2202013-08-15 Paul Eggert <eggert@cs.ucla.edu>
221
222 Fix minor problems found by static checking.
223 * frame.c (delete_frame):
224 * xdisp.c (next_element_from_display_vector):
225 Avoid uninitialized local.
226 * image.c (imagemagick_compute_animated_image): Port to C89.
227 Prefer usual GNU indentation style for loops.
228 Be more careful about bizarrely large sizes, by using ptrdiff_t
229 instead of int.
230
42fe2e88
DA
2312013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
232
233 Fix infinite frame selection loop (Bug#15025).
234 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
235
d39a3da6
EZ
2362013-08-15 Eli Zaretskii <eliz@gnu.org>
237
238 * xdisp.c (compute_window_start_on_continuation_line): When
239 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
240 to make sure we end up setting the window start at the leftmost
241 visible character of the display line. This avoids funky
242 horizontal shifting because the window start is not kept on the
243 same position. (Bug#15090)
05426239
EZ
244 (next_element_from_display_vector): Support 'box' face attribute
245 in the face definitions of a display vector. (Bug#15099)
d39a3da6 246
6e856b69
LMI
2472013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
248
249 * image.c (imagemagick_compute_animated_image): Implement animated
250 images (bug#14700).
995be755
LMI
251 (imagemagick_compute_animated_image): Fix some compilation
252 warnings. Implement a very simple cache to make the animation
253 usable at all, but it should be replaced with a per-image cache.
6e856b69 254
d5a1acfa
DA
2552013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
256
257 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
258 to do `for' loops over alist values.
259 * buffer.h (FOR_EACH_BUFFER):
260 * process.c (FOR_EACH_PROCESS): Use it.
261 (handle_child_signal, status_notify, Fget_buffer_process)
262 (kill_buffer_processes): Use FOR_EACH_PROCESS.
263
9c253307
DA
2642013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
265
266 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
267 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
268 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
269 to xzalloc and so avoid redundant call to memset.
270 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
271 members because it is allocated with xzalloc and so already zeroed.
272
05e64f9f
KB
2732013-08-14 Ken Brown <kbrown@cornell.edu>
274
275 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
276 (Bug#15094).
277
5b71542d
DA
2782013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
279
280 Utility function and macro to copy Lisp string to C string.
281 * lisp.h (xlispstrdupa): New macro.
282 (xlispstrdup): New prototype.
283 * alloc.c (xlispstrdup): New function.
284 * callint.c (Fcall_interactively):
285 * fileio.c (Ffile_name_directory, Fexpand_file_name)
286 (Fsubstitute_in_file_name):
287 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
288 * image.c (x_create_bitmap_from_file):
289 * w32term.c (w32_term_init):
290 * xterm.c (x_term_init): Use xlispstrdup.
291
71530c97
LMI
2922013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
293
4ce82fb8
LMI
294 * image.c (imagemagick_load_image): Make animated pictures work.
295 There's still some problems with background color settings, though
296 (bug#14700).
297
71530c97
LMI
298 * decompress.c (unwind_decompress): Always restore point.
299
7510a061
XF
3002013-08-14 Xue Fuqiao <xfq.free@gmail.com>
301
302 * marker.c (set_marker): Reformat documentation.
303
01c3051f
PE
3042013-08-14 Paul Eggert <eggert@cs.ucla.edu>
305
aab1fcdf
PE
306 * xdisp.c (cursor_type_changed): Now static.
307
01c3051f
PE
308 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
309 Use changed. This avoids the need to call xmalloc and for the
310 caller to call xfree, and avoids memory leaks in some situations.
311
2084152a
DA
3122013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
313
314 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
315 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
316 (redisplay_window): If window_end_valid is cleared due to non-zero
317 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
318 so do not call to try_cursor_movement for that window.
2084152a 319
02455cb6
DA
3202013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
321
322 * window.h (struct window): Convert window_end_pos and
323 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
324 (wset_window_end_pos, wset_window_end_vpos): Remove.
325 * dispnew.c (adjust_glyph_matrix):
326 * window.c (Fwindow_end, replace_window, set_window_buffer)
327 (make_window):
328 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
329 (set_vertical_scroll_bar, redisplay_window, try_window)
330 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
331 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
332 (note_mouse_highlight): Adjust users.
333 (try_cursor_movement): Likewise. Convert old precondition to eassert.
334 Add comment.
335
da5707e8
DA
3362013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
337
338 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
339 * image.c (imagemagick_filename_hint): Use `const char *' and
340 prefer SSDATA to SDATA to avoid warnings.
341
25554267
DA
3422013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
343
344 Cleanup window fringes, margins and scroll bars adjustments.
345 * window.c (set_window_fringes, set_window_margins)
346 (set_window_scroll_bars, apply_window_adjustment): New functions.
347 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
348 (Fset_window_scroll_bars): Use them.
349
38a2c910
DA
3502013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
351
352 * window.h (struct window): Convert scroll_bar_width
353 from Lisp_Object to integer. Adjust comment.
354 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
355 Adjust users.
356 * window.c (wset_scroll_bar_width): Remove.
357 (make_window): Initialize scroll_bar_width.
358 (Fsplit_window_internal): Use direct assignment.
359 (Fset_window_configuration, save_window_save):
360 Convert Lisp_Object to integer and back where appropriate.
361 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
362 bar was actually changed, and mention this in docstring.
363
2d065031
PE
3642013-08-13 Paul Eggert <eggert@cs.ucla.edu>
365
366 * decompress.c: Minor simplifications.
367 (Fzlib_decompress_region): Don't bother verifying
368 that avail_out <= UINT_MAX, as that was confusing.
369 Mention the restriction in a comment instead.
370 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
371
a5bd5abb
JD
3722013-08-13 Jan Djärv <jan.h.d@swipnet.se>
373
374 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
375 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
376
66e7901a
LMI
3772013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
378
379 * image.c (imagemagick_filename_hint): Check for errors in the
380 alist structure.
381
2fa611b7
EZ
3822013-08-13 Eli Zaretskii <eliz@gnu.org>
383
384 * window.c (Fwindow_margins): Return nil when there's no marginal
385 area, as per the documented API.
386
387 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
388 Fmake_vector, as scroll bar's struct members are not all Lisp
389 objects now. This avoids crashes in GC.
390
391 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
392 bool, so its address could be taken.
393
8259030d
LMI
3942013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
395
396 * image.c (imagemagick_filename_hint): New function to possibly
397 apply `image-content-type-suffixes'.
398 (imagemagick_load_image): Use it.
399
866c710e
EZ
4002013-08-13 Eli Zaretskii <eliz@gnu.org>
401
402 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
403 if loading zlib failed.
404
f10490f0
JD
4052013-08-13 Jan Djärv <jan.h.d@swipnet.se>
406
96311be7
JD
407 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
408 2013-08-13 checkin below. Change bool to BOOL, rule is:
409 All Obj-C code uses BOOL, except for interfaces callable from C.
410
f10490f0
JD
411 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
412
c8ae93b0
DA
4132013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
414
415 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
416 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
417 bool instead of BOOL.
418 * w32term.h (struct scroll_bar): Convert fringe_extended_p
419 from Lisp_Object to bitfield. Adjust comment.
420 * w32term.c (x_scroll_bar_create): Adjust user.
421 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
422 * xterm.c (XTset_vertical_scroll_bar): Likewise.
423 Use bool for boolean.
424 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
425 to `unsigned int' when defining a bitfield.
426
53b64418
PE
4272013-08-13 Paul Eggert <eggert@cs.ucla.edu>
428
429 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
430
eeaf9bf3
DA
4312013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
432
433 * window.h (struct window): Convert left_margin_cols and
434 right_margin_cols from Lisp_Objects to integers. Adjust comment.
435 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
436 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
437 Adjust users.
438 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
439 Adjust comment.
440 (showing_window_margins_p, update_window_line, update_frame_1):
441 * fringe.c (draw_fringe_bitmap_1):
442 * xdisp.c (window_box_width): Adjust users.
443 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
444 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
445 Use direct assignment.
446 (Fset_window_configuration, save_window_save, Fwindow_margins):
447 Convert Lisp_Object to integer and back where appropriate.
448 (Fset_window_margins): Adjust user. Return t if any margin
449 was actually changed, and mention this in docstring.
450
956720af
XF
4512013-08-13 Xue Fuqiao <xfq.free@gmail.com>
452
f73f4ce6 453 * syntax.c (forward_word):
956720af
XF
454 * cmds.c (forward_char, backward_char): Mention the optional argument.
455
9e37ee3b
DA
4562013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
457
458 * window.h (struct window): Convert left_fringe_width
459 and right_fringe_width from Lisp_Objects to integers.
460 Adjust comment.
461 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
462 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
463 * window.c (wset_left_fringe_width, wset_right_fringe_width):
464 Remove.
465 (make_window): Initialize new integer fields to -1.
466 (Fsplit_window_internal): Use direct assignment.
467 (Fset_window_configuration, save_window_save): Convert
468 Lisp_Object to integer and back where appropriate.
469 (Fset_window_fringes): Adjust user. Return t if any fringe
470 was actually changed, and mention this in docstring.
471
e4375ca7
DA
4722013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
473
474 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
475 * nsfns.m (x_set_cursor_type):
476 * w32fns.c (x_set_cursor_type):
477 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
478 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 479
a45543bc
DA
4802013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
481
482 * font.c (clear_font_cache): New function, stripped from...
483 (Fclear_font_cache): ...here, which now uses the function
484 above. Adjust comment.
485 * font.h (clear_font_cache): Add prototype.
486 * xfaces.c (clear_face_cache): Use clear_font_cache.
487
ae966a86
DA
4882013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
489
490 * window.c (Fset_window_start): Compare `w', not `window' because
491 `w' might not be equal to `window' after call to decode_live_window.
492
297a545b
PE
4932013-08-12 Paul Eggert <eggert@cs.ucla.edu>
494
495 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
496 This fixes a problem introduced by the Bug#15035 patch
497 when using GPG. Reported by Herbert J. Skuhra.
498
aa942e2b
EZ
4992013-08-12 Eli Zaretskii <eliz@gnu.org>
500
501 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
502 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
503 not yet initialized.
504
7699d09e
LMI
5052013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
506
507 * decompress.c (Fzlib_decompress_region): Support zlib
508 decompression, too, and rename.
509
1d238bc7
PE
5102013-08-12 Paul Eggert <eggert@cs.ucla.edu>
511
512 Minor zlib configuration tweaks.
513 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
514 Don't assume presence of fn_inflateInit2_ zlib internal function.
515
8a44a184
LMI
5162013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
517
518 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
519 include the zlib prefix.
520
594a4307
EZ
5212013-08-12 Eli Zaretskii <eliz@gnu.org>
522
523 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
524 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
525 define static variables that are pointers to zlib functions to be
526 dynamically loaded.
527 (init_zlib_functions) [WINDOWSNT]: New function.
528 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
529 New macros.
530 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
531 macros instead of invoking the zlib functions directly.
532 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
533 Szlib_available_p.
534
d2e113bc
DA
5352013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
536
537 Avoid looping over all frame windows to freeze and unfreeze.
538 * window.h (struct window): Drop frozen_window_start_p.
539 (freeze_window_starts): Drop prototype.
540 * frame.h (struct frame): New frozen_window_starts flag.
541 (FRAME_WINDOWS_FROZEN): New macro.
542 * window.c (freeze_window_start, freeze_window_starts):
543 Remove.
544 (select_window, replace_window): Adjust users.
545 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
546 (window_frozen_p): New function.
547 (redisplay_window): Use it.
548
94fcd171
PE
5492013-08-12 Paul Eggert <eggert@cs.ucla.edu>
550
551 Fix some fd issues when running subprocesses (Bug#15035).
552 Fix bugs that can leak files or file descriptors on errors.
553 Don't unlink open temp files, as that's hard for users to diagnose
554 when things go awry (e.g., temp disk exhausted).
555 Don't bother to lock temp files. Check for invalid recursion.
556 * callproc.c (synch_process_fd): Remove. All uses removed.
557 (synch_process_tempfile): New var or macro.
558 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
559 New constants.
560 (record_kill_process): New arg, the temp name. All callers changed.
561 (delete_temp_file): Now just a simple wrapper around unlink.
562 (call_process_kill): New arg, the call_process_fd array.
563 Close them all. Clear synch_process_pid. Remove the temp file,
564 or arrange for it to be removed.
565 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
566 that's been moved to synch_process_tempfile. Caller changed.
567 Do not remove the tempfile; that's now call_process_kill's
568 responsibility.
569 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
570 call_process_kill; the caller now does that.
571 (call_process_cleanup): Do not close the process fd; that's now
572 call_process_kill's responsibility.
573 (Fcall_process): Implement via new function call_process, which
574 has most of the old body of Fcall_process, but with a different API.
575 (call_process): New function that does not open or close filefd if
576 it is nonnegative. Record which fds need to be closed, and let
577 call_process_kill close (and remove the tempfile, on MSDOS) on error.
578 Signal an error if invoked recursively (could be done via a hook).
579 Simplify creation of the tempfile in the MSDOS case.
580 Don't create the output file until after checking for the executable.
581 Report any failure to open /dev/null.
582 Don't open /dev/null for writing twice; once is enough.
583 Don't create pipe if all output is being discarded or sent to file.
584 Don't worry about setting up the coding system or reading from the
585 pipe if all output is being discarded.
586 Hoist fd_error local into top level, to lessen block nesting.
587 Don't record deleted pid here; now done by Fcall_process_region.
588 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
589 and note its success in synch_process_tempfile.
590 Do not leak resources when child_setup fails.
591 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
592 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
593 (create_temp_file): Now returns open fd, with an additional
594 Lisp_Object * argument to return the name. All callers changed.
595 Do not close the file; rewind it instead, and leave it open for
596 the caller. Do not lock the temp file. Unwind-protect the file
597 and the file-descriptor.
598 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
599 If an asynchrounous process, record it here, not in call_process.
600 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
601 * eval.c (set_unwind_protect): New function.
602 * fileio.c (write_region): New function, generalized from the
603 old Fwrite_region. Do not lock temp files.
604 (Fwrite_region): Use it.
605 * lisp.h (set_unwind_protect, write_region): New decls.
606 * process.c: Include <verify.h>.
607 (make_process): Mark fds as initially closed.
608 (deleted_pid_list): Now a list of pid-filename pairs.
609 All uses changed.
610 (close_process_fd): New function.
611 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
612 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
613 New constants. Verify that their number matches PROCESS_OPEN_FDS.
614 (create_process, create_pty, Fmake_serial_process)
615 (server_accept_connection): Record which fds need to be closed,
616 and let deactivate_process close them.
617 (Fmake_network_process): Do not discard the unwind-protect
618 until it's safe to do so.
619 (deactivate_process): Close the fds opened by create_process etc.
620 (Fprocess_send_eof): Adjust to new way of recording open fds.
621 Report an error if /dev/null can't be opened, instead of aborting.
622 * process.h (PROCESS_OPEN_FDS): New constant.
623 (struct Lisp_Process): New member open_fds.
624 (record_kill_process, record_deleted_pid): Adjust signatures.
625 (record_deleted_pid): Move decl here ...
626 * syswait.h (record_deleted_pid): ... from here.
627
d0e615c3
PE
6282013-08-11 Paul Eggert <eggert@cs.ucla.edu>
629
630 * decompress.c: Fix bugs with large buffers and weird inputs.
631 Tune a bit. Reindent as per usual Emacs style.
632 (BUFFER_SIZE): Remove.
633 (Fdecompress_gzipped_region): Do not mishandle input buffers with
634 more than UINT_MAX bytes. Decompress into the gap instead of into
635 an auto buffer, as this should avoid copying. Return nil if
636 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
637 set immediate_quit; we shouldn't trust zlib code that much.
638
313546eb
LMI
6392013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
640
99a32242
LMI
641 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
642 errors, and really move the gap to where we want it.
643
313546eb
LMI
644 * lisp.h: Include decompress.c support.
645
646 * emacs.c (main): Include decompress.c support.
647
648 * Makefile.in: Include -lz if present.
649
d2d699ac
JD
6502013-08-11 Jan Djärv <jan.h.d@swipnet.se>
651
f90e3ebd
JD
652 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
653 (initWithTitle:): Initialize frame to 0.
654 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
655 (fillWithWidgetValue:frame:): Renamed from
656 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
657
658 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
659 fillWithWidgetValue:frame:
660
423d3b3f
JD
661 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
662 remove memory leak warnings.
663
d2d699ac
JD
664 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
665 (ns_check_menu_open): Handle menu == nil. Remove assignment to
666 menu_pending_title.
667
668 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
669 (x_activate_menubar): Update the whole menu.
670 (trackingNotification:): Call ns_check_menu_open if tracking ends.
671 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
672 current event is not NSSystemDefined (Bug#15001).
673 Call ns_check_menu_open only if trackingMenu is 2.
674 (menuDidClose:): New method, decrease trackingMenu.
675 (fillWithWidgetValue:setDelegate:): New method.
676 (fillWithWidgetValue:): Call the above.
677
678 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
679
7d652d97
PE
6802013-08-11 Paul Eggert <eggert@cs.ucla.edu>
681
682 Omit some unnecessary casts.
683 Many of these go back to the old pre-C89 days, when they may have
684 been needed, but we've been assuming C89 or later for a while now.
685 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
686 (live_float_p, live_misc_p, live_vector_p):
687 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
688 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
689 (defvar_per_buffer):
690 * callint.c (Fcall_interactively):
691 * doc.c (Fsubstitute_command_keys):
692 * filelock.c (get_boot_time):
693 * frame.c (xrdb_get_resource):
694 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
695 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
696 (xg_get_file_name_from_selector, menuitem_destroy_callback)
697 (menuitem_highlight_callback, menu_destroy_callback)
698 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
699 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
700 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
701 (xg_tool_bar_help_callback, tb_size_cb):
702 * image.c (xpm_alloc_color, png_read_from_memory)
703 (png_read_from_file, png_load_body, our_memory_skip_input_data)
704 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
705 (syms_of_image):
706 * keymap.c (describe_map):
707 * nsfns.m (Fns_display_monitor_attributes_list):
708 * nsmenu.m (process_dialog:):
709 * nsterm.m (hold_event):
710 * process.c (wait_reading_process_output):
711 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
712 * scroll.c (do_direct_scrolling, scrolling_1):
713 * termcap.c (tgetent):
714 * window.c (check_window_containing, add_window_to_list)
715 (freeze_window_starts):
716 * xdisp.c (compare_overlay_entries, vmessage):
717 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
718 (x_get_monitor_attributes_xrandr)
719 (Fx_display_monitor_attributes_list, x_display_info_for_name)
720 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
721 * xfont.c (xfont_match, xfont_open):
722 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
723 (menubar_selection_callback, menu_position_func)
724 (popup_selection_callback, create_and_show_popup_menu)
725 (dialog_selection_callback, create_and_show_dialog):
726 * xrdb.c (x_get_string_resource):
727 (main) [TESTRM]:
728 * xsmfns.c (x_session_check_input):
729 * xterm.c (x_draw_glyphless_glyph_string_foreground)
730 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
731 (xaw_jump_callback, xaw_scroll_callback):
732 Omit unnecessary casts.
733
9acc1074
PE
7342013-08-10 Paul Eggert <eggert@cs.ucla.edu>
735
736 Minor string-length refactoring.
737 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
738 * frame.c (make_monitor_attribute_list):
739 Prefer build_string to strlen + make_string.
740
361c0eb8
JD
7412013-08-10 Jan Djärv <jan.h.d@swipnet.se>
742
743 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
744 don't check minor_code (Bug#14417).
745
14ba0822
EZ
7462013-08-09 Eli Zaretskii <eliz@gnu.org>
747
748 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
749 vertical positions instead. This avoids calling MATRIX_ROW with
750 row numbers that are possibly beyond valid limits. (Bug#15064)
751
309f24d1
DA
7522013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
753
754 Use xstrdup and build_unibyte_string where applicable.
755 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
756 * xfns.c (x_window):
757 * xrdb.c (x_get_customization_string):
758 * xterm.c (xim_initialize):
759 * w32fns.c (w32_window): Use xstrdup.
760 (w32_display_monitor_attributes_list):
761 * emacs.c (init_cmdargs):
762 * keyboard.c (PUSH_C_STR):
763 * nsfont.m (nsfont_open):
764 * sysdep.c (system_process_attributes):
765 * w32.c (system_process_attributes):
766 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
767
55902276
EZ
7682013-08-09 Eli Zaretskii <eliz@gnu.org>
769
770 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
771 variables of these types so that GDB would know about them, as aid
772 for debugging fatal exceptions. (Bug#15024) See also
773 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
774 discussions.
775
10bf7f5a
JD
7762013-08-08 Jan Djärv <jan.h.d@swipnet.se>
777
778 * nsterm.m (ns_update_begin): Don't change clip path if it would be
779 larger than the NSWindow (Bug#14934).
780
65620264
DA
7812013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
782
783 Redesign redisplay interface to drop global variable updated_window.
784 Always pass currently updated window as a parameter to update routines.
785 * dispextern.h (updated_window): Remove declaration.
786 (struct redisplay_interface): Pass window parameter to
787 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
788 and after_update_window_hook.
789 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
790 Adjust prototypes.
791 * dispnew.c (updated_window): Remove.
792 (redraw_overlapped_rows, update_marginal_area, update_text_area)
793 (update_window_line): Adjust to match redisplay interface changes.
794 * nsterm.m (ns_update_window_begin, ns_update_window_end)
795 (ns_scroll_run, ns_after_update_window_line):
796 * w32term.c (x_update_window_begin, x_update_window_end)
797 (x_after_update_window_line, x_scroll_run):
798 * xterm.c (x_update_window_begin, x_update_window_end)
799 (x_after_update_window_line, x_scroll_run):
800 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
801 Likewise. Adjust comments where appropriate.
802 (x_cursor_to): Simplify because this is always called during window
803 update (but install debugging check anyway).
804 (expose_window): Check must_be_updated_p flag to see whether this
805 function is called during window update.
806
628fdc56
DA
8072013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
808
809 Do not reset window modification event counters excessively.
810 These leftovers and poor man's tricky methods to catch extra
811 redisplay's attention are no longer needed.
812 * frame.c (set_menu_bar_lines_1):
813 * minibuf.c (read_minibuf_unwind):
814 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
815 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
816 (window_scroll_line_based, Fset_window_configuration):
817 * xdisp.c (redisplay_window): Do not reset last_modified and
818 last_overlay_modified counters.
819
8fd9c92e
JD
8202013-08-07 Jan Djärv <jan.h.d@swipnet.se>
821
822 * xselect.c (x_send_client_event): Set send_event and serial, memset
823 data.l as it might be bigger than data.b. Use 24 bit mask to
824 XSendEvent (Bug#15034).
825
0ee18172
EZ
8262013-08-07 Eli Zaretskii <eliz@gnu.org>
827
828 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
829 for TTY frames that are not the top frame on their console.
830 (Bug#14616)
831
16ddd1a6
MR
8322013-08-07 Martin Rudalics <rudalics@gmx.at>
833
834 * w32term.c (w32fullscreen_hook): Really maximize frame when
835 asked for (Bug#14841).
836
d2a95ffb
DA
8372013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
838
839 Prefer selected_window to Fselected_window, likewise for frames.
840 * buffer.c (Fbuffer_swap_text):
841 * data.c (Fvariable_binding_locus):
842 * window.c (run_window_configuration_change_hook): Adjust users.
843 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
844 Use decode_live_frame.
845
170da1ec
DA
8462013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
847
848 Be more careful if selected window shows the buffer other than current,
849 use window_outdated only if this is not so. This change should also
850 address some weird issues discussed in Bug#13012.
851 * window.h (window_outdated): New prototype.
852 * window.c (window_outdated): Now here. Convert from static and
853 always assume window's buffer.
854 (Fwindow_end, Fwindow_line_height): Use it.
855 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
856 and always assume window's buffer.
857 (redisplay_window): Adjust user.
e5eefe9b 858 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
859 check whether mode line should be updated only if selected window
860 shows current buffer.
861 (run_window_scroll_functions): Use eassert for debugging check.
862 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
863
56b5d5b1
DA
8642013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
865
866 * window.c (window_scroll, window_scroll_pixel_based)
867 (window_scroll_line_based): Use bool for booleans.
868
2878ba7e
PE
8692013-08-06 Paul Eggert <eggert@cs.ucla.edu>
870
871 * process.c: Fix minor off-by-one issues in descriptor counts.
872 This shouldn't fix any real bugs, but it cleans up the code a bit.
873 (max_process_desc, max_input_desc): -1, not 0, means none.
874 All uses changed.
875 (delete_input_desc): New function.
876 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
877 (deactivate_process): Scan backwards when recomuting max_process_desc;
878 that should be faster.
879 (init_process_emacs): Initialize max_input_desc.
880
e30b79c1
DA
8812013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
882
883 Use region cache to speedup bidi_find_paragraph_start.
884 * buffer.h (struct buffer): New member bidi_paragraph_cache.
885 Rename cache_long_line_scans to cache_long_scans.
886 * buffer.c (bset_cache_long_line_scans): Rename to
887 bset_cache_long_scans.
888 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
889 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
890 into account.
891 (syms_of_buffer): Rename cache-long-line-scans to
892 cache-long-scans. Adjust docstring.
893 * search.c (newline_cache_on_off):
894 * indent.c (width_run_cache_on_off): Adjust users.
895 * bidi.c (bidi_paragraph_cache_on_off): New function.
896 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
897 * insdel.c (prepare_to_modify_buffer): Invalidate
898 bidi_paragraph_cache if enabled.
899
00012b86
DA
9002013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
901
902 Invalidate region caches only if buffer text is going to be changed.
903 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
904 (modify_text): ...new prototype.
905 (prepare_to_modify_buffer_1): New prototype.
906 * textprop.c (modify_region): Rename to...
907 (modify_text_properties): ...new function.
908 (add_text_properties_1, set_text_properties, Fremove_text_properties)
909 (Fremove_list_of_text_properties): Adjust users.
910 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
911 (modify_text): ...new function.
912 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
913 (prepare_to_modify_buffer_1): ...new function.
914 * casefiddle.c (casify_region):
915 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
916 (Ftranspose_regions): Use modify_text.
917
dc6c0eda
SM
9182013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
919
920 * lisp.mk (lisp): Add nadvice.elc.
921
8f3a2c26
DA
9222013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
923
924 New macro to iterate over live buffers similar to frames.
925 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
926 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
927 Declare buffer-related variables here to offload lisp.h.
928 * buffer.c (Vbuffer_alist): Adjust comment.
929 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
930 (other_buffer_safely):
931 * data.c (store_symval_forwarding):
932 * dispnew.c (Fframe_or_buffer_changed_p):
933 * fileio.c (Fdo_auto_save):
934 * filelock.c (unlock_all_files):
935 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
936
e0fdb694
PE
9372013-08-04 Paul Eggert <eggert@cs.ucla.edu>
938
939 Fix some minor races in hosts lacking mkostemp (Bug#15015).
940 * callproc.c (create_temp_file):
941 * filelock.c (create_lock_file):
942 Assume mkostemp, since it's now provided by Gnulib.
943
63f5c6c2
EZ
9442013-08-04 Eli Zaretskii <eliz@gnu.org>
945
946 * w32.c (mkostemp): New function.
947 (mktemp): Remove, no longer used. Most of the code reused in
948 mkostemp. (Bug#15015)
484ab239 949 (mktemp): Don't undef.
63f5c6c2 950
f0b79313
DA
9512013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
952
953 * dispnew.c (glyph_matrix_count, glyph_pool_count):
954 Move under GLYPH_DEBUG and ENABLE_CHECKING.
955 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
956 (free_glyph_pool, check_glyph_memory): Likewise for
957 all users. Adjust comments where appropriate.
958
98f638d6
PE
9592013-08-03 Paul Eggert <eggert@cs.ucla.edu>
960
961 * composite.h: Minor fixups.
962 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
963 to fix a misspelling, and change it to an inline function while
964 we're at it (it need not be a macro). All uses changed.
965 (composition_method, composition_valid_p):
966 Rewrite to avoid assignments in if-conditions.
967
75c59fb3
DA
9682013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
969
970 Do not use global Lisp_Object in composition macros.
971 * composite.h (composition_temp): Remove declaration.
972 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
973 (composition_method, composition_valid_p): ...inline functions.
416a3e01 974 (compose_region): Remove the leftover.
75c59fb3
DA
975 * composite.c (composition_temp): Remove.
976 (run_composition_function, update_compositions)
977 (composition_compute_stop_pos, composition_adjust_point)
978 (Ffind_composition_internal):
979 * coding.c (handle_composition_annotation):
980 * xdisp.c (handle_composition_prop, check_point_in_composition):
981 Related users changed.
982
a10c8269
DA
9832013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
984
985 Drop FRAME_PTR typedef.
986 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
987 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
988 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
989 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
990 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
991 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
992 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
993 All related users changed.
994
a104f656
SM
9952013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
996
997 * eval.c (default_toplevel_binding): New function.
998 (Fdefvar): Use it.
999 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1000 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1001 (syms_of_eval): Export them.
1002 * data.c (Fdefault_value): Micro cleanup.
1003 * term.c (init_tty): Use "false".
1004
4b5c9326
DA
10052013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1006
1007 Fix X GC leak in GTK and raw (no toolkit) X ports.
1008 * xterm.c (x_free_frame_resources): If white and black relief
1009 GCs are allocated, always free them here.
1010 * xfns.c (x_make_gc): Omit redundant initialization.
1011 * widget.c (create_frame_gcs): Remove the leftover.
1012 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1013 in x_free_frame_resources.
1014
b19aa636
JD
10152013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1016
1017 * nsterm.m (windowWillResize:toSize:): Only change title if
1018 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1019 modifying it.
1020 (viewDidEndLiveResize): New method.
1021
1022 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1023 inside NS_IMPL_COCOA.
1024
af1f7e06
DA
10252013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1026
1027 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1028 Do not check whether undo is enabled because record_insert and
1029 record_delete does that themselves.
1030
65b02bb9
DA
10312013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1032
1033 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1034 member which is not really used any more.
1035 (FRAME_XIC_BASE_FONTNAME): Remove.
1036 * xfns.c (xic_free_fontset): Adjust user.
1037 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1038 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1039 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1040 (xdialog_show): Use eassert for debugging check.
7ee0f047 1041 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1042
6318cde0
PE
10432013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1044
1045 * fileio.c, fns.c (merge): Move extern decl from here ...
1046 * lisp.h (merge): ... to here.
1047
6c1a09ba
DA
10482013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1049
1050 Fix last font-related change.
1051 * w32font.h (w32font_list_internal, w32font_match_internal):
1052 Fix prototype.
1053 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1054 (uniscribe_list_family): Adjust to match font API change.
1055 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1056 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1057
f8c20208
DA
10582013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 * frame.h (FRAME_MOUSE_UPDATE):
1061 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1062 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1063
fdb396e2
DA
10642013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1065
1066 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1067 * font.h (struct font_driver): Change list, match, and list_family
1068 functions to accept struct frame * as first arg.
1069 * font.c (font_score, font_compare, font_sort_entities): Remove
1070 prototypes.
1071 (font_sort_entities, font_list_entities, font_select_entity):
1072 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1073 match font API change.
1074 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1075 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1076 * ftxfont.c (ftxfont_list, ftxfont_match):
1077 * xftfont.c (xftfont_list, xftfont_match):
1078 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1079 * w32font.c (w32font_list, w32font_match, w32font_list):
1080 (w32font_list_internal, w32_font_match_internal): Likewise.
1081 * xfaces.c (Fx_family_fonts): Adjust user.
1082
52b8a085
DA
10832013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1084
1085 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1086 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1087 only if HAVE_X_WINDOWS is in use.
1088 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1089 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1090 * w32term.c (x_wm_set_icon_position): Likewise.
1091 * w32fns.c (x_icon): Adjust user.
1092
c791c18e
DA
10932013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1094
1095 * xterm.c (last_mouse_press_frame): Remove the
1096 leftover which is not really used any more.
1097 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1098 (x_flush): Call XFlush once per each X display, not frame.
1099 This is better because this code always unconditionally skips
1100 non-X frames in Vframe_list and issues the only XFlush if we
1101 have more than one X frame on the same X display.
2f935d86
DA
1102 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1103 Use bool for booleans.
1104 (x_draw_glyph_string_background, cvt_string_to_pixel):
1105 (cvt_pixel_dtor): Drop unnecessary prototypes.
1106 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1107
f435830e
DA
11082013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1109
1110 Drop unnecessary functions that deals with frame pixel size.
1111 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1112 (x_pixel_height): Drop prototypes.
1113 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1114 (x_pixel_height): Drop implementations.
1115 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1116 which should be always valid for window frame.
1117 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1118 * w32menu.c (Fx_popup_dialog):
1119 * xmenu.c (Fx_popup_dialog): Likewise for both.
1120
84231434
DA
11212013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1124 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1125 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1126 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1127 and mention nil frame in docstring.
84231434 1128
959067a1
DA
11292013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1130
1131 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1132 (x_figure_window_size): Likewise. Adjust to return long.
1133 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1134 (toplevel): Move Qterminal_live_p to...
1135 * terminal.c (toplevel): ...here, make it static, and...
1136 (syms_of_terminal): ...DEFSYM here.
1137 * frame.h (Qterminal_live_p): Remove declaration.
1138 (make_frame, x_figure_window_size): Adjust prototype.
1139 * nsfns.m (Fx_create_frame): Use long for window flags.
1140
f4b169ce
PE
11412013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1142
1143 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1144 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1145 Do not assume that emacs_close (INT_MAX) is a no-op.
1146
bee6a2c7
DA
11472013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1148
1149 * xfaces.c (make_face_cache): For struct face_cache, prefer
1150 xmalloc to xzalloc and so avoid redundant call to memset.
1151 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1152
d7e6881a
DA
11532013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 * fringe.c (draw_window_fringes, update_window_fringes)
1156 (compute_fringe_widths):
1157 * w32term.c (x_draw_glyph_string):
1158 * window.c (candidate_window_p, Frecenter):
1159 * xfaces.c (realize_basic_faces, realize_default_face)
1160 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1161 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1162 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1163 * xmenu.c (Fx_menu_bar_open_internal):
1164 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1165 * xsettings.c (xft_settings_event):
1166 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1167 Use bool for booleans. Adjust style and comments where
1168 appropriate.
1169 * dispextern.h (draw_window_fringes, update_window_fringes)
1170 (compute_fringe_widths):
1171 * xterm.h (x_had_errors_p): Adjust prototype.
1172
ec3058af
DA
11732013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1174
1175 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1176 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1177
218e0637
DA
11782013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1179
1180 * fns.c (toplevel): Remove comment before Fsafe_length because
1181 it checks for QUIT.
1182
e560aba9
PE
11832013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1186
2e5ce5de
EZ
11872013-07-28 Eli Zaretskii <eliz@gnu.org>
1188
1189 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1190 frame which got the message is still alive, before dereferencing
1191 its pointer. (Bug#14970)
1192
1193 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1194 be a live window, before using it as such. (Bug#14970)
1195
e95da6d3
EZ
11962013-07-27 Eli Zaretskii <eliz@gnu.org>
1197
1198 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1199 w32_detect_focus_change instead of doing part of its job by hand.
1200 This fixes the problem whereby FOCUS_OUT events were not sent to
1201 the event queue.
1202
a8f93651
EZ
12032013-07-26 Eli Zaretskii <eliz@gnu.org>
1204
fec92060
EZ
1205 * process.c (Fprocess_list): Doc fix.
1206
a8f93651
EZ
1207 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1208 being re-exposed only if it didn't ask to become visible.
1209 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1210 was previously iconified. (Bug#14841)
1211 (x_iconify_frame): Mark the frame iconified.
1212
d5a7a9d9
PE
12132013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1214
1215 Fix minor problems found by static checking.
1216 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1217 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1218
56ea7291
SM
12192013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1220
1221 * eval.c (set_specpdl_old_value): New function.
1222 (unbind_to): Minor simplification.
1223 (get_backtrace_frame): New function.
1224 (Fbacktrace_frame): Use it. Add `base' argument.
1225 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1226 (syms_of_eval): Export backtrace-eval.
1227 * xterm.c (x_focus_changed): Simplify.
1228
9d611ffe
PE
12292013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1230
1231 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1232
999c74e3
EZ
12332013-07-24 Eli Zaretskii <eliz@gnu.org>
1234
1235 * xdisp.c (redisplay_window): Instead of moving point out of
1236 scroll margin, reject the force_start method, and try scrolling
1237 instead. (Bug#14780)
1238
198fa217
KB
12392013-07-24 Ken Brown <kbrown@cornell.edu>
1240
1241 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1242 (Bug#14944).
1243
53840e55
PE
12442013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * eval.c (Fprogn): Do not check that BODY is a proper list.
1247 This undoes the previous change. The check slows down the
1248 interpreter, and is not needed to prevent a crash. See
1249 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1250
60967f56
GM
12512013-07-23 Glenn Morris <rgm@gnu.org>
1252
1253 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1254
9ca960e2
PE
12552013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1256
a29c3e6d
PE
1257 Port to GNU/Linux systems with tinfo but not ncurses.
1258 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1259 to decide whether ncurses is being used. Without this change,
1260 GCC complains about tgetent not being declared, on a system
1261 that has tinfo installed but ncurses not installed.
1262
f274311c
PE
1263 * eval.c (Fprogn): Check that BODY is a proper list.
1264
16b0520a
PE
1265 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1266 * data.c (Fsetq_default):
1267 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1268 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1269 (Fcondition_case):
1270 Tune by taking advantage of the fact that ARGS is always a list
1271 when a function is declared to have UNEVALLED args.
1272
9ca960e2
PE
1273 * emacsgtkfixed.c: Port to GCC 4.6.
1274 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1275
afacaa1b
JB
12762013-07-23 Juanma Barranquero <lekktu@gmail.com>
1277
1278 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1279 here to silence compiler warnings.
1280
368a85a4
PE
12812013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1284 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1285 from messing up Emacs's 'struct frame' (Bug#14923).
1286
f4e891b5
PE
12872013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1288
1289 * alloc.c (make_save_ptr_ptr): Define this function.
1290 It was inadvertently omitted. It's needed only if
1291 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1292
96c8b65e
JD
12932013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1294
1295 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1296 frame have focus (Bug#14895).
1297
ee010797
PE
12982013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 Avoid vfork-related deadlock more cleanly.
1301 * callproc.c (child_setup): When the child's exec fails, output
1302 the program name, as that's more useful. Use O_NONBLOCK to avoid
1303 deadlock.
1304 * process.c (create_process_1): Remove; no longer needed.
1305 (create_process): Remove timer hack; no longer needed, now that
1306 the child avoids deadlock.
1307
f0398ec1 13082013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1309
1310 * image.c (Fimage_flush): Fix doc typo.
1311
b2a069c2
PE
13122013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1313
6496aec9
PE
1314 Fix array bounds violation when pty allocation fails.
1315 * process.c (PTY_NAME_SIZE): New constant.
1316 (pty_name): Remove static variable; it's now auto.
1317 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1318 Take pty_name as an arg rather than using a static variable.
1319 All callers changed.
1320 (create_process): Recover pty_flag from process, not from volatile local.
1321 (create_pty): Stay inside array even when pty allocation fails.
1322 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1323
b2a069c2
PE
1324 * lread.c (Fload): Avoid initialization only when lint checking.
1325 Mention that it's needed only for older GCCs.
1326
99107004
KH
13272013-07-20 Kenichi Handa <handa@gnu.org>
1328
1329 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1330 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1331
6b1b199d
AS
13322013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1333
1334 * lread.c (Fload): Avoid uninitialized warning.
1335
4195afc3
PE
13362013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1337
3f5bef16
PE
1338 Fix some minor file descriptor leaks and related glitches.
1339 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1340 (create_lock_file): Use write, not emacs_write.
1341 * image.c (slurp_file, png_load_body):
1342 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1343 (server_accept_connection):
1344 Don't leak an fd on memory allocation failure.
1345 * image.c (slurp_file): Add a cheap heuristic for growing files.
1346 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1347 as that's what the other routines do. Maybe input need not be
1348 blocked at all, but it's better to be consistent.
1349 Avoid undefined behavior when strlen is zero.
1350
4195afc3
PE
1351 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1352 (NSTATICS): Now a constant; doesn't need to be a macro.
1353
a1aeeffe
RS
13542013-07-19 Richard Stallman <rms@gnu.org>
1355
1356 * coding.c (decode_coding_utf_8): Add simple loop for fast
1357 processing of ASCII characters.
1358
63b34baa
PE
13592013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1362
621dd9ac
EZ
13632013-07-19 Eli Zaretskii <eliz@gnu.org>
1364
1365 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1366 unportable 'struct x_display_info'.
1367 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1368 is a portable type.
1369
1396ac86
PE
13702013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1371
ab9980cd
PE
1372 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1373 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1374 or fscanf fails.
1375 (system_process_attributes): Prefer plain char to unsigned char
1376 when either will do. Clean up properly if interrupted or if
1377 memory allocations fail. Don't assume sscanf succeeds. Remove
1378 no-longer-needed workaround to stop GCC from whining. Read
1379 command-line once, instead of multiple times. Check read status a
1380 bit more carefully.
1381
1396ac86
PE
1382 Fix obscure porting bug with varargs functions.
1383 The code assumed that int is treated like ptrdiff_t in a vararg
1384 function, which is not a portable assumption. There was a similar
1385 -- though these days less likely -- porting problem with various
1386 assumptions that pointers of different types all smell the same as
1387 far as vararg functions is conserved. To make this problem less
1388 likely in the future, redo the API to use varargs functions.
1389 * alloc.c (make_save_value): Remove this vararg function.
1390 All uses changed to ...
1391 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1392 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1393 New functions.
1394 (make_save_ptr): Rename from make_save_pointer, for consistency with
1395 the above. Define only on platforms that need it. All uses changed.
1396
4d19d194
PE
13972013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1398
1399 * keyboard.c: Try to fix typos in previous change.
1400 (DISPLAY_LIST_INFO): New macro.
1401 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1402 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1403
945c5bb1
JB
14042013-07-18 Juanma Barranquero <lekktu@gmail.com>
1405
1406 * keyboard.c (kbd_buffer_get_event):
1407 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1408 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1409
f4b1eb36
PE
14102013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1411
5e679a2c
PE
1412 * filelock.c: Fix unlikely file descriptor leaks.
1413 (get_boot_time_1): Rework to avoid using emacs_open.
1414 This doesn't actually fix a leak, but is better anyway.
1415 (read_lock_data): Use read, not emacs_read.
1416
a8cd4836
PE
1417 * doc.c: Fix minor memory and file descriptor leaks.
1418 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1419 (get_doc_string, Fsnarf_documentation):
1420 Fix file descriptor leak on error.
1421
ef30e638
PE
1422 * term.c: Fix minor fdopen-related file descriptor leaks.
1423 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1424 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1425
f4b1eb36
PE
1426 * charset.c: Fix file descriptor leaks and errno issues.
1427 Include <errno.h>.
1428 (load_charset_map_from_file): Don't leak file descriptor on error.
1429 Use plain record_xmalloc since the allocation is larger than
1430 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1431 of entries.
1432 * eval.c (record_unwind_protect_nothing):
1433 * fileio.c (fclose_unwind):
1434 New functions.
1435 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1436 The replacement doesn't block input, but that no longer seems
1437 necessary.
1438
b648c163
PE
14392013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1440
a0931322
PE
1441 * lread.c: Fix file descriptor leaks and errno issues.
1442 (Fload): Close some races that leaked fds or streams when 'load'
1443 was interrupted.
1444 (Fload, openp): Report error number of last nontrivial failure to open.
1445 ENOENT counts as trivial.
1446 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1447 New functions.
1448 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1449 now that the function is always called with a nonnegative arg.
1450 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1451 All uses replaced with ...
1452 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1453
b648c163
PE
1454 A few more minor file errno-reporting bugs.
1455 * callproc.c (Fcall_process):
1456 * doc.c (Fsnarf_documentation):
1457 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1458 * process.c (set_socket_option):
1459 Don't let a constructor trash errno.
1460 * doc.c: Include <errno.h>.
1461
b1dc4084
JB
14622013-07-16 Juanma Barranquero <lekktu@gmail.com>
1463
1464 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1465
c43843aa
PE
14662013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1467
50a30cce
PE
1468 Fix w32 bug with call-process-region (Bug#14885).
1469 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1470 to Fcall_process when the input is empty. This simplifies the
1471 code a bit. It makes no difference on POSIXish platforms but
1472 apparently it fixes a bug on w32.
1473
44e18199 1474 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1475 * fileio.c (close_file_unwind): Don't close if FD is negative;
1476 this can happen when unwinding a zapped file descriptor.
1477 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1478 in case Emacs runs out of memory between the two unwind-protects.
1479 Don't trash errno when closing FD.
1480 Zap the FD in the specpdl when closing it, instead of deferring
1481 the removal of the unwind-protect; this fixes a bug where a child
1482 function unwinds the stack past us.
1483
27e498e6
PE
1484 New unwind-protect flavors to better type-check C callbacks.
1485 This also lessens the need to write wrappers for callbacks,
1486 and the need for make_save_pointer.
1487 * alloca.c (free_save_value):
1488 * atimer.c (run_all_atimers):
1489 Now extern.
1490 * alloc.c (safe_alloca_unwind):
1491 * atimer.c (unwind_stop_other_atimers):
1492 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1493 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1494 * minibuf.c (choose_minibuf_frame_1):
1495 * process.c (make_serial_process_unwind):
1496 * xdisp.h (pop_message_unwind):
1497 * xselect.c (queue_selection_requests_unwind):
1498 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1499 * alloca.c (record_xmalloc):
1500 Prefer record_unwind_protect_ptr to record_unwind_protect with
1501 make_save_pointer.
1502 * alloca.c (Fgarbage_collect):
1503 Prefer record_unwind_protect_void to passing a dummy.
1504 * buffer.c (restore_buffer):
1505 * window.c (restore_window_configuration):
1506 * xfns.c, w32fns.c (do_unwind_create_frame)
1507 New wrapper. All record-unwind uses of wrappee changed.
1508 * buffer.c (set_buffer_if_live):
1509 * callproc.c (call_process_cleanup, delete_temp_file):
1510 * coding.c (code_conversion_restore):
1511 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1512 * editfns.c (save_excursion_restore)
1513 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1514 (save_restriction_restore):
1515 * eval.c (restore_stack_limits, un_autoload):
1516 * fns.c (require_unwind):
1517 * keyboard.c (recursive_edit_unwind, tracking_off):
1518 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1519 * macros.c (pop_kbd_macro, restore_menu_items):
1520 * nsfns.m (unwind_create_frame):
1521 * print.c (print_unwind):
1522 * process.c (start_process_unwind):
1523 * search.c (unwind_set_match_data):
1524 * window.c (select_window_norecord, select_frame_norecord):
1525 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1526 (fast_set_selected_frame):
1527 * xfns.c, w32fns.c (unwind_create_tip_frame):
1528 Return void, not a dummy Lisp_Object. All uses changed.
1529 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1530 * callproc.c (call_process_kill):
1531 * fileio.c (restore_point_unwind, decide_coding_unwind)
1532 (build_annotations_unwind):
1533 * insdel.c (Fcombine_after_change_execute_1):
1534 * keyboard.c (read_char_help_form_unwind):
1535 * menu.c (unuse_menu_items):
1536 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1537 * sound.c (sound_cleanup):
1538 * xdisp.c (unwind_redisplay):
1539 * xfns.c (clean_up_dialog):
1540 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1541 Accept no args and return void, instead of accepting and returning
1542 a dummy Lisp_Object. All uses changed.
1543 * cygw32.c (fchdir_unwind):
1544 * fileio.c (close_file_unwind):
1545 * keyboard.c (restore_kboard_configuration):
1546 * lread.c (readevalllop_1):
1547 * process.c (wait_reading_process_output_unwind):
1548 Accept int and return void, rather than accepting an Emacs integer
1549 and returning a dummy object. In some cases this fixes an
1550 unlikely bug when the corresponding int is outside Emacs integer
1551 range. All uses changed.
1552 * dired.c (directory_files_internal_unwind):
1553 * fileio.c (do_auto_save_unwind):
1554 * gtkutil.c (pop_down_dialog):
1555 * insdel.c (reset_var_on_error):
1556 * lread.c (load_unwind):
1557 * xfns.c (clean_up_file_dialog):
1558 * xmenu.c, nsmenu.m (pop_down_menu):
1559 * xmenu.c (cleanup_widget_value_tree):
1560 * xselect.c (wait_for_property_change_unwind):
1561 Accept pointer and return void, rather than accepting an Emacs
1562 save value encapsulating the pointer and returning a dummy object.
1563 All uses changed.
1564 * editfns.c (Fformat): Update the saved pointer directly via
1565 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1566 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1567 (unwind_body): New function.
1568 (record_unwind_protect): First arg is now a function returning void,
1569 not a dummy Lisp_Object.
1570 (record_unwind_protect_ptr, record_unwind_protect_int)
1571 (record_unwind_protect_void): New functions.
1572 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1573 * fileio.c (struct auto_save_unwind): New type.
1574 (do_auto_save_unwind): Use it.
1575 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1576 * insdel.c (struct rvoe_arg): New type.
1577 (reset_var_on_error): Use it.
1578 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1579 New constants.
1580 (specbinding_func): Remove; there are now several such functions.
1581 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1582 (set_unwind_protect_ptr): New function.
1583 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1584
4e604a5d
PE
1585 Be simpler and more consistent about reporting I/O errors.
1586 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1587 Say "Read error" and "Write error", rather than "I/O error", or
1588 "IO error reading", or "IO error writing", when a read or write
1589 error occurs.
1590 * process.c (Fmake_network_process, wait_reading_process_output)
1591 (send_process, Fprocess_send_eof, wait_reading_process_output):
1592 Capitalize diagnostics consistently. Put "failed foo" at the
1593 start of the diagnostic, so that we don't capitalize the
1594 function name "foo". Consistently say "failed" for such
1595 diagnostics.
1596 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1597 All callers changed. This is so it can use report_file_error.
1598 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1599 diagnostics consistently as above.
1600
a9757f6a
PE
1601 * fileio.c (report_file_errno): Fix errno reporting bug.
1602 If the file name is neither null nor a pair, package it up as a
1603 singleton list. All callers changed, both to this function and to
1604 report_file_error. This fixes a bug where the memory allocator
1605 invoked by list1 set errno so that the immediately following
1606 report_file_error reported the wrong errno value.
1607
c43843aa
PE
1608 Fix minor problems found by --enable-gcc-warnings.
1609 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1610 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1611
18c26d81
JD
16122013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1613
1614 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1615 Set event->arg to Qt if switch-event shall be generated.
1616 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1617
1618 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1619
1620 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1621 FOCUS_OUT_EVENT.
1622
1623 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1624 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1625 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1626 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1627 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1628 and there is a focused frame.
1629 (head_table): Add focus-in and focus-out.
1630 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1631 bind to handle-focus-in/out.
1632
1633 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1634 (Fhandle_switch_frame): Call Fhandle_focus_in.
1635 (syms_of_frame): defsubr handle-focus-in/out.
1636
6c6f1994
PE
16372013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1638
c7ddc792
PE
1639 Fix porting bug to older POSIXish platforms (Bug#14862).
1640 * sysdep.c (emacs_pipe): New function, that implements
1641 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1642 This should port better to CentOS 5 and to Mac OS X 10.6.
1643 All calls to pipe2 changed.
1644
6c6f1994
PE
1645 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1646 This makes the code easier to read and the executable a bit smaller.
1647 Do not replace all calls to Fcons that happen to create lists,
1648 just calls that are intended to create lists. For example, when
1649 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1650 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1651 Similarly for list2 through list5.
1652 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1653 * bytecode.c (exec_byte_code):
1654 * callint.c (quotify_arg, Fcall_interactively):
1655 * callproc.c (Fcall_process, create_temp_file):
1656 * charset.c (load_charset_map_from_file)
1657 (Fdefine_charset_internal, init_charset):
1658 * coding.c (get_translation_table, detect_coding_system)
1659 (Fcheck_coding_systems_region)
1660 (Fset_terminal_coding_system_internal)
1661 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1662 * composite.c (update_compositions, Ffind_composition_internal):
1663 * dired.c (directory_files_internal, file_name_completion)
1664 (Fsystem_users):
1665 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1666 * doc.c (Fsnarf_documentation):
1667 * editfns.c (Fmessage_box):
1668 * emacs.c (main):
1669 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1670 (Feval, eval_sub, Ffuncall, apply_lambda):
1671 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1672 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1673 (Fset_file_times, Finsert_file_contents)
1674 (Fchoose_write_coding_system, Fwrite_region):
1675 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1676 * font.c (font_registry_charsets, font_parse_fcname)
1677 (font_prepare_cache, font_update_drivers, Flist_fonts):
1678 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1679 * frame.c (make_frame, Fmake_terminal_frame)
1680 (x_set_frame_parameters, x_report_frame_params)
1681 (x_default_parameter, Fx_parse_geometry):
1682 * ftfont.c (syms_of_ftfont):
1683 * image.c (gif_load):
1684 * keyboard.c (command_loop_1):
1685 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1686 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1687 (Fminor_mode_key_binding, accessible_keymaps_1)
1688 (Faccessible_keymaps, Fwhere_is_internal):
1689 * lread.c (read_emacs_mule_char):
1690 * menu.c (find_and_return_menu_selection):
1691 * minibuf.c (get_minibuffer):
1692 * nsfns.m (Fns_perform_service):
1693 * nsfont.m (ns_script_to_charset):
1694 * nsmenu.m (ns_popup_dialog):
1695 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1696 (Fx_own_selection_internal):
1697 * nsterm.m (append2):
1698 * print.c (Fredirect_debugging_output)
1699 (print_prune_string_charset):
1700 * process.c (Fdelete_process, Fprocess_contact)
1701 (Fformat_network_address, set_socket_option)
1702 (read_and_dispose_of_process_output, write_queue_push)
1703 (send_process, exec_sentinel):
1704 * sound.c (Fplay_sound_internal):
1705 * textprop.c (validate_plist, add_properties)
1706 (Fput_text_property, Fadd_face_text_property)
1707 (copy_text_properties, text_property_list, syms_of_textprop):
1708 * unexaix.c (report_error):
1709 * unexcoff.c (report_error):
1710 * unexsol.c (unexec):
1711 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1712 (Fformat_mode_line, syms_of_xdisp):
1713 * xfaces.c (set_font_frame_param)
1714 (Finternal_lisp_face_attribute_values)
1715 (Finternal_merge_in_global_face, syms_of_xfaces):
1716 * xfns.c (x_default_scroll_bar_color_parameter)
1717 (x_default_font_parameter, x_create_tip_frame):
1718 * xfont.c (xfont_supported_scripts):
1719 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1720 (menu_help_callback, xmenu_show):
1721 * xml.c (make_dom):
1722 * xterm.c (set_wm_state):
1723 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1724 and similarly for list2 through list5.
1725
bafe80ce
PE
17262013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * callproc.c (Fcall_process_region): Fix minor race and tune.
1729 (create_temp_file): New function, with the temp-file-creation part
1730 of the old Fcall_process_region. Use Fcopy_sequence to create the
1731 temp file name, rather than alloca + build_string, for simplicity.
1732 Don't bother to block input around the temp file creation;
1733 shouldn't be needed. Simplify use of mktemp. Use
1734 record_unwind_protect immediately after creating the temp file;
1735 this closes an unlikely race where the temp file was not removed.
1736 Use memcpy rather than an open-coded loop.
1737 (Fcall_process_region): Use the new function. If the input is
1738 empty, redirect from /dev/null rather than from a newly created
1739 empty temp file; this avoids unnecessary file system traffic.
1740
4700b5a5
PE
17412013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1742
5c97beae
PE
1743 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1744 Simplify by making this case like the other two. This is a bit
1745 slower on obsolete hosts, but the extra complexity isn't worth it.
1746
4700b5a5
PE
1747 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1748 * process.c (create_process) [!DOS_NT]:
1749 Remove now-unnecessary calls to emacs_close.
1750
f9a74c4c
EZ
17512013-07-13 Eli Zaretskii <eliz@gnu.org>
1752
922ae7ee
EZ
1753 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1754 returning early. (Bug#14850)
1755
f9a74c4c
EZ
1756 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1757 and inhibit-iso-escape-detection attributes of 'undecided'.
1758 (Bug#14822)
1759
5e301d76
PE
17602013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1761
69e0e5ee
PE
1762 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1763 Reported by Herbert J. Skuhra in
1764 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1765
5e301d76
PE
1766 Don't lose top specpdl entry when memory is exhausted.
1767 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1768 specpdl overflow here, to simplify callers; all callers changed.
1769 Always reserve an unused entry at the stack top; this avoids
1770 losing the top entry's information when memory is exhausted.
1771
7e649856
PE
17722013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1773
a773ed9a
PE
1774 Clean up errno reporting and fix some errno-reporting bugs.
1775 * callproc.c (Fcall_process):
1776 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1777 * process.c (create_process, Fmake_network_process):
1778 * unexaix.c (report_error):
1779 * unexcoff.c (report_error):
1780 Be more careful about reporting the errno of failed operations.
1781 The code previously reported the wrong errno sometimes.
1782 Also, prefer report_file_errno to setting errno + report_file_error.
1783 (Fcall_process): Look at openp return value rather than at path,
1784 as that's a bit faster and clearer when there's a numeric predicate.
1785 * fileio.c (report_file_errno): New function, with most of the
1786 old contents of report_file_error.
1787 (report_file_error): Use it.
1788 (Ffile_exists_p, Ffile_accessible_directory_p):
1789 Set errno to 0 when it is junk.
1790 * fileio.c (Faccess_file):
1791 * image.c (x_create_bitmap_from_file):
1792 Use faccessat rather than opening the file, to avoid the hassle of
1793 having a file descriptor open.
1794 * lisp.h (report_file_errno): New decl.
1795 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1796
7e649856
PE
1797 Minor EBADF fixes.
1798 * process.c (create_process, wait_reading_process_output) [AIX]:
1799 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1800 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1801 a multithreaded environment anyway).
1802 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1803
f6774c1a
AS
18042013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1805
1806 * image.c (x_find_image_file): Don't close a remote file handle.
1807
bacba3c2
PE
18082013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 Fix races with threads and file descriptors.
1811 * callproc.c (Fcall_process_region):
1812 * dired.c (open_directory):
1813 * emacs.c (main, Fdaemon_initialized):
1814 * image.c (x_find_image_file):
1815 * inotify.c (Finotify_rm_watch):
1816 * lread.c (Flocate_file_internal):
1817 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1818 * term.c (term_mouse_moveto, init_tty):
1819 * termcap.c (tgetent):
1820 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1821 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1822 * unexhp9k800.c, unexmacosx.c (unexec):
1823 * callproc.c (Fcall_process_region):
1824 Use emacs_close, not close.
1825 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1826 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1827 and posix_close function on current platforms (which all lack them).
1828 (emacs_close): Use it. This should fix the races on GNU/Linux and
1829 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1830 and it should avoid closing random victim file descriptors on
1831 other platforms.
1832
653d4f43
PE
18332013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1834
c8536ec4
PE
1835 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1836 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1837 Touch up doc a bit.
1838
9c203066
PE
1839 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1840 This is for .gdbinit xbacktrace.
1841
653d4f43
PE
1842 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1843 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1844 (emacs_set_tty): Now static.
1845 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1846 * term.c (tty_capable_p, tty_default_color_capabilities)
1847 (get_tty_terminal, term_mouse_movement)
1848 (handle_one_term_event, init_tty, maybe_fatal):
1849 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1850 (tgetent, scan_file, name_match, compare_contin):
1851 * terminal.c (get_terminal):
1852 Use bool for boolean.
1853 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1854 Prefer char to unsigned char if either will do.
1855 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1856 (tty_write_glyphs): Prefer int to unsigned.
1857 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1858 All callers changed.
1859 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1860
45b683a1
PE
18612013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1862
29abe551
PE
1863 Port to C89.
1864 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1865 (B__dummy__): New dummy symbol, to pacify C89.
1866 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1867 they can't grok varargs macros.
1868 * dispnew.c (add_window_display_history)
1869 (add_frame_display_history):
1870 * print.c (print_object):
1871 * xdisp.c (debug_method_add):
1872 Use %p printf format only for void pointers.
1873 * emacs.c (usage_message): New constant, replacing ...
1874 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1875 (main): Adjust to usage reorg.
1876 * fns.c (syms_of_fns):
1877 * profiler.c (syms_of_profiler):
1878 Don't use non-constant struct initializers.
1879 * gnutls.h (gnutls_initstage_t):
1880 * lisp.h (enum Lisp_Fwd_Type):
1881 * lread.c (lisp_file_lexically_bound_p):
1882 * xsettings.c (anonymous enum):
1883 Remove trailing comma.
1884 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1885 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1886 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1887 (DEFUN): Use it.
1888 * regex.c (const_re_char): New type, to pacify strict C89.
1889 All uses of 'const re_char' replaced to use it.
1890 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1891 with glibc when strict C89. This change is imported from gnulib.
1892 All uses changed.
1893 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1894 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1895 Omit GNU_LINUX implementation, since it requires long long.
1896 * xterm.c (x_draw_underwave):
1897 Do not assume the traditional order of struct's members.
1898 (x_term_init): Rewrite to avoid the need for non-constant structure
1899 initializers.
1900
45b683a1 1901 Syntax cleanup, mostly replacing macros with functions.
763a086d 1902 This removes the need for the syntax_temp hack.
45b683a1
PE
1903 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1904 * syntax.c (SYNTAX_INLINE): New macro.
1905 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1906 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1907 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1908 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1909 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1910 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1911 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1912 Now constants, not macros.
1913 (syntax_temp) [!__GNUC__]: Remove.
1914 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1915 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1916 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1917 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1918 Move here from syntax.h; now functions, not macros. Except for the
1919 last function, these are static since only syntax.c uses them.
1920 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1921 All uses changed. Now a function, not a macro; use this fact
1922 to simplify the code.
1923 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1924 compiler bugs; no longer relevant.
1925 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1926 (SYNTAX_INLINE): New macro.
1927 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1928 for the new functions. Use bool for boolean member.
1929 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1930 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1931 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1932 (SETUP_BUFFER_SYNTAX_TABLE):
1933 Now extern inline functions, not macros.
1934 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1935 Remove; all uses replaced by implementation.
1936 (syntax_temp) [!__GNUC__]: Remove decl.
1937 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1938
29be4a50
JD
19392013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1940
1941 * emacs.c (main): Fix syntax error.
1942
954b166e
PE
19432013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 Timestamp fixes for undo (Bug#14824).
1946 * atimer.c (schedule_atimer):
1947 * fileio.c (Ffile_newer_than_file_p):
1948 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1949 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1950 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1951 (syms_of_fileio): Remove Sclear_visited_file_name.
1952 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1953 file doesn't exist; this avoids an ambiguity with negative timestamps.
1954 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1955 * systime.h (make_emacs_time, invalid_emacs_time):
1956 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1957 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1958 * undo.c (record_first_change): Push (visited-file-modtime) onto
1959 undo list rather than reimplementing it by hand, incorrectly.
1960
d74647c3
KB
19612013-07-09 Ken Brown <kbrown@cornell.edu>
1962
1963 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1964
3c51b96b
JB
19652013-07-09 Juanma Barranquero <lekktu@gmail.com>
1966
1967 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1968
4ebbdd67
PE
19692013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1970
1971 Handle errno and exit status a bit more carefully.
1972 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1973 number into an exit status. Instead, use EXIT_CANCELED.
1974 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1975 * callproc.c (relocate_fd):
1976 * emacs.c (close_output_streams, main):
1977 * process.c (create_process):
1978 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1979 Use emacs_perror for simplicity.
1980 * callproc.c (relocate_fd, main):
1981 * sysdep.c (sys_subshell):
1982 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1983 (shut_down_emacs): Use emacs_write, not write.
1984 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1985 * fileio.c (Fcopy_file, e_write):
1986 * nsterm.m (ns_select):
1987 * process.c (send_process):
1988 * sound.c (vox_write):
1989 Use emacs_write_sig, not emacs_write.
1990 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1991 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1992 New constants.
1993 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1994 of write.
1995 (emacs_full_write): New function.
1996 (emacs_write): Rewrite to use it.
1997 (emacswrite_sig, emacs_perror): New functions.
1998 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1999
44e18199 20002013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2001
2002 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2003 on NS even if it is present. Pixmap on NS is a void*.
2004
9caab067
PE
20052013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2006
2007 Port to Ubuntu 10 (Bug#14803).
2008 Problem reported by T.V. Raman.
2009 * process.c (close_on_exec, accept4, process_socket):
2010 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2011
1d442672
EZ
20122013-07-07 Eli Zaretskii <eliz@gnu.org>
2013
2014 * w32.c (sys_dup): Declare prototype.
2015
2016 * filelock.c:
2017 * emacs.c:
2018 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2019
067428c1
PE
20202013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 Make file descriptors close-on-exec when possible (Bug#14803).
2023 This simplifies Emacs a bit, since it no longer needs to worry
2024 about closing file descriptors by hand in some cases.
2025 It also fixes some unlikely races. Not all such races, as
2026 libraries often open files internally without setting
2027 close-on-exec, but it's an improvement.
2028 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2029 * callproc.c (Fcall_process) [!MSDOS]:
2030 * emacs.c (main) [!DOS_NT]:
2031 * nsterm.m (ns_term_init):
2032 * process.c (create_process):
2033 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2034 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2035 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2036 Prefer mkostemp with O_CLOEXEC to mkstemp.
2037 * callproc.c (relocate_fd) [!WINDOWSNT]:
2038 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2039 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2040 now using pipe2.
2041 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2042 Make the resulting file descriptor close-on-exec.
2043 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2044 * lread.c (load_descriptor_list, load_descriptor_unwind):
2045 Remove; no longer needed. All uses removed.
2046 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2047 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2048 New functions.
2049 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2050 (Fmake_network_process, Fnetwork_interface_list):
2051 (Fnetwork_interface_info, server_accept_connection):
2052 Make newly-created socket close-on-exec.
2053 * sysdep.c (emacs_open, emacs_fopen):
2054 Make new-created descriptor close-on-exec.
2055 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2056 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2057
0da857dd
JD
20582013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2059
2060 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2061 for NS_IMPL_GNUSTEP.
2062
5f86adcd
PE
20632013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 Fix openp errno handling.
2066 * callproc.c (Fcall_process): Preserve openp errno around close.
2067 * lread.c (openp): Set errno when returning -1, as some callers
2068 expect this.
2069
1afb1d07
JD
20702013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2071
2072 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2073
2074 * nsterm.h (NSSavePanel): Update comment.
2075 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2076 (ns_run_file_dialog): Declare.
2077
2078 * nsfns.m: Remove panelOK.
2079 (ns_fd_data): New.
2080 (ns_run_file_dialog): New function.
2081 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2082 event loop, so file dialog is popped up by ns_run_file_dialog, called
2083 by sendEvent (Bug#14578).
2084 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2085
3323c263
EZ
20862013-07-06 Eli Zaretskii <eliz@gnu.org>
2087
fdda0220
EZ
2088 * xdisp.c (default_line_pixel_height): New function.
2089 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2090 (try_cursor_movement, redisplay_window, try_window)
2091 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2092
2093 * window.c (window_scroll_pixel_based): use
2094 default_line_pixel_height.
2095
2096 * dispextern.h (default_line_pixel_height): Add prototype.
2097
2098 * frame.c (x_set_line_spacing): Accept a float value for
2099 line-spacing parameter, per the documentation.
2100
3323c263
EZ
2101 * data.c (Fmultibyte_string_p): Doc fix.
2102
47ba6d43
PE
21032013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2104
406af475
PE
2105 Use emacs_open more consistently when opening files.
2106 This handles EINTR more consistently now, and makes it easier
2107 to introduce other uniform changes to file descriptor handling.
2108 * src/systdio.h: New file.
2109 * src/buffer.c (mmap_init):
2110 * cygw32.c (chdir_to_default_directory):
2111 * dispnew.c (Fopen_termscript):
2112 * emacs.c (Fdaemon_initialized):
2113 * fileio.c (Fdo_auto_save):
2114 * image.c (slurp_file, png_load_body, jpeg_load_body):
2115 * keyboard.c (Fopen_dribble_file):
2116 * lread.c (Fload):
2117 * print.c (Fredirect_debugging_output):
2118 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2119 * termcap.c (tgetent):
2120 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2121 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2122 * w32term.c (w32_initialize) [CYGWIN]:
2123 * xfaces.c (Fx_load_color_file):
2124 Use emacs_open instead of plain open, and emacs_fopen instead of
2125 plain fopen.
2126 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2127 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2128 * callproc.c (default_output_mode): New constant.
2129 (Fcall_process): Use it to call emacs_open instead of plain creat.
2130 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2131 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2132 (emacs_fopen): New function.
2133 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2134 Include <lisp.h>, for emacs_open.
2135 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2136
47ba6d43
PE
2137 Remove duplicate #include directives.
2138 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2139 * xfaces.c:
2140 Don't include stdio.h twice.
2141 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2142 Don't include sys/types.h or stdio.h twice.
2143 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2144 * lread.c: Don't include coding.h twice.
2145 * nsfont.m: Don't include frame.h twice.
2146 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2147 * ralloc.c: Don't include <unistd.h> twice.
2148 * xdisp.c: Don't include font.h twice.
2149 * xterm.c: Don't include fontset.h twice.
2150 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2151
b9ed53d5
PE
21522013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2153
2154 Scale ImageMagick images more carefully.
2155 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2156 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2157 Be more careful about avoiding undefined behavior after
2158 integer overflow and division by zero.
2159
cf13177e
YM
21602013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2161
2162 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2163 (syms_of_w32fns): DEFSYM them.
2164 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2165 (CCHDEVICENAME): Define macros if not defined.
2166 (struct MONITOR_INFO_EX): New struct.
2167 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2168 (enum_display_monitors_fn): New variable.
2169 (globals_of_w32fns): Initialize it.
2170 (Fx_display_pixel_width, Fx_display_pixel_height)
2171 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2172 multi-monitor setups in docstrings.
2173 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2174 screen size by primary monitor's millimeter per pixel.
2175 (w32_monitor_enum, w32_display_monitor_attributes_list)
2176 (w32_display_monitor_attributes_list_fallback)
2177 (Fw32_display_monitor_attributes_list): New functions.
2178 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2179
2180 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2181 if not defined.
2182 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2183
86dfb7a8
MA
21842013-07-04 Michael Albinus <michael.albinus@gmx.de>
2185
2186 * fileio.c (Qfile_notify_error): New error symbol.
2187
2188 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2189 * inotify.c (inotify_callback, symbol_to_inotifymask)
2190 (Finotify_add_watch, Finotify_rm_watch): Use it.
2191 (inotifyevent_to_event): Exchange order of cookie and file name.
2192 (Finotify_add_watch): Adapt docstring.
2193
2194 * lisp.h (Qfile_notify_error): Declare.
2195
2c1c974b
PE
21962013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2197
2198 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2199 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2200 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2201 which did not work (see <http://bugs.gnu.org/14569#307>).
2202 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2203 && (!noninteractive || initialized)). This attempts to thread
2204 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2205
7a35b20f
JB
22062013-07-04 Juanma Barranquero <lekktu@gmail.com>
2207
2208 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2209 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2210
1ce5cd04
PE
22112013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2214 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2215 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2216 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2217
57f8c490
PE
22182013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2221 Define to __sys_siglist.
2222
bcffb5ca
EZ
22232013-07-02 Eli Zaretskii <eliz@gnu.org>
2224
2225 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2226 word-wrap, so that overflow-newline-into-fringe would work in
2227 visual-line-mode. (Bug#2749)
2228 (move_it_in_display_line_to): When the last scanned display
2229 element fits exactly on the display line, and
2230 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2231 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2232 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2233 finding buffer position that corresponds to pixel coordinates,
2234 e.g. in buffer_posn_from_coords.
2235
2c41e781
JD
22362013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2237
2238 * process.c (handle_child_signal): Call catch_child_signal if
2239 NS_IMPL_GNUSTEP.
2240
c2418359
PE
22412013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2242
52a9bcae
PE
2243 Don't convert function pointers to void * and back.
2244 It isn't portable C, and it's easy enough to avoid.
2245 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2246 (make_save_value): Add support for SAVE_FUNCPOINTER.
2247 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2248 * print.c (print_object):
2249 Distinguish function from object pointers.
2250 * lisp.h (SAVE_FUNCPOINTER): New constant.
2251 (SAVE_SLOT_BITS): Adjust to it.
2252 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2253 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2254 (voidfuncptr): New typedef.
2255 (struct Lisp_Save_Value): New member data[0].funcpointer.
2256 (XSAVE_FUNCPOINTER): New function.
2257
c2418359
PE
2258 Simplify buildobj processing.
2259 * Makefile.in (buildobj.h): Make it a sequence of strings each
2260 followed by comma, rather than a single string. Put it into a
2261 .tmp file in case there's an error while generating it.
2262 (gl-stamp): Use .tmp for temp files.
2263 (mostlyclean): Clean .tmp files.
2264 * doc.c (buildobj): Move to just the routine that needs it.
2265 It's now an array of strings, so processing is simpler.
2266
8f43ce49
PE
22672013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2270 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2271 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2272 Invoke malloc_enable_thread even when not interactive.
2273 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2274 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2275 in this case, since the underlying bug has now been fixed.
2276
24827db9
JB
22772013-07-01 Juanma Barranquero <lekktu@gmail.com>
2278
2279 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2280 unlinking it (bug#14691).
2281
ef099a94
MN
22822013-06-30 Michal Nazarewicz <mina86@mina86.com>
2283
2284 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2285 before checking whether buffer is modified. This lets
2286 `kill-buffer-query-functions' cancel killing of the buffer or save
2287 its content before `kill-buffer' asks user the "Buffer %s
2288 modified; kill anyway?" question.
2289
9d3f2fc2
JD
22902013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2291
2292 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2293 Let the super performKeyEquivalent deal with them (Bug#14747).
2294
e6c6c8c7
PE
22952013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2296
1d71c1d9
PE
2297 * widget.c (resize_cb): Remove unused local.
2298
8f5f35cc
PE
2299 Do not use GTK 3 if it exists but cannot be compiled.
2300 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2301 * xterm.c (x_error_handler) [!USE_GTK]:
2302 Do not use GTK 3.
2303
e6c6c8c7
PE
2304 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2305
0ba54312
EZ
23062013-06-30 Eli Zaretskii <eliz@gnu.org>
2307
5d1c3286
EZ
2308 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2309 to the valid range of values. (Bug#14753)
2310
0ba54312
EZ
2311 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2312 when moving point by using the current glyph matrix. This avoids
2313 the need to force redisplay when this function is called in a
2314 loop.
2315
9c90cc06
PE
23162013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 Fix minor problems found by static checking.
2319 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2320 Redo the latter's body to sidestep GCC parenthesization warnings.
2321 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2322 * coding.c (detect_coding, detect_coding_system):
2323 * coding.h (struct undecided_spec):
2324 Use bool for boolean.
2325 * image.c (QCmax_width, QCmax_height): Now static.
2326 * xdisp.c (Fmove_point_visually): Remove unused local.
2327
4c672a0f
EZ
23282013-06-29 Eli Zaretskii <eliz@gnu.org>
2329
2330 * xdisp.c (Fmove_point_visually): New function.
2331
c1ea3abf
JB
23322013-06-28 Kenichi Handa <handa@gnu.org>
2333
2334 * coding.h (define_coding_undecided_arg_index): New enum.
2335 (coding_attr_index): New members
2336 coding_attr_undecided_inhibit_null_byte_detection,
2337 coding_attr_undecided_inhibit_iso_escape_detection,
2338 coding_attr_undecided_prefer_utf_8.
2339 (undecided_spec): New struct.
2340 (struct coding_system): New member `undecided' of the member
2341 `spec'.
2342
2343 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2344 (detect_coding): Likewise.
2345 (detect_coding_system): Likewise.
2346 (Fdefine_coding_system_internal): New coding system properties
2347 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2348 :prefer-utf-8.
2349 (syms_of_coding): Adjust for coding_arg_undecided_max.
2350
ba3de9e6
PE
23512013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * image.c (x_from_xcolors): Remove unused local.
2354
547c9269
YM
23552013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2356
2357 Defer image data transfer between X client and server until actual
2358 display happens.
2359
2360 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2361 and `mask_img'.
2362
2363 * image.c (Destroy_Image): Remove.
2364 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2365 `mask_p', and `colors_p'. All uses changed.
2366 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2367 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2368 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2369 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2370 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2371 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2372 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2373 (image_get_x_image, image_unget_x_image): New functions or macros.
2374 (image_background, image_background_transparent, x_to_xcolors)
2375 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2376 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2377 instead of Destroy_Image.
2378 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2379 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2380 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2381 (imagemagick_load_image, svg_load_image): Use them instead of
2382 x_create_x_image_and_pixmap, and x_put_x_image followed by
2383 x_destroy_x_image, respectively.
2384 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2385 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2386 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2387 background_transparent fields.
2388 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2389 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2390
dae2f5ef
PE
23912013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2394 This mostly consists of undoing recent changes.
2395 * callproc.c (Fcall_process):
2396 * process.c (create_process):
2397 Do not worry about catching SIGCHLD here, undoing previous change.
2398 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2399 * process.c, process.h (catch_child_signal):
2400 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2401 * process.c (catch_child_handler): Don't worry about being called
2402 lazily and do not assume caller has blocked SIGCHLD, undoing
2403 previous change. Move first-time stuff back to
2404 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2405 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2406 set lib_child_handler if it's already initialized, which may
2407 help avoid problems on GNUStep.
2408
fa55d2aa
PE
24092013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2410
2411 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2412 * callproc.c (Fcall_process):
2413 * process.c (create_process):
2414 Make sure SIGCHLD is caught before we fork,
2415 since Emacs startup no arranges to catch SIGCHLD.
2416 * process.c (lib_child_handler): Initialize to null, not to
2417 dummy_handler.
2418 (catch_child_signal): Allow self to be called lazily.
2419 Do nothing if it's already been called.
2420 Assume caller has blocked SIGCHLD (all callers do now).
2421 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2422 just before it's really needed.
2423 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2424 since it hasn't been caught yet.
2425
f3f9606c
LMI
24262013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2427
2428 * image.c (compute_image_size): New function to implement
2429 :max-width and :max-height.
2430 (imagemagick_load_image): Use it.
2431
c7041908
PE
24322013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2435 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2436 Now extern.
2437 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2438 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2439 the SIGCHLD handler, since the code is not atomic and (due to glib)
2440 signals may be arriving now.
2441 * sysdep.c (init_signals): Do not catch child signals here;
2442 'main' now does that later, at a safer time.
2443
f86852b4
PE
24442013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2445
0dfeed58
PE
2446 Clean up SIGCHLD handling a bit (Bug#14569).
2447 * process.c, process.h (catch_child_signal):
2448 Now always extern, even if !NS_IMPL_GNUSTEP.
2449 * process.c (catch_child_signal): Move glib tickler here from
2450 init_process_emacs, so that it's done earlier in Emacs
2451 initialization. Also move the noninteractive && !initialized
2452 check here from init_process_emacs. This is all a bit cleaner for
2453 GNUish platforms, and I hope it works around the Cygwin bug.
2454 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2455 that glib signal handling is tickled before glib creates threads.
2456
f86852b4
PE
2457 * process.c (wait_reading_process_output): Avoid int overflow
2458 when reading more than 2 GiB total from a process.
2459
cbd6509c
PE
24602013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 * process.c (create_process): Handle a couple more cases,
2463 i.e., work even if new_argv and wait_child_setup[i] are cached.
2464 Use Fcall_process's style for volatile vars.
2465
9de1114a
AS
24662013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2467
2468 * process.c (create_process): Mark PROCESS volatile.
2469
fbe9e0b9
PE
24702013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 Use C99-style flexible array members if available.
2473 This avoids some subtle aliasing issues, which typically
2474 aren't a problem with GCC but may be a problem elsewhere.
2475 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2476 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2477 In either case, it uses a flexible array member rather than
2478 the old struct hack. All uses changed.
2479 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2480 Adjust to sdata reorganization.
2481 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2482 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2483 that ports better to pre-C99 non-GCC.
2484 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2485 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2486 as the latter has changed.
2487 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2488 and port better to pre-C99 GCC.
2489 * image.c (struct xpm_cached_color):
2490 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2491 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2492 Use FLEXIBLE_ARRAY_MEMBER.
2493 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2494 Move decl to top level so it gets checked against implementation.
2495 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2496 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2497
1fc71008
PE
24982013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 * syntax.c: Integer cleanups.
2501 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2502 All uses that need 0-or-2 changed to:
2503 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2504 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2505 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2506 (char_quoted, prev_char_comend_first, back_comment)
2507 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2508 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2509 Use bool for boolean.
2510 (update_syntax_table, skip_chars, skip_syntaxes):
2511 Prefer int to unsigned when either will do.
2512 (back_comment): Return boolean success flag, like forw_comment,
2513 instead of positive-or-minus-1 (which might have overflowed int anyway).
2514 Don't stuff ptrdiff_t into int.
2515 (syntax_spec_code, syntax_code_spec): Now const.
2516 (Fmatching_paren, scan_lists, scan_sexps_forward):
2517 Use enum syntaxcode for syntax code.
2518 (Fmatching_paren): Check that arg is a character, not just an integer.
2519 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2520 (Finternal_describe_syntax_value): Omit no-longer-needed
2521 comparison to 0.
2522 (skip_chars): Use char, not unsigned char, when the distinction
2523 doesn't matter.
2524 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2525 * bytecode.c (exec_byte_code):
2526 * syntax.c (syntax_spec_code, Fchar_syntax)
2527 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2528 (init_syntax_once):
2529 * syntax.h (SYNTAX_WITH_FLAGS):
2530 Omit unnecessary casts.
2531
b932cad7
EZ
25322013-06-20 Eli Zaretskii <eliz@gnu.org>
2533
2534 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2535 line dimensions here, to avoid race conditions with the main
2536 thread. (Bug#14062, bug#14630, bug#14669)
2537
2538 * w32term.c (w32_draw_window_cursor): Compute the header line and
2539 mode line dimensions here.
2540 <w32_system_caret_window, w32_system_caret_hdr_height>:
2541 <w32_system_caret_mode_height>: New variables.
2542
2543 * w32term.h: Declare them.
2544
89561f72
PE
25452013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2546
5013fc08
PE
2547 * alloc.c (die): Move "assertion failed" string here ...
2548 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2549 COND when SUPPRESS_CHECKING. This shrinks the executable text
2550 size by 0.8% to 2.2% when configured with --enable-checking,
2551 depending on optimization flags (GCC 4.8.1 x86-64).
2552
89561f72
PE
2553 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2554
763a086d 25552013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2556
2557 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2558 base is 2; this is more accurate.
2559
983aeb9a
JB
25602013-06-19 Juanma Barranquero <lekktu@gmail.com>
2561
2562 * sound.c (string_default): Move to !WINDOWSNT section.
2563 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2564
178ba3e6
PE
25652013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2566
bbc51b15
PE
2567 * sound.c: Integer cleanups.
2568 Remove unnecessary forward decls.
2569 (struct sound_device): The 'file' member is now a Lisp_Object, not
2570 a char *, so that we needn't invoke alloca on a huge size.
2571 (Fplay_sound_internal): Adjust to this.
2572 (string_default): New function.
2573 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2574 Use it to adjust to the struct sound_device change.
2575 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2576 (be2hs) [0]: Remove.
2577
178ba3e6
PE
2578 * syntax.c (skip_chars): Don't use uninitialized storage
2579 when searching a multibyte buffer for characters that are not in a
2580 unibyte string that contains non-ASCII characters.
2581
69f60cdc
JD
25822013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2583
2584 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2585 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2586
0d6224d4
PE
25872013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2590
3c542890
KH
25912013-06-18 Kenichi Handa <handa@gnu.org>
2592
f7e3f7cd
KH
2593 * font.c (Ffont_spec): Signal an error for an invalid font name
2594 (Bug#14648).
3c542890 2595
9349e5f7
PE
25962013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2597
2598 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2599 In particular this ports to 32-bit sparc Sun cc.
2600 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2601 array with a dummy element at specpdl[-1], so that its address can
2602 be taken portably.
2603 (unbind_to): Do not copy the binding; not needed, now that we
2604 copy old_value in the one place where the copy is needed.
2605 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2606 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2607 (union specbinding): Rename from struct specbinding. Redo layout
2608 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2609 which is not portable. With Sun C 5.12 32-bit sparc, the
2610 declaration causes nargs to be an unsigned bitfield, a behavior
2611 that the C standard allows; but Emacs wants nargs to be signed.
2612 The overall type is now a union of structures rather than a
2613 structure of union of structures, and the 'kind' member is now a
2614 bitfield, so that the overall type doesn't grow. All uses changed.
2615 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2616
0a4df6a5
PE
26172013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2618
ec6ecaad
PE
2619 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2620 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2621
0a4df6a5
PE
2622 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2623
7bfe8dbc
EZ
26242013-06-17 Eli Zaretskii <eliz@gnu.org>
2625
2626 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2627 unless we know that the window w's frame is a frame object.
2628 Another attempt at solving bug#14062 and bug#14630.
2629
708e05f6
LMI
26302013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2631
2632 * textprop.c (property_set_type): New enum.
2633 (add_properties): Allow appending/prepending text properties.
2634 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2635 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2636 add_text_properties_1.
2637 (Fadd_face_text_property): New function that calls
2638 add_text_properties_1.
2639
84575e67
PE
26402013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 Move functions from lisp.h to individual modules when possible.
2643 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2644 * alloc.c (XFLOAT_INIT, set_symbol_name):
2645 * buffer.c (CHECK_OVERLAY):
2646 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2647 (set_char_table_parent):
2648 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2649 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2650 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2651 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2652 (set_blv_valcell):
2653 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2654 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2655 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2656 (backtrace_args, backtrace_debug_on_exit):
2657 * floatfns.c (CHECK_FLOAT):
2658 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2659 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2660 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2661 (set_hash_index_slot):
2662 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2663 * marker.c (CHECK_MARKER):
2664 * textprop.c (CHECK_STRING_OR_BUFFER):
2665 * window.c (CHECK_WINDOW_CONFIGURATION):
2666 Move here from lisp.h, and make these functions static rather than
2667 extern inline.
2668 * buffer.c (Qoverlayp):
2669 * data.c (Qsubrp):
2670 * fns.c (Qhash_table_p):
2671 * window.c (Qwindow_configuration_p):
2672 Now static.
2673 * lisp.h: Remove the abovementioned defns and decls.
2674
44e18199 2675 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2676 In lisp.h, prefer functions to function-like macros, and
2677 constants to object-like macros, when either will do. This:
2678 . simplifies use, as there's no more need to worry about
2679 arguments' side effects being evaluated multiple times.
2680 . makes the code easier to debug on some platforms.
2681 However, when using gcc -O0, keep using function-like macros
2682 for a few critical operations, for performance reasons.
2683 This sort of thing isn't needed with gcc -Og, but -Og
2684 is a GCC 4.8 feature and isn't widely-enough available yet.
2685 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2686 Remove enum lsb_bits; no longer needed.
2687 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2688 * buffer.c (Qoverlap):
2689 * data.c (Qsubrp):
2690 * fns.c (Qhash_table_p):
2691 Now extern, so lisp.h can use these symbols.
2692 * dispextern.h: Include character.h, for MAX_CHAR etc.
2693 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2694 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2695 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2696 (GLYPH_CODE_P): Move here from lisp.h.
2697 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2698 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2699 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2700 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2701 XUNTAG now returns void *.
2702 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2703 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2704 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2705 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2706 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2707 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2708 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2709 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2710 New macros, renamed from their sans-lisp_h_ counterparts.
2711 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2712 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2713 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2714 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2715 If compiling via GCC without optimization, define these as macros
2716 in addition to inline functions.
2717 To disable this, compile with -DINLINING=0.
2718 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2719 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2720 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2721 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2722 (INTMASK, VALMASK): Now macros, since static values cannot be
2723 accessed from extern inline functions.
2724 (VALMASK): Also a constant, for benefit of old GDB.
2725 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2726 is INTEGERP, which can fold it in.
5165d44a 2727 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2728 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2729 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2730 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2731 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2732 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2733 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2734 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2735 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2736 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2737 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2738 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2739 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2740 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2741 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2742 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2743 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2744 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2745 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2746 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2747 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2748 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2749 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2750 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2751 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2752 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2753 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2754 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2755 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2756 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2757 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2758 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2759 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2760 Now functions.
2761 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2762 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2763 (VALMASK): Define in one place rather than in two, merging the
2764 USE_LSB_TAG parts; this is simpler.
2765 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2766 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2767 Move up, to avoid use before definition.
2768 Also include "globals.h" earlier, for the same reason.
2769 (make_natnum): New function.
2770 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2771 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2772 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2773 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2774 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2775 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2776 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2777 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2778 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2779 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2780 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2781 (Qwindow_configuration_p, Qimage): New forward declarations.
2782 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2783 (STRING_COPYIN): Remove; unused.
2784 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2785 (xcar_addr, xcdr_addr): New functions. All uses changed.
2786 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2787 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2788 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2789 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2790 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2791 (TYPE_RANGED_INTEGERP): Simplify.
2792 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2793 (setlocale, fixup_locale, synchronize_system_messages_locale)
2794 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2795 Now empty functions, not macros.
2796 (functionp): Return bool, not int.
2797 * window.c (Qwindow_configuration_p): Now extern,
2798 so window.h can use it.
2799 * window.h (Qwindowp): Move decl back to lisp.h.
2800
9583ec36
EZ
28012013-06-15 Eli Zaretskii <eliz@gnu.org>
2802
2803 * xdisp.c (Fline_pixel_height): New function, required for solving
2804 bug #14567.
2805
210272ce
PE
28062013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2807
2808 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2809
de0503df
SM
28102013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2811
2812 * lread.c (syms_of_lread):
2813 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2814
afbfe143
KD
28152013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2816
2817 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2818
d177e213
XF
28192013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2820
2821 * fileio.c (expand_file_name): Doc fix.
2822
05e3e412
PE
28232013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2824
f7394b12
PE
2825 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2826 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2827 Wait for self, not for 0. This can't hurt on GNU or similar
2828 system, and may help with Cygwin.
2829
05e3e412
PE
2830 * keyboard.c: Don't use PROP (...) as an lvalue.
2831 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2832 Use set_prop (A, B), not PROP (A) = B.
2833
17dd3097
EZ
28342013-06-10 Eli Zaretskii <eliz@gnu.org>
2835
2836 * xdisp.c (get_it_property): Use it->window instead of generating
2837 a Lisp object from it->w.
2838
52fab9c9
EZ
28392013-06-09 Eli Zaretskii <eliz@gnu.org>
2840
2841 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2842 get-char-property the window that is being rendered, instead of
2843 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2844 (compute_display_string_pos): When W is NULL, use the current
2845 buffer as the object to pass to get-char-property.
2846 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2847 pointer member of the bidi iterator, since no window is pertinent
2848 to this function.
52fab9c9 2849
5bf97bfc
EZ
28502013-06-08 Eli Zaretskii <eliz@gnu.org>
2851
2852 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2853 being displayed, and pass it to compute_display_string_pos.
2854 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2855 (bidi_paragraph_init): All callers changed.
2856
2857 * xdisp.c (init_from_display_pos, init_iterator)
2858 (handle_single_display_spec, next_overlay_string)
2859 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2860 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2861 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2862 (compute_display_string_pos): Accept additional argument, the
2863 window being displayed, and pass it to Fget_char_property.
2864 (Bug#14575)
2865
2866 * dispextern.h (struct bidi_it): New member w, the window being
2867 displayed.
2868 (compute_display_string_pos): Adjust prototype.
2869
5de0e011
JD
28702013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2871
e7b41c4c 2872 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2873
2874 * process.c (wait_reading_process_output): Check for NS before GLIB.
2875 GLIB may be linked in due to rsvg, but ns_select must be called.
2876
5de0e011
JD
2877 * xgselect.c (xg_select): Remove call to window_system_available
2878 and g_main_context_pending at the top, so Gdk events (i.e. file
2879 notify) are processed when Emacs is started with -nw.
2880
a822acff
EZ
28812013-06-07 Eli Zaretskii <eliz@gnu.org>
2882
2883 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2884 (ctagsfiles3): New variable, includes only *.m files.
2885 (TAGS): Use an explicit language name in the regular expressions,
2886 to avoid transformation of '/SOMETHING' by MSYS to
2887 'c:\MSYS\SOMETHING'.
2888
6c0a9ed1
RC
28892013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2890
2891 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2892
9ef6111b
EZ
28932013-06-06 Eli Zaretskii <eliz@gnu.org>
2894
2895 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2896 still need to set the mouse pointer shape and activate help-echo.
2897 (Bug#14558)
2898
7d300d64
PE
28992013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2900
2901 A few porting etc. fixes for the new file monitor code.
2902 See the thread containing
2903 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2904 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2905 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2906 (dir_monitor_callback, Fgfile_rm_watch):
2907 Use assq_no_quit instead of Fassoc, for speed.
2908 (dir_monitor_callback, Fgfile_rm_watch):
2909 eassert that the monitor is a fixnum.
2910 (dir_monitor_callback): No need for CDR_SAFE.
2911 Simplify building of lisp with alternative tails.
2912 (Fgfile_add_watch, Fgfile_rm_watch):
2913 Do not assume glib functions set errno reliably on failure.
2914 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2915 and signal an error otherwise.
2916 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2917 Use Fdelq instead of Fdelete, for speed.
2918
817ebfcf
EZ
29192013-06-05 Eli Zaretskii <eliz@gnu.org>
2920
2921 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2922 don't insist on being invoked on a highlighted tool-bar button.
2923 Avoids losing tool-bar functionality when mouse-highlight is nil.
2924 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2925 Don't highlight when mouse-highlight is nil.
2926 (note_mouse_highlight): When mouse-highlight is nil, don't return
2927 right away; instead, run tool-bar and mode-line highlight
2928 subroutine, clear any existing highlight, and revert the mouse
2929 pointer to its default shape. (Bug#14558)
2930
55577e7c
SM
29312013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2932
2933 * lisp.mk (lisp): Add prog-mode.el.
2934
f019a684
PE
29352013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2938 * process.c (dummy_handler): New function.
2939 (lib_child_handler): New static var.
2940 (handle_child_signal): Invoke it.
2941 (catch_child_signal): If a library has set up a signal handler,
2942 save it into lib_child_handler.
2943 (init_process_emacs): If using glib and not on Windows, tickle glib's
2944 child-handling code so that it initializes its private SIGCHLD handler.
2945 * syssignal.h (SA_SIGINFO): Default to 0.
2946 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2947 31; it should no longer be needed now.
2948
90db8702
MA
29492013-06-05 Michael Albinus <michael.albinus@gmx.de>
2950
2951 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2952
2953 * gfilenotify.c (globals_of_gfilenotify): New function.
2954 (syms_of_gfilenotify): Move global initialization there.
2955
2956 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2957
bfa3acd6
SM
29582013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2959
2960 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2961 * keyboard.c (menu_bar_items, tool_bar_items):
2962 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2963 not override local keymaps any more.
2964
ba59bd80
EZ
29652013-06-04 Eli Zaretskii <eliz@gnu.org>
2966
2967 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2968
7f203aa1
EZ
29692013-06-03 Eli Zaretskii <eliz@gnu.org>
2970
9337e206
EZ
2971 * w32console.c (initialize_w32_display): Return the dimensions of
2972 the console window via 2 additional arguments, not via the current
2973 frame. This avoids crashes due to overrunning the bounds of
2974 frame's decode_mode_spec_buffer, which is not resized following
2975 the change of the frame dimensions from the initial 10x10.
2976
2977 * w32term.h (w32_initialize_display_info): Adjust prototype.
2978
2979 * term.c (init_tty): Take dimensions of the frame from the values
2980 returned by initialize_w32_display.
2981
7f203aa1
EZ
2982 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2983 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2984 (LIBES): Add $(GFILENOTIFY_LIBS).
2985
2986 * w32inevt.c (handle_file_notifications): Add dummy implementation
2987 for !HAVE_W32NOTIFY.
2988
2989 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2990
55a87246
JD
29912013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2992
2993 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2994
2995 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2996
2997 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2998
3d5ee10a
PE
29992013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 Fix minor problems found by static checking.
3002 * data.c (pure_write_error):
3003 Use xsignal2, not Fsignal, as Fsignal might return.
3004 * eval.c (set_backtrace_debug_on_exit): Now static.
3005 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3006 No longer inline. EXTERN_INLINE is needed only for functions
3007 defined in .h files. Reindent function header as per GNU style.
3008 (backtrace_p, backtrace_top, backtrace_next):
3009 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3010 compiler or linker. Add extern decls to pacify gcc -Wall.
3011 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3012 Now static.
3013 * frame.c (free_monitors): Define only on platforms that need it.
3014 * nsterm.m (ns_term_init):
3015 * process.c (catch_child_signal):
3016 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3017 defined on all porting targets these days.
3018 * process.c, process.h (catch_child_signal):
3019 Make it extern only if NS_IMPL_GNUSTEP is defined.
3020
e2d8a6f0
EZ
30212013-06-03 Eli Zaretskii <eliz@gnu.org>
3022
3023 * w32.c (gettimeofday): Make the signature identical to prototype
3024 in nt/inc/sys/time.h.
3025
a8a7c5f6
SM
30262013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3027
3028 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3029 .gdbinit.
3030
3031 * keyboard.c (safe_run_hooks_error): Improve error message.
3032
3033 * data.c (pure_write_error): Add `object' argument.
3034 * puresize.h (CHECK_IMPURE): Use it.
3035
c9628c79
MA
30362013-06-03 Michael Albinus <michael.albinus@gmx.de>
3037
3038 * Makefile.in (NOTIFY_OBJ): New variable.
3039 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3040
3041 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3042 Call syms_of_gfilenotify.
3043
3044 * gfilenotify.c: New file.
3045
3046 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3047 and Qfile_w32notify.
3048 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3049 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3050
3051 * lisp.h: Declare syms_of_gfilenotify.
3052
3053 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3054
2f592f95
SM
30552013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3056
3057 Merge the specpdl and backtrace stacks. Make the structure of the
3058 specpdl entries more obvious via a tagged union of structs.
3059 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3060 (enum specbind_tag): New enum.
3061 (struct specbinding): Make it a tagged union of structs.
3062 Add a case for backtrace records.
3063 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3064 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3065 (backtrace_debug_on_exit): New accessors.
3066 (struct backtrace): Remove.
3067 (struct catchtag): Remove backlist field.
3068 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3069 Move to eval.c.
3070 (Flocal_variable_p): Speed up the common case where the binding is
3071 already loaded.
3072 * eval.c (backtrace_list): Remove.
3073 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3074 (set_backtrace_args, set_backtrace_nargs)
3075 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3076 (backtrace_next): New functions.
3077 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3078 (unwind_to_catch, internal_lisp_condition_case)
3079 (internal_condition_case, internal_condition_case_1)
3080 (internal_condition_case_2, internal_condition_case_n): Don't bother
3081 with backtrace_list any more.
3082 (Fsignal): Adjust to new backtrace format.
3083 (grow_specpdl): Move up.
3084 (record_in_backtrace): New function.
3085 (eval_sub, Ffuncall): Use it.
3086 (apply_lambda): Adjust to new backtrace format.
3087 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3088 data.c.
3089 (specbind): Adjust to new specpdl format. Simplify.
3090 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3091 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3092 backtrace format.
3093 (mark_backtrace): Remove.
3094 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3095 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3096 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3097 Use mark_specpdl.
3098 * profiler.c (record_backtrace): Use get_backtrace.
3099 (handle_profiler_signal): Use backtrace_top_function.
3100 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3101 accessor functions.
3102
c0342369
JD
31032013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3104
3105 * process.h (catch_child_signal): Declare.
3106
3107 * process.c (catch_child_signal): New function.
3108 (init_process_emacs): Call it.
3109
3110 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3111 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3112 NS_IMPL_COCOA.
3113 (x_set_cursor_type): Remove declaration.
3114 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3115 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3116 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3117 (ns_get_color): Use F suffix on float.
3118 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3119 (ns_get_rgb_color): Remove.
3120 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3121 (note_mouse_movement): x and y are CGFloat.
3122 (ns_draw_fringe_bitmap): Remove unused rowY.
3123 Change #if to COCOA && >= 10_6.
3124 (ns_draw_window_cursor): Remove unused overspill.
3125 (ns_draw_underwave): width and x are EamcsCGFloat.
3126 (ns_draw_box): thickness is CGFloat.
3127 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3128 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3129 if not in main thread.
3130 (ns_get_pending_menu_title, ns_check_menu_open)
3131 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3132 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3133 (sendFromMainThread:): New method.
3134 (changeFont:): size is CGFloat.
3135 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3136 Disable warning about permanent text.
3137 (characterIndexForPoint:): Adjust return type depending on GNUStep
3138 version.
3139 (mouseDown:): delta is CGFloat.
3140 (updateFrameSize): Remove unised variable f.
3141 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3142 Cast float to EmacsCGFloat.
3143 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3144 also to -1 when restoring.
3145 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3146 inside NS_IMPL_COCOA.
3147 (toggleFullScreen:): Put call to toggleFullScreen inside
3148 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3149 (setPosition:portion:whole:): por is CGFloat.
3150 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3151 (mouseDown:): Use CGFloat.
3152 (mouseDragged:): Remove unised variable edge.
3153 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3154
3155 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3156 of CGFloat differs.
3157 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3158 when NS_IMPL_GNUSTEP.
3159 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3160 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3161 (EmacsToolbar): Add clearAll. Add tag argument to
3162 addDisplayItemWithImage.
3163 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3164
3165 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3166
3167 * nsmenu.m (ns_update_menubar): Make static.
3168 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3169 (fillWithWidgetValue:): Add cast to SEL for setAction.
3170 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3171 (update_frame_tool_bar): Update code for GNUStep.
3172 (clearAll): New method.
3173 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3174 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3175 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3176 call to insertItemWithItemIdentifier.
3177 (validateVisibleItems): Fix indentation.
3178 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3179 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3180 UtilityWindow to aStyle, remove call to setStyleMask.
3181
3182 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3183
3184 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3185 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3186 Use F suffix on floats.
3187 (ns_char_width): Returns CGFloat.
3188 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3189 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3190 DPSxshow.
3191 (ns_glyph_metrics): CGFloat instead of float.
3192
a0eb10b3
JB
3193 * nsfns.m (x_set_foreground_color, x_set_background_color):
3194 Use EmacsCGFloat.
3195 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3196 remove unused variables.
3197 (Fns_read_file_name): Keep track if panel is for save.
3198 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3199 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3200 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3201 Just return the input if GNUStep.
c0342369
JD
3202 (x_screen_planes): Remove.
3203 (Fxw_color_values): Use EmacsCGFloat
3204 (Fns_display_monitor_attributes_list): Only get screen number for
3205 Cocoa.
ef099a94 3206 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3207 EmacsSavePanel.
3208 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3209 ns_directory_from_panel.
3210
da9aff11
PE
32112013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3212
3213 * process.c (handle_child_signal): Also use WCONTINUED.
3214 This is so that list-processes doesn't mistakenly list the process
3215 as stopped, when the process has actually been continued and is
3216 now running.
3217
0e64479a
PE
32182013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3219
fc186a96
PE
3220 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3221 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3222 not already configured.
3223
0e64479a
PE
3224 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3225
38b787fa
EZ
32262013-05-29 Eli Zaretskii <eliz@gnu.org>
3227
3228 * Makefile.in (mostlyclean): Remove *.res files.
3229
22513e52
SM
32302013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3231
3232 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3233 a buffer (bug#8447).
3234
6ef3db10
EZ
32352013-05-27 Eli Zaretskii <eliz@gnu.org>
3236
3237 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3238 display vector, and we backtrack, handle the case that the
3239 previous character position is also displayed from a display
3240 vector or covered by a display string or image. (Bug#14476)
3241
6799bb26
JD
32422013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3243
3244 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3245 (struct MonitorInfo, free_monitors): Remove.
3246 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3247 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3248 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3249 Qframes, Qsource.
3250
3251 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3252 (struct MonitorInfo, free_monitors): Remove.
3253 (ns_screen_name): Make static.
3254 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3255 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3256 Qframes, Qsource.
3257
3258 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3259 (struct MonitorInfo): New struct.
3260 (free_monitors, make_monitor_attribute_list): Declare.
3261
22513e52
SM
3262 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3263 New Lisp_Object:s.
6799bb26
JD
3264 (free_monitors, make_monitor_attribute_list): New functions.
3265 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3266 Qsource.
3267
38cd43eb
XF
32682013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3269
3270 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3271
2af0948d
SM
32722013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3273
a7eb9b0f
SM
3274 * keyboard.c: Apply keyboard decoding only to events that come directly
3275 from the tty, not from unread-command-events (bug#14368).
3276 (read_event_from_main_queue): New function, extracted from read_char).
3277 (read_decoded_char): Remove.
3278 (read_decoded_event_from_main_queue): New function to replace it.
3279 (read_char): Use it.
3280 (read_key_sequence): Use read_char rather than read_decoded_char.
3281
2af0948d
SM
3282 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3283
1413e9a5
BR
32842013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3285
3286 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3287
e6d2f155
KH
32882013-05-22 Kenichi Handa <handa@gnu.org>
3289
3290 The following changes are to fix the setting of
3291 buffer-file-coding-system on, for instance, C-x RET c unix RET
3292 _FILE_OF_DOS_EOL_TYPE_ RET.
3293
3294 * coding.h (struct coding_system): New member detected_utf8_chars.
3295
3296 * coding.c (detect_coding_utf_8): Count characters and check EOL
3297 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3298 BOM is there.
3299 (setup_coding_system): Do not initialize coding->head_ascii.
3300 (check_ascii): Do not set coding->eol_seen but update it. Do not
3301 call adjust_coding_eol_type here.
1413e9a5
BR
3302 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3303 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3304 of the found coding-system.
3305 (decode_coding_gap): Cancel previous change. Utilize the
3306 character numbers counted by detect_coding_utf_8. Fix detection
3307 of BOM for utf-8.
3308
ab56a6f4 33092013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3310
3311 * search.c (looking_at_1): Only set last_thing_searched if the match
3312 changed the match-data (bug#14281).
3313
ecc3c6ed
DA
33142013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3315
3316 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3317 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3318 (move_it_vertically_backward): Likewise.
3319
5ba8bf35
YM
33202013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3321
3322 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3323 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3324 (Fx_display_mm_width, Fx_display_mm_height):
3325 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3326
91e8418b 3327 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3328 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3329 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3330 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3331 (Fx_display_backing_store, Fx_display_visual_class)
3332 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3333 (Fx_display_grayscale_p, Fx_display_pixel_width)
3334 (Fx_display_pixel_height, Fx_display_planes)
3335 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3336 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3337 (Fx_display_mm_width, Fx_display_mm_height)
3338 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3339 height for all physical monitors as in X11.
3340
fc30d803
SM
3341 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3342 Return pixel width or height for all physical monitors as in X11.
91e8418b 3343
31ff141c
PE
33442013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3345
3346 Port --enable-gcc-warnings to clang.
3347 * bytecode.c (exec_byte_code):
3348 * regex.c:
3349 Redo diagnostic pragmas to pacify clang, too.
3350 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3351 * editfns.c (Fencode_time):
3352 * fileio.c (file_accessible_directory_p):
3353 * font.c (font_unparse_xlfd):
3354 Use '&"string"[index]' instead of '"string" + (index)'.
3355 * undo.c (user_error): Remove; unused.
3356
df065a0b
EZ
33572013-05-16 Eli Zaretskii <eliz@gnu.org>
3358
04d360e7
EZ
3359 * insdel.c (insert_1_both): Document the arguments, instead of
3360 referring to insert_1, which no longer exists.
3361
5bb98290
EZ
3362 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3363 some window, increment windows_or_buffers_changed, so that
3364 *Messages* display in that window is updated. (Bug#14408)
3365
df065a0b
EZ
3366 * w32.c: Include epaths.h.
3367 (init_environment): Use cmdproxy.exe without leading directories.
3368 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3369 case.
3370 (gettimeofday): Adjust signature and return value to Posix
3371 expectations.
3372
3373 * unexw32.c (open_output_file): Delete the existing emacs.exe
3374 before creating it, to break the hard link to the versioned
3375 executable.
3376
3377 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3378 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3379 (FIRSTFILE_OBJ): New variables.
3380 (W32_RES): Rename to EMACSRES. All users changed.
3381 (base_obj): Use $(CM_OBJ).
3382 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3383 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3384 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3385 $(W32_RES_LINK) before $(LIBES).
3386 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3387
1aa8d505
SM
33882013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3389
6e911150
SM
3390 * makefile.w32-in (DOC): Use just "DOC".
3391
3392 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3393
1aa8d505
SM
3394 * process.c: Export default filters and sentinels to Elisp.
3395 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3396 New constants.
3397 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3398 (Fset_process_sentinel, Fformat_network_address):
3399 Default to them instead of nil.
3400 (server_accept_connection): Sentinels can't be nil any more.
3401 (read_and_dispose_of_process_output): New function, extracted from
3402 read_process_output.
3403 (read_process_output): Use it; filters can't be nil.
3404 (Finternal_default_process_filter): New function, extracted from
3405 read_process_output.
3406 (exec_sentinel_unwind): Remove function.
3407 (exec_sentinel): Don't zilch sentinel while running.
3408 (status_notify): Sentinels can't be nil.
3409 (Finternal_default_process_sentinel): New function extracted from
3410 status_notify.
3411 (setup_process_coding_systems): Default filter is not nil any more.
3412 (syms_of_process): Export new Elisp functions and initialize
3413 new constants.
3414 * lisp.h (make_lisp_proc): New function.
3415
5ac2eb34
SM
34162013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3417
3418 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3419
eda9c7d7
EZ
34202013-05-14 Eli Zaretskii <eliz@gnu.org>
3421
3422 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3423 unless we know that the window w is a leaf window.
3424 Another attempt at solving bug#14062.
eda9c7d7 3425
8fdeaad5
JD
34262013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3427
3428 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3429 fdesc (Bug#14375).
3430
44aa9ee6
PE
34312013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3432
3433 * image.c (gif_load): Check that subimages fit (Bug#14345).
3434
759fd763
SM
34352013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3436
3437 * lread.c (skip_dyn_eof): New function.
3438 (read1): Use it to skip the end of a file in response to #@00.
3439
3440 * doc.c (get_doc_string): Slightly relax the sanity checking.
3441
4465bfb4
JD
34422013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3443
3444 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3445 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3446 (MonitorInfo): New struct.
3447 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3448 (Fns_display_monitor_attributes_list): New functions.
3449 (display-usable-bounds): Remove.
3450 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3451 Qsource.
3452
7583e2a0
PE
34532013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3456 (GTK_CHECK_VERSION): New macro, if not already defined.
3457 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3458 replaced by GTK_CHECK_VERSION.
3459
ad75d77e
PE
34602013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3461
3462 * xterm.h (GTK_PREREQ): New macro.
3463 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3464 to use this macro instead, for consistency and clarity.
3465
07525f77
EZ
34662013-05-08 Eli Zaretskii <eliz@gnu.org>
3467
3468 * xdisp.c (row_for_charpos_p): New function, with code of
3469 cursor_row_p, but accepts an additional argument CHARPOS instead
3470 of using a hardcoded PT.
3471 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3472 (row_containing_pos): Call row_for_charpos_p instead of partially
3473 doing the same. Fixes cursor positioning under longlines-mode
3474 when longlines-show-effect includes more than one newline, when
3475 moving the cursor vertically up.
3476
d901fc8d
JB
34772013-05-08 Juanma Barranquero <lekktu@gmail.com>
3478
3479 * makefile.w32-in (ACL_H): New macro.
3480 ($(BLD)/fileio.$(O)): Update dependencies.
3481
f269bc61
PE
34822013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3483
e7b41c4c 3484 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3485 * Makefile.in (LIB_ACL): New macro.
3486 (LIBACL_LIBS): Remove.
3487 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3488 * fileio.c: Include <acl.h>.
3489 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3490 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3491 !acl_errno_valid.
3492 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3493 it ourselves.
3494
f269bc61
PE
3495 * unexelf.c: Don't assume ElfW (Half) fits in int.
3496 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3497 when dealing with ElfW (Half) values, since they can exceed 2**31
3498 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3499 (entry_address): Omit unused NUM arg. All uses changed.
3500
a261c53e
JL
35012013-05-07 Juri Linkov <juri@jurta.org>
3502
3503 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3504 to the string converted from number with `Fnumber_to_string'.
3505 (Bug#14254)
3506
2b66427d
PE
35072013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3508
3509 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3510 This fixes a problem introduced by my previous change.
3511
15acfe41
GM
35122013-05-07 Glenn Morris <rgm@gnu.org>
3513
3514 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3515
5ea03bf5
JD
35162013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3517
3518 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3519
e0c9d565
PE
35202013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 Static checking by GCC 4.8.0.
3523 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3524 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3525 (x_get_monitor_attributes_fallback)
3526 (x_get_monitor_attributes_xinerama)
3527 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3528 Define only if USE_GTK.
3529 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3530 (x_get_monitor_attributes_fallback): Omit unused locals.
3531 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3532 Use double, not float, to avoid mixed-mode floating point arithmetic.
3533
4e3f9230
YM
35342013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3535 Jan Djärv <jan.h.d@swipnet.se>
3536
3537 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3538 (XINERAMA_CFLAGS): New macros.
3539 (ALL_CFLAGS, LIBES): Use them.
3540
3541 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3542 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3543 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3544 (syms_of_xfns): DEFSYM them.
3545 (struct MonitorInfo): New struct.
3546 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3547 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3548 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3549 (x_get_monitor_attributes_xinerama): New functions.
3550 (Fx_display_monitor_attributes_list): New primitive.
3551 (syms_of_xfns): Defsubr it.
3552
3553 * xterm.h (x_display_info): Add Xatom_net_workarea and
3554 Xatom_net_current_desktop.
3555
3556 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3557 and dpyinfo->Xatom_net_current_desktop.
3558
05839b6a
EZ
35592013-05-06 Eli Zaretskii <eliz@gnu.org>
3560
3561 * xdisp.c (pos_visible_p): Use the special code for finding the
3562 beginning of a display property or overlay for any "replacing"
3563 display property, not just for display strings. This solves
3564 incorrect reporting of position by posn-at-point. (Bug#14241)
3565
dc4a2ee0
PE
35662013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3567
5ee94506
PE
3568 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3569 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3570 Verify that ElfW (Half) fits in int.
3571 (fatal): Use same signature as lisp.h.
3572 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3573 configure and build with -DUNEXELF_DEBUG without worrying about
3574 other modules that use DEBUG.
3575 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3576 possibly-wide integers now uses it instead of plain fprintf.
3577 (entry_address): New function, which avoids problems with 32-bit
3578 overflow on 64-bit hosts.
3579 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3580 (round_up): Don't assume the remainder fits in int.
3581 (find_section): Use bool for boolean. Simplify debug code.
3582 (unexec): Don't assume file sizes fit in int or size_t.
3583 Omit unnecessary trailing newline in 'fatal' format.
3584 Use strerror rather than outputting decimal error number.
3585 Remove unused code when emacs is not defined;
3586 this file relies on Emacs now.
3587 Don't assume e_phnum and e_shnum are positive.
3588
dc4a2ee0
PE
3589 * regex.c: Fix problems when DEBUG is defined.
3590 (extract_number, extract_number_and_incr): Define regardless of
3591 whether DEBUG is defined; that's simpler and makes the code less
3592 likely to go stale in the normal case when DEBUG is not defined.
3593 Return int rather than taking an int * arg. All callers changed.
3594 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3595 Remove, replacing with ...
3596 (DEBUG_PRINT): New macro. All callers changed.
3597 (DEBUG_COMPILES_ARGUMENTS): New macro.
3598 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3599 (print_compiled_pattern, print_double_string) [DEBUG]:
3600 Use prototype rather than old-style definition.
3601 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3602 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3603 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3604 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3605 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3606 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3607 This matters only when DEBUG is defined.
3608
14c7ed05
EZ
36092013-05-05 Eli Zaretskii <eliz@gnu.org>
3610
3611 * xdisp.c (set_iterator_to_next): Set the
3612 ignore_overlay_strings_at_pos_p flag only if we are _really_
3613 iterating over an overlay string, as indicated by the
3614 current.overlay_string_index member. (Bug#14306)
3615
e6076b1b
JD
36162013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3617
3618 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3619 to where it is used, to avoid autorelease issues (Bug#14050).
3620
cbee2131
PE
36212013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3622
3623 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3624 * fileio.c (syms_of_fileio): Implement this.
3625 * filelock.c (create_lock_file): If symbolic links don't work, so
3626 we use a regular file as a lock file, do not fsync the lock file;
3627 it's not needed.
3628
30c7e542
SM
36292013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3630
3631 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3632 (syms_of_minibuf): Adjust accodingly.
3633 * lread.c (Fread):
3634 * callint.c (Fcall_interactively): Adjust calls accordingly.
3635
5bebd186
EZ
36362013-05-04 Eli Zaretskii <eliz@gnu.org>
3637
3638 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3639 w->contents is a buffer before computing everything else.
3640 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3641
3642 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3643 assertion violations. (Bug#14062)
3644
0fb0a4f3
DR
36452013-05-01 David Reitter <david.reitter@gmail.com>
3646
3647 * nsfns.m (ns_tooltip): Initialize.
3648
9e63b4a5
EZ
36492013-04-28 Eli Zaretskii <eliz@gnu.org>
3650
3651 * coding.c (decode_coding_gap): Don't remove the character before
3652 a newline unless it's a CR character. (Bug#14287)
3653
ad60824e
DN
36542013-04-28 Dan Nicolaescu <dann@gnu.org>
3655
3656 * dispextern.h (struct face): Move enum face_underline_type
3657 earlier so that bitfields can be in the same word.
3658
edbdcec0
JD
36592013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3660
3661 * nsfns.m (handlePanelKeys): New function.
3662 (EmacsOpenPanel:performKeyEquivalent:)
3663 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3664 arrows/function/control and copy/paste keys (Bug#14296).
3665
0208ede7
JL
36662013-04-27 Juri Linkov <juri@jurta.org>
3667
3668 * callint.c (Fcall_interactively): Call `Qread_number' for
3669 interactive code letter `n' instead of using duplicate code.
3670 (Bug#14254)
3671
b8dd59f7
PE
36722013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3673
3674 * systime.h (make_timeval): Declare as 'const'.
3675
8bd722db
KH
36762013-04-27 Kenichi Handa <handa@gnu.org>
3677
3678 * font.c (font_open_entity): Always open a font of manageable
3679 size.
3680
13d0e56f 36812013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3682
f780d632
PE
3683 Port better to AIX (Bug#14258).
3684 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3685 to pacify AIX xlc.
3686
ec509856
KH
36872013-04-24 Kenichi Handa <handa@gnu.org>
3688
3689 * coding.c (decode_coding_iso_2022): When an invalid escape
3690 sequence is encountered, reset the invocation and designation
3691 status to the safest one.
3692
84fc48e5
PE
36932013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3696 Without this fix, "make distclean" leaves stamp-h1 behind.
3697
806bda47
EC
36982013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3699
3700 * w32fns.c (w32_fullscreen_rect): New function to compute the
3701 window rectangle for the given fullscreen mode.
3702 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3703 longer tunes the window size. This keeps the window's edges flush
3704 with the screen and allows the taskbar to hide itself in fullboth.
3705
3706 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3707 window decorations and uses the entire screen.
3708
3709 * w32term.h (w32_fullscreen_rect) Add prototype.
3710 (struct w32_output): Replace normal_width, normal_height,
3711 normal_top, and normal_left members with a single normal_placement
3712 struct.
3713 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3714 Remove macros.
3715 (FRAME_NORMAL_PLACEMENT): New macro.
3716
9cc2810b
JB
37172013-04-16 Juanma Barranquero <lekktu@gmail.com>
3718
3719 * minibuf.c (Ftest_completion): Silence compiler warning.
3720
fd16b54c
EZ
37212013-04-15 Eli Zaretskii <eliz@gnu.org>
3722
3723 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3724 bug#14062.
fd16b54c
EZ
3725
3726 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3727 parentheses.
3728
3729 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3730 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3731 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3732 parentheses where appropriate.
3733
9e3379a0
PE
37342013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3735
3736 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3737
ddd6b685
EZ
37382013-04-14 Eli Zaretskii <eliz@gnu.org>
3739
3740 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3741 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3742 Mention in the doc string that setting these variables takes
3743 effect only after a call to set-window-buffer. (Bug#14200)
3744
29b79ba1
EZ
37452013-04-13 Eli Zaretskii <eliz@gnu.org>
3746
3747 * indent.c (Fvertical_motion): Don't consider display strings on
3748 overlay strings as display strings on the buffer position we
3749 started from. This prevents vertical cursor motion from jumping
3750 more than one line when there's an overlay string with a display
3751 property at end of line.
3752 Reported by Karl Chen <Karl.Chen@quarl.org> in
3753 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3754
562c6ee9
SM
37552013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3756
3757 * window.c (select_window): `record_buffer' even if window is
3758 already selected (bug#14191).
3759
fcc1fe85
EZ
37602013-04-11 Eli Zaretskii <eliz@gnu.org>
3761
3762 * window.c (Fwindow_end): Test more flags, including the buffer's
3763 last_overlay_modified flag, to determine whether the window's
3764 display is really up-to-date. Prevents the function from
3765 returning a stale value. (Bug#14170)
3766 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3767 current matrix.
3768
f009190a
EZ
37692013-04-10 Eli Zaretskii <eliz@gnu.org>
3770
3771 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3772 garbaged only if it is not already the top frame on its TTY.
3773 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3774 there are GUI frames open in the same session. (Bug#13864)
3775
78ce603d
SM
37762013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3777
3778 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3779 of marking the idle timers directly.
3780
a8036e40
SM
37812013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3782
3783 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3784 tables (bug#14054).
3785
7ffe7ef6
SM
37862013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3787
3788 * window.c (select_window): Don't record_buffer while the invariant is
3789 temporarily broken (bug#14161).
3790
3791 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3792
7d9f6883
EZ
37932013-04-07 Eli Zaretskii <eliz@gnu.org>
3794
3795 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3796
5406cfd9
RF
37972013-04-07 Romain Francoise <romain@orebokech.com>
3798
3799 Ignore additional platform-specific ACL errors (Bug#13702).
3800 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3801 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3802
95c0e83b
JD
38032013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3804
3805 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3806 f->output_data.ns.
3807
876da980
PE
38082013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3809
3810 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3811 This bug was introduced by my 2013-02-25 change that simplified
3812 data_start configuration. Without this change, on GNU/Linux
3813 an Emacs configured with --enable-profiling fails immediately
3814 due to a profiler signal.
3815 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3816 with these flags. On platforms where special flags are needed
3817 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3818 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3819 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3820
7452b7bd
DA
38212013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3822
3823 Get rid of some platform-specific functions examining window
3824 system and its capabilities. This is a partial rework of the
3825 2013-04-05 change.
3826 * lisp.h (have_menus_p): Remove prototype. This function is
3827 replaced with platform-independent window_system_available.
3828 (check_window_system): Move to...
3829 * frame.h (decode_window_system_frame, window_system_available):
3830 ...here, add new prototypes.
3831 * frame.c (window_system_available, decode_window_system_frame):
3832 New functions.
3833 (check_window_system): Platform-independent now.
3834 * xterm.h (x_in_use): Remove declaration.
3835 (check_x_frame):
3836 * w32term.h (check_x_frame):
3837 * nsterm.h (check_x_frame): Remove prototypes. This function
3838 is replaced with platform-independent decode_window_system_frame.
3839 * msdos.c (have_menus_p): Remove.
3840 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3841 Remove platform-specific functions. Use check_window_system,
3842 decode_window_system_frame and check_ns_display_info where
3843 appropriate. Minor style and comment tweaks.
3844 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3845 (check_x_frame): Likewise.
3846 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3847 Likewise.
3848 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3849 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3850 * xmenu.c, xselect.c: All related users changed.
3851
251e9147
KH
38522013-04-03 Kenichi Handa <handa@gnu.org>
3853
3854 The following changes is to optimize the code for reading UTF-8
3855 files.
3856
562c6ee9 3857 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3858 changed. Check EOL format. Do not call adjust_coding_eol_type
3859 here.
3860 (check_utf_8): New function.
3861 (adjust_coding_eol_type): Do nothing if already adjusted.
3862 (detect_coding): Compare the return value of check_ascii with
3863 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3864 (decode_coding_gap): Optimize for valid UTF-8.
3865
8bc369d4
KH
38662013-03-21 Kenichi Handa <handa@gnu.org>
3867
3868 * coding.c (syms_of_coding): Cancel previous change.
3869
3870 * insdel.c (insert_from_gap): Fix previous change.
3871
73931ad1
DA
38722013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3873
3874 Consistently use platform-specific function to detect window system.
3875 * lisp.h (check_window_system): New prototype. This function is
3876 going to replace check_x, check_w32 and check_ns.
3877 (have_menus_p): Mention msdos.c in comment.
3878 * fontset.c (check_window_system_func): Remove. Adjust all users.
3879 * fontset.h (check_window_system_func): Remove prototype.
3880 * nsterm.h (check_ns):
3881 * xterm.h (check_x):
3882 * w32term.h (check_w32): Likewise.
3883 * menu.c (Fx_popup_menu): Use check_window_system.
3884 * msdos.c (check_window_system): Define for MS-DOS.
3885 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3886 * w32fns.c (check_window_system): Likewise for MS-Windows.
3887 * xfns.c (check_window_system): Likewise for X.
3888 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3889 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3890
7216e43b
PE
38912013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 Prefer < to > in range checks such as 0 <= i && i < N.
3894 This makes it easier to visualize quantities on a number line.
3895 This patch doesn't apply to all such range checks,
3896 only to the range checks affected by the 2013-03-24 change.
3897 This patch reverts most of the 2013-03-24 change.
3898 * alloc.c (xpalloc, Fgarbage_collect):
3899 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3900 * character.c (string_escape_byte8):
3901 * charset.c (read_hex):
3902 * data.c (cons_to_unsigned):
3903 * dispnew.c (update_frame_1):
3904 * doc.c (Fsubstitute_command_keys):
3905 * doprnt.c (doprnt):
3906 * editfns.c (hi_time, decode_time_components):
3907 * fileio.c (file_offset):
3908 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3909 * font.c (font_intern_prop):
3910 * frame.c (x_set_alpha):
3911 * gtkutil.c (get_utf8_string):
3912 * indent.c (check_display_width):
3913 * keymap.c (Fkey_description):
3914 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3915 * lread.c (read1):
3916 * minibuf.c (read_minibuf_noninteractive):
3917 * process.c (wait_reading_process_output):
3918 * search.c (Freplace_match):
3919 * window.c (get_phys_cursor_glyph):
3920 * xdisp.c (redisplay_internal):
3921 * xsmfns.c (smc_save_yourself_CB):
3922 Prefer < to > for range checks.
3923 * dispnew.c (sit_for): Don't mishandle NaNs.
3924 This fixes a bug introduced in the 2013-03-24 change.
3925 * editfns.c (decode_time_components): Don't hoist comparison.
3926 This fixes another bug introduced in the 2013-03-24 change.
3927
92759988
DA
39282013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3929
3930 * frame.h (struct frame): Drop scroll_bottom_vpos
3931 member becaue all real users are dead long ago.
3932 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3933 * xdisp.c (redisplay_internal): Adjust user.
3934
9a1971bb
GM
39352013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3936
f38ab167
JD
3937 * nsmenu.m (showAtX:Y:for:): setLevel to
3938 NSPopUpMenuWindowLevel (Bug#13998).
3939
6d01f1fe
JD
39402013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3941
3942 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3943 (ns_check_pending_open_menu): Declare.
3944
3945 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3946 (x_activate_menubar): Update the menu with title that matches
3947 ns_get_pending_menu_title, and call
3948 ns_check_pending_openmenu (Bug#12698).
3949 (menuWillOpen:): New method.
3950 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3951
3952 * nsterm.m (menu_will_open_state, menu_mouse_point)
3953 (menu_pending_title): New varaibles.
3954 (ns_get_pending_menu_title, ns_check_menu_open)
3955 (ns_check_pending_open_menu): New functions.
3956
781f4782
DA
39572013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3958
3959 * indent.c (current_column_bol_cache): Remove leftover which is not
3960 used in Fmove_to_column any more.
3961 (current_column, scan_for_column): Adjust users.
3962 * keyboard.c (last_point_position_buffer, last_point_position_window):
3963 Remove leftovers which are not used for recording undo any more.
3964 (command_loop_1, syms_of_keyboard): Adjust users.
3965 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3966 redisplay_window any more.
3967 (move_it_to): Adjust user.
3968
1921c31b
JB
39692013-03-29 Juanma Barranquero <lekktu@gmail.com>
3970
3971 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3972 Update dependencies.
3973
717b8bcd
SM
39742013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3975
3976 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3977 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3978 forward references.
3979
e74aeda8
DA
39802013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3981
3982 * window.h (struct window): Replace hchild, vchild and buffer slots
3983 with the only contents slot. This is possible because each valid
3984 window may have either the child window (in vertical or horizontal
3985 combination) or buffer to display (for the leaf window). Using that,
3986 a lof of operations to traverse and/or change window hierarchies may
3987 be simplified. New member horizontal is used to distinguish between
3988 horizontal and vertical combinations of internal windows.
3989 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3990 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3991 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3992 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3993 Use contents slot, not buffer, where appropriate.
3994 (wset_combination): New function.
3995 (wset_buffer): Add eassert.
3996 (Fframe_first_window): Simplify the loop reaching first window.
3997 (Fwindow_buffer): Use WINDOW_LEAF_P.
3998 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3999 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4000 (unshow_buffer): Convert initial debugging check to eassert.
4001 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4002 (make_parent_window, window_resize_check, window_resize_apply)
4003 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4004 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4005 Adjust to match struct window changes.
4006 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4007 (mark_window_cursors_off, count_windows, get_leaf_windows)
4008 (foreach_window_1): Simplify the loop.
4009 * alloc.c (mark_object): Do not check for the leaf window because
4010 internal windows has no glyph matrices anyway.
4011 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4012 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4013 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4014 (build_frame_matrix_from_window_tree, mirror_make_current)
4015 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4016 (update_window_tree, set_window_update_flags): Simplify the loop.
4017 (sync_window_with_frame_matrix_rows): Enforce live window.
4018 Use contents slot, not buffer, where appropriate.
4019 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4020 and WINDOW_HORIZONTAL_COMBINATION_P.
4021 (make_frame_visible_1): Simplify the loop.
4022 Use contents slot, not buffer, where appropriate.
4023 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4024 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4025 (expose_window_tree): Likewise.
4026 Use contents slot, not buffer, where appropriate.
4027 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4028 to avoid deleted windows. Use contents slot instead of buffer.
4029 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4030 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4031 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4032 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4033
121ab1cd
EZ
40342013-03-28 Eli Zaretskii <eliz@gnu.org>
4035
ef454cf7
EZ
4036 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4037 identify the reasons for assertion violations in bug#14062 and
4038 similar ones.
21e930f8
EZ
4039 (Fx_show_tip): Fix compilation error under
4040 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4041
121ab1cd
EZ
4042 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4043 Reported by <rzl24ozi@gmail.com>.
4044
5c89ca24
DA
40452013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4046
4047 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4048 start marker...
562c6ee9
SM
4049 (unwind_with_echo_area_buffer): ...to restore it here.
4050 This is needed to ensure that...
5c89ca24
DA
4051 (redisplay_window): ...both window markers are valid here,
4052 which is verified by eassert.
4053 * editfns.c (save_excursion_save): Do not assume that
4054 selected_window always displays the buffer.
c7f53895
DA
4055 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4056 Fix comment.
5c89ca24 4057
f557c1b1
SM
40582013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4059
4060 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4061 the upcase table.
4062
40693bba 40632013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4064
4065 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4066
c86f791f
EZ
40672013-03-27 Eli Zaretskii <eliz@gnu.org>
4068
4069 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4070 since MinGW's w32api headers do. This avoids compiler warnings.
4071
4072 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4073 if already defined.
4074
c6e72e17
EZ
40752013-03-26 Eli Zaretskii <eliz@gnu.org>
4076
4077 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4078
54e95010
JD
40792013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4080
4081 * gtkutil.c (style_changed_cb): Check if frame is live and an
4082 X frame (Bug#14038).
4083
b88b62de
EZ
40842013-03-26 Eli Zaretskii <eliz@gnu.org>
4085
a18d7de6
EZ
4086 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4087 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4088 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4089 MinGW64.
8f5e14c8
EZ
4090 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4091 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4092
b88b62de
EZ
4093 Fix incompatibilities between MinGW.org and MinGW64 headers.
4094 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4095
4096 * w32.c (REPARSE_DATA_BUFFER): Guard with
4097 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4098
c074e458
JD
40992013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4100
4101 * xterm.c: Include X11/XKBlib.h
4102 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4103
908589fd
AS
41042013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4105
4106 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4107 written backwards.
4108 * blockinput.h (input_blocked_p): Likewise.
4109 * bytecode.c (exec_byte_code): Likewise.
4110 * callproc.c (call_process_kill, call_process_cleanup)
4111 (Fcall_process): Likewise.
4112 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4113 (Fccl_execute_on_string): Likewise.
4114 * character.c (string_escape_byte8): Likewise.
4115 * charset.c (read_hex): Likewise.
4116 * cm.c (calccost): Likewise.
4117 * data.c (cons_to_unsigned): Likewise.
4118 * dired.c (directory_files_internal, file_name_completion):
4119 Likewise.
4120 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4121 (sit_for): Likewise.
4122 * doc.c (Fsubstitute_command_keys): Likewise.
4123 * doprnt.c (doprnt): Likewise.
4124 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4125 * emacsgtkfixed.c: Likewise.
4126 * fileio.c (file_offset, Fwrite_region): Likewise.
4127 * floatfns.c (Fexpt, fmod_float): Likewise.
4128 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4129 Likewise.
4130 * font.c (font_intern_prop): Likewise.
4131 * frame.c (x_set_alpha): Likewise.
4132 * gtkutil.c (get_utf8_string): Likewise.
4133 * indent.c (check_display_width): Likewise.
4134 * intervals.c (create_root_interval, rotate_right, rotate_left)
4135 (split_interval_right, split_interval_left)
4136 (adjust_intervals_for_insertion, delete_node)
4137 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4138 (merge_interval_right, merge_interval_left, copy_intervals)
4139 (set_intervals_multibyte_1): Likewise.
4140 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4141 * keymap.c (Fkey_description): Likewise.
4142 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4143 * lread.c (openp, read_integer, read1, string_to_number):
4144 Likewise.
4145 * menu.c (ensure_menu_items): Likewise.
4146 * minibuf.c (read_minibuf_noninteractive): Likewise.
4147 * print.c (printchar, strout): Likewise.
4148 * process.c (create_process, Faccept_process_output)
4149 (wait_reading_process_output, read_process_output, send_process)
4150 (wait_reading_process_output): Likewise.
4151 * profiler.c (make_log, handle_profiler_signal): Likewise.
4152 * regex.c (re_exec): Likewise.
4153 * regex.h: Likewise.
4154 * search.c (looking_at_1, Freplace_match): Likewise.
4155 * sysdep.c (get_child_status, procfs_ttyname)
4156 (procfs_get_total_memory): Likewise.
4157 * systime.h (EMACS_TIME_VALID_P): Likewise.
4158 * term.c (dissociate_if_controlling_tty): Likewise.
4159 * window.c (get_phys_cursor_glyph): Likewise.
4160 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4161 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4162 Likewise.
4163 * xfns.c (Fx_window_property): Likewise.
4164 * xmenu.c (set_frame_menubar): Likewise.
4165 * xselect.c (x_get_window_property, x_handle_dnd_message):
4166 Likewise.
4167 * xsmfns.c (smc_save_yourself_CB): Likewise.
4168 * xterm.c (x_scroll_bar_set_handle): Likewise.
4169
2bf7d27a
DA
41702013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4171
4172 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4173 to be optional or nil. Adjust comment and convert it to docstring.
4174 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4175 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4176
a9ebfa0b
PE
41772013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4178
4179 Static checking by GCC 4.8-20130319.
4180 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4181 * process.c (Fset_process_datagram_address)
4182 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4183 * xdisp.c (get_char_face_and_encoding):
4184 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4185 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4186 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4187
4f3576ee
KB
41882013-03-24 Ken Brown <kbrown@cornell.edu>
4189
789b5e9a
KB
4190 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4191 fix compilation on 64-bit Cygwin, where underscores are not
4192 automatically prepended.
4193
4f3576ee
KB
4194 * w32term.c (w32_initialize): Silence compiler warning.
4195
b5b7745f
EZ
41962013-03-23 Eli Zaretskii <eliz@gnu.org>
4197
cdc0d0bd
EZ
4198 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4199 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4200 variables, to save and restore frame dimensions.
4201 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4202 after returning from a 'fullscreen' configuration.
4203 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4204 to avoid races between the main thread and the input thread.
4205
4206 * w32term.h (struct w32_output): New members normal_width,
4207 normal_height, normal_top, normal_left, and prev_fsmode.
4208 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4209 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4210 members of a frame.
4211
b5b7745f
EZ
4212 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4213 'fullscreen' parameter. Always record previous width and height
4214 of the frame, except when switching out of maximized modes, so
4215 that they could be restored correctly, instead of resetting to the
4216 default frame dimensions. Send SC_RESTORE command to the frame,
4217 unless we are going to send SC_MAXIMIZE, to restore the frame
4218 resize hints in the mouse pointer shown by the window manager.
4219 (Bug#14032)
4220
4221 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4222
4223 * lisp.h (get_frame_param): Adjust conditions for prototype
4224 declaration.
4225
a3454eed
KB
42262013-03-22 Ken Brown <kbrown@cornell.edu>
4227
4228 * unexcw.c: Drop unneeded inclusion of w32common.h.
4229 (report_sheap_usage): Declare.
4230 (read_exe_header): Add magic numbers for x86_64.
4231 (fixup_executable): Fix printf format specifier for unsigned long
4232 argument.
4233
5a49b79c
DA
42342013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4235
4236 * frame.h (struct frame): Put menu_bar_window under #ifdef
4237 because this member is not needed when X toolkit is in use.
4238 (fset_menu_bar_window):
4239 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4240 (free_glyphs, update_frame):
4241 * xdisp.c (expose_frame): Likewise.
4242 (display_menu_bar): Likewise. Remove redundant eassert.
4243 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4244 toolkit is in use.
4245
d6723bf7
PE
42462013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4247
7b1123d8
PE
4248 Use functions and constants to manipulate Lisp_Save_Value objects.
4249 This replaces code that used macros and strings and token-pasting.
4250 The change makes the C source a bit easier to follow,
4251 and shrinks the Emacs executable a bit.
4252 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4253 (make_save_value): Change 1st arg from string to enum. All callers
4254 changed.
4255 (INTX): Remove.
4256 (mark_object): Use if, not #if, for GC_MARK_STACK.
4257 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4258 (XSAVE_OBJECT): Now functions, not macros.
4259 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4260 the constant was never used.
4261 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4262 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4263 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4264 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4265 New constants.
4266 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4267 type3 with a single member save_type. All uses changed.
4268 (save_type, set_save_pointer, set_save_integer): New functions.
4269 * print.c (PRINTX): Remove.
4270
d6723bf7
PE
4271 * alloc.c: Remove redundant static declarations.
4272
5f24fa51
DA
42732013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4274
4275 * window.h (struct window): Convert left_col, top_line, total_lines
4276 and total_cols from Lisp_Objects to integers. Adjust comments.
4277 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4278 Remove.
4279 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4280 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4281 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4282 Adjust users where appropriate.
4283
42143acd
DA
42842013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4285
4286 * frame.h (struct frame): Drop resx and resy because the same data is
4287 available from window system-specific output context. Adjust users.
562c6ee9
SM
4288 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4289 New functions to provide defaults when no window system available.
42143acd 4290 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4291 (NUMVAL): Move from xdisp.c.
42143acd
DA
4292 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4293 (Ffont_face_attributes, Fopen_font):
4294 * image.c (gs_load):
4295 * w32font.c (fill_in_logfont):
4296 * xdisp.c (calc_pixel_width_or_height):
4297 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4298 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4299
c0a17406
KH
43002013-03-20 Kenichi Handa <handa@gnu.org>
4301
4302 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4303 to 1 (temporary workaround until a bug related to ASCII
4304 optimization is fixed).
4305
095d384d
DA
43062013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4307
4308 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4309 Signal error if window is not internal. Adjust docstring.
4310 (delete_all_child_windows): Use combination_limit to save the buffer.
4311 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4312 * print.c (syms_of_print): Initialize debugging output not here...
4313 (init_print_once): ...but in a new function here.
4314 * lisp.h (init_print_once): Add prototype.
4315 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4316
748fa866
DA
43172013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4318
4319 * window.c (window_resize_check, window_resize_apply)
4320 (window_from_coordinates, recombine_windows, set_window_buffer)
4321 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4322 (Fsplit_window_internal, Fdelete_window_internal)
4323 (freeze_window_starts): Use bool for booleans.
4324 * window.h (window_frame_coordinates, resize_frame_windows)
4325 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4326
81519fd2
SM
43272013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4328
4329 * dispnew.c (bitch_at_user): Use `user-error'.
4330
6db423a9
KB
43312013-03-17 Ken Brown <kbrown@cornell.edu>
4332
4333 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4334 as return type of image_background. (Bug#13981)
4335 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4336
8f2906f5
JD
43372013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4338
960ce480 4339 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4340 (ns_select): Don't return with result uninitialized.
960ce480 4341
8f2906f5
JD
4342 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4343 and getDirectory.
4344
81519fd2
SM
4345 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4346 New functions.
8f2906f5
JD
4347 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4348 directories. If filename is nil, get directory name (Bug#13932).
4349 Use getFilename and getDirectory.
4350 (getFilename, getDirectory): New methods for EmacsSavePanel and
4351 EmacsOpenPanel.
4352 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4353
cded56c1
PE
43542013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4355
4356 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4357
251e9147 43582013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4359
4360 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4361 (adjust_after_replace): Make it back to static. Delete the third
4362 arg text_at_gap_tail. Cancel the code for handling it.
4363
4364 * coding.h (struct coding_system): New member eol_seen.
4365
4366 * coding.c (detect_ascii): New function.
4367 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4368 when the source bytes are actually scanned. On detecting for
4369 coding_category_utf_8_auto, call detect_ascii instead of scanning
4370 source bytes directly.
4371 (produce_chars): Call insert_from_gap with the new arg 0.
4372 (encode_coding): Likewise.
4373 (decode_coding_gap): Control ASCII optimization by the variable
4374 disable_ascii_optimization instead of #ifndef .. #endif.
4375 Deccode EOL format according to coding->eol_seen.
4376 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4377 variable.
4378
8a44e6d1
KH
4379 * lisp.h (adjust_after_replace): Cancel externing it.
4380 (insert_from_gap): Adjust prototype.
4381
5f795e34
EZ
43822013-03-15 Eli Zaretskii <eliz@gnu.org>
4383
4384 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4385 FULLSCREEN_MAXIMIZED. (Bug#13935)
4386
f258b4be
DA
43872013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4388
4389 * region-cache.c (find_cache_boundary, move_cache_gap)
4390 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4391 Simplify debugging check and convert to eassert. Adjust comment.
4392 (pp_cache): Put under ENABLE_CHECKING.
4393
a5cc4dde
EZ
43942013-03-14 Eli Zaretskii <eliz@gnu.org>
4395
4396 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4397 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4398 and WM_ACTIVATEAPP.
4399 (w32fullscreen_hook): If the frame is visible, reset
4400 f->want_fullscreen flag after changing the frame size. If the
4401 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4402 (Bug#13953)
4403
3fc5e44a
DC
44042013-03-13 Daniel Colascione <dancol@dancol.org>
4405
4406 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4407 too so that these builds can use Cygwin's file conversion
4408 functions. (We've been building and linking cygw32.o all along
4409 and just not using it.)
4410
47d7532e
PE
44112013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4412
4413 File synchronization fixes (Bug#13944).
4414 * Makefile.in (LIB_FDATASYNC): New macro.
4415 (LIBES): Use it.
4416 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4417 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4418 Don't worry about HAVE_FSYNC, since a substitute fsync is
4419 available if the system lacks one.
4420 (Fwrite_regin): Retry fsync if interrupted.
4421
c7ffccaf
EZ
44222013-03-13 Eli Zaretskii <eliz@gnu.org>
4423
4e2df81d 4424 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4425 activated, call w32fullscreen_hook, to make sure the new frame
4426 dimensions are in effect. (Bug#13937)
4427
8a7debc1
DA
44282013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4429
4430 * xdisp.c (init_iterator): Simplify because both character and byte
4431 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4432 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4433 character and byte positions can be obtained from marker.
8a7debc1 4434
7fd8c501
PE
44352013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4436
d9df6f40
PE
4437 Static checking by Sun C 5.12.
4438 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4439 * bytecode.c (exec_byte_code):
4440 * dispnew.c (init_display):
4441 * eval.c (error):
4442 * fileio.c (Fsubstitute_in_file_name):
4443 * keyboard.c (Fevent_convert_list):
4444 * keymap.c (Fsingle_key_description):
4445 * term.c (maybe_fatal, fatal):
4446 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4447 * xsmfns.c (Fhandle_save_session):
4448 Omit unreachable code.
4449 * keymap.c (map_keymap_char_table_item): Cast void * to
4450 a function pointer type; the C Standard requires this.
4451
7fd8c501
PE
4452 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4453 Include <sys/param.h> unconditionally, as that works elsewhere and
4454 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4455 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4456 and FreeBSD now.
4457
a020afb9 4458See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4459
4460;; Local Variables:
4461;; coding: utf-8
aac0c6e3
MR
4462;; End:
4463
ab422c4d 4464 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4465
4466 This file is part of GNU Emacs.
4467
4468 GNU Emacs is free software: you can redistribute it and/or modify
4469 it under the terms of the GNU General Public License as published by
4470 the Free Software Foundation, either version 3 of the License, or
4471 (at your option) any later version.
4472
4473 GNU Emacs is distributed in the hope that it will be useful,
4474 but WITHOUT ANY WARRANTY; without even the implied warranty of
4475 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4476 GNU General Public License for more details.
4477
4478 You should have received a copy of the GNU General Public License
4479 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.