Declare external variables.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0fe73012
KB
12013-08-15 Ken Brown <kbrown@cornell.edu>
2
3 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
4 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
5 needed.
6
691a357f
PE
72013-08-15 Paul Eggert <eggert@cs.ucla.edu>
8
9 Fix minor problems found by static checking.
10 * frame.c (delete_frame):
11 * xdisp.c (next_element_from_display_vector):
12 Avoid uninitialized local.
13 * image.c (imagemagick_compute_animated_image): Port to C89.
14 Prefer usual GNU indentation style for loops.
15 Be more careful about bizarrely large sizes, by using ptrdiff_t
16 instead of int.
17
42fe2e88
DA
182013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
19
20 Fix infinite frame selection loop (Bug#15025).
21 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
22
d39a3da6
EZ
232013-08-15 Eli Zaretskii <eliz@gnu.org>
24
25 * xdisp.c (compute_window_start_on_continuation_line): When
26 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
27 to make sure we end up setting the window start at the leftmost
28 visible character of the display line. This avoids funky
29 horizontal shifting because the window start is not kept on the
30 same position. (Bug#15090)
05426239
EZ
31 (next_element_from_display_vector): Support 'box' face attribute
32 in the face definitions of a display vector. (Bug#15099)
d39a3da6 33
6e856b69
LMI
342013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
35
36 * image.c (imagemagick_compute_animated_image): Implement animated
37 images (bug#14700).
995be755
LMI
38 (imagemagick_compute_animated_image): Fix some compilation
39 warnings. Implement a very simple cache to make the animation
40 usable at all, but it should be replaced with a per-image cache.
6e856b69 41
d5a1acfa
DA
422013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
43
44 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
45 to do `for' loops over alist values.
46 * buffer.h (FOR_EACH_BUFFER):
47 * process.c (FOR_EACH_PROCESS): Use it.
48 (handle_child_signal, status_notify, Fget_buffer_process)
49 (kill_buffer_processes): Use FOR_EACH_PROCESS.
50
9c253307
DA
512013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
52
53 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
54 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
55 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
56 to xzalloc and so avoid redundant call to memset.
57 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
58 members because it is allocated with xzalloc and so already zeroed.
59
05e64f9f
KB
602013-08-14 Ken Brown <kbrown@cornell.edu>
61
62 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
63 (Bug#15094).
64
5b71542d
DA
652013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
66
67 Utility function and macro to copy Lisp string to C string.
68 * lisp.h (xlispstrdupa): New macro.
69 (xlispstrdup): New prototype.
70 * alloc.c (xlispstrdup): New function.
71 * callint.c (Fcall_interactively):
72 * fileio.c (Ffile_name_directory, Fexpand_file_name)
73 (Fsubstitute_in_file_name):
74 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
75 * image.c (x_create_bitmap_from_file):
76 * w32term.c (w32_term_init):
77 * xterm.c (x_term_init): Use xlispstrdup.
78
71530c97
LMI
792013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
80
4ce82fb8
LMI
81 * image.c (imagemagick_load_image): Make animated pictures work.
82 There's still some problems with background color settings, though
83 (bug#14700).
84
71530c97
LMI
85 * decompress.c (unwind_decompress): Always restore point.
86
7510a061
XF
872013-08-14 Xue Fuqiao <xfq.free@gmail.com>
88
89 * marker.c (set_marker): Reformat documentation.
90
01c3051f
PE
912013-08-14 Paul Eggert <eggert@cs.ucla.edu>
92
aab1fcdf
PE
93 * xdisp.c (cursor_type_changed): Now static.
94
01c3051f
PE
95 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
96 Use changed. This avoids the need to call xmalloc and for the
97 caller to call xfree, and avoids memory leaks in some situations.
98
2084152a
DA
992013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
100
101 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
102 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
103 (redisplay_window): If window_end_valid is cleared due to non-zero
104 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
105 so do not call to try_cursor_movement for that window.
2084152a 106
02455cb6
DA
1072013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
108
109 * window.h (struct window): Convert window_end_pos and
110 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
111 (wset_window_end_pos, wset_window_end_vpos): Remove.
112 * dispnew.c (adjust_glyph_matrix):
113 * window.c (Fwindow_end, replace_window, set_window_buffer)
114 (make_window):
115 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
116 (set_vertical_scroll_bar, redisplay_window, try_window)
117 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
118 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
119 (note_mouse_highlight): Adjust users.
120 (try_cursor_movement): Likewise. Convert old precondition to eassert.
121 Add comment.
122
da5707e8
DA
1232013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
124
125 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
126 * image.c (imagemagick_filename_hint): Use `const char *' and
127 prefer SSDATA to SDATA to avoid warnings.
128
25554267
DA
1292013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
130
131 Cleanup window fringes, margins and scroll bars adjustments.
132 * window.c (set_window_fringes, set_window_margins)
133 (set_window_scroll_bars, apply_window_adjustment): New functions.
134 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
135 (Fset_window_scroll_bars): Use them.
136
38a2c910
DA
1372013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
138
139 * window.h (struct window): Convert scroll_bar_width
140 from Lisp_Object to integer. Adjust comment.
141 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
142 Adjust users.
143 * window.c (wset_scroll_bar_width): Remove.
144 (make_window): Initialize scroll_bar_width.
145 (Fsplit_window_internal): Use direct assignment.
146 (Fset_window_configuration, save_window_save):
147 Convert Lisp_Object to integer and back where appropriate.
148 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
149 bar was actually changed, and mention this in docstring.
150
2d065031
PE
1512013-08-13 Paul Eggert <eggert@cs.ucla.edu>
152
153 * decompress.c: Minor simplifications.
154 (Fzlib_decompress_region): Don't bother verifying
155 that avail_out <= UINT_MAX, as that was confusing.
156 Mention the restriction in a comment instead.
157 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
158
a5bd5abb
JD
1592013-08-13 Jan Djärv <jan.h.d@swipnet.se>
160
161 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
162 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
163
66e7901a
LMI
1642013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
165
166 * image.c (imagemagick_filename_hint): Check for errors in the
167 alist structure.
168
2fa611b7
EZ
1692013-08-13 Eli Zaretskii <eliz@gnu.org>
170
171 * window.c (Fwindow_margins): Return nil when there's no marginal
172 area, as per the documented API.
173
174 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
175 Fmake_vector, as scroll bar's struct members are not all Lisp
176 objects now. This avoids crashes in GC.
177
178 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
179 bool, so its address could be taken.
180
8259030d
LMI
1812013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
182
183 * image.c (imagemagick_filename_hint): New function to possibly
184 apply `image-content-type-suffixes'.
185 (imagemagick_load_image): Use it.
186
866c710e
EZ
1872013-08-13 Eli Zaretskii <eliz@gnu.org>
188
189 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
190 if loading zlib failed.
191
f10490f0
JD
1922013-08-13 Jan Djärv <jan.h.d@swipnet.se>
193
96311be7
JD
194 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
195 2013-08-13 checkin below. Change bool to BOOL, rule is:
196 All Obj-C code uses BOOL, except for interfaces callable from C.
197
f10490f0
JD
198 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
199
c8ae93b0
DA
2002013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
201
202 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
203 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
204 bool instead of BOOL.
205 * w32term.h (struct scroll_bar): Convert fringe_extended_p
206 from Lisp_Object to bitfield. Adjust comment.
207 * w32term.c (x_scroll_bar_create): Adjust user.
208 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
209 * xterm.c (XTset_vertical_scroll_bar): Likewise.
210 Use bool for boolean.
211 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
212 to `unsigned int' when defining a bitfield.
213
53b64418
PE
2142013-08-13 Paul Eggert <eggert@cs.ucla.edu>
215
216 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
217
eeaf9bf3
DA
2182013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
219
220 * window.h (struct window): Convert left_margin_cols and
221 right_margin_cols from Lisp_Objects to integers. Adjust comment.
222 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
223 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
224 Adjust users.
225 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
226 Adjust comment.
227 (showing_window_margins_p, update_window_line, update_frame_1):
228 * fringe.c (draw_fringe_bitmap_1):
229 * xdisp.c (window_box_width): Adjust users.
230 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
231 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
232 Use direct assignment.
233 (Fset_window_configuration, save_window_save, Fwindow_margins):
234 Convert Lisp_Object to integer and back where appropriate.
235 (Fset_window_margins): Adjust user. Return t if any margin
236 was actually changed, and mention this in docstring.
237
956720af
XF
2382013-08-13 Xue Fuqiao <xfq.free@gmail.com>
239
f73f4ce6 240 * syntax.c (forward_word):
956720af
XF
241 * cmds.c (forward_char, backward_char): Mention the optional argument.
242
9e37ee3b
DA
2432013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
244
245 * window.h (struct window): Convert left_fringe_width
246 and right_fringe_width from Lisp_Objects to integers.
247 Adjust comment.
248 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
249 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
250 * window.c (wset_left_fringe_width, wset_right_fringe_width):
251 Remove.
252 (make_window): Initialize new integer fields to -1.
253 (Fsplit_window_internal): Use direct assignment.
254 (Fset_window_configuration, save_window_save): Convert
255 Lisp_Object to integer and back where appropriate.
256 (Fset_window_fringes): Adjust user. Return t if any fringe
257 was actually changed, and mention this in docstring.
258
e4375ca7
DA
2592013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
260
261 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
262 * nsfns.m (x_set_cursor_type):
263 * w32fns.c (x_set_cursor_type):
264 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
265 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 266
a45543bc
DA
2672013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
268
269 * font.c (clear_font_cache): New function, stripped from...
270 (Fclear_font_cache): ...here, which now uses the function
271 above. Adjust comment.
272 * font.h (clear_font_cache): Add prototype.
273 * xfaces.c (clear_face_cache): Use clear_font_cache.
274
ae966a86
DA
2752013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
276
277 * window.c (Fset_window_start): Compare `w', not `window' because
278 `w' might not be equal to `window' after call to decode_live_window.
279
297a545b
PE
2802013-08-12 Paul Eggert <eggert@cs.ucla.edu>
281
282 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
283 This fixes a problem introduced by the Bug#15035 patch
284 when using GPG. Reported by Herbert J. Skuhra.
285
aa942e2b
EZ
2862013-08-12 Eli Zaretskii <eliz@gnu.org>
287
288 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
289 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
290 not yet initialized.
291
7699d09e
LMI
2922013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
293
294 * decompress.c (Fzlib_decompress_region): Support zlib
295 decompression, too, and rename.
296
1d238bc7
PE
2972013-08-12 Paul Eggert <eggert@cs.ucla.edu>
298
299 Minor zlib configuration tweaks.
300 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
301 Don't assume presence of fn_inflateInit2_ zlib internal function.
302
8a44a184
LMI
3032013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
304
305 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
306 include the zlib prefix.
307
594a4307
EZ
3082013-08-12 Eli Zaretskii <eliz@gnu.org>
309
310 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
311 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
312 define static variables that are pointers to zlib functions to be
313 dynamically loaded.
314 (init_zlib_functions) [WINDOWSNT]: New function.
315 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
316 New macros.
317 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
318 macros instead of invoking the zlib functions directly.
319 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
320 Szlib_available_p.
321
d2e113bc
DA
3222013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
323
324 Avoid looping over all frame windows to freeze and unfreeze.
325 * window.h (struct window): Drop frozen_window_start_p.
326 (freeze_window_starts): Drop prototype.
327 * frame.h (struct frame): New frozen_window_starts flag.
328 (FRAME_WINDOWS_FROZEN): New macro.
329 * window.c (freeze_window_start, freeze_window_starts):
330 Remove.
331 (select_window, replace_window): Adjust users.
332 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
333 (window_frozen_p): New function.
334 (redisplay_window): Use it.
335
94fcd171
PE
3362013-08-12 Paul Eggert <eggert@cs.ucla.edu>
337
338 Fix some fd issues when running subprocesses (Bug#15035).
339 Fix bugs that can leak files or file descriptors on errors.
340 Don't unlink open temp files, as that's hard for users to diagnose
341 when things go awry (e.g., temp disk exhausted).
342 Don't bother to lock temp files. Check for invalid recursion.
343 * callproc.c (synch_process_fd): Remove. All uses removed.
344 (synch_process_tempfile): New var or macro.
345 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
346 New constants.
347 (record_kill_process): New arg, the temp name. All callers changed.
348 (delete_temp_file): Now just a simple wrapper around unlink.
349 (call_process_kill): New arg, the call_process_fd array.
350 Close them all. Clear synch_process_pid. Remove the temp file,
351 or arrange for it to be removed.
352 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
353 that's been moved to synch_process_tempfile. Caller changed.
354 Do not remove the tempfile; that's now call_process_kill's
355 responsibility.
356 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
357 call_process_kill; the caller now does that.
358 (call_process_cleanup): Do not close the process fd; that's now
359 call_process_kill's responsibility.
360 (Fcall_process): Implement via new function call_process, which
361 has most of the old body of Fcall_process, but with a different API.
362 (call_process): New function that does not open or close filefd if
363 it is nonnegative. Record which fds need to be closed, and let
364 call_process_kill close (and remove the tempfile, on MSDOS) on error.
365 Signal an error if invoked recursively (could be done via a hook).
366 Simplify creation of the tempfile in the MSDOS case.
367 Don't create the output file until after checking for the executable.
368 Report any failure to open /dev/null.
369 Don't open /dev/null for writing twice; once is enough.
370 Don't create pipe if all output is being discarded or sent to file.
371 Don't worry about setting up the coding system or reading from the
372 pipe if all output is being discarded.
373 Hoist fd_error local into top level, to lessen block nesting.
374 Don't record deleted pid here; now done by Fcall_process_region.
375 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
376 and note its success in synch_process_tempfile.
377 Do not leak resources when child_setup fails.
378 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
379 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
380 (create_temp_file): Now returns open fd, with an additional
381 Lisp_Object * argument to return the name. All callers changed.
382 Do not close the file; rewind it instead, and leave it open for
383 the caller. Do not lock the temp file. Unwind-protect the file
384 and the file-descriptor.
385 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
386 If an asynchrounous process, record it here, not in call_process.
387 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
388 * eval.c (set_unwind_protect): New function.
389 * fileio.c (write_region): New function, generalized from the
390 old Fwrite_region. Do not lock temp files.
391 (Fwrite_region): Use it.
392 * lisp.h (set_unwind_protect, write_region): New decls.
393 * process.c: Include <verify.h>.
394 (make_process): Mark fds as initially closed.
395 (deleted_pid_list): Now a list of pid-filename pairs.
396 All uses changed.
397 (close_process_fd): New function.
398 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
399 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
400 New constants. Verify that their number matches PROCESS_OPEN_FDS.
401 (create_process, create_pty, Fmake_serial_process)
402 (server_accept_connection): Record which fds need to be closed,
403 and let deactivate_process close them.
404 (Fmake_network_process): Do not discard the unwind-protect
405 until it's safe to do so.
406 (deactivate_process): Close the fds opened by create_process etc.
407 (Fprocess_send_eof): Adjust to new way of recording open fds.
408 Report an error if /dev/null can't be opened, instead of aborting.
409 * process.h (PROCESS_OPEN_FDS): New constant.
410 (struct Lisp_Process): New member open_fds.
411 (record_kill_process, record_deleted_pid): Adjust signatures.
412 (record_deleted_pid): Move decl here ...
413 * syswait.h (record_deleted_pid): ... from here.
414
d0e615c3
PE
4152013-08-11 Paul Eggert <eggert@cs.ucla.edu>
416
417 * decompress.c: Fix bugs with large buffers and weird inputs.
418 Tune a bit. Reindent as per usual Emacs style.
419 (BUFFER_SIZE): Remove.
420 (Fdecompress_gzipped_region): Do not mishandle input buffers with
421 more than UINT_MAX bytes. Decompress into the gap instead of into
422 an auto buffer, as this should avoid copying. Return nil if
423 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
424 set immediate_quit; we shouldn't trust zlib code that much.
425
313546eb
LMI
4262013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
427
99a32242
LMI
428 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
429 errors, and really move the gap to where we want it.
430
313546eb
LMI
431 * lisp.h: Include decompress.c support.
432
433 * emacs.c (main): Include decompress.c support.
434
435 * Makefile.in: Include -lz if present.
436
d2d699ac
JD
4372013-08-11 Jan Djärv <jan.h.d@swipnet.se>
438
f90e3ebd
JD
439 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
440 (initWithTitle:): Initialize frame to 0.
441 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
442 (fillWithWidgetValue:frame:): Renamed from
443 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
444
445 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
446 fillWithWidgetValue:frame:
447
423d3b3f
JD
448 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
449 remove memory leak warnings.
450
d2d699ac
JD
451 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
452 (ns_check_menu_open): Handle menu == nil. Remove assignment to
453 menu_pending_title.
454
455 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
456 (x_activate_menubar): Update the whole menu.
457 (trackingNotification:): Call ns_check_menu_open if tracking ends.
458 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
459 current event is not NSSystemDefined (Bug#15001).
460 Call ns_check_menu_open only if trackingMenu is 2.
461 (menuDidClose:): New method, decrease trackingMenu.
462 (fillWithWidgetValue:setDelegate:): New method.
463 (fillWithWidgetValue:): Call the above.
464
465 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
466
7d652d97
PE
4672013-08-11 Paul Eggert <eggert@cs.ucla.edu>
468
469 Omit some unnecessary casts.
470 Many of these go back to the old pre-C89 days, when they may have
471 been needed, but we've been assuming C89 or later for a while now.
472 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
473 (live_float_p, live_misc_p, live_vector_p):
474 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
475 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
476 (defvar_per_buffer):
477 * callint.c (Fcall_interactively):
478 * doc.c (Fsubstitute_command_keys):
479 * filelock.c (get_boot_time):
480 * frame.c (xrdb_get_resource):
481 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
482 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
483 (xg_get_file_name_from_selector, menuitem_destroy_callback)
484 (menuitem_highlight_callback, menu_destroy_callback)
485 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
486 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
487 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
488 (xg_tool_bar_help_callback, tb_size_cb):
489 * image.c (xpm_alloc_color, png_read_from_memory)
490 (png_read_from_file, png_load_body, our_memory_skip_input_data)
491 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
492 (syms_of_image):
493 * keymap.c (describe_map):
494 * nsfns.m (Fns_display_monitor_attributes_list):
495 * nsmenu.m (process_dialog:):
496 * nsterm.m (hold_event):
497 * process.c (wait_reading_process_output):
498 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
499 * scroll.c (do_direct_scrolling, scrolling_1):
500 * termcap.c (tgetent):
501 * window.c (check_window_containing, add_window_to_list)
502 (freeze_window_starts):
503 * xdisp.c (compare_overlay_entries, vmessage):
504 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
505 (x_get_monitor_attributes_xrandr)
506 (Fx_display_monitor_attributes_list, x_display_info_for_name)
507 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
508 * xfont.c (xfont_match, xfont_open):
509 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
510 (menubar_selection_callback, menu_position_func)
511 (popup_selection_callback, create_and_show_popup_menu)
512 (dialog_selection_callback, create_and_show_dialog):
513 * xrdb.c (x_get_string_resource):
514 (main) [TESTRM]:
515 * xsmfns.c (x_session_check_input):
516 * xterm.c (x_draw_glyphless_glyph_string_foreground)
517 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
518 (xaw_jump_callback, xaw_scroll_callback):
519 Omit unnecessary casts.
520
9acc1074
PE
5212013-08-10 Paul Eggert <eggert@cs.ucla.edu>
522
523 Minor string-length refactoring.
524 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
525 * frame.c (make_monitor_attribute_list):
526 Prefer build_string to strlen + make_string.
527
361c0eb8
JD
5282013-08-10 Jan Djärv <jan.h.d@swipnet.se>
529
530 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
531 don't check minor_code (Bug#14417).
532
14ba0822
EZ
5332013-08-09 Eli Zaretskii <eliz@gnu.org>
534
535 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
536 vertical positions instead. This avoids calling MATRIX_ROW with
537 row numbers that are possibly beyond valid limits. (Bug#15064)
538
309f24d1
DA
5392013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
540
541 Use xstrdup and build_unibyte_string where applicable.
542 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
543 * xfns.c (x_window):
544 * xrdb.c (x_get_customization_string):
545 * xterm.c (xim_initialize):
546 * w32fns.c (w32_window): Use xstrdup.
547 (w32_display_monitor_attributes_list):
548 * emacs.c (init_cmdargs):
549 * keyboard.c (PUSH_C_STR):
550 * nsfont.m (nsfont_open):
551 * sysdep.c (system_process_attributes):
552 * w32.c (system_process_attributes):
553 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
554
55902276
EZ
5552013-08-09 Eli Zaretskii <eliz@gnu.org>
556
557 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
558 variables of these types so that GDB would know about them, as aid
559 for debugging fatal exceptions. (Bug#15024) See also
560 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
561 discussions.
562
10bf7f5a
JD
5632013-08-08 Jan Djärv <jan.h.d@swipnet.se>
564
565 * nsterm.m (ns_update_begin): Don't change clip path if it would be
566 larger than the NSWindow (Bug#14934).
567
65620264
DA
5682013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
569
570 Redesign redisplay interface to drop global variable updated_window.
571 Always pass currently updated window as a parameter to update routines.
572 * dispextern.h (updated_window): Remove declaration.
573 (struct redisplay_interface): Pass window parameter to
574 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
575 and after_update_window_hook.
576 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
577 Adjust prototypes.
578 * dispnew.c (updated_window): Remove.
579 (redraw_overlapped_rows, update_marginal_area, update_text_area)
580 (update_window_line): Adjust to match redisplay interface changes.
581 * nsterm.m (ns_update_window_begin, ns_update_window_end)
582 (ns_scroll_run, ns_after_update_window_line):
583 * w32term.c (x_update_window_begin, x_update_window_end)
584 (x_after_update_window_line, x_scroll_run):
585 * xterm.c (x_update_window_begin, x_update_window_end)
586 (x_after_update_window_line, x_scroll_run):
587 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
588 Likewise. Adjust comments where appropriate.
589 (x_cursor_to): Simplify because this is always called during window
590 update (but install debugging check anyway).
591 (expose_window): Check must_be_updated_p flag to see whether this
592 function is called during window update.
593
628fdc56
DA
5942013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
595
596 Do not reset window modification event counters excessively.
597 These leftovers and poor man's tricky methods to catch extra
598 redisplay's attention are no longer needed.
599 * frame.c (set_menu_bar_lines_1):
600 * minibuf.c (read_minibuf_unwind):
601 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
602 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
603 (window_scroll_line_based, Fset_window_configuration):
604 * xdisp.c (redisplay_window): Do not reset last_modified and
605 last_overlay_modified counters.
606
8fd9c92e
JD
6072013-08-07 Jan Djärv <jan.h.d@swipnet.se>
608
609 * xselect.c (x_send_client_event): Set send_event and serial, memset
610 data.l as it might be bigger than data.b. Use 24 bit mask to
611 XSendEvent (Bug#15034).
612
0ee18172
EZ
6132013-08-07 Eli Zaretskii <eliz@gnu.org>
614
615 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
616 for TTY frames that are not the top frame on their console.
617 (Bug#14616)
618
16ddd1a6
MR
6192013-08-07 Martin Rudalics <rudalics@gmx.at>
620
621 * w32term.c (w32fullscreen_hook): Really maximize frame when
622 asked for (Bug#14841).
623
d2a95ffb
DA
6242013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
625
626 Prefer selected_window to Fselected_window, likewise for frames.
627 * buffer.c (Fbuffer_swap_text):
628 * data.c (Fvariable_binding_locus):
629 * window.c (run_window_configuration_change_hook): Adjust users.
630 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
631 Use decode_live_frame.
632
170da1ec
DA
6332013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Be more careful if selected window shows the buffer other than current,
636 use window_outdated only if this is not so. This change should also
637 address some weird issues discussed in Bug#13012.
638 * window.h (window_outdated): New prototype.
639 * window.c (window_outdated): Now here. Convert from static and
640 always assume window's buffer.
641 (Fwindow_end, Fwindow_line_height): Use it.
642 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
643 and always assume window's buffer.
644 (redisplay_window): Adjust user.
e5eefe9b 645 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
646 check whether mode line should be updated only if selected window
647 shows current buffer.
648 (run_window_scroll_functions): Use eassert for debugging check.
649 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
650
56b5d5b1
DA
6512013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
652
653 * window.c (window_scroll, window_scroll_pixel_based)
654 (window_scroll_line_based): Use bool for booleans.
655
2878ba7e
PE
6562013-08-06 Paul Eggert <eggert@cs.ucla.edu>
657
658 * process.c: Fix minor off-by-one issues in descriptor counts.
659 This shouldn't fix any real bugs, but it cleans up the code a bit.
660 (max_process_desc, max_input_desc): -1, not 0, means none.
661 All uses changed.
662 (delete_input_desc): New function.
663 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
664 (deactivate_process): Scan backwards when recomuting max_process_desc;
665 that should be faster.
666 (init_process_emacs): Initialize max_input_desc.
667
e30b79c1
DA
6682013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
669
670 Use region cache to speedup bidi_find_paragraph_start.
671 * buffer.h (struct buffer): New member bidi_paragraph_cache.
672 Rename cache_long_line_scans to cache_long_scans.
673 * buffer.c (bset_cache_long_line_scans): Rename to
674 bset_cache_long_scans.
675 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
676 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
677 into account.
678 (syms_of_buffer): Rename cache-long-line-scans to
679 cache-long-scans. Adjust docstring.
680 * search.c (newline_cache_on_off):
681 * indent.c (width_run_cache_on_off): Adjust users.
682 * bidi.c (bidi_paragraph_cache_on_off): New function.
683 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
684 * insdel.c (prepare_to_modify_buffer): Invalidate
685 bidi_paragraph_cache if enabled.
686
00012b86
DA
6872013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
688
689 Invalidate region caches only if buffer text is going to be changed.
690 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
691 (modify_text): ...new prototype.
692 (prepare_to_modify_buffer_1): New prototype.
693 * textprop.c (modify_region): Rename to...
694 (modify_text_properties): ...new function.
695 (add_text_properties_1, set_text_properties, Fremove_text_properties)
696 (Fremove_list_of_text_properties): Adjust users.
697 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
698 (modify_text): ...new function.
699 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
700 (prepare_to_modify_buffer_1): ...new function.
701 * casefiddle.c (casify_region):
702 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
703 (Ftranspose_regions): Use modify_text.
704
dc6c0eda
SM
7052013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
706
707 * lisp.mk (lisp): Add nadvice.elc.
708
8f3a2c26
DA
7092013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
710
711 New macro to iterate over live buffers similar to frames.
712 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
713 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
714 Declare buffer-related variables here to offload lisp.h.
715 * buffer.c (Vbuffer_alist): Adjust comment.
716 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
717 (other_buffer_safely):
718 * data.c (store_symval_forwarding):
719 * dispnew.c (Fframe_or_buffer_changed_p):
720 * fileio.c (Fdo_auto_save):
721 * filelock.c (unlock_all_files):
722 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
723
e0fdb694
PE
7242013-08-04 Paul Eggert <eggert@cs.ucla.edu>
725
726 Fix some minor races in hosts lacking mkostemp (Bug#15015).
727 * callproc.c (create_temp_file):
728 * filelock.c (create_lock_file):
729 Assume mkostemp, since it's now provided by Gnulib.
730
63f5c6c2
EZ
7312013-08-04 Eli Zaretskii <eliz@gnu.org>
732
733 * w32.c (mkostemp): New function.
734 (mktemp): Remove, no longer used. Most of the code reused in
735 mkostemp. (Bug#15015)
484ab239 736 (mktemp): Don't undef.
63f5c6c2 737
f0b79313
DA
7382013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
739
740 * dispnew.c (glyph_matrix_count, glyph_pool_count):
741 Move under GLYPH_DEBUG and ENABLE_CHECKING.
742 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
743 (free_glyph_pool, check_glyph_memory): Likewise for
744 all users. Adjust comments where appropriate.
745
98f638d6
PE
7462013-08-03 Paul Eggert <eggert@cs.ucla.edu>
747
748 * composite.h: Minor fixups.
749 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
750 to fix a misspelling, and change it to an inline function while
751 we're at it (it need not be a macro). All uses changed.
752 (composition_method, composition_valid_p):
753 Rewrite to avoid assignments in if-conditions.
754
75c59fb3
DA
7552013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Do not use global Lisp_Object in composition macros.
758 * composite.h (composition_temp): Remove declaration.
759 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
760 (composition_method, composition_valid_p): ...inline functions.
416a3e01 761 (compose_region): Remove the leftover.
75c59fb3
DA
762 * composite.c (composition_temp): Remove.
763 (run_composition_function, update_compositions)
764 (composition_compute_stop_pos, composition_adjust_point)
765 (Ffind_composition_internal):
766 * coding.c (handle_composition_annotation):
767 * xdisp.c (handle_composition_prop, check_point_in_composition):
768 Related users changed.
769
a10c8269
DA
7702013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
771
772 Drop FRAME_PTR typedef.
773 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
774 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
775 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
776 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
777 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
778 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
779 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
780 All related users changed.
781
a104f656
SM
7822013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
783
784 * eval.c (default_toplevel_binding): New function.
785 (Fdefvar): Use it.
786 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
787 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
788 (syms_of_eval): Export them.
789 * data.c (Fdefault_value): Micro cleanup.
790 * term.c (init_tty): Use "false".
791
4b5c9326
DA
7922013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
793
794 Fix X GC leak in GTK and raw (no toolkit) X ports.
795 * xterm.c (x_free_frame_resources): If white and black relief
796 GCs are allocated, always free them here.
797 * xfns.c (x_make_gc): Omit redundant initialization.
798 * widget.c (create_frame_gcs): Remove the leftover.
799 (EmacsFrameDestroy): Do nothing because all GCs are now freed
800 in x_free_frame_resources.
801
b19aa636
JD
8022013-08-02 Jan Djärv <jan.h.d@swipnet.se>
803
804 * nsterm.m (windowWillResize:toSize:): Only change title if
805 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
806 modifying it.
807 (viewDidEndLiveResize): New method.
808
809 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
810 inside NS_IMPL_COCOA.
811
af1f7e06
DA
8122013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
813
814 * insdel.c (adjust_after_replace, replace_range, del_range_2):
815 Do not check whether undo is enabled because record_insert and
816 record_delete does that themselves.
817
65b02bb9
DA
8182013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
819
820 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
821 member which is not really used any more.
822 (FRAME_XIC_BASE_FONTNAME): Remove.
823 * xfns.c (xic_free_fontset): Adjust user.
824 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
825 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
826 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
827 (xdialog_show): Use eassert for debugging check.
7ee0f047 828 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 829
6318cde0
PE
8302013-08-01 Paul Eggert <eggert@cs.ucla.edu>
831
832 * fileio.c, fns.c (merge): Move extern decl from here ...
833 * lisp.h (merge): ... to here.
834
6c1a09ba
DA
8352013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
836
837 Fix last font-related change.
838 * w32font.h (w32font_list_internal, w32font_match_internal):
839 Fix prototype.
840 * w32uniscribe.c (uniscribe_list, uniscribe_match):
841 (uniscribe_list_family): Adjust to match font API change.
842 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
843 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
844
f8c20208
DA
8452013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
846
847 * frame.h (FRAME_MOUSE_UPDATE):
848 * nsterm.m (ns_frame_up_to_date): Omit redundant check
849 whether hlinfo->mouse_face_mouse_frame is non-NULL.
850
fdb396e2
DA
8512013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
852
853 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
854 * font.h (struct font_driver): Change list, match, and list_family
855 functions to accept struct frame * as first arg.
856 * font.c (font_score, font_compare, font_sort_entities): Remove
857 prototypes.
858 (font_sort_entities, font_list_entities, font_select_entity):
859 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
860 match font API change.
861 * xfont.c (xfont_list, xfont_match, xfont_list_family):
862 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
863 * ftxfont.c (ftxfont_list, ftxfont_match):
864 * xftfont.c (xftfont_list, xftfont_match):
865 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
866 * w32font.c (w32font_list, w32font_match, w32font_list):
867 (w32font_list_internal, w32_font_match_internal): Likewise.
868 * xfaces.c (Fx_family_fonts): Adjust user.
869
52b8a085
DA
8702013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
871
872 Do not use pure Xism x_wm_set_icon_position in non-X ports.
873 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
874 only if HAVE_X_WINDOWS is in use.
875 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
876 * nsterm.m (x_wm_set_icon_position): Remove no-op.
877 * w32term.c (x_wm_set_icon_position): Likewise.
878 * w32fns.c (x_icon): Adjust user.
879
c791c18e
DA
8802013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
881
882 * xterm.c (last_mouse_press_frame): Remove the
883 leftover which is not really used any more.
884 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
885 (x_flush): Call XFlush once per each X display, not frame.
886 This is better because this code always unconditionally skips
887 non-X frames in Vframe_list and issues the only XFlush if we
888 have more than one X frame on the same X display.
2f935d86
DA
889 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
890 Use bool for booleans.
891 (x_draw_glyph_string_background, cvt_string_to_pixel):
892 (cvt_pixel_dtor): Drop unnecessary prototypes.
893 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 894
f435830e
DA
8952013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
896
897 Drop unnecessary functions that deals with frame pixel size.
898 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
899 (x_pixel_height): Drop prototypes.
900 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
901 (x_pixel_height): Drop implementations.
902 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
903 which should be always valid for window frame.
904 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
905 * w32menu.c (Fx_popup_dialog):
906 * xmenu.c (Fx_popup_dialog): Likewise for both.
907
84231434
DA
9082013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
909
910 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
911 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
912 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
913 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
914 and mention nil frame in docstring.
84231434 915
959067a1
DA
9162013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
917
918 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
919 (x_figure_window_size): Likewise. Adjust to return long.
920 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
921 (toplevel): Move Qterminal_live_p to...
922 * terminal.c (toplevel): ...here, make it static, and...
923 (syms_of_terminal): ...DEFSYM here.
924 * frame.h (Qterminal_live_p): Remove declaration.
925 (make_frame, x_figure_window_size): Adjust prototype.
926 * nsfns.m (Fx_create_frame): Use long for window flags.
927
f4b169ce
PE
9282013-07-30 Paul Eggert <eggert@cs.ucla.edu>
929
930 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
931 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
932 Do not assume that emacs_close (INT_MAX) is a no-op.
933
bee6a2c7
DA
9342013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
935
936 * xfaces.c (make_face_cache): For struct face_cache, prefer
937 xmalloc to xzalloc and so avoid redundant call to memset.
938 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
939
d7e6881a
DA
9402013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
941
942 * fringe.c (draw_window_fringes, update_window_fringes)
943 (compute_fringe_widths):
944 * w32term.c (x_draw_glyph_string):
945 * window.c (candidate_window_p, Frecenter):
946 * xfaces.c (realize_basic_faces, realize_default_face)
947 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
948 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
949 * xfns.c (x_set_cursor_color, xic_free_xfontset):
950 * xmenu.c (Fx_menu_bar_open_internal):
951 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
952 * xsettings.c (xft_settings_event):
953 * xterm.c (x_draw_glyph_string, x_had_errors_p):
954 Use bool for booleans. Adjust style and comments where
955 appropriate.
956 * dispextern.h (draw_window_fringes, update_window_fringes)
957 (compute_fringe_widths):
958 * xterm.h (x_had_errors_p): Adjust prototype.
959
ec3058af
DA
9602013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
961
962 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
963 CHECK_LIST. Rewrite the loop to avoid useless local variable.
964
218e0637
DA
9652013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
966
967 * fns.c (toplevel): Remove comment before Fsafe_length because
968 it checks for QUIT.
969
e560aba9
PE
9702013-07-28 Paul Eggert <eggert@cs.ucla.edu>
971
972 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
973
2e5ce5de
EZ
9742013-07-28 Eli Zaretskii <eliz@gnu.org>
975
976 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
977 frame which got the message is still alive, before dereferencing
978 its pointer. (Bug#14970)
979
980 * frame.c (delete_frame): Test "this" frame's minibuffer window to
981 be a live window, before using it as such. (Bug#14970)
982
e95da6d3
EZ
9832013-07-27 Eli Zaretskii <eliz@gnu.org>
984
985 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
986 w32_detect_focus_change instead of doing part of its job by hand.
987 This fixes the problem whereby FOCUS_OUT events were not sent to
988 the event queue.
989
a8f93651
EZ
9902013-07-26 Eli Zaretskii <eliz@gnu.org>
991
fec92060
EZ
992 * process.c (Fprocess_list): Doc fix.
993
a8f93651
EZ
994 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
995 being re-exposed only if it didn't ask to become visible.
996 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
997 was previously iconified. (Bug#14841)
998 (x_iconify_frame): Mark the frame iconified.
999
d5a7a9d9
PE
10002013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1001
1002 Fix minor problems found by static checking.
1003 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1004 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1005
56ea7291
SM
10062013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1007
1008 * eval.c (set_specpdl_old_value): New function.
1009 (unbind_to): Minor simplification.
1010 (get_backtrace_frame): New function.
1011 (Fbacktrace_frame): Use it. Add `base' argument.
1012 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1013 (syms_of_eval): Export backtrace-eval.
1014 * xterm.c (x_focus_changed): Simplify.
1015
9d611ffe
PE
10162013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1019
999c74e3
EZ
10202013-07-24 Eli Zaretskii <eliz@gnu.org>
1021
1022 * xdisp.c (redisplay_window): Instead of moving point out of
1023 scroll margin, reject the force_start method, and try scrolling
1024 instead. (Bug#14780)
1025
198fa217
KB
10262013-07-24 Ken Brown <kbrown@cornell.edu>
1027
1028 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1029 (Bug#14944).
1030
53840e55
PE
10312013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1032
1033 * eval.c (Fprogn): Do not check that BODY is a proper list.
1034 This undoes the previous change. The check slows down the
1035 interpreter, and is not needed to prevent a crash. See
1036 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1037
60967f56
GM
10382013-07-23 Glenn Morris <rgm@gnu.org>
1039
1040 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1041
9ca960e2
PE
10422013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1043
a29c3e6d
PE
1044 Port to GNU/Linux systems with tinfo but not ncurses.
1045 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1046 to decide whether ncurses is being used. Without this change,
1047 GCC complains about tgetent not being declared, on a system
1048 that has tinfo installed but ncurses not installed.
1049
f274311c
PE
1050 * eval.c (Fprogn): Check that BODY is a proper list.
1051
16b0520a
PE
1052 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1053 * data.c (Fsetq_default):
1054 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1055 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1056 (Fcondition_case):
1057 Tune by taking advantage of the fact that ARGS is always a list
1058 when a function is declared to have UNEVALLED args.
1059
9ca960e2
PE
1060 * emacsgtkfixed.c: Port to GCC 4.6.
1061 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1062
afacaa1b
JB
10632013-07-23 Juanma Barranquero <lekktu@gmail.com>
1064
1065 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1066 here to silence compiler warnings.
1067
368a85a4
PE
10682013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1071 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1072 from messing up Emacs's 'struct frame' (Bug#14923).
1073
f4e891b5
PE
10742013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1075
1076 * alloc.c (make_save_ptr_ptr): Define this function.
1077 It was inadvertently omitted. It's needed only if
1078 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1079
96c8b65e
JD
10802013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1081
1082 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1083 frame have focus (Bug#14895).
1084
ee010797
PE
10852013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1086
1087 Avoid vfork-related deadlock more cleanly.
1088 * callproc.c (child_setup): When the child's exec fails, output
1089 the program name, as that's more useful. Use O_NONBLOCK to avoid
1090 deadlock.
1091 * process.c (create_process_1): Remove; no longer needed.
1092 (create_process): Remove timer hack; no longer needed, now that
1093 the child avoids deadlock.
1094
f0398ec1 10952013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1096
1097 * image.c (Fimage_flush): Fix doc typo.
1098
b2a069c2
PE
10992013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1100
6496aec9
PE
1101 Fix array bounds violation when pty allocation fails.
1102 * process.c (PTY_NAME_SIZE): New constant.
1103 (pty_name): Remove static variable; it's now auto.
1104 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1105 Take pty_name as an arg rather than using a static variable.
1106 All callers changed.
1107 (create_process): Recover pty_flag from process, not from volatile local.
1108 (create_pty): Stay inside array even when pty allocation fails.
1109 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1110
b2a069c2
PE
1111 * lread.c (Fload): Avoid initialization only when lint checking.
1112 Mention that it's needed only for older GCCs.
1113
99107004
KH
11142013-07-20 Kenichi Handa <handa@gnu.org>
1115
1116 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1117 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1118
6b1b199d
AS
11192013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1120
1121 * lread.c (Fload): Avoid uninitialized warning.
1122
4195afc3
PE
11232013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1124
3f5bef16
PE
1125 Fix some minor file descriptor leaks and related glitches.
1126 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1127 (create_lock_file): Use write, not emacs_write.
1128 * image.c (slurp_file, png_load_body):
1129 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1130 (server_accept_connection):
1131 Don't leak an fd on memory allocation failure.
1132 * image.c (slurp_file): Add a cheap heuristic for growing files.
1133 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1134 as that's what the other routines do. Maybe input need not be
1135 blocked at all, but it's better to be consistent.
1136 Avoid undefined behavior when strlen is zero.
1137
4195afc3
PE
1138 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1139 (NSTATICS): Now a constant; doesn't need to be a macro.
1140
a1aeeffe
RS
11412013-07-19 Richard Stallman <rms@gnu.org>
1142
1143 * coding.c (decode_coding_utf_8): Add simple loop for fast
1144 processing of ASCII characters.
1145
63b34baa
PE
11462013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1149
621dd9ac
EZ
11502013-07-19 Eli Zaretskii <eliz@gnu.org>
1151
1152 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1153 unportable 'struct x_display_info'.
1154 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1155 is a portable type.
1156
1396ac86
PE
11572013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1158
ab9980cd
PE
1159 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1160 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1161 or fscanf fails.
1162 (system_process_attributes): Prefer plain char to unsigned char
1163 when either will do. Clean up properly if interrupted or if
1164 memory allocations fail. Don't assume sscanf succeeds. Remove
1165 no-longer-needed workaround to stop GCC from whining. Read
1166 command-line once, instead of multiple times. Check read status a
1167 bit more carefully.
1168
1396ac86
PE
1169 Fix obscure porting bug with varargs functions.
1170 The code assumed that int is treated like ptrdiff_t in a vararg
1171 function, which is not a portable assumption. There was a similar
1172 -- though these days less likely -- porting problem with various
1173 assumptions that pointers of different types all smell the same as
1174 far as vararg functions is conserved. To make this problem less
1175 likely in the future, redo the API to use varargs functions.
1176 * alloc.c (make_save_value): Remove this vararg function.
1177 All uses changed to ...
1178 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1179 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1180 New functions.
1181 (make_save_ptr): Rename from make_save_pointer, for consistency with
1182 the above. Define only on platforms that need it. All uses changed.
1183
4d19d194
PE
11842013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 * keyboard.c: Try to fix typos in previous change.
1187 (DISPLAY_LIST_INFO): New macro.
1188 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1189 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1190
945c5bb1
JB
11912013-07-18 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * keyboard.c (kbd_buffer_get_event):
1194 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1195 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1196
f4b1eb36
PE
11972013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1198
5e679a2c
PE
1199 * filelock.c: Fix unlikely file descriptor leaks.
1200 (get_boot_time_1): Rework to avoid using emacs_open.
1201 This doesn't actually fix a leak, but is better anyway.
1202 (read_lock_data): Use read, not emacs_read.
1203
a8cd4836
PE
1204 * doc.c: Fix minor memory and file descriptor leaks.
1205 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1206 (get_doc_string, Fsnarf_documentation):
1207 Fix file descriptor leak on error.
1208
ef30e638
PE
1209 * term.c: Fix minor fdopen-related file descriptor leaks.
1210 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1211 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1212
f4b1eb36
PE
1213 * charset.c: Fix file descriptor leaks and errno issues.
1214 Include <errno.h>.
1215 (load_charset_map_from_file): Don't leak file descriptor on error.
1216 Use plain record_xmalloc since the allocation is larger than
1217 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1218 of entries.
1219 * eval.c (record_unwind_protect_nothing):
1220 * fileio.c (fclose_unwind):
1221 New functions.
1222 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1223 The replacement doesn't block input, but that no longer seems
1224 necessary.
1225
b648c163
PE
12262013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1227
a0931322
PE
1228 * lread.c: Fix file descriptor leaks and errno issues.
1229 (Fload): Close some races that leaked fds or streams when 'load'
1230 was interrupted.
1231 (Fload, openp): Report error number of last nontrivial failure to open.
1232 ENOENT counts as trivial.
1233 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1234 New functions.
1235 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1236 now that the function is always called with a nonnegative arg.
1237 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1238 All uses replaced with ...
1239 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1240
b648c163
PE
1241 A few more minor file errno-reporting bugs.
1242 * callproc.c (Fcall_process):
1243 * doc.c (Fsnarf_documentation):
1244 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1245 * process.c (set_socket_option):
1246 Don't let a constructor trash errno.
1247 * doc.c: Include <errno.h>.
1248
b1dc4084
JB
12492013-07-16 Juanma Barranquero <lekktu@gmail.com>
1250
1251 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1252
c43843aa
PE
12532013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1254
50a30cce
PE
1255 Fix w32 bug with call-process-region (Bug#14885).
1256 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1257 to Fcall_process when the input is empty. This simplifies the
1258 code a bit. It makes no difference on POSIXish platforms but
1259 apparently it fixes a bug on w32.
1260
44e18199 1261 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1262 * fileio.c (close_file_unwind): Don't close if FD is negative;
1263 this can happen when unwinding a zapped file descriptor.
1264 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1265 in case Emacs runs out of memory between the two unwind-protects.
1266 Don't trash errno when closing FD.
1267 Zap the FD in the specpdl when closing it, instead of deferring
1268 the removal of the unwind-protect; this fixes a bug where a child
1269 function unwinds the stack past us.
1270
27e498e6
PE
1271 New unwind-protect flavors to better type-check C callbacks.
1272 This also lessens the need to write wrappers for callbacks,
1273 and the need for make_save_pointer.
1274 * alloca.c (free_save_value):
1275 * atimer.c (run_all_atimers):
1276 Now extern.
1277 * alloc.c (safe_alloca_unwind):
1278 * atimer.c (unwind_stop_other_atimers):
1279 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1280 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1281 * minibuf.c (choose_minibuf_frame_1):
1282 * process.c (make_serial_process_unwind):
1283 * xdisp.h (pop_message_unwind):
1284 * xselect.c (queue_selection_requests_unwind):
1285 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1286 * alloca.c (record_xmalloc):
1287 Prefer record_unwind_protect_ptr to record_unwind_protect with
1288 make_save_pointer.
1289 * alloca.c (Fgarbage_collect):
1290 Prefer record_unwind_protect_void to passing a dummy.
1291 * buffer.c (restore_buffer):
1292 * window.c (restore_window_configuration):
1293 * xfns.c, w32fns.c (do_unwind_create_frame)
1294 New wrapper. All record-unwind uses of wrappee changed.
1295 * buffer.c (set_buffer_if_live):
1296 * callproc.c (call_process_cleanup, delete_temp_file):
1297 * coding.c (code_conversion_restore):
1298 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1299 * editfns.c (save_excursion_restore)
1300 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1301 (save_restriction_restore):
1302 * eval.c (restore_stack_limits, un_autoload):
1303 * fns.c (require_unwind):
1304 * keyboard.c (recursive_edit_unwind, tracking_off):
1305 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1306 * macros.c (pop_kbd_macro, restore_menu_items):
1307 * nsfns.m (unwind_create_frame):
1308 * print.c (print_unwind):
1309 * process.c (start_process_unwind):
1310 * search.c (unwind_set_match_data):
1311 * window.c (select_window_norecord, select_frame_norecord):
1312 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1313 (fast_set_selected_frame):
1314 * xfns.c, w32fns.c (unwind_create_tip_frame):
1315 Return void, not a dummy Lisp_Object. All uses changed.
1316 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1317 * callproc.c (call_process_kill):
1318 * fileio.c (restore_point_unwind, decide_coding_unwind)
1319 (build_annotations_unwind):
1320 * insdel.c (Fcombine_after_change_execute_1):
1321 * keyboard.c (read_char_help_form_unwind):
1322 * menu.c (unuse_menu_items):
1323 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1324 * sound.c (sound_cleanup):
1325 * xdisp.c (unwind_redisplay):
1326 * xfns.c (clean_up_dialog):
1327 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1328 Accept no args and return void, instead of accepting and returning
1329 a dummy Lisp_Object. All uses changed.
1330 * cygw32.c (fchdir_unwind):
1331 * fileio.c (close_file_unwind):
1332 * keyboard.c (restore_kboard_configuration):
1333 * lread.c (readevalllop_1):
1334 * process.c (wait_reading_process_output_unwind):
1335 Accept int and return void, rather than accepting an Emacs integer
1336 and returning a dummy object. In some cases this fixes an
1337 unlikely bug when the corresponding int is outside Emacs integer
1338 range. All uses changed.
1339 * dired.c (directory_files_internal_unwind):
1340 * fileio.c (do_auto_save_unwind):
1341 * gtkutil.c (pop_down_dialog):
1342 * insdel.c (reset_var_on_error):
1343 * lread.c (load_unwind):
1344 * xfns.c (clean_up_file_dialog):
1345 * xmenu.c, nsmenu.m (pop_down_menu):
1346 * xmenu.c (cleanup_widget_value_tree):
1347 * xselect.c (wait_for_property_change_unwind):
1348 Accept pointer and return void, rather than accepting an Emacs
1349 save value encapsulating the pointer and returning a dummy object.
1350 All uses changed.
1351 * editfns.c (Fformat): Update the saved pointer directly via
1352 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1353 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1354 (unwind_body): New function.
1355 (record_unwind_protect): First arg is now a function returning void,
1356 not a dummy Lisp_Object.
1357 (record_unwind_protect_ptr, record_unwind_protect_int)
1358 (record_unwind_protect_void): New functions.
1359 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1360 * fileio.c (struct auto_save_unwind): New type.
1361 (do_auto_save_unwind): Use it.
1362 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1363 * insdel.c (struct rvoe_arg): New type.
1364 (reset_var_on_error): Use it.
1365 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1366 New constants.
1367 (specbinding_func): Remove; there are now several such functions.
1368 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1369 (set_unwind_protect_ptr): New function.
1370 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1371
4e604a5d
PE
1372 Be simpler and more consistent about reporting I/O errors.
1373 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1374 Say "Read error" and "Write error", rather than "I/O error", or
1375 "IO error reading", or "IO error writing", when a read or write
1376 error occurs.
1377 * process.c (Fmake_network_process, wait_reading_process_output)
1378 (send_process, Fprocess_send_eof, wait_reading_process_output):
1379 Capitalize diagnostics consistently. Put "failed foo" at the
1380 start of the diagnostic, so that we don't capitalize the
1381 function name "foo". Consistently say "failed" for such
1382 diagnostics.
1383 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1384 All callers changed. This is so it can use report_file_error.
1385 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1386 diagnostics consistently as above.
1387
a9757f6a
PE
1388 * fileio.c (report_file_errno): Fix errno reporting bug.
1389 If the file name is neither null nor a pair, package it up as a
1390 singleton list. All callers changed, both to this function and to
1391 report_file_error. This fixes a bug where the memory allocator
1392 invoked by list1 set errno so that the immediately following
1393 report_file_error reported the wrong errno value.
1394
c43843aa
PE
1395 Fix minor problems found by --enable-gcc-warnings.
1396 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1397 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1398
18c26d81
JD
13992013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1400
1401 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1402 Set event->arg to Qt if switch-event shall be generated.
1403 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1404
1405 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1406
1407 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1408 FOCUS_OUT_EVENT.
1409
1410 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1411 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1412 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1413 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1414 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1415 and there is a focused frame.
1416 (head_table): Add focus-in and focus-out.
1417 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1418 bind to handle-focus-in/out.
1419
1420 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1421 (Fhandle_switch_frame): Call Fhandle_focus_in.
1422 (syms_of_frame): defsubr handle-focus-in/out.
1423
6c6f1994
PE
14242013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1425
c7ddc792
PE
1426 Fix porting bug to older POSIXish platforms (Bug#14862).
1427 * sysdep.c (emacs_pipe): New function, that implements
1428 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1429 This should port better to CentOS 5 and to Mac OS X 10.6.
1430 All calls to pipe2 changed.
1431
6c6f1994
PE
1432 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1433 This makes the code easier to read and the executable a bit smaller.
1434 Do not replace all calls to Fcons that happen to create lists,
1435 just calls that are intended to create lists. For example, when
1436 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1437 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1438 Similarly for list2 through list5.
1439 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1440 * bytecode.c (exec_byte_code):
1441 * callint.c (quotify_arg, Fcall_interactively):
1442 * callproc.c (Fcall_process, create_temp_file):
1443 * charset.c (load_charset_map_from_file)
1444 (Fdefine_charset_internal, init_charset):
1445 * coding.c (get_translation_table, detect_coding_system)
1446 (Fcheck_coding_systems_region)
1447 (Fset_terminal_coding_system_internal)
1448 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1449 * composite.c (update_compositions, Ffind_composition_internal):
1450 * dired.c (directory_files_internal, file_name_completion)
1451 (Fsystem_users):
1452 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1453 * doc.c (Fsnarf_documentation):
1454 * editfns.c (Fmessage_box):
1455 * emacs.c (main):
1456 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1457 (Feval, eval_sub, Ffuncall, apply_lambda):
1458 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1459 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1460 (Fset_file_times, Finsert_file_contents)
1461 (Fchoose_write_coding_system, Fwrite_region):
1462 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1463 * font.c (font_registry_charsets, font_parse_fcname)
1464 (font_prepare_cache, font_update_drivers, Flist_fonts):
1465 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1466 * frame.c (make_frame, Fmake_terminal_frame)
1467 (x_set_frame_parameters, x_report_frame_params)
1468 (x_default_parameter, Fx_parse_geometry):
1469 * ftfont.c (syms_of_ftfont):
1470 * image.c (gif_load):
1471 * keyboard.c (command_loop_1):
1472 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1473 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1474 (Fminor_mode_key_binding, accessible_keymaps_1)
1475 (Faccessible_keymaps, Fwhere_is_internal):
1476 * lread.c (read_emacs_mule_char):
1477 * menu.c (find_and_return_menu_selection):
1478 * minibuf.c (get_minibuffer):
1479 * nsfns.m (Fns_perform_service):
1480 * nsfont.m (ns_script_to_charset):
1481 * nsmenu.m (ns_popup_dialog):
1482 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1483 (Fx_own_selection_internal):
1484 * nsterm.m (append2):
1485 * print.c (Fredirect_debugging_output)
1486 (print_prune_string_charset):
1487 * process.c (Fdelete_process, Fprocess_contact)
1488 (Fformat_network_address, set_socket_option)
1489 (read_and_dispose_of_process_output, write_queue_push)
1490 (send_process, exec_sentinel):
1491 * sound.c (Fplay_sound_internal):
1492 * textprop.c (validate_plist, add_properties)
1493 (Fput_text_property, Fadd_face_text_property)
1494 (copy_text_properties, text_property_list, syms_of_textprop):
1495 * unexaix.c (report_error):
1496 * unexcoff.c (report_error):
1497 * unexsol.c (unexec):
1498 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1499 (Fformat_mode_line, syms_of_xdisp):
1500 * xfaces.c (set_font_frame_param)
1501 (Finternal_lisp_face_attribute_values)
1502 (Finternal_merge_in_global_face, syms_of_xfaces):
1503 * xfns.c (x_default_scroll_bar_color_parameter)
1504 (x_default_font_parameter, x_create_tip_frame):
1505 * xfont.c (xfont_supported_scripts):
1506 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1507 (menu_help_callback, xmenu_show):
1508 * xml.c (make_dom):
1509 * xterm.c (set_wm_state):
1510 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1511 and similarly for list2 through list5.
1512
bafe80ce
PE
15132013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1514
1515 * callproc.c (Fcall_process_region): Fix minor race and tune.
1516 (create_temp_file): New function, with the temp-file-creation part
1517 of the old Fcall_process_region. Use Fcopy_sequence to create the
1518 temp file name, rather than alloca + build_string, for simplicity.
1519 Don't bother to block input around the temp file creation;
1520 shouldn't be needed. Simplify use of mktemp. Use
1521 record_unwind_protect immediately after creating the temp file;
1522 this closes an unlikely race where the temp file was not removed.
1523 Use memcpy rather than an open-coded loop.
1524 (Fcall_process_region): Use the new function. If the input is
1525 empty, redirect from /dev/null rather than from a newly created
1526 empty temp file; this avoids unnecessary file system traffic.
1527
4700b5a5
PE
15282013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1529
5c97beae
PE
1530 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1531 Simplify by making this case like the other two. This is a bit
1532 slower on obsolete hosts, but the extra complexity isn't worth it.
1533
4700b5a5
PE
1534 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1535 * process.c (create_process) [!DOS_NT]:
1536 Remove now-unnecessary calls to emacs_close.
1537
f9a74c4c
EZ
15382013-07-13 Eli Zaretskii <eliz@gnu.org>
1539
922ae7ee
EZ
1540 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1541 returning early. (Bug#14850)
1542
f9a74c4c
EZ
1543 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1544 and inhibit-iso-escape-detection attributes of 'undecided'.
1545 (Bug#14822)
1546
5e301d76
PE
15472013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1548
69e0e5ee
PE
1549 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1550 Reported by Herbert J. Skuhra in
1551 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1552
5e301d76
PE
1553 Don't lose top specpdl entry when memory is exhausted.
1554 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1555 specpdl overflow here, to simplify callers; all callers changed.
1556 Always reserve an unused entry at the stack top; this avoids
1557 losing the top entry's information when memory is exhausted.
1558
7e649856
PE
15592013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1560
a773ed9a
PE
1561 Clean up errno reporting and fix some errno-reporting bugs.
1562 * callproc.c (Fcall_process):
1563 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1564 * process.c (create_process, Fmake_network_process):
1565 * unexaix.c (report_error):
1566 * unexcoff.c (report_error):
1567 Be more careful about reporting the errno of failed operations.
1568 The code previously reported the wrong errno sometimes.
1569 Also, prefer report_file_errno to setting errno + report_file_error.
1570 (Fcall_process): Look at openp return value rather than at path,
1571 as that's a bit faster and clearer when there's a numeric predicate.
1572 * fileio.c (report_file_errno): New function, with most of the
1573 old contents of report_file_error.
1574 (report_file_error): Use it.
1575 (Ffile_exists_p, Ffile_accessible_directory_p):
1576 Set errno to 0 when it is junk.
1577 * fileio.c (Faccess_file):
1578 * image.c (x_create_bitmap_from_file):
1579 Use faccessat rather than opening the file, to avoid the hassle of
1580 having a file descriptor open.
1581 * lisp.h (report_file_errno): New decl.
1582 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1583
7e649856
PE
1584 Minor EBADF fixes.
1585 * process.c (create_process, wait_reading_process_output) [AIX]:
1586 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1587 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1588 a multithreaded environment anyway).
1589 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1590
f6774c1a
AS
15912013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1592
1593 * image.c (x_find_image_file): Don't close a remote file handle.
1594
bacba3c2
PE
15952013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1596
1597 Fix races with threads and file descriptors.
1598 * callproc.c (Fcall_process_region):
1599 * dired.c (open_directory):
1600 * emacs.c (main, Fdaemon_initialized):
1601 * image.c (x_find_image_file):
1602 * inotify.c (Finotify_rm_watch):
1603 * lread.c (Flocate_file_internal):
1604 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1605 * term.c (term_mouse_moveto, init_tty):
1606 * termcap.c (tgetent):
1607 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1608 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1609 * unexhp9k800.c, unexmacosx.c (unexec):
1610 * callproc.c (Fcall_process_region):
1611 Use emacs_close, not close.
1612 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1613 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1614 and posix_close function on current platforms (which all lack them).
1615 (emacs_close): Use it. This should fix the races on GNU/Linux and
1616 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1617 and it should avoid closing random victim file descriptors on
1618 other platforms.
1619
653d4f43
PE
16202013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1621
c8536ec4
PE
1622 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1623 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1624 Touch up doc a bit.
1625
9c203066
PE
1626 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1627 This is for .gdbinit xbacktrace.
1628
653d4f43
PE
1629 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1630 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1631 (emacs_set_tty): Now static.
1632 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1633 * term.c (tty_capable_p, tty_default_color_capabilities)
1634 (get_tty_terminal, term_mouse_movement)
1635 (handle_one_term_event, init_tty, maybe_fatal):
1636 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1637 (tgetent, scan_file, name_match, compare_contin):
1638 * terminal.c (get_terminal):
1639 Use bool for boolean.
1640 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1641 Prefer char to unsigned char if either will do.
1642 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1643 (tty_write_glyphs): Prefer int to unsigned.
1644 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1645 All callers changed.
1646 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1647
45b683a1
PE
16482013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1649
29abe551
PE
1650 Port to C89.
1651 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1652 (B__dummy__): New dummy symbol, to pacify C89.
1653 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1654 they can't grok varargs macros.
1655 * dispnew.c (add_window_display_history)
1656 (add_frame_display_history):
1657 * print.c (print_object):
1658 * xdisp.c (debug_method_add):
1659 Use %p printf format only for void pointers.
1660 * emacs.c (usage_message): New constant, replacing ...
1661 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1662 (main): Adjust to usage reorg.
1663 * fns.c (syms_of_fns):
1664 * profiler.c (syms_of_profiler):
1665 Don't use non-constant struct initializers.
1666 * gnutls.h (gnutls_initstage_t):
1667 * lisp.h (enum Lisp_Fwd_Type):
1668 * lread.c (lisp_file_lexically_bound_p):
1669 * xsettings.c (anonymous enum):
1670 Remove trailing comma.
1671 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1672 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1673 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1674 (DEFUN): Use it.
1675 * regex.c (const_re_char): New type, to pacify strict C89.
1676 All uses of 'const re_char' replaced to use it.
1677 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1678 with glibc when strict C89. This change is imported from gnulib.
1679 All uses changed.
1680 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1681 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1682 Omit GNU_LINUX implementation, since it requires long long.
1683 * xterm.c (x_draw_underwave):
1684 Do not assume the traditional order of struct's members.
1685 (x_term_init): Rewrite to avoid the need for non-constant structure
1686 initializers.
1687
45b683a1 1688 Syntax cleanup, mostly replacing macros with functions.
763a086d 1689 This removes the need for the syntax_temp hack.
45b683a1
PE
1690 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1691 * syntax.c (SYNTAX_INLINE): New macro.
1692 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1693 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1694 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1695 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1696 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1697 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1698 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1699 Now constants, not macros.
1700 (syntax_temp) [!__GNUC__]: Remove.
1701 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1702 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1703 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1704 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1705 Move here from syntax.h; now functions, not macros. Except for the
1706 last function, these are static since only syntax.c uses them.
1707 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1708 All uses changed. Now a function, not a macro; use this fact
1709 to simplify the code.
1710 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1711 compiler bugs; no longer relevant.
1712 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1713 (SYNTAX_INLINE): New macro.
1714 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1715 for the new functions. Use bool for boolean member.
1716 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1717 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1718 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1719 (SETUP_BUFFER_SYNTAX_TABLE):
1720 Now extern inline functions, not macros.
1721 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1722 Remove; all uses replaced by implementation.
1723 (syntax_temp) [!__GNUC__]: Remove decl.
1724 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1725
29be4a50
JD
17262013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1727
1728 * emacs.c (main): Fix syntax error.
1729
954b166e
PE
17302013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 Timestamp fixes for undo (Bug#14824).
1733 * atimer.c (schedule_atimer):
1734 * fileio.c (Ffile_newer_than_file_p):
1735 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1736 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1737 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1738 (syms_of_fileio): Remove Sclear_visited_file_name.
1739 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1740 file doesn't exist; this avoids an ambiguity with negative timestamps.
1741 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1742 * systime.h (make_emacs_time, invalid_emacs_time):
1743 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1744 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1745 * undo.c (record_first_change): Push (visited-file-modtime) onto
1746 undo list rather than reimplementing it by hand, incorrectly.
1747
d74647c3
KB
17482013-07-09 Ken Brown <kbrown@cornell.edu>
1749
1750 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1751
3c51b96b
JB
17522013-07-09 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1755
4ebbdd67
PE
17562013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1757
1758 Handle errno and exit status a bit more carefully.
1759 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1760 number into an exit status. Instead, use EXIT_CANCELED.
1761 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1762 * callproc.c (relocate_fd):
1763 * emacs.c (close_output_streams, main):
1764 * process.c (create_process):
1765 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1766 Use emacs_perror for simplicity.
1767 * callproc.c (relocate_fd, main):
1768 * sysdep.c (sys_subshell):
1769 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1770 (shut_down_emacs): Use emacs_write, not write.
1771 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1772 * fileio.c (Fcopy_file, e_write):
1773 * nsterm.m (ns_select):
1774 * process.c (send_process):
1775 * sound.c (vox_write):
1776 Use emacs_write_sig, not emacs_write.
1777 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1778 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1779 New constants.
1780 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1781 of write.
1782 (emacs_full_write): New function.
1783 (emacs_write): Rewrite to use it.
1784 (emacswrite_sig, emacs_perror): New functions.
1785 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1786
44e18199 17872013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1788
1789 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1790 on NS even if it is present. Pixmap on NS is a void*.
1791
9caab067
PE
17922013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 Port to Ubuntu 10 (Bug#14803).
1795 Problem reported by T.V. Raman.
1796 * process.c (close_on_exec, accept4, process_socket):
1797 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1798
1d442672
EZ
17992013-07-07 Eli Zaretskii <eliz@gnu.org>
1800
1801 * w32.c (sys_dup): Declare prototype.
1802
1803 * filelock.c:
1804 * emacs.c:
1805 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1806
067428c1
PE
18072013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 Make file descriptors close-on-exec when possible (Bug#14803).
1810 This simplifies Emacs a bit, since it no longer needs to worry
1811 about closing file descriptors by hand in some cases.
1812 It also fixes some unlikely races. Not all such races, as
1813 libraries often open files internally without setting
1814 close-on-exec, but it's an improvement.
1815 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1816 * callproc.c (Fcall_process) [!MSDOS]:
1817 * emacs.c (main) [!DOS_NT]:
1818 * nsterm.m (ns_term_init):
1819 * process.c (create_process):
1820 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1821 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1822 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1823 Prefer mkostemp with O_CLOEXEC to mkstemp.
1824 * callproc.c (relocate_fd) [!WINDOWSNT]:
1825 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1826 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1827 now using pipe2.
1828 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1829 Make the resulting file descriptor close-on-exec.
1830 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1831 * lread.c (load_descriptor_list, load_descriptor_unwind):
1832 Remove; no longer needed. All uses removed.
1833 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1834 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1835 New functions.
1836 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1837 (Fmake_network_process, Fnetwork_interface_list):
1838 (Fnetwork_interface_info, server_accept_connection):
1839 Make newly-created socket close-on-exec.
1840 * sysdep.c (emacs_open, emacs_fopen):
1841 Make new-created descriptor close-on-exec.
1842 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1843 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1844
0da857dd
JD
18452013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1846
1847 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1848 for NS_IMPL_GNUSTEP.
1849
5f86adcd
PE
18502013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 Fix openp errno handling.
1853 * callproc.c (Fcall_process): Preserve openp errno around close.
1854 * lread.c (openp): Set errno when returning -1, as some callers
1855 expect this.
1856
1afb1d07
JD
18572013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1858
1859 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1860
1861 * nsterm.h (NSSavePanel): Update comment.
1862 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1863 (ns_run_file_dialog): Declare.
1864
1865 * nsfns.m: Remove panelOK.
1866 (ns_fd_data): New.
1867 (ns_run_file_dialog): New function.
1868 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1869 event loop, so file dialog is popped up by ns_run_file_dialog, called
1870 by sendEvent (Bug#14578).
1871 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1872
3323c263
EZ
18732013-07-06 Eli Zaretskii <eliz@gnu.org>
1874
fdda0220
EZ
1875 * xdisp.c (default_line_pixel_height): New function.
1876 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1877 (try_cursor_movement, redisplay_window, try_window)
1878 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1879
1880 * window.c (window_scroll_pixel_based): use
1881 default_line_pixel_height.
1882
1883 * dispextern.h (default_line_pixel_height): Add prototype.
1884
1885 * frame.c (x_set_line_spacing): Accept a float value for
1886 line-spacing parameter, per the documentation.
1887
3323c263
EZ
1888 * data.c (Fmultibyte_string_p): Doc fix.
1889
47ba6d43
PE
18902013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1891
406af475
PE
1892 Use emacs_open more consistently when opening files.
1893 This handles EINTR more consistently now, and makes it easier
1894 to introduce other uniform changes to file descriptor handling.
1895 * src/systdio.h: New file.
1896 * src/buffer.c (mmap_init):
1897 * cygw32.c (chdir_to_default_directory):
1898 * dispnew.c (Fopen_termscript):
1899 * emacs.c (Fdaemon_initialized):
1900 * fileio.c (Fdo_auto_save):
1901 * image.c (slurp_file, png_load_body, jpeg_load_body):
1902 * keyboard.c (Fopen_dribble_file):
1903 * lread.c (Fload):
1904 * print.c (Fredirect_debugging_output):
1905 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1906 * termcap.c (tgetent):
1907 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1908 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1909 * w32term.c (w32_initialize) [CYGWIN]:
1910 * xfaces.c (Fx_load_color_file):
1911 Use emacs_open instead of plain open, and emacs_fopen instead of
1912 plain fopen.
1913 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1914 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1915 * callproc.c (default_output_mode): New constant.
1916 (Fcall_process): Use it to call emacs_open instead of plain creat.
1917 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1918 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1919 (emacs_fopen): New function.
1920 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1921 Include <lisp.h>, for emacs_open.
1922 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1923
47ba6d43
PE
1924 Remove duplicate #include directives.
1925 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1926 * xfaces.c:
1927 Don't include stdio.h twice.
1928 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1929 Don't include sys/types.h or stdio.h twice.
1930 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1931 * lread.c: Don't include coding.h twice.
1932 * nsfont.m: Don't include frame.h twice.
1933 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1934 * ralloc.c: Don't include <unistd.h> twice.
1935 * xdisp.c: Don't include font.h twice.
1936 * xterm.c: Don't include fontset.h twice.
1937 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1938
b9ed53d5
PE
19392013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1940
1941 Scale ImageMagick images more carefully.
1942 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1943 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1944 Be more careful about avoiding undefined behavior after
1945 integer overflow and division by zero.
1946
cf13177e
YM
19472013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1948
1949 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1950 (syms_of_w32fns): DEFSYM them.
1951 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1952 (CCHDEVICENAME): Define macros if not defined.
1953 (struct MONITOR_INFO_EX): New struct.
1954 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1955 (enum_display_monitors_fn): New variable.
1956 (globals_of_w32fns): Initialize it.
1957 (Fx_display_pixel_width, Fx_display_pixel_height)
1958 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1959 multi-monitor setups in docstrings.
1960 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1961 screen size by primary monitor's millimeter per pixel.
1962 (w32_monitor_enum, w32_display_monitor_attributes_list)
1963 (w32_display_monitor_attributes_list_fallback)
1964 (Fw32_display_monitor_attributes_list): New functions.
1965 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1966
1967 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1968 if not defined.
1969 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1970
86dfb7a8
MA
19712013-07-04 Michael Albinus <michael.albinus@gmx.de>
1972
1973 * fileio.c (Qfile_notify_error): New error symbol.
1974
1975 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1976 * inotify.c (inotify_callback, symbol_to_inotifymask)
1977 (Finotify_add_watch, Finotify_rm_watch): Use it.
1978 (inotifyevent_to_event): Exchange order of cookie and file name.
1979 (Finotify_add_watch): Adapt docstring.
1980
1981 * lisp.h (Qfile_notify_error): Declare.
1982
2c1c974b
PE
19832013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1986 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1987 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1988 which did not work (see <http://bugs.gnu.org/14569#307>).
1989 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1990 && (!noninteractive || initialized)). This attempts to thread
1991 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1992
7a35b20f
JB
19932013-07-04 Juanma Barranquero <lekktu@gmail.com>
1994
1995 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1996 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1997
1ce5cd04
PE
19982013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2001 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2002 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2003 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2004
57f8c490
PE
20052013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2006
2007 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2008 Define to __sys_siglist.
2009
bcffb5ca
EZ
20102013-07-02 Eli Zaretskii <eliz@gnu.org>
2011
2012 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2013 word-wrap, so that overflow-newline-into-fringe would work in
2014 visual-line-mode. (Bug#2749)
2015 (move_it_in_display_line_to): When the last scanned display
2016 element fits exactly on the display line, and
2017 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2018 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2019 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2020 finding buffer position that corresponds to pixel coordinates,
2021 e.g. in buffer_posn_from_coords.
2022
2c41e781
JD
20232013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2024
2025 * process.c (handle_child_signal): Call catch_child_signal if
2026 NS_IMPL_GNUSTEP.
2027
c2418359
PE
20282013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2029
52a9bcae
PE
2030 Don't convert function pointers to void * and back.
2031 It isn't portable C, and it's easy enough to avoid.
2032 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2033 (make_save_value): Add support for SAVE_FUNCPOINTER.
2034 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2035 * print.c (print_object):
2036 Distinguish function from object pointers.
2037 * lisp.h (SAVE_FUNCPOINTER): New constant.
2038 (SAVE_SLOT_BITS): Adjust to it.
2039 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2040 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2041 (voidfuncptr): New typedef.
2042 (struct Lisp_Save_Value): New member data[0].funcpointer.
2043 (XSAVE_FUNCPOINTER): New function.
2044
c2418359
PE
2045 Simplify buildobj processing.
2046 * Makefile.in (buildobj.h): Make it a sequence of strings each
2047 followed by comma, rather than a single string. Put it into a
2048 .tmp file in case there's an error while generating it.
2049 (gl-stamp): Use .tmp for temp files.
2050 (mostlyclean): Clean .tmp files.
2051 * doc.c (buildobj): Move to just the routine that needs it.
2052 It's now an array of strings, so processing is simpler.
2053
8f43ce49
PE
20542013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2057 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2058 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2059 Invoke malloc_enable_thread even when not interactive.
2060 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2061 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2062 in this case, since the underlying bug has now been fixed.
2063
24827db9
JB
20642013-07-01 Juanma Barranquero <lekktu@gmail.com>
2065
2066 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2067 unlinking it (bug#14691).
2068
ef099a94
MN
20692013-06-30 Michal Nazarewicz <mina86@mina86.com>
2070
2071 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2072 before checking whether buffer is modified. This lets
2073 `kill-buffer-query-functions' cancel killing of the buffer or save
2074 its content before `kill-buffer' asks user the "Buffer %s
2075 modified; kill anyway?" question.
2076
9d3f2fc2
JD
20772013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2078
2079 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2080 Let the super performKeyEquivalent deal with them (Bug#14747).
2081
e6c6c8c7
PE
20822013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2083
1d71c1d9
PE
2084 * widget.c (resize_cb): Remove unused local.
2085
8f5f35cc
PE
2086 Do not use GTK 3 if it exists but cannot be compiled.
2087 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2088 * xterm.c (x_error_handler) [!USE_GTK]:
2089 Do not use GTK 3.
2090
e6c6c8c7
PE
2091 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2092
0ba54312
EZ
20932013-06-30 Eli Zaretskii <eliz@gnu.org>
2094
5d1c3286
EZ
2095 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2096 to the valid range of values. (Bug#14753)
2097
0ba54312
EZ
2098 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2099 when moving point by using the current glyph matrix. This avoids
2100 the need to force redisplay when this function is called in a
2101 loop.
2102
9c90cc06
PE
21032013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 Fix minor problems found by static checking.
2106 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2107 Redo the latter's body to sidestep GCC parenthesization warnings.
2108 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2109 * coding.c (detect_coding, detect_coding_system):
2110 * coding.h (struct undecided_spec):
2111 Use bool for boolean.
2112 * image.c (QCmax_width, QCmax_height): Now static.
2113 * xdisp.c (Fmove_point_visually): Remove unused local.
2114
4c672a0f
EZ
21152013-06-29 Eli Zaretskii <eliz@gnu.org>
2116
2117 * xdisp.c (Fmove_point_visually): New function.
2118
c1ea3abf
JB
21192013-06-28 Kenichi Handa <handa@gnu.org>
2120
2121 * coding.h (define_coding_undecided_arg_index): New enum.
2122 (coding_attr_index): New members
2123 coding_attr_undecided_inhibit_null_byte_detection,
2124 coding_attr_undecided_inhibit_iso_escape_detection,
2125 coding_attr_undecided_prefer_utf_8.
2126 (undecided_spec): New struct.
2127 (struct coding_system): New member `undecided' of the member
2128 `spec'.
2129
2130 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2131 (detect_coding): Likewise.
2132 (detect_coding_system): Likewise.
2133 (Fdefine_coding_system_internal): New coding system properties
2134 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2135 :prefer-utf-8.
2136 (syms_of_coding): Adjust for coding_arg_undecided_max.
2137
ba3de9e6
PE
21382013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * image.c (x_from_xcolors): Remove unused local.
2141
547c9269
YM
21422013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2143
2144 Defer image data transfer between X client and server until actual
2145 display happens.
2146
2147 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2148 and `mask_img'.
2149
2150 * image.c (Destroy_Image): Remove.
2151 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2152 `mask_p', and `colors_p'. All uses changed.
2153 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2154 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2155 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2156 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2157 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2158 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2159 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2160 (image_get_x_image, image_unget_x_image): New functions or macros.
2161 (image_background, image_background_transparent, x_to_xcolors)
2162 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2163 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2164 instead of Destroy_Image.
2165 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2166 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2167 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2168 (imagemagick_load_image, svg_load_image): Use them instead of
2169 x_create_x_image_and_pixmap, and x_put_x_image followed by
2170 x_destroy_x_image, respectively.
2171 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2172 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2173 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2174 background_transparent fields.
2175 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2176 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2177
dae2f5ef
PE
21782013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2181 This mostly consists of undoing recent changes.
2182 * callproc.c (Fcall_process):
2183 * process.c (create_process):
2184 Do not worry about catching SIGCHLD here, undoing previous change.
2185 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2186 * process.c, process.h (catch_child_signal):
2187 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2188 * process.c (catch_child_handler): Don't worry about being called
2189 lazily and do not assume caller has blocked SIGCHLD, undoing
2190 previous change. Move first-time stuff back to
2191 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2192 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2193 set lib_child_handler if it's already initialized, which may
2194 help avoid problems on GNUStep.
2195
fa55d2aa
PE
21962013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2197
2198 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2199 * callproc.c (Fcall_process):
2200 * process.c (create_process):
2201 Make sure SIGCHLD is caught before we fork,
2202 since Emacs startup no arranges to catch SIGCHLD.
2203 * process.c (lib_child_handler): Initialize to null, not to
2204 dummy_handler.
2205 (catch_child_signal): Allow self to be called lazily.
2206 Do nothing if it's already been called.
2207 Assume caller has blocked SIGCHLD (all callers do now).
2208 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2209 just before it's really needed.
2210 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2211 since it hasn't been caught yet.
2212
f3f9606c
LMI
22132013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2214
2215 * image.c (compute_image_size): New function to implement
2216 :max-width and :max-height.
2217 (imagemagick_load_image): Use it.
2218
c7041908
PE
22192013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2222 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2223 Now extern.
2224 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2225 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2226 the SIGCHLD handler, since the code is not atomic and (due to glib)
2227 signals may be arriving now.
2228 * sysdep.c (init_signals): Do not catch child signals here;
2229 'main' now does that later, at a safer time.
2230
f86852b4
PE
22312013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2232
0dfeed58
PE
2233 Clean up SIGCHLD handling a bit (Bug#14569).
2234 * process.c, process.h (catch_child_signal):
2235 Now always extern, even if !NS_IMPL_GNUSTEP.
2236 * process.c (catch_child_signal): Move glib tickler here from
2237 init_process_emacs, so that it's done earlier in Emacs
2238 initialization. Also move the noninteractive && !initialized
2239 check here from init_process_emacs. This is all a bit cleaner for
2240 GNUish platforms, and I hope it works around the Cygwin bug.
2241 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2242 that glib signal handling is tickled before glib creates threads.
2243
f86852b4
PE
2244 * process.c (wait_reading_process_output): Avoid int overflow
2245 when reading more than 2 GiB total from a process.
2246
cbd6509c
PE
22472013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 * process.c (create_process): Handle a couple more cases,
2250 i.e., work even if new_argv and wait_child_setup[i] are cached.
2251 Use Fcall_process's style for volatile vars.
2252
9de1114a
AS
22532013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * process.c (create_process): Mark PROCESS volatile.
2256
fbe9e0b9
PE
22572013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2258
2259 Use C99-style flexible array members if available.
2260 This avoids some subtle aliasing issues, which typically
2261 aren't a problem with GCC but may be a problem elsewhere.
2262 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2263 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2264 In either case, it uses a flexible array member rather than
2265 the old struct hack. All uses changed.
2266 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2267 Adjust to sdata reorganization.
2268 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2269 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2270 that ports better to pre-C99 non-GCC.
2271 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2272 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2273 as the latter has changed.
2274 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2275 and port better to pre-C99 GCC.
2276 * image.c (struct xpm_cached_color):
2277 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2278 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2279 Use FLEXIBLE_ARRAY_MEMBER.
2280 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2281 Move decl to top level so it gets checked against implementation.
2282 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2283 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2284
1fc71008
PE
22852013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 * syntax.c: Integer cleanups.
2288 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2289 All uses that need 0-or-2 changed to:
2290 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2291 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2292 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2293 (char_quoted, prev_char_comend_first, back_comment)
2294 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2295 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2296 Use bool for boolean.
2297 (update_syntax_table, skip_chars, skip_syntaxes):
2298 Prefer int to unsigned when either will do.
2299 (back_comment): Return boolean success flag, like forw_comment,
2300 instead of positive-or-minus-1 (which might have overflowed int anyway).
2301 Don't stuff ptrdiff_t into int.
2302 (syntax_spec_code, syntax_code_spec): Now const.
2303 (Fmatching_paren, scan_lists, scan_sexps_forward):
2304 Use enum syntaxcode for syntax code.
2305 (Fmatching_paren): Check that arg is a character, not just an integer.
2306 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2307 (Finternal_describe_syntax_value): Omit no-longer-needed
2308 comparison to 0.
2309 (skip_chars): Use char, not unsigned char, when the distinction
2310 doesn't matter.
2311 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2312 * bytecode.c (exec_byte_code):
2313 * syntax.c (syntax_spec_code, Fchar_syntax)
2314 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2315 (init_syntax_once):
2316 * syntax.h (SYNTAX_WITH_FLAGS):
2317 Omit unnecessary casts.
2318
b932cad7
EZ
23192013-06-20 Eli Zaretskii <eliz@gnu.org>
2320
2321 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2322 line dimensions here, to avoid race conditions with the main
2323 thread. (Bug#14062, bug#14630, bug#14669)
2324
2325 * w32term.c (w32_draw_window_cursor): Compute the header line and
2326 mode line dimensions here.
2327 <w32_system_caret_window, w32_system_caret_hdr_height>:
2328 <w32_system_caret_mode_height>: New variables.
2329
2330 * w32term.h: Declare them.
2331
89561f72
PE
23322013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2333
5013fc08
PE
2334 * alloc.c (die): Move "assertion failed" string here ...
2335 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2336 COND when SUPPRESS_CHECKING. This shrinks the executable text
2337 size by 0.8% to 2.2% when configured with --enable-checking,
2338 depending on optimization flags (GCC 4.8.1 x86-64).
2339
89561f72
PE
2340 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2341
763a086d 23422013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2343
2344 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2345 base is 2; this is more accurate.
2346
983aeb9a
JB
23472013-06-19 Juanma Barranquero <lekktu@gmail.com>
2348
2349 * sound.c (string_default): Move to !WINDOWSNT section.
2350 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2351
178ba3e6
PE
23522013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2353
bbc51b15
PE
2354 * sound.c: Integer cleanups.
2355 Remove unnecessary forward decls.
2356 (struct sound_device): The 'file' member is now a Lisp_Object, not
2357 a char *, so that we needn't invoke alloca on a huge size.
2358 (Fplay_sound_internal): Adjust to this.
2359 (string_default): New function.
2360 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2361 Use it to adjust to the struct sound_device change.
2362 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2363 (be2hs) [0]: Remove.
2364
178ba3e6
PE
2365 * syntax.c (skip_chars): Don't use uninitialized storage
2366 when searching a multibyte buffer for characters that are not in a
2367 unibyte string that contains non-ASCII characters.
2368
69f60cdc
JD
23692013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2370
2371 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2372 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2373
0d6224d4
PE
23742013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2377
3c542890
KH
23782013-06-18 Kenichi Handa <handa@gnu.org>
2379
f7e3f7cd
KH
2380 * font.c (Ffont_spec): Signal an error for an invalid font name
2381 (Bug#14648).
3c542890 2382
9349e5f7
PE
23832013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2384
2385 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2386 In particular this ports to 32-bit sparc Sun cc.
2387 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2388 array with a dummy element at specpdl[-1], so that its address can
2389 be taken portably.
2390 (unbind_to): Do not copy the binding; not needed, now that we
2391 copy old_value in the one place where the copy is needed.
2392 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2393 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2394 (union specbinding): Rename from struct specbinding. Redo layout
2395 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2396 which is not portable. With Sun C 5.12 32-bit sparc, the
2397 declaration causes nargs to be an unsigned bitfield, a behavior
2398 that the C standard allows; but Emacs wants nargs to be signed.
2399 The overall type is now a union of structures rather than a
2400 structure of union of structures, and the 'kind' member is now a
2401 bitfield, so that the overall type doesn't grow. All uses changed.
2402 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2403
0a4df6a5
PE
24042013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2405
ec6ecaad
PE
2406 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2407 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2408
0a4df6a5
PE
2409 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2410
7bfe8dbc
EZ
24112013-06-17 Eli Zaretskii <eliz@gnu.org>
2412
2413 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2414 unless we know that the window w's frame is a frame object.
2415 Another attempt at solving bug#14062 and bug#14630.
2416
708e05f6
LMI
24172013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2418
2419 * textprop.c (property_set_type): New enum.
2420 (add_properties): Allow appending/prepending text properties.
2421 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2422 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2423 add_text_properties_1.
2424 (Fadd_face_text_property): New function that calls
2425 add_text_properties_1.
2426
84575e67
PE
24272013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2428
2429 Move functions from lisp.h to individual modules when possible.
2430 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2431 * alloc.c (XFLOAT_INIT, set_symbol_name):
2432 * buffer.c (CHECK_OVERLAY):
2433 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2434 (set_char_table_parent):
2435 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2436 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2437 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2438 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2439 (set_blv_valcell):
2440 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2441 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2442 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2443 (backtrace_args, backtrace_debug_on_exit):
2444 * floatfns.c (CHECK_FLOAT):
2445 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2446 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2447 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2448 (set_hash_index_slot):
2449 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2450 * marker.c (CHECK_MARKER):
2451 * textprop.c (CHECK_STRING_OR_BUFFER):
2452 * window.c (CHECK_WINDOW_CONFIGURATION):
2453 Move here from lisp.h, and make these functions static rather than
2454 extern inline.
2455 * buffer.c (Qoverlayp):
2456 * data.c (Qsubrp):
2457 * fns.c (Qhash_table_p):
2458 * window.c (Qwindow_configuration_p):
2459 Now static.
2460 * lisp.h: Remove the abovementioned defns and decls.
2461
44e18199 2462 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2463 In lisp.h, prefer functions to function-like macros, and
2464 constants to object-like macros, when either will do. This:
2465 . simplifies use, as there's no more need to worry about
2466 arguments' side effects being evaluated multiple times.
2467 . makes the code easier to debug on some platforms.
2468 However, when using gcc -O0, keep using function-like macros
2469 for a few critical operations, for performance reasons.
2470 This sort of thing isn't needed with gcc -Og, but -Og
2471 is a GCC 4.8 feature and isn't widely-enough available yet.
2472 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2473 Remove enum lsb_bits; no longer needed.
2474 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2475 * buffer.c (Qoverlap):
2476 * data.c (Qsubrp):
2477 * fns.c (Qhash_table_p):
2478 Now extern, so lisp.h can use these symbols.
2479 * dispextern.h: Include character.h, for MAX_CHAR etc.
2480 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2481 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2482 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2483 (GLYPH_CODE_P): Move here from lisp.h.
2484 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2485 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2486 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2487 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2488 XUNTAG now returns void *.
2489 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2490 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2491 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2492 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2493 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2494 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2495 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2496 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2497 New macros, renamed from their sans-lisp_h_ counterparts.
2498 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2499 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2500 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2501 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2502 If compiling via GCC without optimization, define these as macros
2503 in addition to inline functions.
2504 To disable this, compile with -DINLINING=0.
2505 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2506 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2507 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2508 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2509 (INTMASK, VALMASK): Now macros, since static values cannot be
2510 accessed from extern inline functions.
2511 (VALMASK): Also a constant, for benefit of old GDB.
2512 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2513 is INTEGERP, which can fold it in.
5165d44a 2514 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2515 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2516 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2517 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2518 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2519 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2520 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2521 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2522 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2523 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2524 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2525 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2526 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2527 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2528 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2529 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2530 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2531 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2532 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2533 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2534 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2535 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2536 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2537 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2538 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2539 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2540 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2541 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2542 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2543 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2544 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2545 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2546 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2547 Now functions.
2548 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2549 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2550 (VALMASK): Define in one place rather than in two, merging the
2551 USE_LSB_TAG parts; this is simpler.
2552 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2553 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2554 Move up, to avoid use before definition.
2555 Also include "globals.h" earlier, for the same reason.
2556 (make_natnum): New function.
2557 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2558 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2559 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2560 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2561 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2562 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2563 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2564 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2565 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2566 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2567 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2568 (Qwindow_configuration_p, Qimage): New forward declarations.
2569 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2570 (STRING_COPYIN): Remove; unused.
2571 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2572 (xcar_addr, xcdr_addr): New functions. All uses changed.
2573 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2574 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2575 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2576 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2577 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2578 (TYPE_RANGED_INTEGERP): Simplify.
2579 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2580 (setlocale, fixup_locale, synchronize_system_messages_locale)
2581 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2582 Now empty functions, not macros.
2583 (functionp): Return bool, not int.
2584 * window.c (Qwindow_configuration_p): Now extern,
2585 so window.h can use it.
2586 * window.h (Qwindowp): Move decl back to lisp.h.
2587
9583ec36
EZ
25882013-06-15 Eli Zaretskii <eliz@gnu.org>
2589
2590 * xdisp.c (Fline_pixel_height): New function, required for solving
2591 bug #14567.
2592
210272ce
PE
25932013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2594
2595 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2596
de0503df
SM
25972013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2598
2599 * lread.c (syms_of_lread):
2600 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2601
afbfe143
KD
26022013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2603
2604 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2605
d177e213
XF
26062013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2607
2608 * fileio.c (expand_file_name): Doc fix.
2609
05e3e412
PE
26102013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2611
f7394b12
PE
2612 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2613 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2614 Wait for self, not for 0. This can't hurt on GNU or similar
2615 system, and may help with Cygwin.
2616
05e3e412
PE
2617 * keyboard.c: Don't use PROP (...) as an lvalue.
2618 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2619 Use set_prop (A, B), not PROP (A) = B.
2620
17dd3097
EZ
26212013-06-10 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (get_it_property): Use it->window instead of generating
2624 a Lisp object from it->w.
2625
52fab9c9
EZ
26262013-06-09 Eli Zaretskii <eliz@gnu.org>
2627
2628 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2629 get-char-property the window that is being rendered, instead of
2630 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2631 (compute_display_string_pos): When W is NULL, use the current
2632 buffer as the object to pass to get-char-property.
2633 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2634 pointer member of the bidi iterator, since no window is pertinent
2635 to this function.
52fab9c9 2636
5bf97bfc
EZ
26372013-06-08 Eli Zaretskii <eliz@gnu.org>
2638
2639 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2640 being displayed, and pass it to compute_display_string_pos.
2641 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2642 (bidi_paragraph_init): All callers changed.
2643
2644 * xdisp.c (init_from_display_pos, init_iterator)
2645 (handle_single_display_spec, next_overlay_string)
2646 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2647 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2648 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2649 (compute_display_string_pos): Accept additional argument, the
2650 window being displayed, and pass it to Fget_char_property.
2651 (Bug#14575)
2652
2653 * dispextern.h (struct bidi_it): New member w, the window being
2654 displayed.
2655 (compute_display_string_pos): Adjust prototype.
2656
5de0e011
JD
26572013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2658
e7b41c4c 2659 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2660
2661 * process.c (wait_reading_process_output): Check for NS before GLIB.
2662 GLIB may be linked in due to rsvg, but ns_select must be called.
2663
5de0e011
JD
2664 * xgselect.c (xg_select): Remove call to window_system_available
2665 and g_main_context_pending at the top, so Gdk events (i.e. file
2666 notify) are processed when Emacs is started with -nw.
2667
a822acff
EZ
26682013-06-07 Eli Zaretskii <eliz@gnu.org>
2669
2670 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2671 (ctagsfiles3): New variable, includes only *.m files.
2672 (TAGS): Use an explicit language name in the regular expressions,
2673 to avoid transformation of '/SOMETHING' by MSYS to
2674 'c:\MSYS\SOMETHING'.
2675
6c0a9ed1
RC
26762013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2677
2678 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2679
9ef6111b
EZ
26802013-06-06 Eli Zaretskii <eliz@gnu.org>
2681
2682 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2683 still need to set the mouse pointer shape and activate help-echo.
2684 (Bug#14558)
2685
7d300d64
PE
26862013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2687
2688 A few porting etc. fixes for the new file monitor code.
2689 See the thread containing
2690 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2691 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2692 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2693 (dir_monitor_callback, Fgfile_rm_watch):
2694 Use assq_no_quit instead of Fassoc, for speed.
2695 (dir_monitor_callback, Fgfile_rm_watch):
2696 eassert that the monitor is a fixnum.
2697 (dir_monitor_callback): No need for CDR_SAFE.
2698 Simplify building of lisp with alternative tails.
2699 (Fgfile_add_watch, Fgfile_rm_watch):
2700 Do not assume glib functions set errno reliably on failure.
2701 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2702 and signal an error otherwise.
2703 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2704 Use Fdelq instead of Fdelete, for speed.
2705
817ebfcf
EZ
27062013-06-05 Eli Zaretskii <eliz@gnu.org>
2707
2708 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2709 don't insist on being invoked on a highlighted tool-bar button.
2710 Avoids losing tool-bar functionality when mouse-highlight is nil.
2711 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2712 Don't highlight when mouse-highlight is nil.
2713 (note_mouse_highlight): When mouse-highlight is nil, don't return
2714 right away; instead, run tool-bar and mode-line highlight
2715 subroutine, clear any existing highlight, and revert the mouse
2716 pointer to its default shape. (Bug#14558)
2717
55577e7c
SM
27182013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2719
2720 * lisp.mk (lisp): Add prog-mode.el.
2721
f019a684
PE
27222013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2725 * process.c (dummy_handler): New function.
2726 (lib_child_handler): New static var.
2727 (handle_child_signal): Invoke it.
2728 (catch_child_signal): If a library has set up a signal handler,
2729 save it into lib_child_handler.
2730 (init_process_emacs): If using glib and not on Windows, tickle glib's
2731 child-handling code so that it initializes its private SIGCHLD handler.
2732 * syssignal.h (SA_SIGINFO): Default to 0.
2733 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2734 31; it should no longer be needed now.
2735
90db8702
MA
27362013-06-05 Michael Albinus <michael.albinus@gmx.de>
2737
2738 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2739
2740 * gfilenotify.c (globals_of_gfilenotify): New function.
2741 (syms_of_gfilenotify): Move global initialization there.
2742
2743 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2744
bfa3acd6
SM
27452013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2746
2747 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2748 * keyboard.c (menu_bar_items, tool_bar_items):
2749 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2750 not override local keymaps any more.
2751
ba59bd80
EZ
27522013-06-04 Eli Zaretskii <eliz@gnu.org>
2753
2754 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2755
7f203aa1
EZ
27562013-06-03 Eli Zaretskii <eliz@gnu.org>
2757
9337e206
EZ
2758 * w32console.c (initialize_w32_display): Return the dimensions of
2759 the console window via 2 additional arguments, not via the current
2760 frame. This avoids crashes due to overrunning the bounds of
2761 frame's decode_mode_spec_buffer, which is not resized following
2762 the change of the frame dimensions from the initial 10x10.
2763
2764 * w32term.h (w32_initialize_display_info): Adjust prototype.
2765
2766 * term.c (init_tty): Take dimensions of the frame from the values
2767 returned by initialize_w32_display.
2768
7f203aa1
EZ
2769 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2770 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2771 (LIBES): Add $(GFILENOTIFY_LIBS).
2772
2773 * w32inevt.c (handle_file_notifications): Add dummy implementation
2774 for !HAVE_W32NOTIFY.
2775
2776 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2777
55a87246
JD
27782013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2779
2780 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2781
2782 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2783
2784 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2785
3d5ee10a
PE
27862013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2787
2788 Fix minor problems found by static checking.
2789 * data.c (pure_write_error):
2790 Use xsignal2, not Fsignal, as Fsignal might return.
2791 * eval.c (set_backtrace_debug_on_exit): Now static.
2792 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2793 No longer inline. EXTERN_INLINE is needed only for functions
2794 defined in .h files. Reindent function header as per GNU style.
2795 (backtrace_p, backtrace_top, backtrace_next):
2796 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2797 compiler or linker. Add extern decls to pacify gcc -Wall.
2798 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2799 Now static.
2800 * frame.c (free_monitors): Define only on platforms that need it.
2801 * nsterm.m (ns_term_init):
2802 * process.c (catch_child_signal):
2803 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2804 defined on all porting targets these days.
2805 * process.c, process.h (catch_child_signal):
2806 Make it extern only if NS_IMPL_GNUSTEP is defined.
2807
e2d8a6f0
EZ
28082013-06-03 Eli Zaretskii <eliz@gnu.org>
2809
2810 * w32.c (gettimeofday): Make the signature identical to prototype
2811 in nt/inc/sys/time.h.
2812
a8a7c5f6
SM
28132013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2814
2815 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2816 .gdbinit.
2817
2818 * keyboard.c (safe_run_hooks_error): Improve error message.
2819
2820 * data.c (pure_write_error): Add `object' argument.
2821 * puresize.h (CHECK_IMPURE): Use it.
2822
c9628c79
MA
28232013-06-03 Michael Albinus <michael.albinus@gmx.de>
2824
2825 * Makefile.in (NOTIFY_OBJ): New variable.
2826 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2827
2828 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2829 Call syms_of_gfilenotify.
2830
2831 * gfilenotify.c: New file.
2832
2833 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2834 and Qfile_w32notify.
2835 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2836 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2837
2838 * lisp.h: Declare syms_of_gfilenotify.
2839
2840 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2841
2f592f95
SM
28422013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2843
2844 Merge the specpdl and backtrace stacks. Make the structure of the
2845 specpdl entries more obvious via a tagged union of structs.
2846 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2847 (enum specbind_tag): New enum.
2848 (struct specbinding): Make it a tagged union of structs.
2849 Add a case for backtrace records.
2850 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2851 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2852 (backtrace_debug_on_exit): New accessors.
2853 (struct backtrace): Remove.
2854 (struct catchtag): Remove backlist field.
2855 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2856 Move to eval.c.
2857 (Flocal_variable_p): Speed up the common case where the binding is
2858 already loaded.
2859 * eval.c (backtrace_list): Remove.
2860 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2861 (set_backtrace_args, set_backtrace_nargs)
2862 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2863 (backtrace_next): New functions.
2864 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2865 (unwind_to_catch, internal_lisp_condition_case)
2866 (internal_condition_case, internal_condition_case_1)
2867 (internal_condition_case_2, internal_condition_case_n): Don't bother
2868 with backtrace_list any more.
2869 (Fsignal): Adjust to new backtrace format.
2870 (grow_specpdl): Move up.
2871 (record_in_backtrace): New function.
2872 (eval_sub, Ffuncall): Use it.
2873 (apply_lambda): Adjust to new backtrace format.
2874 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2875 data.c.
2876 (specbind): Adjust to new specpdl format. Simplify.
2877 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2878 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2879 backtrace format.
2880 (mark_backtrace): Remove.
2881 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2882 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2883 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2884 Use mark_specpdl.
2885 * profiler.c (record_backtrace): Use get_backtrace.
2886 (handle_profiler_signal): Use backtrace_top_function.
2887 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2888 accessor functions.
2889
c0342369
JD
28902013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2891
2892 * process.h (catch_child_signal): Declare.
2893
2894 * process.c (catch_child_signal): New function.
2895 (init_process_emacs): Call it.
2896
2897 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2898 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2899 NS_IMPL_COCOA.
2900 (x_set_cursor_type): Remove declaration.
2901 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2902 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2903 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2904 (ns_get_color): Use F suffix on float.
2905 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2906 (ns_get_rgb_color): Remove.
2907 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2908 (note_mouse_movement): x and y are CGFloat.
2909 (ns_draw_fringe_bitmap): Remove unused rowY.
2910 Change #if to COCOA && >= 10_6.
2911 (ns_draw_window_cursor): Remove unused overspill.
2912 (ns_draw_underwave): width and x are EamcsCGFloat.
2913 (ns_draw_box): thickness is CGFloat.
2914 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2915 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2916 if not in main thread.
2917 (ns_get_pending_menu_title, ns_check_menu_open)
2918 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2919 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2920 (sendFromMainThread:): New method.
2921 (changeFont:): size is CGFloat.
2922 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2923 Disable warning about permanent text.
2924 (characterIndexForPoint:): Adjust return type depending on GNUStep
2925 version.
2926 (mouseDown:): delta is CGFloat.
2927 (updateFrameSize): Remove unised variable f.
2928 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2929 Cast float to EmacsCGFloat.
2930 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2931 also to -1 when restoring.
2932 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2933 inside NS_IMPL_COCOA.
2934 (toggleFullScreen:): Put call to toggleFullScreen inside
2935 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2936 (setPosition:portion:whole:): por is CGFloat.
2937 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2938 (mouseDown:): Use CGFloat.
2939 (mouseDragged:): Remove unised variable edge.
2940 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2941
2942 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2943 of CGFloat differs.
2944 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2945 when NS_IMPL_GNUSTEP.
2946 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2947 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2948 (EmacsToolbar): Add clearAll. Add tag argument to
2949 addDisplayItemWithImage.
2950 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2951
2952 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2953
2954 * nsmenu.m (ns_update_menubar): Make static.
2955 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2956 (fillWithWidgetValue:): Add cast to SEL for setAction.
2957 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2958 (update_frame_tool_bar): Update code for GNUStep.
2959 (clearAll): New method.
2960 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2961 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2962 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2963 call to insertItemWithItemIdentifier.
2964 (validateVisibleItems): Fix indentation.
2965 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2966 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2967 UtilityWindow to aStyle, remove call to setStyleMask.
2968
2969 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2970
2971 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2972 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2973 Use F suffix on floats.
2974 (ns_char_width): Returns CGFloat.
2975 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2976 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2977 DPSxshow.
2978 (ns_glyph_metrics): CGFloat instead of float.
2979
a0eb10b3
JB
2980 * nsfns.m (x_set_foreground_color, x_set_background_color):
2981 Use EmacsCGFloat.
2982 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2983 remove unused variables.
2984 (Fns_read_file_name): Keep track if panel is for save.
2985 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2986 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2987 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2988 Just return the input if GNUStep.
c0342369
JD
2989 (x_screen_planes): Remove.
2990 (Fxw_color_values): Use EmacsCGFloat
2991 (Fns_display_monitor_attributes_list): Only get screen number for
2992 Cocoa.
ef099a94 2993 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2994 EmacsSavePanel.
2995 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2996 ns_directory_from_panel.
2997
da9aff11
PE
29982013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2999
3000 * process.c (handle_child_signal): Also use WCONTINUED.
3001 This is so that list-processes doesn't mistakenly list the process
3002 as stopped, when the process has actually been continued and is
3003 now running.
3004
0e64479a
PE
30052013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3006
fc186a96
PE
3007 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3008 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3009 not already configured.
3010
0e64479a
PE
3011 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3012
38b787fa
EZ
30132013-05-29 Eli Zaretskii <eliz@gnu.org>
3014
3015 * Makefile.in (mostlyclean): Remove *.res files.
3016
22513e52
SM
30172013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3018
3019 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3020 a buffer (bug#8447).
3021
6ef3db10
EZ
30222013-05-27 Eli Zaretskii <eliz@gnu.org>
3023
3024 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3025 display vector, and we backtrack, handle the case that the
3026 previous character position is also displayed from a display
3027 vector or covered by a display string or image. (Bug#14476)
3028
6799bb26
JD
30292013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3030
3031 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3032 (struct MonitorInfo, free_monitors): Remove.
3033 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3034 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3035 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3036 Qframes, Qsource.
3037
3038 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3039 (struct MonitorInfo, free_monitors): Remove.
3040 (ns_screen_name): Make static.
3041 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3042 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3043 Qframes, Qsource.
3044
3045 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3046 (struct MonitorInfo): New struct.
3047 (free_monitors, make_monitor_attribute_list): Declare.
3048
22513e52
SM
3049 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3050 New Lisp_Object:s.
6799bb26
JD
3051 (free_monitors, make_monitor_attribute_list): New functions.
3052 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3053 Qsource.
3054
38cd43eb
XF
30552013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3056
3057 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3058
2af0948d
SM
30592013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3060
a7eb9b0f
SM
3061 * keyboard.c: Apply keyboard decoding only to events that come directly
3062 from the tty, not from unread-command-events (bug#14368).
3063 (read_event_from_main_queue): New function, extracted from read_char).
3064 (read_decoded_char): Remove.
3065 (read_decoded_event_from_main_queue): New function to replace it.
3066 (read_char): Use it.
3067 (read_key_sequence): Use read_char rather than read_decoded_char.
3068
2af0948d
SM
3069 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3070
1413e9a5
BR
30712013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3072
3073 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3074
e6d2f155
KH
30752013-05-22 Kenichi Handa <handa@gnu.org>
3076
3077 The following changes are to fix the setting of
3078 buffer-file-coding-system on, for instance, C-x RET c unix RET
3079 _FILE_OF_DOS_EOL_TYPE_ RET.
3080
3081 * coding.h (struct coding_system): New member detected_utf8_chars.
3082
3083 * coding.c (detect_coding_utf_8): Count characters and check EOL
3084 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3085 BOM is there.
3086 (setup_coding_system): Do not initialize coding->head_ascii.
3087 (check_ascii): Do not set coding->eol_seen but update it. Do not
3088 call adjust_coding_eol_type here.
1413e9a5
BR
3089 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3090 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3091 of the found coding-system.
3092 (decode_coding_gap): Cancel previous change. Utilize the
3093 character numbers counted by detect_coding_utf_8. Fix detection
3094 of BOM for utf-8.
3095
ab56a6f4 30962013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3097
3098 * search.c (looking_at_1): Only set last_thing_searched if the match
3099 changed the match-data (bug#14281).
3100
ecc3c6ed
DA
31012013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3102
3103 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3104 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3105 (move_it_vertically_backward): Likewise.
3106
5ba8bf35
YM
31072013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3108
3109 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3110 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3111 (Fx_display_mm_width, Fx_display_mm_height):
3112 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3113
91e8418b 3114 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3115 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3116 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3117 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3118 (Fx_display_backing_store, Fx_display_visual_class)
3119 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3120 (Fx_display_grayscale_p, Fx_display_pixel_width)
3121 (Fx_display_pixel_height, Fx_display_planes)
3122 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3123 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3124 (Fx_display_mm_width, Fx_display_mm_height)
3125 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3126 height for all physical monitors as in X11.
3127
fc30d803
SM
3128 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3129 Return pixel width or height for all physical monitors as in X11.
91e8418b 3130
31ff141c
PE
31312013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 Port --enable-gcc-warnings to clang.
3134 * bytecode.c (exec_byte_code):
3135 * regex.c:
3136 Redo diagnostic pragmas to pacify clang, too.
3137 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3138 * editfns.c (Fencode_time):
3139 * fileio.c (file_accessible_directory_p):
3140 * font.c (font_unparse_xlfd):
3141 Use '&"string"[index]' instead of '"string" + (index)'.
3142 * undo.c (user_error): Remove; unused.
3143
df065a0b
EZ
31442013-05-16 Eli Zaretskii <eliz@gnu.org>
3145
04d360e7
EZ
3146 * insdel.c (insert_1_both): Document the arguments, instead of
3147 referring to insert_1, which no longer exists.
3148
5bb98290
EZ
3149 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3150 some window, increment windows_or_buffers_changed, so that
3151 *Messages* display in that window is updated. (Bug#14408)
3152
df065a0b
EZ
3153 * w32.c: Include epaths.h.
3154 (init_environment): Use cmdproxy.exe without leading directories.
3155 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3156 case.
3157 (gettimeofday): Adjust signature and return value to Posix
3158 expectations.
3159
3160 * unexw32.c (open_output_file): Delete the existing emacs.exe
3161 before creating it, to break the hard link to the versioned
3162 executable.
3163
3164 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3165 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3166 (FIRSTFILE_OBJ): New variables.
3167 (W32_RES): Rename to EMACSRES. All users changed.
3168 (base_obj): Use $(CM_OBJ).
3169 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3170 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3171 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3172 $(W32_RES_LINK) before $(LIBES).
3173 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3174
1aa8d505
SM
31752013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3176
6e911150
SM
3177 * makefile.w32-in (DOC): Use just "DOC".
3178
3179 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3180
1aa8d505
SM
3181 * process.c: Export default filters and sentinels to Elisp.
3182 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3183 New constants.
3184 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3185 (Fset_process_sentinel, Fformat_network_address):
3186 Default to them instead of nil.
3187 (server_accept_connection): Sentinels can't be nil any more.
3188 (read_and_dispose_of_process_output): New function, extracted from
3189 read_process_output.
3190 (read_process_output): Use it; filters can't be nil.
3191 (Finternal_default_process_filter): New function, extracted from
3192 read_process_output.
3193 (exec_sentinel_unwind): Remove function.
3194 (exec_sentinel): Don't zilch sentinel while running.
3195 (status_notify): Sentinels can't be nil.
3196 (Finternal_default_process_sentinel): New function extracted from
3197 status_notify.
3198 (setup_process_coding_systems): Default filter is not nil any more.
3199 (syms_of_process): Export new Elisp functions and initialize
3200 new constants.
3201 * lisp.h (make_lisp_proc): New function.
3202
5ac2eb34
SM
32032013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3204
3205 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3206
eda9c7d7
EZ
32072013-05-14 Eli Zaretskii <eliz@gnu.org>
3208
3209 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3210 unless we know that the window w is a leaf window.
3211 Another attempt at solving bug#14062.
eda9c7d7 3212
8fdeaad5
JD
32132013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3214
3215 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3216 fdesc (Bug#14375).
3217
44aa9ee6
PE
32182013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 * image.c (gif_load): Check that subimages fit (Bug#14345).
3221
759fd763
SM
32222013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3223
3224 * lread.c (skip_dyn_eof): New function.
3225 (read1): Use it to skip the end of a file in response to #@00.
3226
3227 * doc.c (get_doc_string): Slightly relax the sanity checking.
3228
4465bfb4
JD
32292013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3230
3231 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3232 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3233 (MonitorInfo): New struct.
3234 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3235 (Fns_display_monitor_attributes_list): New functions.
3236 (display-usable-bounds): Remove.
3237 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3238 Qsource.
3239
7583e2a0
PE
32402013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3241
3242 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3243 (GTK_CHECK_VERSION): New macro, if not already defined.
3244 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3245 replaced by GTK_CHECK_VERSION.
3246
ad75d77e
PE
32472013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3248
3249 * xterm.h (GTK_PREREQ): New macro.
3250 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3251 to use this macro instead, for consistency and clarity.
3252
07525f77
EZ
32532013-05-08 Eli Zaretskii <eliz@gnu.org>
3254
3255 * xdisp.c (row_for_charpos_p): New function, with code of
3256 cursor_row_p, but accepts an additional argument CHARPOS instead
3257 of using a hardcoded PT.
3258 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3259 (row_containing_pos): Call row_for_charpos_p instead of partially
3260 doing the same. Fixes cursor positioning under longlines-mode
3261 when longlines-show-effect includes more than one newline, when
3262 moving the cursor vertically up.
3263
d901fc8d
JB
32642013-05-08 Juanma Barranquero <lekktu@gmail.com>
3265
3266 * makefile.w32-in (ACL_H): New macro.
3267 ($(BLD)/fileio.$(O)): Update dependencies.
3268
f269bc61
PE
32692013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3270
e7b41c4c 3271 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3272 * Makefile.in (LIB_ACL): New macro.
3273 (LIBACL_LIBS): Remove.
3274 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3275 * fileio.c: Include <acl.h>.
3276 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3277 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3278 !acl_errno_valid.
3279 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3280 it ourselves.
3281
f269bc61
PE
3282 * unexelf.c: Don't assume ElfW (Half) fits in int.
3283 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3284 when dealing with ElfW (Half) values, since they can exceed 2**31
3285 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3286 (entry_address): Omit unused NUM arg. All uses changed.
3287
a261c53e
JL
32882013-05-07 Juri Linkov <juri@jurta.org>
3289
3290 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3291 to the string converted from number with `Fnumber_to_string'.
3292 (Bug#14254)
3293
2b66427d
PE
32942013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3295
3296 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3297 This fixes a problem introduced by my previous change.
3298
15acfe41
GM
32992013-05-07 Glenn Morris <rgm@gnu.org>
3300
3301 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3302
5ea03bf5
JD
33032013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3304
3305 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3306
e0c9d565
PE
33072013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 Static checking by GCC 4.8.0.
3310 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3311 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3312 (x_get_monitor_attributes_fallback)
3313 (x_get_monitor_attributes_xinerama)
3314 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3315 Define only if USE_GTK.
3316 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3317 (x_get_monitor_attributes_fallback): Omit unused locals.
3318 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3319 Use double, not float, to avoid mixed-mode floating point arithmetic.
3320
4e3f9230
YM
33212013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3322 Jan Djärv <jan.h.d@swipnet.se>
3323
3324 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3325 (XINERAMA_CFLAGS): New macros.
3326 (ALL_CFLAGS, LIBES): Use them.
3327
3328 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3329 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3330 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3331 (syms_of_xfns): DEFSYM them.
3332 (struct MonitorInfo): New struct.
3333 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3334 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3335 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3336 (x_get_monitor_attributes_xinerama): New functions.
3337 (Fx_display_monitor_attributes_list): New primitive.
3338 (syms_of_xfns): Defsubr it.
3339
3340 * xterm.h (x_display_info): Add Xatom_net_workarea and
3341 Xatom_net_current_desktop.
3342
3343 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3344 and dpyinfo->Xatom_net_current_desktop.
3345
05839b6a
EZ
33462013-05-06 Eli Zaretskii <eliz@gnu.org>
3347
3348 * xdisp.c (pos_visible_p): Use the special code for finding the
3349 beginning of a display property or overlay for any "replacing"
3350 display property, not just for display strings. This solves
3351 incorrect reporting of position by posn-at-point. (Bug#14241)
3352
dc4a2ee0
PE
33532013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3354
5ee94506
PE
3355 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3356 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3357 Verify that ElfW (Half) fits in int.
3358 (fatal): Use same signature as lisp.h.
3359 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3360 configure and build with -DUNEXELF_DEBUG without worrying about
3361 other modules that use DEBUG.
3362 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3363 possibly-wide integers now uses it instead of plain fprintf.
3364 (entry_address): New function, which avoids problems with 32-bit
3365 overflow on 64-bit hosts.
3366 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3367 (round_up): Don't assume the remainder fits in int.
3368 (find_section): Use bool for boolean. Simplify debug code.
3369 (unexec): Don't assume file sizes fit in int or size_t.
3370 Omit unnecessary trailing newline in 'fatal' format.
3371 Use strerror rather than outputting decimal error number.
3372 Remove unused code when emacs is not defined;
3373 this file relies on Emacs now.
3374 Don't assume e_phnum and e_shnum are positive.
3375
dc4a2ee0
PE
3376 * regex.c: Fix problems when DEBUG is defined.
3377 (extract_number, extract_number_and_incr): Define regardless of
3378 whether DEBUG is defined; that's simpler and makes the code less
3379 likely to go stale in the normal case when DEBUG is not defined.
3380 Return int rather than taking an int * arg. All callers changed.
3381 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3382 Remove, replacing with ...
3383 (DEBUG_PRINT): New macro. All callers changed.
3384 (DEBUG_COMPILES_ARGUMENTS): New macro.
3385 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3386 (print_compiled_pattern, print_double_string) [DEBUG]:
3387 Use prototype rather than old-style definition.
3388 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3389 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3390 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3391 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3392 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3393 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3394 This matters only when DEBUG is defined.
3395
14c7ed05
EZ
33962013-05-05 Eli Zaretskii <eliz@gnu.org>
3397
3398 * xdisp.c (set_iterator_to_next): Set the
3399 ignore_overlay_strings_at_pos_p flag only if we are _really_
3400 iterating over an overlay string, as indicated by the
3401 current.overlay_string_index member. (Bug#14306)
3402
e6076b1b
JD
34032013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3404
3405 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3406 to where it is used, to avoid autorelease issues (Bug#14050).
3407
cbee2131
PE
34082013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3411 * fileio.c (syms_of_fileio): Implement this.
3412 * filelock.c (create_lock_file): If symbolic links don't work, so
3413 we use a regular file as a lock file, do not fsync the lock file;
3414 it's not needed.
3415
30c7e542
SM
34162013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3417
3418 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3419 (syms_of_minibuf): Adjust accodingly.
3420 * lread.c (Fread):
3421 * callint.c (Fcall_interactively): Adjust calls accordingly.
3422
5bebd186
EZ
34232013-05-04 Eli Zaretskii <eliz@gnu.org>
3424
3425 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3426 w->contents is a buffer before computing everything else.
3427 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3428
3429 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3430 assertion violations. (Bug#14062)
3431
0fb0a4f3
DR
34322013-05-01 David Reitter <david.reitter@gmail.com>
3433
3434 * nsfns.m (ns_tooltip): Initialize.
3435
9e63b4a5
EZ
34362013-04-28 Eli Zaretskii <eliz@gnu.org>
3437
3438 * coding.c (decode_coding_gap): Don't remove the character before
3439 a newline unless it's a CR character. (Bug#14287)
3440
ad60824e
DN
34412013-04-28 Dan Nicolaescu <dann@gnu.org>
3442
3443 * dispextern.h (struct face): Move enum face_underline_type
3444 earlier so that bitfields can be in the same word.
3445
edbdcec0
JD
34462013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3447
3448 * nsfns.m (handlePanelKeys): New function.
3449 (EmacsOpenPanel:performKeyEquivalent:)
3450 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3451 arrows/function/control and copy/paste keys (Bug#14296).
3452
0208ede7
JL
34532013-04-27 Juri Linkov <juri@jurta.org>
3454
3455 * callint.c (Fcall_interactively): Call `Qread_number' for
3456 interactive code letter `n' instead of using duplicate code.
3457 (Bug#14254)
3458
b8dd59f7
PE
34592013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3460
3461 * systime.h (make_timeval): Declare as 'const'.
3462
8bd722db
KH
34632013-04-27 Kenichi Handa <handa@gnu.org>
3464
3465 * font.c (font_open_entity): Always open a font of manageable
3466 size.
3467
13d0e56f 34682013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3469
f780d632
PE
3470 Port better to AIX (Bug#14258).
3471 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3472 to pacify AIX xlc.
3473
ec509856
KH
34742013-04-24 Kenichi Handa <handa@gnu.org>
3475
3476 * coding.c (decode_coding_iso_2022): When an invalid escape
3477 sequence is encountered, reset the invocation and designation
3478 status to the safest one.
3479
84fc48e5
PE
34802013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3483 Without this fix, "make distclean" leaves stamp-h1 behind.
3484
806bda47
EC
34852013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3486
3487 * w32fns.c (w32_fullscreen_rect): New function to compute the
3488 window rectangle for the given fullscreen mode.
3489 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3490 longer tunes the window size. This keeps the window's edges flush
3491 with the screen and allows the taskbar to hide itself in fullboth.
3492
3493 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3494 window decorations and uses the entire screen.
3495
3496 * w32term.h (w32_fullscreen_rect) Add prototype.
3497 (struct w32_output): Replace normal_width, normal_height,
3498 normal_top, and normal_left members with a single normal_placement
3499 struct.
3500 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3501 Remove macros.
3502 (FRAME_NORMAL_PLACEMENT): New macro.
3503
9cc2810b
JB
35042013-04-16 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * minibuf.c (Ftest_completion): Silence compiler warning.
3507
fd16b54c
EZ
35082013-04-15 Eli Zaretskii <eliz@gnu.org>
3509
3510 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3511 bug#14062.
fd16b54c
EZ
3512
3513 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3514 parentheses.
3515
3516 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3517 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3518 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3519 parentheses where appropriate.
3520
9e3379a0
PE
35212013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3524
ddd6b685
EZ
35252013-04-14 Eli Zaretskii <eliz@gnu.org>
3526
3527 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3528 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3529 Mention in the doc string that setting these variables takes
3530 effect only after a call to set-window-buffer. (Bug#14200)
3531
29b79ba1
EZ
35322013-04-13 Eli Zaretskii <eliz@gnu.org>
3533
3534 * indent.c (Fvertical_motion): Don't consider display strings on
3535 overlay strings as display strings on the buffer position we
3536 started from. This prevents vertical cursor motion from jumping
3537 more than one line when there's an overlay string with a display
3538 property at end of line.
3539 Reported by Karl Chen <Karl.Chen@quarl.org> in
3540 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3541
562c6ee9
SM
35422013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3543
3544 * window.c (select_window): `record_buffer' even if window is
3545 already selected (bug#14191).
3546
fcc1fe85
EZ
35472013-04-11 Eli Zaretskii <eliz@gnu.org>
3548
3549 * window.c (Fwindow_end): Test more flags, including the buffer's
3550 last_overlay_modified flag, to determine whether the window's
3551 display is really up-to-date. Prevents the function from
3552 returning a stale value. (Bug#14170)
3553 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3554 current matrix.
3555
f009190a
EZ
35562013-04-10 Eli Zaretskii <eliz@gnu.org>
3557
3558 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3559 garbaged only if it is not already the top frame on its TTY.
3560 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3561 there are GUI frames open in the same session. (Bug#13864)
3562
78ce603d
SM
35632013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3564
3565 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3566 of marking the idle timers directly.
3567
a8036e40
SM
35682013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3569
3570 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3571 tables (bug#14054).
3572
7ffe7ef6
SM
35732013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3574
3575 * window.c (select_window): Don't record_buffer while the invariant is
3576 temporarily broken (bug#14161).
3577
3578 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3579
7d9f6883
EZ
35802013-04-07 Eli Zaretskii <eliz@gnu.org>
3581
3582 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3583
5406cfd9
RF
35842013-04-07 Romain Francoise <romain@orebokech.com>
3585
3586 Ignore additional platform-specific ACL errors (Bug#13702).
3587 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3588 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3589
95c0e83b
JD
35902013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3591
3592 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3593 f->output_data.ns.
3594
876da980
PE
35952013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3598 This bug was introduced by my 2013-02-25 change that simplified
3599 data_start configuration. Without this change, on GNU/Linux
3600 an Emacs configured with --enable-profiling fails immediately
3601 due to a profiler signal.
3602 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3603 with these flags. On platforms where special flags are needed
3604 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3605 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3606 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3607
7452b7bd
DA
36082013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3609
3610 Get rid of some platform-specific functions examining window
3611 system and its capabilities. This is a partial rework of the
3612 2013-04-05 change.
3613 * lisp.h (have_menus_p): Remove prototype. This function is
3614 replaced with platform-independent window_system_available.
3615 (check_window_system): Move to...
3616 * frame.h (decode_window_system_frame, window_system_available):
3617 ...here, add new prototypes.
3618 * frame.c (window_system_available, decode_window_system_frame):
3619 New functions.
3620 (check_window_system): Platform-independent now.
3621 * xterm.h (x_in_use): Remove declaration.
3622 (check_x_frame):
3623 * w32term.h (check_x_frame):
3624 * nsterm.h (check_x_frame): Remove prototypes. This function
3625 is replaced with platform-independent decode_window_system_frame.
3626 * msdos.c (have_menus_p): Remove.
3627 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3628 Remove platform-specific functions. Use check_window_system,
3629 decode_window_system_frame and check_ns_display_info where
3630 appropriate. Minor style and comment tweaks.
3631 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3632 (check_x_frame): Likewise.
3633 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3634 Likewise.
3635 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3636 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3637 * xmenu.c, xselect.c: All related users changed.
3638
251e9147
KH
36392013-04-03 Kenichi Handa <handa@gnu.org>
3640
3641 The following changes is to optimize the code for reading UTF-8
3642 files.
3643
562c6ee9 3644 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3645 changed. Check EOL format. Do not call adjust_coding_eol_type
3646 here.
3647 (check_utf_8): New function.
3648 (adjust_coding_eol_type): Do nothing if already adjusted.
3649 (detect_coding): Compare the return value of check_ascii with
3650 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3651 (decode_coding_gap): Optimize for valid UTF-8.
3652
8bc369d4
KH
36532013-03-21 Kenichi Handa <handa@gnu.org>
3654
3655 * coding.c (syms_of_coding): Cancel previous change.
3656
3657 * insdel.c (insert_from_gap): Fix previous change.
3658
73931ad1
DA
36592013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3660
3661 Consistently use platform-specific function to detect window system.
3662 * lisp.h (check_window_system): New prototype. This function is
3663 going to replace check_x, check_w32 and check_ns.
3664 (have_menus_p): Mention msdos.c in comment.
3665 * fontset.c (check_window_system_func): Remove. Adjust all users.
3666 * fontset.h (check_window_system_func): Remove prototype.
3667 * nsterm.h (check_ns):
3668 * xterm.h (check_x):
3669 * w32term.h (check_w32): Likewise.
3670 * menu.c (Fx_popup_menu): Use check_window_system.
3671 * msdos.c (check_window_system): Define for MS-DOS.
3672 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3673 * w32fns.c (check_window_system): Likewise for MS-Windows.
3674 * xfns.c (check_window_system): Likewise for X.
3675 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3676 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3677
7216e43b
PE
36782013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3679
3680 Prefer < to > in range checks such as 0 <= i && i < N.
3681 This makes it easier to visualize quantities on a number line.
3682 This patch doesn't apply to all such range checks,
3683 only to the range checks affected by the 2013-03-24 change.
3684 This patch reverts most of the 2013-03-24 change.
3685 * alloc.c (xpalloc, Fgarbage_collect):
3686 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3687 * character.c (string_escape_byte8):
3688 * charset.c (read_hex):
3689 * data.c (cons_to_unsigned):
3690 * dispnew.c (update_frame_1):
3691 * doc.c (Fsubstitute_command_keys):
3692 * doprnt.c (doprnt):
3693 * editfns.c (hi_time, decode_time_components):
3694 * fileio.c (file_offset):
3695 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3696 * font.c (font_intern_prop):
3697 * frame.c (x_set_alpha):
3698 * gtkutil.c (get_utf8_string):
3699 * indent.c (check_display_width):
3700 * keymap.c (Fkey_description):
3701 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3702 * lread.c (read1):
3703 * minibuf.c (read_minibuf_noninteractive):
3704 * process.c (wait_reading_process_output):
3705 * search.c (Freplace_match):
3706 * window.c (get_phys_cursor_glyph):
3707 * xdisp.c (redisplay_internal):
3708 * xsmfns.c (smc_save_yourself_CB):
3709 Prefer < to > for range checks.
3710 * dispnew.c (sit_for): Don't mishandle NaNs.
3711 This fixes a bug introduced in the 2013-03-24 change.
3712 * editfns.c (decode_time_components): Don't hoist comparison.
3713 This fixes another bug introduced in the 2013-03-24 change.
3714
92759988
DA
37152013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3716
3717 * frame.h (struct frame): Drop scroll_bottom_vpos
3718 member becaue all real users are dead long ago.
3719 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3720 * xdisp.c (redisplay_internal): Adjust user.
3721
9a1971bb
GM
37222013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3723
f38ab167
JD
3724 * nsmenu.m (showAtX:Y:for:): setLevel to
3725 NSPopUpMenuWindowLevel (Bug#13998).
3726
6d01f1fe
JD
37272013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3728
3729 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3730 (ns_check_pending_open_menu): Declare.
3731
3732 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3733 (x_activate_menubar): Update the menu with title that matches
3734 ns_get_pending_menu_title, and call
3735 ns_check_pending_openmenu (Bug#12698).
3736 (menuWillOpen:): New method.
3737 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3738
3739 * nsterm.m (menu_will_open_state, menu_mouse_point)
3740 (menu_pending_title): New varaibles.
3741 (ns_get_pending_menu_title, ns_check_menu_open)
3742 (ns_check_pending_open_menu): New functions.
3743
781f4782
DA
37442013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3745
3746 * indent.c (current_column_bol_cache): Remove leftover which is not
3747 used in Fmove_to_column any more.
3748 (current_column, scan_for_column): Adjust users.
3749 * keyboard.c (last_point_position_buffer, last_point_position_window):
3750 Remove leftovers which are not used for recording undo any more.
3751 (command_loop_1, syms_of_keyboard): Adjust users.
3752 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3753 redisplay_window any more.
3754 (move_it_to): Adjust user.
3755
1921c31b
JB
37562013-03-29 Juanma Barranquero <lekktu@gmail.com>
3757
3758 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3759 Update dependencies.
3760
717b8bcd
SM
37612013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3762
3763 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3764 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3765 forward references.
3766
e74aeda8
DA
37672013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3768
3769 * window.h (struct window): Replace hchild, vchild and buffer slots
3770 with the only contents slot. This is possible because each valid
3771 window may have either the child window (in vertical or horizontal
3772 combination) or buffer to display (for the leaf window). Using that,
3773 a lof of operations to traverse and/or change window hierarchies may
3774 be simplified. New member horizontal is used to distinguish between
3775 horizontal and vertical combinations of internal windows.
3776 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3777 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3778 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3779 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3780 Use contents slot, not buffer, where appropriate.
3781 (wset_combination): New function.
3782 (wset_buffer): Add eassert.
3783 (Fframe_first_window): Simplify the loop reaching first window.
3784 (Fwindow_buffer): Use WINDOW_LEAF_P.
3785 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3786 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3787 (unshow_buffer): Convert initial debugging check to eassert.
3788 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3789 (make_parent_window, window_resize_check, window_resize_apply)
3790 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3791 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3792 Adjust to match struct window changes.
3793 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3794 (mark_window_cursors_off, count_windows, get_leaf_windows)
3795 (foreach_window_1): Simplify the loop.
3796 * alloc.c (mark_object): Do not check for the leaf window because
3797 internal windows has no glyph matrices anyway.
3798 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3799 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3800 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3801 (build_frame_matrix_from_window_tree, mirror_make_current)
3802 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3803 (update_window_tree, set_window_update_flags): Simplify the loop.
3804 (sync_window_with_frame_matrix_rows): Enforce live window.
3805 Use contents slot, not buffer, where appropriate.
3806 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3807 and WINDOW_HORIZONTAL_COMBINATION_P.
3808 (make_frame_visible_1): Simplify the loop.
3809 Use contents slot, not buffer, where appropriate.
3810 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3811 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3812 (expose_window_tree): Likewise.
3813 Use contents slot, not buffer, where appropriate.
3814 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3815 to avoid deleted windows. Use contents slot instead of buffer.
3816 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3817 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3818 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3819 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3820
121ab1cd
EZ
38212013-03-28 Eli Zaretskii <eliz@gnu.org>
3822
ef454cf7
EZ
3823 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3824 identify the reasons for assertion violations in bug#14062 and
3825 similar ones.
21e930f8
EZ
3826 (Fx_show_tip): Fix compilation error under
3827 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3828
121ab1cd
EZ
3829 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3830 Reported by <rzl24ozi@gmail.com>.
3831
5c89ca24
DA
38322013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3833
3834 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3835 start marker...
562c6ee9
SM
3836 (unwind_with_echo_area_buffer): ...to restore it here.
3837 This is needed to ensure that...
5c89ca24
DA
3838 (redisplay_window): ...both window markers are valid here,
3839 which is verified by eassert.
3840 * editfns.c (save_excursion_save): Do not assume that
3841 selected_window always displays the buffer.
c7f53895
DA
3842 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3843 Fix comment.
5c89ca24 3844
f557c1b1
SM
38452013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3846
3847 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3848 the upcase table.
3849
40693bba 38502013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3851
3852 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3853
c86f791f
EZ
38542013-03-27 Eli Zaretskii <eliz@gnu.org>
3855
3856 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3857 since MinGW's w32api headers do. This avoids compiler warnings.
3858
3859 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3860 if already defined.
3861
c6e72e17
EZ
38622013-03-26 Eli Zaretskii <eliz@gnu.org>
3863
3864 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3865
54e95010
JD
38662013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3867
3868 * gtkutil.c (style_changed_cb): Check if frame is live and an
3869 X frame (Bug#14038).
3870
b88b62de
EZ
38712013-03-26 Eli Zaretskii <eliz@gnu.org>
3872
a18d7de6
EZ
3873 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3874 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3875 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3876 MinGW64.
8f5e14c8
EZ
3877 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3878 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3879
b88b62de
EZ
3880 Fix incompatibilities between MinGW.org and MinGW64 headers.
3881 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3882
3883 * w32.c (REPARSE_DATA_BUFFER): Guard with
3884 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3885
c074e458
JD
38862013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3887
3888 * xterm.c: Include X11/XKBlib.h
3889 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3890
908589fd
AS
38912013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3892
3893 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3894 written backwards.
3895 * blockinput.h (input_blocked_p): Likewise.
3896 * bytecode.c (exec_byte_code): Likewise.
3897 * callproc.c (call_process_kill, call_process_cleanup)
3898 (Fcall_process): Likewise.
3899 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3900 (Fccl_execute_on_string): Likewise.
3901 * character.c (string_escape_byte8): Likewise.
3902 * charset.c (read_hex): Likewise.
3903 * cm.c (calccost): Likewise.
3904 * data.c (cons_to_unsigned): Likewise.
3905 * dired.c (directory_files_internal, file_name_completion):
3906 Likewise.
3907 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3908 (sit_for): Likewise.
3909 * doc.c (Fsubstitute_command_keys): Likewise.
3910 * doprnt.c (doprnt): Likewise.
3911 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3912 * emacsgtkfixed.c: Likewise.
3913 * fileio.c (file_offset, Fwrite_region): Likewise.
3914 * floatfns.c (Fexpt, fmod_float): Likewise.
3915 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3916 Likewise.
3917 * font.c (font_intern_prop): Likewise.
3918 * frame.c (x_set_alpha): Likewise.
3919 * gtkutil.c (get_utf8_string): Likewise.
3920 * indent.c (check_display_width): Likewise.
3921 * intervals.c (create_root_interval, rotate_right, rotate_left)
3922 (split_interval_right, split_interval_left)
3923 (adjust_intervals_for_insertion, delete_node)
3924 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3925 (merge_interval_right, merge_interval_left, copy_intervals)
3926 (set_intervals_multibyte_1): Likewise.
3927 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3928 * keymap.c (Fkey_description): Likewise.
3929 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3930 * lread.c (openp, read_integer, read1, string_to_number):
3931 Likewise.
3932 * menu.c (ensure_menu_items): Likewise.
3933 * minibuf.c (read_minibuf_noninteractive): Likewise.
3934 * print.c (printchar, strout): Likewise.
3935 * process.c (create_process, Faccept_process_output)
3936 (wait_reading_process_output, read_process_output, send_process)
3937 (wait_reading_process_output): Likewise.
3938 * profiler.c (make_log, handle_profiler_signal): Likewise.
3939 * regex.c (re_exec): Likewise.
3940 * regex.h: Likewise.
3941 * search.c (looking_at_1, Freplace_match): Likewise.
3942 * sysdep.c (get_child_status, procfs_ttyname)
3943 (procfs_get_total_memory): Likewise.
3944 * systime.h (EMACS_TIME_VALID_P): Likewise.
3945 * term.c (dissociate_if_controlling_tty): Likewise.
3946 * window.c (get_phys_cursor_glyph): Likewise.
3947 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3948 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3949 Likewise.
3950 * xfns.c (Fx_window_property): Likewise.
3951 * xmenu.c (set_frame_menubar): Likewise.
3952 * xselect.c (x_get_window_property, x_handle_dnd_message):
3953 Likewise.
3954 * xsmfns.c (smc_save_yourself_CB): Likewise.
3955 * xterm.c (x_scroll_bar_set_handle): Likewise.
3956
2bf7d27a
DA
39572013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3958
3959 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3960 to be optional or nil. Adjust comment and convert it to docstring.
3961 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3962 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3963
a9ebfa0b
PE
39642013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3965
3966 Static checking by GCC 4.8-20130319.
3967 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3968 * process.c (Fset_process_datagram_address)
3969 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3970 * xdisp.c (get_char_face_and_encoding):
3971 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3972 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3973 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3974
4f3576ee
KB
39752013-03-24 Ken Brown <kbrown@cornell.edu>
3976
789b5e9a
KB
3977 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3978 fix compilation on 64-bit Cygwin, where underscores are not
3979 automatically prepended.
3980
4f3576ee
KB
3981 * w32term.c (w32_initialize): Silence compiler warning.
3982
b5b7745f
EZ
39832013-03-23 Eli Zaretskii <eliz@gnu.org>
3984
cdc0d0bd
EZ
3985 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3986 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3987 variables, to save and restore frame dimensions.
3988 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3989 after returning from a 'fullscreen' configuration.
3990 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3991 to avoid races between the main thread and the input thread.
3992
3993 * w32term.h (struct w32_output): New members normal_width,
3994 normal_height, normal_top, normal_left, and prev_fsmode.
3995 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3996 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3997 members of a frame.
3998
b5b7745f
EZ
3999 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4000 'fullscreen' parameter. Always record previous width and height
4001 of the frame, except when switching out of maximized modes, so
4002 that they could be restored correctly, instead of resetting to the
4003 default frame dimensions. Send SC_RESTORE command to the frame,
4004 unless we are going to send SC_MAXIMIZE, to restore the frame
4005 resize hints in the mouse pointer shown by the window manager.
4006 (Bug#14032)
4007
4008 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4009
4010 * lisp.h (get_frame_param): Adjust conditions for prototype
4011 declaration.
4012
a3454eed
KB
40132013-03-22 Ken Brown <kbrown@cornell.edu>
4014
4015 * unexcw.c: Drop unneeded inclusion of w32common.h.
4016 (report_sheap_usage): Declare.
4017 (read_exe_header): Add magic numbers for x86_64.
4018 (fixup_executable): Fix printf format specifier for unsigned long
4019 argument.
4020
5a49b79c
DA
40212013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4022
4023 * frame.h (struct frame): Put menu_bar_window under #ifdef
4024 because this member is not needed when X toolkit is in use.
4025 (fset_menu_bar_window):
4026 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4027 (free_glyphs, update_frame):
4028 * xdisp.c (expose_frame): Likewise.
4029 (display_menu_bar): Likewise. Remove redundant eassert.
4030 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4031 toolkit is in use.
4032
d6723bf7
PE
40332013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4034
7b1123d8
PE
4035 Use functions and constants to manipulate Lisp_Save_Value objects.
4036 This replaces code that used macros and strings and token-pasting.
4037 The change makes the C source a bit easier to follow,
4038 and shrinks the Emacs executable a bit.
4039 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4040 (make_save_value): Change 1st arg from string to enum. All callers
4041 changed.
4042 (INTX): Remove.
4043 (mark_object): Use if, not #if, for GC_MARK_STACK.
4044 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4045 (XSAVE_OBJECT): Now functions, not macros.
4046 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4047 the constant was never used.
4048 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4049 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4050 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4051 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4052 New constants.
4053 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4054 type3 with a single member save_type. All uses changed.
4055 (save_type, set_save_pointer, set_save_integer): New functions.
4056 * print.c (PRINTX): Remove.
4057
d6723bf7
PE
4058 * alloc.c: Remove redundant static declarations.
4059
5f24fa51
DA
40602013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4061
4062 * window.h (struct window): Convert left_col, top_line, total_lines
4063 and total_cols from Lisp_Objects to integers. Adjust comments.
4064 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4065 Remove.
4066 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4067 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4068 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4069 Adjust users where appropriate.
4070
42143acd
DA
40712013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4072
4073 * frame.h (struct frame): Drop resx and resy because the same data is
4074 available from window system-specific output context. Adjust users.
562c6ee9
SM
4075 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4076 New functions to provide defaults when no window system available.
42143acd 4077 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4078 (NUMVAL): Move from xdisp.c.
42143acd
DA
4079 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4080 (Ffont_face_attributes, Fopen_font):
4081 * image.c (gs_load):
4082 * w32font.c (fill_in_logfont):
4083 * xdisp.c (calc_pixel_width_or_height):
4084 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4085 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4086
c0a17406
KH
40872013-03-20 Kenichi Handa <handa@gnu.org>
4088
4089 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4090 to 1 (temporary workaround until a bug related to ASCII
4091 optimization is fixed).
4092
095d384d
DA
40932013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4094
4095 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4096 Signal error if window is not internal. Adjust docstring.
4097 (delete_all_child_windows): Use combination_limit to save the buffer.
4098 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4099 * print.c (syms_of_print): Initialize debugging output not here...
4100 (init_print_once): ...but in a new function here.
4101 * lisp.h (init_print_once): Add prototype.
4102 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4103
748fa866
DA
41042013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4105
4106 * window.c (window_resize_check, window_resize_apply)
4107 (window_from_coordinates, recombine_windows, set_window_buffer)
4108 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4109 (Fsplit_window_internal, Fdelete_window_internal)
4110 (freeze_window_starts): Use bool for booleans.
4111 * window.h (window_frame_coordinates, resize_frame_windows)
4112 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4113
81519fd2
SM
41142013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4115
4116 * dispnew.c (bitch_at_user): Use `user-error'.
4117
6db423a9
KB
41182013-03-17 Ken Brown <kbrown@cornell.edu>
4119
4120 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4121 as return type of image_background. (Bug#13981)
4122 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4123
8f2906f5
JD
41242013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4125
960ce480 4126 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4127 (ns_select): Don't return with result uninitialized.
960ce480 4128
8f2906f5
JD
4129 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4130 and getDirectory.
4131
81519fd2
SM
4132 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4133 New functions.
8f2906f5
JD
4134 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4135 directories. If filename is nil, get directory name (Bug#13932).
4136 Use getFilename and getDirectory.
4137 (getFilename, getDirectory): New methods for EmacsSavePanel and
4138 EmacsOpenPanel.
4139 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4140
cded56c1
PE
41412013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4142
4143 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4144
251e9147 41452013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4146
4147 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4148 (adjust_after_replace): Make it back to static. Delete the third
4149 arg text_at_gap_tail. Cancel the code for handling it.
4150
4151 * coding.h (struct coding_system): New member eol_seen.
4152
4153 * coding.c (detect_ascii): New function.
4154 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4155 when the source bytes are actually scanned. On detecting for
4156 coding_category_utf_8_auto, call detect_ascii instead of scanning
4157 source bytes directly.
4158 (produce_chars): Call insert_from_gap with the new arg 0.
4159 (encode_coding): Likewise.
4160 (decode_coding_gap): Control ASCII optimization by the variable
4161 disable_ascii_optimization instead of #ifndef .. #endif.
4162 Deccode EOL format according to coding->eol_seen.
4163 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4164 variable.
4165
8a44e6d1
KH
4166 * lisp.h (adjust_after_replace): Cancel externing it.
4167 (insert_from_gap): Adjust prototype.
4168
5f795e34
EZ
41692013-03-15 Eli Zaretskii <eliz@gnu.org>
4170
4171 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4172 FULLSCREEN_MAXIMIZED. (Bug#13935)
4173
f258b4be
DA
41742013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4175
4176 * region-cache.c (find_cache_boundary, move_cache_gap)
4177 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4178 Simplify debugging check and convert to eassert. Adjust comment.
4179 (pp_cache): Put under ENABLE_CHECKING.
4180
a5cc4dde
EZ
41812013-03-14 Eli Zaretskii <eliz@gnu.org>
4182
4183 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4184 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4185 and WM_ACTIVATEAPP.
4186 (w32fullscreen_hook): If the frame is visible, reset
4187 f->want_fullscreen flag after changing the frame size. If the
4188 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4189 (Bug#13953)
4190
3fc5e44a
DC
41912013-03-13 Daniel Colascione <dancol@dancol.org>
4192
4193 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4194 too so that these builds can use Cygwin's file conversion
4195 functions. (We've been building and linking cygw32.o all along
4196 and just not using it.)
4197
47d7532e
PE
41982013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4199
4200 File synchronization fixes (Bug#13944).
4201 * Makefile.in (LIB_FDATASYNC): New macro.
4202 (LIBES): Use it.
4203 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4204 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4205 Don't worry about HAVE_FSYNC, since a substitute fsync is
4206 available if the system lacks one.
4207 (Fwrite_regin): Retry fsync if interrupted.
4208
c7ffccaf
EZ
42092013-03-13 Eli Zaretskii <eliz@gnu.org>
4210
4e2df81d 4211 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4212 activated, call w32fullscreen_hook, to make sure the new frame
4213 dimensions are in effect. (Bug#13937)
4214
8a7debc1
DA
42152013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4216
4217 * xdisp.c (init_iterator): Simplify because both character and byte
4218 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4219 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4220 character and byte positions can be obtained from marker.
8a7debc1 4221
7fd8c501
PE
42222013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4223
d9df6f40
PE
4224 Static checking by Sun C 5.12.
4225 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4226 * bytecode.c (exec_byte_code):
4227 * dispnew.c (init_display):
4228 * eval.c (error):
4229 * fileio.c (Fsubstitute_in_file_name):
4230 * keyboard.c (Fevent_convert_list):
4231 * keymap.c (Fsingle_key_description):
4232 * term.c (maybe_fatal, fatal):
4233 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4234 * xsmfns.c (Fhandle_save_session):
4235 Omit unreachable code.
4236 * keymap.c (map_keymap_char_table_item): Cast void * to
4237 a function pointer type; the C Standard requires this.
4238
7fd8c501
PE
4239 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4240 Include <sys/param.h> unconditionally, as that works elsewhere and
4241 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4242 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4243 and FreeBSD now.
4244
a020afb9 4245See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4246
4247;; Local Variables:
4248;; coding: utf-8
aac0c6e3
MR
4249;; End:
4250
ab422c4d 4251 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4252
4253 This file is part of GNU Emacs.
4254
4255 GNU Emacs is free software: you can redistribute it and/or modify
4256 it under the terms of the GNU General Public License as published by
4257 the Free Software Foundation, either version 3 of the License, or
4258 (at your option) any later version.
4259
4260 GNU Emacs is distributed in the hope that it will be useful,
4261 but WITHOUT ANY WARRANTY; without even the implied warranty of
4262 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4263 GNU General Public License for more details.
4264
4265 You should have received a copy of the GNU General Public License
4266 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.