1 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7 * w32console.c (Fset_screen_color): Doc fix.
8 (Fget_screen_color): New function.
9 (syms_of_ntterm): Defsubr it.
11 * callproc.c (call_process_cleanup): Don't close and unlink the
12 temporary file if Fcall_process didn't create it in the first
14 (Fcall_process): Don't create tempfile if stdout of the child
15 process will be redirected to a file specified with `:file'.
16 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
17 cue to call_process_cleanup not to close that handle.
19 2011-05-07 Ben Key <bkey76@gmail.com>
21 * makefile.w32-in: The bootstrap-temacs rule now makes use of
22 one of two shell specific rules, either bootstrap-temacs-CMD or
23 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
24 to the previous implementation of the bootstrap-temacs rule.
25 The bootstrap-temacs-CMD rule is similar to the previous
26 implementation of the bootstrap-temacs rule except that it
27 makes use of the ESC_CFLAGS variable instead of the CFLAGS
30 These changes, along with some changes to nt/configure.bat,
31 nt/gmake.defs, and nt/nmake.defs, are required to extend my
32 earlier fix to add support for --cflags and --ldflags options
33 that include quotes so that it works whether make uses cmd or
36 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
38 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
39 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
41 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
42 a string. Handle both cases.
43 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
44 (Fdbus_register_method): Use Qinvalid_function.
46 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
48 * makefile.w32-in: Update dependencies.
49 (LISP_H): Add inttypes.h and stdin.h.
50 (PROCESS_H): Add unistd.h.
52 2011-05-06 Eli Zaretskii <eliz@gnu.org>
54 * lread.c: Include limits.h (fixes the MS-Windows build broken by
55 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
57 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
59 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
61 * term.c (vfatal): Remove stray call to va_end.
62 It's not needed and the C Standard doesn't allow it here anyway.
64 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
65 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
67 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
70 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
72 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
74 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
76 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
78 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
80 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
81 * charset.c (Fdefine_charset_internal): Don't initialize
82 charset.code_space[15]. The value was garbage, on hosts with
83 32-bit int (Bug#8600).
85 * lread.c (read_integer): Be more consistent with string-to-number.
86 Use string_to_number to do the actual conversion; this avoids
87 rounding errors and fixes some other screwups. Without this fix,
88 for example, #x1fffffffffffffff was misread as -2305843009213693952.
89 (digit_to_number): Move earlier, for benefit of read_integer.
90 Return -1 if the digit is out of range for the base, -2 if it is
91 not a digit in any supported base. (Bug#8602)
93 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
95 * dispnew.c (scrolling_window): Return 1 if we scrolled,
96 to match comment at start of function. This also removes a
97 GCC warning about overflow in a 32+64-bit port.
99 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
101 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
102 Reported by Stefan Monnier in
103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
104 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
105 SYMBOLP-guarded XSYMBOL, not XPNTR.
107 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
108 (EMACS_UINTPTR): Likewise, with uintptr_t.
110 * lisp.h: Prefer 64-bit EMACS_INT if available.
111 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
112 on 32-bit hosts that have 64-bit int, so that they can access
114 However, temporarily disable this change unless the temporary
115 symbol WIDE_EMACS_INT is defined.
117 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
119 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
120 This removes an assumption that EMACS_INT and long are the same
121 width as pointers. The assumption is true for Emacs porting targets
122 now, but we want to make other targets possible.
123 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
124 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
125 In the rest of the code, change types of integers that hold casted
126 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
127 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
128 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
129 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
130 No need to cast type when ORing.
131 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
132 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
133 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
134 assume EMACS_INT is the same width as char *.
135 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
136 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
137 Remove no-longer-needed casts.
138 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
139 (xg_tool_bar_help_callback, xg_make_tool_item):
140 Use EMACS_INTPTR to hold an integer
141 that will be cast to void *; this can avoid a GCC warning
142 if EMACS_INT is not the same width as void *.
143 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
144 * xdisp.c (display_echo_area_1, resize_mini_window_1):
145 (current_message_1, set_message_1):
146 Use a local to convert to proper width without a cast.
147 * xmenu.c (dialog_selection_callback): Likewise.
149 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
150 Also, don't assume VALBITS / RAND_BITS is less than 5,
151 and don't rely on undefined behavior when shifting a 1 left into
153 * lisp.h (get_random): Change signature to match.
155 * lread.c (hash_string): Use size_t, not int, for hash computation.
156 Normally we prefer signed values; but hashing is special, because
157 it's better to use unsigned division on hash table sizes so that
158 the remainder is nonnegative. Also, size_t is the natural width
159 for hashing into memory. The previous code used 'int', which doesn't
160 retain enough info to hash well into very large tables.
161 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
163 * dbusbind.c: Don't possibly lose pointer info when converting.
164 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
165 Use XPNTR rather than XHASH, so that the high-order bits of
166 the pointer aren't lost when converting through void *.
168 * eval.c (Fautoload): Don't double-shift a pointer.
170 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
172 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
174 * gnutls.c (DEF_GNUTLS_FN):
175 * image.c (DEF_IMGLIB_FN): Make function pointers static.
177 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
179 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
182 2011-05-05 Eli Zaretskii <eliz@gnu.org>
184 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
185 New version that can reserve upto 2GB of heap space.
187 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
189 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
191 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
193 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
194 `gnutls_certificate_set_x509_key_file'.
196 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
198 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
201 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
203 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
204 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
205 Remove unused parameter `fildes'.
206 * process.c (read_process_output, send_process): Don't pass it.
208 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
210 Fix previous change: the library cache is defined in w32.c.
211 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
212 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
214 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
216 Implement dynamic loading of GnuTLS on Windows.
218 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
219 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
220 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
223 * gnutls.c (Qgnutls_dll): Define.
224 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
225 (gnutls_*): Declare function pointers.
226 (init_gnutls_functions): New function to initialize function pointers.
227 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
228 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
229 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
230 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
231 (emacs_gnutls_write, emacs_gnutls_read)
232 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
233 (Fgnutls_available_p): New function.
234 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
235 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
236 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
238 * image.c: Include w32.h.
239 (Vimage_type_cache): Delete.
240 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
241 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
242 (w32_delayed_load): Move to w32.c.
244 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
246 * w32.c (QCloaded_from, Vlibrary_cache): Define.
247 (w32_delayed_load): Move from image.c. When loading a library, record
248 its filename in the :loaded-from property of the library id.
249 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
250 Initialize and staticpro them.
251 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
253 * process.c: Include lisp.h before w32.h, not after.
254 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
255 instead of gnutls_record_check_pending.
257 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
259 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
261 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
262 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
265 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
267 * xterm.c (x_set_frame_alpha): Do not set property on anything
268 else than FRAME_X_OUTER_WINDOW (Bug#8608).
270 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
272 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
274 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
276 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
277 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
278 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
279 (gnutls_global_initialized, Qgnutls_bootprop_priority)
280 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
281 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
282 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
283 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
284 (Qgnutls_bootprop_callbacks_verify): Make static.
286 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
288 * callproc.c: Indentation fixup.
290 * sysdep.c (wait_for_termination_1): Make static.
291 (wait_for_termination, interruptible_wait_for_termination): Move
292 after wait_for_termination_1.
294 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
296 * sysdep.c (interruptible_wait_for_termination): New function
297 which is like wait_for_termination, but allows keyboard
300 * callproc.c (Fcall_process): Add (:file "file") as an option for
302 (Fcall_process_region): Ditto.
304 2011-04-30 Eli Zaretskii <eliz@gnu.org>
306 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
307 rather than `XVECTOR (FOO)->size'.
309 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
310 inttypes.h, as a gnulib replacement is used if it not available in
313 2011-04-21 Eli Zaretskii <eliz@gnu.org>
315 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
316 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
317 of MOST_POSITIVE_FIXNUM. (Bug#8528)
319 * coding.c (coding_alloc_by_realloc): Error out if destination
320 will grow beyond MOST_POSITIVE_FIXNUM.
321 (decode_coding_emacs_mule): Abort if there isn't enough place in
322 charbuf for the composition carryover bytes. Reserve an extra
323 space for up to 2 characters produced in a loop.
324 (decode_coding_iso_2022): Abort if there isn't enough place in
325 charbuf for the composition carryover bytes.
327 2011-04-21 Eli Zaretskii <eliz@gnu.org>
329 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
330 aborting when %lld or %lll format is passed.
331 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
332 %llo or %llx format is passed. (Bug#8545)
334 * window.c (window_scroll_line_based): Use a marker instead of
335 simple variables to record original value of point. (Bug#7952)
337 * doprnt.c (doprnt): Fix the case where a multibyte sequence
338 produced by %s or %c overflows available buffer space. (Bug#8545)
340 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
342 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
343 (SIZE_MAX): Move defn after all includes, as they might #define it.
345 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
347 * w32.c (init_environment): Warn about defaulting HOME to C:\.
349 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
351 * keyboard.c (Qdelayed_warnings_hook): Define.
352 (command_loop_1): Run `delayed-warnings-hook'
353 if Vdelayed_warnings_list is non-nil.
354 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
355 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
357 2011-04-28 Eli Zaretskii <eliz@gnu.org>
359 * doprnt.c (doprnt): Don't return value smaller than the buffer
360 size if the message was truncated. (Bug#8545).
362 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
364 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
365 (Fx_window_property): #if-0 the whole functions, not just the bodies.
367 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
369 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
371 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
373 * makefile.w32-in: Update dependencies.
375 2011-04-27 Eli Zaretskii <eliz@gnu.org>
377 Improve `doprnt' and its usage. (Bug#8545)
378 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
379 `format_end'. Remove support for %l as a conversion specifier.
380 Don't use xrealloc. Improve diagnostics when the %l size modifier
381 is used. Update the commentary.
383 * eval.c (verror): Simplify calculation of size_t.
385 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
388 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
390 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
393 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
395 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
396 This makes this file independent of the recent pseudovector change.
398 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
400 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
402 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
403 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
405 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
407 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
408 GCC 4.6.0 optimizes based on type-based alias analysis. For
409 example, if b is of type struct buffer * and v of type struct
410 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
411 != &v->size, and therefore "v->size = 1; b->size = 2; return
412 v->size;" must therefore return 1. This assumption is incorrect
413 for Emacs, since it type-puns struct Lisp_Vector * with many other
414 types. To fix this problem, this patch adds a new type struct
415 vectorlike_header that documents the constraints on layout of vectors
416 and pseudovectors, and helps optimizing compilers not get fooled
417 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
418 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
419 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
421 (XSETPVECTYPE): Rewrite in terms of new macro.
422 (XSETPVECTYPESIZE): New macro, specifying both type and size.
423 This is a bit clearer, and further avoids the possibility of
424 undesirable aliasing.
425 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
426 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
427 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
428 since Lisp_Subr is a special case (no "next" field).
429 (ASIZE): Now uses header.size rather than size. All
430 previous uses of XVECTOR (foo)->size replaced to use this macro,
431 to avoid the hassle of writing XVECTOR (foo)->header.size.
432 (struct vectorlike_header): New type.
433 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
434 object, to help avoid aliasing.
435 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
436 (SUBRP): Likewise, since Lisp_Subr is a special case.
437 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
438 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
439 (struct Lisp_Hash_Table): Combine first two members into a single
440 struct vectorlike_header member. All uses of "size" and "next" members
441 changed to be "header.size" and "header.next".
442 * buffer.h (struct buffer): Likewise.
443 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
444 * frame.h (struct frame): Likewise.
445 * process.h (struct Lisp_Process): Likewise.
446 * termhooks.h (struct terminal): Likewise.
447 * window.c (struct save_window_data, struct saved_window): Likewise.
448 * window.h (struct window): Likewise.
449 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
450 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
451 * buffer.c (init_buffer_once): Likewise.
452 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
454 * process.c (Fformat_network_address): Use local var for size,
457 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
459 Make the Lisp reader and string-to-float more consistent (Bug#8525)
460 * data.c (atof): Remove decl; no longer used or needed.
461 (digit_to_number): Move to lread.c.
462 (Fstring_to_number): Use new string_to_number function, to be
463 consistent with how the Lisp reader treats infinities and NaNs.
464 Do not assume that floating-point numbers represent EMACS_INT
465 without losing information; this is not true on most 64-bit hosts.
466 Avoid double-rounding errors, by insisting on integers when
467 parsing non-base-10 numbers, as the documentation specifies.
468 * lisp.h (string_to_number): New decl, replacing ...
469 (isfloat_string): Remove.
470 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
471 (read1): Do not accept +. and -. as integers; this
472 appears to have been a coding error. Similarly, do not accept
473 strings like +-1e0 as floating point numbers. Do not report
474 overflow for integer overflows unless the base is not 10 which
475 means we have no simple and reliable way to continue.
476 Break out the floating-point parsing into a new
477 function string_to_number, so that Fstring_to_number parses
478 floating point numbers consistently with the Lisp reader.
479 (digit_to_number): Moved here from data.c. Make it static inline.
480 (E_CHAR, EXP_INT): Remove, replacing with ...
481 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
482 (string_to_number): New function, replacing isfloat_string.
483 This function checks for valid syntax and produces the resulting
484 Lisp float number too. Rework it so that string-to-number
485 no longer mishandles examples like "1.0e+". Use strtoumax,
486 so that overflow for non-base-10 numbers is reported only when
487 there's no portable and simple way to convert to floating point.
489 * textprop.c (set_text_properties_1): Rewrite for clarity,
490 and to avoid GCC warning about integer overflow.
492 * intervals.h (struct interval): Use EMACS_INT for members
493 where EMACS_UINT might cause problems. See
494 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
495 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
496 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
498 (offset_intervals): Tell GCC not to worry about length overflow
499 when negating a negative length.
501 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
502 (overrun_check_free): Likewise.
504 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
505 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
508 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
509 (gnutls_make_error): Rename local to avoid shadowing.
510 (gnutls_emacs_global_deinit): ifdef out; not used.
511 (Fgnutls_boot): Use const for pointer to readonly storage.
512 Comment out unused local. Fix pointer signedness problems.
514 * lread.c (openp): Don't stuff size_t into an 'int'.
515 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
516 about possible signed overflow.
518 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
519 (GDK_KEY_g): Don't define if already defined.
520 (xg_prepare_tooltip): Avoid pointer signedness problem.
521 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
523 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
524 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
526 * xfns.c (Fx_window_property): Simplify a bit,
527 to make a bit faster and to avoid GCC 4.6.0 warning.
528 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
530 * fns.c (internal_equal): Don't assume size_t fits in int.
532 * alloc.c (compact_small_strings): Tighten assertion a little.
534 Replace pEd with more-general pI, and fix some printf arg casts.
535 * lisp.h (pI): New macro, generalizing old pEd macro to other
536 conversion specifiers. For example, use "...%"pI"d..." rather
538 (pEd): Remove. All uses replaced with similar uses of pI.
539 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
540 * alloc.c (check_pure_size): Don't overflow by converting size to int.
541 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
542 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
543 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
544 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
545 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
547 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
548 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
549 * print.c (safe_debug_print, print_object): Likewise.
550 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
552 Use pI instead of if-then-else-abort. Use %p to avoid casts,
553 avoiding the 0 flag, which is not portable.
554 * process.c (Fmake_network_process): Use pI to avoid cast.
555 * region-cache.c (pp_cache): Likewise.
556 * xdisp.c (decode_mode_spec): Likewise.
557 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
558 behavior on 64-bit hosts with printf arg.
559 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
560 (x_stop_queuing_selection_requests): Likewise.
561 (x_get_window_property): Don't truncate byte count to an 'int'
564 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
565 here, since it parses constructs like leading '-' and spaces,
566 which are not wanted; and it overflows with large numbers.
567 Instead, simply match F[0-9]+, which is what is wanted anyway.
569 * alloc.c: Remove unportable assumptions about struct layout.
570 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
571 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
572 (allocate_vectorlike, make_pure_vector): Use the new macros,
573 plus offsetof, to remove unportable assumptions about struct layout.
574 These assumptions hold on all porting targets that I know of, but
575 they are not guaranteed, they're easy to remove, and removing them
576 makes further changes easier.
578 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
579 This doesn't fix a bug but makes the code clearer.
580 (string_overrun_cookie): Now const. Use initializers that
581 don't formally overflow signed char, to avoid warnings.
582 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
583 can cause Emacs to crash when string overrun checking is enabled.
584 (allocate_buffer): Don't assume sizeof (struct buffer) is a
585 multiple of sizeof (EMACS_INT); it need not be, if
586 alignof(EMACS_INT) < sizeof (EMACS_INT).
587 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
589 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
591 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
593 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
595 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
596 supposed to be handshaking. (Bug#8556)
597 Reported by Paul Eggert <eggert@cs.ucla.edu>.
599 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
601 * lisp.h (Qdebug): List symbol.
602 * eval.c (Qdebug): Restore global linkage.
603 * keyboard.c (debug-on-event): New variable.
604 (handle_user_signal): Break into debugger when debug-on-event
605 matches the current signal symbol.
607 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
609 * alloc.c (check_sblock, check_string_bytes)
610 (check_string_free_list): Convert to standard C.
612 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
614 * w32.c (emacs_gnutls_push): Fix typo.
616 2011-04-25 Eli Zaretskii <eliz@gnu.org>
618 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
619 "cast to pointer from integer of different size".
621 Improve doprnt and its use in verror. (Bug#8545)
622 * doprnt.c (doprnt): Document the set of format control sequences
623 supported by the function. Use SAFE_ALLOCA instead of always
626 * eval.c (verror): Don't limit the buffer size at size_max-1, that
627 is one byte too soon. Don't use xrealloc; instead xfree and
630 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
632 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
635 * gnutls.c: Renamed global_initialized to
636 gnutls_global_initialized. Added internals for the
637 :verify-hostname-error, :verify-error, and :verify-flags
638 parameters of `gnutls-boot' and documented those parameters in the
639 docstring. Start callback support.
640 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
641 unless a fatal error occured. Call gnutls_alert_send_appropriate
642 on error. Return error code.
643 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
644 (emacs_gnutls_read): Likewise.
645 (Fgnutls_boot): Return handshake error code.
646 (emacs_gnutls_handle_error): New function.
647 (wsaerror_to_errno): Likewise.
649 * w32.h (emacs_gnutls_pull): Add prototype.
650 (emacs_gnutls_push): Likewise.
652 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
653 (emacs_gnutls_push): Likewise.
655 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
657 * process.c (wait_reading_process_output): Check if GnuTLS
658 buffered some data internally if no FDs are set for TLS
661 * makefile.w32-in (OBJ2): Add gnutls.$(O).
662 (LIBS): Link to USER_LIBS.
663 ($(BLD)/gnutls.$(0)): New target.
665 2011-04-24 Eli Zaretskii <eliz@gnu.org>
667 * xdisp.c (handle_single_display_spec): Rename the
668 display_replaced_before_p argument into display_replaced_p, to
669 make it consistent with the commentary. Fix typos in the
672 * textprop.c (syms_of_textprop): Remove dead code.
673 (copy_text_properties): Delete obsolete commentary about an
674 interface that was deleted long ago. Fix typos in the description
677 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
678 to changes in oldXMenu/XMenu.h from 2011-04-16.
679 <menu_help_message, prev_menu_help_message>: Constify.
680 (IT_menu_make_room): menu->help_text is now `const char **';
683 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
684 to changes in oldXMenu/XMenu.h from 2011-04-16.
685 (struct XMenu): Declare `help_text' `const char **'.
687 * xfaces.c <Qunspecified>: Make extern again.
689 * syntax.c: Include sys/types.h before including regex.h, as
692 * doc.c (get_doc_string): Improve the format passed to `error'.
694 * doprnt.c (doprnt): Improve commentary.
696 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
698 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
701 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
702 changes in globals.h immediately force recompilation.
703 (TAGS): Depend on $(CURDIR)/m/intel386.h and
704 $(CURDIR)/s/ms-w32.h.
705 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
707 * character.c (Fchar_direction): Function deleted.
708 (syms_of_character): Don't defsubr it.
709 <char-direction-table>: Deleted.
711 2011-04-23 Eli Zaretskii <eliz@gnu.org>
713 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
714 * doprnt.c: Include limits.h.
715 (SIZE_MAX): New macro.
716 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
717 local variables are now size_t instead of int or unsigned.
718 Improve overflow protection. Support `l' modifier for integer
719 conversions. Support %l conversion. Don't assume an EMACS_INT
720 argument for integer conversions and for %c.
722 * lisp.h (doprnt): Restore prototype.
724 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
727 * Makefile.in (base_obj): Add back doprnt.o.
729 * deps.mk (doprnt.o): Add back prerequisites.
730 (callint.o): Depend on character.h.
732 * eval.c (internal_lisp_condition_case): Include the handler
733 representation in the error message.
734 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
735 when breaking from the loop.
737 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
739 * callint.c (Fcall_interactively): When displaying error message
740 about invalid control letter, pass the character's codepoint, not
741 a pointer to its multibyte form. Improve display of the character
742 in octal and display also its hex code.
744 * character.c (char_string): Use %x to display the (unsigned)
745 codepoint of an invalid character, to avoid displaying a bogus
748 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
749 `error', not SYMBOL_NAME itself.
751 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
752 character arguments to `error'.
754 * charset.c (check_iso_charset_parameter): Fix incorrect argument
755 to `error' in error message about FINAL_CHAR argument. Make sure
756 FINAL_CHAR is a character, and use %c when it is passed as
759 2011-04-23 Eli Zaretskii <eliz@gnu.org>
761 * s/ms-w32.h (localtime): Redirect to sys_localtime.
763 * w32.c: Include <time.h>.
764 (sys_localtime): New function.
766 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
768 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
770 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
772 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
774 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
777 2011-04-19 Eli Zaretskii <eliz@gnu.org>
779 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
780 gl_state.e_property when gl_state.object is Qt.
782 * insdel.c (make_gap_larger): Remove limitation of buffer size
785 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
787 * xdisp.c (lookup_glyphless_char_display)
788 (produce_glyphless_glyph): Handle cons cell entry in
789 glyphless-char-display.
790 (Vglyphless_char_display): Document it.
792 * term.c (produce_glyphless_glyph): Handle cons cell entry in
793 glyphless-char-display.
795 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
797 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
799 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
801 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
802 definition for no-X builds.
804 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
806 Static checks with GCC 4.6.0 and non-default toolkits.
808 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
810 * process.c (keyboard_bit_set): Define only if SIGIO.
811 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
812 (send_process): Repair possible setjmp clobbering.
814 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
816 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
818 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
820 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
821 Define only if needed.
823 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
824 by pacifying GCC about it. Maybe it's time to retire it?
825 * xfaces.c (USG, __TIMEVAL__): Likewise.
827 * dispextern.h (struct redisplay_interface): Rename param
829 * termhooks.h (struct terminal): Likewise.
830 * xterm.c (xembed_send_message): Likewise.
832 * insdel.c (make_gap_smaller): Define only if
833 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
835 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
838 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
839 so that we aren't warned about unused symbols.
841 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
843 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
845 * xfns.c (x_real_positions): Mark locals as initialized.
847 * xmenu.c (xmenu_show): Don't use uninitialized vars.
849 * xterm.c: Fix problems found by static analysis with other toolkits.
850 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
851 (x_dispatch_event): Declare static if USE_GTK, and
852 define if USE_GTK || USE_X_TOOLKIT.
853 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
854 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
855 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
856 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
858 * xmenu.c (menu_help_callback): Pointer type fixes.
859 Use const pointers when pointing at readonly data. Avoid pointer
861 (FALSE): Remove unused macro.
862 (update_frame_menubar): Remove unused decl.
864 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
866 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
867 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
868 (single_menu_item): Rename local to avoid shadowing.
870 * keyboard.c (make_lispy_event): Remove unused local var.
872 * frame.c, frame.h (x_get_resource_string): Bring this back, but
873 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
875 * bitmaps: Change bitmaps from unsigned char back to the X11
876 compatible char. Avoid the old compiler warnings about
877 out-of-range initializers by using, for example, '\xab' rather
880 * xgselect.c (xgselect_initialize): Check vs interface
881 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
883 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
885 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
888 * fns.c (vector): Remove; this old hack is no longer needed.
890 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
892 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
894 * xrdb.c (x_load_resources): Omit unused local.
896 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
897 (x_window): Rename locals to avoid shadowing.
898 (USG): Use the kludged USG macro, to pacify gcc.
900 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
901 (x_term_init): Remove local to avoid shadowing.
903 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
905 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
906 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
908 2011-04-16 Eli Zaretskii <eliz@gnu.org>
910 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
912 Fix regex.c, syntax.c and friends for buffers > 2GB.
913 * syntax.h (struct gl_state_s): Declare character position members
916 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
918 * textprop.c (verify_interval_modification, interval_of): Declare
921 * intervals.c (adjust_intervals_for_insertion): Declare arguments
924 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
926 * indent.c (Fvertical_motion): Local variable it_start is now
929 * regex.c (re_match, re_match_2, re_match_2_internal)
930 (bcmp_translate, regcomp, regexec, print_double_string)
931 (group_in_compile_stack, re_search, re_search_2, regex_compile)
932 (re_compile_pattern, re_exec): Declare arguments and local
933 variables `size_t' and `ssize_t' and return values `regoff_t', as
935 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
936 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
937 <compile_stack_type>: `size' and `avail' are now `size_t'.
939 * regex.h <regoff_t>: Use ssize_t, not int.
940 (re_search, re_search_2, re_match, re_match_2): Arguments that
941 specify buffer/string position and length are now ssize_t and
942 size_t. Return type is regoff_t.
944 2011-04-16 Ben Key <bkey76@gmail.com>
946 * nsfont.m: Fixed bugs in ns_get_family and
947 ns_descriptor_to_entity that were caused by using free to
948 deallocate memory blocks that were allocated by xmalloc (via
949 xstrdup). This caused Emacs to crash when compiled with
950 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
951 --enable-checking=xmallocoverrun). xfree is now used to
952 deallocate these memory blocks.
954 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
956 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
958 emacs_write: Accept and return EMACS_INT for sizes.
959 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
961 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
962 Accept and return EMACS_INT.
963 (emacs_gnutls_write): Return the number of bytes written on
965 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
966 (emacs_read, emacs_write): Remove check for negative size, as the
967 Emacs source code has been audited now.
968 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
969 (emacs_read, emacs_write): Use it.
970 * process.c (send_process): Adjust to the new signatures of
971 emacs_write and emacs_gnutls_write. Do not attempt to store
972 a byte offset into an 'int'; it might overflow.
973 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
975 * sound.c: Don't assume sizes fit in 'int'.
976 (struct sound_device.period_size, alsa_period_size):
977 Return EMACS_INT, not int.
978 (struct sound_device.write, vox_write, alsa_write):
979 Accept EMACS_INT, not int.
980 (wav_play, au_play): Use EMACS_INT to store sizes and to
981 record read return values.
983 2011-04-15 Ben Key <bkey76@gmail.com>
985 * keyboard.c (Qundefined): Don't declare static since it is used
987 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
988 static since they are used in nsfont.m.
990 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
992 * process.c (Qprocessp): Don't declare static.
993 * lisp.h (Qprocessp): Declare again.
995 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
997 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
999 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1001 Improve C-level modularity by making more things 'static'.
1003 Don't publish debugger-only interfaces to other modules.
1004 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1005 (verify_bytepos, count_markers): Move decls to the only modules
1007 * region-cache.h (pp_cache): Likewise.
1008 * window.h (check_all_windows): Likewise.
1009 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1011 * sysdep.c (croak): Now static, if
1012 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1013 * syssignal.h (croak): Declare only if not static.
1015 * alloc.c (refill_memory_reserve): Now static if
1016 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1017 * lisp.h (refill_memory_reserve): Declare only if not static.
1019 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1020 Define only if USE_LUCID.
1022 * xrdb.c (x_customization_string, x_rm_string): Now static.
1024 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1025 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1027 * xdisp.c (draw_row_with_mouse_face): Now static.
1028 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1030 * window.h (check_all_windows): Mark externally visible.
1032 * window.c (window_deletion_count): Now static.
1034 * undo.c: Make symbols static if they're not exported.
1035 (last_undo_buffer, last_boundary_position, pending_boundary):
1038 * textprop.c (interval_insert_behind_hooks): Now static.
1039 (interval_insert_in_front_hooks): Likewise.
1041 * term.c: Make symbols static if they're not exported.
1042 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1043 (max_frame_lines, tty_set_terminal_modes):
1044 (tty_reset_terminal_modes, tty_turn_off_highlight):
1045 (get_tty_terminal): Now static.
1046 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1047 * termhooks.h (term_mouse_moveto): Do not declare if
1049 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1050 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1052 * sysdep.c: Make symbols static if they're not exported.
1053 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1055 (sigprocmask_set, full_mask): Remove; unused.
1056 (wait_debugging): Mark as visible.
1057 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1058 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1060 * syntax.c (syntax_temp): Define only if !__GNUC__.
1062 * sound.c (current_sound_device, current_sound): Now static.
1064 * search.c (searchbufs, searchbuf_head): Now static.
1066 * scroll.c (scroll_cost): Remove; unused.
1067 * dispextern.h (scroll_cost): Remove decl.
1069 * region-cache.h (pp_cache): Mark as externally visible.
1071 * process.c: Make symbols static if they're not exported.
1072 (process_tick, update_tick, create_process, chan_process):
1073 (Vprocess_alist, proc_buffered_char, datagram_access):
1074 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1075 (deactivate_process): Mark defn as static, as well as decl.
1076 * lisp.h (create_process): Remove decl.
1077 * process.h (chan_process, Vprocess_alist): Remove decls.
1079 * print.c: Make symbols static if they're not exported.
1080 (print_depth, new_backquote_output, being_printed, print_buffer):
1081 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1082 (print_interval, print_number_index, initial_stderr_stream):
1084 * lisp.h (Fprinc): Remove decl.
1085 (debug_output_compilation_hack): Mark as externally visible.
1087 * sysdep.c (croak): Move decl from here to syssignal.h.
1088 * syssignal.h (croak): Put it here, so the API can be checked when
1089 'croak' is called from dissociate_if_controlling_tty.
1091 * minibuf.c: Make symbols static if they're not exported.
1092 (minibuf_save_list, choose_minibuf_frame): Now static.
1093 * lisp.h (choose_minibuf_frame): Remove decl.
1095 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1097 * lread.c: Make symbols static if they're not exported.
1098 (read_objects, initial_obarray, oblookup_last_bucket_number):
1100 (make_symbol): Remove; unused.
1101 * lisp.h (initial_obarray, make_symbol): Remove decls.
1103 * keyboard.c: Make symbols static if they're not exported.
1104 (single_kboard, recent_keys_index, total_keys, recent_keys):
1105 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1106 (this_single_command_key_start, echoing, last_auto_save):
1107 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1108 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1109 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1110 (Vlispy_mouse_stem, double_click_count):
1112 (force_auto_save_soon): Define only if SIGDANGER.
1113 (ignore_mouse_drag_p): Now static if
1114 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1115 (print_help): Remove; unused.
1116 (stop_character, last_timer_event): Mark as externally visible.
1117 * keyboard.h (ignore_mouse_drag_p): Declare only if
1118 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1119 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1120 * lisp.h (echoing): Remove decl.
1121 (force_auto_save_soon): Declare only if SIGDANGER.
1122 * xdisp.c (redisplay_window): Simplify code, to make it more
1123 obvious that ignore_mouse_drag_p is not accessed if !defined
1124 USE_GTK && !defined HAVE_NS.
1126 * intervals.c: Make symbols static if they're not exported.
1127 (merge_properties_sticky, merge_interval_right, delete_interval):
1129 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1131 * insdel.c: Make symbols static if they're not exported.
1132 However, leave prepare_to_modify_buffer alone. It's never
1133 called from outside this function, but that appears to be a bug.
1134 (combine_after_change_list, combine_after_change_buffer):
1135 (adjust_after_replace, signal_before_change): Now static.
1136 (adjust_after_replace_noundo): Remove; unused.
1137 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1138 (signal_before_change): Remove decls.
1140 * indent.c (val_compute_motion, val_vmotion): Now static.
1142 * image.c: Make symbols static if they're not exported.
1143 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1145 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1146 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1148 * fringe.c (standard_bitmaps): Now static.
1149 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1151 * frame.c: Make symbols static if they're not exported.
1152 (x_report_frame_params, make_terminal_frame): Now static.
1153 (get_frame_param): Now static, unless HAVE_NS.
1154 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1155 (x_get_resource_string): Remove; not used.
1156 * frame.h (make_terminal_frame, x_report_frame_params):
1157 (x_get_resource_string); Remove decls.
1158 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1159 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1161 * font.c, fontset.c: Make symbols static if they're not exported.
1162 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1163 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1164 * font.c (font_close_object): Now static.
1165 * font.h (font_close_object): Remove.
1166 * fontset.c (FONTSET_OBJLIST): Remove.
1167 (free_realized_fontset) #if-0 the body, which does nothing.
1168 (face_suitable_for_char_p): #if-0, as it's never called.
1169 * fontset.h (face_suitable_for_char_p): Remove decl.
1170 * xfaces.c (face_at_string_position): Use
1171 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1172 since 0 is always ASCII.
1174 * fns.c (weak_hash_tables): Now static.
1176 * fileio.c: Make symbols static if they're not exported.
1177 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1178 (Vwrite_region_annotation_buffers): Now static.
1180 * eval.c: Make symbols static if they're not exported.
1181 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1182 * lisp.h (backtrace_list): Remove decl.
1184 * emacs.c: Make symbols static if they're not exported.
1185 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1186 (fatal_error_code, fatal_error_signal_hook, standard_args):
1188 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1189 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1190 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1191 * lisp.h (fatal_error_signal_hook): Remove decl.
1192 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1194 * editfns.c: Move a (normally-unused) function to its only use.
1195 * editfns.c, lisp.h (get_operating_system_release): Remove.
1196 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1197 worth the hassle of breaking this out.
1199 * xterm.c: Make symbols static if they're not exported.
1200 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1201 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1202 (x_destroy_window, x_delete_display):
1204 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1205 (x_mouse_leave): Remove; unused.
1206 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1207 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1208 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1210 (x_mouse_leave): Declare only if WINDOWSNT.
1211 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1212 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1215 * ftxfont.c: Make symbols static if they're not exported.
1216 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1218 * font.h (ftxfont_driver): Likewise.
1220 * xfns.c: Make symbols static if they're not exported.
1221 (x_last_font_name, x_display_info_for_name):
1222 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1223 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1224 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1225 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1226 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1227 (last_show_tip_args): Now static.
1228 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1229 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1230 (x_screen_planes): Remove; unused.
1231 * dispextern.h (x_screen_planes): Remove decl.
1233 * dispnew.c: Make symbols static if they're not exported.
1234 * dispextern.h (redraw_garbaged_frames, scrolling):
1235 (increment_row_positions): Remove.
1236 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1237 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1239 (redraw_garbaged_frames): Remove; unused.
1241 * xfaces.c: Make symbols static if they're not exported.
1242 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1244 * xterm.h (defined_color): Remove decls.
1245 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1246 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1247 (menu_face_changed_default, defined_color, free_realized_face):
1248 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1249 (ascii_face_of_lisp_face): Remove; unused.
1251 * xdisp.c: Make symbols static if they're not exported.
1252 * dispextern.h (scratch_glyph_row, window_box_edges):
1253 (glyph_to_pixel_coords, set_cursor_from_row):
1254 (get_next_display_element, set_iterator_to_next):
1255 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1256 (show_mouse_face): Remove decls
1257 * frame.h (message_buf_print): Likewise.
1258 * lisp.h (pop_message, set_message, check_point_in_composition):
1260 * xterm.h (set_vertical_scroll_bar): Likewise.
1261 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1262 (message_buf_print, scratch_glyph_row, displayed_buffer):
1263 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1264 (get_next_display_element, show_mouse_face, window_box_edges):
1265 (frame_to_window_pixel_xy, check_point_in_composition):
1266 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1267 (glyph_to_pixel_coords): Remove; unused.
1269 * dired.c (file_name_completion): Now static.
1271 * dbusbind.c (xd_in_read_queued_messages): Now static.
1273 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1274 * data.c (circular_list_error): Remove.
1276 * commands.h (last_point_position, last_point_position_buffer):
1277 (last_point_position_window): Remove decls.
1278 * keyboard.c: Make these variables static.
1280 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1282 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1283 (iso_code_class, detect_coding, code_convert_region): Now static.
1284 (encode_coding_gap): Remove; unused.
1286 * chartab.c (chartab_chars, chartab_bits): Now static.
1288 * charset.h (charset_iso_8859_1): Remove decl.
1289 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1292 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1293 * ccl.c (Vccl_program_table): Now static.
1294 (check_ccl_update): Remove; unused.
1296 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1297 * category.h: ... from here.
1298 * category.c (check_category_table, set_category_set): Now static.
1300 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1301 * lisp.h: Remove these decls.
1303 * buffer.c (buffer_count): Remove unused var.
1305 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1306 so that it's not optimized away.
1307 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1308 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1309 exported only to the debugger.
1311 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1312 * atimer.h (run_all_atimers): Removed; not exported.
1314 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1315 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1316 was inaccessible from Lisp.
1317 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1318 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1320 alloc.c: Import and export fewer symbols, and remove unused items.
1321 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1323 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1324 it's not optimized away by whole-program optimization.
1325 (message_enable_multibyte, free_misc): Remove.
1326 (catchlist, handlerlist, mark_backtrace):
1327 Declare only if BYTE_MARK_STACK.
1328 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1329 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1330 (message_enable_multibyte): Remove decl.
1331 (free_misc, interval_free_list, float_block, float_block_index):
1332 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1333 (cons_free_list, last_marked_index):
1335 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1336 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1337 (mark_backtrace): Define only if BYTE_MARK_STACK.
1338 * xdisp.c (message_enable_multibyte): Now static.
1340 Declare Lisp_Object Q* variables to be 'static' if not exported.
1341 This makes it easier for human readers (and static analyzers)
1342 to see whether these variables are used from other modules.
1343 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1344 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1345 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1346 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1347 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1348 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1349 * xmenu.c, xselect.c:
1350 Declare Q* vars static if they are not used in other modules.
1351 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1352 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1353 Remove decls of unexported vars.
1354 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1356 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1358 Make Emacs functions such as Fatom 'static' by default.
1359 This makes it easier for human readers (and static analyzers)
1360 to see whether these functions can be called from other modules.
1361 DEFUN now defines a static function. To make the function external
1362 so that it can be used in other C modules, use the new macro DEFUE.
1363 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1364 (Finit_image_library):
1365 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1366 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1367 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1368 Remove decls, since these functions are now static.
1369 (Funintern, Fget_internal_run_time): New decls, since these functions
1370 were already external.
1372 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1373 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1374 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1375 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1376 * keyboard.c, keymap.c, lread.c:
1377 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1378 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1379 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1380 Mark functions with DEFUE instead of DEFUN,
1381 if they are used in other modules.
1382 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1383 decls for now-static functions.
1384 * buffer.h (Fdelete_overlay): Remove decl.
1385 * callproc.c (Fgetenv_internal): Mark as internal.
1386 * composite.c (Fremove_list_of_text_properties): Remove decl.
1387 (Fcomposition_get_gstring): New forward static decl.
1388 * composite.h (Fcomposite_get_gstring): Remove decl.
1389 * dired.c (Ffile_attributes): New forward static decl.
1390 * doc.c (Fdocumntation_property): New forward static decl.
1391 * eval.c (Ffetch_bytecode): New forward static decl.
1392 (Funintern): Remove extern decl; now in .h file where it belongs.
1393 * fileio.c (Fmake_symbolic_link): New forward static decl.
1394 * image.c (Finit_image_library): New forward static decl.
1395 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1396 * intervals.h (Fprevious_property_change):
1397 (Fremove_list_of_text_properties): Remove decls.
1398 * keyboard.c (Fthis_command_keys): Remove decl.
1399 (Fcommand_execute): New forward static decl.
1400 * keymap.c (Flookup_key): New forward static decl.
1401 (Fcopy_keymap): Now static.
1402 * keymap.h (Flookup_key): Remove decl.
1403 * process.c (Fget_process): New forward static decl.
1404 (Fprocess_datagram_address): Mark as internal.
1405 * syntax.c (Fsyntax_table_p): New forward static decl.
1406 (skip_chars): Remove duplicate decl.
1407 * textprop.c (Fprevious_property_change): New forward static decl.
1408 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1410 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1411 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1413 * editfns.c (Fformat): Remove unreachable code.
1415 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1417 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1420 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1422 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1423 when at ZV. (Bug#8487)
1425 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1427 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1429 * keyboard.c (parse_tool_bar_item): Likewise.
1430 * sound.c (sound_cleanup, alsa_close): Likewise.
1431 * termcap.c (tgetent): Likewise.
1432 * xfns.c (x_default_font_parameter): Likewise.
1433 * xsettings.c (read_and_apply_settings): Likewise.
1435 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1436 (overrun_check_free): Protoize.
1438 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1440 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1441 since callers should never pass a negative size.
1442 Change the signature to match that of plain 'read' and 'write'; see
1443 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1444 * lisp.h: Update prototypes of emacs_write and emacs_read.
1446 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1448 * xdisp.c (redisplay_window): Don't try to determine the character
1449 position of the scroll margin if the window start point w->startp
1450 is outside the buffer's accessible region. (Bug#8468)
1452 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1454 Fix write-region and its subroutines for buffers > 2GB.
1455 * fileio.c (a_write, e_write): Modify declaration of arguments and
1456 local variables to support buffers larger than 2GB.
1457 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1459 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1460 argument, local variables, and return value.
1462 * lisp.h: Update prototypes of emacs_write and emacs_read.
1464 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1466 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1468 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1470 Fix more problems found by GCC 4.6.0's static checks.
1472 * xdisp.c (vmessage): Use a better test for character truncation.
1474 * charset.c (load_charset_map): <, not <=, for optimization,
1475 and to avoid potential problems with integer overflow.
1476 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1477 * casetab.c (set_identity, shuffle): Likewise.
1478 * editfns.c (Fformat): Likewise.
1479 * syntax.c (skip_chars): Likewise.
1481 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1482 This also lets GCC 4.6.0 generate slightly better loop code.
1484 * callint.c (Fcall_interactively): <, not <=, for optimization.
1485 (Fcall_interactively): Count the number of arguments produced,
1486 not the number of arguments given. This is simpler and lets GCC
1487 4.6.0 generate slightly better code.
1489 * ftfont.c: Distingish more carefully between FcChar8 and char.
1490 The previous code passed unsigned char * to a functions like
1491 strlen and xstrcasecmp that expect char *, which does not
1492 conform to the C standard.
1493 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1494 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1495 char * when the C standard requires it.
1497 * keyboard.c (read_char): Remove unused var.
1499 * eval.c: Port to Windows vsnprintf (Bug#8435).
1501 (SIZE_MAX): Define if the headers do not.
1502 (verror): Do not give up if vsnprintf returns a negative count.
1503 Instead, grow the buffer. This ports to Windows vsnprintf, which
1504 does not conform to C99. Problem reported by Eli Zaretskii.
1505 Also, simplify the allocation scheme, by avoiding the need for
1506 calling realloc, and removing the ALLOCATED variable.
1508 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1510 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1511 But keep the doprint source code for now, as we might revamp it
1512 and use it again (Bug#8435).
1513 * lisp.h (doprnt): Remove.
1514 * Makefile.in (base_obj): Remove doprnt.o.
1515 * deps.mk (doprnt.o): Remove.
1517 error: Print 32- and 64-bit integers portably (Bug#8435).
1518 Without this change, on typical 64-bit hosts error ("...%d...", N)
1519 was used to print both 32- and 64-bit integers N, which relied on
1521 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1523 * lisp.h (error, verror): Mark as printf-like functions.
1524 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1525 Report overflow in size calculations when allocating printf buffer.
1526 Do not truncate output string at its first null byte.
1527 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1528 Truncate the output at a character boundary, since vsnprintf does not
1530 * charset.c (check_iso_charset_parameter): Convert internal
1531 character to string before calling 'error', since %c now has the
1533 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1534 overflow when computing char to be passed to 'error'. Do not
1535 pass Lisp_Object to 'error'; pass the integer instead.
1536 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1537 formatted with plain %d.
1539 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1541 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1543 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1545 * xterm.c (x_catch_errors): Remove duplicate declaration.
1547 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1549 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1551 2011-04-10 Jim Meyering <meyering@redhat.com>
1553 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1554 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1555 return ssize_t not "int", and use size_t as the buffer length.
1556 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1557 * gnutls.h: Update declarations.
1558 * process.c (read_process_output): Use ssize_t, to match.
1559 (send_process): Likewise.
1561 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1563 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1565 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1567 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1568 unsigned char, to match FcChar8 type definition.
1570 * xterm.c (handle_one_xevent):
1571 * xmenu.c (create_and_show_popup_menu):
1572 * xselect.c (x_decline_selection_request)
1573 (x_reply_selection_request): Avoid type-punned deref of X events.
1575 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1577 Fix some uses of `int' instead of EMACS_INT.
1578 * search.c (string_match_1, fast_string_match)
1579 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1580 (scan_buffer, find_next_newline_no_quit)
1581 (find_before_next_newline, search_command, Freplace_match)
1582 (Fmatch_data): Make some `int' variables be EMACS_INT.
1584 * xdisp.c (display_count_lines): 3rd argument and return value now
1585 EMACS_INT. All callers changed.
1586 (pint2hrstr): Last argument is now EMACS_INT.
1588 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1589 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1590 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1591 (decode_coding_utf_16, decode_coding_emacs_mule)
1592 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1593 (decode_coding_ccl, decode_coding_charset)
1594 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1595 (decode_coding_iso_2022, decode_coding_emacs_mule)
1596 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1597 <char_offset, last_offset>: Declare EMACS_INT.
1598 (encode_coding_utf_8, encode_coding_utf_16)
1599 (encode_coding_emacs_mule, encode_invocation_designation)
1600 (encode_designation_at_bol, encode_coding_iso_2022)
1601 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1602 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1604 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1605 (encode_invocation_designation): Last argument P_NCHARS is now
1607 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1608 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1610 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1613 * ccl.c (Fccl_execute_on_string): Declare some variables
1616 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1618 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1620 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1622 * process.c (Fformat_network_address): Doc fix.
1624 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1626 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1628 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1630 * keyboard.c (read_char): Call Lisp function help-form-show,
1631 instead of using internal_with_output_to_temp_buffer.
1632 (Qhelp_form_show): New var.
1633 (syms_of_keyboard): Use DEFSYM macro.
1635 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1637 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1639 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1641 * process.c (Flist_processes): Removed to Lisp.
1642 (list_processes_1): Deleted.
1644 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1646 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1648 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1650 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1652 Fix more problems found by GCC 4.6.0's static checks.
1654 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1656 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1658 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1660 * xdisp.c (vmessage): Mark as a printf-like function.
1662 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1664 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1666 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1667 printf-like functions.
1668 (tiff_load): Add casts to remove these marks before passing them
1669 to system-supplied API.
1671 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1673 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1674 This avoids several warnings with gcc -Wstrict-overflow.
1675 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1676 directly, rather than having caller test rule sign. This avoids
1677 some unnecessary tests.
1678 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1679 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1680 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1682 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1683 (xfont_open): Avoid unnecessary tests.
1685 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1687 * composite.h, composite.c (composition_gstring_put_cache):
1688 Use EMACS_INT, not int, for length.
1690 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1691 breaking out part of COMPOSITION_DECODE_RULE.
1692 (COMPOSITION_DECODE_RULE): Use it.
1693 * composite.c (get_composition_id): Remove unused local vars,
1694 by using the new macro.
1696 * textprop.c (set_text_properties_1): Change while to do-while,
1697 since the condition is always true at first.
1699 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1700 (interval_deletion_adjustment): Return unsigned value.
1703 * process.c (list_processes_1, create_pty, read_process_output):
1704 (exec_sentinel): Remove vars that were set but not used.
1705 (create_pty): Remove unnecessary "volatile"s.
1706 (Fnetwork_interface_info): Avoid possibility of int overflow.
1707 (read_process_output): Do adaptive read buffering even if carryover.
1708 (read_process_output): Simplify nbytes computation if buffered.
1710 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1712 * syntax.c (scan_words): Remove var that was set but not used.
1713 (update_syntax_table): Use unsigned instead of int.
1715 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1716 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1717 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1719 * print.c (print_error_message): Avoid int overflow.
1721 * font.c (font_list_entities): Redo for clarity,
1722 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1724 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1725 (font_score): Avoid potential overflow in diff calculation.
1727 * fns.c (substring_both): Remove var that is set but not used.
1728 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1730 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1732 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1733 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1734 can always succeed if overflow has undefined behavior.
1736 * search.c (boyer_moore, wordify): Remove vars set but not used.
1737 (wordify): Omit three unnecessary tests.
1739 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1740 All callers changed. This avoids the need for an unused var.
1742 * casefiddle.c (casify_region): Remove var that is set but not used.
1744 * dired.c (file_name_completion): Remove var that is set but not used.
1746 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1748 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1749 (Finsert_file_contents): Remove unnecessary code checking fd.
1751 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1752 Check for integer overflow on size calculations.
1754 * buffer.c (Fprevious_overlay_change): Remove var that is set
1757 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1758 Remove vars that are set but not used.
1759 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1760 (timer_check_2): Mark vars as initialized.
1762 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1764 * image.c (lookup_image): Remove var that is set but not used.
1765 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1767 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1768 that are set but not used.
1770 * xfns.c (make_invisible_cursor): Don't return garbage
1771 if XCreateBitmapFromData fails (Bug#8410).
1773 * xselect.c (x_get_local_selection, x_handle_property_notify):
1774 Remove vars that are set but not used.
1776 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1777 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1779 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1780 Remove var that is set but not used.
1781 (scroll_bar_windows_size): Now size_t, not int.
1782 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1785 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1786 (map_tty_color) [!defined MSDOS]: Likewise.
1788 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1790 * coding.c: Remove vars that are set but not used.
1791 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1792 All callers changed.
1793 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1794 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1795 (decode_coding_charset): Remove vars that are set but not used.
1797 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1798 that is set but not used.
1800 * print.c (print_object): Remove var that is set but not used.
1802 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1803 The gnulib version avoids calling malloc in the usual case,
1804 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1805 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1806 * filelock.c (current_lock_owner): Likewise.
1807 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1808 * sysdep.c: Include allocator.h, careadlinkat.h.
1809 (emacs_no_realloc_allocator): New static constant.
1810 (emacs_readlink): New function.
1811 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1812 ../lib/careadlinkat.h.
1814 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1816 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1817 first non-nil return value).
1819 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1821 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1822 if not defined (Bug#8403).
1824 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1826 * xdisp.c (display_count_lines): Remove parameter `start',
1827 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1828 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1829 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1830 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1831 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1832 and thereabouts. All callers changed.
1833 (get_per_char_metric): Remove parameter `f', unused since
1834 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1836 2011-04-02 Jim Meyering <meyering@redhat.com>
1838 do not dereference NULL upon failed strdup
1839 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1840 (ns_get_family): Likewise.
1842 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1844 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1846 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1848 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1851 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1853 Add lexical binding.
1855 * window.c (Ftemp_output_buffer_show): New fun.
1856 (Fsave_window_excursion):
1857 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1859 * lread.c (lisp_file_lexically_bound_p): New function.
1860 (Fload): Bind Qlexical_binding.
1861 (readevalloop): Remove `evalfun' arg.
1862 Bind Qinternal_interpreter_environment.
1863 (Feval_buffer): Bind Qlexical_binding.
1864 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1866 (syms_of_lread): Declare `lexical-binding'.
1868 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1870 * keyboard.c (eval_dyn): New fun.
1871 (menu_item_eval_property): Use it.
1873 * image.c (parse_image_spec): Use Ffunctionp.
1875 * fns.c (concat, mapcar1): Accept byte-code-functions.
1877 * eval.c (Fsetq): Handle lexical vars.
1878 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1879 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1880 (FletX, Flet): Obey lexical binding.
1881 (Fcommandp): Handle closures.
1882 (Feval): New `lexical' arg.
1883 (eval_sub): New function extracted from Feval. Use it almost
1884 everywhere where Feval was used. Look up vars in lexical env.
1886 (Ffunctionp): Move from subr.el.
1887 (Ffuncall): Handle closures.
1888 (apply_lambda): Remove `eval_flags'.
1889 (funcall_lambda): Handle closures and new byte-code-functions.
1890 (Fspecial_variable_p): New function.
1891 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1892 but without exporting it to Lisp.
1894 * doc.c (Fdocumentation, store_function_docstring):
1895 * data.c (Finteractive_form): Handle closures.
1897 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1900 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1902 (exec_byte_code): New function extracted from Fbyte_code to handle new
1903 calling convention for byte-code-functions. Add new byte-codes.
1905 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1907 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1909 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1911 * xdisp.c (redisplay_internal): Fix prototype.
1913 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1915 * xdisp.c (SCROLL_LIMIT): New macro.
1916 (try_scrolling): Use it when setting scroll_limit. Limit
1917 scrolling to 100 screen lines.
1918 (redisplay_window): Even when falling back on "recentering",
1919 position point in the window according to scroll-conservatively,
1920 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1922 (try_scrolling): When point is above the window, allow searching
1923 as far as scroll_max, or one screenful, to compute vertical
1924 distance from PT to the scroll margin position. This prevents
1925 try_scrolling from unnecessarily failing when
1926 scroll-conservatively is set to a value slightly larger than the
1927 window height. Clean up the case of PT below the margin at bottom
1928 of window: scroll_max can no longer be INT_MAX. When aggressive
1929 scrolling is in use, don't let point enter the opposite scroll
1930 margin as result of the scroll.
1931 (syms_of_xdisp) <scroll-conservatively>: Document the
1932 threshold of 100 lines for never-recentering scrolling.
1934 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1936 * dispextern.h (move_it_by_lines):
1937 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1938 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1939 (message_log_check_duplicate): Remove parameters `prev_bol' and
1940 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1941 (redisplay_internal): Remove parameter `preserve_echo_area',
1942 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1944 * indent.c (Fvertical_motion):
1945 * window.c (window_scroll_pixel_based, Frecenter):
1946 Don't pass `need_y_p' to `move_it_by_lines'.
1948 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1950 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1951 steal a few bits to be more compact.
1952 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1953 Remove unneeded casts.
1955 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1957 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1959 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1960 binding" message (bug#7967).
1962 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1964 Fix more problems found by GCC 4.6.0's static checks.
1966 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1967 Remove unused local var.
1969 * editfns.c (Fmessage_box): Remove unused local var.
1971 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1972 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1973 Omit unused local vars.
1974 * window.c (shrink_windows): Omit unused local var.
1975 * menu.c (digest_single_submenu): Omit unused local var.
1976 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1977 Omit unused local var.
1979 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1980 Don't assume string length fits in int.
1981 (keyremap_step, read_key_sequence): Use size_t for sizes.
1982 (read_key_sequence): Don't check last_real_key_start redundantly.
1984 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1985 instead of alloca (Bug#8344).
1987 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1988 (Fbacktrace_frame): Don't assume nframes fits in int.
1990 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1992 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1995 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1997 * cm.c (calccost): Turn while-do into do-while, for clarity.
1999 * keyboard.c (syms_of_keyboard): Use the same style as later
2000 in this function when indexing through an array. This also
2001 works around GCC bug 48267.
2003 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2005 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2007 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2008 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2010 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2011 This avoids undefined behavior on integer overflow, and is a bit
2012 more convenient anyway since it is compared to a size_t variable.
2014 Variadic C functions now count arguments with size_t, not int.
2015 This avoids an unnecessary limitation on 64-bit machines, which
2016 caused (substring ...) to crash on large vectors (Bug#8344).
2017 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2018 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2019 All variadic functions and their callers changed accordingly.
2020 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2021 * data.c (arith_driver, float_arith_driver): Likewise.
2022 * editfns.c (general_insert_function): Likewise.
2023 * eval.c (struct backtrace.nargs, interactive_p)
2024 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2025 (funcall_lambda, mark_backtrace): Likewise.
2026 * fns.c (concat): Likewise.
2027 * frame.c (x_set_frame_parameters): Likewise.
2028 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2029 0 if not found, not -1. All callers changed.
2031 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2032 (stack_copy_size): Now size_t, not int.
2033 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2035 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2037 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2038 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2039 All callers changed.
2041 * lisp.h (multibyte_char_to_unibyte):
2042 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2043 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2044 * character.h (CHAR_TO_BYTE8):
2045 * cmds.c (internal_self_insert):
2046 * editfns.c (general_insert_function):
2047 * keymap.c (push_key_description):
2048 * search.c (Freplace_match):
2049 * xdisp.c (message_dolog, set_message_1): All callers changed.
2051 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2053 * keyboard.c (safe_run_hook_funcall): New function.
2054 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2055 don't set the hook to nil, but remove the offending function instead.
2056 (Qcommand_hook_internal): Remove, unused.
2057 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2058 Vcommand_hook_internal.
2060 * eval.c (enum run_hooks_condition): Remove.
2061 (funcall_nil, funcall_not): New functions.
2062 (run_hook_with_args): Call each function through a `funcall' argument.
2063 Remove `cond' argument, now redundant.
2064 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2065 (Frun_hook_with_args_until_failure): Adjust accordingly.
2066 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2068 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2070 * dispextern.h (string_buffer_position): Remove declaration.
2072 * print.c (strout): Remove parameter `multibyte', unused since
2073 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2075 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2076 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2077 All callers changed.
2079 * w32.c (_wsa_errlist): Use braces for struct initializers.
2081 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2082 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2083 All callers changed.
2084 (string_buffer_position): Likewise. Also, make static (it's never
2085 used outside xdisp.c).
2086 (cursor_row_p): Remove parameter `w', unused since
2087 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2088 (decode_mode_spec): Remove parameter `precision', introduced during
2089 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2090 All callers changed.
2092 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2094 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2096 2011-03-27 Anders Lindgren <andlind@gmail.com>
2098 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2099 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2100 (ns_update_auto_hide_menu_bar): New functions.
2101 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2102 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2103 ns_constrain_all_frames.
2104 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2105 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2107 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2109 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2111 2011-03-27 Glenn Morris <rgm@gnu.org>
2113 * syssignal.h: Replace RETSIGTYPE with void.
2114 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2115 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2116 Replace SIGTYPE with void everywhere.
2117 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2118 * s/template.h (SIGTYPE): Remove commented out definition.
2120 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2122 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2123 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2125 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2127 * w32.c (read_unc_volume): Use parameter `henum', instead of
2128 global variable `wget_enum_handle'.
2130 * keymap.c (describe_vector): Remove parameters `indices' and
2131 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2132 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2134 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2136 * keyboard.c (timer_check): Remove parameter `do_it_now',
2137 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2138 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2139 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2141 * keyboard.c (read_char):
2142 * w32menu.c (w32_menu_display_help):
2143 * xmenu.c (show_help_event, menu_help_callback):
2144 Adjust calls to `show_help_echo'.
2146 * gtkutil.c (xg_maybe_add_timer):
2147 * keyboard.c (readable_events):
2148 * process.c (wait_reading_process_output):
2149 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2151 * insdel.c (adjust_markers_gap_motion):
2152 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2153 (gap_left, gap_right): Don't call it.
2155 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2157 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2158 incurred during fontification.
2160 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2162 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2163 (DEFVAR_PER_BUFFER): Don't pass it.
2165 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2166 (scrolling_window): Don't pass it.
2168 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2170 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2172 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2174 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2175 of variables specific to SELinux and computation of `encoded_absname'.
2177 * image.c (XPutPixel): Remove unused variable `height'.
2179 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2181 * unexw32.c (get_section_info): Remove unused variable `section'.
2183 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2184 (system_process_attributes): Remove unused variable `sess'.
2185 (sys_read): Remove unused variable `err'.
2187 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2188 (w32_wnd_proc): Remove unused variable `isdead'.
2189 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2190 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2191 (x_create_tip_frame): Remove unused variable `tem'.
2193 * w32inevt.c (w32_console_read_socket):
2194 Remove unused variable `no_events'.
2196 * w32term.c (x_draw_composite_glyph_string_foreground):
2197 Remove unused variable `width'.
2199 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2201 * w32term.c (x_set_glyph_string_clipping):
2202 Don't pass uninitialized region to CombineRgn.
2204 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2206 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2207 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2208 (Fx_close_connection): Remove unused variable `i'.
2210 * w32font.c (w32font_draw): Return number of glyphs.
2211 (w32font_open_internal): Remove unused variable `i'.
2212 (w32font_driver): Add missing initializer.
2214 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2215 (fill_in_menu): Remove unused variable `items_added'.
2217 * w32term.c (last_mouse_press_frame): Remove static global variable.
2218 (w32_clip_to_row): Remove unused variable `f'.
2219 (x_delete_terminal): Remove unused variable `i'.
2221 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2222 (NOTHING): Remove unused static global variable.
2223 (uniscribe_check_otf): Remove unused variable `table'.
2224 (uniscribe_font_driver): Add missing initializers.
2226 2011-03-23 Julien Danjou <julien@danjou.info>
2228 * term.c (Fsuspend_tty, Fresume_tty):
2229 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2230 * window.c (temp_output_buffer_show):
2231 * insdel.c (signal_before_change):
2232 * frame.c (Fhandle_switch_frame):
2233 * fileio.c (Fdo_auto_save):
2234 * emacs.c (Fkill_emacs):
2235 * editfns.c (save_excursion_restore):
2236 * cmds.c (internal_self_insert):
2237 * callint.c (Fcall_interactively):
2238 * buffer.c (Fkill_all_local_variables):
2239 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2241 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2242 unconditionnaly since it does the check itself.
2244 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2246 Fix more problems found by GCC 4.5.2's static checks.
2248 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2249 the first time through the loop, since we know p0 < p1 then.
2250 This also avoids a gcc -Wstrict-overflow warning.
2252 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2253 leading to a memory leak, possible in functions like
2254 load_charset_map_from_file that can allocate an unbounded number
2255 of objects (Bug#8318).
2257 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2258 that could (at least in theory) be that large.
2260 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2261 This is less likely to overflow, and avoids undefined behavior if
2262 overflow does occur. All callers changed. Use strtoul to scan
2263 for the unsigned long integer.
2264 (pint2hrstr): Simplify and tune code slightly.
2265 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2267 * scroll.c (do_scrolling): Work around GCC bug 48228.
2268 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2270 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2271 This also avoids a warning with gcc -Wstrict-overflow.
2272 (validate_x_resource_name): Simplify count usage.
2273 This also avoids a warning with gcc -Wstrict-overflow.
2275 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2278 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2280 * process.c (Fmake_network_process): Use socklen_t, not int,
2281 where POSIX says socklen_t is required in portable programs.
2282 This fixes a porting bug on hosts like 64-bit HP-UX, where
2283 socklen_t is wider than int (Bug#8277).
2284 (Fmake_network_process, server_accept_connection):
2285 (wait_reading_process_output, read_process_output):
2288 * process.c: Rename or move locals to avoid shadowing.
2289 (list_processes_1, Fmake_network_process):
2290 (read_process_output_error_handler, exec_sentinel_error_handler):
2291 Rename or move locals.
2292 (Fmake_network_process): Define label "retry_connect" only if needed.
2293 (Fnetwork_interface_info): Fix pointer signedness.
2294 (process_send_signal): Add cast to avoid pointer signedness problem.
2295 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2296 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2298 Make tparam.h and terminfo.c consistent.
2299 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2300 Include tparam.h instead, since it declares them.
2301 * cm.h (PC): Remove extern decl; tparam.h now does this.
2302 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2303 * terminfo.c: Include tparam.h, to check interfaces.
2304 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2305 (tparam): Adjust signature to match interface in tparam.h;
2306 this removes some undefined behavior. Check that outstring and len
2307 are zero, which they always are with Emacs.
2308 * tparam.h (PC, BC, UP): New extern decls.
2310 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2311 (xftfont_open): Rename locals to avoid shadowing.
2313 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2314 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2315 (OTF_TAG_SYM): Omit macro if not needed.
2316 (ftfont_list): Remove unused local.
2317 (get_adstyle_property, ftfont_pattern_entity):
2318 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2319 Rename locals to avoid shadowing.
2321 * xfont.c (xfont_list_family): Mark var as initialized.
2323 * xml.c (make_dom): Now static.
2325 * composite.c (composition_compute_stop_pos): Rename local to
2327 (composition_reseat_it): Remove unused locals.
2328 (find_automatic_composition, composition_adjust_point): Likewise.
2329 (composition_update_it): Mark var as initialized.
2330 (find_automatic_composition): Mark vars as initialized,
2331 with a FIXME (Bug#8290).
2333 character.h: Rename locals to avoid shadowing.
2334 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2335 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2336 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2337 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2340 * textprop.c (property_change_between_p): Remove; unused.
2342 * intervals.c (interval_start_pos): Now static.
2344 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2346 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2347 Rename locals to avoid shadowing.
2349 * sound.c (wav_play, au_play, Fplay_sound_internal):
2350 Fix pointer signedness.
2351 (alsa_choose_format): Remove unused local var.
2352 (wav_play): Initialize a variable to 0, to prevent undefined
2353 behavior (Bug#8278).
2355 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2357 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2359 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2360 clobbering (Bug#8298).
2361 * sysdep.c (sys_subshell): Likewise.
2362 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2364 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2365 This should get cleaned up, so that child_setup has the
2366 same signature on all platforms.
2368 * callproc.c (call_process_cleanup): Now static.
2369 (relocate_fd): Rename locals to avoid shadowing.
2371 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2373 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2374 not to be necessary, and produces flickering.
2376 2011-03-20 Glenn Morris <rgm@gnu.org>
2378 * config.in: Remove file.
2380 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2382 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2383 are now in src/globals.h.
2384 (syms_of_minibuf): Remove spurious & from previous change.
2386 2011-03-20 Leo <sdl.web@gmail.com>
2388 * minibuf.c (completing-read-function): New variable.
2389 (completing-read-default): Rename from completing-read.
2390 (completing-read): Call completing-read-function.
2392 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2394 * xfaces.c (Fx_load_color_file):
2395 Read color file from absolute filename (bug#8250).
2397 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2399 * makefile.w32-in: Update dependencies.
2401 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2403 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2405 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2407 Fix more problems found by GCC 4.5.2's static checks.
2409 * process.c (make_serial_process_unwind, send_process_trap):
2410 (sigchld_handler): Now static.
2412 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2413 That way, the code declares only the vars that it needs.
2414 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2415 * s/cygwin.h (PTY_ITERATION): Likewise.
2416 * s/darwin.h (PTY_ITERATION): Likewise.
2417 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2419 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2420 * process.c (allocate_pty): Don't declare stb unless it's needed.
2422 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2423 (CONSTANTLIM): Remove; unused.
2424 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2425 Define only if needed.
2427 * unexelf.c (unexec): Name an expression,
2428 to avoid gcc -Wbad-function-cast warning.
2429 Use a different way to cause a compilation error if anyone uses
2430 n rather than nn, a way that does not involve shadowing.
2431 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2433 * deps.mk (unexalpha.o): Remove; unused.
2435 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2436 * unexec.h: New file.
2437 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2438 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2440 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2441 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2442 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2443 Change as necessary to match prototype in unexec.h.
2445 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2447 (back_comment, skip_chars): Mark vars as initialized.
2449 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2450 Rename locals to avoid shadowing.
2452 * lread.c (read1): Rewrite so as not to use empty "else".
2453 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2455 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2457 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2458 warning when compiling print.c.
2460 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2461 instead of using an uninitialized var.
2462 (font_sort_entities): Mark var as initialized.
2464 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2466 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2467 pointers to constants.
2468 (font_parse_fcname): Remove unused vars.
2469 (font_delete_unmatched): Now static.
2470 (font_get_spec): Remove; unused.
2471 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2472 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2473 Rename or move locals to avoid shadowing.
2475 * fns.c (require_nesting_list, require_unwind): Now static.
2476 (Ffillarray): Rename locals to avoid shadowing.
2478 * floatfns.c (domain_error2): Define only if needed.
2479 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2481 * alloc.c (mark_backtrace): Move decl from here ...
2482 * lisp.h: ... to here, so that it can be checked.
2484 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2485 (Fdefvar): Rewrite so as not to use empty "else".
2486 (lisp_indirect_variable): Name an expression,
2487 to avoid gcc -Wbad-function-cast warning.
2488 (Fdefvar): Rename locals to avoid shadowing.
2490 * callint.c (quotify_arg, quotify_args): Now static.
2491 (Fcall_interactively): Rename locals to avoid shadowing.
2492 Use const pointer when appropriate.
2494 * lisp.h (get_system_name, get_operating_system_release):
2495 Move decls here, to check interfaces.
2496 * process.c (get_operating_system_release): Move decl to lisp.h.
2497 * xrdb.c (get_system_name): Likewise.
2498 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2499 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2500 some of which prompt warnings from gcc -Wbad-function-cast.
2501 (Fformat_time_string, Fencode_time, Finsert_char):
2502 (Ftranslate_region_internal, Fformat):
2503 Rename or remove local vars to avoid shadowing.
2504 (Ftranslate_region_internal): Mark var as initialized.
2506 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2509 * lisp.h (eassert): Check that the argument compiles, even if
2510 ENABLE_CHECKING is not defined.
2512 * data.c (Findirect_variable): Name an expression, to avoid
2513 gcc -Wbad-function-cast warning.
2514 (default_value, arithcompare, arith_driver, arith_error): Now static.
2515 (store_symval_forwarding): Rename local to avoid shadowing.
2516 (Fmake_variable_buffer_local, Fmake_local_variable):
2517 Mark variables as initialized.
2518 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2520 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2521 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2522 Rename locals to avoid shadowing.
2523 (mark_stack): Move local variables into the #ifdef region where
2525 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2526 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2528 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2529 (GC_STRING_CHARS): Remove; not used.
2530 (Fmemory_limit): Cast sbrk's returned value to char *.
2532 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2533 avoids undefined behavior in theory.
2535 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2537 Use functions, not macros, for up- and down-casing (Bug#8254).
2538 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2539 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2540 to use the following functions instead of these macros.
2541 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2542 EMACS_INT, since callers assume the returned value fits in int.
2543 (upcase1): Likewise, for UPCASE_TABLE.
2544 (uppercasep, lowercasep, upcase): New static inline functions.
2545 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2546 the race-condition problem in the old DOWNCASE.
2548 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2549 Rename locals to avoid shadowing.
2550 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2551 (regex_compile, re_search_2, re_match_2_internal):
2552 Remove unused local vars.
2553 (FREE_VAR): Rewrite so as not to use empty "else",
2554 which gcc can warn about.
2555 (regex_compile, re_match_2_internal): Mark locals as initialized.
2556 (RETALLOC_IF): Define only if needed.
2557 (WORDCHAR_P): Likewise. This one is never needed, but is used
2558 only in a comment talking about a compiler bug, so put inside
2559 the #if 0 of that comment.
2560 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2561 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2564 * search.c (boyer_moore): Rename locals to avoid shadowing.
2565 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2566 (PREV_CHAR_BOUNDARY): Likewise.
2568 * search.c (simple_search): Remove unused var.
2570 * dired.c (compile_pattern): Move decl from here ...
2571 * lisp.h: ... to here, so that it can be checked.
2572 (struct re_registers): New forward decl.
2574 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2576 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2578 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2579 Rename locals to avoid shadowing.
2580 (Fvertical_motion): Mark locals as initialized.
2582 * casefiddle.c (casify_object, casify_region): Now static.
2583 (casify_region): Mark local as initialized.
2585 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2587 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2588 New macros, so that the caller can use some names other than
2589 gcpro1, gcpro2, etc.
2590 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2592 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2593 argument, for consistency with GCPRO2_VAR, etc: it is now the
2594 prefix of the variable, not the variable itself. All uses
2596 * dired.c (directory_files_internal, file_name_completion):
2597 Rename locals to avoid shadowing.
2599 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2600 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2601 dired.c's scmp function, had undefined behavior.
2602 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2603 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2604 * buffer.h: ... to here, because these macros use current_buffer,
2605 and the new implementation with inline functions needs to have
2606 current_buffer in scope now, rather than later when the macros
2608 (downcase, upcase1): New static inline functions.
2609 (DOWNCASE, UPCASE1): Reimplement using these functions.
2610 This avoids undefined behavior in expressions like
2611 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2612 from race conditions in accessing the global variables
2613 case_temp1 and case_temp2.
2614 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2615 * lisp.h (case_temp1, case_temp2): Remove their decls.
2616 * character.h (ASCII_CHAR_P): Move from here ...
2617 * lisp.h: ... to here, so that the inline functions mentioned
2620 * dired.c (directory_files_internal_unwind): Now static.
2622 * fileio.c (file_name_as_directory, directory_file_name):
2623 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2625 (file_name_as_directory): Use const pointers when appropriate.
2626 (Fexpand_file_name): Likewise. In particular, newdir might
2627 point at constant storage, so make it a const pointer.
2628 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2629 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2631 (Fset_file_times, Finsert_file_contents, auto_save_error):
2632 Rename locals to avoid shadowing.
2634 * minibuf.c (choose_minibuf_frame_1): Now static.
2635 (Ftry_completion, Fall_completions): Rename or remove locals
2638 * marker.c (bytepos_to_charpos): Remove; unused.
2640 * lisp.h (verify_bytepos, count_markers): New decls,
2641 so that gcc does not warn that these functions aren't declared.
2643 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2644 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2645 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2646 (copy_text): Remove unused local var.
2648 * filelock.c (within_one_second): Now static.
2649 (lock_file_1): Rename local to avoid shadowing.
2651 * buffer.c (fix_overlays_before): Mark locals as initialized.
2652 (fix_start_end_in_overlays): Likewise. This function should be
2653 simplified by using pointers-to-pointers, but that's a different
2655 (switch_to_buffer_1): Now static.
2656 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2657 (report_overlay_modification): Rename locals to avoid shadowing.
2659 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2660 Fix pointer signedness issue.
2661 (sys_subshell): Mark local as volatile if checking for lint,
2662 to suppress a gcc -Wclobbered warning that does not seem to be right.
2663 (MAXPATHLEN): Define only if needed.
2665 * process.c (serial_open, serial_configure): Move decls from here ...
2666 * systty.h: ... to here, so that they can be checked.
2668 * fns.c (get_random, seed_random): Move extern decls from here ...
2669 * lisp.h: ... to here, so that they can be checked.
2671 * sysdep.c (reset_io): Now static.
2672 (wait_for_termination_signal): Remove; unused.
2674 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2675 (copy_keymap_item, append_key, push_text_char_description):
2677 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2678 (DENSE_TABLE_SIZE): Remove; unused.
2679 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2680 (describe_map_tree):
2681 Rename locals to avoid shadowing.
2683 * keyboard.c: Declare functions static if they are not used elsewhere.
2684 (echo_char, echo_dash, cmd_error, top_level_2):
2685 (poll_for_input, handle_async_input): Now static.
2686 (read_char, kbd_buffer_get_event, make_lispy_position):
2687 (make_lispy_event, make_lispy_movement, apply_modifiers):
2688 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2689 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2690 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2691 (read_key_sequence, read_char): Mark locals as initialized.
2692 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2694 * keyboard.h (make_ctrl_char): New decl.
2695 (mark_kboards): Move decl here ...
2696 * alloc.c (mark_kboards): ... from here.
2698 * lisp.h (force_auto_save_soon): New decl.
2700 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2701 (DEFINE_DUMMY_FUNCTION): New macro.
2702 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2704 (main): Add casts to avoid warnings
2705 if GCC considers string literals to be constants.
2707 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2709 * dbusbind.c: Pointer signedness fixes.
2710 (xd_signature, xd_append_arg, xd_initialize):
2711 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2712 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2713 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2714 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2716 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2717 if GCC considers string literals to be constants.
2718 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2720 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2722 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2723 (print_preprocess, print_object): New macro to fix last change.
2725 * print.c (print_preprocess): Don't forget font objects.
2727 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2729 * emacs.c (USAGE3): Doc fixes.
2731 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2733 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2736 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2738 * lisp.h (VWindow_system, Qfile_name_history):
2739 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2740 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2741 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2743 * w32select.c: Don't #include "keyboard.h".
2744 (run_protected): Add extern declaration for waiting_for_input.
2746 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2747 * w32console.c (detect_input_pending, read_input_pending)
2748 (encode_terminal_code):
2749 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2750 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2751 (w32_system_caret_y, Qfile_name_history):
2752 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2753 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2754 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2755 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2756 * w32proc.c (Qlocal, report_file_error):
2757 * w32term.c (Vwindow_system, updating_frame):
2758 * w32uniscribe.c (initialized, uniscribe_font_driver):
2759 Remove unneeded extern declarations.
2761 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2763 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2765 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2767 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2768 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2769 These macros can no longer be used for assignment.
2771 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2772 Assign struct members directly, instead of using BUF_BEGV etc.
2773 (record_buffer_markers, fetch_buffer_markers): New functions for
2774 recording and fetching special buffer markers.
2775 (set_buffer_internal_1, set_buffer_temp): Use them.
2777 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2779 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2781 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2782 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2784 * xdisp.c (hscroll_window_tree):
2785 (reconsider_clip_changes): Use PT instead of BUF_PT.
2787 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2789 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2790 $(EMACS_ROOT)/lib/intprops.h.
2792 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2794 Fix more problems found by GCC 4.5.2's static checks.
2796 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2797 to unsigned char * to avoid compiler diagnostic.
2798 (xg_free_frame_widgets): Make it clear that a local variable is
2799 needed only if USE_GTK_TOOLTIP.
2800 (gdk_window_get_screen): Make it clear that this macro is needed
2801 only if USE_GTK_TOOLTIP.
2802 (int_gtk_range_get_value): New function, which avoids a diagnostic
2803 from gcc -Wbad-function-cast.
2804 (xg_set_toolkit_scroll_bar_thumb): Use it.
2805 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2806 diagnostic from gcc -Wbad-function-cast.
2807 (get_utf8_string, xg_get_file_with_chooser):
2808 Rename locals to avoid shadowing.
2809 (create_dialog): Move locals to avoid shadowing.
2811 * xgselect.c (xg_select): Remove unused var.
2813 * image.c (four_corners_best): Mark locals as initialized.
2814 (gif_load): Initialize transparent_p to zero (Bug#8238).
2815 Mark another local as initialized.
2816 (my_png_error, my_error_exit): Mark with NO_RETURN.
2818 * image.c (clear_image_cache): Now static.
2819 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2820 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2821 (x_edge_detection): Remove unnecessary cast that
2822 gcc -Wbad-function-cast diagnoses.
2823 (gif_load): Fix pointer signedness.
2824 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2825 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2827 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2829 Improve quality of tests for time stamp overflow.
2830 For example, without this patch (encode-time 0 0 0 1 1
2831 1152921504606846976) returns the obviously-bogus value (-948597
2832 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2833 reports time overflow. See
2834 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2835 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2836 * editfns.c: Include limits.h and intprops.h.
2837 (TIME_T_MIN, TIME_T_MAX): New macros.
2838 (time_overflow): Move earlier, to before first use.
2839 (hi_time, lo_time): New functions, for an accurate test for
2841 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2842 (Fget_internal_run_time): Don't assume time_t fits in int.
2843 (make_time): Use list2 instead of Fcons twice.
2844 (Fdecode_time): More accurate test for out-of-range times.
2845 (check_tm_member): New function.
2846 (Fencode_time): Use it, to test for out-of-range times.
2847 (lisp_time_argument): Don't rely on undefined left-shift and
2848 right-shift behavior when checking for time stamp overflow.
2850 * editfns.c (time_overflow): New function, refactoring common code.
2851 (Fformat_time_string, Fdecode_time, Fencode_time):
2852 (Fcurrent_time_string): Use it.
2854 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2855 * dired.c (make_time): Move to ...
2856 * editfns.c (make_time): ... here.
2857 * systime.h: Note the move.
2859 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2861 * fringe.c (update_window_fringes): Remove unused variables.
2863 * unexmacosx.c (copy_data_segment): Also copy __got section.
2866 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2868 * termcap.c [MSDOS]: Include "msdos.h".
2869 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2870 Constify `char *' arguments and their references according to
2871 prototypes in tparam.h.
2873 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2875 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2876 Adapt all references accordingly.
2878 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2880 2011-03-11 Tom Tromey <tromey@redhat.com>
2882 * buffer.c (syms_of_buffer): Remove obsolete comment.
2884 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2886 * termhooks.h (encode_terminal_code): Declare prototype.
2888 * msdos.c (encode_terminal_code): Don't declare prototype.
2890 * term.c (encode_terminal_code): Now external again, used by
2891 w32console.c and msdos.c.
2893 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2894 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2896 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2898 Fix some minor problems found by GCC 4.5.2's static checks.
2900 * fringe.c (update_window_fringes): Mark locals as initialized
2902 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2904 * alloc.c (mark_fringe_data): Move decl from here ...
2905 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2906 to check its interface.
2907 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2909 * fontset.c (free_realized_fontset): Now static.
2910 (Fset_fontset_font): Rename local to avoid shadowing.
2911 (fontset_font): Mark local as initialized.
2912 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2914 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2916 * xselect.c (x_disown_buffer_selections): Remove; not used.
2917 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2918 (x_own_selection, Fx_disown_selection_internal): Rename locals
2920 (x_handle_dnd_message): Remove local to avoid shadowing.
2922 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2923 so that the caller can use some name other than gcpro1.
2924 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2925 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2926 (Fx_backspace_delete_keys_p):
2927 Use them to avoid shadowing, and rename vars to avoid shadowing.
2928 (x_decode_color, x_set_name, x_window): Now static.
2929 (Fx_create_frame): Add braces to silence GCC warning.
2930 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2931 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2932 Remove unused locals.
2933 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2934 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2935 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2938 * xterm.h (x_mouse_leave): New decl.
2940 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2941 Remove unused functions.
2942 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2943 (x_calc_absolute_position): Now static.
2944 (XTread_socket): Don't define label "out" unless it's used.
2945 Don't declare local "event" unless it's used.
2946 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2947 unless they are used.
2948 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2949 (x_fatal_error_signal): Remove; not used.
2950 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2951 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2952 (x_error_catcher, x_connection_closed, x_error_handler):
2953 (x_error_quitter, xembed_send_message, x_iconify_frame):
2954 (my_log_handler): Rename locals to avoid shadowing.
2955 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2956 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2958 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2959 Rename or move locals to avoid shadowing.
2960 (tty_defined_color, merge_face_heights): Now static.
2961 (free_realized_faces_for_fontset): Remove; not used.
2962 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2963 does not deduce is never used uninitialized.
2964 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2965 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2967 * terminal.c (store_terminal_param): Now static.
2969 * xmenu.c (menu_highlight_callback): Now static.
2970 (set_frame_menubar): Remove unused local.
2971 (xmenu_show): Rename parameter to avoid shadowing.
2972 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2973 since they might point to immutable storage.
2974 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2975 since it's unused otherwise.
2977 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2978 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2979 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2980 avoids a gcc -Wuninitialized diagnostic.
2981 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2982 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2983 does not deduce are never used uninitialized.
2985 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2987 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2988 * window.c (window_loop, size_window):
2989 (run_window_configuration_change_hook, enlarge_window): Likewise.
2991 * window.c (display_buffer): Now static.
2992 (size_window): Mark variables that gcc -Wuninitialized
2993 does not deduce are never used uninitialized.
2994 * window.h (check_all_windows): New decl, to forestall
2995 gcc -Wmissing-prototypes diagnostic.
2996 * dispextern.h (bidi_dump_cached_states): Likewise.
2998 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3000 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3002 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3003 and to avoid gcc -Wuninitialized warning.
3004 (load_charset_map): Mark variables that gcc -Wuninitialized
3005 does not deduce are never used uninitialized.
3006 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3008 * coding.c (coding_set_source, coding_set_destination):
3009 Use "else { /* comment */ }" rather than "else /* comment */;"
3010 for clarity, and to avoid gcc -Wempty-body warning.
3011 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3012 a block, when the outer 'i' will do.
3013 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3014 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3015 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3016 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3017 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3018 Rename locals to avoid shadowing.
3019 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3020 * coding.c (emacs_mule_char, encode_invocation_designation):
3021 Now static, since they're not used elsewhere.
3022 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3023 (decode_coding_object, encode_coding_object, detect_coding_system):
3024 (decode_coding_emacs_mule): Mark variables that gcc
3025 -Wuninitialized does not deduce are never used uninitialized.
3026 (detect_coding_iso_2022): Initialize a local variable that might
3027 be used uninitialized. Leave a FIXME because it's not clear that
3028 this initialization is needed. (Bug#8211)
3029 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3030 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3031 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3032 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3033 Remove unused macros.
3035 * category.c (hash_get_category_set): Remove unused local var.
3036 (copy_category_table): Now static, since it's not used elsewhere.
3037 * character.c (string_count_byte8): Likewise.
3039 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3040 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3042 * chartab.c (copy_sub_char_table): Now static, since it's not used
3044 (sub_char_table_ref_and_range, char_table_ref_and_range):
3045 Rename locals to avoid shadowing.
3046 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3048 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3049 (BIDI_BOB): Remove unused macro.
3051 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3052 deduce are never used uninitialized.
3053 * term.c (encode_terminal_code): Likewise.
3055 * term.c (encode_terminal_code): Now static. Remove unused local.
3057 * tparam.h: New file.
3058 * term.c, tparam.h: Include it.
3059 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3060 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3061 Move these decls to tparam.h, and make them agree with what
3062 is actually in tparam.c. The previous trick of using incompatible
3063 decls in different modules does not conform to the C standard.
3064 All callers of tparam changed to use tparam's actual API.
3065 * tparam.c (tparam1, tparam, tgoto):
3066 Use const pointers where appropriate.
3068 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3069 * cm.h (struct cm): Likewise.
3070 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3071 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3072 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3073 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3074 (turn_on_face, init_tty): Likewise.
3075 * termchar.h (struct tty_display_info): Likewise.
3077 * term.c (term_mouse_position): Rename local to avoid shadowing.
3079 * alloc.c (mark_ttys): Move decl from here ...
3080 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3082 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3084 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3086 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3088 * search.c (compile_pattern_1): Remove argument regp, unused since
3089 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3090 (compile_pattern): Don't pass it.
3092 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3094 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3095 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3097 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3099 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3101 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3102 gdk_window_get_screen, gdk_window_get_geometry,
3103 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3104 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3105 (xg_get_pixbuf_from_pixmap): New function.
3106 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3107 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3108 Call xg_get_pixbuf_from_pixmap instead of
3109 gdk_pixbuf_get_from_drawable.
3110 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3111 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3112 (xg_check_special_colors): Use GtkStyleContext and its functions
3114 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3115 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3116 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3117 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3118 Call gtk_widget_get_preferred_size.
3119 (xg_frame_resized): gdk_window_get_geometry only takes 5
3121 (xg_win_to_widget, xg_event_is_for_menubar):
3122 Call gdk_x11_window_lookup_for_display.
3123 (xg_set_widget_bg): New function.
3124 (delete_cb): New function.
3125 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3126 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3127 (xg_set_background_color): Call xg_set_widget_bg.
3128 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3129 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3130 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3131 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3133 (update_frame_tool_bar): Call gtk_widget_hide.
3134 (xg_initialize): Use GDK_KEY_g.
3136 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3138 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3140 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3141 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3142 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3144 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3146 * w32xfns.c (select_palette): Check success of RealizePalette against
3147 GDI_ERROR, not zero.
3149 See ChangeLog.11 for earlier changes.
3155 Copyright (C) 2011 Free Software Foundation, Inc.
3157 This file is part of GNU Emacs.
3159 GNU Emacs is free software: you can redistribute it and/or modify
3160 it under the terms of the GNU General Public License as published by
3161 the Free Software Foundation, either version 3 of the License, or
3162 (at your option) any later version.
3164 GNU Emacs is distributed in the hope that it will be useful,
3165 but WITHOUT ANY WARRANTY; without even the implied warranty of
3166 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3167 GNU General Public License for more details.
3169 You should have received a copy of the GNU General Public License
3170 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.