Make find_automatic_composition more efficient.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a28d4396
KH
12011-05-18 Kenichi Handa <handa@m17n.org>
2
3 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5 (find_automatic_composition): Mostly rewrite for efficiency.
6
d2fc7e3d 72011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8
9 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10
d2fc7e3d 112011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12
13 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14 `width' to `bar_area_x' and `bar_area_width', respectively.
15 (x_scroll_run): Take account of fringe background extension.
16
17 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]: Rename
18 local vars `left' and `width' to `bar_area_x' and
19 `bar_area_width', respectively.
20 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
21 background extension.
22
79b70037
GM
232011-05-10 Jim Meyering <meyering@redhat.com>
24
25 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
26
2f142cc5
JB
272011-05-10 Juanma Barranquero <lekktu@gmail.com>
28
29 * image.c (Finit_image_library): Return t for built-in image types,
30 like pbm and xbm. (Bug#8640)
31
57679c86
AS
322011-05-09 Andreas Schwab <schwab@linux-m68k.org>
33
34 * w32menu.c (set_frame_menubar): Fix submenu allocation.
35
888c9e86
EZ
362011-05-07 Eli Zaretskii <eliz@gnu.org>
37
b0512a1d
EZ
38 * w32console.c (Fset_screen_color): Doc fix.
39 (Fget_screen_color): New function.
40 (syms_of_ntterm): Defsubr it.
41
888c9e86
EZ
42 * callproc.c (call_process_cleanup): Don't close and unlink the
43 temporary file if Fcall_process didn't create it in the first
44 place.
45 (Fcall_process): Don't create tempfile if stdout of the child
46 process will be redirected to a file specified with `:file'.
47 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
48 cue to call_process_cleanup not to close that handle.
49
4d3fcc8e
BK
502011-05-07 Ben Key <bkey76@gmail.com>
51
52 * makefile.w32-in: The bootstrap-temacs rule now makes use of
53 one of two shell specific rules, either bootstrap-temacs-CMD or
54 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
55 to the previous implementation of the bootstrap-temacs rule.
56 The bootstrap-temacs-CMD rule is similar to the previous
57 implementation of the bootstrap-temacs rule except that it
58 makes use of the ESC_CFLAGS variable instead of the CFLAGS
59 variable.
60
61 These changes, along with some changes to nt/configure.bat,
62 nt/gmake.defs, and nt/nmake.defs, are required to extend my
63 earlier fix to add support for --cflags and --ldflags options
64 that include quotes so that it works whether make uses cmd or
65 sh as the shell.
66
b4289b64
MA
672011-05-06 Michael Albinus <michael.albinus@gmx.de>
68
69 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
70 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
71 is a constant.
72 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
73 a string. Handle both cases.
74 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
75 (Fdbus_register_method): Use Qinvalid_function.
76
af4c0e28
JB
772011-05-06 Juanma Barranquero <lekktu@gmail.com>
78
79 * makefile.w32-in: Update dependencies.
80 (LISP_H): Add inttypes.h and stdin.h.
81 (PROCESS_H): Add unistd.h.
82
c51453d9
EZ
832011-05-06 Eli Zaretskii <eliz@gnu.org>
84
85 * lread.c: Include limits.h (fixes the MS-Windows build broken by
86 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
87
8ff0ac3c 882011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 89
4c4b566b
PE
90 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
91
aab2b9b5
PE
92 * term.c (vfatal): Remove stray call to va_end.
93 It's not needed and the C Standard doesn't allow it here anyway.
94
c378da0b
PE
95 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
96 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
97
288b08c7
PE
98 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
99 bytes.
100
e3601888
PE
101 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
102
db6c0e74
PE
103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
104
dd5963ea
PE
105 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
106
88c9450f
PE
107 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
108
2f9442b8
PE
109 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
110
c032b5f8
PE
111 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
112 * charset.c (Fdefine_charset_internal): Don't initialize
113 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 114 32-bit int (Bug#8600).
a108c10b
PE
115
116 * lread.c (read_integer): Be more consistent with string-to-number.
117 Use string_to_number to do the actual conversion; this avoids
118 rounding errors and fixes some other screwups. Without this fix,
119 for example, #x1fffffffffffffff was misread as -2305843009213693952.
120 (digit_to_number): Move earlier, for benefit of read_integer.
121 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 122 not a digit in any supported base. (Bug#8602)
a108c10b 123
ad5f9eea
PE
124 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
125
aec1708a
PE
126 * dispnew.c (scrolling_window): Return 1 if we scrolled,
127 to match comment at start of function. This also removes a
128 GCC warning about overflow in a 32+64-bit port.
129
47be4ab5
PE
130 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
131
371cac43
PE
132 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
133 Reported by Stefan Monnier in
134 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
135 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
136 SYMBOLP-guarded XSYMBOL, not XPNTR.
137
d01a7826
PE
138 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
139 (EMACS_UINTPTR): Likewise, with uintptr_t.
140
7fd47d5c
PE
141 * lisp.h: Prefer 64-bit EMACS_INT if available.
142 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
143 on 32-bit hosts that have 64-bit int, so that they can access
144 large files.
122b0c86
PE
145 However, temporarily disable this change unless the temporary
146 symbol WIDE_EMACS_INT is defined.
7fd47d5c 147
8727937b
PE
148 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
149
8ac068ac
PE
150 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
151 This removes an assumption that EMACS_INT and long are the same
152 width as pointers. The assumption is true for Emacs porting targets
153 now, but we want to make other targets possible.
154 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
155 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
156 In the rest of the code, change types of integers that hold casted
157 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
158 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
159 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
160 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
161 No need to cast type when ORing.
162 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
163 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
164 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
165 assume EMACS_INT is the same width as char *.
166 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
167 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
168 Remove no-longer-needed casts.
169 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
170 (xg_tool_bar_help_callback, xg_make_tool_item):
171 Use EMACS_INTPTR to hold an integer
172 that will be cast to void *; this can avoid a GCC warning
173 if EMACS_INT is not the same width as void *.
174 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
175 * xdisp.c (display_echo_area_1, resize_mini_window_1):
176 (current_message_1, set_message_1):
177 Use a local to convert to proper width without a cast.
178 * xmenu.c (dialog_selection_callback): Likewise.
179
ede49d71
PE
180 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
181 Also, don't assume VALBITS / RAND_BITS is less than 5,
182 and don't rely on undefined behavior when shifting a 1 left into
183 the sign bit.
184 * lisp.h (get_random): Change signature to match.
185
2f30ecd0
PE
186 * lread.c (hash_string): Use size_t, not int, for hash computation.
187 Normally we prefer signed values; but hashing is special, because
188 it's better to use unsigned division on hash table sizes so that
189 the remainder is nonnegative. Also, size_t is the natural width
190 for hashing into memory. The previous code used 'int', which doesn't
191 retain enough info to hash well into very large tables.
192 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
193
2a866e7b
PE
194 * dbusbind.c: Don't possibly lose pointer info when converting.
195 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
196 Use XPNTR rather than XHASH, so that the high-order bits of
197 the pointer aren't lost when converting through void *.
198
51639eac
PE
199 * eval.c (Fautoload): Don't double-shift a pointer.
200
92394119
PE
201 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
202
dbdb9a7c
JB
2032011-05-06 Juanma Barranquero <lekktu@gmail.com>
204
205 * gnutls.c (DEF_GNUTLS_FN):
206 * image.c (DEF_IMGLIB_FN): Make function pointers static.
207
db7a0b4f
AS
2082011-05-05 Andreas Schwab <schwab@linux-m68k.org>
209
210 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
211 marker. (Bug#8610)
212
f7ff1b0f 2132011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
214
215 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
216 New version that can reserve upto 2GB of heap space.
217
f7ff1b0f 2182011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
219
220 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
221
639c109b
TZ
2222011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
223
224 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
225 `gnutls_certificate_set_x509_key_file'.
226
d2127135
JB
2272011-05-05 Juanma Barranquero <lekktu@gmail.com>
228
229 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
230 Update dependencies.
231
e968f4f3
JB
2322011-05-04 Juanma Barranquero <lekktu@gmail.com>
233
234 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
235 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
236 Remove unused parameter `fildes'.
237 * process.c (read_process_output, send_process): Don't pass it.
238
84d358f0
JB
2392011-05-04 Juanma Barranquero <lekktu@gmail.com>
240
241 Fix previous change: the library cache is defined in w32.c.
242 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
243 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
244
0898ca10
JB
2452011-05-04 Juanma Barranquero <lekktu@gmail.com>
246
247 Implement dynamic loading of GnuTLS on Windows.
248
249 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
250 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
251 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
252 Declare.
253
254 * gnutls.c (Qgnutls_dll): Define.
255 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
256 (gnutls_*): Declare function pointers.
257 (init_gnutls_functions): New function to initialize function pointers.
258 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
259 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
260 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
261 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
262 (emacs_gnutls_write, emacs_gnutls_read)
263 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
264 (Fgnutls_available_p): New function.
265 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
266 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
267 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
268
269 * image.c: Include w32.h.
270 (Vimage_type_cache): Delete.
271 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
272 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
273 (w32_delayed_load): Move to w32.c.
274
275 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
276
277 * w32.c (QCloaded_from, Vlibrary_cache): Define.
278 (w32_delayed_load): Move from image.c. When loading a library, record
279 its filename in the :loaded-from property of the library id.
280 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
281 Initialize and staticpro them.
282 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
283
284 * process.c: Include lisp.h before w32.h, not after.
285 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
286 instead of gnutls_record_check_pending.
287
288 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
289
ff4de4aa
TZ
2902011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
291
292 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
293 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
294 as passed in.
295
abe95abb
JD
2962011-05-03 Jan Djärv <jan.h.d@swipnet.se>
297
298 * xterm.c (x_set_frame_alpha): Do not set property on anything
299 else than FRAME_X_OUTER_WINDOW (Bug#8608).
300
e16e55d4
JB
3012011-05-02 Juanma Barranquero <lekktu@gmail.com>
302
303 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
304
bafcf6a5
JB
3052011-05-02 Juanma Barranquero <lekktu@gmail.com>
306
307 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
308 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
309 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
310 (gnutls_global_initialized, Qgnutls_bootprop_priority)
311 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
312 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
313 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
314 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
315 (Qgnutls_bootprop_callbacks_verify): Make static.
316
e7a6747f
AS
3172011-05-01 Andreas Schwab <schwab@linux-m68k.org>
318
19ed11ba
AS
319 * callproc.c: Indentation fixup.
320
e7a6747f
AS
321 * sysdep.c (wait_for_termination_1): Make static.
322 (wait_for_termination, interruptible_wait_for_termination): Move
323 after wait_for_termination_1.
324
1ef14cb4
LMI
3252011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
326
327 * sysdep.c (interruptible_wait_for_termination): New function
328 which is like wait_for_termination, but allows keyboard
329 interruptions.
330
331 * callproc.c (Fcall_process): Add (:file "file") as an option for
332 the STDOUT buffer.
333 (Fcall_process_region): Ditto.
334
330d880c
EZ
3352011-04-30 Eli Zaretskii <eliz@gnu.org>
336
8db90b73
EZ
337 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
338 rather than `XVECTOR (FOO)->size'.
339
330d880c
EZ
340 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
341 inttypes.h, as a gnulib replacement is used if it not available in
342 system headers.
343
15cbd324
EZ
3442011-04-21 Eli Zaretskii <eliz@gnu.org>
345
346 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
347 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
348 of MOST_POSITIVE_FIXNUM. (Bug#8528)
349
350 * coding.c (coding_alloc_by_realloc): Error out if destination
351 will grow beyond MOST_POSITIVE_FIXNUM.
352 (decode_coding_emacs_mule): Abort if there isn't enough place in
353 charbuf for the composition carryover bytes. Reserve an extra
354 space for up to 2 characters produced in a loop.
355 (decode_coding_iso_2022): Abort if there isn't enough place in
356 charbuf for the composition carryover bytes.
357
3582011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 359
ae940cca
EZ
360 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
361 aborting when %lld or %lll format is passed.
362 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
363 %llo or %llx format is passed. (Bug#8545)
364
03ab8921
EZ
365 * window.c (window_scroll_line_based): Use a marker instead of
366 simple variables to record original value of point. (Bug#7952)
367
afda1437
EZ
368 * doprnt.c (doprnt): Fix the case where a multibyte sequence
369 produced by %s or %c overflows available buffer space. (Bug#8545)
370
f76dee0c
PE
3712011-04-28 Paul Eggert <eggert@cs.ucla.edu>
372
373 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 374 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 375
fdc5744d
JB
3762011-04-28 Juanma Barranquero <lekktu@gmail.com>
377
378 * w32.c (init_environment): Warn about defaulting HOME to C:\.
379
638f053a
JB
3802011-04-28 Juanma Barranquero <lekktu@gmail.com>
381
382 * keyboard.c (Qdelayed_warnings_hook): Define.
383 (command_loop_1): Run `delayed-warnings-hook'
384 if Vdelayed_warnings_list is non-nil.
385 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
386 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
387
d178f871
EZ
3882011-04-28 Eli Zaretskii <eliz@gnu.org>
389
390 * doprnt.c (doprnt): Don't return value smaller than the buffer
391 size if the message was truncated. (Bug#8545).
392
b124fd93
JB
3932011-04-28 Juanma Barranquero <lekktu@gmail.com>
394
395 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
396 (Fx_window_property): #if-0 the whole functions, not just the bodies.
397
e810457d
PE
3982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
399
400 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
401
ea51cceb
JB
4022011-04-27 Juanma Barranquero <lekktu@gmail.com>
403
404 * makefile.w32-in: Update dependencies.
405
94dcfacf
EZ
4062011-04-27 Eli Zaretskii <eliz@gnu.org>
407
408 Improve `doprnt' and its usage. (Bug#8545)
409 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
410 `format_end'. Remove support for %l as a conversion specifier.
411 Don't use xrealloc. Improve diagnostics when the %l size modifier
412 is used. Update the commentary.
413
414 * eval.c (verror): Simplify calculation of size_t.
415
416 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
417 messages.
418
f61f41d7
PE
4192011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
420
421 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
422 change.
423
96fb4434
PE
4242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
425
426 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
427 This makes this file independent of the recent pseudovector change.
428
671875da 4292011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 430
69e9b5a3
PE
431 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
432
b5f869a7 433 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 434 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 435 Remove unused local.
c8926152 436 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 437
841a1577 438 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
439 GCC 4.6.0 optimizes based on type-based alias analysis. For
440 example, if b is of type struct buffer * and v of type struct
441 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
442 != &v->size, and therefore "v->size = 1; b->size = 2; return
443 v->size;" must therefore return 1. This assumption is incorrect
444 for Emacs, since it type-puns struct Lisp_Vector * with many other
445 types. To fix this problem, this patch adds a new type struct
f904488f 446 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
447 and pseudovectors, and helps optimizing compilers not get fooled
448 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
449 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
450 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
451 the size member.
eab3844f
PE
452 (XSETPVECTYPE): Rewrite in terms of new macro.
453 (XSETPVECTYPESIZE): New macro, specifying both type and size.
454 This is a bit clearer, and further avoids the possibility of
455 undesirable aliasing.
456 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 457 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
458 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
459 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
460 (ASIZE): Now uses header.size rather than size. All
461 previous uses of XVECTOR (foo)->size replaced to use this macro,
462 to avoid the hassle of writing XVECTOR (foo)->header.size.
463 (struct vectorlike_header): New type.
eab3844f
PE
464 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
465 object, to help avoid aliasing.
466 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
467 (SUBRP): Likewise, since Lisp_Subr is a special case.
468 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
469 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
470 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 471 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
472 changed to be "header.size" and "header.next".
473 * buffer.h (struct buffer): Likewise.
474 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
475 * frame.h (struct frame): Likewise.
476 * process.h (struct Lisp_Process): Likewise.
477 * termhooks.h (struct terminal): Likewise.
478 * window.c (struct save_window_data, struct saved_window): Likewise.
479 * window.h (struct window): Likewise.
480 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
481 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
482 * buffer.c (init_buffer_once): Likewise.
483 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
484 special case.
485 * process.c (Fformat_network_address): Use local var for size,
486 for brevity.
487
0df1eac5
PE
488 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
489
847ab9d1 490 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
491 * data.c (atof): Remove decl; no longer used or needed.
492 (digit_to_number): Move to lread.c.
493 (Fstring_to_number): Use new string_to_number function, to be
494 consistent with how the Lisp reader treats infinities and NaNs.
495 Do not assume that floating-point numbers represent EMACS_INT
496 without losing information; this is not true on most 64-bit hosts.
497 Avoid double-rounding errors, by insisting on integers when
498 parsing non-base-10 numbers, as the documentation specifies.
499 * lisp.h (string_to_number): New decl, replacing ...
500 (isfloat_string): Remove.
bc0a5c13 501 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 502 (read1): Do not accept +. and -. as integers; this
452f4150
PE
503 appears to have been a coding error. Similarly, do not accept
504 strings like +-1e0 as floating point numbers. Do not report
505 overflow for integer overflows unless the base is not 10 which
506 means we have no simple and reliable way to continue.
507 Break out the floating-point parsing into a new
508 function string_to_number, so that Fstring_to_number parses
509 floating point numbers consistently with the Lisp reader.
510 (digit_to_number): Moved here from data.c. Make it static inline.
511 (E_CHAR, EXP_INT): Remove, replacing with ...
512 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
513 (string_to_number): New function, replacing isfloat_string.
514 This function checks for valid syntax and produces the resulting
515 Lisp float number too. Rework it so that string-to-number
bc0a5c13 516 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
517 so that overflow for non-base-10 numbers is reported only when
518 there's no portable and simple way to convert to floating point.
452f4150 519
67769ffc
PE
520 * textprop.c (set_text_properties_1): Rewrite for clarity,
521 and to avoid GCC warning about integer overflow.
522
c20db43f
PE
523 * intervals.h (struct interval): Use EMACS_INT for members
524 where EMACS_UINT might cause problems. See
525 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
526 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
527 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
528 All uses changed.
37aa2f85
PE
529 (offset_intervals): Tell GCC not to worry about length overflow
530 when negating a negative length.
c20db43f 531
2538aa2f
PE
532 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
533 (overrun_check_free): Likewise.
534
f2d3008d
PE
535 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
536 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
537 word size.
538
ec8df744
PE
539 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
540 (gnutls_make_error): Rename local to avoid shadowing.
541 (gnutls_emacs_global_deinit): ifdef out; not used.
542 (Fgnutls_boot): Use const for pointer to readonly storage.
543 Comment out unused local. Fix pointer signedness problems.
544
640ee02d
PE
545 * lread.c (openp): Don't stuff size_t into an 'int'.
546 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
547 about possible signed overflow.
548
6048fb2a
PE
549 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
550 (GDK_KEY_g): Don't define if already defined.
551 (xg_prepare_tooltip): Avoid pointer signedness problem.
552 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
553
fa3c87e1
PE
554 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
555 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
556
2172544b
PE
557 * xfns.c (Fx_window_property): Simplify a bit,
558 to make a bit faster and to avoid GCC 4.6.0 warning.
559 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
560
9b821a21
PE
561 * fns.c (internal_equal): Don't assume size_t fits in int.
562
3c616cfa
PE
563 * alloc.c (compact_small_strings): Tighten assertion a little.
564
c2982e87
PE
565 Replace pEd with more-general pI, and fix some printf arg casts.
566 * lisp.h (pI): New macro, generalizing old pEd macro to other
567 conversion specifiers. For example, use "...%"pI"d..." rather
568 than "...%"pEd"...".
569 (pEd): Remove. All uses replaced with similar uses of pI.
570 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
571 * alloc.c (check_pure_size): Don't overflow by converting size to int.
572 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
573 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
574 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
575 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
576 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
577 64-bit hosts.
578 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
579 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
580 * print.c (safe_debug_print, print_object): Likewise.
581 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
582 to int.
6f04d126
PE
583 Use pI instead of if-then-else-abort. Use %p to avoid casts,
584 avoiding the 0 flag, which is not portable.
c2982e87
PE
585 * process.c (Fmake_network_process): Use pI to avoid cast.
586 * region-cache.c (pp_cache): Likewise.
587 * xdisp.c (decode_mode_spec): Likewise.
588 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
589 behavior on 64-bit hosts with printf arg.
6f04d126 590 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
591 (x_stop_queuing_selection_requests): Likewise.
592 (x_get_window_property): Don't truncate byte count to an 'int'
593 when tracing.
0b432f21 594
5e073ec7
PE
595 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
596 here, since it parses constructs like leading '-' and spaces,
597 which are not wanted; and it overflows with large numbers.
598 Instead, simply match F[0-9]+, which is what is wanted anyway.
599
36372bf9
PE
600 * alloc.c: Remove unportable assumptions about struct layout.
601 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
602 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
603 (allocate_vectorlike, make_pure_vector): Use the new macros,
604 plus offsetof, to remove unportable assumptions about struct layout.
605 These assumptions hold on all porting targets that I know of, but
606 they are not guaranteed, they're easy to remove, and removing them
607 makes further changes easier.
608
0b432f21
PE
609 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
610 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
611 (string_overrun_cookie): Now const. Use initializers that
612 don't formally overflow signed char, to avoid warnings.
000098c1
PE
613 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
614 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
615 (allocate_buffer): Don't assume sizeof (struct buffer) is a
616 multiple of sizeof (EMACS_INT); it need not be, if
617 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 618 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 619
895009e1
JB
6202011-04-26 Juanma Barranquero <lekktu@gmail.com>
621
622 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
623
6a7a1b0b
TZ
6242011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
625
626 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 627 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
628 Reported by Paul Eggert <eggert@cs.ucla.edu>.
629
841a1577 6302011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
631
632 * lisp.h (Qdebug): List symbol.
895009e1 633 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
634 * keyboard.c (debug-on-event): New variable.
635 (handle_user_signal): Break into debugger when debug-on-event
636 matches the current signal symbol.
637
f2d3ba6f
DN
6382011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
639
640 * alloc.c (check_sblock, check_string_bytes)
641 (check_string_free_list): Convert to standard C.
642
42ce4c63
TZ
6432011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
644
645 * w32.c (emacs_gnutls_push): Fix typo.
646
825cd63c
EZ
6472011-04-25 Eli Zaretskii <eliz@gnu.org>
648
fb11d64d
EZ
649 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
650 "cast to pointer from integer of different size".
651
825cd63c
EZ
652 Improve doprnt and its use in verror. (Bug#8545)
653 * doprnt.c (doprnt): Document the set of format control sequences
654 supported by the function. Use SAFE_ALLOCA instead of always
655 using `alloca'.
656
657 * eval.c (verror): Don't limit the buffer size at size_max-1, that
658 is one byte too soon. Don't use xrealloc; instead xfree and
659 xmalloc anew.
660
e061a11b
TZ
6612011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
662
663 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
664 callbacks stage.
665
666 * gnutls.c: Renamed global_initialized to
667 gnutls_global_initialized. Added internals for the
668 :verify-hostname-error, :verify-error, and :verify-flags
669 parameters of `gnutls-boot' and documented those parameters in the
670 docstring. Start callback support.
671 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
672 unless a fatal error occured. Call gnutls_alert_send_appropriate
673 on error. Return error code.
674 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
675 (emacs_gnutls_read): Likewise.
676 (Fgnutls_boot): Return handshake error code.
677 (emacs_gnutls_handle_error): New function.
678 (wsaerror_to_errno): Likewise.
679
680 * w32.h (emacs_gnutls_pull): Add prototype.
681 (emacs_gnutls_push): Likewise.
682
683 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
684 (emacs_gnutls_push): Likewise.
685
6862011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
687
688 * process.c (wait_reading_process_output): Check if GnuTLS
689 buffered some data internally if no FDs are set for TLS
690 connections.
691
692 * makefile.w32-in (OBJ2): Add gnutls.$(O).
693 (LIBS): Link to USER_LIBS.
694 ($(BLD)/gnutls.$(0)): New target.
695
fa6996bc
EZ
6962011-04-24 Eli Zaretskii <eliz@gnu.org>
697
eb35682e
EZ
698 * xdisp.c (handle_single_display_spec): Rename the
699 display_replaced_before_p argument into display_replaced_p, to
700 make it consistent with the commentary. Fix typos in the
701 commentary.
702
e2ad650c
EZ
703 * textprop.c (syms_of_textprop): Remove dead code.
704 (copy_text_properties): Delete obsolete commentary about an
705 interface that was deleted long ago. Fix typos in the description
706 of arguments.
707
1b2de274
EZ
708 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
709 to changes in oldXMenu/XMenu.h from 2011-04-16.
710 <menu_help_message, prev_menu_help_message>: Constify.
711 (IT_menu_make_room): menu->help_text is now `const char **';
712 adjust.
713
714 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
715 to changes in oldXMenu/XMenu.h from 2011-04-16.
716 (struct XMenu): Declare `help_text' `const char **'.
717
718 * xfaces.c <Qunspecified>: Make extern again.
719
720 * syntax.c: Include sys/types.h before including regex.h, as
721 required by Posix.
722
762b15be
EZ
723 * doc.c (get_doc_string): Improve the format passed to `error'.
724
725 * doprnt.c (doprnt): Improve commentary.
726
727 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
728
729 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
730 them with etags.
731
f1052e5d
EZ
732 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
733 changes in globals.h immediately force recompilation.
762b15be
EZ
734 (TAGS): Depend on $(CURDIR)/m/intel386.h and
735 $(CURDIR)/s/ms-w32.h.
736 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 737
fa6996bc
EZ
738 * character.c (Fchar_direction): Function deleted.
739 (syms_of_character): Don't defsubr it.
740 <char-direction-table>: Deleted.
741
e6c3da20
EZ
7422011-04-23 Eli Zaretskii <eliz@gnu.org>
743
744 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
745 * doprnt.c: Include limits.h.
746 (SIZE_MAX): New macro.
747 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
748 local variables are now size_t instead of int or unsigned.
749 Improve overflow protection. Support `l' modifier for integer
750 conversions. Support %l conversion. Don't assume an EMACS_INT
751 argument for integer conversions and for %c.
752
753 * lisp.h (doprnt): Restore prototype.
754
755 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
756 $(SRC)/character.h.
757
758 * Makefile.in (base_obj): Add back doprnt.o.
759
760 * deps.mk (doprnt.o): Add back prerequisites.
761 (callint.o): Depend on character.h.
762
763 * eval.c (internal_lisp_condition_case): Include the handler
764 representation in the error message.
765 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
766 when breaking from the loop.
767
768 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
769
770 * callint.c (Fcall_interactively): When displaying error message
771 about invalid control letter, pass the character's codepoint, not
772 a pointer to its multibyte form. Improve display of the character
773 in octal and display also its hex code.
774
775 * character.c (char_string): Use %x to display the (unsigned)
776 codepoint of an invalid character, to avoid displaying a bogus
777 negative value.
778
779 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
780 `error', not SYMBOL_NAME itself.
781
782 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
783 character arguments to `error'.
784
785 * charset.c (check_iso_charset_parameter): Fix incorrect argument
786 to `error' in error message about FINAL_CHAR argument. Make sure
787 FINAL_CHAR is a character, and use %c when it is passed as
788 argument to `error'.
789
4ffd0d6b 7902011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
791
792 * s/ms-w32.h (localtime): Redirect to sys_localtime.
793
794 * w32.c: Include <time.h>.
795 (sys_localtime): New function.
796
4ffd0d6b 7972011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
798
799 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
800
4ffd0d6b 801 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 802
4ffd0d6b 8032011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 804
4ffd0d6b
GM
805 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
806 zombies (Bug#8467).
aac0c6e3 807
04c56954
EZ
8082011-04-19 Eli Zaretskii <eliz@gnu.org>
809
810 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
811 gl_state.e_property when gl_state.object is Qt.
812
813 * insdel.c (make_gap_larger): Remove limitation of buffer size
814 to <= INT_MAX.
815
16a43933
CY
8162011-04-18 Chong Yidong <cyd@stupidchicken.com>
817
818 * xdisp.c (lookup_glyphless_char_display)
819 (produce_glyphless_glyph): Handle cons cell entry in
820 glyphless-char-display.
821 (Vglyphless_char_display): Document it.
822
823 * term.c (produce_glyphless_glyph): Handle cons cell entry in
824 glyphless-char-display.
825
4581706e
CY
8262011-04-17 Chong Yidong <cyd@stupidchicken.com>
827
828 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
829
830 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
831
832 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
833 definition for no-X builds.
834
4887c6e2 8352011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 836
fd35b6f9
PE
837 Static checks with GCC 4.6.0 and non-default toolkits.
838
5c1ccb01
PE
839 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
840
006c5daa
PE
841 * process.c (keyboard_bit_set): Define only if SIGIO.
842 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
843 (send_process): Repair possible setjmp clobbering.
844
efc736d3
PE
845 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
846
4e2fe2e6
PE
847 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
848
f97334a2
PE
849 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
850
4e75f29d
PE
851 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
852 Define only if needed.
853
90efadd1
PE
854 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
855 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 856 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 857
3c647824
PE
858 * dispextern.h (struct redisplay_interface): Rename param
859 to avoid shadowing.
e264f262 860 * termhooks.h (struct terminal): Likewise.
761383f4 861 * xterm.c (xembed_send_message): Likewise.
3c647824 862
b58c5c4a
PE
863 * insdel.c (make_gap_smaller): Define only if
864 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
865
cad59032
PE
866 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
867 it.
868
c339dc2e
PE
869 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
870 so that we aren't warned about unused symbols.
871
91a3e27b
PE
872 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
873
399c71d3 874 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 875
8ffc96f5
PE
876 * xfns.c (x_real_positions): Mark locals as initialized.
877
eef9bc79
PE
878 * xmenu.c (xmenu_show): Don't use uninitialized vars.
879
098db9dd
PE
880 * xterm.c: Fix problems found by static analysis with other toolkits.
881 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
882 (x_dispatch_event): Declare static if USE_GTK, and
883 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 884 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 885 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
886 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
887 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 888
eb18f6cc
PE
889 * xmenu.c (menu_help_callback): Pointer type fixes.
890 Use const pointers when pointing at readonly data. Avoid pointer
891 signedness clashes.
892 (FALSE): Remove unused macro.
893 (update_frame_menubar): Remove unused decl.
894
1fe72bf8
PE
895 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
896
60d9e1db
PE
897 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
898 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
899 (single_menu_item): Rename local to avoid shadowing.
900
39261c26
PE
901 * keyboard.c (make_lispy_event): Remove unused local var.
902
018c5e19
PE
903 * frame.c, frame.h (x_get_resource_string): Bring this back, but
904 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
905
63d2b86e
PE
906 * bitmaps: Change bitmaps from unsigned char back to the X11
907 compatible char. Avoid the old compiler warnings about
908 out-of-range initializers by using, for example, '\xab' rather
909 than 0xab.
910
aefd87e1
PE
911 * xgselect.c (xgselect_initialize): Check vs interface
912 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
913
bf501fb9
PE
914 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
915
e9829fdf
PE
916 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
917 to read-only memory.
918
1086c095
PE
919 * fns.c (vector): Remove; this old hack is no longer needed.
920
2baccd04 921 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 922 Remove unused var.
dde42981 923 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 924
72391843 925 * xrdb.c (x_load_resources): Omit unused local.
3565b346 926
436c16df 927 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 928 (x_window): Rename locals to avoid shadowing.
dc5ddd85 929 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 930
92bb796d 931 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 932 (x_term_init): Remove local to avoid shadowing.
92bb796d 933
764430a3 934 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
935
936 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
937 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
938
d1dfb56c
EZ
9392011-04-16 Eli Zaretskii <eliz@gnu.org>
940
c4354cb4
EZ
941 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
942
d1dfb56c
EZ
943 Fix regex.c, syntax.c and friends for buffers > 2GB.
944 * syntax.h (struct gl_state_s): Declare character position members
945 EMACS_INT.
946
947 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
948
949 * textprop.c (verify_interval_modification, interval_of): Declare
950 arguments EMACS_INT.
951
952 * intervals.c (adjust_intervals_for_insertion): Declare arguments
953 EMACS_INT.
954
955 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
956
957 * indent.c (Fvertical_motion): Local variable it_start is now
958 EMACS_INT.
959
960 * regex.c (re_match, re_match_2, re_match_2_internal)
961 (bcmp_translate, regcomp, regexec, print_double_string)
962 (group_in_compile_stack, re_search, re_search_2, regex_compile)
963 (re_compile_pattern, re_exec): Declare arguments and local
964 variables `size_t' and `ssize_t' and return values `regoff_t', as
965 appropriate.
966 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
967 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
968 <compile_stack_type>: `size' and `avail' are now `size_t'.
969
970 * regex.h <regoff_t>: Use ssize_t, not int.
971 (re_search, re_search_2, re_match, re_match_2): Arguments that
972 specify buffer/string position and length are now ssize_t and
973 size_t. Return type is regoff_t.
974
613052cd
BK
9752011-04-16 Ben Key <bkey76@gmail.com>
976
977 * nsfont.m: Fixed bugs in ns_get_family and
978 ns_descriptor_to_entity that were caused by using free to
979 deallocate memory blocks that were allocated by xmalloc (via
980 xstrdup). This caused Emacs to crash when compiled with
981 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
982 --enable-checking=xmallocoverrun). xfree is now used to
983 deallocate these memory blocks.
984
4170f62f 9852011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 986
71b41406
PE
987 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
988
9587a89d
PE
989 emacs_write: Accept and return EMACS_INT for sizes.
990 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
991 et seq.
992 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
993 Accept and return EMACS_INT.
994 (emacs_gnutls_write): Return the number of bytes written on
995 partial writes.
996 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
997 (emacs_read, emacs_write): Remove check for negative size, as the
998 Emacs source code has been audited now.
9587a89d
PE
999 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1000 (emacs_read, emacs_write): Use it.
273a5f82
PE
1001 * process.c (send_process): Adjust to the new signatures of
1002 emacs_write and emacs_gnutls_write. Do not attempt to store
1003 a byte offset into an 'int'; it might overflow.
9587a89d 1004 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1005
3e047f51
PE
1006 * sound.c: Don't assume sizes fit in 'int'.
1007 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1008 Return EMACS_INT, not int.
3e047f51 1009 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1010 Accept EMACS_INT, not int.
1011 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1012 record read return values.
1013
cc39a9db
BK
10142011-04-15 Ben Key <bkey76@gmail.com>
1015
c9d0ec6d
JB
1016 * keyboard.c (Qundefined): Don't declare static since it is used
1017 in nsfns.m.
1018 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1019 static since they are used in nsfont.m.
cc39a9db 1020
6c60eb9f
SM
10212011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1022
1023 * process.c (Qprocessp): Don't declare static.
1024 * lisp.h (Qprocessp): Declare again.
1025
7990b61a
JB
10262011-04-15 Juanma Barranquero <lekktu@gmail.com>
1027
1028 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1029
5d4cb038
PE
10302011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1031
8bd7b830 1032 Improve C-level modularity by making more things 'static'.
cd64ea1d 1033
e3b27b31
PE
1034 Don't publish debugger-only interfaces to other modules.
1035 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1036 (verify_bytepos, count_markers): Move decls to the only modules
1037 that need them.
1038 * region-cache.h (pp_cache): Likewise.
1039 * window.h (check_all_windows): Likewise.
1040 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1041
5d4cb038
PE
1042 * sysdep.c (croak): Now static, if
1043 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1044 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1045
1046 * alloc.c (refill_memory_reserve): Now static if
1047 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1048 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1049
e87b6180
PE
1050 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1051 Define only if USE_LUCID.
1052
ac64929e
PE
1053 * xrdb.c (x_customization_string, x_rm_string): Now static.
1054
6f37259d
PE
1055 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1056 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1057
1683e3ab
PE
1058 * xdisp.c (draw_row_with_mouse_face): Now static.
1059 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1060
de9c2632
PE
1061 * window.h (check_all_windows): Mark externally visible.
1062
2b96acb7
PE
1063 * window.c (window_deletion_count): Now static.
1064
1065 * undo.c: Make symbols static if they're not exported.
1066 (last_undo_buffer, last_boundary_position, pending_boundary):
1067 Now static.
1068
50436f33
PE
1069 * textprop.c (interval_insert_behind_hooks): Now static.
1070 (interval_insert_in_front_hooks): Likewise.
1071
64520e5c
PE
1072 * term.c: Make symbols static if they're not exported.
1073 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1074 (max_frame_lines, tty_set_terminal_modes):
1075 (tty_reset_terminal_modes, tty_turn_off_highlight):
1076 (get_tty_terminal): Now static.
1077 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1078 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1079 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1080 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1081 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1082
1fa53021
PE
1083 * sysdep.c: Make symbols static if they're not exported.
1084 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1085 Now static.
1086 (sigprocmask_set, full_mask): Remove; unused.
1087 (wait_debugging): Mark as visible.
1088 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1089 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1090
d4b43b22
PE
1091 * syntax.c (syntax_temp): Define only if !__GNUC__.
1092
b7c513d0
PE
1093 * sound.c (current_sound_device, current_sound): Now static.
1094
989b29ad
PE
1095 * search.c (searchbufs, searchbuf_head): Now static.
1096
13a55a78
PE
1097 * scroll.c (scroll_cost): Remove; unused.
1098 * dispextern.h (scroll_cost): Remove decl.
1099
de68a1fc
PE
1100 * region-cache.h (pp_cache): Mark as externally visible.
1101
40ccffa6
PE
1102 * process.c: Make symbols static if they're not exported.
1103 (process_tick, update_tick, create_process, chan_process):
1104 (Vprocess_alist, proc_buffered_char, datagram_access):
1105 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1106 (deactivate_process): Mark defn as static, as well as decl.
1107 * lisp.h (create_process): Remove decl.
1108 * process.h (chan_process, Vprocess_alist): Remove decls.
1109
ad64fc97
PE
1110 * print.c: Make symbols static if they're not exported.
1111 (print_depth, new_backquote_output, being_printed, print_buffer):
1112 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1113 (print_interval, print_number_index, initial_stderr_stream):
1114 Now static.
1115 * lisp.h (Fprinc): Remove decl.
1116 (debug_output_compilation_hack): Mark as externally visible.
1117
adddb265
PE
1118 * sysdep.c (croak): Move decl from here to syssignal.h.
1119 * syssignal.h (croak): Put it here, so the API can be checked when
1120 'croak' is called from dissociate_if_controlling_tty.
1121
1717ede2
PE
1122 * minibuf.c: Make symbols static if they're not exported.
1123 (minibuf_save_list, choose_minibuf_frame): Now static.
1124 * lisp.h (choose_minibuf_frame): Remove decl.
1125
fa5fb2bc
PE
1126 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1127
1e3890d1
PE
1128 * lread.c: Make symbols static if they're not exported.
1129 (read_objects, initial_obarray, oblookup_last_bucket_number):
1130 Now static.
1131 (make_symbol): Remove; unused.
1132 * lisp.h (initial_obarray, make_symbol): Remove decls.
1133
8a1414fa
PE
1134 * keyboard.c: Make symbols static if they're not exported.
1135 (single_kboard, recent_keys_index, total_keys, recent_keys):
1136 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1137 (this_single_command_key_start, echoing, last_auto_save):
1138 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1139 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1140 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1141 (Vlispy_mouse_stem, double_click_count):
1142 Now static.
1143 (force_auto_save_soon): Define only if SIGDANGER.
1144 (ignore_mouse_drag_p): Now static if
1145 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1146 (print_help): Remove; unused.
1147 (stop_character, last_timer_event): Mark as externally visible.
1148 * keyboard.h (ignore_mouse_drag_p): Declare only if
1149 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1150 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1151 * lisp.h (echoing): Remove decl.
1152 (force_auto_save_soon): Declare only if SIGDANGER.
1153 * xdisp.c (redisplay_window): Simplify code, to make it more
1154 obvious that ignore_mouse_drag_p is not accessed if !defined
1155 USE_GTK && !defined HAVE_NS.
1156
93ea6e8f
PE
1157 * intervals.c: Make symbols static if they're not exported.
1158 (merge_properties_sticky, merge_interval_right, delete_interval):
1159 Now static.
1160 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1161
77382fcc
PE
1162 * insdel.c: Make symbols static if they're not exported.
1163 However, leave prepare_to_modify_buffer alone. It's never
1164 called from outside this function, but that appears to be a bug.
1165 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1166 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1167 (adjust_after_replace_noundo): Remove; unused.
1168 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1169 (signal_before_change): Remove decls.
77382fcc 1170
9306c32e
PE
1171 * indent.c (val_compute_motion, val_vmotion): Now static.
1172
cd44d2eb
PE
1173 * image.c: Make symbols static if they're not exported.
1174 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1175 if USE_GTK.
1176 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1177 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1178
ad9a7a06
PE
1179 * fringe.c (standard_bitmaps): Now static.
1180 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1181
81626931
PE
1182 * frame.c: Make symbols static if they're not exported.
1183 (x_report_frame_params, make_terminal_frame): Now static.
1184 (get_frame_param): Now static, unless HAVE_NS.
1185 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1186 (x_get_resource_string): Remove; not used.
1187 * frame.h (make_terminal_frame, x_report_frame_params):
1188 (x_get_resource_string); Remove decls.
1189 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1190 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1191
239f9db9
PE
1192 * font.c, fontset.c: Make symbols static if they're not exported.
1193 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1194 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1195 * font.c (font_close_object): Now static.
1196 * font.h (font_close_object): Remove.
1197 * fontset.c (FONTSET_OBJLIST): Remove.
1198 (free_realized_fontset) #if-0 the body, which does nothing.
1199 (face_suitable_for_char_p): #if-0, as it's never called.
1200 * fontset.h (face_suitable_for_char_p): Remove decl.
1201 * xfaces.c (face_at_string_position): Use
1202 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1203 since 0 is always ASCII.
1204
dfcf3579
PE
1205 * fns.c (weak_hash_tables): Now static.
1206
5045092b
PE
1207 * fileio.c: Make symbols static if they're not exported.
1208 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1209 (Vwrite_region_annotation_buffers): Now static.
1210
57a96f5c
PE
1211 * eval.c: Make symbols static if they're not exported.
1212 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1213 * lisp.h (backtrace_list): Remove decl.
1214
35f08c38
PE
1215 * emacs.c: Make symbols static if they're not exported.
1216 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1217 (fatal_error_code, fatal_error_signal_hook, standard_args):
1218 Now static.
1219 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1220 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1221 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1222 * lisp.h (fatal_error_signal_hook): Remove decl.
1223 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1224
f44bd759
PE
1225 * editfns.c: Move a (normally-unused) function to its only use.
1226 * editfns.c, lisp.h (get_operating_system_release): Remove.
1227 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1228 worth the hassle of breaking this out.
1229
b532497d
PE
1230 * xterm.c: Make symbols static if they're not exported.
1231 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1232 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1233 (x_destroy_window, x_delete_display):
1234 Now static.
1235 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1236 (x_mouse_leave): Remove; unused.
1237 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1238 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1239 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1240 Remove decls.
1241 (x_mouse_leave): Declare only if WINDOWSNT.
1242 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1243 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1244 USE_X_TOOLKIT.
1245
1675728f
PE
1246 * ftxfont.c: Make symbols static if they're not exported.
1247 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1248 HAVE_FREETYPE.
1249 * font.h (ftxfont_driver): Likewise.
1250
e4cebfca
PE
1251 * xfns.c: Make symbols static if they're not exported.
1252 (x_last_font_name, x_display_info_for_name):
1253 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1254 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1255 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1256 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1257 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1258 (last_show_tip_args): Now static.
1259 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1260 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1261 (x_screen_planes): Remove; unused.
1262 * dispextern.h (x_screen_planes): Remove decl.
1263
5bf46f05
PE
1264 * dispnew.c: Make symbols static if they're not exported.
1265 * dispextern.h (redraw_garbaged_frames, scrolling):
1266 (increment_row_positions): Remove.
1267 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1268 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1269 Now static.
1270 (redraw_garbaged_frames): Remove; unused.
1271
435f4c28
PE
1272 * xfaces.c: Make symbols static if they're not exported.
1273 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1274 Remove decls.
1275 * xterm.h (defined_color): Remove decls.
1276 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1277 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1278 (menu_face_changed_default, defined_color, free_realized_face):
1279 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1280 (ascii_face_of_lisp_face): Remove; unused.
1281
8524aef3
PE
1282 * xdisp.c: Make symbols static if they're not exported.
1283 * dispextern.h (scratch_glyph_row, window_box_edges):
1284 (glyph_to_pixel_coords, set_cursor_from_row):
1285 (get_next_display_element, set_iterator_to_next):
1286 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1287 (show_mouse_face): Remove decls
1288 * frame.h (message_buf_print): Likewise.
1289 * lisp.h (pop_message, set_message, check_point_in_composition):
1290 Likewise.
1291 * xterm.h (set_vertical_scroll_bar): Likewise.
1292 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1293 (message_buf_print, scratch_glyph_row, displayed_buffer):
1294 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1295 (get_next_display_element, show_mouse_face, window_box_edges):
1296 (frame_to_window_pixel_xy, check_point_in_composition):
1297 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1298 (glyph_to_pixel_coords): Remove; unused.
1299
16390cd2
PE
1300 * dired.c (file_name_completion): Now static.
1301
1302 * dbusbind.c (xd_in_read_queued_messages): Now static.
1303
a25f4dfa
PE
1304 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1305 * data.c (circular_list_error): Remove.
1306
14a9c8df
PE
1307 * commands.h (last_point_position, last_point_position_buffer):
1308 (last_point_position_window): Remove decls.
1309 * keyboard.c: Make these variables static.
1310
74ab6df5
PE
1311 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1312 decls.
1313 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1314 (iso_code_class, detect_coding, code_convert_region): Now static.
1315 (encode_coding_gap): Remove; unused.
1316
38dfbee1
PE
1317 * chartab.c (chartab_chars, chartab_bits): Now static.
1318
a2cb4e63
PE
1319 * charset.h (charset_iso_8859_1): Remove decl.
1320 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1321 Now static.
1322
127198fd
PE
1323 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1324 * ccl.c (Vccl_program_table): Now static.
1325 (check_ccl_update): Remove; unused.
1326
d85b608f
PE
1327 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1328 * category.h: ... from here.
1329 * category.c (check_category_table, set_category_set): Now static.
1330
31cd66f3
PE
1331 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1332 * lisp.h: Remove these decls.
1333
c358e587
PE
1334 * buffer.c (buffer_count): Remove unused var.
1335
e78aecca
PE
1336 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1337 so that it's not optimized away.
1338 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1339 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1340 exported only to the debugger.
1341
e192d7d3
PE
1342 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1343 * atimer.h (run_all_atimers): Removed; not exported.
1344
92470028
PE
1345 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1346 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1347 was inaccessible from Lisp.
1348 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1349 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1350
244ed907
PE
1351 alloc.c: Import and export fewer symbols, and remove unused items.
1352 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1353 is defined.
1354 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1355 it's not optimized away by whole-program optimization.
1356 (message_enable_multibyte, free_misc): Remove.
1357 (catchlist, handlerlist, mark_backtrace):
1358 Declare only if BYTE_MARK_STACK.
1359 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1360 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1361 (message_enable_multibyte): Remove decl.
1362 (free_misc, interval_free_list, float_block, float_block_index):
1363 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1364 (cons_free_list, last_marked_index):
1365 Now static.
1366 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1367 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1368 (mark_backtrace): Define only if BYTE_MARK_STACK.
1369 * xdisp.c (message_enable_multibyte): Now static.
1370
61c2b50e 1371 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1372 This makes it easier for human readers (and static analyzers)
1373 to see whether these variables are used from other modules.
1374 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1375 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1376 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1377 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1378 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1379 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1380 * xmenu.c, xselect.c:
1381 Declare Q* vars static if they are not used in other modules.
1382 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1383 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1384 Remove decls of unexported vars.
1385 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1386
95c82688
PE
1387 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1388
16a97296
PE
1389 Make Emacs functions such as Fatom 'static' by default.
1390 This makes it easier for human readers (and static analyzers)
1391 to see whether these functions can be called from other modules.
1392 DEFUN now defines a static function. To make the function external
1393 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1394 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1395 (Finit_image_library):
16a97296
PE
1396 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1397 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1398 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1399 Remove decls, since these functions are now static.
1400 (Funintern, Fget_internal_run_time): New decls, since these functions
1401 were already external.
95c82688 1402
16a97296
PE
1403 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1404 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1405 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1406 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1407 * keyboard.c, keymap.c, lread.c:
1408 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1409 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1410 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1411 Mark functions with DEFUE instead of DEFUN,
1412 if they are used in other modules.
1413 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1414 decls for now-static functions.
1415 * buffer.h (Fdelete_overlay): Remove decl.
1416 * callproc.c (Fgetenv_internal): Mark as internal.
1417 * composite.c (Fremove_list_of_text_properties): Remove decl.
1418 (Fcomposition_get_gstring): New forward static decl.
1419 * composite.h (Fcomposite_get_gstring): Remove decl.
1420 * dired.c (Ffile_attributes): New forward static decl.
1421 * doc.c (Fdocumntation_property): New forward static decl.
1422 * eval.c (Ffetch_bytecode): New forward static decl.
1423 (Funintern): Remove extern decl; now in .h file where it belongs.
1424 * fileio.c (Fmake_symbolic_link): New forward static decl.
1425 * image.c (Finit_image_library): New forward static decl.
1426 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1427 * intervals.h (Fprevious_property_change):
1428 (Fremove_list_of_text_properties): Remove decls.
1429 * keyboard.c (Fthis_command_keys): Remove decl.
1430 (Fcommand_execute): New forward static decl.
1431 * keymap.c (Flookup_key): New forward static decl.
1432 (Fcopy_keymap): Now static.
1433 * keymap.h (Flookup_key): Remove decl.
1434 * process.c (Fget_process): New forward static decl.
1435 (Fprocess_datagram_address): Mark as internal.
1436 * syntax.c (Fsyntax_table_p): New forward static decl.
1437 (skip_chars): Remove duplicate decl.
1438 * textprop.c (Fprevious_property_change): New forward static decl.
1439 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1440 Now internal.
1441 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1442 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1443
785bbd42
PE
1444 * editfns.c (Fformat): Remove unreachable code.
1445
8b913b57
AS
14462011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1447
1448 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1449 change. (Bug#8496)
1450
a6744a35
EZ
14512011-04-13 Eli Zaretskii <eliz@gnu.org>
1452
1453 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1454 when at ZV. (Bug#8487)
1455
e7974947
AS
14562011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1457
baad03f0
AS
1458 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1459 (Bug#8437)
1460 * keyboard.c (parse_tool_bar_item): Likewise.
1461 * sound.c (sound_cleanup, alsa_close): Likewise.
1462 * termcap.c (tgetent): Likewise.
1463 * xfns.c (x_default_font_parameter): Likewise.
1464 * xsettings.c (read_and_apply_settings): Likewise.
1465
e7974947
AS
1466 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1467 (overrun_check_free): Protoize.
1468
28272684
PE
14692011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1470
1471 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1472 since callers should never pass a negative size.
1473 Change the signature to match that of plain 'read' and 'write'; see
1474 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1475 * lisp.h: Update prototypes of emacs_write and emacs_read.
1476
11997c76
EZ
14772011-04-11 Eli Zaretskii <eliz@gnu.org>
1478
1479 * xdisp.c (redisplay_window): Don't try to determine the character
1480 position of the scroll margin if the window start point w->startp
e896f03c 1481 is outside the buffer's accessible region. (Bug#8468)
11997c76 1482
8a2cbd72
EZ
14832011-04-10 Eli Zaretskii <eliz@gnu.org>
1484
1485 Fix write-region and its subroutines for buffers > 2GB.
1486 * fileio.c (a_write, e_write): Modify declaration of arguments and
1487 local variables to support buffers larger than 2GB.
1488 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1489
1490 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1491 argument, local variables, and return value.
1492
1493 * lisp.h: Update prototypes of emacs_write and emacs_read.
1494
1495 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1496
4073e537 14972011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1498
1ebfdcb6
PE
1499 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1500
b2ded58d
PE
1501 Fix more problems found by GCC 4.6.0's static checks.
1502
7d66342c
PE
1503 * xdisp.c (vmessage): Use a better test for character truncation.
1504
bbf47d44
PE
1505 * charset.c (load_charset_map): <, not <=, for optimization,
1506 and to avoid potential problems with integer overflow.
9248994d 1507 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1508 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1509 * editfns.c (Fformat): Likewise.
1e69125e 1510 * syntax.c (skip_chars): Likewise.
3befa583 1511
e3019616
PE
1512 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1513 This also lets GCC 4.6.0 generate slightly better loop code.
1514
becfa255
PE
1515 * callint.c (Fcall_interactively): <, not <=, for optimization.
1516 (Fcall_interactively): Count the number of arguments produced,
1517 not the number of arguments given. This is simpler and lets GCC
1518 4.6.0 generate slightly better code.
1519
dae0cd48
PE
1520 * ftfont.c: Distingish more carefully between FcChar8 and char.
1521 The previous code passed unsigned char * to a functions like
1522 strlen and xstrcasecmp that expect char *, which does not
1523 conform to the C standard.
1524 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1525 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1526 char * when the C standard requires it.
1527
76032d70
PE
1528 * keyboard.c (read_char): Remove unused var.
1529
eb3f1cc8
PE
1530 * eval.c: Port to Windows vsnprintf (Bug#8435).
1531 Include <limits.h>.
1532 (SIZE_MAX): Define if the headers do not.
1533 (verror): Do not give up if vsnprintf returns a negative count.
1534 Instead, grow the buffer. This ports to Windows vsnprintf, which
1535 does not conform to C99. Problem reported by Eli Zaretskii.
1536 Also, simplify the allocation scheme, by avoiding the need for
1537 calling realloc, and removing the ALLOCATED variable.
1538
70476b54
PE
1539 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1540
12020a9e
PE
1541 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1542 But keep the doprint source code for now, as we might revamp it
1543 and use it again (Bug#8435).
ea6c7ae6
PE
1544 * lisp.h (doprnt): Remove.
1545 * Makefile.in (base_obj): Remove doprnt.o.
1546 * deps.mk (doprnt.o): Remove.
1547
5fdb398c
PE
1548 error: Print 32- and 64-bit integers portably (Bug#8435).
1549 Without this change, on typical 64-bit hosts error ("...%d...", N)
1550 was used to print both 32- and 64-bit integers N, which relied on
1551 undefined behavior.
1552 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1553 New macro.
1554 * lisp.h (error, verror): Mark as printf-like functions.
1555 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1556 Report overflow in size calculations when allocating printf buffer.
1557 Do not truncate output string at its first null byte.
1558 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1559 Truncate the output at a character boundary, since vsnprintf does not
1560 do that.
1561 * charset.c (check_iso_charset_parameter): Convert internal
1562 character to string before calling 'error', since %c now has the
1563 printf meaning.
1564 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1565 overflow when computing char to be passed to 'error'. Do not
1566 pass Lisp_Object to 'error'; pass the integer instead.
1567 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1568 formatted with plain %d.
1569
b189fa66
PE
1570 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1571
bff87ef0
PE
1572 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1573
7e2cac20
PE
1574 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1575
ce4d90b5
PE
1576 * xterm.c (x_catch_errors): Remove duplicate declaration.
1577
266c9547
PE
1578 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1579
79c49ad2
PE
1580 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1581
368f4090
JM
15822011-04-10 Jim Meyering <meyering@redhat.com>
1583
1584 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1585 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1586 return ssize_t not "int", and use size_t as the buffer length.
1587 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1588 * gnutls.h: Update declarations.
1589 * process.c (read_process_output): Use ssize_t, to match.
1590 (send_process): Likewise.
1591
a32d4040
CY
15922011-04-09 Chong Yidong <cyd@stupidchicken.com>
1593
1594 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1595
8546720e 15962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1597
8546720e
GM
1598 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1599 unsigned char, to match FcChar8 type definition.
aac0c6e3 1600
8546720e
GM
1601 * xterm.c (handle_one_xevent):
1602 * xmenu.c (create_and_show_popup_menu):
1603 * xselect.c (x_decline_selection_request)
1604 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1605
0a2f5c1a 16062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1607
1608 Fix some uses of `int' instead of EMACS_INT.
1609 * search.c (string_match_1, fast_string_match)
1610 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1611 (scan_buffer, find_next_newline_no_quit)
1612 (find_before_next_newline, search_command, Freplace_match)
1613 (Fmatch_data): Make some `int' variables be EMACS_INT.
1614
1615 * xdisp.c (display_count_lines): 3rd argument and return value now
1616 EMACS_INT. All callers changed.
1617 (pint2hrstr): Last argument is now EMACS_INT.
1618
1619 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1620 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1621 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1622 (decode_coding_utf_16, decode_coding_emacs_mule)
1623 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1624 (decode_coding_ccl, decode_coding_charset)
1625 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1626 (decode_coding_iso_2022, decode_coding_emacs_mule)
1627 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1628 <char_offset, last_offset>: Declare EMACS_INT.
1629 (encode_coding_utf_8, encode_coding_utf_16)
1630 (encode_coding_emacs_mule, encode_invocation_designation)
1631 (encode_designation_at_bol, encode_coding_iso_2022)
1632 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1633 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1634 Declare EMACS_INT.
1635 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1636 (encode_invocation_designation): Last argument P_NCHARS is now
1637 EMACS_INT.
1638 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1639 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1640
1641 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1642 All users changed.
1643
1644 * ccl.c (Fccl_execute_on_string): Declare some variables
1645 EMACS_INT.
1646
8546720e 16472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1648
1649 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1650
4e19a977
CS
16512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1652
1653 * process.c (Fformat_network_address): Doc fix.
1654
87302331
R
16552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1656
1657 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1658
cbb59342
CY
16592011-04-08 Chong Yidong <cyd@stupidchicken.com>
1660
1661 * keyboard.c (read_char): Call Lisp function help-form-show,
1662 instead of using internal_with_output_to_temp_buffer.
1663 (Qhelp_form_show): New var.
e0d38eeb 1664 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1665
1666 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1667
1668 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1669
e67a13ab
CY
16702011-04-06 Chong Yidong <cyd@stupidchicken.com>
1671
1672 * process.c (Flist_processes): Removed to Lisp.
1673 (list_processes_1): Deleted.
1674
973f782d
EZ
16752011-04-06 Eli Zaretskii <eliz@gnu.org>
1676
7c106b1e
EZ
1677 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1678
973f782d
EZ
1679 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1680
41cf7d1a 16812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1682
ca23cc88
PE
1683 Fix more problems found by GCC 4.6.0's static checks.
1684
f390e2d5
PE
1685 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1686
42eea0d0
PE
1687 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1688
b69769da 1689 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1690
f9541e84
PE
1691 * xdisp.c (vmessage): Mark as a printf-like function.
1692
13841b55
PE
1693 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1694
c136c10f
PE
1695 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1696
5e2d4a30
PE
1697 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1698 printf-like functions.
1699 (tiff_load): Add casts to remove these marks before passing them
1700 to system-supplied API.
1701
583f48b9
PE
1702 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1703
b25d760e
PE
1704 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1705 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1706 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1707 directly, rather than having caller test rule sign. This avoids
1708 some unnecessary tests.
1709 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1710 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1711 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1712
bc7b6697 1713 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1714 (xfont_open): Avoid unnecessary tests.
bc7b6697 1715
27ccc379
PE
1716 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1717
dcd5c89a
PE
1718 * composite.h, composite.c (composition_gstring_put_cache):
1719 Use EMACS_INT, not int, for length.
1720
b13a45c6
PE
1721 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1722 breaking out part of COMPOSITION_DECODE_RULE.
1723 (COMPOSITION_DECODE_RULE): Use it.
1724 * composite.c (get_composition_id): Remove unused local vars,
1725 by using the new macro.
1726
1e792e4d
PE
1727 * textprop.c (set_text_properties_1): Change while to do-while,
1728 since the condition is always true at first.
1729
dc6c6455 1730 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1731 (interval_deletion_adjustment): Return unsigned value.
1732 All uses changed.
dc6c6455 1733
aba7731a
PE
1734 * process.c (list_processes_1, create_pty, read_process_output):
1735 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1736 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1737 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1738 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1739 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1740
fdfc4bf3
PE
1741 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1742
fca8fe46 1743 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1744 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1745
06a0259a 1746 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1747 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1748 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1749
e7b9e80f
PE
1750 * print.c (print_error_message): Avoid int overflow.
1751
56201685
PE
1752 * font.c (font_list_entities): Redo for clarity,
1753 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1754
78834453 1755 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1756 (font_score): Avoid potential overflow in diff calculation.
78834453 1757
0bc0b309 1758 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1759 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1760
e610eaca
PE
1761 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1762
b895abce
PE
1763 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1764 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1765 can always succeed if overflow has undefined behavior.
1766
1f1d9321 1767 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1768 (wordify): Omit three unnecessary tests.
1f1d9321 1769
c59478bc
PE
1770 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1771 All callers changed. This avoids the need for an unused var.
1772
79b73827
PE
1773 * casefiddle.c (casify_region): Remove var that is set but not used.
1774
a4db5dfe
PE
1775 * dired.c (file_name_completion): Remove var that is set but not used.
1776
43aae36e
PE
1777 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1778
2a47c44d 1779 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1780 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1781
a37c69bf
PE
1782 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1783 Check for integer overflow on size calculations.
1784
328ab8e7
PE
1785 * buffer.c (Fprevious_overlay_change): Remove var that is set
1786 but not used.
1787
e5a2a5cb
PE
1788 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1789 Remove vars that are set but not used.
8d84a6eb 1790 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1791 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1792
a60e5f68
PE
1793 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1794
f661cb61 1795 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1796 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1797
f0397f5a
PE
1798 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1799 that are set but not used.
1800
8664db06 1801 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1802 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1803
6abdaa4a
PE
1804 * xselect.c (x_get_local_selection, x_handle_property_notify):
1805 Remove vars that are set but not used.
1806
0ce7538d 1807 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1808 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1809
9ae848fc
PE
1810 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1811 Remove var that is set but not used.
0b918413
PE
1812 (scroll_bar_windows_size): Now size_t, not int.
1813 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1814 Check for overflow.
9ae848fc 1815
a5a62657
PE
1816 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1817 (map_tty_color) [!defined MSDOS]: Likewise.
1818
5c5cdd39
PE
1819 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1820
66ebf983
PE
1821 * coding.c: Remove vars that are set but not used.
1822 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1823 All callers changed.
1824 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1825 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1826 (decode_coding_charset): Remove vars that are set but not used.
1827
1be4d761
PE
1828 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1829 that is set but not used.
1830
47553fa8
PE
1831 * print.c (print_object): Remove var that is set but not used.
1832
1f7196bf 1833 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1834 The gnulib version avoids calling malloc in the usual case,
1835 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1836 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1837 * filelock.c (current_lock_owner): Likewise.
1838 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1839 * sysdep.c: Include allocator.h, careadlinkat.h.
1840 (emacs_no_realloc_allocator): New static constant.
1841 (emacs_readlink): New function.
fdb61804
PE
1842 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1843 ../lib/careadlinkat.h.
d1fdcab7 1844
f84c17c7
SM
18452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1846
1847 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1848 first non-nil return value).
1849
ef3862ad
JD
18502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1851
1852 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1853 if not defined (Bug#8403).
1854
376a7006
JB
18552011-04-02 Juanma Barranquero <lekktu@gmail.com>
1856
1857 * xdisp.c (display_count_lines): Remove parameter `start',
1858 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1859 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1860 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1861 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1862 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1863 and thereabouts. All callers changed.
1864 (get_per_char_metric): Remove parameter `f', unused since
1865 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1866
6ca3801d
JM
18672011-04-02 Jim Meyering <meyering@redhat.com>
1868
1869 do not dereference NULL upon failed strdup
1870 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1871 (ns_get_family): Likewise.
1872
d8e2b5ba
JB
18732011-04-02 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1876
8c74fcbd
JD
18772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1878
1879 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1880 later (Bug#8403).
1881
7200d79c
SM
18822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1883
03408648 1884 Add lexical binding.
7200d79c 1885
03408648
SM
1886 * window.c (Ftemp_output_buffer_show): New fun.
1887 (Fsave_window_excursion):
1888 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1889
1890 * lread.c (lisp_file_lexically_bound_p): New function.
1891 (Fload): Bind Qlexical_binding.
1892 (readevalloop): Remove `evalfun' arg.
1893 Bind Qinternal_interpreter_environment.
1894 (Feval_buffer): Bind Qlexical_binding.
1895 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1896 Mark as dynamic.
1897 (syms_of_lread): Declare `lexical-binding'.
1898
1899 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1900
1901 * keyboard.c (eval_dyn): New fun.
1902 (menu_item_eval_property): Use it.
ca105506
SM
1903
1904 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1905
03408648
SM
1906 * fns.c (concat, mapcar1): Accept byte-code-functions.
1907
1908 * eval.c (Fsetq): Handle lexical vars.
1909 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1910 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1911 (FletX, Flet): Obey lexical binding.
1912 (Fcommandp): Handle closures.
1913 (Feval): New `lexical' arg.
1914 (eval_sub): New function extracted from Feval. Use it almost
1915 everywhere where Feval was used. Look up vars in lexical env.
1916 Handle closures.
1917 (Ffunctionp): Move from subr.el.
1918 (Ffuncall): Handle closures.
1919 (apply_lambda): Remove `eval_flags'.
1920 (funcall_lambda): Handle closures and new byte-code-functions.
1921 (Fspecial_variable_p): New function.
1922 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1923 but without exporting it to Lisp.
23aba0ea 1924
23aba0ea 1925 * doc.c (Fdocumentation, store_function_docstring):
03408648 1926 * data.c (Finteractive_form): Handle closures.
23aba0ea 1927
03408648
SM
1928 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1929 interactive spec.
ba83908c 1930
03408648
SM
1931 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1932 byte-codes.
1933 (exec_byte_code): New function extracted from Fbyte_code to handle new
1934 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1935
03408648 1936 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1937
03408648 1938 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1939
e2abce01
JB
19402011-03-31 Juanma Barranquero <lekktu@gmail.com>
1941
1942 * xdisp.c (redisplay_internal): Fix prototype.
1943
63696a73 19442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1945
63696a73
EZ
1946 * xdisp.c (SCROLL_LIMIT): New macro.
1947 (try_scrolling): Use it when setting scroll_limit. Limit
1948 scrolling to 100 screen lines.
1949 (redisplay_window): Even when falling back on "recentering",
1950 position point in the window according to scroll-conservatively,
1951 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1952
1953 (try_scrolling): When point is above the window, allow searching
1954 as far as scroll_max, or one screenful, to compute vertical
1955 distance from PT to the scroll margin position. This prevents
1956 try_scrolling from unnecessarily failing when
1957 scroll-conservatively is set to a value slightly larger than the
1958 window height. Clean up the case of PT below the margin at bottom
1959 of window: scroll_max can no longer be INT_MAX. When aggressive
1960 scrolling is in use, don't let point enter the opposite scroll
1961 margin as result of the scroll.
1962 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1963 threshold of 100 lines for never-recentering scrolling.
1964
e4cc2dfc
JB
19652011-03-31 Juanma Barranquero <lekktu@gmail.com>
1966
1967 * dispextern.h (move_it_by_lines):
1968 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1969 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1970 (message_log_check_duplicate): Remove parameters `prev_bol' and
1971 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1972 (redisplay_internal): Remove parameter `preserve_echo_area',
1973 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1974
1975 * indent.c (Fvertical_motion):
1976 * window.c (window_scroll_pixel_based, Frecenter):
1977 Don't pass `need_y_p' to `move_it_by_lines'.
1978
1c470562
SM
19792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1980
44f230aa
SM
1981 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1982 steal a few bits to be more compact.
1983 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1984 Remove unneeded casts.
1985
1c470562
SM
1986 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1987
888adce9
ZK
19882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1989
1990 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1991 binding" message (bug#7967).
1992
f838ed7b
PE
19932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1994
77861b95
PE
1995 Fix more problems found by GCC 4.6.0's static checks.
1996
de6dbc14
PE
1997 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1998 Remove unused local var.
1999
f838ed7b
PE
2000 * editfns.c (Fmessage_box): Remove unused local var.
2001
792c7b2b
PE
2002 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2003 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2004 Omit unused local vars.
c499e557 2005 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2006 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2007 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2008 Omit unused local var.
2009
ba0165e1
PE
2010 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2011 Don't assume string length fits in int.
32ad8845 2012 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2013 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2014
3c59b4c9
PE
2015 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2016 instead of alloca (Bug#8344).
2017
a3eed478 2018 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2019 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2020
eb4d412d
PE
2021 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2022
1658b401
PE
2023 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2024 concerns.
2025
2026 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2027
2028 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2029
9a2c6e05
PE
2030 * keyboard.c (syms_of_keyboard): Use the same style as later
2031 in this function when indexing through an array. This also
2032 works around GCC bug 48267.
2033
03d0a109
PE
2034 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2035
44f730c8
PE
2036 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2037
fe75f926
PE
2038 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2039 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2040
ffa8c828
PE
2041 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2042 This avoids undefined behavior on integer overflow, and is a bit
2043 more convenient anyway since it is compared to a size_t variable.
2044
c5101a77
PE
2045 Variadic C functions now count arguments with size_t, not int.
2046 This avoids an unnecessary limitation on 64-bit machines, which
2047 caused (substring ...) to crash on large vectors (Bug#8344).
2048 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2049 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2050 All variadic functions and their callers changed accordingly.
c5101a77
PE
2051 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2052 * data.c (arith_driver, float_arith_driver): Likewise.
2053 * editfns.c (general_insert_function): Likewise.
2054 * eval.c (struct backtrace.nargs, interactive_p)
2055 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2056 (funcall_lambda, mark_backtrace): Likewise.
2057 * fns.c (concat): Likewise.
2058 * frame.c (x_set_frame_parameters): Likewise.
2059 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2060 0 if not found, not -1. All callers changed.
2061
dd3f25f7
PE
2062 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2063 (stack_copy_size): Now size_t, not int.
2064 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2065
461c2ab9
JB
20662011-03-28 Juanma Barranquero <lekktu@gmail.com>
2067
2068 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2069 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2070 All callers changed.
2071
2072 * lisp.h (multibyte_char_to_unibyte):
2073 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2074 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2075 * character.h (CHAR_TO_BYTE8):
2076 * cmds.c (internal_self_insert):
2077 * editfns.c (general_insert_function):
2078 * keymap.c (push_key_description):
2079 * search.c (Freplace_match):
2080 * xdisp.c (message_dolog, set_message_1): All callers changed.
2081
f6d62986
SM
20822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2083
2084 * keyboard.c (safe_run_hook_funcall): New function.
2085 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2086 don't set the hook to nil, but remove the offending function instead.
2087 (Qcommand_hook_internal): Remove, unused.
2088 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2089 Vcommand_hook_internal.
2090
2091 * eval.c (enum run_hooks_condition): Remove.
2092 (funcall_nil, funcall_not): New functions.
2093 (run_hook_with_args): Call each function through a `funcall' argument.
2094 Remove `cond' argument, now redundant.
2095 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2096 (Frun_hook_with_args_until_failure): Adjust accordingly.
2097 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2098
1db5b1ad
JB
20992011-03-28 Juanma Barranquero <lekktu@gmail.com>
2100
2101 * dispextern.h (string_buffer_position): Remove declaration.
2102
2103 * print.c (strout): Remove parameter `multibyte', unused since
2104 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2105
2106 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2107 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2108 All callers changed.
2109
2110 * w32.c (_wsa_errlist): Use braces for struct initializers.
2111
2112 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2113 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2114 All callers changed.
2115 (string_buffer_position): Likewise. Also, make static (it's never
2116 used outside xdisp.c).
2117 (cursor_row_p): Remove parameter `w', unused since
2118 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2119 (decode_mode_spec): Remove parameter `precision', introduced during
2120 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2121 All callers changed.
2122
5ffb62aa
JD
21232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2124
2125 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2126
461c2ab9 21272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2128
2129 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2130 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2131 (ns_update_auto_hide_menu_bar): New functions.
2132 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2133 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2134 ns_constrain_all_frames.
2135 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2136 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2137
5c380ffb
JD
21382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2139
2140 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2141
9af30bdf
GM
21422011-03-27 Glenn Morris <rgm@gnu.org>
2143
2144 * syssignal.h: Replace RETSIGTYPE with void.
2145 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2146 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2147 Replace SIGTYPE with void everywhere.
2148 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2149 * s/template.h (SIGTYPE): Remove commented out definition.
2150
e2abce01
JB
21512011-03-26 Eli Zaretskii <eliz@gnu.org>
2152
2153 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2154 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2155
f868cd8a
JB
21562011-03-26 Juanma Barranquero <lekktu@gmail.com>
2157
59eb0929
JB
2158 * w32.c (read_unc_volume): Use parameter `henum', instead of
2159 global variable `wget_enum_handle'.
2160
2161 * keymap.c (describe_vector): Remove parameters `indices' and
2162 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2163 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2164
f868cd8a
JB
2165 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2166
2167 * keyboard.c (timer_check): Remove parameter `do_it_now',
2168 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2169 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2170 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2171
2172 * keyboard.c (read_char):
2173 * w32menu.c (w32_menu_display_help):
2174 * xmenu.c (show_help_event, menu_help_callback):
2175 Adjust calls to `show_help_echo'.
2176
2177 * gtkutil.c (xg_maybe_add_timer):
2178 * keyboard.c (readable_events):
2179 * process.c (wait_reading_process_output):
2180 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2181
2182 * insdel.c (adjust_markers_gap_motion):
2183 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2184 (gap_left, gap_right): Don't call it.
2185
2ecf6fdb
CY
21862011-03-25 Chong Yidong <cyd@stupidchicken.com>
2187
2188 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2189 incurred during fontification.
2190
6b1f9ba4
JB
21912011-03-25 Juanma Barranquero <lekktu@gmail.com>
2192
2193 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2194 (DEFVAR_PER_BUFFER): Don't pass it.
2195
2196 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2197 (scrolling_window): Don't pass it.
2198
0f4a96b5
JB
21992011-03-25 Juanma Barranquero <lekktu@gmail.com>
2200
2201 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2202
2203 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2204 and `suffix'.
2205 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2206 of variables specific to SELinux and computation of `encoded_absname'.
2207
2208 * image.c (XPutPixel): Remove unused variable `height'.
2209
2210 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2211
2212 * unexw32.c (get_section_info): Remove unused variable `section'.
2213
2214 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2215 (system_process_attributes): Remove unused variable `sess'.
2216 (sys_read): Remove unused variable `err'.
2217
2218 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2219 (w32_wnd_proc): Remove unused variable `isdead'.
2220 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2221 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2222 (x_create_tip_frame): Remove unused variable `tem'.
2223
2224 * w32inevt.c (w32_console_read_socket):
2225 Remove unused variable `no_events'.
2226
2227 * w32term.c (x_draw_composite_glyph_string_foreground):
2228 Remove unused variable `width'.
2229
1149507c
JB
22302011-03-24 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * w32term.c (x_set_glyph_string_clipping):
2233 Don't pass uninitialized region to CombineRgn.
2234
9c88f339
JB
22352011-03-23 Juanma Barranquero <lekktu@gmail.com>
2236
2237 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2238 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2239 (Fx_close_connection): Remove unused variable `i'.
2240
2241 * w32font.c (w32font_draw): Return number of glyphs.
2242 (w32font_open_internal): Remove unused variable `i'.
2243 (w32font_driver): Add missing initializer.
2244
2245 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2246 (fill_in_menu): Remove unused variable `items_added'.
2247
2248 * w32term.c (last_mouse_press_frame): Remove static global variable.
2249 (w32_clip_to_row): Remove unused variable `f'.
2250 (x_delete_terminal): Remove unused variable `i'.
2251
2252 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2253 (NOTHING): Remove unused static global variable.
2254 (uniscribe_check_otf): Remove unused variable `table'.
2255 (uniscribe_font_driver): Add missing initializers.
2256
dee091a3
JD
22572011-03-23 Julien Danjou <julien@danjou.info>
2258
2259 * term.c (Fsuspend_tty, Fresume_tty):
2260 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2261 * window.c (temp_output_buffer_show):
2262 * insdel.c (signal_before_change):
2263 * frame.c (Fhandle_switch_frame):
2264 * fileio.c (Fdo_auto_save):
2265 * emacs.c (Fkill_emacs):
2266 * editfns.c (save_excursion_restore):
2267 * cmds.c (internal_self_insert):
2268 * callint.c (Fcall_interactively):
2269 * buffer.c (Fkill_all_local_variables):
2270 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2271 Use Frun_hooks.
0f4a96b5 2272 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2273 unconditionnaly since it does the check itself.
2274
2c520ab5 22752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2276
c9c49752
PE
2277 Fix more problems found by GCC 4.5.2's static checks.
2278
8abc3f12
PE
2279 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2280 the first time through the loop, since we know p0 < p1 then.
2281 This also avoids a gcc -Wstrict-overflow warning.
2282
a2d26660
PE
2283 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2284 leading to a memory leak, possible in functions like
2285 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2286 of objects (Bug#8318).
a2d26660 2287
916c72e9
PE
2288 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2289 that could (at least in theory) be that large.
2290
19ab8a18
PE
2291 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2292 This is less likely to overflow, and avoids undefined behavior if
2293 overflow does occur. All callers changed. Use strtoul to scan
2294 for the unsigned long integer.
b7cbbd6f
PE
2295 (pint2hrstr): Simplify and tune code slightly.
2296 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2297
f0641eff
PE
2298 * scroll.c (do_scrolling): Work around GCC bug 48228.
2299 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2300
7f650bb9
PE
2301 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2302 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2303 (validate_x_resource_name): Simplify count usage.
2304 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2305
37dd57d1
PE
2306 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2307 fail (Bug#8306).
81e56e61 2308
699979fc 2309 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2310
401bf9b4
PE
2311 * process.c (Fmake_network_process): Use socklen_t, not int,
2312 where POSIX says socklen_t is required in portable programs.
2313 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2314 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2315 (Fmake_network_process, server_accept_connection):
2316 (wait_reading_process_output, read_process_output):
2317 Likewise.
2318
b93aacde
PE
2319 * process.c: Rename or move locals to avoid shadowing.
2320 (list_processes_1, Fmake_network_process):
2321 (read_process_output_error_handler, exec_sentinel_error_handler):
2322 Rename or move locals.
4dc343ee 2323 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2324 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2325 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2326 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2327 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2328
af8a867c 2329 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2330 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2331 Include tparam.h instead, since it declares them.
af8a867c
PE
2332 * cm.h (PC): Remove extern decl; tparam.h now does this.
2333 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2334 * terminfo.c: Include tparam.h, to check interfaces.
2335 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2336 (tparam): Adjust signature to match interface in tparam.h;
2337 this removes some undefined behavior. Check that outstring and len
2338 are zero, which they always are with Emacs.
2339 * tparam.h (PC, BC, UP): New extern decls.
2340
0248044d 2341 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2342 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2343
8ff096c1 2344 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2345 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2346 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2347 (ftfont_list): Remove unused local.
49eaafba
PE
2348 (get_adstyle_property, ftfont_pattern_entity):
2349 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2350 Rename locals to avoid shadowing.
8ff096c1 2351
e2be39f6
PE
2352 * xfont.c (xfont_list_family): Mark var as initialized.
2353
c9735e30
PE
2354 * xml.c (make_dom): Now static.
2355
8f5201ae
PE
2356 * composite.c (composition_compute_stop_pos): Rename local to
2357 avoid shadowing.
b246f932
PE
2358 (composition_reseat_it): Remove unused locals.
2359 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2360 (composition_update_it): Mark var as initialized.
11b61122
PE
2361 (find_automatic_composition): Mark vars as initialized,
2362 with a FIXME (Bug#8290).
8f5201ae 2363
760fbc2c
PE
2364 character.h: Rename locals to avoid shadowing.
2365 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2366 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2367 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2368 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2369 to avoid shadowing.
2370
ff08eb85
PE
2371 * textprop.c (property_change_between_p): Remove; unused.
2372
fc7bf025
PE
2373 * intervals.c (interval_start_pos): Now static.
2374
235d7abc
PE
2375 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2376
44f230aa
SM
2377 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2378 Rename locals to avoid shadowing.
3e7d6594 2379
50060332
PE
2380 * sound.c (wav_play, au_play, Fplay_sound_internal):
2381 Fix pointer signedness.
d01f234b 2382 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2383 (wav_play): Initialize a variable to 0, to prevent undefined
2384 behavior (Bug#8278).
50060332 2385
c4fc4e30
PE
2386 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2387
918436ed
PE
2388 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2389
c939f91b
PE
2390 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2391 clobbering (Bug#8298).
b9c7f648
PE
2392 * sysdep.c (sys_subshell): Likewise.
2393 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2394
6bd8c144
PE
2395 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2396 This should get cleaned up, so that child_setup has the
2397 same signature on all platforms.
2398
7710357c 2399 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2400 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2401
c59da222
CY
24022011-03-22 Chong Yidong <cyd@stupidchicken.com>
2403
2404 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2405 not to be necessary, and produces flickering.
2406
66b87493
GM
24072011-03-20 Glenn Morris <rgm@gnu.org>
2408
2409 * config.in: Remove file.
2410
45b6f6d5
JB
24112011-03-20 Juanma Barranquero <lekktu@gmail.com>
2412
2413 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2414 are now in src/globals.h.
2415 (syms_of_minibuf): Remove spurious & from previous change.
2416
3ec03f7e
LL
24172011-03-20 Leo <sdl.web@gmail.com>
2418
2419 * minibuf.c (completing-read-function): New variable.
2420 (completing-read-default): Rename from completing-read.
2421 (completing-read): Call completing-read-function.
2422
b14e3e21
CY
24232011-03-19 Juanma Barranquero <lekktu@gmail.com>
2424
2425 * xfaces.c (Fx_load_color_file):
2426 Read color file from absolute filename (bug#8250).
2427
f2b726e6
JB
24282011-03-19 Juanma Barranquero <lekktu@gmail.com>
2429
2430 * makefile.w32-in: Update dependencies.
2431
09f6ff02
EZ
24322011-03-17 Eli Zaretskii <eliz@gnu.org>
2433
2434 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2435
29a6015a
PE
24362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2437
a3a6c54e
PE
2438 Fix more problems found by GCC 4.5.2's static checks.
2439
b766f867
PE
2440 * process.c (make_serial_process_unwind, send_process_trap):
2441 (sigchld_handler): Now static.
2442
be02381c
PE
2443 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2444 That way, the code declares only the vars that it needs.
2445 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2446 * s/cygwin.h (PTY_ITERATION): Likewise.
2447 * s/darwin.h (PTY_ITERATION): Likewise.
2448 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2449
57048744
PE
2450 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2451 * process.c (allocate_pty): Don't declare stb unless it's needed.
2452
7914961c 2453 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2454 (CONSTANTLIM): Remove; unused.
2455 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2456 Define only if needed.
7914961c 2457
b3967b18
PE
2458 * unexelf.c (unexec): Name an expression,
2459 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2460 Use a different way to cause a compilation error if anyone uses
2461 n rather than nn, a way that does not involve shadowing.
73366a00 2462 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2463
29a6015a
PE
2464 * deps.mk (unexalpha.o): Remove; unused.
2465
43cfc33e 2466 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2467 * unexec.h: New file.
ce701a33
PE
2468 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2469 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2470 Depend on unexec.h.
2471 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2472 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2473 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2474 Change as necessary to match prototype in unexec.h.
ce701a33 2475
01f44d5a
PE
2476 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2477 shadowing.
4f63c6bb 2478 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2479
a6670b0b
PE
2480 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2481 Rename locals to avoid shadowing.
2482
cef2010d 2483 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2484 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2485
d4d7173a
PE
2486 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2487
f08b802a
PE
2488 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2489 warning when compiling print.c.
2490
3ddb0639
PE
2491 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2492 instead of using an uninitialized var.
5ad03b97 2493 (font_sort_entities): Mark var as initialized.
3ddb0639 2494
170a2692
PE
2495 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2496
e663c700
PE
2497 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2498 pointers to constants.
89bc529a 2499 (font_parse_fcname): Remove unused vars.
7b81e2d0 2500 (font_delete_unmatched): Now static.
ea838e10 2501 (font_get_spec): Remove; unused.
13a547c6
PE
2502 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2503 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2504 Rename or move locals to avoid shadowing.
e663c700 2505
2a80c887 2506 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2507 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2508
1384fa33 2509 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2510 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2511
8b2c52e9
PE
2512 * alloc.c (mark_backtrace): Move decl from here ...
2513 * lisp.h: ... to here, so that it can be checked.
2514
475545b5 2515 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2516 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2517 (lisp_indirect_variable): Name an expression,
2518 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2519 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2520
b1349114 2521 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2522 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2523 Use const pointer when appropriate.
b1349114 2524
a2928364
PE
2525 * lisp.h (get_system_name, get_operating_system_release):
2526 Move decls here, to check interfaces.
2527 * process.c (get_operating_system_release): Move decl to lisp.h.
2528 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2529 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2530 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2531 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2532 (Fformat_time_string, Fencode_time, Finsert_char):
2533 (Ftranslate_region_internal, Fformat):
2534 Rename or remove local vars to avoid shadowing.
9710023e 2535 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2536
a415e694
PE
2537 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2538 avoid shadowing.
2539
8ef4622d
PE
2540 * lisp.h (eassert): Check that the argument compiles, even if
2541 ENABLE_CHECKING is not defined.
2542
946f9a5b
PE
2543 * data.c (Findirect_variable): Name an expression, to avoid
2544 gcc -Wbad-function-cast warning.
112396d6 2545 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2546 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2547 (Fmake_variable_buffer_local, Fmake_local_variable):
2548 Mark variables as initialized.
52746918 2549 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2550
e5aab7e7 2551 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2552 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2553 Rename locals to avoid shadowing.
dff45157
PE
2554 (mark_stack): Move local variables into the #ifdef region where
2555 they're used.
7bc26fdb
PE
2556 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2557 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2558 needed otherwise.
2559 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2560 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2561 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2562
e5aab7e7
PE
2563 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2564 avoids undefined behavior in theory.
2565
4da60324
PE
2566 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2567
88043301
PE
2568 Use functions, not macros, for up- and down-casing (Bug#8254).
2569 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2570 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2571 to use the following functions instead of these macros.
2572 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2573 EMACS_INT, since callers assume the returned value fits in int.
2574 (upcase1): Likewise, for UPCASE_TABLE.
2575 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2576 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2577 the race-condition problem in the old DOWNCASE.
88043301 2578
19ed5445
PE
2579 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2580 Rename locals to avoid shadowing.
2581 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2582 (regex_compile, re_search_2, re_match_2_internal):
2583 Remove unused local vars.
952db0d7
PE
2584 (FREE_VAR): Rewrite so as not to use empty "else",
2585 which gcc can warn about.
da053e48 2586 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2587 (RETALLOC_IF): Define only if needed.
2588 (WORDCHAR_P): Likewise. This one is never needed, but is used
2589 only in a comment talking about a compiler bug, so put inside
2590 the #if 0 of that comment.
2591 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2592 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2593 Remove; unused.
19ed5445 2594
1f3561e4 2595 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2596 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2597 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2598
ded6f8f7
PE
2599 * search.c (simple_search): Remove unused var.
2600
dbd37a95
PE
2601 * dired.c (compile_pattern): Move decl from here ...
2602 * lisp.h: ... to here, so that it can be checked.
2603 (struct re_registers): New forward decl.
2604
7e47afad
PE
2605 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2606
85f24f61
PE
2607 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2608 All uses changed.
2609 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2610 Rename locals to avoid shadowing.
5671df8f 2611 (Fvertical_motion): Mark locals as initialized.
85f24f61 2612
181aa2be 2613 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2614 (casify_region): Mark local as initialized.
181aa2be 2615
930d429c
PE
2616 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2617
7082eac6
PE
2618 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2619 New macros, so that the caller can use some names other than
2620 gcpro1, gcpro2, etc.
2621 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2622 of the new macros.
2623 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2624 argument, for consistency with GCPRO2_VAR, etc: it is now the
2625 prefix of the variable, not the variable itself. All uses
2626 changed.
38b2c076
PE
2627 * dired.c (directory_files_internal, file_name_completion):
2628 Rename locals to avoid shadowing.
2629
15206ed9
PE
2630 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2631 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2632 dired.c's scmp function, had undefined behavior.
2633 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2634 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2635 * buffer.h: ... to here, because these macros use current_buffer,
2636 and the new implementation with inline functions needs to have
2637 current_buffer in scope now, rather than later when the macros
2638 are used.
2639 (downcase, upcase1): New static inline functions.
2640 (DOWNCASE, UPCASE1): Reimplement using these functions.
2641 This avoids undefined behavior in expressions like
2642 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2643 from race conditions in accessing the global variables
2644 case_temp1 and case_temp2.
2645 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2646 * lisp.h (case_temp1, case_temp2): Remove their decls.
2647 * character.h (ASCII_CHAR_P): Move from here ...
2648 * lisp.h: ... to here, so that the inline functions mentioned
2649 above can use them.
2650
4a6bea26
PE
2651 * dired.c (directory_files_internal_unwind): Now static.
2652
f14b7e14
PE
2653 * fileio.c (file_name_as_directory, directory_file_name):
2654 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2655 Now static.
2893f146
PE
2656 (file_name_as_directory): Use const pointers when appropriate.
2657 (Fexpand_file_name): Likewise. In particular, newdir might
2658 point at constant storage, so make it a const pointer.
fd4ead52 2659 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2660 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2661 signedness issues.
f839df0c
PE
2662 (Fset_file_times, Finsert_file_contents, auto_save_error):
2663 Rename locals to avoid shadowing.
f14b7e14 2664
5716756e 2665 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2666 (Ftry_completion, Fall_completions): Rename or remove locals
2667 to avoid shadowing.
5716756e 2668
b4c3046a
PE
2669 * marker.c (bytepos_to_charpos): Remove; unused.
2670
b45db522
PE
2671 * lisp.h (verify_bytepos, count_markers): New decls,
2672 so that gcc does not warn that these functions aren't declared.
2673
85876d07
PE
2674 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2675 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2676 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2677 (copy_text): Remove unused local var.
85876d07 2678
03d78a21 2679 * filelock.c (within_one_second): Now static.
b3dd38ab 2680 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2681
5df8f01b
PE
2682 * buffer.c (fix_overlays_before): Mark locals as initialized.
2683 (fix_start_end_in_overlays): Likewise. This function should be
2684 simplified by using pointers-to-pointers, but that's a different
2685 matter.
b1d876f1 2686 (switch_to_buffer_1): Now static.
8f54f30a
PE
2687 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2688 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2689
a70072c9 2690 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2691 Fix pointer signedness issue.
edced198
PE
2692 (sys_subshell): Mark local as volatile if checking for lint,
2693 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2694 (MAXPATHLEN): Define only if needed.
a70072c9 2695
a0977c44
PE
2696 * process.c (serial_open, serial_configure): Move decls from here ...
2697 * systty.h: ... to here, so that they can be checked.
2698
a884fdcc
PE
2699 * fns.c (get_random, seed_random): Move extern decls from here ...
2700 * lisp.h: ... to here, so that they can be checked.
2701
604efe86 2702 * sysdep.c (reset_io): Now static.
b8950c94 2703 (wait_for_termination_signal): Remove; unused.
604efe86 2704
38fc62d9
PE
2705 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2706 (copy_keymap_item, append_key, push_text_char_description):
2707 Now static.
1004a21a 2708 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2709 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2710 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2711 (describe_map_tree):
2712 Rename locals to avoid shadowing.
38fc62d9 2713
2f2650da
PE
2714 * keyboard.c: Declare functions static if they are not used elsewhere.
2715 (echo_char, echo_dash, cmd_error, top_level_2):
2716 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2717 (read_char, kbd_buffer_get_event, make_lispy_position):
2718 (make_lispy_event, make_lispy_movement, apply_modifiers):
2719 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2720 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2721 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2722 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2723 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2724
a053e86c 2725 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2726 (mark_kboards): Move decl here ...
2727 * alloc.c (mark_kboards): ... from here.
a053e86c 2728
4752793e
PE
2729 * lisp.h (force_auto_save_soon): New decl.
2730
74f10ca7 2731 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2732 (DEFINE_DUMMY_FUNCTION): New macro.
2733 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2734 Use it.
c03cd23f
PE
2735 (main): Add casts to avoid warnings
2736 if GCC considers string literals to be constants.
74f10ca7 2737
022e70d4
PE
2738 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2739
59d6fe83
PE
2740 * dbusbind.c: Pointer signedness fixes.
2741 (xd_signature, xd_append_arg, xd_initialize):
2742 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2743 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2744 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2745 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2746
78320123
PE
2747 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2748 if GCC considers string literals to be constants.
49cebcca 2749 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2750
35ac2a97
SM
27512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2752
fb103ca9
SM
2753 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2754 (print_preprocess, print_object): New macro to fix last change.
2755
35ac2a97
SM
2756 * print.c (print_preprocess): Don't forget font objects.
2757
62973b41
JB
27582011-03-16 Juanma Barranquero <lekktu@gmail.com>
2759
2760 * emacs.c (USAGE3): Doc fixes.
2761
0e48bb22
AS
27622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2763
2764 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2765 structure.
2766
7684e57b
JB
27672011-03-14 Juanma Barranquero <lekktu@gmail.com>
2768
2769 * lisp.h (VWindow_system, Qfile_name_history):
2770 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2771 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2772 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2773
2774 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2775 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2776
2777 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2778 * w32console.c (detect_input_pending, read_input_pending)
2779 (encode_terminal_code):
2780 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2781 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2782 (w32_system_caret_y, Qfile_name_history):
2783 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2784 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2785 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2786 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2787 * w32proc.c (Qlocal, report_file_error):
2788 * w32term.c (Vwindow_system, updating_frame):
2789 * w32uniscribe.c (initialized, uniscribe_font_driver):
2790 Remove unneeded extern declarations.
2791
2aa46d6c
CY
27922011-03-14 Chong Yidong <cyd@stupidchicken.com>
2793
c96bbc66 2794 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2795
cffc6f3b
CY
27962011-03-13 Chong Yidong <cyd@stupidchicken.com>
2797
2798 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2799 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2800 These macros can no longer be used for assignment.
2801
44f230aa
SM
2802 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2803 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2804 (record_buffer_markers, fetch_buffer_markers): New functions for
2805 recording and fetching special buffer markers.
2806 (set_buffer_internal_1, set_buffer_temp): Use them.
2807
2808 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2809
2810 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2811
2812 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2813 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2814
2815 * xdisp.c (hscroll_window_tree):
2816 (reconsider_clip_changes): Use PT instead of BUF_PT.
2817
d251f04b
EZ
28182011-03-13 Eli Zaretskii <eliz@gnu.org>
2819
2820 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2821 $(EMACS_ROOT)/lib/intprops.h.
2822
f0c77cd1
PE
28232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2824
3eca4629
PE
2825 Fix more problems found by GCC 4.5.2's static checks.
2826
7c86ee98
PE
2827 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2828 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2829 (xg_free_frame_widgets): Make it clear that a local variable is
2830 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2831 (gdk_window_get_screen): Make it clear that this macro is needed
2832 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2833 (int_gtk_range_get_value): New function, which avoids a diagnostic
2834 from gcc -Wbad-function-cast.
2835 (xg_set_toolkit_scroll_bar_thumb): Use it.
2836 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2837 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2838 (get_utf8_string, xg_get_file_with_chooser):
2839 Rename locals to avoid shadowing.
2840 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2841
41729b81
PE
2842 * xgselect.c (xg_select): Remove unused var.
2843
f0c77cd1
PE
2844 * image.c (four_corners_best): Mark locals as initialized.
2845 (gif_load): Initialize transparent_p to zero (Bug#8238).
2846 Mark another local as initialized.
ec6cf4c6 2847 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2848
ce0ad53d 2849 * image.c (clear_image_cache): Now static.
d5d5a617 2850 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2851 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2852 (x_edge_detection): Remove unnecessary cast that
2853 gcc -Wbad-function-cast diagnoses.
2037898d 2854 (gif_load): Fix pointer signedness.
6ae141d6
PE
2855 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2856 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2857
33383987 28582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2859
d32df629
PE
2860 Improve quality of tests for time stamp overflow.
2861 For example, without this patch (encode-time 0 0 0 1 1
2862 1152921504606846976) returns the obviously-bogus value (-948597
2863 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2864 reports time overflow. See
2865 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2866 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2867 * editfns.c: Include limits.h and intprops.h.
2868 (TIME_T_MIN, TIME_T_MAX): New macros.
2869 (time_overflow): Move earlier, to before first use.
2870 (hi_time, lo_time): New functions, for an accurate test for
2871 out-of-range times.
2872 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2873 (Fget_internal_run_time): Don't assume time_t fits in int.
2874 (make_time): Use list2 instead of Fcons twice.
2875 (Fdecode_time): More accurate test for out-of-range times.
2876 (check_tm_member): New function.
2877 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2878 (lisp_time_argument): Don't rely on undefined left-shift and
2879 right-shift behavior when checking for time stamp overflow.
8be6f318 2880
fe31d94c
PE
2881 * editfns.c (time_overflow): New function, refactoring common code.
2882 (Fformat_time_string, Fdecode_time, Fencode_time):
2883 (Fcurrent_time_string): Use it.
2884
8be6f318
PE
2885 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2886 * dired.c (make_time): Move to ...
2887 * editfns.c (make_time): ... here.
2888 * systime.h: Note the move.
2889
09d9db2c 28902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2891
126bc0dc
YM
2892 * fringe.c (update_window_fringes): Remove unused variables.
2893
c47cbdfd
YM
2894 * unexmacosx.c (copy_data_segment): Also copy __got section.
2895 (Bug#8223)
2896
7ac80be9
EZ
28972011-03-12 Eli Zaretskii <eliz@gnu.org>
2898
c96bbc66 2899 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2900 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2901 Constify `char *' arguments and their references according to
2902 prototypes in tparam.h.
2903
ecb0f94d 2904 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2905
7ac80be9
EZ
2906 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2907 Adapt all references accordingly.
2908
2909 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2910
ef1fd07e
TT
29112011-03-11 Tom Tromey <tromey@redhat.com>
2912
2913 * buffer.c (syms_of_buffer): Remove obsolete comment.
2914
7ef4b50c
EZ
29152011-03-11 Eli Zaretskii <eliz@gnu.org>
2916
2917 * termhooks.h (encode_terminal_code): Declare prototype.
2918
2919 * msdos.c (encode_terminal_code): Don't declare prototype.
2920
2921 * term.c (encode_terminal_code): Now external again, used by
2922 w32console.c and msdos.c.
2923
44f230aa
SM
2924 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2925 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2926
4b1ec863 29272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2928
1714f52b 2929 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2930
4b1ec863
PE
2931 * fringe.c (update_window_fringes): Mark locals as initialized
2932 (Bug#8227).
2933 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2934
524c7aa6
PE
2935 * alloc.c (mark_fringe_data): Move decl from here ...
2936 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2937 to check its interface.
2938 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2939
a5c0af81 2940 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2941 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2942 (fontset_font): Mark local as initialized.
a9a06e0b 2943 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2944
b4716021
PE
2945 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2946
811e9bac 2947 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2948 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2949 (x_own_selection, Fx_disown_selection_internal): Rename locals
2950 to avoid shadowing.
2951 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2952
7e3ab302
PE
2953 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2954 so that the caller can use some name other than gcpro1.
2955 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2956 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2957 (Fx_backspace_delete_keys_p):
2958 Use them to avoid shadowing, and rename vars to avoid shadowing.
2959 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2960 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2961 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2962 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2963 Remove unused locals.
7e3ab302
PE
2964 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2965 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2966 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2967 macros.
f78faa98 2968
e2b13473
PE
2969 * xterm.h (x_mouse_leave): New decl.
2970
77f23912
PE
2971 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2972 Remove unused functions.
cdf4ba58
PE
2973 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2974 (x_calc_absolute_position): Now static.
7411c686 2975 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2976 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2977 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2978 unless they are used.
38d0b34a
PE
2979 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2980 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2981 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2982 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2983 (x_error_catcher, x_connection_closed, x_error_handler):
2984 (x_error_quitter, xembed_send_message, x_iconify_frame):
2985 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2986 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2987 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2988
44f230aa
SM
2989 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2990 Rename or move locals to avoid shadowing.
6b463e58 2991 (tty_defined_color, merge_face_heights): Now static.
5967d051 2992 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2993 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2994 does not deduce is never used uninitialized.
73719eba
PE
2995 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2996 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2997
426994c3 2998 * terminal.c (store_terminal_param): Now static.
5489860b 2999
032f1620 3000 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3001 (set_frame_menubar): Remove unused local.
d4323972 3002 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3003 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3004 since they might point to immutable storage.
281585b0
PE
3005 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3006 since it's unused otherwise.
032f1620 3007
367c19e5 3008 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3009 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3010 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3011 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3012 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3013 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3014 does not deduce are never used uninitialized.
70739cbe 3015
07b48fa9
PE
3016 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3017
8868a238 3018 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3019 * window.c (window_loop, size_window):
3020 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3021
7e5cf297 3022 * window.c (display_buffer): Now static.
d6550a9f
PE
3023 (size_window): Mark variables that gcc -Wuninitialized
3024 does not deduce are never used uninitialized.
a586633d
PE
3025 * window.h (check_all_windows): New decl, to forestall
3026 gcc -Wmissing-prototypes diagnostic.
5b555da1 3027 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3028
f6095868
PE
3029 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3030 shadowing.
3031 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3032 Include <limits.h>.
3033 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3034 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3035 (load_charset_map): Mark variables that gcc -Wuninitialized
3036 does not deduce are never used uninitialized.
53df7c11 3037 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3038
f38b440c
PE
3039 * coding.c (coding_set_source, coding_set_destination):
3040 Use "else { /* comment */ }" rather than "else /* comment */;"
3041 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3042 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3043 a block, when the outer 'i' will do.
3044 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3045 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3046 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3047 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3048 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3049 Rename locals to avoid shadowing.
3050 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3051 * coding.c (emacs_mule_char, encode_invocation_designation):
3052 Now static, since they're not used elsewhere.
413bb2db 3053 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3054 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3055 (decode_coding_emacs_mule): Mark variables that gcc
3056 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3057 (detect_coding_iso_2022): Initialize a local variable that might
3058 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3059 this initialization is needed. (Bug#8211)
5f58e762
PE
3060 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3061 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3062 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3063 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3064 Remove unused macros.
f38b440c 3065
232b38b9 3066 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3067 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3068 * character.c (string_count_byte8): Likewise.
232b38b9 3069
fb90da1b
PE
3070 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3071 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3072
fb93dbc2
PE
3073 * chartab.c (copy_sub_char_table): Now static, since it's not used
3074 elsewhere.
5c156ace
PE
3075 (sub_char_table_ref_and_range, char_table_ref_and_range):
3076 Rename locals to avoid shadowing.
bbcd0949 3077 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3078
7d3b3862 3079 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3080 (BIDI_BOB): Remove unused macro.
7d3b3862 3081
6be7d3da
PE
3082 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3083 deduce are never used uninitialized.
c2ed9c8b 3084 * term.c (encode_terminal_code): Likewise.
6be7d3da 3085
75f8807f 3086 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3087
50938595
PE
3088 * tparam.h: New file.
3089 * term.c, tparam.h: Include it.
3090 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3091 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3092 Move these decls to tparam.h, and make them agree with what
3093 is actually in tparam.c. The previous trick of using incompatible
3094 decls in different modules does not conform to the C standard.
3095 All callers of tparam changed to use tparam's actual API.
3096 * tparam.c (tparam1, tparam, tgoto):
3097 Use const pointers where appropriate.
3098
fbceeba2
PE
3099 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3100 * cm.h (struct cm): Likewise.
3101 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3102 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3103 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3104 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3105 (turn_on_face, init_tty): Likewise.
3106 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3107
7f3f1250
PE
3108 * term.c (term_mouse_position): Rename local to avoid shadowing.
3109
e6ca6543
PE
3110 * alloc.c (mark_ttys): Move decl from here ...
3111 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3112
c40f8d15
AS
31132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3114
3115 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3116
cfe0661d
JB
31172011-03-09 Juanma Barranquero <lekktu@gmail.com>
3118
3119 * search.c (compile_pattern_1): Remove argument regp, unused since
3120 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3121 (compile_pattern): Don't pass it.
3122
0afb4571
J
31232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3124
3125 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3126 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3127 for ! HAVE_GTK3.
3128 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3129
3130 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3131
3132 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3133 gdk_window_get_screen, gdk_window_get_geometry,
3134 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3135 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3136 (xg_get_pixbuf_from_pixmap): New function.
3137 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3138 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3139 Call xg_get_pixbuf_from_pixmap instead of
3140 gdk_pixbuf_get_from_drawable.
3141 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3142 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3143 (xg_check_special_colors): Use GtkStyleContext and its functions
3144 for HAVE_GTK3.
3145 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3146 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3147 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3148 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3149 Call gtk_widget_get_preferred_size.
0afb4571
J
3150 (xg_frame_resized): gdk_window_get_geometry only takes 5
3151 parameters.
44f230aa
SM
3152 (xg_win_to_widget, xg_event_is_for_menubar):
3153 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3154 (xg_set_widget_bg): New function.
3155 (delete_cb): New function.
895009e1 3156 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3157 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3158 (xg_set_background_color): Call xg_set_widget_bg.
3159 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3160 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3161 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3162 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3163 if ! HAVE_GTK3.
3164 (update_frame_tool_bar): Call gtk_widget_hide.
3165 (xg_initialize): Use GDK_KEY_g.
3166
3167 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3168 if ! HAVE_GTK3
3169 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3170
3171 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3172 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3173 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3174
1c2cc4ef
JB
31752011-03-08 Juanma Barranquero <lekktu@gmail.com>
3176
3177 * w32xfns.c (select_palette): Check success of RealizePalette against
3178 GDI_ERROR, not zero.
3179
33383987 3180See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3181
3182;; Local Variables:
3183;; coding: utf-8
aac0c6e3
MR
3184;; End:
3185
33383987 3186 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3187
3188 This file is part of GNU Emacs.
3189
3190 GNU Emacs is free software: you can redistribute it and/or modify
3191 it under the terms of the GNU General Public License as published by
3192 the Free Software Foundation, either version 3 of the License, or
3193 (at your option) any later version.
3194
3195 GNU Emacs is distributed in the hope that it will be useful,
3196 but WITHOUT ANY WARRANTY; without even the implied warranty of
3197 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3198 GNU General Public License for more details.
3199
3200 You should have received a copy of the GNU General Public License
3201 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.