Fix bug #8597 with setting frame background mode on w32 console.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
888c9e86
EZ
12011-05-07 Eli Zaretskii <eliz@gnu.org>
2
b0512a1d
EZ
3 * w32console.c (Fset_screen_color): Doc fix.
4 (Fget_screen_color): New function.
5 (syms_of_ntterm): Defsubr it.
6
888c9e86
EZ
7 * callproc.c (call_process_cleanup): Don't close and unlink the
8 temporary file if Fcall_process didn't create it in the first
9 place.
10 (Fcall_process): Don't create tempfile if stdout of the child
11 process will be redirected to a file specified with `:file'.
12 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13 cue to call_process_cleanup not to close that handle.
14
4d3fcc8e
BK
152011-05-07 Ben Key <bkey76@gmail.com>
16
17 * makefile.w32-in: The bootstrap-temacs rule now makes use of
18 one of two shell specific rules, either bootstrap-temacs-CMD or
19 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
20 to the previous implementation of the bootstrap-temacs rule.
21 The bootstrap-temacs-CMD rule is similar to the previous
22 implementation of the bootstrap-temacs rule except that it
23 makes use of the ESC_CFLAGS variable instead of the CFLAGS
24 variable.
25
26 These changes, along with some changes to nt/configure.bat,
27 nt/gmake.defs, and nt/nmake.defs, are required to extend my
28 earlier fix to add support for --cflags and --ldflags options
29 that include quotes so that it works whether make uses cmd or
30 sh as the shell.
31
b4289b64
MA
322011-05-06 Michael Albinus <michael.albinus@gmx.de>
33
34 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
35 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
36 is a constant.
37 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
38 a string. Handle both cases.
39 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
40 (Fdbus_register_method): Use Qinvalid_function.
41
af4c0e28
JB
422011-05-06 Juanma Barranquero <lekktu@gmail.com>
43
44 * makefile.w32-in: Update dependencies.
45 (LISP_H): Add inttypes.h and stdin.h.
46 (PROCESS_H): Add unistd.h.
47
c51453d9
EZ
482011-05-06 Eli Zaretskii <eliz@gnu.org>
49
50 * lread.c: Include limits.h (fixes the MS-Windows build broken by
51 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
52
8ff0ac3c 532011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 54
4c4b566b
PE
55 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
56
aab2b9b5
PE
57 * term.c (vfatal): Remove stray call to va_end.
58 It's not needed and the C Standard doesn't allow it here anyway.
59
c378da0b
PE
60 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
61 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
62
288b08c7
PE
63 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
64 bytes.
65
e3601888
PE
66 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
67
db6c0e74
PE
68 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
69
dd5963ea
PE
70 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
71
88c9450f
PE
72 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
73
2f9442b8
PE
74 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
75
c032b5f8
PE
76 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
77 * charset.c (Fdefine_charset_internal): Don't initialize
78 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 79 32-bit int (Bug#8600).
a108c10b
PE
80
81 * lread.c (read_integer): Be more consistent with string-to-number.
82 Use string_to_number to do the actual conversion; this avoids
83 rounding errors and fixes some other screwups. Without this fix,
84 for example, #x1fffffffffffffff was misread as -2305843009213693952.
85 (digit_to_number): Move earlier, for benefit of read_integer.
86 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 87 not a digit in any supported base. (Bug#8602)
a108c10b 88
ad5f9eea
PE
89 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
90
aec1708a
PE
91 * dispnew.c (scrolling_window): Return 1 if we scrolled,
92 to match comment at start of function. This also removes a
93 GCC warning about overflow in a 32+64-bit port.
94
47be4ab5
PE
95 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
96
371cac43
PE
97 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
98 Reported by Stefan Monnier in
99 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
100 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
101 SYMBOLP-guarded XSYMBOL, not XPNTR.
102
d01a7826
PE
103 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
104 (EMACS_UINTPTR): Likewise, with uintptr_t.
105
7fd47d5c
PE
106 * lisp.h: Prefer 64-bit EMACS_INT if available.
107 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
108 on 32-bit hosts that have 64-bit int, so that they can access
109 large files.
122b0c86
PE
110 However, temporarily disable this change unless the temporary
111 symbol WIDE_EMACS_INT is defined.
7fd47d5c 112
8727937b
PE
113 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
114
8ac068ac
PE
115 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
116 This removes an assumption that EMACS_INT and long are the same
117 width as pointers. The assumption is true for Emacs porting targets
118 now, but we want to make other targets possible.
119 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
120 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
121 In the rest of the code, change types of integers that hold casted
122 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
123 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
124 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
125 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
126 No need to cast type when ORing.
127 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
128 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
129 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
130 assume EMACS_INT is the same width as char *.
131 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
132 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
133 Remove no-longer-needed casts.
134 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
135 (xg_tool_bar_help_callback, xg_make_tool_item):
136 Use EMACS_INTPTR to hold an integer
137 that will be cast to void *; this can avoid a GCC warning
138 if EMACS_INT is not the same width as void *.
139 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
140 * xdisp.c (display_echo_area_1, resize_mini_window_1):
141 (current_message_1, set_message_1):
142 Use a local to convert to proper width without a cast.
143 * xmenu.c (dialog_selection_callback): Likewise.
144
ede49d71
PE
145 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
146 Also, don't assume VALBITS / RAND_BITS is less than 5,
147 and don't rely on undefined behavior when shifting a 1 left into
148 the sign bit.
149 * lisp.h (get_random): Change signature to match.
150
2f30ecd0
PE
151 * lread.c (hash_string): Use size_t, not int, for hash computation.
152 Normally we prefer signed values; but hashing is special, because
153 it's better to use unsigned division on hash table sizes so that
154 the remainder is nonnegative. Also, size_t is the natural width
155 for hashing into memory. The previous code used 'int', which doesn't
156 retain enough info to hash well into very large tables.
157 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
158
2a866e7b
PE
159 * dbusbind.c: Don't possibly lose pointer info when converting.
160 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
161 Use XPNTR rather than XHASH, so that the high-order bits of
162 the pointer aren't lost when converting through void *.
163
51639eac
PE
164 * eval.c (Fautoload): Don't double-shift a pointer.
165
92394119
PE
166 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
167
dbdb9a7c
JB
1682011-05-06 Juanma Barranquero <lekktu@gmail.com>
169
170 * gnutls.c (DEF_GNUTLS_FN):
171 * image.c (DEF_IMGLIB_FN): Make function pointers static.
172
db7a0b4f
AS
1732011-05-05 Andreas Schwab <schwab@linux-m68k.org>
174
175 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
176 marker. (Bug#8610)
177
f7ff1b0f 1782011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
179
180 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
181 New version that can reserve upto 2GB of heap space.
182
f7ff1b0f 1832011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
184
185 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
186
639c109b
TZ
1872011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
188
189 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
190 `gnutls_certificate_set_x509_key_file'.
191
d2127135
JB
1922011-05-05 Juanma Barranquero <lekktu@gmail.com>
193
194 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
195 Update dependencies.
196
e968f4f3
JB
1972011-05-04 Juanma Barranquero <lekktu@gmail.com>
198
199 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
200 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
201 Remove unused parameter `fildes'.
202 * process.c (read_process_output, send_process): Don't pass it.
203
84d358f0
JB
2042011-05-04 Juanma Barranquero <lekktu@gmail.com>
205
206 Fix previous change: the library cache is defined in w32.c.
207 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
208 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
209
0898ca10
JB
2102011-05-04 Juanma Barranquero <lekktu@gmail.com>
211
212 Implement dynamic loading of GnuTLS on Windows.
213
214 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
215 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
216 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
217 Declare.
218
219 * gnutls.c (Qgnutls_dll): Define.
220 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
221 (gnutls_*): Declare function pointers.
222 (init_gnutls_functions): New function to initialize function pointers.
223 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
224 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
225 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
226 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
227 (emacs_gnutls_write, emacs_gnutls_read)
228 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
229 (Fgnutls_available_p): New function.
230 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
231 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
232 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
233
234 * image.c: Include w32.h.
235 (Vimage_type_cache): Delete.
236 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
237 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
238 (w32_delayed_load): Move to w32.c.
239
240 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
241
242 * w32.c (QCloaded_from, Vlibrary_cache): Define.
243 (w32_delayed_load): Move from image.c. When loading a library, record
244 its filename in the :loaded-from property of the library id.
245 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
246 Initialize and staticpro them.
247 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
248
249 * process.c: Include lisp.h before w32.h, not after.
250 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
251 instead of gnutls_record_check_pending.
252
253 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
254
ff4de4aa
TZ
2552011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
256
257 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
258 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
259 as passed in.
260
abe95abb
JD
2612011-05-03 Jan Djärv <jan.h.d@swipnet.se>
262
263 * xterm.c (x_set_frame_alpha): Do not set property on anything
264 else than FRAME_X_OUTER_WINDOW (Bug#8608).
265
e16e55d4
JB
2662011-05-02 Juanma Barranquero <lekktu@gmail.com>
267
268 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
269
bafcf6a5
JB
2702011-05-02 Juanma Barranquero <lekktu@gmail.com>
271
272 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
273 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
274 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
275 (gnutls_global_initialized, Qgnutls_bootprop_priority)
276 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
277 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
278 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
279 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
280 (Qgnutls_bootprop_callbacks_verify): Make static.
281
e7a6747f
AS
2822011-05-01 Andreas Schwab <schwab@linux-m68k.org>
283
19ed11ba
AS
284 * callproc.c: Indentation fixup.
285
e7a6747f
AS
286 * sysdep.c (wait_for_termination_1): Make static.
287 (wait_for_termination, interruptible_wait_for_termination): Move
288 after wait_for_termination_1.
289
1ef14cb4
LMI
2902011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
291
292 * sysdep.c (interruptible_wait_for_termination): New function
293 which is like wait_for_termination, but allows keyboard
294 interruptions.
295
296 * callproc.c (Fcall_process): Add (:file "file") as an option for
297 the STDOUT buffer.
298 (Fcall_process_region): Ditto.
299
330d880c
EZ
3002011-04-30 Eli Zaretskii <eliz@gnu.org>
301
8db90b73
EZ
302 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
303 rather than `XVECTOR (FOO)->size'.
304
330d880c
EZ
305 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
306 inttypes.h, as a gnulib replacement is used if it not available in
307 system headers.
308
15cbd324
EZ
3092011-04-21 Eli Zaretskii <eliz@gnu.org>
310
311 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
312 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
313 of MOST_POSITIVE_FIXNUM. (Bug#8528)
314
315 * coding.c (coding_alloc_by_realloc): Error out if destination
316 will grow beyond MOST_POSITIVE_FIXNUM.
317 (decode_coding_emacs_mule): Abort if there isn't enough place in
318 charbuf for the composition carryover bytes. Reserve an extra
319 space for up to 2 characters produced in a loop.
320 (decode_coding_iso_2022): Abort if there isn't enough place in
321 charbuf for the composition carryover bytes.
322
3232011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 324
ae940cca
EZ
325 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
326 aborting when %lld or %lll format is passed.
327 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
328 %llo or %llx format is passed. (Bug#8545)
329
03ab8921
EZ
330 * window.c (window_scroll_line_based): Use a marker instead of
331 simple variables to record original value of point. (Bug#7952)
332
afda1437
EZ
333 * doprnt.c (doprnt): Fix the case where a multibyte sequence
334 produced by %s or %c overflows available buffer space. (Bug#8545)
335
f76dee0c
PE
3362011-04-28 Paul Eggert <eggert@cs.ucla.edu>
337
338 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 339 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 340
fdc5744d
JB
3412011-04-28 Juanma Barranquero <lekktu@gmail.com>
342
343 * w32.c (init_environment): Warn about defaulting HOME to C:\.
344
638f053a
JB
3452011-04-28 Juanma Barranquero <lekktu@gmail.com>
346
347 * keyboard.c (Qdelayed_warnings_hook): Define.
348 (command_loop_1): Run `delayed-warnings-hook'
349 if Vdelayed_warnings_list is non-nil.
350 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
351 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
352
d178f871
EZ
3532011-04-28 Eli Zaretskii <eliz@gnu.org>
354
355 * doprnt.c (doprnt): Don't return value smaller than the buffer
356 size if the message was truncated. (Bug#8545).
357
b124fd93
JB
3582011-04-28 Juanma Barranquero <lekktu@gmail.com>
359
360 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
361 (Fx_window_property): #if-0 the whole functions, not just the bodies.
362
e810457d
PE
3632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
364
365 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
366
ea51cceb
JB
3672011-04-27 Juanma Barranquero <lekktu@gmail.com>
368
369 * makefile.w32-in: Update dependencies.
370
94dcfacf
EZ
3712011-04-27 Eli Zaretskii <eliz@gnu.org>
372
373 Improve `doprnt' and its usage. (Bug#8545)
374 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
375 `format_end'. Remove support for %l as a conversion specifier.
376 Don't use xrealloc. Improve diagnostics when the %l size modifier
377 is used. Update the commentary.
378
379 * eval.c (verror): Simplify calculation of size_t.
380
381 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
382 messages.
383
f61f41d7
PE
3842011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
385
386 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
387 change.
388
96fb4434
PE
3892011-04-27 Paul Eggert <eggert@cs.ucla.edu>
390
391 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
392 This makes this file independent of the recent pseudovector change.
393
671875da 3942011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 395
69e9b5a3
PE
396 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
397
b5f869a7 398 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 399 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 400 Remove unused local.
c8926152 401 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 402
841a1577 403 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
404 GCC 4.6.0 optimizes based on type-based alias analysis. For
405 example, if b is of type struct buffer * and v of type struct
406 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
407 != &v->size, and therefore "v->size = 1; b->size = 2; return
408 v->size;" must therefore return 1. This assumption is incorrect
409 for Emacs, since it type-puns struct Lisp_Vector * with many other
410 types. To fix this problem, this patch adds a new type struct
f904488f 411 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
412 and pseudovectors, and helps optimizing compilers not get fooled
413 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
414 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
415 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
416 the size member.
eab3844f
PE
417 (XSETPVECTYPE): Rewrite in terms of new macro.
418 (XSETPVECTYPESIZE): New macro, specifying both type and size.
419 This is a bit clearer, and further avoids the possibility of
420 undesirable aliasing.
421 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 422 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
423 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
424 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
425 (ASIZE): Now uses header.size rather than size. All
426 previous uses of XVECTOR (foo)->size replaced to use this macro,
427 to avoid the hassle of writing XVECTOR (foo)->header.size.
428 (struct vectorlike_header): New type.
eab3844f
PE
429 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
430 object, to help avoid aliasing.
431 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
432 (SUBRP): Likewise, since Lisp_Subr is a special case.
433 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
434 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
435 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 436 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
437 changed to be "header.size" and "header.next".
438 * buffer.h (struct buffer): Likewise.
439 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
440 * frame.h (struct frame): Likewise.
441 * process.h (struct Lisp_Process): Likewise.
442 * termhooks.h (struct terminal): Likewise.
443 * window.c (struct save_window_data, struct saved_window): Likewise.
444 * window.h (struct window): Likewise.
445 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
446 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
447 * buffer.c (init_buffer_once): Likewise.
448 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
449 special case.
450 * process.c (Fformat_network_address): Use local var for size,
451 for brevity.
452
0df1eac5
PE
453 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
454
847ab9d1 455 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
456 * data.c (atof): Remove decl; no longer used or needed.
457 (digit_to_number): Move to lread.c.
458 (Fstring_to_number): Use new string_to_number function, to be
459 consistent with how the Lisp reader treats infinities and NaNs.
460 Do not assume that floating-point numbers represent EMACS_INT
461 without losing information; this is not true on most 64-bit hosts.
462 Avoid double-rounding errors, by insisting on integers when
463 parsing non-base-10 numbers, as the documentation specifies.
464 * lisp.h (string_to_number): New decl, replacing ...
465 (isfloat_string): Remove.
bc0a5c13 466 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 467 (read1): Do not accept +. and -. as integers; this
452f4150
PE
468 appears to have been a coding error. Similarly, do not accept
469 strings like +-1e0 as floating point numbers. Do not report
470 overflow for integer overflows unless the base is not 10 which
471 means we have no simple and reliable way to continue.
472 Break out the floating-point parsing into a new
473 function string_to_number, so that Fstring_to_number parses
474 floating point numbers consistently with the Lisp reader.
475 (digit_to_number): Moved here from data.c. Make it static inline.
476 (E_CHAR, EXP_INT): Remove, replacing with ...
477 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
478 (string_to_number): New function, replacing isfloat_string.
479 This function checks for valid syntax and produces the resulting
480 Lisp float number too. Rework it so that string-to-number
bc0a5c13 481 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
482 so that overflow for non-base-10 numbers is reported only when
483 there's no portable and simple way to convert to floating point.
452f4150 484
67769ffc
PE
485 * textprop.c (set_text_properties_1): Rewrite for clarity,
486 and to avoid GCC warning about integer overflow.
487
c20db43f
PE
488 * intervals.h (struct interval): Use EMACS_INT for members
489 where EMACS_UINT might cause problems. See
490 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
491 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
492 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
493 All uses changed.
37aa2f85
PE
494 (offset_intervals): Tell GCC not to worry about length overflow
495 when negating a negative length.
c20db43f 496
2538aa2f
PE
497 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
498 (overrun_check_free): Likewise.
499
f2d3008d
PE
500 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
501 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
502 word size.
503
ec8df744
PE
504 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
505 (gnutls_make_error): Rename local to avoid shadowing.
506 (gnutls_emacs_global_deinit): ifdef out; not used.
507 (Fgnutls_boot): Use const for pointer to readonly storage.
508 Comment out unused local. Fix pointer signedness problems.
509
640ee02d
PE
510 * lread.c (openp): Don't stuff size_t into an 'int'.
511 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
512 about possible signed overflow.
513
6048fb2a
PE
514 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
515 (GDK_KEY_g): Don't define if already defined.
516 (xg_prepare_tooltip): Avoid pointer signedness problem.
517 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
518
fa3c87e1
PE
519 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
520 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
521
2172544b
PE
522 * xfns.c (Fx_window_property): Simplify a bit,
523 to make a bit faster and to avoid GCC 4.6.0 warning.
524 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
525
9b821a21
PE
526 * fns.c (internal_equal): Don't assume size_t fits in int.
527
3c616cfa
PE
528 * alloc.c (compact_small_strings): Tighten assertion a little.
529
c2982e87
PE
530 Replace pEd with more-general pI, and fix some printf arg casts.
531 * lisp.h (pI): New macro, generalizing old pEd macro to other
532 conversion specifiers. For example, use "...%"pI"d..." rather
533 than "...%"pEd"...".
534 (pEd): Remove. All uses replaced with similar uses of pI.
535 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
536 * alloc.c (check_pure_size): Don't overflow by converting size to int.
537 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
538 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
539 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
540 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
541 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
542 64-bit hosts.
543 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
544 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
545 * print.c (safe_debug_print, print_object): Likewise.
546 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
547 to int.
6f04d126
PE
548 Use pI instead of if-then-else-abort. Use %p to avoid casts,
549 avoiding the 0 flag, which is not portable.
c2982e87
PE
550 * process.c (Fmake_network_process): Use pI to avoid cast.
551 * region-cache.c (pp_cache): Likewise.
552 * xdisp.c (decode_mode_spec): Likewise.
553 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
554 behavior on 64-bit hosts with printf arg.
6f04d126 555 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
556 (x_stop_queuing_selection_requests): Likewise.
557 (x_get_window_property): Don't truncate byte count to an 'int'
558 when tracing.
0b432f21 559
5e073ec7
PE
560 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
561 here, since it parses constructs like leading '-' and spaces,
562 which are not wanted; and it overflows with large numbers.
563 Instead, simply match F[0-9]+, which is what is wanted anyway.
564
36372bf9
PE
565 * alloc.c: Remove unportable assumptions about struct layout.
566 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
567 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
568 (allocate_vectorlike, make_pure_vector): Use the new macros,
569 plus offsetof, to remove unportable assumptions about struct layout.
570 These assumptions hold on all porting targets that I know of, but
571 they are not guaranteed, they're easy to remove, and removing them
572 makes further changes easier.
573
0b432f21
PE
574 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
575 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
576 (string_overrun_cookie): Now const. Use initializers that
577 don't formally overflow signed char, to avoid warnings.
000098c1
PE
578 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
579 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
580 (allocate_buffer): Don't assume sizeof (struct buffer) is a
581 multiple of sizeof (EMACS_INT); it need not be, if
582 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 583 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 584
895009e1
JB
5852011-04-26 Juanma Barranquero <lekktu@gmail.com>
586
587 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
588
6a7a1b0b
TZ
5892011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
590
591 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 592 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
593 Reported by Paul Eggert <eggert@cs.ucla.edu>.
594
841a1577 5952011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
596
597 * lisp.h (Qdebug): List symbol.
895009e1 598 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
599 * keyboard.c (debug-on-event): New variable.
600 (handle_user_signal): Break into debugger when debug-on-event
601 matches the current signal symbol.
602
f2d3ba6f
DN
6032011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
604
605 * alloc.c (check_sblock, check_string_bytes)
606 (check_string_free_list): Convert to standard C.
607
42ce4c63
TZ
6082011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
609
610 * w32.c (emacs_gnutls_push): Fix typo.
611
825cd63c
EZ
6122011-04-25 Eli Zaretskii <eliz@gnu.org>
613
fb11d64d
EZ
614 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
615 "cast to pointer from integer of different size".
616
825cd63c
EZ
617 Improve doprnt and its use in verror. (Bug#8545)
618 * doprnt.c (doprnt): Document the set of format control sequences
619 supported by the function. Use SAFE_ALLOCA instead of always
620 using `alloca'.
621
622 * eval.c (verror): Don't limit the buffer size at size_max-1, that
623 is one byte too soon. Don't use xrealloc; instead xfree and
624 xmalloc anew.
625
e061a11b
TZ
6262011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
627
628 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
629 callbacks stage.
630
631 * gnutls.c: Renamed global_initialized to
632 gnutls_global_initialized. Added internals for the
633 :verify-hostname-error, :verify-error, and :verify-flags
634 parameters of `gnutls-boot' and documented those parameters in the
635 docstring. Start callback support.
636 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
637 unless a fatal error occured. Call gnutls_alert_send_appropriate
638 on error. Return error code.
639 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
640 (emacs_gnutls_read): Likewise.
641 (Fgnutls_boot): Return handshake error code.
642 (emacs_gnutls_handle_error): New function.
643 (wsaerror_to_errno): Likewise.
644
645 * w32.h (emacs_gnutls_pull): Add prototype.
646 (emacs_gnutls_push): Likewise.
647
648 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
649 (emacs_gnutls_push): Likewise.
650
6512011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
652
653 * process.c (wait_reading_process_output): Check if GnuTLS
654 buffered some data internally if no FDs are set for TLS
655 connections.
656
657 * makefile.w32-in (OBJ2): Add gnutls.$(O).
658 (LIBS): Link to USER_LIBS.
659 ($(BLD)/gnutls.$(0)): New target.
660
fa6996bc
EZ
6612011-04-24 Eli Zaretskii <eliz@gnu.org>
662
eb35682e
EZ
663 * xdisp.c (handle_single_display_spec): Rename the
664 display_replaced_before_p argument into display_replaced_p, to
665 make it consistent with the commentary. Fix typos in the
666 commentary.
667
e2ad650c
EZ
668 * textprop.c (syms_of_textprop): Remove dead code.
669 (copy_text_properties): Delete obsolete commentary about an
670 interface that was deleted long ago. Fix typos in the description
671 of arguments.
672
1b2de274
EZ
673 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
674 to changes in oldXMenu/XMenu.h from 2011-04-16.
675 <menu_help_message, prev_menu_help_message>: Constify.
676 (IT_menu_make_room): menu->help_text is now `const char **';
677 adjust.
678
679 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
680 to changes in oldXMenu/XMenu.h from 2011-04-16.
681 (struct XMenu): Declare `help_text' `const char **'.
682
683 * xfaces.c <Qunspecified>: Make extern again.
684
685 * syntax.c: Include sys/types.h before including regex.h, as
686 required by Posix.
687
762b15be
EZ
688 * doc.c (get_doc_string): Improve the format passed to `error'.
689
690 * doprnt.c (doprnt): Improve commentary.
691
692 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
693
694 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
695 them with etags.
696
f1052e5d
EZ
697 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
698 changes in globals.h immediately force recompilation.
762b15be
EZ
699 (TAGS): Depend on $(CURDIR)/m/intel386.h and
700 $(CURDIR)/s/ms-w32.h.
701 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 702
fa6996bc
EZ
703 * character.c (Fchar_direction): Function deleted.
704 (syms_of_character): Don't defsubr it.
705 <char-direction-table>: Deleted.
706
e6c3da20
EZ
7072011-04-23 Eli Zaretskii <eliz@gnu.org>
708
709 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
710 * doprnt.c: Include limits.h.
711 (SIZE_MAX): New macro.
712 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
713 local variables are now size_t instead of int or unsigned.
714 Improve overflow protection. Support `l' modifier for integer
715 conversions. Support %l conversion. Don't assume an EMACS_INT
716 argument for integer conversions and for %c.
717
718 * lisp.h (doprnt): Restore prototype.
719
720 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
721 $(SRC)/character.h.
722
723 * Makefile.in (base_obj): Add back doprnt.o.
724
725 * deps.mk (doprnt.o): Add back prerequisites.
726 (callint.o): Depend on character.h.
727
728 * eval.c (internal_lisp_condition_case): Include the handler
729 representation in the error message.
730 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
731 when breaking from the loop.
732
733 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
734
735 * callint.c (Fcall_interactively): When displaying error message
736 about invalid control letter, pass the character's codepoint, not
737 a pointer to its multibyte form. Improve display of the character
738 in octal and display also its hex code.
739
740 * character.c (char_string): Use %x to display the (unsigned)
741 codepoint of an invalid character, to avoid displaying a bogus
742 negative value.
743
744 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
745 `error', not SYMBOL_NAME itself.
746
747 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
748 character arguments to `error'.
749
750 * charset.c (check_iso_charset_parameter): Fix incorrect argument
751 to `error' in error message about FINAL_CHAR argument. Make sure
752 FINAL_CHAR is a character, and use %c when it is passed as
753 argument to `error'.
754
4ffd0d6b 7552011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
756
757 * s/ms-w32.h (localtime): Redirect to sys_localtime.
758
759 * w32.c: Include <time.h>.
760 (sys_localtime): New function.
761
4ffd0d6b 7622011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
763
764 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
765
4ffd0d6b 766 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 767
4ffd0d6b 7682011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 769
4ffd0d6b
GM
770 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
771 zombies (Bug#8467).
aac0c6e3 772
04c56954
EZ
7732011-04-19 Eli Zaretskii <eliz@gnu.org>
774
775 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
776 gl_state.e_property when gl_state.object is Qt.
777
778 * insdel.c (make_gap_larger): Remove limitation of buffer size
779 to <= INT_MAX.
780
16a43933
CY
7812011-04-18 Chong Yidong <cyd@stupidchicken.com>
782
783 * xdisp.c (lookup_glyphless_char_display)
784 (produce_glyphless_glyph): Handle cons cell entry in
785 glyphless-char-display.
786 (Vglyphless_char_display): Document it.
787
788 * term.c (produce_glyphless_glyph): Handle cons cell entry in
789 glyphless-char-display.
790
4581706e
CY
7912011-04-17 Chong Yidong <cyd@stupidchicken.com>
792
793 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
794
795 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
796
797 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
798 definition for no-X builds.
799
4887c6e2 8002011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 801
fd35b6f9
PE
802 Static checks with GCC 4.6.0 and non-default toolkits.
803
5c1ccb01
PE
804 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
805
006c5daa
PE
806 * process.c (keyboard_bit_set): Define only if SIGIO.
807 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
808 (send_process): Repair possible setjmp clobbering.
809
efc736d3
PE
810 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
811
4e2fe2e6
PE
812 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
813
f97334a2
PE
814 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
815
4e75f29d
PE
816 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
817 Define only if needed.
818
90efadd1
PE
819 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
820 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 821 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 822
3c647824
PE
823 * dispextern.h (struct redisplay_interface): Rename param
824 to avoid shadowing.
e264f262 825 * termhooks.h (struct terminal): Likewise.
761383f4 826 * xterm.c (xembed_send_message): Likewise.
3c647824 827
b58c5c4a
PE
828 * insdel.c (make_gap_smaller): Define only if
829 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
830
cad59032
PE
831 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
832 it.
833
c339dc2e
PE
834 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
835 so that we aren't warned about unused symbols.
836
91a3e27b
PE
837 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
838
399c71d3 839 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 840
8ffc96f5
PE
841 * xfns.c (x_real_positions): Mark locals as initialized.
842
eef9bc79
PE
843 * xmenu.c (xmenu_show): Don't use uninitialized vars.
844
098db9dd
PE
845 * xterm.c: Fix problems found by static analysis with other toolkits.
846 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
847 (x_dispatch_event): Declare static if USE_GTK, and
848 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 849 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 850 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
851 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
852 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 853
eb18f6cc
PE
854 * xmenu.c (menu_help_callback): Pointer type fixes.
855 Use const pointers when pointing at readonly data. Avoid pointer
856 signedness clashes.
857 (FALSE): Remove unused macro.
858 (update_frame_menubar): Remove unused decl.
859
1fe72bf8
PE
860 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
861
60d9e1db
PE
862 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
863 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
864 (single_menu_item): Rename local to avoid shadowing.
865
39261c26
PE
866 * keyboard.c (make_lispy_event): Remove unused local var.
867
018c5e19
PE
868 * frame.c, frame.h (x_get_resource_string): Bring this back, but
869 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
870
63d2b86e
PE
871 * bitmaps: Change bitmaps from unsigned char back to the X11
872 compatible char. Avoid the old compiler warnings about
873 out-of-range initializers by using, for example, '\xab' rather
874 than 0xab.
875
aefd87e1
PE
876 * xgselect.c (xgselect_initialize): Check vs interface
877 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
878
bf501fb9
PE
879 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
880
e9829fdf
PE
881 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
882 to read-only memory.
883
1086c095
PE
884 * fns.c (vector): Remove; this old hack is no longer needed.
885
2baccd04 886 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 887 Remove unused var.
dde42981 888 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 889
72391843 890 * xrdb.c (x_load_resources): Omit unused local.
3565b346 891
436c16df 892 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 893 (x_window): Rename locals to avoid shadowing.
dc5ddd85 894 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 895
92bb796d 896 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 897 (x_term_init): Remove local to avoid shadowing.
92bb796d 898
764430a3 899 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
900
901 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
902 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
903
d1dfb56c
EZ
9042011-04-16 Eli Zaretskii <eliz@gnu.org>
905
c4354cb4
EZ
906 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
907
d1dfb56c
EZ
908 Fix regex.c, syntax.c and friends for buffers > 2GB.
909 * syntax.h (struct gl_state_s): Declare character position members
910 EMACS_INT.
911
912 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
913
914 * textprop.c (verify_interval_modification, interval_of): Declare
915 arguments EMACS_INT.
916
917 * intervals.c (adjust_intervals_for_insertion): Declare arguments
918 EMACS_INT.
919
920 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
921
922 * indent.c (Fvertical_motion): Local variable it_start is now
923 EMACS_INT.
924
925 * regex.c (re_match, re_match_2, re_match_2_internal)
926 (bcmp_translate, regcomp, regexec, print_double_string)
927 (group_in_compile_stack, re_search, re_search_2, regex_compile)
928 (re_compile_pattern, re_exec): Declare arguments and local
929 variables `size_t' and `ssize_t' and return values `regoff_t', as
930 appropriate.
931 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
932 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
933 <compile_stack_type>: `size' and `avail' are now `size_t'.
934
935 * regex.h <regoff_t>: Use ssize_t, not int.
936 (re_search, re_search_2, re_match, re_match_2): Arguments that
937 specify buffer/string position and length are now ssize_t and
938 size_t. Return type is regoff_t.
939
613052cd
BK
9402011-04-16 Ben Key <bkey76@gmail.com>
941
942 * nsfont.m: Fixed bugs in ns_get_family and
943 ns_descriptor_to_entity that were caused by using free to
944 deallocate memory blocks that were allocated by xmalloc (via
945 xstrdup). This caused Emacs to crash when compiled with
946 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
947 --enable-checking=xmallocoverrun). xfree is now used to
948 deallocate these memory blocks.
949
4170f62f 9502011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 951
71b41406
PE
952 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
953
9587a89d
PE
954 emacs_write: Accept and return EMACS_INT for sizes.
955 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
956 et seq.
957 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
958 Accept and return EMACS_INT.
959 (emacs_gnutls_write): Return the number of bytes written on
960 partial writes.
961 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
962 (emacs_read, emacs_write): Remove check for negative size, as the
963 Emacs source code has been audited now.
9587a89d
PE
964 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
965 (emacs_read, emacs_write): Use it.
273a5f82
PE
966 * process.c (send_process): Adjust to the new signatures of
967 emacs_write and emacs_gnutls_write. Do not attempt to store
968 a byte offset into an 'int'; it might overflow.
9587a89d 969 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 970
3e047f51
PE
971 * sound.c: Don't assume sizes fit in 'int'.
972 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 973 Return EMACS_INT, not int.
3e047f51 974 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
975 Accept EMACS_INT, not int.
976 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
977 record read return values.
978
cc39a9db
BK
9792011-04-15 Ben Key <bkey76@gmail.com>
980
c9d0ec6d
JB
981 * keyboard.c (Qundefined): Don't declare static since it is used
982 in nsfns.m.
983 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
984 static since they are used in nsfont.m.
cc39a9db 985
6c60eb9f
SM
9862011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
987
988 * process.c (Qprocessp): Don't declare static.
989 * lisp.h (Qprocessp): Declare again.
990
7990b61a
JB
9912011-04-15 Juanma Barranquero <lekktu@gmail.com>
992
993 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
994
5d4cb038
PE
9952011-04-14 Paul Eggert <eggert@cs.ucla.edu>
996
8bd7b830 997 Improve C-level modularity by making more things 'static'.
cd64ea1d 998
e3b27b31
PE
999 Don't publish debugger-only interfaces to other modules.
1000 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1001 (verify_bytepos, count_markers): Move decls to the only modules
1002 that need them.
1003 * region-cache.h (pp_cache): Likewise.
1004 * window.h (check_all_windows): Likewise.
1005 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1006
5d4cb038
PE
1007 * sysdep.c (croak): Now static, if
1008 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1009 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1010
1011 * alloc.c (refill_memory_reserve): Now static if
1012 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1013 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1014
e87b6180
PE
1015 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1016 Define only if USE_LUCID.
1017
ac64929e
PE
1018 * xrdb.c (x_customization_string, x_rm_string): Now static.
1019
6f37259d
PE
1020 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1021 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1022
1683e3ab
PE
1023 * xdisp.c (draw_row_with_mouse_face): Now static.
1024 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1025
de9c2632
PE
1026 * window.h (check_all_windows): Mark externally visible.
1027
2b96acb7
PE
1028 * window.c (window_deletion_count): Now static.
1029
1030 * undo.c: Make symbols static if they're not exported.
1031 (last_undo_buffer, last_boundary_position, pending_boundary):
1032 Now static.
1033
50436f33
PE
1034 * textprop.c (interval_insert_behind_hooks): Now static.
1035 (interval_insert_in_front_hooks): Likewise.
1036
64520e5c
PE
1037 * term.c: Make symbols static if they're not exported.
1038 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1039 (max_frame_lines, tty_set_terminal_modes):
1040 (tty_reset_terminal_modes, tty_turn_off_highlight):
1041 (get_tty_terminal): Now static.
1042 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1043 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1044 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1045 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1046 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1047
1fa53021
PE
1048 * sysdep.c: Make symbols static if they're not exported.
1049 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1050 Now static.
1051 (sigprocmask_set, full_mask): Remove; unused.
1052 (wait_debugging): Mark as visible.
1053 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1054 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1055
d4b43b22
PE
1056 * syntax.c (syntax_temp): Define only if !__GNUC__.
1057
b7c513d0
PE
1058 * sound.c (current_sound_device, current_sound): Now static.
1059
989b29ad
PE
1060 * search.c (searchbufs, searchbuf_head): Now static.
1061
13a55a78
PE
1062 * scroll.c (scroll_cost): Remove; unused.
1063 * dispextern.h (scroll_cost): Remove decl.
1064
de68a1fc
PE
1065 * region-cache.h (pp_cache): Mark as externally visible.
1066
40ccffa6
PE
1067 * process.c: Make symbols static if they're not exported.
1068 (process_tick, update_tick, create_process, chan_process):
1069 (Vprocess_alist, proc_buffered_char, datagram_access):
1070 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1071 (deactivate_process): Mark defn as static, as well as decl.
1072 * lisp.h (create_process): Remove decl.
1073 * process.h (chan_process, Vprocess_alist): Remove decls.
1074
ad64fc97
PE
1075 * print.c: Make symbols static if they're not exported.
1076 (print_depth, new_backquote_output, being_printed, print_buffer):
1077 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1078 (print_interval, print_number_index, initial_stderr_stream):
1079 Now static.
1080 * lisp.h (Fprinc): Remove decl.
1081 (debug_output_compilation_hack): Mark as externally visible.
1082
adddb265
PE
1083 * sysdep.c (croak): Move decl from here to syssignal.h.
1084 * syssignal.h (croak): Put it here, so the API can be checked when
1085 'croak' is called from dissociate_if_controlling_tty.
1086
1717ede2
PE
1087 * minibuf.c: Make symbols static if they're not exported.
1088 (minibuf_save_list, choose_minibuf_frame): Now static.
1089 * lisp.h (choose_minibuf_frame): Remove decl.
1090
fa5fb2bc
PE
1091 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1092
1e3890d1
PE
1093 * lread.c: Make symbols static if they're not exported.
1094 (read_objects, initial_obarray, oblookup_last_bucket_number):
1095 Now static.
1096 (make_symbol): Remove; unused.
1097 * lisp.h (initial_obarray, make_symbol): Remove decls.
1098
8a1414fa
PE
1099 * keyboard.c: Make symbols static if they're not exported.
1100 (single_kboard, recent_keys_index, total_keys, recent_keys):
1101 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1102 (this_single_command_key_start, echoing, last_auto_save):
1103 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1104 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1105 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1106 (Vlispy_mouse_stem, double_click_count):
1107 Now static.
1108 (force_auto_save_soon): Define only if SIGDANGER.
1109 (ignore_mouse_drag_p): Now static if
1110 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1111 (print_help): Remove; unused.
1112 (stop_character, last_timer_event): Mark as externally visible.
1113 * keyboard.h (ignore_mouse_drag_p): Declare only if
1114 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1115 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1116 * lisp.h (echoing): Remove decl.
1117 (force_auto_save_soon): Declare only if SIGDANGER.
1118 * xdisp.c (redisplay_window): Simplify code, to make it more
1119 obvious that ignore_mouse_drag_p is not accessed if !defined
1120 USE_GTK && !defined HAVE_NS.
1121
93ea6e8f
PE
1122 * intervals.c: Make symbols static if they're not exported.
1123 (merge_properties_sticky, merge_interval_right, delete_interval):
1124 Now static.
1125 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1126
77382fcc
PE
1127 * insdel.c: Make symbols static if they're not exported.
1128 However, leave prepare_to_modify_buffer alone. It's never
1129 called from outside this function, but that appears to be a bug.
1130 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1131 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1132 (adjust_after_replace_noundo): Remove; unused.
1133 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1134 (signal_before_change): Remove decls.
77382fcc 1135
9306c32e
PE
1136 * indent.c (val_compute_motion, val_vmotion): Now static.
1137
cd44d2eb
PE
1138 * image.c: Make symbols static if they're not exported.
1139 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1140 if USE_GTK.
1141 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1142 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1143
ad9a7a06
PE
1144 * fringe.c (standard_bitmaps): Now static.
1145 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1146
81626931
PE
1147 * frame.c: Make symbols static if they're not exported.
1148 (x_report_frame_params, make_terminal_frame): Now static.
1149 (get_frame_param): Now static, unless HAVE_NS.
1150 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1151 (x_get_resource_string): Remove; not used.
1152 * frame.h (make_terminal_frame, x_report_frame_params):
1153 (x_get_resource_string); Remove decls.
1154 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1155 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1156
239f9db9
PE
1157 * font.c, fontset.c: Make symbols static if they're not exported.
1158 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1159 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1160 * font.c (font_close_object): Now static.
1161 * font.h (font_close_object): Remove.
1162 * fontset.c (FONTSET_OBJLIST): Remove.
1163 (free_realized_fontset) #if-0 the body, which does nothing.
1164 (face_suitable_for_char_p): #if-0, as it's never called.
1165 * fontset.h (face_suitable_for_char_p): Remove decl.
1166 * xfaces.c (face_at_string_position): Use
1167 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1168 since 0 is always ASCII.
1169
dfcf3579
PE
1170 * fns.c (weak_hash_tables): Now static.
1171
5045092b
PE
1172 * fileio.c: Make symbols static if they're not exported.
1173 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1174 (Vwrite_region_annotation_buffers): Now static.
1175
57a96f5c
PE
1176 * eval.c: Make symbols static if they're not exported.
1177 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1178 * lisp.h (backtrace_list): Remove decl.
1179
35f08c38
PE
1180 * emacs.c: Make symbols static if they're not exported.
1181 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1182 (fatal_error_code, fatal_error_signal_hook, standard_args):
1183 Now static.
1184 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1185 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1186 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1187 * lisp.h (fatal_error_signal_hook): Remove decl.
1188 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1189
f44bd759
PE
1190 * editfns.c: Move a (normally-unused) function to its only use.
1191 * editfns.c, lisp.h (get_operating_system_release): Remove.
1192 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1193 worth the hassle of breaking this out.
1194
b532497d
PE
1195 * xterm.c: Make symbols static if they're not exported.
1196 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1197 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1198 (x_destroy_window, x_delete_display):
1199 Now static.
1200 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1201 (x_mouse_leave): Remove; unused.
1202 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1203 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1204 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1205 Remove decls.
1206 (x_mouse_leave): Declare only if WINDOWSNT.
1207 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1208 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1209 USE_X_TOOLKIT.
1210
1675728f
PE
1211 * ftxfont.c: Make symbols static if they're not exported.
1212 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1213 HAVE_FREETYPE.
1214 * font.h (ftxfont_driver): Likewise.
1215
e4cebfca
PE
1216 * xfns.c: Make symbols static if they're not exported.
1217 (x_last_font_name, x_display_info_for_name):
1218 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1219 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1220 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1221 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1222 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1223 (last_show_tip_args): Now static.
1224 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1225 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1226 (x_screen_planes): Remove; unused.
1227 * dispextern.h (x_screen_planes): Remove decl.
1228
5bf46f05
PE
1229 * dispnew.c: Make symbols static if they're not exported.
1230 * dispextern.h (redraw_garbaged_frames, scrolling):
1231 (increment_row_positions): Remove.
1232 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1233 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1234 Now static.
1235 (redraw_garbaged_frames): Remove; unused.
1236
435f4c28
PE
1237 * xfaces.c: Make symbols static if they're not exported.
1238 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1239 Remove decls.
1240 * xterm.h (defined_color): Remove decls.
1241 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1242 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1243 (menu_face_changed_default, defined_color, free_realized_face):
1244 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1245 (ascii_face_of_lisp_face): Remove; unused.
1246
8524aef3
PE
1247 * xdisp.c: Make symbols static if they're not exported.
1248 * dispextern.h (scratch_glyph_row, window_box_edges):
1249 (glyph_to_pixel_coords, set_cursor_from_row):
1250 (get_next_display_element, set_iterator_to_next):
1251 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1252 (show_mouse_face): Remove decls
1253 * frame.h (message_buf_print): Likewise.
1254 * lisp.h (pop_message, set_message, check_point_in_composition):
1255 Likewise.
1256 * xterm.h (set_vertical_scroll_bar): Likewise.
1257 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1258 (message_buf_print, scratch_glyph_row, displayed_buffer):
1259 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1260 (get_next_display_element, show_mouse_face, window_box_edges):
1261 (frame_to_window_pixel_xy, check_point_in_composition):
1262 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1263 (glyph_to_pixel_coords): Remove; unused.
1264
16390cd2
PE
1265 * dired.c (file_name_completion): Now static.
1266
1267 * dbusbind.c (xd_in_read_queued_messages): Now static.
1268
a25f4dfa
PE
1269 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1270 * data.c (circular_list_error): Remove.
1271
14a9c8df
PE
1272 * commands.h (last_point_position, last_point_position_buffer):
1273 (last_point_position_window): Remove decls.
1274 * keyboard.c: Make these variables static.
1275
74ab6df5
PE
1276 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1277 decls.
1278 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1279 (iso_code_class, detect_coding, code_convert_region): Now static.
1280 (encode_coding_gap): Remove; unused.
1281
38dfbee1
PE
1282 * chartab.c (chartab_chars, chartab_bits): Now static.
1283
a2cb4e63
PE
1284 * charset.h (charset_iso_8859_1): Remove decl.
1285 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1286 Now static.
1287
127198fd
PE
1288 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1289 * ccl.c (Vccl_program_table): Now static.
1290 (check_ccl_update): Remove; unused.
1291
d85b608f
PE
1292 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1293 * category.h: ... from here.
1294 * category.c (check_category_table, set_category_set): Now static.
1295
31cd66f3
PE
1296 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1297 * lisp.h: Remove these decls.
1298
c358e587
PE
1299 * buffer.c (buffer_count): Remove unused var.
1300
e78aecca
PE
1301 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1302 so that it's not optimized away.
1303 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1304 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1305 exported only to the debugger.
1306
e192d7d3
PE
1307 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1308 * atimer.h (run_all_atimers): Removed; not exported.
1309
92470028
PE
1310 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1311 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1312 was inaccessible from Lisp.
1313 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1314 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1315
244ed907
PE
1316 alloc.c: Import and export fewer symbols, and remove unused items.
1317 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1318 is defined.
1319 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1320 it's not optimized away by whole-program optimization.
1321 (message_enable_multibyte, free_misc): Remove.
1322 (catchlist, handlerlist, mark_backtrace):
1323 Declare only if BYTE_MARK_STACK.
1324 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1325 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1326 (message_enable_multibyte): Remove decl.
1327 (free_misc, interval_free_list, float_block, float_block_index):
1328 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1329 (cons_free_list, last_marked_index):
1330 Now static.
1331 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1332 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1333 (mark_backtrace): Define only if BYTE_MARK_STACK.
1334 * xdisp.c (message_enable_multibyte): Now static.
1335
61c2b50e 1336 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1337 This makes it easier for human readers (and static analyzers)
1338 to see whether these variables are used from other modules.
1339 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1340 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1341 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1342 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1343 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1344 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1345 * xmenu.c, xselect.c:
1346 Declare Q* vars static if they are not used in other modules.
1347 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1348 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1349 Remove decls of unexported vars.
1350 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1351
95c82688
PE
1352 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1353
16a97296
PE
1354 Make Emacs functions such as Fatom 'static' by default.
1355 This makes it easier for human readers (and static analyzers)
1356 to see whether these functions can be called from other modules.
1357 DEFUN now defines a static function. To make the function external
1358 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1359 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1360 (Finit_image_library):
16a97296
PE
1361 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1362 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1363 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1364 Remove decls, since these functions are now static.
1365 (Funintern, Fget_internal_run_time): New decls, since these functions
1366 were already external.
95c82688 1367
16a97296
PE
1368 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1369 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1370 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1371 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1372 * keyboard.c, keymap.c, lread.c:
1373 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1374 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1375 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1376 Mark functions with DEFUE instead of DEFUN,
1377 if they are used in other modules.
1378 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1379 decls for now-static functions.
1380 * buffer.h (Fdelete_overlay): Remove decl.
1381 * callproc.c (Fgetenv_internal): Mark as internal.
1382 * composite.c (Fremove_list_of_text_properties): Remove decl.
1383 (Fcomposition_get_gstring): New forward static decl.
1384 * composite.h (Fcomposite_get_gstring): Remove decl.
1385 * dired.c (Ffile_attributes): New forward static decl.
1386 * doc.c (Fdocumntation_property): New forward static decl.
1387 * eval.c (Ffetch_bytecode): New forward static decl.
1388 (Funintern): Remove extern decl; now in .h file where it belongs.
1389 * fileio.c (Fmake_symbolic_link): New forward static decl.
1390 * image.c (Finit_image_library): New forward static decl.
1391 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1392 * intervals.h (Fprevious_property_change):
1393 (Fremove_list_of_text_properties): Remove decls.
1394 * keyboard.c (Fthis_command_keys): Remove decl.
1395 (Fcommand_execute): New forward static decl.
1396 * keymap.c (Flookup_key): New forward static decl.
1397 (Fcopy_keymap): Now static.
1398 * keymap.h (Flookup_key): Remove decl.
1399 * process.c (Fget_process): New forward static decl.
1400 (Fprocess_datagram_address): Mark as internal.
1401 * syntax.c (Fsyntax_table_p): New forward static decl.
1402 (skip_chars): Remove duplicate decl.
1403 * textprop.c (Fprevious_property_change): New forward static decl.
1404 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1405 Now internal.
1406 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1407 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1408
785bbd42
PE
1409 * editfns.c (Fformat): Remove unreachable code.
1410
8b913b57
AS
14112011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1412
1413 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1414 change. (Bug#8496)
1415
a6744a35
EZ
14162011-04-13 Eli Zaretskii <eliz@gnu.org>
1417
1418 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1419 when at ZV. (Bug#8487)
1420
e7974947
AS
14212011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1422
baad03f0
AS
1423 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1424 (Bug#8437)
1425 * keyboard.c (parse_tool_bar_item): Likewise.
1426 * sound.c (sound_cleanup, alsa_close): Likewise.
1427 * termcap.c (tgetent): Likewise.
1428 * xfns.c (x_default_font_parameter): Likewise.
1429 * xsettings.c (read_and_apply_settings): Likewise.
1430
e7974947
AS
1431 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1432 (overrun_check_free): Protoize.
1433
28272684
PE
14342011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1437 since callers should never pass a negative size.
1438 Change the signature to match that of plain 'read' and 'write'; see
1439 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1440 * lisp.h: Update prototypes of emacs_write and emacs_read.
1441
11997c76
EZ
14422011-04-11 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (redisplay_window): Don't try to determine the character
1445 position of the scroll margin if the window start point w->startp
e896f03c 1446 is outside the buffer's accessible region. (Bug#8468)
11997c76 1447
8a2cbd72
EZ
14482011-04-10 Eli Zaretskii <eliz@gnu.org>
1449
1450 Fix write-region and its subroutines for buffers > 2GB.
1451 * fileio.c (a_write, e_write): Modify declaration of arguments and
1452 local variables to support buffers larger than 2GB.
1453 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1454
1455 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1456 argument, local variables, and return value.
1457
1458 * lisp.h: Update prototypes of emacs_write and emacs_read.
1459
1460 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1461
4073e537 14622011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1463
1ebfdcb6
PE
1464 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1465
b2ded58d
PE
1466 Fix more problems found by GCC 4.6.0's static checks.
1467
7d66342c
PE
1468 * xdisp.c (vmessage): Use a better test for character truncation.
1469
bbf47d44
PE
1470 * charset.c (load_charset_map): <, not <=, for optimization,
1471 and to avoid potential problems with integer overflow.
9248994d 1472 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1473 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1474 * editfns.c (Fformat): Likewise.
1e69125e 1475 * syntax.c (skip_chars): Likewise.
3befa583 1476
e3019616
PE
1477 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1478 This also lets GCC 4.6.0 generate slightly better loop code.
1479
becfa255
PE
1480 * callint.c (Fcall_interactively): <, not <=, for optimization.
1481 (Fcall_interactively): Count the number of arguments produced,
1482 not the number of arguments given. This is simpler and lets GCC
1483 4.6.0 generate slightly better code.
1484
dae0cd48
PE
1485 * ftfont.c: Distingish more carefully between FcChar8 and char.
1486 The previous code passed unsigned char * to a functions like
1487 strlen and xstrcasecmp that expect char *, which does not
1488 conform to the C standard.
1489 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1490 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1491 char * when the C standard requires it.
1492
76032d70
PE
1493 * keyboard.c (read_char): Remove unused var.
1494
eb3f1cc8
PE
1495 * eval.c: Port to Windows vsnprintf (Bug#8435).
1496 Include <limits.h>.
1497 (SIZE_MAX): Define if the headers do not.
1498 (verror): Do not give up if vsnprintf returns a negative count.
1499 Instead, grow the buffer. This ports to Windows vsnprintf, which
1500 does not conform to C99. Problem reported by Eli Zaretskii.
1501 Also, simplify the allocation scheme, by avoiding the need for
1502 calling realloc, and removing the ALLOCATED variable.
1503
70476b54
PE
1504 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1505
12020a9e
PE
1506 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1507 But keep the doprint source code for now, as we might revamp it
1508 and use it again (Bug#8435).
ea6c7ae6
PE
1509 * lisp.h (doprnt): Remove.
1510 * Makefile.in (base_obj): Remove doprnt.o.
1511 * deps.mk (doprnt.o): Remove.
1512
5fdb398c
PE
1513 error: Print 32- and 64-bit integers portably (Bug#8435).
1514 Without this change, on typical 64-bit hosts error ("...%d...", N)
1515 was used to print both 32- and 64-bit integers N, which relied on
1516 undefined behavior.
1517 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1518 New macro.
1519 * lisp.h (error, verror): Mark as printf-like functions.
1520 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1521 Report overflow in size calculations when allocating printf buffer.
1522 Do not truncate output string at its first null byte.
1523 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1524 Truncate the output at a character boundary, since vsnprintf does not
1525 do that.
1526 * charset.c (check_iso_charset_parameter): Convert internal
1527 character to string before calling 'error', since %c now has the
1528 printf meaning.
1529 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1530 overflow when computing char to be passed to 'error'. Do not
1531 pass Lisp_Object to 'error'; pass the integer instead.
1532 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1533 formatted with plain %d.
1534
b189fa66
PE
1535 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1536
bff87ef0
PE
1537 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1538
7e2cac20
PE
1539 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1540
ce4d90b5
PE
1541 * xterm.c (x_catch_errors): Remove duplicate declaration.
1542
266c9547
PE
1543 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1544
79c49ad2
PE
1545 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1546
368f4090
JM
15472011-04-10 Jim Meyering <meyering@redhat.com>
1548
1549 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1550 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1551 return ssize_t not "int", and use size_t as the buffer length.
1552 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1553 * gnutls.h: Update declarations.
1554 * process.c (read_process_output): Use ssize_t, to match.
1555 (send_process): Likewise.
1556
a32d4040
CY
15572011-04-09 Chong Yidong <cyd@stupidchicken.com>
1558
1559 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1560
8546720e 15612011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1562
8546720e
GM
1563 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1564 unsigned char, to match FcChar8 type definition.
aac0c6e3 1565
8546720e
GM
1566 * xterm.c (handle_one_xevent):
1567 * xmenu.c (create_and_show_popup_menu):
1568 * xselect.c (x_decline_selection_request)
1569 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1570
0a2f5c1a 15712011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1572
1573 Fix some uses of `int' instead of EMACS_INT.
1574 * search.c (string_match_1, fast_string_match)
1575 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1576 (scan_buffer, find_next_newline_no_quit)
1577 (find_before_next_newline, search_command, Freplace_match)
1578 (Fmatch_data): Make some `int' variables be EMACS_INT.
1579
1580 * xdisp.c (display_count_lines): 3rd argument and return value now
1581 EMACS_INT. All callers changed.
1582 (pint2hrstr): Last argument is now EMACS_INT.
1583
1584 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1585 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1586 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1587 (decode_coding_utf_16, decode_coding_emacs_mule)
1588 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1589 (decode_coding_ccl, decode_coding_charset)
1590 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1591 (decode_coding_iso_2022, decode_coding_emacs_mule)
1592 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1593 <char_offset, last_offset>: Declare EMACS_INT.
1594 (encode_coding_utf_8, encode_coding_utf_16)
1595 (encode_coding_emacs_mule, encode_invocation_designation)
1596 (encode_designation_at_bol, encode_coding_iso_2022)
1597 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1598 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1599 Declare EMACS_INT.
1600 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1601 (encode_invocation_designation): Last argument P_NCHARS is now
1602 EMACS_INT.
1603 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1604 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1605
1606 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1607 All users changed.
1608
1609 * ccl.c (Fccl_execute_on_string): Declare some variables
1610 EMACS_INT.
1611
8546720e 16122011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1613
1614 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1615
4e19a977
CS
16162011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1617
1618 * process.c (Fformat_network_address): Doc fix.
1619
87302331
R
16202011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1621
1622 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1623
cbb59342
CY
16242011-04-08 Chong Yidong <cyd@stupidchicken.com>
1625
1626 * keyboard.c (read_char): Call Lisp function help-form-show,
1627 instead of using internal_with_output_to_temp_buffer.
1628 (Qhelp_form_show): New var.
e0d38eeb 1629 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1630
1631 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1632
1633 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1634
e67a13ab
CY
16352011-04-06 Chong Yidong <cyd@stupidchicken.com>
1636
1637 * process.c (Flist_processes): Removed to Lisp.
1638 (list_processes_1): Deleted.
1639
973f782d
EZ
16402011-04-06 Eli Zaretskii <eliz@gnu.org>
1641
7c106b1e
EZ
1642 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1643
973f782d
EZ
1644 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1645
41cf7d1a 16462011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1647
ca23cc88
PE
1648 Fix more problems found by GCC 4.6.0's static checks.
1649
f390e2d5
PE
1650 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1651
42eea0d0
PE
1652 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1653
b69769da 1654 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1655
f9541e84
PE
1656 * xdisp.c (vmessage): Mark as a printf-like function.
1657
13841b55
PE
1658 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1659
c136c10f
PE
1660 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1661
5e2d4a30
PE
1662 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1663 printf-like functions.
1664 (tiff_load): Add casts to remove these marks before passing them
1665 to system-supplied API.
1666
583f48b9
PE
1667 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1668
b25d760e
PE
1669 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1670 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1671 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1672 directly, rather than having caller test rule sign. This avoids
1673 some unnecessary tests.
1674 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1675 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1676 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1677
bc7b6697 1678 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1679 (xfont_open): Avoid unnecessary tests.
bc7b6697 1680
27ccc379
PE
1681 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1682
dcd5c89a
PE
1683 * composite.h, composite.c (composition_gstring_put_cache):
1684 Use EMACS_INT, not int, for length.
1685
b13a45c6
PE
1686 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1687 breaking out part of COMPOSITION_DECODE_RULE.
1688 (COMPOSITION_DECODE_RULE): Use it.
1689 * composite.c (get_composition_id): Remove unused local vars,
1690 by using the new macro.
1691
1e792e4d
PE
1692 * textprop.c (set_text_properties_1): Change while to do-while,
1693 since the condition is always true at first.
1694
dc6c6455 1695 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1696 (interval_deletion_adjustment): Return unsigned value.
1697 All uses changed.
dc6c6455 1698
aba7731a
PE
1699 * process.c (list_processes_1, create_pty, read_process_output):
1700 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1701 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1702 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1703 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1704 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1705
fdfc4bf3
PE
1706 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1707
fca8fe46 1708 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1709 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1710
06a0259a 1711 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1712 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1713 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1714
e7b9e80f
PE
1715 * print.c (print_error_message): Avoid int overflow.
1716
56201685
PE
1717 * font.c (font_list_entities): Redo for clarity,
1718 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1719
78834453 1720 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1721 (font_score): Avoid potential overflow in diff calculation.
78834453 1722
0bc0b309 1723 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1724 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1725
e610eaca
PE
1726 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1727
b895abce
PE
1728 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1729 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1730 can always succeed if overflow has undefined behavior.
1731
1f1d9321 1732 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1733 (wordify): Omit three unnecessary tests.
1f1d9321 1734
c59478bc
PE
1735 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1736 All callers changed. This avoids the need for an unused var.
1737
79b73827
PE
1738 * casefiddle.c (casify_region): Remove var that is set but not used.
1739
a4db5dfe
PE
1740 * dired.c (file_name_completion): Remove var that is set but not used.
1741
43aae36e
PE
1742 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1743
2a47c44d 1744 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1745 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1746
a37c69bf
PE
1747 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1748 Check for integer overflow on size calculations.
1749
328ab8e7
PE
1750 * buffer.c (Fprevious_overlay_change): Remove var that is set
1751 but not used.
1752
e5a2a5cb
PE
1753 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1754 Remove vars that are set but not used.
8d84a6eb 1755 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1756 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1757
a60e5f68
PE
1758 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1759
f661cb61 1760 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1761 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1762
f0397f5a
PE
1763 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1764 that are set but not used.
1765
8664db06 1766 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1767 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1768
6abdaa4a
PE
1769 * xselect.c (x_get_local_selection, x_handle_property_notify):
1770 Remove vars that are set but not used.
1771
0ce7538d 1772 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1773 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1774
9ae848fc
PE
1775 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1776 Remove var that is set but not used.
0b918413
PE
1777 (scroll_bar_windows_size): Now size_t, not int.
1778 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1779 Check for overflow.
9ae848fc 1780
a5a62657
PE
1781 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1782 (map_tty_color) [!defined MSDOS]: Likewise.
1783
5c5cdd39
PE
1784 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1785
66ebf983
PE
1786 * coding.c: Remove vars that are set but not used.
1787 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1788 All callers changed.
1789 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1790 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1791 (decode_coding_charset): Remove vars that are set but not used.
1792
1be4d761
PE
1793 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1794 that is set but not used.
1795
47553fa8
PE
1796 * print.c (print_object): Remove var that is set but not used.
1797
1f7196bf 1798 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1799 The gnulib version avoids calling malloc in the usual case,
1800 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1801 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1802 * filelock.c (current_lock_owner): Likewise.
1803 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1804 * sysdep.c: Include allocator.h, careadlinkat.h.
1805 (emacs_no_realloc_allocator): New static constant.
1806 (emacs_readlink): New function.
fdb61804
PE
1807 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1808 ../lib/careadlinkat.h.
d1fdcab7 1809
f84c17c7
SM
18102011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1811
1812 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1813 first non-nil return value).
1814
ef3862ad
JD
18152011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1816
1817 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1818 if not defined (Bug#8403).
1819
376a7006
JB
18202011-04-02 Juanma Barranquero <lekktu@gmail.com>
1821
1822 * xdisp.c (display_count_lines): Remove parameter `start',
1823 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1824 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1825 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1826 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1827 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1828 and thereabouts. All callers changed.
1829 (get_per_char_metric): Remove parameter `f', unused since
1830 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1831
6ca3801d
JM
18322011-04-02 Jim Meyering <meyering@redhat.com>
1833
1834 do not dereference NULL upon failed strdup
1835 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1836 (ns_get_family): Likewise.
1837
d8e2b5ba
JB
18382011-04-02 Juanma Barranquero <lekktu@gmail.com>
1839
1840 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1841
8c74fcbd
JD
18422011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1843
1844 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1845 later (Bug#8403).
1846
7200d79c
SM
18472011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1848
03408648 1849 Add lexical binding.
7200d79c 1850
03408648
SM
1851 * window.c (Ftemp_output_buffer_show): New fun.
1852 (Fsave_window_excursion):
1853 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1854
1855 * lread.c (lisp_file_lexically_bound_p): New function.
1856 (Fload): Bind Qlexical_binding.
1857 (readevalloop): Remove `evalfun' arg.
1858 Bind Qinternal_interpreter_environment.
1859 (Feval_buffer): Bind Qlexical_binding.
1860 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1861 Mark as dynamic.
1862 (syms_of_lread): Declare `lexical-binding'.
1863
1864 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1865
1866 * keyboard.c (eval_dyn): New fun.
1867 (menu_item_eval_property): Use it.
ca105506
SM
1868
1869 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1870
03408648
SM
1871 * fns.c (concat, mapcar1): Accept byte-code-functions.
1872
1873 * eval.c (Fsetq): Handle lexical vars.
1874 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1875 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1876 (FletX, Flet): Obey lexical binding.
1877 (Fcommandp): Handle closures.
1878 (Feval): New `lexical' arg.
1879 (eval_sub): New function extracted from Feval. Use it almost
1880 everywhere where Feval was used. Look up vars in lexical env.
1881 Handle closures.
1882 (Ffunctionp): Move from subr.el.
1883 (Ffuncall): Handle closures.
1884 (apply_lambda): Remove `eval_flags'.
1885 (funcall_lambda): Handle closures and new byte-code-functions.
1886 (Fspecial_variable_p): New function.
1887 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1888 but without exporting it to Lisp.
23aba0ea 1889
23aba0ea 1890 * doc.c (Fdocumentation, store_function_docstring):
03408648 1891 * data.c (Finteractive_form): Handle closures.
23aba0ea 1892
03408648
SM
1893 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1894 interactive spec.
ba83908c 1895
03408648
SM
1896 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1897 byte-codes.
1898 (exec_byte_code): New function extracted from Fbyte_code to handle new
1899 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1900
03408648 1901 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1902
03408648 1903 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1904
e2abce01
JB
19052011-03-31 Juanma Barranquero <lekktu@gmail.com>
1906
1907 * xdisp.c (redisplay_internal): Fix prototype.
1908
63696a73 19092011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1910
63696a73
EZ
1911 * xdisp.c (SCROLL_LIMIT): New macro.
1912 (try_scrolling): Use it when setting scroll_limit. Limit
1913 scrolling to 100 screen lines.
1914 (redisplay_window): Even when falling back on "recentering",
1915 position point in the window according to scroll-conservatively,
1916 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1917
1918 (try_scrolling): When point is above the window, allow searching
1919 as far as scroll_max, or one screenful, to compute vertical
1920 distance from PT to the scroll margin position. This prevents
1921 try_scrolling from unnecessarily failing when
1922 scroll-conservatively is set to a value slightly larger than the
1923 window height. Clean up the case of PT below the margin at bottom
1924 of window: scroll_max can no longer be INT_MAX. When aggressive
1925 scrolling is in use, don't let point enter the opposite scroll
1926 margin as result of the scroll.
1927 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1928 threshold of 100 lines for never-recentering scrolling.
1929
e4cc2dfc
JB
19302011-03-31 Juanma Barranquero <lekktu@gmail.com>
1931
1932 * dispextern.h (move_it_by_lines):
1933 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1934 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1935 (message_log_check_duplicate): Remove parameters `prev_bol' and
1936 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1937 (redisplay_internal): Remove parameter `preserve_echo_area',
1938 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1939
1940 * indent.c (Fvertical_motion):
1941 * window.c (window_scroll_pixel_based, Frecenter):
1942 Don't pass `need_y_p' to `move_it_by_lines'.
1943
1c470562
SM
19442011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1945
44f230aa
SM
1946 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1947 steal a few bits to be more compact.
1948 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1949 Remove unneeded casts.
1950
1c470562
SM
1951 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1952
888adce9
ZK
19532011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1954
1955 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1956 binding" message (bug#7967).
1957
f838ed7b
PE
19582011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1959
77861b95
PE
1960 Fix more problems found by GCC 4.6.0's static checks.
1961
de6dbc14
PE
1962 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1963 Remove unused local var.
1964
f838ed7b
PE
1965 * editfns.c (Fmessage_box): Remove unused local var.
1966
792c7b2b
PE
1967 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1968 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1969 Omit unused local vars.
c499e557 1970 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1971 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1972 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1973 Omit unused local var.
1974
ba0165e1
PE
1975 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1976 Don't assume string length fits in int.
32ad8845 1977 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1978 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1979
3c59b4c9
PE
1980 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1981 instead of alloca (Bug#8344).
1982
a3eed478 1983 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1984 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1985
eb4d412d
PE
1986 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1987
1658b401
PE
1988 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1989 concerns.
1990
1991 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1992
1993 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1994
9a2c6e05
PE
1995 * keyboard.c (syms_of_keyboard): Use the same style as later
1996 in this function when indexing through an array. This also
1997 works around GCC bug 48267.
1998
03d0a109
PE
1999 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2000
44f730c8
PE
2001 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2002
fe75f926
PE
2003 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2004 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2005
ffa8c828
PE
2006 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2007 This avoids undefined behavior on integer overflow, and is a bit
2008 more convenient anyway since it is compared to a size_t variable.
2009
c5101a77
PE
2010 Variadic C functions now count arguments with size_t, not int.
2011 This avoids an unnecessary limitation on 64-bit machines, which
2012 caused (substring ...) to crash on large vectors (Bug#8344).
2013 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2014 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2015 All variadic functions and their callers changed accordingly.
c5101a77
PE
2016 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2017 * data.c (arith_driver, float_arith_driver): Likewise.
2018 * editfns.c (general_insert_function): Likewise.
2019 * eval.c (struct backtrace.nargs, interactive_p)
2020 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2021 (funcall_lambda, mark_backtrace): Likewise.
2022 * fns.c (concat): Likewise.
2023 * frame.c (x_set_frame_parameters): Likewise.
2024 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2025 0 if not found, not -1. All callers changed.
2026
dd3f25f7
PE
2027 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2028 (stack_copy_size): Now size_t, not int.
2029 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2030
461c2ab9
JB
20312011-03-28 Juanma Barranquero <lekktu@gmail.com>
2032
2033 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2034 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2035 All callers changed.
2036
2037 * lisp.h (multibyte_char_to_unibyte):
2038 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2039 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2040 * character.h (CHAR_TO_BYTE8):
2041 * cmds.c (internal_self_insert):
2042 * editfns.c (general_insert_function):
2043 * keymap.c (push_key_description):
2044 * search.c (Freplace_match):
2045 * xdisp.c (message_dolog, set_message_1): All callers changed.
2046
f6d62986
SM
20472011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2048
2049 * keyboard.c (safe_run_hook_funcall): New function.
2050 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2051 don't set the hook to nil, but remove the offending function instead.
2052 (Qcommand_hook_internal): Remove, unused.
2053 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2054 Vcommand_hook_internal.
2055
2056 * eval.c (enum run_hooks_condition): Remove.
2057 (funcall_nil, funcall_not): New functions.
2058 (run_hook_with_args): Call each function through a `funcall' argument.
2059 Remove `cond' argument, now redundant.
2060 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2061 (Frun_hook_with_args_until_failure): Adjust accordingly.
2062 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2063
1db5b1ad
JB
20642011-03-28 Juanma Barranquero <lekktu@gmail.com>
2065
2066 * dispextern.h (string_buffer_position): Remove declaration.
2067
2068 * print.c (strout): Remove parameter `multibyte', unused since
2069 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2070
2071 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2072 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2073 All callers changed.
2074
2075 * w32.c (_wsa_errlist): Use braces for struct initializers.
2076
2077 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2078 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2079 All callers changed.
2080 (string_buffer_position): Likewise. Also, make static (it's never
2081 used outside xdisp.c).
2082 (cursor_row_p): Remove parameter `w', unused since
2083 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2084 (decode_mode_spec): Remove parameter `precision', introduced during
2085 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2086 All callers changed.
2087
5ffb62aa
JD
20882011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2089
2090 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2091
461c2ab9 20922011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2093
2094 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2095 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2096 (ns_update_auto_hide_menu_bar): New functions.
2097 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2098 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2099 ns_constrain_all_frames.
2100 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2101 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2102
5c380ffb
JD
21032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2104
2105 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2106
9af30bdf
GM
21072011-03-27 Glenn Morris <rgm@gnu.org>
2108
2109 * syssignal.h: Replace RETSIGTYPE with void.
2110 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2111 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2112 Replace SIGTYPE with void everywhere.
2113 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2114 * s/template.h (SIGTYPE): Remove commented out definition.
2115
e2abce01
JB
21162011-03-26 Eli Zaretskii <eliz@gnu.org>
2117
2118 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2119 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2120
f868cd8a
JB
21212011-03-26 Juanma Barranquero <lekktu@gmail.com>
2122
59eb0929
JB
2123 * w32.c (read_unc_volume): Use parameter `henum', instead of
2124 global variable `wget_enum_handle'.
2125
2126 * keymap.c (describe_vector): Remove parameters `indices' and
2127 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2128 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2129
f868cd8a
JB
2130 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2131
2132 * keyboard.c (timer_check): Remove parameter `do_it_now',
2133 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2134 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2135 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2136
2137 * keyboard.c (read_char):
2138 * w32menu.c (w32_menu_display_help):
2139 * xmenu.c (show_help_event, menu_help_callback):
2140 Adjust calls to `show_help_echo'.
2141
2142 * gtkutil.c (xg_maybe_add_timer):
2143 * keyboard.c (readable_events):
2144 * process.c (wait_reading_process_output):
2145 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2146
2147 * insdel.c (adjust_markers_gap_motion):
2148 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2149 (gap_left, gap_right): Don't call it.
2150
2ecf6fdb
CY
21512011-03-25 Chong Yidong <cyd@stupidchicken.com>
2152
2153 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2154 incurred during fontification.
2155
6b1f9ba4
JB
21562011-03-25 Juanma Barranquero <lekktu@gmail.com>
2157
2158 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2159 (DEFVAR_PER_BUFFER): Don't pass it.
2160
2161 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2162 (scrolling_window): Don't pass it.
2163
0f4a96b5
JB
21642011-03-25 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2167
2168 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2169 and `suffix'.
2170 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2171 of variables specific to SELinux and computation of `encoded_absname'.
2172
2173 * image.c (XPutPixel): Remove unused variable `height'.
2174
2175 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2176
2177 * unexw32.c (get_section_info): Remove unused variable `section'.
2178
2179 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2180 (system_process_attributes): Remove unused variable `sess'.
2181 (sys_read): Remove unused variable `err'.
2182
2183 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2184 (w32_wnd_proc): Remove unused variable `isdead'.
2185 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2186 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2187 (x_create_tip_frame): Remove unused variable `tem'.
2188
2189 * w32inevt.c (w32_console_read_socket):
2190 Remove unused variable `no_events'.
2191
2192 * w32term.c (x_draw_composite_glyph_string_foreground):
2193 Remove unused variable `width'.
2194
1149507c
JB
21952011-03-24 Juanma Barranquero <lekktu@gmail.com>
2196
2197 * w32term.c (x_set_glyph_string_clipping):
2198 Don't pass uninitialized region to CombineRgn.
2199
9c88f339
JB
22002011-03-23 Juanma Barranquero <lekktu@gmail.com>
2201
2202 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2203 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2204 (Fx_close_connection): Remove unused variable `i'.
2205
2206 * w32font.c (w32font_draw): Return number of glyphs.
2207 (w32font_open_internal): Remove unused variable `i'.
2208 (w32font_driver): Add missing initializer.
2209
2210 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2211 (fill_in_menu): Remove unused variable `items_added'.
2212
2213 * w32term.c (last_mouse_press_frame): Remove static global variable.
2214 (w32_clip_to_row): Remove unused variable `f'.
2215 (x_delete_terminal): Remove unused variable `i'.
2216
2217 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2218 (NOTHING): Remove unused static global variable.
2219 (uniscribe_check_otf): Remove unused variable `table'.
2220 (uniscribe_font_driver): Add missing initializers.
2221
dee091a3
JD
22222011-03-23 Julien Danjou <julien@danjou.info>
2223
2224 * term.c (Fsuspend_tty, Fresume_tty):
2225 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2226 * window.c (temp_output_buffer_show):
2227 * insdel.c (signal_before_change):
2228 * frame.c (Fhandle_switch_frame):
2229 * fileio.c (Fdo_auto_save):
2230 * emacs.c (Fkill_emacs):
2231 * editfns.c (save_excursion_restore):
2232 * cmds.c (internal_self_insert):
2233 * callint.c (Fcall_interactively):
2234 * buffer.c (Fkill_all_local_variables):
2235 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2236 Use Frun_hooks.
0f4a96b5 2237 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2238 unconditionnaly since it does the check itself.
2239
2c520ab5 22402011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2241
c9c49752
PE
2242 Fix more problems found by GCC 4.5.2's static checks.
2243
8abc3f12
PE
2244 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2245 the first time through the loop, since we know p0 < p1 then.
2246 This also avoids a gcc -Wstrict-overflow warning.
2247
a2d26660
PE
2248 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2249 leading to a memory leak, possible in functions like
2250 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2251 of objects (Bug#8318).
a2d26660 2252
916c72e9
PE
2253 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2254 that could (at least in theory) be that large.
2255
19ab8a18
PE
2256 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2257 This is less likely to overflow, and avoids undefined behavior if
2258 overflow does occur. All callers changed. Use strtoul to scan
2259 for the unsigned long integer.
b7cbbd6f
PE
2260 (pint2hrstr): Simplify and tune code slightly.
2261 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2262
f0641eff
PE
2263 * scroll.c (do_scrolling): Work around GCC bug 48228.
2264 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2265
7f650bb9
PE
2266 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2267 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2268 (validate_x_resource_name): Simplify count usage.
2269 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2270
37dd57d1
PE
2271 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2272 fail (Bug#8306).
81e56e61 2273
699979fc 2274 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2275
401bf9b4
PE
2276 * process.c (Fmake_network_process): Use socklen_t, not int,
2277 where POSIX says socklen_t is required in portable programs.
2278 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2279 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2280 (Fmake_network_process, server_accept_connection):
2281 (wait_reading_process_output, read_process_output):
2282 Likewise.
2283
b93aacde
PE
2284 * process.c: Rename or move locals to avoid shadowing.
2285 (list_processes_1, Fmake_network_process):
2286 (read_process_output_error_handler, exec_sentinel_error_handler):
2287 Rename or move locals.
4dc343ee 2288 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2289 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2290 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2291 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2292 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2293
af8a867c 2294 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2295 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2296 Include tparam.h instead, since it declares them.
af8a867c
PE
2297 * cm.h (PC): Remove extern decl; tparam.h now does this.
2298 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2299 * terminfo.c: Include tparam.h, to check interfaces.
2300 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2301 (tparam): Adjust signature to match interface in tparam.h;
2302 this removes some undefined behavior. Check that outstring and len
2303 are zero, which they always are with Emacs.
2304 * tparam.h (PC, BC, UP): New extern decls.
2305
0248044d 2306 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2307 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2308
8ff096c1 2309 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2310 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2311 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2312 (ftfont_list): Remove unused local.
49eaafba
PE
2313 (get_adstyle_property, ftfont_pattern_entity):
2314 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2315 Rename locals to avoid shadowing.
8ff096c1 2316
e2be39f6
PE
2317 * xfont.c (xfont_list_family): Mark var as initialized.
2318
c9735e30
PE
2319 * xml.c (make_dom): Now static.
2320
8f5201ae
PE
2321 * composite.c (composition_compute_stop_pos): Rename local to
2322 avoid shadowing.
b246f932
PE
2323 (composition_reseat_it): Remove unused locals.
2324 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2325 (composition_update_it): Mark var as initialized.
11b61122
PE
2326 (find_automatic_composition): Mark vars as initialized,
2327 with a FIXME (Bug#8290).
8f5201ae 2328
760fbc2c
PE
2329 character.h: Rename locals to avoid shadowing.
2330 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2331 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2332 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2333 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2334 to avoid shadowing.
2335
ff08eb85
PE
2336 * textprop.c (property_change_between_p): Remove; unused.
2337
fc7bf025
PE
2338 * intervals.c (interval_start_pos): Now static.
2339
235d7abc
PE
2340 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2341
44f230aa
SM
2342 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2343 Rename locals to avoid shadowing.
3e7d6594 2344
50060332
PE
2345 * sound.c (wav_play, au_play, Fplay_sound_internal):
2346 Fix pointer signedness.
d01f234b 2347 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2348 (wav_play): Initialize a variable to 0, to prevent undefined
2349 behavior (Bug#8278).
50060332 2350
c4fc4e30
PE
2351 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2352
918436ed
PE
2353 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2354
c939f91b
PE
2355 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2356 clobbering (Bug#8298).
b9c7f648
PE
2357 * sysdep.c (sys_subshell): Likewise.
2358 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2359
6bd8c144
PE
2360 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2361 This should get cleaned up, so that child_setup has the
2362 same signature on all platforms.
2363
7710357c 2364 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2365 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2366
c59da222
CY
23672011-03-22 Chong Yidong <cyd@stupidchicken.com>
2368
2369 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2370 not to be necessary, and produces flickering.
2371
66b87493
GM
23722011-03-20 Glenn Morris <rgm@gnu.org>
2373
2374 * config.in: Remove file.
2375
45b6f6d5
JB
23762011-03-20 Juanma Barranquero <lekktu@gmail.com>
2377
2378 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2379 are now in src/globals.h.
2380 (syms_of_minibuf): Remove spurious & from previous change.
2381
3ec03f7e
LL
23822011-03-20 Leo <sdl.web@gmail.com>
2383
2384 * minibuf.c (completing-read-function): New variable.
2385 (completing-read-default): Rename from completing-read.
2386 (completing-read): Call completing-read-function.
2387
b14e3e21
CY
23882011-03-19 Juanma Barranquero <lekktu@gmail.com>
2389
2390 * xfaces.c (Fx_load_color_file):
2391 Read color file from absolute filename (bug#8250).
2392
f2b726e6
JB
23932011-03-19 Juanma Barranquero <lekktu@gmail.com>
2394
2395 * makefile.w32-in: Update dependencies.
2396
09f6ff02
EZ
23972011-03-17 Eli Zaretskii <eliz@gnu.org>
2398
2399 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2400
29a6015a
PE
24012011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2402
a3a6c54e
PE
2403 Fix more problems found by GCC 4.5.2's static checks.
2404
b766f867
PE
2405 * process.c (make_serial_process_unwind, send_process_trap):
2406 (sigchld_handler): Now static.
2407
be02381c
PE
2408 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2409 That way, the code declares only the vars that it needs.
2410 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2411 * s/cygwin.h (PTY_ITERATION): Likewise.
2412 * s/darwin.h (PTY_ITERATION): Likewise.
2413 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2414
57048744
PE
2415 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2416 * process.c (allocate_pty): Don't declare stb unless it's needed.
2417
7914961c 2418 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2419 (CONSTANTLIM): Remove; unused.
2420 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2421 Define only if needed.
7914961c 2422
b3967b18
PE
2423 * unexelf.c (unexec): Name an expression,
2424 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2425 Use a different way to cause a compilation error if anyone uses
2426 n rather than nn, a way that does not involve shadowing.
73366a00 2427 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2428
29a6015a
PE
2429 * deps.mk (unexalpha.o): Remove; unused.
2430
43cfc33e 2431 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2432 * unexec.h: New file.
ce701a33
PE
2433 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2434 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2435 Depend on unexec.h.
2436 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2437 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2438 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2439 Change as necessary to match prototype in unexec.h.
ce701a33 2440
01f44d5a
PE
2441 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2442 shadowing.
4f63c6bb 2443 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2444
a6670b0b
PE
2445 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2446 Rename locals to avoid shadowing.
2447
cef2010d 2448 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2449 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2450
d4d7173a
PE
2451 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2452
f08b802a
PE
2453 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2454 warning when compiling print.c.
2455
3ddb0639
PE
2456 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2457 instead of using an uninitialized var.
5ad03b97 2458 (font_sort_entities): Mark var as initialized.
3ddb0639 2459
170a2692
PE
2460 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2461
e663c700
PE
2462 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2463 pointers to constants.
89bc529a 2464 (font_parse_fcname): Remove unused vars.
7b81e2d0 2465 (font_delete_unmatched): Now static.
ea838e10 2466 (font_get_spec): Remove; unused.
13a547c6
PE
2467 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2468 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2469 Rename or move locals to avoid shadowing.
e663c700 2470
2a80c887 2471 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2472 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2473
1384fa33 2474 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2475 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2476
8b2c52e9
PE
2477 * alloc.c (mark_backtrace): Move decl from here ...
2478 * lisp.h: ... to here, so that it can be checked.
2479
475545b5 2480 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2481 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2482 (lisp_indirect_variable): Name an expression,
2483 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2484 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2485
b1349114 2486 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2487 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2488 Use const pointer when appropriate.
b1349114 2489
a2928364
PE
2490 * lisp.h (get_system_name, get_operating_system_release):
2491 Move decls here, to check interfaces.
2492 * process.c (get_operating_system_release): Move decl to lisp.h.
2493 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2494 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2495 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2496 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2497 (Fformat_time_string, Fencode_time, Finsert_char):
2498 (Ftranslate_region_internal, Fformat):
2499 Rename or remove local vars to avoid shadowing.
9710023e 2500 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2501
a415e694
PE
2502 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2503 avoid shadowing.
2504
8ef4622d
PE
2505 * lisp.h (eassert): Check that the argument compiles, even if
2506 ENABLE_CHECKING is not defined.
2507
946f9a5b
PE
2508 * data.c (Findirect_variable): Name an expression, to avoid
2509 gcc -Wbad-function-cast warning.
112396d6 2510 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2511 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2512 (Fmake_variable_buffer_local, Fmake_local_variable):
2513 Mark variables as initialized.
52746918 2514 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2515
e5aab7e7 2516 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2517 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2518 Rename locals to avoid shadowing.
dff45157
PE
2519 (mark_stack): Move local variables into the #ifdef region where
2520 they're used.
7bc26fdb
PE
2521 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2522 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2523 needed otherwise.
2524 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2525 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2526 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2527
e5aab7e7
PE
2528 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2529 avoids undefined behavior in theory.
2530
4da60324
PE
2531 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2532
88043301
PE
2533 Use functions, not macros, for up- and down-casing (Bug#8254).
2534 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2535 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2536 to use the following functions instead of these macros.
2537 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2538 EMACS_INT, since callers assume the returned value fits in int.
2539 (upcase1): Likewise, for UPCASE_TABLE.
2540 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2541 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2542 the race-condition problem in the old DOWNCASE.
88043301 2543
19ed5445
PE
2544 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2545 Rename locals to avoid shadowing.
2546 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2547 (regex_compile, re_search_2, re_match_2_internal):
2548 Remove unused local vars.
952db0d7
PE
2549 (FREE_VAR): Rewrite so as not to use empty "else",
2550 which gcc can warn about.
da053e48 2551 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2552 (RETALLOC_IF): Define only if needed.
2553 (WORDCHAR_P): Likewise. This one is never needed, but is used
2554 only in a comment talking about a compiler bug, so put inside
2555 the #if 0 of that comment.
2556 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2557 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2558 Remove; unused.
19ed5445 2559
1f3561e4 2560 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2561 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2562 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2563
ded6f8f7
PE
2564 * search.c (simple_search): Remove unused var.
2565
dbd37a95
PE
2566 * dired.c (compile_pattern): Move decl from here ...
2567 * lisp.h: ... to here, so that it can be checked.
2568 (struct re_registers): New forward decl.
2569
7e47afad
PE
2570 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2571
85f24f61
PE
2572 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2573 All uses changed.
2574 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2575 Rename locals to avoid shadowing.
5671df8f 2576 (Fvertical_motion): Mark locals as initialized.
85f24f61 2577
181aa2be 2578 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2579 (casify_region): Mark local as initialized.
181aa2be 2580
930d429c
PE
2581 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2582
7082eac6
PE
2583 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2584 New macros, so that the caller can use some names other than
2585 gcpro1, gcpro2, etc.
2586 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2587 of the new macros.
2588 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2589 argument, for consistency with GCPRO2_VAR, etc: it is now the
2590 prefix of the variable, not the variable itself. All uses
2591 changed.
38b2c076
PE
2592 * dired.c (directory_files_internal, file_name_completion):
2593 Rename locals to avoid shadowing.
2594
15206ed9
PE
2595 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2596 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2597 dired.c's scmp function, had undefined behavior.
2598 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2599 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2600 * buffer.h: ... to here, because these macros use current_buffer,
2601 and the new implementation with inline functions needs to have
2602 current_buffer in scope now, rather than later when the macros
2603 are used.
2604 (downcase, upcase1): New static inline functions.
2605 (DOWNCASE, UPCASE1): Reimplement using these functions.
2606 This avoids undefined behavior in expressions like
2607 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2608 from race conditions in accessing the global variables
2609 case_temp1 and case_temp2.
2610 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2611 * lisp.h (case_temp1, case_temp2): Remove their decls.
2612 * character.h (ASCII_CHAR_P): Move from here ...
2613 * lisp.h: ... to here, so that the inline functions mentioned
2614 above can use them.
2615
4a6bea26
PE
2616 * dired.c (directory_files_internal_unwind): Now static.
2617
f14b7e14
PE
2618 * fileio.c (file_name_as_directory, directory_file_name):
2619 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2620 Now static.
2893f146
PE
2621 (file_name_as_directory): Use const pointers when appropriate.
2622 (Fexpand_file_name): Likewise. In particular, newdir might
2623 point at constant storage, so make it a const pointer.
fd4ead52 2624 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2625 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2626 signedness issues.
f839df0c
PE
2627 (Fset_file_times, Finsert_file_contents, auto_save_error):
2628 Rename locals to avoid shadowing.
f14b7e14 2629
5716756e 2630 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2631 (Ftry_completion, Fall_completions): Rename or remove locals
2632 to avoid shadowing.
5716756e 2633
b4c3046a
PE
2634 * marker.c (bytepos_to_charpos): Remove; unused.
2635
b45db522
PE
2636 * lisp.h (verify_bytepos, count_markers): New decls,
2637 so that gcc does not warn that these functions aren't declared.
2638
85876d07
PE
2639 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2640 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2641 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2642 (copy_text): Remove unused local var.
85876d07 2643
03d78a21 2644 * filelock.c (within_one_second): Now static.
b3dd38ab 2645 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2646
5df8f01b
PE
2647 * buffer.c (fix_overlays_before): Mark locals as initialized.
2648 (fix_start_end_in_overlays): Likewise. This function should be
2649 simplified by using pointers-to-pointers, but that's a different
2650 matter.
b1d876f1 2651 (switch_to_buffer_1): Now static.
8f54f30a
PE
2652 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2653 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2654
a70072c9 2655 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2656 Fix pointer signedness issue.
edced198
PE
2657 (sys_subshell): Mark local as volatile if checking for lint,
2658 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2659 (MAXPATHLEN): Define only if needed.
a70072c9 2660
a0977c44
PE
2661 * process.c (serial_open, serial_configure): Move decls from here ...
2662 * systty.h: ... to here, so that they can be checked.
2663
a884fdcc
PE
2664 * fns.c (get_random, seed_random): Move extern decls from here ...
2665 * lisp.h: ... to here, so that they can be checked.
2666
604efe86 2667 * sysdep.c (reset_io): Now static.
b8950c94 2668 (wait_for_termination_signal): Remove; unused.
604efe86 2669
38fc62d9
PE
2670 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2671 (copy_keymap_item, append_key, push_text_char_description):
2672 Now static.
1004a21a 2673 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2674 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2675 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2676 (describe_map_tree):
2677 Rename locals to avoid shadowing.
38fc62d9 2678
2f2650da
PE
2679 * keyboard.c: Declare functions static if they are not used elsewhere.
2680 (echo_char, echo_dash, cmd_error, top_level_2):
2681 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2682 (read_char, kbd_buffer_get_event, make_lispy_position):
2683 (make_lispy_event, make_lispy_movement, apply_modifiers):
2684 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2685 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2686 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2687 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2688 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2689
a053e86c 2690 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2691 (mark_kboards): Move decl here ...
2692 * alloc.c (mark_kboards): ... from here.
a053e86c 2693
4752793e
PE
2694 * lisp.h (force_auto_save_soon): New decl.
2695
74f10ca7 2696 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2697 (DEFINE_DUMMY_FUNCTION): New macro.
2698 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2699 Use it.
c03cd23f
PE
2700 (main): Add casts to avoid warnings
2701 if GCC considers string literals to be constants.
74f10ca7 2702
022e70d4
PE
2703 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2704
59d6fe83
PE
2705 * dbusbind.c: Pointer signedness fixes.
2706 (xd_signature, xd_append_arg, xd_initialize):
2707 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2708 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2709 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2710 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2711
78320123
PE
2712 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2713 if GCC considers string literals to be constants.
49cebcca 2714 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2715
35ac2a97
SM
27162011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2717
fb103ca9
SM
2718 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2719 (print_preprocess, print_object): New macro to fix last change.
2720
35ac2a97
SM
2721 * print.c (print_preprocess): Don't forget font objects.
2722
62973b41
JB
27232011-03-16 Juanma Barranquero <lekktu@gmail.com>
2724
2725 * emacs.c (USAGE3): Doc fixes.
2726
0e48bb22
AS
27272011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2728
2729 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2730 structure.
2731
7684e57b
JB
27322011-03-14 Juanma Barranquero <lekktu@gmail.com>
2733
2734 * lisp.h (VWindow_system, Qfile_name_history):
2735 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2736 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2737 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2738
2739 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2740 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2741
2742 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2743 * w32console.c (detect_input_pending, read_input_pending)
2744 (encode_terminal_code):
2745 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2746 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2747 (w32_system_caret_y, Qfile_name_history):
2748 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2749 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2750 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2751 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2752 * w32proc.c (Qlocal, report_file_error):
2753 * w32term.c (Vwindow_system, updating_frame):
2754 * w32uniscribe.c (initialized, uniscribe_font_driver):
2755 Remove unneeded extern declarations.
2756
2aa46d6c
CY
27572011-03-14 Chong Yidong <cyd@stupidchicken.com>
2758
c96bbc66 2759 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2760
cffc6f3b
CY
27612011-03-13 Chong Yidong <cyd@stupidchicken.com>
2762
2763 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2764 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2765 These macros can no longer be used for assignment.
2766
44f230aa
SM
2767 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2768 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2769 (record_buffer_markers, fetch_buffer_markers): New functions for
2770 recording and fetching special buffer markers.
2771 (set_buffer_internal_1, set_buffer_temp): Use them.
2772
2773 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2774
2775 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2776
2777 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2778 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2779
2780 * xdisp.c (hscroll_window_tree):
2781 (reconsider_clip_changes): Use PT instead of BUF_PT.
2782
d251f04b
EZ
27832011-03-13 Eli Zaretskii <eliz@gnu.org>
2784
2785 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2786 $(EMACS_ROOT)/lib/intprops.h.
2787
f0c77cd1
PE
27882011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2789
3eca4629
PE
2790 Fix more problems found by GCC 4.5.2's static checks.
2791
7c86ee98
PE
2792 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2793 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2794 (xg_free_frame_widgets): Make it clear that a local variable is
2795 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2796 (gdk_window_get_screen): Make it clear that this macro is needed
2797 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2798 (int_gtk_range_get_value): New function, which avoids a diagnostic
2799 from gcc -Wbad-function-cast.
2800 (xg_set_toolkit_scroll_bar_thumb): Use it.
2801 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2802 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2803 (get_utf8_string, xg_get_file_with_chooser):
2804 Rename locals to avoid shadowing.
2805 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2806
41729b81
PE
2807 * xgselect.c (xg_select): Remove unused var.
2808
f0c77cd1
PE
2809 * image.c (four_corners_best): Mark locals as initialized.
2810 (gif_load): Initialize transparent_p to zero (Bug#8238).
2811 Mark another local as initialized.
ec6cf4c6 2812 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2813
ce0ad53d 2814 * image.c (clear_image_cache): Now static.
d5d5a617 2815 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2816 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2817 (x_edge_detection): Remove unnecessary cast that
2818 gcc -Wbad-function-cast diagnoses.
2037898d 2819 (gif_load): Fix pointer signedness.
6ae141d6
PE
2820 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2821 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2822
33383987 28232011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2824
d32df629
PE
2825 Improve quality of tests for time stamp overflow.
2826 For example, without this patch (encode-time 0 0 0 1 1
2827 1152921504606846976) returns the obviously-bogus value (-948597
2828 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2829 reports time overflow. See
2830 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2831 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2832 * editfns.c: Include limits.h and intprops.h.
2833 (TIME_T_MIN, TIME_T_MAX): New macros.
2834 (time_overflow): Move earlier, to before first use.
2835 (hi_time, lo_time): New functions, for an accurate test for
2836 out-of-range times.
2837 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2838 (Fget_internal_run_time): Don't assume time_t fits in int.
2839 (make_time): Use list2 instead of Fcons twice.
2840 (Fdecode_time): More accurate test for out-of-range times.
2841 (check_tm_member): New function.
2842 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2843 (lisp_time_argument): Don't rely on undefined left-shift and
2844 right-shift behavior when checking for time stamp overflow.
8be6f318 2845
fe31d94c
PE
2846 * editfns.c (time_overflow): New function, refactoring common code.
2847 (Fformat_time_string, Fdecode_time, Fencode_time):
2848 (Fcurrent_time_string): Use it.
2849
8be6f318
PE
2850 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2851 * dired.c (make_time): Move to ...
2852 * editfns.c (make_time): ... here.
2853 * systime.h: Note the move.
2854
09d9db2c 28552011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2856
126bc0dc
YM
2857 * fringe.c (update_window_fringes): Remove unused variables.
2858
c47cbdfd
YM
2859 * unexmacosx.c (copy_data_segment): Also copy __got section.
2860 (Bug#8223)
2861
7ac80be9
EZ
28622011-03-12 Eli Zaretskii <eliz@gnu.org>
2863
c96bbc66 2864 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2865 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2866 Constify `char *' arguments and their references according to
2867 prototypes in tparam.h.
2868
ecb0f94d 2869 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2870
7ac80be9
EZ
2871 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2872 Adapt all references accordingly.
2873
2874 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2875
ef1fd07e
TT
28762011-03-11 Tom Tromey <tromey@redhat.com>
2877
2878 * buffer.c (syms_of_buffer): Remove obsolete comment.
2879
7ef4b50c
EZ
28802011-03-11 Eli Zaretskii <eliz@gnu.org>
2881
2882 * termhooks.h (encode_terminal_code): Declare prototype.
2883
2884 * msdos.c (encode_terminal_code): Don't declare prototype.
2885
2886 * term.c (encode_terminal_code): Now external again, used by
2887 w32console.c and msdos.c.
2888
44f230aa
SM
2889 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2890 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2891
4b1ec863 28922011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2893
1714f52b 2894 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2895
4b1ec863
PE
2896 * fringe.c (update_window_fringes): Mark locals as initialized
2897 (Bug#8227).
2898 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2899
524c7aa6
PE
2900 * alloc.c (mark_fringe_data): Move decl from here ...
2901 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2902 to check its interface.
2903 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2904
a5c0af81 2905 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2906 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2907 (fontset_font): Mark local as initialized.
a9a06e0b 2908 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2909
b4716021
PE
2910 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2911
811e9bac 2912 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2913 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2914 (x_own_selection, Fx_disown_selection_internal): Rename locals
2915 to avoid shadowing.
2916 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2917
7e3ab302
PE
2918 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2919 so that the caller can use some name other than gcpro1.
2920 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2921 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2922 (Fx_backspace_delete_keys_p):
2923 Use them to avoid shadowing, and rename vars to avoid shadowing.
2924 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2925 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2926 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2927 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2928 Remove unused locals.
7e3ab302
PE
2929 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2930 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2931 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2932 macros.
f78faa98 2933
e2b13473
PE
2934 * xterm.h (x_mouse_leave): New decl.
2935
77f23912
PE
2936 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2937 Remove unused functions.
cdf4ba58
PE
2938 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2939 (x_calc_absolute_position): Now static.
7411c686 2940 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2941 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2942 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2943 unless they are used.
38d0b34a
PE
2944 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2945 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2946 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2947 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2948 (x_error_catcher, x_connection_closed, x_error_handler):
2949 (x_error_quitter, xembed_send_message, x_iconify_frame):
2950 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2951 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2952 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2953
44f230aa
SM
2954 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2955 Rename or move locals to avoid shadowing.
6b463e58 2956 (tty_defined_color, merge_face_heights): Now static.
5967d051 2957 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2958 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2959 does not deduce is never used uninitialized.
73719eba
PE
2960 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2961 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2962
426994c3 2963 * terminal.c (store_terminal_param): Now static.
5489860b 2964
032f1620 2965 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2966 (set_frame_menubar): Remove unused local.
d4323972 2967 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2968 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2969 since they might point to immutable storage.
281585b0
PE
2970 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2971 since it's unused otherwise.
032f1620 2972
367c19e5 2973 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2974 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2975 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2976 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2977 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2978 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2979 does not deduce are never used uninitialized.
70739cbe 2980
07b48fa9
PE
2981 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2982
8868a238 2983 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2984 * window.c (window_loop, size_window):
2985 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2986
7e5cf297 2987 * window.c (display_buffer): Now static.
d6550a9f
PE
2988 (size_window): Mark variables that gcc -Wuninitialized
2989 does not deduce are never used uninitialized.
a586633d
PE
2990 * window.h (check_all_windows): New decl, to forestall
2991 gcc -Wmissing-prototypes diagnostic.
5b555da1 2992 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2993
f6095868
PE
2994 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2995 shadowing.
2996 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2997 Include <limits.h>.
2998 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2999 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3000 (load_charset_map): Mark variables that gcc -Wuninitialized
3001 does not deduce are never used uninitialized.
53df7c11 3002 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3003
f38b440c
PE
3004 * coding.c (coding_set_source, coding_set_destination):
3005 Use "else { /* comment */ }" rather than "else /* comment */;"
3006 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3007 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3008 a block, when the outer 'i' will do.
3009 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3010 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3011 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3012 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3013 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3014 Rename locals to avoid shadowing.
3015 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3016 * coding.c (emacs_mule_char, encode_invocation_designation):
3017 Now static, since they're not used elsewhere.
413bb2db 3018 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3019 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3020 (decode_coding_emacs_mule): Mark variables that gcc
3021 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3022 (detect_coding_iso_2022): Initialize a local variable that might
3023 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3024 this initialization is needed. (Bug#8211)
5f58e762
PE
3025 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3026 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3027 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3028 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3029 Remove unused macros.
f38b440c 3030
232b38b9 3031 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3032 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3033 * character.c (string_count_byte8): Likewise.
232b38b9 3034
fb90da1b
PE
3035 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3036 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3037
fb93dbc2
PE
3038 * chartab.c (copy_sub_char_table): Now static, since it's not used
3039 elsewhere.
5c156ace
PE
3040 (sub_char_table_ref_and_range, char_table_ref_and_range):
3041 Rename locals to avoid shadowing.
bbcd0949 3042 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3043
7d3b3862 3044 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3045 (BIDI_BOB): Remove unused macro.
7d3b3862 3046
6be7d3da
PE
3047 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3048 deduce are never used uninitialized.
c2ed9c8b 3049 * term.c (encode_terminal_code): Likewise.
6be7d3da 3050
75f8807f 3051 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3052
50938595
PE
3053 * tparam.h: New file.
3054 * term.c, tparam.h: Include it.
3055 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3056 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3057 Move these decls to tparam.h, and make them agree with what
3058 is actually in tparam.c. The previous trick of using incompatible
3059 decls in different modules does not conform to the C standard.
3060 All callers of tparam changed to use tparam's actual API.
3061 * tparam.c (tparam1, tparam, tgoto):
3062 Use const pointers where appropriate.
3063
fbceeba2
PE
3064 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3065 * cm.h (struct cm): Likewise.
3066 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3067 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3068 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3069 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3070 (turn_on_face, init_tty): Likewise.
3071 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3072
7f3f1250
PE
3073 * term.c (term_mouse_position): Rename local to avoid shadowing.
3074
e6ca6543
PE
3075 * alloc.c (mark_ttys): Move decl from here ...
3076 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3077
c40f8d15
AS
30782011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3079
3080 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3081
cfe0661d
JB
30822011-03-09 Juanma Barranquero <lekktu@gmail.com>
3083
3084 * search.c (compile_pattern_1): Remove argument regp, unused since
3085 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3086 (compile_pattern): Don't pass it.
3087
0afb4571
J
30882011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3089
3090 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3091 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3092 for ! HAVE_GTK3.
3093 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3094
3095 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3096
3097 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3098 gdk_window_get_screen, gdk_window_get_geometry,
3099 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3100 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3101 (xg_get_pixbuf_from_pixmap): New function.
3102 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3103 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3104 Call xg_get_pixbuf_from_pixmap instead of
3105 gdk_pixbuf_get_from_drawable.
3106 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3107 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3108 (xg_check_special_colors): Use GtkStyleContext and its functions
3109 for HAVE_GTK3.
3110 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3111 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3112 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3113 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3114 Call gtk_widget_get_preferred_size.
0afb4571
J
3115 (xg_frame_resized): gdk_window_get_geometry only takes 5
3116 parameters.
44f230aa
SM
3117 (xg_win_to_widget, xg_event_is_for_menubar):
3118 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3119 (xg_set_widget_bg): New function.
3120 (delete_cb): New function.
895009e1 3121 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3122 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3123 (xg_set_background_color): Call xg_set_widget_bg.
3124 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3125 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3126 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3127 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3128 if ! HAVE_GTK3.
3129 (update_frame_tool_bar): Call gtk_widget_hide.
3130 (xg_initialize): Use GDK_KEY_g.
3131
3132 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3133 if ! HAVE_GTK3
3134 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3135
3136 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3137 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3138 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3139
1c2cc4ef
JB
31402011-03-08 Juanma Barranquero <lekktu@gmail.com>
3141
3142 * w32xfns.c (select_palette): Check success of RealizePalette against
3143 GDI_ERROR, not zero.
3144
33383987 3145See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3146
3147;; Local Variables:
3148;; coding: utf-8
aac0c6e3
MR
3149;; End:
3150
33383987 3151 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3152
3153 This file is part of GNU Emacs.
3154
3155 GNU Emacs is free software: you can redistribute it and/or modify
3156 it under the terms of the GNU General Public License as published by
3157 the Free Software Foundation, either version 3 of the License, or
3158 (at your option) any later version.
3159
3160 GNU Emacs is distributed in the hope that it will be useful,
3161 but WITHOUT ANY WARRANTY; without even the implied warranty of
3162 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3163 GNU General Public License for more details.
3164
3165 You should have received a copy of the GNU General Public License
3166 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.