* src/callproc.c: Indentation fixup.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e7a6747f
AS
12011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2
19ed11ba
AS
3 * callproc.c: Indentation fixup.
4
e7a6747f
AS
5 * sysdep.c (wait_for_termination_1): Make static.
6 (wait_for_termination, interruptible_wait_for_termination): Move
7 after wait_for_termination_1.
8
1ef14cb4
LMI
92011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10
11 * sysdep.c (interruptible_wait_for_termination): New function
12 which is like wait_for_termination, but allows keyboard
13 interruptions.
14
15 * callproc.c (Fcall_process): Add (:file "file") as an option for
16 the STDOUT buffer.
17 (Fcall_process_region): Ditto.
18
330d880c
EZ
192011-04-30 Eli Zaretskii <eliz@gnu.org>
20
8db90b73
EZ
21 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
22 rather than `XVECTOR (FOO)->size'.
23
330d880c
EZ
24 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
25 inttypes.h, as a gnulib replacement is used if it not available in
26 system headers.
27
15cbd324
EZ
282011-04-21 Eli Zaretskii <eliz@gnu.org>
29
30 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
31 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
32 of MOST_POSITIVE_FIXNUM. (Bug#8528)
33
34 * coding.c (coding_alloc_by_realloc): Error out if destination
35 will grow beyond MOST_POSITIVE_FIXNUM.
36 (decode_coding_emacs_mule): Abort if there isn't enough place in
37 charbuf for the composition carryover bytes. Reserve an extra
38 space for up to 2 characters produced in a loop.
39 (decode_coding_iso_2022): Abort if there isn't enough place in
40 charbuf for the composition carryover bytes.
41
422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 43
ae940cca
EZ
44 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
45 aborting when %lld or %lll format is passed.
46 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
47 %llo or %llx format is passed. (Bug#8545)
48
03ab8921
EZ
49 * window.c (window_scroll_line_based): Use a marker instead of
50 simple variables to record original value of point. (Bug#7952)
51
afda1437
EZ
52 * doprnt.c (doprnt): Fix the case where a multibyte sequence
53 produced by %s or %c overflows available buffer space. (Bug#8545)
54
f76dee0c
PE
552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
56
57 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 58 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 59
fdc5744d
JB
602011-04-28 Juanma Barranquero <lekktu@gmail.com>
61
62 * w32.c (init_environment): Warn about defaulting HOME to C:\.
63
638f053a
JB
642011-04-28 Juanma Barranquero <lekktu@gmail.com>
65
66 * keyboard.c (Qdelayed_warnings_hook): Define.
67 (command_loop_1): Run `delayed-warnings-hook'
68 if Vdelayed_warnings_list is non-nil.
69 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
70 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
71
d178f871
EZ
722011-04-28 Eli Zaretskii <eliz@gnu.org>
73
74 * doprnt.c (doprnt): Don't return value smaller than the buffer
75 size if the message was truncated. (Bug#8545).
76
b124fd93
JB
772011-04-28 Juanma Barranquero <lekktu@gmail.com>
78
79 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
80 (Fx_window_property): #if-0 the whole functions, not just the bodies.
81
e810457d
PE
822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
83
84 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
85
ea51cceb
JB
862011-04-27 Juanma Barranquero <lekktu@gmail.com>
87
88 * makefile.w32-in: Update dependencies.
89
94dcfacf
EZ
902011-04-27 Eli Zaretskii <eliz@gnu.org>
91
92 Improve `doprnt' and its usage. (Bug#8545)
93 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
94 `format_end'. Remove support for %l as a conversion specifier.
95 Don't use xrealloc. Improve diagnostics when the %l size modifier
96 is used. Update the commentary.
97
98 * eval.c (verror): Simplify calculation of size_t.
99
100 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
101 messages.
102
f61f41d7
PE
1032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
104
105 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
106 change.
107
96fb4434
PE
1082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
109
110 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
111 This makes this file independent of the recent pseudovector change.
112
671875da 1132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 114
69e9b5a3
PE
115 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
116
b5f869a7 117 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 118 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 119 Remove unused local.
c8926152 120 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 121
841a1577 122 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
123 GCC 4.6.0 optimizes based on type-based alias analysis. For
124 example, if b is of type struct buffer * and v of type struct
125 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
126 != &v->size, and therefore "v->size = 1; b->size = 2; return
127 v->size;" must therefore return 1. This assumption is incorrect
128 for Emacs, since it type-puns struct Lisp_Vector * with many other
129 types. To fix this problem, this patch adds a new type struct
f904488f 130 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
131 and pseudovectors, and helps optimizing compilers not get fooled
132 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
133 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
134 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
135 the size member.
eab3844f
PE
136 (XSETPVECTYPE): Rewrite in terms of new macro.
137 (XSETPVECTYPESIZE): New macro, specifying both type and size.
138 This is a bit clearer, and further avoids the possibility of
139 undesirable aliasing.
140 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 141 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
142 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
143 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
144 (ASIZE): Now uses header.size rather than size. All
145 previous uses of XVECTOR (foo)->size replaced to use this macro,
146 to avoid the hassle of writing XVECTOR (foo)->header.size.
147 (struct vectorlike_header): New type.
eab3844f
PE
148 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
149 object, to help avoid aliasing.
150 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
151 (SUBRP): Likewise, since Lisp_Subr is a special case.
152 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
153 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
154 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 155 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
156 changed to be "header.size" and "header.next".
157 * buffer.h (struct buffer): Likewise.
158 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
159 * frame.h (struct frame): Likewise.
160 * process.h (struct Lisp_Process): Likewise.
161 * termhooks.h (struct terminal): Likewise.
162 * window.c (struct save_window_data, struct saved_window): Likewise.
163 * window.h (struct window): Likewise.
164 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
165 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
166 * buffer.c (init_buffer_once): Likewise.
167 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
168 special case.
169 * process.c (Fformat_network_address): Use local var for size,
170 for brevity.
171
0df1eac5
PE
172 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
173
847ab9d1 174 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
175 * data.c (atof): Remove decl; no longer used or needed.
176 (digit_to_number): Move to lread.c.
177 (Fstring_to_number): Use new string_to_number function, to be
178 consistent with how the Lisp reader treats infinities and NaNs.
179 Do not assume that floating-point numbers represent EMACS_INT
180 without losing information; this is not true on most 64-bit hosts.
181 Avoid double-rounding errors, by insisting on integers when
182 parsing non-base-10 numbers, as the documentation specifies.
183 * lisp.h (string_to_number): New decl, replacing ...
184 (isfloat_string): Remove.
bc0a5c13 185 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 186 (read1): Do not accept +. and -. as integers; this
452f4150
PE
187 appears to have been a coding error. Similarly, do not accept
188 strings like +-1e0 as floating point numbers. Do not report
189 overflow for integer overflows unless the base is not 10 which
190 means we have no simple and reliable way to continue.
191 Break out the floating-point parsing into a new
192 function string_to_number, so that Fstring_to_number parses
193 floating point numbers consistently with the Lisp reader.
194 (digit_to_number): Moved here from data.c. Make it static inline.
195 (E_CHAR, EXP_INT): Remove, replacing with ...
196 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
197 (string_to_number): New function, replacing isfloat_string.
198 This function checks for valid syntax and produces the resulting
199 Lisp float number too. Rework it so that string-to-number
bc0a5c13 200 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
201 so that overflow for non-base-10 numbers is reported only when
202 there's no portable and simple way to convert to floating point.
452f4150 203
67769ffc
PE
204 * textprop.c (set_text_properties_1): Rewrite for clarity,
205 and to avoid GCC warning about integer overflow.
206
c20db43f
PE
207 * intervals.h (struct interval): Use EMACS_INT for members
208 where EMACS_UINT might cause problems. See
209 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
210 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
211 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
212 All uses changed.
37aa2f85
PE
213 (offset_intervals): Tell GCC not to worry about length overflow
214 when negating a negative length.
c20db43f 215
2538aa2f
PE
216 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
217 (overrun_check_free): Likewise.
218
f2d3008d
PE
219 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
220 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
221 word size.
222
ec8df744
PE
223 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
224 (gnutls_make_error): Rename local to avoid shadowing.
225 (gnutls_emacs_global_deinit): ifdef out; not used.
226 (Fgnutls_boot): Use const for pointer to readonly storage.
227 Comment out unused local. Fix pointer signedness problems.
228
640ee02d
PE
229 * lread.c (openp): Don't stuff size_t into an 'int'.
230 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
231 about possible signed overflow.
232
6048fb2a
PE
233 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
234 (GDK_KEY_g): Don't define if already defined.
235 (xg_prepare_tooltip): Avoid pointer signedness problem.
236 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
237
fa3c87e1
PE
238 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
239 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
240
2172544b
PE
241 * xfns.c (Fx_window_property): Simplify a bit,
242 to make a bit faster and to avoid GCC 4.6.0 warning.
243 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
244
9b821a21
PE
245 * fns.c (internal_equal): Don't assume size_t fits in int.
246
3c616cfa
PE
247 * alloc.c (compact_small_strings): Tighten assertion a little.
248
c2982e87
PE
249 Replace pEd with more-general pI, and fix some printf arg casts.
250 * lisp.h (pI): New macro, generalizing old pEd macro to other
251 conversion specifiers. For example, use "...%"pI"d..." rather
252 than "...%"pEd"...".
253 (pEd): Remove. All uses replaced with similar uses of pI.
254 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
255 * alloc.c (check_pure_size): Don't overflow by converting size to int.
256 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
257 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
258 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
259 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
260 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
261 64-bit hosts.
262 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
263 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
264 * print.c (safe_debug_print, print_object): Likewise.
265 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
266 to int.
6f04d126
PE
267 Use pI instead of if-then-else-abort. Use %p to avoid casts,
268 avoiding the 0 flag, which is not portable.
c2982e87
PE
269 * process.c (Fmake_network_process): Use pI to avoid cast.
270 * region-cache.c (pp_cache): Likewise.
271 * xdisp.c (decode_mode_spec): Likewise.
272 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
273 behavior on 64-bit hosts with printf arg.
6f04d126 274 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
275 (x_stop_queuing_selection_requests): Likewise.
276 (x_get_window_property): Don't truncate byte count to an 'int'
277 when tracing.
0b432f21 278
5e073ec7
PE
279 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
280 here, since it parses constructs like leading '-' and spaces,
281 which are not wanted; and it overflows with large numbers.
282 Instead, simply match F[0-9]+, which is what is wanted anyway.
283
36372bf9
PE
284 * alloc.c: Remove unportable assumptions about struct layout.
285 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
286 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
287 (allocate_vectorlike, make_pure_vector): Use the new macros,
288 plus offsetof, to remove unportable assumptions about struct layout.
289 These assumptions hold on all porting targets that I know of, but
290 they are not guaranteed, they're easy to remove, and removing them
291 makes further changes easier.
292
0b432f21
PE
293 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
294 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
295 (string_overrun_cookie): Now const. Use initializers that
296 don't formally overflow signed char, to avoid warnings.
000098c1
PE
297 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
298 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
299 (allocate_buffer): Don't assume sizeof (struct buffer) is a
300 multiple of sizeof (EMACS_INT); it need not be, if
301 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 302 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 303
895009e1
JB
3042011-04-26 Juanma Barranquero <lekktu@gmail.com>
305
306 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
307
6a7a1b0b
TZ
3082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
309
310 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 311 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
312 Reported by Paul Eggert <eggert@cs.ucla.edu>.
313
841a1577 3142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
315
316 * lisp.h (Qdebug): List symbol.
895009e1 317 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
318 * keyboard.c (debug-on-event): New variable.
319 (handle_user_signal): Break into debugger when debug-on-event
320 matches the current signal symbol.
321
f2d3ba6f
DN
3222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
323
324 * alloc.c (check_sblock, check_string_bytes)
325 (check_string_free_list): Convert to standard C.
326
42ce4c63
TZ
3272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
328
329 * w32.c (emacs_gnutls_push): Fix typo.
330
825cd63c
EZ
3312011-04-25 Eli Zaretskii <eliz@gnu.org>
332
fb11d64d
EZ
333 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
334 "cast to pointer from integer of different size".
335
825cd63c
EZ
336 Improve doprnt and its use in verror. (Bug#8545)
337 * doprnt.c (doprnt): Document the set of format control sequences
338 supported by the function. Use SAFE_ALLOCA instead of always
339 using `alloca'.
340
341 * eval.c (verror): Don't limit the buffer size at size_max-1, that
342 is one byte too soon. Don't use xrealloc; instead xfree and
343 xmalloc anew.
344
e061a11b
TZ
3452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
346
347 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
348 callbacks stage.
349
350 * gnutls.c: Renamed global_initialized to
351 gnutls_global_initialized. Added internals for the
352 :verify-hostname-error, :verify-error, and :verify-flags
353 parameters of `gnutls-boot' and documented those parameters in the
354 docstring. Start callback support.
355 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
356 unless a fatal error occured. Call gnutls_alert_send_appropriate
357 on error. Return error code.
358 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
359 (emacs_gnutls_read): Likewise.
360 (Fgnutls_boot): Return handshake error code.
361 (emacs_gnutls_handle_error): New function.
362 (wsaerror_to_errno): Likewise.
363
364 * w32.h (emacs_gnutls_pull): Add prototype.
365 (emacs_gnutls_push): Likewise.
366
367 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
368 (emacs_gnutls_push): Likewise.
369
3702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
371
372 * process.c (wait_reading_process_output): Check if GnuTLS
373 buffered some data internally if no FDs are set for TLS
374 connections.
375
376 * makefile.w32-in (OBJ2): Add gnutls.$(O).
377 (LIBS): Link to USER_LIBS.
378 ($(BLD)/gnutls.$(0)): New target.
379
fa6996bc
EZ
3802011-04-24 Eli Zaretskii <eliz@gnu.org>
381
eb35682e
EZ
382 * xdisp.c (handle_single_display_spec): Rename the
383 display_replaced_before_p argument into display_replaced_p, to
384 make it consistent with the commentary. Fix typos in the
385 commentary.
386
e2ad650c
EZ
387 * textprop.c (syms_of_textprop): Remove dead code.
388 (copy_text_properties): Delete obsolete commentary about an
389 interface that was deleted long ago. Fix typos in the description
390 of arguments.
391
1b2de274
EZ
392 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
393 to changes in oldXMenu/XMenu.h from 2011-04-16.
394 <menu_help_message, prev_menu_help_message>: Constify.
395 (IT_menu_make_room): menu->help_text is now `const char **';
396 adjust.
397
398 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
399 to changes in oldXMenu/XMenu.h from 2011-04-16.
400 (struct XMenu): Declare `help_text' `const char **'.
401
402 * xfaces.c <Qunspecified>: Make extern again.
403
404 * syntax.c: Include sys/types.h before including regex.h, as
405 required by Posix.
406
762b15be
EZ
407 * doc.c (get_doc_string): Improve the format passed to `error'.
408
409 * doprnt.c (doprnt): Improve commentary.
410
411 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
412
413 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
414 them with etags.
415
f1052e5d
EZ
416 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
417 changes in globals.h immediately force recompilation.
762b15be
EZ
418 (TAGS): Depend on $(CURDIR)/m/intel386.h and
419 $(CURDIR)/s/ms-w32.h.
420 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 421
fa6996bc
EZ
422 * character.c (Fchar_direction): Function deleted.
423 (syms_of_character): Don't defsubr it.
424 <char-direction-table>: Deleted.
425
e6c3da20
EZ
4262011-04-23 Eli Zaretskii <eliz@gnu.org>
427
428 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
429 * doprnt.c: Include limits.h.
430 (SIZE_MAX): New macro.
431 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
432 local variables are now size_t instead of int or unsigned.
433 Improve overflow protection. Support `l' modifier for integer
434 conversions. Support %l conversion. Don't assume an EMACS_INT
435 argument for integer conversions and for %c.
436
437 * lisp.h (doprnt): Restore prototype.
438
439 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
440 $(SRC)/character.h.
441
442 * Makefile.in (base_obj): Add back doprnt.o.
443
444 * deps.mk (doprnt.o): Add back prerequisites.
445 (callint.o): Depend on character.h.
446
447 * eval.c (internal_lisp_condition_case): Include the handler
448 representation in the error message.
449 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
450 when breaking from the loop.
451
452 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
453
454 * callint.c (Fcall_interactively): When displaying error message
455 about invalid control letter, pass the character's codepoint, not
456 a pointer to its multibyte form. Improve display of the character
457 in octal and display also its hex code.
458
459 * character.c (char_string): Use %x to display the (unsigned)
460 codepoint of an invalid character, to avoid displaying a bogus
461 negative value.
462
463 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
464 `error', not SYMBOL_NAME itself.
465
466 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
467 character arguments to `error'.
468
469 * charset.c (check_iso_charset_parameter): Fix incorrect argument
470 to `error' in error message about FINAL_CHAR argument. Make sure
471 FINAL_CHAR is a character, and use %c when it is passed as
472 argument to `error'.
473
4ffd0d6b 4742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
475
476 * s/ms-w32.h (localtime): Redirect to sys_localtime.
477
478 * w32.c: Include <time.h>.
479 (sys_localtime): New function.
480
4ffd0d6b 4812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
482
483 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
484
4ffd0d6b 485 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 486
4ffd0d6b 4872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 488
4ffd0d6b
GM
489 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
490 zombies (Bug#8467).
aac0c6e3 491
04c56954
EZ
4922011-04-19 Eli Zaretskii <eliz@gnu.org>
493
494 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
495 gl_state.e_property when gl_state.object is Qt.
496
497 * insdel.c (make_gap_larger): Remove limitation of buffer size
498 to <= INT_MAX.
499
16a43933
CY
5002011-04-18 Chong Yidong <cyd@stupidchicken.com>
501
502 * xdisp.c (lookup_glyphless_char_display)
503 (produce_glyphless_glyph): Handle cons cell entry in
504 glyphless-char-display.
505 (Vglyphless_char_display): Document it.
506
507 * term.c (produce_glyphless_glyph): Handle cons cell entry in
508 glyphless-char-display.
509
4581706e
CY
5102011-04-17 Chong Yidong <cyd@stupidchicken.com>
511
512 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
513
514 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
515
516 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
517 definition for no-X builds.
518
4887c6e2 5192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 520
fd35b6f9
PE
521 Static checks with GCC 4.6.0 and non-default toolkits.
522
5c1ccb01
PE
523 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
524
006c5daa
PE
525 * process.c (keyboard_bit_set): Define only if SIGIO.
526 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
527 (send_process): Repair possible setjmp clobbering.
528
efc736d3
PE
529 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
530
4e2fe2e6
PE
531 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
532
f97334a2
PE
533 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
534
4e75f29d
PE
535 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
536 Define only if needed.
537
90efadd1
PE
538 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
539 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 540 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 541
3c647824
PE
542 * dispextern.h (struct redisplay_interface): Rename param
543 to avoid shadowing.
e264f262 544 * termhooks.h (struct terminal): Likewise.
761383f4 545 * xterm.c (xembed_send_message): Likewise.
3c647824 546
b58c5c4a
PE
547 * insdel.c (make_gap_smaller): Define only if
548 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
549
cad59032
PE
550 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
551 it.
552
c339dc2e
PE
553 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
554 so that we aren't warned about unused symbols.
555
91a3e27b
PE
556 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
557
399c71d3 558 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 559
8ffc96f5
PE
560 * xfns.c (x_real_positions): Mark locals as initialized.
561
eef9bc79
PE
562 * xmenu.c (xmenu_show): Don't use uninitialized vars.
563
098db9dd
PE
564 * xterm.c: Fix problems found by static analysis with other toolkits.
565 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
566 (x_dispatch_event): Declare static if USE_GTK, and
567 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 568 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 569 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
570 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
571 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 572
eb18f6cc
PE
573 * xmenu.c (menu_help_callback): Pointer type fixes.
574 Use const pointers when pointing at readonly data. Avoid pointer
575 signedness clashes.
576 (FALSE): Remove unused macro.
577 (update_frame_menubar): Remove unused decl.
578
1fe72bf8
PE
579 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
580
60d9e1db
PE
581 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
582 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
583 (single_menu_item): Rename local to avoid shadowing.
584
39261c26
PE
585 * keyboard.c (make_lispy_event): Remove unused local var.
586
018c5e19
PE
587 * frame.c, frame.h (x_get_resource_string): Bring this back, but
588 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
589
63d2b86e
PE
590 * bitmaps: Change bitmaps from unsigned char back to the X11
591 compatible char. Avoid the old compiler warnings about
592 out-of-range initializers by using, for example, '\xab' rather
593 than 0xab.
594
aefd87e1
PE
595 * xgselect.c (xgselect_initialize): Check vs interface
596 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
597
bf501fb9
PE
598 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
599
e9829fdf
PE
600 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
601 to read-only memory.
602
1086c095
PE
603 * fns.c (vector): Remove; this old hack is no longer needed.
604
2baccd04 605 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 606 Remove unused var.
dde42981 607 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 608
72391843 609 * xrdb.c (x_load_resources): Omit unused local.
3565b346 610
436c16df 611 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 612 (x_window): Rename locals to avoid shadowing.
dc5ddd85 613 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 614
92bb796d 615 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 616 (x_term_init): Remove local to avoid shadowing.
92bb796d 617
764430a3 618 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
619
620 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
621 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
622
d1dfb56c
EZ
6232011-04-16 Eli Zaretskii <eliz@gnu.org>
624
c4354cb4
EZ
625 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
626
d1dfb56c
EZ
627 Fix regex.c, syntax.c and friends for buffers > 2GB.
628 * syntax.h (struct gl_state_s): Declare character position members
629 EMACS_INT.
630
631 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
632
633 * textprop.c (verify_interval_modification, interval_of): Declare
634 arguments EMACS_INT.
635
636 * intervals.c (adjust_intervals_for_insertion): Declare arguments
637 EMACS_INT.
638
639 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
640
641 * indent.c (Fvertical_motion): Local variable it_start is now
642 EMACS_INT.
643
644 * regex.c (re_match, re_match_2, re_match_2_internal)
645 (bcmp_translate, regcomp, regexec, print_double_string)
646 (group_in_compile_stack, re_search, re_search_2, regex_compile)
647 (re_compile_pattern, re_exec): Declare arguments and local
648 variables `size_t' and `ssize_t' and return values `regoff_t', as
649 appropriate.
650 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
651 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
652 <compile_stack_type>: `size' and `avail' are now `size_t'.
653
654 * regex.h <regoff_t>: Use ssize_t, not int.
655 (re_search, re_search_2, re_match, re_match_2): Arguments that
656 specify buffer/string position and length are now ssize_t and
657 size_t. Return type is regoff_t.
658
613052cd
BK
6592011-04-16 Ben Key <bkey76@gmail.com>
660
661 * nsfont.m: Fixed bugs in ns_get_family and
662 ns_descriptor_to_entity that were caused by using free to
663 deallocate memory blocks that were allocated by xmalloc (via
664 xstrdup). This caused Emacs to crash when compiled with
665 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
666 --enable-checking=xmallocoverrun). xfree is now used to
667 deallocate these memory blocks.
668
4170f62f 6692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 670
71b41406
PE
671 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
672
9587a89d
PE
673 emacs_write: Accept and return EMACS_INT for sizes.
674 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
675 et seq.
676 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
677 Accept and return EMACS_INT.
678 (emacs_gnutls_write): Return the number of bytes written on
679 partial writes.
680 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
681 (emacs_read, emacs_write): Remove check for negative size, as the
682 Emacs source code has been audited now.
9587a89d
PE
683 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
684 (emacs_read, emacs_write): Use it.
273a5f82
PE
685 * process.c (send_process): Adjust to the new signatures of
686 emacs_write and emacs_gnutls_write. Do not attempt to store
687 a byte offset into an 'int'; it might overflow.
9587a89d 688 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 689
3e047f51
PE
690 * sound.c: Don't assume sizes fit in 'int'.
691 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 692 Return EMACS_INT, not int.
3e047f51 693 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
694 Accept EMACS_INT, not int.
695 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
696 record read return values.
697
cc39a9db
BK
6982011-04-15 Ben Key <bkey76@gmail.com>
699
c9d0ec6d
JB
700 * keyboard.c (Qundefined): Don't declare static since it is used
701 in nsfns.m.
702 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
703 static since they are used in nsfont.m.
cc39a9db 704
6c60eb9f
SM
7052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
706
707 * process.c (Qprocessp): Don't declare static.
708 * lisp.h (Qprocessp): Declare again.
709
7990b61a
JB
7102011-04-15 Juanma Barranquero <lekktu@gmail.com>
711
712 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
713
5d4cb038
PE
7142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
715
8bd7b830 716 Improve C-level modularity by making more things 'static'.
cd64ea1d 717
e3b27b31
PE
718 Don't publish debugger-only interfaces to other modules.
719 * lisp.h (safe_debug_print, debug_output_compilation_hack):
720 (verify_bytepos, count_markers): Move decls to the only modules
721 that need them.
722 * region-cache.h (pp_cache): Likewise.
723 * window.h (check_all_windows): Likewise.
724 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
725
5d4cb038
PE
726 * sysdep.c (croak): Now static, if
727 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
728 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
729
730 * alloc.c (refill_memory_reserve): Now static if
731 !defined REL_ALLOC || defined SYSTEM_MALLOC.
732 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 733
e87b6180
PE
734 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
735 Define only if USE_LUCID.
736
ac64929e
PE
737 * xrdb.c (x_customization_string, x_rm_string): Now static.
738
6f37259d
PE
739 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
740 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
741
1683e3ab
PE
742 * xdisp.c (draw_row_with_mouse_face): Now static.
743 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
744
de9c2632
PE
745 * window.h (check_all_windows): Mark externally visible.
746
2b96acb7
PE
747 * window.c (window_deletion_count): Now static.
748
749 * undo.c: Make symbols static if they're not exported.
750 (last_undo_buffer, last_boundary_position, pending_boundary):
751 Now static.
752
50436f33
PE
753 * textprop.c (interval_insert_behind_hooks): Now static.
754 (interval_insert_in_front_hooks): Likewise.
755
64520e5c
PE
756 * term.c: Make symbols static if they're not exported.
757 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
758 (max_frame_lines, tty_set_terminal_modes):
759 (tty_reset_terminal_modes, tty_turn_off_highlight):
760 (get_tty_terminal): Now static.
761 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
762 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 763 HAVE_WINDOW_SYSTEM.
64520e5c
PE
764 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
765 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
766
1fa53021
PE
767 * sysdep.c: Make symbols static if they're not exported.
768 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
769 Now static.
770 (sigprocmask_set, full_mask): Remove; unused.
771 (wait_debugging): Mark as visible.
772 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
773 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
774
d4b43b22
PE
775 * syntax.c (syntax_temp): Define only if !__GNUC__.
776
b7c513d0
PE
777 * sound.c (current_sound_device, current_sound): Now static.
778
989b29ad
PE
779 * search.c (searchbufs, searchbuf_head): Now static.
780
13a55a78
PE
781 * scroll.c (scroll_cost): Remove; unused.
782 * dispextern.h (scroll_cost): Remove decl.
783
de68a1fc
PE
784 * region-cache.h (pp_cache): Mark as externally visible.
785
40ccffa6
PE
786 * process.c: Make symbols static if they're not exported.
787 (process_tick, update_tick, create_process, chan_process):
788 (Vprocess_alist, proc_buffered_char, datagram_access):
789 (fd_callback_data, send_process_frame, process_sent_to): Now static.
790 (deactivate_process): Mark defn as static, as well as decl.
791 * lisp.h (create_process): Remove decl.
792 * process.h (chan_process, Vprocess_alist): Remove decls.
793
ad64fc97
PE
794 * print.c: Make symbols static if they're not exported.
795 (print_depth, new_backquote_output, being_printed, print_buffer):
796 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
797 (print_interval, print_number_index, initial_stderr_stream):
798 Now static.
799 * lisp.h (Fprinc): Remove decl.
800 (debug_output_compilation_hack): Mark as externally visible.
801
adddb265
PE
802 * sysdep.c (croak): Move decl from here to syssignal.h.
803 * syssignal.h (croak): Put it here, so the API can be checked when
804 'croak' is called from dissociate_if_controlling_tty.
805
1717ede2
PE
806 * minibuf.c: Make symbols static if they're not exported.
807 (minibuf_save_list, choose_minibuf_frame): Now static.
808 * lisp.h (choose_minibuf_frame): Remove decl.
809
fa5fb2bc
PE
810 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
811
1e3890d1
PE
812 * lread.c: Make symbols static if they're not exported.
813 (read_objects, initial_obarray, oblookup_last_bucket_number):
814 Now static.
815 (make_symbol): Remove; unused.
816 * lisp.h (initial_obarray, make_symbol): Remove decls.
817
8a1414fa
PE
818 * keyboard.c: Make symbols static if they're not exported.
819 (single_kboard, recent_keys_index, total_keys, recent_keys):
820 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
821 (this_single_command_key_start, echoing, last_auto_save):
822 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
823 (command_loop, echo_now, keyboard_init_hook, help_char_p):
824 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
825 (Vlispy_mouse_stem, double_click_count):
826 Now static.
827 (force_auto_save_soon): Define only if SIGDANGER.
828 (ignore_mouse_drag_p): Now static if
829 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
830 (print_help): Remove; unused.
831 (stop_character, last_timer_event): Mark as externally visible.
832 * keyboard.h (ignore_mouse_drag_p): Declare only if
833 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
834 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
835 * lisp.h (echoing): Remove decl.
836 (force_auto_save_soon): Declare only if SIGDANGER.
837 * xdisp.c (redisplay_window): Simplify code, to make it more
838 obvious that ignore_mouse_drag_p is not accessed if !defined
839 USE_GTK && !defined HAVE_NS.
840
93ea6e8f
PE
841 * intervals.c: Make symbols static if they're not exported.
842 (merge_properties_sticky, merge_interval_right, delete_interval):
843 Now static.
844 * intervals.h (merge_interval_right, delete_interval): Remove decls.
845
77382fcc
PE
846 * insdel.c: Make symbols static if they're not exported.
847 However, leave prepare_to_modify_buffer alone. It's never
848 called from outside this function, but that appears to be a bug.
849 (combine_after_change_list, combine_after_change_buffer):
4889fc82 850 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
851 (adjust_after_replace_noundo): Remove; unused.
852 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 853 (signal_before_change): Remove decls.
77382fcc 854
9306c32e
PE
855 * indent.c (val_compute_motion, val_vmotion): Now static.
856
cd44d2eb
PE
857 * image.c: Make symbols static if they're not exported.
858 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
859 if USE_GTK.
860 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
861 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
862
ad9a7a06
PE
863 * fringe.c (standard_bitmaps): Now static.
864 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
865
81626931
PE
866 * frame.c: Make symbols static if they're not exported.
867 (x_report_frame_params, make_terminal_frame): Now static.
868 (get_frame_param): Now static, unless HAVE_NS.
869 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
870 (x_get_resource_string): Remove; not used.
871 * frame.h (make_terminal_frame, x_report_frame_params):
872 (x_get_resource_string); Remove decls.
873 (x_fullscreen_adjust): Declare only if WINDOWSNT.
874 * lisp.h (get_frame_param): Declare only if HAVE_NS.
875
239f9db9
PE
876 * font.c, fontset.c: Make symbols static if they're not exported.
877 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
878 (FACE_SUITABLE_FOR_CHAR_P): Use it.
879 * font.c (font_close_object): Now static.
880 * font.h (font_close_object): Remove.
881 * fontset.c (FONTSET_OBJLIST): Remove.
882 (free_realized_fontset) #if-0 the body, which does nothing.
883 (face_suitable_for_char_p): #if-0, as it's never called.
884 * fontset.h (face_suitable_for_char_p): Remove decl.
885 * xfaces.c (face_at_string_position): Use
886 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
887 since 0 is always ASCII.
888
dfcf3579
PE
889 * fns.c (weak_hash_tables): Now static.
890
5045092b
PE
891 * fileio.c: Make symbols static if they're not exported.
892 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
893 (Vwrite_region_annotation_buffers): Now static.
894
57a96f5c
PE
895 * eval.c: Make symbols static if they're not exported.
896 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
897 * lisp.h (backtrace_list): Remove decl.
898
35f08c38
PE
899 * emacs.c: Make symbols static if they're not exported.
900 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
901 (fatal_error_code, fatal_error_signal_hook, standard_args):
902 Now static.
903 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
904 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
905 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
906 * lisp.h (fatal_error_signal_hook): Remove decl.
907 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
908
f44bd759
PE
909 * editfns.c: Move a (normally-unused) function to its only use.
910 * editfns.c, lisp.h (get_operating_system_release): Remove.
911 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
912 worth the hassle of breaking this out.
913
b532497d
PE
914 * xterm.c: Make symbols static if they're not exported.
915 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
916 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
917 (x_destroy_window, x_delete_display):
918 Now static.
919 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
920 (x_mouse_leave): Remove; unused.
921 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
922 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
923 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
924 Remove decls.
925 (x_mouse_leave): Declare only if WINDOWSNT.
926 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
927 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
928 USE_X_TOOLKIT.
929
1675728f
PE
930 * ftxfont.c: Make symbols static if they're not exported.
931 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
932 HAVE_FREETYPE.
933 * font.h (ftxfont_driver): Likewise.
934
e4cebfca
PE
935 * xfns.c: Make symbols static if they're not exported.
936 (x_last_font_name, x_display_info_for_name):
937 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
938 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
939 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
940 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
941 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
942 (last_show_tip_args): Now static.
943 (xic_defaut_fontset, xic_create_fontsetname): Define only if
944 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
945 (x_screen_planes): Remove; unused.
946 * dispextern.h (x_screen_planes): Remove decl.
947
5bf46f05
PE
948 * dispnew.c: Make symbols static if they're not exported.
949 * dispextern.h (redraw_garbaged_frames, scrolling):
950 (increment_row_positions): Remove.
951 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
952 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
953 Now static.
954 (redraw_garbaged_frames): Remove; unused.
955
435f4c28
PE
956 * xfaces.c: Make symbols static if they're not exported.
957 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
958 Remove decls.
959 * xterm.h (defined_color): Remove decls.
960 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
961 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
962 (menu_face_changed_default, defined_color, free_realized_face):
963 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
964 (ascii_face_of_lisp_face): Remove; unused.
965
8524aef3
PE
966 * xdisp.c: Make symbols static if they're not exported.
967 * dispextern.h (scratch_glyph_row, window_box_edges):
968 (glyph_to_pixel_coords, set_cursor_from_row):
969 (get_next_display_element, set_iterator_to_next):
970 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
971 (show_mouse_face): Remove decls
972 * frame.h (message_buf_print): Likewise.
973 * lisp.h (pop_message, set_message, check_point_in_composition):
974 Likewise.
975 * xterm.h (set_vertical_scroll_bar): Likewise.
976 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
977 (message_buf_print, scratch_glyph_row, displayed_buffer):
978 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
979 (get_next_display_element, show_mouse_face, window_box_edges):
980 (frame_to_window_pixel_xy, check_point_in_composition):
981 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
982 (glyph_to_pixel_coords): Remove; unused.
983
16390cd2
PE
984 * dired.c (file_name_completion): Now static.
985
986 * dbusbind.c (xd_in_read_queued_messages): Now static.
987
a25f4dfa
PE
988 * lisp.h (circular_list_error, FOREACH): Remove; unused.
989 * data.c (circular_list_error): Remove.
990
14a9c8df
PE
991 * commands.h (last_point_position, last_point_position_buffer):
992 (last_point_position_window): Remove decls.
993 * keyboard.c: Make these variables static.
994
74ab6df5
PE
995 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
996 decls.
997 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
998 (iso_code_class, detect_coding, code_convert_region): Now static.
999 (encode_coding_gap): Remove; unused.
1000
38dfbee1
PE
1001 * chartab.c (chartab_chars, chartab_bits): Now static.
1002
a2cb4e63
PE
1003 * charset.h (charset_iso_8859_1): Remove decl.
1004 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1005 Now static.
1006
127198fd
PE
1007 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1008 * ccl.c (Vccl_program_table): Now static.
1009 (check_ccl_update): Remove; unused.
1010
d85b608f
PE
1011 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1012 * category.h: ... from here.
1013 * category.c (check_category_table, set_category_set): Now static.
1014
31cd66f3
PE
1015 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1016 * lisp.h: Remove these decls.
1017
c358e587
PE
1018 * buffer.c (buffer_count): Remove unused var.
1019
e78aecca
PE
1020 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1021 so that it's not optimized away.
1022 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1023 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1024 exported only to the debugger.
1025
e192d7d3
PE
1026 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1027 * atimer.h (run_all_atimers): Removed; not exported.
1028
92470028
PE
1029 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1030 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1031 was inaccessible from Lisp.
1032 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1033 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1034
244ed907
PE
1035 alloc.c: Import and export fewer symbols, and remove unused items.
1036 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1037 is defined.
1038 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1039 it's not optimized away by whole-program optimization.
1040 (message_enable_multibyte, free_misc): Remove.
1041 (catchlist, handlerlist, mark_backtrace):
1042 Declare only if BYTE_MARK_STACK.
1043 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1044 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1045 (message_enable_multibyte): Remove decl.
1046 (free_misc, interval_free_list, float_block, float_block_index):
1047 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1048 (cons_free_list, last_marked_index):
1049 Now static.
1050 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1051 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1052 (mark_backtrace): Define only if BYTE_MARK_STACK.
1053 * xdisp.c (message_enable_multibyte): Now static.
1054
61c2b50e 1055 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1056 This makes it easier for human readers (and static analyzers)
1057 to see whether these variables are used from other modules.
1058 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1059 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1060 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1061 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1062 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1063 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1064 * xmenu.c, xselect.c:
1065 Declare Q* vars static if they are not used in other modules.
1066 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1067 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1068 Remove decls of unexported vars.
1069 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1070
95c82688
PE
1071 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1072
16a97296
PE
1073 Make Emacs functions such as Fatom 'static' by default.
1074 This makes it easier for human readers (and static analyzers)
1075 to see whether these functions can be called from other modules.
1076 DEFUN now defines a static function. To make the function external
1077 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1078 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1079 (Finit_image_library):
16a97296
PE
1080 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1081 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1082 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1083 Remove decls, since these functions are now static.
1084 (Funintern, Fget_internal_run_time): New decls, since these functions
1085 were already external.
95c82688 1086
16a97296
PE
1087 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1088 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1089 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1090 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1091 * keyboard.c, keymap.c, lread.c:
1092 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1093 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1094 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1095 Mark functions with DEFUE instead of DEFUN,
1096 if they are used in other modules.
1097 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1098 decls for now-static functions.
1099 * buffer.h (Fdelete_overlay): Remove decl.
1100 * callproc.c (Fgetenv_internal): Mark as internal.
1101 * composite.c (Fremove_list_of_text_properties): Remove decl.
1102 (Fcomposition_get_gstring): New forward static decl.
1103 * composite.h (Fcomposite_get_gstring): Remove decl.
1104 * dired.c (Ffile_attributes): New forward static decl.
1105 * doc.c (Fdocumntation_property): New forward static decl.
1106 * eval.c (Ffetch_bytecode): New forward static decl.
1107 (Funintern): Remove extern decl; now in .h file where it belongs.
1108 * fileio.c (Fmake_symbolic_link): New forward static decl.
1109 * image.c (Finit_image_library): New forward static decl.
1110 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1111 * intervals.h (Fprevious_property_change):
1112 (Fremove_list_of_text_properties): Remove decls.
1113 * keyboard.c (Fthis_command_keys): Remove decl.
1114 (Fcommand_execute): New forward static decl.
1115 * keymap.c (Flookup_key): New forward static decl.
1116 (Fcopy_keymap): Now static.
1117 * keymap.h (Flookup_key): Remove decl.
1118 * process.c (Fget_process): New forward static decl.
1119 (Fprocess_datagram_address): Mark as internal.
1120 * syntax.c (Fsyntax_table_p): New forward static decl.
1121 (skip_chars): Remove duplicate decl.
1122 * textprop.c (Fprevious_property_change): New forward static decl.
1123 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1124 Now internal.
1125 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1126 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1127
785bbd42
PE
1128 * editfns.c (Fformat): Remove unreachable code.
1129
8b913b57
AS
11302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1131
1132 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1133 change. (Bug#8496)
1134
a6744a35
EZ
11352011-04-13 Eli Zaretskii <eliz@gnu.org>
1136
1137 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1138 when at ZV. (Bug#8487)
1139
e7974947
AS
11402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1141
baad03f0
AS
1142 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1143 (Bug#8437)
1144 * keyboard.c (parse_tool_bar_item): Likewise.
1145 * sound.c (sound_cleanup, alsa_close): Likewise.
1146 * termcap.c (tgetent): Likewise.
1147 * xfns.c (x_default_font_parameter): Likewise.
1148 * xsettings.c (read_and_apply_settings): Likewise.
1149
e7974947
AS
1150 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1151 (overrun_check_free): Protoize.
1152
28272684
PE
11532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1154
1155 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1156 since callers should never pass a negative size.
1157 Change the signature to match that of plain 'read' and 'write'; see
1158 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1159 * lisp.h: Update prototypes of emacs_write and emacs_read.
1160
11997c76
EZ
11612011-04-11 Eli Zaretskii <eliz@gnu.org>
1162
1163 * xdisp.c (redisplay_window): Don't try to determine the character
1164 position of the scroll margin if the window start point w->startp
e896f03c 1165 is outside the buffer's accessible region. (Bug#8468)
11997c76 1166
8a2cbd72
EZ
11672011-04-10 Eli Zaretskii <eliz@gnu.org>
1168
1169 Fix write-region and its subroutines for buffers > 2GB.
1170 * fileio.c (a_write, e_write): Modify declaration of arguments and
1171 local variables to support buffers larger than 2GB.
1172 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1173
1174 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1175 argument, local variables, and return value.
1176
1177 * lisp.h: Update prototypes of emacs_write and emacs_read.
1178
1179 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1180
4073e537 11812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1182
1ebfdcb6
PE
1183 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1184
b2ded58d
PE
1185 Fix more problems found by GCC 4.6.0's static checks.
1186
7d66342c
PE
1187 * xdisp.c (vmessage): Use a better test for character truncation.
1188
bbf47d44
PE
1189 * charset.c (load_charset_map): <, not <=, for optimization,
1190 and to avoid potential problems with integer overflow.
9248994d 1191 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1192 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1193 * editfns.c (Fformat): Likewise.
1e69125e 1194 * syntax.c (skip_chars): Likewise.
3befa583 1195
e3019616
PE
1196 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1197 This also lets GCC 4.6.0 generate slightly better loop code.
1198
becfa255
PE
1199 * callint.c (Fcall_interactively): <, not <=, for optimization.
1200 (Fcall_interactively): Count the number of arguments produced,
1201 not the number of arguments given. This is simpler and lets GCC
1202 4.6.0 generate slightly better code.
1203
dae0cd48
PE
1204 * ftfont.c: Distingish more carefully between FcChar8 and char.
1205 The previous code passed unsigned char * to a functions like
1206 strlen and xstrcasecmp that expect char *, which does not
1207 conform to the C standard.
1208 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1209 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1210 char * when the C standard requires it.
1211
76032d70
PE
1212 * keyboard.c (read_char): Remove unused var.
1213
eb3f1cc8
PE
1214 * eval.c: Port to Windows vsnprintf (Bug#8435).
1215 Include <limits.h>.
1216 (SIZE_MAX): Define if the headers do not.
1217 (verror): Do not give up if vsnprintf returns a negative count.
1218 Instead, grow the buffer. This ports to Windows vsnprintf, which
1219 does not conform to C99. Problem reported by Eli Zaretskii.
1220 Also, simplify the allocation scheme, by avoiding the need for
1221 calling realloc, and removing the ALLOCATED variable.
1222
70476b54
PE
1223 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1224
12020a9e
PE
1225 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1226 But keep the doprint source code for now, as we might revamp it
1227 and use it again (Bug#8435).
ea6c7ae6
PE
1228 * lisp.h (doprnt): Remove.
1229 * Makefile.in (base_obj): Remove doprnt.o.
1230 * deps.mk (doprnt.o): Remove.
1231
5fdb398c
PE
1232 error: Print 32- and 64-bit integers portably (Bug#8435).
1233 Without this change, on typical 64-bit hosts error ("...%d...", N)
1234 was used to print both 32- and 64-bit integers N, which relied on
1235 undefined behavior.
1236 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1237 New macro.
1238 * lisp.h (error, verror): Mark as printf-like functions.
1239 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1240 Report overflow in size calculations when allocating printf buffer.
1241 Do not truncate output string at its first null byte.
1242 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1243 Truncate the output at a character boundary, since vsnprintf does not
1244 do that.
1245 * charset.c (check_iso_charset_parameter): Convert internal
1246 character to string before calling 'error', since %c now has the
1247 printf meaning.
1248 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1249 overflow when computing char to be passed to 'error'. Do not
1250 pass Lisp_Object to 'error'; pass the integer instead.
1251 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1252 formatted with plain %d.
1253
b189fa66
PE
1254 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1255
bff87ef0
PE
1256 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1257
7e2cac20
PE
1258 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1259
ce4d90b5
PE
1260 * xterm.c (x_catch_errors): Remove duplicate declaration.
1261
266c9547
PE
1262 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1263
79c49ad2
PE
1264 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1265
368f4090
JM
12662011-04-10 Jim Meyering <meyering@redhat.com>
1267
1268 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1269 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1270 return ssize_t not "int", and use size_t as the buffer length.
1271 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1272 * gnutls.h: Update declarations.
1273 * process.c (read_process_output): Use ssize_t, to match.
1274 (send_process): Likewise.
1275
a32d4040
CY
12762011-04-09 Chong Yidong <cyd@stupidchicken.com>
1277
1278 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1279
8546720e 12802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1281
8546720e
GM
1282 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1283 unsigned char, to match FcChar8 type definition.
aac0c6e3 1284
8546720e
GM
1285 * xterm.c (handle_one_xevent):
1286 * xmenu.c (create_and_show_popup_menu):
1287 * xselect.c (x_decline_selection_request)
1288 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1289
0a2f5c1a 12902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1291
1292 Fix some uses of `int' instead of EMACS_INT.
1293 * search.c (string_match_1, fast_string_match)
1294 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1295 (scan_buffer, find_next_newline_no_quit)
1296 (find_before_next_newline, search_command, Freplace_match)
1297 (Fmatch_data): Make some `int' variables be EMACS_INT.
1298
1299 * xdisp.c (display_count_lines): 3rd argument and return value now
1300 EMACS_INT. All callers changed.
1301 (pint2hrstr): Last argument is now EMACS_INT.
1302
1303 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1304 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1305 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1306 (decode_coding_utf_16, decode_coding_emacs_mule)
1307 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1308 (decode_coding_ccl, decode_coding_charset)
1309 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1310 (decode_coding_iso_2022, decode_coding_emacs_mule)
1311 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1312 <char_offset, last_offset>: Declare EMACS_INT.
1313 (encode_coding_utf_8, encode_coding_utf_16)
1314 (encode_coding_emacs_mule, encode_invocation_designation)
1315 (encode_designation_at_bol, encode_coding_iso_2022)
1316 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1317 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1318 Declare EMACS_INT.
1319 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1320 (encode_invocation_designation): Last argument P_NCHARS is now
1321 EMACS_INT.
1322 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1323 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1324
1325 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1326 All users changed.
1327
1328 * ccl.c (Fccl_execute_on_string): Declare some variables
1329 EMACS_INT.
1330
8546720e 13312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1332
1333 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1334
4e19a977
CS
13352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1336
1337 * process.c (Fformat_network_address): Doc fix.
1338
87302331
R
13392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1340
1341 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1342
cbb59342
CY
13432011-04-08 Chong Yidong <cyd@stupidchicken.com>
1344
1345 * keyboard.c (read_char): Call Lisp function help-form-show,
1346 instead of using internal_with_output_to_temp_buffer.
1347 (Qhelp_form_show): New var.
e0d38eeb 1348 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1349
1350 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1351
1352 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1353
e67a13ab
CY
13542011-04-06 Chong Yidong <cyd@stupidchicken.com>
1355
1356 * process.c (Flist_processes): Removed to Lisp.
1357 (list_processes_1): Deleted.
1358
973f782d
EZ
13592011-04-06 Eli Zaretskii <eliz@gnu.org>
1360
7c106b1e
EZ
1361 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1362
973f782d
EZ
1363 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1364
41cf7d1a 13652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1366
ca23cc88
PE
1367 Fix more problems found by GCC 4.6.0's static checks.
1368
f390e2d5
PE
1369 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1370
42eea0d0
PE
1371 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1372
b69769da 1373 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1374
f9541e84
PE
1375 * xdisp.c (vmessage): Mark as a printf-like function.
1376
13841b55
PE
1377 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1378
c136c10f
PE
1379 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1380
5e2d4a30
PE
1381 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1382 printf-like functions.
1383 (tiff_load): Add casts to remove these marks before passing them
1384 to system-supplied API.
1385
583f48b9
PE
1386 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1387
b25d760e
PE
1388 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1389 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1390 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1391 directly, rather than having caller test rule sign. This avoids
1392 some unnecessary tests.
1393 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1394 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1395 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1396
bc7b6697 1397 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1398 (xfont_open): Avoid unnecessary tests.
bc7b6697 1399
27ccc379
PE
1400 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1401
dcd5c89a
PE
1402 * composite.h, composite.c (composition_gstring_put_cache):
1403 Use EMACS_INT, not int, for length.
1404
b13a45c6
PE
1405 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1406 breaking out part of COMPOSITION_DECODE_RULE.
1407 (COMPOSITION_DECODE_RULE): Use it.
1408 * composite.c (get_composition_id): Remove unused local vars,
1409 by using the new macro.
1410
1e792e4d
PE
1411 * textprop.c (set_text_properties_1): Change while to do-while,
1412 since the condition is always true at first.
1413
dc6c6455 1414 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1415 (interval_deletion_adjustment): Return unsigned value.
1416 All uses changed.
dc6c6455 1417
aba7731a
PE
1418 * process.c (list_processes_1, create_pty, read_process_output):
1419 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1420 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1421 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1422 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1423 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1424
fdfc4bf3
PE
1425 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1426
fca8fe46 1427 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1428 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1429
06a0259a 1430 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1431 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1432 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1433
e7b9e80f
PE
1434 * print.c (print_error_message): Avoid int overflow.
1435
56201685
PE
1436 * font.c (font_list_entities): Redo for clarity,
1437 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1438
78834453 1439 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1440 (font_score): Avoid potential overflow in diff calculation.
78834453 1441
0bc0b309 1442 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1443 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1444
e610eaca
PE
1445 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1446
b895abce
PE
1447 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1448 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1449 can always succeed if overflow has undefined behavior.
1450
1f1d9321 1451 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1452 (wordify): Omit three unnecessary tests.
1f1d9321 1453
c59478bc
PE
1454 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1455 All callers changed. This avoids the need for an unused var.
1456
79b73827
PE
1457 * casefiddle.c (casify_region): Remove var that is set but not used.
1458
a4db5dfe
PE
1459 * dired.c (file_name_completion): Remove var that is set but not used.
1460
43aae36e
PE
1461 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1462
2a47c44d 1463 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1464 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1465
a37c69bf
PE
1466 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1467 Check for integer overflow on size calculations.
1468
328ab8e7
PE
1469 * buffer.c (Fprevious_overlay_change): Remove var that is set
1470 but not used.
1471
e5a2a5cb
PE
1472 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1473 Remove vars that are set but not used.
8d84a6eb 1474 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1475 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1476
a60e5f68
PE
1477 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1478
f661cb61 1479 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1480 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1481
f0397f5a
PE
1482 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1483 that are set but not used.
1484
8664db06 1485 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1486 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1487
6abdaa4a
PE
1488 * xselect.c (x_get_local_selection, x_handle_property_notify):
1489 Remove vars that are set but not used.
1490
0ce7538d 1491 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1492 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1493
9ae848fc
PE
1494 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1495 Remove var that is set but not used.
0b918413
PE
1496 (scroll_bar_windows_size): Now size_t, not int.
1497 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1498 Check for overflow.
9ae848fc 1499
a5a62657
PE
1500 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1501 (map_tty_color) [!defined MSDOS]: Likewise.
1502
5c5cdd39
PE
1503 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1504
66ebf983
PE
1505 * coding.c: Remove vars that are set but not used.
1506 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1507 All callers changed.
1508 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1509 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1510 (decode_coding_charset): Remove vars that are set but not used.
1511
1be4d761
PE
1512 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1513 that is set but not used.
1514
47553fa8
PE
1515 * print.c (print_object): Remove var that is set but not used.
1516
1f7196bf 1517 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1518 The gnulib version avoids calling malloc in the usual case,
1519 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1520 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1521 * filelock.c (current_lock_owner): Likewise.
1522 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1523 * sysdep.c: Include allocator.h, careadlinkat.h.
1524 (emacs_no_realloc_allocator): New static constant.
1525 (emacs_readlink): New function.
fdb61804
PE
1526 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1527 ../lib/careadlinkat.h.
d1fdcab7 1528
f84c17c7
SM
15292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1530
1531 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1532 first non-nil return value).
1533
ef3862ad
JD
15342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1535
1536 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1537 if not defined (Bug#8403).
1538
376a7006
JB
15392011-04-02 Juanma Barranquero <lekktu@gmail.com>
1540
1541 * xdisp.c (display_count_lines): Remove parameter `start',
1542 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1543 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1544 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1545 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1546 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1547 and thereabouts. All callers changed.
1548 (get_per_char_metric): Remove parameter `f', unused since
1549 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1550
6ca3801d
JM
15512011-04-02 Jim Meyering <meyering@redhat.com>
1552
1553 do not dereference NULL upon failed strdup
1554 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1555 (ns_get_family): Likewise.
1556
d8e2b5ba
JB
15572011-04-02 Juanma Barranquero <lekktu@gmail.com>
1558
1559 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1560
8c74fcbd
JD
15612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1562
1563 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1564 later (Bug#8403).
1565
7200d79c
SM
15662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1567
03408648 1568 Add lexical binding.
7200d79c 1569
03408648
SM
1570 * window.c (Ftemp_output_buffer_show): New fun.
1571 (Fsave_window_excursion):
1572 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1573
1574 * lread.c (lisp_file_lexically_bound_p): New function.
1575 (Fload): Bind Qlexical_binding.
1576 (readevalloop): Remove `evalfun' arg.
1577 Bind Qinternal_interpreter_environment.
1578 (Feval_buffer): Bind Qlexical_binding.
1579 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1580 Mark as dynamic.
1581 (syms_of_lread): Declare `lexical-binding'.
1582
1583 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1584
1585 * keyboard.c (eval_dyn): New fun.
1586 (menu_item_eval_property): Use it.
ca105506
SM
1587
1588 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1589
03408648
SM
1590 * fns.c (concat, mapcar1): Accept byte-code-functions.
1591
1592 * eval.c (Fsetq): Handle lexical vars.
1593 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1594 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1595 (FletX, Flet): Obey lexical binding.
1596 (Fcommandp): Handle closures.
1597 (Feval): New `lexical' arg.
1598 (eval_sub): New function extracted from Feval. Use it almost
1599 everywhere where Feval was used. Look up vars in lexical env.
1600 Handle closures.
1601 (Ffunctionp): Move from subr.el.
1602 (Ffuncall): Handle closures.
1603 (apply_lambda): Remove `eval_flags'.
1604 (funcall_lambda): Handle closures and new byte-code-functions.
1605 (Fspecial_variable_p): New function.
1606 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1607 but without exporting it to Lisp.
23aba0ea 1608
23aba0ea 1609 * doc.c (Fdocumentation, store_function_docstring):
03408648 1610 * data.c (Finteractive_form): Handle closures.
23aba0ea 1611
03408648
SM
1612 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1613 interactive spec.
ba83908c 1614
03408648
SM
1615 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1616 byte-codes.
1617 (exec_byte_code): New function extracted from Fbyte_code to handle new
1618 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1619
03408648 1620 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1621
03408648 1622 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1623
e2abce01
JB
16242011-03-31 Juanma Barranquero <lekktu@gmail.com>
1625
1626 * xdisp.c (redisplay_internal): Fix prototype.
1627
63696a73 16282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1629
63696a73
EZ
1630 * xdisp.c (SCROLL_LIMIT): New macro.
1631 (try_scrolling): Use it when setting scroll_limit. Limit
1632 scrolling to 100 screen lines.
1633 (redisplay_window): Even when falling back on "recentering",
1634 position point in the window according to scroll-conservatively,
1635 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1636
1637 (try_scrolling): When point is above the window, allow searching
1638 as far as scroll_max, or one screenful, to compute vertical
1639 distance from PT to the scroll margin position. This prevents
1640 try_scrolling from unnecessarily failing when
1641 scroll-conservatively is set to a value slightly larger than the
1642 window height. Clean up the case of PT below the margin at bottom
1643 of window: scroll_max can no longer be INT_MAX. When aggressive
1644 scrolling is in use, don't let point enter the opposite scroll
1645 margin as result of the scroll.
1646 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1647 threshold of 100 lines for never-recentering scrolling.
1648
e4cc2dfc
JB
16492011-03-31 Juanma Barranquero <lekktu@gmail.com>
1650
1651 * dispextern.h (move_it_by_lines):
1652 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1653 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1654 (message_log_check_duplicate): Remove parameters `prev_bol' and
1655 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1656 (redisplay_internal): Remove parameter `preserve_echo_area',
1657 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1658
1659 * indent.c (Fvertical_motion):
1660 * window.c (window_scroll_pixel_based, Frecenter):
1661 Don't pass `need_y_p' to `move_it_by_lines'.
1662
1c470562
SM
16632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1664
44f230aa
SM
1665 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1666 steal a few bits to be more compact.
1667 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1668 Remove unneeded casts.
1669
1c470562
SM
1670 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1671
888adce9
ZK
16722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1673
1674 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1675 binding" message (bug#7967).
1676
f838ed7b
PE
16772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1678
77861b95
PE
1679 Fix more problems found by GCC 4.6.0's static checks.
1680
de6dbc14
PE
1681 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1682 Remove unused local var.
1683
f838ed7b
PE
1684 * editfns.c (Fmessage_box): Remove unused local var.
1685
792c7b2b
PE
1686 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1687 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1688 Omit unused local vars.
c499e557 1689 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1690 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1691 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1692 Omit unused local var.
1693
ba0165e1
PE
1694 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1695 Don't assume string length fits in int.
32ad8845 1696 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1697 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1698
3c59b4c9
PE
1699 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1700 instead of alloca (Bug#8344).
1701
a3eed478 1702 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1703 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1704
eb4d412d
PE
1705 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1706
1658b401
PE
1707 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1708 concerns.
1709
1710 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1711
1712 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1713
9a2c6e05
PE
1714 * keyboard.c (syms_of_keyboard): Use the same style as later
1715 in this function when indexing through an array. This also
1716 works around GCC bug 48267.
1717
03d0a109
PE
1718 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1719
44f730c8
PE
1720 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1721
fe75f926
PE
1722 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1723 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1724
ffa8c828
PE
1725 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1726 This avoids undefined behavior on integer overflow, and is a bit
1727 more convenient anyway since it is compared to a size_t variable.
1728
c5101a77
PE
1729 Variadic C functions now count arguments with size_t, not int.
1730 This avoids an unnecessary limitation on 64-bit machines, which
1731 caused (substring ...) to crash on large vectors (Bug#8344).
1732 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1733 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1734 All variadic functions and their callers changed accordingly.
c5101a77
PE
1735 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1736 * data.c (arith_driver, float_arith_driver): Likewise.
1737 * editfns.c (general_insert_function): Likewise.
1738 * eval.c (struct backtrace.nargs, interactive_p)
1739 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1740 (funcall_lambda, mark_backtrace): Likewise.
1741 * fns.c (concat): Likewise.
1742 * frame.c (x_set_frame_parameters): Likewise.
1743 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1744 0 if not found, not -1. All callers changed.
1745
dd3f25f7
PE
1746 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1747 (stack_copy_size): Now size_t, not int.
1748 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1749
461c2ab9
JB
17502011-03-28 Juanma Barranquero <lekktu@gmail.com>
1751
1752 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1753 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1754 All callers changed.
1755
1756 * lisp.h (multibyte_char_to_unibyte):
1757 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1758 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1759 * character.h (CHAR_TO_BYTE8):
1760 * cmds.c (internal_self_insert):
1761 * editfns.c (general_insert_function):
1762 * keymap.c (push_key_description):
1763 * search.c (Freplace_match):
1764 * xdisp.c (message_dolog, set_message_1): All callers changed.
1765
f6d62986
SM
17662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1767
1768 * keyboard.c (safe_run_hook_funcall): New function.
1769 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1770 don't set the hook to nil, but remove the offending function instead.
1771 (Qcommand_hook_internal): Remove, unused.
1772 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1773 Vcommand_hook_internal.
1774
1775 * eval.c (enum run_hooks_condition): Remove.
1776 (funcall_nil, funcall_not): New functions.
1777 (run_hook_with_args): Call each function through a `funcall' argument.
1778 Remove `cond' argument, now redundant.
1779 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1780 (Frun_hook_with_args_until_failure): Adjust accordingly.
1781 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1782
1db5b1ad
JB
17832011-03-28 Juanma Barranquero <lekktu@gmail.com>
1784
1785 * dispextern.h (string_buffer_position): Remove declaration.
1786
1787 * print.c (strout): Remove parameter `multibyte', unused since
1788 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1789
1790 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1791 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1792 All callers changed.
1793
1794 * w32.c (_wsa_errlist): Use braces for struct initializers.
1795
1796 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1797 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1798 All callers changed.
1799 (string_buffer_position): Likewise. Also, make static (it's never
1800 used outside xdisp.c).
1801 (cursor_row_p): Remove parameter `w', unused since
1802 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1803 (decode_mode_spec): Remove parameter `precision', introduced during
1804 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1805 All callers changed.
1806
5ffb62aa
JD
18072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1808
1809 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1810
461c2ab9 18112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1812
1813 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1814 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1815 (ns_update_auto_hide_menu_bar): New functions.
1816 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1817 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1818 ns_constrain_all_frames.
1819 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1820 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1821
5c380ffb
JD
18222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1823
1824 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1825
9af30bdf
GM
18262011-03-27 Glenn Morris <rgm@gnu.org>
1827
1828 * syssignal.h: Replace RETSIGTYPE with void.
1829 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1830 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1831 Replace SIGTYPE with void everywhere.
1832 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1833 * s/template.h (SIGTYPE): Remove commented out definition.
1834
e2abce01
JB
18352011-03-26 Eli Zaretskii <eliz@gnu.org>
1836
1837 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1838 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1839
f868cd8a
JB
18402011-03-26 Juanma Barranquero <lekktu@gmail.com>
1841
59eb0929
JB
1842 * w32.c (read_unc_volume): Use parameter `henum', instead of
1843 global variable `wget_enum_handle'.
1844
1845 * keymap.c (describe_vector): Remove parameters `indices' and
1846 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1847 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1848
f868cd8a
JB
1849 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1850
1851 * keyboard.c (timer_check): Remove parameter `do_it_now',
1852 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1853 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1854 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1855
1856 * keyboard.c (read_char):
1857 * w32menu.c (w32_menu_display_help):
1858 * xmenu.c (show_help_event, menu_help_callback):
1859 Adjust calls to `show_help_echo'.
1860
1861 * gtkutil.c (xg_maybe_add_timer):
1862 * keyboard.c (readable_events):
1863 * process.c (wait_reading_process_output):
1864 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1865
1866 * insdel.c (adjust_markers_gap_motion):
1867 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1868 (gap_left, gap_right): Don't call it.
1869
2ecf6fdb
CY
18702011-03-25 Chong Yidong <cyd@stupidchicken.com>
1871
1872 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1873 incurred during fontification.
1874
6b1f9ba4
JB
18752011-03-25 Juanma Barranquero <lekktu@gmail.com>
1876
1877 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1878 (DEFVAR_PER_BUFFER): Don't pass it.
1879
1880 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1881 (scrolling_window): Don't pass it.
1882
0f4a96b5
JB
18832011-03-25 Juanma Barranquero <lekktu@gmail.com>
1884
1885 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1886
1887 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1888 and `suffix'.
1889 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1890 of variables specific to SELinux and computation of `encoded_absname'.
1891
1892 * image.c (XPutPixel): Remove unused variable `height'.
1893
1894 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1895
1896 * unexw32.c (get_section_info): Remove unused variable `section'.
1897
1898 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1899 (system_process_attributes): Remove unused variable `sess'.
1900 (sys_read): Remove unused variable `err'.
1901
1902 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1903 (w32_wnd_proc): Remove unused variable `isdead'.
1904 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1905 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1906 (x_create_tip_frame): Remove unused variable `tem'.
1907
1908 * w32inevt.c (w32_console_read_socket):
1909 Remove unused variable `no_events'.
1910
1911 * w32term.c (x_draw_composite_glyph_string_foreground):
1912 Remove unused variable `width'.
1913
1149507c
JB
19142011-03-24 Juanma Barranquero <lekktu@gmail.com>
1915
1916 * w32term.c (x_set_glyph_string_clipping):
1917 Don't pass uninitialized region to CombineRgn.
1918
9c88f339
JB
19192011-03-23 Juanma Barranquero <lekktu@gmail.com>
1920
1921 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1922 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1923 (Fx_close_connection): Remove unused variable `i'.
1924
1925 * w32font.c (w32font_draw): Return number of glyphs.
1926 (w32font_open_internal): Remove unused variable `i'.
1927 (w32font_driver): Add missing initializer.
1928
1929 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1930 (fill_in_menu): Remove unused variable `items_added'.
1931
1932 * w32term.c (last_mouse_press_frame): Remove static global variable.
1933 (w32_clip_to_row): Remove unused variable `f'.
1934 (x_delete_terminal): Remove unused variable `i'.
1935
1936 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1937 (NOTHING): Remove unused static global variable.
1938 (uniscribe_check_otf): Remove unused variable `table'.
1939 (uniscribe_font_driver): Add missing initializers.
1940
dee091a3
JD
19412011-03-23 Julien Danjou <julien@danjou.info>
1942
1943 * term.c (Fsuspend_tty, Fresume_tty):
1944 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1945 * window.c (temp_output_buffer_show):
1946 * insdel.c (signal_before_change):
1947 * frame.c (Fhandle_switch_frame):
1948 * fileio.c (Fdo_auto_save):
1949 * emacs.c (Fkill_emacs):
1950 * editfns.c (save_excursion_restore):
1951 * cmds.c (internal_self_insert):
1952 * callint.c (Fcall_interactively):
1953 * buffer.c (Fkill_all_local_variables):
1954 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1955 Use Frun_hooks.
0f4a96b5 1956 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1957 unconditionnaly since it does the check itself.
1958
2c520ab5 19592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1960
c9c49752
PE
1961 Fix more problems found by GCC 4.5.2's static checks.
1962
8abc3f12
PE
1963 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1964 the first time through the loop, since we know p0 < p1 then.
1965 This also avoids a gcc -Wstrict-overflow warning.
1966
a2d26660
PE
1967 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1968 leading to a memory leak, possible in functions like
1969 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1970 of objects (Bug#8318).
a2d26660 1971
916c72e9
PE
1972 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1973 that could (at least in theory) be that large.
1974
19ab8a18
PE
1975 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1976 This is less likely to overflow, and avoids undefined behavior if
1977 overflow does occur. All callers changed. Use strtoul to scan
1978 for the unsigned long integer.
b7cbbd6f
PE
1979 (pint2hrstr): Simplify and tune code slightly.
1980 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1981
f0641eff
PE
1982 * scroll.c (do_scrolling): Work around GCC bug 48228.
1983 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1984
7f650bb9
PE
1985 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1986 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1987 (validate_x_resource_name): Simplify count usage.
1988 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1989
37dd57d1
PE
1990 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1991 fail (Bug#8306).
81e56e61 1992
699979fc 1993 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1994
401bf9b4
PE
1995 * process.c (Fmake_network_process): Use socklen_t, not int,
1996 where POSIX says socklen_t is required in portable programs.
1997 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1998 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1999 (Fmake_network_process, server_accept_connection):
2000 (wait_reading_process_output, read_process_output):
2001 Likewise.
2002
b93aacde
PE
2003 * process.c: Rename or move locals to avoid shadowing.
2004 (list_processes_1, Fmake_network_process):
2005 (read_process_output_error_handler, exec_sentinel_error_handler):
2006 Rename or move locals.
4dc343ee 2007 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2008 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2009 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2010 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2011 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2012
af8a867c 2013 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2014 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2015 Include tparam.h instead, since it declares them.
af8a867c
PE
2016 * cm.h (PC): Remove extern decl; tparam.h now does this.
2017 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2018 * terminfo.c: Include tparam.h, to check interfaces.
2019 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2020 (tparam): Adjust signature to match interface in tparam.h;
2021 this removes some undefined behavior. Check that outstring and len
2022 are zero, which they always are with Emacs.
2023 * tparam.h (PC, BC, UP): New extern decls.
2024
0248044d 2025 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2026 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2027
8ff096c1 2028 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2029 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2030 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2031 (ftfont_list): Remove unused local.
49eaafba
PE
2032 (get_adstyle_property, ftfont_pattern_entity):
2033 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2034 Rename locals to avoid shadowing.
8ff096c1 2035
e2be39f6
PE
2036 * xfont.c (xfont_list_family): Mark var as initialized.
2037
c9735e30
PE
2038 * xml.c (make_dom): Now static.
2039
8f5201ae
PE
2040 * composite.c (composition_compute_stop_pos): Rename local to
2041 avoid shadowing.
b246f932
PE
2042 (composition_reseat_it): Remove unused locals.
2043 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2044 (composition_update_it): Mark var as initialized.
11b61122
PE
2045 (find_automatic_composition): Mark vars as initialized,
2046 with a FIXME (Bug#8290).
8f5201ae 2047
760fbc2c
PE
2048 character.h: Rename locals to avoid shadowing.
2049 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2050 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2051 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2052 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2053 to avoid shadowing.
2054
ff08eb85
PE
2055 * textprop.c (property_change_between_p): Remove; unused.
2056
fc7bf025
PE
2057 * intervals.c (interval_start_pos): Now static.
2058
235d7abc
PE
2059 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2060
44f230aa
SM
2061 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2062 Rename locals to avoid shadowing.
3e7d6594 2063
50060332
PE
2064 * sound.c (wav_play, au_play, Fplay_sound_internal):
2065 Fix pointer signedness.
d01f234b 2066 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2067 (wav_play): Initialize a variable to 0, to prevent undefined
2068 behavior (Bug#8278).
50060332 2069
c4fc4e30
PE
2070 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2071
918436ed
PE
2072 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2073
c939f91b
PE
2074 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2075 clobbering (Bug#8298).
b9c7f648
PE
2076 * sysdep.c (sys_subshell): Likewise.
2077 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2078
6bd8c144
PE
2079 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2080 This should get cleaned up, so that child_setup has the
2081 same signature on all platforms.
2082
7710357c 2083 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2084 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2085
c59da222
CY
20862011-03-22 Chong Yidong <cyd@stupidchicken.com>
2087
2088 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2089 not to be necessary, and produces flickering.
2090
66b87493
GM
20912011-03-20 Glenn Morris <rgm@gnu.org>
2092
2093 * config.in: Remove file.
2094
45b6f6d5
JB
20952011-03-20 Juanma Barranquero <lekktu@gmail.com>
2096
2097 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2098 are now in src/globals.h.
2099 (syms_of_minibuf): Remove spurious & from previous change.
2100
3ec03f7e
LL
21012011-03-20 Leo <sdl.web@gmail.com>
2102
2103 * minibuf.c (completing-read-function): New variable.
2104 (completing-read-default): Rename from completing-read.
2105 (completing-read): Call completing-read-function.
2106
b14e3e21
CY
21072011-03-19 Juanma Barranquero <lekktu@gmail.com>
2108
2109 * xfaces.c (Fx_load_color_file):
2110 Read color file from absolute filename (bug#8250).
2111
f2b726e6
JB
21122011-03-19 Juanma Barranquero <lekktu@gmail.com>
2113
2114 * makefile.w32-in: Update dependencies.
2115
09f6ff02
EZ
21162011-03-17 Eli Zaretskii <eliz@gnu.org>
2117
2118 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2119
29a6015a
PE
21202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2121
a3a6c54e
PE
2122 Fix more problems found by GCC 4.5.2's static checks.
2123
b766f867
PE
2124 * process.c (make_serial_process_unwind, send_process_trap):
2125 (sigchld_handler): Now static.
2126
be02381c
PE
2127 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2128 That way, the code declares only the vars that it needs.
2129 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2130 * s/cygwin.h (PTY_ITERATION): Likewise.
2131 * s/darwin.h (PTY_ITERATION): Likewise.
2132 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2133
57048744
PE
2134 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2135 * process.c (allocate_pty): Don't declare stb unless it's needed.
2136
7914961c 2137 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2138 (CONSTANTLIM): Remove; unused.
2139 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2140 Define only if needed.
7914961c 2141
b3967b18
PE
2142 * unexelf.c (unexec): Name an expression,
2143 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2144 Use a different way to cause a compilation error if anyone uses
2145 n rather than nn, a way that does not involve shadowing.
73366a00 2146 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2147
29a6015a
PE
2148 * deps.mk (unexalpha.o): Remove; unused.
2149
43cfc33e 2150 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2151 * unexec.h: New file.
ce701a33
PE
2152 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2153 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2154 Depend on unexec.h.
2155 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2156 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2157 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2158 Change as necessary to match prototype in unexec.h.
ce701a33 2159
01f44d5a
PE
2160 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2161 shadowing.
4f63c6bb 2162 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2163
a6670b0b
PE
2164 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2165 Rename locals to avoid shadowing.
2166
cef2010d 2167 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2168 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2169
d4d7173a
PE
2170 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2171
f08b802a
PE
2172 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2173 warning when compiling print.c.
2174
3ddb0639
PE
2175 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2176 instead of using an uninitialized var.
5ad03b97 2177 (font_sort_entities): Mark var as initialized.
3ddb0639 2178
170a2692
PE
2179 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2180
e663c700
PE
2181 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2182 pointers to constants.
89bc529a 2183 (font_parse_fcname): Remove unused vars.
7b81e2d0 2184 (font_delete_unmatched): Now static.
ea838e10 2185 (font_get_spec): Remove; unused.
13a547c6
PE
2186 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2187 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2188 Rename or move locals to avoid shadowing.
e663c700 2189
2a80c887 2190 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2191 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2192
1384fa33 2193 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2194 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2195
8b2c52e9
PE
2196 * alloc.c (mark_backtrace): Move decl from here ...
2197 * lisp.h: ... to here, so that it can be checked.
2198
475545b5 2199 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2200 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2201 (lisp_indirect_variable): Name an expression,
2202 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2203 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2204
b1349114 2205 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2206 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2207 Use const pointer when appropriate.
b1349114 2208
a2928364
PE
2209 * lisp.h (get_system_name, get_operating_system_release):
2210 Move decls here, to check interfaces.
2211 * process.c (get_operating_system_release): Move decl to lisp.h.
2212 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2213 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2214 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2215 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2216 (Fformat_time_string, Fencode_time, Finsert_char):
2217 (Ftranslate_region_internal, Fformat):
2218 Rename or remove local vars to avoid shadowing.
9710023e 2219 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2220
a415e694
PE
2221 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2222 avoid shadowing.
2223
8ef4622d
PE
2224 * lisp.h (eassert): Check that the argument compiles, even if
2225 ENABLE_CHECKING is not defined.
2226
946f9a5b
PE
2227 * data.c (Findirect_variable): Name an expression, to avoid
2228 gcc -Wbad-function-cast warning.
112396d6 2229 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2230 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2231 (Fmake_variable_buffer_local, Fmake_local_variable):
2232 Mark variables as initialized.
52746918 2233 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2234
e5aab7e7 2235 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2236 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2237 Rename locals to avoid shadowing.
dff45157
PE
2238 (mark_stack): Move local variables into the #ifdef region where
2239 they're used.
7bc26fdb
PE
2240 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2241 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2242 needed otherwise.
2243 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2244 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2245 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2246
e5aab7e7
PE
2247 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2248 avoids undefined behavior in theory.
2249
4da60324
PE
2250 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2251
88043301
PE
2252 Use functions, not macros, for up- and down-casing (Bug#8254).
2253 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2254 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2255 to use the following functions instead of these macros.
2256 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2257 EMACS_INT, since callers assume the returned value fits in int.
2258 (upcase1): Likewise, for UPCASE_TABLE.
2259 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2260 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2261 the race-condition problem in the old DOWNCASE.
88043301 2262
19ed5445
PE
2263 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2264 Rename locals to avoid shadowing.
2265 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2266 (regex_compile, re_search_2, re_match_2_internal):
2267 Remove unused local vars.
952db0d7
PE
2268 (FREE_VAR): Rewrite so as not to use empty "else",
2269 which gcc can warn about.
da053e48 2270 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2271 (RETALLOC_IF): Define only if needed.
2272 (WORDCHAR_P): Likewise. This one is never needed, but is used
2273 only in a comment talking about a compiler bug, so put inside
2274 the #if 0 of that comment.
2275 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2276 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2277 Remove; unused.
19ed5445 2278
1f3561e4 2279 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2280 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2281 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2282
ded6f8f7
PE
2283 * search.c (simple_search): Remove unused var.
2284
dbd37a95
PE
2285 * dired.c (compile_pattern): Move decl from here ...
2286 * lisp.h: ... to here, so that it can be checked.
2287 (struct re_registers): New forward decl.
2288
7e47afad
PE
2289 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2290
85f24f61
PE
2291 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2292 All uses changed.
2293 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2294 Rename locals to avoid shadowing.
5671df8f 2295 (Fvertical_motion): Mark locals as initialized.
85f24f61 2296
181aa2be 2297 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2298 (casify_region): Mark local as initialized.
181aa2be 2299
930d429c
PE
2300 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2301
7082eac6
PE
2302 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2303 New macros, so that the caller can use some names other than
2304 gcpro1, gcpro2, etc.
2305 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2306 of the new macros.
2307 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2308 argument, for consistency with GCPRO2_VAR, etc: it is now the
2309 prefix of the variable, not the variable itself. All uses
2310 changed.
38b2c076
PE
2311 * dired.c (directory_files_internal, file_name_completion):
2312 Rename locals to avoid shadowing.
2313
15206ed9
PE
2314 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2315 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2316 dired.c's scmp function, had undefined behavior.
2317 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2318 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2319 * buffer.h: ... to here, because these macros use current_buffer,
2320 and the new implementation with inline functions needs to have
2321 current_buffer in scope now, rather than later when the macros
2322 are used.
2323 (downcase, upcase1): New static inline functions.
2324 (DOWNCASE, UPCASE1): Reimplement using these functions.
2325 This avoids undefined behavior in expressions like
2326 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2327 from race conditions in accessing the global variables
2328 case_temp1 and case_temp2.
2329 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2330 * lisp.h (case_temp1, case_temp2): Remove their decls.
2331 * character.h (ASCII_CHAR_P): Move from here ...
2332 * lisp.h: ... to here, so that the inline functions mentioned
2333 above can use them.
2334
4a6bea26
PE
2335 * dired.c (directory_files_internal_unwind): Now static.
2336
f14b7e14
PE
2337 * fileio.c (file_name_as_directory, directory_file_name):
2338 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2339 Now static.
2893f146
PE
2340 (file_name_as_directory): Use const pointers when appropriate.
2341 (Fexpand_file_name): Likewise. In particular, newdir might
2342 point at constant storage, so make it a const pointer.
fd4ead52 2343 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2344 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2345 signedness issues.
f839df0c
PE
2346 (Fset_file_times, Finsert_file_contents, auto_save_error):
2347 Rename locals to avoid shadowing.
f14b7e14 2348
5716756e 2349 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2350 (Ftry_completion, Fall_completions): Rename or remove locals
2351 to avoid shadowing.
5716756e 2352
b4c3046a
PE
2353 * marker.c (bytepos_to_charpos): Remove; unused.
2354
b45db522
PE
2355 * lisp.h (verify_bytepos, count_markers): New decls,
2356 so that gcc does not warn that these functions aren't declared.
2357
85876d07
PE
2358 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2359 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2360 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2361 (copy_text): Remove unused local var.
85876d07 2362
03d78a21 2363 * filelock.c (within_one_second): Now static.
b3dd38ab 2364 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2365
5df8f01b
PE
2366 * buffer.c (fix_overlays_before): Mark locals as initialized.
2367 (fix_start_end_in_overlays): Likewise. This function should be
2368 simplified by using pointers-to-pointers, but that's a different
2369 matter.
b1d876f1 2370 (switch_to_buffer_1): Now static.
8f54f30a
PE
2371 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2372 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2373
a70072c9 2374 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2375 Fix pointer signedness issue.
edced198
PE
2376 (sys_subshell): Mark local as volatile if checking for lint,
2377 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2378 (MAXPATHLEN): Define only if needed.
a70072c9 2379
a0977c44
PE
2380 * process.c (serial_open, serial_configure): Move decls from here ...
2381 * systty.h: ... to here, so that they can be checked.
2382
a884fdcc
PE
2383 * fns.c (get_random, seed_random): Move extern decls from here ...
2384 * lisp.h: ... to here, so that they can be checked.
2385
604efe86 2386 * sysdep.c (reset_io): Now static.
b8950c94 2387 (wait_for_termination_signal): Remove; unused.
604efe86 2388
38fc62d9
PE
2389 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2390 (copy_keymap_item, append_key, push_text_char_description):
2391 Now static.
1004a21a 2392 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2393 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2394 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2395 (describe_map_tree):
2396 Rename locals to avoid shadowing.
38fc62d9 2397
2f2650da
PE
2398 * keyboard.c: Declare functions static if they are not used elsewhere.
2399 (echo_char, echo_dash, cmd_error, top_level_2):
2400 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2401 (read_char, kbd_buffer_get_event, make_lispy_position):
2402 (make_lispy_event, make_lispy_movement, apply_modifiers):
2403 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2404 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2405 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2406 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2407 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2408
a053e86c 2409 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2410 (mark_kboards): Move decl here ...
2411 * alloc.c (mark_kboards): ... from here.
a053e86c 2412
4752793e
PE
2413 * lisp.h (force_auto_save_soon): New decl.
2414
74f10ca7 2415 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2416 (DEFINE_DUMMY_FUNCTION): New macro.
2417 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2418 Use it.
c03cd23f
PE
2419 (main): Add casts to avoid warnings
2420 if GCC considers string literals to be constants.
74f10ca7 2421
022e70d4
PE
2422 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2423
59d6fe83
PE
2424 * dbusbind.c: Pointer signedness fixes.
2425 (xd_signature, xd_append_arg, xd_initialize):
2426 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2427 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2428 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2429 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2430
78320123
PE
2431 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2432 if GCC considers string literals to be constants.
49cebcca 2433 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2434
35ac2a97
SM
24352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2436
fb103ca9
SM
2437 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2438 (print_preprocess, print_object): New macro to fix last change.
2439
35ac2a97
SM
2440 * print.c (print_preprocess): Don't forget font objects.
2441
62973b41
JB
24422011-03-16 Juanma Barranquero <lekktu@gmail.com>
2443
2444 * emacs.c (USAGE3): Doc fixes.
2445
0e48bb22
AS
24462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2447
2448 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2449 structure.
2450
7684e57b
JB
24512011-03-14 Juanma Barranquero <lekktu@gmail.com>
2452
2453 * lisp.h (VWindow_system, Qfile_name_history):
2454 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2455 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2456 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2457
2458 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2459 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2460
2461 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2462 * w32console.c (detect_input_pending, read_input_pending)
2463 (encode_terminal_code):
2464 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2465 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2466 (w32_system_caret_y, Qfile_name_history):
2467 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2468 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2469 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2470 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2471 * w32proc.c (Qlocal, report_file_error):
2472 * w32term.c (Vwindow_system, updating_frame):
2473 * w32uniscribe.c (initialized, uniscribe_font_driver):
2474 Remove unneeded extern declarations.
2475
2aa46d6c
CY
24762011-03-14 Chong Yidong <cyd@stupidchicken.com>
2477
c96bbc66 2478 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2479
cffc6f3b
CY
24802011-03-13 Chong Yidong <cyd@stupidchicken.com>
2481
2482 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2483 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2484 These macros can no longer be used for assignment.
2485
44f230aa
SM
2486 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2487 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2488 (record_buffer_markers, fetch_buffer_markers): New functions for
2489 recording and fetching special buffer markers.
2490 (set_buffer_internal_1, set_buffer_temp): Use them.
2491
2492 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2493
2494 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2495
2496 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2497 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2498
2499 * xdisp.c (hscroll_window_tree):
2500 (reconsider_clip_changes): Use PT instead of BUF_PT.
2501
d251f04b
EZ
25022011-03-13 Eli Zaretskii <eliz@gnu.org>
2503
2504 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2505 $(EMACS_ROOT)/lib/intprops.h.
2506
f0c77cd1
PE
25072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2508
3eca4629
PE
2509 Fix more problems found by GCC 4.5.2's static checks.
2510
7c86ee98
PE
2511 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2512 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2513 (xg_free_frame_widgets): Make it clear that a local variable is
2514 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2515 (gdk_window_get_screen): Make it clear that this macro is needed
2516 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2517 (int_gtk_range_get_value): New function, which avoids a diagnostic
2518 from gcc -Wbad-function-cast.
2519 (xg_set_toolkit_scroll_bar_thumb): Use it.
2520 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2521 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2522 (get_utf8_string, xg_get_file_with_chooser):
2523 Rename locals to avoid shadowing.
2524 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2525
41729b81
PE
2526 * xgselect.c (xg_select): Remove unused var.
2527
f0c77cd1
PE
2528 * image.c (four_corners_best): Mark locals as initialized.
2529 (gif_load): Initialize transparent_p to zero (Bug#8238).
2530 Mark another local as initialized.
ec6cf4c6 2531 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2532
ce0ad53d 2533 * image.c (clear_image_cache): Now static.
d5d5a617 2534 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2535 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2536 (x_edge_detection): Remove unnecessary cast that
2537 gcc -Wbad-function-cast diagnoses.
2037898d 2538 (gif_load): Fix pointer signedness.
6ae141d6
PE
2539 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2540 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2541
33383987 25422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2543
d32df629
PE
2544 Improve quality of tests for time stamp overflow.
2545 For example, without this patch (encode-time 0 0 0 1 1
2546 1152921504606846976) returns the obviously-bogus value (-948597
2547 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2548 reports time overflow. See
2549 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2550 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2551 * editfns.c: Include limits.h and intprops.h.
2552 (TIME_T_MIN, TIME_T_MAX): New macros.
2553 (time_overflow): Move earlier, to before first use.
2554 (hi_time, lo_time): New functions, for an accurate test for
2555 out-of-range times.
2556 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2557 (Fget_internal_run_time): Don't assume time_t fits in int.
2558 (make_time): Use list2 instead of Fcons twice.
2559 (Fdecode_time): More accurate test for out-of-range times.
2560 (check_tm_member): New function.
2561 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2562 (lisp_time_argument): Don't rely on undefined left-shift and
2563 right-shift behavior when checking for time stamp overflow.
8be6f318 2564
fe31d94c
PE
2565 * editfns.c (time_overflow): New function, refactoring common code.
2566 (Fformat_time_string, Fdecode_time, Fencode_time):
2567 (Fcurrent_time_string): Use it.
2568
8be6f318
PE
2569 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2570 * dired.c (make_time): Move to ...
2571 * editfns.c (make_time): ... here.
2572 * systime.h: Note the move.
2573
09d9db2c 25742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2575
126bc0dc
YM
2576 * fringe.c (update_window_fringes): Remove unused variables.
2577
c47cbdfd
YM
2578 * unexmacosx.c (copy_data_segment): Also copy __got section.
2579 (Bug#8223)
2580
7ac80be9
EZ
25812011-03-12 Eli Zaretskii <eliz@gnu.org>
2582
c96bbc66 2583 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2584 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2585 Constify `char *' arguments and their references according to
2586 prototypes in tparam.h.
2587
ecb0f94d 2588 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2589
7ac80be9
EZ
2590 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2591 Adapt all references accordingly.
2592
2593 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2594
ef1fd07e
TT
25952011-03-11 Tom Tromey <tromey@redhat.com>
2596
2597 * buffer.c (syms_of_buffer): Remove obsolete comment.
2598
7ef4b50c
EZ
25992011-03-11 Eli Zaretskii <eliz@gnu.org>
2600
2601 * termhooks.h (encode_terminal_code): Declare prototype.
2602
2603 * msdos.c (encode_terminal_code): Don't declare prototype.
2604
2605 * term.c (encode_terminal_code): Now external again, used by
2606 w32console.c and msdos.c.
2607
44f230aa
SM
2608 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2609 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2610
4b1ec863 26112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2612
1714f52b 2613 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2614
4b1ec863
PE
2615 * fringe.c (update_window_fringes): Mark locals as initialized
2616 (Bug#8227).
2617 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2618
524c7aa6
PE
2619 * alloc.c (mark_fringe_data): Move decl from here ...
2620 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2621 to check its interface.
2622 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2623
a5c0af81 2624 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2625 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2626 (fontset_font): Mark local as initialized.
a9a06e0b 2627 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2628
b4716021
PE
2629 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2630
811e9bac 2631 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2632 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2633 (x_own_selection, Fx_disown_selection_internal): Rename locals
2634 to avoid shadowing.
2635 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2636
7e3ab302
PE
2637 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2638 so that the caller can use some name other than gcpro1.
2639 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2640 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2641 (Fx_backspace_delete_keys_p):
2642 Use them to avoid shadowing, and rename vars to avoid shadowing.
2643 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2644 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2645 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2646 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2647 Remove unused locals.
7e3ab302
PE
2648 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2649 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2650 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2651 macros.
f78faa98 2652
e2b13473
PE
2653 * xterm.h (x_mouse_leave): New decl.
2654
77f23912
PE
2655 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2656 Remove unused functions.
cdf4ba58
PE
2657 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2658 (x_calc_absolute_position): Now static.
7411c686 2659 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2660 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2661 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2662 unless they are used.
38d0b34a
PE
2663 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2664 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2665 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2666 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2667 (x_error_catcher, x_connection_closed, x_error_handler):
2668 (x_error_quitter, xembed_send_message, x_iconify_frame):
2669 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2670 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2671 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2672
44f230aa
SM
2673 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2674 Rename or move locals to avoid shadowing.
6b463e58 2675 (tty_defined_color, merge_face_heights): Now static.
5967d051 2676 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2677 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2678 does not deduce is never used uninitialized.
73719eba
PE
2679 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2680 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2681
426994c3 2682 * terminal.c (store_terminal_param): Now static.
5489860b 2683
032f1620 2684 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2685 (set_frame_menubar): Remove unused local.
d4323972 2686 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2687 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2688 since they might point to immutable storage.
281585b0
PE
2689 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2690 since it's unused otherwise.
032f1620 2691
367c19e5 2692 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2693 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2694 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2695 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2696 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2697 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2698 does not deduce are never used uninitialized.
70739cbe 2699
07b48fa9
PE
2700 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2701
8868a238 2702 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2703 * window.c (window_loop, size_window):
2704 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2705
7e5cf297 2706 * window.c (display_buffer): Now static.
d6550a9f
PE
2707 (size_window): Mark variables that gcc -Wuninitialized
2708 does not deduce are never used uninitialized.
a586633d
PE
2709 * window.h (check_all_windows): New decl, to forestall
2710 gcc -Wmissing-prototypes diagnostic.
5b555da1 2711 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2712
f6095868
PE
2713 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2714 shadowing.
2715 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2716 Include <limits.h>.
2717 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2718 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2719 (load_charset_map): Mark variables that gcc -Wuninitialized
2720 does not deduce are never used uninitialized.
53df7c11 2721 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2722
f38b440c
PE
2723 * coding.c (coding_set_source, coding_set_destination):
2724 Use "else { /* comment */ }" rather than "else /* comment */;"
2725 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2726 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2727 a block, when the outer 'i' will do.
2728 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2729 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2730 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2731 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2732 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2733 Rename locals to avoid shadowing.
2734 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2735 * coding.c (emacs_mule_char, encode_invocation_designation):
2736 Now static, since they're not used elsewhere.
413bb2db 2737 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2738 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2739 (decode_coding_emacs_mule): Mark variables that gcc
2740 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2741 (detect_coding_iso_2022): Initialize a local variable that might
2742 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2743 this initialization is needed. (Bug#8211)
5f58e762
PE
2744 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2745 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2746 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2747 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2748 Remove unused macros.
f38b440c 2749
232b38b9 2750 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2751 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2752 * character.c (string_count_byte8): Likewise.
232b38b9 2753
fb90da1b
PE
2754 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2755 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2756
fb93dbc2
PE
2757 * chartab.c (copy_sub_char_table): Now static, since it's not used
2758 elsewhere.
5c156ace
PE
2759 (sub_char_table_ref_and_range, char_table_ref_and_range):
2760 Rename locals to avoid shadowing.
bbcd0949 2761 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2762
7d3b3862 2763 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2764 (BIDI_BOB): Remove unused macro.
7d3b3862 2765
6be7d3da
PE
2766 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2767 deduce are never used uninitialized.
c2ed9c8b 2768 * term.c (encode_terminal_code): Likewise.
6be7d3da 2769
75f8807f 2770 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2771
50938595
PE
2772 * tparam.h: New file.
2773 * term.c, tparam.h: Include it.
2774 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2775 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2776 Move these decls to tparam.h, and make them agree with what
2777 is actually in tparam.c. The previous trick of using incompatible
2778 decls in different modules does not conform to the C standard.
2779 All callers of tparam changed to use tparam's actual API.
2780 * tparam.c (tparam1, tparam, tgoto):
2781 Use const pointers where appropriate.
2782
fbceeba2
PE
2783 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2784 * cm.h (struct cm): Likewise.
2785 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2786 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2787 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2788 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2789 (turn_on_face, init_tty): Likewise.
2790 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2791
7f3f1250
PE
2792 * term.c (term_mouse_position): Rename local to avoid shadowing.
2793
e6ca6543
PE
2794 * alloc.c (mark_ttys): Move decl from here ...
2795 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2796
c40f8d15
AS
27972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2798
2799 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2800
cfe0661d
JB
28012011-03-09 Juanma Barranquero <lekktu@gmail.com>
2802
2803 * search.c (compile_pattern_1): Remove argument regp, unused since
2804 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2805 (compile_pattern): Don't pass it.
2806
0afb4571
J
28072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2808
2809 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2810 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2811 for ! HAVE_GTK3.
2812 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2813
2814 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2815
2816 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2817 gdk_window_get_screen, gdk_window_get_geometry,
2818 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2819 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2820 (xg_get_pixbuf_from_pixmap): New function.
2821 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2822 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2823 Call xg_get_pixbuf_from_pixmap instead of
2824 gdk_pixbuf_get_from_drawable.
2825 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2826 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2827 (xg_check_special_colors): Use GtkStyleContext and its functions
2828 for HAVE_GTK3.
2829 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2830 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2831 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2832 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2833 Call gtk_widget_get_preferred_size.
0afb4571
J
2834 (xg_frame_resized): gdk_window_get_geometry only takes 5
2835 parameters.
44f230aa
SM
2836 (xg_win_to_widget, xg_event_is_for_menubar):
2837 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2838 (xg_set_widget_bg): New function.
2839 (delete_cb): New function.
895009e1 2840 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2841 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2842 (xg_set_background_color): Call xg_set_widget_bg.
2843 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2844 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2845 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2846 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2847 if ! HAVE_GTK3.
2848 (update_frame_tool_bar): Call gtk_widget_hide.
2849 (xg_initialize): Use GDK_KEY_g.
2850
2851 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2852 if ! HAVE_GTK3
2853 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2854
2855 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2856 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2857 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2858
1c2cc4ef
JB
28592011-03-08 Juanma Barranquero <lekktu@gmail.com>
2860
2861 * w32xfns.c (select_palette): Check success of RealizePalette against
2862 GDI_ERROR, not zero.
2863
33383987 2864See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2865
2866;; Local Variables:
2867;; coding: utf-8
aac0c6e3
MR
2868;; End:
2869
33383987 2870 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2871
2872 This file is part of GNU Emacs.
2873
2874 GNU Emacs is free software: you can redistribute it and/or modify
2875 it under the terms of the GNU General Public License as published by
2876 the Free Software Foundation, either version 3 of the License, or
2877 (at your option) any later version.
2878
2879 GNU Emacs is distributed in the hope that it will be useful,
2880 but WITHOUT ANY WARRANTY; without even the implied warranty of
2881 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2882 GNU General Public License for more details.
2883
2884 You should have received a copy of the GNU General Public License
2885 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.