* src/xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f3d4e0a4
CY
12011-05-22 Chong Yidong <cyd@stupidchicken.com>
2
3 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4
4d8ade89
YM
52011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6
7 * dispnew.c (scrolling_window): Don't exclude the case that the
8 last enabled row in the desired matrix touches the bottom boundary.
9
32078c8d
GM
102011-05-21 Glenn Morris <rgm@gnu.org>
11
12 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
14 and add some more files.
32078c8d 15
7285dc67
EZ
162011-05-20 Eli Zaretskii <eliz@gnu.org>
17
18 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
19 report_file_error introduced by the change from 2011-05-07.
20
89d1bd22
PE
212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
22
23 * systime.h (Time): Define only if emacs is defined.
24 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
25 where the include path doesn't have X11/X.h by default. See
26 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
27
e23640bb 282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
29
30 * composite.c (find_automatic_composition): Fix previous change.
31
b9704ad9
GM
322011-05-20 Glenn Morris <rgm@gnu.org>
33
34 * lisp.mk: New file, split from Makefile.in.
35 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
36 (shortlisp): Remove.
37 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
38
4a720484
GM
392011-05-19 Glenn Morris <rgm@gnu.org>
40
41 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
42 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
43 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
44 (lisp): Set the order to that of loadup.el.
45 (shortlisp): Make it a copy of $lisp.
46 (SOME_MACHINE_LISP): Remove.
47 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
48 Use just $shortlisp, not $SOME_MACHINE_LISP too.
49
a28d4396
KH
502011-05-18 Kenichi Handa <handa@m17n.org>
51
52 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
53 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
54 (find_automatic_composition): Mostly rewrite for efficiency.
55
a2b1fa8e
JB
562011-05-18 Juanma Barranquero <lekktu@gmail.com>
57
58 * makefile.w32-in: Update dependencies.
59
8e1f5610
CS
602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
61
62 * menu.c: Include limits.h (fixes the MS-Windows build broken by
63 revision 104625).
64
7025ee00 652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 66
cdfa6eab
PE
67 Fix some integer overflow issues, such as string length overflow.
68
06d6db33
PE
69 * insdel.c (count_size_as_multibyte): Check for string overflow.
70
2b4560a8
PE
71 * character.c (lisp_string_width): Check for string overflow.
72 Use EMACS_INT, not int, for string indexes and lengths; in
73 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
74 the resulting string length overflows an EMACS_INT; instead,
75 report a string overflow if no precision given. When checking for
76 precision exhaustion, use a check that cannot possibly have
77 integer overflow. (Bug#8675)
78 * character.h (lisp_string_width): Adjust to new signature.
79
cb93f9be
PE
80 * alloc.c (string_overflow): New function.
81 (Fmake_string): Use it. This doesn't change behavior, but saves
82 a few bytes and will simplify future changes.
83 * character.c (string_escape_byte8): Likewise.
84 * lisp.h (string_overflow): New decl.
85
1a1f3366
PE
86 Fixups, following up to the user-interface timestamp change.
87 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
88 for UI timestamps, instead of unsigned long.
9fbd6841
PE
89 * msdos.c (mouse_get_pos): Likewise.
90 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
91 * w32gui.h (Time): Define by including "systime.h" rather than by
92 declaring it ourselves. (Bug#8664)
93
d4e3e4d3
PE
94 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
95 * image.c (clear_image_cache): Likewise.
96
f6a24d19
PE
97 * term.c (term_mouse_position): Don't assume time_t wraparound.
98
08dc5ae6
PE
99 Be more systematic about user-interface timestamps.
100 Before, the code sometimes used 'Time', sometimes 'unsigned long',
101 and sometimes 'EMACS_UINT', to represent these timestamps. This
102 change causes it to use 'Time' uniformly, as that's what X uses.
103 This makes the code easier to follow, and makes it easier to catch
104 integer overflow bugs such as Bug#8664.
105 * frame.c (Fmouse_position, Fmouse_pixel_position):
106 Use Time, not unsigned long, for user-interface timestamps.
107 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
108 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
109 * keyboard.h (last_event_timestamp): Likewise.
110 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
111 * menu.h (xmenu_show): Likewise.
112 * term.c (term_mouse_position): Likewise.
113 * termhooks.h (struct input_event.timestamp): Likewise.
114 (struct terminal.mouse_position_hook): Likewise.
115 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
116 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
117 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
118 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
119 what it was before.
120 * menu.h, termhooks.h: Include "systime.h", for Time.
121
8e55734a
PE
122 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
123 Don't assume that the difference between two unsigned long values
124 can fit into an integer. At this point, we know button_down_time
125 <= event->timestamp, so the difference must be nonnegative, so
126 there's no need to cast the result if double-click-time is
127 nonnegative, as it should be; check that it's nonnegative, just in
128 case. This bug is triggered when events are more than 2**31 ms
86db42d2 129 apart (about 25 days). (Bug#8664)
8e55734a 130
841f1b75 131 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 132 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 133
3e26f69c
PE
134 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
135 that always fit in int. Use a sentinel instead of a counter, to
136 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
137 * frame.h (struct frame): Use int for menu_bar_items_used
138 instead of EMACS_INT, since it always fits in int.
3e26f69c 139
5cc152c0
PE
140 * menu.c (grow_menu_items): Check for int overflow.
141
d89eb65e
PE
142 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
143
5235bd3e
PE
144 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
145 Before, the code was not consistent. These values cannot exceed
146 2**31 - 1 so there's no need to make them unsigned.
147 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
148 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
149 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
150 as modifiers.
151 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
152
bc827e23
PE
153 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
154 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
155 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
156 presumably because the widths might not match.
157
78eb494e
PE
158 * window.c (size_window): Avoid needless test at loop start.
159
04f2d78b
CB
1602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
161
162 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
163
d2fc7e3d 1642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
165
166 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
167
d2fc7e3d 1682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
169
170 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
171 `width' to `bar_area_x' and `bar_area_width', respectively.
172 (x_scroll_run): Take account of fringe background extension.
173
04f2d78b
CB
174 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
175 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
176 `bar_area_width', respectively.
177 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
178 background extension.
179
79b70037
GM
1802011-05-10 Jim Meyering <meyering@redhat.com>
181
182 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
183
2f142cc5
JB
1842011-05-10 Juanma Barranquero <lekktu@gmail.com>
185
186 * image.c (Finit_image_library): Return t for built-in image types,
187 like pbm and xbm. (Bug#8640)
188
57679c86
AS
1892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
190
191 * w32menu.c (set_frame_menubar): Fix submenu allocation.
192
888c9e86
EZ
1932011-05-07 Eli Zaretskii <eliz@gnu.org>
194
b0512a1d
EZ
195 * w32console.c (Fset_screen_color): Doc fix.
196 (Fget_screen_color): New function.
197 (syms_of_ntterm): Defsubr it.
198
7285dc67
EZ
199 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
200 unlink the temporary file if Fcall_process didn't create it in the
201 first place.
202 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
203 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
204 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
205 cue to call_process_cleanup not to close that handle.
206
4d3fcc8e
BK
2072011-05-07 Ben Key <bkey76@gmail.com>
208
209 * makefile.w32-in: The bootstrap-temacs rule now makes use of
210 one of two shell specific rules, either bootstrap-temacs-CMD or
211 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
212 to the previous implementation of the bootstrap-temacs rule.
213 The bootstrap-temacs-CMD rule is similar to the previous
214 implementation of the bootstrap-temacs rule except that it
215 makes use of the ESC_CFLAGS variable instead of the CFLAGS
216 variable.
217
218 These changes, along with some changes to nt/configure.bat,
219 nt/gmake.defs, and nt/nmake.defs, are required to extend my
220 earlier fix to add support for --cflags and --ldflags options
221 that include quotes so that it works whether make uses cmd or
222 sh as the shell.
223
b4289b64
MA
2242011-05-06 Michael Albinus <michael.albinus@gmx.de>
225
226 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
227 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
228 is a constant.
229 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
230 a string. Handle both cases.
231 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
232 (Fdbus_register_method): Use Qinvalid_function.
233
af4c0e28
JB
2342011-05-06 Juanma Barranquero <lekktu@gmail.com>
235
236 * makefile.w32-in: Update dependencies.
237 (LISP_H): Add inttypes.h and stdin.h.
238 (PROCESS_H): Add unistd.h.
239
c51453d9
EZ
2402011-05-06 Eli Zaretskii <eliz@gnu.org>
241
242 * lread.c: Include limits.h (fixes the MS-Windows build broken by
243 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
244
8ff0ac3c 2452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 246
4c4b566b
PE
247 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
248
aab2b9b5
PE
249 * term.c (vfatal): Remove stray call to va_end.
250 It's not needed and the C Standard doesn't allow it here anyway.
251
c378da0b
PE
252 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
253 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
254
288b08c7
PE
255 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
256 bytes.
257
e3601888
PE
258 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
259
db6c0e74
PE
260 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
261
dd5963ea
PE
262 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
263
88c9450f
PE
264 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
265
2f9442b8
PE
266 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
267
c032b5f8
PE
268 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
269 * charset.c (Fdefine_charset_internal): Don't initialize
270 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 271 32-bit int (Bug#8600).
a108c10b
PE
272
273 * lread.c (read_integer): Be more consistent with string-to-number.
274 Use string_to_number to do the actual conversion; this avoids
275 rounding errors and fixes some other screwups. Without this fix,
276 for example, #x1fffffffffffffff was misread as -2305843009213693952.
277 (digit_to_number): Move earlier, for benefit of read_integer.
278 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 279 not a digit in any supported base. (Bug#8602)
a108c10b 280
ad5f9eea
PE
281 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
282
aec1708a
PE
283 * dispnew.c (scrolling_window): Return 1 if we scrolled,
284 to match comment at start of function. This also removes a
285 GCC warning about overflow in a 32+64-bit port.
286
47be4ab5
PE
287 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
288
371cac43
PE
289 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
290 Reported by Stefan Monnier in
291 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
292 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
293 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 294
d01a7826
PE
295 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
296 (EMACS_UINTPTR): Likewise, with uintptr_t.
297
7fd47d5c
PE
298 * lisp.h: Prefer 64-bit EMACS_INT if available.
299 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
300 on 32-bit hosts that have 64-bit int, so that they can access
301 large files.
122b0c86
PE
302 However, temporarily disable this change unless the temporary
303 symbol WIDE_EMACS_INT is defined.
7fd47d5c 304
8727937b
PE
305 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
306
8ac068ac
PE
307 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
308 This removes an assumption that EMACS_INT and long are the same
309 width as pointers. The assumption is true for Emacs porting targets
310 now, but we want to make other targets possible.
311 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
312 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
313 In the rest of the code, change types of integers that hold casted
314 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
315 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
316 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
317 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
318 No need to cast type when ORing.
319 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
320 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
321 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
322 assume EMACS_INT is the same width as char *.
323 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
324 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
325 Remove no-longer-needed casts.
326 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
327 (xg_tool_bar_help_callback, xg_make_tool_item):
328 Use EMACS_INTPTR to hold an integer
329 that will be cast to void *; this can avoid a GCC warning
330 if EMACS_INT is not the same width as void *.
331 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
332 * xdisp.c (display_echo_area_1, resize_mini_window_1):
333 (current_message_1, set_message_1):
334 Use a local to convert to proper width without a cast.
335 * xmenu.c (dialog_selection_callback): Likewise.
336
ede49d71
PE
337 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
338 Also, don't assume VALBITS / RAND_BITS is less than 5,
339 and don't rely on undefined behavior when shifting a 1 left into
340 the sign bit.
341 * lisp.h (get_random): Change signature to match.
342
2f30ecd0
PE
343 * lread.c (hash_string): Use size_t, not int, for hash computation.
344 Normally we prefer signed values; but hashing is special, because
345 it's better to use unsigned division on hash table sizes so that
346 the remainder is nonnegative. Also, size_t is the natural width
347 for hashing into memory. The previous code used 'int', which doesn't
348 retain enough info to hash well into very large tables.
349 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
350
2a866e7b
PE
351 * dbusbind.c: Don't possibly lose pointer info when converting.
352 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
353 Use XPNTR rather than XHASH, so that the high-order bits of
354 the pointer aren't lost when converting through void *.
355
51639eac
PE
356 * eval.c (Fautoload): Don't double-shift a pointer.
357
92394119
PE
358 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
359
dbdb9a7c
JB
3602011-05-06 Juanma Barranquero <lekktu@gmail.com>
361
362 * gnutls.c (DEF_GNUTLS_FN):
363 * image.c (DEF_IMGLIB_FN): Make function pointers static.
364
db7a0b4f
AS
3652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
366
367 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
368 marker. (Bug#8610)
369
f7ff1b0f 3702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
371
372 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
373 New version that can reserve upto 2GB of heap space.
374
f7ff1b0f 3752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
376
377 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
378
639c109b
TZ
3792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
380
381 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
382 `gnutls_certificate_set_x509_key_file'.
383
d2127135
JB
3842011-05-05 Juanma Barranquero <lekktu@gmail.com>
385
386 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
387 Update dependencies.
388
e968f4f3
JB
3892011-05-04 Juanma Barranquero <lekktu@gmail.com>
390
391 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
392 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
393 Remove unused parameter `fildes'.
394 * process.c (read_process_output, send_process): Don't pass it.
395
84d358f0
JB
3962011-05-04 Juanma Barranquero <lekktu@gmail.com>
397
398 Fix previous change: the library cache is defined in w32.c.
399 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
400 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
401
0898ca10
JB
4022011-05-04 Juanma Barranquero <lekktu@gmail.com>
403
404 Implement dynamic loading of GnuTLS on Windows.
405
406 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
407 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
408 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
409 Declare.
410
411 * gnutls.c (Qgnutls_dll): Define.
412 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
413 (gnutls_*): Declare function pointers.
414 (init_gnutls_functions): New function to initialize function pointers.
415 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
416 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
417 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
418 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
419 (emacs_gnutls_write, emacs_gnutls_read)
420 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
421 (Fgnutls_available_p): New function.
422 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
423 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
424 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
425
426 * image.c: Include w32.h.
427 (Vimage_type_cache): Delete.
428 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
429 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
430 (w32_delayed_load): Move to w32.c.
431
432 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
433
434 * w32.c (QCloaded_from, Vlibrary_cache): Define.
435 (w32_delayed_load): Move from image.c. When loading a library, record
436 its filename in the :loaded-from property of the library id.
437 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
438 Initialize and staticpro them.
439 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
440
441 * process.c: Include lisp.h before w32.h, not after.
442 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
443 instead of gnutls_record_check_pending.
444
445 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
446
ff4de4aa
TZ
4472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
448
449 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
450 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
451 as passed in.
452
abe95abb
JD
4532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
454
455 * xterm.c (x_set_frame_alpha): Do not set property on anything
456 else than FRAME_X_OUTER_WINDOW (Bug#8608).
457
e16e55d4
JB
4582011-05-02 Juanma Barranquero <lekktu@gmail.com>
459
460 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
461
bafcf6a5
JB
4622011-05-02 Juanma Barranquero <lekktu@gmail.com>
463
464 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
465 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
466 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
467 (gnutls_global_initialized, Qgnutls_bootprop_priority)
468 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
469 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
470 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
471 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
472 (Qgnutls_bootprop_callbacks_verify): Make static.
473
e7a6747f
AS
4742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
475
19ed11ba
AS
476 * callproc.c: Indentation fixup.
477
e7a6747f 478 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
479 (wait_for_termination, interruptible_wait_for_termination):
480 Move after wait_for_termination_1.
e7a6747f 481
1ef14cb4
LMI
4822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
483
484 * sysdep.c (interruptible_wait_for_termination): New function
485 which is like wait_for_termination, but allows keyboard
486 interruptions.
487
488 * callproc.c (Fcall_process): Add (:file "file") as an option for
489 the STDOUT buffer.
490 (Fcall_process_region): Ditto.
491
330d880c
EZ
4922011-04-30 Eli Zaretskii <eliz@gnu.org>
493
8db90b73
EZ
494 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
495 rather than `XVECTOR (FOO)->size'.
496
330d880c
EZ
497 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
498 inttypes.h, as a gnulib replacement is used if it not available in
499 system headers.
500
15cbd324
EZ
5012011-04-21 Eli Zaretskii <eliz@gnu.org>
502
503 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
504 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
505 of MOST_POSITIVE_FIXNUM. (Bug#8528)
506
507 * coding.c (coding_alloc_by_realloc): Error out if destination
508 will grow beyond MOST_POSITIVE_FIXNUM.
509 (decode_coding_emacs_mule): Abort if there isn't enough place in
510 charbuf for the composition carryover bytes. Reserve an extra
511 space for up to 2 characters produced in a loop.
512 (decode_coding_iso_2022): Abort if there isn't enough place in
513 charbuf for the composition carryover bytes.
514
5152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 516
ae940cca
EZ
517 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
518 aborting when %lld or %lll format is passed.
519 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
520 %llo or %llx format is passed. (Bug#8545)
521
03ab8921
EZ
522 * window.c (window_scroll_line_based): Use a marker instead of
523 simple variables to record original value of point. (Bug#7952)
524
afda1437
EZ
525 * doprnt.c (doprnt): Fix the case where a multibyte sequence
526 produced by %s or %c overflows available buffer space. (Bug#8545)
527
f76dee0c
PE
5282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
529
530 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 531 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 532
fdc5744d
JB
5332011-04-28 Juanma Barranquero <lekktu@gmail.com>
534
535 * w32.c (init_environment): Warn about defaulting HOME to C:\.
536
638f053a
JB
5372011-04-28 Juanma Barranquero <lekktu@gmail.com>
538
539 * keyboard.c (Qdelayed_warnings_hook): Define.
540 (command_loop_1): Run `delayed-warnings-hook'
541 if Vdelayed_warnings_list is non-nil.
542 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
543 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
544
d178f871
EZ
5452011-04-28 Eli Zaretskii <eliz@gnu.org>
546
547 * doprnt.c (doprnt): Don't return value smaller than the buffer
548 size if the message was truncated. (Bug#8545).
549
b124fd93
JB
5502011-04-28 Juanma Barranquero <lekktu@gmail.com>
551
552 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
553 (Fx_window_property): #if-0 the whole functions, not just the bodies.
554
e810457d
PE
5552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
556
557 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
558
ea51cceb
JB
5592011-04-27 Juanma Barranquero <lekktu@gmail.com>
560
561 * makefile.w32-in: Update dependencies.
562
94dcfacf
EZ
5632011-04-27 Eli Zaretskii <eliz@gnu.org>
564
565 Improve `doprnt' and its usage. (Bug#8545)
566 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
567 `format_end'. Remove support for %l as a conversion specifier.
568 Don't use xrealloc. Improve diagnostics when the %l size modifier
569 is used. Update the commentary.
570
571 * eval.c (verror): Simplify calculation of size_t.
572
573 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
574 messages.
575
f61f41d7
PE
5762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
577
578 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
579 change.
580
96fb4434
PE
5812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
582
583 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
584 This makes this file independent of the recent pseudovector change.
585
671875da 5862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 587
69e9b5a3
PE
588 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
589
b5f869a7 590 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 591 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 592 Remove unused local.
c8926152 593 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 594
841a1577 595 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
596 GCC 4.6.0 optimizes based on type-based alias analysis.
597 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
598 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
599 != &v->size, and therefore "v->size = 1; b->size = 2; return
600 v->size;" must therefore return 1. This assumption is incorrect
601 for Emacs, since it type-puns struct Lisp_Vector * with many other
602 types. To fix this problem, this patch adds a new type struct
f904488f 603 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
604 and pseudovectors, and helps optimizing compilers not get fooled
605 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
606 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
607 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
608 the size member.
eab3844f
PE
609 (XSETPVECTYPE): Rewrite in terms of new macro.
610 (XSETPVECTYPESIZE): New macro, specifying both type and size.
611 This is a bit clearer, and further avoids the possibility of
612 undesirable aliasing.
613 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 614 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
615 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
616 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
617 (ASIZE): Now uses header.size rather than size.
618 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
619 to avoid the hassle of writing XVECTOR (foo)->header.size.
620 (struct vectorlike_header): New type.
eab3844f
PE
621 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
622 object, to help avoid aliasing.
623 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
624 (SUBRP): Likewise, since Lisp_Subr is a special case.
625 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
626 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
627 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 628 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
629 changed to be "header.size" and "header.next".
630 * buffer.h (struct buffer): Likewise.
631 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
632 * frame.h (struct frame): Likewise.
633 * process.h (struct Lisp_Process): Likewise.
634 * termhooks.h (struct terminal): Likewise.
635 * window.c (struct save_window_data, struct saved_window): Likewise.
636 * window.h (struct window): Likewise.
637 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
638 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
639 * buffer.c (init_buffer_once): Likewise.
640 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
641 special case.
642 * process.c (Fformat_network_address): Use local var for size,
643 for brevity.
644
0df1eac5
PE
645 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
646
847ab9d1 647 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
648 * data.c (atof): Remove decl; no longer used or needed.
649 (digit_to_number): Move to lread.c.
650 (Fstring_to_number): Use new string_to_number function, to be
651 consistent with how the Lisp reader treats infinities and NaNs.
652 Do not assume that floating-point numbers represent EMACS_INT
653 without losing information; this is not true on most 64-bit hosts.
654 Avoid double-rounding errors, by insisting on integers when
655 parsing non-base-10 numbers, as the documentation specifies.
656 * lisp.h (string_to_number): New decl, replacing ...
657 (isfloat_string): Remove.
bc0a5c13 658 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 659 (read1): Do not accept +. and -. as integers; this
452f4150
PE
660 appears to have been a coding error. Similarly, do not accept
661 strings like +-1e0 as floating point numbers. Do not report
662 overflow for integer overflows unless the base is not 10 which
663 means we have no simple and reliable way to continue.
664 Break out the floating-point parsing into a new
665 function string_to_number, so that Fstring_to_number parses
666 floating point numbers consistently with the Lisp reader.
04f2d78b 667 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
668 (E_CHAR, EXP_INT): Remove, replacing with ...
669 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
670 (string_to_number): New function, replacing isfloat_string.
671 This function checks for valid syntax and produces the resulting
672 Lisp float number too. Rework it so that string-to-number
bc0a5c13 673 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
674 so that overflow for non-base-10 numbers is reported only when
675 there's no portable and simple way to convert to floating point.
452f4150 676
67769ffc
PE
677 * textprop.c (set_text_properties_1): Rewrite for clarity,
678 and to avoid GCC warning about integer overflow.
679
c20db43f
PE
680 * intervals.h (struct interval): Use EMACS_INT for members
681 where EMACS_UINT might cause problems. See
682 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
683 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
684 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
685 All uses changed.
37aa2f85
PE
686 (offset_intervals): Tell GCC not to worry about length overflow
687 when negating a negative length.
c20db43f 688
2538aa2f
PE
689 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
690 (overrun_check_free): Likewise.
691
f2d3008d
PE
692 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
693 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
694 word size.
695
ec8df744
PE
696 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
697 (gnutls_make_error): Rename local to avoid shadowing.
698 (gnutls_emacs_global_deinit): ifdef out; not used.
699 (Fgnutls_boot): Use const for pointer to readonly storage.
700 Comment out unused local. Fix pointer signedness problems.
701
640ee02d
PE
702 * lread.c (openp): Don't stuff size_t into an 'int'.
703 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
704 about possible signed overflow.
705
6048fb2a
PE
706 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
707 (GDK_KEY_g): Don't define if already defined.
708 (xg_prepare_tooltip): Avoid pointer signedness problem.
709 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
710
fa3c87e1
PE
711 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
712 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
713
2172544b
PE
714 * xfns.c (Fx_window_property): Simplify a bit,
715 to make a bit faster and to avoid GCC 4.6.0 warning.
716 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
717
9b821a21
PE
718 * fns.c (internal_equal): Don't assume size_t fits in int.
719
3c616cfa
PE
720 * alloc.c (compact_small_strings): Tighten assertion a little.
721
c2982e87
PE
722 Replace pEd with more-general pI, and fix some printf arg casts.
723 * lisp.h (pI): New macro, generalizing old pEd macro to other
724 conversion specifiers. For example, use "...%"pI"d..." rather
725 than "...%"pEd"...".
726 (pEd): Remove. All uses replaced with similar uses of pI.
727 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
728 * alloc.c (check_pure_size): Don't overflow by converting size to int.
729 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
730 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
731 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
732 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
733 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
734 64-bit hosts.
735 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
736 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
737 * print.c (safe_debug_print, print_object): Likewise.
738 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
739 to int.
6f04d126
PE
740 Use pI instead of if-then-else-abort. Use %p to avoid casts,
741 avoiding the 0 flag, which is not portable.
c2982e87
PE
742 * process.c (Fmake_network_process): Use pI to avoid cast.
743 * region-cache.c (pp_cache): Likewise.
744 * xdisp.c (decode_mode_spec): Likewise.
745 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
746 behavior on 64-bit hosts with printf arg.
6f04d126 747 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
748 (x_stop_queuing_selection_requests): Likewise.
749 (x_get_window_property): Don't truncate byte count to an 'int'
750 when tracing.
0b432f21 751
5e073ec7
PE
752 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
753 here, since it parses constructs like leading '-' and spaces,
754 which are not wanted; and it overflows with large numbers.
755 Instead, simply match F[0-9]+, which is what is wanted anyway.
756
36372bf9
PE
757 * alloc.c: Remove unportable assumptions about struct layout.
758 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
759 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
760 (allocate_vectorlike, make_pure_vector): Use the new macros,
761 plus offsetof, to remove unportable assumptions about struct layout.
762 These assumptions hold on all porting targets that I know of, but
763 they are not guaranteed, they're easy to remove, and removing them
764 makes further changes easier.
765
0b432f21
PE
766 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
767 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
768 (string_overrun_cookie): Now const. Use initializers that
769 don't formally overflow signed char, to avoid warnings.
000098c1
PE
770 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
771 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
772 (allocate_buffer): Don't assume sizeof (struct buffer) is a
773 multiple of sizeof (EMACS_INT); it need not be, if
774 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 775 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 776
895009e1
JB
7772011-04-26 Juanma Barranquero <lekktu@gmail.com>
778
779 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
780
6a7a1b0b
TZ
7812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
782
783 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 784 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
785 Reported by Paul Eggert <eggert@cs.ucla.edu>.
786
841a1577 7872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
788
789 * lisp.h (Qdebug): List symbol.
895009e1 790 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
791 * keyboard.c (debug-on-event): New variable.
792 (handle_user_signal): Break into debugger when debug-on-event
793 matches the current signal symbol.
794
f2d3ba6f
DN
7952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
796
797 * alloc.c (check_sblock, check_string_bytes)
798 (check_string_free_list): Convert to standard C.
799
42ce4c63
TZ
8002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
801
802 * w32.c (emacs_gnutls_push): Fix typo.
803
825cd63c
EZ
8042011-04-25 Eli Zaretskii <eliz@gnu.org>
805
fb11d64d
EZ
806 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
807 "cast to pointer from integer of different size".
808
825cd63c
EZ
809 Improve doprnt and its use in verror. (Bug#8545)
810 * doprnt.c (doprnt): Document the set of format control sequences
811 supported by the function. Use SAFE_ALLOCA instead of always
812 using `alloca'.
813
814 * eval.c (verror): Don't limit the buffer size at size_max-1, that
815 is one byte too soon. Don't use xrealloc; instead xfree and
816 xmalloc anew.
817
e061a11b
TZ
8182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
819
820 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
821 callbacks stage.
822
823 * gnutls.c: Renamed global_initialized to
824 gnutls_global_initialized. Added internals for the
825 :verify-hostname-error, :verify-error, and :verify-flags
826 parameters of `gnutls-boot' and documented those parameters in the
827 docstring. Start callback support.
828 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
829 unless a fatal error occured. Call gnutls_alert_send_appropriate
830 on error. Return error code.
831 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
832 (emacs_gnutls_read): Likewise.
833 (Fgnutls_boot): Return handshake error code.
834 (emacs_gnutls_handle_error): New function.
835 (wsaerror_to_errno): Likewise.
836
837 * w32.h (emacs_gnutls_pull): Add prototype.
838 (emacs_gnutls_push): Likewise.
839
840 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
841 (emacs_gnutls_push): Likewise.
842
8432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
844
845 * process.c (wait_reading_process_output): Check if GnuTLS
846 buffered some data internally if no FDs are set for TLS
847 connections.
848
849 * makefile.w32-in (OBJ2): Add gnutls.$(O).
850 (LIBS): Link to USER_LIBS.
851 ($(BLD)/gnutls.$(0)): New target.
852
fa6996bc
EZ
8532011-04-24 Eli Zaretskii <eliz@gnu.org>
854
eb35682e
EZ
855 * xdisp.c (handle_single_display_spec): Rename the
856 display_replaced_before_p argument into display_replaced_p, to
857 make it consistent with the commentary. Fix typos in the
858 commentary.
859
e2ad650c
EZ
860 * textprop.c (syms_of_textprop): Remove dead code.
861 (copy_text_properties): Delete obsolete commentary about an
862 interface that was deleted long ago. Fix typos in the description
863 of arguments.
864
1b2de274
EZ
865 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
866 to changes in oldXMenu/XMenu.h from 2011-04-16.
867 <menu_help_message, prev_menu_help_message>: Constify.
868 (IT_menu_make_room): menu->help_text is now `const char **';
869 adjust.
870
871 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
872 to changes in oldXMenu/XMenu.h from 2011-04-16.
873 (struct XMenu): Declare `help_text' `const char **'.
874
875 * xfaces.c <Qunspecified>: Make extern again.
876
877 * syntax.c: Include sys/types.h before including regex.h, as
878 required by Posix.
879
762b15be
EZ
880 * doc.c (get_doc_string): Improve the format passed to `error'.
881
882 * doprnt.c (doprnt): Improve commentary.
883
884 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
885
886 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
887 them with etags.
888
f1052e5d
EZ
889 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
890 changes in globals.h immediately force recompilation.
762b15be
EZ
891 (TAGS): Depend on $(CURDIR)/m/intel386.h and
892 $(CURDIR)/s/ms-w32.h.
893 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 894
fa6996bc
EZ
895 * character.c (Fchar_direction): Function deleted.
896 (syms_of_character): Don't defsubr it.
897 <char-direction-table>: Deleted.
898
e6c3da20
EZ
8992011-04-23 Eli Zaretskii <eliz@gnu.org>
900
901 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
902 * doprnt.c: Include limits.h.
903 (SIZE_MAX): New macro.
04f2d78b
CB
904 (doprnt): Return a size_t value. 2nd arg is now size_t.
905 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
906 Improve overflow protection. Support `l' modifier for integer
907 conversions. Support %l conversion. Don't assume an EMACS_INT
908 argument for integer conversions and for %c.
909
910 * lisp.h (doprnt): Restore prototype.
911
912 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
913 $(SRC)/character.h.
914
915 * Makefile.in (base_obj): Add back doprnt.o.
916
917 * deps.mk (doprnt.o): Add back prerequisites.
918 (callint.o): Depend on character.h.
919
920 * eval.c (internal_lisp_condition_case): Include the handler
921 representation in the error message.
922 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
923 when breaking from the loop.
924
925 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
926
927 * callint.c (Fcall_interactively): When displaying error message
928 about invalid control letter, pass the character's codepoint, not
929 a pointer to its multibyte form. Improve display of the character
930 in octal and display also its hex code.
931
932 * character.c (char_string): Use %x to display the (unsigned)
933 codepoint of an invalid character, to avoid displaying a bogus
934 negative value.
935
936 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
937 `error', not SYMBOL_NAME itself.
938
939 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
940 character arguments to `error'.
941
942 * charset.c (check_iso_charset_parameter): Fix incorrect argument
943 to `error' in error message about FINAL_CHAR argument. Make sure
944 FINAL_CHAR is a character, and use %c when it is passed as
945 argument to `error'.
946
4ffd0d6b 9472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
948
949 * s/ms-w32.h (localtime): Redirect to sys_localtime.
950
951 * w32.c: Include <time.h>.
952 (sys_localtime): New function.
953
4ffd0d6b 9542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
955
956 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
957
4ffd0d6b 958 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 959
4ffd0d6b 9602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 961
4ffd0d6b
GM
962 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
963 zombies (Bug#8467).
aac0c6e3 964
04c56954
EZ
9652011-04-19 Eli Zaretskii <eliz@gnu.org>
966
967 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
968 gl_state.e_property when gl_state.object is Qt.
969
970 * insdel.c (make_gap_larger): Remove limitation of buffer size
971 to <= INT_MAX.
972
16a43933
CY
9732011-04-18 Chong Yidong <cyd@stupidchicken.com>
974
975 * xdisp.c (lookup_glyphless_char_display)
976 (produce_glyphless_glyph): Handle cons cell entry in
977 glyphless-char-display.
978 (Vglyphless_char_display): Document it.
979
980 * term.c (produce_glyphless_glyph): Handle cons cell entry in
981 glyphless-char-display.
982
4581706e
CY
9832011-04-17 Chong Yidong <cyd@stupidchicken.com>
984
985 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
986
987 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
988
989 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
990 definition for no-X builds.
991
4887c6e2 9922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 993
fd35b6f9
PE
994 Static checks with GCC 4.6.0 and non-default toolkits.
995
5c1ccb01
PE
996 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
997
006c5daa
PE
998 * process.c (keyboard_bit_set): Define only if SIGIO.
999 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1000 (send_process): Repair possible setjmp clobbering.
1001
efc736d3
PE
1002 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1003
4e2fe2e6
PE
1004 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1005
f97334a2
PE
1006 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1007
4e75f29d
PE
1008 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1009 Define only if needed.
1010
90efadd1
PE
1011 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1012 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1013 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1014
3c647824
PE
1015 * dispextern.h (struct redisplay_interface): Rename param
1016 to avoid shadowing.
e264f262 1017 * termhooks.h (struct terminal): Likewise.
761383f4 1018 * xterm.c (xembed_send_message): Likewise.
3c647824 1019
b58c5c4a
PE
1020 * insdel.c (make_gap_smaller): Define only if
1021 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1022
cad59032
PE
1023 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1024 it.
1025
c339dc2e
PE
1026 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1027 so that we aren't warned about unused symbols.
1028
91a3e27b
PE
1029 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1030
399c71d3 1031 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1032
8ffc96f5
PE
1033 * xfns.c (x_real_positions): Mark locals as initialized.
1034
eef9bc79
PE
1035 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1036
098db9dd
PE
1037 * xterm.c: Fix problems found by static analysis with other toolkits.
1038 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1039 (x_dispatch_event): Declare static if USE_GTK, and
1040 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1041 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1042 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1043 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1044 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1045
eb18f6cc
PE
1046 * xmenu.c (menu_help_callback): Pointer type fixes.
1047 Use const pointers when pointing at readonly data. Avoid pointer
1048 signedness clashes.
1049 (FALSE): Remove unused macro.
1050 (update_frame_menubar): Remove unused decl.
1051
1fe72bf8
PE
1052 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1053
60d9e1db
PE
1054 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1055 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1056 (single_menu_item): Rename local to avoid shadowing.
1057
39261c26
PE
1058 * keyboard.c (make_lispy_event): Remove unused local var.
1059
018c5e19
PE
1060 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1061 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1062
63d2b86e
PE
1063 * bitmaps: Change bitmaps from unsigned char back to the X11
1064 compatible char. Avoid the old compiler warnings about
1065 out-of-range initializers by using, for example, '\xab' rather
1066 than 0xab.
1067
aefd87e1
PE
1068 * xgselect.c (xgselect_initialize): Check vs interface
1069 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1070
bf501fb9
PE
1071 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1072
e9829fdf
PE
1073 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1074 to read-only memory.
1075
1086c095
PE
1076 * fns.c (vector): Remove; this old hack is no longer needed.
1077
2baccd04 1078 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1079 Remove unused var.
dde42981 1080 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1081
72391843 1082 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1083
436c16df 1084 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1085 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1086 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1087
92bb796d 1088 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1089 (x_term_init): Remove local to avoid shadowing.
92bb796d 1090
764430a3 1091 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1092
1093 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1094 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1095
d1dfb56c
EZ
10962011-04-16 Eli Zaretskii <eliz@gnu.org>
1097
c4354cb4
EZ
1098 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1099
d1dfb56c
EZ
1100 Fix regex.c, syntax.c and friends for buffers > 2GB.
1101 * syntax.h (struct gl_state_s): Declare character position members
1102 EMACS_INT.
1103
1104 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1105
04f2d78b
CB
1106 * textprop.c (verify_interval_modification, interval_of):
1107 Declare arguments EMACS_INT.
d1dfb56c
EZ
1108
1109 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1110 EMACS_INT.
1111
1112 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1113
1114 * indent.c (Fvertical_motion): Local variable it_start is now
1115 EMACS_INT.
1116
1117 * regex.c (re_match, re_match_2, re_match_2_internal)
1118 (bcmp_translate, regcomp, regexec, print_double_string)
1119 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1120 (re_compile_pattern, re_exec): Declare arguments and local
1121 variables `size_t' and `ssize_t' and return values `regoff_t', as
1122 appropriate.
1123 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1124 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1125 <compile_stack_type>: `size' and `avail' are now `size_t'.
1126
1127 * regex.h <regoff_t>: Use ssize_t, not int.
1128 (re_search, re_search_2, re_match, re_match_2): Arguments that
1129 specify buffer/string position and length are now ssize_t and
1130 size_t. Return type is regoff_t.
1131
613052cd
BK
11322011-04-16 Ben Key <bkey76@gmail.com>
1133
1134 * nsfont.m: Fixed bugs in ns_get_family and
1135 ns_descriptor_to_entity that were caused by using free to
1136 deallocate memory blocks that were allocated by xmalloc (via
1137 xstrdup). This caused Emacs to crash when compiled with
1138 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1139 --enable-checking=xmallocoverrun). xfree is now used to
1140 deallocate these memory blocks.
1141
4170f62f 11422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1143
71b41406
PE
1144 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1145
9587a89d
PE
1146 emacs_write: Accept and return EMACS_INT for sizes.
1147 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1148 et seq.
1149 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1150 Accept and return EMACS_INT.
1151 (emacs_gnutls_write): Return the number of bytes written on
1152 partial writes.
1153 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1154 (emacs_read, emacs_write): Remove check for negative size, as the
1155 Emacs source code has been audited now.
9587a89d
PE
1156 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1157 (emacs_read, emacs_write): Use it.
273a5f82
PE
1158 * process.c (send_process): Adjust to the new signatures of
1159 emacs_write and emacs_gnutls_write. Do not attempt to store
1160 a byte offset into an 'int'; it might overflow.
9587a89d 1161 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1162
3e047f51
PE
1163 * sound.c: Don't assume sizes fit in 'int'.
1164 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1165 Return EMACS_INT, not int.
3e047f51 1166 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1167 Accept EMACS_INT, not int.
1168 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1169 record read return values.
1170
cc39a9db
BK
11712011-04-15 Ben Key <bkey76@gmail.com>
1172
c9d0ec6d
JB
1173 * keyboard.c (Qundefined): Don't declare static since it is used
1174 in nsfns.m.
1175 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1176 static since they are used in nsfont.m.
cc39a9db 1177
6c60eb9f
SM
11782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1179
1180 * process.c (Qprocessp): Don't declare static.
1181 * lisp.h (Qprocessp): Declare again.
1182
7990b61a
JB
11832011-04-15 Juanma Barranquero <lekktu@gmail.com>
1184
1185 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1186
5d4cb038
PE
11872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1188
8bd7b830 1189 Improve C-level modularity by making more things 'static'.
cd64ea1d 1190
e3b27b31
PE
1191 Don't publish debugger-only interfaces to other modules.
1192 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1193 (verify_bytepos, count_markers): Move decls to the only modules
1194 that need them.
1195 * region-cache.h (pp_cache): Likewise.
1196 * window.h (check_all_windows): Likewise.
1197 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1198
5d4cb038
PE
1199 * sysdep.c (croak): Now static, if
1200 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1201 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1202
1203 * alloc.c (refill_memory_reserve): Now static if
1204 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1205 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1206
e87b6180
PE
1207 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1208 Define only if USE_LUCID.
1209
ac64929e
PE
1210 * xrdb.c (x_customization_string, x_rm_string): Now static.
1211
6f37259d
PE
1212 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1213 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1214
1683e3ab
PE
1215 * xdisp.c (draw_row_with_mouse_face): Now static.
1216 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1217
de9c2632
PE
1218 * window.h (check_all_windows): Mark externally visible.
1219
2b96acb7
PE
1220 * window.c (window_deletion_count): Now static.
1221
1222 * undo.c: Make symbols static if they're not exported.
1223 (last_undo_buffer, last_boundary_position, pending_boundary):
1224 Now static.
1225
50436f33
PE
1226 * textprop.c (interval_insert_behind_hooks): Now static.
1227 (interval_insert_in_front_hooks): Likewise.
1228
64520e5c
PE
1229 * term.c: Make symbols static if they're not exported.
1230 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1231 (max_frame_lines, tty_set_terminal_modes):
1232 (tty_reset_terminal_modes, tty_turn_off_highlight):
1233 (get_tty_terminal): Now static.
1234 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1235 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1236 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1237 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1238 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1239
1fa53021
PE
1240 * sysdep.c: Make symbols static if they're not exported.
1241 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1242 Now static.
1243 (sigprocmask_set, full_mask): Remove; unused.
1244 (wait_debugging): Mark as visible.
1245 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1246 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1247
d4b43b22
PE
1248 * syntax.c (syntax_temp): Define only if !__GNUC__.
1249
b7c513d0
PE
1250 * sound.c (current_sound_device, current_sound): Now static.
1251
989b29ad
PE
1252 * search.c (searchbufs, searchbuf_head): Now static.
1253
13a55a78
PE
1254 * scroll.c (scroll_cost): Remove; unused.
1255 * dispextern.h (scroll_cost): Remove decl.
1256
de68a1fc
PE
1257 * region-cache.h (pp_cache): Mark as externally visible.
1258
40ccffa6
PE
1259 * process.c: Make symbols static if they're not exported.
1260 (process_tick, update_tick, create_process, chan_process):
1261 (Vprocess_alist, proc_buffered_char, datagram_access):
1262 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1263 (deactivate_process): Mark defn as static, as well as decl.
1264 * lisp.h (create_process): Remove decl.
1265 * process.h (chan_process, Vprocess_alist): Remove decls.
1266
ad64fc97
PE
1267 * print.c: Make symbols static if they're not exported.
1268 (print_depth, new_backquote_output, being_printed, print_buffer):
1269 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1270 (print_interval, print_number_index, initial_stderr_stream):
1271 Now static.
1272 * lisp.h (Fprinc): Remove decl.
1273 (debug_output_compilation_hack): Mark as externally visible.
1274
adddb265
PE
1275 * sysdep.c (croak): Move decl from here to syssignal.h.
1276 * syssignal.h (croak): Put it here, so the API can be checked when
1277 'croak' is called from dissociate_if_controlling_tty.
1278
1717ede2
PE
1279 * minibuf.c: Make symbols static if they're not exported.
1280 (minibuf_save_list, choose_minibuf_frame): Now static.
1281 * lisp.h (choose_minibuf_frame): Remove decl.
1282
fa5fb2bc
PE
1283 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1284
1e3890d1
PE
1285 * lread.c: Make symbols static if they're not exported.
1286 (read_objects, initial_obarray, oblookup_last_bucket_number):
1287 Now static.
1288 (make_symbol): Remove; unused.
1289 * lisp.h (initial_obarray, make_symbol): Remove decls.
1290
8a1414fa
PE
1291 * keyboard.c: Make symbols static if they're not exported.
1292 (single_kboard, recent_keys_index, total_keys, recent_keys):
1293 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1294 (this_single_command_key_start, echoing, last_auto_save):
1295 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1296 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1297 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1298 (Vlispy_mouse_stem, double_click_count):
1299 Now static.
1300 (force_auto_save_soon): Define only if SIGDANGER.
1301 (ignore_mouse_drag_p): Now static if
1302 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1303 (print_help): Remove; unused.
1304 (stop_character, last_timer_event): Mark as externally visible.
1305 * keyboard.h (ignore_mouse_drag_p): Declare only if
1306 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1307 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1308 * lisp.h (echoing): Remove decl.
1309 (force_auto_save_soon): Declare only if SIGDANGER.
1310 * xdisp.c (redisplay_window): Simplify code, to make it more
1311 obvious that ignore_mouse_drag_p is not accessed if !defined
1312 USE_GTK && !defined HAVE_NS.
1313
93ea6e8f
PE
1314 * intervals.c: Make symbols static if they're not exported.
1315 (merge_properties_sticky, merge_interval_right, delete_interval):
1316 Now static.
1317 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1318
77382fcc
PE
1319 * insdel.c: Make symbols static if they're not exported.
1320 However, leave prepare_to_modify_buffer alone. It's never
1321 called from outside this function, but that appears to be a bug.
1322 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1323 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1324 (adjust_after_replace_noundo): Remove; unused.
1325 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1326 (signal_before_change): Remove decls.
77382fcc 1327
9306c32e
PE
1328 * indent.c (val_compute_motion, val_vmotion): Now static.
1329
cd44d2eb
PE
1330 * image.c: Make symbols static if they're not exported.
1331 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1332 if USE_GTK.
1333 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1334 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1335
ad9a7a06
PE
1336 * fringe.c (standard_bitmaps): Now static.
1337 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1338
81626931
PE
1339 * frame.c: Make symbols static if they're not exported.
1340 (x_report_frame_params, make_terminal_frame): Now static.
1341 (get_frame_param): Now static, unless HAVE_NS.
1342 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1343 (x_get_resource_string): Remove; not used.
1344 * frame.h (make_terminal_frame, x_report_frame_params):
1345 (x_get_resource_string); Remove decls.
1346 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1347 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1348
239f9db9
PE
1349 * font.c, fontset.c: Make symbols static if they're not exported.
1350 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1351 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1352 * font.c (font_close_object): Now static.
1353 * font.h (font_close_object): Remove.
1354 * fontset.c (FONTSET_OBJLIST): Remove.
1355 (free_realized_fontset) #if-0 the body, which does nothing.
1356 (face_suitable_for_char_p): #if-0, as it's never called.
1357 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1358 * xfaces.c (face_at_string_position):
1359 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1360 since 0 is always ASCII.
1361
dfcf3579
PE
1362 * fns.c (weak_hash_tables): Now static.
1363
5045092b
PE
1364 * fileio.c: Make symbols static if they're not exported.
1365 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1366 (Vwrite_region_annotation_buffers): Now static.
1367
57a96f5c
PE
1368 * eval.c: Make symbols static if they're not exported.
1369 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1370 * lisp.h (backtrace_list): Remove decl.
1371
35f08c38
PE
1372 * emacs.c: Make symbols static if they're not exported.
1373 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1374 (fatal_error_code, fatal_error_signal_hook, standard_args):
1375 Now static.
1376 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1377 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1378 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1379 * lisp.h (fatal_error_signal_hook): Remove decl.
1380 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1381
f44bd759
PE
1382 * editfns.c: Move a (normally-unused) function to its only use.
1383 * editfns.c, lisp.h (get_operating_system_release): Remove.
1384 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1385 worth the hassle of breaking this out.
1386
b532497d
PE
1387 * xterm.c: Make symbols static if they're not exported.
1388 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1389 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1390 (x_destroy_window, x_delete_display):
1391 Now static.
1392 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1393 (x_mouse_leave): Remove; unused.
1394 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1395 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1396 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1397 Remove decls.
1398 (x_mouse_leave): Declare only if WINDOWSNT.
1399 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1400 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1401 USE_X_TOOLKIT.
1402
1675728f
PE
1403 * ftxfont.c: Make symbols static if they're not exported.
1404 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1405 HAVE_FREETYPE.
1406 * font.h (ftxfont_driver): Likewise.
1407
e4cebfca
PE
1408 * xfns.c: Make symbols static if they're not exported.
1409 (x_last_font_name, x_display_info_for_name):
1410 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1411 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1412 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1413 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1414 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1415 (last_show_tip_args): Now static.
1416 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1417 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1418 (x_screen_planes): Remove; unused.
1419 * dispextern.h (x_screen_planes): Remove decl.
1420
5bf46f05
PE
1421 * dispnew.c: Make symbols static if they're not exported.
1422 * dispextern.h (redraw_garbaged_frames, scrolling):
1423 (increment_row_positions): Remove.
1424 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1425 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1426 Now static.
1427 (redraw_garbaged_frames): Remove; unused.
1428
435f4c28
PE
1429 * xfaces.c: Make symbols static if they're not exported.
1430 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1431 Remove decls.
1432 * xterm.h (defined_color): Remove decls.
1433 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1434 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1435 (menu_face_changed_default, defined_color, free_realized_face):
1436 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1437 (ascii_face_of_lisp_face): Remove; unused.
1438
8524aef3
PE
1439 * xdisp.c: Make symbols static if they're not exported.
1440 * dispextern.h (scratch_glyph_row, window_box_edges):
1441 (glyph_to_pixel_coords, set_cursor_from_row):
1442 (get_next_display_element, set_iterator_to_next):
1443 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1444 (show_mouse_face): Remove decls
1445 * frame.h (message_buf_print): Likewise.
1446 * lisp.h (pop_message, set_message, check_point_in_composition):
1447 Likewise.
1448 * xterm.h (set_vertical_scroll_bar): Likewise.
1449 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1450 (message_buf_print, scratch_glyph_row, displayed_buffer):
1451 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1452 (get_next_display_element, show_mouse_face, window_box_edges):
1453 (frame_to_window_pixel_xy, check_point_in_composition):
1454 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1455 (glyph_to_pixel_coords): Remove; unused.
1456
16390cd2
PE
1457 * dired.c (file_name_completion): Now static.
1458
1459 * dbusbind.c (xd_in_read_queued_messages): Now static.
1460
a25f4dfa
PE
1461 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1462 * data.c (circular_list_error): Remove.
1463
14a9c8df
PE
1464 * commands.h (last_point_position, last_point_position_buffer):
1465 (last_point_position_window): Remove decls.
1466 * keyboard.c: Make these variables static.
1467
04f2d78b
CB
1468 * coding.h (coding, code_convert_region, encode_coding_gap):
1469 Remove decls.
74ab6df5
PE
1470 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1471 (iso_code_class, detect_coding, code_convert_region): Now static.
1472 (encode_coding_gap): Remove; unused.
1473
38dfbee1
PE
1474 * chartab.c (chartab_chars, chartab_bits): Now static.
1475
a2cb4e63
PE
1476 * charset.h (charset_iso_8859_1): Remove decl.
1477 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1478 Now static.
1479
127198fd
PE
1480 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1481 * ccl.c (Vccl_program_table): Now static.
1482 (check_ccl_update): Remove; unused.
1483
d85b608f
PE
1484 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1485 * category.h: ... from here.
1486 * category.c (check_category_table, set_category_set): Now static.
1487
31cd66f3
PE
1488 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1489 * lisp.h: Remove these decls.
1490
c358e587
PE
1491 * buffer.c (buffer_count): Remove unused var.
1492
e78aecca
PE
1493 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1494 so that it's not optimized away.
1495 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1496 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1497 exported only to the debugger.
1498
e192d7d3 1499 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1500 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1501
92470028
PE
1502 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1503 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1504 was inaccessible from Lisp.
1505 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1506 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1507
244ed907
PE
1508 alloc.c: Import and export fewer symbols, and remove unused items.
1509 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1510 is defined.
1511 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1512 it's not optimized away by whole-program optimization.
1513 (message_enable_multibyte, free_misc): Remove.
1514 (catchlist, handlerlist, mark_backtrace):
1515 Declare only if BYTE_MARK_STACK.
1516 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1517 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1518 (message_enable_multibyte): Remove decl.
1519 (free_misc, interval_free_list, float_block, float_block_index):
1520 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1521 (cons_free_list, last_marked_index):
1522 Now static.
1523 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1524 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1525 (mark_backtrace): Define only if BYTE_MARK_STACK.
1526 * xdisp.c (message_enable_multibyte): Now static.
1527
61c2b50e 1528 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1529 This makes it easier for human readers (and static analyzers)
1530 to see whether these variables are used from other modules.
1531 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1532 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1533 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1534 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1535 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1536 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1537 * xmenu.c, xselect.c:
1538 Declare Q* vars static if they are not used in other modules.
1539 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1540 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1541 Remove decls of unexported vars.
1542 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1543
95c82688
PE
1544 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1545
16a97296
PE
1546 Make Emacs functions such as Fatom 'static' by default.
1547 This makes it easier for human readers (and static analyzers)
1548 to see whether these functions can be called from other modules.
1549 DEFUN now defines a static function. To make the function external
1550 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1551 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1552 (Finit_image_library):
16a97296
PE
1553 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1554 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1555 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1556 Remove decls, since these functions are now static.
1557 (Funintern, Fget_internal_run_time): New decls, since these functions
1558 were already external.
95c82688 1559
16a97296
PE
1560 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1561 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1562 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1563 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1564 * keyboard.c, keymap.c, lread.c:
1565 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1566 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1567 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1568 Mark functions with DEFUE instead of DEFUN,
1569 if they are used in other modules.
1570 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1571 decls for now-static functions.
1572 * buffer.h (Fdelete_overlay): Remove decl.
1573 * callproc.c (Fgetenv_internal): Mark as internal.
1574 * composite.c (Fremove_list_of_text_properties): Remove decl.
1575 (Fcomposition_get_gstring): New forward static decl.
1576 * composite.h (Fcomposite_get_gstring): Remove decl.
1577 * dired.c (Ffile_attributes): New forward static decl.
1578 * doc.c (Fdocumntation_property): New forward static decl.
1579 * eval.c (Ffetch_bytecode): New forward static decl.
1580 (Funintern): Remove extern decl; now in .h file where it belongs.
1581 * fileio.c (Fmake_symbolic_link): New forward static decl.
1582 * image.c (Finit_image_library): New forward static decl.
1583 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1584 * intervals.h (Fprevious_property_change):
1585 (Fremove_list_of_text_properties): Remove decls.
1586 * keyboard.c (Fthis_command_keys): Remove decl.
1587 (Fcommand_execute): New forward static decl.
1588 * keymap.c (Flookup_key): New forward static decl.
1589 (Fcopy_keymap): Now static.
1590 * keymap.h (Flookup_key): Remove decl.
1591 * process.c (Fget_process): New forward static decl.
1592 (Fprocess_datagram_address): Mark as internal.
1593 * syntax.c (Fsyntax_table_p): New forward static decl.
1594 (skip_chars): Remove duplicate decl.
1595 * textprop.c (Fprevious_property_change): New forward static decl.
1596 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1597 Now internal.
1598 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1599 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1600
785bbd42
PE
1601 * editfns.c (Fformat): Remove unreachable code.
1602
8b913b57
AS
16032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1604
1605 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1606 change. (Bug#8496)
1607
a6744a35
EZ
16082011-04-13 Eli Zaretskii <eliz@gnu.org>
1609
1610 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1611 when at ZV. (Bug#8487)
1612
e7974947
AS
16132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1614
baad03f0
AS
1615 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1616 (Bug#8437)
1617 * keyboard.c (parse_tool_bar_item): Likewise.
1618 * sound.c (sound_cleanup, alsa_close): Likewise.
1619 * termcap.c (tgetent): Likewise.
1620 * xfns.c (x_default_font_parameter): Likewise.
1621 * xsettings.c (read_and_apply_settings): Likewise.
1622
e7974947
AS
1623 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1624 (overrun_check_free): Protoize.
1625
28272684
PE
16262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1629 since callers should never pass a negative size.
1630 Change the signature to match that of plain 'read' and 'write'; see
1631 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1632 * lisp.h: Update prototypes of emacs_write and emacs_read.
1633
11997c76
EZ
16342011-04-11 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xdisp.c (redisplay_window): Don't try to determine the character
1637 position of the scroll margin if the window start point w->startp
e896f03c 1638 is outside the buffer's accessible region. (Bug#8468)
11997c76 1639
8a2cbd72
EZ
16402011-04-10 Eli Zaretskii <eliz@gnu.org>
1641
1642 Fix write-region and its subroutines for buffers > 2GB.
1643 * fileio.c (a_write, e_write): Modify declaration of arguments and
1644 local variables to support buffers larger than 2GB.
1645 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1646
1647 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1648 argument, local variables, and return value.
1649
1650 * lisp.h: Update prototypes of emacs_write and emacs_read.
1651
1652 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1653
4073e537 16542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1655
1ebfdcb6
PE
1656 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1657
b2ded58d
PE
1658 Fix more problems found by GCC 4.6.0's static checks.
1659
7d66342c
PE
1660 * xdisp.c (vmessage): Use a better test for character truncation.
1661
bbf47d44
PE
1662 * charset.c (load_charset_map): <, not <=, for optimization,
1663 and to avoid potential problems with integer overflow.
9248994d 1664 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1665 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1666 * editfns.c (Fformat): Likewise.
1e69125e 1667 * syntax.c (skip_chars): Likewise.
3befa583 1668
e3019616
PE
1669 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1670 This also lets GCC 4.6.0 generate slightly better loop code.
1671
becfa255
PE
1672 * callint.c (Fcall_interactively): <, not <=, for optimization.
1673 (Fcall_interactively): Count the number of arguments produced,
1674 not the number of arguments given. This is simpler and lets GCC
1675 4.6.0 generate slightly better code.
1676
dae0cd48
PE
1677 * ftfont.c: Distingish more carefully between FcChar8 and char.
1678 The previous code passed unsigned char * to a functions like
1679 strlen and xstrcasecmp that expect char *, which does not
1680 conform to the C standard.
1681 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1682 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1683 char * when the C standard requires it.
1684
76032d70
PE
1685 * keyboard.c (read_char): Remove unused var.
1686
eb3f1cc8
PE
1687 * eval.c: Port to Windows vsnprintf (Bug#8435).
1688 Include <limits.h>.
1689 (SIZE_MAX): Define if the headers do not.
1690 (verror): Do not give up if vsnprintf returns a negative count.
1691 Instead, grow the buffer. This ports to Windows vsnprintf, which
1692 does not conform to C99. Problem reported by Eli Zaretskii.
1693 Also, simplify the allocation scheme, by avoiding the need for
1694 calling realloc, and removing the ALLOCATED variable.
1695
70476b54
PE
1696 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1697
12020a9e
PE
1698 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1699 But keep the doprint source code for now, as we might revamp it
1700 and use it again (Bug#8435).
ea6c7ae6
PE
1701 * lisp.h (doprnt): Remove.
1702 * Makefile.in (base_obj): Remove doprnt.o.
1703 * deps.mk (doprnt.o): Remove.
1704
5fdb398c
PE
1705 error: Print 32- and 64-bit integers portably (Bug#8435).
1706 Without this change, on typical 64-bit hosts error ("...%d...", N)
1707 was used to print both 32- and 64-bit integers N, which relied on
1708 undefined behavior.
1709 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1710 New macro.
1711 * lisp.h (error, verror): Mark as printf-like functions.
1712 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1713 Report overflow in size calculations when allocating printf buffer.
1714 Do not truncate output string at its first null byte.
1715 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1716 Truncate the output at a character boundary, since vsnprintf does not
1717 do that.
1718 * charset.c (check_iso_charset_parameter): Convert internal
1719 character to string before calling 'error', since %c now has the
1720 printf meaning.
1721 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1722 overflow when computing char to be passed to 'error'. Do not
1723 pass Lisp_Object to 'error'; pass the integer instead.
1724 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1725 formatted with plain %d.
1726
b189fa66
PE
1727 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1728
bff87ef0
PE
1729 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1730
7e2cac20
PE
1731 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1732
ce4d90b5
PE
1733 * xterm.c (x_catch_errors): Remove duplicate declaration.
1734
266c9547
PE
1735 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1736
79c49ad2
PE
1737 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1738
368f4090
JM
17392011-04-10 Jim Meyering <meyering@redhat.com>
1740
1741 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1742 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1743 return ssize_t not "int", and use size_t as the buffer length.
1744 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1745 * gnutls.h: Update declarations.
1746 * process.c (read_process_output): Use ssize_t, to match.
1747 (send_process): Likewise.
1748
a32d4040
CY
17492011-04-09 Chong Yidong <cyd@stupidchicken.com>
1750
1751 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1752
8546720e 17532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1754
04f2d78b
CB
1755 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1756 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1757
8546720e
GM
1758 * xterm.c (handle_one_xevent):
1759 * xmenu.c (create_and_show_popup_menu):
1760 * xselect.c (x_decline_selection_request)
1761 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1762
0a2f5c1a 17632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1764
1765 Fix some uses of `int' instead of EMACS_INT.
1766 * search.c (string_match_1, fast_string_match)
1767 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1768 (scan_buffer, find_next_newline_no_quit)
1769 (find_before_next_newline, search_command, Freplace_match)
1770 (Fmatch_data): Make some `int' variables be EMACS_INT.
1771
1772 * xdisp.c (display_count_lines): 3rd argument and return value now
1773 EMACS_INT. All callers changed.
1774 (pint2hrstr): Last argument is now EMACS_INT.
1775
1776 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1777 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1778 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1779 (decode_coding_utf_16, decode_coding_emacs_mule)
1780 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1781 (decode_coding_ccl, decode_coding_charset)
1782 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1783 (decode_coding_iso_2022, decode_coding_emacs_mule)
1784 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1785 <char_offset, last_offset>: Declare EMACS_INT.
1786 (encode_coding_utf_8, encode_coding_utf_16)
1787 (encode_coding_emacs_mule, encode_invocation_designation)
1788 (encode_designation_at_bol, encode_coding_iso_2022)
1789 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1790 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1791 Declare EMACS_INT.
1792 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1793 (encode_invocation_designation): Last argument P_NCHARS is now
1794 EMACS_INT.
1795 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1796 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1797
1798 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1799 All users changed.
1800
1801 * ccl.c (Fccl_execute_on_string): Declare some variables
1802 EMACS_INT.
1803
8546720e 18042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1805
1806 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1807
4e19a977
CS
18082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1809
1810 * process.c (Fformat_network_address): Doc fix.
1811
87302331
R
18122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1813
1814 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1815
cbb59342
CY
18162011-04-08 Chong Yidong <cyd@stupidchicken.com>
1817
1818 * keyboard.c (read_char): Call Lisp function help-form-show,
1819 instead of using internal_with_output_to_temp_buffer.
1820 (Qhelp_form_show): New var.
e0d38eeb 1821 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1822
1823 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1824
1825 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1826
e67a13ab
CY
18272011-04-06 Chong Yidong <cyd@stupidchicken.com>
1828
04f2d78b
CB
1829 * process.c (Flist_processes): Remove to Lisp.
1830 (list_processes_1): Delete.
e67a13ab 1831
973f782d
EZ
18322011-04-06 Eli Zaretskii <eliz@gnu.org>
1833
7c106b1e
EZ
1834 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1835
973f782d
EZ
1836 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1837
41cf7d1a 18382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1839
ca23cc88
PE
1840 Fix more problems found by GCC 4.6.0's static checks.
1841
f390e2d5
PE
1842 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1843
42eea0d0
PE
1844 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1845
b69769da 1846 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1847
f9541e84
PE
1848 * xdisp.c (vmessage): Mark as a printf-like function.
1849
13841b55
PE
1850 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1851
c136c10f
PE
1852 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1853
5e2d4a30
PE
1854 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1855 printf-like functions.
1856 (tiff_load): Add casts to remove these marks before passing them
1857 to system-supplied API.
1858
583f48b9
PE
1859 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1860
b25d760e
PE
1861 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1862 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1863 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1864 directly, rather than having caller test rule sign. This avoids
1865 some unnecessary tests.
1866 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1867 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1868 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1869
bc7b6697 1870 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1871 (xfont_open): Avoid unnecessary tests.
bc7b6697 1872
27ccc379
PE
1873 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1874
dcd5c89a
PE
1875 * composite.h, composite.c (composition_gstring_put_cache):
1876 Use EMACS_INT, not int, for length.
1877
b13a45c6
PE
1878 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1879 breaking out part of COMPOSITION_DECODE_RULE.
1880 (COMPOSITION_DECODE_RULE): Use it.
1881 * composite.c (get_composition_id): Remove unused local vars,
1882 by using the new macro.
1883
1e792e4d
PE
1884 * textprop.c (set_text_properties_1): Change while to do-while,
1885 since the condition is always true at first.
1886
dc6c6455 1887 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1888 (interval_deletion_adjustment): Return unsigned value.
1889 All uses changed.
dc6c6455 1890
aba7731a
PE
1891 * process.c (list_processes_1, create_pty, read_process_output):
1892 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1893 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1894 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1895 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1896 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1897
fdfc4bf3
PE
1898 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1899
fca8fe46 1900 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1901 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1902
06a0259a 1903 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1904 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1905 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1906
e7b9e80f
PE
1907 * print.c (print_error_message): Avoid int overflow.
1908
56201685
PE
1909 * font.c (font_list_entities): Redo for clarity,
1910 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1911
78834453 1912 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1913 (font_score): Avoid potential overflow in diff calculation.
78834453 1914
0bc0b309 1915 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1916 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1917
e610eaca
PE
1918 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1919
b895abce
PE
1920 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1921 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1922 can always succeed if overflow has undefined behavior.
1923
1f1d9321 1924 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1925 (wordify): Omit three unnecessary tests.
1f1d9321 1926
c59478bc
PE
1927 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1928 All callers changed. This avoids the need for an unused var.
1929
79b73827
PE
1930 * casefiddle.c (casify_region): Remove var that is set but not used.
1931
a4db5dfe
PE
1932 * dired.c (file_name_completion): Remove var that is set but not used.
1933
43aae36e
PE
1934 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1935
2a47c44d 1936 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1937 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1938
a37c69bf
PE
1939 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1940 Check for integer overflow on size calculations.
1941
328ab8e7
PE
1942 * buffer.c (Fprevious_overlay_change): Remove var that is set
1943 but not used.
1944
e5a2a5cb
PE
1945 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1946 Remove vars that are set but not used.
8d84a6eb 1947 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1948 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1949
a60e5f68
PE
1950 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1951
f661cb61 1952 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1953 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1954
f0397f5a
PE
1955 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1956 that are set but not used.
1957
8664db06 1958 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1959 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1960
6abdaa4a
PE
1961 * xselect.c (x_get_local_selection, x_handle_property_notify):
1962 Remove vars that are set but not used.
1963
0ce7538d 1964 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1965 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1966
9ae848fc
PE
1967 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1968 Remove var that is set but not used.
0b918413
PE
1969 (scroll_bar_windows_size): Now size_t, not int.
1970 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1971 Check for overflow.
9ae848fc 1972
a5a62657
PE
1973 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1974 (map_tty_color) [!defined MSDOS]: Likewise.
1975
5c5cdd39
PE
1976 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1977
66ebf983
PE
1978 * coding.c: Remove vars that are set but not used.
1979 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1980 All callers changed.
1981 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1982 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1983 (decode_coding_charset): Remove vars that are set but not used.
1984
1be4d761
PE
1985 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1986 that is set but not used.
1987
47553fa8
PE
1988 * print.c (print_object): Remove var that is set but not used.
1989
1f7196bf 1990 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1991 The gnulib version avoids calling malloc in the usual case,
1992 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1993 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1994 * filelock.c (current_lock_owner): Likewise.
1995 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1996 * sysdep.c: Include allocator.h, careadlinkat.h.
1997 (emacs_no_realloc_allocator): New static constant.
1998 (emacs_readlink): New function.
fdb61804
PE
1999 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2000 ../lib/careadlinkat.h.
d1fdcab7 2001
f84c17c7
SM
20022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2003
2004 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2005 first non-nil return value).
2006
ef3862ad
JD
20072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2008
2009 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2010 if not defined (Bug#8403).
2011
376a7006
JB
20122011-04-02 Juanma Barranquero <lekktu@gmail.com>
2013
2014 * xdisp.c (display_count_lines): Remove parameter `start',
2015 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2016 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2017 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2018 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2019 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2020 and thereabouts. All callers changed.
2021 (get_per_char_metric): Remove parameter `f', unused since
2022 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2023
6ca3801d
JM
20242011-04-02 Jim Meyering <meyering@redhat.com>
2025
2026 do not dereference NULL upon failed strdup
2027 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2028 (ns_get_family): Likewise.
2029
d8e2b5ba
JB
20302011-04-02 Juanma Barranquero <lekktu@gmail.com>
2031
2032 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2033
8c74fcbd
JD
20342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2035
2036 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2037 later (Bug#8403).
2038
7200d79c
SM
20392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2040
03408648 2041 Add lexical binding.
7200d79c 2042
03408648
SM
2043 * window.c (Ftemp_output_buffer_show): New fun.
2044 (Fsave_window_excursion):
2045 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2046
2047 * lread.c (lisp_file_lexically_bound_p): New function.
2048 (Fload): Bind Qlexical_binding.
2049 (readevalloop): Remove `evalfun' arg.
2050 Bind Qinternal_interpreter_environment.
2051 (Feval_buffer): Bind Qlexical_binding.
2052 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2053 Mark as dynamic.
2054 (syms_of_lread): Declare `lexical-binding'.
2055
2056 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2057
2058 * keyboard.c (eval_dyn): New fun.
2059 (menu_item_eval_property): Use it.
ca105506
SM
2060
2061 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2062
03408648
SM
2063 * fns.c (concat, mapcar1): Accept byte-code-functions.
2064
2065 * eval.c (Fsetq): Handle lexical vars.
2066 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2067 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2068 (FletX, Flet): Obey lexical binding.
2069 (Fcommandp): Handle closures.
2070 (Feval): New `lexical' arg.
2071 (eval_sub): New function extracted from Feval. Use it almost
2072 everywhere where Feval was used. Look up vars in lexical env.
2073 Handle closures.
2074 (Ffunctionp): Move from subr.el.
2075 (Ffuncall): Handle closures.
2076 (apply_lambda): Remove `eval_flags'.
2077 (funcall_lambda): Handle closures and new byte-code-functions.
2078 (Fspecial_variable_p): New function.
2079 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2080 but without exporting it to Lisp.
23aba0ea 2081
23aba0ea 2082 * doc.c (Fdocumentation, store_function_docstring):
03408648 2083 * data.c (Finteractive_form): Handle closures.
23aba0ea 2084
03408648
SM
2085 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2086 interactive spec.
ba83908c 2087
04f2d78b
CB
2088 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2089 New byte-codes.
03408648
SM
2090 (exec_byte_code): New function extracted from Fbyte_code to handle new
2091 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2092
03408648 2093 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2094
03408648 2095 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2096
e2abce01
JB
20972011-03-31 Juanma Barranquero <lekktu@gmail.com>
2098
2099 * xdisp.c (redisplay_internal): Fix prototype.
2100
63696a73 21012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2102
63696a73 2103 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2104 (try_scrolling): Use it when setting scroll_limit.
2105 Limit scrolling to 100 screen lines.
63696a73
EZ
2106 (redisplay_window): Even when falling back on "recentering",
2107 position point in the window according to scroll-conservatively,
2108 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2109
2110 (try_scrolling): When point is above the window, allow searching
2111 as far as scroll_max, or one screenful, to compute vertical
2112 distance from PT to the scroll margin position. This prevents
2113 try_scrolling from unnecessarily failing when
2114 scroll-conservatively is set to a value slightly larger than the
2115 window height. Clean up the case of PT below the margin at bottom
2116 of window: scroll_max can no longer be INT_MAX. When aggressive
2117 scrolling is in use, don't let point enter the opposite scroll
2118 margin as result of the scroll.
2119 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2120 threshold of 100 lines for never-recentering scrolling.
2121
e4cc2dfc
JB
21222011-03-31 Juanma Barranquero <lekktu@gmail.com>
2123
2124 * dispextern.h (move_it_by_lines):
2125 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2126 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2127 (message_log_check_duplicate): Remove parameters `prev_bol' and
2128 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2129 (redisplay_internal): Remove parameter `preserve_echo_area',
2130 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2131
2132 * indent.c (Fvertical_motion):
2133 * window.c (window_scroll_pixel_based, Frecenter):
2134 Don't pass `need_y_p' to `move_it_by_lines'.
2135
1c470562
SM
21362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2137
44f230aa
SM
2138 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2139 steal a few bits to be more compact.
2140 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2141 Remove unneeded casts.
2142
1c470562
SM
2143 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2144
888adce9
ZK
21452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2146
2147 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2148 binding" message (bug#7967).
2149
f838ed7b
PE
21502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2151
77861b95
PE
2152 Fix more problems found by GCC 4.6.0's static checks.
2153
de6dbc14
PE
2154 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2155 Remove unused local var.
2156
f838ed7b
PE
2157 * editfns.c (Fmessage_box): Remove unused local var.
2158
792c7b2b
PE
2159 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2160 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2161 Omit unused local vars.
c499e557 2162 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2163 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2164 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2165 Omit unused local var.
2166
ba0165e1
PE
2167 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2168 Don't assume string length fits in int.
32ad8845 2169 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2170 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2171
3c59b4c9
PE
2172 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2173 instead of alloca (Bug#8344).
2174
a3eed478 2175 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2176 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2177
eb4d412d
PE
2178 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2179
1658b401
PE
2180 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2181 concerns.
2182
2183 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2184
2185 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2186
9a2c6e05
PE
2187 * keyboard.c (syms_of_keyboard): Use the same style as later
2188 in this function when indexing through an array. This also
2189 works around GCC bug 48267.
2190
03d0a109
PE
2191 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2192
44f730c8
PE
2193 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2194
fe75f926
PE
2195 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2196 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2197
ffa8c828
PE
2198 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2199 This avoids undefined behavior on integer overflow, and is a bit
2200 more convenient anyway since it is compared to a size_t variable.
2201
c5101a77
PE
2202 Variadic C functions now count arguments with size_t, not int.
2203 This avoids an unnecessary limitation on 64-bit machines, which
2204 caused (substring ...) to crash on large vectors (Bug#8344).
2205 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2206 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2207 All variadic functions and their callers changed accordingly.
c5101a77
PE
2208 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2209 * data.c (arith_driver, float_arith_driver): Likewise.
2210 * editfns.c (general_insert_function): Likewise.
2211 * eval.c (struct backtrace.nargs, interactive_p)
2212 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2213 (funcall_lambda, mark_backtrace): Likewise.
2214 * fns.c (concat): Likewise.
2215 * frame.c (x_set_frame_parameters): Likewise.
2216 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2217 0 if not found, not -1. All callers changed.
2218
dd3f25f7
PE
2219 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2220 (stack_copy_size): Now size_t, not int.
2221 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2222
461c2ab9
JB
22232011-03-28 Juanma Barranquero <lekktu@gmail.com>
2224
2225 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2226 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2227 All callers changed.
2228
2229 * lisp.h (multibyte_char_to_unibyte):
2230 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2231 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2232 * character.h (CHAR_TO_BYTE8):
2233 * cmds.c (internal_self_insert):
2234 * editfns.c (general_insert_function):
2235 * keymap.c (push_key_description):
2236 * search.c (Freplace_match):
2237 * xdisp.c (message_dolog, set_message_1): All callers changed.
2238
f6d62986
SM
22392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2240
2241 * keyboard.c (safe_run_hook_funcall): New function.
2242 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2243 don't set the hook to nil, but remove the offending function instead.
2244 (Qcommand_hook_internal): Remove, unused.
2245 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2246 Vcommand_hook_internal.
2247
2248 * eval.c (enum run_hooks_condition): Remove.
2249 (funcall_nil, funcall_not): New functions.
2250 (run_hook_with_args): Call each function through a `funcall' argument.
2251 Remove `cond' argument, now redundant.
2252 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2253 (Frun_hook_with_args_until_failure): Adjust accordingly.
2254 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2255
1db5b1ad
JB
22562011-03-28 Juanma Barranquero <lekktu@gmail.com>
2257
2258 * dispextern.h (string_buffer_position): Remove declaration.
2259
2260 * print.c (strout): Remove parameter `multibyte', unused since
2261 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2262
2263 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2264 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2265 All callers changed.
2266
2267 * w32.c (_wsa_errlist): Use braces for struct initializers.
2268
2269 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2270 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2271 All callers changed.
2272 (string_buffer_position): Likewise. Also, make static (it's never
2273 used outside xdisp.c).
2274 (cursor_row_p): Remove parameter `w', unused since
2275 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2276 (decode_mode_spec): Remove parameter `precision', introduced during
2277 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2278 All callers changed.
2279
5ffb62aa
JD
22802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2281
2282 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2283
461c2ab9 22842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2285
2286 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2287 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2288 (ns_update_auto_hide_menu_bar): New functions.
2289 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2290 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2291 ns_constrain_all_frames.
2292 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2293 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2294
5c380ffb
JD
22952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2296
2297 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2298
9af30bdf
GM
22992011-03-27 Glenn Morris <rgm@gnu.org>
2300
2301 * syssignal.h: Replace RETSIGTYPE with void.
2302 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2303 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2304 Replace SIGTYPE with void everywhere.
2305 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2306 * s/template.h (SIGTYPE): Remove commented out definition.
2307
e2abce01
JB
23082011-03-26 Eli Zaretskii <eliz@gnu.org>
2309
2310 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2311 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2312
f868cd8a
JB
23132011-03-26 Juanma Barranquero <lekktu@gmail.com>
2314
59eb0929
JB
2315 * w32.c (read_unc_volume): Use parameter `henum', instead of
2316 global variable `wget_enum_handle'.
2317
2318 * keymap.c (describe_vector): Remove parameters `indices' and
2319 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2320 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2321
f868cd8a
JB
2322 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2323
2324 * keyboard.c (timer_check): Remove parameter `do_it_now',
2325 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2326 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2327 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2328
2329 * keyboard.c (read_char):
2330 * w32menu.c (w32_menu_display_help):
2331 * xmenu.c (show_help_event, menu_help_callback):
2332 Adjust calls to `show_help_echo'.
2333
2334 * gtkutil.c (xg_maybe_add_timer):
2335 * keyboard.c (readable_events):
2336 * process.c (wait_reading_process_output):
2337 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2338
2339 * insdel.c (adjust_markers_gap_motion):
2340 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2341 (gap_left, gap_right): Don't call it.
2342
2ecf6fdb
CY
23432011-03-25 Chong Yidong <cyd@stupidchicken.com>
2344
2345 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2346 incurred during fontification.
2347
6b1f9ba4
JB
23482011-03-25 Juanma Barranquero <lekktu@gmail.com>
2349
2350 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2351 (DEFVAR_PER_BUFFER): Don't pass it.
2352
2353 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2354 (scrolling_window): Don't pass it.
2355
0f4a96b5
JB
23562011-03-25 Juanma Barranquero <lekktu@gmail.com>
2357
2358 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2359
2360 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2361 and `suffix'.
2362 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2363 of variables specific to SELinux and computation of `encoded_absname'.
2364
2365 * image.c (XPutPixel): Remove unused variable `height'.
2366
2367 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2368
2369 * unexw32.c (get_section_info): Remove unused variable `section'.
2370
2371 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2372 (system_process_attributes): Remove unused variable `sess'.
2373 (sys_read): Remove unused variable `err'.
2374
2375 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2376 (w32_wnd_proc): Remove unused variable `isdead'.
2377 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2378 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2379 (x_create_tip_frame): Remove unused variable `tem'.
2380
2381 * w32inevt.c (w32_console_read_socket):
2382 Remove unused variable `no_events'.
2383
2384 * w32term.c (x_draw_composite_glyph_string_foreground):
2385 Remove unused variable `width'.
2386
1149507c
JB
23872011-03-24 Juanma Barranquero <lekktu@gmail.com>
2388
2389 * w32term.c (x_set_glyph_string_clipping):
2390 Don't pass uninitialized region to CombineRgn.
2391
9c88f339
JB
23922011-03-23 Juanma Barranquero <lekktu@gmail.com>
2393
2394 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2395 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2396 (Fx_close_connection): Remove unused variable `i'.
2397
2398 * w32font.c (w32font_draw): Return number of glyphs.
2399 (w32font_open_internal): Remove unused variable `i'.
2400 (w32font_driver): Add missing initializer.
2401
2402 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2403 (fill_in_menu): Remove unused variable `items_added'.
2404
2405 * w32term.c (last_mouse_press_frame): Remove static global variable.
2406 (w32_clip_to_row): Remove unused variable `f'.
2407 (x_delete_terminal): Remove unused variable `i'.
2408
2409 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2410 (NOTHING): Remove unused static global variable.
2411 (uniscribe_check_otf): Remove unused variable `table'.
2412 (uniscribe_font_driver): Add missing initializers.
2413
dee091a3
JD
24142011-03-23 Julien Danjou <julien@danjou.info>
2415
2416 * term.c (Fsuspend_tty, Fresume_tty):
2417 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2418 * window.c (temp_output_buffer_show):
2419 * insdel.c (signal_before_change):
2420 * frame.c (Fhandle_switch_frame):
2421 * fileio.c (Fdo_auto_save):
2422 * emacs.c (Fkill_emacs):
2423 * editfns.c (save_excursion_restore):
2424 * cmds.c (internal_self_insert):
2425 * callint.c (Fcall_interactively):
2426 * buffer.c (Fkill_all_local_variables):
2427 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2428 Use Frun_hooks.
0f4a96b5 2429 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2430 unconditionnaly since it does the check itself.
2431
2c520ab5 24322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2433
c9c49752
PE
2434 Fix more problems found by GCC 4.5.2's static checks.
2435
8abc3f12
PE
2436 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2437 the first time through the loop, since we know p0 < p1 then.
2438 This also avoids a gcc -Wstrict-overflow warning.
2439
a2d26660
PE
2440 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2441 leading to a memory leak, possible in functions like
2442 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2443 of objects (Bug#8318).
a2d26660 2444
916c72e9
PE
2445 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2446 that could (at least in theory) be that large.
2447
19ab8a18
PE
2448 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2449 This is less likely to overflow, and avoids undefined behavior if
2450 overflow does occur. All callers changed. Use strtoul to scan
2451 for the unsigned long integer.
b7cbbd6f
PE
2452 (pint2hrstr): Simplify and tune code slightly.
2453 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2454
f0641eff
PE
2455 * scroll.c (do_scrolling): Work around GCC bug 48228.
2456 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2457
7f650bb9
PE
2458 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2459 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2460 (validate_x_resource_name): Simplify count usage.
2461 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2462
37dd57d1
PE
2463 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2464 fail (Bug#8306).
81e56e61 2465
699979fc 2466 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2467
401bf9b4
PE
2468 * process.c (Fmake_network_process): Use socklen_t, not int,
2469 where POSIX says socklen_t is required in portable programs.
2470 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2471 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2472 (Fmake_network_process, server_accept_connection):
2473 (wait_reading_process_output, read_process_output):
2474 Likewise.
2475
b93aacde
PE
2476 * process.c: Rename or move locals to avoid shadowing.
2477 (list_processes_1, Fmake_network_process):
2478 (read_process_output_error_handler, exec_sentinel_error_handler):
2479 Rename or move locals.
4dc343ee 2480 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2481 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2482 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2483 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2484 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2485
af8a867c 2486 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2487 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2488 Include tparam.h instead, since it declares them.
af8a867c
PE
2489 * cm.h (PC): Remove extern decl; tparam.h now does this.
2490 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2491 * terminfo.c: Include tparam.h, to check interfaces.
2492 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2493 (tparam): Adjust signature to match interface in tparam.h;
2494 this removes some undefined behavior. Check that outstring and len
2495 are zero, which they always are with Emacs.
2496 * tparam.h (PC, BC, UP): New extern decls.
2497
0248044d 2498 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2499 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2500
8ff096c1 2501 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2502 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2503 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2504 (ftfont_list): Remove unused local.
49eaafba
PE
2505 (get_adstyle_property, ftfont_pattern_entity):
2506 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2507 Rename locals to avoid shadowing.
8ff096c1 2508
e2be39f6
PE
2509 * xfont.c (xfont_list_family): Mark var as initialized.
2510
c9735e30
PE
2511 * xml.c (make_dom): Now static.
2512
8f5201ae
PE
2513 * composite.c (composition_compute_stop_pos): Rename local to
2514 avoid shadowing.
b246f932
PE
2515 (composition_reseat_it): Remove unused locals.
2516 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2517 (composition_update_it): Mark var as initialized.
11b61122
PE
2518 (find_automatic_composition): Mark vars as initialized,
2519 with a FIXME (Bug#8290).
8f5201ae 2520
760fbc2c
PE
2521 character.h: Rename locals to avoid shadowing.
2522 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2523 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2524 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2525 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2526 to avoid shadowing.
2527
ff08eb85
PE
2528 * textprop.c (property_change_between_p): Remove; unused.
2529
fc7bf025
PE
2530 * intervals.c (interval_start_pos): Now static.
2531
235d7abc
PE
2532 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2533
44f230aa
SM
2534 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2535 Rename locals to avoid shadowing.
3e7d6594 2536
50060332
PE
2537 * sound.c (wav_play, au_play, Fplay_sound_internal):
2538 Fix pointer signedness.
d01f234b 2539 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2540 (wav_play): Initialize a variable to 0, to prevent undefined
2541 behavior (Bug#8278).
50060332 2542
c4fc4e30
PE
2543 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2544
918436ed
PE
2545 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2546
c939f91b
PE
2547 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2548 clobbering (Bug#8298).
b9c7f648
PE
2549 * sysdep.c (sys_subshell): Likewise.
2550 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2551
6bd8c144
PE
2552 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2553 This should get cleaned up, so that child_setup has the
2554 same signature on all platforms.
2555
7710357c 2556 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2557 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2558
c59da222
CY
25592011-03-22 Chong Yidong <cyd@stupidchicken.com>
2560
2561 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2562 not to be necessary, and produces flickering.
2563
66b87493
GM
25642011-03-20 Glenn Morris <rgm@gnu.org>
2565
2566 * config.in: Remove file.
2567
45b6f6d5
JB
25682011-03-20 Juanma Barranquero <lekktu@gmail.com>
2569
2570 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2571 are now in src/globals.h.
2572 (syms_of_minibuf): Remove spurious & from previous change.
2573
3ec03f7e
LL
25742011-03-20 Leo <sdl.web@gmail.com>
2575
2576 * minibuf.c (completing-read-function): New variable.
2577 (completing-read-default): Rename from completing-read.
2578 (completing-read): Call completing-read-function.
2579
b14e3e21
CY
25802011-03-19 Juanma Barranquero <lekktu@gmail.com>
2581
2582 * xfaces.c (Fx_load_color_file):
2583 Read color file from absolute filename (bug#8250).
2584
f2b726e6
JB
25852011-03-19 Juanma Barranquero <lekktu@gmail.com>
2586
2587 * makefile.w32-in: Update dependencies.
2588
09f6ff02
EZ
25892011-03-17 Eli Zaretskii <eliz@gnu.org>
2590
2591 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2592
29a6015a
PE
25932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2594
a3a6c54e
PE
2595 Fix more problems found by GCC 4.5.2's static checks.
2596
b766f867
PE
2597 * process.c (make_serial_process_unwind, send_process_trap):
2598 (sigchld_handler): Now static.
2599
be02381c
PE
2600 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2601 That way, the code declares only the vars that it needs.
2602 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2603 * s/cygwin.h (PTY_ITERATION): Likewise.
2604 * s/darwin.h (PTY_ITERATION): Likewise.
2605 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2606
57048744
PE
2607 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2608 * process.c (allocate_pty): Don't declare stb unless it's needed.
2609
7914961c 2610 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2611 (CONSTANTLIM): Remove; unused.
2612 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2613 Define only if needed.
7914961c 2614
b3967b18
PE
2615 * unexelf.c (unexec): Name an expression,
2616 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2617 Use a different way to cause a compilation error if anyone uses
2618 n rather than nn, a way that does not involve shadowing.
73366a00 2619 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2620
29a6015a
PE
2621 * deps.mk (unexalpha.o): Remove; unused.
2622
43cfc33e 2623 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2624 * unexec.h: New file.
ce701a33
PE
2625 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2626 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2627 Depend on unexec.h.
2628 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2629 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2630 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2631 Change as necessary to match prototype in unexec.h.
ce701a33 2632
01f44d5a
PE
2633 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2634 shadowing.
4f63c6bb 2635 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2636
a6670b0b
PE
2637 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2638 Rename locals to avoid shadowing.
2639
cef2010d 2640 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2641 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2642
d4d7173a
PE
2643 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2644
f08b802a
PE
2645 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2646 warning when compiling print.c.
2647
3ddb0639
PE
2648 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2649 instead of using an uninitialized var.
5ad03b97 2650 (font_sort_entities): Mark var as initialized.
3ddb0639 2651
170a2692
PE
2652 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2653
e663c700
PE
2654 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2655 pointers to constants.
89bc529a 2656 (font_parse_fcname): Remove unused vars.
7b81e2d0 2657 (font_delete_unmatched): Now static.
ea838e10 2658 (font_get_spec): Remove; unused.
13a547c6
PE
2659 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2660 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2661 Rename or move locals to avoid shadowing.
e663c700 2662
2a80c887 2663 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2664 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2665
1384fa33 2666 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2667 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2668
8b2c52e9
PE
2669 * alloc.c (mark_backtrace): Move decl from here ...
2670 * lisp.h: ... to here, so that it can be checked.
2671
475545b5 2672 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2673 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2674 (lisp_indirect_variable): Name an expression,
2675 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2676 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2677
b1349114 2678 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2679 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2680 Use const pointer when appropriate.
b1349114 2681
a2928364
PE
2682 * lisp.h (get_system_name, get_operating_system_release):
2683 Move decls here, to check interfaces.
2684 * process.c (get_operating_system_release): Move decl to lisp.h.
2685 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2686 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2687 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2688 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2689 (Fformat_time_string, Fencode_time, Finsert_char):
2690 (Ftranslate_region_internal, Fformat):
2691 Rename or remove local vars to avoid shadowing.
9710023e 2692 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2693
a415e694
PE
2694 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2695 avoid shadowing.
2696
8ef4622d
PE
2697 * lisp.h (eassert): Check that the argument compiles, even if
2698 ENABLE_CHECKING is not defined.
2699
946f9a5b
PE
2700 * data.c (Findirect_variable): Name an expression, to avoid
2701 gcc -Wbad-function-cast warning.
112396d6 2702 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2703 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2704 (Fmake_variable_buffer_local, Fmake_local_variable):
2705 Mark variables as initialized.
52746918 2706 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2707
e5aab7e7 2708 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2709 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2710 Rename locals to avoid shadowing.
dff45157
PE
2711 (mark_stack): Move local variables into the #ifdef region where
2712 they're used.
7bc26fdb
PE
2713 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2714 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2715 needed otherwise.
2716 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2717 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2718 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2719
e5aab7e7
PE
2720 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2721 avoids undefined behavior in theory.
2722
4da60324
PE
2723 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2724
88043301
PE
2725 Use functions, not macros, for up- and down-casing (Bug#8254).
2726 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2727 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2728 to use the following functions instead of these macros.
2729 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2730 EMACS_INT, since callers assume the returned value fits in int.
2731 (upcase1): Likewise, for UPCASE_TABLE.
2732 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2733 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2734 the race-condition problem in the old DOWNCASE.
88043301 2735
19ed5445
PE
2736 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2737 Rename locals to avoid shadowing.
2738 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2739 (regex_compile, re_search_2, re_match_2_internal):
2740 Remove unused local vars.
952db0d7
PE
2741 (FREE_VAR): Rewrite so as not to use empty "else",
2742 which gcc can warn about.
da053e48 2743 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2744 (RETALLOC_IF): Define only if needed.
2745 (WORDCHAR_P): Likewise. This one is never needed, but is used
2746 only in a comment talking about a compiler bug, so put inside
2747 the #if 0 of that comment.
2748 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2749 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2750 Remove; unused.
19ed5445 2751
1f3561e4 2752 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2753 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2754 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2755
ded6f8f7
PE
2756 * search.c (simple_search): Remove unused var.
2757
dbd37a95
PE
2758 * dired.c (compile_pattern): Move decl from here ...
2759 * lisp.h: ... to here, so that it can be checked.
2760 (struct re_registers): New forward decl.
2761
7e47afad
PE
2762 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2763
85f24f61
PE
2764 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2765 All uses changed.
2766 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2767 Rename locals to avoid shadowing.
5671df8f 2768 (Fvertical_motion): Mark locals as initialized.
85f24f61 2769
181aa2be 2770 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2771 (casify_region): Mark local as initialized.
181aa2be 2772
930d429c
PE
2773 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2774
7082eac6
PE
2775 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2776 New macros, so that the caller can use some names other than
2777 gcpro1, gcpro2, etc.
2778 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2779 of the new macros.
2780 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2781 argument, for consistency with GCPRO2_VAR, etc: it is now the
2782 prefix of the variable, not the variable itself. All uses
2783 changed.
38b2c076
PE
2784 * dired.c (directory_files_internal, file_name_completion):
2785 Rename locals to avoid shadowing.
2786
15206ed9
PE
2787 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2788 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2789 dired.c's scmp function, had undefined behavior.
2790 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2791 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2792 * buffer.h: ... to here, because these macros use current_buffer,
2793 and the new implementation with inline functions needs to have
2794 current_buffer in scope now, rather than later when the macros
2795 are used.
2796 (downcase, upcase1): New static inline functions.
2797 (DOWNCASE, UPCASE1): Reimplement using these functions.
2798 This avoids undefined behavior in expressions like
2799 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2800 from race conditions in accessing the global variables
2801 case_temp1 and case_temp2.
2802 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2803 * lisp.h (case_temp1, case_temp2): Remove their decls.
2804 * character.h (ASCII_CHAR_P): Move from here ...
2805 * lisp.h: ... to here, so that the inline functions mentioned
2806 above can use them.
2807
4a6bea26
PE
2808 * dired.c (directory_files_internal_unwind): Now static.
2809
f14b7e14
PE
2810 * fileio.c (file_name_as_directory, directory_file_name):
2811 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2812 Now static.
2893f146
PE
2813 (file_name_as_directory): Use const pointers when appropriate.
2814 (Fexpand_file_name): Likewise. In particular, newdir might
2815 point at constant storage, so make it a const pointer.
fd4ead52 2816 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2817 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2818 signedness issues.
f839df0c
PE
2819 (Fset_file_times, Finsert_file_contents, auto_save_error):
2820 Rename locals to avoid shadowing.
f14b7e14 2821
5716756e 2822 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2823 (Ftry_completion, Fall_completions): Rename or remove locals
2824 to avoid shadowing.
5716756e 2825
b4c3046a
PE
2826 * marker.c (bytepos_to_charpos): Remove; unused.
2827
b45db522
PE
2828 * lisp.h (verify_bytepos, count_markers): New decls,
2829 so that gcc does not warn that these functions aren't declared.
2830
85876d07
PE
2831 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2832 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2833 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2834 (copy_text): Remove unused local var.
85876d07 2835
03d78a21 2836 * filelock.c (within_one_second): Now static.
b3dd38ab 2837 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2838
5df8f01b
PE
2839 * buffer.c (fix_overlays_before): Mark locals as initialized.
2840 (fix_start_end_in_overlays): Likewise. This function should be
2841 simplified by using pointers-to-pointers, but that's a different
2842 matter.
b1d876f1 2843 (switch_to_buffer_1): Now static.
8f54f30a
PE
2844 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2845 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2846
a70072c9 2847 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2848 Fix pointer signedness issue.
edced198
PE
2849 (sys_subshell): Mark local as volatile if checking for lint,
2850 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2851 (MAXPATHLEN): Define only if needed.
a70072c9 2852
a0977c44
PE
2853 * process.c (serial_open, serial_configure): Move decls from here ...
2854 * systty.h: ... to here, so that they can be checked.
2855
a884fdcc
PE
2856 * fns.c (get_random, seed_random): Move extern decls from here ...
2857 * lisp.h: ... to here, so that they can be checked.
2858
604efe86 2859 * sysdep.c (reset_io): Now static.
b8950c94 2860 (wait_for_termination_signal): Remove; unused.
604efe86 2861
38fc62d9
PE
2862 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2863 (copy_keymap_item, append_key, push_text_char_description):
2864 Now static.
1004a21a 2865 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2866 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2867 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2868 (describe_map_tree):
2869 Rename locals to avoid shadowing.
38fc62d9 2870
2f2650da
PE
2871 * keyboard.c: Declare functions static if they are not used elsewhere.
2872 (echo_char, echo_dash, cmd_error, top_level_2):
2873 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2874 (read_char, kbd_buffer_get_event, make_lispy_position):
2875 (make_lispy_event, make_lispy_movement, apply_modifiers):
2876 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2877 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2878 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2879 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2880 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2881
a053e86c 2882 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2883 (mark_kboards): Move decl here ...
2884 * alloc.c (mark_kboards): ... from here.
a053e86c 2885
4752793e
PE
2886 * lisp.h (force_auto_save_soon): New decl.
2887
74f10ca7 2888 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2889 (DEFINE_DUMMY_FUNCTION): New macro.
2890 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2891 Use it.
c03cd23f
PE
2892 (main): Add casts to avoid warnings
2893 if GCC considers string literals to be constants.
74f10ca7 2894
022e70d4
PE
2895 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2896
59d6fe83
PE
2897 * dbusbind.c: Pointer signedness fixes.
2898 (xd_signature, xd_append_arg, xd_initialize):
2899 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2900 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2901 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2902 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2903
78320123
PE
2904 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2905 if GCC considers string literals to be constants.
49cebcca 2906 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2907
35ac2a97
SM
29082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2909
fb103ca9
SM
2910 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2911 (print_preprocess, print_object): New macro to fix last change.
2912
35ac2a97
SM
2913 * print.c (print_preprocess): Don't forget font objects.
2914
62973b41
JB
29152011-03-16 Juanma Barranquero <lekktu@gmail.com>
2916
2917 * emacs.c (USAGE3): Doc fixes.
2918
0e48bb22
AS
29192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2920
2921 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2922 structure.
2923
7684e57b
JB
29242011-03-14 Juanma Barranquero <lekktu@gmail.com>
2925
2926 * lisp.h (VWindow_system, Qfile_name_history):
2927 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2928 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2929 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2930
2931 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2932 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2933
2934 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2935 * w32console.c (detect_input_pending, read_input_pending)
2936 (encode_terminal_code):
2937 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2938 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2939 (w32_system_caret_y, Qfile_name_history):
2940 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2941 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2942 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2943 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2944 * w32proc.c (Qlocal, report_file_error):
2945 * w32term.c (Vwindow_system, updating_frame):
2946 * w32uniscribe.c (initialized, uniscribe_font_driver):
2947 Remove unneeded extern declarations.
2948
2aa46d6c
CY
29492011-03-14 Chong Yidong <cyd@stupidchicken.com>
2950
c96bbc66 2951 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2952
cffc6f3b
CY
29532011-03-13 Chong Yidong <cyd@stupidchicken.com>
2954
2955 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2956 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2957 These macros can no longer be used for assignment.
2958
44f230aa
SM
2959 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2960 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2961 (record_buffer_markers, fetch_buffer_markers): New functions for
2962 recording and fetching special buffer markers.
2963 (set_buffer_internal_1, set_buffer_temp): Use them.
2964
2965 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2966
2967 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2968
2969 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2970 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2971
2972 * xdisp.c (hscroll_window_tree):
2973 (reconsider_clip_changes): Use PT instead of BUF_PT.
2974
d251f04b
EZ
29752011-03-13 Eli Zaretskii <eliz@gnu.org>
2976
2977 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2978 $(EMACS_ROOT)/lib/intprops.h.
2979
f0c77cd1
PE
29802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2981
3eca4629
PE
2982 Fix more problems found by GCC 4.5.2's static checks.
2983
7c86ee98
PE
2984 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2985 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2986 (xg_free_frame_widgets): Make it clear that a local variable is
2987 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2988 (gdk_window_get_screen): Make it clear that this macro is needed
2989 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2990 (int_gtk_range_get_value): New function, which avoids a diagnostic
2991 from gcc -Wbad-function-cast.
2992 (xg_set_toolkit_scroll_bar_thumb): Use it.
2993 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2994 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2995 (get_utf8_string, xg_get_file_with_chooser):
2996 Rename locals to avoid shadowing.
2997 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2998
41729b81
PE
2999 * xgselect.c (xg_select): Remove unused var.
3000
f0c77cd1
PE
3001 * image.c (four_corners_best): Mark locals as initialized.
3002 (gif_load): Initialize transparent_p to zero (Bug#8238).
3003 Mark another local as initialized.
ec6cf4c6 3004 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3005
ce0ad53d 3006 * image.c (clear_image_cache): Now static.
d5d5a617 3007 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3008 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3009 (x_edge_detection): Remove unnecessary cast that
3010 gcc -Wbad-function-cast diagnoses.
2037898d 3011 (gif_load): Fix pointer signedness.
6ae141d6
PE
3012 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3013 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3014
33383987 30152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3016
d32df629
PE
3017 Improve quality of tests for time stamp overflow.
3018 For example, without this patch (encode-time 0 0 0 1 1
3019 1152921504606846976) returns the obviously-bogus value (-948597
3020 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3021 reports time overflow. See
3022 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3023 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3024 * editfns.c: Include limits.h and intprops.h.
3025 (TIME_T_MIN, TIME_T_MAX): New macros.
3026 (time_overflow): Move earlier, to before first use.
3027 (hi_time, lo_time): New functions, for an accurate test for
3028 out-of-range times.
3029 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3030 (Fget_internal_run_time): Don't assume time_t fits in int.
3031 (make_time): Use list2 instead of Fcons twice.
3032 (Fdecode_time): More accurate test for out-of-range times.
3033 (check_tm_member): New function.
3034 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3035 (lisp_time_argument): Don't rely on undefined left-shift and
3036 right-shift behavior when checking for time stamp overflow.
8be6f318 3037
fe31d94c
PE
3038 * editfns.c (time_overflow): New function, refactoring common code.
3039 (Fformat_time_string, Fdecode_time, Fencode_time):
3040 (Fcurrent_time_string): Use it.
3041
8be6f318
PE
3042 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3043 * dired.c (make_time): Move to ...
3044 * editfns.c (make_time): ... here.
3045 * systime.h: Note the move.
3046
09d9db2c 30472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3048
126bc0dc
YM
3049 * fringe.c (update_window_fringes): Remove unused variables.
3050
c47cbdfd
YM
3051 * unexmacosx.c (copy_data_segment): Also copy __got section.
3052 (Bug#8223)
3053
7ac80be9
EZ
30542011-03-12 Eli Zaretskii <eliz@gnu.org>
3055
c96bbc66 3056 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3057 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3058 Constify `char *' arguments and their references according to
3059 prototypes in tparam.h.
3060
ecb0f94d 3061 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3062
7ac80be9
EZ
3063 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3064 Adapt all references accordingly.
3065
3066 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3067
ef1fd07e
TT
30682011-03-11 Tom Tromey <tromey@redhat.com>
3069
3070 * buffer.c (syms_of_buffer): Remove obsolete comment.
3071
7ef4b50c
EZ
30722011-03-11 Eli Zaretskii <eliz@gnu.org>
3073
3074 * termhooks.h (encode_terminal_code): Declare prototype.
3075
3076 * msdos.c (encode_terminal_code): Don't declare prototype.
3077
3078 * term.c (encode_terminal_code): Now external again, used by
3079 w32console.c and msdos.c.
3080
44f230aa
SM
3081 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3082 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3083
4b1ec863 30842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3085
1714f52b 3086 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3087
4b1ec863
PE
3088 * fringe.c (update_window_fringes): Mark locals as initialized
3089 (Bug#8227).
3090 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3091
524c7aa6
PE
3092 * alloc.c (mark_fringe_data): Move decl from here ...
3093 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3094 to check its interface.
3095 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3096
a5c0af81 3097 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3098 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3099 (fontset_font): Mark local as initialized.
a9a06e0b 3100 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3101
b4716021
PE
3102 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3103
811e9bac 3104 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3105 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3106 (x_own_selection, Fx_disown_selection_internal): Rename locals
3107 to avoid shadowing.
3108 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3109
7e3ab302
PE
3110 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3111 so that the caller can use some name other than gcpro1.
3112 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3113 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3114 (Fx_backspace_delete_keys_p):
3115 Use them to avoid shadowing, and rename vars to avoid shadowing.
3116 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3117 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3118 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3119 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3120 Remove unused locals.
7e3ab302
PE
3121 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3122 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3123 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3124 macros.
f78faa98 3125
e2b13473
PE
3126 * xterm.h (x_mouse_leave): New decl.
3127
77f23912
PE
3128 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3129 Remove unused functions.
cdf4ba58
PE
3130 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3131 (x_calc_absolute_position): Now static.
7411c686 3132 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3133 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3134 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3135 unless they are used.
38d0b34a
PE
3136 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3137 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3138 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3139 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3140 (x_error_catcher, x_connection_closed, x_error_handler):
3141 (x_error_quitter, xembed_send_message, x_iconify_frame):
3142 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3143 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3144 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3145
44f230aa
SM
3146 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3147 Rename or move locals to avoid shadowing.
6b463e58 3148 (tty_defined_color, merge_face_heights): Now static.
5967d051 3149 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3150 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3151 does not deduce is never used uninitialized.
73719eba
PE
3152 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3153 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3154
426994c3 3155 * terminal.c (store_terminal_param): Now static.
5489860b 3156
032f1620 3157 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3158 (set_frame_menubar): Remove unused local.
d4323972 3159 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3160 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3161 since they might point to immutable storage.
281585b0
PE
3162 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3163 since it's unused otherwise.
032f1620 3164
367c19e5 3165 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3166 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3167 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3168 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3169 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3170 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3171 does not deduce are never used uninitialized.
70739cbe 3172
07b48fa9
PE
3173 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3174
8868a238 3175 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3176 * window.c (window_loop, size_window):
3177 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3178
7e5cf297 3179 * window.c (display_buffer): Now static.
d6550a9f
PE
3180 (size_window): Mark variables that gcc -Wuninitialized
3181 does not deduce are never used uninitialized.
a586633d
PE
3182 * window.h (check_all_windows): New decl, to forestall
3183 gcc -Wmissing-prototypes diagnostic.
5b555da1 3184 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3185
f6095868
PE
3186 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3187 shadowing.
3188 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3189 Include <limits.h>.
3190 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3191 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3192 (load_charset_map): Mark variables that gcc -Wuninitialized
3193 does not deduce are never used uninitialized.
53df7c11 3194 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3195
f38b440c
PE
3196 * coding.c (coding_set_source, coding_set_destination):
3197 Use "else { /* comment */ }" rather than "else /* comment */;"
3198 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3199 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3200 a block, when the outer 'i' will do.
3201 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3202 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3203 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3204 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3205 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3206 Rename locals to avoid shadowing.
3207 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3208 * coding.c (emacs_mule_char, encode_invocation_designation):
3209 Now static, since they're not used elsewhere.
413bb2db 3210 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3211 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3212 (decode_coding_emacs_mule): Mark variables that gcc
3213 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3214 (detect_coding_iso_2022): Initialize a local variable that might
3215 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3216 this initialization is needed. (Bug#8211)
5f58e762
PE
3217 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3218 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3219 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3220 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3221 Remove unused macros.
f38b440c 3222
232b38b9 3223 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3224 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3225 * character.c (string_count_byte8): Likewise.
232b38b9 3226
fb90da1b
PE
3227 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3228 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3229
fb93dbc2
PE
3230 * chartab.c (copy_sub_char_table): Now static, since it's not used
3231 elsewhere.
5c156ace
PE
3232 (sub_char_table_ref_and_range, char_table_ref_and_range):
3233 Rename locals to avoid shadowing.
bbcd0949 3234 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3235
7d3b3862 3236 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3237 (BIDI_BOB): Remove unused macro.
7d3b3862 3238
6be7d3da
PE
3239 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3240 deduce are never used uninitialized.
c2ed9c8b 3241 * term.c (encode_terminal_code): Likewise.
6be7d3da 3242
75f8807f 3243 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3244
50938595
PE
3245 * tparam.h: New file.
3246 * term.c, tparam.h: Include it.
3247 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3248 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3249 Move these decls to tparam.h, and make them agree with what
3250 is actually in tparam.c. The previous trick of using incompatible
3251 decls in different modules does not conform to the C standard.
3252 All callers of tparam changed to use tparam's actual API.
3253 * tparam.c (tparam1, tparam, tgoto):
3254 Use const pointers where appropriate.
3255
fbceeba2
PE
3256 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3257 * cm.h (struct cm): Likewise.
3258 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3259 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3260 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3261 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3262 (turn_on_face, init_tty): Likewise.
3263 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3264
7f3f1250
PE
3265 * term.c (term_mouse_position): Rename local to avoid shadowing.
3266
e6ca6543
PE
3267 * alloc.c (mark_ttys): Move decl from here ...
3268 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3269
c40f8d15
AS
32702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3271
3272 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3273
cfe0661d
JB
32742011-03-09 Juanma Barranquero <lekktu@gmail.com>
3275
3276 * search.c (compile_pattern_1): Remove argument regp, unused since
3277 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3278 (compile_pattern): Don't pass it.
3279
0afb4571
J
32802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3281
3282 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3283 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3284 for ! HAVE_GTK3.
3285 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3286
3287 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3288
3289 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3290 gdk_window_get_screen, gdk_window_get_geometry,
3291 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3292 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3293 (xg_get_pixbuf_from_pixmap): New function.
3294 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3295 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3296 Call xg_get_pixbuf_from_pixmap instead of
3297 gdk_pixbuf_get_from_drawable.
3298 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3299 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3300 (xg_check_special_colors): Use GtkStyleContext and its functions
3301 for HAVE_GTK3.
3302 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3303 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3304 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3305 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3306 Call gtk_widget_get_preferred_size.
0afb4571
J
3307 (xg_frame_resized): gdk_window_get_geometry only takes 5
3308 parameters.
44f230aa
SM
3309 (xg_win_to_widget, xg_event_is_for_menubar):
3310 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3311 (xg_set_widget_bg): New function.
3312 (delete_cb): New function.
895009e1 3313 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3314 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3315 (xg_set_background_color): Call xg_set_widget_bg.
3316 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3317 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3318 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3319 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3320 if ! HAVE_GTK3.
3321 (update_frame_tool_bar): Call gtk_widget_hide.
3322 (xg_initialize): Use GDK_KEY_g.
3323
3324 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3325 if ! HAVE_GTK3
3326 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3327
3328 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3329 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3330 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3331
1c2cc4ef
JB
33322011-03-08 Juanma Barranquero <lekktu@gmail.com>
3333
3334 * w32xfns.c (select_palette): Check success of RealizePalette against
3335 GDI_ERROR, not zero.
3336
33383987 3337See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3338
3339;; Local Variables:
3340;; coding: utf-8
aac0c6e3
MR
3341;; End:
3342
33383987 3343 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3344
3345 This file is part of GNU Emacs.
3346
3347 GNU Emacs is free software: you can redistribute it and/or modify
3348 it under the terms of the GNU General Public License as published by
3349 the Free Software Foundation, either version 3 of the License, or
3350 (at your option) any later version.
3351
3352 GNU Emacs is distributed in the hope that it will be useful,
3353 but WITHOUT ANY WARRANTY; without even the implied warranty of
3354 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3355 GNU General Public License for more details.
3356
3357 You should have received a copy of the GNU General Public License
3358 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.