Implement dynamic loading of GnuTLS on Windows.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0898ca10
JB
12011-05-04 Juanma Barranquero <lekktu@gmail.com>
2
3 Implement dynamic loading of GnuTLS on Windows.
4
5 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8 Declare.
9
10 * gnutls.c (Qgnutls_dll): Define.
11 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12 (gnutls_*): Declare function pointers.
13 (init_gnutls_functions): New function to initialize function pointers.
14 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
16 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
17 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
18 (emacs_gnutls_write, emacs_gnutls_read)
19 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
20 (Fgnutls_available_p): New function.
21 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
22 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
23 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
24
25 * image.c: Include w32.h.
26 (Vimage_type_cache): Delete.
27 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
28 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
29 (w32_delayed_load): Move to w32.c.
30
31 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
32
33 * w32.c (QCloaded_from, Vlibrary_cache): Define.
34 (w32_delayed_load): Move from image.c. When loading a library, record
35 its filename in the :loaded-from property of the library id.
36 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
37 Initialize and staticpro them.
38 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
39
40 * process.c: Include lisp.h before w32.h, not after.
41 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
42 instead of gnutls_record_check_pending.
43
44 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
45
ff4de4aa
TZ
462011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
47
48 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
49 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
50 as passed in.
51
abe95abb
JD
522011-05-03 Jan Djärv <jan.h.d@swipnet.se>
53
54 * xterm.c (x_set_frame_alpha): Do not set property on anything
55 else than FRAME_X_OUTER_WINDOW (Bug#8608).
56
e16e55d4
JB
572011-05-02 Juanma Barranquero <lekktu@gmail.com>
58
59 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
60
bafcf6a5
JB
612011-05-02 Juanma Barranquero <lekktu@gmail.com>
62
63 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
64 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
65 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
66 (gnutls_global_initialized, Qgnutls_bootprop_priority)
67 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
68 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
69 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
70 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
71 (Qgnutls_bootprop_callbacks_verify): Make static.
72
e7a6747f
AS
732011-05-01 Andreas Schwab <schwab@linux-m68k.org>
74
19ed11ba
AS
75 * callproc.c: Indentation fixup.
76
e7a6747f
AS
77 * sysdep.c (wait_for_termination_1): Make static.
78 (wait_for_termination, interruptible_wait_for_termination): Move
79 after wait_for_termination_1.
80
1ef14cb4
LMI
812011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
82
83 * sysdep.c (interruptible_wait_for_termination): New function
84 which is like wait_for_termination, but allows keyboard
85 interruptions.
86
87 * callproc.c (Fcall_process): Add (:file "file") as an option for
88 the STDOUT buffer.
89 (Fcall_process_region): Ditto.
90
330d880c
EZ
912011-04-30 Eli Zaretskii <eliz@gnu.org>
92
8db90b73
EZ
93 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
94 rather than `XVECTOR (FOO)->size'.
95
330d880c
EZ
96 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
97 inttypes.h, as a gnulib replacement is used if it not available in
98 system headers.
99
15cbd324
EZ
1002011-04-21 Eli Zaretskii <eliz@gnu.org>
101
102 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
103 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
104 of MOST_POSITIVE_FIXNUM. (Bug#8528)
105
106 * coding.c (coding_alloc_by_realloc): Error out if destination
107 will grow beyond MOST_POSITIVE_FIXNUM.
108 (decode_coding_emacs_mule): Abort if there isn't enough place in
109 charbuf for the composition carryover bytes. Reserve an extra
110 space for up to 2 characters produced in a loop.
111 (decode_coding_iso_2022): Abort if there isn't enough place in
112 charbuf for the composition carryover bytes.
113
1142011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 115
ae940cca
EZ
116 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
117 aborting when %lld or %lll format is passed.
118 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
119 %llo or %llx format is passed. (Bug#8545)
120
03ab8921
EZ
121 * window.c (window_scroll_line_based): Use a marker instead of
122 simple variables to record original value of point. (Bug#7952)
123
afda1437
EZ
124 * doprnt.c (doprnt): Fix the case where a multibyte sequence
125 produced by %s or %c overflows available buffer space. (Bug#8545)
126
f76dee0c
PE
1272011-04-28 Paul Eggert <eggert@cs.ucla.edu>
128
129 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 130 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 131
fdc5744d
JB
1322011-04-28 Juanma Barranquero <lekktu@gmail.com>
133
134 * w32.c (init_environment): Warn about defaulting HOME to C:\.
135
638f053a
JB
1362011-04-28 Juanma Barranquero <lekktu@gmail.com>
137
138 * keyboard.c (Qdelayed_warnings_hook): Define.
139 (command_loop_1): Run `delayed-warnings-hook'
140 if Vdelayed_warnings_list is non-nil.
141 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
142 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
143
d178f871
EZ
1442011-04-28 Eli Zaretskii <eliz@gnu.org>
145
146 * doprnt.c (doprnt): Don't return value smaller than the buffer
147 size if the message was truncated. (Bug#8545).
148
b124fd93
JB
1492011-04-28 Juanma Barranquero <lekktu@gmail.com>
150
151 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
152 (Fx_window_property): #if-0 the whole functions, not just the bodies.
153
e810457d
PE
1542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
155
156 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
157
ea51cceb
JB
1582011-04-27 Juanma Barranquero <lekktu@gmail.com>
159
160 * makefile.w32-in: Update dependencies.
161
94dcfacf
EZ
1622011-04-27 Eli Zaretskii <eliz@gnu.org>
163
164 Improve `doprnt' and its usage. (Bug#8545)
165 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
166 `format_end'. Remove support for %l as a conversion specifier.
167 Don't use xrealloc. Improve diagnostics when the %l size modifier
168 is used. Update the commentary.
169
170 * eval.c (verror): Simplify calculation of size_t.
171
172 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
173 messages.
174
f61f41d7
PE
1752011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
176
177 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
178 change.
179
96fb4434
PE
1802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
181
182 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
183 This makes this file independent of the recent pseudovector change.
184
671875da 1852011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 186
69e9b5a3
PE
187 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
188
b5f869a7 189 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 190 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 191 Remove unused local.
c8926152 192 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 193
841a1577 194 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
195 GCC 4.6.0 optimizes based on type-based alias analysis. For
196 example, if b is of type struct buffer * and v of type struct
197 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
198 != &v->size, and therefore "v->size = 1; b->size = 2; return
199 v->size;" must therefore return 1. This assumption is incorrect
200 for Emacs, since it type-puns struct Lisp_Vector * with many other
201 types. To fix this problem, this patch adds a new type struct
f904488f 202 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
203 and pseudovectors, and helps optimizing compilers not get fooled
204 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
205 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
206 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
207 the size member.
eab3844f
PE
208 (XSETPVECTYPE): Rewrite in terms of new macro.
209 (XSETPVECTYPESIZE): New macro, specifying both type and size.
210 This is a bit clearer, and further avoids the possibility of
211 undesirable aliasing.
212 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 213 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
214 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
215 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
216 (ASIZE): Now uses header.size rather than size. All
217 previous uses of XVECTOR (foo)->size replaced to use this macro,
218 to avoid the hassle of writing XVECTOR (foo)->header.size.
219 (struct vectorlike_header): New type.
eab3844f
PE
220 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
221 object, to help avoid aliasing.
222 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
223 (SUBRP): Likewise, since Lisp_Subr is a special case.
224 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
225 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
226 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 227 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
228 changed to be "header.size" and "header.next".
229 * buffer.h (struct buffer): Likewise.
230 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
231 * frame.h (struct frame): Likewise.
232 * process.h (struct Lisp_Process): Likewise.
233 * termhooks.h (struct terminal): Likewise.
234 * window.c (struct save_window_data, struct saved_window): Likewise.
235 * window.h (struct window): Likewise.
236 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
237 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
238 * buffer.c (init_buffer_once): Likewise.
239 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
240 special case.
241 * process.c (Fformat_network_address): Use local var for size,
242 for brevity.
243
0df1eac5
PE
244 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
245
847ab9d1 246 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
247 * data.c (atof): Remove decl; no longer used or needed.
248 (digit_to_number): Move to lread.c.
249 (Fstring_to_number): Use new string_to_number function, to be
250 consistent with how the Lisp reader treats infinities and NaNs.
251 Do not assume that floating-point numbers represent EMACS_INT
252 without losing information; this is not true on most 64-bit hosts.
253 Avoid double-rounding errors, by insisting on integers when
254 parsing non-base-10 numbers, as the documentation specifies.
255 * lisp.h (string_to_number): New decl, replacing ...
256 (isfloat_string): Remove.
bc0a5c13 257 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 258 (read1): Do not accept +. and -. as integers; this
452f4150
PE
259 appears to have been a coding error. Similarly, do not accept
260 strings like +-1e0 as floating point numbers. Do not report
261 overflow for integer overflows unless the base is not 10 which
262 means we have no simple and reliable way to continue.
263 Break out the floating-point parsing into a new
264 function string_to_number, so that Fstring_to_number parses
265 floating point numbers consistently with the Lisp reader.
266 (digit_to_number): Moved here from data.c. Make it static inline.
267 (E_CHAR, EXP_INT): Remove, replacing with ...
268 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
269 (string_to_number): New function, replacing isfloat_string.
270 This function checks for valid syntax and produces the resulting
271 Lisp float number too. Rework it so that string-to-number
bc0a5c13 272 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
273 so that overflow for non-base-10 numbers is reported only when
274 there's no portable and simple way to convert to floating point.
452f4150 275
67769ffc
PE
276 * textprop.c (set_text_properties_1): Rewrite for clarity,
277 and to avoid GCC warning about integer overflow.
278
c20db43f
PE
279 * intervals.h (struct interval): Use EMACS_INT for members
280 where EMACS_UINT might cause problems. See
281 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
282 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
283 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
284 All uses changed.
37aa2f85
PE
285 (offset_intervals): Tell GCC not to worry about length overflow
286 when negating a negative length.
c20db43f 287
2538aa2f
PE
288 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
289 (overrun_check_free): Likewise.
290
f2d3008d
PE
291 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
292 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
293 word size.
294
ec8df744
PE
295 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
296 (gnutls_make_error): Rename local to avoid shadowing.
297 (gnutls_emacs_global_deinit): ifdef out; not used.
298 (Fgnutls_boot): Use const for pointer to readonly storage.
299 Comment out unused local. Fix pointer signedness problems.
300
640ee02d
PE
301 * lread.c (openp): Don't stuff size_t into an 'int'.
302 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
303 about possible signed overflow.
304
6048fb2a
PE
305 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
306 (GDK_KEY_g): Don't define if already defined.
307 (xg_prepare_tooltip): Avoid pointer signedness problem.
308 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
309
fa3c87e1
PE
310 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
311 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
312
2172544b
PE
313 * xfns.c (Fx_window_property): Simplify a bit,
314 to make a bit faster and to avoid GCC 4.6.0 warning.
315 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
316
9b821a21
PE
317 * fns.c (internal_equal): Don't assume size_t fits in int.
318
3c616cfa
PE
319 * alloc.c (compact_small_strings): Tighten assertion a little.
320
c2982e87
PE
321 Replace pEd with more-general pI, and fix some printf arg casts.
322 * lisp.h (pI): New macro, generalizing old pEd macro to other
323 conversion specifiers. For example, use "...%"pI"d..." rather
324 than "...%"pEd"...".
325 (pEd): Remove. All uses replaced with similar uses of pI.
326 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
327 * alloc.c (check_pure_size): Don't overflow by converting size to int.
328 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
329 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
330 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
331 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
332 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
333 64-bit hosts.
334 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
335 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
336 * print.c (safe_debug_print, print_object): Likewise.
337 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
338 to int.
6f04d126
PE
339 Use pI instead of if-then-else-abort. Use %p to avoid casts,
340 avoiding the 0 flag, which is not portable.
c2982e87
PE
341 * process.c (Fmake_network_process): Use pI to avoid cast.
342 * region-cache.c (pp_cache): Likewise.
343 * xdisp.c (decode_mode_spec): Likewise.
344 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
345 behavior on 64-bit hosts with printf arg.
6f04d126 346 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
347 (x_stop_queuing_selection_requests): Likewise.
348 (x_get_window_property): Don't truncate byte count to an 'int'
349 when tracing.
0b432f21 350
5e073ec7
PE
351 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
352 here, since it parses constructs like leading '-' and spaces,
353 which are not wanted; and it overflows with large numbers.
354 Instead, simply match F[0-9]+, which is what is wanted anyway.
355
36372bf9
PE
356 * alloc.c: Remove unportable assumptions about struct layout.
357 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
358 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
359 (allocate_vectorlike, make_pure_vector): Use the new macros,
360 plus offsetof, to remove unportable assumptions about struct layout.
361 These assumptions hold on all porting targets that I know of, but
362 they are not guaranteed, they're easy to remove, and removing them
363 makes further changes easier.
364
0b432f21
PE
365 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
366 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
367 (string_overrun_cookie): Now const. Use initializers that
368 don't formally overflow signed char, to avoid warnings.
000098c1
PE
369 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
370 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
371 (allocate_buffer): Don't assume sizeof (struct buffer) is a
372 multiple of sizeof (EMACS_INT); it need not be, if
373 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 374 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 375
895009e1
JB
3762011-04-26 Juanma Barranquero <lekktu@gmail.com>
377
378 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
379
6a7a1b0b
TZ
3802011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
381
382 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 383 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
384 Reported by Paul Eggert <eggert@cs.ucla.edu>.
385
841a1577 3862011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
387
388 * lisp.h (Qdebug): List symbol.
895009e1 389 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
390 * keyboard.c (debug-on-event): New variable.
391 (handle_user_signal): Break into debugger when debug-on-event
392 matches the current signal symbol.
393
f2d3ba6f
DN
3942011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
395
396 * alloc.c (check_sblock, check_string_bytes)
397 (check_string_free_list): Convert to standard C.
398
42ce4c63
TZ
3992011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
400
401 * w32.c (emacs_gnutls_push): Fix typo.
402
825cd63c
EZ
4032011-04-25 Eli Zaretskii <eliz@gnu.org>
404
fb11d64d
EZ
405 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
406 "cast to pointer from integer of different size".
407
825cd63c
EZ
408 Improve doprnt and its use in verror. (Bug#8545)
409 * doprnt.c (doprnt): Document the set of format control sequences
410 supported by the function. Use SAFE_ALLOCA instead of always
411 using `alloca'.
412
413 * eval.c (verror): Don't limit the buffer size at size_max-1, that
414 is one byte too soon. Don't use xrealloc; instead xfree and
415 xmalloc anew.
416
e061a11b
TZ
4172011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
418
419 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
420 callbacks stage.
421
422 * gnutls.c: Renamed global_initialized to
423 gnutls_global_initialized. Added internals for the
424 :verify-hostname-error, :verify-error, and :verify-flags
425 parameters of `gnutls-boot' and documented those parameters in the
426 docstring. Start callback support.
427 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
428 unless a fatal error occured. Call gnutls_alert_send_appropriate
429 on error. Return error code.
430 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
431 (emacs_gnutls_read): Likewise.
432 (Fgnutls_boot): Return handshake error code.
433 (emacs_gnutls_handle_error): New function.
434 (wsaerror_to_errno): Likewise.
435
436 * w32.h (emacs_gnutls_pull): Add prototype.
437 (emacs_gnutls_push): Likewise.
438
439 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
440 (emacs_gnutls_push): Likewise.
441
4422011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
443
444 * process.c (wait_reading_process_output): Check if GnuTLS
445 buffered some data internally if no FDs are set for TLS
446 connections.
447
448 * makefile.w32-in (OBJ2): Add gnutls.$(O).
449 (LIBS): Link to USER_LIBS.
450 ($(BLD)/gnutls.$(0)): New target.
451
fa6996bc
EZ
4522011-04-24 Eli Zaretskii <eliz@gnu.org>
453
eb35682e
EZ
454 * xdisp.c (handle_single_display_spec): Rename the
455 display_replaced_before_p argument into display_replaced_p, to
456 make it consistent with the commentary. Fix typos in the
457 commentary.
458
e2ad650c
EZ
459 * textprop.c (syms_of_textprop): Remove dead code.
460 (copy_text_properties): Delete obsolete commentary about an
461 interface that was deleted long ago. Fix typos in the description
462 of arguments.
463
1b2de274
EZ
464 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
465 to changes in oldXMenu/XMenu.h from 2011-04-16.
466 <menu_help_message, prev_menu_help_message>: Constify.
467 (IT_menu_make_room): menu->help_text is now `const char **';
468 adjust.
469
470 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
471 to changes in oldXMenu/XMenu.h from 2011-04-16.
472 (struct XMenu): Declare `help_text' `const char **'.
473
474 * xfaces.c <Qunspecified>: Make extern again.
475
476 * syntax.c: Include sys/types.h before including regex.h, as
477 required by Posix.
478
762b15be
EZ
479 * doc.c (get_doc_string): Improve the format passed to `error'.
480
481 * doprnt.c (doprnt): Improve commentary.
482
483 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
484
485 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
486 them with etags.
487
f1052e5d
EZ
488 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
489 changes in globals.h immediately force recompilation.
762b15be
EZ
490 (TAGS): Depend on $(CURDIR)/m/intel386.h and
491 $(CURDIR)/s/ms-w32.h.
492 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 493
fa6996bc
EZ
494 * character.c (Fchar_direction): Function deleted.
495 (syms_of_character): Don't defsubr it.
496 <char-direction-table>: Deleted.
497
e6c3da20
EZ
4982011-04-23 Eli Zaretskii <eliz@gnu.org>
499
500 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
501 * doprnt.c: Include limits.h.
502 (SIZE_MAX): New macro.
503 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
504 local variables are now size_t instead of int or unsigned.
505 Improve overflow protection. Support `l' modifier for integer
506 conversions. Support %l conversion. Don't assume an EMACS_INT
507 argument for integer conversions and for %c.
508
509 * lisp.h (doprnt): Restore prototype.
510
511 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
512 $(SRC)/character.h.
513
514 * Makefile.in (base_obj): Add back doprnt.o.
515
516 * deps.mk (doprnt.o): Add back prerequisites.
517 (callint.o): Depend on character.h.
518
519 * eval.c (internal_lisp_condition_case): Include the handler
520 representation in the error message.
521 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
522 when breaking from the loop.
523
524 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
525
526 * callint.c (Fcall_interactively): When displaying error message
527 about invalid control letter, pass the character's codepoint, not
528 a pointer to its multibyte form. Improve display of the character
529 in octal and display also its hex code.
530
531 * character.c (char_string): Use %x to display the (unsigned)
532 codepoint of an invalid character, to avoid displaying a bogus
533 negative value.
534
535 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
536 `error', not SYMBOL_NAME itself.
537
538 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
539 character arguments to `error'.
540
541 * charset.c (check_iso_charset_parameter): Fix incorrect argument
542 to `error' in error message about FINAL_CHAR argument. Make sure
543 FINAL_CHAR is a character, and use %c when it is passed as
544 argument to `error'.
545
4ffd0d6b 5462011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
547
548 * s/ms-w32.h (localtime): Redirect to sys_localtime.
549
550 * w32.c: Include <time.h>.
551 (sys_localtime): New function.
552
4ffd0d6b 5532011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
554
555 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
556
4ffd0d6b 557 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 558
4ffd0d6b 5592011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 560
4ffd0d6b
GM
561 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
562 zombies (Bug#8467).
aac0c6e3 563
04c56954
EZ
5642011-04-19 Eli Zaretskii <eliz@gnu.org>
565
566 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
567 gl_state.e_property when gl_state.object is Qt.
568
569 * insdel.c (make_gap_larger): Remove limitation of buffer size
570 to <= INT_MAX.
571
16a43933
CY
5722011-04-18 Chong Yidong <cyd@stupidchicken.com>
573
574 * xdisp.c (lookup_glyphless_char_display)
575 (produce_glyphless_glyph): Handle cons cell entry in
576 glyphless-char-display.
577 (Vglyphless_char_display): Document it.
578
579 * term.c (produce_glyphless_glyph): Handle cons cell entry in
580 glyphless-char-display.
581
4581706e
CY
5822011-04-17 Chong Yidong <cyd@stupidchicken.com>
583
584 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
585
586 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
587
588 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
589 definition for no-X builds.
590
4887c6e2 5912011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 592
fd35b6f9
PE
593 Static checks with GCC 4.6.0 and non-default toolkits.
594
5c1ccb01
PE
595 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
596
006c5daa
PE
597 * process.c (keyboard_bit_set): Define only if SIGIO.
598 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
599 (send_process): Repair possible setjmp clobbering.
600
efc736d3
PE
601 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
602
4e2fe2e6
PE
603 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
604
f97334a2
PE
605 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
606
4e75f29d
PE
607 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
608 Define only if needed.
609
90efadd1
PE
610 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
611 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 612 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 613
3c647824
PE
614 * dispextern.h (struct redisplay_interface): Rename param
615 to avoid shadowing.
e264f262 616 * termhooks.h (struct terminal): Likewise.
761383f4 617 * xterm.c (xembed_send_message): Likewise.
3c647824 618
b58c5c4a
PE
619 * insdel.c (make_gap_smaller): Define only if
620 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
621
cad59032
PE
622 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
623 it.
624
c339dc2e
PE
625 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
626 so that we aren't warned about unused symbols.
627
91a3e27b
PE
628 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
629
399c71d3 630 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 631
8ffc96f5
PE
632 * xfns.c (x_real_positions): Mark locals as initialized.
633
eef9bc79
PE
634 * xmenu.c (xmenu_show): Don't use uninitialized vars.
635
098db9dd
PE
636 * xterm.c: Fix problems found by static analysis with other toolkits.
637 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
638 (x_dispatch_event): Declare static if USE_GTK, and
639 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 640 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 641 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
642 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
643 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 644
eb18f6cc
PE
645 * xmenu.c (menu_help_callback): Pointer type fixes.
646 Use const pointers when pointing at readonly data. Avoid pointer
647 signedness clashes.
648 (FALSE): Remove unused macro.
649 (update_frame_menubar): Remove unused decl.
650
1fe72bf8
PE
651 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
652
60d9e1db
PE
653 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
654 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
655 (single_menu_item): Rename local to avoid shadowing.
656
39261c26
PE
657 * keyboard.c (make_lispy_event): Remove unused local var.
658
018c5e19
PE
659 * frame.c, frame.h (x_get_resource_string): Bring this back, but
660 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
661
63d2b86e
PE
662 * bitmaps: Change bitmaps from unsigned char back to the X11
663 compatible char. Avoid the old compiler warnings about
664 out-of-range initializers by using, for example, '\xab' rather
665 than 0xab.
666
aefd87e1
PE
667 * xgselect.c (xgselect_initialize): Check vs interface
668 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
669
bf501fb9
PE
670 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
671
e9829fdf
PE
672 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
673 to read-only memory.
674
1086c095
PE
675 * fns.c (vector): Remove; this old hack is no longer needed.
676
2baccd04 677 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 678 Remove unused var.
dde42981 679 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 680
72391843 681 * xrdb.c (x_load_resources): Omit unused local.
3565b346 682
436c16df 683 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 684 (x_window): Rename locals to avoid shadowing.
dc5ddd85 685 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 686
92bb796d 687 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 688 (x_term_init): Remove local to avoid shadowing.
92bb796d 689
764430a3 690 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
691
692 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
693 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
694
d1dfb56c
EZ
6952011-04-16 Eli Zaretskii <eliz@gnu.org>
696
c4354cb4
EZ
697 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
698
d1dfb56c
EZ
699 Fix regex.c, syntax.c and friends for buffers > 2GB.
700 * syntax.h (struct gl_state_s): Declare character position members
701 EMACS_INT.
702
703 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
704
705 * textprop.c (verify_interval_modification, interval_of): Declare
706 arguments EMACS_INT.
707
708 * intervals.c (adjust_intervals_for_insertion): Declare arguments
709 EMACS_INT.
710
711 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
712
713 * indent.c (Fvertical_motion): Local variable it_start is now
714 EMACS_INT.
715
716 * regex.c (re_match, re_match_2, re_match_2_internal)
717 (bcmp_translate, regcomp, regexec, print_double_string)
718 (group_in_compile_stack, re_search, re_search_2, regex_compile)
719 (re_compile_pattern, re_exec): Declare arguments and local
720 variables `size_t' and `ssize_t' and return values `regoff_t', as
721 appropriate.
722 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
723 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
724 <compile_stack_type>: `size' and `avail' are now `size_t'.
725
726 * regex.h <regoff_t>: Use ssize_t, not int.
727 (re_search, re_search_2, re_match, re_match_2): Arguments that
728 specify buffer/string position and length are now ssize_t and
729 size_t. Return type is regoff_t.
730
613052cd
BK
7312011-04-16 Ben Key <bkey76@gmail.com>
732
733 * nsfont.m: Fixed bugs in ns_get_family and
734 ns_descriptor_to_entity that were caused by using free to
735 deallocate memory blocks that were allocated by xmalloc (via
736 xstrdup). This caused Emacs to crash when compiled with
737 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
738 --enable-checking=xmallocoverrun). xfree is now used to
739 deallocate these memory blocks.
740
4170f62f 7412011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 742
71b41406
PE
743 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
744
9587a89d
PE
745 emacs_write: Accept and return EMACS_INT for sizes.
746 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
747 et seq.
748 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
749 Accept and return EMACS_INT.
750 (emacs_gnutls_write): Return the number of bytes written on
751 partial writes.
752 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
753 (emacs_read, emacs_write): Remove check for negative size, as the
754 Emacs source code has been audited now.
9587a89d
PE
755 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
756 (emacs_read, emacs_write): Use it.
273a5f82
PE
757 * process.c (send_process): Adjust to the new signatures of
758 emacs_write and emacs_gnutls_write. Do not attempt to store
759 a byte offset into an 'int'; it might overflow.
9587a89d 760 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 761
3e047f51
PE
762 * sound.c: Don't assume sizes fit in 'int'.
763 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 764 Return EMACS_INT, not int.
3e047f51 765 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
766 Accept EMACS_INT, not int.
767 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
768 record read return values.
769
cc39a9db
BK
7702011-04-15 Ben Key <bkey76@gmail.com>
771
c9d0ec6d
JB
772 * keyboard.c (Qundefined): Don't declare static since it is used
773 in nsfns.m.
774 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
775 static since they are used in nsfont.m.
cc39a9db 776
6c60eb9f
SM
7772011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
778
779 * process.c (Qprocessp): Don't declare static.
780 * lisp.h (Qprocessp): Declare again.
781
7990b61a
JB
7822011-04-15 Juanma Barranquero <lekktu@gmail.com>
783
784 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
785
5d4cb038
PE
7862011-04-14 Paul Eggert <eggert@cs.ucla.edu>
787
8bd7b830 788 Improve C-level modularity by making more things 'static'.
cd64ea1d 789
e3b27b31
PE
790 Don't publish debugger-only interfaces to other modules.
791 * lisp.h (safe_debug_print, debug_output_compilation_hack):
792 (verify_bytepos, count_markers): Move decls to the only modules
793 that need them.
794 * region-cache.h (pp_cache): Likewise.
795 * window.h (check_all_windows): Likewise.
796 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
797
5d4cb038
PE
798 * sysdep.c (croak): Now static, if
799 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
800 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
801
802 * alloc.c (refill_memory_reserve): Now static if
803 !defined REL_ALLOC || defined SYSTEM_MALLOC.
804 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 805
e87b6180
PE
806 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
807 Define only if USE_LUCID.
808
ac64929e
PE
809 * xrdb.c (x_customization_string, x_rm_string): Now static.
810
6f37259d
PE
811 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
812 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
813
1683e3ab
PE
814 * xdisp.c (draw_row_with_mouse_face): Now static.
815 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
816
de9c2632
PE
817 * window.h (check_all_windows): Mark externally visible.
818
2b96acb7
PE
819 * window.c (window_deletion_count): Now static.
820
821 * undo.c: Make symbols static if they're not exported.
822 (last_undo_buffer, last_boundary_position, pending_boundary):
823 Now static.
824
50436f33
PE
825 * textprop.c (interval_insert_behind_hooks): Now static.
826 (interval_insert_in_front_hooks): Likewise.
827
64520e5c
PE
828 * term.c: Make symbols static if they're not exported.
829 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
830 (max_frame_lines, tty_set_terminal_modes):
831 (tty_reset_terminal_modes, tty_turn_off_highlight):
832 (get_tty_terminal): Now static.
833 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
834 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 835 HAVE_WINDOW_SYSTEM.
64520e5c
PE
836 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
837 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
838
1fa53021
PE
839 * sysdep.c: Make symbols static if they're not exported.
840 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
841 Now static.
842 (sigprocmask_set, full_mask): Remove; unused.
843 (wait_debugging): Mark as visible.
844 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
845 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
846
d4b43b22
PE
847 * syntax.c (syntax_temp): Define only if !__GNUC__.
848
b7c513d0
PE
849 * sound.c (current_sound_device, current_sound): Now static.
850
989b29ad
PE
851 * search.c (searchbufs, searchbuf_head): Now static.
852
13a55a78
PE
853 * scroll.c (scroll_cost): Remove; unused.
854 * dispextern.h (scroll_cost): Remove decl.
855
de68a1fc
PE
856 * region-cache.h (pp_cache): Mark as externally visible.
857
40ccffa6
PE
858 * process.c: Make symbols static if they're not exported.
859 (process_tick, update_tick, create_process, chan_process):
860 (Vprocess_alist, proc_buffered_char, datagram_access):
861 (fd_callback_data, send_process_frame, process_sent_to): Now static.
862 (deactivate_process): Mark defn as static, as well as decl.
863 * lisp.h (create_process): Remove decl.
864 * process.h (chan_process, Vprocess_alist): Remove decls.
865
ad64fc97
PE
866 * print.c: Make symbols static if they're not exported.
867 (print_depth, new_backquote_output, being_printed, print_buffer):
868 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
869 (print_interval, print_number_index, initial_stderr_stream):
870 Now static.
871 * lisp.h (Fprinc): Remove decl.
872 (debug_output_compilation_hack): Mark as externally visible.
873
adddb265
PE
874 * sysdep.c (croak): Move decl from here to syssignal.h.
875 * syssignal.h (croak): Put it here, so the API can be checked when
876 'croak' is called from dissociate_if_controlling_tty.
877
1717ede2
PE
878 * minibuf.c: Make symbols static if they're not exported.
879 (minibuf_save_list, choose_minibuf_frame): Now static.
880 * lisp.h (choose_minibuf_frame): Remove decl.
881
fa5fb2bc
PE
882 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
883
1e3890d1
PE
884 * lread.c: Make symbols static if they're not exported.
885 (read_objects, initial_obarray, oblookup_last_bucket_number):
886 Now static.
887 (make_symbol): Remove; unused.
888 * lisp.h (initial_obarray, make_symbol): Remove decls.
889
8a1414fa
PE
890 * keyboard.c: Make symbols static if they're not exported.
891 (single_kboard, recent_keys_index, total_keys, recent_keys):
892 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
893 (this_single_command_key_start, echoing, last_auto_save):
894 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
895 (command_loop, echo_now, keyboard_init_hook, help_char_p):
896 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
897 (Vlispy_mouse_stem, double_click_count):
898 Now static.
899 (force_auto_save_soon): Define only if SIGDANGER.
900 (ignore_mouse_drag_p): Now static if
901 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
902 (print_help): Remove; unused.
903 (stop_character, last_timer_event): Mark as externally visible.
904 * keyboard.h (ignore_mouse_drag_p): Declare only if
905 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
906 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
907 * lisp.h (echoing): Remove decl.
908 (force_auto_save_soon): Declare only if SIGDANGER.
909 * xdisp.c (redisplay_window): Simplify code, to make it more
910 obvious that ignore_mouse_drag_p is not accessed if !defined
911 USE_GTK && !defined HAVE_NS.
912
93ea6e8f
PE
913 * intervals.c: Make symbols static if they're not exported.
914 (merge_properties_sticky, merge_interval_right, delete_interval):
915 Now static.
916 * intervals.h (merge_interval_right, delete_interval): Remove decls.
917
77382fcc
PE
918 * insdel.c: Make symbols static if they're not exported.
919 However, leave prepare_to_modify_buffer alone. It's never
920 called from outside this function, but that appears to be a bug.
921 (combine_after_change_list, combine_after_change_buffer):
4889fc82 922 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
923 (adjust_after_replace_noundo): Remove; unused.
924 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 925 (signal_before_change): Remove decls.
77382fcc 926
9306c32e
PE
927 * indent.c (val_compute_motion, val_vmotion): Now static.
928
cd44d2eb
PE
929 * image.c: Make symbols static if they're not exported.
930 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
931 if USE_GTK.
932 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
933 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
934
ad9a7a06
PE
935 * fringe.c (standard_bitmaps): Now static.
936 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
937
81626931
PE
938 * frame.c: Make symbols static if they're not exported.
939 (x_report_frame_params, make_terminal_frame): Now static.
940 (get_frame_param): Now static, unless HAVE_NS.
941 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
942 (x_get_resource_string): Remove; not used.
943 * frame.h (make_terminal_frame, x_report_frame_params):
944 (x_get_resource_string); Remove decls.
945 (x_fullscreen_adjust): Declare only if WINDOWSNT.
946 * lisp.h (get_frame_param): Declare only if HAVE_NS.
947
239f9db9
PE
948 * font.c, fontset.c: Make symbols static if they're not exported.
949 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
950 (FACE_SUITABLE_FOR_CHAR_P): Use it.
951 * font.c (font_close_object): Now static.
952 * font.h (font_close_object): Remove.
953 * fontset.c (FONTSET_OBJLIST): Remove.
954 (free_realized_fontset) #if-0 the body, which does nothing.
955 (face_suitable_for_char_p): #if-0, as it's never called.
956 * fontset.h (face_suitable_for_char_p): Remove decl.
957 * xfaces.c (face_at_string_position): Use
958 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
959 since 0 is always ASCII.
960
dfcf3579
PE
961 * fns.c (weak_hash_tables): Now static.
962
5045092b
PE
963 * fileio.c: Make symbols static if they're not exported.
964 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
965 (Vwrite_region_annotation_buffers): Now static.
966
57a96f5c
PE
967 * eval.c: Make symbols static if they're not exported.
968 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
969 * lisp.h (backtrace_list): Remove decl.
970
35f08c38
PE
971 * emacs.c: Make symbols static if they're not exported.
972 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
973 (fatal_error_code, fatal_error_signal_hook, standard_args):
974 Now static.
975 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
976 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
977 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
978 * lisp.h (fatal_error_signal_hook): Remove decl.
979 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
980
f44bd759
PE
981 * editfns.c: Move a (normally-unused) function to its only use.
982 * editfns.c, lisp.h (get_operating_system_release): Remove.
983 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
984 worth the hassle of breaking this out.
985
b532497d
PE
986 * xterm.c: Make symbols static if they're not exported.
987 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
988 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
989 (x_destroy_window, x_delete_display):
990 Now static.
991 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
992 (x_mouse_leave): Remove; unused.
993 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
994 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
995 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
996 Remove decls.
997 (x_mouse_leave): Declare only if WINDOWSNT.
998 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
999 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1000 USE_X_TOOLKIT.
1001
1675728f
PE
1002 * ftxfont.c: Make symbols static if they're not exported.
1003 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1004 HAVE_FREETYPE.
1005 * font.h (ftxfont_driver): Likewise.
1006
e4cebfca
PE
1007 * xfns.c: Make symbols static if they're not exported.
1008 (x_last_font_name, x_display_info_for_name):
1009 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1010 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1011 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1012 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1013 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1014 (last_show_tip_args): Now static.
1015 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1016 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1017 (x_screen_planes): Remove; unused.
1018 * dispextern.h (x_screen_planes): Remove decl.
1019
5bf46f05
PE
1020 * dispnew.c: Make symbols static if they're not exported.
1021 * dispextern.h (redraw_garbaged_frames, scrolling):
1022 (increment_row_positions): Remove.
1023 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1024 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1025 Now static.
1026 (redraw_garbaged_frames): Remove; unused.
1027
435f4c28
PE
1028 * xfaces.c: Make symbols static if they're not exported.
1029 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1030 Remove decls.
1031 * xterm.h (defined_color): Remove decls.
1032 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1033 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1034 (menu_face_changed_default, defined_color, free_realized_face):
1035 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1036 (ascii_face_of_lisp_face): Remove; unused.
1037
8524aef3
PE
1038 * xdisp.c: Make symbols static if they're not exported.
1039 * dispextern.h (scratch_glyph_row, window_box_edges):
1040 (glyph_to_pixel_coords, set_cursor_from_row):
1041 (get_next_display_element, set_iterator_to_next):
1042 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1043 (show_mouse_face): Remove decls
1044 * frame.h (message_buf_print): Likewise.
1045 * lisp.h (pop_message, set_message, check_point_in_composition):
1046 Likewise.
1047 * xterm.h (set_vertical_scroll_bar): Likewise.
1048 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1049 (message_buf_print, scratch_glyph_row, displayed_buffer):
1050 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1051 (get_next_display_element, show_mouse_face, window_box_edges):
1052 (frame_to_window_pixel_xy, check_point_in_composition):
1053 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1054 (glyph_to_pixel_coords): Remove; unused.
1055
16390cd2
PE
1056 * dired.c (file_name_completion): Now static.
1057
1058 * dbusbind.c (xd_in_read_queued_messages): Now static.
1059
a25f4dfa
PE
1060 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1061 * data.c (circular_list_error): Remove.
1062
14a9c8df
PE
1063 * commands.h (last_point_position, last_point_position_buffer):
1064 (last_point_position_window): Remove decls.
1065 * keyboard.c: Make these variables static.
1066
74ab6df5
PE
1067 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1068 decls.
1069 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1070 (iso_code_class, detect_coding, code_convert_region): Now static.
1071 (encode_coding_gap): Remove; unused.
1072
38dfbee1
PE
1073 * chartab.c (chartab_chars, chartab_bits): Now static.
1074
a2cb4e63
PE
1075 * charset.h (charset_iso_8859_1): Remove decl.
1076 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1077 Now static.
1078
127198fd
PE
1079 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1080 * ccl.c (Vccl_program_table): Now static.
1081 (check_ccl_update): Remove; unused.
1082
d85b608f
PE
1083 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1084 * category.h: ... from here.
1085 * category.c (check_category_table, set_category_set): Now static.
1086
31cd66f3
PE
1087 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1088 * lisp.h: Remove these decls.
1089
c358e587
PE
1090 * buffer.c (buffer_count): Remove unused var.
1091
e78aecca
PE
1092 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1093 so that it's not optimized away.
1094 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1095 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1096 exported only to the debugger.
1097
e192d7d3
PE
1098 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1099 * atimer.h (run_all_atimers): Removed; not exported.
1100
92470028
PE
1101 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1102 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1103 was inaccessible from Lisp.
1104 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1105 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1106
244ed907
PE
1107 alloc.c: Import and export fewer symbols, and remove unused items.
1108 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1109 is defined.
1110 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1111 it's not optimized away by whole-program optimization.
1112 (message_enable_multibyte, free_misc): Remove.
1113 (catchlist, handlerlist, mark_backtrace):
1114 Declare only if BYTE_MARK_STACK.
1115 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1116 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1117 (message_enable_multibyte): Remove decl.
1118 (free_misc, interval_free_list, float_block, float_block_index):
1119 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1120 (cons_free_list, last_marked_index):
1121 Now static.
1122 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1123 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1124 (mark_backtrace): Define only if BYTE_MARK_STACK.
1125 * xdisp.c (message_enable_multibyte): Now static.
1126
61c2b50e 1127 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1128 This makes it easier for human readers (and static analyzers)
1129 to see whether these variables are used from other modules.
1130 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1131 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1132 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1133 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1134 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1135 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1136 * xmenu.c, xselect.c:
1137 Declare Q* vars static if they are not used in other modules.
1138 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1139 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1140 Remove decls of unexported vars.
1141 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1142
95c82688
PE
1143 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1144
16a97296
PE
1145 Make Emacs functions such as Fatom 'static' by default.
1146 This makes it easier for human readers (and static analyzers)
1147 to see whether these functions can be called from other modules.
1148 DEFUN now defines a static function. To make the function external
1149 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1150 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1151 (Finit_image_library):
16a97296
PE
1152 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1153 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1154 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1155 Remove decls, since these functions are now static.
1156 (Funintern, Fget_internal_run_time): New decls, since these functions
1157 were already external.
95c82688 1158
16a97296
PE
1159 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1160 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1161 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1162 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1163 * keyboard.c, keymap.c, lread.c:
1164 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1165 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1166 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1167 Mark functions with DEFUE instead of DEFUN,
1168 if they are used in other modules.
1169 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1170 decls for now-static functions.
1171 * buffer.h (Fdelete_overlay): Remove decl.
1172 * callproc.c (Fgetenv_internal): Mark as internal.
1173 * composite.c (Fremove_list_of_text_properties): Remove decl.
1174 (Fcomposition_get_gstring): New forward static decl.
1175 * composite.h (Fcomposite_get_gstring): Remove decl.
1176 * dired.c (Ffile_attributes): New forward static decl.
1177 * doc.c (Fdocumntation_property): New forward static decl.
1178 * eval.c (Ffetch_bytecode): New forward static decl.
1179 (Funintern): Remove extern decl; now in .h file where it belongs.
1180 * fileio.c (Fmake_symbolic_link): New forward static decl.
1181 * image.c (Finit_image_library): New forward static decl.
1182 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1183 * intervals.h (Fprevious_property_change):
1184 (Fremove_list_of_text_properties): Remove decls.
1185 * keyboard.c (Fthis_command_keys): Remove decl.
1186 (Fcommand_execute): New forward static decl.
1187 * keymap.c (Flookup_key): New forward static decl.
1188 (Fcopy_keymap): Now static.
1189 * keymap.h (Flookup_key): Remove decl.
1190 * process.c (Fget_process): New forward static decl.
1191 (Fprocess_datagram_address): Mark as internal.
1192 * syntax.c (Fsyntax_table_p): New forward static decl.
1193 (skip_chars): Remove duplicate decl.
1194 * textprop.c (Fprevious_property_change): New forward static decl.
1195 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1196 Now internal.
1197 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1198 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1199
785bbd42
PE
1200 * editfns.c (Fformat): Remove unreachable code.
1201
8b913b57
AS
12022011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1203
1204 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1205 change. (Bug#8496)
1206
a6744a35
EZ
12072011-04-13 Eli Zaretskii <eliz@gnu.org>
1208
1209 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1210 when at ZV. (Bug#8487)
1211
e7974947
AS
12122011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1213
baad03f0
AS
1214 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1215 (Bug#8437)
1216 * keyboard.c (parse_tool_bar_item): Likewise.
1217 * sound.c (sound_cleanup, alsa_close): Likewise.
1218 * termcap.c (tgetent): Likewise.
1219 * xfns.c (x_default_font_parameter): Likewise.
1220 * xsettings.c (read_and_apply_settings): Likewise.
1221
e7974947
AS
1222 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1223 (overrun_check_free): Protoize.
1224
28272684
PE
12252011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1228 since callers should never pass a negative size.
1229 Change the signature to match that of plain 'read' and 'write'; see
1230 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1231 * lisp.h: Update prototypes of emacs_write and emacs_read.
1232
11997c76
EZ
12332011-04-11 Eli Zaretskii <eliz@gnu.org>
1234
1235 * xdisp.c (redisplay_window): Don't try to determine the character
1236 position of the scroll margin if the window start point w->startp
e896f03c 1237 is outside the buffer's accessible region. (Bug#8468)
11997c76 1238
8a2cbd72
EZ
12392011-04-10 Eli Zaretskii <eliz@gnu.org>
1240
1241 Fix write-region and its subroutines for buffers > 2GB.
1242 * fileio.c (a_write, e_write): Modify declaration of arguments and
1243 local variables to support buffers larger than 2GB.
1244 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1245
1246 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1247 argument, local variables, and return value.
1248
1249 * lisp.h: Update prototypes of emacs_write and emacs_read.
1250
1251 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1252
4073e537 12532011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1254
1ebfdcb6
PE
1255 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1256
b2ded58d
PE
1257 Fix more problems found by GCC 4.6.0's static checks.
1258
7d66342c
PE
1259 * xdisp.c (vmessage): Use a better test for character truncation.
1260
bbf47d44
PE
1261 * charset.c (load_charset_map): <, not <=, for optimization,
1262 and to avoid potential problems with integer overflow.
9248994d 1263 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1264 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1265 * editfns.c (Fformat): Likewise.
1e69125e 1266 * syntax.c (skip_chars): Likewise.
3befa583 1267
e3019616
PE
1268 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1269 This also lets GCC 4.6.0 generate slightly better loop code.
1270
becfa255
PE
1271 * callint.c (Fcall_interactively): <, not <=, for optimization.
1272 (Fcall_interactively): Count the number of arguments produced,
1273 not the number of arguments given. This is simpler and lets GCC
1274 4.6.0 generate slightly better code.
1275
dae0cd48
PE
1276 * ftfont.c: Distingish more carefully between FcChar8 and char.
1277 The previous code passed unsigned char * to a functions like
1278 strlen and xstrcasecmp that expect char *, which does not
1279 conform to the C standard.
1280 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1281 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1282 char * when the C standard requires it.
1283
76032d70
PE
1284 * keyboard.c (read_char): Remove unused var.
1285
eb3f1cc8
PE
1286 * eval.c: Port to Windows vsnprintf (Bug#8435).
1287 Include <limits.h>.
1288 (SIZE_MAX): Define if the headers do not.
1289 (verror): Do not give up if vsnprintf returns a negative count.
1290 Instead, grow the buffer. This ports to Windows vsnprintf, which
1291 does not conform to C99. Problem reported by Eli Zaretskii.
1292 Also, simplify the allocation scheme, by avoiding the need for
1293 calling realloc, and removing the ALLOCATED variable.
1294
70476b54
PE
1295 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1296
12020a9e
PE
1297 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1298 But keep the doprint source code for now, as we might revamp it
1299 and use it again (Bug#8435).
ea6c7ae6
PE
1300 * lisp.h (doprnt): Remove.
1301 * Makefile.in (base_obj): Remove doprnt.o.
1302 * deps.mk (doprnt.o): Remove.
1303
5fdb398c
PE
1304 error: Print 32- and 64-bit integers portably (Bug#8435).
1305 Without this change, on typical 64-bit hosts error ("...%d...", N)
1306 was used to print both 32- and 64-bit integers N, which relied on
1307 undefined behavior.
1308 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1309 New macro.
1310 * lisp.h (error, verror): Mark as printf-like functions.
1311 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1312 Report overflow in size calculations when allocating printf buffer.
1313 Do not truncate output string at its first null byte.
1314 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1315 Truncate the output at a character boundary, since vsnprintf does not
1316 do that.
1317 * charset.c (check_iso_charset_parameter): Convert internal
1318 character to string before calling 'error', since %c now has the
1319 printf meaning.
1320 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1321 overflow when computing char to be passed to 'error'. Do not
1322 pass Lisp_Object to 'error'; pass the integer instead.
1323 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1324 formatted with plain %d.
1325
b189fa66
PE
1326 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1327
bff87ef0
PE
1328 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1329
7e2cac20
PE
1330 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1331
ce4d90b5
PE
1332 * xterm.c (x_catch_errors): Remove duplicate declaration.
1333
266c9547
PE
1334 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1335
79c49ad2
PE
1336 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1337
368f4090
JM
13382011-04-10 Jim Meyering <meyering@redhat.com>
1339
1340 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1341 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1342 return ssize_t not "int", and use size_t as the buffer length.
1343 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1344 * gnutls.h: Update declarations.
1345 * process.c (read_process_output): Use ssize_t, to match.
1346 (send_process): Likewise.
1347
a32d4040
CY
13482011-04-09 Chong Yidong <cyd@stupidchicken.com>
1349
1350 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1351
8546720e 13522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1353
8546720e
GM
1354 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1355 unsigned char, to match FcChar8 type definition.
aac0c6e3 1356
8546720e
GM
1357 * xterm.c (handle_one_xevent):
1358 * xmenu.c (create_and_show_popup_menu):
1359 * xselect.c (x_decline_selection_request)
1360 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1361
0a2f5c1a 13622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1363
1364 Fix some uses of `int' instead of EMACS_INT.
1365 * search.c (string_match_1, fast_string_match)
1366 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1367 (scan_buffer, find_next_newline_no_quit)
1368 (find_before_next_newline, search_command, Freplace_match)
1369 (Fmatch_data): Make some `int' variables be EMACS_INT.
1370
1371 * xdisp.c (display_count_lines): 3rd argument and return value now
1372 EMACS_INT. All callers changed.
1373 (pint2hrstr): Last argument is now EMACS_INT.
1374
1375 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1376 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1377 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1378 (decode_coding_utf_16, decode_coding_emacs_mule)
1379 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1380 (decode_coding_ccl, decode_coding_charset)
1381 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1382 (decode_coding_iso_2022, decode_coding_emacs_mule)
1383 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1384 <char_offset, last_offset>: Declare EMACS_INT.
1385 (encode_coding_utf_8, encode_coding_utf_16)
1386 (encode_coding_emacs_mule, encode_invocation_designation)
1387 (encode_designation_at_bol, encode_coding_iso_2022)
1388 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1389 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1390 Declare EMACS_INT.
1391 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1392 (encode_invocation_designation): Last argument P_NCHARS is now
1393 EMACS_INT.
1394 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1395 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1396
1397 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1398 All users changed.
1399
1400 * ccl.c (Fccl_execute_on_string): Declare some variables
1401 EMACS_INT.
1402
8546720e 14032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1404
1405 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1406
4e19a977
CS
14072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1408
1409 * process.c (Fformat_network_address): Doc fix.
1410
87302331
R
14112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1412
1413 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1414
cbb59342
CY
14152011-04-08 Chong Yidong <cyd@stupidchicken.com>
1416
1417 * keyboard.c (read_char): Call Lisp function help-form-show,
1418 instead of using internal_with_output_to_temp_buffer.
1419 (Qhelp_form_show): New var.
e0d38eeb 1420 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1421
1422 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1423
1424 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1425
e67a13ab
CY
14262011-04-06 Chong Yidong <cyd@stupidchicken.com>
1427
1428 * process.c (Flist_processes): Removed to Lisp.
1429 (list_processes_1): Deleted.
1430
973f782d
EZ
14312011-04-06 Eli Zaretskii <eliz@gnu.org>
1432
7c106b1e
EZ
1433 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1434
973f782d
EZ
1435 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1436
41cf7d1a 14372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1438
ca23cc88
PE
1439 Fix more problems found by GCC 4.6.0's static checks.
1440
f390e2d5
PE
1441 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1442
42eea0d0
PE
1443 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1444
b69769da 1445 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1446
f9541e84
PE
1447 * xdisp.c (vmessage): Mark as a printf-like function.
1448
13841b55
PE
1449 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1450
c136c10f
PE
1451 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1452
5e2d4a30
PE
1453 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1454 printf-like functions.
1455 (tiff_load): Add casts to remove these marks before passing them
1456 to system-supplied API.
1457
583f48b9
PE
1458 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1459
b25d760e
PE
1460 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1461 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1462 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1463 directly, rather than having caller test rule sign. This avoids
1464 some unnecessary tests.
1465 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1466 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1467 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1468
bc7b6697 1469 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1470 (xfont_open): Avoid unnecessary tests.
bc7b6697 1471
27ccc379
PE
1472 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1473
dcd5c89a
PE
1474 * composite.h, composite.c (composition_gstring_put_cache):
1475 Use EMACS_INT, not int, for length.
1476
b13a45c6
PE
1477 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1478 breaking out part of COMPOSITION_DECODE_RULE.
1479 (COMPOSITION_DECODE_RULE): Use it.
1480 * composite.c (get_composition_id): Remove unused local vars,
1481 by using the new macro.
1482
1e792e4d
PE
1483 * textprop.c (set_text_properties_1): Change while to do-while,
1484 since the condition is always true at first.
1485
dc6c6455 1486 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1487 (interval_deletion_adjustment): Return unsigned value.
1488 All uses changed.
dc6c6455 1489
aba7731a
PE
1490 * process.c (list_processes_1, create_pty, read_process_output):
1491 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1492 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1493 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1494 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1495 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1496
fdfc4bf3
PE
1497 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1498
fca8fe46 1499 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1500 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1501
06a0259a 1502 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1503 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1504 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1505
e7b9e80f
PE
1506 * print.c (print_error_message): Avoid int overflow.
1507
56201685
PE
1508 * font.c (font_list_entities): Redo for clarity,
1509 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1510
78834453 1511 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1512 (font_score): Avoid potential overflow in diff calculation.
78834453 1513
0bc0b309 1514 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1515 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1516
e610eaca
PE
1517 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1518
b895abce
PE
1519 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1520 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1521 can always succeed if overflow has undefined behavior.
1522
1f1d9321 1523 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1524 (wordify): Omit three unnecessary tests.
1f1d9321 1525
c59478bc
PE
1526 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1527 All callers changed. This avoids the need for an unused var.
1528
79b73827
PE
1529 * casefiddle.c (casify_region): Remove var that is set but not used.
1530
a4db5dfe
PE
1531 * dired.c (file_name_completion): Remove var that is set but not used.
1532
43aae36e
PE
1533 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1534
2a47c44d 1535 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1536 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1537
a37c69bf
PE
1538 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1539 Check for integer overflow on size calculations.
1540
328ab8e7
PE
1541 * buffer.c (Fprevious_overlay_change): Remove var that is set
1542 but not used.
1543
e5a2a5cb
PE
1544 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1545 Remove vars that are set but not used.
8d84a6eb 1546 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1547 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1548
a60e5f68
PE
1549 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1550
f661cb61 1551 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1552 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1553
f0397f5a
PE
1554 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1555 that are set but not used.
1556
8664db06 1557 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1558 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1559
6abdaa4a
PE
1560 * xselect.c (x_get_local_selection, x_handle_property_notify):
1561 Remove vars that are set but not used.
1562
0ce7538d 1563 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1564 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1565
9ae848fc
PE
1566 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1567 Remove var that is set but not used.
0b918413
PE
1568 (scroll_bar_windows_size): Now size_t, not int.
1569 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1570 Check for overflow.
9ae848fc 1571
a5a62657
PE
1572 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1573 (map_tty_color) [!defined MSDOS]: Likewise.
1574
5c5cdd39
PE
1575 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1576
66ebf983
PE
1577 * coding.c: Remove vars that are set but not used.
1578 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1579 All callers changed.
1580 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1581 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1582 (decode_coding_charset): Remove vars that are set but not used.
1583
1be4d761
PE
1584 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1585 that is set but not used.
1586
47553fa8
PE
1587 * print.c (print_object): Remove var that is set but not used.
1588
1f7196bf 1589 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1590 The gnulib version avoids calling malloc in the usual case,
1591 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1592 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1593 * filelock.c (current_lock_owner): Likewise.
1594 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1595 * sysdep.c: Include allocator.h, careadlinkat.h.
1596 (emacs_no_realloc_allocator): New static constant.
1597 (emacs_readlink): New function.
fdb61804
PE
1598 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1599 ../lib/careadlinkat.h.
d1fdcab7 1600
f84c17c7
SM
16012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1602
1603 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1604 first non-nil return value).
1605
ef3862ad
JD
16062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1607
1608 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1609 if not defined (Bug#8403).
1610
376a7006
JB
16112011-04-02 Juanma Barranquero <lekktu@gmail.com>
1612
1613 * xdisp.c (display_count_lines): Remove parameter `start',
1614 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1615 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1616 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1617 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1618 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1619 and thereabouts. All callers changed.
1620 (get_per_char_metric): Remove parameter `f', unused since
1621 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1622
6ca3801d
JM
16232011-04-02 Jim Meyering <meyering@redhat.com>
1624
1625 do not dereference NULL upon failed strdup
1626 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1627 (ns_get_family): Likewise.
1628
d8e2b5ba
JB
16292011-04-02 Juanma Barranquero <lekktu@gmail.com>
1630
1631 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1632
8c74fcbd
JD
16332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1634
1635 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1636 later (Bug#8403).
1637
7200d79c
SM
16382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1639
03408648 1640 Add lexical binding.
7200d79c 1641
03408648
SM
1642 * window.c (Ftemp_output_buffer_show): New fun.
1643 (Fsave_window_excursion):
1644 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1645
1646 * lread.c (lisp_file_lexically_bound_p): New function.
1647 (Fload): Bind Qlexical_binding.
1648 (readevalloop): Remove `evalfun' arg.
1649 Bind Qinternal_interpreter_environment.
1650 (Feval_buffer): Bind Qlexical_binding.
1651 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1652 Mark as dynamic.
1653 (syms_of_lread): Declare `lexical-binding'.
1654
1655 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1656
1657 * keyboard.c (eval_dyn): New fun.
1658 (menu_item_eval_property): Use it.
ca105506
SM
1659
1660 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1661
03408648
SM
1662 * fns.c (concat, mapcar1): Accept byte-code-functions.
1663
1664 * eval.c (Fsetq): Handle lexical vars.
1665 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1666 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1667 (FletX, Flet): Obey lexical binding.
1668 (Fcommandp): Handle closures.
1669 (Feval): New `lexical' arg.
1670 (eval_sub): New function extracted from Feval. Use it almost
1671 everywhere where Feval was used. Look up vars in lexical env.
1672 Handle closures.
1673 (Ffunctionp): Move from subr.el.
1674 (Ffuncall): Handle closures.
1675 (apply_lambda): Remove `eval_flags'.
1676 (funcall_lambda): Handle closures and new byte-code-functions.
1677 (Fspecial_variable_p): New function.
1678 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1679 but without exporting it to Lisp.
23aba0ea 1680
23aba0ea 1681 * doc.c (Fdocumentation, store_function_docstring):
03408648 1682 * data.c (Finteractive_form): Handle closures.
23aba0ea 1683
03408648
SM
1684 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1685 interactive spec.
ba83908c 1686
03408648
SM
1687 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1688 byte-codes.
1689 (exec_byte_code): New function extracted from Fbyte_code to handle new
1690 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1691
03408648 1692 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1693
03408648 1694 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1695
e2abce01
JB
16962011-03-31 Juanma Barranquero <lekktu@gmail.com>
1697
1698 * xdisp.c (redisplay_internal): Fix prototype.
1699
63696a73 17002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1701
63696a73
EZ
1702 * xdisp.c (SCROLL_LIMIT): New macro.
1703 (try_scrolling): Use it when setting scroll_limit. Limit
1704 scrolling to 100 screen lines.
1705 (redisplay_window): Even when falling back on "recentering",
1706 position point in the window according to scroll-conservatively,
1707 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1708
1709 (try_scrolling): When point is above the window, allow searching
1710 as far as scroll_max, or one screenful, to compute vertical
1711 distance from PT to the scroll margin position. This prevents
1712 try_scrolling from unnecessarily failing when
1713 scroll-conservatively is set to a value slightly larger than the
1714 window height. Clean up the case of PT below the margin at bottom
1715 of window: scroll_max can no longer be INT_MAX. When aggressive
1716 scrolling is in use, don't let point enter the opposite scroll
1717 margin as result of the scroll.
1718 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1719 threshold of 100 lines for never-recentering scrolling.
1720
e4cc2dfc
JB
17212011-03-31 Juanma Barranquero <lekktu@gmail.com>
1722
1723 * dispextern.h (move_it_by_lines):
1724 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1725 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1726 (message_log_check_duplicate): Remove parameters `prev_bol' and
1727 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1728 (redisplay_internal): Remove parameter `preserve_echo_area',
1729 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1730
1731 * indent.c (Fvertical_motion):
1732 * window.c (window_scroll_pixel_based, Frecenter):
1733 Don't pass `need_y_p' to `move_it_by_lines'.
1734
1c470562
SM
17352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1736
44f230aa
SM
1737 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1738 steal a few bits to be more compact.
1739 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1740 Remove unneeded casts.
1741
1c470562
SM
1742 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1743
888adce9
ZK
17442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1745
1746 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1747 binding" message (bug#7967).
1748
f838ed7b
PE
17492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1750
77861b95
PE
1751 Fix more problems found by GCC 4.6.0's static checks.
1752
de6dbc14
PE
1753 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1754 Remove unused local var.
1755
f838ed7b
PE
1756 * editfns.c (Fmessage_box): Remove unused local var.
1757
792c7b2b
PE
1758 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1759 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1760 Omit unused local vars.
c499e557 1761 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1762 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1763 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1764 Omit unused local var.
1765
ba0165e1
PE
1766 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1767 Don't assume string length fits in int.
32ad8845 1768 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1769 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1770
3c59b4c9
PE
1771 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1772 instead of alloca (Bug#8344).
1773
a3eed478 1774 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1775 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1776
eb4d412d
PE
1777 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1778
1658b401
PE
1779 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1780 concerns.
1781
1782 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1783
1784 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1785
9a2c6e05
PE
1786 * keyboard.c (syms_of_keyboard): Use the same style as later
1787 in this function when indexing through an array. This also
1788 works around GCC bug 48267.
1789
03d0a109
PE
1790 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1791
44f730c8
PE
1792 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1793
fe75f926
PE
1794 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1795 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1796
ffa8c828
PE
1797 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1798 This avoids undefined behavior on integer overflow, and is a bit
1799 more convenient anyway since it is compared to a size_t variable.
1800
c5101a77
PE
1801 Variadic C functions now count arguments with size_t, not int.
1802 This avoids an unnecessary limitation on 64-bit machines, which
1803 caused (substring ...) to crash on large vectors (Bug#8344).
1804 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1805 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1806 All variadic functions and their callers changed accordingly.
c5101a77
PE
1807 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1808 * data.c (arith_driver, float_arith_driver): Likewise.
1809 * editfns.c (general_insert_function): Likewise.
1810 * eval.c (struct backtrace.nargs, interactive_p)
1811 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1812 (funcall_lambda, mark_backtrace): Likewise.
1813 * fns.c (concat): Likewise.
1814 * frame.c (x_set_frame_parameters): Likewise.
1815 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1816 0 if not found, not -1. All callers changed.
1817
dd3f25f7
PE
1818 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1819 (stack_copy_size): Now size_t, not int.
1820 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1821
461c2ab9
JB
18222011-03-28 Juanma Barranquero <lekktu@gmail.com>
1823
1824 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1825 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1826 All callers changed.
1827
1828 * lisp.h (multibyte_char_to_unibyte):
1829 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1830 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1831 * character.h (CHAR_TO_BYTE8):
1832 * cmds.c (internal_self_insert):
1833 * editfns.c (general_insert_function):
1834 * keymap.c (push_key_description):
1835 * search.c (Freplace_match):
1836 * xdisp.c (message_dolog, set_message_1): All callers changed.
1837
f6d62986
SM
18382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1839
1840 * keyboard.c (safe_run_hook_funcall): New function.
1841 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1842 don't set the hook to nil, but remove the offending function instead.
1843 (Qcommand_hook_internal): Remove, unused.
1844 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1845 Vcommand_hook_internal.
1846
1847 * eval.c (enum run_hooks_condition): Remove.
1848 (funcall_nil, funcall_not): New functions.
1849 (run_hook_with_args): Call each function through a `funcall' argument.
1850 Remove `cond' argument, now redundant.
1851 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1852 (Frun_hook_with_args_until_failure): Adjust accordingly.
1853 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1854
1db5b1ad
JB
18552011-03-28 Juanma Barranquero <lekktu@gmail.com>
1856
1857 * dispextern.h (string_buffer_position): Remove declaration.
1858
1859 * print.c (strout): Remove parameter `multibyte', unused since
1860 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1861
1862 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1863 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1864 All callers changed.
1865
1866 * w32.c (_wsa_errlist): Use braces for struct initializers.
1867
1868 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1869 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1870 All callers changed.
1871 (string_buffer_position): Likewise. Also, make static (it's never
1872 used outside xdisp.c).
1873 (cursor_row_p): Remove parameter `w', unused since
1874 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1875 (decode_mode_spec): Remove parameter `precision', introduced during
1876 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1877 All callers changed.
1878
5ffb62aa
JD
18792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1880
1881 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1882
461c2ab9 18832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1884
1885 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1886 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1887 (ns_update_auto_hide_menu_bar): New functions.
1888 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1889 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1890 ns_constrain_all_frames.
1891 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1892 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1893
5c380ffb
JD
18942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1895
1896 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1897
9af30bdf
GM
18982011-03-27 Glenn Morris <rgm@gnu.org>
1899
1900 * syssignal.h: Replace RETSIGTYPE with void.
1901 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1902 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1903 Replace SIGTYPE with void everywhere.
1904 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1905 * s/template.h (SIGTYPE): Remove commented out definition.
1906
e2abce01
JB
19072011-03-26 Eli Zaretskii <eliz@gnu.org>
1908
1909 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1910 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1911
f868cd8a
JB
19122011-03-26 Juanma Barranquero <lekktu@gmail.com>
1913
59eb0929
JB
1914 * w32.c (read_unc_volume): Use parameter `henum', instead of
1915 global variable `wget_enum_handle'.
1916
1917 * keymap.c (describe_vector): Remove parameters `indices' and
1918 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1919 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1920
f868cd8a
JB
1921 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1922
1923 * keyboard.c (timer_check): Remove parameter `do_it_now',
1924 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1925 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1926 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1927
1928 * keyboard.c (read_char):
1929 * w32menu.c (w32_menu_display_help):
1930 * xmenu.c (show_help_event, menu_help_callback):
1931 Adjust calls to `show_help_echo'.
1932
1933 * gtkutil.c (xg_maybe_add_timer):
1934 * keyboard.c (readable_events):
1935 * process.c (wait_reading_process_output):
1936 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1937
1938 * insdel.c (adjust_markers_gap_motion):
1939 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1940 (gap_left, gap_right): Don't call it.
1941
2ecf6fdb
CY
19422011-03-25 Chong Yidong <cyd@stupidchicken.com>
1943
1944 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1945 incurred during fontification.
1946
6b1f9ba4
JB
19472011-03-25 Juanma Barranquero <lekktu@gmail.com>
1948
1949 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1950 (DEFVAR_PER_BUFFER): Don't pass it.
1951
1952 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1953 (scrolling_window): Don't pass it.
1954
0f4a96b5
JB
19552011-03-25 Juanma Barranquero <lekktu@gmail.com>
1956
1957 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1958
1959 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1960 and `suffix'.
1961 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1962 of variables specific to SELinux and computation of `encoded_absname'.
1963
1964 * image.c (XPutPixel): Remove unused variable `height'.
1965
1966 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1967
1968 * unexw32.c (get_section_info): Remove unused variable `section'.
1969
1970 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1971 (system_process_attributes): Remove unused variable `sess'.
1972 (sys_read): Remove unused variable `err'.
1973
1974 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1975 (w32_wnd_proc): Remove unused variable `isdead'.
1976 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1977 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1978 (x_create_tip_frame): Remove unused variable `tem'.
1979
1980 * w32inevt.c (w32_console_read_socket):
1981 Remove unused variable `no_events'.
1982
1983 * w32term.c (x_draw_composite_glyph_string_foreground):
1984 Remove unused variable `width'.
1985
1149507c
JB
19862011-03-24 Juanma Barranquero <lekktu@gmail.com>
1987
1988 * w32term.c (x_set_glyph_string_clipping):
1989 Don't pass uninitialized region to CombineRgn.
1990
9c88f339
JB
19912011-03-23 Juanma Barranquero <lekktu@gmail.com>
1992
1993 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1994 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1995 (Fx_close_connection): Remove unused variable `i'.
1996
1997 * w32font.c (w32font_draw): Return number of glyphs.
1998 (w32font_open_internal): Remove unused variable `i'.
1999 (w32font_driver): Add missing initializer.
2000
2001 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2002 (fill_in_menu): Remove unused variable `items_added'.
2003
2004 * w32term.c (last_mouse_press_frame): Remove static global variable.
2005 (w32_clip_to_row): Remove unused variable `f'.
2006 (x_delete_terminal): Remove unused variable `i'.
2007
2008 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2009 (NOTHING): Remove unused static global variable.
2010 (uniscribe_check_otf): Remove unused variable `table'.
2011 (uniscribe_font_driver): Add missing initializers.
2012
dee091a3
JD
20132011-03-23 Julien Danjou <julien@danjou.info>
2014
2015 * term.c (Fsuspend_tty, Fresume_tty):
2016 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2017 * window.c (temp_output_buffer_show):
2018 * insdel.c (signal_before_change):
2019 * frame.c (Fhandle_switch_frame):
2020 * fileio.c (Fdo_auto_save):
2021 * emacs.c (Fkill_emacs):
2022 * editfns.c (save_excursion_restore):
2023 * cmds.c (internal_self_insert):
2024 * callint.c (Fcall_interactively):
2025 * buffer.c (Fkill_all_local_variables):
2026 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2027 Use Frun_hooks.
0f4a96b5 2028 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2029 unconditionnaly since it does the check itself.
2030
2c520ab5 20312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2032
c9c49752
PE
2033 Fix more problems found by GCC 4.5.2's static checks.
2034
8abc3f12
PE
2035 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2036 the first time through the loop, since we know p0 < p1 then.
2037 This also avoids a gcc -Wstrict-overflow warning.
2038
a2d26660
PE
2039 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2040 leading to a memory leak, possible in functions like
2041 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2042 of objects (Bug#8318).
a2d26660 2043
916c72e9
PE
2044 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2045 that could (at least in theory) be that large.
2046
19ab8a18
PE
2047 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2048 This is less likely to overflow, and avoids undefined behavior if
2049 overflow does occur. All callers changed. Use strtoul to scan
2050 for the unsigned long integer.
b7cbbd6f
PE
2051 (pint2hrstr): Simplify and tune code slightly.
2052 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2053
f0641eff
PE
2054 * scroll.c (do_scrolling): Work around GCC bug 48228.
2055 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2056
7f650bb9
PE
2057 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2058 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2059 (validate_x_resource_name): Simplify count usage.
2060 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2061
37dd57d1
PE
2062 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2063 fail (Bug#8306).
81e56e61 2064
699979fc 2065 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2066
401bf9b4
PE
2067 * process.c (Fmake_network_process): Use socklen_t, not int,
2068 where POSIX says socklen_t is required in portable programs.
2069 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2070 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2071 (Fmake_network_process, server_accept_connection):
2072 (wait_reading_process_output, read_process_output):
2073 Likewise.
2074
b93aacde
PE
2075 * process.c: Rename or move locals to avoid shadowing.
2076 (list_processes_1, Fmake_network_process):
2077 (read_process_output_error_handler, exec_sentinel_error_handler):
2078 Rename or move locals.
4dc343ee 2079 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2080 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2081 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2082 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2083 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2084
af8a867c 2085 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2086 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2087 Include tparam.h instead, since it declares them.
af8a867c
PE
2088 * cm.h (PC): Remove extern decl; tparam.h now does this.
2089 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2090 * terminfo.c: Include tparam.h, to check interfaces.
2091 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2092 (tparam): Adjust signature to match interface in tparam.h;
2093 this removes some undefined behavior. Check that outstring and len
2094 are zero, which they always are with Emacs.
2095 * tparam.h (PC, BC, UP): New extern decls.
2096
0248044d 2097 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2098 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2099
8ff096c1 2100 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2101 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2102 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2103 (ftfont_list): Remove unused local.
49eaafba
PE
2104 (get_adstyle_property, ftfont_pattern_entity):
2105 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2106 Rename locals to avoid shadowing.
8ff096c1 2107
e2be39f6
PE
2108 * xfont.c (xfont_list_family): Mark var as initialized.
2109
c9735e30
PE
2110 * xml.c (make_dom): Now static.
2111
8f5201ae
PE
2112 * composite.c (composition_compute_stop_pos): Rename local to
2113 avoid shadowing.
b246f932
PE
2114 (composition_reseat_it): Remove unused locals.
2115 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2116 (composition_update_it): Mark var as initialized.
11b61122
PE
2117 (find_automatic_composition): Mark vars as initialized,
2118 with a FIXME (Bug#8290).
8f5201ae 2119
760fbc2c
PE
2120 character.h: Rename locals to avoid shadowing.
2121 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2122 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2123 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2124 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2125 to avoid shadowing.
2126
ff08eb85
PE
2127 * textprop.c (property_change_between_p): Remove; unused.
2128
fc7bf025
PE
2129 * intervals.c (interval_start_pos): Now static.
2130
235d7abc
PE
2131 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2132
44f230aa
SM
2133 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2134 Rename locals to avoid shadowing.
3e7d6594 2135
50060332
PE
2136 * sound.c (wav_play, au_play, Fplay_sound_internal):
2137 Fix pointer signedness.
d01f234b 2138 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2139 (wav_play): Initialize a variable to 0, to prevent undefined
2140 behavior (Bug#8278).
50060332 2141
c4fc4e30
PE
2142 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2143
918436ed
PE
2144 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2145
c939f91b
PE
2146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2147 clobbering (Bug#8298).
b9c7f648
PE
2148 * sysdep.c (sys_subshell): Likewise.
2149 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2150
6bd8c144
PE
2151 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2152 This should get cleaned up, so that child_setup has the
2153 same signature on all platforms.
2154
7710357c 2155 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2156 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2157
c59da222
CY
21582011-03-22 Chong Yidong <cyd@stupidchicken.com>
2159
2160 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2161 not to be necessary, and produces flickering.
2162
66b87493
GM
21632011-03-20 Glenn Morris <rgm@gnu.org>
2164
2165 * config.in: Remove file.
2166
45b6f6d5
JB
21672011-03-20 Juanma Barranquero <lekktu@gmail.com>
2168
2169 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2170 are now in src/globals.h.
2171 (syms_of_minibuf): Remove spurious & from previous change.
2172
3ec03f7e
LL
21732011-03-20 Leo <sdl.web@gmail.com>
2174
2175 * minibuf.c (completing-read-function): New variable.
2176 (completing-read-default): Rename from completing-read.
2177 (completing-read): Call completing-read-function.
2178
b14e3e21
CY
21792011-03-19 Juanma Barranquero <lekktu@gmail.com>
2180
2181 * xfaces.c (Fx_load_color_file):
2182 Read color file from absolute filename (bug#8250).
2183
f2b726e6
JB
21842011-03-19 Juanma Barranquero <lekktu@gmail.com>
2185
2186 * makefile.w32-in: Update dependencies.
2187
09f6ff02
EZ
21882011-03-17 Eli Zaretskii <eliz@gnu.org>
2189
2190 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2191
29a6015a
PE
21922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2193
a3a6c54e
PE
2194 Fix more problems found by GCC 4.5.2's static checks.
2195
b766f867
PE
2196 * process.c (make_serial_process_unwind, send_process_trap):
2197 (sigchld_handler): Now static.
2198
be02381c
PE
2199 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2200 That way, the code declares only the vars that it needs.
2201 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2202 * s/cygwin.h (PTY_ITERATION): Likewise.
2203 * s/darwin.h (PTY_ITERATION): Likewise.
2204 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2205
57048744
PE
2206 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2207 * process.c (allocate_pty): Don't declare stb unless it's needed.
2208
7914961c 2209 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2210 (CONSTANTLIM): Remove; unused.
2211 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2212 Define only if needed.
7914961c 2213
b3967b18
PE
2214 * unexelf.c (unexec): Name an expression,
2215 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2216 Use a different way to cause a compilation error if anyone uses
2217 n rather than nn, a way that does not involve shadowing.
73366a00 2218 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2219
29a6015a
PE
2220 * deps.mk (unexalpha.o): Remove; unused.
2221
43cfc33e 2222 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2223 * unexec.h: New file.
ce701a33
PE
2224 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2225 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2226 Depend on unexec.h.
2227 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2228 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2229 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2230 Change as necessary to match prototype in unexec.h.
ce701a33 2231
01f44d5a
PE
2232 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2233 shadowing.
4f63c6bb 2234 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2235
a6670b0b
PE
2236 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2237 Rename locals to avoid shadowing.
2238
cef2010d 2239 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2240 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2241
d4d7173a
PE
2242 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2243
f08b802a
PE
2244 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2245 warning when compiling print.c.
2246
3ddb0639
PE
2247 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2248 instead of using an uninitialized var.
5ad03b97 2249 (font_sort_entities): Mark var as initialized.
3ddb0639 2250
170a2692
PE
2251 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2252
e663c700
PE
2253 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2254 pointers to constants.
89bc529a 2255 (font_parse_fcname): Remove unused vars.
7b81e2d0 2256 (font_delete_unmatched): Now static.
ea838e10 2257 (font_get_spec): Remove; unused.
13a547c6
PE
2258 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2259 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2260 Rename or move locals to avoid shadowing.
e663c700 2261
2a80c887 2262 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2263 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2264
1384fa33 2265 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2266 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2267
8b2c52e9
PE
2268 * alloc.c (mark_backtrace): Move decl from here ...
2269 * lisp.h: ... to here, so that it can be checked.
2270
475545b5 2271 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2272 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2273 (lisp_indirect_variable): Name an expression,
2274 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2275 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2276
b1349114 2277 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2278 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2279 Use const pointer when appropriate.
b1349114 2280
a2928364
PE
2281 * lisp.h (get_system_name, get_operating_system_release):
2282 Move decls here, to check interfaces.
2283 * process.c (get_operating_system_release): Move decl to lisp.h.
2284 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2285 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2286 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2287 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2288 (Fformat_time_string, Fencode_time, Finsert_char):
2289 (Ftranslate_region_internal, Fformat):
2290 Rename or remove local vars to avoid shadowing.
9710023e 2291 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2292
a415e694
PE
2293 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2294 avoid shadowing.
2295
8ef4622d
PE
2296 * lisp.h (eassert): Check that the argument compiles, even if
2297 ENABLE_CHECKING is not defined.
2298
946f9a5b
PE
2299 * data.c (Findirect_variable): Name an expression, to avoid
2300 gcc -Wbad-function-cast warning.
112396d6 2301 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2302 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2303 (Fmake_variable_buffer_local, Fmake_local_variable):
2304 Mark variables as initialized.
52746918 2305 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2306
e5aab7e7 2307 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2308 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2309 Rename locals to avoid shadowing.
dff45157
PE
2310 (mark_stack): Move local variables into the #ifdef region where
2311 they're used.
7bc26fdb
PE
2312 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2313 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2314 needed otherwise.
2315 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2316 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2317 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2318
e5aab7e7
PE
2319 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2320 avoids undefined behavior in theory.
2321
4da60324
PE
2322 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2323
88043301
PE
2324 Use functions, not macros, for up- and down-casing (Bug#8254).
2325 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2326 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2327 to use the following functions instead of these macros.
2328 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2329 EMACS_INT, since callers assume the returned value fits in int.
2330 (upcase1): Likewise, for UPCASE_TABLE.
2331 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2332 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2333 the race-condition problem in the old DOWNCASE.
88043301 2334
19ed5445
PE
2335 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2336 Rename locals to avoid shadowing.
2337 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2338 (regex_compile, re_search_2, re_match_2_internal):
2339 Remove unused local vars.
952db0d7
PE
2340 (FREE_VAR): Rewrite so as not to use empty "else",
2341 which gcc can warn about.
da053e48 2342 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2343 (RETALLOC_IF): Define only if needed.
2344 (WORDCHAR_P): Likewise. This one is never needed, but is used
2345 only in a comment talking about a compiler bug, so put inside
2346 the #if 0 of that comment.
2347 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2348 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2349 Remove; unused.
19ed5445 2350
1f3561e4 2351 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2352 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2353 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2354
ded6f8f7
PE
2355 * search.c (simple_search): Remove unused var.
2356
dbd37a95
PE
2357 * dired.c (compile_pattern): Move decl from here ...
2358 * lisp.h: ... to here, so that it can be checked.
2359 (struct re_registers): New forward decl.
2360
7e47afad
PE
2361 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2362
85f24f61
PE
2363 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2364 All uses changed.
2365 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2366 Rename locals to avoid shadowing.
5671df8f 2367 (Fvertical_motion): Mark locals as initialized.
85f24f61 2368
181aa2be 2369 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2370 (casify_region): Mark local as initialized.
181aa2be 2371
930d429c
PE
2372 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2373
7082eac6
PE
2374 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2375 New macros, so that the caller can use some names other than
2376 gcpro1, gcpro2, etc.
2377 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2378 of the new macros.
2379 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2380 argument, for consistency with GCPRO2_VAR, etc: it is now the
2381 prefix of the variable, not the variable itself. All uses
2382 changed.
38b2c076
PE
2383 * dired.c (directory_files_internal, file_name_completion):
2384 Rename locals to avoid shadowing.
2385
15206ed9
PE
2386 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2387 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2388 dired.c's scmp function, had undefined behavior.
2389 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2390 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2391 * buffer.h: ... to here, because these macros use current_buffer,
2392 and the new implementation with inline functions needs to have
2393 current_buffer in scope now, rather than later when the macros
2394 are used.
2395 (downcase, upcase1): New static inline functions.
2396 (DOWNCASE, UPCASE1): Reimplement using these functions.
2397 This avoids undefined behavior in expressions like
2398 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2399 from race conditions in accessing the global variables
2400 case_temp1 and case_temp2.
2401 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2402 * lisp.h (case_temp1, case_temp2): Remove their decls.
2403 * character.h (ASCII_CHAR_P): Move from here ...
2404 * lisp.h: ... to here, so that the inline functions mentioned
2405 above can use them.
2406
4a6bea26
PE
2407 * dired.c (directory_files_internal_unwind): Now static.
2408
f14b7e14
PE
2409 * fileio.c (file_name_as_directory, directory_file_name):
2410 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2411 Now static.
2893f146
PE
2412 (file_name_as_directory): Use const pointers when appropriate.
2413 (Fexpand_file_name): Likewise. In particular, newdir might
2414 point at constant storage, so make it a const pointer.
fd4ead52 2415 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2416 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2417 signedness issues.
f839df0c
PE
2418 (Fset_file_times, Finsert_file_contents, auto_save_error):
2419 Rename locals to avoid shadowing.
f14b7e14 2420
5716756e 2421 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2422 (Ftry_completion, Fall_completions): Rename or remove locals
2423 to avoid shadowing.
5716756e 2424
b4c3046a
PE
2425 * marker.c (bytepos_to_charpos): Remove; unused.
2426
b45db522
PE
2427 * lisp.h (verify_bytepos, count_markers): New decls,
2428 so that gcc does not warn that these functions aren't declared.
2429
85876d07
PE
2430 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2431 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2432 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2433 (copy_text): Remove unused local var.
85876d07 2434
03d78a21 2435 * filelock.c (within_one_second): Now static.
b3dd38ab 2436 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2437
5df8f01b
PE
2438 * buffer.c (fix_overlays_before): Mark locals as initialized.
2439 (fix_start_end_in_overlays): Likewise. This function should be
2440 simplified by using pointers-to-pointers, but that's a different
2441 matter.
b1d876f1 2442 (switch_to_buffer_1): Now static.
8f54f30a
PE
2443 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2444 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2445
a70072c9 2446 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2447 Fix pointer signedness issue.
edced198
PE
2448 (sys_subshell): Mark local as volatile if checking for lint,
2449 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2450 (MAXPATHLEN): Define only if needed.
a70072c9 2451
a0977c44
PE
2452 * process.c (serial_open, serial_configure): Move decls from here ...
2453 * systty.h: ... to here, so that they can be checked.
2454
a884fdcc
PE
2455 * fns.c (get_random, seed_random): Move extern decls from here ...
2456 * lisp.h: ... to here, so that they can be checked.
2457
604efe86 2458 * sysdep.c (reset_io): Now static.
b8950c94 2459 (wait_for_termination_signal): Remove; unused.
604efe86 2460
38fc62d9
PE
2461 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2462 (copy_keymap_item, append_key, push_text_char_description):
2463 Now static.
1004a21a 2464 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2465 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2466 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2467 (describe_map_tree):
2468 Rename locals to avoid shadowing.
38fc62d9 2469
2f2650da
PE
2470 * keyboard.c: Declare functions static if they are not used elsewhere.
2471 (echo_char, echo_dash, cmd_error, top_level_2):
2472 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2473 (read_char, kbd_buffer_get_event, make_lispy_position):
2474 (make_lispy_event, make_lispy_movement, apply_modifiers):
2475 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2476 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2477 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2478 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2479 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2480
a053e86c 2481 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2482 (mark_kboards): Move decl here ...
2483 * alloc.c (mark_kboards): ... from here.
a053e86c 2484
4752793e
PE
2485 * lisp.h (force_auto_save_soon): New decl.
2486
74f10ca7 2487 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2488 (DEFINE_DUMMY_FUNCTION): New macro.
2489 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2490 Use it.
c03cd23f
PE
2491 (main): Add casts to avoid warnings
2492 if GCC considers string literals to be constants.
74f10ca7 2493
022e70d4
PE
2494 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2495
59d6fe83
PE
2496 * dbusbind.c: Pointer signedness fixes.
2497 (xd_signature, xd_append_arg, xd_initialize):
2498 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2499 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2500 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2501 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2502
78320123
PE
2503 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2504 if GCC considers string literals to be constants.
49cebcca 2505 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2506
35ac2a97
SM
25072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2508
fb103ca9
SM
2509 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2510 (print_preprocess, print_object): New macro to fix last change.
2511
35ac2a97
SM
2512 * print.c (print_preprocess): Don't forget font objects.
2513
62973b41
JB
25142011-03-16 Juanma Barranquero <lekktu@gmail.com>
2515
2516 * emacs.c (USAGE3): Doc fixes.
2517
0e48bb22
AS
25182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2519
2520 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2521 structure.
2522
7684e57b
JB
25232011-03-14 Juanma Barranquero <lekktu@gmail.com>
2524
2525 * lisp.h (VWindow_system, Qfile_name_history):
2526 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2527 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2528 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2529
2530 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2531 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2532
2533 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2534 * w32console.c (detect_input_pending, read_input_pending)
2535 (encode_terminal_code):
2536 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2537 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2538 (w32_system_caret_y, Qfile_name_history):
2539 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2540 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2541 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2542 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2543 * w32proc.c (Qlocal, report_file_error):
2544 * w32term.c (Vwindow_system, updating_frame):
2545 * w32uniscribe.c (initialized, uniscribe_font_driver):
2546 Remove unneeded extern declarations.
2547
2aa46d6c
CY
25482011-03-14 Chong Yidong <cyd@stupidchicken.com>
2549
c96bbc66 2550 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2551
cffc6f3b
CY
25522011-03-13 Chong Yidong <cyd@stupidchicken.com>
2553
2554 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2555 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2556 These macros can no longer be used for assignment.
2557
44f230aa
SM
2558 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2559 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2560 (record_buffer_markers, fetch_buffer_markers): New functions for
2561 recording and fetching special buffer markers.
2562 (set_buffer_internal_1, set_buffer_temp): Use them.
2563
2564 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2565
2566 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2567
2568 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2569 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2570
2571 * xdisp.c (hscroll_window_tree):
2572 (reconsider_clip_changes): Use PT instead of BUF_PT.
2573
d251f04b
EZ
25742011-03-13 Eli Zaretskii <eliz@gnu.org>
2575
2576 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2577 $(EMACS_ROOT)/lib/intprops.h.
2578
f0c77cd1
PE
25792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2580
3eca4629
PE
2581 Fix more problems found by GCC 4.5.2's static checks.
2582
7c86ee98
PE
2583 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2584 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2585 (xg_free_frame_widgets): Make it clear that a local variable is
2586 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2587 (gdk_window_get_screen): Make it clear that this macro is needed
2588 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2589 (int_gtk_range_get_value): New function, which avoids a diagnostic
2590 from gcc -Wbad-function-cast.
2591 (xg_set_toolkit_scroll_bar_thumb): Use it.
2592 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2593 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2594 (get_utf8_string, xg_get_file_with_chooser):
2595 Rename locals to avoid shadowing.
2596 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2597
41729b81
PE
2598 * xgselect.c (xg_select): Remove unused var.
2599
f0c77cd1
PE
2600 * image.c (four_corners_best): Mark locals as initialized.
2601 (gif_load): Initialize transparent_p to zero (Bug#8238).
2602 Mark another local as initialized.
ec6cf4c6 2603 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2604
ce0ad53d 2605 * image.c (clear_image_cache): Now static.
d5d5a617 2606 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2607 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2608 (x_edge_detection): Remove unnecessary cast that
2609 gcc -Wbad-function-cast diagnoses.
2037898d 2610 (gif_load): Fix pointer signedness.
6ae141d6
PE
2611 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2612 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2613
33383987 26142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2615
d32df629
PE
2616 Improve quality of tests for time stamp overflow.
2617 For example, without this patch (encode-time 0 0 0 1 1
2618 1152921504606846976) returns the obviously-bogus value (-948597
2619 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2620 reports time overflow. See
2621 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2622 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2623 * editfns.c: Include limits.h and intprops.h.
2624 (TIME_T_MIN, TIME_T_MAX): New macros.
2625 (time_overflow): Move earlier, to before first use.
2626 (hi_time, lo_time): New functions, for an accurate test for
2627 out-of-range times.
2628 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2629 (Fget_internal_run_time): Don't assume time_t fits in int.
2630 (make_time): Use list2 instead of Fcons twice.
2631 (Fdecode_time): More accurate test for out-of-range times.
2632 (check_tm_member): New function.
2633 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2634 (lisp_time_argument): Don't rely on undefined left-shift and
2635 right-shift behavior when checking for time stamp overflow.
8be6f318 2636
fe31d94c
PE
2637 * editfns.c (time_overflow): New function, refactoring common code.
2638 (Fformat_time_string, Fdecode_time, Fencode_time):
2639 (Fcurrent_time_string): Use it.
2640
8be6f318
PE
2641 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2642 * dired.c (make_time): Move to ...
2643 * editfns.c (make_time): ... here.
2644 * systime.h: Note the move.
2645
09d9db2c 26462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2647
126bc0dc
YM
2648 * fringe.c (update_window_fringes): Remove unused variables.
2649
c47cbdfd
YM
2650 * unexmacosx.c (copy_data_segment): Also copy __got section.
2651 (Bug#8223)
2652
7ac80be9
EZ
26532011-03-12 Eli Zaretskii <eliz@gnu.org>
2654
c96bbc66 2655 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2656 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2657 Constify `char *' arguments and their references according to
2658 prototypes in tparam.h.
2659
ecb0f94d 2660 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2661
7ac80be9
EZ
2662 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2663 Adapt all references accordingly.
2664
2665 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2666
ef1fd07e
TT
26672011-03-11 Tom Tromey <tromey@redhat.com>
2668
2669 * buffer.c (syms_of_buffer): Remove obsolete comment.
2670
7ef4b50c
EZ
26712011-03-11 Eli Zaretskii <eliz@gnu.org>
2672
2673 * termhooks.h (encode_terminal_code): Declare prototype.
2674
2675 * msdos.c (encode_terminal_code): Don't declare prototype.
2676
2677 * term.c (encode_terminal_code): Now external again, used by
2678 w32console.c and msdos.c.
2679
44f230aa
SM
2680 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2681 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2682
4b1ec863 26832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2684
1714f52b 2685 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2686
4b1ec863
PE
2687 * fringe.c (update_window_fringes): Mark locals as initialized
2688 (Bug#8227).
2689 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2690
524c7aa6
PE
2691 * alloc.c (mark_fringe_data): Move decl from here ...
2692 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2693 to check its interface.
2694 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2695
a5c0af81 2696 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2697 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2698 (fontset_font): Mark local as initialized.
a9a06e0b 2699 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2700
b4716021
PE
2701 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2702
811e9bac 2703 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2704 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2705 (x_own_selection, Fx_disown_selection_internal): Rename locals
2706 to avoid shadowing.
2707 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2708
7e3ab302
PE
2709 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2710 so that the caller can use some name other than gcpro1.
2711 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2712 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2713 (Fx_backspace_delete_keys_p):
2714 Use them to avoid shadowing, and rename vars to avoid shadowing.
2715 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2716 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2717 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2718 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2719 Remove unused locals.
7e3ab302
PE
2720 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2721 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2722 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2723 macros.
f78faa98 2724
e2b13473
PE
2725 * xterm.h (x_mouse_leave): New decl.
2726
77f23912
PE
2727 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2728 Remove unused functions.
cdf4ba58
PE
2729 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2730 (x_calc_absolute_position): Now static.
7411c686 2731 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2732 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2733 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2734 unless they are used.
38d0b34a
PE
2735 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2736 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2737 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2738 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2739 (x_error_catcher, x_connection_closed, x_error_handler):
2740 (x_error_quitter, xembed_send_message, x_iconify_frame):
2741 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2742 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2743 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2744
44f230aa
SM
2745 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2746 Rename or move locals to avoid shadowing.
6b463e58 2747 (tty_defined_color, merge_face_heights): Now static.
5967d051 2748 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2749 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2750 does not deduce is never used uninitialized.
73719eba
PE
2751 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2752 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2753
426994c3 2754 * terminal.c (store_terminal_param): Now static.
5489860b 2755
032f1620 2756 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2757 (set_frame_menubar): Remove unused local.
d4323972 2758 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2759 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2760 since they might point to immutable storage.
281585b0
PE
2761 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2762 since it's unused otherwise.
032f1620 2763
367c19e5 2764 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2765 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2766 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2767 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2768 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2769 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2770 does not deduce are never used uninitialized.
70739cbe 2771
07b48fa9
PE
2772 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2773
8868a238 2774 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2775 * window.c (window_loop, size_window):
2776 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2777
7e5cf297 2778 * window.c (display_buffer): Now static.
d6550a9f
PE
2779 (size_window): Mark variables that gcc -Wuninitialized
2780 does not deduce are never used uninitialized.
a586633d
PE
2781 * window.h (check_all_windows): New decl, to forestall
2782 gcc -Wmissing-prototypes diagnostic.
5b555da1 2783 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2784
f6095868
PE
2785 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2786 shadowing.
2787 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2788 Include <limits.h>.
2789 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2790 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2791 (load_charset_map): Mark variables that gcc -Wuninitialized
2792 does not deduce are never used uninitialized.
53df7c11 2793 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2794
f38b440c
PE
2795 * coding.c (coding_set_source, coding_set_destination):
2796 Use "else { /* comment */ }" rather than "else /* comment */;"
2797 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2798 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2799 a block, when the outer 'i' will do.
2800 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2801 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2802 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2803 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2804 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2805 Rename locals to avoid shadowing.
2806 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2807 * coding.c (emacs_mule_char, encode_invocation_designation):
2808 Now static, since they're not used elsewhere.
413bb2db 2809 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2810 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2811 (decode_coding_emacs_mule): Mark variables that gcc
2812 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2813 (detect_coding_iso_2022): Initialize a local variable that might
2814 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2815 this initialization is needed. (Bug#8211)
5f58e762
PE
2816 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2817 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2818 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2819 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2820 Remove unused macros.
f38b440c 2821
232b38b9 2822 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2823 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2824 * character.c (string_count_byte8): Likewise.
232b38b9 2825
fb90da1b
PE
2826 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2827 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2828
fb93dbc2
PE
2829 * chartab.c (copy_sub_char_table): Now static, since it's not used
2830 elsewhere.
5c156ace
PE
2831 (sub_char_table_ref_and_range, char_table_ref_and_range):
2832 Rename locals to avoid shadowing.
bbcd0949 2833 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2834
7d3b3862 2835 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2836 (BIDI_BOB): Remove unused macro.
7d3b3862 2837
6be7d3da
PE
2838 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2839 deduce are never used uninitialized.
c2ed9c8b 2840 * term.c (encode_terminal_code): Likewise.
6be7d3da 2841
75f8807f 2842 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2843
50938595
PE
2844 * tparam.h: New file.
2845 * term.c, tparam.h: Include it.
2846 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2847 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2848 Move these decls to tparam.h, and make them agree with what
2849 is actually in tparam.c. The previous trick of using incompatible
2850 decls in different modules does not conform to the C standard.
2851 All callers of tparam changed to use tparam's actual API.
2852 * tparam.c (tparam1, tparam, tgoto):
2853 Use const pointers where appropriate.
2854
fbceeba2
PE
2855 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2856 * cm.h (struct cm): Likewise.
2857 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2858 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2859 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2860 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2861 (turn_on_face, init_tty): Likewise.
2862 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2863
7f3f1250
PE
2864 * term.c (term_mouse_position): Rename local to avoid shadowing.
2865
e6ca6543
PE
2866 * alloc.c (mark_ttys): Move decl from here ...
2867 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2868
c40f8d15
AS
28692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2870
2871 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2872
cfe0661d
JB
28732011-03-09 Juanma Barranquero <lekktu@gmail.com>
2874
2875 * search.c (compile_pattern_1): Remove argument regp, unused since
2876 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2877 (compile_pattern): Don't pass it.
2878
0afb4571
J
28792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2880
2881 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2882 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2883 for ! HAVE_GTK3.
2884 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2885
2886 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2887
2888 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2889 gdk_window_get_screen, gdk_window_get_geometry,
2890 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2891 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2892 (xg_get_pixbuf_from_pixmap): New function.
2893 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2894 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2895 Call xg_get_pixbuf_from_pixmap instead of
2896 gdk_pixbuf_get_from_drawable.
2897 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2898 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2899 (xg_check_special_colors): Use GtkStyleContext and its functions
2900 for HAVE_GTK3.
2901 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2902 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2903 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2904 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2905 Call gtk_widget_get_preferred_size.
0afb4571
J
2906 (xg_frame_resized): gdk_window_get_geometry only takes 5
2907 parameters.
44f230aa
SM
2908 (xg_win_to_widget, xg_event_is_for_menubar):
2909 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2910 (xg_set_widget_bg): New function.
2911 (delete_cb): New function.
895009e1 2912 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2913 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2914 (xg_set_background_color): Call xg_set_widget_bg.
2915 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2916 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2917 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2918 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2919 if ! HAVE_GTK3.
2920 (update_frame_tool_bar): Call gtk_widget_hide.
2921 (xg_initialize): Use GDK_KEY_g.
2922
2923 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2924 if ! HAVE_GTK3
2925 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2926
2927 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2928 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2929 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2930
1c2cc4ef
JB
29312011-03-08 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * w32xfns.c (select_palette): Check success of RealizePalette against
2934 GDI_ERROR, not zero.
2935
33383987 2936See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2937
2938;; Local Variables:
2939;; coding: utf-8
aac0c6e3
MR
2940;; End:
2941
33383987 2942 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2943
2944 This file is part of GNU Emacs.
2945
2946 GNU Emacs is free software: you can redistribute it and/or modify
2947 it under the terms of the GNU General Public License as published by
2948 the Free Software Foundation, either version 3 of the License, or
2949 (at your option) any later version.
2950
2951 GNU Emacs is distributed in the hope that it will be useful,
2952 but WITHOUT ANY WARRANTY; without even the implied warranty of
2953 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2954 GNU General Public License for more details.
2955
2956 You should have received a copy of the GNU General Public License
2957 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.