1 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3 Implement dynamic loading of GnuTLS on Windows.
5 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10 * gnutls.c (Qgnutls_dll): Define.
11 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12 (gnutls_*): Declare function pointers.
13 (init_gnutls_functions): New function to initialize function pointers.
14 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
16 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
17 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
18 (emacs_gnutls_write, emacs_gnutls_read)
19 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
20 (Fgnutls_available_p): New function.
21 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
22 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
23 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
25 * image.c: Include w32.h.
26 (Vimage_type_cache): Delete.
27 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
28 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
29 (w32_delayed_load): Move to w32.c.
31 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
33 * w32.c (QCloaded_from, Vlibrary_cache): Define.
34 (w32_delayed_load): Move from image.c. When loading a library, record
35 its filename in the :loaded-from property of the library id.
36 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
37 Initialize and staticpro them.
38 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
40 * process.c: Include lisp.h before w32.h, not after.
41 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
42 instead of gnutls_record_check_pending.
44 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
46 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
48 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
49 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
52 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
54 * xterm.c (x_set_frame_alpha): Do not set property on anything
55 else than FRAME_X_OUTER_WINDOW (Bug#8608).
57 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
59 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
61 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
63 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
64 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
65 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
66 (gnutls_global_initialized, Qgnutls_bootprop_priority)
67 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
68 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
69 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
70 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
71 (Qgnutls_bootprop_callbacks_verify): Make static.
73 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
75 * callproc.c: Indentation fixup.
77 * sysdep.c (wait_for_termination_1): Make static.
78 (wait_for_termination, interruptible_wait_for_termination): Move
79 after wait_for_termination_1.
81 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
83 * sysdep.c (interruptible_wait_for_termination): New function
84 which is like wait_for_termination, but allows keyboard
87 * callproc.c (Fcall_process): Add (:file "file") as an option for
89 (Fcall_process_region): Ditto.
91 2011-04-30 Eli Zaretskii <eliz@gnu.org>
93 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
94 rather than `XVECTOR (FOO)->size'.
96 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
97 inttypes.h, as a gnulib replacement is used if it not available in
100 2011-04-21 Eli Zaretskii <eliz@gnu.org>
102 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
103 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
104 of MOST_POSITIVE_FIXNUM. (Bug#8528)
106 * coding.c (coding_alloc_by_realloc): Error out if destination
107 will grow beyond MOST_POSITIVE_FIXNUM.
108 (decode_coding_emacs_mule): Abort if there isn't enough place in
109 charbuf for the composition carryover bytes. Reserve an extra
110 space for up to 2 characters produced in a loop.
111 (decode_coding_iso_2022): Abort if there isn't enough place in
112 charbuf for the composition carryover bytes.
114 2011-04-21 Eli Zaretskii <eliz@gnu.org>
116 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
117 aborting when %lld or %lll format is passed.
118 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
119 %llo or %llx format is passed. (Bug#8545)
121 * window.c (window_scroll_line_based): Use a marker instead of
122 simple variables to record original value of point. (Bug#7952)
124 * doprnt.c (doprnt): Fix the case where a multibyte sequence
125 produced by %s or %c overflows available buffer space. (Bug#8545)
127 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
129 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
130 (SIZE_MAX): Move defn after all includes, as they might #define it.
132 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
134 * w32.c (init_environment): Warn about defaulting HOME to C:\.
136 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
138 * keyboard.c (Qdelayed_warnings_hook): Define.
139 (command_loop_1): Run `delayed-warnings-hook'
140 if Vdelayed_warnings_list is non-nil.
141 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
142 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
144 2011-04-28 Eli Zaretskii <eliz@gnu.org>
146 * doprnt.c (doprnt): Don't return value smaller than the buffer
147 size if the message was truncated. (Bug#8545).
149 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
151 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
152 (Fx_window_property): #if-0 the whole functions, not just the bodies.
154 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
156 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
158 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
160 * makefile.w32-in: Update dependencies.
162 2011-04-27 Eli Zaretskii <eliz@gnu.org>
164 Improve `doprnt' and its usage. (Bug#8545)
165 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
166 `format_end'. Remove support for %l as a conversion specifier.
167 Don't use xrealloc. Improve diagnostics when the %l size modifier
168 is used. Update the commentary.
170 * eval.c (verror): Simplify calculation of size_t.
172 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
175 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
177 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
180 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
182 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
183 This makes this file independent of the recent pseudovector change.
185 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
187 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
189 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
190 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
192 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
194 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
195 GCC 4.6.0 optimizes based on type-based alias analysis. For
196 example, if b is of type struct buffer * and v of type struct
197 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
198 != &v->size, and therefore "v->size = 1; b->size = 2; return
199 v->size;" must therefore return 1. This assumption is incorrect
200 for Emacs, since it type-puns struct Lisp_Vector * with many other
201 types. To fix this problem, this patch adds a new type struct
202 vectorlike_header that documents the constraints on layout of vectors
203 and pseudovectors, and helps optimizing compilers not get fooled
204 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
205 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
206 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
208 (XSETPVECTYPE): Rewrite in terms of new macro.
209 (XSETPVECTYPESIZE): New macro, specifying both type and size.
210 This is a bit clearer, and further avoids the possibility of
211 undesirable aliasing.
212 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
213 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
214 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
215 since Lisp_Subr is a special case (no "next" field).
216 (ASIZE): Now uses header.size rather than size. All
217 previous uses of XVECTOR (foo)->size replaced to use this macro,
218 to avoid the hassle of writing XVECTOR (foo)->header.size.
219 (struct vectorlike_header): New type.
220 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
221 object, to help avoid aliasing.
222 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
223 (SUBRP): Likewise, since Lisp_Subr is a special case.
224 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
225 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
226 (struct Lisp_Hash_Table): Combine first two members into a single
227 struct vectorlike_header member. All uses of "size" and "next" members
228 changed to be "header.size" and "header.next".
229 * buffer.h (struct buffer): Likewise.
230 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
231 * frame.h (struct frame): Likewise.
232 * process.h (struct Lisp_Process): Likewise.
233 * termhooks.h (struct terminal): Likewise.
234 * window.c (struct save_window_data, struct saved_window): Likewise.
235 * window.h (struct window): Likewise.
236 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
237 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
238 * buffer.c (init_buffer_once): Likewise.
239 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
241 * process.c (Fformat_network_address): Use local var for size,
244 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
246 Make the Lisp reader and string-to-float more consistent (Bug#8525)
247 * data.c (atof): Remove decl; no longer used or needed.
248 (digit_to_number): Move to lread.c.
249 (Fstring_to_number): Use new string_to_number function, to be
250 consistent with how the Lisp reader treats infinities and NaNs.
251 Do not assume that floating-point numbers represent EMACS_INT
252 without losing information; this is not true on most 64-bit hosts.
253 Avoid double-rounding errors, by insisting on integers when
254 parsing non-base-10 numbers, as the documentation specifies.
255 * lisp.h (string_to_number): New decl, replacing ...
256 (isfloat_string): Remove.
257 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
258 (read1): Do not accept +. and -. as integers; this
259 appears to have been a coding error. Similarly, do not accept
260 strings like +-1e0 as floating point numbers. Do not report
261 overflow for integer overflows unless the base is not 10 which
262 means we have no simple and reliable way to continue.
263 Break out the floating-point parsing into a new
264 function string_to_number, so that Fstring_to_number parses
265 floating point numbers consistently with the Lisp reader.
266 (digit_to_number): Moved here from data.c. Make it static inline.
267 (E_CHAR, EXP_INT): Remove, replacing with ...
268 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
269 (string_to_number): New function, replacing isfloat_string.
270 This function checks for valid syntax and produces the resulting
271 Lisp float number too. Rework it so that string-to-number
272 no longer mishandles examples like "1.0e+". Use strtoumax,
273 so that overflow for non-base-10 numbers is reported only when
274 there's no portable and simple way to convert to floating point.
276 * textprop.c (set_text_properties_1): Rewrite for clarity,
277 and to avoid GCC warning about integer overflow.
279 * intervals.h (struct interval): Use EMACS_INT for members
280 where EMACS_UINT might cause problems. See
281 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
282 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
283 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
285 (offset_intervals): Tell GCC not to worry about length overflow
286 when negating a negative length.
288 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
289 (overrun_check_free): Likewise.
291 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
292 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
295 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
296 (gnutls_make_error): Rename local to avoid shadowing.
297 (gnutls_emacs_global_deinit): ifdef out; not used.
298 (Fgnutls_boot): Use const for pointer to readonly storage.
299 Comment out unused local. Fix pointer signedness problems.
301 * lread.c (openp): Don't stuff size_t into an 'int'.
302 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
303 about possible signed overflow.
305 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
306 (GDK_KEY_g): Don't define if already defined.
307 (xg_prepare_tooltip): Avoid pointer signedness problem.
308 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
310 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
311 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
313 * xfns.c (Fx_window_property): Simplify a bit,
314 to make a bit faster and to avoid GCC 4.6.0 warning.
315 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
317 * fns.c (internal_equal): Don't assume size_t fits in int.
319 * alloc.c (compact_small_strings): Tighten assertion a little.
321 Replace pEd with more-general pI, and fix some printf arg casts.
322 * lisp.h (pI): New macro, generalizing old pEd macro to other
323 conversion specifiers. For example, use "...%"pI"d..." rather
325 (pEd): Remove. All uses replaced with similar uses of pI.
326 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
327 * alloc.c (check_pure_size): Don't overflow by converting size to int.
328 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
329 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
330 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
331 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
332 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
334 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
335 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
336 * print.c (safe_debug_print, print_object): Likewise.
337 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
339 Use pI instead of if-then-else-abort. Use %p to avoid casts,
340 avoiding the 0 flag, which is not portable.
341 * process.c (Fmake_network_process): Use pI to avoid cast.
342 * region-cache.c (pp_cache): Likewise.
343 * xdisp.c (decode_mode_spec): Likewise.
344 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
345 behavior on 64-bit hosts with printf arg.
346 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
347 (x_stop_queuing_selection_requests): Likewise.
348 (x_get_window_property): Don't truncate byte count to an 'int'
351 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
352 here, since it parses constructs like leading '-' and spaces,
353 which are not wanted; and it overflows with large numbers.
354 Instead, simply match F[0-9]+, which is what is wanted anyway.
356 * alloc.c: Remove unportable assumptions about struct layout.
357 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
358 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
359 (allocate_vectorlike, make_pure_vector): Use the new macros,
360 plus offsetof, to remove unportable assumptions about struct layout.
361 These assumptions hold on all porting targets that I know of, but
362 they are not guaranteed, they're easy to remove, and removing them
363 makes further changes easier.
365 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
366 This doesn't fix a bug but makes the code clearer.
367 (string_overrun_cookie): Now const. Use initializers that
368 don't formally overflow signed char, to avoid warnings.
369 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
370 can cause Emacs to crash when string overrun checking is enabled.
371 (allocate_buffer): Don't assume sizeof (struct buffer) is a
372 multiple of sizeof (EMACS_INT); it need not be, if
373 alignof(EMACS_INT) < sizeof (EMACS_INT).
374 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
376 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
378 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
380 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
382 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
383 supposed to be handshaking. (Bug#8556)
384 Reported by Paul Eggert <eggert@cs.ucla.edu>.
386 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
388 * lisp.h (Qdebug): List symbol.
389 * eval.c (Qdebug): Restore global linkage.
390 * keyboard.c (debug-on-event): New variable.
391 (handle_user_signal): Break into debugger when debug-on-event
392 matches the current signal symbol.
394 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
396 * alloc.c (check_sblock, check_string_bytes)
397 (check_string_free_list): Convert to standard C.
399 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
401 * w32.c (emacs_gnutls_push): Fix typo.
403 2011-04-25 Eli Zaretskii <eliz@gnu.org>
405 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
406 "cast to pointer from integer of different size".
408 Improve doprnt and its use in verror. (Bug#8545)
409 * doprnt.c (doprnt): Document the set of format control sequences
410 supported by the function. Use SAFE_ALLOCA instead of always
413 * eval.c (verror): Don't limit the buffer size at size_max-1, that
414 is one byte too soon. Don't use xrealloc; instead xfree and
417 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
419 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
422 * gnutls.c: Renamed global_initialized to
423 gnutls_global_initialized. Added internals for the
424 :verify-hostname-error, :verify-error, and :verify-flags
425 parameters of `gnutls-boot' and documented those parameters in the
426 docstring. Start callback support.
427 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
428 unless a fatal error occured. Call gnutls_alert_send_appropriate
429 on error. Return error code.
430 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
431 (emacs_gnutls_read): Likewise.
432 (Fgnutls_boot): Return handshake error code.
433 (emacs_gnutls_handle_error): New function.
434 (wsaerror_to_errno): Likewise.
436 * w32.h (emacs_gnutls_pull): Add prototype.
437 (emacs_gnutls_push): Likewise.
439 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
440 (emacs_gnutls_push): Likewise.
442 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
444 * process.c (wait_reading_process_output): Check if GnuTLS
445 buffered some data internally if no FDs are set for TLS
448 * makefile.w32-in (OBJ2): Add gnutls.$(O).
449 (LIBS): Link to USER_LIBS.
450 ($(BLD)/gnutls.$(0)): New target.
452 2011-04-24 Eli Zaretskii <eliz@gnu.org>
454 * xdisp.c (handle_single_display_spec): Rename the
455 display_replaced_before_p argument into display_replaced_p, to
456 make it consistent with the commentary. Fix typos in the
459 * textprop.c (syms_of_textprop): Remove dead code.
460 (copy_text_properties): Delete obsolete commentary about an
461 interface that was deleted long ago. Fix typos in the description
464 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
465 to changes in oldXMenu/XMenu.h from 2011-04-16.
466 <menu_help_message, prev_menu_help_message>: Constify.
467 (IT_menu_make_room): menu->help_text is now `const char **';
470 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
471 to changes in oldXMenu/XMenu.h from 2011-04-16.
472 (struct XMenu): Declare `help_text' `const char **'.
474 * xfaces.c <Qunspecified>: Make extern again.
476 * syntax.c: Include sys/types.h before including regex.h, as
479 * doc.c (get_doc_string): Improve the format passed to `error'.
481 * doprnt.c (doprnt): Improve commentary.
483 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
485 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
488 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
489 changes in globals.h immediately force recompilation.
490 (TAGS): Depend on $(CURDIR)/m/intel386.h and
491 $(CURDIR)/s/ms-w32.h.
492 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
494 * character.c (Fchar_direction): Function deleted.
495 (syms_of_character): Don't defsubr it.
496 <char-direction-table>: Deleted.
498 2011-04-23 Eli Zaretskii <eliz@gnu.org>
500 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
501 * doprnt.c: Include limits.h.
502 (SIZE_MAX): New macro.
503 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
504 local variables are now size_t instead of int or unsigned.
505 Improve overflow protection. Support `l' modifier for integer
506 conversions. Support %l conversion. Don't assume an EMACS_INT
507 argument for integer conversions and for %c.
509 * lisp.h (doprnt): Restore prototype.
511 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
514 * Makefile.in (base_obj): Add back doprnt.o.
516 * deps.mk (doprnt.o): Add back prerequisites.
517 (callint.o): Depend on character.h.
519 * eval.c (internal_lisp_condition_case): Include the handler
520 representation in the error message.
521 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
522 when breaking from the loop.
524 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
526 * callint.c (Fcall_interactively): When displaying error message
527 about invalid control letter, pass the character's codepoint, not
528 a pointer to its multibyte form. Improve display of the character
529 in octal and display also its hex code.
531 * character.c (char_string): Use %x to display the (unsigned)
532 codepoint of an invalid character, to avoid displaying a bogus
535 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
536 `error', not SYMBOL_NAME itself.
538 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
539 character arguments to `error'.
541 * charset.c (check_iso_charset_parameter): Fix incorrect argument
542 to `error' in error message about FINAL_CHAR argument. Make sure
543 FINAL_CHAR is a character, and use %c when it is passed as
546 2011-04-23 Eli Zaretskii <eliz@gnu.org>
548 * s/ms-w32.h (localtime): Redirect to sys_localtime.
550 * w32.c: Include <time.h>.
551 (sys_localtime): New function.
553 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
555 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
557 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
559 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
561 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
564 2011-04-19 Eli Zaretskii <eliz@gnu.org>
566 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
567 gl_state.e_property when gl_state.object is Qt.
569 * insdel.c (make_gap_larger): Remove limitation of buffer size
572 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
574 * xdisp.c (lookup_glyphless_char_display)
575 (produce_glyphless_glyph): Handle cons cell entry in
576 glyphless-char-display.
577 (Vglyphless_char_display): Document it.
579 * term.c (produce_glyphless_glyph): Handle cons cell entry in
580 glyphless-char-display.
582 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
584 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
586 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
588 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
589 definition for no-X builds.
591 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
593 Static checks with GCC 4.6.0 and non-default toolkits.
595 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
597 * process.c (keyboard_bit_set): Define only if SIGIO.
598 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
599 (send_process): Repair possible setjmp clobbering.
601 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
603 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
605 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
607 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
608 Define only if needed.
610 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
611 by pacifying GCC about it. Maybe it's time to retire it?
612 * xfaces.c (USG, __TIMEVAL__): Likewise.
614 * dispextern.h (struct redisplay_interface): Rename param
616 * termhooks.h (struct terminal): Likewise.
617 * xterm.c (xembed_send_message): Likewise.
619 * insdel.c (make_gap_smaller): Define only if
620 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
622 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
625 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
626 so that we aren't warned about unused symbols.
628 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
630 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
632 * xfns.c (x_real_positions): Mark locals as initialized.
634 * xmenu.c (xmenu_show): Don't use uninitialized vars.
636 * xterm.c: Fix problems found by static analysis with other toolkits.
637 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
638 (x_dispatch_event): Declare static if USE_GTK, and
639 define if USE_GTK || USE_X_TOOLKIT.
640 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
641 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
642 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
643 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
645 * xmenu.c (menu_help_callback): Pointer type fixes.
646 Use const pointers when pointing at readonly data. Avoid pointer
648 (FALSE): Remove unused macro.
649 (update_frame_menubar): Remove unused decl.
651 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
653 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
654 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
655 (single_menu_item): Rename local to avoid shadowing.
657 * keyboard.c (make_lispy_event): Remove unused local var.
659 * frame.c, frame.h (x_get_resource_string): Bring this back, but
660 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
662 * bitmaps: Change bitmaps from unsigned char back to the X11
663 compatible char. Avoid the old compiler warnings about
664 out-of-range initializers by using, for example, '\xab' rather
667 * xgselect.c (xgselect_initialize): Check vs interface
668 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
670 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
672 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
675 * fns.c (vector): Remove; this old hack is no longer needed.
677 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
679 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
681 * xrdb.c (x_load_resources): Omit unused local.
683 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
684 (x_window): Rename locals to avoid shadowing.
685 (USG): Use the kludged USG macro, to pacify gcc.
687 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
688 (x_term_init): Remove local to avoid shadowing.
690 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
692 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
693 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
695 2011-04-16 Eli Zaretskii <eliz@gnu.org>
697 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
699 Fix regex.c, syntax.c and friends for buffers > 2GB.
700 * syntax.h (struct gl_state_s): Declare character position members
703 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
705 * textprop.c (verify_interval_modification, interval_of): Declare
708 * intervals.c (adjust_intervals_for_insertion): Declare arguments
711 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
713 * indent.c (Fvertical_motion): Local variable it_start is now
716 * regex.c (re_match, re_match_2, re_match_2_internal)
717 (bcmp_translate, regcomp, regexec, print_double_string)
718 (group_in_compile_stack, re_search, re_search_2, regex_compile)
719 (re_compile_pattern, re_exec): Declare arguments and local
720 variables `size_t' and `ssize_t' and return values `regoff_t', as
722 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
723 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
724 <compile_stack_type>: `size' and `avail' are now `size_t'.
726 * regex.h <regoff_t>: Use ssize_t, not int.
727 (re_search, re_search_2, re_match, re_match_2): Arguments that
728 specify buffer/string position and length are now ssize_t and
729 size_t. Return type is regoff_t.
731 2011-04-16 Ben Key <bkey76@gmail.com>
733 * nsfont.m: Fixed bugs in ns_get_family and
734 ns_descriptor_to_entity that were caused by using free to
735 deallocate memory blocks that were allocated by xmalloc (via
736 xstrdup). This caused Emacs to crash when compiled with
737 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
738 --enable-checking=xmallocoverrun). xfree is now used to
739 deallocate these memory blocks.
741 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
743 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
745 emacs_write: Accept and return EMACS_INT for sizes.
746 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
748 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
749 Accept and return EMACS_INT.
750 (emacs_gnutls_write): Return the number of bytes written on
752 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
753 (emacs_read, emacs_write): Remove check for negative size, as the
754 Emacs source code has been audited now.
755 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
756 (emacs_read, emacs_write): Use it.
757 * process.c (send_process): Adjust to the new signatures of
758 emacs_write and emacs_gnutls_write. Do not attempt to store
759 a byte offset into an 'int'; it might overflow.
760 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
762 * sound.c: Don't assume sizes fit in 'int'.
763 (struct sound_device.period_size, alsa_period_size):
764 Return EMACS_INT, not int.
765 (struct sound_device.write, vox_write, alsa_write):
766 Accept EMACS_INT, not int.
767 (wav_play, au_play): Use EMACS_INT to store sizes and to
768 record read return values.
770 2011-04-15 Ben Key <bkey76@gmail.com>
772 * keyboard.c (Qundefined): Don't declare static since it is used
774 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
775 static since they are used in nsfont.m.
777 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
779 * process.c (Qprocessp): Don't declare static.
780 * lisp.h (Qprocessp): Declare again.
782 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
784 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
786 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
788 Improve C-level modularity by making more things 'static'.
790 Don't publish debugger-only interfaces to other modules.
791 * lisp.h (safe_debug_print, debug_output_compilation_hack):
792 (verify_bytepos, count_markers): Move decls to the only modules
794 * region-cache.h (pp_cache): Likewise.
795 * window.h (check_all_windows): Likewise.
796 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
798 * sysdep.c (croak): Now static, if
799 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
800 * syssignal.h (croak): Declare only if not static.
802 * alloc.c (refill_memory_reserve): Now static if
803 !defined REL_ALLOC || defined SYSTEM_MALLOC.
804 * lisp.h (refill_memory_reserve): Declare only if not static.
806 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
807 Define only if USE_LUCID.
809 * xrdb.c (x_customization_string, x_rm_string): Now static.
811 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
812 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
814 * xdisp.c (draw_row_with_mouse_face): Now static.
815 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
817 * window.h (check_all_windows): Mark externally visible.
819 * window.c (window_deletion_count): Now static.
821 * undo.c: Make symbols static if they're not exported.
822 (last_undo_buffer, last_boundary_position, pending_boundary):
825 * textprop.c (interval_insert_behind_hooks): Now static.
826 (interval_insert_in_front_hooks): Likewise.
828 * term.c: Make symbols static if they're not exported.
829 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
830 (max_frame_lines, tty_set_terminal_modes):
831 (tty_reset_terminal_modes, tty_turn_off_highlight):
832 (get_tty_terminal): Now static.
833 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
834 * termhooks.h (term_mouse_moveto): Do not declare if
836 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
837 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
839 * sysdep.c: Make symbols static if they're not exported.
840 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
842 (sigprocmask_set, full_mask): Remove; unused.
843 (wait_debugging): Mark as visible.
844 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
845 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
847 * syntax.c (syntax_temp): Define only if !__GNUC__.
849 * sound.c (current_sound_device, current_sound): Now static.
851 * search.c (searchbufs, searchbuf_head): Now static.
853 * scroll.c (scroll_cost): Remove; unused.
854 * dispextern.h (scroll_cost): Remove decl.
856 * region-cache.h (pp_cache): Mark as externally visible.
858 * process.c: Make symbols static if they're not exported.
859 (process_tick, update_tick, create_process, chan_process):
860 (Vprocess_alist, proc_buffered_char, datagram_access):
861 (fd_callback_data, send_process_frame, process_sent_to): Now static.
862 (deactivate_process): Mark defn as static, as well as decl.
863 * lisp.h (create_process): Remove decl.
864 * process.h (chan_process, Vprocess_alist): Remove decls.
866 * print.c: Make symbols static if they're not exported.
867 (print_depth, new_backquote_output, being_printed, print_buffer):
868 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
869 (print_interval, print_number_index, initial_stderr_stream):
871 * lisp.h (Fprinc): Remove decl.
872 (debug_output_compilation_hack): Mark as externally visible.
874 * sysdep.c (croak): Move decl from here to syssignal.h.
875 * syssignal.h (croak): Put it here, so the API can be checked when
876 'croak' is called from dissociate_if_controlling_tty.
878 * minibuf.c: Make symbols static if they're not exported.
879 (minibuf_save_list, choose_minibuf_frame): Now static.
880 * lisp.h (choose_minibuf_frame): Remove decl.
882 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
884 * lread.c: Make symbols static if they're not exported.
885 (read_objects, initial_obarray, oblookup_last_bucket_number):
887 (make_symbol): Remove; unused.
888 * lisp.h (initial_obarray, make_symbol): Remove decls.
890 * keyboard.c: Make symbols static if they're not exported.
891 (single_kboard, recent_keys_index, total_keys, recent_keys):
892 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
893 (this_single_command_key_start, echoing, last_auto_save):
894 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
895 (command_loop, echo_now, keyboard_init_hook, help_char_p):
896 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
897 (Vlispy_mouse_stem, double_click_count):
899 (force_auto_save_soon): Define only if SIGDANGER.
900 (ignore_mouse_drag_p): Now static if
901 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
902 (print_help): Remove; unused.
903 (stop_character, last_timer_event): Mark as externally visible.
904 * keyboard.h (ignore_mouse_drag_p): Declare only if
905 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
906 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
907 * lisp.h (echoing): Remove decl.
908 (force_auto_save_soon): Declare only if SIGDANGER.
909 * xdisp.c (redisplay_window): Simplify code, to make it more
910 obvious that ignore_mouse_drag_p is not accessed if !defined
911 USE_GTK && !defined HAVE_NS.
913 * intervals.c: Make symbols static if they're not exported.
914 (merge_properties_sticky, merge_interval_right, delete_interval):
916 * intervals.h (merge_interval_right, delete_interval): Remove decls.
918 * insdel.c: Make symbols static if they're not exported.
919 However, leave prepare_to_modify_buffer alone. It's never
920 called from outside this function, but that appears to be a bug.
921 (combine_after_change_list, combine_after_change_buffer):
922 (adjust_after_replace, signal_before_change): Now static.
923 (adjust_after_replace_noundo): Remove; unused.
924 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
925 (signal_before_change): Remove decls.
927 * indent.c (val_compute_motion, val_vmotion): Now static.
929 * image.c: Make symbols static if they're not exported.
930 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
932 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
933 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
935 * fringe.c (standard_bitmaps): Now static.
936 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
938 * frame.c: Make symbols static if they're not exported.
939 (x_report_frame_params, make_terminal_frame): Now static.
940 (get_frame_param): Now static, unless HAVE_NS.
941 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
942 (x_get_resource_string): Remove; not used.
943 * frame.h (make_terminal_frame, x_report_frame_params):
944 (x_get_resource_string); Remove decls.
945 (x_fullscreen_adjust): Declare only if WINDOWSNT.
946 * lisp.h (get_frame_param): Declare only if HAVE_NS.
948 * font.c, fontset.c: Make symbols static if they're not exported.
949 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
950 (FACE_SUITABLE_FOR_CHAR_P): Use it.
951 * font.c (font_close_object): Now static.
952 * font.h (font_close_object): Remove.
953 * fontset.c (FONTSET_OBJLIST): Remove.
954 (free_realized_fontset) #if-0 the body, which does nothing.
955 (face_suitable_for_char_p): #if-0, as it's never called.
956 * fontset.h (face_suitable_for_char_p): Remove decl.
957 * xfaces.c (face_at_string_position): Use
958 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
959 since 0 is always ASCII.
961 * fns.c (weak_hash_tables): Now static.
963 * fileio.c: Make symbols static if they're not exported.
964 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
965 (Vwrite_region_annotation_buffers): Now static.
967 * eval.c: Make symbols static if they're not exported.
968 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
969 * lisp.h (backtrace_list): Remove decl.
971 * emacs.c: Make symbols static if they're not exported.
972 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
973 (fatal_error_code, fatal_error_signal_hook, standard_args):
975 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
976 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
977 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
978 * lisp.h (fatal_error_signal_hook): Remove decl.
979 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
981 * editfns.c: Move a (normally-unused) function to its only use.
982 * editfns.c, lisp.h (get_operating_system_release): Remove.
983 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
984 worth the hassle of breaking this out.
986 * xterm.c: Make symbols static if they're not exported.
987 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
988 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
989 (x_destroy_window, x_delete_display):
991 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
992 (x_mouse_leave): Remove; unused.
993 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
994 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
995 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
997 (x_mouse_leave): Declare only if WINDOWSNT.
998 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
999 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1002 * ftxfont.c: Make symbols static if they're not exported.
1003 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1005 * font.h (ftxfont_driver): Likewise.
1007 * xfns.c: Make symbols static if they're not exported.
1008 (x_last_font_name, x_display_info_for_name):
1009 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1010 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1011 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1012 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1013 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1014 (last_show_tip_args): Now static.
1015 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1016 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1017 (x_screen_planes): Remove; unused.
1018 * dispextern.h (x_screen_planes): Remove decl.
1020 * dispnew.c: Make symbols static if they're not exported.
1021 * dispextern.h (redraw_garbaged_frames, scrolling):
1022 (increment_row_positions): Remove.
1023 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1024 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1026 (redraw_garbaged_frames): Remove; unused.
1028 * xfaces.c: Make symbols static if they're not exported.
1029 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1031 * xterm.h (defined_color): Remove decls.
1032 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1033 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1034 (menu_face_changed_default, defined_color, free_realized_face):
1035 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1036 (ascii_face_of_lisp_face): Remove; unused.
1038 * xdisp.c: Make symbols static if they're not exported.
1039 * dispextern.h (scratch_glyph_row, window_box_edges):
1040 (glyph_to_pixel_coords, set_cursor_from_row):
1041 (get_next_display_element, set_iterator_to_next):
1042 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1043 (show_mouse_face): Remove decls
1044 * frame.h (message_buf_print): Likewise.
1045 * lisp.h (pop_message, set_message, check_point_in_composition):
1047 * xterm.h (set_vertical_scroll_bar): Likewise.
1048 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1049 (message_buf_print, scratch_glyph_row, displayed_buffer):
1050 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1051 (get_next_display_element, show_mouse_face, window_box_edges):
1052 (frame_to_window_pixel_xy, check_point_in_composition):
1053 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1054 (glyph_to_pixel_coords): Remove; unused.
1056 * dired.c (file_name_completion): Now static.
1058 * dbusbind.c (xd_in_read_queued_messages): Now static.
1060 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1061 * data.c (circular_list_error): Remove.
1063 * commands.h (last_point_position, last_point_position_buffer):
1064 (last_point_position_window): Remove decls.
1065 * keyboard.c: Make these variables static.
1067 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1069 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1070 (iso_code_class, detect_coding, code_convert_region): Now static.
1071 (encode_coding_gap): Remove; unused.
1073 * chartab.c (chartab_chars, chartab_bits): Now static.
1075 * charset.h (charset_iso_8859_1): Remove decl.
1076 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1079 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1080 * ccl.c (Vccl_program_table): Now static.
1081 (check_ccl_update): Remove; unused.
1083 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1084 * category.h: ... from here.
1085 * category.c (check_category_table, set_category_set): Now static.
1087 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1088 * lisp.h: Remove these decls.
1090 * buffer.c (buffer_count): Remove unused var.
1092 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1093 so that it's not optimized away.
1094 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1095 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1096 exported only to the debugger.
1098 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1099 * atimer.h (run_all_atimers): Removed; not exported.
1101 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1102 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1103 was inaccessible from Lisp.
1104 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1105 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1107 alloc.c: Import and export fewer symbols, and remove unused items.
1108 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1110 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1111 it's not optimized away by whole-program optimization.
1112 (message_enable_multibyte, free_misc): Remove.
1113 (catchlist, handlerlist, mark_backtrace):
1114 Declare only if BYTE_MARK_STACK.
1115 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1116 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1117 (message_enable_multibyte): Remove decl.
1118 (free_misc, interval_free_list, float_block, float_block_index):
1119 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1120 (cons_free_list, last_marked_index):
1122 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1123 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1124 (mark_backtrace): Define only if BYTE_MARK_STACK.
1125 * xdisp.c (message_enable_multibyte): Now static.
1127 Declare Lisp_Object Q* variables to be 'static' if not exported.
1128 This makes it easier for human readers (and static analyzers)
1129 to see whether these variables are used from other modules.
1130 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1131 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1132 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1133 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1134 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1135 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1136 * xmenu.c, xselect.c:
1137 Declare Q* vars static if they are not used in other modules.
1138 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1139 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1140 Remove decls of unexported vars.
1141 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1143 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1145 Make Emacs functions such as Fatom 'static' by default.
1146 This makes it easier for human readers (and static analyzers)
1147 to see whether these functions can be called from other modules.
1148 DEFUN now defines a static function. To make the function external
1149 so that it can be used in other C modules, use the new macro DEFUE.
1150 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1151 (Finit_image_library):
1152 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1153 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1154 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1155 Remove decls, since these functions are now static.
1156 (Funintern, Fget_internal_run_time): New decls, since these functions
1157 were already external.
1159 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1160 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1161 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1162 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1163 * keyboard.c, keymap.c, lread.c:
1164 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1165 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1166 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1167 Mark functions with DEFUE instead of DEFUN,
1168 if they are used in other modules.
1169 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1170 decls for now-static functions.
1171 * buffer.h (Fdelete_overlay): Remove decl.
1172 * callproc.c (Fgetenv_internal): Mark as internal.
1173 * composite.c (Fremove_list_of_text_properties): Remove decl.
1174 (Fcomposition_get_gstring): New forward static decl.
1175 * composite.h (Fcomposite_get_gstring): Remove decl.
1176 * dired.c (Ffile_attributes): New forward static decl.
1177 * doc.c (Fdocumntation_property): New forward static decl.
1178 * eval.c (Ffetch_bytecode): New forward static decl.
1179 (Funintern): Remove extern decl; now in .h file where it belongs.
1180 * fileio.c (Fmake_symbolic_link): New forward static decl.
1181 * image.c (Finit_image_library): New forward static decl.
1182 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1183 * intervals.h (Fprevious_property_change):
1184 (Fremove_list_of_text_properties): Remove decls.
1185 * keyboard.c (Fthis_command_keys): Remove decl.
1186 (Fcommand_execute): New forward static decl.
1187 * keymap.c (Flookup_key): New forward static decl.
1188 (Fcopy_keymap): Now static.
1189 * keymap.h (Flookup_key): Remove decl.
1190 * process.c (Fget_process): New forward static decl.
1191 (Fprocess_datagram_address): Mark as internal.
1192 * syntax.c (Fsyntax_table_p): New forward static decl.
1193 (skip_chars): Remove duplicate decl.
1194 * textprop.c (Fprevious_property_change): New forward static decl.
1195 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1197 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1198 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1200 * editfns.c (Fformat): Remove unreachable code.
1202 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1204 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1207 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1209 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1210 when at ZV. (Bug#8487)
1212 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1214 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1216 * keyboard.c (parse_tool_bar_item): Likewise.
1217 * sound.c (sound_cleanup, alsa_close): Likewise.
1218 * termcap.c (tgetent): Likewise.
1219 * xfns.c (x_default_font_parameter): Likewise.
1220 * xsettings.c (read_and_apply_settings): Likewise.
1222 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1223 (overrun_check_free): Protoize.
1225 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1227 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1228 since callers should never pass a negative size.
1229 Change the signature to match that of plain 'read' and 'write'; see
1230 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1231 * lisp.h: Update prototypes of emacs_write and emacs_read.
1233 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1235 * xdisp.c (redisplay_window): Don't try to determine the character
1236 position of the scroll margin if the window start point w->startp
1237 is outside the buffer's accessible region. (Bug#8468)
1239 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1241 Fix write-region and its subroutines for buffers > 2GB.
1242 * fileio.c (a_write, e_write): Modify declaration of arguments and
1243 local variables to support buffers larger than 2GB.
1244 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1246 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1247 argument, local variables, and return value.
1249 * lisp.h: Update prototypes of emacs_write and emacs_read.
1251 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1253 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1255 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1257 Fix more problems found by GCC 4.6.0's static checks.
1259 * xdisp.c (vmessage): Use a better test for character truncation.
1261 * charset.c (load_charset_map): <, not <=, for optimization,
1262 and to avoid potential problems with integer overflow.
1263 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1264 * casetab.c (set_identity, shuffle): Likewise.
1265 * editfns.c (Fformat): Likewise.
1266 * syntax.c (skip_chars): Likewise.
1268 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1269 This also lets GCC 4.6.0 generate slightly better loop code.
1271 * callint.c (Fcall_interactively): <, not <=, for optimization.
1272 (Fcall_interactively): Count the number of arguments produced,
1273 not the number of arguments given. This is simpler and lets GCC
1274 4.6.0 generate slightly better code.
1276 * ftfont.c: Distingish more carefully between FcChar8 and char.
1277 The previous code passed unsigned char * to a functions like
1278 strlen and xstrcasecmp that expect char *, which does not
1279 conform to the C standard.
1280 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1281 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1282 char * when the C standard requires it.
1284 * keyboard.c (read_char): Remove unused var.
1286 * eval.c: Port to Windows vsnprintf (Bug#8435).
1288 (SIZE_MAX): Define if the headers do not.
1289 (verror): Do not give up if vsnprintf returns a negative count.
1290 Instead, grow the buffer. This ports to Windows vsnprintf, which
1291 does not conform to C99. Problem reported by Eli Zaretskii.
1292 Also, simplify the allocation scheme, by avoiding the need for
1293 calling realloc, and removing the ALLOCATED variable.
1295 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1297 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1298 But keep the doprint source code for now, as we might revamp it
1299 and use it again (Bug#8435).
1300 * lisp.h (doprnt): Remove.
1301 * Makefile.in (base_obj): Remove doprnt.o.
1302 * deps.mk (doprnt.o): Remove.
1304 error: Print 32- and 64-bit integers portably (Bug#8435).
1305 Without this change, on typical 64-bit hosts error ("...%d...", N)
1306 was used to print both 32- and 64-bit integers N, which relied on
1308 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1310 * lisp.h (error, verror): Mark as printf-like functions.
1311 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1312 Report overflow in size calculations when allocating printf buffer.
1313 Do not truncate output string at its first null byte.
1314 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1315 Truncate the output at a character boundary, since vsnprintf does not
1317 * charset.c (check_iso_charset_parameter): Convert internal
1318 character to string before calling 'error', since %c now has the
1320 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1321 overflow when computing char to be passed to 'error'. Do not
1322 pass Lisp_Object to 'error'; pass the integer instead.
1323 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1324 formatted with plain %d.
1326 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1328 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1330 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1332 * xterm.c (x_catch_errors): Remove duplicate declaration.
1334 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1336 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1338 2011-04-10 Jim Meyering <meyering@redhat.com>
1340 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1341 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1342 return ssize_t not "int", and use size_t as the buffer length.
1343 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1344 * gnutls.h: Update declarations.
1345 * process.c (read_process_output): Use ssize_t, to match.
1346 (send_process): Likewise.
1348 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1350 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1352 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1354 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1355 unsigned char, to match FcChar8 type definition.
1357 * xterm.c (handle_one_xevent):
1358 * xmenu.c (create_and_show_popup_menu):
1359 * xselect.c (x_decline_selection_request)
1360 (x_reply_selection_request): Avoid type-punned deref of X events.
1362 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1364 Fix some uses of `int' instead of EMACS_INT.
1365 * search.c (string_match_1, fast_string_match)
1366 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1367 (scan_buffer, find_next_newline_no_quit)
1368 (find_before_next_newline, search_command, Freplace_match)
1369 (Fmatch_data): Make some `int' variables be EMACS_INT.
1371 * xdisp.c (display_count_lines): 3rd argument and return value now
1372 EMACS_INT. All callers changed.
1373 (pint2hrstr): Last argument is now EMACS_INT.
1375 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1376 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1377 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1378 (decode_coding_utf_16, decode_coding_emacs_mule)
1379 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1380 (decode_coding_ccl, decode_coding_charset)
1381 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1382 (decode_coding_iso_2022, decode_coding_emacs_mule)
1383 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1384 <char_offset, last_offset>: Declare EMACS_INT.
1385 (encode_coding_utf_8, encode_coding_utf_16)
1386 (encode_coding_emacs_mule, encode_invocation_designation)
1387 (encode_designation_at_bol, encode_coding_iso_2022)
1388 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1389 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1391 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1392 (encode_invocation_designation): Last argument P_NCHARS is now
1394 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1395 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1397 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1400 * ccl.c (Fccl_execute_on_string): Declare some variables
1403 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1405 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1407 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1409 * process.c (Fformat_network_address): Doc fix.
1411 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1413 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1415 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1417 * keyboard.c (read_char): Call Lisp function help-form-show,
1418 instead of using internal_with_output_to_temp_buffer.
1419 (Qhelp_form_show): New var.
1420 (syms_of_keyboard): Use DEFSYM macro.
1422 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1424 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1426 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1428 * process.c (Flist_processes): Removed to Lisp.
1429 (list_processes_1): Deleted.
1431 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1433 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1435 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1437 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1439 Fix more problems found by GCC 4.6.0's static checks.
1441 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1443 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1445 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1447 * xdisp.c (vmessage): Mark as a printf-like function.
1449 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1451 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1453 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1454 printf-like functions.
1455 (tiff_load): Add casts to remove these marks before passing them
1456 to system-supplied API.
1458 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1460 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1461 This avoids several warnings with gcc -Wstrict-overflow.
1462 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1463 directly, rather than having caller test rule sign. This avoids
1464 some unnecessary tests.
1465 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1466 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1467 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1469 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1470 (xfont_open): Avoid unnecessary tests.
1472 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1474 * composite.h, composite.c (composition_gstring_put_cache):
1475 Use EMACS_INT, not int, for length.
1477 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1478 breaking out part of COMPOSITION_DECODE_RULE.
1479 (COMPOSITION_DECODE_RULE): Use it.
1480 * composite.c (get_composition_id): Remove unused local vars,
1481 by using the new macro.
1483 * textprop.c (set_text_properties_1): Change while to do-while,
1484 since the condition is always true at first.
1486 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1487 (interval_deletion_adjustment): Return unsigned value.
1490 * process.c (list_processes_1, create_pty, read_process_output):
1491 (exec_sentinel): Remove vars that were set but not used.
1492 (create_pty): Remove unnecessary "volatile"s.
1493 (Fnetwork_interface_info): Avoid possibility of int overflow.
1494 (read_process_output): Do adaptive read buffering even if carryover.
1495 (read_process_output): Simplify nbytes computation if buffered.
1497 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1499 * syntax.c (scan_words): Remove var that was set but not used.
1500 (update_syntax_table): Use unsigned instead of int.
1502 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1503 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1504 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1506 * print.c (print_error_message): Avoid int overflow.
1508 * font.c (font_list_entities): Redo for clarity,
1509 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1511 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1512 (font_score): Avoid potential overflow in diff calculation.
1514 * fns.c (substring_both): Remove var that is set but not used.
1515 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1517 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1519 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1520 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1521 can always succeed if overflow has undefined behavior.
1523 * search.c (boyer_moore, wordify): Remove vars set but not used.
1524 (wordify): Omit three unnecessary tests.
1526 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1527 All callers changed. This avoids the need for an unused var.
1529 * casefiddle.c (casify_region): Remove var that is set but not used.
1531 * dired.c (file_name_completion): Remove var that is set but not used.
1533 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1535 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1536 (Finsert_file_contents): Remove unnecessary code checking fd.
1538 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1539 Check for integer overflow on size calculations.
1541 * buffer.c (Fprevious_overlay_change): Remove var that is set
1544 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1545 Remove vars that are set but not used.
1546 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1547 (timer_check_2): Mark vars as initialized.
1549 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1551 * image.c (lookup_image): Remove var that is set but not used.
1552 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1554 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1555 that are set but not used.
1557 * xfns.c (make_invisible_cursor): Don't return garbage
1558 if XCreateBitmapFromData fails (Bug#8410).
1560 * xselect.c (x_get_local_selection, x_handle_property_notify):
1561 Remove vars that are set but not used.
1563 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1564 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1566 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1567 Remove var that is set but not used.
1568 (scroll_bar_windows_size): Now size_t, not int.
1569 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1572 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1573 (map_tty_color) [!defined MSDOS]: Likewise.
1575 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1577 * coding.c: Remove vars that are set but not used.
1578 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1579 All callers changed.
1580 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1581 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1582 (decode_coding_charset): Remove vars that are set but not used.
1584 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1585 that is set but not used.
1587 * print.c (print_object): Remove var that is set but not used.
1589 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1590 The gnulib version avoids calling malloc in the usual case,
1591 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1592 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1593 * filelock.c (current_lock_owner): Likewise.
1594 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1595 * sysdep.c: Include allocator.h, careadlinkat.h.
1596 (emacs_no_realloc_allocator): New static constant.
1597 (emacs_readlink): New function.
1598 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1599 ../lib/careadlinkat.h.
1601 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1603 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1604 first non-nil return value).
1606 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1608 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1609 if not defined (Bug#8403).
1611 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1613 * xdisp.c (display_count_lines): Remove parameter `start',
1614 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1615 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1616 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1617 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1618 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1619 and thereabouts. All callers changed.
1620 (get_per_char_metric): Remove parameter `f', unused since
1621 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1623 2011-04-02 Jim Meyering <meyering@redhat.com>
1625 do not dereference NULL upon failed strdup
1626 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1627 (ns_get_family): Likewise.
1629 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1631 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1633 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1635 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1638 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1640 Add lexical binding.
1642 * window.c (Ftemp_output_buffer_show): New fun.
1643 (Fsave_window_excursion):
1644 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1646 * lread.c (lisp_file_lexically_bound_p): New function.
1647 (Fload): Bind Qlexical_binding.
1648 (readevalloop): Remove `evalfun' arg.
1649 Bind Qinternal_interpreter_environment.
1650 (Feval_buffer): Bind Qlexical_binding.
1651 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1653 (syms_of_lread): Declare `lexical-binding'.
1655 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1657 * keyboard.c (eval_dyn): New fun.
1658 (menu_item_eval_property): Use it.
1660 * image.c (parse_image_spec): Use Ffunctionp.
1662 * fns.c (concat, mapcar1): Accept byte-code-functions.
1664 * eval.c (Fsetq): Handle lexical vars.
1665 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1666 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1667 (FletX, Flet): Obey lexical binding.
1668 (Fcommandp): Handle closures.
1669 (Feval): New `lexical' arg.
1670 (eval_sub): New function extracted from Feval. Use it almost
1671 everywhere where Feval was used. Look up vars in lexical env.
1673 (Ffunctionp): Move from subr.el.
1674 (Ffuncall): Handle closures.
1675 (apply_lambda): Remove `eval_flags'.
1676 (funcall_lambda): Handle closures and new byte-code-functions.
1677 (Fspecial_variable_p): New function.
1678 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1679 but without exporting it to Lisp.
1681 * doc.c (Fdocumentation, store_function_docstring):
1682 * data.c (Finteractive_form): Handle closures.
1684 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1687 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1689 (exec_byte_code): New function extracted from Fbyte_code to handle new
1690 calling convention for byte-code-functions. Add new byte-codes.
1692 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1694 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1696 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1698 * xdisp.c (redisplay_internal): Fix prototype.
1700 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1702 * xdisp.c (SCROLL_LIMIT): New macro.
1703 (try_scrolling): Use it when setting scroll_limit. Limit
1704 scrolling to 100 screen lines.
1705 (redisplay_window): Even when falling back on "recentering",
1706 position point in the window according to scroll-conservatively,
1707 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1709 (try_scrolling): When point is above the window, allow searching
1710 as far as scroll_max, or one screenful, to compute vertical
1711 distance from PT to the scroll margin position. This prevents
1712 try_scrolling from unnecessarily failing when
1713 scroll-conservatively is set to a value slightly larger than the
1714 window height. Clean up the case of PT below the margin at bottom
1715 of window: scroll_max can no longer be INT_MAX. When aggressive
1716 scrolling is in use, don't let point enter the opposite scroll
1717 margin as result of the scroll.
1718 (syms_of_xdisp) <scroll-conservatively>: Document the
1719 threshold of 100 lines for never-recentering scrolling.
1721 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1723 * dispextern.h (move_it_by_lines):
1724 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1725 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1726 (message_log_check_duplicate): Remove parameters `prev_bol' and
1727 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1728 (redisplay_internal): Remove parameter `preserve_echo_area',
1729 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1731 * indent.c (Fvertical_motion):
1732 * window.c (window_scroll_pixel_based, Frecenter):
1733 Don't pass `need_y_p' to `move_it_by_lines'.
1735 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1737 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1738 steal a few bits to be more compact.
1739 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1740 Remove unneeded casts.
1742 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1744 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1746 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1747 binding" message (bug#7967).
1749 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1751 Fix more problems found by GCC 4.6.0's static checks.
1753 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1754 Remove unused local var.
1756 * editfns.c (Fmessage_box): Remove unused local var.
1758 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1759 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1760 Omit unused local vars.
1761 * window.c (shrink_windows): Omit unused local var.
1762 * menu.c (digest_single_submenu): Omit unused local var.
1763 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1764 Omit unused local var.
1766 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1767 Don't assume string length fits in int.
1768 (keyremap_step, read_key_sequence): Use size_t for sizes.
1769 (read_key_sequence): Don't check last_real_key_start redundantly.
1771 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1772 instead of alloca (Bug#8344).
1774 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1775 (Fbacktrace_frame): Don't assume nframes fits in int.
1777 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1779 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1782 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1784 * cm.c (calccost): Turn while-do into do-while, for clarity.
1786 * keyboard.c (syms_of_keyboard): Use the same style as later
1787 in this function when indexing through an array. This also
1788 works around GCC bug 48267.
1790 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1792 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1794 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1795 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1797 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1798 This avoids undefined behavior on integer overflow, and is a bit
1799 more convenient anyway since it is compared to a size_t variable.
1801 Variadic C functions now count arguments with size_t, not int.
1802 This avoids an unnecessary limitation on 64-bit machines, which
1803 caused (substring ...) to crash on large vectors (Bug#8344).
1804 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1805 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1806 All variadic functions and their callers changed accordingly.
1807 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1808 * data.c (arith_driver, float_arith_driver): Likewise.
1809 * editfns.c (general_insert_function): Likewise.
1810 * eval.c (struct backtrace.nargs, interactive_p)
1811 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1812 (funcall_lambda, mark_backtrace): Likewise.
1813 * fns.c (concat): Likewise.
1814 * frame.c (x_set_frame_parameters): Likewise.
1815 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1816 0 if not found, not -1. All callers changed.
1818 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1819 (stack_copy_size): Now size_t, not int.
1820 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1822 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1824 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1825 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1826 All callers changed.
1828 * lisp.h (multibyte_char_to_unibyte):
1829 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1830 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1831 * character.h (CHAR_TO_BYTE8):
1832 * cmds.c (internal_self_insert):
1833 * editfns.c (general_insert_function):
1834 * keymap.c (push_key_description):
1835 * search.c (Freplace_match):
1836 * xdisp.c (message_dolog, set_message_1): All callers changed.
1838 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1840 * keyboard.c (safe_run_hook_funcall): New function.
1841 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1842 don't set the hook to nil, but remove the offending function instead.
1843 (Qcommand_hook_internal): Remove, unused.
1844 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1845 Vcommand_hook_internal.
1847 * eval.c (enum run_hooks_condition): Remove.
1848 (funcall_nil, funcall_not): New functions.
1849 (run_hook_with_args): Call each function through a `funcall' argument.
1850 Remove `cond' argument, now redundant.
1851 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1852 (Frun_hook_with_args_until_failure): Adjust accordingly.
1853 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1855 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1857 * dispextern.h (string_buffer_position): Remove declaration.
1859 * print.c (strout): Remove parameter `multibyte', unused since
1860 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1862 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1863 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1864 All callers changed.
1866 * w32.c (_wsa_errlist): Use braces for struct initializers.
1868 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1869 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1870 All callers changed.
1871 (string_buffer_position): Likewise. Also, make static (it's never
1872 used outside xdisp.c).
1873 (cursor_row_p): Remove parameter `w', unused since
1874 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1875 (decode_mode_spec): Remove parameter `precision', introduced during
1876 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1877 All callers changed.
1879 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1881 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1883 2011-03-27 Anders Lindgren <andlind@gmail.com>
1885 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1886 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1887 (ns_update_auto_hide_menu_bar): New functions.
1888 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1889 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1890 ns_constrain_all_frames.
1891 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1892 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1894 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1896 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1898 2011-03-27 Glenn Morris <rgm@gnu.org>
1900 * syssignal.h: Replace RETSIGTYPE with void.
1901 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1902 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1903 Replace SIGTYPE with void everywhere.
1904 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1905 * s/template.h (SIGTYPE): Remove commented out definition.
1907 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1909 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1910 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1912 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1914 * w32.c (read_unc_volume): Use parameter `henum', instead of
1915 global variable `wget_enum_handle'.
1917 * keymap.c (describe_vector): Remove parameters `indices' and
1918 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1919 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1921 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1923 * keyboard.c (timer_check): Remove parameter `do_it_now',
1924 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1925 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1926 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1928 * keyboard.c (read_char):
1929 * w32menu.c (w32_menu_display_help):
1930 * xmenu.c (show_help_event, menu_help_callback):
1931 Adjust calls to `show_help_echo'.
1933 * gtkutil.c (xg_maybe_add_timer):
1934 * keyboard.c (readable_events):
1935 * process.c (wait_reading_process_output):
1936 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1938 * insdel.c (adjust_markers_gap_motion):
1939 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1940 (gap_left, gap_right): Don't call it.
1942 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1944 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1945 incurred during fontification.
1947 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1949 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1950 (DEFVAR_PER_BUFFER): Don't pass it.
1952 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1953 (scrolling_window): Don't pass it.
1955 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1957 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1959 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1961 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1962 of variables specific to SELinux and computation of `encoded_absname'.
1964 * image.c (XPutPixel): Remove unused variable `height'.
1966 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1968 * unexw32.c (get_section_info): Remove unused variable `section'.
1970 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1971 (system_process_attributes): Remove unused variable `sess'.
1972 (sys_read): Remove unused variable `err'.
1974 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1975 (w32_wnd_proc): Remove unused variable `isdead'.
1976 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1977 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1978 (x_create_tip_frame): Remove unused variable `tem'.
1980 * w32inevt.c (w32_console_read_socket):
1981 Remove unused variable `no_events'.
1983 * w32term.c (x_draw_composite_glyph_string_foreground):
1984 Remove unused variable `width'.
1986 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1988 * w32term.c (x_set_glyph_string_clipping):
1989 Don't pass uninitialized region to CombineRgn.
1991 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1993 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1994 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1995 (Fx_close_connection): Remove unused variable `i'.
1997 * w32font.c (w32font_draw): Return number of glyphs.
1998 (w32font_open_internal): Remove unused variable `i'.
1999 (w32font_driver): Add missing initializer.
2001 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2002 (fill_in_menu): Remove unused variable `items_added'.
2004 * w32term.c (last_mouse_press_frame): Remove static global variable.
2005 (w32_clip_to_row): Remove unused variable `f'.
2006 (x_delete_terminal): Remove unused variable `i'.
2008 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2009 (NOTHING): Remove unused static global variable.
2010 (uniscribe_check_otf): Remove unused variable `table'.
2011 (uniscribe_font_driver): Add missing initializers.
2013 2011-03-23 Julien Danjou <julien@danjou.info>
2015 * term.c (Fsuspend_tty, Fresume_tty):
2016 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2017 * window.c (temp_output_buffer_show):
2018 * insdel.c (signal_before_change):
2019 * frame.c (Fhandle_switch_frame):
2020 * fileio.c (Fdo_auto_save):
2021 * emacs.c (Fkill_emacs):
2022 * editfns.c (save_excursion_restore):
2023 * cmds.c (internal_self_insert):
2024 * callint.c (Fcall_interactively):
2025 * buffer.c (Fkill_all_local_variables):
2026 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2028 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2029 unconditionnaly since it does the check itself.
2031 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2033 Fix more problems found by GCC 4.5.2's static checks.
2035 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2036 the first time through the loop, since we know p0 < p1 then.
2037 This also avoids a gcc -Wstrict-overflow warning.
2039 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2040 leading to a memory leak, possible in functions like
2041 load_charset_map_from_file that can allocate an unbounded number
2042 of objects (Bug#8318).
2044 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2045 that could (at least in theory) be that large.
2047 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2048 This is less likely to overflow, and avoids undefined behavior if
2049 overflow does occur. All callers changed. Use strtoul to scan
2050 for the unsigned long integer.
2051 (pint2hrstr): Simplify and tune code slightly.
2052 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2054 * scroll.c (do_scrolling): Work around GCC bug 48228.
2055 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2057 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2058 This also avoids a warning with gcc -Wstrict-overflow.
2059 (validate_x_resource_name): Simplify count usage.
2060 This also avoids a warning with gcc -Wstrict-overflow.
2062 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2065 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2067 * process.c (Fmake_network_process): Use socklen_t, not int,
2068 where POSIX says socklen_t is required in portable programs.
2069 This fixes a porting bug on hosts like 64-bit HP-UX, where
2070 socklen_t is wider than int (Bug#8277).
2071 (Fmake_network_process, server_accept_connection):
2072 (wait_reading_process_output, read_process_output):
2075 * process.c: Rename or move locals to avoid shadowing.
2076 (list_processes_1, Fmake_network_process):
2077 (read_process_output_error_handler, exec_sentinel_error_handler):
2078 Rename or move locals.
2079 (Fmake_network_process): Define label "retry_connect" only if needed.
2080 (Fnetwork_interface_info): Fix pointer signedness.
2081 (process_send_signal): Add cast to avoid pointer signedness problem.
2082 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2083 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2085 Make tparam.h and terminfo.c consistent.
2086 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2087 Include tparam.h instead, since it declares them.
2088 * cm.h (PC): Remove extern decl; tparam.h now does this.
2089 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2090 * terminfo.c: Include tparam.h, to check interfaces.
2091 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2092 (tparam): Adjust signature to match interface in tparam.h;
2093 this removes some undefined behavior. Check that outstring and len
2094 are zero, which they always are with Emacs.
2095 * tparam.h (PC, BC, UP): New extern decls.
2097 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2098 (xftfont_open): Rename locals to avoid shadowing.
2100 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2101 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2102 (OTF_TAG_SYM): Omit macro if not needed.
2103 (ftfont_list): Remove unused local.
2104 (get_adstyle_property, ftfont_pattern_entity):
2105 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2106 Rename locals to avoid shadowing.
2108 * xfont.c (xfont_list_family): Mark var as initialized.
2110 * xml.c (make_dom): Now static.
2112 * composite.c (composition_compute_stop_pos): Rename local to
2114 (composition_reseat_it): Remove unused locals.
2115 (find_automatic_composition, composition_adjust_point): Likewise.
2116 (composition_update_it): Mark var as initialized.
2117 (find_automatic_composition): Mark vars as initialized,
2118 with a FIXME (Bug#8290).
2120 character.h: Rename locals to avoid shadowing.
2121 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2122 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2123 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2124 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2127 * textprop.c (property_change_between_p): Remove; unused.
2129 * intervals.c (interval_start_pos): Now static.
2131 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2133 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2134 Rename locals to avoid shadowing.
2136 * sound.c (wav_play, au_play, Fplay_sound_internal):
2137 Fix pointer signedness.
2138 (alsa_choose_format): Remove unused local var.
2139 (wav_play): Initialize a variable to 0, to prevent undefined
2140 behavior (Bug#8278).
2142 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2144 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2147 clobbering (Bug#8298).
2148 * sysdep.c (sys_subshell): Likewise.
2149 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2151 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2152 This should get cleaned up, so that child_setup has the
2153 same signature on all platforms.
2155 * callproc.c (call_process_cleanup): Now static.
2156 (relocate_fd): Rename locals to avoid shadowing.
2158 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2160 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2161 not to be necessary, and produces flickering.
2163 2011-03-20 Glenn Morris <rgm@gnu.org>
2165 * config.in: Remove file.
2167 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2169 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2170 are now in src/globals.h.
2171 (syms_of_minibuf): Remove spurious & from previous change.
2173 2011-03-20 Leo <sdl.web@gmail.com>
2175 * minibuf.c (completing-read-function): New variable.
2176 (completing-read-default): Rename from completing-read.
2177 (completing-read): Call completing-read-function.
2179 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2181 * xfaces.c (Fx_load_color_file):
2182 Read color file from absolute filename (bug#8250).
2184 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2186 * makefile.w32-in: Update dependencies.
2188 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2190 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2192 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2194 Fix more problems found by GCC 4.5.2's static checks.
2196 * process.c (make_serial_process_unwind, send_process_trap):
2197 (sigchld_handler): Now static.
2199 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2200 That way, the code declares only the vars that it needs.
2201 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2202 * s/cygwin.h (PTY_ITERATION): Likewise.
2203 * s/darwin.h (PTY_ITERATION): Likewise.
2204 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2206 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2207 * process.c (allocate_pty): Don't declare stb unless it's needed.
2209 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2210 (CONSTANTLIM): Remove; unused.
2211 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2212 Define only if needed.
2214 * unexelf.c (unexec): Name an expression,
2215 to avoid gcc -Wbad-function-cast warning.
2216 Use a different way to cause a compilation error if anyone uses
2217 n rather than nn, a way that does not involve shadowing.
2218 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2220 * deps.mk (unexalpha.o): Remove; unused.
2222 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2223 * unexec.h: New file.
2224 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2225 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2227 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2228 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2229 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2230 Change as necessary to match prototype in unexec.h.
2232 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2234 (back_comment, skip_chars): Mark vars as initialized.
2236 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2237 Rename locals to avoid shadowing.
2239 * lread.c (read1): Rewrite so as not to use empty "else".
2240 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2242 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2244 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2245 warning when compiling print.c.
2247 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2248 instead of using an uninitialized var.
2249 (font_sort_entities): Mark var as initialized.
2251 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2253 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2254 pointers to constants.
2255 (font_parse_fcname): Remove unused vars.
2256 (font_delete_unmatched): Now static.
2257 (font_get_spec): Remove; unused.
2258 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2259 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2260 Rename or move locals to avoid shadowing.
2262 * fns.c (require_nesting_list, require_unwind): Now static.
2263 (Ffillarray): Rename locals to avoid shadowing.
2265 * floatfns.c (domain_error2): Define only if needed.
2266 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2268 * alloc.c (mark_backtrace): Move decl from here ...
2269 * lisp.h: ... to here, so that it can be checked.
2271 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2272 (Fdefvar): Rewrite so as not to use empty "else".
2273 (lisp_indirect_variable): Name an expression,
2274 to avoid gcc -Wbad-function-cast warning.
2275 (Fdefvar): Rename locals to avoid shadowing.
2277 * callint.c (quotify_arg, quotify_args): Now static.
2278 (Fcall_interactively): Rename locals to avoid shadowing.
2279 Use const pointer when appropriate.
2281 * lisp.h (get_system_name, get_operating_system_release):
2282 Move decls here, to check interfaces.
2283 * process.c (get_operating_system_release): Move decl to lisp.h.
2284 * xrdb.c (get_system_name): Likewise.
2285 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2286 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2287 some of which prompt warnings from gcc -Wbad-function-cast.
2288 (Fformat_time_string, Fencode_time, Finsert_char):
2289 (Ftranslate_region_internal, Fformat):
2290 Rename or remove local vars to avoid shadowing.
2291 (Ftranslate_region_internal): Mark var as initialized.
2293 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2296 * lisp.h (eassert): Check that the argument compiles, even if
2297 ENABLE_CHECKING is not defined.
2299 * data.c (Findirect_variable): Name an expression, to avoid
2300 gcc -Wbad-function-cast warning.
2301 (default_value, arithcompare, arith_driver, arith_error): Now static.
2302 (store_symval_forwarding): Rename local to avoid shadowing.
2303 (Fmake_variable_buffer_local, Fmake_local_variable):
2304 Mark variables as initialized.
2305 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2307 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2308 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2309 Rename locals to avoid shadowing.
2310 (mark_stack): Move local variables into the #ifdef region where
2312 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2313 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2315 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2316 (GC_STRING_CHARS): Remove; not used.
2317 (Fmemory_limit): Cast sbrk's returned value to char *.
2319 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2320 avoids undefined behavior in theory.
2322 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2324 Use functions, not macros, for up- and down-casing (Bug#8254).
2325 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2326 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2327 to use the following functions instead of these macros.
2328 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2329 EMACS_INT, since callers assume the returned value fits in int.
2330 (upcase1): Likewise, for UPCASE_TABLE.
2331 (uppercasep, lowercasep, upcase): New static inline functions.
2332 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2333 the race-condition problem in the old DOWNCASE.
2335 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2336 Rename locals to avoid shadowing.
2337 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2338 (regex_compile, re_search_2, re_match_2_internal):
2339 Remove unused local vars.
2340 (FREE_VAR): Rewrite so as not to use empty "else",
2341 which gcc can warn about.
2342 (regex_compile, re_match_2_internal): Mark locals as initialized.
2343 (RETALLOC_IF): Define only if needed.
2344 (WORDCHAR_P): Likewise. This one is never needed, but is used
2345 only in a comment talking about a compiler bug, so put inside
2346 the #if 0 of that comment.
2347 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2348 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2351 * search.c (boyer_moore): Rename locals to avoid shadowing.
2352 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2353 (PREV_CHAR_BOUNDARY): Likewise.
2355 * search.c (simple_search): Remove unused var.
2357 * dired.c (compile_pattern): Move decl from here ...
2358 * lisp.h: ... to here, so that it can be checked.
2359 (struct re_registers): New forward decl.
2361 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2363 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2365 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2366 Rename locals to avoid shadowing.
2367 (Fvertical_motion): Mark locals as initialized.
2369 * casefiddle.c (casify_object, casify_region): Now static.
2370 (casify_region): Mark local as initialized.
2372 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2374 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2375 New macros, so that the caller can use some names other than
2376 gcpro1, gcpro2, etc.
2377 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2379 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2380 argument, for consistency with GCPRO2_VAR, etc: it is now the
2381 prefix of the variable, not the variable itself. All uses
2383 * dired.c (directory_files_internal, file_name_completion):
2384 Rename locals to avoid shadowing.
2386 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2387 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2388 dired.c's scmp function, had undefined behavior.
2389 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2390 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2391 * buffer.h: ... to here, because these macros use current_buffer,
2392 and the new implementation with inline functions needs to have
2393 current_buffer in scope now, rather than later when the macros
2395 (downcase, upcase1): New static inline functions.
2396 (DOWNCASE, UPCASE1): Reimplement using these functions.
2397 This avoids undefined behavior in expressions like
2398 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2399 from race conditions in accessing the global variables
2400 case_temp1 and case_temp2.
2401 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2402 * lisp.h (case_temp1, case_temp2): Remove their decls.
2403 * character.h (ASCII_CHAR_P): Move from here ...
2404 * lisp.h: ... to here, so that the inline functions mentioned
2407 * dired.c (directory_files_internal_unwind): Now static.
2409 * fileio.c (file_name_as_directory, directory_file_name):
2410 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2412 (file_name_as_directory): Use const pointers when appropriate.
2413 (Fexpand_file_name): Likewise. In particular, newdir might
2414 point at constant storage, so make it a const pointer.
2415 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2416 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2418 (Fset_file_times, Finsert_file_contents, auto_save_error):
2419 Rename locals to avoid shadowing.
2421 * minibuf.c (choose_minibuf_frame_1): Now static.
2422 (Ftry_completion, Fall_completions): Rename or remove locals
2425 * marker.c (bytepos_to_charpos): Remove; unused.
2427 * lisp.h (verify_bytepos, count_markers): New decls,
2428 so that gcc does not warn that these functions aren't declared.
2430 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2431 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2432 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2433 (copy_text): Remove unused local var.
2435 * filelock.c (within_one_second): Now static.
2436 (lock_file_1): Rename local to avoid shadowing.
2438 * buffer.c (fix_overlays_before): Mark locals as initialized.
2439 (fix_start_end_in_overlays): Likewise. This function should be
2440 simplified by using pointers-to-pointers, but that's a different
2442 (switch_to_buffer_1): Now static.
2443 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2444 (report_overlay_modification): Rename locals to avoid shadowing.
2446 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2447 Fix pointer signedness issue.
2448 (sys_subshell): Mark local as volatile if checking for lint,
2449 to suppress a gcc -Wclobbered warning that does not seem to be right.
2450 (MAXPATHLEN): Define only if needed.
2452 * process.c (serial_open, serial_configure): Move decls from here ...
2453 * systty.h: ... to here, so that they can be checked.
2455 * fns.c (get_random, seed_random): Move extern decls from here ...
2456 * lisp.h: ... to here, so that they can be checked.
2458 * sysdep.c (reset_io): Now static.
2459 (wait_for_termination_signal): Remove; unused.
2461 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2462 (copy_keymap_item, append_key, push_text_char_description):
2464 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2465 (DENSE_TABLE_SIZE): Remove; unused.
2466 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2467 (describe_map_tree):
2468 Rename locals to avoid shadowing.
2470 * keyboard.c: Declare functions static if they are not used elsewhere.
2471 (echo_char, echo_dash, cmd_error, top_level_2):
2472 (poll_for_input, handle_async_input): Now static.
2473 (read_char, kbd_buffer_get_event, make_lispy_position):
2474 (make_lispy_event, make_lispy_movement, apply_modifiers):
2475 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2476 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2477 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2478 (read_key_sequence, read_char): Mark locals as initialized.
2479 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2481 * keyboard.h (make_ctrl_char): New decl.
2482 (mark_kboards): Move decl here ...
2483 * alloc.c (mark_kboards): ... from here.
2485 * lisp.h (force_auto_save_soon): New decl.
2487 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2488 (DEFINE_DUMMY_FUNCTION): New macro.
2489 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2491 (main): Add casts to avoid warnings
2492 if GCC considers string literals to be constants.
2494 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2496 * dbusbind.c: Pointer signedness fixes.
2497 (xd_signature, xd_append_arg, xd_initialize):
2498 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2499 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2500 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2501 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2503 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2504 if GCC considers string literals to be constants.
2505 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2507 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2509 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2510 (print_preprocess, print_object): New macro to fix last change.
2512 * print.c (print_preprocess): Don't forget font objects.
2514 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2516 * emacs.c (USAGE3): Doc fixes.
2518 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2520 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2523 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2525 * lisp.h (VWindow_system, Qfile_name_history):
2526 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2527 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2528 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2530 * w32select.c: Don't #include "keyboard.h".
2531 (run_protected): Add extern declaration for waiting_for_input.
2533 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2534 * w32console.c (detect_input_pending, read_input_pending)
2535 (encode_terminal_code):
2536 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2537 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2538 (w32_system_caret_y, Qfile_name_history):
2539 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2540 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2541 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2542 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2543 * w32proc.c (Qlocal, report_file_error):
2544 * w32term.c (Vwindow_system, updating_frame):
2545 * w32uniscribe.c (initialized, uniscribe_font_driver):
2546 Remove unneeded extern declarations.
2548 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2550 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2552 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2554 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2555 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2556 These macros can no longer be used for assignment.
2558 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2559 Assign struct members directly, instead of using BUF_BEGV etc.
2560 (record_buffer_markers, fetch_buffer_markers): New functions for
2561 recording and fetching special buffer markers.
2562 (set_buffer_internal_1, set_buffer_temp): Use them.
2564 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2566 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2568 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2569 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2571 * xdisp.c (hscroll_window_tree):
2572 (reconsider_clip_changes): Use PT instead of BUF_PT.
2574 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2576 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2577 $(EMACS_ROOT)/lib/intprops.h.
2579 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2581 Fix more problems found by GCC 4.5.2's static checks.
2583 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2584 to unsigned char * to avoid compiler diagnostic.
2585 (xg_free_frame_widgets): Make it clear that a local variable is
2586 needed only if USE_GTK_TOOLTIP.
2587 (gdk_window_get_screen): Make it clear that this macro is needed
2588 only if USE_GTK_TOOLTIP.
2589 (int_gtk_range_get_value): New function, which avoids a diagnostic
2590 from gcc -Wbad-function-cast.
2591 (xg_set_toolkit_scroll_bar_thumb): Use it.
2592 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2593 diagnostic from gcc -Wbad-function-cast.
2594 (get_utf8_string, xg_get_file_with_chooser):
2595 Rename locals to avoid shadowing.
2596 (create_dialog): Move locals to avoid shadowing.
2598 * xgselect.c (xg_select): Remove unused var.
2600 * image.c (four_corners_best): Mark locals as initialized.
2601 (gif_load): Initialize transparent_p to zero (Bug#8238).
2602 Mark another local as initialized.
2603 (my_png_error, my_error_exit): Mark with NO_RETURN.
2605 * image.c (clear_image_cache): Now static.
2606 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2607 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2608 (x_edge_detection): Remove unnecessary cast that
2609 gcc -Wbad-function-cast diagnoses.
2610 (gif_load): Fix pointer signedness.
2611 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2612 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2614 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2616 Improve quality of tests for time stamp overflow.
2617 For example, without this patch (encode-time 0 0 0 1 1
2618 1152921504606846976) returns the obviously-bogus value (-948597
2619 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2620 reports time overflow. See
2621 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2622 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2623 * editfns.c: Include limits.h and intprops.h.
2624 (TIME_T_MIN, TIME_T_MAX): New macros.
2625 (time_overflow): Move earlier, to before first use.
2626 (hi_time, lo_time): New functions, for an accurate test for
2628 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2629 (Fget_internal_run_time): Don't assume time_t fits in int.
2630 (make_time): Use list2 instead of Fcons twice.
2631 (Fdecode_time): More accurate test for out-of-range times.
2632 (check_tm_member): New function.
2633 (Fencode_time): Use it, to test for out-of-range times.
2634 (lisp_time_argument): Don't rely on undefined left-shift and
2635 right-shift behavior when checking for time stamp overflow.
2637 * editfns.c (time_overflow): New function, refactoring common code.
2638 (Fformat_time_string, Fdecode_time, Fencode_time):
2639 (Fcurrent_time_string): Use it.
2641 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2642 * dired.c (make_time): Move to ...
2643 * editfns.c (make_time): ... here.
2644 * systime.h: Note the move.
2646 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2648 * fringe.c (update_window_fringes): Remove unused variables.
2650 * unexmacosx.c (copy_data_segment): Also copy __got section.
2653 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2655 * termcap.c [MSDOS]: Include "msdos.h".
2656 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2657 Constify `char *' arguments and their references according to
2658 prototypes in tparam.h.
2660 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2662 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2663 Adapt all references accordingly.
2665 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2667 2011-03-11 Tom Tromey <tromey@redhat.com>
2669 * buffer.c (syms_of_buffer): Remove obsolete comment.
2671 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2673 * termhooks.h (encode_terminal_code): Declare prototype.
2675 * msdos.c (encode_terminal_code): Don't declare prototype.
2677 * term.c (encode_terminal_code): Now external again, used by
2678 w32console.c and msdos.c.
2680 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2681 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2683 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2685 Fix some minor problems found by GCC 4.5.2's static checks.
2687 * fringe.c (update_window_fringes): Mark locals as initialized
2689 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2691 * alloc.c (mark_fringe_data): Move decl from here ...
2692 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2693 to check its interface.
2694 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2696 * fontset.c (free_realized_fontset): Now static.
2697 (Fset_fontset_font): Rename local to avoid shadowing.
2698 (fontset_font): Mark local as initialized.
2699 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2701 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2703 * xselect.c (x_disown_buffer_selections): Remove; not used.
2704 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2705 (x_own_selection, Fx_disown_selection_internal): Rename locals
2707 (x_handle_dnd_message): Remove local to avoid shadowing.
2709 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2710 so that the caller can use some name other than gcpro1.
2711 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2712 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2713 (Fx_backspace_delete_keys_p):
2714 Use them to avoid shadowing, and rename vars to avoid shadowing.
2715 (x_decode_color, x_set_name, x_window): Now static.
2716 (Fx_create_frame): Add braces to silence GCC warning.
2717 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2718 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2719 Remove unused locals.
2720 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2721 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2722 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2725 * xterm.h (x_mouse_leave): New decl.
2727 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2728 Remove unused functions.
2729 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2730 (x_calc_absolute_position): Now static.
2731 (XTread_socket): Don't define label "out" unless it's used.
2732 Don't declare local "event" unless it's used.
2733 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2734 unless they are used.
2735 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2736 (x_fatal_error_signal): Remove; not used.
2737 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2738 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2739 (x_error_catcher, x_connection_closed, x_error_handler):
2740 (x_error_quitter, xembed_send_message, x_iconify_frame):
2741 (my_log_handler): Rename locals to avoid shadowing.
2742 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2743 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2745 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2746 Rename or move locals to avoid shadowing.
2747 (tty_defined_color, merge_face_heights): Now static.
2748 (free_realized_faces_for_fontset): Remove; not used.
2749 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2750 does not deduce is never used uninitialized.
2751 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2752 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2754 * terminal.c (store_terminal_param): Now static.
2756 * xmenu.c (menu_highlight_callback): Now static.
2757 (set_frame_menubar): Remove unused local.
2758 (xmenu_show): Rename parameter to avoid shadowing.
2759 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2760 since they might point to immutable storage.
2761 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2762 since it's unused otherwise.
2764 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2765 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2766 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2767 avoids a gcc -Wuninitialized diagnostic.
2768 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2769 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2770 does not deduce are never used uninitialized.
2772 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2774 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2775 * window.c (window_loop, size_window):
2776 (run_window_configuration_change_hook, enlarge_window): Likewise.
2778 * window.c (display_buffer): Now static.
2779 (size_window): Mark variables that gcc -Wuninitialized
2780 does not deduce are never used uninitialized.
2781 * window.h (check_all_windows): New decl, to forestall
2782 gcc -Wmissing-prototypes diagnostic.
2783 * dispextern.h (bidi_dump_cached_states): Likewise.
2785 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2787 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2789 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2790 and to avoid gcc -Wuninitialized warning.
2791 (load_charset_map): Mark variables that gcc -Wuninitialized
2792 does not deduce are never used uninitialized.
2793 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2795 * coding.c (coding_set_source, coding_set_destination):
2796 Use "else { /* comment */ }" rather than "else /* comment */;"
2797 for clarity, and to avoid gcc -Wempty-body warning.
2798 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2799 a block, when the outer 'i' will do.
2800 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2801 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2802 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2803 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2804 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2805 Rename locals to avoid shadowing.
2806 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2807 * coding.c (emacs_mule_char, encode_invocation_designation):
2808 Now static, since they're not used elsewhere.
2809 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2810 (decode_coding_object, encode_coding_object, detect_coding_system):
2811 (decode_coding_emacs_mule): Mark variables that gcc
2812 -Wuninitialized does not deduce are never used uninitialized.
2813 (detect_coding_iso_2022): Initialize a local variable that might
2814 be used uninitialized. Leave a FIXME because it's not clear that
2815 this initialization is needed. (Bug#8211)
2816 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2817 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2818 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2819 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2820 Remove unused macros.
2822 * category.c (hash_get_category_set): Remove unused local var.
2823 (copy_category_table): Now static, since it's not used elsewhere.
2824 * character.c (string_count_byte8): Likewise.
2826 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2827 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2829 * chartab.c (copy_sub_char_table): Now static, since it's not used
2831 (sub_char_table_ref_and_range, char_table_ref_and_range):
2832 Rename locals to avoid shadowing.
2833 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2835 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2836 (BIDI_BOB): Remove unused macro.
2838 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2839 deduce are never used uninitialized.
2840 * term.c (encode_terminal_code): Likewise.
2842 * term.c (encode_terminal_code): Now static. Remove unused local.
2844 * tparam.h: New file.
2845 * term.c, tparam.h: Include it.
2846 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2847 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2848 Move these decls to tparam.h, and make them agree with what
2849 is actually in tparam.c. The previous trick of using incompatible
2850 decls in different modules does not conform to the C standard.
2851 All callers of tparam changed to use tparam's actual API.
2852 * tparam.c (tparam1, tparam, tgoto):
2853 Use const pointers where appropriate.
2855 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2856 * cm.h (struct cm): Likewise.
2857 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2858 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2859 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2860 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2861 (turn_on_face, init_tty): Likewise.
2862 * termchar.h (struct tty_display_info): Likewise.
2864 * term.c (term_mouse_position): Rename local to avoid shadowing.
2866 * alloc.c (mark_ttys): Move decl from here ...
2867 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2869 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2871 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2873 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2875 * search.c (compile_pattern_1): Remove argument regp, unused since
2876 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2877 (compile_pattern): Don't pass it.
2879 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2881 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2882 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2884 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2886 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2888 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2889 gdk_window_get_screen, gdk_window_get_geometry,
2890 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2891 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2892 (xg_get_pixbuf_from_pixmap): New function.
2893 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2894 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2895 Call xg_get_pixbuf_from_pixmap instead of
2896 gdk_pixbuf_get_from_drawable.
2897 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2898 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2899 (xg_check_special_colors): Use GtkStyleContext and its functions
2901 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2902 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2903 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2904 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2905 Call gtk_widget_get_preferred_size.
2906 (xg_frame_resized): gdk_window_get_geometry only takes 5
2908 (xg_win_to_widget, xg_event_is_for_menubar):
2909 Call gdk_x11_window_lookup_for_display.
2910 (xg_set_widget_bg): New function.
2911 (delete_cb): New function.
2912 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2913 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2914 (xg_set_background_color): Call xg_set_widget_bg.
2915 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2916 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2917 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2918 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2920 (update_frame_tool_bar): Call gtk_widget_hide.
2921 (xg_initialize): Use GDK_KEY_g.
2923 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2925 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2927 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2928 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2929 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2931 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2933 * w32xfns.c (select_palette): Check success of RealizePalette against
2934 GDI_ERROR, not zero.
2936 See ChangeLog.11 for earlier changes.
2942 Copyright (C) 2011 Free Software Foundation, Inc.
2944 This file is part of GNU Emacs.
2946 GNU Emacs is free software: you can redistribute it and/or modify
2947 it under the terms of the GNU General Public License as published by
2948 the Free Software Foundation, either version 3 of the License, or
2949 (at your option) any later version.
2951 GNU Emacs is distributed in the hope that it will be useful,
2952 but WITHOUT ANY WARRANTY; without even the implied warranty of
2953 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2954 GNU General Public License for more details.
2956 You should have received a copy of the GNU General Public License
2957 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.