* image.c: Pacify --enable-gcc-warnings.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
99149625
PE
12013-10-10 Paul Eggert <eggert@cs.ucla.edu>
2
3 * image.c: Pacify --enable-gcc-warnings.
4 (GIFLIB_MAJOR, GIFLIB_MINOR, GIFLIB_RELEASE, fn_GifErrorString):
5 #define only if used.
6
a5dab159
EZ
72013-10-10 Eli Zaretskii <eliz@gnu.org>
8
9 * image.c (GIFLIB_MAJOR): Define to 4 if undefined.
10 (GIFLIB_MINOR, GIFLIB_RELEASE): Define to zero if undefined.
11 (GifErrorString) [GIFLIB_MAJOR >= 5]: Define a function pointer.
12 (gif_load): For giflib v5.x and later, display the error message
13 produced by giflib when its functions fail.
14 (syms_of_image) <Qlibgif_version> [HAVE_NTGUI]: New DEFSYM.
15 (Bug#15531)
16
6bbe6da8
DA
172013-10-10 Dmitry Antipov <dmantipov@yandex.ru>
18
19 * keyboard.c (last_event_timestamp): Remove. For X selection and
20 GTK popup menus, it may be obtained from per-frame X display info.
21 (kbd_buffer_store_event_hold, kbd_buffer_get_event)
22 (process_special_events): Adjust users.
23 * keyboard.h (last_event_timestamp): Remove declaration.
24 * xmenu.c (xmenu_show, create_and_show_popup_menu): Lost last arg.
25 Use FRAME_DISPLAY_INFO (f)->last_user_time for gtk_menu_popup.
26 * menu.h (xmenu_show): Adjust prototype.
27 * menu.c (Fx_popup_menu): Adjust user.
28 * xselect.c (x_own_selection, x_get_foreign_selection)
29 (Fx_disown_selection_internal): Use dpyinfo->last_user_time.
30
1afcba63
DA
312013-10-10 Dmitry Antipov <dmantipov@yandex.ru>
32
33 * keyboard.c (init_kboard): Now static. Add arg
34 to denote window system. Adjust comment.
35 (init_keyboard): Adjust user.
36 (allocate_kboard): New function.
37 (syms_of_keyboard):
38 * nsterm.m (ns_term_init):
39 * term.c (init_tty):
40 * w32term.c (w32_create_terminal):
41 * xterm.c (x_term_init): Use it.
42 * keyboard.h (init_kboard): Remove prototype.
43 (allocate_kboard): Add prototype.
44
f3606ef7
BF
452013-10-10 Barry Fishman <barry_fishman@acm.org> (tiny change)
46
47 * image.c (GIFLIB_MAJOR): Ensure it's defined.
48 (DGifOpen, DGifOpenFileName): Handle giflib 5 syntax. (Bug#15531)
49
e20bb249
PE
502013-10-09 Paul Eggert <eggert@cs.ucla.edu>
51
52 * fns.c (sxhash_bool_vector): Fix buffer read overrun.
53
9f6a18d2
EZ
542013-10-09 Eli Zaretskii <eliz@gnu.org>
55
56 * term.c (tty_menu_activate): Flush the output stream after
57 showing the cursor, and don't mark the frame garbaged at exit from
58 the function. Fixes redisplay glitches when moving from one menu
59 to another.
60
0486beac
JD
612013-10-09 Jan Djärv <jan.h.d@swipnet.se>
62
63 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Check input for valid UTF-8
64 or throw error (Bug#15570).
65
0d5d3029
PE
662013-10-09 Paul Eggert <eggert@cs.ucla.edu>
67
ab7ce978
PE
68 * intervals.c (temp_set_point_both): Move test into 'eassert',
69 for speed.
70
0d5d3029
PE
71 * lisp.h (eassert): Don't use 'assume'.
72 Sometimes 'assume' wins in performance, and sometimes it loses,
73 so it shouldn't be used all the time. Perhaps we need two
74 flavors of 'eassert', one for where 'assume' is far more likely
75 to help or to hurt; but that can be done later.
1afcba63 76 Problem reported by Dmitry Antipov in
0d5d3029
PE
77 <http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00276.html>.
78 Also, don't include <verify.h>; no longer needed.
79
fa022909
GM
802013-10-09 Glenn Morris <rgm@gnu.org>
81
82 * eval.c (Fcond): Doc tweak.
83
051277bf
EZ
842013-10-09 Eli Zaretskii <eliz@gnu.org>
85
86 * xfaces.c (x_free_gc) [HAVE_X_WINDOWS, HAVE_NTGUI]: Don't pass
87 expressions with side effects to eassert. (Bug#15565)
88
79804536
SM
892013-10-09 Stefan Monnier <monnier@iro.umontreal.ca>
90
91 * fns.c (hashfn_user_defined): Allow hash functions to return any
92 Lisp_Object.
93
3b158d11
PE
942013-10-08 Paul Eggert <eggert@cs.ucla.edu>
95
96 Fix minor problems found by static checking.
97 * dispnew.c (save_current_matrix): Omit unnecessary casts.
98 * dispnew.c (update_frame_with_menu): Mark debug local as used.
99 * keyboard.c, keyboard.h (Qmouse_movement): Now static.
100 * keyboard.c (read_menu_command): Remove unused local.
101 * lisp.h (read_menu_command): New decl.
102 * menu.c, menu.h (menu_item_width): Arg is now unsigned char *, for
103 benefit of STRING_CHAR_AND_LENGTH. All uses changed.
104 Return ptrdiff_t, not int.
105 * term.c (tty_menu_struct): 'allocated' member is now ptrdiff_t,
106 not int, for benefit of xpalloc.
107 (tty_menu_create, tty_menu_make_room): Simplify by using xzalloc
108 and xpalloc.
109 (have_menus_p): Remove; unused.
110 (tty_menu_add_pane, tty_menu_add_selection): Change signedness of
111 local char * pointer to pacify STRING_CHAR_AND_LENGTH.
112 (tty_menu_add_selection, tty_menu_locate, tty_meny_destroy):
113 Now static.
114 (save_and_enable_current_matrix): Omit unnecessary casts.
115 (read_menu_input): Omit local extern decl (now in lisp.h).
116 Don't access uninitialized storage if mouse_get_xy fails.
117 (tty_menu_activate): Mark local as initialized, for lint.
118 (tty_menu_activate, tty_meny_show): Remove unused locals.
119
4ed77415
EZ
1202013-10-08 Eli Zaretskii <eliz@gnu.org>
121
122 Support menus on text-mode terminals.
123 * xterm.h (xw_popup_dialog): Add prototype.
124
125 * xmenu.c (Fx_popup_dialog): Function moved to menu.c.
126 (xmenu_show): Block input here, instead in Fx_popup_menu.
127 (xw_popup_dialog): New function, with X-specific bits of popup
128 dialogs.
129
130 * xdisp.c (deep_copy_glyph_row, display_tty_menu_item): New
131 functions.
132
133 * window.c (Fset_window_configuration): Use run-time tests of the
134 frame type instead of compile-time conditionals, when menu-bar
135 lines are considered.
136
137 * w32term.h (w32con_hide_cursor, w32con_show_cursor)
138 (w32_popup_dialog): New prototypes.
139
140 * w32menu.c (Fx_popup_dialog): Function deleted.
141 (w32_popup_dialog): New function, with w32 specific bits of popup
142 dialogs. Block input here.
143
144 * w32inevt.c (w32_console_read_socket): Minor change to add
145 debugging TTY events.
146
147 * w32fns.c (show_hourglass): If returning early because the frame
148 is not a GUI frame, unblock input.
149
150 * w32console.c (w32con_hide_cursor, w32con_show_cursor, cursorX)
151 (cursorY): New functions.
152
153 * termhooks.h (cursorX, cursorY): Prototypes of functions on
154 WINDOWSNT, macros that call curX and curY elsewhere.
155
156 * termchar.h (struct tty_display_info) <showing_menu>: New flag.
157
158 * term.c (tty_hide_cursor, tty_show_cursor) [WINDOWSNT]: Call w32
159 specific function to hide and show cursor on a text-mode terminal.
160 (tty_menu_struct, struct tty_menu_state): New structures.
161 (tty_menu_create, tty_menu_make_room, tty_menu_search_pane)
162 (tty_menu_calc_size, mouse_get_xy, tty_menu_display)
163 (have_menus_p, tty_menu_add_pane, tty_menu_add_selection)
164 (tty_menu_locate, save_and_enable_current_matrix)
165 (restore_desired_matrix, screen_update, read_menu_input)
166 (tty_menu_activate, tty_menu_destroy, tty_menu_help_callback)
167 (tty_pop_down_menu, tty_menu_last_menubar_item)
168 (tty_menu_new_item_coords, tty_menu_show): New functions.
169 (syms_of_term): New DEFSYMs for tty-menu-* symbols.
170
171 * nsterm.h (ns_popup_dialog): Adjust prototype.
172
173 * nsmenu.m (ns_menu_show): Block and unblock input here, instead
174 of in x-popup-menu.
175 (ns_popup_dialog): Adapt order of arguments to the other
176 *_menu_show implementations.
177 (Fx_popup_dialog): Function deleted.
178
179 * msdos.c (x_set_menu_bar_lines): Delete unused function.
180
181 * menu.h (tty_menu_show, menu_item_width): provide prototypes.
182
183 * menu.c (have_boxes): New function.
184 (single_keymap_panes): Use it instead of a compile-time
185 conditional.
186 (single_menu_item): Use run-time tests of the frame type instead
187 of compile-time conditionals.
188 (encode_menu_string): New function.
189 (list_of_items, list_of_panes): Use it instead of ENCODE_STRING
190 the macro, since different types of frame need different encoding
191 of menu items.
192 (digest_single_submenu): Use run-time tests of frame type instead
193 of, or in addition to, compile-time conditionals.
194 (menu_item_width, Fmenu_bar_menu_at_x_y): New functions.
195 (Fx_popup_menu): Detect when the function is called from keyboard
196 on a TTY. Don't barf when invoked on a text-mode frame. Check
197 frame type at run time, instead of compile-time conditionals for
198 invoking terminal-specific menu-show functions. Call
199 tty_menu_show on text-mode frames.
200 (Fx_popup_dialog): Moved here from xmenu.c. Test frame types at
201 run time to determine which alternative to invoke; support dialogs
202 on TTYs.
203
204 * keyboard.h <Qmouse_movement>: Declare.
205
206 * keyboard.c <Qmouse_movement>: Now extern.
207 <Qecho_keystrokes>: New static variable.
208 (read_key_sequence): Accept an additional argument, a flag to
209 prevent redisplay during reading of the key sequence. All callers
210 changed.
211 (read_menu_command): New function.
212 (read_char): When COMMANDFLAG is -2, do not redisplay and do not
213 autosave.
214 (toolkit_menubar_in_use): New function.
215 (make_lispy_event): Use it instead of a compile-time test.
216
217 * fns.c (Fyes_or_no_p) [HAVE_MENUS]: Don't condition on
218 window-system being available.
219
220 * editfns.c (Fmessage_box) [HAVE_MENUS]: Don't condition the call
221 to x-popup-dialog on the frame type, they all now support popup
222 dialogs.
223
224 * dispnew.c (save_current_matrix): Save the margin areas.
225 (restore_current_matrix): Restore margin areas.
226 (update_frame_with_menu): New function.
227
228 * dispextern.h (display_tty_menu_item, update_frame_with_menu):
229 Add prototypes.
230
231 * alloc.c (make_save_ptr): Now compiled unconditionally.
232
ecab13d4
DA
2332013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
234
235 * dispnew.c (set_window_update_flags): Add buffer arg. Adjust comment.
236 (redraw_frame, update_frame): Adjust users.
237 * dispextern.h (set_window_update_flags): Adjust prototype.
238 * xdisp.c (redisplay_internal): When updating all frames with zero
239 windows_or_buffers_changed, assume that only the windows that shows
240 current buffer should be really updated.
241
f8498081
DA
2422013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
243
244 Do not allocate huge temporary memory areas and objects while encoding
245 for file I/O, thus reducing an enormous memory usage for large buffers.
246 See http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00180.html.
247 * coding.h (struct coding_system): New member raw_destination.
248 * coding.c (setup_coding_system): Initialize it to zero.
249 (encode_coding_object): If raw_destination is set, do not create
250 dst_object. Add comment.
251 * fileio.c (toplevel): New constant E_WRITE_MAX.
252 (e_write): Do not encode more than E_WRITE_MAX characters per one loop
253 iteration. Use raw_destination if E_WRITE_MAX characters is encoded.
254
d180bde8
JD
2552013-10-08 Jan Djärv <jan.h.d@swipnet.se>
256
257 * nsterm.m (windowDidExitFullScreen:):
258 (toggleFullScreen:): Change NS_IMPL_COCOA to HAVE_NATIVE_FS.
259
87c4314d
PE
2602013-10-08 Paul Eggert <eggert@cs.ucla.edu>
261
18978362
PE
262 Fix race where emacs aborts when sent SIGTERM (Bug#15534).
263 * keyboard.c (unblock_input_to): Don't process pending signals
264 if a fatal error is in progress.
265
87c4314d
PE
266 * lisp.h (bits_word, BITS_WORD_MAX): New type and macro.
267 All uses of 'size_t' and 'SIZE_MAX' changed to use them, when
268 they're talking about words in Lisp bool vectors.
269 (BITS_PER_BITS_WORD): Rename from BITS_PER_SIZE_T. All uses changed.
1142cc2a
PE
270 * data.c (popcount_bits_word): Rename from popcount_size_t.
271 (bits_word_to_host_endian): Rename from size_t_to_host_endian.
272 All uses changed.
87c4314d 273
595e113b
PE
2742013-10-07 Paul Eggert <eggert@cs.ucla.edu>
275
276 Improve support for popcount and counting trailing zeros (Bug#15550).
277 * data.c: Include <count-one-bits.h>, <count-trailing-zeros.h>.
278 (USE_MSC_POPCOUNT, POPCOUNT_STATIC_INLINE)
279 (NEED_GENERIC_POPCOUNT, popcount_size_t_generic)
280 (popcount_size_t_msc, popcount_size_t_gcc):
281 Remove; now done by Gnulib.
282 (popcount_size_t): Now a macro that defers to Gnulib.
283 (count_trailing_zero_bits): Return int, for consistency with
284 Gnulib and because Emacs prefers signed to unsigned int.
285 Don't assume that size_t is either unsigned int or unsigned long
286 or unsigned long long.
287 (size_t_to_host_endian): Do not assume that size_t is either
288 exactly 32 or exactly 64 bits wide.
289 * lisp.h (BITS_PER_SIZE_T): Define consistently with BITS_PER_LONG
290 etc., so that it's now an enum constant, not a macro.
291 No need to assume that it's either 32 or 64.
292
ddb317ba
JD
2932013-10-07 Jan Djärv <jan.h.d@swipnet.se>
294
295 * nsterm.m (windowDidEnterFullScreen:): setPresentationOptions only
296 on >= 10.7.
297
bd74250f
DA
2982013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
299
300 * insdel.c (insert_from_gap): Prefer ptrdiff_t to int where needed.
764636db 301 * xdisp.c (handle_fontified_prop): Likewise. Use bool for boolean.
bd74250f 302
223752d7
PE
3032013-10-07 Paul Eggert <eggert@cs.ucla.edu>
304
305 emacs_read and emacs_write now use void *, not char *.
306 * alloc.c (valid_pointer_p) [!WINDOWSNT]: Remove now-unnecessary cast.
307 * sysdep.c (emacs_read, emacs_write, emacs_write_sig):
308 Buffer arg is now void *, not char *. This matches plain
309 'read' and 'write' better, and avoids a constraint violation
310 on Solaris 9 with Oracle Studio.
311
3c439e0a
DA
3122013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
313
314 * alloc.c (Fmake_string): For ASCII char initializer, prefer
315 memset to explicit loop. Otherwise copy largest possible chunk
316 from initialized to uninitialized part, thus allowing the longer
317 memcpy runs and reducing the number of loop iterations.
318
28c76099
JD
3192013-10-06 Jan Djärv <jan.h.d@swipnet.se>
320
321 * nsterm.m (ns_update_begin): If native fullscreen and no toolbar,
322 hide toolbar (Bug#15388).
323 (windowDidEnterFullScreen:): If presentation options are zero,
324 set them here (Bug#15388).
a3e9050c
JD
325 (ns_update_auto_hide_menu_bar): Remove runtime check.
326 Don't auto hide dock unless menubar is also auto hidden.
28c76099 327
544a2a80
XF
3282013-10-05 Xue Fuqiao <xfq.free@gmail.com>
329
330 * editfns.c (message): Mention batch mode in doc string.
331
a27fd309
JD
3322013-10-05 Jan Djärv <jan.h.d@swipnet.se>
333
334 * nsterm.m (check_native_fs): Remove erroneous comment.
335
942f6f82
DA
3362013-10-04 Dmitry Antipov <dmantipov@yandex.ru>
337
338 * xdisp.c (redisplay_internal): Simplify because scan_for_column now
339 uses find_newline instead of scan_newline and so doesn't move point.
340
157fec2e
PE
3412013-10-04 Paul Eggert <eggert@cs.ucla.edu>
342
4eed3157
PE
343 Use hardware support for byteswapping on glibc x86 etc.
344 On Fedora 19 x86-64, the new bswap_64 needs 1 instruction,
345 whereas the old swap64 needed 30.
346 * fringe.c (init_fringe_bitmap) [WORDS_BIGENDIAN]:
347 * sound.c (le2hl, le2hs, be2hl) [!WINDOWSNT]:
348 Use byteswap.h's macros to swap bytes.
349 * lisp.h (swap16, swap32, swap64): Remove.
350 All uses replaced by bswap_16, bswap_32, bswap_64.
351
157fec2e
PE
352 * bytecode.c (exec_byte_code): Use some more volatile variables
353 to work around local variables getting clobbered by longjmp.
354 Port to pre-C99, which doesn't allow decls after stmts.
355
b52f569d
PE
3562013-10-03 Paul Eggert <eggert@cs.ucla.edu>
357
75273afb
PE
358 * lisp.h (eassert): Assume that COND is true when optimizing.
359 In other words, take on the behavior of eassert_and_assume.
360 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
361 (eassert_and_assume): Remove. All uses replaced by eassert.
362
ead45345
PE
363 * xdisp.c (Qglyphless_char): Now static.
364
0a858ebf
PE
365 Adjust to merge from gnulib.
366 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
367 * lisp.h: Include <verify.h>, for 'assume'.
368
b52f569d
PE
369 * eval.c (clobbered_eassert): New macro.
370 (internal_catch, internal_condition_case)
371 (internal_condition_case_1, internal_condition_case_2)
372 (internal_condition_case_n): Use it instead of eassert
373 when the argument contains locals clobbered by longjmp.
374 Don't use clobbered locals outside of clobbered_eassert.
375 (internal_lisp_condition_case): Use a volatile variable
376 to work around a local variable's getting clobbered.
377
adf2aa61
SM
3782013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
379
380 * lisp.h (struct handler): Merge struct handler and struct catchtag.
381 (PUSH_HANDLER): New macro.
382 (catchlist): Remove.
383 (handlerlist): Always declare.
384
385 * eval.c (catchlist): Remove (merge with handlerlist).
386 (handlerlist, lisp_eval_depth): Not static any more.
387 (internal_catch, internal_condition_case, internal_condition_case_1)
388 (internal_condition_case_2, internal_condition_case_n):
389 Use PUSH_HANDLER.
390 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
391 handlerlist/catchlist.
392 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
393 handlerlist which can only handle a single condition-case handler at
394 a time.
395 (find_handler_clause): Simplify since we only a single branch here
396 any more.
397
398 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
399 and Bpophandler.
400 (bcall0): New function.
401 (exec_byte_code): Add corresponding cases. Improve error message when
402 encountering an invalid byte-code. Let Bunwind_protect accept
403 a function (rather than a list of expressions) as argument.
404
405 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
406 and make them unconditional now that they're heap-allocated.
407
328a8179
SM
4082013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
409
410 * charset.c (Fdecode_char, Fencode_char): Remove description of
411 `restriction' arg. now that it's hidden by advertised-calling-convention.
412
c348360a
JD
4132013-10-02 Jan Djärv <jan.h.d@swipnet.se>
414
328a8179
SM
415 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
416 Remove unused variable (from mac-port).
c348360a
JD
417 (macfont_draw): Use s->ybase for correct y position.
418
1a23cd48
DA
4192013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
420
421 * frame.h (struct frame): Drop has_minibuffer member because...
422 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
423 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
424
29bf4de4
DA
4252013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
426
427 * window.h (struct window): Prefer enum text_cursor_kinds to int
428 for phys_cursor_type member. Move the latter, phys_cursor_width,
429 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
430 * window.c (replace_window, make_window): Adjust users.
431
a30ddace
DA
4322013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
433
434 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
435 this module is never compiled otherwise.
436
45435f08
AA
4372013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
438
439 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
440 (Bug#15500).
441
92e5298b
EZ
4422013-09-29 Eli Zaretskii <eliz@gnu.org>
443
444 * xdisp.c (get_next_display_element): Don't call face_for_font in
445 a build configured --without-x. (Bug#15484)
446
caa50be2
JD
4472013-09-29 Jan Djärv <jan.h.d@swipnet.se>
448
66d13b20
JD
449 * window.c (calc_absolute_offset): #elif should be #elif defined.
450
caa50be2
JD
451 * frame.c (delete_frame): Block/unblock input to overcome race
452 condition (Bug#15475).
453
d3e2acb6
AP
4542013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
455
456 * frame.c (delete_frame): Record selected frame only after
457 calling Qdelete_frame_functions (Bug#15477).
458
1610938f
JD
4592013-09-28 Jan Djärv <jan.h.d@swipnet.se>
460
461 * nsterm.m (ns_selection_color): Remove.
462 (ns_get_color): Check for ns_selection_(fg|bg)_color using
463 NSColor selectedText(Background)Color. Only for COCOA.
464 (ns_term_init): Remove assignment of ns_selection_color, logic
465 moved to ns_get_color.
466
328a8179 467 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
468 NS_SELECTION_COLOR_DEFAULT.
469 (NS_SELECTION_FG_COLOR_DEFAULT): New.
470
0d2647e6
EZ
4712013-09-28 Eli Zaretskii <eliz@gnu.org>
472
473 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
474 frame' does not have the tool_bar_window member.
475
ba355de0
BR
4762013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
477
478 Signal error when reading an empty byte-code object (Bug#15405)
479 * lread.c (read1): signal error
480 * alloc.c (make_byte_code): eassert header size
481 (sweep_vectors): change an int to size_t
482
4710d6f4
PE
4832013-09-24 Paul Eggert <eggert@cs.ucla.edu>
484
cf647d93
PE
485 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
486 instead of ints, as it's the usual style for offsetof constants. See:
487 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
488
4710d6f4
PE
489 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
490 This is ugly, but it should fix the performance problem for older
491 GCC versions in the short run. I'll look into integrating the
492 Gnulib module for popcount, as a better fix.
493 See the thread starting in:
494 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
495 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
496 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
497 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
498 (popcount_size_t): Use it.
499
10ebac9d
DC
5002013-09-24 Daniel Colascione <dancol@dancol.org>
501
502 * process.c (Fnetwork_interface_info): Fix build break due to
503 vector changes.
504
9da0f50e
PE
5052013-09-24 Paul Eggert <eggert@cs.ucla.edu>
506
507 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
508 Prefer signed to unsigned integers where either will do.
509 No need for 'const' on locals that do not escape.
510 Omit easserts with unnecessary and unportable assumptions about
511 alignment. Avoid unnecessary casts to char *.
512
d6d9cbc1
DA
5132013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
514
515 Use union for the payload of struct Lisp_Vector.
516 This helps to avoid a few glitches dictated by C's aliasing rules.
517 * lisp.h (struct Lisp_Vector): Use union for next and
518 contents member. Adjust comment. Change related users.
519 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
520 Related users changed.
521 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
522 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
523 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
524 * xfaces.c, xfont.c, xmenu.c: Related users changed.
525
ec7bc82f
DA
5262013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
527
528 Optimize glyph row clearing and copying routines.
529 * dispextern.h (struct glyph_row): Change layout of struct
530 glyph_row to help copy_row_except_pointers. Adjust comment.
531 * dispnew.c (null_row): Remove.
532 (clear_glyph_row): Use offsetof and memset to find and clear
533 just the members that need clearing. Adjust comment.
534 (copy_row_except_pointers): Likewise for copying.
535
d160dd0c
PE
5362013-09-24 Paul Eggert <eggert@cs.ucla.edu>
537
7be68de5
PE
538 Some minor cleanups of recently-added bool vector code.
539 * conf_post.h (assume): Always return void. Use lint version
540 only if GCC and MSC versions don't apply.
541 * conf_post.h (assume):
542 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
543 Depend on _MSC_VER, not __MSC_VER, for consistency with
544 the rest of Emacs.
545 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
546 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
547 (bool_vector_binop_driver, count_trailing_zero_bits)
548 (size_t_to_host_endian): Now static, not static inline;
549 the latter isn't needed with modern compilers and doesn't
550 work with older compilers anyway.
551
d160dd0c
PE
552 * alloc.c (valgrind_p): Use bool for boolean.
553
e08813d0
DA
5542013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
555
556 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
557 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
558 (display_last_displayed_message_p, message_buf_print)
559 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
560 Use bool for boolean.
3a6a78fd
DA
561 * dispextern.h (cancel_line, init_desired_glyphs):
562 Remove ancient leftover.
563 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
564 * lisp.h (noninteractive_need_newline): Adjust declaration.
565
5492865b
DA
5662013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
567
568 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
569 Move to...
570 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
571 ...this file and convert the latter to static. Adjust comment.
572 (make_initial_frame):
573 * window.c (init_window_once): Adjust user.
574 * frame.h (last_nonminibuf_frame): Remove declaration.
575 * lisp.h (selected_frame): Likewise.
576 * msdos.c (the_only_display_info): Adjust comment.
577
cd548fa4
EZ
5782013-09-23 Eli Zaretskii <eliz@gnu.org>
579
f03eddbf
EZ
580 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
581 computing the end column of mouse-highlight that comes from
582 display or overlay strings. (Bug#15437)
b519df23
EZ
583 (note_mouse_highlight): Adapt calculation of last argument to
584 mouse_face_from_string_pos to the above change.
f03eddbf 585
cd548fa4
EZ
586 * conf_post.h (__has_builtin): Define to zero, if undefined, on
587 all platforms, not just for clang.
588
8762e524
JD
5892013-09-23 Jan Djärv <jan.h.d@swipnet.se>
590
591 * filelock.c (lock_file_1): Rearrange to remove compiler warning
592 about excess arguments to snprintf.
593
594 * conf_post.h(assume): Use __builtin_unreachable for clang.
595
d4a9284f
JB
5962013-09-23 Juanma Barranquero <lekktu@gmail.com>
597
598 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
599 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
600
a84683fd
DC
6012013-09-23 Daniel Colascione <dancol@dancol.org>
602
603 * alloc.c (USE_VALGRIND): New macro; on by default
604 when ENABLE_CHECKING.
605 (mark_maybe_object,mark_maybe_pointer)
606 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
607 valgrind purposes.
608 (valgrind_p) [USE_VALGRIND]: New variable.
609 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
610
8fef36c6
JD
6112013-09-22 Jan Djärv <jan.h.d@swipnet.se>
612
fb83ea63
JD
613 * process.c (wait_reading_process_output): Change int pnamelen to
614 socklen_t.
615
616 * nsterm.m (setMarkedText:selectedRange:):
617 (deleteWorkingText):
618 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
619 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
620 argument to unsigned long to avoid warning.
621 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
622
8fef36c6
JD
623 * conf_post.h (assume): Fix compiler error: x shall be cond.
624
cd9356f2
DC
6252013-09-22 Daniel Colascione <dancol@dancol.org>
626
627 * xfns.c (x_get_monitor_attributes): Suppress unused variable
628 warning when compiling without a window system.
629
3e0b94e7
DC
6302013-09-22 Daniel Colascione <dancol@dancol.org>
631
632 * data.c (Qbool_vector_p): New symbol.
633 (bool_vector_spare_mask,popcount_size_t_generic)
634 (popcount_size_t_msc,popcount_size_t_gcc)
635 (popcount_size_t)
636 (bool_vector_binop_driver)
637 (count_trailing_zero_bits,size_t_to_host_endian)
638 (Fbool_vector_exclusive_or)
639 (Fbool_vector_union)
640 (Fbool_vector_intersection,Fbool_vector_set_difference)
641 (Fbool_vector_subsetp,Fbool_vector_not)
642 (Fbool_vector_count_matches)
643 (Fbool_vector_count_matches_at): New functions.
644 (syms_of_data): Intern new symbol, functions.
645 * alloc.c (bool_vector_payload_bytes): New function.
646 (Fmake_bool_vector): Instead of calling Fmake_vector,
647 which performs redundant initialization and argument checking,
648 just call allocate_vector ourselves. Make sure we clear any
649 terminating padding to zero.
650 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
651 instead of open-coding the size calculation.
652 (vroundup_ct): New macro.
653 (vroundup): Assume argument >= 0; invoke vroundup_ct.
654 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
655 * composite.c (composition_gstring_put_cache):
656 Change lint_assume to assume.
3e0b94e7
DC
657 * conf_post.h (assume): New macro.
658 (lint_assume): Remove.
659 * dispnew.c (update_frame_1): Change lint_assume to assume.
660 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
661 to assume.
662 * image.c (gif_load): Change lint_assume to assume.
663 * lisp.h (eassert_and_assume): New macro.
664 (Qbool_vector_p): Declare.
665 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
666 (swap16,swap32,swap64): New inline functions.
667 * macfont.c (macfont_shape): Change lint_assume to assume.
668 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
669 * xsettings.c (parse_settings): Use new swap16 and
670 swap32 from lisp.h instead of file-specific macros.
671
76880d88
EZ
6722013-09-22 Eli Zaretskii <eliz@gnu.org>
673
674 * xdisp.c (try_window_id): Don't abort if cursor row could not be
675 found (which can legitimately happen when the glyph row at the
676 window start is disabled in the current_matrix. (Bug#15365)
677
c6cfd910
PE
6782013-09-22 Paul Eggert <eggert@cs.ucla.edu>
679
680 Fix syntax.h bug introduced by recent INLINE change.
681 syntax.h defined an extern inline function SYNTAX_ENTRY that was
682 conditionally compiled one way in some modules, and a different
683 way in others. This doesn't work with extern inline functions,
684 which must have the same definition in all modules, because the
685 defining code might be shared across modules, depending on the
686 implementation. Symptoms reported by Martin Rudalics in:
687 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
688 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
689 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
690 overriding the corresponding functions in syntax.h.
691 * syntax.h (syntax_property_entry, syntax_property_with_flags)
692 (syntax_property): New inline functions.
693 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
694 Rewrite in terms of these new functions.
695
b3f1d119
EZ
6962013-09-21 Eli Zaretskii <eliz@gnu.org>
697
698 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
699 not chars_in_text, whose result depends on the multibyteness of
700 the current buffer. (Bug#15426)
701
00382e8b
PE
7022013-09-20 Paul Eggert <eggert@cs.ucla.edu>
703
e3b29769
PE
704 Port recent change to hosts where pointers aren't 'long'.
705 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
706 Don't assume that pointers are the same width as 'long'.
707 Add a compile-time check that a pointer fits into two X slots.
708
00382e8b
PE
709 A simpler, centralized INLINE.
710 * conf_post.h (INLINE): Define only if not already defined.
711 This allows us to use a single INLINE, defined by one file
712 per executable.
713 * emacs.c (INLINE): Define it.
714 Also, include category.h, charset.h, composite.h, dispextern.h,
715 syntax.h, systime.h, so that their INLINE definitions are expanded
716 properly for Emacs.
717 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
718 * buffer.h, buffer.c (BUFFER_INLINE):
719 * category.h, category.c (CATEGORY_INLINE):
720 * character.h, character.c (CHARACTER_INLINE):
721 * charset.h, charset.c (CHARSET_INLINE):
722 * composite.h, composite.c (COMPOSITE_INLINE):
723 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
724 * frame.h, frame.c (FRAME_INLINE):
725 * intervals.h, intervals.c (INTERVALS_INLINE):
726 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
727 * lisp.h, alloc.c (LISP_INLINE):
728 * process.h, process.c (PROCESS_INLINE):
729 * syntax.h, syntax.c (SYNTAX_INLINE):
730 * systime.h, sysdep.c (SYSTIME_INLINE):
731 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
732 * window.h, window.c (WINDOW_INLINE):
733 Remove. All uses replaced with INLINE.
734
2b943ba6
DA
7352013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
736
737 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
738 to avoid Bug#15398.
739
13d9698a
EZ
7402013-09-19 Eli Zaretskii <eliz@gnu.org>
741
742 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
743 'const char *' to avoid compiler warnings due to similar change in
744 the prototype of x_get_string_resource.
745
ced135eb
DA
7462013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
747
748 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
749 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
750 going to replace static variables below. Adjust comments.
751 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
752 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
753 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
754 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
755 Related users changed.
756 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
757 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
758 last_mouse_movement_time, going to replace static variables below.
759 Adjust comments.
760 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
761 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
762 Remove.
763 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
764 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
765 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
766 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
767 static variables below.
768 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
769 (last_mouse_scroll_bar): Remove.
770 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
771 (mouseExited): Related users changed.
772
091f1e1f
DA
7732013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
774
775 Do not use external array to process X scroll bar messages.
776 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
777 (x_send_scroll_bar_event): Pack window pointer into two slots
778 of XClientMessageEvent if we're 64-bit. Adjust comment.
779 (x_scroll_bar_to_input_event): Unpack accordingly.
780
582ed56c
DA
7812013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
782
783 Ifdef away recent changes which aren't relevant to NS port.
784 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
785 [!HAVE_NS]: Declare as such.
786 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
787 [!HAVE_NS]: Define as such.
788
18da0d8a
DA
7892013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
790
791 * frame.c (x_redo_mouse_highlight): New function
792 to factor out common code used in W32 and X ports.
793 * dispextern.h (x_redo_mouse_highlight): Add prototype.
794 * xterm.h (struct x_display_info):
795 * w32term.h (struct w32_display_info):
796 * nsterm.h (struct ns_display_info): New members
797 last_mouse_motion_frame, last_mouse_motion_x and
798 last_mouse_motion_y, going to replace static variables below.
799 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
800 (redo_mouse_highlight): Remove.
801 (note_mouse_movement, syms_of_xterm): Adjust user.
802 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
803 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
804 (redo_mouse_highlight): Remove.
805 (note_mouse_movement, syms_of_w32term): Adjust user.
806 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
807 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
808 Remove.
809 (note_mouse_movement, mouseMoved, syms_of_nsterm):
810 * nsfns.m (compute_tip_xy): Adjust user.
811
7a0c745a
DA
8122013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
813
814 * frame.c (x_mouse_grabbed): New function.
815 * dispextern.h (x_mouse_grabbed): Add prototype.
816 (last_mouse_frame): Remove declaration.
817 * xterm.h (struct x_display_info):
818 * w32term.h (struct w32_display_info):
819 * nsterm.h (struct ns_display_info): New member
820 last_mouse_frame, going to replace...
821 * xdisp.c (last_mouse_frame): ...global variable.
822 (note_tool_bar_highlight):
823 * w32term.c (w32_mouse_position, w32_read_socket):
824 * xterm.c (XTmouse_position, handle_one_xevent):
825 Use x_mouse_grabbed.
826 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
827
0791d107
DA
8282013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
829
830 * w32term.c (w32_read_socket): Avoid temporary
831 variables in a call to x_real_positions.
832 * xterm.c (handle_one_xevent): Likewise.
833
2cd98812
DA
8342013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
835
836 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
837 (x_icon_type): Remove prototype.
838 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
839 * frame.c (x_icon_type): Remove.
840 * w32term.c (x_make_frame_visible, x_iconify_frame):
841 * xterm.c (x_make_frame_visible, x_iconify_frame):
842 Use x_set_bitmap_icon to factor out common code.
843
a6c2ee1b
DA
8442013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
845
846 * dispextern.h (check_x_display_info, x_get_string_resource):
847 Declare here just once and unify the latter.
848 * frame.c (check_x_display_info, x_get_string_resource):
849 * nsterm.h (check_x_display_info):
850 * xrdb.c (x_get_string_resource):
851 * xterm.h (check_x_display_info): Remove prototypes.
852 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
853 * w32reg.c (x_get_string_resource): Likewise.
854 (w32_get_rdb_resource): Adjust user.
855
baed3603
DA
8562013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
857
858 * xterm.h (struct x_display_info): New member
859 x_pending_autoraise_frame, going to replace...
860 * xterm.c (pending_autoraise_frame): ...static variable.
861 (x_new_focus_frame, XTread_socket): Adjust users.
862 * w32term.h (struct w32_display_info): New member
863 w32_pending_autoraise_frame, going to replace...
864 * w32term.c (pending_autoraise_frame): ...global variable.
865 (x_new_focus_frame, w32_read_socket): Adjust users.
866
90582f05
GM
8672013-09-17 Glenn Morris <rgm@gnu.org>
868
869 * xdisp.c (message_dolog): If we create *Messages*,
870 switch it to messages-buffer-mode.
871
b7ad2f74
PE
8722013-09-17 Paul Eggert <eggert@cs.ucla.edu>
873
874 Don't overuse 'const' in types of locals.
875 * bidi.c (bidi_count_bytes):
876 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
877 (xg_event_is_for_scrollbar):
878 * xselect.c (x_handle_property_notify)
879 (x_handle_selection_notify, x_handle_dnd_message):
880 * xsettings.c, xsettings.h (xft_settings_event):
881 * xterm.c (x_handle_net_wm_state, handle_one_event)
882 (x_menubar_window_to_frame, x_detect_focus_change)
883 (construct_mouse_click, note_mouse_movement)
884 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
885 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
886 (handle_one_xevent, x_handle_net_wm_state):
887 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
888 (x_handle_dnd_message):
889 Avoid unnecessary 'const', typically the second 'const' in
890 'const foo * const arg', a 'const' that does not affect the API
891 and doesn't significantly help the human reader.
892
19452b86
DA
8932013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
894
895 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
896 only if Glib < 2.36.0.
897 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
898 * xsettings.c (init_gconf, init_gsettings): Do not check
899 for g_type_init.
1893694e
DA
900 * xterm.c (handle_one_xevent): Do not call to x_clear_area
901 if GTK >= 2.7.0.
33b83dd7 902 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 903
6434e343
JD
9042013-09-16 Jan Djärv <jan.h.d@swipnet.se>
905
3f386383
JD
906 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
907 before calling g_type_init.
908
6434e343
JD
909 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
910
911 * nsterm.m (syms_of_nsterm): ... to here.
912
83a119f8
DA
9132013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
914
915 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
916 (ignore_next_mouse_click_timeout): Use Time as X does.
917 (handle_one_xevent): Avoid cast and use unsigned comparison.
918
61582e6a
DA
9192013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
920
921 Do not copy X event in handle_one_xevent except KeyPress case.
922 Wnen XEvent is processed, it is unlikely to be changed except
923 KeyPress case, so we can avoid copying and use const pointer to
924 const data to make sure that an event is not changed elsewhere.
925 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
926 const' and do not create local copy except for the KeyPress event.
927 Use casts to avoid a few glitches. Adjust formatting. Add comments.
928 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
929 (x_handle_net_wm_state, x_menubar_window_to_frame)
930 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
931 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
932 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
933 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
934 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
935 (x_handle_dnd_message):
936 * xsettings.c (xft_settings_event):
937 Use 'const XEvent * const' where appropriate.
938 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
939
f8eb1572
DA
9402013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
941
942 Fix X event waiting to handle multiple frames.
943 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
944 * xterm.c (pending_event_wait): Remove. Adjust users.
945 (x_detect_focus_change): Pass frame arg.
946 (handle_one_xevent): Find related frame early and clear per-frame
947 wait_event_type only if this is an event for the relevant frame.
948 (x_wait_for_event): Use per-frame wait_event_type.
949
3fa2054e
JD
9502013-09-15 Jan Djärv <jan.h.d@swipnet.se>
951
745d3809
JD
952 * nsfns.m (Fx_create_frame): Fix font driver registration for
953 GNUStep.
954
955 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
956 for syms_of_macfont.
957
3fa2054e
JD
958 * nsterm.m: Include macfont.h.
959 (ns_tmp_flags, ns_tmp_font): Remove.
960 (ns_compute_glyph_string_overhangs): Check for driver Qns.
961 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
962 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
963 (changeFont:): Fix code style. Check for font driver type when
964 getiing font.
965
966 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
967 (f)->descent.
968
969 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
970 (nsfont_open): Set font driver type.
971 Set font->ascent and font->descent. Figure out font instead of
972 ns_tmp_font, and flags instead of ns_tmp_flags.
973 Fix indentation. Remove call to ns_draw_text_decoration,
974 moved to nsterm.
975
976 * nsfns.m: Include macfont.h.
977 (Fx_create_frame): Register macfont driver, make a better default font.
978 (Fns_popup_font_panel): Get font from macfont driver, if used.
979
980 * macfont.m, macfont.h, maccuvs.h: New files.
981
982 * font.h: Declare syms_of_macfont.
983
984 * font.c (syms_of_font): Call syms_of_macfont.
985
986 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
987
0eed0355
DA
9882013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
989
990 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
991 and it is always zero for others, so I assume that this is an ancient
992 leftover which nobody will want to change any more.
993 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
994 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
995 * frame.c (x_set_scroll_bar_width):
996 * w32fns.c (w32_createscrollbar):
997 * w32term.c (w32_set_vertical_scroll_bar):
998 * xfns.c (x_set_scroll_bar_default_width):
999 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
1000 (x_scroll_bar_expose): Related users changed.
1001
07013c68
DA
10022013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
1003
1004 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
1005 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
1006 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
1007 Define as such.
c7cc32f7
DA
1008 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
1009 Define once here...
1010 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
1011 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
1012 Remove unused Xisms.
7f09455e
DA
1013 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
1014 these modules are never compiled otherwise.
07013c68 1015
0df00f59
EZ
10162013-09-14 Eli Zaretskii <eliz@gnu.org>
1017
08a209bf 1018 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
1019 Doc fix. (Bug#15375)
1020
fcd42c11
DA
10212013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1022
1023 Unify Fx_focus_frame between all ports.
1024 * frame.h (x_focus_frame): New prototype.
1025 * xfns.c (Fx_focus_frame): Remove.
1026 (syms_of_xfns): Do not defsubr it.
1027 (x_focus_frame): X implementation.
1028 * nsfns.m (Fx_focus_frame): Remove.
1029 (syms_of_nsfns): Do not defsubr it.
1030 (x_focus_frame): NS implementation.
1031 * w32term.c (Fx_focus_frame): Remove.
1032 (x_focus_on_frame): Rename to...
1033 (x_focus_frame): W32 implementation.
1034 * w32term.h (x_focus_on_frame): Remove prototype.
1035 * w32fns.c (Fx_focus_frame): Remove.
1036 (syms_of_w32fns): Do not defsubr it.
1037 * frame.c (Fx_focus_frame): Define here.
1038 (syms_of_frame): Defsubr here.
1039 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
1040
aad3612f
DA
10412013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1042
1043 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
1044 All of them are replaced with FRAME_DISPLAY_INFO, defined in
1045 each port to reference the port-specific window system data.
1046 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
1047 (FRAME_DISPLAY_INFO): Define.
1048 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
1049 (FRAME_DISPLAY_INFO): Define. Adjust users.
1050 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
1051 (FRAME_DISPLAY_INFO): Define. Adjust users.
1052 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
1053 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
1054 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
1055 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
1056 * xselect.c, xterm.c: All related users changed.
1057
9a650e62
DA
10582013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 * xterm.h (x_window_to_frame, x_any_window_to_frame)
1061 (x_menubar_window_to_frame): Remove prototypes.
1062 * xfns.c (x_window_to_frame, x_any_window_to_frame)
1063 (x_menubar_window_to_frame, x_top_window_to_frame):
1064 Move from here...
1065 * xterm.c (x_window_to_frame, x_any_window_to_frame)
1066 (x_menubar_window_to_frame, x_top_window_to_frame):
1067 ...to here and convert all but the last to static.
1068
347ae3e1
EZ
10692013-09-12 Eli Zaretskii <eliz@gnu.org>
1070
1071 * lisp.mk (lisp): Add w32-common-fns.elc.
1072
15c6d837
XF
10732013-09-12 Xue Fuqiao <xfq.free@gmail.com>
1074
1075 * charset.c (char_charset): Document an exception for char-charset.
1076
27e90f77
DA
10772013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1078
1079 * xterm.h (x_display_info): New field last_user_time...
1080 * xterm.c (toplevel): ...to replace static last_user_time.
1081 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
1082
8ffbc36b
DA
10832013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1084
1085 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
1086 scroll bar values to prevent thumb from disappear and update comment.
1087
5ec0337a
GM
10882013-09-11 Glenn Morris <rgm@gnu.org>
1089
1090 * emacs.c (usage_message): Possessive apostrophe tweak.
1091
fb55b9d1
DA
10922013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1093
8d2db8be
DA
1094 * nsterm.m (syms_of_nsterm): Use Qns.
1095 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
1096 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
1097 * xfns.c (x_display_info_for_name, Fx_open_connection):
1098 Remove old '#if 0' code.
1099 (syms_of_xfns): Use Qx.
fb55b9d1
DA
1100 * termhooks.h (fullscreen_hook): Remove the leftover.
1101 (struct terminal): Fix typo in comment.
1102
927eec55
DA
11032013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1104
1105 Cleaning up a few X scroll bar bits.
1106 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
1107 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1108 New member last_seen_part, going to replace...
1109 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
1110 (xt_action_hook) [USE_LUCID]: Adjust user.
1111 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
1112 Lucid-specific scroll bar support.
1113 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
1114 to int and adjust to use last_seen_part member.
1115 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
1116 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1117 Initialize last_seen_part.
1118
71b28baa
SM
11192013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1120
1121 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
1122 insert-buffer-substring an empty string.
1123
f5dacaae
PE
11242013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1125
1126 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
1127 avoiding a GCC warning.
1128
742516e0
DA
11292013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1130
1131 Ifdef away frame tool bar code when it is not really used.
1132 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
1133 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
1134 and minimize_tool_bar_window_p under the above.
1135 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1136 (fset_tool_bar_window): Likewise.
1137 * dispnew.c (clear_current_matrices, clear_desired_matrices)
1138 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
1139 (change_frame_size_1):
1140 * window.c (window_from_coordinates, Frecenter): Adjust users.
1141 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
1142 code is not really used.
1143 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
1144 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
1145 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
1146 [!USE_GTK && !HAVE_NS]: Define as such.
1147 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
1148 (note_mouse_highlight, expose_frame):
1149 * xfns.c (x_set_tool_bar_lines):
1150 * xterm.c (handle_one_xevent): Adjust users.
1151
73f82c7e
PE
11522013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1153
1154 Fix corruption with multiple emacsclient -t instances (Bug#15222).
1155 This bug was introduced by my 2013-08-26 patch, which incorrectly
1156 assumed that the terminfo implementation doesn't use termcap buffers.
1157 * term.c (init_tty) [TERMINFO]: Remove optimization, as
1158 these buffers apparently are used after all.
1159 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
1160 (struct tty_display_info): Define members termcap_term_buffer and
1161 termcap_strings_buffer even if TERMINFO.
1162
53482f41
DA
11632013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1164
1165 Fix last change.
1166 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
1167 'usage' docstring entry to pacify make-docfile.
1168
11692013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
1170
1171 Change comparison functions =, <, >, <=, >= to take many arguments.
1172 * data.c: Change comparison functions' interface and implementation.
1173 * lisp.h: Make arithcompare available for efficient two arg
1174 comparisons.
1175 * bytecode.c: Use arithcompare.
1176 * fileio.c: Use new interface.
1177
533f258f
SM
11782013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1179
1180 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
1181
8c27f5ff
SM
11822013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
1183
1184 * eval.c (Feval): Document the new use of `lexical'.
1185
0750a308
DA
11862013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 Review and drop old frame resize hack.
1189 * frame.h (struct frame): Remove force_flush_display_p.
1190 * dispnew.c (update_frame): Adjust user and don't call
1191 flush_frame here. The comment has said that there was an issues
1192 with redisplaying fringes, but I don't see any differences with
1193 and without this hack. Hopefully we can continue without it.
1194 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
1195 current frame matrices twice if resized_p is set.
1196
83fc0554
DA
11972013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1198
1199 Do not populate pure Xism x_sync to other ports.
1200 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
1201 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
1202 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
1203 * w32term.h (x_sync): Remove prototype.
1204
fd462129
DA
12052013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Cleanup frame flushing.
8c27f5ff
SM
1208 * dispextern.h (struct redisplay_interface):
1209 Drop flush_display_optional because flush_display is enough
fd462129
DA
1210 for X and flushing via RIF is just a no-op for others.
1211 * frame.h (flush_frame): New function.
1212 * dispnew.c (update_frame):
1213 * minibuf.c (read_minibuf):
1214 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
1215 Use it.
1216 * keyboard.c (detect_input_pending_run_timers): Do not flush
1217 all frames but selected one in redisplay_preserve_echo_area.
1218 * nsterm.m (ns_flush): Remove no-op.
1219 (ns_redisplay_interface): Adjust user.
1220 * w32term.h (x_flush): Remove no-op.
1221 (w32_redisplay_interface): Adjust user.
1222 * xterm.c (x_flush): Simplify because we do not flush all
1223 frames at once any more. Adjust comment.
1224 (x_redisplay_interface): Adjust user.
1225
4b73fc73
PE
12262013-09-07 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 Port --without-x --enable-gcc-warnings to Fedora 19.
1229 * gfilenotify.c (globals_of_gfilenotify):
1230 Call g_type_init only if using an older glib version that needs it.
1231
77394d40
DA
12322013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1233
1234 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1235 (last_glyphless_glyph_merged_face_id): Remove declarations.
1236 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
1237 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1238 (last_glyphless_glyph_merged_face_id): Now static.
1239 (merge_escape_glyph_face): New function, refactored from...
1240 (get_next_display_element): ...here.
1241 (merge_glyphless_glyph_face): New function, refactored from...
1242 (produce_glyphless_glyph): ...here...
1243 * term.c (produce_glyphless_glyph): ...and here.
1244
306d67bd
SM
12452013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
1246
1247 * eval.c (eval_sub): Only call Ffunction if necessary.
1248
7f6c6450
DA
12492013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1250
1251 Attempt to make redisplay more selective when changing cursor type.
1252 * frame.h (struct frame): New bitfield cursor_type_changed.
1253 * xdisp.c (cursor_type_changed): Remove.
1254 (try_cursor_movement, redisplay_window, try_window_id)
1255 (set_frame_cursor_types, try_window_reusing_current_matrix):
1256 Adjust to use per-frame bitfield.
1257 (redisplay_internal): Look for cursor type change on each visible
1258 frame and consider all frames if cursor type has been changed on
1259 the frame other than selected. If cursor type has been changed on
1260 selected frame only, do not use fast update.
1261
bd0443bb
DA
12622013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1263
1264 Attempt to make redisplay more selective when changing fonts.
1265 * frame.h (struct frame): New bitfield fonts_changed.
1266 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
1267 (adjust_frame_glyphs): Add prototype.
1268 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 1269 (adjust_glyphs): Remove because we do not
bd0443bb
DA
1270 adjust matrices on all frames at once any more.
1271 (adjust_frame_glyphs): Block and unblock input here.
1272 (adjust_glyph_matrix): Use fonts_changed.
1273 (change_frame_size_1): Use adjust_frame_glyphs.
1274 * font.c (font_open_entity): Use fonts_changed.
1275 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
1276 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1277 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
1278 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
1279 (shrink_mini_window, Fresize_mini_window_internal)
1280 (window_scroll_pixel_based, Fset_window_configuration)
1281 (apply_window_adjustment, Fset_window_vscroll):
1282 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1283 Use adjust_frame_glyphs.
1284 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
1285 (try_window_reusing_current_matrix, try_window_id, display_line)
1286 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
1287 (redisplay_internal): Consider fonts_changed and adjust frame
1288 matrices for each frame only if the frame is visible. If font
1289 has been changed on some frame during full redisplay, retry
1290 only visible frames where the font has been actually changed.
1291
b9695828
DA
12922013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1293
1294 Cache current header and mode line height for each window.
1295 * window.h (struct window): New fields mode_line_height
1296 and header_line_height.
1297 * window.c (make_window): Initialize them.
1298 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
1299 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
1300 (current_mode_line_height, current_header_line_height):
1301 Remove declaration.
1302 * xdisp.c (current_mode_line_height, current_header_line_height):
1303 Remove.
1304 (pos_visible_p, init_xdisp): Adjust user.
1305 (redisplay_window): Invalidate mode_line_height and
1306 header_line_height if current and desired matrices do not agree.
1307
66738305
DA
13082013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1309
1310 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
1311 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
1312
257b3b03
DA
13132013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1314
1315 Make --without-x compatible with --enable-gcc-warnings.
1316 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
1317 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
1318 members under HAVE_WINDOW_SYSTEM.
1319 * keyboard.c (make_lispy_focus_out): Likewise.
1320 (record_menu_key): Move under HAVE_MENUS.
1321 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
1322 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
1323 (syms_of_xdisp): Adjust user.
1324 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
1325 (start_hourglass, cancel_hourglass):
1326 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
1327 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
1328 and CLEAR_FONT_TABLE_NFONTS.
1329 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
1330 Declare only if HAVE_WINDOW_SYSTEM.
1331 (lface_same_font_attributes_p, clear_face_gcs): Define only
1332 if HAVE_WINDOW_SYSTEM.
1333
98b7f4bd
DA
13342013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1335
1336 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
1337 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
1338 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
1339
a7e43722
SM
13402013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
1341
1342 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
1343
0c90b9ee
PE
13442013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
1347 This fixes a type error on hosts where ptrdiff_t is wider than int.
1348
d99760fa
SM
13492013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1350
6629638e
SM
1351 * keyboard.c (read_key_sequence_vs): New function.
1352 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
1353 common code.
1354
d99760fa
SM
1355 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1356
224e313d
PE
13572013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 Makefile improvements.
1360 * Makefile.in (config.status): Don't use double-colon rules, as
1361 they are not portable according to POSIX. Fix shell typo with `;
1362 I guess this rule has never been tested?
1363 (VCSWITNESS): New macro, to override any environment var.
1364
6d6ed1af
DA
13652013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1366
1367 * xterm.h (struct x_display_info): Do not track X connection
1368 fd separately because it is always available from Display.
1369 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1370 Adjust users.
1371
bc923770
DA
13722013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 * buffer.c (drop_overlay):
1375 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1376 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1377
b1cf96de
DA
13782013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1379
1380 * buffer.c (Fmake_overlay, Fmove_overlay):
1381 * intervals.c (set_point_from_marker):
1382 * print.c (PRINTPREPARE): Prefer signal_error
1383 to plain error and report unsuitable marker too.
1384
d1fc6c21
DA
13852013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1386
1387 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1388 for 'dragging' member.
d1ae6a0b
DA
1389 (struct x_output): Remove set-but-unused leftovers
1390 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1391 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1392 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1393 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1394 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1395 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1396 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1397 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1398 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1399
0ce9f6de
JD
14002013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1401
1402 * nsfont.m (INVALID_GLYPH): New define.
1403 (nsfont_encode_char): Use INVALID_GLYPH.
1404 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1405
b594a96c
DA
14062013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1407
1408 * xterm.c (x_last_mouse_movement_time): Revert last change.
1409 This code should use XDisplayMotionBufferSize to check display's
1410 motion history first, and there are few other issues as well.
1411 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1412 (handle_one_xevent): Adjust user.
1413
8b098236
MR
14142013-09-02 Martin Rudalics <rudalics@gmx.at>
1415
9718b207
MR
1416 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1417 * frame.c (Flast_nonminibuf_frame): ... to here.
1418 (check_minibuf_window): Don't abort if no window was found
1419 (Bug#15247).
8b098236 1420
84e70bba
DA
14212013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1422
1423 Use XGetMotionEvents to ask the last mouse motion time from X server.
1424 * xterm.c (X_MOTION_HISTORY): Default to 1.
1425 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1426 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1427 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1428 Ifdef away legacy code.
1429 (XTmouse_position, x_scroll_bar_report_motion):
1430 Use x_last_mouse_movement_time.
fc85e20b
DA
1431 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1432 UnmapNotify event.
84e70bba 1433
1fccc530
DA
14342013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 * msdos.c (last_mouse_window): Move to...
1437 (dos_rawgetc): ...this function and adjust comment.
1438 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1439 (mouseMoved): ...this function and adjust comment.
1440 * w32term.c (last_window): Likewise with...
1441 (w32_read_socket): ...this function.
1442 * xterm.c (last_window): Likewise with...
1443 (handle_one_xevent): ...this function.
1444
0ab10992
DA
14452013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1446
b7da754d 1447 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1448 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1449 (handle_one_xevent): ...to here.
1450 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1451 otherwise.
1452
0c7f856e
DA
14532013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1454
1455 * msdos.c (IT_set_terminal_window): Remove no-op.
1456 (initialize_msdos_display): Adjust terminal setup.
1457 * w32console.c (w32con_set_terminal_window): Remove no-op.
1458 (initialize_w32_display): Adjust terminal setup.
1459 * w32term.c (w32_set_terminal_window): Remove no-op.
1460 (w32_create_terminal): Adjust terminal setup.
1461 * xterm.c (XTset_terminal_window): Remove no-op.
1462 (x_create_terminal): Adjust terminal setup.
1463
a892a94c
DA
14642013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1465
1466 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1467 Remove no-ops.
1468 (ns_create_terminal): Adjust terminal setup.
1469 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1470 Remove no-ops.
1471 (w32_create_terminal): Adjust terminal setup.
1472 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1473 Remove no-ops.
1474 (x_create_terminal): Adjust terminal setup.
1475
cf91889a
DA
14762013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1477
1478 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1479 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1480 * dispnew.c (buffer_posn_from_coords):
1481 * window.c (Fwindow_end, displayed_window_lines):
1482 * xdisp.c (redisplay_mode_lines): Use it.
1483
5b0891df
JD
14842013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1485
1486 * fontset.c (face_for_char): Check char in the current face font first
1487 if HAVE_NS (Bug#15138).
1488
0a357e98
MR
14892013-08-31 Martin Rudalics <rudalics@gmx.at>
1490
1491 * window.c (temp_output_buffer_show): Make sure window returned
1492 by display_buffer is live (Bug#15213).
1493
9d7693d7
DA
14942013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1495
1496 Minor cleanup to avoid forward declarations.
1497 * coding.h (struct ccl_spec): Remove forward declaration.
1498 * composite.h (toplevel): Include font.h.
1499 (struct composition_it, struct face, struct font_metrics):
1500 Remove forward declaration.
1501 * dispextern.h (struct image, struct atimer): Likewise.
1502 * emacsgtkfixed.h (struct frame): Likewise.
1503 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1504 * font.h (struct font_driver, struct font, struct glyph_string)
1505 (struct face): Remove forward declaration.
1506 * fontset.h (struct face, struct font): Likewise.
1507 * frame.h (toplevel): Style cleanup.
1508 (enum output_method): Move to...
1509 * termhooks.h (enum output_method): ...here.
1510 (struct glyph, struct frame, struct ns_display_info)
1511 (struct x_display_info, struct w32_display_info):
1512 Remove forward declaration.
1513 * xterm.h (toplevel): Include termhooks.h.
1514 (struct font, struct window, struct glyph_matrix, struct frame)
1515 (struct input_event, struct face, struct image): Remove forward
1516 declaration.
1517 * gtkutil.h (struct _widget_value): Likewise.
1518 * keyboard.h (toplevel): Include termhooks.h.
1519 (struct input_event): Remove forward declaration.
1520
032f7451
DA
15212013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1522
1523 * intervals.c (set_point_from_marker): New function.
1524 * editfns.c (Fgoto_char):
1525 * process.c (Finternal_default_process_filter):
1526 * window.c (select_window_1): Use it.
1527 * buffer.h (set_point_from_marker): Add prototype.
1528
3f940c5a
EZ
15292013-08-29 Eli Zaretskii <eliz@gnu.org>
1530
1531 * w32.c (term_winsock): Call release_listen_threads before calling
1532 WSACleanup.
1533 (_sys_wait_accept): Wait for accept event in a loop with a finite
1534 timeout, instead of waiting indefinitely. Will hopefully avoid
1535 hanging during exit because WSACleanup deadlocks waiting for the
1536 event object to be released. (Bug#14333)
1537
1538 * w32proc.c (release_listen_threads): New function, signals all
1539 the reader threads that listen for connections to stop waiting.
1540
1541 * w32.h (release_listen_threads): Add prototype.
1542
101ed2bb
DA
15432013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1544
1545 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1546 field of new marker (for sanity and safety).
20de2834
DA
1547 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1548 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1549
1f5cf200
DA
15502013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1551
1552 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1553 (x_after_update_window_line, x_scroll_bar_create):
1554 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1555 (handle_one_xevent, x_clear_frame_area):
1556 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1557 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1558 * xterm.h (x_clear_area): Adjust prototype.
1559
d2b36813
DA
15602013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1561
1562 Hook scanning and indentation functions to find_newline. This helps
1563 to avoid duplicated code and renders more respect to newline cache.
1564 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1565 * cmds.c (Fforward_line):
1566 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1567 Use find_newline and avoid unnecessary point movements.
1568 * search.c (scan_newline): Implement on top of find_newline.
1569
3ec7babc
SM
15702013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1571
1572 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1573 scoped code (bug#11258).
1574
5ab473cd
JD
15752013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1576
1577 * nsterm.m (last_window): New variable.
1578 (EV_TRAILER2): New macro.
1579 (EV_TRAILER): Call EV_TRAILER2.
1580 (mouseMoved:): Add support for mouse-autoselect-window
1581 on nextstep (Bug#6888).
1582
78779650
AS
15832013-08-28 Andreas Schwab <schwab@suse.de>
1584
1585 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1586 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1587 Remove unused macro definitions.
1588 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1589 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1590 Only define if emacs.
78779650 1591
c3c4768d
DA
15922013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1593
1594 Prefer enum glyph_row_area to int where appropriate.
1595 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1596 Fix comment.
1597 (window_box, window_box_width, window_box_left, window_box_left_offset)
1598 (window_box_right, window_box_right_offset): Adjust prototypes.
1599 * xdisp.c (window_box, window_box_width, window_box_left)
1600 (window_box_left_offset, window_box_right, window_box_right_offset):
1601 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1602 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1603 * nsterm.m (ns_clip_to_row):
1604 * w32term.c (w32_clip_to_row):
1605 * xterm.c (x_clip_to_row): Likewise.
1606
6bdcbfe1
DA
16072013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1608
1609 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1610 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1611
50b13cde
PE
16122013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1613
1614 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1615 for portability to hosts where /bin/sh has problems.
1616
f60e429a
DA
16172013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1618
1619 Redesign redisplay interface to drop global output_cursor.
1620 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1621 (toplevel): Remove declaration of output_cursor.
1622 (set_output_cursor, x_cursor_to): Remove prototype.
1623 * window.h (struct window): New member output_cursor.
1624 (output_cursor_to): New function to replace RIF member.
1625 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1626 (update_text_area, set_window_cursor_after_update): Use it.
1627 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1628 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1629 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1630 * w32term.c (x_update_window_begin, x_update_window_end):
1631 * xterm.c (x_update_window_begin, x_update_window_end):
1632 Adjust to use per-window output cursor.
1633
43aac990
PE
16342013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1635
d486344e
PE
1636 Simplify SELECT_TYPE-related code.
1637 Like EMACS_TIME, this portability layer is no longer needed, since
1638 Emacs has been using fd_set as a portability layer for some time.
1639 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1640 (SELECT_TYPE): Remove. All uses changed to fd_set.
1641 (fd_set) [!FD_SET]: New typedef.
1642
43aac990
PE
1643 Simplify EMACS_TIME-related code.
1644 This portability layer is no longer needed, since Emacs has been
1645 using struct timespec as a portability layer for some time.
1646 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1647 Include <time.h> rather than "systime.h"; that's all that's needed now.
1648 * dispnew.c: Include <timespec.h> rather than "systime.h";
1649 that's all that's needed now.
1650 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1651 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1652 TIMESPEC_RESOLUTION.
1653 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1654 LOG10_TIMESPEC_RESOLUTION.
1655 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1656 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1657 (make_emacs_time): Remove. All used changed to make_timespec.
1658 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1659 (current_timespec): Rename from current_emacs_time. All uses changed.
1660 (add_emacs_time): Remove. All uses changed to timespec_add.
1661 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1662 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1663 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1664 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1665 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1666 (current_timespec): Rename from current_emacs_time. All uses changed.
1667 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1668 changed to timespec_cmp.
1669 * xgselect.c: Include <timespec.h>, since our .h files don't.
1670
d350e350
DA
16712013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1672
1673 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1674 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1675 Remove the leftovers.
1676 * gtkutil.c (toplevel): Do not declare Qxft but include
1677 font.h to do so.
1678 * image.c (toplevel): Do not declare Vlibrary_cache because
1679 it's already done in lisp.h.
1680
9fed9729
DA
16812013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1682
1683 * lisp.h (Mouse_HLInfo): Move from here...
1684 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1685 (reset_mouse_highlight): New function.
1686 * msdos.c (dos_set_window_size, IT_update_begin)
1687 (internal_terminal_init):
1688 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1689 (ns_initialize_display_info):
1690 * w32console.c (initialize_w32_display):
1691 * w32term.c (x_update_window_end, x_free_frame_resources)
1692 (w32_initialize_display_info):
1693 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1694 * window.c (Fdelete_other_windows_internal):
1695 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1696 * termchar.h (toplevel):
1697 * xterm.h (toplevel): Include dispextern.h.
1698
f462f075
PE
16992013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1700
1701 Fix minor problems found by static checking.
1702 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1703 (expect): Avoid nested-if warning.
1704 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1705 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1706 * nsterm.h, nsterm.m (ns_select):
1707 * xgselect.c, xgselect.h (xg_select):
1708 Adjust signature to better match pselect's.
1709 * nsterm.m (ns_select):
1710 Don't set *TIMEOUT, since pselect doesn't.
1711 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1712 diagnostic about assigning const char * to it.
1713 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1714
068f9124
SM
17152013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1716
1717 * lread.c (substitute_object_recurse): Handle hash-tables as well
1718 (bug#15190).
1719
f5adc984
PE
17202013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1721
1fc8eb33
PE
1722 Fix unlikely core dump in init_tty, and simplify terminfo case.
1723 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1724 The old version incorrectly dumped core if malloc returned a
1725 buffer containing only non-NUL bytes.
1726 (init_tty): Do not allocate or free termcap buffers; the
1727 struct does that for us now.
1728 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1729 (struct tty_display_info): Define members termcap_term_buffer and
1730 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1731 use them. Allocate them directly in struct rather than indirectly
1732 via a pointer, to simplify init_tty.
1733
f5adc984
PE
1734 * frame.c (check_minibuf_window): Initialize 'window' properly,
1735 so that Emacs reliably aborts later if 'window' is not initialized.
1736
efec3894
JD
17372013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1738
1739 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1740 of VoidSymbol (Bug#15154).
1741
e1d0341e
DA
17422013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1743
1744 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1745 mouse_face_beg_y and mouse_face_end_y.
1746 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1747 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1748 Adjust users and update comment where appropriate.
1749
bfff6445
MR
17502013-08-26 Martin Rudalics <rudalics@gmx.at>
1751
1752 * frame.c (check_minibuf_window): New function.
068f9124
SM
1753 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1754 Call check_minibuf_window (Bug#15183).
bfff6445 1755
c80016b3
DA
17562013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1757
1758 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1759 because this is the only last cursor data we need to keep and consult.
1760 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1761 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1762 Adjust users.
1763
de396731
DA
17642013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1765
068f9124
SM
1766 Fix recovering from possible decompression error.
1767 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1768 the position where the partially decompressed data ends, and
447218dd 1769 should count how many bytes was produced so far.
de396731
DA
1770 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1771 (unwind_decompress): Really delete partially uncompressed data.
1772 (Fzlib_decompress_region): Take decompressed data size into account.
1773
c76826d9
DA
17742013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 * syntax.c (init_syntax_once): Adjust comment and do an early
1777 initialization of Qchar_table_extra_slots just once...
1778 * casetab.c (init_casetab_once):
1779 * category.c (init_category_once):
1780 * character.c (syms_of_character):
1781 * coding.c (syms_of_coding):
1782 * xdisp.c (syms_of_xdisp): ...and omit it here.
1783
b34454d0
EZ
17842013-08-24 Eli Zaretskii <eliz@gnu.org>
1785
11f20add
EZ
1786 * xdisp.c (get_next_display_element): Don't apply to characters
1787 from a display vector the logic of setting it->end_of_box_run_p
1788 suitable for characters from a buffer. (Bug#15175)
1789
b34454d0
EZ
1790 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1791 to handle directories, rather than '_utime' which doesn't.
1792 (Bug#15176)
1793
6e1b469e
JD
17942013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1795
1796 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1797 or fullscreen (Bug#14627).
1798
9c05bccf
PE
17992013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 System-dependent integer overflow fixes.
1802 * process.c (Fset_process_window_size): Signal an error if
1803 the window size is outside the range supported by the lower level.
1804 * sysdep.c (set_window_size): Return negative on error,
1805 nonnegative on success, rather than -1, 0, 1 on not in system,
1806 failure, success. This is simpler. Caller changed.
1807 (serial_configure): Remove unnecessary initialization of local.
1808 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1809 size fits in unsigned long; this isn't true on some 32-bit hosts.
1810 Avoid buffer overrun if some future version of /proc/meminfo has a
1811 variable name longer than 20 bytes.
1812 (system_process_attributes) [__FreeBSD__]:
1813 Don't assume hw.availpages fits in 'int'.
1814
c365c355
PE
18152013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 Don't let very long directory names overrun the stack.
1818 Fix some related minor problems involving "//", vfork.
1819 * callproc.c (encode_current_directory): New function.
1820 (call_process): Don't append "/"; not needed.
1821 * fileio.c (file_name_as_directory_slop): New constant.
1822 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1823 this can save the caller having to alloca.
1824 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1825 Use SAFE_ALLOCA, not alloca.
1826 (directory_file_name, Fexpand_file_name): Leave leading "//"
1827 alone, since it can be special even on POSIX platforms.
1828 * callproc.c (call_process):
1829 * process.c (Fformat_network_address):
1830 * sysdep.c (sys_subshell):
1831 Use encode_current_directory rather than rolling our own.
1832 (create_process): No need to encode directory; caller does that now.
1833 * process.h (encode_current_directory): New decl.
1834 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1835 Rework to avoid 'goto xyzzy;'.
1836
6c6014d4
EZ
18372013-08-23 Eli Zaretskii <eliz@gnu.org>
1838
1839 * xdisp.c (handle_face_prop): If the default face was remapped use
1840 the remapped face for strings from prefix properties. (Bug#15155)
1841
9997ec56
DA
18422013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1843
1844 Minor cleanup for redisplay interface and few related functions.
1845 * frame.h (enum text_cursor_kinds): Move from here...
1846 * dispextern.h (enum text_cursor_kinds): ...to here.
1847 (toplevel): Drop unnecessary declarations.
1848 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1849 in update_window_end_hook and draw_window_cursor functions.
1850 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1851 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1852 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1853 * xterm.c (x_update_window_end, x_draw_window_cursor):
1854 * xdisp.c (display_and_set_cursor, update_window_cursor)
1855 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1856 enum text_cursor_kinds where appropriate.
1857
7f780da6
DA
18582013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1859
1860 Redesign redisplay interface to drop updated_row and updated_area.
1861 * dispextern.h (updated_row, updated_area): Remove declaration.
1862 (struct redisplay_interface): Pass glyph row and row area parameters
1863 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1864 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1865 Adjust prototypes.
1866 * dispnew.c (updated_row, updated_area): Remove.
1867 (redraw_overlapped_rows, update_window_line): Adjust user.
1868 (update_marginal_area, update_text_area): Likewise. Pass updated row
1869 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1870 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1871 Adjust users.
1872
26495794
PE
18732013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * process.c (flush_pending_output): Remove stub.
1876 All uses removed.
1877
4a88129a
PE
18782013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 * callproc.c: Fix race that killed background processes (Bug#15144).
1881 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1882 Record deleted process-id in critical section, not afterwards.
1883 Don't mistakenly kill process created by a call-process invocation
1884 that discards output and does not wait.
1885
0c5307b0
DA
18862013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1887
1888 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1889 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1890 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1891 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1892 to shut up compiler in mark_object.
1893 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1894
0d7c1e66
PE
18952013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1896
1897 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1898 We can't portably rely on PTY_OPEN doing that, even if
1899 it calls posix_openpt with O_CLOEXEC.
1900
3f246b65
KH
19012013-08-20 Kenichi Handa <handa@gnu.org>
1902
1903 * character.c (string_char): Improve commentary.
1904
8c2f38aa
PE
19052013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1908 (struct animation_cache): Make signature a flexible array member.
1909 All uses changed. This is a tad slower but may insulate us better
1910 from future changes to ImageMagick.
1911
bb566cea
PE
19122013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 * image.c: Shrink memory needed for animation cache.
1915 (SIGNATURE_DIGESTSIZE): New constant.
1916 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1917 (imagemagick_create_cache): Copy the signature. This saves
1918 several KB of memory that ImageMagick wastes per signature.
1919 Don't bother updating the update_time, as the caller does that now.
1920 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1921 it's a fixed size struct member now.
1922 (imagemagick_get_animation_cache): Always destroy the signature,
1923 as it's now imagemagick_create_cache's responsibility to copy it.
1924 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1925 and use memcmp rather than strcmp.
1926 eassert that ImageMagick returns a signature of the specified length.
1927
6da26928
LMI
19282013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1929
1930 * image.c (imagemagick_get_animation_cache): Don't segfault on
1931 each invocation.
453f4022
LMI
1932 (imagemagick_get_animation_cache): Revert to previous definition
1933 so that it actually works. But keep the memory leak fix.
1934 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1935
22490125
PE
19362013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1937
d0139df5
PE
1938 * image.c: Fix animation cache signature memory leak.
1939 Fix some other minor performance problems while we're at it.
1940 (imagemagick_create_cache): Clear just the members that
1941 need clearing. Don't set update_time, as caller does that now.
1942 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1943 Simplify by using pointer-to-pointer instead of a prev pointer.
1944 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1945 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1946 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1947 it's already a copy. Free the signature probe unless it's cached.
1948
22490125
PE
1949 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1950 This was introduced by my 2013-08-12 fix for Bug#15035.
1951
deb31e75
DA
19522013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1953
1954 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1955 (imagemagick_prune_animation_cache): Now static.
1956
319a4d03
LMI
19572013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1958
1959 * image.c (imagemagick_get_animation_cache): Don't segfault when
1960 pruning all entries.
1961
f747d82e
KB
19622013-08-18 Ken Brown <kbrown@cornell.edu>
1963
1964 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1965 static heap if ENABLE_CHECKING is defined.
1966 (max_bss_sbrk_ptr): New variable.
1967 (bss_sbrk): Use it.
1968 (report_sheap_usage): Report maximum static heap usage instead of
1969 ending static heap usage.
1970
d2c28fab
EZ
19712013-08-17 Eli Zaretskii <eliz@gnu.org>
1972
1973 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1974 of zlib_initialized according to the results of calling
1975 init_zlib_functions.
1976
274ff63f
LMI
19772013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978
1979 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1980 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1981 (imagemagick_load_image): Remove the ping_wand code, which only
1982 apparently saved time on invalid animated images, and slowed down
1983 everything else. Optimise for the common case.
274ff63f 1984
2bede2ed
XF
19852013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1986
70ff8240
XF
1987 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1988
de179a3e
XF
1989 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1990
2bede2ed
XF
1991 * marker.c (set_marker): Remove documentation of undefined behavior.
1992
703dbeba
LMI
19932013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1994
1995 * image.c (imagemagick_compute_animated_image): Animate correctly
1996 when sub-images are smaller than the main image.
1d18b1e6
LMI
1997 (imagemagick_compute_animated_image): Setting the iterator row to
1998 zero is apparently not allowed.
79670014
LMI
1999 (imagemagick_compute_animated_image): Allow images that say they
2000 have sub-images that are bigger than the main image, but just crop
2001 them.
703dbeba 2002
63216c5e
JD
20032013-08-15 Jan Djärv <jan.h.d@swipnet.se>
2004
2005 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
2006
a5b5f73f
LMI
20072013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2008
2009 * image.c (imagemagick_compute_animated_image): Respect the GIF
2010 disposal methods.
2011
0fe73012
KB
20122013-08-15 Ken Brown <kbrown@cornell.edu>
2013
2014 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
2015 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
2016 needed.
2017
691a357f
PE
20182013-08-15 Paul Eggert <eggert@cs.ucla.edu>
2019
2020 Fix minor problems found by static checking.
2021 * frame.c (delete_frame):
2022 * xdisp.c (next_element_from_display_vector):
2023 Avoid uninitialized local.
2024 * image.c (imagemagick_compute_animated_image): Port to C89.
2025 Prefer usual GNU indentation style for loops.
2026 Be more careful about bizarrely large sizes, by using ptrdiff_t
2027 instead of int.
2028
42fe2e88
DA
20292013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2030
2031 Fix infinite frame selection loop (Bug#15025).
2032 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
2033
d39a3da6
EZ
20342013-08-15 Eli Zaretskii <eliz@gnu.org>
2035
068f9124
SM
2036 * xdisp.c (compute_window_start_on_continuation_line):
2037 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
2038 to make sure we end up setting the window start at the leftmost
2039 visible character of the display line. This avoids funky
2040 horizontal shifting because the window start is not kept on the
2041 same position. (Bug#15090)
05426239
EZ
2042 (next_element_from_display_vector): Support 'box' face attribute
2043 in the face definitions of a display vector. (Bug#15099)
d39a3da6 2044
6e856b69
LMI
20452013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2046
2047 * image.c (imagemagick_compute_animated_image): Implement animated
2048 images (bug#14700).
995be755
LMI
2049 (imagemagick_compute_animated_image): Fix some compilation
2050 warnings. Implement a very simple cache to make the animation
2051 usable at all, but it should be replaced with a per-image cache.
6e856b69 2052
d5a1acfa
DA
20532013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2054
2055 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
2056 to do `for' loops over alist values.
2057 * buffer.h (FOR_EACH_BUFFER):
2058 * process.c (FOR_EACH_PROCESS): Use it.
2059 (handle_child_signal, status_notify, Fget_buffer_process)
2060 (kill_buffer_processes): Use FOR_EACH_PROCESS.
2061
9c253307
DA
20622013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2063
2064 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
2065 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
2066 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
2067 to xzalloc and so avoid redundant call to memset.
2068 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
2069 members because it is allocated with xzalloc and so already zeroed.
2070
05e64f9f
KB
20712013-08-14 Ken Brown <kbrown@cornell.edu>
2072
2073 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
2074 (Bug#15094).
2075
5b71542d
DA
20762013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2077
2078 Utility function and macro to copy Lisp string to C string.
2079 * lisp.h (xlispstrdupa): New macro.
2080 (xlispstrdup): New prototype.
2081 * alloc.c (xlispstrdup): New function.
2082 * callint.c (Fcall_interactively):
2083 * fileio.c (Ffile_name_directory, Fexpand_file_name)
2084 (Fsubstitute_in_file_name):
2085 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
2086 * image.c (x_create_bitmap_from_file):
2087 * w32term.c (w32_term_init):
2088 * xterm.c (x_term_init): Use xlispstrdup.
2089
71530c97
LMI
20902013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2091
4ce82fb8
LMI
2092 * image.c (imagemagick_load_image): Make animated pictures work.
2093 There's still some problems with background color settings, though
2094 (bug#14700).
2095
71530c97
LMI
2096 * decompress.c (unwind_decompress): Always restore point.
2097
7510a061
XF
20982013-08-14 Xue Fuqiao <xfq.free@gmail.com>
2099
2100 * marker.c (set_marker): Reformat documentation.
2101
01c3051f
PE
21022013-08-14 Paul Eggert <eggert@cs.ucla.edu>
2103
aab1fcdf
PE
2104 * xdisp.c (cursor_type_changed): Now static.
2105
01c3051f
PE
2106 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
2107 Use changed. This avoids the need to call xmalloc and for the
2108 caller to call xfree, and avoids memory leaks in some situations.
2109
2084152a
DA
21102013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2111
2112 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
2113 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
2114 (redisplay_window): If window_end_valid is cleared due to non-zero
2115 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
2116 so do not call to try_cursor_movement for that window.
2084152a 2117
02455cb6
DA
21182013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2119
2120 * window.h (struct window): Convert window_end_pos and
2121 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
2122 (wset_window_end_pos, wset_window_end_vpos): Remove.
2123 * dispnew.c (adjust_glyph_matrix):
2124 * window.c (Fwindow_end, replace_window, set_window_buffer)
2125 (make_window):
2126 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
2127 (set_vertical_scroll_bar, redisplay_window, try_window)
2128 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
2129 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
2130 (note_mouse_highlight): Adjust users.
2131 (try_cursor_movement): Likewise. Convert old precondition to eassert.
2132 Add comment.
2133
da5707e8
DA
21342013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2135
2136 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
2137 * image.c (imagemagick_filename_hint): Use `const char *' and
2138 prefer SSDATA to SDATA to avoid warnings.
2139
25554267
DA
21402013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2141
2142 Cleanup window fringes, margins and scroll bars adjustments.
2143 * window.c (set_window_fringes, set_window_margins)
2144 (set_window_scroll_bars, apply_window_adjustment): New functions.
2145 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
2146 (Fset_window_scroll_bars): Use them.
2147
38a2c910
DA
21482013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2149
2150 * window.h (struct window): Convert scroll_bar_width
2151 from Lisp_Object to integer. Adjust comment.
2152 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
2153 Adjust users.
2154 * window.c (wset_scroll_bar_width): Remove.
2155 (make_window): Initialize scroll_bar_width.
2156 (Fsplit_window_internal): Use direct assignment.
2157 (Fset_window_configuration, save_window_save):
2158 Convert Lisp_Object to integer and back where appropriate.
2159 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
2160 bar was actually changed, and mention this in docstring.
2161
2d065031
PE
21622013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2163
2164 * decompress.c: Minor simplifications.
2165 (Fzlib_decompress_region): Don't bother verifying
2166 that avail_out <= UINT_MAX, as that was confusing.
2167 Mention the restriction in a comment instead.
2168 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
2169
a5bd5abb
JD
21702013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2171
2172 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
2173 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
2174
66e7901a
LMI
21752013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2176
2177 * image.c (imagemagick_filename_hint): Check for errors in the
2178 alist structure.
2179
2fa611b7
EZ
21802013-08-13 Eli Zaretskii <eliz@gnu.org>
2181
2182 * window.c (Fwindow_margins): Return nil when there's no marginal
2183 area, as per the documented API.
2184
2185 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
2186 Fmake_vector, as scroll bar's struct members are not all Lisp
2187 objects now. This avoids crashes in GC.
2188
2189 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
2190 bool, so its address could be taken.
2191
8259030d
LMI
21922013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2193
2194 * image.c (imagemagick_filename_hint): New function to possibly
2195 apply `image-content-type-suffixes'.
2196 (imagemagick_load_image): Use it.
2197
866c710e
EZ
21982013-08-13 Eli Zaretskii <eliz@gnu.org>
2199
2200 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
2201 if loading zlib failed.
2202
f10490f0
JD
22032013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2204
96311be7
JD
2205 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
2206 2013-08-13 checkin below. Change bool to BOOL, rule is:
2207 All Obj-C code uses BOOL, except for interfaces callable from C.
2208
f10490f0
JD
2209 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
2210
c8ae93b0
DA
22112013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2212
2213 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
2214 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
2215 bool instead of BOOL.
2216 * w32term.h (struct scroll_bar): Convert fringe_extended_p
2217 from Lisp_Object to bitfield. Adjust comment.
2218 * w32term.c (x_scroll_bar_create): Adjust user.
2219 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
2220 * xterm.c (XTset_vertical_scroll_bar): Likewise.
2221 Use bool for boolean.
2222 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
2223 to `unsigned int' when defining a bitfield.
2224
53b64418
PE
22252013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
2228
eeaf9bf3
DA
22292013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2230
2231 * window.h (struct window): Convert left_margin_cols and
2232 right_margin_cols from Lisp_Objects to integers. Adjust comment.
2233 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
2234 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
2235 Adjust users.
2236 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
2237 Adjust comment.
2238 (showing_window_margins_p, update_window_line, update_frame_1):
2239 * fringe.c (draw_fringe_bitmap_1):
2240 * xdisp.c (window_box_width): Adjust users.
2241 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
2242 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
2243 Use direct assignment.
2244 (Fset_window_configuration, save_window_save, Fwindow_margins):
2245 Convert Lisp_Object to integer and back where appropriate.
2246 (Fset_window_margins): Adjust user. Return t if any margin
2247 was actually changed, and mention this in docstring.
2248
956720af
XF
22492013-08-13 Xue Fuqiao <xfq.free@gmail.com>
2250
f73f4ce6 2251 * syntax.c (forward_word):
956720af
XF
2252 * cmds.c (forward_char, backward_char): Mention the optional argument.
2253
9e37ee3b
DA
22542013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2255
2256 * window.h (struct window): Convert left_fringe_width
2257 and right_fringe_width from Lisp_Objects to integers.
2258 Adjust comment.
2259 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
2260 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
2261 * window.c (wset_left_fringe_width, wset_right_fringe_width):
2262 Remove.
2263 (make_window): Initialize new integer fields to -1.
2264 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
2265 (Fset_window_configuration, save_window_save):
2266 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
2267 (Fset_window_fringes): Adjust user. Return t if any fringe
2268 was actually changed, and mention this in docstring.
2269
e4375ca7
DA
22702013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2271
2272 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
2273 * nsfns.m (x_set_cursor_type):
2274 * w32fns.c (x_set_cursor_type):
2275 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
2276 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 2277
a45543bc
DA
22782013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2279
2280 * font.c (clear_font_cache): New function, stripped from...
2281 (Fclear_font_cache): ...here, which now uses the function
2282 above. Adjust comment.
2283 * font.h (clear_font_cache): Add prototype.
2284 * xfaces.c (clear_face_cache): Use clear_font_cache.
2285
ae966a86
DA
22862013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2287
2288 * window.c (Fset_window_start): Compare `w', not `window' because
2289 `w' might not be equal to `window' after call to decode_live_window.
2290
297a545b
PE
22912013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2292
2293 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
2294 This fixes a problem introduced by the Bug#15035 patch
2295 when using GPG. Reported by Herbert J. Skuhra.
2296
aa942e2b
EZ
22972013-08-12 Eli Zaretskii <eliz@gnu.org>
2298
2299 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
2300 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
2301 not yet initialized.
2302
7699d09e
LMI
23032013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2304
2305 * decompress.c (Fzlib_decompress_region): Support zlib
2306 decompression, too, and rename.
2307
1d238bc7
PE
23082013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2309
2310 Minor zlib configuration tweaks.
2311 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
2312 Don't assume presence of fn_inflateInit2_ zlib internal function.
2313
8a44a184
LMI
23142013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2315
2316 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
2317 include the zlib prefix.
2318
594a4307
EZ
23192013-08-12 Eli Zaretskii <eliz@gnu.org>
2320
2321 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
2322 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
2323 define static variables that are pointers to zlib functions to be
2324 dynamically loaded.
2325 (init_zlib_functions) [WINDOWSNT]: New function.
2326 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
2327 New macros.
2328 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
2329 macros instead of invoking the zlib functions directly.
068f9124
SM
2330 (syms_of_decompress): DEFSYM Qzlib_dll.
2331 Staticpro Szlib_available_p.
594a4307 2332
d2e113bc
DA
23332013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
2334
2335 Avoid looping over all frame windows to freeze and unfreeze.
2336 * window.h (struct window): Drop frozen_window_start_p.
2337 (freeze_window_starts): Drop prototype.
2338 * frame.h (struct frame): New frozen_window_starts flag.
2339 (FRAME_WINDOWS_FROZEN): New macro.
2340 * window.c (freeze_window_start, freeze_window_starts):
2341 Remove.
2342 (select_window, replace_window): Adjust users.
2343 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2344 (window_frozen_p): New function.
2345 (redisplay_window): Use it.
2346
94fcd171
PE
23472013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 Fix some fd issues when running subprocesses (Bug#15035).
2350 Fix bugs that can leak files or file descriptors on errors.
2351 Don't unlink open temp files, as that's hard for users to diagnose
2352 when things go awry (e.g., temp disk exhausted).
2353 Don't bother to lock temp files. Check for invalid recursion.
2354 * callproc.c (synch_process_fd): Remove. All uses removed.
2355 (synch_process_tempfile): New var or macro.
2356 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2357 New constants.
2358 (record_kill_process): New arg, the temp name. All callers changed.
2359 (delete_temp_file): Now just a simple wrapper around unlink.
2360 (call_process_kill): New arg, the call_process_fd array.
2361 Close them all. Clear synch_process_pid. Remove the temp file,
2362 or arrange for it to be removed.
2363 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2364 that's been moved to synch_process_tempfile. Caller changed.
2365 Do not remove the tempfile; that's now call_process_kill's
2366 responsibility.
2367 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2368 call_process_kill; the caller now does that.
2369 (call_process_cleanup): Do not close the process fd; that's now
2370 call_process_kill's responsibility.
2371 (Fcall_process): Implement via new function call_process, which
2372 has most of the old body of Fcall_process, but with a different API.
2373 (call_process): New function that does not open or close filefd if
2374 it is nonnegative. Record which fds need to be closed, and let
2375 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2376 Signal an error if invoked recursively (could be done via a hook).
2377 Simplify creation of the tempfile in the MSDOS case.
2378 Don't create the output file until after checking for the executable.
2379 Report any failure to open /dev/null.
2380 Don't open /dev/null for writing twice; once is enough.
2381 Don't create pipe if all output is being discarded or sent to file.
2382 Don't worry about setting up the coding system or reading from the
2383 pipe if all output is being discarded.
2384 Hoist fd_error local into top level, to lessen block nesting.
2385 Don't record deleted pid here; now done by Fcall_process_region.
2386 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2387 and note its success in synch_process_tempfile.
2388 Do not leak resources when child_setup fails.
2389 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2390 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2391 (create_temp_file): Now returns open fd, with an additional
2392 Lisp_Object * argument to return the name. All callers changed.
2393 Do not close the file; rewind it instead, and leave it open for
2394 the caller. Do not lock the temp file. Unwind-protect the file
2395 and the file-descriptor.
2396 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2397 If an asynchrounous process, record it here, not in call_process.
2398 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2399 * eval.c (set_unwind_protect): New function.
2400 * fileio.c (write_region): New function, generalized from the
2401 old Fwrite_region. Do not lock temp files.
2402 (Fwrite_region): Use it.
2403 * lisp.h (set_unwind_protect, write_region): New decls.
2404 * process.c: Include <verify.h>.
2405 (make_process): Mark fds as initially closed.
2406 (deleted_pid_list): Now a list of pid-filename pairs.
2407 All uses changed.
2408 (close_process_fd): New function.
2409 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2410 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2411 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2412 (create_process, create_pty, Fmake_serial_process)
2413 (server_accept_connection): Record which fds need to be closed,
2414 and let deactivate_process close them.
2415 (Fmake_network_process): Do not discard the unwind-protect
2416 until it's safe to do so.
2417 (deactivate_process): Close the fds opened by create_process etc.
2418 (Fprocess_send_eof): Adjust to new way of recording open fds.
2419 Report an error if /dev/null can't be opened, instead of aborting.
2420 * process.h (PROCESS_OPEN_FDS): New constant.
2421 (struct Lisp_Process): New member open_fds.
2422 (record_kill_process, record_deleted_pid): Adjust signatures.
2423 (record_deleted_pid): Move decl here ...
2424 * syswait.h (record_deleted_pid): ... from here.
2425
d0e615c3
PE
24262013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2427
2428 * decompress.c: Fix bugs with large buffers and weird inputs.
2429 Tune a bit. Reindent as per usual Emacs style.
2430 (BUFFER_SIZE): Remove.
2431 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2432 more than UINT_MAX bytes. Decompress into the gap instead of into
2433 an auto buffer, as this should avoid copying. Return nil if
2434 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2435 set immediate_quit; we shouldn't trust zlib code that much.
2436
313546eb
LMI
24372013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2438
99a32242
LMI
2439 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2440 errors, and really move the gap to where we want it.
2441
313546eb
LMI
2442 * lisp.h: Include decompress.c support.
2443
2444 * emacs.c (main): Include decompress.c support.
2445
2446 * Makefile.in: Include -lz if present.
2447
d2d699ac
JD
24482013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2449
f90e3ebd
JD
2450 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2451 (initWithTitle:): Initialize frame to 0.
2452 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2453 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2454 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2455
2456 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2457 fillWithWidgetValue:frame:
2458
423d3b3f
JD
2459 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2460 remove memory leak warnings.
2461
d2d699ac
JD
2462 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2463 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2464 menu_pending_title.
2465
2466 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2467 (x_activate_menubar): Update the whole menu.
2468 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2469 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2470 current event is not NSSystemDefined (Bug#15001).
2471 Call ns_check_menu_open only if trackingMenu is 2.
2472 (menuDidClose:): New method, decrease trackingMenu.
2473 (fillWithWidgetValue:setDelegate:): New method.
2474 (fillWithWidgetValue:): Call the above.
2475
2476 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2477
7d652d97
PE
24782013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2479
2480 Omit some unnecessary casts.
2481 Many of these go back to the old pre-C89 days, when they may have
2482 been needed, but we've been assuming C89 or later for a while now.
2483 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2484 (live_float_p, live_misc_p, live_vector_p):
2485 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2486 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2487 (defvar_per_buffer):
2488 * callint.c (Fcall_interactively):
2489 * doc.c (Fsubstitute_command_keys):
2490 * filelock.c (get_boot_time):
2491 * frame.c (xrdb_get_resource):
2492 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2493 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2494 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2495 (menuitem_highlight_callback, menu_destroy_callback)
2496 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2497 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2498 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2499 (xg_tool_bar_help_callback, tb_size_cb):
2500 * image.c (xpm_alloc_color, png_read_from_memory)
2501 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2502 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2503 (syms_of_image):
2504 * keymap.c (describe_map):
2505 * nsfns.m (Fns_display_monitor_attributes_list):
2506 * nsmenu.m (process_dialog:):
2507 * nsterm.m (hold_event):
2508 * process.c (wait_reading_process_output):
2509 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2510 * scroll.c (do_direct_scrolling, scrolling_1):
2511 * termcap.c (tgetent):
2512 * window.c (check_window_containing, add_window_to_list)
2513 (freeze_window_starts):
2514 * xdisp.c (compare_overlay_entries, vmessage):
2515 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2516 (x_get_monitor_attributes_xrandr)
2517 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2518 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2519 * xfont.c (xfont_match, xfont_open):
2520 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2521 (menubar_selection_callback, menu_position_func)
2522 (popup_selection_callback, create_and_show_popup_menu)
2523 (dialog_selection_callback, create_and_show_dialog):
2524 * xrdb.c (x_get_string_resource):
2525 (main) [TESTRM]:
2526 * xsmfns.c (x_session_check_input):
2527 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2528 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2529 (xaw_jump_callback, xaw_scroll_callback):
2530 Omit unnecessary casts.
2531
9acc1074
PE
25322013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 Minor string-length refactoring.
2535 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2536 * frame.c (make_monitor_attribute_list):
2537 Prefer build_string to strlen + make_string.
2538
361c0eb8
JD
25392013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2540
2541 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2542 don't check minor_code (Bug#14417).
2543
14ba0822
EZ
25442013-08-09 Eli Zaretskii <eliz@gnu.org>
2545
2546 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2547 vertical positions instead. This avoids calling MATRIX_ROW with
2548 row numbers that are possibly beyond valid limits. (Bug#15064)
2549
309f24d1
DA
25502013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2551
2552 Use xstrdup and build_unibyte_string where applicable.
2553 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2554 * xfns.c (x_window):
2555 * xrdb.c (x_get_customization_string):
2556 * xterm.c (xim_initialize):
2557 * w32fns.c (w32_window): Use xstrdup.
2558 (w32_display_monitor_attributes_list):
2559 * emacs.c (init_cmdargs):
2560 * keyboard.c (PUSH_C_STR):
2561 * nsfont.m (nsfont_open):
2562 * sysdep.c (system_process_attributes):
2563 * w32.c (system_process_attributes):
2564 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2565
55902276
EZ
25662013-08-09 Eli Zaretskii <eliz@gnu.org>
2567
2568 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2569 variables of these types so that GDB would know about them, as aid
2570 for debugging fatal exceptions. (Bug#15024) See also
2571 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2572 discussions.
2573
10bf7f5a
JD
25742013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2575
2576 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2577 larger than the NSWindow (Bug#14934).
2578
65620264
DA
25792013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2580
2581 Redesign redisplay interface to drop global variable updated_window.
2582 Always pass currently updated window as a parameter to update routines.
2583 * dispextern.h (updated_window): Remove declaration.
2584 (struct redisplay_interface): Pass window parameter to
2585 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2586 and after_update_window_hook.
2587 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2588 Adjust prototypes.
2589 * dispnew.c (updated_window): Remove.
2590 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2591 (update_window_line): Adjust to match redisplay interface changes.
2592 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2593 (ns_scroll_run, ns_after_update_window_line):
2594 * w32term.c (x_update_window_begin, x_update_window_end)
2595 (x_after_update_window_line, x_scroll_run):
2596 * xterm.c (x_update_window_begin, x_update_window_end)
2597 (x_after_update_window_line, x_scroll_run):
2598 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2599 Likewise. Adjust comments where appropriate.
2600 (x_cursor_to): Simplify because this is always called during window
2601 update (but install debugging check anyway).
2602 (expose_window): Check must_be_updated_p flag to see whether this
2603 function is called during window update.
2604
628fdc56
DA
26052013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2606
2607 Do not reset window modification event counters excessively.
2608 These leftovers and poor man's tricky methods to catch extra
2609 redisplay's attention are no longer needed.
2610 * frame.c (set_menu_bar_lines_1):
2611 * minibuf.c (read_minibuf_unwind):
2612 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2613 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2614 (window_scroll_line_based, Fset_window_configuration):
2615 * xdisp.c (redisplay_window): Do not reset last_modified and
2616 last_overlay_modified counters.
2617
8fd9c92e
JD
26182013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2619
2620 * xselect.c (x_send_client_event): Set send_event and serial, memset
2621 data.l as it might be bigger than data.b. Use 24 bit mask to
2622 XSendEvent (Bug#15034).
2623
0ee18172
EZ
26242013-08-07 Eli Zaretskii <eliz@gnu.org>
2625
2626 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2627 for TTY frames that are not the top frame on their console.
2628 (Bug#14616)
2629
16ddd1a6
MR
26302013-08-07 Martin Rudalics <rudalics@gmx.at>
2631
2632 * w32term.c (w32fullscreen_hook): Really maximize frame when
2633 asked for (Bug#14841).
2634
d2a95ffb
DA
26352013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2636
2637 Prefer selected_window to Fselected_window, likewise for frames.
2638 * buffer.c (Fbuffer_swap_text):
2639 * data.c (Fvariable_binding_locus):
2640 * window.c (run_window_configuration_change_hook): Adjust users.
2641 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2642 Use decode_live_frame.
2643
170da1ec
DA
26442013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2645
2646 Be more careful if selected window shows the buffer other than current,
2647 use window_outdated only if this is not so. This change should also
2648 address some weird issues discussed in Bug#13012.
2649 * window.h (window_outdated): New prototype.
2650 * window.c (window_outdated): Now here. Convert from static and
2651 always assume window's buffer.
2652 (Fwindow_end, Fwindow_line_height): Use it.
2653 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2654 and always assume window's buffer.
2655 (redisplay_window): Adjust user.
e5eefe9b 2656 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2657 check whether mode line should be updated only if selected window
2658 shows current buffer.
2659 (run_window_scroll_functions): Use eassert for debugging check.
2660 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2661
56b5d5b1
DA
26622013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2663
2664 * window.c (window_scroll, window_scroll_pixel_based)
2665 (window_scroll_line_based): Use bool for booleans.
2666
2878ba7e
PE
26672013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2668
2669 * process.c: Fix minor off-by-one issues in descriptor counts.
2670 This shouldn't fix any real bugs, but it cleans up the code a bit.
2671 (max_process_desc, max_input_desc): -1, not 0, means none.
2672 All uses changed.
2673 (delete_input_desc): New function.
2674 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2675 (deactivate_process): Scan backwards when recomuting max_process_desc;
2676 that should be faster.
2677 (init_process_emacs): Initialize max_input_desc.
2678
e30b79c1
DA
26792013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2680
2681 Use region cache to speedup bidi_find_paragraph_start.
2682 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2683 Rename cache_long_line_scans to cache_long_scans.
2684 * buffer.c (bset_cache_long_line_scans): Rename to
2685 bset_cache_long_scans.
2686 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2687 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2688 into account.
2689 (syms_of_buffer): Rename cache-long-line-scans to
2690 cache-long-scans. Adjust docstring.
2691 * search.c (newline_cache_on_off):
2692 * indent.c (width_run_cache_on_off): Adjust users.
2693 * bidi.c (bidi_paragraph_cache_on_off): New function.
2694 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2695 * insdel.c (prepare_to_modify_buffer):
2696 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2697
00012b86
DA
26982013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2699
2700 Invalidate region caches only if buffer text is going to be changed.
2701 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2702 (modify_text): ...new prototype.
2703 (prepare_to_modify_buffer_1): New prototype.
2704 * textprop.c (modify_region): Rename to...
2705 (modify_text_properties): ...new function.
2706 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2707 (Fremove_list_of_text_properties): Adjust users.
2708 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2709 (modify_text): ...new function.
2710 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2711 (prepare_to_modify_buffer_1): ...new function.
2712 * casefiddle.c (casify_region):
2713 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2714 (Ftranspose_regions): Use modify_text.
2715
dc6c0eda
SM
27162013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2717
2718 * lisp.mk (lisp): Add nadvice.elc.
2719
8f3a2c26
DA
27202013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2721
2722 New macro to iterate over live buffers similar to frames.
2723 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2724 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2725 Declare buffer-related variables here to offload lisp.h.
2726 * buffer.c (Vbuffer_alist): Adjust comment.
2727 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2728 (other_buffer_safely):
2729 * data.c (store_symval_forwarding):
2730 * dispnew.c (Fframe_or_buffer_changed_p):
2731 * fileio.c (Fdo_auto_save):
2732 * filelock.c (unlock_all_files):
2733 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2734
e0fdb694
PE
27352013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2738 * callproc.c (create_temp_file):
2739 * filelock.c (create_lock_file):
2740 Assume mkostemp, since it's now provided by Gnulib.
2741
63f5c6c2
EZ
27422013-08-04 Eli Zaretskii <eliz@gnu.org>
2743
2744 * w32.c (mkostemp): New function.
2745 (mktemp): Remove, no longer used. Most of the code reused in
2746 mkostemp. (Bug#15015)
484ab239 2747 (mktemp): Don't undef.
63f5c6c2 2748
f0b79313
DA
27492013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2750
2751 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2752 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2753 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2754 (free_glyph_pool, check_glyph_memory): Likewise for
2755 all users. Adjust comments where appropriate.
2756
98f638d6
PE
27572013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2758
2759 * composite.h: Minor fixups.
2760 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2761 to fix a misspelling, and change it to an inline function while
2762 we're at it (it need not be a macro). All uses changed.
2763 (composition_method, composition_valid_p):
2764 Rewrite to avoid assignments in if-conditions.
2765
75c59fb3
DA
27662013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2767
2768 Do not use global Lisp_Object in composition macros.
2769 * composite.h (composition_temp): Remove declaration.
2770 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2771 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2772 (compose_region): Remove the leftover.
75c59fb3
DA
2773 * composite.c (composition_temp): Remove.
2774 (run_composition_function, update_compositions)
2775 (composition_compute_stop_pos, composition_adjust_point)
2776 (Ffind_composition_internal):
2777 * coding.c (handle_composition_annotation):
2778 * xdisp.c (handle_composition_prop, check_point_in_composition):
2779 Related users changed.
2780
a10c8269
DA
27812013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2782
2783 Drop FRAME_PTR typedef.
2784 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2785 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2786 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2787 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2788 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2789 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2790 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2791 All related users changed.
2792
a104f656
SM
27932013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2794
2795 * eval.c (default_toplevel_binding): New function.
2796 (Fdefvar): Use it.
2797 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2798 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2799 (syms_of_eval): Export them.
2800 * data.c (Fdefault_value): Micro cleanup.
2801 * term.c (init_tty): Use "false".
2802
4b5c9326
DA
28032013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2804
2805 Fix X GC leak in GTK and raw (no toolkit) X ports.
2806 * xterm.c (x_free_frame_resources): If white and black relief
2807 GCs are allocated, always free them here.
2808 * xfns.c (x_make_gc): Omit redundant initialization.
2809 * widget.c (create_frame_gcs): Remove the leftover.
2810 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2811 in x_free_frame_resources.
2812
b19aa636
JD
28132013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2814
2815 * nsterm.m (windowWillResize:toSize:): Only change title if
2816 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2817 modifying it.
2818 (viewDidEndLiveResize): New method.
2819
2820 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2821 inside NS_IMPL_COCOA.
2822
af1f7e06
DA
28232013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2824
2825 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2826 Do not check whether undo is enabled because record_insert and
2827 record_delete does that themselves.
2828
65b02bb9
DA
28292013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2830
2831 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2832 member which is not really used any more.
2833 (FRAME_XIC_BASE_FONTNAME): Remove.
2834 * xfns.c (xic_free_fontset): Adjust user.
2835 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2836 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2837 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2838 (xdialog_show): Use eassert for debugging check.
7ee0f047 2839 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2840
6318cde0
PE
28412013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * fileio.c, fns.c (merge): Move extern decl from here ...
2844 * lisp.h (merge): ... to here.
2845
6c1a09ba
DA
28462013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2847
2848 Fix last font-related change.
2849 * w32font.h (w32font_list_internal, w32font_match_internal):
2850 Fix prototype.
2851 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2852 (uniscribe_list_family): Adjust to match font API change.
2853 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2854 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2855
f8c20208
DA
28562013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2857
2858 * frame.h (FRAME_MOUSE_UPDATE):
2859 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2860 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2861
fdb396e2
DA
28622013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2863
2864 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2865 * font.h (struct font_driver): Change list, match, and list_family
2866 functions to accept struct frame * as first arg.
068f9124
SM
2867 * font.c (font_score, font_compare, font_sort_entities):
2868 Remove prototypes.
fdb396e2
DA
2869 (font_sort_entities, font_list_entities, font_select_entity):
2870 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2871 match font API change.
2872 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2873 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2874 * ftxfont.c (ftxfont_list, ftxfont_match):
2875 * xftfont.c (xftfont_list, xftfont_match):
2876 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2877 * w32font.c (w32font_list, w32font_match, w32font_list):
2878 (w32font_list_internal, w32_font_match_internal): Likewise.
2879 * xfaces.c (Fx_family_fonts): Adjust user.
2880
52b8a085
DA
28812013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2882
2883 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2884 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2885 only if HAVE_X_WINDOWS is in use.
2886 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2887 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2888 * w32term.c (x_wm_set_icon_position): Likewise.
2889 * w32fns.c (x_icon): Adjust user.
2890
c791c18e
DA
28912013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2892
2893 * xterm.c (last_mouse_press_frame): Remove the
2894 leftover which is not really used any more.
2895 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2896 (x_flush): Call XFlush once per each X display, not frame.
2897 This is better because this code always unconditionally skips
2898 non-X frames in Vframe_list and issues the only XFlush if we
2899 have more than one X frame on the same X display.
2f935d86
DA
2900 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2901 Use bool for booleans.
2902 (x_draw_glyph_string_background, cvt_string_to_pixel):
2903 (cvt_pixel_dtor): Drop unnecessary prototypes.
2904 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2905
f435830e
DA
29062013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2907
2908 Drop unnecessary functions that deals with frame pixel size.
2909 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2910 (x_pixel_height): Drop prototypes.
2911 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2912 (x_pixel_height): Drop implementations.
2913 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2914 which should be always valid for window frame.
2915 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2916 * w32menu.c (Fx_popup_dialog):
2917 * xmenu.c (Fx_popup_dialog): Likewise for both.
2918
84231434
DA
29192013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2920
2921 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2922 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2923 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2924 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2925 and mention nil frame in docstring.
84231434 2926
959067a1
DA
29272013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2928
2929 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2930 (x_figure_window_size): Likewise. Adjust to return long.
2931 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2932 (toplevel): Move Qterminal_live_p to...
2933 * terminal.c (toplevel): ...here, make it static, and...
2934 (syms_of_terminal): ...DEFSYM here.
2935 * frame.h (Qterminal_live_p): Remove declaration.
2936 (make_frame, x_figure_window_size): Adjust prototype.
2937 * nsfns.m (Fx_create_frame): Use long for window flags.
2938
f4b169ce
PE
29392013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2940
2941 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2942 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2943 Do not assume that emacs_close (INT_MAX) is a no-op.
2944
bee6a2c7
DA
29452013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2946
2947 * xfaces.c (make_face_cache): For struct face_cache, prefer
2948 xmalloc to xzalloc and so avoid redundant call to memset.
2949 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2950
d7e6881a
DA
29512013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2952
2953 * fringe.c (draw_window_fringes, update_window_fringes)
2954 (compute_fringe_widths):
2955 * w32term.c (x_draw_glyph_string):
2956 * window.c (candidate_window_p, Frecenter):
2957 * xfaces.c (realize_basic_faces, realize_default_face)
2958 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2959 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2960 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2961 * xmenu.c (Fx_menu_bar_open_internal):
2962 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2963 * xsettings.c (xft_settings_event):
2964 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2965 Use bool for booleans. Adjust style and comments where
2966 appropriate.
2967 * dispextern.h (draw_window_fringes, update_window_fringes)
2968 (compute_fringe_widths):
2969 * xterm.h (x_had_errors_p): Adjust prototype.
2970
ec3058af
DA
29712013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2972
2973 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2974 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2975
218e0637
DA
29762013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2977
2978 * fns.c (toplevel): Remove comment before Fsafe_length because
2979 it checks for QUIT.
2980
e560aba9
PE
29812013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2982
2983 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2984
2e5ce5de
EZ
29852013-07-28 Eli Zaretskii <eliz@gnu.org>
2986
2987 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2988 frame which got the message is still alive, before dereferencing
2989 its pointer. (Bug#14970)
2990
2991 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2992 be a live window, before using it as such. (Bug#14970)
2993
e95da6d3
EZ
29942013-07-27 Eli Zaretskii <eliz@gnu.org>
2995
2996 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2997 w32_detect_focus_change instead of doing part of its job by hand.
2998 This fixes the problem whereby FOCUS_OUT events were not sent to
2999 the event queue.
3000
a8f93651
EZ
30012013-07-26 Eli Zaretskii <eliz@gnu.org>
3002
fec92060
EZ
3003 * process.c (Fprocess_list): Doc fix.
3004
a8f93651
EZ
3005 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
3006 being re-exposed only if it didn't ask to become visible.
3007 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
3008 was previously iconified. (Bug#14841)
3009 (x_iconify_frame): Mark the frame iconified.
3010
d5a7a9d9
PE
30112013-07-26 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 Fix minor problems found by static checking.
3014 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
3015 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
3016
56ea7291
SM
30172013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3018
3019 * eval.c (set_specpdl_old_value): New function.
3020 (unbind_to): Minor simplification.
3021 (get_backtrace_frame): New function.
3022 (Fbacktrace_frame): Use it. Add `base' argument.
3023 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
3024 (syms_of_eval): Export backtrace-eval.
3025 * xterm.c (x_focus_changed): Simplify.
3026
9d611ffe
PE
30272013-07-25 Paul Eggert <eggert@cs.ucla.edu>
3028
3029 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
3030
999c74e3
EZ
30312013-07-24 Eli Zaretskii <eliz@gnu.org>
3032
3033 * xdisp.c (redisplay_window): Instead of moving point out of
3034 scroll margin, reject the force_start method, and try scrolling
3035 instead. (Bug#14780)
3036
198fa217
KB
30372013-07-24 Ken Brown <kbrown@cornell.edu>
3038
3039 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
3040 (Bug#14944).
3041
53840e55
PE
30422013-07-24 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 * eval.c (Fprogn): Do not check that BODY is a proper list.
3045 This undoes the previous change. The check slows down the
3046 interpreter, and is not needed to prevent a crash. See
3047 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
3048
60967f56
GM
30492013-07-23 Glenn Morris <rgm@gnu.org>
3050
3051 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
3052
9ca960e2
PE
30532013-07-23 Paul Eggert <eggert@cs.ucla.edu>
3054
a29c3e6d
PE
3055 Port to GNU/Linux systems with tinfo but not ncurses.
3056 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
3057 to decide whether ncurses is being used. Without this change,
3058 GCC complains about tgetent not being declared, on a system
3059 that has tinfo installed but ncurses not installed.
3060
f274311c
PE
3061 * eval.c (Fprogn): Check that BODY is a proper list.
3062
16b0520a
PE
3063 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
3064 * data.c (Fsetq_default):
3065 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
3066 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
3067 (Fcondition_case):
3068 Tune by taking advantage of the fact that ARGS is always a list
3069 when a function is declared to have UNEVALLED args.
3070
9ca960e2
PE
3071 * emacsgtkfixed.c: Port to GCC 4.6.
3072 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
3073
afacaa1b
JB
30742013-07-23 Juanma Barranquero <lekktu@gmail.com>
3075
3076 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
3077 here to silence compiler warnings.
3078
368a85a4
PE
30792013-07-22 Paul Eggert <eggert@cs.ucla.edu>
3080
3081 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
3082 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
3083 from messing up Emacs's 'struct frame' (Bug#14923).
3084
f4e891b5
PE
30852013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3086
3087 * alloc.c (make_save_ptr_ptr): Define this function.
3088 It was inadvertently omitted. It's needed only if
3089 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
3090
96c8b65e
JD
30912013-07-21 Jan Djärv <jan.h.d@swipnet.se>
3092
3093 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
3094 frame have focus (Bug#14895).
3095
ee010797
PE
30962013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3097
3098 Avoid vfork-related deadlock more cleanly.
3099 * callproc.c (child_setup): When the child's exec fails, output
3100 the program name, as that's more useful. Use O_NONBLOCK to avoid
3101 deadlock.
3102 * process.c (create_process_1): Remove; no longer needed.
3103 (create_process): Remove timer hack; no longer needed, now that
3104 the child avoids deadlock.
3105
f0398ec1 31062013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
3107
3108 * image.c (Fimage_flush): Fix doc typo.
3109
b2a069c2
PE
31102013-07-20 Paul Eggert <eggert@cs.ucla.edu>
3111
6496aec9
PE
3112 Fix array bounds violation when pty allocation fails.
3113 * process.c (PTY_NAME_SIZE): New constant.
3114 (pty_name): Remove static variable; it's now auto.
3115 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
3116 Take pty_name as an arg rather than using a static variable.
3117 All callers changed.
3118 (create_process): Recover pty_flag from process, not from volatile local.
3119 (create_pty): Stay inside array even when pty allocation fails.
3120 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
3121
b2a069c2
PE
3122 * lread.c (Fload): Avoid initialization only when lint checking.
3123 Mention that it's needed only for older GCCs.
3124
99107004
KH
31252013-07-20 Kenichi Handa <handa@gnu.org>
3126
3127 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
3128 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
3129
6b1b199d
AS
31302013-07-20 Andreas Schwab <schwab@linux-m68k.org>
3131
3132 * lread.c (Fload): Avoid uninitialized warning.
3133
4195afc3
PE
31342013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3135
3f5bef16
PE
3136 Fix some minor file descriptor leaks and related glitches.
3137 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
3138 (create_lock_file): Use write, not emacs_write.
3139 * image.c (slurp_file, png_load_body):
3140 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
3141 (server_accept_connection):
3142 Don't leak an fd on memory allocation failure.
3143 * image.c (slurp_file): Add a cheap heuristic for growing files.
3144 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
3145 as that's what the other routines do. Maybe input need not be
3146 blocked at all, but it's better to be consistent.
3147 Avoid undefined behavior when strlen is zero.
3148
4195afc3
PE
3149 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
3150 (NSTATICS): Now a constant; doesn't need to be a macro.
3151
a1aeeffe
RS
31522013-07-19 Richard Stallman <rms@gnu.org>
3153
3154 * coding.c (decode_coding_utf_8): Add simple loop for fast
3155 processing of ASCII characters.
3156
63b34baa
PE
31572013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3158
3159 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
3160
621dd9ac
EZ
31612013-07-19 Eli Zaretskii <eliz@gnu.org>
3162
3163 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
3164 unportable 'struct x_display_info'.
3165 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
3166 is a portable type.
3167
1396ac86
PE
31682013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3169
ab9980cd
PE
3170 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
3171 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
3172 or fscanf fails.
3173 (system_process_attributes): Prefer plain char to unsigned char
3174 when either will do. Clean up properly if interrupted or if
068f9124
SM
3175 memory allocations fail. Don't assume sscanf succeeds.
3176 Remove no-longer-needed workaround to stop GCC from whining.
3177 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
3178 bit more carefully.
3179
1396ac86
PE
3180 Fix obscure porting bug with varargs functions.
3181 The code assumed that int is treated like ptrdiff_t in a vararg
3182 function, which is not a portable assumption. There was a similar
3183 -- though these days less likely -- porting problem with various
3184 assumptions that pointers of different types all smell the same as
3185 far as vararg functions is conserved. To make this problem less
3186 likely in the future, redo the API to use varargs functions.
3187 * alloc.c (make_save_value): Remove this vararg function.
3188 All uses changed to ...
3189 (make_save_int_int_int, make_save_obj_obj_obj_obj)
3190 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
3191 New functions.
3192 (make_save_ptr): Rename from make_save_pointer, for consistency with
3193 the above. Define only on platforms that need it. All uses changed.
3194
4d19d194
PE
31952013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3196
3197 * keyboard.c: Try to fix typos in previous change.
3198 (DISPLAY_LIST_INFO): New macro.
3199 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 3200 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 3201
945c5bb1
JB
32022013-07-18 Juanma Barranquero <lekktu@gmail.com>
3203
3204 * keyboard.c (kbd_buffer_get_event):
3205 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
3206 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
3207
f4b1eb36
PE
32082013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3209
5e679a2c
PE
3210 * filelock.c: Fix unlikely file descriptor leaks.
3211 (get_boot_time_1): Rework to avoid using emacs_open.
3212 This doesn't actually fix a leak, but is better anyway.
3213 (read_lock_data): Use read, not emacs_read.
3214
a8cd4836
PE
3215 * doc.c: Fix minor memory and file descriptor leaks.
3216 * doc.c (get_doc_string): Fix memory leak when doc file absent.
3217 (get_doc_string, Fsnarf_documentation):
3218 Fix file descriptor leak on error.
3219
ef30e638
PE
3220 * term.c: Fix minor fdopen-related file descriptor leaks.
3221 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
3222 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
3223
f4b1eb36
PE
3224 * charset.c: Fix file descriptor leaks and errno issues.
3225 Include <errno.h>.
3226 (load_charset_map_from_file): Don't leak file descriptor on error.
3227 Use plain record_xmalloc since the allocation is larger than
3228 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
3229 of entries.
3230 * eval.c (record_unwind_protect_nothing):
3231 * fileio.c (fclose_unwind):
3232 New functions.
3233 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
3234 The replacement doesn't block input, but that no longer seems
3235 necessary.
3236
b648c163
PE
32372013-07-17 Paul Eggert <eggert@cs.ucla.edu>
3238
a0931322
PE
3239 * lread.c: Fix file descriptor leaks and errno issues.
3240 (Fload): Close some races that leaked fds or streams when 'load'
3241 was interrupted.
3242 (Fload, openp): Report error number of last nontrivial failure to open.
3243 ENOENT counts as trivial.
3244 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
3245 New functions.
3246 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
3247 now that the function is always called with a nonnegative arg.
3248 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
3249 All uses replaced with ...
3250 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
3251
b648c163
PE
3252 A few more minor file errno-reporting bugs.
3253 * callproc.c (Fcall_process):
3254 * doc.c (Fsnarf_documentation):
3255 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
3256 * process.c (set_socket_option):
3257 Don't let a constructor trash errno.
3258 * doc.c: Include <errno.h>.
3259
b1dc4084
JB
32602013-07-16 Juanma Barranquero <lekktu@gmail.com>
3261
3262 * w32fns.c (unwind_create_tip_frame): Fix declaration.
3263
c43843aa
PE
32642013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3265
50a30cce
PE
3266 Fix w32 bug with call-process-region (Bug#14885).
3267 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
3268 to Fcall_process when the input is empty. This simplifies the
3269 code a bit. It makes no difference on POSIXish platforms but
3270 apparently it fixes a bug on w32.
3271
44e18199 3272 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
3273 * fileio.c (close_file_unwind): Don't close if FD is negative;
3274 this can happen when unwinding a zapped file descriptor.
3275 (Finsert_file_contents): Unwind-protect the fd before the point marker,
3276 in case Emacs runs out of memory between the two unwind-protects.
3277 Don't trash errno when closing FD.
3278 Zap the FD in the specpdl when closing it, instead of deferring
3279 the removal of the unwind-protect; this fixes a bug where a child
3280 function unwinds the stack past us.
3281
27e498e6
PE
3282 New unwind-protect flavors to better type-check C callbacks.
3283 This also lessens the need to write wrappers for callbacks,
3284 and the need for make_save_pointer.
3285 * alloca.c (free_save_value):
3286 * atimer.c (run_all_atimers):
3287 Now extern.
3288 * alloc.c (safe_alloca_unwind):
3289 * atimer.c (unwind_stop_other_atimers):
3290 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
3291 * menu.c (cleanup_popup_menu) [HAVE_NS]:
3292 * minibuf.c (choose_minibuf_frame_1):
3293 * process.c (make_serial_process_unwind):
3294 * xdisp.h (pop_message_unwind):
3295 * xselect.c (queue_selection_requests_unwind):
3296 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
3297 * alloca.c (record_xmalloc):
3298 Prefer record_unwind_protect_ptr to record_unwind_protect with
3299 make_save_pointer.
3300 * alloca.c (Fgarbage_collect):
3301 Prefer record_unwind_protect_void to passing a dummy.
3302 * buffer.c (restore_buffer):
3303 * window.c (restore_window_configuration):
3304 * xfns.c, w32fns.c (do_unwind_create_frame)
3305 New wrapper. All record-unwind uses of wrappee changed.
3306 * buffer.c (set_buffer_if_live):
3307 * callproc.c (call_process_cleanup, delete_temp_file):
3308 * coding.c (code_conversion_restore):
3309 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
3310 * editfns.c (save_excursion_restore)
3311 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
3312 (save_restriction_restore):
3313 * eval.c (restore_stack_limits, un_autoload):
3314 * fns.c (require_unwind):
3315 * keyboard.c (recursive_edit_unwind, tracking_off):
3316 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
3317 * macros.c (pop_kbd_macro, restore_menu_items):
3318 * nsfns.m (unwind_create_frame):
3319 * print.c (print_unwind):
3320 * process.c (start_process_unwind):
3321 * search.c (unwind_set_match_data):
3322 * window.c (select_window_norecord, select_frame_norecord):
3323 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
3324 (fast_set_selected_frame):
3325 * xfns.c, w32fns.c (unwind_create_tip_frame):
3326 Return void, not a dummy Lisp_Object. All uses changed.
3327 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
3328 * callproc.c (call_process_kill):
3329 * fileio.c (restore_point_unwind, decide_coding_unwind)
3330 (build_annotations_unwind):
3331 * insdel.c (Fcombine_after_change_execute_1):
3332 * keyboard.c (read_char_help_form_unwind):
3333 * menu.c (unuse_menu_items):
3334 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
3335 * sound.c (sound_cleanup):
3336 * xdisp.c (unwind_redisplay):
3337 * xfns.c (clean_up_dialog):
3338 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
3339 Accept no args and return void, instead of accepting and returning
3340 a dummy Lisp_Object. All uses changed.
3341 * cygw32.c (fchdir_unwind):
3342 * fileio.c (close_file_unwind):
3343 * keyboard.c (restore_kboard_configuration):
3344 * lread.c (readevalllop_1):
3345 * process.c (wait_reading_process_output_unwind):
3346 Accept int and return void, rather than accepting an Emacs integer
3347 and returning a dummy object. In some cases this fixes an
3348 unlikely bug when the corresponding int is outside Emacs integer
3349 range. All uses changed.
3350 * dired.c (directory_files_internal_unwind):
3351 * fileio.c (do_auto_save_unwind):
3352 * gtkutil.c (pop_down_dialog):
3353 * insdel.c (reset_var_on_error):
3354 * lread.c (load_unwind):
3355 * xfns.c (clean_up_file_dialog):
3356 * xmenu.c, nsmenu.m (pop_down_menu):
3357 * xmenu.c (cleanup_widget_value_tree):
3358 * xselect.c (wait_for_property_change_unwind):
3359 Accept pointer and return void, rather than accepting an Emacs
3360 save value encapsulating the pointer and returning a dummy object.
3361 All uses changed.
3362 * editfns.c (Fformat): Update the saved pointer directly via
3363 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3364 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3365 (unwind_body): New function.
3366 (record_unwind_protect): First arg is now a function returning void,
3367 not a dummy Lisp_Object.
3368 (record_unwind_protect_ptr, record_unwind_protect_int)
3369 (record_unwind_protect_void): New functions.
3370 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3371 * fileio.c (struct auto_save_unwind): New type.
3372 (do_auto_save_unwind): Use it.
3373 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3374 * insdel.c (struct rvoe_arg): New type.
3375 (reset_var_on_error): Use it.
3376 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3377 New constants.
3378 (specbinding_func): Remove; there are now several such functions.
3379 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3380 (set_unwind_protect_ptr): New function.
3381 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3382
4e604a5d
PE
3383 Be simpler and more consistent about reporting I/O errors.
3384 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3385 Say "Read error" and "Write error", rather than "I/O error", or
3386 "IO error reading", or "IO error writing", when a read or write
3387 error occurs.
3388 * process.c (Fmake_network_process, wait_reading_process_output)
3389 (send_process, Fprocess_send_eof, wait_reading_process_output):
3390 Capitalize diagnostics consistently. Put "failed foo" at the
3391 start of the diagnostic, so that we don't capitalize the
3392 function name "foo". Consistently say "failed" for such
3393 diagnostics.
3394 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3395 All callers changed. This is so it can use report_file_error.
3396 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3397 diagnostics consistently as above.
3398
a9757f6a
PE
3399 * fileio.c (report_file_errno): Fix errno reporting bug.
3400 If the file name is neither null nor a pair, package it up as a
3401 singleton list. All callers changed, both to this function and to
3402 report_file_error. This fixes a bug where the memory allocator
3403 invoked by list1 set errno so that the immediately following
3404 report_file_error reported the wrong errno value.
3405
c43843aa
PE
3406 Fix minor problems found by --enable-gcc-warnings.
3407 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3408 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3409
18c26d81
JD
34102013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3411
3412 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3413 Set event->arg to Qt if switch-event shall be generated.
3414 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3415
3416 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3417
3418 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3419 FOCUS_OUT_EVENT.
3420
3421 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3422 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3423 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3424 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3425 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3426 and there is a focused frame.
3427 (head_table): Add focus-in and focus-out.
3428 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3429 bind to handle-focus-in/out.
3430
3431 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3432 (Fhandle_switch_frame): Call Fhandle_focus_in.
3433 (syms_of_frame): defsubr handle-focus-in/out.
3434
6c6f1994
PE
34352013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3436
c7ddc792
PE
3437 Fix porting bug to older POSIXish platforms (Bug#14862).
3438 * sysdep.c (emacs_pipe): New function, that implements
3439 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3440 This should port better to CentOS 5 and to Mac OS X 10.6.
3441 All calls to pipe2 changed.
3442
6c6f1994
PE
3443 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3444 This makes the code easier to read and the executable a bit smaller.
3445 Do not replace all calls to Fcons that happen to create lists,
3446 just calls that are intended to create lists. For example, when
3447 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3448 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3449 Similarly for list2 through list5.
3450 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3451 * bytecode.c (exec_byte_code):
3452 * callint.c (quotify_arg, Fcall_interactively):
3453 * callproc.c (Fcall_process, create_temp_file):
3454 * charset.c (load_charset_map_from_file)
3455 (Fdefine_charset_internal, init_charset):
3456 * coding.c (get_translation_table, detect_coding_system)
3457 (Fcheck_coding_systems_region)
3458 (Fset_terminal_coding_system_internal)
3459 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3460 * composite.c (update_compositions, Ffind_composition_internal):
3461 * dired.c (directory_files_internal, file_name_completion)
3462 (Fsystem_users):
3463 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3464 * doc.c (Fsnarf_documentation):
3465 * editfns.c (Fmessage_box):
3466 * emacs.c (main):
3467 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3468 (Feval, eval_sub, Ffuncall, apply_lambda):
3469 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3470 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3471 (Fset_file_times, Finsert_file_contents)
3472 (Fchoose_write_coding_system, Fwrite_region):
3473 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3474 * font.c (font_registry_charsets, font_parse_fcname)
3475 (font_prepare_cache, font_update_drivers, Flist_fonts):
3476 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3477 * frame.c (make_frame, Fmake_terminal_frame)
3478 (x_set_frame_parameters, x_report_frame_params)
3479 (x_default_parameter, Fx_parse_geometry):
3480 * ftfont.c (syms_of_ftfont):
3481 * image.c (gif_load):
3482 * keyboard.c (command_loop_1):
3483 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3484 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3485 (Fminor_mode_key_binding, accessible_keymaps_1)
3486 (Faccessible_keymaps, Fwhere_is_internal):
3487 * lread.c (read_emacs_mule_char):
3488 * menu.c (find_and_return_menu_selection):
3489 * minibuf.c (get_minibuffer):
3490 * nsfns.m (Fns_perform_service):
3491 * nsfont.m (ns_script_to_charset):
3492 * nsmenu.m (ns_popup_dialog):
3493 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3494 (Fx_own_selection_internal):
3495 * nsterm.m (append2):
3496 * print.c (Fredirect_debugging_output)
3497 (print_prune_string_charset):
3498 * process.c (Fdelete_process, Fprocess_contact)
3499 (Fformat_network_address, set_socket_option)
3500 (read_and_dispose_of_process_output, write_queue_push)
3501 (send_process, exec_sentinel):
3502 * sound.c (Fplay_sound_internal):
3503 * textprop.c (validate_plist, add_properties)
3504 (Fput_text_property, Fadd_face_text_property)
3505 (copy_text_properties, text_property_list, syms_of_textprop):
3506 * unexaix.c (report_error):
3507 * unexcoff.c (report_error):
3508 * unexsol.c (unexec):
3509 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3510 (Fformat_mode_line, syms_of_xdisp):
3511 * xfaces.c (set_font_frame_param)
3512 (Finternal_lisp_face_attribute_values)
3513 (Finternal_merge_in_global_face, syms_of_xfaces):
3514 * xfns.c (x_default_scroll_bar_color_parameter)
3515 (x_default_font_parameter, x_create_tip_frame):
3516 * xfont.c (xfont_supported_scripts):
3517 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3518 (menu_help_callback, xmenu_show):
3519 * xml.c (make_dom):
3520 * xterm.c (set_wm_state):
3521 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3522 and similarly for list2 through list5.
3523
bafe80ce
PE
35242013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 * callproc.c (Fcall_process_region): Fix minor race and tune.
3527 (create_temp_file): New function, with the temp-file-creation part
3528 of the old Fcall_process_region. Use Fcopy_sequence to create the
3529 temp file name, rather than alloca + build_string, for simplicity.
3530 Don't bother to block input around the temp file creation;
068f9124
SM
3531 shouldn't be needed. Simplify use of mktemp.
3532 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3533 this closes an unlikely race where the temp file was not removed.
3534 Use memcpy rather than an open-coded loop.
3535 (Fcall_process_region): Use the new function. If the input is
3536 empty, redirect from /dev/null rather than from a newly created
3537 empty temp file; this avoids unnecessary file system traffic.
3538
4700b5a5
PE
35392013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3540
5c97beae
PE
3541 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3542 Simplify by making this case like the other two. This is a bit
3543 slower on obsolete hosts, but the extra complexity isn't worth it.
3544
4700b5a5
PE
3545 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3546 * process.c (create_process) [!DOS_NT]:
3547 Remove now-unnecessary calls to emacs_close.
3548
f9a74c4c
EZ
35492013-07-13 Eli Zaretskii <eliz@gnu.org>
3550
922ae7ee
EZ
3551 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3552 returning early. (Bug#14850)
3553
f9a74c4c
EZ
3554 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3555 and inhibit-iso-escape-detection attributes of 'undecided'.
3556 (Bug#14822)
3557
5e301d76
PE
35582013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3559
69e0e5ee
PE
3560 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3561 Reported by Herbert J. Skuhra in
3562 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3563
5e301d76
PE
3564 Don't lose top specpdl entry when memory is exhausted.
3565 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3566 specpdl overflow here, to simplify callers; all callers changed.
3567 Always reserve an unused entry at the stack top; this avoids
3568 losing the top entry's information when memory is exhausted.
3569
7e649856
PE
35702013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3571
a773ed9a
PE
3572 Clean up errno reporting and fix some errno-reporting bugs.
3573 * callproc.c (Fcall_process):
3574 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3575 * process.c (create_process, Fmake_network_process):
3576 * unexaix.c (report_error):
3577 * unexcoff.c (report_error):
3578 Be more careful about reporting the errno of failed operations.
3579 The code previously reported the wrong errno sometimes.
3580 Also, prefer report_file_errno to setting errno + report_file_error.
3581 (Fcall_process): Look at openp return value rather than at path,
3582 as that's a bit faster and clearer when there's a numeric predicate.
3583 * fileio.c (report_file_errno): New function, with most of the
3584 old contents of report_file_error.
3585 (report_file_error): Use it.
3586 (Ffile_exists_p, Ffile_accessible_directory_p):
3587 Set errno to 0 when it is junk.
3588 * fileio.c (Faccess_file):
3589 * image.c (x_create_bitmap_from_file):
3590 Use faccessat rather than opening the file, to avoid the hassle of
3591 having a file descriptor open.
3592 * lisp.h (report_file_errno): New decl.
3593 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3594
7e649856
PE
3595 Minor EBADF fixes.
3596 * process.c (create_process, wait_reading_process_output) [AIX]:
3597 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3598 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3599 a multithreaded environment anyway).
3600 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3601
f6774c1a
AS
36022013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3603
3604 * image.c (x_find_image_file): Don't close a remote file handle.
3605
bacba3c2
PE
36062013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 Fix races with threads and file descriptors.
3609 * callproc.c (Fcall_process_region):
3610 * dired.c (open_directory):
3611 * emacs.c (main, Fdaemon_initialized):
3612 * image.c (x_find_image_file):
3613 * inotify.c (Finotify_rm_watch):
3614 * lread.c (Flocate_file_internal):
3615 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3616 * term.c (term_mouse_moveto, init_tty):
3617 * termcap.c (tgetent):
3618 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3619 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3620 * unexhp9k800.c, unexmacosx.c (unexec):
3621 * callproc.c (Fcall_process_region):
3622 Use emacs_close, not close.
3623 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3624 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3625 and posix_close function on current platforms (which all lack them).
3626 (emacs_close): Use it. This should fix the races on GNU/Linux and
3627 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3628 and it should avoid closing random victim file descriptors on
3629 other platforms.
3630
653d4f43
PE
36312013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3632
c8536ec4
PE
3633 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3634 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3635 Touch up doc a bit.
3636
9c203066
PE
3637 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3638 This is for .gdbinit xbacktrace.
3639
653d4f43
PE
3640 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3641 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3642 (emacs_set_tty): Now static.
3643 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3644 * term.c (tty_capable_p, tty_default_color_capabilities)
3645 (get_tty_terminal, term_mouse_movement)
3646 (handle_one_term_event, init_tty, maybe_fatal):
3647 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3648 (tgetent, scan_file, name_match, compare_contin):
3649 * terminal.c (get_terminal):
3650 Use bool for boolean.
3651 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3652 Prefer char to unsigned char if either will do.
3653 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3654 (tty_write_glyphs): Prefer int to unsigned.
3655 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3656 All callers changed.
3657 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3658
45b683a1
PE
36592013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3660
29abe551
PE
3661 Port to C89.
3662 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3663 (B__dummy__): New dummy symbol, to pacify C89.
3664 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3665 they can't grok varargs macros.
3666 * dispnew.c (add_window_display_history)
3667 (add_frame_display_history):
3668 * print.c (print_object):
3669 * xdisp.c (debug_method_add):
3670 Use %p printf format only for void pointers.
3671 * emacs.c (usage_message): New constant, replacing ...
3672 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3673 (main): Adjust to usage reorg.
3674 * fns.c (syms_of_fns):
3675 * profiler.c (syms_of_profiler):
3676 Don't use non-constant struct initializers.
3677 * gnutls.h (gnutls_initstage_t):
3678 * lisp.h (enum Lisp_Fwd_Type):
3679 * lread.c (lisp_file_lexically_bound_p):
3680 * xsettings.c (anonymous enum):
3681 Remove trailing comma.
3682 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3683 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3684 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3685 (DEFUN): Use it.
3686 * regex.c (const_re_char): New type, to pacify strict C89.
3687 All uses of 'const re_char' replaced to use it.
3688 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3689 with glibc when strict C89. This change is imported from gnulib.
3690 All uses changed.
3691 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3692 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3693 Omit GNU_LINUX implementation, since it requires long long.
3694 * xterm.c (x_draw_underwave):
3695 Do not assume the traditional order of struct's members.
3696 (x_term_init): Rewrite to avoid the need for non-constant structure
3697 initializers.
3698
45b683a1 3699 Syntax cleanup, mostly replacing macros with functions.
763a086d 3700 This removes the need for the syntax_temp hack.
45b683a1
PE
3701 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3702 * syntax.c (SYNTAX_INLINE): New macro.
3703 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3704 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3705 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3706 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3707 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3708 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3709 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3710 Now constants, not macros.
3711 (syntax_temp) [!__GNUC__]: Remove.
3712 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3713 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3714 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3715 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3716 Move here from syntax.h; now functions, not macros. Except for the
3717 last function, these are static since only syntax.c uses them.
3718 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3719 All uses changed. Now a function, not a macro; use this fact
3720 to simplify the code.
3721 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3722 compiler bugs; no longer relevant.
3723 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3724 (SYNTAX_INLINE): New macro.
3725 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3726 for the new functions. Use bool for boolean member.
3727 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3728 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3729 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3730 (SETUP_BUFFER_SYNTAX_TABLE):
3731 Now extern inline functions, not macros.
3732 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3733 Remove; all uses replaced by implementation.
3734 (syntax_temp) [!__GNUC__]: Remove decl.
3735 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3736
29be4a50
JD
37372013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3738
3739 * emacs.c (main): Fix syntax error.
3740
954b166e
PE
37412013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 Timestamp fixes for undo (Bug#14824).
3744 * atimer.c (schedule_atimer):
3745 * fileio.c (Ffile_newer_than_file_p):
3746 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3747 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3748 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3749 (syms_of_fileio): Remove Sclear_visited_file_name.
3750 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3751 file doesn't exist; this avoids an ambiguity with negative timestamps.
3752 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3753 * systime.h (make_emacs_time, invalid_emacs_time):
3754 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3755 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3756 * undo.c (record_first_change): Push (visited-file-modtime) onto
3757 undo list rather than reimplementing it by hand, incorrectly.
3758
d74647c3
KB
37592013-07-09 Ken Brown <kbrown@cornell.edu>
3760
3761 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3762
3c51b96b
JB
37632013-07-09 Juanma Barranquero <lekktu@gmail.com>
3764
3765 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3766
4ebbdd67
PE
37672013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3768
3769 Handle errno and exit status a bit more carefully.
3770 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3771 number into an exit status. Instead, use EXIT_CANCELED.
3772 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3773 * callproc.c (relocate_fd):
3774 * emacs.c (close_output_streams, main):
3775 * process.c (create_process):
3776 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3777 Use emacs_perror for simplicity.
3778 * callproc.c (relocate_fd, main):
3779 * sysdep.c (sys_subshell):
3780 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3781 (shut_down_emacs): Use emacs_write, not write.
3782 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3783 * fileio.c (Fcopy_file, e_write):
3784 * nsterm.m (ns_select):
3785 * process.c (send_process):
3786 * sound.c (vox_write):
3787 Use emacs_write_sig, not emacs_write.
3788 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3789 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3790 New constants.
3791 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3792 of write.
3793 (emacs_full_write): New function.
3794 (emacs_write): Rewrite to use it.
3795 (emacswrite_sig, emacs_perror): New functions.
3796 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3797
44e18199 37982013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3799
3800 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3801 on NS even if it is present. Pixmap on NS is a void*.
3802
9caab067
PE
38032013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3804
3805 Port to Ubuntu 10 (Bug#14803).
3806 Problem reported by T.V. Raman.
3807 * process.c (close_on_exec, accept4, process_socket):
3808 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3809
1d442672
EZ
38102013-07-07 Eli Zaretskii <eliz@gnu.org>
3811
3812 * w32.c (sys_dup): Declare prototype.
3813
3814 * filelock.c:
3815 * emacs.c:
3816 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3817
067428c1
PE
38182013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3819
3820 Make file descriptors close-on-exec when possible (Bug#14803).
3821 This simplifies Emacs a bit, since it no longer needs to worry
3822 about closing file descriptors by hand in some cases.
3823 It also fixes some unlikely races. Not all such races, as
3824 libraries often open files internally without setting
3825 close-on-exec, but it's an improvement.
3826 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3827 * callproc.c (Fcall_process) [!MSDOS]:
3828 * emacs.c (main) [!DOS_NT]:
3829 * nsterm.m (ns_term_init):
3830 * process.c (create_process):
3831 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3832 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3833 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3834 Prefer mkostemp with O_CLOEXEC to mkstemp.
3835 * callproc.c (relocate_fd) [!WINDOWSNT]:
3836 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3837 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3838 now using pipe2.
3839 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3840 Make the resulting file descriptor close-on-exec.
3841 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3842 * lread.c (load_descriptor_list, load_descriptor_unwind):
3843 Remove; no longer needed. All uses removed.
3844 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3845 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3846 New functions.
3847 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3848 (Fmake_network_process, Fnetwork_interface_list):
3849 (Fnetwork_interface_info, server_accept_connection):
3850 Make newly-created socket close-on-exec.
3851 * sysdep.c (emacs_open, emacs_fopen):
3852 Make new-created descriptor close-on-exec.
3853 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3854 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3855
0da857dd
JD
38562013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3857
3858 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3859 for NS_IMPL_GNUSTEP.
3860
5f86adcd
PE
38612013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3862
3863 Fix openp errno handling.
3864 * callproc.c (Fcall_process): Preserve openp errno around close.
3865 * lread.c (openp): Set errno when returning -1, as some callers
3866 expect this.
3867
1afb1d07
JD
38682013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3869
3870 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3871
3872 * nsterm.h (NSSavePanel): Update comment.
3873 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3874 (ns_run_file_dialog): Declare.
3875
3876 * nsfns.m: Remove panelOK.
3877 (ns_fd_data): New.
3878 (ns_run_file_dialog): New function.
3879 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3880 event loop, so file dialog is popped up by ns_run_file_dialog, called
3881 by sendEvent (Bug#14578).
3882 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3883
3323c263
EZ
38842013-07-06 Eli Zaretskii <eliz@gnu.org>
3885
fdda0220
EZ
3886 * xdisp.c (default_line_pixel_height): New function.
3887 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3888 (try_cursor_movement, redisplay_window, try_window)
3889 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3890
068f9124
SM
3891 * window.c (window_scroll_pixel_based):
3892 use default_line_pixel_height.
fdda0220
EZ
3893
3894 * dispextern.h (default_line_pixel_height): Add prototype.
3895
3896 * frame.c (x_set_line_spacing): Accept a float value for
3897 line-spacing parameter, per the documentation.
3898
3323c263
EZ
3899 * data.c (Fmultibyte_string_p): Doc fix.
3900
47ba6d43
PE
39012013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3902
406af475
PE
3903 Use emacs_open more consistently when opening files.
3904 This handles EINTR more consistently now, and makes it easier
3905 to introduce other uniform changes to file descriptor handling.
3906 * src/systdio.h: New file.
3907 * src/buffer.c (mmap_init):
3908 * cygw32.c (chdir_to_default_directory):
3909 * dispnew.c (Fopen_termscript):
3910 * emacs.c (Fdaemon_initialized):
3911 * fileio.c (Fdo_auto_save):
3912 * image.c (slurp_file, png_load_body, jpeg_load_body):
3913 * keyboard.c (Fopen_dribble_file):
3914 * lread.c (Fload):
3915 * print.c (Fredirect_debugging_output):
3916 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3917 * termcap.c (tgetent):
3918 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3919 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3920 * w32term.c (w32_initialize) [CYGWIN]:
3921 * xfaces.c (Fx_load_color_file):
3922 Use emacs_open instead of plain open, and emacs_fopen instead of
3923 plain fopen.
3924 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3925 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3926 * callproc.c (default_output_mode): New constant.
3927 (Fcall_process): Use it to call emacs_open instead of plain creat.
3928 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3929 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3930 (emacs_fopen): New function.
3931 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3932 Include <lisp.h>, for emacs_open.
3933 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3934
47ba6d43
PE
3935 Remove duplicate #include directives.
3936 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3937 * xfaces.c:
3938 Don't include stdio.h twice.
3939 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3940 Don't include sys/types.h or stdio.h twice.
3941 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3942 * lread.c: Don't include coding.h twice.
3943 * nsfont.m: Don't include frame.h twice.
3944 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3945 * ralloc.c: Don't include <unistd.h> twice.
3946 * xdisp.c: Don't include font.h twice.
3947 * xterm.c: Don't include fontset.h twice.
3948 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3949
b9ed53d5
PE
39502013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3951
3952 Scale ImageMagick images more carefully.
3953 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3954 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3955 Be more careful about avoiding undefined behavior after
3956 integer overflow and division by zero.
3957
cf13177e
YM
39582013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3959
3960 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3961 (syms_of_w32fns): DEFSYM them.
3962 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3963 (CCHDEVICENAME): Define macros if not defined.
3964 (struct MONITOR_INFO_EX): New struct.
3965 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3966 (enum_display_monitors_fn): New variable.
3967 (globals_of_w32fns): Initialize it.
3968 (Fx_display_pixel_width, Fx_display_pixel_height)
3969 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3970 multi-monitor setups in docstrings.
3971 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3972 screen size by primary monitor's millimeter per pixel.
3973 (w32_monitor_enum, w32_display_monitor_attributes_list)
3974 (w32_display_monitor_attributes_list_fallback)
3975 (Fw32_display_monitor_attributes_list): New functions.
3976 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3977
3978 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3979 if not defined.
3980 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3981
86dfb7a8
MA
39822013-07-04 Michael Albinus <michael.albinus@gmx.de>
3983
3984 * fileio.c (Qfile_notify_error): New error symbol.
3985
3986 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3987 * inotify.c (inotify_callback, symbol_to_inotifymask)
3988 (Finotify_add_watch, Finotify_rm_watch): Use it.
3989 (inotifyevent_to_event): Exchange order of cookie and file name.
3990 (Finotify_add_watch): Adapt docstring.
3991
3992 * lisp.h (Qfile_notify_error): Declare.
3993
2c1c974b
PE
39942013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3995
3996 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3997 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3998 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3999 which did not work (see <http://bugs.gnu.org/14569#307>).
4000 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
4001 && (!noninteractive || initialized)). This attempts to thread
4002 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
4003
7a35b20f
JB
40042013-07-04 Juanma Barranquero <lekktu@gmail.com>
4005
4006 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
4007 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
4008
1ce5cd04
PE
40092013-07-04 Paul Eggert <eggert@cs.ucla.edu>
4010
4011 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
4012 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4013 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
4014 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
4015
57f8c490
PE
40162013-07-02 Paul Eggert <eggert@cs.ucla.edu>
4017
4018 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
4019 Define to __sys_siglist.
4020
bcffb5ca
EZ
40212013-07-02 Eli Zaretskii <eliz@gnu.org>
4022
4023 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
4024 word-wrap, so that overflow-newline-into-fringe would work in
4025 visual-line-mode. (Bug#2749)
4026 (move_it_in_display_line_to): When the last scanned display
4027 element fits exactly on the display line, and
4028 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
4029 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
4030 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
4031 finding buffer position that corresponds to pixel coordinates,
4032 e.g. in buffer_posn_from_coords.
4033
2c41e781
JD
40342013-07-02 Jan Djärv <jan.h.d@swipnet.se>
4035
4036 * process.c (handle_child_signal): Call catch_child_signal if
4037 NS_IMPL_GNUSTEP.
4038
c2418359
PE
40392013-07-02 Paul Eggert <eggert@cs.ucla.edu>
4040
52a9bcae
PE
4041 Don't convert function pointers to void * and back.
4042 It isn't portable C, and it's easy enough to avoid.
4043 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
4044 (make_save_value): Add support for SAVE_FUNCPOINTER.
4045 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
4046 * print.c (print_object):
4047 Distinguish function from object pointers.
4048 * lisp.h (SAVE_FUNCPOINTER): New constant.
4049 (SAVE_SLOT_BITS): Adjust to it.
4050 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
4051 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
4052 (voidfuncptr): New typedef.
4053 (struct Lisp_Save_Value): New member data[0].funcpointer.
4054 (XSAVE_FUNCPOINTER): New function.
4055
c2418359
PE
4056 Simplify buildobj processing.
4057 * Makefile.in (buildobj.h): Make it a sequence of strings each
4058 followed by comma, rather than a single string. Put it into a
4059 .tmp file in case there's an error while generating it.
4060 (gl-stamp): Use .tmp for temp files.
4061 (mostlyclean): Clean .tmp files.
4062 * doc.c (buildobj): Move to just the routine that needs it.
4063 It's now an array of strings, so processing is simpler.
4064
8f43ce49
PE
40652013-07-01 Paul Eggert <eggert@cs.ucla.edu>
4066
4067 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
4068 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
4069 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4070 Invoke malloc_enable_thread even when not interactive.
4071 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
4072 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
4073 in this case, since the underlying bug has now been fixed.
4074
24827db9
JB
40752013-07-01 Juanma Barranquero <lekktu@gmail.com>
4076
4077 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
4078 unlinking it (bug#14691).
4079
ef099a94
MN
40802013-06-30 Michal Nazarewicz <mina86@mina86.com>
4081
4082 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
4083 before checking whether buffer is modified. This lets
4084 `kill-buffer-query-functions' cancel killing of the buffer or save
4085 its content before `kill-buffer' asks user the "Buffer %s
4086 modified; kill anyway?" question.
4087
9d3f2fc2
JD
40882013-06-30 Jan Djärv <jan.h.d@swipnet.se>
4089
4090 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
4091 Let the super performKeyEquivalent deal with them (Bug#14747).
4092
e6c6c8c7
PE
40932013-06-30 Paul Eggert <eggert@cs.ucla.edu>
4094
1d71c1d9
PE
4095 * widget.c (resize_cb): Remove unused local.
4096
8f5f35cc
PE
4097 Do not use GTK 3 if it exists but cannot be compiled.
4098 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
4099 * xterm.c (x_error_handler) [!USE_GTK]:
4100 Do not use GTK 3.
4101
e6c6c8c7
PE
4102 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
4103
0ba54312
EZ
41042013-06-30 Eli Zaretskii <eliz@gnu.org>
4105
5d1c3286
EZ
4106 * intervals.c (get_local_map): Instead of aborting, clip POSITION
4107 to the valid range of values. (Bug#14753)
4108
0ba54312
EZ
4109 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
4110 when moving point by using the current glyph matrix. This avoids
4111 the need to force redisplay when this function is called in a
4112 loop.
4113
9c90cc06
PE
41142013-06-29 Paul Eggert <eggert@cs.ucla.edu>
4115
4116 Fix minor problems found by static checking.
4117 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
4118 Redo the latter's body to sidestep GCC parenthesization warnings.
4119 (setup_coding_system, detect_coding, detect_coding_system): Use them.
4120 * coding.c (detect_coding, detect_coding_system):
4121 * coding.h (struct undecided_spec):
4122 Use bool for boolean.
4123 * image.c (QCmax_width, QCmax_height): Now static.
4124 * xdisp.c (Fmove_point_visually): Remove unused local.
4125
4c672a0f
EZ
41262013-06-29 Eli Zaretskii <eliz@gnu.org>
4127
4128 * xdisp.c (Fmove_point_visually): New function.
4129
c1ea3abf
JB
41302013-06-28 Kenichi Handa <handa@gnu.org>
4131
4132 * coding.h (define_coding_undecided_arg_index): New enum.
4133 (coding_attr_index): New members
4134 coding_attr_undecided_inhibit_null_byte_detection,
4135 coding_attr_undecided_inhibit_iso_escape_detection,
4136 coding_attr_undecided_prefer_utf_8.
4137 (undecided_spec): New struct.
4138 (struct coding_system): New member `undecided' of the member
4139 `spec'.
4140
4141 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
4142 (detect_coding): Likewise.
4143 (detect_coding_system): Likewise.
4144 (Fdefine_coding_system_internal): New coding system properties
4145 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
4146 :prefer-utf-8.
4147 (syms_of_coding): Adjust for coding_arg_undecided_max.
4148
ba3de9e6
PE
41492013-06-28 Paul Eggert <eggert@cs.ucla.edu>
4150
4151 * image.c (x_from_xcolors): Remove unused local.
4152
547c9269
YM
41532013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4154
4155 Defer image data transfer between X client and server until actual
4156 display happens.
4157
4158 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
4159 and `mask_img'.
4160
4161 * image.c (Destroy_Image): Remove.
4162 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
4163 `mask_p', and `colors_p'. All uses changed.
4164 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
4165 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
4166 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
4167 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
4168 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 4169 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
4170 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
4171 (image_get_x_image, image_unget_x_image): New functions or macros.
4172 (image_background, image_background_transparent, x_to_xcolors)
4173 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
4174 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
4175 instead of Destroy_Image.
4176 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
4177 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
4178 (png_load_body, jpeg_load_body, tiff_load, gif_load)
4179 (imagemagick_load_image, svg_load_image): Use them instead of
4180 x_create_x_image_and_pixmap, and x_put_x_image followed by
4181 x_destroy_x_image, respectively.
4182 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
4183 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
4184 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
4185 background_transparent fields.
4186 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
4187 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
4188
dae2f5ef
PE
41892013-06-27 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
4192 This mostly consists of undoing recent changes.
4193 * callproc.c (Fcall_process):
4194 * process.c (create_process):
4195 Do not worry about catching SIGCHLD here, undoing previous change.
4196 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
4197 * process.c, process.h (catch_child_signal):
4198 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
4199 * process.c (catch_child_handler): Don't worry about being called
4200 lazily and do not assume caller has blocked SIGCHLD, undoing
4201 previous change. Move first-time stuff back to
4202 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
4203 tickle glib, as that causes Cygwin bootstrap to fail. Do not
4204 set lib_child_handler if it's already initialized, which may
4205 help avoid problems on GNUStep.
4206
fa55d2aa
PE
42072013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4208
4209 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
4210 * callproc.c (Fcall_process):
4211 * process.c (create_process):
4212 Make sure SIGCHLD is caught before we fork,
4213 since Emacs startup no arranges to catch SIGCHLD.
4214 * process.c (lib_child_handler): Initialize to null, not to
4215 dummy_handler.
4216 (catch_child_signal): Allow self to be called lazily.
4217 Do nothing if it's already been called.
4218 Assume caller has blocked SIGCHLD (all callers do now).
4219 * emacs.c (main): Do not catch SIGCHLD here; defer it until
4220 just before it's really needed.
4221 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
4222 since it hasn't been caught yet.
4223
f3f9606c
LMI
42242013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
4225
4226 * image.c (compute_image_size): New function to implement
4227 :max-width and :max-height.
4228 (imagemagick_load_image): Use it.
4229
c7041908
PE
42302013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4231
4232 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
4233 * callproc.c, process.h (block_child_signal, unblock_child_signal):
4234 Now extern.
4235 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
4236 * process.c (catch_child_signal): Block SIGCHLD while futzing with
4237 the SIGCHLD handler, since the code is not atomic and (due to glib)
4238 signals may be arriving now.
4239 * sysdep.c (init_signals): Do not catch child signals here;
4240 'main' now does that later, at a safer time.
4241
f86852b4
PE
42422013-06-22 Paul Eggert <eggert@cs.ucla.edu>
4243
0dfeed58
PE
4244 Clean up SIGCHLD handling a bit (Bug#14569).
4245 * process.c, process.h (catch_child_signal):
4246 Now always extern, even if !NS_IMPL_GNUSTEP.
4247 * process.c (catch_child_signal): Move glib tickler here from
4248 init_process_emacs, so that it's done earlier in Emacs
4249 initialization. Also move the noninteractive && !initialized
4250 check here from init_process_emacs. This is all a bit cleaner for
4251 GNUish platforms, and I hope it works around the Cygwin bug.
4252 * sysdep.c (init_signals): Invoke catch_child_signal here, so
4253 that glib signal handling is tickled before glib creates threads.
4254
f86852b4
PE
4255 * process.c (wait_reading_process_output): Avoid int overflow
4256 when reading more than 2 GiB total from a process.
4257
cbd6509c
PE
42582013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 * process.c (create_process): Handle a couple more cases,
4261 i.e., work even if new_argv and wait_child_setup[i] are cached.
4262 Use Fcall_process's style for volatile vars.
4263
9de1114a
AS
42642013-06-21 Andreas Schwab <schwab@linux-m68k.org>
4265
4266 * process.c (create_process): Mark PROCESS volatile.
4267
fbe9e0b9
PE
42682013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4269
4270 Use C99-style flexible array members if available.
4271 This avoids some subtle aliasing issues, which typically
4272 aren't a problem with GCC but may be a problem elsewhere.
4273 * alloc.c (sdata): New typedef, replacing the old struct sdata.
4274 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
4275 In either case, it uses a flexible array member rather than
4276 the old struct hack. All uses changed.
4277 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
4278 Adjust to sdata reorganization.
4279 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
4280 Use offsetof (struct, flex_array_member), not sizeof (struct), as
4281 that ports better to pre-C99 non-GCC.
4282 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
4283 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
4284 as the latter has changed.
4285 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
4286 and port better to pre-C99 GCC.
4287 * image.c (struct xpm_cached_color):
4288 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
4289 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
4290 Use FLEXIBLE_ARRAY_MEMBER.
4291 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
4292 Move decl to top level so it gets checked against implementation.
4293 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
4294 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
4295
1fc71008
PE
42962013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 * syntax.c: Integer cleanups.
4299 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
4300 All uses that need 0-or-2 changed to:
4301 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
4302 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
4303 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
4304 (char_quoted, prev_char_comend_first, back_comment)
4305 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4306 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
4307 Use bool for boolean.
4308 (update_syntax_table, skip_chars, skip_syntaxes):
4309 Prefer int to unsigned when either will do.
4310 (back_comment): Return boolean success flag, like forw_comment,
4311 instead of positive-or-minus-1 (which might have overflowed int anyway).
4312 Don't stuff ptrdiff_t into int.
4313 (syntax_spec_code, syntax_code_spec): Now const.
4314 (Fmatching_paren, scan_lists, scan_sexps_forward):
4315 Use enum syntaxcode for syntax code.
4316 (Fmatching_paren): Check that arg is a character, not just an integer.
4317 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
4318 (Finternal_describe_syntax_value): Omit no-longer-needed
4319 comparison to 0.
4320 (skip_chars): Use char, not unsigned char, when the distinction
4321 doesn't matter.
4322 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
4323 * bytecode.c (exec_byte_code):
4324 * syntax.c (syntax_spec_code, Fchar_syntax)
4325 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4326 (init_syntax_once):
4327 * syntax.h (SYNTAX_WITH_FLAGS):
4328 Omit unnecessary casts.
4329
b932cad7
EZ
43302013-06-20 Eli Zaretskii <eliz@gnu.org>
4331
4332 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
4333 line dimensions here, to avoid race conditions with the main
4334 thread. (Bug#14062, bug#14630, bug#14669)
4335
4336 * w32term.c (w32_draw_window_cursor): Compute the header line and
4337 mode line dimensions here.
4338 <w32_system_caret_window, w32_system_caret_hdr_height>:
4339 <w32_system_caret_mode_height>: New variables.
4340
4341 * w32term.h: Declare them.
4342
89561f72
PE
43432013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4344
5013fc08
PE
4345 * alloc.c (die): Move "assertion failed" string here ...
4346 * lisp.h (eassert): ... from here. Also, suppress evaluation of
4347 COND when SUPPRESS_CHECKING. This shrinks the executable text
4348 size by 0.8% to 2.2% when configured with --enable-checking,
4349 depending on optimization flags (GCC 4.8.1 x86-64).
4350
89561f72
PE
4351 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
4352
763a086d 43532013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
4354
4355 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4356 base is 2; this is more accurate.
4357
983aeb9a
JB
43582013-06-19 Juanma Barranquero <lekktu@gmail.com>
4359
4360 * sound.c (string_default): Move to !WINDOWSNT section.
4361 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4362
178ba3e6
PE
43632013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4364
bbc51b15
PE
4365 * sound.c: Integer cleanups.
4366 Remove unnecessary forward decls.
4367 (struct sound_device): The 'file' member is now a Lisp_Object, not
4368 a char *, so that we needn't invoke alloca on a huge size.
4369 (Fplay_sound_internal): Adjust to this.
4370 (string_default): New function.
4371 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4372 Use it to adjust to the struct sound_device change.
4373 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4374 (be2hs) [0]: Remove.
4375
178ba3e6
PE
4376 * syntax.c (skip_chars): Don't use uninitialized storage
4377 when searching a multibyte buffer for characters that are not in a
4378 unibyte string that contains non-ASCII characters.
4379
69f60cdc
JD
43802013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4381
4382 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4383 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4384
0d6224d4
PE
43852013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4388
3c542890
KH
43892013-06-18 Kenichi Handa <handa@gnu.org>
4390
f7e3f7cd
KH
4391 * font.c (Ffont_spec): Signal an error for an invalid font name
4392 (Bug#14648).
3c542890 4393
9349e5f7
PE
43942013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4395
4396 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4397 In particular this ports to 32-bit sparc Sun cc.
4398 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4399 array with a dummy element at specpdl[-1], so that its address can
4400 be taken portably.
4401 (unbind_to): Do not copy the binding; not needed, now that we
4402 copy old_value in the one place where the copy is needed.
4403 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4404 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4405 (union specbinding): Rename from struct specbinding. Redo layout
4406 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4407 which is not portable. With Sun C 5.12 32-bit sparc, the
4408 declaration causes nargs to be an unsigned bitfield, a behavior
4409 that the C standard allows; but Emacs wants nargs to be signed.
4410 The overall type is now a union of structures rather than a
4411 structure of union of structures, and the 'kind' member is now a
4412 bitfield, so that the overall type doesn't grow. All uses changed.
4413 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4414
0a4df6a5
PE
44152013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4416
ec6ecaad
PE
4417 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4418 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4419
0a4df6a5
PE
4420 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4421
7bfe8dbc
EZ
44222013-06-17 Eli Zaretskii <eliz@gnu.org>
4423
4424 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4425 unless we know that the window w's frame is a frame object.
4426 Another attempt at solving bug#14062 and bug#14630.
4427
708e05f6
LMI
44282013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4429
4430 * textprop.c (property_set_type): New enum.
4431 (add_properties): Allow appending/prepending text properties.
4432 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4433 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4434 add_text_properties_1.
4435 (Fadd_face_text_property): New function that calls
4436 add_text_properties_1.
4437
84575e67
PE
44382013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4439
4440 Move functions from lisp.h to individual modules when possible.
4441 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4442 * alloc.c (XFLOAT_INIT, set_symbol_name):
4443 * buffer.c (CHECK_OVERLAY):
4444 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4445 (set_char_table_parent):
4446 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4447 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4448 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4449 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4450 (set_blv_valcell):
4451 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4452 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4453 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4454 (backtrace_args, backtrace_debug_on_exit):
4455 * floatfns.c (CHECK_FLOAT):
4456 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4457 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4458 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4459 (set_hash_index_slot):
4460 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4461 * marker.c (CHECK_MARKER):
4462 * textprop.c (CHECK_STRING_OR_BUFFER):
4463 * window.c (CHECK_WINDOW_CONFIGURATION):
4464 Move here from lisp.h, and make these functions static rather than
4465 extern inline.
4466 * buffer.c (Qoverlayp):
4467 * data.c (Qsubrp):
4468 * fns.c (Qhash_table_p):
4469 * window.c (Qwindow_configuration_p):
4470 Now static.
4471 * lisp.h: Remove the abovementioned defns and decls.
4472
44e18199 4473 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4474 In lisp.h, prefer functions to function-like macros, and
4475 constants to object-like macros, when either will do. This:
4476 . simplifies use, as there's no more need to worry about
4477 arguments' side effects being evaluated multiple times.
4478 . makes the code easier to debug on some platforms.
4479 However, when using gcc -O0, keep using function-like macros
4480 for a few critical operations, for performance reasons.
4481 This sort of thing isn't needed with gcc -Og, but -Og
4482 is a GCC 4.8 feature and isn't widely-enough available yet.
4483 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4484 Remove enum lsb_bits; no longer needed.
4485 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4486 * buffer.c (Qoverlap):
4487 * data.c (Qsubrp):
4488 * fns.c (Qhash_table_p):
4489 Now extern, so lisp.h can use these symbols.
4490 * dispextern.h: Include character.h, for MAX_CHAR etc.
4491 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4492 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4493 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4494 (GLYPH_CODE_P): Move here from lisp.h.
4495 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4496 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4497 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4498 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4499 XUNTAG now returns void *.
4500 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4501 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4502 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4503 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4504 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4505 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4506 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4507 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4508 New macros, renamed from their sans-lisp_h_ counterparts.
4509 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4510 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4511 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4512 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4513 If compiling via GCC without optimization, define these as macros
4514 in addition to inline functions.
4515 To disable this, compile with -DINLINING=0.
4516 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4517 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4518 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4519 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4520 (INTMASK, VALMASK): Now macros, since static values cannot be
4521 accessed from extern inline functions.
4522 (VALMASK): Also a constant, for benefit of old GDB.
4523 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4524 is INTEGERP, which can fold it in.
5165d44a 4525 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4526 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4527 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4528 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4529 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4530 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4531 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4532 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4533 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4534 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4535 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4536 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4537 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4538 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4539 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4540 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4541 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4542 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4543 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4544 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4545 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4546 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4547 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4548 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4549 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4550 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4551 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4552 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4553 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4554 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4555 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4556 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4557 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4558 Now functions.
4559 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4560 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4561 (VALMASK): Define in one place rather than in two, merging the
4562 USE_LSB_TAG parts; this is simpler.
4563 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4564 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4565 Move up, to avoid use before definition.
4566 Also include "globals.h" earlier, for the same reason.
4567 (make_natnum): New function.
4568 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4569 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4570 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4571 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4572 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4573 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4574 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4575 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4576 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4577 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4578 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4579 (Qwindow_configuration_p, Qimage): New forward declarations.
4580 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4581 (STRING_COPYIN): Remove; unused.
4582 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4583 (xcar_addr, xcdr_addr): New functions. All uses changed.
4584 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4585 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4586 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4587 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4588 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4589 (TYPE_RANGED_INTEGERP): Simplify.
4590 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4591 (setlocale, fixup_locale, synchronize_system_messages_locale)
4592 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4593 Now empty functions, not macros.
4594 (functionp): Return bool, not int.
4595 * window.c (Qwindow_configuration_p): Now extern,
4596 so window.h can use it.
4597 * window.h (Qwindowp): Move decl back to lisp.h.
4598
9583ec36
EZ
45992013-06-15 Eli Zaretskii <eliz@gnu.org>
4600
4601 * xdisp.c (Fline_pixel_height): New function, required for solving
4602 bug #14567.
4603
210272ce
PE
46042013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4605
4606 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4607
de0503df
SM
46082013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4609
4610 * lread.c (syms_of_lread):
4611 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4612
afbfe143
KD
46132013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4614
4615 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4616
d177e213
XF
46172013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4618
4619 * fileio.c (expand_file_name): Doc fix.
4620
05e3e412
PE
46212013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4622
f7394b12
PE
4623 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4624 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4625 Wait for self, not for 0. This can't hurt on GNU or similar
4626 system, and may help with Cygwin.
4627
05e3e412
PE
4628 * keyboard.c: Don't use PROP (...) as an lvalue.
4629 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4630 Use set_prop (A, B), not PROP (A) = B.
4631
17dd3097
EZ
46322013-06-10 Eli Zaretskii <eliz@gnu.org>
4633
4634 * xdisp.c (get_it_property): Use it->window instead of generating
4635 a Lisp object from it->w.
4636
52fab9c9
EZ
46372013-06-09 Eli Zaretskii <eliz@gnu.org>
4638
4639 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4640 get-char-property the window that is being rendered, instead of
4641 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4642 (compute_display_string_pos): When W is NULL, use the current
4643 buffer as the object to pass to get-char-property.
4644 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4645 pointer member of the bidi iterator, since no window is pertinent
4646 to this function.
52fab9c9 4647
5bf97bfc
EZ
46482013-06-08 Eli Zaretskii <eliz@gnu.org>
4649
4650 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4651 being displayed, and pass it to compute_display_string_pos.
4652 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4653 (bidi_paragraph_init): All callers changed.
4654
4655 * xdisp.c (init_from_display_pos, init_iterator)
4656 (handle_single_display_spec, next_overlay_string)
4657 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4658 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4659 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4660 (compute_display_string_pos): Accept additional argument, the
4661 window being displayed, and pass it to Fget_char_property.
4662 (Bug#14575)
4663
4664 * dispextern.h (struct bidi_it): New member w, the window being
4665 displayed.
4666 (compute_display_string_pos): Adjust prototype.
4667
5de0e011
JD
46682013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4669
e7b41c4c 4670 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4671
4672 * process.c (wait_reading_process_output): Check for NS before GLIB.
4673 GLIB may be linked in due to rsvg, but ns_select must be called.
4674
5de0e011
JD
4675 * xgselect.c (xg_select): Remove call to window_system_available
4676 and g_main_context_pending at the top, so Gdk events (i.e. file
4677 notify) are processed when Emacs is started with -nw.
4678
a822acff
EZ
46792013-06-07 Eli Zaretskii <eliz@gnu.org>
4680
4681 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4682 (ctagsfiles3): New variable, includes only *.m files.
4683 (TAGS): Use an explicit language name in the regular expressions,
4684 to avoid transformation of '/SOMETHING' by MSYS to
4685 'c:\MSYS\SOMETHING'.
4686
6c0a9ed1
RC
46872013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4688
4689 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4690
9ef6111b
EZ
46912013-06-06 Eli Zaretskii <eliz@gnu.org>
4692
4693 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4694 still need to set the mouse pointer shape and activate help-echo.
4695 (Bug#14558)
4696
7d300d64
PE
46972013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4698
4699 A few porting etc. fixes for the new file monitor code.
4700 See the thread containing
4701 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4702 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4703 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4704 (dir_monitor_callback, Fgfile_rm_watch):
4705 Use assq_no_quit instead of Fassoc, for speed.
4706 (dir_monitor_callback, Fgfile_rm_watch):
4707 eassert that the monitor is a fixnum.
4708 (dir_monitor_callback): No need for CDR_SAFE.
4709 Simplify building of lisp with alternative tails.
4710 (Fgfile_add_watch, Fgfile_rm_watch):
4711 Do not assume glib functions set errno reliably on failure.
4712 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4713 and signal an error otherwise.
4714 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4715 Use Fdelq instead of Fdelete, for speed.
4716
817ebfcf
EZ
47172013-06-05 Eli Zaretskii <eliz@gnu.org>
4718
4719 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4720 don't insist on being invoked on a highlighted tool-bar button.
4721 Avoids losing tool-bar functionality when mouse-highlight is nil.
4722 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4723 Don't highlight when mouse-highlight is nil.
4724 (note_mouse_highlight): When mouse-highlight is nil, don't return
4725 right away; instead, run tool-bar and mode-line highlight
4726 subroutine, clear any existing highlight, and revert the mouse
4727 pointer to its default shape. (Bug#14558)
4728
55577e7c
SM
47292013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4730
4731 * lisp.mk (lisp): Add prog-mode.el.
4732
f019a684
PE
47332013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4734
4735 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4736 * process.c (dummy_handler): New function.
4737 (lib_child_handler): New static var.
4738 (handle_child_signal): Invoke it.
4739 (catch_child_signal): If a library has set up a signal handler,
4740 save it into lib_child_handler.
4741 (init_process_emacs): If using glib and not on Windows, tickle glib's
4742 child-handling code so that it initializes its private SIGCHLD handler.
4743 * syssignal.h (SA_SIGINFO): Default to 0.
4744 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4745 31; it should no longer be needed now.
4746
90db8702
MA
47472013-06-05 Michael Albinus <michael.albinus@gmx.de>
4748
4749 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4750
4751 * gfilenotify.c (globals_of_gfilenotify): New function.
4752 (syms_of_gfilenotify): Move global initialization there.
4753
4754 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4755
bfa3acd6
SM
47562013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4757
4758 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4759 * keyboard.c (menu_bar_items, tool_bar_items):
4760 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4761 not override local keymaps any more.
4762
ba59bd80
EZ
47632013-06-04 Eli Zaretskii <eliz@gnu.org>
4764
4765 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4766
7f203aa1
EZ
47672013-06-03 Eli Zaretskii <eliz@gnu.org>
4768
9337e206
EZ
4769 * w32console.c (initialize_w32_display): Return the dimensions of
4770 the console window via 2 additional arguments, not via the current
4771 frame. This avoids crashes due to overrunning the bounds of
4772 frame's decode_mode_spec_buffer, which is not resized following
4773 the change of the frame dimensions from the initial 10x10.
4774
4775 * w32term.h (w32_initialize_display_info): Adjust prototype.
4776
4777 * term.c (init_tty): Take dimensions of the frame from the values
4778 returned by initialize_w32_display.
4779
7f203aa1
EZ
4780 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4781 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4782 (LIBES): Add $(GFILENOTIFY_LIBS).
4783
4784 * w32inevt.c (handle_file_notifications): Add dummy implementation
4785 for !HAVE_W32NOTIFY.
4786
4787 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4788
55a87246
JD
47892013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4790
4791 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4792
4793 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4794
4795 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4796
3d5ee10a
PE
47972013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 Fix minor problems found by static checking.
4800 * data.c (pure_write_error):
4801 Use xsignal2, not Fsignal, as Fsignal might return.
4802 * eval.c (set_backtrace_debug_on_exit): Now static.
4803 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4804 No longer inline. EXTERN_INLINE is needed only for functions
4805 defined in .h files. Reindent function header as per GNU style.
4806 (backtrace_p, backtrace_top, backtrace_next):
4807 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4808 compiler or linker. Add extern decls to pacify gcc -Wall.
4809 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4810 Now static.
4811 * frame.c (free_monitors): Define only on platforms that need it.
4812 * nsterm.m (ns_term_init):
4813 * process.c (catch_child_signal):
4814 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4815 defined on all porting targets these days.
4816 * process.c, process.h (catch_child_signal):
4817 Make it extern only if NS_IMPL_GNUSTEP is defined.
4818
e2d8a6f0
EZ
48192013-06-03 Eli Zaretskii <eliz@gnu.org>
4820
4821 * w32.c (gettimeofday): Make the signature identical to prototype
4822 in nt/inc/sys/time.h.
4823
a8a7c5f6
SM
48242013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4825
4826 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4827 .gdbinit.
4828
4829 * keyboard.c (safe_run_hooks_error): Improve error message.
4830
4831 * data.c (pure_write_error): Add `object' argument.
4832 * puresize.h (CHECK_IMPURE): Use it.
4833
c9628c79
MA
48342013-06-03 Michael Albinus <michael.albinus@gmx.de>
4835
4836 * Makefile.in (NOTIFY_OBJ): New variable.
4837 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4838
4839 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4840 Call syms_of_gfilenotify.
4841
4842 * gfilenotify.c: New file.
4843
4844 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4845 and Qfile_w32notify.
4846 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4847 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4848
4849 * lisp.h: Declare syms_of_gfilenotify.
4850
4851 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4852
2f592f95
SM
48532013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4854
4855 Merge the specpdl and backtrace stacks. Make the structure of the
4856 specpdl entries more obvious via a tagged union of structs.
4857 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4858 (enum specbind_tag): New enum.
4859 (struct specbinding): Make it a tagged union of structs.
4860 Add a case for backtrace records.
4861 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4862 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4863 (backtrace_debug_on_exit): New accessors.
4864 (struct backtrace): Remove.
4865 (struct catchtag): Remove backlist field.
4866 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4867 Move to eval.c.
4868 (Flocal_variable_p): Speed up the common case where the binding is
4869 already loaded.
4870 * eval.c (backtrace_list): Remove.
4871 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4872 (set_backtrace_args, set_backtrace_nargs)
4873 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4874 (backtrace_next): New functions.
4875 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4876 (unwind_to_catch, internal_lisp_condition_case)
4877 (internal_condition_case, internal_condition_case_1)
4878 (internal_condition_case_2, internal_condition_case_n): Don't bother
4879 with backtrace_list any more.
4880 (Fsignal): Adjust to new backtrace format.
4881 (grow_specpdl): Move up.
4882 (record_in_backtrace): New function.
4883 (eval_sub, Ffuncall): Use it.
4884 (apply_lambda): Adjust to new backtrace format.
4885 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4886 data.c.
4887 (specbind): Adjust to new specpdl format. Simplify.
4888 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4889 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4890 backtrace format.
4891 (mark_backtrace): Remove.
4892 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4893 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4894 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4895 Use mark_specpdl.
4896 * profiler.c (record_backtrace): Use get_backtrace.
4897 (handle_profiler_signal): Use backtrace_top_function.
4898 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4899 accessor functions.
4900
c0342369
JD
49012013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4902
4903 * process.h (catch_child_signal): Declare.
4904
4905 * process.c (catch_child_signal): New function.
4906 (init_process_emacs): Call it.
4907
4908 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4909 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4910 NS_IMPL_COCOA.
4911 (x_set_cursor_type): Remove declaration.
4912 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4913 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4914 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4915 (ns_get_color): Use F suffix on float.
4916 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4917 (ns_get_rgb_color): Remove.
4918 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4919 (note_mouse_movement): x and y are CGFloat.
4920 (ns_draw_fringe_bitmap): Remove unused rowY.
4921 Change #if to COCOA && >= 10_6.
4922 (ns_draw_window_cursor): Remove unused overspill.
4923 (ns_draw_underwave): width and x are EamcsCGFloat.
4924 (ns_draw_box): thickness is CGFloat.
4925 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4926 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4927 if not in main thread.
4928 (ns_get_pending_menu_title, ns_check_menu_open)
4929 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4930 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4931 (sendFromMainThread:): New method.
4932 (changeFont:): size is CGFloat.
4933 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4934 Disable warning about permanent text.
4935 (characterIndexForPoint:): Adjust return type depending on GNUStep
4936 version.
4937 (mouseDown:): delta is CGFloat.
4938 (updateFrameSize): Remove unised variable f.
4939 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4940 Cast float to EmacsCGFloat.
4941 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4942 also to -1 when restoring.
4943 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4944 inside NS_IMPL_COCOA.
4945 (toggleFullScreen:): Put call to toggleFullScreen inside
4946 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4947 (setPosition:portion:whole:): por is CGFloat.
4948 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4949 (mouseDown:): Use CGFloat.
4950 (mouseDragged:): Remove unised variable edge.
4951 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4952
4953 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4954 of CGFloat differs.
4955 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4956 when NS_IMPL_GNUSTEP.
4957 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4958 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4959 (EmacsToolbar): Add clearAll. Add tag argument to
4960 addDisplayItemWithImage.
4961 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4962
4963 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4964
4965 * nsmenu.m (ns_update_menubar): Make static.
4966 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4967 (fillWithWidgetValue:): Add cast to SEL for setAction.
4968 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4969 (update_frame_tool_bar): Update code for GNUStep.
4970 (clearAll): New method.
4971 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4972 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4973 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4974 call to insertItemWithItemIdentifier.
4975 (validateVisibleItems): Fix indentation.
4976 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4977 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4978 UtilityWindow to aStyle, remove call to setStyleMask.
4979
4980 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4981
4982 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4983 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4984 Use F suffix on floats.
4985 (ns_char_width): Returns CGFloat.
4986 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4987 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4988 DPSxshow.
4989 (ns_glyph_metrics): CGFloat instead of float.
4990
a0eb10b3
JB
4991 * nsfns.m (x_set_foreground_color, x_set_background_color):
4992 Use EmacsCGFloat.
4993 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4994 remove unused variables.
4995 (Fns_read_file_name): Keep track if panel is for save.
4996 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4997 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4998 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4999 Just return the input if GNUStep.
c0342369
JD
5000 (x_screen_planes): Remove.
5001 (Fxw_color_values): Use EmacsCGFloat
5002 (Fns_display_monitor_attributes_list): Only get screen number for
5003 Cocoa.
ef099a94 5004 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
5005 EmacsSavePanel.
5006 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
5007 ns_directory_from_panel.
5008
da9aff11
PE
50092013-06-01 Paul Eggert <eggert@cs.ucla.edu>
5010
5011 * process.c (handle_child_signal): Also use WCONTINUED.
5012 This is so that list-processes doesn't mistakenly list the process
5013 as stopped, when the process has actually been continued and is
5014 now running.
5015
0e64479a
PE
50162013-05-31 Paul Eggert <eggert@cs.ucla.edu>
5017
fc186a96
PE
5018 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
5019 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
5020 not already configured.
5021
0e64479a
PE
5022 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
5023
38b787fa
EZ
50242013-05-29 Eli Zaretskii <eliz@gnu.org>
5025
5026 * Makefile.in (mostlyclean): Remove *.res files.
5027
22513e52
SM
50282013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
5029
5030 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
5031 a buffer (bug#8447).
5032
6ef3db10
EZ
50332013-05-27 Eli Zaretskii <eliz@gnu.org>
5034
5035 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
5036 display vector, and we backtrack, handle the case that the
5037 previous character position is also displayed from a display
5038 vector or covered by a display string or image. (Bug#14476)
5039
6799bb26
JD
50402013-05-25 Jan Djärv <jan.h.d@swipnet.se>
5041
5042 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
5043 (struct MonitorInfo, free_monitors): Remove.
5044 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
5045 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
5046 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5047 Qframes, Qsource.
5048
5049 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
5050 (struct MonitorInfo, free_monitors): Remove.
5051 (ns_screen_name): Make static.
5052 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
5053 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5054 Qframes, Qsource.
5055
5056 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5057 (struct MonitorInfo): New struct.
5058 (free_monitors, make_monitor_attribute_list): Declare.
5059
22513e52
SM
5060 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
5061 New Lisp_Object:s.
6799bb26
JD
5062 (free_monitors, make_monitor_attribute_list): New functions.
5063 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
5064 Qsource.
5065
38cd43eb
XF
50662013-05-25 Xue Fuqiao <xfq.free@gmail.com>
5067
5068 * callproc.c (call_process): Refine the doc string. (Bug#14045)
5069
2af0948d
SM
50702013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
5071
a7eb9b0f
SM
5072 * keyboard.c: Apply keyboard decoding only to events that come directly
5073 from the tty, not from unread-command-events (bug#14368).
5074 (read_event_from_main_queue): New function, extracted from read_char).
5075 (read_decoded_char): Remove.
5076 (read_decoded_event_from_main_queue): New function to replace it.
5077 (read_char): Use it.
5078 (read_key_sequence): Use read_char rather than read_decoded_char.
5079
2af0948d
SM
5080 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
5081
1413e9a5
BR
50822013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
5083
5084 * casetab.c (init_casetab_once): Fix last change (bug#14424).
5085
e6d2f155
KH
50862013-05-22 Kenichi Handa <handa@gnu.org>
5087
5088 The following changes are to fix the setting of
5089 buffer-file-coding-system on, for instance, C-x RET c unix RET
5090 _FILE_OF_DOS_EOL_TYPE_ RET.
5091
5092 * coding.h (struct coding_system): New member detected_utf8_chars.
5093
5094 * coding.c (detect_coding_utf_8): Count characters and check EOL
5095 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
5096 BOM is there.
5097 (setup_coding_system): Do not initialize coding->head_ascii.
5098 (check_ascii): Do not set coding->eol_seen but update it. Do not
5099 call adjust_coding_eol_type here.
1413e9a5
BR
5100 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
5101 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
5102 of the found coding-system.
5103 (decode_coding_gap): Cancel previous change. Utilize the
5104 character numbers counted by detect_coding_utf_8. Fix detection
5105 of BOM for utf-8.
5106
ab56a6f4 51072013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
5108
5109 * search.c (looking_at_1): Only set last_thing_searched if the match
5110 changed the match-data (bug#14281).
5111
ecc3c6ed
DA
51122013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
5113
5114 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 5115 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
5116 (move_it_vertically_backward): Likewise.
5117
5ba8bf35
YM
51182013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5119
5120 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 5121 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
5122 (Fx_display_mm_width, Fx_display_mm_height):
5123 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 5124
91e8418b 5125 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 5126 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
5127 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
5128 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
5129 (Fx_display_backing_store, Fx_display_visual_class)
5130 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
5131 (Fx_display_grayscale_p, Fx_display_pixel_width)
5132 (Fx_display_pixel_height, Fx_display_planes)
5133 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
5134 (Fx_display_screens): Don't confuse X11 screens with NS screens.
5135 (Fx_display_mm_width, Fx_display_mm_height)
5136 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
5137 height for all physical monitors as in X11.
5138
fc30d803
SM
5139 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
5140 Return pixel width or height for all physical monitors as in X11.
91e8418b 5141
31ff141c
PE
51422013-05-18 Paul Eggert <eggert@cs.ucla.edu>
5143
5144 Port --enable-gcc-warnings to clang.
5145 * bytecode.c (exec_byte_code):
5146 * regex.c:
5147 Redo diagnostic pragmas to pacify clang, too.
5148 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
5149 * editfns.c (Fencode_time):
5150 * fileio.c (file_accessible_directory_p):
5151 * font.c (font_unparse_xlfd):
5152 Use '&"string"[index]' instead of '"string" + (index)'.
5153 * undo.c (user_error): Remove; unused.
5154
df065a0b
EZ
51552013-05-16 Eli Zaretskii <eliz@gnu.org>
5156
04d360e7
EZ
5157 * insdel.c (insert_1_both): Document the arguments, instead of
5158 referring to insert_1, which no longer exists.
5159
5bb98290
EZ
5160 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
5161 some window, increment windows_or_buffers_changed, so that
5162 *Messages* display in that window is updated. (Bug#14408)
5163
df065a0b
EZ
5164 * w32.c: Include epaths.h.
5165 (init_environment): Use cmdproxy.exe without leading directories.
5166 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
5167 case.
5168 (gettimeofday): Adjust signature and return value to Posix
5169 expectations.
5170
5171 * unexw32.c (open_output_file): Delete the existing emacs.exe
5172 before creating it, to break the hard link to the versioned
5173 executable.
5174
5175 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
5176 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
5177 (FIRSTFILE_OBJ): New variables.
5178 (W32_RES): Rename to EMACSRES. All users changed.
5179 (base_obj): Use $(CM_OBJ).
5180 (ALLOBJS): Use $(FIRSTFILE_OBJ).
5181 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
5182 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
5183 $(W32_RES_LINK) before $(LIBES).
5184 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
5185
1aa8d505
SM
51862013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5187
6e911150
SM
5188 * makefile.w32-in (DOC): Use just "DOC".
5189
5190 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
5191
1aa8d505
SM
5192 * process.c: Export default filters and sentinels to Elisp.
5193 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
5194 New constants.
5195 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
5196 (Fset_process_sentinel, Fformat_network_address):
5197 Default to them instead of nil.
5198 (server_accept_connection): Sentinels can't be nil any more.
5199 (read_and_dispose_of_process_output): New function, extracted from
5200 read_process_output.
5201 (read_process_output): Use it; filters can't be nil.
5202 (Finternal_default_process_filter): New function, extracted from
5203 read_process_output.
5204 (exec_sentinel_unwind): Remove function.
5205 (exec_sentinel): Don't zilch sentinel while running.
5206 (status_notify): Sentinels can't be nil.
5207 (Finternal_default_process_sentinel): New function extracted from
5208 status_notify.
5209 (setup_process_coding_systems): Default filter is not nil any more.
5210 (syms_of_process): Export new Elisp functions and initialize
5211 new constants.
5212 * lisp.h (make_lisp_proc): New function.
5213
5ac2eb34
SM
52142013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5215
5216 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
5217
eda9c7d7
EZ
52182013-05-14 Eli Zaretskii <eliz@gnu.org>
5219
5220 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
5221 unless we know that the window w is a leaf window.
5222 Another attempt at solving bug#14062.
eda9c7d7 5223
8fdeaad5
JD
52242013-05-14 Jan Djärv <jan.h.d@swipnet.se>
5225
5226 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
5227 fdesc (Bug#14375).
5228
44aa9ee6
PE
52292013-05-12 Paul Eggert <eggert@cs.ucla.edu>
5230
5231 * image.c (gif_load): Check that subimages fit (Bug#14345).
5232
759fd763
SM
52332013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
5234
5235 * lread.c (skip_dyn_eof): New function.
5236 (read1): Use it to skip the end of a file in response to #@00.
5237
5238 * doc.c (get_doc_string): Slightly relax the sanity checking.
5239
4465bfb4
JD
52402013-05-09 Jan Djärv <jan.h.d@swipnet.se>
5241
5242 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
5243 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5244 (MonitorInfo): New struct.
5245 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
5246 (Fns_display_monitor_attributes_list): New functions.
5247 (display-usable-bounds): Remove.
5248 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
5249 Qsource.
5250
7583e2a0
PE
52512013-05-09 Paul Eggert <eggert@cs.ucla.edu>
5252
5253 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
5254 (GTK_CHECK_VERSION): New macro, if not already defined.
5255 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
5256 replaced by GTK_CHECK_VERSION.
5257
ad75d77e
PE
52582013-05-08 Paul Eggert <eggert@cs.ucla.edu>
5259
5260 * xterm.h (GTK_PREREQ): New macro.
5261 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
5262 to use this macro instead, for consistency and clarity.
5263
07525f77
EZ
52642013-05-08 Eli Zaretskii <eliz@gnu.org>
5265
5266 * xdisp.c (row_for_charpos_p): New function, with code of
5267 cursor_row_p, but accepts an additional argument CHARPOS instead
5268 of using a hardcoded PT.
5269 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
5270 (row_containing_pos): Call row_for_charpos_p instead of partially
5271 doing the same. Fixes cursor positioning under longlines-mode
5272 when longlines-show-effect includes more than one newline, when
5273 moving the cursor vertically up.
5274
d901fc8d
JB
52752013-05-08 Juanma Barranquero <lekktu@gmail.com>
5276
5277 * makefile.w32-in (ACL_H): New macro.
5278 ($(BLD)/fileio.$(O)): Update dependencies.
5279
f269bc61
PE
52802013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5281
e7b41c4c 5282 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
5283 * Makefile.in (LIB_ACL): New macro.
5284 (LIBACL_LIBS): Remove.
5285 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
5286 * fileio.c: Include <acl.h>.
5287 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
5288 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
5289 !acl_errno_valid.
5290 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
5291 it ourselves.
5292
f269bc61
PE
5293 * unexelf.c: Don't assume ElfW (Half) fits in int.
5294 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
5295 when dealing with ElfW (Half) values, since they can exceed 2**31
5296 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
5297 (entry_address): Omit unused NUM arg. All uses changed.
5298
a261c53e
JL
52992013-05-07 Juri Linkov <juri@jurta.org>
5300
5301 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
5302 to the string converted from number with `Fnumber_to_string'.
5303 (Bug#14254)
5304
2b66427d
PE
53052013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5306
5307 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
5308 This fixes a problem introduced by my previous change.
5309
15acfe41
GM
53102013-05-07 Glenn Morris <rgm@gnu.org>
5311
5312 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
5313
5ea03bf5
JD
53142013-05-07 Jan Djärv <jan.h.d@swipnet.se>
5315
5316 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
5317
e0c9d565
PE
53182013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5319
5320 Static checking by GCC 4.8.0.
5321 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
5322 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
5323 (x_get_monitor_attributes_fallback)
5324 (x_get_monitor_attributes_xinerama)
5325 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
5326 Define only if USE_GTK.
5327 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
5328 (x_get_monitor_attributes_fallback): Omit unused locals.
5329 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
5330 Use double, not float, to avoid mixed-mode floating point arithmetic.
5331
4e3f9230
YM
53322013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5333 Jan Djärv <jan.h.d@swipnet.se>
5334
5335 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
5336 (XINERAMA_CFLAGS): New macros.
5337 (ALL_CFLAGS, LIBES): Use them.
5338
5339 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
5340 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
5341 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
5342 (syms_of_xfns): DEFSYM them.
5343 (struct MonitorInfo): New struct.
5344 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
5345 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
5346 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
5347 (x_get_monitor_attributes_xinerama): New functions.
5348 (Fx_display_monitor_attributes_list): New primitive.
5349 (syms_of_xfns): Defsubr it.
5350
5351 * xterm.h (x_display_info): Add Xatom_net_workarea and
5352 Xatom_net_current_desktop.
5353
5354 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5355 and dpyinfo->Xatom_net_current_desktop.
5356
05839b6a
EZ
53572013-05-06 Eli Zaretskii <eliz@gnu.org>
5358
5359 * xdisp.c (pos_visible_p): Use the special code for finding the
5360 beginning of a display property or overlay for any "replacing"
5361 display property, not just for display strings. This solves
5362 incorrect reporting of position by posn-at-point. (Bug#14241)
5363
dc4a2ee0
PE
53642013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5365
5ee94506
PE
5366 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5367 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5368 Verify that ElfW (Half) fits in int.
5369 (fatal): Use same signature as lisp.h.
5370 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5371 configure and build with -DUNEXELF_DEBUG without worrying about
5372 other modules that use DEBUG.
5373 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5374 possibly-wide integers now uses it instead of plain fprintf.
5375 (entry_address): New function, which avoids problems with 32-bit
5376 overflow on 64-bit hosts.
5377 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5378 (round_up): Don't assume the remainder fits in int.
5379 (find_section): Use bool for boolean. Simplify debug code.
5380 (unexec): Don't assume file sizes fit in int or size_t.
5381 Omit unnecessary trailing newline in 'fatal' format.
5382 Use strerror rather than outputting decimal error number.
5383 Remove unused code when emacs is not defined;
5384 this file relies on Emacs now.
5385 Don't assume e_phnum and e_shnum are positive.
5386
dc4a2ee0
PE
5387 * regex.c: Fix problems when DEBUG is defined.
5388 (extract_number, extract_number_and_incr): Define regardless of
5389 whether DEBUG is defined; that's simpler and makes the code less
5390 likely to go stale in the normal case when DEBUG is not defined.
5391 Return int rather than taking an int * arg. All callers changed.
5392 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5393 Remove, replacing with ...
5394 (DEBUG_PRINT): New macro. All callers changed.
5395 (DEBUG_COMPILES_ARGUMENTS): New macro.
5396 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5397 (print_compiled_pattern, print_double_string) [DEBUG]:
5398 Use prototype rather than old-style definition.
5399 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5400 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5401 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5402 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5403 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5404 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5405 This matters only when DEBUG is defined.
5406
14c7ed05
EZ
54072013-05-05 Eli Zaretskii <eliz@gnu.org>
5408
5409 * xdisp.c (set_iterator_to_next): Set the
5410 ignore_overlay_strings_at_pos_p flag only if we are _really_
5411 iterating over an overlay string, as indicated by the
5412 current.overlay_string_index member. (Bug#14306)
5413
e6076b1b
JD
54142013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5415
5416 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5417 to where it is used, to avoid autorelease issues (Bug#14050).
5418
cbee2131
PE
54192013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5420
5421 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5422 * fileio.c (syms_of_fileio): Implement this.
5423 * filelock.c (create_lock_file): If symbolic links don't work, so
5424 we use a regular file as a lock file, do not fsync the lock file;
5425 it's not needed.
5426
30c7e542
SM
54272013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5428
5429 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5430 (syms_of_minibuf): Adjust accodingly.
5431 * lread.c (Fread):
5432 * callint.c (Fcall_interactively): Adjust calls accordingly.
5433
5bebd186
EZ
54342013-05-04 Eli Zaretskii <eliz@gnu.org>
5435
5436 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5437 w->contents is a buffer before computing everything else.
5438 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5439
5440 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5441 assertion violations. (Bug#14062)
5442
0fb0a4f3
DR
54432013-05-01 David Reitter <david.reitter@gmail.com>
5444
5445 * nsfns.m (ns_tooltip): Initialize.
5446
9e63b4a5
EZ
54472013-04-28 Eli Zaretskii <eliz@gnu.org>
5448
5449 * coding.c (decode_coding_gap): Don't remove the character before
5450 a newline unless it's a CR character. (Bug#14287)
5451
ad60824e
DN
54522013-04-28 Dan Nicolaescu <dann@gnu.org>
5453
5454 * dispextern.h (struct face): Move enum face_underline_type
5455 earlier so that bitfields can be in the same word.
5456
edbdcec0
JD
54572013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5458
5459 * nsfns.m (handlePanelKeys): New function.
5460 (EmacsOpenPanel:performKeyEquivalent:)
5461 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5462 arrows/function/control and copy/paste keys (Bug#14296).
5463
0208ede7
JL
54642013-04-27 Juri Linkov <juri@jurta.org>
5465
5466 * callint.c (Fcall_interactively): Call `Qread_number' for
5467 interactive code letter `n' instead of using duplicate code.
5468 (Bug#14254)
5469
b8dd59f7
PE
54702013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5471
5472 * systime.h (make_timeval): Declare as 'const'.
5473
8bd722db
KH
54742013-04-27 Kenichi Handa <handa@gnu.org>
5475
5476 * font.c (font_open_entity): Always open a font of manageable
5477 size.
5478
13d0e56f 54792013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5480
f780d632
PE
5481 Port better to AIX (Bug#14258).
5482 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5483 to pacify AIX xlc.
5484
ec509856
KH
54852013-04-24 Kenichi Handa <handa@gnu.org>
5486
5487 * coding.c (decode_coding_iso_2022): When an invalid escape
5488 sequence is encountered, reset the invocation and designation
5489 status to the safest one.
5490
84fc48e5
PE
54912013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5492
5493 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5494 Without this fix, "make distclean" leaves stamp-h1 behind.
5495
806bda47
EC
54962013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5497
5498 * w32fns.c (w32_fullscreen_rect): New function to compute the
5499 window rectangle for the given fullscreen mode.
5500 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5501 longer tunes the window size. This keeps the window's edges flush
5502 with the screen and allows the taskbar to hide itself in fullboth.
5503
5504 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5505 window decorations and uses the entire screen.
5506
5507 * w32term.h (w32_fullscreen_rect) Add prototype.
5508 (struct w32_output): Replace normal_width, normal_height,
5509 normal_top, and normal_left members with a single normal_placement
5510 struct.
5511 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5512 Remove macros.
5513 (FRAME_NORMAL_PLACEMENT): New macro.
5514
9cc2810b
JB
55152013-04-16 Juanma Barranquero <lekktu@gmail.com>
5516
5517 * minibuf.c (Ftest_completion): Silence compiler warning.
5518
fd16b54c
EZ
55192013-04-15 Eli Zaretskii <eliz@gnu.org>
5520
5521 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5522 bug#14062.
fd16b54c
EZ
5523
5524 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5525 parentheses.
5526
5527 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5528 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5529 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5530 parentheses where appropriate.
5531
9e3379a0
PE
55322013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5533
5534 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5535
ddd6b685
EZ
55362013-04-14 Eli Zaretskii <eliz@gnu.org>
5537
5538 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5539 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5540 Mention in the doc string that setting these variables takes
5541 effect only after a call to set-window-buffer. (Bug#14200)
5542
29b79ba1
EZ
55432013-04-13 Eli Zaretskii <eliz@gnu.org>
5544
5545 * indent.c (Fvertical_motion): Don't consider display strings on
5546 overlay strings as display strings on the buffer position we
5547 started from. This prevents vertical cursor motion from jumping
5548 more than one line when there's an overlay string with a display
5549 property at end of line.
5550 Reported by Karl Chen <Karl.Chen@quarl.org> in
5551 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5552
562c6ee9
SM
55532013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5554
5555 * window.c (select_window): `record_buffer' even if window is
5556 already selected (bug#14191).
5557
fcc1fe85
EZ
55582013-04-11 Eli Zaretskii <eliz@gnu.org>
5559
5560 * window.c (Fwindow_end): Test more flags, including the buffer's
5561 last_overlay_modified flag, to determine whether the window's
5562 display is really up-to-date. Prevents the function from
5563 returning a stale value. (Bug#14170)
5564 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5565 current matrix.
5566
f009190a
EZ
55672013-04-10 Eli Zaretskii <eliz@gnu.org>
5568
5569 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5570 garbaged only if it is not already the top frame on its TTY.
5571 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5572 there are GUI frames open in the same session. (Bug#13864)
5573
78ce603d
SM
55742013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5575
5576 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5577 of marking the idle timers directly.
5578
a8036e40
SM
55792013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5580
5581 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5582 tables (bug#14054).
5583
7ffe7ef6
SM
55842013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5585
5586 * window.c (select_window): Don't record_buffer while the invariant is
5587 temporarily broken (bug#14161).
5588
5589 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5590
7d9f6883
EZ
55912013-04-07 Eli Zaretskii <eliz@gnu.org>
5592
5593 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5594
5406cfd9
RF
55952013-04-07 Romain Francoise <romain@orebokech.com>
5596
5597 Ignore additional platform-specific ACL errors (Bug#13702).
5598 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5599 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5600
95c0e83b
JD
56012013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5602
5603 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5604 f->output_data.ns.
5605
876da980
PE
56062013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5607
5608 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5609 This bug was introduced by my 2013-02-25 change that simplified
5610 data_start configuration. Without this change, on GNU/Linux
5611 an Emacs configured with --enable-profiling fails immediately
5612 due to a profiler signal.
5613 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5614 with these flags. On platforms where special flags are needed
5615 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5616 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5617 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5618
7452b7bd
DA
56192013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5620
5621 Get rid of some platform-specific functions examining window
5622 system and its capabilities. This is a partial rework of the
5623 2013-04-05 change.
5624 * lisp.h (have_menus_p): Remove prototype. This function is
5625 replaced with platform-independent window_system_available.
5626 (check_window_system): Move to...
5627 * frame.h (decode_window_system_frame, window_system_available):
5628 ...here, add new prototypes.
5629 * frame.c (window_system_available, decode_window_system_frame):
5630 New functions.
5631 (check_window_system): Platform-independent now.
5632 * xterm.h (x_in_use): Remove declaration.
5633 (check_x_frame):
5634 * w32term.h (check_x_frame):
5635 * nsterm.h (check_x_frame): Remove prototypes. This function
5636 is replaced with platform-independent decode_window_system_frame.
5637 * msdos.c (have_menus_p): Remove.
5638 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5639 Remove platform-specific functions. Use check_window_system,
5640 decode_window_system_frame and check_ns_display_info where
5641 appropriate. Minor style and comment tweaks.
5642 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5643 (check_x_frame): Likewise.
5644 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5645 Likewise.
5646 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5647 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5648 * xmenu.c, xselect.c: All related users changed.
5649
251e9147
KH
56502013-04-03 Kenichi Handa <handa@gnu.org>
5651
5652 The following changes is to optimize the code for reading UTF-8
5653 files.
5654
562c6ee9 5655 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5656 changed. Check EOL format. Do not call adjust_coding_eol_type
5657 here.
5658 (check_utf_8): New function.
5659 (adjust_coding_eol_type): Do nothing if already adjusted.
5660 (detect_coding): Compare the return value of check_ascii with
5661 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5662 (decode_coding_gap): Optimize for valid UTF-8.
5663
8bc369d4
KH
56642013-03-21 Kenichi Handa <handa@gnu.org>
5665
5666 * coding.c (syms_of_coding): Cancel previous change.
5667
5668 * insdel.c (insert_from_gap): Fix previous change.
5669
73931ad1
DA
56702013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5671
5672 Consistently use platform-specific function to detect window system.
5673 * lisp.h (check_window_system): New prototype. This function is
5674 going to replace check_x, check_w32 and check_ns.
5675 (have_menus_p): Mention msdos.c in comment.
5676 * fontset.c (check_window_system_func): Remove. Adjust all users.
5677 * fontset.h (check_window_system_func): Remove prototype.
5678 * nsterm.h (check_ns):
5679 * xterm.h (check_x):
5680 * w32term.h (check_w32): Likewise.
5681 * menu.c (Fx_popup_menu): Use check_window_system.
5682 * msdos.c (check_window_system): Define for MS-DOS.
5683 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5684 * w32fns.c (check_window_system): Likewise for MS-Windows.
5685 * xfns.c (check_window_system): Likewise for X.
5686 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5687 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5688
7216e43b
PE
56892013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5690
5691 Prefer < to > in range checks such as 0 <= i && i < N.
5692 This makes it easier to visualize quantities on a number line.
5693 This patch doesn't apply to all such range checks,
5694 only to the range checks affected by the 2013-03-24 change.
5695 This patch reverts most of the 2013-03-24 change.
5696 * alloc.c (xpalloc, Fgarbage_collect):
5697 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5698 * character.c (string_escape_byte8):
5699 * charset.c (read_hex):
5700 * data.c (cons_to_unsigned):
5701 * dispnew.c (update_frame_1):
5702 * doc.c (Fsubstitute_command_keys):
5703 * doprnt.c (doprnt):
5704 * editfns.c (hi_time, decode_time_components):
5705 * fileio.c (file_offset):
5706 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5707 * font.c (font_intern_prop):
5708 * frame.c (x_set_alpha):
5709 * gtkutil.c (get_utf8_string):
5710 * indent.c (check_display_width):
5711 * keymap.c (Fkey_description):
5712 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5713 * lread.c (read1):
5714 * minibuf.c (read_minibuf_noninteractive):
5715 * process.c (wait_reading_process_output):
5716 * search.c (Freplace_match):
5717 * window.c (get_phys_cursor_glyph):
5718 * xdisp.c (redisplay_internal):
5719 * xsmfns.c (smc_save_yourself_CB):
5720 Prefer < to > for range checks.
5721 * dispnew.c (sit_for): Don't mishandle NaNs.
5722 This fixes a bug introduced in the 2013-03-24 change.
5723 * editfns.c (decode_time_components): Don't hoist comparison.
5724 This fixes another bug introduced in the 2013-03-24 change.
5725
92759988
DA
57262013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5727
5728 * frame.h (struct frame): Drop scroll_bottom_vpos
5729 member becaue all real users are dead long ago.
5730 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5731 * xdisp.c (redisplay_internal): Adjust user.
5732
9a1971bb
GM
57332013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5734
f38ab167
JD
5735 * nsmenu.m (showAtX:Y:for:): setLevel to
5736 NSPopUpMenuWindowLevel (Bug#13998).
5737
6d01f1fe
JD
57382013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5739
5740 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5741 (ns_check_pending_open_menu): Declare.
5742
5743 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5744 (x_activate_menubar): Update the menu with title that matches
5745 ns_get_pending_menu_title, and call
5746 ns_check_pending_openmenu (Bug#12698).
5747 (menuWillOpen:): New method.
5748 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5749
5750 * nsterm.m (menu_will_open_state, menu_mouse_point)
5751 (menu_pending_title): New varaibles.
5752 (ns_get_pending_menu_title, ns_check_menu_open)
5753 (ns_check_pending_open_menu): New functions.
5754
781f4782
DA
57552013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5756
5757 * indent.c (current_column_bol_cache): Remove leftover which is not
5758 used in Fmove_to_column any more.
5759 (current_column, scan_for_column): Adjust users.
5760 * keyboard.c (last_point_position_buffer, last_point_position_window):
5761 Remove leftovers which are not used for recording undo any more.
5762 (command_loop_1, syms_of_keyboard): Adjust users.
5763 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5764 redisplay_window any more.
5765 (move_it_to): Adjust user.
5766
1921c31b
JB
57672013-03-29 Juanma Barranquero <lekktu@gmail.com>
5768
5769 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5770 Update dependencies.
5771
717b8bcd
SM
57722013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5773
5774 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5775 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5776 forward references.
5777
e74aeda8
DA
57782013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5779
5780 * window.h (struct window): Replace hchild, vchild and buffer slots
5781 with the only contents slot. This is possible because each valid
5782 window may have either the child window (in vertical or horizontal
5783 combination) or buffer to display (for the leaf window). Using that,
5784 a lof of operations to traverse and/or change window hierarchies may
5785 be simplified. New member horizontal is used to distinguish between
5786 horizontal and vertical combinations of internal windows.
5787 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5788 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5789 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5790 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5791 Use contents slot, not buffer, where appropriate.
5792 (wset_combination): New function.
5793 (wset_buffer): Add eassert.
5794 (Fframe_first_window): Simplify the loop reaching first window.
5795 (Fwindow_buffer): Use WINDOW_LEAF_P.
5796 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5797 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5798 (unshow_buffer): Convert initial debugging check to eassert.
5799 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5800 (make_parent_window, window_resize_check, window_resize_apply)
5801 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5802 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5803 Adjust to match struct window changes.
5804 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5805 (mark_window_cursors_off, count_windows, get_leaf_windows)
5806 (foreach_window_1): Simplify the loop.
5807 * alloc.c (mark_object): Do not check for the leaf window because
5808 internal windows has no glyph matrices anyway.
5809 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5810 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5811 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5812 (build_frame_matrix_from_window_tree, mirror_make_current)
5813 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5814 (update_window_tree, set_window_update_flags): Simplify the loop.
5815 (sync_window_with_frame_matrix_rows): Enforce live window.
5816 Use contents slot, not buffer, where appropriate.
5817 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5818 and WINDOW_HORIZONTAL_COMBINATION_P.
5819 (make_frame_visible_1): Simplify the loop.
5820 Use contents slot, not buffer, where appropriate.
5821 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5822 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5823 (expose_window_tree): Likewise.
5824 Use contents slot, not buffer, where appropriate.
5825 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5826 to avoid deleted windows. Use contents slot instead of buffer.
5827 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5828 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5829 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5830 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5831
121ab1cd
EZ
58322013-03-28 Eli Zaretskii <eliz@gnu.org>
5833
ef454cf7
EZ
5834 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5835 identify the reasons for assertion violations in bug#14062 and
5836 similar ones.
21e930f8
EZ
5837 (Fx_show_tip): Fix compilation error under
5838 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5839
121ab1cd
EZ
5840 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5841 Reported by <rzl24ozi@gmail.com>.
5842
5c89ca24
DA
58432013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5844
5845 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5846 start marker...
562c6ee9
SM
5847 (unwind_with_echo_area_buffer): ...to restore it here.
5848 This is needed to ensure that...
5c89ca24
DA
5849 (redisplay_window): ...both window markers are valid here,
5850 which is verified by eassert.
5851 * editfns.c (save_excursion_save): Do not assume that
5852 selected_window always displays the buffer.
c7f53895
DA
5853 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5854 Fix comment.
5c89ca24 5855
f557c1b1
SM
58562013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5857
5858 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5859 the upcase table.
5860
40693bba 58612013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5862
5863 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5864
c86f791f
EZ
58652013-03-27 Eli Zaretskii <eliz@gnu.org>
5866
5867 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5868 since MinGW's w32api headers do. This avoids compiler warnings.
5869
5870 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5871 if already defined.
5872
c6e72e17
EZ
58732013-03-26 Eli Zaretskii <eliz@gnu.org>
5874
5875 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5876
54e95010
JD
58772013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5878
5879 * gtkutil.c (style_changed_cb): Check if frame is live and an
5880 X frame (Bug#14038).
5881
b88b62de
EZ
58822013-03-26 Eli Zaretskii <eliz@gnu.org>
5883
a18d7de6
EZ
5884 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5885 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5886 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5887 MinGW64.
8f5e14c8
EZ
5888 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5889 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5890
b88b62de
EZ
5891 Fix incompatibilities between MinGW.org and MinGW64 headers.
5892 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5893
5894 * w32.c (REPARSE_DATA_BUFFER): Guard with
5895 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5896
c074e458
JD
58972013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5898
5899 * xterm.c: Include X11/XKBlib.h
5900 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5901
908589fd
AS
59022013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5903
5904 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5905 written backwards.
5906 * blockinput.h (input_blocked_p): Likewise.
5907 * bytecode.c (exec_byte_code): Likewise.
5908 * callproc.c (call_process_kill, call_process_cleanup)
5909 (Fcall_process): Likewise.
5910 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5911 (Fccl_execute_on_string): Likewise.
5912 * character.c (string_escape_byte8): Likewise.
5913 * charset.c (read_hex): Likewise.
5914 * cm.c (calccost): Likewise.
5915 * data.c (cons_to_unsigned): Likewise.
5916 * dired.c (directory_files_internal, file_name_completion):
5917 Likewise.
5918 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5919 (sit_for): Likewise.
5920 * doc.c (Fsubstitute_command_keys): Likewise.
5921 * doprnt.c (doprnt): Likewise.
5922 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5923 * emacsgtkfixed.c: Likewise.
5924 * fileio.c (file_offset, Fwrite_region): Likewise.
5925 * floatfns.c (Fexpt, fmod_float): Likewise.
5926 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5927 Likewise.
5928 * font.c (font_intern_prop): Likewise.
5929 * frame.c (x_set_alpha): Likewise.
5930 * gtkutil.c (get_utf8_string): Likewise.
5931 * indent.c (check_display_width): Likewise.
5932 * intervals.c (create_root_interval, rotate_right, rotate_left)
5933 (split_interval_right, split_interval_left)
5934 (adjust_intervals_for_insertion, delete_node)
5935 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5936 (merge_interval_right, merge_interval_left, copy_intervals)
5937 (set_intervals_multibyte_1): Likewise.
5938 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5939 * keymap.c (Fkey_description): Likewise.
5940 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5941 * lread.c (openp, read_integer, read1, string_to_number):
5942 Likewise.
5943 * menu.c (ensure_menu_items): Likewise.
5944 * minibuf.c (read_minibuf_noninteractive): Likewise.
5945 * print.c (printchar, strout): Likewise.
5946 * process.c (create_process, Faccept_process_output)
5947 (wait_reading_process_output, read_process_output, send_process)
5948 (wait_reading_process_output): Likewise.
5949 * profiler.c (make_log, handle_profiler_signal): Likewise.
5950 * regex.c (re_exec): Likewise.
5951 * regex.h: Likewise.
5952 * search.c (looking_at_1, Freplace_match): Likewise.
5953 * sysdep.c (get_child_status, procfs_ttyname)
5954 (procfs_get_total_memory): Likewise.
5955 * systime.h (EMACS_TIME_VALID_P): Likewise.
5956 * term.c (dissociate_if_controlling_tty): Likewise.
5957 * window.c (get_phys_cursor_glyph): Likewise.
5958 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5959 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5960 Likewise.
5961 * xfns.c (Fx_window_property): Likewise.
5962 * xmenu.c (set_frame_menubar): Likewise.
5963 * xselect.c (x_get_window_property, x_handle_dnd_message):
5964 Likewise.
5965 * xsmfns.c (smc_save_yourself_CB): Likewise.
5966 * xterm.c (x_scroll_bar_set_handle): Likewise.
5967
2bf7d27a
DA
59682013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5969
5970 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5971 to be optional or nil. Adjust comment and convert it to docstring.
5972 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5973 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5974
a9ebfa0b
PE
59752013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5976
5977 Static checking by GCC 4.8-20130319.
5978 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5979 * process.c (Fset_process_datagram_address)
5980 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5981 * xdisp.c (get_char_face_and_encoding):
5982 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5983 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5984 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5985
4f3576ee
KB
59862013-03-24 Ken Brown <kbrown@cornell.edu>
5987
789b5e9a
KB
5988 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5989 fix compilation on 64-bit Cygwin, where underscores are not
5990 automatically prepended.
5991
4f3576ee
KB
5992 * w32term.c (w32_initialize): Silence compiler warning.
5993
b5b7745f
EZ
59942013-03-23 Eli Zaretskii <eliz@gnu.org>
5995
cdc0d0bd
EZ
5996 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5997 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5998 variables, to save and restore frame dimensions.
5999 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
6000 after returning from a 'fullscreen' configuration.
6001 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
6002 to avoid races between the main thread and the input thread.
6003
6004 * w32term.h (struct w32_output): New members normal_width,
6005 normal_height, normal_top, normal_left, and prev_fsmode.
6006 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
6007 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
6008 members of a frame.
6009
b5b7745f
EZ
6010 * w32term.c (w32fullscreen_hook): Record last value of the frame's
6011 'fullscreen' parameter. Always record previous width and height
6012 of the frame, except when switching out of maximized modes, so
6013 that they could be restored correctly, instead of resetting to the
6014 default frame dimensions. Send SC_RESTORE command to the frame,
6015 unless we are going to send SC_MAXIMIZE, to restore the frame
6016 resize hints in the mouse pointer shown by the window manager.
6017 (Bug#14032)
6018
6019 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
6020
6021 * lisp.h (get_frame_param): Adjust conditions for prototype
6022 declaration.
6023
a3454eed
KB
60242013-03-22 Ken Brown <kbrown@cornell.edu>
6025
6026 * unexcw.c: Drop unneeded inclusion of w32common.h.
6027 (report_sheap_usage): Declare.
6028 (read_exe_header): Add magic numbers for x86_64.
6029 (fixup_executable): Fix printf format specifier for unsigned long
6030 argument.
6031
5a49b79c
DA
60322013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
6033
6034 * frame.h (struct frame): Put menu_bar_window under #ifdef
6035 because this member is not needed when X toolkit is in use.
6036 (fset_menu_bar_window):
6037 * dispnew.c (clear_current_matrices, clear_desired_matrices)
6038 (free_glyphs, update_frame):
6039 * xdisp.c (expose_frame): Likewise.
6040 (display_menu_bar): Likewise. Remove redundant eassert.
6041 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
6042 toolkit is in use.
6043
d6723bf7
PE
60442013-03-21 Paul Eggert <eggert@cs.ucla.edu>
6045
7b1123d8
PE
6046 Use functions and constants to manipulate Lisp_Save_Value objects.
6047 This replaces code that used macros and strings and token-pasting.
6048 The change makes the C source a bit easier to follow,
6049 and shrinks the Emacs executable a bit.
6050 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
6051 (make_save_value): Change 1st arg from string to enum. All callers
6052 changed.
6053 (INTX): Remove.
6054 (mark_object): Use if, not #if, for GC_MARK_STACK.
6055 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
6056 (XSAVE_OBJECT): Now functions, not macros.
6057 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
6058 the constant was never used.
6059 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
6060 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
6061 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
6062 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
6063 New constants.
6064 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
6065 type3 with a single member save_type. All uses changed.
6066 (save_type, set_save_pointer, set_save_integer): New functions.
6067 * print.c (PRINTX): Remove.
6068
d6723bf7
PE
6069 * alloc.c: Remove redundant static declarations.
6070
5f24fa51
DA
60712013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6072
6073 * window.h (struct window): Convert left_col, top_line, total_lines
6074 and total_cols from Lisp_Objects to integers. Adjust comments.
6075 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
6076 Remove.
6077 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
6078 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
6079 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
6080 Adjust users where appropriate.
6081
42143acd
DA
60822013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6083
6084 * frame.h (struct frame): Drop resx and resy because the same data is
6085 available from window system-specific output context. Adjust users.
562c6ee9
SM
6086 (default_pixels_per_inch_x, default_pixels_per_inch_y):
6087 New functions to provide defaults when no window system available.
42143acd 6088 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 6089 (NUMVAL): Move from xdisp.c.
42143acd
DA
6090 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
6091 (Ffont_face_attributes, Fopen_font):
6092 * image.c (gs_load):
6093 * w32font.c (fill_in_logfont):
6094 * xdisp.c (calc_pixel_width_or_height):
6095 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
6096 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
6097
c0a17406
KH
60982013-03-20 Kenichi Handa <handa@gnu.org>
6099
6100 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
6101 to 1 (temporary workaround until a bug related to ASCII
6102 optimization is fixed).
6103
095d384d
DA
61042013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
6105
6106 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
6107 Signal error if window is not internal. Adjust docstring.
6108 (delete_all_child_windows): Use combination_limit to save the buffer.
6109 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
6110 * print.c (syms_of_print): Initialize debugging output not here...
6111 (init_print_once): ...but in a new function here.
6112 * lisp.h (init_print_once): Add prototype.
6113 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 6114
748fa866
DA
61152013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
6116
6117 * window.c (window_resize_check, window_resize_apply)
6118 (window_from_coordinates, recombine_windows, set_window_buffer)
6119 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
6120 (Fsplit_window_internal, Fdelete_window_internal)
6121 (freeze_window_starts): Use bool for booleans.
6122 * window.h (window_frame_coordinates, resize_frame_windows)
6123 (freeze_window_starts, set_window_buffer): Adjust prototypes.
6124
81519fd2
SM
61252013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
6126
6127 * dispnew.c (bitch_at_user): Use `user-error'.
6128
6db423a9
KB
61292013-03-17 Ken Brown <kbrown@cornell.edu>
6130
6131 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
6132 as return type of image_background. (Bug#13981)
6133 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
6134
8f2906f5
JD
61352013-03-16 Jan Djärv <jan.h.d@swipnet.se>
6136
960ce480 6137 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 6138 (ns_select): Don't return with result uninitialized.
960ce480 6139
8f2906f5
JD
6140 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
6141 and getDirectory.
6142
81519fd2
SM
6143 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
6144 New functions.
8f2906f5
JD
6145 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
6146 directories. If filename is nil, get directory name (Bug#13932).
6147 Use getFilename and getDirectory.
6148 (getFilename, getDirectory): New methods for EmacsSavePanel and
6149 EmacsOpenPanel.
6150 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
6151
cded56c1
PE
61522013-03-15 Paul Eggert <eggert@cs.ucla.edu>
6153
6154 * coding.c (decode_coding_gap): Fix typo caught by static checking.
6155
251e9147 61562013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
6157
6158 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
6159 (adjust_after_replace): Make it back to static. Delete the third
6160 arg text_at_gap_tail. Cancel the code for handling it.
6161
6162 * coding.h (struct coding_system): New member eol_seen.
6163
6164 * coding.c (detect_ascii): New function.
6165 (detect_coding): Set coding->head_ascii and coding->eol_seen only
6166 when the source bytes are actually scanned. On detecting for
6167 coding_category_utf_8_auto, call detect_ascii instead of scanning
6168 source bytes directly.
6169 (produce_chars): Call insert_from_gap with the new arg 0.
6170 (encode_coding): Likewise.
6171 (decode_coding_gap): Control ASCII optimization by the variable
6172 disable_ascii_optimization instead of #ifndef .. #endif.
6173 Deccode EOL format according to coding->eol_seen.
6174 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
6175 variable.
6176
8a44e6d1
KH
6177 * lisp.h (adjust_after_replace): Cancel externing it.
6178 (insert_from_gap): Adjust prototype.
6179
5f795e34
EZ
61802013-03-15 Eli Zaretskii <eliz@gnu.org>
6181
6182 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
6183 FULLSCREEN_MAXIMIZED. (Bug#13935)
6184
f258b4be
DA
61852013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
6186
6187 * region-cache.c (find_cache_boundary, move_cache_gap)
6188 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
6189 Simplify debugging check and convert to eassert. Adjust comment.
6190 (pp_cache): Put under ENABLE_CHECKING.
6191
a5cc4dde
EZ
61922013-03-14 Eli Zaretskii <eliz@gnu.org>
6193
6194 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
6195 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
6196 and WM_ACTIVATEAPP.
6197 (w32fullscreen_hook): If the frame is visible, reset
6198 f->want_fullscreen flag after changing the frame size. If the
6199 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
6200 (Bug#13953)
6201
3fc5e44a
DC
62022013-03-13 Daniel Colascione <dancol@dancol.org>
6203
6204 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
6205 too so that these builds can use Cygwin's file conversion
6206 functions. (We've been building and linking cygw32.o all along
6207 and just not using it.)
6208
47d7532e
PE
62092013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6210
6211 File synchronization fixes (Bug#13944).
6212 * Makefile.in (LIB_FDATASYNC): New macro.
6213 (LIBES): Use it.
6214 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
6215 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
6216 Don't worry about HAVE_FSYNC, since a substitute fsync is
6217 available if the system lacks one.
6218 (Fwrite_regin): Retry fsync if interrupted.
6219
c7ffccaf
EZ
62202013-03-13 Eli Zaretskii <eliz@gnu.org>
6221
4e2df81d 6222 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
6223 activated, call w32fullscreen_hook, to make sure the new frame
6224 dimensions are in effect. (Bug#13937)
6225
8a7debc1
DA
62262013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
6227
6228 * xdisp.c (init_iterator): Simplify because both character and byte
6229 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
6230 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
6231 character and byte positions can be obtained from marker.
8a7debc1 6232
7fd8c501
PE
62332013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6234
d9df6f40
PE
6235 Static checking by Sun C 5.12.
6236 * alloc.c (buffer_memory_full) [REL_ALLOC]:
6237 * bytecode.c (exec_byte_code):
6238 * dispnew.c (init_display):
6239 * eval.c (error):
6240 * fileio.c (Fsubstitute_in_file_name):
6241 * keyboard.c (Fevent_convert_list):
6242 * keymap.c (Fsingle_key_description):
6243 * term.c (maybe_fatal, fatal):
6244 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
6245 * xsmfns.c (Fhandle_save_session):
6246 Omit unreachable code.
6247 * keymap.c (map_keymap_char_table_item): Cast void * to
6248 a function pointer type; the C Standard requires this.
6249
7fd8c501
PE
6250 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
6251 Include <sys/param.h> unconditionally, as that works elsewhere and
6252 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
6253 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
6254 and FreeBSD now.
6255
a020afb9 6256See ChangeLog.12 for earlier changes.
aac0c6e3
MR
6257
6258;; Local Variables:
6259;; coding: utf-8
aac0c6e3
MR
6260;; End:
6261
ab422c4d 6262 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
6263
6264 This file is part of GNU Emacs.
6265
6266 GNU Emacs is free software: you can redistribute it and/or modify
6267 it under the terms of the GNU General Public License as published by
6268 the Free Software Foundation, either version 3 of the License, or
6269 (at your option) any later version.
6270
6271 GNU Emacs is distributed in the hope that it will be useful,
6272 but WITHOUT ANY WARRANTY; without even the implied warranty of
6273 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6274 GNU General Public License for more details.
6275
6276 You should have received a copy of the GNU General Public License
6277 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.