Refine previous change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
71530c97
LMI
12013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
4ce82fb8
LMI
3 * image.c (imagemagick_load_image): Make animated pictures work.
4 There's still some problems with background color settings, though
5 (bug#14700).
6
71530c97
LMI
7 * decompress.c (unwind_decompress): Always restore point.
8
7510a061
XF
92013-08-14 Xue Fuqiao <xfq.free@gmail.com>
10
11 * marker.c (set_marker): Reformat documentation.
12
01c3051f
PE
132013-08-14 Paul Eggert <eggert@cs.ucla.edu>
14
aab1fcdf
PE
15 * xdisp.c (cursor_type_changed): Now static.
16
01c3051f
PE
17 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
18 Use changed. This avoids the need to call xmalloc and for the
19 caller to call xfree, and avoids memory leaks in some situations.
20
2084152a
DA
212013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
22
23 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
24 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
25 (redisplay_window): If window_end_valid is cleared due to non-zero
26 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
27 so do not call to try_cursor_movement for that window.
2084152a 28
02455cb6
DA
292013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
30
31 * window.h (struct window): Convert window_end_pos and
32 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
33 (wset_window_end_pos, wset_window_end_vpos): Remove.
34 * dispnew.c (adjust_glyph_matrix):
35 * window.c (Fwindow_end, replace_window, set_window_buffer)
36 (make_window):
37 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
38 (set_vertical_scroll_bar, redisplay_window, try_window)
39 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
40 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
41 (note_mouse_highlight): Adjust users.
42 (try_cursor_movement): Likewise. Convert old precondition to eassert.
43 Add comment.
44
da5707e8
DA
452013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
46
47 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
48 * image.c (imagemagick_filename_hint): Use `const char *' and
49 prefer SSDATA to SDATA to avoid warnings.
50
25554267
DA
512013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
52
53 Cleanup window fringes, margins and scroll bars adjustments.
54 * window.c (set_window_fringes, set_window_margins)
55 (set_window_scroll_bars, apply_window_adjustment): New functions.
56 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
57 (Fset_window_scroll_bars): Use them.
58
38a2c910
DA
592013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
60
61 * window.h (struct window): Convert scroll_bar_width
62 from Lisp_Object to integer. Adjust comment.
63 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
64 Adjust users.
65 * window.c (wset_scroll_bar_width): Remove.
66 (make_window): Initialize scroll_bar_width.
67 (Fsplit_window_internal): Use direct assignment.
68 (Fset_window_configuration, save_window_save):
69 Convert Lisp_Object to integer and back where appropriate.
70 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
71 bar was actually changed, and mention this in docstring.
72
2d065031
PE
732013-08-13 Paul Eggert <eggert@cs.ucla.edu>
74
75 * decompress.c: Minor simplifications.
76 (Fzlib_decompress_region): Don't bother verifying
77 that avail_out <= UINT_MAX, as that was confusing.
78 Mention the restriction in a comment instead.
79 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
80
a5bd5abb
JD
812013-08-13 Jan Djärv <jan.h.d@swipnet.se>
82
83 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
84 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
85
66e7901a
LMI
862013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
87
88 * image.c (imagemagick_filename_hint): Check for errors in the
89 alist structure.
90
2fa611b7
EZ
912013-08-13 Eli Zaretskii <eliz@gnu.org>
92
93 * window.c (Fwindow_margins): Return nil when there's no marginal
94 area, as per the documented API.
95
96 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
97 Fmake_vector, as scroll bar's struct members are not all Lisp
98 objects now. This avoids crashes in GC.
99
100 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
101 bool, so its address could be taken.
102
8259030d
LMI
1032013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
104
105 * image.c (imagemagick_filename_hint): New function to possibly
106 apply `image-content-type-suffixes'.
107 (imagemagick_load_image): Use it.
108
866c710e
EZ
1092013-08-13 Eli Zaretskii <eliz@gnu.org>
110
111 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
112 if loading zlib failed.
113
f10490f0
JD
1142013-08-13 Jan Djärv <jan.h.d@swipnet.se>
115
96311be7
JD
116 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
117 2013-08-13 checkin below. Change bool to BOOL, rule is:
118 All Obj-C code uses BOOL, except for interfaces callable from C.
119
f10490f0
JD
120 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
121
c8ae93b0
DA
1222013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
123
124 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
125 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
126 bool instead of BOOL.
127 * w32term.h (struct scroll_bar): Convert fringe_extended_p
128 from Lisp_Object to bitfield. Adjust comment.
129 * w32term.c (x_scroll_bar_create): Adjust user.
130 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
131 * xterm.c (XTset_vertical_scroll_bar): Likewise.
132 Use bool for boolean.
133 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
134 to `unsigned int' when defining a bitfield.
135
53b64418
PE
1362013-08-13 Paul Eggert <eggert@cs.ucla.edu>
137
138 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
139
eeaf9bf3
DA
1402013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
141
142 * window.h (struct window): Convert left_margin_cols and
143 right_margin_cols from Lisp_Objects to integers. Adjust comment.
144 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
145 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
146 Adjust users.
147 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
148 Adjust comment.
149 (showing_window_margins_p, update_window_line, update_frame_1):
150 * fringe.c (draw_fringe_bitmap_1):
151 * xdisp.c (window_box_width): Adjust users.
152 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
153 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
154 Use direct assignment.
155 (Fset_window_configuration, save_window_save, Fwindow_margins):
156 Convert Lisp_Object to integer and back where appropriate.
157 (Fset_window_margins): Adjust user. Return t if any margin
158 was actually changed, and mention this in docstring.
159
956720af
XF
1602013-08-13 Xue Fuqiao <xfq.free@gmail.com>
161
f73f4ce6 162 * syntax.c (forward_word):
956720af
XF
163 * cmds.c (forward_char, backward_char): Mention the optional argument.
164
9e37ee3b
DA
1652013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
166
167 * window.h (struct window): Convert left_fringe_width
168 and right_fringe_width from Lisp_Objects to integers.
169 Adjust comment.
170 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
171 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
172 * window.c (wset_left_fringe_width, wset_right_fringe_width):
173 Remove.
174 (make_window): Initialize new integer fields to -1.
175 (Fsplit_window_internal): Use direct assignment.
176 (Fset_window_configuration, save_window_save): Convert
177 Lisp_Object to integer and back where appropriate.
178 (Fset_window_fringes): Adjust user. Return t if any fringe
179 was actually changed, and mention this in docstring.
180
e4375ca7
DA
1812013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
182
183 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
184 * nsfns.m (x_set_cursor_type):
185 * w32fns.c (x_set_cursor_type):
186 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
187 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 188
a45543bc
DA
1892013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
190
191 * font.c (clear_font_cache): New function, stripped from...
192 (Fclear_font_cache): ...here, which now uses the function
193 above. Adjust comment.
194 * font.h (clear_font_cache): Add prototype.
195 * xfaces.c (clear_face_cache): Use clear_font_cache.
196
ae966a86
DA
1972013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
198
199 * window.c (Fset_window_start): Compare `w', not `window' because
200 `w' might not be equal to `window' after call to decode_live_window.
201
297a545b
PE
2022013-08-12 Paul Eggert <eggert@cs.ucla.edu>
203
204 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
205 This fixes a problem introduced by the Bug#15035 patch
206 when using GPG. Reported by Herbert J. Skuhra.
207
aa942e2b
EZ
2082013-08-12 Eli Zaretskii <eliz@gnu.org>
209
210 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
211 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
212 not yet initialized.
213
7699d09e
LMI
2142013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
215
216 * decompress.c (Fzlib_decompress_region): Support zlib
217 decompression, too, and rename.
218
1d238bc7
PE
2192013-08-12 Paul Eggert <eggert@cs.ucla.edu>
220
221 Minor zlib configuration tweaks.
222 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
223 Don't assume presence of fn_inflateInit2_ zlib internal function.
224
8a44a184
LMI
2252013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
226
227 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
228 include the zlib prefix.
229
594a4307
EZ
2302013-08-12 Eli Zaretskii <eliz@gnu.org>
231
232 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
233 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
234 define static variables that are pointers to zlib functions to be
235 dynamically loaded.
236 (init_zlib_functions) [WINDOWSNT]: New function.
237 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
238 New macros.
239 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
240 macros instead of invoking the zlib functions directly.
241 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
242 Szlib_available_p.
243
d2e113bc
DA
2442013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Avoid looping over all frame windows to freeze and unfreeze.
247 * window.h (struct window): Drop frozen_window_start_p.
248 (freeze_window_starts): Drop prototype.
249 * frame.h (struct frame): New frozen_window_starts flag.
250 (FRAME_WINDOWS_FROZEN): New macro.
251 * window.c (freeze_window_start, freeze_window_starts):
252 Remove.
253 (select_window, replace_window): Adjust users.
254 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
255 (window_frozen_p): New function.
256 (redisplay_window): Use it.
257
94fcd171
PE
2582013-08-12 Paul Eggert <eggert@cs.ucla.edu>
259
260 Fix some fd issues when running subprocesses (Bug#15035).
261 Fix bugs that can leak files or file descriptors on errors.
262 Don't unlink open temp files, as that's hard for users to diagnose
263 when things go awry (e.g., temp disk exhausted).
264 Don't bother to lock temp files. Check for invalid recursion.
265 * callproc.c (synch_process_fd): Remove. All uses removed.
266 (synch_process_tempfile): New var or macro.
267 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
268 New constants.
269 (record_kill_process): New arg, the temp name. All callers changed.
270 (delete_temp_file): Now just a simple wrapper around unlink.
271 (call_process_kill): New arg, the call_process_fd array.
272 Close them all. Clear synch_process_pid. Remove the temp file,
273 or arrange for it to be removed.
274 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
275 that's been moved to synch_process_tempfile. Caller changed.
276 Do not remove the tempfile; that's now call_process_kill's
277 responsibility.
278 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
279 call_process_kill; the caller now does that.
280 (call_process_cleanup): Do not close the process fd; that's now
281 call_process_kill's responsibility.
282 (Fcall_process): Implement via new function call_process, which
283 has most of the old body of Fcall_process, but with a different API.
284 (call_process): New function that does not open or close filefd if
285 it is nonnegative. Record which fds need to be closed, and let
286 call_process_kill close (and remove the tempfile, on MSDOS) on error.
287 Signal an error if invoked recursively (could be done via a hook).
288 Simplify creation of the tempfile in the MSDOS case.
289 Don't create the output file until after checking for the executable.
290 Report any failure to open /dev/null.
291 Don't open /dev/null for writing twice; once is enough.
292 Don't create pipe if all output is being discarded or sent to file.
293 Don't worry about setting up the coding system or reading from the
294 pipe if all output is being discarded.
295 Hoist fd_error local into top level, to lessen block nesting.
296 Don't record deleted pid here; now done by Fcall_process_region.
297 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
298 and note its success in synch_process_tempfile.
299 Do not leak resources when child_setup fails.
300 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
301 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
302 (create_temp_file): Now returns open fd, with an additional
303 Lisp_Object * argument to return the name. All callers changed.
304 Do not close the file; rewind it instead, and leave it open for
305 the caller. Do not lock the temp file. Unwind-protect the file
306 and the file-descriptor.
307 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
308 If an asynchrounous process, record it here, not in call_process.
309 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
310 * eval.c (set_unwind_protect): New function.
311 * fileio.c (write_region): New function, generalized from the
312 old Fwrite_region. Do not lock temp files.
313 (Fwrite_region): Use it.
314 * lisp.h (set_unwind_protect, write_region): New decls.
315 * process.c: Include <verify.h>.
316 (make_process): Mark fds as initially closed.
317 (deleted_pid_list): Now a list of pid-filename pairs.
318 All uses changed.
319 (close_process_fd): New function.
320 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
321 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
322 New constants. Verify that their number matches PROCESS_OPEN_FDS.
323 (create_process, create_pty, Fmake_serial_process)
324 (server_accept_connection): Record which fds need to be closed,
325 and let deactivate_process close them.
326 (Fmake_network_process): Do not discard the unwind-protect
327 until it's safe to do so.
328 (deactivate_process): Close the fds opened by create_process etc.
329 (Fprocess_send_eof): Adjust to new way of recording open fds.
330 Report an error if /dev/null can't be opened, instead of aborting.
331 * process.h (PROCESS_OPEN_FDS): New constant.
332 (struct Lisp_Process): New member open_fds.
333 (record_kill_process, record_deleted_pid): Adjust signatures.
334 (record_deleted_pid): Move decl here ...
335 * syswait.h (record_deleted_pid): ... from here.
336
d0e615c3
PE
3372013-08-11 Paul Eggert <eggert@cs.ucla.edu>
338
339 * decompress.c: Fix bugs with large buffers and weird inputs.
340 Tune a bit. Reindent as per usual Emacs style.
341 (BUFFER_SIZE): Remove.
342 (Fdecompress_gzipped_region): Do not mishandle input buffers with
343 more than UINT_MAX bytes. Decompress into the gap instead of into
344 an auto buffer, as this should avoid copying. Return nil if
345 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
346 set immediate_quit; we shouldn't trust zlib code that much.
347
313546eb
LMI
3482013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
349
99a32242
LMI
350 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
351 errors, and really move the gap to where we want it.
352
313546eb
LMI
353 * lisp.h: Include decompress.c support.
354
355 * emacs.c (main): Include decompress.c support.
356
357 * Makefile.in: Include -lz if present.
358
d2d699ac
JD
3592013-08-11 Jan Djärv <jan.h.d@swipnet.se>
360
f90e3ebd
JD
361 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
362 (initWithTitle:): Initialize frame to 0.
363 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
364 (fillWithWidgetValue:frame:): Renamed from
365 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
366
367 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
368 fillWithWidgetValue:frame:
369
423d3b3f
JD
370 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
371 remove memory leak warnings.
372
d2d699ac
JD
373 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
374 (ns_check_menu_open): Handle menu == nil. Remove assignment to
375 menu_pending_title.
376
377 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
378 (x_activate_menubar): Update the whole menu.
379 (trackingNotification:): Call ns_check_menu_open if tracking ends.
380 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
381 current event is not NSSystemDefined (Bug#15001).
382 Call ns_check_menu_open only if trackingMenu is 2.
383 (menuDidClose:): New method, decrease trackingMenu.
384 (fillWithWidgetValue:setDelegate:): New method.
385 (fillWithWidgetValue:): Call the above.
386
387 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
388
7d652d97
PE
3892013-08-11 Paul Eggert <eggert@cs.ucla.edu>
390
391 Omit some unnecessary casts.
392 Many of these go back to the old pre-C89 days, when they may have
393 been needed, but we've been assuming C89 or later for a while now.
394 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
395 (live_float_p, live_misc_p, live_vector_p):
396 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
397 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
398 (defvar_per_buffer):
399 * callint.c (Fcall_interactively):
400 * doc.c (Fsubstitute_command_keys):
401 * filelock.c (get_boot_time):
402 * frame.c (xrdb_get_resource):
403 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
404 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
405 (xg_get_file_name_from_selector, menuitem_destroy_callback)
406 (menuitem_highlight_callback, menu_destroy_callback)
407 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
408 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
409 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
410 (xg_tool_bar_help_callback, tb_size_cb):
411 * image.c (xpm_alloc_color, png_read_from_memory)
412 (png_read_from_file, png_load_body, our_memory_skip_input_data)
413 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
414 (syms_of_image):
415 * keymap.c (describe_map):
416 * nsfns.m (Fns_display_monitor_attributes_list):
417 * nsmenu.m (process_dialog:):
418 * nsterm.m (hold_event):
419 * process.c (wait_reading_process_output):
420 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
421 * scroll.c (do_direct_scrolling, scrolling_1):
422 * termcap.c (tgetent):
423 * window.c (check_window_containing, add_window_to_list)
424 (freeze_window_starts):
425 * xdisp.c (compare_overlay_entries, vmessage):
426 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
427 (x_get_monitor_attributes_xrandr)
428 (Fx_display_monitor_attributes_list, x_display_info_for_name)
429 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
430 * xfont.c (xfont_match, xfont_open):
431 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
432 (menubar_selection_callback, menu_position_func)
433 (popup_selection_callback, create_and_show_popup_menu)
434 (dialog_selection_callback, create_and_show_dialog):
435 * xrdb.c (x_get_string_resource):
436 (main) [TESTRM]:
437 * xsmfns.c (x_session_check_input):
438 * xterm.c (x_draw_glyphless_glyph_string_foreground)
439 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
440 (xaw_jump_callback, xaw_scroll_callback):
441 Omit unnecessary casts.
442
9acc1074
PE
4432013-08-10 Paul Eggert <eggert@cs.ucla.edu>
444
445 Minor string-length refactoring.
446 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
447 * frame.c (make_monitor_attribute_list):
448 Prefer build_string to strlen + make_string.
449
361c0eb8
JD
4502013-08-10 Jan Djärv <jan.h.d@swipnet.se>
451
452 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
453 don't check minor_code (Bug#14417).
454
14ba0822
EZ
4552013-08-09 Eli Zaretskii <eliz@gnu.org>
456
457 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
458 vertical positions instead. This avoids calling MATRIX_ROW with
459 row numbers that are possibly beyond valid limits. (Bug#15064)
460
309f24d1
DA
4612013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Use xstrdup and build_unibyte_string where applicable.
464 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
465 * xfns.c (x_window):
466 * xrdb.c (x_get_customization_string):
467 * xterm.c (xim_initialize):
468 * w32fns.c (w32_window): Use xstrdup.
469 (w32_display_monitor_attributes_list):
470 * emacs.c (init_cmdargs):
471 * keyboard.c (PUSH_C_STR):
472 * nsfont.m (nsfont_open):
473 * sysdep.c (system_process_attributes):
474 * w32.c (system_process_attributes):
475 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
476
55902276
EZ
4772013-08-09 Eli Zaretskii <eliz@gnu.org>
478
479 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
480 variables of these types so that GDB would know about them, as aid
481 for debugging fatal exceptions. (Bug#15024) See also
482 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
483 discussions.
484
10bf7f5a
JD
4852013-08-08 Jan Djärv <jan.h.d@swipnet.se>
486
487 * nsterm.m (ns_update_begin): Don't change clip path if it would be
488 larger than the NSWindow (Bug#14934).
489
65620264
DA
4902013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
491
492 Redesign redisplay interface to drop global variable updated_window.
493 Always pass currently updated window as a parameter to update routines.
494 * dispextern.h (updated_window): Remove declaration.
495 (struct redisplay_interface): Pass window parameter to
496 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
497 and after_update_window_hook.
498 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
499 Adjust prototypes.
500 * dispnew.c (updated_window): Remove.
501 (redraw_overlapped_rows, update_marginal_area, update_text_area)
502 (update_window_line): Adjust to match redisplay interface changes.
503 * nsterm.m (ns_update_window_begin, ns_update_window_end)
504 (ns_scroll_run, ns_after_update_window_line):
505 * w32term.c (x_update_window_begin, x_update_window_end)
506 (x_after_update_window_line, x_scroll_run):
507 * xterm.c (x_update_window_begin, x_update_window_end)
508 (x_after_update_window_line, x_scroll_run):
509 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
510 Likewise. Adjust comments where appropriate.
511 (x_cursor_to): Simplify because this is always called during window
512 update (but install debugging check anyway).
513 (expose_window): Check must_be_updated_p flag to see whether this
514 function is called during window update.
515
628fdc56
DA
5162013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
517
518 Do not reset window modification event counters excessively.
519 These leftovers and poor man's tricky methods to catch extra
520 redisplay's attention are no longer needed.
521 * frame.c (set_menu_bar_lines_1):
522 * minibuf.c (read_minibuf_unwind):
523 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
524 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
525 (window_scroll_line_based, Fset_window_configuration):
526 * xdisp.c (redisplay_window): Do not reset last_modified and
527 last_overlay_modified counters.
528
8fd9c92e
JD
5292013-08-07 Jan Djärv <jan.h.d@swipnet.se>
530
531 * xselect.c (x_send_client_event): Set send_event and serial, memset
532 data.l as it might be bigger than data.b. Use 24 bit mask to
533 XSendEvent (Bug#15034).
534
0ee18172
EZ
5352013-08-07 Eli Zaretskii <eliz@gnu.org>
536
537 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
538 for TTY frames that are not the top frame on their console.
539 (Bug#14616)
540
16ddd1a6
MR
5412013-08-07 Martin Rudalics <rudalics@gmx.at>
542
543 * w32term.c (w32fullscreen_hook): Really maximize frame when
544 asked for (Bug#14841).
545
d2a95ffb
DA
5462013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
547
548 Prefer selected_window to Fselected_window, likewise for frames.
549 * buffer.c (Fbuffer_swap_text):
550 * data.c (Fvariable_binding_locus):
551 * window.c (run_window_configuration_change_hook): Adjust users.
552 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
553 Use decode_live_frame.
554
170da1ec
DA
5552013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
556
557 Be more careful if selected window shows the buffer other than current,
558 use window_outdated only if this is not so. This change should also
559 address some weird issues discussed in Bug#13012.
560 * window.h (window_outdated): New prototype.
561 * window.c (window_outdated): Now here. Convert from static and
562 always assume window's buffer.
563 (Fwindow_end, Fwindow_line_height): Use it.
564 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
565 and always assume window's buffer.
566 (redisplay_window): Adjust user.
e5eefe9b 567 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
568 check whether mode line should be updated only if selected window
569 shows current buffer.
570 (run_window_scroll_functions): Use eassert for debugging check.
571 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
572
56b5d5b1
DA
5732013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
574
575 * window.c (window_scroll, window_scroll_pixel_based)
576 (window_scroll_line_based): Use bool for booleans.
577
2878ba7e
PE
5782013-08-06 Paul Eggert <eggert@cs.ucla.edu>
579
580 * process.c: Fix minor off-by-one issues in descriptor counts.
581 This shouldn't fix any real bugs, but it cleans up the code a bit.
582 (max_process_desc, max_input_desc): -1, not 0, means none.
583 All uses changed.
584 (delete_input_desc): New function.
585 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
586 (deactivate_process): Scan backwards when recomuting max_process_desc;
587 that should be faster.
588 (init_process_emacs): Initialize max_input_desc.
589
e30b79c1
DA
5902013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
591
592 Use region cache to speedup bidi_find_paragraph_start.
593 * buffer.h (struct buffer): New member bidi_paragraph_cache.
594 Rename cache_long_line_scans to cache_long_scans.
595 * buffer.c (bset_cache_long_line_scans): Rename to
596 bset_cache_long_scans.
597 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
598 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
599 into account.
600 (syms_of_buffer): Rename cache-long-line-scans to
601 cache-long-scans. Adjust docstring.
602 * search.c (newline_cache_on_off):
603 * indent.c (width_run_cache_on_off): Adjust users.
604 * bidi.c (bidi_paragraph_cache_on_off): New function.
605 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
606 * insdel.c (prepare_to_modify_buffer): Invalidate
607 bidi_paragraph_cache if enabled.
608
00012b86
DA
6092013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
610
611 Invalidate region caches only if buffer text is going to be changed.
612 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
613 (modify_text): ...new prototype.
614 (prepare_to_modify_buffer_1): New prototype.
615 * textprop.c (modify_region): Rename to...
616 (modify_text_properties): ...new function.
617 (add_text_properties_1, set_text_properties, Fremove_text_properties)
618 (Fremove_list_of_text_properties): Adjust users.
619 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
620 (modify_text): ...new function.
621 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
622 (prepare_to_modify_buffer_1): ...new function.
623 * casefiddle.c (casify_region):
624 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
625 (Ftranspose_regions): Use modify_text.
626
dc6c0eda
SM
6272013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
628
629 * lisp.mk (lisp): Add nadvice.elc.
630
8f3a2c26
DA
6312013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
632
633 New macro to iterate over live buffers similar to frames.
634 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
635 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
636 Declare buffer-related variables here to offload lisp.h.
637 * buffer.c (Vbuffer_alist): Adjust comment.
638 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
639 (other_buffer_safely):
640 * data.c (store_symval_forwarding):
641 * dispnew.c (Fframe_or_buffer_changed_p):
642 * fileio.c (Fdo_auto_save):
643 * filelock.c (unlock_all_files):
644 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
645
e0fdb694
PE
6462013-08-04 Paul Eggert <eggert@cs.ucla.edu>
647
648 Fix some minor races in hosts lacking mkostemp (Bug#15015).
649 * callproc.c (create_temp_file):
650 * filelock.c (create_lock_file):
651 Assume mkostemp, since it's now provided by Gnulib.
652
63f5c6c2
EZ
6532013-08-04 Eli Zaretskii <eliz@gnu.org>
654
655 * w32.c (mkostemp): New function.
656 (mktemp): Remove, no longer used. Most of the code reused in
657 mkostemp. (Bug#15015)
484ab239 658 (mktemp): Don't undef.
63f5c6c2 659
f0b79313
DA
6602013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
661
662 * dispnew.c (glyph_matrix_count, glyph_pool_count):
663 Move under GLYPH_DEBUG and ENABLE_CHECKING.
664 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
665 (free_glyph_pool, check_glyph_memory): Likewise for
666 all users. Adjust comments where appropriate.
667
98f638d6
PE
6682013-08-03 Paul Eggert <eggert@cs.ucla.edu>
669
670 * composite.h: Minor fixups.
671 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
672 to fix a misspelling, and change it to an inline function while
673 we're at it (it need not be a macro). All uses changed.
674 (composition_method, composition_valid_p):
675 Rewrite to avoid assignments in if-conditions.
676
75c59fb3
DA
6772013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Do not use global Lisp_Object in composition macros.
680 * composite.h (composition_temp): Remove declaration.
681 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
682 (composition_method, composition_valid_p): ...inline functions.
416a3e01 683 (compose_region): Remove the leftover.
75c59fb3
DA
684 * composite.c (composition_temp): Remove.
685 (run_composition_function, update_compositions)
686 (composition_compute_stop_pos, composition_adjust_point)
687 (Ffind_composition_internal):
688 * coding.c (handle_composition_annotation):
689 * xdisp.c (handle_composition_prop, check_point_in_composition):
690 Related users changed.
691
a10c8269
DA
6922013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
693
694 Drop FRAME_PTR typedef.
695 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
696 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
697 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
698 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
699 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
700 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
701 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
702 All related users changed.
703
a104f656
SM
7042013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
705
706 * eval.c (default_toplevel_binding): New function.
707 (Fdefvar): Use it.
708 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
709 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
710 (syms_of_eval): Export them.
711 * data.c (Fdefault_value): Micro cleanup.
712 * term.c (init_tty): Use "false".
713
4b5c9326
DA
7142013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
715
716 Fix X GC leak in GTK and raw (no toolkit) X ports.
717 * xterm.c (x_free_frame_resources): If white and black relief
718 GCs are allocated, always free them here.
719 * xfns.c (x_make_gc): Omit redundant initialization.
720 * widget.c (create_frame_gcs): Remove the leftover.
721 (EmacsFrameDestroy): Do nothing because all GCs are now freed
722 in x_free_frame_resources.
723
b19aa636
JD
7242013-08-02 Jan Djärv <jan.h.d@swipnet.se>
725
726 * nsterm.m (windowWillResize:toSize:): Only change title if
727 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
728 modifying it.
729 (viewDidEndLiveResize): New method.
730
731 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
732 inside NS_IMPL_COCOA.
733
af1f7e06
DA
7342013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
735
736 * insdel.c (adjust_after_replace, replace_range, del_range_2):
737 Do not check whether undo is enabled because record_insert and
738 record_delete does that themselves.
739
65b02bb9
DA
7402013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
741
742 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
743 member which is not really used any more.
744 (FRAME_XIC_BASE_FONTNAME): Remove.
745 * xfns.c (xic_free_fontset): Adjust user.
746 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
747 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
748 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
749 (xdialog_show): Use eassert for debugging check.
7ee0f047 750 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 751
6318cde0
PE
7522013-08-01 Paul Eggert <eggert@cs.ucla.edu>
753
754 * fileio.c, fns.c (merge): Move extern decl from here ...
755 * lisp.h (merge): ... to here.
756
6c1a09ba
DA
7572013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
758
759 Fix last font-related change.
760 * w32font.h (w32font_list_internal, w32font_match_internal):
761 Fix prototype.
762 * w32uniscribe.c (uniscribe_list, uniscribe_match):
763 (uniscribe_list_family): Adjust to match font API change.
764 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
765 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
766
f8c20208
DA
7672013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
768
769 * frame.h (FRAME_MOUSE_UPDATE):
770 * nsterm.m (ns_frame_up_to_date): Omit redundant check
771 whether hlinfo->mouse_face_mouse_frame is non-NULL.
772
fdb396e2
DA
7732013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
774
775 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
776 * font.h (struct font_driver): Change list, match, and list_family
777 functions to accept struct frame * as first arg.
778 * font.c (font_score, font_compare, font_sort_entities): Remove
779 prototypes.
780 (font_sort_entities, font_list_entities, font_select_entity):
781 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
782 match font API change.
783 * xfont.c (xfont_list, xfont_match, xfont_list_family):
784 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
785 * ftxfont.c (ftxfont_list, ftxfont_match):
786 * xftfont.c (xftfont_list, xftfont_match):
787 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
788 * w32font.c (w32font_list, w32font_match, w32font_list):
789 (w32font_list_internal, w32_font_match_internal): Likewise.
790 * xfaces.c (Fx_family_fonts): Adjust user.
791
52b8a085
DA
7922013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
793
794 Do not use pure Xism x_wm_set_icon_position in non-X ports.
795 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
796 only if HAVE_X_WINDOWS is in use.
797 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
798 * nsterm.m (x_wm_set_icon_position): Remove no-op.
799 * w32term.c (x_wm_set_icon_position): Likewise.
800 * w32fns.c (x_icon): Adjust user.
801
c791c18e
DA
8022013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
803
804 * xterm.c (last_mouse_press_frame): Remove the
805 leftover which is not really used any more.
806 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
807 (x_flush): Call XFlush once per each X display, not frame.
808 This is better because this code always unconditionally skips
809 non-X frames in Vframe_list and issues the only XFlush if we
810 have more than one X frame on the same X display.
2f935d86
DA
811 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
812 Use bool for booleans.
813 (x_draw_glyph_string_background, cvt_string_to_pixel):
814 (cvt_pixel_dtor): Drop unnecessary prototypes.
815 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 816
f435830e
DA
8172013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
818
819 Drop unnecessary functions that deals with frame pixel size.
820 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
821 (x_pixel_height): Drop prototypes.
822 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
823 (x_pixel_height): Drop implementations.
824 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
825 which should be always valid for window frame.
826 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
827 * w32menu.c (Fx_popup_dialog):
828 * xmenu.c (Fx_popup_dialog): Likewise for both.
829
84231434
DA
8302013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
831
832 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
833 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
834 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
835 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
836 and mention nil frame in docstring.
84231434 837
959067a1
DA
8382013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
839
840 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
841 (x_figure_window_size): Likewise. Adjust to return long.
842 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
843 (toplevel): Move Qterminal_live_p to...
844 * terminal.c (toplevel): ...here, make it static, and...
845 (syms_of_terminal): ...DEFSYM here.
846 * frame.h (Qterminal_live_p): Remove declaration.
847 (make_frame, x_figure_window_size): Adjust prototype.
848 * nsfns.m (Fx_create_frame): Use long for window flags.
849
f4b169ce
PE
8502013-07-30 Paul Eggert <eggert@cs.ucla.edu>
851
852 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
853 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
854 Do not assume that emacs_close (INT_MAX) is a no-op.
855
bee6a2c7
DA
8562013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
857
858 * xfaces.c (make_face_cache): For struct face_cache, prefer
859 xmalloc to xzalloc and so avoid redundant call to memset.
860 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
861
d7e6881a
DA
8622013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
863
864 * fringe.c (draw_window_fringes, update_window_fringes)
865 (compute_fringe_widths):
866 * w32term.c (x_draw_glyph_string):
867 * window.c (candidate_window_p, Frecenter):
868 * xfaces.c (realize_basic_faces, realize_default_face)
869 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
870 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
871 * xfns.c (x_set_cursor_color, xic_free_xfontset):
872 * xmenu.c (Fx_menu_bar_open_internal):
873 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
874 * xsettings.c (xft_settings_event):
875 * xterm.c (x_draw_glyph_string, x_had_errors_p):
876 Use bool for booleans. Adjust style and comments where
877 appropriate.
878 * dispextern.h (draw_window_fringes, update_window_fringes)
879 (compute_fringe_widths):
880 * xterm.h (x_had_errors_p): Adjust prototype.
881
ec3058af
DA
8822013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
883
884 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
885 CHECK_LIST. Rewrite the loop to avoid useless local variable.
886
218e0637
DA
8872013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
888
889 * fns.c (toplevel): Remove comment before Fsafe_length because
890 it checks for QUIT.
891
e560aba9
PE
8922013-07-28 Paul Eggert <eggert@cs.ucla.edu>
893
894 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
895
2e5ce5de
EZ
8962013-07-28 Eli Zaretskii <eliz@gnu.org>
897
898 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
899 frame which got the message is still alive, before dereferencing
900 its pointer. (Bug#14970)
901
902 * frame.c (delete_frame): Test "this" frame's minibuffer window to
903 be a live window, before using it as such. (Bug#14970)
904
e95da6d3
EZ
9052013-07-27 Eli Zaretskii <eliz@gnu.org>
906
907 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
908 w32_detect_focus_change instead of doing part of its job by hand.
909 This fixes the problem whereby FOCUS_OUT events were not sent to
910 the event queue.
911
a8f93651
EZ
9122013-07-26 Eli Zaretskii <eliz@gnu.org>
913
fec92060
EZ
914 * process.c (Fprocess_list): Doc fix.
915
a8f93651
EZ
916 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
917 being re-exposed only if it didn't ask to become visible.
918 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
919 was previously iconified. (Bug#14841)
920 (x_iconify_frame): Mark the frame iconified.
921
d5a7a9d9
PE
9222013-07-26 Paul Eggert <eggert@cs.ucla.edu>
923
924 Fix minor problems found by static checking.
925 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
926 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
927
56ea7291
SM
9282013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
929
930 * eval.c (set_specpdl_old_value): New function.
931 (unbind_to): Minor simplification.
932 (get_backtrace_frame): New function.
933 (Fbacktrace_frame): Use it. Add `base' argument.
934 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
935 (syms_of_eval): Export backtrace-eval.
936 * xterm.c (x_focus_changed): Simplify.
937
9d611ffe
PE
9382013-07-25 Paul Eggert <eggert@cs.ucla.edu>
939
940 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
941
999c74e3
EZ
9422013-07-24 Eli Zaretskii <eliz@gnu.org>
943
944 * xdisp.c (redisplay_window): Instead of moving point out of
945 scroll margin, reject the force_start method, and try scrolling
946 instead. (Bug#14780)
947
198fa217
KB
9482013-07-24 Ken Brown <kbrown@cornell.edu>
949
950 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
951 (Bug#14944).
952
53840e55
PE
9532013-07-24 Paul Eggert <eggert@cs.ucla.edu>
954
955 * eval.c (Fprogn): Do not check that BODY is a proper list.
956 This undoes the previous change. The check slows down the
957 interpreter, and is not needed to prevent a crash. See
958 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
959
60967f56
GM
9602013-07-23 Glenn Morris <rgm@gnu.org>
961
962 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
963
9ca960e2
PE
9642013-07-23 Paul Eggert <eggert@cs.ucla.edu>
965
a29c3e6d
PE
966 Port to GNU/Linux systems with tinfo but not ncurses.
967 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
968 to decide whether ncurses is being used. Without this change,
969 GCC complains about tgetent not being declared, on a system
970 that has tinfo installed but ncurses not installed.
971
f274311c
PE
972 * eval.c (Fprogn): Check that BODY is a proper list.
973
16b0520a
PE
974 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
975 * data.c (Fsetq_default):
976 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
977 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
978 (Fcondition_case):
979 Tune by taking advantage of the fact that ARGS is always a list
980 when a function is declared to have UNEVALLED args.
981
9ca960e2
PE
982 * emacsgtkfixed.c: Port to GCC 4.6.
983 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
984
afacaa1b
JB
9852013-07-23 Juanma Barranquero <lekktu@gmail.com>
986
987 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
988 here to silence compiler warnings.
989
368a85a4
PE
9902013-07-22 Paul Eggert <eggert@cs.ucla.edu>
991
992 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
993 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
994 from messing up Emacs's 'struct frame' (Bug#14923).
995
f4e891b5
PE
9962013-07-21 Paul Eggert <eggert@cs.ucla.edu>
997
998 * alloc.c (make_save_ptr_ptr): Define this function.
999 It was inadvertently omitted. It's needed only if
1000 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1001
96c8b65e
JD
10022013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1003
1004 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1005 frame have focus (Bug#14895).
1006
ee010797
PE
10072013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 Avoid vfork-related deadlock more cleanly.
1010 * callproc.c (child_setup): When the child's exec fails, output
1011 the program name, as that's more useful. Use O_NONBLOCK to avoid
1012 deadlock.
1013 * process.c (create_process_1): Remove; no longer needed.
1014 (create_process): Remove timer hack; no longer needed, now that
1015 the child avoids deadlock.
1016
f0398ec1 10172013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1018
1019 * image.c (Fimage_flush): Fix doc typo.
1020
b2a069c2
PE
10212013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1022
6496aec9
PE
1023 Fix array bounds violation when pty allocation fails.
1024 * process.c (PTY_NAME_SIZE): New constant.
1025 (pty_name): Remove static variable; it's now auto.
1026 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1027 Take pty_name as an arg rather than using a static variable.
1028 All callers changed.
1029 (create_process): Recover pty_flag from process, not from volatile local.
1030 (create_pty): Stay inside array even when pty allocation fails.
1031 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1032
b2a069c2
PE
1033 * lread.c (Fload): Avoid initialization only when lint checking.
1034 Mention that it's needed only for older GCCs.
1035
99107004
KH
10362013-07-20 Kenichi Handa <handa@gnu.org>
1037
1038 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1039 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1040
6b1b199d
AS
10412013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1042
1043 * lread.c (Fload): Avoid uninitialized warning.
1044
4195afc3
PE
10452013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1046
3f5bef16
PE
1047 Fix some minor file descriptor leaks and related glitches.
1048 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1049 (create_lock_file): Use write, not emacs_write.
1050 * image.c (slurp_file, png_load_body):
1051 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1052 (server_accept_connection):
1053 Don't leak an fd on memory allocation failure.
1054 * image.c (slurp_file): Add a cheap heuristic for growing files.
1055 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1056 as that's what the other routines do. Maybe input need not be
1057 blocked at all, but it's better to be consistent.
1058 Avoid undefined behavior when strlen is zero.
1059
4195afc3
PE
1060 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1061 (NSTATICS): Now a constant; doesn't need to be a macro.
1062
a1aeeffe
RS
10632013-07-19 Richard Stallman <rms@gnu.org>
1064
1065 * coding.c (decode_coding_utf_8): Add simple loop for fast
1066 processing of ASCII characters.
1067
63b34baa
PE
10682013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1071
621dd9ac
EZ
10722013-07-19 Eli Zaretskii <eliz@gnu.org>
1073
1074 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1075 unportable 'struct x_display_info'.
1076 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1077 is a portable type.
1078
1396ac86
PE
10792013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1080
ab9980cd
PE
1081 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1082 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1083 or fscanf fails.
1084 (system_process_attributes): Prefer plain char to unsigned char
1085 when either will do. Clean up properly if interrupted or if
1086 memory allocations fail. Don't assume sscanf succeeds. Remove
1087 no-longer-needed workaround to stop GCC from whining. Read
1088 command-line once, instead of multiple times. Check read status a
1089 bit more carefully.
1090
1396ac86
PE
1091 Fix obscure porting bug with varargs functions.
1092 The code assumed that int is treated like ptrdiff_t in a vararg
1093 function, which is not a portable assumption. There was a similar
1094 -- though these days less likely -- porting problem with various
1095 assumptions that pointers of different types all smell the same as
1096 far as vararg functions is conserved. To make this problem less
1097 likely in the future, redo the API to use varargs functions.
1098 * alloc.c (make_save_value): Remove this vararg function.
1099 All uses changed to ...
1100 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1101 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1102 New functions.
1103 (make_save_ptr): Rename from make_save_pointer, for consistency with
1104 the above. Define only on platforms that need it. All uses changed.
1105
4d19d194
PE
11062013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1107
1108 * keyboard.c: Try to fix typos in previous change.
1109 (DISPLAY_LIST_INFO): New macro.
1110 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1111 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1112
945c5bb1
JB
11132013-07-18 Juanma Barranquero <lekktu@gmail.com>
1114
1115 * keyboard.c (kbd_buffer_get_event):
1116 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1117 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1118
f4b1eb36
PE
11192013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1120
5e679a2c
PE
1121 * filelock.c: Fix unlikely file descriptor leaks.
1122 (get_boot_time_1): Rework to avoid using emacs_open.
1123 This doesn't actually fix a leak, but is better anyway.
1124 (read_lock_data): Use read, not emacs_read.
1125
a8cd4836
PE
1126 * doc.c: Fix minor memory and file descriptor leaks.
1127 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1128 (get_doc_string, Fsnarf_documentation):
1129 Fix file descriptor leak on error.
1130
ef30e638
PE
1131 * term.c: Fix minor fdopen-related file descriptor leaks.
1132 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1133 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1134
f4b1eb36
PE
1135 * charset.c: Fix file descriptor leaks and errno issues.
1136 Include <errno.h>.
1137 (load_charset_map_from_file): Don't leak file descriptor on error.
1138 Use plain record_xmalloc since the allocation is larger than
1139 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1140 of entries.
1141 * eval.c (record_unwind_protect_nothing):
1142 * fileio.c (fclose_unwind):
1143 New functions.
1144 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1145 The replacement doesn't block input, but that no longer seems
1146 necessary.
1147
b648c163
PE
11482013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1149
a0931322
PE
1150 * lread.c: Fix file descriptor leaks and errno issues.
1151 (Fload): Close some races that leaked fds or streams when 'load'
1152 was interrupted.
1153 (Fload, openp): Report error number of last nontrivial failure to open.
1154 ENOENT counts as trivial.
1155 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1156 New functions.
1157 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1158 now that the function is always called with a nonnegative arg.
1159 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1160 All uses replaced with ...
1161 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1162
b648c163
PE
1163 A few more minor file errno-reporting bugs.
1164 * callproc.c (Fcall_process):
1165 * doc.c (Fsnarf_documentation):
1166 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1167 * process.c (set_socket_option):
1168 Don't let a constructor trash errno.
1169 * doc.c: Include <errno.h>.
1170
b1dc4084
JB
11712013-07-16 Juanma Barranquero <lekktu@gmail.com>
1172
1173 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1174
c43843aa
PE
11752013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1176
50a30cce
PE
1177 Fix w32 bug with call-process-region (Bug#14885).
1178 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1179 to Fcall_process when the input is empty. This simplifies the
1180 code a bit. It makes no difference on POSIXish platforms but
1181 apparently it fixes a bug on w32.
1182
44e18199 1183 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1184 * fileio.c (close_file_unwind): Don't close if FD is negative;
1185 this can happen when unwinding a zapped file descriptor.
1186 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1187 in case Emacs runs out of memory between the two unwind-protects.
1188 Don't trash errno when closing FD.
1189 Zap the FD in the specpdl when closing it, instead of deferring
1190 the removal of the unwind-protect; this fixes a bug where a child
1191 function unwinds the stack past us.
1192
27e498e6
PE
1193 New unwind-protect flavors to better type-check C callbacks.
1194 This also lessens the need to write wrappers for callbacks,
1195 and the need for make_save_pointer.
1196 * alloca.c (free_save_value):
1197 * atimer.c (run_all_atimers):
1198 Now extern.
1199 * alloc.c (safe_alloca_unwind):
1200 * atimer.c (unwind_stop_other_atimers):
1201 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1202 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1203 * minibuf.c (choose_minibuf_frame_1):
1204 * process.c (make_serial_process_unwind):
1205 * xdisp.h (pop_message_unwind):
1206 * xselect.c (queue_selection_requests_unwind):
1207 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1208 * alloca.c (record_xmalloc):
1209 Prefer record_unwind_protect_ptr to record_unwind_protect with
1210 make_save_pointer.
1211 * alloca.c (Fgarbage_collect):
1212 Prefer record_unwind_protect_void to passing a dummy.
1213 * buffer.c (restore_buffer):
1214 * window.c (restore_window_configuration):
1215 * xfns.c, w32fns.c (do_unwind_create_frame)
1216 New wrapper. All record-unwind uses of wrappee changed.
1217 * buffer.c (set_buffer_if_live):
1218 * callproc.c (call_process_cleanup, delete_temp_file):
1219 * coding.c (code_conversion_restore):
1220 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1221 * editfns.c (save_excursion_restore)
1222 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1223 (save_restriction_restore):
1224 * eval.c (restore_stack_limits, un_autoload):
1225 * fns.c (require_unwind):
1226 * keyboard.c (recursive_edit_unwind, tracking_off):
1227 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1228 * macros.c (pop_kbd_macro, restore_menu_items):
1229 * nsfns.m (unwind_create_frame):
1230 * print.c (print_unwind):
1231 * process.c (start_process_unwind):
1232 * search.c (unwind_set_match_data):
1233 * window.c (select_window_norecord, select_frame_norecord):
1234 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1235 (fast_set_selected_frame):
1236 * xfns.c, w32fns.c (unwind_create_tip_frame):
1237 Return void, not a dummy Lisp_Object. All uses changed.
1238 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1239 * callproc.c (call_process_kill):
1240 * fileio.c (restore_point_unwind, decide_coding_unwind)
1241 (build_annotations_unwind):
1242 * insdel.c (Fcombine_after_change_execute_1):
1243 * keyboard.c (read_char_help_form_unwind):
1244 * menu.c (unuse_menu_items):
1245 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1246 * sound.c (sound_cleanup):
1247 * xdisp.c (unwind_redisplay):
1248 * xfns.c (clean_up_dialog):
1249 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1250 Accept no args and return void, instead of accepting and returning
1251 a dummy Lisp_Object. All uses changed.
1252 * cygw32.c (fchdir_unwind):
1253 * fileio.c (close_file_unwind):
1254 * keyboard.c (restore_kboard_configuration):
1255 * lread.c (readevalllop_1):
1256 * process.c (wait_reading_process_output_unwind):
1257 Accept int and return void, rather than accepting an Emacs integer
1258 and returning a dummy object. In some cases this fixes an
1259 unlikely bug when the corresponding int is outside Emacs integer
1260 range. All uses changed.
1261 * dired.c (directory_files_internal_unwind):
1262 * fileio.c (do_auto_save_unwind):
1263 * gtkutil.c (pop_down_dialog):
1264 * insdel.c (reset_var_on_error):
1265 * lread.c (load_unwind):
1266 * xfns.c (clean_up_file_dialog):
1267 * xmenu.c, nsmenu.m (pop_down_menu):
1268 * xmenu.c (cleanup_widget_value_tree):
1269 * xselect.c (wait_for_property_change_unwind):
1270 Accept pointer and return void, rather than accepting an Emacs
1271 save value encapsulating the pointer and returning a dummy object.
1272 All uses changed.
1273 * editfns.c (Fformat): Update the saved pointer directly via
1274 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1275 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1276 (unwind_body): New function.
1277 (record_unwind_protect): First arg is now a function returning void,
1278 not a dummy Lisp_Object.
1279 (record_unwind_protect_ptr, record_unwind_protect_int)
1280 (record_unwind_protect_void): New functions.
1281 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1282 * fileio.c (struct auto_save_unwind): New type.
1283 (do_auto_save_unwind): Use it.
1284 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1285 * insdel.c (struct rvoe_arg): New type.
1286 (reset_var_on_error): Use it.
1287 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1288 New constants.
1289 (specbinding_func): Remove; there are now several such functions.
1290 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1291 (set_unwind_protect_ptr): New function.
1292 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1293
4e604a5d
PE
1294 Be simpler and more consistent about reporting I/O errors.
1295 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1296 Say "Read error" and "Write error", rather than "I/O error", or
1297 "IO error reading", or "IO error writing", when a read or write
1298 error occurs.
1299 * process.c (Fmake_network_process, wait_reading_process_output)
1300 (send_process, Fprocess_send_eof, wait_reading_process_output):
1301 Capitalize diagnostics consistently. Put "failed foo" at the
1302 start of the diagnostic, so that we don't capitalize the
1303 function name "foo". Consistently say "failed" for such
1304 diagnostics.
1305 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1306 All callers changed. This is so it can use report_file_error.
1307 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1308 diagnostics consistently as above.
1309
a9757f6a
PE
1310 * fileio.c (report_file_errno): Fix errno reporting bug.
1311 If the file name is neither null nor a pair, package it up as a
1312 singleton list. All callers changed, both to this function and to
1313 report_file_error. This fixes a bug where the memory allocator
1314 invoked by list1 set errno so that the immediately following
1315 report_file_error reported the wrong errno value.
1316
c43843aa
PE
1317 Fix minor problems found by --enable-gcc-warnings.
1318 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1319 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1320
18c26d81
JD
13212013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1322
1323 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1324 Set event->arg to Qt if switch-event shall be generated.
1325 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1326
1327 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1328
1329 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1330 FOCUS_OUT_EVENT.
1331
1332 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1333 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1334 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1335 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1336 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1337 and there is a focused frame.
1338 (head_table): Add focus-in and focus-out.
1339 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1340 bind to handle-focus-in/out.
1341
1342 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1343 (Fhandle_switch_frame): Call Fhandle_focus_in.
1344 (syms_of_frame): defsubr handle-focus-in/out.
1345
6c6f1994
PE
13462013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1347
c7ddc792
PE
1348 Fix porting bug to older POSIXish platforms (Bug#14862).
1349 * sysdep.c (emacs_pipe): New function, that implements
1350 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1351 This should port better to CentOS 5 and to Mac OS X 10.6.
1352 All calls to pipe2 changed.
1353
6c6f1994
PE
1354 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1355 This makes the code easier to read and the executable a bit smaller.
1356 Do not replace all calls to Fcons that happen to create lists,
1357 just calls that are intended to create lists. For example, when
1358 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1359 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1360 Similarly for list2 through list5.
1361 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1362 * bytecode.c (exec_byte_code):
1363 * callint.c (quotify_arg, Fcall_interactively):
1364 * callproc.c (Fcall_process, create_temp_file):
1365 * charset.c (load_charset_map_from_file)
1366 (Fdefine_charset_internal, init_charset):
1367 * coding.c (get_translation_table, detect_coding_system)
1368 (Fcheck_coding_systems_region)
1369 (Fset_terminal_coding_system_internal)
1370 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1371 * composite.c (update_compositions, Ffind_composition_internal):
1372 * dired.c (directory_files_internal, file_name_completion)
1373 (Fsystem_users):
1374 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1375 * doc.c (Fsnarf_documentation):
1376 * editfns.c (Fmessage_box):
1377 * emacs.c (main):
1378 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1379 (Feval, eval_sub, Ffuncall, apply_lambda):
1380 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1381 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1382 (Fset_file_times, Finsert_file_contents)
1383 (Fchoose_write_coding_system, Fwrite_region):
1384 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1385 * font.c (font_registry_charsets, font_parse_fcname)
1386 (font_prepare_cache, font_update_drivers, Flist_fonts):
1387 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1388 * frame.c (make_frame, Fmake_terminal_frame)
1389 (x_set_frame_parameters, x_report_frame_params)
1390 (x_default_parameter, Fx_parse_geometry):
1391 * ftfont.c (syms_of_ftfont):
1392 * image.c (gif_load):
1393 * keyboard.c (command_loop_1):
1394 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1395 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1396 (Fminor_mode_key_binding, accessible_keymaps_1)
1397 (Faccessible_keymaps, Fwhere_is_internal):
1398 * lread.c (read_emacs_mule_char):
1399 * menu.c (find_and_return_menu_selection):
1400 * minibuf.c (get_minibuffer):
1401 * nsfns.m (Fns_perform_service):
1402 * nsfont.m (ns_script_to_charset):
1403 * nsmenu.m (ns_popup_dialog):
1404 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1405 (Fx_own_selection_internal):
1406 * nsterm.m (append2):
1407 * print.c (Fredirect_debugging_output)
1408 (print_prune_string_charset):
1409 * process.c (Fdelete_process, Fprocess_contact)
1410 (Fformat_network_address, set_socket_option)
1411 (read_and_dispose_of_process_output, write_queue_push)
1412 (send_process, exec_sentinel):
1413 * sound.c (Fplay_sound_internal):
1414 * textprop.c (validate_plist, add_properties)
1415 (Fput_text_property, Fadd_face_text_property)
1416 (copy_text_properties, text_property_list, syms_of_textprop):
1417 * unexaix.c (report_error):
1418 * unexcoff.c (report_error):
1419 * unexsol.c (unexec):
1420 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1421 (Fformat_mode_line, syms_of_xdisp):
1422 * xfaces.c (set_font_frame_param)
1423 (Finternal_lisp_face_attribute_values)
1424 (Finternal_merge_in_global_face, syms_of_xfaces):
1425 * xfns.c (x_default_scroll_bar_color_parameter)
1426 (x_default_font_parameter, x_create_tip_frame):
1427 * xfont.c (xfont_supported_scripts):
1428 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1429 (menu_help_callback, xmenu_show):
1430 * xml.c (make_dom):
1431 * xterm.c (set_wm_state):
1432 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1433 and similarly for list2 through list5.
1434
bafe80ce
PE
14352013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * callproc.c (Fcall_process_region): Fix minor race and tune.
1438 (create_temp_file): New function, with the temp-file-creation part
1439 of the old Fcall_process_region. Use Fcopy_sequence to create the
1440 temp file name, rather than alloca + build_string, for simplicity.
1441 Don't bother to block input around the temp file creation;
1442 shouldn't be needed. Simplify use of mktemp. Use
1443 record_unwind_protect immediately after creating the temp file;
1444 this closes an unlikely race where the temp file was not removed.
1445 Use memcpy rather than an open-coded loop.
1446 (Fcall_process_region): Use the new function. If the input is
1447 empty, redirect from /dev/null rather than from a newly created
1448 empty temp file; this avoids unnecessary file system traffic.
1449
4700b5a5
PE
14502013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1451
5c97beae
PE
1452 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1453 Simplify by making this case like the other two. This is a bit
1454 slower on obsolete hosts, but the extra complexity isn't worth it.
1455
4700b5a5
PE
1456 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1457 * process.c (create_process) [!DOS_NT]:
1458 Remove now-unnecessary calls to emacs_close.
1459
f9a74c4c
EZ
14602013-07-13 Eli Zaretskii <eliz@gnu.org>
1461
922ae7ee
EZ
1462 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1463 returning early. (Bug#14850)
1464
f9a74c4c
EZ
1465 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1466 and inhibit-iso-escape-detection attributes of 'undecided'.
1467 (Bug#14822)
1468
5e301d76
PE
14692013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1470
69e0e5ee
PE
1471 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1472 Reported by Herbert J. Skuhra in
1473 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1474
5e301d76
PE
1475 Don't lose top specpdl entry when memory is exhausted.
1476 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1477 specpdl overflow here, to simplify callers; all callers changed.
1478 Always reserve an unused entry at the stack top; this avoids
1479 losing the top entry's information when memory is exhausted.
1480
7e649856
PE
14812013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1482
a773ed9a
PE
1483 Clean up errno reporting and fix some errno-reporting bugs.
1484 * callproc.c (Fcall_process):
1485 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1486 * process.c (create_process, Fmake_network_process):
1487 * unexaix.c (report_error):
1488 * unexcoff.c (report_error):
1489 Be more careful about reporting the errno of failed operations.
1490 The code previously reported the wrong errno sometimes.
1491 Also, prefer report_file_errno to setting errno + report_file_error.
1492 (Fcall_process): Look at openp return value rather than at path,
1493 as that's a bit faster and clearer when there's a numeric predicate.
1494 * fileio.c (report_file_errno): New function, with most of the
1495 old contents of report_file_error.
1496 (report_file_error): Use it.
1497 (Ffile_exists_p, Ffile_accessible_directory_p):
1498 Set errno to 0 when it is junk.
1499 * fileio.c (Faccess_file):
1500 * image.c (x_create_bitmap_from_file):
1501 Use faccessat rather than opening the file, to avoid the hassle of
1502 having a file descriptor open.
1503 * lisp.h (report_file_errno): New decl.
1504 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1505
7e649856
PE
1506 Minor EBADF fixes.
1507 * process.c (create_process, wait_reading_process_output) [AIX]:
1508 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1509 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1510 a multithreaded environment anyway).
1511 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1512
f6774c1a
AS
15132013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1514
1515 * image.c (x_find_image_file): Don't close a remote file handle.
1516
bacba3c2
PE
15172013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 Fix races with threads and file descriptors.
1520 * callproc.c (Fcall_process_region):
1521 * dired.c (open_directory):
1522 * emacs.c (main, Fdaemon_initialized):
1523 * image.c (x_find_image_file):
1524 * inotify.c (Finotify_rm_watch):
1525 * lread.c (Flocate_file_internal):
1526 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1527 * term.c (term_mouse_moveto, init_tty):
1528 * termcap.c (tgetent):
1529 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1530 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1531 * unexhp9k800.c, unexmacosx.c (unexec):
1532 * callproc.c (Fcall_process_region):
1533 Use emacs_close, not close.
1534 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1535 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1536 and posix_close function on current platforms (which all lack them).
1537 (emacs_close): Use it. This should fix the races on GNU/Linux and
1538 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1539 and it should avoid closing random victim file descriptors on
1540 other platforms.
1541
653d4f43
PE
15422013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1543
c8536ec4
PE
1544 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1545 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1546 Touch up doc a bit.
1547
9c203066
PE
1548 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1549 This is for .gdbinit xbacktrace.
1550
653d4f43
PE
1551 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1552 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1553 (emacs_set_tty): Now static.
1554 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1555 * term.c (tty_capable_p, tty_default_color_capabilities)
1556 (get_tty_terminal, term_mouse_movement)
1557 (handle_one_term_event, init_tty, maybe_fatal):
1558 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1559 (tgetent, scan_file, name_match, compare_contin):
1560 * terminal.c (get_terminal):
1561 Use bool for boolean.
1562 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1563 Prefer char to unsigned char if either will do.
1564 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1565 (tty_write_glyphs): Prefer int to unsigned.
1566 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1567 All callers changed.
1568 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1569
45b683a1
PE
15702013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1571
29abe551
PE
1572 Port to C89.
1573 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1574 (B__dummy__): New dummy symbol, to pacify C89.
1575 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1576 they can't grok varargs macros.
1577 * dispnew.c (add_window_display_history)
1578 (add_frame_display_history):
1579 * print.c (print_object):
1580 * xdisp.c (debug_method_add):
1581 Use %p printf format only for void pointers.
1582 * emacs.c (usage_message): New constant, replacing ...
1583 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1584 (main): Adjust to usage reorg.
1585 * fns.c (syms_of_fns):
1586 * profiler.c (syms_of_profiler):
1587 Don't use non-constant struct initializers.
1588 * gnutls.h (gnutls_initstage_t):
1589 * lisp.h (enum Lisp_Fwd_Type):
1590 * lread.c (lisp_file_lexically_bound_p):
1591 * xsettings.c (anonymous enum):
1592 Remove trailing comma.
1593 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1594 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1595 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1596 (DEFUN): Use it.
1597 * regex.c (const_re_char): New type, to pacify strict C89.
1598 All uses of 'const re_char' replaced to use it.
1599 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1600 with glibc when strict C89. This change is imported from gnulib.
1601 All uses changed.
1602 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1603 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1604 Omit GNU_LINUX implementation, since it requires long long.
1605 * xterm.c (x_draw_underwave):
1606 Do not assume the traditional order of struct's members.
1607 (x_term_init): Rewrite to avoid the need for non-constant structure
1608 initializers.
1609
45b683a1 1610 Syntax cleanup, mostly replacing macros with functions.
763a086d 1611 This removes the need for the syntax_temp hack.
45b683a1
PE
1612 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1613 * syntax.c (SYNTAX_INLINE): New macro.
1614 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1615 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1616 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1617 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1618 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1619 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1620 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1621 Now constants, not macros.
1622 (syntax_temp) [!__GNUC__]: Remove.
1623 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1624 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1625 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1626 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1627 Move here from syntax.h; now functions, not macros. Except for the
1628 last function, these are static since only syntax.c uses them.
1629 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1630 All uses changed. Now a function, not a macro; use this fact
1631 to simplify the code.
1632 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1633 compiler bugs; no longer relevant.
1634 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1635 (SYNTAX_INLINE): New macro.
1636 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1637 for the new functions. Use bool for boolean member.
1638 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1639 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1640 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1641 (SETUP_BUFFER_SYNTAX_TABLE):
1642 Now extern inline functions, not macros.
1643 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1644 Remove; all uses replaced by implementation.
1645 (syntax_temp) [!__GNUC__]: Remove decl.
1646 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1647
29be4a50
JD
16482013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1649
1650 * emacs.c (main): Fix syntax error.
1651
954b166e
PE
16522013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1653
1654 Timestamp fixes for undo (Bug#14824).
1655 * atimer.c (schedule_atimer):
1656 * fileio.c (Ffile_newer_than_file_p):
1657 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1658 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1659 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1660 (syms_of_fileio): Remove Sclear_visited_file_name.
1661 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1662 file doesn't exist; this avoids an ambiguity with negative timestamps.
1663 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1664 * systime.h (make_emacs_time, invalid_emacs_time):
1665 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1666 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1667 * undo.c (record_first_change): Push (visited-file-modtime) onto
1668 undo list rather than reimplementing it by hand, incorrectly.
1669
d74647c3
KB
16702013-07-09 Ken Brown <kbrown@cornell.edu>
1671
1672 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1673
3c51b96b
JB
16742013-07-09 Juanma Barranquero <lekktu@gmail.com>
1675
1676 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1677
4ebbdd67
PE
16782013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 Handle errno and exit status a bit more carefully.
1681 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1682 number into an exit status. Instead, use EXIT_CANCELED.
1683 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1684 * callproc.c (relocate_fd):
1685 * emacs.c (close_output_streams, main):
1686 * process.c (create_process):
1687 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1688 Use emacs_perror for simplicity.
1689 * callproc.c (relocate_fd, main):
1690 * sysdep.c (sys_subshell):
1691 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1692 (shut_down_emacs): Use emacs_write, not write.
1693 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1694 * fileio.c (Fcopy_file, e_write):
1695 * nsterm.m (ns_select):
1696 * process.c (send_process):
1697 * sound.c (vox_write):
1698 Use emacs_write_sig, not emacs_write.
1699 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1700 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1701 New constants.
1702 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1703 of write.
1704 (emacs_full_write): New function.
1705 (emacs_write): Rewrite to use it.
1706 (emacswrite_sig, emacs_perror): New functions.
1707 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1708
44e18199 17092013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1710
1711 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1712 on NS even if it is present. Pixmap on NS is a void*.
1713
9caab067
PE
17142013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 Port to Ubuntu 10 (Bug#14803).
1717 Problem reported by T.V. Raman.
1718 * process.c (close_on_exec, accept4, process_socket):
1719 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1720
1d442672
EZ
17212013-07-07 Eli Zaretskii <eliz@gnu.org>
1722
1723 * w32.c (sys_dup): Declare prototype.
1724
1725 * filelock.c:
1726 * emacs.c:
1727 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1728
067428c1
PE
17292013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 Make file descriptors close-on-exec when possible (Bug#14803).
1732 This simplifies Emacs a bit, since it no longer needs to worry
1733 about closing file descriptors by hand in some cases.
1734 It also fixes some unlikely races. Not all such races, as
1735 libraries often open files internally without setting
1736 close-on-exec, but it's an improvement.
1737 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1738 * callproc.c (Fcall_process) [!MSDOS]:
1739 * emacs.c (main) [!DOS_NT]:
1740 * nsterm.m (ns_term_init):
1741 * process.c (create_process):
1742 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1743 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1744 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1745 Prefer mkostemp with O_CLOEXEC to mkstemp.
1746 * callproc.c (relocate_fd) [!WINDOWSNT]:
1747 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1748 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1749 now using pipe2.
1750 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1751 Make the resulting file descriptor close-on-exec.
1752 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1753 * lread.c (load_descriptor_list, load_descriptor_unwind):
1754 Remove; no longer needed. All uses removed.
1755 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1756 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1757 New functions.
1758 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1759 (Fmake_network_process, Fnetwork_interface_list):
1760 (Fnetwork_interface_info, server_accept_connection):
1761 Make newly-created socket close-on-exec.
1762 * sysdep.c (emacs_open, emacs_fopen):
1763 Make new-created descriptor close-on-exec.
1764 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1765 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1766
0da857dd
JD
17672013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1768
1769 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1770 for NS_IMPL_GNUSTEP.
1771
5f86adcd
PE
17722013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 Fix openp errno handling.
1775 * callproc.c (Fcall_process): Preserve openp errno around close.
1776 * lread.c (openp): Set errno when returning -1, as some callers
1777 expect this.
1778
1afb1d07
JD
17792013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1780
1781 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1782
1783 * nsterm.h (NSSavePanel): Update comment.
1784 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1785 (ns_run_file_dialog): Declare.
1786
1787 * nsfns.m: Remove panelOK.
1788 (ns_fd_data): New.
1789 (ns_run_file_dialog): New function.
1790 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1791 event loop, so file dialog is popped up by ns_run_file_dialog, called
1792 by sendEvent (Bug#14578).
1793 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1794
3323c263
EZ
17952013-07-06 Eli Zaretskii <eliz@gnu.org>
1796
fdda0220
EZ
1797 * xdisp.c (default_line_pixel_height): New function.
1798 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1799 (try_cursor_movement, redisplay_window, try_window)
1800 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1801
1802 * window.c (window_scroll_pixel_based): use
1803 default_line_pixel_height.
1804
1805 * dispextern.h (default_line_pixel_height): Add prototype.
1806
1807 * frame.c (x_set_line_spacing): Accept a float value for
1808 line-spacing parameter, per the documentation.
1809
3323c263
EZ
1810 * data.c (Fmultibyte_string_p): Doc fix.
1811
47ba6d43
PE
18122013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1813
406af475
PE
1814 Use emacs_open more consistently when opening files.
1815 This handles EINTR more consistently now, and makes it easier
1816 to introduce other uniform changes to file descriptor handling.
1817 * src/systdio.h: New file.
1818 * src/buffer.c (mmap_init):
1819 * cygw32.c (chdir_to_default_directory):
1820 * dispnew.c (Fopen_termscript):
1821 * emacs.c (Fdaemon_initialized):
1822 * fileio.c (Fdo_auto_save):
1823 * image.c (slurp_file, png_load_body, jpeg_load_body):
1824 * keyboard.c (Fopen_dribble_file):
1825 * lread.c (Fload):
1826 * print.c (Fredirect_debugging_output):
1827 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1828 * termcap.c (tgetent):
1829 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1830 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1831 * w32term.c (w32_initialize) [CYGWIN]:
1832 * xfaces.c (Fx_load_color_file):
1833 Use emacs_open instead of plain open, and emacs_fopen instead of
1834 plain fopen.
1835 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1836 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1837 * callproc.c (default_output_mode): New constant.
1838 (Fcall_process): Use it to call emacs_open instead of plain creat.
1839 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1840 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1841 (emacs_fopen): New function.
1842 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1843 Include <lisp.h>, for emacs_open.
1844 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1845
47ba6d43
PE
1846 Remove duplicate #include directives.
1847 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1848 * xfaces.c:
1849 Don't include stdio.h twice.
1850 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1851 Don't include sys/types.h or stdio.h twice.
1852 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1853 * lread.c: Don't include coding.h twice.
1854 * nsfont.m: Don't include frame.h twice.
1855 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1856 * ralloc.c: Don't include <unistd.h> twice.
1857 * xdisp.c: Don't include font.h twice.
1858 * xterm.c: Don't include fontset.h twice.
1859 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1860
b9ed53d5
PE
18612013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 Scale ImageMagick images more carefully.
1864 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1865 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1866 Be more careful about avoiding undefined behavior after
1867 integer overflow and division by zero.
1868
cf13177e
YM
18692013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1870
1871 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1872 (syms_of_w32fns): DEFSYM them.
1873 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1874 (CCHDEVICENAME): Define macros if not defined.
1875 (struct MONITOR_INFO_EX): New struct.
1876 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1877 (enum_display_monitors_fn): New variable.
1878 (globals_of_w32fns): Initialize it.
1879 (Fx_display_pixel_width, Fx_display_pixel_height)
1880 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1881 multi-monitor setups in docstrings.
1882 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1883 screen size by primary monitor's millimeter per pixel.
1884 (w32_monitor_enum, w32_display_monitor_attributes_list)
1885 (w32_display_monitor_attributes_list_fallback)
1886 (Fw32_display_monitor_attributes_list): New functions.
1887 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1888
1889 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1890 if not defined.
1891 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1892
86dfb7a8
MA
18932013-07-04 Michael Albinus <michael.albinus@gmx.de>
1894
1895 * fileio.c (Qfile_notify_error): New error symbol.
1896
1897 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1898 * inotify.c (inotify_callback, symbol_to_inotifymask)
1899 (Finotify_add_watch, Finotify_rm_watch): Use it.
1900 (inotifyevent_to_event): Exchange order of cookie and file name.
1901 (Finotify_add_watch): Adapt docstring.
1902
1903 * lisp.h (Qfile_notify_error): Declare.
1904
2c1c974b
PE
19052013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1908 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1909 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1910 which did not work (see <http://bugs.gnu.org/14569#307>).
1911 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1912 && (!noninteractive || initialized)). This attempts to thread
1913 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1914
7a35b20f
JB
19152013-07-04 Juanma Barranquero <lekktu@gmail.com>
1916
1917 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1918 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1919
1ce5cd04
PE
19202013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1923 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1924 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1925 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1926
57f8c490
PE
19272013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1930 Define to __sys_siglist.
1931
bcffb5ca
EZ
19322013-07-02 Eli Zaretskii <eliz@gnu.org>
1933
1934 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1935 word-wrap, so that overflow-newline-into-fringe would work in
1936 visual-line-mode. (Bug#2749)
1937 (move_it_in_display_line_to): When the last scanned display
1938 element fits exactly on the display line, and
1939 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1940 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1941 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1942 finding buffer position that corresponds to pixel coordinates,
1943 e.g. in buffer_posn_from_coords.
1944
2c41e781
JD
19452013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1946
1947 * process.c (handle_child_signal): Call catch_child_signal if
1948 NS_IMPL_GNUSTEP.
1949
c2418359
PE
19502013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1951
52a9bcae
PE
1952 Don't convert function pointers to void * and back.
1953 It isn't portable C, and it's easy enough to avoid.
1954 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1955 (make_save_value): Add support for SAVE_FUNCPOINTER.
1956 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1957 * print.c (print_object):
1958 Distinguish function from object pointers.
1959 * lisp.h (SAVE_FUNCPOINTER): New constant.
1960 (SAVE_SLOT_BITS): Adjust to it.
1961 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1962 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1963 (voidfuncptr): New typedef.
1964 (struct Lisp_Save_Value): New member data[0].funcpointer.
1965 (XSAVE_FUNCPOINTER): New function.
1966
c2418359
PE
1967 Simplify buildobj processing.
1968 * Makefile.in (buildobj.h): Make it a sequence of strings each
1969 followed by comma, rather than a single string. Put it into a
1970 .tmp file in case there's an error while generating it.
1971 (gl-stamp): Use .tmp for temp files.
1972 (mostlyclean): Clean .tmp files.
1973 * doc.c (buildobj): Move to just the routine that needs it.
1974 It's now an array of strings, so processing is simpler.
1975
8f43ce49
PE
19762013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1979 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1980 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1981 Invoke malloc_enable_thread even when not interactive.
1982 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1983 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1984 in this case, since the underlying bug has now been fixed.
1985
24827db9
JB
19862013-07-01 Juanma Barranquero <lekktu@gmail.com>
1987
1988 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1989 unlinking it (bug#14691).
1990
ef099a94
MN
19912013-06-30 Michal Nazarewicz <mina86@mina86.com>
1992
1993 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1994 before checking whether buffer is modified. This lets
1995 `kill-buffer-query-functions' cancel killing of the buffer or save
1996 its content before `kill-buffer' asks user the "Buffer %s
1997 modified; kill anyway?" question.
1998
9d3f2fc2
JD
19992013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2000
2001 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2002 Let the super performKeyEquivalent deal with them (Bug#14747).
2003
e6c6c8c7
PE
20042013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2005
1d71c1d9
PE
2006 * widget.c (resize_cb): Remove unused local.
2007
8f5f35cc
PE
2008 Do not use GTK 3 if it exists but cannot be compiled.
2009 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2010 * xterm.c (x_error_handler) [!USE_GTK]:
2011 Do not use GTK 3.
2012
e6c6c8c7
PE
2013 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2014
0ba54312
EZ
20152013-06-30 Eli Zaretskii <eliz@gnu.org>
2016
5d1c3286
EZ
2017 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2018 to the valid range of values. (Bug#14753)
2019
0ba54312
EZ
2020 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2021 when moving point by using the current glyph matrix. This avoids
2022 the need to force redisplay when this function is called in a
2023 loop.
2024
9c90cc06
PE
20252013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 Fix minor problems found by static checking.
2028 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2029 Redo the latter's body to sidestep GCC parenthesization warnings.
2030 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2031 * coding.c (detect_coding, detect_coding_system):
2032 * coding.h (struct undecided_spec):
2033 Use bool for boolean.
2034 * image.c (QCmax_width, QCmax_height): Now static.
2035 * xdisp.c (Fmove_point_visually): Remove unused local.
2036
4c672a0f
EZ
20372013-06-29 Eli Zaretskii <eliz@gnu.org>
2038
2039 * xdisp.c (Fmove_point_visually): New function.
2040
c1ea3abf
JB
20412013-06-28 Kenichi Handa <handa@gnu.org>
2042
2043 * coding.h (define_coding_undecided_arg_index): New enum.
2044 (coding_attr_index): New members
2045 coding_attr_undecided_inhibit_null_byte_detection,
2046 coding_attr_undecided_inhibit_iso_escape_detection,
2047 coding_attr_undecided_prefer_utf_8.
2048 (undecided_spec): New struct.
2049 (struct coding_system): New member `undecided' of the member
2050 `spec'.
2051
2052 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2053 (detect_coding): Likewise.
2054 (detect_coding_system): Likewise.
2055 (Fdefine_coding_system_internal): New coding system properties
2056 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2057 :prefer-utf-8.
2058 (syms_of_coding): Adjust for coding_arg_undecided_max.
2059
ba3de9e6
PE
20602013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2061
2062 * image.c (x_from_xcolors): Remove unused local.
2063
547c9269
YM
20642013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2065
2066 Defer image data transfer between X client and server until actual
2067 display happens.
2068
2069 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2070 and `mask_img'.
2071
2072 * image.c (Destroy_Image): Remove.
2073 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2074 `mask_p', and `colors_p'. All uses changed.
2075 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2076 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2077 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2078 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2079 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2080 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2081 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2082 (image_get_x_image, image_unget_x_image): New functions or macros.
2083 (image_background, image_background_transparent, x_to_xcolors)
2084 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2085 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2086 instead of Destroy_Image.
2087 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2088 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2089 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2090 (imagemagick_load_image, svg_load_image): Use them instead of
2091 x_create_x_image_and_pixmap, and x_put_x_image followed by
2092 x_destroy_x_image, respectively.
2093 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2094 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2095 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2096 background_transparent fields.
2097 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2098 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2099
dae2f5ef
PE
21002013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2101
2102 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2103 This mostly consists of undoing recent changes.
2104 * callproc.c (Fcall_process):
2105 * process.c (create_process):
2106 Do not worry about catching SIGCHLD here, undoing previous change.
2107 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2108 * process.c, process.h (catch_child_signal):
2109 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2110 * process.c (catch_child_handler): Don't worry about being called
2111 lazily and do not assume caller has blocked SIGCHLD, undoing
2112 previous change. Move first-time stuff back to
2113 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2114 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2115 set lib_child_handler if it's already initialized, which may
2116 help avoid problems on GNUStep.
2117
fa55d2aa
PE
21182013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2121 * callproc.c (Fcall_process):
2122 * process.c (create_process):
2123 Make sure SIGCHLD is caught before we fork,
2124 since Emacs startup no arranges to catch SIGCHLD.
2125 * process.c (lib_child_handler): Initialize to null, not to
2126 dummy_handler.
2127 (catch_child_signal): Allow self to be called lazily.
2128 Do nothing if it's already been called.
2129 Assume caller has blocked SIGCHLD (all callers do now).
2130 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2131 just before it's really needed.
2132 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2133 since it hasn't been caught yet.
2134
f3f9606c
LMI
21352013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2136
2137 * image.c (compute_image_size): New function to implement
2138 :max-width and :max-height.
2139 (imagemagick_load_image): Use it.
2140
c7041908
PE
21412013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2142
2143 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2144 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2145 Now extern.
2146 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2147 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2148 the SIGCHLD handler, since the code is not atomic and (due to glib)
2149 signals may be arriving now.
2150 * sysdep.c (init_signals): Do not catch child signals here;
2151 'main' now does that later, at a safer time.
2152
f86852b4
PE
21532013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2154
0dfeed58
PE
2155 Clean up SIGCHLD handling a bit (Bug#14569).
2156 * process.c, process.h (catch_child_signal):
2157 Now always extern, even if !NS_IMPL_GNUSTEP.
2158 * process.c (catch_child_signal): Move glib tickler here from
2159 init_process_emacs, so that it's done earlier in Emacs
2160 initialization. Also move the noninteractive && !initialized
2161 check here from init_process_emacs. This is all a bit cleaner for
2162 GNUish platforms, and I hope it works around the Cygwin bug.
2163 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2164 that glib signal handling is tickled before glib creates threads.
2165
f86852b4
PE
2166 * process.c (wait_reading_process_output): Avoid int overflow
2167 when reading more than 2 GiB total from a process.
2168
cbd6509c
PE
21692013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 * process.c (create_process): Handle a couple more cases,
2172 i.e., work even if new_argv and wait_child_setup[i] are cached.
2173 Use Fcall_process's style for volatile vars.
2174
9de1114a
AS
21752013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2176
2177 * process.c (create_process): Mark PROCESS volatile.
2178
fbe9e0b9
PE
21792013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 Use C99-style flexible array members if available.
2182 This avoids some subtle aliasing issues, which typically
2183 aren't a problem with GCC but may be a problem elsewhere.
2184 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2185 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2186 In either case, it uses a flexible array member rather than
2187 the old struct hack. All uses changed.
2188 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2189 Adjust to sdata reorganization.
2190 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2191 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2192 that ports better to pre-C99 non-GCC.
2193 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2194 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2195 as the latter has changed.
2196 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2197 and port better to pre-C99 GCC.
2198 * image.c (struct xpm_cached_color):
2199 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2200 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2201 Use FLEXIBLE_ARRAY_MEMBER.
2202 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2203 Move decl to top level so it gets checked against implementation.
2204 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2205 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2206
1fc71008
PE
22072013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 * syntax.c: Integer cleanups.
2210 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2211 All uses that need 0-or-2 changed to:
2212 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2213 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2214 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2215 (char_quoted, prev_char_comend_first, back_comment)
2216 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2217 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2218 Use bool for boolean.
2219 (update_syntax_table, skip_chars, skip_syntaxes):
2220 Prefer int to unsigned when either will do.
2221 (back_comment): Return boolean success flag, like forw_comment,
2222 instead of positive-or-minus-1 (which might have overflowed int anyway).
2223 Don't stuff ptrdiff_t into int.
2224 (syntax_spec_code, syntax_code_spec): Now const.
2225 (Fmatching_paren, scan_lists, scan_sexps_forward):
2226 Use enum syntaxcode for syntax code.
2227 (Fmatching_paren): Check that arg is a character, not just an integer.
2228 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2229 (Finternal_describe_syntax_value): Omit no-longer-needed
2230 comparison to 0.
2231 (skip_chars): Use char, not unsigned char, when the distinction
2232 doesn't matter.
2233 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2234 * bytecode.c (exec_byte_code):
2235 * syntax.c (syntax_spec_code, Fchar_syntax)
2236 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2237 (init_syntax_once):
2238 * syntax.h (SYNTAX_WITH_FLAGS):
2239 Omit unnecessary casts.
2240
b932cad7
EZ
22412013-06-20 Eli Zaretskii <eliz@gnu.org>
2242
2243 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2244 line dimensions here, to avoid race conditions with the main
2245 thread. (Bug#14062, bug#14630, bug#14669)
2246
2247 * w32term.c (w32_draw_window_cursor): Compute the header line and
2248 mode line dimensions here.
2249 <w32_system_caret_window, w32_system_caret_hdr_height>:
2250 <w32_system_caret_mode_height>: New variables.
2251
2252 * w32term.h: Declare them.
2253
89561f72
PE
22542013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2255
5013fc08
PE
2256 * alloc.c (die): Move "assertion failed" string here ...
2257 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2258 COND when SUPPRESS_CHECKING. This shrinks the executable text
2259 size by 0.8% to 2.2% when configured with --enable-checking,
2260 depending on optimization flags (GCC 4.8.1 x86-64).
2261
89561f72
PE
2262 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2263
763a086d 22642013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2265
2266 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2267 base is 2; this is more accurate.
2268
983aeb9a
JB
22692013-06-19 Juanma Barranquero <lekktu@gmail.com>
2270
2271 * sound.c (string_default): Move to !WINDOWSNT section.
2272 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2273
178ba3e6
PE
22742013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2275
bbc51b15
PE
2276 * sound.c: Integer cleanups.
2277 Remove unnecessary forward decls.
2278 (struct sound_device): The 'file' member is now a Lisp_Object, not
2279 a char *, so that we needn't invoke alloca on a huge size.
2280 (Fplay_sound_internal): Adjust to this.
2281 (string_default): New function.
2282 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2283 Use it to adjust to the struct sound_device change.
2284 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2285 (be2hs) [0]: Remove.
2286
178ba3e6
PE
2287 * syntax.c (skip_chars): Don't use uninitialized storage
2288 when searching a multibyte buffer for characters that are not in a
2289 unibyte string that contains non-ASCII characters.
2290
69f60cdc
JD
22912013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2292
2293 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2294 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2295
0d6224d4
PE
22962013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2297
2298 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2299
3c542890
KH
23002013-06-18 Kenichi Handa <handa@gnu.org>
2301
f7e3f7cd
KH
2302 * font.c (Ffont_spec): Signal an error for an invalid font name
2303 (Bug#14648).
3c542890 2304
9349e5f7
PE
23052013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2308 In particular this ports to 32-bit sparc Sun cc.
2309 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2310 array with a dummy element at specpdl[-1], so that its address can
2311 be taken portably.
2312 (unbind_to): Do not copy the binding; not needed, now that we
2313 copy old_value in the one place where the copy is needed.
2314 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2315 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2316 (union specbinding): Rename from struct specbinding. Redo layout
2317 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2318 which is not portable. With Sun C 5.12 32-bit sparc, the
2319 declaration causes nargs to be an unsigned bitfield, a behavior
2320 that the C standard allows; but Emacs wants nargs to be signed.
2321 The overall type is now a union of structures rather than a
2322 structure of union of structures, and the 'kind' member is now a
2323 bitfield, so that the overall type doesn't grow. All uses changed.
2324 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2325
0a4df6a5
PE
23262013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2327
ec6ecaad
PE
2328 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2329 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2330
0a4df6a5
PE
2331 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2332
7bfe8dbc
EZ
23332013-06-17 Eli Zaretskii <eliz@gnu.org>
2334
2335 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2336 unless we know that the window w's frame is a frame object.
2337 Another attempt at solving bug#14062 and bug#14630.
2338
708e05f6
LMI
23392013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2340
2341 * textprop.c (property_set_type): New enum.
2342 (add_properties): Allow appending/prepending text properties.
2343 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2344 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2345 add_text_properties_1.
2346 (Fadd_face_text_property): New function that calls
2347 add_text_properties_1.
2348
84575e67
PE
23492013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 Move functions from lisp.h to individual modules when possible.
2352 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2353 * alloc.c (XFLOAT_INIT, set_symbol_name):
2354 * buffer.c (CHECK_OVERLAY):
2355 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2356 (set_char_table_parent):
2357 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2358 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2359 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2360 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2361 (set_blv_valcell):
2362 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2363 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2364 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2365 (backtrace_args, backtrace_debug_on_exit):
2366 * floatfns.c (CHECK_FLOAT):
2367 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2368 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2369 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2370 (set_hash_index_slot):
2371 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2372 * marker.c (CHECK_MARKER):
2373 * textprop.c (CHECK_STRING_OR_BUFFER):
2374 * window.c (CHECK_WINDOW_CONFIGURATION):
2375 Move here from lisp.h, and make these functions static rather than
2376 extern inline.
2377 * buffer.c (Qoverlayp):
2378 * data.c (Qsubrp):
2379 * fns.c (Qhash_table_p):
2380 * window.c (Qwindow_configuration_p):
2381 Now static.
2382 * lisp.h: Remove the abovementioned defns and decls.
2383
44e18199 2384 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2385 In lisp.h, prefer functions to function-like macros, and
2386 constants to object-like macros, when either will do. This:
2387 . simplifies use, as there's no more need to worry about
2388 arguments' side effects being evaluated multiple times.
2389 . makes the code easier to debug on some platforms.
2390 However, when using gcc -O0, keep using function-like macros
2391 for a few critical operations, for performance reasons.
2392 This sort of thing isn't needed with gcc -Og, but -Og
2393 is a GCC 4.8 feature and isn't widely-enough available yet.
2394 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2395 Remove enum lsb_bits; no longer needed.
2396 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2397 * buffer.c (Qoverlap):
2398 * data.c (Qsubrp):
2399 * fns.c (Qhash_table_p):
2400 Now extern, so lisp.h can use these symbols.
2401 * dispextern.h: Include character.h, for MAX_CHAR etc.
2402 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2403 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2404 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2405 (GLYPH_CODE_P): Move here from lisp.h.
2406 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2407 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2408 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2409 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2410 XUNTAG now returns void *.
2411 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2412 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2413 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2414 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2415 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2416 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2417 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2418 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2419 New macros, renamed from their sans-lisp_h_ counterparts.
2420 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2421 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2422 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2423 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2424 If compiling via GCC without optimization, define these as macros
2425 in addition to inline functions.
2426 To disable this, compile with -DINLINING=0.
2427 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2428 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2429 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2430 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2431 (INTMASK, VALMASK): Now macros, since static values cannot be
2432 accessed from extern inline functions.
2433 (VALMASK): Also a constant, for benefit of old GDB.
2434 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2435 is INTEGERP, which can fold it in.
5165d44a 2436 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2437 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2438 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2439 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2440 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2441 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2442 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2443 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2444 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2445 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2446 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2447 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2448 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2449 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2450 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2451 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2452 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2453 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2454 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2455 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2456 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2457 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2458 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2459 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2460 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2461 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2462 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2463 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2464 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2465 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2466 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2467 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2468 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2469 Now functions.
2470 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2471 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2472 (VALMASK): Define in one place rather than in two, merging the
2473 USE_LSB_TAG parts; this is simpler.
2474 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2475 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2476 Move up, to avoid use before definition.
2477 Also include "globals.h" earlier, for the same reason.
2478 (make_natnum): New function.
2479 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2480 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2481 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2482 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2483 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2484 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2485 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2486 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2487 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2488 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2489 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2490 (Qwindow_configuration_p, Qimage): New forward declarations.
2491 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2492 (STRING_COPYIN): Remove; unused.
2493 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2494 (xcar_addr, xcdr_addr): New functions. All uses changed.
2495 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2496 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2497 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2498 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2499 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2500 (TYPE_RANGED_INTEGERP): Simplify.
2501 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2502 (setlocale, fixup_locale, synchronize_system_messages_locale)
2503 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2504 Now empty functions, not macros.
2505 (functionp): Return bool, not int.
2506 * window.c (Qwindow_configuration_p): Now extern,
2507 so window.h can use it.
2508 * window.h (Qwindowp): Move decl back to lisp.h.
2509
9583ec36
EZ
25102013-06-15 Eli Zaretskii <eliz@gnu.org>
2511
2512 * xdisp.c (Fline_pixel_height): New function, required for solving
2513 bug #14567.
2514
210272ce
PE
25152013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2516
2517 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2518
de0503df
SM
25192013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2520
2521 * lread.c (syms_of_lread):
2522 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2523
afbfe143
KD
25242013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2525
2526 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2527
d177e213
XF
25282013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2529
2530 * fileio.c (expand_file_name): Doc fix.
2531
05e3e412
PE
25322013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2533
f7394b12
PE
2534 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2535 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2536 Wait for self, not for 0. This can't hurt on GNU or similar
2537 system, and may help with Cygwin.
2538
05e3e412
PE
2539 * keyboard.c: Don't use PROP (...) as an lvalue.
2540 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2541 Use set_prop (A, B), not PROP (A) = B.
2542
17dd3097
EZ
25432013-06-10 Eli Zaretskii <eliz@gnu.org>
2544
2545 * xdisp.c (get_it_property): Use it->window instead of generating
2546 a Lisp object from it->w.
2547
52fab9c9
EZ
25482013-06-09 Eli Zaretskii <eliz@gnu.org>
2549
2550 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2551 get-char-property the window that is being rendered, instead of
2552 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2553 (compute_display_string_pos): When W is NULL, use the current
2554 buffer as the object to pass to get-char-property.
2555 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2556 pointer member of the bidi iterator, since no window is pertinent
2557 to this function.
52fab9c9 2558
5bf97bfc
EZ
25592013-06-08 Eli Zaretskii <eliz@gnu.org>
2560
2561 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2562 being displayed, and pass it to compute_display_string_pos.
2563 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2564 (bidi_paragraph_init): All callers changed.
2565
2566 * xdisp.c (init_from_display_pos, init_iterator)
2567 (handle_single_display_spec, next_overlay_string)
2568 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2569 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2570 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2571 (compute_display_string_pos): Accept additional argument, the
2572 window being displayed, and pass it to Fget_char_property.
2573 (Bug#14575)
2574
2575 * dispextern.h (struct bidi_it): New member w, the window being
2576 displayed.
2577 (compute_display_string_pos): Adjust prototype.
2578
5de0e011
JD
25792013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2580
e7b41c4c 2581 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2582
2583 * process.c (wait_reading_process_output): Check for NS before GLIB.
2584 GLIB may be linked in due to rsvg, but ns_select must be called.
2585
5de0e011
JD
2586 * xgselect.c (xg_select): Remove call to window_system_available
2587 and g_main_context_pending at the top, so Gdk events (i.e. file
2588 notify) are processed when Emacs is started with -nw.
2589
a822acff
EZ
25902013-06-07 Eli Zaretskii <eliz@gnu.org>
2591
2592 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2593 (ctagsfiles3): New variable, includes only *.m files.
2594 (TAGS): Use an explicit language name in the regular expressions,
2595 to avoid transformation of '/SOMETHING' by MSYS to
2596 'c:\MSYS\SOMETHING'.
2597
6c0a9ed1
RC
25982013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2599
2600 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2601
9ef6111b
EZ
26022013-06-06 Eli Zaretskii <eliz@gnu.org>
2603
2604 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2605 still need to set the mouse pointer shape and activate help-echo.
2606 (Bug#14558)
2607
7d300d64
PE
26082013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 A few porting etc. fixes for the new file monitor code.
2611 See the thread containing
2612 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2613 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2614 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2615 (dir_monitor_callback, Fgfile_rm_watch):
2616 Use assq_no_quit instead of Fassoc, for speed.
2617 (dir_monitor_callback, Fgfile_rm_watch):
2618 eassert that the monitor is a fixnum.
2619 (dir_monitor_callback): No need for CDR_SAFE.
2620 Simplify building of lisp with alternative tails.
2621 (Fgfile_add_watch, Fgfile_rm_watch):
2622 Do not assume glib functions set errno reliably on failure.
2623 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2624 and signal an error otherwise.
2625 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2626 Use Fdelq instead of Fdelete, for speed.
2627
817ebfcf
EZ
26282013-06-05 Eli Zaretskii <eliz@gnu.org>
2629
2630 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2631 don't insist on being invoked on a highlighted tool-bar button.
2632 Avoids losing tool-bar functionality when mouse-highlight is nil.
2633 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2634 Don't highlight when mouse-highlight is nil.
2635 (note_mouse_highlight): When mouse-highlight is nil, don't return
2636 right away; instead, run tool-bar and mode-line highlight
2637 subroutine, clear any existing highlight, and revert the mouse
2638 pointer to its default shape. (Bug#14558)
2639
55577e7c
SM
26402013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2641
2642 * lisp.mk (lisp): Add prog-mode.el.
2643
f019a684
PE
26442013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2645
2646 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2647 * process.c (dummy_handler): New function.
2648 (lib_child_handler): New static var.
2649 (handle_child_signal): Invoke it.
2650 (catch_child_signal): If a library has set up a signal handler,
2651 save it into lib_child_handler.
2652 (init_process_emacs): If using glib and not on Windows, tickle glib's
2653 child-handling code so that it initializes its private SIGCHLD handler.
2654 * syssignal.h (SA_SIGINFO): Default to 0.
2655 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2656 31; it should no longer be needed now.
2657
90db8702
MA
26582013-06-05 Michael Albinus <michael.albinus@gmx.de>
2659
2660 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2661
2662 * gfilenotify.c (globals_of_gfilenotify): New function.
2663 (syms_of_gfilenotify): Move global initialization there.
2664
2665 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2666
bfa3acd6
SM
26672013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2668
2669 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2670 * keyboard.c (menu_bar_items, tool_bar_items):
2671 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2672 not override local keymaps any more.
2673
ba59bd80
EZ
26742013-06-04 Eli Zaretskii <eliz@gnu.org>
2675
2676 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2677
7f203aa1
EZ
26782013-06-03 Eli Zaretskii <eliz@gnu.org>
2679
9337e206
EZ
2680 * w32console.c (initialize_w32_display): Return the dimensions of
2681 the console window via 2 additional arguments, not via the current
2682 frame. This avoids crashes due to overrunning the bounds of
2683 frame's decode_mode_spec_buffer, which is not resized following
2684 the change of the frame dimensions from the initial 10x10.
2685
2686 * w32term.h (w32_initialize_display_info): Adjust prototype.
2687
2688 * term.c (init_tty): Take dimensions of the frame from the values
2689 returned by initialize_w32_display.
2690
7f203aa1
EZ
2691 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2692 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2693 (LIBES): Add $(GFILENOTIFY_LIBS).
2694
2695 * w32inevt.c (handle_file_notifications): Add dummy implementation
2696 for !HAVE_W32NOTIFY.
2697
2698 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2699
55a87246
JD
27002013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2701
2702 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2703
2704 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2705
2706 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2707
3d5ee10a
PE
27082013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2709
2710 Fix minor problems found by static checking.
2711 * data.c (pure_write_error):
2712 Use xsignal2, not Fsignal, as Fsignal might return.
2713 * eval.c (set_backtrace_debug_on_exit): Now static.
2714 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2715 No longer inline. EXTERN_INLINE is needed only for functions
2716 defined in .h files. Reindent function header as per GNU style.
2717 (backtrace_p, backtrace_top, backtrace_next):
2718 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2719 compiler or linker. Add extern decls to pacify gcc -Wall.
2720 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2721 Now static.
2722 * frame.c (free_monitors): Define only on platforms that need it.
2723 * nsterm.m (ns_term_init):
2724 * process.c (catch_child_signal):
2725 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2726 defined on all porting targets these days.
2727 * process.c, process.h (catch_child_signal):
2728 Make it extern only if NS_IMPL_GNUSTEP is defined.
2729
e2d8a6f0
EZ
27302013-06-03 Eli Zaretskii <eliz@gnu.org>
2731
2732 * w32.c (gettimeofday): Make the signature identical to prototype
2733 in nt/inc/sys/time.h.
2734
a8a7c5f6
SM
27352013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2736
2737 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2738 .gdbinit.
2739
2740 * keyboard.c (safe_run_hooks_error): Improve error message.
2741
2742 * data.c (pure_write_error): Add `object' argument.
2743 * puresize.h (CHECK_IMPURE): Use it.
2744
c9628c79
MA
27452013-06-03 Michael Albinus <michael.albinus@gmx.de>
2746
2747 * Makefile.in (NOTIFY_OBJ): New variable.
2748 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2749
2750 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2751 Call syms_of_gfilenotify.
2752
2753 * gfilenotify.c: New file.
2754
2755 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2756 and Qfile_w32notify.
2757 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2758 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2759
2760 * lisp.h: Declare syms_of_gfilenotify.
2761
2762 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2763
2f592f95
SM
27642013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2765
2766 Merge the specpdl and backtrace stacks. Make the structure of the
2767 specpdl entries more obvious via a tagged union of structs.
2768 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2769 (enum specbind_tag): New enum.
2770 (struct specbinding): Make it a tagged union of structs.
2771 Add a case for backtrace records.
2772 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2773 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2774 (backtrace_debug_on_exit): New accessors.
2775 (struct backtrace): Remove.
2776 (struct catchtag): Remove backlist field.
2777 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2778 Move to eval.c.
2779 (Flocal_variable_p): Speed up the common case where the binding is
2780 already loaded.
2781 * eval.c (backtrace_list): Remove.
2782 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2783 (set_backtrace_args, set_backtrace_nargs)
2784 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2785 (backtrace_next): New functions.
2786 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2787 (unwind_to_catch, internal_lisp_condition_case)
2788 (internal_condition_case, internal_condition_case_1)
2789 (internal_condition_case_2, internal_condition_case_n): Don't bother
2790 with backtrace_list any more.
2791 (Fsignal): Adjust to new backtrace format.
2792 (grow_specpdl): Move up.
2793 (record_in_backtrace): New function.
2794 (eval_sub, Ffuncall): Use it.
2795 (apply_lambda): Adjust to new backtrace format.
2796 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2797 data.c.
2798 (specbind): Adjust to new specpdl format. Simplify.
2799 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2800 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2801 backtrace format.
2802 (mark_backtrace): Remove.
2803 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2804 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2805 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2806 Use mark_specpdl.
2807 * profiler.c (record_backtrace): Use get_backtrace.
2808 (handle_profiler_signal): Use backtrace_top_function.
2809 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2810 accessor functions.
2811
c0342369
JD
28122013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2813
2814 * process.h (catch_child_signal): Declare.
2815
2816 * process.c (catch_child_signal): New function.
2817 (init_process_emacs): Call it.
2818
2819 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2820 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2821 NS_IMPL_COCOA.
2822 (x_set_cursor_type): Remove declaration.
2823 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2824 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2825 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2826 (ns_get_color): Use F suffix on float.
2827 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2828 (ns_get_rgb_color): Remove.
2829 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2830 (note_mouse_movement): x and y are CGFloat.
2831 (ns_draw_fringe_bitmap): Remove unused rowY.
2832 Change #if to COCOA && >= 10_6.
2833 (ns_draw_window_cursor): Remove unused overspill.
2834 (ns_draw_underwave): width and x are EamcsCGFloat.
2835 (ns_draw_box): thickness is CGFloat.
2836 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2837 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2838 if not in main thread.
2839 (ns_get_pending_menu_title, ns_check_menu_open)
2840 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2841 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2842 (sendFromMainThread:): New method.
2843 (changeFont:): size is CGFloat.
2844 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2845 Disable warning about permanent text.
2846 (characterIndexForPoint:): Adjust return type depending on GNUStep
2847 version.
2848 (mouseDown:): delta is CGFloat.
2849 (updateFrameSize): Remove unised variable f.
2850 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2851 Cast float to EmacsCGFloat.
2852 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2853 also to -1 when restoring.
2854 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2855 inside NS_IMPL_COCOA.
2856 (toggleFullScreen:): Put call to toggleFullScreen inside
2857 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2858 (setPosition:portion:whole:): por is CGFloat.
2859 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2860 (mouseDown:): Use CGFloat.
2861 (mouseDragged:): Remove unised variable edge.
2862 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2863
2864 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2865 of CGFloat differs.
2866 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2867 when NS_IMPL_GNUSTEP.
2868 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2869 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2870 (EmacsToolbar): Add clearAll. Add tag argument to
2871 addDisplayItemWithImage.
2872 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2873
2874 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2875
2876 * nsmenu.m (ns_update_menubar): Make static.
2877 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2878 (fillWithWidgetValue:): Add cast to SEL for setAction.
2879 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2880 (update_frame_tool_bar): Update code for GNUStep.
2881 (clearAll): New method.
2882 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2883 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2884 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2885 call to insertItemWithItemIdentifier.
2886 (validateVisibleItems): Fix indentation.
2887 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2888 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2889 UtilityWindow to aStyle, remove call to setStyleMask.
2890
2891 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2892
2893 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2894 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2895 Use F suffix on floats.
2896 (ns_char_width): Returns CGFloat.
2897 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2898 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2899 DPSxshow.
2900 (ns_glyph_metrics): CGFloat instead of float.
2901
a0eb10b3
JB
2902 * nsfns.m (x_set_foreground_color, x_set_background_color):
2903 Use EmacsCGFloat.
2904 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2905 remove unused variables.
2906 (Fns_read_file_name): Keep track if panel is for save.
2907 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2908 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2909 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2910 Just return the input if GNUStep.
c0342369
JD
2911 (x_screen_planes): Remove.
2912 (Fxw_color_values): Use EmacsCGFloat
2913 (Fns_display_monitor_attributes_list): Only get screen number for
2914 Cocoa.
ef099a94 2915 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2916 EmacsSavePanel.
2917 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2918 ns_directory_from_panel.
2919
da9aff11
PE
29202013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2921
2922 * process.c (handle_child_signal): Also use WCONTINUED.
2923 This is so that list-processes doesn't mistakenly list the process
2924 as stopped, when the process has actually been continued and is
2925 now running.
2926
0e64479a
PE
29272013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2928
fc186a96
PE
2929 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2930 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2931 not already configured.
2932
0e64479a
PE
2933 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2934
38b787fa
EZ
29352013-05-29 Eli Zaretskii <eliz@gnu.org>
2936
2937 * Makefile.in (mostlyclean): Remove *.res files.
2938
22513e52
SM
29392013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2940
2941 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2942 a buffer (bug#8447).
2943
6ef3db10
EZ
29442013-05-27 Eli Zaretskii <eliz@gnu.org>
2945
2946 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2947 display vector, and we backtrack, handle the case that the
2948 previous character position is also displayed from a display
2949 vector or covered by a display string or image. (Bug#14476)
2950
6799bb26
JD
29512013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2952
2953 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2954 (struct MonitorInfo, free_monitors): Remove.
2955 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2956 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2957 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2958 Qframes, Qsource.
2959
2960 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2961 (struct MonitorInfo, free_monitors): Remove.
2962 (ns_screen_name): Make static.
2963 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2964 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2965 Qframes, Qsource.
2966
2967 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2968 (struct MonitorInfo): New struct.
2969 (free_monitors, make_monitor_attribute_list): Declare.
2970
22513e52
SM
2971 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2972 New Lisp_Object:s.
6799bb26
JD
2973 (free_monitors, make_monitor_attribute_list): New functions.
2974 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2975 Qsource.
2976
38cd43eb
XF
29772013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2978
2979 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2980
2af0948d
SM
29812013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2982
a7eb9b0f
SM
2983 * keyboard.c: Apply keyboard decoding only to events that come directly
2984 from the tty, not from unread-command-events (bug#14368).
2985 (read_event_from_main_queue): New function, extracted from read_char).
2986 (read_decoded_char): Remove.
2987 (read_decoded_event_from_main_queue): New function to replace it.
2988 (read_char): Use it.
2989 (read_key_sequence): Use read_char rather than read_decoded_char.
2990
2af0948d
SM
2991 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2992
1413e9a5
BR
29932013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2994
2995 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2996
e6d2f155
KH
29972013-05-22 Kenichi Handa <handa@gnu.org>
2998
2999 The following changes are to fix the setting of
3000 buffer-file-coding-system on, for instance, C-x RET c unix RET
3001 _FILE_OF_DOS_EOL_TYPE_ RET.
3002
3003 * coding.h (struct coding_system): New member detected_utf8_chars.
3004
3005 * coding.c (detect_coding_utf_8): Count characters and check EOL
3006 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3007 BOM is there.
3008 (setup_coding_system): Do not initialize coding->head_ascii.
3009 (check_ascii): Do not set coding->eol_seen but update it. Do not
3010 call adjust_coding_eol_type here.
1413e9a5
BR
3011 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3012 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3013 of the found coding-system.
3014 (decode_coding_gap): Cancel previous change. Utilize the
3015 character numbers counted by detect_coding_utf_8. Fix detection
3016 of BOM for utf-8.
3017
ab56a6f4 30182013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3019
3020 * search.c (looking_at_1): Only set last_thing_searched if the match
3021 changed the match-data (bug#14281).
3022
ecc3c6ed
DA
30232013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3024
3025 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3026 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3027 (move_it_vertically_backward): Likewise.
3028
5ba8bf35
YM
30292013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3030
3031 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3032 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3033 (Fx_display_mm_width, Fx_display_mm_height):
3034 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3035
91e8418b 3036 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3037 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3038 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3039 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3040 (Fx_display_backing_store, Fx_display_visual_class)
3041 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3042 (Fx_display_grayscale_p, Fx_display_pixel_width)
3043 (Fx_display_pixel_height, Fx_display_planes)
3044 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3045 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3046 (Fx_display_mm_width, Fx_display_mm_height)
3047 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3048 height for all physical monitors as in X11.
3049
fc30d803
SM
3050 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3051 Return pixel width or height for all physical monitors as in X11.
91e8418b 3052
31ff141c
PE
30532013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 Port --enable-gcc-warnings to clang.
3056 * bytecode.c (exec_byte_code):
3057 * regex.c:
3058 Redo diagnostic pragmas to pacify clang, too.
3059 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3060 * editfns.c (Fencode_time):
3061 * fileio.c (file_accessible_directory_p):
3062 * font.c (font_unparse_xlfd):
3063 Use '&"string"[index]' instead of '"string" + (index)'.
3064 * undo.c (user_error): Remove; unused.
3065
df065a0b
EZ
30662013-05-16 Eli Zaretskii <eliz@gnu.org>
3067
04d360e7
EZ
3068 * insdel.c (insert_1_both): Document the arguments, instead of
3069 referring to insert_1, which no longer exists.
3070
5bb98290
EZ
3071 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3072 some window, increment windows_or_buffers_changed, so that
3073 *Messages* display in that window is updated. (Bug#14408)
3074
df065a0b
EZ
3075 * w32.c: Include epaths.h.
3076 (init_environment): Use cmdproxy.exe without leading directories.
3077 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3078 case.
3079 (gettimeofday): Adjust signature and return value to Posix
3080 expectations.
3081
3082 * unexw32.c (open_output_file): Delete the existing emacs.exe
3083 before creating it, to break the hard link to the versioned
3084 executable.
3085
3086 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3087 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3088 (FIRSTFILE_OBJ): New variables.
3089 (W32_RES): Rename to EMACSRES. All users changed.
3090 (base_obj): Use $(CM_OBJ).
3091 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3092 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3093 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3094 $(W32_RES_LINK) before $(LIBES).
3095 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3096
1aa8d505
SM
30972013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3098
6e911150
SM
3099 * makefile.w32-in (DOC): Use just "DOC".
3100
3101 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3102
1aa8d505
SM
3103 * process.c: Export default filters and sentinels to Elisp.
3104 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3105 New constants.
3106 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3107 (Fset_process_sentinel, Fformat_network_address):
3108 Default to them instead of nil.
3109 (server_accept_connection): Sentinels can't be nil any more.
3110 (read_and_dispose_of_process_output): New function, extracted from
3111 read_process_output.
3112 (read_process_output): Use it; filters can't be nil.
3113 (Finternal_default_process_filter): New function, extracted from
3114 read_process_output.
3115 (exec_sentinel_unwind): Remove function.
3116 (exec_sentinel): Don't zilch sentinel while running.
3117 (status_notify): Sentinels can't be nil.
3118 (Finternal_default_process_sentinel): New function extracted from
3119 status_notify.
3120 (setup_process_coding_systems): Default filter is not nil any more.
3121 (syms_of_process): Export new Elisp functions and initialize
3122 new constants.
3123 * lisp.h (make_lisp_proc): New function.
3124
5ac2eb34
SM
31252013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3126
3127 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3128
eda9c7d7
EZ
31292013-05-14 Eli Zaretskii <eliz@gnu.org>
3130
3131 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3132 unless we know that the window w is a leaf window.
3133 Another attempt at solving bug#14062.
eda9c7d7 3134
8fdeaad5
JD
31352013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3136
3137 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3138 fdesc (Bug#14375).
3139
44aa9ee6
PE
31402013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 * image.c (gif_load): Check that subimages fit (Bug#14345).
3143
759fd763
SM
31442013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3145
3146 * lread.c (skip_dyn_eof): New function.
3147 (read1): Use it to skip the end of a file in response to #@00.
3148
3149 * doc.c (get_doc_string): Slightly relax the sanity checking.
3150
4465bfb4
JD
31512013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3152
3153 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3154 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3155 (MonitorInfo): New struct.
3156 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3157 (Fns_display_monitor_attributes_list): New functions.
3158 (display-usable-bounds): Remove.
3159 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3160 Qsource.
3161
7583e2a0
PE
31622013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3163
3164 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3165 (GTK_CHECK_VERSION): New macro, if not already defined.
3166 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3167 replaced by GTK_CHECK_VERSION.
3168
ad75d77e
PE
31692013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3170
3171 * xterm.h (GTK_PREREQ): New macro.
3172 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3173 to use this macro instead, for consistency and clarity.
3174
07525f77
EZ
31752013-05-08 Eli Zaretskii <eliz@gnu.org>
3176
3177 * xdisp.c (row_for_charpos_p): New function, with code of
3178 cursor_row_p, but accepts an additional argument CHARPOS instead
3179 of using a hardcoded PT.
3180 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3181 (row_containing_pos): Call row_for_charpos_p instead of partially
3182 doing the same. Fixes cursor positioning under longlines-mode
3183 when longlines-show-effect includes more than one newline, when
3184 moving the cursor vertically up.
3185
d901fc8d
JB
31862013-05-08 Juanma Barranquero <lekktu@gmail.com>
3187
3188 * makefile.w32-in (ACL_H): New macro.
3189 ($(BLD)/fileio.$(O)): Update dependencies.
3190
f269bc61
PE
31912013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3192
e7b41c4c 3193 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3194 * Makefile.in (LIB_ACL): New macro.
3195 (LIBACL_LIBS): Remove.
3196 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3197 * fileio.c: Include <acl.h>.
3198 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3199 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3200 !acl_errno_valid.
3201 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3202 it ourselves.
3203
f269bc61
PE
3204 * unexelf.c: Don't assume ElfW (Half) fits in int.
3205 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3206 when dealing with ElfW (Half) values, since they can exceed 2**31
3207 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3208 (entry_address): Omit unused NUM arg. All uses changed.
3209
a261c53e
JL
32102013-05-07 Juri Linkov <juri@jurta.org>
3211
3212 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3213 to the string converted from number with `Fnumber_to_string'.
3214 (Bug#14254)
3215
2b66427d
PE
32162013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3217
3218 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3219 This fixes a problem introduced by my previous change.
3220
15acfe41
GM
32212013-05-07 Glenn Morris <rgm@gnu.org>
3222
3223 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3224
5ea03bf5
JD
32252013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3226
3227 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3228
e0c9d565
PE
32292013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 Static checking by GCC 4.8.0.
3232 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3233 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3234 (x_get_monitor_attributes_fallback)
3235 (x_get_monitor_attributes_xinerama)
3236 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3237 Define only if USE_GTK.
3238 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3239 (x_get_monitor_attributes_fallback): Omit unused locals.
3240 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3241 Use double, not float, to avoid mixed-mode floating point arithmetic.
3242
4e3f9230
YM
32432013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3244 Jan Djärv <jan.h.d@swipnet.se>
3245
3246 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3247 (XINERAMA_CFLAGS): New macros.
3248 (ALL_CFLAGS, LIBES): Use them.
3249
3250 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3251 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3252 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3253 (syms_of_xfns): DEFSYM them.
3254 (struct MonitorInfo): New struct.
3255 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3256 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3257 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3258 (x_get_monitor_attributes_xinerama): New functions.
3259 (Fx_display_monitor_attributes_list): New primitive.
3260 (syms_of_xfns): Defsubr it.
3261
3262 * xterm.h (x_display_info): Add Xatom_net_workarea and
3263 Xatom_net_current_desktop.
3264
3265 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3266 and dpyinfo->Xatom_net_current_desktop.
3267
05839b6a
EZ
32682013-05-06 Eli Zaretskii <eliz@gnu.org>
3269
3270 * xdisp.c (pos_visible_p): Use the special code for finding the
3271 beginning of a display property or overlay for any "replacing"
3272 display property, not just for display strings. This solves
3273 incorrect reporting of position by posn-at-point. (Bug#14241)
3274
dc4a2ee0
PE
32752013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3276
5ee94506
PE
3277 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3278 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3279 Verify that ElfW (Half) fits in int.
3280 (fatal): Use same signature as lisp.h.
3281 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3282 configure and build with -DUNEXELF_DEBUG without worrying about
3283 other modules that use DEBUG.
3284 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3285 possibly-wide integers now uses it instead of plain fprintf.
3286 (entry_address): New function, which avoids problems with 32-bit
3287 overflow on 64-bit hosts.
3288 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3289 (round_up): Don't assume the remainder fits in int.
3290 (find_section): Use bool for boolean. Simplify debug code.
3291 (unexec): Don't assume file sizes fit in int or size_t.
3292 Omit unnecessary trailing newline in 'fatal' format.
3293 Use strerror rather than outputting decimal error number.
3294 Remove unused code when emacs is not defined;
3295 this file relies on Emacs now.
3296 Don't assume e_phnum and e_shnum are positive.
3297
dc4a2ee0
PE
3298 * regex.c: Fix problems when DEBUG is defined.
3299 (extract_number, extract_number_and_incr): Define regardless of
3300 whether DEBUG is defined; that's simpler and makes the code less
3301 likely to go stale in the normal case when DEBUG is not defined.
3302 Return int rather than taking an int * arg. All callers changed.
3303 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3304 Remove, replacing with ...
3305 (DEBUG_PRINT): New macro. All callers changed.
3306 (DEBUG_COMPILES_ARGUMENTS): New macro.
3307 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3308 (print_compiled_pattern, print_double_string) [DEBUG]:
3309 Use prototype rather than old-style definition.
3310 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3311 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3312 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3313 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3314 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3315 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3316 This matters only when DEBUG is defined.
3317
14c7ed05
EZ
33182013-05-05 Eli Zaretskii <eliz@gnu.org>
3319
3320 * xdisp.c (set_iterator_to_next): Set the
3321 ignore_overlay_strings_at_pos_p flag only if we are _really_
3322 iterating over an overlay string, as indicated by the
3323 current.overlay_string_index member. (Bug#14306)
3324
e6076b1b
JD
33252013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3326
3327 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3328 to where it is used, to avoid autorelease issues (Bug#14050).
3329
cbee2131
PE
33302013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3331
3332 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3333 * fileio.c (syms_of_fileio): Implement this.
3334 * filelock.c (create_lock_file): If symbolic links don't work, so
3335 we use a regular file as a lock file, do not fsync the lock file;
3336 it's not needed.
3337
30c7e542
SM
33382013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3339
3340 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3341 (syms_of_minibuf): Adjust accodingly.
3342 * lread.c (Fread):
3343 * callint.c (Fcall_interactively): Adjust calls accordingly.
3344
5bebd186
EZ
33452013-05-04 Eli Zaretskii <eliz@gnu.org>
3346
3347 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3348 w->contents is a buffer before computing everything else.
3349 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3350
3351 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3352 assertion violations. (Bug#14062)
3353
0fb0a4f3
DR
33542013-05-01 David Reitter <david.reitter@gmail.com>
3355
3356 * nsfns.m (ns_tooltip): Initialize.
3357
9e63b4a5
EZ
33582013-04-28 Eli Zaretskii <eliz@gnu.org>
3359
3360 * coding.c (decode_coding_gap): Don't remove the character before
3361 a newline unless it's a CR character. (Bug#14287)
3362
ad60824e
DN
33632013-04-28 Dan Nicolaescu <dann@gnu.org>
3364
3365 * dispextern.h (struct face): Move enum face_underline_type
3366 earlier so that bitfields can be in the same word.
3367
edbdcec0
JD
33682013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3369
3370 * nsfns.m (handlePanelKeys): New function.
3371 (EmacsOpenPanel:performKeyEquivalent:)
3372 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3373 arrows/function/control and copy/paste keys (Bug#14296).
3374
0208ede7
JL
33752013-04-27 Juri Linkov <juri@jurta.org>
3376
3377 * callint.c (Fcall_interactively): Call `Qread_number' for
3378 interactive code letter `n' instead of using duplicate code.
3379 (Bug#14254)
3380
b8dd59f7
PE
33812013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3382
3383 * systime.h (make_timeval): Declare as 'const'.
3384
8bd722db
KH
33852013-04-27 Kenichi Handa <handa@gnu.org>
3386
3387 * font.c (font_open_entity): Always open a font of manageable
3388 size.
3389
13d0e56f 33902013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3391
f780d632
PE
3392 Port better to AIX (Bug#14258).
3393 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3394 to pacify AIX xlc.
3395
ec509856
KH
33962013-04-24 Kenichi Handa <handa@gnu.org>
3397
3398 * coding.c (decode_coding_iso_2022): When an invalid escape
3399 sequence is encountered, reset the invocation and designation
3400 status to the safest one.
3401
84fc48e5
PE
34022013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3405 Without this fix, "make distclean" leaves stamp-h1 behind.
3406
806bda47
EC
34072013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3408
3409 * w32fns.c (w32_fullscreen_rect): New function to compute the
3410 window rectangle for the given fullscreen mode.
3411 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3412 longer tunes the window size. This keeps the window's edges flush
3413 with the screen and allows the taskbar to hide itself in fullboth.
3414
3415 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3416 window decorations and uses the entire screen.
3417
3418 * w32term.h (w32_fullscreen_rect) Add prototype.
3419 (struct w32_output): Replace normal_width, normal_height,
3420 normal_top, and normal_left members with a single normal_placement
3421 struct.
3422 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3423 Remove macros.
3424 (FRAME_NORMAL_PLACEMENT): New macro.
3425
9cc2810b
JB
34262013-04-16 Juanma Barranquero <lekktu@gmail.com>
3427
3428 * minibuf.c (Ftest_completion): Silence compiler warning.
3429
fd16b54c
EZ
34302013-04-15 Eli Zaretskii <eliz@gnu.org>
3431
3432 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3433 bug#14062.
fd16b54c
EZ
3434
3435 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3436 parentheses.
3437
3438 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3439 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3440 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3441 parentheses where appropriate.
3442
9e3379a0
PE
34432013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3444
3445 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3446
ddd6b685
EZ
34472013-04-14 Eli Zaretskii <eliz@gnu.org>
3448
3449 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3450 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3451 Mention in the doc string that setting these variables takes
3452 effect only after a call to set-window-buffer. (Bug#14200)
3453
29b79ba1
EZ
34542013-04-13 Eli Zaretskii <eliz@gnu.org>
3455
3456 * indent.c (Fvertical_motion): Don't consider display strings on
3457 overlay strings as display strings on the buffer position we
3458 started from. This prevents vertical cursor motion from jumping
3459 more than one line when there's an overlay string with a display
3460 property at end of line.
3461 Reported by Karl Chen <Karl.Chen@quarl.org> in
3462 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3463
562c6ee9
SM
34642013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3465
3466 * window.c (select_window): `record_buffer' even if window is
3467 already selected (bug#14191).
3468
fcc1fe85
EZ
34692013-04-11 Eli Zaretskii <eliz@gnu.org>
3470
3471 * window.c (Fwindow_end): Test more flags, including the buffer's
3472 last_overlay_modified flag, to determine whether the window's
3473 display is really up-to-date. Prevents the function from
3474 returning a stale value. (Bug#14170)
3475 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3476 current matrix.
3477
f009190a
EZ
34782013-04-10 Eli Zaretskii <eliz@gnu.org>
3479
3480 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3481 garbaged only if it is not already the top frame on its TTY.
3482 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3483 there are GUI frames open in the same session. (Bug#13864)
3484
78ce603d
SM
34852013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3486
3487 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3488 of marking the idle timers directly.
3489
a8036e40
SM
34902013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3491
3492 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3493 tables (bug#14054).
3494
7ffe7ef6
SM
34952013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3496
3497 * window.c (select_window): Don't record_buffer while the invariant is
3498 temporarily broken (bug#14161).
3499
3500 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3501
7d9f6883
EZ
35022013-04-07 Eli Zaretskii <eliz@gnu.org>
3503
3504 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3505
5406cfd9
RF
35062013-04-07 Romain Francoise <romain@orebokech.com>
3507
3508 Ignore additional platform-specific ACL errors (Bug#13702).
3509 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3510 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3511
95c0e83b
JD
35122013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3513
3514 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3515 f->output_data.ns.
3516
876da980
PE
35172013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3518
3519 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3520 This bug was introduced by my 2013-02-25 change that simplified
3521 data_start configuration. Without this change, on GNU/Linux
3522 an Emacs configured with --enable-profiling fails immediately
3523 due to a profiler signal.
3524 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3525 with these flags. On platforms where special flags are needed
3526 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3527 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3528 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3529
7452b7bd
DA
35302013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3531
3532 Get rid of some platform-specific functions examining window
3533 system and its capabilities. This is a partial rework of the
3534 2013-04-05 change.
3535 * lisp.h (have_menus_p): Remove prototype. This function is
3536 replaced with platform-independent window_system_available.
3537 (check_window_system): Move to...
3538 * frame.h (decode_window_system_frame, window_system_available):
3539 ...here, add new prototypes.
3540 * frame.c (window_system_available, decode_window_system_frame):
3541 New functions.
3542 (check_window_system): Platform-independent now.
3543 * xterm.h (x_in_use): Remove declaration.
3544 (check_x_frame):
3545 * w32term.h (check_x_frame):
3546 * nsterm.h (check_x_frame): Remove prototypes. This function
3547 is replaced with platform-independent decode_window_system_frame.
3548 * msdos.c (have_menus_p): Remove.
3549 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3550 Remove platform-specific functions. Use check_window_system,
3551 decode_window_system_frame and check_ns_display_info where
3552 appropriate. Minor style and comment tweaks.
3553 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3554 (check_x_frame): Likewise.
3555 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3556 Likewise.
3557 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3558 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3559 * xmenu.c, xselect.c: All related users changed.
3560
251e9147
KH
35612013-04-03 Kenichi Handa <handa@gnu.org>
3562
3563 The following changes is to optimize the code for reading UTF-8
3564 files.
3565
562c6ee9 3566 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3567 changed. Check EOL format. Do not call adjust_coding_eol_type
3568 here.
3569 (check_utf_8): New function.
3570 (adjust_coding_eol_type): Do nothing if already adjusted.
3571 (detect_coding): Compare the return value of check_ascii with
3572 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3573 (decode_coding_gap): Optimize for valid UTF-8.
3574
8bc369d4
KH
35752013-03-21 Kenichi Handa <handa@gnu.org>
3576
3577 * coding.c (syms_of_coding): Cancel previous change.
3578
3579 * insdel.c (insert_from_gap): Fix previous change.
3580
73931ad1
DA
35812013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3582
3583 Consistently use platform-specific function to detect window system.
3584 * lisp.h (check_window_system): New prototype. This function is
3585 going to replace check_x, check_w32 and check_ns.
3586 (have_menus_p): Mention msdos.c in comment.
3587 * fontset.c (check_window_system_func): Remove. Adjust all users.
3588 * fontset.h (check_window_system_func): Remove prototype.
3589 * nsterm.h (check_ns):
3590 * xterm.h (check_x):
3591 * w32term.h (check_w32): Likewise.
3592 * menu.c (Fx_popup_menu): Use check_window_system.
3593 * msdos.c (check_window_system): Define for MS-DOS.
3594 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3595 * w32fns.c (check_window_system): Likewise for MS-Windows.
3596 * xfns.c (check_window_system): Likewise for X.
3597 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3598 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3599
7216e43b
PE
36002013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 Prefer < to > in range checks such as 0 <= i && i < N.
3603 This makes it easier to visualize quantities on a number line.
3604 This patch doesn't apply to all such range checks,
3605 only to the range checks affected by the 2013-03-24 change.
3606 This patch reverts most of the 2013-03-24 change.
3607 * alloc.c (xpalloc, Fgarbage_collect):
3608 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3609 * character.c (string_escape_byte8):
3610 * charset.c (read_hex):
3611 * data.c (cons_to_unsigned):
3612 * dispnew.c (update_frame_1):
3613 * doc.c (Fsubstitute_command_keys):
3614 * doprnt.c (doprnt):
3615 * editfns.c (hi_time, decode_time_components):
3616 * fileio.c (file_offset):
3617 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3618 * font.c (font_intern_prop):
3619 * frame.c (x_set_alpha):
3620 * gtkutil.c (get_utf8_string):
3621 * indent.c (check_display_width):
3622 * keymap.c (Fkey_description):
3623 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3624 * lread.c (read1):
3625 * minibuf.c (read_minibuf_noninteractive):
3626 * process.c (wait_reading_process_output):
3627 * search.c (Freplace_match):
3628 * window.c (get_phys_cursor_glyph):
3629 * xdisp.c (redisplay_internal):
3630 * xsmfns.c (smc_save_yourself_CB):
3631 Prefer < to > for range checks.
3632 * dispnew.c (sit_for): Don't mishandle NaNs.
3633 This fixes a bug introduced in the 2013-03-24 change.
3634 * editfns.c (decode_time_components): Don't hoist comparison.
3635 This fixes another bug introduced in the 2013-03-24 change.
3636
92759988
DA
36372013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3638
3639 * frame.h (struct frame): Drop scroll_bottom_vpos
3640 member becaue all real users are dead long ago.
3641 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3642 * xdisp.c (redisplay_internal): Adjust user.
3643
9a1971bb
GM
36442013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3645
f38ab167
JD
3646 * nsmenu.m (showAtX:Y:for:): setLevel to
3647 NSPopUpMenuWindowLevel (Bug#13998).
3648
6d01f1fe
JD
36492013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3650
3651 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3652 (ns_check_pending_open_menu): Declare.
3653
3654 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3655 (x_activate_menubar): Update the menu with title that matches
3656 ns_get_pending_menu_title, and call
3657 ns_check_pending_openmenu (Bug#12698).
3658 (menuWillOpen:): New method.
3659 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3660
3661 * nsterm.m (menu_will_open_state, menu_mouse_point)
3662 (menu_pending_title): New varaibles.
3663 (ns_get_pending_menu_title, ns_check_menu_open)
3664 (ns_check_pending_open_menu): New functions.
3665
781f4782
DA
36662013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3667
3668 * indent.c (current_column_bol_cache): Remove leftover which is not
3669 used in Fmove_to_column any more.
3670 (current_column, scan_for_column): Adjust users.
3671 * keyboard.c (last_point_position_buffer, last_point_position_window):
3672 Remove leftovers which are not used for recording undo any more.
3673 (command_loop_1, syms_of_keyboard): Adjust users.
3674 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3675 redisplay_window any more.
3676 (move_it_to): Adjust user.
3677
1921c31b
JB
36782013-03-29 Juanma Barranquero <lekktu@gmail.com>
3679
3680 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3681 Update dependencies.
3682
717b8bcd
SM
36832013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3684
3685 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3686 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3687 forward references.
3688
e74aeda8
DA
36892013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3690
3691 * window.h (struct window): Replace hchild, vchild and buffer slots
3692 with the only contents slot. This is possible because each valid
3693 window may have either the child window (in vertical or horizontal
3694 combination) or buffer to display (for the leaf window). Using that,
3695 a lof of operations to traverse and/or change window hierarchies may
3696 be simplified. New member horizontal is used to distinguish between
3697 horizontal and vertical combinations of internal windows.
3698 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3699 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3700 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3701 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3702 Use contents slot, not buffer, where appropriate.
3703 (wset_combination): New function.
3704 (wset_buffer): Add eassert.
3705 (Fframe_first_window): Simplify the loop reaching first window.
3706 (Fwindow_buffer): Use WINDOW_LEAF_P.
3707 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3708 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3709 (unshow_buffer): Convert initial debugging check to eassert.
3710 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3711 (make_parent_window, window_resize_check, window_resize_apply)
3712 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3713 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3714 Adjust to match struct window changes.
3715 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3716 (mark_window_cursors_off, count_windows, get_leaf_windows)
3717 (foreach_window_1): Simplify the loop.
3718 * alloc.c (mark_object): Do not check for the leaf window because
3719 internal windows has no glyph matrices anyway.
3720 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3721 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3722 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3723 (build_frame_matrix_from_window_tree, mirror_make_current)
3724 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3725 (update_window_tree, set_window_update_flags): Simplify the loop.
3726 (sync_window_with_frame_matrix_rows): Enforce live window.
3727 Use contents slot, not buffer, where appropriate.
3728 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3729 and WINDOW_HORIZONTAL_COMBINATION_P.
3730 (make_frame_visible_1): Simplify the loop.
3731 Use contents slot, not buffer, where appropriate.
3732 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3733 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3734 (expose_window_tree): Likewise.
3735 Use contents slot, not buffer, where appropriate.
3736 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3737 to avoid deleted windows. Use contents slot instead of buffer.
3738 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3739 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3740 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3741 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3742
121ab1cd
EZ
37432013-03-28 Eli Zaretskii <eliz@gnu.org>
3744
ef454cf7
EZ
3745 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3746 identify the reasons for assertion violations in bug#14062 and
3747 similar ones.
21e930f8
EZ
3748 (Fx_show_tip): Fix compilation error under
3749 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3750
121ab1cd
EZ
3751 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3752 Reported by <rzl24ozi@gmail.com>.
3753
5c89ca24
DA
37542013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3755
3756 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3757 start marker...
562c6ee9
SM
3758 (unwind_with_echo_area_buffer): ...to restore it here.
3759 This is needed to ensure that...
5c89ca24
DA
3760 (redisplay_window): ...both window markers are valid here,
3761 which is verified by eassert.
3762 * editfns.c (save_excursion_save): Do not assume that
3763 selected_window always displays the buffer.
c7f53895
DA
3764 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3765 Fix comment.
5c89ca24 3766
f557c1b1
SM
37672013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3768
3769 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3770 the upcase table.
3771
40693bba 37722013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3773
3774 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3775
c86f791f
EZ
37762013-03-27 Eli Zaretskii <eliz@gnu.org>
3777
3778 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3779 since MinGW's w32api headers do. This avoids compiler warnings.
3780
3781 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3782 if already defined.
3783
c6e72e17
EZ
37842013-03-26 Eli Zaretskii <eliz@gnu.org>
3785
3786 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3787
54e95010
JD
37882013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3789
3790 * gtkutil.c (style_changed_cb): Check if frame is live and an
3791 X frame (Bug#14038).
3792
b88b62de
EZ
37932013-03-26 Eli Zaretskii <eliz@gnu.org>
3794
a18d7de6
EZ
3795 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3796 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3797 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3798 MinGW64.
8f5e14c8
EZ
3799 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3800 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3801
b88b62de
EZ
3802 Fix incompatibilities between MinGW.org and MinGW64 headers.
3803 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3804
3805 * w32.c (REPARSE_DATA_BUFFER): Guard with
3806 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3807
c074e458
JD
38082013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3809
3810 * xterm.c: Include X11/XKBlib.h
3811 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3812
908589fd
AS
38132013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3814
3815 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3816 written backwards.
3817 * blockinput.h (input_blocked_p): Likewise.
3818 * bytecode.c (exec_byte_code): Likewise.
3819 * callproc.c (call_process_kill, call_process_cleanup)
3820 (Fcall_process): Likewise.
3821 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3822 (Fccl_execute_on_string): Likewise.
3823 * character.c (string_escape_byte8): Likewise.
3824 * charset.c (read_hex): Likewise.
3825 * cm.c (calccost): Likewise.
3826 * data.c (cons_to_unsigned): Likewise.
3827 * dired.c (directory_files_internal, file_name_completion):
3828 Likewise.
3829 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3830 (sit_for): Likewise.
3831 * doc.c (Fsubstitute_command_keys): Likewise.
3832 * doprnt.c (doprnt): Likewise.
3833 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3834 * emacsgtkfixed.c: Likewise.
3835 * fileio.c (file_offset, Fwrite_region): Likewise.
3836 * floatfns.c (Fexpt, fmod_float): Likewise.
3837 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3838 Likewise.
3839 * font.c (font_intern_prop): Likewise.
3840 * frame.c (x_set_alpha): Likewise.
3841 * gtkutil.c (get_utf8_string): Likewise.
3842 * indent.c (check_display_width): Likewise.
3843 * intervals.c (create_root_interval, rotate_right, rotate_left)
3844 (split_interval_right, split_interval_left)
3845 (adjust_intervals_for_insertion, delete_node)
3846 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3847 (merge_interval_right, merge_interval_left, copy_intervals)
3848 (set_intervals_multibyte_1): Likewise.
3849 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3850 * keymap.c (Fkey_description): Likewise.
3851 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3852 * lread.c (openp, read_integer, read1, string_to_number):
3853 Likewise.
3854 * menu.c (ensure_menu_items): Likewise.
3855 * minibuf.c (read_minibuf_noninteractive): Likewise.
3856 * print.c (printchar, strout): Likewise.
3857 * process.c (create_process, Faccept_process_output)
3858 (wait_reading_process_output, read_process_output, send_process)
3859 (wait_reading_process_output): Likewise.
3860 * profiler.c (make_log, handle_profiler_signal): Likewise.
3861 * regex.c (re_exec): Likewise.
3862 * regex.h: Likewise.
3863 * search.c (looking_at_1, Freplace_match): Likewise.
3864 * sysdep.c (get_child_status, procfs_ttyname)
3865 (procfs_get_total_memory): Likewise.
3866 * systime.h (EMACS_TIME_VALID_P): Likewise.
3867 * term.c (dissociate_if_controlling_tty): Likewise.
3868 * window.c (get_phys_cursor_glyph): Likewise.
3869 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3870 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3871 Likewise.
3872 * xfns.c (Fx_window_property): Likewise.
3873 * xmenu.c (set_frame_menubar): Likewise.
3874 * xselect.c (x_get_window_property, x_handle_dnd_message):
3875 Likewise.
3876 * xsmfns.c (smc_save_yourself_CB): Likewise.
3877 * xterm.c (x_scroll_bar_set_handle): Likewise.
3878
2bf7d27a
DA
38792013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3880
3881 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3882 to be optional or nil. Adjust comment and convert it to docstring.
3883 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3884 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3885
a9ebfa0b
PE
38862013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3887
3888 Static checking by GCC 4.8-20130319.
3889 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3890 * process.c (Fset_process_datagram_address)
3891 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3892 * xdisp.c (get_char_face_and_encoding):
3893 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3894 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3895 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3896
4f3576ee
KB
38972013-03-24 Ken Brown <kbrown@cornell.edu>
3898
789b5e9a
KB
3899 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3900 fix compilation on 64-bit Cygwin, where underscores are not
3901 automatically prepended.
3902
4f3576ee
KB
3903 * w32term.c (w32_initialize): Silence compiler warning.
3904
b5b7745f
EZ
39052013-03-23 Eli Zaretskii <eliz@gnu.org>
3906
cdc0d0bd
EZ
3907 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3908 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3909 variables, to save and restore frame dimensions.
3910 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3911 after returning from a 'fullscreen' configuration.
3912 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3913 to avoid races between the main thread and the input thread.
3914
3915 * w32term.h (struct w32_output): New members normal_width,
3916 normal_height, normal_top, normal_left, and prev_fsmode.
3917 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3918 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3919 members of a frame.
3920
b5b7745f
EZ
3921 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3922 'fullscreen' parameter. Always record previous width and height
3923 of the frame, except when switching out of maximized modes, so
3924 that they could be restored correctly, instead of resetting to the
3925 default frame dimensions. Send SC_RESTORE command to the frame,
3926 unless we are going to send SC_MAXIMIZE, to restore the frame
3927 resize hints in the mouse pointer shown by the window manager.
3928 (Bug#14032)
3929
3930 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3931
3932 * lisp.h (get_frame_param): Adjust conditions for prototype
3933 declaration.
3934
a3454eed
KB
39352013-03-22 Ken Brown <kbrown@cornell.edu>
3936
3937 * unexcw.c: Drop unneeded inclusion of w32common.h.
3938 (report_sheap_usage): Declare.
3939 (read_exe_header): Add magic numbers for x86_64.
3940 (fixup_executable): Fix printf format specifier for unsigned long
3941 argument.
3942
5a49b79c
DA
39432013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3944
3945 * frame.h (struct frame): Put menu_bar_window under #ifdef
3946 because this member is not needed when X toolkit is in use.
3947 (fset_menu_bar_window):
3948 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3949 (free_glyphs, update_frame):
3950 * xdisp.c (expose_frame): Likewise.
3951 (display_menu_bar): Likewise. Remove redundant eassert.
3952 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3953 toolkit is in use.
3954
d6723bf7
PE
39552013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3956
7b1123d8
PE
3957 Use functions and constants to manipulate Lisp_Save_Value objects.
3958 This replaces code that used macros and strings and token-pasting.
3959 The change makes the C source a bit easier to follow,
3960 and shrinks the Emacs executable a bit.
3961 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3962 (make_save_value): Change 1st arg from string to enum. All callers
3963 changed.
3964 (INTX): Remove.
3965 (mark_object): Use if, not #if, for GC_MARK_STACK.
3966 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3967 (XSAVE_OBJECT): Now functions, not macros.
3968 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3969 the constant was never used.
3970 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3971 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3972 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3973 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3974 New constants.
3975 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3976 type3 with a single member save_type. All uses changed.
3977 (save_type, set_save_pointer, set_save_integer): New functions.
3978 * print.c (PRINTX): Remove.
3979
d6723bf7
PE
3980 * alloc.c: Remove redundant static declarations.
3981
5f24fa51
DA
39822013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3983
3984 * window.h (struct window): Convert left_col, top_line, total_lines
3985 and total_cols from Lisp_Objects to integers. Adjust comments.
3986 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3987 Remove.
3988 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3989 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3990 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3991 Adjust users where appropriate.
3992
42143acd
DA
39932013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3994
3995 * frame.h (struct frame): Drop resx and resy because the same data is
3996 available from window system-specific output context. Adjust users.
562c6ee9
SM
3997 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3998 New functions to provide defaults when no window system available.
42143acd 3999 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4000 (NUMVAL): Move from xdisp.c.
42143acd
DA
4001 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4002 (Ffont_face_attributes, Fopen_font):
4003 * image.c (gs_load):
4004 * w32font.c (fill_in_logfont):
4005 * xdisp.c (calc_pixel_width_or_height):
4006 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4007 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4008
c0a17406
KH
40092013-03-20 Kenichi Handa <handa@gnu.org>
4010
4011 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4012 to 1 (temporary workaround until a bug related to ASCII
4013 optimization is fixed).
4014
095d384d
DA
40152013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4016
4017 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4018 Signal error if window is not internal. Adjust docstring.
4019 (delete_all_child_windows): Use combination_limit to save the buffer.
4020 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4021 * print.c (syms_of_print): Initialize debugging output not here...
4022 (init_print_once): ...but in a new function here.
4023 * lisp.h (init_print_once): Add prototype.
4024 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4025
748fa866
DA
40262013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4027
4028 * window.c (window_resize_check, window_resize_apply)
4029 (window_from_coordinates, recombine_windows, set_window_buffer)
4030 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4031 (Fsplit_window_internal, Fdelete_window_internal)
4032 (freeze_window_starts): Use bool for booleans.
4033 * window.h (window_frame_coordinates, resize_frame_windows)
4034 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4035
81519fd2
SM
40362013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4037
4038 * dispnew.c (bitch_at_user): Use `user-error'.
4039
6db423a9
KB
40402013-03-17 Ken Brown <kbrown@cornell.edu>
4041
4042 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4043 as return type of image_background. (Bug#13981)
4044 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4045
8f2906f5
JD
40462013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4047
960ce480 4048 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4049 (ns_select): Don't return with result uninitialized.
960ce480 4050
8f2906f5
JD
4051 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4052 and getDirectory.
4053
81519fd2
SM
4054 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4055 New functions.
8f2906f5
JD
4056 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4057 directories. If filename is nil, get directory name (Bug#13932).
4058 Use getFilename and getDirectory.
4059 (getFilename, getDirectory): New methods for EmacsSavePanel and
4060 EmacsOpenPanel.
4061 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4062
cded56c1
PE
40632013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4064
4065 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4066
251e9147 40672013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4068
4069 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4070 (adjust_after_replace): Make it back to static. Delete the third
4071 arg text_at_gap_tail. Cancel the code for handling it.
4072
4073 * coding.h (struct coding_system): New member eol_seen.
4074
4075 * coding.c (detect_ascii): New function.
4076 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4077 when the source bytes are actually scanned. On detecting for
4078 coding_category_utf_8_auto, call detect_ascii instead of scanning
4079 source bytes directly.
4080 (produce_chars): Call insert_from_gap with the new arg 0.
4081 (encode_coding): Likewise.
4082 (decode_coding_gap): Control ASCII optimization by the variable
4083 disable_ascii_optimization instead of #ifndef .. #endif.
4084 Deccode EOL format according to coding->eol_seen.
4085 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4086 variable.
4087
8a44e6d1
KH
4088 * lisp.h (adjust_after_replace): Cancel externing it.
4089 (insert_from_gap): Adjust prototype.
4090
5f795e34
EZ
40912013-03-15 Eli Zaretskii <eliz@gnu.org>
4092
4093 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4094 FULLSCREEN_MAXIMIZED. (Bug#13935)
4095
f258b4be
DA
40962013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4097
4098 * region-cache.c (find_cache_boundary, move_cache_gap)
4099 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4100 Simplify debugging check and convert to eassert. Adjust comment.
4101 (pp_cache): Put under ENABLE_CHECKING.
4102
a5cc4dde
EZ
41032013-03-14 Eli Zaretskii <eliz@gnu.org>
4104
4105 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4106 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4107 and WM_ACTIVATEAPP.
4108 (w32fullscreen_hook): If the frame is visible, reset
4109 f->want_fullscreen flag after changing the frame size. If the
4110 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4111 (Bug#13953)
4112
3fc5e44a
DC
41132013-03-13 Daniel Colascione <dancol@dancol.org>
4114
4115 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4116 too so that these builds can use Cygwin's file conversion
4117 functions. (We've been building and linking cygw32.o all along
4118 and just not using it.)
4119
47d7532e
PE
41202013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4121
4122 File synchronization fixes (Bug#13944).
4123 * Makefile.in (LIB_FDATASYNC): New macro.
4124 (LIBES): Use it.
4125 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4126 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4127 Don't worry about HAVE_FSYNC, since a substitute fsync is
4128 available if the system lacks one.
4129 (Fwrite_regin): Retry fsync if interrupted.
4130
c7ffccaf
EZ
41312013-03-13 Eli Zaretskii <eliz@gnu.org>
4132
4e2df81d 4133 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4134 activated, call w32fullscreen_hook, to make sure the new frame
4135 dimensions are in effect. (Bug#13937)
4136
8a7debc1
DA
41372013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4138
4139 * xdisp.c (init_iterator): Simplify because both character and byte
4140 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4141 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4142 character and byte positions can be obtained from marker.
8a7debc1 4143
7fd8c501
PE
41442013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4145
d9df6f40
PE
4146 Static checking by Sun C 5.12.
4147 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4148 * bytecode.c (exec_byte_code):
4149 * dispnew.c (init_display):
4150 * eval.c (error):
4151 * fileio.c (Fsubstitute_in_file_name):
4152 * keyboard.c (Fevent_convert_list):
4153 * keymap.c (Fsingle_key_description):
4154 * term.c (maybe_fatal, fatal):
4155 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4156 * xsmfns.c (Fhandle_save_session):
4157 Omit unreachable code.
4158 * keymap.c (map_keymap_char_table_item): Cast void * to
4159 a function pointer type; the C Standard requires this.
4160
7fd8c501
PE
4161 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4162 Include <sys/param.h> unconditionally, as that works elsewhere and
4163 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4164 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4165 and FreeBSD now.
4166
a020afb9 4167See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4168
4169;; Local Variables:
4170;; coding: utf-8
aac0c6e3
MR
4171;; End:
4172
ab422c4d 4173 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4174
4175 This file is part of GNU Emacs.
4176
4177 GNU Emacs is free software: you can redistribute it and/or modify
4178 it under the terms of the GNU General Public License as published by
4179 the Free Software Foundation, either version 3 of the License, or
4180 (at your option) any later version.
4181
4182 GNU Emacs is distributed in the hope that it will be useful,
4183 but WITHOUT ANY WARRANTY; without even the implied warranty of
4184 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4185 GNU General Public License for more details.
4186
4187 You should have received a copy of the GNU General Public License
4188 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.