* lisp.h (eassert): Don't use 'assume'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0d5d3029
PE
12013-10-09 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lisp.h (eassert): Don't use 'assume'.
4 Sometimes 'assume' wins in performance, and sometimes it loses,
5 so it shouldn't be used all the time. Perhaps we need two
6 flavors of 'eassert', one for where 'assume' is far more likely
7 to help or to hurt; but that can be done later.
8 Problem reported by Dmitry Andipov in
9 <http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00276.html>.
10 Also, don't include <verify.h>; no longer needed.
11
fa022909
GM
122013-10-09 Glenn Morris <rgm@gnu.org>
13
14 * eval.c (Fcond): Doc tweak.
15
051277bf
EZ
162013-10-09 Eli Zaretskii <eliz@gnu.org>
17
18 * xfaces.c (x_free_gc) [HAVE_X_WINDOWS, HAVE_NTGUI]: Don't pass
19 expressions with side effects to eassert. (Bug#15565)
20
79804536
SM
212013-10-09 Stefan Monnier <monnier@iro.umontreal.ca>
22
23 * fns.c (hashfn_user_defined): Allow hash functions to return any
24 Lisp_Object.
25
3b158d11
PE
262013-10-08 Paul Eggert <eggert@cs.ucla.edu>
27
28 Fix minor problems found by static checking.
29 * dispnew.c (save_current_matrix): Omit unnecessary casts.
30 * dispnew.c (update_frame_with_menu): Mark debug local as used.
31 * keyboard.c, keyboard.h (Qmouse_movement): Now static.
32 * keyboard.c (read_menu_command): Remove unused local.
33 * lisp.h (read_menu_command): New decl.
34 * menu.c, menu.h (menu_item_width): Arg is now unsigned char *, for
35 benefit of STRING_CHAR_AND_LENGTH. All uses changed.
36 Return ptrdiff_t, not int.
37 * term.c (tty_menu_struct): 'allocated' member is now ptrdiff_t,
38 not int, for benefit of xpalloc.
39 (tty_menu_create, tty_menu_make_room): Simplify by using xzalloc
40 and xpalloc.
41 (have_menus_p): Remove; unused.
42 (tty_menu_add_pane, tty_menu_add_selection): Change signedness of
43 local char * pointer to pacify STRING_CHAR_AND_LENGTH.
44 (tty_menu_add_selection, tty_menu_locate, tty_meny_destroy):
45 Now static.
46 (save_and_enable_current_matrix): Omit unnecessary casts.
47 (read_menu_input): Omit local extern decl (now in lisp.h).
48 Don't access uninitialized storage if mouse_get_xy fails.
49 (tty_menu_activate): Mark local as initialized, for lint.
50 (tty_menu_activate, tty_meny_show): Remove unused locals.
51
4ed77415
EZ
522013-10-08 Eli Zaretskii <eliz@gnu.org>
53
54 Support menus on text-mode terminals.
55 * xterm.h (xw_popup_dialog): Add prototype.
56
57 * xmenu.c (Fx_popup_dialog): Function moved to menu.c.
58 (xmenu_show): Block input here, instead in Fx_popup_menu.
59 (xw_popup_dialog): New function, with X-specific bits of popup
60 dialogs.
61
62 * xdisp.c (deep_copy_glyph_row, display_tty_menu_item): New
63 functions.
64
65 * window.c (Fset_window_configuration): Use run-time tests of the
66 frame type instead of compile-time conditionals, when menu-bar
67 lines are considered.
68
69 * w32term.h (w32con_hide_cursor, w32con_show_cursor)
70 (w32_popup_dialog): New prototypes.
71
72 * w32menu.c (Fx_popup_dialog): Function deleted.
73 (w32_popup_dialog): New function, with w32 specific bits of popup
74 dialogs. Block input here.
75
76 * w32inevt.c (w32_console_read_socket): Minor change to add
77 debugging TTY events.
78
79 * w32fns.c (show_hourglass): If returning early because the frame
80 is not a GUI frame, unblock input.
81
82 * w32console.c (w32con_hide_cursor, w32con_show_cursor, cursorX)
83 (cursorY): New functions.
84
85 * termhooks.h (cursorX, cursorY): Prototypes of functions on
86 WINDOWSNT, macros that call curX and curY elsewhere.
87
88 * termchar.h (struct tty_display_info) <showing_menu>: New flag.
89
90 * term.c (tty_hide_cursor, tty_show_cursor) [WINDOWSNT]: Call w32
91 specific function to hide and show cursor on a text-mode terminal.
92 (tty_menu_struct, struct tty_menu_state): New structures.
93 (tty_menu_create, tty_menu_make_room, tty_menu_search_pane)
94 (tty_menu_calc_size, mouse_get_xy, tty_menu_display)
95 (have_menus_p, tty_menu_add_pane, tty_menu_add_selection)
96 (tty_menu_locate, save_and_enable_current_matrix)
97 (restore_desired_matrix, screen_update, read_menu_input)
98 (tty_menu_activate, tty_menu_destroy, tty_menu_help_callback)
99 (tty_pop_down_menu, tty_menu_last_menubar_item)
100 (tty_menu_new_item_coords, tty_menu_show): New functions.
101 (syms_of_term): New DEFSYMs for tty-menu-* symbols.
102
103 * nsterm.h (ns_popup_dialog): Adjust prototype.
104
105 * nsmenu.m (ns_menu_show): Block and unblock input here, instead
106 of in x-popup-menu.
107 (ns_popup_dialog): Adapt order of arguments to the other
108 *_menu_show implementations.
109 (Fx_popup_dialog): Function deleted.
110
111 * msdos.c (x_set_menu_bar_lines): Delete unused function.
112
113 * menu.h (tty_menu_show, menu_item_width): provide prototypes.
114
115 * menu.c (have_boxes): New function.
116 (single_keymap_panes): Use it instead of a compile-time
117 conditional.
118 (single_menu_item): Use run-time tests of the frame type instead
119 of compile-time conditionals.
120 (encode_menu_string): New function.
121 (list_of_items, list_of_panes): Use it instead of ENCODE_STRING
122 the macro, since different types of frame need different encoding
123 of menu items.
124 (digest_single_submenu): Use run-time tests of frame type instead
125 of, or in addition to, compile-time conditionals.
126 (menu_item_width, Fmenu_bar_menu_at_x_y): New functions.
127 (Fx_popup_menu): Detect when the function is called from keyboard
128 on a TTY. Don't barf when invoked on a text-mode frame. Check
129 frame type at run time, instead of compile-time conditionals for
130 invoking terminal-specific menu-show functions. Call
131 tty_menu_show on text-mode frames.
132 (Fx_popup_dialog): Moved here from xmenu.c. Test frame types at
133 run time to determine which alternative to invoke; support dialogs
134 on TTYs.
135
136 * keyboard.h <Qmouse_movement>: Declare.
137
138 * keyboard.c <Qmouse_movement>: Now extern.
139 <Qecho_keystrokes>: New static variable.
140 (read_key_sequence): Accept an additional argument, a flag to
141 prevent redisplay during reading of the key sequence. All callers
142 changed.
143 (read_menu_command): New function.
144 (read_char): When COMMANDFLAG is -2, do not redisplay and do not
145 autosave.
146 (toolkit_menubar_in_use): New function.
147 (make_lispy_event): Use it instead of a compile-time test.
148
149 * fns.c (Fyes_or_no_p) [HAVE_MENUS]: Don't condition on
150 window-system being available.
151
152 * editfns.c (Fmessage_box) [HAVE_MENUS]: Don't condition the call
153 to x-popup-dialog on the frame type, they all now support popup
154 dialogs.
155
156 * dispnew.c (save_current_matrix): Save the margin areas.
157 (restore_current_matrix): Restore margin areas.
158 (update_frame_with_menu): New function.
159
160 * dispextern.h (display_tty_menu_item, update_frame_with_menu):
161 Add prototypes.
162
163 * alloc.c (make_save_ptr): Now compiled unconditionally.
164
ecab13d4
DA
1652013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
166
167 * dispnew.c (set_window_update_flags): Add buffer arg. Adjust comment.
168 (redraw_frame, update_frame): Adjust users.
169 * dispextern.h (set_window_update_flags): Adjust prototype.
170 * xdisp.c (redisplay_internal): When updating all frames with zero
171 windows_or_buffers_changed, assume that only the windows that shows
172 current buffer should be really updated.
173
f8498081
DA
1742013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Do not allocate huge temporary memory areas and objects while encoding
177 for file I/O, thus reducing an enormous memory usage for large buffers.
178 See http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00180.html.
179 * coding.h (struct coding_system): New member raw_destination.
180 * coding.c (setup_coding_system): Initialize it to zero.
181 (encode_coding_object): If raw_destination is set, do not create
182 dst_object. Add comment.
183 * fileio.c (toplevel): New constant E_WRITE_MAX.
184 (e_write): Do not encode more than E_WRITE_MAX characters per one loop
185 iteration. Use raw_destination if E_WRITE_MAX characters is encoded.
186
d180bde8
JD
1872013-10-08 Jan Djärv <jan.h.d@swipnet.se>
188
189 * nsterm.m (windowDidExitFullScreen:):
190 (toggleFullScreen:): Change NS_IMPL_COCOA to HAVE_NATIVE_FS.
191
87c4314d
PE
1922013-10-08 Paul Eggert <eggert@cs.ucla.edu>
193
18978362
PE
194 Fix race where emacs aborts when sent SIGTERM (Bug#15534).
195 * keyboard.c (unblock_input_to): Don't process pending signals
196 if a fatal error is in progress.
197
87c4314d
PE
198 * lisp.h (bits_word, BITS_WORD_MAX): New type and macro.
199 All uses of 'size_t' and 'SIZE_MAX' changed to use them, when
200 they're talking about words in Lisp bool vectors.
201 (BITS_PER_BITS_WORD): Rename from BITS_PER_SIZE_T. All uses changed.
1142cc2a
PE
202 * data.c (popcount_bits_word): Rename from popcount_size_t.
203 (bits_word_to_host_endian): Rename from size_t_to_host_endian.
204 All uses changed.
87c4314d 205
595e113b
PE
2062013-10-07 Paul Eggert <eggert@cs.ucla.edu>
207
208 Improve support for popcount and counting trailing zeros (Bug#15550).
209 * data.c: Include <count-one-bits.h>, <count-trailing-zeros.h>.
210 (USE_MSC_POPCOUNT, POPCOUNT_STATIC_INLINE)
211 (NEED_GENERIC_POPCOUNT, popcount_size_t_generic)
212 (popcount_size_t_msc, popcount_size_t_gcc):
213 Remove; now done by Gnulib.
214 (popcount_size_t): Now a macro that defers to Gnulib.
215 (count_trailing_zero_bits): Return int, for consistency with
216 Gnulib and because Emacs prefers signed to unsigned int.
217 Don't assume that size_t is either unsigned int or unsigned long
218 or unsigned long long.
219 (size_t_to_host_endian): Do not assume that size_t is either
220 exactly 32 or exactly 64 bits wide.
221 * lisp.h (BITS_PER_SIZE_T): Define consistently with BITS_PER_LONG
222 etc., so that it's now an enum constant, not a macro.
223 No need to assume that it's either 32 or 64.
224
ddb317ba
JD
2252013-10-07 Jan Djärv <jan.h.d@swipnet.se>
226
227 * nsterm.m (windowDidEnterFullScreen:): setPresentationOptions only
228 on >= 10.7.
229
bd74250f
DA
2302013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
231
232 * insdel.c (insert_from_gap): Prefer ptrdiff_t to int where needed.
764636db 233 * xdisp.c (handle_fontified_prop): Likewise. Use bool for boolean.
bd74250f 234
223752d7
PE
2352013-10-07 Paul Eggert <eggert@cs.ucla.edu>
236
237 emacs_read and emacs_write now use void *, not char *.
238 * alloc.c (valid_pointer_p) [!WINDOWSNT]: Remove now-unnecessary cast.
239 * sysdep.c (emacs_read, emacs_write, emacs_write_sig):
240 Buffer arg is now void *, not char *. This matches plain
241 'read' and 'write' better, and avoids a constraint violation
242 on Solaris 9 with Oracle Studio.
243
3c439e0a
DA
2442013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
245
246 * alloc.c (Fmake_string): For ASCII char initializer, prefer
247 memset to explicit loop. Otherwise copy largest possible chunk
248 from initialized to uninitialized part, thus allowing the longer
249 memcpy runs and reducing the number of loop iterations.
250
28c76099
JD
2512013-10-06 Jan Djärv <jan.h.d@swipnet.se>
252
253 * nsterm.m (ns_update_begin): If native fullscreen and no toolbar,
254 hide toolbar (Bug#15388).
255 (windowDidEnterFullScreen:): If presentation options are zero,
256 set them here (Bug#15388).
a3e9050c
JD
257 (ns_update_auto_hide_menu_bar): Remove runtime check.
258 Don't auto hide dock unless menubar is also auto hidden.
28c76099 259
544a2a80
XF
2602013-10-05 Xue Fuqiao <xfq.free@gmail.com>
261
262 * editfns.c (message): Mention batch mode in doc string.
263
a27fd309
JD
2642013-10-05 Jan Djärv <jan.h.d@swipnet.se>
265
266 * nsterm.m (check_native_fs): Remove erroneous comment.
267
942f6f82
DA
2682013-10-04 Dmitry Antipov <dmantipov@yandex.ru>
269
270 * xdisp.c (redisplay_internal): Simplify because scan_for_column now
271 uses find_newline instead of scan_newline and so doesn't move point.
272
157fec2e
PE
2732013-10-04 Paul Eggert <eggert@cs.ucla.edu>
274
4eed3157
PE
275 Use hardware support for byteswapping on glibc x86 etc.
276 On Fedora 19 x86-64, the new bswap_64 needs 1 instruction,
277 whereas the old swap64 needed 30.
278 * fringe.c (init_fringe_bitmap) [WORDS_BIGENDIAN]:
279 * sound.c (le2hl, le2hs, be2hl) [!WINDOWSNT]:
280 Use byteswap.h's macros to swap bytes.
281 * lisp.h (swap16, swap32, swap64): Remove.
282 All uses replaced by bswap_16, bswap_32, bswap_64.
283
157fec2e
PE
284 * bytecode.c (exec_byte_code): Use some more volatile variables
285 to work around local variables getting clobbered by longjmp.
286 Port to pre-C99, which doesn't allow decls after stmts.
287
b52f569d
PE
2882013-10-03 Paul Eggert <eggert@cs.ucla.edu>
289
75273afb
PE
290 * lisp.h (eassert): Assume that COND is true when optimizing.
291 In other words, take on the behavior of eassert_and_assume.
292 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
293 (eassert_and_assume): Remove. All uses replaced by eassert.
294
ead45345
PE
295 * xdisp.c (Qglyphless_char): Now static.
296
0a858ebf
PE
297 Adjust to merge from gnulib.
298 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
299 * lisp.h: Include <verify.h>, for 'assume'.
300
b52f569d
PE
301 * eval.c (clobbered_eassert): New macro.
302 (internal_catch, internal_condition_case)
303 (internal_condition_case_1, internal_condition_case_2)
304 (internal_condition_case_n): Use it instead of eassert
305 when the argument contains locals clobbered by longjmp.
306 Don't use clobbered locals outside of clobbered_eassert.
307 (internal_lisp_condition_case): Use a volatile variable
308 to work around a local variable's getting clobbered.
309
adf2aa61
SM
3102013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
311
312 * lisp.h (struct handler): Merge struct handler and struct catchtag.
313 (PUSH_HANDLER): New macro.
314 (catchlist): Remove.
315 (handlerlist): Always declare.
316
317 * eval.c (catchlist): Remove (merge with handlerlist).
318 (handlerlist, lisp_eval_depth): Not static any more.
319 (internal_catch, internal_condition_case, internal_condition_case_1)
320 (internal_condition_case_2, internal_condition_case_n):
321 Use PUSH_HANDLER.
322 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
323 handlerlist/catchlist.
324 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
325 handlerlist which can only handle a single condition-case handler at
326 a time.
327 (find_handler_clause): Simplify since we only a single branch here
328 any more.
329
330 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
331 and Bpophandler.
332 (bcall0): New function.
333 (exec_byte_code): Add corresponding cases. Improve error message when
334 encountering an invalid byte-code. Let Bunwind_protect accept
335 a function (rather than a list of expressions) as argument.
336
337 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
338 and make them unconditional now that they're heap-allocated.
339
328a8179
SM
3402013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
341
342 * charset.c (Fdecode_char, Fencode_char): Remove description of
343 `restriction' arg. now that it's hidden by advertised-calling-convention.
344
c348360a
JD
3452013-10-02 Jan Djärv <jan.h.d@swipnet.se>
346
328a8179
SM
347 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
348 Remove unused variable (from mac-port).
c348360a
JD
349 (macfont_draw): Use s->ybase for correct y position.
350
1a23cd48
DA
3512013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
352
353 * frame.h (struct frame): Drop has_minibuffer member because...
354 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
355 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
356
29bf4de4
DA
3572013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
358
359 * window.h (struct window): Prefer enum text_cursor_kinds to int
360 for phys_cursor_type member. Move the latter, phys_cursor_width,
361 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
362 * window.c (replace_window, make_window): Adjust users.
363
a30ddace
DA
3642013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
365
366 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
367 this module is never compiled otherwise.
368
45435f08
AA
3692013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
370
371 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
372 (Bug#15500).
373
92e5298b
EZ
3742013-09-29 Eli Zaretskii <eliz@gnu.org>
375
376 * xdisp.c (get_next_display_element): Don't call face_for_font in
377 a build configured --without-x. (Bug#15484)
378
caa50be2
JD
3792013-09-29 Jan Djärv <jan.h.d@swipnet.se>
380
66d13b20
JD
381 * window.c (calc_absolute_offset): #elif should be #elif defined.
382
caa50be2
JD
383 * frame.c (delete_frame): Block/unblock input to overcome race
384 condition (Bug#15475).
385
d3e2acb6
AP
3862013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
387
388 * frame.c (delete_frame): Record selected frame only after
389 calling Qdelete_frame_functions (Bug#15477).
390
1610938f
JD
3912013-09-28 Jan Djärv <jan.h.d@swipnet.se>
392
393 * nsterm.m (ns_selection_color): Remove.
394 (ns_get_color): Check for ns_selection_(fg|bg)_color using
395 NSColor selectedText(Background)Color. Only for COCOA.
396 (ns_term_init): Remove assignment of ns_selection_color, logic
397 moved to ns_get_color.
398
328a8179 399 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
400 NS_SELECTION_COLOR_DEFAULT.
401 (NS_SELECTION_FG_COLOR_DEFAULT): New.
402
0d2647e6
EZ
4032013-09-28 Eli Zaretskii <eliz@gnu.org>
404
405 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
406 frame' does not have the tool_bar_window member.
407
ba355de0
BR
4082013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
409
410 Signal error when reading an empty byte-code object (Bug#15405)
411 * lread.c (read1): signal error
412 * alloc.c (make_byte_code): eassert header size
413 (sweep_vectors): change an int to size_t
414
4710d6f4
PE
4152013-09-24 Paul Eggert <eggert@cs.ucla.edu>
416
cf647d93
PE
417 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
418 instead of ints, as it's the usual style for offsetof constants. See:
419 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
420
4710d6f4
PE
421 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
422 This is ugly, but it should fix the performance problem for older
423 GCC versions in the short run. I'll look into integrating the
424 Gnulib module for popcount, as a better fix.
425 See the thread starting in:
426 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
427 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
428 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
429 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
430 (popcount_size_t): Use it.
431
10ebac9d
DC
4322013-09-24 Daniel Colascione <dancol@dancol.org>
433
434 * process.c (Fnetwork_interface_info): Fix build break due to
435 vector changes.
436
9da0f50e
PE
4372013-09-24 Paul Eggert <eggert@cs.ucla.edu>
438
439 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
440 Prefer signed to unsigned integers where either will do.
441 No need for 'const' on locals that do not escape.
442 Omit easserts with unnecessary and unportable assumptions about
443 alignment. Avoid unnecessary casts to char *.
444
d6d9cbc1
DA
4452013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
446
447 Use union for the payload of struct Lisp_Vector.
448 This helps to avoid a few glitches dictated by C's aliasing rules.
449 * lisp.h (struct Lisp_Vector): Use union for next and
450 contents member. Adjust comment. Change related users.
451 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
452 Related users changed.
453 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
454 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
455 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
456 * xfaces.c, xfont.c, xmenu.c: Related users changed.
457
ec7bc82f
DA
4582013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
459
460 Optimize glyph row clearing and copying routines.
461 * dispextern.h (struct glyph_row): Change layout of struct
462 glyph_row to help copy_row_except_pointers. Adjust comment.
463 * dispnew.c (null_row): Remove.
464 (clear_glyph_row): Use offsetof and memset to find and clear
465 just the members that need clearing. Adjust comment.
466 (copy_row_except_pointers): Likewise for copying.
467
d160dd0c
PE
4682013-09-24 Paul Eggert <eggert@cs.ucla.edu>
469
7be68de5
PE
470 Some minor cleanups of recently-added bool vector code.
471 * conf_post.h (assume): Always return void. Use lint version
472 only if GCC and MSC versions don't apply.
473 * conf_post.h (assume):
474 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
475 Depend on _MSC_VER, not __MSC_VER, for consistency with
476 the rest of Emacs.
477 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
478 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
479 (bool_vector_binop_driver, count_trailing_zero_bits)
480 (size_t_to_host_endian): Now static, not static inline;
481 the latter isn't needed with modern compilers and doesn't
482 work with older compilers anyway.
483
d160dd0c
PE
484 * alloc.c (valgrind_p): Use bool for boolean.
485
e08813d0
DA
4862013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
487
488 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
489 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
490 (display_last_displayed_message_p, message_buf_print)
491 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
492 Use bool for boolean.
3a6a78fd
DA
493 * dispextern.h (cancel_line, init_desired_glyphs):
494 Remove ancient leftover.
495 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
496 * lisp.h (noninteractive_need_newline): Adjust declaration.
497
5492865b
DA
4982013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
499
500 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
501 Move to...
502 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
503 ...this file and convert the latter to static. Adjust comment.
504 (make_initial_frame):
505 * window.c (init_window_once): Adjust user.
506 * frame.h (last_nonminibuf_frame): Remove declaration.
507 * lisp.h (selected_frame): Likewise.
508 * msdos.c (the_only_display_info): Adjust comment.
509
cd548fa4
EZ
5102013-09-23 Eli Zaretskii <eliz@gnu.org>
511
f03eddbf
EZ
512 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
513 computing the end column of mouse-highlight that comes from
514 display or overlay strings. (Bug#15437)
b519df23
EZ
515 (note_mouse_highlight): Adapt calculation of last argument to
516 mouse_face_from_string_pos to the above change.
f03eddbf 517
cd548fa4
EZ
518 * conf_post.h (__has_builtin): Define to zero, if undefined, on
519 all platforms, not just for clang.
520
8762e524
JD
5212013-09-23 Jan Djärv <jan.h.d@swipnet.se>
522
523 * filelock.c (lock_file_1): Rearrange to remove compiler warning
524 about excess arguments to snprintf.
525
526 * conf_post.h(assume): Use __builtin_unreachable for clang.
527
d4a9284f
JB
5282013-09-23 Juanma Barranquero <lekktu@gmail.com>
529
530 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
531 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
532
a84683fd
DC
5332013-09-23 Daniel Colascione <dancol@dancol.org>
534
535 * alloc.c (USE_VALGRIND): New macro; on by default
536 when ENABLE_CHECKING.
537 (mark_maybe_object,mark_maybe_pointer)
538 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
539 valgrind purposes.
540 (valgrind_p) [USE_VALGRIND]: New variable.
541 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
542
8fef36c6
JD
5432013-09-22 Jan Djärv <jan.h.d@swipnet.se>
544
fb83ea63
JD
545 * process.c (wait_reading_process_output): Change int pnamelen to
546 socklen_t.
547
548 * nsterm.m (setMarkedText:selectedRange:):
549 (deleteWorkingText):
550 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
551 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
552 argument to unsigned long to avoid warning.
553 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
554
8fef36c6
JD
555 * conf_post.h (assume): Fix compiler error: x shall be cond.
556
cd9356f2
DC
5572013-09-22 Daniel Colascione <dancol@dancol.org>
558
559 * xfns.c (x_get_monitor_attributes): Suppress unused variable
560 warning when compiling without a window system.
561
3e0b94e7
DC
5622013-09-22 Daniel Colascione <dancol@dancol.org>
563
564 * data.c (Qbool_vector_p): New symbol.
565 (bool_vector_spare_mask,popcount_size_t_generic)
566 (popcount_size_t_msc,popcount_size_t_gcc)
567 (popcount_size_t)
568 (bool_vector_binop_driver)
569 (count_trailing_zero_bits,size_t_to_host_endian)
570 (Fbool_vector_exclusive_or)
571 (Fbool_vector_union)
572 (Fbool_vector_intersection,Fbool_vector_set_difference)
573 (Fbool_vector_subsetp,Fbool_vector_not)
574 (Fbool_vector_count_matches)
575 (Fbool_vector_count_matches_at): New functions.
576 (syms_of_data): Intern new symbol, functions.
577 * alloc.c (bool_vector_payload_bytes): New function.
578 (Fmake_bool_vector): Instead of calling Fmake_vector,
579 which performs redundant initialization and argument checking,
580 just call allocate_vector ourselves. Make sure we clear any
581 terminating padding to zero.
582 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
583 instead of open-coding the size calculation.
584 (vroundup_ct): New macro.
585 (vroundup): Assume argument >= 0; invoke vroundup_ct.
586 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
587 * composite.c (composition_gstring_put_cache):
588 Change lint_assume to assume.
3e0b94e7
DC
589 * conf_post.h (assume): New macro.
590 (lint_assume): Remove.
591 * dispnew.c (update_frame_1): Change lint_assume to assume.
592 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
593 to assume.
594 * image.c (gif_load): Change lint_assume to assume.
595 * lisp.h (eassert_and_assume): New macro.
596 (Qbool_vector_p): Declare.
597 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
598 (swap16,swap32,swap64): New inline functions.
599 * macfont.c (macfont_shape): Change lint_assume to assume.
600 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
601 * xsettings.c (parse_settings): Use new swap16 and
602 swap32 from lisp.h instead of file-specific macros.
603
76880d88
EZ
6042013-09-22 Eli Zaretskii <eliz@gnu.org>
605
606 * xdisp.c (try_window_id): Don't abort if cursor row could not be
607 found (which can legitimately happen when the glyph row at the
608 window start is disabled in the current_matrix. (Bug#15365)
609
c6cfd910
PE
6102013-09-22 Paul Eggert <eggert@cs.ucla.edu>
611
612 Fix syntax.h bug introduced by recent INLINE change.
613 syntax.h defined an extern inline function SYNTAX_ENTRY that was
614 conditionally compiled one way in some modules, and a different
615 way in others. This doesn't work with extern inline functions,
616 which must have the same definition in all modules, because the
617 defining code might be shared across modules, depending on the
618 implementation. Symptoms reported by Martin Rudalics in:
619 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
620 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
621 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
622 overriding the corresponding functions in syntax.h.
623 * syntax.h (syntax_property_entry, syntax_property_with_flags)
624 (syntax_property): New inline functions.
625 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
626 Rewrite in terms of these new functions.
627
b3f1d119
EZ
6282013-09-21 Eli Zaretskii <eliz@gnu.org>
629
630 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
631 not chars_in_text, whose result depends on the multibyteness of
632 the current buffer. (Bug#15426)
633
00382e8b
PE
6342013-09-20 Paul Eggert <eggert@cs.ucla.edu>
635
e3b29769
PE
636 Port recent change to hosts where pointers aren't 'long'.
637 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
638 Don't assume that pointers are the same width as 'long'.
639 Add a compile-time check that a pointer fits into two X slots.
640
00382e8b
PE
641 A simpler, centralized INLINE.
642 * conf_post.h (INLINE): Define only if not already defined.
643 This allows us to use a single INLINE, defined by one file
644 per executable.
645 * emacs.c (INLINE): Define it.
646 Also, include category.h, charset.h, composite.h, dispextern.h,
647 syntax.h, systime.h, so that their INLINE definitions are expanded
648 properly for Emacs.
649 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
650 * buffer.h, buffer.c (BUFFER_INLINE):
651 * category.h, category.c (CATEGORY_INLINE):
652 * character.h, character.c (CHARACTER_INLINE):
653 * charset.h, charset.c (CHARSET_INLINE):
654 * composite.h, composite.c (COMPOSITE_INLINE):
655 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
656 * frame.h, frame.c (FRAME_INLINE):
657 * intervals.h, intervals.c (INTERVALS_INLINE):
658 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
659 * lisp.h, alloc.c (LISP_INLINE):
660 * process.h, process.c (PROCESS_INLINE):
661 * syntax.h, syntax.c (SYNTAX_INLINE):
662 * systime.h, sysdep.c (SYSTIME_INLINE):
663 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
664 * window.h, window.c (WINDOW_INLINE):
665 Remove. All uses replaced with INLINE.
666
2b943ba6
DA
6672013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
668
669 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
670 to avoid Bug#15398.
671
13d9698a
EZ
6722013-09-19 Eli Zaretskii <eliz@gnu.org>
673
674 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
675 'const char *' to avoid compiler warnings due to similar change in
676 the prototype of x_get_string_resource.
677
ced135eb
DA
6782013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
679
680 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
681 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
682 going to replace static variables below. Adjust comments.
683 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
684 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
685 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
686 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
687 Related users changed.
688 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
689 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
690 last_mouse_movement_time, going to replace static variables below.
691 Adjust comments.
692 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
693 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
694 Remove.
695 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
696 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
697 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
698 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
699 static variables below.
700 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
701 (last_mouse_scroll_bar): Remove.
702 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
703 (mouseExited): Related users changed.
704
091f1e1f
DA
7052013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
706
707 Do not use external array to process X scroll bar messages.
708 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
709 (x_send_scroll_bar_event): Pack window pointer into two slots
710 of XClientMessageEvent if we're 64-bit. Adjust comment.
711 (x_scroll_bar_to_input_event): Unpack accordingly.
712
582ed56c
DA
7132013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
714
715 Ifdef away recent changes which aren't relevant to NS port.
716 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
717 [!HAVE_NS]: Declare as such.
718 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
719 [!HAVE_NS]: Define as such.
720
18da0d8a
DA
7212013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
722
723 * frame.c (x_redo_mouse_highlight): New function
724 to factor out common code used in W32 and X ports.
725 * dispextern.h (x_redo_mouse_highlight): Add prototype.
726 * xterm.h (struct x_display_info):
727 * w32term.h (struct w32_display_info):
728 * nsterm.h (struct ns_display_info): New members
729 last_mouse_motion_frame, last_mouse_motion_x and
730 last_mouse_motion_y, going to replace static variables below.
731 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
732 (redo_mouse_highlight): Remove.
733 (note_mouse_movement, syms_of_xterm): Adjust user.
734 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
735 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
736 (redo_mouse_highlight): Remove.
737 (note_mouse_movement, syms_of_w32term): Adjust user.
738 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
739 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
740 Remove.
741 (note_mouse_movement, mouseMoved, syms_of_nsterm):
742 * nsfns.m (compute_tip_xy): Adjust user.
743
7a0c745a
DA
7442013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
745
746 * frame.c (x_mouse_grabbed): New function.
747 * dispextern.h (x_mouse_grabbed): Add prototype.
748 (last_mouse_frame): Remove declaration.
749 * xterm.h (struct x_display_info):
750 * w32term.h (struct w32_display_info):
751 * nsterm.h (struct ns_display_info): New member
752 last_mouse_frame, going to replace...
753 * xdisp.c (last_mouse_frame): ...global variable.
754 (note_tool_bar_highlight):
755 * w32term.c (w32_mouse_position, w32_read_socket):
756 * xterm.c (XTmouse_position, handle_one_xevent):
757 Use x_mouse_grabbed.
758 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
759
0791d107
DA
7602013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
761
762 * w32term.c (w32_read_socket): Avoid temporary
763 variables in a call to x_real_positions.
764 * xterm.c (handle_one_xevent): Likewise.
765
2cd98812
DA
7662013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
767
768 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
769 (x_icon_type): Remove prototype.
770 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
771 * frame.c (x_icon_type): Remove.
772 * w32term.c (x_make_frame_visible, x_iconify_frame):
773 * xterm.c (x_make_frame_visible, x_iconify_frame):
774 Use x_set_bitmap_icon to factor out common code.
775
a6c2ee1b
DA
7762013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
777
778 * dispextern.h (check_x_display_info, x_get_string_resource):
779 Declare here just once and unify the latter.
780 * frame.c (check_x_display_info, x_get_string_resource):
781 * nsterm.h (check_x_display_info):
782 * xrdb.c (x_get_string_resource):
783 * xterm.h (check_x_display_info): Remove prototypes.
784 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
785 * w32reg.c (x_get_string_resource): Likewise.
786 (w32_get_rdb_resource): Adjust user.
787
baed3603
DA
7882013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
789
790 * xterm.h (struct x_display_info): New member
791 x_pending_autoraise_frame, going to replace...
792 * xterm.c (pending_autoraise_frame): ...static variable.
793 (x_new_focus_frame, XTread_socket): Adjust users.
794 * w32term.h (struct w32_display_info): New member
795 w32_pending_autoraise_frame, going to replace...
796 * w32term.c (pending_autoraise_frame): ...global variable.
797 (x_new_focus_frame, w32_read_socket): Adjust users.
798
90582f05
GM
7992013-09-17 Glenn Morris <rgm@gnu.org>
800
801 * xdisp.c (message_dolog): If we create *Messages*,
802 switch it to messages-buffer-mode.
803
b7ad2f74
PE
8042013-09-17 Paul Eggert <eggert@cs.ucla.edu>
805
806 Don't overuse 'const' in types of locals.
807 * bidi.c (bidi_count_bytes):
808 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
809 (xg_event_is_for_scrollbar):
810 * xselect.c (x_handle_property_notify)
811 (x_handle_selection_notify, x_handle_dnd_message):
812 * xsettings.c, xsettings.h (xft_settings_event):
813 * xterm.c (x_handle_net_wm_state, handle_one_event)
814 (x_menubar_window_to_frame, x_detect_focus_change)
815 (construct_mouse_click, note_mouse_movement)
816 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
817 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
818 (handle_one_xevent, x_handle_net_wm_state):
819 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
820 (x_handle_dnd_message):
821 Avoid unnecessary 'const', typically the second 'const' in
822 'const foo * const arg', a 'const' that does not affect the API
823 and doesn't significantly help the human reader.
824
19452b86
DA
8252013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
826
827 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
828 only if Glib < 2.36.0.
829 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
830 * xsettings.c (init_gconf, init_gsettings): Do not check
831 for g_type_init.
1893694e
DA
832 * xterm.c (handle_one_xevent): Do not call to x_clear_area
833 if GTK >= 2.7.0.
33b83dd7 834 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 835
6434e343
JD
8362013-09-16 Jan Djärv <jan.h.d@swipnet.se>
837
3f386383
JD
838 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
839 before calling g_type_init.
840
6434e343
JD
841 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
842
843 * nsterm.m (syms_of_nsterm): ... to here.
844
83a119f8
DA
8452013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
846
847 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
848 (ignore_next_mouse_click_timeout): Use Time as X does.
849 (handle_one_xevent): Avoid cast and use unsigned comparison.
850
61582e6a
DA
8512013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
852
853 Do not copy X event in handle_one_xevent except KeyPress case.
854 Wnen XEvent is processed, it is unlikely to be changed except
855 KeyPress case, so we can avoid copying and use const pointer to
856 const data to make sure that an event is not changed elsewhere.
857 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
858 const' and do not create local copy except for the KeyPress event.
859 Use casts to avoid a few glitches. Adjust formatting. Add comments.
860 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
861 (x_handle_net_wm_state, x_menubar_window_to_frame)
862 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
863 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
864 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
865 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
866 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
867 (x_handle_dnd_message):
868 * xsettings.c (xft_settings_event):
869 Use 'const XEvent * const' where appropriate.
870 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
871
f8eb1572
DA
8722013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
873
874 Fix X event waiting to handle multiple frames.
875 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
876 * xterm.c (pending_event_wait): Remove. Adjust users.
877 (x_detect_focus_change): Pass frame arg.
878 (handle_one_xevent): Find related frame early and clear per-frame
879 wait_event_type only if this is an event for the relevant frame.
880 (x_wait_for_event): Use per-frame wait_event_type.
881
3fa2054e
JD
8822013-09-15 Jan Djärv <jan.h.d@swipnet.se>
883
745d3809
JD
884 * nsfns.m (Fx_create_frame): Fix font driver registration for
885 GNUStep.
886
887 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
888 for syms_of_macfont.
889
3fa2054e
JD
890 * nsterm.m: Include macfont.h.
891 (ns_tmp_flags, ns_tmp_font): Remove.
892 (ns_compute_glyph_string_overhangs): Check for driver Qns.
893 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
894 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
895 (changeFont:): Fix code style. Check for font driver type when
896 getiing font.
897
898 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
899 (f)->descent.
900
901 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
902 (nsfont_open): Set font driver type.
903 Set font->ascent and font->descent. Figure out font instead of
904 ns_tmp_font, and flags instead of ns_tmp_flags.
905 Fix indentation. Remove call to ns_draw_text_decoration,
906 moved to nsterm.
907
908 * nsfns.m: Include macfont.h.
909 (Fx_create_frame): Register macfont driver, make a better default font.
910 (Fns_popup_font_panel): Get font from macfont driver, if used.
911
912 * macfont.m, macfont.h, maccuvs.h: New files.
913
914 * font.h: Declare syms_of_macfont.
915
916 * font.c (syms_of_font): Call syms_of_macfont.
917
918 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
919
0eed0355
DA
9202013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
921
922 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
923 and it is always zero for others, so I assume that this is an ancient
924 leftover which nobody will want to change any more.
925 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
926 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
927 * frame.c (x_set_scroll_bar_width):
928 * w32fns.c (w32_createscrollbar):
929 * w32term.c (w32_set_vertical_scroll_bar):
930 * xfns.c (x_set_scroll_bar_default_width):
931 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
932 (x_scroll_bar_expose): Related users changed.
933
07013c68
DA
9342013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
935
936 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
937 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
938 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
939 Define as such.
c7cc32f7
DA
940 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
941 Define once here...
942 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
943 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
944 Remove unused Xisms.
7f09455e
DA
945 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
946 these modules are never compiled otherwise.
07013c68 947
0df00f59
EZ
9482013-09-14 Eli Zaretskii <eliz@gnu.org>
949
08a209bf 950 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
951 Doc fix. (Bug#15375)
952
fcd42c11
DA
9532013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
954
955 Unify Fx_focus_frame between all ports.
956 * frame.h (x_focus_frame): New prototype.
957 * xfns.c (Fx_focus_frame): Remove.
958 (syms_of_xfns): Do not defsubr it.
959 (x_focus_frame): X implementation.
960 * nsfns.m (Fx_focus_frame): Remove.
961 (syms_of_nsfns): Do not defsubr it.
962 (x_focus_frame): NS implementation.
963 * w32term.c (Fx_focus_frame): Remove.
964 (x_focus_on_frame): Rename to...
965 (x_focus_frame): W32 implementation.
966 * w32term.h (x_focus_on_frame): Remove prototype.
967 * w32fns.c (Fx_focus_frame): Remove.
968 (syms_of_w32fns): Do not defsubr it.
969 * frame.c (Fx_focus_frame): Define here.
970 (syms_of_frame): Defsubr here.
971 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
972
aad3612f
DA
9732013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
974
975 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
976 All of them are replaced with FRAME_DISPLAY_INFO, defined in
977 each port to reference the port-specific window system data.
978 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
979 (FRAME_DISPLAY_INFO): Define.
980 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
981 (FRAME_DISPLAY_INFO): Define. Adjust users.
982 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
983 (FRAME_DISPLAY_INFO): Define. Adjust users.
984 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
985 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
986 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
987 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
988 * xselect.c, xterm.c: All related users changed.
989
9a650e62
DA
9902013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
991
992 * xterm.h (x_window_to_frame, x_any_window_to_frame)
993 (x_menubar_window_to_frame): Remove prototypes.
994 * xfns.c (x_window_to_frame, x_any_window_to_frame)
995 (x_menubar_window_to_frame, x_top_window_to_frame):
996 Move from here...
997 * xterm.c (x_window_to_frame, x_any_window_to_frame)
998 (x_menubar_window_to_frame, x_top_window_to_frame):
999 ...to here and convert all but the last to static.
1000
347ae3e1
EZ
10012013-09-12 Eli Zaretskii <eliz@gnu.org>
1002
1003 * lisp.mk (lisp): Add w32-common-fns.elc.
1004
15c6d837
XF
10052013-09-12 Xue Fuqiao <xfq.free@gmail.com>
1006
1007 * charset.c (char_charset): Document an exception for char-charset.
1008
27e90f77
DA
10092013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1010
1011 * xterm.h (x_display_info): New field last_user_time...
1012 * xterm.c (toplevel): ...to replace static last_user_time.
1013 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
1014
8ffbc36b
DA
10152013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1016
1017 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
1018 scroll bar values to prevent thumb from disappear and update comment.
1019
5ec0337a
GM
10202013-09-11 Glenn Morris <rgm@gnu.org>
1021
1022 * emacs.c (usage_message): Possessive apostrophe tweak.
1023
fb55b9d1
DA
10242013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1025
8d2db8be
DA
1026 * nsterm.m (syms_of_nsterm): Use Qns.
1027 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
1028 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
1029 * xfns.c (x_display_info_for_name, Fx_open_connection):
1030 Remove old '#if 0' code.
1031 (syms_of_xfns): Use Qx.
fb55b9d1
DA
1032 * termhooks.h (fullscreen_hook): Remove the leftover.
1033 (struct terminal): Fix typo in comment.
1034
927eec55
DA
10352013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1036
1037 Cleaning up a few X scroll bar bits.
1038 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
1039 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1040 New member last_seen_part, going to replace...
1041 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
1042 (xt_action_hook) [USE_LUCID]: Adjust user.
1043 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
1044 Lucid-specific scroll bar support.
1045 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
1046 to int and adjust to use last_seen_part member.
1047 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
1048 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1049 Initialize last_seen_part.
1050
71b28baa
SM
10512013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1052
1053 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
1054 insert-buffer-substring an empty string.
1055
f5dacaae
PE
10562013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
1059 avoiding a GCC warning.
1060
742516e0
DA
10612013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1062
1063 Ifdef away frame tool bar code when it is not really used.
1064 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
1065 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
1066 and minimize_tool_bar_window_p under the above.
1067 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1068 (fset_tool_bar_window): Likewise.
1069 * dispnew.c (clear_current_matrices, clear_desired_matrices)
1070 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
1071 (change_frame_size_1):
1072 * window.c (window_from_coordinates, Frecenter): Adjust users.
1073 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
1074 code is not really used.
1075 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
1076 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
1077 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
1078 [!USE_GTK && !HAVE_NS]: Define as such.
1079 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
1080 (note_mouse_highlight, expose_frame):
1081 * xfns.c (x_set_tool_bar_lines):
1082 * xterm.c (handle_one_xevent): Adjust users.
1083
73f82c7e
PE
10842013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1085
1086 Fix corruption with multiple emacsclient -t instances (Bug#15222).
1087 This bug was introduced by my 2013-08-26 patch, which incorrectly
1088 assumed that the terminfo implementation doesn't use termcap buffers.
1089 * term.c (init_tty) [TERMINFO]: Remove optimization, as
1090 these buffers apparently are used after all.
1091 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
1092 (struct tty_display_info): Define members termcap_term_buffer and
1093 termcap_strings_buffer even if TERMINFO.
1094
53482f41
DA
10952013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1096
1097 Fix last change.
1098 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
1099 'usage' docstring entry to pacify make-docfile.
1100
11012013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
1102
1103 Change comparison functions =, <, >, <=, >= to take many arguments.
1104 * data.c: Change comparison functions' interface and implementation.
1105 * lisp.h: Make arithcompare available for efficient two arg
1106 comparisons.
1107 * bytecode.c: Use arithcompare.
1108 * fileio.c: Use new interface.
1109
533f258f
SM
11102013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1111
1112 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
1113
8c27f5ff
SM
11142013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
1115
1116 * eval.c (Feval): Document the new use of `lexical'.
1117
0750a308
DA
11182013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1119
1120 Review and drop old frame resize hack.
1121 * frame.h (struct frame): Remove force_flush_display_p.
1122 * dispnew.c (update_frame): Adjust user and don't call
1123 flush_frame here. The comment has said that there was an issues
1124 with redisplaying fringes, but I don't see any differences with
1125 and without this hack. Hopefully we can continue without it.
1126 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
1127 current frame matrices twice if resized_p is set.
1128
83fc0554
DA
11292013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1130
1131 Do not populate pure Xism x_sync to other ports.
1132 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
1133 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
1134 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
1135 * w32term.h (x_sync): Remove prototype.
1136
fd462129
DA
11372013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1138
1139 Cleanup frame flushing.
8c27f5ff
SM
1140 * dispextern.h (struct redisplay_interface):
1141 Drop flush_display_optional because flush_display is enough
fd462129
DA
1142 for X and flushing via RIF is just a no-op for others.
1143 * frame.h (flush_frame): New function.
1144 * dispnew.c (update_frame):
1145 * minibuf.c (read_minibuf):
1146 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
1147 Use it.
1148 * keyboard.c (detect_input_pending_run_timers): Do not flush
1149 all frames but selected one in redisplay_preserve_echo_area.
1150 * nsterm.m (ns_flush): Remove no-op.
1151 (ns_redisplay_interface): Adjust user.
1152 * w32term.h (x_flush): Remove no-op.
1153 (w32_redisplay_interface): Adjust user.
1154 * xterm.c (x_flush): Simplify because we do not flush all
1155 frames at once any more. Adjust comment.
1156 (x_redisplay_interface): Adjust user.
1157
4b73fc73
PE
11582013-09-07 Paul Eggert <eggert@cs.ucla.edu>
1159
1160 Port --without-x --enable-gcc-warnings to Fedora 19.
1161 * gfilenotify.c (globals_of_gfilenotify):
1162 Call g_type_init only if using an older glib version that needs it.
1163
77394d40
DA
11642013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1165
1166 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1167 (last_glyphless_glyph_merged_face_id): Remove declarations.
1168 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
1169 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1170 (last_glyphless_glyph_merged_face_id): Now static.
1171 (merge_escape_glyph_face): New function, refactored from...
1172 (get_next_display_element): ...here.
1173 (merge_glyphless_glyph_face): New function, refactored from...
1174 (produce_glyphless_glyph): ...here...
1175 * term.c (produce_glyphless_glyph): ...and here.
1176
306d67bd
SM
11772013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 * eval.c (eval_sub): Only call Ffunction if necessary.
1180
7f6c6450
DA
11812013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 Attempt to make redisplay more selective when changing cursor type.
1184 * frame.h (struct frame): New bitfield cursor_type_changed.
1185 * xdisp.c (cursor_type_changed): Remove.
1186 (try_cursor_movement, redisplay_window, try_window_id)
1187 (set_frame_cursor_types, try_window_reusing_current_matrix):
1188 Adjust to use per-frame bitfield.
1189 (redisplay_internal): Look for cursor type change on each visible
1190 frame and consider all frames if cursor type has been changed on
1191 the frame other than selected. If cursor type has been changed on
1192 selected frame only, do not use fast update.
1193
bd0443bb
DA
11942013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1195
1196 Attempt to make redisplay more selective when changing fonts.
1197 * frame.h (struct frame): New bitfield fonts_changed.
1198 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
1199 (adjust_frame_glyphs): Add prototype.
1200 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 1201 (adjust_glyphs): Remove because we do not
bd0443bb
DA
1202 adjust matrices on all frames at once any more.
1203 (adjust_frame_glyphs): Block and unblock input here.
1204 (adjust_glyph_matrix): Use fonts_changed.
1205 (change_frame_size_1): Use adjust_frame_glyphs.
1206 * font.c (font_open_entity): Use fonts_changed.
1207 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
1208 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1209 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
1210 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
1211 (shrink_mini_window, Fresize_mini_window_internal)
1212 (window_scroll_pixel_based, Fset_window_configuration)
1213 (apply_window_adjustment, Fset_window_vscroll):
1214 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1215 Use adjust_frame_glyphs.
1216 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
1217 (try_window_reusing_current_matrix, try_window_id, display_line)
1218 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
1219 (redisplay_internal): Consider fonts_changed and adjust frame
1220 matrices for each frame only if the frame is visible. If font
1221 has been changed on some frame during full redisplay, retry
1222 only visible frames where the font has been actually changed.
1223
b9695828
DA
12242013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1225
1226 Cache current header and mode line height for each window.
1227 * window.h (struct window): New fields mode_line_height
1228 and header_line_height.
1229 * window.c (make_window): Initialize them.
1230 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
1231 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
1232 (current_mode_line_height, current_header_line_height):
1233 Remove declaration.
1234 * xdisp.c (current_mode_line_height, current_header_line_height):
1235 Remove.
1236 (pos_visible_p, init_xdisp): Adjust user.
1237 (redisplay_window): Invalidate mode_line_height and
1238 header_line_height if current and desired matrices do not agree.
1239
66738305
DA
12402013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1241
1242 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
1243 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
1244
257b3b03
DA
12452013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1246
1247 Make --without-x compatible with --enable-gcc-warnings.
1248 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
1249 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
1250 members under HAVE_WINDOW_SYSTEM.
1251 * keyboard.c (make_lispy_focus_out): Likewise.
1252 (record_menu_key): Move under HAVE_MENUS.
1253 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
1254 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
1255 (syms_of_xdisp): Adjust user.
1256 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
1257 (start_hourglass, cancel_hourglass):
1258 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
1259 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
1260 and CLEAR_FONT_TABLE_NFONTS.
1261 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
1262 Declare only if HAVE_WINDOW_SYSTEM.
1263 (lface_same_font_attributes_p, clear_face_gcs): Define only
1264 if HAVE_WINDOW_SYSTEM.
1265
98b7f4bd
DA
12662013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1267
1268 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
1269 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
1270 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
1271
a7e43722
SM
12722013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
1273
1274 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
1275
0c90b9ee
PE
12762013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
1279 This fixes a type error on hosts where ptrdiff_t is wider than int.
1280
d99760fa
SM
12812013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1282
6629638e
SM
1283 * keyboard.c (read_key_sequence_vs): New function.
1284 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
1285 common code.
1286
d99760fa
SM
1287 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1288
224e313d
PE
12892013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1290
1291 Makefile improvements.
1292 * Makefile.in (config.status): Don't use double-colon rules, as
1293 they are not portable according to POSIX. Fix shell typo with `;
1294 I guess this rule has never been tested?
1295 (VCSWITNESS): New macro, to override any environment var.
1296
6d6ed1af
DA
12972013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 * xterm.h (struct x_display_info): Do not track X connection
1300 fd separately because it is always available from Display.
1301 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1302 Adjust users.
1303
bc923770
DA
13042013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1305
1306 * buffer.c (drop_overlay):
1307 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1308 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1309
b1cf96de
DA
13102013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 * buffer.c (Fmake_overlay, Fmove_overlay):
1313 * intervals.c (set_point_from_marker):
1314 * print.c (PRINTPREPARE): Prefer signal_error
1315 to plain error and report unsuitable marker too.
1316
d1fc6c21
DA
13172013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1318
1319 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1320 for 'dragging' member.
d1ae6a0b
DA
1321 (struct x_output): Remove set-but-unused leftovers
1322 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1323 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1324 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1325 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1326 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1327 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1328 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1329 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1330 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1331
0ce9f6de
JD
13322013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1333
1334 * nsfont.m (INVALID_GLYPH): New define.
1335 (nsfont_encode_char): Use INVALID_GLYPH.
1336 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1337
b594a96c
DA
13382013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1339
1340 * xterm.c (x_last_mouse_movement_time): Revert last change.
1341 This code should use XDisplayMotionBufferSize to check display's
1342 motion history first, and there are few other issues as well.
1343 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1344 (handle_one_xevent): Adjust user.
1345
8b098236
MR
13462013-09-02 Martin Rudalics <rudalics@gmx.at>
1347
9718b207
MR
1348 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1349 * frame.c (Flast_nonminibuf_frame): ... to here.
1350 (check_minibuf_window): Don't abort if no window was found
1351 (Bug#15247).
8b098236 1352
84e70bba
DA
13532013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1354
1355 Use XGetMotionEvents to ask the last mouse motion time from X server.
1356 * xterm.c (X_MOTION_HISTORY): Default to 1.
1357 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1358 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1359 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1360 Ifdef away legacy code.
1361 (XTmouse_position, x_scroll_bar_report_motion):
1362 Use x_last_mouse_movement_time.
fc85e20b
DA
1363 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1364 UnmapNotify event.
84e70bba 1365
1fccc530
DA
13662013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1367
1368 * msdos.c (last_mouse_window): Move to...
1369 (dos_rawgetc): ...this function and adjust comment.
1370 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1371 (mouseMoved): ...this function and adjust comment.
1372 * w32term.c (last_window): Likewise with...
1373 (w32_read_socket): ...this function.
1374 * xterm.c (last_window): Likewise with...
1375 (handle_one_xevent): ...this function.
1376
0ab10992
DA
13772013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1378
b7da754d 1379 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1380 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1381 (handle_one_xevent): ...to here.
1382 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1383 otherwise.
1384
0c7f856e
DA
13852013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1386
1387 * msdos.c (IT_set_terminal_window): Remove no-op.
1388 (initialize_msdos_display): Adjust terminal setup.
1389 * w32console.c (w32con_set_terminal_window): Remove no-op.
1390 (initialize_w32_display): Adjust terminal setup.
1391 * w32term.c (w32_set_terminal_window): Remove no-op.
1392 (w32_create_terminal): Adjust terminal setup.
1393 * xterm.c (XTset_terminal_window): Remove no-op.
1394 (x_create_terminal): Adjust terminal setup.
1395
a892a94c
DA
13962013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1397
1398 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1399 Remove no-ops.
1400 (ns_create_terminal): Adjust terminal setup.
1401 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1402 Remove no-ops.
1403 (w32_create_terminal): Adjust terminal setup.
1404 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1405 Remove no-ops.
1406 (x_create_terminal): Adjust terminal setup.
1407
cf91889a
DA
14082013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1409
1410 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1411 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1412 * dispnew.c (buffer_posn_from_coords):
1413 * window.c (Fwindow_end, displayed_window_lines):
1414 * xdisp.c (redisplay_mode_lines): Use it.
1415
5b0891df
JD
14162013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1417
1418 * fontset.c (face_for_char): Check char in the current face font first
1419 if HAVE_NS (Bug#15138).
1420
0a357e98
MR
14212013-08-31 Martin Rudalics <rudalics@gmx.at>
1422
1423 * window.c (temp_output_buffer_show): Make sure window returned
1424 by display_buffer is live (Bug#15213).
1425
9d7693d7
DA
14262013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1427
1428 Minor cleanup to avoid forward declarations.
1429 * coding.h (struct ccl_spec): Remove forward declaration.
1430 * composite.h (toplevel): Include font.h.
1431 (struct composition_it, struct face, struct font_metrics):
1432 Remove forward declaration.
1433 * dispextern.h (struct image, struct atimer): Likewise.
1434 * emacsgtkfixed.h (struct frame): Likewise.
1435 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1436 * font.h (struct font_driver, struct font, struct glyph_string)
1437 (struct face): Remove forward declaration.
1438 * fontset.h (struct face, struct font): Likewise.
1439 * frame.h (toplevel): Style cleanup.
1440 (enum output_method): Move to...
1441 * termhooks.h (enum output_method): ...here.
1442 (struct glyph, struct frame, struct ns_display_info)
1443 (struct x_display_info, struct w32_display_info):
1444 Remove forward declaration.
1445 * xterm.h (toplevel): Include termhooks.h.
1446 (struct font, struct window, struct glyph_matrix, struct frame)
1447 (struct input_event, struct face, struct image): Remove forward
1448 declaration.
1449 * gtkutil.h (struct _widget_value): Likewise.
1450 * keyboard.h (toplevel): Include termhooks.h.
1451 (struct input_event): Remove forward declaration.
1452
032f7451
DA
14532013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1454
1455 * intervals.c (set_point_from_marker): New function.
1456 * editfns.c (Fgoto_char):
1457 * process.c (Finternal_default_process_filter):
1458 * window.c (select_window_1): Use it.
1459 * buffer.h (set_point_from_marker): Add prototype.
1460
3f940c5a
EZ
14612013-08-29 Eli Zaretskii <eliz@gnu.org>
1462
1463 * w32.c (term_winsock): Call release_listen_threads before calling
1464 WSACleanup.
1465 (_sys_wait_accept): Wait for accept event in a loop with a finite
1466 timeout, instead of waiting indefinitely. Will hopefully avoid
1467 hanging during exit because WSACleanup deadlocks waiting for the
1468 event object to be released. (Bug#14333)
1469
1470 * w32proc.c (release_listen_threads): New function, signals all
1471 the reader threads that listen for connections to stop waiting.
1472
1473 * w32.h (release_listen_threads): Add prototype.
1474
101ed2bb
DA
14752013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1478 field of new marker (for sanity and safety).
20de2834
DA
1479 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1480 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1481
1f5cf200
DA
14822013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1483
1484 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1485 (x_after_update_window_line, x_scroll_bar_create):
1486 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1487 (handle_one_xevent, x_clear_frame_area):
1488 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1489 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1490 * xterm.h (x_clear_area): Adjust prototype.
1491
d2b36813
DA
14922013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1493
1494 Hook scanning and indentation functions to find_newline. This helps
1495 to avoid duplicated code and renders more respect to newline cache.
1496 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1497 * cmds.c (Fforward_line):
1498 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1499 Use find_newline and avoid unnecessary point movements.
1500 * search.c (scan_newline): Implement on top of find_newline.
1501
3ec7babc
SM
15022013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1503
1504 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1505 scoped code (bug#11258).
1506
5ab473cd
JD
15072013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1508
1509 * nsterm.m (last_window): New variable.
1510 (EV_TRAILER2): New macro.
1511 (EV_TRAILER): Call EV_TRAILER2.
1512 (mouseMoved:): Add support for mouse-autoselect-window
1513 on nextstep (Bug#6888).
1514
78779650
AS
15152013-08-28 Andreas Schwab <schwab@suse.de>
1516
1517 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1518 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1519 Remove unused macro definitions.
1520 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1521 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1522 Only define if emacs.
78779650 1523
c3c4768d
DA
15242013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1525
1526 Prefer enum glyph_row_area to int where appropriate.
1527 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1528 Fix comment.
1529 (window_box, window_box_width, window_box_left, window_box_left_offset)
1530 (window_box_right, window_box_right_offset): Adjust prototypes.
1531 * xdisp.c (window_box, window_box_width, window_box_left)
1532 (window_box_left_offset, window_box_right, window_box_right_offset):
1533 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1534 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1535 * nsterm.m (ns_clip_to_row):
1536 * w32term.c (w32_clip_to_row):
1537 * xterm.c (x_clip_to_row): Likewise.
1538
6bdcbfe1
DA
15392013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1540
1541 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1542 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1543
50b13cde
PE
15442013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1545
1546 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1547 for portability to hosts where /bin/sh has problems.
1548
f60e429a
DA
15492013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1550
1551 Redesign redisplay interface to drop global output_cursor.
1552 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1553 (toplevel): Remove declaration of output_cursor.
1554 (set_output_cursor, x_cursor_to): Remove prototype.
1555 * window.h (struct window): New member output_cursor.
1556 (output_cursor_to): New function to replace RIF member.
1557 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1558 (update_text_area, set_window_cursor_after_update): Use it.
1559 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1560 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1561 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1562 * w32term.c (x_update_window_begin, x_update_window_end):
1563 * xterm.c (x_update_window_begin, x_update_window_end):
1564 Adjust to use per-window output cursor.
1565
43aac990
PE
15662013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1567
d486344e
PE
1568 Simplify SELECT_TYPE-related code.
1569 Like EMACS_TIME, this portability layer is no longer needed, since
1570 Emacs has been using fd_set as a portability layer for some time.
1571 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1572 (SELECT_TYPE): Remove. All uses changed to fd_set.
1573 (fd_set) [!FD_SET]: New typedef.
1574
43aac990
PE
1575 Simplify EMACS_TIME-related code.
1576 This portability layer is no longer needed, since Emacs has been
1577 using struct timespec as a portability layer for some time.
1578 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1579 Include <time.h> rather than "systime.h"; that's all that's needed now.
1580 * dispnew.c: Include <timespec.h> rather than "systime.h";
1581 that's all that's needed now.
1582 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1583 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1584 TIMESPEC_RESOLUTION.
1585 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1586 LOG10_TIMESPEC_RESOLUTION.
1587 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1588 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1589 (make_emacs_time): Remove. All used changed to make_timespec.
1590 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1591 (current_timespec): Rename from current_emacs_time. All uses changed.
1592 (add_emacs_time): Remove. All uses changed to timespec_add.
1593 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1594 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1595 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1596 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1597 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1598 (current_timespec): Rename from current_emacs_time. All uses changed.
1599 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1600 changed to timespec_cmp.
1601 * xgselect.c: Include <timespec.h>, since our .h files don't.
1602
d350e350
DA
16032013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1604
1605 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1606 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1607 Remove the leftovers.
1608 * gtkutil.c (toplevel): Do not declare Qxft but include
1609 font.h to do so.
1610 * image.c (toplevel): Do not declare Vlibrary_cache because
1611 it's already done in lisp.h.
1612
9fed9729
DA
16132013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1614
1615 * lisp.h (Mouse_HLInfo): Move from here...
1616 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1617 (reset_mouse_highlight): New function.
1618 * msdos.c (dos_set_window_size, IT_update_begin)
1619 (internal_terminal_init):
1620 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1621 (ns_initialize_display_info):
1622 * w32console.c (initialize_w32_display):
1623 * w32term.c (x_update_window_end, x_free_frame_resources)
1624 (w32_initialize_display_info):
1625 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1626 * window.c (Fdelete_other_windows_internal):
1627 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1628 * termchar.h (toplevel):
1629 * xterm.h (toplevel): Include dispextern.h.
1630
f462f075
PE
16312013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 Fix minor problems found by static checking.
1634 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1635 (expect): Avoid nested-if warning.
1636 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1637 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1638 * nsterm.h, nsterm.m (ns_select):
1639 * xgselect.c, xgselect.h (xg_select):
1640 Adjust signature to better match pselect's.
1641 * nsterm.m (ns_select):
1642 Don't set *TIMEOUT, since pselect doesn't.
1643 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1644 diagnostic about assigning const char * to it.
1645 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1646
068f9124
SM
16472013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1648
1649 * lread.c (substitute_object_recurse): Handle hash-tables as well
1650 (bug#15190).
1651
f5adc984
PE
16522013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1653
1fc8eb33
PE
1654 Fix unlikely core dump in init_tty, and simplify terminfo case.
1655 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1656 The old version incorrectly dumped core if malloc returned a
1657 buffer containing only non-NUL bytes.
1658 (init_tty): Do not allocate or free termcap buffers; the
1659 struct does that for us now.
1660 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1661 (struct tty_display_info): Define members termcap_term_buffer and
1662 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1663 use them. Allocate them directly in struct rather than indirectly
1664 via a pointer, to simplify init_tty.
1665
f5adc984
PE
1666 * frame.c (check_minibuf_window): Initialize 'window' properly,
1667 so that Emacs reliably aborts later if 'window' is not initialized.
1668
efec3894
JD
16692013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1670
1671 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1672 of VoidSymbol (Bug#15154).
1673
e1d0341e
DA
16742013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1675
1676 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1677 mouse_face_beg_y and mouse_face_end_y.
1678 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1679 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1680 Adjust users and update comment where appropriate.
1681
bfff6445
MR
16822013-08-26 Martin Rudalics <rudalics@gmx.at>
1683
1684 * frame.c (check_minibuf_window): New function.
068f9124
SM
1685 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1686 Call check_minibuf_window (Bug#15183).
bfff6445 1687
c80016b3
DA
16882013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1689
1690 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1691 because this is the only last cursor data we need to keep and consult.
1692 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1693 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1694 Adjust users.
1695
de396731
DA
16962013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1697
068f9124
SM
1698 Fix recovering from possible decompression error.
1699 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1700 the position where the partially decompressed data ends, and
447218dd 1701 should count how many bytes was produced so far.
de396731
DA
1702 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1703 (unwind_decompress): Really delete partially uncompressed data.
1704 (Fzlib_decompress_region): Take decompressed data size into account.
1705
c76826d9
DA
17062013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1707
1708 * syntax.c (init_syntax_once): Adjust comment and do an early
1709 initialization of Qchar_table_extra_slots just once...
1710 * casetab.c (init_casetab_once):
1711 * category.c (init_category_once):
1712 * character.c (syms_of_character):
1713 * coding.c (syms_of_coding):
1714 * xdisp.c (syms_of_xdisp): ...and omit it here.
1715
b34454d0
EZ
17162013-08-24 Eli Zaretskii <eliz@gnu.org>
1717
11f20add
EZ
1718 * xdisp.c (get_next_display_element): Don't apply to characters
1719 from a display vector the logic of setting it->end_of_box_run_p
1720 suitable for characters from a buffer. (Bug#15175)
1721
b34454d0
EZ
1722 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1723 to handle directories, rather than '_utime' which doesn't.
1724 (Bug#15176)
1725
6e1b469e
JD
17262013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1727
1728 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1729 or fullscreen (Bug#14627).
1730
9c05bccf
PE
17312013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 System-dependent integer overflow fixes.
1734 * process.c (Fset_process_window_size): Signal an error if
1735 the window size is outside the range supported by the lower level.
1736 * sysdep.c (set_window_size): Return negative on error,
1737 nonnegative on success, rather than -1, 0, 1 on not in system,
1738 failure, success. This is simpler. Caller changed.
1739 (serial_configure): Remove unnecessary initialization of local.
1740 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1741 size fits in unsigned long; this isn't true on some 32-bit hosts.
1742 Avoid buffer overrun if some future version of /proc/meminfo has a
1743 variable name longer than 20 bytes.
1744 (system_process_attributes) [__FreeBSD__]:
1745 Don't assume hw.availpages fits in 'int'.
1746
c365c355
PE
17472013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 Don't let very long directory names overrun the stack.
1750 Fix some related minor problems involving "//", vfork.
1751 * callproc.c (encode_current_directory): New function.
1752 (call_process): Don't append "/"; not needed.
1753 * fileio.c (file_name_as_directory_slop): New constant.
1754 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1755 this can save the caller having to alloca.
1756 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1757 Use SAFE_ALLOCA, not alloca.
1758 (directory_file_name, Fexpand_file_name): Leave leading "//"
1759 alone, since it can be special even on POSIX platforms.
1760 * callproc.c (call_process):
1761 * process.c (Fformat_network_address):
1762 * sysdep.c (sys_subshell):
1763 Use encode_current_directory rather than rolling our own.
1764 (create_process): No need to encode directory; caller does that now.
1765 * process.h (encode_current_directory): New decl.
1766 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1767 Rework to avoid 'goto xyzzy;'.
1768
6c6014d4
EZ
17692013-08-23 Eli Zaretskii <eliz@gnu.org>
1770
1771 * xdisp.c (handle_face_prop): If the default face was remapped use
1772 the remapped face for strings from prefix properties. (Bug#15155)
1773
9997ec56
DA
17742013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 Minor cleanup for redisplay interface and few related functions.
1777 * frame.h (enum text_cursor_kinds): Move from here...
1778 * dispextern.h (enum text_cursor_kinds): ...to here.
1779 (toplevel): Drop unnecessary declarations.
1780 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1781 in update_window_end_hook and draw_window_cursor functions.
1782 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1783 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1784 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1785 * xterm.c (x_update_window_end, x_draw_window_cursor):
1786 * xdisp.c (display_and_set_cursor, update_window_cursor)
1787 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1788 enum text_cursor_kinds where appropriate.
1789
7f780da6
DA
17902013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1791
1792 Redesign redisplay interface to drop updated_row and updated_area.
1793 * dispextern.h (updated_row, updated_area): Remove declaration.
1794 (struct redisplay_interface): Pass glyph row and row area parameters
1795 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1796 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1797 Adjust prototypes.
1798 * dispnew.c (updated_row, updated_area): Remove.
1799 (redraw_overlapped_rows, update_window_line): Adjust user.
1800 (update_marginal_area, update_text_area): Likewise. Pass updated row
1801 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1802 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1803 Adjust users.
1804
26495794
PE
18052013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 * process.c (flush_pending_output): Remove stub.
1808 All uses removed.
1809
4a88129a
PE
18102013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * callproc.c: Fix race that killed background processes (Bug#15144).
1813 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1814 Record deleted process-id in critical section, not afterwards.
1815 Don't mistakenly kill process created by a call-process invocation
1816 that discards output and does not wait.
1817
0c5307b0
DA
18182013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1819
1820 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1821 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1822 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1823 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1824 to shut up compiler in mark_object.
1825 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1826
0d7c1e66
PE
18272013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1830 We can't portably rely on PTY_OPEN doing that, even if
1831 it calls posix_openpt with O_CLOEXEC.
1832
3f246b65
KH
18332013-08-20 Kenichi Handa <handa@gnu.org>
1834
1835 * character.c (string_char): Improve commentary.
1836
8c2f38aa
PE
18372013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1840 (struct animation_cache): Make signature a flexible array member.
1841 All uses changed. This is a tad slower but may insulate us better
1842 from future changes to ImageMagick.
1843
bb566cea
PE
18442013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 * image.c: Shrink memory needed for animation cache.
1847 (SIGNATURE_DIGESTSIZE): New constant.
1848 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1849 (imagemagick_create_cache): Copy the signature. This saves
1850 several KB of memory that ImageMagick wastes per signature.
1851 Don't bother updating the update_time, as the caller does that now.
1852 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1853 it's a fixed size struct member now.
1854 (imagemagick_get_animation_cache): Always destroy the signature,
1855 as it's now imagemagick_create_cache's responsibility to copy it.
1856 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1857 and use memcmp rather than strcmp.
1858 eassert that ImageMagick returns a signature of the specified length.
1859
6da26928
LMI
18602013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1861
1862 * image.c (imagemagick_get_animation_cache): Don't segfault on
1863 each invocation.
453f4022
LMI
1864 (imagemagick_get_animation_cache): Revert to previous definition
1865 so that it actually works. But keep the memory leak fix.
1866 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1867
22490125
PE
18682013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1869
d0139df5
PE
1870 * image.c: Fix animation cache signature memory leak.
1871 Fix some other minor performance problems while we're at it.
1872 (imagemagick_create_cache): Clear just the members that
1873 need clearing. Don't set update_time, as caller does that now.
1874 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1875 Simplify by using pointer-to-pointer instead of a prev pointer.
1876 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1877 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1878 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1879 it's already a copy. Free the signature probe unless it's cached.
1880
22490125
PE
1881 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1882 This was introduced by my 2013-08-12 fix for Bug#15035.
1883
deb31e75
DA
18842013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1885
1886 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1887 (imagemagick_prune_animation_cache): Now static.
1888
319a4d03
LMI
18892013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1890
1891 * image.c (imagemagick_get_animation_cache): Don't segfault when
1892 pruning all entries.
1893
f747d82e
KB
18942013-08-18 Ken Brown <kbrown@cornell.edu>
1895
1896 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1897 static heap if ENABLE_CHECKING is defined.
1898 (max_bss_sbrk_ptr): New variable.
1899 (bss_sbrk): Use it.
1900 (report_sheap_usage): Report maximum static heap usage instead of
1901 ending static heap usage.
1902
d2c28fab
EZ
19032013-08-17 Eli Zaretskii <eliz@gnu.org>
1904
1905 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1906 of zlib_initialized according to the results of calling
1907 init_zlib_functions.
1908
274ff63f
LMI
19092013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1910
1911 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1912 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1913 (imagemagick_load_image): Remove the ping_wand code, which only
1914 apparently saved time on invalid animated images, and slowed down
1915 everything else. Optimise for the common case.
274ff63f 1916
2bede2ed
XF
19172013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1918
70ff8240
XF
1919 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1920
de179a3e
XF
1921 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1922
2bede2ed
XF
1923 * marker.c (set_marker): Remove documentation of undefined behavior.
1924
703dbeba
LMI
19252013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1926
1927 * image.c (imagemagick_compute_animated_image): Animate correctly
1928 when sub-images are smaller than the main image.
1d18b1e6
LMI
1929 (imagemagick_compute_animated_image): Setting the iterator row to
1930 zero is apparently not allowed.
79670014
LMI
1931 (imagemagick_compute_animated_image): Allow images that say they
1932 have sub-images that are bigger than the main image, but just crop
1933 them.
703dbeba 1934
63216c5e
JD
19352013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1936
1937 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1938
a5b5f73f
LMI
19392013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1940
1941 * image.c (imagemagick_compute_animated_image): Respect the GIF
1942 disposal methods.
1943
0fe73012
KB
19442013-08-15 Ken Brown <kbrown@cornell.edu>
1945
1946 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1947 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1948 needed.
1949
691a357f
PE
19502013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 Fix minor problems found by static checking.
1953 * frame.c (delete_frame):
1954 * xdisp.c (next_element_from_display_vector):
1955 Avoid uninitialized local.
1956 * image.c (imagemagick_compute_animated_image): Port to C89.
1957 Prefer usual GNU indentation style for loops.
1958 Be more careful about bizarrely large sizes, by using ptrdiff_t
1959 instead of int.
1960
42fe2e88
DA
19612013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1962
1963 Fix infinite frame selection loop (Bug#15025).
1964 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1965
d39a3da6
EZ
19662013-08-15 Eli Zaretskii <eliz@gnu.org>
1967
068f9124
SM
1968 * xdisp.c (compute_window_start_on_continuation_line):
1969 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1970 to make sure we end up setting the window start at the leftmost
1971 visible character of the display line. This avoids funky
1972 horizontal shifting because the window start is not kept on the
1973 same position. (Bug#15090)
05426239
EZ
1974 (next_element_from_display_vector): Support 'box' face attribute
1975 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1976
6e856b69
LMI
19772013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978
1979 * image.c (imagemagick_compute_animated_image): Implement animated
1980 images (bug#14700).
995be755
LMI
1981 (imagemagick_compute_animated_image): Fix some compilation
1982 warnings. Implement a very simple cache to make the animation
1983 usable at all, but it should be replaced with a per-image cache.
6e856b69 1984
d5a1acfa
DA
19852013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1986
1987 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1988 to do `for' loops over alist values.
1989 * buffer.h (FOR_EACH_BUFFER):
1990 * process.c (FOR_EACH_PROCESS): Use it.
1991 (handle_child_signal, status_notify, Fget_buffer_process)
1992 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1993
9c253307
DA
19942013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1995
1996 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1997 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1998 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1999 to xzalloc and so avoid redundant call to memset.
2000 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
2001 members because it is allocated with xzalloc and so already zeroed.
2002
05e64f9f
KB
20032013-08-14 Ken Brown <kbrown@cornell.edu>
2004
2005 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
2006 (Bug#15094).
2007
5b71542d
DA
20082013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2009
2010 Utility function and macro to copy Lisp string to C string.
2011 * lisp.h (xlispstrdupa): New macro.
2012 (xlispstrdup): New prototype.
2013 * alloc.c (xlispstrdup): New function.
2014 * callint.c (Fcall_interactively):
2015 * fileio.c (Ffile_name_directory, Fexpand_file_name)
2016 (Fsubstitute_in_file_name):
2017 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
2018 * image.c (x_create_bitmap_from_file):
2019 * w32term.c (w32_term_init):
2020 * xterm.c (x_term_init): Use xlispstrdup.
2021
71530c97
LMI
20222013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2023
4ce82fb8
LMI
2024 * image.c (imagemagick_load_image): Make animated pictures work.
2025 There's still some problems with background color settings, though
2026 (bug#14700).
2027
71530c97
LMI
2028 * decompress.c (unwind_decompress): Always restore point.
2029
7510a061
XF
20302013-08-14 Xue Fuqiao <xfq.free@gmail.com>
2031
2032 * marker.c (set_marker): Reformat documentation.
2033
01c3051f
PE
20342013-08-14 Paul Eggert <eggert@cs.ucla.edu>
2035
aab1fcdf
PE
2036 * xdisp.c (cursor_type_changed): Now static.
2037
01c3051f
PE
2038 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
2039 Use changed. This avoids the need to call xmalloc and for the
2040 caller to call xfree, and avoids memory leaks in some situations.
2041
2084152a
DA
20422013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2043
2044 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
2045 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
2046 (redisplay_window): If window_end_valid is cleared due to non-zero
2047 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
2048 so do not call to try_cursor_movement for that window.
2084152a 2049
02455cb6
DA
20502013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2051
2052 * window.h (struct window): Convert window_end_pos and
2053 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
2054 (wset_window_end_pos, wset_window_end_vpos): Remove.
2055 * dispnew.c (adjust_glyph_matrix):
2056 * window.c (Fwindow_end, replace_window, set_window_buffer)
2057 (make_window):
2058 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
2059 (set_vertical_scroll_bar, redisplay_window, try_window)
2060 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
2061 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
2062 (note_mouse_highlight): Adjust users.
2063 (try_cursor_movement): Likewise. Convert old precondition to eassert.
2064 Add comment.
2065
da5707e8
DA
20662013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2067
2068 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
2069 * image.c (imagemagick_filename_hint): Use `const char *' and
2070 prefer SSDATA to SDATA to avoid warnings.
2071
25554267
DA
20722013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2073
2074 Cleanup window fringes, margins and scroll bars adjustments.
2075 * window.c (set_window_fringes, set_window_margins)
2076 (set_window_scroll_bars, apply_window_adjustment): New functions.
2077 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
2078 (Fset_window_scroll_bars): Use them.
2079
38a2c910
DA
20802013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2081
2082 * window.h (struct window): Convert scroll_bar_width
2083 from Lisp_Object to integer. Adjust comment.
2084 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
2085 Adjust users.
2086 * window.c (wset_scroll_bar_width): Remove.
2087 (make_window): Initialize scroll_bar_width.
2088 (Fsplit_window_internal): Use direct assignment.
2089 (Fset_window_configuration, save_window_save):
2090 Convert Lisp_Object to integer and back where appropriate.
2091 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
2092 bar was actually changed, and mention this in docstring.
2093
2d065031
PE
20942013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 * decompress.c: Minor simplifications.
2097 (Fzlib_decompress_region): Don't bother verifying
2098 that avail_out <= UINT_MAX, as that was confusing.
2099 Mention the restriction in a comment instead.
2100 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
2101
a5bd5abb
JD
21022013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2103
2104 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
2105 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
2106
66e7901a
LMI
21072013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2108
2109 * image.c (imagemagick_filename_hint): Check for errors in the
2110 alist structure.
2111
2fa611b7
EZ
21122013-08-13 Eli Zaretskii <eliz@gnu.org>
2113
2114 * window.c (Fwindow_margins): Return nil when there's no marginal
2115 area, as per the documented API.
2116
2117 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
2118 Fmake_vector, as scroll bar's struct members are not all Lisp
2119 objects now. This avoids crashes in GC.
2120
2121 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
2122 bool, so its address could be taken.
2123
8259030d
LMI
21242013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2125
2126 * image.c (imagemagick_filename_hint): New function to possibly
2127 apply `image-content-type-suffixes'.
2128 (imagemagick_load_image): Use it.
2129
866c710e
EZ
21302013-08-13 Eli Zaretskii <eliz@gnu.org>
2131
2132 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
2133 if loading zlib failed.
2134
f10490f0
JD
21352013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2136
96311be7
JD
2137 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
2138 2013-08-13 checkin below. Change bool to BOOL, rule is:
2139 All Obj-C code uses BOOL, except for interfaces callable from C.
2140
f10490f0
JD
2141 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
2142
c8ae93b0
DA
21432013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2144
2145 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
2146 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
2147 bool instead of BOOL.
2148 * w32term.h (struct scroll_bar): Convert fringe_extended_p
2149 from Lisp_Object to bitfield. Adjust comment.
2150 * w32term.c (x_scroll_bar_create): Adjust user.
2151 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
2152 * xterm.c (XTset_vertical_scroll_bar): Likewise.
2153 Use bool for boolean.
2154 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
2155 to `unsigned int' when defining a bitfield.
2156
53b64418
PE
21572013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2158
2159 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
2160
eeaf9bf3
DA
21612013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2162
2163 * window.h (struct window): Convert left_margin_cols and
2164 right_margin_cols from Lisp_Objects to integers. Adjust comment.
2165 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
2166 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
2167 Adjust users.
2168 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
2169 Adjust comment.
2170 (showing_window_margins_p, update_window_line, update_frame_1):
2171 * fringe.c (draw_fringe_bitmap_1):
2172 * xdisp.c (window_box_width): Adjust users.
2173 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
2174 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
2175 Use direct assignment.
2176 (Fset_window_configuration, save_window_save, Fwindow_margins):
2177 Convert Lisp_Object to integer and back where appropriate.
2178 (Fset_window_margins): Adjust user. Return t if any margin
2179 was actually changed, and mention this in docstring.
2180
956720af
XF
21812013-08-13 Xue Fuqiao <xfq.free@gmail.com>
2182
f73f4ce6 2183 * syntax.c (forward_word):
956720af
XF
2184 * cmds.c (forward_char, backward_char): Mention the optional argument.
2185
9e37ee3b
DA
21862013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2187
2188 * window.h (struct window): Convert left_fringe_width
2189 and right_fringe_width from Lisp_Objects to integers.
2190 Adjust comment.
2191 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
2192 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
2193 * window.c (wset_left_fringe_width, wset_right_fringe_width):
2194 Remove.
2195 (make_window): Initialize new integer fields to -1.
2196 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
2197 (Fset_window_configuration, save_window_save):
2198 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
2199 (Fset_window_fringes): Adjust user. Return t if any fringe
2200 was actually changed, and mention this in docstring.
2201
e4375ca7
DA
22022013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2203
2204 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
2205 * nsfns.m (x_set_cursor_type):
2206 * w32fns.c (x_set_cursor_type):
2207 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
2208 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 2209
a45543bc
DA
22102013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2211
2212 * font.c (clear_font_cache): New function, stripped from...
2213 (Fclear_font_cache): ...here, which now uses the function
2214 above. Adjust comment.
2215 * font.h (clear_font_cache): Add prototype.
2216 * xfaces.c (clear_face_cache): Use clear_font_cache.
2217
ae966a86
DA
22182013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2219
2220 * window.c (Fset_window_start): Compare `w', not `window' because
2221 `w' might not be equal to `window' after call to decode_live_window.
2222
297a545b
PE
22232013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
2226 This fixes a problem introduced by the Bug#15035 patch
2227 when using GPG. Reported by Herbert J. Skuhra.
2228
aa942e2b
EZ
22292013-08-12 Eli Zaretskii <eliz@gnu.org>
2230
2231 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
2232 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
2233 not yet initialized.
2234
7699d09e
LMI
22352013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2236
2237 * decompress.c (Fzlib_decompress_region): Support zlib
2238 decompression, too, and rename.
2239
1d238bc7
PE
22402013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 Minor zlib configuration tweaks.
2243 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
2244 Don't assume presence of fn_inflateInit2_ zlib internal function.
2245
8a44a184
LMI
22462013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2247
2248 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
2249 include the zlib prefix.
2250
594a4307
EZ
22512013-08-12 Eli Zaretskii <eliz@gnu.org>
2252
2253 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
2254 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
2255 define static variables that are pointers to zlib functions to be
2256 dynamically loaded.
2257 (init_zlib_functions) [WINDOWSNT]: New function.
2258 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
2259 New macros.
2260 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
2261 macros instead of invoking the zlib functions directly.
068f9124
SM
2262 (syms_of_decompress): DEFSYM Qzlib_dll.
2263 Staticpro Szlib_available_p.
594a4307 2264
d2e113bc
DA
22652013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
2266
2267 Avoid looping over all frame windows to freeze and unfreeze.
2268 * window.h (struct window): Drop frozen_window_start_p.
2269 (freeze_window_starts): Drop prototype.
2270 * frame.h (struct frame): New frozen_window_starts flag.
2271 (FRAME_WINDOWS_FROZEN): New macro.
2272 * window.c (freeze_window_start, freeze_window_starts):
2273 Remove.
2274 (select_window, replace_window): Adjust users.
2275 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2276 (window_frozen_p): New function.
2277 (redisplay_window): Use it.
2278
94fcd171
PE
22792013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 Fix some fd issues when running subprocesses (Bug#15035).
2282 Fix bugs that can leak files or file descriptors on errors.
2283 Don't unlink open temp files, as that's hard for users to diagnose
2284 when things go awry (e.g., temp disk exhausted).
2285 Don't bother to lock temp files. Check for invalid recursion.
2286 * callproc.c (synch_process_fd): Remove. All uses removed.
2287 (synch_process_tempfile): New var or macro.
2288 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2289 New constants.
2290 (record_kill_process): New arg, the temp name. All callers changed.
2291 (delete_temp_file): Now just a simple wrapper around unlink.
2292 (call_process_kill): New arg, the call_process_fd array.
2293 Close them all. Clear synch_process_pid. Remove the temp file,
2294 or arrange for it to be removed.
2295 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2296 that's been moved to synch_process_tempfile. Caller changed.
2297 Do not remove the tempfile; that's now call_process_kill's
2298 responsibility.
2299 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2300 call_process_kill; the caller now does that.
2301 (call_process_cleanup): Do not close the process fd; that's now
2302 call_process_kill's responsibility.
2303 (Fcall_process): Implement via new function call_process, which
2304 has most of the old body of Fcall_process, but with a different API.
2305 (call_process): New function that does not open or close filefd if
2306 it is nonnegative. Record which fds need to be closed, and let
2307 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2308 Signal an error if invoked recursively (could be done via a hook).
2309 Simplify creation of the tempfile in the MSDOS case.
2310 Don't create the output file until after checking for the executable.
2311 Report any failure to open /dev/null.
2312 Don't open /dev/null for writing twice; once is enough.
2313 Don't create pipe if all output is being discarded or sent to file.
2314 Don't worry about setting up the coding system or reading from the
2315 pipe if all output is being discarded.
2316 Hoist fd_error local into top level, to lessen block nesting.
2317 Don't record deleted pid here; now done by Fcall_process_region.
2318 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2319 and note its success in synch_process_tempfile.
2320 Do not leak resources when child_setup fails.
2321 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2322 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2323 (create_temp_file): Now returns open fd, with an additional
2324 Lisp_Object * argument to return the name. All callers changed.
2325 Do not close the file; rewind it instead, and leave it open for
2326 the caller. Do not lock the temp file. Unwind-protect the file
2327 and the file-descriptor.
2328 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2329 If an asynchrounous process, record it here, not in call_process.
2330 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2331 * eval.c (set_unwind_protect): New function.
2332 * fileio.c (write_region): New function, generalized from the
2333 old Fwrite_region. Do not lock temp files.
2334 (Fwrite_region): Use it.
2335 * lisp.h (set_unwind_protect, write_region): New decls.
2336 * process.c: Include <verify.h>.
2337 (make_process): Mark fds as initially closed.
2338 (deleted_pid_list): Now a list of pid-filename pairs.
2339 All uses changed.
2340 (close_process_fd): New function.
2341 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2342 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2343 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2344 (create_process, create_pty, Fmake_serial_process)
2345 (server_accept_connection): Record which fds need to be closed,
2346 and let deactivate_process close them.
2347 (Fmake_network_process): Do not discard the unwind-protect
2348 until it's safe to do so.
2349 (deactivate_process): Close the fds opened by create_process etc.
2350 (Fprocess_send_eof): Adjust to new way of recording open fds.
2351 Report an error if /dev/null can't be opened, instead of aborting.
2352 * process.h (PROCESS_OPEN_FDS): New constant.
2353 (struct Lisp_Process): New member open_fds.
2354 (record_kill_process, record_deleted_pid): Adjust signatures.
2355 (record_deleted_pid): Move decl here ...
2356 * syswait.h (record_deleted_pid): ... from here.
2357
d0e615c3
PE
23582013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2359
2360 * decompress.c: Fix bugs with large buffers and weird inputs.
2361 Tune a bit. Reindent as per usual Emacs style.
2362 (BUFFER_SIZE): Remove.
2363 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2364 more than UINT_MAX bytes. Decompress into the gap instead of into
2365 an auto buffer, as this should avoid copying. Return nil if
2366 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2367 set immediate_quit; we shouldn't trust zlib code that much.
2368
313546eb
LMI
23692013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2370
99a32242
LMI
2371 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2372 errors, and really move the gap to where we want it.
2373
313546eb
LMI
2374 * lisp.h: Include decompress.c support.
2375
2376 * emacs.c (main): Include decompress.c support.
2377
2378 * Makefile.in: Include -lz if present.
2379
d2d699ac
JD
23802013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2381
f90e3ebd
JD
2382 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2383 (initWithTitle:): Initialize frame to 0.
2384 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2385 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2386 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2387
2388 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2389 fillWithWidgetValue:frame:
2390
423d3b3f
JD
2391 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2392 remove memory leak warnings.
2393
d2d699ac
JD
2394 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2395 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2396 menu_pending_title.
2397
2398 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2399 (x_activate_menubar): Update the whole menu.
2400 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2401 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2402 current event is not NSSystemDefined (Bug#15001).
2403 Call ns_check_menu_open only if trackingMenu is 2.
2404 (menuDidClose:): New method, decrease trackingMenu.
2405 (fillWithWidgetValue:setDelegate:): New method.
2406 (fillWithWidgetValue:): Call the above.
2407
2408 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2409
7d652d97
PE
24102013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 Omit some unnecessary casts.
2413 Many of these go back to the old pre-C89 days, when they may have
2414 been needed, but we've been assuming C89 or later for a while now.
2415 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2416 (live_float_p, live_misc_p, live_vector_p):
2417 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2418 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2419 (defvar_per_buffer):
2420 * callint.c (Fcall_interactively):
2421 * doc.c (Fsubstitute_command_keys):
2422 * filelock.c (get_boot_time):
2423 * frame.c (xrdb_get_resource):
2424 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2425 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2426 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2427 (menuitem_highlight_callback, menu_destroy_callback)
2428 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2429 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2430 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2431 (xg_tool_bar_help_callback, tb_size_cb):
2432 * image.c (xpm_alloc_color, png_read_from_memory)
2433 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2434 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2435 (syms_of_image):
2436 * keymap.c (describe_map):
2437 * nsfns.m (Fns_display_monitor_attributes_list):
2438 * nsmenu.m (process_dialog:):
2439 * nsterm.m (hold_event):
2440 * process.c (wait_reading_process_output):
2441 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2442 * scroll.c (do_direct_scrolling, scrolling_1):
2443 * termcap.c (tgetent):
2444 * window.c (check_window_containing, add_window_to_list)
2445 (freeze_window_starts):
2446 * xdisp.c (compare_overlay_entries, vmessage):
2447 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2448 (x_get_monitor_attributes_xrandr)
2449 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2450 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2451 * xfont.c (xfont_match, xfont_open):
2452 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2453 (menubar_selection_callback, menu_position_func)
2454 (popup_selection_callback, create_and_show_popup_menu)
2455 (dialog_selection_callback, create_and_show_dialog):
2456 * xrdb.c (x_get_string_resource):
2457 (main) [TESTRM]:
2458 * xsmfns.c (x_session_check_input):
2459 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2460 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2461 (xaw_jump_callback, xaw_scroll_callback):
2462 Omit unnecessary casts.
2463
9acc1074
PE
24642013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 Minor string-length refactoring.
2467 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2468 * frame.c (make_monitor_attribute_list):
2469 Prefer build_string to strlen + make_string.
2470
361c0eb8
JD
24712013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2472
2473 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2474 don't check minor_code (Bug#14417).
2475
14ba0822
EZ
24762013-08-09 Eli Zaretskii <eliz@gnu.org>
2477
2478 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2479 vertical positions instead. This avoids calling MATRIX_ROW with
2480 row numbers that are possibly beyond valid limits. (Bug#15064)
2481
309f24d1
DA
24822013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2483
2484 Use xstrdup and build_unibyte_string where applicable.
2485 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2486 * xfns.c (x_window):
2487 * xrdb.c (x_get_customization_string):
2488 * xterm.c (xim_initialize):
2489 * w32fns.c (w32_window): Use xstrdup.
2490 (w32_display_monitor_attributes_list):
2491 * emacs.c (init_cmdargs):
2492 * keyboard.c (PUSH_C_STR):
2493 * nsfont.m (nsfont_open):
2494 * sysdep.c (system_process_attributes):
2495 * w32.c (system_process_attributes):
2496 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2497
55902276
EZ
24982013-08-09 Eli Zaretskii <eliz@gnu.org>
2499
2500 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2501 variables of these types so that GDB would know about them, as aid
2502 for debugging fatal exceptions. (Bug#15024) See also
2503 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2504 discussions.
2505
10bf7f5a
JD
25062013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2507
2508 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2509 larger than the NSWindow (Bug#14934).
2510
65620264
DA
25112013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2512
2513 Redesign redisplay interface to drop global variable updated_window.
2514 Always pass currently updated window as a parameter to update routines.
2515 * dispextern.h (updated_window): Remove declaration.
2516 (struct redisplay_interface): Pass window parameter to
2517 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2518 and after_update_window_hook.
2519 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2520 Adjust prototypes.
2521 * dispnew.c (updated_window): Remove.
2522 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2523 (update_window_line): Adjust to match redisplay interface changes.
2524 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2525 (ns_scroll_run, ns_after_update_window_line):
2526 * w32term.c (x_update_window_begin, x_update_window_end)
2527 (x_after_update_window_line, x_scroll_run):
2528 * xterm.c (x_update_window_begin, x_update_window_end)
2529 (x_after_update_window_line, x_scroll_run):
2530 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2531 Likewise. Adjust comments where appropriate.
2532 (x_cursor_to): Simplify because this is always called during window
2533 update (but install debugging check anyway).
2534 (expose_window): Check must_be_updated_p flag to see whether this
2535 function is called during window update.
2536
628fdc56
DA
25372013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2538
2539 Do not reset window modification event counters excessively.
2540 These leftovers and poor man's tricky methods to catch extra
2541 redisplay's attention are no longer needed.
2542 * frame.c (set_menu_bar_lines_1):
2543 * minibuf.c (read_minibuf_unwind):
2544 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2545 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2546 (window_scroll_line_based, Fset_window_configuration):
2547 * xdisp.c (redisplay_window): Do not reset last_modified and
2548 last_overlay_modified counters.
2549
8fd9c92e
JD
25502013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2551
2552 * xselect.c (x_send_client_event): Set send_event and serial, memset
2553 data.l as it might be bigger than data.b. Use 24 bit mask to
2554 XSendEvent (Bug#15034).
2555
0ee18172
EZ
25562013-08-07 Eli Zaretskii <eliz@gnu.org>
2557
2558 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2559 for TTY frames that are not the top frame on their console.
2560 (Bug#14616)
2561
16ddd1a6
MR
25622013-08-07 Martin Rudalics <rudalics@gmx.at>
2563
2564 * w32term.c (w32fullscreen_hook): Really maximize frame when
2565 asked for (Bug#14841).
2566
d2a95ffb
DA
25672013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2568
2569 Prefer selected_window to Fselected_window, likewise for frames.
2570 * buffer.c (Fbuffer_swap_text):
2571 * data.c (Fvariable_binding_locus):
2572 * window.c (run_window_configuration_change_hook): Adjust users.
2573 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2574 Use decode_live_frame.
2575
170da1ec
DA
25762013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2577
2578 Be more careful if selected window shows the buffer other than current,
2579 use window_outdated only if this is not so. This change should also
2580 address some weird issues discussed in Bug#13012.
2581 * window.h (window_outdated): New prototype.
2582 * window.c (window_outdated): Now here. Convert from static and
2583 always assume window's buffer.
2584 (Fwindow_end, Fwindow_line_height): Use it.
2585 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2586 and always assume window's buffer.
2587 (redisplay_window): Adjust user.
e5eefe9b 2588 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2589 check whether mode line should be updated only if selected window
2590 shows current buffer.
2591 (run_window_scroll_functions): Use eassert for debugging check.
2592 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2593
56b5d5b1
DA
25942013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2595
2596 * window.c (window_scroll, window_scroll_pixel_based)
2597 (window_scroll_line_based): Use bool for booleans.
2598
2878ba7e
PE
25992013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * process.c: Fix minor off-by-one issues in descriptor counts.
2602 This shouldn't fix any real bugs, but it cleans up the code a bit.
2603 (max_process_desc, max_input_desc): -1, not 0, means none.
2604 All uses changed.
2605 (delete_input_desc): New function.
2606 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2607 (deactivate_process): Scan backwards when recomuting max_process_desc;
2608 that should be faster.
2609 (init_process_emacs): Initialize max_input_desc.
2610
e30b79c1
DA
26112013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2612
2613 Use region cache to speedup bidi_find_paragraph_start.
2614 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2615 Rename cache_long_line_scans to cache_long_scans.
2616 * buffer.c (bset_cache_long_line_scans): Rename to
2617 bset_cache_long_scans.
2618 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2619 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2620 into account.
2621 (syms_of_buffer): Rename cache-long-line-scans to
2622 cache-long-scans. Adjust docstring.
2623 * search.c (newline_cache_on_off):
2624 * indent.c (width_run_cache_on_off): Adjust users.
2625 * bidi.c (bidi_paragraph_cache_on_off): New function.
2626 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2627 * insdel.c (prepare_to_modify_buffer):
2628 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2629
00012b86
DA
26302013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2631
2632 Invalidate region caches only if buffer text is going to be changed.
2633 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2634 (modify_text): ...new prototype.
2635 (prepare_to_modify_buffer_1): New prototype.
2636 * textprop.c (modify_region): Rename to...
2637 (modify_text_properties): ...new function.
2638 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2639 (Fremove_list_of_text_properties): Adjust users.
2640 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2641 (modify_text): ...new function.
2642 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2643 (prepare_to_modify_buffer_1): ...new function.
2644 * casefiddle.c (casify_region):
2645 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2646 (Ftranspose_regions): Use modify_text.
2647
dc6c0eda
SM
26482013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2649
2650 * lisp.mk (lisp): Add nadvice.elc.
2651
8f3a2c26
DA
26522013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2653
2654 New macro to iterate over live buffers similar to frames.
2655 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2656 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2657 Declare buffer-related variables here to offload lisp.h.
2658 * buffer.c (Vbuffer_alist): Adjust comment.
2659 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2660 (other_buffer_safely):
2661 * data.c (store_symval_forwarding):
2662 * dispnew.c (Fframe_or_buffer_changed_p):
2663 * fileio.c (Fdo_auto_save):
2664 * filelock.c (unlock_all_files):
2665 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2666
e0fdb694
PE
26672013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2668
2669 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2670 * callproc.c (create_temp_file):
2671 * filelock.c (create_lock_file):
2672 Assume mkostemp, since it's now provided by Gnulib.
2673
63f5c6c2
EZ
26742013-08-04 Eli Zaretskii <eliz@gnu.org>
2675
2676 * w32.c (mkostemp): New function.
2677 (mktemp): Remove, no longer used. Most of the code reused in
2678 mkostemp. (Bug#15015)
484ab239 2679 (mktemp): Don't undef.
63f5c6c2 2680
f0b79313
DA
26812013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2682
2683 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2684 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2685 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2686 (free_glyph_pool, check_glyph_memory): Likewise for
2687 all users. Adjust comments where appropriate.
2688
98f638d6
PE
26892013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 * composite.h: Minor fixups.
2692 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2693 to fix a misspelling, and change it to an inline function while
2694 we're at it (it need not be a macro). All uses changed.
2695 (composition_method, composition_valid_p):
2696 Rewrite to avoid assignments in if-conditions.
2697
75c59fb3
DA
26982013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2699
2700 Do not use global Lisp_Object in composition macros.
2701 * composite.h (composition_temp): Remove declaration.
2702 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2703 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2704 (compose_region): Remove the leftover.
75c59fb3
DA
2705 * composite.c (composition_temp): Remove.
2706 (run_composition_function, update_compositions)
2707 (composition_compute_stop_pos, composition_adjust_point)
2708 (Ffind_composition_internal):
2709 * coding.c (handle_composition_annotation):
2710 * xdisp.c (handle_composition_prop, check_point_in_composition):
2711 Related users changed.
2712
a10c8269
DA
27132013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2714
2715 Drop FRAME_PTR typedef.
2716 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2717 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2718 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2719 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2720 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2721 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2722 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2723 All related users changed.
2724
a104f656
SM
27252013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2726
2727 * eval.c (default_toplevel_binding): New function.
2728 (Fdefvar): Use it.
2729 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2730 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2731 (syms_of_eval): Export them.
2732 * data.c (Fdefault_value): Micro cleanup.
2733 * term.c (init_tty): Use "false".
2734
4b5c9326
DA
27352013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2736
2737 Fix X GC leak in GTK and raw (no toolkit) X ports.
2738 * xterm.c (x_free_frame_resources): If white and black relief
2739 GCs are allocated, always free them here.
2740 * xfns.c (x_make_gc): Omit redundant initialization.
2741 * widget.c (create_frame_gcs): Remove the leftover.
2742 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2743 in x_free_frame_resources.
2744
b19aa636
JD
27452013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2746
2747 * nsterm.m (windowWillResize:toSize:): Only change title if
2748 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2749 modifying it.
2750 (viewDidEndLiveResize): New method.
2751
2752 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2753 inside NS_IMPL_COCOA.
2754
af1f7e06
DA
27552013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2756
2757 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2758 Do not check whether undo is enabled because record_insert and
2759 record_delete does that themselves.
2760
65b02bb9
DA
27612013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2762
2763 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2764 member which is not really used any more.
2765 (FRAME_XIC_BASE_FONTNAME): Remove.
2766 * xfns.c (xic_free_fontset): Adjust user.
2767 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2768 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2769 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2770 (xdialog_show): Use eassert for debugging check.
7ee0f047 2771 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2772
6318cde0
PE
27732013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2774
2775 * fileio.c, fns.c (merge): Move extern decl from here ...
2776 * lisp.h (merge): ... to here.
2777
6c1a09ba
DA
27782013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2779
2780 Fix last font-related change.
2781 * w32font.h (w32font_list_internal, w32font_match_internal):
2782 Fix prototype.
2783 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2784 (uniscribe_list_family): Adjust to match font API change.
2785 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2786 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2787
f8c20208
DA
27882013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2789
2790 * frame.h (FRAME_MOUSE_UPDATE):
2791 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2792 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2793
fdb396e2
DA
27942013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2795
2796 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2797 * font.h (struct font_driver): Change list, match, and list_family
2798 functions to accept struct frame * as first arg.
068f9124
SM
2799 * font.c (font_score, font_compare, font_sort_entities):
2800 Remove prototypes.
fdb396e2
DA
2801 (font_sort_entities, font_list_entities, font_select_entity):
2802 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2803 match font API change.
2804 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2805 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2806 * ftxfont.c (ftxfont_list, ftxfont_match):
2807 * xftfont.c (xftfont_list, xftfont_match):
2808 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2809 * w32font.c (w32font_list, w32font_match, w32font_list):
2810 (w32font_list_internal, w32_font_match_internal): Likewise.
2811 * xfaces.c (Fx_family_fonts): Adjust user.
2812
52b8a085
DA
28132013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2814
2815 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2816 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2817 only if HAVE_X_WINDOWS is in use.
2818 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2819 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2820 * w32term.c (x_wm_set_icon_position): Likewise.
2821 * w32fns.c (x_icon): Adjust user.
2822
c791c18e
DA
28232013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2824
2825 * xterm.c (last_mouse_press_frame): Remove the
2826 leftover which is not really used any more.
2827 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2828 (x_flush): Call XFlush once per each X display, not frame.
2829 This is better because this code always unconditionally skips
2830 non-X frames in Vframe_list and issues the only XFlush if we
2831 have more than one X frame on the same X display.
2f935d86
DA
2832 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2833 Use bool for booleans.
2834 (x_draw_glyph_string_background, cvt_string_to_pixel):
2835 (cvt_pixel_dtor): Drop unnecessary prototypes.
2836 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2837
f435830e
DA
28382013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2839
2840 Drop unnecessary functions that deals with frame pixel size.
2841 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2842 (x_pixel_height): Drop prototypes.
2843 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2844 (x_pixel_height): Drop implementations.
2845 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2846 which should be always valid for window frame.
2847 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2848 * w32menu.c (Fx_popup_dialog):
2849 * xmenu.c (Fx_popup_dialog): Likewise for both.
2850
84231434
DA
28512013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2852
2853 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2854 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2855 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2856 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2857 and mention nil frame in docstring.
84231434 2858
959067a1
DA
28592013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2860
2861 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2862 (x_figure_window_size): Likewise. Adjust to return long.
2863 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2864 (toplevel): Move Qterminal_live_p to...
2865 * terminal.c (toplevel): ...here, make it static, and...
2866 (syms_of_terminal): ...DEFSYM here.
2867 * frame.h (Qterminal_live_p): Remove declaration.
2868 (make_frame, x_figure_window_size): Adjust prototype.
2869 * nsfns.m (Fx_create_frame): Use long for window flags.
2870
f4b169ce
PE
28712013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2874 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2875 Do not assume that emacs_close (INT_MAX) is a no-op.
2876
bee6a2c7
DA
28772013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2878
2879 * xfaces.c (make_face_cache): For struct face_cache, prefer
2880 xmalloc to xzalloc and so avoid redundant call to memset.
2881 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2882
d7e6881a
DA
28832013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2884
2885 * fringe.c (draw_window_fringes, update_window_fringes)
2886 (compute_fringe_widths):
2887 * w32term.c (x_draw_glyph_string):
2888 * window.c (candidate_window_p, Frecenter):
2889 * xfaces.c (realize_basic_faces, realize_default_face)
2890 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2891 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2892 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2893 * xmenu.c (Fx_menu_bar_open_internal):
2894 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2895 * xsettings.c (xft_settings_event):
2896 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2897 Use bool for booleans. Adjust style and comments where
2898 appropriate.
2899 * dispextern.h (draw_window_fringes, update_window_fringes)
2900 (compute_fringe_widths):
2901 * xterm.h (x_had_errors_p): Adjust prototype.
2902
ec3058af
DA
29032013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2904
2905 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2906 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2907
218e0637
DA
29082013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2909
2910 * fns.c (toplevel): Remove comment before Fsafe_length because
2911 it checks for QUIT.
2912
e560aba9
PE
29132013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2914
2915 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2916
2e5ce5de
EZ
29172013-07-28 Eli Zaretskii <eliz@gnu.org>
2918
2919 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2920 frame which got the message is still alive, before dereferencing
2921 its pointer. (Bug#14970)
2922
2923 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2924 be a live window, before using it as such. (Bug#14970)
2925
e95da6d3
EZ
29262013-07-27 Eli Zaretskii <eliz@gnu.org>
2927
2928 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2929 w32_detect_focus_change instead of doing part of its job by hand.
2930 This fixes the problem whereby FOCUS_OUT events were not sent to
2931 the event queue.
2932
a8f93651
EZ
29332013-07-26 Eli Zaretskii <eliz@gnu.org>
2934
fec92060
EZ
2935 * process.c (Fprocess_list): Doc fix.
2936
a8f93651
EZ
2937 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2938 being re-exposed only if it didn't ask to become visible.
2939 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2940 was previously iconified. (Bug#14841)
2941 (x_iconify_frame): Mark the frame iconified.
2942
d5a7a9d9
PE
29432013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2944
2945 Fix minor problems found by static checking.
2946 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2947 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2948
56ea7291
SM
29492013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2950
2951 * eval.c (set_specpdl_old_value): New function.
2952 (unbind_to): Minor simplification.
2953 (get_backtrace_frame): New function.
2954 (Fbacktrace_frame): Use it. Add `base' argument.
2955 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2956 (syms_of_eval): Export backtrace-eval.
2957 * xterm.c (x_focus_changed): Simplify.
2958
9d611ffe
PE
29592013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2962
999c74e3
EZ
29632013-07-24 Eli Zaretskii <eliz@gnu.org>
2964
2965 * xdisp.c (redisplay_window): Instead of moving point out of
2966 scroll margin, reject the force_start method, and try scrolling
2967 instead. (Bug#14780)
2968
198fa217
KB
29692013-07-24 Ken Brown <kbrown@cornell.edu>
2970
2971 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2972 (Bug#14944).
2973
53840e55
PE
29742013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 * eval.c (Fprogn): Do not check that BODY is a proper list.
2977 This undoes the previous change. The check slows down the
2978 interpreter, and is not needed to prevent a crash. See
2979 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2980
60967f56
GM
29812013-07-23 Glenn Morris <rgm@gnu.org>
2982
2983 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2984
9ca960e2
PE
29852013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2986
a29c3e6d
PE
2987 Port to GNU/Linux systems with tinfo but not ncurses.
2988 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2989 to decide whether ncurses is being used. Without this change,
2990 GCC complains about tgetent not being declared, on a system
2991 that has tinfo installed but ncurses not installed.
2992
f274311c
PE
2993 * eval.c (Fprogn): Check that BODY is a proper list.
2994
16b0520a
PE
2995 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2996 * data.c (Fsetq_default):
2997 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2998 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2999 (Fcondition_case):
3000 Tune by taking advantage of the fact that ARGS is always a list
3001 when a function is declared to have UNEVALLED args.
3002
9ca960e2
PE
3003 * emacsgtkfixed.c: Port to GCC 4.6.
3004 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
3005
afacaa1b
JB
30062013-07-23 Juanma Barranquero <lekktu@gmail.com>
3007
3008 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
3009 here to silence compiler warnings.
3010
368a85a4
PE
30112013-07-22 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
3014 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
3015 from messing up Emacs's 'struct frame' (Bug#14923).
3016
f4e891b5
PE
30172013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * alloc.c (make_save_ptr_ptr): Define this function.
3020 It was inadvertently omitted. It's needed only if
3021 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
3022
96c8b65e
JD
30232013-07-21 Jan Djärv <jan.h.d@swipnet.se>
3024
3025 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
3026 frame have focus (Bug#14895).
3027
ee010797
PE
30282013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 Avoid vfork-related deadlock more cleanly.
3031 * callproc.c (child_setup): When the child's exec fails, output
3032 the program name, as that's more useful. Use O_NONBLOCK to avoid
3033 deadlock.
3034 * process.c (create_process_1): Remove; no longer needed.
3035 (create_process): Remove timer hack; no longer needed, now that
3036 the child avoids deadlock.
3037
f0398ec1 30382013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
3039
3040 * image.c (Fimage_flush): Fix doc typo.
3041
b2a069c2
PE
30422013-07-20 Paul Eggert <eggert@cs.ucla.edu>
3043
6496aec9
PE
3044 Fix array bounds violation when pty allocation fails.
3045 * process.c (PTY_NAME_SIZE): New constant.
3046 (pty_name): Remove static variable; it's now auto.
3047 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
3048 Take pty_name as an arg rather than using a static variable.
3049 All callers changed.
3050 (create_process): Recover pty_flag from process, not from volatile local.
3051 (create_pty): Stay inside array even when pty allocation fails.
3052 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
3053
b2a069c2
PE
3054 * lread.c (Fload): Avoid initialization only when lint checking.
3055 Mention that it's needed only for older GCCs.
3056
99107004
KH
30572013-07-20 Kenichi Handa <handa@gnu.org>
3058
3059 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
3060 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
3061
6b1b199d
AS
30622013-07-20 Andreas Schwab <schwab@linux-m68k.org>
3063
3064 * lread.c (Fload): Avoid uninitialized warning.
3065
4195afc3
PE
30662013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3067
3f5bef16
PE
3068 Fix some minor file descriptor leaks and related glitches.
3069 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
3070 (create_lock_file): Use write, not emacs_write.
3071 * image.c (slurp_file, png_load_body):
3072 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
3073 (server_accept_connection):
3074 Don't leak an fd on memory allocation failure.
3075 * image.c (slurp_file): Add a cheap heuristic for growing files.
3076 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
3077 as that's what the other routines do. Maybe input need not be
3078 blocked at all, but it's better to be consistent.
3079 Avoid undefined behavior when strlen is zero.
3080
4195afc3
PE
3081 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
3082 (NSTATICS): Now a constant; doesn't need to be a macro.
3083
a1aeeffe
RS
30842013-07-19 Richard Stallman <rms@gnu.org>
3085
3086 * coding.c (decode_coding_utf_8): Add simple loop for fast
3087 processing of ASCII characters.
3088
63b34baa
PE
30892013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3090
3091 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
3092
621dd9ac
EZ
30932013-07-19 Eli Zaretskii <eliz@gnu.org>
3094
3095 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
3096 unportable 'struct x_display_info'.
3097 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
3098 is a portable type.
3099
1396ac86
PE
31002013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3101
ab9980cd
PE
3102 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
3103 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
3104 or fscanf fails.
3105 (system_process_attributes): Prefer plain char to unsigned char
3106 when either will do. Clean up properly if interrupted or if
068f9124
SM
3107 memory allocations fail. Don't assume sscanf succeeds.
3108 Remove no-longer-needed workaround to stop GCC from whining.
3109 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
3110 bit more carefully.
3111
1396ac86
PE
3112 Fix obscure porting bug with varargs functions.
3113 The code assumed that int is treated like ptrdiff_t in a vararg
3114 function, which is not a portable assumption. There was a similar
3115 -- though these days less likely -- porting problem with various
3116 assumptions that pointers of different types all smell the same as
3117 far as vararg functions is conserved. To make this problem less
3118 likely in the future, redo the API to use varargs functions.
3119 * alloc.c (make_save_value): Remove this vararg function.
3120 All uses changed to ...
3121 (make_save_int_int_int, make_save_obj_obj_obj_obj)
3122 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
3123 New functions.
3124 (make_save_ptr): Rename from make_save_pointer, for consistency with
3125 the above. Define only on platforms that need it. All uses changed.
3126
4d19d194
PE
31272013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 * keyboard.c: Try to fix typos in previous change.
3130 (DISPLAY_LIST_INFO): New macro.
3131 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 3132 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 3133
945c5bb1
JB
31342013-07-18 Juanma Barranquero <lekktu@gmail.com>
3135
3136 * keyboard.c (kbd_buffer_get_event):
3137 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
3138 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
3139
f4b1eb36
PE
31402013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3141
5e679a2c
PE
3142 * filelock.c: Fix unlikely file descriptor leaks.
3143 (get_boot_time_1): Rework to avoid using emacs_open.
3144 This doesn't actually fix a leak, but is better anyway.
3145 (read_lock_data): Use read, not emacs_read.
3146
a8cd4836
PE
3147 * doc.c: Fix minor memory and file descriptor leaks.
3148 * doc.c (get_doc_string): Fix memory leak when doc file absent.
3149 (get_doc_string, Fsnarf_documentation):
3150 Fix file descriptor leak on error.
3151
ef30e638
PE
3152 * term.c: Fix minor fdopen-related file descriptor leaks.
3153 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
3154 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
3155
f4b1eb36
PE
3156 * charset.c: Fix file descriptor leaks and errno issues.
3157 Include <errno.h>.
3158 (load_charset_map_from_file): Don't leak file descriptor on error.
3159 Use plain record_xmalloc since the allocation is larger than
3160 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
3161 of entries.
3162 * eval.c (record_unwind_protect_nothing):
3163 * fileio.c (fclose_unwind):
3164 New functions.
3165 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
3166 The replacement doesn't block input, but that no longer seems
3167 necessary.
3168
b648c163
PE
31692013-07-17 Paul Eggert <eggert@cs.ucla.edu>
3170
a0931322
PE
3171 * lread.c: Fix file descriptor leaks and errno issues.
3172 (Fload): Close some races that leaked fds or streams when 'load'
3173 was interrupted.
3174 (Fload, openp): Report error number of last nontrivial failure to open.
3175 ENOENT counts as trivial.
3176 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
3177 New functions.
3178 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
3179 now that the function is always called with a nonnegative arg.
3180 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
3181 All uses replaced with ...
3182 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
3183
b648c163
PE
3184 A few more minor file errno-reporting bugs.
3185 * callproc.c (Fcall_process):
3186 * doc.c (Fsnarf_documentation):
3187 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
3188 * process.c (set_socket_option):
3189 Don't let a constructor trash errno.
3190 * doc.c: Include <errno.h>.
3191
b1dc4084
JB
31922013-07-16 Juanma Barranquero <lekktu@gmail.com>
3193
3194 * w32fns.c (unwind_create_tip_frame): Fix declaration.
3195
c43843aa
PE
31962013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3197
50a30cce
PE
3198 Fix w32 bug with call-process-region (Bug#14885).
3199 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
3200 to Fcall_process when the input is empty. This simplifies the
3201 code a bit. It makes no difference on POSIXish platforms but
3202 apparently it fixes a bug on w32.
3203
44e18199 3204 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
3205 * fileio.c (close_file_unwind): Don't close if FD is negative;
3206 this can happen when unwinding a zapped file descriptor.
3207 (Finsert_file_contents): Unwind-protect the fd before the point marker,
3208 in case Emacs runs out of memory between the two unwind-protects.
3209 Don't trash errno when closing FD.
3210 Zap the FD in the specpdl when closing it, instead of deferring
3211 the removal of the unwind-protect; this fixes a bug where a child
3212 function unwinds the stack past us.
3213
27e498e6
PE
3214 New unwind-protect flavors to better type-check C callbacks.
3215 This also lessens the need to write wrappers for callbacks,
3216 and the need for make_save_pointer.
3217 * alloca.c (free_save_value):
3218 * atimer.c (run_all_atimers):
3219 Now extern.
3220 * alloc.c (safe_alloca_unwind):
3221 * atimer.c (unwind_stop_other_atimers):
3222 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
3223 * menu.c (cleanup_popup_menu) [HAVE_NS]:
3224 * minibuf.c (choose_minibuf_frame_1):
3225 * process.c (make_serial_process_unwind):
3226 * xdisp.h (pop_message_unwind):
3227 * xselect.c (queue_selection_requests_unwind):
3228 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
3229 * alloca.c (record_xmalloc):
3230 Prefer record_unwind_protect_ptr to record_unwind_protect with
3231 make_save_pointer.
3232 * alloca.c (Fgarbage_collect):
3233 Prefer record_unwind_protect_void to passing a dummy.
3234 * buffer.c (restore_buffer):
3235 * window.c (restore_window_configuration):
3236 * xfns.c, w32fns.c (do_unwind_create_frame)
3237 New wrapper. All record-unwind uses of wrappee changed.
3238 * buffer.c (set_buffer_if_live):
3239 * callproc.c (call_process_cleanup, delete_temp_file):
3240 * coding.c (code_conversion_restore):
3241 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
3242 * editfns.c (save_excursion_restore)
3243 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
3244 (save_restriction_restore):
3245 * eval.c (restore_stack_limits, un_autoload):
3246 * fns.c (require_unwind):
3247 * keyboard.c (recursive_edit_unwind, tracking_off):
3248 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
3249 * macros.c (pop_kbd_macro, restore_menu_items):
3250 * nsfns.m (unwind_create_frame):
3251 * print.c (print_unwind):
3252 * process.c (start_process_unwind):
3253 * search.c (unwind_set_match_data):
3254 * window.c (select_window_norecord, select_frame_norecord):
3255 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
3256 (fast_set_selected_frame):
3257 * xfns.c, w32fns.c (unwind_create_tip_frame):
3258 Return void, not a dummy Lisp_Object. All uses changed.
3259 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
3260 * callproc.c (call_process_kill):
3261 * fileio.c (restore_point_unwind, decide_coding_unwind)
3262 (build_annotations_unwind):
3263 * insdel.c (Fcombine_after_change_execute_1):
3264 * keyboard.c (read_char_help_form_unwind):
3265 * menu.c (unuse_menu_items):
3266 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
3267 * sound.c (sound_cleanup):
3268 * xdisp.c (unwind_redisplay):
3269 * xfns.c (clean_up_dialog):
3270 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
3271 Accept no args and return void, instead of accepting and returning
3272 a dummy Lisp_Object. All uses changed.
3273 * cygw32.c (fchdir_unwind):
3274 * fileio.c (close_file_unwind):
3275 * keyboard.c (restore_kboard_configuration):
3276 * lread.c (readevalllop_1):
3277 * process.c (wait_reading_process_output_unwind):
3278 Accept int and return void, rather than accepting an Emacs integer
3279 and returning a dummy object. In some cases this fixes an
3280 unlikely bug when the corresponding int is outside Emacs integer
3281 range. All uses changed.
3282 * dired.c (directory_files_internal_unwind):
3283 * fileio.c (do_auto_save_unwind):
3284 * gtkutil.c (pop_down_dialog):
3285 * insdel.c (reset_var_on_error):
3286 * lread.c (load_unwind):
3287 * xfns.c (clean_up_file_dialog):
3288 * xmenu.c, nsmenu.m (pop_down_menu):
3289 * xmenu.c (cleanup_widget_value_tree):
3290 * xselect.c (wait_for_property_change_unwind):
3291 Accept pointer and return void, rather than accepting an Emacs
3292 save value encapsulating the pointer and returning a dummy object.
3293 All uses changed.
3294 * editfns.c (Fformat): Update the saved pointer directly via
3295 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3296 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3297 (unwind_body): New function.
3298 (record_unwind_protect): First arg is now a function returning void,
3299 not a dummy Lisp_Object.
3300 (record_unwind_protect_ptr, record_unwind_protect_int)
3301 (record_unwind_protect_void): New functions.
3302 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3303 * fileio.c (struct auto_save_unwind): New type.
3304 (do_auto_save_unwind): Use it.
3305 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3306 * insdel.c (struct rvoe_arg): New type.
3307 (reset_var_on_error): Use it.
3308 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3309 New constants.
3310 (specbinding_func): Remove; there are now several such functions.
3311 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3312 (set_unwind_protect_ptr): New function.
3313 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3314
4e604a5d
PE
3315 Be simpler and more consistent about reporting I/O errors.
3316 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3317 Say "Read error" and "Write error", rather than "I/O error", or
3318 "IO error reading", or "IO error writing", when a read or write
3319 error occurs.
3320 * process.c (Fmake_network_process, wait_reading_process_output)
3321 (send_process, Fprocess_send_eof, wait_reading_process_output):
3322 Capitalize diagnostics consistently. Put "failed foo" at the
3323 start of the diagnostic, so that we don't capitalize the
3324 function name "foo". Consistently say "failed" for such
3325 diagnostics.
3326 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3327 All callers changed. This is so it can use report_file_error.
3328 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3329 diagnostics consistently as above.
3330
a9757f6a
PE
3331 * fileio.c (report_file_errno): Fix errno reporting bug.
3332 If the file name is neither null nor a pair, package it up as a
3333 singleton list. All callers changed, both to this function and to
3334 report_file_error. This fixes a bug where the memory allocator
3335 invoked by list1 set errno so that the immediately following
3336 report_file_error reported the wrong errno value.
3337
c43843aa
PE
3338 Fix minor problems found by --enable-gcc-warnings.
3339 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3340 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3341
18c26d81
JD
33422013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3343
3344 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3345 Set event->arg to Qt if switch-event shall be generated.
3346 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3347
3348 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3349
3350 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3351 FOCUS_OUT_EVENT.
3352
3353 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3354 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3355 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3356 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3357 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3358 and there is a focused frame.
3359 (head_table): Add focus-in and focus-out.
3360 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3361 bind to handle-focus-in/out.
3362
3363 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3364 (Fhandle_switch_frame): Call Fhandle_focus_in.
3365 (syms_of_frame): defsubr handle-focus-in/out.
3366
6c6f1994
PE
33672013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3368
c7ddc792
PE
3369 Fix porting bug to older POSIXish platforms (Bug#14862).
3370 * sysdep.c (emacs_pipe): New function, that implements
3371 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3372 This should port better to CentOS 5 and to Mac OS X 10.6.
3373 All calls to pipe2 changed.
3374
6c6f1994
PE
3375 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3376 This makes the code easier to read and the executable a bit smaller.
3377 Do not replace all calls to Fcons that happen to create lists,
3378 just calls that are intended to create lists. For example, when
3379 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3380 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3381 Similarly for list2 through list5.
3382 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3383 * bytecode.c (exec_byte_code):
3384 * callint.c (quotify_arg, Fcall_interactively):
3385 * callproc.c (Fcall_process, create_temp_file):
3386 * charset.c (load_charset_map_from_file)
3387 (Fdefine_charset_internal, init_charset):
3388 * coding.c (get_translation_table, detect_coding_system)
3389 (Fcheck_coding_systems_region)
3390 (Fset_terminal_coding_system_internal)
3391 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3392 * composite.c (update_compositions, Ffind_composition_internal):
3393 * dired.c (directory_files_internal, file_name_completion)
3394 (Fsystem_users):
3395 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3396 * doc.c (Fsnarf_documentation):
3397 * editfns.c (Fmessage_box):
3398 * emacs.c (main):
3399 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3400 (Feval, eval_sub, Ffuncall, apply_lambda):
3401 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3402 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3403 (Fset_file_times, Finsert_file_contents)
3404 (Fchoose_write_coding_system, Fwrite_region):
3405 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3406 * font.c (font_registry_charsets, font_parse_fcname)
3407 (font_prepare_cache, font_update_drivers, Flist_fonts):
3408 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3409 * frame.c (make_frame, Fmake_terminal_frame)
3410 (x_set_frame_parameters, x_report_frame_params)
3411 (x_default_parameter, Fx_parse_geometry):
3412 * ftfont.c (syms_of_ftfont):
3413 * image.c (gif_load):
3414 * keyboard.c (command_loop_1):
3415 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3416 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3417 (Fminor_mode_key_binding, accessible_keymaps_1)
3418 (Faccessible_keymaps, Fwhere_is_internal):
3419 * lread.c (read_emacs_mule_char):
3420 * menu.c (find_and_return_menu_selection):
3421 * minibuf.c (get_minibuffer):
3422 * nsfns.m (Fns_perform_service):
3423 * nsfont.m (ns_script_to_charset):
3424 * nsmenu.m (ns_popup_dialog):
3425 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3426 (Fx_own_selection_internal):
3427 * nsterm.m (append2):
3428 * print.c (Fredirect_debugging_output)
3429 (print_prune_string_charset):
3430 * process.c (Fdelete_process, Fprocess_contact)
3431 (Fformat_network_address, set_socket_option)
3432 (read_and_dispose_of_process_output, write_queue_push)
3433 (send_process, exec_sentinel):
3434 * sound.c (Fplay_sound_internal):
3435 * textprop.c (validate_plist, add_properties)
3436 (Fput_text_property, Fadd_face_text_property)
3437 (copy_text_properties, text_property_list, syms_of_textprop):
3438 * unexaix.c (report_error):
3439 * unexcoff.c (report_error):
3440 * unexsol.c (unexec):
3441 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3442 (Fformat_mode_line, syms_of_xdisp):
3443 * xfaces.c (set_font_frame_param)
3444 (Finternal_lisp_face_attribute_values)
3445 (Finternal_merge_in_global_face, syms_of_xfaces):
3446 * xfns.c (x_default_scroll_bar_color_parameter)
3447 (x_default_font_parameter, x_create_tip_frame):
3448 * xfont.c (xfont_supported_scripts):
3449 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3450 (menu_help_callback, xmenu_show):
3451 * xml.c (make_dom):
3452 * xterm.c (set_wm_state):
3453 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3454 and similarly for list2 through list5.
3455
bafe80ce
PE
34562013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3457
3458 * callproc.c (Fcall_process_region): Fix minor race and tune.
3459 (create_temp_file): New function, with the temp-file-creation part
3460 of the old Fcall_process_region. Use Fcopy_sequence to create the
3461 temp file name, rather than alloca + build_string, for simplicity.
3462 Don't bother to block input around the temp file creation;
068f9124
SM
3463 shouldn't be needed. Simplify use of mktemp.
3464 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3465 this closes an unlikely race where the temp file was not removed.
3466 Use memcpy rather than an open-coded loop.
3467 (Fcall_process_region): Use the new function. If the input is
3468 empty, redirect from /dev/null rather than from a newly created
3469 empty temp file; this avoids unnecessary file system traffic.
3470
4700b5a5
PE
34712013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3472
5c97beae
PE
3473 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3474 Simplify by making this case like the other two. This is a bit
3475 slower on obsolete hosts, but the extra complexity isn't worth it.
3476
4700b5a5
PE
3477 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3478 * process.c (create_process) [!DOS_NT]:
3479 Remove now-unnecessary calls to emacs_close.
3480
f9a74c4c
EZ
34812013-07-13 Eli Zaretskii <eliz@gnu.org>
3482
922ae7ee
EZ
3483 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3484 returning early. (Bug#14850)
3485
f9a74c4c
EZ
3486 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3487 and inhibit-iso-escape-detection attributes of 'undecided'.
3488 (Bug#14822)
3489
5e301d76
PE
34902013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3491
69e0e5ee
PE
3492 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3493 Reported by Herbert J. Skuhra in
3494 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3495
5e301d76
PE
3496 Don't lose top specpdl entry when memory is exhausted.
3497 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3498 specpdl overflow here, to simplify callers; all callers changed.
3499 Always reserve an unused entry at the stack top; this avoids
3500 losing the top entry's information when memory is exhausted.
3501
7e649856
PE
35022013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3503
a773ed9a
PE
3504 Clean up errno reporting and fix some errno-reporting bugs.
3505 * callproc.c (Fcall_process):
3506 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3507 * process.c (create_process, Fmake_network_process):
3508 * unexaix.c (report_error):
3509 * unexcoff.c (report_error):
3510 Be more careful about reporting the errno of failed operations.
3511 The code previously reported the wrong errno sometimes.
3512 Also, prefer report_file_errno to setting errno + report_file_error.
3513 (Fcall_process): Look at openp return value rather than at path,
3514 as that's a bit faster and clearer when there's a numeric predicate.
3515 * fileio.c (report_file_errno): New function, with most of the
3516 old contents of report_file_error.
3517 (report_file_error): Use it.
3518 (Ffile_exists_p, Ffile_accessible_directory_p):
3519 Set errno to 0 when it is junk.
3520 * fileio.c (Faccess_file):
3521 * image.c (x_create_bitmap_from_file):
3522 Use faccessat rather than opening the file, to avoid the hassle of
3523 having a file descriptor open.
3524 * lisp.h (report_file_errno): New decl.
3525 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3526
7e649856
PE
3527 Minor EBADF fixes.
3528 * process.c (create_process, wait_reading_process_output) [AIX]:
3529 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3530 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3531 a multithreaded environment anyway).
3532 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3533
f6774c1a
AS
35342013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3535
3536 * image.c (x_find_image_file): Don't close a remote file handle.
3537
bacba3c2
PE
35382013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3539
3540 Fix races with threads and file descriptors.
3541 * callproc.c (Fcall_process_region):
3542 * dired.c (open_directory):
3543 * emacs.c (main, Fdaemon_initialized):
3544 * image.c (x_find_image_file):
3545 * inotify.c (Finotify_rm_watch):
3546 * lread.c (Flocate_file_internal):
3547 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3548 * term.c (term_mouse_moveto, init_tty):
3549 * termcap.c (tgetent):
3550 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3551 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3552 * unexhp9k800.c, unexmacosx.c (unexec):
3553 * callproc.c (Fcall_process_region):
3554 Use emacs_close, not close.
3555 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3556 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3557 and posix_close function on current platforms (which all lack them).
3558 (emacs_close): Use it. This should fix the races on GNU/Linux and
3559 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3560 and it should avoid closing random victim file descriptors on
3561 other platforms.
3562
653d4f43
PE
35632013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3564
c8536ec4
PE
3565 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3566 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3567 Touch up doc a bit.
3568
9c203066
PE
3569 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3570 This is for .gdbinit xbacktrace.
3571
653d4f43
PE
3572 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3573 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3574 (emacs_set_tty): Now static.
3575 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3576 * term.c (tty_capable_p, tty_default_color_capabilities)
3577 (get_tty_terminal, term_mouse_movement)
3578 (handle_one_term_event, init_tty, maybe_fatal):
3579 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3580 (tgetent, scan_file, name_match, compare_contin):
3581 * terminal.c (get_terminal):
3582 Use bool for boolean.
3583 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3584 Prefer char to unsigned char if either will do.
3585 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3586 (tty_write_glyphs): Prefer int to unsigned.
3587 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3588 All callers changed.
3589 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3590
45b683a1
PE
35912013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3592
29abe551
PE
3593 Port to C89.
3594 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3595 (B__dummy__): New dummy symbol, to pacify C89.
3596 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3597 they can't grok varargs macros.
3598 * dispnew.c (add_window_display_history)
3599 (add_frame_display_history):
3600 * print.c (print_object):
3601 * xdisp.c (debug_method_add):
3602 Use %p printf format only for void pointers.
3603 * emacs.c (usage_message): New constant, replacing ...
3604 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3605 (main): Adjust to usage reorg.
3606 * fns.c (syms_of_fns):
3607 * profiler.c (syms_of_profiler):
3608 Don't use non-constant struct initializers.
3609 * gnutls.h (gnutls_initstage_t):
3610 * lisp.h (enum Lisp_Fwd_Type):
3611 * lread.c (lisp_file_lexically_bound_p):
3612 * xsettings.c (anonymous enum):
3613 Remove trailing comma.
3614 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3615 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3616 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3617 (DEFUN): Use it.
3618 * regex.c (const_re_char): New type, to pacify strict C89.
3619 All uses of 'const re_char' replaced to use it.
3620 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3621 with glibc when strict C89. This change is imported from gnulib.
3622 All uses changed.
3623 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3624 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3625 Omit GNU_LINUX implementation, since it requires long long.
3626 * xterm.c (x_draw_underwave):
3627 Do not assume the traditional order of struct's members.
3628 (x_term_init): Rewrite to avoid the need for non-constant structure
3629 initializers.
3630
45b683a1 3631 Syntax cleanup, mostly replacing macros with functions.
763a086d 3632 This removes the need for the syntax_temp hack.
45b683a1
PE
3633 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3634 * syntax.c (SYNTAX_INLINE): New macro.
3635 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3636 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3637 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3638 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3639 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3640 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3641 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3642 Now constants, not macros.
3643 (syntax_temp) [!__GNUC__]: Remove.
3644 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3645 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3646 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3647 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3648 Move here from syntax.h; now functions, not macros. Except for the
3649 last function, these are static since only syntax.c uses them.
3650 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3651 All uses changed. Now a function, not a macro; use this fact
3652 to simplify the code.
3653 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3654 compiler bugs; no longer relevant.
3655 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3656 (SYNTAX_INLINE): New macro.
3657 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3658 for the new functions. Use bool for boolean member.
3659 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3660 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3661 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3662 (SETUP_BUFFER_SYNTAX_TABLE):
3663 Now extern inline functions, not macros.
3664 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3665 Remove; all uses replaced by implementation.
3666 (syntax_temp) [!__GNUC__]: Remove decl.
3667 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3668
29be4a50
JD
36692013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3670
3671 * emacs.c (main): Fix syntax error.
3672
954b166e
PE
36732013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3674
3675 Timestamp fixes for undo (Bug#14824).
3676 * atimer.c (schedule_atimer):
3677 * fileio.c (Ffile_newer_than_file_p):
3678 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3679 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3680 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3681 (syms_of_fileio): Remove Sclear_visited_file_name.
3682 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3683 file doesn't exist; this avoids an ambiguity with negative timestamps.
3684 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3685 * systime.h (make_emacs_time, invalid_emacs_time):
3686 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3687 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3688 * undo.c (record_first_change): Push (visited-file-modtime) onto
3689 undo list rather than reimplementing it by hand, incorrectly.
3690
d74647c3
KB
36912013-07-09 Ken Brown <kbrown@cornell.edu>
3692
3693 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3694
3c51b96b
JB
36952013-07-09 Juanma Barranquero <lekktu@gmail.com>
3696
3697 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3698
4ebbdd67
PE
36992013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3700
3701 Handle errno and exit status a bit more carefully.
3702 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3703 number into an exit status. Instead, use EXIT_CANCELED.
3704 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3705 * callproc.c (relocate_fd):
3706 * emacs.c (close_output_streams, main):
3707 * process.c (create_process):
3708 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3709 Use emacs_perror for simplicity.
3710 * callproc.c (relocate_fd, main):
3711 * sysdep.c (sys_subshell):
3712 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3713 (shut_down_emacs): Use emacs_write, not write.
3714 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3715 * fileio.c (Fcopy_file, e_write):
3716 * nsterm.m (ns_select):
3717 * process.c (send_process):
3718 * sound.c (vox_write):
3719 Use emacs_write_sig, not emacs_write.
3720 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3721 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3722 New constants.
3723 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3724 of write.
3725 (emacs_full_write): New function.
3726 (emacs_write): Rewrite to use it.
3727 (emacswrite_sig, emacs_perror): New functions.
3728 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3729
44e18199 37302013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3731
3732 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3733 on NS even if it is present. Pixmap on NS is a void*.
3734
9caab067
PE
37352013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 Port to Ubuntu 10 (Bug#14803).
3738 Problem reported by T.V. Raman.
3739 * process.c (close_on_exec, accept4, process_socket):
3740 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3741
1d442672
EZ
37422013-07-07 Eli Zaretskii <eliz@gnu.org>
3743
3744 * w32.c (sys_dup): Declare prototype.
3745
3746 * filelock.c:
3747 * emacs.c:
3748 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3749
067428c1
PE
37502013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3751
3752 Make file descriptors close-on-exec when possible (Bug#14803).
3753 This simplifies Emacs a bit, since it no longer needs to worry
3754 about closing file descriptors by hand in some cases.
3755 It also fixes some unlikely races. Not all such races, as
3756 libraries often open files internally without setting
3757 close-on-exec, but it's an improvement.
3758 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3759 * callproc.c (Fcall_process) [!MSDOS]:
3760 * emacs.c (main) [!DOS_NT]:
3761 * nsterm.m (ns_term_init):
3762 * process.c (create_process):
3763 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3764 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3765 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3766 Prefer mkostemp with O_CLOEXEC to mkstemp.
3767 * callproc.c (relocate_fd) [!WINDOWSNT]:
3768 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3769 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3770 now using pipe2.
3771 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3772 Make the resulting file descriptor close-on-exec.
3773 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3774 * lread.c (load_descriptor_list, load_descriptor_unwind):
3775 Remove; no longer needed. All uses removed.
3776 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3777 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3778 New functions.
3779 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3780 (Fmake_network_process, Fnetwork_interface_list):
3781 (Fnetwork_interface_info, server_accept_connection):
3782 Make newly-created socket close-on-exec.
3783 * sysdep.c (emacs_open, emacs_fopen):
3784 Make new-created descriptor close-on-exec.
3785 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3786 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3787
0da857dd
JD
37882013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3789
3790 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3791 for NS_IMPL_GNUSTEP.
3792
5f86adcd
PE
37932013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3794
3795 Fix openp errno handling.
3796 * callproc.c (Fcall_process): Preserve openp errno around close.
3797 * lread.c (openp): Set errno when returning -1, as some callers
3798 expect this.
3799
1afb1d07
JD
38002013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3801
3802 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3803
3804 * nsterm.h (NSSavePanel): Update comment.
3805 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3806 (ns_run_file_dialog): Declare.
3807
3808 * nsfns.m: Remove panelOK.
3809 (ns_fd_data): New.
3810 (ns_run_file_dialog): New function.
3811 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3812 event loop, so file dialog is popped up by ns_run_file_dialog, called
3813 by sendEvent (Bug#14578).
3814 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3815
3323c263
EZ
38162013-07-06 Eli Zaretskii <eliz@gnu.org>
3817
fdda0220
EZ
3818 * xdisp.c (default_line_pixel_height): New function.
3819 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3820 (try_cursor_movement, redisplay_window, try_window)
3821 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3822
068f9124
SM
3823 * window.c (window_scroll_pixel_based):
3824 use default_line_pixel_height.
fdda0220
EZ
3825
3826 * dispextern.h (default_line_pixel_height): Add prototype.
3827
3828 * frame.c (x_set_line_spacing): Accept a float value for
3829 line-spacing parameter, per the documentation.
3830
3323c263
EZ
3831 * data.c (Fmultibyte_string_p): Doc fix.
3832
47ba6d43
PE
38332013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3834
406af475
PE
3835 Use emacs_open more consistently when opening files.
3836 This handles EINTR more consistently now, and makes it easier
3837 to introduce other uniform changes to file descriptor handling.
3838 * src/systdio.h: New file.
3839 * src/buffer.c (mmap_init):
3840 * cygw32.c (chdir_to_default_directory):
3841 * dispnew.c (Fopen_termscript):
3842 * emacs.c (Fdaemon_initialized):
3843 * fileio.c (Fdo_auto_save):
3844 * image.c (slurp_file, png_load_body, jpeg_load_body):
3845 * keyboard.c (Fopen_dribble_file):
3846 * lread.c (Fload):
3847 * print.c (Fredirect_debugging_output):
3848 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3849 * termcap.c (tgetent):
3850 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3851 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3852 * w32term.c (w32_initialize) [CYGWIN]:
3853 * xfaces.c (Fx_load_color_file):
3854 Use emacs_open instead of plain open, and emacs_fopen instead of
3855 plain fopen.
3856 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3857 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3858 * callproc.c (default_output_mode): New constant.
3859 (Fcall_process): Use it to call emacs_open instead of plain creat.
3860 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3861 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3862 (emacs_fopen): New function.
3863 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3864 Include <lisp.h>, for emacs_open.
3865 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3866
47ba6d43
PE
3867 Remove duplicate #include directives.
3868 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3869 * xfaces.c:
3870 Don't include stdio.h twice.
3871 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3872 Don't include sys/types.h or stdio.h twice.
3873 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3874 * lread.c: Don't include coding.h twice.
3875 * nsfont.m: Don't include frame.h twice.
3876 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3877 * ralloc.c: Don't include <unistd.h> twice.
3878 * xdisp.c: Don't include font.h twice.
3879 * xterm.c: Don't include fontset.h twice.
3880 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3881
b9ed53d5
PE
38822013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3883
3884 Scale ImageMagick images more carefully.
3885 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3886 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3887 Be more careful about avoiding undefined behavior after
3888 integer overflow and division by zero.
3889
cf13177e
YM
38902013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3891
3892 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3893 (syms_of_w32fns): DEFSYM them.
3894 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3895 (CCHDEVICENAME): Define macros if not defined.
3896 (struct MONITOR_INFO_EX): New struct.
3897 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3898 (enum_display_monitors_fn): New variable.
3899 (globals_of_w32fns): Initialize it.
3900 (Fx_display_pixel_width, Fx_display_pixel_height)
3901 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3902 multi-monitor setups in docstrings.
3903 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3904 screen size by primary monitor's millimeter per pixel.
3905 (w32_monitor_enum, w32_display_monitor_attributes_list)
3906 (w32_display_monitor_attributes_list_fallback)
3907 (Fw32_display_monitor_attributes_list): New functions.
3908 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3909
3910 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3911 if not defined.
3912 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3913
86dfb7a8
MA
39142013-07-04 Michael Albinus <michael.albinus@gmx.de>
3915
3916 * fileio.c (Qfile_notify_error): New error symbol.
3917
3918 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3919 * inotify.c (inotify_callback, symbol_to_inotifymask)
3920 (Finotify_add_watch, Finotify_rm_watch): Use it.
3921 (inotifyevent_to_event): Exchange order of cookie and file name.
3922 (Finotify_add_watch): Adapt docstring.
3923
3924 * lisp.h (Qfile_notify_error): Declare.
3925
2c1c974b
PE
39262013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3929 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3930 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3931 which did not work (see <http://bugs.gnu.org/14569#307>).
3932 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3933 && (!noninteractive || initialized)). This attempts to thread
3934 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3935
7a35b20f
JB
39362013-07-04 Juanma Barranquero <lekktu@gmail.com>
3937
3938 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3939 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3940
1ce5cd04
PE
39412013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3944 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3945 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3946 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3947
57f8c490
PE
39482013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3951 Define to __sys_siglist.
3952
bcffb5ca
EZ
39532013-07-02 Eli Zaretskii <eliz@gnu.org>
3954
3955 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3956 word-wrap, so that overflow-newline-into-fringe would work in
3957 visual-line-mode. (Bug#2749)
3958 (move_it_in_display_line_to): When the last scanned display
3959 element fits exactly on the display line, and
3960 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3961 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3962 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3963 finding buffer position that corresponds to pixel coordinates,
3964 e.g. in buffer_posn_from_coords.
3965
2c41e781
JD
39662013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3967
3968 * process.c (handle_child_signal): Call catch_child_signal if
3969 NS_IMPL_GNUSTEP.
3970
c2418359
PE
39712013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3972
52a9bcae
PE
3973 Don't convert function pointers to void * and back.
3974 It isn't portable C, and it's easy enough to avoid.
3975 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3976 (make_save_value): Add support for SAVE_FUNCPOINTER.
3977 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3978 * print.c (print_object):
3979 Distinguish function from object pointers.
3980 * lisp.h (SAVE_FUNCPOINTER): New constant.
3981 (SAVE_SLOT_BITS): Adjust to it.
3982 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3983 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3984 (voidfuncptr): New typedef.
3985 (struct Lisp_Save_Value): New member data[0].funcpointer.
3986 (XSAVE_FUNCPOINTER): New function.
3987
c2418359
PE
3988 Simplify buildobj processing.
3989 * Makefile.in (buildobj.h): Make it a sequence of strings each
3990 followed by comma, rather than a single string. Put it into a
3991 .tmp file in case there's an error while generating it.
3992 (gl-stamp): Use .tmp for temp files.
3993 (mostlyclean): Clean .tmp files.
3994 * doc.c (buildobj): Move to just the routine that needs it.
3995 It's now an array of strings, so processing is simpler.
3996
8f43ce49
PE
39972013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3998
3999 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
4000 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
4001 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4002 Invoke malloc_enable_thread even when not interactive.
4003 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
4004 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
4005 in this case, since the underlying bug has now been fixed.
4006
24827db9
JB
40072013-07-01 Juanma Barranquero <lekktu@gmail.com>
4008
4009 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
4010 unlinking it (bug#14691).
4011
ef099a94
MN
40122013-06-30 Michal Nazarewicz <mina86@mina86.com>
4013
4014 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
4015 before checking whether buffer is modified. This lets
4016 `kill-buffer-query-functions' cancel killing of the buffer or save
4017 its content before `kill-buffer' asks user the "Buffer %s
4018 modified; kill anyway?" question.
4019
9d3f2fc2
JD
40202013-06-30 Jan Djärv <jan.h.d@swipnet.se>
4021
4022 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
4023 Let the super performKeyEquivalent deal with them (Bug#14747).
4024
e6c6c8c7
PE
40252013-06-30 Paul Eggert <eggert@cs.ucla.edu>
4026
1d71c1d9
PE
4027 * widget.c (resize_cb): Remove unused local.
4028
8f5f35cc
PE
4029 Do not use GTK 3 if it exists but cannot be compiled.
4030 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
4031 * xterm.c (x_error_handler) [!USE_GTK]:
4032 Do not use GTK 3.
4033
e6c6c8c7
PE
4034 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
4035
0ba54312
EZ
40362013-06-30 Eli Zaretskii <eliz@gnu.org>
4037
5d1c3286
EZ
4038 * intervals.c (get_local_map): Instead of aborting, clip POSITION
4039 to the valid range of values. (Bug#14753)
4040
0ba54312
EZ
4041 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
4042 when moving point by using the current glyph matrix. This avoids
4043 the need to force redisplay when this function is called in a
4044 loop.
4045
9c90cc06
PE
40462013-06-29 Paul Eggert <eggert@cs.ucla.edu>
4047
4048 Fix minor problems found by static checking.
4049 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
4050 Redo the latter's body to sidestep GCC parenthesization warnings.
4051 (setup_coding_system, detect_coding, detect_coding_system): Use them.
4052 * coding.c (detect_coding, detect_coding_system):
4053 * coding.h (struct undecided_spec):
4054 Use bool for boolean.
4055 * image.c (QCmax_width, QCmax_height): Now static.
4056 * xdisp.c (Fmove_point_visually): Remove unused local.
4057
4c672a0f
EZ
40582013-06-29 Eli Zaretskii <eliz@gnu.org>
4059
4060 * xdisp.c (Fmove_point_visually): New function.
4061
c1ea3abf
JB
40622013-06-28 Kenichi Handa <handa@gnu.org>
4063
4064 * coding.h (define_coding_undecided_arg_index): New enum.
4065 (coding_attr_index): New members
4066 coding_attr_undecided_inhibit_null_byte_detection,
4067 coding_attr_undecided_inhibit_iso_escape_detection,
4068 coding_attr_undecided_prefer_utf_8.
4069 (undecided_spec): New struct.
4070 (struct coding_system): New member `undecided' of the member
4071 `spec'.
4072
4073 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
4074 (detect_coding): Likewise.
4075 (detect_coding_system): Likewise.
4076 (Fdefine_coding_system_internal): New coding system properties
4077 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
4078 :prefer-utf-8.
4079 (syms_of_coding): Adjust for coding_arg_undecided_max.
4080
ba3de9e6
PE
40812013-06-28 Paul Eggert <eggert@cs.ucla.edu>
4082
4083 * image.c (x_from_xcolors): Remove unused local.
4084
547c9269
YM
40852013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4086
4087 Defer image data transfer between X client and server until actual
4088 display happens.
4089
4090 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
4091 and `mask_img'.
4092
4093 * image.c (Destroy_Image): Remove.
4094 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
4095 `mask_p', and `colors_p'. All uses changed.
4096 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
4097 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
4098 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
4099 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
4100 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 4101 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
4102 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
4103 (image_get_x_image, image_unget_x_image): New functions or macros.
4104 (image_background, image_background_transparent, x_to_xcolors)
4105 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
4106 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
4107 instead of Destroy_Image.
4108 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
4109 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
4110 (png_load_body, jpeg_load_body, tiff_load, gif_load)
4111 (imagemagick_load_image, svg_load_image): Use them instead of
4112 x_create_x_image_and_pixmap, and x_put_x_image followed by
4113 x_destroy_x_image, respectively.
4114 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
4115 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
4116 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
4117 background_transparent fields.
4118 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
4119 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
4120
dae2f5ef
PE
41212013-06-27 Paul Eggert <eggert@cs.ucla.edu>
4122
4123 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
4124 This mostly consists of undoing recent changes.
4125 * callproc.c (Fcall_process):
4126 * process.c (create_process):
4127 Do not worry about catching SIGCHLD here, undoing previous change.
4128 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
4129 * process.c, process.h (catch_child_signal):
4130 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
4131 * process.c (catch_child_handler): Don't worry about being called
4132 lazily and do not assume caller has blocked SIGCHLD, undoing
4133 previous change. Move first-time stuff back to
4134 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
4135 tickle glib, as that causes Cygwin bootstrap to fail. Do not
4136 set lib_child_handler if it's already initialized, which may
4137 help avoid problems on GNUStep.
4138
fa55d2aa
PE
41392013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4140
4141 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
4142 * callproc.c (Fcall_process):
4143 * process.c (create_process):
4144 Make sure SIGCHLD is caught before we fork,
4145 since Emacs startup no arranges to catch SIGCHLD.
4146 * process.c (lib_child_handler): Initialize to null, not to
4147 dummy_handler.
4148 (catch_child_signal): Allow self to be called lazily.
4149 Do nothing if it's already been called.
4150 Assume caller has blocked SIGCHLD (all callers do now).
4151 * emacs.c (main): Do not catch SIGCHLD here; defer it until
4152 just before it's really needed.
4153 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
4154 since it hasn't been caught yet.
4155
f3f9606c
LMI
41562013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
4157
4158 * image.c (compute_image_size): New function to implement
4159 :max-width and :max-height.
4160 (imagemagick_load_image): Use it.
4161
c7041908
PE
41622013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4163
4164 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
4165 * callproc.c, process.h (block_child_signal, unblock_child_signal):
4166 Now extern.
4167 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
4168 * process.c (catch_child_signal): Block SIGCHLD while futzing with
4169 the SIGCHLD handler, since the code is not atomic and (due to glib)
4170 signals may be arriving now.
4171 * sysdep.c (init_signals): Do not catch child signals here;
4172 'main' now does that later, at a safer time.
4173
f86852b4
PE
41742013-06-22 Paul Eggert <eggert@cs.ucla.edu>
4175
0dfeed58
PE
4176 Clean up SIGCHLD handling a bit (Bug#14569).
4177 * process.c, process.h (catch_child_signal):
4178 Now always extern, even if !NS_IMPL_GNUSTEP.
4179 * process.c (catch_child_signal): Move glib tickler here from
4180 init_process_emacs, so that it's done earlier in Emacs
4181 initialization. Also move the noninteractive && !initialized
4182 check here from init_process_emacs. This is all a bit cleaner for
4183 GNUish platforms, and I hope it works around the Cygwin bug.
4184 * sysdep.c (init_signals): Invoke catch_child_signal here, so
4185 that glib signal handling is tickled before glib creates threads.
4186
f86852b4
PE
4187 * process.c (wait_reading_process_output): Avoid int overflow
4188 when reading more than 2 GiB total from a process.
4189
cbd6509c
PE
41902013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4191
4192 * process.c (create_process): Handle a couple more cases,
4193 i.e., work even if new_argv and wait_child_setup[i] are cached.
4194 Use Fcall_process's style for volatile vars.
4195
9de1114a
AS
41962013-06-21 Andreas Schwab <schwab@linux-m68k.org>
4197
4198 * process.c (create_process): Mark PROCESS volatile.
4199
fbe9e0b9
PE
42002013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4201
4202 Use C99-style flexible array members if available.
4203 This avoids some subtle aliasing issues, which typically
4204 aren't a problem with GCC but may be a problem elsewhere.
4205 * alloc.c (sdata): New typedef, replacing the old struct sdata.
4206 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
4207 In either case, it uses a flexible array member rather than
4208 the old struct hack. All uses changed.
4209 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
4210 Adjust to sdata reorganization.
4211 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
4212 Use offsetof (struct, flex_array_member), not sizeof (struct), as
4213 that ports better to pre-C99 non-GCC.
4214 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
4215 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
4216 as the latter has changed.
4217 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
4218 and port better to pre-C99 GCC.
4219 * image.c (struct xpm_cached_color):
4220 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
4221 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
4222 Use FLEXIBLE_ARRAY_MEMBER.
4223 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
4224 Move decl to top level so it gets checked against implementation.
4225 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
4226 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
4227
1fc71008
PE
42282013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4229
4230 * syntax.c: Integer cleanups.
4231 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
4232 All uses that need 0-or-2 changed to:
4233 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
4234 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
4235 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
4236 (char_quoted, prev_char_comend_first, back_comment)
4237 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4238 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
4239 Use bool for boolean.
4240 (update_syntax_table, skip_chars, skip_syntaxes):
4241 Prefer int to unsigned when either will do.
4242 (back_comment): Return boolean success flag, like forw_comment,
4243 instead of positive-or-minus-1 (which might have overflowed int anyway).
4244 Don't stuff ptrdiff_t into int.
4245 (syntax_spec_code, syntax_code_spec): Now const.
4246 (Fmatching_paren, scan_lists, scan_sexps_forward):
4247 Use enum syntaxcode for syntax code.
4248 (Fmatching_paren): Check that arg is a character, not just an integer.
4249 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
4250 (Finternal_describe_syntax_value): Omit no-longer-needed
4251 comparison to 0.
4252 (skip_chars): Use char, not unsigned char, when the distinction
4253 doesn't matter.
4254 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
4255 * bytecode.c (exec_byte_code):
4256 * syntax.c (syntax_spec_code, Fchar_syntax)
4257 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4258 (init_syntax_once):
4259 * syntax.h (SYNTAX_WITH_FLAGS):
4260 Omit unnecessary casts.
4261
b932cad7
EZ
42622013-06-20 Eli Zaretskii <eliz@gnu.org>
4263
4264 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
4265 line dimensions here, to avoid race conditions with the main
4266 thread. (Bug#14062, bug#14630, bug#14669)
4267
4268 * w32term.c (w32_draw_window_cursor): Compute the header line and
4269 mode line dimensions here.
4270 <w32_system_caret_window, w32_system_caret_hdr_height>:
4271 <w32_system_caret_mode_height>: New variables.
4272
4273 * w32term.h: Declare them.
4274
89561f72
PE
42752013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4276
5013fc08
PE
4277 * alloc.c (die): Move "assertion failed" string here ...
4278 * lisp.h (eassert): ... from here. Also, suppress evaluation of
4279 COND when SUPPRESS_CHECKING. This shrinks the executable text
4280 size by 0.8% to 2.2% when configured with --enable-checking,
4281 depending on optimization flags (GCC 4.8.1 x86-64).
4282
89561f72
PE
4283 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
4284
763a086d 42852013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
4286
4287 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4288 base is 2; this is more accurate.
4289
983aeb9a
JB
42902013-06-19 Juanma Barranquero <lekktu@gmail.com>
4291
4292 * sound.c (string_default): Move to !WINDOWSNT section.
4293 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4294
178ba3e6
PE
42952013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4296
bbc51b15
PE
4297 * sound.c: Integer cleanups.
4298 Remove unnecessary forward decls.
4299 (struct sound_device): The 'file' member is now a Lisp_Object, not
4300 a char *, so that we needn't invoke alloca on a huge size.
4301 (Fplay_sound_internal): Adjust to this.
4302 (string_default): New function.
4303 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4304 Use it to adjust to the struct sound_device change.
4305 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4306 (be2hs) [0]: Remove.
4307
178ba3e6
PE
4308 * syntax.c (skip_chars): Don't use uninitialized storage
4309 when searching a multibyte buffer for characters that are not in a
4310 unibyte string that contains non-ASCII characters.
4311
69f60cdc
JD
43122013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4313
4314 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4315 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4316
0d6224d4
PE
43172013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4318
4319 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4320
3c542890
KH
43212013-06-18 Kenichi Handa <handa@gnu.org>
4322
f7e3f7cd
KH
4323 * font.c (Ffont_spec): Signal an error for an invalid font name
4324 (Bug#14648).
3c542890 4325
9349e5f7
PE
43262013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4329 In particular this ports to 32-bit sparc Sun cc.
4330 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4331 array with a dummy element at specpdl[-1], so that its address can
4332 be taken portably.
4333 (unbind_to): Do not copy the binding; not needed, now that we
4334 copy old_value in the one place where the copy is needed.
4335 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4336 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4337 (union specbinding): Rename from struct specbinding. Redo layout
4338 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4339 which is not portable. With Sun C 5.12 32-bit sparc, the
4340 declaration causes nargs to be an unsigned bitfield, a behavior
4341 that the C standard allows; but Emacs wants nargs to be signed.
4342 The overall type is now a union of structures rather than a
4343 structure of union of structures, and the 'kind' member is now a
4344 bitfield, so that the overall type doesn't grow. All uses changed.
4345 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4346
0a4df6a5
PE
43472013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4348
ec6ecaad
PE
4349 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4350 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4351
0a4df6a5
PE
4352 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4353
7bfe8dbc
EZ
43542013-06-17 Eli Zaretskii <eliz@gnu.org>
4355
4356 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4357 unless we know that the window w's frame is a frame object.
4358 Another attempt at solving bug#14062 and bug#14630.
4359
708e05f6
LMI
43602013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4361
4362 * textprop.c (property_set_type): New enum.
4363 (add_properties): Allow appending/prepending text properties.
4364 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4365 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4366 add_text_properties_1.
4367 (Fadd_face_text_property): New function that calls
4368 add_text_properties_1.
4369
84575e67
PE
43702013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4371
4372 Move functions from lisp.h to individual modules when possible.
4373 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4374 * alloc.c (XFLOAT_INIT, set_symbol_name):
4375 * buffer.c (CHECK_OVERLAY):
4376 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4377 (set_char_table_parent):
4378 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4379 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4380 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4381 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4382 (set_blv_valcell):
4383 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4384 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4385 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4386 (backtrace_args, backtrace_debug_on_exit):
4387 * floatfns.c (CHECK_FLOAT):
4388 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4389 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4390 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4391 (set_hash_index_slot):
4392 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4393 * marker.c (CHECK_MARKER):
4394 * textprop.c (CHECK_STRING_OR_BUFFER):
4395 * window.c (CHECK_WINDOW_CONFIGURATION):
4396 Move here from lisp.h, and make these functions static rather than
4397 extern inline.
4398 * buffer.c (Qoverlayp):
4399 * data.c (Qsubrp):
4400 * fns.c (Qhash_table_p):
4401 * window.c (Qwindow_configuration_p):
4402 Now static.
4403 * lisp.h: Remove the abovementioned defns and decls.
4404
44e18199 4405 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4406 In lisp.h, prefer functions to function-like macros, and
4407 constants to object-like macros, when either will do. This:
4408 . simplifies use, as there's no more need to worry about
4409 arguments' side effects being evaluated multiple times.
4410 . makes the code easier to debug on some platforms.
4411 However, when using gcc -O0, keep using function-like macros
4412 for a few critical operations, for performance reasons.
4413 This sort of thing isn't needed with gcc -Og, but -Og
4414 is a GCC 4.8 feature and isn't widely-enough available yet.
4415 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4416 Remove enum lsb_bits; no longer needed.
4417 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4418 * buffer.c (Qoverlap):
4419 * data.c (Qsubrp):
4420 * fns.c (Qhash_table_p):
4421 Now extern, so lisp.h can use these symbols.
4422 * dispextern.h: Include character.h, for MAX_CHAR etc.
4423 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4424 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4425 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4426 (GLYPH_CODE_P): Move here from lisp.h.
4427 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4428 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4429 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4430 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4431 XUNTAG now returns void *.
4432 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4433 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4434 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4435 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4436 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4437 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4438 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4439 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4440 New macros, renamed from their sans-lisp_h_ counterparts.
4441 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4442 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4443 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4444 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4445 If compiling via GCC without optimization, define these as macros
4446 in addition to inline functions.
4447 To disable this, compile with -DINLINING=0.
4448 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4449 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4450 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4451 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4452 (INTMASK, VALMASK): Now macros, since static values cannot be
4453 accessed from extern inline functions.
4454 (VALMASK): Also a constant, for benefit of old GDB.
4455 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4456 is INTEGERP, which can fold it in.
5165d44a 4457 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4458 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4459 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4460 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4461 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4462 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4463 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4464 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4465 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4466 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4467 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4468 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4469 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4470 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4471 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4472 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4473 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4474 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4475 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4476 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4477 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4478 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4479 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4480 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4481 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4482 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4483 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4484 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4485 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4486 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4487 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4488 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4489 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4490 Now functions.
4491 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4492 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4493 (VALMASK): Define in one place rather than in two, merging the
4494 USE_LSB_TAG parts; this is simpler.
4495 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4496 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4497 Move up, to avoid use before definition.
4498 Also include "globals.h" earlier, for the same reason.
4499 (make_natnum): New function.
4500 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4501 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4502 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4503 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4504 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4505 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4506 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4507 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4508 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4509 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4510 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4511 (Qwindow_configuration_p, Qimage): New forward declarations.
4512 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4513 (STRING_COPYIN): Remove; unused.
4514 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4515 (xcar_addr, xcdr_addr): New functions. All uses changed.
4516 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4517 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4518 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4519 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4520 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4521 (TYPE_RANGED_INTEGERP): Simplify.
4522 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4523 (setlocale, fixup_locale, synchronize_system_messages_locale)
4524 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4525 Now empty functions, not macros.
4526 (functionp): Return bool, not int.
4527 * window.c (Qwindow_configuration_p): Now extern,
4528 so window.h can use it.
4529 * window.h (Qwindowp): Move decl back to lisp.h.
4530
9583ec36
EZ
45312013-06-15 Eli Zaretskii <eliz@gnu.org>
4532
4533 * xdisp.c (Fline_pixel_height): New function, required for solving
4534 bug #14567.
4535
210272ce
PE
45362013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4539
de0503df
SM
45402013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4541
4542 * lread.c (syms_of_lread):
4543 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4544
afbfe143
KD
45452013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4546
4547 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4548
d177e213
XF
45492013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4550
4551 * fileio.c (expand_file_name): Doc fix.
4552
05e3e412
PE
45532013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4554
f7394b12
PE
4555 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4556 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4557 Wait for self, not for 0. This can't hurt on GNU or similar
4558 system, and may help with Cygwin.
4559
05e3e412
PE
4560 * keyboard.c: Don't use PROP (...) as an lvalue.
4561 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4562 Use set_prop (A, B), not PROP (A) = B.
4563
17dd3097
EZ
45642013-06-10 Eli Zaretskii <eliz@gnu.org>
4565
4566 * xdisp.c (get_it_property): Use it->window instead of generating
4567 a Lisp object from it->w.
4568
52fab9c9
EZ
45692013-06-09 Eli Zaretskii <eliz@gnu.org>
4570
4571 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4572 get-char-property the window that is being rendered, instead of
4573 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4574 (compute_display_string_pos): When W is NULL, use the current
4575 buffer as the object to pass to get-char-property.
4576 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4577 pointer member of the bidi iterator, since no window is pertinent
4578 to this function.
52fab9c9 4579
5bf97bfc
EZ
45802013-06-08 Eli Zaretskii <eliz@gnu.org>
4581
4582 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4583 being displayed, and pass it to compute_display_string_pos.
4584 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4585 (bidi_paragraph_init): All callers changed.
4586
4587 * xdisp.c (init_from_display_pos, init_iterator)
4588 (handle_single_display_spec, next_overlay_string)
4589 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4590 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4591 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4592 (compute_display_string_pos): Accept additional argument, the
4593 window being displayed, and pass it to Fget_char_property.
4594 (Bug#14575)
4595
4596 * dispextern.h (struct bidi_it): New member w, the window being
4597 displayed.
4598 (compute_display_string_pos): Adjust prototype.
4599
5de0e011
JD
46002013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4601
e7b41c4c 4602 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4603
4604 * process.c (wait_reading_process_output): Check for NS before GLIB.
4605 GLIB may be linked in due to rsvg, but ns_select must be called.
4606
5de0e011
JD
4607 * xgselect.c (xg_select): Remove call to window_system_available
4608 and g_main_context_pending at the top, so Gdk events (i.e. file
4609 notify) are processed when Emacs is started with -nw.
4610
a822acff
EZ
46112013-06-07 Eli Zaretskii <eliz@gnu.org>
4612
4613 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4614 (ctagsfiles3): New variable, includes only *.m files.
4615 (TAGS): Use an explicit language name in the regular expressions,
4616 to avoid transformation of '/SOMETHING' by MSYS to
4617 'c:\MSYS\SOMETHING'.
4618
6c0a9ed1
RC
46192013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4620
4621 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4622
9ef6111b
EZ
46232013-06-06 Eli Zaretskii <eliz@gnu.org>
4624
4625 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4626 still need to set the mouse pointer shape and activate help-echo.
4627 (Bug#14558)
4628
7d300d64
PE
46292013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4630
4631 A few porting etc. fixes for the new file monitor code.
4632 See the thread containing
4633 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4634 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4635 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4636 (dir_monitor_callback, Fgfile_rm_watch):
4637 Use assq_no_quit instead of Fassoc, for speed.
4638 (dir_monitor_callback, Fgfile_rm_watch):
4639 eassert that the monitor is a fixnum.
4640 (dir_monitor_callback): No need for CDR_SAFE.
4641 Simplify building of lisp with alternative tails.
4642 (Fgfile_add_watch, Fgfile_rm_watch):
4643 Do not assume glib functions set errno reliably on failure.
4644 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4645 and signal an error otherwise.
4646 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4647 Use Fdelq instead of Fdelete, for speed.
4648
817ebfcf
EZ
46492013-06-05 Eli Zaretskii <eliz@gnu.org>
4650
4651 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4652 don't insist on being invoked on a highlighted tool-bar button.
4653 Avoids losing tool-bar functionality when mouse-highlight is nil.
4654 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4655 Don't highlight when mouse-highlight is nil.
4656 (note_mouse_highlight): When mouse-highlight is nil, don't return
4657 right away; instead, run tool-bar and mode-line highlight
4658 subroutine, clear any existing highlight, and revert the mouse
4659 pointer to its default shape. (Bug#14558)
4660
55577e7c
SM
46612013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4662
4663 * lisp.mk (lisp): Add prog-mode.el.
4664
f019a684
PE
46652013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4666
4667 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4668 * process.c (dummy_handler): New function.
4669 (lib_child_handler): New static var.
4670 (handle_child_signal): Invoke it.
4671 (catch_child_signal): If a library has set up a signal handler,
4672 save it into lib_child_handler.
4673 (init_process_emacs): If using glib and not on Windows, tickle glib's
4674 child-handling code so that it initializes its private SIGCHLD handler.
4675 * syssignal.h (SA_SIGINFO): Default to 0.
4676 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4677 31; it should no longer be needed now.
4678
90db8702
MA
46792013-06-05 Michael Albinus <michael.albinus@gmx.de>
4680
4681 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4682
4683 * gfilenotify.c (globals_of_gfilenotify): New function.
4684 (syms_of_gfilenotify): Move global initialization there.
4685
4686 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4687
bfa3acd6
SM
46882013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4689
4690 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4691 * keyboard.c (menu_bar_items, tool_bar_items):
4692 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4693 not override local keymaps any more.
4694
ba59bd80
EZ
46952013-06-04 Eli Zaretskii <eliz@gnu.org>
4696
4697 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4698
7f203aa1
EZ
46992013-06-03 Eli Zaretskii <eliz@gnu.org>
4700
9337e206
EZ
4701 * w32console.c (initialize_w32_display): Return the dimensions of
4702 the console window via 2 additional arguments, not via the current
4703 frame. This avoids crashes due to overrunning the bounds of
4704 frame's decode_mode_spec_buffer, which is not resized following
4705 the change of the frame dimensions from the initial 10x10.
4706
4707 * w32term.h (w32_initialize_display_info): Adjust prototype.
4708
4709 * term.c (init_tty): Take dimensions of the frame from the values
4710 returned by initialize_w32_display.
4711
7f203aa1
EZ
4712 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4713 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4714 (LIBES): Add $(GFILENOTIFY_LIBS).
4715
4716 * w32inevt.c (handle_file_notifications): Add dummy implementation
4717 for !HAVE_W32NOTIFY.
4718
4719 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4720
55a87246
JD
47212013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4722
4723 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4724
4725 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4726
4727 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4728
3d5ee10a
PE
47292013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4730
4731 Fix minor problems found by static checking.
4732 * data.c (pure_write_error):
4733 Use xsignal2, not Fsignal, as Fsignal might return.
4734 * eval.c (set_backtrace_debug_on_exit): Now static.
4735 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4736 No longer inline. EXTERN_INLINE is needed only for functions
4737 defined in .h files. Reindent function header as per GNU style.
4738 (backtrace_p, backtrace_top, backtrace_next):
4739 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4740 compiler or linker. Add extern decls to pacify gcc -Wall.
4741 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4742 Now static.
4743 * frame.c (free_monitors): Define only on platforms that need it.
4744 * nsterm.m (ns_term_init):
4745 * process.c (catch_child_signal):
4746 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4747 defined on all porting targets these days.
4748 * process.c, process.h (catch_child_signal):
4749 Make it extern only if NS_IMPL_GNUSTEP is defined.
4750
e2d8a6f0
EZ
47512013-06-03 Eli Zaretskii <eliz@gnu.org>
4752
4753 * w32.c (gettimeofday): Make the signature identical to prototype
4754 in nt/inc/sys/time.h.
4755
a8a7c5f6
SM
47562013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4757
4758 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4759 .gdbinit.
4760
4761 * keyboard.c (safe_run_hooks_error): Improve error message.
4762
4763 * data.c (pure_write_error): Add `object' argument.
4764 * puresize.h (CHECK_IMPURE): Use it.
4765
c9628c79
MA
47662013-06-03 Michael Albinus <michael.albinus@gmx.de>
4767
4768 * Makefile.in (NOTIFY_OBJ): New variable.
4769 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4770
4771 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4772 Call syms_of_gfilenotify.
4773
4774 * gfilenotify.c: New file.
4775
4776 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4777 and Qfile_w32notify.
4778 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4779 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4780
4781 * lisp.h: Declare syms_of_gfilenotify.
4782
4783 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4784
2f592f95
SM
47852013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4786
4787 Merge the specpdl and backtrace stacks. Make the structure of the
4788 specpdl entries more obvious via a tagged union of structs.
4789 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4790 (enum specbind_tag): New enum.
4791 (struct specbinding): Make it a tagged union of structs.
4792 Add a case for backtrace records.
4793 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4794 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4795 (backtrace_debug_on_exit): New accessors.
4796 (struct backtrace): Remove.
4797 (struct catchtag): Remove backlist field.
4798 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4799 Move to eval.c.
4800 (Flocal_variable_p): Speed up the common case where the binding is
4801 already loaded.
4802 * eval.c (backtrace_list): Remove.
4803 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4804 (set_backtrace_args, set_backtrace_nargs)
4805 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4806 (backtrace_next): New functions.
4807 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4808 (unwind_to_catch, internal_lisp_condition_case)
4809 (internal_condition_case, internal_condition_case_1)
4810 (internal_condition_case_2, internal_condition_case_n): Don't bother
4811 with backtrace_list any more.
4812 (Fsignal): Adjust to new backtrace format.
4813 (grow_specpdl): Move up.
4814 (record_in_backtrace): New function.
4815 (eval_sub, Ffuncall): Use it.
4816 (apply_lambda): Adjust to new backtrace format.
4817 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4818 data.c.
4819 (specbind): Adjust to new specpdl format. Simplify.
4820 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4821 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4822 backtrace format.
4823 (mark_backtrace): Remove.
4824 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4825 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4826 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4827 Use mark_specpdl.
4828 * profiler.c (record_backtrace): Use get_backtrace.
4829 (handle_profiler_signal): Use backtrace_top_function.
4830 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4831 accessor functions.
4832
c0342369
JD
48332013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4834
4835 * process.h (catch_child_signal): Declare.
4836
4837 * process.c (catch_child_signal): New function.
4838 (init_process_emacs): Call it.
4839
4840 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4841 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4842 NS_IMPL_COCOA.
4843 (x_set_cursor_type): Remove declaration.
4844 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4845 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4846 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4847 (ns_get_color): Use F suffix on float.
4848 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4849 (ns_get_rgb_color): Remove.
4850 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4851 (note_mouse_movement): x and y are CGFloat.
4852 (ns_draw_fringe_bitmap): Remove unused rowY.
4853 Change #if to COCOA && >= 10_6.
4854 (ns_draw_window_cursor): Remove unused overspill.
4855 (ns_draw_underwave): width and x are EamcsCGFloat.
4856 (ns_draw_box): thickness is CGFloat.
4857 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4858 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4859 if not in main thread.
4860 (ns_get_pending_menu_title, ns_check_menu_open)
4861 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4862 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4863 (sendFromMainThread:): New method.
4864 (changeFont:): size is CGFloat.
4865 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4866 Disable warning about permanent text.
4867 (characterIndexForPoint:): Adjust return type depending on GNUStep
4868 version.
4869 (mouseDown:): delta is CGFloat.
4870 (updateFrameSize): Remove unised variable f.
4871 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4872 Cast float to EmacsCGFloat.
4873 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4874 also to -1 when restoring.
4875 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4876 inside NS_IMPL_COCOA.
4877 (toggleFullScreen:): Put call to toggleFullScreen inside
4878 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4879 (setPosition:portion:whole:): por is CGFloat.
4880 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4881 (mouseDown:): Use CGFloat.
4882 (mouseDragged:): Remove unised variable edge.
4883 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4884
4885 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4886 of CGFloat differs.
4887 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4888 when NS_IMPL_GNUSTEP.
4889 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4890 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4891 (EmacsToolbar): Add clearAll. Add tag argument to
4892 addDisplayItemWithImage.
4893 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4894
4895 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4896
4897 * nsmenu.m (ns_update_menubar): Make static.
4898 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4899 (fillWithWidgetValue:): Add cast to SEL for setAction.
4900 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4901 (update_frame_tool_bar): Update code for GNUStep.
4902 (clearAll): New method.
4903 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4904 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4905 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4906 call to insertItemWithItemIdentifier.
4907 (validateVisibleItems): Fix indentation.
4908 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4909 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4910 UtilityWindow to aStyle, remove call to setStyleMask.
4911
4912 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4913
4914 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4915 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4916 Use F suffix on floats.
4917 (ns_char_width): Returns CGFloat.
4918 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4919 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4920 DPSxshow.
4921 (ns_glyph_metrics): CGFloat instead of float.
4922
a0eb10b3
JB
4923 * nsfns.m (x_set_foreground_color, x_set_background_color):
4924 Use EmacsCGFloat.
4925 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4926 remove unused variables.
4927 (Fns_read_file_name): Keep track if panel is for save.
4928 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4929 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4930 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4931 Just return the input if GNUStep.
c0342369
JD
4932 (x_screen_planes): Remove.
4933 (Fxw_color_values): Use EmacsCGFloat
4934 (Fns_display_monitor_attributes_list): Only get screen number for
4935 Cocoa.
ef099a94 4936 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4937 EmacsSavePanel.
4938 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4939 ns_directory_from_panel.
4940
da9aff11
PE
49412013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4942
4943 * process.c (handle_child_signal): Also use WCONTINUED.
4944 This is so that list-processes doesn't mistakenly list the process
4945 as stopped, when the process has actually been continued and is
4946 now running.
4947
0e64479a
PE
49482013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4949
fc186a96
PE
4950 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4951 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4952 not already configured.
4953
0e64479a
PE
4954 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4955
38b787fa
EZ
49562013-05-29 Eli Zaretskii <eliz@gnu.org>
4957
4958 * Makefile.in (mostlyclean): Remove *.res files.
4959
22513e52
SM
49602013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4961
4962 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4963 a buffer (bug#8447).
4964
6ef3db10
EZ
49652013-05-27 Eli Zaretskii <eliz@gnu.org>
4966
4967 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4968 display vector, and we backtrack, handle the case that the
4969 previous character position is also displayed from a display
4970 vector or covered by a display string or image. (Bug#14476)
4971
6799bb26
JD
49722013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4973
4974 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4975 (struct MonitorInfo, free_monitors): Remove.
4976 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4977 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4978 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4979 Qframes, Qsource.
4980
4981 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4982 (struct MonitorInfo, free_monitors): Remove.
4983 (ns_screen_name): Make static.
4984 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4985 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4986 Qframes, Qsource.
4987
4988 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4989 (struct MonitorInfo): New struct.
4990 (free_monitors, make_monitor_attribute_list): Declare.
4991
22513e52
SM
4992 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4993 New Lisp_Object:s.
6799bb26
JD
4994 (free_monitors, make_monitor_attribute_list): New functions.
4995 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4996 Qsource.
4997
38cd43eb
XF
49982013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4999
5000 * callproc.c (call_process): Refine the doc string. (Bug#14045)
5001
2af0948d
SM
50022013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
5003
a7eb9b0f
SM
5004 * keyboard.c: Apply keyboard decoding only to events that come directly
5005 from the tty, not from unread-command-events (bug#14368).
5006 (read_event_from_main_queue): New function, extracted from read_char).
5007 (read_decoded_char): Remove.
5008 (read_decoded_event_from_main_queue): New function to replace it.
5009 (read_char): Use it.
5010 (read_key_sequence): Use read_char rather than read_decoded_char.
5011
2af0948d
SM
5012 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
5013
1413e9a5
BR
50142013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
5015
5016 * casetab.c (init_casetab_once): Fix last change (bug#14424).
5017
e6d2f155
KH
50182013-05-22 Kenichi Handa <handa@gnu.org>
5019
5020 The following changes are to fix the setting of
5021 buffer-file-coding-system on, for instance, C-x RET c unix RET
5022 _FILE_OF_DOS_EOL_TYPE_ RET.
5023
5024 * coding.h (struct coding_system): New member detected_utf8_chars.
5025
5026 * coding.c (detect_coding_utf_8): Count characters and check EOL
5027 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
5028 BOM is there.
5029 (setup_coding_system): Do not initialize coding->head_ascii.
5030 (check_ascii): Do not set coding->eol_seen but update it. Do not
5031 call adjust_coding_eol_type here.
1413e9a5
BR
5032 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
5033 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
5034 of the found coding-system.
5035 (decode_coding_gap): Cancel previous change. Utilize the
5036 character numbers counted by detect_coding_utf_8. Fix detection
5037 of BOM for utf-8.
5038
ab56a6f4 50392013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
5040
5041 * search.c (looking_at_1): Only set last_thing_searched if the match
5042 changed the match-data (bug#14281).
5043
ecc3c6ed
DA
50442013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
5045
5046 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 5047 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
5048 (move_it_vertically_backward): Likewise.
5049
5ba8bf35
YM
50502013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5051
5052 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 5053 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
5054 (Fx_display_mm_width, Fx_display_mm_height):
5055 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 5056
91e8418b 5057 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 5058 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
5059 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
5060 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
5061 (Fx_display_backing_store, Fx_display_visual_class)
5062 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
5063 (Fx_display_grayscale_p, Fx_display_pixel_width)
5064 (Fx_display_pixel_height, Fx_display_planes)
5065 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
5066 (Fx_display_screens): Don't confuse X11 screens with NS screens.
5067 (Fx_display_mm_width, Fx_display_mm_height)
5068 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
5069 height for all physical monitors as in X11.
5070
fc30d803
SM
5071 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
5072 Return pixel width or height for all physical monitors as in X11.
91e8418b 5073
31ff141c
PE
50742013-05-18 Paul Eggert <eggert@cs.ucla.edu>
5075
5076 Port --enable-gcc-warnings to clang.
5077 * bytecode.c (exec_byte_code):
5078 * regex.c:
5079 Redo diagnostic pragmas to pacify clang, too.
5080 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
5081 * editfns.c (Fencode_time):
5082 * fileio.c (file_accessible_directory_p):
5083 * font.c (font_unparse_xlfd):
5084 Use '&"string"[index]' instead of '"string" + (index)'.
5085 * undo.c (user_error): Remove; unused.
5086
df065a0b
EZ
50872013-05-16 Eli Zaretskii <eliz@gnu.org>
5088
04d360e7
EZ
5089 * insdel.c (insert_1_both): Document the arguments, instead of
5090 referring to insert_1, which no longer exists.
5091
5bb98290
EZ
5092 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
5093 some window, increment windows_or_buffers_changed, so that
5094 *Messages* display in that window is updated. (Bug#14408)
5095
df065a0b
EZ
5096 * w32.c: Include epaths.h.
5097 (init_environment): Use cmdproxy.exe without leading directories.
5098 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
5099 case.
5100 (gettimeofday): Adjust signature and return value to Posix
5101 expectations.
5102
5103 * unexw32.c (open_output_file): Delete the existing emacs.exe
5104 before creating it, to break the hard link to the versioned
5105 executable.
5106
5107 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
5108 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
5109 (FIRSTFILE_OBJ): New variables.
5110 (W32_RES): Rename to EMACSRES. All users changed.
5111 (base_obj): Use $(CM_OBJ).
5112 (ALLOBJS): Use $(FIRSTFILE_OBJ).
5113 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
5114 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
5115 $(W32_RES_LINK) before $(LIBES).
5116 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
5117
1aa8d505
SM
51182013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5119
6e911150
SM
5120 * makefile.w32-in (DOC): Use just "DOC".
5121
5122 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
5123
1aa8d505
SM
5124 * process.c: Export default filters and sentinels to Elisp.
5125 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
5126 New constants.
5127 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
5128 (Fset_process_sentinel, Fformat_network_address):
5129 Default to them instead of nil.
5130 (server_accept_connection): Sentinels can't be nil any more.
5131 (read_and_dispose_of_process_output): New function, extracted from
5132 read_process_output.
5133 (read_process_output): Use it; filters can't be nil.
5134 (Finternal_default_process_filter): New function, extracted from
5135 read_process_output.
5136 (exec_sentinel_unwind): Remove function.
5137 (exec_sentinel): Don't zilch sentinel while running.
5138 (status_notify): Sentinels can't be nil.
5139 (Finternal_default_process_sentinel): New function extracted from
5140 status_notify.
5141 (setup_process_coding_systems): Default filter is not nil any more.
5142 (syms_of_process): Export new Elisp functions and initialize
5143 new constants.
5144 * lisp.h (make_lisp_proc): New function.
5145
5ac2eb34
SM
51462013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5147
5148 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
5149
eda9c7d7
EZ
51502013-05-14 Eli Zaretskii <eliz@gnu.org>
5151
5152 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
5153 unless we know that the window w is a leaf window.
5154 Another attempt at solving bug#14062.
eda9c7d7 5155
8fdeaad5
JD
51562013-05-14 Jan Djärv <jan.h.d@swipnet.se>
5157
5158 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
5159 fdesc (Bug#14375).
5160
44aa9ee6
PE
51612013-05-12 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 * image.c (gif_load): Check that subimages fit (Bug#14345).
5164
759fd763
SM
51652013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
5166
5167 * lread.c (skip_dyn_eof): New function.
5168 (read1): Use it to skip the end of a file in response to #@00.
5169
5170 * doc.c (get_doc_string): Slightly relax the sanity checking.
5171
4465bfb4
JD
51722013-05-09 Jan Djärv <jan.h.d@swipnet.se>
5173
5174 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
5175 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5176 (MonitorInfo): New struct.
5177 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
5178 (Fns_display_monitor_attributes_list): New functions.
5179 (display-usable-bounds): Remove.
5180 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
5181 Qsource.
5182
7583e2a0
PE
51832013-05-09 Paul Eggert <eggert@cs.ucla.edu>
5184
5185 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
5186 (GTK_CHECK_VERSION): New macro, if not already defined.
5187 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
5188 replaced by GTK_CHECK_VERSION.
5189
ad75d77e
PE
51902013-05-08 Paul Eggert <eggert@cs.ucla.edu>
5191
5192 * xterm.h (GTK_PREREQ): New macro.
5193 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
5194 to use this macro instead, for consistency and clarity.
5195
07525f77
EZ
51962013-05-08 Eli Zaretskii <eliz@gnu.org>
5197
5198 * xdisp.c (row_for_charpos_p): New function, with code of
5199 cursor_row_p, but accepts an additional argument CHARPOS instead
5200 of using a hardcoded PT.
5201 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
5202 (row_containing_pos): Call row_for_charpos_p instead of partially
5203 doing the same. Fixes cursor positioning under longlines-mode
5204 when longlines-show-effect includes more than one newline, when
5205 moving the cursor vertically up.
5206
d901fc8d
JB
52072013-05-08 Juanma Barranquero <lekktu@gmail.com>
5208
5209 * makefile.w32-in (ACL_H): New macro.
5210 ($(BLD)/fileio.$(O)): Update dependencies.
5211
f269bc61
PE
52122013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5213
e7b41c4c 5214 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
5215 * Makefile.in (LIB_ACL): New macro.
5216 (LIBACL_LIBS): Remove.
5217 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
5218 * fileio.c: Include <acl.h>.
5219 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
5220 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
5221 !acl_errno_valid.
5222 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
5223 it ourselves.
5224
f269bc61
PE
5225 * unexelf.c: Don't assume ElfW (Half) fits in int.
5226 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
5227 when dealing with ElfW (Half) values, since they can exceed 2**31
5228 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
5229 (entry_address): Omit unused NUM arg. All uses changed.
5230
a261c53e
JL
52312013-05-07 Juri Linkov <juri@jurta.org>
5232
5233 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
5234 to the string converted from number with `Fnumber_to_string'.
5235 (Bug#14254)
5236
2b66427d
PE
52372013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5238
5239 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
5240 This fixes a problem introduced by my previous change.
5241
15acfe41
GM
52422013-05-07 Glenn Morris <rgm@gnu.org>
5243
5244 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
5245
5ea03bf5
JD
52462013-05-07 Jan Djärv <jan.h.d@swipnet.se>
5247
5248 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
5249
e0c9d565
PE
52502013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5251
5252 Static checking by GCC 4.8.0.
5253 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
5254 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
5255 (x_get_monitor_attributes_fallback)
5256 (x_get_monitor_attributes_xinerama)
5257 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
5258 Define only if USE_GTK.
5259 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
5260 (x_get_monitor_attributes_fallback): Omit unused locals.
5261 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
5262 Use double, not float, to avoid mixed-mode floating point arithmetic.
5263
4e3f9230
YM
52642013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5265 Jan Djärv <jan.h.d@swipnet.se>
5266
5267 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
5268 (XINERAMA_CFLAGS): New macros.
5269 (ALL_CFLAGS, LIBES): Use them.
5270
5271 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
5272 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
5273 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
5274 (syms_of_xfns): DEFSYM them.
5275 (struct MonitorInfo): New struct.
5276 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
5277 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
5278 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
5279 (x_get_monitor_attributes_xinerama): New functions.
5280 (Fx_display_monitor_attributes_list): New primitive.
5281 (syms_of_xfns): Defsubr it.
5282
5283 * xterm.h (x_display_info): Add Xatom_net_workarea and
5284 Xatom_net_current_desktop.
5285
5286 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5287 and dpyinfo->Xatom_net_current_desktop.
5288
05839b6a
EZ
52892013-05-06 Eli Zaretskii <eliz@gnu.org>
5290
5291 * xdisp.c (pos_visible_p): Use the special code for finding the
5292 beginning of a display property or overlay for any "replacing"
5293 display property, not just for display strings. This solves
5294 incorrect reporting of position by posn-at-point. (Bug#14241)
5295
dc4a2ee0
PE
52962013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5297
5ee94506
PE
5298 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5299 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5300 Verify that ElfW (Half) fits in int.
5301 (fatal): Use same signature as lisp.h.
5302 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5303 configure and build with -DUNEXELF_DEBUG without worrying about
5304 other modules that use DEBUG.
5305 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5306 possibly-wide integers now uses it instead of plain fprintf.
5307 (entry_address): New function, which avoids problems with 32-bit
5308 overflow on 64-bit hosts.
5309 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5310 (round_up): Don't assume the remainder fits in int.
5311 (find_section): Use bool for boolean. Simplify debug code.
5312 (unexec): Don't assume file sizes fit in int or size_t.
5313 Omit unnecessary trailing newline in 'fatal' format.
5314 Use strerror rather than outputting decimal error number.
5315 Remove unused code when emacs is not defined;
5316 this file relies on Emacs now.
5317 Don't assume e_phnum and e_shnum are positive.
5318
dc4a2ee0
PE
5319 * regex.c: Fix problems when DEBUG is defined.
5320 (extract_number, extract_number_and_incr): Define regardless of
5321 whether DEBUG is defined; that's simpler and makes the code less
5322 likely to go stale in the normal case when DEBUG is not defined.
5323 Return int rather than taking an int * arg. All callers changed.
5324 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5325 Remove, replacing with ...
5326 (DEBUG_PRINT): New macro. All callers changed.
5327 (DEBUG_COMPILES_ARGUMENTS): New macro.
5328 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5329 (print_compiled_pattern, print_double_string) [DEBUG]:
5330 Use prototype rather than old-style definition.
5331 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5332 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5333 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5334 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5335 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5336 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5337 This matters only when DEBUG is defined.
5338
14c7ed05
EZ
53392013-05-05 Eli Zaretskii <eliz@gnu.org>
5340
5341 * xdisp.c (set_iterator_to_next): Set the
5342 ignore_overlay_strings_at_pos_p flag only if we are _really_
5343 iterating over an overlay string, as indicated by the
5344 current.overlay_string_index member. (Bug#14306)
5345
e6076b1b
JD
53462013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5347
5348 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5349 to where it is used, to avoid autorelease issues (Bug#14050).
5350
cbee2131
PE
53512013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5352
5353 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5354 * fileio.c (syms_of_fileio): Implement this.
5355 * filelock.c (create_lock_file): If symbolic links don't work, so
5356 we use a regular file as a lock file, do not fsync the lock file;
5357 it's not needed.
5358
30c7e542
SM
53592013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5360
5361 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5362 (syms_of_minibuf): Adjust accodingly.
5363 * lread.c (Fread):
5364 * callint.c (Fcall_interactively): Adjust calls accordingly.
5365
5bebd186
EZ
53662013-05-04 Eli Zaretskii <eliz@gnu.org>
5367
5368 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5369 w->contents is a buffer before computing everything else.
5370 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5371
5372 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5373 assertion violations. (Bug#14062)
5374
0fb0a4f3
DR
53752013-05-01 David Reitter <david.reitter@gmail.com>
5376
5377 * nsfns.m (ns_tooltip): Initialize.
5378
9e63b4a5
EZ
53792013-04-28 Eli Zaretskii <eliz@gnu.org>
5380
5381 * coding.c (decode_coding_gap): Don't remove the character before
5382 a newline unless it's a CR character. (Bug#14287)
5383
ad60824e
DN
53842013-04-28 Dan Nicolaescu <dann@gnu.org>
5385
5386 * dispextern.h (struct face): Move enum face_underline_type
5387 earlier so that bitfields can be in the same word.
5388
edbdcec0
JD
53892013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5390
5391 * nsfns.m (handlePanelKeys): New function.
5392 (EmacsOpenPanel:performKeyEquivalent:)
5393 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5394 arrows/function/control and copy/paste keys (Bug#14296).
5395
0208ede7
JL
53962013-04-27 Juri Linkov <juri@jurta.org>
5397
5398 * callint.c (Fcall_interactively): Call `Qread_number' for
5399 interactive code letter `n' instead of using duplicate code.
5400 (Bug#14254)
5401
b8dd59f7
PE
54022013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5403
5404 * systime.h (make_timeval): Declare as 'const'.
5405
8bd722db
KH
54062013-04-27 Kenichi Handa <handa@gnu.org>
5407
5408 * font.c (font_open_entity): Always open a font of manageable
5409 size.
5410
13d0e56f 54112013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5412
f780d632
PE
5413 Port better to AIX (Bug#14258).
5414 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5415 to pacify AIX xlc.
5416
ec509856
KH
54172013-04-24 Kenichi Handa <handa@gnu.org>
5418
5419 * coding.c (decode_coding_iso_2022): When an invalid escape
5420 sequence is encountered, reset the invocation and designation
5421 status to the safest one.
5422
84fc48e5
PE
54232013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5424
5425 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5426 Without this fix, "make distclean" leaves stamp-h1 behind.
5427
806bda47
EC
54282013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5429
5430 * w32fns.c (w32_fullscreen_rect): New function to compute the
5431 window rectangle for the given fullscreen mode.
5432 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5433 longer tunes the window size. This keeps the window's edges flush
5434 with the screen and allows the taskbar to hide itself in fullboth.
5435
5436 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5437 window decorations and uses the entire screen.
5438
5439 * w32term.h (w32_fullscreen_rect) Add prototype.
5440 (struct w32_output): Replace normal_width, normal_height,
5441 normal_top, and normal_left members with a single normal_placement
5442 struct.
5443 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5444 Remove macros.
5445 (FRAME_NORMAL_PLACEMENT): New macro.
5446
9cc2810b
JB
54472013-04-16 Juanma Barranquero <lekktu@gmail.com>
5448
5449 * minibuf.c (Ftest_completion): Silence compiler warning.
5450
fd16b54c
EZ
54512013-04-15 Eli Zaretskii <eliz@gnu.org>
5452
5453 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5454 bug#14062.
fd16b54c
EZ
5455
5456 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5457 parentheses.
5458
5459 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5460 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5461 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5462 parentheses where appropriate.
5463
9e3379a0
PE
54642013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5465
5466 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5467
ddd6b685
EZ
54682013-04-14 Eli Zaretskii <eliz@gnu.org>
5469
5470 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5471 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5472 Mention in the doc string that setting these variables takes
5473 effect only after a call to set-window-buffer. (Bug#14200)
5474
29b79ba1
EZ
54752013-04-13 Eli Zaretskii <eliz@gnu.org>
5476
5477 * indent.c (Fvertical_motion): Don't consider display strings on
5478 overlay strings as display strings on the buffer position we
5479 started from. This prevents vertical cursor motion from jumping
5480 more than one line when there's an overlay string with a display
5481 property at end of line.
5482 Reported by Karl Chen <Karl.Chen@quarl.org> in
5483 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5484
562c6ee9
SM
54852013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5486
5487 * window.c (select_window): `record_buffer' even if window is
5488 already selected (bug#14191).
5489
fcc1fe85
EZ
54902013-04-11 Eli Zaretskii <eliz@gnu.org>
5491
5492 * window.c (Fwindow_end): Test more flags, including the buffer's
5493 last_overlay_modified flag, to determine whether the window's
5494 display is really up-to-date. Prevents the function from
5495 returning a stale value. (Bug#14170)
5496 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5497 current matrix.
5498
f009190a
EZ
54992013-04-10 Eli Zaretskii <eliz@gnu.org>
5500
5501 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5502 garbaged only if it is not already the top frame on its TTY.
5503 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5504 there are GUI frames open in the same session. (Bug#13864)
5505
78ce603d
SM
55062013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5507
5508 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5509 of marking the idle timers directly.
5510
a8036e40
SM
55112013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5512
5513 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5514 tables (bug#14054).
5515
7ffe7ef6
SM
55162013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5517
5518 * window.c (select_window): Don't record_buffer while the invariant is
5519 temporarily broken (bug#14161).
5520
5521 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5522
7d9f6883
EZ
55232013-04-07 Eli Zaretskii <eliz@gnu.org>
5524
5525 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5526
5406cfd9
RF
55272013-04-07 Romain Francoise <romain@orebokech.com>
5528
5529 Ignore additional platform-specific ACL errors (Bug#13702).
5530 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5531 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5532
95c0e83b
JD
55332013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5534
5535 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5536 f->output_data.ns.
5537
876da980
PE
55382013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5539
5540 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5541 This bug was introduced by my 2013-02-25 change that simplified
5542 data_start configuration. Without this change, on GNU/Linux
5543 an Emacs configured with --enable-profiling fails immediately
5544 due to a profiler signal.
5545 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5546 with these flags. On platforms where special flags are needed
5547 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5548 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5549 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5550
7452b7bd
DA
55512013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5552
5553 Get rid of some platform-specific functions examining window
5554 system and its capabilities. This is a partial rework of the
5555 2013-04-05 change.
5556 * lisp.h (have_menus_p): Remove prototype. This function is
5557 replaced with platform-independent window_system_available.
5558 (check_window_system): Move to...
5559 * frame.h (decode_window_system_frame, window_system_available):
5560 ...here, add new prototypes.
5561 * frame.c (window_system_available, decode_window_system_frame):
5562 New functions.
5563 (check_window_system): Platform-independent now.
5564 * xterm.h (x_in_use): Remove declaration.
5565 (check_x_frame):
5566 * w32term.h (check_x_frame):
5567 * nsterm.h (check_x_frame): Remove prototypes. This function
5568 is replaced with platform-independent decode_window_system_frame.
5569 * msdos.c (have_menus_p): Remove.
5570 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5571 Remove platform-specific functions. Use check_window_system,
5572 decode_window_system_frame and check_ns_display_info where
5573 appropriate. Minor style and comment tweaks.
5574 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5575 (check_x_frame): Likewise.
5576 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5577 Likewise.
5578 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5579 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5580 * xmenu.c, xselect.c: All related users changed.
5581
251e9147
KH
55822013-04-03 Kenichi Handa <handa@gnu.org>
5583
5584 The following changes is to optimize the code for reading UTF-8
5585 files.
5586
562c6ee9 5587 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5588 changed. Check EOL format. Do not call adjust_coding_eol_type
5589 here.
5590 (check_utf_8): New function.
5591 (adjust_coding_eol_type): Do nothing if already adjusted.
5592 (detect_coding): Compare the return value of check_ascii with
5593 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5594 (decode_coding_gap): Optimize for valid UTF-8.
5595
8bc369d4
KH
55962013-03-21 Kenichi Handa <handa@gnu.org>
5597
5598 * coding.c (syms_of_coding): Cancel previous change.
5599
5600 * insdel.c (insert_from_gap): Fix previous change.
5601
73931ad1
DA
56022013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5603
5604 Consistently use platform-specific function to detect window system.
5605 * lisp.h (check_window_system): New prototype. This function is
5606 going to replace check_x, check_w32 and check_ns.
5607 (have_menus_p): Mention msdos.c in comment.
5608 * fontset.c (check_window_system_func): Remove. Adjust all users.
5609 * fontset.h (check_window_system_func): Remove prototype.
5610 * nsterm.h (check_ns):
5611 * xterm.h (check_x):
5612 * w32term.h (check_w32): Likewise.
5613 * menu.c (Fx_popup_menu): Use check_window_system.
5614 * msdos.c (check_window_system): Define for MS-DOS.
5615 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5616 * w32fns.c (check_window_system): Likewise for MS-Windows.
5617 * xfns.c (check_window_system): Likewise for X.
5618 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5619 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5620
7216e43b
PE
56212013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5622
5623 Prefer < to > in range checks such as 0 <= i && i < N.
5624 This makes it easier to visualize quantities on a number line.
5625 This patch doesn't apply to all such range checks,
5626 only to the range checks affected by the 2013-03-24 change.
5627 This patch reverts most of the 2013-03-24 change.
5628 * alloc.c (xpalloc, Fgarbage_collect):
5629 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5630 * character.c (string_escape_byte8):
5631 * charset.c (read_hex):
5632 * data.c (cons_to_unsigned):
5633 * dispnew.c (update_frame_1):
5634 * doc.c (Fsubstitute_command_keys):
5635 * doprnt.c (doprnt):
5636 * editfns.c (hi_time, decode_time_components):
5637 * fileio.c (file_offset):
5638 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5639 * font.c (font_intern_prop):
5640 * frame.c (x_set_alpha):
5641 * gtkutil.c (get_utf8_string):
5642 * indent.c (check_display_width):
5643 * keymap.c (Fkey_description):
5644 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5645 * lread.c (read1):
5646 * minibuf.c (read_minibuf_noninteractive):
5647 * process.c (wait_reading_process_output):
5648 * search.c (Freplace_match):
5649 * window.c (get_phys_cursor_glyph):
5650 * xdisp.c (redisplay_internal):
5651 * xsmfns.c (smc_save_yourself_CB):
5652 Prefer < to > for range checks.
5653 * dispnew.c (sit_for): Don't mishandle NaNs.
5654 This fixes a bug introduced in the 2013-03-24 change.
5655 * editfns.c (decode_time_components): Don't hoist comparison.
5656 This fixes another bug introduced in the 2013-03-24 change.
5657
92759988
DA
56582013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5659
5660 * frame.h (struct frame): Drop scroll_bottom_vpos
5661 member becaue all real users are dead long ago.
5662 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5663 * xdisp.c (redisplay_internal): Adjust user.
5664
9a1971bb
GM
56652013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5666
f38ab167
JD
5667 * nsmenu.m (showAtX:Y:for:): setLevel to
5668 NSPopUpMenuWindowLevel (Bug#13998).
5669
6d01f1fe
JD
56702013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5671
5672 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5673 (ns_check_pending_open_menu): Declare.
5674
5675 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5676 (x_activate_menubar): Update the menu with title that matches
5677 ns_get_pending_menu_title, and call
5678 ns_check_pending_openmenu (Bug#12698).
5679 (menuWillOpen:): New method.
5680 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5681
5682 * nsterm.m (menu_will_open_state, menu_mouse_point)
5683 (menu_pending_title): New varaibles.
5684 (ns_get_pending_menu_title, ns_check_menu_open)
5685 (ns_check_pending_open_menu): New functions.
5686
781f4782
DA
56872013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5688
5689 * indent.c (current_column_bol_cache): Remove leftover which is not
5690 used in Fmove_to_column any more.
5691 (current_column, scan_for_column): Adjust users.
5692 * keyboard.c (last_point_position_buffer, last_point_position_window):
5693 Remove leftovers which are not used for recording undo any more.
5694 (command_loop_1, syms_of_keyboard): Adjust users.
5695 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5696 redisplay_window any more.
5697 (move_it_to): Adjust user.
5698
1921c31b
JB
56992013-03-29 Juanma Barranquero <lekktu@gmail.com>
5700
5701 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5702 Update dependencies.
5703
717b8bcd
SM
57042013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5705
5706 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5707 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5708 forward references.
5709
e74aeda8
DA
57102013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5711
5712 * window.h (struct window): Replace hchild, vchild and buffer slots
5713 with the only contents slot. This is possible because each valid
5714 window may have either the child window (in vertical or horizontal
5715 combination) or buffer to display (for the leaf window). Using that,
5716 a lof of operations to traverse and/or change window hierarchies may
5717 be simplified. New member horizontal is used to distinguish between
5718 horizontal and vertical combinations of internal windows.
5719 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5720 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5721 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5722 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5723 Use contents slot, not buffer, where appropriate.
5724 (wset_combination): New function.
5725 (wset_buffer): Add eassert.
5726 (Fframe_first_window): Simplify the loop reaching first window.
5727 (Fwindow_buffer): Use WINDOW_LEAF_P.
5728 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5729 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5730 (unshow_buffer): Convert initial debugging check to eassert.
5731 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5732 (make_parent_window, window_resize_check, window_resize_apply)
5733 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5734 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5735 Adjust to match struct window changes.
5736 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5737 (mark_window_cursors_off, count_windows, get_leaf_windows)
5738 (foreach_window_1): Simplify the loop.
5739 * alloc.c (mark_object): Do not check for the leaf window because
5740 internal windows has no glyph matrices anyway.
5741 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5742 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5743 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5744 (build_frame_matrix_from_window_tree, mirror_make_current)
5745 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5746 (update_window_tree, set_window_update_flags): Simplify the loop.
5747 (sync_window_with_frame_matrix_rows): Enforce live window.
5748 Use contents slot, not buffer, where appropriate.
5749 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5750 and WINDOW_HORIZONTAL_COMBINATION_P.
5751 (make_frame_visible_1): Simplify the loop.
5752 Use contents slot, not buffer, where appropriate.
5753 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5754 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5755 (expose_window_tree): Likewise.
5756 Use contents slot, not buffer, where appropriate.
5757 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5758 to avoid deleted windows. Use contents slot instead of buffer.
5759 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5760 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5761 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5762 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5763
121ab1cd
EZ
57642013-03-28 Eli Zaretskii <eliz@gnu.org>
5765
ef454cf7
EZ
5766 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5767 identify the reasons for assertion violations in bug#14062 and
5768 similar ones.
21e930f8
EZ
5769 (Fx_show_tip): Fix compilation error under
5770 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5771
121ab1cd
EZ
5772 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5773 Reported by <rzl24ozi@gmail.com>.
5774
5c89ca24
DA
57752013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5776
5777 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5778 start marker...
562c6ee9
SM
5779 (unwind_with_echo_area_buffer): ...to restore it here.
5780 This is needed to ensure that...
5c89ca24
DA
5781 (redisplay_window): ...both window markers are valid here,
5782 which is verified by eassert.
5783 * editfns.c (save_excursion_save): Do not assume that
5784 selected_window always displays the buffer.
c7f53895
DA
5785 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5786 Fix comment.
5c89ca24 5787
f557c1b1
SM
57882013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5789
5790 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5791 the upcase table.
5792
40693bba 57932013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5794
5795 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5796
c86f791f
EZ
57972013-03-27 Eli Zaretskii <eliz@gnu.org>
5798
5799 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5800 since MinGW's w32api headers do. This avoids compiler warnings.
5801
5802 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5803 if already defined.
5804
c6e72e17
EZ
58052013-03-26 Eli Zaretskii <eliz@gnu.org>
5806
5807 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5808
54e95010
JD
58092013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5810
5811 * gtkutil.c (style_changed_cb): Check if frame is live and an
5812 X frame (Bug#14038).
5813
b88b62de
EZ
58142013-03-26 Eli Zaretskii <eliz@gnu.org>
5815
a18d7de6
EZ
5816 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5817 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5818 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5819 MinGW64.
8f5e14c8
EZ
5820 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5821 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5822
b88b62de
EZ
5823 Fix incompatibilities between MinGW.org and MinGW64 headers.
5824 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5825
5826 * w32.c (REPARSE_DATA_BUFFER): Guard with
5827 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5828
c074e458
JD
58292013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5830
5831 * xterm.c: Include X11/XKBlib.h
5832 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5833
908589fd
AS
58342013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5835
5836 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5837 written backwards.
5838 * blockinput.h (input_blocked_p): Likewise.
5839 * bytecode.c (exec_byte_code): Likewise.
5840 * callproc.c (call_process_kill, call_process_cleanup)
5841 (Fcall_process): Likewise.
5842 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5843 (Fccl_execute_on_string): Likewise.
5844 * character.c (string_escape_byte8): Likewise.
5845 * charset.c (read_hex): Likewise.
5846 * cm.c (calccost): Likewise.
5847 * data.c (cons_to_unsigned): Likewise.
5848 * dired.c (directory_files_internal, file_name_completion):
5849 Likewise.
5850 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5851 (sit_for): Likewise.
5852 * doc.c (Fsubstitute_command_keys): Likewise.
5853 * doprnt.c (doprnt): Likewise.
5854 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5855 * emacsgtkfixed.c: Likewise.
5856 * fileio.c (file_offset, Fwrite_region): Likewise.
5857 * floatfns.c (Fexpt, fmod_float): Likewise.
5858 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5859 Likewise.
5860 * font.c (font_intern_prop): Likewise.
5861 * frame.c (x_set_alpha): Likewise.
5862 * gtkutil.c (get_utf8_string): Likewise.
5863 * indent.c (check_display_width): Likewise.
5864 * intervals.c (create_root_interval, rotate_right, rotate_left)
5865 (split_interval_right, split_interval_left)
5866 (adjust_intervals_for_insertion, delete_node)
5867 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5868 (merge_interval_right, merge_interval_left, copy_intervals)
5869 (set_intervals_multibyte_1): Likewise.
5870 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5871 * keymap.c (Fkey_description): Likewise.
5872 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5873 * lread.c (openp, read_integer, read1, string_to_number):
5874 Likewise.
5875 * menu.c (ensure_menu_items): Likewise.
5876 * minibuf.c (read_minibuf_noninteractive): Likewise.
5877 * print.c (printchar, strout): Likewise.
5878 * process.c (create_process, Faccept_process_output)
5879 (wait_reading_process_output, read_process_output, send_process)
5880 (wait_reading_process_output): Likewise.
5881 * profiler.c (make_log, handle_profiler_signal): Likewise.
5882 * regex.c (re_exec): Likewise.
5883 * regex.h: Likewise.
5884 * search.c (looking_at_1, Freplace_match): Likewise.
5885 * sysdep.c (get_child_status, procfs_ttyname)
5886 (procfs_get_total_memory): Likewise.
5887 * systime.h (EMACS_TIME_VALID_P): Likewise.
5888 * term.c (dissociate_if_controlling_tty): Likewise.
5889 * window.c (get_phys_cursor_glyph): Likewise.
5890 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5891 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5892 Likewise.
5893 * xfns.c (Fx_window_property): Likewise.
5894 * xmenu.c (set_frame_menubar): Likewise.
5895 * xselect.c (x_get_window_property, x_handle_dnd_message):
5896 Likewise.
5897 * xsmfns.c (smc_save_yourself_CB): Likewise.
5898 * xterm.c (x_scroll_bar_set_handle): Likewise.
5899
2bf7d27a
DA
59002013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5901
5902 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5903 to be optional or nil. Adjust comment and convert it to docstring.
5904 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5905 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5906
a9ebfa0b
PE
59072013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5908
5909 Static checking by GCC 4.8-20130319.
5910 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5911 * process.c (Fset_process_datagram_address)
5912 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5913 * xdisp.c (get_char_face_and_encoding):
5914 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5915 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5916 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5917
4f3576ee
KB
59182013-03-24 Ken Brown <kbrown@cornell.edu>
5919
789b5e9a
KB
5920 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5921 fix compilation on 64-bit Cygwin, where underscores are not
5922 automatically prepended.
5923
4f3576ee
KB
5924 * w32term.c (w32_initialize): Silence compiler warning.
5925
b5b7745f
EZ
59262013-03-23 Eli Zaretskii <eliz@gnu.org>
5927
cdc0d0bd
EZ
5928 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5929 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5930 variables, to save and restore frame dimensions.
5931 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5932 after returning from a 'fullscreen' configuration.
5933 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5934 to avoid races between the main thread and the input thread.
5935
5936 * w32term.h (struct w32_output): New members normal_width,
5937 normal_height, normal_top, normal_left, and prev_fsmode.
5938 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5939 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5940 members of a frame.
5941
b5b7745f
EZ
5942 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5943 'fullscreen' parameter. Always record previous width and height
5944 of the frame, except when switching out of maximized modes, so
5945 that they could be restored correctly, instead of resetting to the
5946 default frame dimensions. Send SC_RESTORE command to the frame,
5947 unless we are going to send SC_MAXIMIZE, to restore the frame
5948 resize hints in the mouse pointer shown by the window manager.
5949 (Bug#14032)
5950
5951 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5952
5953 * lisp.h (get_frame_param): Adjust conditions for prototype
5954 declaration.
5955
a3454eed
KB
59562013-03-22 Ken Brown <kbrown@cornell.edu>
5957
5958 * unexcw.c: Drop unneeded inclusion of w32common.h.
5959 (report_sheap_usage): Declare.
5960 (read_exe_header): Add magic numbers for x86_64.
5961 (fixup_executable): Fix printf format specifier for unsigned long
5962 argument.
5963
5a49b79c
DA
59642013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5965
5966 * frame.h (struct frame): Put menu_bar_window under #ifdef
5967 because this member is not needed when X toolkit is in use.
5968 (fset_menu_bar_window):
5969 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5970 (free_glyphs, update_frame):
5971 * xdisp.c (expose_frame): Likewise.
5972 (display_menu_bar): Likewise. Remove redundant eassert.
5973 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5974 toolkit is in use.
5975
d6723bf7
PE
59762013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5977
7b1123d8
PE
5978 Use functions and constants to manipulate Lisp_Save_Value objects.
5979 This replaces code that used macros and strings and token-pasting.
5980 The change makes the C source a bit easier to follow,
5981 and shrinks the Emacs executable a bit.
5982 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5983 (make_save_value): Change 1st arg from string to enum. All callers
5984 changed.
5985 (INTX): Remove.
5986 (mark_object): Use if, not #if, for GC_MARK_STACK.
5987 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5988 (XSAVE_OBJECT): Now functions, not macros.
5989 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5990 the constant was never used.
5991 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5992 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5993 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5994 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5995 New constants.
5996 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5997 type3 with a single member save_type. All uses changed.
5998 (save_type, set_save_pointer, set_save_integer): New functions.
5999 * print.c (PRINTX): Remove.
6000
d6723bf7
PE
6001 * alloc.c: Remove redundant static declarations.
6002
5f24fa51
DA
60032013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6004
6005 * window.h (struct window): Convert left_col, top_line, total_lines
6006 and total_cols from Lisp_Objects to integers. Adjust comments.
6007 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
6008 Remove.
6009 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
6010 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
6011 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
6012 Adjust users where appropriate.
6013
42143acd
DA
60142013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6015
6016 * frame.h (struct frame): Drop resx and resy because the same data is
6017 available from window system-specific output context. Adjust users.
562c6ee9
SM
6018 (default_pixels_per_inch_x, default_pixels_per_inch_y):
6019 New functions to provide defaults when no window system available.
42143acd 6020 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 6021 (NUMVAL): Move from xdisp.c.
42143acd
DA
6022 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
6023 (Ffont_face_attributes, Fopen_font):
6024 * image.c (gs_load):
6025 * w32font.c (fill_in_logfont):
6026 * xdisp.c (calc_pixel_width_or_height):
6027 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
6028 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
6029
c0a17406
KH
60302013-03-20 Kenichi Handa <handa@gnu.org>
6031
6032 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
6033 to 1 (temporary workaround until a bug related to ASCII
6034 optimization is fixed).
6035
095d384d
DA
60362013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
6037
6038 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
6039 Signal error if window is not internal. Adjust docstring.
6040 (delete_all_child_windows): Use combination_limit to save the buffer.
6041 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
6042 * print.c (syms_of_print): Initialize debugging output not here...
6043 (init_print_once): ...but in a new function here.
6044 * lisp.h (init_print_once): Add prototype.
6045 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 6046
748fa866
DA
60472013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
6048
6049 * window.c (window_resize_check, window_resize_apply)
6050 (window_from_coordinates, recombine_windows, set_window_buffer)
6051 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
6052 (Fsplit_window_internal, Fdelete_window_internal)
6053 (freeze_window_starts): Use bool for booleans.
6054 * window.h (window_frame_coordinates, resize_frame_windows)
6055 (freeze_window_starts, set_window_buffer): Adjust prototypes.
6056
81519fd2
SM
60572013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
6058
6059 * dispnew.c (bitch_at_user): Use `user-error'.
6060
6db423a9
KB
60612013-03-17 Ken Brown <kbrown@cornell.edu>
6062
6063 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
6064 as return type of image_background. (Bug#13981)
6065 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
6066
8f2906f5
JD
60672013-03-16 Jan Djärv <jan.h.d@swipnet.se>
6068
960ce480 6069 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 6070 (ns_select): Don't return with result uninitialized.
960ce480 6071
8f2906f5
JD
6072 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
6073 and getDirectory.
6074
81519fd2
SM
6075 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
6076 New functions.
8f2906f5
JD
6077 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
6078 directories. If filename is nil, get directory name (Bug#13932).
6079 Use getFilename and getDirectory.
6080 (getFilename, getDirectory): New methods for EmacsSavePanel and
6081 EmacsOpenPanel.
6082 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
6083
cded56c1
PE
60842013-03-15 Paul Eggert <eggert@cs.ucla.edu>
6085
6086 * coding.c (decode_coding_gap): Fix typo caught by static checking.
6087
251e9147 60882013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
6089
6090 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
6091 (adjust_after_replace): Make it back to static. Delete the third
6092 arg text_at_gap_tail. Cancel the code for handling it.
6093
6094 * coding.h (struct coding_system): New member eol_seen.
6095
6096 * coding.c (detect_ascii): New function.
6097 (detect_coding): Set coding->head_ascii and coding->eol_seen only
6098 when the source bytes are actually scanned. On detecting for
6099 coding_category_utf_8_auto, call detect_ascii instead of scanning
6100 source bytes directly.
6101 (produce_chars): Call insert_from_gap with the new arg 0.
6102 (encode_coding): Likewise.
6103 (decode_coding_gap): Control ASCII optimization by the variable
6104 disable_ascii_optimization instead of #ifndef .. #endif.
6105 Deccode EOL format according to coding->eol_seen.
6106 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
6107 variable.
6108
8a44e6d1
KH
6109 * lisp.h (adjust_after_replace): Cancel externing it.
6110 (insert_from_gap): Adjust prototype.
6111
5f795e34
EZ
61122013-03-15 Eli Zaretskii <eliz@gnu.org>
6113
6114 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
6115 FULLSCREEN_MAXIMIZED. (Bug#13935)
6116
f258b4be
DA
61172013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
6118
6119 * region-cache.c (find_cache_boundary, move_cache_gap)
6120 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
6121 Simplify debugging check and convert to eassert. Adjust comment.
6122 (pp_cache): Put under ENABLE_CHECKING.
6123
a5cc4dde
EZ
61242013-03-14 Eli Zaretskii <eliz@gnu.org>
6125
6126 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
6127 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
6128 and WM_ACTIVATEAPP.
6129 (w32fullscreen_hook): If the frame is visible, reset
6130 f->want_fullscreen flag after changing the frame size. If the
6131 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
6132 (Bug#13953)
6133
3fc5e44a
DC
61342013-03-13 Daniel Colascione <dancol@dancol.org>
6135
6136 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
6137 too so that these builds can use Cygwin's file conversion
6138 functions. (We've been building and linking cygw32.o all along
6139 and just not using it.)
6140
47d7532e
PE
61412013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6142
6143 File synchronization fixes (Bug#13944).
6144 * Makefile.in (LIB_FDATASYNC): New macro.
6145 (LIBES): Use it.
6146 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
6147 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
6148 Don't worry about HAVE_FSYNC, since a substitute fsync is
6149 available if the system lacks one.
6150 (Fwrite_regin): Retry fsync if interrupted.
6151
c7ffccaf
EZ
61522013-03-13 Eli Zaretskii <eliz@gnu.org>
6153
4e2df81d 6154 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
6155 activated, call w32fullscreen_hook, to make sure the new frame
6156 dimensions are in effect. (Bug#13937)
6157
8a7debc1
DA
61582013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
6159
6160 * xdisp.c (init_iterator): Simplify because both character and byte
6161 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
6162 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
6163 character and byte positions can be obtained from marker.
8a7debc1 6164
7fd8c501
PE
61652013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6166
d9df6f40
PE
6167 Static checking by Sun C 5.12.
6168 * alloc.c (buffer_memory_full) [REL_ALLOC]:
6169 * bytecode.c (exec_byte_code):
6170 * dispnew.c (init_display):
6171 * eval.c (error):
6172 * fileio.c (Fsubstitute_in_file_name):
6173 * keyboard.c (Fevent_convert_list):
6174 * keymap.c (Fsingle_key_description):
6175 * term.c (maybe_fatal, fatal):
6176 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
6177 * xsmfns.c (Fhandle_save_session):
6178 Omit unreachable code.
6179 * keymap.c (map_keymap_char_table_item): Cast void * to
6180 a function pointer type; the C Standard requires this.
6181
7fd8c501
PE
6182 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
6183 Include <sys/param.h> unconditionally, as that works elsewhere and
6184 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
6185 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
6186 and FreeBSD now.
6187
a020afb9 6188See ChangeLog.12 for earlier changes.
aac0c6e3
MR
6189
6190;; Local Variables:
6191;; coding: utf-8
aac0c6e3
MR
6192;; End:
6193
ab422c4d 6194 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
6195
6196 This file is part of GNU Emacs.
6197
6198 GNU Emacs is free software: you can redistribute it and/or modify
6199 it under the terms of the GNU General Public License as published by
6200 the Free Software Foundation, either version 3 of the License, or
6201 (at your option) any later version.
6202
6203 GNU Emacs is distributed in the hope that it will be useful,
6204 but WITHOUT ANY WARRANTY; without even the implied warranty of
6205 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6206 GNU General Public License for more details.
6207
6208 You should have received a copy of the GNU General Public License
6209 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.