(imagemagick_load_image): Remove the ping_wand code
[bpt/emacs.git] / src / ChangeLog
CommitLineData
274ff63f
LMI
12013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 4 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
5 (imagemagick_load_image): Remove the ping_wand code, which only
6 apparently saved time on invalid animated images, and slowed down
7 everything else. Optimise for the common case.
274ff63f 8
2bede2ed
XF
92013-08-16 Xue Fuqiao <xfq.free@gmail.com>
10
de179a3e
XF
11 * editfns.c (insert_before_markers): Mention overlay in the doc string.
12
2bede2ed
XF
13 * marker.c (set_marker): Remove documentation of undefined behavior.
14
703dbeba
LMI
152013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
16
17 * image.c (imagemagick_compute_animated_image): Animate correctly
18 when sub-images are smaller than the main image.
1d18b1e6
LMI
19 (imagemagick_compute_animated_image): Setting the iterator row to
20 zero is apparently not allowed.
79670014
LMI
21 (imagemagick_compute_animated_image): Allow images that say they
22 have sub-images that are bigger than the main image, but just crop
23 them.
703dbeba 24
63216c5e
JD
252013-08-15 Jan Djärv <jan.h.d@swipnet.se>
26
27 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
28
a5b5f73f
LMI
292013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
30
31 * image.c (imagemagick_compute_animated_image): Respect the GIF
32 disposal methods.
33
0fe73012
KB
342013-08-15 Ken Brown <kbrown@cornell.edu>
35
36 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
37 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
38 needed.
39
691a357f
PE
402013-08-15 Paul Eggert <eggert@cs.ucla.edu>
41
42 Fix minor problems found by static checking.
43 * frame.c (delete_frame):
44 * xdisp.c (next_element_from_display_vector):
45 Avoid uninitialized local.
46 * image.c (imagemagick_compute_animated_image): Port to C89.
47 Prefer usual GNU indentation style for loops.
48 Be more careful about bizarrely large sizes, by using ptrdiff_t
49 instead of int.
50
42fe2e88
DA
512013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
52
53 Fix infinite frame selection loop (Bug#15025).
54 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
55
d39a3da6
EZ
562013-08-15 Eli Zaretskii <eliz@gnu.org>
57
58 * xdisp.c (compute_window_start_on_continuation_line): When
59 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
60 to make sure we end up setting the window start at the leftmost
61 visible character of the display line. This avoids funky
62 horizontal shifting because the window start is not kept on the
63 same position. (Bug#15090)
05426239
EZ
64 (next_element_from_display_vector): Support 'box' face attribute
65 in the face definitions of a display vector. (Bug#15099)
d39a3da6 66
6e856b69
LMI
672013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
68
69 * image.c (imagemagick_compute_animated_image): Implement animated
70 images (bug#14700).
995be755
LMI
71 (imagemagick_compute_animated_image): Fix some compilation
72 warnings. Implement a very simple cache to make the animation
73 usable at all, but it should be replaced with a per-image cache.
6e856b69 74
d5a1acfa
DA
752013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
76
77 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
78 to do `for' loops over alist values.
79 * buffer.h (FOR_EACH_BUFFER):
80 * process.c (FOR_EACH_PROCESS): Use it.
81 (handle_child_signal, status_notify, Fget_buffer_process)
82 (kill_buffer_processes): Use FOR_EACH_PROCESS.
83
9c253307
DA
842013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
85
86 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
87 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
88 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
89 to xzalloc and so avoid redundant call to memset.
90 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
91 members because it is allocated with xzalloc and so already zeroed.
92
05e64f9f
KB
932013-08-14 Ken Brown <kbrown@cornell.edu>
94
95 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
96 (Bug#15094).
97
5b71542d
DA
982013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
99
100 Utility function and macro to copy Lisp string to C string.
101 * lisp.h (xlispstrdupa): New macro.
102 (xlispstrdup): New prototype.
103 * alloc.c (xlispstrdup): New function.
104 * callint.c (Fcall_interactively):
105 * fileio.c (Ffile_name_directory, Fexpand_file_name)
106 (Fsubstitute_in_file_name):
107 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
108 * image.c (x_create_bitmap_from_file):
109 * w32term.c (w32_term_init):
110 * xterm.c (x_term_init): Use xlispstrdup.
111
71530c97
LMI
1122013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
113
4ce82fb8
LMI
114 * image.c (imagemagick_load_image): Make animated pictures work.
115 There's still some problems with background color settings, though
116 (bug#14700).
117
71530c97
LMI
118 * decompress.c (unwind_decompress): Always restore point.
119
7510a061
XF
1202013-08-14 Xue Fuqiao <xfq.free@gmail.com>
121
122 * marker.c (set_marker): Reformat documentation.
123
01c3051f
PE
1242013-08-14 Paul Eggert <eggert@cs.ucla.edu>
125
aab1fcdf
PE
126 * xdisp.c (cursor_type_changed): Now static.
127
01c3051f
PE
128 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
129 Use changed. This avoids the need to call xmalloc and for the
130 caller to call xfree, and avoids memory leaks in some situations.
131
2084152a
DA
1322013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
133
134 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
135 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
136 (redisplay_window): If window_end_valid is cleared due to non-zero
137 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
138 so do not call to try_cursor_movement for that window.
2084152a 139
02455cb6
DA
1402013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
141
142 * window.h (struct window): Convert window_end_pos and
143 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
144 (wset_window_end_pos, wset_window_end_vpos): Remove.
145 * dispnew.c (adjust_glyph_matrix):
146 * window.c (Fwindow_end, replace_window, set_window_buffer)
147 (make_window):
148 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
149 (set_vertical_scroll_bar, redisplay_window, try_window)
150 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
151 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
152 (note_mouse_highlight): Adjust users.
153 (try_cursor_movement): Likewise. Convert old precondition to eassert.
154 Add comment.
155
da5707e8
DA
1562013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
157
158 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
159 * image.c (imagemagick_filename_hint): Use `const char *' and
160 prefer SSDATA to SDATA to avoid warnings.
161
25554267
DA
1622013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
163
164 Cleanup window fringes, margins and scroll bars adjustments.
165 * window.c (set_window_fringes, set_window_margins)
166 (set_window_scroll_bars, apply_window_adjustment): New functions.
167 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
168 (Fset_window_scroll_bars): Use them.
169
38a2c910
DA
1702013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
171
172 * window.h (struct window): Convert scroll_bar_width
173 from Lisp_Object to integer. Adjust comment.
174 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
175 Adjust users.
176 * window.c (wset_scroll_bar_width): Remove.
177 (make_window): Initialize scroll_bar_width.
178 (Fsplit_window_internal): Use direct assignment.
179 (Fset_window_configuration, save_window_save):
180 Convert Lisp_Object to integer and back where appropriate.
181 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
182 bar was actually changed, and mention this in docstring.
183
2d065031
PE
1842013-08-13 Paul Eggert <eggert@cs.ucla.edu>
185
186 * decompress.c: Minor simplifications.
187 (Fzlib_decompress_region): Don't bother verifying
188 that avail_out <= UINT_MAX, as that was confusing.
189 Mention the restriction in a comment instead.
190 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
191
a5bd5abb
JD
1922013-08-13 Jan Djärv <jan.h.d@swipnet.se>
193
194 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
195 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
196
66e7901a
LMI
1972013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
198
199 * image.c (imagemagick_filename_hint): Check for errors in the
200 alist structure.
201
2fa611b7
EZ
2022013-08-13 Eli Zaretskii <eliz@gnu.org>
203
204 * window.c (Fwindow_margins): Return nil when there's no marginal
205 area, as per the documented API.
206
207 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
208 Fmake_vector, as scroll bar's struct members are not all Lisp
209 objects now. This avoids crashes in GC.
210
211 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
212 bool, so its address could be taken.
213
8259030d
LMI
2142013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
215
216 * image.c (imagemagick_filename_hint): New function to possibly
217 apply `image-content-type-suffixes'.
218 (imagemagick_load_image): Use it.
219
866c710e
EZ
2202013-08-13 Eli Zaretskii <eliz@gnu.org>
221
222 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
223 if loading zlib failed.
224
f10490f0
JD
2252013-08-13 Jan Djärv <jan.h.d@swipnet.se>
226
96311be7
JD
227 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
228 2013-08-13 checkin below. Change bool to BOOL, rule is:
229 All Obj-C code uses BOOL, except for interfaces callable from C.
230
f10490f0
JD
231 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
232
c8ae93b0
DA
2332013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
234
235 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
236 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
237 bool instead of BOOL.
238 * w32term.h (struct scroll_bar): Convert fringe_extended_p
239 from Lisp_Object to bitfield. Adjust comment.
240 * w32term.c (x_scroll_bar_create): Adjust user.
241 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
242 * xterm.c (XTset_vertical_scroll_bar): Likewise.
243 Use bool for boolean.
244 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
245 to `unsigned int' when defining a bitfield.
246
53b64418
PE
2472013-08-13 Paul Eggert <eggert@cs.ucla.edu>
248
249 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
250
eeaf9bf3
DA
2512013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
252
253 * window.h (struct window): Convert left_margin_cols and
254 right_margin_cols from Lisp_Objects to integers. Adjust comment.
255 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
256 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
257 Adjust users.
258 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
259 Adjust comment.
260 (showing_window_margins_p, update_window_line, update_frame_1):
261 * fringe.c (draw_fringe_bitmap_1):
262 * xdisp.c (window_box_width): Adjust users.
263 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
264 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
265 Use direct assignment.
266 (Fset_window_configuration, save_window_save, Fwindow_margins):
267 Convert Lisp_Object to integer and back where appropriate.
268 (Fset_window_margins): Adjust user. Return t if any margin
269 was actually changed, and mention this in docstring.
270
956720af
XF
2712013-08-13 Xue Fuqiao <xfq.free@gmail.com>
272
f73f4ce6 273 * syntax.c (forward_word):
956720af
XF
274 * cmds.c (forward_char, backward_char): Mention the optional argument.
275
9e37ee3b
DA
2762013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
277
278 * window.h (struct window): Convert left_fringe_width
279 and right_fringe_width from Lisp_Objects to integers.
280 Adjust comment.
281 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
282 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
283 * window.c (wset_left_fringe_width, wset_right_fringe_width):
284 Remove.
285 (make_window): Initialize new integer fields to -1.
286 (Fsplit_window_internal): Use direct assignment.
287 (Fset_window_configuration, save_window_save): Convert
288 Lisp_Object to integer and back where appropriate.
289 (Fset_window_fringes): Adjust user. Return t if any fringe
290 was actually changed, and mention this in docstring.
291
e4375ca7
DA
2922013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
293
294 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
295 * nsfns.m (x_set_cursor_type):
296 * w32fns.c (x_set_cursor_type):
297 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
298 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 299
a45543bc
DA
3002013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
301
302 * font.c (clear_font_cache): New function, stripped from...
303 (Fclear_font_cache): ...here, which now uses the function
304 above. Adjust comment.
305 * font.h (clear_font_cache): Add prototype.
306 * xfaces.c (clear_face_cache): Use clear_font_cache.
307
ae966a86
DA
3082013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
309
310 * window.c (Fset_window_start): Compare `w', not `window' because
311 `w' might not be equal to `window' after call to decode_live_window.
312
297a545b
PE
3132013-08-12 Paul Eggert <eggert@cs.ucla.edu>
314
315 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
316 This fixes a problem introduced by the Bug#15035 patch
317 when using GPG. Reported by Herbert J. Skuhra.
318
aa942e2b
EZ
3192013-08-12 Eli Zaretskii <eliz@gnu.org>
320
321 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
322 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
323 not yet initialized.
324
7699d09e
LMI
3252013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
326
327 * decompress.c (Fzlib_decompress_region): Support zlib
328 decompression, too, and rename.
329
1d238bc7
PE
3302013-08-12 Paul Eggert <eggert@cs.ucla.edu>
331
332 Minor zlib configuration tweaks.
333 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
334 Don't assume presence of fn_inflateInit2_ zlib internal function.
335
8a44a184
LMI
3362013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
337
338 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
339 include the zlib prefix.
340
594a4307
EZ
3412013-08-12 Eli Zaretskii <eliz@gnu.org>
342
343 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
344 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
345 define static variables that are pointers to zlib functions to be
346 dynamically loaded.
347 (init_zlib_functions) [WINDOWSNT]: New function.
348 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
349 New macros.
350 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
351 macros instead of invoking the zlib functions directly.
352 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
353 Szlib_available_p.
354
d2e113bc
DA
3552013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Avoid looping over all frame windows to freeze and unfreeze.
358 * window.h (struct window): Drop frozen_window_start_p.
359 (freeze_window_starts): Drop prototype.
360 * frame.h (struct frame): New frozen_window_starts flag.
361 (FRAME_WINDOWS_FROZEN): New macro.
362 * window.c (freeze_window_start, freeze_window_starts):
363 Remove.
364 (select_window, replace_window): Adjust users.
365 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
366 (window_frozen_p): New function.
367 (redisplay_window): Use it.
368
94fcd171
PE
3692013-08-12 Paul Eggert <eggert@cs.ucla.edu>
370
371 Fix some fd issues when running subprocesses (Bug#15035).
372 Fix bugs that can leak files or file descriptors on errors.
373 Don't unlink open temp files, as that's hard for users to diagnose
374 when things go awry (e.g., temp disk exhausted).
375 Don't bother to lock temp files. Check for invalid recursion.
376 * callproc.c (synch_process_fd): Remove. All uses removed.
377 (synch_process_tempfile): New var or macro.
378 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
379 New constants.
380 (record_kill_process): New arg, the temp name. All callers changed.
381 (delete_temp_file): Now just a simple wrapper around unlink.
382 (call_process_kill): New arg, the call_process_fd array.
383 Close them all. Clear synch_process_pid. Remove the temp file,
384 or arrange for it to be removed.
385 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
386 that's been moved to synch_process_tempfile. Caller changed.
387 Do not remove the tempfile; that's now call_process_kill's
388 responsibility.
389 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
390 call_process_kill; the caller now does that.
391 (call_process_cleanup): Do not close the process fd; that's now
392 call_process_kill's responsibility.
393 (Fcall_process): Implement via new function call_process, which
394 has most of the old body of Fcall_process, but with a different API.
395 (call_process): New function that does not open or close filefd if
396 it is nonnegative. Record which fds need to be closed, and let
397 call_process_kill close (and remove the tempfile, on MSDOS) on error.
398 Signal an error if invoked recursively (could be done via a hook).
399 Simplify creation of the tempfile in the MSDOS case.
400 Don't create the output file until after checking for the executable.
401 Report any failure to open /dev/null.
402 Don't open /dev/null for writing twice; once is enough.
403 Don't create pipe if all output is being discarded or sent to file.
404 Don't worry about setting up the coding system or reading from the
405 pipe if all output is being discarded.
406 Hoist fd_error local into top level, to lessen block nesting.
407 Don't record deleted pid here; now done by Fcall_process_region.
408 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
409 and note its success in synch_process_tempfile.
410 Do not leak resources when child_setup fails.
411 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
412 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
413 (create_temp_file): Now returns open fd, with an additional
414 Lisp_Object * argument to return the name. All callers changed.
415 Do not close the file; rewind it instead, and leave it open for
416 the caller. Do not lock the temp file. Unwind-protect the file
417 and the file-descriptor.
418 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
419 If an asynchrounous process, record it here, not in call_process.
420 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
421 * eval.c (set_unwind_protect): New function.
422 * fileio.c (write_region): New function, generalized from the
423 old Fwrite_region. Do not lock temp files.
424 (Fwrite_region): Use it.
425 * lisp.h (set_unwind_protect, write_region): New decls.
426 * process.c: Include <verify.h>.
427 (make_process): Mark fds as initially closed.
428 (deleted_pid_list): Now a list of pid-filename pairs.
429 All uses changed.
430 (close_process_fd): New function.
431 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
432 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
433 New constants. Verify that their number matches PROCESS_OPEN_FDS.
434 (create_process, create_pty, Fmake_serial_process)
435 (server_accept_connection): Record which fds need to be closed,
436 and let deactivate_process close them.
437 (Fmake_network_process): Do not discard the unwind-protect
438 until it's safe to do so.
439 (deactivate_process): Close the fds opened by create_process etc.
440 (Fprocess_send_eof): Adjust to new way of recording open fds.
441 Report an error if /dev/null can't be opened, instead of aborting.
442 * process.h (PROCESS_OPEN_FDS): New constant.
443 (struct Lisp_Process): New member open_fds.
444 (record_kill_process, record_deleted_pid): Adjust signatures.
445 (record_deleted_pid): Move decl here ...
446 * syswait.h (record_deleted_pid): ... from here.
447
d0e615c3
PE
4482013-08-11 Paul Eggert <eggert@cs.ucla.edu>
449
450 * decompress.c: Fix bugs with large buffers and weird inputs.
451 Tune a bit. Reindent as per usual Emacs style.
452 (BUFFER_SIZE): Remove.
453 (Fdecompress_gzipped_region): Do not mishandle input buffers with
454 more than UINT_MAX bytes. Decompress into the gap instead of into
455 an auto buffer, as this should avoid copying. Return nil if
456 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
457 set immediate_quit; we shouldn't trust zlib code that much.
458
313546eb
LMI
4592013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
460
99a32242
LMI
461 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
462 errors, and really move the gap to where we want it.
463
313546eb
LMI
464 * lisp.h: Include decompress.c support.
465
466 * emacs.c (main): Include decompress.c support.
467
468 * Makefile.in: Include -lz if present.
469
d2d699ac
JD
4702013-08-11 Jan Djärv <jan.h.d@swipnet.se>
471
f90e3ebd
JD
472 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
473 (initWithTitle:): Initialize frame to 0.
474 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
475 (fillWithWidgetValue:frame:): Renamed from
476 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
477
478 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
479 fillWithWidgetValue:frame:
480
423d3b3f
JD
481 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
482 remove memory leak warnings.
483
d2d699ac
JD
484 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
485 (ns_check_menu_open): Handle menu == nil. Remove assignment to
486 menu_pending_title.
487
488 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
489 (x_activate_menubar): Update the whole menu.
490 (trackingNotification:): Call ns_check_menu_open if tracking ends.
491 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
492 current event is not NSSystemDefined (Bug#15001).
493 Call ns_check_menu_open only if trackingMenu is 2.
494 (menuDidClose:): New method, decrease trackingMenu.
495 (fillWithWidgetValue:setDelegate:): New method.
496 (fillWithWidgetValue:): Call the above.
497
498 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
499
7d652d97
PE
5002013-08-11 Paul Eggert <eggert@cs.ucla.edu>
501
502 Omit some unnecessary casts.
503 Many of these go back to the old pre-C89 days, when they may have
504 been needed, but we've been assuming C89 or later for a while now.
505 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
506 (live_float_p, live_misc_p, live_vector_p):
507 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
508 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
509 (defvar_per_buffer):
510 * callint.c (Fcall_interactively):
511 * doc.c (Fsubstitute_command_keys):
512 * filelock.c (get_boot_time):
513 * frame.c (xrdb_get_resource):
514 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
515 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
516 (xg_get_file_name_from_selector, menuitem_destroy_callback)
517 (menuitem_highlight_callback, menu_destroy_callback)
518 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
519 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
520 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
521 (xg_tool_bar_help_callback, tb_size_cb):
522 * image.c (xpm_alloc_color, png_read_from_memory)
523 (png_read_from_file, png_load_body, our_memory_skip_input_data)
524 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
525 (syms_of_image):
526 * keymap.c (describe_map):
527 * nsfns.m (Fns_display_monitor_attributes_list):
528 * nsmenu.m (process_dialog:):
529 * nsterm.m (hold_event):
530 * process.c (wait_reading_process_output):
531 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
532 * scroll.c (do_direct_scrolling, scrolling_1):
533 * termcap.c (tgetent):
534 * window.c (check_window_containing, add_window_to_list)
535 (freeze_window_starts):
536 * xdisp.c (compare_overlay_entries, vmessage):
537 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
538 (x_get_monitor_attributes_xrandr)
539 (Fx_display_monitor_attributes_list, x_display_info_for_name)
540 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
541 * xfont.c (xfont_match, xfont_open):
542 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
543 (menubar_selection_callback, menu_position_func)
544 (popup_selection_callback, create_and_show_popup_menu)
545 (dialog_selection_callback, create_and_show_dialog):
546 * xrdb.c (x_get_string_resource):
547 (main) [TESTRM]:
548 * xsmfns.c (x_session_check_input):
549 * xterm.c (x_draw_glyphless_glyph_string_foreground)
550 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
551 (xaw_jump_callback, xaw_scroll_callback):
552 Omit unnecessary casts.
553
9acc1074
PE
5542013-08-10 Paul Eggert <eggert@cs.ucla.edu>
555
556 Minor string-length refactoring.
557 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
558 * frame.c (make_monitor_attribute_list):
559 Prefer build_string to strlen + make_string.
560
361c0eb8
JD
5612013-08-10 Jan Djärv <jan.h.d@swipnet.se>
562
563 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
564 don't check minor_code (Bug#14417).
565
14ba0822
EZ
5662013-08-09 Eli Zaretskii <eliz@gnu.org>
567
568 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
569 vertical positions instead. This avoids calling MATRIX_ROW with
570 row numbers that are possibly beyond valid limits. (Bug#15064)
571
309f24d1
DA
5722013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
573
574 Use xstrdup and build_unibyte_string where applicable.
575 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
576 * xfns.c (x_window):
577 * xrdb.c (x_get_customization_string):
578 * xterm.c (xim_initialize):
579 * w32fns.c (w32_window): Use xstrdup.
580 (w32_display_monitor_attributes_list):
581 * emacs.c (init_cmdargs):
582 * keyboard.c (PUSH_C_STR):
583 * nsfont.m (nsfont_open):
584 * sysdep.c (system_process_attributes):
585 * w32.c (system_process_attributes):
586 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
587
55902276
EZ
5882013-08-09 Eli Zaretskii <eliz@gnu.org>
589
590 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
591 variables of these types so that GDB would know about them, as aid
592 for debugging fatal exceptions. (Bug#15024) See also
593 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
594 discussions.
595
10bf7f5a
JD
5962013-08-08 Jan Djärv <jan.h.d@swipnet.se>
597
598 * nsterm.m (ns_update_begin): Don't change clip path if it would be
599 larger than the NSWindow (Bug#14934).
600
65620264
DA
6012013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
602
603 Redesign redisplay interface to drop global variable updated_window.
604 Always pass currently updated window as a parameter to update routines.
605 * dispextern.h (updated_window): Remove declaration.
606 (struct redisplay_interface): Pass window parameter to
607 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
608 and after_update_window_hook.
609 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
610 Adjust prototypes.
611 * dispnew.c (updated_window): Remove.
612 (redraw_overlapped_rows, update_marginal_area, update_text_area)
613 (update_window_line): Adjust to match redisplay interface changes.
614 * nsterm.m (ns_update_window_begin, ns_update_window_end)
615 (ns_scroll_run, ns_after_update_window_line):
616 * w32term.c (x_update_window_begin, x_update_window_end)
617 (x_after_update_window_line, x_scroll_run):
618 * xterm.c (x_update_window_begin, x_update_window_end)
619 (x_after_update_window_line, x_scroll_run):
620 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
621 Likewise. Adjust comments where appropriate.
622 (x_cursor_to): Simplify because this is always called during window
623 update (but install debugging check anyway).
624 (expose_window): Check must_be_updated_p flag to see whether this
625 function is called during window update.
626
628fdc56
DA
6272013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
628
629 Do not reset window modification event counters excessively.
630 These leftovers and poor man's tricky methods to catch extra
631 redisplay's attention are no longer needed.
632 * frame.c (set_menu_bar_lines_1):
633 * minibuf.c (read_minibuf_unwind):
634 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
635 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
636 (window_scroll_line_based, Fset_window_configuration):
637 * xdisp.c (redisplay_window): Do not reset last_modified and
638 last_overlay_modified counters.
639
8fd9c92e
JD
6402013-08-07 Jan Djärv <jan.h.d@swipnet.se>
641
642 * xselect.c (x_send_client_event): Set send_event and serial, memset
643 data.l as it might be bigger than data.b. Use 24 bit mask to
644 XSendEvent (Bug#15034).
645
0ee18172
EZ
6462013-08-07 Eli Zaretskii <eliz@gnu.org>
647
648 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
649 for TTY frames that are not the top frame on their console.
650 (Bug#14616)
651
16ddd1a6
MR
6522013-08-07 Martin Rudalics <rudalics@gmx.at>
653
654 * w32term.c (w32fullscreen_hook): Really maximize frame when
655 asked for (Bug#14841).
656
d2a95ffb
DA
6572013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
658
659 Prefer selected_window to Fselected_window, likewise for frames.
660 * buffer.c (Fbuffer_swap_text):
661 * data.c (Fvariable_binding_locus):
662 * window.c (run_window_configuration_change_hook): Adjust users.
663 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
664 Use decode_live_frame.
665
170da1ec
DA
6662013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Be more careful if selected window shows the buffer other than current,
669 use window_outdated only if this is not so. This change should also
670 address some weird issues discussed in Bug#13012.
671 * window.h (window_outdated): New prototype.
672 * window.c (window_outdated): Now here. Convert from static and
673 always assume window's buffer.
674 (Fwindow_end, Fwindow_line_height): Use it.
675 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
676 and always assume window's buffer.
677 (redisplay_window): Adjust user.
e5eefe9b 678 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
679 check whether mode line should be updated only if selected window
680 shows current buffer.
681 (run_window_scroll_functions): Use eassert for debugging check.
682 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
683
56b5d5b1
DA
6842013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
685
686 * window.c (window_scroll, window_scroll_pixel_based)
687 (window_scroll_line_based): Use bool for booleans.
688
2878ba7e
PE
6892013-08-06 Paul Eggert <eggert@cs.ucla.edu>
690
691 * process.c: Fix minor off-by-one issues in descriptor counts.
692 This shouldn't fix any real bugs, but it cleans up the code a bit.
693 (max_process_desc, max_input_desc): -1, not 0, means none.
694 All uses changed.
695 (delete_input_desc): New function.
696 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
697 (deactivate_process): Scan backwards when recomuting max_process_desc;
698 that should be faster.
699 (init_process_emacs): Initialize max_input_desc.
700
e30b79c1
DA
7012013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
702
703 Use region cache to speedup bidi_find_paragraph_start.
704 * buffer.h (struct buffer): New member bidi_paragraph_cache.
705 Rename cache_long_line_scans to cache_long_scans.
706 * buffer.c (bset_cache_long_line_scans): Rename to
707 bset_cache_long_scans.
708 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
709 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
710 into account.
711 (syms_of_buffer): Rename cache-long-line-scans to
712 cache-long-scans. Adjust docstring.
713 * search.c (newline_cache_on_off):
714 * indent.c (width_run_cache_on_off): Adjust users.
715 * bidi.c (bidi_paragraph_cache_on_off): New function.
716 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
717 * insdel.c (prepare_to_modify_buffer): Invalidate
718 bidi_paragraph_cache if enabled.
719
00012b86
DA
7202013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
721
722 Invalidate region caches only if buffer text is going to be changed.
723 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
724 (modify_text): ...new prototype.
725 (prepare_to_modify_buffer_1): New prototype.
726 * textprop.c (modify_region): Rename to...
727 (modify_text_properties): ...new function.
728 (add_text_properties_1, set_text_properties, Fremove_text_properties)
729 (Fremove_list_of_text_properties): Adjust users.
730 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
731 (modify_text): ...new function.
732 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
733 (prepare_to_modify_buffer_1): ...new function.
734 * casefiddle.c (casify_region):
735 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
736 (Ftranspose_regions): Use modify_text.
737
dc6c0eda
SM
7382013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
739
740 * lisp.mk (lisp): Add nadvice.elc.
741
8f3a2c26
DA
7422013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
743
744 New macro to iterate over live buffers similar to frames.
745 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
746 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
747 Declare buffer-related variables here to offload lisp.h.
748 * buffer.c (Vbuffer_alist): Adjust comment.
749 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
750 (other_buffer_safely):
751 * data.c (store_symval_forwarding):
752 * dispnew.c (Fframe_or_buffer_changed_p):
753 * fileio.c (Fdo_auto_save):
754 * filelock.c (unlock_all_files):
755 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
756
e0fdb694
PE
7572013-08-04 Paul Eggert <eggert@cs.ucla.edu>
758
759 Fix some minor races in hosts lacking mkostemp (Bug#15015).
760 * callproc.c (create_temp_file):
761 * filelock.c (create_lock_file):
762 Assume mkostemp, since it's now provided by Gnulib.
763
63f5c6c2
EZ
7642013-08-04 Eli Zaretskii <eliz@gnu.org>
765
766 * w32.c (mkostemp): New function.
767 (mktemp): Remove, no longer used. Most of the code reused in
768 mkostemp. (Bug#15015)
484ab239 769 (mktemp): Don't undef.
63f5c6c2 770
f0b79313
DA
7712013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
772
773 * dispnew.c (glyph_matrix_count, glyph_pool_count):
774 Move under GLYPH_DEBUG and ENABLE_CHECKING.
775 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
776 (free_glyph_pool, check_glyph_memory): Likewise for
777 all users. Adjust comments where appropriate.
778
98f638d6
PE
7792013-08-03 Paul Eggert <eggert@cs.ucla.edu>
780
781 * composite.h: Minor fixups.
782 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
783 to fix a misspelling, and change it to an inline function while
784 we're at it (it need not be a macro). All uses changed.
785 (composition_method, composition_valid_p):
786 Rewrite to avoid assignments in if-conditions.
787
75c59fb3
DA
7882013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
789
790 Do not use global Lisp_Object in composition macros.
791 * composite.h (composition_temp): Remove declaration.
792 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
793 (composition_method, composition_valid_p): ...inline functions.
416a3e01 794 (compose_region): Remove the leftover.
75c59fb3
DA
795 * composite.c (composition_temp): Remove.
796 (run_composition_function, update_compositions)
797 (composition_compute_stop_pos, composition_adjust_point)
798 (Ffind_composition_internal):
799 * coding.c (handle_composition_annotation):
800 * xdisp.c (handle_composition_prop, check_point_in_composition):
801 Related users changed.
802
a10c8269
DA
8032013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
804
805 Drop FRAME_PTR typedef.
806 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
807 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
808 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
809 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
810 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
811 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
812 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
813 All related users changed.
814
a104f656
SM
8152013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
816
817 * eval.c (default_toplevel_binding): New function.
818 (Fdefvar): Use it.
819 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
820 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
821 (syms_of_eval): Export them.
822 * data.c (Fdefault_value): Micro cleanup.
823 * term.c (init_tty): Use "false".
824
4b5c9326
DA
8252013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
826
827 Fix X GC leak in GTK and raw (no toolkit) X ports.
828 * xterm.c (x_free_frame_resources): If white and black relief
829 GCs are allocated, always free them here.
830 * xfns.c (x_make_gc): Omit redundant initialization.
831 * widget.c (create_frame_gcs): Remove the leftover.
832 (EmacsFrameDestroy): Do nothing because all GCs are now freed
833 in x_free_frame_resources.
834
b19aa636
JD
8352013-08-02 Jan Djärv <jan.h.d@swipnet.se>
836
837 * nsterm.m (windowWillResize:toSize:): Only change title if
838 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
839 modifying it.
840 (viewDidEndLiveResize): New method.
841
842 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
843 inside NS_IMPL_COCOA.
844
af1f7e06
DA
8452013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
846
847 * insdel.c (adjust_after_replace, replace_range, del_range_2):
848 Do not check whether undo is enabled because record_insert and
849 record_delete does that themselves.
850
65b02bb9
DA
8512013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
852
853 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
854 member which is not really used any more.
855 (FRAME_XIC_BASE_FONTNAME): Remove.
856 * xfns.c (xic_free_fontset): Adjust user.
857 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
858 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
859 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
860 (xdialog_show): Use eassert for debugging check.
7ee0f047 861 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 862
6318cde0
PE
8632013-08-01 Paul Eggert <eggert@cs.ucla.edu>
864
865 * fileio.c, fns.c (merge): Move extern decl from here ...
866 * lisp.h (merge): ... to here.
867
6c1a09ba
DA
8682013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
869
870 Fix last font-related change.
871 * w32font.h (w32font_list_internal, w32font_match_internal):
872 Fix prototype.
873 * w32uniscribe.c (uniscribe_list, uniscribe_match):
874 (uniscribe_list_family): Adjust to match font API change.
875 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
876 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
877
f8c20208
DA
8782013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
879
880 * frame.h (FRAME_MOUSE_UPDATE):
881 * nsterm.m (ns_frame_up_to_date): Omit redundant check
882 whether hlinfo->mouse_face_mouse_frame is non-NULL.
883
fdb396e2
DA
8842013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
885
886 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
887 * font.h (struct font_driver): Change list, match, and list_family
888 functions to accept struct frame * as first arg.
889 * font.c (font_score, font_compare, font_sort_entities): Remove
890 prototypes.
891 (font_sort_entities, font_list_entities, font_select_entity):
892 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
893 match font API change.
894 * xfont.c (xfont_list, xfont_match, xfont_list_family):
895 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
896 * ftxfont.c (ftxfont_list, ftxfont_match):
897 * xftfont.c (xftfont_list, xftfont_match):
898 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
899 * w32font.c (w32font_list, w32font_match, w32font_list):
900 (w32font_list_internal, w32_font_match_internal): Likewise.
901 * xfaces.c (Fx_family_fonts): Adjust user.
902
52b8a085
DA
9032013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
904
905 Do not use pure Xism x_wm_set_icon_position in non-X ports.
906 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
907 only if HAVE_X_WINDOWS is in use.
908 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
909 * nsterm.m (x_wm_set_icon_position): Remove no-op.
910 * w32term.c (x_wm_set_icon_position): Likewise.
911 * w32fns.c (x_icon): Adjust user.
912
c791c18e
DA
9132013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
914
915 * xterm.c (last_mouse_press_frame): Remove the
916 leftover which is not really used any more.
917 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
918 (x_flush): Call XFlush once per each X display, not frame.
919 This is better because this code always unconditionally skips
920 non-X frames in Vframe_list and issues the only XFlush if we
921 have more than one X frame on the same X display.
2f935d86
DA
922 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
923 Use bool for booleans.
924 (x_draw_glyph_string_background, cvt_string_to_pixel):
925 (cvt_pixel_dtor): Drop unnecessary prototypes.
926 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 927
f435830e
DA
9282013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
929
930 Drop unnecessary functions that deals with frame pixel size.
931 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
932 (x_pixel_height): Drop prototypes.
933 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
934 (x_pixel_height): Drop implementations.
935 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
936 which should be always valid for window frame.
937 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
938 * w32menu.c (Fx_popup_dialog):
939 * xmenu.c (Fx_popup_dialog): Likewise for both.
940
84231434
DA
9412013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
942
943 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
944 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
945 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
946 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
947 and mention nil frame in docstring.
84231434 948
959067a1
DA
9492013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
950
951 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
952 (x_figure_window_size): Likewise. Adjust to return long.
953 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
954 (toplevel): Move Qterminal_live_p to...
955 * terminal.c (toplevel): ...here, make it static, and...
956 (syms_of_terminal): ...DEFSYM here.
957 * frame.h (Qterminal_live_p): Remove declaration.
958 (make_frame, x_figure_window_size): Adjust prototype.
959 * nsfns.m (Fx_create_frame): Use long for window flags.
960
f4b169ce
PE
9612013-07-30 Paul Eggert <eggert@cs.ucla.edu>
962
963 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
964 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
965 Do not assume that emacs_close (INT_MAX) is a no-op.
966
bee6a2c7
DA
9672013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
968
969 * xfaces.c (make_face_cache): For struct face_cache, prefer
970 xmalloc to xzalloc and so avoid redundant call to memset.
971 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
972
d7e6881a
DA
9732013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
974
975 * fringe.c (draw_window_fringes, update_window_fringes)
976 (compute_fringe_widths):
977 * w32term.c (x_draw_glyph_string):
978 * window.c (candidate_window_p, Frecenter):
979 * xfaces.c (realize_basic_faces, realize_default_face)
980 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
981 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
982 * xfns.c (x_set_cursor_color, xic_free_xfontset):
983 * xmenu.c (Fx_menu_bar_open_internal):
984 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
985 * xsettings.c (xft_settings_event):
986 * xterm.c (x_draw_glyph_string, x_had_errors_p):
987 Use bool for booleans. Adjust style and comments where
988 appropriate.
989 * dispextern.h (draw_window_fringes, update_window_fringes)
990 (compute_fringe_widths):
991 * xterm.h (x_had_errors_p): Adjust prototype.
992
ec3058af
DA
9932013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
994
995 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
996 CHECK_LIST. Rewrite the loop to avoid useless local variable.
997
218e0637
DA
9982013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 * fns.c (toplevel): Remove comment before Fsafe_length because
1001 it checks for QUIT.
1002
e560aba9
PE
10032013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1006
2e5ce5de
EZ
10072013-07-28 Eli Zaretskii <eliz@gnu.org>
1008
1009 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1010 frame which got the message is still alive, before dereferencing
1011 its pointer. (Bug#14970)
1012
1013 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1014 be a live window, before using it as such. (Bug#14970)
1015
e95da6d3
EZ
10162013-07-27 Eli Zaretskii <eliz@gnu.org>
1017
1018 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1019 w32_detect_focus_change instead of doing part of its job by hand.
1020 This fixes the problem whereby FOCUS_OUT events were not sent to
1021 the event queue.
1022
a8f93651
EZ
10232013-07-26 Eli Zaretskii <eliz@gnu.org>
1024
fec92060
EZ
1025 * process.c (Fprocess_list): Doc fix.
1026
a8f93651
EZ
1027 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1028 being re-exposed only if it didn't ask to become visible.
1029 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1030 was previously iconified. (Bug#14841)
1031 (x_iconify_frame): Mark the frame iconified.
1032
d5a7a9d9
PE
10332013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 Fix minor problems found by static checking.
1036 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1037 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1038
56ea7291
SM
10392013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1040
1041 * eval.c (set_specpdl_old_value): New function.
1042 (unbind_to): Minor simplification.
1043 (get_backtrace_frame): New function.
1044 (Fbacktrace_frame): Use it. Add `base' argument.
1045 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1046 (syms_of_eval): Export backtrace-eval.
1047 * xterm.c (x_focus_changed): Simplify.
1048
9d611ffe
PE
10492013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1052
999c74e3
EZ
10532013-07-24 Eli Zaretskii <eliz@gnu.org>
1054
1055 * xdisp.c (redisplay_window): Instead of moving point out of
1056 scroll margin, reject the force_start method, and try scrolling
1057 instead. (Bug#14780)
1058
198fa217
KB
10592013-07-24 Ken Brown <kbrown@cornell.edu>
1060
1061 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1062 (Bug#14944).
1063
53840e55
PE
10642013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 * eval.c (Fprogn): Do not check that BODY is a proper list.
1067 This undoes the previous change. The check slows down the
1068 interpreter, and is not needed to prevent a crash. See
1069 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1070
60967f56
GM
10712013-07-23 Glenn Morris <rgm@gnu.org>
1072
1073 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1074
9ca960e2
PE
10752013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1076
a29c3e6d
PE
1077 Port to GNU/Linux systems with tinfo but not ncurses.
1078 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1079 to decide whether ncurses is being used. Without this change,
1080 GCC complains about tgetent not being declared, on a system
1081 that has tinfo installed but ncurses not installed.
1082
f274311c
PE
1083 * eval.c (Fprogn): Check that BODY is a proper list.
1084
16b0520a
PE
1085 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1086 * data.c (Fsetq_default):
1087 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1088 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1089 (Fcondition_case):
1090 Tune by taking advantage of the fact that ARGS is always a list
1091 when a function is declared to have UNEVALLED args.
1092
9ca960e2
PE
1093 * emacsgtkfixed.c: Port to GCC 4.6.
1094 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1095
afacaa1b
JB
10962013-07-23 Juanma Barranquero <lekktu@gmail.com>
1097
1098 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1099 here to silence compiler warnings.
1100
368a85a4
PE
11012013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1102
1103 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1104 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1105 from messing up Emacs's 'struct frame' (Bug#14923).
1106
f4e891b5
PE
11072013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 * alloc.c (make_save_ptr_ptr): Define this function.
1110 It was inadvertently omitted. It's needed only if
1111 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1112
96c8b65e
JD
11132013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1114
1115 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1116 frame have focus (Bug#14895).
1117
ee010797
PE
11182013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 Avoid vfork-related deadlock more cleanly.
1121 * callproc.c (child_setup): When the child's exec fails, output
1122 the program name, as that's more useful. Use O_NONBLOCK to avoid
1123 deadlock.
1124 * process.c (create_process_1): Remove; no longer needed.
1125 (create_process): Remove timer hack; no longer needed, now that
1126 the child avoids deadlock.
1127
f0398ec1 11282013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1129
1130 * image.c (Fimage_flush): Fix doc typo.
1131
b2a069c2
PE
11322013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1133
6496aec9
PE
1134 Fix array bounds violation when pty allocation fails.
1135 * process.c (PTY_NAME_SIZE): New constant.
1136 (pty_name): Remove static variable; it's now auto.
1137 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1138 Take pty_name as an arg rather than using a static variable.
1139 All callers changed.
1140 (create_process): Recover pty_flag from process, not from volatile local.
1141 (create_pty): Stay inside array even when pty allocation fails.
1142 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1143
b2a069c2
PE
1144 * lread.c (Fload): Avoid initialization only when lint checking.
1145 Mention that it's needed only for older GCCs.
1146
99107004
KH
11472013-07-20 Kenichi Handa <handa@gnu.org>
1148
1149 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1150 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1151
6b1b199d
AS
11522013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1153
1154 * lread.c (Fload): Avoid uninitialized warning.
1155
4195afc3
PE
11562013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1157
3f5bef16
PE
1158 Fix some minor file descriptor leaks and related glitches.
1159 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1160 (create_lock_file): Use write, not emacs_write.
1161 * image.c (slurp_file, png_load_body):
1162 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1163 (server_accept_connection):
1164 Don't leak an fd on memory allocation failure.
1165 * image.c (slurp_file): Add a cheap heuristic for growing files.
1166 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1167 as that's what the other routines do. Maybe input need not be
1168 blocked at all, but it's better to be consistent.
1169 Avoid undefined behavior when strlen is zero.
1170
4195afc3
PE
1171 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1172 (NSTATICS): Now a constant; doesn't need to be a macro.
1173
a1aeeffe
RS
11742013-07-19 Richard Stallman <rms@gnu.org>
1175
1176 * coding.c (decode_coding_utf_8): Add simple loop for fast
1177 processing of ASCII characters.
1178
63b34baa
PE
11792013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1182
621dd9ac
EZ
11832013-07-19 Eli Zaretskii <eliz@gnu.org>
1184
1185 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1186 unportable 'struct x_display_info'.
1187 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1188 is a portable type.
1189
1396ac86
PE
11902013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1191
ab9980cd
PE
1192 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1193 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1194 or fscanf fails.
1195 (system_process_attributes): Prefer plain char to unsigned char
1196 when either will do. Clean up properly if interrupted or if
1197 memory allocations fail. Don't assume sscanf succeeds. Remove
1198 no-longer-needed workaround to stop GCC from whining. Read
1199 command-line once, instead of multiple times. Check read status a
1200 bit more carefully.
1201
1396ac86
PE
1202 Fix obscure porting bug with varargs functions.
1203 The code assumed that int is treated like ptrdiff_t in a vararg
1204 function, which is not a portable assumption. There was a similar
1205 -- though these days less likely -- porting problem with various
1206 assumptions that pointers of different types all smell the same as
1207 far as vararg functions is conserved. To make this problem less
1208 likely in the future, redo the API to use varargs functions.
1209 * alloc.c (make_save_value): Remove this vararg function.
1210 All uses changed to ...
1211 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1212 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1213 New functions.
1214 (make_save_ptr): Rename from make_save_pointer, for consistency with
1215 the above. Define only on platforms that need it. All uses changed.
1216
4d19d194
PE
12172013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 * keyboard.c: Try to fix typos in previous change.
1220 (DISPLAY_LIST_INFO): New macro.
1221 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1222 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1223
945c5bb1
JB
12242013-07-18 Juanma Barranquero <lekktu@gmail.com>
1225
1226 * keyboard.c (kbd_buffer_get_event):
1227 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1228 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1229
f4b1eb36
PE
12302013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1231
5e679a2c
PE
1232 * filelock.c: Fix unlikely file descriptor leaks.
1233 (get_boot_time_1): Rework to avoid using emacs_open.
1234 This doesn't actually fix a leak, but is better anyway.
1235 (read_lock_data): Use read, not emacs_read.
1236
a8cd4836
PE
1237 * doc.c: Fix minor memory and file descriptor leaks.
1238 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1239 (get_doc_string, Fsnarf_documentation):
1240 Fix file descriptor leak on error.
1241
ef30e638
PE
1242 * term.c: Fix minor fdopen-related file descriptor leaks.
1243 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1244 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1245
f4b1eb36
PE
1246 * charset.c: Fix file descriptor leaks and errno issues.
1247 Include <errno.h>.
1248 (load_charset_map_from_file): Don't leak file descriptor on error.
1249 Use plain record_xmalloc since the allocation is larger than
1250 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1251 of entries.
1252 * eval.c (record_unwind_protect_nothing):
1253 * fileio.c (fclose_unwind):
1254 New functions.
1255 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1256 The replacement doesn't block input, but that no longer seems
1257 necessary.
1258
b648c163
PE
12592013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1260
a0931322
PE
1261 * lread.c: Fix file descriptor leaks and errno issues.
1262 (Fload): Close some races that leaked fds or streams when 'load'
1263 was interrupted.
1264 (Fload, openp): Report error number of last nontrivial failure to open.
1265 ENOENT counts as trivial.
1266 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1267 New functions.
1268 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1269 now that the function is always called with a nonnegative arg.
1270 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1271 All uses replaced with ...
1272 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1273
b648c163
PE
1274 A few more minor file errno-reporting bugs.
1275 * callproc.c (Fcall_process):
1276 * doc.c (Fsnarf_documentation):
1277 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1278 * process.c (set_socket_option):
1279 Don't let a constructor trash errno.
1280 * doc.c: Include <errno.h>.
1281
b1dc4084
JB
12822013-07-16 Juanma Barranquero <lekktu@gmail.com>
1283
1284 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1285
c43843aa
PE
12862013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1287
50a30cce
PE
1288 Fix w32 bug with call-process-region (Bug#14885).
1289 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1290 to Fcall_process when the input is empty. This simplifies the
1291 code a bit. It makes no difference on POSIXish platforms but
1292 apparently it fixes a bug on w32.
1293
44e18199 1294 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1295 * fileio.c (close_file_unwind): Don't close if FD is negative;
1296 this can happen when unwinding a zapped file descriptor.
1297 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1298 in case Emacs runs out of memory between the two unwind-protects.
1299 Don't trash errno when closing FD.
1300 Zap the FD in the specpdl when closing it, instead of deferring
1301 the removal of the unwind-protect; this fixes a bug where a child
1302 function unwinds the stack past us.
1303
27e498e6
PE
1304 New unwind-protect flavors to better type-check C callbacks.
1305 This also lessens the need to write wrappers for callbacks,
1306 and the need for make_save_pointer.
1307 * alloca.c (free_save_value):
1308 * atimer.c (run_all_atimers):
1309 Now extern.
1310 * alloc.c (safe_alloca_unwind):
1311 * atimer.c (unwind_stop_other_atimers):
1312 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1313 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1314 * minibuf.c (choose_minibuf_frame_1):
1315 * process.c (make_serial_process_unwind):
1316 * xdisp.h (pop_message_unwind):
1317 * xselect.c (queue_selection_requests_unwind):
1318 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1319 * alloca.c (record_xmalloc):
1320 Prefer record_unwind_protect_ptr to record_unwind_protect with
1321 make_save_pointer.
1322 * alloca.c (Fgarbage_collect):
1323 Prefer record_unwind_protect_void to passing a dummy.
1324 * buffer.c (restore_buffer):
1325 * window.c (restore_window_configuration):
1326 * xfns.c, w32fns.c (do_unwind_create_frame)
1327 New wrapper. All record-unwind uses of wrappee changed.
1328 * buffer.c (set_buffer_if_live):
1329 * callproc.c (call_process_cleanup, delete_temp_file):
1330 * coding.c (code_conversion_restore):
1331 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1332 * editfns.c (save_excursion_restore)
1333 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1334 (save_restriction_restore):
1335 * eval.c (restore_stack_limits, un_autoload):
1336 * fns.c (require_unwind):
1337 * keyboard.c (recursive_edit_unwind, tracking_off):
1338 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1339 * macros.c (pop_kbd_macro, restore_menu_items):
1340 * nsfns.m (unwind_create_frame):
1341 * print.c (print_unwind):
1342 * process.c (start_process_unwind):
1343 * search.c (unwind_set_match_data):
1344 * window.c (select_window_norecord, select_frame_norecord):
1345 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1346 (fast_set_selected_frame):
1347 * xfns.c, w32fns.c (unwind_create_tip_frame):
1348 Return void, not a dummy Lisp_Object. All uses changed.
1349 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1350 * callproc.c (call_process_kill):
1351 * fileio.c (restore_point_unwind, decide_coding_unwind)
1352 (build_annotations_unwind):
1353 * insdel.c (Fcombine_after_change_execute_1):
1354 * keyboard.c (read_char_help_form_unwind):
1355 * menu.c (unuse_menu_items):
1356 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1357 * sound.c (sound_cleanup):
1358 * xdisp.c (unwind_redisplay):
1359 * xfns.c (clean_up_dialog):
1360 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1361 Accept no args and return void, instead of accepting and returning
1362 a dummy Lisp_Object. All uses changed.
1363 * cygw32.c (fchdir_unwind):
1364 * fileio.c (close_file_unwind):
1365 * keyboard.c (restore_kboard_configuration):
1366 * lread.c (readevalllop_1):
1367 * process.c (wait_reading_process_output_unwind):
1368 Accept int and return void, rather than accepting an Emacs integer
1369 and returning a dummy object. In some cases this fixes an
1370 unlikely bug when the corresponding int is outside Emacs integer
1371 range. All uses changed.
1372 * dired.c (directory_files_internal_unwind):
1373 * fileio.c (do_auto_save_unwind):
1374 * gtkutil.c (pop_down_dialog):
1375 * insdel.c (reset_var_on_error):
1376 * lread.c (load_unwind):
1377 * xfns.c (clean_up_file_dialog):
1378 * xmenu.c, nsmenu.m (pop_down_menu):
1379 * xmenu.c (cleanup_widget_value_tree):
1380 * xselect.c (wait_for_property_change_unwind):
1381 Accept pointer and return void, rather than accepting an Emacs
1382 save value encapsulating the pointer and returning a dummy object.
1383 All uses changed.
1384 * editfns.c (Fformat): Update the saved pointer directly via
1385 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1386 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1387 (unwind_body): New function.
1388 (record_unwind_protect): First arg is now a function returning void,
1389 not a dummy Lisp_Object.
1390 (record_unwind_protect_ptr, record_unwind_protect_int)
1391 (record_unwind_protect_void): New functions.
1392 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1393 * fileio.c (struct auto_save_unwind): New type.
1394 (do_auto_save_unwind): Use it.
1395 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1396 * insdel.c (struct rvoe_arg): New type.
1397 (reset_var_on_error): Use it.
1398 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1399 New constants.
1400 (specbinding_func): Remove; there are now several such functions.
1401 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1402 (set_unwind_protect_ptr): New function.
1403 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1404
4e604a5d
PE
1405 Be simpler and more consistent about reporting I/O errors.
1406 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1407 Say "Read error" and "Write error", rather than "I/O error", or
1408 "IO error reading", or "IO error writing", when a read or write
1409 error occurs.
1410 * process.c (Fmake_network_process, wait_reading_process_output)
1411 (send_process, Fprocess_send_eof, wait_reading_process_output):
1412 Capitalize diagnostics consistently. Put "failed foo" at the
1413 start of the diagnostic, so that we don't capitalize the
1414 function name "foo". Consistently say "failed" for such
1415 diagnostics.
1416 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1417 All callers changed. This is so it can use report_file_error.
1418 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1419 diagnostics consistently as above.
1420
a9757f6a
PE
1421 * fileio.c (report_file_errno): Fix errno reporting bug.
1422 If the file name is neither null nor a pair, package it up as a
1423 singleton list. All callers changed, both to this function and to
1424 report_file_error. This fixes a bug where the memory allocator
1425 invoked by list1 set errno so that the immediately following
1426 report_file_error reported the wrong errno value.
1427
c43843aa
PE
1428 Fix minor problems found by --enable-gcc-warnings.
1429 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1430 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1431
18c26d81
JD
14322013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1433
1434 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1435 Set event->arg to Qt if switch-event shall be generated.
1436 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1437
1438 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1439
1440 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1441 FOCUS_OUT_EVENT.
1442
1443 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1444 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1445 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1446 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1447 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1448 and there is a focused frame.
1449 (head_table): Add focus-in and focus-out.
1450 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1451 bind to handle-focus-in/out.
1452
1453 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1454 (Fhandle_switch_frame): Call Fhandle_focus_in.
1455 (syms_of_frame): defsubr handle-focus-in/out.
1456
6c6f1994
PE
14572013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1458
c7ddc792
PE
1459 Fix porting bug to older POSIXish platforms (Bug#14862).
1460 * sysdep.c (emacs_pipe): New function, that implements
1461 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1462 This should port better to CentOS 5 and to Mac OS X 10.6.
1463 All calls to pipe2 changed.
1464
6c6f1994
PE
1465 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1466 This makes the code easier to read and the executable a bit smaller.
1467 Do not replace all calls to Fcons that happen to create lists,
1468 just calls that are intended to create lists. For example, when
1469 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1470 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1471 Similarly for list2 through list5.
1472 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1473 * bytecode.c (exec_byte_code):
1474 * callint.c (quotify_arg, Fcall_interactively):
1475 * callproc.c (Fcall_process, create_temp_file):
1476 * charset.c (load_charset_map_from_file)
1477 (Fdefine_charset_internal, init_charset):
1478 * coding.c (get_translation_table, detect_coding_system)
1479 (Fcheck_coding_systems_region)
1480 (Fset_terminal_coding_system_internal)
1481 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1482 * composite.c (update_compositions, Ffind_composition_internal):
1483 * dired.c (directory_files_internal, file_name_completion)
1484 (Fsystem_users):
1485 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1486 * doc.c (Fsnarf_documentation):
1487 * editfns.c (Fmessage_box):
1488 * emacs.c (main):
1489 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1490 (Feval, eval_sub, Ffuncall, apply_lambda):
1491 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1492 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1493 (Fset_file_times, Finsert_file_contents)
1494 (Fchoose_write_coding_system, Fwrite_region):
1495 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1496 * font.c (font_registry_charsets, font_parse_fcname)
1497 (font_prepare_cache, font_update_drivers, Flist_fonts):
1498 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1499 * frame.c (make_frame, Fmake_terminal_frame)
1500 (x_set_frame_parameters, x_report_frame_params)
1501 (x_default_parameter, Fx_parse_geometry):
1502 * ftfont.c (syms_of_ftfont):
1503 * image.c (gif_load):
1504 * keyboard.c (command_loop_1):
1505 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1506 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1507 (Fminor_mode_key_binding, accessible_keymaps_1)
1508 (Faccessible_keymaps, Fwhere_is_internal):
1509 * lread.c (read_emacs_mule_char):
1510 * menu.c (find_and_return_menu_selection):
1511 * minibuf.c (get_minibuffer):
1512 * nsfns.m (Fns_perform_service):
1513 * nsfont.m (ns_script_to_charset):
1514 * nsmenu.m (ns_popup_dialog):
1515 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1516 (Fx_own_selection_internal):
1517 * nsterm.m (append2):
1518 * print.c (Fredirect_debugging_output)
1519 (print_prune_string_charset):
1520 * process.c (Fdelete_process, Fprocess_contact)
1521 (Fformat_network_address, set_socket_option)
1522 (read_and_dispose_of_process_output, write_queue_push)
1523 (send_process, exec_sentinel):
1524 * sound.c (Fplay_sound_internal):
1525 * textprop.c (validate_plist, add_properties)
1526 (Fput_text_property, Fadd_face_text_property)
1527 (copy_text_properties, text_property_list, syms_of_textprop):
1528 * unexaix.c (report_error):
1529 * unexcoff.c (report_error):
1530 * unexsol.c (unexec):
1531 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1532 (Fformat_mode_line, syms_of_xdisp):
1533 * xfaces.c (set_font_frame_param)
1534 (Finternal_lisp_face_attribute_values)
1535 (Finternal_merge_in_global_face, syms_of_xfaces):
1536 * xfns.c (x_default_scroll_bar_color_parameter)
1537 (x_default_font_parameter, x_create_tip_frame):
1538 * xfont.c (xfont_supported_scripts):
1539 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1540 (menu_help_callback, xmenu_show):
1541 * xml.c (make_dom):
1542 * xterm.c (set_wm_state):
1543 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1544 and similarly for list2 through list5.
1545
bafe80ce
PE
15462013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 * callproc.c (Fcall_process_region): Fix minor race and tune.
1549 (create_temp_file): New function, with the temp-file-creation part
1550 of the old Fcall_process_region. Use Fcopy_sequence to create the
1551 temp file name, rather than alloca + build_string, for simplicity.
1552 Don't bother to block input around the temp file creation;
1553 shouldn't be needed. Simplify use of mktemp. Use
1554 record_unwind_protect immediately after creating the temp file;
1555 this closes an unlikely race where the temp file was not removed.
1556 Use memcpy rather than an open-coded loop.
1557 (Fcall_process_region): Use the new function. If the input is
1558 empty, redirect from /dev/null rather than from a newly created
1559 empty temp file; this avoids unnecessary file system traffic.
1560
4700b5a5
PE
15612013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1562
5c97beae
PE
1563 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1564 Simplify by making this case like the other two. This is a bit
1565 slower on obsolete hosts, but the extra complexity isn't worth it.
1566
4700b5a5
PE
1567 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1568 * process.c (create_process) [!DOS_NT]:
1569 Remove now-unnecessary calls to emacs_close.
1570
f9a74c4c
EZ
15712013-07-13 Eli Zaretskii <eliz@gnu.org>
1572
922ae7ee
EZ
1573 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1574 returning early. (Bug#14850)
1575
f9a74c4c
EZ
1576 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1577 and inhibit-iso-escape-detection attributes of 'undecided'.
1578 (Bug#14822)
1579
5e301d76
PE
15802013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1581
69e0e5ee
PE
1582 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1583 Reported by Herbert J. Skuhra in
1584 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1585
5e301d76
PE
1586 Don't lose top specpdl entry when memory is exhausted.
1587 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1588 specpdl overflow here, to simplify callers; all callers changed.
1589 Always reserve an unused entry at the stack top; this avoids
1590 losing the top entry's information when memory is exhausted.
1591
7e649856
PE
15922013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1593
a773ed9a
PE
1594 Clean up errno reporting and fix some errno-reporting bugs.
1595 * callproc.c (Fcall_process):
1596 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1597 * process.c (create_process, Fmake_network_process):
1598 * unexaix.c (report_error):
1599 * unexcoff.c (report_error):
1600 Be more careful about reporting the errno of failed operations.
1601 The code previously reported the wrong errno sometimes.
1602 Also, prefer report_file_errno to setting errno + report_file_error.
1603 (Fcall_process): Look at openp return value rather than at path,
1604 as that's a bit faster and clearer when there's a numeric predicate.
1605 * fileio.c (report_file_errno): New function, with most of the
1606 old contents of report_file_error.
1607 (report_file_error): Use it.
1608 (Ffile_exists_p, Ffile_accessible_directory_p):
1609 Set errno to 0 when it is junk.
1610 * fileio.c (Faccess_file):
1611 * image.c (x_create_bitmap_from_file):
1612 Use faccessat rather than opening the file, to avoid the hassle of
1613 having a file descriptor open.
1614 * lisp.h (report_file_errno): New decl.
1615 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1616
7e649856
PE
1617 Minor EBADF fixes.
1618 * process.c (create_process, wait_reading_process_output) [AIX]:
1619 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1620 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1621 a multithreaded environment anyway).
1622 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1623
f6774c1a
AS
16242013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1625
1626 * image.c (x_find_image_file): Don't close a remote file handle.
1627
bacba3c2
PE
16282013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1629
1630 Fix races with threads and file descriptors.
1631 * callproc.c (Fcall_process_region):
1632 * dired.c (open_directory):
1633 * emacs.c (main, Fdaemon_initialized):
1634 * image.c (x_find_image_file):
1635 * inotify.c (Finotify_rm_watch):
1636 * lread.c (Flocate_file_internal):
1637 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1638 * term.c (term_mouse_moveto, init_tty):
1639 * termcap.c (tgetent):
1640 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1641 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1642 * unexhp9k800.c, unexmacosx.c (unexec):
1643 * callproc.c (Fcall_process_region):
1644 Use emacs_close, not close.
1645 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1646 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1647 and posix_close function on current platforms (which all lack them).
1648 (emacs_close): Use it. This should fix the races on GNU/Linux and
1649 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1650 and it should avoid closing random victim file descriptors on
1651 other platforms.
1652
653d4f43
PE
16532013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1654
c8536ec4
PE
1655 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1656 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1657 Touch up doc a bit.
1658
9c203066
PE
1659 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1660 This is for .gdbinit xbacktrace.
1661
653d4f43
PE
1662 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1663 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1664 (emacs_set_tty): Now static.
1665 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1666 * term.c (tty_capable_p, tty_default_color_capabilities)
1667 (get_tty_terminal, term_mouse_movement)
1668 (handle_one_term_event, init_tty, maybe_fatal):
1669 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1670 (tgetent, scan_file, name_match, compare_contin):
1671 * terminal.c (get_terminal):
1672 Use bool for boolean.
1673 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1674 Prefer char to unsigned char if either will do.
1675 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1676 (tty_write_glyphs): Prefer int to unsigned.
1677 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1678 All callers changed.
1679 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1680
45b683a1
PE
16812013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1682
29abe551
PE
1683 Port to C89.
1684 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1685 (B__dummy__): New dummy symbol, to pacify C89.
1686 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1687 they can't grok varargs macros.
1688 * dispnew.c (add_window_display_history)
1689 (add_frame_display_history):
1690 * print.c (print_object):
1691 * xdisp.c (debug_method_add):
1692 Use %p printf format only for void pointers.
1693 * emacs.c (usage_message): New constant, replacing ...
1694 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1695 (main): Adjust to usage reorg.
1696 * fns.c (syms_of_fns):
1697 * profiler.c (syms_of_profiler):
1698 Don't use non-constant struct initializers.
1699 * gnutls.h (gnutls_initstage_t):
1700 * lisp.h (enum Lisp_Fwd_Type):
1701 * lread.c (lisp_file_lexically_bound_p):
1702 * xsettings.c (anonymous enum):
1703 Remove trailing comma.
1704 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1705 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1706 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1707 (DEFUN): Use it.
1708 * regex.c (const_re_char): New type, to pacify strict C89.
1709 All uses of 'const re_char' replaced to use it.
1710 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1711 with glibc when strict C89. This change is imported from gnulib.
1712 All uses changed.
1713 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1714 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1715 Omit GNU_LINUX implementation, since it requires long long.
1716 * xterm.c (x_draw_underwave):
1717 Do not assume the traditional order of struct's members.
1718 (x_term_init): Rewrite to avoid the need for non-constant structure
1719 initializers.
1720
45b683a1 1721 Syntax cleanup, mostly replacing macros with functions.
763a086d 1722 This removes the need for the syntax_temp hack.
45b683a1
PE
1723 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1724 * syntax.c (SYNTAX_INLINE): New macro.
1725 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1726 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1727 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1728 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1729 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1730 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1731 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1732 Now constants, not macros.
1733 (syntax_temp) [!__GNUC__]: Remove.
1734 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1735 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1736 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1737 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1738 Move here from syntax.h; now functions, not macros. Except for the
1739 last function, these are static since only syntax.c uses them.
1740 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1741 All uses changed. Now a function, not a macro; use this fact
1742 to simplify the code.
1743 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1744 compiler bugs; no longer relevant.
1745 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1746 (SYNTAX_INLINE): New macro.
1747 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1748 for the new functions. Use bool for boolean member.
1749 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1750 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1751 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1752 (SETUP_BUFFER_SYNTAX_TABLE):
1753 Now extern inline functions, not macros.
1754 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1755 Remove; all uses replaced by implementation.
1756 (syntax_temp) [!__GNUC__]: Remove decl.
1757 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1758
29be4a50
JD
17592013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1760
1761 * emacs.c (main): Fix syntax error.
1762
954b166e
PE
17632013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1764
1765 Timestamp fixes for undo (Bug#14824).
1766 * atimer.c (schedule_atimer):
1767 * fileio.c (Ffile_newer_than_file_p):
1768 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1769 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1770 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1771 (syms_of_fileio): Remove Sclear_visited_file_name.
1772 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1773 file doesn't exist; this avoids an ambiguity with negative timestamps.
1774 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1775 * systime.h (make_emacs_time, invalid_emacs_time):
1776 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1777 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1778 * undo.c (record_first_change): Push (visited-file-modtime) onto
1779 undo list rather than reimplementing it by hand, incorrectly.
1780
d74647c3
KB
17812013-07-09 Ken Brown <kbrown@cornell.edu>
1782
1783 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1784
3c51b96b
JB
17852013-07-09 Juanma Barranquero <lekktu@gmail.com>
1786
1787 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1788
4ebbdd67
PE
17892013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 Handle errno and exit status a bit more carefully.
1792 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1793 number into an exit status. Instead, use EXIT_CANCELED.
1794 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1795 * callproc.c (relocate_fd):
1796 * emacs.c (close_output_streams, main):
1797 * process.c (create_process):
1798 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1799 Use emacs_perror for simplicity.
1800 * callproc.c (relocate_fd, main):
1801 * sysdep.c (sys_subshell):
1802 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1803 (shut_down_emacs): Use emacs_write, not write.
1804 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1805 * fileio.c (Fcopy_file, e_write):
1806 * nsterm.m (ns_select):
1807 * process.c (send_process):
1808 * sound.c (vox_write):
1809 Use emacs_write_sig, not emacs_write.
1810 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1811 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1812 New constants.
1813 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1814 of write.
1815 (emacs_full_write): New function.
1816 (emacs_write): Rewrite to use it.
1817 (emacswrite_sig, emacs_perror): New functions.
1818 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1819
44e18199 18202013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1821
1822 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1823 on NS even if it is present. Pixmap on NS is a void*.
1824
9caab067
PE
18252013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1826
1827 Port to Ubuntu 10 (Bug#14803).
1828 Problem reported by T.V. Raman.
1829 * process.c (close_on_exec, accept4, process_socket):
1830 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1831
1d442672
EZ
18322013-07-07 Eli Zaretskii <eliz@gnu.org>
1833
1834 * w32.c (sys_dup): Declare prototype.
1835
1836 * filelock.c:
1837 * emacs.c:
1838 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1839
067428c1
PE
18402013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 Make file descriptors close-on-exec when possible (Bug#14803).
1843 This simplifies Emacs a bit, since it no longer needs to worry
1844 about closing file descriptors by hand in some cases.
1845 It also fixes some unlikely races. Not all such races, as
1846 libraries often open files internally without setting
1847 close-on-exec, but it's an improvement.
1848 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1849 * callproc.c (Fcall_process) [!MSDOS]:
1850 * emacs.c (main) [!DOS_NT]:
1851 * nsterm.m (ns_term_init):
1852 * process.c (create_process):
1853 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1854 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1855 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1856 Prefer mkostemp with O_CLOEXEC to mkstemp.
1857 * callproc.c (relocate_fd) [!WINDOWSNT]:
1858 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1859 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1860 now using pipe2.
1861 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1862 Make the resulting file descriptor close-on-exec.
1863 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1864 * lread.c (load_descriptor_list, load_descriptor_unwind):
1865 Remove; no longer needed. All uses removed.
1866 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1867 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1868 New functions.
1869 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1870 (Fmake_network_process, Fnetwork_interface_list):
1871 (Fnetwork_interface_info, server_accept_connection):
1872 Make newly-created socket close-on-exec.
1873 * sysdep.c (emacs_open, emacs_fopen):
1874 Make new-created descriptor close-on-exec.
1875 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1876 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1877
0da857dd
JD
18782013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1879
1880 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1881 for NS_IMPL_GNUSTEP.
1882
5f86adcd
PE
18832013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 Fix openp errno handling.
1886 * callproc.c (Fcall_process): Preserve openp errno around close.
1887 * lread.c (openp): Set errno when returning -1, as some callers
1888 expect this.
1889
1afb1d07
JD
18902013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1891
1892 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1893
1894 * nsterm.h (NSSavePanel): Update comment.
1895 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1896 (ns_run_file_dialog): Declare.
1897
1898 * nsfns.m: Remove panelOK.
1899 (ns_fd_data): New.
1900 (ns_run_file_dialog): New function.
1901 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1902 event loop, so file dialog is popped up by ns_run_file_dialog, called
1903 by sendEvent (Bug#14578).
1904 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1905
3323c263
EZ
19062013-07-06 Eli Zaretskii <eliz@gnu.org>
1907
fdda0220
EZ
1908 * xdisp.c (default_line_pixel_height): New function.
1909 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1910 (try_cursor_movement, redisplay_window, try_window)
1911 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1912
1913 * window.c (window_scroll_pixel_based): use
1914 default_line_pixel_height.
1915
1916 * dispextern.h (default_line_pixel_height): Add prototype.
1917
1918 * frame.c (x_set_line_spacing): Accept a float value for
1919 line-spacing parameter, per the documentation.
1920
3323c263
EZ
1921 * data.c (Fmultibyte_string_p): Doc fix.
1922
47ba6d43
PE
19232013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1924
406af475
PE
1925 Use emacs_open more consistently when opening files.
1926 This handles EINTR more consistently now, and makes it easier
1927 to introduce other uniform changes to file descriptor handling.
1928 * src/systdio.h: New file.
1929 * src/buffer.c (mmap_init):
1930 * cygw32.c (chdir_to_default_directory):
1931 * dispnew.c (Fopen_termscript):
1932 * emacs.c (Fdaemon_initialized):
1933 * fileio.c (Fdo_auto_save):
1934 * image.c (slurp_file, png_load_body, jpeg_load_body):
1935 * keyboard.c (Fopen_dribble_file):
1936 * lread.c (Fload):
1937 * print.c (Fredirect_debugging_output):
1938 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1939 * termcap.c (tgetent):
1940 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1941 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1942 * w32term.c (w32_initialize) [CYGWIN]:
1943 * xfaces.c (Fx_load_color_file):
1944 Use emacs_open instead of plain open, and emacs_fopen instead of
1945 plain fopen.
1946 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1947 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1948 * callproc.c (default_output_mode): New constant.
1949 (Fcall_process): Use it to call emacs_open instead of plain creat.
1950 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1951 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1952 (emacs_fopen): New function.
1953 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1954 Include <lisp.h>, for emacs_open.
1955 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1956
47ba6d43
PE
1957 Remove duplicate #include directives.
1958 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1959 * xfaces.c:
1960 Don't include stdio.h twice.
1961 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1962 Don't include sys/types.h or stdio.h twice.
1963 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1964 * lread.c: Don't include coding.h twice.
1965 * nsfont.m: Don't include frame.h twice.
1966 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1967 * ralloc.c: Don't include <unistd.h> twice.
1968 * xdisp.c: Don't include font.h twice.
1969 * xterm.c: Don't include fontset.h twice.
1970 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1971
b9ed53d5
PE
19722013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 Scale ImageMagick images more carefully.
1975 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1976 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1977 Be more careful about avoiding undefined behavior after
1978 integer overflow and division by zero.
1979
cf13177e
YM
19802013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1981
1982 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1983 (syms_of_w32fns): DEFSYM them.
1984 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1985 (CCHDEVICENAME): Define macros if not defined.
1986 (struct MONITOR_INFO_EX): New struct.
1987 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1988 (enum_display_monitors_fn): New variable.
1989 (globals_of_w32fns): Initialize it.
1990 (Fx_display_pixel_width, Fx_display_pixel_height)
1991 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1992 multi-monitor setups in docstrings.
1993 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1994 screen size by primary monitor's millimeter per pixel.
1995 (w32_monitor_enum, w32_display_monitor_attributes_list)
1996 (w32_display_monitor_attributes_list_fallback)
1997 (Fw32_display_monitor_attributes_list): New functions.
1998 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1999
2000 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2001 if not defined.
2002 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2003
86dfb7a8
MA
20042013-07-04 Michael Albinus <michael.albinus@gmx.de>
2005
2006 * fileio.c (Qfile_notify_error): New error symbol.
2007
2008 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2009 * inotify.c (inotify_callback, symbol_to_inotifymask)
2010 (Finotify_add_watch, Finotify_rm_watch): Use it.
2011 (inotifyevent_to_event): Exchange order of cookie and file name.
2012 (Finotify_add_watch): Adapt docstring.
2013
2014 * lisp.h (Qfile_notify_error): Declare.
2015
2c1c974b
PE
20162013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2019 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2020 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2021 which did not work (see <http://bugs.gnu.org/14569#307>).
2022 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2023 && (!noninteractive || initialized)). This attempts to thread
2024 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2025
7a35b20f
JB
20262013-07-04 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2029 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2030
1ce5cd04
PE
20312013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2034 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2035 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2036 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2037
57f8c490
PE
20382013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2041 Define to __sys_siglist.
2042
bcffb5ca
EZ
20432013-07-02 Eli Zaretskii <eliz@gnu.org>
2044
2045 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2046 word-wrap, so that overflow-newline-into-fringe would work in
2047 visual-line-mode. (Bug#2749)
2048 (move_it_in_display_line_to): When the last scanned display
2049 element fits exactly on the display line, and
2050 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2051 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2052 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2053 finding buffer position that corresponds to pixel coordinates,
2054 e.g. in buffer_posn_from_coords.
2055
2c41e781
JD
20562013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2057
2058 * process.c (handle_child_signal): Call catch_child_signal if
2059 NS_IMPL_GNUSTEP.
2060
c2418359
PE
20612013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2062
52a9bcae
PE
2063 Don't convert function pointers to void * and back.
2064 It isn't portable C, and it's easy enough to avoid.
2065 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2066 (make_save_value): Add support for SAVE_FUNCPOINTER.
2067 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2068 * print.c (print_object):
2069 Distinguish function from object pointers.
2070 * lisp.h (SAVE_FUNCPOINTER): New constant.
2071 (SAVE_SLOT_BITS): Adjust to it.
2072 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2073 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2074 (voidfuncptr): New typedef.
2075 (struct Lisp_Save_Value): New member data[0].funcpointer.
2076 (XSAVE_FUNCPOINTER): New function.
2077
c2418359
PE
2078 Simplify buildobj processing.
2079 * Makefile.in (buildobj.h): Make it a sequence of strings each
2080 followed by comma, rather than a single string. Put it into a
2081 .tmp file in case there's an error while generating it.
2082 (gl-stamp): Use .tmp for temp files.
2083 (mostlyclean): Clean .tmp files.
2084 * doc.c (buildobj): Move to just the routine that needs it.
2085 It's now an array of strings, so processing is simpler.
2086
8f43ce49
PE
20872013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2088
2089 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2090 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2091 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2092 Invoke malloc_enable_thread even when not interactive.
2093 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2094 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2095 in this case, since the underlying bug has now been fixed.
2096
24827db9
JB
20972013-07-01 Juanma Barranquero <lekktu@gmail.com>
2098
2099 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2100 unlinking it (bug#14691).
2101
ef099a94
MN
21022013-06-30 Michal Nazarewicz <mina86@mina86.com>
2103
2104 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2105 before checking whether buffer is modified. This lets
2106 `kill-buffer-query-functions' cancel killing of the buffer or save
2107 its content before `kill-buffer' asks user the "Buffer %s
2108 modified; kill anyway?" question.
2109
9d3f2fc2
JD
21102013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2111
2112 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2113 Let the super performKeyEquivalent deal with them (Bug#14747).
2114
e6c6c8c7
PE
21152013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2116
1d71c1d9
PE
2117 * widget.c (resize_cb): Remove unused local.
2118
8f5f35cc
PE
2119 Do not use GTK 3 if it exists but cannot be compiled.
2120 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2121 * xterm.c (x_error_handler) [!USE_GTK]:
2122 Do not use GTK 3.
2123
e6c6c8c7
PE
2124 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2125
0ba54312
EZ
21262013-06-30 Eli Zaretskii <eliz@gnu.org>
2127
5d1c3286
EZ
2128 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2129 to the valid range of values. (Bug#14753)
2130
0ba54312
EZ
2131 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2132 when moving point by using the current glyph matrix. This avoids
2133 the need to force redisplay when this function is called in a
2134 loop.
2135
9c90cc06
PE
21362013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 Fix minor problems found by static checking.
2139 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2140 Redo the latter's body to sidestep GCC parenthesization warnings.
2141 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2142 * coding.c (detect_coding, detect_coding_system):
2143 * coding.h (struct undecided_spec):
2144 Use bool for boolean.
2145 * image.c (QCmax_width, QCmax_height): Now static.
2146 * xdisp.c (Fmove_point_visually): Remove unused local.
2147
4c672a0f
EZ
21482013-06-29 Eli Zaretskii <eliz@gnu.org>
2149
2150 * xdisp.c (Fmove_point_visually): New function.
2151
c1ea3abf
JB
21522013-06-28 Kenichi Handa <handa@gnu.org>
2153
2154 * coding.h (define_coding_undecided_arg_index): New enum.
2155 (coding_attr_index): New members
2156 coding_attr_undecided_inhibit_null_byte_detection,
2157 coding_attr_undecided_inhibit_iso_escape_detection,
2158 coding_attr_undecided_prefer_utf_8.
2159 (undecided_spec): New struct.
2160 (struct coding_system): New member `undecided' of the member
2161 `spec'.
2162
2163 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2164 (detect_coding): Likewise.
2165 (detect_coding_system): Likewise.
2166 (Fdefine_coding_system_internal): New coding system properties
2167 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2168 :prefer-utf-8.
2169 (syms_of_coding): Adjust for coding_arg_undecided_max.
2170
ba3de9e6
PE
21712013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2172
2173 * image.c (x_from_xcolors): Remove unused local.
2174
547c9269
YM
21752013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2176
2177 Defer image data transfer between X client and server until actual
2178 display happens.
2179
2180 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2181 and `mask_img'.
2182
2183 * image.c (Destroy_Image): Remove.
2184 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2185 `mask_p', and `colors_p'. All uses changed.
2186 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2187 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2188 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2189 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2190 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2191 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2192 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2193 (image_get_x_image, image_unget_x_image): New functions or macros.
2194 (image_background, image_background_transparent, x_to_xcolors)
2195 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2196 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2197 instead of Destroy_Image.
2198 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2199 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2200 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2201 (imagemagick_load_image, svg_load_image): Use them instead of
2202 x_create_x_image_and_pixmap, and x_put_x_image followed by
2203 x_destroy_x_image, respectively.
2204 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2205 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2206 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2207 background_transparent fields.
2208 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2209 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2210
dae2f5ef
PE
22112013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2214 This mostly consists of undoing recent changes.
2215 * callproc.c (Fcall_process):
2216 * process.c (create_process):
2217 Do not worry about catching SIGCHLD here, undoing previous change.
2218 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2219 * process.c, process.h (catch_child_signal):
2220 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2221 * process.c (catch_child_handler): Don't worry about being called
2222 lazily and do not assume caller has blocked SIGCHLD, undoing
2223 previous change. Move first-time stuff back to
2224 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2225 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2226 set lib_child_handler if it's already initialized, which may
2227 help avoid problems on GNUStep.
2228
fa55d2aa
PE
22292013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2232 * callproc.c (Fcall_process):
2233 * process.c (create_process):
2234 Make sure SIGCHLD is caught before we fork,
2235 since Emacs startup no arranges to catch SIGCHLD.
2236 * process.c (lib_child_handler): Initialize to null, not to
2237 dummy_handler.
2238 (catch_child_signal): Allow self to be called lazily.
2239 Do nothing if it's already been called.
2240 Assume caller has blocked SIGCHLD (all callers do now).
2241 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2242 just before it's really needed.
2243 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2244 since it hasn't been caught yet.
2245
f3f9606c
LMI
22462013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2247
2248 * image.c (compute_image_size): New function to implement
2249 :max-width and :max-height.
2250 (imagemagick_load_image): Use it.
2251
c7041908
PE
22522013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2253
2254 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2255 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2256 Now extern.
2257 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2258 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2259 the SIGCHLD handler, since the code is not atomic and (due to glib)
2260 signals may be arriving now.
2261 * sysdep.c (init_signals): Do not catch child signals here;
2262 'main' now does that later, at a safer time.
2263
f86852b4
PE
22642013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2265
0dfeed58
PE
2266 Clean up SIGCHLD handling a bit (Bug#14569).
2267 * process.c, process.h (catch_child_signal):
2268 Now always extern, even if !NS_IMPL_GNUSTEP.
2269 * process.c (catch_child_signal): Move glib tickler here from
2270 init_process_emacs, so that it's done earlier in Emacs
2271 initialization. Also move the noninteractive && !initialized
2272 check here from init_process_emacs. This is all a bit cleaner for
2273 GNUish platforms, and I hope it works around the Cygwin bug.
2274 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2275 that glib signal handling is tickled before glib creates threads.
2276
f86852b4
PE
2277 * process.c (wait_reading_process_output): Avoid int overflow
2278 when reading more than 2 GiB total from a process.
2279
cbd6509c
PE
22802013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2281
2282 * process.c (create_process): Handle a couple more cases,
2283 i.e., work even if new_argv and wait_child_setup[i] are cached.
2284 Use Fcall_process's style for volatile vars.
2285
9de1114a
AS
22862013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2287
2288 * process.c (create_process): Mark PROCESS volatile.
2289
fbe9e0b9
PE
22902013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2291
2292 Use C99-style flexible array members if available.
2293 This avoids some subtle aliasing issues, which typically
2294 aren't a problem with GCC but may be a problem elsewhere.
2295 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2296 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2297 In either case, it uses a flexible array member rather than
2298 the old struct hack. All uses changed.
2299 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2300 Adjust to sdata reorganization.
2301 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2302 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2303 that ports better to pre-C99 non-GCC.
2304 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2305 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2306 as the latter has changed.
2307 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2308 and port better to pre-C99 GCC.
2309 * image.c (struct xpm_cached_color):
2310 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2311 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2312 Use FLEXIBLE_ARRAY_MEMBER.
2313 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2314 Move decl to top level so it gets checked against implementation.
2315 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2316 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2317
1fc71008
PE
23182013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 * syntax.c: Integer cleanups.
2321 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2322 All uses that need 0-or-2 changed to:
2323 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2324 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2325 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2326 (char_quoted, prev_char_comend_first, back_comment)
2327 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2328 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2329 Use bool for boolean.
2330 (update_syntax_table, skip_chars, skip_syntaxes):
2331 Prefer int to unsigned when either will do.
2332 (back_comment): Return boolean success flag, like forw_comment,
2333 instead of positive-or-minus-1 (which might have overflowed int anyway).
2334 Don't stuff ptrdiff_t into int.
2335 (syntax_spec_code, syntax_code_spec): Now const.
2336 (Fmatching_paren, scan_lists, scan_sexps_forward):
2337 Use enum syntaxcode for syntax code.
2338 (Fmatching_paren): Check that arg is a character, not just an integer.
2339 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2340 (Finternal_describe_syntax_value): Omit no-longer-needed
2341 comparison to 0.
2342 (skip_chars): Use char, not unsigned char, when the distinction
2343 doesn't matter.
2344 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2345 * bytecode.c (exec_byte_code):
2346 * syntax.c (syntax_spec_code, Fchar_syntax)
2347 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2348 (init_syntax_once):
2349 * syntax.h (SYNTAX_WITH_FLAGS):
2350 Omit unnecessary casts.
2351
b932cad7
EZ
23522013-06-20 Eli Zaretskii <eliz@gnu.org>
2353
2354 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2355 line dimensions here, to avoid race conditions with the main
2356 thread. (Bug#14062, bug#14630, bug#14669)
2357
2358 * w32term.c (w32_draw_window_cursor): Compute the header line and
2359 mode line dimensions here.
2360 <w32_system_caret_window, w32_system_caret_hdr_height>:
2361 <w32_system_caret_mode_height>: New variables.
2362
2363 * w32term.h: Declare them.
2364
89561f72
PE
23652013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2366
5013fc08
PE
2367 * alloc.c (die): Move "assertion failed" string here ...
2368 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2369 COND when SUPPRESS_CHECKING. This shrinks the executable text
2370 size by 0.8% to 2.2% when configured with --enable-checking,
2371 depending on optimization flags (GCC 4.8.1 x86-64).
2372
89561f72
PE
2373 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2374
763a086d 23752013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2376
2377 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2378 base is 2; this is more accurate.
2379
983aeb9a
JB
23802013-06-19 Juanma Barranquero <lekktu@gmail.com>
2381
2382 * sound.c (string_default): Move to !WINDOWSNT section.
2383 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2384
178ba3e6
PE
23852013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2386
bbc51b15
PE
2387 * sound.c: Integer cleanups.
2388 Remove unnecessary forward decls.
2389 (struct sound_device): The 'file' member is now a Lisp_Object, not
2390 a char *, so that we needn't invoke alloca on a huge size.
2391 (Fplay_sound_internal): Adjust to this.
2392 (string_default): New function.
2393 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2394 Use it to adjust to the struct sound_device change.
2395 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2396 (be2hs) [0]: Remove.
2397
178ba3e6
PE
2398 * syntax.c (skip_chars): Don't use uninitialized storage
2399 when searching a multibyte buffer for characters that are not in a
2400 unibyte string that contains non-ASCII characters.
2401
69f60cdc
JD
24022013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2403
2404 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2405 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2406
0d6224d4
PE
24072013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2408
2409 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2410
3c542890
KH
24112013-06-18 Kenichi Handa <handa@gnu.org>
2412
f7e3f7cd
KH
2413 * font.c (Ffont_spec): Signal an error for an invalid font name
2414 (Bug#14648).
3c542890 2415
9349e5f7
PE
24162013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2417
2418 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2419 In particular this ports to 32-bit sparc Sun cc.
2420 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2421 array with a dummy element at specpdl[-1], so that its address can
2422 be taken portably.
2423 (unbind_to): Do not copy the binding; not needed, now that we
2424 copy old_value in the one place where the copy is needed.
2425 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2426 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2427 (union specbinding): Rename from struct specbinding. Redo layout
2428 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2429 which is not portable. With Sun C 5.12 32-bit sparc, the
2430 declaration causes nargs to be an unsigned bitfield, a behavior
2431 that the C standard allows; but Emacs wants nargs to be signed.
2432 The overall type is now a union of structures rather than a
2433 structure of union of structures, and the 'kind' member is now a
2434 bitfield, so that the overall type doesn't grow. All uses changed.
2435 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2436
0a4df6a5
PE
24372013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2438
ec6ecaad
PE
2439 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2440 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2441
0a4df6a5
PE
2442 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2443
7bfe8dbc
EZ
24442013-06-17 Eli Zaretskii <eliz@gnu.org>
2445
2446 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2447 unless we know that the window w's frame is a frame object.
2448 Another attempt at solving bug#14062 and bug#14630.
2449
708e05f6
LMI
24502013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2451
2452 * textprop.c (property_set_type): New enum.
2453 (add_properties): Allow appending/prepending text properties.
2454 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2455 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2456 add_text_properties_1.
2457 (Fadd_face_text_property): New function that calls
2458 add_text_properties_1.
2459
84575e67
PE
24602013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 Move functions from lisp.h to individual modules when possible.
2463 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2464 * alloc.c (XFLOAT_INIT, set_symbol_name):
2465 * buffer.c (CHECK_OVERLAY):
2466 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2467 (set_char_table_parent):
2468 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2469 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2470 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2471 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2472 (set_blv_valcell):
2473 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2474 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2475 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2476 (backtrace_args, backtrace_debug_on_exit):
2477 * floatfns.c (CHECK_FLOAT):
2478 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2479 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2480 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2481 (set_hash_index_slot):
2482 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2483 * marker.c (CHECK_MARKER):
2484 * textprop.c (CHECK_STRING_OR_BUFFER):
2485 * window.c (CHECK_WINDOW_CONFIGURATION):
2486 Move here from lisp.h, and make these functions static rather than
2487 extern inline.
2488 * buffer.c (Qoverlayp):
2489 * data.c (Qsubrp):
2490 * fns.c (Qhash_table_p):
2491 * window.c (Qwindow_configuration_p):
2492 Now static.
2493 * lisp.h: Remove the abovementioned defns and decls.
2494
44e18199 2495 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2496 In lisp.h, prefer functions to function-like macros, and
2497 constants to object-like macros, when either will do. This:
2498 . simplifies use, as there's no more need to worry about
2499 arguments' side effects being evaluated multiple times.
2500 . makes the code easier to debug on some platforms.
2501 However, when using gcc -O0, keep using function-like macros
2502 for a few critical operations, for performance reasons.
2503 This sort of thing isn't needed with gcc -Og, but -Og
2504 is a GCC 4.8 feature and isn't widely-enough available yet.
2505 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2506 Remove enum lsb_bits; no longer needed.
2507 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2508 * buffer.c (Qoverlap):
2509 * data.c (Qsubrp):
2510 * fns.c (Qhash_table_p):
2511 Now extern, so lisp.h can use these symbols.
2512 * dispextern.h: Include character.h, for MAX_CHAR etc.
2513 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2514 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2515 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2516 (GLYPH_CODE_P): Move here from lisp.h.
2517 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2518 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2519 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2520 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2521 XUNTAG now returns void *.
2522 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2523 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2524 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2525 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2526 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2527 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2528 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2529 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2530 New macros, renamed from their sans-lisp_h_ counterparts.
2531 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2532 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2533 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2534 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2535 If compiling via GCC without optimization, define these as macros
2536 in addition to inline functions.
2537 To disable this, compile with -DINLINING=0.
2538 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2539 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2540 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2541 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2542 (INTMASK, VALMASK): Now macros, since static values cannot be
2543 accessed from extern inline functions.
2544 (VALMASK): Also a constant, for benefit of old GDB.
2545 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2546 is INTEGERP, which can fold it in.
5165d44a 2547 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2548 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2549 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2550 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2551 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2552 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2553 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2554 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2555 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2556 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2557 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2558 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2559 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2560 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2561 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2562 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2563 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2564 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2565 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2566 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2567 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2568 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2569 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2570 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2571 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2572 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2573 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2574 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2575 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2576 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2577 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2578 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2579 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2580 Now functions.
2581 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2582 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2583 (VALMASK): Define in one place rather than in two, merging the
2584 USE_LSB_TAG parts; this is simpler.
2585 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2586 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2587 Move up, to avoid use before definition.
2588 Also include "globals.h" earlier, for the same reason.
2589 (make_natnum): New function.
2590 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2591 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2592 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2593 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2594 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2595 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2596 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2597 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2598 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2599 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2600 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2601 (Qwindow_configuration_p, Qimage): New forward declarations.
2602 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2603 (STRING_COPYIN): Remove; unused.
2604 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2605 (xcar_addr, xcdr_addr): New functions. All uses changed.
2606 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2607 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2608 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2609 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2610 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2611 (TYPE_RANGED_INTEGERP): Simplify.
2612 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2613 (setlocale, fixup_locale, synchronize_system_messages_locale)
2614 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2615 Now empty functions, not macros.
2616 (functionp): Return bool, not int.
2617 * window.c (Qwindow_configuration_p): Now extern,
2618 so window.h can use it.
2619 * window.h (Qwindowp): Move decl back to lisp.h.
2620
9583ec36
EZ
26212013-06-15 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (Fline_pixel_height): New function, required for solving
2624 bug #14567.
2625
210272ce
PE
26262013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2629
de0503df
SM
26302013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2631
2632 * lread.c (syms_of_lread):
2633 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2634
afbfe143
KD
26352013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2636
2637 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2638
d177e213
XF
26392013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2640
2641 * fileio.c (expand_file_name): Doc fix.
2642
05e3e412
PE
26432013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2644
f7394b12
PE
2645 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2646 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2647 Wait for self, not for 0. This can't hurt on GNU or similar
2648 system, and may help with Cygwin.
2649
05e3e412
PE
2650 * keyboard.c: Don't use PROP (...) as an lvalue.
2651 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2652 Use set_prop (A, B), not PROP (A) = B.
2653
17dd3097
EZ
26542013-06-10 Eli Zaretskii <eliz@gnu.org>
2655
2656 * xdisp.c (get_it_property): Use it->window instead of generating
2657 a Lisp object from it->w.
2658
52fab9c9
EZ
26592013-06-09 Eli Zaretskii <eliz@gnu.org>
2660
2661 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2662 get-char-property the window that is being rendered, instead of
2663 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2664 (compute_display_string_pos): When W is NULL, use the current
2665 buffer as the object to pass to get-char-property.
2666 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2667 pointer member of the bidi iterator, since no window is pertinent
2668 to this function.
52fab9c9 2669
5bf97bfc
EZ
26702013-06-08 Eli Zaretskii <eliz@gnu.org>
2671
2672 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2673 being displayed, and pass it to compute_display_string_pos.
2674 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2675 (bidi_paragraph_init): All callers changed.
2676
2677 * xdisp.c (init_from_display_pos, init_iterator)
2678 (handle_single_display_spec, next_overlay_string)
2679 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2680 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2681 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2682 (compute_display_string_pos): Accept additional argument, the
2683 window being displayed, and pass it to Fget_char_property.
2684 (Bug#14575)
2685
2686 * dispextern.h (struct bidi_it): New member w, the window being
2687 displayed.
2688 (compute_display_string_pos): Adjust prototype.
2689
5de0e011
JD
26902013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2691
e7b41c4c 2692 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2693
2694 * process.c (wait_reading_process_output): Check for NS before GLIB.
2695 GLIB may be linked in due to rsvg, but ns_select must be called.
2696
5de0e011
JD
2697 * xgselect.c (xg_select): Remove call to window_system_available
2698 and g_main_context_pending at the top, so Gdk events (i.e. file
2699 notify) are processed when Emacs is started with -nw.
2700
a822acff
EZ
27012013-06-07 Eli Zaretskii <eliz@gnu.org>
2702
2703 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2704 (ctagsfiles3): New variable, includes only *.m files.
2705 (TAGS): Use an explicit language name in the regular expressions,
2706 to avoid transformation of '/SOMETHING' by MSYS to
2707 'c:\MSYS\SOMETHING'.
2708
6c0a9ed1
RC
27092013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2710
2711 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2712
9ef6111b
EZ
27132013-06-06 Eli Zaretskii <eliz@gnu.org>
2714
2715 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2716 still need to set the mouse pointer shape and activate help-echo.
2717 (Bug#14558)
2718
7d300d64
PE
27192013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 A few porting etc. fixes for the new file monitor code.
2722 See the thread containing
2723 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2724 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2725 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2726 (dir_monitor_callback, Fgfile_rm_watch):
2727 Use assq_no_quit instead of Fassoc, for speed.
2728 (dir_monitor_callback, Fgfile_rm_watch):
2729 eassert that the monitor is a fixnum.
2730 (dir_monitor_callback): No need for CDR_SAFE.
2731 Simplify building of lisp with alternative tails.
2732 (Fgfile_add_watch, Fgfile_rm_watch):
2733 Do not assume glib functions set errno reliably on failure.
2734 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2735 and signal an error otherwise.
2736 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2737 Use Fdelq instead of Fdelete, for speed.
2738
817ebfcf
EZ
27392013-06-05 Eli Zaretskii <eliz@gnu.org>
2740
2741 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2742 don't insist on being invoked on a highlighted tool-bar button.
2743 Avoids losing tool-bar functionality when mouse-highlight is nil.
2744 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2745 Don't highlight when mouse-highlight is nil.
2746 (note_mouse_highlight): When mouse-highlight is nil, don't return
2747 right away; instead, run tool-bar and mode-line highlight
2748 subroutine, clear any existing highlight, and revert the mouse
2749 pointer to its default shape. (Bug#14558)
2750
55577e7c
SM
27512013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2752
2753 * lisp.mk (lisp): Add prog-mode.el.
2754
f019a684
PE
27552013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2758 * process.c (dummy_handler): New function.
2759 (lib_child_handler): New static var.
2760 (handle_child_signal): Invoke it.
2761 (catch_child_signal): If a library has set up a signal handler,
2762 save it into lib_child_handler.
2763 (init_process_emacs): If using glib and not on Windows, tickle glib's
2764 child-handling code so that it initializes its private SIGCHLD handler.
2765 * syssignal.h (SA_SIGINFO): Default to 0.
2766 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2767 31; it should no longer be needed now.
2768
90db8702
MA
27692013-06-05 Michael Albinus <michael.albinus@gmx.de>
2770
2771 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2772
2773 * gfilenotify.c (globals_of_gfilenotify): New function.
2774 (syms_of_gfilenotify): Move global initialization there.
2775
2776 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2777
bfa3acd6
SM
27782013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2779
2780 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2781 * keyboard.c (menu_bar_items, tool_bar_items):
2782 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2783 not override local keymaps any more.
2784
ba59bd80
EZ
27852013-06-04 Eli Zaretskii <eliz@gnu.org>
2786
2787 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2788
7f203aa1
EZ
27892013-06-03 Eli Zaretskii <eliz@gnu.org>
2790
9337e206
EZ
2791 * w32console.c (initialize_w32_display): Return the dimensions of
2792 the console window via 2 additional arguments, not via the current
2793 frame. This avoids crashes due to overrunning the bounds of
2794 frame's decode_mode_spec_buffer, which is not resized following
2795 the change of the frame dimensions from the initial 10x10.
2796
2797 * w32term.h (w32_initialize_display_info): Adjust prototype.
2798
2799 * term.c (init_tty): Take dimensions of the frame from the values
2800 returned by initialize_w32_display.
2801
7f203aa1
EZ
2802 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2803 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2804 (LIBES): Add $(GFILENOTIFY_LIBS).
2805
2806 * w32inevt.c (handle_file_notifications): Add dummy implementation
2807 for !HAVE_W32NOTIFY.
2808
2809 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2810
55a87246
JD
28112013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2812
2813 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2814
2815 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2816
2817 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2818
3d5ee10a
PE
28192013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2820
2821 Fix minor problems found by static checking.
2822 * data.c (pure_write_error):
2823 Use xsignal2, not Fsignal, as Fsignal might return.
2824 * eval.c (set_backtrace_debug_on_exit): Now static.
2825 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2826 No longer inline. EXTERN_INLINE is needed only for functions
2827 defined in .h files. Reindent function header as per GNU style.
2828 (backtrace_p, backtrace_top, backtrace_next):
2829 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2830 compiler or linker. Add extern decls to pacify gcc -Wall.
2831 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2832 Now static.
2833 * frame.c (free_monitors): Define only on platforms that need it.
2834 * nsterm.m (ns_term_init):
2835 * process.c (catch_child_signal):
2836 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2837 defined on all porting targets these days.
2838 * process.c, process.h (catch_child_signal):
2839 Make it extern only if NS_IMPL_GNUSTEP is defined.
2840
e2d8a6f0
EZ
28412013-06-03 Eli Zaretskii <eliz@gnu.org>
2842
2843 * w32.c (gettimeofday): Make the signature identical to prototype
2844 in nt/inc/sys/time.h.
2845
a8a7c5f6
SM
28462013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2847
2848 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2849 .gdbinit.
2850
2851 * keyboard.c (safe_run_hooks_error): Improve error message.
2852
2853 * data.c (pure_write_error): Add `object' argument.
2854 * puresize.h (CHECK_IMPURE): Use it.
2855
c9628c79
MA
28562013-06-03 Michael Albinus <michael.albinus@gmx.de>
2857
2858 * Makefile.in (NOTIFY_OBJ): New variable.
2859 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2860
2861 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2862 Call syms_of_gfilenotify.
2863
2864 * gfilenotify.c: New file.
2865
2866 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2867 and Qfile_w32notify.
2868 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2869 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2870
2871 * lisp.h: Declare syms_of_gfilenotify.
2872
2873 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2874
2f592f95
SM
28752013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2876
2877 Merge the specpdl and backtrace stacks. Make the structure of the
2878 specpdl entries more obvious via a tagged union of structs.
2879 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2880 (enum specbind_tag): New enum.
2881 (struct specbinding): Make it a tagged union of structs.
2882 Add a case for backtrace records.
2883 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2884 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2885 (backtrace_debug_on_exit): New accessors.
2886 (struct backtrace): Remove.
2887 (struct catchtag): Remove backlist field.
2888 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2889 Move to eval.c.
2890 (Flocal_variable_p): Speed up the common case where the binding is
2891 already loaded.
2892 * eval.c (backtrace_list): Remove.
2893 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2894 (set_backtrace_args, set_backtrace_nargs)
2895 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2896 (backtrace_next): New functions.
2897 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2898 (unwind_to_catch, internal_lisp_condition_case)
2899 (internal_condition_case, internal_condition_case_1)
2900 (internal_condition_case_2, internal_condition_case_n): Don't bother
2901 with backtrace_list any more.
2902 (Fsignal): Adjust to new backtrace format.
2903 (grow_specpdl): Move up.
2904 (record_in_backtrace): New function.
2905 (eval_sub, Ffuncall): Use it.
2906 (apply_lambda): Adjust to new backtrace format.
2907 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2908 data.c.
2909 (specbind): Adjust to new specpdl format. Simplify.
2910 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2911 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2912 backtrace format.
2913 (mark_backtrace): Remove.
2914 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2915 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2916 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2917 Use mark_specpdl.
2918 * profiler.c (record_backtrace): Use get_backtrace.
2919 (handle_profiler_signal): Use backtrace_top_function.
2920 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2921 accessor functions.
2922
c0342369
JD
29232013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2924
2925 * process.h (catch_child_signal): Declare.
2926
2927 * process.c (catch_child_signal): New function.
2928 (init_process_emacs): Call it.
2929
2930 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2931 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2932 NS_IMPL_COCOA.
2933 (x_set_cursor_type): Remove declaration.
2934 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2935 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2936 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2937 (ns_get_color): Use F suffix on float.
2938 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2939 (ns_get_rgb_color): Remove.
2940 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2941 (note_mouse_movement): x and y are CGFloat.
2942 (ns_draw_fringe_bitmap): Remove unused rowY.
2943 Change #if to COCOA && >= 10_6.
2944 (ns_draw_window_cursor): Remove unused overspill.
2945 (ns_draw_underwave): width and x are EamcsCGFloat.
2946 (ns_draw_box): thickness is CGFloat.
2947 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2948 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2949 if not in main thread.
2950 (ns_get_pending_menu_title, ns_check_menu_open)
2951 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2952 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2953 (sendFromMainThread:): New method.
2954 (changeFont:): size is CGFloat.
2955 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2956 Disable warning about permanent text.
2957 (characterIndexForPoint:): Adjust return type depending on GNUStep
2958 version.
2959 (mouseDown:): delta is CGFloat.
2960 (updateFrameSize): Remove unised variable f.
2961 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2962 Cast float to EmacsCGFloat.
2963 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2964 also to -1 when restoring.
2965 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2966 inside NS_IMPL_COCOA.
2967 (toggleFullScreen:): Put call to toggleFullScreen inside
2968 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2969 (setPosition:portion:whole:): por is CGFloat.
2970 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2971 (mouseDown:): Use CGFloat.
2972 (mouseDragged:): Remove unised variable edge.
2973 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2974
2975 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2976 of CGFloat differs.
2977 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2978 when NS_IMPL_GNUSTEP.
2979 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2980 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2981 (EmacsToolbar): Add clearAll. Add tag argument to
2982 addDisplayItemWithImage.
2983 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2984
2985 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2986
2987 * nsmenu.m (ns_update_menubar): Make static.
2988 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2989 (fillWithWidgetValue:): Add cast to SEL for setAction.
2990 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2991 (update_frame_tool_bar): Update code for GNUStep.
2992 (clearAll): New method.
2993 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2994 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2995 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2996 call to insertItemWithItemIdentifier.
2997 (validateVisibleItems): Fix indentation.
2998 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2999 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3000 UtilityWindow to aStyle, remove call to setStyleMask.
3001
3002 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3003
3004 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3005 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3006 Use F suffix on floats.
3007 (ns_char_width): Returns CGFloat.
3008 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3009 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3010 DPSxshow.
3011 (ns_glyph_metrics): CGFloat instead of float.
3012
a0eb10b3
JB
3013 * nsfns.m (x_set_foreground_color, x_set_background_color):
3014 Use EmacsCGFloat.
3015 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3016 remove unused variables.
3017 (Fns_read_file_name): Keep track if panel is for save.
3018 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3019 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3020 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3021 Just return the input if GNUStep.
c0342369
JD
3022 (x_screen_planes): Remove.
3023 (Fxw_color_values): Use EmacsCGFloat
3024 (Fns_display_monitor_attributes_list): Only get screen number for
3025 Cocoa.
ef099a94 3026 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3027 EmacsSavePanel.
3028 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3029 ns_directory_from_panel.
3030
da9aff11
PE
30312013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3032
3033 * process.c (handle_child_signal): Also use WCONTINUED.
3034 This is so that list-processes doesn't mistakenly list the process
3035 as stopped, when the process has actually been continued and is
3036 now running.
3037
0e64479a
PE
30382013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3039
fc186a96
PE
3040 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3041 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3042 not already configured.
3043
0e64479a
PE
3044 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3045
38b787fa
EZ
30462013-05-29 Eli Zaretskii <eliz@gnu.org>
3047
3048 * Makefile.in (mostlyclean): Remove *.res files.
3049
22513e52
SM
30502013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3051
3052 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3053 a buffer (bug#8447).
3054
6ef3db10
EZ
30552013-05-27 Eli Zaretskii <eliz@gnu.org>
3056
3057 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3058 display vector, and we backtrack, handle the case that the
3059 previous character position is also displayed from a display
3060 vector or covered by a display string or image. (Bug#14476)
3061
6799bb26
JD
30622013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3063
3064 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3065 (struct MonitorInfo, free_monitors): Remove.
3066 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3067 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3068 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3069 Qframes, Qsource.
3070
3071 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3072 (struct MonitorInfo, free_monitors): Remove.
3073 (ns_screen_name): Make static.
3074 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3075 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3076 Qframes, Qsource.
3077
3078 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3079 (struct MonitorInfo): New struct.
3080 (free_monitors, make_monitor_attribute_list): Declare.
3081
22513e52
SM
3082 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3083 New Lisp_Object:s.
6799bb26
JD
3084 (free_monitors, make_monitor_attribute_list): New functions.
3085 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3086 Qsource.
3087
38cd43eb
XF
30882013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3089
3090 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3091
2af0948d
SM
30922013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3093
a7eb9b0f
SM
3094 * keyboard.c: Apply keyboard decoding only to events that come directly
3095 from the tty, not from unread-command-events (bug#14368).
3096 (read_event_from_main_queue): New function, extracted from read_char).
3097 (read_decoded_char): Remove.
3098 (read_decoded_event_from_main_queue): New function to replace it.
3099 (read_char): Use it.
3100 (read_key_sequence): Use read_char rather than read_decoded_char.
3101
2af0948d
SM
3102 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3103
1413e9a5
BR
31042013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3105
3106 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3107
e6d2f155
KH
31082013-05-22 Kenichi Handa <handa@gnu.org>
3109
3110 The following changes are to fix the setting of
3111 buffer-file-coding-system on, for instance, C-x RET c unix RET
3112 _FILE_OF_DOS_EOL_TYPE_ RET.
3113
3114 * coding.h (struct coding_system): New member detected_utf8_chars.
3115
3116 * coding.c (detect_coding_utf_8): Count characters and check EOL
3117 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3118 BOM is there.
3119 (setup_coding_system): Do not initialize coding->head_ascii.
3120 (check_ascii): Do not set coding->eol_seen but update it. Do not
3121 call adjust_coding_eol_type here.
1413e9a5
BR
3122 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3123 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3124 of the found coding-system.
3125 (decode_coding_gap): Cancel previous change. Utilize the
3126 character numbers counted by detect_coding_utf_8. Fix detection
3127 of BOM for utf-8.
3128
ab56a6f4 31292013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3130
3131 * search.c (looking_at_1): Only set last_thing_searched if the match
3132 changed the match-data (bug#14281).
3133
ecc3c6ed
DA
31342013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3135
3136 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3137 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3138 (move_it_vertically_backward): Likewise.
3139
5ba8bf35
YM
31402013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3141
3142 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3143 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3144 (Fx_display_mm_width, Fx_display_mm_height):
3145 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3146
91e8418b 3147 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3148 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3149 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3150 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3151 (Fx_display_backing_store, Fx_display_visual_class)
3152 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3153 (Fx_display_grayscale_p, Fx_display_pixel_width)
3154 (Fx_display_pixel_height, Fx_display_planes)
3155 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3156 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3157 (Fx_display_mm_width, Fx_display_mm_height)
3158 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3159 height for all physical monitors as in X11.
3160
fc30d803
SM
3161 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3162 Return pixel width or height for all physical monitors as in X11.
91e8418b 3163
31ff141c
PE
31642013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3165
3166 Port --enable-gcc-warnings to clang.
3167 * bytecode.c (exec_byte_code):
3168 * regex.c:
3169 Redo diagnostic pragmas to pacify clang, too.
3170 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3171 * editfns.c (Fencode_time):
3172 * fileio.c (file_accessible_directory_p):
3173 * font.c (font_unparse_xlfd):
3174 Use '&"string"[index]' instead of '"string" + (index)'.
3175 * undo.c (user_error): Remove; unused.
3176
df065a0b
EZ
31772013-05-16 Eli Zaretskii <eliz@gnu.org>
3178
04d360e7
EZ
3179 * insdel.c (insert_1_both): Document the arguments, instead of
3180 referring to insert_1, which no longer exists.
3181
5bb98290
EZ
3182 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3183 some window, increment windows_or_buffers_changed, so that
3184 *Messages* display in that window is updated. (Bug#14408)
3185
df065a0b
EZ
3186 * w32.c: Include epaths.h.
3187 (init_environment): Use cmdproxy.exe without leading directories.
3188 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3189 case.
3190 (gettimeofday): Adjust signature and return value to Posix
3191 expectations.
3192
3193 * unexw32.c (open_output_file): Delete the existing emacs.exe
3194 before creating it, to break the hard link to the versioned
3195 executable.
3196
3197 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3198 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3199 (FIRSTFILE_OBJ): New variables.
3200 (W32_RES): Rename to EMACSRES. All users changed.
3201 (base_obj): Use $(CM_OBJ).
3202 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3203 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3204 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3205 $(W32_RES_LINK) before $(LIBES).
3206 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3207
1aa8d505
SM
32082013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3209
6e911150
SM
3210 * makefile.w32-in (DOC): Use just "DOC".
3211
3212 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3213
1aa8d505
SM
3214 * process.c: Export default filters and sentinels to Elisp.
3215 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3216 New constants.
3217 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3218 (Fset_process_sentinel, Fformat_network_address):
3219 Default to them instead of nil.
3220 (server_accept_connection): Sentinels can't be nil any more.
3221 (read_and_dispose_of_process_output): New function, extracted from
3222 read_process_output.
3223 (read_process_output): Use it; filters can't be nil.
3224 (Finternal_default_process_filter): New function, extracted from
3225 read_process_output.
3226 (exec_sentinel_unwind): Remove function.
3227 (exec_sentinel): Don't zilch sentinel while running.
3228 (status_notify): Sentinels can't be nil.
3229 (Finternal_default_process_sentinel): New function extracted from
3230 status_notify.
3231 (setup_process_coding_systems): Default filter is not nil any more.
3232 (syms_of_process): Export new Elisp functions and initialize
3233 new constants.
3234 * lisp.h (make_lisp_proc): New function.
3235
5ac2eb34
SM
32362013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3237
3238 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3239
eda9c7d7
EZ
32402013-05-14 Eli Zaretskii <eliz@gnu.org>
3241
3242 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3243 unless we know that the window w is a leaf window.
3244 Another attempt at solving bug#14062.
eda9c7d7 3245
8fdeaad5
JD
32462013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3247
3248 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3249 fdesc (Bug#14375).
3250
44aa9ee6
PE
32512013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 * image.c (gif_load): Check that subimages fit (Bug#14345).
3254
759fd763
SM
32552013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3256
3257 * lread.c (skip_dyn_eof): New function.
3258 (read1): Use it to skip the end of a file in response to #@00.
3259
3260 * doc.c (get_doc_string): Slightly relax the sanity checking.
3261
4465bfb4
JD
32622013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3263
3264 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3265 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3266 (MonitorInfo): New struct.
3267 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3268 (Fns_display_monitor_attributes_list): New functions.
3269 (display-usable-bounds): Remove.
3270 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3271 Qsource.
3272
7583e2a0
PE
32732013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3276 (GTK_CHECK_VERSION): New macro, if not already defined.
3277 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3278 replaced by GTK_CHECK_VERSION.
3279
ad75d77e
PE
32802013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3281
3282 * xterm.h (GTK_PREREQ): New macro.
3283 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3284 to use this macro instead, for consistency and clarity.
3285
07525f77
EZ
32862013-05-08 Eli Zaretskii <eliz@gnu.org>
3287
3288 * xdisp.c (row_for_charpos_p): New function, with code of
3289 cursor_row_p, but accepts an additional argument CHARPOS instead
3290 of using a hardcoded PT.
3291 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3292 (row_containing_pos): Call row_for_charpos_p instead of partially
3293 doing the same. Fixes cursor positioning under longlines-mode
3294 when longlines-show-effect includes more than one newline, when
3295 moving the cursor vertically up.
3296
d901fc8d
JB
32972013-05-08 Juanma Barranquero <lekktu@gmail.com>
3298
3299 * makefile.w32-in (ACL_H): New macro.
3300 ($(BLD)/fileio.$(O)): Update dependencies.
3301
f269bc61
PE
33022013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3303
e7b41c4c 3304 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3305 * Makefile.in (LIB_ACL): New macro.
3306 (LIBACL_LIBS): Remove.
3307 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3308 * fileio.c: Include <acl.h>.
3309 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3310 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3311 !acl_errno_valid.
3312 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3313 it ourselves.
3314
f269bc61
PE
3315 * unexelf.c: Don't assume ElfW (Half) fits in int.
3316 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3317 when dealing with ElfW (Half) values, since they can exceed 2**31
3318 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3319 (entry_address): Omit unused NUM arg. All uses changed.
3320
a261c53e
JL
33212013-05-07 Juri Linkov <juri@jurta.org>
3322
3323 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3324 to the string converted from number with `Fnumber_to_string'.
3325 (Bug#14254)
3326
2b66427d
PE
33272013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3328
3329 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3330 This fixes a problem introduced by my previous change.
3331
15acfe41
GM
33322013-05-07 Glenn Morris <rgm@gnu.org>
3333
3334 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3335
5ea03bf5
JD
33362013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3337
3338 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3339
e0c9d565
PE
33402013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 Static checking by GCC 4.8.0.
3343 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3344 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3345 (x_get_monitor_attributes_fallback)
3346 (x_get_monitor_attributes_xinerama)
3347 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3348 Define only if USE_GTK.
3349 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3350 (x_get_monitor_attributes_fallback): Omit unused locals.
3351 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3352 Use double, not float, to avoid mixed-mode floating point arithmetic.
3353
4e3f9230
YM
33542013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3355 Jan Djärv <jan.h.d@swipnet.se>
3356
3357 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3358 (XINERAMA_CFLAGS): New macros.
3359 (ALL_CFLAGS, LIBES): Use them.
3360
3361 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3362 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3363 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3364 (syms_of_xfns): DEFSYM them.
3365 (struct MonitorInfo): New struct.
3366 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3367 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3368 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3369 (x_get_monitor_attributes_xinerama): New functions.
3370 (Fx_display_monitor_attributes_list): New primitive.
3371 (syms_of_xfns): Defsubr it.
3372
3373 * xterm.h (x_display_info): Add Xatom_net_workarea and
3374 Xatom_net_current_desktop.
3375
3376 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3377 and dpyinfo->Xatom_net_current_desktop.
3378
05839b6a
EZ
33792013-05-06 Eli Zaretskii <eliz@gnu.org>
3380
3381 * xdisp.c (pos_visible_p): Use the special code for finding the
3382 beginning of a display property or overlay for any "replacing"
3383 display property, not just for display strings. This solves
3384 incorrect reporting of position by posn-at-point. (Bug#14241)
3385
dc4a2ee0
PE
33862013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3387
5ee94506
PE
3388 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3389 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3390 Verify that ElfW (Half) fits in int.
3391 (fatal): Use same signature as lisp.h.
3392 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3393 configure and build with -DUNEXELF_DEBUG without worrying about
3394 other modules that use DEBUG.
3395 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3396 possibly-wide integers now uses it instead of plain fprintf.
3397 (entry_address): New function, which avoids problems with 32-bit
3398 overflow on 64-bit hosts.
3399 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3400 (round_up): Don't assume the remainder fits in int.
3401 (find_section): Use bool for boolean. Simplify debug code.
3402 (unexec): Don't assume file sizes fit in int or size_t.
3403 Omit unnecessary trailing newline in 'fatal' format.
3404 Use strerror rather than outputting decimal error number.
3405 Remove unused code when emacs is not defined;
3406 this file relies on Emacs now.
3407 Don't assume e_phnum and e_shnum are positive.
3408
dc4a2ee0
PE
3409 * regex.c: Fix problems when DEBUG is defined.
3410 (extract_number, extract_number_and_incr): Define regardless of
3411 whether DEBUG is defined; that's simpler and makes the code less
3412 likely to go stale in the normal case when DEBUG is not defined.
3413 Return int rather than taking an int * arg. All callers changed.
3414 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3415 Remove, replacing with ...
3416 (DEBUG_PRINT): New macro. All callers changed.
3417 (DEBUG_COMPILES_ARGUMENTS): New macro.
3418 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3419 (print_compiled_pattern, print_double_string) [DEBUG]:
3420 Use prototype rather than old-style definition.
3421 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3422 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3423 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3424 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3425 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3426 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3427 This matters only when DEBUG is defined.
3428
14c7ed05
EZ
34292013-05-05 Eli Zaretskii <eliz@gnu.org>
3430
3431 * xdisp.c (set_iterator_to_next): Set the
3432 ignore_overlay_strings_at_pos_p flag only if we are _really_
3433 iterating over an overlay string, as indicated by the
3434 current.overlay_string_index member. (Bug#14306)
3435
e6076b1b
JD
34362013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3437
3438 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3439 to where it is used, to avoid autorelease issues (Bug#14050).
3440
cbee2131
PE
34412013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3442
3443 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3444 * fileio.c (syms_of_fileio): Implement this.
3445 * filelock.c (create_lock_file): If symbolic links don't work, so
3446 we use a regular file as a lock file, do not fsync the lock file;
3447 it's not needed.
3448
30c7e542
SM
34492013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3450
3451 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3452 (syms_of_minibuf): Adjust accodingly.
3453 * lread.c (Fread):
3454 * callint.c (Fcall_interactively): Adjust calls accordingly.
3455
5bebd186
EZ
34562013-05-04 Eli Zaretskii <eliz@gnu.org>
3457
3458 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3459 w->contents is a buffer before computing everything else.
3460 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3461
3462 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3463 assertion violations. (Bug#14062)
3464
0fb0a4f3
DR
34652013-05-01 David Reitter <david.reitter@gmail.com>
3466
3467 * nsfns.m (ns_tooltip): Initialize.
3468
9e63b4a5
EZ
34692013-04-28 Eli Zaretskii <eliz@gnu.org>
3470
3471 * coding.c (decode_coding_gap): Don't remove the character before
3472 a newline unless it's a CR character. (Bug#14287)
3473
ad60824e
DN
34742013-04-28 Dan Nicolaescu <dann@gnu.org>
3475
3476 * dispextern.h (struct face): Move enum face_underline_type
3477 earlier so that bitfields can be in the same word.
3478
edbdcec0
JD
34792013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3480
3481 * nsfns.m (handlePanelKeys): New function.
3482 (EmacsOpenPanel:performKeyEquivalent:)
3483 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3484 arrows/function/control and copy/paste keys (Bug#14296).
3485
0208ede7
JL
34862013-04-27 Juri Linkov <juri@jurta.org>
3487
3488 * callint.c (Fcall_interactively): Call `Qread_number' for
3489 interactive code letter `n' instead of using duplicate code.
3490 (Bug#14254)
3491
b8dd59f7
PE
34922013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3493
3494 * systime.h (make_timeval): Declare as 'const'.
3495
8bd722db
KH
34962013-04-27 Kenichi Handa <handa@gnu.org>
3497
3498 * font.c (font_open_entity): Always open a font of manageable
3499 size.
3500
13d0e56f 35012013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3502
f780d632
PE
3503 Port better to AIX (Bug#14258).
3504 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3505 to pacify AIX xlc.
3506
ec509856
KH
35072013-04-24 Kenichi Handa <handa@gnu.org>
3508
3509 * coding.c (decode_coding_iso_2022): When an invalid escape
3510 sequence is encountered, reset the invocation and designation
3511 status to the safest one.
3512
84fc48e5
PE
35132013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3516 Without this fix, "make distclean" leaves stamp-h1 behind.
3517
806bda47
EC
35182013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3519
3520 * w32fns.c (w32_fullscreen_rect): New function to compute the
3521 window rectangle for the given fullscreen mode.
3522 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3523 longer tunes the window size. This keeps the window's edges flush
3524 with the screen and allows the taskbar to hide itself in fullboth.
3525
3526 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3527 window decorations and uses the entire screen.
3528
3529 * w32term.h (w32_fullscreen_rect) Add prototype.
3530 (struct w32_output): Replace normal_width, normal_height,
3531 normal_top, and normal_left members with a single normal_placement
3532 struct.
3533 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3534 Remove macros.
3535 (FRAME_NORMAL_PLACEMENT): New macro.
3536
9cc2810b
JB
35372013-04-16 Juanma Barranquero <lekktu@gmail.com>
3538
3539 * minibuf.c (Ftest_completion): Silence compiler warning.
3540
fd16b54c
EZ
35412013-04-15 Eli Zaretskii <eliz@gnu.org>
3542
3543 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3544 bug#14062.
fd16b54c
EZ
3545
3546 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3547 parentheses.
3548
3549 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3550 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3551 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3552 parentheses where appropriate.
3553
9e3379a0
PE
35542013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3557
ddd6b685
EZ
35582013-04-14 Eli Zaretskii <eliz@gnu.org>
3559
3560 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3561 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3562 Mention in the doc string that setting these variables takes
3563 effect only after a call to set-window-buffer. (Bug#14200)
3564
29b79ba1
EZ
35652013-04-13 Eli Zaretskii <eliz@gnu.org>
3566
3567 * indent.c (Fvertical_motion): Don't consider display strings on
3568 overlay strings as display strings on the buffer position we
3569 started from. This prevents vertical cursor motion from jumping
3570 more than one line when there's an overlay string with a display
3571 property at end of line.
3572 Reported by Karl Chen <Karl.Chen@quarl.org> in
3573 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3574
562c6ee9
SM
35752013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3576
3577 * window.c (select_window): `record_buffer' even if window is
3578 already selected (bug#14191).
3579
fcc1fe85
EZ
35802013-04-11 Eli Zaretskii <eliz@gnu.org>
3581
3582 * window.c (Fwindow_end): Test more flags, including the buffer's
3583 last_overlay_modified flag, to determine whether the window's
3584 display is really up-to-date. Prevents the function from
3585 returning a stale value. (Bug#14170)
3586 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3587 current matrix.
3588
f009190a
EZ
35892013-04-10 Eli Zaretskii <eliz@gnu.org>
3590
3591 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3592 garbaged only if it is not already the top frame on its TTY.
3593 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3594 there are GUI frames open in the same session. (Bug#13864)
3595
78ce603d
SM
35962013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3597
3598 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3599 of marking the idle timers directly.
3600
a8036e40
SM
36012013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3602
3603 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3604 tables (bug#14054).
3605
7ffe7ef6
SM
36062013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3607
3608 * window.c (select_window): Don't record_buffer while the invariant is
3609 temporarily broken (bug#14161).
3610
3611 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3612
7d9f6883
EZ
36132013-04-07 Eli Zaretskii <eliz@gnu.org>
3614
3615 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3616
5406cfd9
RF
36172013-04-07 Romain Francoise <romain@orebokech.com>
3618
3619 Ignore additional platform-specific ACL errors (Bug#13702).
3620 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3621 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3622
95c0e83b
JD
36232013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3624
3625 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3626 f->output_data.ns.
3627
876da980
PE
36282013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3631 This bug was introduced by my 2013-02-25 change that simplified
3632 data_start configuration. Without this change, on GNU/Linux
3633 an Emacs configured with --enable-profiling fails immediately
3634 due to a profiler signal.
3635 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3636 with these flags. On platforms where special flags are needed
3637 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3638 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3639 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3640
7452b7bd
DA
36412013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3642
3643 Get rid of some platform-specific functions examining window
3644 system and its capabilities. This is a partial rework of the
3645 2013-04-05 change.
3646 * lisp.h (have_menus_p): Remove prototype. This function is
3647 replaced with platform-independent window_system_available.
3648 (check_window_system): Move to...
3649 * frame.h (decode_window_system_frame, window_system_available):
3650 ...here, add new prototypes.
3651 * frame.c (window_system_available, decode_window_system_frame):
3652 New functions.
3653 (check_window_system): Platform-independent now.
3654 * xterm.h (x_in_use): Remove declaration.
3655 (check_x_frame):
3656 * w32term.h (check_x_frame):
3657 * nsterm.h (check_x_frame): Remove prototypes. This function
3658 is replaced with platform-independent decode_window_system_frame.
3659 * msdos.c (have_menus_p): Remove.
3660 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3661 Remove platform-specific functions. Use check_window_system,
3662 decode_window_system_frame and check_ns_display_info where
3663 appropriate. Minor style and comment tweaks.
3664 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3665 (check_x_frame): Likewise.
3666 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3667 Likewise.
3668 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3669 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3670 * xmenu.c, xselect.c: All related users changed.
3671
251e9147
KH
36722013-04-03 Kenichi Handa <handa@gnu.org>
3673
3674 The following changes is to optimize the code for reading UTF-8
3675 files.
3676
562c6ee9 3677 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3678 changed. Check EOL format. Do not call adjust_coding_eol_type
3679 here.
3680 (check_utf_8): New function.
3681 (adjust_coding_eol_type): Do nothing if already adjusted.
3682 (detect_coding): Compare the return value of check_ascii with
3683 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3684 (decode_coding_gap): Optimize for valid UTF-8.
3685
8bc369d4
KH
36862013-03-21 Kenichi Handa <handa@gnu.org>
3687
3688 * coding.c (syms_of_coding): Cancel previous change.
3689
3690 * insdel.c (insert_from_gap): Fix previous change.
3691
73931ad1
DA
36922013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3693
3694 Consistently use platform-specific function to detect window system.
3695 * lisp.h (check_window_system): New prototype. This function is
3696 going to replace check_x, check_w32 and check_ns.
3697 (have_menus_p): Mention msdos.c in comment.
3698 * fontset.c (check_window_system_func): Remove. Adjust all users.
3699 * fontset.h (check_window_system_func): Remove prototype.
3700 * nsterm.h (check_ns):
3701 * xterm.h (check_x):
3702 * w32term.h (check_w32): Likewise.
3703 * menu.c (Fx_popup_menu): Use check_window_system.
3704 * msdos.c (check_window_system): Define for MS-DOS.
3705 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3706 * w32fns.c (check_window_system): Likewise for MS-Windows.
3707 * xfns.c (check_window_system): Likewise for X.
3708 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3709 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3710
7216e43b
PE
37112013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3712
3713 Prefer < to > in range checks such as 0 <= i && i < N.
3714 This makes it easier to visualize quantities on a number line.
3715 This patch doesn't apply to all such range checks,
3716 only to the range checks affected by the 2013-03-24 change.
3717 This patch reverts most of the 2013-03-24 change.
3718 * alloc.c (xpalloc, Fgarbage_collect):
3719 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3720 * character.c (string_escape_byte8):
3721 * charset.c (read_hex):
3722 * data.c (cons_to_unsigned):
3723 * dispnew.c (update_frame_1):
3724 * doc.c (Fsubstitute_command_keys):
3725 * doprnt.c (doprnt):
3726 * editfns.c (hi_time, decode_time_components):
3727 * fileio.c (file_offset):
3728 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3729 * font.c (font_intern_prop):
3730 * frame.c (x_set_alpha):
3731 * gtkutil.c (get_utf8_string):
3732 * indent.c (check_display_width):
3733 * keymap.c (Fkey_description):
3734 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3735 * lread.c (read1):
3736 * minibuf.c (read_minibuf_noninteractive):
3737 * process.c (wait_reading_process_output):
3738 * search.c (Freplace_match):
3739 * window.c (get_phys_cursor_glyph):
3740 * xdisp.c (redisplay_internal):
3741 * xsmfns.c (smc_save_yourself_CB):
3742 Prefer < to > for range checks.
3743 * dispnew.c (sit_for): Don't mishandle NaNs.
3744 This fixes a bug introduced in the 2013-03-24 change.
3745 * editfns.c (decode_time_components): Don't hoist comparison.
3746 This fixes another bug introduced in the 2013-03-24 change.
3747
92759988
DA
37482013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3749
3750 * frame.h (struct frame): Drop scroll_bottom_vpos
3751 member becaue all real users are dead long ago.
3752 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3753 * xdisp.c (redisplay_internal): Adjust user.
3754
9a1971bb
GM
37552013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3756
f38ab167
JD
3757 * nsmenu.m (showAtX:Y:for:): setLevel to
3758 NSPopUpMenuWindowLevel (Bug#13998).
3759
6d01f1fe
JD
37602013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3761
3762 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3763 (ns_check_pending_open_menu): Declare.
3764
3765 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3766 (x_activate_menubar): Update the menu with title that matches
3767 ns_get_pending_menu_title, and call
3768 ns_check_pending_openmenu (Bug#12698).
3769 (menuWillOpen:): New method.
3770 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3771
3772 * nsterm.m (menu_will_open_state, menu_mouse_point)
3773 (menu_pending_title): New varaibles.
3774 (ns_get_pending_menu_title, ns_check_menu_open)
3775 (ns_check_pending_open_menu): New functions.
3776
781f4782
DA
37772013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3778
3779 * indent.c (current_column_bol_cache): Remove leftover which is not
3780 used in Fmove_to_column any more.
3781 (current_column, scan_for_column): Adjust users.
3782 * keyboard.c (last_point_position_buffer, last_point_position_window):
3783 Remove leftovers which are not used for recording undo any more.
3784 (command_loop_1, syms_of_keyboard): Adjust users.
3785 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3786 redisplay_window any more.
3787 (move_it_to): Adjust user.
3788
1921c31b
JB
37892013-03-29 Juanma Barranquero <lekktu@gmail.com>
3790
3791 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3792 Update dependencies.
3793
717b8bcd
SM
37942013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3795
3796 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3797 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3798 forward references.
3799
e74aeda8
DA
38002013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3801
3802 * window.h (struct window): Replace hchild, vchild and buffer slots
3803 with the only contents slot. This is possible because each valid
3804 window may have either the child window (in vertical or horizontal
3805 combination) or buffer to display (for the leaf window). Using that,
3806 a lof of operations to traverse and/or change window hierarchies may
3807 be simplified. New member horizontal is used to distinguish between
3808 horizontal and vertical combinations of internal windows.
3809 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3810 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3811 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3812 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3813 Use contents slot, not buffer, where appropriate.
3814 (wset_combination): New function.
3815 (wset_buffer): Add eassert.
3816 (Fframe_first_window): Simplify the loop reaching first window.
3817 (Fwindow_buffer): Use WINDOW_LEAF_P.
3818 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3819 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3820 (unshow_buffer): Convert initial debugging check to eassert.
3821 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3822 (make_parent_window, window_resize_check, window_resize_apply)
3823 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3824 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3825 Adjust to match struct window changes.
3826 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3827 (mark_window_cursors_off, count_windows, get_leaf_windows)
3828 (foreach_window_1): Simplify the loop.
3829 * alloc.c (mark_object): Do not check for the leaf window because
3830 internal windows has no glyph matrices anyway.
3831 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3832 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3833 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3834 (build_frame_matrix_from_window_tree, mirror_make_current)
3835 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3836 (update_window_tree, set_window_update_flags): Simplify the loop.
3837 (sync_window_with_frame_matrix_rows): Enforce live window.
3838 Use contents slot, not buffer, where appropriate.
3839 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3840 and WINDOW_HORIZONTAL_COMBINATION_P.
3841 (make_frame_visible_1): Simplify the loop.
3842 Use contents slot, not buffer, where appropriate.
3843 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3844 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3845 (expose_window_tree): Likewise.
3846 Use contents slot, not buffer, where appropriate.
3847 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3848 to avoid deleted windows. Use contents slot instead of buffer.
3849 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3850 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3851 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3852 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3853
121ab1cd
EZ
38542013-03-28 Eli Zaretskii <eliz@gnu.org>
3855
ef454cf7
EZ
3856 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3857 identify the reasons for assertion violations in bug#14062 and
3858 similar ones.
21e930f8
EZ
3859 (Fx_show_tip): Fix compilation error under
3860 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3861
121ab1cd
EZ
3862 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3863 Reported by <rzl24ozi@gmail.com>.
3864
5c89ca24
DA
38652013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3866
3867 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3868 start marker...
562c6ee9
SM
3869 (unwind_with_echo_area_buffer): ...to restore it here.
3870 This is needed to ensure that...
5c89ca24
DA
3871 (redisplay_window): ...both window markers are valid here,
3872 which is verified by eassert.
3873 * editfns.c (save_excursion_save): Do not assume that
3874 selected_window always displays the buffer.
c7f53895
DA
3875 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3876 Fix comment.
5c89ca24 3877
f557c1b1
SM
38782013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3879
3880 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3881 the upcase table.
3882
40693bba 38832013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3884
3885 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3886
c86f791f
EZ
38872013-03-27 Eli Zaretskii <eliz@gnu.org>
3888
3889 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3890 since MinGW's w32api headers do. This avoids compiler warnings.
3891
3892 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3893 if already defined.
3894
c6e72e17
EZ
38952013-03-26 Eli Zaretskii <eliz@gnu.org>
3896
3897 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3898
54e95010
JD
38992013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3900
3901 * gtkutil.c (style_changed_cb): Check if frame is live and an
3902 X frame (Bug#14038).
3903
b88b62de
EZ
39042013-03-26 Eli Zaretskii <eliz@gnu.org>
3905
a18d7de6
EZ
3906 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3907 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3908 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3909 MinGW64.
8f5e14c8
EZ
3910 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3911 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3912
b88b62de
EZ
3913 Fix incompatibilities between MinGW.org and MinGW64 headers.
3914 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3915
3916 * w32.c (REPARSE_DATA_BUFFER): Guard with
3917 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3918
c074e458
JD
39192013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3920
3921 * xterm.c: Include X11/XKBlib.h
3922 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3923
908589fd
AS
39242013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3925
3926 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3927 written backwards.
3928 * blockinput.h (input_blocked_p): Likewise.
3929 * bytecode.c (exec_byte_code): Likewise.
3930 * callproc.c (call_process_kill, call_process_cleanup)
3931 (Fcall_process): Likewise.
3932 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3933 (Fccl_execute_on_string): Likewise.
3934 * character.c (string_escape_byte8): Likewise.
3935 * charset.c (read_hex): Likewise.
3936 * cm.c (calccost): Likewise.
3937 * data.c (cons_to_unsigned): Likewise.
3938 * dired.c (directory_files_internal, file_name_completion):
3939 Likewise.
3940 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3941 (sit_for): Likewise.
3942 * doc.c (Fsubstitute_command_keys): Likewise.
3943 * doprnt.c (doprnt): Likewise.
3944 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3945 * emacsgtkfixed.c: Likewise.
3946 * fileio.c (file_offset, Fwrite_region): Likewise.
3947 * floatfns.c (Fexpt, fmod_float): Likewise.
3948 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3949 Likewise.
3950 * font.c (font_intern_prop): Likewise.
3951 * frame.c (x_set_alpha): Likewise.
3952 * gtkutil.c (get_utf8_string): Likewise.
3953 * indent.c (check_display_width): Likewise.
3954 * intervals.c (create_root_interval, rotate_right, rotate_left)
3955 (split_interval_right, split_interval_left)
3956 (adjust_intervals_for_insertion, delete_node)
3957 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3958 (merge_interval_right, merge_interval_left, copy_intervals)
3959 (set_intervals_multibyte_1): Likewise.
3960 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3961 * keymap.c (Fkey_description): Likewise.
3962 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3963 * lread.c (openp, read_integer, read1, string_to_number):
3964 Likewise.
3965 * menu.c (ensure_menu_items): Likewise.
3966 * minibuf.c (read_minibuf_noninteractive): Likewise.
3967 * print.c (printchar, strout): Likewise.
3968 * process.c (create_process, Faccept_process_output)
3969 (wait_reading_process_output, read_process_output, send_process)
3970 (wait_reading_process_output): Likewise.
3971 * profiler.c (make_log, handle_profiler_signal): Likewise.
3972 * regex.c (re_exec): Likewise.
3973 * regex.h: Likewise.
3974 * search.c (looking_at_1, Freplace_match): Likewise.
3975 * sysdep.c (get_child_status, procfs_ttyname)
3976 (procfs_get_total_memory): Likewise.
3977 * systime.h (EMACS_TIME_VALID_P): Likewise.
3978 * term.c (dissociate_if_controlling_tty): Likewise.
3979 * window.c (get_phys_cursor_glyph): Likewise.
3980 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3981 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3982 Likewise.
3983 * xfns.c (Fx_window_property): Likewise.
3984 * xmenu.c (set_frame_menubar): Likewise.
3985 * xselect.c (x_get_window_property, x_handle_dnd_message):
3986 Likewise.
3987 * xsmfns.c (smc_save_yourself_CB): Likewise.
3988 * xterm.c (x_scroll_bar_set_handle): Likewise.
3989
2bf7d27a
DA
39902013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3991
3992 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3993 to be optional or nil. Adjust comment and convert it to docstring.
3994 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3995 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3996
a9ebfa0b
PE
39972013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3998
3999 Static checking by GCC 4.8-20130319.
4000 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4001 * process.c (Fset_process_datagram_address)
4002 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4003 * xdisp.c (get_char_face_and_encoding):
4004 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4005 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4006 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4007
4f3576ee
KB
40082013-03-24 Ken Brown <kbrown@cornell.edu>
4009
789b5e9a
KB
4010 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4011 fix compilation on 64-bit Cygwin, where underscores are not
4012 automatically prepended.
4013
4f3576ee
KB
4014 * w32term.c (w32_initialize): Silence compiler warning.
4015
b5b7745f
EZ
40162013-03-23 Eli Zaretskii <eliz@gnu.org>
4017
cdc0d0bd
EZ
4018 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4019 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4020 variables, to save and restore frame dimensions.
4021 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4022 after returning from a 'fullscreen' configuration.
4023 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4024 to avoid races between the main thread and the input thread.
4025
4026 * w32term.h (struct w32_output): New members normal_width,
4027 normal_height, normal_top, normal_left, and prev_fsmode.
4028 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4029 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4030 members of a frame.
4031
b5b7745f
EZ
4032 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4033 'fullscreen' parameter. Always record previous width and height
4034 of the frame, except when switching out of maximized modes, so
4035 that they could be restored correctly, instead of resetting to the
4036 default frame dimensions. Send SC_RESTORE command to the frame,
4037 unless we are going to send SC_MAXIMIZE, to restore the frame
4038 resize hints in the mouse pointer shown by the window manager.
4039 (Bug#14032)
4040
4041 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4042
4043 * lisp.h (get_frame_param): Adjust conditions for prototype
4044 declaration.
4045
a3454eed
KB
40462013-03-22 Ken Brown <kbrown@cornell.edu>
4047
4048 * unexcw.c: Drop unneeded inclusion of w32common.h.
4049 (report_sheap_usage): Declare.
4050 (read_exe_header): Add magic numbers for x86_64.
4051 (fixup_executable): Fix printf format specifier for unsigned long
4052 argument.
4053
5a49b79c
DA
40542013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4055
4056 * frame.h (struct frame): Put menu_bar_window under #ifdef
4057 because this member is not needed when X toolkit is in use.
4058 (fset_menu_bar_window):
4059 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4060 (free_glyphs, update_frame):
4061 * xdisp.c (expose_frame): Likewise.
4062 (display_menu_bar): Likewise. Remove redundant eassert.
4063 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4064 toolkit is in use.
4065
d6723bf7
PE
40662013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4067
7b1123d8
PE
4068 Use functions and constants to manipulate Lisp_Save_Value objects.
4069 This replaces code that used macros and strings and token-pasting.
4070 The change makes the C source a bit easier to follow,
4071 and shrinks the Emacs executable a bit.
4072 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4073 (make_save_value): Change 1st arg from string to enum. All callers
4074 changed.
4075 (INTX): Remove.
4076 (mark_object): Use if, not #if, for GC_MARK_STACK.
4077 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4078 (XSAVE_OBJECT): Now functions, not macros.
4079 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4080 the constant was never used.
4081 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4082 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4083 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4084 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4085 New constants.
4086 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4087 type3 with a single member save_type. All uses changed.
4088 (save_type, set_save_pointer, set_save_integer): New functions.
4089 * print.c (PRINTX): Remove.
4090
d6723bf7
PE
4091 * alloc.c: Remove redundant static declarations.
4092
5f24fa51
DA
40932013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4094
4095 * window.h (struct window): Convert left_col, top_line, total_lines
4096 and total_cols from Lisp_Objects to integers. Adjust comments.
4097 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4098 Remove.
4099 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4100 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4101 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4102 Adjust users where appropriate.
4103
42143acd
DA
41042013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4105
4106 * frame.h (struct frame): Drop resx and resy because the same data is
4107 available from window system-specific output context. Adjust users.
562c6ee9
SM
4108 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4109 New functions to provide defaults when no window system available.
42143acd 4110 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4111 (NUMVAL): Move from xdisp.c.
42143acd
DA
4112 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4113 (Ffont_face_attributes, Fopen_font):
4114 * image.c (gs_load):
4115 * w32font.c (fill_in_logfont):
4116 * xdisp.c (calc_pixel_width_or_height):
4117 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4118 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4119
c0a17406
KH
41202013-03-20 Kenichi Handa <handa@gnu.org>
4121
4122 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4123 to 1 (temporary workaround until a bug related to ASCII
4124 optimization is fixed).
4125
095d384d
DA
41262013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4127
4128 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4129 Signal error if window is not internal. Adjust docstring.
4130 (delete_all_child_windows): Use combination_limit to save the buffer.
4131 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4132 * print.c (syms_of_print): Initialize debugging output not here...
4133 (init_print_once): ...but in a new function here.
4134 * lisp.h (init_print_once): Add prototype.
4135 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4136
748fa866
DA
41372013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4138
4139 * window.c (window_resize_check, window_resize_apply)
4140 (window_from_coordinates, recombine_windows, set_window_buffer)
4141 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4142 (Fsplit_window_internal, Fdelete_window_internal)
4143 (freeze_window_starts): Use bool for booleans.
4144 * window.h (window_frame_coordinates, resize_frame_windows)
4145 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4146
81519fd2
SM
41472013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4148
4149 * dispnew.c (bitch_at_user): Use `user-error'.
4150
6db423a9
KB
41512013-03-17 Ken Brown <kbrown@cornell.edu>
4152
4153 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4154 as return type of image_background. (Bug#13981)
4155 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4156
8f2906f5
JD
41572013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4158
960ce480 4159 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4160 (ns_select): Don't return with result uninitialized.
960ce480 4161
8f2906f5
JD
4162 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4163 and getDirectory.
4164
81519fd2
SM
4165 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4166 New functions.
8f2906f5
JD
4167 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4168 directories. If filename is nil, get directory name (Bug#13932).
4169 Use getFilename and getDirectory.
4170 (getFilename, getDirectory): New methods for EmacsSavePanel and
4171 EmacsOpenPanel.
4172 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4173
cded56c1
PE
41742013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4175
4176 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4177
251e9147 41782013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4179
4180 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4181 (adjust_after_replace): Make it back to static. Delete the third
4182 arg text_at_gap_tail. Cancel the code for handling it.
4183
4184 * coding.h (struct coding_system): New member eol_seen.
4185
4186 * coding.c (detect_ascii): New function.
4187 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4188 when the source bytes are actually scanned. On detecting for
4189 coding_category_utf_8_auto, call detect_ascii instead of scanning
4190 source bytes directly.
4191 (produce_chars): Call insert_from_gap with the new arg 0.
4192 (encode_coding): Likewise.
4193 (decode_coding_gap): Control ASCII optimization by the variable
4194 disable_ascii_optimization instead of #ifndef .. #endif.
4195 Deccode EOL format according to coding->eol_seen.
4196 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4197 variable.
4198
8a44e6d1
KH
4199 * lisp.h (adjust_after_replace): Cancel externing it.
4200 (insert_from_gap): Adjust prototype.
4201
5f795e34
EZ
42022013-03-15 Eli Zaretskii <eliz@gnu.org>
4203
4204 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4205 FULLSCREEN_MAXIMIZED. (Bug#13935)
4206
f258b4be
DA
42072013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4208
4209 * region-cache.c (find_cache_boundary, move_cache_gap)
4210 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4211 Simplify debugging check and convert to eassert. Adjust comment.
4212 (pp_cache): Put under ENABLE_CHECKING.
4213
a5cc4dde
EZ
42142013-03-14 Eli Zaretskii <eliz@gnu.org>
4215
4216 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4217 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4218 and WM_ACTIVATEAPP.
4219 (w32fullscreen_hook): If the frame is visible, reset
4220 f->want_fullscreen flag after changing the frame size. If the
4221 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4222 (Bug#13953)
4223
3fc5e44a
DC
42242013-03-13 Daniel Colascione <dancol@dancol.org>
4225
4226 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4227 too so that these builds can use Cygwin's file conversion
4228 functions. (We've been building and linking cygw32.o all along
4229 and just not using it.)
4230
47d7532e
PE
42312013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4232
4233 File synchronization fixes (Bug#13944).
4234 * Makefile.in (LIB_FDATASYNC): New macro.
4235 (LIBES): Use it.
4236 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4237 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4238 Don't worry about HAVE_FSYNC, since a substitute fsync is
4239 available if the system lacks one.
4240 (Fwrite_regin): Retry fsync if interrupted.
4241
c7ffccaf
EZ
42422013-03-13 Eli Zaretskii <eliz@gnu.org>
4243
4e2df81d 4244 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4245 activated, call w32fullscreen_hook, to make sure the new frame
4246 dimensions are in effect. (Bug#13937)
4247
8a7debc1
DA
42482013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4249
4250 * xdisp.c (init_iterator): Simplify because both character and byte
4251 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4252 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4253 character and byte positions can be obtained from marker.
8a7debc1 4254
7fd8c501
PE
42552013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4256
d9df6f40
PE
4257 Static checking by Sun C 5.12.
4258 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4259 * bytecode.c (exec_byte_code):
4260 * dispnew.c (init_display):
4261 * eval.c (error):
4262 * fileio.c (Fsubstitute_in_file_name):
4263 * keyboard.c (Fevent_convert_list):
4264 * keymap.c (Fsingle_key_description):
4265 * term.c (maybe_fatal, fatal):
4266 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4267 * xsmfns.c (Fhandle_save_session):
4268 Omit unreachable code.
4269 * keymap.c (map_keymap_char_table_item): Cast void * to
4270 a function pointer type; the C Standard requires this.
4271
7fd8c501
PE
4272 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4273 Include <sys/param.h> unconditionally, as that works elsewhere and
4274 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4275 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4276 and FreeBSD now.
4277
a020afb9 4278See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4279
4280;; Local Variables:
4281;; coding: utf-8
aac0c6e3
MR
4282;; End:
4283
ab422c4d 4284 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4285
4286 This file is part of GNU Emacs.
4287
4288 GNU Emacs is free software: you can redistribute it and/or modify
4289 it under the terms of the GNU General Public License as published by
4290 the Free Software Foundation, either version 3 of the License, or
4291 (at your option) any later version.
4292
4293 GNU Emacs is distributed in the hope that it will be useful,
4294 but WITHOUT ANY WARRANTY; without even the implied warranty of
4295 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4296 GNU General Public License for more details.
4297
4298 You should have received a copy of the GNU General Public License
4299 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.