Fix compilation under GLYPH_DEBUG, broken by conditional tool_bar_window.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0d2647e6
EZ
12013-09-28 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
4 frame' does not have the tool_bar_window member.
5
ba355de0
BR
62013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
7
8 Signal error when reading an empty byte-code object (Bug#15405)
9 * lread.c (read1): signal error
10 * alloc.c (make_byte_code): eassert header size
11 (sweep_vectors): change an int to size_t
12
4710d6f4
PE
132013-09-24 Paul Eggert <eggert@cs.ucla.edu>
14
cf647d93
PE
15 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
16 instead of ints, as it's the usual style for offsetof constants. See:
17 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
18
4710d6f4
PE
19 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
20 This is ugly, but it should fix the performance problem for older
21 GCC versions in the short run. I'll look into integrating the
22 Gnulib module for popcount, as a better fix.
23 See the thread starting in:
24 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
25 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
26 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
27 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
28 (popcount_size_t): Use it.
29
10ebac9d
DC
302013-09-24 Daniel Colascione <dancol@dancol.org>
31
32 * process.c (Fnetwork_interface_info): Fix build break due to
33 vector changes.
34
9da0f50e
PE
352013-09-24 Paul Eggert <eggert@cs.ucla.edu>
36
37 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
38 Prefer signed to unsigned integers where either will do.
39 No need for 'const' on locals that do not escape.
40 Omit easserts with unnecessary and unportable assumptions about
41 alignment. Avoid unnecessary casts to char *.
42
d6d9cbc1
DA
432013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
44
45 Use union for the payload of struct Lisp_Vector.
46 This helps to avoid a few glitches dictated by C's aliasing rules.
47 * lisp.h (struct Lisp_Vector): Use union for next and
48 contents member. Adjust comment. Change related users.
49 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
50 Related users changed.
51 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
52 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
53 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
54 * xfaces.c, xfont.c, xmenu.c: Related users changed.
55
ec7bc82f
DA
562013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
57
58 Optimize glyph row clearing and copying routines.
59 * dispextern.h (struct glyph_row): Change layout of struct
60 glyph_row to help copy_row_except_pointers. Adjust comment.
61 * dispnew.c (null_row): Remove.
62 (clear_glyph_row): Use offsetof and memset to find and clear
63 just the members that need clearing. Adjust comment.
64 (copy_row_except_pointers): Likewise for copying.
65
d160dd0c
PE
662013-09-24 Paul Eggert <eggert@cs.ucla.edu>
67
7be68de5
PE
68 Some minor cleanups of recently-added bool vector code.
69 * conf_post.h (assume): Always return void. Use lint version
70 only if GCC and MSC versions don't apply.
71 * conf_post.h (assume):
72 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
73 Depend on _MSC_VER, not __MSC_VER, for consistency with
74 the rest of Emacs.
75 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
76 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
77 (bool_vector_binop_driver, count_trailing_zero_bits)
78 (size_t_to_host_endian): Now static, not static inline;
79 the latter isn't needed with modern compilers and doesn't
80 work with older compilers anyway.
81
d160dd0c
PE
82 * alloc.c (valgrind_p): Use bool for boolean.
83
e08813d0
DA
842013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
85
86 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
87 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
88 (display_last_displayed_message_p, message_buf_print)
89 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
90 Use bool for boolean.
3a6a78fd
DA
91 * dispextern.h (cancel_line, init_desired_glyphs):
92 Remove ancient leftover.
93 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
94 * lisp.h (noninteractive_need_newline): Adjust declaration.
95
5492865b
DA
962013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
97
98 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
99 Move to...
100 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
101 ...this file and convert the latter to static. Adjust comment.
102 (make_initial_frame):
103 * window.c (init_window_once): Adjust user.
104 * frame.h (last_nonminibuf_frame): Remove declaration.
105 * lisp.h (selected_frame): Likewise.
106 * msdos.c (the_only_display_info): Adjust comment.
107
cd548fa4
EZ
1082013-09-23 Eli Zaretskii <eliz@gnu.org>
109
f03eddbf
EZ
110 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
111 computing the end column of mouse-highlight that comes from
112 display or overlay strings. (Bug#15437)
b519df23
EZ
113 (note_mouse_highlight): Adapt calculation of last argument to
114 mouse_face_from_string_pos to the above change.
f03eddbf 115
cd548fa4
EZ
116 * conf_post.h (__has_builtin): Define to zero, if undefined, on
117 all platforms, not just for clang.
118
8762e524
JD
1192013-09-23 Jan Djärv <jan.h.d@swipnet.se>
120
121 * filelock.c (lock_file_1): Rearrange to remove compiler warning
122 about excess arguments to snprintf.
123
124 * conf_post.h(assume): Use __builtin_unreachable for clang.
125
d4a9284f
JB
1262013-09-23 Juanma Barranquero <lekktu@gmail.com>
127
128 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
129 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
130
a84683fd
DC
1312013-09-23 Daniel Colascione <dancol@dancol.org>
132
133 * alloc.c (USE_VALGRIND): New macro; on by default
134 when ENABLE_CHECKING.
135 (mark_maybe_object,mark_maybe_pointer)
136 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
137 valgrind purposes.
138 (valgrind_p) [USE_VALGRIND]: New variable.
139 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
140
8fef36c6
JD
1412013-09-22 Jan Djärv <jan.h.d@swipnet.se>
142
fb83ea63
JD
143 * process.c (wait_reading_process_output): Change int pnamelen to
144 socklen_t.
145
146 * nsterm.m (setMarkedText:selectedRange:):
147 (deleteWorkingText):
148 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
149 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
150 argument to unsigned long to avoid warning.
151 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
152
8fef36c6
JD
153 * conf_post.h (assume): Fix compiler error: x shall be cond.
154
cd9356f2
DC
1552013-09-22 Daniel Colascione <dancol@dancol.org>
156
157 * xfns.c (x_get_monitor_attributes): Suppress unused variable
158 warning when compiling without a window system.
159
3e0b94e7
DC
1602013-09-22 Daniel Colascione <dancol@dancol.org>
161
162 * data.c (Qbool_vector_p): New symbol.
163 (bool_vector_spare_mask,popcount_size_t_generic)
164 (popcount_size_t_msc,popcount_size_t_gcc)
165 (popcount_size_t)
166 (bool_vector_binop_driver)
167 (count_trailing_zero_bits,size_t_to_host_endian)
168 (Fbool_vector_exclusive_or)
169 (Fbool_vector_union)
170 (Fbool_vector_intersection,Fbool_vector_set_difference)
171 (Fbool_vector_subsetp,Fbool_vector_not)
172 (Fbool_vector_count_matches)
173 (Fbool_vector_count_matches_at): New functions.
174 (syms_of_data): Intern new symbol, functions.
175 * alloc.c (bool_vector_payload_bytes): New function.
176 (Fmake_bool_vector): Instead of calling Fmake_vector,
177 which performs redundant initialization and argument checking,
178 just call allocate_vector ourselves. Make sure we clear any
179 terminating padding to zero.
180 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
181 instead of open-coding the size calculation.
182 (vroundup_ct): New macro.
183 (vroundup): Assume argument >= 0; invoke vroundup_ct.
184 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
185 * composite.c (composition_gstring_put_cache): Change
186 lint_assume to assume.
187 * conf_post.h (assume): New macro.
188 (lint_assume): Remove.
189 * dispnew.c (update_frame_1): Change lint_assume to assume.
190 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
191 to assume.
192 * image.c (gif_load): Change lint_assume to assume.
193 * lisp.h (eassert_and_assume): New macro.
194 (Qbool_vector_p): Declare.
195 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
196 (swap16,swap32,swap64): New inline functions.
197 * macfont.c (macfont_shape): Change lint_assume to assume.
198 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
199 * xsettings.c (parse_settings): Use new swap16 and
200 swap32 from lisp.h instead of file-specific macros.
201
76880d88
EZ
2022013-09-22 Eli Zaretskii <eliz@gnu.org>
203
204 * xdisp.c (try_window_id): Don't abort if cursor row could not be
205 found (which can legitimately happen when the glyph row at the
206 window start is disabled in the current_matrix. (Bug#15365)
207
c6cfd910
PE
2082013-09-22 Paul Eggert <eggert@cs.ucla.edu>
209
210 Fix syntax.h bug introduced by recent INLINE change.
211 syntax.h defined an extern inline function SYNTAX_ENTRY that was
212 conditionally compiled one way in some modules, and a different
213 way in others. This doesn't work with extern inline functions,
214 which must have the same definition in all modules, because the
215 defining code might be shared across modules, depending on the
216 implementation. Symptoms reported by Martin Rudalics in:
217 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
218 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
219 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
220 overriding the corresponding functions in syntax.h.
221 * syntax.h (syntax_property_entry, syntax_property_with_flags)
222 (syntax_property): New inline functions.
223 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
224 Rewrite in terms of these new functions.
225
b3f1d119
EZ
2262013-09-21 Eli Zaretskii <eliz@gnu.org>
227
228 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
229 not chars_in_text, whose result depends on the multibyteness of
230 the current buffer. (Bug#15426)
231
00382e8b
PE
2322013-09-20 Paul Eggert <eggert@cs.ucla.edu>
233
e3b29769
PE
234 Port recent change to hosts where pointers aren't 'long'.
235 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
236 Don't assume that pointers are the same width as 'long'.
237 Add a compile-time check that a pointer fits into two X slots.
238
00382e8b
PE
239 A simpler, centralized INLINE.
240 * conf_post.h (INLINE): Define only if not already defined.
241 This allows us to use a single INLINE, defined by one file
242 per executable.
243 * emacs.c (INLINE): Define it.
244 Also, include category.h, charset.h, composite.h, dispextern.h,
245 syntax.h, systime.h, so that their INLINE definitions are expanded
246 properly for Emacs.
247 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
248 * buffer.h, buffer.c (BUFFER_INLINE):
249 * category.h, category.c (CATEGORY_INLINE):
250 * character.h, character.c (CHARACTER_INLINE):
251 * charset.h, charset.c (CHARSET_INLINE):
252 * composite.h, composite.c (COMPOSITE_INLINE):
253 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
254 * frame.h, frame.c (FRAME_INLINE):
255 * intervals.h, intervals.c (INTERVALS_INLINE):
256 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
257 * lisp.h, alloc.c (LISP_INLINE):
258 * process.h, process.c (PROCESS_INLINE):
259 * syntax.h, syntax.c (SYNTAX_INLINE):
260 * systime.h, sysdep.c (SYSTIME_INLINE):
261 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
262 * window.h, window.c (WINDOW_INLINE):
263 Remove. All uses replaced with INLINE.
264
2b943ba6
DA
2652013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
266
267 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
268 to avoid Bug#15398.
269
13d9698a
EZ
2702013-09-19 Eli Zaretskii <eliz@gnu.org>
271
272 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
273 'const char *' to avoid compiler warnings due to similar change in
274 the prototype of x_get_string_resource.
275
ced135eb
DA
2762013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
277
278 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
279 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
280 going to replace static variables below. Adjust comments.
281 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
282 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
283 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
284 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
285 Related users changed.
286 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
287 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
288 last_mouse_movement_time, going to replace static variables below.
289 Adjust comments.
290 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
291 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
292 Remove.
293 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
294 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
295 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
296 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
297 static variables below.
298 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
299 (last_mouse_scroll_bar): Remove.
300 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
301 (mouseExited): Related users changed.
302
091f1e1f
DA
3032013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
304
305 Do not use external array to process X scroll bar messages.
306 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
307 (x_send_scroll_bar_event): Pack window pointer into two slots
308 of XClientMessageEvent if we're 64-bit. Adjust comment.
309 (x_scroll_bar_to_input_event): Unpack accordingly.
310
582ed56c
DA
3112013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
312
313 Ifdef away recent changes which aren't relevant to NS port.
314 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
315 [!HAVE_NS]: Declare as such.
316 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
317 [!HAVE_NS]: Define as such.
318
18da0d8a
DA
3192013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
320
321 * frame.c (x_redo_mouse_highlight): New function
322 to factor out common code used in W32 and X ports.
323 * dispextern.h (x_redo_mouse_highlight): Add prototype.
324 * xterm.h (struct x_display_info):
325 * w32term.h (struct w32_display_info):
326 * nsterm.h (struct ns_display_info): New members
327 last_mouse_motion_frame, last_mouse_motion_x and
328 last_mouse_motion_y, going to replace static variables below.
329 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
330 (redo_mouse_highlight): Remove.
331 (note_mouse_movement, syms_of_xterm): Adjust user.
332 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
333 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
334 (redo_mouse_highlight): Remove.
335 (note_mouse_movement, syms_of_w32term): Adjust user.
336 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
337 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
338 Remove.
339 (note_mouse_movement, mouseMoved, syms_of_nsterm):
340 * nsfns.m (compute_tip_xy): Adjust user.
341
7a0c745a
DA
3422013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
343
344 * frame.c (x_mouse_grabbed): New function.
345 * dispextern.h (x_mouse_grabbed): Add prototype.
346 (last_mouse_frame): Remove declaration.
347 * xterm.h (struct x_display_info):
348 * w32term.h (struct w32_display_info):
349 * nsterm.h (struct ns_display_info): New member
350 last_mouse_frame, going to replace...
351 * xdisp.c (last_mouse_frame): ...global variable.
352 (note_tool_bar_highlight):
353 * w32term.c (w32_mouse_position, w32_read_socket):
354 * xterm.c (XTmouse_position, handle_one_xevent):
355 Use x_mouse_grabbed.
356 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
357
0791d107
DA
3582013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
359
360 * w32term.c (w32_read_socket): Avoid temporary
361 variables in a call to x_real_positions.
362 * xterm.c (handle_one_xevent): Likewise.
363
2cd98812
DA
3642013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
365
366 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
367 (x_icon_type): Remove prototype.
368 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
369 * frame.c (x_icon_type): Remove.
370 * w32term.c (x_make_frame_visible, x_iconify_frame):
371 * xterm.c (x_make_frame_visible, x_iconify_frame):
372 Use x_set_bitmap_icon to factor out common code.
373
a6c2ee1b
DA
3742013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
375
376 * dispextern.h (check_x_display_info, x_get_string_resource):
377 Declare here just once and unify the latter.
378 * frame.c (check_x_display_info, x_get_string_resource):
379 * nsterm.h (check_x_display_info):
380 * xrdb.c (x_get_string_resource):
381 * xterm.h (check_x_display_info): Remove prototypes.
382 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
383 * w32reg.c (x_get_string_resource): Likewise.
384 (w32_get_rdb_resource): Adjust user.
385
baed3603
DA
3862013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
387
388 * xterm.h (struct x_display_info): New member
389 x_pending_autoraise_frame, going to replace...
390 * xterm.c (pending_autoraise_frame): ...static variable.
391 (x_new_focus_frame, XTread_socket): Adjust users.
392 * w32term.h (struct w32_display_info): New member
393 w32_pending_autoraise_frame, going to replace...
394 * w32term.c (pending_autoraise_frame): ...global variable.
395 (x_new_focus_frame, w32_read_socket): Adjust users.
396
90582f05
GM
3972013-09-17 Glenn Morris <rgm@gnu.org>
398
399 * xdisp.c (message_dolog): If we create *Messages*,
400 switch it to messages-buffer-mode.
401
b7ad2f74
PE
4022013-09-17 Paul Eggert <eggert@cs.ucla.edu>
403
404 Don't overuse 'const' in types of locals.
405 * bidi.c (bidi_count_bytes):
406 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
407 (xg_event_is_for_scrollbar):
408 * xselect.c (x_handle_property_notify)
409 (x_handle_selection_notify, x_handle_dnd_message):
410 * xsettings.c, xsettings.h (xft_settings_event):
411 * xterm.c (x_handle_net_wm_state, handle_one_event)
412 (x_menubar_window_to_frame, x_detect_focus_change)
413 (construct_mouse_click, note_mouse_movement)
414 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
415 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
416 (handle_one_xevent, x_handle_net_wm_state):
417 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
418 (x_handle_dnd_message):
419 Avoid unnecessary 'const', typically the second 'const' in
420 'const foo * const arg', a 'const' that does not affect the API
421 and doesn't significantly help the human reader.
422
19452b86
DA
4232013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
424
425 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
426 only if Glib < 2.36.0.
427 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
428 * xsettings.c (init_gconf, init_gsettings): Do not check
429 for g_type_init.
1893694e
DA
430 * xterm.c (handle_one_xevent): Do not call to x_clear_area
431 if GTK >= 2.7.0.
33b83dd7 432 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 433
6434e343
JD
4342013-09-16 Jan Djärv <jan.h.d@swipnet.se>
435
3f386383
JD
436 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
437 before calling g_type_init.
438
6434e343
JD
439 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
440
441 * nsterm.m (syms_of_nsterm): ... to here.
442
83a119f8
DA
4432013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
444
445 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
446 (ignore_next_mouse_click_timeout): Use Time as X does.
447 (handle_one_xevent): Avoid cast and use unsigned comparison.
448
61582e6a
DA
4492013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
450
451 Do not copy X event in handle_one_xevent except KeyPress case.
452 Wnen XEvent is processed, it is unlikely to be changed except
453 KeyPress case, so we can avoid copying and use const pointer to
454 const data to make sure that an event is not changed elsewhere.
455 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
456 const' and do not create local copy except for the KeyPress event.
457 Use casts to avoid a few glitches. Adjust formatting. Add comments.
458 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
459 (x_handle_net_wm_state, x_menubar_window_to_frame)
460 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
461 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
462 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
463 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
464 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
465 (x_handle_dnd_message):
466 * xsettings.c (xft_settings_event):
467 Use 'const XEvent * const' where appropriate.
468 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
469
f8eb1572
DA
4702013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Fix X event waiting to handle multiple frames.
473 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
474 * xterm.c (pending_event_wait): Remove. Adjust users.
475 (x_detect_focus_change): Pass frame arg.
476 (handle_one_xevent): Find related frame early and clear per-frame
477 wait_event_type only if this is an event for the relevant frame.
478 (x_wait_for_event): Use per-frame wait_event_type.
479
3fa2054e
JD
4802013-09-15 Jan Djärv <jan.h.d@swipnet.se>
481
745d3809
JD
482 * nsfns.m (Fx_create_frame): Fix font driver registration for
483 GNUStep.
484
485 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
486 for syms_of_macfont.
487
3fa2054e
JD
488 * nsterm.m: Include macfont.h.
489 (ns_tmp_flags, ns_tmp_font): Remove.
490 (ns_compute_glyph_string_overhangs): Check for driver Qns.
491 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
492 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
493 (changeFont:): Fix code style. Check for font driver type when
494 getiing font.
495
496 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
497 (f)->descent.
498
499 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
500 (nsfont_open): Set font driver type.
501 Set font->ascent and font->descent. Figure out font instead of
502 ns_tmp_font, and flags instead of ns_tmp_flags.
503 Fix indentation. Remove call to ns_draw_text_decoration,
504 moved to nsterm.
505
506 * nsfns.m: Include macfont.h.
507 (Fx_create_frame): Register macfont driver, make a better default font.
508 (Fns_popup_font_panel): Get font from macfont driver, if used.
509
510 * macfont.m, macfont.h, maccuvs.h: New files.
511
512 * font.h: Declare syms_of_macfont.
513
514 * font.c (syms_of_font): Call syms_of_macfont.
515
516 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
517
0eed0355
DA
5182013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
521 and it is always zero for others, so I assume that this is an ancient
522 leftover which nobody will want to change any more.
523 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
524 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
525 * frame.c (x_set_scroll_bar_width):
526 * w32fns.c (w32_createscrollbar):
527 * w32term.c (w32_set_vertical_scroll_bar):
528 * xfns.c (x_set_scroll_bar_default_width):
529 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
530 (x_scroll_bar_expose): Related users changed.
531
07013c68
DA
5322013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
533
534 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
535 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
536 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
537 Define as such.
c7cc32f7
DA
538 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
539 Define once here...
540 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
541 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
542 Remove unused Xisms.
7f09455e
DA
543 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
544 these modules are never compiled otherwise.
07013c68 545
0df00f59
EZ
5462013-09-14 Eli Zaretskii <eliz@gnu.org>
547
08a209bf 548 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
549 Doc fix. (Bug#15375)
550
fcd42c11
DA
5512013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
552
553 Unify Fx_focus_frame between all ports.
554 * frame.h (x_focus_frame): New prototype.
555 * xfns.c (Fx_focus_frame): Remove.
556 (syms_of_xfns): Do not defsubr it.
557 (x_focus_frame): X implementation.
558 * nsfns.m (Fx_focus_frame): Remove.
559 (syms_of_nsfns): Do not defsubr it.
560 (x_focus_frame): NS implementation.
561 * w32term.c (Fx_focus_frame): Remove.
562 (x_focus_on_frame): Rename to...
563 (x_focus_frame): W32 implementation.
564 * w32term.h (x_focus_on_frame): Remove prototype.
565 * w32fns.c (Fx_focus_frame): Remove.
566 (syms_of_w32fns): Do not defsubr it.
567 * frame.c (Fx_focus_frame): Define here.
568 (syms_of_frame): Defsubr here.
569 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
570
aad3612f
DA
5712013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
572
573 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
574 All of them are replaced with FRAME_DISPLAY_INFO, defined in
575 each port to reference the port-specific window system data.
576 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
577 (FRAME_DISPLAY_INFO): Define.
578 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
579 (FRAME_DISPLAY_INFO): Define. Adjust users.
580 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
581 (FRAME_DISPLAY_INFO): Define. Adjust users.
582 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
583 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
584 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
585 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
586 * xselect.c, xterm.c: All related users changed.
587
9a650e62
DA
5882013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
589
590 * xterm.h (x_window_to_frame, x_any_window_to_frame)
591 (x_menubar_window_to_frame): Remove prototypes.
592 * xfns.c (x_window_to_frame, x_any_window_to_frame)
593 (x_menubar_window_to_frame, x_top_window_to_frame):
594 Move from here...
595 * xterm.c (x_window_to_frame, x_any_window_to_frame)
596 (x_menubar_window_to_frame, x_top_window_to_frame):
597 ...to here and convert all but the last to static.
598
347ae3e1
EZ
5992013-09-12 Eli Zaretskii <eliz@gnu.org>
600
601 * lisp.mk (lisp): Add w32-common-fns.elc.
602
15c6d837
XF
6032013-09-12 Xue Fuqiao <xfq.free@gmail.com>
604
605 * charset.c (char_charset): Document an exception for char-charset.
606
27e90f77
DA
6072013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
608
609 * xterm.h (x_display_info): New field last_user_time...
610 * xterm.c (toplevel): ...to replace static last_user_time.
611 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
612
8ffbc36b
DA
6132013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
614
615 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
616 scroll bar values to prevent thumb from disappear and update comment.
617
5ec0337a
GM
6182013-09-11 Glenn Morris <rgm@gnu.org>
619
620 * emacs.c (usage_message): Possessive apostrophe tweak.
621
fb55b9d1
DA
6222013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
623
8d2db8be
DA
624 * nsterm.m (syms_of_nsterm): Use Qns.
625 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
626 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
627 * xfns.c (x_display_info_for_name, Fx_open_connection):
628 Remove old '#if 0' code.
629 (syms_of_xfns): Use Qx.
fb55b9d1
DA
630 * termhooks.h (fullscreen_hook): Remove the leftover.
631 (struct terminal): Fix typo in comment.
632
927eec55
DA
6332013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Cleaning up a few X scroll bar bits.
636 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
637 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
638 New member last_seen_part, going to replace...
639 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
640 (xt_action_hook) [USE_LUCID]: Adjust user.
641 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
642 Lucid-specific scroll bar support.
643 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
644 to int and adjust to use last_seen_part member.
645 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
646 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
647 Initialize last_seen_part.
648
71b28baa
SM
6492013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
650
651 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
652 insert-buffer-substring an empty string.
653
f5dacaae
PE
6542013-09-11 Paul Eggert <eggert@cs.ucla.edu>
655
656 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
657 avoiding a GCC warning.
658
742516e0
DA
6592013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
660
661 Ifdef away frame tool bar code when it is not really used.
662 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
663 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
664 and minimize_tool_bar_window_p under the above.
665 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
666 (fset_tool_bar_window): Likewise.
667 * dispnew.c (clear_current_matrices, clear_desired_matrices)
668 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
669 (change_frame_size_1):
670 * window.c (window_from_coordinates, Frecenter): Adjust users.
671 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
672 code is not really used.
673 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
674 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
675 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
676 [!USE_GTK && !HAVE_NS]: Define as such.
677 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
678 (note_mouse_highlight, expose_frame):
679 * xfns.c (x_set_tool_bar_lines):
680 * xterm.c (handle_one_xevent): Adjust users.
681
73f82c7e
PE
6822013-09-11 Paul Eggert <eggert@cs.ucla.edu>
683
684 Fix corruption with multiple emacsclient -t instances (Bug#15222).
685 This bug was introduced by my 2013-08-26 patch, which incorrectly
686 assumed that the terminfo implementation doesn't use termcap buffers.
687 * term.c (init_tty) [TERMINFO]: Remove optimization, as
688 these buffers apparently are used after all.
689 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
690 (struct tty_display_info): Define members termcap_term_buffer and
691 termcap_strings_buffer even if TERMINFO.
692
53482f41
DA
6932013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
694
695 Fix last change.
696 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
697 'usage' docstring entry to pacify make-docfile.
698
6992013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
700
701 Change comparison functions =, <, >, <=, >= to take many arguments.
702 * data.c: Change comparison functions' interface and implementation.
703 * lisp.h: Make arithcompare available for efficient two arg
704 comparisons.
705 * bytecode.c: Use arithcompare.
706 * fileio.c: Use new interface.
707
533f258f
SM
7082013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
709
710 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
711
8c27f5ff
SM
7122013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
713
714 * eval.c (Feval): Document the new use of `lexical'.
715
0750a308
DA
7162013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
717
718 Review and drop old frame resize hack.
719 * frame.h (struct frame): Remove force_flush_display_p.
720 * dispnew.c (update_frame): Adjust user and don't call
721 flush_frame here. The comment has said that there was an issues
722 with redisplaying fringes, but I don't see any differences with
723 and without this hack. Hopefully we can continue without it.
724 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
725 current frame matrices twice if resized_p is set.
726
83fc0554
DA
7272013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
728
729 Do not populate pure Xism x_sync to other ports.
730 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
731 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
732 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
733 * w32term.h (x_sync): Remove prototype.
734
fd462129
DA
7352013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
736
737 Cleanup frame flushing.
8c27f5ff
SM
738 * dispextern.h (struct redisplay_interface):
739 Drop flush_display_optional because flush_display is enough
fd462129
DA
740 for X and flushing via RIF is just a no-op for others.
741 * frame.h (flush_frame): New function.
742 * dispnew.c (update_frame):
743 * minibuf.c (read_minibuf):
744 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
745 Use it.
746 * keyboard.c (detect_input_pending_run_timers): Do not flush
747 all frames but selected one in redisplay_preserve_echo_area.
748 * nsterm.m (ns_flush): Remove no-op.
749 (ns_redisplay_interface): Adjust user.
750 * w32term.h (x_flush): Remove no-op.
751 (w32_redisplay_interface): Adjust user.
752 * xterm.c (x_flush): Simplify because we do not flush all
753 frames at once any more. Adjust comment.
754 (x_redisplay_interface): Adjust user.
755
4b73fc73
PE
7562013-09-07 Paul Eggert <eggert@cs.ucla.edu>
757
758 Port --without-x --enable-gcc-warnings to Fedora 19.
759 * gfilenotify.c (globals_of_gfilenotify):
760 Call g_type_init only if using an older glib version that needs it.
761
77394d40
DA
7622013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
763
764 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
765 (last_glyphless_glyph_merged_face_id): Remove declarations.
766 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
767 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
768 (last_glyphless_glyph_merged_face_id): Now static.
769 (merge_escape_glyph_face): New function, refactored from...
770 (get_next_display_element): ...here.
771 (merge_glyphless_glyph_face): New function, refactored from...
772 (produce_glyphless_glyph): ...here...
773 * term.c (produce_glyphless_glyph): ...and here.
774
306d67bd
SM
7752013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
776
777 * eval.c (eval_sub): Only call Ffunction if necessary.
778
7f6c6450
DA
7792013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
780
781 Attempt to make redisplay more selective when changing cursor type.
782 * frame.h (struct frame): New bitfield cursor_type_changed.
783 * xdisp.c (cursor_type_changed): Remove.
784 (try_cursor_movement, redisplay_window, try_window_id)
785 (set_frame_cursor_types, try_window_reusing_current_matrix):
786 Adjust to use per-frame bitfield.
787 (redisplay_internal): Look for cursor type change on each visible
788 frame and consider all frames if cursor type has been changed on
789 the frame other than selected. If cursor type has been changed on
790 selected frame only, do not use fast update.
791
bd0443bb
DA
7922013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
793
794 Attempt to make redisplay more selective when changing fonts.
795 * frame.h (struct frame): New bitfield fonts_changed.
796 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
797 (adjust_frame_glyphs): Add prototype.
798 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 799 (adjust_glyphs): Remove because we do not
bd0443bb
DA
800 adjust matrices on all frames at once any more.
801 (adjust_frame_glyphs): Block and unblock input here.
802 (adjust_glyph_matrix): Use fonts_changed.
803 (change_frame_size_1): Use adjust_frame_glyphs.
804 * font.c (font_open_entity): Use fonts_changed.
805 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
806 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
807 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
808 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
809 (shrink_mini_window, Fresize_mini_window_internal)
810 (window_scroll_pixel_based, Fset_window_configuration)
811 (apply_window_adjustment, Fset_window_vscroll):
812 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
813 Use adjust_frame_glyphs.
814 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
815 (try_window_reusing_current_matrix, try_window_id, display_line)
816 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
817 (redisplay_internal): Consider fonts_changed and adjust frame
818 matrices for each frame only if the frame is visible. If font
819 has been changed on some frame during full redisplay, retry
820 only visible frames where the font has been actually changed.
821
b9695828
DA
8222013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
823
824 Cache current header and mode line height for each window.
825 * window.h (struct window): New fields mode_line_height
826 and header_line_height.
827 * window.c (make_window): Initialize them.
828 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
829 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
830 (current_mode_line_height, current_header_line_height):
831 Remove declaration.
832 * xdisp.c (current_mode_line_height, current_header_line_height):
833 Remove.
834 (pos_visible_p, init_xdisp): Adjust user.
835 (redisplay_window): Invalidate mode_line_height and
836 header_line_height if current and desired matrices do not agree.
837
66738305
DA
8382013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
839
840 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
841 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
842
257b3b03
DA
8432013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
844
845 Make --without-x compatible with --enable-gcc-warnings.
846 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
847 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
848 members under HAVE_WINDOW_SYSTEM.
849 * keyboard.c (make_lispy_focus_out): Likewise.
850 (record_menu_key): Move under HAVE_MENUS.
851 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
852 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
853 (syms_of_xdisp): Adjust user.
854 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
855 (start_hourglass, cancel_hourglass):
856 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
857 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
858 and CLEAR_FONT_TABLE_NFONTS.
859 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
860 Declare only if HAVE_WINDOW_SYSTEM.
861 (lface_same_font_attributes_p, clear_face_gcs): Define only
862 if HAVE_WINDOW_SYSTEM.
863
98b7f4bd
DA
8642013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
865
866 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
867 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
868 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
869
a7e43722
SM
8702013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
871
872 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
873
0c90b9ee
PE
8742013-09-04 Paul Eggert <eggert@cs.ucla.edu>
875
876 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
877 This fixes a type error on hosts where ptrdiff_t is wider than int.
878
d99760fa
SM
8792013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
880
6629638e
SM
881 * keyboard.c (read_key_sequence_vs): New function.
882 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
883 common code.
884
d99760fa
SM
885 * callint.c (Fcall_interactively): Always return a vector for 'K'.
886
224e313d
PE
8872013-09-04 Paul Eggert <eggert@cs.ucla.edu>
888
889 Makefile improvements.
890 * Makefile.in (config.status): Don't use double-colon rules, as
891 they are not portable according to POSIX. Fix shell typo with `;
892 I guess this rule has never been tested?
893 (VCSWITNESS): New macro, to override any environment var.
894
6d6ed1af
DA
8952013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
896
897 * xterm.h (struct x_display_info): Do not track X connection
898 fd separately because it is always available from Display.
899 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
900 Adjust users.
901
bc923770
DA
9022013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
903
904 * buffer.c (drop_overlay):
905 * fileio.c (restore_point_unwind): Prefer unchain_marker to
906 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
907
b1cf96de
DA
9082013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
909
910 * buffer.c (Fmake_overlay, Fmove_overlay):
911 * intervals.c (set_point_from_marker):
912 * print.c (PRINTPREPARE): Prefer signal_error
913 to plain error and report unsuitable marker too.
914
d1fc6c21
DA
9152013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
916
917 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
918 for 'dragging' member.
d1ae6a0b
DA
919 (struct x_output): Remove set-but-unused leftovers
920 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
921 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
922 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
923 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
924 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
925 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
926 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 927 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 928 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 929
0ce9f6de
JD
9302013-09-03 Jan Djärv <jan.h.d@swipnet.se>
931
932 * nsfont.m (INVALID_GLYPH): New define.
933 (nsfont_encode_char): Use INVALID_GLYPH.
934 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
935
b594a96c
DA
9362013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
937
938 * xterm.c (x_last_mouse_movement_time): Revert last change.
939 This code should use XDisplayMotionBufferSize to check display's
940 motion history first, and there are few other issues as well.
941 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
942 (handle_one_xevent): Adjust user.
943
8b098236
MR
9442013-09-02 Martin Rudalics <rudalics@gmx.at>
945
9718b207
MR
946 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
947 * frame.c (Flast_nonminibuf_frame): ... to here.
948 (check_minibuf_window): Don't abort if no window was found
949 (Bug#15247).
8b098236 950
84e70bba
DA
9512013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
952
953 Use XGetMotionEvents to ask the last mouse motion time from X server.
954 * xterm.c (X_MOTION_HISTORY): Default to 1.
955 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
956 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
957 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
958 Ifdef away legacy code.
959 (XTmouse_position, x_scroll_bar_report_motion):
960 Use x_last_mouse_movement_time.
fc85e20b
DA
961 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
962 UnmapNotify event.
84e70bba 963
1fccc530
DA
9642013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
965
966 * msdos.c (last_mouse_window): Move to...
967 (dos_rawgetc): ...this function and adjust comment.
968 * nsterm.m (last_window): Rename to last_mouse_window, move to...
969 (mouseMoved): ...this function and adjust comment.
970 * w32term.c (last_window): Likewise with...
971 (w32_read_socket): ...this function.
972 * xterm.c (last_window): Likewise with...
973 (handle_one_xevent): ...this function.
974
0ab10992
DA
9752013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
976
b7da754d 977 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
978 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
979 (handle_one_xevent): ...to here.
980 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
981 otherwise.
982
0c7f856e
DA
9832013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
984
985 * msdos.c (IT_set_terminal_window): Remove no-op.
986 (initialize_msdos_display): Adjust terminal setup.
987 * w32console.c (w32con_set_terminal_window): Remove no-op.
988 (initialize_w32_display): Adjust terminal setup.
989 * w32term.c (w32_set_terminal_window): Remove no-op.
990 (w32_create_terminal): Adjust terminal setup.
991 * xterm.c (XTset_terminal_window): Remove no-op.
992 (x_create_terminal): Adjust terminal setup.
993
a892a94c
DA
9942013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
995
996 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
997 Remove no-ops.
998 (ns_create_terminal): Adjust terminal setup.
999 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1000 Remove no-ops.
1001 (w32_create_terminal): Adjust terminal setup.
1002 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1003 Remove no-ops.
1004 (x_create_terminal): Adjust terminal setup.
1005
cf91889a
DA
10062013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1007
1008 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1009 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1010 * dispnew.c (buffer_posn_from_coords):
1011 * window.c (Fwindow_end, displayed_window_lines):
1012 * xdisp.c (redisplay_mode_lines): Use it.
1013
5b0891df
JD
10142013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1015
1016 * fontset.c (face_for_char): Check char in the current face font first
1017 if HAVE_NS (Bug#15138).
1018
0a357e98
MR
10192013-08-31 Martin Rudalics <rudalics@gmx.at>
1020
1021 * window.c (temp_output_buffer_show): Make sure window returned
1022 by display_buffer is live (Bug#15213).
1023
9d7693d7
DA
10242013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1025
1026 Minor cleanup to avoid forward declarations.
1027 * coding.h (struct ccl_spec): Remove forward declaration.
1028 * composite.h (toplevel): Include font.h.
1029 (struct composition_it, struct face, struct font_metrics):
1030 Remove forward declaration.
1031 * dispextern.h (struct image, struct atimer): Likewise.
1032 * emacsgtkfixed.h (struct frame): Likewise.
1033 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1034 * font.h (struct font_driver, struct font, struct glyph_string)
1035 (struct face): Remove forward declaration.
1036 * fontset.h (struct face, struct font): Likewise.
1037 * frame.h (toplevel): Style cleanup.
1038 (enum output_method): Move to...
1039 * termhooks.h (enum output_method): ...here.
1040 (struct glyph, struct frame, struct ns_display_info)
1041 (struct x_display_info, struct w32_display_info):
1042 Remove forward declaration.
1043 * xterm.h (toplevel): Include termhooks.h.
1044 (struct font, struct window, struct glyph_matrix, struct frame)
1045 (struct input_event, struct face, struct image): Remove forward
1046 declaration.
1047 * gtkutil.h (struct _widget_value): Likewise.
1048 * keyboard.h (toplevel): Include termhooks.h.
1049 (struct input_event): Remove forward declaration.
1050
032f7451
DA
10512013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1052
1053 * intervals.c (set_point_from_marker): New function.
1054 * editfns.c (Fgoto_char):
1055 * process.c (Finternal_default_process_filter):
1056 * window.c (select_window_1): Use it.
1057 * buffer.h (set_point_from_marker): Add prototype.
1058
3f940c5a
EZ
10592013-08-29 Eli Zaretskii <eliz@gnu.org>
1060
1061 * w32.c (term_winsock): Call release_listen_threads before calling
1062 WSACleanup.
1063 (_sys_wait_accept): Wait for accept event in a loop with a finite
1064 timeout, instead of waiting indefinitely. Will hopefully avoid
1065 hanging during exit because WSACleanup deadlocks waiting for the
1066 event object to be released. (Bug#14333)
1067
1068 * w32proc.c (release_listen_threads): New function, signals all
1069 the reader threads that listen for connections to stop waiting.
1070
1071 * w32.h (release_listen_threads): Add prototype.
1072
101ed2bb
DA
10732013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1074
1075 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1076 field of new marker (for sanity and safety).
20de2834
DA
1077 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1078 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1079
1f5cf200
DA
10802013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1081
1082 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1083 (x_after_update_window_line, x_scroll_bar_create):
1084 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1085 (handle_one_xevent, x_clear_frame_area):
1086 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1087 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1088 * xterm.h (x_clear_area): Adjust prototype.
1089
d2b36813
DA
10902013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1091
1092 Hook scanning and indentation functions to find_newline. This helps
1093 to avoid duplicated code and renders more respect to newline cache.
1094 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1095 * cmds.c (Fforward_line):
1096 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1097 Use find_newline and avoid unnecessary point movements.
1098 * search.c (scan_newline): Implement on top of find_newline.
1099
3ec7babc
SM
11002013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1101
1102 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1103 scoped code (bug#11258).
1104
5ab473cd
JD
11052013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1106
1107 * nsterm.m (last_window): New variable.
1108 (EV_TRAILER2): New macro.
1109 (EV_TRAILER): Call EV_TRAILER2.
1110 (mouseMoved:): Add support for mouse-autoselect-window
1111 on nextstep (Bug#6888).
1112
78779650
AS
11132013-08-28 Andreas Schwab <schwab@suse.de>
1114
1115 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1116 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1117 Remove unused macro definitions.
1118 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1119 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1120 Only define if emacs.
78779650 1121
c3c4768d
DA
11222013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1123
1124 Prefer enum glyph_row_area to int where appropriate.
1125 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1126 Fix comment.
1127 (window_box, window_box_width, window_box_left, window_box_left_offset)
1128 (window_box_right, window_box_right_offset): Adjust prototypes.
1129 * xdisp.c (window_box, window_box_width, window_box_left)
1130 (window_box_left_offset, window_box_right, window_box_right_offset):
1131 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1132 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1133 * nsterm.m (ns_clip_to_row):
1134 * w32term.c (w32_clip_to_row):
1135 * xterm.c (x_clip_to_row): Likewise.
1136
6bdcbfe1
DA
11372013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1138
1139 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1140 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1141
50b13cde
PE
11422013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1145 for portability to hosts where /bin/sh has problems.
1146
f60e429a
DA
11472013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1148
1149 Redesign redisplay interface to drop global output_cursor.
1150 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1151 (toplevel): Remove declaration of output_cursor.
1152 (set_output_cursor, x_cursor_to): Remove prototype.
1153 * window.h (struct window): New member output_cursor.
1154 (output_cursor_to): New function to replace RIF member.
1155 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1156 (update_text_area, set_window_cursor_after_update): Use it.
1157 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1158 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1159 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1160 * w32term.c (x_update_window_begin, x_update_window_end):
1161 * xterm.c (x_update_window_begin, x_update_window_end):
1162 Adjust to use per-window output cursor.
1163
43aac990
PE
11642013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1165
d486344e
PE
1166 Simplify SELECT_TYPE-related code.
1167 Like EMACS_TIME, this portability layer is no longer needed, since
1168 Emacs has been using fd_set as a portability layer for some time.
1169 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1170 (SELECT_TYPE): Remove. All uses changed to fd_set.
1171 (fd_set) [!FD_SET]: New typedef.
1172
43aac990
PE
1173 Simplify EMACS_TIME-related code.
1174 This portability layer is no longer needed, since Emacs has been
1175 using struct timespec as a portability layer for some time.
1176 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1177 Include <time.h> rather than "systime.h"; that's all that's needed now.
1178 * dispnew.c: Include <timespec.h> rather than "systime.h";
1179 that's all that's needed now.
1180 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1181 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1182 TIMESPEC_RESOLUTION.
1183 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1184 LOG10_TIMESPEC_RESOLUTION.
1185 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1186 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1187 (make_emacs_time): Remove. All used changed to make_timespec.
1188 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1189 (current_timespec): Rename from current_emacs_time. All uses changed.
1190 (add_emacs_time): Remove. All uses changed to timespec_add.
1191 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1192 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1193 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1194 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1195 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1196 (current_timespec): Rename from current_emacs_time. All uses changed.
1197 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1198 changed to timespec_cmp.
1199 * xgselect.c: Include <timespec.h>, since our .h files don't.
1200
d350e350
DA
12012013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1202
1203 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1204 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1205 Remove the leftovers.
1206 * gtkutil.c (toplevel): Do not declare Qxft but include
1207 font.h to do so.
1208 * image.c (toplevel): Do not declare Vlibrary_cache because
1209 it's already done in lisp.h.
1210
9fed9729
DA
12112013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1212
1213 * lisp.h (Mouse_HLInfo): Move from here...
1214 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1215 (reset_mouse_highlight): New function.
1216 * msdos.c (dos_set_window_size, IT_update_begin)
1217 (internal_terminal_init):
1218 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1219 (ns_initialize_display_info):
1220 * w32console.c (initialize_w32_display):
1221 * w32term.c (x_update_window_end, x_free_frame_resources)
1222 (w32_initialize_display_info):
1223 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1224 * window.c (Fdelete_other_windows_internal):
1225 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1226 * termchar.h (toplevel):
1227 * xterm.h (toplevel): Include dispextern.h.
1228
f462f075
PE
12292013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1230
1231 Fix minor problems found by static checking.
1232 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1233 (expect): Avoid nested-if warning.
1234 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1235 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1236 * nsterm.h, nsterm.m (ns_select):
1237 * xgselect.c, xgselect.h (xg_select):
1238 Adjust signature to better match pselect's.
1239 * nsterm.m (ns_select):
1240 Don't set *TIMEOUT, since pselect doesn't.
1241 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1242 diagnostic about assigning const char * to it.
1243 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1244
068f9124
SM
12452013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1246
1247 * lread.c (substitute_object_recurse): Handle hash-tables as well
1248 (bug#15190).
1249
f5adc984
PE
12502013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1251
1fc8eb33
PE
1252 Fix unlikely core dump in init_tty, and simplify terminfo case.
1253 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1254 The old version incorrectly dumped core if malloc returned a
1255 buffer containing only non-NUL bytes.
1256 (init_tty): Do not allocate or free termcap buffers; the
1257 struct does that for us now.
1258 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1259 (struct tty_display_info): Define members termcap_term_buffer and
1260 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1261 use them. Allocate them directly in struct rather than indirectly
1262 via a pointer, to simplify init_tty.
1263
f5adc984
PE
1264 * frame.c (check_minibuf_window): Initialize 'window' properly,
1265 so that Emacs reliably aborts later if 'window' is not initialized.
1266
efec3894
JD
12672013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1268
1269 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1270 of VoidSymbol (Bug#15154).
1271
e1d0341e
DA
12722013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1273
1274 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1275 mouse_face_beg_y and mouse_face_end_y.
1276 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1277 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1278 Adjust users and update comment where appropriate.
1279
bfff6445
MR
12802013-08-26 Martin Rudalics <rudalics@gmx.at>
1281
1282 * frame.c (check_minibuf_window): New function.
068f9124
SM
1283 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1284 Call check_minibuf_window (Bug#15183).
bfff6445 1285
c80016b3
DA
12862013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1287
1288 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1289 because this is the only last cursor data we need to keep and consult.
1290 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1291 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1292 Adjust users.
1293
de396731
DA
12942013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1295
068f9124
SM
1296 Fix recovering from possible decompression error.
1297 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1298 the position where the partially decompressed data ends, and
447218dd 1299 should count how many bytes was produced so far.
de396731
DA
1300 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1301 (unwind_decompress): Really delete partially uncompressed data.
1302 (Fzlib_decompress_region): Take decompressed data size into account.
1303
c76826d9
DA
13042013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1305
1306 * syntax.c (init_syntax_once): Adjust comment and do an early
1307 initialization of Qchar_table_extra_slots just once...
1308 * casetab.c (init_casetab_once):
1309 * category.c (init_category_once):
1310 * character.c (syms_of_character):
1311 * coding.c (syms_of_coding):
1312 * xdisp.c (syms_of_xdisp): ...and omit it here.
1313
b34454d0
EZ
13142013-08-24 Eli Zaretskii <eliz@gnu.org>
1315
11f20add
EZ
1316 * xdisp.c (get_next_display_element): Don't apply to characters
1317 from a display vector the logic of setting it->end_of_box_run_p
1318 suitable for characters from a buffer. (Bug#15175)
1319
b34454d0
EZ
1320 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1321 to handle directories, rather than '_utime' which doesn't.
1322 (Bug#15176)
1323
6e1b469e
JD
13242013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1325
1326 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1327 or fullscreen (Bug#14627).
1328
9c05bccf
PE
13292013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 System-dependent integer overflow fixes.
1332 * process.c (Fset_process_window_size): Signal an error if
1333 the window size is outside the range supported by the lower level.
1334 * sysdep.c (set_window_size): Return negative on error,
1335 nonnegative on success, rather than -1, 0, 1 on not in system,
1336 failure, success. This is simpler. Caller changed.
1337 (serial_configure): Remove unnecessary initialization of local.
1338 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1339 size fits in unsigned long; this isn't true on some 32-bit hosts.
1340 Avoid buffer overrun if some future version of /proc/meminfo has a
1341 variable name longer than 20 bytes.
1342 (system_process_attributes) [__FreeBSD__]:
1343 Don't assume hw.availpages fits in 'int'.
1344
c365c355
PE
13452013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 Don't let very long directory names overrun the stack.
1348 Fix some related minor problems involving "//", vfork.
1349 * callproc.c (encode_current_directory): New function.
1350 (call_process): Don't append "/"; not needed.
1351 * fileio.c (file_name_as_directory_slop): New constant.
1352 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1353 this can save the caller having to alloca.
1354 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1355 Use SAFE_ALLOCA, not alloca.
1356 (directory_file_name, Fexpand_file_name): Leave leading "//"
1357 alone, since it can be special even on POSIX platforms.
1358 * callproc.c (call_process):
1359 * process.c (Fformat_network_address):
1360 * sysdep.c (sys_subshell):
1361 Use encode_current_directory rather than rolling our own.
1362 (create_process): No need to encode directory; caller does that now.
1363 * process.h (encode_current_directory): New decl.
1364 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1365 Rework to avoid 'goto xyzzy;'.
1366
6c6014d4
EZ
13672013-08-23 Eli Zaretskii <eliz@gnu.org>
1368
1369 * xdisp.c (handle_face_prop): If the default face was remapped use
1370 the remapped face for strings from prefix properties. (Bug#15155)
1371
9997ec56
DA
13722013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 Minor cleanup for redisplay interface and few related functions.
1375 * frame.h (enum text_cursor_kinds): Move from here...
1376 * dispextern.h (enum text_cursor_kinds): ...to here.
1377 (toplevel): Drop unnecessary declarations.
1378 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1379 in update_window_end_hook and draw_window_cursor functions.
1380 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1381 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1382 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1383 * xterm.c (x_update_window_end, x_draw_window_cursor):
1384 * xdisp.c (display_and_set_cursor, update_window_cursor)
1385 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1386 enum text_cursor_kinds where appropriate.
1387
7f780da6
DA
13882013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1389
1390 Redesign redisplay interface to drop updated_row and updated_area.
1391 * dispextern.h (updated_row, updated_area): Remove declaration.
1392 (struct redisplay_interface): Pass glyph row and row area parameters
1393 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1394 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1395 Adjust prototypes.
1396 * dispnew.c (updated_row, updated_area): Remove.
1397 (redraw_overlapped_rows, update_window_line): Adjust user.
1398 (update_marginal_area, update_text_area): Likewise. Pass updated row
1399 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1400 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1401 Adjust users.
1402
26495794
PE
14032013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 * process.c (flush_pending_output): Remove stub.
1406 All uses removed.
1407
4a88129a
PE
14082013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * callproc.c: Fix race that killed background processes (Bug#15144).
1411 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1412 Record deleted process-id in critical section, not afterwards.
1413 Don't mistakenly kill process created by a call-process invocation
1414 that discards output and does not wait.
1415
0c5307b0
DA
14162013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1417
1418 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1419 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1420 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1421 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1422 to shut up compiler in mark_object.
1423 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1424
0d7c1e66
PE
14252013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1426
1427 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1428 We can't portably rely on PTY_OPEN doing that, even if
1429 it calls posix_openpt with O_CLOEXEC.
1430
3f246b65
KH
14312013-08-20 Kenichi Handa <handa@gnu.org>
1432
1433 * character.c (string_char): Improve commentary.
1434
8c2f38aa
PE
14352013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1438 (struct animation_cache): Make signature a flexible array member.
1439 All uses changed. This is a tad slower but may insulate us better
1440 from future changes to ImageMagick.
1441
bb566cea
PE
14422013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1443
1444 * image.c: Shrink memory needed for animation cache.
1445 (SIGNATURE_DIGESTSIZE): New constant.
1446 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1447 (imagemagick_create_cache): Copy the signature. This saves
1448 several KB of memory that ImageMagick wastes per signature.
1449 Don't bother updating the update_time, as the caller does that now.
1450 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1451 it's a fixed size struct member now.
1452 (imagemagick_get_animation_cache): Always destroy the signature,
1453 as it's now imagemagick_create_cache's responsibility to copy it.
1454 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1455 and use memcmp rather than strcmp.
1456 eassert that ImageMagick returns a signature of the specified length.
1457
6da26928
LMI
14582013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1459
1460 * image.c (imagemagick_get_animation_cache): Don't segfault on
1461 each invocation.
453f4022
LMI
1462 (imagemagick_get_animation_cache): Revert to previous definition
1463 so that it actually works. But keep the memory leak fix.
1464 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1465
22490125
PE
14662013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1467
d0139df5
PE
1468 * image.c: Fix animation cache signature memory leak.
1469 Fix some other minor performance problems while we're at it.
1470 (imagemagick_create_cache): Clear just the members that
1471 need clearing. Don't set update_time, as caller does that now.
1472 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1473 Simplify by using pointer-to-pointer instead of a prev pointer.
1474 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1475 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1476 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1477 it's already a copy. Free the signature probe unless it's cached.
1478
22490125
PE
1479 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1480 This was introduced by my 2013-08-12 fix for Bug#15035.
1481
deb31e75
DA
14822013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1483
1484 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1485 (imagemagick_prune_animation_cache): Now static.
1486
319a4d03
LMI
14872013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1488
1489 * image.c (imagemagick_get_animation_cache): Don't segfault when
1490 pruning all entries.
1491
f747d82e
KB
14922013-08-18 Ken Brown <kbrown@cornell.edu>
1493
1494 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1495 static heap if ENABLE_CHECKING is defined.
1496 (max_bss_sbrk_ptr): New variable.
1497 (bss_sbrk): Use it.
1498 (report_sheap_usage): Report maximum static heap usage instead of
1499 ending static heap usage.
1500
d2c28fab
EZ
15012013-08-17 Eli Zaretskii <eliz@gnu.org>
1502
1503 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1504 of zlib_initialized according to the results of calling
1505 init_zlib_functions.
1506
274ff63f
LMI
15072013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1508
1509 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1510 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1511 (imagemagick_load_image): Remove the ping_wand code, which only
1512 apparently saved time on invalid animated images, and slowed down
1513 everything else. Optimise for the common case.
274ff63f 1514
2bede2ed
XF
15152013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1516
70ff8240
XF
1517 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1518
de179a3e
XF
1519 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1520
2bede2ed
XF
1521 * marker.c (set_marker): Remove documentation of undefined behavior.
1522
703dbeba
LMI
15232013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1524
1525 * image.c (imagemagick_compute_animated_image): Animate correctly
1526 when sub-images are smaller than the main image.
1d18b1e6
LMI
1527 (imagemagick_compute_animated_image): Setting the iterator row to
1528 zero is apparently not allowed.
79670014
LMI
1529 (imagemagick_compute_animated_image): Allow images that say they
1530 have sub-images that are bigger than the main image, but just crop
1531 them.
703dbeba 1532
63216c5e
JD
15332013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1534
1535 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1536
a5b5f73f
LMI
15372013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1538
1539 * image.c (imagemagick_compute_animated_image): Respect the GIF
1540 disposal methods.
1541
0fe73012
KB
15422013-08-15 Ken Brown <kbrown@cornell.edu>
1543
1544 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1545 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1546 needed.
1547
691a357f
PE
15482013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1549
1550 Fix minor problems found by static checking.
1551 * frame.c (delete_frame):
1552 * xdisp.c (next_element_from_display_vector):
1553 Avoid uninitialized local.
1554 * image.c (imagemagick_compute_animated_image): Port to C89.
1555 Prefer usual GNU indentation style for loops.
1556 Be more careful about bizarrely large sizes, by using ptrdiff_t
1557 instead of int.
1558
42fe2e88
DA
15592013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1560
1561 Fix infinite frame selection loop (Bug#15025).
1562 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1563
d39a3da6
EZ
15642013-08-15 Eli Zaretskii <eliz@gnu.org>
1565
068f9124
SM
1566 * xdisp.c (compute_window_start_on_continuation_line):
1567 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1568 to make sure we end up setting the window start at the leftmost
1569 visible character of the display line. This avoids funky
1570 horizontal shifting because the window start is not kept on the
1571 same position. (Bug#15090)
05426239
EZ
1572 (next_element_from_display_vector): Support 'box' face attribute
1573 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1574
6e856b69
LMI
15752013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1576
1577 * image.c (imagemagick_compute_animated_image): Implement animated
1578 images (bug#14700).
995be755
LMI
1579 (imagemagick_compute_animated_image): Fix some compilation
1580 warnings. Implement a very simple cache to make the animation
1581 usable at all, but it should be replaced with a per-image cache.
6e856b69 1582
d5a1acfa
DA
15832013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1584
1585 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1586 to do `for' loops over alist values.
1587 * buffer.h (FOR_EACH_BUFFER):
1588 * process.c (FOR_EACH_PROCESS): Use it.
1589 (handle_child_signal, status_notify, Fget_buffer_process)
1590 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1591
9c253307
DA
15922013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1593
1594 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1595 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1596 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1597 to xzalloc and so avoid redundant call to memset.
1598 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1599 members because it is allocated with xzalloc and so already zeroed.
1600
05e64f9f
KB
16012013-08-14 Ken Brown <kbrown@cornell.edu>
1602
1603 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1604 (Bug#15094).
1605
5b71542d
DA
16062013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1607
1608 Utility function and macro to copy Lisp string to C string.
1609 * lisp.h (xlispstrdupa): New macro.
1610 (xlispstrdup): New prototype.
1611 * alloc.c (xlispstrdup): New function.
1612 * callint.c (Fcall_interactively):
1613 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1614 (Fsubstitute_in_file_name):
1615 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1616 * image.c (x_create_bitmap_from_file):
1617 * w32term.c (w32_term_init):
1618 * xterm.c (x_term_init): Use xlispstrdup.
1619
71530c97
LMI
16202013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1621
4ce82fb8
LMI
1622 * image.c (imagemagick_load_image): Make animated pictures work.
1623 There's still some problems with background color settings, though
1624 (bug#14700).
1625
71530c97
LMI
1626 * decompress.c (unwind_decompress): Always restore point.
1627
7510a061
XF
16282013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1629
1630 * marker.c (set_marker): Reformat documentation.
1631
01c3051f
PE
16322013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1633
aab1fcdf
PE
1634 * xdisp.c (cursor_type_changed): Now static.
1635
01c3051f
PE
1636 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1637 Use changed. This avoids the need to call xmalloc and for the
1638 caller to call xfree, and avoids memory leaks in some situations.
1639
2084152a
DA
16402013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1641
1642 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1643 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1644 (redisplay_window): If window_end_valid is cleared due to non-zero
1645 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1646 so do not call to try_cursor_movement for that window.
2084152a 1647
02455cb6
DA
16482013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1649
1650 * window.h (struct window): Convert window_end_pos and
1651 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1652 (wset_window_end_pos, wset_window_end_vpos): Remove.
1653 * dispnew.c (adjust_glyph_matrix):
1654 * window.c (Fwindow_end, replace_window, set_window_buffer)
1655 (make_window):
1656 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1657 (set_vertical_scroll_bar, redisplay_window, try_window)
1658 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1659 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1660 (note_mouse_highlight): Adjust users.
1661 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1662 Add comment.
1663
da5707e8
DA
16642013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1665
1666 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1667 * image.c (imagemagick_filename_hint): Use `const char *' and
1668 prefer SSDATA to SDATA to avoid warnings.
1669
25554267
DA
16702013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1671
1672 Cleanup window fringes, margins and scroll bars adjustments.
1673 * window.c (set_window_fringes, set_window_margins)
1674 (set_window_scroll_bars, apply_window_adjustment): New functions.
1675 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1676 (Fset_window_scroll_bars): Use them.
1677
38a2c910
DA
16782013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1679
1680 * window.h (struct window): Convert scroll_bar_width
1681 from Lisp_Object to integer. Adjust comment.
1682 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1683 Adjust users.
1684 * window.c (wset_scroll_bar_width): Remove.
1685 (make_window): Initialize scroll_bar_width.
1686 (Fsplit_window_internal): Use direct assignment.
1687 (Fset_window_configuration, save_window_save):
1688 Convert Lisp_Object to integer and back where appropriate.
1689 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1690 bar was actually changed, and mention this in docstring.
1691
2d065031
PE
16922013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1693
1694 * decompress.c: Minor simplifications.
1695 (Fzlib_decompress_region): Don't bother verifying
1696 that avail_out <= UINT_MAX, as that was confusing.
1697 Mention the restriction in a comment instead.
1698 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1699
a5bd5abb
JD
17002013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1701
1702 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1703 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1704
66e7901a
LMI
17052013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1706
1707 * image.c (imagemagick_filename_hint): Check for errors in the
1708 alist structure.
1709
2fa611b7
EZ
17102013-08-13 Eli Zaretskii <eliz@gnu.org>
1711
1712 * window.c (Fwindow_margins): Return nil when there's no marginal
1713 area, as per the documented API.
1714
1715 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1716 Fmake_vector, as scroll bar's struct members are not all Lisp
1717 objects now. This avoids crashes in GC.
1718
1719 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1720 bool, so its address could be taken.
1721
8259030d
LMI
17222013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1723
1724 * image.c (imagemagick_filename_hint): New function to possibly
1725 apply `image-content-type-suffixes'.
1726 (imagemagick_load_image): Use it.
1727
866c710e
EZ
17282013-08-13 Eli Zaretskii <eliz@gnu.org>
1729
1730 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1731 if loading zlib failed.
1732
f10490f0
JD
17332013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1734
96311be7
JD
1735 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1736 2013-08-13 checkin below. Change bool to BOOL, rule is:
1737 All Obj-C code uses BOOL, except for interfaces callable from C.
1738
f10490f0
JD
1739 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1740
c8ae93b0
DA
17412013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1742
1743 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1744 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1745 bool instead of BOOL.
1746 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1747 from Lisp_Object to bitfield. Adjust comment.
1748 * w32term.c (x_scroll_bar_create): Adjust user.
1749 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1750 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1751 Use bool for boolean.
1752 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1753 to `unsigned int' when defining a bitfield.
1754
53b64418
PE
17552013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1756
1757 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1758
eeaf9bf3
DA
17592013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1760
1761 * window.h (struct window): Convert left_margin_cols and
1762 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1763 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1764 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1765 Adjust users.
1766 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1767 Adjust comment.
1768 (showing_window_margins_p, update_window_line, update_frame_1):
1769 * fringe.c (draw_fringe_bitmap_1):
1770 * xdisp.c (window_box_width): Adjust users.
1771 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1772 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1773 Use direct assignment.
1774 (Fset_window_configuration, save_window_save, Fwindow_margins):
1775 Convert Lisp_Object to integer and back where appropriate.
1776 (Fset_window_margins): Adjust user. Return t if any margin
1777 was actually changed, and mention this in docstring.
1778
956720af
XF
17792013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1780
f73f4ce6 1781 * syntax.c (forward_word):
956720af
XF
1782 * cmds.c (forward_char, backward_char): Mention the optional argument.
1783
9e37ee3b
DA
17842013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1785
1786 * window.h (struct window): Convert left_fringe_width
1787 and right_fringe_width from Lisp_Objects to integers.
1788 Adjust comment.
1789 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1790 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1791 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1792 Remove.
1793 (make_window): Initialize new integer fields to -1.
1794 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1795 (Fset_window_configuration, save_window_save):
1796 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1797 (Fset_window_fringes): Adjust user. Return t if any fringe
1798 was actually changed, and mention this in docstring.
1799
e4375ca7
DA
18002013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1803 * nsfns.m (x_set_cursor_type):
1804 * w32fns.c (x_set_cursor_type):
1805 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1806 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1807
a45543bc
DA
18082013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1809
1810 * font.c (clear_font_cache): New function, stripped from...
1811 (Fclear_font_cache): ...here, which now uses the function
1812 above. Adjust comment.
1813 * font.h (clear_font_cache): Add prototype.
1814 * xfaces.c (clear_face_cache): Use clear_font_cache.
1815
ae966a86
DA
18162013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1817
1818 * window.c (Fset_window_start): Compare `w', not `window' because
1819 `w' might not be equal to `window' after call to decode_live_window.
1820
297a545b
PE
18212013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1824 This fixes a problem introduced by the Bug#15035 patch
1825 when using GPG. Reported by Herbert J. Skuhra.
1826
aa942e2b
EZ
18272013-08-12 Eli Zaretskii <eliz@gnu.org>
1828
1829 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1830 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1831 not yet initialized.
1832
7699d09e
LMI
18332013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1834
1835 * decompress.c (Fzlib_decompress_region): Support zlib
1836 decompression, too, and rename.
1837
1d238bc7
PE
18382013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 Minor zlib configuration tweaks.
1841 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1842 Don't assume presence of fn_inflateInit2_ zlib internal function.
1843
8a44a184
LMI
18442013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1845
1846 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1847 include the zlib prefix.
1848
594a4307
EZ
18492013-08-12 Eli Zaretskii <eliz@gnu.org>
1850
1851 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1852 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1853 define static variables that are pointers to zlib functions to be
1854 dynamically loaded.
1855 (init_zlib_functions) [WINDOWSNT]: New function.
1856 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1857 New macros.
1858 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1859 macros instead of invoking the zlib functions directly.
068f9124
SM
1860 (syms_of_decompress): DEFSYM Qzlib_dll.
1861 Staticpro Szlib_available_p.
594a4307 1862
d2e113bc
DA
18632013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1864
1865 Avoid looping over all frame windows to freeze and unfreeze.
1866 * window.h (struct window): Drop frozen_window_start_p.
1867 (freeze_window_starts): Drop prototype.
1868 * frame.h (struct frame): New frozen_window_starts flag.
1869 (FRAME_WINDOWS_FROZEN): New macro.
1870 * window.c (freeze_window_start, freeze_window_starts):
1871 Remove.
1872 (select_window, replace_window): Adjust users.
1873 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1874 (window_frozen_p): New function.
1875 (redisplay_window): Use it.
1876
94fcd171
PE
18772013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1878
1879 Fix some fd issues when running subprocesses (Bug#15035).
1880 Fix bugs that can leak files or file descriptors on errors.
1881 Don't unlink open temp files, as that's hard for users to diagnose
1882 when things go awry (e.g., temp disk exhausted).
1883 Don't bother to lock temp files. Check for invalid recursion.
1884 * callproc.c (synch_process_fd): Remove. All uses removed.
1885 (synch_process_tempfile): New var or macro.
1886 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1887 New constants.
1888 (record_kill_process): New arg, the temp name. All callers changed.
1889 (delete_temp_file): Now just a simple wrapper around unlink.
1890 (call_process_kill): New arg, the call_process_fd array.
1891 Close them all. Clear synch_process_pid. Remove the temp file,
1892 or arrange for it to be removed.
1893 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1894 that's been moved to synch_process_tempfile. Caller changed.
1895 Do not remove the tempfile; that's now call_process_kill's
1896 responsibility.
1897 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1898 call_process_kill; the caller now does that.
1899 (call_process_cleanup): Do not close the process fd; that's now
1900 call_process_kill's responsibility.
1901 (Fcall_process): Implement via new function call_process, which
1902 has most of the old body of Fcall_process, but with a different API.
1903 (call_process): New function that does not open or close filefd if
1904 it is nonnegative. Record which fds need to be closed, and let
1905 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1906 Signal an error if invoked recursively (could be done via a hook).
1907 Simplify creation of the tempfile in the MSDOS case.
1908 Don't create the output file until after checking for the executable.
1909 Report any failure to open /dev/null.
1910 Don't open /dev/null for writing twice; once is enough.
1911 Don't create pipe if all output is being discarded or sent to file.
1912 Don't worry about setting up the coding system or reading from the
1913 pipe if all output is being discarded.
1914 Hoist fd_error local into top level, to lessen block nesting.
1915 Don't record deleted pid here; now done by Fcall_process_region.
1916 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1917 and note its success in synch_process_tempfile.
1918 Do not leak resources when child_setup fails.
1919 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1920 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1921 (create_temp_file): Now returns open fd, with an additional
1922 Lisp_Object * argument to return the name. All callers changed.
1923 Do not close the file; rewind it instead, and leave it open for
1924 the caller. Do not lock the temp file. Unwind-protect the file
1925 and the file-descriptor.
1926 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1927 If an asynchrounous process, record it here, not in call_process.
1928 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1929 * eval.c (set_unwind_protect): New function.
1930 * fileio.c (write_region): New function, generalized from the
1931 old Fwrite_region. Do not lock temp files.
1932 (Fwrite_region): Use it.
1933 * lisp.h (set_unwind_protect, write_region): New decls.
1934 * process.c: Include <verify.h>.
1935 (make_process): Mark fds as initially closed.
1936 (deleted_pid_list): Now a list of pid-filename pairs.
1937 All uses changed.
1938 (close_process_fd): New function.
1939 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1940 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1941 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1942 (create_process, create_pty, Fmake_serial_process)
1943 (server_accept_connection): Record which fds need to be closed,
1944 and let deactivate_process close them.
1945 (Fmake_network_process): Do not discard the unwind-protect
1946 until it's safe to do so.
1947 (deactivate_process): Close the fds opened by create_process etc.
1948 (Fprocess_send_eof): Adjust to new way of recording open fds.
1949 Report an error if /dev/null can't be opened, instead of aborting.
1950 * process.h (PROCESS_OPEN_FDS): New constant.
1951 (struct Lisp_Process): New member open_fds.
1952 (record_kill_process, record_deleted_pid): Adjust signatures.
1953 (record_deleted_pid): Move decl here ...
1954 * syswait.h (record_deleted_pid): ... from here.
1955
d0e615c3
PE
19562013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1957
1958 * decompress.c: Fix bugs with large buffers and weird inputs.
1959 Tune a bit. Reindent as per usual Emacs style.
1960 (BUFFER_SIZE): Remove.
1961 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1962 more than UINT_MAX bytes. Decompress into the gap instead of into
1963 an auto buffer, as this should avoid copying. Return nil if
1964 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1965 set immediate_quit; we shouldn't trust zlib code that much.
1966
313546eb
LMI
19672013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1968
99a32242
LMI
1969 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1970 errors, and really move the gap to where we want it.
1971
313546eb
LMI
1972 * lisp.h: Include decompress.c support.
1973
1974 * emacs.c (main): Include decompress.c support.
1975
1976 * Makefile.in: Include -lz if present.
1977
d2d699ac
JD
19782013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1979
f90e3ebd
JD
1980 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1981 (initWithTitle:): Initialize frame to 0.
1982 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1983 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1984 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1985
1986 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1987 fillWithWidgetValue:frame:
1988
423d3b3f
JD
1989 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1990 remove memory leak warnings.
1991
d2d699ac
JD
1992 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1993 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1994 menu_pending_title.
1995
1996 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1997 (x_activate_menubar): Update the whole menu.
1998 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1999 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2000 current event is not NSSystemDefined (Bug#15001).
2001 Call ns_check_menu_open only if trackingMenu is 2.
2002 (menuDidClose:): New method, decrease trackingMenu.
2003 (fillWithWidgetValue:setDelegate:): New method.
2004 (fillWithWidgetValue:): Call the above.
2005
2006 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2007
7d652d97
PE
20082013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2009
2010 Omit some unnecessary casts.
2011 Many of these go back to the old pre-C89 days, when they may have
2012 been needed, but we've been assuming C89 or later for a while now.
2013 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2014 (live_float_p, live_misc_p, live_vector_p):
2015 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2016 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2017 (defvar_per_buffer):
2018 * callint.c (Fcall_interactively):
2019 * doc.c (Fsubstitute_command_keys):
2020 * filelock.c (get_boot_time):
2021 * frame.c (xrdb_get_resource):
2022 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2023 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2024 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2025 (menuitem_highlight_callback, menu_destroy_callback)
2026 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2027 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2028 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2029 (xg_tool_bar_help_callback, tb_size_cb):
2030 * image.c (xpm_alloc_color, png_read_from_memory)
2031 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2032 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2033 (syms_of_image):
2034 * keymap.c (describe_map):
2035 * nsfns.m (Fns_display_monitor_attributes_list):
2036 * nsmenu.m (process_dialog:):
2037 * nsterm.m (hold_event):
2038 * process.c (wait_reading_process_output):
2039 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2040 * scroll.c (do_direct_scrolling, scrolling_1):
2041 * termcap.c (tgetent):
2042 * window.c (check_window_containing, add_window_to_list)
2043 (freeze_window_starts):
2044 * xdisp.c (compare_overlay_entries, vmessage):
2045 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2046 (x_get_monitor_attributes_xrandr)
2047 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2048 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2049 * xfont.c (xfont_match, xfont_open):
2050 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2051 (menubar_selection_callback, menu_position_func)
2052 (popup_selection_callback, create_and_show_popup_menu)
2053 (dialog_selection_callback, create_and_show_dialog):
2054 * xrdb.c (x_get_string_resource):
2055 (main) [TESTRM]:
2056 * xsmfns.c (x_session_check_input):
2057 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2058 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2059 (xaw_jump_callback, xaw_scroll_callback):
2060 Omit unnecessary casts.
2061
9acc1074
PE
20622013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2063
2064 Minor string-length refactoring.
2065 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2066 * frame.c (make_monitor_attribute_list):
2067 Prefer build_string to strlen + make_string.
2068
361c0eb8
JD
20692013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2070
2071 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2072 don't check minor_code (Bug#14417).
2073
14ba0822
EZ
20742013-08-09 Eli Zaretskii <eliz@gnu.org>
2075
2076 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2077 vertical positions instead. This avoids calling MATRIX_ROW with
2078 row numbers that are possibly beyond valid limits. (Bug#15064)
2079
309f24d1
DA
20802013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2081
2082 Use xstrdup and build_unibyte_string where applicable.
2083 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2084 * xfns.c (x_window):
2085 * xrdb.c (x_get_customization_string):
2086 * xterm.c (xim_initialize):
2087 * w32fns.c (w32_window): Use xstrdup.
2088 (w32_display_monitor_attributes_list):
2089 * emacs.c (init_cmdargs):
2090 * keyboard.c (PUSH_C_STR):
2091 * nsfont.m (nsfont_open):
2092 * sysdep.c (system_process_attributes):
2093 * w32.c (system_process_attributes):
2094 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2095
55902276
EZ
20962013-08-09 Eli Zaretskii <eliz@gnu.org>
2097
2098 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2099 variables of these types so that GDB would know about them, as aid
2100 for debugging fatal exceptions. (Bug#15024) See also
2101 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2102 discussions.
2103
10bf7f5a
JD
21042013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2105
2106 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2107 larger than the NSWindow (Bug#14934).
2108
65620264
DA
21092013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2110
2111 Redesign redisplay interface to drop global variable updated_window.
2112 Always pass currently updated window as a parameter to update routines.
2113 * dispextern.h (updated_window): Remove declaration.
2114 (struct redisplay_interface): Pass window parameter to
2115 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2116 and after_update_window_hook.
2117 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2118 Adjust prototypes.
2119 * dispnew.c (updated_window): Remove.
2120 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2121 (update_window_line): Adjust to match redisplay interface changes.
2122 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2123 (ns_scroll_run, ns_after_update_window_line):
2124 * w32term.c (x_update_window_begin, x_update_window_end)
2125 (x_after_update_window_line, x_scroll_run):
2126 * xterm.c (x_update_window_begin, x_update_window_end)
2127 (x_after_update_window_line, x_scroll_run):
2128 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2129 Likewise. Adjust comments where appropriate.
2130 (x_cursor_to): Simplify because this is always called during window
2131 update (but install debugging check anyway).
2132 (expose_window): Check must_be_updated_p flag to see whether this
2133 function is called during window update.
2134
628fdc56
DA
21352013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2136
2137 Do not reset window modification event counters excessively.
2138 These leftovers and poor man's tricky methods to catch extra
2139 redisplay's attention are no longer needed.
2140 * frame.c (set_menu_bar_lines_1):
2141 * minibuf.c (read_minibuf_unwind):
2142 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2143 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2144 (window_scroll_line_based, Fset_window_configuration):
2145 * xdisp.c (redisplay_window): Do not reset last_modified and
2146 last_overlay_modified counters.
2147
8fd9c92e
JD
21482013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2149
2150 * xselect.c (x_send_client_event): Set send_event and serial, memset
2151 data.l as it might be bigger than data.b. Use 24 bit mask to
2152 XSendEvent (Bug#15034).
2153
0ee18172
EZ
21542013-08-07 Eli Zaretskii <eliz@gnu.org>
2155
2156 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2157 for TTY frames that are not the top frame on their console.
2158 (Bug#14616)
2159
16ddd1a6
MR
21602013-08-07 Martin Rudalics <rudalics@gmx.at>
2161
2162 * w32term.c (w32fullscreen_hook): Really maximize frame when
2163 asked for (Bug#14841).
2164
d2a95ffb
DA
21652013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2166
2167 Prefer selected_window to Fselected_window, likewise for frames.
2168 * buffer.c (Fbuffer_swap_text):
2169 * data.c (Fvariable_binding_locus):
2170 * window.c (run_window_configuration_change_hook): Adjust users.
2171 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2172 Use decode_live_frame.
2173
170da1ec
DA
21742013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2175
2176 Be more careful if selected window shows the buffer other than current,
2177 use window_outdated only if this is not so. This change should also
2178 address some weird issues discussed in Bug#13012.
2179 * window.h (window_outdated): New prototype.
2180 * window.c (window_outdated): Now here. Convert from static and
2181 always assume window's buffer.
2182 (Fwindow_end, Fwindow_line_height): Use it.
2183 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2184 and always assume window's buffer.
2185 (redisplay_window): Adjust user.
e5eefe9b 2186 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2187 check whether mode line should be updated only if selected window
2188 shows current buffer.
2189 (run_window_scroll_functions): Use eassert for debugging check.
2190 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2191
56b5d5b1
DA
21922013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2193
2194 * window.c (window_scroll, window_scroll_pixel_based)
2195 (window_scroll_line_based): Use bool for booleans.
2196
2878ba7e
PE
21972013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 * process.c: Fix minor off-by-one issues in descriptor counts.
2200 This shouldn't fix any real bugs, but it cleans up the code a bit.
2201 (max_process_desc, max_input_desc): -1, not 0, means none.
2202 All uses changed.
2203 (delete_input_desc): New function.
2204 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2205 (deactivate_process): Scan backwards when recomuting max_process_desc;
2206 that should be faster.
2207 (init_process_emacs): Initialize max_input_desc.
2208
e30b79c1
DA
22092013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2210
2211 Use region cache to speedup bidi_find_paragraph_start.
2212 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2213 Rename cache_long_line_scans to cache_long_scans.
2214 * buffer.c (bset_cache_long_line_scans): Rename to
2215 bset_cache_long_scans.
2216 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2217 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2218 into account.
2219 (syms_of_buffer): Rename cache-long-line-scans to
2220 cache-long-scans. Adjust docstring.
2221 * search.c (newline_cache_on_off):
2222 * indent.c (width_run_cache_on_off): Adjust users.
2223 * bidi.c (bidi_paragraph_cache_on_off): New function.
2224 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2225 * insdel.c (prepare_to_modify_buffer):
2226 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2227
00012b86
DA
22282013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2229
2230 Invalidate region caches only if buffer text is going to be changed.
2231 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2232 (modify_text): ...new prototype.
2233 (prepare_to_modify_buffer_1): New prototype.
2234 * textprop.c (modify_region): Rename to...
2235 (modify_text_properties): ...new function.
2236 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2237 (Fremove_list_of_text_properties): Adjust users.
2238 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2239 (modify_text): ...new function.
2240 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2241 (prepare_to_modify_buffer_1): ...new function.
2242 * casefiddle.c (casify_region):
2243 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2244 (Ftranspose_regions): Use modify_text.
2245
dc6c0eda
SM
22462013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2247
2248 * lisp.mk (lisp): Add nadvice.elc.
2249
8f3a2c26
DA
22502013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2251
2252 New macro to iterate over live buffers similar to frames.
2253 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2254 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2255 Declare buffer-related variables here to offload lisp.h.
2256 * buffer.c (Vbuffer_alist): Adjust comment.
2257 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2258 (other_buffer_safely):
2259 * data.c (store_symval_forwarding):
2260 * dispnew.c (Fframe_or_buffer_changed_p):
2261 * fileio.c (Fdo_auto_save):
2262 * filelock.c (unlock_all_files):
2263 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2264
e0fdb694
PE
22652013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2266
2267 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2268 * callproc.c (create_temp_file):
2269 * filelock.c (create_lock_file):
2270 Assume mkostemp, since it's now provided by Gnulib.
2271
63f5c6c2
EZ
22722013-08-04 Eli Zaretskii <eliz@gnu.org>
2273
2274 * w32.c (mkostemp): New function.
2275 (mktemp): Remove, no longer used. Most of the code reused in
2276 mkostemp. (Bug#15015)
484ab239 2277 (mktemp): Don't undef.
63f5c6c2 2278
f0b79313
DA
22792013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2280
2281 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2282 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2283 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2284 (free_glyph_pool, check_glyph_memory): Likewise for
2285 all users. Adjust comments where appropriate.
2286
98f638d6
PE
22872013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 * composite.h: Minor fixups.
2290 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2291 to fix a misspelling, and change it to an inline function while
2292 we're at it (it need not be a macro). All uses changed.
2293 (composition_method, composition_valid_p):
2294 Rewrite to avoid assignments in if-conditions.
2295
75c59fb3
DA
22962013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2297
2298 Do not use global Lisp_Object in composition macros.
2299 * composite.h (composition_temp): Remove declaration.
2300 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2301 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2302 (compose_region): Remove the leftover.
75c59fb3
DA
2303 * composite.c (composition_temp): Remove.
2304 (run_composition_function, update_compositions)
2305 (composition_compute_stop_pos, composition_adjust_point)
2306 (Ffind_composition_internal):
2307 * coding.c (handle_composition_annotation):
2308 * xdisp.c (handle_composition_prop, check_point_in_composition):
2309 Related users changed.
2310
a10c8269
DA
23112013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2312
2313 Drop FRAME_PTR typedef.
2314 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2315 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2316 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2317 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2318 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2319 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2320 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2321 All related users changed.
2322
a104f656
SM
23232013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2324
2325 * eval.c (default_toplevel_binding): New function.
2326 (Fdefvar): Use it.
2327 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2328 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2329 (syms_of_eval): Export them.
2330 * data.c (Fdefault_value): Micro cleanup.
2331 * term.c (init_tty): Use "false".
2332
4b5c9326
DA
23332013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2334
2335 Fix X GC leak in GTK and raw (no toolkit) X ports.
2336 * xterm.c (x_free_frame_resources): If white and black relief
2337 GCs are allocated, always free them here.
2338 * xfns.c (x_make_gc): Omit redundant initialization.
2339 * widget.c (create_frame_gcs): Remove the leftover.
2340 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2341 in x_free_frame_resources.
2342
b19aa636
JD
23432013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2344
2345 * nsterm.m (windowWillResize:toSize:): Only change title if
2346 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2347 modifying it.
2348 (viewDidEndLiveResize): New method.
2349
2350 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2351 inside NS_IMPL_COCOA.
2352
af1f7e06
DA
23532013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2354
2355 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2356 Do not check whether undo is enabled because record_insert and
2357 record_delete does that themselves.
2358
65b02bb9
DA
23592013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2360
2361 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2362 member which is not really used any more.
2363 (FRAME_XIC_BASE_FONTNAME): Remove.
2364 * xfns.c (xic_free_fontset): Adjust user.
2365 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2366 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2367 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2368 (xdialog_show): Use eassert for debugging check.
7ee0f047 2369 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2370
6318cde0
PE
23712013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 * fileio.c, fns.c (merge): Move extern decl from here ...
2374 * lisp.h (merge): ... to here.
2375
6c1a09ba
DA
23762013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2377
2378 Fix last font-related change.
2379 * w32font.h (w32font_list_internal, w32font_match_internal):
2380 Fix prototype.
2381 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2382 (uniscribe_list_family): Adjust to match font API change.
2383 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2384 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2385
f8c20208
DA
23862013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2387
2388 * frame.h (FRAME_MOUSE_UPDATE):
2389 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2390 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2391
fdb396e2
DA
23922013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2393
2394 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2395 * font.h (struct font_driver): Change list, match, and list_family
2396 functions to accept struct frame * as first arg.
068f9124
SM
2397 * font.c (font_score, font_compare, font_sort_entities):
2398 Remove prototypes.
fdb396e2
DA
2399 (font_sort_entities, font_list_entities, font_select_entity):
2400 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2401 match font API change.
2402 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2403 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2404 * ftxfont.c (ftxfont_list, ftxfont_match):
2405 * xftfont.c (xftfont_list, xftfont_match):
2406 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2407 * w32font.c (w32font_list, w32font_match, w32font_list):
2408 (w32font_list_internal, w32_font_match_internal): Likewise.
2409 * xfaces.c (Fx_family_fonts): Adjust user.
2410
52b8a085
DA
24112013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2412
2413 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2414 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2415 only if HAVE_X_WINDOWS is in use.
2416 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2417 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2418 * w32term.c (x_wm_set_icon_position): Likewise.
2419 * w32fns.c (x_icon): Adjust user.
2420
c791c18e
DA
24212013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2422
2423 * xterm.c (last_mouse_press_frame): Remove the
2424 leftover which is not really used any more.
2425 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2426 (x_flush): Call XFlush once per each X display, not frame.
2427 This is better because this code always unconditionally skips
2428 non-X frames in Vframe_list and issues the only XFlush if we
2429 have more than one X frame on the same X display.
2f935d86
DA
2430 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2431 Use bool for booleans.
2432 (x_draw_glyph_string_background, cvt_string_to_pixel):
2433 (cvt_pixel_dtor): Drop unnecessary prototypes.
2434 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2435
f435830e
DA
24362013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2437
2438 Drop unnecessary functions that deals with frame pixel size.
2439 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2440 (x_pixel_height): Drop prototypes.
2441 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2442 (x_pixel_height): Drop implementations.
2443 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2444 which should be always valid for window frame.
2445 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2446 * w32menu.c (Fx_popup_dialog):
2447 * xmenu.c (Fx_popup_dialog): Likewise for both.
2448
84231434
DA
24492013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2450
2451 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2452 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2453 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2454 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2455 and mention nil frame in docstring.
84231434 2456
959067a1
DA
24572013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2458
2459 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2460 (x_figure_window_size): Likewise. Adjust to return long.
2461 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2462 (toplevel): Move Qterminal_live_p to...
2463 * terminal.c (toplevel): ...here, make it static, and...
2464 (syms_of_terminal): ...DEFSYM here.
2465 * frame.h (Qterminal_live_p): Remove declaration.
2466 (make_frame, x_figure_window_size): Adjust prototype.
2467 * nsfns.m (Fx_create_frame): Use long for window flags.
2468
f4b169ce
PE
24692013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2470
2471 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2472 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2473 Do not assume that emacs_close (INT_MAX) is a no-op.
2474
bee6a2c7
DA
24752013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2476
2477 * xfaces.c (make_face_cache): For struct face_cache, prefer
2478 xmalloc to xzalloc and so avoid redundant call to memset.
2479 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2480
d7e6881a
DA
24812013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2482
2483 * fringe.c (draw_window_fringes, update_window_fringes)
2484 (compute_fringe_widths):
2485 * w32term.c (x_draw_glyph_string):
2486 * window.c (candidate_window_p, Frecenter):
2487 * xfaces.c (realize_basic_faces, realize_default_face)
2488 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2489 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2490 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2491 * xmenu.c (Fx_menu_bar_open_internal):
2492 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2493 * xsettings.c (xft_settings_event):
2494 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2495 Use bool for booleans. Adjust style and comments where
2496 appropriate.
2497 * dispextern.h (draw_window_fringes, update_window_fringes)
2498 (compute_fringe_widths):
2499 * xterm.h (x_had_errors_p): Adjust prototype.
2500
ec3058af
DA
25012013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2502
2503 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2504 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2505
218e0637
DA
25062013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2507
2508 * fns.c (toplevel): Remove comment before Fsafe_length because
2509 it checks for QUIT.
2510
e560aba9
PE
25112013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2514
2e5ce5de
EZ
25152013-07-28 Eli Zaretskii <eliz@gnu.org>
2516
2517 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2518 frame which got the message is still alive, before dereferencing
2519 its pointer. (Bug#14970)
2520
2521 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2522 be a live window, before using it as such. (Bug#14970)
2523
e95da6d3
EZ
25242013-07-27 Eli Zaretskii <eliz@gnu.org>
2525
2526 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2527 w32_detect_focus_change instead of doing part of its job by hand.
2528 This fixes the problem whereby FOCUS_OUT events were not sent to
2529 the event queue.
2530
a8f93651
EZ
25312013-07-26 Eli Zaretskii <eliz@gnu.org>
2532
fec92060
EZ
2533 * process.c (Fprocess_list): Doc fix.
2534
a8f93651
EZ
2535 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2536 being re-exposed only if it didn't ask to become visible.
2537 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2538 was previously iconified. (Bug#14841)
2539 (x_iconify_frame): Mark the frame iconified.
2540
d5a7a9d9
PE
25412013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2542
2543 Fix minor problems found by static checking.
2544 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2545 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2546
56ea7291
SM
25472013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2548
2549 * eval.c (set_specpdl_old_value): New function.
2550 (unbind_to): Minor simplification.
2551 (get_backtrace_frame): New function.
2552 (Fbacktrace_frame): Use it. Add `base' argument.
2553 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2554 (syms_of_eval): Export backtrace-eval.
2555 * xterm.c (x_focus_changed): Simplify.
2556
9d611ffe
PE
25572013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2560
999c74e3
EZ
25612013-07-24 Eli Zaretskii <eliz@gnu.org>
2562
2563 * xdisp.c (redisplay_window): Instead of moving point out of
2564 scroll margin, reject the force_start method, and try scrolling
2565 instead. (Bug#14780)
2566
198fa217
KB
25672013-07-24 Ken Brown <kbrown@cornell.edu>
2568
2569 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2570 (Bug#14944).
2571
53840e55
PE
25722013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2573
2574 * eval.c (Fprogn): Do not check that BODY is a proper list.
2575 This undoes the previous change. The check slows down the
2576 interpreter, and is not needed to prevent a crash. See
2577 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2578
60967f56
GM
25792013-07-23 Glenn Morris <rgm@gnu.org>
2580
2581 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2582
9ca960e2
PE
25832013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2584
a29c3e6d
PE
2585 Port to GNU/Linux systems with tinfo but not ncurses.
2586 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2587 to decide whether ncurses is being used. Without this change,
2588 GCC complains about tgetent not being declared, on a system
2589 that has tinfo installed but ncurses not installed.
2590
f274311c
PE
2591 * eval.c (Fprogn): Check that BODY is a proper list.
2592
16b0520a
PE
2593 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2594 * data.c (Fsetq_default):
2595 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2596 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2597 (Fcondition_case):
2598 Tune by taking advantage of the fact that ARGS is always a list
2599 when a function is declared to have UNEVALLED args.
2600
9ca960e2
PE
2601 * emacsgtkfixed.c: Port to GCC 4.6.
2602 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2603
afacaa1b
JB
26042013-07-23 Juanma Barranquero <lekktu@gmail.com>
2605
2606 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2607 here to silence compiler warnings.
2608
368a85a4
PE
26092013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2610
2611 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2612 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2613 from messing up Emacs's 'struct frame' (Bug#14923).
2614
f4e891b5
PE
26152013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 * alloc.c (make_save_ptr_ptr): Define this function.
2618 It was inadvertently omitted. It's needed only if
2619 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2620
96c8b65e
JD
26212013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2622
2623 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2624 frame have focus (Bug#14895).
2625
ee010797
PE
26262013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 Avoid vfork-related deadlock more cleanly.
2629 * callproc.c (child_setup): When the child's exec fails, output
2630 the program name, as that's more useful. Use O_NONBLOCK to avoid
2631 deadlock.
2632 * process.c (create_process_1): Remove; no longer needed.
2633 (create_process): Remove timer hack; no longer needed, now that
2634 the child avoids deadlock.
2635
f0398ec1 26362013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2637
2638 * image.c (Fimage_flush): Fix doc typo.
2639
b2a069c2
PE
26402013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2641
6496aec9
PE
2642 Fix array bounds violation when pty allocation fails.
2643 * process.c (PTY_NAME_SIZE): New constant.
2644 (pty_name): Remove static variable; it's now auto.
2645 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2646 Take pty_name as an arg rather than using a static variable.
2647 All callers changed.
2648 (create_process): Recover pty_flag from process, not from volatile local.
2649 (create_pty): Stay inside array even when pty allocation fails.
2650 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2651
b2a069c2
PE
2652 * lread.c (Fload): Avoid initialization only when lint checking.
2653 Mention that it's needed only for older GCCs.
2654
99107004
KH
26552013-07-20 Kenichi Handa <handa@gnu.org>
2656
2657 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2658 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2659
6b1b199d
AS
26602013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2661
2662 * lread.c (Fload): Avoid uninitialized warning.
2663
4195afc3
PE
26642013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2665
3f5bef16
PE
2666 Fix some minor file descriptor leaks and related glitches.
2667 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2668 (create_lock_file): Use write, not emacs_write.
2669 * image.c (slurp_file, png_load_body):
2670 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2671 (server_accept_connection):
2672 Don't leak an fd on memory allocation failure.
2673 * image.c (slurp_file): Add a cheap heuristic for growing files.
2674 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2675 as that's what the other routines do. Maybe input need not be
2676 blocked at all, but it's better to be consistent.
2677 Avoid undefined behavior when strlen is zero.
2678
4195afc3
PE
2679 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2680 (NSTATICS): Now a constant; doesn't need to be a macro.
2681
a1aeeffe
RS
26822013-07-19 Richard Stallman <rms@gnu.org>
2683
2684 * coding.c (decode_coding_utf_8): Add simple loop for fast
2685 processing of ASCII characters.
2686
63b34baa
PE
26872013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2690
621dd9ac
EZ
26912013-07-19 Eli Zaretskii <eliz@gnu.org>
2692
2693 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2694 unportable 'struct x_display_info'.
2695 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2696 is a portable type.
2697
1396ac86
PE
26982013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2699
ab9980cd
PE
2700 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2701 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2702 or fscanf fails.
2703 (system_process_attributes): Prefer plain char to unsigned char
2704 when either will do. Clean up properly if interrupted or if
068f9124
SM
2705 memory allocations fail. Don't assume sscanf succeeds.
2706 Remove no-longer-needed workaround to stop GCC from whining.
2707 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2708 bit more carefully.
2709
1396ac86
PE
2710 Fix obscure porting bug with varargs functions.
2711 The code assumed that int is treated like ptrdiff_t in a vararg
2712 function, which is not a portable assumption. There was a similar
2713 -- though these days less likely -- porting problem with various
2714 assumptions that pointers of different types all smell the same as
2715 far as vararg functions is conserved. To make this problem less
2716 likely in the future, redo the API to use varargs functions.
2717 * alloc.c (make_save_value): Remove this vararg function.
2718 All uses changed to ...
2719 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2720 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2721 New functions.
2722 (make_save_ptr): Rename from make_save_pointer, for consistency with
2723 the above. Define only on platforms that need it. All uses changed.
2724
4d19d194
PE
27252013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2726
2727 * keyboard.c: Try to fix typos in previous change.
2728 (DISPLAY_LIST_INFO): New macro.
2729 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2730 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2731
945c5bb1
JB
27322013-07-18 Juanma Barranquero <lekktu@gmail.com>
2733
2734 * keyboard.c (kbd_buffer_get_event):
2735 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2736 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2737
f4b1eb36
PE
27382013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2739
5e679a2c
PE
2740 * filelock.c: Fix unlikely file descriptor leaks.
2741 (get_boot_time_1): Rework to avoid using emacs_open.
2742 This doesn't actually fix a leak, but is better anyway.
2743 (read_lock_data): Use read, not emacs_read.
2744
a8cd4836
PE
2745 * doc.c: Fix minor memory and file descriptor leaks.
2746 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2747 (get_doc_string, Fsnarf_documentation):
2748 Fix file descriptor leak on error.
2749
ef30e638
PE
2750 * term.c: Fix minor fdopen-related file descriptor leaks.
2751 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2752 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2753
f4b1eb36
PE
2754 * charset.c: Fix file descriptor leaks and errno issues.
2755 Include <errno.h>.
2756 (load_charset_map_from_file): Don't leak file descriptor on error.
2757 Use plain record_xmalloc since the allocation is larger than
2758 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2759 of entries.
2760 * eval.c (record_unwind_protect_nothing):
2761 * fileio.c (fclose_unwind):
2762 New functions.
2763 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2764 The replacement doesn't block input, but that no longer seems
2765 necessary.
2766
b648c163
PE
27672013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2768
a0931322
PE
2769 * lread.c: Fix file descriptor leaks and errno issues.
2770 (Fload): Close some races that leaked fds or streams when 'load'
2771 was interrupted.
2772 (Fload, openp): Report error number of last nontrivial failure to open.
2773 ENOENT counts as trivial.
2774 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2775 New functions.
2776 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2777 now that the function is always called with a nonnegative arg.
2778 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2779 All uses replaced with ...
2780 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2781
b648c163
PE
2782 A few more minor file errno-reporting bugs.
2783 * callproc.c (Fcall_process):
2784 * doc.c (Fsnarf_documentation):
2785 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2786 * process.c (set_socket_option):
2787 Don't let a constructor trash errno.
2788 * doc.c: Include <errno.h>.
2789
b1dc4084
JB
27902013-07-16 Juanma Barranquero <lekktu@gmail.com>
2791
2792 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2793
c43843aa
PE
27942013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2795
50a30cce
PE
2796 Fix w32 bug with call-process-region (Bug#14885).
2797 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2798 to Fcall_process when the input is empty. This simplifies the
2799 code a bit. It makes no difference on POSIXish platforms but
2800 apparently it fixes a bug on w32.
2801
44e18199 2802 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2803 * fileio.c (close_file_unwind): Don't close if FD is negative;
2804 this can happen when unwinding a zapped file descriptor.
2805 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2806 in case Emacs runs out of memory between the two unwind-protects.
2807 Don't trash errno when closing FD.
2808 Zap the FD in the specpdl when closing it, instead of deferring
2809 the removal of the unwind-protect; this fixes a bug where a child
2810 function unwinds the stack past us.
2811
27e498e6
PE
2812 New unwind-protect flavors to better type-check C callbacks.
2813 This also lessens the need to write wrappers for callbacks,
2814 and the need for make_save_pointer.
2815 * alloca.c (free_save_value):
2816 * atimer.c (run_all_atimers):
2817 Now extern.
2818 * alloc.c (safe_alloca_unwind):
2819 * atimer.c (unwind_stop_other_atimers):
2820 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2821 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2822 * minibuf.c (choose_minibuf_frame_1):
2823 * process.c (make_serial_process_unwind):
2824 * xdisp.h (pop_message_unwind):
2825 * xselect.c (queue_selection_requests_unwind):
2826 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2827 * alloca.c (record_xmalloc):
2828 Prefer record_unwind_protect_ptr to record_unwind_protect with
2829 make_save_pointer.
2830 * alloca.c (Fgarbage_collect):
2831 Prefer record_unwind_protect_void to passing a dummy.
2832 * buffer.c (restore_buffer):
2833 * window.c (restore_window_configuration):
2834 * xfns.c, w32fns.c (do_unwind_create_frame)
2835 New wrapper. All record-unwind uses of wrappee changed.
2836 * buffer.c (set_buffer_if_live):
2837 * callproc.c (call_process_cleanup, delete_temp_file):
2838 * coding.c (code_conversion_restore):
2839 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2840 * editfns.c (save_excursion_restore)
2841 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2842 (save_restriction_restore):
2843 * eval.c (restore_stack_limits, un_autoload):
2844 * fns.c (require_unwind):
2845 * keyboard.c (recursive_edit_unwind, tracking_off):
2846 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2847 * macros.c (pop_kbd_macro, restore_menu_items):
2848 * nsfns.m (unwind_create_frame):
2849 * print.c (print_unwind):
2850 * process.c (start_process_unwind):
2851 * search.c (unwind_set_match_data):
2852 * window.c (select_window_norecord, select_frame_norecord):
2853 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2854 (fast_set_selected_frame):
2855 * xfns.c, w32fns.c (unwind_create_tip_frame):
2856 Return void, not a dummy Lisp_Object. All uses changed.
2857 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2858 * callproc.c (call_process_kill):
2859 * fileio.c (restore_point_unwind, decide_coding_unwind)
2860 (build_annotations_unwind):
2861 * insdel.c (Fcombine_after_change_execute_1):
2862 * keyboard.c (read_char_help_form_unwind):
2863 * menu.c (unuse_menu_items):
2864 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2865 * sound.c (sound_cleanup):
2866 * xdisp.c (unwind_redisplay):
2867 * xfns.c (clean_up_dialog):
2868 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2869 Accept no args and return void, instead of accepting and returning
2870 a dummy Lisp_Object. All uses changed.
2871 * cygw32.c (fchdir_unwind):
2872 * fileio.c (close_file_unwind):
2873 * keyboard.c (restore_kboard_configuration):
2874 * lread.c (readevalllop_1):
2875 * process.c (wait_reading_process_output_unwind):
2876 Accept int and return void, rather than accepting an Emacs integer
2877 and returning a dummy object. In some cases this fixes an
2878 unlikely bug when the corresponding int is outside Emacs integer
2879 range. All uses changed.
2880 * dired.c (directory_files_internal_unwind):
2881 * fileio.c (do_auto_save_unwind):
2882 * gtkutil.c (pop_down_dialog):
2883 * insdel.c (reset_var_on_error):
2884 * lread.c (load_unwind):
2885 * xfns.c (clean_up_file_dialog):
2886 * xmenu.c, nsmenu.m (pop_down_menu):
2887 * xmenu.c (cleanup_widget_value_tree):
2888 * xselect.c (wait_for_property_change_unwind):
2889 Accept pointer and return void, rather than accepting an Emacs
2890 save value encapsulating the pointer and returning a dummy object.
2891 All uses changed.
2892 * editfns.c (Fformat): Update the saved pointer directly via
2893 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2894 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2895 (unwind_body): New function.
2896 (record_unwind_protect): First arg is now a function returning void,
2897 not a dummy Lisp_Object.
2898 (record_unwind_protect_ptr, record_unwind_protect_int)
2899 (record_unwind_protect_void): New functions.
2900 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2901 * fileio.c (struct auto_save_unwind): New type.
2902 (do_auto_save_unwind): Use it.
2903 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2904 * insdel.c (struct rvoe_arg): New type.
2905 (reset_var_on_error): Use it.
2906 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2907 New constants.
2908 (specbinding_func): Remove; there are now several such functions.
2909 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2910 (set_unwind_protect_ptr): New function.
2911 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2912
4e604a5d
PE
2913 Be simpler and more consistent about reporting I/O errors.
2914 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2915 Say "Read error" and "Write error", rather than "I/O error", or
2916 "IO error reading", or "IO error writing", when a read or write
2917 error occurs.
2918 * process.c (Fmake_network_process, wait_reading_process_output)
2919 (send_process, Fprocess_send_eof, wait_reading_process_output):
2920 Capitalize diagnostics consistently. Put "failed foo" at the
2921 start of the diagnostic, so that we don't capitalize the
2922 function name "foo". Consistently say "failed" for such
2923 diagnostics.
2924 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2925 All callers changed. This is so it can use report_file_error.
2926 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2927 diagnostics consistently as above.
2928
a9757f6a
PE
2929 * fileio.c (report_file_errno): Fix errno reporting bug.
2930 If the file name is neither null nor a pair, package it up as a
2931 singleton list. All callers changed, both to this function and to
2932 report_file_error. This fixes a bug where the memory allocator
2933 invoked by list1 set errno so that the immediately following
2934 report_file_error reported the wrong errno value.
2935
c43843aa
PE
2936 Fix minor problems found by --enable-gcc-warnings.
2937 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2938 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2939
18c26d81
JD
29402013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2941
2942 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2943 Set event->arg to Qt if switch-event shall be generated.
2944 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2945
2946 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2947
2948 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2949 FOCUS_OUT_EVENT.
2950
2951 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2952 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2953 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2954 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2955 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2956 and there is a focused frame.
2957 (head_table): Add focus-in and focus-out.
2958 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2959 bind to handle-focus-in/out.
2960
2961 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2962 (Fhandle_switch_frame): Call Fhandle_focus_in.
2963 (syms_of_frame): defsubr handle-focus-in/out.
2964
6c6f1994
PE
29652013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2966
c7ddc792
PE
2967 Fix porting bug to older POSIXish platforms (Bug#14862).
2968 * sysdep.c (emacs_pipe): New function, that implements
2969 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2970 This should port better to CentOS 5 and to Mac OS X 10.6.
2971 All calls to pipe2 changed.
2972
6c6f1994
PE
2973 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2974 This makes the code easier to read and the executable a bit smaller.
2975 Do not replace all calls to Fcons that happen to create lists,
2976 just calls that are intended to create lists. For example, when
2977 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2978 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2979 Similarly for list2 through list5.
2980 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2981 * bytecode.c (exec_byte_code):
2982 * callint.c (quotify_arg, Fcall_interactively):
2983 * callproc.c (Fcall_process, create_temp_file):
2984 * charset.c (load_charset_map_from_file)
2985 (Fdefine_charset_internal, init_charset):
2986 * coding.c (get_translation_table, detect_coding_system)
2987 (Fcheck_coding_systems_region)
2988 (Fset_terminal_coding_system_internal)
2989 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2990 * composite.c (update_compositions, Ffind_composition_internal):
2991 * dired.c (directory_files_internal, file_name_completion)
2992 (Fsystem_users):
2993 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2994 * doc.c (Fsnarf_documentation):
2995 * editfns.c (Fmessage_box):
2996 * emacs.c (main):
2997 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2998 (Feval, eval_sub, Ffuncall, apply_lambda):
2999 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3000 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3001 (Fset_file_times, Finsert_file_contents)
3002 (Fchoose_write_coding_system, Fwrite_region):
3003 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3004 * font.c (font_registry_charsets, font_parse_fcname)
3005 (font_prepare_cache, font_update_drivers, Flist_fonts):
3006 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3007 * frame.c (make_frame, Fmake_terminal_frame)
3008 (x_set_frame_parameters, x_report_frame_params)
3009 (x_default_parameter, Fx_parse_geometry):
3010 * ftfont.c (syms_of_ftfont):
3011 * image.c (gif_load):
3012 * keyboard.c (command_loop_1):
3013 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3014 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3015 (Fminor_mode_key_binding, accessible_keymaps_1)
3016 (Faccessible_keymaps, Fwhere_is_internal):
3017 * lread.c (read_emacs_mule_char):
3018 * menu.c (find_and_return_menu_selection):
3019 * minibuf.c (get_minibuffer):
3020 * nsfns.m (Fns_perform_service):
3021 * nsfont.m (ns_script_to_charset):
3022 * nsmenu.m (ns_popup_dialog):
3023 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3024 (Fx_own_selection_internal):
3025 * nsterm.m (append2):
3026 * print.c (Fredirect_debugging_output)
3027 (print_prune_string_charset):
3028 * process.c (Fdelete_process, Fprocess_contact)
3029 (Fformat_network_address, set_socket_option)
3030 (read_and_dispose_of_process_output, write_queue_push)
3031 (send_process, exec_sentinel):
3032 * sound.c (Fplay_sound_internal):
3033 * textprop.c (validate_plist, add_properties)
3034 (Fput_text_property, Fadd_face_text_property)
3035 (copy_text_properties, text_property_list, syms_of_textprop):
3036 * unexaix.c (report_error):
3037 * unexcoff.c (report_error):
3038 * unexsol.c (unexec):
3039 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3040 (Fformat_mode_line, syms_of_xdisp):
3041 * xfaces.c (set_font_frame_param)
3042 (Finternal_lisp_face_attribute_values)
3043 (Finternal_merge_in_global_face, syms_of_xfaces):
3044 * xfns.c (x_default_scroll_bar_color_parameter)
3045 (x_default_font_parameter, x_create_tip_frame):
3046 * xfont.c (xfont_supported_scripts):
3047 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3048 (menu_help_callback, xmenu_show):
3049 * xml.c (make_dom):
3050 * xterm.c (set_wm_state):
3051 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3052 and similarly for list2 through list5.
3053
bafe80ce
PE
30542013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 * callproc.c (Fcall_process_region): Fix minor race and tune.
3057 (create_temp_file): New function, with the temp-file-creation part
3058 of the old Fcall_process_region. Use Fcopy_sequence to create the
3059 temp file name, rather than alloca + build_string, for simplicity.
3060 Don't bother to block input around the temp file creation;
068f9124
SM
3061 shouldn't be needed. Simplify use of mktemp.
3062 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3063 this closes an unlikely race where the temp file was not removed.
3064 Use memcpy rather than an open-coded loop.
3065 (Fcall_process_region): Use the new function. If the input is
3066 empty, redirect from /dev/null rather than from a newly created
3067 empty temp file; this avoids unnecessary file system traffic.
3068
4700b5a5
PE
30692013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3070
5c97beae
PE
3071 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3072 Simplify by making this case like the other two. This is a bit
3073 slower on obsolete hosts, but the extra complexity isn't worth it.
3074
4700b5a5
PE
3075 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3076 * process.c (create_process) [!DOS_NT]:
3077 Remove now-unnecessary calls to emacs_close.
3078
f9a74c4c
EZ
30792013-07-13 Eli Zaretskii <eliz@gnu.org>
3080
922ae7ee
EZ
3081 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3082 returning early. (Bug#14850)
3083
f9a74c4c
EZ
3084 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3085 and inhibit-iso-escape-detection attributes of 'undecided'.
3086 (Bug#14822)
3087
5e301d76
PE
30882013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3089
69e0e5ee
PE
3090 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3091 Reported by Herbert J. Skuhra in
3092 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3093
5e301d76
PE
3094 Don't lose top specpdl entry when memory is exhausted.
3095 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3096 specpdl overflow here, to simplify callers; all callers changed.
3097 Always reserve an unused entry at the stack top; this avoids
3098 losing the top entry's information when memory is exhausted.
3099
7e649856
PE
31002013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3101
a773ed9a
PE
3102 Clean up errno reporting and fix some errno-reporting bugs.
3103 * callproc.c (Fcall_process):
3104 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3105 * process.c (create_process, Fmake_network_process):
3106 * unexaix.c (report_error):
3107 * unexcoff.c (report_error):
3108 Be more careful about reporting the errno of failed operations.
3109 The code previously reported the wrong errno sometimes.
3110 Also, prefer report_file_errno to setting errno + report_file_error.
3111 (Fcall_process): Look at openp return value rather than at path,
3112 as that's a bit faster and clearer when there's a numeric predicate.
3113 * fileio.c (report_file_errno): New function, with most of the
3114 old contents of report_file_error.
3115 (report_file_error): Use it.
3116 (Ffile_exists_p, Ffile_accessible_directory_p):
3117 Set errno to 0 when it is junk.
3118 * fileio.c (Faccess_file):
3119 * image.c (x_create_bitmap_from_file):
3120 Use faccessat rather than opening the file, to avoid the hassle of
3121 having a file descriptor open.
3122 * lisp.h (report_file_errno): New decl.
3123 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3124
7e649856
PE
3125 Minor EBADF fixes.
3126 * process.c (create_process, wait_reading_process_output) [AIX]:
3127 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3128 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3129 a multithreaded environment anyway).
3130 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3131
f6774c1a
AS
31322013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3133
3134 * image.c (x_find_image_file): Don't close a remote file handle.
3135
bacba3c2
PE
31362013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 Fix races with threads and file descriptors.
3139 * callproc.c (Fcall_process_region):
3140 * dired.c (open_directory):
3141 * emacs.c (main, Fdaemon_initialized):
3142 * image.c (x_find_image_file):
3143 * inotify.c (Finotify_rm_watch):
3144 * lread.c (Flocate_file_internal):
3145 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3146 * term.c (term_mouse_moveto, init_tty):
3147 * termcap.c (tgetent):
3148 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3149 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3150 * unexhp9k800.c, unexmacosx.c (unexec):
3151 * callproc.c (Fcall_process_region):
3152 Use emacs_close, not close.
3153 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3154 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3155 and posix_close function on current platforms (which all lack them).
3156 (emacs_close): Use it. This should fix the races on GNU/Linux and
3157 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3158 and it should avoid closing random victim file descriptors on
3159 other platforms.
3160
653d4f43
PE
31612013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3162
c8536ec4
PE
3163 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3164 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3165 Touch up doc a bit.
3166
9c203066
PE
3167 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3168 This is for .gdbinit xbacktrace.
3169
653d4f43
PE
3170 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3171 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3172 (emacs_set_tty): Now static.
3173 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3174 * term.c (tty_capable_p, tty_default_color_capabilities)
3175 (get_tty_terminal, term_mouse_movement)
3176 (handle_one_term_event, init_tty, maybe_fatal):
3177 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3178 (tgetent, scan_file, name_match, compare_contin):
3179 * terminal.c (get_terminal):
3180 Use bool for boolean.
3181 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3182 Prefer char to unsigned char if either will do.
3183 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3184 (tty_write_glyphs): Prefer int to unsigned.
3185 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3186 All callers changed.
3187 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3188
45b683a1
PE
31892013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3190
29abe551
PE
3191 Port to C89.
3192 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3193 (B__dummy__): New dummy symbol, to pacify C89.
3194 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3195 they can't grok varargs macros.
3196 * dispnew.c (add_window_display_history)
3197 (add_frame_display_history):
3198 * print.c (print_object):
3199 * xdisp.c (debug_method_add):
3200 Use %p printf format only for void pointers.
3201 * emacs.c (usage_message): New constant, replacing ...
3202 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3203 (main): Adjust to usage reorg.
3204 * fns.c (syms_of_fns):
3205 * profiler.c (syms_of_profiler):
3206 Don't use non-constant struct initializers.
3207 * gnutls.h (gnutls_initstage_t):
3208 * lisp.h (enum Lisp_Fwd_Type):
3209 * lread.c (lisp_file_lexically_bound_p):
3210 * xsettings.c (anonymous enum):
3211 Remove trailing comma.
3212 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3213 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3214 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3215 (DEFUN): Use it.
3216 * regex.c (const_re_char): New type, to pacify strict C89.
3217 All uses of 'const re_char' replaced to use it.
3218 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3219 with glibc when strict C89. This change is imported from gnulib.
3220 All uses changed.
3221 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3222 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3223 Omit GNU_LINUX implementation, since it requires long long.
3224 * xterm.c (x_draw_underwave):
3225 Do not assume the traditional order of struct's members.
3226 (x_term_init): Rewrite to avoid the need for non-constant structure
3227 initializers.
3228
45b683a1 3229 Syntax cleanup, mostly replacing macros with functions.
763a086d 3230 This removes the need for the syntax_temp hack.
45b683a1
PE
3231 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3232 * syntax.c (SYNTAX_INLINE): New macro.
3233 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3234 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3235 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3236 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3237 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3238 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3239 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3240 Now constants, not macros.
3241 (syntax_temp) [!__GNUC__]: Remove.
3242 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3243 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3244 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3245 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3246 Move here from syntax.h; now functions, not macros. Except for the
3247 last function, these are static since only syntax.c uses them.
3248 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3249 All uses changed. Now a function, not a macro; use this fact
3250 to simplify the code.
3251 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3252 compiler bugs; no longer relevant.
3253 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3254 (SYNTAX_INLINE): New macro.
3255 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3256 for the new functions. Use bool for boolean member.
3257 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3258 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3259 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3260 (SETUP_BUFFER_SYNTAX_TABLE):
3261 Now extern inline functions, not macros.
3262 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3263 Remove; all uses replaced by implementation.
3264 (syntax_temp) [!__GNUC__]: Remove decl.
3265 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3266
29be4a50
JD
32672013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3268
3269 * emacs.c (main): Fix syntax error.
3270
954b166e
PE
32712013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3272
3273 Timestamp fixes for undo (Bug#14824).
3274 * atimer.c (schedule_atimer):
3275 * fileio.c (Ffile_newer_than_file_p):
3276 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3277 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3278 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3279 (syms_of_fileio): Remove Sclear_visited_file_name.
3280 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3281 file doesn't exist; this avoids an ambiguity with negative timestamps.
3282 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3283 * systime.h (make_emacs_time, invalid_emacs_time):
3284 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3285 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3286 * undo.c (record_first_change): Push (visited-file-modtime) onto
3287 undo list rather than reimplementing it by hand, incorrectly.
3288
d74647c3
KB
32892013-07-09 Ken Brown <kbrown@cornell.edu>
3290
3291 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3292
3c51b96b
JB
32932013-07-09 Juanma Barranquero <lekktu@gmail.com>
3294
3295 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3296
4ebbdd67
PE
32972013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3298
3299 Handle errno and exit status a bit more carefully.
3300 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3301 number into an exit status. Instead, use EXIT_CANCELED.
3302 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3303 * callproc.c (relocate_fd):
3304 * emacs.c (close_output_streams, main):
3305 * process.c (create_process):
3306 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3307 Use emacs_perror for simplicity.
3308 * callproc.c (relocate_fd, main):
3309 * sysdep.c (sys_subshell):
3310 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3311 (shut_down_emacs): Use emacs_write, not write.
3312 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3313 * fileio.c (Fcopy_file, e_write):
3314 * nsterm.m (ns_select):
3315 * process.c (send_process):
3316 * sound.c (vox_write):
3317 Use emacs_write_sig, not emacs_write.
3318 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3319 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3320 New constants.
3321 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3322 of write.
3323 (emacs_full_write): New function.
3324 (emacs_write): Rewrite to use it.
3325 (emacswrite_sig, emacs_perror): New functions.
3326 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3327
44e18199 33282013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3329
3330 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3331 on NS even if it is present. Pixmap on NS is a void*.
3332
9caab067
PE
33332013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3334
3335 Port to Ubuntu 10 (Bug#14803).
3336 Problem reported by T.V. Raman.
3337 * process.c (close_on_exec, accept4, process_socket):
3338 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3339
1d442672
EZ
33402013-07-07 Eli Zaretskii <eliz@gnu.org>
3341
3342 * w32.c (sys_dup): Declare prototype.
3343
3344 * filelock.c:
3345 * emacs.c:
3346 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3347
067428c1
PE
33482013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 Make file descriptors close-on-exec when possible (Bug#14803).
3351 This simplifies Emacs a bit, since it no longer needs to worry
3352 about closing file descriptors by hand in some cases.
3353 It also fixes some unlikely races. Not all such races, as
3354 libraries often open files internally without setting
3355 close-on-exec, but it's an improvement.
3356 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3357 * callproc.c (Fcall_process) [!MSDOS]:
3358 * emacs.c (main) [!DOS_NT]:
3359 * nsterm.m (ns_term_init):
3360 * process.c (create_process):
3361 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3362 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3363 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3364 Prefer mkostemp with O_CLOEXEC to mkstemp.
3365 * callproc.c (relocate_fd) [!WINDOWSNT]:
3366 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3367 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3368 now using pipe2.
3369 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3370 Make the resulting file descriptor close-on-exec.
3371 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3372 * lread.c (load_descriptor_list, load_descriptor_unwind):
3373 Remove; no longer needed. All uses removed.
3374 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3375 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3376 New functions.
3377 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3378 (Fmake_network_process, Fnetwork_interface_list):
3379 (Fnetwork_interface_info, server_accept_connection):
3380 Make newly-created socket close-on-exec.
3381 * sysdep.c (emacs_open, emacs_fopen):
3382 Make new-created descriptor close-on-exec.
3383 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3384 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3385
0da857dd
JD
33862013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3387
3388 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3389 for NS_IMPL_GNUSTEP.
3390
5f86adcd
PE
33912013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3392
3393 Fix openp errno handling.
3394 * callproc.c (Fcall_process): Preserve openp errno around close.
3395 * lread.c (openp): Set errno when returning -1, as some callers
3396 expect this.
3397
1afb1d07
JD
33982013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3399
3400 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3401
3402 * nsterm.h (NSSavePanel): Update comment.
3403 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3404 (ns_run_file_dialog): Declare.
3405
3406 * nsfns.m: Remove panelOK.
3407 (ns_fd_data): New.
3408 (ns_run_file_dialog): New function.
3409 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3410 event loop, so file dialog is popped up by ns_run_file_dialog, called
3411 by sendEvent (Bug#14578).
3412 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3413
3323c263
EZ
34142013-07-06 Eli Zaretskii <eliz@gnu.org>
3415
fdda0220
EZ
3416 * xdisp.c (default_line_pixel_height): New function.
3417 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3418 (try_cursor_movement, redisplay_window, try_window)
3419 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3420
068f9124
SM
3421 * window.c (window_scroll_pixel_based):
3422 use default_line_pixel_height.
fdda0220
EZ
3423
3424 * dispextern.h (default_line_pixel_height): Add prototype.
3425
3426 * frame.c (x_set_line_spacing): Accept a float value for
3427 line-spacing parameter, per the documentation.
3428
3323c263
EZ
3429 * data.c (Fmultibyte_string_p): Doc fix.
3430
47ba6d43
PE
34312013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3432
406af475
PE
3433 Use emacs_open more consistently when opening files.
3434 This handles EINTR more consistently now, and makes it easier
3435 to introduce other uniform changes to file descriptor handling.
3436 * src/systdio.h: New file.
3437 * src/buffer.c (mmap_init):
3438 * cygw32.c (chdir_to_default_directory):
3439 * dispnew.c (Fopen_termscript):
3440 * emacs.c (Fdaemon_initialized):
3441 * fileio.c (Fdo_auto_save):
3442 * image.c (slurp_file, png_load_body, jpeg_load_body):
3443 * keyboard.c (Fopen_dribble_file):
3444 * lread.c (Fload):
3445 * print.c (Fredirect_debugging_output):
3446 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3447 * termcap.c (tgetent):
3448 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3449 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3450 * w32term.c (w32_initialize) [CYGWIN]:
3451 * xfaces.c (Fx_load_color_file):
3452 Use emacs_open instead of plain open, and emacs_fopen instead of
3453 plain fopen.
3454 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3455 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3456 * callproc.c (default_output_mode): New constant.
3457 (Fcall_process): Use it to call emacs_open instead of plain creat.
3458 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3459 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3460 (emacs_fopen): New function.
3461 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3462 Include <lisp.h>, for emacs_open.
3463 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3464
47ba6d43
PE
3465 Remove duplicate #include directives.
3466 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3467 * xfaces.c:
3468 Don't include stdio.h twice.
3469 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3470 Don't include sys/types.h or stdio.h twice.
3471 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3472 * lread.c: Don't include coding.h twice.
3473 * nsfont.m: Don't include frame.h twice.
3474 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3475 * ralloc.c: Don't include <unistd.h> twice.
3476 * xdisp.c: Don't include font.h twice.
3477 * xterm.c: Don't include fontset.h twice.
3478 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3479
b9ed53d5
PE
34802013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 Scale ImageMagick images more carefully.
3483 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3484 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3485 Be more careful about avoiding undefined behavior after
3486 integer overflow and division by zero.
3487
cf13177e
YM
34882013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3489
3490 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3491 (syms_of_w32fns): DEFSYM them.
3492 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3493 (CCHDEVICENAME): Define macros if not defined.
3494 (struct MONITOR_INFO_EX): New struct.
3495 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3496 (enum_display_monitors_fn): New variable.
3497 (globals_of_w32fns): Initialize it.
3498 (Fx_display_pixel_width, Fx_display_pixel_height)
3499 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3500 multi-monitor setups in docstrings.
3501 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3502 screen size by primary monitor's millimeter per pixel.
3503 (w32_monitor_enum, w32_display_monitor_attributes_list)
3504 (w32_display_monitor_attributes_list_fallback)
3505 (Fw32_display_monitor_attributes_list): New functions.
3506 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3507
3508 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3509 if not defined.
3510 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3511
86dfb7a8
MA
35122013-07-04 Michael Albinus <michael.albinus@gmx.de>
3513
3514 * fileio.c (Qfile_notify_error): New error symbol.
3515
3516 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3517 * inotify.c (inotify_callback, symbol_to_inotifymask)
3518 (Finotify_add_watch, Finotify_rm_watch): Use it.
3519 (inotifyevent_to_event): Exchange order of cookie and file name.
3520 (Finotify_add_watch): Adapt docstring.
3521
3522 * lisp.h (Qfile_notify_error): Declare.
3523
2c1c974b
PE
35242013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3527 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3528 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3529 which did not work (see <http://bugs.gnu.org/14569#307>).
3530 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3531 && (!noninteractive || initialized)). This attempts to thread
3532 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3533
7a35b20f
JB
35342013-07-04 Juanma Barranquero <lekktu@gmail.com>
3535
3536 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3537 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3538
1ce5cd04
PE
35392013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3540
3541 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3542 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3543 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3544 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3545
57f8c490
PE
35462013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3547
3548 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3549 Define to __sys_siglist.
3550
bcffb5ca
EZ
35512013-07-02 Eli Zaretskii <eliz@gnu.org>
3552
3553 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3554 word-wrap, so that overflow-newline-into-fringe would work in
3555 visual-line-mode. (Bug#2749)
3556 (move_it_in_display_line_to): When the last scanned display
3557 element fits exactly on the display line, and
3558 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3559 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3560 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3561 finding buffer position that corresponds to pixel coordinates,
3562 e.g. in buffer_posn_from_coords.
3563
2c41e781
JD
35642013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3565
3566 * process.c (handle_child_signal): Call catch_child_signal if
3567 NS_IMPL_GNUSTEP.
3568
c2418359
PE
35692013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3570
52a9bcae
PE
3571 Don't convert function pointers to void * and back.
3572 It isn't portable C, and it's easy enough to avoid.
3573 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3574 (make_save_value): Add support for SAVE_FUNCPOINTER.
3575 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3576 * print.c (print_object):
3577 Distinguish function from object pointers.
3578 * lisp.h (SAVE_FUNCPOINTER): New constant.
3579 (SAVE_SLOT_BITS): Adjust to it.
3580 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3581 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3582 (voidfuncptr): New typedef.
3583 (struct Lisp_Save_Value): New member data[0].funcpointer.
3584 (XSAVE_FUNCPOINTER): New function.
3585
c2418359
PE
3586 Simplify buildobj processing.
3587 * Makefile.in (buildobj.h): Make it a sequence of strings each
3588 followed by comma, rather than a single string. Put it into a
3589 .tmp file in case there's an error while generating it.
3590 (gl-stamp): Use .tmp for temp files.
3591 (mostlyclean): Clean .tmp files.
3592 * doc.c (buildobj): Move to just the routine that needs it.
3593 It's now an array of strings, so processing is simpler.
3594
8f43ce49
PE
35952013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3598 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3599 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3600 Invoke malloc_enable_thread even when not interactive.
3601 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3602 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3603 in this case, since the underlying bug has now been fixed.
3604
24827db9
JB
36052013-07-01 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3608 unlinking it (bug#14691).
3609
ef099a94
MN
36102013-06-30 Michal Nazarewicz <mina86@mina86.com>
3611
3612 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3613 before checking whether buffer is modified. This lets
3614 `kill-buffer-query-functions' cancel killing of the buffer or save
3615 its content before `kill-buffer' asks user the "Buffer %s
3616 modified; kill anyway?" question.
3617
9d3f2fc2
JD
36182013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3619
3620 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3621 Let the super performKeyEquivalent deal with them (Bug#14747).
3622
e6c6c8c7
PE
36232013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3624
1d71c1d9
PE
3625 * widget.c (resize_cb): Remove unused local.
3626
8f5f35cc
PE
3627 Do not use GTK 3 if it exists but cannot be compiled.
3628 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3629 * xterm.c (x_error_handler) [!USE_GTK]:
3630 Do not use GTK 3.
3631
e6c6c8c7
PE
3632 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3633
0ba54312
EZ
36342013-06-30 Eli Zaretskii <eliz@gnu.org>
3635
5d1c3286
EZ
3636 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3637 to the valid range of values. (Bug#14753)
3638
0ba54312
EZ
3639 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3640 when moving point by using the current glyph matrix. This avoids
3641 the need to force redisplay when this function is called in a
3642 loop.
3643
9c90cc06
PE
36442013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3645
3646 Fix minor problems found by static checking.
3647 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3648 Redo the latter's body to sidestep GCC parenthesization warnings.
3649 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3650 * coding.c (detect_coding, detect_coding_system):
3651 * coding.h (struct undecided_spec):
3652 Use bool for boolean.
3653 * image.c (QCmax_width, QCmax_height): Now static.
3654 * xdisp.c (Fmove_point_visually): Remove unused local.
3655
4c672a0f
EZ
36562013-06-29 Eli Zaretskii <eliz@gnu.org>
3657
3658 * xdisp.c (Fmove_point_visually): New function.
3659
c1ea3abf
JB
36602013-06-28 Kenichi Handa <handa@gnu.org>
3661
3662 * coding.h (define_coding_undecided_arg_index): New enum.
3663 (coding_attr_index): New members
3664 coding_attr_undecided_inhibit_null_byte_detection,
3665 coding_attr_undecided_inhibit_iso_escape_detection,
3666 coding_attr_undecided_prefer_utf_8.
3667 (undecided_spec): New struct.
3668 (struct coding_system): New member `undecided' of the member
3669 `spec'.
3670
3671 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3672 (detect_coding): Likewise.
3673 (detect_coding_system): Likewise.
3674 (Fdefine_coding_system_internal): New coding system properties
3675 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3676 :prefer-utf-8.
3677 (syms_of_coding): Adjust for coding_arg_undecided_max.
3678
ba3de9e6
PE
36792013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3680
3681 * image.c (x_from_xcolors): Remove unused local.
3682
547c9269
YM
36832013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3684
3685 Defer image data transfer between X client and server until actual
3686 display happens.
3687
3688 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3689 and `mask_img'.
3690
3691 * image.c (Destroy_Image): Remove.
3692 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3693 `mask_p', and `colors_p'. All uses changed.
3694 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3695 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3696 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3697 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3698 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3699 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3700 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3701 (image_get_x_image, image_unget_x_image): New functions or macros.
3702 (image_background, image_background_transparent, x_to_xcolors)
3703 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3704 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3705 instead of Destroy_Image.
3706 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3707 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3708 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3709 (imagemagick_load_image, svg_load_image): Use them instead of
3710 x_create_x_image_and_pixmap, and x_put_x_image followed by
3711 x_destroy_x_image, respectively.
3712 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3713 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3714 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3715 background_transparent fields.
3716 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3717 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3718
dae2f5ef
PE
37192013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3720
3721 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3722 This mostly consists of undoing recent changes.
3723 * callproc.c (Fcall_process):
3724 * process.c (create_process):
3725 Do not worry about catching SIGCHLD here, undoing previous change.
3726 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3727 * process.c, process.h (catch_child_signal):
3728 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3729 * process.c (catch_child_handler): Don't worry about being called
3730 lazily and do not assume caller has blocked SIGCHLD, undoing
3731 previous change. Move first-time stuff back to
3732 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3733 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3734 set lib_child_handler if it's already initialized, which may
3735 help avoid problems on GNUStep.
3736
fa55d2aa
PE
37372013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3738
3739 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3740 * callproc.c (Fcall_process):
3741 * process.c (create_process):
3742 Make sure SIGCHLD is caught before we fork,
3743 since Emacs startup no arranges to catch SIGCHLD.
3744 * process.c (lib_child_handler): Initialize to null, not to
3745 dummy_handler.
3746 (catch_child_signal): Allow self to be called lazily.
3747 Do nothing if it's already been called.
3748 Assume caller has blocked SIGCHLD (all callers do now).
3749 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3750 just before it's really needed.
3751 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3752 since it hasn't been caught yet.
3753
f3f9606c
LMI
37542013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3755
3756 * image.c (compute_image_size): New function to implement
3757 :max-width and :max-height.
3758 (imagemagick_load_image): Use it.
3759
c7041908
PE
37602013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3763 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3764 Now extern.
3765 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3766 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3767 the SIGCHLD handler, since the code is not atomic and (due to glib)
3768 signals may be arriving now.
3769 * sysdep.c (init_signals): Do not catch child signals here;
3770 'main' now does that later, at a safer time.
3771
f86852b4
PE
37722013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3773
0dfeed58
PE
3774 Clean up SIGCHLD handling a bit (Bug#14569).
3775 * process.c, process.h (catch_child_signal):
3776 Now always extern, even if !NS_IMPL_GNUSTEP.
3777 * process.c (catch_child_signal): Move glib tickler here from
3778 init_process_emacs, so that it's done earlier in Emacs
3779 initialization. Also move the noninteractive && !initialized
3780 check here from init_process_emacs. This is all a bit cleaner for
3781 GNUish platforms, and I hope it works around the Cygwin bug.
3782 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3783 that glib signal handling is tickled before glib creates threads.
3784
f86852b4
PE
3785 * process.c (wait_reading_process_output): Avoid int overflow
3786 when reading more than 2 GiB total from a process.
3787
cbd6509c
PE
37882013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3789
3790 * process.c (create_process): Handle a couple more cases,
3791 i.e., work even if new_argv and wait_child_setup[i] are cached.
3792 Use Fcall_process's style for volatile vars.
3793
9de1114a
AS
37942013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3795
3796 * process.c (create_process): Mark PROCESS volatile.
3797
fbe9e0b9
PE
37982013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 Use C99-style flexible array members if available.
3801 This avoids some subtle aliasing issues, which typically
3802 aren't a problem with GCC but may be a problem elsewhere.
3803 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3804 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3805 In either case, it uses a flexible array member rather than
3806 the old struct hack. All uses changed.
3807 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3808 Adjust to sdata reorganization.
3809 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3810 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3811 that ports better to pre-C99 non-GCC.
3812 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3813 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3814 as the latter has changed.
3815 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3816 and port better to pre-C99 GCC.
3817 * image.c (struct xpm_cached_color):
3818 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3819 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3820 Use FLEXIBLE_ARRAY_MEMBER.
3821 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3822 Move decl to top level so it gets checked against implementation.
3823 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3824 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3825
1fc71008
PE
38262013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * syntax.c: Integer cleanups.
3829 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3830 All uses that need 0-or-2 changed to:
3831 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3832 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3833 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3834 (char_quoted, prev_char_comend_first, back_comment)
3835 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3836 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3837 Use bool for boolean.
3838 (update_syntax_table, skip_chars, skip_syntaxes):
3839 Prefer int to unsigned when either will do.
3840 (back_comment): Return boolean success flag, like forw_comment,
3841 instead of positive-or-minus-1 (which might have overflowed int anyway).
3842 Don't stuff ptrdiff_t into int.
3843 (syntax_spec_code, syntax_code_spec): Now const.
3844 (Fmatching_paren, scan_lists, scan_sexps_forward):
3845 Use enum syntaxcode for syntax code.
3846 (Fmatching_paren): Check that arg is a character, not just an integer.
3847 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3848 (Finternal_describe_syntax_value): Omit no-longer-needed
3849 comparison to 0.
3850 (skip_chars): Use char, not unsigned char, when the distinction
3851 doesn't matter.
3852 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3853 * bytecode.c (exec_byte_code):
3854 * syntax.c (syntax_spec_code, Fchar_syntax)
3855 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3856 (init_syntax_once):
3857 * syntax.h (SYNTAX_WITH_FLAGS):
3858 Omit unnecessary casts.
3859
b932cad7
EZ
38602013-06-20 Eli Zaretskii <eliz@gnu.org>
3861
3862 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3863 line dimensions here, to avoid race conditions with the main
3864 thread. (Bug#14062, bug#14630, bug#14669)
3865
3866 * w32term.c (w32_draw_window_cursor): Compute the header line and
3867 mode line dimensions here.
3868 <w32_system_caret_window, w32_system_caret_hdr_height>:
3869 <w32_system_caret_mode_height>: New variables.
3870
3871 * w32term.h: Declare them.
3872
89561f72
PE
38732013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3874
5013fc08
PE
3875 * alloc.c (die): Move "assertion failed" string here ...
3876 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3877 COND when SUPPRESS_CHECKING. This shrinks the executable text
3878 size by 0.8% to 2.2% when configured with --enable-checking,
3879 depending on optimization flags (GCC 4.8.1 x86-64).
3880
89561f72
PE
3881 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3882
763a086d 38832013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3884
3885 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3886 base is 2; this is more accurate.
3887
983aeb9a
JB
38882013-06-19 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * sound.c (string_default): Move to !WINDOWSNT section.
3891 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3892
178ba3e6
PE
38932013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3894
bbc51b15
PE
3895 * sound.c: Integer cleanups.
3896 Remove unnecessary forward decls.
3897 (struct sound_device): The 'file' member is now a Lisp_Object, not
3898 a char *, so that we needn't invoke alloca on a huge size.
3899 (Fplay_sound_internal): Adjust to this.
3900 (string_default): New function.
3901 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3902 Use it to adjust to the struct sound_device change.
3903 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3904 (be2hs) [0]: Remove.
3905
178ba3e6
PE
3906 * syntax.c (skip_chars): Don't use uninitialized storage
3907 when searching a multibyte buffer for characters that are not in a
3908 unibyte string that contains non-ASCII characters.
3909
69f60cdc
JD
39102013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3911
3912 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3913 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3914
0d6224d4
PE
39152013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3916
3917 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3918
3c542890
KH
39192013-06-18 Kenichi Handa <handa@gnu.org>
3920
f7e3f7cd
KH
3921 * font.c (Ffont_spec): Signal an error for an invalid font name
3922 (Bug#14648).
3c542890 3923
9349e5f7
PE
39242013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3925
3926 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3927 In particular this ports to 32-bit sparc Sun cc.
3928 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3929 array with a dummy element at specpdl[-1], so that its address can
3930 be taken portably.
3931 (unbind_to): Do not copy the binding; not needed, now that we
3932 copy old_value in the one place where the copy is needed.
3933 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3934 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3935 (union specbinding): Rename from struct specbinding. Redo layout
3936 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3937 which is not portable. With Sun C 5.12 32-bit sparc, the
3938 declaration causes nargs to be an unsigned bitfield, a behavior
3939 that the C standard allows; but Emacs wants nargs to be signed.
3940 The overall type is now a union of structures rather than a
3941 structure of union of structures, and the 'kind' member is now a
3942 bitfield, so that the overall type doesn't grow. All uses changed.
3943 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3944
0a4df6a5
PE
39452013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3946
ec6ecaad
PE
3947 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3948 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3949
0a4df6a5
PE
3950 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3951
7bfe8dbc
EZ
39522013-06-17 Eli Zaretskii <eliz@gnu.org>
3953
3954 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3955 unless we know that the window w's frame is a frame object.
3956 Another attempt at solving bug#14062 and bug#14630.
3957
708e05f6
LMI
39582013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3959
3960 * textprop.c (property_set_type): New enum.
3961 (add_properties): Allow appending/prepending text properties.
3962 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3963 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3964 add_text_properties_1.
3965 (Fadd_face_text_property): New function that calls
3966 add_text_properties_1.
3967
84575e67
PE
39682013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 Move functions from lisp.h to individual modules when possible.
3971 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3972 * alloc.c (XFLOAT_INIT, set_symbol_name):
3973 * buffer.c (CHECK_OVERLAY):
3974 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3975 (set_char_table_parent):
3976 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3977 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3978 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3979 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3980 (set_blv_valcell):
3981 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3982 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3983 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3984 (backtrace_args, backtrace_debug_on_exit):
3985 * floatfns.c (CHECK_FLOAT):
3986 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3987 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3988 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3989 (set_hash_index_slot):
3990 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3991 * marker.c (CHECK_MARKER):
3992 * textprop.c (CHECK_STRING_OR_BUFFER):
3993 * window.c (CHECK_WINDOW_CONFIGURATION):
3994 Move here from lisp.h, and make these functions static rather than
3995 extern inline.
3996 * buffer.c (Qoverlayp):
3997 * data.c (Qsubrp):
3998 * fns.c (Qhash_table_p):
3999 * window.c (Qwindow_configuration_p):
4000 Now static.
4001 * lisp.h: Remove the abovementioned defns and decls.
4002
44e18199 4003 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4004 In lisp.h, prefer functions to function-like macros, and
4005 constants to object-like macros, when either will do. This:
4006 . simplifies use, as there's no more need to worry about
4007 arguments' side effects being evaluated multiple times.
4008 . makes the code easier to debug on some platforms.
4009 However, when using gcc -O0, keep using function-like macros
4010 for a few critical operations, for performance reasons.
4011 This sort of thing isn't needed with gcc -Og, but -Og
4012 is a GCC 4.8 feature and isn't widely-enough available yet.
4013 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4014 Remove enum lsb_bits; no longer needed.
4015 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4016 * buffer.c (Qoverlap):
4017 * data.c (Qsubrp):
4018 * fns.c (Qhash_table_p):
4019 Now extern, so lisp.h can use these symbols.
4020 * dispextern.h: Include character.h, for MAX_CHAR etc.
4021 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4022 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4023 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4024 (GLYPH_CODE_P): Move here from lisp.h.
4025 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4026 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4027 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4028 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4029 XUNTAG now returns void *.
4030 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4031 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4032 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4033 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4034 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4035 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4036 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4037 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4038 New macros, renamed from their sans-lisp_h_ counterparts.
4039 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4040 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4041 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4042 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4043 If compiling via GCC without optimization, define these as macros
4044 in addition to inline functions.
4045 To disable this, compile with -DINLINING=0.
4046 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4047 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4048 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4049 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4050 (INTMASK, VALMASK): Now macros, since static values cannot be
4051 accessed from extern inline functions.
4052 (VALMASK): Also a constant, for benefit of old GDB.
4053 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4054 is INTEGERP, which can fold it in.
5165d44a 4055 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4056 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4057 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4058 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4059 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4060 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4061 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4062 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4063 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4064 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4065 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4066 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4067 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4068 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4069 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4070 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4071 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4072 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4073 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4074 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4075 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4076 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4077 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4078 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4079 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4080 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4081 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4082 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4083 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4084 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4085 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4086 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4087 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4088 Now functions.
4089 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4090 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4091 (VALMASK): Define in one place rather than in two, merging the
4092 USE_LSB_TAG parts; this is simpler.
4093 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4094 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4095 Move up, to avoid use before definition.
4096 Also include "globals.h" earlier, for the same reason.
4097 (make_natnum): New function.
4098 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4099 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4100 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4101 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4102 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4103 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4104 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4105 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4106 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4107 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4108 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4109 (Qwindow_configuration_p, Qimage): New forward declarations.
4110 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4111 (STRING_COPYIN): Remove; unused.
4112 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4113 (xcar_addr, xcdr_addr): New functions. All uses changed.
4114 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4115 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4116 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4117 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4118 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4119 (TYPE_RANGED_INTEGERP): Simplify.
4120 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4121 (setlocale, fixup_locale, synchronize_system_messages_locale)
4122 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4123 Now empty functions, not macros.
4124 (functionp): Return bool, not int.
4125 * window.c (Qwindow_configuration_p): Now extern,
4126 so window.h can use it.
4127 * window.h (Qwindowp): Move decl back to lisp.h.
4128
9583ec36
EZ
41292013-06-15 Eli Zaretskii <eliz@gnu.org>
4130
4131 * xdisp.c (Fline_pixel_height): New function, required for solving
4132 bug #14567.
4133
210272ce
PE
41342013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4137
de0503df
SM
41382013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4139
4140 * lread.c (syms_of_lread):
4141 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4142
afbfe143
KD
41432013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4144
4145 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4146
d177e213
XF
41472013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4148
4149 * fileio.c (expand_file_name): Doc fix.
4150
05e3e412
PE
41512013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4152
f7394b12
PE
4153 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4154 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4155 Wait for self, not for 0. This can't hurt on GNU or similar
4156 system, and may help with Cygwin.
4157
05e3e412
PE
4158 * keyboard.c: Don't use PROP (...) as an lvalue.
4159 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4160 Use set_prop (A, B), not PROP (A) = B.
4161
17dd3097
EZ
41622013-06-10 Eli Zaretskii <eliz@gnu.org>
4163
4164 * xdisp.c (get_it_property): Use it->window instead of generating
4165 a Lisp object from it->w.
4166
52fab9c9
EZ
41672013-06-09 Eli Zaretskii <eliz@gnu.org>
4168
4169 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4170 get-char-property the window that is being rendered, instead of
4171 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4172 (compute_display_string_pos): When W is NULL, use the current
4173 buffer as the object to pass to get-char-property.
4174 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4175 pointer member of the bidi iterator, since no window is pertinent
4176 to this function.
52fab9c9 4177
5bf97bfc
EZ
41782013-06-08 Eli Zaretskii <eliz@gnu.org>
4179
4180 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4181 being displayed, and pass it to compute_display_string_pos.
4182 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4183 (bidi_paragraph_init): All callers changed.
4184
4185 * xdisp.c (init_from_display_pos, init_iterator)
4186 (handle_single_display_spec, next_overlay_string)
4187 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4188 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4189 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4190 (compute_display_string_pos): Accept additional argument, the
4191 window being displayed, and pass it to Fget_char_property.
4192 (Bug#14575)
4193
4194 * dispextern.h (struct bidi_it): New member w, the window being
4195 displayed.
4196 (compute_display_string_pos): Adjust prototype.
4197
5de0e011
JD
41982013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4199
e7b41c4c 4200 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4201
4202 * process.c (wait_reading_process_output): Check for NS before GLIB.
4203 GLIB may be linked in due to rsvg, but ns_select must be called.
4204
5de0e011
JD
4205 * xgselect.c (xg_select): Remove call to window_system_available
4206 and g_main_context_pending at the top, so Gdk events (i.e. file
4207 notify) are processed when Emacs is started with -nw.
4208
a822acff
EZ
42092013-06-07 Eli Zaretskii <eliz@gnu.org>
4210
4211 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4212 (ctagsfiles3): New variable, includes only *.m files.
4213 (TAGS): Use an explicit language name in the regular expressions,
4214 to avoid transformation of '/SOMETHING' by MSYS to
4215 'c:\MSYS\SOMETHING'.
4216
6c0a9ed1
RC
42172013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4218
4219 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4220
9ef6111b
EZ
42212013-06-06 Eli Zaretskii <eliz@gnu.org>
4222
4223 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4224 still need to set the mouse pointer shape and activate help-echo.
4225 (Bug#14558)
4226
7d300d64
PE
42272013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4228
4229 A few porting etc. fixes for the new file monitor code.
4230 See the thread containing
4231 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4232 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4233 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4234 (dir_monitor_callback, Fgfile_rm_watch):
4235 Use assq_no_quit instead of Fassoc, for speed.
4236 (dir_monitor_callback, Fgfile_rm_watch):
4237 eassert that the monitor is a fixnum.
4238 (dir_monitor_callback): No need for CDR_SAFE.
4239 Simplify building of lisp with alternative tails.
4240 (Fgfile_add_watch, Fgfile_rm_watch):
4241 Do not assume glib functions set errno reliably on failure.
4242 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4243 and signal an error otherwise.
4244 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4245 Use Fdelq instead of Fdelete, for speed.
4246
817ebfcf
EZ
42472013-06-05 Eli Zaretskii <eliz@gnu.org>
4248
4249 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4250 don't insist on being invoked on a highlighted tool-bar button.
4251 Avoids losing tool-bar functionality when mouse-highlight is nil.
4252 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4253 Don't highlight when mouse-highlight is nil.
4254 (note_mouse_highlight): When mouse-highlight is nil, don't return
4255 right away; instead, run tool-bar and mode-line highlight
4256 subroutine, clear any existing highlight, and revert the mouse
4257 pointer to its default shape. (Bug#14558)
4258
55577e7c
SM
42592013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4260
4261 * lisp.mk (lisp): Add prog-mode.el.
4262
f019a684
PE
42632013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4264
4265 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4266 * process.c (dummy_handler): New function.
4267 (lib_child_handler): New static var.
4268 (handle_child_signal): Invoke it.
4269 (catch_child_signal): If a library has set up a signal handler,
4270 save it into lib_child_handler.
4271 (init_process_emacs): If using glib and not on Windows, tickle glib's
4272 child-handling code so that it initializes its private SIGCHLD handler.
4273 * syssignal.h (SA_SIGINFO): Default to 0.
4274 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4275 31; it should no longer be needed now.
4276
90db8702
MA
42772013-06-05 Michael Albinus <michael.albinus@gmx.de>
4278
4279 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4280
4281 * gfilenotify.c (globals_of_gfilenotify): New function.
4282 (syms_of_gfilenotify): Move global initialization there.
4283
4284 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4285
bfa3acd6
SM
42862013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4287
4288 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4289 * keyboard.c (menu_bar_items, tool_bar_items):
4290 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4291 not override local keymaps any more.
4292
ba59bd80
EZ
42932013-06-04 Eli Zaretskii <eliz@gnu.org>
4294
4295 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4296
7f203aa1
EZ
42972013-06-03 Eli Zaretskii <eliz@gnu.org>
4298
9337e206
EZ
4299 * w32console.c (initialize_w32_display): Return the dimensions of
4300 the console window via 2 additional arguments, not via the current
4301 frame. This avoids crashes due to overrunning the bounds of
4302 frame's decode_mode_spec_buffer, which is not resized following
4303 the change of the frame dimensions from the initial 10x10.
4304
4305 * w32term.h (w32_initialize_display_info): Adjust prototype.
4306
4307 * term.c (init_tty): Take dimensions of the frame from the values
4308 returned by initialize_w32_display.
4309
7f203aa1
EZ
4310 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4311 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4312 (LIBES): Add $(GFILENOTIFY_LIBS).
4313
4314 * w32inevt.c (handle_file_notifications): Add dummy implementation
4315 for !HAVE_W32NOTIFY.
4316
4317 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4318
55a87246
JD
43192013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4320
4321 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4322
4323 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4324
4325 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4326
3d5ee10a
PE
43272013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4328
4329 Fix minor problems found by static checking.
4330 * data.c (pure_write_error):
4331 Use xsignal2, not Fsignal, as Fsignal might return.
4332 * eval.c (set_backtrace_debug_on_exit): Now static.
4333 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4334 No longer inline. EXTERN_INLINE is needed only for functions
4335 defined in .h files. Reindent function header as per GNU style.
4336 (backtrace_p, backtrace_top, backtrace_next):
4337 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4338 compiler or linker. Add extern decls to pacify gcc -Wall.
4339 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4340 Now static.
4341 * frame.c (free_monitors): Define only on platforms that need it.
4342 * nsterm.m (ns_term_init):
4343 * process.c (catch_child_signal):
4344 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4345 defined on all porting targets these days.
4346 * process.c, process.h (catch_child_signal):
4347 Make it extern only if NS_IMPL_GNUSTEP is defined.
4348
e2d8a6f0
EZ
43492013-06-03 Eli Zaretskii <eliz@gnu.org>
4350
4351 * w32.c (gettimeofday): Make the signature identical to prototype
4352 in nt/inc/sys/time.h.
4353
a8a7c5f6
SM
43542013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4355
4356 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4357 .gdbinit.
4358
4359 * keyboard.c (safe_run_hooks_error): Improve error message.
4360
4361 * data.c (pure_write_error): Add `object' argument.
4362 * puresize.h (CHECK_IMPURE): Use it.
4363
c9628c79
MA
43642013-06-03 Michael Albinus <michael.albinus@gmx.de>
4365
4366 * Makefile.in (NOTIFY_OBJ): New variable.
4367 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4368
4369 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4370 Call syms_of_gfilenotify.
4371
4372 * gfilenotify.c: New file.
4373
4374 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4375 and Qfile_w32notify.
4376 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4377 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4378
4379 * lisp.h: Declare syms_of_gfilenotify.
4380
4381 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4382
2f592f95
SM
43832013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4384
4385 Merge the specpdl and backtrace stacks. Make the structure of the
4386 specpdl entries more obvious via a tagged union of structs.
4387 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4388 (enum specbind_tag): New enum.
4389 (struct specbinding): Make it a tagged union of structs.
4390 Add a case for backtrace records.
4391 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4392 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4393 (backtrace_debug_on_exit): New accessors.
4394 (struct backtrace): Remove.
4395 (struct catchtag): Remove backlist field.
4396 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4397 Move to eval.c.
4398 (Flocal_variable_p): Speed up the common case where the binding is
4399 already loaded.
4400 * eval.c (backtrace_list): Remove.
4401 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4402 (set_backtrace_args, set_backtrace_nargs)
4403 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4404 (backtrace_next): New functions.
4405 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4406 (unwind_to_catch, internal_lisp_condition_case)
4407 (internal_condition_case, internal_condition_case_1)
4408 (internal_condition_case_2, internal_condition_case_n): Don't bother
4409 with backtrace_list any more.
4410 (Fsignal): Adjust to new backtrace format.
4411 (grow_specpdl): Move up.
4412 (record_in_backtrace): New function.
4413 (eval_sub, Ffuncall): Use it.
4414 (apply_lambda): Adjust to new backtrace format.
4415 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4416 data.c.
4417 (specbind): Adjust to new specpdl format. Simplify.
4418 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4419 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4420 backtrace format.
4421 (mark_backtrace): Remove.
4422 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4423 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4424 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4425 Use mark_specpdl.
4426 * profiler.c (record_backtrace): Use get_backtrace.
4427 (handle_profiler_signal): Use backtrace_top_function.
4428 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4429 accessor functions.
4430
c0342369
JD
44312013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4432
4433 * process.h (catch_child_signal): Declare.
4434
4435 * process.c (catch_child_signal): New function.
4436 (init_process_emacs): Call it.
4437
4438 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4439 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4440 NS_IMPL_COCOA.
4441 (x_set_cursor_type): Remove declaration.
4442 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4443 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4444 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4445 (ns_get_color): Use F suffix on float.
4446 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4447 (ns_get_rgb_color): Remove.
4448 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4449 (note_mouse_movement): x and y are CGFloat.
4450 (ns_draw_fringe_bitmap): Remove unused rowY.
4451 Change #if to COCOA && >= 10_6.
4452 (ns_draw_window_cursor): Remove unused overspill.
4453 (ns_draw_underwave): width and x are EamcsCGFloat.
4454 (ns_draw_box): thickness is CGFloat.
4455 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4456 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4457 if not in main thread.
4458 (ns_get_pending_menu_title, ns_check_menu_open)
4459 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4460 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4461 (sendFromMainThread:): New method.
4462 (changeFont:): size is CGFloat.
4463 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4464 Disable warning about permanent text.
4465 (characterIndexForPoint:): Adjust return type depending on GNUStep
4466 version.
4467 (mouseDown:): delta is CGFloat.
4468 (updateFrameSize): Remove unised variable f.
4469 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4470 Cast float to EmacsCGFloat.
4471 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4472 also to -1 when restoring.
4473 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4474 inside NS_IMPL_COCOA.
4475 (toggleFullScreen:): Put call to toggleFullScreen inside
4476 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4477 (setPosition:portion:whole:): por is CGFloat.
4478 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4479 (mouseDown:): Use CGFloat.
4480 (mouseDragged:): Remove unised variable edge.
4481 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4482
4483 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4484 of CGFloat differs.
4485 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4486 when NS_IMPL_GNUSTEP.
4487 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4488 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4489 (EmacsToolbar): Add clearAll. Add tag argument to
4490 addDisplayItemWithImage.
4491 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4492
4493 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4494
4495 * nsmenu.m (ns_update_menubar): Make static.
4496 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4497 (fillWithWidgetValue:): Add cast to SEL for setAction.
4498 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4499 (update_frame_tool_bar): Update code for GNUStep.
4500 (clearAll): New method.
4501 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4502 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4503 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4504 call to insertItemWithItemIdentifier.
4505 (validateVisibleItems): Fix indentation.
4506 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4507 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4508 UtilityWindow to aStyle, remove call to setStyleMask.
4509
4510 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4511
4512 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4513 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4514 Use F suffix on floats.
4515 (ns_char_width): Returns CGFloat.
4516 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4517 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4518 DPSxshow.
4519 (ns_glyph_metrics): CGFloat instead of float.
4520
a0eb10b3
JB
4521 * nsfns.m (x_set_foreground_color, x_set_background_color):
4522 Use EmacsCGFloat.
4523 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4524 remove unused variables.
4525 (Fns_read_file_name): Keep track if panel is for save.
4526 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4527 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4528 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4529 Just return the input if GNUStep.
c0342369
JD
4530 (x_screen_planes): Remove.
4531 (Fxw_color_values): Use EmacsCGFloat
4532 (Fns_display_monitor_attributes_list): Only get screen number for
4533 Cocoa.
ef099a94 4534 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4535 EmacsSavePanel.
4536 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4537 ns_directory_from_panel.
4538
da9aff11
PE
45392013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4540
4541 * process.c (handle_child_signal): Also use WCONTINUED.
4542 This is so that list-processes doesn't mistakenly list the process
4543 as stopped, when the process has actually been continued and is
4544 now running.
4545
0e64479a
PE
45462013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4547
fc186a96
PE
4548 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4549 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4550 not already configured.
4551
0e64479a
PE
4552 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4553
38b787fa
EZ
45542013-05-29 Eli Zaretskii <eliz@gnu.org>
4555
4556 * Makefile.in (mostlyclean): Remove *.res files.
4557
22513e52
SM
45582013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4559
4560 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4561 a buffer (bug#8447).
4562
6ef3db10
EZ
45632013-05-27 Eli Zaretskii <eliz@gnu.org>
4564
4565 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4566 display vector, and we backtrack, handle the case that the
4567 previous character position is also displayed from a display
4568 vector or covered by a display string or image. (Bug#14476)
4569
6799bb26
JD
45702013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4571
4572 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4573 (struct MonitorInfo, free_monitors): Remove.
4574 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4575 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4576 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4577 Qframes, Qsource.
4578
4579 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4580 (struct MonitorInfo, free_monitors): Remove.
4581 (ns_screen_name): Make static.
4582 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4583 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4584 Qframes, Qsource.
4585
4586 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4587 (struct MonitorInfo): New struct.
4588 (free_monitors, make_monitor_attribute_list): Declare.
4589
22513e52
SM
4590 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4591 New Lisp_Object:s.
6799bb26
JD
4592 (free_monitors, make_monitor_attribute_list): New functions.
4593 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4594 Qsource.
4595
38cd43eb
XF
45962013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4597
4598 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4599
2af0948d
SM
46002013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4601
a7eb9b0f
SM
4602 * keyboard.c: Apply keyboard decoding only to events that come directly
4603 from the tty, not from unread-command-events (bug#14368).
4604 (read_event_from_main_queue): New function, extracted from read_char).
4605 (read_decoded_char): Remove.
4606 (read_decoded_event_from_main_queue): New function to replace it.
4607 (read_char): Use it.
4608 (read_key_sequence): Use read_char rather than read_decoded_char.
4609
2af0948d
SM
4610 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4611
1413e9a5
BR
46122013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4613
4614 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4615
e6d2f155
KH
46162013-05-22 Kenichi Handa <handa@gnu.org>
4617
4618 The following changes are to fix the setting of
4619 buffer-file-coding-system on, for instance, C-x RET c unix RET
4620 _FILE_OF_DOS_EOL_TYPE_ RET.
4621
4622 * coding.h (struct coding_system): New member detected_utf8_chars.
4623
4624 * coding.c (detect_coding_utf_8): Count characters and check EOL
4625 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4626 BOM is there.
4627 (setup_coding_system): Do not initialize coding->head_ascii.
4628 (check_ascii): Do not set coding->eol_seen but update it. Do not
4629 call adjust_coding_eol_type here.
1413e9a5
BR
4630 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4631 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4632 of the found coding-system.
4633 (decode_coding_gap): Cancel previous change. Utilize the
4634 character numbers counted by detect_coding_utf_8. Fix detection
4635 of BOM for utf-8.
4636
ab56a6f4 46372013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4638
4639 * search.c (looking_at_1): Only set last_thing_searched if the match
4640 changed the match-data (bug#14281).
4641
ecc3c6ed
DA
46422013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4643
4644 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4645 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4646 (move_it_vertically_backward): Likewise.
4647
5ba8bf35
YM
46482013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4649
4650 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4651 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4652 (Fx_display_mm_width, Fx_display_mm_height):
4653 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4654
91e8418b 4655 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4656 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4657 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4658 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4659 (Fx_display_backing_store, Fx_display_visual_class)
4660 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4661 (Fx_display_grayscale_p, Fx_display_pixel_width)
4662 (Fx_display_pixel_height, Fx_display_planes)
4663 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4664 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4665 (Fx_display_mm_width, Fx_display_mm_height)
4666 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4667 height for all physical monitors as in X11.
4668
fc30d803
SM
4669 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4670 Return pixel width or height for all physical monitors as in X11.
91e8418b 4671
31ff141c
PE
46722013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4673
4674 Port --enable-gcc-warnings to clang.
4675 * bytecode.c (exec_byte_code):
4676 * regex.c:
4677 Redo diagnostic pragmas to pacify clang, too.
4678 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4679 * editfns.c (Fencode_time):
4680 * fileio.c (file_accessible_directory_p):
4681 * font.c (font_unparse_xlfd):
4682 Use '&"string"[index]' instead of '"string" + (index)'.
4683 * undo.c (user_error): Remove; unused.
4684
df065a0b
EZ
46852013-05-16 Eli Zaretskii <eliz@gnu.org>
4686
04d360e7
EZ
4687 * insdel.c (insert_1_both): Document the arguments, instead of
4688 referring to insert_1, which no longer exists.
4689
5bb98290
EZ
4690 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4691 some window, increment windows_or_buffers_changed, so that
4692 *Messages* display in that window is updated. (Bug#14408)
4693
df065a0b
EZ
4694 * w32.c: Include epaths.h.
4695 (init_environment): Use cmdproxy.exe without leading directories.
4696 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4697 case.
4698 (gettimeofday): Adjust signature and return value to Posix
4699 expectations.
4700
4701 * unexw32.c (open_output_file): Delete the existing emacs.exe
4702 before creating it, to break the hard link to the versioned
4703 executable.
4704
4705 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4706 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4707 (FIRSTFILE_OBJ): New variables.
4708 (W32_RES): Rename to EMACSRES. All users changed.
4709 (base_obj): Use $(CM_OBJ).
4710 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4711 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4712 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4713 $(W32_RES_LINK) before $(LIBES).
4714 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4715
1aa8d505
SM
47162013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4717
6e911150
SM
4718 * makefile.w32-in (DOC): Use just "DOC".
4719
4720 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4721
1aa8d505
SM
4722 * process.c: Export default filters and sentinels to Elisp.
4723 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4724 New constants.
4725 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4726 (Fset_process_sentinel, Fformat_network_address):
4727 Default to them instead of nil.
4728 (server_accept_connection): Sentinels can't be nil any more.
4729 (read_and_dispose_of_process_output): New function, extracted from
4730 read_process_output.
4731 (read_process_output): Use it; filters can't be nil.
4732 (Finternal_default_process_filter): New function, extracted from
4733 read_process_output.
4734 (exec_sentinel_unwind): Remove function.
4735 (exec_sentinel): Don't zilch sentinel while running.
4736 (status_notify): Sentinels can't be nil.
4737 (Finternal_default_process_sentinel): New function extracted from
4738 status_notify.
4739 (setup_process_coding_systems): Default filter is not nil any more.
4740 (syms_of_process): Export new Elisp functions and initialize
4741 new constants.
4742 * lisp.h (make_lisp_proc): New function.
4743
5ac2eb34
SM
47442013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4745
4746 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4747
eda9c7d7
EZ
47482013-05-14 Eli Zaretskii <eliz@gnu.org>
4749
4750 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4751 unless we know that the window w is a leaf window.
4752 Another attempt at solving bug#14062.
eda9c7d7 4753
8fdeaad5
JD
47542013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4755
4756 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4757 fdesc (Bug#14375).
4758
44aa9ee6
PE
47592013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4760
4761 * image.c (gif_load): Check that subimages fit (Bug#14345).
4762
759fd763
SM
47632013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4764
4765 * lread.c (skip_dyn_eof): New function.
4766 (read1): Use it to skip the end of a file in response to #@00.
4767
4768 * doc.c (get_doc_string): Slightly relax the sanity checking.
4769
4465bfb4
JD
47702013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4771
4772 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4773 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4774 (MonitorInfo): New struct.
4775 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4776 (Fns_display_monitor_attributes_list): New functions.
4777 (display-usable-bounds): Remove.
4778 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4779 Qsource.
4780
7583e2a0
PE
47812013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4782
4783 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4784 (GTK_CHECK_VERSION): New macro, if not already defined.
4785 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4786 replaced by GTK_CHECK_VERSION.
4787
ad75d77e
PE
47882013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 * xterm.h (GTK_PREREQ): New macro.
4791 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4792 to use this macro instead, for consistency and clarity.
4793
07525f77
EZ
47942013-05-08 Eli Zaretskii <eliz@gnu.org>
4795
4796 * xdisp.c (row_for_charpos_p): New function, with code of
4797 cursor_row_p, but accepts an additional argument CHARPOS instead
4798 of using a hardcoded PT.
4799 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4800 (row_containing_pos): Call row_for_charpos_p instead of partially
4801 doing the same. Fixes cursor positioning under longlines-mode
4802 when longlines-show-effect includes more than one newline, when
4803 moving the cursor vertically up.
4804
d901fc8d
JB
48052013-05-08 Juanma Barranquero <lekktu@gmail.com>
4806
4807 * makefile.w32-in (ACL_H): New macro.
4808 ($(BLD)/fileio.$(O)): Update dependencies.
4809
f269bc61
PE
48102013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4811
e7b41c4c 4812 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4813 * Makefile.in (LIB_ACL): New macro.
4814 (LIBACL_LIBS): Remove.
4815 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4816 * fileio.c: Include <acl.h>.
4817 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4818 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4819 !acl_errno_valid.
4820 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4821 it ourselves.
4822
f269bc61
PE
4823 * unexelf.c: Don't assume ElfW (Half) fits in int.
4824 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4825 when dealing with ElfW (Half) values, since they can exceed 2**31
4826 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4827 (entry_address): Omit unused NUM arg. All uses changed.
4828
a261c53e
JL
48292013-05-07 Juri Linkov <juri@jurta.org>
4830
4831 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4832 to the string converted from number with `Fnumber_to_string'.
4833 (Bug#14254)
4834
2b66427d
PE
48352013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4838 This fixes a problem introduced by my previous change.
4839
15acfe41
GM
48402013-05-07 Glenn Morris <rgm@gnu.org>
4841
4842 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4843
5ea03bf5
JD
48442013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4845
4846 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4847
e0c9d565
PE
48482013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4849
4850 Static checking by GCC 4.8.0.
4851 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4852 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4853 (x_get_monitor_attributes_fallback)
4854 (x_get_monitor_attributes_xinerama)
4855 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4856 Define only if USE_GTK.
4857 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4858 (x_get_monitor_attributes_fallback): Omit unused locals.
4859 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4860 Use double, not float, to avoid mixed-mode floating point arithmetic.
4861
4e3f9230
YM
48622013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4863 Jan Djärv <jan.h.d@swipnet.se>
4864
4865 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4866 (XINERAMA_CFLAGS): New macros.
4867 (ALL_CFLAGS, LIBES): Use them.
4868
4869 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4870 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4871 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4872 (syms_of_xfns): DEFSYM them.
4873 (struct MonitorInfo): New struct.
4874 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4875 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4876 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4877 (x_get_monitor_attributes_xinerama): New functions.
4878 (Fx_display_monitor_attributes_list): New primitive.
4879 (syms_of_xfns): Defsubr it.
4880
4881 * xterm.h (x_display_info): Add Xatom_net_workarea and
4882 Xatom_net_current_desktop.
4883
4884 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4885 and dpyinfo->Xatom_net_current_desktop.
4886
05839b6a
EZ
48872013-05-06 Eli Zaretskii <eliz@gnu.org>
4888
4889 * xdisp.c (pos_visible_p): Use the special code for finding the
4890 beginning of a display property or overlay for any "replacing"
4891 display property, not just for display strings. This solves
4892 incorrect reporting of position by posn-at-point. (Bug#14241)
4893
dc4a2ee0
PE
48942013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4895
5ee94506
PE
4896 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4897 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4898 Verify that ElfW (Half) fits in int.
4899 (fatal): Use same signature as lisp.h.
4900 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4901 configure and build with -DUNEXELF_DEBUG without worrying about
4902 other modules that use DEBUG.
4903 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4904 possibly-wide integers now uses it instead of plain fprintf.
4905 (entry_address): New function, which avoids problems with 32-bit
4906 overflow on 64-bit hosts.
4907 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4908 (round_up): Don't assume the remainder fits in int.
4909 (find_section): Use bool for boolean. Simplify debug code.
4910 (unexec): Don't assume file sizes fit in int or size_t.
4911 Omit unnecessary trailing newline in 'fatal' format.
4912 Use strerror rather than outputting decimal error number.
4913 Remove unused code when emacs is not defined;
4914 this file relies on Emacs now.
4915 Don't assume e_phnum and e_shnum are positive.
4916
dc4a2ee0
PE
4917 * regex.c: Fix problems when DEBUG is defined.
4918 (extract_number, extract_number_and_incr): Define regardless of
4919 whether DEBUG is defined; that's simpler and makes the code less
4920 likely to go stale in the normal case when DEBUG is not defined.
4921 Return int rather than taking an int * arg. All callers changed.
4922 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4923 Remove, replacing with ...
4924 (DEBUG_PRINT): New macro. All callers changed.
4925 (DEBUG_COMPILES_ARGUMENTS): New macro.
4926 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4927 (print_compiled_pattern, print_double_string) [DEBUG]:
4928 Use prototype rather than old-style definition.
4929 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4930 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4931 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4932 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4933 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4934 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4935 This matters only when DEBUG is defined.
4936
14c7ed05
EZ
49372013-05-05 Eli Zaretskii <eliz@gnu.org>
4938
4939 * xdisp.c (set_iterator_to_next): Set the
4940 ignore_overlay_strings_at_pos_p flag only if we are _really_
4941 iterating over an overlay string, as indicated by the
4942 current.overlay_string_index member. (Bug#14306)
4943
e6076b1b
JD
49442013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4945
4946 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4947 to where it is used, to avoid autorelease issues (Bug#14050).
4948
cbee2131
PE
49492013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4950
4951 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4952 * fileio.c (syms_of_fileio): Implement this.
4953 * filelock.c (create_lock_file): If symbolic links don't work, so
4954 we use a regular file as a lock file, do not fsync the lock file;
4955 it's not needed.
4956
30c7e542
SM
49572013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4958
4959 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4960 (syms_of_minibuf): Adjust accodingly.
4961 * lread.c (Fread):
4962 * callint.c (Fcall_interactively): Adjust calls accordingly.
4963
5bebd186
EZ
49642013-05-04 Eli Zaretskii <eliz@gnu.org>
4965
4966 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4967 w->contents is a buffer before computing everything else.
4968 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4969
4970 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4971 assertion violations. (Bug#14062)
4972
0fb0a4f3
DR
49732013-05-01 David Reitter <david.reitter@gmail.com>
4974
4975 * nsfns.m (ns_tooltip): Initialize.
4976
9e63b4a5
EZ
49772013-04-28 Eli Zaretskii <eliz@gnu.org>
4978
4979 * coding.c (decode_coding_gap): Don't remove the character before
4980 a newline unless it's a CR character. (Bug#14287)
4981
ad60824e
DN
49822013-04-28 Dan Nicolaescu <dann@gnu.org>
4983
4984 * dispextern.h (struct face): Move enum face_underline_type
4985 earlier so that bitfields can be in the same word.
4986
edbdcec0
JD
49872013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4988
4989 * nsfns.m (handlePanelKeys): New function.
4990 (EmacsOpenPanel:performKeyEquivalent:)
4991 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4992 arrows/function/control and copy/paste keys (Bug#14296).
4993
0208ede7
JL
49942013-04-27 Juri Linkov <juri@jurta.org>
4995
4996 * callint.c (Fcall_interactively): Call `Qread_number' for
4997 interactive code letter `n' instead of using duplicate code.
4998 (Bug#14254)
4999
b8dd59f7
PE
50002013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5001
5002 * systime.h (make_timeval): Declare as 'const'.
5003
8bd722db
KH
50042013-04-27 Kenichi Handa <handa@gnu.org>
5005
5006 * font.c (font_open_entity): Always open a font of manageable
5007 size.
5008
13d0e56f 50092013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5010
f780d632
PE
5011 Port better to AIX (Bug#14258).
5012 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5013 to pacify AIX xlc.
5014
ec509856
KH
50152013-04-24 Kenichi Handa <handa@gnu.org>
5016
5017 * coding.c (decode_coding_iso_2022): When an invalid escape
5018 sequence is encountered, reset the invocation and designation
5019 status to the safest one.
5020
84fc48e5
PE
50212013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5022
5023 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5024 Without this fix, "make distclean" leaves stamp-h1 behind.
5025
806bda47
EC
50262013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5027
5028 * w32fns.c (w32_fullscreen_rect): New function to compute the
5029 window rectangle for the given fullscreen mode.
5030 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5031 longer tunes the window size. This keeps the window's edges flush
5032 with the screen and allows the taskbar to hide itself in fullboth.
5033
5034 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5035 window decorations and uses the entire screen.
5036
5037 * w32term.h (w32_fullscreen_rect) Add prototype.
5038 (struct w32_output): Replace normal_width, normal_height,
5039 normal_top, and normal_left members with a single normal_placement
5040 struct.
5041 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5042 Remove macros.
5043 (FRAME_NORMAL_PLACEMENT): New macro.
5044
9cc2810b
JB
50452013-04-16 Juanma Barranquero <lekktu@gmail.com>
5046
5047 * minibuf.c (Ftest_completion): Silence compiler warning.
5048
fd16b54c
EZ
50492013-04-15 Eli Zaretskii <eliz@gnu.org>
5050
5051 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5052 bug#14062.
fd16b54c
EZ
5053
5054 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5055 parentheses.
5056
5057 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5058 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5059 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5060 parentheses where appropriate.
5061
9e3379a0
PE
50622013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5063
5064 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5065
ddd6b685
EZ
50662013-04-14 Eli Zaretskii <eliz@gnu.org>
5067
5068 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5069 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5070 Mention in the doc string that setting these variables takes
5071 effect only after a call to set-window-buffer. (Bug#14200)
5072
29b79ba1
EZ
50732013-04-13 Eli Zaretskii <eliz@gnu.org>
5074
5075 * indent.c (Fvertical_motion): Don't consider display strings on
5076 overlay strings as display strings on the buffer position we
5077 started from. This prevents vertical cursor motion from jumping
5078 more than one line when there's an overlay string with a display
5079 property at end of line.
5080 Reported by Karl Chen <Karl.Chen@quarl.org> in
5081 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5082
562c6ee9
SM
50832013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5084
5085 * window.c (select_window): `record_buffer' even if window is
5086 already selected (bug#14191).
5087
fcc1fe85
EZ
50882013-04-11 Eli Zaretskii <eliz@gnu.org>
5089
5090 * window.c (Fwindow_end): Test more flags, including the buffer's
5091 last_overlay_modified flag, to determine whether the window's
5092 display is really up-to-date. Prevents the function from
5093 returning a stale value. (Bug#14170)
5094 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5095 current matrix.
5096
f009190a
EZ
50972013-04-10 Eli Zaretskii <eliz@gnu.org>
5098
5099 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5100 garbaged only if it is not already the top frame on its TTY.
5101 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5102 there are GUI frames open in the same session. (Bug#13864)
5103
78ce603d
SM
51042013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5105
5106 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5107 of marking the idle timers directly.
5108
a8036e40
SM
51092013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5110
5111 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5112 tables (bug#14054).
5113
7ffe7ef6
SM
51142013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5115
5116 * window.c (select_window): Don't record_buffer while the invariant is
5117 temporarily broken (bug#14161).
5118
5119 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5120
7d9f6883
EZ
51212013-04-07 Eli Zaretskii <eliz@gnu.org>
5122
5123 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5124
5406cfd9
RF
51252013-04-07 Romain Francoise <romain@orebokech.com>
5126
5127 Ignore additional platform-specific ACL errors (Bug#13702).
5128 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5129 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5130
95c0e83b
JD
51312013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5132
5133 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5134 f->output_data.ns.
5135
876da980
PE
51362013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5137
5138 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5139 This bug was introduced by my 2013-02-25 change that simplified
5140 data_start configuration. Without this change, on GNU/Linux
5141 an Emacs configured with --enable-profiling fails immediately
5142 due to a profiler signal.
5143 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5144 with these flags. On platforms where special flags are needed
5145 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5146 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5147 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5148
7452b7bd
DA
51492013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5150
5151 Get rid of some platform-specific functions examining window
5152 system and its capabilities. This is a partial rework of the
5153 2013-04-05 change.
5154 * lisp.h (have_menus_p): Remove prototype. This function is
5155 replaced with platform-independent window_system_available.
5156 (check_window_system): Move to...
5157 * frame.h (decode_window_system_frame, window_system_available):
5158 ...here, add new prototypes.
5159 * frame.c (window_system_available, decode_window_system_frame):
5160 New functions.
5161 (check_window_system): Platform-independent now.
5162 * xterm.h (x_in_use): Remove declaration.
5163 (check_x_frame):
5164 * w32term.h (check_x_frame):
5165 * nsterm.h (check_x_frame): Remove prototypes. This function
5166 is replaced with platform-independent decode_window_system_frame.
5167 * msdos.c (have_menus_p): Remove.
5168 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5169 Remove platform-specific functions. Use check_window_system,
5170 decode_window_system_frame and check_ns_display_info where
5171 appropriate. Minor style and comment tweaks.
5172 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5173 (check_x_frame): Likewise.
5174 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5175 Likewise.
5176 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5177 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5178 * xmenu.c, xselect.c: All related users changed.
5179
251e9147
KH
51802013-04-03 Kenichi Handa <handa@gnu.org>
5181
5182 The following changes is to optimize the code for reading UTF-8
5183 files.
5184
562c6ee9 5185 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5186 changed. Check EOL format. Do not call adjust_coding_eol_type
5187 here.
5188 (check_utf_8): New function.
5189 (adjust_coding_eol_type): Do nothing if already adjusted.
5190 (detect_coding): Compare the return value of check_ascii with
5191 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5192 (decode_coding_gap): Optimize for valid UTF-8.
5193
8bc369d4
KH
51942013-03-21 Kenichi Handa <handa@gnu.org>
5195
5196 * coding.c (syms_of_coding): Cancel previous change.
5197
5198 * insdel.c (insert_from_gap): Fix previous change.
5199
73931ad1
DA
52002013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5201
5202 Consistently use platform-specific function to detect window system.
5203 * lisp.h (check_window_system): New prototype. This function is
5204 going to replace check_x, check_w32 and check_ns.
5205 (have_menus_p): Mention msdos.c in comment.
5206 * fontset.c (check_window_system_func): Remove. Adjust all users.
5207 * fontset.h (check_window_system_func): Remove prototype.
5208 * nsterm.h (check_ns):
5209 * xterm.h (check_x):
5210 * w32term.h (check_w32): Likewise.
5211 * menu.c (Fx_popup_menu): Use check_window_system.
5212 * msdos.c (check_window_system): Define for MS-DOS.
5213 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5214 * w32fns.c (check_window_system): Likewise for MS-Windows.
5215 * xfns.c (check_window_system): Likewise for X.
5216 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5217 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5218
7216e43b
PE
52192013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5220
5221 Prefer < to > in range checks such as 0 <= i && i < N.
5222 This makes it easier to visualize quantities on a number line.
5223 This patch doesn't apply to all such range checks,
5224 only to the range checks affected by the 2013-03-24 change.
5225 This patch reverts most of the 2013-03-24 change.
5226 * alloc.c (xpalloc, Fgarbage_collect):
5227 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5228 * character.c (string_escape_byte8):
5229 * charset.c (read_hex):
5230 * data.c (cons_to_unsigned):
5231 * dispnew.c (update_frame_1):
5232 * doc.c (Fsubstitute_command_keys):
5233 * doprnt.c (doprnt):
5234 * editfns.c (hi_time, decode_time_components):
5235 * fileio.c (file_offset):
5236 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5237 * font.c (font_intern_prop):
5238 * frame.c (x_set_alpha):
5239 * gtkutil.c (get_utf8_string):
5240 * indent.c (check_display_width):
5241 * keymap.c (Fkey_description):
5242 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5243 * lread.c (read1):
5244 * minibuf.c (read_minibuf_noninteractive):
5245 * process.c (wait_reading_process_output):
5246 * search.c (Freplace_match):
5247 * window.c (get_phys_cursor_glyph):
5248 * xdisp.c (redisplay_internal):
5249 * xsmfns.c (smc_save_yourself_CB):
5250 Prefer < to > for range checks.
5251 * dispnew.c (sit_for): Don't mishandle NaNs.
5252 This fixes a bug introduced in the 2013-03-24 change.
5253 * editfns.c (decode_time_components): Don't hoist comparison.
5254 This fixes another bug introduced in the 2013-03-24 change.
5255
92759988
DA
52562013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5257
5258 * frame.h (struct frame): Drop scroll_bottom_vpos
5259 member becaue all real users are dead long ago.
5260 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5261 * xdisp.c (redisplay_internal): Adjust user.
5262
9a1971bb
GM
52632013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5264
f38ab167
JD
5265 * nsmenu.m (showAtX:Y:for:): setLevel to
5266 NSPopUpMenuWindowLevel (Bug#13998).
5267
6d01f1fe
JD
52682013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5269
5270 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5271 (ns_check_pending_open_menu): Declare.
5272
5273 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5274 (x_activate_menubar): Update the menu with title that matches
5275 ns_get_pending_menu_title, and call
5276 ns_check_pending_openmenu (Bug#12698).
5277 (menuWillOpen:): New method.
5278 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5279
5280 * nsterm.m (menu_will_open_state, menu_mouse_point)
5281 (menu_pending_title): New varaibles.
5282 (ns_get_pending_menu_title, ns_check_menu_open)
5283 (ns_check_pending_open_menu): New functions.
5284
781f4782
DA
52852013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5286
5287 * indent.c (current_column_bol_cache): Remove leftover which is not
5288 used in Fmove_to_column any more.
5289 (current_column, scan_for_column): Adjust users.
5290 * keyboard.c (last_point_position_buffer, last_point_position_window):
5291 Remove leftovers which are not used for recording undo any more.
5292 (command_loop_1, syms_of_keyboard): Adjust users.
5293 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5294 redisplay_window any more.
5295 (move_it_to): Adjust user.
5296
1921c31b
JB
52972013-03-29 Juanma Barranquero <lekktu@gmail.com>
5298
5299 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5300 Update dependencies.
5301
717b8bcd
SM
53022013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5303
5304 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5305 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5306 forward references.
5307
e74aeda8
DA
53082013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5309
5310 * window.h (struct window): Replace hchild, vchild and buffer slots
5311 with the only contents slot. This is possible because each valid
5312 window may have either the child window (in vertical or horizontal
5313 combination) or buffer to display (for the leaf window). Using that,
5314 a lof of operations to traverse and/or change window hierarchies may
5315 be simplified. New member horizontal is used to distinguish between
5316 horizontal and vertical combinations of internal windows.
5317 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5318 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5319 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5320 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5321 Use contents slot, not buffer, where appropriate.
5322 (wset_combination): New function.
5323 (wset_buffer): Add eassert.
5324 (Fframe_first_window): Simplify the loop reaching first window.
5325 (Fwindow_buffer): Use WINDOW_LEAF_P.
5326 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5327 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5328 (unshow_buffer): Convert initial debugging check to eassert.
5329 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5330 (make_parent_window, window_resize_check, window_resize_apply)
5331 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5332 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5333 Adjust to match struct window changes.
5334 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5335 (mark_window_cursors_off, count_windows, get_leaf_windows)
5336 (foreach_window_1): Simplify the loop.
5337 * alloc.c (mark_object): Do not check for the leaf window because
5338 internal windows has no glyph matrices anyway.
5339 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5340 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5341 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5342 (build_frame_matrix_from_window_tree, mirror_make_current)
5343 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5344 (update_window_tree, set_window_update_flags): Simplify the loop.
5345 (sync_window_with_frame_matrix_rows): Enforce live window.
5346 Use contents slot, not buffer, where appropriate.
5347 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5348 and WINDOW_HORIZONTAL_COMBINATION_P.
5349 (make_frame_visible_1): Simplify the loop.
5350 Use contents slot, not buffer, where appropriate.
5351 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5352 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5353 (expose_window_tree): Likewise.
5354 Use contents slot, not buffer, where appropriate.
5355 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5356 to avoid deleted windows. Use contents slot instead of buffer.
5357 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5358 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5359 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5360 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5361
121ab1cd
EZ
53622013-03-28 Eli Zaretskii <eliz@gnu.org>
5363
ef454cf7
EZ
5364 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5365 identify the reasons for assertion violations in bug#14062 and
5366 similar ones.
21e930f8
EZ
5367 (Fx_show_tip): Fix compilation error under
5368 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5369
121ab1cd
EZ
5370 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5371 Reported by <rzl24ozi@gmail.com>.
5372
5c89ca24
DA
53732013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5374
5375 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5376 start marker...
562c6ee9
SM
5377 (unwind_with_echo_area_buffer): ...to restore it here.
5378 This is needed to ensure that...
5c89ca24
DA
5379 (redisplay_window): ...both window markers are valid here,
5380 which is verified by eassert.
5381 * editfns.c (save_excursion_save): Do not assume that
5382 selected_window always displays the buffer.
c7f53895
DA
5383 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5384 Fix comment.
5c89ca24 5385
f557c1b1
SM
53862013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5387
5388 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5389 the upcase table.
5390
40693bba 53912013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5392
5393 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5394
c86f791f
EZ
53952013-03-27 Eli Zaretskii <eliz@gnu.org>
5396
5397 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5398 since MinGW's w32api headers do. This avoids compiler warnings.
5399
5400 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5401 if already defined.
5402
c6e72e17
EZ
54032013-03-26 Eli Zaretskii <eliz@gnu.org>
5404
5405 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5406
54e95010
JD
54072013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5408
5409 * gtkutil.c (style_changed_cb): Check if frame is live and an
5410 X frame (Bug#14038).
5411
b88b62de
EZ
54122013-03-26 Eli Zaretskii <eliz@gnu.org>
5413
a18d7de6
EZ
5414 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5415 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5416 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5417 MinGW64.
8f5e14c8
EZ
5418 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5419 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5420
b88b62de
EZ
5421 Fix incompatibilities between MinGW.org and MinGW64 headers.
5422 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5423
5424 * w32.c (REPARSE_DATA_BUFFER): Guard with
5425 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5426
c074e458
JD
54272013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5428
5429 * xterm.c: Include X11/XKBlib.h
5430 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5431
908589fd
AS
54322013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5433
5434 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5435 written backwards.
5436 * blockinput.h (input_blocked_p): Likewise.
5437 * bytecode.c (exec_byte_code): Likewise.
5438 * callproc.c (call_process_kill, call_process_cleanup)
5439 (Fcall_process): Likewise.
5440 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5441 (Fccl_execute_on_string): Likewise.
5442 * character.c (string_escape_byte8): Likewise.
5443 * charset.c (read_hex): Likewise.
5444 * cm.c (calccost): Likewise.
5445 * data.c (cons_to_unsigned): Likewise.
5446 * dired.c (directory_files_internal, file_name_completion):
5447 Likewise.
5448 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5449 (sit_for): Likewise.
5450 * doc.c (Fsubstitute_command_keys): Likewise.
5451 * doprnt.c (doprnt): Likewise.
5452 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5453 * emacsgtkfixed.c: Likewise.
5454 * fileio.c (file_offset, Fwrite_region): Likewise.
5455 * floatfns.c (Fexpt, fmod_float): Likewise.
5456 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5457 Likewise.
5458 * font.c (font_intern_prop): Likewise.
5459 * frame.c (x_set_alpha): Likewise.
5460 * gtkutil.c (get_utf8_string): Likewise.
5461 * indent.c (check_display_width): Likewise.
5462 * intervals.c (create_root_interval, rotate_right, rotate_left)
5463 (split_interval_right, split_interval_left)
5464 (adjust_intervals_for_insertion, delete_node)
5465 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5466 (merge_interval_right, merge_interval_left, copy_intervals)
5467 (set_intervals_multibyte_1): Likewise.
5468 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5469 * keymap.c (Fkey_description): Likewise.
5470 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5471 * lread.c (openp, read_integer, read1, string_to_number):
5472 Likewise.
5473 * menu.c (ensure_menu_items): Likewise.
5474 * minibuf.c (read_minibuf_noninteractive): Likewise.
5475 * print.c (printchar, strout): Likewise.
5476 * process.c (create_process, Faccept_process_output)
5477 (wait_reading_process_output, read_process_output, send_process)
5478 (wait_reading_process_output): Likewise.
5479 * profiler.c (make_log, handle_profiler_signal): Likewise.
5480 * regex.c (re_exec): Likewise.
5481 * regex.h: Likewise.
5482 * search.c (looking_at_1, Freplace_match): Likewise.
5483 * sysdep.c (get_child_status, procfs_ttyname)
5484 (procfs_get_total_memory): Likewise.
5485 * systime.h (EMACS_TIME_VALID_P): Likewise.
5486 * term.c (dissociate_if_controlling_tty): Likewise.
5487 * window.c (get_phys_cursor_glyph): Likewise.
5488 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5489 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5490 Likewise.
5491 * xfns.c (Fx_window_property): Likewise.
5492 * xmenu.c (set_frame_menubar): Likewise.
5493 * xselect.c (x_get_window_property, x_handle_dnd_message):
5494 Likewise.
5495 * xsmfns.c (smc_save_yourself_CB): Likewise.
5496 * xterm.c (x_scroll_bar_set_handle): Likewise.
5497
2bf7d27a
DA
54982013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5499
5500 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5501 to be optional or nil. Adjust comment and convert it to docstring.
5502 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5503 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5504
a9ebfa0b
PE
55052013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5506
5507 Static checking by GCC 4.8-20130319.
5508 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5509 * process.c (Fset_process_datagram_address)
5510 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5511 * xdisp.c (get_char_face_and_encoding):
5512 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5513 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5514 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5515
4f3576ee
KB
55162013-03-24 Ken Brown <kbrown@cornell.edu>
5517
789b5e9a
KB
5518 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5519 fix compilation on 64-bit Cygwin, where underscores are not
5520 automatically prepended.
5521
4f3576ee
KB
5522 * w32term.c (w32_initialize): Silence compiler warning.
5523
b5b7745f
EZ
55242013-03-23 Eli Zaretskii <eliz@gnu.org>
5525
cdc0d0bd
EZ
5526 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5527 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5528 variables, to save and restore frame dimensions.
5529 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5530 after returning from a 'fullscreen' configuration.
5531 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5532 to avoid races between the main thread and the input thread.
5533
5534 * w32term.h (struct w32_output): New members normal_width,
5535 normal_height, normal_top, normal_left, and prev_fsmode.
5536 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5537 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5538 members of a frame.
5539
b5b7745f
EZ
5540 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5541 'fullscreen' parameter. Always record previous width and height
5542 of the frame, except when switching out of maximized modes, so
5543 that they could be restored correctly, instead of resetting to the
5544 default frame dimensions. Send SC_RESTORE command to the frame,
5545 unless we are going to send SC_MAXIMIZE, to restore the frame
5546 resize hints in the mouse pointer shown by the window manager.
5547 (Bug#14032)
5548
5549 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5550
5551 * lisp.h (get_frame_param): Adjust conditions for prototype
5552 declaration.
5553
a3454eed
KB
55542013-03-22 Ken Brown <kbrown@cornell.edu>
5555
5556 * unexcw.c: Drop unneeded inclusion of w32common.h.
5557 (report_sheap_usage): Declare.
5558 (read_exe_header): Add magic numbers for x86_64.
5559 (fixup_executable): Fix printf format specifier for unsigned long
5560 argument.
5561
5a49b79c
DA
55622013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5563
5564 * frame.h (struct frame): Put menu_bar_window under #ifdef
5565 because this member is not needed when X toolkit is in use.
5566 (fset_menu_bar_window):
5567 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5568 (free_glyphs, update_frame):
5569 * xdisp.c (expose_frame): Likewise.
5570 (display_menu_bar): Likewise. Remove redundant eassert.
5571 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5572 toolkit is in use.
5573
d6723bf7
PE
55742013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5575
7b1123d8
PE
5576 Use functions and constants to manipulate Lisp_Save_Value objects.
5577 This replaces code that used macros and strings and token-pasting.
5578 The change makes the C source a bit easier to follow,
5579 and shrinks the Emacs executable a bit.
5580 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5581 (make_save_value): Change 1st arg from string to enum. All callers
5582 changed.
5583 (INTX): Remove.
5584 (mark_object): Use if, not #if, for GC_MARK_STACK.
5585 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5586 (XSAVE_OBJECT): Now functions, not macros.
5587 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5588 the constant was never used.
5589 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5590 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5591 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5592 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5593 New constants.
5594 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5595 type3 with a single member save_type. All uses changed.
5596 (save_type, set_save_pointer, set_save_integer): New functions.
5597 * print.c (PRINTX): Remove.
5598
d6723bf7
PE
5599 * alloc.c: Remove redundant static declarations.
5600
5f24fa51
DA
56012013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5602
5603 * window.h (struct window): Convert left_col, top_line, total_lines
5604 and total_cols from Lisp_Objects to integers. Adjust comments.
5605 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5606 Remove.
5607 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5608 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5609 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5610 Adjust users where appropriate.
5611
42143acd
DA
56122013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5613
5614 * frame.h (struct frame): Drop resx and resy because the same data is
5615 available from window system-specific output context. Adjust users.
562c6ee9
SM
5616 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5617 New functions to provide defaults when no window system available.
42143acd 5618 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5619 (NUMVAL): Move from xdisp.c.
42143acd
DA
5620 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5621 (Ffont_face_attributes, Fopen_font):
5622 * image.c (gs_load):
5623 * w32font.c (fill_in_logfont):
5624 * xdisp.c (calc_pixel_width_or_height):
5625 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5626 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5627
c0a17406
KH
56282013-03-20 Kenichi Handa <handa@gnu.org>
5629
5630 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5631 to 1 (temporary workaround until a bug related to ASCII
5632 optimization is fixed).
5633
095d384d
DA
56342013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5635
5636 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5637 Signal error if window is not internal. Adjust docstring.
5638 (delete_all_child_windows): Use combination_limit to save the buffer.
5639 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5640 * print.c (syms_of_print): Initialize debugging output not here...
5641 (init_print_once): ...but in a new function here.
5642 * lisp.h (init_print_once): Add prototype.
5643 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5644
748fa866
DA
56452013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5646
5647 * window.c (window_resize_check, window_resize_apply)
5648 (window_from_coordinates, recombine_windows, set_window_buffer)
5649 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5650 (Fsplit_window_internal, Fdelete_window_internal)
5651 (freeze_window_starts): Use bool for booleans.
5652 * window.h (window_frame_coordinates, resize_frame_windows)
5653 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5654
81519fd2
SM
56552013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5656
5657 * dispnew.c (bitch_at_user): Use `user-error'.
5658
6db423a9
KB
56592013-03-17 Ken Brown <kbrown@cornell.edu>
5660
5661 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5662 as return type of image_background. (Bug#13981)
5663 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5664
8f2906f5
JD
56652013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5666
960ce480 5667 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5668 (ns_select): Don't return with result uninitialized.
960ce480 5669
8f2906f5
JD
5670 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5671 and getDirectory.
5672
81519fd2
SM
5673 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5674 New functions.
8f2906f5
JD
5675 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5676 directories. If filename is nil, get directory name (Bug#13932).
5677 Use getFilename and getDirectory.
5678 (getFilename, getDirectory): New methods for EmacsSavePanel and
5679 EmacsOpenPanel.
5680 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5681
cded56c1
PE
56822013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5683
5684 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5685
251e9147 56862013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5687
5688 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5689 (adjust_after_replace): Make it back to static. Delete the third
5690 arg text_at_gap_tail. Cancel the code for handling it.
5691
5692 * coding.h (struct coding_system): New member eol_seen.
5693
5694 * coding.c (detect_ascii): New function.
5695 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5696 when the source bytes are actually scanned. On detecting for
5697 coding_category_utf_8_auto, call detect_ascii instead of scanning
5698 source bytes directly.
5699 (produce_chars): Call insert_from_gap with the new arg 0.
5700 (encode_coding): Likewise.
5701 (decode_coding_gap): Control ASCII optimization by the variable
5702 disable_ascii_optimization instead of #ifndef .. #endif.
5703 Deccode EOL format according to coding->eol_seen.
5704 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5705 variable.
5706
8a44e6d1
KH
5707 * lisp.h (adjust_after_replace): Cancel externing it.
5708 (insert_from_gap): Adjust prototype.
5709
5f795e34
EZ
57102013-03-15 Eli Zaretskii <eliz@gnu.org>
5711
5712 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5713 FULLSCREEN_MAXIMIZED. (Bug#13935)
5714
f258b4be
DA
57152013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5716
5717 * region-cache.c (find_cache_boundary, move_cache_gap)
5718 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5719 Simplify debugging check and convert to eassert. Adjust comment.
5720 (pp_cache): Put under ENABLE_CHECKING.
5721
a5cc4dde
EZ
57222013-03-14 Eli Zaretskii <eliz@gnu.org>
5723
5724 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5725 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5726 and WM_ACTIVATEAPP.
5727 (w32fullscreen_hook): If the frame is visible, reset
5728 f->want_fullscreen flag after changing the frame size. If the
5729 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5730 (Bug#13953)
5731
3fc5e44a
DC
57322013-03-13 Daniel Colascione <dancol@dancol.org>
5733
5734 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5735 too so that these builds can use Cygwin's file conversion
5736 functions. (We've been building and linking cygw32.o all along
5737 and just not using it.)
5738
47d7532e
PE
57392013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5740
5741 File synchronization fixes (Bug#13944).
5742 * Makefile.in (LIB_FDATASYNC): New macro.
5743 (LIBES): Use it.
5744 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5745 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5746 Don't worry about HAVE_FSYNC, since a substitute fsync is
5747 available if the system lacks one.
5748 (Fwrite_regin): Retry fsync if interrupted.
5749
c7ffccaf
EZ
57502013-03-13 Eli Zaretskii <eliz@gnu.org>
5751
4e2df81d 5752 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5753 activated, call w32fullscreen_hook, to make sure the new frame
5754 dimensions are in effect. (Bug#13937)
5755
8a7debc1
DA
57562013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5757
5758 * xdisp.c (init_iterator): Simplify because both character and byte
5759 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5760 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5761 character and byte positions can be obtained from marker.
8a7debc1 5762
7fd8c501
PE
57632013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5764
d9df6f40
PE
5765 Static checking by Sun C 5.12.
5766 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5767 * bytecode.c (exec_byte_code):
5768 * dispnew.c (init_display):
5769 * eval.c (error):
5770 * fileio.c (Fsubstitute_in_file_name):
5771 * keyboard.c (Fevent_convert_list):
5772 * keymap.c (Fsingle_key_description):
5773 * term.c (maybe_fatal, fatal):
5774 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5775 * xsmfns.c (Fhandle_save_session):
5776 Omit unreachable code.
5777 * keymap.c (map_keymap_char_table_item): Cast void * to
5778 a function pointer type; the C Standard requires this.
5779
7fd8c501
PE
5780 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5781 Include <sys/param.h> unconditionally, as that works elsewhere and
5782 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5783 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5784 and FreeBSD now.
5785
a020afb9 5786See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5787
5788;; Local Variables:
5789;; coding: utf-8
aac0c6e3
MR
5790;; End:
5791
ab422c4d 5792 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5793
5794 This file is part of GNU Emacs.
5795
5796 GNU Emacs is free software: you can redistribute it and/or modify
5797 it under the terms of the GNU General Public License as published by
5798 the Free Software Foundation, either version 3 of the License, or
5799 (at your option) any later version.
5800
5801 GNU Emacs is distributed in the hope that it will be useful,
5802 but WITHOUT ANY WARRANTY; without even the implied warranty of
5803 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5804 GNU General Public License for more details.
5805
5806 You should have received a copy of the GNU General Public License
5807 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.