* regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
78779650
AS
12013-08-28 Andreas Schwab <schwab@suse.de>
2
3 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
4 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
5 Remove unused macro definitions.
6 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
7 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA): Only
8 define if emacs.
9
c3c4768d
DA
102013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
11
12 Prefer enum glyph_row_area to int where appropriate.
13 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
14 Fix comment.
15 (window_box, window_box_width, window_box_left, window_box_left_offset)
16 (window_box_right, window_box_right_offset): Adjust prototypes.
17 * xdisp.c (window_box, window_box_width, window_box_left)
18 (window_box_left_offset, window_box_right, window_box_right_offset):
19 Use enum glyph_row_area. Adjust users and tweak comment where needed.
20 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
21 * nsterm.m (ns_clip_to_row):
22 * w32term.c (w32_clip_to_row):
23 * xterm.c (x_clip_to_row): Likewise.
24
6bdcbfe1
DA
252013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
26
27 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
28 (Fprevious_overlay_change): Fast path for buffer with no overlays.
29
50b13cde
PE
302013-08-28 Paul Eggert <eggert@cs.ucla.edu>
31
32 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
33 for portability to hosts where /bin/sh has problems.
34
f60e429a
DA
352013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
36
37 Redesign redisplay interface to drop global output_cursor.
38 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
39 (toplevel): Remove declaration of output_cursor.
40 (set_output_cursor, x_cursor_to): Remove prototype.
41 * window.h (struct window): New member output_cursor.
42 (output_cursor_to): New function to replace RIF member.
43 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
44 (update_text_area, set_window_cursor_after_update): Use it.
45 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
46 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
47 * nsterm.m (ns_update_window_begin, ns_update_window_end):
48 * w32term.c (x_update_window_begin, x_update_window_end):
49 * xterm.c (x_update_window_begin, x_update_window_end):
50 Adjust to use per-window output cursor.
51
43aac990
PE
522013-08-27 Paul Eggert <eggert@cs.ucla.edu>
53
d486344e
PE
54 Simplify SELECT_TYPE-related code.
55 Like EMACS_TIME, this portability layer is no longer needed, since
56 Emacs has been using fd_set as a portability layer for some time.
57 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
58 (SELECT_TYPE): Remove. All uses changed to fd_set.
59 (fd_set) [!FD_SET]: New typedef.
60
43aac990
PE
61 Simplify EMACS_TIME-related code.
62 This portability layer is no longer needed, since Emacs has been
63 using struct timespec as a portability layer for some time.
64 * atimer.h, buffer.h, dispextern.h, xgselect.h:
65 Include <time.h> rather than "systime.h"; that's all that's needed now.
66 * dispnew.c: Include <timespec.h> rather than "systime.h";
67 that's all that's needed now.
68 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
69 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
70 TIMESPEC_RESOLUTION.
71 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
72 LOG10_TIMESPEC_RESOLUTION.
73 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
74 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
75 (make_emacs_time): Remove. All used changed to make_timespec.
76 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
77 (current_timespec): Rename from current_emacs_time. All uses changed.
78 (add_emacs_time): Remove. All uses changed to timespec_add.
79 (sub_emacs_time): Remove. All uses change dot timespec_sub.
80 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
81 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
82 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
83 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
84 (current_timespec): Rename from current_emacs_time. All uses changed.
85 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
86 changed to timespec_cmp.
87 * xgselect.c: Include <timespec.h>, since our .h files don't.
88
d350e350
DA
892013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
90
91 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
92 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
93 Remove the leftovers.
94 * gtkutil.c (toplevel): Do not declare Qxft but include
95 font.h to do so.
96 * image.c (toplevel): Do not declare Vlibrary_cache because
97 it's already done in lisp.h.
98
9fed9729
DA
992013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
100
101 * lisp.h (Mouse_HLInfo): Move from here...
102 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
103 (reset_mouse_highlight): New function.
104 * msdos.c (dos_set_window_size, IT_update_begin)
105 (internal_terminal_init):
106 * nsterm.m (ns_update_window_end, x_free_frame_resources)
107 (ns_initialize_display_info):
108 * w32console.c (initialize_w32_display):
109 * w32term.c (x_update_window_end, x_free_frame_resources)
110 (w32_initialize_display_info):
111 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
112 * window.c (Fdelete_other_windows_internal):
113 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
114 * termchar.h (toplevel):
115 * xterm.h (toplevel): Include dispextern.h.
116
f462f075
PE
1172013-08-26 Paul Eggert <eggert@cs.ucla.edu>
118
119 Fix minor problems found by static checking.
120 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
121 (expect): Avoid nested-if warning.
122 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
123 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
124 * nsterm.h, nsterm.m (ns_select):
125 * xgselect.c, xgselect.h (xg_select):
126 Adjust signature to better match pselect's.
127 * nsterm.m (ns_select):
128 Don't set *TIMEOUT, since pselect doesn't.
129 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
130 diagnostic about assigning const char * to it.
131 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
132
068f9124
SM
1332013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
134
135 * lread.c (substitute_object_recurse): Handle hash-tables as well
136 (bug#15190).
137
f5adc984
PE
1382013-08-26 Paul Eggert <eggert@cs.ucla.edu>
139
1fc8eb33
PE
140 Fix unlikely core dump in init_tty, and simplify terminfo case.
141 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
142 The old version incorrectly dumped core if malloc returned a
143 buffer containing only non-NUL bytes.
144 (init_tty): Do not allocate or free termcap buffers; the
145 struct does that for us now.
146 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
147 (struct tty_display_info): Define members termcap_term_buffer and
148 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
149 use them. Allocate them directly in struct rather than indirectly
150 via a pointer, to simplify init_tty.
151
f5adc984
PE
152 * frame.c (check_minibuf_window): Initialize 'window' properly,
153 so that Emacs reliably aborts later if 'window' is not initialized.
154
efec3894
JD
1552013-08-26 Jan Djärv <jan.h.d@swipnet.se>
156
157 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
158 of VoidSymbol (Bug#15154).
159
e1d0341e
DA
1602013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
161
162 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
163 mouse_face_beg_y and mouse_face_end_y.
164 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
165 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
166 Adjust users and update comment where appropriate.
167
bfff6445
MR
1682013-08-26 Martin Rudalics <rudalics@gmx.at>
169
170 * frame.c (check_minibuf_window): New function.
068f9124
SM
171 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
172 Call check_minibuf_window (Bug#15183).
bfff6445 173
c80016b3
DA
1742013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
175
176 * window.h (struct window): Replace last_cursor with last_cursor_vpos
177 because this is the only last cursor data we need to keep and consult.
178 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
179 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
180 Adjust users.
181
de396731
DA
1822013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
183
068f9124
SM
184 Fix recovering from possible decompression error.
185 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 186 the position where the partially decompressed data ends, and
447218dd 187 should count how many bytes was produced so far.
de396731
DA
188 * decompress.c (struct decompress_unwind_data): Add nbytes member.
189 (unwind_decompress): Really delete partially uncompressed data.
190 (Fzlib_decompress_region): Take decompressed data size into account.
191
c76826d9
DA
1922013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
193
194 * syntax.c (init_syntax_once): Adjust comment and do an early
195 initialization of Qchar_table_extra_slots just once...
196 * casetab.c (init_casetab_once):
197 * category.c (init_category_once):
198 * character.c (syms_of_character):
199 * coding.c (syms_of_coding):
200 * xdisp.c (syms_of_xdisp): ...and omit it here.
201
b34454d0
EZ
2022013-08-24 Eli Zaretskii <eliz@gnu.org>
203
11f20add
EZ
204 * xdisp.c (get_next_display_element): Don't apply to characters
205 from a display vector the logic of setting it->end_of_box_run_p
206 suitable for characters from a buffer. (Bug#15175)
207
b34454d0
EZ
208 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
209 to handle directories, rather than '_utime' which doesn't.
210 (Bug#15176)
211
6e1b469e
JD
2122013-08-24 Jan Djärv <jan.h.d@swipnet.se>
213
214 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
215 or fullscreen (Bug#14627).
216
9c05bccf
PE
2172013-08-24 Paul Eggert <eggert@cs.ucla.edu>
218
219 System-dependent integer overflow fixes.
220 * process.c (Fset_process_window_size): Signal an error if
221 the window size is outside the range supported by the lower level.
222 * sysdep.c (set_window_size): Return negative on error,
223 nonnegative on success, rather than -1, 0, 1 on not in system,
224 failure, success. This is simpler. Caller changed.
225 (serial_configure): Remove unnecessary initialization of local.
226 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
227 size fits in unsigned long; this isn't true on some 32-bit hosts.
228 Avoid buffer overrun if some future version of /proc/meminfo has a
229 variable name longer than 20 bytes.
230 (system_process_attributes) [__FreeBSD__]:
231 Don't assume hw.availpages fits in 'int'.
232
c365c355
PE
2332013-08-23 Paul Eggert <eggert@cs.ucla.edu>
234
235 Don't let very long directory names overrun the stack.
236 Fix some related minor problems involving "//", vfork.
237 * callproc.c (encode_current_directory): New function.
238 (call_process): Don't append "/"; not needed.
239 * fileio.c (file_name_as_directory_slop): New constant.
240 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
241 this can save the caller having to alloca.
242 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
243 Use SAFE_ALLOCA, not alloca.
244 (directory_file_name, Fexpand_file_name): Leave leading "//"
245 alone, since it can be special even on POSIX platforms.
246 * callproc.c (call_process):
247 * process.c (Fformat_network_address):
248 * sysdep.c (sys_subshell):
249 Use encode_current_directory rather than rolling our own.
250 (create_process): No need to encode directory; caller does that now.
251 * process.h (encode_current_directory): New decl.
252 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
253 Rework to avoid 'goto xyzzy;'.
254
6c6014d4
EZ
2552013-08-23 Eli Zaretskii <eliz@gnu.org>
256
257 * xdisp.c (handle_face_prop): If the default face was remapped use
258 the remapped face for strings from prefix properties. (Bug#15155)
259
9997ec56
DA
2602013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
261
262 Minor cleanup for redisplay interface and few related functions.
263 * frame.h (enum text_cursor_kinds): Move from here...
264 * dispextern.h (enum text_cursor_kinds): ...to here.
265 (toplevel): Drop unnecessary declarations.
266 (struct redisplay_interface): Use bool and enum text_cursor_kinds
267 in update_window_end_hook and draw_window_cursor functions.
268 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
269 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
270 * w32term.c (x_update_window_end,w32_draw_window_cursor):
271 * xterm.c (x_update_window_end, x_draw_window_cursor):
272 * xdisp.c (display_and_set_cursor, update_window_cursor)
273 (update_cursor_in_window_tree, x_update_cursor): Use bool and
274 enum text_cursor_kinds where appropriate.
275
7f780da6
DA
2762013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
277
278 Redesign redisplay interface to drop updated_row and updated_area.
279 * dispextern.h (updated_row, updated_area): Remove declaration.
280 (struct redisplay_interface): Pass glyph row and row area parameters
281 to write_glyphs, insert_glyphs and clear_end_of_line functions.
282 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
283 Adjust prototypes.
284 * dispnew.c (updated_row, updated_area): Remove.
285 (redraw_overlapped_rows, update_window_line): Adjust user.
286 (update_marginal_area, update_text_area): Likewise. Pass updated row
287 as a parameter. Prefer enum glyph_row_area to int where appropriate.
288 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
289 Adjust users.
290
26495794
PE
2912013-08-22 Paul Eggert <eggert@cs.ucla.edu>
292
293 * process.c (flush_pending_output): Remove stub.
294 All uses removed.
295
4a88129a
PE
2962013-08-21 Paul Eggert <eggert@cs.ucla.edu>
297
298 * callproc.c: Fix race that killed background processes (Bug#15144).
299 (call_process): New arg TEMPFILE_INDEX. Callers changed.
300 Record deleted process-id in critical section, not afterwards.
301 Don't mistakenly kill process created by a call-process invocation
302 that discards output and does not wait.
303
0c5307b0
DA
3042013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
305
306 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
307 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
308 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
309 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
310 to shut up compiler in mark_object.
311 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
312
0d7c1e66
PE
3132013-08-21 Paul Eggert <eggert@cs.ucla.edu>
314
315 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
316 We can't portably rely on PTY_OPEN doing that, even if
317 it calls posix_openpt with O_CLOEXEC.
318
3f246b65
KH
3192013-08-20 Kenichi Handa <handa@gnu.org>
320
321 * character.c (string_char): Improve commentary.
322
8c2f38aa
PE
3232013-08-20 Paul Eggert <eggert@cs.ucla.edu>
324
325 * image.c (SIGNATURE_DIGESTSIZE): Remove.
326 (struct animation_cache): Make signature a flexible array member.
327 All uses changed. This is a tad slower but may insulate us better
328 from future changes to ImageMagick.
329
bb566cea
PE
3302013-08-19 Paul Eggert <eggert@cs.ucla.edu>
331
332 * image.c: Shrink memory needed for animation cache.
333 (SIGNATURE_DIGESTSIZE): New constant.
334 (struct animation_cache): Make 'signature' a fixed size array of bytes.
335 (imagemagick_create_cache): Copy the signature. This saves
336 several KB of memory that ImageMagick wastes per signature.
337 Don't bother updating the update_time, as the caller does that now.
338 (imagemagick_prune_animation_cache): Don't destroy the signature, as
339 it's a fixed size struct member now.
340 (imagemagick_get_animation_cache): Always destroy the signature,
341 as it's now imagemagick_create_cache's responsibility to copy it.
342 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
343 and use memcmp rather than strcmp.
344 eassert that ImageMagick returns a signature of the specified length.
345
6da26928
LMI
3462013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
347
348 * image.c (imagemagick_get_animation_cache): Don't segfault on
349 each invocation.
453f4022
LMI
350 (imagemagick_get_animation_cache): Revert to previous definition
351 so that it actually works. But keep the memory leak fix.
352 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 353
22490125
PE
3542013-08-19 Paul Eggert <eggert@cs.ucla.edu>
355
d0139df5
PE
356 * image.c: Fix animation cache signature memory leak.
357 Fix some other minor performance problems while we're at it.
358 (imagemagick_create_cache): Clear just the members that
359 need clearing. Don't set update_time, as caller does that now.
360 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
361 Simplify by using pointer-to-pointer instead of a prev pointer.
362 (imagemagick_prune_animation_cache): Use make_emacs_time rather
363 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
364 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
365 it's already a copy. Free the signature probe unless it's cached.
366
22490125
PE
367 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
368 This was introduced by my 2013-08-12 fix for Bug#15035.
369
deb31e75
DA
3702013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
371
372 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
373 (imagemagick_prune_animation_cache): Now static.
374
319a4d03
LMI
3752013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
376
377 * image.c (imagemagick_get_animation_cache): Don't segfault when
378 pruning all entries.
379
f747d82e
KB
3802013-08-18 Ken Brown <kbrown@cornell.edu>
381
382 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
383 static heap if ENABLE_CHECKING is defined.
384 (max_bss_sbrk_ptr): New variable.
385 (bss_sbrk): Use it.
386 (report_sheap_usage): Report maximum static heap usage instead of
387 ending static heap usage.
388
d2c28fab
EZ
3892013-08-17 Eli Zaretskii <eliz@gnu.org>
390
391 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
392 of zlib_initialized according to the results of calling
393 init_zlib_functions.
394
274ff63f
LMI
3952013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
396
397 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 398 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
399 (imagemagick_load_image): Remove the ping_wand code, which only
400 apparently saved time on invalid animated images, and slowed down
401 everything else. Optimise for the common case.
274ff63f 402
2bede2ed
XF
4032013-08-16 Xue Fuqiao <xfq.free@gmail.com>
404
70ff8240
XF
405 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
406
de179a3e
XF
407 * editfns.c (insert_before_markers): Mention overlay in the doc string.
408
2bede2ed
XF
409 * marker.c (set_marker): Remove documentation of undefined behavior.
410
703dbeba
LMI
4112013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
412
413 * image.c (imagemagick_compute_animated_image): Animate correctly
414 when sub-images are smaller than the main image.
1d18b1e6
LMI
415 (imagemagick_compute_animated_image): Setting the iterator row to
416 zero is apparently not allowed.
79670014
LMI
417 (imagemagick_compute_animated_image): Allow images that say they
418 have sub-images that are bigger than the main image, but just crop
419 them.
703dbeba 420
63216c5e
JD
4212013-08-15 Jan Djärv <jan.h.d@swipnet.se>
422
423 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
424
a5b5f73f
LMI
4252013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
426
427 * image.c (imagemagick_compute_animated_image): Respect the GIF
428 disposal methods.
429
0fe73012
KB
4302013-08-15 Ken Brown <kbrown@cornell.edu>
431
432 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
433 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
434 needed.
435
691a357f
PE
4362013-08-15 Paul Eggert <eggert@cs.ucla.edu>
437
438 Fix minor problems found by static checking.
439 * frame.c (delete_frame):
440 * xdisp.c (next_element_from_display_vector):
441 Avoid uninitialized local.
442 * image.c (imagemagick_compute_animated_image): Port to C89.
443 Prefer usual GNU indentation style for loops.
444 Be more careful about bizarrely large sizes, by using ptrdiff_t
445 instead of int.
446
42fe2e88
DA
4472013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
448
449 Fix infinite frame selection loop (Bug#15025).
450 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
451
d39a3da6
EZ
4522013-08-15 Eli Zaretskii <eliz@gnu.org>
453
068f9124
SM
454 * xdisp.c (compute_window_start_on_continuation_line):
455 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
456 to make sure we end up setting the window start at the leftmost
457 visible character of the display line. This avoids funky
458 horizontal shifting because the window start is not kept on the
459 same position. (Bug#15090)
05426239
EZ
460 (next_element_from_display_vector): Support 'box' face attribute
461 in the face definitions of a display vector. (Bug#15099)
d39a3da6 462
6e856b69
LMI
4632013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
464
465 * image.c (imagemagick_compute_animated_image): Implement animated
466 images (bug#14700).
995be755
LMI
467 (imagemagick_compute_animated_image): Fix some compilation
468 warnings. Implement a very simple cache to make the animation
469 usable at all, but it should be replaced with a per-image cache.
6e856b69 470
d5a1acfa
DA
4712013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
472
473 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
474 to do `for' loops over alist values.
475 * buffer.h (FOR_EACH_BUFFER):
476 * process.c (FOR_EACH_PROCESS): Use it.
477 (handle_child_signal, status_notify, Fget_buffer_process)
478 (kill_buffer_processes): Use FOR_EACH_PROCESS.
479
9c253307
DA
4802013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
481
482 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
483 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
484 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
485 to xzalloc and so avoid redundant call to memset.
486 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
487 members because it is allocated with xzalloc and so already zeroed.
488
05e64f9f
KB
4892013-08-14 Ken Brown <kbrown@cornell.edu>
490
491 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
492 (Bug#15094).
493
5b71542d
DA
4942013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
495
496 Utility function and macro to copy Lisp string to C string.
497 * lisp.h (xlispstrdupa): New macro.
498 (xlispstrdup): New prototype.
499 * alloc.c (xlispstrdup): New function.
500 * callint.c (Fcall_interactively):
501 * fileio.c (Ffile_name_directory, Fexpand_file_name)
502 (Fsubstitute_in_file_name):
503 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
504 * image.c (x_create_bitmap_from_file):
505 * w32term.c (w32_term_init):
506 * xterm.c (x_term_init): Use xlispstrdup.
507
71530c97
LMI
5082013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
509
4ce82fb8
LMI
510 * image.c (imagemagick_load_image): Make animated pictures work.
511 There's still some problems with background color settings, though
512 (bug#14700).
513
71530c97
LMI
514 * decompress.c (unwind_decompress): Always restore point.
515
7510a061
XF
5162013-08-14 Xue Fuqiao <xfq.free@gmail.com>
517
518 * marker.c (set_marker): Reformat documentation.
519
01c3051f
PE
5202013-08-14 Paul Eggert <eggert@cs.ucla.edu>
521
aab1fcdf
PE
522 * xdisp.c (cursor_type_changed): Now static.
523
01c3051f
PE
524 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
525 Use changed. This avoids the need to call xmalloc and for the
526 caller to call xfree, and avoids memory leaks in some situations.
527
2084152a
DA
5282013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
529
530 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
531 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
532 (redisplay_window): If window_end_valid is cleared due to non-zero
533 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
534 so do not call to try_cursor_movement for that window.
2084152a 535
02455cb6
DA
5362013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
537
538 * window.h (struct window): Convert window_end_pos and
539 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
540 (wset_window_end_pos, wset_window_end_vpos): Remove.
541 * dispnew.c (adjust_glyph_matrix):
542 * window.c (Fwindow_end, replace_window, set_window_buffer)
543 (make_window):
544 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
545 (set_vertical_scroll_bar, redisplay_window, try_window)
546 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
547 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
548 (note_mouse_highlight): Adjust users.
549 (try_cursor_movement): Likewise. Convert old precondition to eassert.
550 Add comment.
551
da5707e8
DA
5522013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
553
554 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
555 * image.c (imagemagick_filename_hint): Use `const char *' and
556 prefer SSDATA to SDATA to avoid warnings.
557
25554267
DA
5582013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
559
560 Cleanup window fringes, margins and scroll bars adjustments.
561 * window.c (set_window_fringes, set_window_margins)
562 (set_window_scroll_bars, apply_window_adjustment): New functions.
563 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
564 (Fset_window_scroll_bars): Use them.
565
38a2c910
DA
5662013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
567
568 * window.h (struct window): Convert scroll_bar_width
569 from Lisp_Object to integer. Adjust comment.
570 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
571 Adjust users.
572 * window.c (wset_scroll_bar_width): Remove.
573 (make_window): Initialize scroll_bar_width.
574 (Fsplit_window_internal): Use direct assignment.
575 (Fset_window_configuration, save_window_save):
576 Convert Lisp_Object to integer and back where appropriate.
577 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
578 bar was actually changed, and mention this in docstring.
579
2d065031
PE
5802013-08-13 Paul Eggert <eggert@cs.ucla.edu>
581
582 * decompress.c: Minor simplifications.
583 (Fzlib_decompress_region): Don't bother verifying
584 that avail_out <= UINT_MAX, as that was confusing.
585 Mention the restriction in a comment instead.
586 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
587
a5bd5abb
JD
5882013-08-13 Jan Djärv <jan.h.d@swipnet.se>
589
590 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
591 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
592
66e7901a
LMI
5932013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
594
595 * image.c (imagemagick_filename_hint): Check for errors in the
596 alist structure.
597
2fa611b7
EZ
5982013-08-13 Eli Zaretskii <eliz@gnu.org>
599
600 * window.c (Fwindow_margins): Return nil when there's no marginal
601 area, as per the documented API.
602
603 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
604 Fmake_vector, as scroll bar's struct members are not all Lisp
605 objects now. This avoids crashes in GC.
606
607 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
608 bool, so its address could be taken.
609
8259030d
LMI
6102013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
611
612 * image.c (imagemagick_filename_hint): New function to possibly
613 apply `image-content-type-suffixes'.
614 (imagemagick_load_image): Use it.
615
866c710e
EZ
6162013-08-13 Eli Zaretskii <eliz@gnu.org>
617
618 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
619 if loading zlib failed.
620
f10490f0
JD
6212013-08-13 Jan Djärv <jan.h.d@swipnet.se>
622
96311be7
JD
623 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
624 2013-08-13 checkin below. Change bool to BOOL, rule is:
625 All Obj-C code uses BOOL, except for interfaces callable from C.
626
f10490f0
JD
627 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
628
c8ae93b0
DA
6292013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
630
631 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
632 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
633 bool instead of BOOL.
634 * w32term.h (struct scroll_bar): Convert fringe_extended_p
635 from Lisp_Object to bitfield. Adjust comment.
636 * w32term.c (x_scroll_bar_create): Adjust user.
637 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
638 * xterm.c (XTset_vertical_scroll_bar): Likewise.
639 Use bool for boolean.
640 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
641 to `unsigned int' when defining a bitfield.
642
53b64418
PE
6432013-08-13 Paul Eggert <eggert@cs.ucla.edu>
644
645 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
646
eeaf9bf3
DA
6472013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
648
649 * window.h (struct window): Convert left_margin_cols and
650 right_margin_cols from Lisp_Objects to integers. Adjust comment.
651 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
652 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
653 Adjust users.
654 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
655 Adjust comment.
656 (showing_window_margins_p, update_window_line, update_frame_1):
657 * fringe.c (draw_fringe_bitmap_1):
658 * xdisp.c (window_box_width): Adjust users.
659 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
660 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
661 Use direct assignment.
662 (Fset_window_configuration, save_window_save, Fwindow_margins):
663 Convert Lisp_Object to integer and back where appropriate.
664 (Fset_window_margins): Adjust user. Return t if any margin
665 was actually changed, and mention this in docstring.
666
956720af
XF
6672013-08-13 Xue Fuqiao <xfq.free@gmail.com>
668
f73f4ce6 669 * syntax.c (forward_word):
956720af
XF
670 * cmds.c (forward_char, backward_char): Mention the optional argument.
671
9e37ee3b
DA
6722013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
673
674 * window.h (struct window): Convert left_fringe_width
675 and right_fringe_width from Lisp_Objects to integers.
676 Adjust comment.
677 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
678 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
679 * window.c (wset_left_fringe_width, wset_right_fringe_width):
680 Remove.
681 (make_window): Initialize new integer fields to -1.
682 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
683 (Fset_window_configuration, save_window_save):
684 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
685 (Fset_window_fringes): Adjust user. Return t if any fringe
686 was actually changed, and mention this in docstring.
687
e4375ca7
DA
6882013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
689
690 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
691 * nsfns.m (x_set_cursor_type):
692 * w32fns.c (x_set_cursor_type):
693 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
694 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 695
a45543bc
DA
6962013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
697
698 * font.c (clear_font_cache): New function, stripped from...
699 (Fclear_font_cache): ...here, which now uses the function
700 above. Adjust comment.
701 * font.h (clear_font_cache): Add prototype.
702 * xfaces.c (clear_face_cache): Use clear_font_cache.
703
ae966a86
DA
7042013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
705
706 * window.c (Fset_window_start): Compare `w', not `window' because
707 `w' might not be equal to `window' after call to decode_live_window.
708
297a545b
PE
7092013-08-12 Paul Eggert <eggert@cs.ucla.edu>
710
711 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
712 This fixes a problem introduced by the Bug#15035 patch
713 when using GPG. Reported by Herbert J. Skuhra.
714
aa942e2b
EZ
7152013-08-12 Eli Zaretskii <eliz@gnu.org>
716
717 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
718 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
719 not yet initialized.
720
7699d09e
LMI
7212013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
722
723 * decompress.c (Fzlib_decompress_region): Support zlib
724 decompression, too, and rename.
725
1d238bc7
PE
7262013-08-12 Paul Eggert <eggert@cs.ucla.edu>
727
728 Minor zlib configuration tweaks.
729 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
730 Don't assume presence of fn_inflateInit2_ zlib internal function.
731
8a44a184
LMI
7322013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
733
734 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
735 include the zlib prefix.
736
594a4307
EZ
7372013-08-12 Eli Zaretskii <eliz@gnu.org>
738
739 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
740 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
741 define static variables that are pointers to zlib functions to be
742 dynamically loaded.
743 (init_zlib_functions) [WINDOWSNT]: New function.
744 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
745 New macros.
746 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
747 macros instead of invoking the zlib functions directly.
068f9124
SM
748 (syms_of_decompress): DEFSYM Qzlib_dll.
749 Staticpro Szlib_available_p.
594a4307 750
d2e113bc
DA
7512013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
752
753 Avoid looping over all frame windows to freeze and unfreeze.
754 * window.h (struct window): Drop frozen_window_start_p.
755 (freeze_window_starts): Drop prototype.
756 * frame.h (struct frame): New frozen_window_starts flag.
757 (FRAME_WINDOWS_FROZEN): New macro.
758 * window.c (freeze_window_start, freeze_window_starts):
759 Remove.
760 (select_window, replace_window): Adjust users.
761 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
762 (window_frozen_p): New function.
763 (redisplay_window): Use it.
764
94fcd171
PE
7652013-08-12 Paul Eggert <eggert@cs.ucla.edu>
766
767 Fix some fd issues when running subprocesses (Bug#15035).
768 Fix bugs that can leak files or file descriptors on errors.
769 Don't unlink open temp files, as that's hard for users to diagnose
770 when things go awry (e.g., temp disk exhausted).
771 Don't bother to lock temp files. Check for invalid recursion.
772 * callproc.c (synch_process_fd): Remove. All uses removed.
773 (synch_process_tempfile): New var or macro.
774 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
775 New constants.
776 (record_kill_process): New arg, the temp name. All callers changed.
777 (delete_temp_file): Now just a simple wrapper around unlink.
778 (call_process_kill): New arg, the call_process_fd array.
779 Close them all. Clear synch_process_pid. Remove the temp file,
780 or arrange for it to be removed.
781 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
782 that's been moved to synch_process_tempfile. Caller changed.
783 Do not remove the tempfile; that's now call_process_kill's
784 responsibility.
785 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
786 call_process_kill; the caller now does that.
787 (call_process_cleanup): Do not close the process fd; that's now
788 call_process_kill's responsibility.
789 (Fcall_process): Implement via new function call_process, which
790 has most of the old body of Fcall_process, but with a different API.
791 (call_process): New function that does not open or close filefd if
792 it is nonnegative. Record which fds need to be closed, and let
793 call_process_kill close (and remove the tempfile, on MSDOS) on error.
794 Signal an error if invoked recursively (could be done via a hook).
795 Simplify creation of the tempfile in the MSDOS case.
796 Don't create the output file until after checking for the executable.
797 Report any failure to open /dev/null.
798 Don't open /dev/null for writing twice; once is enough.
799 Don't create pipe if all output is being discarded or sent to file.
800 Don't worry about setting up the coding system or reading from the
801 pipe if all output is being discarded.
802 Hoist fd_error local into top level, to lessen block nesting.
803 Don't record deleted pid here; now done by Fcall_process_region.
804 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
805 and note its success in synch_process_tempfile.
806 Do not leak resources when child_setup fails.
807 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
808 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
809 (create_temp_file): Now returns open fd, with an additional
810 Lisp_Object * argument to return the name. All callers changed.
811 Do not close the file; rewind it instead, and leave it open for
812 the caller. Do not lock the temp file. Unwind-protect the file
813 and the file-descriptor.
814 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
815 If an asynchrounous process, record it here, not in call_process.
816 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
817 * eval.c (set_unwind_protect): New function.
818 * fileio.c (write_region): New function, generalized from the
819 old Fwrite_region. Do not lock temp files.
820 (Fwrite_region): Use it.
821 * lisp.h (set_unwind_protect, write_region): New decls.
822 * process.c: Include <verify.h>.
823 (make_process): Mark fds as initially closed.
824 (deleted_pid_list): Now a list of pid-filename pairs.
825 All uses changed.
826 (close_process_fd): New function.
827 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
828 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
829 New constants. Verify that their number matches PROCESS_OPEN_FDS.
830 (create_process, create_pty, Fmake_serial_process)
831 (server_accept_connection): Record which fds need to be closed,
832 and let deactivate_process close them.
833 (Fmake_network_process): Do not discard the unwind-protect
834 until it's safe to do so.
835 (deactivate_process): Close the fds opened by create_process etc.
836 (Fprocess_send_eof): Adjust to new way of recording open fds.
837 Report an error if /dev/null can't be opened, instead of aborting.
838 * process.h (PROCESS_OPEN_FDS): New constant.
839 (struct Lisp_Process): New member open_fds.
840 (record_kill_process, record_deleted_pid): Adjust signatures.
841 (record_deleted_pid): Move decl here ...
842 * syswait.h (record_deleted_pid): ... from here.
843
d0e615c3
PE
8442013-08-11 Paul Eggert <eggert@cs.ucla.edu>
845
846 * decompress.c: Fix bugs with large buffers and weird inputs.
847 Tune a bit. Reindent as per usual Emacs style.
848 (BUFFER_SIZE): Remove.
849 (Fdecompress_gzipped_region): Do not mishandle input buffers with
850 more than UINT_MAX bytes. Decompress into the gap instead of into
851 an auto buffer, as this should avoid copying. Return nil if
852 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
853 set immediate_quit; we shouldn't trust zlib code that much.
854
313546eb
LMI
8552013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
856
99a32242
LMI
857 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
858 errors, and really move the gap to where we want it.
859
313546eb
LMI
860 * lisp.h: Include decompress.c support.
861
862 * emacs.c (main): Include decompress.c support.
863
864 * Makefile.in: Include -lz if present.
865
d2d699ac
JD
8662013-08-11 Jan Djärv <jan.h.d@swipnet.se>
867
f90e3ebd
JD
868 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
869 (initWithTitle:): Initialize frame to 0.
870 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 871 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
872 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
873
874 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
875 fillWithWidgetValue:frame:
876
423d3b3f
JD
877 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
878 remove memory leak warnings.
879
d2d699ac
JD
880 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
881 (ns_check_menu_open): Handle menu == nil. Remove assignment to
882 menu_pending_title.
883
884 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
885 (x_activate_menubar): Update the whole menu.
886 (trackingNotification:): Call ns_check_menu_open if tracking ends.
887 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
888 current event is not NSSystemDefined (Bug#15001).
889 Call ns_check_menu_open only if trackingMenu is 2.
890 (menuDidClose:): New method, decrease trackingMenu.
891 (fillWithWidgetValue:setDelegate:): New method.
892 (fillWithWidgetValue:): Call the above.
893
894 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
895
7d652d97
PE
8962013-08-11 Paul Eggert <eggert@cs.ucla.edu>
897
898 Omit some unnecessary casts.
899 Many of these go back to the old pre-C89 days, when they may have
900 been needed, but we've been assuming C89 or later for a while now.
901 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
902 (live_float_p, live_misc_p, live_vector_p):
903 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
904 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
905 (defvar_per_buffer):
906 * callint.c (Fcall_interactively):
907 * doc.c (Fsubstitute_command_keys):
908 * filelock.c (get_boot_time):
909 * frame.c (xrdb_get_resource):
910 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
911 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
912 (xg_get_file_name_from_selector, menuitem_destroy_callback)
913 (menuitem_highlight_callback, menu_destroy_callback)
914 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
915 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
916 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
917 (xg_tool_bar_help_callback, tb_size_cb):
918 * image.c (xpm_alloc_color, png_read_from_memory)
919 (png_read_from_file, png_load_body, our_memory_skip_input_data)
920 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
921 (syms_of_image):
922 * keymap.c (describe_map):
923 * nsfns.m (Fns_display_monitor_attributes_list):
924 * nsmenu.m (process_dialog:):
925 * nsterm.m (hold_event):
926 * process.c (wait_reading_process_output):
927 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
928 * scroll.c (do_direct_scrolling, scrolling_1):
929 * termcap.c (tgetent):
930 * window.c (check_window_containing, add_window_to_list)
931 (freeze_window_starts):
932 * xdisp.c (compare_overlay_entries, vmessage):
933 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
934 (x_get_monitor_attributes_xrandr)
935 (Fx_display_monitor_attributes_list, x_display_info_for_name)
936 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
937 * xfont.c (xfont_match, xfont_open):
938 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
939 (menubar_selection_callback, menu_position_func)
940 (popup_selection_callback, create_and_show_popup_menu)
941 (dialog_selection_callback, create_and_show_dialog):
942 * xrdb.c (x_get_string_resource):
943 (main) [TESTRM]:
944 * xsmfns.c (x_session_check_input):
945 * xterm.c (x_draw_glyphless_glyph_string_foreground)
946 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
947 (xaw_jump_callback, xaw_scroll_callback):
948 Omit unnecessary casts.
949
9acc1074
PE
9502013-08-10 Paul Eggert <eggert@cs.ucla.edu>
951
952 Minor string-length refactoring.
953 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
954 * frame.c (make_monitor_attribute_list):
955 Prefer build_string to strlen + make_string.
956
361c0eb8
JD
9572013-08-10 Jan Djärv <jan.h.d@swipnet.se>
958
959 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
960 don't check minor_code (Bug#14417).
961
14ba0822
EZ
9622013-08-09 Eli Zaretskii <eliz@gnu.org>
963
964 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
965 vertical positions instead. This avoids calling MATRIX_ROW with
966 row numbers that are possibly beyond valid limits. (Bug#15064)
967
309f24d1
DA
9682013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
969
970 Use xstrdup and build_unibyte_string where applicable.
971 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
972 * xfns.c (x_window):
973 * xrdb.c (x_get_customization_string):
974 * xterm.c (xim_initialize):
975 * w32fns.c (w32_window): Use xstrdup.
976 (w32_display_monitor_attributes_list):
977 * emacs.c (init_cmdargs):
978 * keyboard.c (PUSH_C_STR):
979 * nsfont.m (nsfont_open):
980 * sysdep.c (system_process_attributes):
981 * w32.c (system_process_attributes):
982 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
983
55902276
EZ
9842013-08-09 Eli Zaretskii <eliz@gnu.org>
985
986 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
987 variables of these types so that GDB would know about them, as aid
988 for debugging fatal exceptions. (Bug#15024) See also
989 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
990 discussions.
991
10bf7f5a
JD
9922013-08-08 Jan Djärv <jan.h.d@swipnet.se>
993
994 * nsterm.m (ns_update_begin): Don't change clip path if it would be
995 larger than the NSWindow (Bug#14934).
996
65620264
DA
9972013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
998
999 Redesign redisplay interface to drop global variable updated_window.
1000 Always pass currently updated window as a parameter to update routines.
1001 * dispextern.h (updated_window): Remove declaration.
1002 (struct redisplay_interface): Pass window parameter to
1003 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1004 and after_update_window_hook.
1005 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1006 Adjust prototypes.
1007 * dispnew.c (updated_window): Remove.
1008 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1009 (update_window_line): Adjust to match redisplay interface changes.
1010 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1011 (ns_scroll_run, ns_after_update_window_line):
1012 * w32term.c (x_update_window_begin, x_update_window_end)
1013 (x_after_update_window_line, x_scroll_run):
1014 * xterm.c (x_update_window_begin, x_update_window_end)
1015 (x_after_update_window_line, x_scroll_run):
1016 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1017 Likewise. Adjust comments where appropriate.
1018 (x_cursor_to): Simplify because this is always called during window
1019 update (but install debugging check anyway).
1020 (expose_window): Check must_be_updated_p flag to see whether this
1021 function is called during window update.
1022
628fdc56
DA
10232013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1024
1025 Do not reset window modification event counters excessively.
1026 These leftovers and poor man's tricky methods to catch extra
1027 redisplay's attention are no longer needed.
1028 * frame.c (set_menu_bar_lines_1):
1029 * minibuf.c (read_minibuf_unwind):
1030 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1031 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1032 (window_scroll_line_based, Fset_window_configuration):
1033 * xdisp.c (redisplay_window): Do not reset last_modified and
1034 last_overlay_modified counters.
1035
8fd9c92e
JD
10362013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1037
1038 * xselect.c (x_send_client_event): Set send_event and serial, memset
1039 data.l as it might be bigger than data.b. Use 24 bit mask to
1040 XSendEvent (Bug#15034).
1041
0ee18172
EZ
10422013-08-07 Eli Zaretskii <eliz@gnu.org>
1043
1044 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1045 for TTY frames that are not the top frame on their console.
1046 (Bug#14616)
1047
16ddd1a6
MR
10482013-08-07 Martin Rudalics <rudalics@gmx.at>
1049
1050 * w32term.c (w32fullscreen_hook): Really maximize frame when
1051 asked for (Bug#14841).
1052
d2a95ffb
DA
10532013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1054
1055 Prefer selected_window to Fselected_window, likewise for frames.
1056 * buffer.c (Fbuffer_swap_text):
1057 * data.c (Fvariable_binding_locus):
1058 * window.c (run_window_configuration_change_hook): Adjust users.
1059 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1060 Use decode_live_frame.
1061
170da1ec
DA
10622013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1063
1064 Be more careful if selected window shows the buffer other than current,
1065 use window_outdated only if this is not so. This change should also
1066 address some weird issues discussed in Bug#13012.
1067 * window.h (window_outdated): New prototype.
1068 * window.c (window_outdated): Now here. Convert from static and
1069 always assume window's buffer.
1070 (Fwindow_end, Fwindow_line_height): Use it.
1071 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1072 and always assume window's buffer.
1073 (redisplay_window): Adjust user.
e5eefe9b 1074 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1075 check whether mode line should be updated only if selected window
1076 shows current buffer.
1077 (run_window_scroll_functions): Use eassert for debugging check.
1078 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1079
56b5d5b1
DA
10802013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1081
1082 * window.c (window_scroll, window_scroll_pixel_based)
1083 (window_scroll_line_based): Use bool for booleans.
1084
2878ba7e
PE
10852013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1086
1087 * process.c: Fix minor off-by-one issues in descriptor counts.
1088 This shouldn't fix any real bugs, but it cleans up the code a bit.
1089 (max_process_desc, max_input_desc): -1, not 0, means none.
1090 All uses changed.
1091 (delete_input_desc): New function.
1092 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1093 (deactivate_process): Scan backwards when recomuting max_process_desc;
1094 that should be faster.
1095 (init_process_emacs): Initialize max_input_desc.
1096
e30b79c1
DA
10972013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Use region cache to speedup bidi_find_paragraph_start.
1100 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1101 Rename cache_long_line_scans to cache_long_scans.
1102 * buffer.c (bset_cache_long_line_scans): Rename to
1103 bset_cache_long_scans.
1104 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1105 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1106 into account.
1107 (syms_of_buffer): Rename cache-long-line-scans to
1108 cache-long-scans. Adjust docstring.
1109 * search.c (newline_cache_on_off):
1110 * indent.c (width_run_cache_on_off): Adjust users.
1111 * bidi.c (bidi_paragraph_cache_on_off): New function.
1112 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1113 * insdel.c (prepare_to_modify_buffer):
1114 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1115
00012b86
DA
11162013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1117
1118 Invalidate region caches only if buffer text is going to be changed.
1119 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1120 (modify_text): ...new prototype.
1121 (prepare_to_modify_buffer_1): New prototype.
1122 * textprop.c (modify_region): Rename to...
1123 (modify_text_properties): ...new function.
1124 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1125 (Fremove_list_of_text_properties): Adjust users.
1126 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1127 (modify_text): ...new function.
1128 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1129 (prepare_to_modify_buffer_1): ...new function.
1130 * casefiddle.c (casify_region):
1131 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1132 (Ftranspose_regions): Use modify_text.
1133
dc6c0eda
SM
11342013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * lisp.mk (lisp): Add nadvice.elc.
1137
8f3a2c26
DA
11382013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1139
1140 New macro to iterate over live buffers similar to frames.
1141 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1142 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1143 Declare buffer-related variables here to offload lisp.h.
1144 * buffer.c (Vbuffer_alist): Adjust comment.
1145 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1146 (other_buffer_safely):
1147 * data.c (store_symval_forwarding):
1148 * dispnew.c (Fframe_or_buffer_changed_p):
1149 * fileio.c (Fdo_auto_save):
1150 * filelock.c (unlock_all_files):
1151 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1152
e0fdb694
PE
11532013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1154
1155 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1156 * callproc.c (create_temp_file):
1157 * filelock.c (create_lock_file):
1158 Assume mkostemp, since it's now provided by Gnulib.
1159
63f5c6c2
EZ
11602013-08-04 Eli Zaretskii <eliz@gnu.org>
1161
1162 * w32.c (mkostemp): New function.
1163 (mktemp): Remove, no longer used. Most of the code reused in
1164 mkostemp. (Bug#15015)
484ab239 1165 (mktemp): Don't undef.
63f5c6c2 1166
f0b79313
DA
11672013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1168
1169 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1170 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1171 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1172 (free_glyph_pool, check_glyph_memory): Likewise for
1173 all users. Adjust comments where appropriate.
1174
98f638d6
PE
11752013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 * composite.h: Minor fixups.
1178 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1179 to fix a misspelling, and change it to an inline function while
1180 we're at it (it need not be a macro). All uses changed.
1181 (composition_method, composition_valid_p):
1182 Rewrite to avoid assignments in if-conditions.
1183
75c59fb3
DA
11842013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1185
1186 Do not use global Lisp_Object in composition macros.
1187 * composite.h (composition_temp): Remove declaration.
1188 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1189 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1190 (compose_region): Remove the leftover.
75c59fb3
DA
1191 * composite.c (composition_temp): Remove.
1192 (run_composition_function, update_compositions)
1193 (composition_compute_stop_pos, composition_adjust_point)
1194 (Ffind_composition_internal):
1195 * coding.c (handle_composition_annotation):
1196 * xdisp.c (handle_composition_prop, check_point_in_composition):
1197 Related users changed.
1198
a10c8269
DA
11992013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1200
1201 Drop FRAME_PTR typedef.
1202 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1203 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1204 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1205 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1206 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1207 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1208 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1209 All related users changed.
1210
a104f656
SM
12112013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1212
1213 * eval.c (default_toplevel_binding): New function.
1214 (Fdefvar): Use it.
1215 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1216 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1217 (syms_of_eval): Export them.
1218 * data.c (Fdefault_value): Micro cleanup.
1219 * term.c (init_tty): Use "false".
1220
4b5c9326
DA
12212013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1222
1223 Fix X GC leak in GTK and raw (no toolkit) X ports.
1224 * xterm.c (x_free_frame_resources): If white and black relief
1225 GCs are allocated, always free them here.
1226 * xfns.c (x_make_gc): Omit redundant initialization.
1227 * widget.c (create_frame_gcs): Remove the leftover.
1228 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1229 in x_free_frame_resources.
1230
b19aa636
JD
12312013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1232
1233 * nsterm.m (windowWillResize:toSize:): Only change title if
1234 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1235 modifying it.
1236 (viewDidEndLiveResize): New method.
1237
1238 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1239 inside NS_IMPL_COCOA.
1240
af1f7e06
DA
12412013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1242
1243 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1244 Do not check whether undo is enabled because record_insert and
1245 record_delete does that themselves.
1246
65b02bb9
DA
12472013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1248
1249 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1250 member which is not really used any more.
1251 (FRAME_XIC_BASE_FONTNAME): Remove.
1252 * xfns.c (xic_free_fontset): Adjust user.
1253 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1254 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1255 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1256 (xdialog_show): Use eassert for debugging check.
7ee0f047 1257 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1258
6318cde0
PE
12592013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 * fileio.c, fns.c (merge): Move extern decl from here ...
1262 * lisp.h (merge): ... to here.
1263
6c1a09ba
DA
12642013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1265
1266 Fix last font-related change.
1267 * w32font.h (w32font_list_internal, w32font_match_internal):
1268 Fix prototype.
1269 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1270 (uniscribe_list_family): Adjust to match font API change.
1271 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1272 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1273
f8c20208
DA
12742013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1275
1276 * frame.h (FRAME_MOUSE_UPDATE):
1277 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1278 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1279
fdb396e2
DA
12802013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1281
1282 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1283 * font.h (struct font_driver): Change list, match, and list_family
1284 functions to accept struct frame * as first arg.
068f9124
SM
1285 * font.c (font_score, font_compare, font_sort_entities):
1286 Remove prototypes.
fdb396e2
DA
1287 (font_sort_entities, font_list_entities, font_select_entity):
1288 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1289 match font API change.
1290 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1291 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1292 * ftxfont.c (ftxfont_list, ftxfont_match):
1293 * xftfont.c (xftfont_list, xftfont_match):
1294 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1295 * w32font.c (w32font_list, w32font_match, w32font_list):
1296 (w32font_list_internal, w32_font_match_internal): Likewise.
1297 * xfaces.c (Fx_family_fonts): Adjust user.
1298
52b8a085
DA
12992013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1302 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1303 only if HAVE_X_WINDOWS is in use.
1304 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1305 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1306 * w32term.c (x_wm_set_icon_position): Likewise.
1307 * w32fns.c (x_icon): Adjust user.
1308
c791c18e
DA
13092013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1310
1311 * xterm.c (last_mouse_press_frame): Remove the
1312 leftover which is not really used any more.
1313 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1314 (x_flush): Call XFlush once per each X display, not frame.
1315 This is better because this code always unconditionally skips
1316 non-X frames in Vframe_list and issues the only XFlush if we
1317 have more than one X frame on the same X display.
2f935d86
DA
1318 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1319 Use bool for booleans.
1320 (x_draw_glyph_string_background, cvt_string_to_pixel):
1321 (cvt_pixel_dtor): Drop unnecessary prototypes.
1322 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1323
f435830e
DA
13242013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1325
1326 Drop unnecessary functions that deals with frame pixel size.
1327 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1328 (x_pixel_height): Drop prototypes.
1329 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1330 (x_pixel_height): Drop implementations.
1331 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1332 which should be always valid for window frame.
1333 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1334 * w32menu.c (Fx_popup_dialog):
1335 * xmenu.c (Fx_popup_dialog): Likewise for both.
1336
84231434
DA
13372013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1338
1339 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1340 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1341 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1342 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1343 and mention nil frame in docstring.
84231434 1344
959067a1
DA
13452013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1346
1347 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1348 (x_figure_window_size): Likewise. Adjust to return long.
1349 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1350 (toplevel): Move Qterminal_live_p to...
1351 * terminal.c (toplevel): ...here, make it static, and...
1352 (syms_of_terminal): ...DEFSYM here.
1353 * frame.h (Qterminal_live_p): Remove declaration.
1354 (make_frame, x_figure_window_size): Adjust prototype.
1355 * nsfns.m (Fx_create_frame): Use long for window flags.
1356
f4b169ce
PE
13572013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1360 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1361 Do not assume that emacs_close (INT_MAX) is a no-op.
1362
bee6a2c7
DA
13632013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1364
1365 * xfaces.c (make_face_cache): For struct face_cache, prefer
1366 xmalloc to xzalloc and so avoid redundant call to memset.
1367 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1368
d7e6881a
DA
13692013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1370
1371 * fringe.c (draw_window_fringes, update_window_fringes)
1372 (compute_fringe_widths):
1373 * w32term.c (x_draw_glyph_string):
1374 * window.c (candidate_window_p, Frecenter):
1375 * xfaces.c (realize_basic_faces, realize_default_face)
1376 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1377 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1378 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1379 * xmenu.c (Fx_menu_bar_open_internal):
1380 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1381 * xsettings.c (xft_settings_event):
1382 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1383 Use bool for booleans. Adjust style and comments where
1384 appropriate.
1385 * dispextern.h (draw_window_fringes, update_window_fringes)
1386 (compute_fringe_widths):
1387 * xterm.h (x_had_errors_p): Adjust prototype.
1388
ec3058af
DA
13892013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1390
1391 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1392 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1393
218e0637
DA
13942013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1395
1396 * fns.c (toplevel): Remove comment before Fsafe_length because
1397 it checks for QUIT.
1398
e560aba9
PE
13992013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1402
2e5ce5de
EZ
14032013-07-28 Eli Zaretskii <eliz@gnu.org>
1404
1405 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1406 frame which got the message is still alive, before dereferencing
1407 its pointer. (Bug#14970)
1408
1409 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1410 be a live window, before using it as such. (Bug#14970)
1411
e95da6d3
EZ
14122013-07-27 Eli Zaretskii <eliz@gnu.org>
1413
1414 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1415 w32_detect_focus_change instead of doing part of its job by hand.
1416 This fixes the problem whereby FOCUS_OUT events were not sent to
1417 the event queue.
1418
a8f93651
EZ
14192013-07-26 Eli Zaretskii <eliz@gnu.org>
1420
fec92060
EZ
1421 * process.c (Fprocess_list): Doc fix.
1422
a8f93651
EZ
1423 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1424 being re-exposed only if it didn't ask to become visible.
1425 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1426 was previously iconified. (Bug#14841)
1427 (x_iconify_frame): Mark the frame iconified.
1428
d5a7a9d9
PE
14292013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1430
1431 Fix minor problems found by static checking.
1432 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1433 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1434
56ea7291
SM
14352013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1436
1437 * eval.c (set_specpdl_old_value): New function.
1438 (unbind_to): Minor simplification.
1439 (get_backtrace_frame): New function.
1440 (Fbacktrace_frame): Use it. Add `base' argument.
1441 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1442 (syms_of_eval): Export backtrace-eval.
1443 * xterm.c (x_focus_changed): Simplify.
1444
9d611ffe
PE
14452013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1448
999c74e3
EZ
14492013-07-24 Eli Zaretskii <eliz@gnu.org>
1450
1451 * xdisp.c (redisplay_window): Instead of moving point out of
1452 scroll margin, reject the force_start method, and try scrolling
1453 instead. (Bug#14780)
1454
198fa217
KB
14552013-07-24 Ken Brown <kbrown@cornell.edu>
1456
1457 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1458 (Bug#14944).
1459
53840e55
PE
14602013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 * eval.c (Fprogn): Do not check that BODY is a proper list.
1463 This undoes the previous change. The check slows down the
1464 interpreter, and is not needed to prevent a crash. See
1465 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1466
60967f56
GM
14672013-07-23 Glenn Morris <rgm@gnu.org>
1468
1469 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1470
9ca960e2
PE
14712013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1472
a29c3e6d
PE
1473 Port to GNU/Linux systems with tinfo but not ncurses.
1474 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1475 to decide whether ncurses is being used. Without this change,
1476 GCC complains about tgetent not being declared, on a system
1477 that has tinfo installed but ncurses not installed.
1478
f274311c
PE
1479 * eval.c (Fprogn): Check that BODY is a proper list.
1480
16b0520a
PE
1481 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1482 * data.c (Fsetq_default):
1483 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1484 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1485 (Fcondition_case):
1486 Tune by taking advantage of the fact that ARGS is always a list
1487 when a function is declared to have UNEVALLED args.
1488
9ca960e2
PE
1489 * emacsgtkfixed.c: Port to GCC 4.6.
1490 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1491
afacaa1b
JB
14922013-07-23 Juanma Barranquero <lekktu@gmail.com>
1493
1494 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1495 here to silence compiler warnings.
1496
368a85a4
PE
14972013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1500 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1501 from messing up Emacs's 'struct frame' (Bug#14923).
1502
f4e891b5
PE
15032013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 * alloc.c (make_save_ptr_ptr): Define this function.
1506 It was inadvertently omitted. It's needed only if
1507 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1508
96c8b65e
JD
15092013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1510
1511 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1512 frame have focus (Bug#14895).
1513
ee010797
PE
15142013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 Avoid vfork-related deadlock more cleanly.
1517 * callproc.c (child_setup): When the child's exec fails, output
1518 the program name, as that's more useful. Use O_NONBLOCK to avoid
1519 deadlock.
1520 * process.c (create_process_1): Remove; no longer needed.
1521 (create_process): Remove timer hack; no longer needed, now that
1522 the child avoids deadlock.
1523
f0398ec1 15242013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1525
1526 * image.c (Fimage_flush): Fix doc typo.
1527
b2a069c2
PE
15282013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1529
6496aec9
PE
1530 Fix array bounds violation when pty allocation fails.
1531 * process.c (PTY_NAME_SIZE): New constant.
1532 (pty_name): Remove static variable; it's now auto.
1533 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1534 Take pty_name as an arg rather than using a static variable.
1535 All callers changed.
1536 (create_process): Recover pty_flag from process, not from volatile local.
1537 (create_pty): Stay inside array even when pty allocation fails.
1538 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1539
b2a069c2
PE
1540 * lread.c (Fload): Avoid initialization only when lint checking.
1541 Mention that it's needed only for older GCCs.
1542
99107004
KH
15432013-07-20 Kenichi Handa <handa@gnu.org>
1544
1545 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1546 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1547
6b1b199d
AS
15482013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1549
1550 * lread.c (Fload): Avoid uninitialized warning.
1551
4195afc3
PE
15522013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1553
3f5bef16
PE
1554 Fix some minor file descriptor leaks and related glitches.
1555 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1556 (create_lock_file): Use write, not emacs_write.
1557 * image.c (slurp_file, png_load_body):
1558 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1559 (server_accept_connection):
1560 Don't leak an fd on memory allocation failure.
1561 * image.c (slurp_file): Add a cheap heuristic for growing files.
1562 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1563 as that's what the other routines do. Maybe input need not be
1564 blocked at all, but it's better to be consistent.
1565 Avoid undefined behavior when strlen is zero.
1566
4195afc3
PE
1567 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1568 (NSTATICS): Now a constant; doesn't need to be a macro.
1569
a1aeeffe
RS
15702013-07-19 Richard Stallman <rms@gnu.org>
1571
1572 * coding.c (decode_coding_utf_8): Add simple loop for fast
1573 processing of ASCII characters.
1574
63b34baa
PE
15752013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1578
621dd9ac
EZ
15792013-07-19 Eli Zaretskii <eliz@gnu.org>
1580
1581 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1582 unportable 'struct x_display_info'.
1583 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1584 is a portable type.
1585
1396ac86
PE
15862013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1587
ab9980cd
PE
1588 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1589 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1590 or fscanf fails.
1591 (system_process_attributes): Prefer plain char to unsigned char
1592 when either will do. Clean up properly if interrupted or if
068f9124
SM
1593 memory allocations fail. Don't assume sscanf succeeds.
1594 Remove no-longer-needed workaround to stop GCC from whining.
1595 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1596 bit more carefully.
1597
1396ac86
PE
1598 Fix obscure porting bug with varargs functions.
1599 The code assumed that int is treated like ptrdiff_t in a vararg
1600 function, which is not a portable assumption. There was a similar
1601 -- though these days less likely -- porting problem with various
1602 assumptions that pointers of different types all smell the same as
1603 far as vararg functions is conserved. To make this problem less
1604 likely in the future, redo the API to use varargs functions.
1605 * alloc.c (make_save_value): Remove this vararg function.
1606 All uses changed to ...
1607 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1608 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1609 New functions.
1610 (make_save_ptr): Rename from make_save_pointer, for consistency with
1611 the above. Define only on platforms that need it. All uses changed.
1612
4d19d194
PE
16132013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1614
1615 * keyboard.c: Try to fix typos in previous change.
1616 (DISPLAY_LIST_INFO): New macro.
1617 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1618 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1619
945c5bb1
JB
16202013-07-18 Juanma Barranquero <lekktu@gmail.com>
1621
1622 * keyboard.c (kbd_buffer_get_event):
1623 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1624 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1625
f4b1eb36
PE
16262013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1627
5e679a2c
PE
1628 * filelock.c: Fix unlikely file descriptor leaks.
1629 (get_boot_time_1): Rework to avoid using emacs_open.
1630 This doesn't actually fix a leak, but is better anyway.
1631 (read_lock_data): Use read, not emacs_read.
1632
a8cd4836
PE
1633 * doc.c: Fix minor memory and file descriptor leaks.
1634 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1635 (get_doc_string, Fsnarf_documentation):
1636 Fix file descriptor leak on error.
1637
ef30e638
PE
1638 * term.c: Fix minor fdopen-related file descriptor leaks.
1639 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1640 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1641
f4b1eb36
PE
1642 * charset.c: Fix file descriptor leaks and errno issues.
1643 Include <errno.h>.
1644 (load_charset_map_from_file): Don't leak file descriptor on error.
1645 Use plain record_xmalloc since the allocation is larger than
1646 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1647 of entries.
1648 * eval.c (record_unwind_protect_nothing):
1649 * fileio.c (fclose_unwind):
1650 New functions.
1651 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1652 The replacement doesn't block input, but that no longer seems
1653 necessary.
1654
b648c163
PE
16552013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1656
a0931322
PE
1657 * lread.c: Fix file descriptor leaks and errno issues.
1658 (Fload): Close some races that leaked fds or streams when 'load'
1659 was interrupted.
1660 (Fload, openp): Report error number of last nontrivial failure to open.
1661 ENOENT counts as trivial.
1662 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1663 New functions.
1664 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1665 now that the function is always called with a nonnegative arg.
1666 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1667 All uses replaced with ...
1668 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1669
b648c163
PE
1670 A few more minor file errno-reporting bugs.
1671 * callproc.c (Fcall_process):
1672 * doc.c (Fsnarf_documentation):
1673 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1674 * process.c (set_socket_option):
1675 Don't let a constructor trash errno.
1676 * doc.c: Include <errno.h>.
1677
b1dc4084
JB
16782013-07-16 Juanma Barranquero <lekktu@gmail.com>
1679
1680 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1681
c43843aa
PE
16822013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1683
50a30cce
PE
1684 Fix w32 bug with call-process-region (Bug#14885).
1685 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1686 to Fcall_process when the input is empty. This simplifies the
1687 code a bit. It makes no difference on POSIXish platforms but
1688 apparently it fixes a bug on w32.
1689
44e18199 1690 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1691 * fileio.c (close_file_unwind): Don't close if FD is negative;
1692 this can happen when unwinding a zapped file descriptor.
1693 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1694 in case Emacs runs out of memory between the two unwind-protects.
1695 Don't trash errno when closing FD.
1696 Zap the FD in the specpdl when closing it, instead of deferring
1697 the removal of the unwind-protect; this fixes a bug where a child
1698 function unwinds the stack past us.
1699
27e498e6
PE
1700 New unwind-protect flavors to better type-check C callbacks.
1701 This also lessens the need to write wrappers for callbacks,
1702 and the need for make_save_pointer.
1703 * alloca.c (free_save_value):
1704 * atimer.c (run_all_atimers):
1705 Now extern.
1706 * alloc.c (safe_alloca_unwind):
1707 * atimer.c (unwind_stop_other_atimers):
1708 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1709 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1710 * minibuf.c (choose_minibuf_frame_1):
1711 * process.c (make_serial_process_unwind):
1712 * xdisp.h (pop_message_unwind):
1713 * xselect.c (queue_selection_requests_unwind):
1714 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1715 * alloca.c (record_xmalloc):
1716 Prefer record_unwind_protect_ptr to record_unwind_protect with
1717 make_save_pointer.
1718 * alloca.c (Fgarbage_collect):
1719 Prefer record_unwind_protect_void to passing a dummy.
1720 * buffer.c (restore_buffer):
1721 * window.c (restore_window_configuration):
1722 * xfns.c, w32fns.c (do_unwind_create_frame)
1723 New wrapper. All record-unwind uses of wrappee changed.
1724 * buffer.c (set_buffer_if_live):
1725 * callproc.c (call_process_cleanup, delete_temp_file):
1726 * coding.c (code_conversion_restore):
1727 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1728 * editfns.c (save_excursion_restore)
1729 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1730 (save_restriction_restore):
1731 * eval.c (restore_stack_limits, un_autoload):
1732 * fns.c (require_unwind):
1733 * keyboard.c (recursive_edit_unwind, tracking_off):
1734 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1735 * macros.c (pop_kbd_macro, restore_menu_items):
1736 * nsfns.m (unwind_create_frame):
1737 * print.c (print_unwind):
1738 * process.c (start_process_unwind):
1739 * search.c (unwind_set_match_data):
1740 * window.c (select_window_norecord, select_frame_norecord):
1741 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1742 (fast_set_selected_frame):
1743 * xfns.c, w32fns.c (unwind_create_tip_frame):
1744 Return void, not a dummy Lisp_Object. All uses changed.
1745 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1746 * callproc.c (call_process_kill):
1747 * fileio.c (restore_point_unwind, decide_coding_unwind)
1748 (build_annotations_unwind):
1749 * insdel.c (Fcombine_after_change_execute_1):
1750 * keyboard.c (read_char_help_form_unwind):
1751 * menu.c (unuse_menu_items):
1752 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1753 * sound.c (sound_cleanup):
1754 * xdisp.c (unwind_redisplay):
1755 * xfns.c (clean_up_dialog):
1756 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1757 Accept no args and return void, instead of accepting and returning
1758 a dummy Lisp_Object. All uses changed.
1759 * cygw32.c (fchdir_unwind):
1760 * fileio.c (close_file_unwind):
1761 * keyboard.c (restore_kboard_configuration):
1762 * lread.c (readevalllop_1):
1763 * process.c (wait_reading_process_output_unwind):
1764 Accept int and return void, rather than accepting an Emacs integer
1765 and returning a dummy object. In some cases this fixes an
1766 unlikely bug when the corresponding int is outside Emacs integer
1767 range. All uses changed.
1768 * dired.c (directory_files_internal_unwind):
1769 * fileio.c (do_auto_save_unwind):
1770 * gtkutil.c (pop_down_dialog):
1771 * insdel.c (reset_var_on_error):
1772 * lread.c (load_unwind):
1773 * xfns.c (clean_up_file_dialog):
1774 * xmenu.c, nsmenu.m (pop_down_menu):
1775 * xmenu.c (cleanup_widget_value_tree):
1776 * xselect.c (wait_for_property_change_unwind):
1777 Accept pointer and return void, rather than accepting an Emacs
1778 save value encapsulating the pointer and returning a dummy object.
1779 All uses changed.
1780 * editfns.c (Fformat): Update the saved pointer directly via
1781 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1782 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1783 (unwind_body): New function.
1784 (record_unwind_protect): First arg is now a function returning void,
1785 not a dummy Lisp_Object.
1786 (record_unwind_protect_ptr, record_unwind_protect_int)
1787 (record_unwind_protect_void): New functions.
1788 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1789 * fileio.c (struct auto_save_unwind): New type.
1790 (do_auto_save_unwind): Use it.
1791 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1792 * insdel.c (struct rvoe_arg): New type.
1793 (reset_var_on_error): Use it.
1794 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1795 New constants.
1796 (specbinding_func): Remove; there are now several such functions.
1797 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1798 (set_unwind_protect_ptr): New function.
1799 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1800
4e604a5d
PE
1801 Be simpler and more consistent about reporting I/O errors.
1802 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1803 Say "Read error" and "Write error", rather than "I/O error", or
1804 "IO error reading", or "IO error writing", when a read or write
1805 error occurs.
1806 * process.c (Fmake_network_process, wait_reading_process_output)
1807 (send_process, Fprocess_send_eof, wait_reading_process_output):
1808 Capitalize diagnostics consistently. Put "failed foo" at the
1809 start of the diagnostic, so that we don't capitalize the
1810 function name "foo". Consistently say "failed" for such
1811 diagnostics.
1812 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1813 All callers changed. This is so it can use report_file_error.
1814 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1815 diagnostics consistently as above.
1816
a9757f6a
PE
1817 * fileio.c (report_file_errno): Fix errno reporting bug.
1818 If the file name is neither null nor a pair, package it up as a
1819 singleton list. All callers changed, both to this function and to
1820 report_file_error. This fixes a bug where the memory allocator
1821 invoked by list1 set errno so that the immediately following
1822 report_file_error reported the wrong errno value.
1823
c43843aa
PE
1824 Fix minor problems found by --enable-gcc-warnings.
1825 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1826 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1827
18c26d81
JD
18282013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1829
1830 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1831 Set event->arg to Qt if switch-event shall be generated.
1832 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1833
1834 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1835
1836 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1837 FOCUS_OUT_EVENT.
1838
1839 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1840 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1841 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1842 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1843 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1844 and there is a focused frame.
1845 (head_table): Add focus-in and focus-out.
1846 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1847 bind to handle-focus-in/out.
1848
1849 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1850 (Fhandle_switch_frame): Call Fhandle_focus_in.
1851 (syms_of_frame): defsubr handle-focus-in/out.
1852
6c6f1994
PE
18532013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1854
c7ddc792
PE
1855 Fix porting bug to older POSIXish platforms (Bug#14862).
1856 * sysdep.c (emacs_pipe): New function, that implements
1857 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1858 This should port better to CentOS 5 and to Mac OS X 10.6.
1859 All calls to pipe2 changed.
1860
6c6f1994
PE
1861 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1862 This makes the code easier to read and the executable a bit smaller.
1863 Do not replace all calls to Fcons that happen to create lists,
1864 just calls that are intended to create lists. For example, when
1865 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1866 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1867 Similarly for list2 through list5.
1868 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1869 * bytecode.c (exec_byte_code):
1870 * callint.c (quotify_arg, Fcall_interactively):
1871 * callproc.c (Fcall_process, create_temp_file):
1872 * charset.c (load_charset_map_from_file)
1873 (Fdefine_charset_internal, init_charset):
1874 * coding.c (get_translation_table, detect_coding_system)
1875 (Fcheck_coding_systems_region)
1876 (Fset_terminal_coding_system_internal)
1877 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1878 * composite.c (update_compositions, Ffind_composition_internal):
1879 * dired.c (directory_files_internal, file_name_completion)
1880 (Fsystem_users):
1881 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1882 * doc.c (Fsnarf_documentation):
1883 * editfns.c (Fmessage_box):
1884 * emacs.c (main):
1885 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1886 (Feval, eval_sub, Ffuncall, apply_lambda):
1887 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1888 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1889 (Fset_file_times, Finsert_file_contents)
1890 (Fchoose_write_coding_system, Fwrite_region):
1891 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1892 * font.c (font_registry_charsets, font_parse_fcname)
1893 (font_prepare_cache, font_update_drivers, Flist_fonts):
1894 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1895 * frame.c (make_frame, Fmake_terminal_frame)
1896 (x_set_frame_parameters, x_report_frame_params)
1897 (x_default_parameter, Fx_parse_geometry):
1898 * ftfont.c (syms_of_ftfont):
1899 * image.c (gif_load):
1900 * keyboard.c (command_loop_1):
1901 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1902 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1903 (Fminor_mode_key_binding, accessible_keymaps_1)
1904 (Faccessible_keymaps, Fwhere_is_internal):
1905 * lread.c (read_emacs_mule_char):
1906 * menu.c (find_and_return_menu_selection):
1907 * minibuf.c (get_minibuffer):
1908 * nsfns.m (Fns_perform_service):
1909 * nsfont.m (ns_script_to_charset):
1910 * nsmenu.m (ns_popup_dialog):
1911 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1912 (Fx_own_selection_internal):
1913 * nsterm.m (append2):
1914 * print.c (Fredirect_debugging_output)
1915 (print_prune_string_charset):
1916 * process.c (Fdelete_process, Fprocess_contact)
1917 (Fformat_network_address, set_socket_option)
1918 (read_and_dispose_of_process_output, write_queue_push)
1919 (send_process, exec_sentinel):
1920 * sound.c (Fplay_sound_internal):
1921 * textprop.c (validate_plist, add_properties)
1922 (Fput_text_property, Fadd_face_text_property)
1923 (copy_text_properties, text_property_list, syms_of_textprop):
1924 * unexaix.c (report_error):
1925 * unexcoff.c (report_error):
1926 * unexsol.c (unexec):
1927 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1928 (Fformat_mode_line, syms_of_xdisp):
1929 * xfaces.c (set_font_frame_param)
1930 (Finternal_lisp_face_attribute_values)
1931 (Finternal_merge_in_global_face, syms_of_xfaces):
1932 * xfns.c (x_default_scroll_bar_color_parameter)
1933 (x_default_font_parameter, x_create_tip_frame):
1934 * xfont.c (xfont_supported_scripts):
1935 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1936 (menu_help_callback, xmenu_show):
1937 * xml.c (make_dom):
1938 * xterm.c (set_wm_state):
1939 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1940 and similarly for list2 through list5.
1941
bafe80ce
PE
19422013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 * callproc.c (Fcall_process_region): Fix minor race and tune.
1945 (create_temp_file): New function, with the temp-file-creation part
1946 of the old Fcall_process_region. Use Fcopy_sequence to create the
1947 temp file name, rather than alloca + build_string, for simplicity.
1948 Don't bother to block input around the temp file creation;
068f9124
SM
1949 shouldn't be needed. Simplify use of mktemp.
1950 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
1951 this closes an unlikely race where the temp file was not removed.
1952 Use memcpy rather than an open-coded loop.
1953 (Fcall_process_region): Use the new function. If the input is
1954 empty, redirect from /dev/null rather than from a newly created
1955 empty temp file; this avoids unnecessary file system traffic.
1956
4700b5a5
PE
19572013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1958
5c97beae
PE
1959 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1960 Simplify by making this case like the other two. This is a bit
1961 slower on obsolete hosts, but the extra complexity isn't worth it.
1962
4700b5a5
PE
1963 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1964 * process.c (create_process) [!DOS_NT]:
1965 Remove now-unnecessary calls to emacs_close.
1966
f9a74c4c
EZ
19672013-07-13 Eli Zaretskii <eliz@gnu.org>
1968
922ae7ee
EZ
1969 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1970 returning early. (Bug#14850)
1971
f9a74c4c
EZ
1972 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1973 and inhibit-iso-escape-detection attributes of 'undecided'.
1974 (Bug#14822)
1975
5e301d76
PE
19762013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1977
69e0e5ee
PE
1978 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1979 Reported by Herbert J. Skuhra in
1980 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1981
5e301d76
PE
1982 Don't lose top specpdl entry when memory is exhausted.
1983 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1984 specpdl overflow here, to simplify callers; all callers changed.
1985 Always reserve an unused entry at the stack top; this avoids
1986 losing the top entry's information when memory is exhausted.
1987
7e649856
PE
19882013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1989
a773ed9a
PE
1990 Clean up errno reporting and fix some errno-reporting bugs.
1991 * callproc.c (Fcall_process):
1992 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1993 * process.c (create_process, Fmake_network_process):
1994 * unexaix.c (report_error):
1995 * unexcoff.c (report_error):
1996 Be more careful about reporting the errno of failed operations.
1997 The code previously reported the wrong errno sometimes.
1998 Also, prefer report_file_errno to setting errno + report_file_error.
1999 (Fcall_process): Look at openp return value rather than at path,
2000 as that's a bit faster and clearer when there's a numeric predicate.
2001 * fileio.c (report_file_errno): New function, with most of the
2002 old contents of report_file_error.
2003 (report_file_error): Use it.
2004 (Ffile_exists_p, Ffile_accessible_directory_p):
2005 Set errno to 0 when it is junk.
2006 * fileio.c (Faccess_file):
2007 * image.c (x_create_bitmap_from_file):
2008 Use faccessat rather than opening the file, to avoid the hassle of
2009 having a file descriptor open.
2010 * lisp.h (report_file_errno): New decl.
2011 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2012
7e649856
PE
2013 Minor EBADF fixes.
2014 * process.c (create_process, wait_reading_process_output) [AIX]:
2015 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2016 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2017 a multithreaded environment anyway).
2018 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2019
f6774c1a
AS
20202013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2021
2022 * image.c (x_find_image_file): Don't close a remote file handle.
2023
bacba3c2
PE
20242013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 Fix races with threads and file descriptors.
2027 * callproc.c (Fcall_process_region):
2028 * dired.c (open_directory):
2029 * emacs.c (main, Fdaemon_initialized):
2030 * image.c (x_find_image_file):
2031 * inotify.c (Finotify_rm_watch):
2032 * lread.c (Flocate_file_internal):
2033 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2034 * term.c (term_mouse_moveto, init_tty):
2035 * termcap.c (tgetent):
2036 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2037 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2038 * unexhp9k800.c, unexmacosx.c (unexec):
2039 * callproc.c (Fcall_process_region):
2040 Use emacs_close, not close.
2041 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2042 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2043 and posix_close function on current platforms (which all lack them).
2044 (emacs_close): Use it. This should fix the races on GNU/Linux and
2045 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2046 and it should avoid closing random victim file descriptors on
2047 other platforms.
2048
653d4f43
PE
20492013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2050
c8536ec4
PE
2051 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2052 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2053 Touch up doc a bit.
2054
9c203066
PE
2055 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2056 This is for .gdbinit xbacktrace.
2057
653d4f43
PE
2058 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2059 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2060 (emacs_set_tty): Now static.
2061 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2062 * term.c (tty_capable_p, tty_default_color_capabilities)
2063 (get_tty_terminal, term_mouse_movement)
2064 (handle_one_term_event, init_tty, maybe_fatal):
2065 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2066 (tgetent, scan_file, name_match, compare_contin):
2067 * terminal.c (get_terminal):
2068 Use bool for boolean.
2069 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2070 Prefer char to unsigned char if either will do.
2071 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2072 (tty_write_glyphs): Prefer int to unsigned.
2073 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2074 All callers changed.
2075 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2076
45b683a1
PE
20772013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2078
29abe551
PE
2079 Port to C89.
2080 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2081 (B__dummy__): New dummy symbol, to pacify C89.
2082 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2083 they can't grok varargs macros.
2084 * dispnew.c (add_window_display_history)
2085 (add_frame_display_history):
2086 * print.c (print_object):
2087 * xdisp.c (debug_method_add):
2088 Use %p printf format only for void pointers.
2089 * emacs.c (usage_message): New constant, replacing ...
2090 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2091 (main): Adjust to usage reorg.
2092 * fns.c (syms_of_fns):
2093 * profiler.c (syms_of_profiler):
2094 Don't use non-constant struct initializers.
2095 * gnutls.h (gnutls_initstage_t):
2096 * lisp.h (enum Lisp_Fwd_Type):
2097 * lread.c (lisp_file_lexically_bound_p):
2098 * xsettings.c (anonymous enum):
2099 Remove trailing comma.
2100 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2101 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2102 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2103 (DEFUN): Use it.
2104 * regex.c (const_re_char): New type, to pacify strict C89.
2105 All uses of 'const re_char' replaced to use it.
2106 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2107 with glibc when strict C89. This change is imported from gnulib.
2108 All uses changed.
2109 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2110 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2111 Omit GNU_LINUX implementation, since it requires long long.
2112 * xterm.c (x_draw_underwave):
2113 Do not assume the traditional order of struct's members.
2114 (x_term_init): Rewrite to avoid the need for non-constant structure
2115 initializers.
2116
45b683a1 2117 Syntax cleanup, mostly replacing macros with functions.
763a086d 2118 This removes the need for the syntax_temp hack.
45b683a1
PE
2119 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2120 * syntax.c (SYNTAX_INLINE): New macro.
2121 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2122 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2123 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2124 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2125 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2126 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2127 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2128 Now constants, not macros.
2129 (syntax_temp) [!__GNUC__]: Remove.
2130 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2131 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2132 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2133 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2134 Move here from syntax.h; now functions, not macros. Except for the
2135 last function, these are static since only syntax.c uses them.
2136 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2137 All uses changed. Now a function, not a macro; use this fact
2138 to simplify the code.
2139 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2140 compiler bugs; no longer relevant.
2141 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2142 (SYNTAX_INLINE): New macro.
2143 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2144 for the new functions. Use bool for boolean member.
2145 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2146 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2147 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2148 (SETUP_BUFFER_SYNTAX_TABLE):
2149 Now extern inline functions, not macros.
2150 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2151 Remove; all uses replaced by implementation.
2152 (syntax_temp) [!__GNUC__]: Remove decl.
2153 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2154
29be4a50
JD
21552013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2156
2157 * emacs.c (main): Fix syntax error.
2158
954b166e
PE
21592013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 Timestamp fixes for undo (Bug#14824).
2162 * atimer.c (schedule_atimer):
2163 * fileio.c (Ffile_newer_than_file_p):
2164 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2165 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2166 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2167 (syms_of_fileio): Remove Sclear_visited_file_name.
2168 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2169 file doesn't exist; this avoids an ambiguity with negative timestamps.
2170 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2171 * systime.h (make_emacs_time, invalid_emacs_time):
2172 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2173 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2174 * undo.c (record_first_change): Push (visited-file-modtime) onto
2175 undo list rather than reimplementing it by hand, incorrectly.
2176
d74647c3
KB
21772013-07-09 Ken Brown <kbrown@cornell.edu>
2178
2179 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2180
3c51b96b
JB
21812013-07-09 Juanma Barranquero <lekktu@gmail.com>
2182
2183 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2184
4ebbdd67
PE
21852013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2186
2187 Handle errno and exit status a bit more carefully.
2188 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2189 number into an exit status. Instead, use EXIT_CANCELED.
2190 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2191 * callproc.c (relocate_fd):
2192 * emacs.c (close_output_streams, main):
2193 * process.c (create_process):
2194 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2195 Use emacs_perror for simplicity.
2196 * callproc.c (relocate_fd, main):
2197 * sysdep.c (sys_subshell):
2198 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2199 (shut_down_emacs): Use emacs_write, not write.
2200 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2201 * fileio.c (Fcopy_file, e_write):
2202 * nsterm.m (ns_select):
2203 * process.c (send_process):
2204 * sound.c (vox_write):
2205 Use emacs_write_sig, not emacs_write.
2206 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2207 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2208 New constants.
2209 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2210 of write.
2211 (emacs_full_write): New function.
2212 (emacs_write): Rewrite to use it.
2213 (emacswrite_sig, emacs_perror): New functions.
2214 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2215
44e18199 22162013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2217
2218 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2219 on NS even if it is present. Pixmap on NS is a void*.
2220
9caab067
PE
22212013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 Port to Ubuntu 10 (Bug#14803).
2224 Problem reported by T.V. Raman.
2225 * process.c (close_on_exec, accept4, process_socket):
2226 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2227
1d442672
EZ
22282013-07-07 Eli Zaretskii <eliz@gnu.org>
2229
2230 * w32.c (sys_dup): Declare prototype.
2231
2232 * filelock.c:
2233 * emacs.c:
2234 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2235
067428c1
PE
22362013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2237
2238 Make file descriptors close-on-exec when possible (Bug#14803).
2239 This simplifies Emacs a bit, since it no longer needs to worry
2240 about closing file descriptors by hand in some cases.
2241 It also fixes some unlikely races. Not all such races, as
2242 libraries often open files internally without setting
2243 close-on-exec, but it's an improvement.
2244 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2245 * callproc.c (Fcall_process) [!MSDOS]:
2246 * emacs.c (main) [!DOS_NT]:
2247 * nsterm.m (ns_term_init):
2248 * process.c (create_process):
2249 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2250 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2251 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2252 Prefer mkostemp with O_CLOEXEC to mkstemp.
2253 * callproc.c (relocate_fd) [!WINDOWSNT]:
2254 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2255 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2256 now using pipe2.
2257 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2258 Make the resulting file descriptor close-on-exec.
2259 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2260 * lread.c (load_descriptor_list, load_descriptor_unwind):
2261 Remove; no longer needed. All uses removed.
2262 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2263 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2264 New functions.
2265 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2266 (Fmake_network_process, Fnetwork_interface_list):
2267 (Fnetwork_interface_info, server_accept_connection):
2268 Make newly-created socket close-on-exec.
2269 * sysdep.c (emacs_open, emacs_fopen):
2270 Make new-created descriptor close-on-exec.
2271 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2272 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2273
0da857dd
JD
22742013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2275
2276 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2277 for NS_IMPL_GNUSTEP.
2278
5f86adcd
PE
22792013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 Fix openp errno handling.
2282 * callproc.c (Fcall_process): Preserve openp errno around close.
2283 * lread.c (openp): Set errno when returning -1, as some callers
2284 expect this.
2285
1afb1d07
JD
22862013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2287
2288 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2289
2290 * nsterm.h (NSSavePanel): Update comment.
2291 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2292 (ns_run_file_dialog): Declare.
2293
2294 * nsfns.m: Remove panelOK.
2295 (ns_fd_data): New.
2296 (ns_run_file_dialog): New function.
2297 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2298 event loop, so file dialog is popped up by ns_run_file_dialog, called
2299 by sendEvent (Bug#14578).
2300 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2301
3323c263
EZ
23022013-07-06 Eli Zaretskii <eliz@gnu.org>
2303
fdda0220
EZ
2304 * xdisp.c (default_line_pixel_height): New function.
2305 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2306 (try_cursor_movement, redisplay_window, try_window)
2307 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2308
068f9124
SM
2309 * window.c (window_scroll_pixel_based):
2310 use default_line_pixel_height.
fdda0220
EZ
2311
2312 * dispextern.h (default_line_pixel_height): Add prototype.
2313
2314 * frame.c (x_set_line_spacing): Accept a float value for
2315 line-spacing parameter, per the documentation.
2316
3323c263
EZ
2317 * data.c (Fmultibyte_string_p): Doc fix.
2318
47ba6d43
PE
23192013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2320
406af475
PE
2321 Use emacs_open more consistently when opening files.
2322 This handles EINTR more consistently now, and makes it easier
2323 to introduce other uniform changes to file descriptor handling.
2324 * src/systdio.h: New file.
2325 * src/buffer.c (mmap_init):
2326 * cygw32.c (chdir_to_default_directory):
2327 * dispnew.c (Fopen_termscript):
2328 * emacs.c (Fdaemon_initialized):
2329 * fileio.c (Fdo_auto_save):
2330 * image.c (slurp_file, png_load_body, jpeg_load_body):
2331 * keyboard.c (Fopen_dribble_file):
2332 * lread.c (Fload):
2333 * print.c (Fredirect_debugging_output):
2334 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2335 * termcap.c (tgetent):
2336 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2337 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2338 * w32term.c (w32_initialize) [CYGWIN]:
2339 * xfaces.c (Fx_load_color_file):
2340 Use emacs_open instead of plain open, and emacs_fopen instead of
2341 plain fopen.
2342 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2343 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2344 * callproc.c (default_output_mode): New constant.
2345 (Fcall_process): Use it to call emacs_open instead of plain creat.
2346 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2347 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2348 (emacs_fopen): New function.
2349 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2350 Include <lisp.h>, for emacs_open.
2351 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2352
47ba6d43
PE
2353 Remove duplicate #include directives.
2354 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2355 * xfaces.c:
2356 Don't include stdio.h twice.
2357 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2358 Don't include sys/types.h or stdio.h twice.
2359 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2360 * lread.c: Don't include coding.h twice.
2361 * nsfont.m: Don't include frame.h twice.
2362 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2363 * ralloc.c: Don't include <unistd.h> twice.
2364 * xdisp.c: Don't include font.h twice.
2365 * xterm.c: Don't include fontset.h twice.
2366 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2367
b9ed53d5
PE
23682013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 Scale ImageMagick images more carefully.
2371 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2372 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2373 Be more careful about avoiding undefined behavior after
2374 integer overflow and division by zero.
2375
cf13177e
YM
23762013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2377
2378 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2379 (syms_of_w32fns): DEFSYM them.
2380 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2381 (CCHDEVICENAME): Define macros if not defined.
2382 (struct MONITOR_INFO_EX): New struct.
2383 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2384 (enum_display_monitors_fn): New variable.
2385 (globals_of_w32fns): Initialize it.
2386 (Fx_display_pixel_width, Fx_display_pixel_height)
2387 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2388 multi-monitor setups in docstrings.
2389 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2390 screen size by primary monitor's millimeter per pixel.
2391 (w32_monitor_enum, w32_display_monitor_attributes_list)
2392 (w32_display_monitor_attributes_list_fallback)
2393 (Fw32_display_monitor_attributes_list): New functions.
2394 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2395
2396 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2397 if not defined.
2398 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2399
86dfb7a8
MA
24002013-07-04 Michael Albinus <michael.albinus@gmx.de>
2401
2402 * fileio.c (Qfile_notify_error): New error symbol.
2403
2404 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2405 * inotify.c (inotify_callback, symbol_to_inotifymask)
2406 (Finotify_add_watch, Finotify_rm_watch): Use it.
2407 (inotifyevent_to_event): Exchange order of cookie and file name.
2408 (Finotify_add_watch): Adapt docstring.
2409
2410 * lisp.h (Qfile_notify_error): Declare.
2411
2c1c974b
PE
24122013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2415 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2416 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2417 which did not work (see <http://bugs.gnu.org/14569#307>).
2418 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2419 && (!noninteractive || initialized)). This attempts to thread
2420 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2421
7a35b20f
JB
24222013-07-04 Juanma Barranquero <lekktu@gmail.com>
2423
2424 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2425 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2426
1ce5cd04
PE
24272013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2428
2429 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2430 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2431 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2432 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2433
57f8c490
PE
24342013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2437 Define to __sys_siglist.
2438
bcffb5ca
EZ
24392013-07-02 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2442 word-wrap, so that overflow-newline-into-fringe would work in
2443 visual-line-mode. (Bug#2749)
2444 (move_it_in_display_line_to): When the last scanned display
2445 element fits exactly on the display line, and
2446 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2447 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2448 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2449 finding buffer position that corresponds to pixel coordinates,
2450 e.g. in buffer_posn_from_coords.
2451
2c41e781
JD
24522013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2453
2454 * process.c (handle_child_signal): Call catch_child_signal if
2455 NS_IMPL_GNUSTEP.
2456
c2418359
PE
24572013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2458
52a9bcae
PE
2459 Don't convert function pointers to void * and back.
2460 It isn't portable C, and it's easy enough to avoid.
2461 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2462 (make_save_value): Add support for SAVE_FUNCPOINTER.
2463 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2464 * print.c (print_object):
2465 Distinguish function from object pointers.
2466 * lisp.h (SAVE_FUNCPOINTER): New constant.
2467 (SAVE_SLOT_BITS): Adjust to it.
2468 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2469 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2470 (voidfuncptr): New typedef.
2471 (struct Lisp_Save_Value): New member data[0].funcpointer.
2472 (XSAVE_FUNCPOINTER): New function.
2473
c2418359
PE
2474 Simplify buildobj processing.
2475 * Makefile.in (buildobj.h): Make it a sequence of strings each
2476 followed by comma, rather than a single string. Put it into a
2477 .tmp file in case there's an error while generating it.
2478 (gl-stamp): Use .tmp for temp files.
2479 (mostlyclean): Clean .tmp files.
2480 * doc.c (buildobj): Move to just the routine that needs it.
2481 It's now an array of strings, so processing is simpler.
2482
8f43ce49
PE
24832013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2486 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2487 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2488 Invoke malloc_enable_thread even when not interactive.
2489 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2490 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2491 in this case, since the underlying bug has now been fixed.
2492
24827db9
JB
24932013-07-01 Juanma Barranquero <lekktu@gmail.com>
2494
2495 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2496 unlinking it (bug#14691).
2497
ef099a94
MN
24982013-06-30 Michal Nazarewicz <mina86@mina86.com>
2499
2500 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2501 before checking whether buffer is modified. This lets
2502 `kill-buffer-query-functions' cancel killing of the buffer or save
2503 its content before `kill-buffer' asks user the "Buffer %s
2504 modified; kill anyway?" question.
2505
9d3f2fc2
JD
25062013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2507
2508 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2509 Let the super performKeyEquivalent deal with them (Bug#14747).
2510
e6c6c8c7
PE
25112013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2512
1d71c1d9
PE
2513 * widget.c (resize_cb): Remove unused local.
2514
8f5f35cc
PE
2515 Do not use GTK 3 if it exists but cannot be compiled.
2516 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2517 * xterm.c (x_error_handler) [!USE_GTK]:
2518 Do not use GTK 3.
2519
e6c6c8c7
PE
2520 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2521
0ba54312
EZ
25222013-06-30 Eli Zaretskii <eliz@gnu.org>
2523
5d1c3286
EZ
2524 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2525 to the valid range of values. (Bug#14753)
2526
0ba54312
EZ
2527 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2528 when moving point by using the current glyph matrix. This avoids
2529 the need to force redisplay when this function is called in a
2530 loop.
2531
9c90cc06
PE
25322013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 Fix minor problems found by static checking.
2535 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2536 Redo the latter's body to sidestep GCC parenthesization warnings.
2537 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2538 * coding.c (detect_coding, detect_coding_system):
2539 * coding.h (struct undecided_spec):
2540 Use bool for boolean.
2541 * image.c (QCmax_width, QCmax_height): Now static.
2542 * xdisp.c (Fmove_point_visually): Remove unused local.
2543
4c672a0f
EZ
25442013-06-29 Eli Zaretskii <eliz@gnu.org>
2545
2546 * xdisp.c (Fmove_point_visually): New function.
2547
c1ea3abf
JB
25482013-06-28 Kenichi Handa <handa@gnu.org>
2549
2550 * coding.h (define_coding_undecided_arg_index): New enum.
2551 (coding_attr_index): New members
2552 coding_attr_undecided_inhibit_null_byte_detection,
2553 coding_attr_undecided_inhibit_iso_escape_detection,
2554 coding_attr_undecided_prefer_utf_8.
2555 (undecided_spec): New struct.
2556 (struct coding_system): New member `undecided' of the member
2557 `spec'.
2558
2559 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2560 (detect_coding): Likewise.
2561 (detect_coding_system): Likewise.
2562 (Fdefine_coding_system_internal): New coding system properties
2563 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2564 :prefer-utf-8.
2565 (syms_of_coding): Adjust for coding_arg_undecided_max.
2566
ba3de9e6
PE
25672013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 * image.c (x_from_xcolors): Remove unused local.
2570
547c9269
YM
25712013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2572
2573 Defer image data transfer between X client and server until actual
2574 display happens.
2575
2576 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2577 and `mask_img'.
2578
2579 * image.c (Destroy_Image): Remove.
2580 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2581 `mask_p', and `colors_p'. All uses changed.
2582 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2583 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2584 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2585 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2586 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2587 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2588 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2589 (image_get_x_image, image_unget_x_image): New functions or macros.
2590 (image_background, image_background_transparent, x_to_xcolors)
2591 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2592 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2593 instead of Destroy_Image.
2594 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2595 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2596 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2597 (imagemagick_load_image, svg_load_image): Use them instead of
2598 x_create_x_image_and_pixmap, and x_put_x_image followed by
2599 x_destroy_x_image, respectively.
2600 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2601 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2602 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2603 background_transparent fields.
2604 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2605 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2606
dae2f5ef
PE
26072013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2608
2609 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2610 This mostly consists of undoing recent changes.
2611 * callproc.c (Fcall_process):
2612 * process.c (create_process):
2613 Do not worry about catching SIGCHLD here, undoing previous change.
2614 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2615 * process.c, process.h (catch_child_signal):
2616 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2617 * process.c (catch_child_handler): Don't worry about being called
2618 lazily and do not assume caller has blocked SIGCHLD, undoing
2619 previous change. Move first-time stuff back to
2620 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2621 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2622 set lib_child_handler if it's already initialized, which may
2623 help avoid problems on GNUStep.
2624
fa55d2aa
PE
26252013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2626
2627 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2628 * callproc.c (Fcall_process):
2629 * process.c (create_process):
2630 Make sure SIGCHLD is caught before we fork,
2631 since Emacs startup no arranges to catch SIGCHLD.
2632 * process.c (lib_child_handler): Initialize to null, not to
2633 dummy_handler.
2634 (catch_child_signal): Allow self to be called lazily.
2635 Do nothing if it's already been called.
2636 Assume caller has blocked SIGCHLD (all callers do now).
2637 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2638 just before it's really needed.
2639 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2640 since it hasn't been caught yet.
2641
f3f9606c
LMI
26422013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2643
2644 * image.c (compute_image_size): New function to implement
2645 :max-width and :max-height.
2646 (imagemagick_load_image): Use it.
2647
c7041908
PE
26482013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2649
2650 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2651 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2652 Now extern.
2653 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2654 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2655 the SIGCHLD handler, since the code is not atomic and (due to glib)
2656 signals may be arriving now.
2657 * sysdep.c (init_signals): Do not catch child signals here;
2658 'main' now does that later, at a safer time.
2659
f86852b4
PE
26602013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2661
0dfeed58
PE
2662 Clean up SIGCHLD handling a bit (Bug#14569).
2663 * process.c, process.h (catch_child_signal):
2664 Now always extern, even if !NS_IMPL_GNUSTEP.
2665 * process.c (catch_child_signal): Move glib tickler here from
2666 init_process_emacs, so that it's done earlier in Emacs
2667 initialization. Also move the noninteractive && !initialized
2668 check here from init_process_emacs. This is all a bit cleaner for
2669 GNUish platforms, and I hope it works around the Cygwin bug.
2670 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2671 that glib signal handling is tickled before glib creates threads.
2672
f86852b4
PE
2673 * process.c (wait_reading_process_output): Avoid int overflow
2674 when reading more than 2 GiB total from a process.
2675
cbd6509c
PE
26762013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 * process.c (create_process): Handle a couple more cases,
2679 i.e., work even if new_argv and wait_child_setup[i] are cached.
2680 Use Fcall_process's style for volatile vars.
2681
9de1114a
AS
26822013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2683
2684 * process.c (create_process): Mark PROCESS volatile.
2685
fbe9e0b9
PE
26862013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2687
2688 Use C99-style flexible array members if available.
2689 This avoids some subtle aliasing issues, which typically
2690 aren't a problem with GCC but may be a problem elsewhere.
2691 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2692 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2693 In either case, it uses a flexible array member rather than
2694 the old struct hack. All uses changed.
2695 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2696 Adjust to sdata reorganization.
2697 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2698 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2699 that ports better to pre-C99 non-GCC.
2700 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2701 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2702 as the latter has changed.
2703 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2704 and port better to pre-C99 GCC.
2705 * image.c (struct xpm_cached_color):
2706 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2707 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2708 Use FLEXIBLE_ARRAY_MEMBER.
2709 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2710 Move decl to top level so it gets checked against implementation.
2711 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2712 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2713
1fc71008
PE
27142013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 * syntax.c: Integer cleanups.
2717 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2718 All uses that need 0-or-2 changed to:
2719 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2720 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2721 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2722 (char_quoted, prev_char_comend_first, back_comment)
2723 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2724 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2725 Use bool for boolean.
2726 (update_syntax_table, skip_chars, skip_syntaxes):
2727 Prefer int to unsigned when either will do.
2728 (back_comment): Return boolean success flag, like forw_comment,
2729 instead of positive-or-minus-1 (which might have overflowed int anyway).
2730 Don't stuff ptrdiff_t into int.
2731 (syntax_spec_code, syntax_code_spec): Now const.
2732 (Fmatching_paren, scan_lists, scan_sexps_forward):
2733 Use enum syntaxcode for syntax code.
2734 (Fmatching_paren): Check that arg is a character, not just an integer.
2735 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2736 (Finternal_describe_syntax_value): Omit no-longer-needed
2737 comparison to 0.
2738 (skip_chars): Use char, not unsigned char, when the distinction
2739 doesn't matter.
2740 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2741 * bytecode.c (exec_byte_code):
2742 * syntax.c (syntax_spec_code, Fchar_syntax)
2743 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2744 (init_syntax_once):
2745 * syntax.h (SYNTAX_WITH_FLAGS):
2746 Omit unnecessary casts.
2747
b932cad7
EZ
27482013-06-20 Eli Zaretskii <eliz@gnu.org>
2749
2750 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2751 line dimensions here, to avoid race conditions with the main
2752 thread. (Bug#14062, bug#14630, bug#14669)
2753
2754 * w32term.c (w32_draw_window_cursor): Compute the header line and
2755 mode line dimensions here.
2756 <w32_system_caret_window, w32_system_caret_hdr_height>:
2757 <w32_system_caret_mode_height>: New variables.
2758
2759 * w32term.h: Declare them.
2760
89561f72
PE
27612013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2762
5013fc08
PE
2763 * alloc.c (die): Move "assertion failed" string here ...
2764 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2765 COND when SUPPRESS_CHECKING. This shrinks the executable text
2766 size by 0.8% to 2.2% when configured with --enable-checking,
2767 depending on optimization flags (GCC 4.8.1 x86-64).
2768
89561f72
PE
2769 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2770
763a086d 27712013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2772
2773 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2774 base is 2; this is more accurate.
2775
983aeb9a
JB
27762013-06-19 Juanma Barranquero <lekktu@gmail.com>
2777
2778 * sound.c (string_default): Move to !WINDOWSNT section.
2779 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2780
178ba3e6
PE
27812013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2782
bbc51b15
PE
2783 * sound.c: Integer cleanups.
2784 Remove unnecessary forward decls.
2785 (struct sound_device): The 'file' member is now a Lisp_Object, not
2786 a char *, so that we needn't invoke alloca on a huge size.
2787 (Fplay_sound_internal): Adjust to this.
2788 (string_default): New function.
2789 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2790 Use it to adjust to the struct sound_device change.
2791 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2792 (be2hs) [0]: Remove.
2793
178ba3e6
PE
2794 * syntax.c (skip_chars): Don't use uninitialized storage
2795 when searching a multibyte buffer for characters that are not in a
2796 unibyte string that contains non-ASCII characters.
2797
69f60cdc
JD
27982013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2799
2800 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2801 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2802
0d6224d4
PE
28032013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2806
3c542890
KH
28072013-06-18 Kenichi Handa <handa@gnu.org>
2808
f7e3f7cd
KH
2809 * font.c (Ffont_spec): Signal an error for an invalid font name
2810 (Bug#14648).
3c542890 2811
9349e5f7
PE
28122013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2813
2814 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2815 In particular this ports to 32-bit sparc Sun cc.
2816 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2817 array with a dummy element at specpdl[-1], so that its address can
2818 be taken portably.
2819 (unbind_to): Do not copy the binding; not needed, now that we
2820 copy old_value in the one place where the copy is needed.
2821 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2822 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2823 (union specbinding): Rename from struct specbinding. Redo layout
2824 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2825 which is not portable. With Sun C 5.12 32-bit sparc, the
2826 declaration causes nargs to be an unsigned bitfield, a behavior
2827 that the C standard allows; but Emacs wants nargs to be signed.
2828 The overall type is now a union of structures rather than a
2829 structure of union of structures, and the 'kind' member is now a
2830 bitfield, so that the overall type doesn't grow. All uses changed.
2831 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2832
0a4df6a5
PE
28332013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2834
ec6ecaad
PE
2835 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2836 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2837
0a4df6a5
PE
2838 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2839
7bfe8dbc
EZ
28402013-06-17 Eli Zaretskii <eliz@gnu.org>
2841
2842 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2843 unless we know that the window w's frame is a frame object.
2844 Another attempt at solving bug#14062 and bug#14630.
2845
708e05f6
LMI
28462013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2847
2848 * textprop.c (property_set_type): New enum.
2849 (add_properties): Allow appending/prepending text properties.
2850 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2851 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2852 add_text_properties_1.
2853 (Fadd_face_text_property): New function that calls
2854 add_text_properties_1.
2855
84575e67
PE
28562013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 Move functions from lisp.h to individual modules when possible.
2859 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2860 * alloc.c (XFLOAT_INIT, set_symbol_name):
2861 * buffer.c (CHECK_OVERLAY):
2862 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2863 (set_char_table_parent):
2864 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2865 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2866 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2867 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2868 (set_blv_valcell):
2869 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2870 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2871 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2872 (backtrace_args, backtrace_debug_on_exit):
2873 * floatfns.c (CHECK_FLOAT):
2874 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2875 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2876 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2877 (set_hash_index_slot):
2878 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2879 * marker.c (CHECK_MARKER):
2880 * textprop.c (CHECK_STRING_OR_BUFFER):
2881 * window.c (CHECK_WINDOW_CONFIGURATION):
2882 Move here from lisp.h, and make these functions static rather than
2883 extern inline.
2884 * buffer.c (Qoverlayp):
2885 * data.c (Qsubrp):
2886 * fns.c (Qhash_table_p):
2887 * window.c (Qwindow_configuration_p):
2888 Now static.
2889 * lisp.h: Remove the abovementioned defns and decls.
2890
44e18199 2891 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2892 In lisp.h, prefer functions to function-like macros, and
2893 constants to object-like macros, when either will do. This:
2894 . simplifies use, as there's no more need to worry about
2895 arguments' side effects being evaluated multiple times.
2896 . makes the code easier to debug on some platforms.
2897 However, when using gcc -O0, keep using function-like macros
2898 for a few critical operations, for performance reasons.
2899 This sort of thing isn't needed with gcc -Og, but -Og
2900 is a GCC 4.8 feature and isn't widely-enough available yet.
2901 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2902 Remove enum lsb_bits; no longer needed.
2903 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2904 * buffer.c (Qoverlap):
2905 * data.c (Qsubrp):
2906 * fns.c (Qhash_table_p):
2907 Now extern, so lisp.h can use these symbols.
2908 * dispextern.h: Include character.h, for MAX_CHAR etc.
2909 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2910 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2911 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2912 (GLYPH_CODE_P): Move here from lisp.h.
2913 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2914 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2915 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2916 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2917 XUNTAG now returns void *.
2918 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2919 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2920 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2921 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2922 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2923 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2924 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2925 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2926 New macros, renamed from their sans-lisp_h_ counterparts.
2927 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2928 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2929 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2930 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2931 If compiling via GCC without optimization, define these as macros
2932 in addition to inline functions.
2933 To disable this, compile with -DINLINING=0.
2934 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2935 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2936 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2937 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2938 (INTMASK, VALMASK): Now macros, since static values cannot be
2939 accessed from extern inline functions.
2940 (VALMASK): Also a constant, for benefit of old GDB.
2941 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2942 is INTEGERP, which can fold it in.
5165d44a 2943 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2944 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2945 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2946 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2947 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2948 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2949 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2950 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2951 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2952 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2953 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2954 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2955 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2956 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2957 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2958 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2959 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2960 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2961 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2962 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2963 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2964 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2965 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2966 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2967 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2968 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2969 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2970 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2971 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2972 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2973 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2974 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2975 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2976 Now functions.
2977 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2978 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2979 (VALMASK): Define in one place rather than in two, merging the
2980 USE_LSB_TAG parts; this is simpler.
2981 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2982 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2983 Move up, to avoid use before definition.
2984 Also include "globals.h" earlier, for the same reason.
2985 (make_natnum): New function.
2986 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2987 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2988 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2989 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2990 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2991 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2992 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2993 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2994 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2995 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2996 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2997 (Qwindow_configuration_p, Qimage): New forward declarations.
2998 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2999 (STRING_COPYIN): Remove; unused.
3000 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3001 (xcar_addr, xcdr_addr): New functions. All uses changed.
3002 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3003 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3004 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3005 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3006 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3007 (TYPE_RANGED_INTEGERP): Simplify.
3008 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3009 (setlocale, fixup_locale, synchronize_system_messages_locale)
3010 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3011 Now empty functions, not macros.
3012 (functionp): Return bool, not int.
3013 * window.c (Qwindow_configuration_p): Now extern,
3014 so window.h can use it.
3015 * window.h (Qwindowp): Move decl back to lisp.h.
3016
9583ec36
EZ
30172013-06-15 Eli Zaretskii <eliz@gnu.org>
3018
3019 * xdisp.c (Fline_pixel_height): New function, required for solving
3020 bug #14567.
3021
210272ce
PE
30222013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3023
3024 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3025
de0503df
SM
30262013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3027
3028 * lread.c (syms_of_lread):
3029 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3030
afbfe143
KD
30312013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3032
3033 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3034
d177e213
XF
30352013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3036
3037 * fileio.c (expand_file_name): Doc fix.
3038
05e3e412
PE
30392013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3040
f7394b12
PE
3041 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3042 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3043 Wait for self, not for 0. This can't hurt on GNU or similar
3044 system, and may help with Cygwin.
3045
05e3e412
PE
3046 * keyboard.c: Don't use PROP (...) as an lvalue.
3047 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3048 Use set_prop (A, B), not PROP (A) = B.
3049
17dd3097
EZ
30502013-06-10 Eli Zaretskii <eliz@gnu.org>
3051
3052 * xdisp.c (get_it_property): Use it->window instead of generating
3053 a Lisp object from it->w.
3054
52fab9c9
EZ
30552013-06-09 Eli Zaretskii <eliz@gnu.org>
3056
3057 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3058 get-char-property the window that is being rendered, instead of
3059 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3060 (compute_display_string_pos): When W is NULL, use the current
3061 buffer as the object to pass to get-char-property.
3062 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3063 pointer member of the bidi iterator, since no window is pertinent
3064 to this function.
52fab9c9 3065
5bf97bfc
EZ
30662013-06-08 Eli Zaretskii <eliz@gnu.org>
3067
3068 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3069 being displayed, and pass it to compute_display_string_pos.
3070 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3071 (bidi_paragraph_init): All callers changed.
3072
3073 * xdisp.c (init_from_display_pos, init_iterator)
3074 (handle_single_display_spec, next_overlay_string)
3075 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3076 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3077 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3078 (compute_display_string_pos): Accept additional argument, the
3079 window being displayed, and pass it to Fget_char_property.
3080 (Bug#14575)
3081
3082 * dispextern.h (struct bidi_it): New member w, the window being
3083 displayed.
3084 (compute_display_string_pos): Adjust prototype.
3085
5de0e011
JD
30862013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3087
e7b41c4c 3088 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3089
3090 * process.c (wait_reading_process_output): Check for NS before GLIB.
3091 GLIB may be linked in due to rsvg, but ns_select must be called.
3092
5de0e011
JD
3093 * xgselect.c (xg_select): Remove call to window_system_available
3094 and g_main_context_pending at the top, so Gdk events (i.e. file
3095 notify) are processed when Emacs is started with -nw.
3096
a822acff
EZ
30972013-06-07 Eli Zaretskii <eliz@gnu.org>
3098
3099 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3100 (ctagsfiles3): New variable, includes only *.m files.
3101 (TAGS): Use an explicit language name in the regular expressions,
3102 to avoid transformation of '/SOMETHING' by MSYS to
3103 'c:\MSYS\SOMETHING'.
3104
6c0a9ed1
RC
31052013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3106
3107 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3108
9ef6111b
EZ
31092013-06-06 Eli Zaretskii <eliz@gnu.org>
3110
3111 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3112 still need to set the mouse pointer shape and activate help-echo.
3113 (Bug#14558)
3114
7d300d64
PE
31152013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 A few porting etc. fixes for the new file monitor code.
3118 See the thread containing
3119 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3120 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3121 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3122 (dir_monitor_callback, Fgfile_rm_watch):
3123 Use assq_no_quit instead of Fassoc, for speed.
3124 (dir_monitor_callback, Fgfile_rm_watch):
3125 eassert that the monitor is a fixnum.
3126 (dir_monitor_callback): No need for CDR_SAFE.
3127 Simplify building of lisp with alternative tails.
3128 (Fgfile_add_watch, Fgfile_rm_watch):
3129 Do not assume glib functions set errno reliably on failure.
3130 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3131 and signal an error otherwise.
3132 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3133 Use Fdelq instead of Fdelete, for speed.
3134
817ebfcf
EZ
31352013-06-05 Eli Zaretskii <eliz@gnu.org>
3136
3137 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3138 don't insist on being invoked on a highlighted tool-bar button.
3139 Avoids losing tool-bar functionality when mouse-highlight is nil.
3140 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3141 Don't highlight when mouse-highlight is nil.
3142 (note_mouse_highlight): When mouse-highlight is nil, don't return
3143 right away; instead, run tool-bar and mode-line highlight
3144 subroutine, clear any existing highlight, and revert the mouse
3145 pointer to its default shape. (Bug#14558)
3146
55577e7c
SM
31472013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3148
3149 * lisp.mk (lisp): Add prog-mode.el.
3150
f019a684
PE
31512013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3154 * process.c (dummy_handler): New function.
3155 (lib_child_handler): New static var.
3156 (handle_child_signal): Invoke it.
3157 (catch_child_signal): If a library has set up a signal handler,
3158 save it into lib_child_handler.
3159 (init_process_emacs): If using glib and not on Windows, tickle glib's
3160 child-handling code so that it initializes its private SIGCHLD handler.
3161 * syssignal.h (SA_SIGINFO): Default to 0.
3162 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3163 31; it should no longer be needed now.
3164
90db8702
MA
31652013-06-05 Michael Albinus <michael.albinus@gmx.de>
3166
3167 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3168
3169 * gfilenotify.c (globals_of_gfilenotify): New function.
3170 (syms_of_gfilenotify): Move global initialization there.
3171
3172 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3173
bfa3acd6
SM
31742013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3175
3176 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3177 * keyboard.c (menu_bar_items, tool_bar_items):
3178 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3179 not override local keymaps any more.
3180
ba59bd80
EZ
31812013-06-04 Eli Zaretskii <eliz@gnu.org>
3182
3183 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3184
7f203aa1
EZ
31852013-06-03 Eli Zaretskii <eliz@gnu.org>
3186
9337e206
EZ
3187 * w32console.c (initialize_w32_display): Return the dimensions of
3188 the console window via 2 additional arguments, not via the current
3189 frame. This avoids crashes due to overrunning the bounds of
3190 frame's decode_mode_spec_buffer, which is not resized following
3191 the change of the frame dimensions from the initial 10x10.
3192
3193 * w32term.h (w32_initialize_display_info): Adjust prototype.
3194
3195 * term.c (init_tty): Take dimensions of the frame from the values
3196 returned by initialize_w32_display.
3197
7f203aa1
EZ
3198 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3199 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3200 (LIBES): Add $(GFILENOTIFY_LIBS).
3201
3202 * w32inevt.c (handle_file_notifications): Add dummy implementation
3203 for !HAVE_W32NOTIFY.
3204
3205 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3206
55a87246
JD
32072013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3208
3209 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3210
3211 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3212
3213 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3214
3d5ee10a
PE
32152013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 Fix minor problems found by static checking.
3218 * data.c (pure_write_error):
3219 Use xsignal2, not Fsignal, as Fsignal might return.
3220 * eval.c (set_backtrace_debug_on_exit): Now static.
3221 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3222 No longer inline. EXTERN_INLINE is needed only for functions
3223 defined in .h files. Reindent function header as per GNU style.
3224 (backtrace_p, backtrace_top, backtrace_next):
3225 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3226 compiler or linker. Add extern decls to pacify gcc -Wall.
3227 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3228 Now static.
3229 * frame.c (free_monitors): Define only on platforms that need it.
3230 * nsterm.m (ns_term_init):
3231 * process.c (catch_child_signal):
3232 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3233 defined on all porting targets these days.
3234 * process.c, process.h (catch_child_signal):
3235 Make it extern only if NS_IMPL_GNUSTEP is defined.
3236
e2d8a6f0
EZ
32372013-06-03 Eli Zaretskii <eliz@gnu.org>
3238
3239 * w32.c (gettimeofday): Make the signature identical to prototype
3240 in nt/inc/sys/time.h.
3241
a8a7c5f6
SM
32422013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3243
3244 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3245 .gdbinit.
3246
3247 * keyboard.c (safe_run_hooks_error): Improve error message.
3248
3249 * data.c (pure_write_error): Add `object' argument.
3250 * puresize.h (CHECK_IMPURE): Use it.
3251
c9628c79
MA
32522013-06-03 Michael Albinus <michael.albinus@gmx.de>
3253
3254 * Makefile.in (NOTIFY_OBJ): New variable.
3255 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3256
3257 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3258 Call syms_of_gfilenotify.
3259
3260 * gfilenotify.c: New file.
3261
3262 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3263 and Qfile_w32notify.
3264 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3265 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3266
3267 * lisp.h: Declare syms_of_gfilenotify.
3268
3269 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3270
2f592f95
SM
32712013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3272
3273 Merge the specpdl and backtrace stacks. Make the structure of the
3274 specpdl entries more obvious via a tagged union of structs.
3275 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3276 (enum specbind_tag): New enum.
3277 (struct specbinding): Make it a tagged union of structs.
3278 Add a case for backtrace records.
3279 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3280 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3281 (backtrace_debug_on_exit): New accessors.
3282 (struct backtrace): Remove.
3283 (struct catchtag): Remove backlist field.
3284 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3285 Move to eval.c.
3286 (Flocal_variable_p): Speed up the common case where the binding is
3287 already loaded.
3288 * eval.c (backtrace_list): Remove.
3289 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3290 (set_backtrace_args, set_backtrace_nargs)
3291 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3292 (backtrace_next): New functions.
3293 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3294 (unwind_to_catch, internal_lisp_condition_case)
3295 (internal_condition_case, internal_condition_case_1)
3296 (internal_condition_case_2, internal_condition_case_n): Don't bother
3297 with backtrace_list any more.
3298 (Fsignal): Adjust to new backtrace format.
3299 (grow_specpdl): Move up.
3300 (record_in_backtrace): New function.
3301 (eval_sub, Ffuncall): Use it.
3302 (apply_lambda): Adjust to new backtrace format.
3303 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3304 data.c.
3305 (specbind): Adjust to new specpdl format. Simplify.
3306 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3307 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3308 backtrace format.
3309 (mark_backtrace): Remove.
3310 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3311 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3312 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3313 Use mark_specpdl.
3314 * profiler.c (record_backtrace): Use get_backtrace.
3315 (handle_profiler_signal): Use backtrace_top_function.
3316 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3317 accessor functions.
3318
c0342369
JD
33192013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3320
3321 * process.h (catch_child_signal): Declare.
3322
3323 * process.c (catch_child_signal): New function.
3324 (init_process_emacs): Call it.
3325
3326 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3327 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3328 NS_IMPL_COCOA.
3329 (x_set_cursor_type): Remove declaration.
3330 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3331 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3332 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3333 (ns_get_color): Use F suffix on float.
3334 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3335 (ns_get_rgb_color): Remove.
3336 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3337 (note_mouse_movement): x and y are CGFloat.
3338 (ns_draw_fringe_bitmap): Remove unused rowY.
3339 Change #if to COCOA && >= 10_6.
3340 (ns_draw_window_cursor): Remove unused overspill.
3341 (ns_draw_underwave): width and x are EamcsCGFloat.
3342 (ns_draw_box): thickness is CGFloat.
3343 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3344 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3345 if not in main thread.
3346 (ns_get_pending_menu_title, ns_check_menu_open)
3347 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3348 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3349 (sendFromMainThread:): New method.
3350 (changeFont:): size is CGFloat.
3351 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3352 Disable warning about permanent text.
3353 (characterIndexForPoint:): Adjust return type depending on GNUStep
3354 version.
3355 (mouseDown:): delta is CGFloat.
3356 (updateFrameSize): Remove unised variable f.
3357 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3358 Cast float to EmacsCGFloat.
3359 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3360 also to -1 when restoring.
3361 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3362 inside NS_IMPL_COCOA.
3363 (toggleFullScreen:): Put call to toggleFullScreen inside
3364 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3365 (setPosition:portion:whole:): por is CGFloat.
3366 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3367 (mouseDown:): Use CGFloat.
3368 (mouseDragged:): Remove unised variable edge.
3369 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3370
3371 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3372 of CGFloat differs.
3373 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3374 when NS_IMPL_GNUSTEP.
3375 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3376 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3377 (EmacsToolbar): Add clearAll. Add tag argument to
3378 addDisplayItemWithImage.
3379 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3380
3381 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3382
3383 * nsmenu.m (ns_update_menubar): Make static.
3384 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3385 (fillWithWidgetValue:): Add cast to SEL for setAction.
3386 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3387 (update_frame_tool_bar): Update code for GNUStep.
3388 (clearAll): New method.
3389 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3390 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3391 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3392 call to insertItemWithItemIdentifier.
3393 (validateVisibleItems): Fix indentation.
3394 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3395 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3396 UtilityWindow to aStyle, remove call to setStyleMask.
3397
3398 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3399
3400 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3401 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3402 Use F suffix on floats.
3403 (ns_char_width): Returns CGFloat.
3404 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3405 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3406 DPSxshow.
3407 (ns_glyph_metrics): CGFloat instead of float.
3408
a0eb10b3
JB
3409 * nsfns.m (x_set_foreground_color, x_set_background_color):
3410 Use EmacsCGFloat.
3411 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3412 remove unused variables.
3413 (Fns_read_file_name): Keep track if panel is for save.
3414 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3415 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3416 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3417 Just return the input if GNUStep.
c0342369
JD
3418 (x_screen_planes): Remove.
3419 (Fxw_color_values): Use EmacsCGFloat
3420 (Fns_display_monitor_attributes_list): Only get screen number for
3421 Cocoa.
ef099a94 3422 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3423 EmacsSavePanel.
3424 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3425 ns_directory_from_panel.
3426
da9aff11
PE
34272013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3428
3429 * process.c (handle_child_signal): Also use WCONTINUED.
3430 This is so that list-processes doesn't mistakenly list the process
3431 as stopped, when the process has actually been continued and is
3432 now running.
3433
0e64479a
PE
34342013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3435
fc186a96
PE
3436 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3437 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3438 not already configured.
3439
0e64479a
PE
3440 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3441
38b787fa
EZ
34422013-05-29 Eli Zaretskii <eliz@gnu.org>
3443
3444 * Makefile.in (mostlyclean): Remove *.res files.
3445
22513e52
SM
34462013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3447
3448 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3449 a buffer (bug#8447).
3450
6ef3db10
EZ
34512013-05-27 Eli Zaretskii <eliz@gnu.org>
3452
3453 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3454 display vector, and we backtrack, handle the case that the
3455 previous character position is also displayed from a display
3456 vector or covered by a display string or image. (Bug#14476)
3457
6799bb26
JD
34582013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3459
3460 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3461 (struct MonitorInfo, free_monitors): Remove.
3462 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3463 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3464 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3465 Qframes, Qsource.
3466
3467 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3468 (struct MonitorInfo, free_monitors): Remove.
3469 (ns_screen_name): Make static.
3470 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3471 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3472 Qframes, Qsource.
3473
3474 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3475 (struct MonitorInfo): New struct.
3476 (free_monitors, make_monitor_attribute_list): Declare.
3477
22513e52
SM
3478 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3479 New Lisp_Object:s.
6799bb26
JD
3480 (free_monitors, make_monitor_attribute_list): New functions.
3481 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3482 Qsource.
3483
38cd43eb
XF
34842013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3485
3486 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3487
2af0948d
SM
34882013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3489
a7eb9b0f
SM
3490 * keyboard.c: Apply keyboard decoding only to events that come directly
3491 from the tty, not from unread-command-events (bug#14368).
3492 (read_event_from_main_queue): New function, extracted from read_char).
3493 (read_decoded_char): Remove.
3494 (read_decoded_event_from_main_queue): New function to replace it.
3495 (read_char): Use it.
3496 (read_key_sequence): Use read_char rather than read_decoded_char.
3497
2af0948d
SM
3498 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3499
1413e9a5
BR
35002013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3501
3502 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3503
e6d2f155
KH
35042013-05-22 Kenichi Handa <handa@gnu.org>
3505
3506 The following changes are to fix the setting of
3507 buffer-file-coding-system on, for instance, C-x RET c unix RET
3508 _FILE_OF_DOS_EOL_TYPE_ RET.
3509
3510 * coding.h (struct coding_system): New member detected_utf8_chars.
3511
3512 * coding.c (detect_coding_utf_8): Count characters and check EOL
3513 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3514 BOM is there.
3515 (setup_coding_system): Do not initialize coding->head_ascii.
3516 (check_ascii): Do not set coding->eol_seen but update it. Do not
3517 call adjust_coding_eol_type here.
1413e9a5
BR
3518 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3519 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3520 of the found coding-system.
3521 (decode_coding_gap): Cancel previous change. Utilize the
3522 character numbers counted by detect_coding_utf_8. Fix detection
3523 of BOM for utf-8.
3524
ab56a6f4 35252013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3526
3527 * search.c (looking_at_1): Only set last_thing_searched if the match
3528 changed the match-data (bug#14281).
3529
ecc3c6ed
DA
35302013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3531
3532 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3533 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3534 (move_it_vertically_backward): Likewise.
3535
5ba8bf35
YM
35362013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3537
3538 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3539 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3540 (Fx_display_mm_width, Fx_display_mm_height):
3541 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3542
91e8418b 3543 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3544 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3545 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3546 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3547 (Fx_display_backing_store, Fx_display_visual_class)
3548 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3549 (Fx_display_grayscale_p, Fx_display_pixel_width)
3550 (Fx_display_pixel_height, Fx_display_planes)
3551 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3552 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3553 (Fx_display_mm_width, Fx_display_mm_height)
3554 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3555 height for all physical monitors as in X11.
3556
fc30d803
SM
3557 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3558 Return pixel width or height for all physical monitors as in X11.
91e8418b 3559
31ff141c
PE
35602013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3561
3562 Port --enable-gcc-warnings to clang.
3563 * bytecode.c (exec_byte_code):
3564 * regex.c:
3565 Redo diagnostic pragmas to pacify clang, too.
3566 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3567 * editfns.c (Fencode_time):
3568 * fileio.c (file_accessible_directory_p):
3569 * font.c (font_unparse_xlfd):
3570 Use '&"string"[index]' instead of '"string" + (index)'.
3571 * undo.c (user_error): Remove; unused.
3572
df065a0b
EZ
35732013-05-16 Eli Zaretskii <eliz@gnu.org>
3574
04d360e7
EZ
3575 * insdel.c (insert_1_both): Document the arguments, instead of
3576 referring to insert_1, which no longer exists.
3577
5bb98290
EZ
3578 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3579 some window, increment windows_or_buffers_changed, so that
3580 *Messages* display in that window is updated. (Bug#14408)
3581
df065a0b
EZ
3582 * w32.c: Include epaths.h.
3583 (init_environment): Use cmdproxy.exe without leading directories.
3584 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3585 case.
3586 (gettimeofday): Adjust signature and return value to Posix
3587 expectations.
3588
3589 * unexw32.c (open_output_file): Delete the existing emacs.exe
3590 before creating it, to break the hard link to the versioned
3591 executable.
3592
3593 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3594 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3595 (FIRSTFILE_OBJ): New variables.
3596 (W32_RES): Rename to EMACSRES. All users changed.
3597 (base_obj): Use $(CM_OBJ).
3598 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3599 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3600 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3601 $(W32_RES_LINK) before $(LIBES).
3602 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3603
1aa8d505
SM
36042013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3605
6e911150
SM
3606 * makefile.w32-in (DOC): Use just "DOC".
3607
3608 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3609
1aa8d505
SM
3610 * process.c: Export default filters and sentinels to Elisp.
3611 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3612 New constants.
3613 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3614 (Fset_process_sentinel, Fformat_network_address):
3615 Default to them instead of nil.
3616 (server_accept_connection): Sentinels can't be nil any more.
3617 (read_and_dispose_of_process_output): New function, extracted from
3618 read_process_output.
3619 (read_process_output): Use it; filters can't be nil.
3620 (Finternal_default_process_filter): New function, extracted from
3621 read_process_output.
3622 (exec_sentinel_unwind): Remove function.
3623 (exec_sentinel): Don't zilch sentinel while running.
3624 (status_notify): Sentinels can't be nil.
3625 (Finternal_default_process_sentinel): New function extracted from
3626 status_notify.
3627 (setup_process_coding_systems): Default filter is not nil any more.
3628 (syms_of_process): Export new Elisp functions and initialize
3629 new constants.
3630 * lisp.h (make_lisp_proc): New function.
3631
5ac2eb34
SM
36322013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3633
3634 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3635
eda9c7d7
EZ
36362013-05-14 Eli Zaretskii <eliz@gnu.org>
3637
3638 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3639 unless we know that the window w is a leaf window.
3640 Another attempt at solving bug#14062.
eda9c7d7 3641
8fdeaad5
JD
36422013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3643
3644 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3645 fdesc (Bug#14375).
3646
44aa9ee6
PE
36472013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3648
3649 * image.c (gif_load): Check that subimages fit (Bug#14345).
3650
759fd763
SM
36512013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3652
3653 * lread.c (skip_dyn_eof): New function.
3654 (read1): Use it to skip the end of a file in response to #@00.
3655
3656 * doc.c (get_doc_string): Slightly relax the sanity checking.
3657
4465bfb4
JD
36582013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3659
3660 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3661 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3662 (MonitorInfo): New struct.
3663 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3664 (Fns_display_monitor_attributes_list): New functions.
3665 (display-usable-bounds): Remove.
3666 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3667 Qsource.
3668
7583e2a0
PE
36692013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3672 (GTK_CHECK_VERSION): New macro, if not already defined.
3673 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3674 replaced by GTK_CHECK_VERSION.
3675
ad75d77e
PE
36762013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 * xterm.h (GTK_PREREQ): New macro.
3679 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3680 to use this macro instead, for consistency and clarity.
3681
07525f77
EZ
36822013-05-08 Eli Zaretskii <eliz@gnu.org>
3683
3684 * xdisp.c (row_for_charpos_p): New function, with code of
3685 cursor_row_p, but accepts an additional argument CHARPOS instead
3686 of using a hardcoded PT.
3687 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3688 (row_containing_pos): Call row_for_charpos_p instead of partially
3689 doing the same. Fixes cursor positioning under longlines-mode
3690 when longlines-show-effect includes more than one newline, when
3691 moving the cursor vertically up.
3692
d901fc8d
JB
36932013-05-08 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * makefile.w32-in (ACL_H): New macro.
3696 ($(BLD)/fileio.$(O)): Update dependencies.
3697
f269bc61
PE
36982013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3699
e7b41c4c 3700 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3701 * Makefile.in (LIB_ACL): New macro.
3702 (LIBACL_LIBS): Remove.
3703 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3704 * fileio.c: Include <acl.h>.
3705 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3706 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3707 !acl_errno_valid.
3708 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3709 it ourselves.
3710
f269bc61
PE
3711 * unexelf.c: Don't assume ElfW (Half) fits in int.
3712 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3713 when dealing with ElfW (Half) values, since they can exceed 2**31
3714 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3715 (entry_address): Omit unused NUM arg. All uses changed.
3716
a261c53e
JL
37172013-05-07 Juri Linkov <juri@jurta.org>
3718
3719 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3720 to the string converted from number with `Fnumber_to_string'.
3721 (Bug#14254)
3722
2b66427d
PE
37232013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3724
3725 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3726 This fixes a problem introduced by my previous change.
3727
15acfe41
GM
37282013-05-07 Glenn Morris <rgm@gnu.org>
3729
3730 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3731
5ea03bf5
JD
37322013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3733
3734 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3735
e0c9d565
PE
37362013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3737
3738 Static checking by GCC 4.8.0.
3739 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3740 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3741 (x_get_monitor_attributes_fallback)
3742 (x_get_monitor_attributes_xinerama)
3743 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3744 Define only if USE_GTK.
3745 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3746 (x_get_monitor_attributes_fallback): Omit unused locals.
3747 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3748 Use double, not float, to avoid mixed-mode floating point arithmetic.
3749
4e3f9230
YM
37502013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3751 Jan Djärv <jan.h.d@swipnet.se>
3752
3753 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3754 (XINERAMA_CFLAGS): New macros.
3755 (ALL_CFLAGS, LIBES): Use them.
3756
3757 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3758 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3759 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3760 (syms_of_xfns): DEFSYM them.
3761 (struct MonitorInfo): New struct.
3762 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3763 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3764 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3765 (x_get_monitor_attributes_xinerama): New functions.
3766 (Fx_display_monitor_attributes_list): New primitive.
3767 (syms_of_xfns): Defsubr it.
3768
3769 * xterm.h (x_display_info): Add Xatom_net_workarea and
3770 Xatom_net_current_desktop.
3771
3772 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3773 and dpyinfo->Xatom_net_current_desktop.
3774
05839b6a
EZ
37752013-05-06 Eli Zaretskii <eliz@gnu.org>
3776
3777 * xdisp.c (pos_visible_p): Use the special code for finding the
3778 beginning of a display property or overlay for any "replacing"
3779 display property, not just for display strings. This solves
3780 incorrect reporting of position by posn-at-point. (Bug#14241)
3781
dc4a2ee0
PE
37822013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3783
5ee94506
PE
3784 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3785 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3786 Verify that ElfW (Half) fits in int.
3787 (fatal): Use same signature as lisp.h.
3788 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3789 configure and build with -DUNEXELF_DEBUG without worrying about
3790 other modules that use DEBUG.
3791 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3792 possibly-wide integers now uses it instead of plain fprintf.
3793 (entry_address): New function, which avoids problems with 32-bit
3794 overflow on 64-bit hosts.
3795 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3796 (round_up): Don't assume the remainder fits in int.
3797 (find_section): Use bool for boolean. Simplify debug code.
3798 (unexec): Don't assume file sizes fit in int or size_t.
3799 Omit unnecessary trailing newline in 'fatal' format.
3800 Use strerror rather than outputting decimal error number.
3801 Remove unused code when emacs is not defined;
3802 this file relies on Emacs now.
3803 Don't assume e_phnum and e_shnum are positive.
3804
dc4a2ee0
PE
3805 * regex.c: Fix problems when DEBUG is defined.
3806 (extract_number, extract_number_and_incr): Define regardless of
3807 whether DEBUG is defined; that's simpler and makes the code less
3808 likely to go stale in the normal case when DEBUG is not defined.
3809 Return int rather than taking an int * arg. All callers changed.
3810 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3811 Remove, replacing with ...
3812 (DEBUG_PRINT): New macro. All callers changed.
3813 (DEBUG_COMPILES_ARGUMENTS): New macro.
3814 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3815 (print_compiled_pattern, print_double_string) [DEBUG]:
3816 Use prototype rather than old-style definition.
3817 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3818 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3819 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3820 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3821 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3822 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3823 This matters only when DEBUG is defined.
3824
14c7ed05
EZ
38252013-05-05 Eli Zaretskii <eliz@gnu.org>
3826
3827 * xdisp.c (set_iterator_to_next): Set the
3828 ignore_overlay_strings_at_pos_p flag only if we are _really_
3829 iterating over an overlay string, as indicated by the
3830 current.overlay_string_index member. (Bug#14306)
3831
e6076b1b
JD
38322013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3833
3834 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3835 to where it is used, to avoid autorelease issues (Bug#14050).
3836
cbee2131
PE
38372013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3838
3839 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3840 * fileio.c (syms_of_fileio): Implement this.
3841 * filelock.c (create_lock_file): If symbolic links don't work, so
3842 we use a regular file as a lock file, do not fsync the lock file;
3843 it's not needed.
3844
30c7e542
SM
38452013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3846
3847 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3848 (syms_of_minibuf): Adjust accodingly.
3849 * lread.c (Fread):
3850 * callint.c (Fcall_interactively): Adjust calls accordingly.
3851
5bebd186
EZ
38522013-05-04 Eli Zaretskii <eliz@gnu.org>
3853
3854 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3855 w->contents is a buffer before computing everything else.
3856 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3857
3858 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3859 assertion violations. (Bug#14062)
3860
0fb0a4f3
DR
38612013-05-01 David Reitter <david.reitter@gmail.com>
3862
3863 * nsfns.m (ns_tooltip): Initialize.
3864
9e63b4a5
EZ
38652013-04-28 Eli Zaretskii <eliz@gnu.org>
3866
3867 * coding.c (decode_coding_gap): Don't remove the character before
3868 a newline unless it's a CR character. (Bug#14287)
3869
ad60824e
DN
38702013-04-28 Dan Nicolaescu <dann@gnu.org>
3871
3872 * dispextern.h (struct face): Move enum face_underline_type
3873 earlier so that bitfields can be in the same word.
3874
edbdcec0
JD
38752013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3876
3877 * nsfns.m (handlePanelKeys): New function.
3878 (EmacsOpenPanel:performKeyEquivalent:)
3879 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3880 arrows/function/control and copy/paste keys (Bug#14296).
3881
0208ede7
JL
38822013-04-27 Juri Linkov <juri@jurta.org>
3883
3884 * callint.c (Fcall_interactively): Call `Qread_number' for
3885 interactive code letter `n' instead of using duplicate code.
3886 (Bug#14254)
3887
b8dd59f7
PE
38882013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3889
3890 * systime.h (make_timeval): Declare as 'const'.
3891
8bd722db
KH
38922013-04-27 Kenichi Handa <handa@gnu.org>
3893
3894 * font.c (font_open_entity): Always open a font of manageable
3895 size.
3896
13d0e56f 38972013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3898
f780d632
PE
3899 Port better to AIX (Bug#14258).
3900 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3901 to pacify AIX xlc.
3902
ec509856
KH
39032013-04-24 Kenichi Handa <handa@gnu.org>
3904
3905 * coding.c (decode_coding_iso_2022): When an invalid escape
3906 sequence is encountered, reset the invocation and designation
3907 status to the safest one.
3908
84fc48e5
PE
39092013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3912 Without this fix, "make distclean" leaves stamp-h1 behind.
3913
806bda47
EC
39142013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3915
3916 * w32fns.c (w32_fullscreen_rect): New function to compute the
3917 window rectangle for the given fullscreen mode.
3918 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3919 longer tunes the window size. This keeps the window's edges flush
3920 with the screen and allows the taskbar to hide itself in fullboth.
3921
3922 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3923 window decorations and uses the entire screen.
3924
3925 * w32term.h (w32_fullscreen_rect) Add prototype.
3926 (struct w32_output): Replace normal_width, normal_height,
3927 normal_top, and normal_left members with a single normal_placement
3928 struct.
3929 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3930 Remove macros.
3931 (FRAME_NORMAL_PLACEMENT): New macro.
3932
9cc2810b
JB
39332013-04-16 Juanma Barranquero <lekktu@gmail.com>
3934
3935 * minibuf.c (Ftest_completion): Silence compiler warning.
3936
fd16b54c
EZ
39372013-04-15 Eli Zaretskii <eliz@gnu.org>
3938
3939 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3940 bug#14062.
fd16b54c
EZ
3941
3942 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3943 parentheses.
3944
3945 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3946 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3947 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3948 parentheses where appropriate.
3949
9e3379a0
PE
39502013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3951
3952 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3953
ddd6b685
EZ
39542013-04-14 Eli Zaretskii <eliz@gnu.org>
3955
3956 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3957 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3958 Mention in the doc string that setting these variables takes
3959 effect only after a call to set-window-buffer. (Bug#14200)
3960
29b79ba1
EZ
39612013-04-13 Eli Zaretskii <eliz@gnu.org>
3962
3963 * indent.c (Fvertical_motion): Don't consider display strings on
3964 overlay strings as display strings on the buffer position we
3965 started from. This prevents vertical cursor motion from jumping
3966 more than one line when there's an overlay string with a display
3967 property at end of line.
3968 Reported by Karl Chen <Karl.Chen@quarl.org> in
3969 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3970
562c6ee9
SM
39712013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3972
3973 * window.c (select_window): `record_buffer' even if window is
3974 already selected (bug#14191).
3975
fcc1fe85
EZ
39762013-04-11 Eli Zaretskii <eliz@gnu.org>
3977
3978 * window.c (Fwindow_end): Test more flags, including the buffer's
3979 last_overlay_modified flag, to determine whether the window's
3980 display is really up-to-date. Prevents the function from
3981 returning a stale value. (Bug#14170)
3982 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3983 current matrix.
3984
f009190a
EZ
39852013-04-10 Eli Zaretskii <eliz@gnu.org>
3986
3987 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3988 garbaged only if it is not already the top frame on its TTY.
3989 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3990 there are GUI frames open in the same session. (Bug#13864)
3991
78ce603d
SM
39922013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3993
3994 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3995 of marking the idle timers directly.
3996
a8036e40
SM
39972013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3998
3999 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4000 tables (bug#14054).
4001
7ffe7ef6
SM
40022013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4003
4004 * window.c (select_window): Don't record_buffer while the invariant is
4005 temporarily broken (bug#14161).
4006
4007 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4008
7d9f6883
EZ
40092013-04-07 Eli Zaretskii <eliz@gnu.org>
4010
4011 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4012
5406cfd9
RF
40132013-04-07 Romain Francoise <romain@orebokech.com>
4014
4015 Ignore additional platform-specific ACL errors (Bug#13702).
4016 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4017 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4018
95c0e83b
JD
40192013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4020
4021 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4022 f->output_data.ns.
4023
876da980
PE
40242013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4027 This bug was introduced by my 2013-02-25 change that simplified
4028 data_start configuration. Without this change, on GNU/Linux
4029 an Emacs configured with --enable-profiling fails immediately
4030 due to a profiler signal.
4031 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4032 with these flags. On platforms where special flags are needed
4033 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4034 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4035 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4036
7452b7bd
DA
40372013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4038
4039 Get rid of some platform-specific functions examining window
4040 system and its capabilities. This is a partial rework of the
4041 2013-04-05 change.
4042 * lisp.h (have_menus_p): Remove prototype. This function is
4043 replaced with platform-independent window_system_available.
4044 (check_window_system): Move to...
4045 * frame.h (decode_window_system_frame, window_system_available):
4046 ...here, add new prototypes.
4047 * frame.c (window_system_available, decode_window_system_frame):
4048 New functions.
4049 (check_window_system): Platform-independent now.
4050 * xterm.h (x_in_use): Remove declaration.
4051 (check_x_frame):
4052 * w32term.h (check_x_frame):
4053 * nsterm.h (check_x_frame): Remove prototypes. This function
4054 is replaced with platform-independent decode_window_system_frame.
4055 * msdos.c (have_menus_p): Remove.
4056 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4057 Remove platform-specific functions. Use check_window_system,
4058 decode_window_system_frame and check_ns_display_info where
4059 appropriate. Minor style and comment tweaks.
4060 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4061 (check_x_frame): Likewise.
4062 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4063 Likewise.
4064 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4065 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4066 * xmenu.c, xselect.c: All related users changed.
4067
251e9147
KH
40682013-04-03 Kenichi Handa <handa@gnu.org>
4069
4070 The following changes is to optimize the code for reading UTF-8
4071 files.
4072
562c6ee9 4073 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4074 changed. Check EOL format. Do not call adjust_coding_eol_type
4075 here.
4076 (check_utf_8): New function.
4077 (adjust_coding_eol_type): Do nothing if already adjusted.
4078 (detect_coding): Compare the return value of check_ascii with
4079 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4080 (decode_coding_gap): Optimize for valid UTF-8.
4081
8bc369d4
KH
40822013-03-21 Kenichi Handa <handa@gnu.org>
4083
4084 * coding.c (syms_of_coding): Cancel previous change.
4085
4086 * insdel.c (insert_from_gap): Fix previous change.
4087
73931ad1
DA
40882013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4089
4090 Consistently use platform-specific function to detect window system.
4091 * lisp.h (check_window_system): New prototype. This function is
4092 going to replace check_x, check_w32 and check_ns.
4093 (have_menus_p): Mention msdos.c in comment.
4094 * fontset.c (check_window_system_func): Remove. Adjust all users.
4095 * fontset.h (check_window_system_func): Remove prototype.
4096 * nsterm.h (check_ns):
4097 * xterm.h (check_x):
4098 * w32term.h (check_w32): Likewise.
4099 * menu.c (Fx_popup_menu): Use check_window_system.
4100 * msdos.c (check_window_system): Define for MS-DOS.
4101 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4102 * w32fns.c (check_window_system): Likewise for MS-Windows.
4103 * xfns.c (check_window_system): Likewise for X.
4104 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4105 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4106
7216e43b
PE
41072013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4108
4109 Prefer < to > in range checks such as 0 <= i && i < N.
4110 This makes it easier to visualize quantities on a number line.
4111 This patch doesn't apply to all such range checks,
4112 only to the range checks affected by the 2013-03-24 change.
4113 This patch reverts most of the 2013-03-24 change.
4114 * alloc.c (xpalloc, Fgarbage_collect):
4115 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4116 * character.c (string_escape_byte8):
4117 * charset.c (read_hex):
4118 * data.c (cons_to_unsigned):
4119 * dispnew.c (update_frame_1):
4120 * doc.c (Fsubstitute_command_keys):
4121 * doprnt.c (doprnt):
4122 * editfns.c (hi_time, decode_time_components):
4123 * fileio.c (file_offset):
4124 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4125 * font.c (font_intern_prop):
4126 * frame.c (x_set_alpha):
4127 * gtkutil.c (get_utf8_string):
4128 * indent.c (check_display_width):
4129 * keymap.c (Fkey_description):
4130 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4131 * lread.c (read1):
4132 * minibuf.c (read_minibuf_noninteractive):
4133 * process.c (wait_reading_process_output):
4134 * search.c (Freplace_match):
4135 * window.c (get_phys_cursor_glyph):
4136 * xdisp.c (redisplay_internal):
4137 * xsmfns.c (smc_save_yourself_CB):
4138 Prefer < to > for range checks.
4139 * dispnew.c (sit_for): Don't mishandle NaNs.
4140 This fixes a bug introduced in the 2013-03-24 change.
4141 * editfns.c (decode_time_components): Don't hoist comparison.
4142 This fixes another bug introduced in the 2013-03-24 change.
4143
92759988
DA
41442013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4145
4146 * frame.h (struct frame): Drop scroll_bottom_vpos
4147 member becaue all real users are dead long ago.
4148 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4149 * xdisp.c (redisplay_internal): Adjust user.
4150
9a1971bb
GM
41512013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4152
f38ab167
JD
4153 * nsmenu.m (showAtX:Y:for:): setLevel to
4154 NSPopUpMenuWindowLevel (Bug#13998).
4155
6d01f1fe
JD
41562013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4157
4158 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4159 (ns_check_pending_open_menu): Declare.
4160
4161 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4162 (x_activate_menubar): Update the menu with title that matches
4163 ns_get_pending_menu_title, and call
4164 ns_check_pending_openmenu (Bug#12698).
4165 (menuWillOpen:): New method.
4166 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4167
4168 * nsterm.m (menu_will_open_state, menu_mouse_point)
4169 (menu_pending_title): New varaibles.
4170 (ns_get_pending_menu_title, ns_check_menu_open)
4171 (ns_check_pending_open_menu): New functions.
4172
781f4782
DA
41732013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4174
4175 * indent.c (current_column_bol_cache): Remove leftover which is not
4176 used in Fmove_to_column any more.
4177 (current_column, scan_for_column): Adjust users.
4178 * keyboard.c (last_point_position_buffer, last_point_position_window):
4179 Remove leftovers which are not used for recording undo any more.
4180 (command_loop_1, syms_of_keyboard): Adjust users.
4181 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4182 redisplay_window any more.
4183 (move_it_to): Adjust user.
4184
1921c31b
JB
41852013-03-29 Juanma Barranquero <lekktu@gmail.com>
4186
4187 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4188 Update dependencies.
4189
717b8bcd
SM
41902013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4191
4192 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4193 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4194 forward references.
4195
e74aeda8
DA
41962013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4197
4198 * window.h (struct window): Replace hchild, vchild and buffer slots
4199 with the only contents slot. This is possible because each valid
4200 window may have either the child window (in vertical or horizontal
4201 combination) or buffer to display (for the leaf window). Using that,
4202 a lof of operations to traverse and/or change window hierarchies may
4203 be simplified. New member horizontal is used to distinguish between
4204 horizontal and vertical combinations of internal windows.
4205 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4206 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4207 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4208 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4209 Use contents slot, not buffer, where appropriate.
4210 (wset_combination): New function.
4211 (wset_buffer): Add eassert.
4212 (Fframe_first_window): Simplify the loop reaching first window.
4213 (Fwindow_buffer): Use WINDOW_LEAF_P.
4214 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4215 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4216 (unshow_buffer): Convert initial debugging check to eassert.
4217 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4218 (make_parent_window, window_resize_check, window_resize_apply)
4219 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4220 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4221 Adjust to match struct window changes.
4222 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4223 (mark_window_cursors_off, count_windows, get_leaf_windows)
4224 (foreach_window_1): Simplify the loop.
4225 * alloc.c (mark_object): Do not check for the leaf window because
4226 internal windows has no glyph matrices anyway.
4227 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4228 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4229 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4230 (build_frame_matrix_from_window_tree, mirror_make_current)
4231 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4232 (update_window_tree, set_window_update_flags): Simplify the loop.
4233 (sync_window_with_frame_matrix_rows): Enforce live window.
4234 Use contents slot, not buffer, where appropriate.
4235 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4236 and WINDOW_HORIZONTAL_COMBINATION_P.
4237 (make_frame_visible_1): Simplify the loop.
4238 Use contents slot, not buffer, where appropriate.
4239 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4240 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4241 (expose_window_tree): Likewise.
4242 Use contents slot, not buffer, where appropriate.
4243 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4244 to avoid deleted windows. Use contents slot instead of buffer.
4245 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4246 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4247 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4248 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4249
121ab1cd
EZ
42502013-03-28 Eli Zaretskii <eliz@gnu.org>
4251
ef454cf7
EZ
4252 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4253 identify the reasons for assertion violations in bug#14062 and
4254 similar ones.
21e930f8
EZ
4255 (Fx_show_tip): Fix compilation error under
4256 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4257
121ab1cd
EZ
4258 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4259 Reported by <rzl24ozi@gmail.com>.
4260
5c89ca24
DA
42612013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4262
4263 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4264 start marker...
562c6ee9
SM
4265 (unwind_with_echo_area_buffer): ...to restore it here.
4266 This is needed to ensure that...
5c89ca24
DA
4267 (redisplay_window): ...both window markers are valid here,
4268 which is verified by eassert.
4269 * editfns.c (save_excursion_save): Do not assume that
4270 selected_window always displays the buffer.
c7f53895
DA
4271 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4272 Fix comment.
5c89ca24 4273
f557c1b1
SM
42742013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4275
4276 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4277 the upcase table.
4278
40693bba 42792013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4280
4281 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4282
c86f791f
EZ
42832013-03-27 Eli Zaretskii <eliz@gnu.org>
4284
4285 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4286 since MinGW's w32api headers do. This avoids compiler warnings.
4287
4288 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4289 if already defined.
4290
c6e72e17
EZ
42912013-03-26 Eli Zaretskii <eliz@gnu.org>
4292
4293 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4294
54e95010
JD
42952013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4296
4297 * gtkutil.c (style_changed_cb): Check if frame is live and an
4298 X frame (Bug#14038).
4299
b88b62de
EZ
43002013-03-26 Eli Zaretskii <eliz@gnu.org>
4301
a18d7de6
EZ
4302 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4303 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4304 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4305 MinGW64.
8f5e14c8
EZ
4306 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4307 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4308
b88b62de
EZ
4309 Fix incompatibilities between MinGW.org and MinGW64 headers.
4310 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4311
4312 * w32.c (REPARSE_DATA_BUFFER): Guard with
4313 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4314
c074e458
JD
43152013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4316
4317 * xterm.c: Include X11/XKBlib.h
4318 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4319
908589fd
AS
43202013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4321
4322 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4323 written backwards.
4324 * blockinput.h (input_blocked_p): Likewise.
4325 * bytecode.c (exec_byte_code): Likewise.
4326 * callproc.c (call_process_kill, call_process_cleanup)
4327 (Fcall_process): Likewise.
4328 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4329 (Fccl_execute_on_string): Likewise.
4330 * character.c (string_escape_byte8): Likewise.
4331 * charset.c (read_hex): Likewise.
4332 * cm.c (calccost): Likewise.
4333 * data.c (cons_to_unsigned): Likewise.
4334 * dired.c (directory_files_internal, file_name_completion):
4335 Likewise.
4336 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4337 (sit_for): Likewise.
4338 * doc.c (Fsubstitute_command_keys): Likewise.
4339 * doprnt.c (doprnt): Likewise.
4340 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4341 * emacsgtkfixed.c: Likewise.
4342 * fileio.c (file_offset, Fwrite_region): Likewise.
4343 * floatfns.c (Fexpt, fmod_float): Likewise.
4344 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4345 Likewise.
4346 * font.c (font_intern_prop): Likewise.
4347 * frame.c (x_set_alpha): Likewise.
4348 * gtkutil.c (get_utf8_string): Likewise.
4349 * indent.c (check_display_width): Likewise.
4350 * intervals.c (create_root_interval, rotate_right, rotate_left)
4351 (split_interval_right, split_interval_left)
4352 (adjust_intervals_for_insertion, delete_node)
4353 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4354 (merge_interval_right, merge_interval_left, copy_intervals)
4355 (set_intervals_multibyte_1): Likewise.
4356 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4357 * keymap.c (Fkey_description): Likewise.
4358 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4359 * lread.c (openp, read_integer, read1, string_to_number):
4360 Likewise.
4361 * menu.c (ensure_menu_items): Likewise.
4362 * minibuf.c (read_minibuf_noninteractive): Likewise.
4363 * print.c (printchar, strout): Likewise.
4364 * process.c (create_process, Faccept_process_output)
4365 (wait_reading_process_output, read_process_output, send_process)
4366 (wait_reading_process_output): Likewise.
4367 * profiler.c (make_log, handle_profiler_signal): Likewise.
4368 * regex.c (re_exec): Likewise.
4369 * regex.h: Likewise.
4370 * search.c (looking_at_1, Freplace_match): Likewise.
4371 * sysdep.c (get_child_status, procfs_ttyname)
4372 (procfs_get_total_memory): Likewise.
4373 * systime.h (EMACS_TIME_VALID_P): Likewise.
4374 * term.c (dissociate_if_controlling_tty): Likewise.
4375 * window.c (get_phys_cursor_glyph): Likewise.
4376 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4377 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4378 Likewise.
4379 * xfns.c (Fx_window_property): Likewise.
4380 * xmenu.c (set_frame_menubar): Likewise.
4381 * xselect.c (x_get_window_property, x_handle_dnd_message):
4382 Likewise.
4383 * xsmfns.c (smc_save_yourself_CB): Likewise.
4384 * xterm.c (x_scroll_bar_set_handle): Likewise.
4385
2bf7d27a
DA
43862013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4387
4388 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4389 to be optional or nil. Adjust comment and convert it to docstring.
4390 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4391 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4392
a9ebfa0b
PE
43932013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4394
4395 Static checking by GCC 4.8-20130319.
4396 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4397 * process.c (Fset_process_datagram_address)
4398 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4399 * xdisp.c (get_char_face_and_encoding):
4400 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4401 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4402 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4403
4f3576ee
KB
44042013-03-24 Ken Brown <kbrown@cornell.edu>
4405
789b5e9a
KB
4406 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4407 fix compilation on 64-bit Cygwin, where underscores are not
4408 automatically prepended.
4409
4f3576ee
KB
4410 * w32term.c (w32_initialize): Silence compiler warning.
4411
b5b7745f
EZ
44122013-03-23 Eli Zaretskii <eliz@gnu.org>
4413
cdc0d0bd
EZ
4414 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4415 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4416 variables, to save and restore frame dimensions.
4417 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4418 after returning from a 'fullscreen' configuration.
4419 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4420 to avoid races between the main thread and the input thread.
4421
4422 * w32term.h (struct w32_output): New members normal_width,
4423 normal_height, normal_top, normal_left, and prev_fsmode.
4424 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4425 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4426 members of a frame.
4427
b5b7745f
EZ
4428 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4429 'fullscreen' parameter. Always record previous width and height
4430 of the frame, except when switching out of maximized modes, so
4431 that they could be restored correctly, instead of resetting to the
4432 default frame dimensions. Send SC_RESTORE command to the frame,
4433 unless we are going to send SC_MAXIMIZE, to restore the frame
4434 resize hints in the mouse pointer shown by the window manager.
4435 (Bug#14032)
4436
4437 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4438
4439 * lisp.h (get_frame_param): Adjust conditions for prototype
4440 declaration.
4441
a3454eed
KB
44422013-03-22 Ken Brown <kbrown@cornell.edu>
4443
4444 * unexcw.c: Drop unneeded inclusion of w32common.h.
4445 (report_sheap_usage): Declare.
4446 (read_exe_header): Add magic numbers for x86_64.
4447 (fixup_executable): Fix printf format specifier for unsigned long
4448 argument.
4449
5a49b79c
DA
44502013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4451
4452 * frame.h (struct frame): Put menu_bar_window under #ifdef
4453 because this member is not needed when X toolkit is in use.
4454 (fset_menu_bar_window):
4455 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4456 (free_glyphs, update_frame):
4457 * xdisp.c (expose_frame): Likewise.
4458 (display_menu_bar): Likewise. Remove redundant eassert.
4459 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4460 toolkit is in use.
4461
d6723bf7
PE
44622013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4463
7b1123d8
PE
4464 Use functions and constants to manipulate Lisp_Save_Value objects.
4465 This replaces code that used macros and strings and token-pasting.
4466 The change makes the C source a bit easier to follow,
4467 and shrinks the Emacs executable a bit.
4468 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4469 (make_save_value): Change 1st arg from string to enum. All callers
4470 changed.
4471 (INTX): Remove.
4472 (mark_object): Use if, not #if, for GC_MARK_STACK.
4473 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4474 (XSAVE_OBJECT): Now functions, not macros.
4475 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4476 the constant was never used.
4477 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4478 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4479 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4480 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4481 New constants.
4482 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4483 type3 with a single member save_type. All uses changed.
4484 (save_type, set_save_pointer, set_save_integer): New functions.
4485 * print.c (PRINTX): Remove.
4486
d6723bf7
PE
4487 * alloc.c: Remove redundant static declarations.
4488
5f24fa51
DA
44892013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4490
4491 * window.h (struct window): Convert left_col, top_line, total_lines
4492 and total_cols from Lisp_Objects to integers. Adjust comments.
4493 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4494 Remove.
4495 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4496 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4497 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4498 Adjust users where appropriate.
4499
42143acd
DA
45002013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4501
4502 * frame.h (struct frame): Drop resx and resy because the same data is
4503 available from window system-specific output context. Adjust users.
562c6ee9
SM
4504 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4505 New functions to provide defaults when no window system available.
42143acd 4506 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4507 (NUMVAL): Move from xdisp.c.
42143acd
DA
4508 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4509 (Ffont_face_attributes, Fopen_font):
4510 * image.c (gs_load):
4511 * w32font.c (fill_in_logfont):
4512 * xdisp.c (calc_pixel_width_or_height):
4513 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4514 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4515
c0a17406
KH
45162013-03-20 Kenichi Handa <handa@gnu.org>
4517
4518 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4519 to 1 (temporary workaround until a bug related to ASCII
4520 optimization is fixed).
4521
095d384d
DA
45222013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4523
4524 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4525 Signal error if window is not internal. Adjust docstring.
4526 (delete_all_child_windows): Use combination_limit to save the buffer.
4527 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4528 * print.c (syms_of_print): Initialize debugging output not here...
4529 (init_print_once): ...but in a new function here.
4530 * lisp.h (init_print_once): Add prototype.
4531 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4532
748fa866
DA
45332013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4534
4535 * window.c (window_resize_check, window_resize_apply)
4536 (window_from_coordinates, recombine_windows, set_window_buffer)
4537 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4538 (Fsplit_window_internal, Fdelete_window_internal)
4539 (freeze_window_starts): Use bool for booleans.
4540 * window.h (window_frame_coordinates, resize_frame_windows)
4541 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4542
81519fd2
SM
45432013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4544
4545 * dispnew.c (bitch_at_user): Use `user-error'.
4546
6db423a9
KB
45472013-03-17 Ken Brown <kbrown@cornell.edu>
4548
4549 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4550 as return type of image_background. (Bug#13981)
4551 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4552
8f2906f5
JD
45532013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4554
960ce480 4555 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4556 (ns_select): Don't return with result uninitialized.
960ce480 4557
8f2906f5
JD
4558 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4559 and getDirectory.
4560
81519fd2
SM
4561 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4562 New functions.
8f2906f5
JD
4563 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4564 directories. If filename is nil, get directory name (Bug#13932).
4565 Use getFilename and getDirectory.
4566 (getFilename, getDirectory): New methods for EmacsSavePanel and
4567 EmacsOpenPanel.
4568 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4569
cded56c1
PE
45702013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4571
4572 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4573
251e9147 45742013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4575
4576 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4577 (adjust_after_replace): Make it back to static. Delete the third
4578 arg text_at_gap_tail. Cancel the code for handling it.
4579
4580 * coding.h (struct coding_system): New member eol_seen.
4581
4582 * coding.c (detect_ascii): New function.
4583 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4584 when the source bytes are actually scanned. On detecting for
4585 coding_category_utf_8_auto, call detect_ascii instead of scanning
4586 source bytes directly.
4587 (produce_chars): Call insert_from_gap with the new arg 0.
4588 (encode_coding): Likewise.
4589 (decode_coding_gap): Control ASCII optimization by the variable
4590 disable_ascii_optimization instead of #ifndef .. #endif.
4591 Deccode EOL format according to coding->eol_seen.
4592 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4593 variable.
4594
8a44e6d1
KH
4595 * lisp.h (adjust_after_replace): Cancel externing it.
4596 (insert_from_gap): Adjust prototype.
4597
5f795e34
EZ
45982013-03-15 Eli Zaretskii <eliz@gnu.org>
4599
4600 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4601 FULLSCREEN_MAXIMIZED. (Bug#13935)
4602
f258b4be
DA
46032013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4604
4605 * region-cache.c (find_cache_boundary, move_cache_gap)
4606 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4607 Simplify debugging check and convert to eassert. Adjust comment.
4608 (pp_cache): Put under ENABLE_CHECKING.
4609
a5cc4dde
EZ
46102013-03-14 Eli Zaretskii <eliz@gnu.org>
4611
4612 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4613 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4614 and WM_ACTIVATEAPP.
4615 (w32fullscreen_hook): If the frame is visible, reset
4616 f->want_fullscreen flag after changing the frame size. If the
4617 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4618 (Bug#13953)
4619
3fc5e44a
DC
46202013-03-13 Daniel Colascione <dancol@dancol.org>
4621
4622 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4623 too so that these builds can use Cygwin's file conversion
4624 functions. (We've been building and linking cygw32.o all along
4625 and just not using it.)
4626
47d7532e
PE
46272013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4628
4629 File synchronization fixes (Bug#13944).
4630 * Makefile.in (LIB_FDATASYNC): New macro.
4631 (LIBES): Use it.
4632 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4633 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4634 Don't worry about HAVE_FSYNC, since a substitute fsync is
4635 available if the system lacks one.
4636 (Fwrite_regin): Retry fsync if interrupted.
4637
c7ffccaf
EZ
46382013-03-13 Eli Zaretskii <eliz@gnu.org>
4639
4e2df81d 4640 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4641 activated, call w32fullscreen_hook, to make sure the new frame
4642 dimensions are in effect. (Bug#13937)
4643
8a7debc1
DA
46442013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4645
4646 * xdisp.c (init_iterator): Simplify because both character and byte
4647 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4648 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4649 character and byte positions can be obtained from marker.
8a7debc1 4650
7fd8c501
PE
46512013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4652
d9df6f40
PE
4653 Static checking by Sun C 5.12.
4654 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4655 * bytecode.c (exec_byte_code):
4656 * dispnew.c (init_display):
4657 * eval.c (error):
4658 * fileio.c (Fsubstitute_in_file_name):
4659 * keyboard.c (Fevent_convert_list):
4660 * keymap.c (Fsingle_key_description):
4661 * term.c (maybe_fatal, fatal):
4662 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4663 * xsmfns.c (Fhandle_save_session):
4664 Omit unreachable code.
4665 * keymap.c (map_keymap_char_table_item): Cast void * to
4666 a function pointer type; the C Standard requires this.
4667
7fd8c501
PE
4668 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4669 Include <sys/param.h> unconditionally, as that works elsewhere and
4670 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4671 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4672 and FreeBSD now.
4673
a020afb9 4674See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4675
4676;; Local Variables:
4677;; coding: utf-8
aac0c6e3
MR
4678;; End:
4679
ab422c4d 4680 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4681
4682 This file is part of GNU Emacs.
4683
4684 GNU Emacs is free software: you can redistribute it and/or modify
4685 it under the terms of the GNU General Public License as published by
4686 the Free Software Foundation, either version 3 of the License, or
4687 (at your option) any later version.
4688
4689 GNU Emacs is distributed in the hope that it will be useful,
4690 but WITHOUT ANY WARRANTY; without even the implied warranty of
4691 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4692 GNU General Public License for more details.
4693
4694 You should have received a copy of the GNU General Public License
4695 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.