* vc/vc.el (vc-diff-build-argument-list-internal): If the file is
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6bbe6da8
DA
12013-10-10 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * keyboard.c (last_event_timestamp): Remove. For X selection and
4 GTK popup menus, it may be obtained from per-frame X display info.
5 (kbd_buffer_store_event_hold, kbd_buffer_get_event)
6 (process_special_events): Adjust users.
7 * keyboard.h (last_event_timestamp): Remove declaration.
8 * xmenu.c (xmenu_show, create_and_show_popup_menu): Lost last arg.
9 Use FRAME_DISPLAY_INFO (f)->last_user_time for gtk_menu_popup.
10 * menu.h (xmenu_show): Adjust prototype.
11 * menu.c (Fx_popup_menu): Adjust user.
12 * xselect.c (x_own_selection, x_get_foreign_selection)
13 (Fx_disown_selection_internal): Use dpyinfo->last_user_time.
14
1afcba63
DA
152013-10-10 Dmitry Antipov <dmantipov@yandex.ru>
16
17 * keyboard.c (init_kboard): Now static. Add arg
18 to denote window system. Adjust comment.
19 (init_keyboard): Adjust user.
20 (allocate_kboard): New function.
21 (syms_of_keyboard):
22 * nsterm.m (ns_term_init):
23 * term.c (init_tty):
24 * w32term.c (w32_create_terminal):
25 * xterm.c (x_term_init): Use it.
26 * keyboard.h (init_kboard): Remove prototype.
27 (allocate_kboard): Add prototype.
28
f3606ef7
BF
292013-10-10 Barry Fishman <barry_fishman@acm.org> (tiny change)
30
31 * image.c (GIFLIB_MAJOR): Ensure it's defined.
32 (DGifOpen, DGifOpenFileName): Handle giflib 5 syntax. (Bug#15531)
33
e20bb249
PE
342013-10-09 Paul Eggert <eggert@cs.ucla.edu>
35
36 * fns.c (sxhash_bool_vector): Fix buffer read overrun.
37
9f6a18d2
EZ
382013-10-09 Eli Zaretskii <eliz@gnu.org>
39
40 * term.c (tty_menu_activate): Flush the output stream after
41 showing the cursor, and don't mark the frame garbaged at exit from
42 the function. Fixes redisplay glitches when moving from one menu
43 to another.
44
0486beac
JD
452013-10-09 Jan Djärv <jan.h.d@swipnet.se>
46
47 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Check input for valid UTF-8
48 or throw error (Bug#15570).
49
0d5d3029
PE
502013-10-09 Paul Eggert <eggert@cs.ucla.edu>
51
ab7ce978
PE
52 * intervals.c (temp_set_point_both): Move test into 'eassert',
53 for speed.
54
0d5d3029
PE
55 * lisp.h (eassert): Don't use 'assume'.
56 Sometimes 'assume' wins in performance, and sometimes it loses,
57 so it shouldn't be used all the time. Perhaps we need two
58 flavors of 'eassert', one for where 'assume' is far more likely
59 to help or to hurt; but that can be done later.
1afcba63 60 Problem reported by Dmitry Antipov in
0d5d3029
PE
61 <http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00276.html>.
62 Also, don't include <verify.h>; no longer needed.
63
fa022909
GM
642013-10-09 Glenn Morris <rgm@gnu.org>
65
66 * eval.c (Fcond): Doc tweak.
67
051277bf
EZ
682013-10-09 Eli Zaretskii <eliz@gnu.org>
69
70 * xfaces.c (x_free_gc) [HAVE_X_WINDOWS, HAVE_NTGUI]: Don't pass
71 expressions with side effects to eassert. (Bug#15565)
72
79804536
SM
732013-10-09 Stefan Monnier <monnier@iro.umontreal.ca>
74
75 * fns.c (hashfn_user_defined): Allow hash functions to return any
76 Lisp_Object.
77
3b158d11
PE
782013-10-08 Paul Eggert <eggert@cs.ucla.edu>
79
80 Fix minor problems found by static checking.
81 * dispnew.c (save_current_matrix): Omit unnecessary casts.
82 * dispnew.c (update_frame_with_menu): Mark debug local as used.
83 * keyboard.c, keyboard.h (Qmouse_movement): Now static.
84 * keyboard.c (read_menu_command): Remove unused local.
85 * lisp.h (read_menu_command): New decl.
86 * menu.c, menu.h (menu_item_width): Arg is now unsigned char *, for
87 benefit of STRING_CHAR_AND_LENGTH. All uses changed.
88 Return ptrdiff_t, not int.
89 * term.c (tty_menu_struct): 'allocated' member is now ptrdiff_t,
90 not int, for benefit of xpalloc.
91 (tty_menu_create, tty_menu_make_room): Simplify by using xzalloc
92 and xpalloc.
93 (have_menus_p): Remove; unused.
94 (tty_menu_add_pane, tty_menu_add_selection): Change signedness of
95 local char * pointer to pacify STRING_CHAR_AND_LENGTH.
96 (tty_menu_add_selection, tty_menu_locate, tty_meny_destroy):
97 Now static.
98 (save_and_enable_current_matrix): Omit unnecessary casts.
99 (read_menu_input): Omit local extern decl (now in lisp.h).
100 Don't access uninitialized storage if mouse_get_xy fails.
101 (tty_menu_activate): Mark local as initialized, for lint.
102 (tty_menu_activate, tty_meny_show): Remove unused locals.
103
4ed77415
EZ
1042013-10-08 Eli Zaretskii <eliz@gnu.org>
105
106 Support menus on text-mode terminals.
107 * xterm.h (xw_popup_dialog): Add prototype.
108
109 * xmenu.c (Fx_popup_dialog): Function moved to menu.c.
110 (xmenu_show): Block input here, instead in Fx_popup_menu.
111 (xw_popup_dialog): New function, with X-specific bits of popup
112 dialogs.
113
114 * xdisp.c (deep_copy_glyph_row, display_tty_menu_item): New
115 functions.
116
117 * window.c (Fset_window_configuration): Use run-time tests of the
118 frame type instead of compile-time conditionals, when menu-bar
119 lines are considered.
120
121 * w32term.h (w32con_hide_cursor, w32con_show_cursor)
122 (w32_popup_dialog): New prototypes.
123
124 * w32menu.c (Fx_popup_dialog): Function deleted.
125 (w32_popup_dialog): New function, with w32 specific bits of popup
126 dialogs. Block input here.
127
128 * w32inevt.c (w32_console_read_socket): Minor change to add
129 debugging TTY events.
130
131 * w32fns.c (show_hourglass): If returning early because the frame
132 is not a GUI frame, unblock input.
133
134 * w32console.c (w32con_hide_cursor, w32con_show_cursor, cursorX)
135 (cursorY): New functions.
136
137 * termhooks.h (cursorX, cursorY): Prototypes of functions on
138 WINDOWSNT, macros that call curX and curY elsewhere.
139
140 * termchar.h (struct tty_display_info) <showing_menu>: New flag.
141
142 * term.c (tty_hide_cursor, tty_show_cursor) [WINDOWSNT]: Call w32
143 specific function to hide and show cursor on a text-mode terminal.
144 (tty_menu_struct, struct tty_menu_state): New structures.
145 (tty_menu_create, tty_menu_make_room, tty_menu_search_pane)
146 (tty_menu_calc_size, mouse_get_xy, tty_menu_display)
147 (have_menus_p, tty_menu_add_pane, tty_menu_add_selection)
148 (tty_menu_locate, save_and_enable_current_matrix)
149 (restore_desired_matrix, screen_update, read_menu_input)
150 (tty_menu_activate, tty_menu_destroy, tty_menu_help_callback)
151 (tty_pop_down_menu, tty_menu_last_menubar_item)
152 (tty_menu_new_item_coords, tty_menu_show): New functions.
153 (syms_of_term): New DEFSYMs for tty-menu-* symbols.
154
155 * nsterm.h (ns_popup_dialog): Adjust prototype.
156
157 * nsmenu.m (ns_menu_show): Block and unblock input here, instead
158 of in x-popup-menu.
159 (ns_popup_dialog): Adapt order of arguments to the other
160 *_menu_show implementations.
161 (Fx_popup_dialog): Function deleted.
162
163 * msdos.c (x_set_menu_bar_lines): Delete unused function.
164
165 * menu.h (tty_menu_show, menu_item_width): provide prototypes.
166
167 * menu.c (have_boxes): New function.
168 (single_keymap_panes): Use it instead of a compile-time
169 conditional.
170 (single_menu_item): Use run-time tests of the frame type instead
171 of compile-time conditionals.
172 (encode_menu_string): New function.
173 (list_of_items, list_of_panes): Use it instead of ENCODE_STRING
174 the macro, since different types of frame need different encoding
175 of menu items.
176 (digest_single_submenu): Use run-time tests of frame type instead
177 of, or in addition to, compile-time conditionals.
178 (menu_item_width, Fmenu_bar_menu_at_x_y): New functions.
179 (Fx_popup_menu): Detect when the function is called from keyboard
180 on a TTY. Don't barf when invoked on a text-mode frame. Check
181 frame type at run time, instead of compile-time conditionals for
182 invoking terminal-specific menu-show functions. Call
183 tty_menu_show on text-mode frames.
184 (Fx_popup_dialog): Moved here from xmenu.c. Test frame types at
185 run time to determine which alternative to invoke; support dialogs
186 on TTYs.
187
188 * keyboard.h <Qmouse_movement>: Declare.
189
190 * keyboard.c <Qmouse_movement>: Now extern.
191 <Qecho_keystrokes>: New static variable.
192 (read_key_sequence): Accept an additional argument, a flag to
193 prevent redisplay during reading of the key sequence. All callers
194 changed.
195 (read_menu_command): New function.
196 (read_char): When COMMANDFLAG is -2, do not redisplay and do not
197 autosave.
198 (toolkit_menubar_in_use): New function.
199 (make_lispy_event): Use it instead of a compile-time test.
200
201 * fns.c (Fyes_or_no_p) [HAVE_MENUS]: Don't condition on
202 window-system being available.
203
204 * editfns.c (Fmessage_box) [HAVE_MENUS]: Don't condition the call
205 to x-popup-dialog on the frame type, they all now support popup
206 dialogs.
207
208 * dispnew.c (save_current_matrix): Save the margin areas.
209 (restore_current_matrix): Restore margin areas.
210 (update_frame_with_menu): New function.
211
212 * dispextern.h (display_tty_menu_item, update_frame_with_menu):
213 Add prototypes.
214
215 * alloc.c (make_save_ptr): Now compiled unconditionally.
216
ecab13d4
DA
2172013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
218
219 * dispnew.c (set_window_update_flags): Add buffer arg. Adjust comment.
220 (redraw_frame, update_frame): Adjust users.
221 * dispextern.h (set_window_update_flags): Adjust prototype.
222 * xdisp.c (redisplay_internal): When updating all frames with zero
223 windows_or_buffers_changed, assume that only the windows that shows
224 current buffer should be really updated.
225
f8498081
DA
2262013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
227
228 Do not allocate huge temporary memory areas and objects while encoding
229 for file I/O, thus reducing an enormous memory usage for large buffers.
230 See http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00180.html.
231 * coding.h (struct coding_system): New member raw_destination.
232 * coding.c (setup_coding_system): Initialize it to zero.
233 (encode_coding_object): If raw_destination is set, do not create
234 dst_object. Add comment.
235 * fileio.c (toplevel): New constant E_WRITE_MAX.
236 (e_write): Do not encode more than E_WRITE_MAX characters per one loop
237 iteration. Use raw_destination if E_WRITE_MAX characters is encoded.
238
d180bde8
JD
2392013-10-08 Jan Djärv <jan.h.d@swipnet.se>
240
241 * nsterm.m (windowDidExitFullScreen:):
242 (toggleFullScreen:): Change NS_IMPL_COCOA to HAVE_NATIVE_FS.
243
87c4314d
PE
2442013-10-08 Paul Eggert <eggert@cs.ucla.edu>
245
18978362
PE
246 Fix race where emacs aborts when sent SIGTERM (Bug#15534).
247 * keyboard.c (unblock_input_to): Don't process pending signals
248 if a fatal error is in progress.
249
87c4314d
PE
250 * lisp.h (bits_word, BITS_WORD_MAX): New type and macro.
251 All uses of 'size_t' and 'SIZE_MAX' changed to use them, when
252 they're talking about words in Lisp bool vectors.
253 (BITS_PER_BITS_WORD): Rename from BITS_PER_SIZE_T. All uses changed.
1142cc2a
PE
254 * data.c (popcount_bits_word): Rename from popcount_size_t.
255 (bits_word_to_host_endian): Rename from size_t_to_host_endian.
256 All uses changed.
87c4314d 257
595e113b
PE
2582013-10-07 Paul Eggert <eggert@cs.ucla.edu>
259
260 Improve support for popcount and counting trailing zeros (Bug#15550).
261 * data.c: Include <count-one-bits.h>, <count-trailing-zeros.h>.
262 (USE_MSC_POPCOUNT, POPCOUNT_STATIC_INLINE)
263 (NEED_GENERIC_POPCOUNT, popcount_size_t_generic)
264 (popcount_size_t_msc, popcount_size_t_gcc):
265 Remove; now done by Gnulib.
266 (popcount_size_t): Now a macro that defers to Gnulib.
267 (count_trailing_zero_bits): Return int, for consistency with
268 Gnulib and because Emacs prefers signed to unsigned int.
269 Don't assume that size_t is either unsigned int or unsigned long
270 or unsigned long long.
271 (size_t_to_host_endian): Do not assume that size_t is either
272 exactly 32 or exactly 64 bits wide.
273 * lisp.h (BITS_PER_SIZE_T): Define consistently with BITS_PER_LONG
274 etc., so that it's now an enum constant, not a macro.
275 No need to assume that it's either 32 or 64.
276
ddb317ba
JD
2772013-10-07 Jan Djärv <jan.h.d@swipnet.se>
278
279 * nsterm.m (windowDidEnterFullScreen:): setPresentationOptions only
280 on >= 10.7.
281
bd74250f
DA
2822013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
283
284 * insdel.c (insert_from_gap): Prefer ptrdiff_t to int where needed.
764636db 285 * xdisp.c (handle_fontified_prop): Likewise. Use bool for boolean.
bd74250f 286
223752d7
PE
2872013-10-07 Paul Eggert <eggert@cs.ucla.edu>
288
289 emacs_read and emacs_write now use void *, not char *.
290 * alloc.c (valid_pointer_p) [!WINDOWSNT]: Remove now-unnecessary cast.
291 * sysdep.c (emacs_read, emacs_write, emacs_write_sig):
292 Buffer arg is now void *, not char *. This matches plain
293 'read' and 'write' better, and avoids a constraint violation
294 on Solaris 9 with Oracle Studio.
295
3c439e0a
DA
2962013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
297
298 * alloc.c (Fmake_string): For ASCII char initializer, prefer
299 memset to explicit loop. Otherwise copy largest possible chunk
300 from initialized to uninitialized part, thus allowing the longer
301 memcpy runs and reducing the number of loop iterations.
302
28c76099
JD
3032013-10-06 Jan Djärv <jan.h.d@swipnet.se>
304
305 * nsterm.m (ns_update_begin): If native fullscreen and no toolbar,
306 hide toolbar (Bug#15388).
307 (windowDidEnterFullScreen:): If presentation options are zero,
308 set them here (Bug#15388).
a3e9050c
JD
309 (ns_update_auto_hide_menu_bar): Remove runtime check.
310 Don't auto hide dock unless menubar is also auto hidden.
28c76099 311
544a2a80
XF
3122013-10-05 Xue Fuqiao <xfq.free@gmail.com>
313
314 * editfns.c (message): Mention batch mode in doc string.
315
a27fd309
JD
3162013-10-05 Jan Djärv <jan.h.d@swipnet.se>
317
318 * nsterm.m (check_native_fs): Remove erroneous comment.
319
942f6f82
DA
3202013-10-04 Dmitry Antipov <dmantipov@yandex.ru>
321
322 * xdisp.c (redisplay_internal): Simplify because scan_for_column now
323 uses find_newline instead of scan_newline and so doesn't move point.
324
157fec2e
PE
3252013-10-04 Paul Eggert <eggert@cs.ucla.edu>
326
4eed3157
PE
327 Use hardware support for byteswapping on glibc x86 etc.
328 On Fedora 19 x86-64, the new bswap_64 needs 1 instruction,
329 whereas the old swap64 needed 30.
330 * fringe.c (init_fringe_bitmap) [WORDS_BIGENDIAN]:
331 * sound.c (le2hl, le2hs, be2hl) [!WINDOWSNT]:
332 Use byteswap.h's macros to swap bytes.
333 * lisp.h (swap16, swap32, swap64): Remove.
334 All uses replaced by bswap_16, bswap_32, bswap_64.
335
157fec2e
PE
336 * bytecode.c (exec_byte_code): Use some more volatile variables
337 to work around local variables getting clobbered by longjmp.
338 Port to pre-C99, which doesn't allow decls after stmts.
339
b52f569d
PE
3402013-10-03 Paul Eggert <eggert@cs.ucla.edu>
341
75273afb
PE
342 * lisp.h (eassert): Assume that COND is true when optimizing.
343 In other words, take on the behavior of eassert_and_assume.
344 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
345 (eassert_and_assume): Remove. All uses replaced by eassert.
346
ead45345
PE
347 * xdisp.c (Qglyphless_char): Now static.
348
0a858ebf
PE
349 Adjust to merge from gnulib.
350 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
351 * lisp.h: Include <verify.h>, for 'assume'.
352
b52f569d
PE
353 * eval.c (clobbered_eassert): New macro.
354 (internal_catch, internal_condition_case)
355 (internal_condition_case_1, internal_condition_case_2)
356 (internal_condition_case_n): Use it instead of eassert
357 when the argument contains locals clobbered by longjmp.
358 Don't use clobbered locals outside of clobbered_eassert.
359 (internal_lisp_condition_case): Use a volatile variable
360 to work around a local variable's getting clobbered.
361
adf2aa61
SM
3622013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
363
364 * lisp.h (struct handler): Merge struct handler and struct catchtag.
365 (PUSH_HANDLER): New macro.
366 (catchlist): Remove.
367 (handlerlist): Always declare.
368
369 * eval.c (catchlist): Remove (merge with handlerlist).
370 (handlerlist, lisp_eval_depth): Not static any more.
371 (internal_catch, internal_condition_case, internal_condition_case_1)
372 (internal_condition_case_2, internal_condition_case_n):
373 Use PUSH_HANDLER.
374 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
375 handlerlist/catchlist.
376 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
377 handlerlist which can only handle a single condition-case handler at
378 a time.
379 (find_handler_clause): Simplify since we only a single branch here
380 any more.
381
382 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
383 and Bpophandler.
384 (bcall0): New function.
385 (exec_byte_code): Add corresponding cases. Improve error message when
386 encountering an invalid byte-code. Let Bunwind_protect accept
387 a function (rather than a list of expressions) as argument.
388
389 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
390 and make them unconditional now that they're heap-allocated.
391
328a8179
SM
3922013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
393
394 * charset.c (Fdecode_char, Fencode_char): Remove description of
395 `restriction' arg. now that it's hidden by advertised-calling-convention.
396
c348360a
JD
3972013-10-02 Jan Djärv <jan.h.d@swipnet.se>
398
328a8179
SM
399 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
400 Remove unused variable (from mac-port).
c348360a
JD
401 (macfont_draw): Use s->ybase for correct y position.
402
1a23cd48
DA
4032013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
404
405 * frame.h (struct frame): Drop has_minibuffer member because...
406 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
407 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
408
29bf4de4
DA
4092013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
410
411 * window.h (struct window): Prefer enum text_cursor_kinds to int
412 for phys_cursor_type member. Move the latter, phys_cursor_width,
413 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
414 * window.c (replace_window, make_window): Adjust users.
415
a30ddace
DA
4162013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
417
418 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
419 this module is never compiled otherwise.
420
45435f08
AA
4212013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
422
423 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
424 (Bug#15500).
425
92e5298b
EZ
4262013-09-29 Eli Zaretskii <eliz@gnu.org>
427
428 * xdisp.c (get_next_display_element): Don't call face_for_font in
429 a build configured --without-x. (Bug#15484)
430
caa50be2
JD
4312013-09-29 Jan Djärv <jan.h.d@swipnet.se>
432
66d13b20
JD
433 * window.c (calc_absolute_offset): #elif should be #elif defined.
434
caa50be2
JD
435 * frame.c (delete_frame): Block/unblock input to overcome race
436 condition (Bug#15475).
437
d3e2acb6
AP
4382013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
439
440 * frame.c (delete_frame): Record selected frame only after
441 calling Qdelete_frame_functions (Bug#15477).
442
1610938f
JD
4432013-09-28 Jan Djärv <jan.h.d@swipnet.se>
444
445 * nsterm.m (ns_selection_color): Remove.
446 (ns_get_color): Check for ns_selection_(fg|bg)_color using
447 NSColor selectedText(Background)Color. Only for COCOA.
448 (ns_term_init): Remove assignment of ns_selection_color, logic
449 moved to ns_get_color.
450
328a8179 451 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
452 NS_SELECTION_COLOR_DEFAULT.
453 (NS_SELECTION_FG_COLOR_DEFAULT): New.
454
0d2647e6
EZ
4552013-09-28 Eli Zaretskii <eliz@gnu.org>
456
457 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
458 frame' does not have the tool_bar_window member.
459
ba355de0
BR
4602013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
461
462 Signal error when reading an empty byte-code object (Bug#15405)
463 * lread.c (read1): signal error
464 * alloc.c (make_byte_code): eassert header size
465 (sweep_vectors): change an int to size_t
466
4710d6f4
PE
4672013-09-24 Paul Eggert <eggert@cs.ucla.edu>
468
cf647d93
PE
469 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
470 instead of ints, as it's the usual style for offsetof constants. See:
471 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
472
4710d6f4
PE
473 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
474 This is ugly, but it should fix the performance problem for older
475 GCC versions in the short run. I'll look into integrating the
476 Gnulib module for popcount, as a better fix.
477 See the thread starting in:
478 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
479 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
480 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
481 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
482 (popcount_size_t): Use it.
483
10ebac9d
DC
4842013-09-24 Daniel Colascione <dancol@dancol.org>
485
486 * process.c (Fnetwork_interface_info): Fix build break due to
487 vector changes.
488
9da0f50e
PE
4892013-09-24 Paul Eggert <eggert@cs.ucla.edu>
490
491 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
492 Prefer signed to unsigned integers where either will do.
493 No need for 'const' on locals that do not escape.
494 Omit easserts with unnecessary and unportable assumptions about
495 alignment. Avoid unnecessary casts to char *.
496
d6d9cbc1
DA
4972013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
498
499 Use union for the payload of struct Lisp_Vector.
500 This helps to avoid a few glitches dictated by C's aliasing rules.
501 * lisp.h (struct Lisp_Vector): Use union for next and
502 contents member. Adjust comment. Change related users.
503 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
504 Related users changed.
505 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
506 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
507 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
508 * xfaces.c, xfont.c, xmenu.c: Related users changed.
509
ec7bc82f
DA
5102013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
511
512 Optimize glyph row clearing and copying routines.
513 * dispextern.h (struct glyph_row): Change layout of struct
514 glyph_row to help copy_row_except_pointers. Adjust comment.
515 * dispnew.c (null_row): Remove.
516 (clear_glyph_row): Use offsetof and memset to find and clear
517 just the members that need clearing. Adjust comment.
518 (copy_row_except_pointers): Likewise for copying.
519
d160dd0c
PE
5202013-09-24 Paul Eggert <eggert@cs.ucla.edu>
521
7be68de5
PE
522 Some minor cleanups of recently-added bool vector code.
523 * conf_post.h (assume): Always return void. Use lint version
524 only if GCC and MSC versions don't apply.
525 * conf_post.h (assume):
526 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
527 Depend on _MSC_VER, not __MSC_VER, for consistency with
528 the rest of Emacs.
529 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
530 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
531 (bool_vector_binop_driver, count_trailing_zero_bits)
532 (size_t_to_host_endian): Now static, not static inline;
533 the latter isn't needed with modern compilers and doesn't
534 work with older compilers anyway.
535
d160dd0c
PE
536 * alloc.c (valgrind_p): Use bool for boolean.
537
e08813d0
DA
5382013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
539
540 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
541 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
542 (display_last_displayed_message_p, message_buf_print)
543 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
544 Use bool for boolean.
3a6a78fd
DA
545 * dispextern.h (cancel_line, init_desired_glyphs):
546 Remove ancient leftover.
547 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
548 * lisp.h (noninteractive_need_newline): Adjust declaration.
549
5492865b
DA
5502013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
551
552 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
553 Move to...
554 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
555 ...this file and convert the latter to static. Adjust comment.
556 (make_initial_frame):
557 * window.c (init_window_once): Adjust user.
558 * frame.h (last_nonminibuf_frame): Remove declaration.
559 * lisp.h (selected_frame): Likewise.
560 * msdos.c (the_only_display_info): Adjust comment.
561
cd548fa4
EZ
5622013-09-23 Eli Zaretskii <eliz@gnu.org>
563
f03eddbf
EZ
564 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
565 computing the end column of mouse-highlight that comes from
566 display or overlay strings. (Bug#15437)
b519df23
EZ
567 (note_mouse_highlight): Adapt calculation of last argument to
568 mouse_face_from_string_pos to the above change.
f03eddbf 569
cd548fa4
EZ
570 * conf_post.h (__has_builtin): Define to zero, if undefined, on
571 all platforms, not just for clang.
572
8762e524
JD
5732013-09-23 Jan Djärv <jan.h.d@swipnet.se>
574
575 * filelock.c (lock_file_1): Rearrange to remove compiler warning
576 about excess arguments to snprintf.
577
578 * conf_post.h(assume): Use __builtin_unreachable for clang.
579
d4a9284f
JB
5802013-09-23 Juanma Barranquero <lekktu@gmail.com>
581
582 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
583 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
584
a84683fd
DC
5852013-09-23 Daniel Colascione <dancol@dancol.org>
586
587 * alloc.c (USE_VALGRIND): New macro; on by default
588 when ENABLE_CHECKING.
589 (mark_maybe_object,mark_maybe_pointer)
590 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
591 valgrind purposes.
592 (valgrind_p) [USE_VALGRIND]: New variable.
593 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
594
8fef36c6
JD
5952013-09-22 Jan Djärv <jan.h.d@swipnet.se>
596
fb83ea63
JD
597 * process.c (wait_reading_process_output): Change int pnamelen to
598 socklen_t.
599
600 * nsterm.m (setMarkedText:selectedRange:):
601 (deleteWorkingText):
602 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
603 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
604 argument to unsigned long to avoid warning.
605 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
606
8fef36c6
JD
607 * conf_post.h (assume): Fix compiler error: x shall be cond.
608
cd9356f2
DC
6092013-09-22 Daniel Colascione <dancol@dancol.org>
610
611 * xfns.c (x_get_monitor_attributes): Suppress unused variable
612 warning when compiling without a window system.
613
3e0b94e7
DC
6142013-09-22 Daniel Colascione <dancol@dancol.org>
615
616 * data.c (Qbool_vector_p): New symbol.
617 (bool_vector_spare_mask,popcount_size_t_generic)
618 (popcount_size_t_msc,popcount_size_t_gcc)
619 (popcount_size_t)
620 (bool_vector_binop_driver)
621 (count_trailing_zero_bits,size_t_to_host_endian)
622 (Fbool_vector_exclusive_or)
623 (Fbool_vector_union)
624 (Fbool_vector_intersection,Fbool_vector_set_difference)
625 (Fbool_vector_subsetp,Fbool_vector_not)
626 (Fbool_vector_count_matches)
627 (Fbool_vector_count_matches_at): New functions.
628 (syms_of_data): Intern new symbol, functions.
629 * alloc.c (bool_vector_payload_bytes): New function.
630 (Fmake_bool_vector): Instead of calling Fmake_vector,
631 which performs redundant initialization and argument checking,
632 just call allocate_vector ourselves. Make sure we clear any
633 terminating padding to zero.
634 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
635 instead of open-coding the size calculation.
636 (vroundup_ct): New macro.
637 (vroundup): Assume argument >= 0; invoke vroundup_ct.
638 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
639 * composite.c (composition_gstring_put_cache):
640 Change lint_assume to assume.
3e0b94e7
DC
641 * conf_post.h (assume): New macro.
642 (lint_assume): Remove.
643 * dispnew.c (update_frame_1): Change lint_assume to assume.
644 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
645 to assume.
646 * image.c (gif_load): Change lint_assume to assume.
647 * lisp.h (eassert_and_assume): New macro.
648 (Qbool_vector_p): Declare.
649 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
650 (swap16,swap32,swap64): New inline functions.
651 * macfont.c (macfont_shape): Change lint_assume to assume.
652 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
653 * xsettings.c (parse_settings): Use new swap16 and
654 swap32 from lisp.h instead of file-specific macros.
655
76880d88
EZ
6562013-09-22 Eli Zaretskii <eliz@gnu.org>
657
658 * xdisp.c (try_window_id): Don't abort if cursor row could not be
659 found (which can legitimately happen when the glyph row at the
660 window start is disabled in the current_matrix. (Bug#15365)
661
c6cfd910
PE
6622013-09-22 Paul Eggert <eggert@cs.ucla.edu>
663
664 Fix syntax.h bug introduced by recent INLINE change.
665 syntax.h defined an extern inline function SYNTAX_ENTRY that was
666 conditionally compiled one way in some modules, and a different
667 way in others. This doesn't work with extern inline functions,
668 which must have the same definition in all modules, because the
669 defining code might be shared across modules, depending on the
670 implementation. Symptoms reported by Martin Rudalics in:
671 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
672 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
673 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
674 overriding the corresponding functions in syntax.h.
675 * syntax.h (syntax_property_entry, syntax_property_with_flags)
676 (syntax_property): New inline functions.
677 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
678 Rewrite in terms of these new functions.
679
b3f1d119
EZ
6802013-09-21 Eli Zaretskii <eliz@gnu.org>
681
682 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
683 not chars_in_text, whose result depends on the multibyteness of
684 the current buffer. (Bug#15426)
685
00382e8b
PE
6862013-09-20 Paul Eggert <eggert@cs.ucla.edu>
687
e3b29769
PE
688 Port recent change to hosts where pointers aren't 'long'.
689 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
690 Don't assume that pointers are the same width as 'long'.
691 Add a compile-time check that a pointer fits into two X slots.
692
00382e8b
PE
693 A simpler, centralized INLINE.
694 * conf_post.h (INLINE): Define only if not already defined.
695 This allows us to use a single INLINE, defined by one file
696 per executable.
697 * emacs.c (INLINE): Define it.
698 Also, include category.h, charset.h, composite.h, dispextern.h,
699 syntax.h, systime.h, so that their INLINE definitions are expanded
700 properly for Emacs.
701 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
702 * buffer.h, buffer.c (BUFFER_INLINE):
703 * category.h, category.c (CATEGORY_INLINE):
704 * character.h, character.c (CHARACTER_INLINE):
705 * charset.h, charset.c (CHARSET_INLINE):
706 * composite.h, composite.c (COMPOSITE_INLINE):
707 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
708 * frame.h, frame.c (FRAME_INLINE):
709 * intervals.h, intervals.c (INTERVALS_INLINE):
710 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
711 * lisp.h, alloc.c (LISP_INLINE):
712 * process.h, process.c (PROCESS_INLINE):
713 * syntax.h, syntax.c (SYNTAX_INLINE):
714 * systime.h, sysdep.c (SYSTIME_INLINE):
715 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
716 * window.h, window.c (WINDOW_INLINE):
717 Remove. All uses replaced with INLINE.
718
2b943ba6
DA
7192013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
720
721 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
722 to avoid Bug#15398.
723
13d9698a
EZ
7242013-09-19 Eli Zaretskii <eliz@gnu.org>
725
726 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
727 'const char *' to avoid compiler warnings due to similar change in
728 the prototype of x_get_string_resource.
729
ced135eb
DA
7302013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
731
732 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
733 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
734 going to replace static variables below. Adjust comments.
735 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
736 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
737 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
738 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
739 Related users changed.
740 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
741 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
742 last_mouse_movement_time, going to replace static variables below.
743 Adjust comments.
744 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
745 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
746 Remove.
747 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
748 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
749 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
750 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
751 static variables below.
752 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
753 (last_mouse_scroll_bar): Remove.
754 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
755 (mouseExited): Related users changed.
756
091f1e1f
DA
7572013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
758
759 Do not use external array to process X scroll bar messages.
760 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
761 (x_send_scroll_bar_event): Pack window pointer into two slots
762 of XClientMessageEvent if we're 64-bit. Adjust comment.
763 (x_scroll_bar_to_input_event): Unpack accordingly.
764
582ed56c
DA
7652013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
766
767 Ifdef away recent changes which aren't relevant to NS port.
768 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
769 [!HAVE_NS]: Declare as such.
770 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
771 [!HAVE_NS]: Define as such.
772
18da0d8a
DA
7732013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
774
775 * frame.c (x_redo_mouse_highlight): New function
776 to factor out common code used in W32 and X ports.
777 * dispextern.h (x_redo_mouse_highlight): Add prototype.
778 * xterm.h (struct x_display_info):
779 * w32term.h (struct w32_display_info):
780 * nsterm.h (struct ns_display_info): New members
781 last_mouse_motion_frame, last_mouse_motion_x and
782 last_mouse_motion_y, going to replace static variables below.
783 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
784 (redo_mouse_highlight): Remove.
785 (note_mouse_movement, syms_of_xterm): Adjust user.
786 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
787 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
788 (redo_mouse_highlight): Remove.
789 (note_mouse_movement, syms_of_w32term): Adjust user.
790 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
791 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
792 Remove.
793 (note_mouse_movement, mouseMoved, syms_of_nsterm):
794 * nsfns.m (compute_tip_xy): Adjust user.
795
7a0c745a
DA
7962013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
797
798 * frame.c (x_mouse_grabbed): New function.
799 * dispextern.h (x_mouse_grabbed): Add prototype.
800 (last_mouse_frame): Remove declaration.
801 * xterm.h (struct x_display_info):
802 * w32term.h (struct w32_display_info):
803 * nsterm.h (struct ns_display_info): New member
804 last_mouse_frame, going to replace...
805 * xdisp.c (last_mouse_frame): ...global variable.
806 (note_tool_bar_highlight):
807 * w32term.c (w32_mouse_position, w32_read_socket):
808 * xterm.c (XTmouse_position, handle_one_xevent):
809 Use x_mouse_grabbed.
810 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
811
0791d107
DA
8122013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
813
814 * w32term.c (w32_read_socket): Avoid temporary
815 variables in a call to x_real_positions.
816 * xterm.c (handle_one_xevent): Likewise.
817
2cd98812
DA
8182013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
819
820 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
821 (x_icon_type): Remove prototype.
822 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
823 * frame.c (x_icon_type): Remove.
824 * w32term.c (x_make_frame_visible, x_iconify_frame):
825 * xterm.c (x_make_frame_visible, x_iconify_frame):
826 Use x_set_bitmap_icon to factor out common code.
827
a6c2ee1b
DA
8282013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
829
830 * dispextern.h (check_x_display_info, x_get_string_resource):
831 Declare here just once and unify the latter.
832 * frame.c (check_x_display_info, x_get_string_resource):
833 * nsterm.h (check_x_display_info):
834 * xrdb.c (x_get_string_resource):
835 * xterm.h (check_x_display_info): Remove prototypes.
836 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
837 * w32reg.c (x_get_string_resource): Likewise.
838 (w32_get_rdb_resource): Adjust user.
839
baed3603
DA
8402013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
841
842 * xterm.h (struct x_display_info): New member
843 x_pending_autoraise_frame, going to replace...
844 * xterm.c (pending_autoraise_frame): ...static variable.
845 (x_new_focus_frame, XTread_socket): Adjust users.
846 * w32term.h (struct w32_display_info): New member
847 w32_pending_autoraise_frame, going to replace...
848 * w32term.c (pending_autoraise_frame): ...global variable.
849 (x_new_focus_frame, w32_read_socket): Adjust users.
850
90582f05
GM
8512013-09-17 Glenn Morris <rgm@gnu.org>
852
853 * xdisp.c (message_dolog): If we create *Messages*,
854 switch it to messages-buffer-mode.
855
b7ad2f74
PE
8562013-09-17 Paul Eggert <eggert@cs.ucla.edu>
857
858 Don't overuse 'const' in types of locals.
859 * bidi.c (bidi_count_bytes):
860 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
861 (xg_event_is_for_scrollbar):
862 * xselect.c (x_handle_property_notify)
863 (x_handle_selection_notify, x_handle_dnd_message):
864 * xsettings.c, xsettings.h (xft_settings_event):
865 * xterm.c (x_handle_net_wm_state, handle_one_event)
866 (x_menubar_window_to_frame, x_detect_focus_change)
867 (construct_mouse_click, note_mouse_movement)
868 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
869 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
870 (handle_one_xevent, x_handle_net_wm_state):
871 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
872 (x_handle_dnd_message):
873 Avoid unnecessary 'const', typically the second 'const' in
874 'const foo * const arg', a 'const' that does not affect the API
875 and doesn't significantly help the human reader.
876
19452b86
DA
8772013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
878
879 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
880 only if Glib < 2.36.0.
881 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
882 * xsettings.c (init_gconf, init_gsettings): Do not check
883 for g_type_init.
1893694e
DA
884 * xterm.c (handle_one_xevent): Do not call to x_clear_area
885 if GTK >= 2.7.0.
33b83dd7 886 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 887
6434e343
JD
8882013-09-16 Jan Djärv <jan.h.d@swipnet.se>
889
3f386383
JD
890 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
891 before calling g_type_init.
892
6434e343
JD
893 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
894
895 * nsterm.m (syms_of_nsterm): ... to here.
896
83a119f8
DA
8972013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
898
899 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
900 (ignore_next_mouse_click_timeout): Use Time as X does.
901 (handle_one_xevent): Avoid cast and use unsigned comparison.
902
61582e6a
DA
9032013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
904
905 Do not copy X event in handle_one_xevent except KeyPress case.
906 Wnen XEvent is processed, it is unlikely to be changed except
907 KeyPress case, so we can avoid copying and use const pointer to
908 const data to make sure that an event is not changed elsewhere.
909 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
910 const' and do not create local copy except for the KeyPress event.
911 Use casts to avoid a few glitches. Adjust formatting. Add comments.
912 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
913 (x_handle_net_wm_state, x_menubar_window_to_frame)
914 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
915 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
916 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
917 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
918 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
919 (x_handle_dnd_message):
920 * xsettings.c (xft_settings_event):
921 Use 'const XEvent * const' where appropriate.
922 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
923
f8eb1572
DA
9242013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
925
926 Fix X event waiting to handle multiple frames.
927 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
928 * xterm.c (pending_event_wait): Remove. Adjust users.
929 (x_detect_focus_change): Pass frame arg.
930 (handle_one_xevent): Find related frame early and clear per-frame
931 wait_event_type only if this is an event for the relevant frame.
932 (x_wait_for_event): Use per-frame wait_event_type.
933
3fa2054e
JD
9342013-09-15 Jan Djärv <jan.h.d@swipnet.se>
935
745d3809
JD
936 * nsfns.m (Fx_create_frame): Fix font driver registration for
937 GNUStep.
938
939 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
940 for syms_of_macfont.
941
3fa2054e
JD
942 * nsterm.m: Include macfont.h.
943 (ns_tmp_flags, ns_tmp_font): Remove.
944 (ns_compute_glyph_string_overhangs): Check for driver Qns.
945 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
946 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
947 (changeFont:): Fix code style. Check for font driver type when
948 getiing font.
949
950 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
951 (f)->descent.
952
953 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
954 (nsfont_open): Set font driver type.
955 Set font->ascent and font->descent. Figure out font instead of
956 ns_tmp_font, and flags instead of ns_tmp_flags.
957 Fix indentation. Remove call to ns_draw_text_decoration,
958 moved to nsterm.
959
960 * nsfns.m: Include macfont.h.
961 (Fx_create_frame): Register macfont driver, make a better default font.
962 (Fns_popup_font_panel): Get font from macfont driver, if used.
963
964 * macfont.m, macfont.h, maccuvs.h: New files.
965
966 * font.h: Declare syms_of_macfont.
967
968 * font.c (syms_of_font): Call syms_of_macfont.
969
970 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
971
0eed0355
DA
9722013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
973
974 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
975 and it is always zero for others, so I assume that this is an ancient
976 leftover which nobody will want to change any more.
977 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
978 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
979 * frame.c (x_set_scroll_bar_width):
980 * w32fns.c (w32_createscrollbar):
981 * w32term.c (w32_set_vertical_scroll_bar):
982 * xfns.c (x_set_scroll_bar_default_width):
983 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
984 (x_scroll_bar_expose): Related users changed.
985
07013c68
DA
9862013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
987
988 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
989 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
990 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
991 Define as such.
c7cc32f7
DA
992 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
993 Define once here...
994 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
995 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
996 Remove unused Xisms.
7f09455e
DA
997 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
998 these modules are never compiled otherwise.
07013c68 999
0df00f59
EZ
10002013-09-14 Eli Zaretskii <eliz@gnu.org>
1001
08a209bf 1002 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
1003 Doc fix. (Bug#15375)
1004
fcd42c11
DA
10052013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1006
1007 Unify Fx_focus_frame between all ports.
1008 * frame.h (x_focus_frame): New prototype.
1009 * xfns.c (Fx_focus_frame): Remove.
1010 (syms_of_xfns): Do not defsubr it.
1011 (x_focus_frame): X implementation.
1012 * nsfns.m (Fx_focus_frame): Remove.
1013 (syms_of_nsfns): Do not defsubr it.
1014 (x_focus_frame): NS implementation.
1015 * w32term.c (Fx_focus_frame): Remove.
1016 (x_focus_on_frame): Rename to...
1017 (x_focus_frame): W32 implementation.
1018 * w32term.h (x_focus_on_frame): Remove prototype.
1019 * w32fns.c (Fx_focus_frame): Remove.
1020 (syms_of_w32fns): Do not defsubr it.
1021 * frame.c (Fx_focus_frame): Define here.
1022 (syms_of_frame): Defsubr here.
1023 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
1024
aad3612f
DA
10252013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1026
1027 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
1028 All of them are replaced with FRAME_DISPLAY_INFO, defined in
1029 each port to reference the port-specific window system data.
1030 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
1031 (FRAME_DISPLAY_INFO): Define.
1032 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
1033 (FRAME_DISPLAY_INFO): Define. Adjust users.
1034 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
1035 (FRAME_DISPLAY_INFO): Define. Adjust users.
1036 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
1037 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
1038 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
1039 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
1040 * xselect.c, xterm.c: All related users changed.
1041
9a650e62
DA
10422013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1043
1044 * xterm.h (x_window_to_frame, x_any_window_to_frame)
1045 (x_menubar_window_to_frame): Remove prototypes.
1046 * xfns.c (x_window_to_frame, x_any_window_to_frame)
1047 (x_menubar_window_to_frame, x_top_window_to_frame):
1048 Move from here...
1049 * xterm.c (x_window_to_frame, x_any_window_to_frame)
1050 (x_menubar_window_to_frame, x_top_window_to_frame):
1051 ...to here and convert all but the last to static.
1052
347ae3e1
EZ
10532013-09-12 Eli Zaretskii <eliz@gnu.org>
1054
1055 * lisp.mk (lisp): Add w32-common-fns.elc.
1056
15c6d837
XF
10572013-09-12 Xue Fuqiao <xfq.free@gmail.com>
1058
1059 * charset.c (char_charset): Document an exception for char-charset.
1060
27e90f77
DA
10612013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1062
1063 * xterm.h (x_display_info): New field last_user_time...
1064 * xterm.c (toplevel): ...to replace static last_user_time.
1065 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
1066
8ffbc36b
DA
10672013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1068
1069 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
1070 scroll bar values to prevent thumb from disappear and update comment.
1071
5ec0337a
GM
10722013-09-11 Glenn Morris <rgm@gnu.org>
1073
1074 * emacs.c (usage_message): Possessive apostrophe tweak.
1075
fb55b9d1
DA
10762013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1077
8d2db8be
DA
1078 * nsterm.m (syms_of_nsterm): Use Qns.
1079 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
1080 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
1081 * xfns.c (x_display_info_for_name, Fx_open_connection):
1082 Remove old '#if 0' code.
1083 (syms_of_xfns): Use Qx.
fb55b9d1
DA
1084 * termhooks.h (fullscreen_hook): Remove the leftover.
1085 (struct terminal): Fix typo in comment.
1086
927eec55
DA
10872013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1088
1089 Cleaning up a few X scroll bar bits.
1090 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
1091 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1092 New member last_seen_part, going to replace...
1093 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
1094 (xt_action_hook) [USE_LUCID]: Adjust user.
1095 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
1096 Lucid-specific scroll bar support.
1097 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
1098 to int and adjust to use last_seen_part member.
1099 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
1100 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1101 Initialize last_seen_part.
1102
71b28baa
SM
11032013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1104
1105 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
1106 insert-buffer-substring an empty string.
1107
f5dacaae
PE
11082013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
1111 avoiding a GCC warning.
1112
742516e0
DA
11132013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 Ifdef away frame tool bar code when it is not really used.
1116 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
1117 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
1118 and minimize_tool_bar_window_p under the above.
1119 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1120 (fset_tool_bar_window): Likewise.
1121 * dispnew.c (clear_current_matrices, clear_desired_matrices)
1122 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
1123 (change_frame_size_1):
1124 * window.c (window_from_coordinates, Frecenter): Adjust users.
1125 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
1126 code is not really used.
1127 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
1128 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
1129 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
1130 [!USE_GTK && !HAVE_NS]: Define as such.
1131 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
1132 (note_mouse_highlight, expose_frame):
1133 * xfns.c (x_set_tool_bar_lines):
1134 * xterm.c (handle_one_xevent): Adjust users.
1135
73f82c7e
PE
11362013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1137
1138 Fix corruption with multiple emacsclient -t instances (Bug#15222).
1139 This bug was introduced by my 2013-08-26 patch, which incorrectly
1140 assumed that the terminfo implementation doesn't use termcap buffers.
1141 * term.c (init_tty) [TERMINFO]: Remove optimization, as
1142 these buffers apparently are used after all.
1143 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
1144 (struct tty_display_info): Define members termcap_term_buffer and
1145 termcap_strings_buffer even if TERMINFO.
1146
53482f41
DA
11472013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1148
1149 Fix last change.
1150 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
1151 'usage' docstring entry to pacify make-docfile.
1152
11532013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
1154
1155 Change comparison functions =, <, >, <=, >= to take many arguments.
1156 * data.c: Change comparison functions' interface and implementation.
1157 * lisp.h: Make arithcompare available for efficient two arg
1158 comparisons.
1159 * bytecode.c: Use arithcompare.
1160 * fileio.c: Use new interface.
1161
533f258f
SM
11622013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1163
1164 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
1165
8c27f5ff
SM
11662013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
1167
1168 * eval.c (Feval): Document the new use of `lexical'.
1169
0750a308
DA
11702013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 Review and drop old frame resize hack.
1173 * frame.h (struct frame): Remove force_flush_display_p.
1174 * dispnew.c (update_frame): Adjust user and don't call
1175 flush_frame here. The comment has said that there was an issues
1176 with redisplaying fringes, but I don't see any differences with
1177 and without this hack. Hopefully we can continue without it.
1178 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
1179 current frame matrices twice if resized_p is set.
1180
83fc0554
DA
11812013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 Do not populate pure Xism x_sync to other ports.
1184 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
1185 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
1186 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
1187 * w32term.h (x_sync): Remove prototype.
1188
fd462129
DA
11892013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1190
1191 Cleanup frame flushing.
8c27f5ff
SM
1192 * dispextern.h (struct redisplay_interface):
1193 Drop flush_display_optional because flush_display is enough
fd462129
DA
1194 for X and flushing via RIF is just a no-op for others.
1195 * frame.h (flush_frame): New function.
1196 * dispnew.c (update_frame):
1197 * minibuf.c (read_minibuf):
1198 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
1199 Use it.
1200 * keyboard.c (detect_input_pending_run_timers): Do not flush
1201 all frames but selected one in redisplay_preserve_echo_area.
1202 * nsterm.m (ns_flush): Remove no-op.
1203 (ns_redisplay_interface): Adjust user.
1204 * w32term.h (x_flush): Remove no-op.
1205 (w32_redisplay_interface): Adjust user.
1206 * xterm.c (x_flush): Simplify because we do not flush all
1207 frames at once any more. Adjust comment.
1208 (x_redisplay_interface): Adjust user.
1209
4b73fc73
PE
12102013-09-07 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 Port --without-x --enable-gcc-warnings to Fedora 19.
1213 * gfilenotify.c (globals_of_gfilenotify):
1214 Call g_type_init only if using an older glib version that needs it.
1215
77394d40
DA
12162013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1219 (last_glyphless_glyph_merged_face_id): Remove declarations.
1220 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
1221 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1222 (last_glyphless_glyph_merged_face_id): Now static.
1223 (merge_escape_glyph_face): New function, refactored from...
1224 (get_next_display_element): ...here.
1225 (merge_glyphless_glyph_face): New function, refactored from...
1226 (produce_glyphless_glyph): ...here...
1227 * term.c (produce_glyphless_glyph): ...and here.
1228
306d67bd
SM
12292013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
1230
1231 * eval.c (eval_sub): Only call Ffunction if necessary.
1232
7f6c6450
DA
12332013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1234
1235 Attempt to make redisplay more selective when changing cursor type.
1236 * frame.h (struct frame): New bitfield cursor_type_changed.
1237 * xdisp.c (cursor_type_changed): Remove.
1238 (try_cursor_movement, redisplay_window, try_window_id)
1239 (set_frame_cursor_types, try_window_reusing_current_matrix):
1240 Adjust to use per-frame bitfield.
1241 (redisplay_internal): Look for cursor type change on each visible
1242 frame and consider all frames if cursor type has been changed on
1243 the frame other than selected. If cursor type has been changed on
1244 selected frame only, do not use fast update.
1245
bd0443bb
DA
12462013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1247
1248 Attempt to make redisplay more selective when changing fonts.
1249 * frame.h (struct frame): New bitfield fonts_changed.
1250 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
1251 (adjust_frame_glyphs): Add prototype.
1252 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 1253 (adjust_glyphs): Remove because we do not
bd0443bb
DA
1254 adjust matrices on all frames at once any more.
1255 (adjust_frame_glyphs): Block and unblock input here.
1256 (adjust_glyph_matrix): Use fonts_changed.
1257 (change_frame_size_1): Use adjust_frame_glyphs.
1258 * font.c (font_open_entity): Use fonts_changed.
1259 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
1260 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1261 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
1262 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
1263 (shrink_mini_window, Fresize_mini_window_internal)
1264 (window_scroll_pixel_based, Fset_window_configuration)
1265 (apply_window_adjustment, Fset_window_vscroll):
1266 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1267 Use adjust_frame_glyphs.
1268 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
1269 (try_window_reusing_current_matrix, try_window_id, display_line)
1270 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
1271 (redisplay_internal): Consider fonts_changed and adjust frame
1272 matrices for each frame only if the frame is visible. If font
1273 has been changed on some frame during full redisplay, retry
1274 only visible frames where the font has been actually changed.
1275
b9695828
DA
12762013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1277
1278 Cache current header and mode line height for each window.
1279 * window.h (struct window): New fields mode_line_height
1280 and header_line_height.
1281 * window.c (make_window): Initialize them.
1282 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
1283 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
1284 (current_mode_line_height, current_header_line_height):
1285 Remove declaration.
1286 * xdisp.c (current_mode_line_height, current_header_line_height):
1287 Remove.
1288 (pos_visible_p, init_xdisp): Adjust user.
1289 (redisplay_window): Invalidate mode_line_height and
1290 header_line_height if current and desired matrices do not agree.
1291
66738305
DA
12922013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1293
1294 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
1295 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
1296
257b3b03
DA
12972013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 Make --without-x compatible with --enable-gcc-warnings.
1300 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
1301 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
1302 members under HAVE_WINDOW_SYSTEM.
1303 * keyboard.c (make_lispy_focus_out): Likewise.
1304 (record_menu_key): Move under HAVE_MENUS.
1305 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
1306 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
1307 (syms_of_xdisp): Adjust user.
1308 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
1309 (start_hourglass, cancel_hourglass):
1310 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
1311 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
1312 and CLEAR_FONT_TABLE_NFONTS.
1313 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
1314 Declare only if HAVE_WINDOW_SYSTEM.
1315 (lface_same_font_attributes_p, clear_face_gcs): Define only
1316 if HAVE_WINDOW_SYSTEM.
1317
98b7f4bd
DA
13182013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1319
1320 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
1321 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
1322 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
1323
a7e43722
SM
13242013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
1325
1326 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
1327
0c90b9ee
PE
13282013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
1331 This fixes a type error on hosts where ptrdiff_t is wider than int.
1332
d99760fa
SM
13332013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1334
6629638e
SM
1335 * keyboard.c (read_key_sequence_vs): New function.
1336 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
1337 common code.
1338
d99760fa
SM
1339 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1340
224e313d
PE
13412013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 Makefile improvements.
1344 * Makefile.in (config.status): Don't use double-colon rules, as
1345 they are not portable according to POSIX. Fix shell typo with `;
1346 I guess this rule has never been tested?
1347 (VCSWITNESS): New macro, to override any environment var.
1348
6d6ed1af
DA
13492013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 * xterm.h (struct x_display_info): Do not track X connection
1352 fd separately because it is always available from Display.
1353 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1354 Adjust users.
1355
bc923770
DA
13562013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1357
1358 * buffer.c (drop_overlay):
1359 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1360 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1361
b1cf96de
DA
13622013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1363
1364 * buffer.c (Fmake_overlay, Fmove_overlay):
1365 * intervals.c (set_point_from_marker):
1366 * print.c (PRINTPREPARE): Prefer signal_error
1367 to plain error and report unsuitable marker too.
1368
d1fc6c21
DA
13692013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1370
1371 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1372 for 'dragging' member.
d1ae6a0b
DA
1373 (struct x_output): Remove set-but-unused leftovers
1374 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1375 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1376 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1377 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1378 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1379 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1380 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1381 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1382 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1383
0ce9f6de
JD
13842013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1385
1386 * nsfont.m (INVALID_GLYPH): New define.
1387 (nsfont_encode_char): Use INVALID_GLYPH.
1388 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1389
b594a96c
DA
13902013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1391
1392 * xterm.c (x_last_mouse_movement_time): Revert last change.
1393 This code should use XDisplayMotionBufferSize to check display's
1394 motion history first, and there are few other issues as well.
1395 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1396 (handle_one_xevent): Adjust user.
1397
8b098236
MR
13982013-09-02 Martin Rudalics <rudalics@gmx.at>
1399
9718b207
MR
1400 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1401 * frame.c (Flast_nonminibuf_frame): ... to here.
1402 (check_minibuf_window): Don't abort if no window was found
1403 (Bug#15247).
8b098236 1404
84e70bba
DA
14052013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1406
1407 Use XGetMotionEvents to ask the last mouse motion time from X server.
1408 * xterm.c (X_MOTION_HISTORY): Default to 1.
1409 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1410 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1411 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1412 Ifdef away legacy code.
1413 (XTmouse_position, x_scroll_bar_report_motion):
1414 Use x_last_mouse_movement_time.
fc85e20b
DA
1415 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1416 UnmapNotify event.
84e70bba 1417
1fccc530
DA
14182013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1419
1420 * msdos.c (last_mouse_window): Move to...
1421 (dos_rawgetc): ...this function and adjust comment.
1422 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1423 (mouseMoved): ...this function and adjust comment.
1424 * w32term.c (last_window): Likewise with...
1425 (w32_read_socket): ...this function.
1426 * xterm.c (last_window): Likewise with...
1427 (handle_one_xevent): ...this function.
1428
0ab10992
DA
14292013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1430
b7da754d 1431 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1432 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1433 (handle_one_xevent): ...to here.
1434 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1435 otherwise.
1436
0c7f856e
DA
14372013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1438
1439 * msdos.c (IT_set_terminal_window): Remove no-op.
1440 (initialize_msdos_display): Adjust terminal setup.
1441 * w32console.c (w32con_set_terminal_window): Remove no-op.
1442 (initialize_w32_display): Adjust terminal setup.
1443 * w32term.c (w32_set_terminal_window): Remove no-op.
1444 (w32_create_terminal): Adjust terminal setup.
1445 * xterm.c (XTset_terminal_window): Remove no-op.
1446 (x_create_terminal): Adjust terminal setup.
1447
a892a94c
DA
14482013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1449
1450 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1451 Remove no-ops.
1452 (ns_create_terminal): Adjust terminal setup.
1453 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1454 Remove no-ops.
1455 (w32_create_terminal): Adjust terminal setup.
1456 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1457 Remove no-ops.
1458 (x_create_terminal): Adjust terminal setup.
1459
cf91889a
DA
14602013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1461
1462 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1463 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1464 * dispnew.c (buffer_posn_from_coords):
1465 * window.c (Fwindow_end, displayed_window_lines):
1466 * xdisp.c (redisplay_mode_lines): Use it.
1467
5b0891df
JD
14682013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1469
1470 * fontset.c (face_for_char): Check char in the current face font first
1471 if HAVE_NS (Bug#15138).
1472
0a357e98
MR
14732013-08-31 Martin Rudalics <rudalics@gmx.at>
1474
1475 * window.c (temp_output_buffer_show): Make sure window returned
1476 by display_buffer is live (Bug#15213).
1477
9d7693d7
DA
14782013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1479
1480 Minor cleanup to avoid forward declarations.
1481 * coding.h (struct ccl_spec): Remove forward declaration.
1482 * composite.h (toplevel): Include font.h.
1483 (struct composition_it, struct face, struct font_metrics):
1484 Remove forward declaration.
1485 * dispextern.h (struct image, struct atimer): Likewise.
1486 * emacsgtkfixed.h (struct frame): Likewise.
1487 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1488 * font.h (struct font_driver, struct font, struct glyph_string)
1489 (struct face): Remove forward declaration.
1490 * fontset.h (struct face, struct font): Likewise.
1491 * frame.h (toplevel): Style cleanup.
1492 (enum output_method): Move to...
1493 * termhooks.h (enum output_method): ...here.
1494 (struct glyph, struct frame, struct ns_display_info)
1495 (struct x_display_info, struct w32_display_info):
1496 Remove forward declaration.
1497 * xterm.h (toplevel): Include termhooks.h.
1498 (struct font, struct window, struct glyph_matrix, struct frame)
1499 (struct input_event, struct face, struct image): Remove forward
1500 declaration.
1501 * gtkutil.h (struct _widget_value): Likewise.
1502 * keyboard.h (toplevel): Include termhooks.h.
1503 (struct input_event): Remove forward declaration.
1504
032f7451
DA
15052013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1506
1507 * intervals.c (set_point_from_marker): New function.
1508 * editfns.c (Fgoto_char):
1509 * process.c (Finternal_default_process_filter):
1510 * window.c (select_window_1): Use it.
1511 * buffer.h (set_point_from_marker): Add prototype.
1512
3f940c5a
EZ
15132013-08-29 Eli Zaretskii <eliz@gnu.org>
1514
1515 * w32.c (term_winsock): Call release_listen_threads before calling
1516 WSACleanup.
1517 (_sys_wait_accept): Wait for accept event in a loop with a finite
1518 timeout, instead of waiting indefinitely. Will hopefully avoid
1519 hanging during exit because WSACleanup deadlocks waiting for the
1520 event object to be released. (Bug#14333)
1521
1522 * w32proc.c (release_listen_threads): New function, signals all
1523 the reader threads that listen for connections to stop waiting.
1524
1525 * w32.h (release_listen_threads): Add prototype.
1526
101ed2bb
DA
15272013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1528
1529 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1530 field of new marker (for sanity and safety).
20de2834
DA
1531 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1532 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1533
1f5cf200
DA
15342013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1537 (x_after_update_window_line, x_scroll_bar_create):
1538 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1539 (handle_one_xevent, x_clear_frame_area):
1540 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1541 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1542 * xterm.h (x_clear_area): Adjust prototype.
1543
d2b36813
DA
15442013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1545
1546 Hook scanning and indentation functions to find_newline. This helps
1547 to avoid duplicated code and renders more respect to newline cache.
1548 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1549 * cmds.c (Fforward_line):
1550 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1551 Use find_newline and avoid unnecessary point movements.
1552 * search.c (scan_newline): Implement on top of find_newline.
1553
3ec7babc
SM
15542013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1555
1556 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1557 scoped code (bug#11258).
1558
5ab473cd
JD
15592013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1560
1561 * nsterm.m (last_window): New variable.
1562 (EV_TRAILER2): New macro.
1563 (EV_TRAILER): Call EV_TRAILER2.
1564 (mouseMoved:): Add support for mouse-autoselect-window
1565 on nextstep (Bug#6888).
1566
78779650
AS
15672013-08-28 Andreas Schwab <schwab@suse.de>
1568
1569 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1570 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1571 Remove unused macro definitions.
1572 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1573 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1574 Only define if emacs.
78779650 1575
c3c4768d
DA
15762013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1577
1578 Prefer enum glyph_row_area to int where appropriate.
1579 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1580 Fix comment.
1581 (window_box, window_box_width, window_box_left, window_box_left_offset)
1582 (window_box_right, window_box_right_offset): Adjust prototypes.
1583 * xdisp.c (window_box, window_box_width, window_box_left)
1584 (window_box_left_offset, window_box_right, window_box_right_offset):
1585 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1586 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1587 * nsterm.m (ns_clip_to_row):
1588 * w32term.c (w32_clip_to_row):
1589 * xterm.c (x_clip_to_row): Likewise.
1590
6bdcbfe1
DA
15912013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1592
1593 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1594 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1595
50b13cde
PE
15962013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1597
1598 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1599 for portability to hosts where /bin/sh has problems.
1600
f60e429a
DA
16012013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1602
1603 Redesign redisplay interface to drop global output_cursor.
1604 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1605 (toplevel): Remove declaration of output_cursor.
1606 (set_output_cursor, x_cursor_to): Remove prototype.
1607 * window.h (struct window): New member output_cursor.
1608 (output_cursor_to): New function to replace RIF member.
1609 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1610 (update_text_area, set_window_cursor_after_update): Use it.
1611 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1612 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1613 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1614 * w32term.c (x_update_window_begin, x_update_window_end):
1615 * xterm.c (x_update_window_begin, x_update_window_end):
1616 Adjust to use per-window output cursor.
1617
43aac990
PE
16182013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1619
d486344e
PE
1620 Simplify SELECT_TYPE-related code.
1621 Like EMACS_TIME, this portability layer is no longer needed, since
1622 Emacs has been using fd_set as a portability layer for some time.
1623 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1624 (SELECT_TYPE): Remove. All uses changed to fd_set.
1625 (fd_set) [!FD_SET]: New typedef.
1626
43aac990
PE
1627 Simplify EMACS_TIME-related code.
1628 This portability layer is no longer needed, since Emacs has been
1629 using struct timespec as a portability layer for some time.
1630 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1631 Include <time.h> rather than "systime.h"; that's all that's needed now.
1632 * dispnew.c: Include <timespec.h> rather than "systime.h";
1633 that's all that's needed now.
1634 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1635 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1636 TIMESPEC_RESOLUTION.
1637 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1638 LOG10_TIMESPEC_RESOLUTION.
1639 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1640 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1641 (make_emacs_time): Remove. All used changed to make_timespec.
1642 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1643 (current_timespec): Rename from current_emacs_time. All uses changed.
1644 (add_emacs_time): Remove. All uses changed to timespec_add.
1645 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1646 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1647 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1648 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1649 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1650 (current_timespec): Rename from current_emacs_time. All uses changed.
1651 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1652 changed to timespec_cmp.
1653 * xgselect.c: Include <timespec.h>, since our .h files don't.
1654
d350e350
DA
16552013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1656
1657 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1658 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1659 Remove the leftovers.
1660 * gtkutil.c (toplevel): Do not declare Qxft but include
1661 font.h to do so.
1662 * image.c (toplevel): Do not declare Vlibrary_cache because
1663 it's already done in lisp.h.
1664
9fed9729
DA
16652013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 * lisp.h (Mouse_HLInfo): Move from here...
1668 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1669 (reset_mouse_highlight): New function.
1670 * msdos.c (dos_set_window_size, IT_update_begin)
1671 (internal_terminal_init):
1672 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1673 (ns_initialize_display_info):
1674 * w32console.c (initialize_w32_display):
1675 * w32term.c (x_update_window_end, x_free_frame_resources)
1676 (w32_initialize_display_info):
1677 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1678 * window.c (Fdelete_other_windows_internal):
1679 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1680 * termchar.h (toplevel):
1681 * xterm.h (toplevel): Include dispextern.h.
1682
f462f075
PE
16832013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 Fix minor problems found by static checking.
1686 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1687 (expect): Avoid nested-if warning.
1688 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1689 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1690 * nsterm.h, nsterm.m (ns_select):
1691 * xgselect.c, xgselect.h (xg_select):
1692 Adjust signature to better match pselect's.
1693 * nsterm.m (ns_select):
1694 Don't set *TIMEOUT, since pselect doesn't.
1695 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1696 diagnostic about assigning const char * to it.
1697 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1698
068f9124
SM
16992013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1700
1701 * lread.c (substitute_object_recurse): Handle hash-tables as well
1702 (bug#15190).
1703
f5adc984
PE
17042013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1705
1fc8eb33
PE
1706 Fix unlikely core dump in init_tty, and simplify terminfo case.
1707 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1708 The old version incorrectly dumped core if malloc returned a
1709 buffer containing only non-NUL bytes.
1710 (init_tty): Do not allocate or free termcap buffers; the
1711 struct does that for us now.
1712 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1713 (struct tty_display_info): Define members termcap_term_buffer and
1714 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1715 use them. Allocate them directly in struct rather than indirectly
1716 via a pointer, to simplify init_tty.
1717
f5adc984
PE
1718 * frame.c (check_minibuf_window): Initialize 'window' properly,
1719 so that Emacs reliably aborts later if 'window' is not initialized.
1720
efec3894
JD
17212013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1722
1723 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1724 of VoidSymbol (Bug#15154).
1725
e1d0341e
DA
17262013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1727
1728 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1729 mouse_face_beg_y and mouse_face_end_y.
1730 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1731 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1732 Adjust users and update comment where appropriate.
1733
bfff6445
MR
17342013-08-26 Martin Rudalics <rudalics@gmx.at>
1735
1736 * frame.c (check_minibuf_window): New function.
068f9124
SM
1737 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1738 Call check_minibuf_window (Bug#15183).
bfff6445 1739
c80016b3
DA
17402013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1741
1742 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1743 because this is the only last cursor data we need to keep and consult.
1744 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1745 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1746 Adjust users.
1747
de396731
DA
17482013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1749
068f9124
SM
1750 Fix recovering from possible decompression error.
1751 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1752 the position where the partially decompressed data ends, and
447218dd 1753 should count how many bytes was produced so far.
de396731
DA
1754 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1755 (unwind_decompress): Really delete partially uncompressed data.
1756 (Fzlib_decompress_region): Take decompressed data size into account.
1757
c76826d9
DA
17582013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1759
1760 * syntax.c (init_syntax_once): Adjust comment and do an early
1761 initialization of Qchar_table_extra_slots just once...
1762 * casetab.c (init_casetab_once):
1763 * category.c (init_category_once):
1764 * character.c (syms_of_character):
1765 * coding.c (syms_of_coding):
1766 * xdisp.c (syms_of_xdisp): ...and omit it here.
1767
b34454d0
EZ
17682013-08-24 Eli Zaretskii <eliz@gnu.org>
1769
11f20add
EZ
1770 * xdisp.c (get_next_display_element): Don't apply to characters
1771 from a display vector the logic of setting it->end_of_box_run_p
1772 suitable for characters from a buffer. (Bug#15175)
1773
b34454d0
EZ
1774 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1775 to handle directories, rather than '_utime' which doesn't.
1776 (Bug#15176)
1777
6e1b469e
JD
17782013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1779
1780 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1781 or fullscreen (Bug#14627).
1782
9c05bccf
PE
17832013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1784
1785 System-dependent integer overflow fixes.
1786 * process.c (Fset_process_window_size): Signal an error if
1787 the window size is outside the range supported by the lower level.
1788 * sysdep.c (set_window_size): Return negative on error,
1789 nonnegative on success, rather than -1, 0, 1 on not in system,
1790 failure, success. This is simpler. Caller changed.
1791 (serial_configure): Remove unnecessary initialization of local.
1792 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1793 size fits in unsigned long; this isn't true on some 32-bit hosts.
1794 Avoid buffer overrun if some future version of /proc/meminfo has a
1795 variable name longer than 20 bytes.
1796 (system_process_attributes) [__FreeBSD__]:
1797 Don't assume hw.availpages fits in 'int'.
1798
c365c355
PE
17992013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 Don't let very long directory names overrun the stack.
1802 Fix some related minor problems involving "//", vfork.
1803 * callproc.c (encode_current_directory): New function.
1804 (call_process): Don't append "/"; not needed.
1805 * fileio.c (file_name_as_directory_slop): New constant.
1806 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1807 this can save the caller having to alloca.
1808 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1809 Use SAFE_ALLOCA, not alloca.
1810 (directory_file_name, Fexpand_file_name): Leave leading "//"
1811 alone, since it can be special even on POSIX platforms.
1812 * callproc.c (call_process):
1813 * process.c (Fformat_network_address):
1814 * sysdep.c (sys_subshell):
1815 Use encode_current_directory rather than rolling our own.
1816 (create_process): No need to encode directory; caller does that now.
1817 * process.h (encode_current_directory): New decl.
1818 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1819 Rework to avoid 'goto xyzzy;'.
1820
6c6014d4
EZ
18212013-08-23 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (handle_face_prop): If the default face was remapped use
1824 the remapped face for strings from prefix properties. (Bug#15155)
1825
9997ec56
DA
18262013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1827
1828 Minor cleanup for redisplay interface and few related functions.
1829 * frame.h (enum text_cursor_kinds): Move from here...
1830 * dispextern.h (enum text_cursor_kinds): ...to here.
1831 (toplevel): Drop unnecessary declarations.
1832 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1833 in update_window_end_hook and draw_window_cursor functions.
1834 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1835 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1836 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1837 * xterm.c (x_update_window_end, x_draw_window_cursor):
1838 * xdisp.c (display_and_set_cursor, update_window_cursor)
1839 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1840 enum text_cursor_kinds where appropriate.
1841
7f780da6
DA
18422013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1843
1844 Redesign redisplay interface to drop updated_row and updated_area.
1845 * dispextern.h (updated_row, updated_area): Remove declaration.
1846 (struct redisplay_interface): Pass glyph row and row area parameters
1847 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1848 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1849 Adjust prototypes.
1850 * dispnew.c (updated_row, updated_area): Remove.
1851 (redraw_overlapped_rows, update_window_line): Adjust user.
1852 (update_marginal_area, update_text_area): Likewise. Pass updated row
1853 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1854 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1855 Adjust users.
1856
26495794
PE
18572013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 * process.c (flush_pending_output): Remove stub.
1860 All uses removed.
1861
4a88129a
PE
18622013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 * callproc.c: Fix race that killed background processes (Bug#15144).
1865 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1866 Record deleted process-id in critical section, not afterwards.
1867 Don't mistakenly kill process created by a call-process invocation
1868 that discards output and does not wait.
1869
0c5307b0
DA
18702013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1871
1872 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1873 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1874 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1875 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1876 to shut up compiler in mark_object.
1877 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1878
0d7c1e66
PE
18792013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1882 We can't portably rely on PTY_OPEN doing that, even if
1883 it calls posix_openpt with O_CLOEXEC.
1884
3f246b65
KH
18852013-08-20 Kenichi Handa <handa@gnu.org>
1886
1887 * character.c (string_char): Improve commentary.
1888
8c2f38aa
PE
18892013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1892 (struct animation_cache): Make signature a flexible array member.
1893 All uses changed. This is a tad slower but may insulate us better
1894 from future changes to ImageMagick.
1895
bb566cea
PE
18962013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * image.c: Shrink memory needed for animation cache.
1899 (SIGNATURE_DIGESTSIZE): New constant.
1900 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1901 (imagemagick_create_cache): Copy the signature. This saves
1902 several KB of memory that ImageMagick wastes per signature.
1903 Don't bother updating the update_time, as the caller does that now.
1904 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1905 it's a fixed size struct member now.
1906 (imagemagick_get_animation_cache): Always destroy the signature,
1907 as it's now imagemagick_create_cache's responsibility to copy it.
1908 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1909 and use memcmp rather than strcmp.
1910 eassert that ImageMagick returns a signature of the specified length.
1911
6da26928
LMI
19122013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1913
1914 * image.c (imagemagick_get_animation_cache): Don't segfault on
1915 each invocation.
453f4022
LMI
1916 (imagemagick_get_animation_cache): Revert to previous definition
1917 so that it actually works. But keep the memory leak fix.
1918 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1919
22490125
PE
19202013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1921
d0139df5
PE
1922 * image.c: Fix animation cache signature memory leak.
1923 Fix some other minor performance problems while we're at it.
1924 (imagemagick_create_cache): Clear just the members that
1925 need clearing. Don't set update_time, as caller does that now.
1926 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1927 Simplify by using pointer-to-pointer instead of a prev pointer.
1928 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1929 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1930 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1931 it's already a copy. Free the signature probe unless it's cached.
1932
22490125
PE
1933 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1934 This was introduced by my 2013-08-12 fix for Bug#15035.
1935
deb31e75
DA
19362013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1937
1938 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1939 (imagemagick_prune_animation_cache): Now static.
1940
319a4d03
LMI
19412013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1942
1943 * image.c (imagemagick_get_animation_cache): Don't segfault when
1944 pruning all entries.
1945
f747d82e
KB
19462013-08-18 Ken Brown <kbrown@cornell.edu>
1947
1948 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1949 static heap if ENABLE_CHECKING is defined.
1950 (max_bss_sbrk_ptr): New variable.
1951 (bss_sbrk): Use it.
1952 (report_sheap_usage): Report maximum static heap usage instead of
1953 ending static heap usage.
1954
d2c28fab
EZ
19552013-08-17 Eli Zaretskii <eliz@gnu.org>
1956
1957 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1958 of zlib_initialized according to the results of calling
1959 init_zlib_functions.
1960
274ff63f
LMI
19612013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1962
1963 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1964 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1965 (imagemagick_load_image): Remove the ping_wand code, which only
1966 apparently saved time on invalid animated images, and slowed down
1967 everything else. Optimise for the common case.
274ff63f 1968
2bede2ed
XF
19692013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1970
70ff8240
XF
1971 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1972
de179a3e
XF
1973 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1974
2bede2ed
XF
1975 * marker.c (set_marker): Remove documentation of undefined behavior.
1976
703dbeba
LMI
19772013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978
1979 * image.c (imagemagick_compute_animated_image): Animate correctly
1980 when sub-images are smaller than the main image.
1d18b1e6
LMI
1981 (imagemagick_compute_animated_image): Setting the iterator row to
1982 zero is apparently not allowed.
79670014
LMI
1983 (imagemagick_compute_animated_image): Allow images that say they
1984 have sub-images that are bigger than the main image, but just crop
1985 them.
703dbeba 1986
63216c5e
JD
19872013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1988
1989 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1990
a5b5f73f
LMI
19912013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1992
1993 * image.c (imagemagick_compute_animated_image): Respect the GIF
1994 disposal methods.
1995
0fe73012
KB
19962013-08-15 Ken Brown <kbrown@cornell.edu>
1997
1998 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1999 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
2000 needed.
2001
691a357f
PE
20022013-08-15 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 Fix minor problems found by static checking.
2005 * frame.c (delete_frame):
2006 * xdisp.c (next_element_from_display_vector):
2007 Avoid uninitialized local.
2008 * image.c (imagemagick_compute_animated_image): Port to C89.
2009 Prefer usual GNU indentation style for loops.
2010 Be more careful about bizarrely large sizes, by using ptrdiff_t
2011 instead of int.
2012
42fe2e88
DA
20132013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2014
2015 Fix infinite frame selection loop (Bug#15025).
2016 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
2017
d39a3da6
EZ
20182013-08-15 Eli Zaretskii <eliz@gnu.org>
2019
068f9124
SM
2020 * xdisp.c (compute_window_start_on_continuation_line):
2021 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
2022 to make sure we end up setting the window start at the leftmost
2023 visible character of the display line. This avoids funky
2024 horizontal shifting because the window start is not kept on the
2025 same position. (Bug#15090)
05426239
EZ
2026 (next_element_from_display_vector): Support 'box' face attribute
2027 in the face definitions of a display vector. (Bug#15099)
d39a3da6 2028
6e856b69
LMI
20292013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2030
2031 * image.c (imagemagick_compute_animated_image): Implement animated
2032 images (bug#14700).
995be755
LMI
2033 (imagemagick_compute_animated_image): Fix some compilation
2034 warnings. Implement a very simple cache to make the animation
2035 usable at all, but it should be replaced with a per-image cache.
6e856b69 2036
d5a1acfa
DA
20372013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2038
2039 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
2040 to do `for' loops over alist values.
2041 * buffer.h (FOR_EACH_BUFFER):
2042 * process.c (FOR_EACH_PROCESS): Use it.
2043 (handle_child_signal, status_notify, Fget_buffer_process)
2044 (kill_buffer_processes): Use FOR_EACH_PROCESS.
2045
9c253307
DA
20462013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2047
2048 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
2049 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
2050 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
2051 to xzalloc and so avoid redundant call to memset.
2052 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
2053 members because it is allocated with xzalloc and so already zeroed.
2054
05e64f9f
KB
20552013-08-14 Ken Brown <kbrown@cornell.edu>
2056
2057 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
2058 (Bug#15094).
2059
5b71542d
DA
20602013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2061
2062 Utility function and macro to copy Lisp string to C string.
2063 * lisp.h (xlispstrdupa): New macro.
2064 (xlispstrdup): New prototype.
2065 * alloc.c (xlispstrdup): New function.
2066 * callint.c (Fcall_interactively):
2067 * fileio.c (Ffile_name_directory, Fexpand_file_name)
2068 (Fsubstitute_in_file_name):
2069 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
2070 * image.c (x_create_bitmap_from_file):
2071 * w32term.c (w32_term_init):
2072 * xterm.c (x_term_init): Use xlispstrdup.
2073
71530c97
LMI
20742013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2075
4ce82fb8
LMI
2076 * image.c (imagemagick_load_image): Make animated pictures work.
2077 There's still some problems with background color settings, though
2078 (bug#14700).
2079
71530c97
LMI
2080 * decompress.c (unwind_decompress): Always restore point.
2081
7510a061
XF
20822013-08-14 Xue Fuqiao <xfq.free@gmail.com>
2083
2084 * marker.c (set_marker): Reformat documentation.
2085
01c3051f
PE
20862013-08-14 Paul Eggert <eggert@cs.ucla.edu>
2087
aab1fcdf
PE
2088 * xdisp.c (cursor_type_changed): Now static.
2089
01c3051f
PE
2090 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
2091 Use changed. This avoids the need to call xmalloc and for the
2092 caller to call xfree, and avoids memory leaks in some situations.
2093
2084152a
DA
20942013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2095
2096 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
2097 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
2098 (redisplay_window): If window_end_valid is cleared due to non-zero
2099 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
2100 so do not call to try_cursor_movement for that window.
2084152a 2101
02455cb6
DA
21022013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2103
2104 * window.h (struct window): Convert window_end_pos and
2105 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
2106 (wset_window_end_pos, wset_window_end_vpos): Remove.
2107 * dispnew.c (adjust_glyph_matrix):
2108 * window.c (Fwindow_end, replace_window, set_window_buffer)
2109 (make_window):
2110 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
2111 (set_vertical_scroll_bar, redisplay_window, try_window)
2112 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
2113 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
2114 (note_mouse_highlight): Adjust users.
2115 (try_cursor_movement): Likewise. Convert old precondition to eassert.
2116 Add comment.
2117
da5707e8
DA
21182013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2119
2120 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
2121 * image.c (imagemagick_filename_hint): Use `const char *' and
2122 prefer SSDATA to SDATA to avoid warnings.
2123
25554267
DA
21242013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2125
2126 Cleanup window fringes, margins and scroll bars adjustments.
2127 * window.c (set_window_fringes, set_window_margins)
2128 (set_window_scroll_bars, apply_window_adjustment): New functions.
2129 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
2130 (Fset_window_scroll_bars): Use them.
2131
38a2c910
DA
21322013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2133
2134 * window.h (struct window): Convert scroll_bar_width
2135 from Lisp_Object to integer. Adjust comment.
2136 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
2137 Adjust users.
2138 * window.c (wset_scroll_bar_width): Remove.
2139 (make_window): Initialize scroll_bar_width.
2140 (Fsplit_window_internal): Use direct assignment.
2141 (Fset_window_configuration, save_window_save):
2142 Convert Lisp_Object to integer and back where appropriate.
2143 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
2144 bar was actually changed, and mention this in docstring.
2145
2d065031
PE
21462013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 * decompress.c: Minor simplifications.
2149 (Fzlib_decompress_region): Don't bother verifying
2150 that avail_out <= UINT_MAX, as that was confusing.
2151 Mention the restriction in a comment instead.
2152 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
2153
a5bd5abb
JD
21542013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2155
2156 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
2157 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
2158
66e7901a
LMI
21592013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2160
2161 * image.c (imagemagick_filename_hint): Check for errors in the
2162 alist structure.
2163
2fa611b7
EZ
21642013-08-13 Eli Zaretskii <eliz@gnu.org>
2165
2166 * window.c (Fwindow_margins): Return nil when there's no marginal
2167 area, as per the documented API.
2168
2169 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
2170 Fmake_vector, as scroll bar's struct members are not all Lisp
2171 objects now. This avoids crashes in GC.
2172
2173 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
2174 bool, so its address could be taken.
2175
8259030d
LMI
21762013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2177
2178 * image.c (imagemagick_filename_hint): New function to possibly
2179 apply `image-content-type-suffixes'.
2180 (imagemagick_load_image): Use it.
2181
866c710e
EZ
21822013-08-13 Eli Zaretskii <eliz@gnu.org>
2183
2184 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
2185 if loading zlib failed.
2186
f10490f0
JD
21872013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2188
96311be7
JD
2189 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
2190 2013-08-13 checkin below. Change bool to BOOL, rule is:
2191 All Obj-C code uses BOOL, except for interfaces callable from C.
2192
f10490f0
JD
2193 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
2194
c8ae93b0
DA
21952013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2196
2197 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
2198 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
2199 bool instead of BOOL.
2200 * w32term.h (struct scroll_bar): Convert fringe_extended_p
2201 from Lisp_Object to bitfield. Adjust comment.
2202 * w32term.c (x_scroll_bar_create): Adjust user.
2203 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
2204 * xterm.c (XTset_vertical_scroll_bar): Likewise.
2205 Use bool for boolean.
2206 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
2207 to `unsigned int' when defining a bitfield.
2208
53b64418
PE
22092013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
2212
eeaf9bf3
DA
22132013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2214
2215 * window.h (struct window): Convert left_margin_cols and
2216 right_margin_cols from Lisp_Objects to integers. Adjust comment.
2217 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
2218 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
2219 Adjust users.
2220 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
2221 Adjust comment.
2222 (showing_window_margins_p, update_window_line, update_frame_1):
2223 * fringe.c (draw_fringe_bitmap_1):
2224 * xdisp.c (window_box_width): Adjust users.
2225 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
2226 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
2227 Use direct assignment.
2228 (Fset_window_configuration, save_window_save, Fwindow_margins):
2229 Convert Lisp_Object to integer and back where appropriate.
2230 (Fset_window_margins): Adjust user. Return t if any margin
2231 was actually changed, and mention this in docstring.
2232
956720af
XF
22332013-08-13 Xue Fuqiao <xfq.free@gmail.com>
2234
f73f4ce6 2235 * syntax.c (forward_word):
956720af
XF
2236 * cmds.c (forward_char, backward_char): Mention the optional argument.
2237
9e37ee3b
DA
22382013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2239
2240 * window.h (struct window): Convert left_fringe_width
2241 and right_fringe_width from Lisp_Objects to integers.
2242 Adjust comment.
2243 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
2244 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
2245 * window.c (wset_left_fringe_width, wset_right_fringe_width):
2246 Remove.
2247 (make_window): Initialize new integer fields to -1.
2248 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
2249 (Fset_window_configuration, save_window_save):
2250 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
2251 (Fset_window_fringes): Adjust user. Return t if any fringe
2252 was actually changed, and mention this in docstring.
2253
e4375ca7
DA
22542013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2255
2256 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
2257 * nsfns.m (x_set_cursor_type):
2258 * w32fns.c (x_set_cursor_type):
2259 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
2260 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 2261
a45543bc
DA
22622013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2263
2264 * font.c (clear_font_cache): New function, stripped from...
2265 (Fclear_font_cache): ...here, which now uses the function
2266 above. Adjust comment.
2267 * font.h (clear_font_cache): Add prototype.
2268 * xfaces.c (clear_face_cache): Use clear_font_cache.
2269
ae966a86
DA
22702013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2271
2272 * window.c (Fset_window_start): Compare `w', not `window' because
2273 `w' might not be equal to `window' after call to decode_live_window.
2274
297a545b
PE
22752013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2276
2277 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
2278 This fixes a problem introduced by the Bug#15035 patch
2279 when using GPG. Reported by Herbert J. Skuhra.
2280
aa942e2b
EZ
22812013-08-12 Eli Zaretskii <eliz@gnu.org>
2282
2283 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
2284 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
2285 not yet initialized.
2286
7699d09e
LMI
22872013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2288
2289 * decompress.c (Fzlib_decompress_region): Support zlib
2290 decompression, too, and rename.
2291
1d238bc7
PE
22922013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 Minor zlib configuration tweaks.
2295 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
2296 Don't assume presence of fn_inflateInit2_ zlib internal function.
2297
8a44a184
LMI
22982013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2299
2300 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
2301 include the zlib prefix.
2302
594a4307
EZ
23032013-08-12 Eli Zaretskii <eliz@gnu.org>
2304
2305 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
2306 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
2307 define static variables that are pointers to zlib functions to be
2308 dynamically loaded.
2309 (init_zlib_functions) [WINDOWSNT]: New function.
2310 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
2311 New macros.
2312 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
2313 macros instead of invoking the zlib functions directly.
068f9124
SM
2314 (syms_of_decompress): DEFSYM Qzlib_dll.
2315 Staticpro Szlib_available_p.
594a4307 2316
d2e113bc
DA
23172013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
2318
2319 Avoid looping over all frame windows to freeze and unfreeze.
2320 * window.h (struct window): Drop frozen_window_start_p.
2321 (freeze_window_starts): Drop prototype.
2322 * frame.h (struct frame): New frozen_window_starts flag.
2323 (FRAME_WINDOWS_FROZEN): New macro.
2324 * window.c (freeze_window_start, freeze_window_starts):
2325 Remove.
2326 (select_window, replace_window): Adjust users.
2327 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2328 (window_frozen_p): New function.
2329 (redisplay_window): Use it.
2330
94fcd171
PE
23312013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 Fix some fd issues when running subprocesses (Bug#15035).
2334 Fix bugs that can leak files or file descriptors on errors.
2335 Don't unlink open temp files, as that's hard for users to diagnose
2336 when things go awry (e.g., temp disk exhausted).
2337 Don't bother to lock temp files. Check for invalid recursion.
2338 * callproc.c (synch_process_fd): Remove. All uses removed.
2339 (synch_process_tempfile): New var or macro.
2340 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2341 New constants.
2342 (record_kill_process): New arg, the temp name. All callers changed.
2343 (delete_temp_file): Now just a simple wrapper around unlink.
2344 (call_process_kill): New arg, the call_process_fd array.
2345 Close them all. Clear synch_process_pid. Remove the temp file,
2346 or arrange for it to be removed.
2347 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2348 that's been moved to synch_process_tempfile. Caller changed.
2349 Do not remove the tempfile; that's now call_process_kill's
2350 responsibility.
2351 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2352 call_process_kill; the caller now does that.
2353 (call_process_cleanup): Do not close the process fd; that's now
2354 call_process_kill's responsibility.
2355 (Fcall_process): Implement via new function call_process, which
2356 has most of the old body of Fcall_process, but with a different API.
2357 (call_process): New function that does not open or close filefd if
2358 it is nonnegative. Record which fds need to be closed, and let
2359 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2360 Signal an error if invoked recursively (could be done via a hook).
2361 Simplify creation of the tempfile in the MSDOS case.
2362 Don't create the output file until after checking for the executable.
2363 Report any failure to open /dev/null.
2364 Don't open /dev/null for writing twice; once is enough.
2365 Don't create pipe if all output is being discarded or sent to file.
2366 Don't worry about setting up the coding system or reading from the
2367 pipe if all output is being discarded.
2368 Hoist fd_error local into top level, to lessen block nesting.
2369 Don't record deleted pid here; now done by Fcall_process_region.
2370 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2371 and note its success in synch_process_tempfile.
2372 Do not leak resources when child_setup fails.
2373 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2374 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2375 (create_temp_file): Now returns open fd, with an additional
2376 Lisp_Object * argument to return the name. All callers changed.
2377 Do not close the file; rewind it instead, and leave it open for
2378 the caller. Do not lock the temp file. Unwind-protect the file
2379 and the file-descriptor.
2380 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2381 If an asynchrounous process, record it here, not in call_process.
2382 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2383 * eval.c (set_unwind_protect): New function.
2384 * fileio.c (write_region): New function, generalized from the
2385 old Fwrite_region. Do not lock temp files.
2386 (Fwrite_region): Use it.
2387 * lisp.h (set_unwind_protect, write_region): New decls.
2388 * process.c: Include <verify.h>.
2389 (make_process): Mark fds as initially closed.
2390 (deleted_pid_list): Now a list of pid-filename pairs.
2391 All uses changed.
2392 (close_process_fd): New function.
2393 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2394 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2395 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2396 (create_process, create_pty, Fmake_serial_process)
2397 (server_accept_connection): Record which fds need to be closed,
2398 and let deactivate_process close them.
2399 (Fmake_network_process): Do not discard the unwind-protect
2400 until it's safe to do so.
2401 (deactivate_process): Close the fds opened by create_process etc.
2402 (Fprocess_send_eof): Adjust to new way of recording open fds.
2403 Report an error if /dev/null can't be opened, instead of aborting.
2404 * process.h (PROCESS_OPEN_FDS): New constant.
2405 (struct Lisp_Process): New member open_fds.
2406 (record_kill_process, record_deleted_pid): Adjust signatures.
2407 (record_deleted_pid): Move decl here ...
2408 * syswait.h (record_deleted_pid): ... from here.
2409
d0e615c3
PE
24102013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 * decompress.c: Fix bugs with large buffers and weird inputs.
2413 Tune a bit. Reindent as per usual Emacs style.
2414 (BUFFER_SIZE): Remove.
2415 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2416 more than UINT_MAX bytes. Decompress into the gap instead of into
2417 an auto buffer, as this should avoid copying. Return nil if
2418 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2419 set immediate_quit; we shouldn't trust zlib code that much.
2420
313546eb
LMI
24212013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2422
99a32242
LMI
2423 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2424 errors, and really move the gap to where we want it.
2425
313546eb
LMI
2426 * lisp.h: Include decompress.c support.
2427
2428 * emacs.c (main): Include decompress.c support.
2429
2430 * Makefile.in: Include -lz if present.
2431
d2d699ac
JD
24322013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2433
f90e3ebd
JD
2434 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2435 (initWithTitle:): Initialize frame to 0.
2436 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2437 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2438 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2439
2440 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2441 fillWithWidgetValue:frame:
2442
423d3b3f
JD
2443 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2444 remove memory leak warnings.
2445
d2d699ac
JD
2446 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2447 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2448 menu_pending_title.
2449
2450 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2451 (x_activate_menubar): Update the whole menu.
2452 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2453 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2454 current event is not NSSystemDefined (Bug#15001).
2455 Call ns_check_menu_open only if trackingMenu is 2.
2456 (menuDidClose:): New method, decrease trackingMenu.
2457 (fillWithWidgetValue:setDelegate:): New method.
2458 (fillWithWidgetValue:): Call the above.
2459
2460 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2461
7d652d97
PE
24622013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 Omit some unnecessary casts.
2465 Many of these go back to the old pre-C89 days, when they may have
2466 been needed, but we've been assuming C89 or later for a while now.
2467 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2468 (live_float_p, live_misc_p, live_vector_p):
2469 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2470 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2471 (defvar_per_buffer):
2472 * callint.c (Fcall_interactively):
2473 * doc.c (Fsubstitute_command_keys):
2474 * filelock.c (get_boot_time):
2475 * frame.c (xrdb_get_resource):
2476 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2477 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2478 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2479 (menuitem_highlight_callback, menu_destroy_callback)
2480 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2481 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2482 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2483 (xg_tool_bar_help_callback, tb_size_cb):
2484 * image.c (xpm_alloc_color, png_read_from_memory)
2485 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2486 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2487 (syms_of_image):
2488 * keymap.c (describe_map):
2489 * nsfns.m (Fns_display_monitor_attributes_list):
2490 * nsmenu.m (process_dialog:):
2491 * nsterm.m (hold_event):
2492 * process.c (wait_reading_process_output):
2493 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2494 * scroll.c (do_direct_scrolling, scrolling_1):
2495 * termcap.c (tgetent):
2496 * window.c (check_window_containing, add_window_to_list)
2497 (freeze_window_starts):
2498 * xdisp.c (compare_overlay_entries, vmessage):
2499 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2500 (x_get_monitor_attributes_xrandr)
2501 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2502 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2503 * xfont.c (xfont_match, xfont_open):
2504 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2505 (menubar_selection_callback, menu_position_func)
2506 (popup_selection_callback, create_and_show_popup_menu)
2507 (dialog_selection_callback, create_and_show_dialog):
2508 * xrdb.c (x_get_string_resource):
2509 (main) [TESTRM]:
2510 * xsmfns.c (x_session_check_input):
2511 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2512 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2513 (xaw_jump_callback, xaw_scroll_callback):
2514 Omit unnecessary casts.
2515
9acc1074
PE
25162013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 Minor string-length refactoring.
2519 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2520 * frame.c (make_monitor_attribute_list):
2521 Prefer build_string to strlen + make_string.
2522
361c0eb8
JD
25232013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2524
2525 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2526 don't check minor_code (Bug#14417).
2527
14ba0822
EZ
25282013-08-09 Eli Zaretskii <eliz@gnu.org>
2529
2530 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2531 vertical positions instead. This avoids calling MATRIX_ROW with
2532 row numbers that are possibly beyond valid limits. (Bug#15064)
2533
309f24d1
DA
25342013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2535
2536 Use xstrdup and build_unibyte_string where applicable.
2537 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2538 * xfns.c (x_window):
2539 * xrdb.c (x_get_customization_string):
2540 * xterm.c (xim_initialize):
2541 * w32fns.c (w32_window): Use xstrdup.
2542 (w32_display_monitor_attributes_list):
2543 * emacs.c (init_cmdargs):
2544 * keyboard.c (PUSH_C_STR):
2545 * nsfont.m (nsfont_open):
2546 * sysdep.c (system_process_attributes):
2547 * w32.c (system_process_attributes):
2548 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2549
55902276
EZ
25502013-08-09 Eli Zaretskii <eliz@gnu.org>
2551
2552 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2553 variables of these types so that GDB would know about them, as aid
2554 for debugging fatal exceptions. (Bug#15024) See also
2555 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2556 discussions.
2557
10bf7f5a
JD
25582013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2559
2560 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2561 larger than the NSWindow (Bug#14934).
2562
65620264
DA
25632013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2564
2565 Redesign redisplay interface to drop global variable updated_window.
2566 Always pass currently updated window as a parameter to update routines.
2567 * dispextern.h (updated_window): Remove declaration.
2568 (struct redisplay_interface): Pass window parameter to
2569 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2570 and after_update_window_hook.
2571 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2572 Adjust prototypes.
2573 * dispnew.c (updated_window): Remove.
2574 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2575 (update_window_line): Adjust to match redisplay interface changes.
2576 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2577 (ns_scroll_run, ns_after_update_window_line):
2578 * w32term.c (x_update_window_begin, x_update_window_end)
2579 (x_after_update_window_line, x_scroll_run):
2580 * xterm.c (x_update_window_begin, x_update_window_end)
2581 (x_after_update_window_line, x_scroll_run):
2582 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2583 Likewise. Adjust comments where appropriate.
2584 (x_cursor_to): Simplify because this is always called during window
2585 update (but install debugging check anyway).
2586 (expose_window): Check must_be_updated_p flag to see whether this
2587 function is called during window update.
2588
628fdc56
DA
25892013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2590
2591 Do not reset window modification event counters excessively.
2592 These leftovers and poor man's tricky methods to catch extra
2593 redisplay's attention are no longer needed.
2594 * frame.c (set_menu_bar_lines_1):
2595 * minibuf.c (read_minibuf_unwind):
2596 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2597 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2598 (window_scroll_line_based, Fset_window_configuration):
2599 * xdisp.c (redisplay_window): Do not reset last_modified and
2600 last_overlay_modified counters.
2601
8fd9c92e
JD
26022013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2603
2604 * xselect.c (x_send_client_event): Set send_event and serial, memset
2605 data.l as it might be bigger than data.b. Use 24 bit mask to
2606 XSendEvent (Bug#15034).
2607
0ee18172
EZ
26082013-08-07 Eli Zaretskii <eliz@gnu.org>
2609
2610 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2611 for TTY frames that are not the top frame on their console.
2612 (Bug#14616)
2613
16ddd1a6
MR
26142013-08-07 Martin Rudalics <rudalics@gmx.at>
2615
2616 * w32term.c (w32fullscreen_hook): Really maximize frame when
2617 asked for (Bug#14841).
2618
d2a95ffb
DA
26192013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2620
2621 Prefer selected_window to Fselected_window, likewise for frames.
2622 * buffer.c (Fbuffer_swap_text):
2623 * data.c (Fvariable_binding_locus):
2624 * window.c (run_window_configuration_change_hook): Adjust users.
2625 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2626 Use decode_live_frame.
2627
170da1ec
DA
26282013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2629
2630 Be more careful if selected window shows the buffer other than current,
2631 use window_outdated only if this is not so. This change should also
2632 address some weird issues discussed in Bug#13012.
2633 * window.h (window_outdated): New prototype.
2634 * window.c (window_outdated): Now here. Convert from static and
2635 always assume window's buffer.
2636 (Fwindow_end, Fwindow_line_height): Use it.
2637 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2638 and always assume window's buffer.
2639 (redisplay_window): Adjust user.
e5eefe9b 2640 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2641 check whether mode line should be updated only if selected window
2642 shows current buffer.
2643 (run_window_scroll_functions): Use eassert for debugging check.
2644 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2645
56b5d5b1
DA
26462013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2647
2648 * window.c (window_scroll, window_scroll_pixel_based)
2649 (window_scroll_line_based): Use bool for booleans.
2650
2878ba7e
PE
26512013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2652
2653 * process.c: Fix minor off-by-one issues in descriptor counts.
2654 This shouldn't fix any real bugs, but it cleans up the code a bit.
2655 (max_process_desc, max_input_desc): -1, not 0, means none.
2656 All uses changed.
2657 (delete_input_desc): New function.
2658 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2659 (deactivate_process): Scan backwards when recomuting max_process_desc;
2660 that should be faster.
2661 (init_process_emacs): Initialize max_input_desc.
2662
e30b79c1
DA
26632013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2664
2665 Use region cache to speedup bidi_find_paragraph_start.
2666 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2667 Rename cache_long_line_scans to cache_long_scans.
2668 * buffer.c (bset_cache_long_line_scans): Rename to
2669 bset_cache_long_scans.
2670 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2671 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2672 into account.
2673 (syms_of_buffer): Rename cache-long-line-scans to
2674 cache-long-scans. Adjust docstring.
2675 * search.c (newline_cache_on_off):
2676 * indent.c (width_run_cache_on_off): Adjust users.
2677 * bidi.c (bidi_paragraph_cache_on_off): New function.
2678 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2679 * insdel.c (prepare_to_modify_buffer):
2680 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2681
00012b86
DA
26822013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2683
2684 Invalidate region caches only if buffer text is going to be changed.
2685 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2686 (modify_text): ...new prototype.
2687 (prepare_to_modify_buffer_1): New prototype.
2688 * textprop.c (modify_region): Rename to...
2689 (modify_text_properties): ...new function.
2690 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2691 (Fremove_list_of_text_properties): Adjust users.
2692 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2693 (modify_text): ...new function.
2694 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2695 (prepare_to_modify_buffer_1): ...new function.
2696 * casefiddle.c (casify_region):
2697 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2698 (Ftranspose_regions): Use modify_text.
2699
dc6c0eda
SM
27002013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2701
2702 * lisp.mk (lisp): Add nadvice.elc.
2703
8f3a2c26
DA
27042013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2705
2706 New macro to iterate over live buffers similar to frames.
2707 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2708 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2709 Declare buffer-related variables here to offload lisp.h.
2710 * buffer.c (Vbuffer_alist): Adjust comment.
2711 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2712 (other_buffer_safely):
2713 * data.c (store_symval_forwarding):
2714 * dispnew.c (Fframe_or_buffer_changed_p):
2715 * fileio.c (Fdo_auto_save):
2716 * filelock.c (unlock_all_files):
2717 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2718
e0fdb694
PE
27192013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2722 * callproc.c (create_temp_file):
2723 * filelock.c (create_lock_file):
2724 Assume mkostemp, since it's now provided by Gnulib.
2725
63f5c6c2
EZ
27262013-08-04 Eli Zaretskii <eliz@gnu.org>
2727
2728 * w32.c (mkostemp): New function.
2729 (mktemp): Remove, no longer used. Most of the code reused in
2730 mkostemp. (Bug#15015)
484ab239 2731 (mktemp): Don't undef.
63f5c6c2 2732
f0b79313
DA
27332013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2734
2735 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2736 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2737 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2738 (free_glyph_pool, check_glyph_memory): Likewise for
2739 all users. Adjust comments where appropriate.
2740
98f638d6
PE
27412013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 * composite.h: Minor fixups.
2744 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2745 to fix a misspelling, and change it to an inline function while
2746 we're at it (it need not be a macro). All uses changed.
2747 (composition_method, composition_valid_p):
2748 Rewrite to avoid assignments in if-conditions.
2749
75c59fb3
DA
27502013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2751
2752 Do not use global Lisp_Object in composition macros.
2753 * composite.h (composition_temp): Remove declaration.
2754 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2755 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2756 (compose_region): Remove the leftover.
75c59fb3
DA
2757 * composite.c (composition_temp): Remove.
2758 (run_composition_function, update_compositions)
2759 (composition_compute_stop_pos, composition_adjust_point)
2760 (Ffind_composition_internal):
2761 * coding.c (handle_composition_annotation):
2762 * xdisp.c (handle_composition_prop, check_point_in_composition):
2763 Related users changed.
2764
a10c8269
DA
27652013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2766
2767 Drop FRAME_PTR typedef.
2768 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2769 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2770 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2771 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2772 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2773 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2774 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2775 All related users changed.
2776
a104f656
SM
27772013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2778
2779 * eval.c (default_toplevel_binding): New function.
2780 (Fdefvar): Use it.
2781 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2782 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2783 (syms_of_eval): Export them.
2784 * data.c (Fdefault_value): Micro cleanup.
2785 * term.c (init_tty): Use "false".
2786
4b5c9326
DA
27872013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2788
2789 Fix X GC leak in GTK and raw (no toolkit) X ports.
2790 * xterm.c (x_free_frame_resources): If white and black relief
2791 GCs are allocated, always free them here.
2792 * xfns.c (x_make_gc): Omit redundant initialization.
2793 * widget.c (create_frame_gcs): Remove the leftover.
2794 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2795 in x_free_frame_resources.
2796
b19aa636
JD
27972013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2798
2799 * nsterm.m (windowWillResize:toSize:): Only change title if
2800 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2801 modifying it.
2802 (viewDidEndLiveResize): New method.
2803
2804 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2805 inside NS_IMPL_COCOA.
2806
af1f7e06
DA
28072013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2808
2809 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2810 Do not check whether undo is enabled because record_insert and
2811 record_delete does that themselves.
2812
65b02bb9
DA
28132013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2814
2815 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2816 member which is not really used any more.
2817 (FRAME_XIC_BASE_FONTNAME): Remove.
2818 * xfns.c (xic_free_fontset): Adjust user.
2819 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2820 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2821 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2822 (xdialog_show): Use eassert for debugging check.
7ee0f047 2823 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2824
6318cde0
PE
28252013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2826
2827 * fileio.c, fns.c (merge): Move extern decl from here ...
2828 * lisp.h (merge): ... to here.
2829
6c1a09ba
DA
28302013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2831
2832 Fix last font-related change.
2833 * w32font.h (w32font_list_internal, w32font_match_internal):
2834 Fix prototype.
2835 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2836 (uniscribe_list_family): Adjust to match font API change.
2837 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2838 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2839
f8c20208
DA
28402013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2841
2842 * frame.h (FRAME_MOUSE_UPDATE):
2843 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2844 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2845
fdb396e2
DA
28462013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2847
2848 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2849 * font.h (struct font_driver): Change list, match, and list_family
2850 functions to accept struct frame * as first arg.
068f9124
SM
2851 * font.c (font_score, font_compare, font_sort_entities):
2852 Remove prototypes.
fdb396e2
DA
2853 (font_sort_entities, font_list_entities, font_select_entity):
2854 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2855 match font API change.
2856 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2857 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2858 * ftxfont.c (ftxfont_list, ftxfont_match):
2859 * xftfont.c (xftfont_list, xftfont_match):
2860 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2861 * w32font.c (w32font_list, w32font_match, w32font_list):
2862 (w32font_list_internal, w32_font_match_internal): Likewise.
2863 * xfaces.c (Fx_family_fonts): Adjust user.
2864
52b8a085
DA
28652013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2866
2867 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2868 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2869 only if HAVE_X_WINDOWS is in use.
2870 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2871 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2872 * w32term.c (x_wm_set_icon_position): Likewise.
2873 * w32fns.c (x_icon): Adjust user.
2874
c791c18e
DA
28752013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2876
2877 * xterm.c (last_mouse_press_frame): Remove the
2878 leftover which is not really used any more.
2879 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2880 (x_flush): Call XFlush once per each X display, not frame.
2881 This is better because this code always unconditionally skips
2882 non-X frames in Vframe_list and issues the only XFlush if we
2883 have more than one X frame on the same X display.
2f935d86
DA
2884 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2885 Use bool for booleans.
2886 (x_draw_glyph_string_background, cvt_string_to_pixel):
2887 (cvt_pixel_dtor): Drop unnecessary prototypes.
2888 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2889
f435830e
DA
28902013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2891
2892 Drop unnecessary functions that deals with frame pixel size.
2893 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2894 (x_pixel_height): Drop prototypes.
2895 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2896 (x_pixel_height): Drop implementations.
2897 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2898 which should be always valid for window frame.
2899 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2900 * w32menu.c (Fx_popup_dialog):
2901 * xmenu.c (Fx_popup_dialog): Likewise for both.
2902
84231434
DA
29032013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2904
2905 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2906 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2907 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2908 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2909 and mention nil frame in docstring.
84231434 2910
959067a1
DA
29112013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2912
2913 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2914 (x_figure_window_size): Likewise. Adjust to return long.
2915 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2916 (toplevel): Move Qterminal_live_p to...
2917 * terminal.c (toplevel): ...here, make it static, and...
2918 (syms_of_terminal): ...DEFSYM here.
2919 * frame.h (Qterminal_live_p): Remove declaration.
2920 (make_frame, x_figure_window_size): Adjust prototype.
2921 * nsfns.m (Fx_create_frame): Use long for window flags.
2922
f4b169ce
PE
29232013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2924
2925 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2926 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2927 Do not assume that emacs_close (INT_MAX) is a no-op.
2928
bee6a2c7
DA
29292013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2930
2931 * xfaces.c (make_face_cache): For struct face_cache, prefer
2932 xmalloc to xzalloc and so avoid redundant call to memset.
2933 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2934
d7e6881a
DA
29352013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2936
2937 * fringe.c (draw_window_fringes, update_window_fringes)
2938 (compute_fringe_widths):
2939 * w32term.c (x_draw_glyph_string):
2940 * window.c (candidate_window_p, Frecenter):
2941 * xfaces.c (realize_basic_faces, realize_default_face)
2942 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2943 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2944 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2945 * xmenu.c (Fx_menu_bar_open_internal):
2946 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2947 * xsettings.c (xft_settings_event):
2948 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2949 Use bool for booleans. Adjust style and comments where
2950 appropriate.
2951 * dispextern.h (draw_window_fringes, update_window_fringes)
2952 (compute_fringe_widths):
2953 * xterm.h (x_had_errors_p): Adjust prototype.
2954
ec3058af
DA
29552013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2956
2957 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2958 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2959
218e0637
DA
29602013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2961
2962 * fns.c (toplevel): Remove comment before Fsafe_length because
2963 it checks for QUIT.
2964
e560aba9
PE
29652013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2966
2967 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2968
2e5ce5de
EZ
29692013-07-28 Eli Zaretskii <eliz@gnu.org>
2970
2971 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2972 frame which got the message is still alive, before dereferencing
2973 its pointer. (Bug#14970)
2974
2975 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2976 be a live window, before using it as such. (Bug#14970)
2977
e95da6d3
EZ
29782013-07-27 Eli Zaretskii <eliz@gnu.org>
2979
2980 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2981 w32_detect_focus_change instead of doing part of its job by hand.
2982 This fixes the problem whereby FOCUS_OUT events were not sent to
2983 the event queue.
2984
a8f93651
EZ
29852013-07-26 Eli Zaretskii <eliz@gnu.org>
2986
fec92060
EZ
2987 * process.c (Fprocess_list): Doc fix.
2988
a8f93651
EZ
2989 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2990 being re-exposed only if it didn't ask to become visible.
2991 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2992 was previously iconified. (Bug#14841)
2993 (x_iconify_frame): Mark the frame iconified.
2994
d5a7a9d9
PE
29952013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2996
2997 Fix minor problems found by static checking.
2998 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2999 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
3000
56ea7291
SM
30012013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3002
3003 * eval.c (set_specpdl_old_value): New function.
3004 (unbind_to): Minor simplification.
3005 (get_backtrace_frame): New function.
3006 (Fbacktrace_frame): Use it. Add `base' argument.
3007 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
3008 (syms_of_eval): Export backtrace-eval.
3009 * xterm.c (x_focus_changed): Simplify.
3010
9d611ffe
PE
30112013-07-25 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
3014
999c74e3
EZ
30152013-07-24 Eli Zaretskii <eliz@gnu.org>
3016
3017 * xdisp.c (redisplay_window): Instead of moving point out of
3018 scroll margin, reject the force_start method, and try scrolling
3019 instead. (Bug#14780)
3020
198fa217
KB
30212013-07-24 Ken Brown <kbrown@cornell.edu>
3022
3023 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
3024 (Bug#14944).
3025
53840e55
PE
30262013-07-24 Paul Eggert <eggert@cs.ucla.edu>
3027
3028 * eval.c (Fprogn): Do not check that BODY is a proper list.
3029 This undoes the previous change. The check slows down the
3030 interpreter, and is not needed to prevent a crash. See
3031 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
3032
60967f56
GM
30332013-07-23 Glenn Morris <rgm@gnu.org>
3034
3035 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
3036
9ca960e2
PE
30372013-07-23 Paul Eggert <eggert@cs.ucla.edu>
3038
a29c3e6d
PE
3039 Port to GNU/Linux systems with tinfo but not ncurses.
3040 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
3041 to decide whether ncurses is being used. Without this change,
3042 GCC complains about tgetent not being declared, on a system
3043 that has tinfo installed but ncurses not installed.
3044
f274311c
PE
3045 * eval.c (Fprogn): Check that BODY is a proper list.
3046
16b0520a
PE
3047 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
3048 * data.c (Fsetq_default):
3049 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
3050 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
3051 (Fcondition_case):
3052 Tune by taking advantage of the fact that ARGS is always a list
3053 when a function is declared to have UNEVALLED args.
3054
9ca960e2
PE
3055 * emacsgtkfixed.c: Port to GCC 4.6.
3056 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
3057
afacaa1b
JB
30582013-07-23 Juanma Barranquero <lekktu@gmail.com>
3059
3060 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
3061 here to silence compiler warnings.
3062
368a85a4
PE
30632013-07-22 Paul Eggert <eggert@cs.ucla.edu>
3064
3065 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
3066 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
3067 from messing up Emacs's 'struct frame' (Bug#14923).
3068
f4e891b5
PE
30692013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 * alloc.c (make_save_ptr_ptr): Define this function.
3072 It was inadvertently omitted. It's needed only if
3073 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
3074
96c8b65e
JD
30752013-07-21 Jan Djärv <jan.h.d@swipnet.se>
3076
3077 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
3078 frame have focus (Bug#14895).
3079
ee010797
PE
30802013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 Avoid vfork-related deadlock more cleanly.
3083 * callproc.c (child_setup): When the child's exec fails, output
3084 the program name, as that's more useful. Use O_NONBLOCK to avoid
3085 deadlock.
3086 * process.c (create_process_1): Remove; no longer needed.
3087 (create_process): Remove timer hack; no longer needed, now that
3088 the child avoids deadlock.
3089
f0398ec1 30902013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
3091
3092 * image.c (Fimage_flush): Fix doc typo.
3093
b2a069c2
PE
30942013-07-20 Paul Eggert <eggert@cs.ucla.edu>
3095
6496aec9
PE
3096 Fix array bounds violation when pty allocation fails.
3097 * process.c (PTY_NAME_SIZE): New constant.
3098 (pty_name): Remove static variable; it's now auto.
3099 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
3100 Take pty_name as an arg rather than using a static variable.
3101 All callers changed.
3102 (create_process): Recover pty_flag from process, not from volatile local.
3103 (create_pty): Stay inside array even when pty allocation fails.
3104 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
3105
b2a069c2
PE
3106 * lread.c (Fload): Avoid initialization only when lint checking.
3107 Mention that it's needed only for older GCCs.
3108
99107004
KH
31092013-07-20 Kenichi Handa <handa@gnu.org>
3110
3111 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
3112 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
3113
6b1b199d
AS
31142013-07-20 Andreas Schwab <schwab@linux-m68k.org>
3115
3116 * lread.c (Fload): Avoid uninitialized warning.
3117
4195afc3
PE
31182013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3119
3f5bef16
PE
3120 Fix some minor file descriptor leaks and related glitches.
3121 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
3122 (create_lock_file): Use write, not emacs_write.
3123 * image.c (slurp_file, png_load_body):
3124 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
3125 (server_accept_connection):
3126 Don't leak an fd on memory allocation failure.
3127 * image.c (slurp_file): Add a cheap heuristic for growing files.
3128 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
3129 as that's what the other routines do. Maybe input need not be
3130 blocked at all, but it's better to be consistent.
3131 Avoid undefined behavior when strlen is zero.
3132
4195afc3
PE
3133 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
3134 (NSTATICS): Now a constant; doesn't need to be a macro.
3135
a1aeeffe
RS
31362013-07-19 Richard Stallman <rms@gnu.org>
3137
3138 * coding.c (decode_coding_utf_8): Add simple loop for fast
3139 processing of ASCII characters.
3140
63b34baa
PE
31412013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
3144
621dd9ac
EZ
31452013-07-19 Eli Zaretskii <eliz@gnu.org>
3146
3147 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
3148 unportable 'struct x_display_info'.
3149 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
3150 is a portable type.
3151
1396ac86
PE
31522013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3153
ab9980cd
PE
3154 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
3155 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
3156 or fscanf fails.
3157 (system_process_attributes): Prefer plain char to unsigned char
3158 when either will do. Clean up properly if interrupted or if
068f9124
SM
3159 memory allocations fail. Don't assume sscanf succeeds.
3160 Remove no-longer-needed workaround to stop GCC from whining.
3161 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
3162 bit more carefully.
3163
1396ac86
PE
3164 Fix obscure porting bug with varargs functions.
3165 The code assumed that int is treated like ptrdiff_t in a vararg
3166 function, which is not a portable assumption. There was a similar
3167 -- though these days less likely -- porting problem with various
3168 assumptions that pointers of different types all smell the same as
3169 far as vararg functions is conserved. To make this problem less
3170 likely in the future, redo the API to use varargs functions.
3171 * alloc.c (make_save_value): Remove this vararg function.
3172 All uses changed to ...
3173 (make_save_int_int_int, make_save_obj_obj_obj_obj)
3174 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
3175 New functions.
3176 (make_save_ptr): Rename from make_save_pointer, for consistency with
3177 the above. Define only on platforms that need it. All uses changed.
3178
4d19d194
PE
31792013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 * keyboard.c: Try to fix typos in previous change.
3182 (DISPLAY_LIST_INFO): New macro.
3183 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 3184 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 3185
945c5bb1
JB
31862013-07-18 Juanma Barranquero <lekktu@gmail.com>
3187
3188 * keyboard.c (kbd_buffer_get_event):
3189 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
3190 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
3191
f4b1eb36
PE
31922013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3193
5e679a2c
PE
3194 * filelock.c: Fix unlikely file descriptor leaks.
3195 (get_boot_time_1): Rework to avoid using emacs_open.
3196 This doesn't actually fix a leak, but is better anyway.
3197 (read_lock_data): Use read, not emacs_read.
3198
a8cd4836
PE
3199 * doc.c: Fix minor memory and file descriptor leaks.
3200 * doc.c (get_doc_string): Fix memory leak when doc file absent.
3201 (get_doc_string, Fsnarf_documentation):
3202 Fix file descriptor leak on error.
3203
ef30e638
PE
3204 * term.c: Fix minor fdopen-related file descriptor leaks.
3205 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
3206 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
3207
f4b1eb36
PE
3208 * charset.c: Fix file descriptor leaks and errno issues.
3209 Include <errno.h>.
3210 (load_charset_map_from_file): Don't leak file descriptor on error.
3211 Use plain record_xmalloc since the allocation is larger than
3212 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
3213 of entries.
3214 * eval.c (record_unwind_protect_nothing):
3215 * fileio.c (fclose_unwind):
3216 New functions.
3217 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
3218 The replacement doesn't block input, but that no longer seems
3219 necessary.
3220
b648c163
PE
32212013-07-17 Paul Eggert <eggert@cs.ucla.edu>
3222
a0931322
PE
3223 * lread.c: Fix file descriptor leaks and errno issues.
3224 (Fload): Close some races that leaked fds or streams when 'load'
3225 was interrupted.
3226 (Fload, openp): Report error number of last nontrivial failure to open.
3227 ENOENT counts as trivial.
3228 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
3229 New functions.
3230 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
3231 now that the function is always called with a nonnegative arg.
3232 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
3233 All uses replaced with ...
3234 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
3235
b648c163
PE
3236 A few more minor file errno-reporting bugs.
3237 * callproc.c (Fcall_process):
3238 * doc.c (Fsnarf_documentation):
3239 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
3240 * process.c (set_socket_option):
3241 Don't let a constructor trash errno.
3242 * doc.c: Include <errno.h>.
3243
b1dc4084
JB
32442013-07-16 Juanma Barranquero <lekktu@gmail.com>
3245
3246 * w32fns.c (unwind_create_tip_frame): Fix declaration.
3247
c43843aa
PE
32482013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3249
50a30cce
PE
3250 Fix w32 bug with call-process-region (Bug#14885).
3251 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
3252 to Fcall_process when the input is empty. This simplifies the
3253 code a bit. It makes no difference on POSIXish platforms but
3254 apparently it fixes a bug on w32.
3255
44e18199 3256 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
3257 * fileio.c (close_file_unwind): Don't close if FD is negative;
3258 this can happen when unwinding a zapped file descriptor.
3259 (Finsert_file_contents): Unwind-protect the fd before the point marker,
3260 in case Emacs runs out of memory between the two unwind-protects.
3261 Don't trash errno when closing FD.
3262 Zap the FD in the specpdl when closing it, instead of deferring
3263 the removal of the unwind-protect; this fixes a bug where a child
3264 function unwinds the stack past us.
3265
27e498e6
PE
3266 New unwind-protect flavors to better type-check C callbacks.
3267 This also lessens the need to write wrappers for callbacks,
3268 and the need for make_save_pointer.
3269 * alloca.c (free_save_value):
3270 * atimer.c (run_all_atimers):
3271 Now extern.
3272 * alloc.c (safe_alloca_unwind):
3273 * atimer.c (unwind_stop_other_atimers):
3274 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
3275 * menu.c (cleanup_popup_menu) [HAVE_NS]:
3276 * minibuf.c (choose_minibuf_frame_1):
3277 * process.c (make_serial_process_unwind):
3278 * xdisp.h (pop_message_unwind):
3279 * xselect.c (queue_selection_requests_unwind):
3280 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
3281 * alloca.c (record_xmalloc):
3282 Prefer record_unwind_protect_ptr to record_unwind_protect with
3283 make_save_pointer.
3284 * alloca.c (Fgarbage_collect):
3285 Prefer record_unwind_protect_void to passing a dummy.
3286 * buffer.c (restore_buffer):
3287 * window.c (restore_window_configuration):
3288 * xfns.c, w32fns.c (do_unwind_create_frame)
3289 New wrapper. All record-unwind uses of wrappee changed.
3290 * buffer.c (set_buffer_if_live):
3291 * callproc.c (call_process_cleanup, delete_temp_file):
3292 * coding.c (code_conversion_restore):
3293 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
3294 * editfns.c (save_excursion_restore)
3295 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
3296 (save_restriction_restore):
3297 * eval.c (restore_stack_limits, un_autoload):
3298 * fns.c (require_unwind):
3299 * keyboard.c (recursive_edit_unwind, tracking_off):
3300 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
3301 * macros.c (pop_kbd_macro, restore_menu_items):
3302 * nsfns.m (unwind_create_frame):
3303 * print.c (print_unwind):
3304 * process.c (start_process_unwind):
3305 * search.c (unwind_set_match_data):
3306 * window.c (select_window_norecord, select_frame_norecord):
3307 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
3308 (fast_set_selected_frame):
3309 * xfns.c, w32fns.c (unwind_create_tip_frame):
3310 Return void, not a dummy Lisp_Object. All uses changed.
3311 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
3312 * callproc.c (call_process_kill):
3313 * fileio.c (restore_point_unwind, decide_coding_unwind)
3314 (build_annotations_unwind):
3315 * insdel.c (Fcombine_after_change_execute_1):
3316 * keyboard.c (read_char_help_form_unwind):
3317 * menu.c (unuse_menu_items):
3318 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
3319 * sound.c (sound_cleanup):
3320 * xdisp.c (unwind_redisplay):
3321 * xfns.c (clean_up_dialog):
3322 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
3323 Accept no args and return void, instead of accepting and returning
3324 a dummy Lisp_Object. All uses changed.
3325 * cygw32.c (fchdir_unwind):
3326 * fileio.c (close_file_unwind):
3327 * keyboard.c (restore_kboard_configuration):
3328 * lread.c (readevalllop_1):
3329 * process.c (wait_reading_process_output_unwind):
3330 Accept int and return void, rather than accepting an Emacs integer
3331 and returning a dummy object. In some cases this fixes an
3332 unlikely bug when the corresponding int is outside Emacs integer
3333 range. All uses changed.
3334 * dired.c (directory_files_internal_unwind):
3335 * fileio.c (do_auto_save_unwind):
3336 * gtkutil.c (pop_down_dialog):
3337 * insdel.c (reset_var_on_error):
3338 * lread.c (load_unwind):
3339 * xfns.c (clean_up_file_dialog):
3340 * xmenu.c, nsmenu.m (pop_down_menu):
3341 * xmenu.c (cleanup_widget_value_tree):
3342 * xselect.c (wait_for_property_change_unwind):
3343 Accept pointer and return void, rather than accepting an Emacs
3344 save value encapsulating the pointer and returning a dummy object.
3345 All uses changed.
3346 * editfns.c (Fformat): Update the saved pointer directly via
3347 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3348 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3349 (unwind_body): New function.
3350 (record_unwind_protect): First arg is now a function returning void,
3351 not a dummy Lisp_Object.
3352 (record_unwind_protect_ptr, record_unwind_protect_int)
3353 (record_unwind_protect_void): New functions.
3354 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3355 * fileio.c (struct auto_save_unwind): New type.
3356 (do_auto_save_unwind): Use it.
3357 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3358 * insdel.c (struct rvoe_arg): New type.
3359 (reset_var_on_error): Use it.
3360 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3361 New constants.
3362 (specbinding_func): Remove; there are now several such functions.
3363 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3364 (set_unwind_protect_ptr): New function.
3365 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3366
4e604a5d
PE
3367 Be simpler and more consistent about reporting I/O errors.
3368 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3369 Say "Read error" and "Write error", rather than "I/O error", or
3370 "IO error reading", or "IO error writing", when a read or write
3371 error occurs.
3372 * process.c (Fmake_network_process, wait_reading_process_output)
3373 (send_process, Fprocess_send_eof, wait_reading_process_output):
3374 Capitalize diagnostics consistently. Put "failed foo" at the
3375 start of the diagnostic, so that we don't capitalize the
3376 function name "foo". Consistently say "failed" for such
3377 diagnostics.
3378 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3379 All callers changed. This is so it can use report_file_error.
3380 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3381 diagnostics consistently as above.
3382
a9757f6a
PE
3383 * fileio.c (report_file_errno): Fix errno reporting bug.
3384 If the file name is neither null nor a pair, package it up as a
3385 singleton list. All callers changed, both to this function and to
3386 report_file_error. This fixes a bug where the memory allocator
3387 invoked by list1 set errno so that the immediately following
3388 report_file_error reported the wrong errno value.
3389
c43843aa
PE
3390 Fix minor problems found by --enable-gcc-warnings.
3391 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3392 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3393
18c26d81
JD
33942013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3395
3396 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3397 Set event->arg to Qt if switch-event shall be generated.
3398 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3399
3400 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3401
3402 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3403 FOCUS_OUT_EVENT.
3404
3405 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3406 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3407 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3408 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3409 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3410 and there is a focused frame.
3411 (head_table): Add focus-in and focus-out.
3412 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3413 bind to handle-focus-in/out.
3414
3415 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3416 (Fhandle_switch_frame): Call Fhandle_focus_in.
3417 (syms_of_frame): defsubr handle-focus-in/out.
3418
6c6f1994
PE
34192013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3420
c7ddc792
PE
3421 Fix porting bug to older POSIXish platforms (Bug#14862).
3422 * sysdep.c (emacs_pipe): New function, that implements
3423 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3424 This should port better to CentOS 5 and to Mac OS X 10.6.
3425 All calls to pipe2 changed.
3426
6c6f1994
PE
3427 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3428 This makes the code easier to read and the executable a bit smaller.
3429 Do not replace all calls to Fcons that happen to create lists,
3430 just calls that are intended to create lists. For example, when
3431 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3432 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3433 Similarly for list2 through list5.
3434 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3435 * bytecode.c (exec_byte_code):
3436 * callint.c (quotify_arg, Fcall_interactively):
3437 * callproc.c (Fcall_process, create_temp_file):
3438 * charset.c (load_charset_map_from_file)
3439 (Fdefine_charset_internal, init_charset):
3440 * coding.c (get_translation_table, detect_coding_system)
3441 (Fcheck_coding_systems_region)
3442 (Fset_terminal_coding_system_internal)
3443 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3444 * composite.c (update_compositions, Ffind_composition_internal):
3445 * dired.c (directory_files_internal, file_name_completion)
3446 (Fsystem_users):
3447 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3448 * doc.c (Fsnarf_documentation):
3449 * editfns.c (Fmessage_box):
3450 * emacs.c (main):
3451 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3452 (Feval, eval_sub, Ffuncall, apply_lambda):
3453 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3454 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3455 (Fset_file_times, Finsert_file_contents)
3456 (Fchoose_write_coding_system, Fwrite_region):
3457 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3458 * font.c (font_registry_charsets, font_parse_fcname)
3459 (font_prepare_cache, font_update_drivers, Flist_fonts):
3460 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3461 * frame.c (make_frame, Fmake_terminal_frame)
3462 (x_set_frame_parameters, x_report_frame_params)
3463 (x_default_parameter, Fx_parse_geometry):
3464 * ftfont.c (syms_of_ftfont):
3465 * image.c (gif_load):
3466 * keyboard.c (command_loop_1):
3467 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3468 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3469 (Fminor_mode_key_binding, accessible_keymaps_1)
3470 (Faccessible_keymaps, Fwhere_is_internal):
3471 * lread.c (read_emacs_mule_char):
3472 * menu.c (find_and_return_menu_selection):
3473 * minibuf.c (get_minibuffer):
3474 * nsfns.m (Fns_perform_service):
3475 * nsfont.m (ns_script_to_charset):
3476 * nsmenu.m (ns_popup_dialog):
3477 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3478 (Fx_own_selection_internal):
3479 * nsterm.m (append2):
3480 * print.c (Fredirect_debugging_output)
3481 (print_prune_string_charset):
3482 * process.c (Fdelete_process, Fprocess_contact)
3483 (Fformat_network_address, set_socket_option)
3484 (read_and_dispose_of_process_output, write_queue_push)
3485 (send_process, exec_sentinel):
3486 * sound.c (Fplay_sound_internal):
3487 * textprop.c (validate_plist, add_properties)
3488 (Fput_text_property, Fadd_face_text_property)
3489 (copy_text_properties, text_property_list, syms_of_textprop):
3490 * unexaix.c (report_error):
3491 * unexcoff.c (report_error):
3492 * unexsol.c (unexec):
3493 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3494 (Fformat_mode_line, syms_of_xdisp):
3495 * xfaces.c (set_font_frame_param)
3496 (Finternal_lisp_face_attribute_values)
3497 (Finternal_merge_in_global_face, syms_of_xfaces):
3498 * xfns.c (x_default_scroll_bar_color_parameter)
3499 (x_default_font_parameter, x_create_tip_frame):
3500 * xfont.c (xfont_supported_scripts):
3501 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3502 (menu_help_callback, xmenu_show):
3503 * xml.c (make_dom):
3504 * xterm.c (set_wm_state):
3505 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3506 and similarly for list2 through list5.
3507
bafe80ce
PE
35082013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3509
3510 * callproc.c (Fcall_process_region): Fix minor race and tune.
3511 (create_temp_file): New function, with the temp-file-creation part
3512 of the old Fcall_process_region. Use Fcopy_sequence to create the
3513 temp file name, rather than alloca + build_string, for simplicity.
3514 Don't bother to block input around the temp file creation;
068f9124
SM
3515 shouldn't be needed. Simplify use of mktemp.
3516 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3517 this closes an unlikely race where the temp file was not removed.
3518 Use memcpy rather than an open-coded loop.
3519 (Fcall_process_region): Use the new function. If the input is
3520 empty, redirect from /dev/null rather than from a newly created
3521 empty temp file; this avoids unnecessary file system traffic.
3522
4700b5a5
PE
35232013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3524
5c97beae
PE
3525 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3526 Simplify by making this case like the other two. This is a bit
3527 slower on obsolete hosts, but the extra complexity isn't worth it.
3528
4700b5a5
PE
3529 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3530 * process.c (create_process) [!DOS_NT]:
3531 Remove now-unnecessary calls to emacs_close.
3532
f9a74c4c
EZ
35332013-07-13 Eli Zaretskii <eliz@gnu.org>
3534
922ae7ee
EZ
3535 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3536 returning early. (Bug#14850)
3537
f9a74c4c
EZ
3538 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3539 and inhibit-iso-escape-detection attributes of 'undecided'.
3540 (Bug#14822)
3541
5e301d76
PE
35422013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3543
69e0e5ee
PE
3544 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3545 Reported by Herbert J. Skuhra in
3546 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3547
5e301d76
PE
3548 Don't lose top specpdl entry when memory is exhausted.
3549 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3550 specpdl overflow here, to simplify callers; all callers changed.
3551 Always reserve an unused entry at the stack top; this avoids
3552 losing the top entry's information when memory is exhausted.
3553
7e649856
PE
35542013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3555
a773ed9a
PE
3556 Clean up errno reporting and fix some errno-reporting bugs.
3557 * callproc.c (Fcall_process):
3558 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3559 * process.c (create_process, Fmake_network_process):
3560 * unexaix.c (report_error):
3561 * unexcoff.c (report_error):
3562 Be more careful about reporting the errno of failed operations.
3563 The code previously reported the wrong errno sometimes.
3564 Also, prefer report_file_errno to setting errno + report_file_error.
3565 (Fcall_process): Look at openp return value rather than at path,
3566 as that's a bit faster and clearer when there's a numeric predicate.
3567 * fileio.c (report_file_errno): New function, with most of the
3568 old contents of report_file_error.
3569 (report_file_error): Use it.
3570 (Ffile_exists_p, Ffile_accessible_directory_p):
3571 Set errno to 0 when it is junk.
3572 * fileio.c (Faccess_file):
3573 * image.c (x_create_bitmap_from_file):
3574 Use faccessat rather than opening the file, to avoid the hassle of
3575 having a file descriptor open.
3576 * lisp.h (report_file_errno): New decl.
3577 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3578
7e649856
PE
3579 Minor EBADF fixes.
3580 * process.c (create_process, wait_reading_process_output) [AIX]:
3581 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3582 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3583 a multithreaded environment anyway).
3584 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3585
f6774c1a
AS
35862013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3587
3588 * image.c (x_find_image_file): Don't close a remote file handle.
3589
bacba3c2
PE
35902013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 Fix races with threads and file descriptors.
3593 * callproc.c (Fcall_process_region):
3594 * dired.c (open_directory):
3595 * emacs.c (main, Fdaemon_initialized):
3596 * image.c (x_find_image_file):
3597 * inotify.c (Finotify_rm_watch):
3598 * lread.c (Flocate_file_internal):
3599 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3600 * term.c (term_mouse_moveto, init_tty):
3601 * termcap.c (tgetent):
3602 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3603 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3604 * unexhp9k800.c, unexmacosx.c (unexec):
3605 * callproc.c (Fcall_process_region):
3606 Use emacs_close, not close.
3607 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3608 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3609 and posix_close function on current platforms (which all lack them).
3610 (emacs_close): Use it. This should fix the races on GNU/Linux and
3611 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3612 and it should avoid closing random victim file descriptors on
3613 other platforms.
3614
653d4f43
PE
36152013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3616
c8536ec4
PE
3617 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3618 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3619 Touch up doc a bit.
3620
9c203066
PE
3621 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3622 This is for .gdbinit xbacktrace.
3623
653d4f43
PE
3624 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3625 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3626 (emacs_set_tty): Now static.
3627 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3628 * term.c (tty_capable_p, tty_default_color_capabilities)
3629 (get_tty_terminal, term_mouse_movement)
3630 (handle_one_term_event, init_tty, maybe_fatal):
3631 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3632 (tgetent, scan_file, name_match, compare_contin):
3633 * terminal.c (get_terminal):
3634 Use bool for boolean.
3635 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3636 Prefer char to unsigned char if either will do.
3637 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3638 (tty_write_glyphs): Prefer int to unsigned.
3639 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3640 All callers changed.
3641 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3642
45b683a1
PE
36432013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3644
29abe551
PE
3645 Port to C89.
3646 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3647 (B__dummy__): New dummy symbol, to pacify C89.
3648 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3649 they can't grok varargs macros.
3650 * dispnew.c (add_window_display_history)
3651 (add_frame_display_history):
3652 * print.c (print_object):
3653 * xdisp.c (debug_method_add):
3654 Use %p printf format only for void pointers.
3655 * emacs.c (usage_message): New constant, replacing ...
3656 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3657 (main): Adjust to usage reorg.
3658 * fns.c (syms_of_fns):
3659 * profiler.c (syms_of_profiler):
3660 Don't use non-constant struct initializers.
3661 * gnutls.h (gnutls_initstage_t):
3662 * lisp.h (enum Lisp_Fwd_Type):
3663 * lread.c (lisp_file_lexically_bound_p):
3664 * xsettings.c (anonymous enum):
3665 Remove trailing comma.
3666 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3667 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3668 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3669 (DEFUN): Use it.
3670 * regex.c (const_re_char): New type, to pacify strict C89.
3671 All uses of 'const re_char' replaced to use it.
3672 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3673 with glibc when strict C89. This change is imported from gnulib.
3674 All uses changed.
3675 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3676 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3677 Omit GNU_LINUX implementation, since it requires long long.
3678 * xterm.c (x_draw_underwave):
3679 Do not assume the traditional order of struct's members.
3680 (x_term_init): Rewrite to avoid the need for non-constant structure
3681 initializers.
3682
45b683a1 3683 Syntax cleanup, mostly replacing macros with functions.
763a086d 3684 This removes the need for the syntax_temp hack.
45b683a1
PE
3685 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3686 * syntax.c (SYNTAX_INLINE): New macro.
3687 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3688 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3689 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3690 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3691 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3692 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3693 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3694 Now constants, not macros.
3695 (syntax_temp) [!__GNUC__]: Remove.
3696 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3697 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3698 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3699 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3700 Move here from syntax.h; now functions, not macros. Except for the
3701 last function, these are static since only syntax.c uses them.
3702 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3703 All uses changed. Now a function, not a macro; use this fact
3704 to simplify the code.
3705 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3706 compiler bugs; no longer relevant.
3707 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3708 (SYNTAX_INLINE): New macro.
3709 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3710 for the new functions. Use bool for boolean member.
3711 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3712 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3713 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3714 (SETUP_BUFFER_SYNTAX_TABLE):
3715 Now extern inline functions, not macros.
3716 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3717 Remove; all uses replaced by implementation.
3718 (syntax_temp) [!__GNUC__]: Remove decl.
3719 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3720
29be4a50
JD
37212013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3722
3723 * emacs.c (main): Fix syntax error.
3724
954b166e
PE
37252013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3726
3727 Timestamp fixes for undo (Bug#14824).
3728 * atimer.c (schedule_atimer):
3729 * fileio.c (Ffile_newer_than_file_p):
3730 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3731 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3732 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3733 (syms_of_fileio): Remove Sclear_visited_file_name.
3734 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3735 file doesn't exist; this avoids an ambiguity with negative timestamps.
3736 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3737 * systime.h (make_emacs_time, invalid_emacs_time):
3738 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3739 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3740 * undo.c (record_first_change): Push (visited-file-modtime) onto
3741 undo list rather than reimplementing it by hand, incorrectly.
3742
d74647c3
KB
37432013-07-09 Ken Brown <kbrown@cornell.edu>
3744
3745 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3746
3c51b96b
JB
37472013-07-09 Juanma Barranquero <lekktu@gmail.com>
3748
3749 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3750
4ebbdd67
PE
37512013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3752
3753 Handle errno and exit status a bit more carefully.
3754 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3755 number into an exit status. Instead, use EXIT_CANCELED.
3756 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3757 * callproc.c (relocate_fd):
3758 * emacs.c (close_output_streams, main):
3759 * process.c (create_process):
3760 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3761 Use emacs_perror for simplicity.
3762 * callproc.c (relocate_fd, main):
3763 * sysdep.c (sys_subshell):
3764 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3765 (shut_down_emacs): Use emacs_write, not write.
3766 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3767 * fileio.c (Fcopy_file, e_write):
3768 * nsterm.m (ns_select):
3769 * process.c (send_process):
3770 * sound.c (vox_write):
3771 Use emacs_write_sig, not emacs_write.
3772 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3773 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3774 New constants.
3775 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3776 of write.
3777 (emacs_full_write): New function.
3778 (emacs_write): Rewrite to use it.
3779 (emacswrite_sig, emacs_perror): New functions.
3780 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3781
44e18199 37822013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3783
3784 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3785 on NS even if it is present. Pixmap on NS is a void*.
3786
9caab067
PE
37872013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3788
3789 Port to Ubuntu 10 (Bug#14803).
3790 Problem reported by T.V. Raman.
3791 * process.c (close_on_exec, accept4, process_socket):
3792 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3793
1d442672
EZ
37942013-07-07 Eli Zaretskii <eliz@gnu.org>
3795
3796 * w32.c (sys_dup): Declare prototype.
3797
3798 * filelock.c:
3799 * emacs.c:
3800 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3801
067428c1
PE
38022013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3803
3804 Make file descriptors close-on-exec when possible (Bug#14803).
3805 This simplifies Emacs a bit, since it no longer needs to worry
3806 about closing file descriptors by hand in some cases.
3807 It also fixes some unlikely races. Not all such races, as
3808 libraries often open files internally without setting
3809 close-on-exec, but it's an improvement.
3810 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3811 * callproc.c (Fcall_process) [!MSDOS]:
3812 * emacs.c (main) [!DOS_NT]:
3813 * nsterm.m (ns_term_init):
3814 * process.c (create_process):
3815 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3816 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3817 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3818 Prefer mkostemp with O_CLOEXEC to mkstemp.
3819 * callproc.c (relocate_fd) [!WINDOWSNT]:
3820 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3821 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3822 now using pipe2.
3823 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3824 Make the resulting file descriptor close-on-exec.
3825 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3826 * lread.c (load_descriptor_list, load_descriptor_unwind):
3827 Remove; no longer needed. All uses removed.
3828 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3829 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3830 New functions.
3831 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3832 (Fmake_network_process, Fnetwork_interface_list):
3833 (Fnetwork_interface_info, server_accept_connection):
3834 Make newly-created socket close-on-exec.
3835 * sysdep.c (emacs_open, emacs_fopen):
3836 Make new-created descriptor close-on-exec.
3837 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3838 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3839
0da857dd
JD
38402013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3841
3842 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3843 for NS_IMPL_GNUSTEP.
3844
5f86adcd
PE
38452013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 Fix openp errno handling.
3848 * callproc.c (Fcall_process): Preserve openp errno around close.
3849 * lread.c (openp): Set errno when returning -1, as some callers
3850 expect this.
3851
1afb1d07
JD
38522013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3853
3854 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3855
3856 * nsterm.h (NSSavePanel): Update comment.
3857 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3858 (ns_run_file_dialog): Declare.
3859
3860 * nsfns.m: Remove panelOK.
3861 (ns_fd_data): New.
3862 (ns_run_file_dialog): New function.
3863 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3864 event loop, so file dialog is popped up by ns_run_file_dialog, called
3865 by sendEvent (Bug#14578).
3866 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3867
3323c263
EZ
38682013-07-06 Eli Zaretskii <eliz@gnu.org>
3869
fdda0220
EZ
3870 * xdisp.c (default_line_pixel_height): New function.
3871 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3872 (try_cursor_movement, redisplay_window, try_window)
3873 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3874
068f9124
SM
3875 * window.c (window_scroll_pixel_based):
3876 use default_line_pixel_height.
fdda0220
EZ
3877
3878 * dispextern.h (default_line_pixel_height): Add prototype.
3879
3880 * frame.c (x_set_line_spacing): Accept a float value for
3881 line-spacing parameter, per the documentation.
3882
3323c263
EZ
3883 * data.c (Fmultibyte_string_p): Doc fix.
3884
47ba6d43
PE
38852013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3886
406af475
PE
3887 Use emacs_open more consistently when opening files.
3888 This handles EINTR more consistently now, and makes it easier
3889 to introduce other uniform changes to file descriptor handling.
3890 * src/systdio.h: New file.
3891 * src/buffer.c (mmap_init):
3892 * cygw32.c (chdir_to_default_directory):
3893 * dispnew.c (Fopen_termscript):
3894 * emacs.c (Fdaemon_initialized):
3895 * fileio.c (Fdo_auto_save):
3896 * image.c (slurp_file, png_load_body, jpeg_load_body):
3897 * keyboard.c (Fopen_dribble_file):
3898 * lread.c (Fload):
3899 * print.c (Fredirect_debugging_output):
3900 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3901 * termcap.c (tgetent):
3902 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3903 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3904 * w32term.c (w32_initialize) [CYGWIN]:
3905 * xfaces.c (Fx_load_color_file):
3906 Use emacs_open instead of plain open, and emacs_fopen instead of
3907 plain fopen.
3908 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3909 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3910 * callproc.c (default_output_mode): New constant.
3911 (Fcall_process): Use it to call emacs_open instead of plain creat.
3912 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3913 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3914 (emacs_fopen): New function.
3915 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3916 Include <lisp.h>, for emacs_open.
3917 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3918
47ba6d43
PE
3919 Remove duplicate #include directives.
3920 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3921 * xfaces.c:
3922 Don't include stdio.h twice.
3923 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3924 Don't include sys/types.h or stdio.h twice.
3925 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3926 * lread.c: Don't include coding.h twice.
3927 * nsfont.m: Don't include frame.h twice.
3928 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3929 * ralloc.c: Don't include <unistd.h> twice.
3930 * xdisp.c: Don't include font.h twice.
3931 * xterm.c: Don't include fontset.h twice.
3932 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3933
b9ed53d5
PE
39342013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3935
3936 Scale ImageMagick images more carefully.
3937 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3938 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3939 Be more careful about avoiding undefined behavior after
3940 integer overflow and division by zero.
3941
cf13177e
YM
39422013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3943
3944 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3945 (syms_of_w32fns): DEFSYM them.
3946 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3947 (CCHDEVICENAME): Define macros if not defined.
3948 (struct MONITOR_INFO_EX): New struct.
3949 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3950 (enum_display_monitors_fn): New variable.
3951 (globals_of_w32fns): Initialize it.
3952 (Fx_display_pixel_width, Fx_display_pixel_height)
3953 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3954 multi-monitor setups in docstrings.
3955 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3956 screen size by primary monitor's millimeter per pixel.
3957 (w32_monitor_enum, w32_display_monitor_attributes_list)
3958 (w32_display_monitor_attributes_list_fallback)
3959 (Fw32_display_monitor_attributes_list): New functions.
3960 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3961
3962 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3963 if not defined.
3964 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3965
86dfb7a8
MA
39662013-07-04 Michael Albinus <michael.albinus@gmx.de>
3967
3968 * fileio.c (Qfile_notify_error): New error symbol.
3969
3970 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3971 * inotify.c (inotify_callback, symbol_to_inotifymask)
3972 (Finotify_add_watch, Finotify_rm_watch): Use it.
3973 (inotifyevent_to_event): Exchange order of cookie and file name.
3974 (Finotify_add_watch): Adapt docstring.
3975
3976 * lisp.h (Qfile_notify_error): Declare.
3977
2c1c974b
PE
39782013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3981 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3982 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3983 which did not work (see <http://bugs.gnu.org/14569#307>).
3984 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3985 && (!noninteractive || initialized)). This attempts to thread
3986 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3987
7a35b20f
JB
39882013-07-04 Juanma Barranquero <lekktu@gmail.com>
3989
3990 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3991 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3992
1ce5cd04
PE
39932013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3994
3995 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3996 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3997 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3998 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3999
57f8c490
PE
40002013-07-02 Paul Eggert <eggert@cs.ucla.edu>
4001
4002 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
4003 Define to __sys_siglist.
4004
bcffb5ca
EZ
40052013-07-02 Eli Zaretskii <eliz@gnu.org>
4006
4007 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
4008 word-wrap, so that overflow-newline-into-fringe would work in
4009 visual-line-mode. (Bug#2749)
4010 (move_it_in_display_line_to): When the last scanned display
4011 element fits exactly on the display line, and
4012 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
4013 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
4014 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
4015 finding buffer position that corresponds to pixel coordinates,
4016 e.g. in buffer_posn_from_coords.
4017
2c41e781
JD
40182013-07-02 Jan Djärv <jan.h.d@swipnet.se>
4019
4020 * process.c (handle_child_signal): Call catch_child_signal if
4021 NS_IMPL_GNUSTEP.
4022
c2418359
PE
40232013-07-02 Paul Eggert <eggert@cs.ucla.edu>
4024
52a9bcae
PE
4025 Don't convert function pointers to void * and back.
4026 It isn't portable C, and it's easy enough to avoid.
4027 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
4028 (make_save_value): Add support for SAVE_FUNCPOINTER.
4029 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
4030 * print.c (print_object):
4031 Distinguish function from object pointers.
4032 * lisp.h (SAVE_FUNCPOINTER): New constant.
4033 (SAVE_SLOT_BITS): Adjust to it.
4034 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
4035 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
4036 (voidfuncptr): New typedef.
4037 (struct Lisp_Save_Value): New member data[0].funcpointer.
4038 (XSAVE_FUNCPOINTER): New function.
4039
c2418359
PE
4040 Simplify buildobj processing.
4041 * Makefile.in (buildobj.h): Make it a sequence of strings each
4042 followed by comma, rather than a single string. Put it into a
4043 .tmp file in case there's an error while generating it.
4044 (gl-stamp): Use .tmp for temp files.
4045 (mostlyclean): Clean .tmp files.
4046 * doc.c (buildobj): Move to just the routine that needs it.
4047 It's now an array of strings, so processing is simpler.
4048
8f43ce49
PE
40492013-07-01 Paul Eggert <eggert@cs.ucla.edu>
4050
4051 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
4052 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
4053 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4054 Invoke malloc_enable_thread even when not interactive.
4055 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
4056 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
4057 in this case, since the underlying bug has now been fixed.
4058
24827db9
JB
40592013-07-01 Juanma Barranquero <lekktu@gmail.com>
4060
4061 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
4062 unlinking it (bug#14691).
4063
ef099a94
MN
40642013-06-30 Michal Nazarewicz <mina86@mina86.com>
4065
4066 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
4067 before checking whether buffer is modified. This lets
4068 `kill-buffer-query-functions' cancel killing of the buffer or save
4069 its content before `kill-buffer' asks user the "Buffer %s
4070 modified; kill anyway?" question.
4071
9d3f2fc2
JD
40722013-06-30 Jan Djärv <jan.h.d@swipnet.se>
4073
4074 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
4075 Let the super performKeyEquivalent deal with them (Bug#14747).
4076
e6c6c8c7
PE
40772013-06-30 Paul Eggert <eggert@cs.ucla.edu>
4078
1d71c1d9
PE
4079 * widget.c (resize_cb): Remove unused local.
4080
8f5f35cc
PE
4081 Do not use GTK 3 if it exists but cannot be compiled.
4082 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
4083 * xterm.c (x_error_handler) [!USE_GTK]:
4084 Do not use GTK 3.
4085
e6c6c8c7
PE
4086 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
4087
0ba54312
EZ
40882013-06-30 Eli Zaretskii <eliz@gnu.org>
4089
5d1c3286
EZ
4090 * intervals.c (get_local_map): Instead of aborting, clip POSITION
4091 to the valid range of values. (Bug#14753)
4092
0ba54312
EZ
4093 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
4094 when moving point by using the current glyph matrix. This avoids
4095 the need to force redisplay when this function is called in a
4096 loop.
4097
9c90cc06
PE
40982013-06-29 Paul Eggert <eggert@cs.ucla.edu>
4099
4100 Fix minor problems found by static checking.
4101 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
4102 Redo the latter's body to sidestep GCC parenthesization warnings.
4103 (setup_coding_system, detect_coding, detect_coding_system): Use them.
4104 * coding.c (detect_coding, detect_coding_system):
4105 * coding.h (struct undecided_spec):
4106 Use bool for boolean.
4107 * image.c (QCmax_width, QCmax_height): Now static.
4108 * xdisp.c (Fmove_point_visually): Remove unused local.
4109
4c672a0f
EZ
41102013-06-29 Eli Zaretskii <eliz@gnu.org>
4111
4112 * xdisp.c (Fmove_point_visually): New function.
4113
c1ea3abf
JB
41142013-06-28 Kenichi Handa <handa@gnu.org>
4115
4116 * coding.h (define_coding_undecided_arg_index): New enum.
4117 (coding_attr_index): New members
4118 coding_attr_undecided_inhibit_null_byte_detection,
4119 coding_attr_undecided_inhibit_iso_escape_detection,
4120 coding_attr_undecided_prefer_utf_8.
4121 (undecided_spec): New struct.
4122 (struct coding_system): New member `undecided' of the member
4123 `spec'.
4124
4125 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
4126 (detect_coding): Likewise.
4127 (detect_coding_system): Likewise.
4128 (Fdefine_coding_system_internal): New coding system properties
4129 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
4130 :prefer-utf-8.
4131 (syms_of_coding): Adjust for coding_arg_undecided_max.
4132
ba3de9e6
PE
41332013-06-28 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 * image.c (x_from_xcolors): Remove unused local.
4136
547c9269
YM
41372013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4138
4139 Defer image data transfer between X client and server until actual
4140 display happens.
4141
4142 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
4143 and `mask_img'.
4144
4145 * image.c (Destroy_Image): Remove.
4146 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
4147 `mask_p', and `colors_p'. All uses changed.
4148 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
4149 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
4150 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
4151 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
4152 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 4153 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
4154 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
4155 (image_get_x_image, image_unget_x_image): New functions or macros.
4156 (image_background, image_background_transparent, x_to_xcolors)
4157 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
4158 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
4159 instead of Destroy_Image.
4160 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
4161 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
4162 (png_load_body, jpeg_load_body, tiff_load, gif_load)
4163 (imagemagick_load_image, svg_load_image): Use them instead of
4164 x_create_x_image_and_pixmap, and x_put_x_image followed by
4165 x_destroy_x_image, respectively.
4166 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
4167 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
4168 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
4169 background_transparent fields.
4170 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
4171 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
4172
dae2f5ef
PE
41732013-06-27 Paul Eggert <eggert@cs.ucla.edu>
4174
4175 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
4176 This mostly consists of undoing recent changes.
4177 * callproc.c (Fcall_process):
4178 * process.c (create_process):
4179 Do not worry about catching SIGCHLD here, undoing previous change.
4180 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
4181 * process.c, process.h (catch_child_signal):
4182 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
4183 * process.c (catch_child_handler): Don't worry about being called
4184 lazily and do not assume caller has blocked SIGCHLD, undoing
4185 previous change. Move first-time stuff back to
4186 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
4187 tickle glib, as that causes Cygwin bootstrap to fail. Do not
4188 set lib_child_handler if it's already initialized, which may
4189 help avoid problems on GNUStep.
4190
fa55d2aa
PE
41912013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
4194 * callproc.c (Fcall_process):
4195 * process.c (create_process):
4196 Make sure SIGCHLD is caught before we fork,
4197 since Emacs startup no arranges to catch SIGCHLD.
4198 * process.c (lib_child_handler): Initialize to null, not to
4199 dummy_handler.
4200 (catch_child_signal): Allow self to be called lazily.
4201 Do nothing if it's already been called.
4202 Assume caller has blocked SIGCHLD (all callers do now).
4203 * emacs.c (main): Do not catch SIGCHLD here; defer it until
4204 just before it's really needed.
4205 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
4206 since it hasn't been caught yet.
4207
f3f9606c
LMI
42082013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
4209
4210 * image.c (compute_image_size): New function to implement
4211 :max-width and :max-height.
4212 (imagemagick_load_image): Use it.
4213
c7041908
PE
42142013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
4217 * callproc.c, process.h (block_child_signal, unblock_child_signal):
4218 Now extern.
4219 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
4220 * process.c (catch_child_signal): Block SIGCHLD while futzing with
4221 the SIGCHLD handler, since the code is not atomic and (due to glib)
4222 signals may be arriving now.
4223 * sysdep.c (init_signals): Do not catch child signals here;
4224 'main' now does that later, at a safer time.
4225
f86852b4
PE
42262013-06-22 Paul Eggert <eggert@cs.ucla.edu>
4227
0dfeed58
PE
4228 Clean up SIGCHLD handling a bit (Bug#14569).
4229 * process.c, process.h (catch_child_signal):
4230 Now always extern, even if !NS_IMPL_GNUSTEP.
4231 * process.c (catch_child_signal): Move glib tickler here from
4232 init_process_emacs, so that it's done earlier in Emacs
4233 initialization. Also move the noninteractive && !initialized
4234 check here from init_process_emacs. This is all a bit cleaner for
4235 GNUish platforms, and I hope it works around the Cygwin bug.
4236 * sysdep.c (init_signals): Invoke catch_child_signal here, so
4237 that glib signal handling is tickled before glib creates threads.
4238
f86852b4
PE
4239 * process.c (wait_reading_process_output): Avoid int overflow
4240 when reading more than 2 GiB total from a process.
4241
cbd6509c
PE
42422013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4243
4244 * process.c (create_process): Handle a couple more cases,
4245 i.e., work even if new_argv and wait_child_setup[i] are cached.
4246 Use Fcall_process's style for volatile vars.
4247
9de1114a
AS
42482013-06-21 Andreas Schwab <schwab@linux-m68k.org>
4249
4250 * process.c (create_process): Mark PROCESS volatile.
4251
fbe9e0b9
PE
42522013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4253
4254 Use C99-style flexible array members if available.
4255 This avoids some subtle aliasing issues, which typically
4256 aren't a problem with GCC but may be a problem elsewhere.
4257 * alloc.c (sdata): New typedef, replacing the old struct sdata.
4258 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
4259 In either case, it uses a flexible array member rather than
4260 the old struct hack. All uses changed.
4261 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
4262 Adjust to sdata reorganization.
4263 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
4264 Use offsetof (struct, flex_array_member), not sizeof (struct), as
4265 that ports better to pre-C99 non-GCC.
4266 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
4267 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
4268 as the latter has changed.
4269 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
4270 and port better to pre-C99 GCC.
4271 * image.c (struct xpm_cached_color):
4272 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
4273 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
4274 Use FLEXIBLE_ARRAY_MEMBER.
4275 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
4276 Move decl to top level so it gets checked against implementation.
4277 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
4278 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
4279
1fc71008
PE
42802013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4281
4282 * syntax.c: Integer cleanups.
4283 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
4284 All uses that need 0-or-2 changed to:
4285 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
4286 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
4287 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
4288 (char_quoted, prev_char_comend_first, back_comment)
4289 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4290 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
4291 Use bool for boolean.
4292 (update_syntax_table, skip_chars, skip_syntaxes):
4293 Prefer int to unsigned when either will do.
4294 (back_comment): Return boolean success flag, like forw_comment,
4295 instead of positive-or-minus-1 (which might have overflowed int anyway).
4296 Don't stuff ptrdiff_t into int.
4297 (syntax_spec_code, syntax_code_spec): Now const.
4298 (Fmatching_paren, scan_lists, scan_sexps_forward):
4299 Use enum syntaxcode for syntax code.
4300 (Fmatching_paren): Check that arg is a character, not just an integer.
4301 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
4302 (Finternal_describe_syntax_value): Omit no-longer-needed
4303 comparison to 0.
4304 (skip_chars): Use char, not unsigned char, when the distinction
4305 doesn't matter.
4306 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
4307 * bytecode.c (exec_byte_code):
4308 * syntax.c (syntax_spec_code, Fchar_syntax)
4309 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4310 (init_syntax_once):
4311 * syntax.h (SYNTAX_WITH_FLAGS):
4312 Omit unnecessary casts.
4313
b932cad7
EZ
43142013-06-20 Eli Zaretskii <eliz@gnu.org>
4315
4316 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
4317 line dimensions here, to avoid race conditions with the main
4318 thread. (Bug#14062, bug#14630, bug#14669)
4319
4320 * w32term.c (w32_draw_window_cursor): Compute the header line and
4321 mode line dimensions here.
4322 <w32_system_caret_window, w32_system_caret_hdr_height>:
4323 <w32_system_caret_mode_height>: New variables.
4324
4325 * w32term.h: Declare them.
4326
89561f72
PE
43272013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4328
5013fc08
PE
4329 * alloc.c (die): Move "assertion failed" string here ...
4330 * lisp.h (eassert): ... from here. Also, suppress evaluation of
4331 COND when SUPPRESS_CHECKING. This shrinks the executable text
4332 size by 0.8% to 2.2% when configured with --enable-checking,
4333 depending on optimization flags (GCC 4.8.1 x86-64).
4334
89561f72
PE
4335 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
4336
763a086d 43372013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
4338
4339 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4340 base is 2; this is more accurate.
4341
983aeb9a
JB
43422013-06-19 Juanma Barranquero <lekktu@gmail.com>
4343
4344 * sound.c (string_default): Move to !WINDOWSNT section.
4345 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4346
178ba3e6
PE
43472013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4348
bbc51b15
PE
4349 * sound.c: Integer cleanups.
4350 Remove unnecessary forward decls.
4351 (struct sound_device): The 'file' member is now a Lisp_Object, not
4352 a char *, so that we needn't invoke alloca on a huge size.
4353 (Fplay_sound_internal): Adjust to this.
4354 (string_default): New function.
4355 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4356 Use it to adjust to the struct sound_device change.
4357 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4358 (be2hs) [0]: Remove.
4359
178ba3e6
PE
4360 * syntax.c (skip_chars): Don't use uninitialized storage
4361 when searching a multibyte buffer for characters that are not in a
4362 unibyte string that contains non-ASCII characters.
4363
69f60cdc
JD
43642013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4365
4366 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4367 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4368
0d6224d4
PE
43692013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4372
3c542890
KH
43732013-06-18 Kenichi Handa <handa@gnu.org>
4374
f7e3f7cd
KH
4375 * font.c (Ffont_spec): Signal an error for an invalid font name
4376 (Bug#14648).
3c542890 4377
9349e5f7
PE
43782013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4381 In particular this ports to 32-bit sparc Sun cc.
4382 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4383 array with a dummy element at specpdl[-1], so that its address can
4384 be taken portably.
4385 (unbind_to): Do not copy the binding; not needed, now that we
4386 copy old_value in the one place where the copy is needed.
4387 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4388 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4389 (union specbinding): Rename from struct specbinding. Redo layout
4390 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4391 which is not portable. With Sun C 5.12 32-bit sparc, the
4392 declaration causes nargs to be an unsigned bitfield, a behavior
4393 that the C standard allows; but Emacs wants nargs to be signed.
4394 The overall type is now a union of structures rather than a
4395 structure of union of structures, and the 'kind' member is now a
4396 bitfield, so that the overall type doesn't grow. All uses changed.
4397 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4398
0a4df6a5
PE
43992013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4400
ec6ecaad
PE
4401 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4402 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4403
0a4df6a5
PE
4404 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4405
7bfe8dbc
EZ
44062013-06-17 Eli Zaretskii <eliz@gnu.org>
4407
4408 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4409 unless we know that the window w's frame is a frame object.
4410 Another attempt at solving bug#14062 and bug#14630.
4411
708e05f6
LMI
44122013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4413
4414 * textprop.c (property_set_type): New enum.
4415 (add_properties): Allow appending/prepending text properties.
4416 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4417 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4418 add_text_properties_1.
4419 (Fadd_face_text_property): New function that calls
4420 add_text_properties_1.
4421
84575e67
PE
44222013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 Move functions from lisp.h to individual modules when possible.
4425 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4426 * alloc.c (XFLOAT_INIT, set_symbol_name):
4427 * buffer.c (CHECK_OVERLAY):
4428 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4429 (set_char_table_parent):
4430 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4431 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4432 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4433 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4434 (set_blv_valcell):
4435 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4436 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4437 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4438 (backtrace_args, backtrace_debug_on_exit):
4439 * floatfns.c (CHECK_FLOAT):
4440 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4441 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4442 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4443 (set_hash_index_slot):
4444 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4445 * marker.c (CHECK_MARKER):
4446 * textprop.c (CHECK_STRING_OR_BUFFER):
4447 * window.c (CHECK_WINDOW_CONFIGURATION):
4448 Move here from lisp.h, and make these functions static rather than
4449 extern inline.
4450 * buffer.c (Qoverlayp):
4451 * data.c (Qsubrp):
4452 * fns.c (Qhash_table_p):
4453 * window.c (Qwindow_configuration_p):
4454 Now static.
4455 * lisp.h: Remove the abovementioned defns and decls.
4456
44e18199 4457 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4458 In lisp.h, prefer functions to function-like macros, and
4459 constants to object-like macros, when either will do. This:
4460 . simplifies use, as there's no more need to worry about
4461 arguments' side effects being evaluated multiple times.
4462 . makes the code easier to debug on some platforms.
4463 However, when using gcc -O0, keep using function-like macros
4464 for a few critical operations, for performance reasons.
4465 This sort of thing isn't needed with gcc -Og, but -Og
4466 is a GCC 4.8 feature and isn't widely-enough available yet.
4467 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4468 Remove enum lsb_bits; no longer needed.
4469 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4470 * buffer.c (Qoverlap):
4471 * data.c (Qsubrp):
4472 * fns.c (Qhash_table_p):
4473 Now extern, so lisp.h can use these symbols.
4474 * dispextern.h: Include character.h, for MAX_CHAR etc.
4475 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4476 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4477 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4478 (GLYPH_CODE_P): Move here from lisp.h.
4479 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4480 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4481 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4482 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4483 XUNTAG now returns void *.
4484 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4485 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4486 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4487 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4488 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4489 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4490 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4491 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4492 New macros, renamed from their sans-lisp_h_ counterparts.
4493 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4494 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4495 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4496 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4497 If compiling via GCC without optimization, define these as macros
4498 in addition to inline functions.
4499 To disable this, compile with -DINLINING=0.
4500 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4501 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4502 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4503 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4504 (INTMASK, VALMASK): Now macros, since static values cannot be
4505 accessed from extern inline functions.
4506 (VALMASK): Also a constant, for benefit of old GDB.
4507 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4508 is INTEGERP, which can fold it in.
5165d44a 4509 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4510 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4511 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4512 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4513 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4514 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4515 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4516 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4517 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4518 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4519 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4520 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4521 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4522 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4523 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4524 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4525 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4526 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4527 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4528 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4529 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4530 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4531 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4532 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4533 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4534 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4535 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4536 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4537 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4538 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4539 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4540 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4541 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4542 Now functions.
4543 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4544 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4545 (VALMASK): Define in one place rather than in two, merging the
4546 USE_LSB_TAG parts; this is simpler.
4547 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4548 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4549 Move up, to avoid use before definition.
4550 Also include "globals.h" earlier, for the same reason.
4551 (make_natnum): New function.
4552 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4553 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4554 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4555 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4556 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4557 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4558 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4559 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4560 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4561 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4562 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4563 (Qwindow_configuration_p, Qimage): New forward declarations.
4564 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4565 (STRING_COPYIN): Remove; unused.
4566 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4567 (xcar_addr, xcdr_addr): New functions. All uses changed.
4568 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4569 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4570 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4571 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4572 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4573 (TYPE_RANGED_INTEGERP): Simplify.
4574 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4575 (setlocale, fixup_locale, synchronize_system_messages_locale)
4576 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4577 Now empty functions, not macros.
4578 (functionp): Return bool, not int.
4579 * window.c (Qwindow_configuration_p): Now extern,
4580 so window.h can use it.
4581 * window.h (Qwindowp): Move decl back to lisp.h.
4582
9583ec36
EZ
45832013-06-15 Eli Zaretskii <eliz@gnu.org>
4584
4585 * xdisp.c (Fline_pixel_height): New function, required for solving
4586 bug #14567.
4587
210272ce
PE
45882013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4589
4590 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4591
de0503df
SM
45922013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4593
4594 * lread.c (syms_of_lread):
4595 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4596
afbfe143
KD
45972013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4598
4599 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4600
d177e213
XF
46012013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4602
4603 * fileio.c (expand_file_name): Doc fix.
4604
05e3e412
PE
46052013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4606
f7394b12
PE
4607 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4608 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4609 Wait for self, not for 0. This can't hurt on GNU or similar
4610 system, and may help with Cygwin.
4611
05e3e412
PE
4612 * keyboard.c: Don't use PROP (...) as an lvalue.
4613 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4614 Use set_prop (A, B), not PROP (A) = B.
4615
17dd3097
EZ
46162013-06-10 Eli Zaretskii <eliz@gnu.org>
4617
4618 * xdisp.c (get_it_property): Use it->window instead of generating
4619 a Lisp object from it->w.
4620
52fab9c9
EZ
46212013-06-09 Eli Zaretskii <eliz@gnu.org>
4622
4623 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4624 get-char-property the window that is being rendered, instead of
4625 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4626 (compute_display_string_pos): When W is NULL, use the current
4627 buffer as the object to pass to get-char-property.
4628 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4629 pointer member of the bidi iterator, since no window is pertinent
4630 to this function.
52fab9c9 4631
5bf97bfc
EZ
46322013-06-08 Eli Zaretskii <eliz@gnu.org>
4633
4634 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4635 being displayed, and pass it to compute_display_string_pos.
4636 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4637 (bidi_paragraph_init): All callers changed.
4638
4639 * xdisp.c (init_from_display_pos, init_iterator)
4640 (handle_single_display_spec, next_overlay_string)
4641 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4642 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4643 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4644 (compute_display_string_pos): Accept additional argument, the
4645 window being displayed, and pass it to Fget_char_property.
4646 (Bug#14575)
4647
4648 * dispextern.h (struct bidi_it): New member w, the window being
4649 displayed.
4650 (compute_display_string_pos): Adjust prototype.
4651
5de0e011
JD
46522013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4653
e7b41c4c 4654 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4655
4656 * process.c (wait_reading_process_output): Check for NS before GLIB.
4657 GLIB may be linked in due to rsvg, but ns_select must be called.
4658
5de0e011
JD
4659 * xgselect.c (xg_select): Remove call to window_system_available
4660 and g_main_context_pending at the top, so Gdk events (i.e. file
4661 notify) are processed when Emacs is started with -nw.
4662
a822acff
EZ
46632013-06-07 Eli Zaretskii <eliz@gnu.org>
4664
4665 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4666 (ctagsfiles3): New variable, includes only *.m files.
4667 (TAGS): Use an explicit language name in the regular expressions,
4668 to avoid transformation of '/SOMETHING' by MSYS to
4669 'c:\MSYS\SOMETHING'.
4670
6c0a9ed1
RC
46712013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4672
4673 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4674
9ef6111b
EZ
46752013-06-06 Eli Zaretskii <eliz@gnu.org>
4676
4677 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4678 still need to set the mouse pointer shape and activate help-echo.
4679 (Bug#14558)
4680
7d300d64
PE
46812013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4682
4683 A few porting etc. fixes for the new file monitor code.
4684 See the thread containing
4685 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4686 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4687 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4688 (dir_monitor_callback, Fgfile_rm_watch):
4689 Use assq_no_quit instead of Fassoc, for speed.
4690 (dir_monitor_callback, Fgfile_rm_watch):
4691 eassert that the monitor is a fixnum.
4692 (dir_monitor_callback): No need for CDR_SAFE.
4693 Simplify building of lisp with alternative tails.
4694 (Fgfile_add_watch, Fgfile_rm_watch):
4695 Do not assume glib functions set errno reliably on failure.
4696 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4697 and signal an error otherwise.
4698 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4699 Use Fdelq instead of Fdelete, for speed.
4700
817ebfcf
EZ
47012013-06-05 Eli Zaretskii <eliz@gnu.org>
4702
4703 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4704 don't insist on being invoked on a highlighted tool-bar button.
4705 Avoids losing tool-bar functionality when mouse-highlight is nil.
4706 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4707 Don't highlight when mouse-highlight is nil.
4708 (note_mouse_highlight): When mouse-highlight is nil, don't return
4709 right away; instead, run tool-bar and mode-line highlight
4710 subroutine, clear any existing highlight, and revert the mouse
4711 pointer to its default shape. (Bug#14558)
4712
55577e7c
SM
47132013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4714
4715 * lisp.mk (lisp): Add prog-mode.el.
4716
f019a684
PE
47172013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4718
4719 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4720 * process.c (dummy_handler): New function.
4721 (lib_child_handler): New static var.
4722 (handle_child_signal): Invoke it.
4723 (catch_child_signal): If a library has set up a signal handler,
4724 save it into lib_child_handler.
4725 (init_process_emacs): If using glib and not on Windows, tickle glib's
4726 child-handling code so that it initializes its private SIGCHLD handler.
4727 * syssignal.h (SA_SIGINFO): Default to 0.
4728 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4729 31; it should no longer be needed now.
4730
90db8702
MA
47312013-06-05 Michael Albinus <michael.albinus@gmx.de>
4732
4733 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4734
4735 * gfilenotify.c (globals_of_gfilenotify): New function.
4736 (syms_of_gfilenotify): Move global initialization there.
4737
4738 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4739
bfa3acd6
SM
47402013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4741
4742 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4743 * keyboard.c (menu_bar_items, tool_bar_items):
4744 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4745 not override local keymaps any more.
4746
ba59bd80
EZ
47472013-06-04 Eli Zaretskii <eliz@gnu.org>
4748
4749 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4750
7f203aa1
EZ
47512013-06-03 Eli Zaretskii <eliz@gnu.org>
4752
9337e206
EZ
4753 * w32console.c (initialize_w32_display): Return the dimensions of
4754 the console window via 2 additional arguments, not via the current
4755 frame. This avoids crashes due to overrunning the bounds of
4756 frame's decode_mode_spec_buffer, which is not resized following
4757 the change of the frame dimensions from the initial 10x10.
4758
4759 * w32term.h (w32_initialize_display_info): Adjust prototype.
4760
4761 * term.c (init_tty): Take dimensions of the frame from the values
4762 returned by initialize_w32_display.
4763
7f203aa1
EZ
4764 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4765 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4766 (LIBES): Add $(GFILENOTIFY_LIBS).
4767
4768 * w32inevt.c (handle_file_notifications): Add dummy implementation
4769 for !HAVE_W32NOTIFY.
4770
4771 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4772
55a87246
JD
47732013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4774
4775 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4776
4777 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4778
4779 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4780
3d5ee10a
PE
47812013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4782
4783 Fix minor problems found by static checking.
4784 * data.c (pure_write_error):
4785 Use xsignal2, not Fsignal, as Fsignal might return.
4786 * eval.c (set_backtrace_debug_on_exit): Now static.
4787 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4788 No longer inline. EXTERN_INLINE is needed only for functions
4789 defined in .h files. Reindent function header as per GNU style.
4790 (backtrace_p, backtrace_top, backtrace_next):
4791 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4792 compiler or linker. Add extern decls to pacify gcc -Wall.
4793 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4794 Now static.
4795 * frame.c (free_monitors): Define only on platforms that need it.
4796 * nsterm.m (ns_term_init):
4797 * process.c (catch_child_signal):
4798 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4799 defined on all porting targets these days.
4800 * process.c, process.h (catch_child_signal):
4801 Make it extern only if NS_IMPL_GNUSTEP is defined.
4802
e2d8a6f0
EZ
48032013-06-03 Eli Zaretskii <eliz@gnu.org>
4804
4805 * w32.c (gettimeofday): Make the signature identical to prototype
4806 in nt/inc/sys/time.h.
4807
a8a7c5f6
SM
48082013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4809
4810 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4811 .gdbinit.
4812
4813 * keyboard.c (safe_run_hooks_error): Improve error message.
4814
4815 * data.c (pure_write_error): Add `object' argument.
4816 * puresize.h (CHECK_IMPURE): Use it.
4817
c9628c79
MA
48182013-06-03 Michael Albinus <michael.albinus@gmx.de>
4819
4820 * Makefile.in (NOTIFY_OBJ): New variable.
4821 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4822
4823 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4824 Call syms_of_gfilenotify.
4825
4826 * gfilenotify.c: New file.
4827
4828 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4829 and Qfile_w32notify.
4830 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4831 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4832
4833 * lisp.h: Declare syms_of_gfilenotify.
4834
4835 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4836
2f592f95
SM
48372013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4838
4839 Merge the specpdl and backtrace stacks. Make the structure of the
4840 specpdl entries more obvious via a tagged union of structs.
4841 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4842 (enum specbind_tag): New enum.
4843 (struct specbinding): Make it a tagged union of structs.
4844 Add a case for backtrace records.
4845 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4846 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4847 (backtrace_debug_on_exit): New accessors.
4848 (struct backtrace): Remove.
4849 (struct catchtag): Remove backlist field.
4850 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4851 Move to eval.c.
4852 (Flocal_variable_p): Speed up the common case where the binding is
4853 already loaded.
4854 * eval.c (backtrace_list): Remove.
4855 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4856 (set_backtrace_args, set_backtrace_nargs)
4857 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4858 (backtrace_next): New functions.
4859 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4860 (unwind_to_catch, internal_lisp_condition_case)
4861 (internal_condition_case, internal_condition_case_1)
4862 (internal_condition_case_2, internal_condition_case_n): Don't bother
4863 with backtrace_list any more.
4864 (Fsignal): Adjust to new backtrace format.
4865 (grow_specpdl): Move up.
4866 (record_in_backtrace): New function.
4867 (eval_sub, Ffuncall): Use it.
4868 (apply_lambda): Adjust to new backtrace format.
4869 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4870 data.c.
4871 (specbind): Adjust to new specpdl format. Simplify.
4872 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4873 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4874 backtrace format.
4875 (mark_backtrace): Remove.
4876 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4877 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4878 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4879 Use mark_specpdl.
4880 * profiler.c (record_backtrace): Use get_backtrace.
4881 (handle_profiler_signal): Use backtrace_top_function.
4882 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4883 accessor functions.
4884
c0342369
JD
48852013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4886
4887 * process.h (catch_child_signal): Declare.
4888
4889 * process.c (catch_child_signal): New function.
4890 (init_process_emacs): Call it.
4891
4892 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4893 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4894 NS_IMPL_COCOA.
4895 (x_set_cursor_type): Remove declaration.
4896 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4897 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4898 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4899 (ns_get_color): Use F suffix on float.
4900 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4901 (ns_get_rgb_color): Remove.
4902 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4903 (note_mouse_movement): x and y are CGFloat.
4904 (ns_draw_fringe_bitmap): Remove unused rowY.
4905 Change #if to COCOA && >= 10_6.
4906 (ns_draw_window_cursor): Remove unused overspill.
4907 (ns_draw_underwave): width and x are EamcsCGFloat.
4908 (ns_draw_box): thickness is CGFloat.
4909 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4910 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4911 if not in main thread.
4912 (ns_get_pending_menu_title, ns_check_menu_open)
4913 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4914 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4915 (sendFromMainThread:): New method.
4916 (changeFont:): size is CGFloat.
4917 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4918 Disable warning about permanent text.
4919 (characterIndexForPoint:): Adjust return type depending on GNUStep
4920 version.
4921 (mouseDown:): delta is CGFloat.
4922 (updateFrameSize): Remove unised variable f.
4923 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4924 Cast float to EmacsCGFloat.
4925 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4926 also to -1 when restoring.
4927 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4928 inside NS_IMPL_COCOA.
4929 (toggleFullScreen:): Put call to toggleFullScreen inside
4930 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4931 (setPosition:portion:whole:): por is CGFloat.
4932 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4933 (mouseDown:): Use CGFloat.
4934 (mouseDragged:): Remove unised variable edge.
4935 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4936
4937 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4938 of CGFloat differs.
4939 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4940 when NS_IMPL_GNUSTEP.
4941 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4942 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4943 (EmacsToolbar): Add clearAll. Add tag argument to
4944 addDisplayItemWithImage.
4945 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4946
4947 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4948
4949 * nsmenu.m (ns_update_menubar): Make static.
4950 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4951 (fillWithWidgetValue:): Add cast to SEL for setAction.
4952 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4953 (update_frame_tool_bar): Update code for GNUStep.
4954 (clearAll): New method.
4955 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4956 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4957 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4958 call to insertItemWithItemIdentifier.
4959 (validateVisibleItems): Fix indentation.
4960 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4961 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4962 UtilityWindow to aStyle, remove call to setStyleMask.
4963
4964 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4965
4966 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4967 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4968 Use F suffix on floats.
4969 (ns_char_width): Returns CGFloat.
4970 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4971 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4972 DPSxshow.
4973 (ns_glyph_metrics): CGFloat instead of float.
4974
a0eb10b3
JB
4975 * nsfns.m (x_set_foreground_color, x_set_background_color):
4976 Use EmacsCGFloat.
4977 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4978 remove unused variables.
4979 (Fns_read_file_name): Keep track if panel is for save.
4980 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4981 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4982 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4983 Just return the input if GNUStep.
c0342369
JD
4984 (x_screen_planes): Remove.
4985 (Fxw_color_values): Use EmacsCGFloat
4986 (Fns_display_monitor_attributes_list): Only get screen number for
4987 Cocoa.
ef099a94 4988 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4989 EmacsSavePanel.
4990 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4991 ns_directory_from_panel.
4992
da9aff11
PE
49932013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4994
4995 * process.c (handle_child_signal): Also use WCONTINUED.
4996 This is so that list-processes doesn't mistakenly list the process
4997 as stopped, when the process has actually been continued and is
4998 now running.
4999
0e64479a
PE
50002013-05-31 Paul Eggert <eggert@cs.ucla.edu>
5001
fc186a96
PE
5002 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
5003 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
5004 not already configured.
5005
0e64479a
PE
5006 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
5007
38b787fa
EZ
50082013-05-29 Eli Zaretskii <eliz@gnu.org>
5009
5010 * Makefile.in (mostlyclean): Remove *.res files.
5011
22513e52
SM
50122013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
5013
5014 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
5015 a buffer (bug#8447).
5016
6ef3db10
EZ
50172013-05-27 Eli Zaretskii <eliz@gnu.org>
5018
5019 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
5020 display vector, and we backtrack, handle the case that the
5021 previous character position is also displayed from a display
5022 vector or covered by a display string or image. (Bug#14476)
5023
6799bb26
JD
50242013-05-25 Jan Djärv <jan.h.d@swipnet.se>
5025
5026 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
5027 (struct MonitorInfo, free_monitors): Remove.
5028 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
5029 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
5030 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5031 Qframes, Qsource.
5032
5033 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
5034 (struct MonitorInfo, free_monitors): Remove.
5035 (ns_screen_name): Make static.
5036 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
5037 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5038 Qframes, Qsource.
5039
5040 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5041 (struct MonitorInfo): New struct.
5042 (free_monitors, make_monitor_attribute_list): Declare.
5043
22513e52
SM
5044 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
5045 New Lisp_Object:s.
6799bb26
JD
5046 (free_monitors, make_monitor_attribute_list): New functions.
5047 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
5048 Qsource.
5049
38cd43eb
XF
50502013-05-25 Xue Fuqiao <xfq.free@gmail.com>
5051
5052 * callproc.c (call_process): Refine the doc string. (Bug#14045)
5053
2af0948d
SM
50542013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
5055
a7eb9b0f
SM
5056 * keyboard.c: Apply keyboard decoding only to events that come directly
5057 from the tty, not from unread-command-events (bug#14368).
5058 (read_event_from_main_queue): New function, extracted from read_char).
5059 (read_decoded_char): Remove.
5060 (read_decoded_event_from_main_queue): New function to replace it.
5061 (read_char): Use it.
5062 (read_key_sequence): Use read_char rather than read_decoded_char.
5063
2af0948d
SM
5064 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
5065
1413e9a5
BR
50662013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
5067
5068 * casetab.c (init_casetab_once): Fix last change (bug#14424).
5069
e6d2f155
KH
50702013-05-22 Kenichi Handa <handa@gnu.org>
5071
5072 The following changes are to fix the setting of
5073 buffer-file-coding-system on, for instance, C-x RET c unix RET
5074 _FILE_OF_DOS_EOL_TYPE_ RET.
5075
5076 * coding.h (struct coding_system): New member detected_utf8_chars.
5077
5078 * coding.c (detect_coding_utf_8): Count characters and check EOL
5079 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
5080 BOM is there.
5081 (setup_coding_system): Do not initialize coding->head_ascii.
5082 (check_ascii): Do not set coding->eol_seen but update it. Do not
5083 call adjust_coding_eol_type here.
1413e9a5
BR
5084 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
5085 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
5086 of the found coding-system.
5087 (decode_coding_gap): Cancel previous change. Utilize the
5088 character numbers counted by detect_coding_utf_8. Fix detection
5089 of BOM for utf-8.
5090
ab56a6f4 50912013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
5092
5093 * search.c (looking_at_1): Only set last_thing_searched if the match
5094 changed the match-data (bug#14281).
5095
ecc3c6ed
DA
50962013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
5097
5098 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 5099 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
5100 (move_it_vertically_backward): Likewise.
5101
5ba8bf35
YM
51022013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5103
5104 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 5105 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
5106 (Fx_display_mm_width, Fx_display_mm_height):
5107 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 5108
91e8418b 5109 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 5110 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
5111 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
5112 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
5113 (Fx_display_backing_store, Fx_display_visual_class)
5114 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
5115 (Fx_display_grayscale_p, Fx_display_pixel_width)
5116 (Fx_display_pixel_height, Fx_display_planes)
5117 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
5118 (Fx_display_screens): Don't confuse X11 screens with NS screens.
5119 (Fx_display_mm_width, Fx_display_mm_height)
5120 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
5121 height for all physical monitors as in X11.
5122
fc30d803
SM
5123 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
5124 Return pixel width or height for all physical monitors as in X11.
91e8418b 5125
31ff141c
PE
51262013-05-18 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 Port --enable-gcc-warnings to clang.
5129 * bytecode.c (exec_byte_code):
5130 * regex.c:
5131 Redo diagnostic pragmas to pacify clang, too.
5132 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
5133 * editfns.c (Fencode_time):
5134 * fileio.c (file_accessible_directory_p):
5135 * font.c (font_unparse_xlfd):
5136 Use '&"string"[index]' instead of '"string" + (index)'.
5137 * undo.c (user_error): Remove; unused.
5138
df065a0b
EZ
51392013-05-16 Eli Zaretskii <eliz@gnu.org>
5140
04d360e7
EZ
5141 * insdel.c (insert_1_both): Document the arguments, instead of
5142 referring to insert_1, which no longer exists.
5143
5bb98290
EZ
5144 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
5145 some window, increment windows_or_buffers_changed, so that
5146 *Messages* display in that window is updated. (Bug#14408)
5147
df065a0b
EZ
5148 * w32.c: Include epaths.h.
5149 (init_environment): Use cmdproxy.exe without leading directories.
5150 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
5151 case.
5152 (gettimeofday): Adjust signature and return value to Posix
5153 expectations.
5154
5155 * unexw32.c (open_output_file): Delete the existing emacs.exe
5156 before creating it, to break the hard link to the versioned
5157 executable.
5158
5159 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
5160 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
5161 (FIRSTFILE_OBJ): New variables.
5162 (W32_RES): Rename to EMACSRES. All users changed.
5163 (base_obj): Use $(CM_OBJ).
5164 (ALLOBJS): Use $(FIRSTFILE_OBJ).
5165 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
5166 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
5167 $(W32_RES_LINK) before $(LIBES).
5168 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
5169
1aa8d505
SM
51702013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5171
6e911150
SM
5172 * makefile.w32-in (DOC): Use just "DOC".
5173
5174 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
5175
1aa8d505
SM
5176 * process.c: Export default filters and sentinels to Elisp.
5177 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
5178 New constants.
5179 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
5180 (Fset_process_sentinel, Fformat_network_address):
5181 Default to them instead of nil.
5182 (server_accept_connection): Sentinels can't be nil any more.
5183 (read_and_dispose_of_process_output): New function, extracted from
5184 read_process_output.
5185 (read_process_output): Use it; filters can't be nil.
5186 (Finternal_default_process_filter): New function, extracted from
5187 read_process_output.
5188 (exec_sentinel_unwind): Remove function.
5189 (exec_sentinel): Don't zilch sentinel while running.
5190 (status_notify): Sentinels can't be nil.
5191 (Finternal_default_process_sentinel): New function extracted from
5192 status_notify.
5193 (setup_process_coding_systems): Default filter is not nil any more.
5194 (syms_of_process): Export new Elisp functions and initialize
5195 new constants.
5196 * lisp.h (make_lisp_proc): New function.
5197
5ac2eb34
SM
51982013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5199
5200 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
5201
eda9c7d7
EZ
52022013-05-14 Eli Zaretskii <eliz@gnu.org>
5203
5204 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
5205 unless we know that the window w is a leaf window.
5206 Another attempt at solving bug#14062.
eda9c7d7 5207
8fdeaad5
JD
52082013-05-14 Jan Djärv <jan.h.d@swipnet.se>
5209
5210 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
5211 fdesc (Bug#14375).
5212
44aa9ee6
PE
52132013-05-12 Paul Eggert <eggert@cs.ucla.edu>
5214
5215 * image.c (gif_load): Check that subimages fit (Bug#14345).
5216
759fd763
SM
52172013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
5218
5219 * lread.c (skip_dyn_eof): New function.
5220 (read1): Use it to skip the end of a file in response to #@00.
5221
5222 * doc.c (get_doc_string): Slightly relax the sanity checking.
5223
4465bfb4
JD
52242013-05-09 Jan Djärv <jan.h.d@swipnet.se>
5225
5226 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
5227 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5228 (MonitorInfo): New struct.
5229 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
5230 (Fns_display_monitor_attributes_list): New functions.
5231 (display-usable-bounds): Remove.
5232 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
5233 Qsource.
5234
7583e2a0
PE
52352013-05-09 Paul Eggert <eggert@cs.ucla.edu>
5236
5237 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
5238 (GTK_CHECK_VERSION): New macro, if not already defined.
5239 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
5240 replaced by GTK_CHECK_VERSION.
5241
ad75d77e
PE
52422013-05-08 Paul Eggert <eggert@cs.ucla.edu>
5243
5244 * xterm.h (GTK_PREREQ): New macro.
5245 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
5246 to use this macro instead, for consistency and clarity.
5247
07525f77
EZ
52482013-05-08 Eli Zaretskii <eliz@gnu.org>
5249
5250 * xdisp.c (row_for_charpos_p): New function, with code of
5251 cursor_row_p, but accepts an additional argument CHARPOS instead
5252 of using a hardcoded PT.
5253 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
5254 (row_containing_pos): Call row_for_charpos_p instead of partially
5255 doing the same. Fixes cursor positioning under longlines-mode
5256 when longlines-show-effect includes more than one newline, when
5257 moving the cursor vertically up.
5258
d901fc8d
JB
52592013-05-08 Juanma Barranquero <lekktu@gmail.com>
5260
5261 * makefile.w32-in (ACL_H): New macro.
5262 ($(BLD)/fileio.$(O)): Update dependencies.
5263
f269bc61
PE
52642013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5265
e7b41c4c 5266 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
5267 * Makefile.in (LIB_ACL): New macro.
5268 (LIBACL_LIBS): Remove.
5269 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
5270 * fileio.c: Include <acl.h>.
5271 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
5272 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
5273 !acl_errno_valid.
5274 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
5275 it ourselves.
5276
f269bc61
PE
5277 * unexelf.c: Don't assume ElfW (Half) fits in int.
5278 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
5279 when dealing with ElfW (Half) values, since they can exceed 2**31
5280 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
5281 (entry_address): Omit unused NUM arg. All uses changed.
5282
a261c53e
JL
52832013-05-07 Juri Linkov <juri@jurta.org>
5284
5285 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
5286 to the string converted from number with `Fnumber_to_string'.
5287 (Bug#14254)
5288
2b66427d
PE
52892013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5290
5291 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
5292 This fixes a problem introduced by my previous change.
5293
15acfe41
GM
52942013-05-07 Glenn Morris <rgm@gnu.org>
5295
5296 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
5297
5ea03bf5
JD
52982013-05-07 Jan Djärv <jan.h.d@swipnet.se>
5299
5300 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
5301
e0c9d565
PE
53022013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5303
5304 Static checking by GCC 4.8.0.
5305 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
5306 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
5307 (x_get_monitor_attributes_fallback)
5308 (x_get_monitor_attributes_xinerama)
5309 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
5310 Define only if USE_GTK.
5311 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
5312 (x_get_monitor_attributes_fallback): Omit unused locals.
5313 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
5314 Use double, not float, to avoid mixed-mode floating point arithmetic.
5315
4e3f9230
YM
53162013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5317 Jan Djärv <jan.h.d@swipnet.se>
5318
5319 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
5320 (XINERAMA_CFLAGS): New macros.
5321 (ALL_CFLAGS, LIBES): Use them.
5322
5323 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
5324 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
5325 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
5326 (syms_of_xfns): DEFSYM them.
5327 (struct MonitorInfo): New struct.
5328 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
5329 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
5330 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
5331 (x_get_monitor_attributes_xinerama): New functions.
5332 (Fx_display_monitor_attributes_list): New primitive.
5333 (syms_of_xfns): Defsubr it.
5334
5335 * xterm.h (x_display_info): Add Xatom_net_workarea and
5336 Xatom_net_current_desktop.
5337
5338 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5339 and dpyinfo->Xatom_net_current_desktop.
5340
05839b6a
EZ
53412013-05-06 Eli Zaretskii <eliz@gnu.org>
5342
5343 * xdisp.c (pos_visible_p): Use the special code for finding the
5344 beginning of a display property or overlay for any "replacing"
5345 display property, not just for display strings. This solves
5346 incorrect reporting of position by posn-at-point. (Bug#14241)
5347
dc4a2ee0
PE
53482013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5349
5ee94506
PE
5350 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5351 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5352 Verify that ElfW (Half) fits in int.
5353 (fatal): Use same signature as lisp.h.
5354 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5355 configure and build with -DUNEXELF_DEBUG without worrying about
5356 other modules that use DEBUG.
5357 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5358 possibly-wide integers now uses it instead of plain fprintf.
5359 (entry_address): New function, which avoids problems with 32-bit
5360 overflow on 64-bit hosts.
5361 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5362 (round_up): Don't assume the remainder fits in int.
5363 (find_section): Use bool for boolean. Simplify debug code.
5364 (unexec): Don't assume file sizes fit in int or size_t.
5365 Omit unnecessary trailing newline in 'fatal' format.
5366 Use strerror rather than outputting decimal error number.
5367 Remove unused code when emacs is not defined;
5368 this file relies on Emacs now.
5369 Don't assume e_phnum and e_shnum are positive.
5370
dc4a2ee0
PE
5371 * regex.c: Fix problems when DEBUG is defined.
5372 (extract_number, extract_number_and_incr): Define regardless of
5373 whether DEBUG is defined; that's simpler and makes the code less
5374 likely to go stale in the normal case when DEBUG is not defined.
5375 Return int rather than taking an int * arg. All callers changed.
5376 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5377 Remove, replacing with ...
5378 (DEBUG_PRINT): New macro. All callers changed.
5379 (DEBUG_COMPILES_ARGUMENTS): New macro.
5380 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5381 (print_compiled_pattern, print_double_string) [DEBUG]:
5382 Use prototype rather than old-style definition.
5383 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5384 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5385 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5386 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5387 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5388 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5389 This matters only when DEBUG is defined.
5390
14c7ed05
EZ
53912013-05-05 Eli Zaretskii <eliz@gnu.org>
5392
5393 * xdisp.c (set_iterator_to_next): Set the
5394 ignore_overlay_strings_at_pos_p flag only if we are _really_
5395 iterating over an overlay string, as indicated by the
5396 current.overlay_string_index member. (Bug#14306)
5397
e6076b1b
JD
53982013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5399
5400 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5401 to where it is used, to avoid autorelease issues (Bug#14050).
5402
cbee2131
PE
54032013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5404
5405 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5406 * fileio.c (syms_of_fileio): Implement this.
5407 * filelock.c (create_lock_file): If symbolic links don't work, so
5408 we use a regular file as a lock file, do not fsync the lock file;
5409 it's not needed.
5410
30c7e542
SM
54112013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5412
5413 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5414 (syms_of_minibuf): Adjust accodingly.
5415 * lread.c (Fread):
5416 * callint.c (Fcall_interactively): Adjust calls accordingly.
5417
5bebd186
EZ
54182013-05-04 Eli Zaretskii <eliz@gnu.org>
5419
5420 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5421 w->contents is a buffer before computing everything else.
5422 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5423
5424 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5425 assertion violations. (Bug#14062)
5426
0fb0a4f3
DR
54272013-05-01 David Reitter <david.reitter@gmail.com>
5428
5429 * nsfns.m (ns_tooltip): Initialize.
5430
9e63b4a5
EZ
54312013-04-28 Eli Zaretskii <eliz@gnu.org>
5432
5433 * coding.c (decode_coding_gap): Don't remove the character before
5434 a newline unless it's a CR character. (Bug#14287)
5435
ad60824e
DN
54362013-04-28 Dan Nicolaescu <dann@gnu.org>
5437
5438 * dispextern.h (struct face): Move enum face_underline_type
5439 earlier so that bitfields can be in the same word.
5440
edbdcec0
JD
54412013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5442
5443 * nsfns.m (handlePanelKeys): New function.
5444 (EmacsOpenPanel:performKeyEquivalent:)
5445 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5446 arrows/function/control and copy/paste keys (Bug#14296).
5447
0208ede7
JL
54482013-04-27 Juri Linkov <juri@jurta.org>
5449
5450 * callint.c (Fcall_interactively): Call `Qread_number' for
5451 interactive code letter `n' instead of using duplicate code.
5452 (Bug#14254)
5453
b8dd59f7
PE
54542013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5455
5456 * systime.h (make_timeval): Declare as 'const'.
5457
8bd722db
KH
54582013-04-27 Kenichi Handa <handa@gnu.org>
5459
5460 * font.c (font_open_entity): Always open a font of manageable
5461 size.
5462
13d0e56f 54632013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5464
f780d632
PE
5465 Port better to AIX (Bug#14258).
5466 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5467 to pacify AIX xlc.
5468
ec509856
KH
54692013-04-24 Kenichi Handa <handa@gnu.org>
5470
5471 * coding.c (decode_coding_iso_2022): When an invalid escape
5472 sequence is encountered, reset the invocation and designation
5473 status to the safest one.
5474
84fc48e5
PE
54752013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5476
5477 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5478 Without this fix, "make distclean" leaves stamp-h1 behind.
5479
806bda47
EC
54802013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5481
5482 * w32fns.c (w32_fullscreen_rect): New function to compute the
5483 window rectangle for the given fullscreen mode.
5484 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5485 longer tunes the window size. This keeps the window's edges flush
5486 with the screen and allows the taskbar to hide itself in fullboth.
5487
5488 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5489 window decorations and uses the entire screen.
5490
5491 * w32term.h (w32_fullscreen_rect) Add prototype.
5492 (struct w32_output): Replace normal_width, normal_height,
5493 normal_top, and normal_left members with a single normal_placement
5494 struct.
5495 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5496 Remove macros.
5497 (FRAME_NORMAL_PLACEMENT): New macro.
5498
9cc2810b
JB
54992013-04-16 Juanma Barranquero <lekktu@gmail.com>
5500
5501 * minibuf.c (Ftest_completion): Silence compiler warning.
5502
fd16b54c
EZ
55032013-04-15 Eli Zaretskii <eliz@gnu.org>
5504
5505 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5506 bug#14062.
fd16b54c
EZ
5507
5508 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5509 parentheses.
5510
5511 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5512 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5513 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5514 parentheses where appropriate.
5515
9e3379a0
PE
55162013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5517
5518 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5519
ddd6b685
EZ
55202013-04-14 Eli Zaretskii <eliz@gnu.org>
5521
5522 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5523 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5524 Mention in the doc string that setting these variables takes
5525 effect only after a call to set-window-buffer. (Bug#14200)
5526
29b79ba1
EZ
55272013-04-13 Eli Zaretskii <eliz@gnu.org>
5528
5529 * indent.c (Fvertical_motion): Don't consider display strings on
5530 overlay strings as display strings on the buffer position we
5531 started from. This prevents vertical cursor motion from jumping
5532 more than one line when there's an overlay string with a display
5533 property at end of line.
5534 Reported by Karl Chen <Karl.Chen@quarl.org> in
5535 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5536
562c6ee9
SM
55372013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5538
5539 * window.c (select_window): `record_buffer' even if window is
5540 already selected (bug#14191).
5541
fcc1fe85
EZ
55422013-04-11 Eli Zaretskii <eliz@gnu.org>
5543
5544 * window.c (Fwindow_end): Test more flags, including the buffer's
5545 last_overlay_modified flag, to determine whether the window's
5546 display is really up-to-date. Prevents the function from
5547 returning a stale value. (Bug#14170)
5548 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5549 current matrix.
5550
f009190a
EZ
55512013-04-10 Eli Zaretskii <eliz@gnu.org>
5552
5553 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5554 garbaged only if it is not already the top frame on its TTY.
5555 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5556 there are GUI frames open in the same session. (Bug#13864)
5557
78ce603d
SM
55582013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5559
5560 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5561 of marking the idle timers directly.
5562
a8036e40
SM
55632013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5564
5565 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5566 tables (bug#14054).
5567
7ffe7ef6
SM
55682013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5569
5570 * window.c (select_window): Don't record_buffer while the invariant is
5571 temporarily broken (bug#14161).
5572
5573 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5574
7d9f6883
EZ
55752013-04-07 Eli Zaretskii <eliz@gnu.org>
5576
5577 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5578
5406cfd9
RF
55792013-04-07 Romain Francoise <romain@orebokech.com>
5580
5581 Ignore additional platform-specific ACL errors (Bug#13702).
5582 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5583 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5584
95c0e83b
JD
55852013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5586
5587 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5588 f->output_data.ns.
5589
876da980
PE
55902013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5591
5592 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5593 This bug was introduced by my 2013-02-25 change that simplified
5594 data_start configuration. Without this change, on GNU/Linux
5595 an Emacs configured with --enable-profiling fails immediately
5596 due to a profiler signal.
5597 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5598 with these flags. On platforms where special flags are needed
5599 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5600 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5601 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5602
7452b7bd
DA
56032013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5604
5605 Get rid of some platform-specific functions examining window
5606 system and its capabilities. This is a partial rework of the
5607 2013-04-05 change.
5608 * lisp.h (have_menus_p): Remove prototype. This function is
5609 replaced with platform-independent window_system_available.
5610 (check_window_system): Move to...
5611 * frame.h (decode_window_system_frame, window_system_available):
5612 ...here, add new prototypes.
5613 * frame.c (window_system_available, decode_window_system_frame):
5614 New functions.
5615 (check_window_system): Platform-independent now.
5616 * xterm.h (x_in_use): Remove declaration.
5617 (check_x_frame):
5618 * w32term.h (check_x_frame):
5619 * nsterm.h (check_x_frame): Remove prototypes. This function
5620 is replaced with platform-independent decode_window_system_frame.
5621 * msdos.c (have_menus_p): Remove.
5622 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5623 Remove platform-specific functions. Use check_window_system,
5624 decode_window_system_frame and check_ns_display_info where
5625 appropriate. Minor style and comment tweaks.
5626 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5627 (check_x_frame): Likewise.
5628 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5629 Likewise.
5630 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5631 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5632 * xmenu.c, xselect.c: All related users changed.
5633
251e9147
KH
56342013-04-03 Kenichi Handa <handa@gnu.org>
5635
5636 The following changes is to optimize the code for reading UTF-8
5637 files.
5638
562c6ee9 5639 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5640 changed. Check EOL format. Do not call adjust_coding_eol_type
5641 here.
5642 (check_utf_8): New function.
5643 (adjust_coding_eol_type): Do nothing if already adjusted.
5644 (detect_coding): Compare the return value of check_ascii with
5645 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5646 (decode_coding_gap): Optimize for valid UTF-8.
5647
8bc369d4
KH
56482013-03-21 Kenichi Handa <handa@gnu.org>
5649
5650 * coding.c (syms_of_coding): Cancel previous change.
5651
5652 * insdel.c (insert_from_gap): Fix previous change.
5653
73931ad1
DA
56542013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5655
5656 Consistently use platform-specific function to detect window system.
5657 * lisp.h (check_window_system): New prototype. This function is
5658 going to replace check_x, check_w32 and check_ns.
5659 (have_menus_p): Mention msdos.c in comment.
5660 * fontset.c (check_window_system_func): Remove. Adjust all users.
5661 * fontset.h (check_window_system_func): Remove prototype.
5662 * nsterm.h (check_ns):
5663 * xterm.h (check_x):
5664 * w32term.h (check_w32): Likewise.
5665 * menu.c (Fx_popup_menu): Use check_window_system.
5666 * msdos.c (check_window_system): Define for MS-DOS.
5667 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5668 * w32fns.c (check_window_system): Likewise for MS-Windows.
5669 * xfns.c (check_window_system): Likewise for X.
5670 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5671 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5672
7216e43b
PE
56732013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5674
5675 Prefer < to > in range checks such as 0 <= i && i < N.
5676 This makes it easier to visualize quantities on a number line.
5677 This patch doesn't apply to all such range checks,
5678 only to the range checks affected by the 2013-03-24 change.
5679 This patch reverts most of the 2013-03-24 change.
5680 * alloc.c (xpalloc, Fgarbage_collect):
5681 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5682 * character.c (string_escape_byte8):
5683 * charset.c (read_hex):
5684 * data.c (cons_to_unsigned):
5685 * dispnew.c (update_frame_1):
5686 * doc.c (Fsubstitute_command_keys):
5687 * doprnt.c (doprnt):
5688 * editfns.c (hi_time, decode_time_components):
5689 * fileio.c (file_offset):
5690 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5691 * font.c (font_intern_prop):
5692 * frame.c (x_set_alpha):
5693 * gtkutil.c (get_utf8_string):
5694 * indent.c (check_display_width):
5695 * keymap.c (Fkey_description):
5696 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5697 * lread.c (read1):
5698 * minibuf.c (read_minibuf_noninteractive):
5699 * process.c (wait_reading_process_output):
5700 * search.c (Freplace_match):
5701 * window.c (get_phys_cursor_glyph):
5702 * xdisp.c (redisplay_internal):
5703 * xsmfns.c (smc_save_yourself_CB):
5704 Prefer < to > for range checks.
5705 * dispnew.c (sit_for): Don't mishandle NaNs.
5706 This fixes a bug introduced in the 2013-03-24 change.
5707 * editfns.c (decode_time_components): Don't hoist comparison.
5708 This fixes another bug introduced in the 2013-03-24 change.
5709
92759988
DA
57102013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5711
5712 * frame.h (struct frame): Drop scroll_bottom_vpos
5713 member becaue all real users are dead long ago.
5714 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5715 * xdisp.c (redisplay_internal): Adjust user.
5716
9a1971bb
GM
57172013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5718
f38ab167
JD
5719 * nsmenu.m (showAtX:Y:for:): setLevel to
5720 NSPopUpMenuWindowLevel (Bug#13998).
5721
6d01f1fe
JD
57222013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5723
5724 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5725 (ns_check_pending_open_menu): Declare.
5726
5727 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5728 (x_activate_menubar): Update the menu with title that matches
5729 ns_get_pending_menu_title, and call
5730 ns_check_pending_openmenu (Bug#12698).
5731 (menuWillOpen:): New method.
5732 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5733
5734 * nsterm.m (menu_will_open_state, menu_mouse_point)
5735 (menu_pending_title): New varaibles.
5736 (ns_get_pending_menu_title, ns_check_menu_open)
5737 (ns_check_pending_open_menu): New functions.
5738
781f4782
DA
57392013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5740
5741 * indent.c (current_column_bol_cache): Remove leftover which is not
5742 used in Fmove_to_column any more.
5743 (current_column, scan_for_column): Adjust users.
5744 * keyboard.c (last_point_position_buffer, last_point_position_window):
5745 Remove leftovers which are not used for recording undo any more.
5746 (command_loop_1, syms_of_keyboard): Adjust users.
5747 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5748 redisplay_window any more.
5749 (move_it_to): Adjust user.
5750
1921c31b
JB
57512013-03-29 Juanma Barranquero <lekktu@gmail.com>
5752
5753 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5754 Update dependencies.
5755
717b8bcd
SM
57562013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5757
5758 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5759 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5760 forward references.
5761
e74aeda8
DA
57622013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5763
5764 * window.h (struct window): Replace hchild, vchild and buffer slots
5765 with the only contents slot. This is possible because each valid
5766 window may have either the child window (in vertical or horizontal
5767 combination) or buffer to display (for the leaf window). Using that,
5768 a lof of operations to traverse and/or change window hierarchies may
5769 be simplified. New member horizontal is used to distinguish between
5770 horizontal and vertical combinations of internal windows.
5771 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5772 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5773 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5774 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5775 Use contents slot, not buffer, where appropriate.
5776 (wset_combination): New function.
5777 (wset_buffer): Add eassert.
5778 (Fframe_first_window): Simplify the loop reaching first window.
5779 (Fwindow_buffer): Use WINDOW_LEAF_P.
5780 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5781 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5782 (unshow_buffer): Convert initial debugging check to eassert.
5783 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5784 (make_parent_window, window_resize_check, window_resize_apply)
5785 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5786 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5787 Adjust to match struct window changes.
5788 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5789 (mark_window_cursors_off, count_windows, get_leaf_windows)
5790 (foreach_window_1): Simplify the loop.
5791 * alloc.c (mark_object): Do not check for the leaf window because
5792 internal windows has no glyph matrices anyway.
5793 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5794 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5795 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5796 (build_frame_matrix_from_window_tree, mirror_make_current)
5797 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5798 (update_window_tree, set_window_update_flags): Simplify the loop.
5799 (sync_window_with_frame_matrix_rows): Enforce live window.
5800 Use contents slot, not buffer, where appropriate.
5801 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5802 and WINDOW_HORIZONTAL_COMBINATION_P.
5803 (make_frame_visible_1): Simplify the loop.
5804 Use contents slot, not buffer, where appropriate.
5805 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5806 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5807 (expose_window_tree): Likewise.
5808 Use contents slot, not buffer, where appropriate.
5809 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5810 to avoid deleted windows. Use contents slot instead of buffer.
5811 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5812 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5813 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5814 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5815
121ab1cd
EZ
58162013-03-28 Eli Zaretskii <eliz@gnu.org>
5817
ef454cf7
EZ
5818 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5819 identify the reasons for assertion violations in bug#14062 and
5820 similar ones.
21e930f8
EZ
5821 (Fx_show_tip): Fix compilation error under
5822 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5823
121ab1cd
EZ
5824 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5825 Reported by <rzl24ozi@gmail.com>.
5826
5c89ca24
DA
58272013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5828
5829 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5830 start marker...
562c6ee9
SM
5831 (unwind_with_echo_area_buffer): ...to restore it here.
5832 This is needed to ensure that...
5c89ca24
DA
5833 (redisplay_window): ...both window markers are valid here,
5834 which is verified by eassert.
5835 * editfns.c (save_excursion_save): Do not assume that
5836 selected_window always displays the buffer.
c7f53895
DA
5837 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5838 Fix comment.
5c89ca24 5839
f557c1b1
SM
58402013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5841
5842 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5843 the upcase table.
5844
40693bba 58452013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5846
5847 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5848
c86f791f
EZ
58492013-03-27 Eli Zaretskii <eliz@gnu.org>
5850
5851 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5852 since MinGW's w32api headers do. This avoids compiler warnings.
5853
5854 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5855 if already defined.
5856
c6e72e17
EZ
58572013-03-26 Eli Zaretskii <eliz@gnu.org>
5858
5859 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5860
54e95010
JD
58612013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5862
5863 * gtkutil.c (style_changed_cb): Check if frame is live and an
5864 X frame (Bug#14038).
5865
b88b62de
EZ
58662013-03-26 Eli Zaretskii <eliz@gnu.org>
5867
a18d7de6
EZ
5868 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5869 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5870 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5871 MinGW64.
8f5e14c8
EZ
5872 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5873 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5874
b88b62de
EZ
5875 Fix incompatibilities between MinGW.org and MinGW64 headers.
5876 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5877
5878 * w32.c (REPARSE_DATA_BUFFER): Guard with
5879 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5880
c074e458
JD
58812013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5882
5883 * xterm.c: Include X11/XKBlib.h
5884 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5885
908589fd
AS
58862013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5887
5888 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5889 written backwards.
5890 * blockinput.h (input_blocked_p): Likewise.
5891 * bytecode.c (exec_byte_code): Likewise.
5892 * callproc.c (call_process_kill, call_process_cleanup)
5893 (Fcall_process): Likewise.
5894 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5895 (Fccl_execute_on_string): Likewise.
5896 * character.c (string_escape_byte8): Likewise.
5897 * charset.c (read_hex): Likewise.
5898 * cm.c (calccost): Likewise.
5899 * data.c (cons_to_unsigned): Likewise.
5900 * dired.c (directory_files_internal, file_name_completion):
5901 Likewise.
5902 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5903 (sit_for): Likewise.
5904 * doc.c (Fsubstitute_command_keys): Likewise.
5905 * doprnt.c (doprnt): Likewise.
5906 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5907 * emacsgtkfixed.c: Likewise.
5908 * fileio.c (file_offset, Fwrite_region): Likewise.
5909 * floatfns.c (Fexpt, fmod_float): Likewise.
5910 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5911 Likewise.
5912 * font.c (font_intern_prop): Likewise.
5913 * frame.c (x_set_alpha): Likewise.
5914 * gtkutil.c (get_utf8_string): Likewise.
5915 * indent.c (check_display_width): Likewise.
5916 * intervals.c (create_root_interval, rotate_right, rotate_left)
5917 (split_interval_right, split_interval_left)
5918 (adjust_intervals_for_insertion, delete_node)
5919 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5920 (merge_interval_right, merge_interval_left, copy_intervals)
5921 (set_intervals_multibyte_1): Likewise.
5922 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5923 * keymap.c (Fkey_description): Likewise.
5924 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5925 * lread.c (openp, read_integer, read1, string_to_number):
5926 Likewise.
5927 * menu.c (ensure_menu_items): Likewise.
5928 * minibuf.c (read_minibuf_noninteractive): Likewise.
5929 * print.c (printchar, strout): Likewise.
5930 * process.c (create_process, Faccept_process_output)
5931 (wait_reading_process_output, read_process_output, send_process)
5932 (wait_reading_process_output): Likewise.
5933 * profiler.c (make_log, handle_profiler_signal): Likewise.
5934 * regex.c (re_exec): Likewise.
5935 * regex.h: Likewise.
5936 * search.c (looking_at_1, Freplace_match): Likewise.
5937 * sysdep.c (get_child_status, procfs_ttyname)
5938 (procfs_get_total_memory): Likewise.
5939 * systime.h (EMACS_TIME_VALID_P): Likewise.
5940 * term.c (dissociate_if_controlling_tty): Likewise.
5941 * window.c (get_phys_cursor_glyph): Likewise.
5942 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5943 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5944 Likewise.
5945 * xfns.c (Fx_window_property): Likewise.
5946 * xmenu.c (set_frame_menubar): Likewise.
5947 * xselect.c (x_get_window_property, x_handle_dnd_message):
5948 Likewise.
5949 * xsmfns.c (smc_save_yourself_CB): Likewise.
5950 * xterm.c (x_scroll_bar_set_handle): Likewise.
5951
2bf7d27a
DA
59522013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5953
5954 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5955 to be optional or nil. Adjust comment and convert it to docstring.
5956 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5957 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5958
a9ebfa0b
PE
59592013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5960
5961 Static checking by GCC 4.8-20130319.
5962 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5963 * process.c (Fset_process_datagram_address)
5964 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5965 * xdisp.c (get_char_face_and_encoding):
5966 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5967 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5968 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5969
4f3576ee
KB
59702013-03-24 Ken Brown <kbrown@cornell.edu>
5971
789b5e9a
KB
5972 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5973 fix compilation on 64-bit Cygwin, where underscores are not
5974 automatically prepended.
5975
4f3576ee
KB
5976 * w32term.c (w32_initialize): Silence compiler warning.
5977
b5b7745f
EZ
59782013-03-23 Eli Zaretskii <eliz@gnu.org>
5979
cdc0d0bd
EZ
5980 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5981 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5982 variables, to save and restore frame dimensions.
5983 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5984 after returning from a 'fullscreen' configuration.
5985 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5986 to avoid races between the main thread and the input thread.
5987
5988 * w32term.h (struct w32_output): New members normal_width,
5989 normal_height, normal_top, normal_left, and prev_fsmode.
5990 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5991 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5992 members of a frame.
5993
b5b7745f
EZ
5994 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5995 'fullscreen' parameter. Always record previous width and height
5996 of the frame, except when switching out of maximized modes, so
5997 that they could be restored correctly, instead of resetting to the
5998 default frame dimensions. Send SC_RESTORE command to the frame,
5999 unless we are going to send SC_MAXIMIZE, to restore the frame
6000 resize hints in the mouse pointer shown by the window manager.
6001 (Bug#14032)
6002
6003 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
6004
6005 * lisp.h (get_frame_param): Adjust conditions for prototype
6006 declaration.
6007
a3454eed
KB
60082013-03-22 Ken Brown <kbrown@cornell.edu>
6009
6010 * unexcw.c: Drop unneeded inclusion of w32common.h.
6011 (report_sheap_usage): Declare.
6012 (read_exe_header): Add magic numbers for x86_64.
6013 (fixup_executable): Fix printf format specifier for unsigned long
6014 argument.
6015
5a49b79c
DA
60162013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
6017
6018 * frame.h (struct frame): Put menu_bar_window under #ifdef
6019 because this member is not needed when X toolkit is in use.
6020 (fset_menu_bar_window):
6021 * dispnew.c (clear_current_matrices, clear_desired_matrices)
6022 (free_glyphs, update_frame):
6023 * xdisp.c (expose_frame): Likewise.
6024 (display_menu_bar): Likewise. Remove redundant eassert.
6025 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
6026 toolkit is in use.
6027
d6723bf7
PE
60282013-03-21 Paul Eggert <eggert@cs.ucla.edu>
6029
7b1123d8
PE
6030 Use functions and constants to manipulate Lisp_Save_Value objects.
6031 This replaces code that used macros and strings and token-pasting.
6032 The change makes the C source a bit easier to follow,
6033 and shrinks the Emacs executable a bit.
6034 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
6035 (make_save_value): Change 1st arg from string to enum. All callers
6036 changed.
6037 (INTX): Remove.
6038 (mark_object): Use if, not #if, for GC_MARK_STACK.
6039 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
6040 (XSAVE_OBJECT): Now functions, not macros.
6041 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
6042 the constant was never used.
6043 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
6044 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
6045 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
6046 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
6047 New constants.
6048 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
6049 type3 with a single member save_type. All uses changed.
6050 (save_type, set_save_pointer, set_save_integer): New functions.
6051 * print.c (PRINTX): Remove.
6052
d6723bf7
PE
6053 * alloc.c: Remove redundant static declarations.
6054
5f24fa51
DA
60552013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6056
6057 * window.h (struct window): Convert left_col, top_line, total_lines
6058 and total_cols from Lisp_Objects to integers. Adjust comments.
6059 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
6060 Remove.
6061 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
6062 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
6063 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
6064 Adjust users where appropriate.
6065
42143acd
DA
60662013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6067
6068 * frame.h (struct frame): Drop resx and resy because the same data is
6069 available from window system-specific output context. Adjust users.
562c6ee9
SM
6070 (default_pixels_per_inch_x, default_pixels_per_inch_y):
6071 New functions to provide defaults when no window system available.
42143acd 6072 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 6073 (NUMVAL): Move from xdisp.c.
42143acd
DA
6074 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
6075 (Ffont_face_attributes, Fopen_font):
6076 * image.c (gs_load):
6077 * w32font.c (fill_in_logfont):
6078 * xdisp.c (calc_pixel_width_or_height):
6079 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
6080 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
6081
c0a17406
KH
60822013-03-20 Kenichi Handa <handa@gnu.org>
6083
6084 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
6085 to 1 (temporary workaround until a bug related to ASCII
6086 optimization is fixed).
6087
095d384d
DA
60882013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
6089
6090 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
6091 Signal error if window is not internal. Adjust docstring.
6092 (delete_all_child_windows): Use combination_limit to save the buffer.
6093 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
6094 * print.c (syms_of_print): Initialize debugging output not here...
6095 (init_print_once): ...but in a new function here.
6096 * lisp.h (init_print_once): Add prototype.
6097 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 6098
748fa866
DA
60992013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
6100
6101 * window.c (window_resize_check, window_resize_apply)
6102 (window_from_coordinates, recombine_windows, set_window_buffer)
6103 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
6104 (Fsplit_window_internal, Fdelete_window_internal)
6105 (freeze_window_starts): Use bool for booleans.
6106 * window.h (window_frame_coordinates, resize_frame_windows)
6107 (freeze_window_starts, set_window_buffer): Adjust prototypes.
6108
81519fd2
SM
61092013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
6110
6111 * dispnew.c (bitch_at_user): Use `user-error'.
6112
6db423a9
KB
61132013-03-17 Ken Brown <kbrown@cornell.edu>
6114
6115 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
6116 as return type of image_background. (Bug#13981)
6117 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
6118
8f2906f5
JD
61192013-03-16 Jan Djärv <jan.h.d@swipnet.se>
6120
960ce480 6121 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 6122 (ns_select): Don't return with result uninitialized.
960ce480 6123
8f2906f5
JD
6124 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
6125 and getDirectory.
6126
81519fd2
SM
6127 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
6128 New functions.
8f2906f5
JD
6129 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
6130 directories. If filename is nil, get directory name (Bug#13932).
6131 Use getFilename and getDirectory.
6132 (getFilename, getDirectory): New methods for EmacsSavePanel and
6133 EmacsOpenPanel.
6134 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
6135
cded56c1
PE
61362013-03-15 Paul Eggert <eggert@cs.ucla.edu>
6137
6138 * coding.c (decode_coding_gap): Fix typo caught by static checking.
6139
251e9147 61402013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
6141
6142 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
6143 (adjust_after_replace): Make it back to static. Delete the third
6144 arg text_at_gap_tail. Cancel the code for handling it.
6145
6146 * coding.h (struct coding_system): New member eol_seen.
6147
6148 * coding.c (detect_ascii): New function.
6149 (detect_coding): Set coding->head_ascii and coding->eol_seen only
6150 when the source bytes are actually scanned. On detecting for
6151 coding_category_utf_8_auto, call detect_ascii instead of scanning
6152 source bytes directly.
6153 (produce_chars): Call insert_from_gap with the new arg 0.
6154 (encode_coding): Likewise.
6155 (decode_coding_gap): Control ASCII optimization by the variable
6156 disable_ascii_optimization instead of #ifndef .. #endif.
6157 Deccode EOL format according to coding->eol_seen.
6158 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
6159 variable.
6160
8a44e6d1
KH
6161 * lisp.h (adjust_after_replace): Cancel externing it.
6162 (insert_from_gap): Adjust prototype.
6163
5f795e34
EZ
61642013-03-15 Eli Zaretskii <eliz@gnu.org>
6165
6166 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
6167 FULLSCREEN_MAXIMIZED. (Bug#13935)
6168
f258b4be
DA
61692013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
6170
6171 * region-cache.c (find_cache_boundary, move_cache_gap)
6172 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
6173 Simplify debugging check and convert to eassert. Adjust comment.
6174 (pp_cache): Put under ENABLE_CHECKING.
6175
a5cc4dde
EZ
61762013-03-14 Eli Zaretskii <eliz@gnu.org>
6177
6178 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
6179 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
6180 and WM_ACTIVATEAPP.
6181 (w32fullscreen_hook): If the frame is visible, reset
6182 f->want_fullscreen flag after changing the frame size. If the
6183 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
6184 (Bug#13953)
6185
3fc5e44a
DC
61862013-03-13 Daniel Colascione <dancol@dancol.org>
6187
6188 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
6189 too so that these builds can use Cygwin's file conversion
6190 functions. (We've been building and linking cygw32.o all along
6191 and just not using it.)
6192
47d7532e
PE
61932013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6194
6195 File synchronization fixes (Bug#13944).
6196 * Makefile.in (LIB_FDATASYNC): New macro.
6197 (LIBES): Use it.
6198 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
6199 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
6200 Don't worry about HAVE_FSYNC, since a substitute fsync is
6201 available if the system lacks one.
6202 (Fwrite_regin): Retry fsync if interrupted.
6203
c7ffccaf
EZ
62042013-03-13 Eli Zaretskii <eliz@gnu.org>
6205
4e2df81d 6206 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
6207 activated, call w32fullscreen_hook, to make sure the new frame
6208 dimensions are in effect. (Bug#13937)
6209
8a7debc1
DA
62102013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
6211
6212 * xdisp.c (init_iterator): Simplify because both character and byte
6213 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
6214 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
6215 character and byte positions can be obtained from marker.
8a7debc1 6216
7fd8c501
PE
62172013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6218
d9df6f40
PE
6219 Static checking by Sun C 5.12.
6220 * alloc.c (buffer_memory_full) [REL_ALLOC]:
6221 * bytecode.c (exec_byte_code):
6222 * dispnew.c (init_display):
6223 * eval.c (error):
6224 * fileio.c (Fsubstitute_in_file_name):
6225 * keyboard.c (Fevent_convert_list):
6226 * keymap.c (Fsingle_key_description):
6227 * term.c (maybe_fatal, fatal):
6228 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
6229 * xsmfns.c (Fhandle_save_session):
6230 Omit unreachable code.
6231 * keymap.c (map_keymap_char_table_item): Cast void * to
6232 a function pointer type; the C Standard requires this.
6233
7fd8c501
PE
6234 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
6235 Include <sys/param.h> unconditionally, as that works elsewhere and
6236 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
6237 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
6238 and FreeBSD now.
6239
a020afb9 6240See ChangeLog.12 for earlier changes.
aac0c6e3
MR
6241
6242;; Local Variables:
6243;; coding: utf-8
aac0c6e3
MR
6244;; End:
6245
ab422c4d 6246 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
6247
6248 This file is part of GNU Emacs.
6249
6250 GNU Emacs is free software: you can redistribute it and/or modify
6251 it under the terms of the GNU General Public License as published by
6252 the Free Software Foundation, either version 3 of the License, or
6253 (at your option) any later version.
6254
6255 GNU Emacs is distributed in the hope that it will be useful,
6256 but WITHOUT ANY WARRANTY; without even the implied warranty of
6257 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6258 GNU General Public License for more details.
6259
6260 You should have received a copy of the GNU General Public License
6261 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.