* dispnew.c (clear_glyph_row, copy_row_except_pointers):
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9da0f50e
PE
12013-09-24 Paul Eggert <eggert@cs.ucla.edu>
2
3 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
4 Prefer signed to unsigned integers where either will do.
5 No need for 'const' on locals that do not escape.
6 Omit easserts with unnecessary and unportable assumptions about
7 alignment. Avoid unnecessary casts to char *.
8
d6d9cbc1
DA
92013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
10
11 Use union for the payload of struct Lisp_Vector.
12 This helps to avoid a few glitches dictated by C's aliasing rules.
13 * lisp.h (struct Lisp_Vector): Use union for next and
14 contents member. Adjust comment. Change related users.
15 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
16 Related users changed.
17 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
18 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
19 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
20 * xfaces.c, xfont.c, xmenu.c: Related users changed.
21
ec7bc82f
DA
222013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
23
24 Optimize glyph row clearing and copying routines.
25 * dispextern.h (struct glyph_row): Change layout of struct
26 glyph_row to help copy_row_except_pointers. Adjust comment.
27 * dispnew.c (null_row): Remove.
28 (clear_glyph_row): Use offsetof and memset to find and clear
29 just the members that need clearing. Adjust comment.
30 (copy_row_except_pointers): Likewise for copying.
31
d160dd0c
PE
322013-09-24 Paul Eggert <eggert@cs.ucla.edu>
33
7be68de5
PE
34 Some minor cleanups of recently-added bool vector code.
35 * conf_post.h (assume): Always return void. Use lint version
36 only if GCC and MSC versions don't apply.
37 * conf_post.h (assume):
38 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
39 Depend on _MSC_VER, not __MSC_VER, for consistency with
40 the rest of Emacs.
41 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
42 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
43 (bool_vector_binop_driver, count_trailing_zero_bits)
44 (size_t_to_host_endian): Now static, not static inline;
45 the latter isn't needed with modern compilers and doesn't
46 work with older compilers anyway.
47
d160dd0c
PE
48 * alloc.c (valgrind_p): Use bool for boolean.
49
e08813d0
DA
502013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
51
52 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
53 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
54 (display_last_displayed_message_p, message_buf_print)
55 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
56 Use bool for boolean.
3a6a78fd
DA
57 * dispextern.h (cancel_line, init_desired_glyphs):
58 Remove ancient leftover.
59 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
60 * lisp.h (noninteractive_need_newline): Adjust declaration.
61
5492865b
DA
622013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
63
64 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
65 Move to...
66 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
67 ...this file and convert the latter to static. Adjust comment.
68 (make_initial_frame):
69 * window.c (init_window_once): Adjust user.
70 * frame.h (last_nonminibuf_frame): Remove declaration.
71 * lisp.h (selected_frame): Likewise.
72 * msdos.c (the_only_display_info): Adjust comment.
73
cd548fa4
EZ
742013-09-23 Eli Zaretskii <eliz@gnu.org>
75
f03eddbf
EZ
76 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
77 computing the end column of mouse-highlight that comes from
78 display or overlay strings. (Bug#15437)
b519df23
EZ
79 (note_mouse_highlight): Adapt calculation of last argument to
80 mouse_face_from_string_pos to the above change.
f03eddbf 81
cd548fa4
EZ
82 * conf_post.h (__has_builtin): Define to zero, if undefined, on
83 all platforms, not just for clang.
84
8762e524
JD
852013-09-23 Jan Djärv <jan.h.d@swipnet.se>
86
87 * filelock.c (lock_file_1): Rearrange to remove compiler warning
88 about excess arguments to snprintf.
89
90 * conf_post.h(assume): Use __builtin_unreachable for clang.
91
d4a9284f
JB
922013-09-23 Juanma Barranquero <lekktu@gmail.com>
93
94 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
95 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
96
a84683fd
DC
972013-09-23 Daniel Colascione <dancol@dancol.org>
98
99 * alloc.c (USE_VALGRIND): New macro; on by default
100 when ENABLE_CHECKING.
101 (mark_maybe_object,mark_maybe_pointer)
102 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
103 valgrind purposes.
104 (valgrind_p) [USE_VALGRIND]: New variable.
105 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
106
8fef36c6
JD
1072013-09-22 Jan Djärv <jan.h.d@swipnet.se>
108
fb83ea63
JD
109 * process.c (wait_reading_process_output): Change int pnamelen to
110 socklen_t.
111
112 * nsterm.m (setMarkedText:selectedRange:):
113 (deleteWorkingText):
114 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
115 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
116 argument to unsigned long to avoid warning.
117 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
118
8fef36c6
JD
119 * conf_post.h (assume): Fix compiler error: x shall be cond.
120
cd9356f2
DC
1212013-09-22 Daniel Colascione <dancol@dancol.org>
122
123 * xfns.c (x_get_monitor_attributes): Suppress unused variable
124 warning when compiling without a window system.
125
3e0b94e7
DC
1262013-09-22 Daniel Colascione <dancol@dancol.org>
127
128 * data.c (Qbool_vector_p): New symbol.
129 (bool_vector_spare_mask,popcount_size_t_generic)
130 (popcount_size_t_msc,popcount_size_t_gcc)
131 (popcount_size_t)
132 (bool_vector_binop_driver)
133 (count_trailing_zero_bits,size_t_to_host_endian)
134 (Fbool_vector_exclusive_or)
135 (Fbool_vector_union)
136 (Fbool_vector_intersection,Fbool_vector_set_difference)
137 (Fbool_vector_subsetp,Fbool_vector_not)
138 (Fbool_vector_count_matches)
139 (Fbool_vector_count_matches_at): New functions.
140 (syms_of_data): Intern new symbol, functions.
141 * alloc.c (bool_vector_payload_bytes): New function.
142 (Fmake_bool_vector): Instead of calling Fmake_vector,
143 which performs redundant initialization and argument checking,
144 just call allocate_vector ourselves. Make sure we clear any
145 terminating padding to zero.
146 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
147 instead of open-coding the size calculation.
148 (vroundup_ct): New macro.
149 (vroundup): Assume argument >= 0; invoke vroundup_ct.
150 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
151 * composite.c (composition_gstring_put_cache): Change
152 lint_assume to assume.
153 * conf_post.h (assume): New macro.
154 (lint_assume): Remove.
155 * dispnew.c (update_frame_1): Change lint_assume to assume.
156 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
157 to assume.
158 * image.c (gif_load): Change lint_assume to assume.
159 * lisp.h (eassert_and_assume): New macro.
160 (Qbool_vector_p): Declare.
161 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
162 (swap16,swap32,swap64): New inline functions.
163 * macfont.c (macfont_shape): Change lint_assume to assume.
164 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
165 * xsettings.c (parse_settings): Use new swap16 and
166 swap32 from lisp.h instead of file-specific macros.
167
76880d88
EZ
1682013-09-22 Eli Zaretskii <eliz@gnu.org>
169
170 * xdisp.c (try_window_id): Don't abort if cursor row could not be
171 found (which can legitimately happen when the glyph row at the
172 window start is disabled in the current_matrix. (Bug#15365)
173
c6cfd910
PE
1742013-09-22 Paul Eggert <eggert@cs.ucla.edu>
175
176 Fix syntax.h bug introduced by recent INLINE change.
177 syntax.h defined an extern inline function SYNTAX_ENTRY that was
178 conditionally compiled one way in some modules, and a different
179 way in others. This doesn't work with extern inline functions,
180 which must have the same definition in all modules, because the
181 defining code might be shared across modules, depending on the
182 implementation. Symptoms reported by Martin Rudalics in:
183 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
184 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
185 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
186 overriding the corresponding functions in syntax.h.
187 * syntax.h (syntax_property_entry, syntax_property_with_flags)
188 (syntax_property): New inline functions.
189 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
190 Rewrite in terms of these new functions.
191
b3f1d119
EZ
1922013-09-21 Eli Zaretskii <eliz@gnu.org>
193
194 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
195 not chars_in_text, whose result depends on the multibyteness of
196 the current buffer. (Bug#15426)
197
00382e8b
PE
1982013-09-20 Paul Eggert <eggert@cs.ucla.edu>
199
e3b29769
PE
200 Port recent change to hosts where pointers aren't 'long'.
201 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
202 Don't assume that pointers are the same width as 'long'.
203 Add a compile-time check that a pointer fits into two X slots.
204
00382e8b
PE
205 A simpler, centralized INLINE.
206 * conf_post.h (INLINE): Define only if not already defined.
207 This allows us to use a single INLINE, defined by one file
208 per executable.
209 * emacs.c (INLINE): Define it.
210 Also, include category.h, charset.h, composite.h, dispextern.h,
211 syntax.h, systime.h, so that their INLINE definitions are expanded
212 properly for Emacs.
213 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
214 * buffer.h, buffer.c (BUFFER_INLINE):
215 * category.h, category.c (CATEGORY_INLINE):
216 * character.h, character.c (CHARACTER_INLINE):
217 * charset.h, charset.c (CHARSET_INLINE):
218 * composite.h, composite.c (COMPOSITE_INLINE):
219 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
220 * frame.h, frame.c (FRAME_INLINE):
221 * intervals.h, intervals.c (INTERVALS_INLINE):
222 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
223 * lisp.h, alloc.c (LISP_INLINE):
224 * process.h, process.c (PROCESS_INLINE):
225 * syntax.h, syntax.c (SYNTAX_INLINE):
226 * systime.h, sysdep.c (SYSTIME_INLINE):
227 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
228 * window.h, window.c (WINDOW_INLINE):
229 Remove. All uses replaced with INLINE.
230
2b943ba6
DA
2312013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
232
233 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
234 to avoid Bug#15398.
235
13d9698a
EZ
2362013-09-19 Eli Zaretskii <eliz@gnu.org>
237
238 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
239 'const char *' to avoid compiler warnings due to similar change in
240 the prototype of x_get_string_resource.
241
ced135eb
DA
2422013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
243
244 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
245 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
246 going to replace static variables below. Adjust comments.
247 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
248 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
249 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
250 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
251 Related users changed.
252 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
253 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
254 last_mouse_movement_time, going to replace static variables below.
255 Adjust comments.
256 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
257 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
258 Remove.
259 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
260 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
261 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
262 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
263 static variables below.
264 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
265 (last_mouse_scroll_bar): Remove.
266 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
267 (mouseExited): Related users changed.
268
091f1e1f
DA
2692013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Do not use external array to process X scroll bar messages.
272 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
273 (x_send_scroll_bar_event): Pack window pointer into two slots
274 of XClientMessageEvent if we're 64-bit. Adjust comment.
275 (x_scroll_bar_to_input_event): Unpack accordingly.
276
582ed56c
DA
2772013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
278
279 Ifdef away recent changes which aren't relevant to NS port.
280 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
281 [!HAVE_NS]: Declare as such.
282 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
283 [!HAVE_NS]: Define as such.
284
18da0d8a
DA
2852013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
286
287 * frame.c (x_redo_mouse_highlight): New function
288 to factor out common code used in W32 and X ports.
289 * dispextern.h (x_redo_mouse_highlight): Add prototype.
290 * xterm.h (struct x_display_info):
291 * w32term.h (struct w32_display_info):
292 * nsterm.h (struct ns_display_info): New members
293 last_mouse_motion_frame, last_mouse_motion_x and
294 last_mouse_motion_y, going to replace static variables below.
295 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
296 (redo_mouse_highlight): Remove.
297 (note_mouse_movement, syms_of_xterm): Adjust user.
298 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
299 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
300 (redo_mouse_highlight): Remove.
301 (note_mouse_movement, syms_of_w32term): Adjust user.
302 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
303 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
304 Remove.
305 (note_mouse_movement, mouseMoved, syms_of_nsterm):
306 * nsfns.m (compute_tip_xy): Adjust user.
307
7a0c745a
DA
3082013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
309
310 * frame.c (x_mouse_grabbed): New function.
311 * dispextern.h (x_mouse_grabbed): Add prototype.
312 (last_mouse_frame): Remove declaration.
313 * xterm.h (struct x_display_info):
314 * w32term.h (struct w32_display_info):
315 * nsterm.h (struct ns_display_info): New member
316 last_mouse_frame, going to replace...
317 * xdisp.c (last_mouse_frame): ...global variable.
318 (note_tool_bar_highlight):
319 * w32term.c (w32_mouse_position, w32_read_socket):
320 * xterm.c (XTmouse_position, handle_one_xevent):
321 Use x_mouse_grabbed.
322 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
323
0791d107
DA
3242013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
325
326 * w32term.c (w32_read_socket): Avoid temporary
327 variables in a call to x_real_positions.
328 * xterm.c (handle_one_xevent): Likewise.
329
2cd98812
DA
3302013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
331
332 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
333 (x_icon_type): Remove prototype.
334 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
335 * frame.c (x_icon_type): Remove.
336 * w32term.c (x_make_frame_visible, x_iconify_frame):
337 * xterm.c (x_make_frame_visible, x_iconify_frame):
338 Use x_set_bitmap_icon to factor out common code.
339
a6c2ee1b
DA
3402013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
341
342 * dispextern.h (check_x_display_info, x_get_string_resource):
343 Declare here just once and unify the latter.
344 * frame.c (check_x_display_info, x_get_string_resource):
345 * nsterm.h (check_x_display_info):
346 * xrdb.c (x_get_string_resource):
347 * xterm.h (check_x_display_info): Remove prototypes.
348 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
349 * w32reg.c (x_get_string_resource): Likewise.
350 (w32_get_rdb_resource): Adjust user.
351
baed3603
DA
3522013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
353
354 * xterm.h (struct x_display_info): New member
355 x_pending_autoraise_frame, going to replace...
356 * xterm.c (pending_autoraise_frame): ...static variable.
357 (x_new_focus_frame, XTread_socket): Adjust users.
358 * w32term.h (struct w32_display_info): New member
359 w32_pending_autoraise_frame, going to replace...
360 * w32term.c (pending_autoraise_frame): ...global variable.
361 (x_new_focus_frame, w32_read_socket): Adjust users.
362
90582f05
GM
3632013-09-17 Glenn Morris <rgm@gnu.org>
364
365 * xdisp.c (message_dolog): If we create *Messages*,
366 switch it to messages-buffer-mode.
367
b7ad2f74
PE
3682013-09-17 Paul Eggert <eggert@cs.ucla.edu>
369
370 Don't overuse 'const' in types of locals.
371 * bidi.c (bidi_count_bytes):
372 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
373 (xg_event_is_for_scrollbar):
374 * xselect.c (x_handle_property_notify)
375 (x_handle_selection_notify, x_handle_dnd_message):
376 * xsettings.c, xsettings.h (xft_settings_event):
377 * xterm.c (x_handle_net_wm_state, handle_one_event)
378 (x_menubar_window_to_frame, x_detect_focus_change)
379 (construct_mouse_click, note_mouse_movement)
380 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
381 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
382 (handle_one_xevent, x_handle_net_wm_state):
383 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
384 (x_handle_dnd_message):
385 Avoid unnecessary 'const', typically the second 'const' in
386 'const foo * const arg', a 'const' that does not affect the API
387 and doesn't significantly help the human reader.
388
19452b86
DA
3892013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
390
391 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
392 only if Glib < 2.36.0.
393 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
394 * xsettings.c (init_gconf, init_gsettings): Do not check
395 for g_type_init.
1893694e
DA
396 * xterm.c (handle_one_xevent): Do not call to x_clear_area
397 if GTK >= 2.7.0.
33b83dd7 398 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 399
6434e343
JD
4002013-09-16 Jan Djärv <jan.h.d@swipnet.se>
401
3f386383
JD
402 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
403 before calling g_type_init.
404
6434e343
JD
405 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
406
407 * nsterm.m (syms_of_nsterm): ... to here.
408
83a119f8
DA
4092013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
410
411 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
412 (ignore_next_mouse_click_timeout): Use Time as X does.
413 (handle_one_xevent): Avoid cast and use unsigned comparison.
414
61582e6a
DA
4152013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
416
417 Do not copy X event in handle_one_xevent except KeyPress case.
418 Wnen XEvent is processed, it is unlikely to be changed except
419 KeyPress case, so we can avoid copying and use const pointer to
420 const data to make sure that an event is not changed elsewhere.
421 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
422 const' and do not create local copy except for the KeyPress event.
423 Use casts to avoid a few glitches. Adjust formatting. Add comments.
424 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
425 (x_handle_net_wm_state, x_menubar_window_to_frame)
426 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
427 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
428 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
429 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
430 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
431 (x_handle_dnd_message):
432 * xsettings.c (xft_settings_event):
433 Use 'const XEvent * const' where appropriate.
434 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
435
f8eb1572
DA
4362013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
437
438 Fix X event waiting to handle multiple frames.
439 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
440 * xterm.c (pending_event_wait): Remove. Adjust users.
441 (x_detect_focus_change): Pass frame arg.
442 (handle_one_xevent): Find related frame early and clear per-frame
443 wait_event_type only if this is an event for the relevant frame.
444 (x_wait_for_event): Use per-frame wait_event_type.
445
3fa2054e
JD
4462013-09-15 Jan Djärv <jan.h.d@swipnet.se>
447
745d3809
JD
448 * nsfns.m (Fx_create_frame): Fix font driver registration for
449 GNUStep.
450
451 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
452 for syms_of_macfont.
453
3fa2054e
JD
454 * nsterm.m: Include macfont.h.
455 (ns_tmp_flags, ns_tmp_font): Remove.
456 (ns_compute_glyph_string_overhangs): Check for driver Qns.
457 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
458 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
459 (changeFont:): Fix code style. Check for font driver type when
460 getiing font.
461
462 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
463 (f)->descent.
464
465 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
466 (nsfont_open): Set font driver type.
467 Set font->ascent and font->descent. Figure out font instead of
468 ns_tmp_font, and flags instead of ns_tmp_flags.
469 Fix indentation. Remove call to ns_draw_text_decoration,
470 moved to nsterm.
471
472 * nsfns.m: Include macfont.h.
473 (Fx_create_frame): Register macfont driver, make a better default font.
474 (Fns_popup_font_panel): Get font from macfont driver, if used.
475
476 * macfont.m, macfont.h, maccuvs.h: New files.
477
478 * font.h: Declare syms_of_macfont.
479
480 * font.c (syms_of_font): Call syms_of_macfont.
481
482 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
483
0eed0355
DA
4842013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
485
486 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
487 and it is always zero for others, so I assume that this is an ancient
488 leftover which nobody will want to change any more.
489 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
490 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
491 * frame.c (x_set_scroll_bar_width):
492 * w32fns.c (w32_createscrollbar):
493 * w32term.c (w32_set_vertical_scroll_bar):
494 * xfns.c (x_set_scroll_bar_default_width):
495 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
496 (x_scroll_bar_expose): Related users changed.
497
07013c68
DA
4982013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
499
500 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
501 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
502 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
503 Define as such.
c7cc32f7
DA
504 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
505 Define once here...
506 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
507 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
508 Remove unused Xisms.
7f09455e
DA
509 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
510 these modules are never compiled otherwise.
07013c68 511
0df00f59
EZ
5122013-09-14 Eli Zaretskii <eliz@gnu.org>
513
08a209bf 514 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
515 Doc fix. (Bug#15375)
516
fcd42c11
DA
5172013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
518
519 Unify Fx_focus_frame between all ports.
520 * frame.h (x_focus_frame): New prototype.
521 * xfns.c (Fx_focus_frame): Remove.
522 (syms_of_xfns): Do not defsubr it.
523 (x_focus_frame): X implementation.
524 * nsfns.m (Fx_focus_frame): Remove.
525 (syms_of_nsfns): Do not defsubr it.
526 (x_focus_frame): NS implementation.
527 * w32term.c (Fx_focus_frame): Remove.
528 (x_focus_on_frame): Rename to...
529 (x_focus_frame): W32 implementation.
530 * w32term.h (x_focus_on_frame): Remove prototype.
531 * w32fns.c (Fx_focus_frame): Remove.
532 (syms_of_w32fns): Do not defsubr it.
533 * frame.c (Fx_focus_frame): Define here.
534 (syms_of_frame): Defsubr here.
535 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
536
aad3612f
DA
5372013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
538
539 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
540 All of them are replaced with FRAME_DISPLAY_INFO, defined in
541 each port to reference the port-specific window system data.
542 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
543 (FRAME_DISPLAY_INFO): Define.
544 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
545 (FRAME_DISPLAY_INFO): Define. Adjust users.
546 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
547 (FRAME_DISPLAY_INFO): Define. Adjust users.
548 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
549 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
550 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
551 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
552 * xselect.c, xterm.c: All related users changed.
553
9a650e62
DA
5542013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
555
556 * xterm.h (x_window_to_frame, x_any_window_to_frame)
557 (x_menubar_window_to_frame): Remove prototypes.
558 * xfns.c (x_window_to_frame, x_any_window_to_frame)
559 (x_menubar_window_to_frame, x_top_window_to_frame):
560 Move from here...
561 * xterm.c (x_window_to_frame, x_any_window_to_frame)
562 (x_menubar_window_to_frame, x_top_window_to_frame):
563 ...to here and convert all but the last to static.
564
347ae3e1
EZ
5652013-09-12 Eli Zaretskii <eliz@gnu.org>
566
567 * lisp.mk (lisp): Add w32-common-fns.elc.
568
15c6d837
XF
5692013-09-12 Xue Fuqiao <xfq.free@gmail.com>
570
571 * charset.c (char_charset): Document an exception for char-charset.
572
27e90f77
DA
5732013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
574
575 * xterm.h (x_display_info): New field last_user_time...
576 * xterm.c (toplevel): ...to replace static last_user_time.
577 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
578
8ffbc36b
DA
5792013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
580
581 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
582 scroll bar values to prevent thumb from disappear and update comment.
583
5ec0337a
GM
5842013-09-11 Glenn Morris <rgm@gnu.org>
585
586 * emacs.c (usage_message): Possessive apostrophe tweak.
587
fb55b9d1
DA
5882013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
589
8d2db8be
DA
590 * nsterm.m (syms_of_nsterm): Use Qns.
591 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
592 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
593 * xfns.c (x_display_info_for_name, Fx_open_connection):
594 Remove old '#if 0' code.
595 (syms_of_xfns): Use Qx.
fb55b9d1
DA
596 * termhooks.h (fullscreen_hook): Remove the leftover.
597 (struct terminal): Fix typo in comment.
598
927eec55
DA
5992013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Cleaning up a few X scroll bar bits.
602 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
603 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
604 New member last_seen_part, going to replace...
605 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
606 (xt_action_hook) [USE_LUCID]: Adjust user.
607 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
608 Lucid-specific scroll bar support.
609 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
610 to int and adjust to use last_seen_part member.
611 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
612 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
613 Initialize last_seen_part.
614
71b28baa
SM
6152013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
616
617 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
618 insert-buffer-substring an empty string.
619
f5dacaae
PE
6202013-09-11 Paul Eggert <eggert@cs.ucla.edu>
621
622 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
623 avoiding a GCC warning.
624
742516e0
DA
6252013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
626
627 Ifdef away frame tool bar code when it is not really used.
628 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
629 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
630 and minimize_tool_bar_window_p under the above.
631 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
632 (fset_tool_bar_window): Likewise.
633 * dispnew.c (clear_current_matrices, clear_desired_matrices)
634 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
635 (change_frame_size_1):
636 * window.c (window_from_coordinates, Frecenter): Adjust users.
637 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
638 code is not really used.
639 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
640 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
641 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
642 [!USE_GTK && !HAVE_NS]: Define as such.
643 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
644 (note_mouse_highlight, expose_frame):
645 * xfns.c (x_set_tool_bar_lines):
646 * xterm.c (handle_one_xevent): Adjust users.
647
73f82c7e
PE
6482013-09-11 Paul Eggert <eggert@cs.ucla.edu>
649
650 Fix corruption with multiple emacsclient -t instances (Bug#15222).
651 This bug was introduced by my 2013-08-26 patch, which incorrectly
652 assumed that the terminfo implementation doesn't use termcap buffers.
653 * term.c (init_tty) [TERMINFO]: Remove optimization, as
654 these buffers apparently are used after all.
655 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
656 (struct tty_display_info): Define members termcap_term_buffer and
657 termcap_strings_buffer even if TERMINFO.
658
53482f41
DA
6592013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
660
661 Fix last change.
662 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
663 'usage' docstring entry to pacify make-docfile.
664
6652013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
666
667 Change comparison functions =, <, >, <=, >= to take many arguments.
668 * data.c: Change comparison functions' interface and implementation.
669 * lisp.h: Make arithcompare available for efficient two arg
670 comparisons.
671 * bytecode.c: Use arithcompare.
672 * fileio.c: Use new interface.
673
533f258f
SM
6742013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
675
676 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
677
8c27f5ff
SM
6782013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
679
680 * eval.c (Feval): Document the new use of `lexical'.
681
0750a308
DA
6822013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
683
684 Review and drop old frame resize hack.
685 * frame.h (struct frame): Remove force_flush_display_p.
686 * dispnew.c (update_frame): Adjust user and don't call
687 flush_frame here. The comment has said that there was an issues
688 with redisplaying fringes, but I don't see any differences with
689 and without this hack. Hopefully we can continue without it.
690 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
691 current frame matrices twice if resized_p is set.
692
83fc0554
DA
6932013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
694
695 Do not populate pure Xism x_sync to other ports.
696 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
697 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
698 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
699 * w32term.h (x_sync): Remove prototype.
700
fd462129
DA
7012013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
702
703 Cleanup frame flushing.
8c27f5ff
SM
704 * dispextern.h (struct redisplay_interface):
705 Drop flush_display_optional because flush_display is enough
fd462129
DA
706 for X and flushing via RIF is just a no-op for others.
707 * frame.h (flush_frame): New function.
708 * dispnew.c (update_frame):
709 * minibuf.c (read_minibuf):
710 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
711 Use it.
712 * keyboard.c (detect_input_pending_run_timers): Do not flush
713 all frames but selected one in redisplay_preserve_echo_area.
714 * nsterm.m (ns_flush): Remove no-op.
715 (ns_redisplay_interface): Adjust user.
716 * w32term.h (x_flush): Remove no-op.
717 (w32_redisplay_interface): Adjust user.
718 * xterm.c (x_flush): Simplify because we do not flush all
719 frames at once any more. Adjust comment.
720 (x_redisplay_interface): Adjust user.
721
4b73fc73
PE
7222013-09-07 Paul Eggert <eggert@cs.ucla.edu>
723
724 Port --without-x --enable-gcc-warnings to Fedora 19.
725 * gfilenotify.c (globals_of_gfilenotify):
726 Call g_type_init only if using an older glib version that needs it.
727
77394d40
DA
7282013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
729
730 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
731 (last_glyphless_glyph_merged_face_id): Remove declarations.
732 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
733 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
734 (last_glyphless_glyph_merged_face_id): Now static.
735 (merge_escape_glyph_face): New function, refactored from...
736 (get_next_display_element): ...here.
737 (merge_glyphless_glyph_face): New function, refactored from...
738 (produce_glyphless_glyph): ...here...
739 * term.c (produce_glyphless_glyph): ...and here.
740
306d67bd
SM
7412013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
742
743 * eval.c (eval_sub): Only call Ffunction if necessary.
744
7f6c6450
DA
7452013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
746
747 Attempt to make redisplay more selective when changing cursor type.
748 * frame.h (struct frame): New bitfield cursor_type_changed.
749 * xdisp.c (cursor_type_changed): Remove.
750 (try_cursor_movement, redisplay_window, try_window_id)
751 (set_frame_cursor_types, try_window_reusing_current_matrix):
752 Adjust to use per-frame bitfield.
753 (redisplay_internal): Look for cursor type change on each visible
754 frame and consider all frames if cursor type has been changed on
755 the frame other than selected. If cursor type has been changed on
756 selected frame only, do not use fast update.
757
bd0443bb
DA
7582013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Attempt to make redisplay more selective when changing fonts.
761 * frame.h (struct frame): New bitfield fonts_changed.
762 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
763 (adjust_frame_glyphs): Add prototype.
764 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 765 (adjust_glyphs): Remove because we do not
bd0443bb
DA
766 adjust matrices on all frames at once any more.
767 (adjust_frame_glyphs): Block and unblock input here.
768 (adjust_glyph_matrix): Use fonts_changed.
769 (change_frame_size_1): Use adjust_frame_glyphs.
770 * font.c (font_open_entity): Use fonts_changed.
771 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
772 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
773 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
774 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
775 (shrink_mini_window, Fresize_mini_window_internal)
776 (window_scroll_pixel_based, Fset_window_configuration)
777 (apply_window_adjustment, Fset_window_vscroll):
778 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
779 Use adjust_frame_glyphs.
780 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
781 (try_window_reusing_current_matrix, try_window_id, display_line)
782 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
783 (redisplay_internal): Consider fonts_changed and adjust frame
784 matrices for each frame only if the frame is visible. If font
785 has been changed on some frame during full redisplay, retry
786 only visible frames where the font has been actually changed.
787
b9695828
DA
7882013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
789
790 Cache current header and mode line height for each window.
791 * window.h (struct window): New fields mode_line_height
792 and header_line_height.
793 * window.c (make_window): Initialize them.
794 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
795 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
796 (current_mode_line_height, current_header_line_height):
797 Remove declaration.
798 * xdisp.c (current_mode_line_height, current_header_line_height):
799 Remove.
800 (pos_visible_p, init_xdisp): Adjust user.
801 (redisplay_window): Invalidate mode_line_height and
802 header_line_height if current and desired matrices do not agree.
803
66738305
DA
8042013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
805
806 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
807 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
808
257b3b03
DA
8092013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
810
811 Make --without-x compatible with --enable-gcc-warnings.
812 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
813 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
814 members under HAVE_WINDOW_SYSTEM.
815 * keyboard.c (make_lispy_focus_out): Likewise.
816 (record_menu_key): Move under HAVE_MENUS.
817 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
818 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
819 (syms_of_xdisp): Adjust user.
820 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
821 (start_hourglass, cancel_hourglass):
822 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
823 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
824 and CLEAR_FONT_TABLE_NFONTS.
825 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
826 Declare only if HAVE_WINDOW_SYSTEM.
827 (lface_same_font_attributes_p, clear_face_gcs): Define only
828 if HAVE_WINDOW_SYSTEM.
829
98b7f4bd
DA
8302013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
831
832 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
833 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
834 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
835
a7e43722
SM
8362013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
837
838 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
839
0c90b9ee
PE
8402013-09-04 Paul Eggert <eggert@cs.ucla.edu>
841
842 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
843 This fixes a type error on hosts where ptrdiff_t is wider than int.
844
d99760fa
SM
8452013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
846
6629638e
SM
847 * keyboard.c (read_key_sequence_vs): New function.
848 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
849 common code.
850
d99760fa
SM
851 * callint.c (Fcall_interactively): Always return a vector for 'K'.
852
224e313d
PE
8532013-09-04 Paul Eggert <eggert@cs.ucla.edu>
854
855 Makefile improvements.
856 * Makefile.in (config.status): Don't use double-colon rules, as
857 they are not portable according to POSIX. Fix shell typo with `;
858 I guess this rule has never been tested?
859 (VCSWITNESS): New macro, to override any environment var.
860
6d6ed1af
DA
8612013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
862
863 * xterm.h (struct x_display_info): Do not track X connection
864 fd separately because it is always available from Display.
865 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
866 Adjust users.
867
bc923770
DA
8682013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
869
870 * buffer.c (drop_overlay):
871 * fileio.c (restore_point_unwind): Prefer unchain_marker to
872 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
873
b1cf96de
DA
8742013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
875
876 * buffer.c (Fmake_overlay, Fmove_overlay):
877 * intervals.c (set_point_from_marker):
878 * print.c (PRINTPREPARE): Prefer signal_error
879 to plain error and report unsuitable marker too.
880
d1fc6c21
DA
8812013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
882
883 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
884 for 'dragging' member.
d1ae6a0b
DA
885 (struct x_output): Remove set-but-unused leftovers
886 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
887 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
888 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
889 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
890 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
891 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
892 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 893 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 894 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 895
0ce9f6de
JD
8962013-09-03 Jan Djärv <jan.h.d@swipnet.se>
897
898 * nsfont.m (INVALID_GLYPH): New define.
899 (nsfont_encode_char): Use INVALID_GLYPH.
900 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
901
b594a96c
DA
9022013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
903
904 * xterm.c (x_last_mouse_movement_time): Revert last change.
905 This code should use XDisplayMotionBufferSize to check display's
906 motion history first, and there are few other issues as well.
907 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
908 (handle_one_xevent): Adjust user.
909
8b098236
MR
9102013-09-02 Martin Rudalics <rudalics@gmx.at>
911
9718b207
MR
912 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
913 * frame.c (Flast_nonminibuf_frame): ... to here.
914 (check_minibuf_window): Don't abort if no window was found
915 (Bug#15247).
8b098236 916
84e70bba
DA
9172013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
918
919 Use XGetMotionEvents to ask the last mouse motion time from X server.
920 * xterm.c (X_MOTION_HISTORY): Default to 1.
921 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
922 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
923 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
924 Ifdef away legacy code.
925 (XTmouse_position, x_scroll_bar_report_motion):
926 Use x_last_mouse_movement_time.
fc85e20b
DA
927 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
928 UnmapNotify event.
84e70bba 929
1fccc530
DA
9302013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
931
932 * msdos.c (last_mouse_window): Move to...
933 (dos_rawgetc): ...this function and adjust comment.
934 * nsterm.m (last_window): Rename to last_mouse_window, move to...
935 (mouseMoved): ...this function and adjust comment.
936 * w32term.c (last_window): Likewise with...
937 (w32_read_socket): ...this function.
938 * xterm.c (last_window): Likewise with...
939 (handle_one_xevent): ...this function.
940
0ab10992
DA
9412013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
942
b7da754d 943 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
944 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
945 (handle_one_xevent): ...to here.
946 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
947 otherwise.
948
0c7f856e
DA
9492013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
950
951 * msdos.c (IT_set_terminal_window): Remove no-op.
952 (initialize_msdos_display): Adjust terminal setup.
953 * w32console.c (w32con_set_terminal_window): Remove no-op.
954 (initialize_w32_display): Adjust terminal setup.
955 * w32term.c (w32_set_terminal_window): Remove no-op.
956 (w32_create_terminal): Adjust terminal setup.
957 * xterm.c (XTset_terminal_window): Remove no-op.
958 (x_create_terminal): Adjust terminal setup.
959
a892a94c
DA
9602013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
961
962 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
963 Remove no-ops.
964 (ns_create_terminal): Adjust terminal setup.
965 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
966 Remove no-ops.
967 (w32_create_terminal): Adjust terminal setup.
968 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
969 Remove no-ops.
970 (x_create_terminal): Adjust terminal setup.
971
cf91889a
DA
9722013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
973
974 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
975 (CLIP_TEXT_POS_FROM_MARKER): New macro.
976 * dispnew.c (buffer_posn_from_coords):
977 * window.c (Fwindow_end, displayed_window_lines):
978 * xdisp.c (redisplay_mode_lines): Use it.
979
5b0891df
JD
9802013-09-01 Jan Djärv <jan.h.d@swipnet.se>
981
982 * fontset.c (face_for_char): Check char in the current face font first
983 if HAVE_NS (Bug#15138).
984
0a357e98
MR
9852013-08-31 Martin Rudalics <rudalics@gmx.at>
986
987 * window.c (temp_output_buffer_show): Make sure window returned
988 by display_buffer is live (Bug#15213).
989
9d7693d7
DA
9902013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
991
992 Minor cleanup to avoid forward declarations.
993 * coding.h (struct ccl_spec): Remove forward declaration.
994 * composite.h (toplevel): Include font.h.
995 (struct composition_it, struct face, struct font_metrics):
996 Remove forward declaration.
997 * dispextern.h (struct image, struct atimer): Likewise.
998 * emacsgtkfixed.h (struct frame): Likewise.
999 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1000 * font.h (struct font_driver, struct font, struct glyph_string)
1001 (struct face): Remove forward declaration.
1002 * fontset.h (struct face, struct font): Likewise.
1003 * frame.h (toplevel): Style cleanup.
1004 (enum output_method): Move to...
1005 * termhooks.h (enum output_method): ...here.
1006 (struct glyph, struct frame, struct ns_display_info)
1007 (struct x_display_info, struct w32_display_info):
1008 Remove forward declaration.
1009 * xterm.h (toplevel): Include termhooks.h.
1010 (struct font, struct window, struct glyph_matrix, struct frame)
1011 (struct input_event, struct face, struct image): Remove forward
1012 declaration.
1013 * gtkutil.h (struct _widget_value): Likewise.
1014 * keyboard.h (toplevel): Include termhooks.h.
1015 (struct input_event): Remove forward declaration.
1016
032f7451
DA
10172013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1018
1019 * intervals.c (set_point_from_marker): New function.
1020 * editfns.c (Fgoto_char):
1021 * process.c (Finternal_default_process_filter):
1022 * window.c (select_window_1): Use it.
1023 * buffer.h (set_point_from_marker): Add prototype.
1024
3f940c5a
EZ
10252013-08-29 Eli Zaretskii <eliz@gnu.org>
1026
1027 * w32.c (term_winsock): Call release_listen_threads before calling
1028 WSACleanup.
1029 (_sys_wait_accept): Wait for accept event in a loop with a finite
1030 timeout, instead of waiting indefinitely. Will hopefully avoid
1031 hanging during exit because WSACleanup deadlocks waiting for the
1032 event object to be released. (Bug#14333)
1033
1034 * w32proc.c (release_listen_threads): New function, signals all
1035 the reader threads that listen for connections to stop waiting.
1036
1037 * w32.h (release_listen_threads): Add prototype.
1038
101ed2bb
DA
10392013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1040
1041 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1042 field of new marker (for sanity and safety).
20de2834
DA
1043 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1044 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1045
1f5cf200
DA
10462013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1049 (x_after_update_window_line, x_scroll_bar_create):
1050 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1051 (handle_one_xevent, x_clear_frame_area):
1052 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1053 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1054 * xterm.h (x_clear_area): Adjust prototype.
1055
d2b36813
DA
10562013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1057
1058 Hook scanning and indentation functions to find_newline. This helps
1059 to avoid duplicated code and renders more respect to newline cache.
1060 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1061 * cmds.c (Fforward_line):
1062 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1063 Use find_newline and avoid unnecessary point movements.
1064 * search.c (scan_newline): Implement on top of find_newline.
1065
3ec7babc
SM
10662013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1067
1068 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1069 scoped code (bug#11258).
1070
5ab473cd
JD
10712013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1072
1073 * nsterm.m (last_window): New variable.
1074 (EV_TRAILER2): New macro.
1075 (EV_TRAILER): Call EV_TRAILER2.
1076 (mouseMoved:): Add support for mouse-autoselect-window
1077 on nextstep (Bug#6888).
1078
78779650
AS
10792013-08-28 Andreas Schwab <schwab@suse.de>
1080
1081 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1082 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1083 Remove unused macro definitions.
1084 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1085 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1086 Only define if emacs.
78779650 1087
c3c4768d
DA
10882013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1089
1090 Prefer enum glyph_row_area to int where appropriate.
1091 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1092 Fix comment.
1093 (window_box, window_box_width, window_box_left, window_box_left_offset)
1094 (window_box_right, window_box_right_offset): Adjust prototypes.
1095 * xdisp.c (window_box, window_box_width, window_box_left)
1096 (window_box_left_offset, window_box_right, window_box_right_offset):
1097 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1098 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1099 * nsterm.m (ns_clip_to_row):
1100 * w32term.c (w32_clip_to_row):
1101 * xterm.c (x_clip_to_row): Likewise.
1102
6bdcbfe1
DA
11032013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1104
1105 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1106 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1107
50b13cde
PE
11082013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1111 for portability to hosts where /bin/sh has problems.
1112
f60e429a
DA
11132013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 Redesign redisplay interface to drop global output_cursor.
1116 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1117 (toplevel): Remove declaration of output_cursor.
1118 (set_output_cursor, x_cursor_to): Remove prototype.
1119 * window.h (struct window): New member output_cursor.
1120 (output_cursor_to): New function to replace RIF member.
1121 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1122 (update_text_area, set_window_cursor_after_update): Use it.
1123 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1124 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1125 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1126 * w32term.c (x_update_window_begin, x_update_window_end):
1127 * xterm.c (x_update_window_begin, x_update_window_end):
1128 Adjust to use per-window output cursor.
1129
43aac990
PE
11302013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1131
d486344e
PE
1132 Simplify SELECT_TYPE-related code.
1133 Like EMACS_TIME, this portability layer is no longer needed, since
1134 Emacs has been using fd_set as a portability layer for some time.
1135 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1136 (SELECT_TYPE): Remove. All uses changed to fd_set.
1137 (fd_set) [!FD_SET]: New typedef.
1138
43aac990
PE
1139 Simplify EMACS_TIME-related code.
1140 This portability layer is no longer needed, since Emacs has been
1141 using struct timespec as a portability layer for some time.
1142 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1143 Include <time.h> rather than "systime.h"; that's all that's needed now.
1144 * dispnew.c: Include <timespec.h> rather than "systime.h";
1145 that's all that's needed now.
1146 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1147 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1148 TIMESPEC_RESOLUTION.
1149 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1150 LOG10_TIMESPEC_RESOLUTION.
1151 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1152 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1153 (make_emacs_time): Remove. All used changed to make_timespec.
1154 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1155 (current_timespec): Rename from current_emacs_time. All uses changed.
1156 (add_emacs_time): Remove. All uses changed to timespec_add.
1157 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1158 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1159 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1160 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1161 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1162 (current_timespec): Rename from current_emacs_time. All uses changed.
1163 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1164 changed to timespec_cmp.
1165 * xgselect.c: Include <timespec.h>, since our .h files don't.
1166
d350e350
DA
11672013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1168
1169 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1170 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1171 Remove the leftovers.
1172 * gtkutil.c (toplevel): Do not declare Qxft but include
1173 font.h to do so.
1174 * image.c (toplevel): Do not declare Vlibrary_cache because
1175 it's already done in lisp.h.
1176
9fed9729
DA
11772013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1178
1179 * lisp.h (Mouse_HLInfo): Move from here...
1180 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1181 (reset_mouse_highlight): New function.
1182 * msdos.c (dos_set_window_size, IT_update_begin)
1183 (internal_terminal_init):
1184 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1185 (ns_initialize_display_info):
1186 * w32console.c (initialize_w32_display):
1187 * w32term.c (x_update_window_end, x_free_frame_resources)
1188 (w32_initialize_display_info):
1189 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1190 * window.c (Fdelete_other_windows_internal):
1191 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1192 * termchar.h (toplevel):
1193 * xterm.h (toplevel): Include dispextern.h.
1194
f462f075
PE
11952013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 Fix minor problems found by static checking.
1198 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1199 (expect): Avoid nested-if warning.
1200 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1201 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1202 * nsterm.h, nsterm.m (ns_select):
1203 * xgselect.c, xgselect.h (xg_select):
1204 Adjust signature to better match pselect's.
1205 * nsterm.m (ns_select):
1206 Don't set *TIMEOUT, since pselect doesn't.
1207 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1208 diagnostic about assigning const char * to it.
1209 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1210
068f9124
SM
12112013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1212
1213 * lread.c (substitute_object_recurse): Handle hash-tables as well
1214 (bug#15190).
1215
f5adc984
PE
12162013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1217
1fc8eb33
PE
1218 Fix unlikely core dump in init_tty, and simplify terminfo case.
1219 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1220 The old version incorrectly dumped core if malloc returned a
1221 buffer containing only non-NUL bytes.
1222 (init_tty): Do not allocate or free termcap buffers; the
1223 struct does that for us now.
1224 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1225 (struct tty_display_info): Define members termcap_term_buffer and
1226 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1227 use them. Allocate them directly in struct rather than indirectly
1228 via a pointer, to simplify init_tty.
1229
f5adc984
PE
1230 * frame.c (check_minibuf_window): Initialize 'window' properly,
1231 so that Emacs reliably aborts later if 'window' is not initialized.
1232
efec3894
JD
12332013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1234
1235 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1236 of VoidSymbol (Bug#15154).
1237
e1d0341e
DA
12382013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1239
1240 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1241 mouse_face_beg_y and mouse_face_end_y.
1242 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1243 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1244 Adjust users and update comment where appropriate.
1245
bfff6445
MR
12462013-08-26 Martin Rudalics <rudalics@gmx.at>
1247
1248 * frame.c (check_minibuf_window): New function.
068f9124
SM
1249 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1250 Call check_minibuf_window (Bug#15183).
bfff6445 1251
c80016b3
DA
12522013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1253
1254 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1255 because this is the only last cursor data we need to keep and consult.
1256 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1257 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1258 Adjust users.
1259
de396731
DA
12602013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1261
068f9124
SM
1262 Fix recovering from possible decompression error.
1263 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1264 the position where the partially decompressed data ends, and
447218dd 1265 should count how many bytes was produced so far.
de396731
DA
1266 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1267 (unwind_decompress): Really delete partially uncompressed data.
1268 (Fzlib_decompress_region): Take decompressed data size into account.
1269
c76826d9
DA
12702013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1271
1272 * syntax.c (init_syntax_once): Adjust comment and do an early
1273 initialization of Qchar_table_extra_slots just once...
1274 * casetab.c (init_casetab_once):
1275 * category.c (init_category_once):
1276 * character.c (syms_of_character):
1277 * coding.c (syms_of_coding):
1278 * xdisp.c (syms_of_xdisp): ...and omit it here.
1279
b34454d0
EZ
12802013-08-24 Eli Zaretskii <eliz@gnu.org>
1281
11f20add
EZ
1282 * xdisp.c (get_next_display_element): Don't apply to characters
1283 from a display vector the logic of setting it->end_of_box_run_p
1284 suitable for characters from a buffer. (Bug#15175)
1285
b34454d0
EZ
1286 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1287 to handle directories, rather than '_utime' which doesn't.
1288 (Bug#15176)
1289
6e1b469e
JD
12902013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1291
1292 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1293 or fullscreen (Bug#14627).
1294
9c05bccf
PE
12952013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1296
1297 System-dependent integer overflow fixes.
1298 * process.c (Fset_process_window_size): Signal an error if
1299 the window size is outside the range supported by the lower level.
1300 * sysdep.c (set_window_size): Return negative on error,
1301 nonnegative on success, rather than -1, 0, 1 on not in system,
1302 failure, success. This is simpler. Caller changed.
1303 (serial_configure): Remove unnecessary initialization of local.
1304 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1305 size fits in unsigned long; this isn't true on some 32-bit hosts.
1306 Avoid buffer overrun if some future version of /proc/meminfo has a
1307 variable name longer than 20 bytes.
1308 (system_process_attributes) [__FreeBSD__]:
1309 Don't assume hw.availpages fits in 'int'.
1310
c365c355
PE
13112013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 Don't let very long directory names overrun the stack.
1314 Fix some related minor problems involving "//", vfork.
1315 * callproc.c (encode_current_directory): New function.
1316 (call_process): Don't append "/"; not needed.
1317 * fileio.c (file_name_as_directory_slop): New constant.
1318 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1319 this can save the caller having to alloca.
1320 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1321 Use SAFE_ALLOCA, not alloca.
1322 (directory_file_name, Fexpand_file_name): Leave leading "//"
1323 alone, since it can be special even on POSIX platforms.
1324 * callproc.c (call_process):
1325 * process.c (Fformat_network_address):
1326 * sysdep.c (sys_subshell):
1327 Use encode_current_directory rather than rolling our own.
1328 (create_process): No need to encode directory; caller does that now.
1329 * process.h (encode_current_directory): New decl.
1330 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1331 Rework to avoid 'goto xyzzy;'.
1332
6c6014d4
EZ
13332013-08-23 Eli Zaretskii <eliz@gnu.org>
1334
1335 * xdisp.c (handle_face_prop): If the default face was remapped use
1336 the remapped face for strings from prefix properties. (Bug#15155)
1337
9997ec56
DA
13382013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1339
1340 Minor cleanup for redisplay interface and few related functions.
1341 * frame.h (enum text_cursor_kinds): Move from here...
1342 * dispextern.h (enum text_cursor_kinds): ...to here.
1343 (toplevel): Drop unnecessary declarations.
1344 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1345 in update_window_end_hook and draw_window_cursor functions.
1346 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1347 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1348 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1349 * xterm.c (x_update_window_end, x_draw_window_cursor):
1350 * xdisp.c (display_and_set_cursor, update_window_cursor)
1351 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1352 enum text_cursor_kinds where appropriate.
1353
7f780da6
DA
13542013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1355
1356 Redesign redisplay interface to drop updated_row and updated_area.
1357 * dispextern.h (updated_row, updated_area): Remove declaration.
1358 (struct redisplay_interface): Pass glyph row and row area parameters
1359 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1360 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1361 Adjust prototypes.
1362 * dispnew.c (updated_row, updated_area): Remove.
1363 (redraw_overlapped_rows, update_window_line): Adjust user.
1364 (update_marginal_area, update_text_area): Likewise. Pass updated row
1365 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1366 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1367 Adjust users.
1368
26495794
PE
13692013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 * process.c (flush_pending_output): Remove stub.
1372 All uses removed.
1373
4a88129a
PE
13742013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 * callproc.c: Fix race that killed background processes (Bug#15144).
1377 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1378 Record deleted process-id in critical section, not afterwards.
1379 Don't mistakenly kill process created by a call-process invocation
1380 that discards output and does not wait.
1381
0c5307b0
DA
13822013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1383
1384 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1385 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1386 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1387 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1388 to shut up compiler in mark_object.
1389 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1390
0d7c1e66
PE
13912013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1394 We can't portably rely on PTY_OPEN doing that, even if
1395 it calls posix_openpt with O_CLOEXEC.
1396
3f246b65
KH
13972013-08-20 Kenichi Handa <handa@gnu.org>
1398
1399 * character.c (string_char): Improve commentary.
1400
8c2f38aa
PE
14012013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1404 (struct animation_cache): Make signature a flexible array member.
1405 All uses changed. This is a tad slower but may insulate us better
1406 from future changes to ImageMagick.
1407
bb566cea
PE
14082013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * image.c: Shrink memory needed for animation cache.
1411 (SIGNATURE_DIGESTSIZE): New constant.
1412 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1413 (imagemagick_create_cache): Copy the signature. This saves
1414 several KB of memory that ImageMagick wastes per signature.
1415 Don't bother updating the update_time, as the caller does that now.
1416 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1417 it's a fixed size struct member now.
1418 (imagemagick_get_animation_cache): Always destroy the signature,
1419 as it's now imagemagick_create_cache's responsibility to copy it.
1420 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1421 and use memcmp rather than strcmp.
1422 eassert that ImageMagick returns a signature of the specified length.
1423
6da26928
LMI
14242013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1425
1426 * image.c (imagemagick_get_animation_cache): Don't segfault on
1427 each invocation.
453f4022
LMI
1428 (imagemagick_get_animation_cache): Revert to previous definition
1429 so that it actually works. But keep the memory leak fix.
1430 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1431
22490125
PE
14322013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1433
d0139df5
PE
1434 * image.c: Fix animation cache signature memory leak.
1435 Fix some other minor performance problems while we're at it.
1436 (imagemagick_create_cache): Clear just the members that
1437 need clearing. Don't set update_time, as caller does that now.
1438 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1439 Simplify by using pointer-to-pointer instead of a prev pointer.
1440 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1441 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1442 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1443 it's already a copy. Free the signature probe unless it's cached.
1444
22490125
PE
1445 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1446 This was introduced by my 2013-08-12 fix for Bug#15035.
1447
deb31e75
DA
14482013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1449
1450 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1451 (imagemagick_prune_animation_cache): Now static.
1452
319a4d03
LMI
14532013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1454
1455 * image.c (imagemagick_get_animation_cache): Don't segfault when
1456 pruning all entries.
1457
f747d82e
KB
14582013-08-18 Ken Brown <kbrown@cornell.edu>
1459
1460 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1461 static heap if ENABLE_CHECKING is defined.
1462 (max_bss_sbrk_ptr): New variable.
1463 (bss_sbrk): Use it.
1464 (report_sheap_usage): Report maximum static heap usage instead of
1465 ending static heap usage.
1466
d2c28fab
EZ
14672013-08-17 Eli Zaretskii <eliz@gnu.org>
1468
1469 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1470 of zlib_initialized according to the results of calling
1471 init_zlib_functions.
1472
274ff63f
LMI
14732013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1474
1475 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1476 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1477 (imagemagick_load_image): Remove the ping_wand code, which only
1478 apparently saved time on invalid animated images, and slowed down
1479 everything else. Optimise for the common case.
274ff63f 1480
2bede2ed
XF
14812013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1482
70ff8240
XF
1483 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1484
de179a3e
XF
1485 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1486
2bede2ed
XF
1487 * marker.c (set_marker): Remove documentation of undefined behavior.
1488
703dbeba
LMI
14892013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1490
1491 * image.c (imagemagick_compute_animated_image): Animate correctly
1492 when sub-images are smaller than the main image.
1d18b1e6
LMI
1493 (imagemagick_compute_animated_image): Setting the iterator row to
1494 zero is apparently not allowed.
79670014
LMI
1495 (imagemagick_compute_animated_image): Allow images that say they
1496 have sub-images that are bigger than the main image, but just crop
1497 them.
703dbeba 1498
63216c5e
JD
14992013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1500
1501 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1502
a5b5f73f
LMI
15032013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1504
1505 * image.c (imagemagick_compute_animated_image): Respect the GIF
1506 disposal methods.
1507
0fe73012
KB
15082013-08-15 Ken Brown <kbrown@cornell.edu>
1509
1510 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1511 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1512 needed.
1513
691a357f
PE
15142013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 Fix minor problems found by static checking.
1517 * frame.c (delete_frame):
1518 * xdisp.c (next_element_from_display_vector):
1519 Avoid uninitialized local.
1520 * image.c (imagemagick_compute_animated_image): Port to C89.
1521 Prefer usual GNU indentation style for loops.
1522 Be more careful about bizarrely large sizes, by using ptrdiff_t
1523 instead of int.
1524
42fe2e88
DA
15252013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1526
1527 Fix infinite frame selection loop (Bug#15025).
1528 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1529
d39a3da6
EZ
15302013-08-15 Eli Zaretskii <eliz@gnu.org>
1531
068f9124
SM
1532 * xdisp.c (compute_window_start_on_continuation_line):
1533 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1534 to make sure we end up setting the window start at the leftmost
1535 visible character of the display line. This avoids funky
1536 horizontal shifting because the window start is not kept on the
1537 same position. (Bug#15090)
05426239
EZ
1538 (next_element_from_display_vector): Support 'box' face attribute
1539 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1540
6e856b69
LMI
15412013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1542
1543 * image.c (imagemagick_compute_animated_image): Implement animated
1544 images (bug#14700).
995be755
LMI
1545 (imagemagick_compute_animated_image): Fix some compilation
1546 warnings. Implement a very simple cache to make the animation
1547 usable at all, but it should be replaced with a per-image cache.
6e856b69 1548
d5a1acfa
DA
15492013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1550
1551 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1552 to do `for' loops over alist values.
1553 * buffer.h (FOR_EACH_BUFFER):
1554 * process.c (FOR_EACH_PROCESS): Use it.
1555 (handle_child_signal, status_notify, Fget_buffer_process)
1556 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1557
9c253307
DA
15582013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1559
1560 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1561 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1562 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1563 to xzalloc and so avoid redundant call to memset.
1564 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1565 members because it is allocated with xzalloc and so already zeroed.
1566
05e64f9f
KB
15672013-08-14 Ken Brown <kbrown@cornell.edu>
1568
1569 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1570 (Bug#15094).
1571
5b71542d
DA
15722013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1573
1574 Utility function and macro to copy Lisp string to C string.
1575 * lisp.h (xlispstrdupa): New macro.
1576 (xlispstrdup): New prototype.
1577 * alloc.c (xlispstrdup): New function.
1578 * callint.c (Fcall_interactively):
1579 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1580 (Fsubstitute_in_file_name):
1581 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1582 * image.c (x_create_bitmap_from_file):
1583 * w32term.c (w32_term_init):
1584 * xterm.c (x_term_init): Use xlispstrdup.
1585
71530c97
LMI
15862013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1587
4ce82fb8
LMI
1588 * image.c (imagemagick_load_image): Make animated pictures work.
1589 There's still some problems with background color settings, though
1590 (bug#14700).
1591
71530c97
LMI
1592 * decompress.c (unwind_decompress): Always restore point.
1593
7510a061
XF
15942013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1595
1596 * marker.c (set_marker): Reformat documentation.
1597
01c3051f
PE
15982013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1599
aab1fcdf
PE
1600 * xdisp.c (cursor_type_changed): Now static.
1601
01c3051f
PE
1602 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1603 Use changed. This avoids the need to call xmalloc and for the
1604 caller to call xfree, and avoids memory leaks in some situations.
1605
2084152a
DA
16062013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1607
1608 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1609 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1610 (redisplay_window): If window_end_valid is cleared due to non-zero
1611 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1612 so do not call to try_cursor_movement for that window.
2084152a 1613
02455cb6
DA
16142013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1615
1616 * window.h (struct window): Convert window_end_pos and
1617 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1618 (wset_window_end_pos, wset_window_end_vpos): Remove.
1619 * dispnew.c (adjust_glyph_matrix):
1620 * window.c (Fwindow_end, replace_window, set_window_buffer)
1621 (make_window):
1622 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1623 (set_vertical_scroll_bar, redisplay_window, try_window)
1624 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1625 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1626 (note_mouse_highlight): Adjust users.
1627 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1628 Add comment.
1629
da5707e8
DA
16302013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1631
1632 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1633 * image.c (imagemagick_filename_hint): Use `const char *' and
1634 prefer SSDATA to SDATA to avoid warnings.
1635
25554267
DA
16362013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1637
1638 Cleanup window fringes, margins and scroll bars adjustments.
1639 * window.c (set_window_fringes, set_window_margins)
1640 (set_window_scroll_bars, apply_window_adjustment): New functions.
1641 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1642 (Fset_window_scroll_bars): Use them.
1643
38a2c910
DA
16442013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1645
1646 * window.h (struct window): Convert scroll_bar_width
1647 from Lisp_Object to integer. Adjust comment.
1648 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1649 Adjust users.
1650 * window.c (wset_scroll_bar_width): Remove.
1651 (make_window): Initialize scroll_bar_width.
1652 (Fsplit_window_internal): Use direct assignment.
1653 (Fset_window_configuration, save_window_save):
1654 Convert Lisp_Object to integer and back where appropriate.
1655 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1656 bar was actually changed, and mention this in docstring.
1657
2d065031
PE
16582013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 * decompress.c: Minor simplifications.
1661 (Fzlib_decompress_region): Don't bother verifying
1662 that avail_out <= UINT_MAX, as that was confusing.
1663 Mention the restriction in a comment instead.
1664 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1665
a5bd5abb
JD
16662013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1667
1668 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1669 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1670
66e7901a
LMI
16712013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1672
1673 * image.c (imagemagick_filename_hint): Check for errors in the
1674 alist structure.
1675
2fa611b7
EZ
16762013-08-13 Eli Zaretskii <eliz@gnu.org>
1677
1678 * window.c (Fwindow_margins): Return nil when there's no marginal
1679 area, as per the documented API.
1680
1681 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1682 Fmake_vector, as scroll bar's struct members are not all Lisp
1683 objects now. This avoids crashes in GC.
1684
1685 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1686 bool, so its address could be taken.
1687
8259030d
LMI
16882013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1689
1690 * image.c (imagemagick_filename_hint): New function to possibly
1691 apply `image-content-type-suffixes'.
1692 (imagemagick_load_image): Use it.
1693
866c710e
EZ
16942013-08-13 Eli Zaretskii <eliz@gnu.org>
1695
1696 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1697 if loading zlib failed.
1698
f10490f0
JD
16992013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1700
96311be7
JD
1701 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1702 2013-08-13 checkin below. Change bool to BOOL, rule is:
1703 All Obj-C code uses BOOL, except for interfaces callable from C.
1704
f10490f0
JD
1705 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1706
c8ae93b0
DA
17072013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1708
1709 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1710 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1711 bool instead of BOOL.
1712 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1713 from Lisp_Object to bitfield. Adjust comment.
1714 * w32term.c (x_scroll_bar_create): Adjust user.
1715 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1716 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1717 Use bool for boolean.
1718 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1719 to `unsigned int' when defining a bitfield.
1720
53b64418
PE
17212013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1722
1723 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1724
eeaf9bf3
DA
17252013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1726
1727 * window.h (struct window): Convert left_margin_cols and
1728 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1729 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1730 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1731 Adjust users.
1732 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1733 Adjust comment.
1734 (showing_window_margins_p, update_window_line, update_frame_1):
1735 * fringe.c (draw_fringe_bitmap_1):
1736 * xdisp.c (window_box_width): Adjust users.
1737 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1738 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1739 Use direct assignment.
1740 (Fset_window_configuration, save_window_save, Fwindow_margins):
1741 Convert Lisp_Object to integer and back where appropriate.
1742 (Fset_window_margins): Adjust user. Return t if any margin
1743 was actually changed, and mention this in docstring.
1744
956720af
XF
17452013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1746
f73f4ce6 1747 * syntax.c (forward_word):
956720af
XF
1748 * cmds.c (forward_char, backward_char): Mention the optional argument.
1749
9e37ee3b
DA
17502013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1751
1752 * window.h (struct window): Convert left_fringe_width
1753 and right_fringe_width from Lisp_Objects to integers.
1754 Adjust comment.
1755 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1756 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1757 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1758 Remove.
1759 (make_window): Initialize new integer fields to -1.
1760 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1761 (Fset_window_configuration, save_window_save):
1762 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1763 (Fset_window_fringes): Adjust user. Return t if any fringe
1764 was actually changed, and mention this in docstring.
1765
e4375ca7
DA
17662013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1767
1768 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1769 * nsfns.m (x_set_cursor_type):
1770 * w32fns.c (x_set_cursor_type):
1771 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1772 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1773
a45543bc
DA
17742013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 * font.c (clear_font_cache): New function, stripped from...
1777 (Fclear_font_cache): ...here, which now uses the function
1778 above. Adjust comment.
1779 * font.h (clear_font_cache): Add prototype.
1780 * xfaces.c (clear_face_cache): Use clear_font_cache.
1781
ae966a86
DA
17822013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1783
1784 * window.c (Fset_window_start): Compare `w', not `window' because
1785 `w' might not be equal to `window' after call to decode_live_window.
1786
297a545b
PE
17872013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1790 This fixes a problem introduced by the Bug#15035 patch
1791 when using GPG. Reported by Herbert J. Skuhra.
1792
aa942e2b
EZ
17932013-08-12 Eli Zaretskii <eliz@gnu.org>
1794
1795 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1796 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1797 not yet initialized.
1798
7699d09e
LMI
17992013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1800
1801 * decompress.c (Fzlib_decompress_region): Support zlib
1802 decompression, too, and rename.
1803
1d238bc7
PE
18042013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 Minor zlib configuration tweaks.
1807 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1808 Don't assume presence of fn_inflateInit2_ zlib internal function.
1809
8a44a184
LMI
18102013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1811
1812 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1813 include the zlib prefix.
1814
594a4307
EZ
18152013-08-12 Eli Zaretskii <eliz@gnu.org>
1816
1817 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1818 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1819 define static variables that are pointers to zlib functions to be
1820 dynamically loaded.
1821 (init_zlib_functions) [WINDOWSNT]: New function.
1822 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1823 New macros.
1824 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1825 macros instead of invoking the zlib functions directly.
068f9124
SM
1826 (syms_of_decompress): DEFSYM Qzlib_dll.
1827 Staticpro Szlib_available_p.
594a4307 1828
d2e113bc
DA
18292013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1830
1831 Avoid looping over all frame windows to freeze and unfreeze.
1832 * window.h (struct window): Drop frozen_window_start_p.
1833 (freeze_window_starts): Drop prototype.
1834 * frame.h (struct frame): New frozen_window_starts flag.
1835 (FRAME_WINDOWS_FROZEN): New macro.
1836 * window.c (freeze_window_start, freeze_window_starts):
1837 Remove.
1838 (select_window, replace_window): Adjust users.
1839 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1840 (window_frozen_p): New function.
1841 (redisplay_window): Use it.
1842
94fcd171
PE
18432013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 Fix some fd issues when running subprocesses (Bug#15035).
1846 Fix bugs that can leak files or file descriptors on errors.
1847 Don't unlink open temp files, as that's hard for users to diagnose
1848 when things go awry (e.g., temp disk exhausted).
1849 Don't bother to lock temp files. Check for invalid recursion.
1850 * callproc.c (synch_process_fd): Remove. All uses removed.
1851 (synch_process_tempfile): New var or macro.
1852 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1853 New constants.
1854 (record_kill_process): New arg, the temp name. All callers changed.
1855 (delete_temp_file): Now just a simple wrapper around unlink.
1856 (call_process_kill): New arg, the call_process_fd array.
1857 Close them all. Clear synch_process_pid. Remove the temp file,
1858 or arrange for it to be removed.
1859 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1860 that's been moved to synch_process_tempfile. Caller changed.
1861 Do not remove the tempfile; that's now call_process_kill's
1862 responsibility.
1863 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1864 call_process_kill; the caller now does that.
1865 (call_process_cleanup): Do not close the process fd; that's now
1866 call_process_kill's responsibility.
1867 (Fcall_process): Implement via new function call_process, which
1868 has most of the old body of Fcall_process, but with a different API.
1869 (call_process): New function that does not open or close filefd if
1870 it is nonnegative. Record which fds need to be closed, and let
1871 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1872 Signal an error if invoked recursively (could be done via a hook).
1873 Simplify creation of the tempfile in the MSDOS case.
1874 Don't create the output file until after checking for the executable.
1875 Report any failure to open /dev/null.
1876 Don't open /dev/null for writing twice; once is enough.
1877 Don't create pipe if all output is being discarded or sent to file.
1878 Don't worry about setting up the coding system or reading from the
1879 pipe if all output is being discarded.
1880 Hoist fd_error local into top level, to lessen block nesting.
1881 Don't record deleted pid here; now done by Fcall_process_region.
1882 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1883 and note its success in synch_process_tempfile.
1884 Do not leak resources when child_setup fails.
1885 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1886 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1887 (create_temp_file): Now returns open fd, with an additional
1888 Lisp_Object * argument to return the name. All callers changed.
1889 Do not close the file; rewind it instead, and leave it open for
1890 the caller. Do not lock the temp file. Unwind-protect the file
1891 and the file-descriptor.
1892 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1893 If an asynchrounous process, record it here, not in call_process.
1894 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1895 * eval.c (set_unwind_protect): New function.
1896 * fileio.c (write_region): New function, generalized from the
1897 old Fwrite_region. Do not lock temp files.
1898 (Fwrite_region): Use it.
1899 * lisp.h (set_unwind_protect, write_region): New decls.
1900 * process.c: Include <verify.h>.
1901 (make_process): Mark fds as initially closed.
1902 (deleted_pid_list): Now a list of pid-filename pairs.
1903 All uses changed.
1904 (close_process_fd): New function.
1905 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1906 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1907 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1908 (create_process, create_pty, Fmake_serial_process)
1909 (server_accept_connection): Record which fds need to be closed,
1910 and let deactivate_process close them.
1911 (Fmake_network_process): Do not discard the unwind-protect
1912 until it's safe to do so.
1913 (deactivate_process): Close the fds opened by create_process etc.
1914 (Fprocess_send_eof): Adjust to new way of recording open fds.
1915 Report an error if /dev/null can't be opened, instead of aborting.
1916 * process.h (PROCESS_OPEN_FDS): New constant.
1917 (struct Lisp_Process): New member open_fds.
1918 (record_kill_process, record_deleted_pid): Adjust signatures.
1919 (record_deleted_pid): Move decl here ...
1920 * syswait.h (record_deleted_pid): ... from here.
1921
d0e615c3
PE
19222013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 * decompress.c: Fix bugs with large buffers and weird inputs.
1925 Tune a bit. Reindent as per usual Emacs style.
1926 (BUFFER_SIZE): Remove.
1927 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1928 more than UINT_MAX bytes. Decompress into the gap instead of into
1929 an auto buffer, as this should avoid copying. Return nil if
1930 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1931 set immediate_quit; we shouldn't trust zlib code that much.
1932
313546eb
LMI
19332013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1934
99a32242
LMI
1935 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1936 errors, and really move the gap to where we want it.
1937
313546eb
LMI
1938 * lisp.h: Include decompress.c support.
1939
1940 * emacs.c (main): Include decompress.c support.
1941
1942 * Makefile.in: Include -lz if present.
1943
d2d699ac
JD
19442013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1945
f90e3ebd
JD
1946 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1947 (initWithTitle:): Initialize frame to 0.
1948 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1949 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1950 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1951
1952 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1953 fillWithWidgetValue:frame:
1954
423d3b3f
JD
1955 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1956 remove memory leak warnings.
1957
d2d699ac
JD
1958 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1959 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1960 menu_pending_title.
1961
1962 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1963 (x_activate_menubar): Update the whole menu.
1964 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1965 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1966 current event is not NSSystemDefined (Bug#15001).
1967 Call ns_check_menu_open only if trackingMenu is 2.
1968 (menuDidClose:): New method, decrease trackingMenu.
1969 (fillWithWidgetValue:setDelegate:): New method.
1970 (fillWithWidgetValue:): Call the above.
1971
1972 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1973
7d652d97
PE
19742013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 Omit some unnecessary casts.
1977 Many of these go back to the old pre-C89 days, when they may have
1978 been needed, but we've been assuming C89 or later for a while now.
1979 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1980 (live_float_p, live_misc_p, live_vector_p):
1981 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1982 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1983 (defvar_per_buffer):
1984 * callint.c (Fcall_interactively):
1985 * doc.c (Fsubstitute_command_keys):
1986 * filelock.c (get_boot_time):
1987 * frame.c (xrdb_get_resource):
1988 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1989 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1990 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1991 (menuitem_highlight_callback, menu_destroy_callback)
1992 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1993 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1994 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1995 (xg_tool_bar_help_callback, tb_size_cb):
1996 * image.c (xpm_alloc_color, png_read_from_memory)
1997 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1998 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1999 (syms_of_image):
2000 * keymap.c (describe_map):
2001 * nsfns.m (Fns_display_monitor_attributes_list):
2002 * nsmenu.m (process_dialog:):
2003 * nsterm.m (hold_event):
2004 * process.c (wait_reading_process_output):
2005 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2006 * scroll.c (do_direct_scrolling, scrolling_1):
2007 * termcap.c (tgetent):
2008 * window.c (check_window_containing, add_window_to_list)
2009 (freeze_window_starts):
2010 * xdisp.c (compare_overlay_entries, vmessage):
2011 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2012 (x_get_monitor_attributes_xrandr)
2013 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2014 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2015 * xfont.c (xfont_match, xfont_open):
2016 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2017 (menubar_selection_callback, menu_position_func)
2018 (popup_selection_callback, create_and_show_popup_menu)
2019 (dialog_selection_callback, create_and_show_dialog):
2020 * xrdb.c (x_get_string_resource):
2021 (main) [TESTRM]:
2022 * xsmfns.c (x_session_check_input):
2023 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2024 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2025 (xaw_jump_callback, xaw_scroll_callback):
2026 Omit unnecessary casts.
2027
9acc1074
PE
20282013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 Minor string-length refactoring.
2031 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2032 * frame.c (make_monitor_attribute_list):
2033 Prefer build_string to strlen + make_string.
2034
361c0eb8
JD
20352013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2036
2037 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2038 don't check minor_code (Bug#14417).
2039
14ba0822
EZ
20402013-08-09 Eli Zaretskii <eliz@gnu.org>
2041
2042 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2043 vertical positions instead. This avoids calling MATRIX_ROW with
2044 row numbers that are possibly beyond valid limits. (Bug#15064)
2045
309f24d1
DA
20462013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2047
2048 Use xstrdup and build_unibyte_string where applicable.
2049 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2050 * xfns.c (x_window):
2051 * xrdb.c (x_get_customization_string):
2052 * xterm.c (xim_initialize):
2053 * w32fns.c (w32_window): Use xstrdup.
2054 (w32_display_monitor_attributes_list):
2055 * emacs.c (init_cmdargs):
2056 * keyboard.c (PUSH_C_STR):
2057 * nsfont.m (nsfont_open):
2058 * sysdep.c (system_process_attributes):
2059 * w32.c (system_process_attributes):
2060 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2061
55902276
EZ
20622013-08-09 Eli Zaretskii <eliz@gnu.org>
2063
2064 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2065 variables of these types so that GDB would know about them, as aid
2066 for debugging fatal exceptions. (Bug#15024) See also
2067 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2068 discussions.
2069
10bf7f5a
JD
20702013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2071
2072 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2073 larger than the NSWindow (Bug#14934).
2074
65620264
DA
20752013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2076
2077 Redesign redisplay interface to drop global variable updated_window.
2078 Always pass currently updated window as a parameter to update routines.
2079 * dispextern.h (updated_window): Remove declaration.
2080 (struct redisplay_interface): Pass window parameter to
2081 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2082 and after_update_window_hook.
2083 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2084 Adjust prototypes.
2085 * dispnew.c (updated_window): Remove.
2086 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2087 (update_window_line): Adjust to match redisplay interface changes.
2088 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2089 (ns_scroll_run, ns_after_update_window_line):
2090 * w32term.c (x_update_window_begin, x_update_window_end)
2091 (x_after_update_window_line, x_scroll_run):
2092 * xterm.c (x_update_window_begin, x_update_window_end)
2093 (x_after_update_window_line, x_scroll_run):
2094 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2095 Likewise. Adjust comments where appropriate.
2096 (x_cursor_to): Simplify because this is always called during window
2097 update (but install debugging check anyway).
2098 (expose_window): Check must_be_updated_p flag to see whether this
2099 function is called during window update.
2100
628fdc56
DA
21012013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2102
2103 Do not reset window modification event counters excessively.
2104 These leftovers and poor man's tricky methods to catch extra
2105 redisplay's attention are no longer needed.
2106 * frame.c (set_menu_bar_lines_1):
2107 * minibuf.c (read_minibuf_unwind):
2108 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2109 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2110 (window_scroll_line_based, Fset_window_configuration):
2111 * xdisp.c (redisplay_window): Do not reset last_modified and
2112 last_overlay_modified counters.
2113
8fd9c92e
JD
21142013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2115
2116 * xselect.c (x_send_client_event): Set send_event and serial, memset
2117 data.l as it might be bigger than data.b. Use 24 bit mask to
2118 XSendEvent (Bug#15034).
2119
0ee18172
EZ
21202013-08-07 Eli Zaretskii <eliz@gnu.org>
2121
2122 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2123 for TTY frames that are not the top frame on their console.
2124 (Bug#14616)
2125
16ddd1a6
MR
21262013-08-07 Martin Rudalics <rudalics@gmx.at>
2127
2128 * w32term.c (w32fullscreen_hook): Really maximize frame when
2129 asked for (Bug#14841).
2130
d2a95ffb
DA
21312013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2132
2133 Prefer selected_window to Fselected_window, likewise for frames.
2134 * buffer.c (Fbuffer_swap_text):
2135 * data.c (Fvariable_binding_locus):
2136 * window.c (run_window_configuration_change_hook): Adjust users.
2137 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2138 Use decode_live_frame.
2139
170da1ec
DA
21402013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2141
2142 Be more careful if selected window shows the buffer other than current,
2143 use window_outdated only if this is not so. This change should also
2144 address some weird issues discussed in Bug#13012.
2145 * window.h (window_outdated): New prototype.
2146 * window.c (window_outdated): Now here. Convert from static and
2147 always assume window's buffer.
2148 (Fwindow_end, Fwindow_line_height): Use it.
2149 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2150 and always assume window's buffer.
2151 (redisplay_window): Adjust user.
e5eefe9b 2152 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2153 check whether mode line should be updated only if selected window
2154 shows current buffer.
2155 (run_window_scroll_functions): Use eassert for debugging check.
2156 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2157
56b5d5b1
DA
21582013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2159
2160 * window.c (window_scroll, window_scroll_pixel_based)
2161 (window_scroll_line_based): Use bool for booleans.
2162
2878ba7e
PE
21632013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 * process.c: Fix minor off-by-one issues in descriptor counts.
2166 This shouldn't fix any real bugs, but it cleans up the code a bit.
2167 (max_process_desc, max_input_desc): -1, not 0, means none.
2168 All uses changed.
2169 (delete_input_desc): New function.
2170 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2171 (deactivate_process): Scan backwards when recomuting max_process_desc;
2172 that should be faster.
2173 (init_process_emacs): Initialize max_input_desc.
2174
e30b79c1
DA
21752013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2176
2177 Use region cache to speedup bidi_find_paragraph_start.
2178 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2179 Rename cache_long_line_scans to cache_long_scans.
2180 * buffer.c (bset_cache_long_line_scans): Rename to
2181 bset_cache_long_scans.
2182 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2183 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2184 into account.
2185 (syms_of_buffer): Rename cache-long-line-scans to
2186 cache-long-scans. Adjust docstring.
2187 * search.c (newline_cache_on_off):
2188 * indent.c (width_run_cache_on_off): Adjust users.
2189 * bidi.c (bidi_paragraph_cache_on_off): New function.
2190 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2191 * insdel.c (prepare_to_modify_buffer):
2192 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2193
00012b86
DA
21942013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2195
2196 Invalidate region caches only if buffer text is going to be changed.
2197 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2198 (modify_text): ...new prototype.
2199 (prepare_to_modify_buffer_1): New prototype.
2200 * textprop.c (modify_region): Rename to...
2201 (modify_text_properties): ...new function.
2202 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2203 (Fremove_list_of_text_properties): Adjust users.
2204 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2205 (modify_text): ...new function.
2206 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2207 (prepare_to_modify_buffer_1): ...new function.
2208 * casefiddle.c (casify_region):
2209 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2210 (Ftranspose_regions): Use modify_text.
2211
dc6c0eda
SM
22122013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2213
2214 * lisp.mk (lisp): Add nadvice.elc.
2215
8f3a2c26
DA
22162013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2217
2218 New macro to iterate over live buffers similar to frames.
2219 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2220 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2221 Declare buffer-related variables here to offload lisp.h.
2222 * buffer.c (Vbuffer_alist): Adjust comment.
2223 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2224 (other_buffer_safely):
2225 * data.c (store_symval_forwarding):
2226 * dispnew.c (Fframe_or_buffer_changed_p):
2227 * fileio.c (Fdo_auto_save):
2228 * filelock.c (unlock_all_files):
2229 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2230
e0fdb694
PE
22312013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2234 * callproc.c (create_temp_file):
2235 * filelock.c (create_lock_file):
2236 Assume mkostemp, since it's now provided by Gnulib.
2237
63f5c6c2
EZ
22382013-08-04 Eli Zaretskii <eliz@gnu.org>
2239
2240 * w32.c (mkostemp): New function.
2241 (mktemp): Remove, no longer used. Most of the code reused in
2242 mkostemp. (Bug#15015)
484ab239 2243 (mktemp): Don't undef.
63f5c6c2 2244
f0b79313
DA
22452013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2246
2247 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2248 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2249 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2250 (free_glyph_pool, check_glyph_memory): Likewise for
2251 all users. Adjust comments where appropriate.
2252
98f638d6
PE
22532013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 * composite.h: Minor fixups.
2256 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2257 to fix a misspelling, and change it to an inline function while
2258 we're at it (it need not be a macro). All uses changed.
2259 (composition_method, composition_valid_p):
2260 Rewrite to avoid assignments in if-conditions.
2261
75c59fb3
DA
22622013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2263
2264 Do not use global Lisp_Object in composition macros.
2265 * composite.h (composition_temp): Remove declaration.
2266 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2267 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2268 (compose_region): Remove the leftover.
75c59fb3
DA
2269 * composite.c (composition_temp): Remove.
2270 (run_composition_function, update_compositions)
2271 (composition_compute_stop_pos, composition_adjust_point)
2272 (Ffind_composition_internal):
2273 * coding.c (handle_composition_annotation):
2274 * xdisp.c (handle_composition_prop, check_point_in_composition):
2275 Related users changed.
2276
a10c8269
DA
22772013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2278
2279 Drop FRAME_PTR typedef.
2280 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2281 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2282 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2283 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2284 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2285 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2286 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2287 All related users changed.
2288
a104f656
SM
22892013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2290
2291 * eval.c (default_toplevel_binding): New function.
2292 (Fdefvar): Use it.
2293 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2294 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2295 (syms_of_eval): Export them.
2296 * data.c (Fdefault_value): Micro cleanup.
2297 * term.c (init_tty): Use "false".
2298
4b5c9326
DA
22992013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2300
2301 Fix X GC leak in GTK and raw (no toolkit) X ports.
2302 * xterm.c (x_free_frame_resources): If white and black relief
2303 GCs are allocated, always free them here.
2304 * xfns.c (x_make_gc): Omit redundant initialization.
2305 * widget.c (create_frame_gcs): Remove the leftover.
2306 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2307 in x_free_frame_resources.
2308
b19aa636
JD
23092013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2310
2311 * nsterm.m (windowWillResize:toSize:): Only change title if
2312 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2313 modifying it.
2314 (viewDidEndLiveResize): New method.
2315
2316 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2317 inside NS_IMPL_COCOA.
2318
af1f7e06
DA
23192013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2320
2321 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2322 Do not check whether undo is enabled because record_insert and
2323 record_delete does that themselves.
2324
65b02bb9
DA
23252013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2326
2327 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2328 member which is not really used any more.
2329 (FRAME_XIC_BASE_FONTNAME): Remove.
2330 * xfns.c (xic_free_fontset): Adjust user.
2331 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2332 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2333 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2334 (xdialog_show): Use eassert for debugging check.
7ee0f047 2335 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2336
6318cde0
PE
23372013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2338
2339 * fileio.c, fns.c (merge): Move extern decl from here ...
2340 * lisp.h (merge): ... to here.
2341
6c1a09ba
DA
23422013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2343
2344 Fix last font-related change.
2345 * w32font.h (w32font_list_internal, w32font_match_internal):
2346 Fix prototype.
2347 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2348 (uniscribe_list_family): Adjust to match font API change.
2349 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2350 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2351
f8c20208
DA
23522013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2353
2354 * frame.h (FRAME_MOUSE_UPDATE):
2355 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2356 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2357
fdb396e2
DA
23582013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2359
2360 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2361 * font.h (struct font_driver): Change list, match, and list_family
2362 functions to accept struct frame * as first arg.
068f9124
SM
2363 * font.c (font_score, font_compare, font_sort_entities):
2364 Remove prototypes.
fdb396e2
DA
2365 (font_sort_entities, font_list_entities, font_select_entity):
2366 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2367 match font API change.
2368 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2369 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2370 * ftxfont.c (ftxfont_list, ftxfont_match):
2371 * xftfont.c (xftfont_list, xftfont_match):
2372 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2373 * w32font.c (w32font_list, w32font_match, w32font_list):
2374 (w32font_list_internal, w32_font_match_internal): Likewise.
2375 * xfaces.c (Fx_family_fonts): Adjust user.
2376
52b8a085
DA
23772013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2378
2379 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2380 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2381 only if HAVE_X_WINDOWS is in use.
2382 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2383 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2384 * w32term.c (x_wm_set_icon_position): Likewise.
2385 * w32fns.c (x_icon): Adjust user.
2386
c791c18e
DA
23872013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2388
2389 * xterm.c (last_mouse_press_frame): Remove the
2390 leftover which is not really used any more.
2391 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2392 (x_flush): Call XFlush once per each X display, not frame.
2393 This is better because this code always unconditionally skips
2394 non-X frames in Vframe_list and issues the only XFlush if we
2395 have more than one X frame on the same X display.
2f935d86
DA
2396 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2397 Use bool for booleans.
2398 (x_draw_glyph_string_background, cvt_string_to_pixel):
2399 (cvt_pixel_dtor): Drop unnecessary prototypes.
2400 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2401
f435830e
DA
24022013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2403
2404 Drop unnecessary functions that deals with frame pixel size.
2405 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2406 (x_pixel_height): Drop prototypes.
2407 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2408 (x_pixel_height): Drop implementations.
2409 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2410 which should be always valid for window frame.
2411 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2412 * w32menu.c (Fx_popup_dialog):
2413 * xmenu.c (Fx_popup_dialog): Likewise for both.
2414
84231434
DA
24152013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2416
2417 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2418 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2419 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2420 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2421 and mention nil frame in docstring.
84231434 2422
959067a1
DA
24232013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2424
2425 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2426 (x_figure_window_size): Likewise. Adjust to return long.
2427 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2428 (toplevel): Move Qterminal_live_p to...
2429 * terminal.c (toplevel): ...here, make it static, and...
2430 (syms_of_terminal): ...DEFSYM here.
2431 * frame.h (Qterminal_live_p): Remove declaration.
2432 (make_frame, x_figure_window_size): Adjust prototype.
2433 * nsfns.m (Fx_create_frame): Use long for window flags.
2434
f4b169ce
PE
24352013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2438 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2439 Do not assume that emacs_close (INT_MAX) is a no-op.
2440
bee6a2c7
DA
24412013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2442
2443 * xfaces.c (make_face_cache): For struct face_cache, prefer
2444 xmalloc to xzalloc and so avoid redundant call to memset.
2445 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2446
d7e6881a
DA
24472013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2448
2449 * fringe.c (draw_window_fringes, update_window_fringes)
2450 (compute_fringe_widths):
2451 * w32term.c (x_draw_glyph_string):
2452 * window.c (candidate_window_p, Frecenter):
2453 * xfaces.c (realize_basic_faces, realize_default_face)
2454 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2455 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2456 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2457 * xmenu.c (Fx_menu_bar_open_internal):
2458 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2459 * xsettings.c (xft_settings_event):
2460 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2461 Use bool for booleans. Adjust style and comments where
2462 appropriate.
2463 * dispextern.h (draw_window_fringes, update_window_fringes)
2464 (compute_fringe_widths):
2465 * xterm.h (x_had_errors_p): Adjust prototype.
2466
ec3058af
DA
24672013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2468
2469 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2470 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2471
218e0637
DA
24722013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2473
2474 * fns.c (toplevel): Remove comment before Fsafe_length because
2475 it checks for QUIT.
2476
e560aba9
PE
24772013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2478
2479 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2480
2e5ce5de
EZ
24812013-07-28 Eli Zaretskii <eliz@gnu.org>
2482
2483 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2484 frame which got the message is still alive, before dereferencing
2485 its pointer. (Bug#14970)
2486
2487 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2488 be a live window, before using it as such. (Bug#14970)
2489
e95da6d3
EZ
24902013-07-27 Eli Zaretskii <eliz@gnu.org>
2491
2492 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2493 w32_detect_focus_change instead of doing part of its job by hand.
2494 This fixes the problem whereby FOCUS_OUT events were not sent to
2495 the event queue.
2496
a8f93651
EZ
24972013-07-26 Eli Zaretskii <eliz@gnu.org>
2498
fec92060
EZ
2499 * process.c (Fprocess_list): Doc fix.
2500
a8f93651
EZ
2501 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2502 being re-exposed only if it didn't ask to become visible.
2503 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2504 was previously iconified. (Bug#14841)
2505 (x_iconify_frame): Mark the frame iconified.
2506
d5a7a9d9
PE
25072013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2508
2509 Fix minor problems found by static checking.
2510 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2511 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2512
56ea7291
SM
25132013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2514
2515 * eval.c (set_specpdl_old_value): New function.
2516 (unbind_to): Minor simplification.
2517 (get_backtrace_frame): New function.
2518 (Fbacktrace_frame): Use it. Add `base' argument.
2519 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2520 (syms_of_eval): Export backtrace-eval.
2521 * xterm.c (x_focus_changed): Simplify.
2522
9d611ffe
PE
25232013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2524
2525 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2526
999c74e3
EZ
25272013-07-24 Eli Zaretskii <eliz@gnu.org>
2528
2529 * xdisp.c (redisplay_window): Instead of moving point out of
2530 scroll margin, reject the force_start method, and try scrolling
2531 instead. (Bug#14780)
2532
198fa217
KB
25332013-07-24 Ken Brown <kbrown@cornell.edu>
2534
2535 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2536 (Bug#14944).
2537
53840e55
PE
25382013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2539
2540 * eval.c (Fprogn): Do not check that BODY is a proper list.
2541 This undoes the previous change. The check slows down the
2542 interpreter, and is not needed to prevent a crash. See
2543 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2544
60967f56
GM
25452013-07-23 Glenn Morris <rgm@gnu.org>
2546
2547 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2548
9ca960e2
PE
25492013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2550
a29c3e6d
PE
2551 Port to GNU/Linux systems with tinfo but not ncurses.
2552 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2553 to decide whether ncurses is being used. Without this change,
2554 GCC complains about tgetent not being declared, on a system
2555 that has tinfo installed but ncurses not installed.
2556
f274311c
PE
2557 * eval.c (Fprogn): Check that BODY is a proper list.
2558
16b0520a
PE
2559 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2560 * data.c (Fsetq_default):
2561 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2562 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2563 (Fcondition_case):
2564 Tune by taking advantage of the fact that ARGS is always a list
2565 when a function is declared to have UNEVALLED args.
2566
9ca960e2
PE
2567 * emacsgtkfixed.c: Port to GCC 4.6.
2568 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2569
afacaa1b
JB
25702013-07-23 Juanma Barranquero <lekktu@gmail.com>
2571
2572 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2573 here to silence compiler warnings.
2574
368a85a4
PE
25752013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2578 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2579 from messing up Emacs's 'struct frame' (Bug#14923).
2580
f4e891b5
PE
25812013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2582
2583 * alloc.c (make_save_ptr_ptr): Define this function.
2584 It was inadvertently omitted. It's needed only if
2585 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2586
96c8b65e
JD
25872013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2588
2589 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2590 frame have focus (Bug#14895).
2591
ee010797
PE
25922013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 Avoid vfork-related deadlock more cleanly.
2595 * callproc.c (child_setup): When the child's exec fails, output
2596 the program name, as that's more useful. Use O_NONBLOCK to avoid
2597 deadlock.
2598 * process.c (create_process_1): Remove; no longer needed.
2599 (create_process): Remove timer hack; no longer needed, now that
2600 the child avoids deadlock.
2601
f0398ec1 26022013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2603
2604 * image.c (Fimage_flush): Fix doc typo.
2605
b2a069c2
PE
26062013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2607
6496aec9
PE
2608 Fix array bounds violation when pty allocation fails.
2609 * process.c (PTY_NAME_SIZE): New constant.
2610 (pty_name): Remove static variable; it's now auto.
2611 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2612 Take pty_name as an arg rather than using a static variable.
2613 All callers changed.
2614 (create_process): Recover pty_flag from process, not from volatile local.
2615 (create_pty): Stay inside array even when pty allocation fails.
2616 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2617
b2a069c2
PE
2618 * lread.c (Fload): Avoid initialization only when lint checking.
2619 Mention that it's needed only for older GCCs.
2620
99107004
KH
26212013-07-20 Kenichi Handa <handa@gnu.org>
2622
2623 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2624 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2625
6b1b199d
AS
26262013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2627
2628 * lread.c (Fload): Avoid uninitialized warning.
2629
4195afc3
PE
26302013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2631
3f5bef16
PE
2632 Fix some minor file descriptor leaks and related glitches.
2633 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2634 (create_lock_file): Use write, not emacs_write.
2635 * image.c (slurp_file, png_load_body):
2636 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2637 (server_accept_connection):
2638 Don't leak an fd on memory allocation failure.
2639 * image.c (slurp_file): Add a cheap heuristic for growing files.
2640 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2641 as that's what the other routines do. Maybe input need not be
2642 blocked at all, but it's better to be consistent.
2643 Avoid undefined behavior when strlen is zero.
2644
4195afc3
PE
2645 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2646 (NSTATICS): Now a constant; doesn't need to be a macro.
2647
a1aeeffe
RS
26482013-07-19 Richard Stallman <rms@gnu.org>
2649
2650 * coding.c (decode_coding_utf_8): Add simple loop for fast
2651 processing of ASCII characters.
2652
63b34baa
PE
26532013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2656
621dd9ac
EZ
26572013-07-19 Eli Zaretskii <eliz@gnu.org>
2658
2659 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2660 unportable 'struct x_display_info'.
2661 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2662 is a portable type.
2663
1396ac86
PE
26642013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2665
ab9980cd
PE
2666 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2667 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2668 or fscanf fails.
2669 (system_process_attributes): Prefer plain char to unsigned char
2670 when either will do. Clean up properly if interrupted or if
068f9124
SM
2671 memory allocations fail. Don't assume sscanf succeeds.
2672 Remove no-longer-needed workaround to stop GCC from whining.
2673 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2674 bit more carefully.
2675
1396ac86
PE
2676 Fix obscure porting bug with varargs functions.
2677 The code assumed that int is treated like ptrdiff_t in a vararg
2678 function, which is not a portable assumption. There was a similar
2679 -- though these days less likely -- porting problem with various
2680 assumptions that pointers of different types all smell the same as
2681 far as vararg functions is conserved. To make this problem less
2682 likely in the future, redo the API to use varargs functions.
2683 * alloc.c (make_save_value): Remove this vararg function.
2684 All uses changed to ...
2685 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2686 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2687 New functions.
2688 (make_save_ptr): Rename from make_save_pointer, for consistency with
2689 the above. Define only on platforms that need it. All uses changed.
2690
4d19d194
PE
26912013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 * keyboard.c: Try to fix typos in previous change.
2694 (DISPLAY_LIST_INFO): New macro.
2695 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2696 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2697
945c5bb1
JB
26982013-07-18 Juanma Barranquero <lekktu@gmail.com>
2699
2700 * keyboard.c (kbd_buffer_get_event):
2701 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2702 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2703
f4b1eb36
PE
27042013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2705
5e679a2c
PE
2706 * filelock.c: Fix unlikely file descriptor leaks.
2707 (get_boot_time_1): Rework to avoid using emacs_open.
2708 This doesn't actually fix a leak, but is better anyway.
2709 (read_lock_data): Use read, not emacs_read.
2710
a8cd4836
PE
2711 * doc.c: Fix minor memory and file descriptor leaks.
2712 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2713 (get_doc_string, Fsnarf_documentation):
2714 Fix file descriptor leak on error.
2715
ef30e638
PE
2716 * term.c: Fix minor fdopen-related file descriptor leaks.
2717 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2718 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2719
f4b1eb36
PE
2720 * charset.c: Fix file descriptor leaks and errno issues.
2721 Include <errno.h>.
2722 (load_charset_map_from_file): Don't leak file descriptor on error.
2723 Use plain record_xmalloc since the allocation is larger than
2724 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2725 of entries.
2726 * eval.c (record_unwind_protect_nothing):
2727 * fileio.c (fclose_unwind):
2728 New functions.
2729 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2730 The replacement doesn't block input, but that no longer seems
2731 necessary.
2732
b648c163
PE
27332013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2734
a0931322
PE
2735 * lread.c: Fix file descriptor leaks and errno issues.
2736 (Fload): Close some races that leaked fds or streams when 'load'
2737 was interrupted.
2738 (Fload, openp): Report error number of last nontrivial failure to open.
2739 ENOENT counts as trivial.
2740 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2741 New functions.
2742 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2743 now that the function is always called with a nonnegative arg.
2744 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2745 All uses replaced with ...
2746 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2747
b648c163
PE
2748 A few more minor file errno-reporting bugs.
2749 * callproc.c (Fcall_process):
2750 * doc.c (Fsnarf_documentation):
2751 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2752 * process.c (set_socket_option):
2753 Don't let a constructor trash errno.
2754 * doc.c: Include <errno.h>.
2755
b1dc4084
JB
27562013-07-16 Juanma Barranquero <lekktu@gmail.com>
2757
2758 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2759
c43843aa
PE
27602013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2761
50a30cce
PE
2762 Fix w32 bug with call-process-region (Bug#14885).
2763 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2764 to Fcall_process when the input is empty. This simplifies the
2765 code a bit. It makes no difference on POSIXish platforms but
2766 apparently it fixes a bug on w32.
2767
44e18199 2768 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2769 * fileio.c (close_file_unwind): Don't close if FD is negative;
2770 this can happen when unwinding a zapped file descriptor.
2771 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2772 in case Emacs runs out of memory between the two unwind-protects.
2773 Don't trash errno when closing FD.
2774 Zap the FD in the specpdl when closing it, instead of deferring
2775 the removal of the unwind-protect; this fixes a bug where a child
2776 function unwinds the stack past us.
2777
27e498e6
PE
2778 New unwind-protect flavors to better type-check C callbacks.
2779 This also lessens the need to write wrappers for callbacks,
2780 and the need for make_save_pointer.
2781 * alloca.c (free_save_value):
2782 * atimer.c (run_all_atimers):
2783 Now extern.
2784 * alloc.c (safe_alloca_unwind):
2785 * atimer.c (unwind_stop_other_atimers):
2786 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2787 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2788 * minibuf.c (choose_minibuf_frame_1):
2789 * process.c (make_serial_process_unwind):
2790 * xdisp.h (pop_message_unwind):
2791 * xselect.c (queue_selection_requests_unwind):
2792 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2793 * alloca.c (record_xmalloc):
2794 Prefer record_unwind_protect_ptr to record_unwind_protect with
2795 make_save_pointer.
2796 * alloca.c (Fgarbage_collect):
2797 Prefer record_unwind_protect_void to passing a dummy.
2798 * buffer.c (restore_buffer):
2799 * window.c (restore_window_configuration):
2800 * xfns.c, w32fns.c (do_unwind_create_frame)
2801 New wrapper. All record-unwind uses of wrappee changed.
2802 * buffer.c (set_buffer_if_live):
2803 * callproc.c (call_process_cleanup, delete_temp_file):
2804 * coding.c (code_conversion_restore):
2805 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2806 * editfns.c (save_excursion_restore)
2807 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2808 (save_restriction_restore):
2809 * eval.c (restore_stack_limits, un_autoload):
2810 * fns.c (require_unwind):
2811 * keyboard.c (recursive_edit_unwind, tracking_off):
2812 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2813 * macros.c (pop_kbd_macro, restore_menu_items):
2814 * nsfns.m (unwind_create_frame):
2815 * print.c (print_unwind):
2816 * process.c (start_process_unwind):
2817 * search.c (unwind_set_match_data):
2818 * window.c (select_window_norecord, select_frame_norecord):
2819 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2820 (fast_set_selected_frame):
2821 * xfns.c, w32fns.c (unwind_create_tip_frame):
2822 Return void, not a dummy Lisp_Object. All uses changed.
2823 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2824 * callproc.c (call_process_kill):
2825 * fileio.c (restore_point_unwind, decide_coding_unwind)
2826 (build_annotations_unwind):
2827 * insdel.c (Fcombine_after_change_execute_1):
2828 * keyboard.c (read_char_help_form_unwind):
2829 * menu.c (unuse_menu_items):
2830 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2831 * sound.c (sound_cleanup):
2832 * xdisp.c (unwind_redisplay):
2833 * xfns.c (clean_up_dialog):
2834 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2835 Accept no args and return void, instead of accepting and returning
2836 a dummy Lisp_Object. All uses changed.
2837 * cygw32.c (fchdir_unwind):
2838 * fileio.c (close_file_unwind):
2839 * keyboard.c (restore_kboard_configuration):
2840 * lread.c (readevalllop_1):
2841 * process.c (wait_reading_process_output_unwind):
2842 Accept int and return void, rather than accepting an Emacs integer
2843 and returning a dummy object. In some cases this fixes an
2844 unlikely bug when the corresponding int is outside Emacs integer
2845 range. All uses changed.
2846 * dired.c (directory_files_internal_unwind):
2847 * fileio.c (do_auto_save_unwind):
2848 * gtkutil.c (pop_down_dialog):
2849 * insdel.c (reset_var_on_error):
2850 * lread.c (load_unwind):
2851 * xfns.c (clean_up_file_dialog):
2852 * xmenu.c, nsmenu.m (pop_down_menu):
2853 * xmenu.c (cleanup_widget_value_tree):
2854 * xselect.c (wait_for_property_change_unwind):
2855 Accept pointer and return void, rather than accepting an Emacs
2856 save value encapsulating the pointer and returning a dummy object.
2857 All uses changed.
2858 * editfns.c (Fformat): Update the saved pointer directly via
2859 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2860 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2861 (unwind_body): New function.
2862 (record_unwind_protect): First arg is now a function returning void,
2863 not a dummy Lisp_Object.
2864 (record_unwind_protect_ptr, record_unwind_protect_int)
2865 (record_unwind_protect_void): New functions.
2866 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2867 * fileio.c (struct auto_save_unwind): New type.
2868 (do_auto_save_unwind): Use it.
2869 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2870 * insdel.c (struct rvoe_arg): New type.
2871 (reset_var_on_error): Use it.
2872 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2873 New constants.
2874 (specbinding_func): Remove; there are now several such functions.
2875 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2876 (set_unwind_protect_ptr): New function.
2877 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2878
4e604a5d
PE
2879 Be simpler and more consistent about reporting I/O errors.
2880 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2881 Say "Read error" and "Write error", rather than "I/O error", or
2882 "IO error reading", or "IO error writing", when a read or write
2883 error occurs.
2884 * process.c (Fmake_network_process, wait_reading_process_output)
2885 (send_process, Fprocess_send_eof, wait_reading_process_output):
2886 Capitalize diagnostics consistently. Put "failed foo" at the
2887 start of the diagnostic, so that we don't capitalize the
2888 function name "foo". Consistently say "failed" for such
2889 diagnostics.
2890 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2891 All callers changed. This is so it can use report_file_error.
2892 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2893 diagnostics consistently as above.
2894
a9757f6a
PE
2895 * fileio.c (report_file_errno): Fix errno reporting bug.
2896 If the file name is neither null nor a pair, package it up as a
2897 singleton list. All callers changed, both to this function and to
2898 report_file_error. This fixes a bug where the memory allocator
2899 invoked by list1 set errno so that the immediately following
2900 report_file_error reported the wrong errno value.
2901
c43843aa
PE
2902 Fix minor problems found by --enable-gcc-warnings.
2903 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2904 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2905
18c26d81
JD
29062013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2907
2908 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2909 Set event->arg to Qt if switch-event shall be generated.
2910 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2911
2912 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2913
2914 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2915 FOCUS_OUT_EVENT.
2916
2917 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2918 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2919 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2920 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2921 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2922 and there is a focused frame.
2923 (head_table): Add focus-in and focus-out.
2924 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2925 bind to handle-focus-in/out.
2926
2927 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2928 (Fhandle_switch_frame): Call Fhandle_focus_in.
2929 (syms_of_frame): defsubr handle-focus-in/out.
2930
6c6f1994
PE
29312013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2932
c7ddc792
PE
2933 Fix porting bug to older POSIXish platforms (Bug#14862).
2934 * sysdep.c (emacs_pipe): New function, that implements
2935 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2936 This should port better to CentOS 5 and to Mac OS X 10.6.
2937 All calls to pipe2 changed.
2938
6c6f1994
PE
2939 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2940 This makes the code easier to read and the executable a bit smaller.
2941 Do not replace all calls to Fcons that happen to create lists,
2942 just calls that are intended to create lists. For example, when
2943 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2944 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2945 Similarly for list2 through list5.
2946 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2947 * bytecode.c (exec_byte_code):
2948 * callint.c (quotify_arg, Fcall_interactively):
2949 * callproc.c (Fcall_process, create_temp_file):
2950 * charset.c (load_charset_map_from_file)
2951 (Fdefine_charset_internal, init_charset):
2952 * coding.c (get_translation_table, detect_coding_system)
2953 (Fcheck_coding_systems_region)
2954 (Fset_terminal_coding_system_internal)
2955 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2956 * composite.c (update_compositions, Ffind_composition_internal):
2957 * dired.c (directory_files_internal, file_name_completion)
2958 (Fsystem_users):
2959 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2960 * doc.c (Fsnarf_documentation):
2961 * editfns.c (Fmessage_box):
2962 * emacs.c (main):
2963 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2964 (Feval, eval_sub, Ffuncall, apply_lambda):
2965 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2966 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2967 (Fset_file_times, Finsert_file_contents)
2968 (Fchoose_write_coding_system, Fwrite_region):
2969 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2970 * font.c (font_registry_charsets, font_parse_fcname)
2971 (font_prepare_cache, font_update_drivers, Flist_fonts):
2972 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2973 * frame.c (make_frame, Fmake_terminal_frame)
2974 (x_set_frame_parameters, x_report_frame_params)
2975 (x_default_parameter, Fx_parse_geometry):
2976 * ftfont.c (syms_of_ftfont):
2977 * image.c (gif_load):
2978 * keyboard.c (command_loop_1):
2979 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2980 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2981 (Fminor_mode_key_binding, accessible_keymaps_1)
2982 (Faccessible_keymaps, Fwhere_is_internal):
2983 * lread.c (read_emacs_mule_char):
2984 * menu.c (find_and_return_menu_selection):
2985 * minibuf.c (get_minibuffer):
2986 * nsfns.m (Fns_perform_service):
2987 * nsfont.m (ns_script_to_charset):
2988 * nsmenu.m (ns_popup_dialog):
2989 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2990 (Fx_own_selection_internal):
2991 * nsterm.m (append2):
2992 * print.c (Fredirect_debugging_output)
2993 (print_prune_string_charset):
2994 * process.c (Fdelete_process, Fprocess_contact)
2995 (Fformat_network_address, set_socket_option)
2996 (read_and_dispose_of_process_output, write_queue_push)
2997 (send_process, exec_sentinel):
2998 * sound.c (Fplay_sound_internal):
2999 * textprop.c (validate_plist, add_properties)
3000 (Fput_text_property, Fadd_face_text_property)
3001 (copy_text_properties, text_property_list, syms_of_textprop):
3002 * unexaix.c (report_error):
3003 * unexcoff.c (report_error):
3004 * unexsol.c (unexec):
3005 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3006 (Fformat_mode_line, syms_of_xdisp):
3007 * xfaces.c (set_font_frame_param)
3008 (Finternal_lisp_face_attribute_values)
3009 (Finternal_merge_in_global_face, syms_of_xfaces):
3010 * xfns.c (x_default_scroll_bar_color_parameter)
3011 (x_default_font_parameter, x_create_tip_frame):
3012 * xfont.c (xfont_supported_scripts):
3013 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3014 (menu_help_callback, xmenu_show):
3015 * xml.c (make_dom):
3016 * xterm.c (set_wm_state):
3017 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3018 and similarly for list2 through list5.
3019
bafe80ce
PE
30202013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3021
3022 * callproc.c (Fcall_process_region): Fix minor race and tune.
3023 (create_temp_file): New function, with the temp-file-creation part
3024 of the old Fcall_process_region. Use Fcopy_sequence to create the
3025 temp file name, rather than alloca + build_string, for simplicity.
3026 Don't bother to block input around the temp file creation;
068f9124
SM
3027 shouldn't be needed. Simplify use of mktemp.
3028 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3029 this closes an unlikely race where the temp file was not removed.
3030 Use memcpy rather than an open-coded loop.
3031 (Fcall_process_region): Use the new function. If the input is
3032 empty, redirect from /dev/null rather than from a newly created
3033 empty temp file; this avoids unnecessary file system traffic.
3034
4700b5a5
PE
30352013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3036
5c97beae
PE
3037 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3038 Simplify by making this case like the other two. This is a bit
3039 slower on obsolete hosts, but the extra complexity isn't worth it.
3040
4700b5a5
PE
3041 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3042 * process.c (create_process) [!DOS_NT]:
3043 Remove now-unnecessary calls to emacs_close.
3044
f9a74c4c
EZ
30452013-07-13 Eli Zaretskii <eliz@gnu.org>
3046
922ae7ee
EZ
3047 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3048 returning early. (Bug#14850)
3049
f9a74c4c
EZ
3050 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3051 and inhibit-iso-escape-detection attributes of 'undecided'.
3052 (Bug#14822)
3053
5e301d76
PE
30542013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3055
69e0e5ee
PE
3056 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3057 Reported by Herbert J. Skuhra in
3058 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3059
5e301d76
PE
3060 Don't lose top specpdl entry when memory is exhausted.
3061 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3062 specpdl overflow here, to simplify callers; all callers changed.
3063 Always reserve an unused entry at the stack top; this avoids
3064 losing the top entry's information when memory is exhausted.
3065
7e649856
PE
30662013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3067
a773ed9a
PE
3068 Clean up errno reporting and fix some errno-reporting bugs.
3069 * callproc.c (Fcall_process):
3070 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3071 * process.c (create_process, Fmake_network_process):
3072 * unexaix.c (report_error):
3073 * unexcoff.c (report_error):
3074 Be more careful about reporting the errno of failed operations.
3075 The code previously reported the wrong errno sometimes.
3076 Also, prefer report_file_errno to setting errno + report_file_error.
3077 (Fcall_process): Look at openp return value rather than at path,
3078 as that's a bit faster and clearer when there's a numeric predicate.
3079 * fileio.c (report_file_errno): New function, with most of the
3080 old contents of report_file_error.
3081 (report_file_error): Use it.
3082 (Ffile_exists_p, Ffile_accessible_directory_p):
3083 Set errno to 0 when it is junk.
3084 * fileio.c (Faccess_file):
3085 * image.c (x_create_bitmap_from_file):
3086 Use faccessat rather than opening the file, to avoid the hassle of
3087 having a file descriptor open.
3088 * lisp.h (report_file_errno): New decl.
3089 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3090
7e649856
PE
3091 Minor EBADF fixes.
3092 * process.c (create_process, wait_reading_process_output) [AIX]:
3093 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3094 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3095 a multithreaded environment anyway).
3096 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3097
f6774c1a
AS
30982013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3099
3100 * image.c (x_find_image_file): Don't close a remote file handle.
3101
bacba3c2
PE
31022013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 Fix races with threads and file descriptors.
3105 * callproc.c (Fcall_process_region):
3106 * dired.c (open_directory):
3107 * emacs.c (main, Fdaemon_initialized):
3108 * image.c (x_find_image_file):
3109 * inotify.c (Finotify_rm_watch):
3110 * lread.c (Flocate_file_internal):
3111 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3112 * term.c (term_mouse_moveto, init_tty):
3113 * termcap.c (tgetent):
3114 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3115 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3116 * unexhp9k800.c, unexmacosx.c (unexec):
3117 * callproc.c (Fcall_process_region):
3118 Use emacs_close, not close.
3119 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3120 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3121 and posix_close function on current platforms (which all lack them).
3122 (emacs_close): Use it. This should fix the races on GNU/Linux and
3123 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3124 and it should avoid closing random victim file descriptors on
3125 other platforms.
3126
653d4f43
PE
31272013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3128
c8536ec4
PE
3129 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3130 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3131 Touch up doc a bit.
3132
9c203066
PE
3133 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3134 This is for .gdbinit xbacktrace.
3135
653d4f43
PE
3136 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3137 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3138 (emacs_set_tty): Now static.
3139 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3140 * term.c (tty_capable_p, tty_default_color_capabilities)
3141 (get_tty_terminal, term_mouse_movement)
3142 (handle_one_term_event, init_tty, maybe_fatal):
3143 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3144 (tgetent, scan_file, name_match, compare_contin):
3145 * terminal.c (get_terminal):
3146 Use bool for boolean.
3147 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3148 Prefer char to unsigned char if either will do.
3149 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3150 (tty_write_glyphs): Prefer int to unsigned.
3151 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3152 All callers changed.
3153 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3154
45b683a1
PE
31552013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3156
29abe551
PE
3157 Port to C89.
3158 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3159 (B__dummy__): New dummy symbol, to pacify C89.
3160 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3161 they can't grok varargs macros.
3162 * dispnew.c (add_window_display_history)
3163 (add_frame_display_history):
3164 * print.c (print_object):
3165 * xdisp.c (debug_method_add):
3166 Use %p printf format only for void pointers.
3167 * emacs.c (usage_message): New constant, replacing ...
3168 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3169 (main): Adjust to usage reorg.
3170 * fns.c (syms_of_fns):
3171 * profiler.c (syms_of_profiler):
3172 Don't use non-constant struct initializers.
3173 * gnutls.h (gnutls_initstage_t):
3174 * lisp.h (enum Lisp_Fwd_Type):
3175 * lread.c (lisp_file_lexically_bound_p):
3176 * xsettings.c (anonymous enum):
3177 Remove trailing comma.
3178 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3179 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3180 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3181 (DEFUN): Use it.
3182 * regex.c (const_re_char): New type, to pacify strict C89.
3183 All uses of 'const re_char' replaced to use it.
3184 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3185 with glibc when strict C89. This change is imported from gnulib.
3186 All uses changed.
3187 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3188 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3189 Omit GNU_LINUX implementation, since it requires long long.
3190 * xterm.c (x_draw_underwave):
3191 Do not assume the traditional order of struct's members.
3192 (x_term_init): Rewrite to avoid the need for non-constant structure
3193 initializers.
3194
45b683a1 3195 Syntax cleanup, mostly replacing macros with functions.
763a086d 3196 This removes the need for the syntax_temp hack.
45b683a1
PE
3197 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3198 * syntax.c (SYNTAX_INLINE): New macro.
3199 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3200 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3201 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3202 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3203 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3204 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3205 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3206 Now constants, not macros.
3207 (syntax_temp) [!__GNUC__]: Remove.
3208 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3209 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3210 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3211 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3212 Move here from syntax.h; now functions, not macros. Except for the
3213 last function, these are static since only syntax.c uses them.
3214 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3215 All uses changed. Now a function, not a macro; use this fact
3216 to simplify the code.
3217 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3218 compiler bugs; no longer relevant.
3219 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3220 (SYNTAX_INLINE): New macro.
3221 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3222 for the new functions. Use bool for boolean member.
3223 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3224 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3225 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3226 (SETUP_BUFFER_SYNTAX_TABLE):
3227 Now extern inline functions, not macros.
3228 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3229 Remove; all uses replaced by implementation.
3230 (syntax_temp) [!__GNUC__]: Remove decl.
3231 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3232
29be4a50
JD
32332013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3234
3235 * emacs.c (main): Fix syntax error.
3236
954b166e
PE
32372013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3238
3239 Timestamp fixes for undo (Bug#14824).
3240 * atimer.c (schedule_atimer):
3241 * fileio.c (Ffile_newer_than_file_p):
3242 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3243 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3244 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3245 (syms_of_fileio): Remove Sclear_visited_file_name.
3246 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3247 file doesn't exist; this avoids an ambiguity with negative timestamps.
3248 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3249 * systime.h (make_emacs_time, invalid_emacs_time):
3250 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3251 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3252 * undo.c (record_first_change): Push (visited-file-modtime) onto
3253 undo list rather than reimplementing it by hand, incorrectly.
3254
d74647c3
KB
32552013-07-09 Ken Brown <kbrown@cornell.edu>
3256
3257 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3258
3c51b96b
JB
32592013-07-09 Juanma Barranquero <lekktu@gmail.com>
3260
3261 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3262
4ebbdd67
PE
32632013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 Handle errno and exit status a bit more carefully.
3266 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3267 number into an exit status. Instead, use EXIT_CANCELED.
3268 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3269 * callproc.c (relocate_fd):
3270 * emacs.c (close_output_streams, main):
3271 * process.c (create_process):
3272 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3273 Use emacs_perror for simplicity.
3274 * callproc.c (relocate_fd, main):
3275 * sysdep.c (sys_subshell):
3276 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3277 (shut_down_emacs): Use emacs_write, not write.
3278 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3279 * fileio.c (Fcopy_file, e_write):
3280 * nsterm.m (ns_select):
3281 * process.c (send_process):
3282 * sound.c (vox_write):
3283 Use emacs_write_sig, not emacs_write.
3284 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3285 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3286 New constants.
3287 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3288 of write.
3289 (emacs_full_write): New function.
3290 (emacs_write): Rewrite to use it.
3291 (emacswrite_sig, emacs_perror): New functions.
3292 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3293
44e18199 32942013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3295
3296 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3297 on NS even if it is present. Pixmap on NS is a void*.
3298
9caab067
PE
32992013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 Port to Ubuntu 10 (Bug#14803).
3302 Problem reported by T.V. Raman.
3303 * process.c (close_on_exec, accept4, process_socket):
3304 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3305
1d442672
EZ
33062013-07-07 Eli Zaretskii <eliz@gnu.org>
3307
3308 * w32.c (sys_dup): Declare prototype.
3309
3310 * filelock.c:
3311 * emacs.c:
3312 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3313
067428c1
PE
33142013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 Make file descriptors close-on-exec when possible (Bug#14803).
3317 This simplifies Emacs a bit, since it no longer needs to worry
3318 about closing file descriptors by hand in some cases.
3319 It also fixes some unlikely races. Not all such races, as
3320 libraries often open files internally without setting
3321 close-on-exec, but it's an improvement.
3322 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3323 * callproc.c (Fcall_process) [!MSDOS]:
3324 * emacs.c (main) [!DOS_NT]:
3325 * nsterm.m (ns_term_init):
3326 * process.c (create_process):
3327 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3328 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3329 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3330 Prefer mkostemp with O_CLOEXEC to mkstemp.
3331 * callproc.c (relocate_fd) [!WINDOWSNT]:
3332 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3333 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3334 now using pipe2.
3335 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3336 Make the resulting file descriptor close-on-exec.
3337 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3338 * lread.c (load_descriptor_list, load_descriptor_unwind):
3339 Remove; no longer needed. All uses removed.
3340 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3341 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3342 New functions.
3343 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3344 (Fmake_network_process, Fnetwork_interface_list):
3345 (Fnetwork_interface_info, server_accept_connection):
3346 Make newly-created socket close-on-exec.
3347 * sysdep.c (emacs_open, emacs_fopen):
3348 Make new-created descriptor close-on-exec.
3349 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3350 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3351
0da857dd
JD
33522013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3353
3354 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3355 for NS_IMPL_GNUSTEP.
3356
5f86adcd
PE
33572013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3358
3359 Fix openp errno handling.
3360 * callproc.c (Fcall_process): Preserve openp errno around close.
3361 * lread.c (openp): Set errno when returning -1, as some callers
3362 expect this.
3363
1afb1d07
JD
33642013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3365
3366 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3367
3368 * nsterm.h (NSSavePanel): Update comment.
3369 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3370 (ns_run_file_dialog): Declare.
3371
3372 * nsfns.m: Remove panelOK.
3373 (ns_fd_data): New.
3374 (ns_run_file_dialog): New function.
3375 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3376 event loop, so file dialog is popped up by ns_run_file_dialog, called
3377 by sendEvent (Bug#14578).
3378 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3379
3323c263
EZ
33802013-07-06 Eli Zaretskii <eliz@gnu.org>
3381
fdda0220
EZ
3382 * xdisp.c (default_line_pixel_height): New function.
3383 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3384 (try_cursor_movement, redisplay_window, try_window)
3385 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3386
068f9124
SM
3387 * window.c (window_scroll_pixel_based):
3388 use default_line_pixel_height.
fdda0220
EZ
3389
3390 * dispextern.h (default_line_pixel_height): Add prototype.
3391
3392 * frame.c (x_set_line_spacing): Accept a float value for
3393 line-spacing parameter, per the documentation.
3394
3323c263
EZ
3395 * data.c (Fmultibyte_string_p): Doc fix.
3396
47ba6d43
PE
33972013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3398
406af475
PE
3399 Use emacs_open more consistently when opening files.
3400 This handles EINTR more consistently now, and makes it easier
3401 to introduce other uniform changes to file descriptor handling.
3402 * src/systdio.h: New file.
3403 * src/buffer.c (mmap_init):
3404 * cygw32.c (chdir_to_default_directory):
3405 * dispnew.c (Fopen_termscript):
3406 * emacs.c (Fdaemon_initialized):
3407 * fileio.c (Fdo_auto_save):
3408 * image.c (slurp_file, png_load_body, jpeg_load_body):
3409 * keyboard.c (Fopen_dribble_file):
3410 * lread.c (Fload):
3411 * print.c (Fredirect_debugging_output):
3412 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3413 * termcap.c (tgetent):
3414 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3415 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3416 * w32term.c (w32_initialize) [CYGWIN]:
3417 * xfaces.c (Fx_load_color_file):
3418 Use emacs_open instead of plain open, and emacs_fopen instead of
3419 plain fopen.
3420 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3421 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3422 * callproc.c (default_output_mode): New constant.
3423 (Fcall_process): Use it to call emacs_open instead of plain creat.
3424 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3425 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3426 (emacs_fopen): New function.
3427 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3428 Include <lisp.h>, for emacs_open.
3429 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3430
47ba6d43
PE
3431 Remove duplicate #include directives.
3432 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3433 * xfaces.c:
3434 Don't include stdio.h twice.
3435 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3436 Don't include sys/types.h or stdio.h twice.
3437 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3438 * lread.c: Don't include coding.h twice.
3439 * nsfont.m: Don't include frame.h twice.
3440 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3441 * ralloc.c: Don't include <unistd.h> twice.
3442 * xdisp.c: Don't include font.h twice.
3443 * xterm.c: Don't include fontset.h twice.
3444 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3445
b9ed53d5
PE
34462013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3447
3448 Scale ImageMagick images more carefully.
3449 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3450 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3451 Be more careful about avoiding undefined behavior after
3452 integer overflow and division by zero.
3453
cf13177e
YM
34542013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3455
3456 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3457 (syms_of_w32fns): DEFSYM them.
3458 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3459 (CCHDEVICENAME): Define macros if not defined.
3460 (struct MONITOR_INFO_EX): New struct.
3461 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3462 (enum_display_monitors_fn): New variable.
3463 (globals_of_w32fns): Initialize it.
3464 (Fx_display_pixel_width, Fx_display_pixel_height)
3465 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3466 multi-monitor setups in docstrings.
3467 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3468 screen size by primary monitor's millimeter per pixel.
3469 (w32_monitor_enum, w32_display_monitor_attributes_list)
3470 (w32_display_monitor_attributes_list_fallback)
3471 (Fw32_display_monitor_attributes_list): New functions.
3472 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3473
3474 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3475 if not defined.
3476 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3477
86dfb7a8
MA
34782013-07-04 Michael Albinus <michael.albinus@gmx.de>
3479
3480 * fileio.c (Qfile_notify_error): New error symbol.
3481
3482 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3483 * inotify.c (inotify_callback, symbol_to_inotifymask)
3484 (Finotify_add_watch, Finotify_rm_watch): Use it.
3485 (inotifyevent_to_event): Exchange order of cookie and file name.
3486 (Finotify_add_watch): Adapt docstring.
3487
3488 * lisp.h (Qfile_notify_error): Declare.
3489
2c1c974b
PE
34902013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3493 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3494 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3495 which did not work (see <http://bugs.gnu.org/14569#307>).
3496 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3497 && (!noninteractive || initialized)). This attempts to thread
3498 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3499
7a35b20f
JB
35002013-07-04 Juanma Barranquero <lekktu@gmail.com>
3501
3502 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3503 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3504
1ce5cd04
PE
35052013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3506
3507 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3508 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3509 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3510 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3511
57f8c490
PE
35122013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3515 Define to __sys_siglist.
3516
bcffb5ca
EZ
35172013-07-02 Eli Zaretskii <eliz@gnu.org>
3518
3519 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3520 word-wrap, so that overflow-newline-into-fringe would work in
3521 visual-line-mode. (Bug#2749)
3522 (move_it_in_display_line_to): When the last scanned display
3523 element fits exactly on the display line, and
3524 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3525 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3526 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3527 finding buffer position that corresponds to pixel coordinates,
3528 e.g. in buffer_posn_from_coords.
3529
2c41e781
JD
35302013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3531
3532 * process.c (handle_child_signal): Call catch_child_signal if
3533 NS_IMPL_GNUSTEP.
3534
c2418359
PE
35352013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3536
52a9bcae
PE
3537 Don't convert function pointers to void * and back.
3538 It isn't portable C, and it's easy enough to avoid.
3539 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3540 (make_save_value): Add support for SAVE_FUNCPOINTER.
3541 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3542 * print.c (print_object):
3543 Distinguish function from object pointers.
3544 * lisp.h (SAVE_FUNCPOINTER): New constant.
3545 (SAVE_SLOT_BITS): Adjust to it.
3546 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3547 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3548 (voidfuncptr): New typedef.
3549 (struct Lisp_Save_Value): New member data[0].funcpointer.
3550 (XSAVE_FUNCPOINTER): New function.
3551
c2418359
PE
3552 Simplify buildobj processing.
3553 * Makefile.in (buildobj.h): Make it a sequence of strings each
3554 followed by comma, rather than a single string. Put it into a
3555 .tmp file in case there's an error while generating it.
3556 (gl-stamp): Use .tmp for temp files.
3557 (mostlyclean): Clean .tmp files.
3558 * doc.c (buildobj): Move to just the routine that needs it.
3559 It's now an array of strings, so processing is simpler.
3560
8f43ce49
PE
35612013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3562
3563 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3564 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3565 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3566 Invoke malloc_enable_thread even when not interactive.
3567 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3568 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3569 in this case, since the underlying bug has now been fixed.
3570
24827db9
JB
35712013-07-01 Juanma Barranquero <lekktu@gmail.com>
3572
3573 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3574 unlinking it (bug#14691).
3575
ef099a94
MN
35762013-06-30 Michal Nazarewicz <mina86@mina86.com>
3577
3578 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3579 before checking whether buffer is modified. This lets
3580 `kill-buffer-query-functions' cancel killing of the buffer or save
3581 its content before `kill-buffer' asks user the "Buffer %s
3582 modified; kill anyway?" question.
3583
9d3f2fc2
JD
35842013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3585
3586 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3587 Let the super performKeyEquivalent deal with them (Bug#14747).
3588
e6c6c8c7
PE
35892013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3590
1d71c1d9
PE
3591 * widget.c (resize_cb): Remove unused local.
3592
8f5f35cc
PE
3593 Do not use GTK 3 if it exists but cannot be compiled.
3594 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3595 * xterm.c (x_error_handler) [!USE_GTK]:
3596 Do not use GTK 3.
3597
e6c6c8c7
PE
3598 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3599
0ba54312
EZ
36002013-06-30 Eli Zaretskii <eliz@gnu.org>
3601
5d1c3286
EZ
3602 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3603 to the valid range of values. (Bug#14753)
3604
0ba54312
EZ
3605 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3606 when moving point by using the current glyph matrix. This avoids
3607 the need to force redisplay when this function is called in a
3608 loop.
3609
9c90cc06
PE
36102013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 Fix minor problems found by static checking.
3613 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3614 Redo the latter's body to sidestep GCC parenthesization warnings.
3615 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3616 * coding.c (detect_coding, detect_coding_system):
3617 * coding.h (struct undecided_spec):
3618 Use bool for boolean.
3619 * image.c (QCmax_width, QCmax_height): Now static.
3620 * xdisp.c (Fmove_point_visually): Remove unused local.
3621
4c672a0f
EZ
36222013-06-29 Eli Zaretskii <eliz@gnu.org>
3623
3624 * xdisp.c (Fmove_point_visually): New function.
3625
c1ea3abf
JB
36262013-06-28 Kenichi Handa <handa@gnu.org>
3627
3628 * coding.h (define_coding_undecided_arg_index): New enum.
3629 (coding_attr_index): New members
3630 coding_attr_undecided_inhibit_null_byte_detection,
3631 coding_attr_undecided_inhibit_iso_escape_detection,
3632 coding_attr_undecided_prefer_utf_8.
3633 (undecided_spec): New struct.
3634 (struct coding_system): New member `undecided' of the member
3635 `spec'.
3636
3637 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3638 (detect_coding): Likewise.
3639 (detect_coding_system): Likewise.
3640 (Fdefine_coding_system_internal): New coding system properties
3641 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3642 :prefer-utf-8.
3643 (syms_of_coding): Adjust for coding_arg_undecided_max.
3644
ba3de9e6
PE
36452013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3646
3647 * image.c (x_from_xcolors): Remove unused local.
3648
547c9269
YM
36492013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3650
3651 Defer image data transfer between X client and server until actual
3652 display happens.
3653
3654 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3655 and `mask_img'.
3656
3657 * image.c (Destroy_Image): Remove.
3658 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3659 `mask_p', and `colors_p'. All uses changed.
3660 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3661 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3662 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3663 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3664 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3665 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3666 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3667 (image_get_x_image, image_unget_x_image): New functions or macros.
3668 (image_background, image_background_transparent, x_to_xcolors)
3669 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3670 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3671 instead of Destroy_Image.
3672 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3673 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3674 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3675 (imagemagick_load_image, svg_load_image): Use them instead of
3676 x_create_x_image_and_pixmap, and x_put_x_image followed by
3677 x_destroy_x_image, respectively.
3678 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3679 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3680 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3681 background_transparent fields.
3682 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3683 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3684
dae2f5ef
PE
36852013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3686
3687 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3688 This mostly consists of undoing recent changes.
3689 * callproc.c (Fcall_process):
3690 * process.c (create_process):
3691 Do not worry about catching SIGCHLD here, undoing previous change.
3692 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3693 * process.c, process.h (catch_child_signal):
3694 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3695 * process.c (catch_child_handler): Don't worry about being called
3696 lazily and do not assume caller has blocked SIGCHLD, undoing
3697 previous change. Move first-time stuff back to
3698 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3699 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3700 set lib_child_handler if it's already initialized, which may
3701 help avoid problems on GNUStep.
3702
fa55d2aa
PE
37032013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3704
3705 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3706 * callproc.c (Fcall_process):
3707 * process.c (create_process):
3708 Make sure SIGCHLD is caught before we fork,
3709 since Emacs startup no arranges to catch SIGCHLD.
3710 * process.c (lib_child_handler): Initialize to null, not to
3711 dummy_handler.
3712 (catch_child_signal): Allow self to be called lazily.
3713 Do nothing if it's already been called.
3714 Assume caller has blocked SIGCHLD (all callers do now).
3715 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3716 just before it's really needed.
3717 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3718 since it hasn't been caught yet.
3719
f3f9606c
LMI
37202013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3721
3722 * image.c (compute_image_size): New function to implement
3723 :max-width and :max-height.
3724 (imagemagick_load_image): Use it.
3725
c7041908
PE
37262013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3727
3728 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3729 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3730 Now extern.
3731 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3732 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3733 the SIGCHLD handler, since the code is not atomic and (due to glib)
3734 signals may be arriving now.
3735 * sysdep.c (init_signals): Do not catch child signals here;
3736 'main' now does that later, at a safer time.
3737
f86852b4
PE
37382013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3739
0dfeed58
PE
3740 Clean up SIGCHLD handling a bit (Bug#14569).
3741 * process.c, process.h (catch_child_signal):
3742 Now always extern, even if !NS_IMPL_GNUSTEP.
3743 * process.c (catch_child_signal): Move glib tickler here from
3744 init_process_emacs, so that it's done earlier in Emacs
3745 initialization. Also move the noninteractive && !initialized
3746 check here from init_process_emacs. This is all a bit cleaner for
3747 GNUish platforms, and I hope it works around the Cygwin bug.
3748 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3749 that glib signal handling is tickled before glib creates threads.
3750
f86852b4
PE
3751 * process.c (wait_reading_process_output): Avoid int overflow
3752 when reading more than 2 GiB total from a process.
3753
cbd6509c
PE
37542013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3755
3756 * process.c (create_process): Handle a couple more cases,
3757 i.e., work even if new_argv and wait_child_setup[i] are cached.
3758 Use Fcall_process's style for volatile vars.
3759
9de1114a
AS
37602013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3761
3762 * process.c (create_process): Mark PROCESS volatile.
3763
fbe9e0b9
PE
37642013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3765
3766 Use C99-style flexible array members if available.
3767 This avoids some subtle aliasing issues, which typically
3768 aren't a problem with GCC but may be a problem elsewhere.
3769 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3770 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3771 In either case, it uses a flexible array member rather than
3772 the old struct hack. All uses changed.
3773 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3774 Adjust to sdata reorganization.
3775 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3776 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3777 that ports better to pre-C99 non-GCC.
3778 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3779 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3780 as the latter has changed.
3781 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3782 and port better to pre-C99 GCC.
3783 * image.c (struct xpm_cached_color):
3784 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3785 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3786 Use FLEXIBLE_ARRAY_MEMBER.
3787 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3788 Move decl to top level so it gets checked against implementation.
3789 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3790 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3791
1fc71008
PE
37922013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3793
3794 * syntax.c: Integer cleanups.
3795 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3796 All uses that need 0-or-2 changed to:
3797 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3798 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3799 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3800 (char_quoted, prev_char_comend_first, back_comment)
3801 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3802 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3803 Use bool for boolean.
3804 (update_syntax_table, skip_chars, skip_syntaxes):
3805 Prefer int to unsigned when either will do.
3806 (back_comment): Return boolean success flag, like forw_comment,
3807 instead of positive-or-minus-1 (which might have overflowed int anyway).
3808 Don't stuff ptrdiff_t into int.
3809 (syntax_spec_code, syntax_code_spec): Now const.
3810 (Fmatching_paren, scan_lists, scan_sexps_forward):
3811 Use enum syntaxcode for syntax code.
3812 (Fmatching_paren): Check that arg is a character, not just an integer.
3813 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3814 (Finternal_describe_syntax_value): Omit no-longer-needed
3815 comparison to 0.
3816 (skip_chars): Use char, not unsigned char, when the distinction
3817 doesn't matter.
3818 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3819 * bytecode.c (exec_byte_code):
3820 * syntax.c (syntax_spec_code, Fchar_syntax)
3821 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3822 (init_syntax_once):
3823 * syntax.h (SYNTAX_WITH_FLAGS):
3824 Omit unnecessary casts.
3825
b932cad7
EZ
38262013-06-20 Eli Zaretskii <eliz@gnu.org>
3827
3828 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3829 line dimensions here, to avoid race conditions with the main
3830 thread. (Bug#14062, bug#14630, bug#14669)
3831
3832 * w32term.c (w32_draw_window_cursor): Compute the header line and
3833 mode line dimensions here.
3834 <w32_system_caret_window, w32_system_caret_hdr_height>:
3835 <w32_system_caret_mode_height>: New variables.
3836
3837 * w32term.h: Declare them.
3838
89561f72
PE
38392013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3840
5013fc08
PE
3841 * alloc.c (die): Move "assertion failed" string here ...
3842 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3843 COND when SUPPRESS_CHECKING. This shrinks the executable text
3844 size by 0.8% to 2.2% when configured with --enable-checking,
3845 depending on optimization flags (GCC 4.8.1 x86-64).
3846
89561f72
PE
3847 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3848
763a086d 38492013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3850
3851 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3852 base is 2; this is more accurate.
3853
983aeb9a
JB
38542013-06-19 Juanma Barranquero <lekktu@gmail.com>
3855
3856 * sound.c (string_default): Move to !WINDOWSNT section.
3857 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3858
178ba3e6
PE
38592013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3860
bbc51b15
PE
3861 * sound.c: Integer cleanups.
3862 Remove unnecessary forward decls.
3863 (struct sound_device): The 'file' member is now a Lisp_Object, not
3864 a char *, so that we needn't invoke alloca on a huge size.
3865 (Fplay_sound_internal): Adjust to this.
3866 (string_default): New function.
3867 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3868 Use it to adjust to the struct sound_device change.
3869 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3870 (be2hs) [0]: Remove.
3871
178ba3e6
PE
3872 * syntax.c (skip_chars): Don't use uninitialized storage
3873 when searching a multibyte buffer for characters that are not in a
3874 unibyte string that contains non-ASCII characters.
3875
69f60cdc
JD
38762013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3877
3878 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3879 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3880
0d6224d4
PE
38812013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3884
3c542890
KH
38852013-06-18 Kenichi Handa <handa@gnu.org>
3886
f7e3f7cd
KH
3887 * font.c (Ffont_spec): Signal an error for an invalid font name
3888 (Bug#14648).
3c542890 3889
9349e5f7
PE
38902013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3893 In particular this ports to 32-bit sparc Sun cc.
3894 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3895 array with a dummy element at specpdl[-1], so that its address can
3896 be taken portably.
3897 (unbind_to): Do not copy the binding; not needed, now that we
3898 copy old_value in the one place where the copy is needed.
3899 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3900 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3901 (union specbinding): Rename from struct specbinding. Redo layout
3902 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3903 which is not portable. With Sun C 5.12 32-bit sparc, the
3904 declaration causes nargs to be an unsigned bitfield, a behavior
3905 that the C standard allows; but Emacs wants nargs to be signed.
3906 The overall type is now a union of structures rather than a
3907 structure of union of structures, and the 'kind' member is now a
3908 bitfield, so that the overall type doesn't grow. All uses changed.
3909 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3910
0a4df6a5
PE
39112013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3912
ec6ecaad
PE
3913 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3914 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3915
0a4df6a5
PE
3916 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3917
7bfe8dbc
EZ
39182013-06-17 Eli Zaretskii <eliz@gnu.org>
3919
3920 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3921 unless we know that the window w's frame is a frame object.
3922 Another attempt at solving bug#14062 and bug#14630.
3923
708e05f6
LMI
39242013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3925
3926 * textprop.c (property_set_type): New enum.
3927 (add_properties): Allow appending/prepending text properties.
3928 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3929 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3930 add_text_properties_1.
3931 (Fadd_face_text_property): New function that calls
3932 add_text_properties_1.
3933
84575e67
PE
39342013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3935
3936 Move functions from lisp.h to individual modules when possible.
3937 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3938 * alloc.c (XFLOAT_INIT, set_symbol_name):
3939 * buffer.c (CHECK_OVERLAY):
3940 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3941 (set_char_table_parent):
3942 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3943 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3944 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3945 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3946 (set_blv_valcell):
3947 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3948 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3949 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3950 (backtrace_args, backtrace_debug_on_exit):
3951 * floatfns.c (CHECK_FLOAT):
3952 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3953 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3954 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3955 (set_hash_index_slot):
3956 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3957 * marker.c (CHECK_MARKER):
3958 * textprop.c (CHECK_STRING_OR_BUFFER):
3959 * window.c (CHECK_WINDOW_CONFIGURATION):
3960 Move here from lisp.h, and make these functions static rather than
3961 extern inline.
3962 * buffer.c (Qoverlayp):
3963 * data.c (Qsubrp):
3964 * fns.c (Qhash_table_p):
3965 * window.c (Qwindow_configuration_p):
3966 Now static.
3967 * lisp.h: Remove the abovementioned defns and decls.
3968
44e18199 3969 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3970 In lisp.h, prefer functions to function-like macros, and
3971 constants to object-like macros, when either will do. This:
3972 . simplifies use, as there's no more need to worry about
3973 arguments' side effects being evaluated multiple times.
3974 . makes the code easier to debug on some platforms.
3975 However, when using gcc -O0, keep using function-like macros
3976 for a few critical operations, for performance reasons.
3977 This sort of thing isn't needed with gcc -Og, but -Og
3978 is a GCC 4.8 feature and isn't widely-enough available yet.
3979 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3980 Remove enum lsb_bits; no longer needed.
3981 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3982 * buffer.c (Qoverlap):
3983 * data.c (Qsubrp):
3984 * fns.c (Qhash_table_p):
3985 Now extern, so lisp.h can use these symbols.
3986 * dispextern.h: Include character.h, for MAX_CHAR etc.
3987 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3988 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3989 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3990 (GLYPH_CODE_P): Move here from lisp.h.
3991 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3992 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3993 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3994 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3995 XUNTAG now returns void *.
3996 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3997 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3998 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3999 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4000 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4001 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4002 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4003 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4004 New macros, renamed from their sans-lisp_h_ counterparts.
4005 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4006 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4007 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4008 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4009 If compiling via GCC without optimization, define these as macros
4010 in addition to inline functions.
4011 To disable this, compile with -DINLINING=0.
4012 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4013 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4014 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4015 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4016 (INTMASK, VALMASK): Now macros, since static values cannot be
4017 accessed from extern inline functions.
4018 (VALMASK): Also a constant, for benefit of old GDB.
4019 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4020 is INTEGERP, which can fold it in.
5165d44a 4021 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4022 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4023 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4024 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4025 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4026 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4027 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4028 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4029 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4030 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4031 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4032 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4033 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4034 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4035 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4036 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4037 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4038 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4039 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4040 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4041 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4042 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4043 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4044 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4045 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4046 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4047 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4048 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4049 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4050 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4051 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4052 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4053 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4054 Now functions.
4055 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4056 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4057 (VALMASK): Define in one place rather than in two, merging the
4058 USE_LSB_TAG parts; this is simpler.
4059 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4060 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4061 Move up, to avoid use before definition.
4062 Also include "globals.h" earlier, for the same reason.
4063 (make_natnum): New function.
4064 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4065 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4066 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4067 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4068 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4069 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4070 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4071 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4072 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4073 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4074 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4075 (Qwindow_configuration_p, Qimage): New forward declarations.
4076 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4077 (STRING_COPYIN): Remove; unused.
4078 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4079 (xcar_addr, xcdr_addr): New functions. All uses changed.
4080 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4081 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4082 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4083 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4084 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4085 (TYPE_RANGED_INTEGERP): Simplify.
4086 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4087 (setlocale, fixup_locale, synchronize_system_messages_locale)
4088 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4089 Now empty functions, not macros.
4090 (functionp): Return bool, not int.
4091 * window.c (Qwindow_configuration_p): Now extern,
4092 so window.h can use it.
4093 * window.h (Qwindowp): Move decl back to lisp.h.
4094
9583ec36
EZ
40952013-06-15 Eli Zaretskii <eliz@gnu.org>
4096
4097 * xdisp.c (Fline_pixel_height): New function, required for solving
4098 bug #14567.
4099
210272ce
PE
41002013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4101
4102 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4103
de0503df
SM
41042013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4105
4106 * lread.c (syms_of_lread):
4107 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4108
afbfe143
KD
41092013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4110
4111 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4112
d177e213
XF
41132013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4114
4115 * fileio.c (expand_file_name): Doc fix.
4116
05e3e412
PE
41172013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4118
f7394b12
PE
4119 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4120 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4121 Wait for self, not for 0. This can't hurt on GNU or similar
4122 system, and may help with Cygwin.
4123
05e3e412
PE
4124 * keyboard.c: Don't use PROP (...) as an lvalue.
4125 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4126 Use set_prop (A, B), not PROP (A) = B.
4127
17dd3097
EZ
41282013-06-10 Eli Zaretskii <eliz@gnu.org>
4129
4130 * xdisp.c (get_it_property): Use it->window instead of generating
4131 a Lisp object from it->w.
4132
52fab9c9
EZ
41332013-06-09 Eli Zaretskii <eliz@gnu.org>
4134
4135 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4136 get-char-property the window that is being rendered, instead of
4137 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4138 (compute_display_string_pos): When W is NULL, use the current
4139 buffer as the object to pass to get-char-property.
4140 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4141 pointer member of the bidi iterator, since no window is pertinent
4142 to this function.
52fab9c9 4143
5bf97bfc
EZ
41442013-06-08 Eli Zaretskii <eliz@gnu.org>
4145
4146 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4147 being displayed, and pass it to compute_display_string_pos.
4148 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4149 (bidi_paragraph_init): All callers changed.
4150
4151 * xdisp.c (init_from_display_pos, init_iterator)
4152 (handle_single_display_spec, next_overlay_string)
4153 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4154 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4155 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4156 (compute_display_string_pos): Accept additional argument, the
4157 window being displayed, and pass it to Fget_char_property.
4158 (Bug#14575)
4159
4160 * dispextern.h (struct bidi_it): New member w, the window being
4161 displayed.
4162 (compute_display_string_pos): Adjust prototype.
4163
5de0e011
JD
41642013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4165
e7b41c4c 4166 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4167
4168 * process.c (wait_reading_process_output): Check for NS before GLIB.
4169 GLIB may be linked in due to rsvg, but ns_select must be called.
4170
5de0e011
JD
4171 * xgselect.c (xg_select): Remove call to window_system_available
4172 and g_main_context_pending at the top, so Gdk events (i.e. file
4173 notify) are processed when Emacs is started with -nw.
4174
a822acff
EZ
41752013-06-07 Eli Zaretskii <eliz@gnu.org>
4176
4177 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4178 (ctagsfiles3): New variable, includes only *.m files.
4179 (TAGS): Use an explicit language name in the regular expressions,
4180 to avoid transformation of '/SOMETHING' by MSYS to
4181 'c:\MSYS\SOMETHING'.
4182
6c0a9ed1
RC
41832013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4184
4185 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4186
9ef6111b
EZ
41872013-06-06 Eli Zaretskii <eliz@gnu.org>
4188
4189 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4190 still need to set the mouse pointer shape and activate help-echo.
4191 (Bug#14558)
4192
7d300d64
PE
41932013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4194
4195 A few porting etc. fixes for the new file monitor code.
4196 See the thread containing
4197 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4198 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4199 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4200 (dir_monitor_callback, Fgfile_rm_watch):
4201 Use assq_no_quit instead of Fassoc, for speed.
4202 (dir_monitor_callback, Fgfile_rm_watch):
4203 eassert that the monitor is a fixnum.
4204 (dir_monitor_callback): No need for CDR_SAFE.
4205 Simplify building of lisp with alternative tails.
4206 (Fgfile_add_watch, Fgfile_rm_watch):
4207 Do not assume glib functions set errno reliably on failure.
4208 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4209 and signal an error otherwise.
4210 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4211 Use Fdelq instead of Fdelete, for speed.
4212
817ebfcf
EZ
42132013-06-05 Eli Zaretskii <eliz@gnu.org>
4214
4215 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4216 don't insist on being invoked on a highlighted tool-bar button.
4217 Avoids losing tool-bar functionality when mouse-highlight is nil.
4218 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4219 Don't highlight when mouse-highlight is nil.
4220 (note_mouse_highlight): When mouse-highlight is nil, don't return
4221 right away; instead, run tool-bar and mode-line highlight
4222 subroutine, clear any existing highlight, and revert the mouse
4223 pointer to its default shape. (Bug#14558)
4224
55577e7c
SM
42252013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4226
4227 * lisp.mk (lisp): Add prog-mode.el.
4228
f019a684
PE
42292013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4232 * process.c (dummy_handler): New function.
4233 (lib_child_handler): New static var.
4234 (handle_child_signal): Invoke it.
4235 (catch_child_signal): If a library has set up a signal handler,
4236 save it into lib_child_handler.
4237 (init_process_emacs): If using glib and not on Windows, tickle glib's
4238 child-handling code so that it initializes its private SIGCHLD handler.
4239 * syssignal.h (SA_SIGINFO): Default to 0.
4240 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4241 31; it should no longer be needed now.
4242
90db8702
MA
42432013-06-05 Michael Albinus <michael.albinus@gmx.de>
4244
4245 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4246
4247 * gfilenotify.c (globals_of_gfilenotify): New function.
4248 (syms_of_gfilenotify): Move global initialization there.
4249
4250 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4251
bfa3acd6
SM
42522013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4253
4254 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4255 * keyboard.c (menu_bar_items, tool_bar_items):
4256 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4257 not override local keymaps any more.
4258
ba59bd80
EZ
42592013-06-04 Eli Zaretskii <eliz@gnu.org>
4260
4261 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4262
7f203aa1
EZ
42632013-06-03 Eli Zaretskii <eliz@gnu.org>
4264
9337e206
EZ
4265 * w32console.c (initialize_w32_display): Return the dimensions of
4266 the console window via 2 additional arguments, not via the current
4267 frame. This avoids crashes due to overrunning the bounds of
4268 frame's decode_mode_spec_buffer, which is not resized following
4269 the change of the frame dimensions from the initial 10x10.
4270
4271 * w32term.h (w32_initialize_display_info): Adjust prototype.
4272
4273 * term.c (init_tty): Take dimensions of the frame from the values
4274 returned by initialize_w32_display.
4275
7f203aa1
EZ
4276 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4277 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4278 (LIBES): Add $(GFILENOTIFY_LIBS).
4279
4280 * w32inevt.c (handle_file_notifications): Add dummy implementation
4281 for !HAVE_W32NOTIFY.
4282
4283 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4284
55a87246
JD
42852013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4286
4287 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4288
4289 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4290
4291 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4292
3d5ee10a
PE
42932013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 Fix minor problems found by static checking.
4296 * data.c (pure_write_error):
4297 Use xsignal2, not Fsignal, as Fsignal might return.
4298 * eval.c (set_backtrace_debug_on_exit): Now static.
4299 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4300 No longer inline. EXTERN_INLINE is needed only for functions
4301 defined in .h files. Reindent function header as per GNU style.
4302 (backtrace_p, backtrace_top, backtrace_next):
4303 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4304 compiler or linker. Add extern decls to pacify gcc -Wall.
4305 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4306 Now static.
4307 * frame.c (free_monitors): Define only on platforms that need it.
4308 * nsterm.m (ns_term_init):
4309 * process.c (catch_child_signal):
4310 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4311 defined on all porting targets these days.
4312 * process.c, process.h (catch_child_signal):
4313 Make it extern only if NS_IMPL_GNUSTEP is defined.
4314
e2d8a6f0
EZ
43152013-06-03 Eli Zaretskii <eliz@gnu.org>
4316
4317 * w32.c (gettimeofday): Make the signature identical to prototype
4318 in nt/inc/sys/time.h.
4319
a8a7c5f6
SM
43202013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4321
4322 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4323 .gdbinit.
4324
4325 * keyboard.c (safe_run_hooks_error): Improve error message.
4326
4327 * data.c (pure_write_error): Add `object' argument.
4328 * puresize.h (CHECK_IMPURE): Use it.
4329
c9628c79
MA
43302013-06-03 Michael Albinus <michael.albinus@gmx.de>
4331
4332 * Makefile.in (NOTIFY_OBJ): New variable.
4333 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4334
4335 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4336 Call syms_of_gfilenotify.
4337
4338 * gfilenotify.c: New file.
4339
4340 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4341 and Qfile_w32notify.
4342 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4343 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4344
4345 * lisp.h: Declare syms_of_gfilenotify.
4346
4347 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4348
2f592f95
SM
43492013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4350
4351 Merge the specpdl and backtrace stacks. Make the structure of the
4352 specpdl entries more obvious via a tagged union of structs.
4353 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4354 (enum specbind_tag): New enum.
4355 (struct specbinding): Make it a tagged union of structs.
4356 Add a case for backtrace records.
4357 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4358 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4359 (backtrace_debug_on_exit): New accessors.
4360 (struct backtrace): Remove.
4361 (struct catchtag): Remove backlist field.
4362 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4363 Move to eval.c.
4364 (Flocal_variable_p): Speed up the common case where the binding is
4365 already loaded.
4366 * eval.c (backtrace_list): Remove.
4367 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4368 (set_backtrace_args, set_backtrace_nargs)
4369 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4370 (backtrace_next): New functions.
4371 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4372 (unwind_to_catch, internal_lisp_condition_case)
4373 (internal_condition_case, internal_condition_case_1)
4374 (internal_condition_case_2, internal_condition_case_n): Don't bother
4375 with backtrace_list any more.
4376 (Fsignal): Adjust to new backtrace format.
4377 (grow_specpdl): Move up.
4378 (record_in_backtrace): New function.
4379 (eval_sub, Ffuncall): Use it.
4380 (apply_lambda): Adjust to new backtrace format.
4381 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4382 data.c.
4383 (specbind): Adjust to new specpdl format. Simplify.
4384 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4385 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4386 backtrace format.
4387 (mark_backtrace): Remove.
4388 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4389 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4390 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4391 Use mark_specpdl.
4392 * profiler.c (record_backtrace): Use get_backtrace.
4393 (handle_profiler_signal): Use backtrace_top_function.
4394 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4395 accessor functions.
4396
c0342369
JD
43972013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4398
4399 * process.h (catch_child_signal): Declare.
4400
4401 * process.c (catch_child_signal): New function.
4402 (init_process_emacs): Call it.
4403
4404 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4405 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4406 NS_IMPL_COCOA.
4407 (x_set_cursor_type): Remove declaration.
4408 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4409 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4410 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4411 (ns_get_color): Use F suffix on float.
4412 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4413 (ns_get_rgb_color): Remove.
4414 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4415 (note_mouse_movement): x and y are CGFloat.
4416 (ns_draw_fringe_bitmap): Remove unused rowY.
4417 Change #if to COCOA && >= 10_6.
4418 (ns_draw_window_cursor): Remove unused overspill.
4419 (ns_draw_underwave): width and x are EamcsCGFloat.
4420 (ns_draw_box): thickness is CGFloat.
4421 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4422 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4423 if not in main thread.
4424 (ns_get_pending_menu_title, ns_check_menu_open)
4425 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4426 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4427 (sendFromMainThread:): New method.
4428 (changeFont:): size is CGFloat.
4429 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4430 Disable warning about permanent text.
4431 (characterIndexForPoint:): Adjust return type depending on GNUStep
4432 version.
4433 (mouseDown:): delta is CGFloat.
4434 (updateFrameSize): Remove unised variable f.
4435 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4436 Cast float to EmacsCGFloat.
4437 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4438 also to -1 when restoring.
4439 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4440 inside NS_IMPL_COCOA.
4441 (toggleFullScreen:): Put call to toggleFullScreen inside
4442 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4443 (setPosition:portion:whole:): por is CGFloat.
4444 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4445 (mouseDown:): Use CGFloat.
4446 (mouseDragged:): Remove unised variable edge.
4447 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4448
4449 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4450 of CGFloat differs.
4451 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4452 when NS_IMPL_GNUSTEP.
4453 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4454 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4455 (EmacsToolbar): Add clearAll. Add tag argument to
4456 addDisplayItemWithImage.
4457 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4458
4459 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4460
4461 * nsmenu.m (ns_update_menubar): Make static.
4462 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4463 (fillWithWidgetValue:): Add cast to SEL for setAction.
4464 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4465 (update_frame_tool_bar): Update code for GNUStep.
4466 (clearAll): New method.
4467 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4468 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4469 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4470 call to insertItemWithItemIdentifier.
4471 (validateVisibleItems): Fix indentation.
4472 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4473 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4474 UtilityWindow to aStyle, remove call to setStyleMask.
4475
4476 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4477
4478 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4479 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4480 Use F suffix on floats.
4481 (ns_char_width): Returns CGFloat.
4482 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4483 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4484 DPSxshow.
4485 (ns_glyph_metrics): CGFloat instead of float.
4486
a0eb10b3
JB
4487 * nsfns.m (x_set_foreground_color, x_set_background_color):
4488 Use EmacsCGFloat.
4489 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4490 remove unused variables.
4491 (Fns_read_file_name): Keep track if panel is for save.
4492 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4493 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4494 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4495 Just return the input if GNUStep.
c0342369
JD
4496 (x_screen_planes): Remove.
4497 (Fxw_color_values): Use EmacsCGFloat
4498 (Fns_display_monitor_attributes_list): Only get screen number for
4499 Cocoa.
ef099a94 4500 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4501 EmacsSavePanel.
4502 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4503 ns_directory_from_panel.
4504
da9aff11
PE
45052013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4506
4507 * process.c (handle_child_signal): Also use WCONTINUED.
4508 This is so that list-processes doesn't mistakenly list the process
4509 as stopped, when the process has actually been continued and is
4510 now running.
4511
0e64479a
PE
45122013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4513
fc186a96
PE
4514 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4515 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4516 not already configured.
4517
0e64479a
PE
4518 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4519
38b787fa
EZ
45202013-05-29 Eli Zaretskii <eliz@gnu.org>
4521
4522 * Makefile.in (mostlyclean): Remove *.res files.
4523
22513e52
SM
45242013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4525
4526 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4527 a buffer (bug#8447).
4528
6ef3db10
EZ
45292013-05-27 Eli Zaretskii <eliz@gnu.org>
4530
4531 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4532 display vector, and we backtrack, handle the case that the
4533 previous character position is also displayed from a display
4534 vector or covered by a display string or image. (Bug#14476)
4535
6799bb26
JD
45362013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4537
4538 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4539 (struct MonitorInfo, free_monitors): Remove.
4540 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4541 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4542 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4543 Qframes, Qsource.
4544
4545 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4546 (struct MonitorInfo, free_monitors): Remove.
4547 (ns_screen_name): Make static.
4548 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4549 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4550 Qframes, Qsource.
4551
4552 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4553 (struct MonitorInfo): New struct.
4554 (free_monitors, make_monitor_attribute_list): Declare.
4555
22513e52
SM
4556 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4557 New Lisp_Object:s.
6799bb26
JD
4558 (free_monitors, make_monitor_attribute_list): New functions.
4559 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4560 Qsource.
4561
38cd43eb
XF
45622013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4563
4564 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4565
2af0948d
SM
45662013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4567
a7eb9b0f
SM
4568 * keyboard.c: Apply keyboard decoding only to events that come directly
4569 from the tty, not from unread-command-events (bug#14368).
4570 (read_event_from_main_queue): New function, extracted from read_char).
4571 (read_decoded_char): Remove.
4572 (read_decoded_event_from_main_queue): New function to replace it.
4573 (read_char): Use it.
4574 (read_key_sequence): Use read_char rather than read_decoded_char.
4575
2af0948d
SM
4576 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4577
1413e9a5
BR
45782013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4579
4580 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4581
e6d2f155
KH
45822013-05-22 Kenichi Handa <handa@gnu.org>
4583
4584 The following changes are to fix the setting of
4585 buffer-file-coding-system on, for instance, C-x RET c unix RET
4586 _FILE_OF_DOS_EOL_TYPE_ RET.
4587
4588 * coding.h (struct coding_system): New member detected_utf8_chars.
4589
4590 * coding.c (detect_coding_utf_8): Count characters and check EOL
4591 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4592 BOM is there.
4593 (setup_coding_system): Do not initialize coding->head_ascii.
4594 (check_ascii): Do not set coding->eol_seen but update it. Do not
4595 call adjust_coding_eol_type here.
1413e9a5
BR
4596 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4597 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4598 of the found coding-system.
4599 (decode_coding_gap): Cancel previous change. Utilize the
4600 character numbers counted by detect_coding_utf_8. Fix detection
4601 of BOM for utf-8.
4602
ab56a6f4 46032013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4604
4605 * search.c (looking_at_1): Only set last_thing_searched if the match
4606 changed the match-data (bug#14281).
4607
ecc3c6ed
DA
46082013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4609
4610 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4611 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4612 (move_it_vertically_backward): Likewise.
4613
5ba8bf35
YM
46142013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4615
4616 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4617 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4618 (Fx_display_mm_width, Fx_display_mm_height):
4619 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4620
91e8418b 4621 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4622 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4623 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4624 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4625 (Fx_display_backing_store, Fx_display_visual_class)
4626 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4627 (Fx_display_grayscale_p, Fx_display_pixel_width)
4628 (Fx_display_pixel_height, Fx_display_planes)
4629 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4630 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4631 (Fx_display_mm_width, Fx_display_mm_height)
4632 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4633 height for all physical monitors as in X11.
4634
fc30d803
SM
4635 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4636 Return pixel width or height for all physical monitors as in X11.
91e8418b 4637
31ff141c
PE
46382013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4639
4640 Port --enable-gcc-warnings to clang.
4641 * bytecode.c (exec_byte_code):
4642 * regex.c:
4643 Redo diagnostic pragmas to pacify clang, too.
4644 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4645 * editfns.c (Fencode_time):
4646 * fileio.c (file_accessible_directory_p):
4647 * font.c (font_unparse_xlfd):
4648 Use '&"string"[index]' instead of '"string" + (index)'.
4649 * undo.c (user_error): Remove; unused.
4650
df065a0b
EZ
46512013-05-16 Eli Zaretskii <eliz@gnu.org>
4652
04d360e7
EZ
4653 * insdel.c (insert_1_both): Document the arguments, instead of
4654 referring to insert_1, which no longer exists.
4655
5bb98290
EZ
4656 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4657 some window, increment windows_or_buffers_changed, so that
4658 *Messages* display in that window is updated. (Bug#14408)
4659
df065a0b
EZ
4660 * w32.c: Include epaths.h.
4661 (init_environment): Use cmdproxy.exe without leading directories.
4662 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4663 case.
4664 (gettimeofday): Adjust signature and return value to Posix
4665 expectations.
4666
4667 * unexw32.c (open_output_file): Delete the existing emacs.exe
4668 before creating it, to break the hard link to the versioned
4669 executable.
4670
4671 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4672 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4673 (FIRSTFILE_OBJ): New variables.
4674 (W32_RES): Rename to EMACSRES. All users changed.
4675 (base_obj): Use $(CM_OBJ).
4676 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4677 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4678 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4679 $(W32_RES_LINK) before $(LIBES).
4680 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4681
1aa8d505
SM
46822013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4683
6e911150
SM
4684 * makefile.w32-in (DOC): Use just "DOC".
4685
4686 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4687
1aa8d505
SM
4688 * process.c: Export default filters and sentinels to Elisp.
4689 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4690 New constants.
4691 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4692 (Fset_process_sentinel, Fformat_network_address):
4693 Default to them instead of nil.
4694 (server_accept_connection): Sentinels can't be nil any more.
4695 (read_and_dispose_of_process_output): New function, extracted from
4696 read_process_output.
4697 (read_process_output): Use it; filters can't be nil.
4698 (Finternal_default_process_filter): New function, extracted from
4699 read_process_output.
4700 (exec_sentinel_unwind): Remove function.
4701 (exec_sentinel): Don't zilch sentinel while running.
4702 (status_notify): Sentinels can't be nil.
4703 (Finternal_default_process_sentinel): New function extracted from
4704 status_notify.
4705 (setup_process_coding_systems): Default filter is not nil any more.
4706 (syms_of_process): Export new Elisp functions and initialize
4707 new constants.
4708 * lisp.h (make_lisp_proc): New function.
4709
5ac2eb34
SM
47102013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4711
4712 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4713
eda9c7d7
EZ
47142013-05-14 Eli Zaretskii <eliz@gnu.org>
4715
4716 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4717 unless we know that the window w is a leaf window.
4718 Another attempt at solving bug#14062.
eda9c7d7 4719
8fdeaad5
JD
47202013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4721
4722 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4723 fdesc (Bug#14375).
4724
44aa9ee6
PE
47252013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4726
4727 * image.c (gif_load): Check that subimages fit (Bug#14345).
4728
759fd763
SM
47292013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4730
4731 * lread.c (skip_dyn_eof): New function.
4732 (read1): Use it to skip the end of a file in response to #@00.
4733
4734 * doc.c (get_doc_string): Slightly relax the sanity checking.
4735
4465bfb4
JD
47362013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4737
4738 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4739 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4740 (MonitorInfo): New struct.
4741 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4742 (Fns_display_monitor_attributes_list): New functions.
4743 (display-usable-bounds): Remove.
4744 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4745 Qsource.
4746
7583e2a0
PE
47472013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4748
4749 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4750 (GTK_CHECK_VERSION): New macro, if not already defined.
4751 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4752 replaced by GTK_CHECK_VERSION.
4753
ad75d77e
PE
47542013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4755
4756 * xterm.h (GTK_PREREQ): New macro.
4757 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4758 to use this macro instead, for consistency and clarity.
4759
07525f77
EZ
47602013-05-08 Eli Zaretskii <eliz@gnu.org>
4761
4762 * xdisp.c (row_for_charpos_p): New function, with code of
4763 cursor_row_p, but accepts an additional argument CHARPOS instead
4764 of using a hardcoded PT.
4765 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4766 (row_containing_pos): Call row_for_charpos_p instead of partially
4767 doing the same. Fixes cursor positioning under longlines-mode
4768 when longlines-show-effect includes more than one newline, when
4769 moving the cursor vertically up.
4770
d901fc8d
JB
47712013-05-08 Juanma Barranquero <lekktu@gmail.com>
4772
4773 * makefile.w32-in (ACL_H): New macro.
4774 ($(BLD)/fileio.$(O)): Update dependencies.
4775
f269bc61
PE
47762013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4777
e7b41c4c 4778 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4779 * Makefile.in (LIB_ACL): New macro.
4780 (LIBACL_LIBS): Remove.
4781 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4782 * fileio.c: Include <acl.h>.
4783 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4784 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4785 !acl_errno_valid.
4786 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4787 it ourselves.
4788
f269bc61
PE
4789 * unexelf.c: Don't assume ElfW (Half) fits in int.
4790 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4791 when dealing with ElfW (Half) values, since they can exceed 2**31
4792 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4793 (entry_address): Omit unused NUM arg. All uses changed.
4794
a261c53e
JL
47952013-05-07 Juri Linkov <juri@jurta.org>
4796
4797 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4798 to the string converted from number with `Fnumber_to_string'.
4799 (Bug#14254)
4800
2b66427d
PE
48012013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4802
4803 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4804 This fixes a problem introduced by my previous change.
4805
15acfe41
GM
48062013-05-07 Glenn Morris <rgm@gnu.org>
4807
4808 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4809
5ea03bf5
JD
48102013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4811
4812 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4813
e0c9d565
PE
48142013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4815
4816 Static checking by GCC 4.8.0.
4817 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4818 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4819 (x_get_monitor_attributes_fallback)
4820 (x_get_monitor_attributes_xinerama)
4821 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4822 Define only if USE_GTK.
4823 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4824 (x_get_monitor_attributes_fallback): Omit unused locals.
4825 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4826 Use double, not float, to avoid mixed-mode floating point arithmetic.
4827
4e3f9230
YM
48282013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4829 Jan Djärv <jan.h.d@swipnet.se>
4830
4831 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4832 (XINERAMA_CFLAGS): New macros.
4833 (ALL_CFLAGS, LIBES): Use them.
4834
4835 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4836 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4837 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4838 (syms_of_xfns): DEFSYM them.
4839 (struct MonitorInfo): New struct.
4840 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4841 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4842 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4843 (x_get_monitor_attributes_xinerama): New functions.
4844 (Fx_display_monitor_attributes_list): New primitive.
4845 (syms_of_xfns): Defsubr it.
4846
4847 * xterm.h (x_display_info): Add Xatom_net_workarea and
4848 Xatom_net_current_desktop.
4849
4850 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4851 and dpyinfo->Xatom_net_current_desktop.
4852
05839b6a
EZ
48532013-05-06 Eli Zaretskii <eliz@gnu.org>
4854
4855 * xdisp.c (pos_visible_p): Use the special code for finding the
4856 beginning of a display property or overlay for any "replacing"
4857 display property, not just for display strings. This solves
4858 incorrect reporting of position by posn-at-point. (Bug#14241)
4859
dc4a2ee0
PE
48602013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4861
5ee94506
PE
4862 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4863 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4864 Verify that ElfW (Half) fits in int.
4865 (fatal): Use same signature as lisp.h.
4866 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4867 configure and build with -DUNEXELF_DEBUG without worrying about
4868 other modules that use DEBUG.
4869 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4870 possibly-wide integers now uses it instead of plain fprintf.
4871 (entry_address): New function, which avoids problems with 32-bit
4872 overflow on 64-bit hosts.
4873 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4874 (round_up): Don't assume the remainder fits in int.
4875 (find_section): Use bool for boolean. Simplify debug code.
4876 (unexec): Don't assume file sizes fit in int or size_t.
4877 Omit unnecessary trailing newline in 'fatal' format.
4878 Use strerror rather than outputting decimal error number.
4879 Remove unused code when emacs is not defined;
4880 this file relies on Emacs now.
4881 Don't assume e_phnum and e_shnum are positive.
4882
dc4a2ee0
PE
4883 * regex.c: Fix problems when DEBUG is defined.
4884 (extract_number, extract_number_and_incr): Define regardless of
4885 whether DEBUG is defined; that's simpler and makes the code less
4886 likely to go stale in the normal case when DEBUG is not defined.
4887 Return int rather than taking an int * arg. All callers changed.
4888 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4889 Remove, replacing with ...
4890 (DEBUG_PRINT): New macro. All callers changed.
4891 (DEBUG_COMPILES_ARGUMENTS): New macro.
4892 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4893 (print_compiled_pattern, print_double_string) [DEBUG]:
4894 Use prototype rather than old-style definition.
4895 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4896 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4897 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4898 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4899 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4900 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4901 This matters only when DEBUG is defined.
4902
14c7ed05
EZ
49032013-05-05 Eli Zaretskii <eliz@gnu.org>
4904
4905 * xdisp.c (set_iterator_to_next): Set the
4906 ignore_overlay_strings_at_pos_p flag only if we are _really_
4907 iterating over an overlay string, as indicated by the
4908 current.overlay_string_index member. (Bug#14306)
4909
e6076b1b
JD
49102013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4911
4912 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4913 to where it is used, to avoid autorelease issues (Bug#14050).
4914
cbee2131
PE
49152013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4916
4917 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4918 * fileio.c (syms_of_fileio): Implement this.
4919 * filelock.c (create_lock_file): If symbolic links don't work, so
4920 we use a regular file as a lock file, do not fsync the lock file;
4921 it's not needed.
4922
30c7e542
SM
49232013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4924
4925 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4926 (syms_of_minibuf): Adjust accodingly.
4927 * lread.c (Fread):
4928 * callint.c (Fcall_interactively): Adjust calls accordingly.
4929
5bebd186
EZ
49302013-05-04 Eli Zaretskii <eliz@gnu.org>
4931
4932 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4933 w->contents is a buffer before computing everything else.
4934 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4935
4936 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4937 assertion violations. (Bug#14062)
4938
0fb0a4f3
DR
49392013-05-01 David Reitter <david.reitter@gmail.com>
4940
4941 * nsfns.m (ns_tooltip): Initialize.
4942
9e63b4a5
EZ
49432013-04-28 Eli Zaretskii <eliz@gnu.org>
4944
4945 * coding.c (decode_coding_gap): Don't remove the character before
4946 a newline unless it's a CR character. (Bug#14287)
4947
ad60824e
DN
49482013-04-28 Dan Nicolaescu <dann@gnu.org>
4949
4950 * dispextern.h (struct face): Move enum face_underline_type
4951 earlier so that bitfields can be in the same word.
4952
edbdcec0
JD
49532013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4954
4955 * nsfns.m (handlePanelKeys): New function.
4956 (EmacsOpenPanel:performKeyEquivalent:)
4957 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4958 arrows/function/control and copy/paste keys (Bug#14296).
4959
0208ede7
JL
49602013-04-27 Juri Linkov <juri@jurta.org>
4961
4962 * callint.c (Fcall_interactively): Call `Qread_number' for
4963 interactive code letter `n' instead of using duplicate code.
4964 (Bug#14254)
4965
b8dd59f7
PE
49662013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 * systime.h (make_timeval): Declare as 'const'.
4969
8bd722db
KH
49702013-04-27 Kenichi Handa <handa@gnu.org>
4971
4972 * font.c (font_open_entity): Always open a font of manageable
4973 size.
4974
13d0e56f 49752013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4976
f780d632
PE
4977 Port better to AIX (Bug#14258).
4978 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4979 to pacify AIX xlc.
4980
ec509856
KH
49812013-04-24 Kenichi Handa <handa@gnu.org>
4982
4983 * coding.c (decode_coding_iso_2022): When an invalid escape
4984 sequence is encountered, reset the invocation and designation
4985 status to the safest one.
4986
84fc48e5
PE
49872013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4988
4989 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4990 Without this fix, "make distclean" leaves stamp-h1 behind.
4991
806bda47
EC
49922013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4993
4994 * w32fns.c (w32_fullscreen_rect): New function to compute the
4995 window rectangle for the given fullscreen mode.
4996 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4997 longer tunes the window size. This keeps the window's edges flush
4998 with the screen and allows the taskbar to hide itself in fullboth.
4999
5000 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5001 window decorations and uses the entire screen.
5002
5003 * w32term.h (w32_fullscreen_rect) Add prototype.
5004 (struct w32_output): Replace normal_width, normal_height,
5005 normal_top, and normal_left members with a single normal_placement
5006 struct.
5007 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5008 Remove macros.
5009 (FRAME_NORMAL_PLACEMENT): New macro.
5010
9cc2810b
JB
50112013-04-16 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * minibuf.c (Ftest_completion): Silence compiler warning.
5014
fd16b54c
EZ
50152013-04-15 Eli Zaretskii <eliz@gnu.org>
5016
5017 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5018 bug#14062.
fd16b54c
EZ
5019
5020 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5021 parentheses.
5022
5023 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5024 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5025 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5026 parentheses where appropriate.
5027
9e3379a0
PE
50282013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5029
5030 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5031
ddd6b685
EZ
50322013-04-14 Eli Zaretskii <eliz@gnu.org>
5033
5034 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5035 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5036 Mention in the doc string that setting these variables takes
5037 effect only after a call to set-window-buffer. (Bug#14200)
5038
29b79ba1
EZ
50392013-04-13 Eli Zaretskii <eliz@gnu.org>
5040
5041 * indent.c (Fvertical_motion): Don't consider display strings on
5042 overlay strings as display strings on the buffer position we
5043 started from. This prevents vertical cursor motion from jumping
5044 more than one line when there's an overlay string with a display
5045 property at end of line.
5046 Reported by Karl Chen <Karl.Chen@quarl.org> in
5047 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5048
562c6ee9
SM
50492013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5050
5051 * window.c (select_window): `record_buffer' even if window is
5052 already selected (bug#14191).
5053
fcc1fe85
EZ
50542013-04-11 Eli Zaretskii <eliz@gnu.org>
5055
5056 * window.c (Fwindow_end): Test more flags, including the buffer's
5057 last_overlay_modified flag, to determine whether the window's
5058 display is really up-to-date. Prevents the function from
5059 returning a stale value. (Bug#14170)
5060 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5061 current matrix.
5062
f009190a
EZ
50632013-04-10 Eli Zaretskii <eliz@gnu.org>
5064
5065 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5066 garbaged only if it is not already the top frame on its TTY.
5067 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5068 there are GUI frames open in the same session. (Bug#13864)
5069
78ce603d
SM
50702013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5071
5072 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5073 of marking the idle timers directly.
5074
a8036e40
SM
50752013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5076
5077 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5078 tables (bug#14054).
5079
7ffe7ef6
SM
50802013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5081
5082 * window.c (select_window): Don't record_buffer while the invariant is
5083 temporarily broken (bug#14161).
5084
5085 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5086
7d9f6883
EZ
50872013-04-07 Eli Zaretskii <eliz@gnu.org>
5088
5089 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5090
5406cfd9
RF
50912013-04-07 Romain Francoise <romain@orebokech.com>
5092
5093 Ignore additional platform-specific ACL errors (Bug#13702).
5094 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5095 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5096
95c0e83b
JD
50972013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5098
5099 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5100 f->output_data.ns.
5101
876da980
PE
51022013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5103
5104 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5105 This bug was introduced by my 2013-02-25 change that simplified
5106 data_start configuration. Without this change, on GNU/Linux
5107 an Emacs configured with --enable-profiling fails immediately
5108 due to a profiler signal.
5109 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5110 with these flags. On platforms where special flags are needed
5111 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5112 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5113 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5114
7452b7bd
DA
51152013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5116
5117 Get rid of some platform-specific functions examining window
5118 system and its capabilities. This is a partial rework of the
5119 2013-04-05 change.
5120 * lisp.h (have_menus_p): Remove prototype. This function is
5121 replaced with platform-independent window_system_available.
5122 (check_window_system): Move to...
5123 * frame.h (decode_window_system_frame, window_system_available):
5124 ...here, add new prototypes.
5125 * frame.c (window_system_available, decode_window_system_frame):
5126 New functions.
5127 (check_window_system): Platform-independent now.
5128 * xterm.h (x_in_use): Remove declaration.
5129 (check_x_frame):
5130 * w32term.h (check_x_frame):
5131 * nsterm.h (check_x_frame): Remove prototypes. This function
5132 is replaced with platform-independent decode_window_system_frame.
5133 * msdos.c (have_menus_p): Remove.
5134 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5135 Remove platform-specific functions. Use check_window_system,
5136 decode_window_system_frame and check_ns_display_info where
5137 appropriate. Minor style and comment tweaks.
5138 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5139 (check_x_frame): Likewise.
5140 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5141 Likewise.
5142 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5143 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5144 * xmenu.c, xselect.c: All related users changed.
5145
251e9147
KH
51462013-04-03 Kenichi Handa <handa@gnu.org>
5147
5148 The following changes is to optimize the code for reading UTF-8
5149 files.
5150
562c6ee9 5151 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5152 changed. Check EOL format. Do not call adjust_coding_eol_type
5153 here.
5154 (check_utf_8): New function.
5155 (adjust_coding_eol_type): Do nothing if already adjusted.
5156 (detect_coding): Compare the return value of check_ascii with
5157 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5158 (decode_coding_gap): Optimize for valid UTF-8.
5159
8bc369d4
KH
51602013-03-21 Kenichi Handa <handa@gnu.org>
5161
5162 * coding.c (syms_of_coding): Cancel previous change.
5163
5164 * insdel.c (insert_from_gap): Fix previous change.
5165
73931ad1
DA
51662013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5167
5168 Consistently use platform-specific function to detect window system.
5169 * lisp.h (check_window_system): New prototype. This function is
5170 going to replace check_x, check_w32 and check_ns.
5171 (have_menus_p): Mention msdos.c in comment.
5172 * fontset.c (check_window_system_func): Remove. Adjust all users.
5173 * fontset.h (check_window_system_func): Remove prototype.
5174 * nsterm.h (check_ns):
5175 * xterm.h (check_x):
5176 * w32term.h (check_w32): Likewise.
5177 * menu.c (Fx_popup_menu): Use check_window_system.
5178 * msdos.c (check_window_system): Define for MS-DOS.
5179 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5180 * w32fns.c (check_window_system): Likewise for MS-Windows.
5181 * xfns.c (check_window_system): Likewise for X.
5182 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5183 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5184
7216e43b
PE
51852013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5186
5187 Prefer < to > in range checks such as 0 <= i && i < N.
5188 This makes it easier to visualize quantities on a number line.
5189 This patch doesn't apply to all such range checks,
5190 only to the range checks affected by the 2013-03-24 change.
5191 This patch reverts most of the 2013-03-24 change.
5192 * alloc.c (xpalloc, Fgarbage_collect):
5193 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5194 * character.c (string_escape_byte8):
5195 * charset.c (read_hex):
5196 * data.c (cons_to_unsigned):
5197 * dispnew.c (update_frame_1):
5198 * doc.c (Fsubstitute_command_keys):
5199 * doprnt.c (doprnt):
5200 * editfns.c (hi_time, decode_time_components):
5201 * fileio.c (file_offset):
5202 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5203 * font.c (font_intern_prop):
5204 * frame.c (x_set_alpha):
5205 * gtkutil.c (get_utf8_string):
5206 * indent.c (check_display_width):
5207 * keymap.c (Fkey_description):
5208 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5209 * lread.c (read1):
5210 * minibuf.c (read_minibuf_noninteractive):
5211 * process.c (wait_reading_process_output):
5212 * search.c (Freplace_match):
5213 * window.c (get_phys_cursor_glyph):
5214 * xdisp.c (redisplay_internal):
5215 * xsmfns.c (smc_save_yourself_CB):
5216 Prefer < to > for range checks.
5217 * dispnew.c (sit_for): Don't mishandle NaNs.
5218 This fixes a bug introduced in the 2013-03-24 change.
5219 * editfns.c (decode_time_components): Don't hoist comparison.
5220 This fixes another bug introduced in the 2013-03-24 change.
5221
92759988
DA
52222013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5223
5224 * frame.h (struct frame): Drop scroll_bottom_vpos
5225 member becaue all real users are dead long ago.
5226 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5227 * xdisp.c (redisplay_internal): Adjust user.
5228
9a1971bb
GM
52292013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5230
f38ab167
JD
5231 * nsmenu.m (showAtX:Y:for:): setLevel to
5232 NSPopUpMenuWindowLevel (Bug#13998).
5233
6d01f1fe
JD
52342013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5235
5236 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5237 (ns_check_pending_open_menu): Declare.
5238
5239 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5240 (x_activate_menubar): Update the menu with title that matches
5241 ns_get_pending_menu_title, and call
5242 ns_check_pending_openmenu (Bug#12698).
5243 (menuWillOpen:): New method.
5244 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5245
5246 * nsterm.m (menu_will_open_state, menu_mouse_point)
5247 (menu_pending_title): New varaibles.
5248 (ns_get_pending_menu_title, ns_check_menu_open)
5249 (ns_check_pending_open_menu): New functions.
5250
781f4782
DA
52512013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5252
5253 * indent.c (current_column_bol_cache): Remove leftover which is not
5254 used in Fmove_to_column any more.
5255 (current_column, scan_for_column): Adjust users.
5256 * keyboard.c (last_point_position_buffer, last_point_position_window):
5257 Remove leftovers which are not used for recording undo any more.
5258 (command_loop_1, syms_of_keyboard): Adjust users.
5259 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5260 redisplay_window any more.
5261 (move_it_to): Adjust user.
5262
1921c31b
JB
52632013-03-29 Juanma Barranquero <lekktu@gmail.com>
5264
5265 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5266 Update dependencies.
5267
717b8bcd
SM
52682013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5269
5270 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5271 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5272 forward references.
5273
e74aeda8
DA
52742013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5275
5276 * window.h (struct window): Replace hchild, vchild and buffer slots
5277 with the only contents slot. This is possible because each valid
5278 window may have either the child window (in vertical or horizontal
5279 combination) or buffer to display (for the leaf window). Using that,
5280 a lof of operations to traverse and/or change window hierarchies may
5281 be simplified. New member horizontal is used to distinguish between
5282 horizontal and vertical combinations of internal windows.
5283 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5284 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5285 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5286 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5287 Use contents slot, not buffer, where appropriate.
5288 (wset_combination): New function.
5289 (wset_buffer): Add eassert.
5290 (Fframe_first_window): Simplify the loop reaching first window.
5291 (Fwindow_buffer): Use WINDOW_LEAF_P.
5292 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5293 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5294 (unshow_buffer): Convert initial debugging check to eassert.
5295 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5296 (make_parent_window, window_resize_check, window_resize_apply)
5297 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5298 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5299 Adjust to match struct window changes.
5300 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5301 (mark_window_cursors_off, count_windows, get_leaf_windows)
5302 (foreach_window_1): Simplify the loop.
5303 * alloc.c (mark_object): Do not check for the leaf window because
5304 internal windows has no glyph matrices anyway.
5305 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5306 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5307 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5308 (build_frame_matrix_from_window_tree, mirror_make_current)
5309 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5310 (update_window_tree, set_window_update_flags): Simplify the loop.
5311 (sync_window_with_frame_matrix_rows): Enforce live window.
5312 Use contents slot, not buffer, where appropriate.
5313 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5314 and WINDOW_HORIZONTAL_COMBINATION_P.
5315 (make_frame_visible_1): Simplify the loop.
5316 Use contents slot, not buffer, where appropriate.
5317 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5318 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5319 (expose_window_tree): Likewise.
5320 Use contents slot, not buffer, where appropriate.
5321 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5322 to avoid deleted windows. Use contents slot instead of buffer.
5323 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5324 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5325 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5326 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5327
121ab1cd
EZ
53282013-03-28 Eli Zaretskii <eliz@gnu.org>
5329
ef454cf7
EZ
5330 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5331 identify the reasons for assertion violations in bug#14062 and
5332 similar ones.
21e930f8
EZ
5333 (Fx_show_tip): Fix compilation error under
5334 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5335
121ab1cd
EZ
5336 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5337 Reported by <rzl24ozi@gmail.com>.
5338
5c89ca24
DA
53392013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5340
5341 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5342 start marker...
562c6ee9
SM
5343 (unwind_with_echo_area_buffer): ...to restore it here.
5344 This is needed to ensure that...
5c89ca24
DA
5345 (redisplay_window): ...both window markers are valid here,
5346 which is verified by eassert.
5347 * editfns.c (save_excursion_save): Do not assume that
5348 selected_window always displays the buffer.
c7f53895
DA
5349 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5350 Fix comment.
5c89ca24 5351
f557c1b1
SM
53522013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5353
5354 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5355 the upcase table.
5356
40693bba 53572013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5358
5359 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5360
c86f791f
EZ
53612013-03-27 Eli Zaretskii <eliz@gnu.org>
5362
5363 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5364 since MinGW's w32api headers do. This avoids compiler warnings.
5365
5366 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5367 if already defined.
5368
c6e72e17
EZ
53692013-03-26 Eli Zaretskii <eliz@gnu.org>
5370
5371 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5372
54e95010
JD
53732013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5374
5375 * gtkutil.c (style_changed_cb): Check if frame is live and an
5376 X frame (Bug#14038).
5377
b88b62de
EZ
53782013-03-26 Eli Zaretskii <eliz@gnu.org>
5379
a18d7de6
EZ
5380 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5381 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5382 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5383 MinGW64.
8f5e14c8
EZ
5384 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5385 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5386
b88b62de
EZ
5387 Fix incompatibilities between MinGW.org and MinGW64 headers.
5388 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5389
5390 * w32.c (REPARSE_DATA_BUFFER): Guard with
5391 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5392
c074e458
JD
53932013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5394
5395 * xterm.c: Include X11/XKBlib.h
5396 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5397
908589fd
AS
53982013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5399
5400 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5401 written backwards.
5402 * blockinput.h (input_blocked_p): Likewise.
5403 * bytecode.c (exec_byte_code): Likewise.
5404 * callproc.c (call_process_kill, call_process_cleanup)
5405 (Fcall_process): Likewise.
5406 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5407 (Fccl_execute_on_string): Likewise.
5408 * character.c (string_escape_byte8): Likewise.
5409 * charset.c (read_hex): Likewise.
5410 * cm.c (calccost): Likewise.
5411 * data.c (cons_to_unsigned): Likewise.
5412 * dired.c (directory_files_internal, file_name_completion):
5413 Likewise.
5414 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5415 (sit_for): Likewise.
5416 * doc.c (Fsubstitute_command_keys): Likewise.
5417 * doprnt.c (doprnt): Likewise.
5418 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5419 * emacsgtkfixed.c: Likewise.
5420 * fileio.c (file_offset, Fwrite_region): Likewise.
5421 * floatfns.c (Fexpt, fmod_float): Likewise.
5422 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5423 Likewise.
5424 * font.c (font_intern_prop): Likewise.
5425 * frame.c (x_set_alpha): Likewise.
5426 * gtkutil.c (get_utf8_string): Likewise.
5427 * indent.c (check_display_width): Likewise.
5428 * intervals.c (create_root_interval, rotate_right, rotate_left)
5429 (split_interval_right, split_interval_left)
5430 (adjust_intervals_for_insertion, delete_node)
5431 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5432 (merge_interval_right, merge_interval_left, copy_intervals)
5433 (set_intervals_multibyte_1): Likewise.
5434 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5435 * keymap.c (Fkey_description): Likewise.
5436 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5437 * lread.c (openp, read_integer, read1, string_to_number):
5438 Likewise.
5439 * menu.c (ensure_menu_items): Likewise.
5440 * minibuf.c (read_minibuf_noninteractive): Likewise.
5441 * print.c (printchar, strout): Likewise.
5442 * process.c (create_process, Faccept_process_output)
5443 (wait_reading_process_output, read_process_output, send_process)
5444 (wait_reading_process_output): Likewise.
5445 * profiler.c (make_log, handle_profiler_signal): Likewise.
5446 * regex.c (re_exec): Likewise.
5447 * regex.h: Likewise.
5448 * search.c (looking_at_1, Freplace_match): Likewise.
5449 * sysdep.c (get_child_status, procfs_ttyname)
5450 (procfs_get_total_memory): Likewise.
5451 * systime.h (EMACS_TIME_VALID_P): Likewise.
5452 * term.c (dissociate_if_controlling_tty): Likewise.
5453 * window.c (get_phys_cursor_glyph): Likewise.
5454 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5455 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5456 Likewise.
5457 * xfns.c (Fx_window_property): Likewise.
5458 * xmenu.c (set_frame_menubar): Likewise.
5459 * xselect.c (x_get_window_property, x_handle_dnd_message):
5460 Likewise.
5461 * xsmfns.c (smc_save_yourself_CB): Likewise.
5462 * xterm.c (x_scroll_bar_set_handle): Likewise.
5463
2bf7d27a
DA
54642013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5465
5466 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5467 to be optional or nil. Adjust comment and convert it to docstring.
5468 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5469 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5470
a9ebfa0b
PE
54712013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5472
5473 Static checking by GCC 4.8-20130319.
5474 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5475 * process.c (Fset_process_datagram_address)
5476 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5477 * xdisp.c (get_char_face_and_encoding):
5478 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5479 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5480 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5481
4f3576ee
KB
54822013-03-24 Ken Brown <kbrown@cornell.edu>
5483
789b5e9a
KB
5484 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5485 fix compilation on 64-bit Cygwin, where underscores are not
5486 automatically prepended.
5487
4f3576ee
KB
5488 * w32term.c (w32_initialize): Silence compiler warning.
5489
b5b7745f
EZ
54902013-03-23 Eli Zaretskii <eliz@gnu.org>
5491
cdc0d0bd
EZ
5492 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5493 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5494 variables, to save and restore frame dimensions.
5495 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5496 after returning from a 'fullscreen' configuration.
5497 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5498 to avoid races between the main thread and the input thread.
5499
5500 * w32term.h (struct w32_output): New members normal_width,
5501 normal_height, normal_top, normal_left, and prev_fsmode.
5502 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5503 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5504 members of a frame.
5505
b5b7745f
EZ
5506 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5507 'fullscreen' parameter. Always record previous width and height
5508 of the frame, except when switching out of maximized modes, so
5509 that they could be restored correctly, instead of resetting to the
5510 default frame dimensions. Send SC_RESTORE command to the frame,
5511 unless we are going to send SC_MAXIMIZE, to restore the frame
5512 resize hints in the mouse pointer shown by the window manager.
5513 (Bug#14032)
5514
5515 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5516
5517 * lisp.h (get_frame_param): Adjust conditions for prototype
5518 declaration.
5519
a3454eed
KB
55202013-03-22 Ken Brown <kbrown@cornell.edu>
5521
5522 * unexcw.c: Drop unneeded inclusion of w32common.h.
5523 (report_sheap_usage): Declare.
5524 (read_exe_header): Add magic numbers for x86_64.
5525 (fixup_executable): Fix printf format specifier for unsigned long
5526 argument.
5527
5a49b79c
DA
55282013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5529
5530 * frame.h (struct frame): Put menu_bar_window under #ifdef
5531 because this member is not needed when X toolkit is in use.
5532 (fset_menu_bar_window):
5533 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5534 (free_glyphs, update_frame):
5535 * xdisp.c (expose_frame): Likewise.
5536 (display_menu_bar): Likewise. Remove redundant eassert.
5537 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5538 toolkit is in use.
5539
d6723bf7
PE
55402013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5541
7b1123d8
PE
5542 Use functions and constants to manipulate Lisp_Save_Value objects.
5543 This replaces code that used macros and strings and token-pasting.
5544 The change makes the C source a bit easier to follow,
5545 and shrinks the Emacs executable a bit.
5546 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5547 (make_save_value): Change 1st arg from string to enum. All callers
5548 changed.
5549 (INTX): Remove.
5550 (mark_object): Use if, not #if, for GC_MARK_STACK.
5551 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5552 (XSAVE_OBJECT): Now functions, not macros.
5553 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5554 the constant was never used.
5555 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5556 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5557 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5558 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5559 New constants.
5560 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5561 type3 with a single member save_type. All uses changed.
5562 (save_type, set_save_pointer, set_save_integer): New functions.
5563 * print.c (PRINTX): Remove.
5564
d6723bf7
PE
5565 * alloc.c: Remove redundant static declarations.
5566
5f24fa51
DA
55672013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5568
5569 * window.h (struct window): Convert left_col, top_line, total_lines
5570 and total_cols from Lisp_Objects to integers. Adjust comments.
5571 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5572 Remove.
5573 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5574 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5575 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5576 Adjust users where appropriate.
5577
42143acd
DA
55782013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5579
5580 * frame.h (struct frame): Drop resx and resy because the same data is
5581 available from window system-specific output context. Adjust users.
562c6ee9
SM
5582 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5583 New functions to provide defaults when no window system available.
42143acd 5584 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5585 (NUMVAL): Move from xdisp.c.
42143acd
DA
5586 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5587 (Ffont_face_attributes, Fopen_font):
5588 * image.c (gs_load):
5589 * w32font.c (fill_in_logfont):
5590 * xdisp.c (calc_pixel_width_or_height):
5591 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5592 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5593
c0a17406
KH
55942013-03-20 Kenichi Handa <handa@gnu.org>
5595
5596 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5597 to 1 (temporary workaround until a bug related to ASCII
5598 optimization is fixed).
5599
095d384d
DA
56002013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5601
5602 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5603 Signal error if window is not internal. Adjust docstring.
5604 (delete_all_child_windows): Use combination_limit to save the buffer.
5605 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5606 * print.c (syms_of_print): Initialize debugging output not here...
5607 (init_print_once): ...but in a new function here.
5608 * lisp.h (init_print_once): Add prototype.
5609 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5610
748fa866
DA
56112013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5612
5613 * window.c (window_resize_check, window_resize_apply)
5614 (window_from_coordinates, recombine_windows, set_window_buffer)
5615 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5616 (Fsplit_window_internal, Fdelete_window_internal)
5617 (freeze_window_starts): Use bool for booleans.
5618 * window.h (window_frame_coordinates, resize_frame_windows)
5619 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5620
81519fd2
SM
56212013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5622
5623 * dispnew.c (bitch_at_user): Use `user-error'.
5624
6db423a9
KB
56252013-03-17 Ken Brown <kbrown@cornell.edu>
5626
5627 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5628 as return type of image_background. (Bug#13981)
5629 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5630
8f2906f5
JD
56312013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5632
960ce480 5633 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5634 (ns_select): Don't return with result uninitialized.
960ce480 5635
8f2906f5
JD
5636 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5637 and getDirectory.
5638
81519fd2
SM
5639 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5640 New functions.
8f2906f5
JD
5641 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5642 directories. If filename is nil, get directory name (Bug#13932).
5643 Use getFilename and getDirectory.
5644 (getFilename, getDirectory): New methods for EmacsSavePanel and
5645 EmacsOpenPanel.
5646 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5647
cded56c1
PE
56482013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5649
5650 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5651
251e9147 56522013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5653
5654 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5655 (adjust_after_replace): Make it back to static. Delete the third
5656 arg text_at_gap_tail. Cancel the code for handling it.
5657
5658 * coding.h (struct coding_system): New member eol_seen.
5659
5660 * coding.c (detect_ascii): New function.
5661 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5662 when the source bytes are actually scanned. On detecting for
5663 coding_category_utf_8_auto, call detect_ascii instead of scanning
5664 source bytes directly.
5665 (produce_chars): Call insert_from_gap with the new arg 0.
5666 (encode_coding): Likewise.
5667 (decode_coding_gap): Control ASCII optimization by the variable
5668 disable_ascii_optimization instead of #ifndef .. #endif.
5669 Deccode EOL format according to coding->eol_seen.
5670 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5671 variable.
5672
8a44e6d1
KH
5673 * lisp.h (adjust_after_replace): Cancel externing it.
5674 (insert_from_gap): Adjust prototype.
5675
5f795e34
EZ
56762013-03-15 Eli Zaretskii <eliz@gnu.org>
5677
5678 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5679 FULLSCREEN_MAXIMIZED. (Bug#13935)
5680
f258b4be
DA
56812013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5682
5683 * region-cache.c (find_cache_boundary, move_cache_gap)
5684 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5685 Simplify debugging check and convert to eassert. Adjust comment.
5686 (pp_cache): Put under ENABLE_CHECKING.
5687
a5cc4dde
EZ
56882013-03-14 Eli Zaretskii <eliz@gnu.org>
5689
5690 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5691 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5692 and WM_ACTIVATEAPP.
5693 (w32fullscreen_hook): If the frame is visible, reset
5694 f->want_fullscreen flag after changing the frame size. If the
5695 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5696 (Bug#13953)
5697
3fc5e44a
DC
56982013-03-13 Daniel Colascione <dancol@dancol.org>
5699
5700 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5701 too so that these builds can use Cygwin's file conversion
5702 functions. (We've been building and linking cygw32.o all along
5703 and just not using it.)
5704
47d7532e
PE
57052013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5706
5707 File synchronization fixes (Bug#13944).
5708 * Makefile.in (LIB_FDATASYNC): New macro.
5709 (LIBES): Use it.
5710 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5711 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5712 Don't worry about HAVE_FSYNC, since a substitute fsync is
5713 available if the system lacks one.
5714 (Fwrite_regin): Retry fsync if interrupted.
5715
c7ffccaf
EZ
57162013-03-13 Eli Zaretskii <eliz@gnu.org>
5717
4e2df81d 5718 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5719 activated, call w32fullscreen_hook, to make sure the new frame
5720 dimensions are in effect. (Bug#13937)
5721
8a7debc1
DA
57222013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5723
5724 * xdisp.c (init_iterator): Simplify because both character and byte
5725 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5726 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5727 character and byte positions can be obtained from marker.
8a7debc1 5728
7fd8c501
PE
57292013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5730
d9df6f40
PE
5731 Static checking by Sun C 5.12.
5732 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5733 * bytecode.c (exec_byte_code):
5734 * dispnew.c (init_display):
5735 * eval.c (error):
5736 * fileio.c (Fsubstitute_in_file_name):
5737 * keyboard.c (Fevent_convert_list):
5738 * keymap.c (Fsingle_key_description):
5739 * term.c (maybe_fatal, fatal):
5740 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5741 * xsmfns.c (Fhandle_save_session):
5742 Omit unreachable code.
5743 * keymap.c (map_keymap_char_table_item): Cast void * to
5744 a function pointer type; the C Standard requires this.
5745
7fd8c501
PE
5746 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5747 Include <sys/param.h> unconditionally, as that works elsewhere and
5748 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5749 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5750 and FreeBSD now.
5751
a020afb9 5752See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5753
5754;; Local Variables:
5755;; coding: utf-8
aac0c6e3
MR
5756;; End:
5757
ab422c4d 5758 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5759
5760 This file is part of GNU Emacs.
5761
5762 GNU Emacs is free software: you can redistribute it and/or modify
5763 it under the terms of the GNU General Public License as published by
5764 the Free Software Foundation, either version 3 of the License, or
5765 (at your option) any later version.
5766
5767 GNU Emacs is distributed in the hope that it will be useful,
5768 but WITHOUT ANY WARRANTY; without even the implied warranty of
5769 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5770 GNU General Public License for more details.
5771
5772 You should have received a copy of the GNU General Public License
5773 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.