Merge from gnulib.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
deb31e75
DA
12013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
4 (imagemagick_prune_animation_cache): Now static.
5
319a4d03
LMI
62013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
7
8 * image.c (imagemagick_get_animation_cache): Don't segfault when
9 pruning all entries.
10
f747d82e
KB
112013-08-18 Ken Brown <kbrown@cornell.edu>
12
13 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
14 static heap if ENABLE_CHECKING is defined.
15 (max_bss_sbrk_ptr): New variable.
16 (bss_sbrk): Use it.
17 (report_sheap_usage): Report maximum static heap usage instead of
18 ending static heap usage.
19
d2c28fab
EZ
202013-08-17 Eli Zaretskii <eliz@gnu.org>
21
22 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
23 of zlib_initialized according to the results of calling
24 init_zlib_functions.
25
274ff63f
LMI
262013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
27
28 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 29 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
30 (imagemagick_load_image): Remove the ping_wand code, which only
31 apparently saved time on invalid animated images, and slowed down
32 everything else. Optimise for the common case.
274ff63f 33
2bede2ed
XF
342013-08-16 Xue Fuqiao <xfq.free@gmail.com>
35
70ff8240
XF
36 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
37
de179a3e
XF
38 * editfns.c (insert_before_markers): Mention overlay in the doc string.
39
2bede2ed
XF
40 * marker.c (set_marker): Remove documentation of undefined behavior.
41
703dbeba
LMI
422013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
43
44 * image.c (imagemagick_compute_animated_image): Animate correctly
45 when sub-images are smaller than the main image.
1d18b1e6
LMI
46 (imagemagick_compute_animated_image): Setting the iterator row to
47 zero is apparently not allowed.
79670014
LMI
48 (imagemagick_compute_animated_image): Allow images that say they
49 have sub-images that are bigger than the main image, but just crop
50 them.
703dbeba 51
63216c5e
JD
522013-08-15 Jan Djärv <jan.h.d@swipnet.se>
53
54 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
55
a5b5f73f
LMI
562013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
57
58 * image.c (imagemagick_compute_animated_image): Respect the GIF
59 disposal methods.
60
0fe73012
KB
612013-08-15 Ken Brown <kbrown@cornell.edu>
62
63 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
64 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
65 needed.
66
691a357f
PE
672013-08-15 Paul Eggert <eggert@cs.ucla.edu>
68
69 Fix minor problems found by static checking.
70 * frame.c (delete_frame):
71 * xdisp.c (next_element_from_display_vector):
72 Avoid uninitialized local.
73 * image.c (imagemagick_compute_animated_image): Port to C89.
74 Prefer usual GNU indentation style for loops.
75 Be more careful about bizarrely large sizes, by using ptrdiff_t
76 instead of int.
77
42fe2e88
DA
782013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
79
80 Fix infinite frame selection loop (Bug#15025).
81 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
82
d39a3da6
EZ
832013-08-15 Eli Zaretskii <eliz@gnu.org>
84
85 * xdisp.c (compute_window_start_on_continuation_line): When
86 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
87 to make sure we end up setting the window start at the leftmost
88 visible character of the display line. This avoids funky
89 horizontal shifting because the window start is not kept on the
90 same position. (Bug#15090)
05426239
EZ
91 (next_element_from_display_vector): Support 'box' face attribute
92 in the face definitions of a display vector. (Bug#15099)
d39a3da6 93
6e856b69
LMI
942013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
95
96 * image.c (imagemagick_compute_animated_image): Implement animated
97 images (bug#14700).
995be755
LMI
98 (imagemagick_compute_animated_image): Fix some compilation
99 warnings. Implement a very simple cache to make the animation
100 usable at all, but it should be replaced with a per-image cache.
6e856b69 101
d5a1acfa
DA
1022013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
103
104 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
105 to do `for' loops over alist values.
106 * buffer.h (FOR_EACH_BUFFER):
107 * process.c (FOR_EACH_PROCESS): Use it.
108 (handle_child_signal, status_notify, Fget_buffer_process)
109 (kill_buffer_processes): Use FOR_EACH_PROCESS.
110
9c253307
DA
1112013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
112
113 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
114 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
115 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
116 to xzalloc and so avoid redundant call to memset.
117 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
118 members because it is allocated with xzalloc and so already zeroed.
119
05e64f9f
KB
1202013-08-14 Ken Brown <kbrown@cornell.edu>
121
122 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
123 (Bug#15094).
124
5b71542d
DA
1252013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
126
127 Utility function and macro to copy Lisp string to C string.
128 * lisp.h (xlispstrdupa): New macro.
129 (xlispstrdup): New prototype.
130 * alloc.c (xlispstrdup): New function.
131 * callint.c (Fcall_interactively):
132 * fileio.c (Ffile_name_directory, Fexpand_file_name)
133 (Fsubstitute_in_file_name):
134 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
135 * image.c (x_create_bitmap_from_file):
136 * w32term.c (w32_term_init):
137 * xterm.c (x_term_init): Use xlispstrdup.
138
71530c97
LMI
1392013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
140
4ce82fb8
LMI
141 * image.c (imagemagick_load_image): Make animated pictures work.
142 There's still some problems with background color settings, though
143 (bug#14700).
144
71530c97
LMI
145 * decompress.c (unwind_decompress): Always restore point.
146
7510a061
XF
1472013-08-14 Xue Fuqiao <xfq.free@gmail.com>
148
149 * marker.c (set_marker): Reformat documentation.
150
01c3051f
PE
1512013-08-14 Paul Eggert <eggert@cs.ucla.edu>
152
aab1fcdf
PE
153 * xdisp.c (cursor_type_changed): Now static.
154
01c3051f
PE
155 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
156 Use changed. This avoids the need to call xmalloc and for the
157 caller to call xfree, and avoids memory leaks in some situations.
158
2084152a
DA
1592013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
160
161 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
162 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
163 (redisplay_window): If window_end_valid is cleared due to non-zero
164 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
165 so do not call to try_cursor_movement for that window.
2084152a 166
02455cb6
DA
1672013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
168
169 * window.h (struct window): Convert window_end_pos and
170 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
171 (wset_window_end_pos, wset_window_end_vpos): Remove.
172 * dispnew.c (adjust_glyph_matrix):
173 * window.c (Fwindow_end, replace_window, set_window_buffer)
174 (make_window):
175 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
176 (set_vertical_scroll_bar, redisplay_window, try_window)
177 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
178 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
179 (note_mouse_highlight): Adjust users.
180 (try_cursor_movement): Likewise. Convert old precondition to eassert.
181 Add comment.
182
da5707e8
DA
1832013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
184
185 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
186 * image.c (imagemagick_filename_hint): Use `const char *' and
187 prefer SSDATA to SDATA to avoid warnings.
188
25554267
DA
1892013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Cleanup window fringes, margins and scroll bars adjustments.
192 * window.c (set_window_fringes, set_window_margins)
193 (set_window_scroll_bars, apply_window_adjustment): New functions.
194 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
195 (Fset_window_scroll_bars): Use them.
196
38a2c910
DA
1972013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
198
199 * window.h (struct window): Convert scroll_bar_width
200 from Lisp_Object to integer. Adjust comment.
201 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
202 Adjust users.
203 * window.c (wset_scroll_bar_width): Remove.
204 (make_window): Initialize scroll_bar_width.
205 (Fsplit_window_internal): Use direct assignment.
206 (Fset_window_configuration, save_window_save):
207 Convert Lisp_Object to integer and back where appropriate.
208 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
209 bar was actually changed, and mention this in docstring.
210
2d065031
PE
2112013-08-13 Paul Eggert <eggert@cs.ucla.edu>
212
213 * decompress.c: Minor simplifications.
214 (Fzlib_decompress_region): Don't bother verifying
215 that avail_out <= UINT_MAX, as that was confusing.
216 Mention the restriction in a comment instead.
217 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
218
a5bd5abb
JD
2192013-08-13 Jan Djärv <jan.h.d@swipnet.se>
220
221 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
222 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
223
66e7901a
LMI
2242013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
225
226 * image.c (imagemagick_filename_hint): Check for errors in the
227 alist structure.
228
2fa611b7
EZ
2292013-08-13 Eli Zaretskii <eliz@gnu.org>
230
231 * window.c (Fwindow_margins): Return nil when there's no marginal
232 area, as per the documented API.
233
234 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
235 Fmake_vector, as scroll bar's struct members are not all Lisp
236 objects now. This avoids crashes in GC.
237
238 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
239 bool, so its address could be taken.
240
8259030d
LMI
2412013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
242
243 * image.c (imagemagick_filename_hint): New function to possibly
244 apply `image-content-type-suffixes'.
245 (imagemagick_load_image): Use it.
246
866c710e
EZ
2472013-08-13 Eli Zaretskii <eliz@gnu.org>
248
249 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
250 if loading zlib failed.
251
f10490f0
JD
2522013-08-13 Jan Djärv <jan.h.d@swipnet.se>
253
96311be7
JD
254 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
255 2013-08-13 checkin below. Change bool to BOOL, rule is:
256 All Obj-C code uses BOOL, except for interfaces callable from C.
257
f10490f0
JD
258 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
259
c8ae93b0
DA
2602013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
261
262 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
263 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
264 bool instead of BOOL.
265 * w32term.h (struct scroll_bar): Convert fringe_extended_p
266 from Lisp_Object to bitfield. Adjust comment.
267 * w32term.c (x_scroll_bar_create): Adjust user.
268 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
269 * xterm.c (XTset_vertical_scroll_bar): Likewise.
270 Use bool for boolean.
271 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
272 to `unsigned int' when defining a bitfield.
273
53b64418
PE
2742013-08-13 Paul Eggert <eggert@cs.ucla.edu>
275
276 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
277
eeaf9bf3
DA
2782013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
279
280 * window.h (struct window): Convert left_margin_cols and
281 right_margin_cols from Lisp_Objects to integers. Adjust comment.
282 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
283 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
284 Adjust users.
285 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
286 Adjust comment.
287 (showing_window_margins_p, update_window_line, update_frame_1):
288 * fringe.c (draw_fringe_bitmap_1):
289 * xdisp.c (window_box_width): Adjust users.
290 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
291 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
292 Use direct assignment.
293 (Fset_window_configuration, save_window_save, Fwindow_margins):
294 Convert Lisp_Object to integer and back where appropriate.
295 (Fset_window_margins): Adjust user. Return t if any margin
296 was actually changed, and mention this in docstring.
297
956720af
XF
2982013-08-13 Xue Fuqiao <xfq.free@gmail.com>
299
f73f4ce6 300 * syntax.c (forward_word):
956720af
XF
301 * cmds.c (forward_char, backward_char): Mention the optional argument.
302
9e37ee3b
DA
3032013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
304
305 * window.h (struct window): Convert left_fringe_width
306 and right_fringe_width from Lisp_Objects to integers.
307 Adjust comment.
308 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
309 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
310 * window.c (wset_left_fringe_width, wset_right_fringe_width):
311 Remove.
312 (make_window): Initialize new integer fields to -1.
313 (Fsplit_window_internal): Use direct assignment.
314 (Fset_window_configuration, save_window_save): Convert
315 Lisp_Object to integer and back where appropriate.
316 (Fset_window_fringes): Adjust user. Return t if any fringe
317 was actually changed, and mention this in docstring.
318
e4375ca7
DA
3192013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
320
321 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
322 * nsfns.m (x_set_cursor_type):
323 * w32fns.c (x_set_cursor_type):
324 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
325 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 326
a45543bc
DA
3272013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
328
329 * font.c (clear_font_cache): New function, stripped from...
330 (Fclear_font_cache): ...here, which now uses the function
331 above. Adjust comment.
332 * font.h (clear_font_cache): Add prototype.
333 * xfaces.c (clear_face_cache): Use clear_font_cache.
334
ae966a86
DA
3352013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
336
337 * window.c (Fset_window_start): Compare `w', not `window' because
338 `w' might not be equal to `window' after call to decode_live_window.
339
297a545b
PE
3402013-08-12 Paul Eggert <eggert@cs.ucla.edu>
341
342 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
343 This fixes a problem introduced by the Bug#15035 patch
344 when using GPG. Reported by Herbert J. Skuhra.
345
aa942e2b
EZ
3462013-08-12 Eli Zaretskii <eliz@gnu.org>
347
348 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
349 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
350 not yet initialized.
351
7699d09e
LMI
3522013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
353
354 * decompress.c (Fzlib_decompress_region): Support zlib
355 decompression, too, and rename.
356
1d238bc7
PE
3572013-08-12 Paul Eggert <eggert@cs.ucla.edu>
358
359 Minor zlib configuration tweaks.
360 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
361 Don't assume presence of fn_inflateInit2_ zlib internal function.
362
8a44a184
LMI
3632013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
364
365 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
366 include the zlib prefix.
367
594a4307
EZ
3682013-08-12 Eli Zaretskii <eliz@gnu.org>
369
370 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
371 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
372 define static variables that are pointers to zlib functions to be
373 dynamically loaded.
374 (init_zlib_functions) [WINDOWSNT]: New function.
375 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
376 New macros.
377 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
378 macros instead of invoking the zlib functions directly.
379 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
380 Szlib_available_p.
381
d2e113bc
DA
3822013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
383
384 Avoid looping over all frame windows to freeze and unfreeze.
385 * window.h (struct window): Drop frozen_window_start_p.
386 (freeze_window_starts): Drop prototype.
387 * frame.h (struct frame): New frozen_window_starts flag.
388 (FRAME_WINDOWS_FROZEN): New macro.
389 * window.c (freeze_window_start, freeze_window_starts):
390 Remove.
391 (select_window, replace_window): Adjust users.
392 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
393 (window_frozen_p): New function.
394 (redisplay_window): Use it.
395
94fcd171
PE
3962013-08-12 Paul Eggert <eggert@cs.ucla.edu>
397
398 Fix some fd issues when running subprocesses (Bug#15035).
399 Fix bugs that can leak files or file descriptors on errors.
400 Don't unlink open temp files, as that's hard for users to diagnose
401 when things go awry (e.g., temp disk exhausted).
402 Don't bother to lock temp files. Check for invalid recursion.
403 * callproc.c (synch_process_fd): Remove. All uses removed.
404 (synch_process_tempfile): New var or macro.
405 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
406 New constants.
407 (record_kill_process): New arg, the temp name. All callers changed.
408 (delete_temp_file): Now just a simple wrapper around unlink.
409 (call_process_kill): New arg, the call_process_fd array.
410 Close them all. Clear synch_process_pid. Remove the temp file,
411 or arrange for it to be removed.
412 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
413 that's been moved to synch_process_tempfile. Caller changed.
414 Do not remove the tempfile; that's now call_process_kill's
415 responsibility.
416 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
417 call_process_kill; the caller now does that.
418 (call_process_cleanup): Do not close the process fd; that's now
419 call_process_kill's responsibility.
420 (Fcall_process): Implement via new function call_process, which
421 has most of the old body of Fcall_process, but with a different API.
422 (call_process): New function that does not open or close filefd if
423 it is nonnegative. Record which fds need to be closed, and let
424 call_process_kill close (and remove the tempfile, on MSDOS) on error.
425 Signal an error if invoked recursively (could be done via a hook).
426 Simplify creation of the tempfile in the MSDOS case.
427 Don't create the output file until after checking for the executable.
428 Report any failure to open /dev/null.
429 Don't open /dev/null for writing twice; once is enough.
430 Don't create pipe if all output is being discarded or sent to file.
431 Don't worry about setting up the coding system or reading from the
432 pipe if all output is being discarded.
433 Hoist fd_error local into top level, to lessen block nesting.
434 Don't record deleted pid here; now done by Fcall_process_region.
435 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
436 and note its success in synch_process_tempfile.
437 Do not leak resources when child_setup fails.
438 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
439 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
440 (create_temp_file): Now returns open fd, with an additional
441 Lisp_Object * argument to return the name. All callers changed.
442 Do not close the file; rewind it instead, and leave it open for
443 the caller. Do not lock the temp file. Unwind-protect the file
444 and the file-descriptor.
445 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
446 If an asynchrounous process, record it here, not in call_process.
447 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
448 * eval.c (set_unwind_protect): New function.
449 * fileio.c (write_region): New function, generalized from the
450 old Fwrite_region. Do not lock temp files.
451 (Fwrite_region): Use it.
452 * lisp.h (set_unwind_protect, write_region): New decls.
453 * process.c: Include <verify.h>.
454 (make_process): Mark fds as initially closed.
455 (deleted_pid_list): Now a list of pid-filename pairs.
456 All uses changed.
457 (close_process_fd): New function.
458 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
459 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
460 New constants. Verify that their number matches PROCESS_OPEN_FDS.
461 (create_process, create_pty, Fmake_serial_process)
462 (server_accept_connection): Record which fds need to be closed,
463 and let deactivate_process close them.
464 (Fmake_network_process): Do not discard the unwind-protect
465 until it's safe to do so.
466 (deactivate_process): Close the fds opened by create_process etc.
467 (Fprocess_send_eof): Adjust to new way of recording open fds.
468 Report an error if /dev/null can't be opened, instead of aborting.
469 * process.h (PROCESS_OPEN_FDS): New constant.
470 (struct Lisp_Process): New member open_fds.
471 (record_kill_process, record_deleted_pid): Adjust signatures.
472 (record_deleted_pid): Move decl here ...
473 * syswait.h (record_deleted_pid): ... from here.
474
d0e615c3
PE
4752013-08-11 Paul Eggert <eggert@cs.ucla.edu>
476
477 * decompress.c: Fix bugs with large buffers and weird inputs.
478 Tune a bit. Reindent as per usual Emacs style.
479 (BUFFER_SIZE): Remove.
480 (Fdecompress_gzipped_region): Do not mishandle input buffers with
481 more than UINT_MAX bytes. Decompress into the gap instead of into
482 an auto buffer, as this should avoid copying. Return nil if
483 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
484 set immediate_quit; we shouldn't trust zlib code that much.
485
313546eb
LMI
4862013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
487
99a32242
LMI
488 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
489 errors, and really move the gap to where we want it.
490
313546eb
LMI
491 * lisp.h: Include decompress.c support.
492
493 * emacs.c (main): Include decompress.c support.
494
495 * Makefile.in: Include -lz if present.
496
d2d699ac
JD
4972013-08-11 Jan Djärv <jan.h.d@swipnet.se>
498
f90e3ebd
JD
499 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
500 (initWithTitle:): Initialize frame to 0.
501 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
502 (fillWithWidgetValue:frame:): Renamed from
503 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
504
505 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
506 fillWithWidgetValue:frame:
507
423d3b3f
JD
508 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
509 remove memory leak warnings.
510
d2d699ac
JD
511 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
512 (ns_check_menu_open): Handle menu == nil. Remove assignment to
513 menu_pending_title.
514
515 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
516 (x_activate_menubar): Update the whole menu.
517 (trackingNotification:): Call ns_check_menu_open if tracking ends.
518 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
519 current event is not NSSystemDefined (Bug#15001).
520 Call ns_check_menu_open only if trackingMenu is 2.
521 (menuDidClose:): New method, decrease trackingMenu.
522 (fillWithWidgetValue:setDelegate:): New method.
523 (fillWithWidgetValue:): Call the above.
524
525 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
526
7d652d97
PE
5272013-08-11 Paul Eggert <eggert@cs.ucla.edu>
528
529 Omit some unnecessary casts.
530 Many of these go back to the old pre-C89 days, when they may have
531 been needed, but we've been assuming C89 or later for a while now.
532 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
533 (live_float_p, live_misc_p, live_vector_p):
534 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
535 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
536 (defvar_per_buffer):
537 * callint.c (Fcall_interactively):
538 * doc.c (Fsubstitute_command_keys):
539 * filelock.c (get_boot_time):
540 * frame.c (xrdb_get_resource):
541 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
542 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
543 (xg_get_file_name_from_selector, menuitem_destroy_callback)
544 (menuitem_highlight_callback, menu_destroy_callback)
545 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
546 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
547 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
548 (xg_tool_bar_help_callback, tb_size_cb):
549 * image.c (xpm_alloc_color, png_read_from_memory)
550 (png_read_from_file, png_load_body, our_memory_skip_input_data)
551 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
552 (syms_of_image):
553 * keymap.c (describe_map):
554 * nsfns.m (Fns_display_monitor_attributes_list):
555 * nsmenu.m (process_dialog:):
556 * nsterm.m (hold_event):
557 * process.c (wait_reading_process_output):
558 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
559 * scroll.c (do_direct_scrolling, scrolling_1):
560 * termcap.c (tgetent):
561 * window.c (check_window_containing, add_window_to_list)
562 (freeze_window_starts):
563 * xdisp.c (compare_overlay_entries, vmessage):
564 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
565 (x_get_monitor_attributes_xrandr)
566 (Fx_display_monitor_attributes_list, x_display_info_for_name)
567 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
568 * xfont.c (xfont_match, xfont_open):
569 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
570 (menubar_selection_callback, menu_position_func)
571 (popup_selection_callback, create_and_show_popup_menu)
572 (dialog_selection_callback, create_and_show_dialog):
573 * xrdb.c (x_get_string_resource):
574 (main) [TESTRM]:
575 * xsmfns.c (x_session_check_input):
576 * xterm.c (x_draw_glyphless_glyph_string_foreground)
577 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
578 (xaw_jump_callback, xaw_scroll_callback):
579 Omit unnecessary casts.
580
9acc1074
PE
5812013-08-10 Paul Eggert <eggert@cs.ucla.edu>
582
583 Minor string-length refactoring.
584 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
585 * frame.c (make_monitor_attribute_list):
586 Prefer build_string to strlen + make_string.
587
361c0eb8
JD
5882013-08-10 Jan Djärv <jan.h.d@swipnet.se>
589
590 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
591 don't check minor_code (Bug#14417).
592
14ba0822
EZ
5932013-08-09 Eli Zaretskii <eliz@gnu.org>
594
595 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
596 vertical positions instead. This avoids calling MATRIX_ROW with
597 row numbers that are possibly beyond valid limits. (Bug#15064)
598
309f24d1
DA
5992013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Use xstrdup and build_unibyte_string where applicable.
602 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
603 * xfns.c (x_window):
604 * xrdb.c (x_get_customization_string):
605 * xterm.c (xim_initialize):
606 * w32fns.c (w32_window): Use xstrdup.
607 (w32_display_monitor_attributes_list):
608 * emacs.c (init_cmdargs):
609 * keyboard.c (PUSH_C_STR):
610 * nsfont.m (nsfont_open):
611 * sysdep.c (system_process_attributes):
612 * w32.c (system_process_attributes):
613 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
614
55902276
EZ
6152013-08-09 Eli Zaretskii <eliz@gnu.org>
616
617 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
618 variables of these types so that GDB would know about them, as aid
619 for debugging fatal exceptions. (Bug#15024) See also
620 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
621 discussions.
622
10bf7f5a
JD
6232013-08-08 Jan Djärv <jan.h.d@swipnet.se>
624
625 * nsterm.m (ns_update_begin): Don't change clip path if it would be
626 larger than the NSWindow (Bug#14934).
627
65620264
DA
6282013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
629
630 Redesign redisplay interface to drop global variable updated_window.
631 Always pass currently updated window as a parameter to update routines.
632 * dispextern.h (updated_window): Remove declaration.
633 (struct redisplay_interface): Pass window parameter to
634 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
635 and after_update_window_hook.
636 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
637 Adjust prototypes.
638 * dispnew.c (updated_window): Remove.
639 (redraw_overlapped_rows, update_marginal_area, update_text_area)
640 (update_window_line): Adjust to match redisplay interface changes.
641 * nsterm.m (ns_update_window_begin, ns_update_window_end)
642 (ns_scroll_run, ns_after_update_window_line):
643 * w32term.c (x_update_window_begin, x_update_window_end)
644 (x_after_update_window_line, x_scroll_run):
645 * xterm.c (x_update_window_begin, x_update_window_end)
646 (x_after_update_window_line, x_scroll_run):
647 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
648 Likewise. Adjust comments where appropriate.
649 (x_cursor_to): Simplify because this is always called during window
650 update (but install debugging check anyway).
651 (expose_window): Check must_be_updated_p flag to see whether this
652 function is called during window update.
653
628fdc56
DA
6542013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
655
656 Do not reset window modification event counters excessively.
657 These leftovers and poor man's tricky methods to catch extra
658 redisplay's attention are no longer needed.
659 * frame.c (set_menu_bar_lines_1):
660 * minibuf.c (read_minibuf_unwind):
661 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
662 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
663 (window_scroll_line_based, Fset_window_configuration):
664 * xdisp.c (redisplay_window): Do not reset last_modified and
665 last_overlay_modified counters.
666
8fd9c92e
JD
6672013-08-07 Jan Djärv <jan.h.d@swipnet.se>
668
669 * xselect.c (x_send_client_event): Set send_event and serial, memset
670 data.l as it might be bigger than data.b. Use 24 bit mask to
671 XSendEvent (Bug#15034).
672
0ee18172
EZ
6732013-08-07 Eli Zaretskii <eliz@gnu.org>
674
675 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
676 for TTY frames that are not the top frame on their console.
677 (Bug#14616)
678
16ddd1a6
MR
6792013-08-07 Martin Rudalics <rudalics@gmx.at>
680
681 * w32term.c (w32fullscreen_hook): Really maximize frame when
682 asked for (Bug#14841).
683
d2a95ffb
DA
6842013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
685
686 Prefer selected_window to Fselected_window, likewise for frames.
687 * buffer.c (Fbuffer_swap_text):
688 * data.c (Fvariable_binding_locus):
689 * window.c (run_window_configuration_change_hook): Adjust users.
690 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
691 Use decode_live_frame.
692
170da1ec
DA
6932013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
694
695 Be more careful if selected window shows the buffer other than current,
696 use window_outdated only if this is not so. This change should also
697 address some weird issues discussed in Bug#13012.
698 * window.h (window_outdated): New prototype.
699 * window.c (window_outdated): Now here. Convert from static and
700 always assume window's buffer.
701 (Fwindow_end, Fwindow_line_height): Use it.
702 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
703 and always assume window's buffer.
704 (redisplay_window): Adjust user.
e5eefe9b 705 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
706 check whether mode line should be updated only if selected window
707 shows current buffer.
708 (run_window_scroll_functions): Use eassert for debugging check.
709 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
710
56b5d5b1
DA
7112013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
712
713 * window.c (window_scroll, window_scroll_pixel_based)
714 (window_scroll_line_based): Use bool for booleans.
715
2878ba7e
PE
7162013-08-06 Paul Eggert <eggert@cs.ucla.edu>
717
718 * process.c: Fix minor off-by-one issues in descriptor counts.
719 This shouldn't fix any real bugs, but it cleans up the code a bit.
720 (max_process_desc, max_input_desc): -1, not 0, means none.
721 All uses changed.
722 (delete_input_desc): New function.
723 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
724 (deactivate_process): Scan backwards when recomuting max_process_desc;
725 that should be faster.
726 (init_process_emacs): Initialize max_input_desc.
727
e30b79c1
DA
7282013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Use region cache to speedup bidi_find_paragraph_start.
731 * buffer.h (struct buffer): New member bidi_paragraph_cache.
732 Rename cache_long_line_scans to cache_long_scans.
733 * buffer.c (bset_cache_long_line_scans): Rename to
734 bset_cache_long_scans.
735 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
736 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
737 into account.
738 (syms_of_buffer): Rename cache-long-line-scans to
739 cache-long-scans. Adjust docstring.
740 * search.c (newline_cache_on_off):
741 * indent.c (width_run_cache_on_off): Adjust users.
742 * bidi.c (bidi_paragraph_cache_on_off): New function.
743 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
744 * insdel.c (prepare_to_modify_buffer): Invalidate
745 bidi_paragraph_cache if enabled.
746
00012b86
DA
7472013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
748
749 Invalidate region caches only if buffer text is going to be changed.
750 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
751 (modify_text): ...new prototype.
752 (prepare_to_modify_buffer_1): New prototype.
753 * textprop.c (modify_region): Rename to...
754 (modify_text_properties): ...new function.
755 (add_text_properties_1, set_text_properties, Fremove_text_properties)
756 (Fremove_list_of_text_properties): Adjust users.
757 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
758 (modify_text): ...new function.
759 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
760 (prepare_to_modify_buffer_1): ...new function.
761 * casefiddle.c (casify_region):
762 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
763 (Ftranspose_regions): Use modify_text.
764
dc6c0eda
SM
7652013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
766
767 * lisp.mk (lisp): Add nadvice.elc.
768
8f3a2c26
DA
7692013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
770
771 New macro to iterate over live buffers similar to frames.
772 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
773 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
774 Declare buffer-related variables here to offload lisp.h.
775 * buffer.c (Vbuffer_alist): Adjust comment.
776 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
777 (other_buffer_safely):
778 * data.c (store_symval_forwarding):
779 * dispnew.c (Fframe_or_buffer_changed_p):
780 * fileio.c (Fdo_auto_save):
781 * filelock.c (unlock_all_files):
782 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
783
e0fdb694
PE
7842013-08-04 Paul Eggert <eggert@cs.ucla.edu>
785
786 Fix some minor races in hosts lacking mkostemp (Bug#15015).
787 * callproc.c (create_temp_file):
788 * filelock.c (create_lock_file):
789 Assume mkostemp, since it's now provided by Gnulib.
790
63f5c6c2
EZ
7912013-08-04 Eli Zaretskii <eliz@gnu.org>
792
793 * w32.c (mkostemp): New function.
794 (mktemp): Remove, no longer used. Most of the code reused in
795 mkostemp. (Bug#15015)
484ab239 796 (mktemp): Don't undef.
63f5c6c2 797
f0b79313
DA
7982013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
799
800 * dispnew.c (glyph_matrix_count, glyph_pool_count):
801 Move under GLYPH_DEBUG and ENABLE_CHECKING.
802 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
803 (free_glyph_pool, check_glyph_memory): Likewise for
804 all users. Adjust comments where appropriate.
805
98f638d6
PE
8062013-08-03 Paul Eggert <eggert@cs.ucla.edu>
807
808 * composite.h: Minor fixups.
809 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
810 to fix a misspelling, and change it to an inline function while
811 we're at it (it need not be a macro). All uses changed.
812 (composition_method, composition_valid_p):
813 Rewrite to avoid assignments in if-conditions.
814
75c59fb3
DA
8152013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
816
817 Do not use global Lisp_Object in composition macros.
818 * composite.h (composition_temp): Remove declaration.
819 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
820 (composition_method, composition_valid_p): ...inline functions.
416a3e01 821 (compose_region): Remove the leftover.
75c59fb3
DA
822 * composite.c (composition_temp): Remove.
823 (run_composition_function, update_compositions)
824 (composition_compute_stop_pos, composition_adjust_point)
825 (Ffind_composition_internal):
826 * coding.c (handle_composition_annotation):
827 * xdisp.c (handle_composition_prop, check_point_in_composition):
828 Related users changed.
829
a10c8269
DA
8302013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
831
832 Drop FRAME_PTR typedef.
833 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
834 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
835 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
836 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
837 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
838 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
839 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
840 All related users changed.
841
a104f656
SM
8422013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * eval.c (default_toplevel_binding): New function.
845 (Fdefvar): Use it.
846 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
847 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
848 (syms_of_eval): Export them.
849 * data.c (Fdefault_value): Micro cleanup.
850 * term.c (init_tty): Use "false".
851
4b5c9326
DA
8522013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
853
854 Fix X GC leak in GTK and raw (no toolkit) X ports.
855 * xterm.c (x_free_frame_resources): If white and black relief
856 GCs are allocated, always free them here.
857 * xfns.c (x_make_gc): Omit redundant initialization.
858 * widget.c (create_frame_gcs): Remove the leftover.
859 (EmacsFrameDestroy): Do nothing because all GCs are now freed
860 in x_free_frame_resources.
861
b19aa636
JD
8622013-08-02 Jan Djärv <jan.h.d@swipnet.se>
863
864 * nsterm.m (windowWillResize:toSize:): Only change title if
865 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
866 modifying it.
867 (viewDidEndLiveResize): New method.
868
869 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
870 inside NS_IMPL_COCOA.
871
af1f7e06
DA
8722013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
873
874 * insdel.c (adjust_after_replace, replace_range, del_range_2):
875 Do not check whether undo is enabled because record_insert and
876 record_delete does that themselves.
877
65b02bb9
DA
8782013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
879
880 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
881 member which is not really used any more.
882 (FRAME_XIC_BASE_FONTNAME): Remove.
883 * xfns.c (xic_free_fontset): Adjust user.
884 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
885 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
886 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
887 (xdialog_show): Use eassert for debugging check.
7ee0f047 888 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 889
6318cde0
PE
8902013-08-01 Paul Eggert <eggert@cs.ucla.edu>
891
892 * fileio.c, fns.c (merge): Move extern decl from here ...
893 * lisp.h (merge): ... to here.
894
6c1a09ba
DA
8952013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
896
897 Fix last font-related change.
898 * w32font.h (w32font_list_internal, w32font_match_internal):
899 Fix prototype.
900 * w32uniscribe.c (uniscribe_list, uniscribe_match):
901 (uniscribe_list_family): Adjust to match font API change.
902 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
903 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
904
f8c20208
DA
9052013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
906
907 * frame.h (FRAME_MOUSE_UPDATE):
908 * nsterm.m (ns_frame_up_to_date): Omit redundant check
909 whether hlinfo->mouse_face_mouse_frame is non-NULL.
910
fdb396e2
DA
9112013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
912
913 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
914 * font.h (struct font_driver): Change list, match, and list_family
915 functions to accept struct frame * as first arg.
916 * font.c (font_score, font_compare, font_sort_entities): Remove
917 prototypes.
918 (font_sort_entities, font_list_entities, font_select_entity):
919 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
920 match font API change.
921 * xfont.c (xfont_list, xfont_match, xfont_list_family):
922 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
923 * ftxfont.c (ftxfont_list, ftxfont_match):
924 * xftfont.c (xftfont_list, xftfont_match):
925 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
926 * w32font.c (w32font_list, w32font_match, w32font_list):
927 (w32font_list_internal, w32_font_match_internal): Likewise.
928 * xfaces.c (Fx_family_fonts): Adjust user.
929
52b8a085
DA
9302013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
931
932 Do not use pure Xism x_wm_set_icon_position in non-X ports.
933 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
934 only if HAVE_X_WINDOWS is in use.
935 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
936 * nsterm.m (x_wm_set_icon_position): Remove no-op.
937 * w32term.c (x_wm_set_icon_position): Likewise.
938 * w32fns.c (x_icon): Adjust user.
939
c791c18e
DA
9402013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
941
942 * xterm.c (last_mouse_press_frame): Remove the
943 leftover which is not really used any more.
944 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
945 (x_flush): Call XFlush once per each X display, not frame.
946 This is better because this code always unconditionally skips
947 non-X frames in Vframe_list and issues the only XFlush if we
948 have more than one X frame on the same X display.
2f935d86
DA
949 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
950 Use bool for booleans.
951 (x_draw_glyph_string_background, cvt_string_to_pixel):
952 (cvt_pixel_dtor): Drop unnecessary prototypes.
953 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 954
f435830e
DA
9552013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
956
957 Drop unnecessary functions that deals with frame pixel size.
958 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
959 (x_pixel_height): Drop prototypes.
960 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
961 (x_pixel_height): Drop implementations.
962 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
963 which should be always valid for window frame.
964 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
965 * w32menu.c (Fx_popup_dialog):
966 * xmenu.c (Fx_popup_dialog): Likewise for both.
967
84231434
DA
9682013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
969
970 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
971 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
972 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
973 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
974 and mention nil frame in docstring.
84231434 975
959067a1
DA
9762013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
977
978 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
979 (x_figure_window_size): Likewise. Adjust to return long.
980 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
981 (toplevel): Move Qterminal_live_p to...
982 * terminal.c (toplevel): ...here, make it static, and...
983 (syms_of_terminal): ...DEFSYM here.
984 * frame.h (Qterminal_live_p): Remove declaration.
985 (make_frame, x_figure_window_size): Adjust prototype.
986 * nsfns.m (Fx_create_frame): Use long for window flags.
987
f4b169ce
PE
9882013-07-30 Paul Eggert <eggert@cs.ucla.edu>
989
990 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
991 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
992 Do not assume that emacs_close (INT_MAX) is a no-op.
993
bee6a2c7
DA
9942013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
995
996 * xfaces.c (make_face_cache): For struct face_cache, prefer
997 xmalloc to xzalloc and so avoid redundant call to memset.
998 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
999
d7e6881a
DA
10002013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1001
1002 * fringe.c (draw_window_fringes, update_window_fringes)
1003 (compute_fringe_widths):
1004 * w32term.c (x_draw_glyph_string):
1005 * window.c (candidate_window_p, Frecenter):
1006 * xfaces.c (realize_basic_faces, realize_default_face)
1007 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1008 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1009 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1010 * xmenu.c (Fx_menu_bar_open_internal):
1011 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1012 * xsettings.c (xft_settings_event):
1013 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1014 Use bool for booleans. Adjust style and comments where
1015 appropriate.
1016 * dispextern.h (draw_window_fringes, update_window_fringes)
1017 (compute_fringe_widths):
1018 * xterm.h (x_had_errors_p): Adjust prototype.
1019
ec3058af
DA
10202013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1021
1022 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1023 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1024
218e0637
DA
10252013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1026
1027 * fns.c (toplevel): Remove comment before Fsafe_length because
1028 it checks for QUIT.
1029
e560aba9
PE
10302013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1033
2e5ce5de
EZ
10342013-07-28 Eli Zaretskii <eliz@gnu.org>
1035
1036 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1037 frame which got the message is still alive, before dereferencing
1038 its pointer. (Bug#14970)
1039
1040 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1041 be a live window, before using it as such. (Bug#14970)
1042
e95da6d3
EZ
10432013-07-27 Eli Zaretskii <eliz@gnu.org>
1044
1045 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1046 w32_detect_focus_change instead of doing part of its job by hand.
1047 This fixes the problem whereby FOCUS_OUT events were not sent to
1048 the event queue.
1049
a8f93651
EZ
10502013-07-26 Eli Zaretskii <eliz@gnu.org>
1051
fec92060
EZ
1052 * process.c (Fprocess_list): Doc fix.
1053
a8f93651
EZ
1054 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1055 being re-exposed only if it didn't ask to become visible.
1056 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1057 was previously iconified. (Bug#14841)
1058 (x_iconify_frame): Mark the frame iconified.
1059
d5a7a9d9
PE
10602013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 Fix minor problems found by static checking.
1063 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1064 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1065
56ea7291
SM
10662013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1067
1068 * eval.c (set_specpdl_old_value): New function.
1069 (unbind_to): Minor simplification.
1070 (get_backtrace_frame): New function.
1071 (Fbacktrace_frame): Use it. Add `base' argument.
1072 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1073 (syms_of_eval): Export backtrace-eval.
1074 * xterm.c (x_focus_changed): Simplify.
1075
9d611ffe
PE
10762013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1079
999c74e3
EZ
10802013-07-24 Eli Zaretskii <eliz@gnu.org>
1081
1082 * xdisp.c (redisplay_window): Instead of moving point out of
1083 scroll margin, reject the force_start method, and try scrolling
1084 instead. (Bug#14780)
1085
198fa217
KB
10862013-07-24 Ken Brown <kbrown@cornell.edu>
1087
1088 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1089 (Bug#14944).
1090
53840e55
PE
10912013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 * eval.c (Fprogn): Do not check that BODY is a proper list.
1094 This undoes the previous change. The check slows down the
1095 interpreter, and is not needed to prevent a crash. See
1096 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1097
60967f56
GM
10982013-07-23 Glenn Morris <rgm@gnu.org>
1099
1100 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1101
9ca960e2
PE
11022013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1103
a29c3e6d
PE
1104 Port to GNU/Linux systems with tinfo but not ncurses.
1105 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1106 to decide whether ncurses is being used. Without this change,
1107 GCC complains about tgetent not being declared, on a system
1108 that has tinfo installed but ncurses not installed.
1109
f274311c
PE
1110 * eval.c (Fprogn): Check that BODY is a proper list.
1111
16b0520a
PE
1112 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1113 * data.c (Fsetq_default):
1114 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1115 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1116 (Fcondition_case):
1117 Tune by taking advantage of the fact that ARGS is always a list
1118 when a function is declared to have UNEVALLED args.
1119
9ca960e2
PE
1120 * emacsgtkfixed.c: Port to GCC 4.6.
1121 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1122
afacaa1b
JB
11232013-07-23 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1126 here to silence compiler warnings.
1127
368a85a4
PE
11282013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1131 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1132 from messing up Emacs's 'struct frame' (Bug#14923).
1133
f4e891b5
PE
11342013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 * alloc.c (make_save_ptr_ptr): Define this function.
1137 It was inadvertently omitted. It's needed only if
1138 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1139
96c8b65e
JD
11402013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1141
1142 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1143 frame have focus (Bug#14895).
1144
ee010797
PE
11452013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 Avoid vfork-related deadlock more cleanly.
1148 * callproc.c (child_setup): When the child's exec fails, output
1149 the program name, as that's more useful. Use O_NONBLOCK to avoid
1150 deadlock.
1151 * process.c (create_process_1): Remove; no longer needed.
1152 (create_process): Remove timer hack; no longer needed, now that
1153 the child avoids deadlock.
1154
f0398ec1 11552013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1156
1157 * image.c (Fimage_flush): Fix doc typo.
1158
b2a069c2
PE
11592013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1160
6496aec9
PE
1161 Fix array bounds violation when pty allocation fails.
1162 * process.c (PTY_NAME_SIZE): New constant.
1163 (pty_name): Remove static variable; it's now auto.
1164 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1165 Take pty_name as an arg rather than using a static variable.
1166 All callers changed.
1167 (create_process): Recover pty_flag from process, not from volatile local.
1168 (create_pty): Stay inside array even when pty allocation fails.
1169 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1170
b2a069c2
PE
1171 * lread.c (Fload): Avoid initialization only when lint checking.
1172 Mention that it's needed only for older GCCs.
1173
99107004
KH
11742013-07-20 Kenichi Handa <handa@gnu.org>
1175
1176 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1177 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1178
6b1b199d
AS
11792013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1180
1181 * lread.c (Fload): Avoid uninitialized warning.
1182
4195afc3
PE
11832013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1184
3f5bef16
PE
1185 Fix some minor file descriptor leaks and related glitches.
1186 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1187 (create_lock_file): Use write, not emacs_write.
1188 * image.c (slurp_file, png_load_body):
1189 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1190 (server_accept_connection):
1191 Don't leak an fd on memory allocation failure.
1192 * image.c (slurp_file): Add a cheap heuristic for growing files.
1193 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1194 as that's what the other routines do. Maybe input need not be
1195 blocked at all, but it's better to be consistent.
1196 Avoid undefined behavior when strlen is zero.
1197
4195afc3
PE
1198 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1199 (NSTATICS): Now a constant; doesn't need to be a macro.
1200
a1aeeffe
RS
12012013-07-19 Richard Stallman <rms@gnu.org>
1202
1203 * coding.c (decode_coding_utf_8): Add simple loop for fast
1204 processing of ASCII characters.
1205
63b34baa
PE
12062013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1209
621dd9ac
EZ
12102013-07-19 Eli Zaretskii <eliz@gnu.org>
1211
1212 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1213 unportable 'struct x_display_info'.
1214 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1215 is a portable type.
1216
1396ac86
PE
12172013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1218
ab9980cd
PE
1219 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1220 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1221 or fscanf fails.
1222 (system_process_attributes): Prefer plain char to unsigned char
1223 when either will do. Clean up properly if interrupted or if
1224 memory allocations fail. Don't assume sscanf succeeds. Remove
1225 no-longer-needed workaround to stop GCC from whining. Read
1226 command-line once, instead of multiple times. Check read status a
1227 bit more carefully.
1228
1396ac86
PE
1229 Fix obscure porting bug with varargs functions.
1230 The code assumed that int is treated like ptrdiff_t in a vararg
1231 function, which is not a portable assumption. There was a similar
1232 -- though these days less likely -- porting problem with various
1233 assumptions that pointers of different types all smell the same as
1234 far as vararg functions is conserved. To make this problem less
1235 likely in the future, redo the API to use varargs functions.
1236 * alloc.c (make_save_value): Remove this vararg function.
1237 All uses changed to ...
1238 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1239 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1240 New functions.
1241 (make_save_ptr): Rename from make_save_pointer, for consistency with
1242 the above. Define only on platforms that need it. All uses changed.
1243
4d19d194
PE
12442013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * keyboard.c: Try to fix typos in previous change.
1247 (DISPLAY_LIST_INFO): New macro.
1248 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1249 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1250
945c5bb1
JB
12512013-07-18 Juanma Barranquero <lekktu@gmail.com>
1252
1253 * keyboard.c (kbd_buffer_get_event):
1254 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1255 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1256
f4b1eb36
PE
12572013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1258
5e679a2c
PE
1259 * filelock.c: Fix unlikely file descriptor leaks.
1260 (get_boot_time_1): Rework to avoid using emacs_open.
1261 This doesn't actually fix a leak, but is better anyway.
1262 (read_lock_data): Use read, not emacs_read.
1263
a8cd4836
PE
1264 * doc.c: Fix minor memory and file descriptor leaks.
1265 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1266 (get_doc_string, Fsnarf_documentation):
1267 Fix file descriptor leak on error.
1268
ef30e638
PE
1269 * term.c: Fix minor fdopen-related file descriptor leaks.
1270 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1271 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1272
f4b1eb36
PE
1273 * charset.c: Fix file descriptor leaks and errno issues.
1274 Include <errno.h>.
1275 (load_charset_map_from_file): Don't leak file descriptor on error.
1276 Use plain record_xmalloc since the allocation is larger than
1277 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1278 of entries.
1279 * eval.c (record_unwind_protect_nothing):
1280 * fileio.c (fclose_unwind):
1281 New functions.
1282 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1283 The replacement doesn't block input, but that no longer seems
1284 necessary.
1285
b648c163
PE
12862013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1287
a0931322
PE
1288 * lread.c: Fix file descriptor leaks and errno issues.
1289 (Fload): Close some races that leaked fds or streams when 'load'
1290 was interrupted.
1291 (Fload, openp): Report error number of last nontrivial failure to open.
1292 ENOENT counts as trivial.
1293 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1294 New functions.
1295 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1296 now that the function is always called with a nonnegative arg.
1297 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1298 All uses replaced with ...
1299 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1300
b648c163
PE
1301 A few more minor file errno-reporting bugs.
1302 * callproc.c (Fcall_process):
1303 * doc.c (Fsnarf_documentation):
1304 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1305 * process.c (set_socket_option):
1306 Don't let a constructor trash errno.
1307 * doc.c: Include <errno.h>.
1308
b1dc4084
JB
13092013-07-16 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1312
c43843aa
PE
13132013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1314
50a30cce
PE
1315 Fix w32 bug with call-process-region (Bug#14885).
1316 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1317 to Fcall_process when the input is empty. This simplifies the
1318 code a bit. It makes no difference on POSIXish platforms but
1319 apparently it fixes a bug on w32.
1320
44e18199 1321 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1322 * fileio.c (close_file_unwind): Don't close if FD is negative;
1323 this can happen when unwinding a zapped file descriptor.
1324 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1325 in case Emacs runs out of memory between the two unwind-protects.
1326 Don't trash errno when closing FD.
1327 Zap the FD in the specpdl when closing it, instead of deferring
1328 the removal of the unwind-protect; this fixes a bug where a child
1329 function unwinds the stack past us.
1330
27e498e6
PE
1331 New unwind-protect flavors to better type-check C callbacks.
1332 This also lessens the need to write wrappers for callbacks,
1333 and the need for make_save_pointer.
1334 * alloca.c (free_save_value):
1335 * atimer.c (run_all_atimers):
1336 Now extern.
1337 * alloc.c (safe_alloca_unwind):
1338 * atimer.c (unwind_stop_other_atimers):
1339 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1340 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1341 * minibuf.c (choose_minibuf_frame_1):
1342 * process.c (make_serial_process_unwind):
1343 * xdisp.h (pop_message_unwind):
1344 * xselect.c (queue_selection_requests_unwind):
1345 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1346 * alloca.c (record_xmalloc):
1347 Prefer record_unwind_protect_ptr to record_unwind_protect with
1348 make_save_pointer.
1349 * alloca.c (Fgarbage_collect):
1350 Prefer record_unwind_protect_void to passing a dummy.
1351 * buffer.c (restore_buffer):
1352 * window.c (restore_window_configuration):
1353 * xfns.c, w32fns.c (do_unwind_create_frame)
1354 New wrapper. All record-unwind uses of wrappee changed.
1355 * buffer.c (set_buffer_if_live):
1356 * callproc.c (call_process_cleanup, delete_temp_file):
1357 * coding.c (code_conversion_restore):
1358 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1359 * editfns.c (save_excursion_restore)
1360 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1361 (save_restriction_restore):
1362 * eval.c (restore_stack_limits, un_autoload):
1363 * fns.c (require_unwind):
1364 * keyboard.c (recursive_edit_unwind, tracking_off):
1365 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1366 * macros.c (pop_kbd_macro, restore_menu_items):
1367 * nsfns.m (unwind_create_frame):
1368 * print.c (print_unwind):
1369 * process.c (start_process_unwind):
1370 * search.c (unwind_set_match_data):
1371 * window.c (select_window_norecord, select_frame_norecord):
1372 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1373 (fast_set_selected_frame):
1374 * xfns.c, w32fns.c (unwind_create_tip_frame):
1375 Return void, not a dummy Lisp_Object. All uses changed.
1376 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1377 * callproc.c (call_process_kill):
1378 * fileio.c (restore_point_unwind, decide_coding_unwind)
1379 (build_annotations_unwind):
1380 * insdel.c (Fcombine_after_change_execute_1):
1381 * keyboard.c (read_char_help_form_unwind):
1382 * menu.c (unuse_menu_items):
1383 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1384 * sound.c (sound_cleanup):
1385 * xdisp.c (unwind_redisplay):
1386 * xfns.c (clean_up_dialog):
1387 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1388 Accept no args and return void, instead of accepting and returning
1389 a dummy Lisp_Object. All uses changed.
1390 * cygw32.c (fchdir_unwind):
1391 * fileio.c (close_file_unwind):
1392 * keyboard.c (restore_kboard_configuration):
1393 * lread.c (readevalllop_1):
1394 * process.c (wait_reading_process_output_unwind):
1395 Accept int and return void, rather than accepting an Emacs integer
1396 and returning a dummy object. In some cases this fixes an
1397 unlikely bug when the corresponding int is outside Emacs integer
1398 range. All uses changed.
1399 * dired.c (directory_files_internal_unwind):
1400 * fileio.c (do_auto_save_unwind):
1401 * gtkutil.c (pop_down_dialog):
1402 * insdel.c (reset_var_on_error):
1403 * lread.c (load_unwind):
1404 * xfns.c (clean_up_file_dialog):
1405 * xmenu.c, nsmenu.m (pop_down_menu):
1406 * xmenu.c (cleanup_widget_value_tree):
1407 * xselect.c (wait_for_property_change_unwind):
1408 Accept pointer and return void, rather than accepting an Emacs
1409 save value encapsulating the pointer and returning a dummy object.
1410 All uses changed.
1411 * editfns.c (Fformat): Update the saved pointer directly via
1412 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1413 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1414 (unwind_body): New function.
1415 (record_unwind_protect): First arg is now a function returning void,
1416 not a dummy Lisp_Object.
1417 (record_unwind_protect_ptr, record_unwind_protect_int)
1418 (record_unwind_protect_void): New functions.
1419 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1420 * fileio.c (struct auto_save_unwind): New type.
1421 (do_auto_save_unwind): Use it.
1422 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1423 * insdel.c (struct rvoe_arg): New type.
1424 (reset_var_on_error): Use it.
1425 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1426 New constants.
1427 (specbinding_func): Remove; there are now several such functions.
1428 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1429 (set_unwind_protect_ptr): New function.
1430 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1431
4e604a5d
PE
1432 Be simpler and more consistent about reporting I/O errors.
1433 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1434 Say "Read error" and "Write error", rather than "I/O error", or
1435 "IO error reading", or "IO error writing", when a read or write
1436 error occurs.
1437 * process.c (Fmake_network_process, wait_reading_process_output)
1438 (send_process, Fprocess_send_eof, wait_reading_process_output):
1439 Capitalize diagnostics consistently. Put "failed foo" at the
1440 start of the diagnostic, so that we don't capitalize the
1441 function name "foo". Consistently say "failed" for such
1442 diagnostics.
1443 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1444 All callers changed. This is so it can use report_file_error.
1445 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1446 diagnostics consistently as above.
1447
a9757f6a
PE
1448 * fileio.c (report_file_errno): Fix errno reporting bug.
1449 If the file name is neither null nor a pair, package it up as a
1450 singleton list. All callers changed, both to this function and to
1451 report_file_error. This fixes a bug where the memory allocator
1452 invoked by list1 set errno so that the immediately following
1453 report_file_error reported the wrong errno value.
1454
c43843aa
PE
1455 Fix minor problems found by --enable-gcc-warnings.
1456 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1457 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1458
18c26d81
JD
14592013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1460
1461 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1462 Set event->arg to Qt if switch-event shall be generated.
1463 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1464
1465 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1466
1467 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1468 FOCUS_OUT_EVENT.
1469
1470 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1471 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1472 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1473 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1474 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1475 and there is a focused frame.
1476 (head_table): Add focus-in and focus-out.
1477 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1478 bind to handle-focus-in/out.
1479
1480 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1481 (Fhandle_switch_frame): Call Fhandle_focus_in.
1482 (syms_of_frame): defsubr handle-focus-in/out.
1483
6c6f1994
PE
14842013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1485
c7ddc792
PE
1486 Fix porting bug to older POSIXish platforms (Bug#14862).
1487 * sysdep.c (emacs_pipe): New function, that implements
1488 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1489 This should port better to CentOS 5 and to Mac OS X 10.6.
1490 All calls to pipe2 changed.
1491
6c6f1994
PE
1492 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1493 This makes the code easier to read and the executable a bit smaller.
1494 Do not replace all calls to Fcons that happen to create lists,
1495 just calls that are intended to create lists. For example, when
1496 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1497 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1498 Similarly for list2 through list5.
1499 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1500 * bytecode.c (exec_byte_code):
1501 * callint.c (quotify_arg, Fcall_interactively):
1502 * callproc.c (Fcall_process, create_temp_file):
1503 * charset.c (load_charset_map_from_file)
1504 (Fdefine_charset_internal, init_charset):
1505 * coding.c (get_translation_table, detect_coding_system)
1506 (Fcheck_coding_systems_region)
1507 (Fset_terminal_coding_system_internal)
1508 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1509 * composite.c (update_compositions, Ffind_composition_internal):
1510 * dired.c (directory_files_internal, file_name_completion)
1511 (Fsystem_users):
1512 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1513 * doc.c (Fsnarf_documentation):
1514 * editfns.c (Fmessage_box):
1515 * emacs.c (main):
1516 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1517 (Feval, eval_sub, Ffuncall, apply_lambda):
1518 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1519 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1520 (Fset_file_times, Finsert_file_contents)
1521 (Fchoose_write_coding_system, Fwrite_region):
1522 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1523 * font.c (font_registry_charsets, font_parse_fcname)
1524 (font_prepare_cache, font_update_drivers, Flist_fonts):
1525 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1526 * frame.c (make_frame, Fmake_terminal_frame)
1527 (x_set_frame_parameters, x_report_frame_params)
1528 (x_default_parameter, Fx_parse_geometry):
1529 * ftfont.c (syms_of_ftfont):
1530 * image.c (gif_load):
1531 * keyboard.c (command_loop_1):
1532 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1533 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1534 (Fminor_mode_key_binding, accessible_keymaps_1)
1535 (Faccessible_keymaps, Fwhere_is_internal):
1536 * lread.c (read_emacs_mule_char):
1537 * menu.c (find_and_return_menu_selection):
1538 * minibuf.c (get_minibuffer):
1539 * nsfns.m (Fns_perform_service):
1540 * nsfont.m (ns_script_to_charset):
1541 * nsmenu.m (ns_popup_dialog):
1542 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1543 (Fx_own_selection_internal):
1544 * nsterm.m (append2):
1545 * print.c (Fredirect_debugging_output)
1546 (print_prune_string_charset):
1547 * process.c (Fdelete_process, Fprocess_contact)
1548 (Fformat_network_address, set_socket_option)
1549 (read_and_dispose_of_process_output, write_queue_push)
1550 (send_process, exec_sentinel):
1551 * sound.c (Fplay_sound_internal):
1552 * textprop.c (validate_plist, add_properties)
1553 (Fput_text_property, Fadd_face_text_property)
1554 (copy_text_properties, text_property_list, syms_of_textprop):
1555 * unexaix.c (report_error):
1556 * unexcoff.c (report_error):
1557 * unexsol.c (unexec):
1558 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1559 (Fformat_mode_line, syms_of_xdisp):
1560 * xfaces.c (set_font_frame_param)
1561 (Finternal_lisp_face_attribute_values)
1562 (Finternal_merge_in_global_face, syms_of_xfaces):
1563 * xfns.c (x_default_scroll_bar_color_parameter)
1564 (x_default_font_parameter, x_create_tip_frame):
1565 * xfont.c (xfont_supported_scripts):
1566 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1567 (menu_help_callback, xmenu_show):
1568 * xml.c (make_dom):
1569 * xterm.c (set_wm_state):
1570 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1571 and similarly for list2 through list5.
1572
bafe80ce
PE
15732013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 * callproc.c (Fcall_process_region): Fix minor race and tune.
1576 (create_temp_file): New function, with the temp-file-creation part
1577 of the old Fcall_process_region. Use Fcopy_sequence to create the
1578 temp file name, rather than alloca + build_string, for simplicity.
1579 Don't bother to block input around the temp file creation;
1580 shouldn't be needed. Simplify use of mktemp. Use
1581 record_unwind_protect immediately after creating the temp file;
1582 this closes an unlikely race where the temp file was not removed.
1583 Use memcpy rather than an open-coded loop.
1584 (Fcall_process_region): Use the new function. If the input is
1585 empty, redirect from /dev/null rather than from a newly created
1586 empty temp file; this avoids unnecessary file system traffic.
1587
4700b5a5
PE
15882013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1589
5c97beae
PE
1590 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1591 Simplify by making this case like the other two. This is a bit
1592 slower on obsolete hosts, but the extra complexity isn't worth it.
1593
4700b5a5
PE
1594 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1595 * process.c (create_process) [!DOS_NT]:
1596 Remove now-unnecessary calls to emacs_close.
1597
f9a74c4c
EZ
15982013-07-13 Eli Zaretskii <eliz@gnu.org>
1599
922ae7ee
EZ
1600 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1601 returning early. (Bug#14850)
1602
f9a74c4c
EZ
1603 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1604 and inhibit-iso-escape-detection attributes of 'undecided'.
1605 (Bug#14822)
1606
5e301d76
PE
16072013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1608
69e0e5ee
PE
1609 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1610 Reported by Herbert J. Skuhra in
1611 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1612
5e301d76
PE
1613 Don't lose top specpdl entry when memory is exhausted.
1614 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1615 specpdl overflow here, to simplify callers; all callers changed.
1616 Always reserve an unused entry at the stack top; this avoids
1617 losing the top entry's information when memory is exhausted.
1618
7e649856
PE
16192013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1620
a773ed9a
PE
1621 Clean up errno reporting and fix some errno-reporting bugs.
1622 * callproc.c (Fcall_process):
1623 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1624 * process.c (create_process, Fmake_network_process):
1625 * unexaix.c (report_error):
1626 * unexcoff.c (report_error):
1627 Be more careful about reporting the errno of failed operations.
1628 The code previously reported the wrong errno sometimes.
1629 Also, prefer report_file_errno to setting errno + report_file_error.
1630 (Fcall_process): Look at openp return value rather than at path,
1631 as that's a bit faster and clearer when there's a numeric predicate.
1632 * fileio.c (report_file_errno): New function, with most of the
1633 old contents of report_file_error.
1634 (report_file_error): Use it.
1635 (Ffile_exists_p, Ffile_accessible_directory_p):
1636 Set errno to 0 when it is junk.
1637 * fileio.c (Faccess_file):
1638 * image.c (x_create_bitmap_from_file):
1639 Use faccessat rather than opening the file, to avoid the hassle of
1640 having a file descriptor open.
1641 * lisp.h (report_file_errno): New decl.
1642 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1643
7e649856
PE
1644 Minor EBADF fixes.
1645 * process.c (create_process, wait_reading_process_output) [AIX]:
1646 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1647 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1648 a multithreaded environment anyway).
1649 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1650
f6774c1a
AS
16512013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1652
1653 * image.c (x_find_image_file): Don't close a remote file handle.
1654
bacba3c2
PE
16552013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 Fix races with threads and file descriptors.
1658 * callproc.c (Fcall_process_region):
1659 * dired.c (open_directory):
1660 * emacs.c (main, Fdaemon_initialized):
1661 * image.c (x_find_image_file):
1662 * inotify.c (Finotify_rm_watch):
1663 * lread.c (Flocate_file_internal):
1664 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1665 * term.c (term_mouse_moveto, init_tty):
1666 * termcap.c (tgetent):
1667 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1668 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1669 * unexhp9k800.c, unexmacosx.c (unexec):
1670 * callproc.c (Fcall_process_region):
1671 Use emacs_close, not close.
1672 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1673 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1674 and posix_close function on current platforms (which all lack them).
1675 (emacs_close): Use it. This should fix the races on GNU/Linux and
1676 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1677 and it should avoid closing random victim file descriptors on
1678 other platforms.
1679
653d4f43
PE
16802013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1681
c8536ec4
PE
1682 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1683 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1684 Touch up doc a bit.
1685
9c203066
PE
1686 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1687 This is for .gdbinit xbacktrace.
1688
653d4f43
PE
1689 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1690 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1691 (emacs_set_tty): Now static.
1692 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1693 * term.c (tty_capable_p, tty_default_color_capabilities)
1694 (get_tty_terminal, term_mouse_movement)
1695 (handle_one_term_event, init_tty, maybe_fatal):
1696 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1697 (tgetent, scan_file, name_match, compare_contin):
1698 * terminal.c (get_terminal):
1699 Use bool for boolean.
1700 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1701 Prefer char to unsigned char if either will do.
1702 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1703 (tty_write_glyphs): Prefer int to unsigned.
1704 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1705 All callers changed.
1706 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1707
45b683a1
PE
17082013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1709
29abe551
PE
1710 Port to C89.
1711 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1712 (B__dummy__): New dummy symbol, to pacify C89.
1713 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1714 they can't grok varargs macros.
1715 * dispnew.c (add_window_display_history)
1716 (add_frame_display_history):
1717 * print.c (print_object):
1718 * xdisp.c (debug_method_add):
1719 Use %p printf format only for void pointers.
1720 * emacs.c (usage_message): New constant, replacing ...
1721 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1722 (main): Adjust to usage reorg.
1723 * fns.c (syms_of_fns):
1724 * profiler.c (syms_of_profiler):
1725 Don't use non-constant struct initializers.
1726 * gnutls.h (gnutls_initstage_t):
1727 * lisp.h (enum Lisp_Fwd_Type):
1728 * lread.c (lisp_file_lexically_bound_p):
1729 * xsettings.c (anonymous enum):
1730 Remove trailing comma.
1731 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1732 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1733 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1734 (DEFUN): Use it.
1735 * regex.c (const_re_char): New type, to pacify strict C89.
1736 All uses of 'const re_char' replaced to use it.
1737 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1738 with glibc when strict C89. This change is imported from gnulib.
1739 All uses changed.
1740 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1741 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1742 Omit GNU_LINUX implementation, since it requires long long.
1743 * xterm.c (x_draw_underwave):
1744 Do not assume the traditional order of struct's members.
1745 (x_term_init): Rewrite to avoid the need for non-constant structure
1746 initializers.
1747
45b683a1 1748 Syntax cleanup, mostly replacing macros with functions.
763a086d 1749 This removes the need for the syntax_temp hack.
45b683a1
PE
1750 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1751 * syntax.c (SYNTAX_INLINE): New macro.
1752 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1753 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1754 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1755 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1756 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1757 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1758 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1759 Now constants, not macros.
1760 (syntax_temp) [!__GNUC__]: Remove.
1761 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1762 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1763 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1764 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1765 Move here from syntax.h; now functions, not macros. Except for the
1766 last function, these are static since only syntax.c uses them.
1767 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1768 All uses changed. Now a function, not a macro; use this fact
1769 to simplify the code.
1770 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1771 compiler bugs; no longer relevant.
1772 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1773 (SYNTAX_INLINE): New macro.
1774 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1775 for the new functions. Use bool for boolean member.
1776 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1777 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1778 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1779 (SETUP_BUFFER_SYNTAX_TABLE):
1780 Now extern inline functions, not macros.
1781 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1782 Remove; all uses replaced by implementation.
1783 (syntax_temp) [!__GNUC__]: Remove decl.
1784 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1785
29be4a50
JD
17862013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1787
1788 * emacs.c (main): Fix syntax error.
1789
954b166e
PE
17902013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1791
1792 Timestamp fixes for undo (Bug#14824).
1793 * atimer.c (schedule_atimer):
1794 * fileio.c (Ffile_newer_than_file_p):
1795 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1796 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1797 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1798 (syms_of_fileio): Remove Sclear_visited_file_name.
1799 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1800 file doesn't exist; this avoids an ambiguity with negative timestamps.
1801 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1802 * systime.h (make_emacs_time, invalid_emacs_time):
1803 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1804 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1805 * undo.c (record_first_change): Push (visited-file-modtime) onto
1806 undo list rather than reimplementing it by hand, incorrectly.
1807
d74647c3
KB
18082013-07-09 Ken Brown <kbrown@cornell.edu>
1809
1810 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1811
3c51b96b
JB
18122013-07-09 Juanma Barranquero <lekktu@gmail.com>
1813
1814 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1815
4ebbdd67
PE
18162013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1817
1818 Handle errno and exit status a bit more carefully.
1819 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1820 number into an exit status. Instead, use EXIT_CANCELED.
1821 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1822 * callproc.c (relocate_fd):
1823 * emacs.c (close_output_streams, main):
1824 * process.c (create_process):
1825 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1826 Use emacs_perror for simplicity.
1827 * callproc.c (relocate_fd, main):
1828 * sysdep.c (sys_subshell):
1829 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1830 (shut_down_emacs): Use emacs_write, not write.
1831 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1832 * fileio.c (Fcopy_file, e_write):
1833 * nsterm.m (ns_select):
1834 * process.c (send_process):
1835 * sound.c (vox_write):
1836 Use emacs_write_sig, not emacs_write.
1837 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1838 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1839 New constants.
1840 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1841 of write.
1842 (emacs_full_write): New function.
1843 (emacs_write): Rewrite to use it.
1844 (emacswrite_sig, emacs_perror): New functions.
1845 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1846
44e18199 18472013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1848
1849 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1850 on NS even if it is present. Pixmap on NS is a void*.
1851
9caab067
PE
18522013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 Port to Ubuntu 10 (Bug#14803).
1855 Problem reported by T.V. Raman.
1856 * process.c (close_on_exec, accept4, process_socket):
1857 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1858
1d442672
EZ
18592013-07-07 Eli Zaretskii <eliz@gnu.org>
1860
1861 * w32.c (sys_dup): Declare prototype.
1862
1863 * filelock.c:
1864 * emacs.c:
1865 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1866
067428c1
PE
18672013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 Make file descriptors close-on-exec when possible (Bug#14803).
1870 This simplifies Emacs a bit, since it no longer needs to worry
1871 about closing file descriptors by hand in some cases.
1872 It also fixes some unlikely races. Not all such races, as
1873 libraries often open files internally without setting
1874 close-on-exec, but it's an improvement.
1875 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1876 * callproc.c (Fcall_process) [!MSDOS]:
1877 * emacs.c (main) [!DOS_NT]:
1878 * nsterm.m (ns_term_init):
1879 * process.c (create_process):
1880 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1881 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1882 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1883 Prefer mkostemp with O_CLOEXEC to mkstemp.
1884 * callproc.c (relocate_fd) [!WINDOWSNT]:
1885 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1886 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1887 now using pipe2.
1888 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1889 Make the resulting file descriptor close-on-exec.
1890 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1891 * lread.c (load_descriptor_list, load_descriptor_unwind):
1892 Remove; no longer needed. All uses removed.
1893 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1894 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1895 New functions.
1896 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1897 (Fmake_network_process, Fnetwork_interface_list):
1898 (Fnetwork_interface_info, server_accept_connection):
1899 Make newly-created socket close-on-exec.
1900 * sysdep.c (emacs_open, emacs_fopen):
1901 Make new-created descriptor close-on-exec.
1902 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1903 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1904
0da857dd
JD
19052013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1906
1907 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1908 for NS_IMPL_GNUSTEP.
1909
5f86adcd
PE
19102013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1911
1912 Fix openp errno handling.
1913 * callproc.c (Fcall_process): Preserve openp errno around close.
1914 * lread.c (openp): Set errno when returning -1, as some callers
1915 expect this.
1916
1afb1d07
JD
19172013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1918
1919 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1920
1921 * nsterm.h (NSSavePanel): Update comment.
1922 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1923 (ns_run_file_dialog): Declare.
1924
1925 * nsfns.m: Remove panelOK.
1926 (ns_fd_data): New.
1927 (ns_run_file_dialog): New function.
1928 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1929 event loop, so file dialog is popped up by ns_run_file_dialog, called
1930 by sendEvent (Bug#14578).
1931 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1932
3323c263
EZ
19332013-07-06 Eli Zaretskii <eliz@gnu.org>
1934
fdda0220
EZ
1935 * xdisp.c (default_line_pixel_height): New function.
1936 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1937 (try_cursor_movement, redisplay_window, try_window)
1938 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1939
1940 * window.c (window_scroll_pixel_based): use
1941 default_line_pixel_height.
1942
1943 * dispextern.h (default_line_pixel_height): Add prototype.
1944
1945 * frame.c (x_set_line_spacing): Accept a float value for
1946 line-spacing parameter, per the documentation.
1947
3323c263
EZ
1948 * data.c (Fmultibyte_string_p): Doc fix.
1949
47ba6d43
PE
19502013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1951
406af475
PE
1952 Use emacs_open more consistently when opening files.
1953 This handles EINTR more consistently now, and makes it easier
1954 to introduce other uniform changes to file descriptor handling.
1955 * src/systdio.h: New file.
1956 * src/buffer.c (mmap_init):
1957 * cygw32.c (chdir_to_default_directory):
1958 * dispnew.c (Fopen_termscript):
1959 * emacs.c (Fdaemon_initialized):
1960 * fileio.c (Fdo_auto_save):
1961 * image.c (slurp_file, png_load_body, jpeg_load_body):
1962 * keyboard.c (Fopen_dribble_file):
1963 * lread.c (Fload):
1964 * print.c (Fredirect_debugging_output):
1965 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1966 * termcap.c (tgetent):
1967 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1968 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1969 * w32term.c (w32_initialize) [CYGWIN]:
1970 * xfaces.c (Fx_load_color_file):
1971 Use emacs_open instead of plain open, and emacs_fopen instead of
1972 plain fopen.
1973 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1974 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1975 * callproc.c (default_output_mode): New constant.
1976 (Fcall_process): Use it to call emacs_open instead of plain creat.
1977 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1978 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1979 (emacs_fopen): New function.
1980 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1981 Include <lisp.h>, for emacs_open.
1982 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1983
47ba6d43
PE
1984 Remove duplicate #include directives.
1985 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1986 * xfaces.c:
1987 Don't include stdio.h twice.
1988 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1989 Don't include sys/types.h or stdio.h twice.
1990 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1991 * lread.c: Don't include coding.h twice.
1992 * nsfont.m: Don't include frame.h twice.
1993 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1994 * ralloc.c: Don't include <unistd.h> twice.
1995 * xdisp.c: Don't include font.h twice.
1996 * xterm.c: Don't include fontset.h twice.
1997 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1998
b9ed53d5
PE
19992013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 Scale ImageMagick images more carefully.
2002 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2003 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2004 Be more careful about avoiding undefined behavior after
2005 integer overflow and division by zero.
2006
cf13177e
YM
20072013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2008
2009 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2010 (syms_of_w32fns): DEFSYM them.
2011 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2012 (CCHDEVICENAME): Define macros if not defined.
2013 (struct MONITOR_INFO_EX): New struct.
2014 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2015 (enum_display_monitors_fn): New variable.
2016 (globals_of_w32fns): Initialize it.
2017 (Fx_display_pixel_width, Fx_display_pixel_height)
2018 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2019 multi-monitor setups in docstrings.
2020 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2021 screen size by primary monitor's millimeter per pixel.
2022 (w32_monitor_enum, w32_display_monitor_attributes_list)
2023 (w32_display_monitor_attributes_list_fallback)
2024 (Fw32_display_monitor_attributes_list): New functions.
2025 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2026
2027 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2028 if not defined.
2029 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2030
86dfb7a8
MA
20312013-07-04 Michael Albinus <michael.albinus@gmx.de>
2032
2033 * fileio.c (Qfile_notify_error): New error symbol.
2034
2035 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2036 * inotify.c (inotify_callback, symbol_to_inotifymask)
2037 (Finotify_add_watch, Finotify_rm_watch): Use it.
2038 (inotifyevent_to_event): Exchange order of cookie and file name.
2039 (Finotify_add_watch): Adapt docstring.
2040
2041 * lisp.h (Qfile_notify_error): Declare.
2042
2c1c974b
PE
20432013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2046 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2047 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2048 which did not work (see <http://bugs.gnu.org/14569#307>).
2049 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2050 && (!noninteractive || initialized)). This attempts to thread
2051 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2052
7a35b20f
JB
20532013-07-04 Juanma Barranquero <lekktu@gmail.com>
2054
2055 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2056 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2057
1ce5cd04
PE
20582013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2061 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2062 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2063 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2064
57f8c490
PE
20652013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2068 Define to __sys_siglist.
2069
bcffb5ca
EZ
20702013-07-02 Eli Zaretskii <eliz@gnu.org>
2071
2072 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2073 word-wrap, so that overflow-newline-into-fringe would work in
2074 visual-line-mode. (Bug#2749)
2075 (move_it_in_display_line_to): When the last scanned display
2076 element fits exactly on the display line, and
2077 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2078 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2079 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2080 finding buffer position that corresponds to pixel coordinates,
2081 e.g. in buffer_posn_from_coords.
2082
2c41e781
JD
20832013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2084
2085 * process.c (handle_child_signal): Call catch_child_signal if
2086 NS_IMPL_GNUSTEP.
2087
c2418359
PE
20882013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2089
52a9bcae
PE
2090 Don't convert function pointers to void * and back.
2091 It isn't portable C, and it's easy enough to avoid.
2092 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2093 (make_save_value): Add support for SAVE_FUNCPOINTER.
2094 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2095 * print.c (print_object):
2096 Distinguish function from object pointers.
2097 * lisp.h (SAVE_FUNCPOINTER): New constant.
2098 (SAVE_SLOT_BITS): Adjust to it.
2099 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2100 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2101 (voidfuncptr): New typedef.
2102 (struct Lisp_Save_Value): New member data[0].funcpointer.
2103 (XSAVE_FUNCPOINTER): New function.
2104
c2418359
PE
2105 Simplify buildobj processing.
2106 * Makefile.in (buildobj.h): Make it a sequence of strings each
2107 followed by comma, rather than a single string. Put it into a
2108 .tmp file in case there's an error while generating it.
2109 (gl-stamp): Use .tmp for temp files.
2110 (mostlyclean): Clean .tmp files.
2111 * doc.c (buildobj): Move to just the routine that needs it.
2112 It's now an array of strings, so processing is simpler.
2113
8f43ce49
PE
21142013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2117 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2118 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2119 Invoke malloc_enable_thread even when not interactive.
2120 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2121 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2122 in this case, since the underlying bug has now been fixed.
2123
24827db9
JB
21242013-07-01 Juanma Barranquero <lekktu@gmail.com>
2125
2126 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2127 unlinking it (bug#14691).
2128
ef099a94
MN
21292013-06-30 Michal Nazarewicz <mina86@mina86.com>
2130
2131 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2132 before checking whether buffer is modified. This lets
2133 `kill-buffer-query-functions' cancel killing of the buffer or save
2134 its content before `kill-buffer' asks user the "Buffer %s
2135 modified; kill anyway?" question.
2136
9d3f2fc2
JD
21372013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2138
2139 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2140 Let the super performKeyEquivalent deal with them (Bug#14747).
2141
e6c6c8c7
PE
21422013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2143
1d71c1d9
PE
2144 * widget.c (resize_cb): Remove unused local.
2145
8f5f35cc
PE
2146 Do not use GTK 3 if it exists but cannot be compiled.
2147 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2148 * xterm.c (x_error_handler) [!USE_GTK]:
2149 Do not use GTK 3.
2150
e6c6c8c7
PE
2151 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2152
0ba54312
EZ
21532013-06-30 Eli Zaretskii <eliz@gnu.org>
2154
5d1c3286
EZ
2155 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2156 to the valid range of values. (Bug#14753)
2157
0ba54312
EZ
2158 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2159 when moving point by using the current glyph matrix. This avoids
2160 the need to force redisplay when this function is called in a
2161 loop.
2162
9c90cc06
PE
21632013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 Fix minor problems found by static checking.
2166 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2167 Redo the latter's body to sidestep GCC parenthesization warnings.
2168 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2169 * coding.c (detect_coding, detect_coding_system):
2170 * coding.h (struct undecided_spec):
2171 Use bool for boolean.
2172 * image.c (QCmax_width, QCmax_height): Now static.
2173 * xdisp.c (Fmove_point_visually): Remove unused local.
2174
4c672a0f
EZ
21752013-06-29 Eli Zaretskii <eliz@gnu.org>
2176
2177 * xdisp.c (Fmove_point_visually): New function.
2178
c1ea3abf
JB
21792013-06-28 Kenichi Handa <handa@gnu.org>
2180
2181 * coding.h (define_coding_undecided_arg_index): New enum.
2182 (coding_attr_index): New members
2183 coding_attr_undecided_inhibit_null_byte_detection,
2184 coding_attr_undecided_inhibit_iso_escape_detection,
2185 coding_attr_undecided_prefer_utf_8.
2186 (undecided_spec): New struct.
2187 (struct coding_system): New member `undecided' of the member
2188 `spec'.
2189
2190 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2191 (detect_coding): Likewise.
2192 (detect_coding_system): Likewise.
2193 (Fdefine_coding_system_internal): New coding system properties
2194 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2195 :prefer-utf-8.
2196 (syms_of_coding): Adjust for coding_arg_undecided_max.
2197
ba3de9e6
PE
21982013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 * image.c (x_from_xcolors): Remove unused local.
2201
547c9269
YM
22022013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2203
2204 Defer image data transfer between X client and server until actual
2205 display happens.
2206
2207 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2208 and `mask_img'.
2209
2210 * image.c (Destroy_Image): Remove.
2211 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2212 `mask_p', and `colors_p'. All uses changed.
2213 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2214 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2215 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2216 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2217 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2218 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2219 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2220 (image_get_x_image, image_unget_x_image): New functions or macros.
2221 (image_background, image_background_transparent, x_to_xcolors)
2222 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2223 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2224 instead of Destroy_Image.
2225 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2226 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2227 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2228 (imagemagick_load_image, svg_load_image): Use them instead of
2229 x_create_x_image_and_pixmap, and x_put_x_image followed by
2230 x_destroy_x_image, respectively.
2231 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2232 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2233 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2234 background_transparent fields.
2235 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2236 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2237
dae2f5ef
PE
22382013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2241 This mostly consists of undoing recent changes.
2242 * callproc.c (Fcall_process):
2243 * process.c (create_process):
2244 Do not worry about catching SIGCHLD here, undoing previous change.
2245 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2246 * process.c, process.h (catch_child_signal):
2247 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2248 * process.c (catch_child_handler): Don't worry about being called
2249 lazily and do not assume caller has blocked SIGCHLD, undoing
2250 previous change. Move first-time stuff back to
2251 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2252 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2253 set lib_child_handler if it's already initialized, which may
2254 help avoid problems on GNUStep.
2255
fa55d2aa
PE
22562013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2257
2258 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2259 * callproc.c (Fcall_process):
2260 * process.c (create_process):
2261 Make sure SIGCHLD is caught before we fork,
2262 since Emacs startup no arranges to catch SIGCHLD.
2263 * process.c (lib_child_handler): Initialize to null, not to
2264 dummy_handler.
2265 (catch_child_signal): Allow self to be called lazily.
2266 Do nothing if it's already been called.
2267 Assume caller has blocked SIGCHLD (all callers do now).
2268 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2269 just before it's really needed.
2270 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2271 since it hasn't been caught yet.
2272
f3f9606c
LMI
22732013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2274
2275 * image.c (compute_image_size): New function to implement
2276 :max-width and :max-height.
2277 (imagemagick_load_image): Use it.
2278
c7041908
PE
22792013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2282 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2283 Now extern.
2284 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2285 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2286 the SIGCHLD handler, since the code is not atomic and (due to glib)
2287 signals may be arriving now.
2288 * sysdep.c (init_signals): Do not catch child signals here;
2289 'main' now does that later, at a safer time.
2290
f86852b4
PE
22912013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2292
0dfeed58
PE
2293 Clean up SIGCHLD handling a bit (Bug#14569).
2294 * process.c, process.h (catch_child_signal):
2295 Now always extern, even if !NS_IMPL_GNUSTEP.
2296 * process.c (catch_child_signal): Move glib tickler here from
2297 init_process_emacs, so that it's done earlier in Emacs
2298 initialization. Also move the noninteractive && !initialized
2299 check here from init_process_emacs. This is all a bit cleaner for
2300 GNUish platforms, and I hope it works around the Cygwin bug.
2301 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2302 that glib signal handling is tickled before glib creates threads.
2303
f86852b4
PE
2304 * process.c (wait_reading_process_output): Avoid int overflow
2305 when reading more than 2 GiB total from a process.
2306
cbd6509c
PE
23072013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 * process.c (create_process): Handle a couple more cases,
2310 i.e., work even if new_argv and wait_child_setup[i] are cached.
2311 Use Fcall_process's style for volatile vars.
2312
9de1114a
AS
23132013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2314
2315 * process.c (create_process): Mark PROCESS volatile.
2316
fbe9e0b9
PE
23172013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2318
2319 Use C99-style flexible array members if available.
2320 This avoids some subtle aliasing issues, which typically
2321 aren't a problem with GCC but may be a problem elsewhere.
2322 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2323 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2324 In either case, it uses a flexible array member rather than
2325 the old struct hack. All uses changed.
2326 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2327 Adjust to sdata reorganization.
2328 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2329 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2330 that ports better to pre-C99 non-GCC.
2331 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2332 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2333 as the latter has changed.
2334 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2335 and port better to pre-C99 GCC.
2336 * image.c (struct xpm_cached_color):
2337 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2338 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2339 Use FLEXIBLE_ARRAY_MEMBER.
2340 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2341 Move decl to top level so it gets checked against implementation.
2342 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2343 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2344
1fc71008
PE
23452013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2346
2347 * syntax.c: Integer cleanups.
2348 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2349 All uses that need 0-or-2 changed to:
2350 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2351 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2352 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2353 (char_quoted, prev_char_comend_first, back_comment)
2354 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2355 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2356 Use bool for boolean.
2357 (update_syntax_table, skip_chars, skip_syntaxes):
2358 Prefer int to unsigned when either will do.
2359 (back_comment): Return boolean success flag, like forw_comment,
2360 instead of positive-or-minus-1 (which might have overflowed int anyway).
2361 Don't stuff ptrdiff_t into int.
2362 (syntax_spec_code, syntax_code_spec): Now const.
2363 (Fmatching_paren, scan_lists, scan_sexps_forward):
2364 Use enum syntaxcode for syntax code.
2365 (Fmatching_paren): Check that arg is a character, not just an integer.
2366 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2367 (Finternal_describe_syntax_value): Omit no-longer-needed
2368 comparison to 0.
2369 (skip_chars): Use char, not unsigned char, when the distinction
2370 doesn't matter.
2371 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2372 * bytecode.c (exec_byte_code):
2373 * syntax.c (syntax_spec_code, Fchar_syntax)
2374 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2375 (init_syntax_once):
2376 * syntax.h (SYNTAX_WITH_FLAGS):
2377 Omit unnecessary casts.
2378
b932cad7
EZ
23792013-06-20 Eli Zaretskii <eliz@gnu.org>
2380
2381 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2382 line dimensions here, to avoid race conditions with the main
2383 thread. (Bug#14062, bug#14630, bug#14669)
2384
2385 * w32term.c (w32_draw_window_cursor): Compute the header line and
2386 mode line dimensions here.
2387 <w32_system_caret_window, w32_system_caret_hdr_height>:
2388 <w32_system_caret_mode_height>: New variables.
2389
2390 * w32term.h: Declare them.
2391
89561f72
PE
23922013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2393
5013fc08
PE
2394 * alloc.c (die): Move "assertion failed" string here ...
2395 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2396 COND when SUPPRESS_CHECKING. This shrinks the executable text
2397 size by 0.8% to 2.2% when configured with --enable-checking,
2398 depending on optimization flags (GCC 4.8.1 x86-64).
2399
89561f72
PE
2400 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2401
763a086d 24022013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2403
2404 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2405 base is 2; this is more accurate.
2406
983aeb9a
JB
24072013-06-19 Juanma Barranquero <lekktu@gmail.com>
2408
2409 * sound.c (string_default): Move to !WINDOWSNT section.
2410 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2411
178ba3e6
PE
24122013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2413
bbc51b15
PE
2414 * sound.c: Integer cleanups.
2415 Remove unnecessary forward decls.
2416 (struct sound_device): The 'file' member is now a Lisp_Object, not
2417 a char *, so that we needn't invoke alloca on a huge size.
2418 (Fplay_sound_internal): Adjust to this.
2419 (string_default): New function.
2420 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2421 Use it to adjust to the struct sound_device change.
2422 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2423 (be2hs) [0]: Remove.
2424
178ba3e6
PE
2425 * syntax.c (skip_chars): Don't use uninitialized storage
2426 when searching a multibyte buffer for characters that are not in a
2427 unibyte string that contains non-ASCII characters.
2428
69f60cdc
JD
24292013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2430
2431 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2432 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2433
0d6224d4
PE
24342013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2437
3c542890
KH
24382013-06-18 Kenichi Handa <handa@gnu.org>
2439
f7e3f7cd
KH
2440 * font.c (Ffont_spec): Signal an error for an invalid font name
2441 (Bug#14648).
3c542890 2442
9349e5f7
PE
24432013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2446 In particular this ports to 32-bit sparc Sun cc.
2447 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2448 array with a dummy element at specpdl[-1], so that its address can
2449 be taken portably.
2450 (unbind_to): Do not copy the binding; not needed, now that we
2451 copy old_value in the one place where the copy is needed.
2452 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2453 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2454 (union specbinding): Rename from struct specbinding. Redo layout
2455 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2456 which is not portable. With Sun C 5.12 32-bit sparc, the
2457 declaration causes nargs to be an unsigned bitfield, a behavior
2458 that the C standard allows; but Emacs wants nargs to be signed.
2459 The overall type is now a union of structures rather than a
2460 structure of union of structures, and the 'kind' member is now a
2461 bitfield, so that the overall type doesn't grow. All uses changed.
2462 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2463
0a4df6a5
PE
24642013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2465
ec6ecaad
PE
2466 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2467 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2468
0a4df6a5
PE
2469 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2470
7bfe8dbc
EZ
24712013-06-17 Eli Zaretskii <eliz@gnu.org>
2472
2473 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2474 unless we know that the window w's frame is a frame object.
2475 Another attempt at solving bug#14062 and bug#14630.
2476
708e05f6
LMI
24772013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2478
2479 * textprop.c (property_set_type): New enum.
2480 (add_properties): Allow appending/prepending text properties.
2481 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2482 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2483 add_text_properties_1.
2484 (Fadd_face_text_property): New function that calls
2485 add_text_properties_1.
2486
84575e67
PE
24872013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2488
2489 Move functions from lisp.h to individual modules when possible.
2490 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2491 * alloc.c (XFLOAT_INIT, set_symbol_name):
2492 * buffer.c (CHECK_OVERLAY):
2493 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2494 (set_char_table_parent):
2495 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2496 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2497 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2498 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2499 (set_blv_valcell):
2500 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2501 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2502 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2503 (backtrace_args, backtrace_debug_on_exit):
2504 * floatfns.c (CHECK_FLOAT):
2505 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2506 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2507 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2508 (set_hash_index_slot):
2509 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2510 * marker.c (CHECK_MARKER):
2511 * textprop.c (CHECK_STRING_OR_BUFFER):
2512 * window.c (CHECK_WINDOW_CONFIGURATION):
2513 Move here from lisp.h, and make these functions static rather than
2514 extern inline.
2515 * buffer.c (Qoverlayp):
2516 * data.c (Qsubrp):
2517 * fns.c (Qhash_table_p):
2518 * window.c (Qwindow_configuration_p):
2519 Now static.
2520 * lisp.h: Remove the abovementioned defns and decls.
2521
44e18199 2522 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2523 In lisp.h, prefer functions to function-like macros, and
2524 constants to object-like macros, when either will do. This:
2525 . simplifies use, as there's no more need to worry about
2526 arguments' side effects being evaluated multiple times.
2527 . makes the code easier to debug on some platforms.
2528 However, when using gcc -O0, keep using function-like macros
2529 for a few critical operations, for performance reasons.
2530 This sort of thing isn't needed with gcc -Og, but -Og
2531 is a GCC 4.8 feature and isn't widely-enough available yet.
2532 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2533 Remove enum lsb_bits; no longer needed.
2534 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2535 * buffer.c (Qoverlap):
2536 * data.c (Qsubrp):
2537 * fns.c (Qhash_table_p):
2538 Now extern, so lisp.h can use these symbols.
2539 * dispextern.h: Include character.h, for MAX_CHAR etc.
2540 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2541 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2542 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2543 (GLYPH_CODE_P): Move here from lisp.h.
2544 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2545 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2546 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2547 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2548 XUNTAG now returns void *.
2549 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2550 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2551 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2552 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2553 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2554 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2555 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2556 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2557 New macros, renamed from their sans-lisp_h_ counterparts.
2558 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2559 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2560 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2561 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2562 If compiling via GCC without optimization, define these as macros
2563 in addition to inline functions.
2564 To disable this, compile with -DINLINING=0.
2565 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2566 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2567 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2568 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2569 (INTMASK, VALMASK): Now macros, since static values cannot be
2570 accessed from extern inline functions.
2571 (VALMASK): Also a constant, for benefit of old GDB.
2572 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2573 is INTEGERP, which can fold it in.
5165d44a 2574 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2575 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2576 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2577 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2578 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2579 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2580 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2581 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2582 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2583 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2584 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2585 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2586 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2587 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2588 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2589 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2590 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2591 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2592 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2593 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2594 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2595 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2596 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2597 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2598 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2599 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2600 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2601 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2602 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2603 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2604 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2605 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2606 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2607 Now functions.
2608 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2609 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2610 (VALMASK): Define in one place rather than in two, merging the
2611 USE_LSB_TAG parts; this is simpler.
2612 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2613 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2614 Move up, to avoid use before definition.
2615 Also include "globals.h" earlier, for the same reason.
2616 (make_natnum): New function.
2617 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2618 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2619 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2620 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2621 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2622 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2623 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2624 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2625 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2626 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2627 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2628 (Qwindow_configuration_p, Qimage): New forward declarations.
2629 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2630 (STRING_COPYIN): Remove; unused.
2631 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2632 (xcar_addr, xcdr_addr): New functions. All uses changed.
2633 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2634 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2635 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2636 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2637 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2638 (TYPE_RANGED_INTEGERP): Simplify.
2639 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2640 (setlocale, fixup_locale, synchronize_system_messages_locale)
2641 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2642 Now empty functions, not macros.
2643 (functionp): Return bool, not int.
2644 * window.c (Qwindow_configuration_p): Now extern,
2645 so window.h can use it.
2646 * window.h (Qwindowp): Move decl back to lisp.h.
2647
9583ec36
EZ
26482013-06-15 Eli Zaretskii <eliz@gnu.org>
2649
2650 * xdisp.c (Fline_pixel_height): New function, required for solving
2651 bug #14567.
2652
210272ce
PE
26532013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2656
de0503df
SM
26572013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2658
2659 * lread.c (syms_of_lread):
2660 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2661
afbfe143
KD
26622013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2663
2664 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2665
d177e213
XF
26662013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2667
2668 * fileio.c (expand_file_name): Doc fix.
2669
05e3e412
PE
26702013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2671
f7394b12
PE
2672 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2673 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2674 Wait for self, not for 0. This can't hurt on GNU or similar
2675 system, and may help with Cygwin.
2676
05e3e412
PE
2677 * keyboard.c: Don't use PROP (...) as an lvalue.
2678 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2679 Use set_prop (A, B), not PROP (A) = B.
2680
17dd3097
EZ
26812013-06-10 Eli Zaretskii <eliz@gnu.org>
2682
2683 * xdisp.c (get_it_property): Use it->window instead of generating
2684 a Lisp object from it->w.
2685
52fab9c9
EZ
26862013-06-09 Eli Zaretskii <eliz@gnu.org>
2687
2688 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2689 get-char-property the window that is being rendered, instead of
2690 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2691 (compute_display_string_pos): When W is NULL, use the current
2692 buffer as the object to pass to get-char-property.
2693 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2694 pointer member of the bidi iterator, since no window is pertinent
2695 to this function.
52fab9c9 2696
5bf97bfc
EZ
26972013-06-08 Eli Zaretskii <eliz@gnu.org>
2698
2699 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2700 being displayed, and pass it to compute_display_string_pos.
2701 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2702 (bidi_paragraph_init): All callers changed.
2703
2704 * xdisp.c (init_from_display_pos, init_iterator)
2705 (handle_single_display_spec, next_overlay_string)
2706 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2707 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2708 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2709 (compute_display_string_pos): Accept additional argument, the
2710 window being displayed, and pass it to Fget_char_property.
2711 (Bug#14575)
2712
2713 * dispextern.h (struct bidi_it): New member w, the window being
2714 displayed.
2715 (compute_display_string_pos): Adjust prototype.
2716
5de0e011
JD
27172013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2718
e7b41c4c 2719 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2720
2721 * process.c (wait_reading_process_output): Check for NS before GLIB.
2722 GLIB may be linked in due to rsvg, but ns_select must be called.
2723
5de0e011
JD
2724 * xgselect.c (xg_select): Remove call to window_system_available
2725 and g_main_context_pending at the top, so Gdk events (i.e. file
2726 notify) are processed when Emacs is started with -nw.
2727
a822acff
EZ
27282013-06-07 Eli Zaretskii <eliz@gnu.org>
2729
2730 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2731 (ctagsfiles3): New variable, includes only *.m files.
2732 (TAGS): Use an explicit language name in the regular expressions,
2733 to avoid transformation of '/SOMETHING' by MSYS to
2734 'c:\MSYS\SOMETHING'.
2735
6c0a9ed1
RC
27362013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2737
2738 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2739
9ef6111b
EZ
27402013-06-06 Eli Zaretskii <eliz@gnu.org>
2741
2742 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2743 still need to set the mouse pointer shape and activate help-echo.
2744 (Bug#14558)
2745
7d300d64
PE
27462013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2747
2748 A few porting etc. fixes for the new file monitor code.
2749 See the thread containing
2750 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2751 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2752 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2753 (dir_monitor_callback, Fgfile_rm_watch):
2754 Use assq_no_quit instead of Fassoc, for speed.
2755 (dir_monitor_callback, Fgfile_rm_watch):
2756 eassert that the monitor is a fixnum.
2757 (dir_monitor_callback): No need for CDR_SAFE.
2758 Simplify building of lisp with alternative tails.
2759 (Fgfile_add_watch, Fgfile_rm_watch):
2760 Do not assume glib functions set errno reliably on failure.
2761 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2762 and signal an error otherwise.
2763 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2764 Use Fdelq instead of Fdelete, for speed.
2765
817ebfcf
EZ
27662013-06-05 Eli Zaretskii <eliz@gnu.org>
2767
2768 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2769 don't insist on being invoked on a highlighted tool-bar button.
2770 Avoids losing tool-bar functionality when mouse-highlight is nil.
2771 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2772 Don't highlight when mouse-highlight is nil.
2773 (note_mouse_highlight): When mouse-highlight is nil, don't return
2774 right away; instead, run tool-bar and mode-line highlight
2775 subroutine, clear any existing highlight, and revert the mouse
2776 pointer to its default shape. (Bug#14558)
2777
55577e7c
SM
27782013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2779
2780 * lisp.mk (lisp): Add prog-mode.el.
2781
f019a684
PE
27822013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2783
2784 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2785 * process.c (dummy_handler): New function.
2786 (lib_child_handler): New static var.
2787 (handle_child_signal): Invoke it.
2788 (catch_child_signal): If a library has set up a signal handler,
2789 save it into lib_child_handler.
2790 (init_process_emacs): If using glib and not on Windows, tickle glib's
2791 child-handling code so that it initializes its private SIGCHLD handler.
2792 * syssignal.h (SA_SIGINFO): Default to 0.
2793 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2794 31; it should no longer be needed now.
2795
90db8702
MA
27962013-06-05 Michael Albinus <michael.albinus@gmx.de>
2797
2798 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2799
2800 * gfilenotify.c (globals_of_gfilenotify): New function.
2801 (syms_of_gfilenotify): Move global initialization there.
2802
2803 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2804
bfa3acd6
SM
28052013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2806
2807 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2808 * keyboard.c (menu_bar_items, tool_bar_items):
2809 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2810 not override local keymaps any more.
2811
ba59bd80
EZ
28122013-06-04 Eli Zaretskii <eliz@gnu.org>
2813
2814 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2815
7f203aa1
EZ
28162013-06-03 Eli Zaretskii <eliz@gnu.org>
2817
9337e206
EZ
2818 * w32console.c (initialize_w32_display): Return the dimensions of
2819 the console window via 2 additional arguments, not via the current
2820 frame. This avoids crashes due to overrunning the bounds of
2821 frame's decode_mode_spec_buffer, which is not resized following
2822 the change of the frame dimensions from the initial 10x10.
2823
2824 * w32term.h (w32_initialize_display_info): Adjust prototype.
2825
2826 * term.c (init_tty): Take dimensions of the frame from the values
2827 returned by initialize_w32_display.
2828
7f203aa1
EZ
2829 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2830 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2831 (LIBES): Add $(GFILENOTIFY_LIBS).
2832
2833 * w32inevt.c (handle_file_notifications): Add dummy implementation
2834 for !HAVE_W32NOTIFY.
2835
2836 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2837
55a87246
JD
28382013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2839
2840 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2841
2842 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2843
2844 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2845
3d5ee10a
PE
28462013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 Fix minor problems found by static checking.
2849 * data.c (pure_write_error):
2850 Use xsignal2, not Fsignal, as Fsignal might return.
2851 * eval.c (set_backtrace_debug_on_exit): Now static.
2852 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2853 No longer inline. EXTERN_INLINE is needed only for functions
2854 defined in .h files. Reindent function header as per GNU style.
2855 (backtrace_p, backtrace_top, backtrace_next):
2856 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2857 compiler or linker. Add extern decls to pacify gcc -Wall.
2858 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2859 Now static.
2860 * frame.c (free_monitors): Define only on platforms that need it.
2861 * nsterm.m (ns_term_init):
2862 * process.c (catch_child_signal):
2863 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2864 defined on all porting targets these days.
2865 * process.c, process.h (catch_child_signal):
2866 Make it extern only if NS_IMPL_GNUSTEP is defined.
2867
e2d8a6f0
EZ
28682013-06-03 Eli Zaretskii <eliz@gnu.org>
2869
2870 * w32.c (gettimeofday): Make the signature identical to prototype
2871 in nt/inc/sys/time.h.
2872
a8a7c5f6
SM
28732013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2874
2875 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2876 .gdbinit.
2877
2878 * keyboard.c (safe_run_hooks_error): Improve error message.
2879
2880 * data.c (pure_write_error): Add `object' argument.
2881 * puresize.h (CHECK_IMPURE): Use it.
2882
c9628c79
MA
28832013-06-03 Michael Albinus <michael.albinus@gmx.de>
2884
2885 * Makefile.in (NOTIFY_OBJ): New variable.
2886 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2887
2888 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2889 Call syms_of_gfilenotify.
2890
2891 * gfilenotify.c: New file.
2892
2893 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2894 and Qfile_w32notify.
2895 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2896 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2897
2898 * lisp.h: Declare syms_of_gfilenotify.
2899
2900 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2901
2f592f95
SM
29022013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2903
2904 Merge the specpdl and backtrace stacks. Make the structure of the
2905 specpdl entries more obvious via a tagged union of structs.
2906 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2907 (enum specbind_tag): New enum.
2908 (struct specbinding): Make it a tagged union of structs.
2909 Add a case for backtrace records.
2910 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2911 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2912 (backtrace_debug_on_exit): New accessors.
2913 (struct backtrace): Remove.
2914 (struct catchtag): Remove backlist field.
2915 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2916 Move to eval.c.
2917 (Flocal_variable_p): Speed up the common case where the binding is
2918 already loaded.
2919 * eval.c (backtrace_list): Remove.
2920 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2921 (set_backtrace_args, set_backtrace_nargs)
2922 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2923 (backtrace_next): New functions.
2924 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2925 (unwind_to_catch, internal_lisp_condition_case)
2926 (internal_condition_case, internal_condition_case_1)
2927 (internal_condition_case_2, internal_condition_case_n): Don't bother
2928 with backtrace_list any more.
2929 (Fsignal): Adjust to new backtrace format.
2930 (grow_specpdl): Move up.
2931 (record_in_backtrace): New function.
2932 (eval_sub, Ffuncall): Use it.
2933 (apply_lambda): Adjust to new backtrace format.
2934 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2935 data.c.
2936 (specbind): Adjust to new specpdl format. Simplify.
2937 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2938 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2939 backtrace format.
2940 (mark_backtrace): Remove.
2941 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2942 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2943 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2944 Use mark_specpdl.
2945 * profiler.c (record_backtrace): Use get_backtrace.
2946 (handle_profiler_signal): Use backtrace_top_function.
2947 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2948 accessor functions.
2949
c0342369
JD
29502013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2951
2952 * process.h (catch_child_signal): Declare.
2953
2954 * process.c (catch_child_signal): New function.
2955 (init_process_emacs): Call it.
2956
2957 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2958 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2959 NS_IMPL_COCOA.
2960 (x_set_cursor_type): Remove declaration.
2961 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2962 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2963 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2964 (ns_get_color): Use F suffix on float.
2965 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2966 (ns_get_rgb_color): Remove.
2967 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2968 (note_mouse_movement): x and y are CGFloat.
2969 (ns_draw_fringe_bitmap): Remove unused rowY.
2970 Change #if to COCOA && >= 10_6.
2971 (ns_draw_window_cursor): Remove unused overspill.
2972 (ns_draw_underwave): width and x are EamcsCGFloat.
2973 (ns_draw_box): thickness is CGFloat.
2974 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2975 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2976 if not in main thread.
2977 (ns_get_pending_menu_title, ns_check_menu_open)
2978 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2979 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2980 (sendFromMainThread:): New method.
2981 (changeFont:): size is CGFloat.
2982 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2983 Disable warning about permanent text.
2984 (characterIndexForPoint:): Adjust return type depending on GNUStep
2985 version.
2986 (mouseDown:): delta is CGFloat.
2987 (updateFrameSize): Remove unised variable f.
2988 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2989 Cast float to EmacsCGFloat.
2990 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2991 also to -1 when restoring.
2992 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2993 inside NS_IMPL_COCOA.
2994 (toggleFullScreen:): Put call to toggleFullScreen inside
2995 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2996 (setPosition:portion:whole:): por is CGFloat.
2997 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2998 (mouseDown:): Use CGFloat.
2999 (mouseDragged:): Remove unised variable edge.
3000 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3001
3002 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3003 of CGFloat differs.
3004 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3005 when NS_IMPL_GNUSTEP.
3006 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3007 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3008 (EmacsToolbar): Add clearAll. Add tag argument to
3009 addDisplayItemWithImage.
3010 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3011
3012 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3013
3014 * nsmenu.m (ns_update_menubar): Make static.
3015 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3016 (fillWithWidgetValue:): Add cast to SEL for setAction.
3017 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3018 (update_frame_tool_bar): Update code for GNUStep.
3019 (clearAll): New method.
3020 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3021 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3022 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3023 call to insertItemWithItemIdentifier.
3024 (validateVisibleItems): Fix indentation.
3025 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3026 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3027 UtilityWindow to aStyle, remove call to setStyleMask.
3028
3029 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3030
3031 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3032 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3033 Use F suffix on floats.
3034 (ns_char_width): Returns CGFloat.
3035 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3036 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3037 DPSxshow.
3038 (ns_glyph_metrics): CGFloat instead of float.
3039
a0eb10b3
JB
3040 * nsfns.m (x_set_foreground_color, x_set_background_color):
3041 Use EmacsCGFloat.
3042 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3043 remove unused variables.
3044 (Fns_read_file_name): Keep track if panel is for save.
3045 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3046 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3047 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3048 Just return the input if GNUStep.
c0342369
JD
3049 (x_screen_planes): Remove.
3050 (Fxw_color_values): Use EmacsCGFloat
3051 (Fns_display_monitor_attributes_list): Only get screen number for
3052 Cocoa.
ef099a94 3053 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3054 EmacsSavePanel.
3055 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3056 ns_directory_from_panel.
3057
da9aff11
PE
30582013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 * process.c (handle_child_signal): Also use WCONTINUED.
3061 This is so that list-processes doesn't mistakenly list the process
3062 as stopped, when the process has actually been continued and is
3063 now running.
3064
0e64479a
PE
30652013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3066
fc186a96
PE
3067 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3068 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3069 not already configured.
3070
0e64479a
PE
3071 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3072
38b787fa
EZ
30732013-05-29 Eli Zaretskii <eliz@gnu.org>
3074
3075 * Makefile.in (mostlyclean): Remove *.res files.
3076
22513e52
SM
30772013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3078
3079 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3080 a buffer (bug#8447).
3081
6ef3db10
EZ
30822013-05-27 Eli Zaretskii <eliz@gnu.org>
3083
3084 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3085 display vector, and we backtrack, handle the case that the
3086 previous character position is also displayed from a display
3087 vector or covered by a display string or image. (Bug#14476)
3088
6799bb26
JD
30892013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3090
3091 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3092 (struct MonitorInfo, free_monitors): Remove.
3093 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3094 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3095 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3096 Qframes, Qsource.
3097
3098 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3099 (struct MonitorInfo, free_monitors): Remove.
3100 (ns_screen_name): Make static.
3101 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3102 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3103 Qframes, Qsource.
3104
3105 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3106 (struct MonitorInfo): New struct.
3107 (free_monitors, make_monitor_attribute_list): Declare.
3108
22513e52
SM
3109 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3110 New Lisp_Object:s.
6799bb26
JD
3111 (free_monitors, make_monitor_attribute_list): New functions.
3112 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3113 Qsource.
3114
38cd43eb
XF
31152013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3116
3117 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3118
2af0948d
SM
31192013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3120
a7eb9b0f
SM
3121 * keyboard.c: Apply keyboard decoding only to events that come directly
3122 from the tty, not from unread-command-events (bug#14368).
3123 (read_event_from_main_queue): New function, extracted from read_char).
3124 (read_decoded_char): Remove.
3125 (read_decoded_event_from_main_queue): New function to replace it.
3126 (read_char): Use it.
3127 (read_key_sequence): Use read_char rather than read_decoded_char.
3128
2af0948d
SM
3129 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3130
1413e9a5
BR
31312013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3132
3133 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3134
e6d2f155
KH
31352013-05-22 Kenichi Handa <handa@gnu.org>
3136
3137 The following changes are to fix the setting of
3138 buffer-file-coding-system on, for instance, C-x RET c unix RET
3139 _FILE_OF_DOS_EOL_TYPE_ RET.
3140
3141 * coding.h (struct coding_system): New member detected_utf8_chars.
3142
3143 * coding.c (detect_coding_utf_8): Count characters and check EOL
3144 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3145 BOM is there.
3146 (setup_coding_system): Do not initialize coding->head_ascii.
3147 (check_ascii): Do not set coding->eol_seen but update it. Do not
3148 call adjust_coding_eol_type here.
1413e9a5
BR
3149 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3150 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3151 of the found coding-system.
3152 (decode_coding_gap): Cancel previous change. Utilize the
3153 character numbers counted by detect_coding_utf_8. Fix detection
3154 of BOM for utf-8.
3155
ab56a6f4 31562013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3157
3158 * search.c (looking_at_1): Only set last_thing_searched if the match
3159 changed the match-data (bug#14281).
3160
ecc3c6ed
DA
31612013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3162
3163 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3164 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3165 (move_it_vertically_backward): Likewise.
3166
5ba8bf35
YM
31672013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3168
3169 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3170 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3171 (Fx_display_mm_width, Fx_display_mm_height):
3172 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3173
91e8418b 3174 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3175 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3176 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3177 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3178 (Fx_display_backing_store, Fx_display_visual_class)
3179 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3180 (Fx_display_grayscale_p, Fx_display_pixel_width)
3181 (Fx_display_pixel_height, Fx_display_planes)
3182 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3183 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3184 (Fx_display_mm_width, Fx_display_mm_height)
3185 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3186 height for all physical monitors as in X11.
3187
fc30d803
SM
3188 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3189 Return pixel width or height for all physical monitors as in X11.
91e8418b 3190
31ff141c
PE
31912013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 Port --enable-gcc-warnings to clang.
3194 * bytecode.c (exec_byte_code):
3195 * regex.c:
3196 Redo diagnostic pragmas to pacify clang, too.
3197 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3198 * editfns.c (Fencode_time):
3199 * fileio.c (file_accessible_directory_p):
3200 * font.c (font_unparse_xlfd):
3201 Use '&"string"[index]' instead of '"string" + (index)'.
3202 * undo.c (user_error): Remove; unused.
3203
df065a0b
EZ
32042013-05-16 Eli Zaretskii <eliz@gnu.org>
3205
04d360e7
EZ
3206 * insdel.c (insert_1_both): Document the arguments, instead of
3207 referring to insert_1, which no longer exists.
3208
5bb98290
EZ
3209 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3210 some window, increment windows_or_buffers_changed, so that
3211 *Messages* display in that window is updated. (Bug#14408)
3212
df065a0b
EZ
3213 * w32.c: Include epaths.h.
3214 (init_environment): Use cmdproxy.exe without leading directories.
3215 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3216 case.
3217 (gettimeofday): Adjust signature and return value to Posix
3218 expectations.
3219
3220 * unexw32.c (open_output_file): Delete the existing emacs.exe
3221 before creating it, to break the hard link to the versioned
3222 executable.
3223
3224 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3225 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3226 (FIRSTFILE_OBJ): New variables.
3227 (W32_RES): Rename to EMACSRES. All users changed.
3228 (base_obj): Use $(CM_OBJ).
3229 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3230 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3231 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3232 $(W32_RES_LINK) before $(LIBES).
3233 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3234
1aa8d505
SM
32352013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3236
6e911150
SM
3237 * makefile.w32-in (DOC): Use just "DOC".
3238
3239 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3240
1aa8d505
SM
3241 * process.c: Export default filters and sentinels to Elisp.
3242 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3243 New constants.
3244 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3245 (Fset_process_sentinel, Fformat_network_address):
3246 Default to them instead of nil.
3247 (server_accept_connection): Sentinels can't be nil any more.
3248 (read_and_dispose_of_process_output): New function, extracted from
3249 read_process_output.
3250 (read_process_output): Use it; filters can't be nil.
3251 (Finternal_default_process_filter): New function, extracted from
3252 read_process_output.
3253 (exec_sentinel_unwind): Remove function.
3254 (exec_sentinel): Don't zilch sentinel while running.
3255 (status_notify): Sentinels can't be nil.
3256 (Finternal_default_process_sentinel): New function extracted from
3257 status_notify.
3258 (setup_process_coding_systems): Default filter is not nil any more.
3259 (syms_of_process): Export new Elisp functions and initialize
3260 new constants.
3261 * lisp.h (make_lisp_proc): New function.
3262
5ac2eb34
SM
32632013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3264
3265 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3266
eda9c7d7
EZ
32672013-05-14 Eli Zaretskii <eliz@gnu.org>
3268
3269 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3270 unless we know that the window w is a leaf window.
3271 Another attempt at solving bug#14062.
eda9c7d7 3272
8fdeaad5
JD
32732013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3274
3275 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3276 fdesc (Bug#14375).
3277
44aa9ee6
PE
32782013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3279
3280 * image.c (gif_load): Check that subimages fit (Bug#14345).
3281
759fd763
SM
32822013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3283
3284 * lread.c (skip_dyn_eof): New function.
3285 (read1): Use it to skip the end of a file in response to #@00.
3286
3287 * doc.c (get_doc_string): Slightly relax the sanity checking.
3288
4465bfb4
JD
32892013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3290
3291 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3292 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3293 (MonitorInfo): New struct.
3294 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3295 (Fns_display_monitor_attributes_list): New functions.
3296 (display-usable-bounds): Remove.
3297 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3298 Qsource.
3299
7583e2a0
PE
33002013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3303 (GTK_CHECK_VERSION): New macro, if not already defined.
3304 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3305 replaced by GTK_CHECK_VERSION.
3306
ad75d77e
PE
33072013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 * xterm.h (GTK_PREREQ): New macro.
3310 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3311 to use this macro instead, for consistency and clarity.
3312
07525f77
EZ
33132013-05-08 Eli Zaretskii <eliz@gnu.org>
3314
3315 * xdisp.c (row_for_charpos_p): New function, with code of
3316 cursor_row_p, but accepts an additional argument CHARPOS instead
3317 of using a hardcoded PT.
3318 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3319 (row_containing_pos): Call row_for_charpos_p instead of partially
3320 doing the same. Fixes cursor positioning under longlines-mode
3321 when longlines-show-effect includes more than one newline, when
3322 moving the cursor vertically up.
3323
d901fc8d
JB
33242013-05-08 Juanma Barranquero <lekktu@gmail.com>
3325
3326 * makefile.w32-in (ACL_H): New macro.
3327 ($(BLD)/fileio.$(O)): Update dependencies.
3328
f269bc61
PE
33292013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3330
e7b41c4c 3331 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3332 * Makefile.in (LIB_ACL): New macro.
3333 (LIBACL_LIBS): Remove.
3334 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3335 * fileio.c: Include <acl.h>.
3336 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3337 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3338 !acl_errno_valid.
3339 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3340 it ourselves.
3341
f269bc61
PE
3342 * unexelf.c: Don't assume ElfW (Half) fits in int.
3343 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3344 when dealing with ElfW (Half) values, since they can exceed 2**31
3345 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3346 (entry_address): Omit unused NUM arg. All uses changed.
3347
a261c53e
JL
33482013-05-07 Juri Linkov <juri@jurta.org>
3349
3350 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3351 to the string converted from number with `Fnumber_to_string'.
3352 (Bug#14254)
3353
2b66427d
PE
33542013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3355
3356 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3357 This fixes a problem introduced by my previous change.
3358
15acfe41
GM
33592013-05-07 Glenn Morris <rgm@gnu.org>
3360
3361 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3362
5ea03bf5
JD
33632013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3364
3365 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3366
e0c9d565
PE
33672013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3368
3369 Static checking by GCC 4.8.0.
3370 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3371 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3372 (x_get_monitor_attributes_fallback)
3373 (x_get_monitor_attributes_xinerama)
3374 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3375 Define only if USE_GTK.
3376 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3377 (x_get_monitor_attributes_fallback): Omit unused locals.
3378 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3379 Use double, not float, to avoid mixed-mode floating point arithmetic.
3380
4e3f9230
YM
33812013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3382 Jan Djärv <jan.h.d@swipnet.se>
3383
3384 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3385 (XINERAMA_CFLAGS): New macros.
3386 (ALL_CFLAGS, LIBES): Use them.
3387
3388 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3389 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3390 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3391 (syms_of_xfns): DEFSYM them.
3392 (struct MonitorInfo): New struct.
3393 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3394 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3395 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3396 (x_get_monitor_attributes_xinerama): New functions.
3397 (Fx_display_monitor_attributes_list): New primitive.
3398 (syms_of_xfns): Defsubr it.
3399
3400 * xterm.h (x_display_info): Add Xatom_net_workarea and
3401 Xatom_net_current_desktop.
3402
3403 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3404 and dpyinfo->Xatom_net_current_desktop.
3405
05839b6a
EZ
34062013-05-06 Eli Zaretskii <eliz@gnu.org>
3407
3408 * xdisp.c (pos_visible_p): Use the special code for finding the
3409 beginning of a display property or overlay for any "replacing"
3410 display property, not just for display strings. This solves
3411 incorrect reporting of position by posn-at-point. (Bug#14241)
3412
dc4a2ee0
PE
34132013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3414
5ee94506
PE
3415 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3416 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3417 Verify that ElfW (Half) fits in int.
3418 (fatal): Use same signature as lisp.h.
3419 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3420 configure and build with -DUNEXELF_DEBUG without worrying about
3421 other modules that use DEBUG.
3422 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3423 possibly-wide integers now uses it instead of plain fprintf.
3424 (entry_address): New function, which avoids problems with 32-bit
3425 overflow on 64-bit hosts.
3426 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3427 (round_up): Don't assume the remainder fits in int.
3428 (find_section): Use bool for boolean. Simplify debug code.
3429 (unexec): Don't assume file sizes fit in int or size_t.
3430 Omit unnecessary trailing newline in 'fatal' format.
3431 Use strerror rather than outputting decimal error number.
3432 Remove unused code when emacs is not defined;
3433 this file relies on Emacs now.
3434 Don't assume e_phnum and e_shnum are positive.
3435
dc4a2ee0
PE
3436 * regex.c: Fix problems when DEBUG is defined.
3437 (extract_number, extract_number_and_incr): Define regardless of
3438 whether DEBUG is defined; that's simpler and makes the code less
3439 likely to go stale in the normal case when DEBUG is not defined.
3440 Return int rather than taking an int * arg. All callers changed.
3441 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3442 Remove, replacing with ...
3443 (DEBUG_PRINT): New macro. All callers changed.
3444 (DEBUG_COMPILES_ARGUMENTS): New macro.
3445 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3446 (print_compiled_pattern, print_double_string) [DEBUG]:
3447 Use prototype rather than old-style definition.
3448 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3449 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3450 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3451 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3452 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3453 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3454 This matters only when DEBUG is defined.
3455
14c7ed05
EZ
34562013-05-05 Eli Zaretskii <eliz@gnu.org>
3457
3458 * xdisp.c (set_iterator_to_next): Set the
3459 ignore_overlay_strings_at_pos_p flag only if we are _really_
3460 iterating over an overlay string, as indicated by the
3461 current.overlay_string_index member. (Bug#14306)
3462
e6076b1b
JD
34632013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3464
3465 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3466 to where it is used, to avoid autorelease issues (Bug#14050).
3467
cbee2131
PE
34682013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3469
3470 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3471 * fileio.c (syms_of_fileio): Implement this.
3472 * filelock.c (create_lock_file): If symbolic links don't work, so
3473 we use a regular file as a lock file, do not fsync the lock file;
3474 it's not needed.
3475
30c7e542
SM
34762013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3477
3478 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3479 (syms_of_minibuf): Adjust accodingly.
3480 * lread.c (Fread):
3481 * callint.c (Fcall_interactively): Adjust calls accordingly.
3482
5bebd186
EZ
34832013-05-04 Eli Zaretskii <eliz@gnu.org>
3484
3485 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3486 w->contents is a buffer before computing everything else.
3487 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3488
3489 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3490 assertion violations. (Bug#14062)
3491
0fb0a4f3
DR
34922013-05-01 David Reitter <david.reitter@gmail.com>
3493
3494 * nsfns.m (ns_tooltip): Initialize.
3495
9e63b4a5
EZ
34962013-04-28 Eli Zaretskii <eliz@gnu.org>
3497
3498 * coding.c (decode_coding_gap): Don't remove the character before
3499 a newline unless it's a CR character. (Bug#14287)
3500
ad60824e
DN
35012013-04-28 Dan Nicolaescu <dann@gnu.org>
3502
3503 * dispextern.h (struct face): Move enum face_underline_type
3504 earlier so that bitfields can be in the same word.
3505
edbdcec0
JD
35062013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3507
3508 * nsfns.m (handlePanelKeys): New function.
3509 (EmacsOpenPanel:performKeyEquivalent:)
3510 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3511 arrows/function/control and copy/paste keys (Bug#14296).
3512
0208ede7
JL
35132013-04-27 Juri Linkov <juri@jurta.org>
3514
3515 * callint.c (Fcall_interactively): Call `Qread_number' for
3516 interactive code letter `n' instead of using duplicate code.
3517 (Bug#14254)
3518
b8dd59f7
PE
35192013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 * systime.h (make_timeval): Declare as 'const'.
3522
8bd722db
KH
35232013-04-27 Kenichi Handa <handa@gnu.org>
3524
3525 * font.c (font_open_entity): Always open a font of manageable
3526 size.
3527
13d0e56f 35282013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3529
f780d632
PE
3530 Port better to AIX (Bug#14258).
3531 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3532 to pacify AIX xlc.
3533
ec509856
KH
35342013-04-24 Kenichi Handa <handa@gnu.org>
3535
3536 * coding.c (decode_coding_iso_2022): When an invalid escape
3537 sequence is encountered, reset the invocation and designation
3538 status to the safest one.
3539
84fc48e5
PE
35402013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3541
3542 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3543 Without this fix, "make distclean" leaves stamp-h1 behind.
3544
806bda47
EC
35452013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3546
3547 * w32fns.c (w32_fullscreen_rect): New function to compute the
3548 window rectangle for the given fullscreen mode.
3549 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3550 longer tunes the window size. This keeps the window's edges flush
3551 with the screen and allows the taskbar to hide itself in fullboth.
3552
3553 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3554 window decorations and uses the entire screen.
3555
3556 * w32term.h (w32_fullscreen_rect) Add prototype.
3557 (struct w32_output): Replace normal_width, normal_height,
3558 normal_top, and normal_left members with a single normal_placement
3559 struct.
3560 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3561 Remove macros.
3562 (FRAME_NORMAL_PLACEMENT): New macro.
3563
9cc2810b
JB
35642013-04-16 Juanma Barranquero <lekktu@gmail.com>
3565
3566 * minibuf.c (Ftest_completion): Silence compiler warning.
3567
fd16b54c
EZ
35682013-04-15 Eli Zaretskii <eliz@gnu.org>
3569
3570 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3571 bug#14062.
fd16b54c
EZ
3572
3573 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3574 parentheses.
3575
3576 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3577 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3578 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3579 parentheses where appropriate.
3580
9e3379a0
PE
35812013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3582
3583 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3584
ddd6b685
EZ
35852013-04-14 Eli Zaretskii <eliz@gnu.org>
3586
3587 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3588 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3589 Mention in the doc string that setting these variables takes
3590 effect only after a call to set-window-buffer. (Bug#14200)
3591
29b79ba1
EZ
35922013-04-13 Eli Zaretskii <eliz@gnu.org>
3593
3594 * indent.c (Fvertical_motion): Don't consider display strings on
3595 overlay strings as display strings on the buffer position we
3596 started from. This prevents vertical cursor motion from jumping
3597 more than one line when there's an overlay string with a display
3598 property at end of line.
3599 Reported by Karl Chen <Karl.Chen@quarl.org> in
3600 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3601
562c6ee9
SM
36022013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3603
3604 * window.c (select_window): `record_buffer' even if window is
3605 already selected (bug#14191).
3606
fcc1fe85
EZ
36072013-04-11 Eli Zaretskii <eliz@gnu.org>
3608
3609 * window.c (Fwindow_end): Test more flags, including the buffer's
3610 last_overlay_modified flag, to determine whether the window's
3611 display is really up-to-date. Prevents the function from
3612 returning a stale value. (Bug#14170)
3613 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3614 current matrix.
3615
f009190a
EZ
36162013-04-10 Eli Zaretskii <eliz@gnu.org>
3617
3618 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3619 garbaged only if it is not already the top frame on its TTY.
3620 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3621 there are GUI frames open in the same session. (Bug#13864)
3622
78ce603d
SM
36232013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3624
3625 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3626 of marking the idle timers directly.
3627
a8036e40
SM
36282013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3629
3630 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3631 tables (bug#14054).
3632
7ffe7ef6
SM
36332013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3634
3635 * window.c (select_window): Don't record_buffer while the invariant is
3636 temporarily broken (bug#14161).
3637
3638 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3639
7d9f6883
EZ
36402013-04-07 Eli Zaretskii <eliz@gnu.org>
3641
3642 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3643
5406cfd9
RF
36442013-04-07 Romain Francoise <romain@orebokech.com>
3645
3646 Ignore additional platform-specific ACL errors (Bug#13702).
3647 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3648 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3649
95c0e83b
JD
36502013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3651
3652 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3653 f->output_data.ns.
3654
876da980
PE
36552013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3658 This bug was introduced by my 2013-02-25 change that simplified
3659 data_start configuration. Without this change, on GNU/Linux
3660 an Emacs configured with --enable-profiling fails immediately
3661 due to a profiler signal.
3662 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3663 with these flags. On platforms where special flags are needed
3664 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3665 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3666 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3667
7452b7bd
DA
36682013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3669
3670 Get rid of some platform-specific functions examining window
3671 system and its capabilities. This is a partial rework of the
3672 2013-04-05 change.
3673 * lisp.h (have_menus_p): Remove prototype. This function is
3674 replaced with platform-independent window_system_available.
3675 (check_window_system): Move to...
3676 * frame.h (decode_window_system_frame, window_system_available):
3677 ...here, add new prototypes.
3678 * frame.c (window_system_available, decode_window_system_frame):
3679 New functions.
3680 (check_window_system): Platform-independent now.
3681 * xterm.h (x_in_use): Remove declaration.
3682 (check_x_frame):
3683 * w32term.h (check_x_frame):
3684 * nsterm.h (check_x_frame): Remove prototypes. This function
3685 is replaced with platform-independent decode_window_system_frame.
3686 * msdos.c (have_menus_p): Remove.
3687 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3688 Remove platform-specific functions. Use check_window_system,
3689 decode_window_system_frame and check_ns_display_info where
3690 appropriate. Minor style and comment tweaks.
3691 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3692 (check_x_frame): Likewise.
3693 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3694 Likewise.
3695 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3696 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3697 * xmenu.c, xselect.c: All related users changed.
3698
251e9147
KH
36992013-04-03 Kenichi Handa <handa@gnu.org>
3700
3701 The following changes is to optimize the code for reading UTF-8
3702 files.
3703
562c6ee9 3704 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3705 changed. Check EOL format. Do not call adjust_coding_eol_type
3706 here.
3707 (check_utf_8): New function.
3708 (adjust_coding_eol_type): Do nothing if already adjusted.
3709 (detect_coding): Compare the return value of check_ascii with
3710 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3711 (decode_coding_gap): Optimize for valid UTF-8.
3712
8bc369d4
KH
37132013-03-21 Kenichi Handa <handa@gnu.org>
3714
3715 * coding.c (syms_of_coding): Cancel previous change.
3716
3717 * insdel.c (insert_from_gap): Fix previous change.
3718
73931ad1
DA
37192013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3720
3721 Consistently use platform-specific function to detect window system.
3722 * lisp.h (check_window_system): New prototype. This function is
3723 going to replace check_x, check_w32 and check_ns.
3724 (have_menus_p): Mention msdos.c in comment.
3725 * fontset.c (check_window_system_func): Remove. Adjust all users.
3726 * fontset.h (check_window_system_func): Remove prototype.
3727 * nsterm.h (check_ns):
3728 * xterm.h (check_x):
3729 * w32term.h (check_w32): Likewise.
3730 * menu.c (Fx_popup_menu): Use check_window_system.
3731 * msdos.c (check_window_system): Define for MS-DOS.
3732 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3733 * w32fns.c (check_window_system): Likewise for MS-Windows.
3734 * xfns.c (check_window_system): Likewise for X.
3735 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3736 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3737
7216e43b
PE
37382013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 Prefer < to > in range checks such as 0 <= i && i < N.
3741 This makes it easier to visualize quantities on a number line.
3742 This patch doesn't apply to all such range checks,
3743 only to the range checks affected by the 2013-03-24 change.
3744 This patch reverts most of the 2013-03-24 change.
3745 * alloc.c (xpalloc, Fgarbage_collect):
3746 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3747 * character.c (string_escape_byte8):
3748 * charset.c (read_hex):
3749 * data.c (cons_to_unsigned):
3750 * dispnew.c (update_frame_1):
3751 * doc.c (Fsubstitute_command_keys):
3752 * doprnt.c (doprnt):
3753 * editfns.c (hi_time, decode_time_components):
3754 * fileio.c (file_offset):
3755 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3756 * font.c (font_intern_prop):
3757 * frame.c (x_set_alpha):
3758 * gtkutil.c (get_utf8_string):
3759 * indent.c (check_display_width):
3760 * keymap.c (Fkey_description):
3761 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3762 * lread.c (read1):
3763 * minibuf.c (read_minibuf_noninteractive):
3764 * process.c (wait_reading_process_output):
3765 * search.c (Freplace_match):
3766 * window.c (get_phys_cursor_glyph):
3767 * xdisp.c (redisplay_internal):
3768 * xsmfns.c (smc_save_yourself_CB):
3769 Prefer < to > for range checks.
3770 * dispnew.c (sit_for): Don't mishandle NaNs.
3771 This fixes a bug introduced in the 2013-03-24 change.
3772 * editfns.c (decode_time_components): Don't hoist comparison.
3773 This fixes another bug introduced in the 2013-03-24 change.
3774
92759988
DA
37752013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3776
3777 * frame.h (struct frame): Drop scroll_bottom_vpos
3778 member becaue all real users are dead long ago.
3779 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3780 * xdisp.c (redisplay_internal): Adjust user.
3781
9a1971bb
GM
37822013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3783
f38ab167
JD
3784 * nsmenu.m (showAtX:Y:for:): setLevel to
3785 NSPopUpMenuWindowLevel (Bug#13998).
3786
6d01f1fe
JD
37872013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3788
3789 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3790 (ns_check_pending_open_menu): Declare.
3791
3792 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3793 (x_activate_menubar): Update the menu with title that matches
3794 ns_get_pending_menu_title, and call
3795 ns_check_pending_openmenu (Bug#12698).
3796 (menuWillOpen:): New method.
3797 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3798
3799 * nsterm.m (menu_will_open_state, menu_mouse_point)
3800 (menu_pending_title): New varaibles.
3801 (ns_get_pending_menu_title, ns_check_menu_open)
3802 (ns_check_pending_open_menu): New functions.
3803
781f4782
DA
38042013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3805
3806 * indent.c (current_column_bol_cache): Remove leftover which is not
3807 used in Fmove_to_column any more.
3808 (current_column, scan_for_column): Adjust users.
3809 * keyboard.c (last_point_position_buffer, last_point_position_window):
3810 Remove leftovers which are not used for recording undo any more.
3811 (command_loop_1, syms_of_keyboard): Adjust users.
3812 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3813 redisplay_window any more.
3814 (move_it_to): Adjust user.
3815
1921c31b
JB
38162013-03-29 Juanma Barranquero <lekktu@gmail.com>
3817
3818 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3819 Update dependencies.
3820
717b8bcd
SM
38212013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3822
3823 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3824 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3825 forward references.
3826
e74aeda8
DA
38272013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3828
3829 * window.h (struct window): Replace hchild, vchild and buffer slots
3830 with the only contents slot. This is possible because each valid
3831 window may have either the child window (in vertical or horizontal
3832 combination) or buffer to display (for the leaf window). Using that,
3833 a lof of operations to traverse and/or change window hierarchies may
3834 be simplified. New member horizontal is used to distinguish between
3835 horizontal and vertical combinations of internal windows.
3836 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3837 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3838 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3839 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3840 Use contents slot, not buffer, where appropriate.
3841 (wset_combination): New function.
3842 (wset_buffer): Add eassert.
3843 (Fframe_first_window): Simplify the loop reaching first window.
3844 (Fwindow_buffer): Use WINDOW_LEAF_P.
3845 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3846 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3847 (unshow_buffer): Convert initial debugging check to eassert.
3848 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3849 (make_parent_window, window_resize_check, window_resize_apply)
3850 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3851 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3852 Adjust to match struct window changes.
3853 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3854 (mark_window_cursors_off, count_windows, get_leaf_windows)
3855 (foreach_window_1): Simplify the loop.
3856 * alloc.c (mark_object): Do not check for the leaf window because
3857 internal windows has no glyph matrices anyway.
3858 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3859 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3860 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3861 (build_frame_matrix_from_window_tree, mirror_make_current)
3862 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3863 (update_window_tree, set_window_update_flags): Simplify the loop.
3864 (sync_window_with_frame_matrix_rows): Enforce live window.
3865 Use contents slot, not buffer, where appropriate.
3866 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3867 and WINDOW_HORIZONTAL_COMBINATION_P.
3868 (make_frame_visible_1): Simplify the loop.
3869 Use contents slot, not buffer, where appropriate.
3870 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3871 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3872 (expose_window_tree): Likewise.
3873 Use contents slot, not buffer, where appropriate.
3874 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3875 to avoid deleted windows. Use contents slot instead of buffer.
3876 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3877 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3878 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3879 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3880
121ab1cd
EZ
38812013-03-28 Eli Zaretskii <eliz@gnu.org>
3882
ef454cf7
EZ
3883 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3884 identify the reasons for assertion violations in bug#14062 and
3885 similar ones.
21e930f8
EZ
3886 (Fx_show_tip): Fix compilation error under
3887 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3888
121ab1cd
EZ
3889 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3890 Reported by <rzl24ozi@gmail.com>.
3891
5c89ca24
DA
38922013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3893
3894 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3895 start marker...
562c6ee9
SM
3896 (unwind_with_echo_area_buffer): ...to restore it here.
3897 This is needed to ensure that...
5c89ca24
DA
3898 (redisplay_window): ...both window markers are valid here,
3899 which is verified by eassert.
3900 * editfns.c (save_excursion_save): Do not assume that
3901 selected_window always displays the buffer.
c7f53895
DA
3902 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3903 Fix comment.
5c89ca24 3904
f557c1b1
SM
39052013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3906
3907 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3908 the upcase table.
3909
40693bba 39102013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3911
3912 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3913
c86f791f
EZ
39142013-03-27 Eli Zaretskii <eliz@gnu.org>
3915
3916 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3917 since MinGW's w32api headers do. This avoids compiler warnings.
3918
3919 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3920 if already defined.
3921
c6e72e17
EZ
39222013-03-26 Eli Zaretskii <eliz@gnu.org>
3923
3924 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3925
54e95010
JD
39262013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3927
3928 * gtkutil.c (style_changed_cb): Check if frame is live and an
3929 X frame (Bug#14038).
3930
b88b62de
EZ
39312013-03-26 Eli Zaretskii <eliz@gnu.org>
3932
a18d7de6
EZ
3933 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3934 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3935 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3936 MinGW64.
8f5e14c8
EZ
3937 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3938 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3939
b88b62de
EZ
3940 Fix incompatibilities between MinGW.org and MinGW64 headers.
3941 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3942
3943 * w32.c (REPARSE_DATA_BUFFER): Guard with
3944 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3945
c074e458
JD
39462013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3947
3948 * xterm.c: Include X11/XKBlib.h
3949 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3950
908589fd
AS
39512013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3952
3953 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3954 written backwards.
3955 * blockinput.h (input_blocked_p): Likewise.
3956 * bytecode.c (exec_byte_code): Likewise.
3957 * callproc.c (call_process_kill, call_process_cleanup)
3958 (Fcall_process): Likewise.
3959 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3960 (Fccl_execute_on_string): Likewise.
3961 * character.c (string_escape_byte8): Likewise.
3962 * charset.c (read_hex): Likewise.
3963 * cm.c (calccost): Likewise.
3964 * data.c (cons_to_unsigned): Likewise.
3965 * dired.c (directory_files_internal, file_name_completion):
3966 Likewise.
3967 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3968 (sit_for): Likewise.
3969 * doc.c (Fsubstitute_command_keys): Likewise.
3970 * doprnt.c (doprnt): Likewise.
3971 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3972 * emacsgtkfixed.c: Likewise.
3973 * fileio.c (file_offset, Fwrite_region): Likewise.
3974 * floatfns.c (Fexpt, fmod_float): Likewise.
3975 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3976 Likewise.
3977 * font.c (font_intern_prop): Likewise.
3978 * frame.c (x_set_alpha): Likewise.
3979 * gtkutil.c (get_utf8_string): Likewise.
3980 * indent.c (check_display_width): Likewise.
3981 * intervals.c (create_root_interval, rotate_right, rotate_left)
3982 (split_interval_right, split_interval_left)
3983 (adjust_intervals_for_insertion, delete_node)
3984 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3985 (merge_interval_right, merge_interval_left, copy_intervals)
3986 (set_intervals_multibyte_1): Likewise.
3987 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3988 * keymap.c (Fkey_description): Likewise.
3989 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3990 * lread.c (openp, read_integer, read1, string_to_number):
3991 Likewise.
3992 * menu.c (ensure_menu_items): Likewise.
3993 * minibuf.c (read_minibuf_noninteractive): Likewise.
3994 * print.c (printchar, strout): Likewise.
3995 * process.c (create_process, Faccept_process_output)
3996 (wait_reading_process_output, read_process_output, send_process)
3997 (wait_reading_process_output): Likewise.
3998 * profiler.c (make_log, handle_profiler_signal): Likewise.
3999 * regex.c (re_exec): Likewise.
4000 * regex.h: Likewise.
4001 * search.c (looking_at_1, Freplace_match): Likewise.
4002 * sysdep.c (get_child_status, procfs_ttyname)
4003 (procfs_get_total_memory): Likewise.
4004 * systime.h (EMACS_TIME_VALID_P): Likewise.
4005 * term.c (dissociate_if_controlling_tty): Likewise.
4006 * window.c (get_phys_cursor_glyph): Likewise.
4007 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4008 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4009 Likewise.
4010 * xfns.c (Fx_window_property): Likewise.
4011 * xmenu.c (set_frame_menubar): Likewise.
4012 * xselect.c (x_get_window_property, x_handle_dnd_message):
4013 Likewise.
4014 * xsmfns.c (smc_save_yourself_CB): Likewise.
4015 * xterm.c (x_scroll_bar_set_handle): Likewise.
4016
2bf7d27a
DA
40172013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4018
4019 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4020 to be optional or nil. Adjust comment and convert it to docstring.
4021 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4022 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4023
a9ebfa0b
PE
40242013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 Static checking by GCC 4.8-20130319.
4027 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4028 * process.c (Fset_process_datagram_address)
4029 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4030 * xdisp.c (get_char_face_and_encoding):
4031 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4032 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4033 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4034
4f3576ee
KB
40352013-03-24 Ken Brown <kbrown@cornell.edu>
4036
789b5e9a
KB
4037 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4038 fix compilation on 64-bit Cygwin, where underscores are not
4039 automatically prepended.
4040
4f3576ee
KB
4041 * w32term.c (w32_initialize): Silence compiler warning.
4042
b5b7745f
EZ
40432013-03-23 Eli Zaretskii <eliz@gnu.org>
4044
cdc0d0bd
EZ
4045 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4046 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4047 variables, to save and restore frame dimensions.
4048 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4049 after returning from a 'fullscreen' configuration.
4050 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4051 to avoid races between the main thread and the input thread.
4052
4053 * w32term.h (struct w32_output): New members normal_width,
4054 normal_height, normal_top, normal_left, and prev_fsmode.
4055 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4056 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4057 members of a frame.
4058
b5b7745f
EZ
4059 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4060 'fullscreen' parameter. Always record previous width and height
4061 of the frame, except when switching out of maximized modes, so
4062 that they could be restored correctly, instead of resetting to the
4063 default frame dimensions. Send SC_RESTORE command to the frame,
4064 unless we are going to send SC_MAXIMIZE, to restore the frame
4065 resize hints in the mouse pointer shown by the window manager.
4066 (Bug#14032)
4067
4068 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4069
4070 * lisp.h (get_frame_param): Adjust conditions for prototype
4071 declaration.
4072
a3454eed
KB
40732013-03-22 Ken Brown <kbrown@cornell.edu>
4074
4075 * unexcw.c: Drop unneeded inclusion of w32common.h.
4076 (report_sheap_usage): Declare.
4077 (read_exe_header): Add magic numbers for x86_64.
4078 (fixup_executable): Fix printf format specifier for unsigned long
4079 argument.
4080
5a49b79c
DA
40812013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4082
4083 * frame.h (struct frame): Put menu_bar_window under #ifdef
4084 because this member is not needed when X toolkit is in use.
4085 (fset_menu_bar_window):
4086 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4087 (free_glyphs, update_frame):
4088 * xdisp.c (expose_frame): Likewise.
4089 (display_menu_bar): Likewise. Remove redundant eassert.
4090 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4091 toolkit is in use.
4092
d6723bf7
PE
40932013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4094
7b1123d8
PE
4095 Use functions and constants to manipulate Lisp_Save_Value objects.
4096 This replaces code that used macros and strings and token-pasting.
4097 The change makes the C source a bit easier to follow,
4098 and shrinks the Emacs executable a bit.
4099 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4100 (make_save_value): Change 1st arg from string to enum. All callers
4101 changed.
4102 (INTX): Remove.
4103 (mark_object): Use if, not #if, for GC_MARK_STACK.
4104 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4105 (XSAVE_OBJECT): Now functions, not macros.
4106 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4107 the constant was never used.
4108 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4109 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4110 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4111 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4112 New constants.
4113 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4114 type3 with a single member save_type. All uses changed.
4115 (save_type, set_save_pointer, set_save_integer): New functions.
4116 * print.c (PRINTX): Remove.
4117
d6723bf7
PE
4118 * alloc.c: Remove redundant static declarations.
4119
5f24fa51
DA
41202013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4121
4122 * window.h (struct window): Convert left_col, top_line, total_lines
4123 and total_cols from Lisp_Objects to integers. Adjust comments.
4124 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4125 Remove.
4126 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4127 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4128 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4129 Adjust users where appropriate.
4130
42143acd
DA
41312013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4132
4133 * frame.h (struct frame): Drop resx and resy because the same data is
4134 available from window system-specific output context. Adjust users.
562c6ee9
SM
4135 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4136 New functions to provide defaults when no window system available.
42143acd 4137 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4138 (NUMVAL): Move from xdisp.c.
42143acd
DA
4139 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4140 (Ffont_face_attributes, Fopen_font):
4141 * image.c (gs_load):
4142 * w32font.c (fill_in_logfont):
4143 * xdisp.c (calc_pixel_width_or_height):
4144 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4145 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4146
c0a17406
KH
41472013-03-20 Kenichi Handa <handa@gnu.org>
4148
4149 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4150 to 1 (temporary workaround until a bug related to ASCII
4151 optimization is fixed).
4152
095d384d
DA
41532013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4154
4155 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4156 Signal error if window is not internal. Adjust docstring.
4157 (delete_all_child_windows): Use combination_limit to save the buffer.
4158 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4159 * print.c (syms_of_print): Initialize debugging output not here...
4160 (init_print_once): ...but in a new function here.
4161 * lisp.h (init_print_once): Add prototype.
4162 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4163
748fa866
DA
41642013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4165
4166 * window.c (window_resize_check, window_resize_apply)
4167 (window_from_coordinates, recombine_windows, set_window_buffer)
4168 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4169 (Fsplit_window_internal, Fdelete_window_internal)
4170 (freeze_window_starts): Use bool for booleans.
4171 * window.h (window_frame_coordinates, resize_frame_windows)
4172 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4173
81519fd2
SM
41742013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4175
4176 * dispnew.c (bitch_at_user): Use `user-error'.
4177
6db423a9
KB
41782013-03-17 Ken Brown <kbrown@cornell.edu>
4179
4180 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4181 as return type of image_background. (Bug#13981)
4182 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4183
8f2906f5
JD
41842013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4185
960ce480 4186 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4187 (ns_select): Don't return with result uninitialized.
960ce480 4188
8f2906f5
JD
4189 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4190 and getDirectory.
4191
81519fd2
SM
4192 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4193 New functions.
8f2906f5
JD
4194 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4195 directories. If filename is nil, get directory name (Bug#13932).
4196 Use getFilename and getDirectory.
4197 (getFilename, getDirectory): New methods for EmacsSavePanel and
4198 EmacsOpenPanel.
4199 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4200
cded56c1
PE
42012013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4204
251e9147 42052013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4206
4207 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4208 (adjust_after_replace): Make it back to static. Delete the third
4209 arg text_at_gap_tail. Cancel the code for handling it.
4210
4211 * coding.h (struct coding_system): New member eol_seen.
4212
4213 * coding.c (detect_ascii): New function.
4214 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4215 when the source bytes are actually scanned. On detecting for
4216 coding_category_utf_8_auto, call detect_ascii instead of scanning
4217 source bytes directly.
4218 (produce_chars): Call insert_from_gap with the new arg 0.
4219 (encode_coding): Likewise.
4220 (decode_coding_gap): Control ASCII optimization by the variable
4221 disable_ascii_optimization instead of #ifndef .. #endif.
4222 Deccode EOL format according to coding->eol_seen.
4223 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4224 variable.
4225
8a44e6d1
KH
4226 * lisp.h (adjust_after_replace): Cancel externing it.
4227 (insert_from_gap): Adjust prototype.
4228
5f795e34
EZ
42292013-03-15 Eli Zaretskii <eliz@gnu.org>
4230
4231 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4232 FULLSCREEN_MAXIMIZED. (Bug#13935)
4233
f258b4be
DA
42342013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4235
4236 * region-cache.c (find_cache_boundary, move_cache_gap)
4237 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4238 Simplify debugging check and convert to eassert. Adjust comment.
4239 (pp_cache): Put under ENABLE_CHECKING.
4240
a5cc4dde
EZ
42412013-03-14 Eli Zaretskii <eliz@gnu.org>
4242
4243 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4244 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4245 and WM_ACTIVATEAPP.
4246 (w32fullscreen_hook): If the frame is visible, reset
4247 f->want_fullscreen flag after changing the frame size. If the
4248 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4249 (Bug#13953)
4250
3fc5e44a
DC
42512013-03-13 Daniel Colascione <dancol@dancol.org>
4252
4253 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4254 too so that these builds can use Cygwin's file conversion
4255 functions. (We've been building and linking cygw32.o all along
4256 and just not using it.)
4257
47d7532e
PE
42582013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 File synchronization fixes (Bug#13944).
4261 * Makefile.in (LIB_FDATASYNC): New macro.
4262 (LIBES): Use it.
4263 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4264 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4265 Don't worry about HAVE_FSYNC, since a substitute fsync is
4266 available if the system lacks one.
4267 (Fwrite_regin): Retry fsync if interrupted.
4268
c7ffccaf
EZ
42692013-03-13 Eli Zaretskii <eliz@gnu.org>
4270
4e2df81d 4271 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4272 activated, call w32fullscreen_hook, to make sure the new frame
4273 dimensions are in effect. (Bug#13937)
4274
8a7debc1
DA
42752013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4276
4277 * xdisp.c (init_iterator): Simplify because both character and byte
4278 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4279 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4280 character and byte positions can be obtained from marker.
8a7debc1 4281
7fd8c501
PE
42822013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4283
d9df6f40
PE
4284 Static checking by Sun C 5.12.
4285 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4286 * bytecode.c (exec_byte_code):
4287 * dispnew.c (init_display):
4288 * eval.c (error):
4289 * fileio.c (Fsubstitute_in_file_name):
4290 * keyboard.c (Fevent_convert_list):
4291 * keymap.c (Fsingle_key_description):
4292 * term.c (maybe_fatal, fatal):
4293 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4294 * xsmfns.c (Fhandle_save_session):
4295 Omit unreachable code.
4296 * keymap.c (map_keymap_char_table_item): Cast void * to
4297 a function pointer type; the C Standard requires this.
4298
7fd8c501
PE
4299 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4300 Include <sys/param.h> unconditionally, as that works elsewhere and
4301 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4302 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4303 and FreeBSD now.
4304
a020afb9 4305See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4306
4307;; Local Variables:
4308;; coding: utf-8
aac0c6e3
MR
4309;; End:
4310
ab422c4d 4311 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4312
4313 This file is part of GNU Emacs.
4314
4315 GNU Emacs is free software: you can redistribute it and/or modify
4316 it under the terms of the GNU General Public License as published by
4317 the Free Software Foundation, either version 3 of the License, or
4318 (at your option) any later version.
4319
4320 GNU Emacs is distributed in the hope that it will be useful,
4321 but WITHOUT ANY WARRANTY; without even the implied warranty of
4322 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4323 GNU General Public License for more details.
4324
4325 You should have received a copy of the GNU General Public License
4326 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.