* lisp/subr.el (decode-char, encode-char): Use advertised-calling-convention
[bpt/emacs.git] / src / ChangeLog
CommitLineData
328a8179
SM
12013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * charset.c (Fdecode_char, Fencode_char): Remove description of
4 `restriction' arg. now that it's hidden by advertised-calling-convention.
5
c348360a
JD
62013-10-02 Jan Djärv <jan.h.d@swipnet.se>
7
328a8179
SM
8 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
9 Remove unused variable (from mac-port).
c348360a
JD
10 (macfont_draw): Use s->ybase for correct y position.
11
1a23cd48
DA
122013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
13
14 * frame.h (struct frame): Drop has_minibuffer member because...
15 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
16 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
17
29bf4de4
DA
182013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
19
20 * window.h (struct window): Prefer enum text_cursor_kinds to int
21 for phys_cursor_type member. Move the latter, phys_cursor_width,
22 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
23 * window.c (replace_window, make_window): Adjust users.
24
a30ddace
DA
252013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
26
27 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
28 this module is never compiled otherwise.
29
45435f08
AA
302013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
31
32 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
33 (Bug#15500).
34
92e5298b
EZ
352013-09-29 Eli Zaretskii <eliz@gnu.org>
36
37 * xdisp.c (get_next_display_element): Don't call face_for_font in
38 a build configured --without-x. (Bug#15484)
39
caa50be2
JD
402013-09-29 Jan Djärv <jan.h.d@swipnet.se>
41
66d13b20
JD
42 * window.c (calc_absolute_offset): #elif should be #elif defined.
43
caa50be2
JD
44 * frame.c (delete_frame): Block/unblock input to overcome race
45 condition (Bug#15475).
46
d3e2acb6
AP
472013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
48
49 * frame.c (delete_frame): Record selected frame only after
50 calling Qdelete_frame_functions (Bug#15477).
51
1610938f
JD
522013-09-28 Jan Djärv <jan.h.d@swipnet.se>
53
54 * nsterm.m (ns_selection_color): Remove.
55 (ns_get_color): Check for ns_selection_(fg|bg)_color using
56 NSColor selectedText(Background)Color. Only for COCOA.
57 (ns_term_init): Remove assignment of ns_selection_color, logic
58 moved to ns_get_color.
59
328a8179 60 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
61 NS_SELECTION_COLOR_DEFAULT.
62 (NS_SELECTION_FG_COLOR_DEFAULT): New.
63
0d2647e6
EZ
642013-09-28 Eli Zaretskii <eliz@gnu.org>
65
66 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
67 frame' does not have the tool_bar_window member.
68
ba355de0
BR
692013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
70
71 Signal error when reading an empty byte-code object (Bug#15405)
72 * lread.c (read1): signal error
73 * alloc.c (make_byte_code): eassert header size
74 (sweep_vectors): change an int to size_t
75
4710d6f4
PE
762013-09-24 Paul Eggert <eggert@cs.ucla.edu>
77
cf647d93
PE
78 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
79 instead of ints, as it's the usual style for offsetof constants. See:
80 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
81
4710d6f4
PE
82 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
83 This is ugly, but it should fix the performance problem for older
84 GCC versions in the short run. I'll look into integrating the
85 Gnulib module for popcount, as a better fix.
86 See the thread starting in:
87 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
88 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
89 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
90 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
91 (popcount_size_t): Use it.
92
10ebac9d
DC
932013-09-24 Daniel Colascione <dancol@dancol.org>
94
95 * process.c (Fnetwork_interface_info): Fix build break due to
96 vector changes.
97
9da0f50e
PE
982013-09-24 Paul Eggert <eggert@cs.ucla.edu>
99
100 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
101 Prefer signed to unsigned integers where either will do.
102 No need for 'const' on locals that do not escape.
103 Omit easserts with unnecessary and unportable assumptions about
104 alignment. Avoid unnecessary casts to char *.
105
d6d9cbc1
DA
1062013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
107
108 Use union for the payload of struct Lisp_Vector.
109 This helps to avoid a few glitches dictated by C's aliasing rules.
110 * lisp.h (struct Lisp_Vector): Use union for next and
111 contents member. Adjust comment. Change related users.
112 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
113 Related users changed.
114 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
115 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
116 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
117 * xfaces.c, xfont.c, xmenu.c: Related users changed.
118
ec7bc82f
DA
1192013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
120
121 Optimize glyph row clearing and copying routines.
122 * dispextern.h (struct glyph_row): Change layout of struct
123 glyph_row to help copy_row_except_pointers. Adjust comment.
124 * dispnew.c (null_row): Remove.
125 (clear_glyph_row): Use offsetof and memset to find and clear
126 just the members that need clearing. Adjust comment.
127 (copy_row_except_pointers): Likewise for copying.
128
d160dd0c
PE
1292013-09-24 Paul Eggert <eggert@cs.ucla.edu>
130
7be68de5
PE
131 Some minor cleanups of recently-added bool vector code.
132 * conf_post.h (assume): Always return void. Use lint version
133 only if GCC and MSC versions don't apply.
134 * conf_post.h (assume):
135 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
136 Depend on _MSC_VER, not __MSC_VER, for consistency with
137 the rest of Emacs.
138 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
139 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
140 (bool_vector_binop_driver, count_trailing_zero_bits)
141 (size_t_to_host_endian): Now static, not static inline;
142 the latter isn't needed with modern compilers and doesn't
143 work with older compilers anyway.
144
d160dd0c
PE
145 * alloc.c (valgrind_p): Use bool for boolean.
146
e08813d0
DA
1472013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
148
149 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
150 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
151 (display_last_displayed_message_p, message_buf_print)
152 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
153 Use bool for boolean.
3a6a78fd
DA
154 * dispextern.h (cancel_line, init_desired_glyphs):
155 Remove ancient leftover.
156 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
157 * lisp.h (noninteractive_need_newline): Adjust declaration.
158
5492865b
DA
1592013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
160
161 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
162 Move to...
163 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
164 ...this file and convert the latter to static. Adjust comment.
165 (make_initial_frame):
166 * window.c (init_window_once): Adjust user.
167 * frame.h (last_nonminibuf_frame): Remove declaration.
168 * lisp.h (selected_frame): Likewise.
169 * msdos.c (the_only_display_info): Adjust comment.
170
cd548fa4
EZ
1712013-09-23 Eli Zaretskii <eliz@gnu.org>
172
f03eddbf
EZ
173 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
174 computing the end column of mouse-highlight that comes from
175 display or overlay strings. (Bug#15437)
b519df23
EZ
176 (note_mouse_highlight): Adapt calculation of last argument to
177 mouse_face_from_string_pos to the above change.
f03eddbf 178
cd548fa4
EZ
179 * conf_post.h (__has_builtin): Define to zero, if undefined, on
180 all platforms, not just for clang.
181
8762e524
JD
1822013-09-23 Jan Djärv <jan.h.d@swipnet.se>
183
184 * filelock.c (lock_file_1): Rearrange to remove compiler warning
185 about excess arguments to snprintf.
186
187 * conf_post.h(assume): Use __builtin_unreachable for clang.
188
d4a9284f
JB
1892013-09-23 Juanma Barranquero <lekktu@gmail.com>
190
191 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
192 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
193
a84683fd
DC
1942013-09-23 Daniel Colascione <dancol@dancol.org>
195
196 * alloc.c (USE_VALGRIND): New macro; on by default
197 when ENABLE_CHECKING.
198 (mark_maybe_object,mark_maybe_pointer)
199 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
200 valgrind purposes.
201 (valgrind_p) [USE_VALGRIND]: New variable.
202 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
203
8fef36c6
JD
2042013-09-22 Jan Djärv <jan.h.d@swipnet.se>
205
fb83ea63
JD
206 * process.c (wait_reading_process_output): Change int pnamelen to
207 socklen_t.
208
209 * nsterm.m (setMarkedText:selectedRange:):
210 (deleteWorkingText):
211 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
212 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
213 argument to unsigned long to avoid warning.
214 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
215
8fef36c6
JD
216 * conf_post.h (assume): Fix compiler error: x shall be cond.
217
cd9356f2
DC
2182013-09-22 Daniel Colascione <dancol@dancol.org>
219
220 * xfns.c (x_get_monitor_attributes): Suppress unused variable
221 warning when compiling without a window system.
222
3e0b94e7
DC
2232013-09-22 Daniel Colascione <dancol@dancol.org>
224
225 * data.c (Qbool_vector_p): New symbol.
226 (bool_vector_spare_mask,popcount_size_t_generic)
227 (popcount_size_t_msc,popcount_size_t_gcc)
228 (popcount_size_t)
229 (bool_vector_binop_driver)
230 (count_trailing_zero_bits,size_t_to_host_endian)
231 (Fbool_vector_exclusive_or)
232 (Fbool_vector_union)
233 (Fbool_vector_intersection,Fbool_vector_set_difference)
234 (Fbool_vector_subsetp,Fbool_vector_not)
235 (Fbool_vector_count_matches)
236 (Fbool_vector_count_matches_at): New functions.
237 (syms_of_data): Intern new symbol, functions.
238 * alloc.c (bool_vector_payload_bytes): New function.
239 (Fmake_bool_vector): Instead of calling Fmake_vector,
240 which performs redundant initialization and argument checking,
241 just call allocate_vector ourselves. Make sure we clear any
242 terminating padding to zero.
243 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
244 instead of open-coding the size calculation.
245 (vroundup_ct): New macro.
246 (vroundup): Assume argument >= 0; invoke vroundup_ct.
247 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
248 * composite.c (composition_gstring_put_cache):
249 Change lint_assume to assume.
3e0b94e7
DC
250 * conf_post.h (assume): New macro.
251 (lint_assume): Remove.
252 * dispnew.c (update_frame_1): Change lint_assume to assume.
253 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
254 to assume.
255 * image.c (gif_load): Change lint_assume to assume.
256 * lisp.h (eassert_and_assume): New macro.
257 (Qbool_vector_p): Declare.
258 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
259 (swap16,swap32,swap64): New inline functions.
260 * macfont.c (macfont_shape): Change lint_assume to assume.
261 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
262 * xsettings.c (parse_settings): Use new swap16 and
263 swap32 from lisp.h instead of file-specific macros.
264
76880d88
EZ
2652013-09-22 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (try_window_id): Don't abort if cursor row could not be
268 found (which can legitimately happen when the glyph row at the
269 window start is disabled in the current_matrix. (Bug#15365)
270
c6cfd910
PE
2712013-09-22 Paul Eggert <eggert@cs.ucla.edu>
272
273 Fix syntax.h bug introduced by recent INLINE change.
274 syntax.h defined an extern inline function SYNTAX_ENTRY that was
275 conditionally compiled one way in some modules, and a different
276 way in others. This doesn't work with extern inline functions,
277 which must have the same definition in all modules, because the
278 defining code might be shared across modules, depending on the
279 implementation. Symptoms reported by Martin Rudalics in:
280 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
281 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
282 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
283 overriding the corresponding functions in syntax.h.
284 * syntax.h (syntax_property_entry, syntax_property_with_flags)
285 (syntax_property): New inline functions.
286 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
287 Rewrite in terms of these new functions.
288
b3f1d119
EZ
2892013-09-21 Eli Zaretskii <eliz@gnu.org>
290
291 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
292 not chars_in_text, whose result depends on the multibyteness of
293 the current buffer. (Bug#15426)
294
00382e8b
PE
2952013-09-20 Paul Eggert <eggert@cs.ucla.edu>
296
e3b29769
PE
297 Port recent change to hosts where pointers aren't 'long'.
298 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
299 Don't assume that pointers are the same width as 'long'.
300 Add a compile-time check that a pointer fits into two X slots.
301
00382e8b
PE
302 A simpler, centralized INLINE.
303 * conf_post.h (INLINE): Define only if not already defined.
304 This allows us to use a single INLINE, defined by one file
305 per executable.
306 * emacs.c (INLINE): Define it.
307 Also, include category.h, charset.h, composite.h, dispextern.h,
308 syntax.h, systime.h, so that their INLINE definitions are expanded
309 properly for Emacs.
310 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
311 * buffer.h, buffer.c (BUFFER_INLINE):
312 * category.h, category.c (CATEGORY_INLINE):
313 * character.h, character.c (CHARACTER_INLINE):
314 * charset.h, charset.c (CHARSET_INLINE):
315 * composite.h, composite.c (COMPOSITE_INLINE):
316 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
317 * frame.h, frame.c (FRAME_INLINE):
318 * intervals.h, intervals.c (INTERVALS_INLINE):
319 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
320 * lisp.h, alloc.c (LISP_INLINE):
321 * process.h, process.c (PROCESS_INLINE):
322 * syntax.h, syntax.c (SYNTAX_INLINE):
323 * systime.h, sysdep.c (SYSTIME_INLINE):
324 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
325 * window.h, window.c (WINDOW_INLINE):
326 Remove. All uses replaced with INLINE.
327
2b943ba6
DA
3282013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
329
330 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
331 to avoid Bug#15398.
332
13d9698a
EZ
3332013-09-19 Eli Zaretskii <eliz@gnu.org>
334
335 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
336 'const char *' to avoid compiler warnings due to similar change in
337 the prototype of x_get_string_resource.
338
ced135eb
DA
3392013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
340
341 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
342 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
343 going to replace static variables below. Adjust comments.
344 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
345 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
346 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
347 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
348 Related users changed.
349 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
350 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
351 last_mouse_movement_time, going to replace static variables below.
352 Adjust comments.
353 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
354 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
355 Remove.
356 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
357 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
358 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
359 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
360 static variables below.
361 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
362 (last_mouse_scroll_bar): Remove.
363 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
364 (mouseExited): Related users changed.
365
091f1e1f
DA
3662013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
367
368 Do not use external array to process X scroll bar messages.
369 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
370 (x_send_scroll_bar_event): Pack window pointer into two slots
371 of XClientMessageEvent if we're 64-bit. Adjust comment.
372 (x_scroll_bar_to_input_event): Unpack accordingly.
373
582ed56c
DA
3742013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
375
376 Ifdef away recent changes which aren't relevant to NS port.
377 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
378 [!HAVE_NS]: Declare as such.
379 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
380 [!HAVE_NS]: Define as such.
381
18da0d8a
DA
3822013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
383
384 * frame.c (x_redo_mouse_highlight): New function
385 to factor out common code used in W32 and X ports.
386 * dispextern.h (x_redo_mouse_highlight): Add prototype.
387 * xterm.h (struct x_display_info):
388 * w32term.h (struct w32_display_info):
389 * nsterm.h (struct ns_display_info): New members
390 last_mouse_motion_frame, last_mouse_motion_x and
391 last_mouse_motion_y, going to replace static variables below.
392 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
393 (redo_mouse_highlight): Remove.
394 (note_mouse_movement, syms_of_xterm): Adjust user.
395 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
396 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
397 (redo_mouse_highlight): Remove.
398 (note_mouse_movement, syms_of_w32term): Adjust user.
399 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
400 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
401 Remove.
402 (note_mouse_movement, mouseMoved, syms_of_nsterm):
403 * nsfns.m (compute_tip_xy): Adjust user.
404
7a0c745a
DA
4052013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
406
407 * frame.c (x_mouse_grabbed): New function.
408 * dispextern.h (x_mouse_grabbed): Add prototype.
409 (last_mouse_frame): Remove declaration.
410 * xterm.h (struct x_display_info):
411 * w32term.h (struct w32_display_info):
412 * nsterm.h (struct ns_display_info): New member
413 last_mouse_frame, going to replace...
414 * xdisp.c (last_mouse_frame): ...global variable.
415 (note_tool_bar_highlight):
416 * w32term.c (w32_mouse_position, w32_read_socket):
417 * xterm.c (XTmouse_position, handle_one_xevent):
418 Use x_mouse_grabbed.
419 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
420
0791d107
DA
4212013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
422
423 * w32term.c (w32_read_socket): Avoid temporary
424 variables in a call to x_real_positions.
425 * xterm.c (handle_one_xevent): Likewise.
426
2cd98812
DA
4272013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
428
429 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
430 (x_icon_type): Remove prototype.
431 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
432 * frame.c (x_icon_type): Remove.
433 * w32term.c (x_make_frame_visible, x_iconify_frame):
434 * xterm.c (x_make_frame_visible, x_iconify_frame):
435 Use x_set_bitmap_icon to factor out common code.
436
a6c2ee1b
DA
4372013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
438
439 * dispextern.h (check_x_display_info, x_get_string_resource):
440 Declare here just once and unify the latter.
441 * frame.c (check_x_display_info, x_get_string_resource):
442 * nsterm.h (check_x_display_info):
443 * xrdb.c (x_get_string_resource):
444 * xterm.h (check_x_display_info): Remove prototypes.
445 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
446 * w32reg.c (x_get_string_resource): Likewise.
447 (w32_get_rdb_resource): Adjust user.
448
baed3603
DA
4492013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
450
451 * xterm.h (struct x_display_info): New member
452 x_pending_autoraise_frame, going to replace...
453 * xterm.c (pending_autoraise_frame): ...static variable.
454 (x_new_focus_frame, XTread_socket): Adjust users.
455 * w32term.h (struct w32_display_info): New member
456 w32_pending_autoraise_frame, going to replace...
457 * w32term.c (pending_autoraise_frame): ...global variable.
458 (x_new_focus_frame, w32_read_socket): Adjust users.
459
90582f05
GM
4602013-09-17 Glenn Morris <rgm@gnu.org>
461
462 * xdisp.c (message_dolog): If we create *Messages*,
463 switch it to messages-buffer-mode.
464
b7ad2f74
PE
4652013-09-17 Paul Eggert <eggert@cs.ucla.edu>
466
467 Don't overuse 'const' in types of locals.
468 * bidi.c (bidi_count_bytes):
469 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
470 (xg_event_is_for_scrollbar):
471 * xselect.c (x_handle_property_notify)
472 (x_handle_selection_notify, x_handle_dnd_message):
473 * xsettings.c, xsettings.h (xft_settings_event):
474 * xterm.c (x_handle_net_wm_state, handle_one_event)
475 (x_menubar_window_to_frame, x_detect_focus_change)
476 (construct_mouse_click, note_mouse_movement)
477 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
478 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
479 (handle_one_xevent, x_handle_net_wm_state):
480 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
481 (x_handle_dnd_message):
482 Avoid unnecessary 'const', typically the second 'const' in
483 'const foo * const arg', a 'const' that does not affect the API
484 and doesn't significantly help the human reader.
485
19452b86
DA
4862013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
487
488 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
489 only if Glib < 2.36.0.
490 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
491 * xsettings.c (init_gconf, init_gsettings): Do not check
492 for g_type_init.
1893694e
DA
493 * xterm.c (handle_one_xevent): Do not call to x_clear_area
494 if GTK >= 2.7.0.
33b83dd7 495 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 496
6434e343
JD
4972013-09-16 Jan Djärv <jan.h.d@swipnet.se>
498
3f386383
JD
499 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
500 before calling g_type_init.
501
6434e343
JD
502 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
503
504 * nsterm.m (syms_of_nsterm): ... to here.
505
83a119f8
DA
5062013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
507
508 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
509 (ignore_next_mouse_click_timeout): Use Time as X does.
510 (handle_one_xevent): Avoid cast and use unsigned comparison.
511
61582e6a
DA
5122013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
513
514 Do not copy X event in handle_one_xevent except KeyPress case.
515 Wnen XEvent is processed, it is unlikely to be changed except
516 KeyPress case, so we can avoid copying and use const pointer to
517 const data to make sure that an event is not changed elsewhere.
518 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
519 const' and do not create local copy except for the KeyPress event.
520 Use casts to avoid a few glitches. Adjust formatting. Add comments.
521 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
522 (x_handle_net_wm_state, x_menubar_window_to_frame)
523 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
524 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
525 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
526 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
527 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
528 (x_handle_dnd_message):
529 * xsettings.c (xft_settings_event):
530 Use 'const XEvent * const' where appropriate.
531 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
532
f8eb1572
DA
5332013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
534
535 Fix X event waiting to handle multiple frames.
536 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
537 * xterm.c (pending_event_wait): Remove. Adjust users.
538 (x_detect_focus_change): Pass frame arg.
539 (handle_one_xevent): Find related frame early and clear per-frame
540 wait_event_type only if this is an event for the relevant frame.
541 (x_wait_for_event): Use per-frame wait_event_type.
542
3fa2054e
JD
5432013-09-15 Jan Djärv <jan.h.d@swipnet.se>
544
745d3809
JD
545 * nsfns.m (Fx_create_frame): Fix font driver registration for
546 GNUStep.
547
548 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
549 for syms_of_macfont.
550
3fa2054e
JD
551 * nsterm.m: Include macfont.h.
552 (ns_tmp_flags, ns_tmp_font): Remove.
553 (ns_compute_glyph_string_overhangs): Check for driver Qns.
554 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
555 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
556 (changeFont:): Fix code style. Check for font driver type when
557 getiing font.
558
559 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
560 (f)->descent.
561
562 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
563 (nsfont_open): Set font driver type.
564 Set font->ascent and font->descent. Figure out font instead of
565 ns_tmp_font, and flags instead of ns_tmp_flags.
566 Fix indentation. Remove call to ns_draw_text_decoration,
567 moved to nsterm.
568
569 * nsfns.m: Include macfont.h.
570 (Fx_create_frame): Register macfont driver, make a better default font.
571 (Fns_popup_font_panel): Get font from macfont driver, if used.
572
573 * macfont.m, macfont.h, maccuvs.h: New files.
574
575 * font.h: Declare syms_of_macfont.
576
577 * font.c (syms_of_font): Call syms_of_macfont.
578
579 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
580
0eed0355
DA
5812013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
582
583 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
584 and it is always zero for others, so I assume that this is an ancient
585 leftover which nobody will want to change any more.
586 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
587 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
588 * frame.c (x_set_scroll_bar_width):
589 * w32fns.c (w32_createscrollbar):
590 * w32term.c (w32_set_vertical_scroll_bar):
591 * xfns.c (x_set_scroll_bar_default_width):
592 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
593 (x_scroll_bar_expose): Related users changed.
594
07013c68
DA
5952013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
596
597 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
598 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
599 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
600 Define as such.
c7cc32f7
DA
601 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
602 Define once here...
603 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
604 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
605 Remove unused Xisms.
7f09455e
DA
606 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
607 these modules are never compiled otherwise.
07013c68 608
0df00f59
EZ
6092013-09-14 Eli Zaretskii <eliz@gnu.org>
610
08a209bf 611 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
612 Doc fix. (Bug#15375)
613
fcd42c11
DA
6142013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
615
616 Unify Fx_focus_frame between all ports.
617 * frame.h (x_focus_frame): New prototype.
618 * xfns.c (Fx_focus_frame): Remove.
619 (syms_of_xfns): Do not defsubr it.
620 (x_focus_frame): X implementation.
621 * nsfns.m (Fx_focus_frame): Remove.
622 (syms_of_nsfns): Do not defsubr it.
623 (x_focus_frame): NS implementation.
624 * w32term.c (Fx_focus_frame): Remove.
625 (x_focus_on_frame): Rename to...
626 (x_focus_frame): W32 implementation.
627 * w32term.h (x_focus_on_frame): Remove prototype.
628 * w32fns.c (Fx_focus_frame): Remove.
629 (syms_of_w32fns): Do not defsubr it.
630 * frame.c (Fx_focus_frame): Define here.
631 (syms_of_frame): Defsubr here.
632 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
633
aad3612f
DA
6342013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
635
636 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
637 All of them are replaced with FRAME_DISPLAY_INFO, defined in
638 each port to reference the port-specific window system data.
639 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
640 (FRAME_DISPLAY_INFO): Define.
641 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
642 (FRAME_DISPLAY_INFO): Define. Adjust users.
643 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
644 (FRAME_DISPLAY_INFO): Define. Adjust users.
645 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
646 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
647 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
648 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
649 * xselect.c, xterm.c: All related users changed.
650
9a650e62
DA
6512013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
652
653 * xterm.h (x_window_to_frame, x_any_window_to_frame)
654 (x_menubar_window_to_frame): Remove prototypes.
655 * xfns.c (x_window_to_frame, x_any_window_to_frame)
656 (x_menubar_window_to_frame, x_top_window_to_frame):
657 Move from here...
658 * xterm.c (x_window_to_frame, x_any_window_to_frame)
659 (x_menubar_window_to_frame, x_top_window_to_frame):
660 ...to here and convert all but the last to static.
661
347ae3e1
EZ
6622013-09-12 Eli Zaretskii <eliz@gnu.org>
663
664 * lisp.mk (lisp): Add w32-common-fns.elc.
665
15c6d837
XF
6662013-09-12 Xue Fuqiao <xfq.free@gmail.com>
667
668 * charset.c (char_charset): Document an exception for char-charset.
669
27e90f77
DA
6702013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
671
672 * xterm.h (x_display_info): New field last_user_time...
673 * xterm.c (toplevel): ...to replace static last_user_time.
674 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
675
8ffbc36b
DA
6762013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
677
678 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
679 scroll bar values to prevent thumb from disappear and update comment.
680
5ec0337a
GM
6812013-09-11 Glenn Morris <rgm@gnu.org>
682
683 * emacs.c (usage_message): Possessive apostrophe tweak.
684
fb55b9d1
DA
6852013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
686
8d2db8be
DA
687 * nsterm.m (syms_of_nsterm): Use Qns.
688 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
689 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
690 * xfns.c (x_display_info_for_name, Fx_open_connection):
691 Remove old '#if 0' code.
692 (syms_of_xfns): Use Qx.
fb55b9d1
DA
693 * termhooks.h (fullscreen_hook): Remove the leftover.
694 (struct terminal): Fix typo in comment.
695
927eec55
DA
6962013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
697
698 Cleaning up a few X scroll bar bits.
699 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
700 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
701 New member last_seen_part, going to replace...
702 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
703 (xt_action_hook) [USE_LUCID]: Adjust user.
704 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
705 Lucid-specific scroll bar support.
706 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
707 to int and adjust to use last_seen_part member.
708 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
709 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
710 Initialize last_seen_part.
711
71b28baa
SM
7122013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
713
714 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
715 insert-buffer-substring an empty string.
716
f5dacaae
PE
7172013-09-11 Paul Eggert <eggert@cs.ucla.edu>
718
719 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
720 avoiding a GCC warning.
721
742516e0
DA
7222013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
723
724 Ifdef away frame tool bar code when it is not really used.
725 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
726 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
727 and minimize_tool_bar_window_p under the above.
728 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
729 (fset_tool_bar_window): Likewise.
730 * dispnew.c (clear_current_matrices, clear_desired_matrices)
731 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
732 (change_frame_size_1):
733 * window.c (window_from_coordinates, Frecenter): Adjust users.
734 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
735 code is not really used.
736 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
737 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
738 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
739 [!USE_GTK && !HAVE_NS]: Define as such.
740 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
741 (note_mouse_highlight, expose_frame):
742 * xfns.c (x_set_tool_bar_lines):
743 * xterm.c (handle_one_xevent): Adjust users.
744
73f82c7e
PE
7452013-09-11 Paul Eggert <eggert@cs.ucla.edu>
746
747 Fix corruption with multiple emacsclient -t instances (Bug#15222).
748 This bug was introduced by my 2013-08-26 patch, which incorrectly
749 assumed that the terminfo implementation doesn't use termcap buffers.
750 * term.c (init_tty) [TERMINFO]: Remove optimization, as
751 these buffers apparently are used after all.
752 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
753 (struct tty_display_info): Define members termcap_term_buffer and
754 termcap_strings_buffer even if TERMINFO.
755
53482f41
DA
7562013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
757
758 Fix last change.
759 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
760 'usage' docstring entry to pacify make-docfile.
761
7622013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
763
764 Change comparison functions =, <, >, <=, >= to take many arguments.
765 * data.c: Change comparison functions' interface and implementation.
766 * lisp.h: Make arithcompare available for efficient two arg
767 comparisons.
768 * bytecode.c: Use arithcompare.
769 * fileio.c: Use new interface.
770
533f258f
SM
7712013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
772
773 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
774
8c27f5ff
SM
7752013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
776
777 * eval.c (Feval): Document the new use of `lexical'.
778
0750a308
DA
7792013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
780
781 Review and drop old frame resize hack.
782 * frame.h (struct frame): Remove force_flush_display_p.
783 * dispnew.c (update_frame): Adjust user and don't call
784 flush_frame here. The comment has said that there was an issues
785 with redisplaying fringes, but I don't see any differences with
786 and without this hack. Hopefully we can continue without it.
787 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
788 current frame matrices twice if resized_p is set.
789
83fc0554
DA
7902013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
791
792 Do not populate pure Xism x_sync to other ports.
793 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
794 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
795 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
796 * w32term.h (x_sync): Remove prototype.
797
fd462129
DA
7982013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
799
800 Cleanup frame flushing.
8c27f5ff
SM
801 * dispextern.h (struct redisplay_interface):
802 Drop flush_display_optional because flush_display is enough
fd462129
DA
803 for X and flushing via RIF is just a no-op for others.
804 * frame.h (flush_frame): New function.
805 * dispnew.c (update_frame):
806 * minibuf.c (read_minibuf):
807 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
808 Use it.
809 * keyboard.c (detect_input_pending_run_timers): Do not flush
810 all frames but selected one in redisplay_preserve_echo_area.
811 * nsterm.m (ns_flush): Remove no-op.
812 (ns_redisplay_interface): Adjust user.
813 * w32term.h (x_flush): Remove no-op.
814 (w32_redisplay_interface): Adjust user.
815 * xterm.c (x_flush): Simplify because we do not flush all
816 frames at once any more. Adjust comment.
817 (x_redisplay_interface): Adjust user.
818
4b73fc73
PE
8192013-09-07 Paul Eggert <eggert@cs.ucla.edu>
820
821 Port --without-x --enable-gcc-warnings to Fedora 19.
822 * gfilenotify.c (globals_of_gfilenotify):
823 Call g_type_init only if using an older glib version that needs it.
824
77394d40
DA
8252013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
826
827 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
828 (last_glyphless_glyph_merged_face_id): Remove declarations.
829 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
830 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
831 (last_glyphless_glyph_merged_face_id): Now static.
832 (merge_escape_glyph_face): New function, refactored from...
833 (get_next_display_element): ...here.
834 (merge_glyphless_glyph_face): New function, refactored from...
835 (produce_glyphless_glyph): ...here...
836 * term.c (produce_glyphless_glyph): ...and here.
837
306d67bd
SM
8382013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
839
840 * eval.c (eval_sub): Only call Ffunction if necessary.
841
7f6c6450
DA
8422013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
843
844 Attempt to make redisplay more selective when changing cursor type.
845 * frame.h (struct frame): New bitfield cursor_type_changed.
846 * xdisp.c (cursor_type_changed): Remove.
847 (try_cursor_movement, redisplay_window, try_window_id)
848 (set_frame_cursor_types, try_window_reusing_current_matrix):
849 Adjust to use per-frame bitfield.
850 (redisplay_internal): Look for cursor type change on each visible
851 frame and consider all frames if cursor type has been changed on
852 the frame other than selected. If cursor type has been changed on
853 selected frame only, do not use fast update.
854
bd0443bb
DA
8552013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
856
857 Attempt to make redisplay more selective when changing fonts.
858 * frame.h (struct frame): New bitfield fonts_changed.
859 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
860 (adjust_frame_glyphs): Add prototype.
861 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 862 (adjust_glyphs): Remove because we do not
bd0443bb
DA
863 adjust matrices on all frames at once any more.
864 (adjust_frame_glyphs): Block and unblock input here.
865 (adjust_glyph_matrix): Use fonts_changed.
866 (change_frame_size_1): Use adjust_frame_glyphs.
867 * font.c (font_open_entity): Use fonts_changed.
868 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
869 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
870 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
871 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
872 (shrink_mini_window, Fresize_mini_window_internal)
873 (window_scroll_pixel_based, Fset_window_configuration)
874 (apply_window_adjustment, Fset_window_vscroll):
875 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
876 Use adjust_frame_glyphs.
877 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
878 (try_window_reusing_current_matrix, try_window_id, display_line)
879 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
880 (redisplay_internal): Consider fonts_changed and adjust frame
881 matrices for each frame only if the frame is visible. If font
882 has been changed on some frame during full redisplay, retry
883 only visible frames where the font has been actually changed.
884
b9695828
DA
8852013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
886
887 Cache current header and mode line height for each window.
888 * window.h (struct window): New fields mode_line_height
889 and header_line_height.
890 * window.c (make_window): Initialize them.
891 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
892 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
893 (current_mode_line_height, current_header_line_height):
894 Remove declaration.
895 * xdisp.c (current_mode_line_height, current_header_line_height):
896 Remove.
897 (pos_visible_p, init_xdisp): Adjust user.
898 (redisplay_window): Invalidate mode_line_height and
899 header_line_height if current and desired matrices do not agree.
900
66738305
DA
9012013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
902
903 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
904 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
905
257b3b03
DA
9062013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
907
908 Make --without-x compatible with --enable-gcc-warnings.
909 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
910 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
911 members under HAVE_WINDOW_SYSTEM.
912 * keyboard.c (make_lispy_focus_out): Likewise.
913 (record_menu_key): Move under HAVE_MENUS.
914 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
915 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
916 (syms_of_xdisp): Adjust user.
917 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
918 (start_hourglass, cancel_hourglass):
919 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
920 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
921 and CLEAR_FONT_TABLE_NFONTS.
922 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
923 Declare only if HAVE_WINDOW_SYSTEM.
924 (lface_same_font_attributes_p, clear_face_gcs): Define only
925 if HAVE_WINDOW_SYSTEM.
926
98b7f4bd
DA
9272013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
928
929 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
930 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
931 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
932
a7e43722
SM
9332013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
934
935 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
936
0c90b9ee
PE
9372013-09-04 Paul Eggert <eggert@cs.ucla.edu>
938
939 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
940 This fixes a type error on hosts where ptrdiff_t is wider than int.
941
d99760fa
SM
9422013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
943
6629638e
SM
944 * keyboard.c (read_key_sequence_vs): New function.
945 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
946 common code.
947
d99760fa
SM
948 * callint.c (Fcall_interactively): Always return a vector for 'K'.
949
224e313d
PE
9502013-09-04 Paul Eggert <eggert@cs.ucla.edu>
951
952 Makefile improvements.
953 * Makefile.in (config.status): Don't use double-colon rules, as
954 they are not portable according to POSIX. Fix shell typo with `;
955 I guess this rule has never been tested?
956 (VCSWITNESS): New macro, to override any environment var.
957
6d6ed1af
DA
9582013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
959
960 * xterm.h (struct x_display_info): Do not track X connection
961 fd separately because it is always available from Display.
962 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
963 Adjust users.
964
bc923770
DA
9652013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
966
967 * buffer.c (drop_overlay):
968 * fileio.c (restore_point_unwind): Prefer unchain_marker to
969 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
970
b1cf96de
DA
9712013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
972
973 * buffer.c (Fmake_overlay, Fmove_overlay):
974 * intervals.c (set_point_from_marker):
975 * print.c (PRINTPREPARE): Prefer signal_error
976 to plain error and report unsuitable marker too.
977
d1fc6c21
DA
9782013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
979
980 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
981 for 'dragging' member.
d1ae6a0b
DA
982 (struct x_output): Remove set-but-unused leftovers
983 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
984 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
985 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
986 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
987 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
988 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
989 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 990 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 991 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 992
0ce9f6de
JD
9932013-09-03 Jan Djärv <jan.h.d@swipnet.se>
994
995 * nsfont.m (INVALID_GLYPH): New define.
996 (nsfont_encode_char): Use INVALID_GLYPH.
997 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
998
b594a96c
DA
9992013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1000
1001 * xterm.c (x_last_mouse_movement_time): Revert last change.
1002 This code should use XDisplayMotionBufferSize to check display's
1003 motion history first, and there are few other issues as well.
1004 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1005 (handle_one_xevent): Adjust user.
1006
8b098236
MR
10072013-09-02 Martin Rudalics <rudalics@gmx.at>
1008
9718b207
MR
1009 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1010 * frame.c (Flast_nonminibuf_frame): ... to here.
1011 (check_minibuf_window): Don't abort if no window was found
1012 (Bug#15247).
8b098236 1013
84e70bba
DA
10142013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1015
1016 Use XGetMotionEvents to ask the last mouse motion time from X server.
1017 * xterm.c (X_MOTION_HISTORY): Default to 1.
1018 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1019 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1020 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1021 Ifdef away legacy code.
1022 (XTmouse_position, x_scroll_bar_report_motion):
1023 Use x_last_mouse_movement_time.
fc85e20b
DA
1024 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1025 UnmapNotify event.
84e70bba 1026
1fccc530
DA
10272013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1028
1029 * msdos.c (last_mouse_window): Move to...
1030 (dos_rawgetc): ...this function and adjust comment.
1031 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1032 (mouseMoved): ...this function and adjust comment.
1033 * w32term.c (last_window): Likewise with...
1034 (w32_read_socket): ...this function.
1035 * xterm.c (last_window): Likewise with...
1036 (handle_one_xevent): ...this function.
1037
0ab10992
DA
10382013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1039
b7da754d 1040 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1041 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1042 (handle_one_xevent): ...to here.
1043 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1044 otherwise.
1045
0c7f856e
DA
10462013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 * msdos.c (IT_set_terminal_window): Remove no-op.
1049 (initialize_msdos_display): Adjust terminal setup.
1050 * w32console.c (w32con_set_terminal_window): Remove no-op.
1051 (initialize_w32_display): Adjust terminal setup.
1052 * w32term.c (w32_set_terminal_window): Remove no-op.
1053 (w32_create_terminal): Adjust terminal setup.
1054 * xterm.c (XTset_terminal_window): Remove no-op.
1055 (x_create_terminal): Adjust terminal setup.
1056
a892a94c
DA
10572013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1058
1059 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1060 Remove no-ops.
1061 (ns_create_terminal): Adjust terminal setup.
1062 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1063 Remove no-ops.
1064 (w32_create_terminal): Adjust terminal setup.
1065 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1066 Remove no-ops.
1067 (x_create_terminal): Adjust terminal setup.
1068
cf91889a
DA
10692013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1070
1071 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1072 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1073 * dispnew.c (buffer_posn_from_coords):
1074 * window.c (Fwindow_end, displayed_window_lines):
1075 * xdisp.c (redisplay_mode_lines): Use it.
1076
5b0891df
JD
10772013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1078
1079 * fontset.c (face_for_char): Check char in the current face font first
1080 if HAVE_NS (Bug#15138).
1081
0a357e98
MR
10822013-08-31 Martin Rudalics <rudalics@gmx.at>
1083
1084 * window.c (temp_output_buffer_show): Make sure window returned
1085 by display_buffer is live (Bug#15213).
1086
9d7693d7
DA
10872013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1088
1089 Minor cleanup to avoid forward declarations.
1090 * coding.h (struct ccl_spec): Remove forward declaration.
1091 * composite.h (toplevel): Include font.h.
1092 (struct composition_it, struct face, struct font_metrics):
1093 Remove forward declaration.
1094 * dispextern.h (struct image, struct atimer): Likewise.
1095 * emacsgtkfixed.h (struct frame): Likewise.
1096 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1097 * font.h (struct font_driver, struct font, struct glyph_string)
1098 (struct face): Remove forward declaration.
1099 * fontset.h (struct face, struct font): Likewise.
1100 * frame.h (toplevel): Style cleanup.
1101 (enum output_method): Move to...
1102 * termhooks.h (enum output_method): ...here.
1103 (struct glyph, struct frame, struct ns_display_info)
1104 (struct x_display_info, struct w32_display_info):
1105 Remove forward declaration.
1106 * xterm.h (toplevel): Include termhooks.h.
1107 (struct font, struct window, struct glyph_matrix, struct frame)
1108 (struct input_event, struct face, struct image): Remove forward
1109 declaration.
1110 * gtkutil.h (struct _widget_value): Likewise.
1111 * keyboard.h (toplevel): Include termhooks.h.
1112 (struct input_event): Remove forward declaration.
1113
032f7451
DA
11142013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1115
1116 * intervals.c (set_point_from_marker): New function.
1117 * editfns.c (Fgoto_char):
1118 * process.c (Finternal_default_process_filter):
1119 * window.c (select_window_1): Use it.
1120 * buffer.h (set_point_from_marker): Add prototype.
1121
3f940c5a
EZ
11222013-08-29 Eli Zaretskii <eliz@gnu.org>
1123
1124 * w32.c (term_winsock): Call release_listen_threads before calling
1125 WSACleanup.
1126 (_sys_wait_accept): Wait for accept event in a loop with a finite
1127 timeout, instead of waiting indefinitely. Will hopefully avoid
1128 hanging during exit because WSACleanup deadlocks waiting for the
1129 event object to be released. (Bug#14333)
1130
1131 * w32proc.c (release_listen_threads): New function, signals all
1132 the reader threads that listen for connections to stop waiting.
1133
1134 * w32.h (release_listen_threads): Add prototype.
1135
101ed2bb
DA
11362013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1137
1138 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1139 field of new marker (for sanity and safety).
20de2834
DA
1140 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1141 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1142
1f5cf200
DA
11432013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1144
1145 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1146 (x_after_update_window_line, x_scroll_bar_create):
1147 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1148 (handle_one_xevent, x_clear_frame_area):
1149 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1150 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1151 * xterm.h (x_clear_area): Adjust prototype.
1152
d2b36813
DA
11532013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 Hook scanning and indentation functions to find_newline. This helps
1156 to avoid duplicated code and renders more respect to newline cache.
1157 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1158 * cmds.c (Fforward_line):
1159 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1160 Use find_newline and avoid unnecessary point movements.
1161 * search.c (scan_newline): Implement on top of find_newline.
1162
3ec7babc
SM
11632013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1164
1165 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1166 scoped code (bug#11258).
1167
5ab473cd
JD
11682013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1169
1170 * nsterm.m (last_window): New variable.
1171 (EV_TRAILER2): New macro.
1172 (EV_TRAILER): Call EV_TRAILER2.
1173 (mouseMoved:): Add support for mouse-autoselect-window
1174 on nextstep (Bug#6888).
1175
78779650
AS
11762013-08-28 Andreas Schwab <schwab@suse.de>
1177
1178 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1179 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1180 Remove unused macro definitions.
1181 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1182 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1183 Only define if emacs.
78779650 1184
c3c4768d
DA
11852013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1186
1187 Prefer enum glyph_row_area to int where appropriate.
1188 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1189 Fix comment.
1190 (window_box, window_box_width, window_box_left, window_box_left_offset)
1191 (window_box_right, window_box_right_offset): Adjust prototypes.
1192 * xdisp.c (window_box, window_box_width, window_box_left)
1193 (window_box_left_offset, window_box_right, window_box_right_offset):
1194 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1195 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1196 * nsterm.m (ns_clip_to_row):
1197 * w32term.c (w32_clip_to_row):
1198 * xterm.c (x_clip_to_row): Likewise.
1199
6bdcbfe1
DA
12002013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1201
1202 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1203 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1204
50b13cde
PE
12052013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1208 for portability to hosts where /bin/sh has problems.
1209
f60e429a
DA
12102013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1211
1212 Redesign redisplay interface to drop global output_cursor.
1213 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1214 (toplevel): Remove declaration of output_cursor.
1215 (set_output_cursor, x_cursor_to): Remove prototype.
1216 * window.h (struct window): New member output_cursor.
1217 (output_cursor_to): New function to replace RIF member.
1218 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1219 (update_text_area, set_window_cursor_after_update): Use it.
1220 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1221 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1222 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1223 * w32term.c (x_update_window_begin, x_update_window_end):
1224 * xterm.c (x_update_window_begin, x_update_window_end):
1225 Adjust to use per-window output cursor.
1226
43aac990
PE
12272013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1228
d486344e
PE
1229 Simplify SELECT_TYPE-related code.
1230 Like EMACS_TIME, this portability layer is no longer needed, since
1231 Emacs has been using fd_set as a portability layer for some time.
1232 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1233 (SELECT_TYPE): Remove. All uses changed to fd_set.
1234 (fd_set) [!FD_SET]: New typedef.
1235
43aac990
PE
1236 Simplify EMACS_TIME-related code.
1237 This portability layer is no longer needed, since Emacs has been
1238 using struct timespec as a portability layer for some time.
1239 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1240 Include <time.h> rather than "systime.h"; that's all that's needed now.
1241 * dispnew.c: Include <timespec.h> rather than "systime.h";
1242 that's all that's needed now.
1243 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1244 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1245 TIMESPEC_RESOLUTION.
1246 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1247 LOG10_TIMESPEC_RESOLUTION.
1248 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1249 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1250 (make_emacs_time): Remove. All used changed to make_timespec.
1251 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1252 (current_timespec): Rename from current_emacs_time. All uses changed.
1253 (add_emacs_time): Remove. All uses changed to timespec_add.
1254 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1255 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1256 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1257 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1258 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1259 (current_timespec): Rename from current_emacs_time. All uses changed.
1260 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1261 changed to timespec_cmp.
1262 * xgselect.c: Include <timespec.h>, since our .h files don't.
1263
d350e350
DA
12642013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1265
1266 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1267 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1268 Remove the leftovers.
1269 * gtkutil.c (toplevel): Do not declare Qxft but include
1270 font.h to do so.
1271 * image.c (toplevel): Do not declare Vlibrary_cache because
1272 it's already done in lisp.h.
1273
9fed9729
DA
12742013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1275
1276 * lisp.h (Mouse_HLInfo): Move from here...
1277 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1278 (reset_mouse_highlight): New function.
1279 * msdos.c (dos_set_window_size, IT_update_begin)
1280 (internal_terminal_init):
1281 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1282 (ns_initialize_display_info):
1283 * w32console.c (initialize_w32_display):
1284 * w32term.c (x_update_window_end, x_free_frame_resources)
1285 (w32_initialize_display_info):
1286 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1287 * window.c (Fdelete_other_windows_internal):
1288 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1289 * termchar.h (toplevel):
1290 * xterm.h (toplevel): Include dispextern.h.
1291
f462f075
PE
12922013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Fix minor problems found by static checking.
1295 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1296 (expect): Avoid nested-if warning.
1297 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1298 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1299 * nsterm.h, nsterm.m (ns_select):
1300 * xgselect.c, xgselect.h (xg_select):
1301 Adjust signature to better match pselect's.
1302 * nsterm.m (ns_select):
1303 Don't set *TIMEOUT, since pselect doesn't.
1304 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1305 diagnostic about assigning const char * to it.
1306 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1307
068f9124
SM
13082013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1309
1310 * lread.c (substitute_object_recurse): Handle hash-tables as well
1311 (bug#15190).
1312
f5adc984
PE
13132013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1314
1fc8eb33
PE
1315 Fix unlikely core dump in init_tty, and simplify terminfo case.
1316 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1317 The old version incorrectly dumped core if malloc returned a
1318 buffer containing only non-NUL bytes.
1319 (init_tty): Do not allocate or free termcap buffers; the
1320 struct does that for us now.
1321 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1322 (struct tty_display_info): Define members termcap_term_buffer and
1323 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1324 use them. Allocate them directly in struct rather than indirectly
1325 via a pointer, to simplify init_tty.
1326
f5adc984
PE
1327 * frame.c (check_minibuf_window): Initialize 'window' properly,
1328 so that Emacs reliably aborts later if 'window' is not initialized.
1329
efec3894
JD
13302013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1331
1332 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1333 of VoidSymbol (Bug#15154).
1334
e1d0341e
DA
13352013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1338 mouse_face_beg_y and mouse_face_end_y.
1339 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1340 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1341 Adjust users and update comment where appropriate.
1342
bfff6445
MR
13432013-08-26 Martin Rudalics <rudalics@gmx.at>
1344
1345 * frame.c (check_minibuf_window): New function.
068f9124
SM
1346 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1347 Call check_minibuf_window (Bug#15183).
bfff6445 1348
c80016b3
DA
13492013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1352 because this is the only last cursor data we need to keep and consult.
1353 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1354 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1355 Adjust users.
1356
de396731
DA
13572013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1358
068f9124
SM
1359 Fix recovering from possible decompression error.
1360 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1361 the position where the partially decompressed data ends, and
447218dd 1362 should count how many bytes was produced so far.
de396731
DA
1363 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1364 (unwind_decompress): Really delete partially uncompressed data.
1365 (Fzlib_decompress_region): Take decompressed data size into account.
1366
c76826d9
DA
13672013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 * syntax.c (init_syntax_once): Adjust comment and do an early
1370 initialization of Qchar_table_extra_slots just once...
1371 * casetab.c (init_casetab_once):
1372 * category.c (init_category_once):
1373 * character.c (syms_of_character):
1374 * coding.c (syms_of_coding):
1375 * xdisp.c (syms_of_xdisp): ...and omit it here.
1376
b34454d0
EZ
13772013-08-24 Eli Zaretskii <eliz@gnu.org>
1378
11f20add
EZ
1379 * xdisp.c (get_next_display_element): Don't apply to characters
1380 from a display vector the logic of setting it->end_of_box_run_p
1381 suitable for characters from a buffer. (Bug#15175)
1382
b34454d0
EZ
1383 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1384 to handle directories, rather than '_utime' which doesn't.
1385 (Bug#15176)
1386
6e1b469e
JD
13872013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1388
1389 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1390 or fullscreen (Bug#14627).
1391
9c05bccf
PE
13922013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 System-dependent integer overflow fixes.
1395 * process.c (Fset_process_window_size): Signal an error if
1396 the window size is outside the range supported by the lower level.
1397 * sysdep.c (set_window_size): Return negative on error,
1398 nonnegative on success, rather than -1, 0, 1 on not in system,
1399 failure, success. This is simpler. Caller changed.
1400 (serial_configure): Remove unnecessary initialization of local.
1401 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1402 size fits in unsigned long; this isn't true on some 32-bit hosts.
1403 Avoid buffer overrun if some future version of /proc/meminfo has a
1404 variable name longer than 20 bytes.
1405 (system_process_attributes) [__FreeBSD__]:
1406 Don't assume hw.availpages fits in 'int'.
1407
c365c355
PE
14082013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 Don't let very long directory names overrun the stack.
1411 Fix some related minor problems involving "//", vfork.
1412 * callproc.c (encode_current_directory): New function.
1413 (call_process): Don't append "/"; not needed.
1414 * fileio.c (file_name_as_directory_slop): New constant.
1415 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1416 this can save the caller having to alloca.
1417 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1418 Use SAFE_ALLOCA, not alloca.
1419 (directory_file_name, Fexpand_file_name): Leave leading "//"
1420 alone, since it can be special even on POSIX platforms.
1421 * callproc.c (call_process):
1422 * process.c (Fformat_network_address):
1423 * sysdep.c (sys_subshell):
1424 Use encode_current_directory rather than rolling our own.
1425 (create_process): No need to encode directory; caller does that now.
1426 * process.h (encode_current_directory): New decl.
1427 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1428 Rework to avoid 'goto xyzzy;'.
1429
6c6014d4
EZ
14302013-08-23 Eli Zaretskii <eliz@gnu.org>
1431
1432 * xdisp.c (handle_face_prop): If the default face was remapped use
1433 the remapped face for strings from prefix properties. (Bug#15155)
1434
9997ec56
DA
14352013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1436
1437 Minor cleanup for redisplay interface and few related functions.
1438 * frame.h (enum text_cursor_kinds): Move from here...
1439 * dispextern.h (enum text_cursor_kinds): ...to here.
1440 (toplevel): Drop unnecessary declarations.
1441 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1442 in update_window_end_hook and draw_window_cursor functions.
1443 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1444 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1445 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1446 * xterm.c (x_update_window_end, x_draw_window_cursor):
1447 * xdisp.c (display_and_set_cursor, update_window_cursor)
1448 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1449 enum text_cursor_kinds where appropriate.
1450
7f780da6
DA
14512013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1452
1453 Redesign redisplay interface to drop updated_row and updated_area.
1454 * dispextern.h (updated_row, updated_area): Remove declaration.
1455 (struct redisplay_interface): Pass glyph row and row area parameters
1456 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1457 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1458 Adjust prototypes.
1459 * dispnew.c (updated_row, updated_area): Remove.
1460 (redraw_overlapped_rows, update_window_line): Adjust user.
1461 (update_marginal_area, update_text_area): Likewise. Pass updated row
1462 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1463 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1464 Adjust users.
1465
26495794
PE
14662013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 * process.c (flush_pending_output): Remove stub.
1469 All uses removed.
1470
4a88129a
PE
14712013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1472
1473 * callproc.c: Fix race that killed background processes (Bug#15144).
1474 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1475 Record deleted process-id in critical section, not afterwards.
1476 Don't mistakenly kill process created by a call-process invocation
1477 that discards output and does not wait.
1478
0c5307b0
DA
14792013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1480
1481 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1482 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1483 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1484 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1485 to shut up compiler in mark_object.
1486 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1487
0d7c1e66
PE
14882013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1491 We can't portably rely on PTY_OPEN doing that, even if
1492 it calls posix_openpt with O_CLOEXEC.
1493
3f246b65
KH
14942013-08-20 Kenichi Handa <handa@gnu.org>
1495
1496 * character.c (string_char): Improve commentary.
1497
8c2f38aa
PE
14982013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1501 (struct animation_cache): Make signature a flexible array member.
1502 All uses changed. This is a tad slower but may insulate us better
1503 from future changes to ImageMagick.
1504
bb566cea
PE
15052013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1506
1507 * image.c: Shrink memory needed for animation cache.
1508 (SIGNATURE_DIGESTSIZE): New constant.
1509 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1510 (imagemagick_create_cache): Copy the signature. This saves
1511 several KB of memory that ImageMagick wastes per signature.
1512 Don't bother updating the update_time, as the caller does that now.
1513 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1514 it's a fixed size struct member now.
1515 (imagemagick_get_animation_cache): Always destroy the signature,
1516 as it's now imagemagick_create_cache's responsibility to copy it.
1517 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1518 and use memcmp rather than strcmp.
1519 eassert that ImageMagick returns a signature of the specified length.
1520
6da26928
LMI
15212013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1522
1523 * image.c (imagemagick_get_animation_cache): Don't segfault on
1524 each invocation.
453f4022
LMI
1525 (imagemagick_get_animation_cache): Revert to previous definition
1526 so that it actually works. But keep the memory leak fix.
1527 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1528
22490125
PE
15292013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1530
d0139df5
PE
1531 * image.c: Fix animation cache signature memory leak.
1532 Fix some other minor performance problems while we're at it.
1533 (imagemagick_create_cache): Clear just the members that
1534 need clearing. Don't set update_time, as caller does that now.
1535 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1536 Simplify by using pointer-to-pointer instead of a prev pointer.
1537 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1538 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1539 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1540 it's already a copy. Free the signature probe unless it's cached.
1541
22490125
PE
1542 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1543 This was introduced by my 2013-08-12 fix for Bug#15035.
1544
deb31e75
DA
15452013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1546
1547 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1548 (imagemagick_prune_animation_cache): Now static.
1549
319a4d03
LMI
15502013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1551
1552 * image.c (imagemagick_get_animation_cache): Don't segfault when
1553 pruning all entries.
1554
f747d82e
KB
15552013-08-18 Ken Brown <kbrown@cornell.edu>
1556
1557 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1558 static heap if ENABLE_CHECKING is defined.
1559 (max_bss_sbrk_ptr): New variable.
1560 (bss_sbrk): Use it.
1561 (report_sheap_usage): Report maximum static heap usage instead of
1562 ending static heap usage.
1563
d2c28fab
EZ
15642013-08-17 Eli Zaretskii <eliz@gnu.org>
1565
1566 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1567 of zlib_initialized according to the results of calling
1568 init_zlib_functions.
1569
274ff63f
LMI
15702013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1571
1572 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1573 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1574 (imagemagick_load_image): Remove the ping_wand code, which only
1575 apparently saved time on invalid animated images, and slowed down
1576 everything else. Optimise for the common case.
274ff63f 1577
2bede2ed
XF
15782013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1579
70ff8240
XF
1580 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1581
de179a3e
XF
1582 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1583
2bede2ed
XF
1584 * marker.c (set_marker): Remove documentation of undefined behavior.
1585
703dbeba
LMI
15862013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1587
1588 * image.c (imagemagick_compute_animated_image): Animate correctly
1589 when sub-images are smaller than the main image.
1d18b1e6
LMI
1590 (imagemagick_compute_animated_image): Setting the iterator row to
1591 zero is apparently not allowed.
79670014
LMI
1592 (imagemagick_compute_animated_image): Allow images that say they
1593 have sub-images that are bigger than the main image, but just crop
1594 them.
703dbeba 1595
63216c5e
JD
15962013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1597
1598 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1599
a5b5f73f
LMI
16002013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1601
1602 * image.c (imagemagick_compute_animated_image): Respect the GIF
1603 disposal methods.
1604
0fe73012
KB
16052013-08-15 Ken Brown <kbrown@cornell.edu>
1606
1607 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1608 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1609 needed.
1610
691a357f
PE
16112013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1612
1613 Fix minor problems found by static checking.
1614 * frame.c (delete_frame):
1615 * xdisp.c (next_element_from_display_vector):
1616 Avoid uninitialized local.
1617 * image.c (imagemagick_compute_animated_image): Port to C89.
1618 Prefer usual GNU indentation style for loops.
1619 Be more careful about bizarrely large sizes, by using ptrdiff_t
1620 instead of int.
1621
42fe2e88
DA
16222013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1623
1624 Fix infinite frame selection loop (Bug#15025).
1625 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1626
d39a3da6
EZ
16272013-08-15 Eli Zaretskii <eliz@gnu.org>
1628
068f9124
SM
1629 * xdisp.c (compute_window_start_on_continuation_line):
1630 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1631 to make sure we end up setting the window start at the leftmost
1632 visible character of the display line. This avoids funky
1633 horizontal shifting because the window start is not kept on the
1634 same position. (Bug#15090)
05426239
EZ
1635 (next_element_from_display_vector): Support 'box' face attribute
1636 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1637
6e856b69
LMI
16382013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1639
1640 * image.c (imagemagick_compute_animated_image): Implement animated
1641 images (bug#14700).
995be755
LMI
1642 (imagemagick_compute_animated_image): Fix some compilation
1643 warnings. Implement a very simple cache to make the animation
1644 usable at all, but it should be replaced with a per-image cache.
6e856b69 1645
d5a1acfa
DA
16462013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1647
1648 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1649 to do `for' loops over alist values.
1650 * buffer.h (FOR_EACH_BUFFER):
1651 * process.c (FOR_EACH_PROCESS): Use it.
1652 (handle_child_signal, status_notify, Fget_buffer_process)
1653 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1654
9c253307
DA
16552013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1656
1657 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1658 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1659 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1660 to xzalloc and so avoid redundant call to memset.
1661 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1662 members because it is allocated with xzalloc and so already zeroed.
1663
05e64f9f
KB
16642013-08-14 Ken Brown <kbrown@cornell.edu>
1665
1666 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1667 (Bug#15094).
1668
5b71542d
DA
16692013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1670
1671 Utility function and macro to copy Lisp string to C string.
1672 * lisp.h (xlispstrdupa): New macro.
1673 (xlispstrdup): New prototype.
1674 * alloc.c (xlispstrdup): New function.
1675 * callint.c (Fcall_interactively):
1676 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1677 (Fsubstitute_in_file_name):
1678 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1679 * image.c (x_create_bitmap_from_file):
1680 * w32term.c (w32_term_init):
1681 * xterm.c (x_term_init): Use xlispstrdup.
1682
71530c97
LMI
16832013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1684
4ce82fb8
LMI
1685 * image.c (imagemagick_load_image): Make animated pictures work.
1686 There's still some problems with background color settings, though
1687 (bug#14700).
1688
71530c97
LMI
1689 * decompress.c (unwind_decompress): Always restore point.
1690
7510a061
XF
16912013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1692
1693 * marker.c (set_marker): Reformat documentation.
1694
01c3051f
PE
16952013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1696
aab1fcdf
PE
1697 * xdisp.c (cursor_type_changed): Now static.
1698
01c3051f
PE
1699 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1700 Use changed. This avoids the need to call xmalloc and for the
1701 caller to call xfree, and avoids memory leaks in some situations.
1702
2084152a
DA
17032013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1704
1705 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1706 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1707 (redisplay_window): If window_end_valid is cleared due to non-zero
1708 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1709 so do not call to try_cursor_movement for that window.
2084152a 1710
02455cb6
DA
17112013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1712
1713 * window.h (struct window): Convert window_end_pos and
1714 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1715 (wset_window_end_pos, wset_window_end_vpos): Remove.
1716 * dispnew.c (adjust_glyph_matrix):
1717 * window.c (Fwindow_end, replace_window, set_window_buffer)
1718 (make_window):
1719 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1720 (set_vertical_scroll_bar, redisplay_window, try_window)
1721 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1722 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1723 (note_mouse_highlight): Adjust users.
1724 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1725 Add comment.
1726
da5707e8
DA
17272013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1728
1729 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1730 * image.c (imagemagick_filename_hint): Use `const char *' and
1731 prefer SSDATA to SDATA to avoid warnings.
1732
25554267
DA
17332013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1734
1735 Cleanup window fringes, margins and scroll bars adjustments.
1736 * window.c (set_window_fringes, set_window_margins)
1737 (set_window_scroll_bars, apply_window_adjustment): New functions.
1738 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1739 (Fset_window_scroll_bars): Use them.
1740
38a2c910
DA
17412013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1742
1743 * window.h (struct window): Convert scroll_bar_width
1744 from Lisp_Object to integer. Adjust comment.
1745 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1746 Adjust users.
1747 * window.c (wset_scroll_bar_width): Remove.
1748 (make_window): Initialize scroll_bar_width.
1749 (Fsplit_window_internal): Use direct assignment.
1750 (Fset_window_configuration, save_window_save):
1751 Convert Lisp_Object to integer and back where appropriate.
1752 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1753 bar was actually changed, and mention this in docstring.
1754
2d065031
PE
17552013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1756
1757 * decompress.c: Minor simplifications.
1758 (Fzlib_decompress_region): Don't bother verifying
1759 that avail_out <= UINT_MAX, as that was confusing.
1760 Mention the restriction in a comment instead.
1761 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1762
a5bd5abb
JD
17632013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1764
1765 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1766 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1767
66e7901a
LMI
17682013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1769
1770 * image.c (imagemagick_filename_hint): Check for errors in the
1771 alist structure.
1772
2fa611b7
EZ
17732013-08-13 Eli Zaretskii <eliz@gnu.org>
1774
1775 * window.c (Fwindow_margins): Return nil when there's no marginal
1776 area, as per the documented API.
1777
1778 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1779 Fmake_vector, as scroll bar's struct members are not all Lisp
1780 objects now. This avoids crashes in GC.
1781
1782 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1783 bool, so its address could be taken.
1784
8259030d
LMI
17852013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1786
1787 * image.c (imagemagick_filename_hint): New function to possibly
1788 apply `image-content-type-suffixes'.
1789 (imagemagick_load_image): Use it.
1790
866c710e
EZ
17912013-08-13 Eli Zaretskii <eliz@gnu.org>
1792
1793 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1794 if loading zlib failed.
1795
f10490f0
JD
17962013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1797
96311be7
JD
1798 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1799 2013-08-13 checkin below. Change bool to BOOL, rule is:
1800 All Obj-C code uses BOOL, except for interfaces callable from C.
1801
f10490f0
JD
1802 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1803
c8ae93b0
DA
18042013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1805
1806 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1807 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1808 bool instead of BOOL.
1809 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1810 from Lisp_Object to bitfield. Adjust comment.
1811 * w32term.c (x_scroll_bar_create): Adjust user.
1812 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1813 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1814 Use bool for boolean.
1815 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1816 to `unsigned int' when defining a bitfield.
1817
53b64418
PE
18182013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1821
eeaf9bf3
DA
18222013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1823
1824 * window.h (struct window): Convert left_margin_cols and
1825 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1826 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1827 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1828 Adjust users.
1829 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1830 Adjust comment.
1831 (showing_window_margins_p, update_window_line, update_frame_1):
1832 * fringe.c (draw_fringe_bitmap_1):
1833 * xdisp.c (window_box_width): Adjust users.
1834 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1835 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1836 Use direct assignment.
1837 (Fset_window_configuration, save_window_save, Fwindow_margins):
1838 Convert Lisp_Object to integer and back where appropriate.
1839 (Fset_window_margins): Adjust user. Return t if any margin
1840 was actually changed, and mention this in docstring.
1841
956720af
XF
18422013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1843
f73f4ce6 1844 * syntax.c (forward_word):
956720af
XF
1845 * cmds.c (forward_char, backward_char): Mention the optional argument.
1846
9e37ee3b
DA
18472013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1848
1849 * window.h (struct window): Convert left_fringe_width
1850 and right_fringe_width from Lisp_Objects to integers.
1851 Adjust comment.
1852 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1853 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1854 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1855 Remove.
1856 (make_window): Initialize new integer fields to -1.
1857 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1858 (Fset_window_configuration, save_window_save):
1859 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1860 (Fset_window_fringes): Adjust user. Return t if any fringe
1861 was actually changed, and mention this in docstring.
1862
e4375ca7
DA
18632013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1864
1865 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1866 * nsfns.m (x_set_cursor_type):
1867 * w32fns.c (x_set_cursor_type):
1868 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1869 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1870
a45543bc
DA
18712013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1872
1873 * font.c (clear_font_cache): New function, stripped from...
1874 (Fclear_font_cache): ...here, which now uses the function
1875 above. Adjust comment.
1876 * font.h (clear_font_cache): Add prototype.
1877 * xfaces.c (clear_face_cache): Use clear_font_cache.
1878
ae966a86
DA
18792013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1880
1881 * window.c (Fset_window_start): Compare `w', not `window' because
1882 `w' might not be equal to `window' after call to decode_live_window.
1883
297a545b
PE
18842013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1885
1886 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1887 This fixes a problem introduced by the Bug#15035 patch
1888 when using GPG. Reported by Herbert J. Skuhra.
1889
aa942e2b
EZ
18902013-08-12 Eli Zaretskii <eliz@gnu.org>
1891
1892 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1893 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1894 not yet initialized.
1895
7699d09e
LMI
18962013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1897
1898 * decompress.c (Fzlib_decompress_region): Support zlib
1899 decompression, too, and rename.
1900
1d238bc7
PE
19012013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 Minor zlib configuration tweaks.
1904 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1905 Don't assume presence of fn_inflateInit2_ zlib internal function.
1906
8a44a184
LMI
19072013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1908
1909 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1910 include the zlib prefix.
1911
594a4307
EZ
19122013-08-12 Eli Zaretskii <eliz@gnu.org>
1913
1914 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1915 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1916 define static variables that are pointers to zlib functions to be
1917 dynamically loaded.
1918 (init_zlib_functions) [WINDOWSNT]: New function.
1919 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1920 New macros.
1921 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1922 macros instead of invoking the zlib functions directly.
068f9124
SM
1923 (syms_of_decompress): DEFSYM Qzlib_dll.
1924 Staticpro Szlib_available_p.
594a4307 1925
d2e113bc
DA
19262013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 Avoid looping over all frame windows to freeze and unfreeze.
1929 * window.h (struct window): Drop frozen_window_start_p.
1930 (freeze_window_starts): Drop prototype.
1931 * frame.h (struct frame): New frozen_window_starts flag.
1932 (FRAME_WINDOWS_FROZEN): New macro.
1933 * window.c (freeze_window_start, freeze_window_starts):
1934 Remove.
1935 (select_window, replace_window): Adjust users.
1936 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1937 (window_frozen_p): New function.
1938 (redisplay_window): Use it.
1939
94fcd171
PE
19402013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 Fix some fd issues when running subprocesses (Bug#15035).
1943 Fix bugs that can leak files or file descriptors on errors.
1944 Don't unlink open temp files, as that's hard for users to diagnose
1945 when things go awry (e.g., temp disk exhausted).
1946 Don't bother to lock temp files. Check for invalid recursion.
1947 * callproc.c (synch_process_fd): Remove. All uses removed.
1948 (synch_process_tempfile): New var or macro.
1949 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1950 New constants.
1951 (record_kill_process): New arg, the temp name. All callers changed.
1952 (delete_temp_file): Now just a simple wrapper around unlink.
1953 (call_process_kill): New arg, the call_process_fd array.
1954 Close them all. Clear synch_process_pid. Remove the temp file,
1955 or arrange for it to be removed.
1956 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1957 that's been moved to synch_process_tempfile. Caller changed.
1958 Do not remove the tempfile; that's now call_process_kill's
1959 responsibility.
1960 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1961 call_process_kill; the caller now does that.
1962 (call_process_cleanup): Do not close the process fd; that's now
1963 call_process_kill's responsibility.
1964 (Fcall_process): Implement via new function call_process, which
1965 has most of the old body of Fcall_process, but with a different API.
1966 (call_process): New function that does not open or close filefd if
1967 it is nonnegative. Record which fds need to be closed, and let
1968 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1969 Signal an error if invoked recursively (could be done via a hook).
1970 Simplify creation of the tempfile in the MSDOS case.
1971 Don't create the output file until after checking for the executable.
1972 Report any failure to open /dev/null.
1973 Don't open /dev/null for writing twice; once is enough.
1974 Don't create pipe if all output is being discarded or sent to file.
1975 Don't worry about setting up the coding system or reading from the
1976 pipe if all output is being discarded.
1977 Hoist fd_error local into top level, to lessen block nesting.
1978 Don't record deleted pid here; now done by Fcall_process_region.
1979 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1980 and note its success in synch_process_tempfile.
1981 Do not leak resources when child_setup fails.
1982 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1983 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1984 (create_temp_file): Now returns open fd, with an additional
1985 Lisp_Object * argument to return the name. All callers changed.
1986 Do not close the file; rewind it instead, and leave it open for
1987 the caller. Do not lock the temp file. Unwind-protect the file
1988 and the file-descriptor.
1989 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1990 If an asynchrounous process, record it here, not in call_process.
1991 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1992 * eval.c (set_unwind_protect): New function.
1993 * fileio.c (write_region): New function, generalized from the
1994 old Fwrite_region. Do not lock temp files.
1995 (Fwrite_region): Use it.
1996 * lisp.h (set_unwind_protect, write_region): New decls.
1997 * process.c: Include <verify.h>.
1998 (make_process): Mark fds as initially closed.
1999 (deleted_pid_list): Now a list of pid-filename pairs.
2000 All uses changed.
2001 (close_process_fd): New function.
2002 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2003 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2004 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2005 (create_process, create_pty, Fmake_serial_process)
2006 (server_accept_connection): Record which fds need to be closed,
2007 and let deactivate_process close them.
2008 (Fmake_network_process): Do not discard the unwind-protect
2009 until it's safe to do so.
2010 (deactivate_process): Close the fds opened by create_process etc.
2011 (Fprocess_send_eof): Adjust to new way of recording open fds.
2012 Report an error if /dev/null can't be opened, instead of aborting.
2013 * process.h (PROCESS_OPEN_FDS): New constant.
2014 (struct Lisp_Process): New member open_fds.
2015 (record_kill_process, record_deleted_pid): Adjust signatures.
2016 (record_deleted_pid): Move decl here ...
2017 * syswait.h (record_deleted_pid): ... from here.
2018
d0e615c3
PE
20192013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2020
2021 * decompress.c: Fix bugs with large buffers and weird inputs.
2022 Tune a bit. Reindent as per usual Emacs style.
2023 (BUFFER_SIZE): Remove.
2024 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2025 more than UINT_MAX bytes. Decompress into the gap instead of into
2026 an auto buffer, as this should avoid copying. Return nil if
2027 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2028 set immediate_quit; we shouldn't trust zlib code that much.
2029
313546eb
LMI
20302013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2031
99a32242
LMI
2032 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2033 errors, and really move the gap to where we want it.
2034
313546eb
LMI
2035 * lisp.h: Include decompress.c support.
2036
2037 * emacs.c (main): Include decompress.c support.
2038
2039 * Makefile.in: Include -lz if present.
2040
d2d699ac
JD
20412013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2042
f90e3ebd
JD
2043 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2044 (initWithTitle:): Initialize frame to 0.
2045 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2046 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2047 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2048
2049 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2050 fillWithWidgetValue:frame:
2051
423d3b3f
JD
2052 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2053 remove memory leak warnings.
2054
d2d699ac
JD
2055 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2056 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2057 menu_pending_title.
2058
2059 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2060 (x_activate_menubar): Update the whole menu.
2061 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2062 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2063 current event is not NSSystemDefined (Bug#15001).
2064 Call ns_check_menu_open only if trackingMenu is 2.
2065 (menuDidClose:): New method, decrease trackingMenu.
2066 (fillWithWidgetValue:setDelegate:): New method.
2067 (fillWithWidgetValue:): Call the above.
2068
2069 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2070
7d652d97
PE
20712013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 Omit some unnecessary casts.
2074 Many of these go back to the old pre-C89 days, when they may have
2075 been needed, but we've been assuming C89 or later for a while now.
2076 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2077 (live_float_p, live_misc_p, live_vector_p):
2078 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2079 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2080 (defvar_per_buffer):
2081 * callint.c (Fcall_interactively):
2082 * doc.c (Fsubstitute_command_keys):
2083 * filelock.c (get_boot_time):
2084 * frame.c (xrdb_get_resource):
2085 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2086 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2087 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2088 (menuitem_highlight_callback, menu_destroy_callback)
2089 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2090 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2091 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2092 (xg_tool_bar_help_callback, tb_size_cb):
2093 * image.c (xpm_alloc_color, png_read_from_memory)
2094 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2095 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2096 (syms_of_image):
2097 * keymap.c (describe_map):
2098 * nsfns.m (Fns_display_monitor_attributes_list):
2099 * nsmenu.m (process_dialog:):
2100 * nsterm.m (hold_event):
2101 * process.c (wait_reading_process_output):
2102 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2103 * scroll.c (do_direct_scrolling, scrolling_1):
2104 * termcap.c (tgetent):
2105 * window.c (check_window_containing, add_window_to_list)
2106 (freeze_window_starts):
2107 * xdisp.c (compare_overlay_entries, vmessage):
2108 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2109 (x_get_monitor_attributes_xrandr)
2110 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2111 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2112 * xfont.c (xfont_match, xfont_open):
2113 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2114 (menubar_selection_callback, menu_position_func)
2115 (popup_selection_callback, create_and_show_popup_menu)
2116 (dialog_selection_callback, create_and_show_dialog):
2117 * xrdb.c (x_get_string_resource):
2118 (main) [TESTRM]:
2119 * xsmfns.c (x_session_check_input):
2120 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2121 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2122 (xaw_jump_callback, xaw_scroll_callback):
2123 Omit unnecessary casts.
2124
9acc1074
PE
21252013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2126
2127 Minor string-length refactoring.
2128 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2129 * frame.c (make_monitor_attribute_list):
2130 Prefer build_string to strlen + make_string.
2131
361c0eb8
JD
21322013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2133
2134 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2135 don't check minor_code (Bug#14417).
2136
14ba0822
EZ
21372013-08-09 Eli Zaretskii <eliz@gnu.org>
2138
2139 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2140 vertical positions instead. This avoids calling MATRIX_ROW with
2141 row numbers that are possibly beyond valid limits. (Bug#15064)
2142
309f24d1
DA
21432013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2144
2145 Use xstrdup and build_unibyte_string where applicable.
2146 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2147 * xfns.c (x_window):
2148 * xrdb.c (x_get_customization_string):
2149 * xterm.c (xim_initialize):
2150 * w32fns.c (w32_window): Use xstrdup.
2151 (w32_display_monitor_attributes_list):
2152 * emacs.c (init_cmdargs):
2153 * keyboard.c (PUSH_C_STR):
2154 * nsfont.m (nsfont_open):
2155 * sysdep.c (system_process_attributes):
2156 * w32.c (system_process_attributes):
2157 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2158
55902276
EZ
21592013-08-09 Eli Zaretskii <eliz@gnu.org>
2160
2161 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2162 variables of these types so that GDB would know about them, as aid
2163 for debugging fatal exceptions. (Bug#15024) See also
2164 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2165 discussions.
2166
10bf7f5a
JD
21672013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2168
2169 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2170 larger than the NSWindow (Bug#14934).
2171
65620264
DA
21722013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2173
2174 Redesign redisplay interface to drop global variable updated_window.
2175 Always pass currently updated window as a parameter to update routines.
2176 * dispextern.h (updated_window): Remove declaration.
2177 (struct redisplay_interface): Pass window parameter to
2178 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2179 and after_update_window_hook.
2180 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2181 Adjust prototypes.
2182 * dispnew.c (updated_window): Remove.
2183 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2184 (update_window_line): Adjust to match redisplay interface changes.
2185 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2186 (ns_scroll_run, ns_after_update_window_line):
2187 * w32term.c (x_update_window_begin, x_update_window_end)
2188 (x_after_update_window_line, x_scroll_run):
2189 * xterm.c (x_update_window_begin, x_update_window_end)
2190 (x_after_update_window_line, x_scroll_run):
2191 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2192 Likewise. Adjust comments where appropriate.
2193 (x_cursor_to): Simplify because this is always called during window
2194 update (but install debugging check anyway).
2195 (expose_window): Check must_be_updated_p flag to see whether this
2196 function is called during window update.
2197
628fdc56
DA
21982013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2199
2200 Do not reset window modification event counters excessively.
2201 These leftovers and poor man's tricky methods to catch extra
2202 redisplay's attention are no longer needed.
2203 * frame.c (set_menu_bar_lines_1):
2204 * minibuf.c (read_minibuf_unwind):
2205 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2206 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2207 (window_scroll_line_based, Fset_window_configuration):
2208 * xdisp.c (redisplay_window): Do not reset last_modified and
2209 last_overlay_modified counters.
2210
8fd9c92e
JD
22112013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2212
2213 * xselect.c (x_send_client_event): Set send_event and serial, memset
2214 data.l as it might be bigger than data.b. Use 24 bit mask to
2215 XSendEvent (Bug#15034).
2216
0ee18172
EZ
22172013-08-07 Eli Zaretskii <eliz@gnu.org>
2218
2219 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2220 for TTY frames that are not the top frame on their console.
2221 (Bug#14616)
2222
16ddd1a6
MR
22232013-08-07 Martin Rudalics <rudalics@gmx.at>
2224
2225 * w32term.c (w32fullscreen_hook): Really maximize frame when
2226 asked for (Bug#14841).
2227
d2a95ffb
DA
22282013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2229
2230 Prefer selected_window to Fselected_window, likewise for frames.
2231 * buffer.c (Fbuffer_swap_text):
2232 * data.c (Fvariable_binding_locus):
2233 * window.c (run_window_configuration_change_hook): Adjust users.
2234 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2235 Use decode_live_frame.
2236
170da1ec
DA
22372013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2238
2239 Be more careful if selected window shows the buffer other than current,
2240 use window_outdated only if this is not so. This change should also
2241 address some weird issues discussed in Bug#13012.
2242 * window.h (window_outdated): New prototype.
2243 * window.c (window_outdated): Now here. Convert from static and
2244 always assume window's buffer.
2245 (Fwindow_end, Fwindow_line_height): Use it.
2246 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2247 and always assume window's buffer.
2248 (redisplay_window): Adjust user.
e5eefe9b 2249 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2250 check whether mode line should be updated only if selected window
2251 shows current buffer.
2252 (run_window_scroll_functions): Use eassert for debugging check.
2253 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2254
56b5d5b1
DA
22552013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2256
2257 * window.c (window_scroll, window_scroll_pixel_based)
2258 (window_scroll_line_based): Use bool for booleans.
2259
2878ba7e
PE
22602013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 * process.c: Fix minor off-by-one issues in descriptor counts.
2263 This shouldn't fix any real bugs, but it cleans up the code a bit.
2264 (max_process_desc, max_input_desc): -1, not 0, means none.
2265 All uses changed.
2266 (delete_input_desc): New function.
2267 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2268 (deactivate_process): Scan backwards when recomuting max_process_desc;
2269 that should be faster.
2270 (init_process_emacs): Initialize max_input_desc.
2271
e30b79c1
DA
22722013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2273
2274 Use region cache to speedup bidi_find_paragraph_start.
2275 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2276 Rename cache_long_line_scans to cache_long_scans.
2277 * buffer.c (bset_cache_long_line_scans): Rename to
2278 bset_cache_long_scans.
2279 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2280 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2281 into account.
2282 (syms_of_buffer): Rename cache-long-line-scans to
2283 cache-long-scans. Adjust docstring.
2284 * search.c (newline_cache_on_off):
2285 * indent.c (width_run_cache_on_off): Adjust users.
2286 * bidi.c (bidi_paragraph_cache_on_off): New function.
2287 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2288 * insdel.c (prepare_to_modify_buffer):
2289 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2290
00012b86
DA
22912013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2292
2293 Invalidate region caches only if buffer text is going to be changed.
2294 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2295 (modify_text): ...new prototype.
2296 (prepare_to_modify_buffer_1): New prototype.
2297 * textprop.c (modify_region): Rename to...
2298 (modify_text_properties): ...new function.
2299 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2300 (Fremove_list_of_text_properties): Adjust users.
2301 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2302 (modify_text): ...new function.
2303 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2304 (prepare_to_modify_buffer_1): ...new function.
2305 * casefiddle.c (casify_region):
2306 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2307 (Ftranspose_regions): Use modify_text.
2308
dc6c0eda
SM
23092013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2310
2311 * lisp.mk (lisp): Add nadvice.elc.
2312
8f3a2c26
DA
23132013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2314
2315 New macro to iterate over live buffers similar to frames.
2316 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2317 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2318 Declare buffer-related variables here to offload lisp.h.
2319 * buffer.c (Vbuffer_alist): Adjust comment.
2320 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2321 (other_buffer_safely):
2322 * data.c (store_symval_forwarding):
2323 * dispnew.c (Fframe_or_buffer_changed_p):
2324 * fileio.c (Fdo_auto_save):
2325 * filelock.c (unlock_all_files):
2326 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2327
e0fdb694
PE
23282013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2329
2330 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2331 * callproc.c (create_temp_file):
2332 * filelock.c (create_lock_file):
2333 Assume mkostemp, since it's now provided by Gnulib.
2334
63f5c6c2
EZ
23352013-08-04 Eli Zaretskii <eliz@gnu.org>
2336
2337 * w32.c (mkostemp): New function.
2338 (mktemp): Remove, no longer used. Most of the code reused in
2339 mkostemp. (Bug#15015)
484ab239 2340 (mktemp): Don't undef.
63f5c6c2 2341
f0b79313
DA
23422013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2343
2344 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2345 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2346 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2347 (free_glyph_pool, check_glyph_memory): Likewise for
2348 all users. Adjust comments where appropriate.
2349
98f638d6
PE
23502013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 * composite.h: Minor fixups.
2353 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2354 to fix a misspelling, and change it to an inline function while
2355 we're at it (it need not be a macro). All uses changed.
2356 (composition_method, composition_valid_p):
2357 Rewrite to avoid assignments in if-conditions.
2358
75c59fb3
DA
23592013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2360
2361 Do not use global Lisp_Object in composition macros.
2362 * composite.h (composition_temp): Remove declaration.
2363 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2364 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2365 (compose_region): Remove the leftover.
75c59fb3
DA
2366 * composite.c (composition_temp): Remove.
2367 (run_composition_function, update_compositions)
2368 (composition_compute_stop_pos, composition_adjust_point)
2369 (Ffind_composition_internal):
2370 * coding.c (handle_composition_annotation):
2371 * xdisp.c (handle_composition_prop, check_point_in_composition):
2372 Related users changed.
2373
a10c8269
DA
23742013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2375
2376 Drop FRAME_PTR typedef.
2377 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2378 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2379 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2380 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2381 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2382 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2383 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2384 All related users changed.
2385
a104f656
SM
23862013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2387
2388 * eval.c (default_toplevel_binding): New function.
2389 (Fdefvar): Use it.
2390 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2391 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2392 (syms_of_eval): Export them.
2393 * data.c (Fdefault_value): Micro cleanup.
2394 * term.c (init_tty): Use "false".
2395
4b5c9326
DA
23962013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2397
2398 Fix X GC leak in GTK and raw (no toolkit) X ports.
2399 * xterm.c (x_free_frame_resources): If white and black relief
2400 GCs are allocated, always free them here.
2401 * xfns.c (x_make_gc): Omit redundant initialization.
2402 * widget.c (create_frame_gcs): Remove the leftover.
2403 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2404 in x_free_frame_resources.
2405
b19aa636
JD
24062013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2407
2408 * nsterm.m (windowWillResize:toSize:): Only change title if
2409 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2410 modifying it.
2411 (viewDidEndLiveResize): New method.
2412
2413 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2414 inside NS_IMPL_COCOA.
2415
af1f7e06
DA
24162013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2417
2418 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2419 Do not check whether undo is enabled because record_insert and
2420 record_delete does that themselves.
2421
65b02bb9
DA
24222013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2423
2424 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2425 member which is not really used any more.
2426 (FRAME_XIC_BASE_FONTNAME): Remove.
2427 * xfns.c (xic_free_fontset): Adjust user.
2428 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2429 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2430 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2431 (xdialog_show): Use eassert for debugging check.
7ee0f047 2432 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2433
6318cde0
PE
24342013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * fileio.c, fns.c (merge): Move extern decl from here ...
2437 * lisp.h (merge): ... to here.
2438
6c1a09ba
DA
24392013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2440
2441 Fix last font-related change.
2442 * w32font.h (w32font_list_internal, w32font_match_internal):
2443 Fix prototype.
2444 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2445 (uniscribe_list_family): Adjust to match font API change.
2446 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2447 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2448
f8c20208
DA
24492013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2450
2451 * frame.h (FRAME_MOUSE_UPDATE):
2452 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2453 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2454
fdb396e2
DA
24552013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2456
2457 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2458 * font.h (struct font_driver): Change list, match, and list_family
2459 functions to accept struct frame * as first arg.
068f9124
SM
2460 * font.c (font_score, font_compare, font_sort_entities):
2461 Remove prototypes.
fdb396e2
DA
2462 (font_sort_entities, font_list_entities, font_select_entity):
2463 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2464 match font API change.
2465 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2466 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2467 * ftxfont.c (ftxfont_list, ftxfont_match):
2468 * xftfont.c (xftfont_list, xftfont_match):
2469 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2470 * w32font.c (w32font_list, w32font_match, w32font_list):
2471 (w32font_list_internal, w32_font_match_internal): Likewise.
2472 * xfaces.c (Fx_family_fonts): Adjust user.
2473
52b8a085
DA
24742013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2475
2476 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2477 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2478 only if HAVE_X_WINDOWS is in use.
2479 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2480 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2481 * w32term.c (x_wm_set_icon_position): Likewise.
2482 * w32fns.c (x_icon): Adjust user.
2483
c791c18e
DA
24842013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2485
2486 * xterm.c (last_mouse_press_frame): Remove the
2487 leftover which is not really used any more.
2488 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2489 (x_flush): Call XFlush once per each X display, not frame.
2490 This is better because this code always unconditionally skips
2491 non-X frames in Vframe_list and issues the only XFlush if we
2492 have more than one X frame on the same X display.
2f935d86
DA
2493 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2494 Use bool for booleans.
2495 (x_draw_glyph_string_background, cvt_string_to_pixel):
2496 (cvt_pixel_dtor): Drop unnecessary prototypes.
2497 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2498
f435830e
DA
24992013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2500
2501 Drop unnecessary functions that deals with frame pixel size.
2502 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2503 (x_pixel_height): Drop prototypes.
2504 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2505 (x_pixel_height): Drop implementations.
2506 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2507 which should be always valid for window frame.
2508 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2509 * w32menu.c (Fx_popup_dialog):
2510 * xmenu.c (Fx_popup_dialog): Likewise for both.
2511
84231434
DA
25122013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2513
2514 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2515 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2516 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2517 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2518 and mention nil frame in docstring.
84231434 2519
959067a1
DA
25202013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2521
2522 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2523 (x_figure_window_size): Likewise. Adjust to return long.
2524 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2525 (toplevel): Move Qterminal_live_p to...
2526 * terminal.c (toplevel): ...here, make it static, and...
2527 (syms_of_terminal): ...DEFSYM here.
2528 * frame.h (Qterminal_live_p): Remove declaration.
2529 (make_frame, x_figure_window_size): Adjust prototype.
2530 * nsfns.m (Fx_create_frame): Use long for window flags.
2531
f4b169ce
PE
25322013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2535 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2536 Do not assume that emacs_close (INT_MAX) is a no-op.
2537
bee6a2c7
DA
25382013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2539
2540 * xfaces.c (make_face_cache): For struct face_cache, prefer
2541 xmalloc to xzalloc and so avoid redundant call to memset.
2542 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2543
d7e6881a
DA
25442013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2545
2546 * fringe.c (draw_window_fringes, update_window_fringes)
2547 (compute_fringe_widths):
2548 * w32term.c (x_draw_glyph_string):
2549 * window.c (candidate_window_p, Frecenter):
2550 * xfaces.c (realize_basic_faces, realize_default_face)
2551 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2552 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2553 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2554 * xmenu.c (Fx_menu_bar_open_internal):
2555 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2556 * xsettings.c (xft_settings_event):
2557 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2558 Use bool for booleans. Adjust style and comments where
2559 appropriate.
2560 * dispextern.h (draw_window_fringes, update_window_fringes)
2561 (compute_fringe_widths):
2562 * xterm.h (x_had_errors_p): Adjust prototype.
2563
ec3058af
DA
25642013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2565
2566 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2567 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2568
218e0637
DA
25692013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2570
2571 * fns.c (toplevel): Remove comment before Fsafe_length because
2572 it checks for QUIT.
2573
e560aba9
PE
25742013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2577
2e5ce5de
EZ
25782013-07-28 Eli Zaretskii <eliz@gnu.org>
2579
2580 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2581 frame which got the message is still alive, before dereferencing
2582 its pointer. (Bug#14970)
2583
2584 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2585 be a live window, before using it as such. (Bug#14970)
2586
e95da6d3
EZ
25872013-07-27 Eli Zaretskii <eliz@gnu.org>
2588
2589 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2590 w32_detect_focus_change instead of doing part of its job by hand.
2591 This fixes the problem whereby FOCUS_OUT events were not sent to
2592 the event queue.
2593
a8f93651
EZ
25942013-07-26 Eli Zaretskii <eliz@gnu.org>
2595
fec92060
EZ
2596 * process.c (Fprocess_list): Doc fix.
2597
a8f93651
EZ
2598 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2599 being re-exposed only if it didn't ask to become visible.
2600 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2601 was previously iconified. (Bug#14841)
2602 (x_iconify_frame): Mark the frame iconified.
2603
d5a7a9d9
PE
26042013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2605
2606 Fix minor problems found by static checking.
2607 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2608 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2609
56ea7291
SM
26102013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2611
2612 * eval.c (set_specpdl_old_value): New function.
2613 (unbind_to): Minor simplification.
2614 (get_backtrace_frame): New function.
2615 (Fbacktrace_frame): Use it. Add `base' argument.
2616 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2617 (syms_of_eval): Export backtrace-eval.
2618 * xterm.c (x_focus_changed): Simplify.
2619
9d611ffe
PE
26202013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2621
2622 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2623
999c74e3
EZ
26242013-07-24 Eli Zaretskii <eliz@gnu.org>
2625
2626 * xdisp.c (redisplay_window): Instead of moving point out of
2627 scroll margin, reject the force_start method, and try scrolling
2628 instead. (Bug#14780)
2629
198fa217
KB
26302013-07-24 Ken Brown <kbrown@cornell.edu>
2631
2632 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2633 (Bug#14944).
2634
53840e55
PE
26352013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2636
2637 * eval.c (Fprogn): Do not check that BODY is a proper list.
2638 This undoes the previous change. The check slows down the
2639 interpreter, and is not needed to prevent a crash. See
2640 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2641
60967f56
GM
26422013-07-23 Glenn Morris <rgm@gnu.org>
2643
2644 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2645
9ca960e2
PE
26462013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2647
a29c3e6d
PE
2648 Port to GNU/Linux systems with tinfo but not ncurses.
2649 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2650 to decide whether ncurses is being used. Without this change,
2651 GCC complains about tgetent not being declared, on a system
2652 that has tinfo installed but ncurses not installed.
2653
f274311c
PE
2654 * eval.c (Fprogn): Check that BODY is a proper list.
2655
16b0520a
PE
2656 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2657 * data.c (Fsetq_default):
2658 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2659 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2660 (Fcondition_case):
2661 Tune by taking advantage of the fact that ARGS is always a list
2662 when a function is declared to have UNEVALLED args.
2663
9ca960e2
PE
2664 * emacsgtkfixed.c: Port to GCC 4.6.
2665 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2666
afacaa1b
JB
26672013-07-23 Juanma Barranquero <lekktu@gmail.com>
2668
2669 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2670 here to silence compiler warnings.
2671
368a85a4
PE
26722013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2675 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2676 from messing up Emacs's 'struct frame' (Bug#14923).
2677
f4e891b5
PE
26782013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * alloc.c (make_save_ptr_ptr): Define this function.
2681 It was inadvertently omitted. It's needed only if
2682 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2683
96c8b65e
JD
26842013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2685
2686 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2687 frame have focus (Bug#14895).
2688
ee010797
PE
26892013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 Avoid vfork-related deadlock more cleanly.
2692 * callproc.c (child_setup): When the child's exec fails, output
2693 the program name, as that's more useful. Use O_NONBLOCK to avoid
2694 deadlock.
2695 * process.c (create_process_1): Remove; no longer needed.
2696 (create_process): Remove timer hack; no longer needed, now that
2697 the child avoids deadlock.
2698
f0398ec1 26992013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2700
2701 * image.c (Fimage_flush): Fix doc typo.
2702
b2a069c2
PE
27032013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2704
6496aec9
PE
2705 Fix array bounds violation when pty allocation fails.
2706 * process.c (PTY_NAME_SIZE): New constant.
2707 (pty_name): Remove static variable; it's now auto.
2708 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2709 Take pty_name as an arg rather than using a static variable.
2710 All callers changed.
2711 (create_process): Recover pty_flag from process, not from volatile local.
2712 (create_pty): Stay inside array even when pty allocation fails.
2713 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2714
b2a069c2
PE
2715 * lread.c (Fload): Avoid initialization only when lint checking.
2716 Mention that it's needed only for older GCCs.
2717
99107004
KH
27182013-07-20 Kenichi Handa <handa@gnu.org>
2719
2720 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2721 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2722
6b1b199d
AS
27232013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2724
2725 * lread.c (Fload): Avoid uninitialized warning.
2726
4195afc3
PE
27272013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2728
3f5bef16
PE
2729 Fix some minor file descriptor leaks and related glitches.
2730 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2731 (create_lock_file): Use write, not emacs_write.
2732 * image.c (slurp_file, png_load_body):
2733 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2734 (server_accept_connection):
2735 Don't leak an fd on memory allocation failure.
2736 * image.c (slurp_file): Add a cheap heuristic for growing files.
2737 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2738 as that's what the other routines do. Maybe input need not be
2739 blocked at all, but it's better to be consistent.
2740 Avoid undefined behavior when strlen is zero.
2741
4195afc3
PE
2742 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2743 (NSTATICS): Now a constant; doesn't need to be a macro.
2744
a1aeeffe
RS
27452013-07-19 Richard Stallman <rms@gnu.org>
2746
2747 * coding.c (decode_coding_utf_8): Add simple loop for fast
2748 processing of ASCII characters.
2749
63b34baa
PE
27502013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2751
2752 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2753
621dd9ac
EZ
27542013-07-19 Eli Zaretskii <eliz@gnu.org>
2755
2756 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2757 unportable 'struct x_display_info'.
2758 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2759 is a portable type.
2760
1396ac86
PE
27612013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2762
ab9980cd
PE
2763 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2764 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2765 or fscanf fails.
2766 (system_process_attributes): Prefer plain char to unsigned char
2767 when either will do. Clean up properly if interrupted or if
068f9124
SM
2768 memory allocations fail. Don't assume sscanf succeeds.
2769 Remove no-longer-needed workaround to stop GCC from whining.
2770 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2771 bit more carefully.
2772
1396ac86
PE
2773 Fix obscure porting bug with varargs functions.
2774 The code assumed that int is treated like ptrdiff_t in a vararg
2775 function, which is not a portable assumption. There was a similar
2776 -- though these days less likely -- porting problem with various
2777 assumptions that pointers of different types all smell the same as
2778 far as vararg functions is conserved. To make this problem less
2779 likely in the future, redo the API to use varargs functions.
2780 * alloc.c (make_save_value): Remove this vararg function.
2781 All uses changed to ...
2782 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2783 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2784 New functions.
2785 (make_save_ptr): Rename from make_save_pointer, for consistency with
2786 the above. Define only on platforms that need it. All uses changed.
2787
4d19d194
PE
27882013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2789
2790 * keyboard.c: Try to fix typos in previous change.
2791 (DISPLAY_LIST_INFO): New macro.
2792 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2793 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2794
945c5bb1
JB
27952013-07-18 Juanma Barranquero <lekktu@gmail.com>
2796
2797 * keyboard.c (kbd_buffer_get_event):
2798 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2799 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2800
f4b1eb36
PE
28012013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2802
5e679a2c
PE
2803 * filelock.c: Fix unlikely file descriptor leaks.
2804 (get_boot_time_1): Rework to avoid using emacs_open.
2805 This doesn't actually fix a leak, but is better anyway.
2806 (read_lock_data): Use read, not emacs_read.
2807
a8cd4836
PE
2808 * doc.c: Fix minor memory and file descriptor leaks.
2809 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2810 (get_doc_string, Fsnarf_documentation):
2811 Fix file descriptor leak on error.
2812
ef30e638
PE
2813 * term.c: Fix minor fdopen-related file descriptor leaks.
2814 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2815 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2816
f4b1eb36
PE
2817 * charset.c: Fix file descriptor leaks and errno issues.
2818 Include <errno.h>.
2819 (load_charset_map_from_file): Don't leak file descriptor on error.
2820 Use plain record_xmalloc since the allocation is larger than
2821 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2822 of entries.
2823 * eval.c (record_unwind_protect_nothing):
2824 * fileio.c (fclose_unwind):
2825 New functions.
2826 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2827 The replacement doesn't block input, but that no longer seems
2828 necessary.
2829
b648c163
PE
28302013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2831
a0931322
PE
2832 * lread.c: Fix file descriptor leaks and errno issues.
2833 (Fload): Close some races that leaked fds or streams when 'load'
2834 was interrupted.
2835 (Fload, openp): Report error number of last nontrivial failure to open.
2836 ENOENT counts as trivial.
2837 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2838 New functions.
2839 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2840 now that the function is always called with a nonnegative arg.
2841 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2842 All uses replaced with ...
2843 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2844
b648c163
PE
2845 A few more minor file errno-reporting bugs.
2846 * callproc.c (Fcall_process):
2847 * doc.c (Fsnarf_documentation):
2848 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2849 * process.c (set_socket_option):
2850 Don't let a constructor trash errno.
2851 * doc.c: Include <errno.h>.
2852
b1dc4084
JB
28532013-07-16 Juanma Barranquero <lekktu@gmail.com>
2854
2855 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2856
c43843aa
PE
28572013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2858
50a30cce
PE
2859 Fix w32 bug with call-process-region (Bug#14885).
2860 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2861 to Fcall_process when the input is empty. This simplifies the
2862 code a bit. It makes no difference on POSIXish platforms but
2863 apparently it fixes a bug on w32.
2864
44e18199 2865 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2866 * fileio.c (close_file_unwind): Don't close if FD is negative;
2867 this can happen when unwinding a zapped file descriptor.
2868 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2869 in case Emacs runs out of memory between the two unwind-protects.
2870 Don't trash errno when closing FD.
2871 Zap the FD in the specpdl when closing it, instead of deferring
2872 the removal of the unwind-protect; this fixes a bug where a child
2873 function unwinds the stack past us.
2874
27e498e6
PE
2875 New unwind-protect flavors to better type-check C callbacks.
2876 This also lessens the need to write wrappers for callbacks,
2877 and the need for make_save_pointer.
2878 * alloca.c (free_save_value):
2879 * atimer.c (run_all_atimers):
2880 Now extern.
2881 * alloc.c (safe_alloca_unwind):
2882 * atimer.c (unwind_stop_other_atimers):
2883 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2884 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2885 * minibuf.c (choose_minibuf_frame_1):
2886 * process.c (make_serial_process_unwind):
2887 * xdisp.h (pop_message_unwind):
2888 * xselect.c (queue_selection_requests_unwind):
2889 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2890 * alloca.c (record_xmalloc):
2891 Prefer record_unwind_protect_ptr to record_unwind_protect with
2892 make_save_pointer.
2893 * alloca.c (Fgarbage_collect):
2894 Prefer record_unwind_protect_void to passing a dummy.
2895 * buffer.c (restore_buffer):
2896 * window.c (restore_window_configuration):
2897 * xfns.c, w32fns.c (do_unwind_create_frame)
2898 New wrapper. All record-unwind uses of wrappee changed.
2899 * buffer.c (set_buffer_if_live):
2900 * callproc.c (call_process_cleanup, delete_temp_file):
2901 * coding.c (code_conversion_restore):
2902 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2903 * editfns.c (save_excursion_restore)
2904 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2905 (save_restriction_restore):
2906 * eval.c (restore_stack_limits, un_autoload):
2907 * fns.c (require_unwind):
2908 * keyboard.c (recursive_edit_unwind, tracking_off):
2909 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2910 * macros.c (pop_kbd_macro, restore_menu_items):
2911 * nsfns.m (unwind_create_frame):
2912 * print.c (print_unwind):
2913 * process.c (start_process_unwind):
2914 * search.c (unwind_set_match_data):
2915 * window.c (select_window_norecord, select_frame_norecord):
2916 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2917 (fast_set_selected_frame):
2918 * xfns.c, w32fns.c (unwind_create_tip_frame):
2919 Return void, not a dummy Lisp_Object. All uses changed.
2920 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2921 * callproc.c (call_process_kill):
2922 * fileio.c (restore_point_unwind, decide_coding_unwind)
2923 (build_annotations_unwind):
2924 * insdel.c (Fcombine_after_change_execute_1):
2925 * keyboard.c (read_char_help_form_unwind):
2926 * menu.c (unuse_menu_items):
2927 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2928 * sound.c (sound_cleanup):
2929 * xdisp.c (unwind_redisplay):
2930 * xfns.c (clean_up_dialog):
2931 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2932 Accept no args and return void, instead of accepting and returning
2933 a dummy Lisp_Object. All uses changed.
2934 * cygw32.c (fchdir_unwind):
2935 * fileio.c (close_file_unwind):
2936 * keyboard.c (restore_kboard_configuration):
2937 * lread.c (readevalllop_1):
2938 * process.c (wait_reading_process_output_unwind):
2939 Accept int and return void, rather than accepting an Emacs integer
2940 and returning a dummy object. In some cases this fixes an
2941 unlikely bug when the corresponding int is outside Emacs integer
2942 range. All uses changed.
2943 * dired.c (directory_files_internal_unwind):
2944 * fileio.c (do_auto_save_unwind):
2945 * gtkutil.c (pop_down_dialog):
2946 * insdel.c (reset_var_on_error):
2947 * lread.c (load_unwind):
2948 * xfns.c (clean_up_file_dialog):
2949 * xmenu.c, nsmenu.m (pop_down_menu):
2950 * xmenu.c (cleanup_widget_value_tree):
2951 * xselect.c (wait_for_property_change_unwind):
2952 Accept pointer and return void, rather than accepting an Emacs
2953 save value encapsulating the pointer and returning a dummy object.
2954 All uses changed.
2955 * editfns.c (Fformat): Update the saved pointer directly via
2956 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2957 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2958 (unwind_body): New function.
2959 (record_unwind_protect): First arg is now a function returning void,
2960 not a dummy Lisp_Object.
2961 (record_unwind_protect_ptr, record_unwind_protect_int)
2962 (record_unwind_protect_void): New functions.
2963 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2964 * fileio.c (struct auto_save_unwind): New type.
2965 (do_auto_save_unwind): Use it.
2966 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2967 * insdel.c (struct rvoe_arg): New type.
2968 (reset_var_on_error): Use it.
2969 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2970 New constants.
2971 (specbinding_func): Remove; there are now several such functions.
2972 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2973 (set_unwind_protect_ptr): New function.
2974 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2975
4e604a5d
PE
2976 Be simpler and more consistent about reporting I/O errors.
2977 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2978 Say "Read error" and "Write error", rather than "I/O error", or
2979 "IO error reading", or "IO error writing", when a read or write
2980 error occurs.
2981 * process.c (Fmake_network_process, wait_reading_process_output)
2982 (send_process, Fprocess_send_eof, wait_reading_process_output):
2983 Capitalize diagnostics consistently. Put "failed foo" at the
2984 start of the diagnostic, so that we don't capitalize the
2985 function name "foo". Consistently say "failed" for such
2986 diagnostics.
2987 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2988 All callers changed. This is so it can use report_file_error.
2989 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2990 diagnostics consistently as above.
2991
a9757f6a
PE
2992 * fileio.c (report_file_errno): Fix errno reporting bug.
2993 If the file name is neither null nor a pair, package it up as a
2994 singleton list. All callers changed, both to this function and to
2995 report_file_error. This fixes a bug where the memory allocator
2996 invoked by list1 set errno so that the immediately following
2997 report_file_error reported the wrong errno value.
2998
c43843aa
PE
2999 Fix minor problems found by --enable-gcc-warnings.
3000 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3001 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3002
18c26d81
JD
30032013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3004
3005 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3006 Set event->arg to Qt if switch-event shall be generated.
3007 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3008
3009 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3010
3011 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3012 FOCUS_OUT_EVENT.
3013
3014 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3015 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3016 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3017 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3018 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3019 and there is a focused frame.
3020 (head_table): Add focus-in and focus-out.
3021 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3022 bind to handle-focus-in/out.
3023
3024 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3025 (Fhandle_switch_frame): Call Fhandle_focus_in.
3026 (syms_of_frame): defsubr handle-focus-in/out.
3027
6c6f1994
PE
30282013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3029
c7ddc792
PE
3030 Fix porting bug to older POSIXish platforms (Bug#14862).
3031 * sysdep.c (emacs_pipe): New function, that implements
3032 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3033 This should port better to CentOS 5 and to Mac OS X 10.6.
3034 All calls to pipe2 changed.
3035
6c6f1994
PE
3036 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3037 This makes the code easier to read and the executable a bit smaller.
3038 Do not replace all calls to Fcons that happen to create lists,
3039 just calls that are intended to create lists. For example, when
3040 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3041 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3042 Similarly for list2 through list5.
3043 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3044 * bytecode.c (exec_byte_code):
3045 * callint.c (quotify_arg, Fcall_interactively):
3046 * callproc.c (Fcall_process, create_temp_file):
3047 * charset.c (load_charset_map_from_file)
3048 (Fdefine_charset_internal, init_charset):
3049 * coding.c (get_translation_table, detect_coding_system)
3050 (Fcheck_coding_systems_region)
3051 (Fset_terminal_coding_system_internal)
3052 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3053 * composite.c (update_compositions, Ffind_composition_internal):
3054 * dired.c (directory_files_internal, file_name_completion)
3055 (Fsystem_users):
3056 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3057 * doc.c (Fsnarf_documentation):
3058 * editfns.c (Fmessage_box):
3059 * emacs.c (main):
3060 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3061 (Feval, eval_sub, Ffuncall, apply_lambda):
3062 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3063 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3064 (Fset_file_times, Finsert_file_contents)
3065 (Fchoose_write_coding_system, Fwrite_region):
3066 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3067 * font.c (font_registry_charsets, font_parse_fcname)
3068 (font_prepare_cache, font_update_drivers, Flist_fonts):
3069 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3070 * frame.c (make_frame, Fmake_terminal_frame)
3071 (x_set_frame_parameters, x_report_frame_params)
3072 (x_default_parameter, Fx_parse_geometry):
3073 * ftfont.c (syms_of_ftfont):
3074 * image.c (gif_load):
3075 * keyboard.c (command_loop_1):
3076 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3077 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3078 (Fminor_mode_key_binding, accessible_keymaps_1)
3079 (Faccessible_keymaps, Fwhere_is_internal):
3080 * lread.c (read_emacs_mule_char):
3081 * menu.c (find_and_return_menu_selection):
3082 * minibuf.c (get_minibuffer):
3083 * nsfns.m (Fns_perform_service):
3084 * nsfont.m (ns_script_to_charset):
3085 * nsmenu.m (ns_popup_dialog):
3086 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3087 (Fx_own_selection_internal):
3088 * nsterm.m (append2):
3089 * print.c (Fredirect_debugging_output)
3090 (print_prune_string_charset):
3091 * process.c (Fdelete_process, Fprocess_contact)
3092 (Fformat_network_address, set_socket_option)
3093 (read_and_dispose_of_process_output, write_queue_push)
3094 (send_process, exec_sentinel):
3095 * sound.c (Fplay_sound_internal):
3096 * textprop.c (validate_plist, add_properties)
3097 (Fput_text_property, Fadd_face_text_property)
3098 (copy_text_properties, text_property_list, syms_of_textprop):
3099 * unexaix.c (report_error):
3100 * unexcoff.c (report_error):
3101 * unexsol.c (unexec):
3102 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3103 (Fformat_mode_line, syms_of_xdisp):
3104 * xfaces.c (set_font_frame_param)
3105 (Finternal_lisp_face_attribute_values)
3106 (Finternal_merge_in_global_face, syms_of_xfaces):
3107 * xfns.c (x_default_scroll_bar_color_parameter)
3108 (x_default_font_parameter, x_create_tip_frame):
3109 * xfont.c (xfont_supported_scripts):
3110 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3111 (menu_help_callback, xmenu_show):
3112 * xml.c (make_dom):
3113 * xterm.c (set_wm_state):
3114 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3115 and similarly for list2 through list5.
3116
bafe80ce
PE
31172013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3118
3119 * callproc.c (Fcall_process_region): Fix minor race and tune.
3120 (create_temp_file): New function, with the temp-file-creation part
3121 of the old Fcall_process_region. Use Fcopy_sequence to create the
3122 temp file name, rather than alloca + build_string, for simplicity.
3123 Don't bother to block input around the temp file creation;
068f9124
SM
3124 shouldn't be needed. Simplify use of mktemp.
3125 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3126 this closes an unlikely race where the temp file was not removed.
3127 Use memcpy rather than an open-coded loop.
3128 (Fcall_process_region): Use the new function. If the input is
3129 empty, redirect from /dev/null rather than from a newly created
3130 empty temp file; this avoids unnecessary file system traffic.
3131
4700b5a5
PE
31322013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3133
5c97beae
PE
3134 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3135 Simplify by making this case like the other two. This is a bit
3136 slower on obsolete hosts, but the extra complexity isn't worth it.
3137
4700b5a5
PE
3138 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3139 * process.c (create_process) [!DOS_NT]:
3140 Remove now-unnecessary calls to emacs_close.
3141
f9a74c4c
EZ
31422013-07-13 Eli Zaretskii <eliz@gnu.org>
3143
922ae7ee
EZ
3144 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3145 returning early. (Bug#14850)
3146
f9a74c4c
EZ
3147 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3148 and inhibit-iso-escape-detection attributes of 'undecided'.
3149 (Bug#14822)
3150
5e301d76
PE
31512013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3152
69e0e5ee
PE
3153 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3154 Reported by Herbert J. Skuhra in
3155 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3156
5e301d76
PE
3157 Don't lose top specpdl entry when memory is exhausted.
3158 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3159 specpdl overflow here, to simplify callers; all callers changed.
3160 Always reserve an unused entry at the stack top; this avoids
3161 losing the top entry's information when memory is exhausted.
3162
7e649856
PE
31632013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3164
a773ed9a
PE
3165 Clean up errno reporting and fix some errno-reporting bugs.
3166 * callproc.c (Fcall_process):
3167 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3168 * process.c (create_process, Fmake_network_process):
3169 * unexaix.c (report_error):
3170 * unexcoff.c (report_error):
3171 Be more careful about reporting the errno of failed operations.
3172 The code previously reported the wrong errno sometimes.
3173 Also, prefer report_file_errno to setting errno + report_file_error.
3174 (Fcall_process): Look at openp return value rather than at path,
3175 as that's a bit faster and clearer when there's a numeric predicate.
3176 * fileio.c (report_file_errno): New function, with most of the
3177 old contents of report_file_error.
3178 (report_file_error): Use it.
3179 (Ffile_exists_p, Ffile_accessible_directory_p):
3180 Set errno to 0 when it is junk.
3181 * fileio.c (Faccess_file):
3182 * image.c (x_create_bitmap_from_file):
3183 Use faccessat rather than opening the file, to avoid the hassle of
3184 having a file descriptor open.
3185 * lisp.h (report_file_errno): New decl.
3186 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3187
7e649856
PE
3188 Minor EBADF fixes.
3189 * process.c (create_process, wait_reading_process_output) [AIX]:
3190 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3191 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3192 a multithreaded environment anyway).
3193 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3194
f6774c1a
AS
31952013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3196
3197 * image.c (x_find_image_file): Don't close a remote file handle.
3198
bacba3c2
PE
31992013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3200
3201 Fix races with threads and file descriptors.
3202 * callproc.c (Fcall_process_region):
3203 * dired.c (open_directory):
3204 * emacs.c (main, Fdaemon_initialized):
3205 * image.c (x_find_image_file):
3206 * inotify.c (Finotify_rm_watch):
3207 * lread.c (Flocate_file_internal):
3208 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3209 * term.c (term_mouse_moveto, init_tty):
3210 * termcap.c (tgetent):
3211 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3212 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3213 * unexhp9k800.c, unexmacosx.c (unexec):
3214 * callproc.c (Fcall_process_region):
3215 Use emacs_close, not close.
3216 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3217 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3218 and posix_close function on current platforms (which all lack them).
3219 (emacs_close): Use it. This should fix the races on GNU/Linux and
3220 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3221 and it should avoid closing random victim file descriptors on
3222 other platforms.
3223
653d4f43
PE
32242013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3225
c8536ec4
PE
3226 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3227 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3228 Touch up doc a bit.
3229
9c203066
PE
3230 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3231 This is for .gdbinit xbacktrace.
3232
653d4f43
PE
3233 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3234 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3235 (emacs_set_tty): Now static.
3236 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3237 * term.c (tty_capable_p, tty_default_color_capabilities)
3238 (get_tty_terminal, term_mouse_movement)
3239 (handle_one_term_event, init_tty, maybe_fatal):
3240 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3241 (tgetent, scan_file, name_match, compare_contin):
3242 * terminal.c (get_terminal):
3243 Use bool for boolean.
3244 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3245 Prefer char to unsigned char if either will do.
3246 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3247 (tty_write_glyphs): Prefer int to unsigned.
3248 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3249 All callers changed.
3250 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3251
45b683a1
PE
32522013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3253
29abe551
PE
3254 Port to C89.
3255 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3256 (B__dummy__): New dummy symbol, to pacify C89.
3257 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3258 they can't grok varargs macros.
3259 * dispnew.c (add_window_display_history)
3260 (add_frame_display_history):
3261 * print.c (print_object):
3262 * xdisp.c (debug_method_add):
3263 Use %p printf format only for void pointers.
3264 * emacs.c (usage_message): New constant, replacing ...
3265 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3266 (main): Adjust to usage reorg.
3267 * fns.c (syms_of_fns):
3268 * profiler.c (syms_of_profiler):
3269 Don't use non-constant struct initializers.
3270 * gnutls.h (gnutls_initstage_t):
3271 * lisp.h (enum Lisp_Fwd_Type):
3272 * lread.c (lisp_file_lexically_bound_p):
3273 * xsettings.c (anonymous enum):
3274 Remove trailing comma.
3275 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3276 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3277 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3278 (DEFUN): Use it.
3279 * regex.c (const_re_char): New type, to pacify strict C89.
3280 All uses of 'const re_char' replaced to use it.
3281 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3282 with glibc when strict C89. This change is imported from gnulib.
3283 All uses changed.
3284 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3285 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3286 Omit GNU_LINUX implementation, since it requires long long.
3287 * xterm.c (x_draw_underwave):
3288 Do not assume the traditional order of struct's members.
3289 (x_term_init): Rewrite to avoid the need for non-constant structure
3290 initializers.
3291
45b683a1 3292 Syntax cleanup, mostly replacing macros with functions.
763a086d 3293 This removes the need for the syntax_temp hack.
45b683a1
PE
3294 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3295 * syntax.c (SYNTAX_INLINE): New macro.
3296 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3297 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3298 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3299 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3300 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3301 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3302 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3303 Now constants, not macros.
3304 (syntax_temp) [!__GNUC__]: Remove.
3305 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3306 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3307 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3308 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3309 Move here from syntax.h; now functions, not macros. Except for the
3310 last function, these are static since only syntax.c uses them.
3311 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3312 All uses changed. Now a function, not a macro; use this fact
3313 to simplify the code.
3314 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3315 compiler bugs; no longer relevant.
3316 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3317 (SYNTAX_INLINE): New macro.
3318 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3319 for the new functions. Use bool for boolean member.
3320 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3321 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3322 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3323 (SETUP_BUFFER_SYNTAX_TABLE):
3324 Now extern inline functions, not macros.
3325 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3326 Remove; all uses replaced by implementation.
3327 (syntax_temp) [!__GNUC__]: Remove decl.
3328 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3329
29be4a50
JD
33302013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3331
3332 * emacs.c (main): Fix syntax error.
3333
954b166e
PE
33342013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 Timestamp fixes for undo (Bug#14824).
3337 * atimer.c (schedule_atimer):
3338 * fileio.c (Ffile_newer_than_file_p):
3339 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3340 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3341 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3342 (syms_of_fileio): Remove Sclear_visited_file_name.
3343 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3344 file doesn't exist; this avoids an ambiguity with negative timestamps.
3345 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3346 * systime.h (make_emacs_time, invalid_emacs_time):
3347 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3348 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3349 * undo.c (record_first_change): Push (visited-file-modtime) onto
3350 undo list rather than reimplementing it by hand, incorrectly.
3351
d74647c3
KB
33522013-07-09 Ken Brown <kbrown@cornell.edu>
3353
3354 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3355
3c51b96b
JB
33562013-07-09 Juanma Barranquero <lekktu@gmail.com>
3357
3358 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3359
4ebbdd67
PE
33602013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3361
3362 Handle errno and exit status a bit more carefully.
3363 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3364 number into an exit status. Instead, use EXIT_CANCELED.
3365 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3366 * callproc.c (relocate_fd):
3367 * emacs.c (close_output_streams, main):
3368 * process.c (create_process):
3369 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3370 Use emacs_perror for simplicity.
3371 * callproc.c (relocate_fd, main):
3372 * sysdep.c (sys_subshell):
3373 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3374 (shut_down_emacs): Use emacs_write, not write.
3375 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3376 * fileio.c (Fcopy_file, e_write):
3377 * nsterm.m (ns_select):
3378 * process.c (send_process):
3379 * sound.c (vox_write):
3380 Use emacs_write_sig, not emacs_write.
3381 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3382 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3383 New constants.
3384 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3385 of write.
3386 (emacs_full_write): New function.
3387 (emacs_write): Rewrite to use it.
3388 (emacswrite_sig, emacs_perror): New functions.
3389 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3390
44e18199 33912013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3392
3393 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3394 on NS even if it is present. Pixmap on NS is a void*.
3395
9caab067
PE
33962013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3397
3398 Port to Ubuntu 10 (Bug#14803).
3399 Problem reported by T.V. Raman.
3400 * process.c (close_on_exec, accept4, process_socket):
3401 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3402
1d442672
EZ
34032013-07-07 Eli Zaretskii <eliz@gnu.org>
3404
3405 * w32.c (sys_dup): Declare prototype.
3406
3407 * filelock.c:
3408 * emacs.c:
3409 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3410
067428c1
PE
34112013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3412
3413 Make file descriptors close-on-exec when possible (Bug#14803).
3414 This simplifies Emacs a bit, since it no longer needs to worry
3415 about closing file descriptors by hand in some cases.
3416 It also fixes some unlikely races. Not all such races, as
3417 libraries often open files internally without setting
3418 close-on-exec, but it's an improvement.
3419 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3420 * callproc.c (Fcall_process) [!MSDOS]:
3421 * emacs.c (main) [!DOS_NT]:
3422 * nsterm.m (ns_term_init):
3423 * process.c (create_process):
3424 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3425 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3426 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3427 Prefer mkostemp with O_CLOEXEC to mkstemp.
3428 * callproc.c (relocate_fd) [!WINDOWSNT]:
3429 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3430 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3431 now using pipe2.
3432 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3433 Make the resulting file descriptor close-on-exec.
3434 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3435 * lread.c (load_descriptor_list, load_descriptor_unwind):
3436 Remove; no longer needed. All uses removed.
3437 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3438 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3439 New functions.
3440 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3441 (Fmake_network_process, Fnetwork_interface_list):
3442 (Fnetwork_interface_info, server_accept_connection):
3443 Make newly-created socket close-on-exec.
3444 * sysdep.c (emacs_open, emacs_fopen):
3445 Make new-created descriptor close-on-exec.
3446 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3447 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3448
0da857dd
JD
34492013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3450
3451 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3452 for NS_IMPL_GNUSTEP.
3453
5f86adcd
PE
34542013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3455
3456 Fix openp errno handling.
3457 * callproc.c (Fcall_process): Preserve openp errno around close.
3458 * lread.c (openp): Set errno when returning -1, as some callers
3459 expect this.
3460
1afb1d07
JD
34612013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3462
3463 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3464
3465 * nsterm.h (NSSavePanel): Update comment.
3466 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3467 (ns_run_file_dialog): Declare.
3468
3469 * nsfns.m: Remove panelOK.
3470 (ns_fd_data): New.
3471 (ns_run_file_dialog): New function.
3472 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3473 event loop, so file dialog is popped up by ns_run_file_dialog, called
3474 by sendEvent (Bug#14578).
3475 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3476
3323c263
EZ
34772013-07-06 Eli Zaretskii <eliz@gnu.org>
3478
fdda0220
EZ
3479 * xdisp.c (default_line_pixel_height): New function.
3480 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3481 (try_cursor_movement, redisplay_window, try_window)
3482 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3483
068f9124
SM
3484 * window.c (window_scroll_pixel_based):
3485 use default_line_pixel_height.
fdda0220
EZ
3486
3487 * dispextern.h (default_line_pixel_height): Add prototype.
3488
3489 * frame.c (x_set_line_spacing): Accept a float value for
3490 line-spacing parameter, per the documentation.
3491
3323c263
EZ
3492 * data.c (Fmultibyte_string_p): Doc fix.
3493
47ba6d43
PE
34942013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3495
406af475
PE
3496 Use emacs_open more consistently when opening files.
3497 This handles EINTR more consistently now, and makes it easier
3498 to introduce other uniform changes to file descriptor handling.
3499 * src/systdio.h: New file.
3500 * src/buffer.c (mmap_init):
3501 * cygw32.c (chdir_to_default_directory):
3502 * dispnew.c (Fopen_termscript):
3503 * emacs.c (Fdaemon_initialized):
3504 * fileio.c (Fdo_auto_save):
3505 * image.c (slurp_file, png_load_body, jpeg_load_body):
3506 * keyboard.c (Fopen_dribble_file):
3507 * lread.c (Fload):
3508 * print.c (Fredirect_debugging_output):
3509 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3510 * termcap.c (tgetent):
3511 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3512 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3513 * w32term.c (w32_initialize) [CYGWIN]:
3514 * xfaces.c (Fx_load_color_file):
3515 Use emacs_open instead of plain open, and emacs_fopen instead of
3516 plain fopen.
3517 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3518 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3519 * callproc.c (default_output_mode): New constant.
3520 (Fcall_process): Use it to call emacs_open instead of plain creat.
3521 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3522 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3523 (emacs_fopen): New function.
3524 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3525 Include <lisp.h>, for emacs_open.
3526 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3527
47ba6d43
PE
3528 Remove duplicate #include directives.
3529 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3530 * xfaces.c:
3531 Don't include stdio.h twice.
3532 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3533 Don't include sys/types.h or stdio.h twice.
3534 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3535 * lread.c: Don't include coding.h twice.
3536 * nsfont.m: Don't include frame.h twice.
3537 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3538 * ralloc.c: Don't include <unistd.h> twice.
3539 * xdisp.c: Don't include font.h twice.
3540 * xterm.c: Don't include fontset.h twice.
3541 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3542
b9ed53d5
PE
35432013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 Scale ImageMagick images more carefully.
3546 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3547 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3548 Be more careful about avoiding undefined behavior after
3549 integer overflow and division by zero.
3550
cf13177e
YM
35512013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3552
3553 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3554 (syms_of_w32fns): DEFSYM them.
3555 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3556 (CCHDEVICENAME): Define macros if not defined.
3557 (struct MONITOR_INFO_EX): New struct.
3558 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3559 (enum_display_monitors_fn): New variable.
3560 (globals_of_w32fns): Initialize it.
3561 (Fx_display_pixel_width, Fx_display_pixel_height)
3562 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3563 multi-monitor setups in docstrings.
3564 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3565 screen size by primary monitor's millimeter per pixel.
3566 (w32_monitor_enum, w32_display_monitor_attributes_list)
3567 (w32_display_monitor_attributes_list_fallback)
3568 (Fw32_display_monitor_attributes_list): New functions.
3569 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3570
3571 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3572 if not defined.
3573 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3574
86dfb7a8
MA
35752013-07-04 Michael Albinus <michael.albinus@gmx.de>
3576
3577 * fileio.c (Qfile_notify_error): New error symbol.
3578
3579 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3580 * inotify.c (inotify_callback, symbol_to_inotifymask)
3581 (Finotify_add_watch, Finotify_rm_watch): Use it.
3582 (inotifyevent_to_event): Exchange order of cookie and file name.
3583 (Finotify_add_watch): Adapt docstring.
3584
3585 * lisp.h (Qfile_notify_error): Declare.
3586
2c1c974b
PE
35872013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3590 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3591 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3592 which did not work (see <http://bugs.gnu.org/14569#307>).
3593 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3594 && (!noninteractive || initialized)). This attempts to thread
3595 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3596
7a35b20f
JB
35972013-07-04 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3600 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3601
1ce5cd04
PE
36022013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3605 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3606 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3607 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3608
57f8c490
PE
36092013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3610
3611 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3612 Define to __sys_siglist.
3613
bcffb5ca
EZ
36142013-07-02 Eli Zaretskii <eliz@gnu.org>
3615
3616 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3617 word-wrap, so that overflow-newline-into-fringe would work in
3618 visual-line-mode. (Bug#2749)
3619 (move_it_in_display_line_to): When the last scanned display
3620 element fits exactly on the display line, and
3621 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3622 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3623 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3624 finding buffer position that corresponds to pixel coordinates,
3625 e.g. in buffer_posn_from_coords.
3626
2c41e781
JD
36272013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3628
3629 * process.c (handle_child_signal): Call catch_child_signal if
3630 NS_IMPL_GNUSTEP.
3631
c2418359
PE
36322013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3633
52a9bcae
PE
3634 Don't convert function pointers to void * and back.
3635 It isn't portable C, and it's easy enough to avoid.
3636 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3637 (make_save_value): Add support for SAVE_FUNCPOINTER.
3638 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3639 * print.c (print_object):
3640 Distinguish function from object pointers.
3641 * lisp.h (SAVE_FUNCPOINTER): New constant.
3642 (SAVE_SLOT_BITS): Adjust to it.
3643 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3644 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3645 (voidfuncptr): New typedef.
3646 (struct Lisp_Save_Value): New member data[0].funcpointer.
3647 (XSAVE_FUNCPOINTER): New function.
3648
c2418359
PE
3649 Simplify buildobj processing.
3650 * Makefile.in (buildobj.h): Make it a sequence of strings each
3651 followed by comma, rather than a single string. Put it into a
3652 .tmp file in case there's an error while generating it.
3653 (gl-stamp): Use .tmp for temp files.
3654 (mostlyclean): Clean .tmp files.
3655 * doc.c (buildobj): Move to just the routine that needs it.
3656 It's now an array of strings, so processing is simpler.
3657
8f43ce49
PE
36582013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3659
3660 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3661 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3662 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3663 Invoke malloc_enable_thread even when not interactive.
3664 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3665 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3666 in this case, since the underlying bug has now been fixed.
3667
24827db9
JB
36682013-07-01 Juanma Barranquero <lekktu@gmail.com>
3669
3670 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3671 unlinking it (bug#14691).
3672
ef099a94
MN
36732013-06-30 Michal Nazarewicz <mina86@mina86.com>
3674
3675 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3676 before checking whether buffer is modified. This lets
3677 `kill-buffer-query-functions' cancel killing of the buffer or save
3678 its content before `kill-buffer' asks user the "Buffer %s
3679 modified; kill anyway?" question.
3680
9d3f2fc2
JD
36812013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3682
3683 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3684 Let the super performKeyEquivalent deal with them (Bug#14747).
3685
e6c6c8c7
PE
36862013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3687
1d71c1d9
PE
3688 * widget.c (resize_cb): Remove unused local.
3689
8f5f35cc
PE
3690 Do not use GTK 3 if it exists but cannot be compiled.
3691 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3692 * xterm.c (x_error_handler) [!USE_GTK]:
3693 Do not use GTK 3.
3694
e6c6c8c7
PE
3695 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3696
0ba54312
EZ
36972013-06-30 Eli Zaretskii <eliz@gnu.org>
3698
5d1c3286
EZ
3699 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3700 to the valid range of values. (Bug#14753)
3701
0ba54312
EZ
3702 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3703 when moving point by using the current glyph matrix. This avoids
3704 the need to force redisplay when this function is called in a
3705 loop.
3706
9c90cc06
PE
37072013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3708
3709 Fix minor problems found by static checking.
3710 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3711 Redo the latter's body to sidestep GCC parenthesization warnings.
3712 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3713 * coding.c (detect_coding, detect_coding_system):
3714 * coding.h (struct undecided_spec):
3715 Use bool for boolean.
3716 * image.c (QCmax_width, QCmax_height): Now static.
3717 * xdisp.c (Fmove_point_visually): Remove unused local.
3718
4c672a0f
EZ
37192013-06-29 Eli Zaretskii <eliz@gnu.org>
3720
3721 * xdisp.c (Fmove_point_visually): New function.
3722
c1ea3abf
JB
37232013-06-28 Kenichi Handa <handa@gnu.org>
3724
3725 * coding.h (define_coding_undecided_arg_index): New enum.
3726 (coding_attr_index): New members
3727 coding_attr_undecided_inhibit_null_byte_detection,
3728 coding_attr_undecided_inhibit_iso_escape_detection,
3729 coding_attr_undecided_prefer_utf_8.
3730 (undecided_spec): New struct.
3731 (struct coding_system): New member `undecided' of the member
3732 `spec'.
3733
3734 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3735 (detect_coding): Likewise.
3736 (detect_coding_system): Likewise.
3737 (Fdefine_coding_system_internal): New coding system properties
3738 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3739 :prefer-utf-8.
3740 (syms_of_coding): Adjust for coding_arg_undecided_max.
3741
ba3de9e6
PE
37422013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3743
3744 * image.c (x_from_xcolors): Remove unused local.
3745
547c9269
YM
37462013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3747
3748 Defer image data transfer between X client and server until actual
3749 display happens.
3750
3751 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3752 and `mask_img'.
3753
3754 * image.c (Destroy_Image): Remove.
3755 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3756 `mask_p', and `colors_p'. All uses changed.
3757 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3758 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3759 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3760 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3761 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3762 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3763 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3764 (image_get_x_image, image_unget_x_image): New functions or macros.
3765 (image_background, image_background_transparent, x_to_xcolors)
3766 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3767 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3768 instead of Destroy_Image.
3769 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3770 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3771 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3772 (imagemagick_load_image, svg_load_image): Use them instead of
3773 x_create_x_image_and_pixmap, and x_put_x_image followed by
3774 x_destroy_x_image, respectively.
3775 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3776 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3777 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3778 background_transparent fields.
3779 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3780 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3781
dae2f5ef
PE
37822013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3785 This mostly consists of undoing recent changes.
3786 * callproc.c (Fcall_process):
3787 * process.c (create_process):
3788 Do not worry about catching SIGCHLD here, undoing previous change.
3789 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3790 * process.c, process.h (catch_child_signal):
3791 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3792 * process.c (catch_child_handler): Don't worry about being called
3793 lazily and do not assume caller has blocked SIGCHLD, undoing
3794 previous change. Move first-time stuff back to
3795 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3796 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3797 set lib_child_handler if it's already initialized, which may
3798 help avoid problems on GNUStep.
3799
fa55d2aa
PE
38002013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3801
3802 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3803 * callproc.c (Fcall_process):
3804 * process.c (create_process):
3805 Make sure SIGCHLD is caught before we fork,
3806 since Emacs startup no arranges to catch SIGCHLD.
3807 * process.c (lib_child_handler): Initialize to null, not to
3808 dummy_handler.
3809 (catch_child_signal): Allow self to be called lazily.
3810 Do nothing if it's already been called.
3811 Assume caller has blocked SIGCHLD (all callers do now).
3812 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3813 just before it's really needed.
3814 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3815 since it hasn't been caught yet.
3816
f3f9606c
LMI
38172013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3818
3819 * image.c (compute_image_size): New function to implement
3820 :max-width and :max-height.
3821 (imagemagick_load_image): Use it.
3822
c7041908
PE
38232013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3824
3825 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3826 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3827 Now extern.
3828 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3829 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3830 the SIGCHLD handler, since the code is not atomic and (due to glib)
3831 signals may be arriving now.
3832 * sysdep.c (init_signals): Do not catch child signals here;
3833 'main' now does that later, at a safer time.
3834
f86852b4
PE
38352013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3836
0dfeed58
PE
3837 Clean up SIGCHLD handling a bit (Bug#14569).
3838 * process.c, process.h (catch_child_signal):
3839 Now always extern, even if !NS_IMPL_GNUSTEP.
3840 * process.c (catch_child_signal): Move glib tickler here from
3841 init_process_emacs, so that it's done earlier in Emacs
3842 initialization. Also move the noninteractive && !initialized
3843 check here from init_process_emacs. This is all a bit cleaner for
3844 GNUish platforms, and I hope it works around the Cygwin bug.
3845 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3846 that glib signal handling is tickled before glib creates threads.
3847
f86852b4
PE
3848 * process.c (wait_reading_process_output): Avoid int overflow
3849 when reading more than 2 GiB total from a process.
3850
cbd6509c
PE
38512013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 * process.c (create_process): Handle a couple more cases,
3854 i.e., work even if new_argv and wait_child_setup[i] are cached.
3855 Use Fcall_process's style for volatile vars.
3856
9de1114a
AS
38572013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3858
3859 * process.c (create_process): Mark PROCESS volatile.
3860
fbe9e0b9
PE
38612013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3862
3863 Use C99-style flexible array members if available.
3864 This avoids some subtle aliasing issues, which typically
3865 aren't a problem with GCC but may be a problem elsewhere.
3866 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3867 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3868 In either case, it uses a flexible array member rather than
3869 the old struct hack. All uses changed.
3870 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3871 Adjust to sdata reorganization.
3872 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3873 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3874 that ports better to pre-C99 non-GCC.
3875 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3876 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3877 as the latter has changed.
3878 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3879 and port better to pre-C99 GCC.
3880 * image.c (struct xpm_cached_color):
3881 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3882 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3883 Use FLEXIBLE_ARRAY_MEMBER.
3884 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3885 Move decl to top level so it gets checked against implementation.
3886 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3887 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3888
1fc71008
PE
38892013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 * syntax.c: Integer cleanups.
3892 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3893 All uses that need 0-or-2 changed to:
3894 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3895 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3896 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3897 (char_quoted, prev_char_comend_first, back_comment)
3898 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3899 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3900 Use bool for boolean.
3901 (update_syntax_table, skip_chars, skip_syntaxes):
3902 Prefer int to unsigned when either will do.
3903 (back_comment): Return boolean success flag, like forw_comment,
3904 instead of positive-or-minus-1 (which might have overflowed int anyway).
3905 Don't stuff ptrdiff_t into int.
3906 (syntax_spec_code, syntax_code_spec): Now const.
3907 (Fmatching_paren, scan_lists, scan_sexps_forward):
3908 Use enum syntaxcode for syntax code.
3909 (Fmatching_paren): Check that arg is a character, not just an integer.
3910 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3911 (Finternal_describe_syntax_value): Omit no-longer-needed
3912 comparison to 0.
3913 (skip_chars): Use char, not unsigned char, when the distinction
3914 doesn't matter.
3915 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3916 * bytecode.c (exec_byte_code):
3917 * syntax.c (syntax_spec_code, Fchar_syntax)
3918 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3919 (init_syntax_once):
3920 * syntax.h (SYNTAX_WITH_FLAGS):
3921 Omit unnecessary casts.
3922
b932cad7
EZ
39232013-06-20 Eli Zaretskii <eliz@gnu.org>
3924
3925 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3926 line dimensions here, to avoid race conditions with the main
3927 thread. (Bug#14062, bug#14630, bug#14669)
3928
3929 * w32term.c (w32_draw_window_cursor): Compute the header line and
3930 mode line dimensions here.
3931 <w32_system_caret_window, w32_system_caret_hdr_height>:
3932 <w32_system_caret_mode_height>: New variables.
3933
3934 * w32term.h: Declare them.
3935
89561f72
PE
39362013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3937
5013fc08
PE
3938 * alloc.c (die): Move "assertion failed" string here ...
3939 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3940 COND when SUPPRESS_CHECKING. This shrinks the executable text
3941 size by 0.8% to 2.2% when configured with --enable-checking,
3942 depending on optimization flags (GCC 4.8.1 x86-64).
3943
89561f72
PE
3944 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3945
763a086d 39462013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3947
3948 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3949 base is 2; this is more accurate.
3950
983aeb9a
JB
39512013-06-19 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * sound.c (string_default): Move to !WINDOWSNT section.
3954 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3955
178ba3e6
PE
39562013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3957
bbc51b15
PE
3958 * sound.c: Integer cleanups.
3959 Remove unnecessary forward decls.
3960 (struct sound_device): The 'file' member is now a Lisp_Object, not
3961 a char *, so that we needn't invoke alloca on a huge size.
3962 (Fplay_sound_internal): Adjust to this.
3963 (string_default): New function.
3964 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3965 Use it to adjust to the struct sound_device change.
3966 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3967 (be2hs) [0]: Remove.
3968
178ba3e6
PE
3969 * syntax.c (skip_chars): Don't use uninitialized storage
3970 when searching a multibyte buffer for characters that are not in a
3971 unibyte string that contains non-ASCII characters.
3972
69f60cdc
JD
39732013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3974
3975 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3976 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3977
0d6224d4
PE
39782013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3981
3c542890
KH
39822013-06-18 Kenichi Handa <handa@gnu.org>
3983
f7e3f7cd
KH
3984 * font.c (Ffont_spec): Signal an error for an invalid font name
3985 (Bug#14648).
3c542890 3986
9349e5f7
PE
39872013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3990 In particular this ports to 32-bit sparc Sun cc.
3991 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3992 array with a dummy element at specpdl[-1], so that its address can
3993 be taken portably.
3994 (unbind_to): Do not copy the binding; not needed, now that we
3995 copy old_value in the one place where the copy is needed.
3996 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3997 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3998 (union specbinding): Rename from struct specbinding. Redo layout
3999 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4000 which is not portable. With Sun C 5.12 32-bit sparc, the
4001 declaration causes nargs to be an unsigned bitfield, a behavior
4002 that the C standard allows; but Emacs wants nargs to be signed.
4003 The overall type is now a union of structures rather than a
4004 structure of union of structures, and the 'kind' member is now a
4005 bitfield, so that the overall type doesn't grow. All uses changed.
4006 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4007
0a4df6a5
PE
40082013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4009
ec6ecaad
PE
4010 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4011 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4012
0a4df6a5
PE
4013 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4014
7bfe8dbc
EZ
40152013-06-17 Eli Zaretskii <eliz@gnu.org>
4016
4017 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4018 unless we know that the window w's frame is a frame object.
4019 Another attempt at solving bug#14062 and bug#14630.
4020
708e05f6
LMI
40212013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4022
4023 * textprop.c (property_set_type): New enum.
4024 (add_properties): Allow appending/prepending text properties.
4025 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4026 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4027 add_text_properties_1.
4028 (Fadd_face_text_property): New function that calls
4029 add_text_properties_1.
4030
84575e67
PE
40312013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4032
4033 Move functions from lisp.h to individual modules when possible.
4034 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4035 * alloc.c (XFLOAT_INIT, set_symbol_name):
4036 * buffer.c (CHECK_OVERLAY):
4037 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4038 (set_char_table_parent):
4039 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4040 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4041 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4042 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4043 (set_blv_valcell):
4044 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4045 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4046 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4047 (backtrace_args, backtrace_debug_on_exit):
4048 * floatfns.c (CHECK_FLOAT):
4049 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4050 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4051 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4052 (set_hash_index_slot):
4053 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4054 * marker.c (CHECK_MARKER):
4055 * textprop.c (CHECK_STRING_OR_BUFFER):
4056 * window.c (CHECK_WINDOW_CONFIGURATION):
4057 Move here from lisp.h, and make these functions static rather than
4058 extern inline.
4059 * buffer.c (Qoverlayp):
4060 * data.c (Qsubrp):
4061 * fns.c (Qhash_table_p):
4062 * window.c (Qwindow_configuration_p):
4063 Now static.
4064 * lisp.h: Remove the abovementioned defns and decls.
4065
44e18199 4066 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4067 In lisp.h, prefer functions to function-like macros, and
4068 constants to object-like macros, when either will do. This:
4069 . simplifies use, as there's no more need to worry about
4070 arguments' side effects being evaluated multiple times.
4071 . makes the code easier to debug on some platforms.
4072 However, when using gcc -O0, keep using function-like macros
4073 for a few critical operations, for performance reasons.
4074 This sort of thing isn't needed with gcc -Og, but -Og
4075 is a GCC 4.8 feature and isn't widely-enough available yet.
4076 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4077 Remove enum lsb_bits; no longer needed.
4078 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4079 * buffer.c (Qoverlap):
4080 * data.c (Qsubrp):
4081 * fns.c (Qhash_table_p):
4082 Now extern, so lisp.h can use these symbols.
4083 * dispextern.h: Include character.h, for MAX_CHAR etc.
4084 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4085 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4086 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4087 (GLYPH_CODE_P): Move here from lisp.h.
4088 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4089 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4090 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4091 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4092 XUNTAG now returns void *.
4093 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4094 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4095 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4096 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4097 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4098 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4099 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4100 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4101 New macros, renamed from their sans-lisp_h_ counterparts.
4102 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4103 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4104 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4105 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4106 If compiling via GCC without optimization, define these as macros
4107 in addition to inline functions.
4108 To disable this, compile with -DINLINING=0.
4109 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4110 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4111 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4112 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4113 (INTMASK, VALMASK): Now macros, since static values cannot be
4114 accessed from extern inline functions.
4115 (VALMASK): Also a constant, for benefit of old GDB.
4116 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4117 is INTEGERP, which can fold it in.
5165d44a 4118 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4119 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4120 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4121 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4122 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4123 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4124 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4125 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4126 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4127 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4128 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4129 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4130 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4131 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4132 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4133 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4134 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4135 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4136 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4137 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4138 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4139 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4140 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4141 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4142 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4143 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4144 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4145 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4146 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4147 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4148 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4149 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4150 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4151 Now functions.
4152 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4153 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4154 (VALMASK): Define in one place rather than in two, merging the
4155 USE_LSB_TAG parts; this is simpler.
4156 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4157 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4158 Move up, to avoid use before definition.
4159 Also include "globals.h" earlier, for the same reason.
4160 (make_natnum): New function.
4161 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4162 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4163 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4164 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4165 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4166 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4167 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4168 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4169 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4170 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4171 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4172 (Qwindow_configuration_p, Qimage): New forward declarations.
4173 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4174 (STRING_COPYIN): Remove; unused.
4175 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4176 (xcar_addr, xcdr_addr): New functions. All uses changed.
4177 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4178 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4179 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4180 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4181 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4182 (TYPE_RANGED_INTEGERP): Simplify.
4183 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4184 (setlocale, fixup_locale, synchronize_system_messages_locale)
4185 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4186 Now empty functions, not macros.
4187 (functionp): Return bool, not int.
4188 * window.c (Qwindow_configuration_p): Now extern,
4189 so window.h can use it.
4190 * window.h (Qwindowp): Move decl back to lisp.h.
4191
9583ec36
EZ
41922013-06-15 Eli Zaretskii <eliz@gnu.org>
4193
4194 * xdisp.c (Fline_pixel_height): New function, required for solving
4195 bug #14567.
4196
210272ce
PE
41972013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4200
de0503df
SM
42012013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4202
4203 * lread.c (syms_of_lread):
4204 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4205
afbfe143
KD
42062013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4207
4208 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4209
d177e213
XF
42102013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4211
4212 * fileio.c (expand_file_name): Doc fix.
4213
05e3e412
PE
42142013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4215
f7394b12
PE
4216 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4217 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4218 Wait for self, not for 0. This can't hurt on GNU or similar
4219 system, and may help with Cygwin.
4220
05e3e412
PE
4221 * keyboard.c: Don't use PROP (...) as an lvalue.
4222 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4223 Use set_prop (A, B), not PROP (A) = B.
4224
17dd3097
EZ
42252013-06-10 Eli Zaretskii <eliz@gnu.org>
4226
4227 * xdisp.c (get_it_property): Use it->window instead of generating
4228 a Lisp object from it->w.
4229
52fab9c9
EZ
42302013-06-09 Eli Zaretskii <eliz@gnu.org>
4231
4232 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4233 get-char-property the window that is being rendered, instead of
4234 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4235 (compute_display_string_pos): When W is NULL, use the current
4236 buffer as the object to pass to get-char-property.
4237 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4238 pointer member of the bidi iterator, since no window is pertinent
4239 to this function.
52fab9c9 4240
5bf97bfc
EZ
42412013-06-08 Eli Zaretskii <eliz@gnu.org>
4242
4243 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4244 being displayed, and pass it to compute_display_string_pos.
4245 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4246 (bidi_paragraph_init): All callers changed.
4247
4248 * xdisp.c (init_from_display_pos, init_iterator)
4249 (handle_single_display_spec, next_overlay_string)
4250 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4251 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4252 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4253 (compute_display_string_pos): Accept additional argument, the
4254 window being displayed, and pass it to Fget_char_property.
4255 (Bug#14575)
4256
4257 * dispextern.h (struct bidi_it): New member w, the window being
4258 displayed.
4259 (compute_display_string_pos): Adjust prototype.
4260
5de0e011
JD
42612013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4262
e7b41c4c 4263 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4264
4265 * process.c (wait_reading_process_output): Check for NS before GLIB.
4266 GLIB may be linked in due to rsvg, but ns_select must be called.
4267
5de0e011
JD
4268 * xgselect.c (xg_select): Remove call to window_system_available
4269 and g_main_context_pending at the top, so Gdk events (i.e. file
4270 notify) are processed when Emacs is started with -nw.
4271
a822acff
EZ
42722013-06-07 Eli Zaretskii <eliz@gnu.org>
4273
4274 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4275 (ctagsfiles3): New variable, includes only *.m files.
4276 (TAGS): Use an explicit language name in the regular expressions,
4277 to avoid transformation of '/SOMETHING' by MSYS to
4278 'c:\MSYS\SOMETHING'.
4279
6c0a9ed1
RC
42802013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4281
4282 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4283
9ef6111b
EZ
42842013-06-06 Eli Zaretskii <eliz@gnu.org>
4285
4286 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4287 still need to set the mouse pointer shape and activate help-echo.
4288 (Bug#14558)
4289
7d300d64
PE
42902013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 A few porting etc. fixes for the new file monitor code.
4293 See the thread containing
4294 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4295 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4296 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4297 (dir_monitor_callback, Fgfile_rm_watch):
4298 Use assq_no_quit instead of Fassoc, for speed.
4299 (dir_monitor_callback, Fgfile_rm_watch):
4300 eassert that the monitor is a fixnum.
4301 (dir_monitor_callback): No need for CDR_SAFE.
4302 Simplify building of lisp with alternative tails.
4303 (Fgfile_add_watch, Fgfile_rm_watch):
4304 Do not assume glib functions set errno reliably on failure.
4305 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4306 and signal an error otherwise.
4307 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4308 Use Fdelq instead of Fdelete, for speed.
4309
817ebfcf
EZ
43102013-06-05 Eli Zaretskii <eliz@gnu.org>
4311
4312 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4313 don't insist on being invoked on a highlighted tool-bar button.
4314 Avoids losing tool-bar functionality when mouse-highlight is nil.
4315 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4316 Don't highlight when mouse-highlight is nil.
4317 (note_mouse_highlight): When mouse-highlight is nil, don't return
4318 right away; instead, run tool-bar and mode-line highlight
4319 subroutine, clear any existing highlight, and revert the mouse
4320 pointer to its default shape. (Bug#14558)
4321
55577e7c
SM
43222013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4323
4324 * lisp.mk (lisp): Add prog-mode.el.
4325
f019a684
PE
43262013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4329 * process.c (dummy_handler): New function.
4330 (lib_child_handler): New static var.
4331 (handle_child_signal): Invoke it.
4332 (catch_child_signal): If a library has set up a signal handler,
4333 save it into lib_child_handler.
4334 (init_process_emacs): If using glib and not on Windows, tickle glib's
4335 child-handling code so that it initializes its private SIGCHLD handler.
4336 * syssignal.h (SA_SIGINFO): Default to 0.
4337 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4338 31; it should no longer be needed now.
4339
90db8702
MA
43402013-06-05 Michael Albinus <michael.albinus@gmx.de>
4341
4342 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4343
4344 * gfilenotify.c (globals_of_gfilenotify): New function.
4345 (syms_of_gfilenotify): Move global initialization there.
4346
4347 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4348
bfa3acd6
SM
43492013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4350
4351 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4352 * keyboard.c (menu_bar_items, tool_bar_items):
4353 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4354 not override local keymaps any more.
4355
ba59bd80
EZ
43562013-06-04 Eli Zaretskii <eliz@gnu.org>
4357
4358 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4359
7f203aa1
EZ
43602013-06-03 Eli Zaretskii <eliz@gnu.org>
4361
9337e206
EZ
4362 * w32console.c (initialize_w32_display): Return the dimensions of
4363 the console window via 2 additional arguments, not via the current
4364 frame. This avoids crashes due to overrunning the bounds of
4365 frame's decode_mode_spec_buffer, which is not resized following
4366 the change of the frame dimensions from the initial 10x10.
4367
4368 * w32term.h (w32_initialize_display_info): Adjust prototype.
4369
4370 * term.c (init_tty): Take dimensions of the frame from the values
4371 returned by initialize_w32_display.
4372
7f203aa1
EZ
4373 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4374 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4375 (LIBES): Add $(GFILENOTIFY_LIBS).
4376
4377 * w32inevt.c (handle_file_notifications): Add dummy implementation
4378 for !HAVE_W32NOTIFY.
4379
4380 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4381
55a87246
JD
43822013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4383
4384 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4385
4386 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4387
4388 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4389
3d5ee10a
PE
43902013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4391
4392 Fix minor problems found by static checking.
4393 * data.c (pure_write_error):
4394 Use xsignal2, not Fsignal, as Fsignal might return.
4395 * eval.c (set_backtrace_debug_on_exit): Now static.
4396 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4397 No longer inline. EXTERN_INLINE is needed only for functions
4398 defined in .h files. Reindent function header as per GNU style.
4399 (backtrace_p, backtrace_top, backtrace_next):
4400 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4401 compiler or linker. Add extern decls to pacify gcc -Wall.
4402 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4403 Now static.
4404 * frame.c (free_monitors): Define only on platforms that need it.
4405 * nsterm.m (ns_term_init):
4406 * process.c (catch_child_signal):
4407 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4408 defined on all porting targets these days.
4409 * process.c, process.h (catch_child_signal):
4410 Make it extern only if NS_IMPL_GNUSTEP is defined.
4411
e2d8a6f0
EZ
44122013-06-03 Eli Zaretskii <eliz@gnu.org>
4413
4414 * w32.c (gettimeofday): Make the signature identical to prototype
4415 in nt/inc/sys/time.h.
4416
a8a7c5f6
SM
44172013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4418
4419 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4420 .gdbinit.
4421
4422 * keyboard.c (safe_run_hooks_error): Improve error message.
4423
4424 * data.c (pure_write_error): Add `object' argument.
4425 * puresize.h (CHECK_IMPURE): Use it.
4426
c9628c79
MA
44272013-06-03 Michael Albinus <michael.albinus@gmx.de>
4428
4429 * Makefile.in (NOTIFY_OBJ): New variable.
4430 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4431
4432 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4433 Call syms_of_gfilenotify.
4434
4435 * gfilenotify.c: New file.
4436
4437 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4438 and Qfile_w32notify.
4439 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4440 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4441
4442 * lisp.h: Declare syms_of_gfilenotify.
4443
4444 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4445
2f592f95
SM
44462013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4447
4448 Merge the specpdl and backtrace stacks. Make the structure of the
4449 specpdl entries more obvious via a tagged union of structs.
4450 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4451 (enum specbind_tag): New enum.
4452 (struct specbinding): Make it a tagged union of structs.
4453 Add a case for backtrace records.
4454 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4455 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4456 (backtrace_debug_on_exit): New accessors.
4457 (struct backtrace): Remove.
4458 (struct catchtag): Remove backlist field.
4459 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4460 Move to eval.c.
4461 (Flocal_variable_p): Speed up the common case where the binding is
4462 already loaded.
4463 * eval.c (backtrace_list): Remove.
4464 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4465 (set_backtrace_args, set_backtrace_nargs)
4466 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4467 (backtrace_next): New functions.
4468 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4469 (unwind_to_catch, internal_lisp_condition_case)
4470 (internal_condition_case, internal_condition_case_1)
4471 (internal_condition_case_2, internal_condition_case_n): Don't bother
4472 with backtrace_list any more.
4473 (Fsignal): Adjust to new backtrace format.
4474 (grow_specpdl): Move up.
4475 (record_in_backtrace): New function.
4476 (eval_sub, Ffuncall): Use it.
4477 (apply_lambda): Adjust to new backtrace format.
4478 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4479 data.c.
4480 (specbind): Adjust to new specpdl format. Simplify.
4481 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4482 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4483 backtrace format.
4484 (mark_backtrace): Remove.
4485 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4486 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4487 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4488 Use mark_specpdl.
4489 * profiler.c (record_backtrace): Use get_backtrace.
4490 (handle_profiler_signal): Use backtrace_top_function.
4491 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4492 accessor functions.
4493
c0342369
JD
44942013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4495
4496 * process.h (catch_child_signal): Declare.
4497
4498 * process.c (catch_child_signal): New function.
4499 (init_process_emacs): Call it.
4500
4501 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4502 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4503 NS_IMPL_COCOA.
4504 (x_set_cursor_type): Remove declaration.
4505 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4506 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4507 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4508 (ns_get_color): Use F suffix on float.
4509 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4510 (ns_get_rgb_color): Remove.
4511 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4512 (note_mouse_movement): x and y are CGFloat.
4513 (ns_draw_fringe_bitmap): Remove unused rowY.
4514 Change #if to COCOA && >= 10_6.
4515 (ns_draw_window_cursor): Remove unused overspill.
4516 (ns_draw_underwave): width and x are EamcsCGFloat.
4517 (ns_draw_box): thickness is CGFloat.
4518 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4519 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4520 if not in main thread.
4521 (ns_get_pending_menu_title, ns_check_menu_open)
4522 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4523 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4524 (sendFromMainThread:): New method.
4525 (changeFont:): size is CGFloat.
4526 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4527 Disable warning about permanent text.
4528 (characterIndexForPoint:): Adjust return type depending on GNUStep
4529 version.
4530 (mouseDown:): delta is CGFloat.
4531 (updateFrameSize): Remove unised variable f.
4532 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4533 Cast float to EmacsCGFloat.
4534 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4535 also to -1 when restoring.
4536 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4537 inside NS_IMPL_COCOA.
4538 (toggleFullScreen:): Put call to toggleFullScreen inside
4539 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4540 (setPosition:portion:whole:): por is CGFloat.
4541 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4542 (mouseDown:): Use CGFloat.
4543 (mouseDragged:): Remove unised variable edge.
4544 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4545
4546 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4547 of CGFloat differs.
4548 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4549 when NS_IMPL_GNUSTEP.
4550 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4551 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4552 (EmacsToolbar): Add clearAll. Add tag argument to
4553 addDisplayItemWithImage.
4554 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4555
4556 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4557
4558 * nsmenu.m (ns_update_menubar): Make static.
4559 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4560 (fillWithWidgetValue:): Add cast to SEL for setAction.
4561 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4562 (update_frame_tool_bar): Update code for GNUStep.
4563 (clearAll): New method.
4564 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4565 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4566 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4567 call to insertItemWithItemIdentifier.
4568 (validateVisibleItems): Fix indentation.
4569 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4570 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4571 UtilityWindow to aStyle, remove call to setStyleMask.
4572
4573 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4574
4575 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4576 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4577 Use F suffix on floats.
4578 (ns_char_width): Returns CGFloat.
4579 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4580 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4581 DPSxshow.
4582 (ns_glyph_metrics): CGFloat instead of float.
4583
a0eb10b3
JB
4584 * nsfns.m (x_set_foreground_color, x_set_background_color):
4585 Use EmacsCGFloat.
4586 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4587 remove unused variables.
4588 (Fns_read_file_name): Keep track if panel is for save.
4589 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4590 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4591 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4592 Just return the input if GNUStep.
c0342369
JD
4593 (x_screen_planes): Remove.
4594 (Fxw_color_values): Use EmacsCGFloat
4595 (Fns_display_monitor_attributes_list): Only get screen number for
4596 Cocoa.
ef099a94 4597 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4598 EmacsSavePanel.
4599 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4600 ns_directory_from_panel.
4601
da9aff11
PE
46022013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4603
4604 * process.c (handle_child_signal): Also use WCONTINUED.
4605 This is so that list-processes doesn't mistakenly list the process
4606 as stopped, when the process has actually been continued and is
4607 now running.
4608
0e64479a
PE
46092013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4610
fc186a96
PE
4611 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4612 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4613 not already configured.
4614
0e64479a
PE
4615 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4616
38b787fa
EZ
46172013-05-29 Eli Zaretskii <eliz@gnu.org>
4618
4619 * Makefile.in (mostlyclean): Remove *.res files.
4620
22513e52
SM
46212013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4622
4623 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4624 a buffer (bug#8447).
4625
6ef3db10
EZ
46262013-05-27 Eli Zaretskii <eliz@gnu.org>
4627
4628 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4629 display vector, and we backtrack, handle the case that the
4630 previous character position is also displayed from a display
4631 vector or covered by a display string or image. (Bug#14476)
4632
6799bb26
JD
46332013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4634
4635 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4636 (struct MonitorInfo, free_monitors): Remove.
4637 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4638 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4639 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4640 Qframes, Qsource.
4641
4642 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4643 (struct MonitorInfo, free_monitors): Remove.
4644 (ns_screen_name): Make static.
4645 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4646 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4647 Qframes, Qsource.
4648
4649 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4650 (struct MonitorInfo): New struct.
4651 (free_monitors, make_monitor_attribute_list): Declare.
4652
22513e52
SM
4653 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4654 New Lisp_Object:s.
6799bb26
JD
4655 (free_monitors, make_monitor_attribute_list): New functions.
4656 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4657 Qsource.
4658
38cd43eb
XF
46592013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4660
4661 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4662
2af0948d
SM
46632013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4664
a7eb9b0f
SM
4665 * keyboard.c: Apply keyboard decoding only to events that come directly
4666 from the tty, not from unread-command-events (bug#14368).
4667 (read_event_from_main_queue): New function, extracted from read_char).
4668 (read_decoded_char): Remove.
4669 (read_decoded_event_from_main_queue): New function to replace it.
4670 (read_char): Use it.
4671 (read_key_sequence): Use read_char rather than read_decoded_char.
4672
2af0948d
SM
4673 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4674
1413e9a5
BR
46752013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4676
4677 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4678
e6d2f155
KH
46792013-05-22 Kenichi Handa <handa@gnu.org>
4680
4681 The following changes are to fix the setting of
4682 buffer-file-coding-system on, for instance, C-x RET c unix RET
4683 _FILE_OF_DOS_EOL_TYPE_ RET.
4684
4685 * coding.h (struct coding_system): New member detected_utf8_chars.
4686
4687 * coding.c (detect_coding_utf_8): Count characters and check EOL
4688 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4689 BOM is there.
4690 (setup_coding_system): Do not initialize coding->head_ascii.
4691 (check_ascii): Do not set coding->eol_seen but update it. Do not
4692 call adjust_coding_eol_type here.
1413e9a5
BR
4693 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4694 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4695 of the found coding-system.
4696 (decode_coding_gap): Cancel previous change. Utilize the
4697 character numbers counted by detect_coding_utf_8. Fix detection
4698 of BOM for utf-8.
4699
ab56a6f4 47002013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4701
4702 * search.c (looking_at_1): Only set last_thing_searched if the match
4703 changed the match-data (bug#14281).
4704
ecc3c6ed
DA
47052013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4706
4707 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4708 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4709 (move_it_vertically_backward): Likewise.
4710
5ba8bf35
YM
47112013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4712
4713 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4714 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4715 (Fx_display_mm_width, Fx_display_mm_height):
4716 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4717
91e8418b 4718 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4719 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4720 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4721 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4722 (Fx_display_backing_store, Fx_display_visual_class)
4723 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4724 (Fx_display_grayscale_p, Fx_display_pixel_width)
4725 (Fx_display_pixel_height, Fx_display_planes)
4726 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4727 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4728 (Fx_display_mm_width, Fx_display_mm_height)
4729 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4730 height for all physical monitors as in X11.
4731
fc30d803
SM
4732 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4733 Return pixel width or height for all physical monitors as in X11.
91e8418b 4734
31ff141c
PE
47352013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4736
4737 Port --enable-gcc-warnings to clang.
4738 * bytecode.c (exec_byte_code):
4739 * regex.c:
4740 Redo diagnostic pragmas to pacify clang, too.
4741 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4742 * editfns.c (Fencode_time):
4743 * fileio.c (file_accessible_directory_p):
4744 * font.c (font_unparse_xlfd):
4745 Use '&"string"[index]' instead of '"string" + (index)'.
4746 * undo.c (user_error): Remove; unused.
4747
df065a0b
EZ
47482013-05-16 Eli Zaretskii <eliz@gnu.org>
4749
04d360e7
EZ
4750 * insdel.c (insert_1_both): Document the arguments, instead of
4751 referring to insert_1, which no longer exists.
4752
5bb98290
EZ
4753 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4754 some window, increment windows_or_buffers_changed, so that
4755 *Messages* display in that window is updated. (Bug#14408)
4756
df065a0b
EZ
4757 * w32.c: Include epaths.h.
4758 (init_environment): Use cmdproxy.exe without leading directories.
4759 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4760 case.
4761 (gettimeofday): Adjust signature and return value to Posix
4762 expectations.
4763
4764 * unexw32.c (open_output_file): Delete the existing emacs.exe
4765 before creating it, to break the hard link to the versioned
4766 executable.
4767
4768 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4769 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4770 (FIRSTFILE_OBJ): New variables.
4771 (W32_RES): Rename to EMACSRES. All users changed.
4772 (base_obj): Use $(CM_OBJ).
4773 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4774 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4775 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4776 $(W32_RES_LINK) before $(LIBES).
4777 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4778
1aa8d505
SM
47792013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4780
6e911150
SM
4781 * makefile.w32-in (DOC): Use just "DOC".
4782
4783 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4784
1aa8d505
SM
4785 * process.c: Export default filters and sentinels to Elisp.
4786 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4787 New constants.
4788 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4789 (Fset_process_sentinel, Fformat_network_address):
4790 Default to them instead of nil.
4791 (server_accept_connection): Sentinels can't be nil any more.
4792 (read_and_dispose_of_process_output): New function, extracted from
4793 read_process_output.
4794 (read_process_output): Use it; filters can't be nil.
4795 (Finternal_default_process_filter): New function, extracted from
4796 read_process_output.
4797 (exec_sentinel_unwind): Remove function.
4798 (exec_sentinel): Don't zilch sentinel while running.
4799 (status_notify): Sentinels can't be nil.
4800 (Finternal_default_process_sentinel): New function extracted from
4801 status_notify.
4802 (setup_process_coding_systems): Default filter is not nil any more.
4803 (syms_of_process): Export new Elisp functions and initialize
4804 new constants.
4805 * lisp.h (make_lisp_proc): New function.
4806
5ac2eb34
SM
48072013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4808
4809 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4810
eda9c7d7
EZ
48112013-05-14 Eli Zaretskii <eliz@gnu.org>
4812
4813 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4814 unless we know that the window w is a leaf window.
4815 Another attempt at solving bug#14062.
eda9c7d7 4816
8fdeaad5
JD
48172013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4818
4819 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4820 fdesc (Bug#14375).
4821
44aa9ee6
PE
48222013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4823
4824 * image.c (gif_load): Check that subimages fit (Bug#14345).
4825
759fd763
SM
48262013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4827
4828 * lread.c (skip_dyn_eof): New function.
4829 (read1): Use it to skip the end of a file in response to #@00.
4830
4831 * doc.c (get_doc_string): Slightly relax the sanity checking.
4832
4465bfb4
JD
48332013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4834
4835 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4836 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4837 (MonitorInfo): New struct.
4838 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4839 (Fns_display_monitor_attributes_list): New functions.
4840 (display-usable-bounds): Remove.
4841 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4842 Qsource.
4843
7583e2a0
PE
48442013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4845
4846 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4847 (GTK_CHECK_VERSION): New macro, if not already defined.
4848 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4849 replaced by GTK_CHECK_VERSION.
4850
ad75d77e
PE
48512013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4852
4853 * xterm.h (GTK_PREREQ): New macro.
4854 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4855 to use this macro instead, for consistency and clarity.
4856
07525f77
EZ
48572013-05-08 Eli Zaretskii <eliz@gnu.org>
4858
4859 * xdisp.c (row_for_charpos_p): New function, with code of
4860 cursor_row_p, but accepts an additional argument CHARPOS instead
4861 of using a hardcoded PT.
4862 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4863 (row_containing_pos): Call row_for_charpos_p instead of partially
4864 doing the same. Fixes cursor positioning under longlines-mode
4865 when longlines-show-effect includes more than one newline, when
4866 moving the cursor vertically up.
4867
d901fc8d
JB
48682013-05-08 Juanma Barranquero <lekktu@gmail.com>
4869
4870 * makefile.w32-in (ACL_H): New macro.
4871 ($(BLD)/fileio.$(O)): Update dependencies.
4872
f269bc61
PE
48732013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4874
e7b41c4c 4875 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4876 * Makefile.in (LIB_ACL): New macro.
4877 (LIBACL_LIBS): Remove.
4878 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4879 * fileio.c: Include <acl.h>.
4880 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4881 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4882 !acl_errno_valid.
4883 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4884 it ourselves.
4885
f269bc61
PE
4886 * unexelf.c: Don't assume ElfW (Half) fits in int.
4887 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4888 when dealing with ElfW (Half) values, since they can exceed 2**31
4889 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4890 (entry_address): Omit unused NUM arg. All uses changed.
4891
a261c53e
JL
48922013-05-07 Juri Linkov <juri@jurta.org>
4893
4894 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4895 to the string converted from number with `Fnumber_to_string'.
4896 (Bug#14254)
4897
2b66427d
PE
48982013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4899
4900 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4901 This fixes a problem introduced by my previous change.
4902
15acfe41
GM
49032013-05-07 Glenn Morris <rgm@gnu.org>
4904
4905 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4906
5ea03bf5
JD
49072013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4908
4909 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4910
e0c9d565
PE
49112013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4912
4913 Static checking by GCC 4.8.0.
4914 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4915 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4916 (x_get_monitor_attributes_fallback)
4917 (x_get_monitor_attributes_xinerama)
4918 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4919 Define only if USE_GTK.
4920 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4921 (x_get_monitor_attributes_fallback): Omit unused locals.
4922 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4923 Use double, not float, to avoid mixed-mode floating point arithmetic.
4924
4e3f9230
YM
49252013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4926 Jan Djärv <jan.h.d@swipnet.se>
4927
4928 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4929 (XINERAMA_CFLAGS): New macros.
4930 (ALL_CFLAGS, LIBES): Use them.
4931
4932 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4933 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4934 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4935 (syms_of_xfns): DEFSYM them.
4936 (struct MonitorInfo): New struct.
4937 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4938 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4939 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4940 (x_get_monitor_attributes_xinerama): New functions.
4941 (Fx_display_monitor_attributes_list): New primitive.
4942 (syms_of_xfns): Defsubr it.
4943
4944 * xterm.h (x_display_info): Add Xatom_net_workarea and
4945 Xatom_net_current_desktop.
4946
4947 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4948 and dpyinfo->Xatom_net_current_desktop.
4949
05839b6a
EZ
49502013-05-06 Eli Zaretskii <eliz@gnu.org>
4951
4952 * xdisp.c (pos_visible_p): Use the special code for finding the
4953 beginning of a display property or overlay for any "replacing"
4954 display property, not just for display strings. This solves
4955 incorrect reporting of position by posn-at-point. (Bug#14241)
4956
dc4a2ee0
PE
49572013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4958
5ee94506
PE
4959 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4960 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4961 Verify that ElfW (Half) fits in int.
4962 (fatal): Use same signature as lisp.h.
4963 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4964 configure and build with -DUNEXELF_DEBUG without worrying about
4965 other modules that use DEBUG.
4966 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4967 possibly-wide integers now uses it instead of plain fprintf.
4968 (entry_address): New function, which avoids problems with 32-bit
4969 overflow on 64-bit hosts.
4970 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4971 (round_up): Don't assume the remainder fits in int.
4972 (find_section): Use bool for boolean. Simplify debug code.
4973 (unexec): Don't assume file sizes fit in int or size_t.
4974 Omit unnecessary trailing newline in 'fatal' format.
4975 Use strerror rather than outputting decimal error number.
4976 Remove unused code when emacs is not defined;
4977 this file relies on Emacs now.
4978 Don't assume e_phnum and e_shnum are positive.
4979
dc4a2ee0
PE
4980 * regex.c: Fix problems when DEBUG is defined.
4981 (extract_number, extract_number_and_incr): Define regardless of
4982 whether DEBUG is defined; that's simpler and makes the code less
4983 likely to go stale in the normal case when DEBUG is not defined.
4984 Return int rather than taking an int * arg. All callers changed.
4985 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4986 Remove, replacing with ...
4987 (DEBUG_PRINT): New macro. All callers changed.
4988 (DEBUG_COMPILES_ARGUMENTS): New macro.
4989 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4990 (print_compiled_pattern, print_double_string) [DEBUG]:
4991 Use prototype rather than old-style definition.
4992 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4993 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4994 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4995 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4996 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4997 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4998 This matters only when DEBUG is defined.
4999
14c7ed05
EZ
50002013-05-05 Eli Zaretskii <eliz@gnu.org>
5001
5002 * xdisp.c (set_iterator_to_next): Set the
5003 ignore_overlay_strings_at_pos_p flag only if we are _really_
5004 iterating over an overlay string, as indicated by the
5005 current.overlay_string_index member. (Bug#14306)
5006
e6076b1b
JD
50072013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5008
5009 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5010 to where it is used, to avoid autorelease issues (Bug#14050).
5011
cbee2131
PE
50122013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5013
5014 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5015 * fileio.c (syms_of_fileio): Implement this.
5016 * filelock.c (create_lock_file): If symbolic links don't work, so
5017 we use a regular file as a lock file, do not fsync the lock file;
5018 it's not needed.
5019
30c7e542
SM
50202013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5021
5022 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5023 (syms_of_minibuf): Adjust accodingly.
5024 * lread.c (Fread):
5025 * callint.c (Fcall_interactively): Adjust calls accordingly.
5026
5bebd186
EZ
50272013-05-04 Eli Zaretskii <eliz@gnu.org>
5028
5029 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5030 w->contents is a buffer before computing everything else.
5031 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5032
5033 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5034 assertion violations. (Bug#14062)
5035
0fb0a4f3
DR
50362013-05-01 David Reitter <david.reitter@gmail.com>
5037
5038 * nsfns.m (ns_tooltip): Initialize.
5039
9e63b4a5
EZ
50402013-04-28 Eli Zaretskii <eliz@gnu.org>
5041
5042 * coding.c (decode_coding_gap): Don't remove the character before
5043 a newline unless it's a CR character. (Bug#14287)
5044
ad60824e
DN
50452013-04-28 Dan Nicolaescu <dann@gnu.org>
5046
5047 * dispextern.h (struct face): Move enum face_underline_type
5048 earlier so that bitfields can be in the same word.
5049
edbdcec0
JD
50502013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5051
5052 * nsfns.m (handlePanelKeys): New function.
5053 (EmacsOpenPanel:performKeyEquivalent:)
5054 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5055 arrows/function/control and copy/paste keys (Bug#14296).
5056
0208ede7
JL
50572013-04-27 Juri Linkov <juri@jurta.org>
5058
5059 * callint.c (Fcall_interactively): Call `Qread_number' for
5060 interactive code letter `n' instead of using duplicate code.
5061 (Bug#14254)
5062
b8dd59f7
PE
50632013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5064
5065 * systime.h (make_timeval): Declare as 'const'.
5066
8bd722db
KH
50672013-04-27 Kenichi Handa <handa@gnu.org>
5068
5069 * font.c (font_open_entity): Always open a font of manageable
5070 size.
5071
13d0e56f 50722013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5073
f780d632
PE
5074 Port better to AIX (Bug#14258).
5075 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5076 to pacify AIX xlc.
5077
ec509856
KH
50782013-04-24 Kenichi Handa <handa@gnu.org>
5079
5080 * coding.c (decode_coding_iso_2022): When an invalid escape
5081 sequence is encountered, reset the invocation and designation
5082 status to the safest one.
5083
84fc48e5
PE
50842013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5085
5086 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5087 Without this fix, "make distclean" leaves stamp-h1 behind.
5088
806bda47
EC
50892013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5090
5091 * w32fns.c (w32_fullscreen_rect): New function to compute the
5092 window rectangle for the given fullscreen mode.
5093 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5094 longer tunes the window size. This keeps the window's edges flush
5095 with the screen and allows the taskbar to hide itself in fullboth.
5096
5097 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5098 window decorations and uses the entire screen.
5099
5100 * w32term.h (w32_fullscreen_rect) Add prototype.
5101 (struct w32_output): Replace normal_width, normal_height,
5102 normal_top, and normal_left members with a single normal_placement
5103 struct.
5104 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5105 Remove macros.
5106 (FRAME_NORMAL_PLACEMENT): New macro.
5107
9cc2810b
JB
51082013-04-16 Juanma Barranquero <lekktu@gmail.com>
5109
5110 * minibuf.c (Ftest_completion): Silence compiler warning.
5111
fd16b54c
EZ
51122013-04-15 Eli Zaretskii <eliz@gnu.org>
5113
5114 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5115 bug#14062.
fd16b54c
EZ
5116
5117 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5118 parentheses.
5119
5120 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5121 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5122 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5123 parentheses where appropriate.
5124
9e3379a0
PE
51252013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5126
5127 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5128
ddd6b685
EZ
51292013-04-14 Eli Zaretskii <eliz@gnu.org>
5130
5131 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5132 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5133 Mention in the doc string that setting these variables takes
5134 effect only after a call to set-window-buffer. (Bug#14200)
5135
29b79ba1
EZ
51362013-04-13 Eli Zaretskii <eliz@gnu.org>
5137
5138 * indent.c (Fvertical_motion): Don't consider display strings on
5139 overlay strings as display strings on the buffer position we
5140 started from. This prevents vertical cursor motion from jumping
5141 more than one line when there's an overlay string with a display
5142 property at end of line.
5143 Reported by Karl Chen <Karl.Chen@quarl.org> in
5144 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5145
562c6ee9
SM
51462013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5147
5148 * window.c (select_window): `record_buffer' even if window is
5149 already selected (bug#14191).
5150
fcc1fe85
EZ
51512013-04-11 Eli Zaretskii <eliz@gnu.org>
5152
5153 * window.c (Fwindow_end): Test more flags, including the buffer's
5154 last_overlay_modified flag, to determine whether the window's
5155 display is really up-to-date. Prevents the function from
5156 returning a stale value. (Bug#14170)
5157 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5158 current matrix.
5159
f009190a
EZ
51602013-04-10 Eli Zaretskii <eliz@gnu.org>
5161
5162 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5163 garbaged only if it is not already the top frame on its TTY.
5164 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5165 there are GUI frames open in the same session. (Bug#13864)
5166
78ce603d
SM
51672013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5168
5169 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5170 of marking the idle timers directly.
5171
a8036e40
SM
51722013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5173
5174 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5175 tables (bug#14054).
5176
7ffe7ef6
SM
51772013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5178
5179 * window.c (select_window): Don't record_buffer while the invariant is
5180 temporarily broken (bug#14161).
5181
5182 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5183
7d9f6883
EZ
51842013-04-07 Eli Zaretskii <eliz@gnu.org>
5185
5186 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5187
5406cfd9
RF
51882013-04-07 Romain Francoise <romain@orebokech.com>
5189
5190 Ignore additional platform-specific ACL errors (Bug#13702).
5191 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5192 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5193
95c0e83b
JD
51942013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5195
5196 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5197 f->output_data.ns.
5198
876da980
PE
51992013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5200
5201 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5202 This bug was introduced by my 2013-02-25 change that simplified
5203 data_start configuration. Without this change, on GNU/Linux
5204 an Emacs configured with --enable-profiling fails immediately
5205 due to a profiler signal.
5206 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5207 with these flags. On platforms where special flags are needed
5208 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5209 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5210 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5211
7452b7bd
DA
52122013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5213
5214 Get rid of some platform-specific functions examining window
5215 system and its capabilities. This is a partial rework of the
5216 2013-04-05 change.
5217 * lisp.h (have_menus_p): Remove prototype. This function is
5218 replaced with platform-independent window_system_available.
5219 (check_window_system): Move to...
5220 * frame.h (decode_window_system_frame, window_system_available):
5221 ...here, add new prototypes.
5222 * frame.c (window_system_available, decode_window_system_frame):
5223 New functions.
5224 (check_window_system): Platform-independent now.
5225 * xterm.h (x_in_use): Remove declaration.
5226 (check_x_frame):
5227 * w32term.h (check_x_frame):
5228 * nsterm.h (check_x_frame): Remove prototypes. This function
5229 is replaced with platform-independent decode_window_system_frame.
5230 * msdos.c (have_menus_p): Remove.
5231 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5232 Remove platform-specific functions. Use check_window_system,
5233 decode_window_system_frame and check_ns_display_info where
5234 appropriate. Minor style and comment tweaks.
5235 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5236 (check_x_frame): Likewise.
5237 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5238 Likewise.
5239 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5240 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5241 * xmenu.c, xselect.c: All related users changed.
5242
251e9147
KH
52432013-04-03 Kenichi Handa <handa@gnu.org>
5244
5245 The following changes is to optimize the code for reading UTF-8
5246 files.
5247
562c6ee9 5248 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5249 changed. Check EOL format. Do not call adjust_coding_eol_type
5250 here.
5251 (check_utf_8): New function.
5252 (adjust_coding_eol_type): Do nothing if already adjusted.
5253 (detect_coding): Compare the return value of check_ascii with
5254 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5255 (decode_coding_gap): Optimize for valid UTF-8.
5256
8bc369d4
KH
52572013-03-21 Kenichi Handa <handa@gnu.org>
5258
5259 * coding.c (syms_of_coding): Cancel previous change.
5260
5261 * insdel.c (insert_from_gap): Fix previous change.
5262
73931ad1
DA
52632013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5264
5265 Consistently use platform-specific function to detect window system.
5266 * lisp.h (check_window_system): New prototype. This function is
5267 going to replace check_x, check_w32 and check_ns.
5268 (have_menus_p): Mention msdos.c in comment.
5269 * fontset.c (check_window_system_func): Remove. Adjust all users.
5270 * fontset.h (check_window_system_func): Remove prototype.
5271 * nsterm.h (check_ns):
5272 * xterm.h (check_x):
5273 * w32term.h (check_w32): Likewise.
5274 * menu.c (Fx_popup_menu): Use check_window_system.
5275 * msdos.c (check_window_system): Define for MS-DOS.
5276 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5277 * w32fns.c (check_window_system): Likewise for MS-Windows.
5278 * xfns.c (check_window_system): Likewise for X.
5279 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5280 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5281
7216e43b
PE
52822013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5283
5284 Prefer < to > in range checks such as 0 <= i && i < N.
5285 This makes it easier to visualize quantities on a number line.
5286 This patch doesn't apply to all such range checks,
5287 only to the range checks affected by the 2013-03-24 change.
5288 This patch reverts most of the 2013-03-24 change.
5289 * alloc.c (xpalloc, Fgarbage_collect):
5290 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5291 * character.c (string_escape_byte8):
5292 * charset.c (read_hex):
5293 * data.c (cons_to_unsigned):
5294 * dispnew.c (update_frame_1):
5295 * doc.c (Fsubstitute_command_keys):
5296 * doprnt.c (doprnt):
5297 * editfns.c (hi_time, decode_time_components):
5298 * fileio.c (file_offset):
5299 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5300 * font.c (font_intern_prop):
5301 * frame.c (x_set_alpha):
5302 * gtkutil.c (get_utf8_string):
5303 * indent.c (check_display_width):
5304 * keymap.c (Fkey_description):
5305 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5306 * lread.c (read1):
5307 * minibuf.c (read_minibuf_noninteractive):
5308 * process.c (wait_reading_process_output):
5309 * search.c (Freplace_match):
5310 * window.c (get_phys_cursor_glyph):
5311 * xdisp.c (redisplay_internal):
5312 * xsmfns.c (smc_save_yourself_CB):
5313 Prefer < to > for range checks.
5314 * dispnew.c (sit_for): Don't mishandle NaNs.
5315 This fixes a bug introduced in the 2013-03-24 change.
5316 * editfns.c (decode_time_components): Don't hoist comparison.
5317 This fixes another bug introduced in the 2013-03-24 change.
5318
92759988
DA
53192013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5320
5321 * frame.h (struct frame): Drop scroll_bottom_vpos
5322 member becaue all real users are dead long ago.
5323 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5324 * xdisp.c (redisplay_internal): Adjust user.
5325
9a1971bb
GM
53262013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5327
f38ab167
JD
5328 * nsmenu.m (showAtX:Y:for:): setLevel to
5329 NSPopUpMenuWindowLevel (Bug#13998).
5330
6d01f1fe
JD
53312013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5332
5333 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5334 (ns_check_pending_open_menu): Declare.
5335
5336 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5337 (x_activate_menubar): Update the menu with title that matches
5338 ns_get_pending_menu_title, and call
5339 ns_check_pending_openmenu (Bug#12698).
5340 (menuWillOpen:): New method.
5341 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5342
5343 * nsterm.m (menu_will_open_state, menu_mouse_point)
5344 (menu_pending_title): New varaibles.
5345 (ns_get_pending_menu_title, ns_check_menu_open)
5346 (ns_check_pending_open_menu): New functions.
5347
781f4782
DA
53482013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5349
5350 * indent.c (current_column_bol_cache): Remove leftover which is not
5351 used in Fmove_to_column any more.
5352 (current_column, scan_for_column): Adjust users.
5353 * keyboard.c (last_point_position_buffer, last_point_position_window):
5354 Remove leftovers which are not used for recording undo any more.
5355 (command_loop_1, syms_of_keyboard): Adjust users.
5356 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5357 redisplay_window any more.
5358 (move_it_to): Adjust user.
5359
1921c31b
JB
53602013-03-29 Juanma Barranquero <lekktu@gmail.com>
5361
5362 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5363 Update dependencies.
5364
717b8bcd
SM
53652013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5366
5367 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5368 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5369 forward references.
5370
e74aeda8
DA
53712013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5372
5373 * window.h (struct window): Replace hchild, vchild and buffer slots
5374 with the only contents slot. This is possible because each valid
5375 window may have either the child window (in vertical or horizontal
5376 combination) or buffer to display (for the leaf window). Using that,
5377 a lof of operations to traverse and/or change window hierarchies may
5378 be simplified. New member horizontal is used to distinguish between
5379 horizontal and vertical combinations of internal windows.
5380 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5381 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5382 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5383 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5384 Use contents slot, not buffer, where appropriate.
5385 (wset_combination): New function.
5386 (wset_buffer): Add eassert.
5387 (Fframe_first_window): Simplify the loop reaching first window.
5388 (Fwindow_buffer): Use WINDOW_LEAF_P.
5389 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5390 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5391 (unshow_buffer): Convert initial debugging check to eassert.
5392 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5393 (make_parent_window, window_resize_check, window_resize_apply)
5394 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5395 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5396 Adjust to match struct window changes.
5397 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5398 (mark_window_cursors_off, count_windows, get_leaf_windows)
5399 (foreach_window_1): Simplify the loop.
5400 * alloc.c (mark_object): Do not check for the leaf window because
5401 internal windows has no glyph matrices anyway.
5402 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5403 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5404 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5405 (build_frame_matrix_from_window_tree, mirror_make_current)
5406 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5407 (update_window_tree, set_window_update_flags): Simplify the loop.
5408 (sync_window_with_frame_matrix_rows): Enforce live window.
5409 Use contents slot, not buffer, where appropriate.
5410 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5411 and WINDOW_HORIZONTAL_COMBINATION_P.
5412 (make_frame_visible_1): Simplify the loop.
5413 Use contents slot, not buffer, where appropriate.
5414 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5415 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5416 (expose_window_tree): Likewise.
5417 Use contents slot, not buffer, where appropriate.
5418 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5419 to avoid deleted windows. Use contents slot instead of buffer.
5420 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5421 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5422 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5423 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5424
121ab1cd
EZ
54252013-03-28 Eli Zaretskii <eliz@gnu.org>
5426
ef454cf7
EZ
5427 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5428 identify the reasons for assertion violations in bug#14062 and
5429 similar ones.
21e930f8
EZ
5430 (Fx_show_tip): Fix compilation error under
5431 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5432
121ab1cd
EZ
5433 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5434 Reported by <rzl24ozi@gmail.com>.
5435
5c89ca24
DA
54362013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5437
5438 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5439 start marker...
562c6ee9
SM
5440 (unwind_with_echo_area_buffer): ...to restore it here.
5441 This is needed to ensure that...
5c89ca24
DA
5442 (redisplay_window): ...both window markers are valid here,
5443 which is verified by eassert.
5444 * editfns.c (save_excursion_save): Do not assume that
5445 selected_window always displays the buffer.
c7f53895
DA
5446 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5447 Fix comment.
5c89ca24 5448
f557c1b1
SM
54492013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5450
5451 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5452 the upcase table.
5453
40693bba 54542013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5455
5456 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5457
c86f791f
EZ
54582013-03-27 Eli Zaretskii <eliz@gnu.org>
5459
5460 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5461 since MinGW's w32api headers do. This avoids compiler warnings.
5462
5463 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5464 if already defined.
5465
c6e72e17
EZ
54662013-03-26 Eli Zaretskii <eliz@gnu.org>
5467
5468 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5469
54e95010
JD
54702013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5471
5472 * gtkutil.c (style_changed_cb): Check if frame is live and an
5473 X frame (Bug#14038).
5474
b88b62de
EZ
54752013-03-26 Eli Zaretskii <eliz@gnu.org>
5476
a18d7de6
EZ
5477 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5478 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5479 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5480 MinGW64.
8f5e14c8
EZ
5481 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5482 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5483
b88b62de
EZ
5484 Fix incompatibilities between MinGW.org and MinGW64 headers.
5485 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5486
5487 * w32.c (REPARSE_DATA_BUFFER): Guard with
5488 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5489
c074e458
JD
54902013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5491
5492 * xterm.c: Include X11/XKBlib.h
5493 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5494
908589fd
AS
54952013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5496
5497 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5498 written backwards.
5499 * blockinput.h (input_blocked_p): Likewise.
5500 * bytecode.c (exec_byte_code): Likewise.
5501 * callproc.c (call_process_kill, call_process_cleanup)
5502 (Fcall_process): Likewise.
5503 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5504 (Fccl_execute_on_string): Likewise.
5505 * character.c (string_escape_byte8): Likewise.
5506 * charset.c (read_hex): Likewise.
5507 * cm.c (calccost): Likewise.
5508 * data.c (cons_to_unsigned): Likewise.
5509 * dired.c (directory_files_internal, file_name_completion):
5510 Likewise.
5511 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5512 (sit_for): Likewise.
5513 * doc.c (Fsubstitute_command_keys): Likewise.
5514 * doprnt.c (doprnt): Likewise.
5515 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5516 * emacsgtkfixed.c: Likewise.
5517 * fileio.c (file_offset, Fwrite_region): Likewise.
5518 * floatfns.c (Fexpt, fmod_float): Likewise.
5519 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5520 Likewise.
5521 * font.c (font_intern_prop): Likewise.
5522 * frame.c (x_set_alpha): Likewise.
5523 * gtkutil.c (get_utf8_string): Likewise.
5524 * indent.c (check_display_width): Likewise.
5525 * intervals.c (create_root_interval, rotate_right, rotate_left)
5526 (split_interval_right, split_interval_left)
5527 (adjust_intervals_for_insertion, delete_node)
5528 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5529 (merge_interval_right, merge_interval_left, copy_intervals)
5530 (set_intervals_multibyte_1): Likewise.
5531 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5532 * keymap.c (Fkey_description): Likewise.
5533 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5534 * lread.c (openp, read_integer, read1, string_to_number):
5535 Likewise.
5536 * menu.c (ensure_menu_items): Likewise.
5537 * minibuf.c (read_minibuf_noninteractive): Likewise.
5538 * print.c (printchar, strout): Likewise.
5539 * process.c (create_process, Faccept_process_output)
5540 (wait_reading_process_output, read_process_output, send_process)
5541 (wait_reading_process_output): Likewise.
5542 * profiler.c (make_log, handle_profiler_signal): Likewise.
5543 * regex.c (re_exec): Likewise.
5544 * regex.h: Likewise.
5545 * search.c (looking_at_1, Freplace_match): Likewise.
5546 * sysdep.c (get_child_status, procfs_ttyname)
5547 (procfs_get_total_memory): Likewise.
5548 * systime.h (EMACS_TIME_VALID_P): Likewise.
5549 * term.c (dissociate_if_controlling_tty): Likewise.
5550 * window.c (get_phys_cursor_glyph): Likewise.
5551 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5552 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5553 Likewise.
5554 * xfns.c (Fx_window_property): Likewise.
5555 * xmenu.c (set_frame_menubar): Likewise.
5556 * xselect.c (x_get_window_property, x_handle_dnd_message):
5557 Likewise.
5558 * xsmfns.c (smc_save_yourself_CB): Likewise.
5559 * xterm.c (x_scroll_bar_set_handle): Likewise.
5560
2bf7d27a
DA
55612013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5562
5563 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5564 to be optional or nil. Adjust comment and convert it to docstring.
5565 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5566 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5567
a9ebfa0b
PE
55682013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5569
5570 Static checking by GCC 4.8-20130319.
5571 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5572 * process.c (Fset_process_datagram_address)
5573 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5574 * xdisp.c (get_char_face_and_encoding):
5575 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5576 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5577 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5578
4f3576ee
KB
55792013-03-24 Ken Brown <kbrown@cornell.edu>
5580
789b5e9a
KB
5581 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5582 fix compilation on 64-bit Cygwin, where underscores are not
5583 automatically prepended.
5584
4f3576ee
KB
5585 * w32term.c (w32_initialize): Silence compiler warning.
5586
b5b7745f
EZ
55872013-03-23 Eli Zaretskii <eliz@gnu.org>
5588
cdc0d0bd
EZ
5589 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5590 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5591 variables, to save and restore frame dimensions.
5592 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5593 after returning from a 'fullscreen' configuration.
5594 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5595 to avoid races between the main thread and the input thread.
5596
5597 * w32term.h (struct w32_output): New members normal_width,
5598 normal_height, normal_top, normal_left, and prev_fsmode.
5599 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5600 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5601 members of a frame.
5602
b5b7745f
EZ
5603 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5604 'fullscreen' parameter. Always record previous width and height
5605 of the frame, except when switching out of maximized modes, so
5606 that they could be restored correctly, instead of resetting to the
5607 default frame dimensions. Send SC_RESTORE command to the frame,
5608 unless we are going to send SC_MAXIMIZE, to restore the frame
5609 resize hints in the mouse pointer shown by the window manager.
5610 (Bug#14032)
5611
5612 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5613
5614 * lisp.h (get_frame_param): Adjust conditions for prototype
5615 declaration.
5616
a3454eed
KB
56172013-03-22 Ken Brown <kbrown@cornell.edu>
5618
5619 * unexcw.c: Drop unneeded inclusion of w32common.h.
5620 (report_sheap_usage): Declare.
5621 (read_exe_header): Add magic numbers for x86_64.
5622 (fixup_executable): Fix printf format specifier for unsigned long
5623 argument.
5624
5a49b79c
DA
56252013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5626
5627 * frame.h (struct frame): Put menu_bar_window under #ifdef
5628 because this member is not needed when X toolkit is in use.
5629 (fset_menu_bar_window):
5630 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5631 (free_glyphs, update_frame):
5632 * xdisp.c (expose_frame): Likewise.
5633 (display_menu_bar): Likewise. Remove redundant eassert.
5634 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5635 toolkit is in use.
5636
d6723bf7
PE
56372013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5638
7b1123d8
PE
5639 Use functions and constants to manipulate Lisp_Save_Value objects.
5640 This replaces code that used macros and strings and token-pasting.
5641 The change makes the C source a bit easier to follow,
5642 and shrinks the Emacs executable a bit.
5643 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5644 (make_save_value): Change 1st arg from string to enum. All callers
5645 changed.
5646 (INTX): Remove.
5647 (mark_object): Use if, not #if, for GC_MARK_STACK.
5648 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5649 (XSAVE_OBJECT): Now functions, not macros.
5650 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5651 the constant was never used.
5652 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5653 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5654 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5655 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5656 New constants.
5657 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5658 type3 with a single member save_type. All uses changed.
5659 (save_type, set_save_pointer, set_save_integer): New functions.
5660 * print.c (PRINTX): Remove.
5661
d6723bf7
PE
5662 * alloc.c: Remove redundant static declarations.
5663
5f24fa51
DA
56642013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5665
5666 * window.h (struct window): Convert left_col, top_line, total_lines
5667 and total_cols from Lisp_Objects to integers. Adjust comments.
5668 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5669 Remove.
5670 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5671 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5672 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5673 Adjust users where appropriate.
5674
42143acd
DA
56752013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5676
5677 * frame.h (struct frame): Drop resx and resy because the same data is
5678 available from window system-specific output context. Adjust users.
562c6ee9
SM
5679 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5680 New functions to provide defaults when no window system available.
42143acd 5681 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5682 (NUMVAL): Move from xdisp.c.
42143acd
DA
5683 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5684 (Ffont_face_attributes, Fopen_font):
5685 * image.c (gs_load):
5686 * w32font.c (fill_in_logfont):
5687 * xdisp.c (calc_pixel_width_or_height):
5688 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5689 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5690
c0a17406
KH
56912013-03-20 Kenichi Handa <handa@gnu.org>
5692
5693 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5694 to 1 (temporary workaround until a bug related to ASCII
5695 optimization is fixed).
5696
095d384d
DA
56972013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5698
5699 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5700 Signal error if window is not internal. Adjust docstring.
5701 (delete_all_child_windows): Use combination_limit to save the buffer.
5702 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5703 * print.c (syms_of_print): Initialize debugging output not here...
5704 (init_print_once): ...but in a new function here.
5705 * lisp.h (init_print_once): Add prototype.
5706 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5707
748fa866
DA
57082013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5709
5710 * window.c (window_resize_check, window_resize_apply)
5711 (window_from_coordinates, recombine_windows, set_window_buffer)
5712 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5713 (Fsplit_window_internal, Fdelete_window_internal)
5714 (freeze_window_starts): Use bool for booleans.
5715 * window.h (window_frame_coordinates, resize_frame_windows)
5716 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5717
81519fd2
SM
57182013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5719
5720 * dispnew.c (bitch_at_user): Use `user-error'.
5721
6db423a9
KB
57222013-03-17 Ken Brown <kbrown@cornell.edu>
5723
5724 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5725 as return type of image_background. (Bug#13981)
5726 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5727
8f2906f5
JD
57282013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5729
960ce480 5730 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5731 (ns_select): Don't return with result uninitialized.
960ce480 5732
8f2906f5
JD
5733 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5734 and getDirectory.
5735
81519fd2
SM
5736 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5737 New functions.
8f2906f5
JD
5738 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5739 directories. If filename is nil, get directory name (Bug#13932).
5740 Use getFilename and getDirectory.
5741 (getFilename, getDirectory): New methods for EmacsSavePanel and
5742 EmacsOpenPanel.
5743 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5744
cded56c1
PE
57452013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5746
5747 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5748
251e9147 57492013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5750
5751 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5752 (adjust_after_replace): Make it back to static. Delete the third
5753 arg text_at_gap_tail. Cancel the code for handling it.
5754
5755 * coding.h (struct coding_system): New member eol_seen.
5756
5757 * coding.c (detect_ascii): New function.
5758 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5759 when the source bytes are actually scanned. On detecting for
5760 coding_category_utf_8_auto, call detect_ascii instead of scanning
5761 source bytes directly.
5762 (produce_chars): Call insert_from_gap with the new arg 0.
5763 (encode_coding): Likewise.
5764 (decode_coding_gap): Control ASCII optimization by the variable
5765 disable_ascii_optimization instead of #ifndef .. #endif.
5766 Deccode EOL format according to coding->eol_seen.
5767 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5768 variable.
5769
8a44e6d1
KH
5770 * lisp.h (adjust_after_replace): Cancel externing it.
5771 (insert_from_gap): Adjust prototype.
5772
5f795e34
EZ
57732013-03-15 Eli Zaretskii <eliz@gnu.org>
5774
5775 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5776 FULLSCREEN_MAXIMIZED. (Bug#13935)
5777
f258b4be
DA
57782013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5779
5780 * region-cache.c (find_cache_boundary, move_cache_gap)
5781 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5782 Simplify debugging check and convert to eassert. Adjust comment.
5783 (pp_cache): Put under ENABLE_CHECKING.
5784
a5cc4dde
EZ
57852013-03-14 Eli Zaretskii <eliz@gnu.org>
5786
5787 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5788 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5789 and WM_ACTIVATEAPP.
5790 (w32fullscreen_hook): If the frame is visible, reset
5791 f->want_fullscreen flag after changing the frame size. If the
5792 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5793 (Bug#13953)
5794
3fc5e44a
DC
57952013-03-13 Daniel Colascione <dancol@dancol.org>
5796
5797 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5798 too so that these builds can use Cygwin's file conversion
5799 functions. (We've been building and linking cygw32.o all along
5800 and just not using it.)
5801
47d7532e
PE
58022013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5803
5804 File synchronization fixes (Bug#13944).
5805 * Makefile.in (LIB_FDATASYNC): New macro.
5806 (LIBES): Use it.
5807 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5808 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5809 Don't worry about HAVE_FSYNC, since a substitute fsync is
5810 available if the system lacks one.
5811 (Fwrite_regin): Retry fsync if interrupted.
5812
c7ffccaf
EZ
58132013-03-13 Eli Zaretskii <eliz@gnu.org>
5814
4e2df81d 5815 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5816 activated, call w32fullscreen_hook, to make sure the new frame
5817 dimensions are in effect. (Bug#13937)
5818
8a7debc1
DA
58192013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5820
5821 * xdisp.c (init_iterator): Simplify because both character and byte
5822 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5823 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5824 character and byte positions can be obtained from marker.
8a7debc1 5825
7fd8c501
PE
58262013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5827
d9df6f40
PE
5828 Static checking by Sun C 5.12.
5829 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5830 * bytecode.c (exec_byte_code):
5831 * dispnew.c (init_display):
5832 * eval.c (error):
5833 * fileio.c (Fsubstitute_in_file_name):
5834 * keyboard.c (Fevent_convert_list):
5835 * keymap.c (Fsingle_key_description):
5836 * term.c (maybe_fatal, fatal):
5837 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5838 * xsmfns.c (Fhandle_save_session):
5839 Omit unreachable code.
5840 * keymap.c (map_keymap_char_table_item): Cast void * to
5841 a function pointer type; the C Standard requires this.
5842
7fd8c501
PE
5843 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5844 Include <sys/param.h> unconditionally, as that works elsewhere and
5845 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5846 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5847 and FreeBSD now.
5848
a020afb9 5849See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5850
5851;; Local Variables:
5852;; coding: utf-8
aac0c6e3
MR
5853;; End:
5854
ab422c4d 5855 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5856
5857 This file is part of GNU Emacs.
5858
5859 GNU Emacs is free software: you can redistribute it and/or modify
5860 it under the terms of the GNU General Public License as published by
5861 the Free Software Foundation, either version 3 of the License, or
5862 (at your option) any later version.
5863
5864 GNU Emacs is distributed in the hope that it will be useful,
5865 but WITHOUT ANY WARRANTY; without even the implied warranty of
5866 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5867 GNU General Public License for more details.
5868
5869 You should have received a copy of the GNU General Public License
5870 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.