* dispextern.h (check_x_display_info, x_get_string_resource):
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a6c2ee1b
DA
12013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * dispextern.h (check_x_display_info, x_get_string_resource):
4 Declare here just once and unify the latter.
5 * frame.c (check_x_display_info, x_get_string_resource):
6 * nsterm.h (check_x_display_info):
7 * xrdb.c (x_get_string_resource):
8 * xterm.h (check_x_display_info): Remove prototypes.
9 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
10 * w32reg.c (x_get_string_resource): Likewise.
11 (w32_get_rdb_resource): Adjust user.
12
baed3603
DA
132013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
14
15 * xterm.h (struct x_display_info): New member
16 x_pending_autoraise_frame, going to replace...
17 * xterm.c (pending_autoraise_frame): ...static variable.
18 (x_new_focus_frame, XTread_socket): Adjust users.
19 * w32term.h (struct w32_display_info): New member
20 w32_pending_autoraise_frame, going to replace...
21 * w32term.c (pending_autoraise_frame): ...global variable.
22 (x_new_focus_frame, w32_read_socket): Adjust users.
23
90582f05
GM
242013-09-17 Glenn Morris <rgm@gnu.org>
25
26 * xdisp.c (message_dolog): If we create *Messages*,
27 switch it to messages-buffer-mode.
28
b7ad2f74
PE
292013-09-17 Paul Eggert <eggert@cs.ucla.edu>
30
31 Don't overuse 'const' in types of locals.
32 * bidi.c (bidi_count_bytes):
33 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
34 (xg_event_is_for_scrollbar):
35 * xselect.c (x_handle_property_notify)
36 (x_handle_selection_notify, x_handle_dnd_message):
37 * xsettings.c, xsettings.h (xft_settings_event):
38 * xterm.c (x_handle_net_wm_state, handle_one_event)
39 (x_menubar_window_to_frame, x_detect_focus_change)
40 (construct_mouse_click, note_mouse_movement)
41 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
42 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
43 (handle_one_xevent, x_handle_net_wm_state):
44 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
45 (x_handle_dnd_message):
46 Avoid unnecessary 'const', typically the second 'const' in
47 'const foo * const arg', a 'const' that does not affect the API
48 and doesn't significantly help the human reader.
49
19452b86
DA
502013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
51
52 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
53 only if Glib < 2.36.0.
54 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
55 * xsettings.c (init_gconf, init_gsettings): Do not check
56 for g_type_init.
1893694e
DA
57 * xterm.c (handle_one_xevent): Do not call to x_clear_area
58 if GTK >= 2.7.0.
33b83dd7 59 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 60
6434e343
JD
612013-09-16 Jan Djärv <jan.h.d@swipnet.se>
62
3f386383
JD
63 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
64 before calling g_type_init.
65
6434e343
JD
66 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
67
68 * nsterm.m (syms_of_nsterm): ... to here.
69
83a119f8
DA
702013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
71
72 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
73 (ignore_next_mouse_click_timeout): Use Time as X does.
74 (handle_one_xevent): Avoid cast and use unsigned comparison.
75
61582e6a
DA
762013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
77
78 Do not copy X event in handle_one_xevent except KeyPress case.
79 Wnen XEvent is processed, it is unlikely to be changed except
80 KeyPress case, so we can avoid copying and use const pointer to
81 const data to make sure that an event is not changed elsewhere.
82 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
83 const' and do not create local copy except for the KeyPress event.
84 Use casts to avoid a few glitches. Adjust formatting. Add comments.
85 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
86 (x_handle_net_wm_state, x_menubar_window_to_frame)
87 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
88 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
89 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
90 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
91 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
92 (x_handle_dnd_message):
93 * xsettings.c (xft_settings_event):
94 Use 'const XEvent * const' where appropriate.
95 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
96
f8eb1572
DA
972013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
98
99 Fix X event waiting to handle multiple frames.
100 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
101 * xterm.c (pending_event_wait): Remove. Adjust users.
102 (x_detect_focus_change): Pass frame arg.
103 (handle_one_xevent): Find related frame early and clear per-frame
104 wait_event_type only if this is an event for the relevant frame.
105 (x_wait_for_event): Use per-frame wait_event_type.
106
3fa2054e
JD
1072013-09-15 Jan Djärv <jan.h.d@swipnet.se>
108
745d3809
JD
109 * nsfns.m (Fx_create_frame): Fix font driver registration for
110 GNUStep.
111
112 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
113 for syms_of_macfont.
114
3fa2054e
JD
115 * nsterm.m: Include macfont.h.
116 (ns_tmp_flags, ns_tmp_font): Remove.
117 (ns_compute_glyph_string_overhangs): Check for driver Qns.
118 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
119 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
120 (changeFont:): Fix code style. Check for font driver type when
121 getiing font.
122
123 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
124 (f)->descent.
125
126 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
127 (nsfont_open): Set font driver type.
128 Set font->ascent and font->descent. Figure out font instead of
129 ns_tmp_font, and flags instead of ns_tmp_flags.
130 Fix indentation. Remove call to ns_draw_text_decoration,
131 moved to nsterm.
132
133 * nsfns.m: Include macfont.h.
134 (Fx_create_frame): Register macfont driver, make a better default font.
135 (Fns_popup_font_panel): Get font from macfont driver, if used.
136
137 * macfont.m, macfont.h, maccuvs.h: New files.
138
139 * font.h: Declare syms_of_macfont.
140
141 * font.c (syms_of_font): Call syms_of_macfont.
142
143 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
144
0eed0355
DA
1452013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
146
147 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
148 and it is always zero for others, so I assume that this is an ancient
149 leftover which nobody will want to change any more.
150 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
151 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
152 * frame.c (x_set_scroll_bar_width):
153 * w32fns.c (w32_createscrollbar):
154 * w32term.c (w32_set_vertical_scroll_bar):
155 * xfns.c (x_set_scroll_bar_default_width):
156 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
157 (x_scroll_bar_expose): Related users changed.
158
07013c68
DA
1592013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
160
161 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
162 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
163 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
164 Define as such.
c7cc32f7
DA
165 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
166 Define once here...
167 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
168 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
169 Remove unused Xisms.
7f09455e
DA
170 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
171 these modules are never compiled otherwise.
07013c68 172
0df00f59
EZ
1732013-09-14 Eli Zaretskii <eliz@gnu.org>
174
08a209bf 175 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
176 Doc fix. (Bug#15375)
177
fcd42c11
DA
1782013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
179
180 Unify Fx_focus_frame between all ports.
181 * frame.h (x_focus_frame): New prototype.
182 * xfns.c (Fx_focus_frame): Remove.
183 (syms_of_xfns): Do not defsubr it.
184 (x_focus_frame): X implementation.
185 * nsfns.m (Fx_focus_frame): Remove.
186 (syms_of_nsfns): Do not defsubr it.
187 (x_focus_frame): NS implementation.
188 * w32term.c (Fx_focus_frame): Remove.
189 (x_focus_on_frame): Rename to...
190 (x_focus_frame): W32 implementation.
191 * w32term.h (x_focus_on_frame): Remove prototype.
192 * w32fns.c (Fx_focus_frame): Remove.
193 (syms_of_w32fns): Do not defsubr it.
194 * frame.c (Fx_focus_frame): Define here.
195 (syms_of_frame): Defsubr here.
196 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
197
aad3612f
DA
1982013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
199
200 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
201 All of them are replaced with FRAME_DISPLAY_INFO, defined in
202 each port to reference the port-specific window system data.
203 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
204 (FRAME_DISPLAY_INFO): Define.
205 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
206 (FRAME_DISPLAY_INFO): Define. Adjust users.
207 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
208 (FRAME_DISPLAY_INFO): Define. Adjust users.
209 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
210 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
211 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
212 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
213 * xselect.c, xterm.c: All related users changed.
214
9a650e62
DA
2152013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
216
217 * xterm.h (x_window_to_frame, x_any_window_to_frame)
218 (x_menubar_window_to_frame): Remove prototypes.
219 * xfns.c (x_window_to_frame, x_any_window_to_frame)
220 (x_menubar_window_to_frame, x_top_window_to_frame):
221 Move from here...
222 * xterm.c (x_window_to_frame, x_any_window_to_frame)
223 (x_menubar_window_to_frame, x_top_window_to_frame):
224 ...to here and convert all but the last to static.
225
347ae3e1
EZ
2262013-09-12 Eli Zaretskii <eliz@gnu.org>
227
228 * lisp.mk (lisp): Add w32-common-fns.elc.
229
15c6d837
XF
2302013-09-12 Xue Fuqiao <xfq.free@gmail.com>
231
232 * charset.c (char_charset): Document an exception for char-charset.
233
27e90f77
DA
2342013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
235
236 * xterm.h (x_display_info): New field last_user_time...
237 * xterm.c (toplevel): ...to replace static last_user_time.
238 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
239
8ffbc36b
DA
2402013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
241
242 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
243 scroll bar values to prevent thumb from disappear and update comment.
244
5ec0337a
GM
2452013-09-11 Glenn Morris <rgm@gnu.org>
246
247 * emacs.c (usage_message): Possessive apostrophe tweak.
248
fb55b9d1
DA
2492013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
250
8d2db8be
DA
251 * nsterm.m (syms_of_nsterm): Use Qns.
252 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
253 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
254 * xfns.c (x_display_info_for_name, Fx_open_connection):
255 Remove old '#if 0' code.
256 (syms_of_xfns): Use Qx.
fb55b9d1
DA
257 * termhooks.h (fullscreen_hook): Remove the leftover.
258 (struct terminal): Fix typo in comment.
259
927eec55
DA
2602013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
261
262 Cleaning up a few X scroll bar bits.
263 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
264 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
265 New member last_seen_part, going to replace...
266 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
267 (xt_action_hook) [USE_LUCID]: Adjust user.
268 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
269 Lucid-specific scroll bar support.
270 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
271 to int and adjust to use last_seen_part member.
272 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
273 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
274 Initialize last_seen_part.
275
71b28baa
SM
2762013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
277
278 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
279 insert-buffer-substring an empty string.
280
f5dacaae
PE
2812013-09-11 Paul Eggert <eggert@cs.ucla.edu>
282
283 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
284 avoiding a GCC warning.
285
742516e0
DA
2862013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
287
288 Ifdef away frame tool bar code when it is not really used.
289 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
290 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
291 and minimize_tool_bar_window_p under the above.
292 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
293 (fset_tool_bar_window): Likewise.
294 * dispnew.c (clear_current_matrices, clear_desired_matrices)
295 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
296 (change_frame_size_1):
297 * window.c (window_from_coordinates, Frecenter): Adjust users.
298 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
299 code is not really used.
300 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
301 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
302 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
303 [!USE_GTK && !HAVE_NS]: Define as such.
304 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
305 (note_mouse_highlight, expose_frame):
306 * xfns.c (x_set_tool_bar_lines):
307 * xterm.c (handle_one_xevent): Adjust users.
308
73f82c7e
PE
3092013-09-11 Paul Eggert <eggert@cs.ucla.edu>
310
311 Fix corruption with multiple emacsclient -t instances (Bug#15222).
312 This bug was introduced by my 2013-08-26 patch, which incorrectly
313 assumed that the terminfo implementation doesn't use termcap buffers.
314 * term.c (init_tty) [TERMINFO]: Remove optimization, as
315 these buffers apparently are used after all.
316 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
317 (struct tty_display_info): Define members termcap_term_buffer and
318 termcap_strings_buffer even if TERMINFO.
319
53482f41
DA
3202013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
321
322 Fix last change.
323 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
324 'usage' docstring entry to pacify make-docfile.
325
3262013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
327
328 Change comparison functions =, <, >, <=, >= to take many arguments.
329 * data.c: Change comparison functions' interface and implementation.
330 * lisp.h: Make arithcompare available for efficient two arg
331 comparisons.
332 * bytecode.c: Use arithcompare.
333 * fileio.c: Use new interface.
334
533f258f
SM
3352013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
336
337 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
338
8c27f5ff
SM
3392013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
340
341 * eval.c (Feval): Document the new use of `lexical'.
342
0750a308
DA
3432013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
344
345 Review and drop old frame resize hack.
346 * frame.h (struct frame): Remove force_flush_display_p.
347 * dispnew.c (update_frame): Adjust user and don't call
348 flush_frame here. The comment has said that there was an issues
349 with redisplaying fringes, but I don't see any differences with
350 and without this hack. Hopefully we can continue without it.
351 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
352 current frame matrices twice if resized_p is set.
353
83fc0554
DA
3542013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
355
356 Do not populate pure Xism x_sync to other ports.
357 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
358 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
359 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
360 * w32term.h (x_sync): Remove prototype.
361
fd462129
DA
3622013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
363
364 Cleanup frame flushing.
8c27f5ff
SM
365 * dispextern.h (struct redisplay_interface):
366 Drop flush_display_optional because flush_display is enough
fd462129
DA
367 for X and flushing via RIF is just a no-op for others.
368 * frame.h (flush_frame): New function.
369 * dispnew.c (update_frame):
370 * minibuf.c (read_minibuf):
371 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
372 Use it.
373 * keyboard.c (detect_input_pending_run_timers): Do not flush
374 all frames but selected one in redisplay_preserve_echo_area.
375 * nsterm.m (ns_flush): Remove no-op.
376 (ns_redisplay_interface): Adjust user.
377 * w32term.h (x_flush): Remove no-op.
378 (w32_redisplay_interface): Adjust user.
379 * xterm.c (x_flush): Simplify because we do not flush all
380 frames at once any more. Adjust comment.
381 (x_redisplay_interface): Adjust user.
382
4b73fc73
PE
3832013-09-07 Paul Eggert <eggert@cs.ucla.edu>
384
385 Port --without-x --enable-gcc-warnings to Fedora 19.
386 * gfilenotify.c (globals_of_gfilenotify):
387 Call g_type_init only if using an older glib version that needs it.
388
77394d40
DA
3892013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
390
391 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
392 (last_glyphless_glyph_merged_face_id): Remove declarations.
393 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
394 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
395 (last_glyphless_glyph_merged_face_id): Now static.
396 (merge_escape_glyph_face): New function, refactored from...
397 (get_next_display_element): ...here.
398 (merge_glyphless_glyph_face): New function, refactored from...
399 (produce_glyphless_glyph): ...here...
400 * term.c (produce_glyphless_glyph): ...and here.
401
306d67bd
SM
4022013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
403
404 * eval.c (eval_sub): Only call Ffunction if necessary.
405
7f6c6450
DA
4062013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
407
408 Attempt to make redisplay more selective when changing cursor type.
409 * frame.h (struct frame): New bitfield cursor_type_changed.
410 * xdisp.c (cursor_type_changed): Remove.
411 (try_cursor_movement, redisplay_window, try_window_id)
412 (set_frame_cursor_types, try_window_reusing_current_matrix):
413 Adjust to use per-frame bitfield.
414 (redisplay_internal): Look for cursor type change on each visible
415 frame and consider all frames if cursor type has been changed on
416 the frame other than selected. If cursor type has been changed on
417 selected frame only, do not use fast update.
418
bd0443bb
DA
4192013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
420
421 Attempt to make redisplay more selective when changing fonts.
422 * frame.h (struct frame): New bitfield fonts_changed.
423 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
424 (adjust_frame_glyphs): Add prototype.
425 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 426 (adjust_glyphs): Remove because we do not
bd0443bb
DA
427 adjust matrices on all frames at once any more.
428 (adjust_frame_glyphs): Block and unblock input here.
429 (adjust_glyph_matrix): Use fonts_changed.
430 (change_frame_size_1): Use adjust_frame_glyphs.
431 * font.c (font_open_entity): Use fonts_changed.
432 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
433 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
434 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
435 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
436 (shrink_mini_window, Fresize_mini_window_internal)
437 (window_scroll_pixel_based, Fset_window_configuration)
438 (apply_window_adjustment, Fset_window_vscroll):
439 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
440 Use adjust_frame_glyphs.
441 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
442 (try_window_reusing_current_matrix, try_window_id, display_line)
443 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
444 (redisplay_internal): Consider fonts_changed and adjust frame
445 matrices for each frame only if the frame is visible. If font
446 has been changed on some frame during full redisplay, retry
447 only visible frames where the font has been actually changed.
448
b9695828
DA
4492013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
450
451 Cache current header and mode line height for each window.
452 * window.h (struct window): New fields mode_line_height
453 and header_line_height.
454 * window.c (make_window): Initialize them.
455 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
456 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
457 (current_mode_line_height, current_header_line_height):
458 Remove declaration.
459 * xdisp.c (current_mode_line_height, current_header_line_height):
460 Remove.
461 (pos_visible_p, init_xdisp): Adjust user.
462 (redisplay_window): Invalidate mode_line_height and
463 header_line_height if current and desired matrices do not agree.
464
66738305
DA
4652013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
466
467 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
468 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
469
257b3b03
DA
4702013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Make --without-x compatible with --enable-gcc-warnings.
473 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
474 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
475 members under HAVE_WINDOW_SYSTEM.
476 * keyboard.c (make_lispy_focus_out): Likewise.
477 (record_menu_key): Move under HAVE_MENUS.
478 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
479 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
480 (syms_of_xdisp): Adjust user.
481 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
482 (start_hourglass, cancel_hourglass):
483 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
484 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
485 and CLEAR_FONT_TABLE_NFONTS.
486 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
487 Declare only if HAVE_WINDOW_SYSTEM.
488 (lface_same_font_attributes_p, clear_face_gcs): Define only
489 if HAVE_WINDOW_SYSTEM.
490
98b7f4bd
DA
4912013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
492
493 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
494 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
495 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
496
a7e43722
SM
4972013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
498
499 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
500
0c90b9ee
PE
5012013-09-04 Paul Eggert <eggert@cs.ucla.edu>
502
503 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
504 This fixes a type error on hosts where ptrdiff_t is wider than int.
505
d99760fa
SM
5062013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
507
6629638e
SM
508 * keyboard.c (read_key_sequence_vs): New function.
509 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
510 common code.
511
d99760fa
SM
512 * callint.c (Fcall_interactively): Always return a vector for 'K'.
513
224e313d
PE
5142013-09-04 Paul Eggert <eggert@cs.ucla.edu>
515
516 Makefile improvements.
517 * Makefile.in (config.status): Don't use double-colon rules, as
518 they are not portable according to POSIX. Fix shell typo with `;
519 I guess this rule has never been tested?
520 (VCSWITNESS): New macro, to override any environment var.
521
6d6ed1af
DA
5222013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
523
524 * xterm.h (struct x_display_info): Do not track X connection
525 fd separately because it is always available from Display.
526 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
527 Adjust users.
528
bc923770
DA
5292013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
530
531 * buffer.c (drop_overlay):
532 * fileio.c (restore_point_unwind): Prefer unchain_marker to
533 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
534
b1cf96de
DA
5352013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
536
537 * buffer.c (Fmake_overlay, Fmove_overlay):
538 * intervals.c (set_point_from_marker):
539 * print.c (PRINTPREPARE): Prefer signal_error
540 to plain error and report unsuitable marker too.
541
d1fc6c21
DA
5422013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
543
544 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
545 for 'dragging' member.
d1ae6a0b
DA
546 (struct x_output): Remove set-but-unused leftovers
547 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
548 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
549 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
550 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
551 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
552 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
553 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 554 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 555 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 556
0ce9f6de
JD
5572013-09-03 Jan Djärv <jan.h.d@swipnet.se>
558
559 * nsfont.m (INVALID_GLYPH): New define.
560 (nsfont_encode_char): Use INVALID_GLYPH.
561 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
562
b594a96c
DA
5632013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
564
565 * xterm.c (x_last_mouse_movement_time): Revert last change.
566 This code should use XDisplayMotionBufferSize to check display's
567 motion history first, and there are few other issues as well.
568 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
569 (handle_one_xevent): Adjust user.
570
8b098236
MR
5712013-09-02 Martin Rudalics <rudalics@gmx.at>
572
9718b207
MR
573 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
574 * frame.c (Flast_nonminibuf_frame): ... to here.
575 (check_minibuf_window): Don't abort if no window was found
576 (Bug#15247).
8b098236 577
84e70bba
DA
5782013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
579
580 Use XGetMotionEvents to ask the last mouse motion time from X server.
581 * xterm.c (X_MOTION_HISTORY): Default to 1.
582 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
583 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
584 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
585 Ifdef away legacy code.
586 (XTmouse_position, x_scroll_bar_report_motion):
587 Use x_last_mouse_movement_time.
fc85e20b
DA
588 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
589 UnmapNotify event.
84e70bba 590
1fccc530
DA
5912013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
592
593 * msdos.c (last_mouse_window): Move to...
594 (dos_rawgetc): ...this function and adjust comment.
595 * nsterm.m (last_window): Rename to last_mouse_window, move to...
596 (mouseMoved): ...this function and adjust comment.
597 * w32term.c (last_window): Likewise with...
598 (w32_read_socket): ...this function.
599 * xterm.c (last_window): Likewise with...
600 (handle_one_xevent): ...this function.
601
0ab10992
DA
6022013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
603
b7da754d 604 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
605 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
606 (handle_one_xevent): ...to here.
607 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
608 otherwise.
609
0c7f856e
DA
6102013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
611
612 * msdos.c (IT_set_terminal_window): Remove no-op.
613 (initialize_msdos_display): Adjust terminal setup.
614 * w32console.c (w32con_set_terminal_window): Remove no-op.
615 (initialize_w32_display): Adjust terminal setup.
616 * w32term.c (w32_set_terminal_window): Remove no-op.
617 (w32_create_terminal): Adjust terminal setup.
618 * xterm.c (XTset_terminal_window): Remove no-op.
619 (x_create_terminal): Adjust terminal setup.
620
a892a94c
DA
6212013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
622
623 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
624 Remove no-ops.
625 (ns_create_terminal): Adjust terminal setup.
626 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
627 Remove no-ops.
628 (w32_create_terminal): Adjust terminal setup.
629 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
630 Remove no-ops.
631 (x_create_terminal): Adjust terminal setup.
632
cf91889a
DA
6332013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
634
635 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
636 (CLIP_TEXT_POS_FROM_MARKER): New macro.
637 * dispnew.c (buffer_posn_from_coords):
638 * window.c (Fwindow_end, displayed_window_lines):
639 * xdisp.c (redisplay_mode_lines): Use it.
640
5b0891df
JD
6412013-09-01 Jan Djärv <jan.h.d@swipnet.se>
642
643 * fontset.c (face_for_char): Check char in the current face font first
644 if HAVE_NS (Bug#15138).
645
0a357e98
MR
6462013-08-31 Martin Rudalics <rudalics@gmx.at>
647
648 * window.c (temp_output_buffer_show): Make sure window returned
649 by display_buffer is live (Bug#15213).
650
9d7693d7
DA
6512013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
652
653 Minor cleanup to avoid forward declarations.
654 * coding.h (struct ccl_spec): Remove forward declaration.
655 * composite.h (toplevel): Include font.h.
656 (struct composition_it, struct face, struct font_metrics):
657 Remove forward declaration.
658 * dispextern.h (struct image, struct atimer): Likewise.
659 * emacsgtkfixed.h (struct frame): Likewise.
660 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
661 * font.h (struct font_driver, struct font, struct glyph_string)
662 (struct face): Remove forward declaration.
663 * fontset.h (struct face, struct font): Likewise.
664 * frame.h (toplevel): Style cleanup.
665 (enum output_method): Move to...
666 * termhooks.h (enum output_method): ...here.
667 (struct glyph, struct frame, struct ns_display_info)
668 (struct x_display_info, struct w32_display_info):
669 Remove forward declaration.
670 * xterm.h (toplevel): Include termhooks.h.
671 (struct font, struct window, struct glyph_matrix, struct frame)
672 (struct input_event, struct face, struct image): Remove forward
673 declaration.
674 * gtkutil.h (struct _widget_value): Likewise.
675 * keyboard.h (toplevel): Include termhooks.h.
676 (struct input_event): Remove forward declaration.
677
032f7451
DA
6782013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
679
680 * intervals.c (set_point_from_marker): New function.
681 * editfns.c (Fgoto_char):
682 * process.c (Finternal_default_process_filter):
683 * window.c (select_window_1): Use it.
684 * buffer.h (set_point_from_marker): Add prototype.
685
3f940c5a
EZ
6862013-08-29 Eli Zaretskii <eliz@gnu.org>
687
688 * w32.c (term_winsock): Call release_listen_threads before calling
689 WSACleanup.
690 (_sys_wait_accept): Wait for accept event in a loop with a finite
691 timeout, instead of waiting indefinitely. Will hopefully avoid
692 hanging during exit because WSACleanup deadlocks waiting for the
693 event object to be released. (Bug#14333)
694
695 * w32proc.c (release_listen_threads): New function, signals all
696 the reader threads that listen for connections to stop waiting.
697
698 * w32.h (release_listen_threads): Add prototype.
699
101ed2bb
DA
7002013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
701
702 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
703 field of new marker (for sanity and safety).
20de2834
DA
704 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
705 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 706
1f5cf200
DA
7072013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
708
709 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
710 (x_after_update_window_line, x_scroll_bar_create):
711 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
712 (handle_one_xevent, x_clear_frame_area):
713 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
714 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
715 * xterm.h (x_clear_area): Adjust prototype.
716
d2b36813
DA
7172013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
718
719 Hook scanning and indentation functions to find_newline. This helps
720 to avoid duplicated code and renders more respect to newline cache.
721 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
722 * cmds.c (Fforward_line):
723 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
724 Use find_newline and avoid unnecessary point movements.
725 * search.c (scan_newline): Implement on top of find_newline.
726
3ec7babc
SM
7272013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
728
729 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
730 scoped code (bug#11258).
731
5ab473cd
JD
7322013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
733
734 * nsterm.m (last_window): New variable.
735 (EV_TRAILER2): New macro.
736 (EV_TRAILER): Call EV_TRAILER2.
737 (mouseMoved:): Add support for mouse-autoselect-window
738 on nextstep (Bug#6888).
739
78779650
AS
7402013-08-28 Andreas Schwab <schwab@suse.de>
741
742 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
743 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
744 Remove unused macro definitions.
745 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
746 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
747 Only define if emacs.
78779650 748
c3c4768d
DA
7492013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
750
751 Prefer enum glyph_row_area to int where appropriate.
752 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
753 Fix comment.
754 (window_box, window_box_width, window_box_left, window_box_left_offset)
755 (window_box_right, window_box_right_offset): Adjust prototypes.
756 * xdisp.c (window_box, window_box_width, window_box_left)
757 (window_box_left_offset, window_box_right, window_box_right_offset):
758 Use enum glyph_row_area. Adjust users and tweak comment where needed.
759 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
760 * nsterm.m (ns_clip_to_row):
761 * w32term.c (w32_clip_to_row):
762 * xterm.c (x_clip_to_row): Likewise.
763
6bdcbfe1
DA
7642013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
765
766 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
767 (Fprevious_overlay_change): Fast path for buffer with no overlays.
768
50b13cde
PE
7692013-08-28 Paul Eggert <eggert@cs.ucla.edu>
770
771 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
772 for portability to hosts where /bin/sh has problems.
773
f60e429a
DA
7742013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
775
776 Redesign redisplay interface to drop global output_cursor.
777 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
778 (toplevel): Remove declaration of output_cursor.
779 (set_output_cursor, x_cursor_to): Remove prototype.
780 * window.h (struct window): New member output_cursor.
781 (output_cursor_to): New function to replace RIF member.
782 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
783 (update_text_area, set_window_cursor_after_update): Use it.
784 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
785 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
786 * nsterm.m (ns_update_window_begin, ns_update_window_end):
787 * w32term.c (x_update_window_begin, x_update_window_end):
788 * xterm.c (x_update_window_begin, x_update_window_end):
789 Adjust to use per-window output cursor.
790
43aac990
PE
7912013-08-27 Paul Eggert <eggert@cs.ucla.edu>
792
d486344e
PE
793 Simplify SELECT_TYPE-related code.
794 Like EMACS_TIME, this portability layer is no longer needed, since
795 Emacs has been using fd_set as a portability layer for some time.
796 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
797 (SELECT_TYPE): Remove. All uses changed to fd_set.
798 (fd_set) [!FD_SET]: New typedef.
799
43aac990
PE
800 Simplify EMACS_TIME-related code.
801 This portability layer is no longer needed, since Emacs has been
802 using struct timespec as a portability layer for some time.
803 * atimer.h, buffer.h, dispextern.h, xgselect.h:
804 Include <time.h> rather than "systime.h"; that's all that's needed now.
805 * dispnew.c: Include <timespec.h> rather than "systime.h";
806 that's all that's needed now.
807 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
808 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
809 TIMESPEC_RESOLUTION.
810 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
811 LOG10_TIMESPEC_RESOLUTION.
812 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
813 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
814 (make_emacs_time): Remove. All used changed to make_timespec.
815 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
816 (current_timespec): Rename from current_emacs_time. All uses changed.
817 (add_emacs_time): Remove. All uses changed to timespec_add.
818 (sub_emacs_time): Remove. All uses change dot timespec_sub.
819 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
820 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
821 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
822 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
823 (current_timespec): Rename from current_emacs_time. All uses changed.
824 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
825 changed to timespec_cmp.
826 * xgselect.c: Include <timespec.h>, since our .h files don't.
827
d350e350
DA
8282013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
829
830 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
831 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
832 Remove the leftovers.
833 * gtkutil.c (toplevel): Do not declare Qxft but include
834 font.h to do so.
835 * image.c (toplevel): Do not declare Vlibrary_cache because
836 it's already done in lisp.h.
837
9fed9729
DA
8382013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
839
840 * lisp.h (Mouse_HLInfo): Move from here...
841 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
842 (reset_mouse_highlight): New function.
843 * msdos.c (dos_set_window_size, IT_update_begin)
844 (internal_terminal_init):
845 * nsterm.m (ns_update_window_end, x_free_frame_resources)
846 (ns_initialize_display_info):
847 * w32console.c (initialize_w32_display):
848 * w32term.c (x_update_window_end, x_free_frame_resources)
849 (w32_initialize_display_info):
850 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
851 * window.c (Fdelete_other_windows_internal):
852 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
853 * termchar.h (toplevel):
854 * xterm.h (toplevel): Include dispextern.h.
855
f462f075
PE
8562013-08-26 Paul Eggert <eggert@cs.ucla.edu>
857
858 Fix minor problems found by static checking.
859 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
860 (expect): Avoid nested-if warning.
861 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
862 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
863 * nsterm.h, nsterm.m (ns_select):
864 * xgselect.c, xgselect.h (xg_select):
865 Adjust signature to better match pselect's.
866 * nsterm.m (ns_select):
867 Don't set *TIMEOUT, since pselect doesn't.
868 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
869 diagnostic about assigning const char * to it.
870 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
871
068f9124
SM
8722013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
873
874 * lread.c (substitute_object_recurse): Handle hash-tables as well
875 (bug#15190).
876
f5adc984
PE
8772013-08-26 Paul Eggert <eggert@cs.ucla.edu>
878
1fc8eb33
PE
879 Fix unlikely core dump in init_tty, and simplify terminfo case.
880 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
881 The old version incorrectly dumped core if malloc returned a
882 buffer containing only non-NUL bytes.
883 (init_tty): Do not allocate or free termcap buffers; the
884 struct does that for us now.
885 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
886 (struct tty_display_info): Define members termcap_term_buffer and
887 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
888 use them. Allocate them directly in struct rather than indirectly
889 via a pointer, to simplify init_tty.
890
f5adc984
PE
891 * frame.c (check_minibuf_window): Initialize 'window' properly,
892 so that Emacs reliably aborts later if 'window' is not initialized.
893
efec3894
JD
8942013-08-26 Jan Djärv <jan.h.d@swipnet.se>
895
896 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
897 of VoidSymbol (Bug#15154).
898
e1d0341e
DA
8992013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
900
901 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
902 mouse_face_beg_y and mouse_face_end_y.
903 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
904 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
905 Adjust users and update comment where appropriate.
906
bfff6445
MR
9072013-08-26 Martin Rudalics <rudalics@gmx.at>
908
909 * frame.c (check_minibuf_window): New function.
068f9124
SM
910 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
911 Call check_minibuf_window (Bug#15183).
bfff6445 912
c80016b3
DA
9132013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
914
915 * window.h (struct window): Replace last_cursor with last_cursor_vpos
916 because this is the only last cursor data we need to keep and consult.
917 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
918 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
919 Adjust users.
920
de396731
DA
9212013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
922
068f9124
SM
923 Fix recovering from possible decompression error.
924 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 925 the position where the partially decompressed data ends, and
447218dd 926 should count how many bytes was produced so far.
de396731
DA
927 * decompress.c (struct decompress_unwind_data): Add nbytes member.
928 (unwind_decompress): Really delete partially uncompressed data.
929 (Fzlib_decompress_region): Take decompressed data size into account.
930
c76826d9
DA
9312013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
932
933 * syntax.c (init_syntax_once): Adjust comment and do an early
934 initialization of Qchar_table_extra_slots just once...
935 * casetab.c (init_casetab_once):
936 * category.c (init_category_once):
937 * character.c (syms_of_character):
938 * coding.c (syms_of_coding):
939 * xdisp.c (syms_of_xdisp): ...and omit it here.
940
b34454d0
EZ
9412013-08-24 Eli Zaretskii <eliz@gnu.org>
942
11f20add
EZ
943 * xdisp.c (get_next_display_element): Don't apply to characters
944 from a display vector the logic of setting it->end_of_box_run_p
945 suitable for characters from a buffer. (Bug#15175)
946
b34454d0
EZ
947 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
948 to handle directories, rather than '_utime' which doesn't.
949 (Bug#15176)
950
6e1b469e
JD
9512013-08-24 Jan Djärv <jan.h.d@swipnet.se>
952
953 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
954 or fullscreen (Bug#14627).
955
9c05bccf
PE
9562013-08-24 Paul Eggert <eggert@cs.ucla.edu>
957
958 System-dependent integer overflow fixes.
959 * process.c (Fset_process_window_size): Signal an error if
960 the window size is outside the range supported by the lower level.
961 * sysdep.c (set_window_size): Return negative on error,
962 nonnegative on success, rather than -1, 0, 1 on not in system,
963 failure, success. This is simpler. Caller changed.
964 (serial_configure): Remove unnecessary initialization of local.
965 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
966 size fits in unsigned long; this isn't true on some 32-bit hosts.
967 Avoid buffer overrun if some future version of /proc/meminfo has a
968 variable name longer than 20 bytes.
969 (system_process_attributes) [__FreeBSD__]:
970 Don't assume hw.availpages fits in 'int'.
971
c365c355
PE
9722013-08-23 Paul Eggert <eggert@cs.ucla.edu>
973
974 Don't let very long directory names overrun the stack.
975 Fix some related minor problems involving "//", vfork.
976 * callproc.c (encode_current_directory): New function.
977 (call_process): Don't append "/"; not needed.
978 * fileio.c (file_name_as_directory_slop): New constant.
979 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
980 this can save the caller having to alloca.
981 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
982 Use SAFE_ALLOCA, not alloca.
983 (directory_file_name, Fexpand_file_name): Leave leading "//"
984 alone, since it can be special even on POSIX platforms.
985 * callproc.c (call_process):
986 * process.c (Fformat_network_address):
987 * sysdep.c (sys_subshell):
988 Use encode_current_directory rather than rolling our own.
989 (create_process): No need to encode directory; caller does that now.
990 * process.h (encode_current_directory): New decl.
991 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
992 Rework to avoid 'goto xyzzy;'.
993
6c6014d4
EZ
9942013-08-23 Eli Zaretskii <eliz@gnu.org>
995
996 * xdisp.c (handle_face_prop): If the default face was remapped use
997 the remapped face for strings from prefix properties. (Bug#15155)
998
9997ec56
DA
9992013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1000
1001 Minor cleanup for redisplay interface and few related functions.
1002 * frame.h (enum text_cursor_kinds): Move from here...
1003 * dispextern.h (enum text_cursor_kinds): ...to here.
1004 (toplevel): Drop unnecessary declarations.
1005 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1006 in update_window_end_hook and draw_window_cursor functions.
1007 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1008 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1009 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1010 * xterm.c (x_update_window_end, x_draw_window_cursor):
1011 * xdisp.c (display_and_set_cursor, update_window_cursor)
1012 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1013 enum text_cursor_kinds where appropriate.
1014
7f780da6
DA
10152013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1016
1017 Redesign redisplay interface to drop updated_row and updated_area.
1018 * dispextern.h (updated_row, updated_area): Remove declaration.
1019 (struct redisplay_interface): Pass glyph row and row area parameters
1020 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1021 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1022 Adjust prototypes.
1023 * dispnew.c (updated_row, updated_area): Remove.
1024 (redraw_overlapped_rows, update_window_line): Adjust user.
1025 (update_marginal_area, update_text_area): Likewise. Pass updated row
1026 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1027 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1028 Adjust users.
1029
26495794
PE
10302013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 * process.c (flush_pending_output): Remove stub.
1033 All uses removed.
1034
4a88129a
PE
10352013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 * callproc.c: Fix race that killed background processes (Bug#15144).
1038 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1039 Record deleted process-id in critical section, not afterwards.
1040 Don't mistakenly kill process created by a call-process invocation
1041 that discards output and does not wait.
1042
0c5307b0
DA
10432013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1044
1045 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1046 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1047 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1048 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1049 to shut up compiler in mark_object.
1050 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1051
0d7c1e66
PE
10522013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1053
1054 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1055 We can't portably rely on PTY_OPEN doing that, even if
1056 it calls posix_openpt with O_CLOEXEC.
1057
3f246b65
KH
10582013-08-20 Kenichi Handa <handa@gnu.org>
1059
1060 * character.c (string_char): Improve commentary.
1061
8c2f38aa
PE
10622013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1065 (struct animation_cache): Make signature a flexible array member.
1066 All uses changed. This is a tad slower but may insulate us better
1067 from future changes to ImageMagick.
1068
bb566cea
PE
10692013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 * image.c: Shrink memory needed for animation cache.
1072 (SIGNATURE_DIGESTSIZE): New constant.
1073 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1074 (imagemagick_create_cache): Copy the signature. This saves
1075 several KB of memory that ImageMagick wastes per signature.
1076 Don't bother updating the update_time, as the caller does that now.
1077 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1078 it's a fixed size struct member now.
1079 (imagemagick_get_animation_cache): Always destroy the signature,
1080 as it's now imagemagick_create_cache's responsibility to copy it.
1081 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1082 and use memcmp rather than strcmp.
1083 eassert that ImageMagick returns a signature of the specified length.
1084
6da26928
LMI
10852013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1086
1087 * image.c (imagemagick_get_animation_cache): Don't segfault on
1088 each invocation.
453f4022
LMI
1089 (imagemagick_get_animation_cache): Revert to previous definition
1090 so that it actually works. But keep the memory leak fix.
1091 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1092
22490125
PE
10932013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1094
d0139df5
PE
1095 * image.c: Fix animation cache signature memory leak.
1096 Fix some other minor performance problems while we're at it.
1097 (imagemagick_create_cache): Clear just the members that
1098 need clearing. Don't set update_time, as caller does that now.
1099 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1100 Simplify by using pointer-to-pointer instead of a prev pointer.
1101 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1102 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1103 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1104 it's already a copy. Free the signature probe unless it's cached.
1105
22490125
PE
1106 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1107 This was introduced by my 2013-08-12 fix for Bug#15035.
1108
deb31e75
DA
11092013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1112 (imagemagick_prune_animation_cache): Now static.
1113
319a4d03
LMI
11142013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1115
1116 * image.c (imagemagick_get_animation_cache): Don't segfault when
1117 pruning all entries.
1118
f747d82e
KB
11192013-08-18 Ken Brown <kbrown@cornell.edu>
1120
1121 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1122 static heap if ENABLE_CHECKING is defined.
1123 (max_bss_sbrk_ptr): New variable.
1124 (bss_sbrk): Use it.
1125 (report_sheap_usage): Report maximum static heap usage instead of
1126 ending static heap usage.
1127
d2c28fab
EZ
11282013-08-17 Eli Zaretskii <eliz@gnu.org>
1129
1130 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1131 of zlib_initialized according to the results of calling
1132 init_zlib_functions.
1133
274ff63f
LMI
11342013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1135
1136 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1137 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1138 (imagemagick_load_image): Remove the ping_wand code, which only
1139 apparently saved time on invalid animated images, and slowed down
1140 everything else. Optimise for the common case.
274ff63f 1141
2bede2ed
XF
11422013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1143
70ff8240
XF
1144 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1145
de179a3e
XF
1146 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1147
2bede2ed
XF
1148 * marker.c (set_marker): Remove documentation of undefined behavior.
1149
703dbeba
LMI
11502013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1151
1152 * image.c (imagemagick_compute_animated_image): Animate correctly
1153 when sub-images are smaller than the main image.
1d18b1e6
LMI
1154 (imagemagick_compute_animated_image): Setting the iterator row to
1155 zero is apparently not allowed.
79670014
LMI
1156 (imagemagick_compute_animated_image): Allow images that say they
1157 have sub-images that are bigger than the main image, but just crop
1158 them.
703dbeba 1159
63216c5e
JD
11602013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1161
1162 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1163
a5b5f73f
LMI
11642013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1165
1166 * image.c (imagemagick_compute_animated_image): Respect the GIF
1167 disposal methods.
1168
0fe73012
KB
11692013-08-15 Ken Brown <kbrown@cornell.edu>
1170
1171 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1172 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1173 needed.
1174
691a357f
PE
11752013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 Fix minor problems found by static checking.
1178 * frame.c (delete_frame):
1179 * xdisp.c (next_element_from_display_vector):
1180 Avoid uninitialized local.
1181 * image.c (imagemagick_compute_animated_image): Port to C89.
1182 Prefer usual GNU indentation style for loops.
1183 Be more careful about bizarrely large sizes, by using ptrdiff_t
1184 instead of int.
1185
42fe2e88
DA
11862013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 Fix infinite frame selection loop (Bug#15025).
1189 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1190
d39a3da6
EZ
11912013-08-15 Eli Zaretskii <eliz@gnu.org>
1192
068f9124
SM
1193 * xdisp.c (compute_window_start_on_continuation_line):
1194 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1195 to make sure we end up setting the window start at the leftmost
1196 visible character of the display line. This avoids funky
1197 horizontal shifting because the window start is not kept on the
1198 same position. (Bug#15090)
05426239
EZ
1199 (next_element_from_display_vector): Support 'box' face attribute
1200 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1201
6e856b69
LMI
12022013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1203
1204 * image.c (imagemagick_compute_animated_image): Implement animated
1205 images (bug#14700).
995be755
LMI
1206 (imagemagick_compute_animated_image): Fix some compilation
1207 warnings. Implement a very simple cache to make the animation
1208 usable at all, but it should be replaced with a per-image cache.
6e856b69 1209
d5a1acfa
DA
12102013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1211
1212 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1213 to do `for' loops over alist values.
1214 * buffer.h (FOR_EACH_BUFFER):
1215 * process.c (FOR_EACH_PROCESS): Use it.
1216 (handle_child_signal, status_notify, Fget_buffer_process)
1217 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1218
9c253307
DA
12192013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1220
1221 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1222 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1223 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1224 to xzalloc and so avoid redundant call to memset.
1225 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1226 members because it is allocated with xzalloc and so already zeroed.
1227
05e64f9f
KB
12282013-08-14 Ken Brown <kbrown@cornell.edu>
1229
1230 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1231 (Bug#15094).
1232
5b71542d
DA
12332013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1234
1235 Utility function and macro to copy Lisp string to C string.
1236 * lisp.h (xlispstrdupa): New macro.
1237 (xlispstrdup): New prototype.
1238 * alloc.c (xlispstrdup): New function.
1239 * callint.c (Fcall_interactively):
1240 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1241 (Fsubstitute_in_file_name):
1242 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1243 * image.c (x_create_bitmap_from_file):
1244 * w32term.c (w32_term_init):
1245 * xterm.c (x_term_init): Use xlispstrdup.
1246
71530c97
LMI
12472013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1248
4ce82fb8
LMI
1249 * image.c (imagemagick_load_image): Make animated pictures work.
1250 There's still some problems with background color settings, though
1251 (bug#14700).
1252
71530c97
LMI
1253 * decompress.c (unwind_decompress): Always restore point.
1254
7510a061
XF
12552013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1256
1257 * marker.c (set_marker): Reformat documentation.
1258
01c3051f
PE
12592013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1260
aab1fcdf
PE
1261 * xdisp.c (cursor_type_changed): Now static.
1262
01c3051f
PE
1263 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1264 Use changed. This avoids the need to call xmalloc and for the
1265 caller to call xfree, and avoids memory leaks in some situations.
1266
2084152a
DA
12672013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1268
1269 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1270 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1271 (redisplay_window): If window_end_valid is cleared due to non-zero
1272 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1273 so do not call to try_cursor_movement for that window.
2084152a 1274
02455cb6
DA
12752013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1276
1277 * window.h (struct window): Convert window_end_pos and
1278 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1279 (wset_window_end_pos, wset_window_end_vpos): Remove.
1280 * dispnew.c (adjust_glyph_matrix):
1281 * window.c (Fwindow_end, replace_window, set_window_buffer)
1282 (make_window):
1283 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1284 (set_vertical_scroll_bar, redisplay_window, try_window)
1285 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1286 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1287 (note_mouse_highlight): Adjust users.
1288 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1289 Add comment.
1290
da5707e8
DA
12912013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1292
1293 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1294 * image.c (imagemagick_filename_hint): Use `const char *' and
1295 prefer SSDATA to SDATA to avoid warnings.
1296
25554267
DA
12972013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 Cleanup window fringes, margins and scroll bars adjustments.
1300 * window.c (set_window_fringes, set_window_margins)
1301 (set_window_scroll_bars, apply_window_adjustment): New functions.
1302 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1303 (Fset_window_scroll_bars): Use them.
1304
38a2c910
DA
13052013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 * window.h (struct window): Convert scroll_bar_width
1308 from Lisp_Object to integer. Adjust comment.
1309 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1310 Adjust users.
1311 * window.c (wset_scroll_bar_width): Remove.
1312 (make_window): Initialize scroll_bar_width.
1313 (Fsplit_window_internal): Use direct assignment.
1314 (Fset_window_configuration, save_window_save):
1315 Convert Lisp_Object to integer and back where appropriate.
1316 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1317 bar was actually changed, and mention this in docstring.
1318
2d065031
PE
13192013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * decompress.c: Minor simplifications.
1322 (Fzlib_decompress_region): Don't bother verifying
1323 that avail_out <= UINT_MAX, as that was confusing.
1324 Mention the restriction in a comment instead.
1325 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1326
a5bd5abb
JD
13272013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1328
1329 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1330 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1331
66e7901a
LMI
13322013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1333
1334 * image.c (imagemagick_filename_hint): Check for errors in the
1335 alist structure.
1336
2fa611b7
EZ
13372013-08-13 Eli Zaretskii <eliz@gnu.org>
1338
1339 * window.c (Fwindow_margins): Return nil when there's no marginal
1340 area, as per the documented API.
1341
1342 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1343 Fmake_vector, as scroll bar's struct members are not all Lisp
1344 objects now. This avoids crashes in GC.
1345
1346 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1347 bool, so its address could be taken.
1348
8259030d
LMI
13492013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1350
1351 * image.c (imagemagick_filename_hint): New function to possibly
1352 apply `image-content-type-suffixes'.
1353 (imagemagick_load_image): Use it.
1354
866c710e
EZ
13552013-08-13 Eli Zaretskii <eliz@gnu.org>
1356
1357 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1358 if loading zlib failed.
1359
f10490f0
JD
13602013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1361
96311be7
JD
1362 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1363 2013-08-13 checkin below. Change bool to BOOL, rule is:
1364 All Obj-C code uses BOOL, except for interfaces callable from C.
1365
f10490f0
JD
1366 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1367
c8ae93b0
DA
13682013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1369
1370 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1371 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1372 bool instead of BOOL.
1373 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1374 from Lisp_Object to bitfield. Adjust comment.
1375 * w32term.c (x_scroll_bar_create): Adjust user.
1376 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1377 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1378 Use bool for boolean.
1379 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1380 to `unsigned int' when defining a bitfield.
1381
53b64418
PE
13822013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1385
eeaf9bf3
DA
13862013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1387
1388 * window.h (struct window): Convert left_margin_cols and
1389 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1390 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1391 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1392 Adjust users.
1393 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1394 Adjust comment.
1395 (showing_window_margins_p, update_window_line, update_frame_1):
1396 * fringe.c (draw_fringe_bitmap_1):
1397 * xdisp.c (window_box_width): Adjust users.
1398 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1399 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1400 Use direct assignment.
1401 (Fset_window_configuration, save_window_save, Fwindow_margins):
1402 Convert Lisp_Object to integer and back where appropriate.
1403 (Fset_window_margins): Adjust user. Return t if any margin
1404 was actually changed, and mention this in docstring.
1405
956720af
XF
14062013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1407
f73f4ce6 1408 * syntax.c (forward_word):
956720af
XF
1409 * cmds.c (forward_char, backward_char): Mention the optional argument.
1410
9e37ee3b
DA
14112013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1412
1413 * window.h (struct window): Convert left_fringe_width
1414 and right_fringe_width from Lisp_Objects to integers.
1415 Adjust comment.
1416 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1417 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1418 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1419 Remove.
1420 (make_window): Initialize new integer fields to -1.
1421 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1422 (Fset_window_configuration, save_window_save):
1423 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1424 (Fset_window_fringes): Adjust user. Return t if any fringe
1425 was actually changed, and mention this in docstring.
1426
e4375ca7
DA
14272013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1428
1429 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1430 * nsfns.m (x_set_cursor_type):
1431 * w32fns.c (x_set_cursor_type):
1432 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1433 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1434
a45543bc
DA
14352013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1436
1437 * font.c (clear_font_cache): New function, stripped from...
1438 (Fclear_font_cache): ...here, which now uses the function
1439 above. Adjust comment.
1440 * font.h (clear_font_cache): Add prototype.
1441 * xfaces.c (clear_face_cache): Use clear_font_cache.
1442
ae966a86
DA
14432013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1444
1445 * window.c (Fset_window_start): Compare `w', not `window' because
1446 `w' might not be equal to `window' after call to decode_live_window.
1447
297a545b
PE
14482013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1449
1450 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1451 This fixes a problem introduced by the Bug#15035 patch
1452 when using GPG. Reported by Herbert J. Skuhra.
1453
aa942e2b
EZ
14542013-08-12 Eli Zaretskii <eliz@gnu.org>
1455
1456 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1457 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1458 not yet initialized.
1459
7699d09e
LMI
14602013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1461
1462 * decompress.c (Fzlib_decompress_region): Support zlib
1463 decompression, too, and rename.
1464
1d238bc7
PE
14652013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1466
1467 Minor zlib configuration tweaks.
1468 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1469 Don't assume presence of fn_inflateInit2_ zlib internal function.
1470
8a44a184
LMI
14712013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1472
1473 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1474 include the zlib prefix.
1475
594a4307
EZ
14762013-08-12 Eli Zaretskii <eliz@gnu.org>
1477
1478 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1479 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1480 define static variables that are pointers to zlib functions to be
1481 dynamically loaded.
1482 (init_zlib_functions) [WINDOWSNT]: New function.
1483 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1484 New macros.
1485 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1486 macros instead of invoking the zlib functions directly.
068f9124
SM
1487 (syms_of_decompress): DEFSYM Qzlib_dll.
1488 Staticpro Szlib_available_p.
594a4307 1489
d2e113bc
DA
14902013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1491
1492 Avoid looping over all frame windows to freeze and unfreeze.
1493 * window.h (struct window): Drop frozen_window_start_p.
1494 (freeze_window_starts): Drop prototype.
1495 * frame.h (struct frame): New frozen_window_starts flag.
1496 (FRAME_WINDOWS_FROZEN): New macro.
1497 * window.c (freeze_window_start, freeze_window_starts):
1498 Remove.
1499 (select_window, replace_window): Adjust users.
1500 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1501 (window_frozen_p): New function.
1502 (redisplay_window): Use it.
1503
94fcd171
PE
15042013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 Fix some fd issues when running subprocesses (Bug#15035).
1507 Fix bugs that can leak files or file descriptors on errors.
1508 Don't unlink open temp files, as that's hard for users to diagnose
1509 when things go awry (e.g., temp disk exhausted).
1510 Don't bother to lock temp files. Check for invalid recursion.
1511 * callproc.c (synch_process_fd): Remove. All uses removed.
1512 (synch_process_tempfile): New var or macro.
1513 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1514 New constants.
1515 (record_kill_process): New arg, the temp name. All callers changed.
1516 (delete_temp_file): Now just a simple wrapper around unlink.
1517 (call_process_kill): New arg, the call_process_fd array.
1518 Close them all. Clear synch_process_pid. Remove the temp file,
1519 or arrange for it to be removed.
1520 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1521 that's been moved to synch_process_tempfile. Caller changed.
1522 Do not remove the tempfile; that's now call_process_kill's
1523 responsibility.
1524 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1525 call_process_kill; the caller now does that.
1526 (call_process_cleanup): Do not close the process fd; that's now
1527 call_process_kill's responsibility.
1528 (Fcall_process): Implement via new function call_process, which
1529 has most of the old body of Fcall_process, but with a different API.
1530 (call_process): New function that does not open or close filefd if
1531 it is nonnegative. Record which fds need to be closed, and let
1532 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1533 Signal an error if invoked recursively (could be done via a hook).
1534 Simplify creation of the tempfile in the MSDOS case.
1535 Don't create the output file until after checking for the executable.
1536 Report any failure to open /dev/null.
1537 Don't open /dev/null for writing twice; once is enough.
1538 Don't create pipe if all output is being discarded or sent to file.
1539 Don't worry about setting up the coding system or reading from the
1540 pipe if all output is being discarded.
1541 Hoist fd_error local into top level, to lessen block nesting.
1542 Don't record deleted pid here; now done by Fcall_process_region.
1543 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1544 and note its success in synch_process_tempfile.
1545 Do not leak resources when child_setup fails.
1546 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1547 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1548 (create_temp_file): Now returns open fd, with an additional
1549 Lisp_Object * argument to return the name. All callers changed.
1550 Do not close the file; rewind it instead, and leave it open for
1551 the caller. Do not lock the temp file. Unwind-protect the file
1552 and the file-descriptor.
1553 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1554 If an asynchrounous process, record it here, not in call_process.
1555 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1556 * eval.c (set_unwind_protect): New function.
1557 * fileio.c (write_region): New function, generalized from the
1558 old Fwrite_region. Do not lock temp files.
1559 (Fwrite_region): Use it.
1560 * lisp.h (set_unwind_protect, write_region): New decls.
1561 * process.c: Include <verify.h>.
1562 (make_process): Mark fds as initially closed.
1563 (deleted_pid_list): Now a list of pid-filename pairs.
1564 All uses changed.
1565 (close_process_fd): New function.
1566 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1567 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1568 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1569 (create_process, create_pty, Fmake_serial_process)
1570 (server_accept_connection): Record which fds need to be closed,
1571 and let deactivate_process close them.
1572 (Fmake_network_process): Do not discard the unwind-protect
1573 until it's safe to do so.
1574 (deactivate_process): Close the fds opened by create_process etc.
1575 (Fprocess_send_eof): Adjust to new way of recording open fds.
1576 Report an error if /dev/null can't be opened, instead of aborting.
1577 * process.h (PROCESS_OPEN_FDS): New constant.
1578 (struct Lisp_Process): New member open_fds.
1579 (record_kill_process, record_deleted_pid): Adjust signatures.
1580 (record_deleted_pid): Move decl here ...
1581 * syswait.h (record_deleted_pid): ... from here.
1582
d0e615c3
PE
15832013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 * decompress.c: Fix bugs with large buffers and weird inputs.
1586 Tune a bit. Reindent as per usual Emacs style.
1587 (BUFFER_SIZE): Remove.
1588 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1589 more than UINT_MAX bytes. Decompress into the gap instead of into
1590 an auto buffer, as this should avoid copying. Return nil if
1591 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1592 set immediate_quit; we shouldn't trust zlib code that much.
1593
313546eb
LMI
15942013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1595
99a32242
LMI
1596 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1597 errors, and really move the gap to where we want it.
1598
313546eb
LMI
1599 * lisp.h: Include decompress.c support.
1600
1601 * emacs.c (main): Include decompress.c support.
1602
1603 * Makefile.in: Include -lz if present.
1604
d2d699ac
JD
16052013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1606
f90e3ebd
JD
1607 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1608 (initWithTitle:): Initialize frame to 0.
1609 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1610 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1611 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1612
1613 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1614 fillWithWidgetValue:frame:
1615
423d3b3f
JD
1616 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1617 remove memory leak warnings.
1618
d2d699ac
JD
1619 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1620 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1621 menu_pending_title.
1622
1623 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1624 (x_activate_menubar): Update the whole menu.
1625 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1626 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1627 current event is not NSSystemDefined (Bug#15001).
1628 Call ns_check_menu_open only if trackingMenu is 2.
1629 (menuDidClose:): New method, decrease trackingMenu.
1630 (fillWithWidgetValue:setDelegate:): New method.
1631 (fillWithWidgetValue:): Call the above.
1632
1633 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1634
7d652d97
PE
16352013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 Omit some unnecessary casts.
1638 Many of these go back to the old pre-C89 days, when they may have
1639 been needed, but we've been assuming C89 or later for a while now.
1640 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1641 (live_float_p, live_misc_p, live_vector_p):
1642 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1643 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1644 (defvar_per_buffer):
1645 * callint.c (Fcall_interactively):
1646 * doc.c (Fsubstitute_command_keys):
1647 * filelock.c (get_boot_time):
1648 * frame.c (xrdb_get_resource):
1649 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1650 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1651 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1652 (menuitem_highlight_callback, menu_destroy_callback)
1653 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1654 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1655 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1656 (xg_tool_bar_help_callback, tb_size_cb):
1657 * image.c (xpm_alloc_color, png_read_from_memory)
1658 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1659 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1660 (syms_of_image):
1661 * keymap.c (describe_map):
1662 * nsfns.m (Fns_display_monitor_attributes_list):
1663 * nsmenu.m (process_dialog:):
1664 * nsterm.m (hold_event):
1665 * process.c (wait_reading_process_output):
1666 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1667 * scroll.c (do_direct_scrolling, scrolling_1):
1668 * termcap.c (tgetent):
1669 * window.c (check_window_containing, add_window_to_list)
1670 (freeze_window_starts):
1671 * xdisp.c (compare_overlay_entries, vmessage):
1672 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1673 (x_get_monitor_attributes_xrandr)
1674 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1675 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1676 * xfont.c (xfont_match, xfont_open):
1677 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1678 (menubar_selection_callback, menu_position_func)
1679 (popup_selection_callback, create_and_show_popup_menu)
1680 (dialog_selection_callback, create_and_show_dialog):
1681 * xrdb.c (x_get_string_resource):
1682 (main) [TESTRM]:
1683 * xsmfns.c (x_session_check_input):
1684 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1685 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1686 (xaw_jump_callback, xaw_scroll_callback):
1687 Omit unnecessary casts.
1688
9acc1074
PE
16892013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1690
1691 Minor string-length refactoring.
1692 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1693 * frame.c (make_monitor_attribute_list):
1694 Prefer build_string to strlen + make_string.
1695
361c0eb8
JD
16962013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1697
1698 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1699 don't check minor_code (Bug#14417).
1700
14ba0822
EZ
17012013-08-09 Eli Zaretskii <eliz@gnu.org>
1702
1703 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1704 vertical positions instead. This avoids calling MATRIX_ROW with
1705 row numbers that are possibly beyond valid limits. (Bug#15064)
1706
309f24d1
DA
17072013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1708
1709 Use xstrdup and build_unibyte_string where applicable.
1710 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1711 * xfns.c (x_window):
1712 * xrdb.c (x_get_customization_string):
1713 * xterm.c (xim_initialize):
1714 * w32fns.c (w32_window): Use xstrdup.
1715 (w32_display_monitor_attributes_list):
1716 * emacs.c (init_cmdargs):
1717 * keyboard.c (PUSH_C_STR):
1718 * nsfont.m (nsfont_open):
1719 * sysdep.c (system_process_attributes):
1720 * w32.c (system_process_attributes):
1721 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1722
55902276
EZ
17232013-08-09 Eli Zaretskii <eliz@gnu.org>
1724
1725 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1726 variables of these types so that GDB would know about them, as aid
1727 for debugging fatal exceptions. (Bug#15024) See also
1728 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1729 discussions.
1730
10bf7f5a
JD
17312013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1732
1733 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1734 larger than the NSWindow (Bug#14934).
1735
65620264
DA
17362013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1737
1738 Redesign redisplay interface to drop global variable updated_window.
1739 Always pass currently updated window as a parameter to update routines.
1740 * dispextern.h (updated_window): Remove declaration.
1741 (struct redisplay_interface): Pass window parameter to
1742 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1743 and after_update_window_hook.
1744 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1745 Adjust prototypes.
1746 * dispnew.c (updated_window): Remove.
1747 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1748 (update_window_line): Adjust to match redisplay interface changes.
1749 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1750 (ns_scroll_run, ns_after_update_window_line):
1751 * w32term.c (x_update_window_begin, x_update_window_end)
1752 (x_after_update_window_line, x_scroll_run):
1753 * xterm.c (x_update_window_begin, x_update_window_end)
1754 (x_after_update_window_line, x_scroll_run):
1755 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1756 Likewise. Adjust comments where appropriate.
1757 (x_cursor_to): Simplify because this is always called during window
1758 update (but install debugging check anyway).
1759 (expose_window): Check must_be_updated_p flag to see whether this
1760 function is called during window update.
1761
628fdc56
DA
17622013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1763
1764 Do not reset window modification event counters excessively.
1765 These leftovers and poor man's tricky methods to catch extra
1766 redisplay's attention are no longer needed.
1767 * frame.c (set_menu_bar_lines_1):
1768 * minibuf.c (read_minibuf_unwind):
1769 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1770 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1771 (window_scroll_line_based, Fset_window_configuration):
1772 * xdisp.c (redisplay_window): Do not reset last_modified and
1773 last_overlay_modified counters.
1774
8fd9c92e
JD
17752013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1776
1777 * xselect.c (x_send_client_event): Set send_event and serial, memset
1778 data.l as it might be bigger than data.b. Use 24 bit mask to
1779 XSendEvent (Bug#15034).
1780
0ee18172
EZ
17812013-08-07 Eli Zaretskii <eliz@gnu.org>
1782
1783 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1784 for TTY frames that are not the top frame on their console.
1785 (Bug#14616)
1786
16ddd1a6
MR
17872013-08-07 Martin Rudalics <rudalics@gmx.at>
1788
1789 * w32term.c (w32fullscreen_hook): Really maximize frame when
1790 asked for (Bug#14841).
1791
d2a95ffb
DA
17922013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1793
1794 Prefer selected_window to Fselected_window, likewise for frames.
1795 * buffer.c (Fbuffer_swap_text):
1796 * data.c (Fvariable_binding_locus):
1797 * window.c (run_window_configuration_change_hook): Adjust users.
1798 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1799 Use decode_live_frame.
1800
170da1ec
DA
18012013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1802
1803 Be more careful if selected window shows the buffer other than current,
1804 use window_outdated only if this is not so. This change should also
1805 address some weird issues discussed in Bug#13012.
1806 * window.h (window_outdated): New prototype.
1807 * window.c (window_outdated): Now here. Convert from static and
1808 always assume window's buffer.
1809 (Fwindow_end, Fwindow_line_height): Use it.
1810 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1811 and always assume window's buffer.
1812 (redisplay_window): Adjust user.
e5eefe9b 1813 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1814 check whether mode line should be updated only if selected window
1815 shows current buffer.
1816 (run_window_scroll_functions): Use eassert for debugging check.
1817 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1818
56b5d5b1
DA
18192013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1820
1821 * window.c (window_scroll, window_scroll_pixel_based)
1822 (window_scroll_line_based): Use bool for booleans.
1823
2878ba7e
PE
18242013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * process.c: Fix minor off-by-one issues in descriptor counts.
1827 This shouldn't fix any real bugs, but it cleans up the code a bit.
1828 (max_process_desc, max_input_desc): -1, not 0, means none.
1829 All uses changed.
1830 (delete_input_desc): New function.
1831 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1832 (deactivate_process): Scan backwards when recomuting max_process_desc;
1833 that should be faster.
1834 (init_process_emacs): Initialize max_input_desc.
1835
e30b79c1
DA
18362013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1837
1838 Use region cache to speedup bidi_find_paragraph_start.
1839 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1840 Rename cache_long_line_scans to cache_long_scans.
1841 * buffer.c (bset_cache_long_line_scans): Rename to
1842 bset_cache_long_scans.
1843 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1844 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1845 into account.
1846 (syms_of_buffer): Rename cache-long-line-scans to
1847 cache-long-scans. Adjust docstring.
1848 * search.c (newline_cache_on_off):
1849 * indent.c (width_run_cache_on_off): Adjust users.
1850 * bidi.c (bidi_paragraph_cache_on_off): New function.
1851 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1852 * insdel.c (prepare_to_modify_buffer):
1853 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1854
00012b86
DA
18552013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1856
1857 Invalidate region caches only if buffer text is going to be changed.
1858 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1859 (modify_text): ...new prototype.
1860 (prepare_to_modify_buffer_1): New prototype.
1861 * textprop.c (modify_region): Rename to...
1862 (modify_text_properties): ...new function.
1863 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1864 (Fremove_list_of_text_properties): Adjust users.
1865 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1866 (modify_text): ...new function.
1867 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1868 (prepare_to_modify_buffer_1): ...new function.
1869 * casefiddle.c (casify_region):
1870 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1871 (Ftranspose_regions): Use modify_text.
1872
dc6c0eda
SM
18732013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1874
1875 * lisp.mk (lisp): Add nadvice.elc.
1876
8f3a2c26
DA
18772013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1878
1879 New macro to iterate over live buffers similar to frames.
1880 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1881 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1882 Declare buffer-related variables here to offload lisp.h.
1883 * buffer.c (Vbuffer_alist): Adjust comment.
1884 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1885 (other_buffer_safely):
1886 * data.c (store_symval_forwarding):
1887 * dispnew.c (Fframe_or_buffer_changed_p):
1888 * fileio.c (Fdo_auto_save):
1889 * filelock.c (unlock_all_files):
1890 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1891
e0fdb694
PE
18922013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1893
1894 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1895 * callproc.c (create_temp_file):
1896 * filelock.c (create_lock_file):
1897 Assume mkostemp, since it's now provided by Gnulib.
1898
63f5c6c2
EZ
18992013-08-04 Eli Zaretskii <eliz@gnu.org>
1900
1901 * w32.c (mkostemp): New function.
1902 (mktemp): Remove, no longer used. Most of the code reused in
1903 mkostemp. (Bug#15015)
484ab239 1904 (mktemp): Don't undef.
63f5c6c2 1905
f0b79313
DA
19062013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1907
1908 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1909 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1910 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1911 (free_glyph_pool, check_glyph_memory): Likewise for
1912 all users. Adjust comments where appropriate.
1913
98f638d6
PE
19142013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1915
1916 * composite.h: Minor fixups.
1917 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1918 to fix a misspelling, and change it to an inline function while
1919 we're at it (it need not be a macro). All uses changed.
1920 (composition_method, composition_valid_p):
1921 Rewrite to avoid assignments in if-conditions.
1922
75c59fb3
DA
19232013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1924
1925 Do not use global Lisp_Object in composition macros.
1926 * composite.h (composition_temp): Remove declaration.
1927 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1928 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1929 (compose_region): Remove the leftover.
75c59fb3
DA
1930 * composite.c (composition_temp): Remove.
1931 (run_composition_function, update_compositions)
1932 (composition_compute_stop_pos, composition_adjust_point)
1933 (Ffind_composition_internal):
1934 * coding.c (handle_composition_annotation):
1935 * xdisp.c (handle_composition_prop, check_point_in_composition):
1936 Related users changed.
1937
a10c8269
DA
19382013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1939
1940 Drop FRAME_PTR typedef.
1941 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1942 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1943 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1944 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1945 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1946 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1947 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1948 All related users changed.
1949
a104f656
SM
19502013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1951
1952 * eval.c (default_toplevel_binding): New function.
1953 (Fdefvar): Use it.
1954 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1955 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1956 (syms_of_eval): Export them.
1957 * data.c (Fdefault_value): Micro cleanup.
1958 * term.c (init_tty): Use "false".
1959
4b5c9326
DA
19602013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1961
1962 Fix X GC leak in GTK and raw (no toolkit) X ports.
1963 * xterm.c (x_free_frame_resources): If white and black relief
1964 GCs are allocated, always free them here.
1965 * xfns.c (x_make_gc): Omit redundant initialization.
1966 * widget.c (create_frame_gcs): Remove the leftover.
1967 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1968 in x_free_frame_resources.
1969
b19aa636
JD
19702013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1971
1972 * nsterm.m (windowWillResize:toSize:): Only change title if
1973 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1974 modifying it.
1975 (viewDidEndLiveResize): New method.
1976
1977 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1978 inside NS_IMPL_COCOA.
1979
af1f7e06
DA
19802013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1981
1982 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1983 Do not check whether undo is enabled because record_insert and
1984 record_delete does that themselves.
1985
65b02bb9
DA
19862013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1987
1988 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1989 member which is not really used any more.
1990 (FRAME_XIC_BASE_FONTNAME): Remove.
1991 * xfns.c (xic_free_fontset): Adjust user.
1992 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1993 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1994 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1995 (xdialog_show): Use eassert for debugging check.
7ee0f047 1996 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1997
6318cde0
PE
19982013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 * fileio.c, fns.c (merge): Move extern decl from here ...
2001 * lisp.h (merge): ... to here.
2002
6c1a09ba
DA
20032013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2004
2005 Fix last font-related change.
2006 * w32font.h (w32font_list_internal, w32font_match_internal):
2007 Fix prototype.
2008 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2009 (uniscribe_list_family): Adjust to match font API change.
2010 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2011 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2012
f8c20208
DA
20132013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2014
2015 * frame.h (FRAME_MOUSE_UPDATE):
2016 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2017 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2018
fdb396e2
DA
20192013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2020
2021 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2022 * font.h (struct font_driver): Change list, match, and list_family
2023 functions to accept struct frame * as first arg.
068f9124
SM
2024 * font.c (font_score, font_compare, font_sort_entities):
2025 Remove prototypes.
fdb396e2
DA
2026 (font_sort_entities, font_list_entities, font_select_entity):
2027 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2028 match font API change.
2029 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2030 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2031 * ftxfont.c (ftxfont_list, ftxfont_match):
2032 * xftfont.c (xftfont_list, xftfont_match):
2033 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2034 * w32font.c (w32font_list, w32font_match, w32font_list):
2035 (w32font_list_internal, w32_font_match_internal): Likewise.
2036 * xfaces.c (Fx_family_fonts): Adjust user.
2037
52b8a085
DA
20382013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2039
2040 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2041 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2042 only if HAVE_X_WINDOWS is in use.
2043 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2044 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2045 * w32term.c (x_wm_set_icon_position): Likewise.
2046 * w32fns.c (x_icon): Adjust user.
2047
c791c18e
DA
20482013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2049
2050 * xterm.c (last_mouse_press_frame): Remove the
2051 leftover which is not really used any more.
2052 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2053 (x_flush): Call XFlush once per each X display, not frame.
2054 This is better because this code always unconditionally skips
2055 non-X frames in Vframe_list and issues the only XFlush if we
2056 have more than one X frame on the same X display.
2f935d86
DA
2057 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2058 Use bool for booleans.
2059 (x_draw_glyph_string_background, cvt_string_to_pixel):
2060 (cvt_pixel_dtor): Drop unnecessary prototypes.
2061 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2062
f435830e
DA
20632013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2064
2065 Drop unnecessary functions that deals with frame pixel size.
2066 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2067 (x_pixel_height): Drop prototypes.
2068 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2069 (x_pixel_height): Drop implementations.
2070 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2071 which should be always valid for window frame.
2072 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2073 * w32menu.c (Fx_popup_dialog):
2074 * xmenu.c (Fx_popup_dialog): Likewise for both.
2075
84231434
DA
20762013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2077
2078 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2079 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2080 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2081 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2082 and mention nil frame in docstring.
84231434 2083
959067a1
DA
20842013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2085
2086 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2087 (x_figure_window_size): Likewise. Adjust to return long.
2088 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2089 (toplevel): Move Qterminal_live_p to...
2090 * terminal.c (toplevel): ...here, make it static, and...
2091 (syms_of_terminal): ...DEFSYM here.
2092 * frame.h (Qterminal_live_p): Remove declaration.
2093 (make_frame, x_figure_window_size): Adjust prototype.
2094 * nsfns.m (Fx_create_frame): Use long for window flags.
2095
f4b169ce
PE
20962013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2099 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2100 Do not assume that emacs_close (INT_MAX) is a no-op.
2101
bee6a2c7
DA
21022013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2103
2104 * xfaces.c (make_face_cache): For struct face_cache, prefer
2105 xmalloc to xzalloc and so avoid redundant call to memset.
2106 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2107
d7e6881a
DA
21082013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2109
2110 * fringe.c (draw_window_fringes, update_window_fringes)
2111 (compute_fringe_widths):
2112 * w32term.c (x_draw_glyph_string):
2113 * window.c (candidate_window_p, Frecenter):
2114 * xfaces.c (realize_basic_faces, realize_default_face)
2115 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2116 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2117 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2118 * xmenu.c (Fx_menu_bar_open_internal):
2119 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2120 * xsettings.c (xft_settings_event):
2121 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2122 Use bool for booleans. Adjust style and comments where
2123 appropriate.
2124 * dispextern.h (draw_window_fringes, update_window_fringes)
2125 (compute_fringe_widths):
2126 * xterm.h (x_had_errors_p): Adjust prototype.
2127
ec3058af
DA
21282013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2129
2130 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2131 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2132
218e0637
DA
21332013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2134
2135 * fns.c (toplevel): Remove comment before Fsafe_length because
2136 it checks for QUIT.
2137
e560aba9
PE
21382013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2141
2e5ce5de
EZ
21422013-07-28 Eli Zaretskii <eliz@gnu.org>
2143
2144 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2145 frame which got the message is still alive, before dereferencing
2146 its pointer. (Bug#14970)
2147
2148 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2149 be a live window, before using it as such. (Bug#14970)
2150
e95da6d3
EZ
21512013-07-27 Eli Zaretskii <eliz@gnu.org>
2152
2153 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2154 w32_detect_focus_change instead of doing part of its job by hand.
2155 This fixes the problem whereby FOCUS_OUT events were not sent to
2156 the event queue.
2157
a8f93651
EZ
21582013-07-26 Eli Zaretskii <eliz@gnu.org>
2159
fec92060
EZ
2160 * process.c (Fprocess_list): Doc fix.
2161
a8f93651
EZ
2162 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2163 being re-exposed only if it didn't ask to become visible.
2164 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2165 was previously iconified. (Bug#14841)
2166 (x_iconify_frame): Mark the frame iconified.
2167
d5a7a9d9
PE
21682013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 Fix minor problems found by static checking.
2171 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2172 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2173
56ea7291
SM
21742013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2175
2176 * eval.c (set_specpdl_old_value): New function.
2177 (unbind_to): Minor simplification.
2178 (get_backtrace_frame): New function.
2179 (Fbacktrace_frame): Use it. Add `base' argument.
2180 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2181 (syms_of_eval): Export backtrace-eval.
2182 * xterm.c (x_focus_changed): Simplify.
2183
9d611ffe
PE
21842013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2187
999c74e3
EZ
21882013-07-24 Eli Zaretskii <eliz@gnu.org>
2189
2190 * xdisp.c (redisplay_window): Instead of moving point out of
2191 scroll margin, reject the force_start method, and try scrolling
2192 instead. (Bug#14780)
2193
198fa217
KB
21942013-07-24 Ken Brown <kbrown@cornell.edu>
2195
2196 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2197 (Bug#14944).
2198
53840e55
PE
21992013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 * eval.c (Fprogn): Do not check that BODY is a proper list.
2202 This undoes the previous change. The check slows down the
2203 interpreter, and is not needed to prevent a crash. See
2204 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2205
60967f56
GM
22062013-07-23 Glenn Morris <rgm@gnu.org>
2207
2208 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2209
9ca960e2
PE
22102013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2211
a29c3e6d
PE
2212 Port to GNU/Linux systems with tinfo but not ncurses.
2213 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2214 to decide whether ncurses is being used. Without this change,
2215 GCC complains about tgetent not being declared, on a system
2216 that has tinfo installed but ncurses not installed.
2217
f274311c
PE
2218 * eval.c (Fprogn): Check that BODY is a proper list.
2219
16b0520a
PE
2220 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2221 * data.c (Fsetq_default):
2222 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2223 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2224 (Fcondition_case):
2225 Tune by taking advantage of the fact that ARGS is always a list
2226 when a function is declared to have UNEVALLED args.
2227
9ca960e2
PE
2228 * emacsgtkfixed.c: Port to GCC 4.6.
2229 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2230
afacaa1b
JB
22312013-07-23 Juanma Barranquero <lekktu@gmail.com>
2232
2233 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2234 here to silence compiler warnings.
2235
368a85a4
PE
22362013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2237
2238 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2239 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2240 from messing up Emacs's 'struct frame' (Bug#14923).
2241
f4e891b5
PE
22422013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2243
2244 * alloc.c (make_save_ptr_ptr): Define this function.
2245 It was inadvertently omitted. It's needed only if
2246 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2247
96c8b65e
JD
22482013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2249
2250 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2251 frame have focus (Bug#14895).
2252
ee010797
PE
22532013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 Avoid vfork-related deadlock more cleanly.
2256 * callproc.c (child_setup): When the child's exec fails, output
2257 the program name, as that's more useful. Use O_NONBLOCK to avoid
2258 deadlock.
2259 * process.c (create_process_1): Remove; no longer needed.
2260 (create_process): Remove timer hack; no longer needed, now that
2261 the child avoids deadlock.
2262
f0398ec1 22632013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2264
2265 * image.c (Fimage_flush): Fix doc typo.
2266
b2a069c2
PE
22672013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2268
6496aec9
PE
2269 Fix array bounds violation when pty allocation fails.
2270 * process.c (PTY_NAME_SIZE): New constant.
2271 (pty_name): Remove static variable; it's now auto.
2272 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2273 Take pty_name as an arg rather than using a static variable.
2274 All callers changed.
2275 (create_process): Recover pty_flag from process, not from volatile local.
2276 (create_pty): Stay inside array even when pty allocation fails.
2277 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2278
b2a069c2
PE
2279 * lread.c (Fload): Avoid initialization only when lint checking.
2280 Mention that it's needed only for older GCCs.
2281
99107004
KH
22822013-07-20 Kenichi Handa <handa@gnu.org>
2283
2284 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2285 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2286
6b1b199d
AS
22872013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2288
2289 * lread.c (Fload): Avoid uninitialized warning.
2290
4195afc3
PE
22912013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2292
3f5bef16
PE
2293 Fix some minor file descriptor leaks and related glitches.
2294 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2295 (create_lock_file): Use write, not emacs_write.
2296 * image.c (slurp_file, png_load_body):
2297 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2298 (server_accept_connection):
2299 Don't leak an fd on memory allocation failure.
2300 * image.c (slurp_file): Add a cheap heuristic for growing files.
2301 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2302 as that's what the other routines do. Maybe input need not be
2303 blocked at all, but it's better to be consistent.
2304 Avoid undefined behavior when strlen is zero.
2305
4195afc3
PE
2306 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2307 (NSTATICS): Now a constant; doesn't need to be a macro.
2308
a1aeeffe
RS
23092013-07-19 Richard Stallman <rms@gnu.org>
2310
2311 * coding.c (decode_coding_utf_8): Add simple loop for fast
2312 processing of ASCII characters.
2313
63b34baa
PE
23142013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2317
621dd9ac
EZ
23182013-07-19 Eli Zaretskii <eliz@gnu.org>
2319
2320 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2321 unportable 'struct x_display_info'.
2322 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2323 is a portable type.
2324
1396ac86
PE
23252013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2326
ab9980cd
PE
2327 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2328 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2329 or fscanf fails.
2330 (system_process_attributes): Prefer plain char to unsigned char
2331 when either will do. Clean up properly if interrupted or if
068f9124
SM
2332 memory allocations fail. Don't assume sscanf succeeds.
2333 Remove no-longer-needed workaround to stop GCC from whining.
2334 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2335 bit more carefully.
2336
1396ac86
PE
2337 Fix obscure porting bug with varargs functions.
2338 The code assumed that int is treated like ptrdiff_t in a vararg
2339 function, which is not a portable assumption. There was a similar
2340 -- though these days less likely -- porting problem with various
2341 assumptions that pointers of different types all smell the same as
2342 far as vararg functions is conserved. To make this problem less
2343 likely in the future, redo the API to use varargs functions.
2344 * alloc.c (make_save_value): Remove this vararg function.
2345 All uses changed to ...
2346 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2347 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2348 New functions.
2349 (make_save_ptr): Rename from make_save_pointer, for consistency with
2350 the above. Define only on platforms that need it. All uses changed.
2351
4d19d194
PE
23522013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2353
2354 * keyboard.c: Try to fix typos in previous change.
2355 (DISPLAY_LIST_INFO): New macro.
2356 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2357 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2358
945c5bb1
JB
23592013-07-18 Juanma Barranquero <lekktu@gmail.com>
2360
2361 * keyboard.c (kbd_buffer_get_event):
2362 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2363 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2364
f4b1eb36
PE
23652013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2366
5e679a2c
PE
2367 * filelock.c: Fix unlikely file descriptor leaks.
2368 (get_boot_time_1): Rework to avoid using emacs_open.
2369 This doesn't actually fix a leak, but is better anyway.
2370 (read_lock_data): Use read, not emacs_read.
2371
a8cd4836
PE
2372 * doc.c: Fix minor memory and file descriptor leaks.
2373 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2374 (get_doc_string, Fsnarf_documentation):
2375 Fix file descriptor leak on error.
2376
ef30e638
PE
2377 * term.c: Fix minor fdopen-related file descriptor leaks.
2378 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2379 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2380
f4b1eb36
PE
2381 * charset.c: Fix file descriptor leaks and errno issues.
2382 Include <errno.h>.
2383 (load_charset_map_from_file): Don't leak file descriptor on error.
2384 Use plain record_xmalloc since the allocation is larger than
2385 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2386 of entries.
2387 * eval.c (record_unwind_protect_nothing):
2388 * fileio.c (fclose_unwind):
2389 New functions.
2390 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2391 The replacement doesn't block input, but that no longer seems
2392 necessary.
2393
b648c163
PE
23942013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2395
a0931322
PE
2396 * lread.c: Fix file descriptor leaks and errno issues.
2397 (Fload): Close some races that leaked fds or streams when 'load'
2398 was interrupted.
2399 (Fload, openp): Report error number of last nontrivial failure to open.
2400 ENOENT counts as trivial.
2401 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2402 New functions.
2403 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2404 now that the function is always called with a nonnegative arg.
2405 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2406 All uses replaced with ...
2407 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2408
b648c163
PE
2409 A few more minor file errno-reporting bugs.
2410 * callproc.c (Fcall_process):
2411 * doc.c (Fsnarf_documentation):
2412 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2413 * process.c (set_socket_option):
2414 Don't let a constructor trash errno.
2415 * doc.c: Include <errno.h>.
2416
b1dc4084
JB
24172013-07-16 Juanma Barranquero <lekktu@gmail.com>
2418
2419 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2420
c43843aa
PE
24212013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2422
50a30cce
PE
2423 Fix w32 bug with call-process-region (Bug#14885).
2424 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2425 to Fcall_process when the input is empty. This simplifies the
2426 code a bit. It makes no difference on POSIXish platforms but
2427 apparently it fixes a bug on w32.
2428
44e18199 2429 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2430 * fileio.c (close_file_unwind): Don't close if FD is negative;
2431 this can happen when unwinding a zapped file descriptor.
2432 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2433 in case Emacs runs out of memory between the two unwind-protects.
2434 Don't trash errno when closing FD.
2435 Zap the FD in the specpdl when closing it, instead of deferring
2436 the removal of the unwind-protect; this fixes a bug where a child
2437 function unwinds the stack past us.
2438
27e498e6
PE
2439 New unwind-protect flavors to better type-check C callbacks.
2440 This also lessens the need to write wrappers for callbacks,
2441 and the need for make_save_pointer.
2442 * alloca.c (free_save_value):
2443 * atimer.c (run_all_atimers):
2444 Now extern.
2445 * alloc.c (safe_alloca_unwind):
2446 * atimer.c (unwind_stop_other_atimers):
2447 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2448 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2449 * minibuf.c (choose_minibuf_frame_1):
2450 * process.c (make_serial_process_unwind):
2451 * xdisp.h (pop_message_unwind):
2452 * xselect.c (queue_selection_requests_unwind):
2453 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2454 * alloca.c (record_xmalloc):
2455 Prefer record_unwind_protect_ptr to record_unwind_protect with
2456 make_save_pointer.
2457 * alloca.c (Fgarbage_collect):
2458 Prefer record_unwind_protect_void to passing a dummy.
2459 * buffer.c (restore_buffer):
2460 * window.c (restore_window_configuration):
2461 * xfns.c, w32fns.c (do_unwind_create_frame)
2462 New wrapper. All record-unwind uses of wrappee changed.
2463 * buffer.c (set_buffer_if_live):
2464 * callproc.c (call_process_cleanup, delete_temp_file):
2465 * coding.c (code_conversion_restore):
2466 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2467 * editfns.c (save_excursion_restore)
2468 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2469 (save_restriction_restore):
2470 * eval.c (restore_stack_limits, un_autoload):
2471 * fns.c (require_unwind):
2472 * keyboard.c (recursive_edit_unwind, tracking_off):
2473 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2474 * macros.c (pop_kbd_macro, restore_menu_items):
2475 * nsfns.m (unwind_create_frame):
2476 * print.c (print_unwind):
2477 * process.c (start_process_unwind):
2478 * search.c (unwind_set_match_data):
2479 * window.c (select_window_norecord, select_frame_norecord):
2480 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2481 (fast_set_selected_frame):
2482 * xfns.c, w32fns.c (unwind_create_tip_frame):
2483 Return void, not a dummy Lisp_Object. All uses changed.
2484 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2485 * callproc.c (call_process_kill):
2486 * fileio.c (restore_point_unwind, decide_coding_unwind)
2487 (build_annotations_unwind):
2488 * insdel.c (Fcombine_after_change_execute_1):
2489 * keyboard.c (read_char_help_form_unwind):
2490 * menu.c (unuse_menu_items):
2491 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2492 * sound.c (sound_cleanup):
2493 * xdisp.c (unwind_redisplay):
2494 * xfns.c (clean_up_dialog):
2495 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2496 Accept no args and return void, instead of accepting and returning
2497 a dummy Lisp_Object. All uses changed.
2498 * cygw32.c (fchdir_unwind):
2499 * fileio.c (close_file_unwind):
2500 * keyboard.c (restore_kboard_configuration):
2501 * lread.c (readevalllop_1):
2502 * process.c (wait_reading_process_output_unwind):
2503 Accept int and return void, rather than accepting an Emacs integer
2504 and returning a dummy object. In some cases this fixes an
2505 unlikely bug when the corresponding int is outside Emacs integer
2506 range. All uses changed.
2507 * dired.c (directory_files_internal_unwind):
2508 * fileio.c (do_auto_save_unwind):
2509 * gtkutil.c (pop_down_dialog):
2510 * insdel.c (reset_var_on_error):
2511 * lread.c (load_unwind):
2512 * xfns.c (clean_up_file_dialog):
2513 * xmenu.c, nsmenu.m (pop_down_menu):
2514 * xmenu.c (cleanup_widget_value_tree):
2515 * xselect.c (wait_for_property_change_unwind):
2516 Accept pointer and return void, rather than accepting an Emacs
2517 save value encapsulating the pointer and returning a dummy object.
2518 All uses changed.
2519 * editfns.c (Fformat): Update the saved pointer directly via
2520 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2521 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2522 (unwind_body): New function.
2523 (record_unwind_protect): First arg is now a function returning void,
2524 not a dummy Lisp_Object.
2525 (record_unwind_protect_ptr, record_unwind_protect_int)
2526 (record_unwind_protect_void): New functions.
2527 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2528 * fileio.c (struct auto_save_unwind): New type.
2529 (do_auto_save_unwind): Use it.
2530 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2531 * insdel.c (struct rvoe_arg): New type.
2532 (reset_var_on_error): Use it.
2533 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2534 New constants.
2535 (specbinding_func): Remove; there are now several such functions.
2536 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2537 (set_unwind_protect_ptr): New function.
2538 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2539
4e604a5d
PE
2540 Be simpler and more consistent about reporting I/O errors.
2541 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2542 Say "Read error" and "Write error", rather than "I/O error", or
2543 "IO error reading", or "IO error writing", when a read or write
2544 error occurs.
2545 * process.c (Fmake_network_process, wait_reading_process_output)
2546 (send_process, Fprocess_send_eof, wait_reading_process_output):
2547 Capitalize diagnostics consistently. Put "failed foo" at the
2548 start of the diagnostic, so that we don't capitalize the
2549 function name "foo". Consistently say "failed" for such
2550 diagnostics.
2551 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2552 All callers changed. This is so it can use report_file_error.
2553 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2554 diagnostics consistently as above.
2555
a9757f6a
PE
2556 * fileio.c (report_file_errno): Fix errno reporting bug.
2557 If the file name is neither null nor a pair, package it up as a
2558 singleton list. All callers changed, both to this function and to
2559 report_file_error. This fixes a bug where the memory allocator
2560 invoked by list1 set errno so that the immediately following
2561 report_file_error reported the wrong errno value.
2562
c43843aa
PE
2563 Fix minor problems found by --enable-gcc-warnings.
2564 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2565 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2566
18c26d81
JD
25672013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2568
2569 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2570 Set event->arg to Qt if switch-event shall be generated.
2571 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2572
2573 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2574
2575 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2576 FOCUS_OUT_EVENT.
2577
2578 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2579 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2580 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2581 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2582 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2583 and there is a focused frame.
2584 (head_table): Add focus-in and focus-out.
2585 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2586 bind to handle-focus-in/out.
2587
2588 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2589 (Fhandle_switch_frame): Call Fhandle_focus_in.
2590 (syms_of_frame): defsubr handle-focus-in/out.
2591
6c6f1994
PE
25922013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2593
c7ddc792
PE
2594 Fix porting bug to older POSIXish platforms (Bug#14862).
2595 * sysdep.c (emacs_pipe): New function, that implements
2596 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2597 This should port better to CentOS 5 and to Mac OS X 10.6.
2598 All calls to pipe2 changed.
2599
6c6f1994
PE
2600 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2601 This makes the code easier to read and the executable a bit smaller.
2602 Do not replace all calls to Fcons that happen to create lists,
2603 just calls that are intended to create lists. For example, when
2604 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2605 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2606 Similarly for list2 through list5.
2607 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2608 * bytecode.c (exec_byte_code):
2609 * callint.c (quotify_arg, Fcall_interactively):
2610 * callproc.c (Fcall_process, create_temp_file):
2611 * charset.c (load_charset_map_from_file)
2612 (Fdefine_charset_internal, init_charset):
2613 * coding.c (get_translation_table, detect_coding_system)
2614 (Fcheck_coding_systems_region)
2615 (Fset_terminal_coding_system_internal)
2616 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2617 * composite.c (update_compositions, Ffind_composition_internal):
2618 * dired.c (directory_files_internal, file_name_completion)
2619 (Fsystem_users):
2620 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2621 * doc.c (Fsnarf_documentation):
2622 * editfns.c (Fmessage_box):
2623 * emacs.c (main):
2624 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2625 (Feval, eval_sub, Ffuncall, apply_lambda):
2626 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2627 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2628 (Fset_file_times, Finsert_file_contents)
2629 (Fchoose_write_coding_system, Fwrite_region):
2630 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2631 * font.c (font_registry_charsets, font_parse_fcname)
2632 (font_prepare_cache, font_update_drivers, Flist_fonts):
2633 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2634 * frame.c (make_frame, Fmake_terminal_frame)
2635 (x_set_frame_parameters, x_report_frame_params)
2636 (x_default_parameter, Fx_parse_geometry):
2637 * ftfont.c (syms_of_ftfont):
2638 * image.c (gif_load):
2639 * keyboard.c (command_loop_1):
2640 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2641 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2642 (Fminor_mode_key_binding, accessible_keymaps_1)
2643 (Faccessible_keymaps, Fwhere_is_internal):
2644 * lread.c (read_emacs_mule_char):
2645 * menu.c (find_and_return_menu_selection):
2646 * minibuf.c (get_minibuffer):
2647 * nsfns.m (Fns_perform_service):
2648 * nsfont.m (ns_script_to_charset):
2649 * nsmenu.m (ns_popup_dialog):
2650 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2651 (Fx_own_selection_internal):
2652 * nsterm.m (append2):
2653 * print.c (Fredirect_debugging_output)
2654 (print_prune_string_charset):
2655 * process.c (Fdelete_process, Fprocess_contact)
2656 (Fformat_network_address, set_socket_option)
2657 (read_and_dispose_of_process_output, write_queue_push)
2658 (send_process, exec_sentinel):
2659 * sound.c (Fplay_sound_internal):
2660 * textprop.c (validate_plist, add_properties)
2661 (Fput_text_property, Fadd_face_text_property)
2662 (copy_text_properties, text_property_list, syms_of_textprop):
2663 * unexaix.c (report_error):
2664 * unexcoff.c (report_error):
2665 * unexsol.c (unexec):
2666 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2667 (Fformat_mode_line, syms_of_xdisp):
2668 * xfaces.c (set_font_frame_param)
2669 (Finternal_lisp_face_attribute_values)
2670 (Finternal_merge_in_global_face, syms_of_xfaces):
2671 * xfns.c (x_default_scroll_bar_color_parameter)
2672 (x_default_font_parameter, x_create_tip_frame):
2673 * xfont.c (xfont_supported_scripts):
2674 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2675 (menu_help_callback, xmenu_show):
2676 * xml.c (make_dom):
2677 * xterm.c (set_wm_state):
2678 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2679 and similarly for list2 through list5.
2680
bafe80ce
PE
26812013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2682
2683 * callproc.c (Fcall_process_region): Fix minor race and tune.
2684 (create_temp_file): New function, with the temp-file-creation part
2685 of the old Fcall_process_region. Use Fcopy_sequence to create the
2686 temp file name, rather than alloca + build_string, for simplicity.
2687 Don't bother to block input around the temp file creation;
068f9124
SM
2688 shouldn't be needed. Simplify use of mktemp.
2689 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2690 this closes an unlikely race where the temp file was not removed.
2691 Use memcpy rather than an open-coded loop.
2692 (Fcall_process_region): Use the new function. If the input is
2693 empty, redirect from /dev/null rather than from a newly created
2694 empty temp file; this avoids unnecessary file system traffic.
2695
4700b5a5
PE
26962013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2697
5c97beae
PE
2698 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2699 Simplify by making this case like the other two. This is a bit
2700 slower on obsolete hosts, but the extra complexity isn't worth it.
2701
4700b5a5
PE
2702 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2703 * process.c (create_process) [!DOS_NT]:
2704 Remove now-unnecessary calls to emacs_close.
2705
f9a74c4c
EZ
27062013-07-13 Eli Zaretskii <eliz@gnu.org>
2707
922ae7ee
EZ
2708 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2709 returning early. (Bug#14850)
2710
f9a74c4c
EZ
2711 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2712 and inhibit-iso-escape-detection attributes of 'undecided'.
2713 (Bug#14822)
2714
5e301d76
PE
27152013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2716
69e0e5ee
PE
2717 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2718 Reported by Herbert J. Skuhra in
2719 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2720
5e301d76
PE
2721 Don't lose top specpdl entry when memory is exhausted.
2722 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2723 specpdl overflow here, to simplify callers; all callers changed.
2724 Always reserve an unused entry at the stack top; this avoids
2725 losing the top entry's information when memory is exhausted.
2726
7e649856
PE
27272013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2728
a773ed9a
PE
2729 Clean up errno reporting and fix some errno-reporting bugs.
2730 * callproc.c (Fcall_process):
2731 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2732 * process.c (create_process, Fmake_network_process):
2733 * unexaix.c (report_error):
2734 * unexcoff.c (report_error):
2735 Be more careful about reporting the errno of failed operations.
2736 The code previously reported the wrong errno sometimes.
2737 Also, prefer report_file_errno to setting errno + report_file_error.
2738 (Fcall_process): Look at openp return value rather than at path,
2739 as that's a bit faster and clearer when there's a numeric predicate.
2740 * fileio.c (report_file_errno): New function, with most of the
2741 old contents of report_file_error.
2742 (report_file_error): Use it.
2743 (Ffile_exists_p, Ffile_accessible_directory_p):
2744 Set errno to 0 when it is junk.
2745 * fileio.c (Faccess_file):
2746 * image.c (x_create_bitmap_from_file):
2747 Use faccessat rather than opening the file, to avoid the hassle of
2748 having a file descriptor open.
2749 * lisp.h (report_file_errno): New decl.
2750 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2751
7e649856
PE
2752 Minor EBADF fixes.
2753 * process.c (create_process, wait_reading_process_output) [AIX]:
2754 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2755 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2756 a multithreaded environment anyway).
2757 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2758
f6774c1a
AS
27592013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2760
2761 * image.c (x_find_image_file): Don't close a remote file handle.
2762
bacba3c2
PE
27632013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2764
2765 Fix races with threads and file descriptors.
2766 * callproc.c (Fcall_process_region):
2767 * dired.c (open_directory):
2768 * emacs.c (main, Fdaemon_initialized):
2769 * image.c (x_find_image_file):
2770 * inotify.c (Finotify_rm_watch):
2771 * lread.c (Flocate_file_internal):
2772 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2773 * term.c (term_mouse_moveto, init_tty):
2774 * termcap.c (tgetent):
2775 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2776 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2777 * unexhp9k800.c, unexmacosx.c (unexec):
2778 * callproc.c (Fcall_process_region):
2779 Use emacs_close, not close.
2780 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2781 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2782 and posix_close function on current platforms (which all lack them).
2783 (emacs_close): Use it. This should fix the races on GNU/Linux and
2784 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2785 and it should avoid closing random victim file descriptors on
2786 other platforms.
2787
653d4f43
PE
27882013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2789
c8536ec4
PE
2790 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2791 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2792 Touch up doc a bit.
2793
9c203066
PE
2794 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2795 This is for .gdbinit xbacktrace.
2796
653d4f43
PE
2797 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2798 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2799 (emacs_set_tty): Now static.
2800 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2801 * term.c (tty_capable_p, tty_default_color_capabilities)
2802 (get_tty_terminal, term_mouse_movement)
2803 (handle_one_term_event, init_tty, maybe_fatal):
2804 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2805 (tgetent, scan_file, name_match, compare_contin):
2806 * terminal.c (get_terminal):
2807 Use bool for boolean.
2808 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2809 Prefer char to unsigned char if either will do.
2810 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2811 (tty_write_glyphs): Prefer int to unsigned.
2812 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2813 All callers changed.
2814 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2815
45b683a1
PE
28162013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2817
29abe551
PE
2818 Port to C89.
2819 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2820 (B__dummy__): New dummy symbol, to pacify C89.
2821 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2822 they can't grok varargs macros.
2823 * dispnew.c (add_window_display_history)
2824 (add_frame_display_history):
2825 * print.c (print_object):
2826 * xdisp.c (debug_method_add):
2827 Use %p printf format only for void pointers.
2828 * emacs.c (usage_message): New constant, replacing ...
2829 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2830 (main): Adjust to usage reorg.
2831 * fns.c (syms_of_fns):
2832 * profiler.c (syms_of_profiler):
2833 Don't use non-constant struct initializers.
2834 * gnutls.h (gnutls_initstage_t):
2835 * lisp.h (enum Lisp_Fwd_Type):
2836 * lread.c (lisp_file_lexically_bound_p):
2837 * xsettings.c (anonymous enum):
2838 Remove trailing comma.
2839 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2840 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2841 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2842 (DEFUN): Use it.
2843 * regex.c (const_re_char): New type, to pacify strict C89.
2844 All uses of 'const re_char' replaced to use it.
2845 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2846 with glibc when strict C89. This change is imported from gnulib.
2847 All uses changed.
2848 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2849 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2850 Omit GNU_LINUX implementation, since it requires long long.
2851 * xterm.c (x_draw_underwave):
2852 Do not assume the traditional order of struct's members.
2853 (x_term_init): Rewrite to avoid the need for non-constant structure
2854 initializers.
2855
45b683a1 2856 Syntax cleanup, mostly replacing macros with functions.
763a086d 2857 This removes the need for the syntax_temp hack.
45b683a1
PE
2858 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2859 * syntax.c (SYNTAX_INLINE): New macro.
2860 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2861 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2862 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2863 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2864 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2865 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2866 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2867 Now constants, not macros.
2868 (syntax_temp) [!__GNUC__]: Remove.
2869 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2870 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2871 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2872 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2873 Move here from syntax.h; now functions, not macros. Except for the
2874 last function, these are static since only syntax.c uses them.
2875 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2876 All uses changed. Now a function, not a macro; use this fact
2877 to simplify the code.
2878 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2879 compiler bugs; no longer relevant.
2880 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2881 (SYNTAX_INLINE): New macro.
2882 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2883 for the new functions. Use bool for boolean member.
2884 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2885 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2886 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2887 (SETUP_BUFFER_SYNTAX_TABLE):
2888 Now extern inline functions, not macros.
2889 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2890 Remove; all uses replaced by implementation.
2891 (syntax_temp) [!__GNUC__]: Remove decl.
2892 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2893
29be4a50
JD
28942013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2895
2896 * emacs.c (main): Fix syntax error.
2897
954b166e
PE
28982013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2899
2900 Timestamp fixes for undo (Bug#14824).
2901 * atimer.c (schedule_atimer):
2902 * fileio.c (Ffile_newer_than_file_p):
2903 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2904 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2905 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2906 (syms_of_fileio): Remove Sclear_visited_file_name.
2907 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2908 file doesn't exist; this avoids an ambiguity with negative timestamps.
2909 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2910 * systime.h (make_emacs_time, invalid_emacs_time):
2911 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2912 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2913 * undo.c (record_first_change): Push (visited-file-modtime) onto
2914 undo list rather than reimplementing it by hand, incorrectly.
2915
d74647c3
KB
29162013-07-09 Ken Brown <kbrown@cornell.edu>
2917
2918 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2919
3c51b96b
JB
29202013-07-09 Juanma Barranquero <lekktu@gmail.com>
2921
2922 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2923
4ebbdd67
PE
29242013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 Handle errno and exit status a bit more carefully.
2927 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2928 number into an exit status. Instead, use EXIT_CANCELED.
2929 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2930 * callproc.c (relocate_fd):
2931 * emacs.c (close_output_streams, main):
2932 * process.c (create_process):
2933 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2934 Use emacs_perror for simplicity.
2935 * callproc.c (relocate_fd, main):
2936 * sysdep.c (sys_subshell):
2937 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2938 (shut_down_emacs): Use emacs_write, not write.
2939 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2940 * fileio.c (Fcopy_file, e_write):
2941 * nsterm.m (ns_select):
2942 * process.c (send_process):
2943 * sound.c (vox_write):
2944 Use emacs_write_sig, not emacs_write.
2945 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2946 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2947 New constants.
2948 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2949 of write.
2950 (emacs_full_write): New function.
2951 (emacs_write): Rewrite to use it.
2952 (emacswrite_sig, emacs_perror): New functions.
2953 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2954
44e18199 29552013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2956
2957 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2958 on NS even if it is present. Pixmap on NS is a void*.
2959
9caab067
PE
29602013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2961
2962 Port to Ubuntu 10 (Bug#14803).
2963 Problem reported by T.V. Raman.
2964 * process.c (close_on_exec, accept4, process_socket):
2965 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2966
1d442672
EZ
29672013-07-07 Eli Zaretskii <eliz@gnu.org>
2968
2969 * w32.c (sys_dup): Declare prototype.
2970
2971 * filelock.c:
2972 * emacs.c:
2973 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2974
067428c1
PE
29752013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 Make file descriptors close-on-exec when possible (Bug#14803).
2978 This simplifies Emacs a bit, since it no longer needs to worry
2979 about closing file descriptors by hand in some cases.
2980 It also fixes some unlikely races. Not all such races, as
2981 libraries often open files internally without setting
2982 close-on-exec, but it's an improvement.
2983 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2984 * callproc.c (Fcall_process) [!MSDOS]:
2985 * emacs.c (main) [!DOS_NT]:
2986 * nsterm.m (ns_term_init):
2987 * process.c (create_process):
2988 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2989 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2990 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2991 Prefer mkostemp with O_CLOEXEC to mkstemp.
2992 * callproc.c (relocate_fd) [!WINDOWSNT]:
2993 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2994 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2995 now using pipe2.
2996 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2997 Make the resulting file descriptor close-on-exec.
2998 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2999 * lread.c (load_descriptor_list, load_descriptor_unwind):
3000 Remove; no longer needed. All uses removed.
3001 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3002 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3003 New functions.
3004 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3005 (Fmake_network_process, Fnetwork_interface_list):
3006 (Fnetwork_interface_info, server_accept_connection):
3007 Make newly-created socket close-on-exec.
3008 * sysdep.c (emacs_open, emacs_fopen):
3009 Make new-created descriptor close-on-exec.
3010 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3011 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3012
0da857dd
JD
30132013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3014
3015 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3016 for NS_IMPL_GNUSTEP.
3017
5f86adcd
PE
30182013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 Fix openp errno handling.
3021 * callproc.c (Fcall_process): Preserve openp errno around close.
3022 * lread.c (openp): Set errno when returning -1, as some callers
3023 expect this.
3024
1afb1d07
JD
30252013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3026
3027 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3028
3029 * nsterm.h (NSSavePanel): Update comment.
3030 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3031 (ns_run_file_dialog): Declare.
3032
3033 * nsfns.m: Remove panelOK.
3034 (ns_fd_data): New.
3035 (ns_run_file_dialog): New function.
3036 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3037 event loop, so file dialog is popped up by ns_run_file_dialog, called
3038 by sendEvent (Bug#14578).
3039 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3040
3323c263
EZ
30412013-07-06 Eli Zaretskii <eliz@gnu.org>
3042
fdda0220
EZ
3043 * xdisp.c (default_line_pixel_height): New function.
3044 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3045 (try_cursor_movement, redisplay_window, try_window)
3046 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3047
068f9124
SM
3048 * window.c (window_scroll_pixel_based):
3049 use default_line_pixel_height.
fdda0220
EZ
3050
3051 * dispextern.h (default_line_pixel_height): Add prototype.
3052
3053 * frame.c (x_set_line_spacing): Accept a float value for
3054 line-spacing parameter, per the documentation.
3055
3323c263
EZ
3056 * data.c (Fmultibyte_string_p): Doc fix.
3057
47ba6d43
PE
30582013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3059
406af475
PE
3060 Use emacs_open more consistently when opening files.
3061 This handles EINTR more consistently now, and makes it easier
3062 to introduce other uniform changes to file descriptor handling.
3063 * src/systdio.h: New file.
3064 * src/buffer.c (mmap_init):
3065 * cygw32.c (chdir_to_default_directory):
3066 * dispnew.c (Fopen_termscript):
3067 * emacs.c (Fdaemon_initialized):
3068 * fileio.c (Fdo_auto_save):
3069 * image.c (slurp_file, png_load_body, jpeg_load_body):
3070 * keyboard.c (Fopen_dribble_file):
3071 * lread.c (Fload):
3072 * print.c (Fredirect_debugging_output):
3073 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3074 * termcap.c (tgetent):
3075 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3076 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3077 * w32term.c (w32_initialize) [CYGWIN]:
3078 * xfaces.c (Fx_load_color_file):
3079 Use emacs_open instead of plain open, and emacs_fopen instead of
3080 plain fopen.
3081 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3082 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3083 * callproc.c (default_output_mode): New constant.
3084 (Fcall_process): Use it to call emacs_open instead of plain creat.
3085 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3086 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3087 (emacs_fopen): New function.
3088 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3089 Include <lisp.h>, for emacs_open.
3090 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3091
47ba6d43
PE
3092 Remove duplicate #include directives.
3093 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3094 * xfaces.c:
3095 Don't include stdio.h twice.
3096 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3097 Don't include sys/types.h or stdio.h twice.
3098 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3099 * lread.c: Don't include coding.h twice.
3100 * nsfont.m: Don't include frame.h twice.
3101 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3102 * ralloc.c: Don't include <unistd.h> twice.
3103 * xdisp.c: Don't include font.h twice.
3104 * xterm.c: Don't include fontset.h twice.
3105 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3106
b9ed53d5
PE
31072013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 Scale ImageMagick images more carefully.
3110 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3111 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3112 Be more careful about avoiding undefined behavior after
3113 integer overflow and division by zero.
3114
cf13177e
YM
31152013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3116
3117 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3118 (syms_of_w32fns): DEFSYM them.
3119 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3120 (CCHDEVICENAME): Define macros if not defined.
3121 (struct MONITOR_INFO_EX): New struct.
3122 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3123 (enum_display_monitors_fn): New variable.
3124 (globals_of_w32fns): Initialize it.
3125 (Fx_display_pixel_width, Fx_display_pixel_height)
3126 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3127 multi-monitor setups in docstrings.
3128 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3129 screen size by primary monitor's millimeter per pixel.
3130 (w32_monitor_enum, w32_display_monitor_attributes_list)
3131 (w32_display_monitor_attributes_list_fallback)
3132 (Fw32_display_monitor_attributes_list): New functions.
3133 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3134
3135 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3136 if not defined.
3137 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3138
86dfb7a8
MA
31392013-07-04 Michael Albinus <michael.albinus@gmx.de>
3140
3141 * fileio.c (Qfile_notify_error): New error symbol.
3142
3143 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3144 * inotify.c (inotify_callback, symbol_to_inotifymask)
3145 (Finotify_add_watch, Finotify_rm_watch): Use it.
3146 (inotifyevent_to_event): Exchange order of cookie and file name.
3147 (Finotify_add_watch): Adapt docstring.
3148
3149 * lisp.h (Qfile_notify_error): Declare.
3150
2c1c974b
PE
31512013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3154 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3155 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3156 which did not work (see <http://bugs.gnu.org/14569#307>).
3157 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3158 && (!noninteractive || initialized)). This attempts to thread
3159 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3160
7a35b20f
JB
31612013-07-04 Juanma Barranquero <lekktu@gmail.com>
3162
3163 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3164 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3165
1ce5cd04
PE
31662013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3169 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3170 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3171 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3172
57f8c490
PE
31732013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3174
3175 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3176 Define to __sys_siglist.
3177
bcffb5ca
EZ
31782013-07-02 Eli Zaretskii <eliz@gnu.org>
3179
3180 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3181 word-wrap, so that overflow-newline-into-fringe would work in
3182 visual-line-mode. (Bug#2749)
3183 (move_it_in_display_line_to): When the last scanned display
3184 element fits exactly on the display line, and
3185 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3186 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3187 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3188 finding buffer position that corresponds to pixel coordinates,
3189 e.g. in buffer_posn_from_coords.
3190
2c41e781
JD
31912013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3192
3193 * process.c (handle_child_signal): Call catch_child_signal if
3194 NS_IMPL_GNUSTEP.
3195
c2418359
PE
31962013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3197
52a9bcae
PE
3198 Don't convert function pointers to void * and back.
3199 It isn't portable C, and it's easy enough to avoid.
3200 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3201 (make_save_value): Add support for SAVE_FUNCPOINTER.
3202 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3203 * print.c (print_object):
3204 Distinguish function from object pointers.
3205 * lisp.h (SAVE_FUNCPOINTER): New constant.
3206 (SAVE_SLOT_BITS): Adjust to it.
3207 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3208 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3209 (voidfuncptr): New typedef.
3210 (struct Lisp_Save_Value): New member data[0].funcpointer.
3211 (XSAVE_FUNCPOINTER): New function.
3212
c2418359
PE
3213 Simplify buildobj processing.
3214 * Makefile.in (buildobj.h): Make it a sequence of strings each
3215 followed by comma, rather than a single string. Put it into a
3216 .tmp file in case there's an error while generating it.
3217 (gl-stamp): Use .tmp for temp files.
3218 (mostlyclean): Clean .tmp files.
3219 * doc.c (buildobj): Move to just the routine that needs it.
3220 It's now an array of strings, so processing is simpler.
3221
8f43ce49
PE
32222013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3223
3224 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3225 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3226 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3227 Invoke malloc_enable_thread even when not interactive.
3228 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3229 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3230 in this case, since the underlying bug has now been fixed.
3231
24827db9
JB
32322013-07-01 Juanma Barranquero <lekktu@gmail.com>
3233
3234 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3235 unlinking it (bug#14691).
3236
ef099a94
MN
32372013-06-30 Michal Nazarewicz <mina86@mina86.com>
3238
3239 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3240 before checking whether buffer is modified. This lets
3241 `kill-buffer-query-functions' cancel killing of the buffer or save
3242 its content before `kill-buffer' asks user the "Buffer %s
3243 modified; kill anyway?" question.
3244
9d3f2fc2
JD
32452013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3246
3247 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3248 Let the super performKeyEquivalent deal with them (Bug#14747).
3249
e6c6c8c7
PE
32502013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3251
1d71c1d9
PE
3252 * widget.c (resize_cb): Remove unused local.
3253
8f5f35cc
PE
3254 Do not use GTK 3 if it exists but cannot be compiled.
3255 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3256 * xterm.c (x_error_handler) [!USE_GTK]:
3257 Do not use GTK 3.
3258
e6c6c8c7
PE
3259 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3260
0ba54312
EZ
32612013-06-30 Eli Zaretskii <eliz@gnu.org>
3262
5d1c3286
EZ
3263 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3264 to the valid range of values. (Bug#14753)
3265
0ba54312
EZ
3266 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3267 when moving point by using the current glyph matrix. This avoids
3268 the need to force redisplay when this function is called in a
3269 loop.
3270
9c90cc06
PE
32712013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3272
3273 Fix minor problems found by static checking.
3274 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3275 Redo the latter's body to sidestep GCC parenthesization warnings.
3276 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3277 * coding.c (detect_coding, detect_coding_system):
3278 * coding.h (struct undecided_spec):
3279 Use bool for boolean.
3280 * image.c (QCmax_width, QCmax_height): Now static.
3281 * xdisp.c (Fmove_point_visually): Remove unused local.
3282
4c672a0f
EZ
32832013-06-29 Eli Zaretskii <eliz@gnu.org>
3284
3285 * xdisp.c (Fmove_point_visually): New function.
3286
c1ea3abf
JB
32872013-06-28 Kenichi Handa <handa@gnu.org>
3288
3289 * coding.h (define_coding_undecided_arg_index): New enum.
3290 (coding_attr_index): New members
3291 coding_attr_undecided_inhibit_null_byte_detection,
3292 coding_attr_undecided_inhibit_iso_escape_detection,
3293 coding_attr_undecided_prefer_utf_8.
3294 (undecided_spec): New struct.
3295 (struct coding_system): New member `undecided' of the member
3296 `spec'.
3297
3298 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3299 (detect_coding): Likewise.
3300 (detect_coding_system): Likewise.
3301 (Fdefine_coding_system_internal): New coding system properties
3302 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3303 :prefer-utf-8.
3304 (syms_of_coding): Adjust for coding_arg_undecided_max.
3305
ba3de9e6
PE
33062013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3307
3308 * image.c (x_from_xcolors): Remove unused local.
3309
547c9269
YM
33102013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3311
3312 Defer image data transfer between X client and server until actual
3313 display happens.
3314
3315 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3316 and `mask_img'.
3317
3318 * image.c (Destroy_Image): Remove.
3319 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3320 `mask_p', and `colors_p'. All uses changed.
3321 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3322 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3323 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3324 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3325 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3326 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3327 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3328 (image_get_x_image, image_unget_x_image): New functions or macros.
3329 (image_background, image_background_transparent, x_to_xcolors)
3330 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3331 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3332 instead of Destroy_Image.
3333 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3334 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3335 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3336 (imagemagick_load_image, svg_load_image): Use them instead of
3337 x_create_x_image_and_pixmap, and x_put_x_image followed by
3338 x_destroy_x_image, respectively.
3339 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3340 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3341 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3342 background_transparent fields.
3343 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3344 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3345
dae2f5ef
PE
33462013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3347
3348 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3349 This mostly consists of undoing recent changes.
3350 * callproc.c (Fcall_process):
3351 * process.c (create_process):
3352 Do not worry about catching SIGCHLD here, undoing previous change.
3353 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3354 * process.c, process.h (catch_child_signal):
3355 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3356 * process.c (catch_child_handler): Don't worry about being called
3357 lazily and do not assume caller has blocked SIGCHLD, undoing
3358 previous change. Move first-time stuff back to
3359 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3360 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3361 set lib_child_handler if it's already initialized, which may
3362 help avoid problems on GNUStep.
3363
fa55d2aa
PE
33642013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3367 * callproc.c (Fcall_process):
3368 * process.c (create_process):
3369 Make sure SIGCHLD is caught before we fork,
3370 since Emacs startup no arranges to catch SIGCHLD.
3371 * process.c (lib_child_handler): Initialize to null, not to
3372 dummy_handler.
3373 (catch_child_signal): Allow self to be called lazily.
3374 Do nothing if it's already been called.
3375 Assume caller has blocked SIGCHLD (all callers do now).
3376 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3377 just before it's really needed.
3378 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3379 since it hasn't been caught yet.
3380
f3f9606c
LMI
33812013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3382
3383 * image.c (compute_image_size): New function to implement
3384 :max-width and :max-height.
3385 (imagemagick_load_image): Use it.
3386
c7041908
PE
33872013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3390 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3391 Now extern.
3392 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3393 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3394 the SIGCHLD handler, since the code is not atomic and (due to glib)
3395 signals may be arriving now.
3396 * sysdep.c (init_signals): Do not catch child signals here;
3397 'main' now does that later, at a safer time.
3398
f86852b4
PE
33992013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3400
0dfeed58
PE
3401 Clean up SIGCHLD handling a bit (Bug#14569).
3402 * process.c, process.h (catch_child_signal):
3403 Now always extern, even if !NS_IMPL_GNUSTEP.
3404 * process.c (catch_child_signal): Move glib tickler here from
3405 init_process_emacs, so that it's done earlier in Emacs
3406 initialization. Also move the noninteractive && !initialized
3407 check here from init_process_emacs. This is all a bit cleaner for
3408 GNUish platforms, and I hope it works around the Cygwin bug.
3409 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3410 that glib signal handling is tickled before glib creates threads.
3411
f86852b4
PE
3412 * process.c (wait_reading_process_output): Avoid int overflow
3413 when reading more than 2 GiB total from a process.
3414
cbd6509c
PE
34152013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 * process.c (create_process): Handle a couple more cases,
3418 i.e., work even if new_argv and wait_child_setup[i] are cached.
3419 Use Fcall_process's style for volatile vars.
3420
9de1114a
AS
34212013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3422
3423 * process.c (create_process): Mark PROCESS volatile.
3424
fbe9e0b9
PE
34252013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3426
3427 Use C99-style flexible array members if available.
3428 This avoids some subtle aliasing issues, which typically
3429 aren't a problem with GCC but may be a problem elsewhere.
3430 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3431 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3432 In either case, it uses a flexible array member rather than
3433 the old struct hack. All uses changed.
3434 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3435 Adjust to sdata reorganization.
3436 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3437 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3438 that ports better to pre-C99 non-GCC.
3439 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3440 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3441 as the latter has changed.
3442 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3443 and port better to pre-C99 GCC.
3444 * image.c (struct xpm_cached_color):
3445 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3446 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3447 Use FLEXIBLE_ARRAY_MEMBER.
3448 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3449 Move decl to top level so it gets checked against implementation.
3450 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3451 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3452
1fc71008
PE
34532013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 * syntax.c: Integer cleanups.
3456 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3457 All uses that need 0-or-2 changed to:
3458 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3459 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3460 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3461 (char_quoted, prev_char_comend_first, back_comment)
3462 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3463 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3464 Use bool for boolean.
3465 (update_syntax_table, skip_chars, skip_syntaxes):
3466 Prefer int to unsigned when either will do.
3467 (back_comment): Return boolean success flag, like forw_comment,
3468 instead of positive-or-minus-1 (which might have overflowed int anyway).
3469 Don't stuff ptrdiff_t into int.
3470 (syntax_spec_code, syntax_code_spec): Now const.
3471 (Fmatching_paren, scan_lists, scan_sexps_forward):
3472 Use enum syntaxcode for syntax code.
3473 (Fmatching_paren): Check that arg is a character, not just an integer.
3474 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3475 (Finternal_describe_syntax_value): Omit no-longer-needed
3476 comparison to 0.
3477 (skip_chars): Use char, not unsigned char, when the distinction
3478 doesn't matter.
3479 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3480 * bytecode.c (exec_byte_code):
3481 * syntax.c (syntax_spec_code, Fchar_syntax)
3482 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3483 (init_syntax_once):
3484 * syntax.h (SYNTAX_WITH_FLAGS):
3485 Omit unnecessary casts.
3486
b932cad7
EZ
34872013-06-20 Eli Zaretskii <eliz@gnu.org>
3488
3489 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3490 line dimensions here, to avoid race conditions with the main
3491 thread. (Bug#14062, bug#14630, bug#14669)
3492
3493 * w32term.c (w32_draw_window_cursor): Compute the header line and
3494 mode line dimensions here.
3495 <w32_system_caret_window, w32_system_caret_hdr_height>:
3496 <w32_system_caret_mode_height>: New variables.
3497
3498 * w32term.h: Declare them.
3499
89561f72
PE
35002013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3501
5013fc08
PE
3502 * alloc.c (die): Move "assertion failed" string here ...
3503 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3504 COND when SUPPRESS_CHECKING. This shrinks the executable text
3505 size by 0.8% to 2.2% when configured with --enable-checking,
3506 depending on optimization flags (GCC 4.8.1 x86-64).
3507
89561f72
PE
3508 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3509
763a086d 35102013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3511
3512 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3513 base is 2; this is more accurate.
3514
983aeb9a
JB
35152013-06-19 Juanma Barranquero <lekktu@gmail.com>
3516
3517 * sound.c (string_default): Move to !WINDOWSNT section.
3518 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3519
178ba3e6
PE
35202013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3521
bbc51b15
PE
3522 * sound.c: Integer cleanups.
3523 Remove unnecessary forward decls.
3524 (struct sound_device): The 'file' member is now a Lisp_Object, not
3525 a char *, so that we needn't invoke alloca on a huge size.
3526 (Fplay_sound_internal): Adjust to this.
3527 (string_default): New function.
3528 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3529 Use it to adjust to the struct sound_device change.
3530 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3531 (be2hs) [0]: Remove.
3532
178ba3e6
PE
3533 * syntax.c (skip_chars): Don't use uninitialized storage
3534 when searching a multibyte buffer for characters that are not in a
3535 unibyte string that contains non-ASCII characters.
3536
69f60cdc
JD
35372013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3538
3539 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3540 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3541
0d6224d4
PE
35422013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3543
3544 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3545
3c542890
KH
35462013-06-18 Kenichi Handa <handa@gnu.org>
3547
f7e3f7cd
KH
3548 * font.c (Ffont_spec): Signal an error for an invalid font name
3549 (Bug#14648).
3c542890 3550
9349e5f7
PE
35512013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3552
3553 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3554 In particular this ports to 32-bit sparc Sun cc.
3555 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3556 array with a dummy element at specpdl[-1], so that its address can
3557 be taken portably.
3558 (unbind_to): Do not copy the binding; not needed, now that we
3559 copy old_value in the one place where the copy is needed.
3560 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3561 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3562 (union specbinding): Rename from struct specbinding. Redo layout
3563 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3564 which is not portable. With Sun C 5.12 32-bit sparc, the
3565 declaration causes nargs to be an unsigned bitfield, a behavior
3566 that the C standard allows; but Emacs wants nargs to be signed.
3567 The overall type is now a union of structures rather than a
3568 structure of union of structures, and the 'kind' member is now a
3569 bitfield, so that the overall type doesn't grow. All uses changed.
3570 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3571
0a4df6a5
PE
35722013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3573
ec6ecaad
PE
3574 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3575 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3576
0a4df6a5
PE
3577 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3578
7bfe8dbc
EZ
35792013-06-17 Eli Zaretskii <eliz@gnu.org>
3580
3581 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3582 unless we know that the window w's frame is a frame object.
3583 Another attempt at solving bug#14062 and bug#14630.
3584
708e05f6
LMI
35852013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3586
3587 * textprop.c (property_set_type): New enum.
3588 (add_properties): Allow appending/prepending text properties.
3589 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3590 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3591 add_text_properties_1.
3592 (Fadd_face_text_property): New function that calls
3593 add_text_properties_1.
3594
84575e67
PE
35952013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Move functions from lisp.h to individual modules when possible.
3598 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3599 * alloc.c (XFLOAT_INIT, set_symbol_name):
3600 * buffer.c (CHECK_OVERLAY):
3601 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3602 (set_char_table_parent):
3603 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3604 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3605 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3606 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3607 (set_blv_valcell):
3608 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3609 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3610 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3611 (backtrace_args, backtrace_debug_on_exit):
3612 * floatfns.c (CHECK_FLOAT):
3613 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3614 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3615 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3616 (set_hash_index_slot):
3617 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3618 * marker.c (CHECK_MARKER):
3619 * textprop.c (CHECK_STRING_OR_BUFFER):
3620 * window.c (CHECK_WINDOW_CONFIGURATION):
3621 Move here from lisp.h, and make these functions static rather than
3622 extern inline.
3623 * buffer.c (Qoverlayp):
3624 * data.c (Qsubrp):
3625 * fns.c (Qhash_table_p):
3626 * window.c (Qwindow_configuration_p):
3627 Now static.
3628 * lisp.h: Remove the abovementioned defns and decls.
3629
44e18199 3630 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3631 In lisp.h, prefer functions to function-like macros, and
3632 constants to object-like macros, when either will do. This:
3633 . simplifies use, as there's no more need to worry about
3634 arguments' side effects being evaluated multiple times.
3635 . makes the code easier to debug on some platforms.
3636 However, when using gcc -O0, keep using function-like macros
3637 for a few critical operations, for performance reasons.
3638 This sort of thing isn't needed with gcc -Og, but -Og
3639 is a GCC 4.8 feature and isn't widely-enough available yet.
3640 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3641 Remove enum lsb_bits; no longer needed.
3642 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3643 * buffer.c (Qoverlap):
3644 * data.c (Qsubrp):
3645 * fns.c (Qhash_table_p):
3646 Now extern, so lisp.h can use these symbols.
3647 * dispextern.h: Include character.h, for MAX_CHAR etc.
3648 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3649 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3650 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3651 (GLYPH_CODE_P): Move here from lisp.h.
3652 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3653 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3654 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3655 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3656 XUNTAG now returns void *.
3657 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3658 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3659 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3660 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3661 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3662 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3663 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3664 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3665 New macros, renamed from their sans-lisp_h_ counterparts.
3666 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3667 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3668 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3669 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3670 If compiling via GCC without optimization, define these as macros
3671 in addition to inline functions.
3672 To disable this, compile with -DINLINING=0.
3673 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3674 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3675 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3676 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3677 (INTMASK, VALMASK): Now macros, since static values cannot be
3678 accessed from extern inline functions.
3679 (VALMASK): Also a constant, for benefit of old GDB.
3680 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3681 is INTEGERP, which can fold it in.
5165d44a 3682 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3683 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3684 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3685 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3686 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3687 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3688 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3689 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3690 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3691 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3692 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3693 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3694 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3695 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3696 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3697 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3698 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3699 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3700 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3701 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3702 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3703 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3704 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3705 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3706 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3707 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3708 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3709 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3710 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3711 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3712 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3713 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3714 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3715 Now functions.
3716 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3717 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3718 (VALMASK): Define in one place rather than in two, merging the
3719 USE_LSB_TAG parts; this is simpler.
3720 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3721 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3722 Move up, to avoid use before definition.
3723 Also include "globals.h" earlier, for the same reason.
3724 (make_natnum): New function.
3725 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3726 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3727 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3728 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3729 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3730 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3731 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3732 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3733 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3734 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3735 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3736 (Qwindow_configuration_p, Qimage): New forward declarations.
3737 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3738 (STRING_COPYIN): Remove; unused.
3739 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3740 (xcar_addr, xcdr_addr): New functions. All uses changed.
3741 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3742 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3743 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3744 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3745 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3746 (TYPE_RANGED_INTEGERP): Simplify.
3747 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3748 (setlocale, fixup_locale, synchronize_system_messages_locale)
3749 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3750 Now empty functions, not macros.
3751 (functionp): Return bool, not int.
3752 * window.c (Qwindow_configuration_p): Now extern,
3753 so window.h can use it.
3754 * window.h (Qwindowp): Move decl back to lisp.h.
3755
9583ec36
EZ
37562013-06-15 Eli Zaretskii <eliz@gnu.org>
3757
3758 * xdisp.c (Fline_pixel_height): New function, required for solving
3759 bug #14567.
3760
210272ce
PE
37612013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3762
3763 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3764
de0503df
SM
37652013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3766
3767 * lread.c (syms_of_lread):
3768 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3769
afbfe143
KD
37702013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3771
3772 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3773
d177e213
XF
37742013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3775
3776 * fileio.c (expand_file_name): Doc fix.
3777
05e3e412
PE
37782013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3779
f7394b12
PE
3780 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3781 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3782 Wait for self, not for 0. This can't hurt on GNU or similar
3783 system, and may help with Cygwin.
3784
05e3e412
PE
3785 * keyboard.c: Don't use PROP (...) as an lvalue.
3786 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3787 Use set_prop (A, B), not PROP (A) = B.
3788
17dd3097
EZ
37892013-06-10 Eli Zaretskii <eliz@gnu.org>
3790
3791 * xdisp.c (get_it_property): Use it->window instead of generating
3792 a Lisp object from it->w.
3793
52fab9c9
EZ
37942013-06-09 Eli Zaretskii <eliz@gnu.org>
3795
3796 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3797 get-char-property the window that is being rendered, instead of
3798 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3799 (compute_display_string_pos): When W is NULL, use the current
3800 buffer as the object to pass to get-char-property.
3801 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3802 pointer member of the bidi iterator, since no window is pertinent
3803 to this function.
52fab9c9 3804
5bf97bfc
EZ
38052013-06-08 Eli Zaretskii <eliz@gnu.org>
3806
3807 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3808 being displayed, and pass it to compute_display_string_pos.
3809 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3810 (bidi_paragraph_init): All callers changed.
3811
3812 * xdisp.c (init_from_display_pos, init_iterator)
3813 (handle_single_display_spec, next_overlay_string)
3814 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3815 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3816 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3817 (compute_display_string_pos): Accept additional argument, the
3818 window being displayed, and pass it to Fget_char_property.
3819 (Bug#14575)
3820
3821 * dispextern.h (struct bidi_it): New member w, the window being
3822 displayed.
3823 (compute_display_string_pos): Adjust prototype.
3824
5de0e011
JD
38252013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3826
e7b41c4c 3827 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3828
3829 * process.c (wait_reading_process_output): Check for NS before GLIB.
3830 GLIB may be linked in due to rsvg, but ns_select must be called.
3831
5de0e011
JD
3832 * xgselect.c (xg_select): Remove call to window_system_available
3833 and g_main_context_pending at the top, so Gdk events (i.e. file
3834 notify) are processed when Emacs is started with -nw.
3835
a822acff
EZ
38362013-06-07 Eli Zaretskii <eliz@gnu.org>
3837
3838 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3839 (ctagsfiles3): New variable, includes only *.m files.
3840 (TAGS): Use an explicit language name in the regular expressions,
3841 to avoid transformation of '/SOMETHING' by MSYS to
3842 'c:\MSYS\SOMETHING'.
3843
6c0a9ed1
RC
38442013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3845
3846 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3847
9ef6111b
EZ
38482013-06-06 Eli Zaretskii <eliz@gnu.org>
3849
3850 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3851 still need to set the mouse pointer shape and activate help-echo.
3852 (Bug#14558)
3853
7d300d64
PE
38542013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3855
3856 A few porting etc. fixes for the new file monitor code.
3857 See the thread containing
3858 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3859 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3860 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3861 (dir_monitor_callback, Fgfile_rm_watch):
3862 Use assq_no_quit instead of Fassoc, for speed.
3863 (dir_monitor_callback, Fgfile_rm_watch):
3864 eassert that the monitor is a fixnum.
3865 (dir_monitor_callback): No need for CDR_SAFE.
3866 Simplify building of lisp with alternative tails.
3867 (Fgfile_add_watch, Fgfile_rm_watch):
3868 Do not assume glib functions set errno reliably on failure.
3869 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3870 and signal an error otherwise.
3871 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3872 Use Fdelq instead of Fdelete, for speed.
3873
817ebfcf
EZ
38742013-06-05 Eli Zaretskii <eliz@gnu.org>
3875
3876 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3877 don't insist on being invoked on a highlighted tool-bar button.
3878 Avoids losing tool-bar functionality when mouse-highlight is nil.
3879 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3880 Don't highlight when mouse-highlight is nil.
3881 (note_mouse_highlight): When mouse-highlight is nil, don't return
3882 right away; instead, run tool-bar and mode-line highlight
3883 subroutine, clear any existing highlight, and revert the mouse
3884 pointer to its default shape. (Bug#14558)
3885
55577e7c
SM
38862013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3887
3888 * lisp.mk (lisp): Add prog-mode.el.
3889
f019a684
PE
38902013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3893 * process.c (dummy_handler): New function.
3894 (lib_child_handler): New static var.
3895 (handle_child_signal): Invoke it.
3896 (catch_child_signal): If a library has set up a signal handler,
3897 save it into lib_child_handler.
3898 (init_process_emacs): If using glib and not on Windows, tickle glib's
3899 child-handling code so that it initializes its private SIGCHLD handler.
3900 * syssignal.h (SA_SIGINFO): Default to 0.
3901 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3902 31; it should no longer be needed now.
3903
90db8702
MA
39042013-06-05 Michael Albinus <michael.albinus@gmx.de>
3905
3906 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3907
3908 * gfilenotify.c (globals_of_gfilenotify): New function.
3909 (syms_of_gfilenotify): Move global initialization there.
3910
3911 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3912
bfa3acd6
SM
39132013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3914
3915 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3916 * keyboard.c (menu_bar_items, tool_bar_items):
3917 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3918 not override local keymaps any more.
3919
ba59bd80
EZ
39202013-06-04 Eli Zaretskii <eliz@gnu.org>
3921
3922 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3923
7f203aa1
EZ
39242013-06-03 Eli Zaretskii <eliz@gnu.org>
3925
9337e206
EZ
3926 * w32console.c (initialize_w32_display): Return the dimensions of
3927 the console window via 2 additional arguments, not via the current
3928 frame. This avoids crashes due to overrunning the bounds of
3929 frame's decode_mode_spec_buffer, which is not resized following
3930 the change of the frame dimensions from the initial 10x10.
3931
3932 * w32term.h (w32_initialize_display_info): Adjust prototype.
3933
3934 * term.c (init_tty): Take dimensions of the frame from the values
3935 returned by initialize_w32_display.
3936
7f203aa1
EZ
3937 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3938 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3939 (LIBES): Add $(GFILENOTIFY_LIBS).
3940
3941 * w32inevt.c (handle_file_notifications): Add dummy implementation
3942 for !HAVE_W32NOTIFY.
3943
3944 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3945
55a87246
JD
39462013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3947
3948 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3949
3950 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3951
3952 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3953
3d5ee10a
PE
39542013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3955
3956 Fix minor problems found by static checking.
3957 * data.c (pure_write_error):
3958 Use xsignal2, not Fsignal, as Fsignal might return.
3959 * eval.c (set_backtrace_debug_on_exit): Now static.
3960 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3961 No longer inline. EXTERN_INLINE is needed only for functions
3962 defined in .h files. Reindent function header as per GNU style.
3963 (backtrace_p, backtrace_top, backtrace_next):
3964 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3965 compiler or linker. Add extern decls to pacify gcc -Wall.
3966 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3967 Now static.
3968 * frame.c (free_monitors): Define only on platforms that need it.
3969 * nsterm.m (ns_term_init):
3970 * process.c (catch_child_signal):
3971 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3972 defined on all porting targets these days.
3973 * process.c, process.h (catch_child_signal):
3974 Make it extern only if NS_IMPL_GNUSTEP is defined.
3975
e2d8a6f0
EZ
39762013-06-03 Eli Zaretskii <eliz@gnu.org>
3977
3978 * w32.c (gettimeofday): Make the signature identical to prototype
3979 in nt/inc/sys/time.h.
3980
a8a7c5f6
SM
39812013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3982
3983 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3984 .gdbinit.
3985
3986 * keyboard.c (safe_run_hooks_error): Improve error message.
3987
3988 * data.c (pure_write_error): Add `object' argument.
3989 * puresize.h (CHECK_IMPURE): Use it.
3990
c9628c79
MA
39912013-06-03 Michael Albinus <michael.albinus@gmx.de>
3992
3993 * Makefile.in (NOTIFY_OBJ): New variable.
3994 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3995
3996 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3997 Call syms_of_gfilenotify.
3998
3999 * gfilenotify.c: New file.
4000
4001 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4002 and Qfile_w32notify.
4003 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4004 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4005
4006 * lisp.h: Declare syms_of_gfilenotify.
4007
4008 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4009
2f592f95
SM
40102013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4011
4012 Merge the specpdl and backtrace stacks. Make the structure of the
4013 specpdl entries more obvious via a tagged union of structs.
4014 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4015 (enum specbind_tag): New enum.
4016 (struct specbinding): Make it a tagged union of structs.
4017 Add a case for backtrace records.
4018 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4019 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4020 (backtrace_debug_on_exit): New accessors.
4021 (struct backtrace): Remove.
4022 (struct catchtag): Remove backlist field.
4023 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4024 Move to eval.c.
4025 (Flocal_variable_p): Speed up the common case where the binding is
4026 already loaded.
4027 * eval.c (backtrace_list): Remove.
4028 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4029 (set_backtrace_args, set_backtrace_nargs)
4030 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4031 (backtrace_next): New functions.
4032 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4033 (unwind_to_catch, internal_lisp_condition_case)
4034 (internal_condition_case, internal_condition_case_1)
4035 (internal_condition_case_2, internal_condition_case_n): Don't bother
4036 with backtrace_list any more.
4037 (Fsignal): Adjust to new backtrace format.
4038 (grow_specpdl): Move up.
4039 (record_in_backtrace): New function.
4040 (eval_sub, Ffuncall): Use it.
4041 (apply_lambda): Adjust to new backtrace format.
4042 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4043 data.c.
4044 (specbind): Adjust to new specpdl format. Simplify.
4045 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4046 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4047 backtrace format.
4048 (mark_backtrace): Remove.
4049 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4050 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4051 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4052 Use mark_specpdl.
4053 * profiler.c (record_backtrace): Use get_backtrace.
4054 (handle_profiler_signal): Use backtrace_top_function.
4055 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4056 accessor functions.
4057
c0342369
JD
40582013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4059
4060 * process.h (catch_child_signal): Declare.
4061
4062 * process.c (catch_child_signal): New function.
4063 (init_process_emacs): Call it.
4064
4065 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4066 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4067 NS_IMPL_COCOA.
4068 (x_set_cursor_type): Remove declaration.
4069 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4070 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4071 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4072 (ns_get_color): Use F suffix on float.
4073 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4074 (ns_get_rgb_color): Remove.
4075 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4076 (note_mouse_movement): x and y are CGFloat.
4077 (ns_draw_fringe_bitmap): Remove unused rowY.
4078 Change #if to COCOA && >= 10_6.
4079 (ns_draw_window_cursor): Remove unused overspill.
4080 (ns_draw_underwave): width and x are EamcsCGFloat.
4081 (ns_draw_box): thickness is CGFloat.
4082 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4083 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4084 if not in main thread.
4085 (ns_get_pending_menu_title, ns_check_menu_open)
4086 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4087 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4088 (sendFromMainThread:): New method.
4089 (changeFont:): size is CGFloat.
4090 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4091 Disable warning about permanent text.
4092 (characterIndexForPoint:): Adjust return type depending on GNUStep
4093 version.
4094 (mouseDown:): delta is CGFloat.
4095 (updateFrameSize): Remove unised variable f.
4096 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4097 Cast float to EmacsCGFloat.
4098 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4099 also to -1 when restoring.
4100 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4101 inside NS_IMPL_COCOA.
4102 (toggleFullScreen:): Put call to toggleFullScreen inside
4103 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4104 (setPosition:portion:whole:): por is CGFloat.
4105 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4106 (mouseDown:): Use CGFloat.
4107 (mouseDragged:): Remove unised variable edge.
4108 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4109
4110 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4111 of CGFloat differs.
4112 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4113 when NS_IMPL_GNUSTEP.
4114 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4115 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4116 (EmacsToolbar): Add clearAll. Add tag argument to
4117 addDisplayItemWithImage.
4118 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4119
4120 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4121
4122 * nsmenu.m (ns_update_menubar): Make static.
4123 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4124 (fillWithWidgetValue:): Add cast to SEL for setAction.
4125 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4126 (update_frame_tool_bar): Update code for GNUStep.
4127 (clearAll): New method.
4128 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4129 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4130 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4131 call to insertItemWithItemIdentifier.
4132 (validateVisibleItems): Fix indentation.
4133 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4134 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4135 UtilityWindow to aStyle, remove call to setStyleMask.
4136
4137 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4138
4139 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4140 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4141 Use F suffix on floats.
4142 (ns_char_width): Returns CGFloat.
4143 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4144 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4145 DPSxshow.
4146 (ns_glyph_metrics): CGFloat instead of float.
4147
a0eb10b3
JB
4148 * nsfns.m (x_set_foreground_color, x_set_background_color):
4149 Use EmacsCGFloat.
4150 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4151 remove unused variables.
4152 (Fns_read_file_name): Keep track if panel is for save.
4153 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4154 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4155 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4156 Just return the input if GNUStep.
c0342369
JD
4157 (x_screen_planes): Remove.
4158 (Fxw_color_values): Use EmacsCGFloat
4159 (Fns_display_monitor_attributes_list): Only get screen number for
4160 Cocoa.
ef099a94 4161 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4162 EmacsSavePanel.
4163 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4164 ns_directory_from_panel.
4165
da9aff11
PE
41662013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 * process.c (handle_child_signal): Also use WCONTINUED.
4169 This is so that list-processes doesn't mistakenly list the process
4170 as stopped, when the process has actually been continued and is
4171 now running.
4172
0e64479a
PE
41732013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4174
fc186a96
PE
4175 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4176 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4177 not already configured.
4178
0e64479a
PE
4179 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4180
38b787fa
EZ
41812013-05-29 Eli Zaretskii <eliz@gnu.org>
4182
4183 * Makefile.in (mostlyclean): Remove *.res files.
4184
22513e52
SM
41852013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4186
4187 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4188 a buffer (bug#8447).
4189
6ef3db10
EZ
41902013-05-27 Eli Zaretskii <eliz@gnu.org>
4191
4192 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4193 display vector, and we backtrack, handle the case that the
4194 previous character position is also displayed from a display
4195 vector or covered by a display string or image. (Bug#14476)
4196
6799bb26
JD
41972013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4198
4199 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4200 (struct MonitorInfo, free_monitors): Remove.
4201 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4202 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4203 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4204 Qframes, Qsource.
4205
4206 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4207 (struct MonitorInfo, free_monitors): Remove.
4208 (ns_screen_name): Make static.
4209 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4210 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4211 Qframes, Qsource.
4212
4213 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4214 (struct MonitorInfo): New struct.
4215 (free_monitors, make_monitor_attribute_list): Declare.
4216
22513e52
SM
4217 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4218 New Lisp_Object:s.
6799bb26
JD
4219 (free_monitors, make_monitor_attribute_list): New functions.
4220 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4221 Qsource.
4222
38cd43eb
XF
42232013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4224
4225 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4226
2af0948d
SM
42272013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4228
a7eb9b0f
SM
4229 * keyboard.c: Apply keyboard decoding only to events that come directly
4230 from the tty, not from unread-command-events (bug#14368).
4231 (read_event_from_main_queue): New function, extracted from read_char).
4232 (read_decoded_char): Remove.
4233 (read_decoded_event_from_main_queue): New function to replace it.
4234 (read_char): Use it.
4235 (read_key_sequence): Use read_char rather than read_decoded_char.
4236
2af0948d
SM
4237 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4238
1413e9a5
BR
42392013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4240
4241 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4242
e6d2f155
KH
42432013-05-22 Kenichi Handa <handa@gnu.org>
4244
4245 The following changes are to fix the setting of
4246 buffer-file-coding-system on, for instance, C-x RET c unix RET
4247 _FILE_OF_DOS_EOL_TYPE_ RET.
4248
4249 * coding.h (struct coding_system): New member detected_utf8_chars.
4250
4251 * coding.c (detect_coding_utf_8): Count characters and check EOL
4252 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4253 BOM is there.
4254 (setup_coding_system): Do not initialize coding->head_ascii.
4255 (check_ascii): Do not set coding->eol_seen but update it. Do not
4256 call adjust_coding_eol_type here.
1413e9a5
BR
4257 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4258 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4259 of the found coding-system.
4260 (decode_coding_gap): Cancel previous change. Utilize the
4261 character numbers counted by detect_coding_utf_8. Fix detection
4262 of BOM for utf-8.
4263
ab56a6f4 42642013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4265
4266 * search.c (looking_at_1): Only set last_thing_searched if the match
4267 changed the match-data (bug#14281).
4268
ecc3c6ed
DA
42692013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4270
4271 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4272 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4273 (move_it_vertically_backward): Likewise.
4274
5ba8bf35
YM
42752013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4276
4277 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4278 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4279 (Fx_display_mm_width, Fx_display_mm_height):
4280 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4281
91e8418b 4282 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4283 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4284 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4285 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4286 (Fx_display_backing_store, Fx_display_visual_class)
4287 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4288 (Fx_display_grayscale_p, Fx_display_pixel_width)
4289 (Fx_display_pixel_height, Fx_display_planes)
4290 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4291 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4292 (Fx_display_mm_width, Fx_display_mm_height)
4293 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4294 height for all physical monitors as in X11.
4295
fc30d803
SM
4296 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4297 Return pixel width or height for all physical monitors as in X11.
91e8418b 4298
31ff141c
PE
42992013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 Port --enable-gcc-warnings to clang.
4302 * bytecode.c (exec_byte_code):
4303 * regex.c:
4304 Redo diagnostic pragmas to pacify clang, too.
4305 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4306 * editfns.c (Fencode_time):
4307 * fileio.c (file_accessible_directory_p):
4308 * font.c (font_unparse_xlfd):
4309 Use '&"string"[index]' instead of '"string" + (index)'.
4310 * undo.c (user_error): Remove; unused.
4311
df065a0b
EZ
43122013-05-16 Eli Zaretskii <eliz@gnu.org>
4313
04d360e7
EZ
4314 * insdel.c (insert_1_both): Document the arguments, instead of
4315 referring to insert_1, which no longer exists.
4316
5bb98290
EZ
4317 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4318 some window, increment windows_or_buffers_changed, so that
4319 *Messages* display in that window is updated. (Bug#14408)
4320
df065a0b
EZ
4321 * w32.c: Include epaths.h.
4322 (init_environment): Use cmdproxy.exe without leading directories.
4323 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4324 case.
4325 (gettimeofday): Adjust signature and return value to Posix
4326 expectations.
4327
4328 * unexw32.c (open_output_file): Delete the existing emacs.exe
4329 before creating it, to break the hard link to the versioned
4330 executable.
4331
4332 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4333 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4334 (FIRSTFILE_OBJ): New variables.
4335 (W32_RES): Rename to EMACSRES. All users changed.
4336 (base_obj): Use $(CM_OBJ).
4337 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4338 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4339 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4340 $(W32_RES_LINK) before $(LIBES).
4341 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4342
1aa8d505
SM
43432013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4344
6e911150
SM
4345 * makefile.w32-in (DOC): Use just "DOC".
4346
4347 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4348
1aa8d505
SM
4349 * process.c: Export default filters and sentinels to Elisp.
4350 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4351 New constants.
4352 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4353 (Fset_process_sentinel, Fformat_network_address):
4354 Default to them instead of nil.
4355 (server_accept_connection): Sentinels can't be nil any more.
4356 (read_and_dispose_of_process_output): New function, extracted from
4357 read_process_output.
4358 (read_process_output): Use it; filters can't be nil.
4359 (Finternal_default_process_filter): New function, extracted from
4360 read_process_output.
4361 (exec_sentinel_unwind): Remove function.
4362 (exec_sentinel): Don't zilch sentinel while running.
4363 (status_notify): Sentinels can't be nil.
4364 (Finternal_default_process_sentinel): New function extracted from
4365 status_notify.
4366 (setup_process_coding_systems): Default filter is not nil any more.
4367 (syms_of_process): Export new Elisp functions and initialize
4368 new constants.
4369 * lisp.h (make_lisp_proc): New function.
4370
5ac2eb34
SM
43712013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4372
4373 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4374
eda9c7d7
EZ
43752013-05-14 Eli Zaretskii <eliz@gnu.org>
4376
4377 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4378 unless we know that the window w is a leaf window.
4379 Another attempt at solving bug#14062.
eda9c7d7 4380
8fdeaad5
JD
43812013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4382
4383 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4384 fdesc (Bug#14375).
4385
44aa9ee6
PE
43862013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4387
4388 * image.c (gif_load): Check that subimages fit (Bug#14345).
4389
759fd763
SM
43902013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4391
4392 * lread.c (skip_dyn_eof): New function.
4393 (read1): Use it to skip the end of a file in response to #@00.
4394
4395 * doc.c (get_doc_string): Slightly relax the sanity checking.
4396
4465bfb4
JD
43972013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4398
4399 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4400 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4401 (MonitorInfo): New struct.
4402 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4403 (Fns_display_monitor_attributes_list): New functions.
4404 (display-usable-bounds): Remove.
4405 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4406 Qsource.
4407
7583e2a0
PE
44082013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4409
4410 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4411 (GTK_CHECK_VERSION): New macro, if not already defined.
4412 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4413 replaced by GTK_CHECK_VERSION.
4414
ad75d77e
PE
44152013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4416
4417 * xterm.h (GTK_PREREQ): New macro.
4418 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4419 to use this macro instead, for consistency and clarity.
4420
07525f77
EZ
44212013-05-08 Eli Zaretskii <eliz@gnu.org>
4422
4423 * xdisp.c (row_for_charpos_p): New function, with code of
4424 cursor_row_p, but accepts an additional argument CHARPOS instead
4425 of using a hardcoded PT.
4426 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4427 (row_containing_pos): Call row_for_charpos_p instead of partially
4428 doing the same. Fixes cursor positioning under longlines-mode
4429 when longlines-show-effect includes more than one newline, when
4430 moving the cursor vertically up.
4431
d901fc8d
JB
44322013-05-08 Juanma Barranquero <lekktu@gmail.com>
4433
4434 * makefile.w32-in (ACL_H): New macro.
4435 ($(BLD)/fileio.$(O)): Update dependencies.
4436
f269bc61
PE
44372013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4438
e7b41c4c 4439 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4440 * Makefile.in (LIB_ACL): New macro.
4441 (LIBACL_LIBS): Remove.
4442 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4443 * fileio.c: Include <acl.h>.
4444 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4445 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4446 !acl_errno_valid.
4447 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4448 it ourselves.
4449
f269bc61
PE
4450 * unexelf.c: Don't assume ElfW (Half) fits in int.
4451 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4452 when dealing with ElfW (Half) values, since they can exceed 2**31
4453 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4454 (entry_address): Omit unused NUM arg. All uses changed.
4455
a261c53e
JL
44562013-05-07 Juri Linkov <juri@jurta.org>
4457
4458 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4459 to the string converted from number with `Fnumber_to_string'.
4460 (Bug#14254)
4461
2b66427d
PE
44622013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4465 This fixes a problem introduced by my previous change.
4466
15acfe41
GM
44672013-05-07 Glenn Morris <rgm@gnu.org>
4468
4469 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4470
5ea03bf5
JD
44712013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4472
4473 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4474
e0c9d565
PE
44752013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4476
4477 Static checking by GCC 4.8.0.
4478 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4479 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4480 (x_get_monitor_attributes_fallback)
4481 (x_get_monitor_attributes_xinerama)
4482 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4483 Define only if USE_GTK.
4484 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4485 (x_get_monitor_attributes_fallback): Omit unused locals.
4486 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4487 Use double, not float, to avoid mixed-mode floating point arithmetic.
4488
4e3f9230
YM
44892013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4490 Jan Djärv <jan.h.d@swipnet.se>
4491
4492 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4493 (XINERAMA_CFLAGS): New macros.
4494 (ALL_CFLAGS, LIBES): Use them.
4495
4496 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4497 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4498 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4499 (syms_of_xfns): DEFSYM them.
4500 (struct MonitorInfo): New struct.
4501 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4502 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4503 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4504 (x_get_monitor_attributes_xinerama): New functions.
4505 (Fx_display_monitor_attributes_list): New primitive.
4506 (syms_of_xfns): Defsubr it.
4507
4508 * xterm.h (x_display_info): Add Xatom_net_workarea and
4509 Xatom_net_current_desktop.
4510
4511 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4512 and dpyinfo->Xatom_net_current_desktop.
4513
05839b6a
EZ
45142013-05-06 Eli Zaretskii <eliz@gnu.org>
4515
4516 * xdisp.c (pos_visible_p): Use the special code for finding the
4517 beginning of a display property or overlay for any "replacing"
4518 display property, not just for display strings. This solves
4519 incorrect reporting of position by posn-at-point. (Bug#14241)
4520
dc4a2ee0
PE
45212013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4522
5ee94506
PE
4523 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4524 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4525 Verify that ElfW (Half) fits in int.
4526 (fatal): Use same signature as lisp.h.
4527 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4528 configure and build with -DUNEXELF_DEBUG without worrying about
4529 other modules that use DEBUG.
4530 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4531 possibly-wide integers now uses it instead of plain fprintf.
4532 (entry_address): New function, which avoids problems with 32-bit
4533 overflow on 64-bit hosts.
4534 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4535 (round_up): Don't assume the remainder fits in int.
4536 (find_section): Use bool for boolean. Simplify debug code.
4537 (unexec): Don't assume file sizes fit in int or size_t.
4538 Omit unnecessary trailing newline in 'fatal' format.
4539 Use strerror rather than outputting decimal error number.
4540 Remove unused code when emacs is not defined;
4541 this file relies on Emacs now.
4542 Don't assume e_phnum and e_shnum are positive.
4543
dc4a2ee0
PE
4544 * regex.c: Fix problems when DEBUG is defined.
4545 (extract_number, extract_number_and_incr): Define regardless of
4546 whether DEBUG is defined; that's simpler and makes the code less
4547 likely to go stale in the normal case when DEBUG is not defined.
4548 Return int rather than taking an int * arg. All callers changed.
4549 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4550 Remove, replacing with ...
4551 (DEBUG_PRINT): New macro. All callers changed.
4552 (DEBUG_COMPILES_ARGUMENTS): New macro.
4553 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4554 (print_compiled_pattern, print_double_string) [DEBUG]:
4555 Use prototype rather than old-style definition.
4556 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4557 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4558 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4559 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4560 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4561 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4562 This matters only when DEBUG is defined.
4563
14c7ed05
EZ
45642013-05-05 Eli Zaretskii <eliz@gnu.org>
4565
4566 * xdisp.c (set_iterator_to_next): Set the
4567 ignore_overlay_strings_at_pos_p flag only if we are _really_
4568 iterating over an overlay string, as indicated by the
4569 current.overlay_string_index member. (Bug#14306)
4570
e6076b1b
JD
45712013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4572
4573 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4574 to where it is used, to avoid autorelease issues (Bug#14050).
4575
cbee2131
PE
45762013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4577
4578 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4579 * fileio.c (syms_of_fileio): Implement this.
4580 * filelock.c (create_lock_file): If symbolic links don't work, so
4581 we use a regular file as a lock file, do not fsync the lock file;
4582 it's not needed.
4583
30c7e542
SM
45842013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4585
4586 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4587 (syms_of_minibuf): Adjust accodingly.
4588 * lread.c (Fread):
4589 * callint.c (Fcall_interactively): Adjust calls accordingly.
4590
5bebd186
EZ
45912013-05-04 Eli Zaretskii <eliz@gnu.org>
4592
4593 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4594 w->contents is a buffer before computing everything else.
4595 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4596
4597 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4598 assertion violations. (Bug#14062)
4599
0fb0a4f3
DR
46002013-05-01 David Reitter <david.reitter@gmail.com>
4601
4602 * nsfns.m (ns_tooltip): Initialize.
4603
9e63b4a5
EZ
46042013-04-28 Eli Zaretskii <eliz@gnu.org>
4605
4606 * coding.c (decode_coding_gap): Don't remove the character before
4607 a newline unless it's a CR character. (Bug#14287)
4608
ad60824e
DN
46092013-04-28 Dan Nicolaescu <dann@gnu.org>
4610
4611 * dispextern.h (struct face): Move enum face_underline_type
4612 earlier so that bitfields can be in the same word.
4613
edbdcec0
JD
46142013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4615
4616 * nsfns.m (handlePanelKeys): New function.
4617 (EmacsOpenPanel:performKeyEquivalent:)
4618 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4619 arrows/function/control and copy/paste keys (Bug#14296).
4620
0208ede7
JL
46212013-04-27 Juri Linkov <juri@jurta.org>
4622
4623 * callint.c (Fcall_interactively): Call `Qread_number' for
4624 interactive code letter `n' instead of using duplicate code.
4625 (Bug#14254)
4626
b8dd59f7
PE
46272013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4628
4629 * systime.h (make_timeval): Declare as 'const'.
4630
8bd722db
KH
46312013-04-27 Kenichi Handa <handa@gnu.org>
4632
4633 * font.c (font_open_entity): Always open a font of manageable
4634 size.
4635
13d0e56f 46362013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4637
f780d632
PE
4638 Port better to AIX (Bug#14258).
4639 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4640 to pacify AIX xlc.
4641
ec509856
KH
46422013-04-24 Kenichi Handa <handa@gnu.org>
4643
4644 * coding.c (decode_coding_iso_2022): When an invalid escape
4645 sequence is encountered, reset the invocation and designation
4646 status to the safest one.
4647
84fc48e5
PE
46482013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4649
4650 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4651 Without this fix, "make distclean" leaves stamp-h1 behind.
4652
806bda47
EC
46532013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4654
4655 * w32fns.c (w32_fullscreen_rect): New function to compute the
4656 window rectangle for the given fullscreen mode.
4657 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4658 longer tunes the window size. This keeps the window's edges flush
4659 with the screen and allows the taskbar to hide itself in fullboth.
4660
4661 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4662 window decorations and uses the entire screen.
4663
4664 * w32term.h (w32_fullscreen_rect) Add prototype.
4665 (struct w32_output): Replace normal_width, normal_height,
4666 normal_top, and normal_left members with a single normal_placement
4667 struct.
4668 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4669 Remove macros.
4670 (FRAME_NORMAL_PLACEMENT): New macro.
4671
9cc2810b
JB
46722013-04-16 Juanma Barranquero <lekktu@gmail.com>
4673
4674 * minibuf.c (Ftest_completion): Silence compiler warning.
4675
fd16b54c
EZ
46762013-04-15 Eli Zaretskii <eliz@gnu.org>
4677
4678 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4679 bug#14062.
fd16b54c
EZ
4680
4681 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4682 parentheses.
4683
4684 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4685 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4686 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4687 parentheses where appropriate.
4688
9e3379a0
PE
46892013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4690
4691 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4692
ddd6b685
EZ
46932013-04-14 Eli Zaretskii <eliz@gnu.org>
4694
4695 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4696 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4697 Mention in the doc string that setting these variables takes
4698 effect only after a call to set-window-buffer. (Bug#14200)
4699
29b79ba1
EZ
47002013-04-13 Eli Zaretskii <eliz@gnu.org>
4701
4702 * indent.c (Fvertical_motion): Don't consider display strings on
4703 overlay strings as display strings on the buffer position we
4704 started from. This prevents vertical cursor motion from jumping
4705 more than one line when there's an overlay string with a display
4706 property at end of line.
4707 Reported by Karl Chen <Karl.Chen@quarl.org> in
4708 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4709
562c6ee9
SM
47102013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4711
4712 * window.c (select_window): `record_buffer' even if window is
4713 already selected (bug#14191).
4714
fcc1fe85
EZ
47152013-04-11 Eli Zaretskii <eliz@gnu.org>
4716
4717 * window.c (Fwindow_end): Test more flags, including the buffer's
4718 last_overlay_modified flag, to determine whether the window's
4719 display is really up-to-date. Prevents the function from
4720 returning a stale value. (Bug#14170)
4721 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4722 current matrix.
4723
f009190a
EZ
47242013-04-10 Eli Zaretskii <eliz@gnu.org>
4725
4726 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4727 garbaged only if it is not already the top frame on its TTY.
4728 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4729 there are GUI frames open in the same session. (Bug#13864)
4730
78ce603d
SM
47312013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4732
4733 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4734 of marking the idle timers directly.
4735
a8036e40
SM
47362013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4737
4738 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4739 tables (bug#14054).
4740
7ffe7ef6
SM
47412013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4742
4743 * window.c (select_window): Don't record_buffer while the invariant is
4744 temporarily broken (bug#14161).
4745
4746 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4747
7d9f6883
EZ
47482013-04-07 Eli Zaretskii <eliz@gnu.org>
4749
4750 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4751
5406cfd9
RF
47522013-04-07 Romain Francoise <romain@orebokech.com>
4753
4754 Ignore additional platform-specific ACL errors (Bug#13702).
4755 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4756 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4757
95c0e83b
JD
47582013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4759
4760 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4761 f->output_data.ns.
4762
876da980
PE
47632013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4764
4765 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4766 This bug was introduced by my 2013-02-25 change that simplified
4767 data_start configuration. Without this change, on GNU/Linux
4768 an Emacs configured with --enable-profiling fails immediately
4769 due to a profiler signal.
4770 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4771 with these flags. On platforms where special flags are needed
4772 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4773 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4774 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4775
7452b7bd
DA
47762013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4777
4778 Get rid of some platform-specific functions examining window
4779 system and its capabilities. This is a partial rework of the
4780 2013-04-05 change.
4781 * lisp.h (have_menus_p): Remove prototype. This function is
4782 replaced with platform-independent window_system_available.
4783 (check_window_system): Move to...
4784 * frame.h (decode_window_system_frame, window_system_available):
4785 ...here, add new prototypes.
4786 * frame.c (window_system_available, decode_window_system_frame):
4787 New functions.
4788 (check_window_system): Platform-independent now.
4789 * xterm.h (x_in_use): Remove declaration.
4790 (check_x_frame):
4791 * w32term.h (check_x_frame):
4792 * nsterm.h (check_x_frame): Remove prototypes. This function
4793 is replaced with platform-independent decode_window_system_frame.
4794 * msdos.c (have_menus_p): Remove.
4795 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4796 Remove platform-specific functions. Use check_window_system,
4797 decode_window_system_frame and check_ns_display_info where
4798 appropriate. Minor style and comment tweaks.
4799 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4800 (check_x_frame): Likewise.
4801 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4802 Likewise.
4803 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4804 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4805 * xmenu.c, xselect.c: All related users changed.
4806
251e9147
KH
48072013-04-03 Kenichi Handa <handa@gnu.org>
4808
4809 The following changes is to optimize the code for reading UTF-8
4810 files.
4811
562c6ee9 4812 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4813 changed. Check EOL format. Do not call adjust_coding_eol_type
4814 here.
4815 (check_utf_8): New function.
4816 (adjust_coding_eol_type): Do nothing if already adjusted.
4817 (detect_coding): Compare the return value of check_ascii with
4818 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4819 (decode_coding_gap): Optimize for valid UTF-8.
4820
8bc369d4
KH
48212013-03-21 Kenichi Handa <handa@gnu.org>
4822
4823 * coding.c (syms_of_coding): Cancel previous change.
4824
4825 * insdel.c (insert_from_gap): Fix previous change.
4826
73931ad1
DA
48272013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4828
4829 Consistently use platform-specific function to detect window system.
4830 * lisp.h (check_window_system): New prototype. This function is
4831 going to replace check_x, check_w32 and check_ns.
4832 (have_menus_p): Mention msdos.c in comment.
4833 * fontset.c (check_window_system_func): Remove. Adjust all users.
4834 * fontset.h (check_window_system_func): Remove prototype.
4835 * nsterm.h (check_ns):
4836 * xterm.h (check_x):
4837 * w32term.h (check_w32): Likewise.
4838 * menu.c (Fx_popup_menu): Use check_window_system.
4839 * msdos.c (check_window_system): Define for MS-DOS.
4840 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4841 * w32fns.c (check_window_system): Likewise for MS-Windows.
4842 * xfns.c (check_window_system): Likewise for X.
4843 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4844 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4845
7216e43b
PE
48462013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4847
4848 Prefer < to > in range checks such as 0 <= i && i < N.
4849 This makes it easier to visualize quantities on a number line.
4850 This patch doesn't apply to all such range checks,
4851 only to the range checks affected by the 2013-03-24 change.
4852 This patch reverts most of the 2013-03-24 change.
4853 * alloc.c (xpalloc, Fgarbage_collect):
4854 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4855 * character.c (string_escape_byte8):
4856 * charset.c (read_hex):
4857 * data.c (cons_to_unsigned):
4858 * dispnew.c (update_frame_1):
4859 * doc.c (Fsubstitute_command_keys):
4860 * doprnt.c (doprnt):
4861 * editfns.c (hi_time, decode_time_components):
4862 * fileio.c (file_offset):
4863 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4864 * font.c (font_intern_prop):
4865 * frame.c (x_set_alpha):
4866 * gtkutil.c (get_utf8_string):
4867 * indent.c (check_display_width):
4868 * keymap.c (Fkey_description):
4869 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4870 * lread.c (read1):
4871 * minibuf.c (read_minibuf_noninteractive):
4872 * process.c (wait_reading_process_output):
4873 * search.c (Freplace_match):
4874 * window.c (get_phys_cursor_glyph):
4875 * xdisp.c (redisplay_internal):
4876 * xsmfns.c (smc_save_yourself_CB):
4877 Prefer < to > for range checks.
4878 * dispnew.c (sit_for): Don't mishandle NaNs.
4879 This fixes a bug introduced in the 2013-03-24 change.
4880 * editfns.c (decode_time_components): Don't hoist comparison.
4881 This fixes another bug introduced in the 2013-03-24 change.
4882
92759988
DA
48832013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4884
4885 * frame.h (struct frame): Drop scroll_bottom_vpos
4886 member becaue all real users are dead long ago.
4887 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4888 * xdisp.c (redisplay_internal): Adjust user.
4889
9a1971bb
GM
48902013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4891
f38ab167
JD
4892 * nsmenu.m (showAtX:Y:for:): setLevel to
4893 NSPopUpMenuWindowLevel (Bug#13998).
4894
6d01f1fe
JD
48952013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4896
4897 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4898 (ns_check_pending_open_menu): Declare.
4899
4900 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4901 (x_activate_menubar): Update the menu with title that matches
4902 ns_get_pending_menu_title, and call
4903 ns_check_pending_openmenu (Bug#12698).
4904 (menuWillOpen:): New method.
4905 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4906
4907 * nsterm.m (menu_will_open_state, menu_mouse_point)
4908 (menu_pending_title): New varaibles.
4909 (ns_get_pending_menu_title, ns_check_menu_open)
4910 (ns_check_pending_open_menu): New functions.
4911
781f4782
DA
49122013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4913
4914 * indent.c (current_column_bol_cache): Remove leftover which is not
4915 used in Fmove_to_column any more.
4916 (current_column, scan_for_column): Adjust users.
4917 * keyboard.c (last_point_position_buffer, last_point_position_window):
4918 Remove leftovers which are not used for recording undo any more.
4919 (command_loop_1, syms_of_keyboard): Adjust users.
4920 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4921 redisplay_window any more.
4922 (move_it_to): Adjust user.
4923
1921c31b
JB
49242013-03-29 Juanma Barranquero <lekktu@gmail.com>
4925
4926 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4927 Update dependencies.
4928
717b8bcd
SM
49292013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4930
4931 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4932 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4933 forward references.
4934
e74aeda8
DA
49352013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4936
4937 * window.h (struct window): Replace hchild, vchild and buffer slots
4938 with the only contents slot. This is possible because each valid
4939 window may have either the child window (in vertical or horizontal
4940 combination) or buffer to display (for the leaf window). Using that,
4941 a lof of operations to traverse and/or change window hierarchies may
4942 be simplified. New member horizontal is used to distinguish between
4943 horizontal and vertical combinations of internal windows.
4944 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4945 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4946 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4947 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4948 Use contents slot, not buffer, where appropriate.
4949 (wset_combination): New function.
4950 (wset_buffer): Add eassert.
4951 (Fframe_first_window): Simplify the loop reaching first window.
4952 (Fwindow_buffer): Use WINDOW_LEAF_P.
4953 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4954 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4955 (unshow_buffer): Convert initial debugging check to eassert.
4956 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4957 (make_parent_window, window_resize_check, window_resize_apply)
4958 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4959 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4960 Adjust to match struct window changes.
4961 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4962 (mark_window_cursors_off, count_windows, get_leaf_windows)
4963 (foreach_window_1): Simplify the loop.
4964 * alloc.c (mark_object): Do not check for the leaf window because
4965 internal windows has no glyph matrices anyway.
4966 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4967 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4968 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4969 (build_frame_matrix_from_window_tree, mirror_make_current)
4970 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4971 (update_window_tree, set_window_update_flags): Simplify the loop.
4972 (sync_window_with_frame_matrix_rows): Enforce live window.
4973 Use contents slot, not buffer, where appropriate.
4974 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4975 and WINDOW_HORIZONTAL_COMBINATION_P.
4976 (make_frame_visible_1): Simplify the loop.
4977 Use contents slot, not buffer, where appropriate.
4978 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4979 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4980 (expose_window_tree): Likewise.
4981 Use contents slot, not buffer, where appropriate.
4982 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4983 to avoid deleted windows. Use contents slot instead of buffer.
4984 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4985 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4986 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4987 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4988
121ab1cd
EZ
49892013-03-28 Eli Zaretskii <eliz@gnu.org>
4990
ef454cf7
EZ
4991 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4992 identify the reasons for assertion violations in bug#14062 and
4993 similar ones.
21e930f8
EZ
4994 (Fx_show_tip): Fix compilation error under
4995 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4996
121ab1cd
EZ
4997 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4998 Reported by <rzl24ozi@gmail.com>.
4999
5c89ca24
DA
50002013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5001
5002 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5003 start marker...
562c6ee9
SM
5004 (unwind_with_echo_area_buffer): ...to restore it here.
5005 This is needed to ensure that...
5c89ca24
DA
5006 (redisplay_window): ...both window markers are valid here,
5007 which is verified by eassert.
5008 * editfns.c (save_excursion_save): Do not assume that
5009 selected_window always displays the buffer.
c7f53895
DA
5010 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5011 Fix comment.
5c89ca24 5012
f557c1b1
SM
50132013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5014
5015 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5016 the upcase table.
5017
40693bba 50182013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5019
5020 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5021
c86f791f
EZ
50222013-03-27 Eli Zaretskii <eliz@gnu.org>
5023
5024 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5025 since MinGW's w32api headers do. This avoids compiler warnings.
5026
5027 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5028 if already defined.
5029
c6e72e17
EZ
50302013-03-26 Eli Zaretskii <eliz@gnu.org>
5031
5032 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5033
54e95010
JD
50342013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5035
5036 * gtkutil.c (style_changed_cb): Check if frame is live and an
5037 X frame (Bug#14038).
5038
b88b62de
EZ
50392013-03-26 Eli Zaretskii <eliz@gnu.org>
5040
a18d7de6
EZ
5041 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5042 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5043 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5044 MinGW64.
8f5e14c8
EZ
5045 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5046 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5047
b88b62de
EZ
5048 Fix incompatibilities between MinGW.org and MinGW64 headers.
5049 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5050
5051 * w32.c (REPARSE_DATA_BUFFER): Guard with
5052 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5053
c074e458
JD
50542013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5055
5056 * xterm.c: Include X11/XKBlib.h
5057 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5058
908589fd
AS
50592013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5060
5061 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5062 written backwards.
5063 * blockinput.h (input_blocked_p): Likewise.
5064 * bytecode.c (exec_byte_code): Likewise.
5065 * callproc.c (call_process_kill, call_process_cleanup)
5066 (Fcall_process): Likewise.
5067 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5068 (Fccl_execute_on_string): Likewise.
5069 * character.c (string_escape_byte8): Likewise.
5070 * charset.c (read_hex): Likewise.
5071 * cm.c (calccost): Likewise.
5072 * data.c (cons_to_unsigned): Likewise.
5073 * dired.c (directory_files_internal, file_name_completion):
5074 Likewise.
5075 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5076 (sit_for): Likewise.
5077 * doc.c (Fsubstitute_command_keys): Likewise.
5078 * doprnt.c (doprnt): Likewise.
5079 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5080 * emacsgtkfixed.c: Likewise.
5081 * fileio.c (file_offset, Fwrite_region): Likewise.
5082 * floatfns.c (Fexpt, fmod_float): Likewise.
5083 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5084 Likewise.
5085 * font.c (font_intern_prop): Likewise.
5086 * frame.c (x_set_alpha): Likewise.
5087 * gtkutil.c (get_utf8_string): Likewise.
5088 * indent.c (check_display_width): Likewise.
5089 * intervals.c (create_root_interval, rotate_right, rotate_left)
5090 (split_interval_right, split_interval_left)
5091 (adjust_intervals_for_insertion, delete_node)
5092 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5093 (merge_interval_right, merge_interval_left, copy_intervals)
5094 (set_intervals_multibyte_1): Likewise.
5095 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5096 * keymap.c (Fkey_description): Likewise.
5097 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5098 * lread.c (openp, read_integer, read1, string_to_number):
5099 Likewise.
5100 * menu.c (ensure_menu_items): Likewise.
5101 * minibuf.c (read_minibuf_noninteractive): Likewise.
5102 * print.c (printchar, strout): Likewise.
5103 * process.c (create_process, Faccept_process_output)
5104 (wait_reading_process_output, read_process_output, send_process)
5105 (wait_reading_process_output): Likewise.
5106 * profiler.c (make_log, handle_profiler_signal): Likewise.
5107 * regex.c (re_exec): Likewise.
5108 * regex.h: Likewise.
5109 * search.c (looking_at_1, Freplace_match): Likewise.
5110 * sysdep.c (get_child_status, procfs_ttyname)
5111 (procfs_get_total_memory): Likewise.
5112 * systime.h (EMACS_TIME_VALID_P): Likewise.
5113 * term.c (dissociate_if_controlling_tty): Likewise.
5114 * window.c (get_phys_cursor_glyph): Likewise.
5115 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5116 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5117 Likewise.
5118 * xfns.c (Fx_window_property): Likewise.
5119 * xmenu.c (set_frame_menubar): Likewise.
5120 * xselect.c (x_get_window_property, x_handle_dnd_message):
5121 Likewise.
5122 * xsmfns.c (smc_save_yourself_CB): Likewise.
5123 * xterm.c (x_scroll_bar_set_handle): Likewise.
5124
2bf7d27a
DA
51252013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5126
5127 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5128 to be optional or nil. Adjust comment and convert it to docstring.
5129 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5130 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5131
a9ebfa0b
PE
51322013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5133
5134 Static checking by GCC 4.8-20130319.
5135 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5136 * process.c (Fset_process_datagram_address)
5137 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5138 * xdisp.c (get_char_face_and_encoding):
5139 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5140 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5141 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5142
4f3576ee
KB
51432013-03-24 Ken Brown <kbrown@cornell.edu>
5144
789b5e9a
KB
5145 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5146 fix compilation on 64-bit Cygwin, where underscores are not
5147 automatically prepended.
5148
4f3576ee
KB
5149 * w32term.c (w32_initialize): Silence compiler warning.
5150
b5b7745f
EZ
51512013-03-23 Eli Zaretskii <eliz@gnu.org>
5152
cdc0d0bd
EZ
5153 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5154 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5155 variables, to save and restore frame dimensions.
5156 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5157 after returning from a 'fullscreen' configuration.
5158 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5159 to avoid races between the main thread and the input thread.
5160
5161 * w32term.h (struct w32_output): New members normal_width,
5162 normal_height, normal_top, normal_left, and prev_fsmode.
5163 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5164 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5165 members of a frame.
5166
b5b7745f
EZ
5167 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5168 'fullscreen' parameter. Always record previous width and height
5169 of the frame, except when switching out of maximized modes, so
5170 that they could be restored correctly, instead of resetting to the
5171 default frame dimensions. Send SC_RESTORE command to the frame,
5172 unless we are going to send SC_MAXIMIZE, to restore the frame
5173 resize hints in the mouse pointer shown by the window manager.
5174 (Bug#14032)
5175
5176 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5177
5178 * lisp.h (get_frame_param): Adjust conditions for prototype
5179 declaration.
5180
a3454eed
KB
51812013-03-22 Ken Brown <kbrown@cornell.edu>
5182
5183 * unexcw.c: Drop unneeded inclusion of w32common.h.
5184 (report_sheap_usage): Declare.
5185 (read_exe_header): Add magic numbers for x86_64.
5186 (fixup_executable): Fix printf format specifier for unsigned long
5187 argument.
5188
5a49b79c
DA
51892013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5190
5191 * frame.h (struct frame): Put menu_bar_window under #ifdef
5192 because this member is not needed when X toolkit is in use.
5193 (fset_menu_bar_window):
5194 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5195 (free_glyphs, update_frame):
5196 * xdisp.c (expose_frame): Likewise.
5197 (display_menu_bar): Likewise. Remove redundant eassert.
5198 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5199 toolkit is in use.
5200
d6723bf7
PE
52012013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5202
7b1123d8
PE
5203 Use functions and constants to manipulate Lisp_Save_Value objects.
5204 This replaces code that used macros and strings and token-pasting.
5205 The change makes the C source a bit easier to follow,
5206 and shrinks the Emacs executable a bit.
5207 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5208 (make_save_value): Change 1st arg from string to enum. All callers
5209 changed.
5210 (INTX): Remove.
5211 (mark_object): Use if, not #if, for GC_MARK_STACK.
5212 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5213 (XSAVE_OBJECT): Now functions, not macros.
5214 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5215 the constant was never used.
5216 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5217 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5218 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5219 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5220 New constants.
5221 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5222 type3 with a single member save_type. All uses changed.
5223 (save_type, set_save_pointer, set_save_integer): New functions.
5224 * print.c (PRINTX): Remove.
5225
d6723bf7
PE
5226 * alloc.c: Remove redundant static declarations.
5227
5f24fa51
DA
52282013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5229
5230 * window.h (struct window): Convert left_col, top_line, total_lines
5231 and total_cols from Lisp_Objects to integers. Adjust comments.
5232 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5233 Remove.
5234 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5235 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5236 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5237 Adjust users where appropriate.
5238
42143acd
DA
52392013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5240
5241 * frame.h (struct frame): Drop resx and resy because the same data is
5242 available from window system-specific output context. Adjust users.
562c6ee9
SM
5243 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5244 New functions to provide defaults when no window system available.
42143acd 5245 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5246 (NUMVAL): Move from xdisp.c.
42143acd
DA
5247 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5248 (Ffont_face_attributes, Fopen_font):
5249 * image.c (gs_load):
5250 * w32font.c (fill_in_logfont):
5251 * xdisp.c (calc_pixel_width_or_height):
5252 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5253 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5254
c0a17406
KH
52552013-03-20 Kenichi Handa <handa@gnu.org>
5256
5257 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5258 to 1 (temporary workaround until a bug related to ASCII
5259 optimization is fixed).
5260
095d384d
DA
52612013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5262
5263 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5264 Signal error if window is not internal. Adjust docstring.
5265 (delete_all_child_windows): Use combination_limit to save the buffer.
5266 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5267 * print.c (syms_of_print): Initialize debugging output not here...
5268 (init_print_once): ...but in a new function here.
5269 * lisp.h (init_print_once): Add prototype.
5270 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5271
748fa866
DA
52722013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5273
5274 * window.c (window_resize_check, window_resize_apply)
5275 (window_from_coordinates, recombine_windows, set_window_buffer)
5276 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5277 (Fsplit_window_internal, Fdelete_window_internal)
5278 (freeze_window_starts): Use bool for booleans.
5279 * window.h (window_frame_coordinates, resize_frame_windows)
5280 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5281
81519fd2
SM
52822013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5283
5284 * dispnew.c (bitch_at_user): Use `user-error'.
5285
6db423a9
KB
52862013-03-17 Ken Brown <kbrown@cornell.edu>
5287
5288 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5289 as return type of image_background. (Bug#13981)
5290 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5291
8f2906f5
JD
52922013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5293
960ce480 5294 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5295 (ns_select): Don't return with result uninitialized.
960ce480 5296
8f2906f5
JD
5297 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5298 and getDirectory.
5299
81519fd2
SM
5300 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5301 New functions.
8f2906f5
JD
5302 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5303 directories. If filename is nil, get directory name (Bug#13932).
5304 Use getFilename and getDirectory.
5305 (getFilename, getDirectory): New methods for EmacsSavePanel and
5306 EmacsOpenPanel.
5307 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5308
cded56c1
PE
53092013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5310
5311 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5312
251e9147 53132013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5314
5315 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5316 (adjust_after_replace): Make it back to static. Delete the third
5317 arg text_at_gap_tail. Cancel the code for handling it.
5318
5319 * coding.h (struct coding_system): New member eol_seen.
5320
5321 * coding.c (detect_ascii): New function.
5322 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5323 when the source bytes are actually scanned. On detecting for
5324 coding_category_utf_8_auto, call detect_ascii instead of scanning
5325 source bytes directly.
5326 (produce_chars): Call insert_from_gap with the new arg 0.
5327 (encode_coding): Likewise.
5328 (decode_coding_gap): Control ASCII optimization by the variable
5329 disable_ascii_optimization instead of #ifndef .. #endif.
5330 Deccode EOL format according to coding->eol_seen.
5331 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5332 variable.
5333
8a44e6d1
KH
5334 * lisp.h (adjust_after_replace): Cancel externing it.
5335 (insert_from_gap): Adjust prototype.
5336
5f795e34
EZ
53372013-03-15 Eli Zaretskii <eliz@gnu.org>
5338
5339 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5340 FULLSCREEN_MAXIMIZED. (Bug#13935)
5341
f258b4be
DA
53422013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5343
5344 * region-cache.c (find_cache_boundary, move_cache_gap)
5345 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5346 Simplify debugging check and convert to eassert. Adjust comment.
5347 (pp_cache): Put under ENABLE_CHECKING.
5348
a5cc4dde
EZ
53492013-03-14 Eli Zaretskii <eliz@gnu.org>
5350
5351 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5352 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5353 and WM_ACTIVATEAPP.
5354 (w32fullscreen_hook): If the frame is visible, reset
5355 f->want_fullscreen flag after changing the frame size. If the
5356 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5357 (Bug#13953)
5358
3fc5e44a
DC
53592013-03-13 Daniel Colascione <dancol@dancol.org>
5360
5361 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5362 too so that these builds can use Cygwin's file conversion
5363 functions. (We've been building and linking cygw32.o all along
5364 and just not using it.)
5365
47d7532e
PE
53662013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5367
5368 File synchronization fixes (Bug#13944).
5369 * Makefile.in (LIB_FDATASYNC): New macro.
5370 (LIBES): Use it.
5371 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5372 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5373 Don't worry about HAVE_FSYNC, since a substitute fsync is
5374 available if the system lacks one.
5375 (Fwrite_regin): Retry fsync if interrupted.
5376
c7ffccaf
EZ
53772013-03-13 Eli Zaretskii <eliz@gnu.org>
5378
4e2df81d 5379 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5380 activated, call w32fullscreen_hook, to make sure the new frame
5381 dimensions are in effect. (Bug#13937)
5382
8a7debc1
DA
53832013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5384
5385 * xdisp.c (init_iterator): Simplify because both character and byte
5386 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5387 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5388 character and byte positions can be obtained from marker.
8a7debc1 5389
7fd8c501
PE
53902013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5391
d9df6f40
PE
5392 Static checking by Sun C 5.12.
5393 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5394 * bytecode.c (exec_byte_code):
5395 * dispnew.c (init_display):
5396 * eval.c (error):
5397 * fileio.c (Fsubstitute_in_file_name):
5398 * keyboard.c (Fevent_convert_list):
5399 * keymap.c (Fsingle_key_description):
5400 * term.c (maybe_fatal, fatal):
5401 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5402 * xsmfns.c (Fhandle_save_session):
5403 Omit unreachable code.
5404 * keymap.c (map_keymap_char_table_item): Cast void * to
5405 a function pointer type; the C Standard requires this.
5406
7fd8c501
PE
5407 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5408 Include <sys/param.h> unconditionally, as that works elsewhere and
5409 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5410 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5411 and FreeBSD now.
5412
a020afb9 5413See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5414
5415;; Local Variables:
5416;; coding: utf-8
aac0c6e3
MR
5417;; End:
5418
ab422c4d 5419 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5420
5421 This file is part of GNU Emacs.
5422
5423 GNU Emacs is free software: you can redistribute it and/or modify
5424 it under the terms of the GNU General Public License as published by
5425 the Free Software Foundation, either version 3 of the License, or
5426 (at your option) any later version.
5427
5428 GNU Emacs is distributed in the hope that it will be useful,
5429 but WITHOUT ANY WARRANTY; without even the implied warranty of
5430 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5431 GNU General Public License for more details.
5432
5433 You should have received a copy of the GNU General Public License
5434 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.