Fix minor problems in text-mode menu display.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9f6a18d2
EZ
12013-10-09 Eli Zaretskii <eliz@gnu.org>
2
3 * term.c (tty_menu_activate): Flush the output stream after
4 showing the cursor, and don't mark the frame garbaged at exit from
5 the function. Fixes redisplay glitches when moving from one menu
6 to another.
7
0486beac
JD
82013-10-09 Jan Djärv <jan.h.d@swipnet.se>
9
10 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Check input for valid UTF-8
11 or throw error (Bug#15570).
12
0d5d3029
PE
132013-10-09 Paul Eggert <eggert@cs.ucla.edu>
14
ab7ce978
PE
15 * intervals.c (temp_set_point_both): Move test into 'eassert',
16 for speed.
17
0d5d3029
PE
18 * lisp.h (eassert): Don't use 'assume'.
19 Sometimes 'assume' wins in performance, and sometimes it loses,
20 so it shouldn't be used all the time. Perhaps we need two
21 flavors of 'eassert', one for where 'assume' is far more likely
22 to help or to hurt; but that can be done later.
23 Problem reported by Dmitry Andipov in
24 <http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00276.html>.
25 Also, don't include <verify.h>; no longer needed.
26
fa022909
GM
272013-10-09 Glenn Morris <rgm@gnu.org>
28
29 * eval.c (Fcond): Doc tweak.
30
051277bf
EZ
312013-10-09 Eli Zaretskii <eliz@gnu.org>
32
33 * xfaces.c (x_free_gc) [HAVE_X_WINDOWS, HAVE_NTGUI]: Don't pass
34 expressions with side effects to eassert. (Bug#15565)
35
79804536
SM
362013-10-09 Stefan Monnier <monnier@iro.umontreal.ca>
37
38 * fns.c (hashfn_user_defined): Allow hash functions to return any
39 Lisp_Object.
40
3b158d11
PE
412013-10-08 Paul Eggert <eggert@cs.ucla.edu>
42
43 Fix minor problems found by static checking.
44 * dispnew.c (save_current_matrix): Omit unnecessary casts.
45 * dispnew.c (update_frame_with_menu): Mark debug local as used.
46 * keyboard.c, keyboard.h (Qmouse_movement): Now static.
47 * keyboard.c (read_menu_command): Remove unused local.
48 * lisp.h (read_menu_command): New decl.
49 * menu.c, menu.h (menu_item_width): Arg is now unsigned char *, for
50 benefit of STRING_CHAR_AND_LENGTH. All uses changed.
51 Return ptrdiff_t, not int.
52 * term.c (tty_menu_struct): 'allocated' member is now ptrdiff_t,
53 not int, for benefit of xpalloc.
54 (tty_menu_create, tty_menu_make_room): Simplify by using xzalloc
55 and xpalloc.
56 (have_menus_p): Remove; unused.
57 (tty_menu_add_pane, tty_menu_add_selection): Change signedness of
58 local char * pointer to pacify STRING_CHAR_AND_LENGTH.
59 (tty_menu_add_selection, tty_menu_locate, tty_meny_destroy):
60 Now static.
61 (save_and_enable_current_matrix): Omit unnecessary casts.
62 (read_menu_input): Omit local extern decl (now in lisp.h).
63 Don't access uninitialized storage if mouse_get_xy fails.
64 (tty_menu_activate): Mark local as initialized, for lint.
65 (tty_menu_activate, tty_meny_show): Remove unused locals.
66
4ed77415
EZ
672013-10-08 Eli Zaretskii <eliz@gnu.org>
68
69 Support menus on text-mode terminals.
70 * xterm.h (xw_popup_dialog): Add prototype.
71
72 * xmenu.c (Fx_popup_dialog): Function moved to menu.c.
73 (xmenu_show): Block input here, instead in Fx_popup_menu.
74 (xw_popup_dialog): New function, with X-specific bits of popup
75 dialogs.
76
77 * xdisp.c (deep_copy_glyph_row, display_tty_menu_item): New
78 functions.
79
80 * window.c (Fset_window_configuration): Use run-time tests of the
81 frame type instead of compile-time conditionals, when menu-bar
82 lines are considered.
83
84 * w32term.h (w32con_hide_cursor, w32con_show_cursor)
85 (w32_popup_dialog): New prototypes.
86
87 * w32menu.c (Fx_popup_dialog): Function deleted.
88 (w32_popup_dialog): New function, with w32 specific bits of popup
89 dialogs. Block input here.
90
91 * w32inevt.c (w32_console_read_socket): Minor change to add
92 debugging TTY events.
93
94 * w32fns.c (show_hourglass): If returning early because the frame
95 is not a GUI frame, unblock input.
96
97 * w32console.c (w32con_hide_cursor, w32con_show_cursor, cursorX)
98 (cursorY): New functions.
99
100 * termhooks.h (cursorX, cursorY): Prototypes of functions on
101 WINDOWSNT, macros that call curX and curY elsewhere.
102
103 * termchar.h (struct tty_display_info) <showing_menu>: New flag.
104
105 * term.c (tty_hide_cursor, tty_show_cursor) [WINDOWSNT]: Call w32
106 specific function to hide and show cursor on a text-mode terminal.
107 (tty_menu_struct, struct tty_menu_state): New structures.
108 (tty_menu_create, tty_menu_make_room, tty_menu_search_pane)
109 (tty_menu_calc_size, mouse_get_xy, tty_menu_display)
110 (have_menus_p, tty_menu_add_pane, tty_menu_add_selection)
111 (tty_menu_locate, save_and_enable_current_matrix)
112 (restore_desired_matrix, screen_update, read_menu_input)
113 (tty_menu_activate, tty_menu_destroy, tty_menu_help_callback)
114 (tty_pop_down_menu, tty_menu_last_menubar_item)
115 (tty_menu_new_item_coords, tty_menu_show): New functions.
116 (syms_of_term): New DEFSYMs for tty-menu-* symbols.
117
118 * nsterm.h (ns_popup_dialog): Adjust prototype.
119
120 * nsmenu.m (ns_menu_show): Block and unblock input here, instead
121 of in x-popup-menu.
122 (ns_popup_dialog): Adapt order of arguments to the other
123 *_menu_show implementations.
124 (Fx_popup_dialog): Function deleted.
125
126 * msdos.c (x_set_menu_bar_lines): Delete unused function.
127
128 * menu.h (tty_menu_show, menu_item_width): provide prototypes.
129
130 * menu.c (have_boxes): New function.
131 (single_keymap_panes): Use it instead of a compile-time
132 conditional.
133 (single_menu_item): Use run-time tests of the frame type instead
134 of compile-time conditionals.
135 (encode_menu_string): New function.
136 (list_of_items, list_of_panes): Use it instead of ENCODE_STRING
137 the macro, since different types of frame need different encoding
138 of menu items.
139 (digest_single_submenu): Use run-time tests of frame type instead
140 of, or in addition to, compile-time conditionals.
141 (menu_item_width, Fmenu_bar_menu_at_x_y): New functions.
142 (Fx_popup_menu): Detect when the function is called from keyboard
143 on a TTY. Don't barf when invoked on a text-mode frame. Check
144 frame type at run time, instead of compile-time conditionals for
145 invoking terminal-specific menu-show functions. Call
146 tty_menu_show on text-mode frames.
147 (Fx_popup_dialog): Moved here from xmenu.c. Test frame types at
148 run time to determine which alternative to invoke; support dialogs
149 on TTYs.
150
151 * keyboard.h <Qmouse_movement>: Declare.
152
153 * keyboard.c <Qmouse_movement>: Now extern.
154 <Qecho_keystrokes>: New static variable.
155 (read_key_sequence): Accept an additional argument, a flag to
156 prevent redisplay during reading of the key sequence. All callers
157 changed.
158 (read_menu_command): New function.
159 (read_char): When COMMANDFLAG is -2, do not redisplay and do not
160 autosave.
161 (toolkit_menubar_in_use): New function.
162 (make_lispy_event): Use it instead of a compile-time test.
163
164 * fns.c (Fyes_or_no_p) [HAVE_MENUS]: Don't condition on
165 window-system being available.
166
167 * editfns.c (Fmessage_box) [HAVE_MENUS]: Don't condition the call
168 to x-popup-dialog on the frame type, they all now support popup
169 dialogs.
170
171 * dispnew.c (save_current_matrix): Save the margin areas.
172 (restore_current_matrix): Restore margin areas.
173 (update_frame_with_menu): New function.
174
175 * dispextern.h (display_tty_menu_item, update_frame_with_menu):
176 Add prototypes.
177
178 * alloc.c (make_save_ptr): Now compiled unconditionally.
179
ecab13d4
DA
1802013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
181
182 * dispnew.c (set_window_update_flags): Add buffer arg. Adjust comment.
183 (redraw_frame, update_frame): Adjust users.
184 * dispextern.h (set_window_update_flags): Adjust prototype.
185 * xdisp.c (redisplay_internal): When updating all frames with zero
186 windows_or_buffers_changed, assume that only the windows that shows
187 current buffer should be really updated.
188
f8498081
DA
1892013-10-08 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Do not allocate huge temporary memory areas and objects while encoding
192 for file I/O, thus reducing an enormous memory usage for large buffers.
193 See http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00180.html.
194 * coding.h (struct coding_system): New member raw_destination.
195 * coding.c (setup_coding_system): Initialize it to zero.
196 (encode_coding_object): If raw_destination is set, do not create
197 dst_object. Add comment.
198 * fileio.c (toplevel): New constant E_WRITE_MAX.
199 (e_write): Do not encode more than E_WRITE_MAX characters per one loop
200 iteration. Use raw_destination if E_WRITE_MAX characters is encoded.
201
d180bde8
JD
2022013-10-08 Jan Djärv <jan.h.d@swipnet.se>
203
204 * nsterm.m (windowDidExitFullScreen:):
205 (toggleFullScreen:): Change NS_IMPL_COCOA to HAVE_NATIVE_FS.
206
87c4314d
PE
2072013-10-08 Paul Eggert <eggert@cs.ucla.edu>
208
18978362
PE
209 Fix race where emacs aborts when sent SIGTERM (Bug#15534).
210 * keyboard.c (unblock_input_to): Don't process pending signals
211 if a fatal error is in progress.
212
87c4314d
PE
213 * lisp.h (bits_word, BITS_WORD_MAX): New type and macro.
214 All uses of 'size_t' and 'SIZE_MAX' changed to use them, when
215 they're talking about words in Lisp bool vectors.
216 (BITS_PER_BITS_WORD): Rename from BITS_PER_SIZE_T. All uses changed.
1142cc2a
PE
217 * data.c (popcount_bits_word): Rename from popcount_size_t.
218 (bits_word_to_host_endian): Rename from size_t_to_host_endian.
219 All uses changed.
87c4314d 220
595e113b
PE
2212013-10-07 Paul Eggert <eggert@cs.ucla.edu>
222
223 Improve support for popcount and counting trailing zeros (Bug#15550).
224 * data.c: Include <count-one-bits.h>, <count-trailing-zeros.h>.
225 (USE_MSC_POPCOUNT, POPCOUNT_STATIC_INLINE)
226 (NEED_GENERIC_POPCOUNT, popcount_size_t_generic)
227 (popcount_size_t_msc, popcount_size_t_gcc):
228 Remove; now done by Gnulib.
229 (popcount_size_t): Now a macro that defers to Gnulib.
230 (count_trailing_zero_bits): Return int, for consistency with
231 Gnulib and because Emacs prefers signed to unsigned int.
232 Don't assume that size_t is either unsigned int or unsigned long
233 or unsigned long long.
234 (size_t_to_host_endian): Do not assume that size_t is either
235 exactly 32 or exactly 64 bits wide.
236 * lisp.h (BITS_PER_SIZE_T): Define consistently with BITS_PER_LONG
237 etc., so that it's now an enum constant, not a macro.
238 No need to assume that it's either 32 or 64.
239
ddb317ba
JD
2402013-10-07 Jan Djärv <jan.h.d@swipnet.se>
241
242 * nsterm.m (windowDidEnterFullScreen:): setPresentationOptions only
243 on >= 10.7.
244
bd74250f
DA
2452013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
246
247 * insdel.c (insert_from_gap): Prefer ptrdiff_t to int where needed.
764636db 248 * xdisp.c (handle_fontified_prop): Likewise. Use bool for boolean.
bd74250f 249
223752d7
PE
2502013-10-07 Paul Eggert <eggert@cs.ucla.edu>
251
252 emacs_read and emacs_write now use void *, not char *.
253 * alloc.c (valid_pointer_p) [!WINDOWSNT]: Remove now-unnecessary cast.
254 * sysdep.c (emacs_read, emacs_write, emacs_write_sig):
255 Buffer arg is now void *, not char *. This matches plain
256 'read' and 'write' better, and avoids a constraint violation
257 on Solaris 9 with Oracle Studio.
258
3c439e0a
DA
2592013-10-07 Dmitry Antipov <dmantipov@yandex.ru>
260
261 * alloc.c (Fmake_string): For ASCII char initializer, prefer
262 memset to explicit loop. Otherwise copy largest possible chunk
263 from initialized to uninitialized part, thus allowing the longer
264 memcpy runs and reducing the number of loop iterations.
265
28c76099
JD
2662013-10-06 Jan Djärv <jan.h.d@swipnet.se>
267
268 * nsterm.m (ns_update_begin): If native fullscreen and no toolbar,
269 hide toolbar (Bug#15388).
270 (windowDidEnterFullScreen:): If presentation options are zero,
271 set them here (Bug#15388).
a3e9050c
JD
272 (ns_update_auto_hide_menu_bar): Remove runtime check.
273 Don't auto hide dock unless menubar is also auto hidden.
28c76099 274
544a2a80
XF
2752013-10-05 Xue Fuqiao <xfq.free@gmail.com>
276
277 * editfns.c (message): Mention batch mode in doc string.
278
a27fd309
JD
2792013-10-05 Jan Djärv <jan.h.d@swipnet.se>
280
281 * nsterm.m (check_native_fs): Remove erroneous comment.
282
942f6f82
DA
2832013-10-04 Dmitry Antipov <dmantipov@yandex.ru>
284
285 * xdisp.c (redisplay_internal): Simplify because scan_for_column now
286 uses find_newline instead of scan_newline and so doesn't move point.
287
157fec2e
PE
2882013-10-04 Paul Eggert <eggert@cs.ucla.edu>
289
4eed3157
PE
290 Use hardware support for byteswapping on glibc x86 etc.
291 On Fedora 19 x86-64, the new bswap_64 needs 1 instruction,
292 whereas the old swap64 needed 30.
293 * fringe.c (init_fringe_bitmap) [WORDS_BIGENDIAN]:
294 * sound.c (le2hl, le2hs, be2hl) [!WINDOWSNT]:
295 Use byteswap.h's macros to swap bytes.
296 * lisp.h (swap16, swap32, swap64): Remove.
297 All uses replaced by bswap_16, bswap_32, bswap_64.
298
157fec2e
PE
299 * bytecode.c (exec_byte_code): Use some more volatile variables
300 to work around local variables getting clobbered by longjmp.
301 Port to pre-C99, which doesn't allow decls after stmts.
302
b52f569d
PE
3032013-10-03 Paul Eggert <eggert@cs.ucla.edu>
304
75273afb
PE
305 * lisp.h (eassert): Assume that COND is true when optimizing.
306 In other words, take on the behavior of eassert_and_assume.
307 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
308 (eassert_and_assume): Remove. All uses replaced by eassert.
309
ead45345
PE
310 * xdisp.c (Qglyphless_char): Now static.
311
0a858ebf
PE
312 Adjust to merge from gnulib.
313 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
314 * lisp.h: Include <verify.h>, for 'assume'.
315
b52f569d
PE
316 * eval.c (clobbered_eassert): New macro.
317 (internal_catch, internal_condition_case)
318 (internal_condition_case_1, internal_condition_case_2)
319 (internal_condition_case_n): Use it instead of eassert
320 when the argument contains locals clobbered by longjmp.
321 Don't use clobbered locals outside of clobbered_eassert.
322 (internal_lisp_condition_case): Use a volatile variable
323 to work around a local variable's getting clobbered.
324
adf2aa61
SM
3252013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
326
327 * lisp.h (struct handler): Merge struct handler and struct catchtag.
328 (PUSH_HANDLER): New macro.
329 (catchlist): Remove.
330 (handlerlist): Always declare.
331
332 * eval.c (catchlist): Remove (merge with handlerlist).
333 (handlerlist, lisp_eval_depth): Not static any more.
334 (internal_catch, internal_condition_case, internal_condition_case_1)
335 (internal_condition_case_2, internal_condition_case_n):
336 Use PUSH_HANDLER.
337 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
338 handlerlist/catchlist.
339 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
340 handlerlist which can only handle a single condition-case handler at
341 a time.
342 (find_handler_clause): Simplify since we only a single branch here
343 any more.
344
345 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
346 and Bpophandler.
347 (bcall0): New function.
348 (exec_byte_code): Add corresponding cases. Improve error message when
349 encountering an invalid byte-code. Let Bunwind_protect accept
350 a function (rather than a list of expressions) as argument.
351
352 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
353 and make them unconditional now that they're heap-allocated.
354
328a8179
SM
3552013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
356
357 * charset.c (Fdecode_char, Fencode_char): Remove description of
358 `restriction' arg. now that it's hidden by advertised-calling-convention.
359
c348360a
JD
3602013-10-02 Jan Djärv <jan.h.d@swipnet.se>
361
328a8179
SM
362 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
363 Remove unused variable (from mac-port).
c348360a
JD
364 (macfont_draw): Use s->ybase for correct y position.
365
1a23cd48
DA
3662013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
367
368 * frame.h (struct frame): Drop has_minibuffer member because...
369 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
370 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
371
29bf4de4
DA
3722013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
373
374 * window.h (struct window): Prefer enum text_cursor_kinds to int
375 for phys_cursor_type member. Move the latter, phys_cursor_width,
376 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
377 * window.c (replace_window, make_window): Adjust users.
378
a30ddace
DA
3792013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
380
381 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
382 this module is never compiled otherwise.
383
45435f08
AA
3842013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
385
386 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
387 (Bug#15500).
388
92e5298b
EZ
3892013-09-29 Eli Zaretskii <eliz@gnu.org>
390
391 * xdisp.c (get_next_display_element): Don't call face_for_font in
392 a build configured --without-x. (Bug#15484)
393
caa50be2
JD
3942013-09-29 Jan Djärv <jan.h.d@swipnet.se>
395
66d13b20
JD
396 * window.c (calc_absolute_offset): #elif should be #elif defined.
397
caa50be2
JD
398 * frame.c (delete_frame): Block/unblock input to overcome race
399 condition (Bug#15475).
400
d3e2acb6
AP
4012013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
402
403 * frame.c (delete_frame): Record selected frame only after
404 calling Qdelete_frame_functions (Bug#15477).
405
1610938f
JD
4062013-09-28 Jan Djärv <jan.h.d@swipnet.se>
407
408 * nsterm.m (ns_selection_color): Remove.
409 (ns_get_color): Check for ns_selection_(fg|bg)_color using
410 NSColor selectedText(Background)Color. Only for COCOA.
411 (ns_term_init): Remove assignment of ns_selection_color, logic
412 moved to ns_get_color.
413
328a8179 414 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
415 NS_SELECTION_COLOR_DEFAULT.
416 (NS_SELECTION_FG_COLOR_DEFAULT): New.
417
0d2647e6
EZ
4182013-09-28 Eli Zaretskii <eliz@gnu.org>
419
420 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
421 frame' does not have the tool_bar_window member.
422
ba355de0
BR
4232013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
424
425 Signal error when reading an empty byte-code object (Bug#15405)
426 * lread.c (read1): signal error
427 * alloc.c (make_byte_code): eassert header size
428 (sweep_vectors): change an int to size_t
429
4710d6f4
PE
4302013-09-24 Paul Eggert <eggert@cs.ucla.edu>
431
cf647d93
PE
432 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
433 instead of ints, as it's the usual style for offsetof constants. See:
434 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
435
4710d6f4
PE
436 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
437 This is ugly, but it should fix the performance problem for older
438 GCC versions in the short run. I'll look into integrating the
439 Gnulib module for popcount, as a better fix.
440 See the thread starting in:
441 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
442 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
443 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
444 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
445 (popcount_size_t): Use it.
446
10ebac9d
DC
4472013-09-24 Daniel Colascione <dancol@dancol.org>
448
449 * process.c (Fnetwork_interface_info): Fix build break due to
450 vector changes.
451
9da0f50e
PE
4522013-09-24 Paul Eggert <eggert@cs.ucla.edu>
453
454 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
455 Prefer signed to unsigned integers where either will do.
456 No need for 'const' on locals that do not escape.
457 Omit easserts with unnecessary and unportable assumptions about
458 alignment. Avoid unnecessary casts to char *.
459
d6d9cbc1
DA
4602013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
461
462 Use union for the payload of struct Lisp_Vector.
463 This helps to avoid a few glitches dictated by C's aliasing rules.
464 * lisp.h (struct Lisp_Vector): Use union for next and
465 contents member. Adjust comment. Change related users.
466 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
467 Related users changed.
468 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
469 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
470 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
471 * xfaces.c, xfont.c, xmenu.c: Related users changed.
472
ec7bc82f
DA
4732013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
474
475 Optimize glyph row clearing and copying routines.
476 * dispextern.h (struct glyph_row): Change layout of struct
477 glyph_row to help copy_row_except_pointers. Adjust comment.
478 * dispnew.c (null_row): Remove.
479 (clear_glyph_row): Use offsetof and memset to find and clear
480 just the members that need clearing. Adjust comment.
481 (copy_row_except_pointers): Likewise for copying.
482
d160dd0c
PE
4832013-09-24 Paul Eggert <eggert@cs.ucla.edu>
484
7be68de5
PE
485 Some minor cleanups of recently-added bool vector code.
486 * conf_post.h (assume): Always return void. Use lint version
487 only if GCC and MSC versions don't apply.
488 * conf_post.h (assume):
489 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
490 Depend on _MSC_VER, not __MSC_VER, for consistency with
491 the rest of Emacs.
492 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
493 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
494 (bool_vector_binop_driver, count_trailing_zero_bits)
495 (size_t_to_host_endian): Now static, not static inline;
496 the latter isn't needed with modern compilers and doesn't
497 work with older compilers anyway.
498
d160dd0c
PE
499 * alloc.c (valgrind_p): Use bool for boolean.
500
e08813d0
DA
5012013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
502
503 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
504 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
505 (display_last_displayed_message_p, message_buf_print)
506 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
507 Use bool for boolean.
3a6a78fd
DA
508 * dispextern.h (cancel_line, init_desired_glyphs):
509 Remove ancient leftover.
510 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
511 * lisp.h (noninteractive_need_newline): Adjust declaration.
512
5492865b
DA
5132013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
514
515 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
516 Move to...
517 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
518 ...this file and convert the latter to static. Adjust comment.
519 (make_initial_frame):
520 * window.c (init_window_once): Adjust user.
521 * frame.h (last_nonminibuf_frame): Remove declaration.
522 * lisp.h (selected_frame): Likewise.
523 * msdos.c (the_only_display_info): Adjust comment.
524
cd548fa4
EZ
5252013-09-23 Eli Zaretskii <eliz@gnu.org>
526
f03eddbf
EZ
527 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
528 computing the end column of mouse-highlight that comes from
529 display or overlay strings. (Bug#15437)
b519df23
EZ
530 (note_mouse_highlight): Adapt calculation of last argument to
531 mouse_face_from_string_pos to the above change.
f03eddbf 532
cd548fa4
EZ
533 * conf_post.h (__has_builtin): Define to zero, if undefined, on
534 all platforms, not just for clang.
535
8762e524
JD
5362013-09-23 Jan Djärv <jan.h.d@swipnet.se>
537
538 * filelock.c (lock_file_1): Rearrange to remove compiler warning
539 about excess arguments to snprintf.
540
541 * conf_post.h(assume): Use __builtin_unreachable for clang.
542
d4a9284f
JB
5432013-09-23 Juanma Barranquero <lekktu@gmail.com>
544
545 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
546 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
547
a84683fd
DC
5482013-09-23 Daniel Colascione <dancol@dancol.org>
549
550 * alloc.c (USE_VALGRIND): New macro; on by default
551 when ENABLE_CHECKING.
552 (mark_maybe_object,mark_maybe_pointer)
553 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
554 valgrind purposes.
555 (valgrind_p) [USE_VALGRIND]: New variable.
556 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
557
8fef36c6
JD
5582013-09-22 Jan Djärv <jan.h.d@swipnet.se>
559
fb83ea63
JD
560 * process.c (wait_reading_process_output): Change int pnamelen to
561 socklen_t.
562
563 * nsterm.m (setMarkedText:selectedRange:):
564 (deleteWorkingText):
565 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
566 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
567 argument to unsigned long to avoid warning.
568 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
569
8fef36c6
JD
570 * conf_post.h (assume): Fix compiler error: x shall be cond.
571
cd9356f2
DC
5722013-09-22 Daniel Colascione <dancol@dancol.org>
573
574 * xfns.c (x_get_monitor_attributes): Suppress unused variable
575 warning when compiling without a window system.
576
3e0b94e7
DC
5772013-09-22 Daniel Colascione <dancol@dancol.org>
578
579 * data.c (Qbool_vector_p): New symbol.
580 (bool_vector_spare_mask,popcount_size_t_generic)
581 (popcount_size_t_msc,popcount_size_t_gcc)
582 (popcount_size_t)
583 (bool_vector_binop_driver)
584 (count_trailing_zero_bits,size_t_to_host_endian)
585 (Fbool_vector_exclusive_or)
586 (Fbool_vector_union)
587 (Fbool_vector_intersection,Fbool_vector_set_difference)
588 (Fbool_vector_subsetp,Fbool_vector_not)
589 (Fbool_vector_count_matches)
590 (Fbool_vector_count_matches_at): New functions.
591 (syms_of_data): Intern new symbol, functions.
592 * alloc.c (bool_vector_payload_bytes): New function.
593 (Fmake_bool_vector): Instead of calling Fmake_vector,
594 which performs redundant initialization and argument checking,
595 just call allocate_vector ourselves. Make sure we clear any
596 terminating padding to zero.
597 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
598 instead of open-coding the size calculation.
599 (vroundup_ct): New macro.
600 (vroundup): Assume argument >= 0; invoke vroundup_ct.
601 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
602 * composite.c (composition_gstring_put_cache):
603 Change lint_assume to assume.
3e0b94e7
DC
604 * conf_post.h (assume): New macro.
605 (lint_assume): Remove.
606 * dispnew.c (update_frame_1): Change lint_assume to assume.
607 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
608 to assume.
609 * image.c (gif_load): Change lint_assume to assume.
610 * lisp.h (eassert_and_assume): New macro.
611 (Qbool_vector_p): Declare.
612 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
613 (swap16,swap32,swap64): New inline functions.
614 * macfont.c (macfont_shape): Change lint_assume to assume.
615 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
616 * xsettings.c (parse_settings): Use new swap16 and
617 swap32 from lisp.h instead of file-specific macros.
618
76880d88
EZ
6192013-09-22 Eli Zaretskii <eliz@gnu.org>
620
621 * xdisp.c (try_window_id): Don't abort if cursor row could not be
622 found (which can legitimately happen when the glyph row at the
623 window start is disabled in the current_matrix. (Bug#15365)
624
c6cfd910
PE
6252013-09-22 Paul Eggert <eggert@cs.ucla.edu>
626
627 Fix syntax.h bug introduced by recent INLINE change.
628 syntax.h defined an extern inline function SYNTAX_ENTRY that was
629 conditionally compiled one way in some modules, and a different
630 way in others. This doesn't work with extern inline functions,
631 which must have the same definition in all modules, because the
632 defining code might be shared across modules, depending on the
633 implementation. Symptoms reported by Martin Rudalics in:
634 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
635 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
636 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
637 overriding the corresponding functions in syntax.h.
638 * syntax.h (syntax_property_entry, syntax_property_with_flags)
639 (syntax_property): New inline functions.
640 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
641 Rewrite in terms of these new functions.
642
b3f1d119
EZ
6432013-09-21 Eli Zaretskii <eliz@gnu.org>
644
645 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
646 not chars_in_text, whose result depends on the multibyteness of
647 the current buffer. (Bug#15426)
648
00382e8b
PE
6492013-09-20 Paul Eggert <eggert@cs.ucla.edu>
650
e3b29769
PE
651 Port recent change to hosts where pointers aren't 'long'.
652 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
653 Don't assume that pointers are the same width as 'long'.
654 Add a compile-time check that a pointer fits into two X slots.
655
00382e8b
PE
656 A simpler, centralized INLINE.
657 * conf_post.h (INLINE): Define only if not already defined.
658 This allows us to use a single INLINE, defined by one file
659 per executable.
660 * emacs.c (INLINE): Define it.
661 Also, include category.h, charset.h, composite.h, dispextern.h,
662 syntax.h, systime.h, so that their INLINE definitions are expanded
663 properly for Emacs.
664 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
665 * buffer.h, buffer.c (BUFFER_INLINE):
666 * category.h, category.c (CATEGORY_INLINE):
667 * character.h, character.c (CHARACTER_INLINE):
668 * charset.h, charset.c (CHARSET_INLINE):
669 * composite.h, composite.c (COMPOSITE_INLINE):
670 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
671 * frame.h, frame.c (FRAME_INLINE):
672 * intervals.h, intervals.c (INTERVALS_INLINE):
673 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
674 * lisp.h, alloc.c (LISP_INLINE):
675 * process.h, process.c (PROCESS_INLINE):
676 * syntax.h, syntax.c (SYNTAX_INLINE):
677 * systime.h, sysdep.c (SYSTIME_INLINE):
678 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
679 * window.h, window.c (WINDOW_INLINE):
680 Remove. All uses replaced with INLINE.
681
2b943ba6
DA
6822013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
683
684 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
685 to avoid Bug#15398.
686
13d9698a
EZ
6872013-09-19 Eli Zaretskii <eliz@gnu.org>
688
689 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
690 'const char *' to avoid compiler warnings due to similar change in
691 the prototype of x_get_string_resource.
692
ced135eb
DA
6932013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
694
695 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
696 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
697 going to replace static variables below. Adjust comments.
698 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
699 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
700 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
701 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
702 Related users changed.
703 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
704 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
705 last_mouse_movement_time, going to replace static variables below.
706 Adjust comments.
707 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
708 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
709 Remove.
710 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
711 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
712 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
713 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
714 static variables below.
715 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
716 (last_mouse_scroll_bar): Remove.
717 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
718 (mouseExited): Related users changed.
719
091f1e1f
DA
7202013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
721
722 Do not use external array to process X scroll bar messages.
723 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
724 (x_send_scroll_bar_event): Pack window pointer into two slots
725 of XClientMessageEvent if we're 64-bit. Adjust comment.
726 (x_scroll_bar_to_input_event): Unpack accordingly.
727
582ed56c
DA
7282013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Ifdef away recent changes which aren't relevant to NS port.
731 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
732 [!HAVE_NS]: Declare as such.
733 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
734 [!HAVE_NS]: Define as such.
735
18da0d8a
DA
7362013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
737
738 * frame.c (x_redo_mouse_highlight): New function
739 to factor out common code used in W32 and X ports.
740 * dispextern.h (x_redo_mouse_highlight): Add prototype.
741 * xterm.h (struct x_display_info):
742 * w32term.h (struct w32_display_info):
743 * nsterm.h (struct ns_display_info): New members
744 last_mouse_motion_frame, last_mouse_motion_x and
745 last_mouse_motion_y, going to replace static variables below.
746 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
747 (redo_mouse_highlight): Remove.
748 (note_mouse_movement, syms_of_xterm): Adjust user.
749 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
750 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
751 (redo_mouse_highlight): Remove.
752 (note_mouse_movement, syms_of_w32term): Adjust user.
753 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
754 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
755 Remove.
756 (note_mouse_movement, mouseMoved, syms_of_nsterm):
757 * nsfns.m (compute_tip_xy): Adjust user.
758
7a0c745a
DA
7592013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
760
761 * frame.c (x_mouse_grabbed): New function.
762 * dispextern.h (x_mouse_grabbed): Add prototype.
763 (last_mouse_frame): Remove declaration.
764 * xterm.h (struct x_display_info):
765 * w32term.h (struct w32_display_info):
766 * nsterm.h (struct ns_display_info): New member
767 last_mouse_frame, going to replace...
768 * xdisp.c (last_mouse_frame): ...global variable.
769 (note_tool_bar_highlight):
770 * w32term.c (w32_mouse_position, w32_read_socket):
771 * xterm.c (XTmouse_position, handle_one_xevent):
772 Use x_mouse_grabbed.
773 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
774
0791d107
DA
7752013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
776
777 * w32term.c (w32_read_socket): Avoid temporary
778 variables in a call to x_real_positions.
779 * xterm.c (handle_one_xevent): Likewise.
780
2cd98812
DA
7812013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
782
783 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
784 (x_icon_type): Remove prototype.
785 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
786 * frame.c (x_icon_type): Remove.
787 * w32term.c (x_make_frame_visible, x_iconify_frame):
788 * xterm.c (x_make_frame_visible, x_iconify_frame):
789 Use x_set_bitmap_icon to factor out common code.
790
a6c2ee1b
DA
7912013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
792
793 * dispextern.h (check_x_display_info, x_get_string_resource):
794 Declare here just once and unify the latter.
795 * frame.c (check_x_display_info, x_get_string_resource):
796 * nsterm.h (check_x_display_info):
797 * xrdb.c (x_get_string_resource):
798 * xterm.h (check_x_display_info): Remove prototypes.
799 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
800 * w32reg.c (x_get_string_resource): Likewise.
801 (w32_get_rdb_resource): Adjust user.
802
baed3603
DA
8032013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
804
805 * xterm.h (struct x_display_info): New member
806 x_pending_autoraise_frame, going to replace...
807 * xterm.c (pending_autoraise_frame): ...static variable.
808 (x_new_focus_frame, XTread_socket): Adjust users.
809 * w32term.h (struct w32_display_info): New member
810 w32_pending_autoraise_frame, going to replace...
811 * w32term.c (pending_autoraise_frame): ...global variable.
812 (x_new_focus_frame, w32_read_socket): Adjust users.
813
90582f05
GM
8142013-09-17 Glenn Morris <rgm@gnu.org>
815
816 * xdisp.c (message_dolog): If we create *Messages*,
817 switch it to messages-buffer-mode.
818
b7ad2f74
PE
8192013-09-17 Paul Eggert <eggert@cs.ucla.edu>
820
821 Don't overuse 'const' in types of locals.
822 * bidi.c (bidi_count_bytes):
823 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
824 (xg_event_is_for_scrollbar):
825 * xselect.c (x_handle_property_notify)
826 (x_handle_selection_notify, x_handle_dnd_message):
827 * xsettings.c, xsettings.h (xft_settings_event):
828 * xterm.c (x_handle_net_wm_state, handle_one_event)
829 (x_menubar_window_to_frame, x_detect_focus_change)
830 (construct_mouse_click, note_mouse_movement)
831 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
832 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
833 (handle_one_xevent, x_handle_net_wm_state):
834 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
835 (x_handle_dnd_message):
836 Avoid unnecessary 'const', typically the second 'const' in
837 'const foo * const arg', a 'const' that does not affect the API
838 and doesn't significantly help the human reader.
839
19452b86
DA
8402013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
841
842 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
843 only if Glib < 2.36.0.
844 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
845 * xsettings.c (init_gconf, init_gsettings): Do not check
846 for g_type_init.
1893694e
DA
847 * xterm.c (handle_one_xevent): Do not call to x_clear_area
848 if GTK >= 2.7.0.
33b83dd7 849 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 850
6434e343
JD
8512013-09-16 Jan Djärv <jan.h.d@swipnet.se>
852
3f386383
JD
853 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
854 before calling g_type_init.
855
6434e343
JD
856 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
857
858 * nsterm.m (syms_of_nsterm): ... to here.
859
83a119f8
DA
8602013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
861
862 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
863 (ignore_next_mouse_click_timeout): Use Time as X does.
864 (handle_one_xevent): Avoid cast and use unsigned comparison.
865
61582e6a
DA
8662013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
867
868 Do not copy X event in handle_one_xevent except KeyPress case.
869 Wnen XEvent is processed, it is unlikely to be changed except
870 KeyPress case, so we can avoid copying and use const pointer to
871 const data to make sure that an event is not changed elsewhere.
872 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
873 const' and do not create local copy except for the KeyPress event.
874 Use casts to avoid a few glitches. Adjust formatting. Add comments.
875 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
876 (x_handle_net_wm_state, x_menubar_window_to_frame)
877 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
878 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
879 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
880 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
881 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
882 (x_handle_dnd_message):
883 * xsettings.c (xft_settings_event):
884 Use 'const XEvent * const' where appropriate.
885 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
886
f8eb1572
DA
8872013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
888
889 Fix X event waiting to handle multiple frames.
890 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
891 * xterm.c (pending_event_wait): Remove. Adjust users.
892 (x_detect_focus_change): Pass frame arg.
893 (handle_one_xevent): Find related frame early and clear per-frame
894 wait_event_type only if this is an event for the relevant frame.
895 (x_wait_for_event): Use per-frame wait_event_type.
896
3fa2054e
JD
8972013-09-15 Jan Djärv <jan.h.d@swipnet.se>
898
745d3809
JD
899 * nsfns.m (Fx_create_frame): Fix font driver registration for
900 GNUStep.
901
902 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
903 for syms_of_macfont.
904
3fa2054e
JD
905 * nsterm.m: Include macfont.h.
906 (ns_tmp_flags, ns_tmp_font): Remove.
907 (ns_compute_glyph_string_overhangs): Check for driver Qns.
908 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
909 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
910 (changeFont:): Fix code style. Check for font driver type when
911 getiing font.
912
913 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
914 (f)->descent.
915
916 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
917 (nsfont_open): Set font driver type.
918 Set font->ascent and font->descent. Figure out font instead of
919 ns_tmp_font, and flags instead of ns_tmp_flags.
920 Fix indentation. Remove call to ns_draw_text_decoration,
921 moved to nsterm.
922
923 * nsfns.m: Include macfont.h.
924 (Fx_create_frame): Register macfont driver, make a better default font.
925 (Fns_popup_font_panel): Get font from macfont driver, if used.
926
927 * macfont.m, macfont.h, maccuvs.h: New files.
928
929 * font.h: Declare syms_of_macfont.
930
931 * font.c (syms_of_font): Call syms_of_macfont.
932
933 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
934
0eed0355
DA
9352013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
938 and it is always zero for others, so I assume that this is an ancient
939 leftover which nobody will want to change any more.
940 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
941 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
942 * frame.c (x_set_scroll_bar_width):
943 * w32fns.c (w32_createscrollbar):
944 * w32term.c (w32_set_vertical_scroll_bar):
945 * xfns.c (x_set_scroll_bar_default_width):
946 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
947 (x_scroll_bar_expose): Related users changed.
948
07013c68
DA
9492013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
950
951 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
952 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
953 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
954 Define as such.
c7cc32f7
DA
955 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
956 Define once here...
957 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
958 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
959 Remove unused Xisms.
7f09455e
DA
960 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
961 these modules are never compiled otherwise.
07013c68 962
0df00f59
EZ
9632013-09-14 Eli Zaretskii <eliz@gnu.org>
964
08a209bf 965 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
966 Doc fix. (Bug#15375)
967
fcd42c11
DA
9682013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
969
970 Unify Fx_focus_frame between all ports.
971 * frame.h (x_focus_frame): New prototype.
972 * xfns.c (Fx_focus_frame): Remove.
973 (syms_of_xfns): Do not defsubr it.
974 (x_focus_frame): X implementation.
975 * nsfns.m (Fx_focus_frame): Remove.
976 (syms_of_nsfns): Do not defsubr it.
977 (x_focus_frame): NS implementation.
978 * w32term.c (Fx_focus_frame): Remove.
979 (x_focus_on_frame): Rename to...
980 (x_focus_frame): W32 implementation.
981 * w32term.h (x_focus_on_frame): Remove prototype.
982 * w32fns.c (Fx_focus_frame): Remove.
983 (syms_of_w32fns): Do not defsubr it.
984 * frame.c (Fx_focus_frame): Define here.
985 (syms_of_frame): Defsubr here.
986 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
987
aad3612f
DA
9882013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
989
990 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
991 All of them are replaced with FRAME_DISPLAY_INFO, defined in
992 each port to reference the port-specific window system data.
993 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
994 (FRAME_DISPLAY_INFO): Define.
995 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
996 (FRAME_DISPLAY_INFO): Define. Adjust users.
997 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
998 (FRAME_DISPLAY_INFO): Define. Adjust users.
999 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
1000 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
1001 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
1002 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
1003 * xselect.c, xterm.c: All related users changed.
1004
9a650e62
DA
10052013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1006
1007 * xterm.h (x_window_to_frame, x_any_window_to_frame)
1008 (x_menubar_window_to_frame): Remove prototypes.
1009 * xfns.c (x_window_to_frame, x_any_window_to_frame)
1010 (x_menubar_window_to_frame, x_top_window_to_frame):
1011 Move from here...
1012 * xterm.c (x_window_to_frame, x_any_window_to_frame)
1013 (x_menubar_window_to_frame, x_top_window_to_frame):
1014 ...to here and convert all but the last to static.
1015
347ae3e1
EZ
10162013-09-12 Eli Zaretskii <eliz@gnu.org>
1017
1018 * lisp.mk (lisp): Add w32-common-fns.elc.
1019
15c6d837
XF
10202013-09-12 Xue Fuqiao <xfq.free@gmail.com>
1021
1022 * charset.c (char_charset): Document an exception for char-charset.
1023
27e90f77
DA
10242013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1025
1026 * xterm.h (x_display_info): New field last_user_time...
1027 * xterm.c (toplevel): ...to replace static last_user_time.
1028 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
1029
8ffbc36b
DA
10302013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
1031
1032 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
1033 scroll bar values to prevent thumb from disappear and update comment.
1034
5ec0337a
GM
10352013-09-11 Glenn Morris <rgm@gnu.org>
1036
1037 * emacs.c (usage_message): Possessive apostrophe tweak.
1038
fb55b9d1
DA
10392013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1040
8d2db8be
DA
1041 * nsterm.m (syms_of_nsterm): Use Qns.
1042 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
1043 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
1044 * xfns.c (x_display_info_for_name, Fx_open_connection):
1045 Remove old '#if 0' code.
1046 (syms_of_xfns): Use Qx.
fb55b9d1
DA
1047 * termhooks.h (fullscreen_hook): Remove the leftover.
1048 (struct terminal): Fix typo in comment.
1049
927eec55
DA
10502013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1051
1052 Cleaning up a few X scroll bar bits.
1053 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
1054 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1055 New member last_seen_part, going to replace...
1056 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
1057 (xt_action_hook) [USE_LUCID]: Adjust user.
1058 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
1059 Lucid-specific scroll bar support.
1060 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
1061 to int and adjust to use last_seen_part member.
1062 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
1063 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
1064 Initialize last_seen_part.
1065
71b28baa
SM
10662013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1067
1068 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
1069 insert-buffer-substring an empty string.
1070
f5dacaae
PE
10712013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
1074 avoiding a GCC warning.
1075
742516e0
DA
10762013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 Ifdef away frame tool bar code when it is not really used.
1079 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
1080 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
1081 and minimize_tool_bar_window_p under the above.
1082 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1083 (fset_tool_bar_window): Likewise.
1084 * dispnew.c (clear_current_matrices, clear_desired_matrices)
1085 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
1086 (change_frame_size_1):
1087 * window.c (window_from_coordinates, Frecenter): Adjust users.
1088 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
1089 code is not really used.
1090 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
1091 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
1092 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
1093 [!USE_GTK && !HAVE_NS]: Define as such.
1094 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
1095 (note_mouse_highlight, expose_frame):
1096 * xfns.c (x_set_tool_bar_lines):
1097 * xterm.c (handle_one_xevent): Adjust users.
1098
73f82c7e
PE
10992013-09-11 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 Fix corruption with multiple emacsclient -t instances (Bug#15222).
1102 This bug was introduced by my 2013-08-26 patch, which incorrectly
1103 assumed that the terminfo implementation doesn't use termcap buffers.
1104 * term.c (init_tty) [TERMINFO]: Remove optimization, as
1105 these buffers apparently are used after all.
1106 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
1107 (struct tty_display_info): Define members termcap_term_buffer and
1108 termcap_strings_buffer even if TERMINFO.
1109
53482f41
DA
11102013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1111
1112 Fix last change.
1113 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
1114 'usage' docstring entry to pacify make-docfile.
1115
11162013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
1117
1118 Change comparison functions =, <, >, <=, >= to take many arguments.
1119 * data.c: Change comparison functions' interface and implementation.
1120 * lisp.h: Make arithcompare available for efficient two arg
1121 comparisons.
1122 * bytecode.c: Use arithcompare.
1123 * fileio.c: Use new interface.
1124
533f258f
SM
11252013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
1126
1127 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
1128
8c27f5ff
SM
11292013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
1130
1131 * eval.c (Feval): Document the new use of `lexical'.
1132
0750a308
DA
11332013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1134
1135 Review and drop old frame resize hack.
1136 * frame.h (struct frame): Remove force_flush_display_p.
1137 * dispnew.c (update_frame): Adjust user and don't call
1138 flush_frame here. The comment has said that there was an issues
1139 with redisplaying fringes, but I don't see any differences with
1140 and without this hack. Hopefully we can continue without it.
1141 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
1142 current frame matrices twice if resized_p is set.
1143
83fc0554
DA
11442013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1145
1146 Do not populate pure Xism x_sync to other ports.
1147 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
1148 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
1149 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
1150 * w32term.h (x_sync): Remove prototype.
1151
fd462129
DA
11522013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
1153
1154 Cleanup frame flushing.
8c27f5ff
SM
1155 * dispextern.h (struct redisplay_interface):
1156 Drop flush_display_optional because flush_display is enough
fd462129
DA
1157 for X and flushing via RIF is just a no-op for others.
1158 * frame.h (flush_frame): New function.
1159 * dispnew.c (update_frame):
1160 * minibuf.c (read_minibuf):
1161 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
1162 Use it.
1163 * keyboard.c (detect_input_pending_run_timers): Do not flush
1164 all frames but selected one in redisplay_preserve_echo_area.
1165 * nsterm.m (ns_flush): Remove no-op.
1166 (ns_redisplay_interface): Adjust user.
1167 * w32term.h (x_flush): Remove no-op.
1168 (w32_redisplay_interface): Adjust user.
1169 * xterm.c (x_flush): Simplify because we do not flush all
1170 frames at once any more. Adjust comment.
1171 (x_redisplay_interface): Adjust user.
1172
4b73fc73
PE
11732013-09-07 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 Port --without-x --enable-gcc-warnings to Fedora 19.
1176 * gfilenotify.c (globals_of_gfilenotify):
1177 Call g_type_init only if using an older glib version that needs it.
1178
77394d40
DA
11792013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1180
1181 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1182 (last_glyphless_glyph_merged_face_id): Remove declarations.
1183 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
1184 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
1185 (last_glyphless_glyph_merged_face_id): Now static.
1186 (merge_escape_glyph_face): New function, refactored from...
1187 (get_next_display_element): ...here.
1188 (merge_glyphless_glyph_face): New function, refactored from...
1189 (produce_glyphless_glyph): ...here...
1190 * term.c (produce_glyphless_glyph): ...and here.
1191
306d67bd
SM
11922013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
1193
1194 * eval.c (eval_sub): Only call Ffunction if necessary.
1195
7f6c6450
DA
11962013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 Attempt to make redisplay more selective when changing cursor type.
1199 * frame.h (struct frame): New bitfield cursor_type_changed.
1200 * xdisp.c (cursor_type_changed): Remove.
1201 (try_cursor_movement, redisplay_window, try_window_id)
1202 (set_frame_cursor_types, try_window_reusing_current_matrix):
1203 Adjust to use per-frame bitfield.
1204 (redisplay_internal): Look for cursor type change on each visible
1205 frame and consider all frames if cursor type has been changed on
1206 the frame other than selected. If cursor type has been changed on
1207 selected frame only, do not use fast update.
1208
bd0443bb
DA
12092013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1210
1211 Attempt to make redisplay more selective when changing fonts.
1212 * frame.h (struct frame): New bitfield fonts_changed.
1213 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
1214 (adjust_frame_glyphs): Add prototype.
1215 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 1216 (adjust_glyphs): Remove because we do not
bd0443bb
DA
1217 adjust matrices on all frames at once any more.
1218 (adjust_frame_glyphs): Block and unblock input here.
1219 (adjust_glyph_matrix): Use fonts_changed.
1220 (change_frame_size_1): Use adjust_frame_glyphs.
1221 * font.c (font_open_entity): Use fonts_changed.
1222 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
1223 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1224 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
1225 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
1226 (shrink_mini_window, Fresize_mini_window_internal)
1227 (window_scroll_pixel_based, Fset_window_configuration)
1228 (apply_window_adjustment, Fset_window_vscroll):
1229 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
1230 Use adjust_frame_glyphs.
1231 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
1232 (try_window_reusing_current_matrix, try_window_id, display_line)
1233 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
1234 (redisplay_internal): Consider fonts_changed and adjust frame
1235 matrices for each frame only if the frame is visible. If font
1236 has been changed on some frame during full redisplay, retry
1237 only visible frames where the font has been actually changed.
1238
b9695828
DA
12392013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1240
1241 Cache current header and mode line height for each window.
1242 * window.h (struct window): New fields mode_line_height
1243 and header_line_height.
1244 * window.c (make_window): Initialize them.
1245 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
1246 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
1247 (current_mode_line_height, current_header_line_height):
1248 Remove declaration.
1249 * xdisp.c (current_mode_line_height, current_header_line_height):
1250 Remove.
1251 (pos_visible_p, init_xdisp): Adjust user.
1252 (redisplay_window): Invalidate mode_line_height and
1253 header_line_height if current and desired matrices do not agree.
1254
66738305
DA
12552013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1256
1257 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
1258 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
1259
257b3b03
DA
12602013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1261
1262 Make --without-x compatible with --enable-gcc-warnings.
1263 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
1264 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
1265 members under HAVE_WINDOW_SYSTEM.
1266 * keyboard.c (make_lispy_focus_out): Likewise.
1267 (record_menu_key): Move under HAVE_MENUS.
1268 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
1269 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
1270 (syms_of_xdisp): Adjust user.
1271 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
1272 (start_hourglass, cancel_hourglass):
1273 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
1274 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
1275 and CLEAR_FONT_TABLE_NFONTS.
1276 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
1277 Declare only if HAVE_WINDOW_SYSTEM.
1278 (lface_same_font_attributes_p, clear_face_gcs): Define only
1279 if HAVE_WINDOW_SYSTEM.
1280
98b7f4bd
DA
12812013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1282
1283 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
1284 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
1285 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
1286
a7e43722
SM
12872013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
1288
1289 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
1290
0c90b9ee
PE
12912013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
1294 This fixes a type error on hosts where ptrdiff_t is wider than int.
1295
d99760fa
SM
12962013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1297
6629638e
SM
1298 * keyboard.c (read_key_sequence_vs): New function.
1299 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
1300 common code.
1301
d99760fa
SM
1302 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1303
224e313d
PE
13042013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 Makefile improvements.
1307 * Makefile.in (config.status): Don't use double-colon rules, as
1308 they are not portable according to POSIX. Fix shell typo with `;
1309 I guess this rule has never been tested?
1310 (VCSWITNESS): New macro, to override any environment var.
1311
6d6ed1af
DA
13122013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1313
1314 * xterm.h (struct x_display_info): Do not track X connection
1315 fd separately because it is always available from Display.
1316 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1317 Adjust users.
1318
bc923770
DA
13192013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1320
1321 * buffer.c (drop_overlay):
1322 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1323 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1324
b1cf96de
DA
13252013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1326
1327 * buffer.c (Fmake_overlay, Fmove_overlay):
1328 * intervals.c (set_point_from_marker):
1329 * print.c (PRINTPREPARE): Prefer signal_error
1330 to plain error and report unsuitable marker too.
1331
d1fc6c21
DA
13322013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1335 for 'dragging' member.
d1ae6a0b
DA
1336 (struct x_output): Remove set-but-unused leftovers
1337 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1338 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1339 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1340 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1341 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1342 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1343 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1344 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1345 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1346
0ce9f6de
JD
13472013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1348
1349 * nsfont.m (INVALID_GLYPH): New define.
1350 (nsfont_encode_char): Use INVALID_GLYPH.
1351 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1352
b594a96c
DA
13532013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1354
1355 * xterm.c (x_last_mouse_movement_time): Revert last change.
1356 This code should use XDisplayMotionBufferSize to check display's
1357 motion history first, and there are few other issues as well.
1358 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1359 (handle_one_xevent): Adjust user.
1360
8b098236
MR
13612013-09-02 Martin Rudalics <rudalics@gmx.at>
1362
9718b207
MR
1363 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1364 * frame.c (Flast_nonminibuf_frame): ... to here.
1365 (check_minibuf_window): Don't abort if no window was found
1366 (Bug#15247).
8b098236 1367
84e70bba
DA
13682013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1369
1370 Use XGetMotionEvents to ask the last mouse motion time from X server.
1371 * xterm.c (X_MOTION_HISTORY): Default to 1.
1372 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1373 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1374 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1375 Ifdef away legacy code.
1376 (XTmouse_position, x_scroll_bar_report_motion):
1377 Use x_last_mouse_movement_time.
fc85e20b
DA
1378 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1379 UnmapNotify event.
84e70bba 1380
1fccc530
DA
13812013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1382
1383 * msdos.c (last_mouse_window): Move to...
1384 (dos_rawgetc): ...this function and adjust comment.
1385 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1386 (mouseMoved): ...this function and adjust comment.
1387 * w32term.c (last_window): Likewise with...
1388 (w32_read_socket): ...this function.
1389 * xterm.c (last_window): Likewise with...
1390 (handle_one_xevent): ...this function.
1391
0ab10992
DA
13922013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1393
b7da754d 1394 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1395 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1396 (handle_one_xevent): ...to here.
1397 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1398 otherwise.
1399
0c7f856e
DA
14002013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1401
1402 * msdos.c (IT_set_terminal_window): Remove no-op.
1403 (initialize_msdos_display): Adjust terminal setup.
1404 * w32console.c (w32con_set_terminal_window): Remove no-op.
1405 (initialize_w32_display): Adjust terminal setup.
1406 * w32term.c (w32_set_terminal_window): Remove no-op.
1407 (w32_create_terminal): Adjust terminal setup.
1408 * xterm.c (XTset_terminal_window): Remove no-op.
1409 (x_create_terminal): Adjust terminal setup.
1410
a892a94c
DA
14112013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1412
1413 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1414 Remove no-ops.
1415 (ns_create_terminal): Adjust terminal setup.
1416 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1417 Remove no-ops.
1418 (w32_create_terminal): Adjust terminal setup.
1419 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1420 Remove no-ops.
1421 (x_create_terminal): Adjust terminal setup.
1422
cf91889a
DA
14232013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1424
1425 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1426 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1427 * dispnew.c (buffer_posn_from_coords):
1428 * window.c (Fwindow_end, displayed_window_lines):
1429 * xdisp.c (redisplay_mode_lines): Use it.
1430
5b0891df
JD
14312013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1432
1433 * fontset.c (face_for_char): Check char in the current face font first
1434 if HAVE_NS (Bug#15138).
1435
0a357e98
MR
14362013-08-31 Martin Rudalics <rudalics@gmx.at>
1437
1438 * window.c (temp_output_buffer_show): Make sure window returned
1439 by display_buffer is live (Bug#15213).
1440
9d7693d7
DA
14412013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1442
1443 Minor cleanup to avoid forward declarations.
1444 * coding.h (struct ccl_spec): Remove forward declaration.
1445 * composite.h (toplevel): Include font.h.
1446 (struct composition_it, struct face, struct font_metrics):
1447 Remove forward declaration.
1448 * dispextern.h (struct image, struct atimer): Likewise.
1449 * emacsgtkfixed.h (struct frame): Likewise.
1450 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1451 * font.h (struct font_driver, struct font, struct glyph_string)
1452 (struct face): Remove forward declaration.
1453 * fontset.h (struct face, struct font): Likewise.
1454 * frame.h (toplevel): Style cleanup.
1455 (enum output_method): Move to...
1456 * termhooks.h (enum output_method): ...here.
1457 (struct glyph, struct frame, struct ns_display_info)
1458 (struct x_display_info, struct w32_display_info):
1459 Remove forward declaration.
1460 * xterm.h (toplevel): Include termhooks.h.
1461 (struct font, struct window, struct glyph_matrix, struct frame)
1462 (struct input_event, struct face, struct image): Remove forward
1463 declaration.
1464 * gtkutil.h (struct _widget_value): Likewise.
1465 * keyboard.h (toplevel): Include termhooks.h.
1466 (struct input_event): Remove forward declaration.
1467
032f7451
DA
14682013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1469
1470 * intervals.c (set_point_from_marker): New function.
1471 * editfns.c (Fgoto_char):
1472 * process.c (Finternal_default_process_filter):
1473 * window.c (select_window_1): Use it.
1474 * buffer.h (set_point_from_marker): Add prototype.
1475
3f940c5a
EZ
14762013-08-29 Eli Zaretskii <eliz@gnu.org>
1477
1478 * w32.c (term_winsock): Call release_listen_threads before calling
1479 WSACleanup.
1480 (_sys_wait_accept): Wait for accept event in a loop with a finite
1481 timeout, instead of waiting indefinitely. Will hopefully avoid
1482 hanging during exit because WSACleanup deadlocks waiting for the
1483 event object to be released. (Bug#14333)
1484
1485 * w32proc.c (release_listen_threads): New function, signals all
1486 the reader threads that listen for connections to stop waiting.
1487
1488 * w32.h (release_listen_threads): Add prototype.
1489
101ed2bb
DA
14902013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1491
1492 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1493 field of new marker (for sanity and safety).
20de2834
DA
1494 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1495 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1496
1f5cf200
DA
14972013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1498
1499 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1500 (x_after_update_window_line, x_scroll_bar_create):
1501 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1502 (handle_one_xevent, x_clear_frame_area):
1503 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1504 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1505 * xterm.h (x_clear_area): Adjust prototype.
1506
d2b36813
DA
15072013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1508
1509 Hook scanning and indentation functions to find_newline. This helps
1510 to avoid duplicated code and renders more respect to newline cache.
1511 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1512 * cmds.c (Fforward_line):
1513 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1514 Use find_newline and avoid unnecessary point movements.
1515 * search.c (scan_newline): Implement on top of find_newline.
1516
3ec7babc
SM
15172013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1518
1519 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1520 scoped code (bug#11258).
1521
5ab473cd
JD
15222013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1523
1524 * nsterm.m (last_window): New variable.
1525 (EV_TRAILER2): New macro.
1526 (EV_TRAILER): Call EV_TRAILER2.
1527 (mouseMoved:): Add support for mouse-autoselect-window
1528 on nextstep (Bug#6888).
1529
78779650
AS
15302013-08-28 Andreas Schwab <schwab@suse.de>
1531
1532 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1533 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1534 Remove unused macro definitions.
1535 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1536 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1537 Only define if emacs.
78779650 1538
c3c4768d
DA
15392013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1540
1541 Prefer enum glyph_row_area to int where appropriate.
1542 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1543 Fix comment.
1544 (window_box, window_box_width, window_box_left, window_box_left_offset)
1545 (window_box_right, window_box_right_offset): Adjust prototypes.
1546 * xdisp.c (window_box, window_box_width, window_box_left)
1547 (window_box_left_offset, window_box_right, window_box_right_offset):
1548 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1549 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1550 * nsterm.m (ns_clip_to_row):
1551 * w32term.c (w32_clip_to_row):
1552 * xterm.c (x_clip_to_row): Likewise.
1553
6bdcbfe1
DA
15542013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1555
1556 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1557 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1558
50b13cde
PE
15592013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1562 for portability to hosts where /bin/sh has problems.
1563
f60e429a
DA
15642013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1565
1566 Redesign redisplay interface to drop global output_cursor.
1567 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1568 (toplevel): Remove declaration of output_cursor.
1569 (set_output_cursor, x_cursor_to): Remove prototype.
1570 * window.h (struct window): New member output_cursor.
1571 (output_cursor_to): New function to replace RIF member.
1572 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1573 (update_text_area, set_window_cursor_after_update): Use it.
1574 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1575 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1576 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1577 * w32term.c (x_update_window_begin, x_update_window_end):
1578 * xterm.c (x_update_window_begin, x_update_window_end):
1579 Adjust to use per-window output cursor.
1580
43aac990
PE
15812013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1582
d486344e
PE
1583 Simplify SELECT_TYPE-related code.
1584 Like EMACS_TIME, this portability layer is no longer needed, since
1585 Emacs has been using fd_set as a portability layer for some time.
1586 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1587 (SELECT_TYPE): Remove. All uses changed to fd_set.
1588 (fd_set) [!FD_SET]: New typedef.
1589
43aac990
PE
1590 Simplify EMACS_TIME-related code.
1591 This portability layer is no longer needed, since Emacs has been
1592 using struct timespec as a portability layer for some time.
1593 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1594 Include <time.h> rather than "systime.h"; that's all that's needed now.
1595 * dispnew.c: Include <timespec.h> rather than "systime.h";
1596 that's all that's needed now.
1597 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1598 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1599 TIMESPEC_RESOLUTION.
1600 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1601 LOG10_TIMESPEC_RESOLUTION.
1602 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1603 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1604 (make_emacs_time): Remove. All used changed to make_timespec.
1605 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1606 (current_timespec): Rename from current_emacs_time. All uses changed.
1607 (add_emacs_time): Remove. All uses changed to timespec_add.
1608 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1609 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1610 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1611 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1612 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1613 (current_timespec): Rename from current_emacs_time. All uses changed.
1614 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1615 changed to timespec_cmp.
1616 * xgselect.c: Include <timespec.h>, since our .h files don't.
1617
d350e350
DA
16182013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1619
1620 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1621 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1622 Remove the leftovers.
1623 * gtkutil.c (toplevel): Do not declare Qxft but include
1624 font.h to do so.
1625 * image.c (toplevel): Do not declare Vlibrary_cache because
1626 it's already done in lisp.h.
1627
9fed9729
DA
16282013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1629
1630 * lisp.h (Mouse_HLInfo): Move from here...
1631 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1632 (reset_mouse_highlight): New function.
1633 * msdos.c (dos_set_window_size, IT_update_begin)
1634 (internal_terminal_init):
1635 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1636 (ns_initialize_display_info):
1637 * w32console.c (initialize_w32_display):
1638 * w32term.c (x_update_window_end, x_free_frame_resources)
1639 (w32_initialize_display_info):
1640 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1641 * window.c (Fdelete_other_windows_internal):
1642 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1643 * termchar.h (toplevel):
1644 * xterm.h (toplevel): Include dispextern.h.
1645
f462f075
PE
16462013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1647
1648 Fix minor problems found by static checking.
1649 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1650 (expect): Avoid nested-if warning.
1651 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1652 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1653 * nsterm.h, nsterm.m (ns_select):
1654 * xgselect.c, xgselect.h (xg_select):
1655 Adjust signature to better match pselect's.
1656 * nsterm.m (ns_select):
1657 Don't set *TIMEOUT, since pselect doesn't.
1658 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1659 diagnostic about assigning const char * to it.
1660 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1661
068f9124
SM
16622013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1663
1664 * lread.c (substitute_object_recurse): Handle hash-tables as well
1665 (bug#15190).
1666
f5adc984
PE
16672013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1668
1fc8eb33
PE
1669 Fix unlikely core dump in init_tty, and simplify terminfo case.
1670 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1671 The old version incorrectly dumped core if malloc returned a
1672 buffer containing only non-NUL bytes.
1673 (init_tty): Do not allocate or free termcap buffers; the
1674 struct does that for us now.
1675 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1676 (struct tty_display_info): Define members termcap_term_buffer and
1677 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1678 use them. Allocate them directly in struct rather than indirectly
1679 via a pointer, to simplify init_tty.
1680
f5adc984
PE
1681 * frame.c (check_minibuf_window): Initialize 'window' properly,
1682 so that Emacs reliably aborts later if 'window' is not initialized.
1683
efec3894
JD
16842013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1685
1686 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1687 of VoidSymbol (Bug#15154).
1688
e1d0341e
DA
16892013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1690
1691 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1692 mouse_face_beg_y and mouse_face_end_y.
1693 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1694 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1695 Adjust users and update comment where appropriate.
1696
bfff6445
MR
16972013-08-26 Martin Rudalics <rudalics@gmx.at>
1698
1699 * frame.c (check_minibuf_window): New function.
068f9124
SM
1700 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1701 Call check_minibuf_window (Bug#15183).
bfff6445 1702
c80016b3
DA
17032013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1704
1705 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1706 because this is the only last cursor data we need to keep and consult.
1707 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1708 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1709 Adjust users.
1710
de396731
DA
17112013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1712
068f9124
SM
1713 Fix recovering from possible decompression error.
1714 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1715 the position where the partially decompressed data ends, and
447218dd 1716 should count how many bytes was produced so far.
de396731
DA
1717 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1718 (unwind_decompress): Really delete partially uncompressed data.
1719 (Fzlib_decompress_region): Take decompressed data size into account.
1720
c76826d9
DA
17212013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1722
1723 * syntax.c (init_syntax_once): Adjust comment and do an early
1724 initialization of Qchar_table_extra_slots just once...
1725 * casetab.c (init_casetab_once):
1726 * category.c (init_category_once):
1727 * character.c (syms_of_character):
1728 * coding.c (syms_of_coding):
1729 * xdisp.c (syms_of_xdisp): ...and omit it here.
1730
b34454d0
EZ
17312013-08-24 Eli Zaretskii <eliz@gnu.org>
1732
11f20add
EZ
1733 * xdisp.c (get_next_display_element): Don't apply to characters
1734 from a display vector the logic of setting it->end_of_box_run_p
1735 suitable for characters from a buffer. (Bug#15175)
1736
b34454d0
EZ
1737 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1738 to handle directories, rather than '_utime' which doesn't.
1739 (Bug#15176)
1740
6e1b469e
JD
17412013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1742
1743 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1744 or fullscreen (Bug#14627).
1745
9c05bccf
PE
17462013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 System-dependent integer overflow fixes.
1749 * process.c (Fset_process_window_size): Signal an error if
1750 the window size is outside the range supported by the lower level.
1751 * sysdep.c (set_window_size): Return negative on error,
1752 nonnegative on success, rather than -1, 0, 1 on not in system,
1753 failure, success. This is simpler. Caller changed.
1754 (serial_configure): Remove unnecessary initialization of local.
1755 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1756 size fits in unsigned long; this isn't true on some 32-bit hosts.
1757 Avoid buffer overrun if some future version of /proc/meminfo has a
1758 variable name longer than 20 bytes.
1759 (system_process_attributes) [__FreeBSD__]:
1760 Don't assume hw.availpages fits in 'int'.
1761
c365c355
PE
17622013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1763
1764 Don't let very long directory names overrun the stack.
1765 Fix some related minor problems involving "//", vfork.
1766 * callproc.c (encode_current_directory): New function.
1767 (call_process): Don't append "/"; not needed.
1768 * fileio.c (file_name_as_directory_slop): New constant.
1769 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1770 this can save the caller having to alloca.
1771 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1772 Use SAFE_ALLOCA, not alloca.
1773 (directory_file_name, Fexpand_file_name): Leave leading "//"
1774 alone, since it can be special even on POSIX platforms.
1775 * callproc.c (call_process):
1776 * process.c (Fformat_network_address):
1777 * sysdep.c (sys_subshell):
1778 Use encode_current_directory rather than rolling our own.
1779 (create_process): No need to encode directory; caller does that now.
1780 * process.h (encode_current_directory): New decl.
1781 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1782 Rework to avoid 'goto xyzzy;'.
1783
6c6014d4
EZ
17842013-08-23 Eli Zaretskii <eliz@gnu.org>
1785
1786 * xdisp.c (handle_face_prop): If the default face was remapped use
1787 the remapped face for strings from prefix properties. (Bug#15155)
1788
9997ec56
DA
17892013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1790
1791 Minor cleanup for redisplay interface and few related functions.
1792 * frame.h (enum text_cursor_kinds): Move from here...
1793 * dispextern.h (enum text_cursor_kinds): ...to here.
1794 (toplevel): Drop unnecessary declarations.
1795 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1796 in update_window_end_hook and draw_window_cursor functions.
1797 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1798 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1799 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1800 * xterm.c (x_update_window_end, x_draw_window_cursor):
1801 * xdisp.c (display_and_set_cursor, update_window_cursor)
1802 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1803 enum text_cursor_kinds where appropriate.
1804
7f780da6
DA
18052013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1806
1807 Redesign redisplay interface to drop updated_row and updated_area.
1808 * dispextern.h (updated_row, updated_area): Remove declaration.
1809 (struct redisplay_interface): Pass glyph row and row area parameters
1810 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1811 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1812 Adjust prototypes.
1813 * dispnew.c (updated_row, updated_area): Remove.
1814 (redraw_overlapped_rows, update_window_line): Adjust user.
1815 (update_marginal_area, update_text_area): Likewise. Pass updated row
1816 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1817 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1818 Adjust users.
1819
26495794
PE
18202013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1821
1822 * process.c (flush_pending_output): Remove stub.
1823 All uses removed.
1824
4a88129a
PE
18252013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1826
1827 * callproc.c: Fix race that killed background processes (Bug#15144).
1828 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1829 Record deleted process-id in critical section, not afterwards.
1830 Don't mistakenly kill process created by a call-process invocation
1831 that discards output and does not wait.
1832
0c5307b0
DA
18332013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1834
1835 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1836 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1837 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1838 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1839 to shut up compiler in mark_object.
1840 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1841
0d7c1e66
PE
18422013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1845 We can't portably rely on PTY_OPEN doing that, even if
1846 it calls posix_openpt with O_CLOEXEC.
1847
3f246b65
KH
18482013-08-20 Kenichi Handa <handa@gnu.org>
1849
1850 * character.c (string_char): Improve commentary.
1851
8c2f38aa
PE
18522013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1855 (struct animation_cache): Make signature a flexible array member.
1856 All uses changed. This is a tad slower but may insulate us better
1857 from future changes to ImageMagick.
1858
bb566cea
PE
18592013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 * image.c: Shrink memory needed for animation cache.
1862 (SIGNATURE_DIGESTSIZE): New constant.
1863 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1864 (imagemagick_create_cache): Copy the signature. This saves
1865 several KB of memory that ImageMagick wastes per signature.
1866 Don't bother updating the update_time, as the caller does that now.
1867 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1868 it's a fixed size struct member now.
1869 (imagemagick_get_animation_cache): Always destroy the signature,
1870 as it's now imagemagick_create_cache's responsibility to copy it.
1871 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1872 and use memcmp rather than strcmp.
1873 eassert that ImageMagick returns a signature of the specified length.
1874
6da26928
LMI
18752013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1876
1877 * image.c (imagemagick_get_animation_cache): Don't segfault on
1878 each invocation.
453f4022
LMI
1879 (imagemagick_get_animation_cache): Revert to previous definition
1880 so that it actually works. But keep the memory leak fix.
1881 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1882
22490125
PE
18832013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1884
d0139df5
PE
1885 * image.c: Fix animation cache signature memory leak.
1886 Fix some other minor performance problems while we're at it.
1887 (imagemagick_create_cache): Clear just the members that
1888 need clearing. Don't set update_time, as caller does that now.
1889 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1890 Simplify by using pointer-to-pointer instead of a prev pointer.
1891 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1892 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1893 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1894 it's already a copy. Free the signature probe unless it's cached.
1895
22490125
PE
1896 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1897 This was introduced by my 2013-08-12 fix for Bug#15035.
1898
deb31e75
DA
18992013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1900
1901 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1902 (imagemagick_prune_animation_cache): Now static.
1903
319a4d03
LMI
19042013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1905
1906 * image.c (imagemagick_get_animation_cache): Don't segfault when
1907 pruning all entries.
1908
f747d82e
KB
19092013-08-18 Ken Brown <kbrown@cornell.edu>
1910
1911 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1912 static heap if ENABLE_CHECKING is defined.
1913 (max_bss_sbrk_ptr): New variable.
1914 (bss_sbrk): Use it.
1915 (report_sheap_usage): Report maximum static heap usage instead of
1916 ending static heap usage.
1917
d2c28fab
EZ
19182013-08-17 Eli Zaretskii <eliz@gnu.org>
1919
1920 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1921 of zlib_initialized according to the results of calling
1922 init_zlib_functions.
1923
274ff63f
LMI
19242013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1925
1926 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1927 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1928 (imagemagick_load_image): Remove the ping_wand code, which only
1929 apparently saved time on invalid animated images, and slowed down
1930 everything else. Optimise for the common case.
274ff63f 1931
2bede2ed
XF
19322013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1933
70ff8240
XF
1934 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1935
de179a3e
XF
1936 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1937
2bede2ed
XF
1938 * marker.c (set_marker): Remove documentation of undefined behavior.
1939
703dbeba
LMI
19402013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1941
1942 * image.c (imagemagick_compute_animated_image): Animate correctly
1943 when sub-images are smaller than the main image.
1d18b1e6
LMI
1944 (imagemagick_compute_animated_image): Setting the iterator row to
1945 zero is apparently not allowed.
79670014
LMI
1946 (imagemagick_compute_animated_image): Allow images that say they
1947 have sub-images that are bigger than the main image, but just crop
1948 them.
703dbeba 1949
63216c5e
JD
19502013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1951
1952 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1953
a5b5f73f
LMI
19542013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1955
1956 * image.c (imagemagick_compute_animated_image): Respect the GIF
1957 disposal methods.
1958
0fe73012
KB
19592013-08-15 Ken Brown <kbrown@cornell.edu>
1960
1961 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1962 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1963 needed.
1964
691a357f
PE
19652013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 Fix minor problems found by static checking.
1968 * frame.c (delete_frame):
1969 * xdisp.c (next_element_from_display_vector):
1970 Avoid uninitialized local.
1971 * image.c (imagemagick_compute_animated_image): Port to C89.
1972 Prefer usual GNU indentation style for loops.
1973 Be more careful about bizarrely large sizes, by using ptrdiff_t
1974 instead of int.
1975
42fe2e88
DA
19762013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1977
1978 Fix infinite frame selection loop (Bug#15025).
1979 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1980
d39a3da6
EZ
19812013-08-15 Eli Zaretskii <eliz@gnu.org>
1982
068f9124
SM
1983 * xdisp.c (compute_window_start_on_continuation_line):
1984 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1985 to make sure we end up setting the window start at the leftmost
1986 visible character of the display line. This avoids funky
1987 horizontal shifting because the window start is not kept on the
1988 same position. (Bug#15090)
05426239
EZ
1989 (next_element_from_display_vector): Support 'box' face attribute
1990 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1991
6e856b69
LMI
19922013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1993
1994 * image.c (imagemagick_compute_animated_image): Implement animated
1995 images (bug#14700).
995be755
LMI
1996 (imagemagick_compute_animated_image): Fix some compilation
1997 warnings. Implement a very simple cache to make the animation
1998 usable at all, but it should be replaced with a per-image cache.
6e856b69 1999
d5a1acfa
DA
20002013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2001
2002 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
2003 to do `for' loops over alist values.
2004 * buffer.h (FOR_EACH_BUFFER):
2005 * process.c (FOR_EACH_PROCESS): Use it.
2006 (handle_child_signal, status_notify, Fget_buffer_process)
2007 (kill_buffer_processes): Use FOR_EACH_PROCESS.
2008
9c253307
DA
20092013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2010
2011 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
2012 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
2013 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
2014 to xzalloc and so avoid redundant call to memset.
2015 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
2016 members because it is allocated with xzalloc and so already zeroed.
2017
05e64f9f
KB
20182013-08-14 Ken Brown <kbrown@cornell.edu>
2019
2020 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
2021 (Bug#15094).
2022
5b71542d
DA
20232013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2024
2025 Utility function and macro to copy Lisp string to C string.
2026 * lisp.h (xlispstrdupa): New macro.
2027 (xlispstrdup): New prototype.
2028 * alloc.c (xlispstrdup): New function.
2029 * callint.c (Fcall_interactively):
2030 * fileio.c (Ffile_name_directory, Fexpand_file_name)
2031 (Fsubstitute_in_file_name):
2032 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
2033 * image.c (x_create_bitmap_from_file):
2034 * w32term.c (w32_term_init):
2035 * xterm.c (x_term_init): Use xlispstrdup.
2036
71530c97
LMI
20372013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2038
4ce82fb8
LMI
2039 * image.c (imagemagick_load_image): Make animated pictures work.
2040 There's still some problems with background color settings, though
2041 (bug#14700).
2042
71530c97
LMI
2043 * decompress.c (unwind_decompress): Always restore point.
2044
7510a061
XF
20452013-08-14 Xue Fuqiao <xfq.free@gmail.com>
2046
2047 * marker.c (set_marker): Reformat documentation.
2048
01c3051f
PE
20492013-08-14 Paul Eggert <eggert@cs.ucla.edu>
2050
aab1fcdf
PE
2051 * xdisp.c (cursor_type_changed): Now static.
2052
01c3051f
PE
2053 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
2054 Use changed. This avoids the need to call xmalloc and for the
2055 caller to call xfree, and avoids memory leaks in some situations.
2056
2084152a
DA
20572013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2058
2059 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
2060 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
2061 (redisplay_window): If window_end_valid is cleared due to non-zero
2062 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
2063 so do not call to try_cursor_movement for that window.
2084152a 2064
02455cb6
DA
20652013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2066
2067 * window.h (struct window): Convert window_end_pos and
2068 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
2069 (wset_window_end_pos, wset_window_end_vpos): Remove.
2070 * dispnew.c (adjust_glyph_matrix):
2071 * window.c (Fwindow_end, replace_window, set_window_buffer)
2072 (make_window):
2073 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
2074 (set_vertical_scroll_bar, redisplay_window, try_window)
2075 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
2076 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
2077 (note_mouse_highlight): Adjust users.
2078 (try_cursor_movement): Likewise. Convert old precondition to eassert.
2079 Add comment.
2080
da5707e8
DA
20812013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2082
2083 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
2084 * image.c (imagemagick_filename_hint): Use `const char *' and
2085 prefer SSDATA to SDATA to avoid warnings.
2086
25554267
DA
20872013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2088
2089 Cleanup window fringes, margins and scroll bars adjustments.
2090 * window.c (set_window_fringes, set_window_margins)
2091 (set_window_scroll_bars, apply_window_adjustment): New functions.
2092 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
2093 (Fset_window_scroll_bars): Use them.
2094
38a2c910
DA
20952013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2096
2097 * window.h (struct window): Convert scroll_bar_width
2098 from Lisp_Object to integer. Adjust comment.
2099 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
2100 Adjust users.
2101 * window.c (wset_scroll_bar_width): Remove.
2102 (make_window): Initialize scroll_bar_width.
2103 (Fsplit_window_internal): Use direct assignment.
2104 (Fset_window_configuration, save_window_save):
2105 Convert Lisp_Object to integer and back where appropriate.
2106 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
2107 bar was actually changed, and mention this in docstring.
2108
2d065031
PE
21092013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 * decompress.c: Minor simplifications.
2112 (Fzlib_decompress_region): Don't bother verifying
2113 that avail_out <= UINT_MAX, as that was confusing.
2114 Mention the restriction in a comment instead.
2115 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
2116
a5bd5abb
JD
21172013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2118
2119 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
2120 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
2121
66e7901a
LMI
21222013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2123
2124 * image.c (imagemagick_filename_hint): Check for errors in the
2125 alist structure.
2126
2fa611b7
EZ
21272013-08-13 Eli Zaretskii <eliz@gnu.org>
2128
2129 * window.c (Fwindow_margins): Return nil when there's no marginal
2130 area, as per the documented API.
2131
2132 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
2133 Fmake_vector, as scroll bar's struct members are not all Lisp
2134 objects now. This avoids crashes in GC.
2135
2136 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
2137 bool, so its address could be taken.
2138
8259030d
LMI
21392013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2140
2141 * image.c (imagemagick_filename_hint): New function to possibly
2142 apply `image-content-type-suffixes'.
2143 (imagemagick_load_image): Use it.
2144
866c710e
EZ
21452013-08-13 Eli Zaretskii <eliz@gnu.org>
2146
2147 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
2148 if loading zlib failed.
2149
f10490f0
JD
21502013-08-13 Jan Djärv <jan.h.d@swipnet.se>
2151
96311be7
JD
2152 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
2153 2013-08-13 checkin below. Change bool to BOOL, rule is:
2154 All Obj-C code uses BOOL, except for interfaces callable from C.
2155
f10490f0
JD
2156 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
2157
c8ae93b0
DA
21582013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2159
2160 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
2161 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
2162 bool instead of BOOL.
2163 * w32term.h (struct scroll_bar): Convert fringe_extended_p
2164 from Lisp_Object to bitfield. Adjust comment.
2165 * w32term.c (x_scroll_bar_create): Adjust user.
2166 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
2167 * xterm.c (XTset_vertical_scroll_bar): Likewise.
2168 Use bool for boolean.
2169 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
2170 to `unsigned int' when defining a bitfield.
2171
53b64418
PE
21722013-08-13 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
2175
eeaf9bf3
DA
21762013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2177
2178 * window.h (struct window): Convert left_margin_cols and
2179 right_margin_cols from Lisp_Objects to integers. Adjust comment.
2180 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
2181 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
2182 Adjust users.
2183 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
2184 Adjust comment.
2185 (showing_window_margins_p, update_window_line, update_frame_1):
2186 * fringe.c (draw_fringe_bitmap_1):
2187 * xdisp.c (window_box_width): Adjust users.
2188 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
2189 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
2190 Use direct assignment.
2191 (Fset_window_configuration, save_window_save, Fwindow_margins):
2192 Convert Lisp_Object to integer and back where appropriate.
2193 (Fset_window_margins): Adjust user. Return t if any margin
2194 was actually changed, and mention this in docstring.
2195
956720af
XF
21962013-08-13 Xue Fuqiao <xfq.free@gmail.com>
2197
f73f4ce6 2198 * syntax.c (forward_word):
956720af
XF
2199 * cmds.c (forward_char, backward_char): Mention the optional argument.
2200
9e37ee3b
DA
22012013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2202
2203 * window.h (struct window): Convert left_fringe_width
2204 and right_fringe_width from Lisp_Objects to integers.
2205 Adjust comment.
2206 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
2207 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
2208 * window.c (wset_left_fringe_width, wset_right_fringe_width):
2209 Remove.
2210 (make_window): Initialize new integer fields to -1.
2211 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
2212 (Fset_window_configuration, save_window_save):
2213 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
2214 (Fset_window_fringes): Adjust user. Return t if any fringe
2215 was actually changed, and mention this in docstring.
2216
e4375ca7
DA
22172013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2218
2219 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
2220 * nsfns.m (x_set_cursor_type):
2221 * w32fns.c (x_set_cursor_type):
2222 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
2223 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 2224
a45543bc
DA
22252013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2226
2227 * font.c (clear_font_cache): New function, stripped from...
2228 (Fclear_font_cache): ...here, which now uses the function
2229 above. Adjust comment.
2230 * font.h (clear_font_cache): Add prototype.
2231 * xfaces.c (clear_face_cache): Use clear_font_cache.
2232
ae966a86
DA
22332013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2234
2235 * window.c (Fset_window_start): Compare `w', not `window' because
2236 `w' might not be equal to `window' after call to decode_live_window.
2237
297a545b
PE
22382013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
2241 This fixes a problem introduced by the Bug#15035 patch
2242 when using GPG. Reported by Herbert J. Skuhra.
2243
aa942e2b
EZ
22442013-08-12 Eli Zaretskii <eliz@gnu.org>
2245
2246 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
2247 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
2248 not yet initialized.
2249
7699d09e
LMI
22502013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2251
2252 * decompress.c (Fzlib_decompress_region): Support zlib
2253 decompression, too, and rename.
2254
1d238bc7
PE
22552013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2256
2257 Minor zlib configuration tweaks.
2258 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
2259 Don't assume presence of fn_inflateInit2_ zlib internal function.
2260
8a44a184
LMI
22612013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2262
2263 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
2264 include the zlib prefix.
2265
594a4307
EZ
22662013-08-12 Eli Zaretskii <eliz@gnu.org>
2267
2268 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
2269 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
2270 define static variables that are pointers to zlib functions to be
2271 dynamically loaded.
2272 (init_zlib_functions) [WINDOWSNT]: New function.
2273 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
2274 New macros.
2275 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
2276 macros instead of invoking the zlib functions directly.
068f9124
SM
2277 (syms_of_decompress): DEFSYM Qzlib_dll.
2278 Staticpro Szlib_available_p.
594a4307 2279
d2e113bc
DA
22802013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
2281
2282 Avoid looping over all frame windows to freeze and unfreeze.
2283 * window.h (struct window): Drop frozen_window_start_p.
2284 (freeze_window_starts): Drop prototype.
2285 * frame.h (struct frame): New frozen_window_starts flag.
2286 (FRAME_WINDOWS_FROZEN): New macro.
2287 * window.c (freeze_window_start, freeze_window_starts):
2288 Remove.
2289 (select_window, replace_window): Adjust users.
2290 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
2291 (window_frozen_p): New function.
2292 (redisplay_window): Use it.
2293
94fcd171
PE
22942013-08-12 Paul Eggert <eggert@cs.ucla.edu>
2295
2296 Fix some fd issues when running subprocesses (Bug#15035).
2297 Fix bugs that can leak files or file descriptors on errors.
2298 Don't unlink open temp files, as that's hard for users to diagnose
2299 when things go awry (e.g., temp disk exhausted).
2300 Don't bother to lock temp files. Check for invalid recursion.
2301 * callproc.c (synch_process_fd): Remove. All uses removed.
2302 (synch_process_tempfile): New var or macro.
2303 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2304 New constants.
2305 (record_kill_process): New arg, the temp name. All callers changed.
2306 (delete_temp_file): Now just a simple wrapper around unlink.
2307 (call_process_kill): New arg, the call_process_fd array.
2308 Close them all. Clear synch_process_pid. Remove the temp file,
2309 or arrange for it to be removed.
2310 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2311 that's been moved to synch_process_tempfile. Caller changed.
2312 Do not remove the tempfile; that's now call_process_kill's
2313 responsibility.
2314 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2315 call_process_kill; the caller now does that.
2316 (call_process_cleanup): Do not close the process fd; that's now
2317 call_process_kill's responsibility.
2318 (Fcall_process): Implement via new function call_process, which
2319 has most of the old body of Fcall_process, but with a different API.
2320 (call_process): New function that does not open or close filefd if
2321 it is nonnegative. Record which fds need to be closed, and let
2322 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2323 Signal an error if invoked recursively (could be done via a hook).
2324 Simplify creation of the tempfile in the MSDOS case.
2325 Don't create the output file until after checking for the executable.
2326 Report any failure to open /dev/null.
2327 Don't open /dev/null for writing twice; once is enough.
2328 Don't create pipe if all output is being discarded or sent to file.
2329 Don't worry about setting up the coding system or reading from the
2330 pipe if all output is being discarded.
2331 Hoist fd_error local into top level, to lessen block nesting.
2332 Don't record deleted pid here; now done by Fcall_process_region.
2333 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2334 and note its success in synch_process_tempfile.
2335 Do not leak resources when child_setup fails.
2336 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2337 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2338 (create_temp_file): Now returns open fd, with an additional
2339 Lisp_Object * argument to return the name. All callers changed.
2340 Do not close the file; rewind it instead, and leave it open for
2341 the caller. Do not lock the temp file. Unwind-protect the file
2342 and the file-descriptor.
2343 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2344 If an asynchrounous process, record it here, not in call_process.
2345 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2346 * eval.c (set_unwind_protect): New function.
2347 * fileio.c (write_region): New function, generalized from the
2348 old Fwrite_region. Do not lock temp files.
2349 (Fwrite_region): Use it.
2350 * lisp.h (set_unwind_protect, write_region): New decls.
2351 * process.c: Include <verify.h>.
2352 (make_process): Mark fds as initially closed.
2353 (deleted_pid_list): Now a list of pid-filename pairs.
2354 All uses changed.
2355 (close_process_fd): New function.
2356 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2357 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2358 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2359 (create_process, create_pty, Fmake_serial_process)
2360 (server_accept_connection): Record which fds need to be closed,
2361 and let deactivate_process close them.
2362 (Fmake_network_process): Do not discard the unwind-protect
2363 until it's safe to do so.
2364 (deactivate_process): Close the fds opened by create_process etc.
2365 (Fprocess_send_eof): Adjust to new way of recording open fds.
2366 Report an error if /dev/null can't be opened, instead of aborting.
2367 * process.h (PROCESS_OPEN_FDS): New constant.
2368 (struct Lisp_Process): New member open_fds.
2369 (record_kill_process, record_deleted_pid): Adjust signatures.
2370 (record_deleted_pid): Move decl here ...
2371 * syswait.h (record_deleted_pid): ... from here.
2372
d0e615c3
PE
23732013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * decompress.c: Fix bugs with large buffers and weird inputs.
2376 Tune a bit. Reindent as per usual Emacs style.
2377 (BUFFER_SIZE): Remove.
2378 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2379 more than UINT_MAX bytes. Decompress into the gap instead of into
2380 an auto buffer, as this should avoid copying. Return nil if
2381 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2382 set immediate_quit; we shouldn't trust zlib code that much.
2383
313546eb
LMI
23842013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2385
99a32242
LMI
2386 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2387 errors, and really move the gap to where we want it.
2388
313546eb
LMI
2389 * lisp.h: Include decompress.c support.
2390
2391 * emacs.c (main): Include decompress.c support.
2392
2393 * Makefile.in: Include -lz if present.
2394
d2d699ac
JD
23952013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2396
f90e3ebd
JD
2397 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2398 (initWithTitle:): Initialize frame to 0.
2399 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2400 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2401 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2402
2403 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2404 fillWithWidgetValue:frame:
2405
423d3b3f
JD
2406 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2407 remove memory leak warnings.
2408
d2d699ac
JD
2409 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2410 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2411 menu_pending_title.
2412
2413 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2414 (x_activate_menubar): Update the whole menu.
2415 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2416 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2417 current event is not NSSystemDefined (Bug#15001).
2418 Call ns_check_menu_open only if trackingMenu is 2.
2419 (menuDidClose:): New method, decrease trackingMenu.
2420 (fillWithWidgetValue:setDelegate:): New method.
2421 (fillWithWidgetValue:): Call the above.
2422
2423 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2424
7d652d97
PE
24252013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 Omit some unnecessary casts.
2428 Many of these go back to the old pre-C89 days, when they may have
2429 been needed, but we've been assuming C89 or later for a while now.
2430 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2431 (live_float_p, live_misc_p, live_vector_p):
2432 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2433 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2434 (defvar_per_buffer):
2435 * callint.c (Fcall_interactively):
2436 * doc.c (Fsubstitute_command_keys):
2437 * filelock.c (get_boot_time):
2438 * frame.c (xrdb_get_resource):
2439 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2440 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2441 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2442 (menuitem_highlight_callback, menu_destroy_callback)
2443 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2444 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2445 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2446 (xg_tool_bar_help_callback, tb_size_cb):
2447 * image.c (xpm_alloc_color, png_read_from_memory)
2448 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2449 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2450 (syms_of_image):
2451 * keymap.c (describe_map):
2452 * nsfns.m (Fns_display_monitor_attributes_list):
2453 * nsmenu.m (process_dialog:):
2454 * nsterm.m (hold_event):
2455 * process.c (wait_reading_process_output):
2456 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2457 * scroll.c (do_direct_scrolling, scrolling_1):
2458 * termcap.c (tgetent):
2459 * window.c (check_window_containing, add_window_to_list)
2460 (freeze_window_starts):
2461 * xdisp.c (compare_overlay_entries, vmessage):
2462 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2463 (x_get_monitor_attributes_xrandr)
2464 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2465 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2466 * xfont.c (xfont_match, xfont_open):
2467 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2468 (menubar_selection_callback, menu_position_func)
2469 (popup_selection_callback, create_and_show_popup_menu)
2470 (dialog_selection_callback, create_and_show_dialog):
2471 * xrdb.c (x_get_string_resource):
2472 (main) [TESTRM]:
2473 * xsmfns.c (x_session_check_input):
2474 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2475 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2476 (xaw_jump_callback, xaw_scroll_callback):
2477 Omit unnecessary casts.
2478
9acc1074
PE
24792013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2480
2481 Minor string-length refactoring.
2482 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2483 * frame.c (make_monitor_attribute_list):
2484 Prefer build_string to strlen + make_string.
2485
361c0eb8
JD
24862013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2487
2488 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2489 don't check minor_code (Bug#14417).
2490
14ba0822
EZ
24912013-08-09 Eli Zaretskii <eliz@gnu.org>
2492
2493 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2494 vertical positions instead. This avoids calling MATRIX_ROW with
2495 row numbers that are possibly beyond valid limits. (Bug#15064)
2496
309f24d1
DA
24972013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2498
2499 Use xstrdup and build_unibyte_string where applicable.
2500 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2501 * xfns.c (x_window):
2502 * xrdb.c (x_get_customization_string):
2503 * xterm.c (xim_initialize):
2504 * w32fns.c (w32_window): Use xstrdup.
2505 (w32_display_monitor_attributes_list):
2506 * emacs.c (init_cmdargs):
2507 * keyboard.c (PUSH_C_STR):
2508 * nsfont.m (nsfont_open):
2509 * sysdep.c (system_process_attributes):
2510 * w32.c (system_process_attributes):
2511 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2512
55902276
EZ
25132013-08-09 Eli Zaretskii <eliz@gnu.org>
2514
2515 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2516 variables of these types so that GDB would know about them, as aid
2517 for debugging fatal exceptions. (Bug#15024) See also
2518 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2519 discussions.
2520
10bf7f5a
JD
25212013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2522
2523 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2524 larger than the NSWindow (Bug#14934).
2525
65620264
DA
25262013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2527
2528 Redesign redisplay interface to drop global variable updated_window.
2529 Always pass currently updated window as a parameter to update routines.
2530 * dispextern.h (updated_window): Remove declaration.
2531 (struct redisplay_interface): Pass window parameter to
2532 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2533 and after_update_window_hook.
2534 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2535 Adjust prototypes.
2536 * dispnew.c (updated_window): Remove.
2537 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2538 (update_window_line): Adjust to match redisplay interface changes.
2539 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2540 (ns_scroll_run, ns_after_update_window_line):
2541 * w32term.c (x_update_window_begin, x_update_window_end)
2542 (x_after_update_window_line, x_scroll_run):
2543 * xterm.c (x_update_window_begin, x_update_window_end)
2544 (x_after_update_window_line, x_scroll_run):
2545 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2546 Likewise. Adjust comments where appropriate.
2547 (x_cursor_to): Simplify because this is always called during window
2548 update (but install debugging check anyway).
2549 (expose_window): Check must_be_updated_p flag to see whether this
2550 function is called during window update.
2551
628fdc56
DA
25522013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2553
2554 Do not reset window modification event counters excessively.
2555 These leftovers and poor man's tricky methods to catch extra
2556 redisplay's attention are no longer needed.
2557 * frame.c (set_menu_bar_lines_1):
2558 * minibuf.c (read_minibuf_unwind):
2559 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2560 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2561 (window_scroll_line_based, Fset_window_configuration):
2562 * xdisp.c (redisplay_window): Do not reset last_modified and
2563 last_overlay_modified counters.
2564
8fd9c92e
JD
25652013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2566
2567 * xselect.c (x_send_client_event): Set send_event and serial, memset
2568 data.l as it might be bigger than data.b. Use 24 bit mask to
2569 XSendEvent (Bug#15034).
2570
0ee18172
EZ
25712013-08-07 Eli Zaretskii <eliz@gnu.org>
2572
2573 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2574 for TTY frames that are not the top frame on their console.
2575 (Bug#14616)
2576
16ddd1a6
MR
25772013-08-07 Martin Rudalics <rudalics@gmx.at>
2578
2579 * w32term.c (w32fullscreen_hook): Really maximize frame when
2580 asked for (Bug#14841).
2581
d2a95ffb
DA
25822013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2583
2584 Prefer selected_window to Fselected_window, likewise for frames.
2585 * buffer.c (Fbuffer_swap_text):
2586 * data.c (Fvariable_binding_locus):
2587 * window.c (run_window_configuration_change_hook): Adjust users.
2588 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2589 Use decode_live_frame.
2590
170da1ec
DA
25912013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2592
2593 Be more careful if selected window shows the buffer other than current,
2594 use window_outdated only if this is not so. This change should also
2595 address some weird issues discussed in Bug#13012.
2596 * window.h (window_outdated): New prototype.
2597 * window.c (window_outdated): Now here. Convert from static and
2598 always assume window's buffer.
2599 (Fwindow_end, Fwindow_line_height): Use it.
2600 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2601 and always assume window's buffer.
2602 (redisplay_window): Adjust user.
e5eefe9b 2603 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2604 check whether mode line should be updated only if selected window
2605 shows current buffer.
2606 (run_window_scroll_functions): Use eassert for debugging check.
2607 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2608
56b5d5b1
DA
26092013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2610
2611 * window.c (window_scroll, window_scroll_pixel_based)
2612 (window_scroll_line_based): Use bool for booleans.
2613
2878ba7e
PE
26142013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 * process.c: Fix minor off-by-one issues in descriptor counts.
2617 This shouldn't fix any real bugs, but it cleans up the code a bit.
2618 (max_process_desc, max_input_desc): -1, not 0, means none.
2619 All uses changed.
2620 (delete_input_desc): New function.
2621 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2622 (deactivate_process): Scan backwards when recomuting max_process_desc;
2623 that should be faster.
2624 (init_process_emacs): Initialize max_input_desc.
2625
e30b79c1
DA
26262013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2627
2628 Use region cache to speedup bidi_find_paragraph_start.
2629 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2630 Rename cache_long_line_scans to cache_long_scans.
2631 * buffer.c (bset_cache_long_line_scans): Rename to
2632 bset_cache_long_scans.
2633 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2634 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2635 into account.
2636 (syms_of_buffer): Rename cache-long-line-scans to
2637 cache-long-scans. Adjust docstring.
2638 * search.c (newline_cache_on_off):
2639 * indent.c (width_run_cache_on_off): Adjust users.
2640 * bidi.c (bidi_paragraph_cache_on_off): New function.
2641 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2642 * insdel.c (prepare_to_modify_buffer):
2643 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2644
00012b86
DA
26452013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2646
2647 Invalidate region caches only if buffer text is going to be changed.
2648 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2649 (modify_text): ...new prototype.
2650 (prepare_to_modify_buffer_1): New prototype.
2651 * textprop.c (modify_region): Rename to...
2652 (modify_text_properties): ...new function.
2653 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2654 (Fremove_list_of_text_properties): Adjust users.
2655 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2656 (modify_text): ...new function.
2657 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2658 (prepare_to_modify_buffer_1): ...new function.
2659 * casefiddle.c (casify_region):
2660 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2661 (Ftranspose_regions): Use modify_text.
2662
dc6c0eda
SM
26632013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2664
2665 * lisp.mk (lisp): Add nadvice.elc.
2666
8f3a2c26
DA
26672013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2668
2669 New macro to iterate over live buffers similar to frames.
2670 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2671 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2672 Declare buffer-related variables here to offload lisp.h.
2673 * buffer.c (Vbuffer_alist): Adjust comment.
2674 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2675 (other_buffer_safely):
2676 * data.c (store_symval_forwarding):
2677 * dispnew.c (Fframe_or_buffer_changed_p):
2678 * fileio.c (Fdo_auto_save):
2679 * filelock.c (unlock_all_files):
2680 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2681
e0fdb694
PE
26822013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2685 * callproc.c (create_temp_file):
2686 * filelock.c (create_lock_file):
2687 Assume mkostemp, since it's now provided by Gnulib.
2688
63f5c6c2
EZ
26892013-08-04 Eli Zaretskii <eliz@gnu.org>
2690
2691 * w32.c (mkostemp): New function.
2692 (mktemp): Remove, no longer used. Most of the code reused in
2693 mkostemp. (Bug#15015)
484ab239 2694 (mktemp): Don't undef.
63f5c6c2 2695
f0b79313
DA
26962013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2697
2698 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2699 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2700 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2701 (free_glyph_pool, check_glyph_memory): Likewise for
2702 all users. Adjust comments where appropriate.
2703
98f638d6
PE
27042013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 * composite.h: Minor fixups.
2707 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2708 to fix a misspelling, and change it to an inline function while
2709 we're at it (it need not be a macro). All uses changed.
2710 (composition_method, composition_valid_p):
2711 Rewrite to avoid assignments in if-conditions.
2712
75c59fb3
DA
27132013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2714
2715 Do not use global Lisp_Object in composition macros.
2716 * composite.h (composition_temp): Remove declaration.
2717 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2718 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2719 (compose_region): Remove the leftover.
75c59fb3
DA
2720 * composite.c (composition_temp): Remove.
2721 (run_composition_function, update_compositions)
2722 (composition_compute_stop_pos, composition_adjust_point)
2723 (Ffind_composition_internal):
2724 * coding.c (handle_composition_annotation):
2725 * xdisp.c (handle_composition_prop, check_point_in_composition):
2726 Related users changed.
2727
a10c8269
DA
27282013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2729
2730 Drop FRAME_PTR typedef.
2731 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2732 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2733 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2734 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2735 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2736 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2737 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2738 All related users changed.
2739
a104f656
SM
27402013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2741
2742 * eval.c (default_toplevel_binding): New function.
2743 (Fdefvar): Use it.
2744 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2745 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2746 (syms_of_eval): Export them.
2747 * data.c (Fdefault_value): Micro cleanup.
2748 * term.c (init_tty): Use "false".
2749
4b5c9326
DA
27502013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2751
2752 Fix X GC leak in GTK and raw (no toolkit) X ports.
2753 * xterm.c (x_free_frame_resources): If white and black relief
2754 GCs are allocated, always free them here.
2755 * xfns.c (x_make_gc): Omit redundant initialization.
2756 * widget.c (create_frame_gcs): Remove the leftover.
2757 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2758 in x_free_frame_resources.
2759
b19aa636
JD
27602013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2761
2762 * nsterm.m (windowWillResize:toSize:): Only change title if
2763 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2764 modifying it.
2765 (viewDidEndLiveResize): New method.
2766
2767 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2768 inside NS_IMPL_COCOA.
2769
af1f7e06
DA
27702013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2771
2772 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2773 Do not check whether undo is enabled because record_insert and
2774 record_delete does that themselves.
2775
65b02bb9
DA
27762013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2777
2778 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2779 member which is not really used any more.
2780 (FRAME_XIC_BASE_FONTNAME): Remove.
2781 * xfns.c (xic_free_fontset): Adjust user.
2782 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2783 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2784 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2785 (xdialog_show): Use eassert for debugging check.
7ee0f047 2786 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2787
6318cde0
PE
27882013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2789
2790 * fileio.c, fns.c (merge): Move extern decl from here ...
2791 * lisp.h (merge): ... to here.
2792
6c1a09ba
DA
27932013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2794
2795 Fix last font-related change.
2796 * w32font.h (w32font_list_internal, w32font_match_internal):
2797 Fix prototype.
2798 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2799 (uniscribe_list_family): Adjust to match font API change.
2800 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2801 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2802
f8c20208
DA
28032013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2804
2805 * frame.h (FRAME_MOUSE_UPDATE):
2806 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2807 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2808
fdb396e2
DA
28092013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2810
2811 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2812 * font.h (struct font_driver): Change list, match, and list_family
2813 functions to accept struct frame * as first arg.
068f9124
SM
2814 * font.c (font_score, font_compare, font_sort_entities):
2815 Remove prototypes.
fdb396e2
DA
2816 (font_sort_entities, font_list_entities, font_select_entity):
2817 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2818 match font API change.
2819 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2820 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2821 * ftxfont.c (ftxfont_list, ftxfont_match):
2822 * xftfont.c (xftfont_list, xftfont_match):
2823 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2824 * w32font.c (w32font_list, w32font_match, w32font_list):
2825 (w32font_list_internal, w32_font_match_internal): Likewise.
2826 * xfaces.c (Fx_family_fonts): Adjust user.
2827
52b8a085
DA
28282013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2829
2830 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2831 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2832 only if HAVE_X_WINDOWS is in use.
2833 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2834 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2835 * w32term.c (x_wm_set_icon_position): Likewise.
2836 * w32fns.c (x_icon): Adjust user.
2837
c791c18e
DA
28382013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2839
2840 * xterm.c (last_mouse_press_frame): Remove the
2841 leftover which is not really used any more.
2842 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2843 (x_flush): Call XFlush once per each X display, not frame.
2844 This is better because this code always unconditionally skips
2845 non-X frames in Vframe_list and issues the only XFlush if we
2846 have more than one X frame on the same X display.
2f935d86
DA
2847 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2848 Use bool for booleans.
2849 (x_draw_glyph_string_background, cvt_string_to_pixel):
2850 (cvt_pixel_dtor): Drop unnecessary prototypes.
2851 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2852
f435830e
DA
28532013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2854
2855 Drop unnecessary functions that deals with frame pixel size.
2856 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2857 (x_pixel_height): Drop prototypes.
2858 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2859 (x_pixel_height): Drop implementations.
2860 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2861 which should be always valid for window frame.
2862 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2863 * w32menu.c (Fx_popup_dialog):
2864 * xmenu.c (Fx_popup_dialog): Likewise for both.
2865
84231434
DA
28662013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2867
2868 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2869 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2870 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2871 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2872 and mention nil frame in docstring.
84231434 2873
959067a1
DA
28742013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2875
2876 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2877 (x_figure_window_size): Likewise. Adjust to return long.
2878 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2879 (toplevel): Move Qterminal_live_p to...
2880 * terminal.c (toplevel): ...here, make it static, and...
2881 (syms_of_terminal): ...DEFSYM here.
2882 * frame.h (Qterminal_live_p): Remove declaration.
2883 (make_frame, x_figure_window_size): Adjust prototype.
2884 * nsfns.m (Fx_create_frame): Use long for window flags.
2885
f4b169ce
PE
28862013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2887
2888 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2889 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2890 Do not assume that emacs_close (INT_MAX) is a no-op.
2891
bee6a2c7
DA
28922013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2893
2894 * xfaces.c (make_face_cache): For struct face_cache, prefer
2895 xmalloc to xzalloc and so avoid redundant call to memset.
2896 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2897
d7e6881a
DA
28982013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2899
2900 * fringe.c (draw_window_fringes, update_window_fringes)
2901 (compute_fringe_widths):
2902 * w32term.c (x_draw_glyph_string):
2903 * window.c (candidate_window_p, Frecenter):
2904 * xfaces.c (realize_basic_faces, realize_default_face)
2905 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2906 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2907 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2908 * xmenu.c (Fx_menu_bar_open_internal):
2909 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2910 * xsettings.c (xft_settings_event):
2911 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2912 Use bool for booleans. Adjust style and comments where
2913 appropriate.
2914 * dispextern.h (draw_window_fringes, update_window_fringes)
2915 (compute_fringe_widths):
2916 * xterm.h (x_had_errors_p): Adjust prototype.
2917
ec3058af
DA
29182013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2919
2920 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2921 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2922
218e0637
DA
29232013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2924
2925 * fns.c (toplevel): Remove comment before Fsafe_length because
2926 it checks for QUIT.
2927
e560aba9
PE
29282013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2931
2e5ce5de
EZ
29322013-07-28 Eli Zaretskii <eliz@gnu.org>
2933
2934 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2935 frame which got the message is still alive, before dereferencing
2936 its pointer. (Bug#14970)
2937
2938 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2939 be a live window, before using it as such. (Bug#14970)
2940
e95da6d3
EZ
29412013-07-27 Eli Zaretskii <eliz@gnu.org>
2942
2943 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2944 w32_detect_focus_change instead of doing part of its job by hand.
2945 This fixes the problem whereby FOCUS_OUT events were not sent to
2946 the event queue.
2947
a8f93651
EZ
29482013-07-26 Eli Zaretskii <eliz@gnu.org>
2949
fec92060
EZ
2950 * process.c (Fprocess_list): Doc fix.
2951
a8f93651
EZ
2952 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2953 being re-exposed only if it didn't ask to become visible.
2954 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2955 was previously iconified. (Bug#14841)
2956 (x_iconify_frame): Mark the frame iconified.
2957
d5a7a9d9
PE
29582013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2959
2960 Fix minor problems found by static checking.
2961 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2962 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2963
56ea7291
SM
29642013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2965
2966 * eval.c (set_specpdl_old_value): New function.
2967 (unbind_to): Minor simplification.
2968 (get_backtrace_frame): New function.
2969 (Fbacktrace_frame): Use it. Add `base' argument.
2970 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2971 (syms_of_eval): Export backtrace-eval.
2972 * xterm.c (x_focus_changed): Simplify.
2973
9d611ffe
PE
29742013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2977
999c74e3
EZ
29782013-07-24 Eli Zaretskii <eliz@gnu.org>
2979
2980 * xdisp.c (redisplay_window): Instead of moving point out of
2981 scroll margin, reject the force_start method, and try scrolling
2982 instead. (Bug#14780)
2983
198fa217
KB
29842013-07-24 Ken Brown <kbrown@cornell.edu>
2985
2986 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2987 (Bug#14944).
2988
53840e55
PE
29892013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 * eval.c (Fprogn): Do not check that BODY is a proper list.
2992 This undoes the previous change. The check slows down the
2993 interpreter, and is not needed to prevent a crash. See
2994 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2995
60967f56
GM
29962013-07-23 Glenn Morris <rgm@gnu.org>
2997
2998 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2999
9ca960e2
PE
30002013-07-23 Paul Eggert <eggert@cs.ucla.edu>
3001
a29c3e6d
PE
3002 Port to GNU/Linux systems with tinfo but not ncurses.
3003 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
3004 to decide whether ncurses is being used. Without this change,
3005 GCC complains about tgetent not being declared, on a system
3006 that has tinfo installed but ncurses not installed.
3007
f274311c
PE
3008 * eval.c (Fprogn): Check that BODY is a proper list.
3009
16b0520a
PE
3010 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
3011 * data.c (Fsetq_default):
3012 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
3013 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
3014 (Fcondition_case):
3015 Tune by taking advantage of the fact that ARGS is always a list
3016 when a function is declared to have UNEVALLED args.
3017
9ca960e2
PE
3018 * emacsgtkfixed.c: Port to GCC 4.6.
3019 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
3020
afacaa1b
JB
30212013-07-23 Juanma Barranquero <lekktu@gmail.com>
3022
3023 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
3024 here to silence compiler warnings.
3025
368a85a4
PE
30262013-07-22 Paul Eggert <eggert@cs.ucla.edu>
3027
3028 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
3029 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
3030 from messing up Emacs's 'struct frame' (Bug#14923).
3031
f4e891b5
PE
30322013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3033
3034 * alloc.c (make_save_ptr_ptr): Define this function.
3035 It was inadvertently omitted. It's needed only if
3036 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
3037
96c8b65e
JD
30382013-07-21 Jan Djärv <jan.h.d@swipnet.se>
3039
3040 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
3041 frame have focus (Bug#14895).
3042
ee010797
PE
30432013-07-21 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 Avoid vfork-related deadlock more cleanly.
3046 * callproc.c (child_setup): When the child's exec fails, output
3047 the program name, as that's more useful. Use O_NONBLOCK to avoid
3048 deadlock.
3049 * process.c (create_process_1): Remove; no longer needed.
3050 (create_process): Remove timer hack; no longer needed, now that
3051 the child avoids deadlock.
3052
f0398ec1 30532013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
3054
3055 * image.c (Fimage_flush): Fix doc typo.
3056
b2a069c2
PE
30572013-07-20 Paul Eggert <eggert@cs.ucla.edu>
3058
6496aec9
PE
3059 Fix array bounds violation when pty allocation fails.
3060 * process.c (PTY_NAME_SIZE): New constant.
3061 (pty_name): Remove static variable; it's now auto.
3062 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
3063 Take pty_name as an arg rather than using a static variable.
3064 All callers changed.
3065 (create_process): Recover pty_flag from process, not from volatile local.
3066 (create_pty): Stay inside array even when pty allocation fails.
3067 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
3068
b2a069c2
PE
3069 * lread.c (Fload): Avoid initialization only when lint checking.
3070 Mention that it's needed only for older GCCs.
3071
99107004
KH
30722013-07-20 Kenichi Handa <handa@gnu.org>
3073
3074 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
3075 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
3076
6b1b199d
AS
30772013-07-20 Andreas Schwab <schwab@linux-m68k.org>
3078
3079 * lread.c (Fload): Avoid uninitialized warning.
3080
4195afc3
PE
30812013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3082
3f5bef16
PE
3083 Fix some minor file descriptor leaks and related glitches.
3084 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
3085 (create_lock_file): Use write, not emacs_write.
3086 * image.c (slurp_file, png_load_body):
3087 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
3088 (server_accept_connection):
3089 Don't leak an fd on memory allocation failure.
3090 * image.c (slurp_file): Add a cheap heuristic for growing files.
3091 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
3092 as that's what the other routines do. Maybe input need not be
3093 blocked at all, but it's better to be consistent.
3094 Avoid undefined behavior when strlen is zero.
3095
4195afc3
PE
3096 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
3097 (NSTATICS): Now a constant; doesn't need to be a macro.
3098
a1aeeffe
RS
30992013-07-19 Richard Stallman <rms@gnu.org>
3100
3101 * coding.c (decode_coding_utf_8): Add simple loop for fast
3102 processing of ASCII characters.
3103
63b34baa
PE
31042013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3105
3106 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
3107
621dd9ac
EZ
31082013-07-19 Eli Zaretskii <eliz@gnu.org>
3109
3110 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
3111 unportable 'struct x_display_info'.
3112 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
3113 is a portable type.
3114
1396ac86
PE
31152013-07-19 Paul Eggert <eggert@cs.ucla.edu>
3116
ab9980cd
PE
3117 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
3118 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
3119 or fscanf fails.
3120 (system_process_attributes): Prefer plain char to unsigned char
3121 when either will do. Clean up properly if interrupted or if
068f9124
SM
3122 memory allocations fail. Don't assume sscanf succeeds.
3123 Remove no-longer-needed workaround to stop GCC from whining.
3124 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
3125 bit more carefully.
3126
1396ac86
PE
3127 Fix obscure porting bug with varargs functions.
3128 The code assumed that int is treated like ptrdiff_t in a vararg
3129 function, which is not a portable assumption. There was a similar
3130 -- though these days less likely -- porting problem with various
3131 assumptions that pointers of different types all smell the same as
3132 far as vararg functions is conserved. To make this problem less
3133 likely in the future, redo the API to use varargs functions.
3134 * alloc.c (make_save_value): Remove this vararg function.
3135 All uses changed to ...
3136 (make_save_int_int_int, make_save_obj_obj_obj_obj)
3137 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
3138 New functions.
3139 (make_save_ptr): Rename from make_save_pointer, for consistency with
3140 the above. Define only on platforms that need it. All uses changed.
3141
4d19d194
PE
31422013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3143
3144 * keyboard.c: Try to fix typos in previous change.
3145 (DISPLAY_LIST_INFO): New macro.
3146 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 3147 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 3148
945c5bb1
JB
31492013-07-18 Juanma Barranquero <lekktu@gmail.com>
3150
3151 * keyboard.c (kbd_buffer_get_event):
3152 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
3153 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
3154
f4b1eb36
PE
31552013-07-18 Paul Eggert <eggert@cs.ucla.edu>
3156
5e679a2c
PE
3157 * filelock.c: Fix unlikely file descriptor leaks.
3158 (get_boot_time_1): Rework to avoid using emacs_open.
3159 This doesn't actually fix a leak, but is better anyway.
3160 (read_lock_data): Use read, not emacs_read.
3161
a8cd4836
PE
3162 * doc.c: Fix minor memory and file descriptor leaks.
3163 * doc.c (get_doc_string): Fix memory leak when doc file absent.
3164 (get_doc_string, Fsnarf_documentation):
3165 Fix file descriptor leak on error.
3166
ef30e638
PE
3167 * term.c: Fix minor fdopen-related file descriptor leaks.
3168 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
3169 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
3170
f4b1eb36
PE
3171 * charset.c: Fix file descriptor leaks and errno issues.
3172 Include <errno.h>.
3173 (load_charset_map_from_file): Don't leak file descriptor on error.
3174 Use plain record_xmalloc since the allocation is larger than
3175 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
3176 of entries.
3177 * eval.c (record_unwind_protect_nothing):
3178 * fileio.c (fclose_unwind):
3179 New functions.
3180 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
3181 The replacement doesn't block input, but that no longer seems
3182 necessary.
3183
b648c163
PE
31842013-07-17 Paul Eggert <eggert@cs.ucla.edu>
3185
a0931322
PE
3186 * lread.c: Fix file descriptor leaks and errno issues.
3187 (Fload): Close some races that leaked fds or streams when 'load'
3188 was interrupted.
3189 (Fload, openp): Report error number of last nontrivial failure to open.
3190 ENOENT counts as trivial.
3191 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
3192 New functions.
3193 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
3194 now that the function is always called with a nonnegative arg.
3195 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
3196 All uses replaced with ...
3197 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
3198
b648c163
PE
3199 A few more minor file errno-reporting bugs.
3200 * callproc.c (Fcall_process):
3201 * doc.c (Fsnarf_documentation):
3202 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
3203 * process.c (set_socket_option):
3204 Don't let a constructor trash errno.
3205 * doc.c: Include <errno.h>.
3206
b1dc4084
JB
32072013-07-16 Juanma Barranquero <lekktu@gmail.com>
3208
3209 * w32fns.c (unwind_create_tip_frame): Fix declaration.
3210
c43843aa
PE
32112013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3212
50a30cce
PE
3213 Fix w32 bug with call-process-region (Bug#14885).
3214 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
3215 to Fcall_process when the input is empty. This simplifies the
3216 code a bit. It makes no difference on POSIXish platforms but
3217 apparently it fixes a bug on w32.
3218
44e18199 3219 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
3220 * fileio.c (close_file_unwind): Don't close if FD is negative;
3221 this can happen when unwinding a zapped file descriptor.
3222 (Finsert_file_contents): Unwind-protect the fd before the point marker,
3223 in case Emacs runs out of memory between the two unwind-protects.
3224 Don't trash errno when closing FD.
3225 Zap the FD in the specpdl when closing it, instead of deferring
3226 the removal of the unwind-protect; this fixes a bug where a child
3227 function unwinds the stack past us.
3228
27e498e6
PE
3229 New unwind-protect flavors to better type-check C callbacks.
3230 This also lessens the need to write wrappers for callbacks,
3231 and the need for make_save_pointer.
3232 * alloca.c (free_save_value):
3233 * atimer.c (run_all_atimers):
3234 Now extern.
3235 * alloc.c (safe_alloca_unwind):
3236 * atimer.c (unwind_stop_other_atimers):
3237 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
3238 * menu.c (cleanup_popup_menu) [HAVE_NS]:
3239 * minibuf.c (choose_minibuf_frame_1):
3240 * process.c (make_serial_process_unwind):
3241 * xdisp.h (pop_message_unwind):
3242 * xselect.c (queue_selection_requests_unwind):
3243 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
3244 * alloca.c (record_xmalloc):
3245 Prefer record_unwind_protect_ptr to record_unwind_protect with
3246 make_save_pointer.
3247 * alloca.c (Fgarbage_collect):
3248 Prefer record_unwind_protect_void to passing a dummy.
3249 * buffer.c (restore_buffer):
3250 * window.c (restore_window_configuration):
3251 * xfns.c, w32fns.c (do_unwind_create_frame)
3252 New wrapper. All record-unwind uses of wrappee changed.
3253 * buffer.c (set_buffer_if_live):
3254 * callproc.c (call_process_cleanup, delete_temp_file):
3255 * coding.c (code_conversion_restore):
3256 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
3257 * editfns.c (save_excursion_restore)
3258 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
3259 (save_restriction_restore):
3260 * eval.c (restore_stack_limits, un_autoload):
3261 * fns.c (require_unwind):
3262 * keyboard.c (recursive_edit_unwind, tracking_off):
3263 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
3264 * macros.c (pop_kbd_macro, restore_menu_items):
3265 * nsfns.m (unwind_create_frame):
3266 * print.c (print_unwind):
3267 * process.c (start_process_unwind):
3268 * search.c (unwind_set_match_data):
3269 * window.c (select_window_norecord, select_frame_norecord):
3270 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
3271 (fast_set_selected_frame):
3272 * xfns.c, w32fns.c (unwind_create_tip_frame):
3273 Return void, not a dummy Lisp_Object. All uses changed.
3274 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
3275 * callproc.c (call_process_kill):
3276 * fileio.c (restore_point_unwind, decide_coding_unwind)
3277 (build_annotations_unwind):
3278 * insdel.c (Fcombine_after_change_execute_1):
3279 * keyboard.c (read_char_help_form_unwind):
3280 * menu.c (unuse_menu_items):
3281 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
3282 * sound.c (sound_cleanup):
3283 * xdisp.c (unwind_redisplay):
3284 * xfns.c (clean_up_dialog):
3285 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
3286 Accept no args and return void, instead of accepting and returning
3287 a dummy Lisp_Object. All uses changed.
3288 * cygw32.c (fchdir_unwind):
3289 * fileio.c (close_file_unwind):
3290 * keyboard.c (restore_kboard_configuration):
3291 * lread.c (readevalllop_1):
3292 * process.c (wait_reading_process_output_unwind):
3293 Accept int and return void, rather than accepting an Emacs integer
3294 and returning a dummy object. In some cases this fixes an
3295 unlikely bug when the corresponding int is outside Emacs integer
3296 range. All uses changed.
3297 * dired.c (directory_files_internal_unwind):
3298 * fileio.c (do_auto_save_unwind):
3299 * gtkutil.c (pop_down_dialog):
3300 * insdel.c (reset_var_on_error):
3301 * lread.c (load_unwind):
3302 * xfns.c (clean_up_file_dialog):
3303 * xmenu.c, nsmenu.m (pop_down_menu):
3304 * xmenu.c (cleanup_widget_value_tree):
3305 * xselect.c (wait_for_property_change_unwind):
3306 Accept pointer and return void, rather than accepting an Emacs
3307 save value encapsulating the pointer and returning a dummy object.
3308 All uses changed.
3309 * editfns.c (Fformat): Update the saved pointer directly via
3310 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3311 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3312 (unwind_body): New function.
3313 (record_unwind_protect): First arg is now a function returning void,
3314 not a dummy Lisp_Object.
3315 (record_unwind_protect_ptr, record_unwind_protect_int)
3316 (record_unwind_protect_void): New functions.
3317 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3318 * fileio.c (struct auto_save_unwind): New type.
3319 (do_auto_save_unwind): Use it.
3320 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3321 * insdel.c (struct rvoe_arg): New type.
3322 (reset_var_on_error): Use it.
3323 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3324 New constants.
3325 (specbinding_func): Remove; there are now several such functions.
3326 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3327 (set_unwind_protect_ptr): New function.
3328 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3329
4e604a5d
PE
3330 Be simpler and more consistent about reporting I/O errors.
3331 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3332 Say "Read error" and "Write error", rather than "I/O error", or
3333 "IO error reading", or "IO error writing", when a read or write
3334 error occurs.
3335 * process.c (Fmake_network_process, wait_reading_process_output)
3336 (send_process, Fprocess_send_eof, wait_reading_process_output):
3337 Capitalize diagnostics consistently. Put "failed foo" at the
3338 start of the diagnostic, so that we don't capitalize the
3339 function name "foo". Consistently say "failed" for such
3340 diagnostics.
3341 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3342 All callers changed. This is so it can use report_file_error.
3343 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3344 diagnostics consistently as above.
3345
a9757f6a
PE
3346 * fileio.c (report_file_errno): Fix errno reporting bug.
3347 If the file name is neither null nor a pair, package it up as a
3348 singleton list. All callers changed, both to this function and to
3349 report_file_error. This fixes a bug where the memory allocator
3350 invoked by list1 set errno so that the immediately following
3351 report_file_error reported the wrong errno value.
3352
c43843aa
PE
3353 Fix minor problems found by --enable-gcc-warnings.
3354 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3355 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3356
18c26d81
JD
33572013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3358
3359 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3360 Set event->arg to Qt if switch-event shall be generated.
3361 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3362
3363 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3364
3365 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3366 FOCUS_OUT_EVENT.
3367
3368 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3369 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3370 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3371 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3372 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3373 and there is a focused frame.
3374 (head_table): Add focus-in and focus-out.
3375 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3376 bind to handle-focus-in/out.
3377
3378 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3379 (Fhandle_switch_frame): Call Fhandle_focus_in.
3380 (syms_of_frame): defsubr handle-focus-in/out.
3381
6c6f1994
PE
33822013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3383
c7ddc792
PE
3384 Fix porting bug to older POSIXish platforms (Bug#14862).
3385 * sysdep.c (emacs_pipe): New function, that implements
3386 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3387 This should port better to CentOS 5 and to Mac OS X 10.6.
3388 All calls to pipe2 changed.
3389
6c6f1994
PE
3390 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3391 This makes the code easier to read and the executable a bit smaller.
3392 Do not replace all calls to Fcons that happen to create lists,
3393 just calls that are intended to create lists. For example, when
3394 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3395 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3396 Similarly for list2 through list5.
3397 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3398 * bytecode.c (exec_byte_code):
3399 * callint.c (quotify_arg, Fcall_interactively):
3400 * callproc.c (Fcall_process, create_temp_file):
3401 * charset.c (load_charset_map_from_file)
3402 (Fdefine_charset_internal, init_charset):
3403 * coding.c (get_translation_table, detect_coding_system)
3404 (Fcheck_coding_systems_region)
3405 (Fset_terminal_coding_system_internal)
3406 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3407 * composite.c (update_compositions, Ffind_composition_internal):
3408 * dired.c (directory_files_internal, file_name_completion)
3409 (Fsystem_users):
3410 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3411 * doc.c (Fsnarf_documentation):
3412 * editfns.c (Fmessage_box):
3413 * emacs.c (main):
3414 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3415 (Feval, eval_sub, Ffuncall, apply_lambda):
3416 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3417 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3418 (Fset_file_times, Finsert_file_contents)
3419 (Fchoose_write_coding_system, Fwrite_region):
3420 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3421 * font.c (font_registry_charsets, font_parse_fcname)
3422 (font_prepare_cache, font_update_drivers, Flist_fonts):
3423 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3424 * frame.c (make_frame, Fmake_terminal_frame)
3425 (x_set_frame_parameters, x_report_frame_params)
3426 (x_default_parameter, Fx_parse_geometry):
3427 * ftfont.c (syms_of_ftfont):
3428 * image.c (gif_load):
3429 * keyboard.c (command_loop_1):
3430 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3431 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3432 (Fminor_mode_key_binding, accessible_keymaps_1)
3433 (Faccessible_keymaps, Fwhere_is_internal):
3434 * lread.c (read_emacs_mule_char):
3435 * menu.c (find_and_return_menu_selection):
3436 * minibuf.c (get_minibuffer):
3437 * nsfns.m (Fns_perform_service):
3438 * nsfont.m (ns_script_to_charset):
3439 * nsmenu.m (ns_popup_dialog):
3440 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3441 (Fx_own_selection_internal):
3442 * nsterm.m (append2):
3443 * print.c (Fredirect_debugging_output)
3444 (print_prune_string_charset):
3445 * process.c (Fdelete_process, Fprocess_contact)
3446 (Fformat_network_address, set_socket_option)
3447 (read_and_dispose_of_process_output, write_queue_push)
3448 (send_process, exec_sentinel):
3449 * sound.c (Fplay_sound_internal):
3450 * textprop.c (validate_plist, add_properties)
3451 (Fput_text_property, Fadd_face_text_property)
3452 (copy_text_properties, text_property_list, syms_of_textprop):
3453 * unexaix.c (report_error):
3454 * unexcoff.c (report_error):
3455 * unexsol.c (unexec):
3456 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3457 (Fformat_mode_line, syms_of_xdisp):
3458 * xfaces.c (set_font_frame_param)
3459 (Finternal_lisp_face_attribute_values)
3460 (Finternal_merge_in_global_face, syms_of_xfaces):
3461 * xfns.c (x_default_scroll_bar_color_parameter)
3462 (x_default_font_parameter, x_create_tip_frame):
3463 * xfont.c (xfont_supported_scripts):
3464 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3465 (menu_help_callback, xmenu_show):
3466 * xml.c (make_dom):
3467 * xterm.c (set_wm_state):
3468 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3469 and similarly for list2 through list5.
3470
bafe80ce
PE
34712013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3472
3473 * callproc.c (Fcall_process_region): Fix minor race and tune.
3474 (create_temp_file): New function, with the temp-file-creation part
3475 of the old Fcall_process_region. Use Fcopy_sequence to create the
3476 temp file name, rather than alloca + build_string, for simplicity.
3477 Don't bother to block input around the temp file creation;
068f9124
SM
3478 shouldn't be needed. Simplify use of mktemp.
3479 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3480 this closes an unlikely race where the temp file was not removed.
3481 Use memcpy rather than an open-coded loop.
3482 (Fcall_process_region): Use the new function. If the input is
3483 empty, redirect from /dev/null rather than from a newly created
3484 empty temp file; this avoids unnecessary file system traffic.
3485
4700b5a5
PE
34862013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3487
5c97beae
PE
3488 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3489 Simplify by making this case like the other two. This is a bit
3490 slower on obsolete hosts, but the extra complexity isn't worth it.
3491
4700b5a5
PE
3492 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3493 * process.c (create_process) [!DOS_NT]:
3494 Remove now-unnecessary calls to emacs_close.
3495
f9a74c4c
EZ
34962013-07-13 Eli Zaretskii <eliz@gnu.org>
3497
922ae7ee
EZ
3498 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3499 returning early. (Bug#14850)
3500
f9a74c4c
EZ
3501 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3502 and inhibit-iso-escape-detection attributes of 'undecided'.
3503 (Bug#14822)
3504
5e301d76
PE
35052013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3506
69e0e5ee
PE
3507 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3508 Reported by Herbert J. Skuhra in
3509 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3510
5e301d76
PE
3511 Don't lose top specpdl entry when memory is exhausted.
3512 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3513 specpdl overflow here, to simplify callers; all callers changed.
3514 Always reserve an unused entry at the stack top; this avoids
3515 losing the top entry's information when memory is exhausted.
3516
7e649856
PE
35172013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3518
a773ed9a
PE
3519 Clean up errno reporting and fix some errno-reporting bugs.
3520 * callproc.c (Fcall_process):
3521 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3522 * process.c (create_process, Fmake_network_process):
3523 * unexaix.c (report_error):
3524 * unexcoff.c (report_error):
3525 Be more careful about reporting the errno of failed operations.
3526 The code previously reported the wrong errno sometimes.
3527 Also, prefer report_file_errno to setting errno + report_file_error.
3528 (Fcall_process): Look at openp return value rather than at path,
3529 as that's a bit faster and clearer when there's a numeric predicate.
3530 * fileio.c (report_file_errno): New function, with most of the
3531 old contents of report_file_error.
3532 (report_file_error): Use it.
3533 (Ffile_exists_p, Ffile_accessible_directory_p):
3534 Set errno to 0 when it is junk.
3535 * fileio.c (Faccess_file):
3536 * image.c (x_create_bitmap_from_file):
3537 Use faccessat rather than opening the file, to avoid the hassle of
3538 having a file descriptor open.
3539 * lisp.h (report_file_errno): New decl.
3540 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3541
7e649856
PE
3542 Minor EBADF fixes.
3543 * process.c (create_process, wait_reading_process_output) [AIX]:
3544 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3545 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3546 a multithreaded environment anyway).
3547 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3548
f6774c1a
AS
35492013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3550
3551 * image.c (x_find_image_file): Don't close a remote file handle.
3552
bacba3c2
PE
35532013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 Fix races with threads and file descriptors.
3556 * callproc.c (Fcall_process_region):
3557 * dired.c (open_directory):
3558 * emacs.c (main, Fdaemon_initialized):
3559 * image.c (x_find_image_file):
3560 * inotify.c (Finotify_rm_watch):
3561 * lread.c (Flocate_file_internal):
3562 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3563 * term.c (term_mouse_moveto, init_tty):
3564 * termcap.c (tgetent):
3565 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3566 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3567 * unexhp9k800.c, unexmacosx.c (unexec):
3568 * callproc.c (Fcall_process_region):
3569 Use emacs_close, not close.
3570 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3571 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3572 and posix_close function on current platforms (which all lack them).
3573 (emacs_close): Use it. This should fix the races on GNU/Linux and
3574 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3575 and it should avoid closing random victim file descriptors on
3576 other platforms.
3577
653d4f43
PE
35782013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3579
c8536ec4
PE
3580 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3581 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3582 Touch up doc a bit.
3583
9c203066
PE
3584 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3585 This is for .gdbinit xbacktrace.
3586
653d4f43
PE
3587 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3588 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3589 (emacs_set_tty): Now static.
3590 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3591 * term.c (tty_capable_p, tty_default_color_capabilities)
3592 (get_tty_terminal, term_mouse_movement)
3593 (handle_one_term_event, init_tty, maybe_fatal):
3594 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3595 (tgetent, scan_file, name_match, compare_contin):
3596 * terminal.c (get_terminal):
3597 Use bool for boolean.
3598 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3599 Prefer char to unsigned char if either will do.
3600 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3601 (tty_write_glyphs): Prefer int to unsigned.
3602 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3603 All callers changed.
3604 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3605
45b683a1
PE
36062013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3607
29abe551
PE
3608 Port to C89.
3609 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3610 (B__dummy__): New dummy symbol, to pacify C89.
3611 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3612 they can't grok varargs macros.
3613 * dispnew.c (add_window_display_history)
3614 (add_frame_display_history):
3615 * print.c (print_object):
3616 * xdisp.c (debug_method_add):
3617 Use %p printf format only for void pointers.
3618 * emacs.c (usage_message): New constant, replacing ...
3619 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3620 (main): Adjust to usage reorg.
3621 * fns.c (syms_of_fns):
3622 * profiler.c (syms_of_profiler):
3623 Don't use non-constant struct initializers.
3624 * gnutls.h (gnutls_initstage_t):
3625 * lisp.h (enum Lisp_Fwd_Type):
3626 * lread.c (lisp_file_lexically_bound_p):
3627 * xsettings.c (anonymous enum):
3628 Remove trailing comma.
3629 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3630 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3631 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3632 (DEFUN): Use it.
3633 * regex.c (const_re_char): New type, to pacify strict C89.
3634 All uses of 'const re_char' replaced to use it.
3635 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3636 with glibc when strict C89. This change is imported from gnulib.
3637 All uses changed.
3638 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3639 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3640 Omit GNU_LINUX implementation, since it requires long long.
3641 * xterm.c (x_draw_underwave):
3642 Do not assume the traditional order of struct's members.
3643 (x_term_init): Rewrite to avoid the need for non-constant structure
3644 initializers.
3645
45b683a1 3646 Syntax cleanup, mostly replacing macros with functions.
763a086d 3647 This removes the need for the syntax_temp hack.
45b683a1
PE
3648 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3649 * syntax.c (SYNTAX_INLINE): New macro.
3650 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3651 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3652 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3653 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3654 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3655 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3656 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3657 Now constants, not macros.
3658 (syntax_temp) [!__GNUC__]: Remove.
3659 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3660 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3661 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3662 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3663 Move here from syntax.h; now functions, not macros. Except for the
3664 last function, these are static since only syntax.c uses them.
3665 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3666 All uses changed. Now a function, not a macro; use this fact
3667 to simplify the code.
3668 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3669 compiler bugs; no longer relevant.
3670 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3671 (SYNTAX_INLINE): New macro.
3672 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3673 for the new functions. Use bool for boolean member.
3674 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3675 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3676 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3677 (SETUP_BUFFER_SYNTAX_TABLE):
3678 Now extern inline functions, not macros.
3679 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3680 Remove; all uses replaced by implementation.
3681 (syntax_temp) [!__GNUC__]: Remove decl.
3682 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3683
29be4a50
JD
36842013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3685
3686 * emacs.c (main): Fix syntax error.
3687
954b166e
PE
36882013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 Timestamp fixes for undo (Bug#14824).
3691 * atimer.c (schedule_atimer):
3692 * fileio.c (Ffile_newer_than_file_p):
3693 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3694 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3695 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3696 (syms_of_fileio): Remove Sclear_visited_file_name.
3697 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3698 file doesn't exist; this avoids an ambiguity with negative timestamps.
3699 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3700 * systime.h (make_emacs_time, invalid_emacs_time):
3701 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3702 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3703 * undo.c (record_first_change): Push (visited-file-modtime) onto
3704 undo list rather than reimplementing it by hand, incorrectly.
3705
d74647c3
KB
37062013-07-09 Ken Brown <kbrown@cornell.edu>
3707
3708 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3709
3c51b96b
JB
37102013-07-09 Juanma Barranquero <lekktu@gmail.com>
3711
3712 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3713
4ebbdd67
PE
37142013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3715
3716 Handle errno and exit status a bit more carefully.
3717 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3718 number into an exit status. Instead, use EXIT_CANCELED.
3719 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3720 * callproc.c (relocate_fd):
3721 * emacs.c (close_output_streams, main):
3722 * process.c (create_process):
3723 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3724 Use emacs_perror for simplicity.
3725 * callproc.c (relocate_fd, main):
3726 * sysdep.c (sys_subshell):
3727 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3728 (shut_down_emacs): Use emacs_write, not write.
3729 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3730 * fileio.c (Fcopy_file, e_write):
3731 * nsterm.m (ns_select):
3732 * process.c (send_process):
3733 * sound.c (vox_write):
3734 Use emacs_write_sig, not emacs_write.
3735 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3736 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3737 New constants.
3738 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3739 of write.
3740 (emacs_full_write): New function.
3741 (emacs_write): Rewrite to use it.
3742 (emacswrite_sig, emacs_perror): New functions.
3743 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3744
44e18199 37452013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3746
3747 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3748 on NS even if it is present. Pixmap on NS is a void*.
3749
9caab067
PE
37502013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3751
3752 Port to Ubuntu 10 (Bug#14803).
3753 Problem reported by T.V. Raman.
3754 * process.c (close_on_exec, accept4, process_socket):
3755 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3756
1d442672
EZ
37572013-07-07 Eli Zaretskii <eliz@gnu.org>
3758
3759 * w32.c (sys_dup): Declare prototype.
3760
3761 * filelock.c:
3762 * emacs.c:
3763 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3764
067428c1
PE
37652013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3766
3767 Make file descriptors close-on-exec when possible (Bug#14803).
3768 This simplifies Emacs a bit, since it no longer needs to worry
3769 about closing file descriptors by hand in some cases.
3770 It also fixes some unlikely races. Not all such races, as
3771 libraries often open files internally without setting
3772 close-on-exec, but it's an improvement.
3773 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3774 * callproc.c (Fcall_process) [!MSDOS]:
3775 * emacs.c (main) [!DOS_NT]:
3776 * nsterm.m (ns_term_init):
3777 * process.c (create_process):
3778 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3779 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3780 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3781 Prefer mkostemp with O_CLOEXEC to mkstemp.
3782 * callproc.c (relocate_fd) [!WINDOWSNT]:
3783 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3784 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3785 now using pipe2.
3786 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3787 Make the resulting file descriptor close-on-exec.
3788 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3789 * lread.c (load_descriptor_list, load_descriptor_unwind):
3790 Remove; no longer needed. All uses removed.
3791 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3792 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3793 New functions.
3794 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3795 (Fmake_network_process, Fnetwork_interface_list):
3796 (Fnetwork_interface_info, server_accept_connection):
3797 Make newly-created socket close-on-exec.
3798 * sysdep.c (emacs_open, emacs_fopen):
3799 Make new-created descriptor close-on-exec.
3800 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3801 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3802
0da857dd
JD
38032013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3804
3805 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3806 for NS_IMPL_GNUSTEP.
3807
5f86adcd
PE
38082013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3809
3810 Fix openp errno handling.
3811 * callproc.c (Fcall_process): Preserve openp errno around close.
3812 * lread.c (openp): Set errno when returning -1, as some callers
3813 expect this.
3814
1afb1d07
JD
38152013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3816
3817 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3818
3819 * nsterm.h (NSSavePanel): Update comment.
3820 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3821 (ns_run_file_dialog): Declare.
3822
3823 * nsfns.m: Remove panelOK.
3824 (ns_fd_data): New.
3825 (ns_run_file_dialog): New function.
3826 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3827 event loop, so file dialog is popped up by ns_run_file_dialog, called
3828 by sendEvent (Bug#14578).
3829 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3830
3323c263
EZ
38312013-07-06 Eli Zaretskii <eliz@gnu.org>
3832
fdda0220
EZ
3833 * xdisp.c (default_line_pixel_height): New function.
3834 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3835 (try_cursor_movement, redisplay_window, try_window)
3836 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3837
068f9124
SM
3838 * window.c (window_scroll_pixel_based):
3839 use default_line_pixel_height.
fdda0220
EZ
3840
3841 * dispextern.h (default_line_pixel_height): Add prototype.
3842
3843 * frame.c (x_set_line_spacing): Accept a float value for
3844 line-spacing parameter, per the documentation.
3845
3323c263
EZ
3846 * data.c (Fmultibyte_string_p): Doc fix.
3847
47ba6d43
PE
38482013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3849
406af475
PE
3850 Use emacs_open more consistently when opening files.
3851 This handles EINTR more consistently now, and makes it easier
3852 to introduce other uniform changes to file descriptor handling.
3853 * src/systdio.h: New file.
3854 * src/buffer.c (mmap_init):
3855 * cygw32.c (chdir_to_default_directory):
3856 * dispnew.c (Fopen_termscript):
3857 * emacs.c (Fdaemon_initialized):
3858 * fileio.c (Fdo_auto_save):
3859 * image.c (slurp_file, png_load_body, jpeg_load_body):
3860 * keyboard.c (Fopen_dribble_file):
3861 * lread.c (Fload):
3862 * print.c (Fredirect_debugging_output):
3863 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3864 * termcap.c (tgetent):
3865 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3866 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3867 * w32term.c (w32_initialize) [CYGWIN]:
3868 * xfaces.c (Fx_load_color_file):
3869 Use emacs_open instead of plain open, and emacs_fopen instead of
3870 plain fopen.
3871 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3872 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3873 * callproc.c (default_output_mode): New constant.
3874 (Fcall_process): Use it to call emacs_open instead of plain creat.
3875 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3876 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3877 (emacs_fopen): New function.
3878 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3879 Include <lisp.h>, for emacs_open.
3880 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3881
47ba6d43
PE
3882 Remove duplicate #include directives.
3883 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3884 * xfaces.c:
3885 Don't include stdio.h twice.
3886 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3887 Don't include sys/types.h or stdio.h twice.
3888 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3889 * lread.c: Don't include coding.h twice.
3890 * nsfont.m: Don't include frame.h twice.
3891 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3892 * ralloc.c: Don't include <unistd.h> twice.
3893 * xdisp.c: Don't include font.h twice.
3894 * xterm.c: Don't include fontset.h twice.
3895 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3896
b9ed53d5
PE
38972013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3898
3899 Scale ImageMagick images more carefully.
3900 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3901 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3902 Be more careful about avoiding undefined behavior after
3903 integer overflow and division by zero.
3904
cf13177e
YM
39052013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3906
3907 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3908 (syms_of_w32fns): DEFSYM them.
3909 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3910 (CCHDEVICENAME): Define macros if not defined.
3911 (struct MONITOR_INFO_EX): New struct.
3912 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3913 (enum_display_monitors_fn): New variable.
3914 (globals_of_w32fns): Initialize it.
3915 (Fx_display_pixel_width, Fx_display_pixel_height)
3916 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3917 multi-monitor setups in docstrings.
3918 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3919 screen size by primary monitor's millimeter per pixel.
3920 (w32_monitor_enum, w32_display_monitor_attributes_list)
3921 (w32_display_monitor_attributes_list_fallback)
3922 (Fw32_display_monitor_attributes_list): New functions.
3923 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3924
3925 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3926 if not defined.
3927 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3928
86dfb7a8
MA
39292013-07-04 Michael Albinus <michael.albinus@gmx.de>
3930
3931 * fileio.c (Qfile_notify_error): New error symbol.
3932
3933 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3934 * inotify.c (inotify_callback, symbol_to_inotifymask)
3935 (Finotify_add_watch, Finotify_rm_watch): Use it.
3936 (inotifyevent_to_event): Exchange order of cookie and file name.
3937 (Finotify_add_watch): Adapt docstring.
3938
3939 * lisp.h (Qfile_notify_error): Declare.
3940
2c1c974b
PE
39412013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3944 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3945 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3946 which did not work (see <http://bugs.gnu.org/14569#307>).
3947 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3948 && (!noninteractive || initialized)). This attempts to thread
3949 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3950
7a35b20f
JB
39512013-07-04 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3954 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3955
1ce5cd04
PE
39562013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3959 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3960 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3961 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3962
57f8c490
PE
39632013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3964
3965 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3966 Define to __sys_siglist.
3967
bcffb5ca
EZ
39682013-07-02 Eli Zaretskii <eliz@gnu.org>
3969
3970 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3971 word-wrap, so that overflow-newline-into-fringe would work in
3972 visual-line-mode. (Bug#2749)
3973 (move_it_in_display_line_to): When the last scanned display
3974 element fits exactly on the display line, and
3975 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3976 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3977 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3978 finding buffer position that corresponds to pixel coordinates,
3979 e.g. in buffer_posn_from_coords.
3980
2c41e781
JD
39812013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3982
3983 * process.c (handle_child_signal): Call catch_child_signal if
3984 NS_IMPL_GNUSTEP.
3985
c2418359
PE
39862013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3987
52a9bcae
PE
3988 Don't convert function pointers to void * and back.
3989 It isn't portable C, and it's easy enough to avoid.
3990 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3991 (make_save_value): Add support for SAVE_FUNCPOINTER.
3992 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3993 * print.c (print_object):
3994 Distinguish function from object pointers.
3995 * lisp.h (SAVE_FUNCPOINTER): New constant.
3996 (SAVE_SLOT_BITS): Adjust to it.
3997 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3998 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3999 (voidfuncptr): New typedef.
4000 (struct Lisp_Save_Value): New member data[0].funcpointer.
4001 (XSAVE_FUNCPOINTER): New function.
4002
c2418359
PE
4003 Simplify buildobj processing.
4004 * Makefile.in (buildobj.h): Make it a sequence of strings each
4005 followed by comma, rather than a single string. Put it into a
4006 .tmp file in case there's an error while generating it.
4007 (gl-stamp): Use .tmp for temp files.
4008 (mostlyclean): Clean .tmp files.
4009 * doc.c (buildobj): Move to just the routine that needs it.
4010 It's now an array of strings, so processing is simpler.
4011
8f43ce49
PE
40122013-07-01 Paul Eggert <eggert@cs.ucla.edu>
4013
4014 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
4015 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
4016 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
4017 Invoke malloc_enable_thread even when not interactive.
4018 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
4019 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
4020 in this case, since the underlying bug has now been fixed.
4021
24827db9
JB
40222013-07-01 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
4025 unlinking it (bug#14691).
4026
ef099a94
MN
40272013-06-30 Michal Nazarewicz <mina86@mina86.com>
4028
4029 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
4030 before checking whether buffer is modified. This lets
4031 `kill-buffer-query-functions' cancel killing of the buffer or save
4032 its content before `kill-buffer' asks user the "Buffer %s
4033 modified; kill anyway?" question.
4034
9d3f2fc2
JD
40352013-06-30 Jan Djärv <jan.h.d@swipnet.se>
4036
4037 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
4038 Let the super performKeyEquivalent deal with them (Bug#14747).
4039
e6c6c8c7
PE
40402013-06-30 Paul Eggert <eggert@cs.ucla.edu>
4041
1d71c1d9
PE
4042 * widget.c (resize_cb): Remove unused local.
4043
8f5f35cc
PE
4044 Do not use GTK 3 if it exists but cannot be compiled.
4045 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
4046 * xterm.c (x_error_handler) [!USE_GTK]:
4047 Do not use GTK 3.
4048
e6c6c8c7
PE
4049 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
4050
0ba54312
EZ
40512013-06-30 Eli Zaretskii <eliz@gnu.org>
4052
5d1c3286
EZ
4053 * intervals.c (get_local_map): Instead of aborting, clip POSITION
4054 to the valid range of values. (Bug#14753)
4055
0ba54312
EZ
4056 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
4057 when moving point by using the current glyph matrix. This avoids
4058 the need to force redisplay when this function is called in a
4059 loop.
4060
9c90cc06
PE
40612013-06-29 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 Fix minor problems found by static checking.
4064 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
4065 Redo the latter's body to sidestep GCC parenthesization warnings.
4066 (setup_coding_system, detect_coding, detect_coding_system): Use them.
4067 * coding.c (detect_coding, detect_coding_system):
4068 * coding.h (struct undecided_spec):
4069 Use bool for boolean.
4070 * image.c (QCmax_width, QCmax_height): Now static.
4071 * xdisp.c (Fmove_point_visually): Remove unused local.
4072
4c672a0f
EZ
40732013-06-29 Eli Zaretskii <eliz@gnu.org>
4074
4075 * xdisp.c (Fmove_point_visually): New function.
4076
c1ea3abf
JB
40772013-06-28 Kenichi Handa <handa@gnu.org>
4078
4079 * coding.h (define_coding_undecided_arg_index): New enum.
4080 (coding_attr_index): New members
4081 coding_attr_undecided_inhibit_null_byte_detection,
4082 coding_attr_undecided_inhibit_iso_escape_detection,
4083 coding_attr_undecided_prefer_utf_8.
4084 (undecided_spec): New struct.
4085 (struct coding_system): New member `undecided' of the member
4086 `spec'.
4087
4088 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
4089 (detect_coding): Likewise.
4090 (detect_coding_system): Likewise.
4091 (Fdefine_coding_system_internal): New coding system properties
4092 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
4093 :prefer-utf-8.
4094 (syms_of_coding): Adjust for coding_arg_undecided_max.
4095
ba3de9e6
PE
40962013-06-28 Paul Eggert <eggert@cs.ucla.edu>
4097
4098 * image.c (x_from_xcolors): Remove unused local.
4099
547c9269
YM
41002013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4101
4102 Defer image data transfer between X client and server until actual
4103 display happens.
4104
4105 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
4106 and `mask_img'.
4107
4108 * image.c (Destroy_Image): Remove.
4109 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
4110 `mask_p', and `colors_p'. All uses changed.
4111 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
4112 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
4113 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
4114 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
4115 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 4116 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
4117 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
4118 (image_get_x_image, image_unget_x_image): New functions or macros.
4119 (image_background, image_background_transparent, x_to_xcolors)
4120 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
4121 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
4122 instead of Destroy_Image.
4123 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
4124 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
4125 (png_load_body, jpeg_load_body, tiff_load, gif_load)
4126 (imagemagick_load_image, svg_load_image): Use them instead of
4127 x_create_x_image_and_pixmap, and x_put_x_image followed by
4128 x_destroy_x_image, respectively.
4129 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
4130 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
4131 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
4132 background_transparent fields.
4133 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
4134 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
4135
dae2f5ef
PE
41362013-06-27 Paul Eggert <eggert@cs.ucla.edu>
4137
4138 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
4139 This mostly consists of undoing recent changes.
4140 * callproc.c (Fcall_process):
4141 * process.c (create_process):
4142 Do not worry about catching SIGCHLD here, undoing previous change.
4143 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
4144 * process.c, process.h (catch_child_signal):
4145 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
4146 * process.c (catch_child_handler): Don't worry about being called
4147 lazily and do not assume caller has blocked SIGCHLD, undoing
4148 previous change. Move first-time stuff back to
4149 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
4150 tickle glib, as that causes Cygwin bootstrap to fail. Do not
4151 set lib_child_handler if it's already initialized, which may
4152 help avoid problems on GNUStep.
4153
fa55d2aa
PE
41542013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
4157 * callproc.c (Fcall_process):
4158 * process.c (create_process):
4159 Make sure SIGCHLD is caught before we fork,
4160 since Emacs startup no arranges to catch SIGCHLD.
4161 * process.c (lib_child_handler): Initialize to null, not to
4162 dummy_handler.
4163 (catch_child_signal): Allow self to be called lazily.
4164 Do nothing if it's already been called.
4165 Assume caller has blocked SIGCHLD (all callers do now).
4166 * emacs.c (main): Do not catch SIGCHLD here; defer it until
4167 just before it's really needed.
4168 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
4169 since it hasn't been caught yet.
4170
f3f9606c
LMI
41712013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
4172
4173 * image.c (compute_image_size): New function to implement
4174 :max-width and :max-height.
4175 (imagemagick_load_image): Use it.
4176
c7041908
PE
41772013-06-23 Paul Eggert <eggert@cs.ucla.edu>
4178
4179 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
4180 * callproc.c, process.h (block_child_signal, unblock_child_signal):
4181 Now extern.
4182 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
4183 * process.c (catch_child_signal): Block SIGCHLD while futzing with
4184 the SIGCHLD handler, since the code is not atomic and (due to glib)
4185 signals may be arriving now.
4186 * sysdep.c (init_signals): Do not catch child signals here;
4187 'main' now does that later, at a safer time.
4188
f86852b4
PE
41892013-06-22 Paul Eggert <eggert@cs.ucla.edu>
4190
0dfeed58
PE
4191 Clean up SIGCHLD handling a bit (Bug#14569).
4192 * process.c, process.h (catch_child_signal):
4193 Now always extern, even if !NS_IMPL_GNUSTEP.
4194 * process.c (catch_child_signal): Move glib tickler here from
4195 init_process_emacs, so that it's done earlier in Emacs
4196 initialization. Also move the noninteractive && !initialized
4197 check here from init_process_emacs. This is all a bit cleaner for
4198 GNUish platforms, and I hope it works around the Cygwin bug.
4199 * sysdep.c (init_signals): Invoke catch_child_signal here, so
4200 that glib signal handling is tickled before glib creates threads.
4201
f86852b4
PE
4202 * process.c (wait_reading_process_output): Avoid int overflow
4203 when reading more than 2 GiB total from a process.
4204
cbd6509c
PE
42052013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4206
4207 * process.c (create_process): Handle a couple more cases,
4208 i.e., work even if new_argv and wait_child_setup[i] are cached.
4209 Use Fcall_process's style for volatile vars.
4210
9de1114a
AS
42112013-06-21 Andreas Schwab <schwab@linux-m68k.org>
4212
4213 * process.c (create_process): Mark PROCESS volatile.
4214
fbe9e0b9
PE
42152013-06-21 Paul Eggert <eggert@cs.ucla.edu>
4216
4217 Use C99-style flexible array members if available.
4218 This avoids some subtle aliasing issues, which typically
4219 aren't a problem with GCC but may be a problem elsewhere.
4220 * alloc.c (sdata): New typedef, replacing the old struct sdata.
4221 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
4222 In either case, it uses a flexible array member rather than
4223 the old struct hack. All uses changed.
4224 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
4225 Adjust to sdata reorganization.
4226 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
4227 Use offsetof (struct, flex_array_member), not sizeof (struct), as
4228 that ports better to pre-C99 non-GCC.
4229 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
4230 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
4231 as the latter has changed.
4232 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
4233 and port better to pre-C99 GCC.
4234 * image.c (struct xpm_cached_color):
4235 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
4236 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
4237 Use FLEXIBLE_ARRAY_MEMBER.
4238 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
4239 Move decl to top level so it gets checked against implementation.
4240 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
4241 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
4242
1fc71008
PE
42432013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4244
4245 * syntax.c: Integer cleanups.
4246 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
4247 All uses that need 0-or-2 changed to:
4248 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
4249 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
4250 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
4251 (char_quoted, prev_char_comend_first, back_comment)
4252 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4253 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
4254 Use bool for boolean.
4255 (update_syntax_table, skip_chars, skip_syntaxes):
4256 Prefer int to unsigned when either will do.
4257 (back_comment): Return boolean success flag, like forw_comment,
4258 instead of positive-or-minus-1 (which might have overflowed int anyway).
4259 Don't stuff ptrdiff_t into int.
4260 (syntax_spec_code, syntax_code_spec): Now const.
4261 (Fmatching_paren, scan_lists, scan_sexps_forward):
4262 Use enum syntaxcode for syntax code.
4263 (Fmatching_paren): Check that arg is a character, not just an integer.
4264 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
4265 (Finternal_describe_syntax_value): Omit no-longer-needed
4266 comparison to 0.
4267 (skip_chars): Use char, not unsigned char, when the distinction
4268 doesn't matter.
4269 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
4270 * bytecode.c (exec_byte_code):
4271 * syntax.c (syntax_spec_code, Fchar_syntax)
4272 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
4273 (init_syntax_once):
4274 * syntax.h (SYNTAX_WITH_FLAGS):
4275 Omit unnecessary casts.
4276
b932cad7
EZ
42772013-06-20 Eli Zaretskii <eliz@gnu.org>
4278
4279 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
4280 line dimensions here, to avoid race conditions with the main
4281 thread. (Bug#14062, bug#14630, bug#14669)
4282
4283 * w32term.c (w32_draw_window_cursor): Compute the header line and
4284 mode line dimensions here.
4285 <w32_system_caret_window, w32_system_caret_hdr_height>:
4286 <w32_system_caret_mode_height>: New variables.
4287
4288 * w32term.h: Declare them.
4289
89561f72
PE
42902013-06-20 Paul Eggert <eggert@cs.ucla.edu>
4291
5013fc08
PE
4292 * alloc.c (die): Move "assertion failed" string here ...
4293 * lisp.h (eassert): ... from here. Also, suppress evaluation of
4294 COND when SUPPRESS_CHECKING. This shrinks the executable text
4295 size by 0.8% to 2.2% when configured with --enable-checking,
4296 depending on optimization flags (GCC 4.8.1 x86-64).
4297
89561f72
PE
4298 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
4299
763a086d 43002013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
4301
4302 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4303 base is 2; this is more accurate.
4304
983aeb9a
JB
43052013-06-19 Juanma Barranquero <lekktu@gmail.com>
4306
4307 * sound.c (string_default): Move to !WINDOWSNT section.
4308 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4309
178ba3e6
PE
43102013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4311
bbc51b15
PE
4312 * sound.c: Integer cleanups.
4313 Remove unnecessary forward decls.
4314 (struct sound_device): The 'file' member is now a Lisp_Object, not
4315 a char *, so that we needn't invoke alloca on a huge size.
4316 (Fplay_sound_internal): Adjust to this.
4317 (string_default): New function.
4318 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4319 Use it to adjust to the struct sound_device change.
4320 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4321 (be2hs) [0]: Remove.
4322
178ba3e6
PE
4323 * syntax.c (skip_chars): Don't use uninitialized storage
4324 when searching a multibyte buffer for characters that are not in a
4325 unibyte string that contains non-ASCII characters.
4326
69f60cdc
JD
43272013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4328
4329 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4330 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4331
0d6224d4
PE
43322013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4335
3c542890
KH
43362013-06-18 Kenichi Handa <handa@gnu.org>
4337
f7e3f7cd
KH
4338 * font.c (Ffont_spec): Signal an error for an invalid font name
4339 (Bug#14648).
3c542890 4340
9349e5f7
PE
43412013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4342
4343 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4344 In particular this ports to 32-bit sparc Sun cc.
4345 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4346 array with a dummy element at specpdl[-1], so that its address can
4347 be taken portably.
4348 (unbind_to): Do not copy the binding; not needed, now that we
4349 copy old_value in the one place where the copy is needed.
4350 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4351 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4352 (union specbinding): Rename from struct specbinding. Redo layout
4353 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4354 which is not portable. With Sun C 5.12 32-bit sparc, the
4355 declaration causes nargs to be an unsigned bitfield, a behavior
4356 that the C standard allows; but Emacs wants nargs to be signed.
4357 The overall type is now a union of structures rather than a
4358 structure of union of structures, and the 'kind' member is now a
4359 bitfield, so that the overall type doesn't grow. All uses changed.
4360 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4361
0a4df6a5
PE
43622013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4363
ec6ecaad
PE
4364 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4365 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4366
0a4df6a5
PE
4367 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4368
7bfe8dbc
EZ
43692013-06-17 Eli Zaretskii <eliz@gnu.org>
4370
4371 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4372 unless we know that the window w's frame is a frame object.
4373 Another attempt at solving bug#14062 and bug#14630.
4374
708e05f6
LMI
43752013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4376
4377 * textprop.c (property_set_type): New enum.
4378 (add_properties): Allow appending/prepending text properties.
4379 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4380 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4381 add_text_properties_1.
4382 (Fadd_face_text_property): New function that calls
4383 add_text_properties_1.
4384
84575e67
PE
43852013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 Move functions from lisp.h to individual modules when possible.
4388 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4389 * alloc.c (XFLOAT_INIT, set_symbol_name):
4390 * buffer.c (CHECK_OVERLAY):
4391 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4392 (set_char_table_parent):
4393 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4394 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4395 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4396 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4397 (set_blv_valcell):
4398 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4399 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4400 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4401 (backtrace_args, backtrace_debug_on_exit):
4402 * floatfns.c (CHECK_FLOAT):
4403 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4404 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4405 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4406 (set_hash_index_slot):
4407 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4408 * marker.c (CHECK_MARKER):
4409 * textprop.c (CHECK_STRING_OR_BUFFER):
4410 * window.c (CHECK_WINDOW_CONFIGURATION):
4411 Move here from lisp.h, and make these functions static rather than
4412 extern inline.
4413 * buffer.c (Qoverlayp):
4414 * data.c (Qsubrp):
4415 * fns.c (Qhash_table_p):
4416 * window.c (Qwindow_configuration_p):
4417 Now static.
4418 * lisp.h: Remove the abovementioned defns and decls.
4419
44e18199 4420 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4421 In lisp.h, prefer functions to function-like macros, and
4422 constants to object-like macros, when either will do. This:
4423 . simplifies use, as there's no more need to worry about
4424 arguments' side effects being evaluated multiple times.
4425 . makes the code easier to debug on some platforms.
4426 However, when using gcc -O0, keep using function-like macros
4427 for a few critical operations, for performance reasons.
4428 This sort of thing isn't needed with gcc -Og, but -Og
4429 is a GCC 4.8 feature and isn't widely-enough available yet.
4430 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4431 Remove enum lsb_bits; no longer needed.
4432 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4433 * buffer.c (Qoverlap):
4434 * data.c (Qsubrp):
4435 * fns.c (Qhash_table_p):
4436 Now extern, so lisp.h can use these symbols.
4437 * dispextern.h: Include character.h, for MAX_CHAR etc.
4438 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4439 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4440 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4441 (GLYPH_CODE_P): Move here from lisp.h.
4442 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4443 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4444 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4445 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4446 XUNTAG now returns void *.
4447 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4448 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4449 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4450 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4451 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4452 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4453 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4454 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4455 New macros, renamed from their sans-lisp_h_ counterparts.
4456 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4457 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4458 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4459 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4460 If compiling via GCC without optimization, define these as macros
4461 in addition to inline functions.
4462 To disable this, compile with -DINLINING=0.
4463 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4464 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4465 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4466 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4467 (INTMASK, VALMASK): Now macros, since static values cannot be
4468 accessed from extern inline functions.
4469 (VALMASK): Also a constant, for benefit of old GDB.
4470 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4471 is INTEGERP, which can fold it in.
5165d44a 4472 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4473 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4474 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4475 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4476 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4477 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4478 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4479 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4480 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4481 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4482 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4483 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4484 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4485 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4486 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4487 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4488 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4489 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4490 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4491 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4492 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4493 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4494 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4495 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4496 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4497 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4498 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4499 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4500 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4501 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4502 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4503 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4504 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4505 Now functions.
4506 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4507 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4508 (VALMASK): Define in one place rather than in two, merging the
4509 USE_LSB_TAG parts; this is simpler.
4510 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4511 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4512 Move up, to avoid use before definition.
4513 Also include "globals.h" earlier, for the same reason.
4514 (make_natnum): New function.
4515 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4516 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4517 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4518 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4519 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4520 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4521 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4522 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4523 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4524 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4525 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4526 (Qwindow_configuration_p, Qimage): New forward declarations.
4527 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4528 (STRING_COPYIN): Remove; unused.
4529 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4530 (xcar_addr, xcdr_addr): New functions. All uses changed.
4531 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4532 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4533 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4534 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4535 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4536 (TYPE_RANGED_INTEGERP): Simplify.
4537 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4538 (setlocale, fixup_locale, synchronize_system_messages_locale)
4539 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4540 Now empty functions, not macros.
4541 (functionp): Return bool, not int.
4542 * window.c (Qwindow_configuration_p): Now extern,
4543 so window.h can use it.
4544 * window.h (Qwindowp): Move decl back to lisp.h.
4545
9583ec36
EZ
45462013-06-15 Eli Zaretskii <eliz@gnu.org>
4547
4548 * xdisp.c (Fline_pixel_height): New function, required for solving
4549 bug #14567.
4550
210272ce
PE
45512013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4552
4553 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4554
de0503df
SM
45552013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4556
4557 * lread.c (syms_of_lread):
4558 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4559
afbfe143
KD
45602013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4561
4562 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4563
d177e213
XF
45642013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4565
4566 * fileio.c (expand_file_name): Doc fix.
4567
05e3e412
PE
45682013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4569
f7394b12
PE
4570 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4571 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4572 Wait for self, not for 0. This can't hurt on GNU or similar
4573 system, and may help with Cygwin.
4574
05e3e412
PE
4575 * keyboard.c: Don't use PROP (...) as an lvalue.
4576 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4577 Use set_prop (A, B), not PROP (A) = B.
4578
17dd3097
EZ
45792013-06-10 Eli Zaretskii <eliz@gnu.org>
4580
4581 * xdisp.c (get_it_property): Use it->window instead of generating
4582 a Lisp object from it->w.
4583
52fab9c9
EZ
45842013-06-09 Eli Zaretskii <eliz@gnu.org>
4585
4586 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4587 get-char-property the window that is being rendered, instead of
4588 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4589 (compute_display_string_pos): When W is NULL, use the current
4590 buffer as the object to pass to get-char-property.
4591 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4592 pointer member of the bidi iterator, since no window is pertinent
4593 to this function.
52fab9c9 4594
5bf97bfc
EZ
45952013-06-08 Eli Zaretskii <eliz@gnu.org>
4596
4597 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4598 being displayed, and pass it to compute_display_string_pos.
4599 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4600 (bidi_paragraph_init): All callers changed.
4601
4602 * xdisp.c (init_from_display_pos, init_iterator)
4603 (handle_single_display_spec, next_overlay_string)
4604 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4605 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4606 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4607 (compute_display_string_pos): Accept additional argument, the
4608 window being displayed, and pass it to Fget_char_property.
4609 (Bug#14575)
4610
4611 * dispextern.h (struct bidi_it): New member w, the window being
4612 displayed.
4613 (compute_display_string_pos): Adjust prototype.
4614
5de0e011
JD
46152013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4616
e7b41c4c 4617 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4618
4619 * process.c (wait_reading_process_output): Check for NS before GLIB.
4620 GLIB may be linked in due to rsvg, but ns_select must be called.
4621
5de0e011
JD
4622 * xgselect.c (xg_select): Remove call to window_system_available
4623 and g_main_context_pending at the top, so Gdk events (i.e. file
4624 notify) are processed when Emacs is started with -nw.
4625
a822acff
EZ
46262013-06-07 Eli Zaretskii <eliz@gnu.org>
4627
4628 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4629 (ctagsfiles3): New variable, includes only *.m files.
4630 (TAGS): Use an explicit language name in the regular expressions,
4631 to avoid transformation of '/SOMETHING' by MSYS to
4632 'c:\MSYS\SOMETHING'.
4633
6c0a9ed1
RC
46342013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4635
4636 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4637
9ef6111b
EZ
46382013-06-06 Eli Zaretskii <eliz@gnu.org>
4639
4640 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4641 still need to set the mouse pointer shape and activate help-echo.
4642 (Bug#14558)
4643
7d300d64
PE
46442013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4645
4646 A few porting etc. fixes for the new file monitor code.
4647 See the thread containing
4648 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4649 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4650 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4651 (dir_monitor_callback, Fgfile_rm_watch):
4652 Use assq_no_quit instead of Fassoc, for speed.
4653 (dir_monitor_callback, Fgfile_rm_watch):
4654 eassert that the monitor is a fixnum.
4655 (dir_monitor_callback): No need for CDR_SAFE.
4656 Simplify building of lisp with alternative tails.
4657 (Fgfile_add_watch, Fgfile_rm_watch):
4658 Do not assume glib functions set errno reliably on failure.
4659 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4660 and signal an error otherwise.
4661 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4662 Use Fdelq instead of Fdelete, for speed.
4663
817ebfcf
EZ
46642013-06-05 Eli Zaretskii <eliz@gnu.org>
4665
4666 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4667 don't insist on being invoked on a highlighted tool-bar button.
4668 Avoids losing tool-bar functionality when mouse-highlight is nil.
4669 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4670 Don't highlight when mouse-highlight is nil.
4671 (note_mouse_highlight): When mouse-highlight is nil, don't return
4672 right away; instead, run tool-bar and mode-line highlight
4673 subroutine, clear any existing highlight, and revert the mouse
4674 pointer to its default shape. (Bug#14558)
4675
55577e7c
SM
46762013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4677
4678 * lisp.mk (lisp): Add prog-mode.el.
4679
f019a684
PE
46802013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4681
4682 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4683 * process.c (dummy_handler): New function.
4684 (lib_child_handler): New static var.
4685 (handle_child_signal): Invoke it.
4686 (catch_child_signal): If a library has set up a signal handler,
4687 save it into lib_child_handler.
4688 (init_process_emacs): If using glib and not on Windows, tickle glib's
4689 child-handling code so that it initializes its private SIGCHLD handler.
4690 * syssignal.h (SA_SIGINFO): Default to 0.
4691 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4692 31; it should no longer be needed now.
4693
90db8702
MA
46942013-06-05 Michael Albinus <michael.albinus@gmx.de>
4695
4696 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4697
4698 * gfilenotify.c (globals_of_gfilenotify): New function.
4699 (syms_of_gfilenotify): Move global initialization there.
4700
4701 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4702
bfa3acd6
SM
47032013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4704
4705 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4706 * keyboard.c (menu_bar_items, tool_bar_items):
4707 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4708 not override local keymaps any more.
4709
ba59bd80
EZ
47102013-06-04 Eli Zaretskii <eliz@gnu.org>
4711
4712 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4713
7f203aa1
EZ
47142013-06-03 Eli Zaretskii <eliz@gnu.org>
4715
9337e206
EZ
4716 * w32console.c (initialize_w32_display): Return the dimensions of
4717 the console window via 2 additional arguments, not via the current
4718 frame. This avoids crashes due to overrunning the bounds of
4719 frame's decode_mode_spec_buffer, which is not resized following
4720 the change of the frame dimensions from the initial 10x10.
4721
4722 * w32term.h (w32_initialize_display_info): Adjust prototype.
4723
4724 * term.c (init_tty): Take dimensions of the frame from the values
4725 returned by initialize_w32_display.
4726
7f203aa1
EZ
4727 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4728 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4729 (LIBES): Add $(GFILENOTIFY_LIBS).
4730
4731 * w32inevt.c (handle_file_notifications): Add dummy implementation
4732 for !HAVE_W32NOTIFY.
4733
4734 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4735
55a87246
JD
47362013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4737
4738 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4739
4740 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4741
4742 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4743
3d5ee10a
PE
47442013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4745
4746 Fix minor problems found by static checking.
4747 * data.c (pure_write_error):
4748 Use xsignal2, not Fsignal, as Fsignal might return.
4749 * eval.c (set_backtrace_debug_on_exit): Now static.
4750 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4751 No longer inline. EXTERN_INLINE is needed only for functions
4752 defined in .h files. Reindent function header as per GNU style.
4753 (backtrace_p, backtrace_top, backtrace_next):
4754 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4755 compiler or linker. Add extern decls to pacify gcc -Wall.
4756 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4757 Now static.
4758 * frame.c (free_monitors): Define only on platforms that need it.
4759 * nsterm.m (ns_term_init):
4760 * process.c (catch_child_signal):
4761 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4762 defined on all porting targets these days.
4763 * process.c, process.h (catch_child_signal):
4764 Make it extern only if NS_IMPL_GNUSTEP is defined.
4765
e2d8a6f0
EZ
47662013-06-03 Eli Zaretskii <eliz@gnu.org>
4767
4768 * w32.c (gettimeofday): Make the signature identical to prototype
4769 in nt/inc/sys/time.h.
4770
a8a7c5f6
SM
47712013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4772
4773 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4774 .gdbinit.
4775
4776 * keyboard.c (safe_run_hooks_error): Improve error message.
4777
4778 * data.c (pure_write_error): Add `object' argument.
4779 * puresize.h (CHECK_IMPURE): Use it.
4780
c9628c79
MA
47812013-06-03 Michael Albinus <michael.albinus@gmx.de>
4782
4783 * Makefile.in (NOTIFY_OBJ): New variable.
4784 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4785
4786 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4787 Call syms_of_gfilenotify.
4788
4789 * gfilenotify.c: New file.
4790
4791 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4792 and Qfile_w32notify.
4793 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4794 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4795
4796 * lisp.h: Declare syms_of_gfilenotify.
4797
4798 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4799
2f592f95
SM
48002013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4801
4802 Merge the specpdl and backtrace stacks. Make the structure of the
4803 specpdl entries more obvious via a tagged union of structs.
4804 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4805 (enum specbind_tag): New enum.
4806 (struct specbinding): Make it a tagged union of structs.
4807 Add a case for backtrace records.
4808 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4809 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4810 (backtrace_debug_on_exit): New accessors.
4811 (struct backtrace): Remove.
4812 (struct catchtag): Remove backlist field.
4813 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4814 Move to eval.c.
4815 (Flocal_variable_p): Speed up the common case where the binding is
4816 already loaded.
4817 * eval.c (backtrace_list): Remove.
4818 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4819 (set_backtrace_args, set_backtrace_nargs)
4820 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4821 (backtrace_next): New functions.
4822 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4823 (unwind_to_catch, internal_lisp_condition_case)
4824 (internal_condition_case, internal_condition_case_1)
4825 (internal_condition_case_2, internal_condition_case_n): Don't bother
4826 with backtrace_list any more.
4827 (Fsignal): Adjust to new backtrace format.
4828 (grow_specpdl): Move up.
4829 (record_in_backtrace): New function.
4830 (eval_sub, Ffuncall): Use it.
4831 (apply_lambda): Adjust to new backtrace format.
4832 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4833 data.c.
4834 (specbind): Adjust to new specpdl format. Simplify.
4835 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4836 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4837 backtrace format.
4838 (mark_backtrace): Remove.
4839 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4840 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4841 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4842 Use mark_specpdl.
4843 * profiler.c (record_backtrace): Use get_backtrace.
4844 (handle_profiler_signal): Use backtrace_top_function.
4845 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4846 accessor functions.
4847
c0342369
JD
48482013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4849
4850 * process.h (catch_child_signal): Declare.
4851
4852 * process.c (catch_child_signal): New function.
4853 (init_process_emacs): Call it.
4854
4855 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4856 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4857 NS_IMPL_COCOA.
4858 (x_set_cursor_type): Remove declaration.
4859 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4860 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4861 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4862 (ns_get_color): Use F suffix on float.
4863 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4864 (ns_get_rgb_color): Remove.
4865 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4866 (note_mouse_movement): x and y are CGFloat.
4867 (ns_draw_fringe_bitmap): Remove unused rowY.
4868 Change #if to COCOA && >= 10_6.
4869 (ns_draw_window_cursor): Remove unused overspill.
4870 (ns_draw_underwave): width and x are EamcsCGFloat.
4871 (ns_draw_box): thickness is CGFloat.
4872 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4873 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4874 if not in main thread.
4875 (ns_get_pending_menu_title, ns_check_menu_open)
4876 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4877 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4878 (sendFromMainThread:): New method.
4879 (changeFont:): size is CGFloat.
4880 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4881 Disable warning about permanent text.
4882 (characterIndexForPoint:): Adjust return type depending on GNUStep
4883 version.
4884 (mouseDown:): delta is CGFloat.
4885 (updateFrameSize): Remove unised variable f.
4886 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4887 Cast float to EmacsCGFloat.
4888 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4889 also to -1 when restoring.
4890 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4891 inside NS_IMPL_COCOA.
4892 (toggleFullScreen:): Put call to toggleFullScreen inside
4893 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4894 (setPosition:portion:whole:): por is CGFloat.
4895 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4896 (mouseDown:): Use CGFloat.
4897 (mouseDragged:): Remove unised variable edge.
4898 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4899
4900 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4901 of CGFloat differs.
4902 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4903 when NS_IMPL_GNUSTEP.
4904 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4905 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4906 (EmacsToolbar): Add clearAll. Add tag argument to
4907 addDisplayItemWithImage.
4908 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4909
4910 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4911
4912 * nsmenu.m (ns_update_menubar): Make static.
4913 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4914 (fillWithWidgetValue:): Add cast to SEL for setAction.
4915 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4916 (update_frame_tool_bar): Update code for GNUStep.
4917 (clearAll): New method.
4918 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4919 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4920 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4921 call to insertItemWithItemIdentifier.
4922 (validateVisibleItems): Fix indentation.
4923 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4924 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4925 UtilityWindow to aStyle, remove call to setStyleMask.
4926
4927 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4928
4929 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4930 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4931 Use F suffix on floats.
4932 (ns_char_width): Returns CGFloat.
4933 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4934 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4935 DPSxshow.
4936 (ns_glyph_metrics): CGFloat instead of float.
4937
a0eb10b3
JB
4938 * nsfns.m (x_set_foreground_color, x_set_background_color):
4939 Use EmacsCGFloat.
4940 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4941 remove unused variables.
4942 (Fns_read_file_name): Keep track if panel is for save.
4943 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4944 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4945 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4946 Just return the input if GNUStep.
c0342369
JD
4947 (x_screen_planes): Remove.
4948 (Fxw_color_values): Use EmacsCGFloat
4949 (Fns_display_monitor_attributes_list): Only get screen number for
4950 Cocoa.
ef099a94 4951 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4952 EmacsSavePanel.
4953 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4954 ns_directory_from_panel.
4955
da9aff11
PE
49562013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 * process.c (handle_child_signal): Also use WCONTINUED.
4959 This is so that list-processes doesn't mistakenly list the process
4960 as stopped, when the process has actually been continued and is
4961 now running.
4962
0e64479a
PE
49632013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4964
fc186a96
PE
4965 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4966 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4967 not already configured.
4968
0e64479a
PE
4969 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4970
38b787fa
EZ
49712013-05-29 Eli Zaretskii <eliz@gnu.org>
4972
4973 * Makefile.in (mostlyclean): Remove *.res files.
4974
22513e52
SM
49752013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4976
4977 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4978 a buffer (bug#8447).
4979
6ef3db10
EZ
49802013-05-27 Eli Zaretskii <eliz@gnu.org>
4981
4982 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4983 display vector, and we backtrack, handle the case that the
4984 previous character position is also displayed from a display
4985 vector or covered by a display string or image. (Bug#14476)
4986
6799bb26
JD
49872013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4988
4989 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4990 (struct MonitorInfo, free_monitors): Remove.
4991 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4992 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4993 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4994 Qframes, Qsource.
4995
4996 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4997 (struct MonitorInfo, free_monitors): Remove.
4998 (ns_screen_name): Make static.
4999 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
5000 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
5001 Qframes, Qsource.
5002
5003 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5004 (struct MonitorInfo): New struct.
5005 (free_monitors, make_monitor_attribute_list): Declare.
5006
22513e52
SM
5007 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
5008 New Lisp_Object:s.
6799bb26
JD
5009 (free_monitors, make_monitor_attribute_list): New functions.
5010 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
5011 Qsource.
5012
38cd43eb
XF
50132013-05-25 Xue Fuqiao <xfq.free@gmail.com>
5014
5015 * callproc.c (call_process): Refine the doc string. (Bug#14045)
5016
2af0948d
SM
50172013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
5018
a7eb9b0f
SM
5019 * keyboard.c: Apply keyboard decoding only to events that come directly
5020 from the tty, not from unread-command-events (bug#14368).
5021 (read_event_from_main_queue): New function, extracted from read_char).
5022 (read_decoded_char): Remove.
5023 (read_decoded_event_from_main_queue): New function to replace it.
5024 (read_char): Use it.
5025 (read_key_sequence): Use read_char rather than read_decoded_char.
5026
2af0948d
SM
5027 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
5028
1413e9a5
BR
50292013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
5030
5031 * casetab.c (init_casetab_once): Fix last change (bug#14424).
5032
e6d2f155
KH
50332013-05-22 Kenichi Handa <handa@gnu.org>
5034
5035 The following changes are to fix the setting of
5036 buffer-file-coding-system on, for instance, C-x RET c unix RET
5037 _FILE_OF_DOS_EOL_TYPE_ RET.
5038
5039 * coding.h (struct coding_system): New member detected_utf8_chars.
5040
5041 * coding.c (detect_coding_utf_8): Count characters and check EOL
5042 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
5043 BOM is there.
5044 (setup_coding_system): Do not initialize coding->head_ascii.
5045 (check_ascii): Do not set coding->eol_seen but update it. Do not
5046 call adjust_coding_eol_type here.
1413e9a5
BR
5047 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
5048 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
5049 of the found coding-system.
5050 (decode_coding_gap): Cancel previous change. Utilize the
5051 character numbers counted by detect_coding_utf_8. Fix detection
5052 of BOM for utf-8.
5053
ab56a6f4 50542013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
5055
5056 * search.c (looking_at_1): Only set last_thing_searched if the match
5057 changed the match-data (bug#14281).
5058
ecc3c6ed
DA
50592013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
5060
5061 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 5062 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
5063 (move_it_vertically_backward): Likewise.
5064
5ba8bf35
YM
50652013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5066
5067 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 5068 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
5069 (Fx_display_mm_width, Fx_display_mm_height):
5070 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 5071
91e8418b 5072 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 5073 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
5074 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
5075 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
5076 (Fx_display_backing_store, Fx_display_visual_class)
5077 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
5078 (Fx_display_grayscale_p, Fx_display_pixel_width)
5079 (Fx_display_pixel_height, Fx_display_planes)
5080 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
5081 (Fx_display_screens): Don't confuse X11 screens with NS screens.
5082 (Fx_display_mm_width, Fx_display_mm_height)
5083 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
5084 height for all physical monitors as in X11.
5085
fc30d803
SM
5086 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
5087 Return pixel width or height for all physical monitors as in X11.
91e8418b 5088
31ff141c
PE
50892013-05-18 Paul Eggert <eggert@cs.ucla.edu>
5090
5091 Port --enable-gcc-warnings to clang.
5092 * bytecode.c (exec_byte_code):
5093 * regex.c:
5094 Redo diagnostic pragmas to pacify clang, too.
5095 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
5096 * editfns.c (Fencode_time):
5097 * fileio.c (file_accessible_directory_p):
5098 * font.c (font_unparse_xlfd):
5099 Use '&"string"[index]' instead of '"string" + (index)'.
5100 * undo.c (user_error): Remove; unused.
5101
df065a0b
EZ
51022013-05-16 Eli Zaretskii <eliz@gnu.org>
5103
04d360e7
EZ
5104 * insdel.c (insert_1_both): Document the arguments, instead of
5105 referring to insert_1, which no longer exists.
5106
5bb98290
EZ
5107 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
5108 some window, increment windows_or_buffers_changed, so that
5109 *Messages* display in that window is updated. (Bug#14408)
5110
df065a0b
EZ
5111 * w32.c: Include epaths.h.
5112 (init_environment): Use cmdproxy.exe without leading directories.
5113 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
5114 case.
5115 (gettimeofday): Adjust signature and return value to Posix
5116 expectations.
5117
5118 * unexw32.c (open_output_file): Delete the existing emacs.exe
5119 before creating it, to break the hard link to the versioned
5120 executable.
5121
5122 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
5123 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
5124 (FIRSTFILE_OBJ): New variables.
5125 (W32_RES): Rename to EMACSRES. All users changed.
5126 (base_obj): Use $(CM_OBJ).
5127 (ALLOBJS): Use $(FIRSTFILE_OBJ).
5128 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
5129 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
5130 $(W32_RES_LINK) before $(LIBES).
5131 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
5132
1aa8d505
SM
51332013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5134
6e911150
SM
5135 * makefile.w32-in (DOC): Use just "DOC".
5136
5137 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
5138
1aa8d505
SM
5139 * process.c: Export default filters and sentinels to Elisp.
5140 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
5141 New constants.
5142 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
5143 (Fset_process_sentinel, Fformat_network_address):
5144 Default to them instead of nil.
5145 (server_accept_connection): Sentinels can't be nil any more.
5146 (read_and_dispose_of_process_output): New function, extracted from
5147 read_process_output.
5148 (read_process_output): Use it; filters can't be nil.
5149 (Finternal_default_process_filter): New function, extracted from
5150 read_process_output.
5151 (exec_sentinel_unwind): Remove function.
5152 (exec_sentinel): Don't zilch sentinel while running.
5153 (status_notify): Sentinels can't be nil.
5154 (Finternal_default_process_sentinel): New function extracted from
5155 status_notify.
5156 (setup_process_coding_systems): Default filter is not nil any more.
5157 (syms_of_process): Export new Elisp functions and initialize
5158 new constants.
5159 * lisp.h (make_lisp_proc): New function.
5160
5ac2eb34
SM
51612013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5162
5163 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
5164
eda9c7d7
EZ
51652013-05-14 Eli Zaretskii <eliz@gnu.org>
5166
5167 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
5168 unless we know that the window w is a leaf window.
5169 Another attempt at solving bug#14062.
eda9c7d7 5170
8fdeaad5
JD
51712013-05-14 Jan Djärv <jan.h.d@swipnet.se>
5172
5173 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
5174 fdesc (Bug#14375).
5175
44aa9ee6
PE
51762013-05-12 Paul Eggert <eggert@cs.ucla.edu>
5177
5178 * image.c (gif_load): Check that subimages fit (Bug#14345).
5179
759fd763
SM
51802013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
5181
5182 * lread.c (skip_dyn_eof): New function.
5183 (read1): Use it to skip the end of a file in response to #@00.
5184
5185 * doc.c (get_doc_string): Slightly relax the sanity checking.
5186
4465bfb4
JD
51872013-05-09 Jan Djärv <jan.h.d@swipnet.se>
5188
5189 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
5190 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
5191 (MonitorInfo): New struct.
5192 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
5193 (Fns_display_monitor_attributes_list): New functions.
5194 (display-usable-bounds): Remove.
5195 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
5196 Qsource.
5197
7583e2a0
PE
51982013-05-09 Paul Eggert <eggert@cs.ucla.edu>
5199
5200 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
5201 (GTK_CHECK_VERSION): New macro, if not already defined.
5202 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
5203 replaced by GTK_CHECK_VERSION.
5204
ad75d77e
PE
52052013-05-08 Paul Eggert <eggert@cs.ucla.edu>
5206
5207 * xterm.h (GTK_PREREQ): New macro.
5208 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
5209 to use this macro instead, for consistency and clarity.
5210
07525f77
EZ
52112013-05-08 Eli Zaretskii <eliz@gnu.org>
5212
5213 * xdisp.c (row_for_charpos_p): New function, with code of
5214 cursor_row_p, but accepts an additional argument CHARPOS instead
5215 of using a hardcoded PT.
5216 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
5217 (row_containing_pos): Call row_for_charpos_p instead of partially
5218 doing the same. Fixes cursor positioning under longlines-mode
5219 when longlines-show-effect includes more than one newline, when
5220 moving the cursor vertically up.
5221
d901fc8d
JB
52222013-05-08 Juanma Barranquero <lekktu@gmail.com>
5223
5224 * makefile.w32-in (ACL_H): New macro.
5225 ($(BLD)/fileio.$(O)): Update dependencies.
5226
f269bc61
PE
52272013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5228
e7b41c4c 5229 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
5230 * Makefile.in (LIB_ACL): New macro.
5231 (LIBACL_LIBS): Remove.
5232 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
5233 * fileio.c: Include <acl.h>.
5234 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
5235 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
5236 !acl_errno_valid.
5237 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
5238 it ourselves.
5239
f269bc61
PE
5240 * unexelf.c: Don't assume ElfW (Half) fits in int.
5241 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
5242 when dealing with ElfW (Half) values, since they can exceed 2**31
5243 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
5244 (entry_address): Omit unused NUM arg. All uses changed.
5245
a261c53e
JL
52462013-05-07 Juri Linkov <juri@jurta.org>
5247
5248 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
5249 to the string converted from number with `Fnumber_to_string'.
5250 (Bug#14254)
5251
2b66427d
PE
52522013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
5255 This fixes a problem introduced by my previous change.
5256
15acfe41
GM
52572013-05-07 Glenn Morris <rgm@gnu.org>
5258
5259 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
5260
5ea03bf5
JD
52612013-05-07 Jan Djärv <jan.h.d@swipnet.se>
5262
5263 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
5264
e0c9d565
PE
52652013-05-07 Paul Eggert <eggert@cs.ucla.edu>
5266
5267 Static checking by GCC 4.8.0.
5268 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
5269 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
5270 (x_get_monitor_attributes_fallback)
5271 (x_get_monitor_attributes_xinerama)
5272 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
5273 Define only if USE_GTK.
5274 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
5275 (x_get_monitor_attributes_fallback): Omit unused locals.
5276 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
5277 Use double, not float, to avoid mixed-mode floating point arithmetic.
5278
4e3f9230
YM
52792013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5280 Jan Djärv <jan.h.d@swipnet.se>
5281
5282 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
5283 (XINERAMA_CFLAGS): New macros.
5284 (ALL_CFLAGS, LIBES): Use them.
5285
5286 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
5287 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
5288 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
5289 (syms_of_xfns): DEFSYM them.
5290 (struct MonitorInfo): New struct.
5291 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
5292 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
5293 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
5294 (x_get_monitor_attributes_xinerama): New functions.
5295 (Fx_display_monitor_attributes_list): New primitive.
5296 (syms_of_xfns): Defsubr it.
5297
5298 * xterm.h (x_display_info): Add Xatom_net_workarea and
5299 Xatom_net_current_desktop.
5300
5301 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5302 and dpyinfo->Xatom_net_current_desktop.
5303
05839b6a
EZ
53042013-05-06 Eli Zaretskii <eliz@gnu.org>
5305
5306 * xdisp.c (pos_visible_p): Use the special code for finding the
5307 beginning of a display property or overlay for any "replacing"
5308 display property, not just for display strings. This solves
5309 incorrect reporting of position by posn-at-point. (Bug#14241)
5310
dc4a2ee0
PE
53112013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5312
5ee94506
PE
5313 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5314 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5315 Verify that ElfW (Half) fits in int.
5316 (fatal): Use same signature as lisp.h.
5317 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5318 configure and build with -DUNEXELF_DEBUG without worrying about
5319 other modules that use DEBUG.
5320 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5321 possibly-wide integers now uses it instead of plain fprintf.
5322 (entry_address): New function, which avoids problems with 32-bit
5323 overflow on 64-bit hosts.
5324 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5325 (round_up): Don't assume the remainder fits in int.
5326 (find_section): Use bool for boolean. Simplify debug code.
5327 (unexec): Don't assume file sizes fit in int or size_t.
5328 Omit unnecessary trailing newline in 'fatal' format.
5329 Use strerror rather than outputting decimal error number.
5330 Remove unused code when emacs is not defined;
5331 this file relies on Emacs now.
5332 Don't assume e_phnum and e_shnum are positive.
5333
dc4a2ee0
PE
5334 * regex.c: Fix problems when DEBUG is defined.
5335 (extract_number, extract_number_and_incr): Define regardless of
5336 whether DEBUG is defined; that's simpler and makes the code less
5337 likely to go stale in the normal case when DEBUG is not defined.
5338 Return int rather than taking an int * arg. All callers changed.
5339 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5340 Remove, replacing with ...
5341 (DEBUG_PRINT): New macro. All callers changed.
5342 (DEBUG_COMPILES_ARGUMENTS): New macro.
5343 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5344 (print_compiled_pattern, print_double_string) [DEBUG]:
5345 Use prototype rather than old-style definition.
5346 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5347 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5348 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5349 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5350 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5351 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5352 This matters only when DEBUG is defined.
5353
14c7ed05
EZ
53542013-05-05 Eli Zaretskii <eliz@gnu.org>
5355
5356 * xdisp.c (set_iterator_to_next): Set the
5357 ignore_overlay_strings_at_pos_p flag only if we are _really_
5358 iterating over an overlay string, as indicated by the
5359 current.overlay_string_index member. (Bug#14306)
5360
e6076b1b
JD
53612013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5362
5363 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5364 to where it is used, to avoid autorelease issues (Bug#14050).
5365
cbee2131
PE
53662013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5367
5368 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5369 * fileio.c (syms_of_fileio): Implement this.
5370 * filelock.c (create_lock_file): If symbolic links don't work, so
5371 we use a regular file as a lock file, do not fsync the lock file;
5372 it's not needed.
5373
30c7e542
SM
53742013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5375
5376 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5377 (syms_of_minibuf): Adjust accodingly.
5378 * lread.c (Fread):
5379 * callint.c (Fcall_interactively): Adjust calls accordingly.
5380
5bebd186
EZ
53812013-05-04 Eli Zaretskii <eliz@gnu.org>
5382
5383 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5384 w->contents is a buffer before computing everything else.
5385 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5386
5387 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5388 assertion violations. (Bug#14062)
5389
0fb0a4f3
DR
53902013-05-01 David Reitter <david.reitter@gmail.com>
5391
5392 * nsfns.m (ns_tooltip): Initialize.
5393
9e63b4a5
EZ
53942013-04-28 Eli Zaretskii <eliz@gnu.org>
5395
5396 * coding.c (decode_coding_gap): Don't remove the character before
5397 a newline unless it's a CR character. (Bug#14287)
5398
ad60824e
DN
53992013-04-28 Dan Nicolaescu <dann@gnu.org>
5400
5401 * dispextern.h (struct face): Move enum face_underline_type
5402 earlier so that bitfields can be in the same word.
5403
edbdcec0
JD
54042013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5405
5406 * nsfns.m (handlePanelKeys): New function.
5407 (EmacsOpenPanel:performKeyEquivalent:)
5408 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5409 arrows/function/control and copy/paste keys (Bug#14296).
5410
0208ede7
JL
54112013-04-27 Juri Linkov <juri@jurta.org>
5412
5413 * callint.c (Fcall_interactively): Call `Qread_number' for
5414 interactive code letter `n' instead of using duplicate code.
5415 (Bug#14254)
5416
b8dd59f7
PE
54172013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5418
5419 * systime.h (make_timeval): Declare as 'const'.
5420
8bd722db
KH
54212013-04-27 Kenichi Handa <handa@gnu.org>
5422
5423 * font.c (font_open_entity): Always open a font of manageable
5424 size.
5425
13d0e56f 54262013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5427
f780d632
PE
5428 Port better to AIX (Bug#14258).
5429 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5430 to pacify AIX xlc.
5431
ec509856
KH
54322013-04-24 Kenichi Handa <handa@gnu.org>
5433
5434 * coding.c (decode_coding_iso_2022): When an invalid escape
5435 sequence is encountered, reset the invocation and designation
5436 status to the safest one.
5437
84fc48e5
PE
54382013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5439
5440 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5441 Without this fix, "make distclean" leaves stamp-h1 behind.
5442
806bda47
EC
54432013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5444
5445 * w32fns.c (w32_fullscreen_rect): New function to compute the
5446 window rectangle for the given fullscreen mode.
5447 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5448 longer tunes the window size. This keeps the window's edges flush
5449 with the screen and allows the taskbar to hide itself in fullboth.
5450
5451 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5452 window decorations and uses the entire screen.
5453
5454 * w32term.h (w32_fullscreen_rect) Add prototype.
5455 (struct w32_output): Replace normal_width, normal_height,
5456 normal_top, and normal_left members with a single normal_placement
5457 struct.
5458 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5459 Remove macros.
5460 (FRAME_NORMAL_PLACEMENT): New macro.
5461
9cc2810b
JB
54622013-04-16 Juanma Barranquero <lekktu@gmail.com>
5463
5464 * minibuf.c (Ftest_completion): Silence compiler warning.
5465
fd16b54c
EZ
54662013-04-15 Eli Zaretskii <eliz@gnu.org>
5467
5468 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5469 bug#14062.
fd16b54c
EZ
5470
5471 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5472 parentheses.
5473
5474 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5475 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5476 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5477 parentheses where appropriate.
5478
9e3379a0
PE
54792013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5480
5481 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5482
ddd6b685
EZ
54832013-04-14 Eli Zaretskii <eliz@gnu.org>
5484
5485 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5486 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5487 Mention in the doc string that setting these variables takes
5488 effect only after a call to set-window-buffer. (Bug#14200)
5489
29b79ba1
EZ
54902013-04-13 Eli Zaretskii <eliz@gnu.org>
5491
5492 * indent.c (Fvertical_motion): Don't consider display strings on
5493 overlay strings as display strings on the buffer position we
5494 started from. This prevents vertical cursor motion from jumping
5495 more than one line when there's an overlay string with a display
5496 property at end of line.
5497 Reported by Karl Chen <Karl.Chen@quarl.org> in
5498 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5499
562c6ee9
SM
55002013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5501
5502 * window.c (select_window): `record_buffer' even if window is
5503 already selected (bug#14191).
5504
fcc1fe85
EZ
55052013-04-11 Eli Zaretskii <eliz@gnu.org>
5506
5507 * window.c (Fwindow_end): Test more flags, including the buffer's
5508 last_overlay_modified flag, to determine whether the window's
5509 display is really up-to-date. Prevents the function from
5510 returning a stale value. (Bug#14170)
5511 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5512 current matrix.
5513
f009190a
EZ
55142013-04-10 Eli Zaretskii <eliz@gnu.org>
5515
5516 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5517 garbaged only if it is not already the top frame on its TTY.
5518 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5519 there are GUI frames open in the same session. (Bug#13864)
5520
78ce603d
SM
55212013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5522
5523 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5524 of marking the idle timers directly.
5525
a8036e40
SM
55262013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5527
5528 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5529 tables (bug#14054).
5530
7ffe7ef6
SM
55312013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5532
5533 * window.c (select_window): Don't record_buffer while the invariant is
5534 temporarily broken (bug#14161).
5535
5536 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5537
7d9f6883
EZ
55382013-04-07 Eli Zaretskii <eliz@gnu.org>
5539
5540 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5541
5406cfd9
RF
55422013-04-07 Romain Francoise <romain@orebokech.com>
5543
5544 Ignore additional platform-specific ACL errors (Bug#13702).
5545 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5546 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5547
95c0e83b
JD
55482013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5549
5550 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5551 f->output_data.ns.
5552
876da980
PE
55532013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5554
5555 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5556 This bug was introduced by my 2013-02-25 change that simplified
5557 data_start configuration. Without this change, on GNU/Linux
5558 an Emacs configured with --enable-profiling fails immediately
5559 due to a profiler signal.
5560 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5561 with these flags. On platforms where special flags are needed
5562 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5563 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5564 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5565
7452b7bd
DA
55662013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5567
5568 Get rid of some platform-specific functions examining window
5569 system and its capabilities. This is a partial rework of the
5570 2013-04-05 change.
5571 * lisp.h (have_menus_p): Remove prototype. This function is
5572 replaced with platform-independent window_system_available.
5573 (check_window_system): Move to...
5574 * frame.h (decode_window_system_frame, window_system_available):
5575 ...here, add new prototypes.
5576 * frame.c (window_system_available, decode_window_system_frame):
5577 New functions.
5578 (check_window_system): Platform-independent now.
5579 * xterm.h (x_in_use): Remove declaration.
5580 (check_x_frame):
5581 * w32term.h (check_x_frame):
5582 * nsterm.h (check_x_frame): Remove prototypes. This function
5583 is replaced with platform-independent decode_window_system_frame.
5584 * msdos.c (have_menus_p): Remove.
5585 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5586 Remove platform-specific functions. Use check_window_system,
5587 decode_window_system_frame and check_ns_display_info where
5588 appropriate. Minor style and comment tweaks.
5589 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5590 (check_x_frame): Likewise.
5591 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5592 Likewise.
5593 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5594 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5595 * xmenu.c, xselect.c: All related users changed.
5596
251e9147
KH
55972013-04-03 Kenichi Handa <handa@gnu.org>
5598
5599 The following changes is to optimize the code for reading UTF-8
5600 files.
5601
562c6ee9 5602 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5603 changed. Check EOL format. Do not call adjust_coding_eol_type
5604 here.
5605 (check_utf_8): New function.
5606 (adjust_coding_eol_type): Do nothing if already adjusted.
5607 (detect_coding): Compare the return value of check_ascii with
5608 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5609 (decode_coding_gap): Optimize for valid UTF-8.
5610
8bc369d4
KH
56112013-03-21 Kenichi Handa <handa@gnu.org>
5612
5613 * coding.c (syms_of_coding): Cancel previous change.
5614
5615 * insdel.c (insert_from_gap): Fix previous change.
5616
73931ad1
DA
56172013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5618
5619 Consistently use platform-specific function to detect window system.
5620 * lisp.h (check_window_system): New prototype. This function is
5621 going to replace check_x, check_w32 and check_ns.
5622 (have_menus_p): Mention msdos.c in comment.
5623 * fontset.c (check_window_system_func): Remove. Adjust all users.
5624 * fontset.h (check_window_system_func): Remove prototype.
5625 * nsterm.h (check_ns):
5626 * xterm.h (check_x):
5627 * w32term.h (check_w32): Likewise.
5628 * menu.c (Fx_popup_menu): Use check_window_system.
5629 * msdos.c (check_window_system): Define for MS-DOS.
5630 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5631 * w32fns.c (check_window_system): Likewise for MS-Windows.
5632 * xfns.c (check_window_system): Likewise for X.
5633 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5634 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5635
7216e43b
PE
56362013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5637
5638 Prefer < to > in range checks such as 0 <= i && i < N.
5639 This makes it easier to visualize quantities on a number line.
5640 This patch doesn't apply to all such range checks,
5641 only to the range checks affected by the 2013-03-24 change.
5642 This patch reverts most of the 2013-03-24 change.
5643 * alloc.c (xpalloc, Fgarbage_collect):
5644 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5645 * character.c (string_escape_byte8):
5646 * charset.c (read_hex):
5647 * data.c (cons_to_unsigned):
5648 * dispnew.c (update_frame_1):
5649 * doc.c (Fsubstitute_command_keys):
5650 * doprnt.c (doprnt):
5651 * editfns.c (hi_time, decode_time_components):
5652 * fileio.c (file_offset):
5653 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5654 * font.c (font_intern_prop):
5655 * frame.c (x_set_alpha):
5656 * gtkutil.c (get_utf8_string):
5657 * indent.c (check_display_width):
5658 * keymap.c (Fkey_description):
5659 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5660 * lread.c (read1):
5661 * minibuf.c (read_minibuf_noninteractive):
5662 * process.c (wait_reading_process_output):
5663 * search.c (Freplace_match):
5664 * window.c (get_phys_cursor_glyph):
5665 * xdisp.c (redisplay_internal):
5666 * xsmfns.c (smc_save_yourself_CB):
5667 Prefer < to > for range checks.
5668 * dispnew.c (sit_for): Don't mishandle NaNs.
5669 This fixes a bug introduced in the 2013-03-24 change.
5670 * editfns.c (decode_time_components): Don't hoist comparison.
5671 This fixes another bug introduced in the 2013-03-24 change.
5672
92759988
DA
56732013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5674
5675 * frame.h (struct frame): Drop scroll_bottom_vpos
5676 member becaue all real users are dead long ago.
5677 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5678 * xdisp.c (redisplay_internal): Adjust user.
5679
9a1971bb
GM
56802013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5681
f38ab167
JD
5682 * nsmenu.m (showAtX:Y:for:): setLevel to
5683 NSPopUpMenuWindowLevel (Bug#13998).
5684
6d01f1fe
JD
56852013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5686
5687 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5688 (ns_check_pending_open_menu): Declare.
5689
5690 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5691 (x_activate_menubar): Update the menu with title that matches
5692 ns_get_pending_menu_title, and call
5693 ns_check_pending_openmenu (Bug#12698).
5694 (menuWillOpen:): New method.
5695 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5696
5697 * nsterm.m (menu_will_open_state, menu_mouse_point)
5698 (menu_pending_title): New varaibles.
5699 (ns_get_pending_menu_title, ns_check_menu_open)
5700 (ns_check_pending_open_menu): New functions.
5701
781f4782
DA
57022013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5703
5704 * indent.c (current_column_bol_cache): Remove leftover which is not
5705 used in Fmove_to_column any more.
5706 (current_column, scan_for_column): Adjust users.
5707 * keyboard.c (last_point_position_buffer, last_point_position_window):
5708 Remove leftovers which are not used for recording undo any more.
5709 (command_loop_1, syms_of_keyboard): Adjust users.
5710 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5711 redisplay_window any more.
5712 (move_it_to): Adjust user.
5713
1921c31b
JB
57142013-03-29 Juanma Barranquero <lekktu@gmail.com>
5715
5716 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5717 Update dependencies.
5718
717b8bcd
SM
57192013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5720
5721 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5722 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5723 forward references.
5724
e74aeda8
DA
57252013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5726
5727 * window.h (struct window): Replace hchild, vchild and buffer slots
5728 with the only contents slot. This is possible because each valid
5729 window may have either the child window (in vertical or horizontal
5730 combination) or buffer to display (for the leaf window). Using that,
5731 a lof of operations to traverse and/or change window hierarchies may
5732 be simplified. New member horizontal is used to distinguish between
5733 horizontal and vertical combinations of internal windows.
5734 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5735 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5736 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5737 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5738 Use contents slot, not buffer, where appropriate.
5739 (wset_combination): New function.
5740 (wset_buffer): Add eassert.
5741 (Fframe_first_window): Simplify the loop reaching first window.
5742 (Fwindow_buffer): Use WINDOW_LEAF_P.
5743 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5744 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5745 (unshow_buffer): Convert initial debugging check to eassert.
5746 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5747 (make_parent_window, window_resize_check, window_resize_apply)
5748 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5749 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5750 Adjust to match struct window changes.
5751 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5752 (mark_window_cursors_off, count_windows, get_leaf_windows)
5753 (foreach_window_1): Simplify the loop.
5754 * alloc.c (mark_object): Do not check for the leaf window because
5755 internal windows has no glyph matrices anyway.
5756 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5757 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5758 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5759 (build_frame_matrix_from_window_tree, mirror_make_current)
5760 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5761 (update_window_tree, set_window_update_flags): Simplify the loop.
5762 (sync_window_with_frame_matrix_rows): Enforce live window.
5763 Use contents slot, not buffer, where appropriate.
5764 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5765 and WINDOW_HORIZONTAL_COMBINATION_P.
5766 (make_frame_visible_1): Simplify the loop.
5767 Use contents slot, not buffer, where appropriate.
5768 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5769 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5770 (expose_window_tree): Likewise.
5771 Use contents slot, not buffer, where appropriate.
5772 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5773 to avoid deleted windows. Use contents slot instead of buffer.
5774 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5775 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5776 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5777 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5778
121ab1cd
EZ
57792013-03-28 Eli Zaretskii <eliz@gnu.org>
5780
ef454cf7
EZ
5781 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5782 identify the reasons for assertion violations in bug#14062 and
5783 similar ones.
21e930f8
EZ
5784 (Fx_show_tip): Fix compilation error under
5785 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5786
121ab1cd
EZ
5787 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5788 Reported by <rzl24ozi@gmail.com>.
5789
5c89ca24
DA
57902013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5791
5792 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5793 start marker...
562c6ee9
SM
5794 (unwind_with_echo_area_buffer): ...to restore it here.
5795 This is needed to ensure that...
5c89ca24
DA
5796 (redisplay_window): ...both window markers are valid here,
5797 which is verified by eassert.
5798 * editfns.c (save_excursion_save): Do not assume that
5799 selected_window always displays the buffer.
c7f53895
DA
5800 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5801 Fix comment.
5c89ca24 5802
f557c1b1
SM
58032013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5804
5805 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5806 the upcase table.
5807
40693bba 58082013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5809
5810 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5811
c86f791f
EZ
58122013-03-27 Eli Zaretskii <eliz@gnu.org>
5813
5814 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5815 since MinGW's w32api headers do. This avoids compiler warnings.
5816
5817 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5818 if already defined.
5819
c6e72e17
EZ
58202013-03-26 Eli Zaretskii <eliz@gnu.org>
5821
5822 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5823
54e95010
JD
58242013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5825
5826 * gtkutil.c (style_changed_cb): Check if frame is live and an
5827 X frame (Bug#14038).
5828
b88b62de
EZ
58292013-03-26 Eli Zaretskii <eliz@gnu.org>
5830
a18d7de6
EZ
5831 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5832 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5833 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5834 MinGW64.
8f5e14c8
EZ
5835 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5836 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5837
b88b62de
EZ
5838 Fix incompatibilities between MinGW.org and MinGW64 headers.
5839 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5840
5841 * w32.c (REPARSE_DATA_BUFFER): Guard with
5842 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5843
c074e458
JD
58442013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5845
5846 * xterm.c: Include X11/XKBlib.h
5847 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5848
908589fd
AS
58492013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5850
5851 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5852 written backwards.
5853 * blockinput.h (input_blocked_p): Likewise.
5854 * bytecode.c (exec_byte_code): Likewise.
5855 * callproc.c (call_process_kill, call_process_cleanup)
5856 (Fcall_process): Likewise.
5857 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5858 (Fccl_execute_on_string): Likewise.
5859 * character.c (string_escape_byte8): Likewise.
5860 * charset.c (read_hex): Likewise.
5861 * cm.c (calccost): Likewise.
5862 * data.c (cons_to_unsigned): Likewise.
5863 * dired.c (directory_files_internal, file_name_completion):
5864 Likewise.
5865 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5866 (sit_for): Likewise.
5867 * doc.c (Fsubstitute_command_keys): Likewise.
5868 * doprnt.c (doprnt): Likewise.
5869 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5870 * emacsgtkfixed.c: Likewise.
5871 * fileio.c (file_offset, Fwrite_region): Likewise.
5872 * floatfns.c (Fexpt, fmod_float): Likewise.
5873 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5874 Likewise.
5875 * font.c (font_intern_prop): Likewise.
5876 * frame.c (x_set_alpha): Likewise.
5877 * gtkutil.c (get_utf8_string): Likewise.
5878 * indent.c (check_display_width): Likewise.
5879 * intervals.c (create_root_interval, rotate_right, rotate_left)
5880 (split_interval_right, split_interval_left)
5881 (adjust_intervals_for_insertion, delete_node)
5882 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5883 (merge_interval_right, merge_interval_left, copy_intervals)
5884 (set_intervals_multibyte_1): Likewise.
5885 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5886 * keymap.c (Fkey_description): Likewise.
5887 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5888 * lread.c (openp, read_integer, read1, string_to_number):
5889 Likewise.
5890 * menu.c (ensure_menu_items): Likewise.
5891 * minibuf.c (read_minibuf_noninteractive): Likewise.
5892 * print.c (printchar, strout): Likewise.
5893 * process.c (create_process, Faccept_process_output)
5894 (wait_reading_process_output, read_process_output, send_process)
5895 (wait_reading_process_output): Likewise.
5896 * profiler.c (make_log, handle_profiler_signal): Likewise.
5897 * regex.c (re_exec): Likewise.
5898 * regex.h: Likewise.
5899 * search.c (looking_at_1, Freplace_match): Likewise.
5900 * sysdep.c (get_child_status, procfs_ttyname)
5901 (procfs_get_total_memory): Likewise.
5902 * systime.h (EMACS_TIME_VALID_P): Likewise.
5903 * term.c (dissociate_if_controlling_tty): Likewise.
5904 * window.c (get_phys_cursor_glyph): Likewise.
5905 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5906 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5907 Likewise.
5908 * xfns.c (Fx_window_property): Likewise.
5909 * xmenu.c (set_frame_menubar): Likewise.
5910 * xselect.c (x_get_window_property, x_handle_dnd_message):
5911 Likewise.
5912 * xsmfns.c (smc_save_yourself_CB): Likewise.
5913 * xterm.c (x_scroll_bar_set_handle): Likewise.
5914
2bf7d27a
DA
59152013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5916
5917 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5918 to be optional or nil. Adjust comment and convert it to docstring.
5919 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5920 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5921
a9ebfa0b
PE
59222013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5923
5924 Static checking by GCC 4.8-20130319.
5925 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5926 * process.c (Fset_process_datagram_address)
5927 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5928 * xdisp.c (get_char_face_and_encoding):
5929 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5930 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5931 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5932
4f3576ee
KB
59332013-03-24 Ken Brown <kbrown@cornell.edu>
5934
789b5e9a
KB
5935 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5936 fix compilation on 64-bit Cygwin, where underscores are not
5937 automatically prepended.
5938
4f3576ee
KB
5939 * w32term.c (w32_initialize): Silence compiler warning.
5940
b5b7745f
EZ
59412013-03-23 Eli Zaretskii <eliz@gnu.org>
5942
cdc0d0bd
EZ
5943 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5944 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5945 variables, to save and restore frame dimensions.
5946 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5947 after returning from a 'fullscreen' configuration.
5948 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5949 to avoid races between the main thread and the input thread.
5950
5951 * w32term.h (struct w32_output): New members normal_width,
5952 normal_height, normal_top, normal_left, and prev_fsmode.
5953 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5954 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5955 members of a frame.
5956
b5b7745f
EZ
5957 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5958 'fullscreen' parameter. Always record previous width and height
5959 of the frame, except when switching out of maximized modes, so
5960 that they could be restored correctly, instead of resetting to the
5961 default frame dimensions. Send SC_RESTORE command to the frame,
5962 unless we are going to send SC_MAXIMIZE, to restore the frame
5963 resize hints in the mouse pointer shown by the window manager.
5964 (Bug#14032)
5965
5966 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5967
5968 * lisp.h (get_frame_param): Adjust conditions for prototype
5969 declaration.
5970
a3454eed
KB
59712013-03-22 Ken Brown <kbrown@cornell.edu>
5972
5973 * unexcw.c: Drop unneeded inclusion of w32common.h.
5974 (report_sheap_usage): Declare.
5975 (read_exe_header): Add magic numbers for x86_64.
5976 (fixup_executable): Fix printf format specifier for unsigned long
5977 argument.
5978
5a49b79c
DA
59792013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5980
5981 * frame.h (struct frame): Put menu_bar_window under #ifdef
5982 because this member is not needed when X toolkit is in use.
5983 (fset_menu_bar_window):
5984 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5985 (free_glyphs, update_frame):
5986 * xdisp.c (expose_frame): Likewise.
5987 (display_menu_bar): Likewise. Remove redundant eassert.
5988 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5989 toolkit is in use.
5990
d6723bf7
PE
59912013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5992
7b1123d8
PE
5993 Use functions and constants to manipulate Lisp_Save_Value objects.
5994 This replaces code that used macros and strings and token-pasting.
5995 The change makes the C source a bit easier to follow,
5996 and shrinks the Emacs executable a bit.
5997 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5998 (make_save_value): Change 1st arg from string to enum. All callers
5999 changed.
6000 (INTX): Remove.
6001 (mark_object): Use if, not #if, for GC_MARK_STACK.
6002 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
6003 (XSAVE_OBJECT): Now functions, not macros.
6004 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
6005 the constant was never used.
6006 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
6007 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
6008 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
6009 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
6010 New constants.
6011 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
6012 type3 with a single member save_type. All uses changed.
6013 (save_type, set_save_pointer, set_save_integer): New functions.
6014 * print.c (PRINTX): Remove.
6015
d6723bf7
PE
6016 * alloc.c: Remove redundant static declarations.
6017
5f24fa51
DA
60182013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6019
6020 * window.h (struct window): Convert left_col, top_line, total_lines
6021 and total_cols from Lisp_Objects to integers. Adjust comments.
6022 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
6023 Remove.
6024 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
6025 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
6026 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
6027 Adjust users where appropriate.
6028
42143acd
DA
60292013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
6030
6031 * frame.h (struct frame): Drop resx and resy because the same data is
6032 available from window system-specific output context. Adjust users.
562c6ee9
SM
6033 (default_pixels_per_inch_x, default_pixels_per_inch_y):
6034 New functions to provide defaults when no window system available.
42143acd 6035 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 6036 (NUMVAL): Move from xdisp.c.
42143acd
DA
6037 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
6038 (Ffont_face_attributes, Fopen_font):
6039 * image.c (gs_load):
6040 * w32font.c (fill_in_logfont):
6041 * xdisp.c (calc_pixel_width_or_height):
6042 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
6043 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
6044
c0a17406
KH
60452013-03-20 Kenichi Handa <handa@gnu.org>
6046
6047 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
6048 to 1 (temporary workaround until a bug related to ASCII
6049 optimization is fixed).
6050
095d384d
DA
60512013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
6052
6053 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
6054 Signal error if window is not internal. Adjust docstring.
6055 (delete_all_child_windows): Use combination_limit to save the buffer.
6056 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
6057 * print.c (syms_of_print): Initialize debugging output not here...
6058 (init_print_once): ...but in a new function here.
6059 * lisp.h (init_print_once): Add prototype.
6060 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 6061
748fa866
DA
60622013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
6063
6064 * window.c (window_resize_check, window_resize_apply)
6065 (window_from_coordinates, recombine_windows, set_window_buffer)
6066 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
6067 (Fsplit_window_internal, Fdelete_window_internal)
6068 (freeze_window_starts): Use bool for booleans.
6069 * window.h (window_frame_coordinates, resize_frame_windows)
6070 (freeze_window_starts, set_window_buffer): Adjust prototypes.
6071
81519fd2
SM
60722013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
6073
6074 * dispnew.c (bitch_at_user): Use `user-error'.
6075
6db423a9
KB
60762013-03-17 Ken Brown <kbrown@cornell.edu>
6077
6078 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
6079 as return type of image_background. (Bug#13981)
6080 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
6081
8f2906f5
JD
60822013-03-16 Jan Djärv <jan.h.d@swipnet.se>
6083
960ce480 6084 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 6085 (ns_select): Don't return with result uninitialized.
960ce480 6086
8f2906f5
JD
6087 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
6088 and getDirectory.
6089
81519fd2
SM
6090 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
6091 New functions.
8f2906f5
JD
6092 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
6093 directories. If filename is nil, get directory name (Bug#13932).
6094 Use getFilename and getDirectory.
6095 (getFilename, getDirectory): New methods for EmacsSavePanel and
6096 EmacsOpenPanel.
6097 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
6098
cded56c1
PE
60992013-03-15 Paul Eggert <eggert@cs.ucla.edu>
6100
6101 * coding.c (decode_coding_gap): Fix typo caught by static checking.
6102
251e9147 61032013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
6104
6105 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
6106 (adjust_after_replace): Make it back to static. Delete the third
6107 arg text_at_gap_tail. Cancel the code for handling it.
6108
6109 * coding.h (struct coding_system): New member eol_seen.
6110
6111 * coding.c (detect_ascii): New function.
6112 (detect_coding): Set coding->head_ascii and coding->eol_seen only
6113 when the source bytes are actually scanned. On detecting for
6114 coding_category_utf_8_auto, call detect_ascii instead of scanning
6115 source bytes directly.
6116 (produce_chars): Call insert_from_gap with the new arg 0.
6117 (encode_coding): Likewise.
6118 (decode_coding_gap): Control ASCII optimization by the variable
6119 disable_ascii_optimization instead of #ifndef .. #endif.
6120 Deccode EOL format according to coding->eol_seen.
6121 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
6122 variable.
6123
8a44e6d1
KH
6124 * lisp.h (adjust_after_replace): Cancel externing it.
6125 (insert_from_gap): Adjust prototype.
6126
5f795e34
EZ
61272013-03-15 Eli Zaretskii <eliz@gnu.org>
6128
6129 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
6130 FULLSCREEN_MAXIMIZED. (Bug#13935)
6131
f258b4be
DA
61322013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
6133
6134 * region-cache.c (find_cache_boundary, move_cache_gap)
6135 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
6136 Simplify debugging check and convert to eassert. Adjust comment.
6137 (pp_cache): Put under ENABLE_CHECKING.
6138
a5cc4dde
EZ
61392013-03-14 Eli Zaretskii <eliz@gnu.org>
6140
6141 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
6142 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
6143 and WM_ACTIVATEAPP.
6144 (w32fullscreen_hook): If the frame is visible, reset
6145 f->want_fullscreen flag after changing the frame size. If the
6146 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
6147 (Bug#13953)
6148
3fc5e44a
DC
61492013-03-13 Daniel Colascione <dancol@dancol.org>
6150
6151 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
6152 too so that these builds can use Cygwin's file conversion
6153 functions. (We've been building and linking cygw32.o all along
6154 and just not using it.)
6155
47d7532e
PE
61562013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6157
6158 File synchronization fixes (Bug#13944).
6159 * Makefile.in (LIB_FDATASYNC): New macro.
6160 (LIBES): Use it.
6161 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
6162 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
6163 Don't worry about HAVE_FSYNC, since a substitute fsync is
6164 available if the system lacks one.
6165 (Fwrite_regin): Retry fsync if interrupted.
6166
c7ffccaf
EZ
61672013-03-13 Eli Zaretskii <eliz@gnu.org>
6168
4e2df81d 6169 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
6170 activated, call w32fullscreen_hook, to make sure the new frame
6171 dimensions are in effect. (Bug#13937)
6172
8a7debc1
DA
61732013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
6174
6175 * xdisp.c (init_iterator): Simplify because both character and byte
6176 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
6177 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
6178 character and byte positions can be obtained from marker.
8a7debc1 6179
7fd8c501
PE
61802013-03-13 Paul Eggert <eggert@cs.ucla.edu>
6181
d9df6f40
PE
6182 Static checking by Sun C 5.12.
6183 * alloc.c (buffer_memory_full) [REL_ALLOC]:
6184 * bytecode.c (exec_byte_code):
6185 * dispnew.c (init_display):
6186 * eval.c (error):
6187 * fileio.c (Fsubstitute_in_file_name):
6188 * keyboard.c (Fevent_convert_list):
6189 * keymap.c (Fsingle_key_description):
6190 * term.c (maybe_fatal, fatal):
6191 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
6192 * xsmfns.c (Fhandle_save_session):
6193 Omit unreachable code.
6194 * keymap.c (map_keymap_char_table_item): Cast void * to
6195 a function pointer type; the C Standard requires this.
6196
7fd8c501
PE
6197 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
6198 Include <sys/param.h> unconditionally, as that works elsewhere and
6199 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
6200 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
6201 and FreeBSD now.
6202
a020afb9 6203See ChangeLog.12 for earlier changes.
aac0c6e3
MR
6204
6205;; Local Variables:
6206;; coding: utf-8
aac0c6e3
MR
6207;; End:
6208
ab422c4d 6209 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
6210
6211 This file is part of GNU Emacs.
6212
6213 GNU Emacs is free software: you can redistribute it and/or modify
6214 it under the terms of the GNU General Public License as published by
6215 the Free Software Foundation, either version 3 of the License, or
6216 (at your option) any later version.
6217
6218 GNU Emacs is distributed in the hope that it will be useful,
6219 but WITHOUT ANY WARRANTY; without even the implied warranty of
6220 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6221 GNU General Public License for more details.
6222
6223 You should have received a copy of the GNU General Public License
6224 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.