* lisp/minibuffer.el (completion--replace): Be careful that `end' might be
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b52f569d
PE
12013-10-03 Paul Eggert <eggert@cs.ucla.edu>
2
75273afb
PE
3 * lisp.h (eassert): Assume that COND is true when optimizing.
4 In other words, take on the behavior of eassert_and_assume.
5 This makes Emacs 0.2% smaller on my platform (Fedora 19, x86-64).
6 (eassert_and_assume): Remove. All uses replaced by eassert.
7
ead45345
PE
8 * xdisp.c (Qglyphless_char): Now static.
9
0a858ebf
PE
10 Adjust to merge from gnulib.
11 * conf_post.h (__has_builtin, assume): Remove; gnulib now does these.
12 * lisp.h: Include <verify.h>, for 'assume'.
13
b52f569d
PE
14 * eval.c (clobbered_eassert): New macro.
15 (internal_catch, internal_condition_case)
16 (internal_condition_case_1, internal_condition_case_2)
17 (internal_condition_case_n): Use it instead of eassert
18 when the argument contains locals clobbered by longjmp.
19 Don't use clobbered locals outside of clobbered_eassert.
20 (internal_lisp_condition_case): Use a volatile variable
21 to work around a local variable's getting clobbered.
22
adf2aa61
SM
232013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
24
25 * lisp.h (struct handler): Merge struct handler and struct catchtag.
26 (PUSH_HANDLER): New macro.
27 (catchlist): Remove.
28 (handlerlist): Always declare.
29
30 * eval.c (catchlist): Remove (merge with handlerlist).
31 (handlerlist, lisp_eval_depth): Not static any more.
32 (internal_catch, internal_condition_case, internal_condition_case_1)
33 (internal_condition_case_2, internal_condition_case_n):
34 Use PUSH_HANDLER.
35 (unwind_to_catch, Fthrow, Fsignal): Adjust to merged
36 handlerlist/catchlist.
37 (internal_lisp_condition_case): Use PUSH_HANDLER. Adjust to new
38 handlerlist which can only handle a single condition-case handler at
39 a time.
40 (find_handler_clause): Simplify since we only a single branch here
41 any more.
42
43 * bytecode.c (BYTE_CODES): Add Bpushcatch, Bpushconditioncase
44 and Bpophandler.
45 (bcall0): New function.
46 (exec_byte_code): Add corresponding cases. Improve error message when
47 encountering an invalid byte-code. Let Bunwind_protect accept
48 a function (rather than a list of expressions) as argument.
49
50 * alloc.c (Fgarbage_collect): Merge scans of handlerlist and catchlist,
51 and make them unconditional now that they're heap-allocated.
52
328a8179
SM
532013-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
54
55 * charset.c (Fdecode_char, Fencode_char): Remove description of
56 `restriction' arg. now that it's hidden by advertised-calling-convention.
57
c348360a
JD
582013-10-02 Jan Djärv <jan.h.d@swipnet.se>
59
328a8179
SM
60 * macfont.m (mac_ctfont_create_preferred_family_for_attributes):
61 Remove unused variable (from mac-port).
c348360a
JD
62 (macfont_draw): Use s->ybase for correct y position.
63
1a23cd48
DA
642013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
65
66 * frame.h (struct frame): Drop has_minibuffer member because...
67 (FRAME_HAS_MINIBUF_P): ...this macro can be implemented without it.
68 * frame.c (make_frame, make_minibuffer_frame): Adjust users.
69
29bf4de4
DA
702013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
71
72 * window.h (struct window): Prefer enum text_cursor_kinds to int
73 for phys_cursor_type member. Move the latter, phys_cursor_width,
74 phys_cursor_ascent and phys_cursor_height under HAVE_WINDOW_SYSTEM.
75 * window.c (replace_window, make_window): Adjust users.
76
a30ddace
DA
772013-10-02 Dmitry Antipov <dmantipov@yandex.ru>
78
79 * fringe.c (toplevel): Do not use HAVE_WINDOW_SYSTEM because
80 this module is never compiled otherwise.
81
45435f08
AA
822013-10-01 Alp Aker <alp.tekin.aker@gmail.com>
83
84 * macfont.m (macfont_draw): Use CGRectMake rather than NSMakeRect
85 (Bug#15500).
86
92e5298b
EZ
872013-09-29 Eli Zaretskii <eliz@gnu.org>
88
89 * xdisp.c (get_next_display_element): Don't call face_for_font in
90 a build configured --without-x. (Bug#15484)
91
caa50be2
JD
922013-09-29 Jan Djärv <jan.h.d@swipnet.se>
93
66d13b20
JD
94 * window.c (calc_absolute_offset): #elif should be #elif defined.
95
caa50be2
JD
96 * frame.c (delete_frame): Block/unblock input to overcome race
97 condition (Bug#15475).
98
d3e2acb6
AP
992013-09-29 Andreas Politz <politza@hochschule-trier.de> (tiny change)
100
101 * frame.c (delete_frame): Record selected frame only after
102 calling Qdelete_frame_functions (Bug#15477).
103
1610938f
JD
1042013-09-28 Jan Djärv <jan.h.d@swipnet.se>
105
106 * nsterm.m (ns_selection_color): Remove.
107 (ns_get_color): Check for ns_selection_(fg|bg)_color using
108 NSColor selectedText(Background)Color. Only for COCOA.
109 (ns_term_init): Remove assignment of ns_selection_color, logic
110 moved to ns_get_color.
111
328a8179 112 * nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Rename from
1610938f
JD
113 NS_SELECTION_COLOR_DEFAULT.
114 (NS_SELECTION_FG_COLOR_DEFAULT): New.
115
0d2647e6
EZ
1162013-09-28 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
119 frame' does not have the tool_bar_window member.
120
ba355de0
BR
1212013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
122
123 Signal error when reading an empty byte-code object (Bug#15405)
124 * lread.c (read1): signal error
125 * alloc.c (make_byte_code): eassert header size
126 (sweep_vectors): change an int to size_t
127
4710d6f4
PE
1282013-09-24 Paul Eggert <eggert@cs.ucla.edu>
129
cf647d93
PE
130 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
131 instead of ints, as it's the usual style for offsetof constants. See:
132 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
133
4710d6f4
PE
134 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
135 This is ugly, but it should fix the performance problem for older
136 GCC versions in the short run. I'll look into integrating the
137 Gnulib module for popcount, as a better fix.
138 See the thread starting in:
139 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
140 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
141 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
142 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
143 (popcount_size_t): Use it.
144
10ebac9d
DC
1452013-09-24 Daniel Colascione <dancol@dancol.org>
146
147 * process.c (Fnetwork_interface_info): Fix build break due to
148 vector changes.
149
9da0f50e
PE
1502013-09-24 Paul Eggert <eggert@cs.ucla.edu>
151
152 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
153 Prefer signed to unsigned integers where either will do.
154 No need for 'const' on locals that do not escape.
155 Omit easserts with unnecessary and unportable assumptions about
156 alignment. Avoid unnecessary casts to char *.
157
d6d9cbc1
DA
1582013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
159
160 Use union for the payload of struct Lisp_Vector.
161 This helps to avoid a few glitches dictated by C's aliasing rules.
162 * lisp.h (struct Lisp_Vector): Use union for next and
163 contents member. Adjust comment. Change related users.
164 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
165 Related users changed.
166 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
167 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
168 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
169 * xfaces.c, xfont.c, xmenu.c: Related users changed.
170
ec7bc82f
DA
1712013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
172
173 Optimize glyph row clearing and copying routines.
174 * dispextern.h (struct glyph_row): Change layout of struct
175 glyph_row to help copy_row_except_pointers. Adjust comment.
176 * dispnew.c (null_row): Remove.
177 (clear_glyph_row): Use offsetof and memset to find and clear
178 just the members that need clearing. Adjust comment.
179 (copy_row_except_pointers): Likewise for copying.
180
d160dd0c
PE
1812013-09-24 Paul Eggert <eggert@cs.ucla.edu>
182
7be68de5
PE
183 Some minor cleanups of recently-added bool vector code.
184 * conf_post.h (assume): Always return void. Use lint version
185 only if GCC and MSC versions don't apply.
186 * conf_post.h (assume):
187 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
188 Depend on _MSC_VER, not __MSC_VER, for consistency with
189 the rest of Emacs.
190 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
191 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
192 (bool_vector_binop_driver, count_trailing_zero_bits)
193 (size_t_to_host_endian): Now static, not static inline;
194 the latter isn't needed with modern compilers and doesn't
195 work with older compilers anyway.
196
d160dd0c
PE
197 * alloc.c (valgrind_p): Use bool for boolean.
198
e08813d0
DA
1992013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
200
201 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
202 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
203 (display_last_displayed_message_p, message_buf_print)
204 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
205 Use bool for boolean.
3a6a78fd
DA
206 * dispextern.h (cancel_line, init_desired_glyphs):
207 Remove ancient leftover.
208 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
209 * lisp.h (noninteractive_need_newline): Adjust declaration.
210
5492865b
DA
2112013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
212
213 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
214 Move to...
215 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
216 ...this file and convert the latter to static. Adjust comment.
217 (make_initial_frame):
218 * window.c (init_window_once): Adjust user.
219 * frame.h (last_nonminibuf_frame): Remove declaration.
220 * lisp.h (selected_frame): Likewise.
221 * msdos.c (the_only_display_info): Adjust comment.
222
cd548fa4
EZ
2232013-09-23 Eli Zaretskii <eliz@gnu.org>
224
f03eddbf
EZ
225 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
226 computing the end column of mouse-highlight that comes from
227 display or overlay strings. (Bug#15437)
b519df23
EZ
228 (note_mouse_highlight): Adapt calculation of last argument to
229 mouse_face_from_string_pos to the above change.
f03eddbf 230
cd548fa4
EZ
231 * conf_post.h (__has_builtin): Define to zero, if undefined, on
232 all platforms, not just for clang.
233
8762e524
JD
2342013-09-23 Jan Djärv <jan.h.d@swipnet.se>
235
236 * filelock.c (lock_file_1): Rearrange to remove compiler warning
237 about excess arguments to snprintf.
238
239 * conf_post.h(assume): Use __builtin_unreachable for clang.
240
d4a9284f
JB
2412013-09-23 Juanma Barranquero <lekktu@gmail.com>
242
243 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
244 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
245
a84683fd
DC
2462013-09-23 Daniel Colascione <dancol@dancol.org>
247
248 * alloc.c (USE_VALGRIND): New macro; on by default
249 when ENABLE_CHECKING.
250 (mark_maybe_object,mark_maybe_pointer)
251 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
252 valgrind purposes.
253 (valgrind_p) [USE_VALGRIND]: New variable.
254 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
255
8fef36c6
JD
2562013-09-22 Jan Djärv <jan.h.d@swipnet.se>
257
fb83ea63
JD
258 * process.c (wait_reading_process_output): Change int pnamelen to
259 socklen_t.
260
261 * nsterm.m (setMarkedText:selectedRange:):
262 (deleteWorkingText):
263 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
264 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
265 argument to unsigned long to avoid warning.
266 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
267
8fef36c6
JD
268 * conf_post.h (assume): Fix compiler error: x shall be cond.
269
cd9356f2
DC
2702013-09-22 Daniel Colascione <dancol@dancol.org>
271
272 * xfns.c (x_get_monitor_attributes): Suppress unused variable
273 warning when compiling without a window system.
274
3e0b94e7
DC
2752013-09-22 Daniel Colascione <dancol@dancol.org>
276
277 * data.c (Qbool_vector_p): New symbol.
278 (bool_vector_spare_mask,popcount_size_t_generic)
279 (popcount_size_t_msc,popcount_size_t_gcc)
280 (popcount_size_t)
281 (bool_vector_binop_driver)
282 (count_trailing_zero_bits,size_t_to_host_endian)
283 (Fbool_vector_exclusive_or)
284 (Fbool_vector_union)
285 (Fbool_vector_intersection,Fbool_vector_set_difference)
286 (Fbool_vector_subsetp,Fbool_vector_not)
287 (Fbool_vector_count_matches)
288 (Fbool_vector_count_matches_at): New functions.
289 (syms_of_data): Intern new symbol, functions.
290 * alloc.c (bool_vector_payload_bytes): New function.
291 (Fmake_bool_vector): Instead of calling Fmake_vector,
292 which performs redundant initialization and argument checking,
293 just call allocate_vector ourselves. Make sure we clear any
294 terminating padding to zero.
295 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
296 instead of open-coding the size calculation.
297 (vroundup_ct): New macro.
298 (vroundup): Assume argument >= 0; invoke vroundup_ct.
299 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
328a8179
SM
300 * composite.c (composition_gstring_put_cache):
301 Change lint_assume to assume.
3e0b94e7
DC
302 * conf_post.h (assume): New macro.
303 (lint_assume): Remove.
304 * dispnew.c (update_frame_1): Change lint_assume to assume.
305 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
306 to assume.
307 * image.c (gif_load): Change lint_assume to assume.
308 * lisp.h (eassert_and_assume): New macro.
309 (Qbool_vector_p): Declare.
310 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
311 (swap16,swap32,swap64): New inline functions.
312 * macfont.c (macfont_shape): Change lint_assume to assume.
313 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
314 * xsettings.c (parse_settings): Use new swap16 and
315 swap32 from lisp.h instead of file-specific macros.
316
76880d88
EZ
3172013-09-22 Eli Zaretskii <eliz@gnu.org>
318
319 * xdisp.c (try_window_id): Don't abort if cursor row could not be
320 found (which can legitimately happen when the glyph row at the
321 window start is disabled in the current_matrix. (Bug#15365)
322
c6cfd910
PE
3232013-09-22 Paul Eggert <eggert@cs.ucla.edu>
324
325 Fix syntax.h bug introduced by recent INLINE change.
326 syntax.h defined an extern inline function SYNTAX_ENTRY that was
327 conditionally compiled one way in some modules, and a different
328 way in others. This doesn't work with extern inline functions,
329 which must have the same definition in all modules, because the
330 defining code might be shared across modules, depending on the
331 implementation. Symptoms reported by Martin Rudalics in:
332 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
333 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
334 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
335 overriding the corresponding functions in syntax.h.
336 * syntax.h (syntax_property_entry, syntax_property_with_flags)
337 (syntax_property): New inline functions.
338 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
339 Rewrite in terms of these new functions.
340
b3f1d119
EZ
3412013-09-21 Eli Zaretskii <eliz@gnu.org>
342
343 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
344 not chars_in_text, whose result depends on the multibyteness of
345 the current buffer. (Bug#15426)
346
00382e8b
PE
3472013-09-20 Paul Eggert <eggert@cs.ucla.edu>
348
e3b29769
PE
349 Port recent change to hosts where pointers aren't 'long'.
350 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
351 Don't assume that pointers are the same width as 'long'.
352 Add a compile-time check that a pointer fits into two X slots.
353
00382e8b
PE
354 A simpler, centralized INLINE.
355 * conf_post.h (INLINE): Define only if not already defined.
356 This allows us to use a single INLINE, defined by one file
357 per executable.
358 * emacs.c (INLINE): Define it.
359 Also, include category.h, charset.h, composite.h, dispextern.h,
360 syntax.h, systime.h, so that their INLINE definitions are expanded
361 properly for Emacs.
362 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
363 * buffer.h, buffer.c (BUFFER_INLINE):
364 * category.h, category.c (CATEGORY_INLINE):
365 * character.h, character.c (CHARACTER_INLINE):
366 * charset.h, charset.c (CHARSET_INLINE):
367 * composite.h, composite.c (COMPOSITE_INLINE):
368 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
369 * frame.h, frame.c (FRAME_INLINE):
370 * intervals.h, intervals.c (INTERVALS_INLINE):
371 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
372 * lisp.h, alloc.c (LISP_INLINE):
373 * process.h, process.c (PROCESS_INLINE):
374 * syntax.h, syntax.c (SYNTAX_INLINE):
375 * systime.h, sysdep.c (SYSTIME_INLINE):
376 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
377 * window.h, window.c (WINDOW_INLINE):
378 Remove. All uses replaced with INLINE.
379
2b943ba6
DA
3802013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
381
382 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
383 to avoid Bug#15398.
384
13d9698a
EZ
3852013-09-19 Eli Zaretskii <eliz@gnu.org>
386
387 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
388 'const char *' to avoid compiler warnings due to similar change in
389 the prototype of x_get_string_resource.
390
ced135eb
DA
3912013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
392
393 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
394 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
395 going to replace static variables below. Adjust comments.
396 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
397 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
398 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
399 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
400 Related users changed.
401 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
402 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
403 last_mouse_movement_time, going to replace static variables below.
404 Adjust comments.
405 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
406 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
407 Remove.
408 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
409 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
410 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
411 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
412 static variables below.
413 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
414 (last_mouse_scroll_bar): Remove.
415 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
416 (mouseExited): Related users changed.
417
091f1e1f
DA
4182013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
419
420 Do not use external array to process X scroll bar messages.
421 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
422 (x_send_scroll_bar_event): Pack window pointer into two slots
423 of XClientMessageEvent if we're 64-bit. Adjust comment.
424 (x_scroll_bar_to_input_event): Unpack accordingly.
425
582ed56c
DA
4262013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
427
428 Ifdef away recent changes which aren't relevant to NS port.
429 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
430 [!HAVE_NS]: Declare as such.
431 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
432 [!HAVE_NS]: Define as such.
433
18da0d8a
DA
4342013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
435
436 * frame.c (x_redo_mouse_highlight): New function
437 to factor out common code used in W32 and X ports.
438 * dispextern.h (x_redo_mouse_highlight): Add prototype.
439 * xterm.h (struct x_display_info):
440 * w32term.h (struct w32_display_info):
441 * nsterm.h (struct ns_display_info): New members
442 last_mouse_motion_frame, last_mouse_motion_x and
443 last_mouse_motion_y, going to replace static variables below.
444 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
445 (redo_mouse_highlight): Remove.
446 (note_mouse_movement, syms_of_xterm): Adjust user.
447 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
448 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
449 (redo_mouse_highlight): Remove.
450 (note_mouse_movement, syms_of_w32term): Adjust user.
451 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
452 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
453 Remove.
454 (note_mouse_movement, mouseMoved, syms_of_nsterm):
455 * nsfns.m (compute_tip_xy): Adjust user.
456
7a0c745a
DA
4572013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
458
459 * frame.c (x_mouse_grabbed): New function.
460 * dispextern.h (x_mouse_grabbed): Add prototype.
461 (last_mouse_frame): Remove declaration.
462 * xterm.h (struct x_display_info):
463 * w32term.h (struct w32_display_info):
464 * nsterm.h (struct ns_display_info): New member
465 last_mouse_frame, going to replace...
466 * xdisp.c (last_mouse_frame): ...global variable.
467 (note_tool_bar_highlight):
468 * w32term.c (w32_mouse_position, w32_read_socket):
469 * xterm.c (XTmouse_position, handle_one_xevent):
470 Use x_mouse_grabbed.
471 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
472
0791d107
DA
4732013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
474
475 * w32term.c (w32_read_socket): Avoid temporary
476 variables in a call to x_real_positions.
477 * xterm.c (handle_one_xevent): Likewise.
478
2cd98812
DA
4792013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
480
481 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
482 (x_icon_type): Remove prototype.
483 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
484 * frame.c (x_icon_type): Remove.
485 * w32term.c (x_make_frame_visible, x_iconify_frame):
486 * xterm.c (x_make_frame_visible, x_iconify_frame):
487 Use x_set_bitmap_icon to factor out common code.
488
a6c2ee1b
DA
4892013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
490
491 * dispextern.h (check_x_display_info, x_get_string_resource):
492 Declare here just once and unify the latter.
493 * frame.c (check_x_display_info, x_get_string_resource):
494 * nsterm.h (check_x_display_info):
495 * xrdb.c (x_get_string_resource):
496 * xterm.h (check_x_display_info): Remove prototypes.
497 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
498 * w32reg.c (x_get_string_resource): Likewise.
499 (w32_get_rdb_resource): Adjust user.
500
baed3603
DA
5012013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
502
503 * xterm.h (struct x_display_info): New member
504 x_pending_autoraise_frame, going to replace...
505 * xterm.c (pending_autoraise_frame): ...static variable.
506 (x_new_focus_frame, XTread_socket): Adjust users.
507 * w32term.h (struct w32_display_info): New member
508 w32_pending_autoraise_frame, going to replace...
509 * w32term.c (pending_autoraise_frame): ...global variable.
510 (x_new_focus_frame, w32_read_socket): Adjust users.
511
90582f05
GM
5122013-09-17 Glenn Morris <rgm@gnu.org>
513
514 * xdisp.c (message_dolog): If we create *Messages*,
515 switch it to messages-buffer-mode.
516
b7ad2f74
PE
5172013-09-17 Paul Eggert <eggert@cs.ucla.edu>
518
519 Don't overuse 'const' in types of locals.
520 * bidi.c (bidi_count_bytes):
521 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
522 (xg_event_is_for_scrollbar):
523 * xselect.c (x_handle_property_notify)
524 (x_handle_selection_notify, x_handle_dnd_message):
525 * xsettings.c, xsettings.h (xft_settings_event):
526 * xterm.c (x_handle_net_wm_state, handle_one_event)
527 (x_menubar_window_to_frame, x_detect_focus_change)
528 (construct_mouse_click, note_mouse_movement)
529 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
530 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
531 (handle_one_xevent, x_handle_net_wm_state):
532 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
533 (x_handle_dnd_message):
534 Avoid unnecessary 'const', typically the second 'const' in
535 'const foo * const arg', a 'const' that does not affect the API
536 and doesn't significantly help the human reader.
537
19452b86
DA
5382013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
539
540 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
541 only if Glib < 2.36.0.
542 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
543 * xsettings.c (init_gconf, init_gsettings): Do not check
544 for g_type_init.
1893694e
DA
545 * xterm.c (handle_one_xevent): Do not call to x_clear_area
546 if GTK >= 2.7.0.
33b83dd7 547 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 548
6434e343
JD
5492013-09-16 Jan Djärv <jan.h.d@swipnet.se>
550
3f386383
JD
551 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
552 before calling g_type_init.
553
6434e343
JD
554 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
555
556 * nsterm.m (syms_of_nsterm): ... to here.
557
83a119f8
DA
5582013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
559
560 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
561 (ignore_next_mouse_click_timeout): Use Time as X does.
562 (handle_one_xevent): Avoid cast and use unsigned comparison.
563
61582e6a
DA
5642013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
565
566 Do not copy X event in handle_one_xevent except KeyPress case.
567 Wnen XEvent is processed, it is unlikely to be changed except
568 KeyPress case, so we can avoid copying and use const pointer to
569 const data to make sure that an event is not changed elsewhere.
570 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
571 const' and do not create local copy except for the KeyPress event.
572 Use casts to avoid a few glitches. Adjust formatting. Add comments.
573 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
574 (x_handle_net_wm_state, x_menubar_window_to_frame)
575 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
576 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
577 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
578 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
579 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
580 (x_handle_dnd_message):
581 * xsettings.c (xft_settings_event):
582 Use 'const XEvent * const' where appropriate.
583 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
584
f8eb1572
DA
5852013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
586
587 Fix X event waiting to handle multiple frames.
588 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
589 * xterm.c (pending_event_wait): Remove. Adjust users.
590 (x_detect_focus_change): Pass frame arg.
591 (handle_one_xevent): Find related frame early and clear per-frame
592 wait_event_type only if this is an event for the relevant frame.
593 (x_wait_for_event): Use per-frame wait_event_type.
594
3fa2054e
JD
5952013-09-15 Jan Djärv <jan.h.d@swipnet.se>
596
745d3809
JD
597 * nsfns.m (Fx_create_frame): Fix font driver registration for
598 GNUStep.
599
600 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
601 for syms_of_macfont.
602
3fa2054e
JD
603 * nsterm.m: Include macfont.h.
604 (ns_tmp_flags, ns_tmp_font): Remove.
605 (ns_compute_glyph_string_overhangs): Check for driver Qns.
606 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
607 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
608 (changeFont:): Fix code style. Check for font driver type when
609 getiing font.
610
611 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
612 (f)->descent.
613
614 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
615 (nsfont_open): Set font driver type.
616 Set font->ascent and font->descent. Figure out font instead of
617 ns_tmp_font, and flags instead of ns_tmp_flags.
618 Fix indentation. Remove call to ns_draw_text_decoration,
619 moved to nsterm.
620
621 * nsfns.m: Include macfont.h.
622 (Fx_create_frame): Register macfont driver, make a better default font.
623 (Fns_popup_font_panel): Get font from macfont driver, if used.
624
625 * macfont.m, macfont.h, maccuvs.h: New files.
626
627 * font.h: Declare syms_of_macfont.
628
629 * font.c (syms_of_font): Call syms_of_macfont.
630
631 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
632
0eed0355
DA
6332013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
636 and it is always zero for others, so I assume that this is an ancient
637 leftover which nobody will want to change any more.
638 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
639 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
640 * frame.c (x_set_scroll_bar_width):
641 * w32fns.c (w32_createscrollbar):
642 * w32term.c (w32_set_vertical_scroll_bar):
643 * xfns.c (x_set_scroll_bar_default_width):
644 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
645 (x_scroll_bar_expose): Related users changed.
646
07013c68
DA
6472013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
648
649 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
650 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
651 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
652 Define as such.
c7cc32f7
DA
653 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
654 Define once here...
655 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
656 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
657 Remove unused Xisms.
7f09455e
DA
658 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
659 these modules are never compiled otherwise.
07013c68 660
0df00f59
EZ
6612013-09-14 Eli Zaretskii <eliz@gnu.org>
662
08a209bf 663 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
664 Doc fix. (Bug#15375)
665
fcd42c11
DA
6662013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Unify Fx_focus_frame between all ports.
669 * frame.h (x_focus_frame): New prototype.
670 * xfns.c (Fx_focus_frame): Remove.
671 (syms_of_xfns): Do not defsubr it.
672 (x_focus_frame): X implementation.
673 * nsfns.m (Fx_focus_frame): Remove.
674 (syms_of_nsfns): Do not defsubr it.
675 (x_focus_frame): NS implementation.
676 * w32term.c (Fx_focus_frame): Remove.
677 (x_focus_on_frame): Rename to...
678 (x_focus_frame): W32 implementation.
679 * w32term.h (x_focus_on_frame): Remove prototype.
680 * w32fns.c (Fx_focus_frame): Remove.
681 (syms_of_w32fns): Do not defsubr it.
682 * frame.c (Fx_focus_frame): Define here.
683 (syms_of_frame): Defsubr here.
684 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
685
aad3612f
DA
6862013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
687
688 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
689 All of them are replaced with FRAME_DISPLAY_INFO, defined in
690 each port to reference the port-specific window system data.
691 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
692 (FRAME_DISPLAY_INFO): Define.
693 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
694 (FRAME_DISPLAY_INFO): Define. Adjust users.
695 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
696 (FRAME_DISPLAY_INFO): Define. Adjust users.
697 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
698 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
699 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
700 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
701 * xselect.c, xterm.c: All related users changed.
702
9a650e62
DA
7032013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
704
705 * xterm.h (x_window_to_frame, x_any_window_to_frame)
706 (x_menubar_window_to_frame): Remove prototypes.
707 * xfns.c (x_window_to_frame, x_any_window_to_frame)
708 (x_menubar_window_to_frame, x_top_window_to_frame):
709 Move from here...
710 * xterm.c (x_window_to_frame, x_any_window_to_frame)
711 (x_menubar_window_to_frame, x_top_window_to_frame):
712 ...to here and convert all but the last to static.
713
347ae3e1
EZ
7142013-09-12 Eli Zaretskii <eliz@gnu.org>
715
716 * lisp.mk (lisp): Add w32-common-fns.elc.
717
15c6d837
XF
7182013-09-12 Xue Fuqiao <xfq.free@gmail.com>
719
720 * charset.c (char_charset): Document an exception for char-charset.
721
27e90f77
DA
7222013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
723
724 * xterm.h (x_display_info): New field last_user_time...
725 * xterm.c (toplevel): ...to replace static last_user_time.
726 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
727
8ffbc36b
DA
7282013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
729
730 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
731 scroll bar values to prevent thumb from disappear and update comment.
732
5ec0337a
GM
7332013-09-11 Glenn Morris <rgm@gnu.org>
734
735 * emacs.c (usage_message): Possessive apostrophe tweak.
736
fb55b9d1
DA
7372013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
738
8d2db8be
DA
739 * nsterm.m (syms_of_nsterm): Use Qns.
740 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
741 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
742 * xfns.c (x_display_info_for_name, Fx_open_connection):
743 Remove old '#if 0' code.
744 (syms_of_xfns): Use Qx.
fb55b9d1
DA
745 * termhooks.h (fullscreen_hook): Remove the leftover.
746 (struct terminal): Fix typo in comment.
747
927eec55
DA
7482013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
749
750 Cleaning up a few X scroll bar bits.
751 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
752 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
753 New member last_seen_part, going to replace...
754 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
755 (xt_action_hook) [USE_LUCID]: Adjust user.
756 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
757 Lucid-specific scroll bar support.
758 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
759 to int and adjust to use last_seen_part member.
760 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
761 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
762 Initialize last_seen_part.
763
71b28baa
SM
7642013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
765
766 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
767 insert-buffer-substring an empty string.
768
f5dacaae
PE
7692013-09-11 Paul Eggert <eggert@cs.ucla.edu>
770
771 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
772 avoiding a GCC warning.
773
742516e0
DA
7742013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
775
776 Ifdef away frame tool bar code when it is not really used.
777 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
778 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
779 and minimize_tool_bar_window_p under the above.
780 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
781 (fset_tool_bar_window): Likewise.
782 * dispnew.c (clear_current_matrices, clear_desired_matrices)
783 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
784 (change_frame_size_1):
785 * window.c (window_from_coordinates, Frecenter): Adjust users.
786 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
787 code is not really used.
788 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
789 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
790 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
791 [!USE_GTK && !HAVE_NS]: Define as such.
792 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
793 (note_mouse_highlight, expose_frame):
794 * xfns.c (x_set_tool_bar_lines):
795 * xterm.c (handle_one_xevent): Adjust users.
796
73f82c7e
PE
7972013-09-11 Paul Eggert <eggert@cs.ucla.edu>
798
799 Fix corruption with multiple emacsclient -t instances (Bug#15222).
800 This bug was introduced by my 2013-08-26 patch, which incorrectly
801 assumed that the terminfo implementation doesn't use termcap buffers.
802 * term.c (init_tty) [TERMINFO]: Remove optimization, as
803 these buffers apparently are used after all.
804 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
805 (struct tty_display_info): Define members termcap_term_buffer and
806 termcap_strings_buffer even if TERMINFO.
807
53482f41
DA
8082013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
809
810 Fix last change.
811 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
812 'usage' docstring entry to pacify make-docfile.
813
8142013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
815
816 Change comparison functions =, <, >, <=, >= to take many arguments.
817 * data.c: Change comparison functions' interface and implementation.
818 * lisp.h: Make arithcompare available for efficient two arg
819 comparisons.
820 * bytecode.c: Use arithcompare.
821 * fileio.c: Use new interface.
822
533f258f
SM
8232013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
824
825 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
826
8c27f5ff
SM
8272013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
828
829 * eval.c (Feval): Document the new use of `lexical'.
830
0750a308
DA
8312013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
832
833 Review and drop old frame resize hack.
834 * frame.h (struct frame): Remove force_flush_display_p.
835 * dispnew.c (update_frame): Adjust user and don't call
836 flush_frame here. The comment has said that there was an issues
837 with redisplaying fringes, but I don't see any differences with
838 and without this hack. Hopefully we can continue without it.
839 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
840 current frame matrices twice if resized_p is set.
841
83fc0554
DA
8422013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
843
844 Do not populate pure Xism x_sync to other ports.
845 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
846 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
847 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
848 * w32term.h (x_sync): Remove prototype.
849
fd462129
DA
8502013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
851
852 Cleanup frame flushing.
8c27f5ff
SM
853 * dispextern.h (struct redisplay_interface):
854 Drop flush_display_optional because flush_display is enough
fd462129
DA
855 for X and flushing via RIF is just a no-op for others.
856 * frame.h (flush_frame): New function.
857 * dispnew.c (update_frame):
858 * minibuf.c (read_minibuf):
859 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
860 Use it.
861 * keyboard.c (detect_input_pending_run_timers): Do not flush
862 all frames but selected one in redisplay_preserve_echo_area.
863 * nsterm.m (ns_flush): Remove no-op.
864 (ns_redisplay_interface): Adjust user.
865 * w32term.h (x_flush): Remove no-op.
866 (w32_redisplay_interface): Adjust user.
867 * xterm.c (x_flush): Simplify because we do not flush all
868 frames at once any more. Adjust comment.
869 (x_redisplay_interface): Adjust user.
870
4b73fc73
PE
8712013-09-07 Paul Eggert <eggert@cs.ucla.edu>
872
873 Port --without-x --enable-gcc-warnings to Fedora 19.
874 * gfilenotify.c (globals_of_gfilenotify):
875 Call g_type_init only if using an older glib version that needs it.
876
77394d40
DA
8772013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
878
879 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
880 (last_glyphless_glyph_merged_face_id): Remove declarations.
881 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
882 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
883 (last_glyphless_glyph_merged_face_id): Now static.
884 (merge_escape_glyph_face): New function, refactored from...
885 (get_next_display_element): ...here.
886 (merge_glyphless_glyph_face): New function, refactored from...
887 (produce_glyphless_glyph): ...here...
888 * term.c (produce_glyphless_glyph): ...and here.
889
306d67bd
SM
8902013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
891
892 * eval.c (eval_sub): Only call Ffunction if necessary.
893
7f6c6450
DA
8942013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
895
896 Attempt to make redisplay more selective when changing cursor type.
897 * frame.h (struct frame): New bitfield cursor_type_changed.
898 * xdisp.c (cursor_type_changed): Remove.
899 (try_cursor_movement, redisplay_window, try_window_id)
900 (set_frame_cursor_types, try_window_reusing_current_matrix):
901 Adjust to use per-frame bitfield.
902 (redisplay_internal): Look for cursor type change on each visible
903 frame and consider all frames if cursor type has been changed on
904 the frame other than selected. If cursor type has been changed on
905 selected frame only, do not use fast update.
906
bd0443bb
DA
9072013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
908
909 Attempt to make redisplay more selective when changing fonts.
910 * frame.h (struct frame): New bitfield fonts_changed.
911 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
912 (adjust_frame_glyphs): Add prototype.
913 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 914 (adjust_glyphs): Remove because we do not
bd0443bb
DA
915 adjust matrices on all frames at once any more.
916 (adjust_frame_glyphs): Block and unblock input here.
917 (adjust_glyph_matrix): Use fonts_changed.
918 (change_frame_size_1): Use adjust_frame_glyphs.
919 * font.c (font_open_entity): Use fonts_changed.
920 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
921 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
922 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
923 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
924 (shrink_mini_window, Fresize_mini_window_internal)
925 (window_scroll_pixel_based, Fset_window_configuration)
926 (apply_window_adjustment, Fset_window_vscroll):
927 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
928 Use adjust_frame_glyphs.
929 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
930 (try_window_reusing_current_matrix, try_window_id, display_line)
931 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
932 (redisplay_internal): Consider fonts_changed and adjust frame
933 matrices for each frame only if the frame is visible. If font
934 has been changed on some frame during full redisplay, retry
935 only visible frames where the font has been actually changed.
936
b9695828
DA
9372013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
938
939 Cache current header and mode line height for each window.
940 * window.h (struct window): New fields mode_line_height
941 and header_line_height.
942 * window.c (make_window): Initialize them.
943 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
944 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
945 (current_mode_line_height, current_header_line_height):
946 Remove declaration.
947 * xdisp.c (current_mode_line_height, current_header_line_height):
948 Remove.
949 (pos_visible_p, init_xdisp): Adjust user.
950 (redisplay_window): Invalidate mode_line_height and
951 header_line_height if current and desired matrices do not agree.
952
66738305
DA
9532013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
954
955 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
956 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
957
257b3b03
DA
9582013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
959
960 Make --without-x compatible with --enable-gcc-warnings.
961 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
962 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
963 members under HAVE_WINDOW_SYSTEM.
964 * keyboard.c (make_lispy_focus_out): Likewise.
965 (record_menu_key): Move under HAVE_MENUS.
966 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
967 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
968 (syms_of_xdisp): Adjust user.
969 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
970 (start_hourglass, cancel_hourglass):
971 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
972 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
973 and CLEAR_FONT_TABLE_NFONTS.
974 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
975 Declare only if HAVE_WINDOW_SYSTEM.
976 (lface_same_font_attributes_p, clear_face_gcs): Define only
977 if HAVE_WINDOW_SYSTEM.
978
98b7f4bd
DA
9792013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
980
981 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
982 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
983 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
984
a7e43722
SM
9852013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
986
987 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
988
0c90b9ee
PE
9892013-09-04 Paul Eggert <eggert@cs.ucla.edu>
990
991 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
992 This fixes a type error on hosts where ptrdiff_t is wider than int.
993
d99760fa
SM
9942013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
995
6629638e
SM
996 * keyboard.c (read_key_sequence_vs): New function.
997 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
998 common code.
999
d99760fa
SM
1000 * callint.c (Fcall_interactively): Always return a vector for 'K'.
1001
224e313d
PE
10022013-09-04 Paul Eggert <eggert@cs.ucla.edu>
1003
1004 Makefile improvements.
1005 * Makefile.in (config.status): Don't use double-colon rules, as
1006 they are not portable according to POSIX. Fix shell typo with `;
1007 I guess this rule has never been tested?
1008 (VCSWITNESS): New macro, to override any environment var.
1009
6d6ed1af
DA
10102013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
1011
1012 * xterm.h (struct x_display_info): Do not track X connection
1013 fd separately because it is always available from Display.
1014 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
1015 Adjust users.
1016
bc923770
DA
10172013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1018
1019 * buffer.c (drop_overlay):
1020 * fileio.c (restore_point_unwind): Prefer unchain_marker to
1021 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
1022
b1cf96de
DA
10232013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1024
1025 * buffer.c (Fmake_overlay, Fmove_overlay):
1026 * intervals.c (set_point_from_marker):
1027 * print.c (PRINTPREPARE): Prefer signal_error
1028 to plain error and report unsuitable marker too.
1029
d1fc6c21
DA
10302013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
1031
1032 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
1033 for 'dragging' member.
d1ae6a0b
DA
1034 (struct x_output): Remove set-but-unused leftovers
1035 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
1036 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
1037 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
1038 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
1039 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
1040 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
1041 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 1042 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 1043 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 1044
0ce9f6de
JD
10452013-09-03 Jan Djärv <jan.h.d@swipnet.se>
1046
1047 * nsfont.m (INVALID_GLYPH): New define.
1048 (nsfont_encode_char): Use INVALID_GLYPH.
1049 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
1050
b594a96c
DA
10512013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1052
1053 * xterm.c (x_last_mouse_movement_time): Revert last change.
1054 This code should use XDisplayMotionBufferSize to check display's
1055 motion history first, and there are few other issues as well.
1056 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
1057 (handle_one_xevent): Adjust user.
1058
8b098236
MR
10592013-09-02 Martin Rudalics <rudalics@gmx.at>
1060
9718b207
MR
1061 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
1062 * frame.c (Flast_nonminibuf_frame): ... to here.
1063 (check_minibuf_window): Don't abort if no window was found
1064 (Bug#15247).
8b098236 1065
84e70bba
DA
10662013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1067
1068 Use XGetMotionEvents to ask the last mouse motion time from X server.
1069 * xterm.c (X_MOTION_HISTORY): Default to 1.
1070 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
1071 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
1072 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
1073 Ifdef away legacy code.
1074 (XTmouse_position, x_scroll_bar_report_motion):
1075 Use x_last_mouse_movement_time.
fc85e20b
DA
1076 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
1077 UnmapNotify event.
84e70bba 1078
1fccc530
DA
10792013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1080
1081 * msdos.c (last_mouse_window): Move to...
1082 (dos_rawgetc): ...this function and adjust comment.
1083 * nsterm.m (last_window): Rename to last_mouse_window, move to...
1084 (mouseMoved): ...this function and adjust comment.
1085 * w32term.c (last_window): Likewise with...
1086 (w32_read_socket): ...this function.
1087 * xterm.c (last_window): Likewise with...
1088 (handle_one_xevent): ...this function.
1089
0ab10992
DA
10902013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1091
b7da754d 1092 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
1093 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
1094 (handle_one_xevent): ...to here.
1095 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
1096 otherwise.
1097
0c7f856e
DA
10982013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
1099
1100 * msdos.c (IT_set_terminal_window): Remove no-op.
1101 (initialize_msdos_display): Adjust terminal setup.
1102 * w32console.c (w32con_set_terminal_window): Remove no-op.
1103 (initialize_w32_display): Adjust terminal setup.
1104 * w32term.c (w32_set_terminal_window): Remove no-op.
1105 (w32_create_terminal): Adjust terminal setup.
1106 * xterm.c (XTset_terminal_window): Remove no-op.
1107 (x_create_terminal): Adjust terminal setup.
1108
a892a94c
DA
11092013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
1112 Remove no-ops.
1113 (ns_create_terminal): Adjust terminal setup.
1114 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
1115 Remove no-ops.
1116 (w32_create_terminal): Adjust terminal setup.
1117 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
1118 Remove no-ops.
1119 (x_create_terminal): Adjust terminal setup.
1120
cf91889a
DA
11212013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1124 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1125 * dispnew.c (buffer_posn_from_coords):
1126 * window.c (Fwindow_end, displayed_window_lines):
1127 * xdisp.c (redisplay_mode_lines): Use it.
1128
5b0891df
JD
11292013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1130
1131 * fontset.c (face_for_char): Check char in the current face font first
1132 if HAVE_NS (Bug#15138).
1133
0a357e98
MR
11342013-08-31 Martin Rudalics <rudalics@gmx.at>
1135
1136 * window.c (temp_output_buffer_show): Make sure window returned
1137 by display_buffer is live (Bug#15213).
1138
9d7693d7
DA
11392013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 Minor cleanup to avoid forward declarations.
1142 * coding.h (struct ccl_spec): Remove forward declaration.
1143 * composite.h (toplevel): Include font.h.
1144 (struct composition_it, struct face, struct font_metrics):
1145 Remove forward declaration.
1146 * dispextern.h (struct image, struct atimer): Likewise.
1147 * emacsgtkfixed.h (struct frame): Likewise.
1148 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1149 * font.h (struct font_driver, struct font, struct glyph_string)
1150 (struct face): Remove forward declaration.
1151 * fontset.h (struct face, struct font): Likewise.
1152 * frame.h (toplevel): Style cleanup.
1153 (enum output_method): Move to...
1154 * termhooks.h (enum output_method): ...here.
1155 (struct glyph, struct frame, struct ns_display_info)
1156 (struct x_display_info, struct w32_display_info):
1157 Remove forward declaration.
1158 * xterm.h (toplevel): Include termhooks.h.
1159 (struct font, struct window, struct glyph_matrix, struct frame)
1160 (struct input_event, struct face, struct image): Remove forward
1161 declaration.
1162 * gtkutil.h (struct _widget_value): Likewise.
1163 * keyboard.h (toplevel): Include termhooks.h.
1164 (struct input_event): Remove forward declaration.
1165
032f7451
DA
11662013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1167
1168 * intervals.c (set_point_from_marker): New function.
1169 * editfns.c (Fgoto_char):
1170 * process.c (Finternal_default_process_filter):
1171 * window.c (select_window_1): Use it.
1172 * buffer.h (set_point_from_marker): Add prototype.
1173
3f940c5a
EZ
11742013-08-29 Eli Zaretskii <eliz@gnu.org>
1175
1176 * w32.c (term_winsock): Call release_listen_threads before calling
1177 WSACleanup.
1178 (_sys_wait_accept): Wait for accept event in a loop with a finite
1179 timeout, instead of waiting indefinitely. Will hopefully avoid
1180 hanging during exit because WSACleanup deadlocks waiting for the
1181 event object to be released. (Bug#14333)
1182
1183 * w32proc.c (release_listen_threads): New function, signals all
1184 the reader threads that listen for connections to stop waiting.
1185
1186 * w32.h (release_listen_threads): Add prototype.
1187
101ed2bb
DA
11882013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1189
1190 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1191 field of new marker (for sanity and safety).
20de2834
DA
1192 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1193 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1194
1f5cf200
DA
11952013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1196
1197 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1198 (x_after_update_window_line, x_scroll_bar_create):
1199 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1200 (handle_one_xevent, x_clear_frame_area):
1201 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1202 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1203 * xterm.h (x_clear_area): Adjust prototype.
1204
d2b36813
DA
12052013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Hook scanning and indentation functions to find_newline. This helps
1208 to avoid duplicated code and renders more respect to newline cache.
1209 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1210 * cmds.c (Fforward_line):
1211 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1212 Use find_newline and avoid unnecessary point movements.
1213 * search.c (scan_newline): Implement on top of find_newline.
1214
3ec7babc
SM
12152013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1216
1217 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1218 scoped code (bug#11258).
1219
5ab473cd
JD
12202013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1221
1222 * nsterm.m (last_window): New variable.
1223 (EV_TRAILER2): New macro.
1224 (EV_TRAILER): Call EV_TRAILER2.
1225 (mouseMoved:): Add support for mouse-autoselect-window
1226 on nextstep (Bug#6888).
1227
78779650
AS
12282013-08-28 Andreas Schwab <schwab@suse.de>
1229
1230 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1231 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1232 Remove unused macro definitions.
1233 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1234 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1235 Only define if emacs.
78779650 1236
c3c4768d
DA
12372013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1238
1239 Prefer enum glyph_row_area to int where appropriate.
1240 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1241 Fix comment.
1242 (window_box, window_box_width, window_box_left, window_box_left_offset)
1243 (window_box_right, window_box_right_offset): Adjust prototypes.
1244 * xdisp.c (window_box, window_box_width, window_box_left)
1245 (window_box_left_offset, window_box_right, window_box_right_offset):
1246 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1247 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1248 * nsterm.m (ns_clip_to_row):
1249 * w32term.c (w32_clip_to_row):
1250 * xterm.c (x_clip_to_row): Likewise.
1251
6bdcbfe1
DA
12522013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1253
1254 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1255 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1256
50b13cde
PE
12572013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1260 for portability to hosts where /bin/sh has problems.
1261
f60e429a
DA
12622013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1263
1264 Redesign redisplay interface to drop global output_cursor.
1265 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1266 (toplevel): Remove declaration of output_cursor.
1267 (set_output_cursor, x_cursor_to): Remove prototype.
1268 * window.h (struct window): New member output_cursor.
1269 (output_cursor_to): New function to replace RIF member.
1270 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1271 (update_text_area, set_window_cursor_after_update): Use it.
1272 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1273 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1274 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1275 * w32term.c (x_update_window_begin, x_update_window_end):
1276 * xterm.c (x_update_window_begin, x_update_window_end):
1277 Adjust to use per-window output cursor.
1278
43aac990
PE
12792013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1280
d486344e
PE
1281 Simplify SELECT_TYPE-related code.
1282 Like EMACS_TIME, this portability layer is no longer needed, since
1283 Emacs has been using fd_set as a portability layer for some time.
1284 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1285 (SELECT_TYPE): Remove. All uses changed to fd_set.
1286 (fd_set) [!FD_SET]: New typedef.
1287
43aac990
PE
1288 Simplify EMACS_TIME-related code.
1289 This portability layer is no longer needed, since Emacs has been
1290 using struct timespec as a portability layer for some time.
1291 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1292 Include <time.h> rather than "systime.h"; that's all that's needed now.
1293 * dispnew.c: Include <timespec.h> rather than "systime.h";
1294 that's all that's needed now.
1295 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1296 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1297 TIMESPEC_RESOLUTION.
1298 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1299 LOG10_TIMESPEC_RESOLUTION.
1300 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1301 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1302 (make_emacs_time): Remove. All used changed to make_timespec.
1303 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1304 (current_timespec): Rename from current_emacs_time. All uses changed.
1305 (add_emacs_time): Remove. All uses changed to timespec_add.
1306 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1307 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1308 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1309 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1310 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1311 (current_timespec): Rename from current_emacs_time. All uses changed.
1312 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1313 changed to timespec_cmp.
1314 * xgselect.c: Include <timespec.h>, since our .h files don't.
1315
d350e350
DA
13162013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1317
1318 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1319 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1320 Remove the leftovers.
1321 * gtkutil.c (toplevel): Do not declare Qxft but include
1322 font.h to do so.
1323 * image.c (toplevel): Do not declare Vlibrary_cache because
1324 it's already done in lisp.h.
1325
9fed9729
DA
13262013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1327
1328 * lisp.h (Mouse_HLInfo): Move from here...
1329 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1330 (reset_mouse_highlight): New function.
1331 * msdos.c (dos_set_window_size, IT_update_begin)
1332 (internal_terminal_init):
1333 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1334 (ns_initialize_display_info):
1335 * w32console.c (initialize_w32_display):
1336 * w32term.c (x_update_window_end, x_free_frame_resources)
1337 (w32_initialize_display_info):
1338 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1339 * window.c (Fdelete_other_windows_internal):
1340 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1341 * termchar.h (toplevel):
1342 * xterm.h (toplevel): Include dispextern.h.
1343
f462f075
PE
13442013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 Fix minor problems found by static checking.
1347 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1348 (expect): Avoid nested-if warning.
1349 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1350 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1351 * nsterm.h, nsterm.m (ns_select):
1352 * xgselect.c, xgselect.h (xg_select):
1353 Adjust signature to better match pselect's.
1354 * nsterm.m (ns_select):
1355 Don't set *TIMEOUT, since pselect doesn't.
1356 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1357 diagnostic about assigning const char * to it.
1358 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1359
068f9124
SM
13602013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1361
1362 * lread.c (substitute_object_recurse): Handle hash-tables as well
1363 (bug#15190).
1364
f5adc984
PE
13652013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1366
1fc8eb33
PE
1367 Fix unlikely core dump in init_tty, and simplify terminfo case.
1368 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1369 The old version incorrectly dumped core if malloc returned a
1370 buffer containing only non-NUL bytes.
1371 (init_tty): Do not allocate or free termcap buffers; the
1372 struct does that for us now.
1373 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1374 (struct tty_display_info): Define members termcap_term_buffer and
1375 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1376 use them. Allocate them directly in struct rather than indirectly
1377 via a pointer, to simplify init_tty.
1378
f5adc984
PE
1379 * frame.c (check_minibuf_window): Initialize 'window' properly,
1380 so that Emacs reliably aborts later if 'window' is not initialized.
1381
efec3894
JD
13822013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1383
1384 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1385 of VoidSymbol (Bug#15154).
1386
e1d0341e
DA
13872013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1388
1389 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1390 mouse_face_beg_y and mouse_face_end_y.
1391 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1392 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1393 Adjust users and update comment where appropriate.
1394
bfff6445
MR
13952013-08-26 Martin Rudalics <rudalics@gmx.at>
1396
1397 * frame.c (check_minibuf_window): New function.
068f9124
SM
1398 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1399 Call check_minibuf_window (Bug#15183).
bfff6445 1400
c80016b3
DA
14012013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1402
1403 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1404 because this is the only last cursor data we need to keep and consult.
1405 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1406 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1407 Adjust users.
1408
de396731
DA
14092013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1410
068f9124
SM
1411 Fix recovering from possible decompression error.
1412 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1413 the position where the partially decompressed data ends, and
447218dd 1414 should count how many bytes was produced so far.
de396731
DA
1415 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1416 (unwind_decompress): Really delete partially uncompressed data.
1417 (Fzlib_decompress_region): Take decompressed data size into account.
1418
c76826d9
DA
14192013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1420
1421 * syntax.c (init_syntax_once): Adjust comment and do an early
1422 initialization of Qchar_table_extra_slots just once...
1423 * casetab.c (init_casetab_once):
1424 * category.c (init_category_once):
1425 * character.c (syms_of_character):
1426 * coding.c (syms_of_coding):
1427 * xdisp.c (syms_of_xdisp): ...and omit it here.
1428
b34454d0
EZ
14292013-08-24 Eli Zaretskii <eliz@gnu.org>
1430
11f20add
EZ
1431 * xdisp.c (get_next_display_element): Don't apply to characters
1432 from a display vector the logic of setting it->end_of_box_run_p
1433 suitable for characters from a buffer. (Bug#15175)
1434
b34454d0
EZ
1435 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1436 to handle directories, rather than '_utime' which doesn't.
1437 (Bug#15176)
1438
6e1b469e
JD
14392013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1440
1441 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1442 or fullscreen (Bug#14627).
1443
9c05bccf
PE
14442013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1445
1446 System-dependent integer overflow fixes.
1447 * process.c (Fset_process_window_size): Signal an error if
1448 the window size is outside the range supported by the lower level.
1449 * sysdep.c (set_window_size): Return negative on error,
1450 nonnegative on success, rather than -1, 0, 1 on not in system,
1451 failure, success. This is simpler. Caller changed.
1452 (serial_configure): Remove unnecessary initialization of local.
1453 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1454 size fits in unsigned long; this isn't true on some 32-bit hosts.
1455 Avoid buffer overrun if some future version of /proc/meminfo has a
1456 variable name longer than 20 bytes.
1457 (system_process_attributes) [__FreeBSD__]:
1458 Don't assume hw.availpages fits in 'int'.
1459
c365c355
PE
14602013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 Don't let very long directory names overrun the stack.
1463 Fix some related minor problems involving "//", vfork.
1464 * callproc.c (encode_current_directory): New function.
1465 (call_process): Don't append "/"; not needed.
1466 * fileio.c (file_name_as_directory_slop): New constant.
1467 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1468 this can save the caller having to alloca.
1469 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1470 Use SAFE_ALLOCA, not alloca.
1471 (directory_file_name, Fexpand_file_name): Leave leading "//"
1472 alone, since it can be special even on POSIX platforms.
1473 * callproc.c (call_process):
1474 * process.c (Fformat_network_address):
1475 * sysdep.c (sys_subshell):
1476 Use encode_current_directory rather than rolling our own.
1477 (create_process): No need to encode directory; caller does that now.
1478 * process.h (encode_current_directory): New decl.
1479 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1480 Rework to avoid 'goto xyzzy;'.
1481
6c6014d4
EZ
14822013-08-23 Eli Zaretskii <eliz@gnu.org>
1483
1484 * xdisp.c (handle_face_prop): If the default face was remapped use
1485 the remapped face for strings from prefix properties. (Bug#15155)
1486
9997ec56
DA
14872013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1488
1489 Minor cleanup for redisplay interface and few related functions.
1490 * frame.h (enum text_cursor_kinds): Move from here...
1491 * dispextern.h (enum text_cursor_kinds): ...to here.
1492 (toplevel): Drop unnecessary declarations.
1493 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1494 in update_window_end_hook and draw_window_cursor functions.
1495 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1496 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1497 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1498 * xterm.c (x_update_window_end, x_draw_window_cursor):
1499 * xdisp.c (display_and_set_cursor, update_window_cursor)
1500 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1501 enum text_cursor_kinds where appropriate.
1502
7f780da6
DA
15032013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1504
1505 Redesign redisplay interface to drop updated_row and updated_area.
1506 * dispextern.h (updated_row, updated_area): Remove declaration.
1507 (struct redisplay_interface): Pass glyph row and row area parameters
1508 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1509 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1510 Adjust prototypes.
1511 * dispnew.c (updated_row, updated_area): Remove.
1512 (redraw_overlapped_rows, update_window_line): Adjust user.
1513 (update_marginal_area, update_text_area): Likewise. Pass updated row
1514 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1515 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1516 Adjust users.
1517
26495794
PE
15182013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 * process.c (flush_pending_output): Remove stub.
1521 All uses removed.
1522
4a88129a
PE
15232013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 * callproc.c: Fix race that killed background processes (Bug#15144).
1526 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1527 Record deleted process-id in critical section, not afterwards.
1528 Don't mistakenly kill process created by a call-process invocation
1529 that discards output and does not wait.
1530
0c5307b0
DA
15312013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1532
1533 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1534 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1535 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1536 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1537 to shut up compiler in mark_object.
1538 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1539
0d7c1e66
PE
15402013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1541
1542 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1543 We can't portably rely on PTY_OPEN doing that, even if
1544 it calls posix_openpt with O_CLOEXEC.
1545
3f246b65
KH
15462013-08-20 Kenichi Handa <handa@gnu.org>
1547
1548 * character.c (string_char): Improve commentary.
1549
8c2f38aa
PE
15502013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1551
1552 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1553 (struct animation_cache): Make signature a flexible array member.
1554 All uses changed. This is a tad slower but may insulate us better
1555 from future changes to ImageMagick.
1556
bb566cea
PE
15572013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * image.c: Shrink memory needed for animation cache.
1560 (SIGNATURE_DIGESTSIZE): New constant.
1561 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1562 (imagemagick_create_cache): Copy the signature. This saves
1563 several KB of memory that ImageMagick wastes per signature.
1564 Don't bother updating the update_time, as the caller does that now.
1565 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1566 it's a fixed size struct member now.
1567 (imagemagick_get_animation_cache): Always destroy the signature,
1568 as it's now imagemagick_create_cache's responsibility to copy it.
1569 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1570 and use memcmp rather than strcmp.
1571 eassert that ImageMagick returns a signature of the specified length.
1572
6da26928
LMI
15732013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1574
1575 * image.c (imagemagick_get_animation_cache): Don't segfault on
1576 each invocation.
453f4022
LMI
1577 (imagemagick_get_animation_cache): Revert to previous definition
1578 so that it actually works. But keep the memory leak fix.
1579 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1580
22490125
PE
15812013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1582
d0139df5
PE
1583 * image.c: Fix animation cache signature memory leak.
1584 Fix some other minor performance problems while we're at it.
1585 (imagemagick_create_cache): Clear just the members that
1586 need clearing. Don't set update_time, as caller does that now.
1587 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1588 Simplify by using pointer-to-pointer instead of a prev pointer.
1589 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1590 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1591 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1592 it's already a copy. Free the signature probe unless it's cached.
1593
22490125
PE
1594 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1595 This was introduced by my 2013-08-12 fix for Bug#15035.
1596
deb31e75
DA
15972013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1598
1599 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1600 (imagemagick_prune_animation_cache): Now static.
1601
319a4d03
LMI
16022013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1603
1604 * image.c (imagemagick_get_animation_cache): Don't segfault when
1605 pruning all entries.
1606
f747d82e
KB
16072013-08-18 Ken Brown <kbrown@cornell.edu>
1608
1609 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1610 static heap if ENABLE_CHECKING is defined.
1611 (max_bss_sbrk_ptr): New variable.
1612 (bss_sbrk): Use it.
1613 (report_sheap_usage): Report maximum static heap usage instead of
1614 ending static heap usage.
1615
d2c28fab
EZ
16162013-08-17 Eli Zaretskii <eliz@gnu.org>
1617
1618 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1619 of zlib_initialized according to the results of calling
1620 init_zlib_functions.
1621
274ff63f
LMI
16222013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1623
1624 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1625 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1626 (imagemagick_load_image): Remove the ping_wand code, which only
1627 apparently saved time on invalid animated images, and slowed down
1628 everything else. Optimise for the common case.
274ff63f 1629
2bede2ed
XF
16302013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1631
70ff8240
XF
1632 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1633
de179a3e
XF
1634 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1635
2bede2ed
XF
1636 * marker.c (set_marker): Remove documentation of undefined behavior.
1637
703dbeba
LMI
16382013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1639
1640 * image.c (imagemagick_compute_animated_image): Animate correctly
1641 when sub-images are smaller than the main image.
1d18b1e6
LMI
1642 (imagemagick_compute_animated_image): Setting the iterator row to
1643 zero is apparently not allowed.
79670014
LMI
1644 (imagemagick_compute_animated_image): Allow images that say they
1645 have sub-images that are bigger than the main image, but just crop
1646 them.
703dbeba 1647
63216c5e
JD
16482013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1649
1650 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1651
a5b5f73f
LMI
16522013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1653
1654 * image.c (imagemagick_compute_animated_image): Respect the GIF
1655 disposal methods.
1656
0fe73012
KB
16572013-08-15 Ken Brown <kbrown@cornell.edu>
1658
1659 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1660 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1661 needed.
1662
691a357f
PE
16632013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1664
1665 Fix minor problems found by static checking.
1666 * frame.c (delete_frame):
1667 * xdisp.c (next_element_from_display_vector):
1668 Avoid uninitialized local.
1669 * image.c (imagemagick_compute_animated_image): Port to C89.
1670 Prefer usual GNU indentation style for loops.
1671 Be more careful about bizarrely large sizes, by using ptrdiff_t
1672 instead of int.
1673
42fe2e88
DA
16742013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1675
1676 Fix infinite frame selection loop (Bug#15025).
1677 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1678
d39a3da6
EZ
16792013-08-15 Eli Zaretskii <eliz@gnu.org>
1680
068f9124
SM
1681 * xdisp.c (compute_window_start_on_continuation_line):
1682 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1683 to make sure we end up setting the window start at the leftmost
1684 visible character of the display line. This avoids funky
1685 horizontal shifting because the window start is not kept on the
1686 same position. (Bug#15090)
05426239
EZ
1687 (next_element_from_display_vector): Support 'box' face attribute
1688 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1689
6e856b69
LMI
16902013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1691
1692 * image.c (imagemagick_compute_animated_image): Implement animated
1693 images (bug#14700).
995be755
LMI
1694 (imagemagick_compute_animated_image): Fix some compilation
1695 warnings. Implement a very simple cache to make the animation
1696 usable at all, but it should be replaced with a per-image cache.
6e856b69 1697
d5a1acfa
DA
16982013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1699
1700 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1701 to do `for' loops over alist values.
1702 * buffer.h (FOR_EACH_BUFFER):
1703 * process.c (FOR_EACH_PROCESS): Use it.
1704 (handle_child_signal, status_notify, Fget_buffer_process)
1705 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1706
9c253307
DA
17072013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1708
1709 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1710 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1711 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1712 to xzalloc and so avoid redundant call to memset.
1713 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1714 members because it is allocated with xzalloc and so already zeroed.
1715
05e64f9f
KB
17162013-08-14 Ken Brown <kbrown@cornell.edu>
1717
1718 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1719 (Bug#15094).
1720
5b71542d
DA
17212013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1722
1723 Utility function and macro to copy Lisp string to C string.
1724 * lisp.h (xlispstrdupa): New macro.
1725 (xlispstrdup): New prototype.
1726 * alloc.c (xlispstrdup): New function.
1727 * callint.c (Fcall_interactively):
1728 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1729 (Fsubstitute_in_file_name):
1730 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1731 * image.c (x_create_bitmap_from_file):
1732 * w32term.c (w32_term_init):
1733 * xterm.c (x_term_init): Use xlispstrdup.
1734
71530c97
LMI
17352013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1736
4ce82fb8
LMI
1737 * image.c (imagemagick_load_image): Make animated pictures work.
1738 There's still some problems with background color settings, though
1739 (bug#14700).
1740
71530c97
LMI
1741 * decompress.c (unwind_decompress): Always restore point.
1742
7510a061
XF
17432013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1744
1745 * marker.c (set_marker): Reformat documentation.
1746
01c3051f
PE
17472013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1748
aab1fcdf
PE
1749 * xdisp.c (cursor_type_changed): Now static.
1750
01c3051f
PE
1751 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1752 Use changed. This avoids the need to call xmalloc and for the
1753 caller to call xfree, and avoids memory leaks in some situations.
1754
2084152a
DA
17552013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1756
1757 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1758 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1759 (redisplay_window): If window_end_valid is cleared due to non-zero
1760 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1761 so do not call to try_cursor_movement for that window.
2084152a 1762
02455cb6
DA
17632013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1764
1765 * window.h (struct window): Convert window_end_pos and
1766 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1767 (wset_window_end_pos, wset_window_end_vpos): Remove.
1768 * dispnew.c (adjust_glyph_matrix):
1769 * window.c (Fwindow_end, replace_window, set_window_buffer)
1770 (make_window):
1771 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1772 (set_vertical_scroll_bar, redisplay_window, try_window)
1773 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1774 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1775 (note_mouse_highlight): Adjust users.
1776 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1777 Add comment.
1778
da5707e8
DA
17792013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1780
1781 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1782 * image.c (imagemagick_filename_hint): Use `const char *' and
1783 prefer SSDATA to SDATA to avoid warnings.
1784
25554267
DA
17852013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1786
1787 Cleanup window fringes, margins and scroll bars adjustments.
1788 * window.c (set_window_fringes, set_window_margins)
1789 (set_window_scroll_bars, apply_window_adjustment): New functions.
1790 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1791 (Fset_window_scroll_bars): Use them.
1792
38a2c910
DA
17932013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1794
1795 * window.h (struct window): Convert scroll_bar_width
1796 from Lisp_Object to integer. Adjust comment.
1797 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1798 Adjust users.
1799 * window.c (wset_scroll_bar_width): Remove.
1800 (make_window): Initialize scroll_bar_width.
1801 (Fsplit_window_internal): Use direct assignment.
1802 (Fset_window_configuration, save_window_save):
1803 Convert Lisp_Object to integer and back where appropriate.
1804 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1805 bar was actually changed, and mention this in docstring.
1806
2d065031
PE
18072013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 * decompress.c: Minor simplifications.
1810 (Fzlib_decompress_region): Don't bother verifying
1811 that avail_out <= UINT_MAX, as that was confusing.
1812 Mention the restriction in a comment instead.
1813 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1814
a5bd5abb
JD
18152013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1816
1817 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1818 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1819
66e7901a
LMI
18202013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1821
1822 * image.c (imagemagick_filename_hint): Check for errors in the
1823 alist structure.
1824
2fa611b7
EZ
18252013-08-13 Eli Zaretskii <eliz@gnu.org>
1826
1827 * window.c (Fwindow_margins): Return nil when there's no marginal
1828 area, as per the documented API.
1829
1830 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1831 Fmake_vector, as scroll bar's struct members are not all Lisp
1832 objects now. This avoids crashes in GC.
1833
1834 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1835 bool, so its address could be taken.
1836
8259030d
LMI
18372013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1838
1839 * image.c (imagemagick_filename_hint): New function to possibly
1840 apply `image-content-type-suffixes'.
1841 (imagemagick_load_image): Use it.
1842
866c710e
EZ
18432013-08-13 Eli Zaretskii <eliz@gnu.org>
1844
1845 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1846 if loading zlib failed.
1847
f10490f0
JD
18482013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1849
96311be7
JD
1850 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1851 2013-08-13 checkin below. Change bool to BOOL, rule is:
1852 All Obj-C code uses BOOL, except for interfaces callable from C.
1853
f10490f0
JD
1854 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1855
c8ae93b0
DA
18562013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1857
1858 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1859 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1860 bool instead of BOOL.
1861 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1862 from Lisp_Object to bitfield. Adjust comment.
1863 * w32term.c (x_scroll_bar_create): Adjust user.
1864 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1865 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1866 Use bool for boolean.
1867 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1868 to `unsigned int' when defining a bitfield.
1869
53b64418
PE
18702013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1873
eeaf9bf3
DA
18742013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1875
1876 * window.h (struct window): Convert left_margin_cols and
1877 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1878 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1879 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1880 Adjust users.
1881 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1882 Adjust comment.
1883 (showing_window_margins_p, update_window_line, update_frame_1):
1884 * fringe.c (draw_fringe_bitmap_1):
1885 * xdisp.c (window_box_width): Adjust users.
1886 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1887 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1888 Use direct assignment.
1889 (Fset_window_configuration, save_window_save, Fwindow_margins):
1890 Convert Lisp_Object to integer and back where appropriate.
1891 (Fset_window_margins): Adjust user. Return t if any margin
1892 was actually changed, and mention this in docstring.
1893
956720af
XF
18942013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1895
f73f4ce6 1896 * syntax.c (forward_word):
956720af
XF
1897 * cmds.c (forward_char, backward_char): Mention the optional argument.
1898
9e37ee3b
DA
18992013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1900
1901 * window.h (struct window): Convert left_fringe_width
1902 and right_fringe_width from Lisp_Objects to integers.
1903 Adjust comment.
1904 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1905 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1906 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1907 Remove.
1908 (make_window): Initialize new integer fields to -1.
1909 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1910 (Fset_window_configuration, save_window_save):
1911 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1912 (Fset_window_fringes): Adjust user. Return t if any fringe
1913 was actually changed, and mention this in docstring.
1914
e4375ca7
DA
19152013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1916
1917 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1918 * nsfns.m (x_set_cursor_type):
1919 * w32fns.c (x_set_cursor_type):
1920 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1921 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1922
a45543bc
DA
19232013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1924
1925 * font.c (clear_font_cache): New function, stripped from...
1926 (Fclear_font_cache): ...here, which now uses the function
1927 above. Adjust comment.
1928 * font.h (clear_font_cache): Add prototype.
1929 * xfaces.c (clear_face_cache): Use clear_font_cache.
1930
ae966a86
DA
19312013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1932
1933 * window.c (Fset_window_start): Compare `w', not `window' because
1934 `w' might not be equal to `window' after call to decode_live_window.
1935
297a545b
PE
19362013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1939 This fixes a problem introduced by the Bug#15035 patch
1940 when using GPG. Reported by Herbert J. Skuhra.
1941
aa942e2b
EZ
19422013-08-12 Eli Zaretskii <eliz@gnu.org>
1943
1944 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1945 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1946 not yet initialized.
1947
7699d09e
LMI
19482013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1949
1950 * decompress.c (Fzlib_decompress_region): Support zlib
1951 decompression, too, and rename.
1952
1d238bc7
PE
19532013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1954
1955 Minor zlib configuration tweaks.
1956 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1957 Don't assume presence of fn_inflateInit2_ zlib internal function.
1958
8a44a184
LMI
19592013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1960
1961 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1962 include the zlib prefix.
1963
594a4307
EZ
19642013-08-12 Eli Zaretskii <eliz@gnu.org>
1965
1966 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1967 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1968 define static variables that are pointers to zlib functions to be
1969 dynamically loaded.
1970 (init_zlib_functions) [WINDOWSNT]: New function.
1971 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1972 New macros.
1973 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1974 macros instead of invoking the zlib functions directly.
068f9124
SM
1975 (syms_of_decompress): DEFSYM Qzlib_dll.
1976 Staticpro Szlib_available_p.
594a4307 1977
d2e113bc
DA
19782013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1979
1980 Avoid looping over all frame windows to freeze and unfreeze.
1981 * window.h (struct window): Drop frozen_window_start_p.
1982 (freeze_window_starts): Drop prototype.
1983 * frame.h (struct frame): New frozen_window_starts flag.
1984 (FRAME_WINDOWS_FROZEN): New macro.
1985 * window.c (freeze_window_start, freeze_window_starts):
1986 Remove.
1987 (select_window, replace_window): Adjust users.
1988 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1989 (window_frozen_p): New function.
1990 (redisplay_window): Use it.
1991
94fcd171
PE
19922013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 Fix some fd issues when running subprocesses (Bug#15035).
1995 Fix bugs that can leak files or file descriptors on errors.
1996 Don't unlink open temp files, as that's hard for users to diagnose
1997 when things go awry (e.g., temp disk exhausted).
1998 Don't bother to lock temp files. Check for invalid recursion.
1999 * callproc.c (synch_process_fd): Remove. All uses removed.
2000 (synch_process_tempfile): New var or macro.
2001 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
2002 New constants.
2003 (record_kill_process): New arg, the temp name. All callers changed.
2004 (delete_temp_file): Now just a simple wrapper around unlink.
2005 (call_process_kill): New arg, the call_process_fd array.
2006 Close them all. Clear synch_process_pid. Remove the temp file,
2007 or arrange for it to be removed.
2008 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
2009 that's been moved to synch_process_tempfile. Caller changed.
2010 Do not remove the tempfile; that's now call_process_kill's
2011 responsibility.
2012 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
2013 call_process_kill; the caller now does that.
2014 (call_process_cleanup): Do not close the process fd; that's now
2015 call_process_kill's responsibility.
2016 (Fcall_process): Implement via new function call_process, which
2017 has most of the old body of Fcall_process, but with a different API.
2018 (call_process): New function that does not open or close filefd if
2019 it is nonnegative. Record which fds need to be closed, and let
2020 call_process_kill close (and remove the tempfile, on MSDOS) on error.
2021 Signal an error if invoked recursively (could be done via a hook).
2022 Simplify creation of the tempfile in the MSDOS case.
2023 Don't create the output file until after checking for the executable.
2024 Report any failure to open /dev/null.
2025 Don't open /dev/null for writing twice; once is enough.
2026 Don't create pipe if all output is being discarded or sent to file.
2027 Don't worry about setting up the coding system or reading from the
2028 pipe if all output is being discarded.
2029 Hoist fd_error local into top level, to lessen block nesting.
2030 Don't record deleted pid here; now done by Fcall_process_region.
2031 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
2032 and note its success in synch_process_tempfile.
2033 Do not leak resources when child_setup fails.
2034 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
2035 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
2036 (create_temp_file): Now returns open fd, with an additional
2037 Lisp_Object * argument to return the name. All callers changed.
2038 Do not close the file; rewind it instead, and leave it open for
2039 the caller. Do not lock the temp file. Unwind-protect the file
2040 and the file-descriptor.
2041 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
2042 If an asynchrounous process, record it here, not in call_process.
2043 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
2044 * eval.c (set_unwind_protect): New function.
2045 * fileio.c (write_region): New function, generalized from the
2046 old Fwrite_region. Do not lock temp files.
2047 (Fwrite_region): Use it.
2048 * lisp.h (set_unwind_protect, write_region): New decls.
2049 * process.c: Include <verify.h>.
2050 (make_process): Mark fds as initially closed.
2051 (deleted_pid_list): Now a list of pid-filename pairs.
2052 All uses changed.
2053 (close_process_fd): New function.
2054 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
2055 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
2056 New constants. Verify that their number matches PROCESS_OPEN_FDS.
2057 (create_process, create_pty, Fmake_serial_process)
2058 (server_accept_connection): Record which fds need to be closed,
2059 and let deactivate_process close them.
2060 (Fmake_network_process): Do not discard the unwind-protect
2061 until it's safe to do so.
2062 (deactivate_process): Close the fds opened by create_process etc.
2063 (Fprocess_send_eof): Adjust to new way of recording open fds.
2064 Report an error if /dev/null can't be opened, instead of aborting.
2065 * process.h (PROCESS_OPEN_FDS): New constant.
2066 (struct Lisp_Process): New member open_fds.
2067 (record_kill_process, record_deleted_pid): Adjust signatures.
2068 (record_deleted_pid): Move decl here ...
2069 * syswait.h (record_deleted_pid): ... from here.
2070
d0e615c3
PE
20712013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 * decompress.c: Fix bugs with large buffers and weird inputs.
2074 Tune a bit. Reindent as per usual Emacs style.
2075 (BUFFER_SIZE): Remove.
2076 (Fdecompress_gzipped_region): Do not mishandle input buffers with
2077 more than UINT_MAX bytes. Decompress into the gap instead of into
2078 an auto buffer, as this should avoid copying. Return nil if
2079 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
2080 set immediate_quit; we shouldn't trust zlib code that much.
2081
313546eb
LMI
20822013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2083
99a32242
LMI
2084 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
2085 errors, and really move the gap to where we want it.
2086
313546eb
LMI
2087 * lisp.h: Include decompress.c support.
2088
2089 * emacs.c (main): Include decompress.c support.
2090
2091 * Makefile.in: Include -lz if present.
2092
d2d699ac
JD
20932013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2094
f90e3ebd
JD
2095 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
2096 (initWithTitle:): Initialize frame to 0.
2097 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 2098 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
2099 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
2100
2101 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
2102 fillWithWidgetValue:frame:
2103
423d3b3f
JD
2104 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
2105 remove memory leak warnings.
2106
d2d699ac
JD
2107 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
2108 (ns_check_menu_open): Handle menu == nil. Remove assignment to
2109 menu_pending_title.
2110
2111 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
2112 (x_activate_menubar): Update the whole menu.
2113 (trackingNotification:): Call ns_check_menu_open if tracking ends.
2114 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
2115 current event is not NSSystemDefined (Bug#15001).
2116 Call ns_check_menu_open only if trackingMenu is 2.
2117 (menuDidClose:): New method, decrease trackingMenu.
2118 (fillWithWidgetValue:setDelegate:): New method.
2119 (fillWithWidgetValue:): Call the above.
2120
2121 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2122
7d652d97
PE
21232013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 Omit some unnecessary casts.
2126 Many of these go back to the old pre-C89 days, when they may have
2127 been needed, but we've been assuming C89 or later for a while now.
2128 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2129 (live_float_p, live_misc_p, live_vector_p):
2130 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2131 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2132 (defvar_per_buffer):
2133 * callint.c (Fcall_interactively):
2134 * doc.c (Fsubstitute_command_keys):
2135 * filelock.c (get_boot_time):
2136 * frame.c (xrdb_get_resource):
2137 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2138 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2139 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2140 (menuitem_highlight_callback, menu_destroy_callback)
2141 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2142 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2143 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2144 (xg_tool_bar_help_callback, tb_size_cb):
2145 * image.c (xpm_alloc_color, png_read_from_memory)
2146 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2147 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2148 (syms_of_image):
2149 * keymap.c (describe_map):
2150 * nsfns.m (Fns_display_monitor_attributes_list):
2151 * nsmenu.m (process_dialog:):
2152 * nsterm.m (hold_event):
2153 * process.c (wait_reading_process_output):
2154 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2155 * scroll.c (do_direct_scrolling, scrolling_1):
2156 * termcap.c (tgetent):
2157 * window.c (check_window_containing, add_window_to_list)
2158 (freeze_window_starts):
2159 * xdisp.c (compare_overlay_entries, vmessage):
2160 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2161 (x_get_monitor_attributes_xrandr)
2162 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2163 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2164 * xfont.c (xfont_match, xfont_open):
2165 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2166 (menubar_selection_callback, menu_position_func)
2167 (popup_selection_callback, create_and_show_popup_menu)
2168 (dialog_selection_callback, create_and_show_dialog):
2169 * xrdb.c (x_get_string_resource):
2170 (main) [TESTRM]:
2171 * xsmfns.c (x_session_check_input):
2172 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2173 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2174 (xaw_jump_callback, xaw_scroll_callback):
2175 Omit unnecessary casts.
2176
9acc1074
PE
21772013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 Minor string-length refactoring.
2180 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2181 * frame.c (make_monitor_attribute_list):
2182 Prefer build_string to strlen + make_string.
2183
361c0eb8
JD
21842013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2185
2186 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2187 don't check minor_code (Bug#14417).
2188
14ba0822
EZ
21892013-08-09 Eli Zaretskii <eliz@gnu.org>
2190
2191 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2192 vertical positions instead. This avoids calling MATRIX_ROW with
2193 row numbers that are possibly beyond valid limits. (Bug#15064)
2194
309f24d1
DA
21952013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2196
2197 Use xstrdup and build_unibyte_string where applicable.
2198 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2199 * xfns.c (x_window):
2200 * xrdb.c (x_get_customization_string):
2201 * xterm.c (xim_initialize):
2202 * w32fns.c (w32_window): Use xstrdup.
2203 (w32_display_monitor_attributes_list):
2204 * emacs.c (init_cmdargs):
2205 * keyboard.c (PUSH_C_STR):
2206 * nsfont.m (nsfont_open):
2207 * sysdep.c (system_process_attributes):
2208 * w32.c (system_process_attributes):
2209 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2210
55902276
EZ
22112013-08-09 Eli Zaretskii <eliz@gnu.org>
2212
2213 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2214 variables of these types so that GDB would know about them, as aid
2215 for debugging fatal exceptions. (Bug#15024) See also
2216 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2217 discussions.
2218
10bf7f5a
JD
22192013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2220
2221 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2222 larger than the NSWindow (Bug#14934).
2223
65620264
DA
22242013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2225
2226 Redesign redisplay interface to drop global variable updated_window.
2227 Always pass currently updated window as a parameter to update routines.
2228 * dispextern.h (updated_window): Remove declaration.
2229 (struct redisplay_interface): Pass window parameter to
2230 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2231 and after_update_window_hook.
2232 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2233 Adjust prototypes.
2234 * dispnew.c (updated_window): Remove.
2235 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2236 (update_window_line): Adjust to match redisplay interface changes.
2237 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2238 (ns_scroll_run, ns_after_update_window_line):
2239 * w32term.c (x_update_window_begin, x_update_window_end)
2240 (x_after_update_window_line, x_scroll_run):
2241 * xterm.c (x_update_window_begin, x_update_window_end)
2242 (x_after_update_window_line, x_scroll_run):
2243 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2244 Likewise. Adjust comments where appropriate.
2245 (x_cursor_to): Simplify because this is always called during window
2246 update (but install debugging check anyway).
2247 (expose_window): Check must_be_updated_p flag to see whether this
2248 function is called during window update.
2249
628fdc56
DA
22502013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2251
2252 Do not reset window modification event counters excessively.
2253 These leftovers and poor man's tricky methods to catch extra
2254 redisplay's attention are no longer needed.
2255 * frame.c (set_menu_bar_lines_1):
2256 * minibuf.c (read_minibuf_unwind):
2257 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2258 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2259 (window_scroll_line_based, Fset_window_configuration):
2260 * xdisp.c (redisplay_window): Do not reset last_modified and
2261 last_overlay_modified counters.
2262
8fd9c92e
JD
22632013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2264
2265 * xselect.c (x_send_client_event): Set send_event and serial, memset
2266 data.l as it might be bigger than data.b. Use 24 bit mask to
2267 XSendEvent (Bug#15034).
2268
0ee18172
EZ
22692013-08-07 Eli Zaretskii <eliz@gnu.org>
2270
2271 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2272 for TTY frames that are not the top frame on their console.
2273 (Bug#14616)
2274
16ddd1a6
MR
22752013-08-07 Martin Rudalics <rudalics@gmx.at>
2276
2277 * w32term.c (w32fullscreen_hook): Really maximize frame when
2278 asked for (Bug#14841).
2279
d2a95ffb
DA
22802013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2281
2282 Prefer selected_window to Fselected_window, likewise for frames.
2283 * buffer.c (Fbuffer_swap_text):
2284 * data.c (Fvariable_binding_locus):
2285 * window.c (run_window_configuration_change_hook): Adjust users.
2286 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2287 Use decode_live_frame.
2288
170da1ec
DA
22892013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2290
2291 Be more careful if selected window shows the buffer other than current,
2292 use window_outdated only if this is not so. This change should also
2293 address some weird issues discussed in Bug#13012.
2294 * window.h (window_outdated): New prototype.
2295 * window.c (window_outdated): Now here. Convert from static and
2296 always assume window's buffer.
2297 (Fwindow_end, Fwindow_line_height): Use it.
2298 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2299 and always assume window's buffer.
2300 (redisplay_window): Adjust user.
e5eefe9b 2301 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2302 check whether mode line should be updated only if selected window
2303 shows current buffer.
2304 (run_window_scroll_functions): Use eassert for debugging check.
2305 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2306
56b5d5b1
DA
23072013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2308
2309 * window.c (window_scroll, window_scroll_pixel_based)
2310 (window_scroll_line_based): Use bool for booleans.
2311
2878ba7e
PE
23122013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2313
2314 * process.c: Fix minor off-by-one issues in descriptor counts.
2315 This shouldn't fix any real bugs, but it cleans up the code a bit.
2316 (max_process_desc, max_input_desc): -1, not 0, means none.
2317 All uses changed.
2318 (delete_input_desc): New function.
2319 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2320 (deactivate_process): Scan backwards when recomuting max_process_desc;
2321 that should be faster.
2322 (init_process_emacs): Initialize max_input_desc.
2323
e30b79c1
DA
23242013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2325
2326 Use region cache to speedup bidi_find_paragraph_start.
2327 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2328 Rename cache_long_line_scans to cache_long_scans.
2329 * buffer.c (bset_cache_long_line_scans): Rename to
2330 bset_cache_long_scans.
2331 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2332 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2333 into account.
2334 (syms_of_buffer): Rename cache-long-line-scans to
2335 cache-long-scans. Adjust docstring.
2336 * search.c (newline_cache_on_off):
2337 * indent.c (width_run_cache_on_off): Adjust users.
2338 * bidi.c (bidi_paragraph_cache_on_off): New function.
2339 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2340 * insdel.c (prepare_to_modify_buffer):
2341 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2342
00012b86
DA
23432013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2344
2345 Invalidate region caches only if buffer text is going to be changed.
2346 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2347 (modify_text): ...new prototype.
2348 (prepare_to_modify_buffer_1): New prototype.
2349 * textprop.c (modify_region): Rename to...
2350 (modify_text_properties): ...new function.
2351 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2352 (Fremove_list_of_text_properties): Adjust users.
2353 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2354 (modify_text): ...new function.
2355 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2356 (prepare_to_modify_buffer_1): ...new function.
2357 * casefiddle.c (casify_region):
2358 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2359 (Ftranspose_regions): Use modify_text.
2360
dc6c0eda
SM
23612013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2362
2363 * lisp.mk (lisp): Add nadvice.elc.
2364
8f3a2c26
DA
23652013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2366
2367 New macro to iterate over live buffers similar to frames.
2368 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2369 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2370 Declare buffer-related variables here to offload lisp.h.
2371 * buffer.c (Vbuffer_alist): Adjust comment.
2372 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2373 (other_buffer_safely):
2374 * data.c (store_symval_forwarding):
2375 * dispnew.c (Fframe_or_buffer_changed_p):
2376 * fileio.c (Fdo_auto_save):
2377 * filelock.c (unlock_all_files):
2378 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2379
e0fdb694
PE
23802013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2383 * callproc.c (create_temp_file):
2384 * filelock.c (create_lock_file):
2385 Assume mkostemp, since it's now provided by Gnulib.
2386
63f5c6c2
EZ
23872013-08-04 Eli Zaretskii <eliz@gnu.org>
2388
2389 * w32.c (mkostemp): New function.
2390 (mktemp): Remove, no longer used. Most of the code reused in
2391 mkostemp. (Bug#15015)
484ab239 2392 (mktemp): Don't undef.
63f5c6c2 2393
f0b79313
DA
23942013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2395
2396 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2397 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2398 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2399 (free_glyph_pool, check_glyph_memory): Likewise for
2400 all users. Adjust comments where appropriate.
2401
98f638d6
PE
24022013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * composite.h: Minor fixups.
2405 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2406 to fix a misspelling, and change it to an inline function while
2407 we're at it (it need not be a macro). All uses changed.
2408 (composition_method, composition_valid_p):
2409 Rewrite to avoid assignments in if-conditions.
2410
75c59fb3
DA
24112013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2412
2413 Do not use global Lisp_Object in composition macros.
2414 * composite.h (composition_temp): Remove declaration.
2415 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2416 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2417 (compose_region): Remove the leftover.
75c59fb3
DA
2418 * composite.c (composition_temp): Remove.
2419 (run_composition_function, update_compositions)
2420 (composition_compute_stop_pos, composition_adjust_point)
2421 (Ffind_composition_internal):
2422 * coding.c (handle_composition_annotation):
2423 * xdisp.c (handle_composition_prop, check_point_in_composition):
2424 Related users changed.
2425
a10c8269
DA
24262013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2427
2428 Drop FRAME_PTR typedef.
2429 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2430 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2431 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2432 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2433 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2434 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2435 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2436 All related users changed.
2437
a104f656
SM
24382013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2439
2440 * eval.c (default_toplevel_binding): New function.
2441 (Fdefvar): Use it.
2442 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2443 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2444 (syms_of_eval): Export them.
2445 * data.c (Fdefault_value): Micro cleanup.
2446 * term.c (init_tty): Use "false".
2447
4b5c9326
DA
24482013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2449
2450 Fix X GC leak in GTK and raw (no toolkit) X ports.
2451 * xterm.c (x_free_frame_resources): If white and black relief
2452 GCs are allocated, always free them here.
2453 * xfns.c (x_make_gc): Omit redundant initialization.
2454 * widget.c (create_frame_gcs): Remove the leftover.
2455 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2456 in x_free_frame_resources.
2457
b19aa636
JD
24582013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2459
2460 * nsterm.m (windowWillResize:toSize:): Only change title if
2461 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2462 modifying it.
2463 (viewDidEndLiveResize): New method.
2464
2465 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2466 inside NS_IMPL_COCOA.
2467
af1f7e06
DA
24682013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2469
2470 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2471 Do not check whether undo is enabled because record_insert and
2472 record_delete does that themselves.
2473
65b02bb9
DA
24742013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2475
2476 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2477 member which is not really used any more.
2478 (FRAME_XIC_BASE_FONTNAME): Remove.
2479 * xfns.c (xic_free_fontset): Adjust user.
2480 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2481 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2482 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2483 (xdialog_show): Use eassert for debugging check.
7ee0f047 2484 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2485
6318cde0
PE
24862013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 * fileio.c, fns.c (merge): Move extern decl from here ...
2489 * lisp.h (merge): ... to here.
2490
6c1a09ba
DA
24912013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2492
2493 Fix last font-related change.
2494 * w32font.h (w32font_list_internal, w32font_match_internal):
2495 Fix prototype.
2496 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2497 (uniscribe_list_family): Adjust to match font API change.
2498 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2499 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2500
f8c20208
DA
25012013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2502
2503 * frame.h (FRAME_MOUSE_UPDATE):
2504 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2505 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2506
fdb396e2
DA
25072013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2508
2509 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2510 * font.h (struct font_driver): Change list, match, and list_family
2511 functions to accept struct frame * as first arg.
068f9124
SM
2512 * font.c (font_score, font_compare, font_sort_entities):
2513 Remove prototypes.
fdb396e2
DA
2514 (font_sort_entities, font_list_entities, font_select_entity):
2515 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2516 match font API change.
2517 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2518 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2519 * ftxfont.c (ftxfont_list, ftxfont_match):
2520 * xftfont.c (xftfont_list, xftfont_match):
2521 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2522 * w32font.c (w32font_list, w32font_match, w32font_list):
2523 (w32font_list_internal, w32_font_match_internal): Likewise.
2524 * xfaces.c (Fx_family_fonts): Adjust user.
2525
52b8a085
DA
25262013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2527
2528 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2529 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2530 only if HAVE_X_WINDOWS is in use.
2531 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2532 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2533 * w32term.c (x_wm_set_icon_position): Likewise.
2534 * w32fns.c (x_icon): Adjust user.
2535
c791c18e
DA
25362013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2537
2538 * xterm.c (last_mouse_press_frame): Remove the
2539 leftover which is not really used any more.
2540 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2541 (x_flush): Call XFlush once per each X display, not frame.
2542 This is better because this code always unconditionally skips
2543 non-X frames in Vframe_list and issues the only XFlush if we
2544 have more than one X frame on the same X display.
2f935d86
DA
2545 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2546 Use bool for booleans.
2547 (x_draw_glyph_string_background, cvt_string_to_pixel):
2548 (cvt_pixel_dtor): Drop unnecessary prototypes.
2549 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2550
f435830e
DA
25512013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2552
2553 Drop unnecessary functions that deals with frame pixel size.
2554 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2555 (x_pixel_height): Drop prototypes.
2556 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2557 (x_pixel_height): Drop implementations.
2558 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2559 which should be always valid for window frame.
2560 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2561 * w32menu.c (Fx_popup_dialog):
2562 * xmenu.c (Fx_popup_dialog): Likewise for both.
2563
84231434
DA
25642013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2565
2566 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2567 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2568 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2569 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2570 and mention nil frame in docstring.
84231434 2571
959067a1
DA
25722013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2573
2574 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2575 (x_figure_window_size): Likewise. Adjust to return long.
2576 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2577 (toplevel): Move Qterminal_live_p to...
2578 * terminal.c (toplevel): ...here, make it static, and...
2579 (syms_of_terminal): ...DEFSYM here.
2580 * frame.h (Qterminal_live_p): Remove declaration.
2581 (make_frame, x_figure_window_size): Adjust prototype.
2582 * nsfns.m (Fx_create_frame): Use long for window flags.
2583
f4b169ce
PE
25842013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2585
2586 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2587 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2588 Do not assume that emacs_close (INT_MAX) is a no-op.
2589
bee6a2c7
DA
25902013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2591
2592 * xfaces.c (make_face_cache): For struct face_cache, prefer
2593 xmalloc to xzalloc and so avoid redundant call to memset.
2594 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2595
d7e6881a
DA
25962013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2597
2598 * fringe.c (draw_window_fringes, update_window_fringes)
2599 (compute_fringe_widths):
2600 * w32term.c (x_draw_glyph_string):
2601 * window.c (candidate_window_p, Frecenter):
2602 * xfaces.c (realize_basic_faces, realize_default_face)
2603 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2604 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2605 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2606 * xmenu.c (Fx_menu_bar_open_internal):
2607 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2608 * xsettings.c (xft_settings_event):
2609 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2610 Use bool for booleans. Adjust style and comments where
2611 appropriate.
2612 * dispextern.h (draw_window_fringes, update_window_fringes)
2613 (compute_fringe_widths):
2614 * xterm.h (x_had_errors_p): Adjust prototype.
2615
ec3058af
DA
26162013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2617
2618 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2619 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2620
218e0637
DA
26212013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2622
2623 * fns.c (toplevel): Remove comment before Fsafe_length because
2624 it checks for QUIT.
2625
e560aba9
PE
26262013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2629
2e5ce5de
EZ
26302013-07-28 Eli Zaretskii <eliz@gnu.org>
2631
2632 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2633 frame which got the message is still alive, before dereferencing
2634 its pointer. (Bug#14970)
2635
2636 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2637 be a live window, before using it as such. (Bug#14970)
2638
e95da6d3
EZ
26392013-07-27 Eli Zaretskii <eliz@gnu.org>
2640
2641 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2642 w32_detect_focus_change instead of doing part of its job by hand.
2643 This fixes the problem whereby FOCUS_OUT events were not sent to
2644 the event queue.
2645
a8f93651
EZ
26462013-07-26 Eli Zaretskii <eliz@gnu.org>
2647
fec92060
EZ
2648 * process.c (Fprocess_list): Doc fix.
2649
a8f93651
EZ
2650 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2651 being re-exposed only if it didn't ask to become visible.
2652 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2653 was previously iconified. (Bug#14841)
2654 (x_iconify_frame): Mark the frame iconified.
2655
d5a7a9d9
PE
26562013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 Fix minor problems found by static checking.
2659 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2660 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2661
56ea7291
SM
26622013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2663
2664 * eval.c (set_specpdl_old_value): New function.
2665 (unbind_to): Minor simplification.
2666 (get_backtrace_frame): New function.
2667 (Fbacktrace_frame): Use it. Add `base' argument.
2668 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2669 (syms_of_eval): Export backtrace-eval.
2670 * xterm.c (x_focus_changed): Simplify.
2671
9d611ffe
PE
26722013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2675
999c74e3
EZ
26762013-07-24 Eli Zaretskii <eliz@gnu.org>
2677
2678 * xdisp.c (redisplay_window): Instead of moving point out of
2679 scroll margin, reject the force_start method, and try scrolling
2680 instead. (Bug#14780)
2681
198fa217
KB
26822013-07-24 Ken Brown <kbrown@cornell.edu>
2683
2684 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2685 (Bug#14944).
2686
53840e55
PE
26872013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 * eval.c (Fprogn): Do not check that BODY is a proper list.
2690 This undoes the previous change. The check slows down the
2691 interpreter, and is not needed to prevent a crash. See
2692 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2693
60967f56
GM
26942013-07-23 Glenn Morris <rgm@gnu.org>
2695
2696 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2697
9ca960e2
PE
26982013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2699
a29c3e6d
PE
2700 Port to GNU/Linux systems with tinfo but not ncurses.
2701 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2702 to decide whether ncurses is being used. Without this change,
2703 GCC complains about tgetent not being declared, on a system
2704 that has tinfo installed but ncurses not installed.
2705
f274311c
PE
2706 * eval.c (Fprogn): Check that BODY is a proper list.
2707
16b0520a
PE
2708 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2709 * data.c (Fsetq_default):
2710 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2711 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2712 (Fcondition_case):
2713 Tune by taking advantage of the fact that ARGS is always a list
2714 when a function is declared to have UNEVALLED args.
2715
9ca960e2
PE
2716 * emacsgtkfixed.c: Port to GCC 4.6.
2717 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2718
afacaa1b
JB
27192013-07-23 Juanma Barranquero <lekktu@gmail.com>
2720
2721 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2722 here to silence compiler warnings.
2723
368a85a4
PE
27242013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2727 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2728 from messing up Emacs's 'struct frame' (Bug#14923).
2729
f4e891b5
PE
27302013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2731
2732 * alloc.c (make_save_ptr_ptr): Define this function.
2733 It was inadvertently omitted. It's needed only if
2734 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2735
96c8b65e
JD
27362013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2737
2738 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2739 frame have focus (Bug#14895).
2740
ee010797
PE
27412013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 Avoid vfork-related deadlock more cleanly.
2744 * callproc.c (child_setup): When the child's exec fails, output
2745 the program name, as that's more useful. Use O_NONBLOCK to avoid
2746 deadlock.
2747 * process.c (create_process_1): Remove; no longer needed.
2748 (create_process): Remove timer hack; no longer needed, now that
2749 the child avoids deadlock.
2750
f0398ec1 27512013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2752
2753 * image.c (Fimage_flush): Fix doc typo.
2754
b2a069c2
PE
27552013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2756
6496aec9
PE
2757 Fix array bounds violation when pty allocation fails.
2758 * process.c (PTY_NAME_SIZE): New constant.
2759 (pty_name): Remove static variable; it's now auto.
2760 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2761 Take pty_name as an arg rather than using a static variable.
2762 All callers changed.
2763 (create_process): Recover pty_flag from process, not from volatile local.
2764 (create_pty): Stay inside array even when pty allocation fails.
2765 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2766
b2a069c2
PE
2767 * lread.c (Fload): Avoid initialization only when lint checking.
2768 Mention that it's needed only for older GCCs.
2769
99107004
KH
27702013-07-20 Kenichi Handa <handa@gnu.org>
2771
2772 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2773 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2774
6b1b199d
AS
27752013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2776
2777 * lread.c (Fload): Avoid uninitialized warning.
2778
4195afc3
PE
27792013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2780
3f5bef16
PE
2781 Fix some minor file descriptor leaks and related glitches.
2782 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2783 (create_lock_file): Use write, not emacs_write.
2784 * image.c (slurp_file, png_load_body):
2785 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2786 (server_accept_connection):
2787 Don't leak an fd on memory allocation failure.
2788 * image.c (slurp_file): Add a cheap heuristic for growing files.
2789 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2790 as that's what the other routines do. Maybe input need not be
2791 blocked at all, but it's better to be consistent.
2792 Avoid undefined behavior when strlen is zero.
2793
4195afc3
PE
2794 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2795 (NSTATICS): Now a constant; doesn't need to be a macro.
2796
a1aeeffe
RS
27972013-07-19 Richard Stallman <rms@gnu.org>
2798
2799 * coding.c (decode_coding_utf_8): Add simple loop for fast
2800 processing of ASCII characters.
2801
63b34baa
PE
28022013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2805
621dd9ac
EZ
28062013-07-19 Eli Zaretskii <eliz@gnu.org>
2807
2808 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2809 unportable 'struct x_display_info'.
2810 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2811 is a portable type.
2812
1396ac86
PE
28132013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2814
ab9980cd
PE
2815 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2816 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2817 or fscanf fails.
2818 (system_process_attributes): Prefer plain char to unsigned char
2819 when either will do. Clean up properly if interrupted or if
068f9124
SM
2820 memory allocations fail. Don't assume sscanf succeeds.
2821 Remove no-longer-needed workaround to stop GCC from whining.
2822 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2823 bit more carefully.
2824
1396ac86
PE
2825 Fix obscure porting bug with varargs functions.
2826 The code assumed that int is treated like ptrdiff_t in a vararg
2827 function, which is not a portable assumption. There was a similar
2828 -- though these days less likely -- porting problem with various
2829 assumptions that pointers of different types all smell the same as
2830 far as vararg functions is conserved. To make this problem less
2831 likely in the future, redo the API to use varargs functions.
2832 * alloc.c (make_save_value): Remove this vararg function.
2833 All uses changed to ...
2834 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2835 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2836 New functions.
2837 (make_save_ptr): Rename from make_save_pointer, for consistency with
2838 the above. Define only on platforms that need it. All uses changed.
2839
4d19d194
PE
28402013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 * keyboard.c: Try to fix typos in previous change.
2843 (DISPLAY_LIST_INFO): New macro.
2844 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2845 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2846
945c5bb1
JB
28472013-07-18 Juanma Barranquero <lekktu@gmail.com>
2848
2849 * keyboard.c (kbd_buffer_get_event):
2850 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2851 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2852
f4b1eb36
PE
28532013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2854
5e679a2c
PE
2855 * filelock.c: Fix unlikely file descriptor leaks.
2856 (get_boot_time_1): Rework to avoid using emacs_open.
2857 This doesn't actually fix a leak, but is better anyway.
2858 (read_lock_data): Use read, not emacs_read.
2859
a8cd4836
PE
2860 * doc.c: Fix minor memory and file descriptor leaks.
2861 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2862 (get_doc_string, Fsnarf_documentation):
2863 Fix file descriptor leak on error.
2864
ef30e638
PE
2865 * term.c: Fix minor fdopen-related file descriptor leaks.
2866 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2867 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2868
f4b1eb36
PE
2869 * charset.c: Fix file descriptor leaks and errno issues.
2870 Include <errno.h>.
2871 (load_charset_map_from_file): Don't leak file descriptor on error.
2872 Use plain record_xmalloc since the allocation is larger than
2873 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2874 of entries.
2875 * eval.c (record_unwind_protect_nothing):
2876 * fileio.c (fclose_unwind):
2877 New functions.
2878 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2879 The replacement doesn't block input, but that no longer seems
2880 necessary.
2881
b648c163
PE
28822013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2883
a0931322
PE
2884 * lread.c: Fix file descriptor leaks and errno issues.
2885 (Fload): Close some races that leaked fds or streams when 'load'
2886 was interrupted.
2887 (Fload, openp): Report error number of last nontrivial failure to open.
2888 ENOENT counts as trivial.
2889 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2890 New functions.
2891 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2892 now that the function is always called with a nonnegative arg.
2893 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2894 All uses replaced with ...
2895 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2896
b648c163
PE
2897 A few more minor file errno-reporting bugs.
2898 * callproc.c (Fcall_process):
2899 * doc.c (Fsnarf_documentation):
2900 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2901 * process.c (set_socket_option):
2902 Don't let a constructor trash errno.
2903 * doc.c: Include <errno.h>.
2904
b1dc4084
JB
29052013-07-16 Juanma Barranquero <lekktu@gmail.com>
2906
2907 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2908
c43843aa
PE
29092013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2910
50a30cce
PE
2911 Fix w32 bug with call-process-region (Bug#14885).
2912 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2913 to Fcall_process when the input is empty. This simplifies the
2914 code a bit. It makes no difference on POSIXish platforms but
2915 apparently it fixes a bug on w32.
2916
44e18199 2917 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2918 * fileio.c (close_file_unwind): Don't close if FD is negative;
2919 this can happen when unwinding a zapped file descriptor.
2920 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2921 in case Emacs runs out of memory between the two unwind-protects.
2922 Don't trash errno when closing FD.
2923 Zap the FD in the specpdl when closing it, instead of deferring
2924 the removal of the unwind-protect; this fixes a bug where a child
2925 function unwinds the stack past us.
2926
27e498e6
PE
2927 New unwind-protect flavors to better type-check C callbacks.
2928 This also lessens the need to write wrappers for callbacks,
2929 and the need for make_save_pointer.
2930 * alloca.c (free_save_value):
2931 * atimer.c (run_all_atimers):
2932 Now extern.
2933 * alloc.c (safe_alloca_unwind):
2934 * atimer.c (unwind_stop_other_atimers):
2935 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2936 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2937 * minibuf.c (choose_minibuf_frame_1):
2938 * process.c (make_serial_process_unwind):
2939 * xdisp.h (pop_message_unwind):
2940 * xselect.c (queue_selection_requests_unwind):
2941 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2942 * alloca.c (record_xmalloc):
2943 Prefer record_unwind_protect_ptr to record_unwind_protect with
2944 make_save_pointer.
2945 * alloca.c (Fgarbage_collect):
2946 Prefer record_unwind_protect_void to passing a dummy.
2947 * buffer.c (restore_buffer):
2948 * window.c (restore_window_configuration):
2949 * xfns.c, w32fns.c (do_unwind_create_frame)
2950 New wrapper. All record-unwind uses of wrappee changed.
2951 * buffer.c (set_buffer_if_live):
2952 * callproc.c (call_process_cleanup, delete_temp_file):
2953 * coding.c (code_conversion_restore):
2954 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2955 * editfns.c (save_excursion_restore)
2956 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2957 (save_restriction_restore):
2958 * eval.c (restore_stack_limits, un_autoload):
2959 * fns.c (require_unwind):
2960 * keyboard.c (recursive_edit_unwind, tracking_off):
2961 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2962 * macros.c (pop_kbd_macro, restore_menu_items):
2963 * nsfns.m (unwind_create_frame):
2964 * print.c (print_unwind):
2965 * process.c (start_process_unwind):
2966 * search.c (unwind_set_match_data):
2967 * window.c (select_window_norecord, select_frame_norecord):
2968 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2969 (fast_set_selected_frame):
2970 * xfns.c, w32fns.c (unwind_create_tip_frame):
2971 Return void, not a dummy Lisp_Object. All uses changed.
2972 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2973 * callproc.c (call_process_kill):
2974 * fileio.c (restore_point_unwind, decide_coding_unwind)
2975 (build_annotations_unwind):
2976 * insdel.c (Fcombine_after_change_execute_1):
2977 * keyboard.c (read_char_help_form_unwind):
2978 * menu.c (unuse_menu_items):
2979 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2980 * sound.c (sound_cleanup):
2981 * xdisp.c (unwind_redisplay):
2982 * xfns.c (clean_up_dialog):
2983 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2984 Accept no args and return void, instead of accepting and returning
2985 a dummy Lisp_Object. All uses changed.
2986 * cygw32.c (fchdir_unwind):
2987 * fileio.c (close_file_unwind):
2988 * keyboard.c (restore_kboard_configuration):
2989 * lread.c (readevalllop_1):
2990 * process.c (wait_reading_process_output_unwind):
2991 Accept int and return void, rather than accepting an Emacs integer
2992 and returning a dummy object. In some cases this fixes an
2993 unlikely bug when the corresponding int is outside Emacs integer
2994 range. All uses changed.
2995 * dired.c (directory_files_internal_unwind):
2996 * fileio.c (do_auto_save_unwind):
2997 * gtkutil.c (pop_down_dialog):
2998 * insdel.c (reset_var_on_error):
2999 * lread.c (load_unwind):
3000 * xfns.c (clean_up_file_dialog):
3001 * xmenu.c, nsmenu.m (pop_down_menu):
3002 * xmenu.c (cleanup_widget_value_tree):
3003 * xselect.c (wait_for_property_change_unwind):
3004 Accept pointer and return void, rather than accepting an Emacs
3005 save value encapsulating the pointer and returning a dummy object.
3006 All uses changed.
3007 * editfns.c (Fformat): Update the saved pointer directly via
3008 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
3009 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
3010 (unwind_body): New function.
3011 (record_unwind_protect): First arg is now a function returning void,
3012 not a dummy Lisp_Object.
3013 (record_unwind_protect_ptr, record_unwind_protect_int)
3014 (record_unwind_protect_void): New functions.
3015 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
3016 * fileio.c (struct auto_save_unwind): New type.
3017 (do_auto_save_unwind): Use it.
3018 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
3019 * insdel.c (struct rvoe_arg): New type.
3020 (reset_var_on_error): Use it.
3021 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
3022 New constants.
3023 (specbinding_func): Remove; there are now several such functions.
3024 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
3025 (set_unwind_protect_ptr): New function.
3026 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
3027
4e604a5d
PE
3028 Be simpler and more consistent about reporting I/O errors.
3029 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3030 Say "Read error" and "Write error", rather than "I/O error", or
3031 "IO error reading", or "IO error writing", when a read or write
3032 error occurs.
3033 * process.c (Fmake_network_process, wait_reading_process_output)
3034 (send_process, Fprocess_send_eof, wait_reading_process_output):
3035 Capitalize diagnostics consistently. Put "failed foo" at the
3036 start of the diagnostic, so that we don't capitalize the
3037 function name "foo". Consistently say "failed" for such
3038 diagnostics.
3039 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
3040 All callers changed. This is so it can use report_file_error.
3041 * sysdep.c (serial_open, serial_configure): Capitalize I/O
3042 diagnostics consistently as above.
3043
a9757f6a
PE
3044 * fileio.c (report_file_errno): Fix errno reporting bug.
3045 If the file name is neither null nor a pair, package it up as a
3046 singleton list. All callers changed, both to this function and to
3047 report_file_error. This fixes a bug where the memory allocator
3048 invoked by list1 set errno so that the immediately following
3049 report_file_error reported the wrong errno value.
3050
c43843aa
PE
3051 Fix minor problems found by --enable-gcc-warnings.
3052 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
3053 * keyboard.c (kbd_buffer_get_event): Remove unused local.
3054
18c26d81
JD
30552013-07-16 Jan Djärv <jan.h.d@swipnet.se>
3056
3057 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
3058 Set event->arg to Qt if switch-event shall be generated.
3059 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
3060
3061 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
3062
3063 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
3064 FOCUS_OUT_EVENT.
3065
3066 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
3067 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
3068 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
3069 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 3070 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
3071 and there is a focused frame.
3072 (head_table): Add focus-in and focus-out.
3073 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
3074 bind to handle-focus-in/out.
3075
3076 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
3077 (Fhandle_switch_frame): Call Fhandle_focus_in.
3078 (syms_of_frame): defsubr handle-focus-in/out.
3079
6c6f1994
PE
30802013-07-16 Paul Eggert <eggert@cs.ucla.edu>
3081
c7ddc792
PE
3082 Fix porting bug to older POSIXish platforms (Bug#14862).
3083 * sysdep.c (emacs_pipe): New function, that implements
3084 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
3085 This should port better to CentOS 5 and to Mac OS X 10.6.
3086 All calls to pipe2 changed.
3087
6c6f1994
PE
3088 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
3089 This makes the code easier to read and the executable a bit smaller.
3090 Do not replace all calls to Fcons that happen to create lists,
3091 just calls that are intended to create lists. For example, when
3092 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
3093 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
3094 Similarly for list2 through list5.
3095 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3096 * bytecode.c (exec_byte_code):
3097 * callint.c (quotify_arg, Fcall_interactively):
3098 * callproc.c (Fcall_process, create_temp_file):
3099 * charset.c (load_charset_map_from_file)
3100 (Fdefine_charset_internal, init_charset):
3101 * coding.c (get_translation_table, detect_coding_system)
3102 (Fcheck_coding_systems_region)
3103 (Fset_terminal_coding_system_internal)
3104 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
3105 * composite.c (update_compositions, Ffind_composition_internal):
3106 * dired.c (directory_files_internal, file_name_completion)
3107 (Fsystem_users):
3108 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
3109 * doc.c (Fsnarf_documentation):
3110 * editfns.c (Fmessage_box):
3111 * emacs.c (main):
3112 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
3113 (Feval, eval_sub, Ffuncall, apply_lambda):
3114 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
3115 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
3116 (Fset_file_times, Finsert_file_contents)
3117 (Fchoose_write_coding_system, Fwrite_region):
3118 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
3119 * font.c (font_registry_charsets, font_parse_fcname)
3120 (font_prepare_cache, font_update_drivers, Flist_fonts):
3121 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3122 * frame.c (make_frame, Fmake_terminal_frame)
3123 (x_set_frame_parameters, x_report_frame_params)
3124 (x_default_parameter, Fx_parse_geometry):
3125 * ftfont.c (syms_of_ftfont):
3126 * image.c (gif_load):
3127 * keyboard.c (command_loop_1):
3128 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3129 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3130 (Fminor_mode_key_binding, accessible_keymaps_1)
3131 (Faccessible_keymaps, Fwhere_is_internal):
3132 * lread.c (read_emacs_mule_char):
3133 * menu.c (find_and_return_menu_selection):
3134 * minibuf.c (get_minibuffer):
3135 * nsfns.m (Fns_perform_service):
3136 * nsfont.m (ns_script_to_charset):
3137 * nsmenu.m (ns_popup_dialog):
3138 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3139 (Fx_own_selection_internal):
3140 * nsterm.m (append2):
3141 * print.c (Fredirect_debugging_output)
3142 (print_prune_string_charset):
3143 * process.c (Fdelete_process, Fprocess_contact)
3144 (Fformat_network_address, set_socket_option)
3145 (read_and_dispose_of_process_output, write_queue_push)
3146 (send_process, exec_sentinel):
3147 * sound.c (Fplay_sound_internal):
3148 * textprop.c (validate_plist, add_properties)
3149 (Fput_text_property, Fadd_face_text_property)
3150 (copy_text_properties, text_property_list, syms_of_textprop):
3151 * unexaix.c (report_error):
3152 * unexcoff.c (report_error):
3153 * unexsol.c (unexec):
3154 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3155 (Fformat_mode_line, syms_of_xdisp):
3156 * xfaces.c (set_font_frame_param)
3157 (Finternal_lisp_face_attribute_values)
3158 (Finternal_merge_in_global_face, syms_of_xfaces):
3159 * xfns.c (x_default_scroll_bar_color_parameter)
3160 (x_default_font_parameter, x_create_tip_frame):
3161 * xfont.c (xfont_supported_scripts):
3162 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3163 (menu_help_callback, xmenu_show):
3164 * xml.c (make_dom):
3165 * xterm.c (set_wm_state):
3166 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3167 and similarly for list2 through list5.
3168
bafe80ce
PE
31692013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3170
3171 * callproc.c (Fcall_process_region): Fix minor race and tune.
3172 (create_temp_file): New function, with the temp-file-creation part
3173 of the old Fcall_process_region. Use Fcopy_sequence to create the
3174 temp file name, rather than alloca + build_string, for simplicity.
3175 Don't bother to block input around the temp file creation;
068f9124
SM
3176 shouldn't be needed. Simplify use of mktemp.
3177 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3178 this closes an unlikely race where the temp file was not removed.
3179 Use memcpy rather than an open-coded loop.
3180 (Fcall_process_region): Use the new function. If the input is
3181 empty, redirect from /dev/null rather than from a newly created
3182 empty temp file; this avoids unnecessary file system traffic.
3183
4700b5a5
PE
31842013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3185
5c97beae
PE
3186 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3187 Simplify by making this case like the other two. This is a bit
3188 slower on obsolete hosts, but the extra complexity isn't worth it.
3189
4700b5a5
PE
3190 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3191 * process.c (create_process) [!DOS_NT]:
3192 Remove now-unnecessary calls to emacs_close.
3193
f9a74c4c
EZ
31942013-07-13 Eli Zaretskii <eliz@gnu.org>
3195
922ae7ee
EZ
3196 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3197 returning early. (Bug#14850)
3198
f9a74c4c
EZ
3199 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3200 and inhibit-iso-escape-detection attributes of 'undecided'.
3201 (Bug#14822)
3202
5e301d76
PE
32032013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3204
69e0e5ee
PE
3205 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3206 Reported by Herbert J. Skuhra in
3207 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3208
5e301d76
PE
3209 Don't lose top specpdl entry when memory is exhausted.
3210 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3211 specpdl overflow here, to simplify callers; all callers changed.
3212 Always reserve an unused entry at the stack top; this avoids
3213 losing the top entry's information when memory is exhausted.
3214
7e649856
PE
32152013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3216
a773ed9a
PE
3217 Clean up errno reporting and fix some errno-reporting bugs.
3218 * callproc.c (Fcall_process):
3219 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3220 * process.c (create_process, Fmake_network_process):
3221 * unexaix.c (report_error):
3222 * unexcoff.c (report_error):
3223 Be more careful about reporting the errno of failed operations.
3224 The code previously reported the wrong errno sometimes.
3225 Also, prefer report_file_errno to setting errno + report_file_error.
3226 (Fcall_process): Look at openp return value rather than at path,
3227 as that's a bit faster and clearer when there's a numeric predicate.
3228 * fileio.c (report_file_errno): New function, with most of the
3229 old contents of report_file_error.
3230 (report_file_error): Use it.
3231 (Ffile_exists_p, Ffile_accessible_directory_p):
3232 Set errno to 0 when it is junk.
3233 * fileio.c (Faccess_file):
3234 * image.c (x_create_bitmap_from_file):
3235 Use faccessat rather than opening the file, to avoid the hassle of
3236 having a file descriptor open.
3237 * lisp.h (report_file_errno): New decl.
3238 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3239
7e649856
PE
3240 Minor EBADF fixes.
3241 * process.c (create_process, wait_reading_process_output) [AIX]:
3242 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3243 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3244 a multithreaded environment anyway).
3245 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3246
f6774c1a
AS
32472013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3248
3249 * image.c (x_find_image_file): Don't close a remote file handle.
3250
bacba3c2
PE
32512013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 Fix races with threads and file descriptors.
3254 * callproc.c (Fcall_process_region):
3255 * dired.c (open_directory):
3256 * emacs.c (main, Fdaemon_initialized):
3257 * image.c (x_find_image_file):
3258 * inotify.c (Finotify_rm_watch):
3259 * lread.c (Flocate_file_internal):
3260 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3261 * term.c (term_mouse_moveto, init_tty):
3262 * termcap.c (tgetent):
3263 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3264 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3265 * unexhp9k800.c, unexmacosx.c (unexec):
3266 * callproc.c (Fcall_process_region):
3267 Use emacs_close, not close.
3268 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3269 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3270 and posix_close function on current platforms (which all lack them).
3271 (emacs_close): Use it. This should fix the races on GNU/Linux and
3272 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3273 and it should avoid closing random victim file descriptors on
3274 other platforms.
3275
653d4f43
PE
32762013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3277
c8536ec4
PE
3278 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3279 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3280 Touch up doc a bit.
3281
9c203066
PE
3282 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3283 This is for .gdbinit xbacktrace.
3284
653d4f43
PE
3285 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3286 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3287 (emacs_set_tty): Now static.
3288 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3289 * term.c (tty_capable_p, tty_default_color_capabilities)
3290 (get_tty_terminal, term_mouse_movement)
3291 (handle_one_term_event, init_tty, maybe_fatal):
3292 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3293 (tgetent, scan_file, name_match, compare_contin):
3294 * terminal.c (get_terminal):
3295 Use bool for boolean.
3296 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3297 Prefer char to unsigned char if either will do.
3298 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3299 (tty_write_glyphs): Prefer int to unsigned.
3300 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3301 All callers changed.
3302 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3303
45b683a1
PE
33042013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3305
29abe551
PE
3306 Port to C89.
3307 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3308 (B__dummy__): New dummy symbol, to pacify C89.
3309 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3310 they can't grok varargs macros.
3311 * dispnew.c (add_window_display_history)
3312 (add_frame_display_history):
3313 * print.c (print_object):
3314 * xdisp.c (debug_method_add):
3315 Use %p printf format only for void pointers.
3316 * emacs.c (usage_message): New constant, replacing ...
3317 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3318 (main): Adjust to usage reorg.
3319 * fns.c (syms_of_fns):
3320 * profiler.c (syms_of_profiler):
3321 Don't use non-constant struct initializers.
3322 * gnutls.h (gnutls_initstage_t):
3323 * lisp.h (enum Lisp_Fwd_Type):
3324 * lread.c (lisp_file_lexically_bound_p):
3325 * xsettings.c (anonymous enum):
3326 Remove trailing comma.
3327 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3328 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3329 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3330 (DEFUN): Use it.
3331 * regex.c (const_re_char): New type, to pacify strict C89.
3332 All uses of 'const re_char' replaced to use it.
3333 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3334 with glibc when strict C89. This change is imported from gnulib.
3335 All uses changed.
3336 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3337 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3338 Omit GNU_LINUX implementation, since it requires long long.
3339 * xterm.c (x_draw_underwave):
3340 Do not assume the traditional order of struct's members.
3341 (x_term_init): Rewrite to avoid the need for non-constant structure
3342 initializers.
3343
45b683a1 3344 Syntax cleanup, mostly replacing macros with functions.
763a086d 3345 This removes the need for the syntax_temp hack.
45b683a1
PE
3346 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3347 * syntax.c (SYNTAX_INLINE): New macro.
3348 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3349 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3350 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3351 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3352 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3353 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3354 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3355 Now constants, not macros.
3356 (syntax_temp) [!__GNUC__]: Remove.
3357 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3358 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3359 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3360 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3361 Move here from syntax.h; now functions, not macros. Except for the
3362 last function, these are static since only syntax.c uses them.
3363 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3364 All uses changed. Now a function, not a macro; use this fact
3365 to simplify the code.
3366 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3367 compiler bugs; no longer relevant.
3368 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3369 (SYNTAX_INLINE): New macro.
3370 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3371 for the new functions. Use bool for boolean member.
3372 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3373 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3374 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3375 (SETUP_BUFFER_SYNTAX_TABLE):
3376 Now extern inline functions, not macros.
3377 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3378 Remove; all uses replaced by implementation.
3379 (syntax_temp) [!__GNUC__]: Remove decl.
3380 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3381
29be4a50
JD
33822013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3383
3384 * emacs.c (main): Fix syntax error.
3385
954b166e
PE
33862013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3387
3388 Timestamp fixes for undo (Bug#14824).
3389 * atimer.c (schedule_atimer):
3390 * fileio.c (Ffile_newer_than_file_p):
3391 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3392 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3393 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3394 (syms_of_fileio): Remove Sclear_visited_file_name.
3395 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3396 file doesn't exist; this avoids an ambiguity with negative timestamps.
3397 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3398 * systime.h (make_emacs_time, invalid_emacs_time):
3399 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3400 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3401 * undo.c (record_first_change): Push (visited-file-modtime) onto
3402 undo list rather than reimplementing it by hand, incorrectly.
3403
d74647c3
KB
34042013-07-09 Ken Brown <kbrown@cornell.edu>
3405
3406 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3407
3c51b96b
JB
34082013-07-09 Juanma Barranquero <lekktu@gmail.com>
3409
3410 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3411
4ebbdd67
PE
34122013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3413
3414 Handle errno and exit status a bit more carefully.
3415 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3416 number into an exit status. Instead, use EXIT_CANCELED.
3417 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3418 * callproc.c (relocate_fd):
3419 * emacs.c (close_output_streams, main):
3420 * process.c (create_process):
3421 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3422 Use emacs_perror for simplicity.
3423 * callproc.c (relocate_fd, main):
3424 * sysdep.c (sys_subshell):
3425 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3426 (shut_down_emacs): Use emacs_write, not write.
3427 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3428 * fileio.c (Fcopy_file, e_write):
3429 * nsterm.m (ns_select):
3430 * process.c (send_process):
3431 * sound.c (vox_write):
3432 Use emacs_write_sig, not emacs_write.
3433 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3434 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3435 New constants.
3436 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3437 of write.
3438 (emacs_full_write): New function.
3439 (emacs_write): Rewrite to use it.
3440 (emacswrite_sig, emacs_perror): New functions.
3441 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3442
44e18199 34432013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3444
3445 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3446 on NS even if it is present. Pixmap on NS is a void*.
3447
9caab067
PE
34482013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3449
3450 Port to Ubuntu 10 (Bug#14803).
3451 Problem reported by T.V. Raman.
3452 * process.c (close_on_exec, accept4, process_socket):
3453 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3454
1d442672
EZ
34552013-07-07 Eli Zaretskii <eliz@gnu.org>
3456
3457 * w32.c (sys_dup): Declare prototype.
3458
3459 * filelock.c:
3460 * emacs.c:
3461 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3462
067428c1
PE
34632013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3464
3465 Make file descriptors close-on-exec when possible (Bug#14803).
3466 This simplifies Emacs a bit, since it no longer needs to worry
3467 about closing file descriptors by hand in some cases.
3468 It also fixes some unlikely races. Not all such races, as
3469 libraries often open files internally without setting
3470 close-on-exec, but it's an improvement.
3471 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3472 * callproc.c (Fcall_process) [!MSDOS]:
3473 * emacs.c (main) [!DOS_NT]:
3474 * nsterm.m (ns_term_init):
3475 * process.c (create_process):
3476 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3477 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3478 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3479 Prefer mkostemp with O_CLOEXEC to mkstemp.
3480 * callproc.c (relocate_fd) [!WINDOWSNT]:
3481 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3482 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3483 now using pipe2.
3484 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3485 Make the resulting file descriptor close-on-exec.
3486 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3487 * lread.c (load_descriptor_list, load_descriptor_unwind):
3488 Remove; no longer needed. All uses removed.
3489 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3490 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3491 New functions.
3492 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3493 (Fmake_network_process, Fnetwork_interface_list):
3494 (Fnetwork_interface_info, server_accept_connection):
3495 Make newly-created socket close-on-exec.
3496 * sysdep.c (emacs_open, emacs_fopen):
3497 Make new-created descriptor close-on-exec.
3498 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3499 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3500
0da857dd
JD
35012013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3502
3503 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3504 for NS_IMPL_GNUSTEP.
3505
5f86adcd
PE
35062013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3507
3508 Fix openp errno handling.
3509 * callproc.c (Fcall_process): Preserve openp errno around close.
3510 * lread.c (openp): Set errno when returning -1, as some callers
3511 expect this.
3512
1afb1d07
JD
35132013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3514
3515 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3516
3517 * nsterm.h (NSSavePanel): Update comment.
3518 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3519 (ns_run_file_dialog): Declare.
3520
3521 * nsfns.m: Remove panelOK.
3522 (ns_fd_data): New.
3523 (ns_run_file_dialog): New function.
3524 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3525 event loop, so file dialog is popped up by ns_run_file_dialog, called
3526 by sendEvent (Bug#14578).
3527 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3528
3323c263
EZ
35292013-07-06 Eli Zaretskii <eliz@gnu.org>
3530
fdda0220
EZ
3531 * xdisp.c (default_line_pixel_height): New function.
3532 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3533 (try_cursor_movement, redisplay_window, try_window)
3534 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3535
068f9124
SM
3536 * window.c (window_scroll_pixel_based):
3537 use default_line_pixel_height.
fdda0220
EZ
3538
3539 * dispextern.h (default_line_pixel_height): Add prototype.
3540
3541 * frame.c (x_set_line_spacing): Accept a float value for
3542 line-spacing parameter, per the documentation.
3543
3323c263
EZ
3544 * data.c (Fmultibyte_string_p): Doc fix.
3545
47ba6d43
PE
35462013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3547
406af475
PE
3548 Use emacs_open more consistently when opening files.
3549 This handles EINTR more consistently now, and makes it easier
3550 to introduce other uniform changes to file descriptor handling.
3551 * src/systdio.h: New file.
3552 * src/buffer.c (mmap_init):
3553 * cygw32.c (chdir_to_default_directory):
3554 * dispnew.c (Fopen_termscript):
3555 * emacs.c (Fdaemon_initialized):
3556 * fileio.c (Fdo_auto_save):
3557 * image.c (slurp_file, png_load_body, jpeg_load_body):
3558 * keyboard.c (Fopen_dribble_file):
3559 * lread.c (Fload):
3560 * print.c (Fredirect_debugging_output):
3561 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3562 * termcap.c (tgetent):
3563 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3564 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3565 * w32term.c (w32_initialize) [CYGWIN]:
3566 * xfaces.c (Fx_load_color_file):
3567 Use emacs_open instead of plain open, and emacs_fopen instead of
3568 plain fopen.
3569 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3570 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3571 * callproc.c (default_output_mode): New constant.
3572 (Fcall_process): Use it to call emacs_open instead of plain creat.
3573 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3574 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3575 (emacs_fopen): New function.
3576 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3577 Include <lisp.h>, for emacs_open.
3578 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3579
47ba6d43
PE
3580 Remove duplicate #include directives.
3581 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3582 * xfaces.c:
3583 Don't include stdio.h twice.
3584 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3585 Don't include sys/types.h or stdio.h twice.
3586 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3587 * lread.c: Don't include coding.h twice.
3588 * nsfont.m: Don't include frame.h twice.
3589 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3590 * ralloc.c: Don't include <unistd.h> twice.
3591 * xdisp.c: Don't include font.h twice.
3592 * xterm.c: Don't include fontset.h twice.
3593 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3594
b9ed53d5
PE
35952013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Scale ImageMagick images more carefully.
3598 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3599 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3600 Be more careful about avoiding undefined behavior after
3601 integer overflow and division by zero.
3602
cf13177e
YM
36032013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3604
3605 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3606 (syms_of_w32fns): DEFSYM them.
3607 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3608 (CCHDEVICENAME): Define macros if not defined.
3609 (struct MONITOR_INFO_EX): New struct.
3610 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3611 (enum_display_monitors_fn): New variable.
3612 (globals_of_w32fns): Initialize it.
3613 (Fx_display_pixel_width, Fx_display_pixel_height)
3614 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3615 multi-monitor setups in docstrings.
3616 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3617 screen size by primary monitor's millimeter per pixel.
3618 (w32_monitor_enum, w32_display_monitor_attributes_list)
3619 (w32_display_monitor_attributes_list_fallback)
3620 (Fw32_display_monitor_attributes_list): New functions.
3621 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3622
3623 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3624 if not defined.
3625 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3626
86dfb7a8
MA
36272013-07-04 Michael Albinus <michael.albinus@gmx.de>
3628
3629 * fileio.c (Qfile_notify_error): New error symbol.
3630
3631 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3632 * inotify.c (inotify_callback, symbol_to_inotifymask)
3633 (Finotify_add_watch, Finotify_rm_watch): Use it.
3634 (inotifyevent_to_event): Exchange order of cookie and file name.
3635 (Finotify_add_watch): Adapt docstring.
3636
3637 * lisp.h (Qfile_notify_error): Declare.
3638
2c1c974b
PE
36392013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3642 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3643 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3644 which did not work (see <http://bugs.gnu.org/14569#307>).
3645 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3646 && (!noninteractive || initialized)). This attempts to thread
3647 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3648
7a35b20f
JB
36492013-07-04 Juanma Barranquero <lekktu@gmail.com>
3650
3651 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3652 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3653
1ce5cd04
PE
36542013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3657 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3658 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3659 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3660
57f8c490
PE
36612013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3664 Define to __sys_siglist.
3665
bcffb5ca
EZ
36662013-07-02 Eli Zaretskii <eliz@gnu.org>
3667
3668 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3669 word-wrap, so that overflow-newline-into-fringe would work in
3670 visual-line-mode. (Bug#2749)
3671 (move_it_in_display_line_to): When the last scanned display
3672 element fits exactly on the display line, and
3673 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3674 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3675 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3676 finding buffer position that corresponds to pixel coordinates,
3677 e.g. in buffer_posn_from_coords.
3678
2c41e781
JD
36792013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3680
3681 * process.c (handle_child_signal): Call catch_child_signal if
3682 NS_IMPL_GNUSTEP.
3683
c2418359
PE
36842013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3685
52a9bcae
PE
3686 Don't convert function pointers to void * and back.
3687 It isn't portable C, and it's easy enough to avoid.
3688 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3689 (make_save_value): Add support for SAVE_FUNCPOINTER.
3690 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3691 * print.c (print_object):
3692 Distinguish function from object pointers.
3693 * lisp.h (SAVE_FUNCPOINTER): New constant.
3694 (SAVE_SLOT_BITS): Adjust to it.
3695 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3696 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3697 (voidfuncptr): New typedef.
3698 (struct Lisp_Save_Value): New member data[0].funcpointer.
3699 (XSAVE_FUNCPOINTER): New function.
3700
c2418359
PE
3701 Simplify buildobj processing.
3702 * Makefile.in (buildobj.h): Make it a sequence of strings each
3703 followed by comma, rather than a single string. Put it into a
3704 .tmp file in case there's an error while generating it.
3705 (gl-stamp): Use .tmp for temp files.
3706 (mostlyclean): Clean .tmp files.
3707 * doc.c (buildobj): Move to just the routine that needs it.
3708 It's now an array of strings, so processing is simpler.
3709
8f43ce49
PE
37102013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3713 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3714 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3715 Invoke malloc_enable_thread even when not interactive.
3716 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3717 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3718 in this case, since the underlying bug has now been fixed.
3719
24827db9
JB
37202013-07-01 Juanma Barranquero <lekktu@gmail.com>
3721
3722 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3723 unlinking it (bug#14691).
3724
ef099a94
MN
37252013-06-30 Michal Nazarewicz <mina86@mina86.com>
3726
3727 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3728 before checking whether buffer is modified. This lets
3729 `kill-buffer-query-functions' cancel killing of the buffer or save
3730 its content before `kill-buffer' asks user the "Buffer %s
3731 modified; kill anyway?" question.
3732
9d3f2fc2
JD
37332013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3734
3735 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3736 Let the super performKeyEquivalent deal with them (Bug#14747).
3737
e6c6c8c7
PE
37382013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3739
1d71c1d9
PE
3740 * widget.c (resize_cb): Remove unused local.
3741
8f5f35cc
PE
3742 Do not use GTK 3 if it exists but cannot be compiled.
3743 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3744 * xterm.c (x_error_handler) [!USE_GTK]:
3745 Do not use GTK 3.
3746
e6c6c8c7
PE
3747 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3748
0ba54312
EZ
37492013-06-30 Eli Zaretskii <eliz@gnu.org>
3750
5d1c3286
EZ
3751 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3752 to the valid range of values. (Bug#14753)
3753
0ba54312
EZ
3754 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3755 when moving point by using the current glyph matrix. This avoids
3756 the need to force redisplay when this function is called in a
3757 loop.
3758
9c90cc06
PE
37592013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3760
3761 Fix minor problems found by static checking.
3762 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3763 Redo the latter's body to sidestep GCC parenthesization warnings.
3764 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3765 * coding.c (detect_coding, detect_coding_system):
3766 * coding.h (struct undecided_spec):
3767 Use bool for boolean.
3768 * image.c (QCmax_width, QCmax_height): Now static.
3769 * xdisp.c (Fmove_point_visually): Remove unused local.
3770
4c672a0f
EZ
37712013-06-29 Eli Zaretskii <eliz@gnu.org>
3772
3773 * xdisp.c (Fmove_point_visually): New function.
3774
c1ea3abf
JB
37752013-06-28 Kenichi Handa <handa@gnu.org>
3776
3777 * coding.h (define_coding_undecided_arg_index): New enum.
3778 (coding_attr_index): New members
3779 coding_attr_undecided_inhibit_null_byte_detection,
3780 coding_attr_undecided_inhibit_iso_escape_detection,
3781 coding_attr_undecided_prefer_utf_8.
3782 (undecided_spec): New struct.
3783 (struct coding_system): New member `undecided' of the member
3784 `spec'.
3785
3786 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3787 (detect_coding): Likewise.
3788 (detect_coding_system): Likewise.
3789 (Fdefine_coding_system_internal): New coding system properties
3790 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3791 :prefer-utf-8.
3792 (syms_of_coding): Adjust for coding_arg_undecided_max.
3793
ba3de9e6
PE
37942013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3795
3796 * image.c (x_from_xcolors): Remove unused local.
3797
547c9269
YM
37982013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3799
3800 Defer image data transfer between X client and server until actual
3801 display happens.
3802
3803 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3804 and `mask_img'.
3805
3806 * image.c (Destroy_Image): Remove.
3807 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3808 `mask_p', and `colors_p'. All uses changed.
3809 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3810 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3811 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3812 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3813 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3814 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3815 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3816 (image_get_x_image, image_unget_x_image): New functions or macros.
3817 (image_background, image_background_transparent, x_to_xcolors)
3818 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3819 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3820 instead of Destroy_Image.
3821 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3822 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3823 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3824 (imagemagick_load_image, svg_load_image): Use them instead of
3825 x_create_x_image_and_pixmap, and x_put_x_image followed by
3826 x_destroy_x_image, respectively.
3827 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3828 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3829 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3830 background_transparent fields.
3831 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3832 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3833
dae2f5ef
PE
38342013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3835
3836 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3837 This mostly consists of undoing recent changes.
3838 * callproc.c (Fcall_process):
3839 * process.c (create_process):
3840 Do not worry about catching SIGCHLD here, undoing previous change.
3841 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3842 * process.c, process.h (catch_child_signal):
3843 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3844 * process.c (catch_child_handler): Don't worry about being called
3845 lazily and do not assume caller has blocked SIGCHLD, undoing
3846 previous change. Move first-time stuff back to
3847 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3848 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3849 set lib_child_handler if it's already initialized, which may
3850 help avoid problems on GNUStep.
3851
fa55d2aa
PE
38522013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3853
3854 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3855 * callproc.c (Fcall_process):
3856 * process.c (create_process):
3857 Make sure SIGCHLD is caught before we fork,
3858 since Emacs startup no arranges to catch SIGCHLD.
3859 * process.c (lib_child_handler): Initialize to null, not to
3860 dummy_handler.
3861 (catch_child_signal): Allow self to be called lazily.
3862 Do nothing if it's already been called.
3863 Assume caller has blocked SIGCHLD (all callers do now).
3864 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3865 just before it's really needed.
3866 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3867 since it hasn't been caught yet.
3868
f3f9606c
LMI
38692013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3870
3871 * image.c (compute_image_size): New function to implement
3872 :max-width and :max-height.
3873 (imagemagick_load_image): Use it.
3874
c7041908
PE
38752013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3878 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3879 Now extern.
3880 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3881 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3882 the SIGCHLD handler, since the code is not atomic and (due to glib)
3883 signals may be arriving now.
3884 * sysdep.c (init_signals): Do not catch child signals here;
3885 'main' now does that later, at a safer time.
3886
f86852b4
PE
38872013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3888
0dfeed58
PE
3889 Clean up SIGCHLD handling a bit (Bug#14569).
3890 * process.c, process.h (catch_child_signal):
3891 Now always extern, even if !NS_IMPL_GNUSTEP.
3892 * process.c (catch_child_signal): Move glib tickler here from
3893 init_process_emacs, so that it's done earlier in Emacs
3894 initialization. Also move the noninteractive && !initialized
3895 check here from init_process_emacs. This is all a bit cleaner for
3896 GNUish platforms, and I hope it works around the Cygwin bug.
3897 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3898 that glib signal handling is tickled before glib creates threads.
3899
f86852b4
PE
3900 * process.c (wait_reading_process_output): Avoid int overflow
3901 when reading more than 2 GiB total from a process.
3902
cbd6509c
PE
39032013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 * process.c (create_process): Handle a couple more cases,
3906 i.e., work even if new_argv and wait_child_setup[i] are cached.
3907 Use Fcall_process's style for volatile vars.
3908
9de1114a
AS
39092013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3910
3911 * process.c (create_process): Mark PROCESS volatile.
3912
fbe9e0b9
PE
39132013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3914
3915 Use C99-style flexible array members if available.
3916 This avoids some subtle aliasing issues, which typically
3917 aren't a problem with GCC but may be a problem elsewhere.
3918 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3919 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3920 In either case, it uses a flexible array member rather than
3921 the old struct hack. All uses changed.
3922 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3923 Adjust to sdata reorganization.
3924 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3925 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3926 that ports better to pre-C99 non-GCC.
3927 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3928 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3929 as the latter has changed.
3930 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3931 and port better to pre-C99 GCC.
3932 * image.c (struct xpm_cached_color):
3933 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3934 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3935 Use FLEXIBLE_ARRAY_MEMBER.
3936 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3937 Move decl to top level so it gets checked against implementation.
3938 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3939 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3940
1fc71008
PE
39412013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 * syntax.c: Integer cleanups.
3944 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3945 All uses that need 0-or-2 changed to:
3946 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3947 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3948 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3949 (char_quoted, prev_char_comend_first, back_comment)
3950 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3951 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3952 Use bool for boolean.
3953 (update_syntax_table, skip_chars, skip_syntaxes):
3954 Prefer int to unsigned when either will do.
3955 (back_comment): Return boolean success flag, like forw_comment,
3956 instead of positive-or-minus-1 (which might have overflowed int anyway).
3957 Don't stuff ptrdiff_t into int.
3958 (syntax_spec_code, syntax_code_spec): Now const.
3959 (Fmatching_paren, scan_lists, scan_sexps_forward):
3960 Use enum syntaxcode for syntax code.
3961 (Fmatching_paren): Check that arg is a character, not just an integer.
3962 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3963 (Finternal_describe_syntax_value): Omit no-longer-needed
3964 comparison to 0.
3965 (skip_chars): Use char, not unsigned char, when the distinction
3966 doesn't matter.
3967 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3968 * bytecode.c (exec_byte_code):
3969 * syntax.c (syntax_spec_code, Fchar_syntax)
3970 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3971 (init_syntax_once):
3972 * syntax.h (SYNTAX_WITH_FLAGS):
3973 Omit unnecessary casts.
3974
b932cad7
EZ
39752013-06-20 Eli Zaretskii <eliz@gnu.org>
3976
3977 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3978 line dimensions here, to avoid race conditions with the main
3979 thread. (Bug#14062, bug#14630, bug#14669)
3980
3981 * w32term.c (w32_draw_window_cursor): Compute the header line and
3982 mode line dimensions here.
3983 <w32_system_caret_window, w32_system_caret_hdr_height>:
3984 <w32_system_caret_mode_height>: New variables.
3985
3986 * w32term.h: Declare them.
3987
89561f72
PE
39882013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3989
5013fc08
PE
3990 * alloc.c (die): Move "assertion failed" string here ...
3991 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3992 COND when SUPPRESS_CHECKING. This shrinks the executable text
3993 size by 0.8% to 2.2% when configured with --enable-checking,
3994 depending on optimization flags (GCC 4.8.1 x86-64).
3995
89561f72
PE
3996 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3997
763a086d 39982013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3999
4000 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
4001 base is 2; this is more accurate.
4002
983aeb9a
JB
40032013-06-19 Juanma Barranquero <lekktu@gmail.com>
4004
4005 * sound.c (string_default): Move to !WINDOWSNT section.
4006 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
4007
178ba3e6
PE
40082013-06-19 Paul Eggert <eggert@cs.ucla.edu>
4009
bbc51b15
PE
4010 * sound.c: Integer cleanups.
4011 Remove unnecessary forward decls.
4012 (struct sound_device): The 'file' member is now a Lisp_Object, not
4013 a char *, so that we needn't invoke alloca on a huge size.
4014 (Fplay_sound_internal): Adjust to this.
4015 (string_default): New function.
4016 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
4017 Use it to adjust to the struct sound_device change.
4018 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
4019 (be2hs) [0]: Remove.
4020
178ba3e6
PE
4021 * syntax.c (skip_chars): Don't use uninitialized storage
4022 when searching a multibyte buffer for characters that are not in a
4023 unibyte string that contains non-ASCII characters.
4024
69f60cdc
JD
40252013-06-18 Jan Djärv <jan.h.d@swipnet.se>
4026
4027 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
4028 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
4029
0d6224d4
PE
40302013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4031
4032 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
4033
3c542890
KH
40342013-06-18 Kenichi Handa <handa@gnu.org>
4035
f7e3f7cd
KH
4036 * font.c (Ffont_spec): Signal an error for an invalid font name
4037 (Bug#14648).
3c542890 4038
9349e5f7
PE
40392013-06-18 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
4042 In particular this ports to 32-bit sparc Sun cc.
4043 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
4044 array with a dummy element at specpdl[-1], so that its address can
4045 be taken portably.
4046 (unbind_to): Do not copy the binding; not needed, now that we
4047 copy old_value in the one place where the copy is needed.
4048 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
4049 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
4050 (union specbinding): Rename from struct specbinding. Redo layout
4051 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
4052 which is not portable. With Sun C 5.12 32-bit sparc, the
4053 declaration causes nargs to be an unsigned bitfield, a behavior
4054 that the C standard allows; but Emacs wants nargs to be signed.
4055 The overall type is now a union of structures rather than a
4056 structure of union of structures, and the 'kind' member is now a
4057 bitfield, so that the overall type doesn't grow. All uses changed.
4058 * process.c (Fmake_serial_process): Remove unnecessary initialization.
4059
0a4df6a5
PE
40602013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4061
ec6ecaad
PE
4062 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
4063 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
4064
0a4df6a5
PE
4065 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
4066
7bfe8dbc
EZ
40672013-06-17 Eli Zaretskii <eliz@gnu.org>
4068
4069 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
4070 unless we know that the window w's frame is a frame object.
4071 Another attempt at solving bug#14062 and bug#14630.
4072
708e05f6
LMI
40732013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
4074
4075 * textprop.c (property_set_type): New enum.
4076 (add_properties): Allow appending/prepending text properties.
4077 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 4078 (Fadd_text_properties): Move all the code into
708e05f6
LMI
4079 add_text_properties_1.
4080 (Fadd_face_text_property): New function that calls
4081 add_text_properties_1.
4082
84575e67
PE
40832013-06-17 Paul Eggert <eggert@cs.ucla.edu>
4084
4085 Move functions from lisp.h to individual modules when possible.
4086 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
4087 * alloc.c (XFLOAT_INIT, set_symbol_name):
4088 * buffer.c (CHECK_OVERLAY):
4089 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
4090 (set_char_table_parent):
4091 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
4092 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
4093 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
4094 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
4095 (set_blv_valcell):
4096 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
4097 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
4098 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
4099 (backtrace_args, backtrace_debug_on_exit):
4100 * floatfns.c (CHECK_FLOAT):
4101 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
4102 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
4103 (set_hash_hash, set_hash_hash_slot, set_hash_index)
4104 (set_hash_index_slot):
4105 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
4106 * marker.c (CHECK_MARKER):
4107 * textprop.c (CHECK_STRING_OR_BUFFER):
4108 * window.c (CHECK_WINDOW_CONFIGURATION):
4109 Move here from lisp.h, and make these functions static rather than
4110 extern inline.
4111 * buffer.c (Qoverlayp):
4112 * data.c (Qsubrp):
4113 * fns.c (Qhash_table_p):
4114 * window.c (Qwindow_configuration_p):
4115 Now static.
4116 * lisp.h: Remove the abovementioned defns and decls.
4117
44e18199 4118 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
4119 In lisp.h, prefer functions to function-like macros, and
4120 constants to object-like macros, when either will do. This:
4121 . simplifies use, as there's no more need to worry about
4122 arguments' side effects being evaluated multiple times.
4123 . makes the code easier to debug on some platforms.
4124 However, when using gcc -O0, keep using function-like macros
4125 for a few critical operations, for performance reasons.
4126 This sort of thing isn't needed with gcc -Og, but -Og
4127 is a GCC 4.8 feature and isn't widely-enough available yet.
4128 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4129 Remove enum lsb_bits; no longer needed.
4130 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4131 * buffer.c (Qoverlap):
4132 * data.c (Qsubrp):
4133 * fns.c (Qhash_table_p):
4134 Now extern, so lisp.h can use these symbols.
4135 * dispextern.h: Include character.h, for MAX_CHAR etc.
4136 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4137 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4138 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4139 (GLYPH_CODE_P): Move here from lisp.h.
4140 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4141 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4142 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4143 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4144 XUNTAG now returns void *.
4145 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4146 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4147 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4148 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4149 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4150 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4151 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4152 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4153 New macros, renamed from their sans-lisp_h_ counterparts.
4154 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4155 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4156 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4157 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4158 If compiling via GCC without optimization, define these as macros
4159 in addition to inline functions.
4160 To disable this, compile with -DINLINING=0.
4161 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4162 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4163 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4164 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4165 (INTMASK, VALMASK): Now macros, since static values cannot be
4166 accessed from extern inline functions.
4167 (VALMASK): Also a constant, for benefit of old GDB.
4168 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4169 is INTEGERP, which can fold it in.
5165d44a 4170 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4171 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4172 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4173 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4174 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4175 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4176 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4177 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4178 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4179 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4180 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4181 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4182 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4183 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4184 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4185 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4186 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4187 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4188 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4189 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4190 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4191 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4192 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4193 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4194 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4195 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4196 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4197 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4198 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4199 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4200 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4201 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4202 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4203 Now functions.
4204 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4205 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4206 (VALMASK): Define in one place rather than in two, merging the
4207 USE_LSB_TAG parts; this is simpler.
4208 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4209 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4210 Move up, to avoid use before definition.
4211 Also include "globals.h" earlier, for the same reason.
4212 (make_natnum): New function.
4213 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4214 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4215 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4216 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4217 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4218 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4219 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4220 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4221 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4222 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4223 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4224 (Qwindow_configuration_p, Qimage): New forward declarations.
4225 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4226 (STRING_COPYIN): Remove; unused.
4227 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4228 (xcar_addr, xcdr_addr): New functions. All uses changed.
4229 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4230 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4231 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4232 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4233 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4234 (TYPE_RANGED_INTEGERP): Simplify.
4235 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4236 (setlocale, fixup_locale, synchronize_system_messages_locale)
4237 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4238 Now empty functions, not macros.
4239 (functionp): Return bool, not int.
4240 * window.c (Qwindow_configuration_p): Now extern,
4241 so window.h can use it.
4242 * window.h (Qwindowp): Move decl back to lisp.h.
4243
9583ec36
EZ
42442013-06-15 Eli Zaretskii <eliz@gnu.org>
4245
4246 * xdisp.c (Fline_pixel_height): New function, required for solving
4247 bug #14567.
4248
210272ce
PE
42492013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4252
de0503df
SM
42532013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4254
4255 * lread.c (syms_of_lread):
4256 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4257
afbfe143
KD
42582013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4259
4260 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4261
d177e213
XF
42622013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4263
4264 * fileio.c (expand_file_name): Doc fix.
4265
05e3e412
PE
42662013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4267
f7394b12
PE
4268 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4269 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4270 Wait for self, not for 0. This can't hurt on GNU or similar
4271 system, and may help with Cygwin.
4272
05e3e412
PE
4273 * keyboard.c: Don't use PROP (...) as an lvalue.
4274 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4275 Use set_prop (A, B), not PROP (A) = B.
4276
17dd3097
EZ
42772013-06-10 Eli Zaretskii <eliz@gnu.org>
4278
4279 * xdisp.c (get_it_property): Use it->window instead of generating
4280 a Lisp object from it->w.
4281
52fab9c9
EZ
42822013-06-09 Eli Zaretskii <eliz@gnu.org>
4283
4284 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4285 get-char-property the window that is being rendered, instead of
4286 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4287 (compute_display_string_pos): When W is NULL, use the current
4288 buffer as the object to pass to get-char-property.
4289 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4290 pointer member of the bidi iterator, since no window is pertinent
4291 to this function.
52fab9c9 4292
5bf97bfc
EZ
42932013-06-08 Eli Zaretskii <eliz@gnu.org>
4294
4295 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4296 being displayed, and pass it to compute_display_string_pos.
4297 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4298 (bidi_paragraph_init): All callers changed.
4299
4300 * xdisp.c (init_from_display_pos, init_iterator)
4301 (handle_single_display_spec, next_overlay_string)
4302 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4303 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4304 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4305 (compute_display_string_pos): Accept additional argument, the
4306 window being displayed, and pass it to Fget_char_property.
4307 (Bug#14575)
4308
4309 * dispextern.h (struct bidi_it): New member w, the window being
4310 displayed.
4311 (compute_display_string_pos): Adjust prototype.
4312
5de0e011
JD
43132013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4314
e7b41c4c 4315 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4316
4317 * process.c (wait_reading_process_output): Check for NS before GLIB.
4318 GLIB may be linked in due to rsvg, but ns_select must be called.
4319
5de0e011
JD
4320 * xgselect.c (xg_select): Remove call to window_system_available
4321 and g_main_context_pending at the top, so Gdk events (i.e. file
4322 notify) are processed when Emacs is started with -nw.
4323
a822acff
EZ
43242013-06-07 Eli Zaretskii <eliz@gnu.org>
4325
4326 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4327 (ctagsfiles3): New variable, includes only *.m files.
4328 (TAGS): Use an explicit language name in the regular expressions,
4329 to avoid transformation of '/SOMETHING' by MSYS to
4330 'c:\MSYS\SOMETHING'.
4331
6c0a9ed1
RC
43322013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4333
4334 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4335
9ef6111b
EZ
43362013-06-06 Eli Zaretskii <eliz@gnu.org>
4337
4338 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4339 still need to set the mouse pointer shape and activate help-echo.
4340 (Bug#14558)
4341
7d300d64
PE
43422013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 A few porting etc. fixes for the new file monitor code.
4345 See the thread containing
4346 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4347 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4348 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4349 (dir_monitor_callback, Fgfile_rm_watch):
4350 Use assq_no_quit instead of Fassoc, for speed.
4351 (dir_monitor_callback, Fgfile_rm_watch):
4352 eassert that the monitor is a fixnum.
4353 (dir_monitor_callback): No need for CDR_SAFE.
4354 Simplify building of lisp with alternative tails.
4355 (Fgfile_add_watch, Fgfile_rm_watch):
4356 Do not assume glib functions set errno reliably on failure.
4357 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4358 and signal an error otherwise.
4359 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4360 Use Fdelq instead of Fdelete, for speed.
4361
817ebfcf
EZ
43622013-06-05 Eli Zaretskii <eliz@gnu.org>
4363
4364 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4365 don't insist on being invoked on a highlighted tool-bar button.
4366 Avoids losing tool-bar functionality when mouse-highlight is nil.
4367 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4368 Don't highlight when mouse-highlight is nil.
4369 (note_mouse_highlight): When mouse-highlight is nil, don't return
4370 right away; instead, run tool-bar and mode-line highlight
4371 subroutine, clear any existing highlight, and revert the mouse
4372 pointer to its default shape. (Bug#14558)
4373
55577e7c
SM
43742013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4375
4376 * lisp.mk (lisp): Add prog-mode.el.
4377
f019a684
PE
43782013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4381 * process.c (dummy_handler): New function.
4382 (lib_child_handler): New static var.
4383 (handle_child_signal): Invoke it.
4384 (catch_child_signal): If a library has set up a signal handler,
4385 save it into lib_child_handler.
4386 (init_process_emacs): If using glib and not on Windows, tickle glib's
4387 child-handling code so that it initializes its private SIGCHLD handler.
4388 * syssignal.h (SA_SIGINFO): Default to 0.
4389 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4390 31; it should no longer be needed now.
4391
90db8702
MA
43922013-06-05 Michael Albinus <michael.albinus@gmx.de>
4393
4394 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4395
4396 * gfilenotify.c (globals_of_gfilenotify): New function.
4397 (syms_of_gfilenotify): Move global initialization there.
4398
4399 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4400
bfa3acd6
SM
44012013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4402
4403 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4404 * keyboard.c (menu_bar_items, tool_bar_items):
4405 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4406 not override local keymaps any more.
4407
ba59bd80
EZ
44082013-06-04 Eli Zaretskii <eliz@gnu.org>
4409
4410 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4411
7f203aa1
EZ
44122013-06-03 Eli Zaretskii <eliz@gnu.org>
4413
9337e206
EZ
4414 * w32console.c (initialize_w32_display): Return the dimensions of
4415 the console window via 2 additional arguments, not via the current
4416 frame. This avoids crashes due to overrunning the bounds of
4417 frame's decode_mode_spec_buffer, which is not resized following
4418 the change of the frame dimensions from the initial 10x10.
4419
4420 * w32term.h (w32_initialize_display_info): Adjust prototype.
4421
4422 * term.c (init_tty): Take dimensions of the frame from the values
4423 returned by initialize_w32_display.
4424
7f203aa1
EZ
4425 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4426 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4427 (LIBES): Add $(GFILENOTIFY_LIBS).
4428
4429 * w32inevt.c (handle_file_notifications): Add dummy implementation
4430 for !HAVE_W32NOTIFY.
4431
4432 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4433
55a87246
JD
44342013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4435
4436 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4437
4438 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4439
4440 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4441
3d5ee10a
PE
44422013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4443
4444 Fix minor problems found by static checking.
4445 * data.c (pure_write_error):
4446 Use xsignal2, not Fsignal, as Fsignal might return.
4447 * eval.c (set_backtrace_debug_on_exit): Now static.
4448 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4449 No longer inline. EXTERN_INLINE is needed only for functions
4450 defined in .h files. Reindent function header as per GNU style.
4451 (backtrace_p, backtrace_top, backtrace_next):
4452 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4453 compiler or linker. Add extern decls to pacify gcc -Wall.
4454 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4455 Now static.
4456 * frame.c (free_monitors): Define only on platforms that need it.
4457 * nsterm.m (ns_term_init):
4458 * process.c (catch_child_signal):
4459 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4460 defined on all porting targets these days.
4461 * process.c, process.h (catch_child_signal):
4462 Make it extern only if NS_IMPL_GNUSTEP is defined.
4463
e2d8a6f0
EZ
44642013-06-03 Eli Zaretskii <eliz@gnu.org>
4465
4466 * w32.c (gettimeofday): Make the signature identical to prototype
4467 in nt/inc/sys/time.h.
4468
a8a7c5f6
SM
44692013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4470
4471 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4472 .gdbinit.
4473
4474 * keyboard.c (safe_run_hooks_error): Improve error message.
4475
4476 * data.c (pure_write_error): Add `object' argument.
4477 * puresize.h (CHECK_IMPURE): Use it.
4478
c9628c79
MA
44792013-06-03 Michael Albinus <michael.albinus@gmx.de>
4480
4481 * Makefile.in (NOTIFY_OBJ): New variable.
4482 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4483
4484 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4485 Call syms_of_gfilenotify.
4486
4487 * gfilenotify.c: New file.
4488
4489 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4490 and Qfile_w32notify.
4491 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4492 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4493
4494 * lisp.h: Declare syms_of_gfilenotify.
4495
4496 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4497
2f592f95
SM
44982013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4499
4500 Merge the specpdl and backtrace stacks. Make the structure of the
4501 specpdl entries more obvious via a tagged union of structs.
4502 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4503 (enum specbind_tag): New enum.
4504 (struct specbinding): Make it a tagged union of structs.
4505 Add a case for backtrace records.
4506 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4507 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4508 (backtrace_debug_on_exit): New accessors.
4509 (struct backtrace): Remove.
4510 (struct catchtag): Remove backlist field.
4511 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4512 Move to eval.c.
4513 (Flocal_variable_p): Speed up the common case where the binding is
4514 already loaded.
4515 * eval.c (backtrace_list): Remove.
4516 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4517 (set_backtrace_args, set_backtrace_nargs)
4518 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4519 (backtrace_next): New functions.
4520 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4521 (unwind_to_catch, internal_lisp_condition_case)
4522 (internal_condition_case, internal_condition_case_1)
4523 (internal_condition_case_2, internal_condition_case_n): Don't bother
4524 with backtrace_list any more.
4525 (Fsignal): Adjust to new backtrace format.
4526 (grow_specpdl): Move up.
4527 (record_in_backtrace): New function.
4528 (eval_sub, Ffuncall): Use it.
4529 (apply_lambda): Adjust to new backtrace format.
4530 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4531 data.c.
4532 (specbind): Adjust to new specpdl format. Simplify.
4533 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4534 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4535 backtrace format.
4536 (mark_backtrace): Remove.
4537 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4538 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4539 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4540 Use mark_specpdl.
4541 * profiler.c (record_backtrace): Use get_backtrace.
4542 (handle_profiler_signal): Use backtrace_top_function.
4543 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4544 accessor functions.
4545
c0342369
JD
45462013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4547
4548 * process.h (catch_child_signal): Declare.
4549
4550 * process.c (catch_child_signal): New function.
4551 (init_process_emacs): Call it.
4552
4553 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4554 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4555 NS_IMPL_COCOA.
4556 (x_set_cursor_type): Remove declaration.
4557 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4558 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4559 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4560 (ns_get_color): Use F suffix on float.
4561 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4562 (ns_get_rgb_color): Remove.
4563 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4564 (note_mouse_movement): x and y are CGFloat.
4565 (ns_draw_fringe_bitmap): Remove unused rowY.
4566 Change #if to COCOA && >= 10_6.
4567 (ns_draw_window_cursor): Remove unused overspill.
4568 (ns_draw_underwave): width and x are EamcsCGFloat.
4569 (ns_draw_box): thickness is CGFloat.
4570 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4571 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4572 if not in main thread.
4573 (ns_get_pending_menu_title, ns_check_menu_open)
4574 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4575 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4576 (sendFromMainThread:): New method.
4577 (changeFont:): size is CGFloat.
4578 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4579 Disable warning about permanent text.
4580 (characterIndexForPoint:): Adjust return type depending on GNUStep
4581 version.
4582 (mouseDown:): delta is CGFloat.
4583 (updateFrameSize): Remove unised variable f.
4584 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4585 Cast float to EmacsCGFloat.
4586 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4587 also to -1 when restoring.
4588 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4589 inside NS_IMPL_COCOA.
4590 (toggleFullScreen:): Put call to toggleFullScreen inside
4591 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4592 (setPosition:portion:whole:): por is CGFloat.
4593 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4594 (mouseDown:): Use CGFloat.
4595 (mouseDragged:): Remove unised variable edge.
4596 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4597
4598 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4599 of CGFloat differs.
4600 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4601 when NS_IMPL_GNUSTEP.
4602 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4603 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4604 (EmacsToolbar): Add clearAll. Add tag argument to
4605 addDisplayItemWithImage.
4606 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4607
4608 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4609
4610 * nsmenu.m (ns_update_menubar): Make static.
4611 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4612 (fillWithWidgetValue:): Add cast to SEL for setAction.
4613 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4614 (update_frame_tool_bar): Update code for GNUStep.
4615 (clearAll): New method.
4616 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4617 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4618 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4619 call to insertItemWithItemIdentifier.
4620 (validateVisibleItems): Fix indentation.
4621 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4622 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4623 UtilityWindow to aStyle, remove call to setStyleMask.
4624
4625 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4626
4627 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4628 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4629 Use F suffix on floats.
4630 (ns_char_width): Returns CGFloat.
4631 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4632 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4633 DPSxshow.
4634 (ns_glyph_metrics): CGFloat instead of float.
4635
a0eb10b3
JB
4636 * nsfns.m (x_set_foreground_color, x_set_background_color):
4637 Use EmacsCGFloat.
4638 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4639 remove unused variables.
4640 (Fns_read_file_name): Keep track if panel is for save.
4641 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4642 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4643 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4644 Just return the input if GNUStep.
c0342369
JD
4645 (x_screen_planes): Remove.
4646 (Fxw_color_values): Use EmacsCGFloat
4647 (Fns_display_monitor_attributes_list): Only get screen number for
4648 Cocoa.
ef099a94 4649 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4650 EmacsSavePanel.
4651 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4652 ns_directory_from_panel.
4653
da9aff11
PE
46542013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4655
4656 * process.c (handle_child_signal): Also use WCONTINUED.
4657 This is so that list-processes doesn't mistakenly list the process
4658 as stopped, when the process has actually been continued and is
4659 now running.
4660
0e64479a
PE
46612013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4662
fc186a96
PE
4663 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4664 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4665 not already configured.
4666
0e64479a
PE
4667 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4668
38b787fa
EZ
46692013-05-29 Eli Zaretskii <eliz@gnu.org>
4670
4671 * Makefile.in (mostlyclean): Remove *.res files.
4672
22513e52
SM
46732013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4674
4675 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4676 a buffer (bug#8447).
4677
6ef3db10
EZ
46782013-05-27 Eli Zaretskii <eliz@gnu.org>
4679
4680 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4681 display vector, and we backtrack, handle the case that the
4682 previous character position is also displayed from a display
4683 vector or covered by a display string or image. (Bug#14476)
4684
6799bb26
JD
46852013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4686
4687 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4688 (struct MonitorInfo, free_monitors): Remove.
4689 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4690 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4691 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4692 Qframes, Qsource.
4693
4694 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4695 (struct MonitorInfo, free_monitors): Remove.
4696 (ns_screen_name): Make static.
4697 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4698 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4699 Qframes, Qsource.
4700
4701 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4702 (struct MonitorInfo): New struct.
4703 (free_monitors, make_monitor_attribute_list): Declare.
4704
22513e52
SM
4705 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4706 New Lisp_Object:s.
6799bb26
JD
4707 (free_monitors, make_monitor_attribute_list): New functions.
4708 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4709 Qsource.
4710
38cd43eb
XF
47112013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4712
4713 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4714
2af0948d
SM
47152013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4716
a7eb9b0f
SM
4717 * keyboard.c: Apply keyboard decoding only to events that come directly
4718 from the tty, not from unread-command-events (bug#14368).
4719 (read_event_from_main_queue): New function, extracted from read_char).
4720 (read_decoded_char): Remove.
4721 (read_decoded_event_from_main_queue): New function to replace it.
4722 (read_char): Use it.
4723 (read_key_sequence): Use read_char rather than read_decoded_char.
4724
2af0948d
SM
4725 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4726
1413e9a5
BR
47272013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4728
4729 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4730
e6d2f155
KH
47312013-05-22 Kenichi Handa <handa@gnu.org>
4732
4733 The following changes are to fix the setting of
4734 buffer-file-coding-system on, for instance, C-x RET c unix RET
4735 _FILE_OF_DOS_EOL_TYPE_ RET.
4736
4737 * coding.h (struct coding_system): New member detected_utf8_chars.
4738
4739 * coding.c (detect_coding_utf_8): Count characters and check EOL
4740 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4741 BOM is there.
4742 (setup_coding_system): Do not initialize coding->head_ascii.
4743 (check_ascii): Do not set coding->eol_seen but update it. Do not
4744 call adjust_coding_eol_type here.
1413e9a5
BR
4745 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4746 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4747 of the found coding-system.
4748 (decode_coding_gap): Cancel previous change. Utilize the
4749 character numbers counted by detect_coding_utf_8. Fix detection
4750 of BOM for utf-8.
4751
ab56a6f4 47522013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4753
4754 * search.c (looking_at_1): Only set last_thing_searched if the match
4755 changed the match-data (bug#14281).
4756
ecc3c6ed
DA
47572013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4758
4759 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4760 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4761 (move_it_vertically_backward): Likewise.
4762
5ba8bf35
YM
47632013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4764
4765 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4766 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4767 (Fx_display_mm_width, Fx_display_mm_height):
4768 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4769
91e8418b 4770 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4771 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4772 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4773 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4774 (Fx_display_backing_store, Fx_display_visual_class)
4775 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4776 (Fx_display_grayscale_p, Fx_display_pixel_width)
4777 (Fx_display_pixel_height, Fx_display_planes)
4778 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4779 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4780 (Fx_display_mm_width, Fx_display_mm_height)
4781 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4782 height for all physical monitors as in X11.
4783
fc30d803
SM
4784 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4785 Return pixel width or height for all physical monitors as in X11.
91e8418b 4786
31ff141c
PE
47872013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4788
4789 Port --enable-gcc-warnings to clang.
4790 * bytecode.c (exec_byte_code):
4791 * regex.c:
4792 Redo diagnostic pragmas to pacify clang, too.
4793 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4794 * editfns.c (Fencode_time):
4795 * fileio.c (file_accessible_directory_p):
4796 * font.c (font_unparse_xlfd):
4797 Use '&"string"[index]' instead of '"string" + (index)'.
4798 * undo.c (user_error): Remove; unused.
4799
df065a0b
EZ
48002013-05-16 Eli Zaretskii <eliz@gnu.org>
4801
04d360e7
EZ
4802 * insdel.c (insert_1_both): Document the arguments, instead of
4803 referring to insert_1, which no longer exists.
4804
5bb98290
EZ
4805 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4806 some window, increment windows_or_buffers_changed, so that
4807 *Messages* display in that window is updated. (Bug#14408)
4808
df065a0b
EZ
4809 * w32.c: Include epaths.h.
4810 (init_environment): Use cmdproxy.exe without leading directories.
4811 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4812 case.
4813 (gettimeofday): Adjust signature and return value to Posix
4814 expectations.
4815
4816 * unexw32.c (open_output_file): Delete the existing emacs.exe
4817 before creating it, to break the hard link to the versioned
4818 executable.
4819
4820 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4821 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4822 (FIRSTFILE_OBJ): New variables.
4823 (W32_RES): Rename to EMACSRES. All users changed.
4824 (base_obj): Use $(CM_OBJ).
4825 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4826 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4827 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4828 $(W32_RES_LINK) before $(LIBES).
4829 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4830
1aa8d505
SM
48312013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4832
6e911150
SM
4833 * makefile.w32-in (DOC): Use just "DOC".
4834
4835 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4836
1aa8d505
SM
4837 * process.c: Export default filters and sentinels to Elisp.
4838 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4839 New constants.
4840 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4841 (Fset_process_sentinel, Fformat_network_address):
4842 Default to them instead of nil.
4843 (server_accept_connection): Sentinels can't be nil any more.
4844 (read_and_dispose_of_process_output): New function, extracted from
4845 read_process_output.
4846 (read_process_output): Use it; filters can't be nil.
4847 (Finternal_default_process_filter): New function, extracted from
4848 read_process_output.
4849 (exec_sentinel_unwind): Remove function.
4850 (exec_sentinel): Don't zilch sentinel while running.
4851 (status_notify): Sentinels can't be nil.
4852 (Finternal_default_process_sentinel): New function extracted from
4853 status_notify.
4854 (setup_process_coding_systems): Default filter is not nil any more.
4855 (syms_of_process): Export new Elisp functions and initialize
4856 new constants.
4857 * lisp.h (make_lisp_proc): New function.
4858
5ac2eb34
SM
48592013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4860
4861 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4862
eda9c7d7
EZ
48632013-05-14 Eli Zaretskii <eliz@gnu.org>
4864
4865 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4866 unless we know that the window w is a leaf window.
4867 Another attempt at solving bug#14062.
eda9c7d7 4868
8fdeaad5
JD
48692013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4870
4871 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4872 fdesc (Bug#14375).
4873
44aa9ee6
PE
48742013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4875
4876 * image.c (gif_load): Check that subimages fit (Bug#14345).
4877
759fd763
SM
48782013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4879
4880 * lread.c (skip_dyn_eof): New function.
4881 (read1): Use it to skip the end of a file in response to #@00.
4882
4883 * doc.c (get_doc_string): Slightly relax the sanity checking.
4884
4465bfb4
JD
48852013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4886
4887 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4888 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4889 (MonitorInfo): New struct.
4890 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4891 (Fns_display_monitor_attributes_list): New functions.
4892 (display-usable-bounds): Remove.
4893 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4894 Qsource.
4895
7583e2a0
PE
48962013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4897
4898 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4899 (GTK_CHECK_VERSION): New macro, if not already defined.
4900 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4901 replaced by GTK_CHECK_VERSION.
4902
ad75d77e
PE
49032013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 * xterm.h (GTK_PREREQ): New macro.
4906 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4907 to use this macro instead, for consistency and clarity.
4908
07525f77
EZ
49092013-05-08 Eli Zaretskii <eliz@gnu.org>
4910
4911 * xdisp.c (row_for_charpos_p): New function, with code of
4912 cursor_row_p, but accepts an additional argument CHARPOS instead
4913 of using a hardcoded PT.
4914 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4915 (row_containing_pos): Call row_for_charpos_p instead of partially
4916 doing the same. Fixes cursor positioning under longlines-mode
4917 when longlines-show-effect includes more than one newline, when
4918 moving the cursor vertically up.
4919
d901fc8d
JB
49202013-05-08 Juanma Barranquero <lekktu@gmail.com>
4921
4922 * makefile.w32-in (ACL_H): New macro.
4923 ($(BLD)/fileio.$(O)): Update dependencies.
4924
f269bc61
PE
49252013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4926
e7b41c4c 4927 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4928 * Makefile.in (LIB_ACL): New macro.
4929 (LIBACL_LIBS): Remove.
4930 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4931 * fileio.c: Include <acl.h>.
4932 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4933 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4934 !acl_errno_valid.
4935 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4936 it ourselves.
4937
f269bc61
PE
4938 * unexelf.c: Don't assume ElfW (Half) fits in int.
4939 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4940 when dealing with ElfW (Half) values, since they can exceed 2**31
4941 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4942 (entry_address): Omit unused NUM arg. All uses changed.
4943
a261c53e
JL
49442013-05-07 Juri Linkov <juri@jurta.org>
4945
4946 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4947 to the string converted from number with `Fnumber_to_string'.
4948 (Bug#14254)
4949
2b66427d
PE
49502013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4951
4952 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4953 This fixes a problem introduced by my previous change.
4954
15acfe41
GM
49552013-05-07 Glenn Morris <rgm@gnu.org>
4956
4957 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4958
5ea03bf5
JD
49592013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4960
4961 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4962
e0c9d565
PE
49632013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4964
4965 Static checking by GCC 4.8.0.
4966 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4967 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4968 (x_get_monitor_attributes_fallback)
4969 (x_get_monitor_attributes_xinerama)
4970 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4971 Define only if USE_GTK.
4972 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4973 (x_get_monitor_attributes_fallback): Omit unused locals.
4974 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4975 Use double, not float, to avoid mixed-mode floating point arithmetic.
4976
4e3f9230
YM
49772013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4978 Jan Djärv <jan.h.d@swipnet.se>
4979
4980 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4981 (XINERAMA_CFLAGS): New macros.
4982 (ALL_CFLAGS, LIBES): Use them.
4983
4984 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4985 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4986 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4987 (syms_of_xfns): DEFSYM them.
4988 (struct MonitorInfo): New struct.
4989 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4990 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4991 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4992 (x_get_monitor_attributes_xinerama): New functions.
4993 (Fx_display_monitor_attributes_list): New primitive.
4994 (syms_of_xfns): Defsubr it.
4995
4996 * xterm.h (x_display_info): Add Xatom_net_workarea and
4997 Xatom_net_current_desktop.
4998
4999 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
5000 and dpyinfo->Xatom_net_current_desktop.
5001
05839b6a
EZ
50022013-05-06 Eli Zaretskii <eliz@gnu.org>
5003
5004 * xdisp.c (pos_visible_p): Use the special code for finding the
5005 beginning of a display property or overlay for any "replacing"
5006 display property, not just for display strings. This solves
5007 incorrect reporting of position by posn-at-point. (Bug#14241)
5008
dc4a2ee0
PE
50092013-05-06 Paul Eggert <eggert@cs.ucla.edu>
5010
5ee94506
PE
5011 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
5012 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
5013 Verify that ElfW (Half) fits in int.
5014 (fatal): Use same signature as lisp.h.
5015 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
5016 configure and build with -DUNEXELF_DEBUG without worrying about
5017 other modules that use DEBUG.
5018 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
5019 possibly-wide integers now uses it instead of plain fprintf.
5020 (entry_address): New function, which avoids problems with 32-bit
5021 overflow on 64-bit hosts.
5022 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
5023 (round_up): Don't assume the remainder fits in int.
5024 (find_section): Use bool for boolean. Simplify debug code.
5025 (unexec): Don't assume file sizes fit in int or size_t.
5026 Omit unnecessary trailing newline in 'fatal' format.
5027 Use strerror rather than outputting decimal error number.
5028 Remove unused code when emacs is not defined;
5029 this file relies on Emacs now.
5030 Don't assume e_phnum and e_shnum are positive.
5031
dc4a2ee0
PE
5032 * regex.c: Fix problems when DEBUG is defined.
5033 (extract_number, extract_number_and_incr): Define regardless of
5034 whether DEBUG is defined; that's simpler and makes the code less
5035 likely to go stale in the normal case when DEBUG is not defined.
5036 Return int rather than taking an int * arg. All callers changed.
5037 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
5038 Remove, replacing with ...
5039 (DEBUG_PRINT): New macro. All callers changed.
5040 (DEBUG_COMPILES_ARGUMENTS): New macro.
5041 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
5042 (print_compiled_pattern, print_double_string) [DEBUG]:
5043 Use prototype rather than old-style definition.
5044 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
5045 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
5046 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
5047 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
5048 Don't assume ptrdiff_t, size_t, and long are the same width as int.
5049 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
5050 This matters only when DEBUG is defined.
5051
14c7ed05
EZ
50522013-05-05 Eli Zaretskii <eliz@gnu.org>
5053
5054 * xdisp.c (set_iterator_to_next): Set the
5055 ignore_overlay_strings_at_pos_p flag only if we are _really_
5056 iterating over an overlay string, as indicated by the
5057 current.overlay_string_index member. (Bug#14306)
5058
e6076b1b
JD
50592013-05-05 Jan Djärv <jan.h.d@swipnet.se>
5060
5061 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
5062 to where it is used, to avoid autorelease issues (Bug#14050).
5063
cbee2131
PE
50642013-05-05 Paul Eggert <eggert@cs.ucla.edu>
5065
5066 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
5067 * fileio.c (syms_of_fileio): Implement this.
5068 * filelock.c (create_lock_file): If symbolic links don't work, so
5069 we use a regular file as a lock file, do not fsync the lock file;
5070 it's not needed.
5071
30c7e542
SM
50722013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5073
5074 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
5075 (syms_of_minibuf): Adjust accodingly.
5076 * lread.c (Fread):
5077 * callint.c (Fcall_interactively): Adjust calls accordingly.
5078
5bebd186
EZ
50792013-05-04 Eli Zaretskii <eliz@gnu.org>
5080
5081 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
5082 w->contents is a buffer before computing everything else.
5083 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
5084
5085 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
5086 assertion violations. (Bug#14062)
5087
0fb0a4f3
DR
50882013-05-01 David Reitter <david.reitter@gmail.com>
5089
5090 * nsfns.m (ns_tooltip): Initialize.
5091
9e63b4a5
EZ
50922013-04-28 Eli Zaretskii <eliz@gnu.org>
5093
5094 * coding.c (decode_coding_gap): Don't remove the character before
5095 a newline unless it's a CR character. (Bug#14287)
5096
ad60824e
DN
50972013-04-28 Dan Nicolaescu <dann@gnu.org>
5098
5099 * dispextern.h (struct face): Move enum face_underline_type
5100 earlier so that bitfields can be in the same word.
5101
edbdcec0
JD
51022013-04-28 Jan Djärv <jan.h.d@swipnet.se>
5103
5104 * nsfns.m (handlePanelKeys): New function.
5105 (EmacsOpenPanel:performKeyEquivalent:)
5106 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
5107 arrows/function/control and copy/paste keys (Bug#14296).
5108
0208ede7
JL
51092013-04-27 Juri Linkov <juri@jurta.org>
5110
5111 * callint.c (Fcall_interactively): Call `Qread_number' for
5112 interactive code letter `n' instead of using duplicate code.
5113 (Bug#14254)
5114
b8dd59f7
PE
51152013-04-27 Paul Eggert <eggert@cs.ucla.edu>
5116
5117 * systime.h (make_timeval): Declare as 'const'.
5118
8bd722db
KH
51192013-04-27 Kenichi Handa <handa@gnu.org>
5120
5121 * font.c (font_open_entity): Always open a font of manageable
5122 size.
5123
13d0e56f 51242013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5125
f780d632
PE
5126 Port better to AIX (Bug#14258).
5127 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5128 to pacify AIX xlc.
5129
ec509856
KH
51302013-04-24 Kenichi Handa <handa@gnu.org>
5131
5132 * coding.c (decode_coding_iso_2022): When an invalid escape
5133 sequence is encountered, reset the invocation and designation
5134 status to the safest one.
5135
84fc48e5
PE
51362013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5137
5138 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5139 Without this fix, "make distclean" leaves stamp-h1 behind.
5140
806bda47
EC
51412013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5142
5143 * w32fns.c (w32_fullscreen_rect): New function to compute the
5144 window rectangle for the given fullscreen mode.
5145 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5146 longer tunes the window size. This keeps the window's edges flush
5147 with the screen and allows the taskbar to hide itself in fullboth.
5148
5149 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5150 window decorations and uses the entire screen.
5151
5152 * w32term.h (w32_fullscreen_rect) Add prototype.
5153 (struct w32_output): Replace normal_width, normal_height,
5154 normal_top, and normal_left members with a single normal_placement
5155 struct.
5156 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5157 Remove macros.
5158 (FRAME_NORMAL_PLACEMENT): New macro.
5159
9cc2810b
JB
51602013-04-16 Juanma Barranquero <lekktu@gmail.com>
5161
5162 * minibuf.c (Ftest_completion): Silence compiler warning.
5163
fd16b54c
EZ
51642013-04-15 Eli Zaretskii <eliz@gnu.org>
5165
5166 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5167 bug#14062.
fd16b54c
EZ
5168
5169 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5170 parentheses.
5171
5172 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5173 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5174 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5175 parentheses where appropriate.
5176
9e3379a0
PE
51772013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5178
5179 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5180
ddd6b685
EZ
51812013-04-14 Eli Zaretskii <eliz@gnu.org>
5182
5183 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5184 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5185 Mention in the doc string that setting these variables takes
5186 effect only after a call to set-window-buffer. (Bug#14200)
5187
29b79ba1
EZ
51882013-04-13 Eli Zaretskii <eliz@gnu.org>
5189
5190 * indent.c (Fvertical_motion): Don't consider display strings on
5191 overlay strings as display strings on the buffer position we
5192 started from. This prevents vertical cursor motion from jumping
5193 more than one line when there's an overlay string with a display
5194 property at end of line.
5195 Reported by Karl Chen <Karl.Chen@quarl.org> in
5196 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5197
562c6ee9
SM
51982013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5199
5200 * window.c (select_window): `record_buffer' even if window is
5201 already selected (bug#14191).
5202
fcc1fe85
EZ
52032013-04-11 Eli Zaretskii <eliz@gnu.org>
5204
5205 * window.c (Fwindow_end): Test more flags, including the buffer's
5206 last_overlay_modified flag, to determine whether the window's
5207 display is really up-to-date. Prevents the function from
5208 returning a stale value. (Bug#14170)
5209 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5210 current matrix.
5211
f009190a
EZ
52122013-04-10 Eli Zaretskii <eliz@gnu.org>
5213
5214 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5215 garbaged only if it is not already the top frame on its TTY.
5216 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5217 there are GUI frames open in the same session. (Bug#13864)
5218
78ce603d
SM
52192013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5220
5221 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5222 of marking the idle timers directly.
5223
a8036e40
SM
52242013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5225
5226 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5227 tables (bug#14054).
5228
7ffe7ef6
SM
52292013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5230
5231 * window.c (select_window): Don't record_buffer while the invariant is
5232 temporarily broken (bug#14161).
5233
5234 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5235
7d9f6883
EZ
52362013-04-07 Eli Zaretskii <eliz@gnu.org>
5237
5238 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5239
5406cfd9
RF
52402013-04-07 Romain Francoise <romain@orebokech.com>
5241
5242 Ignore additional platform-specific ACL errors (Bug#13702).
5243 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5244 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5245
95c0e83b
JD
52462013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5247
5248 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5249 f->output_data.ns.
5250
876da980
PE
52512013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5252
5253 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5254 This bug was introduced by my 2013-02-25 change that simplified
5255 data_start configuration. Without this change, on GNU/Linux
5256 an Emacs configured with --enable-profiling fails immediately
5257 due to a profiler signal.
5258 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5259 with these flags. On platforms where special flags are needed
5260 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5261 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5262 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5263
7452b7bd
DA
52642013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5265
5266 Get rid of some platform-specific functions examining window
5267 system and its capabilities. This is a partial rework of the
5268 2013-04-05 change.
5269 * lisp.h (have_menus_p): Remove prototype. This function is
5270 replaced with platform-independent window_system_available.
5271 (check_window_system): Move to...
5272 * frame.h (decode_window_system_frame, window_system_available):
5273 ...here, add new prototypes.
5274 * frame.c (window_system_available, decode_window_system_frame):
5275 New functions.
5276 (check_window_system): Platform-independent now.
5277 * xterm.h (x_in_use): Remove declaration.
5278 (check_x_frame):
5279 * w32term.h (check_x_frame):
5280 * nsterm.h (check_x_frame): Remove prototypes. This function
5281 is replaced with platform-independent decode_window_system_frame.
5282 * msdos.c (have_menus_p): Remove.
5283 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5284 Remove platform-specific functions. Use check_window_system,
5285 decode_window_system_frame and check_ns_display_info where
5286 appropriate. Minor style and comment tweaks.
5287 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5288 (check_x_frame): Likewise.
5289 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5290 Likewise.
5291 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5292 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5293 * xmenu.c, xselect.c: All related users changed.
5294
251e9147
KH
52952013-04-03 Kenichi Handa <handa@gnu.org>
5296
5297 The following changes is to optimize the code for reading UTF-8
5298 files.
5299
562c6ee9 5300 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5301 changed. Check EOL format. Do not call adjust_coding_eol_type
5302 here.
5303 (check_utf_8): New function.
5304 (adjust_coding_eol_type): Do nothing if already adjusted.
5305 (detect_coding): Compare the return value of check_ascii with
5306 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5307 (decode_coding_gap): Optimize for valid UTF-8.
5308
8bc369d4
KH
53092013-03-21 Kenichi Handa <handa@gnu.org>
5310
5311 * coding.c (syms_of_coding): Cancel previous change.
5312
5313 * insdel.c (insert_from_gap): Fix previous change.
5314
73931ad1
DA
53152013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5316
5317 Consistently use platform-specific function to detect window system.
5318 * lisp.h (check_window_system): New prototype. This function is
5319 going to replace check_x, check_w32 and check_ns.
5320 (have_menus_p): Mention msdos.c in comment.
5321 * fontset.c (check_window_system_func): Remove. Adjust all users.
5322 * fontset.h (check_window_system_func): Remove prototype.
5323 * nsterm.h (check_ns):
5324 * xterm.h (check_x):
5325 * w32term.h (check_w32): Likewise.
5326 * menu.c (Fx_popup_menu): Use check_window_system.
5327 * msdos.c (check_window_system): Define for MS-DOS.
5328 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5329 * w32fns.c (check_window_system): Likewise for MS-Windows.
5330 * xfns.c (check_window_system): Likewise for X.
5331 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5332 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5333
7216e43b
PE
53342013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5335
5336 Prefer < to > in range checks such as 0 <= i && i < N.
5337 This makes it easier to visualize quantities on a number line.
5338 This patch doesn't apply to all such range checks,
5339 only to the range checks affected by the 2013-03-24 change.
5340 This patch reverts most of the 2013-03-24 change.
5341 * alloc.c (xpalloc, Fgarbage_collect):
5342 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5343 * character.c (string_escape_byte8):
5344 * charset.c (read_hex):
5345 * data.c (cons_to_unsigned):
5346 * dispnew.c (update_frame_1):
5347 * doc.c (Fsubstitute_command_keys):
5348 * doprnt.c (doprnt):
5349 * editfns.c (hi_time, decode_time_components):
5350 * fileio.c (file_offset):
5351 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5352 * font.c (font_intern_prop):
5353 * frame.c (x_set_alpha):
5354 * gtkutil.c (get_utf8_string):
5355 * indent.c (check_display_width):
5356 * keymap.c (Fkey_description):
5357 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5358 * lread.c (read1):
5359 * minibuf.c (read_minibuf_noninteractive):
5360 * process.c (wait_reading_process_output):
5361 * search.c (Freplace_match):
5362 * window.c (get_phys_cursor_glyph):
5363 * xdisp.c (redisplay_internal):
5364 * xsmfns.c (smc_save_yourself_CB):
5365 Prefer < to > for range checks.
5366 * dispnew.c (sit_for): Don't mishandle NaNs.
5367 This fixes a bug introduced in the 2013-03-24 change.
5368 * editfns.c (decode_time_components): Don't hoist comparison.
5369 This fixes another bug introduced in the 2013-03-24 change.
5370
92759988
DA
53712013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5372
5373 * frame.h (struct frame): Drop scroll_bottom_vpos
5374 member becaue all real users are dead long ago.
5375 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5376 * xdisp.c (redisplay_internal): Adjust user.
5377
9a1971bb
GM
53782013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5379
f38ab167
JD
5380 * nsmenu.m (showAtX:Y:for:): setLevel to
5381 NSPopUpMenuWindowLevel (Bug#13998).
5382
6d01f1fe
JD
53832013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5384
5385 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5386 (ns_check_pending_open_menu): Declare.
5387
5388 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5389 (x_activate_menubar): Update the menu with title that matches
5390 ns_get_pending_menu_title, and call
5391 ns_check_pending_openmenu (Bug#12698).
5392 (menuWillOpen:): New method.
5393 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5394
5395 * nsterm.m (menu_will_open_state, menu_mouse_point)
5396 (menu_pending_title): New varaibles.
5397 (ns_get_pending_menu_title, ns_check_menu_open)
5398 (ns_check_pending_open_menu): New functions.
5399
781f4782
DA
54002013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5401
5402 * indent.c (current_column_bol_cache): Remove leftover which is not
5403 used in Fmove_to_column any more.
5404 (current_column, scan_for_column): Adjust users.
5405 * keyboard.c (last_point_position_buffer, last_point_position_window):
5406 Remove leftovers which are not used for recording undo any more.
5407 (command_loop_1, syms_of_keyboard): Adjust users.
5408 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5409 redisplay_window any more.
5410 (move_it_to): Adjust user.
5411
1921c31b
JB
54122013-03-29 Juanma Barranquero <lekktu@gmail.com>
5413
5414 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5415 Update dependencies.
5416
717b8bcd
SM
54172013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5418
5419 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5420 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5421 forward references.
5422
e74aeda8
DA
54232013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5424
5425 * window.h (struct window): Replace hchild, vchild and buffer slots
5426 with the only contents slot. This is possible because each valid
5427 window may have either the child window (in vertical or horizontal
5428 combination) or buffer to display (for the leaf window). Using that,
5429 a lof of operations to traverse and/or change window hierarchies may
5430 be simplified. New member horizontal is used to distinguish between
5431 horizontal and vertical combinations of internal windows.
5432 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5433 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5434 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5435 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5436 Use contents slot, not buffer, where appropriate.
5437 (wset_combination): New function.
5438 (wset_buffer): Add eassert.
5439 (Fframe_first_window): Simplify the loop reaching first window.
5440 (Fwindow_buffer): Use WINDOW_LEAF_P.
5441 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5442 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5443 (unshow_buffer): Convert initial debugging check to eassert.
5444 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5445 (make_parent_window, window_resize_check, window_resize_apply)
5446 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5447 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5448 Adjust to match struct window changes.
5449 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5450 (mark_window_cursors_off, count_windows, get_leaf_windows)
5451 (foreach_window_1): Simplify the loop.
5452 * alloc.c (mark_object): Do not check for the leaf window because
5453 internal windows has no glyph matrices anyway.
5454 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5455 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5456 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5457 (build_frame_matrix_from_window_tree, mirror_make_current)
5458 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5459 (update_window_tree, set_window_update_flags): Simplify the loop.
5460 (sync_window_with_frame_matrix_rows): Enforce live window.
5461 Use contents slot, not buffer, where appropriate.
5462 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5463 and WINDOW_HORIZONTAL_COMBINATION_P.
5464 (make_frame_visible_1): Simplify the loop.
5465 Use contents slot, not buffer, where appropriate.
5466 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5467 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5468 (expose_window_tree): Likewise.
5469 Use contents slot, not buffer, where appropriate.
5470 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5471 to avoid deleted windows. Use contents slot instead of buffer.
5472 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5473 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5474 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5475 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5476
121ab1cd
EZ
54772013-03-28 Eli Zaretskii <eliz@gnu.org>
5478
ef454cf7
EZ
5479 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5480 identify the reasons for assertion violations in bug#14062 and
5481 similar ones.
21e930f8
EZ
5482 (Fx_show_tip): Fix compilation error under
5483 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5484
121ab1cd
EZ
5485 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5486 Reported by <rzl24ozi@gmail.com>.
5487
5c89ca24
DA
54882013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5489
5490 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5491 start marker...
562c6ee9
SM
5492 (unwind_with_echo_area_buffer): ...to restore it here.
5493 This is needed to ensure that...
5c89ca24
DA
5494 (redisplay_window): ...both window markers are valid here,
5495 which is verified by eassert.
5496 * editfns.c (save_excursion_save): Do not assume that
5497 selected_window always displays the buffer.
c7f53895
DA
5498 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5499 Fix comment.
5c89ca24 5500
f557c1b1
SM
55012013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5502
5503 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5504 the upcase table.
5505
40693bba 55062013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5507
5508 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5509
c86f791f
EZ
55102013-03-27 Eli Zaretskii <eliz@gnu.org>
5511
5512 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5513 since MinGW's w32api headers do. This avoids compiler warnings.
5514
5515 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5516 if already defined.
5517
c6e72e17
EZ
55182013-03-26 Eli Zaretskii <eliz@gnu.org>
5519
5520 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5521
54e95010
JD
55222013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5523
5524 * gtkutil.c (style_changed_cb): Check if frame is live and an
5525 X frame (Bug#14038).
5526
b88b62de
EZ
55272013-03-26 Eli Zaretskii <eliz@gnu.org>
5528
a18d7de6
EZ
5529 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5530 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5531 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5532 MinGW64.
8f5e14c8
EZ
5533 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5534 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5535
b88b62de
EZ
5536 Fix incompatibilities between MinGW.org and MinGW64 headers.
5537 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5538
5539 * w32.c (REPARSE_DATA_BUFFER): Guard with
5540 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5541
c074e458
JD
55422013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5543
5544 * xterm.c: Include X11/XKBlib.h
5545 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5546
908589fd
AS
55472013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5548
5549 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5550 written backwards.
5551 * blockinput.h (input_blocked_p): Likewise.
5552 * bytecode.c (exec_byte_code): Likewise.
5553 * callproc.c (call_process_kill, call_process_cleanup)
5554 (Fcall_process): Likewise.
5555 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5556 (Fccl_execute_on_string): Likewise.
5557 * character.c (string_escape_byte8): Likewise.
5558 * charset.c (read_hex): Likewise.
5559 * cm.c (calccost): Likewise.
5560 * data.c (cons_to_unsigned): Likewise.
5561 * dired.c (directory_files_internal, file_name_completion):
5562 Likewise.
5563 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5564 (sit_for): Likewise.
5565 * doc.c (Fsubstitute_command_keys): Likewise.
5566 * doprnt.c (doprnt): Likewise.
5567 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5568 * emacsgtkfixed.c: Likewise.
5569 * fileio.c (file_offset, Fwrite_region): Likewise.
5570 * floatfns.c (Fexpt, fmod_float): Likewise.
5571 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5572 Likewise.
5573 * font.c (font_intern_prop): Likewise.
5574 * frame.c (x_set_alpha): Likewise.
5575 * gtkutil.c (get_utf8_string): Likewise.
5576 * indent.c (check_display_width): Likewise.
5577 * intervals.c (create_root_interval, rotate_right, rotate_left)
5578 (split_interval_right, split_interval_left)
5579 (adjust_intervals_for_insertion, delete_node)
5580 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5581 (merge_interval_right, merge_interval_left, copy_intervals)
5582 (set_intervals_multibyte_1): Likewise.
5583 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5584 * keymap.c (Fkey_description): Likewise.
5585 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5586 * lread.c (openp, read_integer, read1, string_to_number):
5587 Likewise.
5588 * menu.c (ensure_menu_items): Likewise.
5589 * minibuf.c (read_minibuf_noninteractive): Likewise.
5590 * print.c (printchar, strout): Likewise.
5591 * process.c (create_process, Faccept_process_output)
5592 (wait_reading_process_output, read_process_output, send_process)
5593 (wait_reading_process_output): Likewise.
5594 * profiler.c (make_log, handle_profiler_signal): Likewise.
5595 * regex.c (re_exec): Likewise.
5596 * regex.h: Likewise.
5597 * search.c (looking_at_1, Freplace_match): Likewise.
5598 * sysdep.c (get_child_status, procfs_ttyname)
5599 (procfs_get_total_memory): Likewise.
5600 * systime.h (EMACS_TIME_VALID_P): Likewise.
5601 * term.c (dissociate_if_controlling_tty): Likewise.
5602 * window.c (get_phys_cursor_glyph): Likewise.
5603 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5604 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5605 Likewise.
5606 * xfns.c (Fx_window_property): Likewise.
5607 * xmenu.c (set_frame_menubar): Likewise.
5608 * xselect.c (x_get_window_property, x_handle_dnd_message):
5609 Likewise.
5610 * xsmfns.c (smc_save_yourself_CB): Likewise.
5611 * xterm.c (x_scroll_bar_set_handle): Likewise.
5612
2bf7d27a
DA
56132013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5614
5615 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5616 to be optional or nil. Adjust comment and convert it to docstring.
5617 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5618 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5619
a9ebfa0b
PE
56202013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5621
5622 Static checking by GCC 4.8-20130319.
5623 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5624 * process.c (Fset_process_datagram_address)
5625 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5626 * xdisp.c (get_char_face_and_encoding):
5627 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5628 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5629 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5630
4f3576ee
KB
56312013-03-24 Ken Brown <kbrown@cornell.edu>
5632
789b5e9a
KB
5633 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5634 fix compilation on 64-bit Cygwin, where underscores are not
5635 automatically prepended.
5636
4f3576ee
KB
5637 * w32term.c (w32_initialize): Silence compiler warning.
5638
b5b7745f
EZ
56392013-03-23 Eli Zaretskii <eliz@gnu.org>
5640
cdc0d0bd
EZ
5641 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5642 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5643 variables, to save and restore frame dimensions.
5644 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5645 after returning from a 'fullscreen' configuration.
5646 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5647 to avoid races between the main thread and the input thread.
5648
5649 * w32term.h (struct w32_output): New members normal_width,
5650 normal_height, normal_top, normal_left, and prev_fsmode.
5651 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5652 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5653 members of a frame.
5654
b5b7745f
EZ
5655 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5656 'fullscreen' parameter. Always record previous width and height
5657 of the frame, except when switching out of maximized modes, so
5658 that they could be restored correctly, instead of resetting to the
5659 default frame dimensions. Send SC_RESTORE command to the frame,
5660 unless we are going to send SC_MAXIMIZE, to restore the frame
5661 resize hints in the mouse pointer shown by the window manager.
5662 (Bug#14032)
5663
5664 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5665
5666 * lisp.h (get_frame_param): Adjust conditions for prototype
5667 declaration.
5668
a3454eed
KB
56692013-03-22 Ken Brown <kbrown@cornell.edu>
5670
5671 * unexcw.c: Drop unneeded inclusion of w32common.h.
5672 (report_sheap_usage): Declare.
5673 (read_exe_header): Add magic numbers for x86_64.
5674 (fixup_executable): Fix printf format specifier for unsigned long
5675 argument.
5676
5a49b79c
DA
56772013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5678
5679 * frame.h (struct frame): Put menu_bar_window under #ifdef
5680 because this member is not needed when X toolkit is in use.
5681 (fset_menu_bar_window):
5682 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5683 (free_glyphs, update_frame):
5684 * xdisp.c (expose_frame): Likewise.
5685 (display_menu_bar): Likewise. Remove redundant eassert.
5686 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5687 toolkit is in use.
5688
d6723bf7
PE
56892013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5690
7b1123d8
PE
5691 Use functions and constants to manipulate Lisp_Save_Value objects.
5692 This replaces code that used macros and strings and token-pasting.
5693 The change makes the C source a bit easier to follow,
5694 and shrinks the Emacs executable a bit.
5695 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5696 (make_save_value): Change 1st arg from string to enum. All callers
5697 changed.
5698 (INTX): Remove.
5699 (mark_object): Use if, not #if, for GC_MARK_STACK.
5700 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5701 (XSAVE_OBJECT): Now functions, not macros.
5702 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5703 the constant was never used.
5704 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5705 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5706 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5707 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5708 New constants.
5709 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5710 type3 with a single member save_type. All uses changed.
5711 (save_type, set_save_pointer, set_save_integer): New functions.
5712 * print.c (PRINTX): Remove.
5713
d6723bf7
PE
5714 * alloc.c: Remove redundant static declarations.
5715
5f24fa51
DA
57162013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5717
5718 * window.h (struct window): Convert left_col, top_line, total_lines
5719 and total_cols from Lisp_Objects to integers. Adjust comments.
5720 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5721 Remove.
5722 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5723 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5724 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5725 Adjust users where appropriate.
5726
42143acd
DA
57272013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5728
5729 * frame.h (struct frame): Drop resx and resy because the same data is
5730 available from window system-specific output context. Adjust users.
562c6ee9
SM
5731 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5732 New functions to provide defaults when no window system available.
42143acd 5733 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5734 (NUMVAL): Move from xdisp.c.
42143acd
DA
5735 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5736 (Ffont_face_attributes, Fopen_font):
5737 * image.c (gs_load):
5738 * w32font.c (fill_in_logfont):
5739 * xdisp.c (calc_pixel_width_or_height):
5740 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5741 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5742
c0a17406
KH
57432013-03-20 Kenichi Handa <handa@gnu.org>
5744
5745 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5746 to 1 (temporary workaround until a bug related to ASCII
5747 optimization is fixed).
5748
095d384d
DA
57492013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5750
5751 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5752 Signal error if window is not internal. Adjust docstring.
5753 (delete_all_child_windows): Use combination_limit to save the buffer.
5754 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5755 * print.c (syms_of_print): Initialize debugging output not here...
5756 (init_print_once): ...but in a new function here.
5757 * lisp.h (init_print_once): Add prototype.
5758 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5759
748fa866
DA
57602013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5761
5762 * window.c (window_resize_check, window_resize_apply)
5763 (window_from_coordinates, recombine_windows, set_window_buffer)
5764 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5765 (Fsplit_window_internal, Fdelete_window_internal)
5766 (freeze_window_starts): Use bool for booleans.
5767 * window.h (window_frame_coordinates, resize_frame_windows)
5768 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5769
81519fd2
SM
57702013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5771
5772 * dispnew.c (bitch_at_user): Use `user-error'.
5773
6db423a9
KB
57742013-03-17 Ken Brown <kbrown@cornell.edu>
5775
5776 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5777 as return type of image_background. (Bug#13981)
5778 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5779
8f2906f5
JD
57802013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5781
960ce480 5782 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5783 (ns_select): Don't return with result uninitialized.
960ce480 5784
8f2906f5
JD
5785 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5786 and getDirectory.
5787
81519fd2
SM
5788 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5789 New functions.
8f2906f5
JD
5790 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5791 directories. If filename is nil, get directory name (Bug#13932).
5792 Use getFilename and getDirectory.
5793 (getFilename, getDirectory): New methods for EmacsSavePanel and
5794 EmacsOpenPanel.
5795 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5796
cded56c1
PE
57972013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5798
5799 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5800
251e9147 58012013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5802
5803 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5804 (adjust_after_replace): Make it back to static. Delete the third
5805 arg text_at_gap_tail. Cancel the code for handling it.
5806
5807 * coding.h (struct coding_system): New member eol_seen.
5808
5809 * coding.c (detect_ascii): New function.
5810 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5811 when the source bytes are actually scanned. On detecting for
5812 coding_category_utf_8_auto, call detect_ascii instead of scanning
5813 source bytes directly.
5814 (produce_chars): Call insert_from_gap with the new arg 0.
5815 (encode_coding): Likewise.
5816 (decode_coding_gap): Control ASCII optimization by the variable
5817 disable_ascii_optimization instead of #ifndef .. #endif.
5818 Deccode EOL format according to coding->eol_seen.
5819 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5820 variable.
5821
8a44e6d1
KH
5822 * lisp.h (adjust_after_replace): Cancel externing it.
5823 (insert_from_gap): Adjust prototype.
5824
5f795e34
EZ
58252013-03-15 Eli Zaretskii <eliz@gnu.org>
5826
5827 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5828 FULLSCREEN_MAXIMIZED. (Bug#13935)
5829
f258b4be
DA
58302013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5831
5832 * region-cache.c (find_cache_boundary, move_cache_gap)
5833 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5834 Simplify debugging check and convert to eassert. Adjust comment.
5835 (pp_cache): Put under ENABLE_CHECKING.
5836
a5cc4dde
EZ
58372013-03-14 Eli Zaretskii <eliz@gnu.org>
5838
5839 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5840 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5841 and WM_ACTIVATEAPP.
5842 (w32fullscreen_hook): If the frame is visible, reset
5843 f->want_fullscreen flag after changing the frame size. If the
5844 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5845 (Bug#13953)
5846
3fc5e44a
DC
58472013-03-13 Daniel Colascione <dancol@dancol.org>
5848
5849 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5850 too so that these builds can use Cygwin's file conversion
5851 functions. (We've been building and linking cygw32.o all along
5852 and just not using it.)
5853
47d7532e
PE
58542013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 File synchronization fixes (Bug#13944).
5857 * Makefile.in (LIB_FDATASYNC): New macro.
5858 (LIBES): Use it.
5859 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5860 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5861 Don't worry about HAVE_FSYNC, since a substitute fsync is
5862 available if the system lacks one.
5863 (Fwrite_regin): Retry fsync if interrupted.
5864
c7ffccaf
EZ
58652013-03-13 Eli Zaretskii <eliz@gnu.org>
5866
4e2df81d 5867 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5868 activated, call w32fullscreen_hook, to make sure the new frame
5869 dimensions are in effect. (Bug#13937)
5870
8a7debc1
DA
58712013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5872
5873 * xdisp.c (init_iterator): Simplify because both character and byte
5874 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5875 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5876 character and byte positions can be obtained from marker.
8a7debc1 5877
7fd8c501
PE
58782013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5879
d9df6f40
PE
5880 Static checking by Sun C 5.12.
5881 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5882 * bytecode.c (exec_byte_code):
5883 * dispnew.c (init_display):
5884 * eval.c (error):
5885 * fileio.c (Fsubstitute_in_file_name):
5886 * keyboard.c (Fevent_convert_list):
5887 * keymap.c (Fsingle_key_description):
5888 * term.c (maybe_fatal, fatal):
5889 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5890 * xsmfns.c (Fhandle_save_session):
5891 Omit unreachable code.
5892 * keymap.c (map_keymap_char_table_item): Cast void * to
5893 a function pointer type; the C Standard requires this.
5894
7fd8c501
PE
5895 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5896 Include <sys/param.h> unconditionally, as that works elsewhere and
5897 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5898 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5899 and FreeBSD now.
5900
a020afb9 5901See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5902
5903;; Local Variables:
5904;; coding: utf-8
aac0c6e3
MR
5905;; End:
5906
ab422c4d 5907 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5908
5909 This file is part of GNU Emacs.
5910
5911 GNU Emacs is free software: you can redistribute it and/or modify
5912 it under the terms of the GNU General Public License as published by
5913 the Free Software Foundation, either version 3 of the License, or
5914 (at your option) any later version.
5915
5916 GNU Emacs is distributed in the hope that it will be useful,
5917 but WITHOUT ANY WARRANTY; without even the implied warranty of
5918 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5919 GNU General Public License for more details.
5920
5921 You should have received a copy of the GNU General Public License
5922 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.