* lisp/minibuffer.el (completion--twq-all): Try and preserve each
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bee6a2c7
DA
12013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * xfaces.c (make_face_cache): For struct face_cache, prefer
4 xmalloc to xzalloc and so avoid redundant call to memset.
5 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
6
d7e6881a
DA
72013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
8
9 * fringe.c (draw_window_fringes, update_window_fringes)
10 (compute_fringe_widths):
11 * w32term.c (x_draw_glyph_string):
12 * window.c (candidate_window_p, Frecenter):
13 * xfaces.c (realize_basic_faces, realize_default_face)
14 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
15 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
16 * xfns.c (x_set_cursor_color, xic_free_xfontset):
17 * xmenu.c (Fx_menu_bar_open_internal):
18 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
19 * xsettings.c (xft_settings_event):
20 * xterm.c (x_draw_glyph_string, x_had_errors_p):
21 Use bool for booleans. Adjust style and comments where
22 appropriate.
23 * dispextern.h (draw_window_fringes, update_window_fringes)
24 (compute_fringe_widths):
25 * xterm.h (x_had_errors_p): Adjust prototype.
26
ec3058af
DA
272013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
28
29 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
30 CHECK_LIST. Rewrite the loop to avoid useless local variable.
31
218e0637
DA
322013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
33
34 * fns.c (toplevel): Remove comment before Fsafe_length because
35 it checks for QUIT.
36
e560aba9
PE
372013-07-28 Paul Eggert <eggert@cs.ucla.edu>
38
39 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
40
2e5ce5de
EZ
412013-07-28 Eli Zaretskii <eliz@gnu.org>
42
43 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
44 frame which got the message is still alive, before dereferencing
45 its pointer. (Bug#14970)
46
47 * frame.c (delete_frame): Test "this" frame's minibuffer window to
48 be a live window, before using it as such. (Bug#14970)
49
e95da6d3
EZ
502013-07-27 Eli Zaretskii <eliz@gnu.org>
51
52 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
53 w32_detect_focus_change instead of doing part of its job by hand.
54 This fixes the problem whereby FOCUS_OUT events were not sent to
55 the event queue.
56
a8f93651
EZ
572013-07-26 Eli Zaretskii <eliz@gnu.org>
58
fec92060
EZ
59 * process.c (Fprocess_list): Doc fix.
60
a8f93651
EZ
61 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
62 being re-exposed only if it didn't ask to become visible.
63 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
64 was previously iconified. (Bug#14841)
65 (x_iconify_frame): Mark the frame iconified.
66
d5a7a9d9
PE
672013-07-26 Paul Eggert <eggert@cs.ucla.edu>
68
69 Fix minor problems found by static checking.
70 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
71 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
72
56ea7291
SM
732013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
74
75 * eval.c (set_specpdl_old_value): New function.
76 (unbind_to): Minor simplification.
77 (get_backtrace_frame): New function.
78 (Fbacktrace_frame): Use it. Add `base' argument.
79 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
80 (syms_of_eval): Export backtrace-eval.
81 * xterm.c (x_focus_changed): Simplify.
82
9d611ffe
PE
832013-07-25 Paul Eggert <eggert@cs.ucla.edu>
84
85 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
86
999c74e3
EZ
872013-07-24 Eli Zaretskii <eliz@gnu.org>
88
89 * xdisp.c (redisplay_window): Instead of moving point out of
90 scroll margin, reject the force_start method, and try scrolling
91 instead. (Bug#14780)
92
198fa217
KB
932013-07-24 Ken Brown <kbrown@cornell.edu>
94
95 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
96 (Bug#14944).
97
53840e55
PE
982013-07-24 Paul Eggert <eggert@cs.ucla.edu>
99
100 * eval.c (Fprogn): Do not check that BODY is a proper list.
101 This undoes the previous change. The check slows down the
102 interpreter, and is not needed to prevent a crash. See
103 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
104
60967f56
GM
1052013-07-23 Glenn Morris <rgm@gnu.org>
106
107 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
108
9ca960e2
PE
1092013-07-23 Paul Eggert <eggert@cs.ucla.edu>
110
a29c3e6d
PE
111 Port to GNU/Linux systems with tinfo but not ncurses.
112 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
113 to decide whether ncurses is being used. Without this change,
114 GCC complains about tgetent not being declared, on a system
115 that has tinfo installed but ncurses not installed.
116
f274311c
PE
117 * eval.c (Fprogn): Check that BODY is a proper list.
118
16b0520a
PE
119 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
120 * data.c (Fsetq_default):
121 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
122 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
123 (Fcondition_case):
124 Tune by taking advantage of the fact that ARGS is always a list
125 when a function is declared to have UNEVALLED args.
126
9ca960e2
PE
127 * emacsgtkfixed.c: Port to GCC 4.6.
128 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
129
afacaa1b
JB
1302013-07-23 Juanma Barranquero <lekktu@gmail.com>
131
132 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
133 here to silence compiler warnings.
134
368a85a4
PE
1352013-07-22 Paul Eggert <eggert@cs.ucla.edu>
136
137 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
138 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
139 from messing up Emacs's 'struct frame' (Bug#14923).
140
f4e891b5
PE
1412013-07-21 Paul Eggert <eggert@cs.ucla.edu>
142
143 * alloc.c (make_save_ptr_ptr): Define this function.
144 It was inadvertently omitted. It's needed only if
145 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
146
96c8b65e
JD
1472013-07-21 Jan Djärv <jan.h.d@swipnet.se>
148
149 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
150 frame have focus (Bug#14895).
151
ee010797
PE
1522013-07-21 Paul Eggert <eggert@cs.ucla.edu>
153
154 Avoid vfork-related deadlock more cleanly.
155 * callproc.c (child_setup): When the child's exec fails, output
156 the program name, as that's more useful. Use O_NONBLOCK to avoid
157 deadlock.
158 * process.c (create_process_1): Remove; no longer needed.
159 (create_process): Remove timer hack; no longer needed, now that
160 the child avoids deadlock.
161
f0398ec1 1622013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
163
164 * image.c (Fimage_flush): Fix doc typo.
165
b2a069c2
PE
1662013-07-20 Paul Eggert <eggert@cs.ucla.edu>
167
6496aec9
PE
168 Fix array bounds violation when pty allocation fails.
169 * process.c (PTY_NAME_SIZE): New constant.
170 (pty_name): Remove static variable; it's now auto.
171 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
172 Take pty_name as an arg rather than using a static variable.
173 All callers changed.
174 (create_process): Recover pty_flag from process, not from volatile local.
175 (create_pty): Stay inside array even when pty allocation fails.
176 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
177
b2a069c2
PE
178 * lread.c (Fload): Avoid initialization only when lint checking.
179 Mention that it's needed only for older GCCs.
180
99107004
KH
1812013-07-20 Kenichi Handa <handa@gnu.org>
182
183 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
184 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
185
6b1b199d
AS
1862013-07-20 Andreas Schwab <schwab@linux-m68k.org>
187
188 * lread.c (Fload): Avoid uninitialized warning.
189
4195afc3
PE
1902013-07-19 Paul Eggert <eggert@cs.ucla.edu>
191
3f5bef16
PE
192 Fix some minor file descriptor leaks and related glitches.
193 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
194 (create_lock_file): Use write, not emacs_write.
195 * image.c (slurp_file, png_load_body):
196 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
197 (server_accept_connection):
198 Don't leak an fd on memory allocation failure.
199 * image.c (slurp_file): Add a cheap heuristic for growing files.
200 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
201 as that's what the other routines do. Maybe input need not be
202 blocked at all, but it's better to be consistent.
203 Avoid undefined behavior when strlen is zero.
204
4195afc3
PE
205 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
206 (NSTATICS): Now a constant; doesn't need to be a macro.
207
a1aeeffe
RS
2082013-07-19 Richard Stallman <rms@gnu.org>
209
210 * coding.c (decode_coding_utf_8): Add simple loop for fast
211 processing of ASCII characters.
212
63b34baa
PE
2132013-07-19 Paul Eggert <eggert@cs.ucla.edu>
214
215 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
216
621dd9ac
EZ
2172013-07-19 Eli Zaretskii <eliz@gnu.org>
218
219 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
220 unportable 'struct x_display_info'.
221 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
222 is a portable type.
223
1396ac86
PE
2242013-07-19 Paul Eggert <eggert@cs.ucla.edu>
225
ab9980cd
PE
226 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
227 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
228 or fscanf fails.
229 (system_process_attributes): Prefer plain char to unsigned char
230 when either will do. Clean up properly if interrupted or if
231 memory allocations fail. Don't assume sscanf succeeds. Remove
232 no-longer-needed workaround to stop GCC from whining. Read
233 command-line once, instead of multiple times. Check read status a
234 bit more carefully.
235
1396ac86
PE
236 Fix obscure porting bug with varargs functions.
237 The code assumed that int is treated like ptrdiff_t in a vararg
238 function, which is not a portable assumption. There was a similar
239 -- though these days less likely -- porting problem with various
240 assumptions that pointers of different types all smell the same as
241 far as vararg functions is conserved. To make this problem less
242 likely in the future, redo the API to use varargs functions.
243 * alloc.c (make_save_value): Remove this vararg function.
244 All uses changed to ...
245 (make_save_int_int_int, make_save_obj_obj_obj_obj)
246 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
247 New functions.
248 (make_save_ptr): Rename from make_save_pointer, for consistency with
249 the above. Define only on platforms that need it. All uses changed.
250
4d19d194
PE
2512013-07-18 Paul Eggert <eggert@cs.ucla.edu>
252
253 * keyboard.c: Try to fix typos in previous change.
254 (DISPLAY_LIST_INFO): New macro.
255 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 256 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 257
945c5bb1
JB
2582013-07-18 Juanma Barranquero <lekktu@gmail.com>
259
260 * keyboard.c (kbd_buffer_get_event):
261 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
262 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
263
f4b1eb36
PE
2642013-07-18 Paul Eggert <eggert@cs.ucla.edu>
265
5e679a2c
PE
266 * filelock.c: Fix unlikely file descriptor leaks.
267 (get_boot_time_1): Rework to avoid using emacs_open.
268 This doesn't actually fix a leak, but is better anyway.
269 (read_lock_data): Use read, not emacs_read.
270
a8cd4836
PE
271 * doc.c: Fix minor memory and file descriptor leaks.
272 * doc.c (get_doc_string): Fix memory leak when doc file absent.
273 (get_doc_string, Fsnarf_documentation):
274 Fix file descriptor leak on error.
275
ef30e638
PE
276 * term.c: Fix minor fdopen-related file descriptor leaks.
277 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
278 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
279
f4b1eb36
PE
280 * charset.c: Fix file descriptor leaks and errno issues.
281 Include <errno.h>.
282 (load_charset_map_from_file): Don't leak file descriptor on error.
283 Use plain record_xmalloc since the allocation is larger than
284 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
285 of entries.
286 * eval.c (record_unwind_protect_nothing):
287 * fileio.c (fclose_unwind):
288 New functions.
289 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
290 The replacement doesn't block input, but that no longer seems
291 necessary.
292
b648c163
PE
2932013-07-17 Paul Eggert <eggert@cs.ucla.edu>
294
a0931322
PE
295 * lread.c: Fix file descriptor leaks and errno issues.
296 (Fload): Close some races that leaked fds or streams when 'load'
297 was interrupted.
298 (Fload, openp): Report error number of last nontrivial failure to open.
299 ENOENT counts as trivial.
300 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
301 New functions.
302 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
303 now that the function is always called with a nonnegative arg.
304 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
305 All uses replaced with ...
306 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
307
b648c163
PE
308 A few more minor file errno-reporting bugs.
309 * callproc.c (Fcall_process):
310 * doc.c (Fsnarf_documentation):
311 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
312 * process.c (set_socket_option):
313 Don't let a constructor trash errno.
314 * doc.c: Include <errno.h>.
315
b1dc4084
JB
3162013-07-16 Juanma Barranquero <lekktu@gmail.com>
317
318 * w32fns.c (unwind_create_tip_frame): Fix declaration.
319
c43843aa
PE
3202013-07-16 Paul Eggert <eggert@cs.ucla.edu>
321
50a30cce
PE
322 Fix w32 bug with call-process-region (Bug#14885).
323 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
324 to Fcall_process when the input is empty. This simplifies the
325 code a bit. It makes no difference on POSIXish platforms but
326 apparently it fixes a bug on w32.
327
328 Fix bug where insert-file-contents closes a file twice. (Bug#14839).
41d48a42
PE
329 * fileio.c (close_file_unwind): Don't close if FD is negative;
330 this can happen when unwinding a zapped file descriptor.
331 (Finsert_file_contents): Unwind-protect the fd before the point marker,
332 in case Emacs runs out of memory between the two unwind-protects.
333 Don't trash errno when closing FD.
334 Zap the FD in the specpdl when closing it, instead of deferring
335 the removal of the unwind-protect; this fixes a bug where a child
336 function unwinds the stack past us.
337
27e498e6
PE
338 New unwind-protect flavors to better type-check C callbacks.
339 This also lessens the need to write wrappers for callbacks,
340 and the need for make_save_pointer.
341 * alloca.c (free_save_value):
342 * atimer.c (run_all_atimers):
343 Now extern.
344 * alloc.c (safe_alloca_unwind):
345 * atimer.c (unwind_stop_other_atimers):
346 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
347 * menu.c (cleanup_popup_menu) [HAVE_NS]:
348 * minibuf.c (choose_minibuf_frame_1):
349 * process.c (make_serial_process_unwind):
350 * xdisp.h (pop_message_unwind):
351 * xselect.c (queue_selection_requests_unwind):
352 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
353 * alloca.c (record_xmalloc):
354 Prefer record_unwind_protect_ptr to record_unwind_protect with
355 make_save_pointer.
356 * alloca.c (Fgarbage_collect):
357 Prefer record_unwind_protect_void to passing a dummy.
358 * buffer.c (restore_buffer):
359 * window.c (restore_window_configuration):
360 * xfns.c, w32fns.c (do_unwind_create_frame)
361 New wrapper. All record-unwind uses of wrappee changed.
362 * buffer.c (set_buffer_if_live):
363 * callproc.c (call_process_cleanup, delete_temp_file):
364 * coding.c (code_conversion_restore):
365 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
366 * editfns.c (save_excursion_restore)
367 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
368 (save_restriction_restore):
369 * eval.c (restore_stack_limits, un_autoload):
370 * fns.c (require_unwind):
371 * keyboard.c (recursive_edit_unwind, tracking_off):
372 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
373 * macros.c (pop_kbd_macro, restore_menu_items):
374 * nsfns.m (unwind_create_frame):
375 * print.c (print_unwind):
376 * process.c (start_process_unwind):
377 * search.c (unwind_set_match_data):
378 * window.c (select_window_norecord, select_frame_norecord):
379 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
380 (fast_set_selected_frame):
381 * xfns.c, w32fns.c (unwind_create_tip_frame):
382 Return void, not a dummy Lisp_Object. All uses changed.
383 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
384 * callproc.c (call_process_kill):
385 * fileio.c (restore_point_unwind, decide_coding_unwind)
386 (build_annotations_unwind):
387 * insdel.c (Fcombine_after_change_execute_1):
388 * keyboard.c (read_char_help_form_unwind):
389 * menu.c (unuse_menu_items):
390 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
391 * sound.c (sound_cleanup):
392 * xdisp.c (unwind_redisplay):
393 * xfns.c (clean_up_dialog):
394 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
395 Accept no args and return void, instead of accepting and returning
396 a dummy Lisp_Object. All uses changed.
397 * cygw32.c (fchdir_unwind):
398 * fileio.c (close_file_unwind):
399 * keyboard.c (restore_kboard_configuration):
400 * lread.c (readevalllop_1):
401 * process.c (wait_reading_process_output_unwind):
402 Accept int and return void, rather than accepting an Emacs integer
403 and returning a dummy object. In some cases this fixes an
404 unlikely bug when the corresponding int is outside Emacs integer
405 range. All uses changed.
406 * dired.c (directory_files_internal_unwind):
407 * fileio.c (do_auto_save_unwind):
408 * gtkutil.c (pop_down_dialog):
409 * insdel.c (reset_var_on_error):
410 * lread.c (load_unwind):
411 * xfns.c (clean_up_file_dialog):
412 * xmenu.c, nsmenu.m (pop_down_menu):
413 * xmenu.c (cleanup_widget_value_tree):
414 * xselect.c (wait_for_property_change_unwind):
415 Accept pointer and return void, rather than accepting an Emacs
416 save value encapsulating the pointer and returning a dummy object.
417 All uses changed.
418 * editfns.c (Fformat): Update the saved pointer directly via
419 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
420 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
421 (unwind_body): New function.
422 (record_unwind_protect): First arg is now a function returning void,
423 not a dummy Lisp_Object.
424 (record_unwind_protect_ptr, record_unwind_protect_int)
425 (record_unwind_protect_void): New functions.
426 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
427 * fileio.c (struct auto_save_unwind): New type.
428 (do_auto_save_unwind): Use it.
429 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
430 * insdel.c (struct rvoe_arg): New type.
431 (reset_var_on_error): Use it.
432 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
433 New constants.
434 (specbinding_func): Remove; there are now several such functions.
435 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
436 (set_unwind_protect_ptr): New function.
437 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
438
4e604a5d
PE
439 Be simpler and more consistent about reporting I/O errors.
440 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
441 Say "Read error" and "Write error", rather than "I/O error", or
442 "IO error reading", or "IO error writing", when a read or write
443 error occurs.
444 * process.c (Fmake_network_process, wait_reading_process_output)
445 (send_process, Fprocess_send_eof, wait_reading_process_output):
446 Capitalize diagnostics consistently. Put "failed foo" at the
447 start of the diagnostic, so that we don't capitalize the
448 function name "foo". Consistently say "failed" for such
449 diagnostics.
450 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
451 All callers changed. This is so it can use report_file_error.
452 * sysdep.c (serial_open, serial_configure): Capitalize I/O
453 diagnostics consistently as above.
454
a9757f6a
PE
455 * fileio.c (report_file_errno): Fix errno reporting bug.
456 If the file name is neither null nor a pair, package it up as a
457 singleton list. All callers changed, both to this function and to
458 report_file_error. This fixes a bug where the memory allocator
459 invoked by list1 set errno so that the immediately following
460 report_file_error reported the wrong errno value.
461
c43843aa
PE
462 Fix minor problems found by --enable-gcc-warnings.
463 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
464 * keyboard.c (kbd_buffer_get_event): Remove unused local.
465
18c26d81
JD
4662013-07-16 Jan Djärv <jan.h.d@swipnet.se>
467
468 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
469 Set event->arg to Qt if switch-event shall be generated.
470 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
471
472 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
473
474 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
475 FOCUS_OUT_EVENT.
476
477 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
478 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
479 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
480 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
481 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
482 and there is a focused frame.
483 (head_table): Add focus-in and focus-out.
484 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
485 bind to handle-focus-in/out.
486
487 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
488 (Fhandle_switch_frame): Call Fhandle_focus_in.
489 (syms_of_frame): defsubr handle-focus-in/out.
490
6c6f1994
PE
4912013-07-16 Paul Eggert <eggert@cs.ucla.edu>
492
c7ddc792
PE
493 Fix porting bug to older POSIXish platforms (Bug#14862).
494 * sysdep.c (emacs_pipe): New function, that implements
495 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
496 This should port better to CentOS 5 and to Mac OS X 10.6.
497 All calls to pipe2 changed.
498
6c6f1994
PE
499 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
500 This makes the code easier to read and the executable a bit smaller.
501 Do not replace all calls to Fcons that happen to create lists,
502 just calls that are intended to create lists. For example, when
503 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
504 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
505 Similarly for list2 through list5.
506 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
507 * bytecode.c (exec_byte_code):
508 * callint.c (quotify_arg, Fcall_interactively):
509 * callproc.c (Fcall_process, create_temp_file):
510 * charset.c (load_charset_map_from_file)
511 (Fdefine_charset_internal, init_charset):
512 * coding.c (get_translation_table, detect_coding_system)
513 (Fcheck_coding_systems_region)
514 (Fset_terminal_coding_system_internal)
515 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
516 * composite.c (update_compositions, Ffind_composition_internal):
517 * dired.c (directory_files_internal, file_name_completion)
518 (Fsystem_users):
519 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
520 * doc.c (Fsnarf_documentation):
521 * editfns.c (Fmessage_box):
522 * emacs.c (main):
523 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
524 (Feval, eval_sub, Ffuncall, apply_lambda):
525 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
526 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
527 (Fset_file_times, Finsert_file_contents)
528 (Fchoose_write_coding_system, Fwrite_region):
529 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
530 * font.c (font_registry_charsets, font_parse_fcname)
531 (font_prepare_cache, font_update_drivers, Flist_fonts):
532 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
533 * frame.c (make_frame, Fmake_terminal_frame)
534 (x_set_frame_parameters, x_report_frame_params)
535 (x_default_parameter, Fx_parse_geometry):
536 * ftfont.c (syms_of_ftfont):
537 * image.c (gif_load):
538 * keyboard.c (command_loop_1):
539 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
540 (Fcopy_keymap, append_key, Fcurrent_active_maps)
541 (Fminor_mode_key_binding, accessible_keymaps_1)
542 (Faccessible_keymaps, Fwhere_is_internal):
543 * lread.c (read_emacs_mule_char):
544 * menu.c (find_and_return_menu_selection):
545 * minibuf.c (get_minibuffer):
546 * nsfns.m (Fns_perform_service):
547 * nsfont.m (ns_script_to_charset):
548 * nsmenu.m (ns_popup_dialog):
549 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
550 (Fx_own_selection_internal):
551 * nsterm.m (append2):
552 * print.c (Fredirect_debugging_output)
553 (print_prune_string_charset):
554 * process.c (Fdelete_process, Fprocess_contact)
555 (Fformat_network_address, set_socket_option)
556 (read_and_dispose_of_process_output, write_queue_push)
557 (send_process, exec_sentinel):
558 * sound.c (Fplay_sound_internal):
559 * textprop.c (validate_plist, add_properties)
560 (Fput_text_property, Fadd_face_text_property)
561 (copy_text_properties, text_property_list, syms_of_textprop):
562 * unexaix.c (report_error):
563 * unexcoff.c (report_error):
564 * unexsol.c (unexec):
565 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
566 (Fformat_mode_line, syms_of_xdisp):
567 * xfaces.c (set_font_frame_param)
568 (Finternal_lisp_face_attribute_values)
569 (Finternal_merge_in_global_face, syms_of_xfaces):
570 * xfns.c (x_default_scroll_bar_color_parameter)
571 (x_default_font_parameter, x_create_tip_frame):
572 * xfont.c (xfont_supported_scripts):
573 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
574 (menu_help_callback, xmenu_show):
575 * xml.c (make_dom):
576 * xterm.c (set_wm_state):
577 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
578 and similarly for list2 through list5.
579
bafe80ce
PE
5802013-07-15 Paul Eggert <eggert@cs.ucla.edu>
581
582 * callproc.c (Fcall_process_region): Fix minor race and tune.
583 (create_temp_file): New function, with the temp-file-creation part
584 of the old Fcall_process_region. Use Fcopy_sequence to create the
585 temp file name, rather than alloca + build_string, for simplicity.
586 Don't bother to block input around the temp file creation;
587 shouldn't be needed. Simplify use of mktemp. Use
588 record_unwind_protect immediately after creating the temp file;
589 this closes an unlikely race where the temp file was not removed.
590 Use memcpy rather than an open-coded loop.
591 (Fcall_process_region): Use the new function. If the input is
592 empty, redirect from /dev/null rather than from a newly created
593 empty temp file; this avoids unnecessary file system traffic.
594
4700b5a5
PE
5952013-07-14 Paul Eggert <eggert@cs.ucla.edu>
596
5c97beae
PE
597 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
598 Simplify by making this case like the other two. This is a bit
599 slower on obsolete hosts, but the extra complexity isn't worth it.
600
4700b5a5
PE
601 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
602 * process.c (create_process) [!DOS_NT]:
603 Remove now-unnecessary calls to emacs_close.
604
f9a74c4c
EZ
6052013-07-13 Eli Zaretskii <eliz@gnu.org>
606
922ae7ee
EZ
607 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
608 returning early. (Bug#14850)
609
f9a74c4c
EZ
610 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
611 and inhibit-iso-escape-detection attributes of 'undecided'.
612 (Bug#14822)
613
5e301d76
PE
6142013-07-13 Paul Eggert <eggert@cs.ucla.edu>
615
69e0e5ee
PE
616 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
617 Reported by Herbert J. Skuhra in
618 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
619
5e301d76
PE
620 Don't lose top specpdl entry when memory is exhausted.
621 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
622 specpdl overflow here, to simplify callers; all callers changed.
623 Always reserve an unused entry at the stack top; this avoids
624 losing the top entry's information when memory is exhausted.
625
7e649856
PE
6262013-07-12 Paul Eggert <eggert@cs.ucla.edu>
627
a773ed9a
PE
628 Clean up errno reporting and fix some errno-reporting bugs.
629 * callproc.c (Fcall_process):
630 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
631 * process.c (create_process, Fmake_network_process):
632 * unexaix.c (report_error):
633 * unexcoff.c (report_error):
634 Be more careful about reporting the errno of failed operations.
635 The code previously reported the wrong errno sometimes.
636 Also, prefer report_file_errno to setting errno + report_file_error.
637 (Fcall_process): Look at openp return value rather than at path,
638 as that's a bit faster and clearer when there's a numeric predicate.
639 * fileio.c (report_file_errno): New function, with most of the
640 old contents of report_file_error.
641 (report_file_error): Use it.
642 (Ffile_exists_p, Ffile_accessible_directory_p):
643 Set errno to 0 when it is junk.
644 * fileio.c (Faccess_file):
645 * image.c (x_create_bitmap_from_file):
646 Use faccessat rather than opening the file, to avoid the hassle of
647 having a file descriptor open.
648 * lisp.h (report_file_errno): New decl.
649 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
650
7e649856
PE
651 Minor EBADF fixes.
652 * process.c (create_process, wait_reading_process_output) [AIX]:
653 Remove obsolete SIGHUP-related code, as Emacs no longer disables
654 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
655 a multithreaded environment anyway).
656 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
657
f6774c1a
AS
6582013-07-12 Andreas Schwab <schwab@linux-m68k.org>
659
660 * image.c (x_find_image_file): Don't close a remote file handle.
661
bacba3c2
PE
6622013-07-12 Paul Eggert <eggert@cs.ucla.edu>
663
664 Fix races with threads and file descriptors.
665 * callproc.c (Fcall_process_region):
666 * dired.c (open_directory):
667 * emacs.c (main, Fdaemon_initialized):
668 * image.c (x_find_image_file):
669 * inotify.c (Finotify_rm_watch):
670 * lread.c (Flocate_file_internal):
671 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
672 * term.c (term_mouse_moveto, init_tty):
673 * termcap.c (tgetent):
674 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
675 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
676 * unexhp9k800.c, unexmacosx.c (unexec):
677 * callproc.c (Fcall_process_region):
678 Use emacs_close, not close.
679 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
680 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
681 and posix_close function on current platforms (which all lack them).
682 (emacs_close): Use it. This should fix the races on GNU/Linux and
683 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
684 and it should avoid closing random victim file descriptors on
685 other platforms.
686
653d4f43
PE
6872013-07-11 Paul Eggert <eggert@cs.ucla.edu>
688
c8536ec4
PE
689 * inotify.c (uninitialized): Remove. All uses replaced by -1.
690 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
691 Touch up doc a bit.
692
9c203066
PE
693 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
694 This is for .gdbinit xbacktrace.
695
653d4f43
PE
696 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
697 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
698 (emacs_set_tty): Now static.
699 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
700 * term.c (tty_capable_p, tty_default_color_capabilities)
701 (get_tty_terminal, term_mouse_movement)
702 (handle_one_term_event, init_tty, maybe_fatal):
703 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
704 (tgetent, scan_file, name_match, compare_contin):
705 * terminal.c (get_terminal):
706 Use bool for boolean.
707 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
708 Prefer char to unsigned char if either will do.
709 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
710 (tty_write_glyphs): Prefer int to unsigned.
711 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
712 All callers changed.
713 * termcap.c (tprint, main) [TEST]: Remove non-working test.
714
45b683a1
PE
7152013-07-10 Paul Eggert <eggert@cs.ucla.edu>
716
29abe551
PE
717 Port to C89.
718 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
719 (B__dummy__): New dummy symbol, to pacify C89.
720 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
721 they can't grok varargs macros.
722 * dispnew.c (add_window_display_history)
723 (add_frame_display_history):
724 * print.c (print_object):
725 * xdisp.c (debug_method_add):
726 Use %p printf format only for void pointers.
727 * emacs.c (usage_message): New constant, replacing ...
728 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
729 (main): Adjust to usage reorg.
730 * fns.c (syms_of_fns):
731 * profiler.c (syms_of_profiler):
732 Don't use non-constant struct initializers.
733 * gnutls.h (gnutls_initstage_t):
734 * lisp.h (enum Lisp_Fwd_Type):
735 * lread.c (lisp_file_lexically_bound_p):
736 * xsettings.c (anonymous enum):
737 Remove trailing comma.
738 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
739 * lisp.h (ENUM_BF): Use unsigned if pedantic.
740 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
741 (DEFUN): Use it.
742 * regex.c (const_re_char): New type, to pacify strict C89.
743 All uses of 'const re_char' replaced to use it.
744 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
745 with glibc when strict C89. This change is imported from gnulib.
746 All uses changed.
747 (_Restrict_arr_): Rename from __restrict_arr, similarly.
748 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
749 Omit GNU_LINUX implementation, since it requires long long.
750 * xterm.c (x_draw_underwave):
751 Do not assume the traditional order of struct's members.
752 (x_term_init): Rewrite to avoid the need for non-constant structure
753 initializers.
754
45b683a1 755 Syntax cleanup, mostly replacing macros with functions.
763a086d 756 This removes the need for the syntax_temp hack.
45b683a1
PE
757 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
758 * syntax.c (SYNTAX_INLINE): New macro.
759 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
760 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
761 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
762 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
763 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
764 (SYNTAX_COMEND_FIRST): Now functions, not macros.
765 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
766 Now constants, not macros.
767 (syntax_temp) [!__GNUC__]: Remove.
768 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
769 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
770 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
771 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
772 Move here from syntax.h; now functions, not macros. Except for the
773 last function, these are static since only syntax.c uses them.
774 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
775 All uses changed. Now a function, not a macro; use this fact
776 to simplify the code.
777 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
778 compiler bugs; no longer relevant.
779 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
780 (SYNTAX_INLINE): New macro.
781 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
782 for the new functions. Use bool for boolean member.
783 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
784 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
785 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
786 (SETUP_BUFFER_SYNTAX_TABLE):
787 Now extern inline functions, not macros.
788 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
789 Remove; all uses replaced by implementation.
790 (syntax_temp) [!__GNUC__]: Remove decl.
791 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
792
29be4a50
JD
7932013-07-10 Jan Djärv <jan.h.d@swipnet.se>
794
795 * emacs.c (main): Fix syntax error.
796
954b166e
PE
7972013-07-10 Paul Eggert <eggert@cs.ucla.edu>
798
799 Timestamp fixes for undo (Bug#14824).
800 * atimer.c (schedule_atimer):
801 * fileio.c (Ffile_newer_than_file_p):
802 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
803 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
804 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
805 (syms_of_fileio): Remove Sclear_visited_file_name.
806 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
807 file doesn't exist; this avoids an ambiguity with negative timestamps.
808 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
809 * systime.h (make_emacs_time, invalid_emacs_time):
810 Don't assume struct timespec layout; POSIX doesn't guarantee it.
811 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
812 * undo.c (record_first_change): Push (visited-file-modtime) onto
813 undo list rather than reimplementing it by hand, incorrectly.
814
d74647c3
KB
8152013-07-09 Ken Brown <kbrown@cornell.edu>
816
817 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
818
3c51b96b
JB
8192013-07-09 Juanma Barranquero <lekktu@gmail.com>
820
821 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
822
4ebbdd67
PE
8232013-07-09 Paul Eggert <eggert@cs.ucla.edu>
824
825 Handle errno and exit status a bit more carefully.
826 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
827 number into an exit status. Instead, use EXIT_CANCELED.
828 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
829 * callproc.c (relocate_fd):
830 * emacs.c (close_output_streams, main):
831 * process.c (create_process):
832 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
833 Use emacs_perror for simplicity.
834 * callproc.c (relocate_fd, main):
835 * sysdep.c (sys_subshell):
836 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
837 (shut_down_emacs): Use emacs_write, not write.
838 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
839 * fileio.c (Fcopy_file, e_write):
840 * nsterm.m (ns_select):
841 * process.c (send_process):
842 * sound.c (vox_write):
843 Use emacs_write_sig, not emacs_write.
844 * lisp.h (emacs_write_sig, emacs_perror): New decls.
845 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
846 New constants.
847 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
848 of write.
849 (emacs_full_write): New function.
850 (emacs_write): Rewrite to use it.
851 (emacswrite_sig, emacs_perror): New functions.
852 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
853
763a086d 8542013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change).
e4b1e5af
JD
855
856 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
857 on NS even if it is present. Pixmap on NS is a void*.
858
9caab067
PE
8592013-07-07 Paul Eggert <eggert@cs.ucla.edu>
860
861 Port to Ubuntu 10 (Bug#14803).
862 Problem reported by T.V. Raman.
863 * process.c (close_on_exec, accept4, process_socket):
864 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
865
1d442672
EZ
8662013-07-07 Eli Zaretskii <eliz@gnu.org>
867
868 * w32.c (sys_dup): Declare prototype.
869
870 * filelock.c:
871 * emacs.c:
872 * callproc.c [WINDOWSNT]: Include sys/socket.h.
873
067428c1
PE
8742013-07-07 Paul Eggert <eggert@cs.ucla.edu>
875
876 Make file descriptors close-on-exec when possible (Bug#14803).
877 This simplifies Emacs a bit, since it no longer needs to worry
878 about closing file descriptors by hand in some cases.
879 It also fixes some unlikely races. Not all such races, as
880 libraries often open files internally without setting
881 close-on-exec, but it's an improvement.
882 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
883 * callproc.c (Fcall_process) [!MSDOS]:
884 * emacs.c (main) [!DOS_NT]:
885 * nsterm.m (ns_term_init):
886 * process.c (create_process):
887 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
888 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
889 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
890 Prefer mkostemp with O_CLOEXEC to mkstemp.
891 * callproc.c (relocate_fd) [!WINDOWSNT]:
892 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
893 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
894 now using pipe2.
895 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
896 Make the resulting file descriptor close-on-exec.
897 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
898 * lread.c (load_descriptor_list, load_descriptor_unwind):
899 Remove; no longer needed. All uses removed.
900 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
901 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
902 New functions.
903 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
904 (Fmake_network_process, Fnetwork_interface_list):
905 (Fnetwork_interface_info, server_accept_connection):
906 Make newly-created socket close-on-exec.
907 * sysdep.c (emacs_open, emacs_fopen):
908 Make new-created descriptor close-on-exec.
909 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
910 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
911
0da857dd
JD
9122013-07-07 Jan Djärv <jan.h.d@swipnet.se>
913
914 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
915 for NS_IMPL_GNUSTEP.
916
5f86adcd
PE
9172013-07-07 Paul Eggert <eggert@cs.ucla.edu>
918
919 Fix openp errno handling.
920 * callproc.c (Fcall_process): Preserve openp errno around close.
921 * lread.c (openp): Set errno when returning -1, as some callers
922 expect this.
923
1afb1d07
JD
9242013-07-06 Jan Djärv <jan.h.d@swipnet.se>
925
926 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
927
928 * nsterm.h (NSSavePanel): Update comment.
929 (NSAPP_DATA2_RUNFILEDIALOG): Define.
930 (ns_run_file_dialog): Declare.
931
932 * nsfns.m: Remove panelOK.
933 (ns_fd_data): New.
934 (ns_run_file_dialog): New function.
935 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
936 event loop, so file dialog is popped up by ns_run_file_dialog, called
937 by sendEvent (Bug#14578).
938 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
939
3323c263
EZ
9402013-07-06 Eli Zaretskii <eliz@gnu.org>
941
fdda0220
EZ
942 * xdisp.c (default_line_pixel_height): New function.
943 (pos_visible_p, move_it_vertically_backward, try_scrolling)
944 (try_cursor_movement, redisplay_window, try_window)
945 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
946
947 * window.c (window_scroll_pixel_based): use
948 default_line_pixel_height.
949
950 * dispextern.h (default_line_pixel_height): Add prototype.
951
952 * frame.c (x_set_line_spacing): Accept a float value for
953 line-spacing parameter, per the documentation.
954
3323c263
EZ
955 * data.c (Fmultibyte_string_p): Doc fix.
956
47ba6d43
PE
9572013-07-05 Paul Eggert <eggert@cs.ucla.edu>
958
406af475
PE
959 Use emacs_open more consistently when opening files.
960 This handles EINTR more consistently now, and makes it easier
961 to introduce other uniform changes to file descriptor handling.
962 * src/systdio.h: New file.
963 * src/buffer.c (mmap_init):
964 * cygw32.c (chdir_to_default_directory):
965 * dispnew.c (Fopen_termscript):
966 * emacs.c (Fdaemon_initialized):
967 * fileio.c (Fdo_auto_save):
968 * image.c (slurp_file, png_load_body, jpeg_load_body):
969 * keyboard.c (Fopen_dribble_file):
970 * lread.c (Fload):
971 * print.c (Fredirect_debugging_output):
972 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
973 * termcap.c (tgetent):
974 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
975 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
976 * w32term.c (w32_initialize) [CYGWIN]:
977 * xfaces.c (Fx_load_color_file):
978 Use emacs_open instead of plain open, and emacs_fopen instead of
979 plain fopen.
980 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
981 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
982 * callproc.c (default_output_mode): New constant.
983 (Fcall_process): Use it to call emacs_open instead of plain creat.
984 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
985 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
986 (emacs_fopen): New function.
987 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
988 Include <lisp.h>, for emacs_open.
989 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
990
47ba6d43
PE
991 Remove duplicate #include directives.
992 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
993 * xfaces.c:
994 Don't include stdio.h twice.
995 * buffer.c [USE_MMAP_FOR_BUFFERS]:
996 Don't include sys/types.h or stdio.h twice.
997 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
998 * lread.c: Don't include coding.h twice.
999 * nsfont.m: Don't include frame.h twice.
1000 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1001 * ralloc.c: Don't include <unistd.h> twice.
1002 * xdisp.c: Don't include font.h twice.
1003 * xterm.c: Don't include fontset.h twice.
1004 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1005
b9ed53d5
PE
10062013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 Scale ImageMagick images more carefully.
1009 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1010 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1011 Be more careful about avoiding undefined behavior after
1012 integer overflow and division by zero.
1013
cf13177e
YM
10142013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1015
1016 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1017 (syms_of_w32fns): DEFSYM them.
1018 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1019 (CCHDEVICENAME): Define macros if not defined.
1020 (struct MONITOR_INFO_EX): New struct.
1021 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1022 (enum_display_monitors_fn): New variable.
1023 (globals_of_w32fns): Initialize it.
1024 (Fx_display_pixel_width, Fx_display_pixel_height)
1025 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1026 multi-monitor setups in docstrings.
1027 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1028 screen size by primary monitor's millimeter per pixel.
1029 (w32_monitor_enum, w32_display_monitor_attributes_list)
1030 (w32_display_monitor_attributes_list_fallback)
1031 (Fw32_display_monitor_attributes_list): New functions.
1032 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1033
1034 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1035 if not defined.
1036 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1037
86dfb7a8
MA
10382013-07-04 Michael Albinus <michael.albinus@gmx.de>
1039
1040 * fileio.c (Qfile_notify_error): New error symbol.
1041
1042 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1043 * inotify.c (inotify_callback, symbol_to_inotifymask)
1044 (Finotify_add_watch, Finotify_rm_watch): Use it.
1045 (inotifyevent_to_event): Exchange order of cookie and file name.
1046 (Finotify_add_watch): Adapt docstring.
1047
1048 * lisp.h (Qfile_notify_error): Declare.
1049
2c1c974b
PE
10502013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1053 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1054 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1055 which did not work (see <http://bugs.gnu.org/14569#307>).
1056 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1057 && (!noninteractive || initialized)). This attempts to thread
1058 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1059
7a35b20f
JB
10602013-07-04 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1063 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1064
1ce5cd04
PE
10652013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1068 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1069 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1070 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1071
57f8c490
PE
10722013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1075 Define to __sys_siglist.
1076
bcffb5ca
EZ
10772013-07-02 Eli Zaretskii <eliz@gnu.org>
1078
1079 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1080 word-wrap, so that overflow-newline-into-fringe would work in
1081 visual-line-mode. (Bug#2749)
1082 (move_it_in_display_line_to): When the last scanned display
1083 element fits exactly on the display line, and
1084 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1085 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1086 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1087 finding buffer position that corresponds to pixel coordinates,
1088 e.g. in buffer_posn_from_coords.
1089
2c41e781
JD
10902013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1091
1092 * process.c (handle_child_signal): Call catch_child_signal if
1093 NS_IMPL_GNUSTEP.
1094
c2418359
PE
10952013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1096
52a9bcae
PE
1097 Don't convert function pointers to void * and back.
1098 It isn't portable C, and it's easy enough to avoid.
1099 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1100 (make_save_value): Add support for SAVE_FUNCPOINTER.
1101 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1102 * print.c (print_object):
1103 Distinguish function from object pointers.
1104 * lisp.h (SAVE_FUNCPOINTER): New constant.
1105 (SAVE_SLOT_BITS): Adjust to it.
1106 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1107 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1108 (voidfuncptr): New typedef.
1109 (struct Lisp_Save_Value): New member data[0].funcpointer.
1110 (XSAVE_FUNCPOINTER): New function.
1111
c2418359
PE
1112 Simplify buildobj processing.
1113 * Makefile.in (buildobj.h): Make it a sequence of strings each
1114 followed by comma, rather than a single string. Put it into a
1115 .tmp file in case there's an error while generating it.
1116 (gl-stamp): Use .tmp for temp files.
1117 (mostlyclean): Clean .tmp files.
1118 * doc.c (buildobj): Move to just the routine that needs it.
1119 It's now an array of strings, so processing is simpler.
1120
8f43ce49
PE
11212013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1122
1123 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1124 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1125 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1126 Invoke malloc_enable_thread even when not interactive.
1127 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1128 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1129 in this case, since the underlying bug has now been fixed.
1130
24827db9
JB
11312013-07-01 Juanma Barranquero <lekktu@gmail.com>
1132
1133 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1134 unlinking it (bug#14691).
1135
ef099a94
MN
11362013-06-30 Michal Nazarewicz <mina86@mina86.com>
1137
1138 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1139 before checking whether buffer is modified. This lets
1140 `kill-buffer-query-functions' cancel killing of the buffer or save
1141 its content before `kill-buffer' asks user the "Buffer %s
1142 modified; kill anyway?" question.
1143
9d3f2fc2
JD
11442013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1145
1146 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1147 Let the super performKeyEquivalent deal with them (Bug#14747).
1148
e6c6c8c7
PE
11492013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1150
1d71c1d9
PE
1151 * widget.c (resize_cb): Remove unused local.
1152
8f5f35cc
PE
1153 Do not use GTK 3 if it exists but cannot be compiled.
1154 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1155 * xterm.c (x_error_handler) [!USE_GTK]:
1156 Do not use GTK 3.
1157
e6c6c8c7
PE
1158 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1159
0ba54312
EZ
11602013-06-30 Eli Zaretskii <eliz@gnu.org>
1161
5d1c3286
EZ
1162 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1163 to the valid range of values. (Bug#14753)
1164
0ba54312
EZ
1165 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1166 when moving point by using the current glyph matrix. This avoids
1167 the need to force redisplay when this function is called in a
1168 loop.
1169
9c90cc06
PE
11702013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 Fix minor problems found by static checking.
1173 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1174 Redo the latter's body to sidestep GCC parenthesization warnings.
1175 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1176 * coding.c (detect_coding, detect_coding_system):
1177 * coding.h (struct undecided_spec):
1178 Use bool for boolean.
1179 * image.c (QCmax_width, QCmax_height): Now static.
1180 * xdisp.c (Fmove_point_visually): Remove unused local.
1181
4c672a0f
EZ
11822013-06-29 Eli Zaretskii <eliz@gnu.org>
1183
1184 * xdisp.c (Fmove_point_visually): New function.
1185
c1ea3abf
JB
11862013-06-28 Kenichi Handa <handa@gnu.org>
1187
1188 * coding.h (define_coding_undecided_arg_index): New enum.
1189 (coding_attr_index): New members
1190 coding_attr_undecided_inhibit_null_byte_detection,
1191 coding_attr_undecided_inhibit_iso_escape_detection,
1192 coding_attr_undecided_prefer_utf_8.
1193 (undecided_spec): New struct.
1194 (struct coding_system): New member `undecided' of the member
1195 `spec'.
1196
1197 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1198 (detect_coding): Likewise.
1199 (detect_coding_system): Likewise.
1200 (Fdefine_coding_system_internal): New coding system properties
1201 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1202 :prefer-utf-8.
1203 (syms_of_coding): Adjust for coding_arg_undecided_max.
1204
ba3de9e6
PE
12052013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 * image.c (x_from_xcolors): Remove unused local.
1208
547c9269
YM
12092013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1210
1211 Defer image data transfer between X client and server until actual
1212 display happens.
1213
1214 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1215 and `mask_img'.
1216
1217 * image.c (Destroy_Image): Remove.
1218 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1219 `mask_p', and `colors_p'. All uses changed.
1220 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1221 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1222 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1223 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1224 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1225 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1226 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1227 (image_get_x_image, image_unget_x_image): New functions or macros.
1228 (image_background, image_background_transparent, x_to_xcolors)
1229 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1230 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1231 instead of Destroy_Image.
1232 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1233 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1234 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1235 (imagemagick_load_image, svg_load_image): Use them instead of
1236 x_create_x_image_and_pixmap, and x_put_x_image followed by
1237 x_destroy_x_image, respectively.
1238 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1239 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1240 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1241 background_transparent fields.
1242 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1243 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1244
dae2f5ef
PE
12452013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1246
1247 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1248 This mostly consists of undoing recent changes.
1249 * callproc.c (Fcall_process):
1250 * process.c (create_process):
1251 Do not worry about catching SIGCHLD here, undoing previous change.
1252 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1253 * process.c, process.h (catch_child_signal):
1254 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1255 * process.c (catch_child_handler): Don't worry about being called
1256 lazily and do not assume caller has blocked SIGCHLD, undoing
1257 previous change. Move first-time stuff back to
1258 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1259 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1260 set lib_child_handler if it's already initialized, which may
1261 help avoid problems on GNUStep.
1262
fa55d2aa
PE
12632013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1264
1265 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1266 * callproc.c (Fcall_process):
1267 * process.c (create_process):
1268 Make sure SIGCHLD is caught before we fork,
1269 since Emacs startup no arranges to catch SIGCHLD.
1270 * process.c (lib_child_handler): Initialize to null, not to
1271 dummy_handler.
1272 (catch_child_signal): Allow self to be called lazily.
1273 Do nothing if it's already been called.
1274 Assume caller has blocked SIGCHLD (all callers do now).
1275 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1276 just before it's really needed.
1277 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1278 since it hasn't been caught yet.
1279
f3f9606c
LMI
12802013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1281
1282 * image.c (compute_image_size): New function to implement
1283 :max-width and :max-height.
1284 (imagemagick_load_image): Use it.
1285
c7041908
PE
12862013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1289 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1290 Now extern.
1291 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1292 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1293 the SIGCHLD handler, since the code is not atomic and (due to glib)
1294 signals may be arriving now.
1295 * sysdep.c (init_signals): Do not catch child signals here;
1296 'main' now does that later, at a safer time.
1297
f86852b4
PE
12982013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1299
0dfeed58
PE
1300 Clean up SIGCHLD handling a bit (Bug#14569).
1301 * process.c, process.h (catch_child_signal):
1302 Now always extern, even if !NS_IMPL_GNUSTEP.
1303 * process.c (catch_child_signal): Move glib tickler here from
1304 init_process_emacs, so that it's done earlier in Emacs
1305 initialization. Also move the noninteractive && !initialized
1306 check here from init_process_emacs. This is all a bit cleaner for
1307 GNUish platforms, and I hope it works around the Cygwin bug.
1308 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1309 that glib signal handling is tickled before glib creates threads.
1310
f86852b4
PE
1311 * process.c (wait_reading_process_output): Avoid int overflow
1312 when reading more than 2 GiB total from a process.
1313
cbd6509c
PE
13142013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * process.c (create_process): Handle a couple more cases,
1317 i.e., work even if new_argv and wait_child_setup[i] are cached.
1318 Use Fcall_process's style for volatile vars.
1319
9de1114a
AS
13202013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1321
1322 * process.c (create_process): Mark PROCESS volatile.
1323
fbe9e0b9
PE
13242013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 Use C99-style flexible array members if available.
1327 This avoids some subtle aliasing issues, which typically
1328 aren't a problem with GCC but may be a problem elsewhere.
1329 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1330 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1331 In either case, it uses a flexible array member rather than
1332 the old struct hack. All uses changed.
1333 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1334 Adjust to sdata reorganization.
1335 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1336 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1337 that ports better to pre-C99 non-GCC.
1338 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1339 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1340 as the latter has changed.
1341 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1342 and port better to pre-C99 GCC.
1343 * image.c (struct xpm_cached_color):
1344 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1345 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1346 Use FLEXIBLE_ARRAY_MEMBER.
1347 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1348 Move decl to top level so it gets checked against implementation.
1349 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1350 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1351
1fc71008
PE
13522013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1353
1354 * syntax.c: Integer cleanups.
1355 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1356 All uses that need 0-or-2 changed to:
1357 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1358 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1359 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1360 (char_quoted, prev_char_comend_first, back_comment)
1361 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1362 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1363 Use bool for boolean.
1364 (update_syntax_table, skip_chars, skip_syntaxes):
1365 Prefer int to unsigned when either will do.
1366 (back_comment): Return boolean success flag, like forw_comment,
1367 instead of positive-or-minus-1 (which might have overflowed int anyway).
1368 Don't stuff ptrdiff_t into int.
1369 (syntax_spec_code, syntax_code_spec): Now const.
1370 (Fmatching_paren, scan_lists, scan_sexps_forward):
1371 Use enum syntaxcode for syntax code.
1372 (Fmatching_paren): Check that arg is a character, not just an integer.
1373 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1374 (Finternal_describe_syntax_value): Omit no-longer-needed
1375 comparison to 0.
1376 (skip_chars): Use char, not unsigned char, when the distinction
1377 doesn't matter.
1378 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1379 * bytecode.c (exec_byte_code):
1380 * syntax.c (syntax_spec_code, Fchar_syntax)
1381 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1382 (init_syntax_once):
1383 * syntax.h (SYNTAX_WITH_FLAGS):
1384 Omit unnecessary casts.
1385
b932cad7
EZ
13862013-06-20 Eli Zaretskii <eliz@gnu.org>
1387
1388 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1389 line dimensions here, to avoid race conditions with the main
1390 thread. (Bug#14062, bug#14630, bug#14669)
1391
1392 * w32term.c (w32_draw_window_cursor): Compute the header line and
1393 mode line dimensions here.
1394 <w32_system_caret_window, w32_system_caret_hdr_height>:
1395 <w32_system_caret_mode_height>: New variables.
1396
1397 * w32term.h: Declare them.
1398
89561f72
PE
13992013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1400
5013fc08
PE
1401 * alloc.c (die): Move "assertion failed" string here ...
1402 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1403 COND when SUPPRESS_CHECKING. This shrinks the executable text
1404 size by 0.8% to 2.2% when configured with --enable-checking,
1405 depending on optimization flags (GCC 4.8.1 x86-64).
1406
89561f72
PE
1407 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1408
763a086d 14092013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
1410
1411 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1412 base is 2; this is more accurate.
1413
983aeb9a
JB
14142013-06-19 Juanma Barranquero <lekktu@gmail.com>
1415
1416 * sound.c (string_default): Move to !WINDOWSNT section.
1417 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1418
178ba3e6
PE
14192013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1420
bbc51b15
PE
1421 * sound.c: Integer cleanups.
1422 Remove unnecessary forward decls.
1423 (struct sound_device): The 'file' member is now a Lisp_Object, not
1424 a char *, so that we needn't invoke alloca on a huge size.
1425 (Fplay_sound_internal): Adjust to this.
1426 (string_default): New function.
1427 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1428 Use it to adjust to the struct sound_device change.
1429 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1430 (be2hs) [0]: Remove.
1431
178ba3e6
PE
1432 * syntax.c (skip_chars): Don't use uninitialized storage
1433 when searching a multibyte buffer for characters that are not in a
1434 unibyte string that contains non-ASCII characters.
1435
69f60cdc
JD
14362013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1437
1438 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1439 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1440
0d6224d4
PE
14412013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1442
1443 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1444
3c542890
KH
14452013-06-18 Kenichi Handa <handa@gnu.org>
1446
f7e3f7cd
KH
1447 * font.c (Ffont_spec): Signal an error for an invalid font name
1448 (Bug#14648).
3c542890 1449
9349e5f7
PE
14502013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1453 In particular this ports to 32-bit sparc Sun cc.
1454 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1455 array with a dummy element at specpdl[-1], so that its address can
1456 be taken portably.
1457 (unbind_to): Do not copy the binding; not needed, now that we
1458 copy old_value in the one place where the copy is needed.
1459 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1460 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1461 (union specbinding): Rename from struct specbinding. Redo layout
1462 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1463 which is not portable. With Sun C 5.12 32-bit sparc, the
1464 declaration causes nargs to be an unsigned bitfield, a behavior
1465 that the C standard allows; but Emacs wants nargs to be signed.
1466 The overall type is now a union of structures rather than a
1467 structure of union of structures, and the 'kind' member is now a
1468 bitfield, so that the overall type doesn't grow. All uses changed.
1469 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1470
0a4df6a5
PE
14712013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1472
ec6ecaad
PE
1473 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1474 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1475
0a4df6a5
PE
1476 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1477
7bfe8dbc
EZ
14782013-06-17 Eli Zaretskii <eliz@gnu.org>
1479
1480 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1481 unless we know that the window w's frame is a frame object.
1482 Another attempt at solving bug#14062 and bug#14630.
1483
708e05f6
LMI
14842013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1485
1486 * textprop.c (property_set_type): New enum.
1487 (add_properties): Allow appending/prepending text properties.
1488 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1489 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1490 add_text_properties_1.
1491 (Fadd_face_text_property): New function that calls
1492 add_text_properties_1.
1493
84575e67
PE
14942013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 Move functions from lisp.h to individual modules when possible.
1497 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1498 * alloc.c (XFLOAT_INIT, set_symbol_name):
1499 * buffer.c (CHECK_OVERLAY):
1500 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1501 (set_char_table_parent):
1502 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
1503 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
1504 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
1505 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
1506 (set_blv_valcell):
1507 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
1508 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
1509 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
1510 (backtrace_args, backtrace_debug_on_exit):
1511 * floatfns.c (CHECK_FLOAT):
1512 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
1513 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
1514 (set_hash_hash, set_hash_hash_slot, set_hash_index)
1515 (set_hash_index_slot):
1516 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
1517 * marker.c (CHECK_MARKER):
1518 * textprop.c (CHECK_STRING_OR_BUFFER):
1519 * window.c (CHECK_WINDOW_CONFIGURATION):
1520 Move here from lisp.h, and make these functions static rather than
1521 extern inline.
1522 * buffer.c (Qoverlayp):
1523 * data.c (Qsubrp):
1524 * fns.c (Qhash_table_p):
1525 * window.c (Qwindow_configuration_p):
1526 Now static.
1527 * lisp.h: Remove the abovementioned defns and decls.
1528
1529 Use functions, not macros, for XINT etc. (Bug#11935).
1530 In lisp.h, prefer functions to function-like macros, and
1531 constants to object-like macros, when either will do. This:
1532 . simplifies use, as there's no more need to worry about
1533 arguments' side effects being evaluated multiple times.
1534 . makes the code easier to debug on some platforms.
1535 However, when using gcc -O0, keep using function-like macros
1536 for a few critical operations, for performance reasons.
1537 This sort of thing isn't needed with gcc -Og, but -Og
1538 is a GCC 4.8 feature and isn't widely-enough available yet.
1539 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
1540 Remove enum lsb_bits; no longer needed.
1541 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
1542 * buffer.c (Qoverlap):
1543 * data.c (Qsubrp):
1544 * fns.c (Qhash_table_p):
1545 Now extern, so lisp.h can use these symbols.
1546 * dispextern.h: Include character.h, for MAX_CHAR etc.
1547 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1548 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1549 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1550 (GLYPH_CODE_P): Move here from lisp.h.
1551 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1552 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
1553 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
1554 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
1555 XUNTAG now returns void *.
1556 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
1557 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
1558 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
1559 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
1560 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
1561 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
1562 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
1563 (lisp_h_XPNTR, lisp_h_XSYMBOL):
1564 New macros, renamed from their sans-lisp_h_ counterparts.
1565 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
1566 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
1567 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
1568 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
1569 If compiling via GCC without optimization, define these as macros
1570 in addition to inline functions.
1571 To disable this, compile with -DINLINING=0.
1572 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
1573 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
1574 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
1575 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
1576 (INTMASK, VALMASK): Now macros, since static values cannot be
1577 accessed from extern inline functions.
1578 (VALMASK): Also a constant, for benefit of old GDB.
1579 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
1580 is INTEGERP, which can fold it in.
5165d44a 1581 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
1582 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
1583 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
1584 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
1585 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
1586 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
1587 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
1588 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
1589 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
1590 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
1591 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
1592 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
1593 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
1594 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
1595 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
1596 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
1597 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
1598 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
1599 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
1600 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
1601 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
1602 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
1603 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
1604 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
1605 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
1606 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
1607 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
1608 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
1609 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
1610 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
1611 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
1612 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
1613 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
1614 Now functions.
1615 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
1616 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
1617 (VALMASK): Define in one place rather than in two, merging the
1618 USE_LSB_TAG parts; this is simpler.
1619 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
1620 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
1621 Move up, to avoid use before definition.
1622 Also include "globals.h" earlier, for the same reason.
1623 (make_natnum): New function.
1624 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
1625 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
1626 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
1627 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
1628 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
1629 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
1630 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
1631 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
1632 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
1633 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
1634 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
1635 (Qwindow_configuration_p, Qimage): New forward declarations.
1636 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
1637 (STRING_COPYIN): Remove; unused.
1638 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
1639 (xcar_addr, xcdr_addr): New functions. All uses changed.
1640 (IEEE_FLOATING_POINT): Now a constant, not a macro.
1641 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
1642 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
1643 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
1644 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
1645 (TYPE_RANGED_INTEGERP): Simplify.
1646 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
1647 (setlocale, fixup_locale, synchronize_system_messages_locale)
1648 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
1649 Now empty functions, not macros.
1650 (functionp): Return bool, not int.
1651 * window.c (Qwindow_configuration_p): Now extern,
1652 so window.h can use it.
1653 * window.h (Qwindowp): Move decl back to lisp.h.
1654
9583ec36
EZ
16552013-06-15 Eli Zaretskii <eliz@gnu.org>
1656
1657 * xdisp.c (Fline_pixel_height): New function, required for solving
1658 bug #14567.
1659
210272ce
PE
16602013-06-15 Paul Eggert <eggert@cs.ucla.edu>
1661
1662 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
1663
de0503df
SM
16642013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
1665
1666 * lread.c (syms_of_lread):
1667 * fns.c (Fprovide): Adjust to new format of after-load-alist.
1668
afbfe143
KD
16692013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
1670
1671 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
1672
d177e213
XF
16732013-06-12 Xue Fuqiao <xfq.free@gmail.com>
1674
1675 * fileio.c (expand_file_name): Doc fix.
1676
05e3e412
PE
16772013-06-11 Paul Eggert <eggert@cs.ucla.edu>
1678
f7394b12
PE
1679 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
1680 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
1681 Wait for self, not for 0. This can't hurt on GNU or similar
1682 system, and may help with Cygwin.
1683
05e3e412
PE
1684 * keyboard.c: Don't use PROP (...) as an lvalue.
1685 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
1686 Use set_prop (A, B), not PROP (A) = B.
1687
17dd3097
EZ
16882013-06-10 Eli Zaretskii <eliz@gnu.org>
1689
1690 * xdisp.c (get_it_property): Use it->window instead of generating
1691 a Lisp object from it->w.
1692
52fab9c9
EZ
16932013-06-09 Eli Zaretskii <eliz@gnu.org>
1694
1695 * xdisp.c (get_it_property): If it->object is a buffer, pass to
1696 get-char-property the window that is being rendered, instead of
1697 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
1698 (compute_display_string_pos): When W is NULL, use the current
1699 buffer as the object to pass to get-char-property.
1700 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
1701 pointer member of the bidi iterator, since no window is pertinent
1702 to this function.
52fab9c9 1703
5bf97bfc
EZ
17042013-06-08 Eli Zaretskii <eliz@gnu.org>
1705
1706 * bidi.c (bidi_fetch_char): Accept additional argument, the window
1707 being displayed, and pass it to compute_display_string_pos.
1708 (bidi_level_of_next_char, bidi_resolve_explicit_1)
1709 (bidi_paragraph_init): All callers changed.
1710
1711 * xdisp.c (init_from_display_pos, init_iterator)
1712 (handle_single_display_spec, next_overlay_string)
1713 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
1714 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
1715 Set bidi_it.w member from it->w.
5bf97bfc
EZ
1716 (compute_display_string_pos): Accept additional argument, the
1717 window being displayed, and pass it to Fget_char_property.
1718 (Bug#14575)
1719
1720 * dispextern.h (struct bidi_it): New member w, the window being
1721 displayed.
1722 (compute_display_string_pos): Adjust prototype.
1723
5de0e011
JD
17242013-06-08 Jan Djärv <jan.h.d@swipnet.se>
1725
e7b41c4c 1726 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
1727
1728 * process.c (wait_reading_process_output): Check for NS before GLIB.
1729 GLIB may be linked in due to rsvg, but ns_select must be called.
1730
5de0e011
JD
1731 * xgselect.c (xg_select): Remove call to window_system_available
1732 and g_main_context_pending at the top, so Gdk events (i.e. file
1733 notify) are processed when Emacs is started with -nw.
1734
a822acff
EZ
17352013-06-07 Eli Zaretskii <eliz@gnu.org>
1736
1737 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
1738 (ctagsfiles3): New variable, includes only *.m files.
1739 (TAGS): Use an explicit language name in the regular expressions,
1740 to avoid transformation of '/SOMETHING' by MSYS to
1741 'c:\MSYS\SOMETHING'.
1742
6c0a9ed1
RC
17432013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
1744
1745 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
1746
9ef6111b
EZ
17472013-06-06 Eli Zaretskii <eliz@gnu.org>
1748
1749 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
1750 still need to set the mouse pointer shape and activate help-echo.
1751 (Bug#14558)
1752
7d300d64
PE
17532013-06-06 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 A few porting etc. fixes for the new file monitor code.
1756 See the thread containing
1757 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
1758 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
1759 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
1760 (dir_monitor_callback, Fgfile_rm_watch):
1761 Use assq_no_quit instead of Fassoc, for speed.
1762 (dir_monitor_callback, Fgfile_rm_watch):
1763 eassert that the monitor is a fixnum.
1764 (dir_monitor_callback): No need for CDR_SAFE.
1765 Simplify building of lisp with alternative tails.
1766 (Fgfile_add_watch, Fgfile_rm_watch):
1767 Do not assume glib functions set errno reliably on failure.
1768 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
1769 and signal an error otherwise.
1770 (Fgfile_rm_watch): Prefer CONSP to !NILP.
1771 Use Fdelq instead of Fdelete, for speed.
1772
817ebfcf
EZ
17732013-06-05 Eli Zaretskii <eliz@gnu.org>
1774
1775 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
1776 don't insist on being invoked on a highlighted tool-bar button.
1777 Avoids losing tool-bar functionality when mouse-highlight is nil.
1778 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
1779 Don't highlight when mouse-highlight is nil.
1780 (note_mouse_highlight): When mouse-highlight is nil, don't return
1781 right away; instead, run tool-bar and mode-line highlight
1782 subroutine, clear any existing highlight, and revert the mouse
1783 pointer to its default shape. (Bug#14558)
1784
55577e7c
SM
17852013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1786
1787 * lisp.mk (lisp): Add prog-mode.el.
1788
f019a684
PE
17892013-06-05 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
1792 * process.c (dummy_handler): New function.
1793 (lib_child_handler): New static var.
1794 (handle_child_signal): Invoke it.
1795 (catch_child_signal): If a library has set up a signal handler,
1796 save it into lib_child_handler.
1797 (init_process_emacs): If using glib and not on Windows, tickle glib's
1798 child-handling code so that it initializes its private SIGCHLD handler.
1799 * syssignal.h (SA_SIGINFO): Default to 0.
1800 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
1801 31; it should no longer be needed now.
1802
90db8702
MA
18032013-06-05 Michael Albinus <michael.albinus@gmx.de>
1804
1805 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
1806
1807 * gfilenotify.c (globals_of_gfilenotify): New function.
1808 (syms_of_gfilenotify): Move global initialization there.
1809
1810 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
1811
bfa3acd6
SM
18122013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
1815 * keyboard.c (menu_bar_items, tool_bar_items):
1816 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
1817 not override local keymaps any more.
1818
ba59bd80
EZ
18192013-06-04 Eli Zaretskii <eliz@gnu.org>
1820
1821 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
1822
7f203aa1
EZ
18232013-06-03 Eli Zaretskii <eliz@gnu.org>
1824
9337e206
EZ
1825 * w32console.c (initialize_w32_display): Return the dimensions of
1826 the console window via 2 additional arguments, not via the current
1827 frame. This avoids crashes due to overrunning the bounds of
1828 frame's decode_mode_spec_buffer, which is not resized following
1829 the change of the frame dimensions from the initial 10x10.
1830
1831 * w32term.h (w32_initialize_display_info): Adjust prototype.
1832
1833 * term.c (init_tty): Take dimensions of the frame from the values
1834 returned by initialize_w32_display.
1835
7f203aa1
EZ
1836 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
1837 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
1838 (LIBES): Add $(GFILENOTIFY_LIBS).
1839
1840 * w32inevt.c (handle_file_notifications): Add dummy implementation
1841 for !HAVE_W32NOTIFY.
1842
1843 * w32term.c: Wrap code with HAVE_W32NOTIFY.
1844
55a87246
JD
18452013-06-03 Jan Djärv <jan.h.d@swipnet.se>
1846
1847 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
1848
1849 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
1850
1851 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
1852
3d5ee10a
PE
18532013-06-03 Paul Eggert <eggert@cs.ucla.edu>
1854
1855 Fix minor problems found by static checking.
1856 * data.c (pure_write_error):
1857 Use xsignal2, not Fsignal, as Fsignal might return.
1858 * eval.c (set_backtrace_debug_on_exit): Now static.
1859 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
1860 No longer inline. EXTERN_INLINE is needed only for functions
1861 defined in .h files. Reindent function header as per GNU style.
1862 (backtrace_p, backtrace_top, backtrace_next):
1863 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
1864 compiler or linker. Add extern decls to pacify gcc -Wall.
1865 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
1866 Now static.
1867 * frame.c (free_monitors): Define only on platforms that need it.
1868 * nsterm.m (ns_term_init):
1869 * process.c (catch_child_signal):
1870 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
1871 defined on all porting targets these days.
1872 * process.c, process.h (catch_child_signal):
1873 Make it extern only if NS_IMPL_GNUSTEP is defined.
1874
e2d8a6f0
EZ
18752013-06-03 Eli Zaretskii <eliz@gnu.org>
1876
1877 * w32.c (gettimeofday): Make the signature identical to prototype
1878 in nt/inc/sys/time.h.
1879
a8a7c5f6
SM
18802013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1881
1882 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
1883 .gdbinit.
1884
1885 * keyboard.c (safe_run_hooks_error): Improve error message.
1886
1887 * data.c (pure_write_error): Add `object' argument.
1888 * puresize.h (CHECK_IMPURE): Use it.
1889
c9628c79
MA
18902013-06-03 Michael Albinus <michael.albinus@gmx.de>
1891
1892 * Makefile.in (NOTIFY_OBJ): New variable.
1893 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
1894
1895 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
1896 Call syms_of_gfilenotify.
1897
1898 * gfilenotify.c: New file.
1899
1900 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
1901 and Qfile_w32notify.
1902 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
1903 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
1904
1905 * lisp.h: Declare syms_of_gfilenotify.
1906
1907 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
1908
2f592f95
SM
19092013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
1910
1911 Merge the specpdl and backtrace stacks. Make the structure of the
1912 specpdl entries more obvious via a tagged union of structs.
1913 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
1914 (enum specbind_tag): New enum.
1915 (struct specbinding): Make it a tagged union of structs.
1916 Add a case for backtrace records.
1917 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
1918 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
1919 (backtrace_debug_on_exit): New accessors.
1920 (struct backtrace): Remove.
1921 (struct catchtag): Remove backlist field.
1922 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1923 Move to eval.c.
1924 (Flocal_variable_p): Speed up the common case where the binding is
1925 already loaded.
1926 * eval.c (backtrace_list): Remove.
1927 (set_specpdl_symbol, set_specpdl_old_value): Remove.
1928 (set_backtrace_args, set_backtrace_nargs)
1929 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
1930 (backtrace_next): New functions.
1931 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
1932 (unwind_to_catch, internal_lisp_condition_case)
1933 (internal_condition_case, internal_condition_case_1)
1934 (internal_condition_case_2, internal_condition_case_n): Don't bother
1935 with backtrace_list any more.
1936 (Fsignal): Adjust to new backtrace format.
1937 (grow_specpdl): Move up.
1938 (record_in_backtrace): New function.
1939 (eval_sub, Ffuncall): Use it.
1940 (apply_lambda): Adjust to new backtrace format.
1941 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
1942 data.c.
1943 (specbind): Adjust to new specpdl format. Simplify.
1944 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
1945 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
1946 backtrace format.
1947 (mark_backtrace): Remove.
1948 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
1949 * xdisp.c (redisplay_internal): Use record_in_backtrace.
1950 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
1951 Use mark_specpdl.
1952 * profiler.c (record_backtrace): Use get_backtrace.
1953 (handle_profiler_signal): Use backtrace_top_function.
1954 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
1955 accessor functions.
1956
c0342369
JD
19572013-06-02 Jan Djärv <jan.h.d@swipnet.se>
1958
1959 * process.h (catch_child_signal): Declare.
1960
1961 * process.c (catch_child_signal): New function.
1962 (init_process_emacs): Call it.
1963
1964 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
1965 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
1966 NS_IMPL_COCOA.
1967 (x_set_cursor_type): Remove declaration.
1968 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
1969 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
1970 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
1971 (ns_get_color): Use F suffix on float.
1972 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
1973 (ns_get_rgb_color): Remove.
1974 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
1975 (note_mouse_movement): x and y are CGFloat.
1976 (ns_draw_fringe_bitmap): Remove unused rowY.
1977 Change #if to COCOA && >= 10_6.
1978 (ns_draw_window_cursor): Remove unused overspill.
1979 (ns_draw_underwave): width and x are EamcsCGFloat.
1980 (ns_draw_box): thickness is CGFloat.
1981 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
1982 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
1983 if not in main thread.
1984 (ns_get_pending_menu_title, ns_check_menu_open)
1985 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
1986 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
1987 (sendFromMainThread:): New method.
1988 (changeFont:): size is CGFloat.
1989 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
1990 Disable warning about permanent text.
1991 (characterIndexForPoint:): Adjust return type depending on GNUStep
1992 version.
1993 (mouseDown:): delta is CGFloat.
1994 (updateFrameSize): Remove unised variable f.
1995 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
1996 Cast float to EmacsCGFloat.
1997 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
1998 also to -1 when restoring.
1999 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2000 inside NS_IMPL_COCOA.
2001 (toggleFullScreen:): Put call to toggleFullScreen inside
2002 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2003 (setPosition:portion:whole:): por is CGFloat.
2004 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2005 (mouseDown:): Use CGFloat.
2006 (mouseDragged:): Remove unised variable edge.
2007 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2008
2009 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2010 of CGFloat differs.
2011 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2012 when NS_IMPL_GNUSTEP.
2013 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2014 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2015 (EmacsToolbar): Add clearAll. Add tag argument to
2016 addDisplayItemWithImage.
2017 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2018
2019 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2020
2021 * nsmenu.m (ns_update_menubar): Make static.
2022 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2023 (fillWithWidgetValue:): Add cast to SEL for setAction.
2024 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2025 (update_frame_tool_bar): Update code for GNUStep.
2026 (clearAll): New method.
2027 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2028 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2029 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2030 call to insertItemWithItemIdentifier.
2031 (validateVisibleItems): Fix indentation.
2032 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2033 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2034 UtilityWindow to aStyle, remove call to setStyleMask.
2035
2036 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2037
2038 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2039 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2040 Use F suffix on floats.
2041 (ns_char_width): Returns CGFloat.
2042 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2043 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2044 DPSxshow.
2045 (ns_glyph_metrics): CGFloat instead of float.
2046
a0eb10b3
JB
2047 * nsfns.m (x_set_foreground_color, x_set_background_color):
2048 Use EmacsCGFloat.
2049 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2050 remove unused variables.
2051 (Fns_read_file_name): Keep track if panel is for save.
2052 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2053 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2054 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2055 Just return the input if GNUStep.
c0342369
JD
2056 (x_screen_planes): Remove.
2057 (Fxw_color_values): Use EmacsCGFloat
2058 (Fns_display_monitor_attributes_list): Only get screen number for
2059 Cocoa.
ef099a94 2060 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2061 EmacsSavePanel.
2062 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2063 ns_directory_from_panel.
2064
da9aff11
PE
20652013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 * process.c (handle_child_signal): Also use WCONTINUED.
2068 This is so that list-processes doesn't mistakenly list the process
2069 as stopped, when the process has actually been continued and is
2070 now running.
2071
0e64479a
PE
20722013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2073
fc186a96
PE
2074 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2075 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2076 not already configured.
2077
0e64479a
PE
2078 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2079
38b787fa
EZ
20802013-05-29 Eli Zaretskii <eliz@gnu.org>
2081
2082 * Makefile.in (mostlyclean): Remove *.res files.
2083
22513e52
SM
20842013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2085
2086 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2087 a buffer (bug#8447).
2088
6ef3db10
EZ
20892013-05-27 Eli Zaretskii <eliz@gnu.org>
2090
2091 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2092 display vector, and we backtrack, handle the case that the
2093 previous character position is also displayed from a display
2094 vector or covered by a display string or image. (Bug#14476)
2095
6799bb26
JD
20962013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2097
2098 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2099 (struct MonitorInfo, free_monitors): Remove.
2100 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2101 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2102 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2103 Qframes, Qsource.
2104
2105 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2106 (struct MonitorInfo, free_monitors): Remove.
2107 (ns_screen_name): Make static.
2108 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2109 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2110 Qframes, Qsource.
2111
2112 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2113 (struct MonitorInfo): New struct.
2114 (free_monitors, make_monitor_attribute_list): Declare.
2115
22513e52
SM
2116 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2117 New Lisp_Object:s.
6799bb26
JD
2118 (free_monitors, make_monitor_attribute_list): New functions.
2119 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2120 Qsource.
2121
38cd43eb
XF
21222013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2123
2124 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2125
2af0948d
SM
21262013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2127
a7eb9b0f
SM
2128 * keyboard.c: Apply keyboard decoding only to events that come directly
2129 from the tty, not from unread-command-events (bug#14368).
2130 (read_event_from_main_queue): New function, extracted from read_char).
2131 (read_decoded_char): Remove.
2132 (read_decoded_event_from_main_queue): New function to replace it.
2133 (read_char): Use it.
2134 (read_key_sequence): Use read_char rather than read_decoded_char.
2135
2af0948d
SM
2136 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2137
1413e9a5
BR
21382013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2139
2140 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2141
e6d2f155
KH
21422013-05-22 Kenichi Handa <handa@gnu.org>
2143
2144 The following changes are to fix the setting of
2145 buffer-file-coding-system on, for instance, C-x RET c unix RET
2146 _FILE_OF_DOS_EOL_TYPE_ RET.
2147
2148 * coding.h (struct coding_system): New member detected_utf8_chars.
2149
2150 * coding.c (detect_coding_utf_8): Count characters and check EOL
2151 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2152 BOM is there.
2153 (setup_coding_system): Do not initialize coding->head_ascii.
2154 (check_ascii): Do not set coding->eol_seen but update it. Do not
2155 call adjust_coding_eol_type here.
1413e9a5
BR
2156 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2157 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2158 of the found coding-system.
2159 (decode_coding_gap): Cancel previous change. Utilize the
2160 character numbers counted by detect_coding_utf_8. Fix detection
2161 of BOM for utf-8.
2162
ab56a6f4 21632013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2164
2165 * search.c (looking_at_1): Only set last_thing_searched if the match
2166 changed the match-data (bug#14281).
2167
ecc3c6ed
DA
21682013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2169
2170 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2171 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2172 (move_it_vertically_backward): Likewise.
2173
5ba8bf35
YM
21742013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2175
2176 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2177 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2178 (Fx_display_mm_width, Fx_display_mm_height):
2179 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2180
91e8418b 2181 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2182 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2183 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2184 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2185 (Fx_display_backing_store, Fx_display_visual_class)
2186 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2187 (Fx_display_grayscale_p, Fx_display_pixel_width)
2188 (Fx_display_pixel_height, Fx_display_planes)
2189 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2190 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2191 (Fx_display_mm_width, Fx_display_mm_height)
2192 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2193 height for all physical monitors as in X11.
2194
fc30d803
SM
2195 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2196 Return pixel width or height for all physical monitors as in X11.
91e8418b 2197
31ff141c
PE
21982013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 Port --enable-gcc-warnings to clang.
2201 * bytecode.c (exec_byte_code):
2202 * regex.c:
2203 Redo diagnostic pragmas to pacify clang, too.
2204 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2205 * editfns.c (Fencode_time):
2206 * fileio.c (file_accessible_directory_p):
2207 * font.c (font_unparse_xlfd):
2208 Use '&"string"[index]' instead of '"string" + (index)'.
2209 * undo.c (user_error): Remove; unused.
2210
df065a0b
EZ
22112013-05-16 Eli Zaretskii <eliz@gnu.org>
2212
04d360e7
EZ
2213 * insdel.c (insert_1_both): Document the arguments, instead of
2214 referring to insert_1, which no longer exists.
2215
5bb98290
EZ
2216 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2217 some window, increment windows_or_buffers_changed, so that
2218 *Messages* display in that window is updated. (Bug#14408)
2219
df065a0b
EZ
2220 * w32.c: Include epaths.h.
2221 (init_environment): Use cmdproxy.exe without leading directories.
2222 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2223 case.
2224 (gettimeofday): Adjust signature and return value to Posix
2225 expectations.
2226
2227 * unexw32.c (open_output_file): Delete the existing emacs.exe
2228 before creating it, to break the hard link to the versioned
2229 executable.
2230
2231 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2232 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2233 (FIRSTFILE_OBJ): New variables.
2234 (W32_RES): Rename to EMACSRES. All users changed.
2235 (base_obj): Use $(CM_OBJ).
2236 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2237 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2238 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2239 $(W32_RES_LINK) before $(LIBES).
2240 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2241
1aa8d505
SM
22422013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2243
6e911150
SM
2244 * makefile.w32-in (DOC): Use just "DOC".
2245
2246 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2247
1aa8d505
SM
2248 * process.c: Export default filters and sentinels to Elisp.
2249 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2250 New constants.
2251 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2252 (Fset_process_sentinel, Fformat_network_address):
2253 Default to them instead of nil.
2254 (server_accept_connection): Sentinels can't be nil any more.
2255 (read_and_dispose_of_process_output): New function, extracted from
2256 read_process_output.
2257 (read_process_output): Use it; filters can't be nil.
2258 (Finternal_default_process_filter): New function, extracted from
2259 read_process_output.
2260 (exec_sentinel_unwind): Remove function.
2261 (exec_sentinel): Don't zilch sentinel while running.
2262 (status_notify): Sentinels can't be nil.
2263 (Finternal_default_process_sentinel): New function extracted from
2264 status_notify.
2265 (setup_process_coding_systems): Default filter is not nil any more.
2266 (syms_of_process): Export new Elisp functions and initialize
2267 new constants.
2268 * lisp.h (make_lisp_proc): New function.
2269
5ac2eb34
SM
22702013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2271
2272 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2273
eda9c7d7
EZ
22742013-05-14 Eli Zaretskii <eliz@gnu.org>
2275
2276 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2277 unless we know that the window w is a leaf window.
2278 Another attempt at solving bug#14062.
eda9c7d7 2279
8fdeaad5
JD
22802013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2281
2282 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2283 fdesc (Bug#14375).
2284
44aa9ee6
PE
22852013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 * image.c (gif_load): Check that subimages fit (Bug#14345).
2288
759fd763
SM
22892013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2290
2291 * lread.c (skip_dyn_eof): New function.
2292 (read1): Use it to skip the end of a file in response to #@00.
2293
2294 * doc.c (get_doc_string): Slightly relax the sanity checking.
2295
4465bfb4
JD
22962013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2297
2298 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2299 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2300 (MonitorInfo): New struct.
2301 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2302 (Fns_display_monitor_attributes_list): New functions.
2303 (display-usable-bounds): Remove.
2304 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2305 Qsource.
2306
7583e2a0
PE
23072013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2310 (GTK_CHECK_VERSION): New macro, if not already defined.
2311 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2312 replaced by GTK_CHECK_VERSION.
2313
ad75d77e
PE
23142013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 * xterm.h (GTK_PREREQ): New macro.
2317 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2318 to use this macro instead, for consistency and clarity.
2319
07525f77
EZ
23202013-05-08 Eli Zaretskii <eliz@gnu.org>
2321
2322 * xdisp.c (row_for_charpos_p): New function, with code of
2323 cursor_row_p, but accepts an additional argument CHARPOS instead
2324 of using a hardcoded PT.
2325 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2326 (row_containing_pos): Call row_for_charpos_p instead of partially
2327 doing the same. Fixes cursor positioning under longlines-mode
2328 when longlines-show-effect includes more than one newline, when
2329 moving the cursor vertically up.
2330
d901fc8d
JB
23312013-05-08 Juanma Barranquero <lekktu@gmail.com>
2332
2333 * makefile.w32-in (ACL_H): New macro.
2334 ($(BLD)/fileio.$(O)): Update dependencies.
2335
f269bc61
PE
23362013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2337
e7b41c4c 2338 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2339 * Makefile.in (LIB_ACL): New macro.
2340 (LIBACL_LIBS): Remove.
2341 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2342 * fileio.c: Include <acl.h>.
2343 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2344 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2345 !acl_errno_valid.
2346 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2347 it ourselves.
2348
f269bc61
PE
2349 * unexelf.c: Don't assume ElfW (Half) fits in int.
2350 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2351 when dealing with ElfW (Half) values, since they can exceed 2**31
2352 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2353 (entry_address): Omit unused NUM arg. All uses changed.
2354
a261c53e
JL
23552013-05-07 Juri Linkov <juri@jurta.org>
2356
2357 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2358 to the string converted from number with `Fnumber_to_string'.
2359 (Bug#14254)
2360
2b66427d
PE
23612013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2362
2363 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2364 This fixes a problem introduced by my previous change.
2365
15acfe41
GM
23662013-05-07 Glenn Morris <rgm@gnu.org>
2367
2368 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2369
5ea03bf5
JD
23702013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2371
2372 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2373
e0c9d565
PE
23742013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 Static checking by GCC 4.8.0.
2377 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2378 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2379 (x_get_monitor_attributes_fallback)
2380 (x_get_monitor_attributes_xinerama)
2381 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2382 Define only if USE_GTK.
2383 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2384 (x_get_monitor_attributes_fallback): Omit unused locals.
2385 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2386 Use double, not float, to avoid mixed-mode floating point arithmetic.
2387
4e3f9230
YM
23882013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2389 Jan Djärv <jan.h.d@swipnet.se>
2390
2391 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2392 (XINERAMA_CFLAGS): New macros.
2393 (ALL_CFLAGS, LIBES): Use them.
2394
2395 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2396 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2397 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2398 (syms_of_xfns): DEFSYM them.
2399 (struct MonitorInfo): New struct.
2400 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2401 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2402 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2403 (x_get_monitor_attributes_xinerama): New functions.
2404 (Fx_display_monitor_attributes_list): New primitive.
2405 (syms_of_xfns): Defsubr it.
2406
2407 * xterm.h (x_display_info): Add Xatom_net_workarea and
2408 Xatom_net_current_desktop.
2409
2410 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2411 and dpyinfo->Xatom_net_current_desktop.
2412
05839b6a
EZ
24132013-05-06 Eli Zaretskii <eliz@gnu.org>
2414
2415 * xdisp.c (pos_visible_p): Use the special code for finding the
2416 beginning of a display property or overlay for any "replacing"
2417 display property, not just for display strings. This solves
2418 incorrect reporting of position by posn-at-point. (Bug#14241)
2419
dc4a2ee0
PE
24202013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2421
5ee94506
PE
2422 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2423 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2424 Verify that ElfW (Half) fits in int.
2425 (fatal): Use same signature as lisp.h.
2426 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2427 configure and build with -DUNEXELF_DEBUG without worrying about
2428 other modules that use DEBUG.
2429 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2430 possibly-wide integers now uses it instead of plain fprintf.
2431 (entry_address): New function, which avoids problems with 32-bit
2432 overflow on 64-bit hosts.
2433 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2434 (round_up): Don't assume the remainder fits in int.
2435 (find_section): Use bool for boolean. Simplify debug code.
2436 (unexec): Don't assume file sizes fit in int or size_t.
2437 Omit unnecessary trailing newline in 'fatal' format.
2438 Use strerror rather than outputting decimal error number.
2439 Remove unused code when emacs is not defined;
2440 this file relies on Emacs now.
2441 Don't assume e_phnum and e_shnum are positive.
2442
dc4a2ee0
PE
2443 * regex.c: Fix problems when DEBUG is defined.
2444 (extract_number, extract_number_and_incr): Define regardless of
2445 whether DEBUG is defined; that's simpler and makes the code less
2446 likely to go stale in the normal case when DEBUG is not defined.
2447 Return int rather than taking an int * arg. All callers changed.
2448 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2449 Remove, replacing with ...
2450 (DEBUG_PRINT): New macro. All callers changed.
2451 (DEBUG_COMPILES_ARGUMENTS): New macro.
2452 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2453 (print_compiled_pattern, print_double_string) [DEBUG]:
2454 Use prototype rather than old-style definition.
2455 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2456 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2457 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2458 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2459 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2460 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2461 This matters only when DEBUG is defined.
2462
14c7ed05
EZ
24632013-05-05 Eli Zaretskii <eliz@gnu.org>
2464
2465 * xdisp.c (set_iterator_to_next): Set the
2466 ignore_overlay_strings_at_pos_p flag only if we are _really_
2467 iterating over an overlay string, as indicated by the
2468 current.overlay_string_index member. (Bug#14306)
2469
e6076b1b
JD
24702013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2471
2472 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2473 to where it is used, to avoid autorelease issues (Bug#14050).
2474
cbee2131
PE
24752013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2478 * fileio.c (syms_of_fileio): Implement this.
2479 * filelock.c (create_lock_file): If symbolic links don't work, so
2480 we use a regular file as a lock file, do not fsync the lock file;
2481 it's not needed.
2482
30c7e542
SM
24832013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2484
2485 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2486 (syms_of_minibuf): Adjust accodingly.
2487 * lread.c (Fread):
2488 * callint.c (Fcall_interactively): Adjust calls accordingly.
2489
5bebd186
EZ
24902013-05-04 Eli Zaretskii <eliz@gnu.org>
2491
2492 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2493 w->contents is a buffer before computing everything else.
2494 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2495
2496 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2497 assertion violations. (Bug#14062)
2498
0fb0a4f3
DR
24992013-05-01 David Reitter <david.reitter@gmail.com>
2500
2501 * nsfns.m (ns_tooltip): Initialize.
2502
9e63b4a5
EZ
25032013-04-28 Eli Zaretskii <eliz@gnu.org>
2504
2505 * coding.c (decode_coding_gap): Don't remove the character before
2506 a newline unless it's a CR character. (Bug#14287)
2507
ad60824e
DN
25082013-04-28 Dan Nicolaescu <dann@gnu.org>
2509
2510 * dispextern.h (struct face): Move enum face_underline_type
2511 earlier so that bitfields can be in the same word.
2512
edbdcec0
JD
25132013-04-28 Jan Djärv <jan.h.d@swipnet.se>
2514
2515 * nsfns.m (handlePanelKeys): New function.
2516 (EmacsOpenPanel:performKeyEquivalent:)
2517 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
2518 arrows/function/control and copy/paste keys (Bug#14296).
2519
0208ede7
JL
25202013-04-27 Juri Linkov <juri@jurta.org>
2521
2522 * callint.c (Fcall_interactively): Call `Qread_number' for
2523 interactive code letter `n' instead of using duplicate code.
2524 (Bug#14254)
2525
b8dd59f7
PE
25262013-04-27 Paul Eggert <eggert@cs.ucla.edu>
2527
2528 * systime.h (make_timeval): Declare as 'const'.
2529
8bd722db
KH
25302013-04-27 Kenichi Handa <handa@gnu.org>
2531
2532 * font.c (font_open_entity): Always open a font of manageable
2533 size.
2534
13d0e56f 25352013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 2536
f780d632
PE
2537 Port better to AIX (Bug#14258).
2538 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
2539 to pacify AIX xlc.
2540
ec509856
KH
25412013-04-24 Kenichi Handa <handa@gnu.org>
2542
2543 * coding.c (decode_coding_iso_2022): When an invalid escape
2544 sequence is encountered, reset the invocation and designation
2545 status to the safest one.
2546
84fc48e5
PE
25472013-04-22 Paul Eggert <eggert@cs.ucla.edu>
2548
2549 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
2550 Without this fix, "make distclean" leaves stamp-h1 behind.
2551
806bda47
EC
25522013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
2553
2554 * w32fns.c (w32_fullscreen_rect): New function to compute the
2555 window rectangle for the given fullscreen mode.
2556 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
2557 longer tunes the window size. This keeps the window's edges flush
2558 with the screen and allows the taskbar to hide itself in fullboth.
2559
2560 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
2561 window decorations and uses the entire screen.
2562
2563 * w32term.h (w32_fullscreen_rect) Add prototype.
2564 (struct w32_output): Replace normal_width, normal_height,
2565 normal_top, and normal_left members with a single normal_placement
2566 struct.
2567 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
2568 Remove macros.
2569 (FRAME_NORMAL_PLACEMENT): New macro.
2570
9cc2810b
JB
25712013-04-16 Juanma Barranquero <lekktu@gmail.com>
2572
2573 * minibuf.c (Ftest_completion): Silence compiler warning.
2574
fd16b54c
EZ
25752013-04-15 Eli Zaretskii <eliz@gnu.org>
2576
2577 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 2578 bug#14062.
fd16b54c
EZ
2579
2580 * frame.h (WINDOW_FRAME): Protect macro and its argument with
2581 parentheses.
2582
2583 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
2584 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
2585 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
2586 parentheses where appropriate.
2587
9e3379a0
PE
25882013-04-14 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 * keyboard.c (timer_start_idle): Remove no-longer-used local.
2591
ddd6b685
EZ
25922013-04-14 Eli Zaretskii <eliz@gnu.org>
2593
2594 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
2595 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
2596 Mention in the doc string that setting these variables takes
2597 effect only after a call to set-window-buffer. (Bug#14200)
2598
29b79ba1
EZ
25992013-04-13 Eli Zaretskii <eliz@gnu.org>
2600
2601 * indent.c (Fvertical_motion): Don't consider display strings on
2602 overlay strings as display strings on the buffer position we
2603 started from. This prevents vertical cursor motion from jumping
2604 more than one line when there's an overlay string with a display
2605 property at end of line.
2606 Reported by Karl Chen <Karl.Chen@quarl.org> in
2607 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
2608
562c6ee9
SM
26092013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
2610
2611 * window.c (select_window): `record_buffer' even if window is
2612 already selected (bug#14191).
2613
fcc1fe85
EZ
26142013-04-11 Eli Zaretskii <eliz@gnu.org>
2615
2616 * window.c (Fwindow_end): Test more flags, including the buffer's
2617 last_overlay_modified flag, to determine whether the window's
2618 display is really up-to-date. Prevents the function from
2619 returning a stale value. (Bug#14170)
2620 (Fwindow_line_height): Fix the test for up-to-date-ness of the
2621 current matrix.
2622
f009190a
EZ
26232013-04-10 Eli Zaretskii <eliz@gnu.org>
2624
2625 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
2626 garbaged only if it is not already the top frame on its TTY.
2627 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
2628 there are GUI frames open in the same session. (Bug#13864)
2629
78ce603d
SM
26302013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
2631
2632 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
2633 of marking the idle timers directly.
2634
a8036e40
SM
26352013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
2636
2637 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
2638 tables (bug#14054).
2639
7ffe7ef6
SM
26402013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
2641
2642 * window.c (select_window): Don't record_buffer while the invariant is
2643 temporarily broken (bug#14161).
2644
2645 * fns.c (Fdelq): Don't assume !NILP => CONSP.
2646
7d9f6883
EZ
26472013-04-07 Eli Zaretskii <eliz@gnu.org>
2648
2649 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
2650
5406cfd9
RF
26512013-04-07 Romain Francoise <romain@orebokech.com>
2652
2653 Ignore additional platform-specific ACL errors (Bug#13702).
2654 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
2655 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
2656
95c0e83b
JD
26572013-03-31 Jan Djärv <jan.h.d@swipnet.se>
2658
2659 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
2660 f->output_data.ns.
2661
876da980
PE
26622013-04-07 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
2665 This bug was introduced by my 2013-02-25 change that simplified
2666 data_start configuration. Without this change, on GNU/Linux
2667 an Emacs configured with --enable-profiling fails immediately
2668 due to a profiler signal.
2669 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
2670 with these flags. On platforms where special flags are needed
2671 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
2672 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
2673 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
2674
7452b7bd
DA
26752013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
2676
2677 Get rid of some platform-specific functions examining window
2678 system and its capabilities. This is a partial rework of the
2679 2013-04-05 change.
2680 * lisp.h (have_menus_p): Remove prototype. This function is
2681 replaced with platform-independent window_system_available.
2682 (check_window_system): Move to...
2683 * frame.h (decode_window_system_frame, window_system_available):
2684 ...here, add new prototypes.
2685 * frame.c (window_system_available, decode_window_system_frame):
2686 New functions.
2687 (check_window_system): Platform-independent now.
2688 * xterm.h (x_in_use): Remove declaration.
2689 (check_x_frame):
2690 * w32term.h (check_x_frame):
2691 * nsterm.h (check_x_frame): Remove prototypes. This function
2692 is replaced with platform-independent decode_window_system_frame.
2693 * msdos.c (have_menus_p): Remove.
2694 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
2695 Remove platform-specific functions. Use check_window_system,
2696 decode_window_system_frame and check_ns_display_info where
2697 appropriate. Minor style and comment tweaks.
2698 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
2699 (check_x_frame): Likewise.
2700 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
2701 Likewise.
2702 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
2703 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
2704 * xmenu.c, xselect.c: All related users changed.
2705
251e9147
KH
27062013-04-03 Kenichi Handa <handa@gnu.org>
2707
2708 The following changes is to optimize the code for reading UTF-8
2709 files.
2710
562c6ee9 2711 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
2712 changed. Check EOL format. Do not call adjust_coding_eol_type
2713 here.
2714 (check_utf_8): New function.
2715 (adjust_coding_eol_type): Do nothing if already adjusted.
2716 (detect_coding): Compare the return value of check_ascii with
2717 coding->src_bytes. Call adjust_coding_eol_type if necessary.
2718 (decode_coding_gap): Optimize for valid UTF-8.
2719
8bc369d4
KH
27202013-03-21 Kenichi Handa <handa@gnu.org>
2721
2722 * coding.c (syms_of_coding): Cancel previous change.
2723
2724 * insdel.c (insert_from_gap): Fix previous change.
2725
73931ad1
DA
27262013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
2727
2728 Consistently use platform-specific function to detect window system.
2729 * lisp.h (check_window_system): New prototype. This function is
2730 going to replace check_x, check_w32 and check_ns.
2731 (have_menus_p): Mention msdos.c in comment.
2732 * fontset.c (check_window_system_func): Remove. Adjust all users.
2733 * fontset.h (check_window_system_func): Remove prototype.
2734 * nsterm.h (check_ns):
2735 * xterm.h (check_x):
2736 * w32term.h (check_w32): Likewise.
2737 * menu.c (Fx_popup_menu): Use check_window_system.
2738 * msdos.c (check_window_system): Define for MS-DOS.
2739 * nsfns.m (check_window_system): Define for NS. Adjust all users.
2740 * w32fns.c (check_window_system): Likewise for MS-Windows.
2741 * xfns.c (check_window_system): Likewise for X.
2742 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
2743 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
2744
7216e43b
PE
27452013-04-02 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 Prefer < to > in range checks such as 0 <= i && i < N.
2748 This makes it easier to visualize quantities on a number line.
2749 This patch doesn't apply to all such range checks,
2750 only to the range checks affected by the 2013-03-24 change.
2751 This patch reverts most of the 2013-03-24 change.
2752 * alloc.c (xpalloc, Fgarbage_collect):
2753 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
2754 * character.c (string_escape_byte8):
2755 * charset.c (read_hex):
2756 * data.c (cons_to_unsigned):
2757 * dispnew.c (update_frame_1):
2758 * doc.c (Fsubstitute_command_keys):
2759 * doprnt.c (doprnt):
2760 * editfns.c (hi_time, decode_time_components):
2761 * fileio.c (file_offset):
2762 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2763 * font.c (font_intern_prop):
2764 * frame.c (x_set_alpha):
2765 * gtkutil.c (get_utf8_string):
2766 * indent.c (check_display_width):
2767 * keymap.c (Fkey_description):
2768 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
2769 * lread.c (read1):
2770 * minibuf.c (read_minibuf_noninteractive):
2771 * process.c (wait_reading_process_output):
2772 * search.c (Freplace_match):
2773 * window.c (get_phys_cursor_glyph):
2774 * xdisp.c (redisplay_internal):
2775 * xsmfns.c (smc_save_yourself_CB):
2776 Prefer < to > for range checks.
2777 * dispnew.c (sit_for): Don't mishandle NaNs.
2778 This fixes a bug introduced in the 2013-03-24 change.
2779 * editfns.c (decode_time_components): Don't hoist comparison.
2780 This fixes another bug introduced in the 2013-03-24 change.
2781
92759988
DA
27822013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
2783
2784 * frame.h (struct frame): Drop scroll_bottom_vpos
2785 member becaue all real users are dead long ago.
2786 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
2787 * xdisp.c (redisplay_internal): Adjust user.
2788
9a1971bb
GM
27892013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
2790
f38ab167
JD
2791 * nsmenu.m (showAtX:Y:for:): setLevel to
2792 NSPopUpMenuWindowLevel (Bug#13998).
2793
6d01f1fe
JD
27942013-03-30 Jan Djärv <jan.h.d@swipnet.se>
2795
2796 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
2797 (ns_check_pending_open_menu): Declare.
2798
2799 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
2800 (x_activate_menubar): Update the menu with title that matches
2801 ns_get_pending_menu_title, and call
2802 ns_check_pending_openmenu (Bug#12698).
2803 (menuWillOpen:): New method.
2804 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
2805
2806 * nsterm.m (menu_will_open_state, menu_mouse_point)
2807 (menu_pending_title): New varaibles.
2808 (ns_get_pending_menu_title, ns_check_menu_open)
2809 (ns_check_pending_open_menu): New functions.
2810
781f4782
DA
28112013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
2812
2813 * indent.c (current_column_bol_cache): Remove leftover which is not
2814 used in Fmove_to_column any more.
2815 (current_column, scan_for_column): Adjust users.
2816 * keyboard.c (last_point_position_buffer, last_point_position_window):
2817 Remove leftovers which are not used for recording undo any more.
2818 (command_loop_1, syms_of_keyboard): Adjust users.
2819 * xdisp.c (last_max_ascent): Remove leftover which is not used in
2820 redisplay_window any more.
2821 (move_it_to): Adjust user.
2822
1921c31b
JB
28232013-03-29 Juanma Barranquero <lekktu@gmail.com>
2824
2825 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
2826 Update dependencies.
2827
717b8bcd
SM
28282013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2829
2830 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
2831 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
2832 forward references.
2833
e74aeda8
DA
28342013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2835
2836 * window.h (struct window): Replace hchild, vchild and buffer slots
2837 with the only contents slot. This is possible because each valid
2838 window may have either the child window (in vertical or horizontal
2839 combination) or buffer to display (for the leaf window). Using that,
2840 a lof of operations to traverse and/or change window hierarchies may
2841 be simplified. New member horizontal is used to distinguish between
2842 horizontal and vertical combinations of internal windows.
2843 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
2844 (WINDOW_VERTICAL_COMBINATION_P): New macros.
2845 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
2846 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
2847 Use contents slot, not buffer, where appropriate.
2848 (wset_combination): New function.
2849 (wset_buffer): Add eassert.
2850 (Fframe_first_window): Simplify the loop reaching first window.
2851 (Fwindow_buffer): Use WINDOW_LEAF_P.
2852 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
2853 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
2854 (unshow_buffer): Convert initial debugging check to eassert.
2855 (replace_window, recombine_windows, Fdelete_other_windows_internal)
2856 (make_parent_window, window_resize_check, window_resize_apply)
2857 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
2858 (Fset_window_configuration, delete_all_child_windows, save_window_save):
2859 Adjust to match struct window changes.
2860 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
2861 (mark_window_cursors_off, count_windows, get_leaf_windows)
2862 (foreach_window_1): Simplify the loop.
2863 * alloc.c (mark_object): Do not check for the leaf window because
2864 internal windows has no glyph matrices anyway.
2865 * dispnew.c (clear_window_matrices, showing_window_margins_p)
2866 (allocate_matrices_for_window_redisplay, fake_current_matrices)
2867 (allocate_matrices_for_frame_redisplay, free_window_matrices)
2868 (build_frame_matrix_from_window_tree, mirror_make_current)
2869 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
2870 (update_window_tree, set_window_update_flags): Simplify the loop.
2871 (sync_window_with_frame_matrix_rows): Enforce live window.
2872 Use contents slot, not buffer, where appropriate.
2873 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
2874 and WINDOW_HORIZONTAL_COMBINATION_P.
2875 (make_frame_visible_1): Simplify the loop.
2876 Use contents slot, not buffer, where appropriate.
2877 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
2878 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
2879 (expose_window_tree): Likewise.
2880 Use contents slot, not buffer, where appropriate.
2881 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
2882 to avoid deleted windows. Use contents slot instead of buffer.
2883 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
2884 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
2885 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
2886 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
2887
121ab1cd
EZ
28882013-03-28 Eli Zaretskii <eliz@gnu.org>
2889
ef454cf7
EZ
2890 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
2891 identify the reasons for assertion violations in bug#14062 and
2892 similar ones.
21e930f8
EZ
2893 (Fx_show_tip): Fix compilation error under
2894 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 2895
121ab1cd
EZ
2896 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
2897 Reported by <rzl24ozi@gmail.com>.
2898
5c89ca24
DA
28992013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
2900
2901 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
2902 start marker...
562c6ee9
SM
2903 (unwind_with_echo_area_buffer): ...to restore it here.
2904 This is needed to ensure that...
5c89ca24
DA
2905 (redisplay_window): ...both window markers are valid here,
2906 which is verified by eassert.
2907 * editfns.c (save_excursion_save): Do not assume that
2908 selected_window always displays the buffer.
c7f53895
DA
2909 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
2910 Fix comment.
5c89ca24 2911
f557c1b1
SM
29122013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
2913
2914 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
2915 the upcase table.
2916
40693bba 29172013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
2918
2919 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
2920
c86f791f
EZ
29212013-03-27 Eli Zaretskii <eliz@gnu.org>
2922
2923 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
2924 since MinGW's w32api headers do. This avoids compiler warnings.
2925
2926 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
2927 if already defined.
2928
c6e72e17
EZ
29292013-03-26 Eli Zaretskii <eliz@gnu.org>
2930
2931 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
2932
54e95010
JD
29332013-03-26 Jan Djärv <jan.h.d@swipnet.se>
2934
2935 * gtkutil.c (style_changed_cb): Check if frame is live and an
2936 X frame (Bug#14038).
2937
b88b62de
EZ
29382013-03-26 Eli Zaretskii <eliz@gnu.org>
2939
a18d7de6
EZ
2940 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
2941 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
2942 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
2943 MinGW64.
8f5e14c8
EZ
2944 Move inclusion of time.h before sys/time.h, so that MinGW64 could
2945 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 2946
b88b62de
EZ
2947 Fix incompatibilities between MinGW.org and MinGW64 headers.
2948 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
2949
2950 * w32.c (REPARSE_DATA_BUFFER): Guard with
2951 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
2952
c074e458
JD
29532013-03-25 Jan Djärv <jan.h.d@swipnet.se>
2954
2955 * xterm.c: Include X11/XKBlib.h
2956 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
2957
908589fd
AS
29582013-03-24 Andreas Schwab <schwab@linux-m68k.org>
2959
2960 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
2961 written backwards.
2962 * blockinput.h (input_blocked_p): Likewise.
2963 * bytecode.c (exec_byte_code): Likewise.
2964 * callproc.c (call_process_kill, call_process_cleanup)
2965 (Fcall_process): Likewise.
2966 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
2967 (Fccl_execute_on_string): Likewise.
2968 * character.c (string_escape_byte8): Likewise.
2969 * charset.c (read_hex): Likewise.
2970 * cm.c (calccost): Likewise.
2971 * data.c (cons_to_unsigned): Likewise.
2972 * dired.c (directory_files_internal, file_name_completion):
2973 Likewise.
2974 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
2975 (sit_for): Likewise.
2976 * doc.c (Fsubstitute_command_keys): Likewise.
2977 * doprnt.c (doprnt): Likewise.
2978 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
2979 * emacsgtkfixed.c: Likewise.
2980 * fileio.c (file_offset, Fwrite_region): Likewise.
2981 * floatfns.c (Fexpt, fmod_float): Likewise.
2982 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
2983 Likewise.
2984 * font.c (font_intern_prop): Likewise.
2985 * frame.c (x_set_alpha): Likewise.
2986 * gtkutil.c (get_utf8_string): Likewise.
2987 * indent.c (check_display_width): Likewise.
2988 * intervals.c (create_root_interval, rotate_right, rotate_left)
2989 (split_interval_right, split_interval_left)
2990 (adjust_intervals_for_insertion, delete_node)
2991 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2992 (merge_interval_right, merge_interval_left, copy_intervals)
2993 (set_intervals_multibyte_1): Likewise.
2994 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
2995 * keymap.c (Fkey_description): Likewise.
2996 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
2997 * lread.c (openp, read_integer, read1, string_to_number):
2998 Likewise.
2999 * menu.c (ensure_menu_items): Likewise.
3000 * minibuf.c (read_minibuf_noninteractive): Likewise.
3001 * print.c (printchar, strout): Likewise.
3002 * process.c (create_process, Faccept_process_output)
3003 (wait_reading_process_output, read_process_output, send_process)
3004 (wait_reading_process_output): Likewise.
3005 * profiler.c (make_log, handle_profiler_signal): Likewise.
3006 * regex.c (re_exec): Likewise.
3007 * regex.h: Likewise.
3008 * search.c (looking_at_1, Freplace_match): Likewise.
3009 * sysdep.c (get_child_status, procfs_ttyname)
3010 (procfs_get_total_memory): Likewise.
3011 * systime.h (EMACS_TIME_VALID_P): Likewise.
3012 * term.c (dissociate_if_controlling_tty): Likewise.
3013 * window.c (get_phys_cursor_glyph): Likewise.
3014 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3015 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3016 Likewise.
3017 * xfns.c (Fx_window_property): Likewise.
3018 * xmenu.c (set_frame_menubar): Likewise.
3019 * xselect.c (x_get_window_property, x_handle_dnd_message):
3020 Likewise.
3021 * xsmfns.c (smc_save_yourself_CB): Likewise.
3022 * xterm.c (x_scroll_bar_set_handle): Likewise.
3023
2bf7d27a
DA
30242013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3025
3026 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3027 to be optional or nil. Adjust comment and convert it to docstring.
3028 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3029 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3030
a9ebfa0b
PE
30312013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3032
3033 Static checking by GCC 4.8-20130319.
3034 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3035 * process.c (Fset_process_datagram_address)
3036 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3037 * xdisp.c (get_char_face_and_encoding):
3038 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3039 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3040 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3041
4f3576ee
KB
30422013-03-24 Ken Brown <kbrown@cornell.edu>
3043
789b5e9a
KB
3044 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3045 fix compilation on 64-bit Cygwin, where underscores are not
3046 automatically prepended.
3047
4f3576ee
KB
3048 * w32term.c (w32_initialize): Silence compiler warning.
3049
b5b7745f
EZ
30502013-03-23 Eli Zaretskii <eliz@gnu.org>
3051
cdc0d0bd
EZ
3052 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3053 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3054 variables, to save and restore frame dimensions.
3055 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3056 after returning from a 'fullscreen' configuration.
3057 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3058 to avoid races between the main thread and the input thread.
3059
3060 * w32term.h (struct w32_output): New members normal_width,
3061 normal_height, normal_top, normal_left, and prev_fsmode.
3062 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3063 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3064 members of a frame.
3065
b5b7745f
EZ
3066 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3067 'fullscreen' parameter. Always record previous width and height
3068 of the frame, except when switching out of maximized modes, so
3069 that they could be restored correctly, instead of resetting to the
3070 default frame dimensions. Send SC_RESTORE command to the frame,
3071 unless we are going to send SC_MAXIMIZE, to restore the frame
3072 resize hints in the mouse pointer shown by the window manager.
3073 (Bug#14032)
3074
3075 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3076
3077 * lisp.h (get_frame_param): Adjust conditions for prototype
3078 declaration.
3079
a3454eed
KB
30802013-03-22 Ken Brown <kbrown@cornell.edu>
3081
3082 * unexcw.c: Drop unneeded inclusion of w32common.h.
3083 (report_sheap_usage): Declare.
3084 (read_exe_header): Add magic numbers for x86_64.
3085 (fixup_executable): Fix printf format specifier for unsigned long
3086 argument.
3087
5a49b79c
DA
30882013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3089
3090 * frame.h (struct frame): Put menu_bar_window under #ifdef
3091 because this member is not needed when X toolkit is in use.
3092 (fset_menu_bar_window):
3093 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3094 (free_glyphs, update_frame):
3095 * xdisp.c (expose_frame): Likewise.
3096 (display_menu_bar): Likewise. Remove redundant eassert.
3097 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3098 toolkit is in use.
3099
d6723bf7
PE
31002013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3101
7b1123d8
PE
3102 Use functions and constants to manipulate Lisp_Save_Value objects.
3103 This replaces code that used macros and strings and token-pasting.
3104 The change makes the C source a bit easier to follow,
3105 and shrinks the Emacs executable a bit.
3106 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3107 (make_save_value): Change 1st arg from string to enum. All callers
3108 changed.
3109 (INTX): Remove.
3110 (mark_object): Use if, not #if, for GC_MARK_STACK.
3111 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3112 (XSAVE_OBJECT): Now functions, not macros.
3113 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3114 the constant was never used.
3115 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3116 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3117 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3118 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3119 New constants.
3120 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3121 type3 with a single member save_type. All uses changed.
3122 (save_type, set_save_pointer, set_save_integer): New functions.
3123 * print.c (PRINTX): Remove.
3124
d6723bf7
PE
3125 * alloc.c: Remove redundant static declarations.
3126
5f24fa51
DA
31272013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3128
3129 * window.h (struct window): Convert left_col, top_line, total_lines
3130 and total_cols from Lisp_Objects to integers. Adjust comments.
3131 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3132 Remove.
3133 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3134 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3135 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3136 Adjust users where appropriate.
3137
42143acd
DA
31382013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3139
3140 * frame.h (struct frame): Drop resx and resy because the same data is
3141 available from window system-specific output context. Adjust users.
562c6ee9
SM
3142 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3143 New functions to provide defaults when no window system available.
42143acd 3144 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3145 (NUMVAL): Move from xdisp.c.
42143acd
DA
3146 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3147 (Ffont_face_attributes, Fopen_font):
3148 * image.c (gs_load):
3149 * w32font.c (fill_in_logfont):
3150 * xdisp.c (calc_pixel_width_or_height):
3151 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3152 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3153
c0a17406
KH
31542013-03-20 Kenichi Handa <handa@gnu.org>
3155
3156 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3157 to 1 (temporary workaround until a bug related to ASCII
3158 optimization is fixed).
3159
095d384d
DA
31602013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3161
3162 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3163 Signal error if window is not internal. Adjust docstring.
3164 (delete_all_child_windows): Use combination_limit to save the buffer.
3165 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3166 * print.c (syms_of_print): Initialize debugging output not here...
3167 (init_print_once): ...but in a new function here.
3168 * lisp.h (init_print_once): Add prototype.
3169 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3170
748fa866
DA
31712013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3172
3173 * window.c (window_resize_check, window_resize_apply)
3174 (window_from_coordinates, recombine_windows, set_window_buffer)
3175 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3176 (Fsplit_window_internal, Fdelete_window_internal)
3177 (freeze_window_starts): Use bool for booleans.
3178 * window.h (window_frame_coordinates, resize_frame_windows)
3179 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3180
81519fd2
SM
31812013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3182
3183 * dispnew.c (bitch_at_user): Use `user-error'.
3184
6db423a9
KB
31852013-03-17 Ken Brown <kbrown@cornell.edu>
3186
3187 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3188 as return type of image_background. (Bug#13981)
3189 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3190
8f2906f5
JD
31912013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3192
960ce480 3193 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3194 (ns_select): Don't return with result uninitialized.
960ce480 3195
8f2906f5
JD
3196 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3197 and getDirectory.
3198
81519fd2
SM
3199 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3200 New functions.
8f2906f5
JD
3201 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3202 directories. If filename is nil, get directory name (Bug#13932).
3203 Use getFilename and getDirectory.
3204 (getFilename, getDirectory): New methods for EmacsSavePanel and
3205 EmacsOpenPanel.
3206 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3207
cded56c1
PE
32082013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3209
3210 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3211
251e9147 32122013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3213
3214 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3215 (adjust_after_replace): Make it back to static. Delete the third
3216 arg text_at_gap_tail. Cancel the code for handling it.
3217
3218 * coding.h (struct coding_system): New member eol_seen.
3219
3220 * coding.c (detect_ascii): New function.
3221 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3222 when the source bytes are actually scanned. On detecting for
3223 coding_category_utf_8_auto, call detect_ascii instead of scanning
3224 source bytes directly.
3225 (produce_chars): Call insert_from_gap with the new arg 0.
3226 (encode_coding): Likewise.
3227 (decode_coding_gap): Control ASCII optimization by the variable
3228 disable_ascii_optimization instead of #ifndef .. #endif.
3229 Deccode EOL format according to coding->eol_seen.
3230 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3231 variable.
3232
8a44e6d1
KH
3233 * lisp.h (adjust_after_replace): Cancel externing it.
3234 (insert_from_gap): Adjust prototype.
3235
5f795e34
EZ
32362013-03-15 Eli Zaretskii <eliz@gnu.org>
3237
3238 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3239 FULLSCREEN_MAXIMIZED. (Bug#13935)
3240
f258b4be
DA
32412013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3242
3243 * region-cache.c (find_cache_boundary, move_cache_gap)
3244 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3245 Simplify debugging check and convert to eassert. Adjust comment.
3246 (pp_cache): Put under ENABLE_CHECKING.
3247
a5cc4dde
EZ
32482013-03-14 Eli Zaretskii <eliz@gnu.org>
3249
3250 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3251 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3252 and WM_ACTIVATEAPP.
3253 (w32fullscreen_hook): If the frame is visible, reset
3254 f->want_fullscreen flag after changing the frame size. If the
3255 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3256 (Bug#13953)
3257
3fc5e44a
DC
32582013-03-13 Daniel Colascione <dancol@dancol.org>
3259
3260 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3261 too so that these builds can use Cygwin's file conversion
3262 functions. (We've been building and linking cygw32.o all along
3263 and just not using it.)
3264
47d7532e
PE
32652013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 File synchronization fixes (Bug#13944).
3268 * Makefile.in (LIB_FDATASYNC): New macro.
3269 (LIBES): Use it.
3270 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3271 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3272 Don't worry about HAVE_FSYNC, since a substitute fsync is
3273 available if the system lacks one.
3274 (Fwrite_regin): Retry fsync if interrupted.
3275
c7ffccaf
EZ
32762013-03-13 Eli Zaretskii <eliz@gnu.org>
3277
4e2df81d 3278 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3279 activated, call w32fullscreen_hook, to make sure the new frame
3280 dimensions are in effect. (Bug#13937)
3281
8a7debc1
DA
32822013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3283
3284 * xdisp.c (init_iterator): Simplify because both character and byte
3285 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3286 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3287 character and byte positions can be obtained from marker.
8a7debc1 3288
7fd8c501
PE
32892013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3290
d9df6f40
PE
3291 Static checking by Sun C 5.12.
3292 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3293 * bytecode.c (exec_byte_code):
3294 * dispnew.c (init_display):
3295 * eval.c (error):
3296 * fileio.c (Fsubstitute_in_file_name):
3297 * keyboard.c (Fevent_convert_list):
3298 * keymap.c (Fsingle_key_description):
3299 * term.c (maybe_fatal, fatal):
3300 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3301 * xsmfns.c (Fhandle_save_session):
3302 Omit unreachable code.
3303 * keymap.c (map_keymap_char_table_item): Cast void * to
3304 a function pointer type; the C Standard requires this.
3305
7fd8c501
PE
3306 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3307 Include <sys/param.h> unconditionally, as that works elsewhere and
3308 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3309 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3310 and FreeBSD now.
3311
a020afb9 3312See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3313
3314;; Local Variables:
3315;; coding: utf-8
aac0c6e3
MR
3316;; End:
3317
ab422c4d 3318 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3319
3320 This file is part of GNU Emacs.
3321
3322 GNU Emacs is free software: you can redistribute it and/or modify
3323 it under the terms of the GNU General Public License as published by
3324 the Free Software Foundation, either version 3 of the License, or
3325 (at your option) any later version.
3326
3327 GNU Emacs is distributed in the hope that it will be useful,
3328 but WITHOUT ANY WARRANTY; without even the implied warranty of
3329 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3330 GNU General Public License for more details.
3331
3332 You should have received a copy of the GNU General Public License
3333 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.