Hook scanning and indentation functions to find_newline. This helps
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d2b36813
DA
12013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Hook scanning and indentation functions to find_newline. This helps
4 to avoid duplicated code and renders more respect to newline cache.
5 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
6 * cmds.c (Fforward_line):
7 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
8 Use find_newline and avoid unnecessary point movements.
9 * search.c (scan_newline): Implement on top of find_newline.
10
3ec7babc
SM
112013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
12
13 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
14 scoped code (bug#11258).
15
5ab473cd
JD
162013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
17
18 * nsterm.m (last_window): New variable.
19 (EV_TRAILER2): New macro.
20 (EV_TRAILER): Call EV_TRAILER2.
21 (mouseMoved:): Add support for mouse-autoselect-window
22 on nextstep (Bug#6888).
23
78779650
AS
242013-08-28 Andreas Schwab <schwab@suse.de>
25
26 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
27 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
28 Remove unused macro definitions.
29 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
30 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
31 Only define if emacs.
78779650 32
c3c4768d
DA
332013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
34
35 Prefer enum glyph_row_area to int where appropriate.
36 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
37 Fix comment.
38 (window_box, window_box_width, window_box_left, window_box_left_offset)
39 (window_box_right, window_box_right_offset): Adjust prototypes.
40 * xdisp.c (window_box, window_box_width, window_box_left)
41 (window_box_left_offset, window_box_right, window_box_right_offset):
42 Use enum glyph_row_area. Adjust users and tweak comment where needed.
43 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
44 * nsterm.m (ns_clip_to_row):
45 * w32term.c (w32_clip_to_row):
46 * xterm.c (x_clip_to_row): Likewise.
47
6bdcbfe1
DA
482013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
49
50 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
51 (Fprevious_overlay_change): Fast path for buffer with no overlays.
52
50b13cde
PE
532013-08-28 Paul Eggert <eggert@cs.ucla.edu>
54
55 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
56 for portability to hosts where /bin/sh has problems.
57
f60e429a
DA
582013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
59
60 Redesign redisplay interface to drop global output_cursor.
61 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
62 (toplevel): Remove declaration of output_cursor.
63 (set_output_cursor, x_cursor_to): Remove prototype.
64 * window.h (struct window): New member output_cursor.
65 (output_cursor_to): New function to replace RIF member.
66 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
67 (update_text_area, set_window_cursor_after_update): Use it.
68 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
69 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
70 * nsterm.m (ns_update_window_begin, ns_update_window_end):
71 * w32term.c (x_update_window_begin, x_update_window_end):
72 * xterm.c (x_update_window_begin, x_update_window_end):
73 Adjust to use per-window output cursor.
74
43aac990
PE
752013-08-27 Paul Eggert <eggert@cs.ucla.edu>
76
d486344e
PE
77 Simplify SELECT_TYPE-related code.
78 Like EMACS_TIME, this portability layer is no longer needed, since
79 Emacs has been using fd_set as a portability layer for some time.
80 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
81 (SELECT_TYPE): Remove. All uses changed to fd_set.
82 (fd_set) [!FD_SET]: New typedef.
83
43aac990
PE
84 Simplify EMACS_TIME-related code.
85 This portability layer is no longer needed, since Emacs has been
86 using struct timespec as a portability layer for some time.
87 * atimer.h, buffer.h, dispextern.h, xgselect.h:
88 Include <time.h> rather than "systime.h"; that's all that's needed now.
89 * dispnew.c: Include <timespec.h> rather than "systime.h";
90 that's all that's needed now.
91 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
92 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
93 TIMESPEC_RESOLUTION.
94 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
95 LOG10_TIMESPEC_RESOLUTION.
96 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
97 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
98 (make_emacs_time): Remove. All used changed to make_timespec.
99 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
100 (current_timespec): Rename from current_emacs_time. All uses changed.
101 (add_emacs_time): Remove. All uses changed to timespec_add.
102 (sub_emacs_time): Remove. All uses change dot timespec_sub.
103 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
104 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
105 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
106 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
107 (current_timespec): Rename from current_emacs_time. All uses changed.
108 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
109 changed to timespec_cmp.
110 * xgselect.c: Include <timespec.h>, since our .h files don't.
111
d350e350
DA
1122013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
115 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
116 Remove the leftovers.
117 * gtkutil.c (toplevel): Do not declare Qxft but include
118 font.h to do so.
119 * image.c (toplevel): Do not declare Vlibrary_cache because
120 it's already done in lisp.h.
121
9fed9729
DA
1222013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
123
124 * lisp.h (Mouse_HLInfo): Move from here...
125 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
126 (reset_mouse_highlight): New function.
127 * msdos.c (dos_set_window_size, IT_update_begin)
128 (internal_terminal_init):
129 * nsterm.m (ns_update_window_end, x_free_frame_resources)
130 (ns_initialize_display_info):
131 * w32console.c (initialize_w32_display):
132 * w32term.c (x_update_window_end, x_free_frame_resources)
133 (w32_initialize_display_info):
134 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
135 * window.c (Fdelete_other_windows_internal):
136 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
137 * termchar.h (toplevel):
138 * xterm.h (toplevel): Include dispextern.h.
139
f462f075
PE
1402013-08-26 Paul Eggert <eggert@cs.ucla.edu>
141
142 Fix minor problems found by static checking.
143 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
144 (expect): Avoid nested-if warning.
145 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
146 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
147 * nsterm.h, nsterm.m (ns_select):
148 * xgselect.c, xgselect.h (xg_select):
149 Adjust signature to better match pselect's.
150 * nsterm.m (ns_select):
151 Don't set *TIMEOUT, since pselect doesn't.
152 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
153 diagnostic about assigning const char * to it.
154 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
155
068f9124
SM
1562013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
157
158 * lread.c (substitute_object_recurse): Handle hash-tables as well
159 (bug#15190).
160
f5adc984
PE
1612013-08-26 Paul Eggert <eggert@cs.ucla.edu>
162
1fc8eb33
PE
163 Fix unlikely core dump in init_tty, and simplify terminfo case.
164 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
165 The old version incorrectly dumped core if malloc returned a
166 buffer containing only non-NUL bytes.
167 (init_tty): Do not allocate or free termcap buffers; the
168 struct does that for us now.
169 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
170 (struct tty_display_info): Define members termcap_term_buffer and
171 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
172 use them. Allocate them directly in struct rather than indirectly
173 via a pointer, to simplify init_tty.
174
f5adc984
PE
175 * frame.c (check_minibuf_window): Initialize 'window' properly,
176 so that Emacs reliably aborts later if 'window' is not initialized.
177
efec3894
JD
1782013-08-26 Jan Djärv <jan.h.d@swipnet.se>
179
180 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
181 of VoidSymbol (Bug#15154).
182
e1d0341e
DA
1832013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
184
185 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
186 mouse_face_beg_y and mouse_face_end_y.
187 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
188 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
189 Adjust users and update comment where appropriate.
190
bfff6445
MR
1912013-08-26 Martin Rudalics <rudalics@gmx.at>
192
193 * frame.c (check_minibuf_window): New function.
068f9124
SM
194 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
195 Call check_minibuf_window (Bug#15183).
bfff6445 196
c80016b3
DA
1972013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
198
199 * window.h (struct window): Replace last_cursor with last_cursor_vpos
200 because this is the only last cursor data we need to keep and consult.
201 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
202 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
203 Adjust users.
204
de396731
DA
2052013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
206
068f9124
SM
207 Fix recovering from possible decompression error.
208 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 209 the position where the partially decompressed data ends, and
447218dd 210 should count how many bytes was produced so far.
de396731
DA
211 * decompress.c (struct decompress_unwind_data): Add nbytes member.
212 (unwind_decompress): Really delete partially uncompressed data.
213 (Fzlib_decompress_region): Take decompressed data size into account.
214
c76826d9
DA
2152013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
216
217 * syntax.c (init_syntax_once): Adjust comment and do an early
218 initialization of Qchar_table_extra_slots just once...
219 * casetab.c (init_casetab_once):
220 * category.c (init_category_once):
221 * character.c (syms_of_character):
222 * coding.c (syms_of_coding):
223 * xdisp.c (syms_of_xdisp): ...and omit it here.
224
b34454d0
EZ
2252013-08-24 Eli Zaretskii <eliz@gnu.org>
226
11f20add
EZ
227 * xdisp.c (get_next_display_element): Don't apply to characters
228 from a display vector the logic of setting it->end_of_box_run_p
229 suitable for characters from a buffer. (Bug#15175)
230
b34454d0
EZ
231 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
232 to handle directories, rather than '_utime' which doesn't.
233 (Bug#15176)
234
6e1b469e
JD
2352013-08-24 Jan Djärv <jan.h.d@swipnet.se>
236
237 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
238 or fullscreen (Bug#14627).
239
9c05bccf
PE
2402013-08-24 Paul Eggert <eggert@cs.ucla.edu>
241
242 System-dependent integer overflow fixes.
243 * process.c (Fset_process_window_size): Signal an error if
244 the window size is outside the range supported by the lower level.
245 * sysdep.c (set_window_size): Return negative on error,
246 nonnegative on success, rather than -1, 0, 1 on not in system,
247 failure, success. This is simpler. Caller changed.
248 (serial_configure): Remove unnecessary initialization of local.
249 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
250 size fits in unsigned long; this isn't true on some 32-bit hosts.
251 Avoid buffer overrun if some future version of /proc/meminfo has a
252 variable name longer than 20 bytes.
253 (system_process_attributes) [__FreeBSD__]:
254 Don't assume hw.availpages fits in 'int'.
255
c365c355
PE
2562013-08-23 Paul Eggert <eggert@cs.ucla.edu>
257
258 Don't let very long directory names overrun the stack.
259 Fix some related minor problems involving "//", vfork.
260 * callproc.c (encode_current_directory): New function.
261 (call_process): Don't append "/"; not needed.
262 * fileio.c (file_name_as_directory_slop): New constant.
263 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
264 this can save the caller having to alloca.
265 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
266 Use SAFE_ALLOCA, not alloca.
267 (directory_file_name, Fexpand_file_name): Leave leading "//"
268 alone, since it can be special even on POSIX platforms.
269 * callproc.c (call_process):
270 * process.c (Fformat_network_address):
271 * sysdep.c (sys_subshell):
272 Use encode_current_directory rather than rolling our own.
273 (create_process): No need to encode directory; caller does that now.
274 * process.h (encode_current_directory): New decl.
275 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
276 Rework to avoid 'goto xyzzy;'.
277
6c6014d4
EZ
2782013-08-23 Eli Zaretskii <eliz@gnu.org>
279
280 * xdisp.c (handle_face_prop): If the default face was remapped use
281 the remapped face for strings from prefix properties. (Bug#15155)
282
9997ec56
DA
2832013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
284
285 Minor cleanup for redisplay interface and few related functions.
286 * frame.h (enum text_cursor_kinds): Move from here...
287 * dispextern.h (enum text_cursor_kinds): ...to here.
288 (toplevel): Drop unnecessary declarations.
289 (struct redisplay_interface): Use bool and enum text_cursor_kinds
290 in update_window_end_hook and draw_window_cursor functions.
291 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
292 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
293 * w32term.c (x_update_window_end,w32_draw_window_cursor):
294 * xterm.c (x_update_window_end, x_draw_window_cursor):
295 * xdisp.c (display_and_set_cursor, update_window_cursor)
296 (update_cursor_in_window_tree, x_update_cursor): Use bool and
297 enum text_cursor_kinds where appropriate.
298
7f780da6
DA
2992013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
300
301 Redesign redisplay interface to drop updated_row and updated_area.
302 * dispextern.h (updated_row, updated_area): Remove declaration.
303 (struct redisplay_interface): Pass glyph row and row area parameters
304 to write_glyphs, insert_glyphs and clear_end_of_line functions.
305 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
306 Adjust prototypes.
307 * dispnew.c (updated_row, updated_area): Remove.
308 (redraw_overlapped_rows, update_window_line): Adjust user.
309 (update_marginal_area, update_text_area): Likewise. Pass updated row
310 as a parameter. Prefer enum glyph_row_area to int where appropriate.
311 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
312 Adjust users.
313
26495794
PE
3142013-08-22 Paul Eggert <eggert@cs.ucla.edu>
315
316 * process.c (flush_pending_output): Remove stub.
317 All uses removed.
318
4a88129a
PE
3192013-08-21 Paul Eggert <eggert@cs.ucla.edu>
320
321 * callproc.c: Fix race that killed background processes (Bug#15144).
322 (call_process): New arg TEMPFILE_INDEX. Callers changed.
323 Record deleted process-id in critical section, not afterwards.
324 Don't mistakenly kill process created by a call-process invocation
325 that discards output and does not wait.
326
0c5307b0
DA
3272013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
330 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
331 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
332 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
333 to shut up compiler in mark_object.
334 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
335
0d7c1e66
PE
3362013-08-21 Paul Eggert <eggert@cs.ucla.edu>
337
338 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
339 We can't portably rely on PTY_OPEN doing that, even if
340 it calls posix_openpt with O_CLOEXEC.
341
3f246b65
KH
3422013-08-20 Kenichi Handa <handa@gnu.org>
343
344 * character.c (string_char): Improve commentary.
345
8c2f38aa
PE
3462013-08-20 Paul Eggert <eggert@cs.ucla.edu>
347
348 * image.c (SIGNATURE_DIGESTSIZE): Remove.
349 (struct animation_cache): Make signature a flexible array member.
350 All uses changed. This is a tad slower but may insulate us better
351 from future changes to ImageMagick.
352
bb566cea
PE
3532013-08-19 Paul Eggert <eggert@cs.ucla.edu>
354
355 * image.c: Shrink memory needed for animation cache.
356 (SIGNATURE_DIGESTSIZE): New constant.
357 (struct animation_cache): Make 'signature' a fixed size array of bytes.
358 (imagemagick_create_cache): Copy the signature. This saves
359 several KB of memory that ImageMagick wastes per signature.
360 Don't bother updating the update_time, as the caller does that now.
361 (imagemagick_prune_animation_cache): Don't destroy the signature, as
362 it's a fixed size struct member now.
363 (imagemagick_get_animation_cache): Always destroy the signature,
364 as it's now imagemagick_create_cache's responsibility to copy it.
365 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
366 and use memcmp rather than strcmp.
367 eassert that ImageMagick returns a signature of the specified length.
368
6da26928
LMI
3692013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
370
371 * image.c (imagemagick_get_animation_cache): Don't segfault on
372 each invocation.
453f4022
LMI
373 (imagemagick_get_animation_cache): Revert to previous definition
374 so that it actually works. But keep the memory leak fix.
375 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 376
22490125
PE
3772013-08-19 Paul Eggert <eggert@cs.ucla.edu>
378
d0139df5
PE
379 * image.c: Fix animation cache signature memory leak.
380 Fix some other minor performance problems while we're at it.
381 (imagemagick_create_cache): Clear just the members that
382 need clearing. Don't set update_time, as caller does that now.
383 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
384 Simplify by using pointer-to-pointer instead of a prev pointer.
385 (imagemagick_prune_animation_cache): Use make_emacs_time rather
386 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
387 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
388 it's already a copy. Free the signature probe unless it's cached.
389
22490125
PE
390 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
391 This was introduced by my 2013-08-12 fix for Bug#15035.
392
deb31e75
DA
3932013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
394
395 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
396 (imagemagick_prune_animation_cache): Now static.
397
319a4d03
LMI
3982013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
399
400 * image.c (imagemagick_get_animation_cache): Don't segfault when
401 pruning all entries.
402
f747d82e
KB
4032013-08-18 Ken Brown <kbrown@cornell.edu>
404
405 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
406 static heap if ENABLE_CHECKING is defined.
407 (max_bss_sbrk_ptr): New variable.
408 (bss_sbrk): Use it.
409 (report_sheap_usage): Report maximum static heap usage instead of
410 ending static heap usage.
411
d2c28fab
EZ
4122013-08-17 Eli Zaretskii <eliz@gnu.org>
413
414 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
415 of zlib_initialized according to the results of calling
416 init_zlib_functions.
417
274ff63f
LMI
4182013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
419
420 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 421 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
422 (imagemagick_load_image): Remove the ping_wand code, which only
423 apparently saved time on invalid animated images, and slowed down
424 everything else. Optimise for the common case.
274ff63f 425
2bede2ed
XF
4262013-08-16 Xue Fuqiao <xfq.free@gmail.com>
427
70ff8240
XF
428 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
429
de179a3e
XF
430 * editfns.c (insert_before_markers): Mention overlay in the doc string.
431
2bede2ed
XF
432 * marker.c (set_marker): Remove documentation of undefined behavior.
433
703dbeba
LMI
4342013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
435
436 * image.c (imagemagick_compute_animated_image): Animate correctly
437 when sub-images are smaller than the main image.
1d18b1e6
LMI
438 (imagemagick_compute_animated_image): Setting the iterator row to
439 zero is apparently not allowed.
79670014
LMI
440 (imagemagick_compute_animated_image): Allow images that say they
441 have sub-images that are bigger than the main image, but just crop
442 them.
703dbeba 443
63216c5e
JD
4442013-08-15 Jan Djärv <jan.h.d@swipnet.se>
445
446 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
447
a5b5f73f
LMI
4482013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
449
450 * image.c (imagemagick_compute_animated_image): Respect the GIF
451 disposal methods.
452
0fe73012
KB
4532013-08-15 Ken Brown <kbrown@cornell.edu>
454
455 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
456 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
457 needed.
458
691a357f
PE
4592013-08-15 Paul Eggert <eggert@cs.ucla.edu>
460
461 Fix minor problems found by static checking.
462 * frame.c (delete_frame):
463 * xdisp.c (next_element_from_display_vector):
464 Avoid uninitialized local.
465 * image.c (imagemagick_compute_animated_image): Port to C89.
466 Prefer usual GNU indentation style for loops.
467 Be more careful about bizarrely large sizes, by using ptrdiff_t
468 instead of int.
469
42fe2e88
DA
4702013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Fix infinite frame selection loop (Bug#15025).
473 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
474
d39a3da6
EZ
4752013-08-15 Eli Zaretskii <eliz@gnu.org>
476
068f9124
SM
477 * xdisp.c (compute_window_start_on_continuation_line):
478 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
479 to make sure we end up setting the window start at the leftmost
480 visible character of the display line. This avoids funky
481 horizontal shifting because the window start is not kept on the
482 same position. (Bug#15090)
05426239
EZ
483 (next_element_from_display_vector): Support 'box' face attribute
484 in the face definitions of a display vector. (Bug#15099)
d39a3da6 485
6e856b69
LMI
4862013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
487
488 * image.c (imagemagick_compute_animated_image): Implement animated
489 images (bug#14700).
995be755
LMI
490 (imagemagick_compute_animated_image): Fix some compilation
491 warnings. Implement a very simple cache to make the animation
492 usable at all, but it should be replaced with a per-image cache.
6e856b69 493
d5a1acfa
DA
4942013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
495
496 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
497 to do `for' loops over alist values.
498 * buffer.h (FOR_EACH_BUFFER):
499 * process.c (FOR_EACH_PROCESS): Use it.
500 (handle_child_signal, status_notify, Fget_buffer_process)
501 (kill_buffer_processes): Use FOR_EACH_PROCESS.
502
9c253307
DA
5032013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
504
505 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
506 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
507 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
508 to xzalloc and so avoid redundant call to memset.
509 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
510 members because it is allocated with xzalloc and so already zeroed.
511
05e64f9f
KB
5122013-08-14 Ken Brown <kbrown@cornell.edu>
513
514 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
515 (Bug#15094).
516
5b71542d
DA
5172013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
518
519 Utility function and macro to copy Lisp string to C string.
520 * lisp.h (xlispstrdupa): New macro.
521 (xlispstrdup): New prototype.
522 * alloc.c (xlispstrdup): New function.
523 * callint.c (Fcall_interactively):
524 * fileio.c (Ffile_name_directory, Fexpand_file_name)
525 (Fsubstitute_in_file_name):
526 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
527 * image.c (x_create_bitmap_from_file):
528 * w32term.c (w32_term_init):
529 * xterm.c (x_term_init): Use xlispstrdup.
530
71530c97
LMI
5312013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
532
4ce82fb8
LMI
533 * image.c (imagemagick_load_image): Make animated pictures work.
534 There's still some problems with background color settings, though
535 (bug#14700).
536
71530c97
LMI
537 * decompress.c (unwind_decompress): Always restore point.
538
7510a061
XF
5392013-08-14 Xue Fuqiao <xfq.free@gmail.com>
540
541 * marker.c (set_marker): Reformat documentation.
542
01c3051f
PE
5432013-08-14 Paul Eggert <eggert@cs.ucla.edu>
544
aab1fcdf
PE
545 * xdisp.c (cursor_type_changed): Now static.
546
01c3051f
PE
547 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
548 Use changed. This avoids the need to call xmalloc and for the
549 caller to call xfree, and avoids memory leaks in some situations.
550
2084152a
DA
5512013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
552
553 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
554 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
555 (redisplay_window): If window_end_valid is cleared due to non-zero
556 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
557 so do not call to try_cursor_movement for that window.
2084152a 558
02455cb6
DA
5592013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
560
561 * window.h (struct window): Convert window_end_pos and
562 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
563 (wset_window_end_pos, wset_window_end_vpos): Remove.
564 * dispnew.c (adjust_glyph_matrix):
565 * window.c (Fwindow_end, replace_window, set_window_buffer)
566 (make_window):
567 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
568 (set_vertical_scroll_bar, redisplay_window, try_window)
569 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
570 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
571 (note_mouse_highlight): Adjust users.
572 (try_cursor_movement): Likewise. Convert old precondition to eassert.
573 Add comment.
574
da5707e8
DA
5752013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
578 * image.c (imagemagick_filename_hint): Use `const char *' and
579 prefer SSDATA to SDATA to avoid warnings.
580
25554267
DA
5812013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
582
583 Cleanup window fringes, margins and scroll bars adjustments.
584 * window.c (set_window_fringes, set_window_margins)
585 (set_window_scroll_bars, apply_window_adjustment): New functions.
586 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
587 (Fset_window_scroll_bars): Use them.
588
38a2c910
DA
5892013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
590
591 * window.h (struct window): Convert scroll_bar_width
592 from Lisp_Object to integer. Adjust comment.
593 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
594 Adjust users.
595 * window.c (wset_scroll_bar_width): Remove.
596 (make_window): Initialize scroll_bar_width.
597 (Fsplit_window_internal): Use direct assignment.
598 (Fset_window_configuration, save_window_save):
599 Convert Lisp_Object to integer and back where appropriate.
600 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
601 bar was actually changed, and mention this in docstring.
602
2d065031
PE
6032013-08-13 Paul Eggert <eggert@cs.ucla.edu>
604
605 * decompress.c: Minor simplifications.
606 (Fzlib_decompress_region): Don't bother verifying
607 that avail_out <= UINT_MAX, as that was confusing.
608 Mention the restriction in a comment instead.
609 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
610
a5bd5abb
JD
6112013-08-13 Jan Djärv <jan.h.d@swipnet.se>
612
613 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
614 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
615
66e7901a
LMI
6162013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
617
618 * image.c (imagemagick_filename_hint): Check for errors in the
619 alist structure.
620
2fa611b7
EZ
6212013-08-13 Eli Zaretskii <eliz@gnu.org>
622
623 * window.c (Fwindow_margins): Return nil when there's no marginal
624 area, as per the documented API.
625
626 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
627 Fmake_vector, as scroll bar's struct members are not all Lisp
628 objects now. This avoids crashes in GC.
629
630 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
631 bool, so its address could be taken.
632
8259030d
LMI
6332013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
634
635 * image.c (imagemagick_filename_hint): New function to possibly
636 apply `image-content-type-suffixes'.
637 (imagemagick_load_image): Use it.
638
866c710e
EZ
6392013-08-13 Eli Zaretskii <eliz@gnu.org>
640
641 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
642 if loading zlib failed.
643
f10490f0
JD
6442013-08-13 Jan Djärv <jan.h.d@swipnet.se>
645
96311be7
JD
646 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
647 2013-08-13 checkin below. Change bool to BOOL, rule is:
648 All Obj-C code uses BOOL, except for interfaces callable from C.
649
f10490f0
JD
650 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
651
c8ae93b0
DA
6522013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
653
654 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
655 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
656 bool instead of BOOL.
657 * w32term.h (struct scroll_bar): Convert fringe_extended_p
658 from Lisp_Object to bitfield. Adjust comment.
659 * w32term.c (x_scroll_bar_create): Adjust user.
660 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
661 * xterm.c (XTset_vertical_scroll_bar): Likewise.
662 Use bool for boolean.
663 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
664 to `unsigned int' when defining a bitfield.
665
53b64418
PE
6662013-08-13 Paul Eggert <eggert@cs.ucla.edu>
667
668 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
669
eeaf9bf3
DA
6702013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
671
672 * window.h (struct window): Convert left_margin_cols and
673 right_margin_cols from Lisp_Objects to integers. Adjust comment.
674 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
675 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
676 Adjust users.
677 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
678 Adjust comment.
679 (showing_window_margins_p, update_window_line, update_frame_1):
680 * fringe.c (draw_fringe_bitmap_1):
681 * xdisp.c (window_box_width): Adjust users.
682 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
683 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
684 Use direct assignment.
685 (Fset_window_configuration, save_window_save, Fwindow_margins):
686 Convert Lisp_Object to integer and back where appropriate.
687 (Fset_window_margins): Adjust user. Return t if any margin
688 was actually changed, and mention this in docstring.
689
956720af
XF
6902013-08-13 Xue Fuqiao <xfq.free@gmail.com>
691
f73f4ce6 692 * syntax.c (forward_word):
956720af
XF
693 * cmds.c (forward_char, backward_char): Mention the optional argument.
694
9e37ee3b
DA
6952013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
696
697 * window.h (struct window): Convert left_fringe_width
698 and right_fringe_width from Lisp_Objects to integers.
699 Adjust comment.
700 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
701 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
702 * window.c (wset_left_fringe_width, wset_right_fringe_width):
703 Remove.
704 (make_window): Initialize new integer fields to -1.
705 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
706 (Fset_window_configuration, save_window_save):
707 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
708 (Fset_window_fringes): Adjust user. Return t if any fringe
709 was actually changed, and mention this in docstring.
710
e4375ca7
DA
7112013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
712
713 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
714 * nsfns.m (x_set_cursor_type):
715 * w32fns.c (x_set_cursor_type):
716 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
717 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 718
a45543bc
DA
7192013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
720
721 * font.c (clear_font_cache): New function, stripped from...
722 (Fclear_font_cache): ...here, which now uses the function
723 above. Adjust comment.
724 * font.h (clear_font_cache): Add prototype.
725 * xfaces.c (clear_face_cache): Use clear_font_cache.
726
ae966a86
DA
7272013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
728
729 * window.c (Fset_window_start): Compare `w', not `window' because
730 `w' might not be equal to `window' after call to decode_live_window.
731
297a545b
PE
7322013-08-12 Paul Eggert <eggert@cs.ucla.edu>
733
734 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
735 This fixes a problem introduced by the Bug#15035 patch
736 when using GPG. Reported by Herbert J. Skuhra.
737
aa942e2b
EZ
7382013-08-12 Eli Zaretskii <eliz@gnu.org>
739
740 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
741 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
742 not yet initialized.
743
7699d09e
LMI
7442013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
745
746 * decompress.c (Fzlib_decompress_region): Support zlib
747 decompression, too, and rename.
748
1d238bc7
PE
7492013-08-12 Paul Eggert <eggert@cs.ucla.edu>
750
751 Minor zlib configuration tweaks.
752 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
753 Don't assume presence of fn_inflateInit2_ zlib internal function.
754
8a44a184
LMI
7552013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
756
757 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
758 include the zlib prefix.
759
594a4307
EZ
7602013-08-12 Eli Zaretskii <eliz@gnu.org>
761
762 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
763 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
764 define static variables that are pointers to zlib functions to be
765 dynamically loaded.
766 (init_zlib_functions) [WINDOWSNT]: New function.
767 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
768 New macros.
769 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
770 macros instead of invoking the zlib functions directly.
068f9124
SM
771 (syms_of_decompress): DEFSYM Qzlib_dll.
772 Staticpro Szlib_available_p.
594a4307 773
d2e113bc
DA
7742013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
775
776 Avoid looping over all frame windows to freeze and unfreeze.
777 * window.h (struct window): Drop frozen_window_start_p.
778 (freeze_window_starts): Drop prototype.
779 * frame.h (struct frame): New frozen_window_starts flag.
780 (FRAME_WINDOWS_FROZEN): New macro.
781 * window.c (freeze_window_start, freeze_window_starts):
782 Remove.
783 (select_window, replace_window): Adjust users.
784 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
785 (window_frozen_p): New function.
786 (redisplay_window): Use it.
787
94fcd171
PE
7882013-08-12 Paul Eggert <eggert@cs.ucla.edu>
789
790 Fix some fd issues when running subprocesses (Bug#15035).
791 Fix bugs that can leak files or file descriptors on errors.
792 Don't unlink open temp files, as that's hard for users to diagnose
793 when things go awry (e.g., temp disk exhausted).
794 Don't bother to lock temp files. Check for invalid recursion.
795 * callproc.c (synch_process_fd): Remove. All uses removed.
796 (synch_process_tempfile): New var or macro.
797 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
798 New constants.
799 (record_kill_process): New arg, the temp name. All callers changed.
800 (delete_temp_file): Now just a simple wrapper around unlink.
801 (call_process_kill): New arg, the call_process_fd array.
802 Close them all. Clear synch_process_pid. Remove the temp file,
803 or arrange for it to be removed.
804 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
805 that's been moved to synch_process_tempfile. Caller changed.
806 Do not remove the tempfile; that's now call_process_kill's
807 responsibility.
808 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
809 call_process_kill; the caller now does that.
810 (call_process_cleanup): Do not close the process fd; that's now
811 call_process_kill's responsibility.
812 (Fcall_process): Implement via new function call_process, which
813 has most of the old body of Fcall_process, but with a different API.
814 (call_process): New function that does not open or close filefd if
815 it is nonnegative. Record which fds need to be closed, and let
816 call_process_kill close (and remove the tempfile, on MSDOS) on error.
817 Signal an error if invoked recursively (could be done via a hook).
818 Simplify creation of the tempfile in the MSDOS case.
819 Don't create the output file until after checking for the executable.
820 Report any failure to open /dev/null.
821 Don't open /dev/null for writing twice; once is enough.
822 Don't create pipe if all output is being discarded or sent to file.
823 Don't worry about setting up the coding system or reading from the
824 pipe if all output is being discarded.
825 Hoist fd_error local into top level, to lessen block nesting.
826 Don't record deleted pid here; now done by Fcall_process_region.
827 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
828 and note its success in synch_process_tempfile.
829 Do not leak resources when child_setup fails.
830 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
831 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
832 (create_temp_file): Now returns open fd, with an additional
833 Lisp_Object * argument to return the name. All callers changed.
834 Do not close the file; rewind it instead, and leave it open for
835 the caller. Do not lock the temp file. Unwind-protect the file
836 and the file-descriptor.
837 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
838 If an asynchrounous process, record it here, not in call_process.
839 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
840 * eval.c (set_unwind_protect): New function.
841 * fileio.c (write_region): New function, generalized from the
842 old Fwrite_region. Do not lock temp files.
843 (Fwrite_region): Use it.
844 * lisp.h (set_unwind_protect, write_region): New decls.
845 * process.c: Include <verify.h>.
846 (make_process): Mark fds as initially closed.
847 (deleted_pid_list): Now a list of pid-filename pairs.
848 All uses changed.
849 (close_process_fd): New function.
850 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
851 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
852 New constants. Verify that their number matches PROCESS_OPEN_FDS.
853 (create_process, create_pty, Fmake_serial_process)
854 (server_accept_connection): Record which fds need to be closed,
855 and let deactivate_process close them.
856 (Fmake_network_process): Do not discard the unwind-protect
857 until it's safe to do so.
858 (deactivate_process): Close the fds opened by create_process etc.
859 (Fprocess_send_eof): Adjust to new way of recording open fds.
860 Report an error if /dev/null can't be opened, instead of aborting.
861 * process.h (PROCESS_OPEN_FDS): New constant.
862 (struct Lisp_Process): New member open_fds.
863 (record_kill_process, record_deleted_pid): Adjust signatures.
864 (record_deleted_pid): Move decl here ...
865 * syswait.h (record_deleted_pid): ... from here.
866
d0e615c3
PE
8672013-08-11 Paul Eggert <eggert@cs.ucla.edu>
868
869 * decompress.c: Fix bugs with large buffers and weird inputs.
870 Tune a bit. Reindent as per usual Emacs style.
871 (BUFFER_SIZE): Remove.
872 (Fdecompress_gzipped_region): Do not mishandle input buffers with
873 more than UINT_MAX bytes. Decompress into the gap instead of into
874 an auto buffer, as this should avoid copying. Return nil if
875 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
876 set immediate_quit; we shouldn't trust zlib code that much.
877
313546eb
LMI
8782013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
879
99a32242
LMI
880 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
881 errors, and really move the gap to where we want it.
882
313546eb
LMI
883 * lisp.h: Include decompress.c support.
884
885 * emacs.c (main): Include decompress.c support.
886
887 * Makefile.in: Include -lz if present.
888
d2d699ac
JD
8892013-08-11 Jan Djärv <jan.h.d@swipnet.se>
890
f90e3ebd
JD
891 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
892 (initWithTitle:): Initialize frame to 0.
893 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 894 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
895 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
896
897 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
898 fillWithWidgetValue:frame:
899
423d3b3f
JD
900 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
901 remove memory leak warnings.
902
d2d699ac
JD
903 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
904 (ns_check_menu_open): Handle menu == nil. Remove assignment to
905 menu_pending_title.
906
907 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
908 (x_activate_menubar): Update the whole menu.
909 (trackingNotification:): Call ns_check_menu_open if tracking ends.
910 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
911 current event is not NSSystemDefined (Bug#15001).
912 Call ns_check_menu_open only if trackingMenu is 2.
913 (menuDidClose:): New method, decrease trackingMenu.
914 (fillWithWidgetValue:setDelegate:): New method.
915 (fillWithWidgetValue:): Call the above.
916
917 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
918
7d652d97
PE
9192013-08-11 Paul Eggert <eggert@cs.ucla.edu>
920
921 Omit some unnecessary casts.
922 Many of these go back to the old pre-C89 days, when they may have
923 been needed, but we've been assuming C89 or later for a while now.
924 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
925 (live_float_p, live_misc_p, live_vector_p):
926 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
927 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
928 (defvar_per_buffer):
929 * callint.c (Fcall_interactively):
930 * doc.c (Fsubstitute_command_keys):
931 * filelock.c (get_boot_time):
932 * frame.c (xrdb_get_resource):
933 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
934 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
935 (xg_get_file_name_from_selector, menuitem_destroy_callback)
936 (menuitem_highlight_callback, menu_destroy_callback)
937 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
938 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
939 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
940 (xg_tool_bar_help_callback, tb_size_cb):
941 * image.c (xpm_alloc_color, png_read_from_memory)
942 (png_read_from_file, png_load_body, our_memory_skip_input_data)
943 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
944 (syms_of_image):
945 * keymap.c (describe_map):
946 * nsfns.m (Fns_display_monitor_attributes_list):
947 * nsmenu.m (process_dialog:):
948 * nsterm.m (hold_event):
949 * process.c (wait_reading_process_output):
950 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
951 * scroll.c (do_direct_scrolling, scrolling_1):
952 * termcap.c (tgetent):
953 * window.c (check_window_containing, add_window_to_list)
954 (freeze_window_starts):
955 * xdisp.c (compare_overlay_entries, vmessage):
956 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
957 (x_get_monitor_attributes_xrandr)
958 (Fx_display_monitor_attributes_list, x_display_info_for_name)
959 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
960 * xfont.c (xfont_match, xfont_open):
961 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
962 (menubar_selection_callback, menu_position_func)
963 (popup_selection_callback, create_and_show_popup_menu)
964 (dialog_selection_callback, create_and_show_dialog):
965 * xrdb.c (x_get_string_resource):
966 (main) [TESTRM]:
967 * xsmfns.c (x_session_check_input):
968 * xterm.c (x_draw_glyphless_glyph_string_foreground)
969 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
970 (xaw_jump_callback, xaw_scroll_callback):
971 Omit unnecessary casts.
972
9acc1074
PE
9732013-08-10 Paul Eggert <eggert@cs.ucla.edu>
974
975 Minor string-length refactoring.
976 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
977 * frame.c (make_monitor_attribute_list):
978 Prefer build_string to strlen + make_string.
979
361c0eb8
JD
9802013-08-10 Jan Djärv <jan.h.d@swipnet.se>
981
982 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
983 don't check minor_code (Bug#14417).
984
14ba0822
EZ
9852013-08-09 Eli Zaretskii <eliz@gnu.org>
986
987 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
988 vertical positions instead. This avoids calling MATRIX_ROW with
989 row numbers that are possibly beyond valid limits. (Bug#15064)
990
309f24d1
DA
9912013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
992
993 Use xstrdup and build_unibyte_string where applicable.
994 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
995 * xfns.c (x_window):
996 * xrdb.c (x_get_customization_string):
997 * xterm.c (xim_initialize):
998 * w32fns.c (w32_window): Use xstrdup.
999 (w32_display_monitor_attributes_list):
1000 * emacs.c (init_cmdargs):
1001 * keyboard.c (PUSH_C_STR):
1002 * nsfont.m (nsfont_open):
1003 * sysdep.c (system_process_attributes):
1004 * w32.c (system_process_attributes):
1005 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1006
55902276
EZ
10072013-08-09 Eli Zaretskii <eliz@gnu.org>
1008
1009 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1010 variables of these types so that GDB would know about them, as aid
1011 for debugging fatal exceptions. (Bug#15024) See also
1012 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1013 discussions.
1014
10bf7f5a
JD
10152013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1016
1017 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1018 larger than the NSWindow (Bug#14934).
1019
65620264
DA
10202013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1021
1022 Redesign redisplay interface to drop global variable updated_window.
1023 Always pass currently updated window as a parameter to update routines.
1024 * dispextern.h (updated_window): Remove declaration.
1025 (struct redisplay_interface): Pass window parameter to
1026 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1027 and after_update_window_hook.
1028 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1029 Adjust prototypes.
1030 * dispnew.c (updated_window): Remove.
1031 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1032 (update_window_line): Adjust to match redisplay interface changes.
1033 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1034 (ns_scroll_run, ns_after_update_window_line):
1035 * w32term.c (x_update_window_begin, x_update_window_end)
1036 (x_after_update_window_line, x_scroll_run):
1037 * xterm.c (x_update_window_begin, x_update_window_end)
1038 (x_after_update_window_line, x_scroll_run):
1039 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1040 Likewise. Adjust comments where appropriate.
1041 (x_cursor_to): Simplify because this is always called during window
1042 update (but install debugging check anyway).
1043 (expose_window): Check must_be_updated_p flag to see whether this
1044 function is called during window update.
1045
628fdc56
DA
10462013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 Do not reset window modification event counters excessively.
1049 These leftovers and poor man's tricky methods to catch extra
1050 redisplay's attention are no longer needed.
1051 * frame.c (set_menu_bar_lines_1):
1052 * minibuf.c (read_minibuf_unwind):
1053 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1054 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1055 (window_scroll_line_based, Fset_window_configuration):
1056 * xdisp.c (redisplay_window): Do not reset last_modified and
1057 last_overlay_modified counters.
1058
8fd9c92e
JD
10592013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1060
1061 * xselect.c (x_send_client_event): Set send_event and serial, memset
1062 data.l as it might be bigger than data.b. Use 24 bit mask to
1063 XSendEvent (Bug#15034).
1064
0ee18172
EZ
10652013-08-07 Eli Zaretskii <eliz@gnu.org>
1066
1067 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1068 for TTY frames that are not the top frame on their console.
1069 (Bug#14616)
1070
16ddd1a6
MR
10712013-08-07 Martin Rudalics <rudalics@gmx.at>
1072
1073 * w32term.c (w32fullscreen_hook): Really maximize frame when
1074 asked for (Bug#14841).
1075
d2a95ffb
DA
10762013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 Prefer selected_window to Fselected_window, likewise for frames.
1079 * buffer.c (Fbuffer_swap_text):
1080 * data.c (Fvariable_binding_locus):
1081 * window.c (run_window_configuration_change_hook): Adjust users.
1082 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1083 Use decode_live_frame.
1084
170da1ec
DA
10852013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1086
1087 Be more careful if selected window shows the buffer other than current,
1088 use window_outdated only if this is not so. This change should also
1089 address some weird issues discussed in Bug#13012.
1090 * window.h (window_outdated): New prototype.
1091 * window.c (window_outdated): Now here. Convert from static and
1092 always assume window's buffer.
1093 (Fwindow_end, Fwindow_line_height): Use it.
1094 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1095 and always assume window's buffer.
1096 (redisplay_window): Adjust user.
e5eefe9b 1097 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1098 check whether mode line should be updated only if selected window
1099 shows current buffer.
1100 (run_window_scroll_functions): Use eassert for debugging check.
1101 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1102
56b5d5b1
DA
11032013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1104
1105 * window.c (window_scroll, window_scroll_pixel_based)
1106 (window_scroll_line_based): Use bool for booleans.
1107
2878ba7e
PE
11082013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 * process.c: Fix minor off-by-one issues in descriptor counts.
1111 This shouldn't fix any real bugs, but it cleans up the code a bit.
1112 (max_process_desc, max_input_desc): -1, not 0, means none.
1113 All uses changed.
1114 (delete_input_desc): New function.
1115 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1116 (deactivate_process): Scan backwards when recomuting max_process_desc;
1117 that should be faster.
1118 (init_process_emacs): Initialize max_input_desc.
1119
e30b79c1
DA
11202013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1121
1122 Use region cache to speedup bidi_find_paragraph_start.
1123 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1124 Rename cache_long_line_scans to cache_long_scans.
1125 * buffer.c (bset_cache_long_line_scans): Rename to
1126 bset_cache_long_scans.
1127 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1128 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1129 into account.
1130 (syms_of_buffer): Rename cache-long-line-scans to
1131 cache-long-scans. Adjust docstring.
1132 * search.c (newline_cache_on_off):
1133 * indent.c (width_run_cache_on_off): Adjust users.
1134 * bidi.c (bidi_paragraph_cache_on_off): New function.
1135 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1136 * insdel.c (prepare_to_modify_buffer):
1137 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1138
00012b86
DA
11392013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 Invalidate region caches only if buffer text is going to be changed.
1142 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1143 (modify_text): ...new prototype.
1144 (prepare_to_modify_buffer_1): New prototype.
1145 * textprop.c (modify_region): Rename to...
1146 (modify_text_properties): ...new function.
1147 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1148 (Fremove_list_of_text_properties): Adjust users.
1149 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1150 (modify_text): ...new function.
1151 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1152 (prepare_to_modify_buffer_1): ...new function.
1153 * casefiddle.c (casify_region):
1154 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1155 (Ftranspose_regions): Use modify_text.
1156
dc6c0eda
SM
11572013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1158
1159 * lisp.mk (lisp): Add nadvice.elc.
1160
8f3a2c26
DA
11612013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1162
1163 New macro to iterate over live buffers similar to frames.
1164 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1165 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1166 Declare buffer-related variables here to offload lisp.h.
1167 * buffer.c (Vbuffer_alist): Adjust comment.
1168 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1169 (other_buffer_safely):
1170 * data.c (store_symval_forwarding):
1171 * dispnew.c (Fframe_or_buffer_changed_p):
1172 * fileio.c (Fdo_auto_save):
1173 * filelock.c (unlock_all_files):
1174 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1175
e0fdb694
PE
11762013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1179 * callproc.c (create_temp_file):
1180 * filelock.c (create_lock_file):
1181 Assume mkostemp, since it's now provided by Gnulib.
1182
63f5c6c2
EZ
11832013-08-04 Eli Zaretskii <eliz@gnu.org>
1184
1185 * w32.c (mkostemp): New function.
1186 (mktemp): Remove, no longer used. Most of the code reused in
1187 mkostemp. (Bug#15015)
484ab239 1188 (mktemp): Don't undef.
63f5c6c2 1189
f0b79313
DA
11902013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1191
1192 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1193 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1194 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1195 (free_glyph_pool, check_glyph_memory): Likewise for
1196 all users. Adjust comments where appropriate.
1197
98f638d6
PE
11982013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * composite.h: Minor fixups.
1201 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1202 to fix a misspelling, and change it to an inline function while
1203 we're at it (it need not be a macro). All uses changed.
1204 (composition_method, composition_valid_p):
1205 Rewrite to avoid assignments in if-conditions.
1206
75c59fb3
DA
12072013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1208
1209 Do not use global Lisp_Object in composition macros.
1210 * composite.h (composition_temp): Remove declaration.
1211 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1212 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1213 (compose_region): Remove the leftover.
75c59fb3
DA
1214 * composite.c (composition_temp): Remove.
1215 (run_composition_function, update_compositions)
1216 (composition_compute_stop_pos, composition_adjust_point)
1217 (Ffind_composition_internal):
1218 * coding.c (handle_composition_annotation):
1219 * xdisp.c (handle_composition_prop, check_point_in_composition):
1220 Related users changed.
1221
a10c8269
DA
12222013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 Drop FRAME_PTR typedef.
1225 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1226 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1227 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1228 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1229 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1230 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1231 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1232 All related users changed.
1233
a104f656
SM
12342013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1235
1236 * eval.c (default_toplevel_binding): New function.
1237 (Fdefvar): Use it.
1238 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1239 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1240 (syms_of_eval): Export them.
1241 * data.c (Fdefault_value): Micro cleanup.
1242 * term.c (init_tty): Use "false".
1243
4b5c9326
DA
12442013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1245
1246 Fix X GC leak in GTK and raw (no toolkit) X ports.
1247 * xterm.c (x_free_frame_resources): If white and black relief
1248 GCs are allocated, always free them here.
1249 * xfns.c (x_make_gc): Omit redundant initialization.
1250 * widget.c (create_frame_gcs): Remove the leftover.
1251 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1252 in x_free_frame_resources.
1253
b19aa636
JD
12542013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1255
1256 * nsterm.m (windowWillResize:toSize:): Only change title if
1257 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1258 modifying it.
1259 (viewDidEndLiveResize): New method.
1260
1261 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1262 inside NS_IMPL_COCOA.
1263
af1f7e06
DA
12642013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1265
1266 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1267 Do not check whether undo is enabled because record_insert and
1268 record_delete does that themselves.
1269
65b02bb9
DA
12702013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1271
1272 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1273 member which is not really used any more.
1274 (FRAME_XIC_BASE_FONTNAME): Remove.
1275 * xfns.c (xic_free_fontset): Adjust user.
1276 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1277 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1278 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1279 (xdialog_show): Use eassert for debugging check.
7ee0f047 1280 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1281
6318cde0
PE
12822013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 * fileio.c, fns.c (merge): Move extern decl from here ...
1285 * lisp.h (merge): ... to here.
1286
6c1a09ba
DA
12872013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1288
1289 Fix last font-related change.
1290 * w32font.h (w32font_list_internal, w32font_match_internal):
1291 Fix prototype.
1292 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1293 (uniscribe_list_family): Adjust to match font API change.
1294 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1295 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1296
f8c20208
DA
12972013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 * frame.h (FRAME_MOUSE_UPDATE):
1300 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1301 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1302
fdb396e2
DA
13032013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1304
1305 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1306 * font.h (struct font_driver): Change list, match, and list_family
1307 functions to accept struct frame * as first arg.
068f9124
SM
1308 * font.c (font_score, font_compare, font_sort_entities):
1309 Remove prototypes.
fdb396e2
DA
1310 (font_sort_entities, font_list_entities, font_select_entity):
1311 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1312 match font API change.
1313 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1314 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1315 * ftxfont.c (ftxfont_list, ftxfont_match):
1316 * xftfont.c (xftfont_list, xftfont_match):
1317 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1318 * w32font.c (w32font_list, w32font_match, w32font_list):
1319 (w32font_list_internal, w32_font_match_internal): Likewise.
1320 * xfaces.c (Fx_family_fonts): Adjust user.
1321
52b8a085
DA
13222013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1323
1324 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1325 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1326 only if HAVE_X_WINDOWS is in use.
1327 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1328 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1329 * w32term.c (x_wm_set_icon_position): Likewise.
1330 * w32fns.c (x_icon): Adjust user.
1331
c791c18e
DA
13322013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 * xterm.c (last_mouse_press_frame): Remove the
1335 leftover which is not really used any more.
1336 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1337 (x_flush): Call XFlush once per each X display, not frame.
1338 This is better because this code always unconditionally skips
1339 non-X frames in Vframe_list and issues the only XFlush if we
1340 have more than one X frame on the same X display.
2f935d86
DA
1341 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1342 Use bool for booleans.
1343 (x_draw_glyph_string_background, cvt_string_to_pixel):
1344 (cvt_pixel_dtor): Drop unnecessary prototypes.
1345 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1346
f435830e
DA
13472013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1348
1349 Drop unnecessary functions that deals with frame pixel size.
1350 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1351 (x_pixel_height): Drop prototypes.
1352 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1353 (x_pixel_height): Drop implementations.
1354 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1355 which should be always valid for window frame.
1356 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1357 * w32menu.c (Fx_popup_dialog):
1358 * xmenu.c (Fx_popup_dialog): Likewise for both.
1359
84231434
DA
13602013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1363 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1364 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1365 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1366 and mention nil frame in docstring.
84231434 1367
959067a1
DA
13682013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1369
1370 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1371 (x_figure_window_size): Likewise. Adjust to return long.
1372 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1373 (toplevel): Move Qterminal_live_p to...
1374 * terminal.c (toplevel): ...here, make it static, and...
1375 (syms_of_terminal): ...DEFSYM here.
1376 * frame.h (Qterminal_live_p): Remove declaration.
1377 (make_frame, x_figure_window_size): Adjust prototype.
1378 * nsfns.m (Fx_create_frame): Use long for window flags.
1379
f4b169ce
PE
13802013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1381
1382 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1383 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1384 Do not assume that emacs_close (INT_MAX) is a no-op.
1385
bee6a2c7
DA
13862013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1387
1388 * xfaces.c (make_face_cache): For struct face_cache, prefer
1389 xmalloc to xzalloc and so avoid redundant call to memset.
1390 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1391
d7e6881a
DA
13922013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1393
1394 * fringe.c (draw_window_fringes, update_window_fringes)
1395 (compute_fringe_widths):
1396 * w32term.c (x_draw_glyph_string):
1397 * window.c (candidate_window_p, Frecenter):
1398 * xfaces.c (realize_basic_faces, realize_default_face)
1399 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1400 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1401 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1402 * xmenu.c (Fx_menu_bar_open_internal):
1403 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1404 * xsettings.c (xft_settings_event):
1405 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1406 Use bool for booleans. Adjust style and comments where
1407 appropriate.
1408 * dispextern.h (draw_window_fringes, update_window_fringes)
1409 (compute_fringe_widths):
1410 * xterm.h (x_had_errors_p): Adjust prototype.
1411
ec3058af
DA
14122013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1413
1414 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1415 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1416
218e0637
DA
14172013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1418
1419 * fns.c (toplevel): Remove comment before Fsafe_length because
1420 it checks for QUIT.
1421
e560aba9
PE
14222013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1425
2e5ce5de
EZ
14262013-07-28 Eli Zaretskii <eliz@gnu.org>
1427
1428 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1429 frame which got the message is still alive, before dereferencing
1430 its pointer. (Bug#14970)
1431
1432 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1433 be a live window, before using it as such. (Bug#14970)
1434
e95da6d3
EZ
14352013-07-27 Eli Zaretskii <eliz@gnu.org>
1436
1437 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1438 w32_detect_focus_change instead of doing part of its job by hand.
1439 This fixes the problem whereby FOCUS_OUT events were not sent to
1440 the event queue.
1441
a8f93651
EZ
14422013-07-26 Eli Zaretskii <eliz@gnu.org>
1443
fec92060
EZ
1444 * process.c (Fprocess_list): Doc fix.
1445
a8f93651
EZ
1446 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1447 being re-exposed only if it didn't ask to become visible.
1448 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1449 was previously iconified. (Bug#14841)
1450 (x_iconify_frame): Mark the frame iconified.
1451
d5a7a9d9
PE
14522013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 Fix minor problems found by static checking.
1455 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1456 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1457
56ea7291
SM
14582013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1459
1460 * eval.c (set_specpdl_old_value): New function.
1461 (unbind_to): Minor simplification.
1462 (get_backtrace_frame): New function.
1463 (Fbacktrace_frame): Use it. Add `base' argument.
1464 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1465 (syms_of_eval): Export backtrace-eval.
1466 * xterm.c (x_focus_changed): Simplify.
1467
9d611ffe
PE
14682013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1469
1470 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1471
999c74e3
EZ
14722013-07-24 Eli Zaretskii <eliz@gnu.org>
1473
1474 * xdisp.c (redisplay_window): Instead of moving point out of
1475 scroll margin, reject the force_start method, and try scrolling
1476 instead. (Bug#14780)
1477
198fa217
KB
14782013-07-24 Ken Brown <kbrown@cornell.edu>
1479
1480 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1481 (Bug#14944).
1482
53840e55
PE
14832013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 * eval.c (Fprogn): Do not check that BODY is a proper list.
1486 This undoes the previous change. The check slows down the
1487 interpreter, and is not needed to prevent a crash. See
1488 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1489
60967f56
GM
14902013-07-23 Glenn Morris <rgm@gnu.org>
1491
1492 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1493
9ca960e2
PE
14942013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1495
a29c3e6d
PE
1496 Port to GNU/Linux systems with tinfo but not ncurses.
1497 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1498 to decide whether ncurses is being used. Without this change,
1499 GCC complains about tgetent not being declared, on a system
1500 that has tinfo installed but ncurses not installed.
1501
f274311c
PE
1502 * eval.c (Fprogn): Check that BODY is a proper list.
1503
16b0520a
PE
1504 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1505 * data.c (Fsetq_default):
1506 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1507 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1508 (Fcondition_case):
1509 Tune by taking advantage of the fact that ARGS is always a list
1510 when a function is declared to have UNEVALLED args.
1511
9ca960e2
PE
1512 * emacsgtkfixed.c: Port to GCC 4.6.
1513 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1514
afacaa1b
JB
15152013-07-23 Juanma Barranquero <lekktu@gmail.com>
1516
1517 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1518 here to silence compiler warnings.
1519
368a85a4
PE
15202013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1523 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1524 from messing up Emacs's 'struct frame' (Bug#14923).
1525
f4e891b5
PE
15262013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 * alloc.c (make_save_ptr_ptr): Define this function.
1529 It was inadvertently omitted. It's needed only if
1530 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1531
96c8b65e
JD
15322013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1533
1534 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1535 frame have focus (Bug#14895).
1536
ee010797
PE
15372013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1538
1539 Avoid vfork-related deadlock more cleanly.
1540 * callproc.c (child_setup): When the child's exec fails, output
1541 the program name, as that's more useful. Use O_NONBLOCK to avoid
1542 deadlock.
1543 * process.c (create_process_1): Remove; no longer needed.
1544 (create_process): Remove timer hack; no longer needed, now that
1545 the child avoids deadlock.
1546
f0398ec1 15472013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1548
1549 * image.c (Fimage_flush): Fix doc typo.
1550
b2a069c2
PE
15512013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1552
6496aec9
PE
1553 Fix array bounds violation when pty allocation fails.
1554 * process.c (PTY_NAME_SIZE): New constant.
1555 (pty_name): Remove static variable; it's now auto.
1556 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1557 Take pty_name as an arg rather than using a static variable.
1558 All callers changed.
1559 (create_process): Recover pty_flag from process, not from volatile local.
1560 (create_pty): Stay inside array even when pty allocation fails.
1561 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1562
b2a069c2
PE
1563 * lread.c (Fload): Avoid initialization only when lint checking.
1564 Mention that it's needed only for older GCCs.
1565
99107004
KH
15662013-07-20 Kenichi Handa <handa@gnu.org>
1567
1568 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1569 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1570
6b1b199d
AS
15712013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1572
1573 * lread.c (Fload): Avoid uninitialized warning.
1574
4195afc3
PE
15752013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1576
3f5bef16
PE
1577 Fix some minor file descriptor leaks and related glitches.
1578 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1579 (create_lock_file): Use write, not emacs_write.
1580 * image.c (slurp_file, png_load_body):
1581 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1582 (server_accept_connection):
1583 Don't leak an fd on memory allocation failure.
1584 * image.c (slurp_file): Add a cheap heuristic for growing files.
1585 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1586 as that's what the other routines do. Maybe input need not be
1587 blocked at all, but it's better to be consistent.
1588 Avoid undefined behavior when strlen is zero.
1589
4195afc3
PE
1590 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1591 (NSTATICS): Now a constant; doesn't need to be a macro.
1592
a1aeeffe
RS
15932013-07-19 Richard Stallman <rms@gnu.org>
1594
1595 * coding.c (decode_coding_utf_8): Add simple loop for fast
1596 processing of ASCII characters.
1597
63b34baa
PE
15982013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1601
621dd9ac
EZ
16022013-07-19 Eli Zaretskii <eliz@gnu.org>
1603
1604 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1605 unportable 'struct x_display_info'.
1606 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1607 is a portable type.
1608
1396ac86
PE
16092013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1610
ab9980cd
PE
1611 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1612 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1613 or fscanf fails.
1614 (system_process_attributes): Prefer plain char to unsigned char
1615 when either will do. Clean up properly if interrupted or if
068f9124
SM
1616 memory allocations fail. Don't assume sscanf succeeds.
1617 Remove no-longer-needed workaround to stop GCC from whining.
1618 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1619 bit more carefully.
1620
1396ac86
PE
1621 Fix obscure porting bug with varargs functions.
1622 The code assumed that int is treated like ptrdiff_t in a vararg
1623 function, which is not a portable assumption. There was a similar
1624 -- though these days less likely -- porting problem with various
1625 assumptions that pointers of different types all smell the same as
1626 far as vararg functions is conserved. To make this problem less
1627 likely in the future, redo the API to use varargs functions.
1628 * alloc.c (make_save_value): Remove this vararg function.
1629 All uses changed to ...
1630 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1631 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1632 New functions.
1633 (make_save_ptr): Rename from make_save_pointer, for consistency with
1634 the above. Define only on platforms that need it. All uses changed.
1635
4d19d194
PE
16362013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1637
1638 * keyboard.c: Try to fix typos in previous change.
1639 (DISPLAY_LIST_INFO): New macro.
1640 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1641 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1642
945c5bb1
JB
16432013-07-18 Juanma Barranquero <lekktu@gmail.com>
1644
1645 * keyboard.c (kbd_buffer_get_event):
1646 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1647 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1648
f4b1eb36
PE
16492013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1650
5e679a2c
PE
1651 * filelock.c: Fix unlikely file descriptor leaks.
1652 (get_boot_time_1): Rework to avoid using emacs_open.
1653 This doesn't actually fix a leak, but is better anyway.
1654 (read_lock_data): Use read, not emacs_read.
1655
a8cd4836
PE
1656 * doc.c: Fix minor memory and file descriptor leaks.
1657 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1658 (get_doc_string, Fsnarf_documentation):
1659 Fix file descriptor leak on error.
1660
ef30e638
PE
1661 * term.c: Fix minor fdopen-related file descriptor leaks.
1662 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1663 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1664
f4b1eb36
PE
1665 * charset.c: Fix file descriptor leaks and errno issues.
1666 Include <errno.h>.
1667 (load_charset_map_from_file): Don't leak file descriptor on error.
1668 Use plain record_xmalloc since the allocation is larger than
1669 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1670 of entries.
1671 * eval.c (record_unwind_protect_nothing):
1672 * fileio.c (fclose_unwind):
1673 New functions.
1674 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1675 The replacement doesn't block input, but that no longer seems
1676 necessary.
1677
b648c163
PE
16782013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1679
a0931322
PE
1680 * lread.c: Fix file descriptor leaks and errno issues.
1681 (Fload): Close some races that leaked fds or streams when 'load'
1682 was interrupted.
1683 (Fload, openp): Report error number of last nontrivial failure to open.
1684 ENOENT counts as trivial.
1685 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1686 New functions.
1687 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1688 now that the function is always called with a nonnegative arg.
1689 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1690 All uses replaced with ...
1691 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1692
b648c163
PE
1693 A few more minor file errno-reporting bugs.
1694 * callproc.c (Fcall_process):
1695 * doc.c (Fsnarf_documentation):
1696 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1697 * process.c (set_socket_option):
1698 Don't let a constructor trash errno.
1699 * doc.c: Include <errno.h>.
1700
b1dc4084
JB
17012013-07-16 Juanma Barranquero <lekktu@gmail.com>
1702
1703 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1704
c43843aa
PE
17052013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1706
50a30cce
PE
1707 Fix w32 bug with call-process-region (Bug#14885).
1708 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1709 to Fcall_process when the input is empty. This simplifies the
1710 code a bit. It makes no difference on POSIXish platforms but
1711 apparently it fixes a bug on w32.
1712
44e18199 1713 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1714 * fileio.c (close_file_unwind): Don't close if FD is negative;
1715 this can happen when unwinding a zapped file descriptor.
1716 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1717 in case Emacs runs out of memory between the two unwind-protects.
1718 Don't trash errno when closing FD.
1719 Zap the FD in the specpdl when closing it, instead of deferring
1720 the removal of the unwind-protect; this fixes a bug where a child
1721 function unwinds the stack past us.
1722
27e498e6
PE
1723 New unwind-protect flavors to better type-check C callbacks.
1724 This also lessens the need to write wrappers for callbacks,
1725 and the need for make_save_pointer.
1726 * alloca.c (free_save_value):
1727 * atimer.c (run_all_atimers):
1728 Now extern.
1729 * alloc.c (safe_alloca_unwind):
1730 * atimer.c (unwind_stop_other_atimers):
1731 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1732 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1733 * minibuf.c (choose_minibuf_frame_1):
1734 * process.c (make_serial_process_unwind):
1735 * xdisp.h (pop_message_unwind):
1736 * xselect.c (queue_selection_requests_unwind):
1737 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1738 * alloca.c (record_xmalloc):
1739 Prefer record_unwind_protect_ptr to record_unwind_protect with
1740 make_save_pointer.
1741 * alloca.c (Fgarbage_collect):
1742 Prefer record_unwind_protect_void to passing a dummy.
1743 * buffer.c (restore_buffer):
1744 * window.c (restore_window_configuration):
1745 * xfns.c, w32fns.c (do_unwind_create_frame)
1746 New wrapper. All record-unwind uses of wrappee changed.
1747 * buffer.c (set_buffer_if_live):
1748 * callproc.c (call_process_cleanup, delete_temp_file):
1749 * coding.c (code_conversion_restore):
1750 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1751 * editfns.c (save_excursion_restore)
1752 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1753 (save_restriction_restore):
1754 * eval.c (restore_stack_limits, un_autoload):
1755 * fns.c (require_unwind):
1756 * keyboard.c (recursive_edit_unwind, tracking_off):
1757 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1758 * macros.c (pop_kbd_macro, restore_menu_items):
1759 * nsfns.m (unwind_create_frame):
1760 * print.c (print_unwind):
1761 * process.c (start_process_unwind):
1762 * search.c (unwind_set_match_data):
1763 * window.c (select_window_norecord, select_frame_norecord):
1764 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1765 (fast_set_selected_frame):
1766 * xfns.c, w32fns.c (unwind_create_tip_frame):
1767 Return void, not a dummy Lisp_Object. All uses changed.
1768 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1769 * callproc.c (call_process_kill):
1770 * fileio.c (restore_point_unwind, decide_coding_unwind)
1771 (build_annotations_unwind):
1772 * insdel.c (Fcombine_after_change_execute_1):
1773 * keyboard.c (read_char_help_form_unwind):
1774 * menu.c (unuse_menu_items):
1775 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1776 * sound.c (sound_cleanup):
1777 * xdisp.c (unwind_redisplay):
1778 * xfns.c (clean_up_dialog):
1779 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1780 Accept no args and return void, instead of accepting and returning
1781 a dummy Lisp_Object. All uses changed.
1782 * cygw32.c (fchdir_unwind):
1783 * fileio.c (close_file_unwind):
1784 * keyboard.c (restore_kboard_configuration):
1785 * lread.c (readevalllop_1):
1786 * process.c (wait_reading_process_output_unwind):
1787 Accept int and return void, rather than accepting an Emacs integer
1788 and returning a dummy object. In some cases this fixes an
1789 unlikely bug when the corresponding int is outside Emacs integer
1790 range. All uses changed.
1791 * dired.c (directory_files_internal_unwind):
1792 * fileio.c (do_auto_save_unwind):
1793 * gtkutil.c (pop_down_dialog):
1794 * insdel.c (reset_var_on_error):
1795 * lread.c (load_unwind):
1796 * xfns.c (clean_up_file_dialog):
1797 * xmenu.c, nsmenu.m (pop_down_menu):
1798 * xmenu.c (cleanup_widget_value_tree):
1799 * xselect.c (wait_for_property_change_unwind):
1800 Accept pointer and return void, rather than accepting an Emacs
1801 save value encapsulating the pointer and returning a dummy object.
1802 All uses changed.
1803 * editfns.c (Fformat): Update the saved pointer directly via
1804 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1805 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1806 (unwind_body): New function.
1807 (record_unwind_protect): First arg is now a function returning void,
1808 not a dummy Lisp_Object.
1809 (record_unwind_protect_ptr, record_unwind_protect_int)
1810 (record_unwind_protect_void): New functions.
1811 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1812 * fileio.c (struct auto_save_unwind): New type.
1813 (do_auto_save_unwind): Use it.
1814 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1815 * insdel.c (struct rvoe_arg): New type.
1816 (reset_var_on_error): Use it.
1817 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1818 New constants.
1819 (specbinding_func): Remove; there are now several such functions.
1820 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1821 (set_unwind_protect_ptr): New function.
1822 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1823
4e604a5d
PE
1824 Be simpler and more consistent about reporting I/O errors.
1825 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1826 Say "Read error" and "Write error", rather than "I/O error", or
1827 "IO error reading", or "IO error writing", when a read or write
1828 error occurs.
1829 * process.c (Fmake_network_process, wait_reading_process_output)
1830 (send_process, Fprocess_send_eof, wait_reading_process_output):
1831 Capitalize diagnostics consistently. Put "failed foo" at the
1832 start of the diagnostic, so that we don't capitalize the
1833 function name "foo". Consistently say "failed" for such
1834 diagnostics.
1835 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1836 All callers changed. This is so it can use report_file_error.
1837 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1838 diagnostics consistently as above.
1839
a9757f6a
PE
1840 * fileio.c (report_file_errno): Fix errno reporting bug.
1841 If the file name is neither null nor a pair, package it up as a
1842 singleton list. All callers changed, both to this function and to
1843 report_file_error. This fixes a bug where the memory allocator
1844 invoked by list1 set errno so that the immediately following
1845 report_file_error reported the wrong errno value.
1846
c43843aa
PE
1847 Fix minor problems found by --enable-gcc-warnings.
1848 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1849 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1850
18c26d81
JD
18512013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1852
1853 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1854 Set event->arg to Qt if switch-event shall be generated.
1855 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1856
1857 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1858
1859 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1860 FOCUS_OUT_EVENT.
1861
1862 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1863 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1864 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1865 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1866 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1867 and there is a focused frame.
1868 (head_table): Add focus-in and focus-out.
1869 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1870 bind to handle-focus-in/out.
1871
1872 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1873 (Fhandle_switch_frame): Call Fhandle_focus_in.
1874 (syms_of_frame): defsubr handle-focus-in/out.
1875
6c6f1994
PE
18762013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1877
c7ddc792
PE
1878 Fix porting bug to older POSIXish platforms (Bug#14862).
1879 * sysdep.c (emacs_pipe): New function, that implements
1880 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1881 This should port better to CentOS 5 and to Mac OS X 10.6.
1882 All calls to pipe2 changed.
1883
6c6f1994
PE
1884 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1885 This makes the code easier to read and the executable a bit smaller.
1886 Do not replace all calls to Fcons that happen to create lists,
1887 just calls that are intended to create lists. For example, when
1888 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1889 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1890 Similarly for list2 through list5.
1891 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1892 * bytecode.c (exec_byte_code):
1893 * callint.c (quotify_arg, Fcall_interactively):
1894 * callproc.c (Fcall_process, create_temp_file):
1895 * charset.c (load_charset_map_from_file)
1896 (Fdefine_charset_internal, init_charset):
1897 * coding.c (get_translation_table, detect_coding_system)
1898 (Fcheck_coding_systems_region)
1899 (Fset_terminal_coding_system_internal)
1900 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1901 * composite.c (update_compositions, Ffind_composition_internal):
1902 * dired.c (directory_files_internal, file_name_completion)
1903 (Fsystem_users):
1904 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1905 * doc.c (Fsnarf_documentation):
1906 * editfns.c (Fmessage_box):
1907 * emacs.c (main):
1908 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1909 (Feval, eval_sub, Ffuncall, apply_lambda):
1910 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1911 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1912 (Fset_file_times, Finsert_file_contents)
1913 (Fchoose_write_coding_system, Fwrite_region):
1914 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1915 * font.c (font_registry_charsets, font_parse_fcname)
1916 (font_prepare_cache, font_update_drivers, Flist_fonts):
1917 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1918 * frame.c (make_frame, Fmake_terminal_frame)
1919 (x_set_frame_parameters, x_report_frame_params)
1920 (x_default_parameter, Fx_parse_geometry):
1921 * ftfont.c (syms_of_ftfont):
1922 * image.c (gif_load):
1923 * keyboard.c (command_loop_1):
1924 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1925 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1926 (Fminor_mode_key_binding, accessible_keymaps_1)
1927 (Faccessible_keymaps, Fwhere_is_internal):
1928 * lread.c (read_emacs_mule_char):
1929 * menu.c (find_and_return_menu_selection):
1930 * minibuf.c (get_minibuffer):
1931 * nsfns.m (Fns_perform_service):
1932 * nsfont.m (ns_script_to_charset):
1933 * nsmenu.m (ns_popup_dialog):
1934 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1935 (Fx_own_selection_internal):
1936 * nsterm.m (append2):
1937 * print.c (Fredirect_debugging_output)
1938 (print_prune_string_charset):
1939 * process.c (Fdelete_process, Fprocess_contact)
1940 (Fformat_network_address, set_socket_option)
1941 (read_and_dispose_of_process_output, write_queue_push)
1942 (send_process, exec_sentinel):
1943 * sound.c (Fplay_sound_internal):
1944 * textprop.c (validate_plist, add_properties)
1945 (Fput_text_property, Fadd_face_text_property)
1946 (copy_text_properties, text_property_list, syms_of_textprop):
1947 * unexaix.c (report_error):
1948 * unexcoff.c (report_error):
1949 * unexsol.c (unexec):
1950 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1951 (Fformat_mode_line, syms_of_xdisp):
1952 * xfaces.c (set_font_frame_param)
1953 (Finternal_lisp_face_attribute_values)
1954 (Finternal_merge_in_global_face, syms_of_xfaces):
1955 * xfns.c (x_default_scroll_bar_color_parameter)
1956 (x_default_font_parameter, x_create_tip_frame):
1957 * xfont.c (xfont_supported_scripts):
1958 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1959 (menu_help_callback, xmenu_show):
1960 * xml.c (make_dom):
1961 * xterm.c (set_wm_state):
1962 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1963 and similarly for list2 through list5.
1964
bafe80ce
PE
19652013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 * callproc.c (Fcall_process_region): Fix minor race and tune.
1968 (create_temp_file): New function, with the temp-file-creation part
1969 of the old Fcall_process_region. Use Fcopy_sequence to create the
1970 temp file name, rather than alloca + build_string, for simplicity.
1971 Don't bother to block input around the temp file creation;
068f9124
SM
1972 shouldn't be needed. Simplify use of mktemp.
1973 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
1974 this closes an unlikely race where the temp file was not removed.
1975 Use memcpy rather than an open-coded loop.
1976 (Fcall_process_region): Use the new function. If the input is
1977 empty, redirect from /dev/null rather than from a newly created
1978 empty temp file; this avoids unnecessary file system traffic.
1979
4700b5a5
PE
19802013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1981
5c97beae
PE
1982 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1983 Simplify by making this case like the other two. This is a bit
1984 slower on obsolete hosts, but the extra complexity isn't worth it.
1985
4700b5a5
PE
1986 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1987 * process.c (create_process) [!DOS_NT]:
1988 Remove now-unnecessary calls to emacs_close.
1989
f9a74c4c
EZ
19902013-07-13 Eli Zaretskii <eliz@gnu.org>
1991
922ae7ee
EZ
1992 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1993 returning early. (Bug#14850)
1994
f9a74c4c
EZ
1995 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1996 and inhibit-iso-escape-detection attributes of 'undecided'.
1997 (Bug#14822)
1998
5e301d76
PE
19992013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2000
69e0e5ee
PE
2001 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2002 Reported by Herbert J. Skuhra in
2003 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2004
5e301d76
PE
2005 Don't lose top specpdl entry when memory is exhausted.
2006 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2007 specpdl overflow here, to simplify callers; all callers changed.
2008 Always reserve an unused entry at the stack top; this avoids
2009 losing the top entry's information when memory is exhausted.
2010
7e649856
PE
20112013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2012
a773ed9a
PE
2013 Clean up errno reporting and fix some errno-reporting bugs.
2014 * callproc.c (Fcall_process):
2015 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2016 * process.c (create_process, Fmake_network_process):
2017 * unexaix.c (report_error):
2018 * unexcoff.c (report_error):
2019 Be more careful about reporting the errno of failed operations.
2020 The code previously reported the wrong errno sometimes.
2021 Also, prefer report_file_errno to setting errno + report_file_error.
2022 (Fcall_process): Look at openp return value rather than at path,
2023 as that's a bit faster and clearer when there's a numeric predicate.
2024 * fileio.c (report_file_errno): New function, with most of the
2025 old contents of report_file_error.
2026 (report_file_error): Use it.
2027 (Ffile_exists_p, Ffile_accessible_directory_p):
2028 Set errno to 0 when it is junk.
2029 * fileio.c (Faccess_file):
2030 * image.c (x_create_bitmap_from_file):
2031 Use faccessat rather than opening the file, to avoid the hassle of
2032 having a file descriptor open.
2033 * lisp.h (report_file_errno): New decl.
2034 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2035
7e649856
PE
2036 Minor EBADF fixes.
2037 * process.c (create_process, wait_reading_process_output) [AIX]:
2038 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2039 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2040 a multithreaded environment anyway).
2041 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2042
f6774c1a
AS
20432013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2044
2045 * image.c (x_find_image_file): Don't close a remote file handle.
2046
bacba3c2
PE
20472013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2048
2049 Fix races with threads and file descriptors.
2050 * callproc.c (Fcall_process_region):
2051 * dired.c (open_directory):
2052 * emacs.c (main, Fdaemon_initialized):
2053 * image.c (x_find_image_file):
2054 * inotify.c (Finotify_rm_watch):
2055 * lread.c (Flocate_file_internal):
2056 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2057 * term.c (term_mouse_moveto, init_tty):
2058 * termcap.c (tgetent):
2059 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2060 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2061 * unexhp9k800.c, unexmacosx.c (unexec):
2062 * callproc.c (Fcall_process_region):
2063 Use emacs_close, not close.
2064 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2065 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2066 and posix_close function on current platforms (which all lack them).
2067 (emacs_close): Use it. This should fix the races on GNU/Linux and
2068 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2069 and it should avoid closing random victim file descriptors on
2070 other platforms.
2071
653d4f43
PE
20722013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2073
c8536ec4
PE
2074 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2075 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2076 Touch up doc a bit.
2077
9c203066
PE
2078 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2079 This is for .gdbinit xbacktrace.
2080
653d4f43
PE
2081 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2082 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2083 (emacs_set_tty): Now static.
2084 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2085 * term.c (tty_capable_p, tty_default_color_capabilities)
2086 (get_tty_terminal, term_mouse_movement)
2087 (handle_one_term_event, init_tty, maybe_fatal):
2088 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2089 (tgetent, scan_file, name_match, compare_contin):
2090 * terminal.c (get_terminal):
2091 Use bool for boolean.
2092 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2093 Prefer char to unsigned char if either will do.
2094 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2095 (tty_write_glyphs): Prefer int to unsigned.
2096 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2097 All callers changed.
2098 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2099
45b683a1
PE
21002013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2101
29abe551
PE
2102 Port to C89.
2103 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2104 (B__dummy__): New dummy symbol, to pacify C89.
2105 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2106 they can't grok varargs macros.
2107 * dispnew.c (add_window_display_history)
2108 (add_frame_display_history):
2109 * print.c (print_object):
2110 * xdisp.c (debug_method_add):
2111 Use %p printf format only for void pointers.
2112 * emacs.c (usage_message): New constant, replacing ...
2113 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2114 (main): Adjust to usage reorg.
2115 * fns.c (syms_of_fns):
2116 * profiler.c (syms_of_profiler):
2117 Don't use non-constant struct initializers.
2118 * gnutls.h (gnutls_initstage_t):
2119 * lisp.h (enum Lisp_Fwd_Type):
2120 * lread.c (lisp_file_lexically_bound_p):
2121 * xsettings.c (anonymous enum):
2122 Remove trailing comma.
2123 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2124 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2125 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2126 (DEFUN): Use it.
2127 * regex.c (const_re_char): New type, to pacify strict C89.
2128 All uses of 'const re_char' replaced to use it.
2129 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2130 with glibc when strict C89. This change is imported from gnulib.
2131 All uses changed.
2132 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2133 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2134 Omit GNU_LINUX implementation, since it requires long long.
2135 * xterm.c (x_draw_underwave):
2136 Do not assume the traditional order of struct's members.
2137 (x_term_init): Rewrite to avoid the need for non-constant structure
2138 initializers.
2139
45b683a1 2140 Syntax cleanup, mostly replacing macros with functions.
763a086d 2141 This removes the need for the syntax_temp hack.
45b683a1
PE
2142 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2143 * syntax.c (SYNTAX_INLINE): New macro.
2144 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2145 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2146 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2147 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2148 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2149 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2150 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2151 Now constants, not macros.
2152 (syntax_temp) [!__GNUC__]: Remove.
2153 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2154 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2155 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2156 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2157 Move here from syntax.h; now functions, not macros. Except for the
2158 last function, these are static since only syntax.c uses them.
2159 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2160 All uses changed. Now a function, not a macro; use this fact
2161 to simplify the code.
2162 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2163 compiler bugs; no longer relevant.
2164 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2165 (SYNTAX_INLINE): New macro.
2166 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2167 for the new functions. Use bool for boolean member.
2168 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2169 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2170 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2171 (SETUP_BUFFER_SYNTAX_TABLE):
2172 Now extern inline functions, not macros.
2173 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2174 Remove; all uses replaced by implementation.
2175 (syntax_temp) [!__GNUC__]: Remove decl.
2176 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2177
29be4a50
JD
21782013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2179
2180 * emacs.c (main): Fix syntax error.
2181
954b166e
PE
21822013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2183
2184 Timestamp fixes for undo (Bug#14824).
2185 * atimer.c (schedule_atimer):
2186 * fileio.c (Ffile_newer_than_file_p):
2187 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2188 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2189 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2190 (syms_of_fileio): Remove Sclear_visited_file_name.
2191 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2192 file doesn't exist; this avoids an ambiguity with negative timestamps.
2193 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2194 * systime.h (make_emacs_time, invalid_emacs_time):
2195 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2196 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2197 * undo.c (record_first_change): Push (visited-file-modtime) onto
2198 undo list rather than reimplementing it by hand, incorrectly.
2199
d74647c3
KB
22002013-07-09 Ken Brown <kbrown@cornell.edu>
2201
2202 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2203
3c51b96b
JB
22042013-07-09 Juanma Barranquero <lekktu@gmail.com>
2205
2206 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2207
4ebbdd67
PE
22082013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 Handle errno and exit status a bit more carefully.
2211 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2212 number into an exit status. Instead, use EXIT_CANCELED.
2213 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2214 * callproc.c (relocate_fd):
2215 * emacs.c (close_output_streams, main):
2216 * process.c (create_process):
2217 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2218 Use emacs_perror for simplicity.
2219 * callproc.c (relocate_fd, main):
2220 * sysdep.c (sys_subshell):
2221 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2222 (shut_down_emacs): Use emacs_write, not write.
2223 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2224 * fileio.c (Fcopy_file, e_write):
2225 * nsterm.m (ns_select):
2226 * process.c (send_process):
2227 * sound.c (vox_write):
2228 Use emacs_write_sig, not emacs_write.
2229 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2230 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2231 New constants.
2232 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2233 of write.
2234 (emacs_full_write): New function.
2235 (emacs_write): Rewrite to use it.
2236 (emacswrite_sig, emacs_perror): New functions.
2237 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2238
44e18199 22392013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2240
2241 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2242 on NS even if it is present. Pixmap on NS is a void*.
2243
9caab067
PE
22442013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 Port to Ubuntu 10 (Bug#14803).
2247 Problem reported by T.V. Raman.
2248 * process.c (close_on_exec, accept4, process_socket):
2249 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2250
1d442672
EZ
22512013-07-07 Eli Zaretskii <eliz@gnu.org>
2252
2253 * w32.c (sys_dup): Declare prototype.
2254
2255 * filelock.c:
2256 * emacs.c:
2257 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2258
067428c1
PE
22592013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2260
2261 Make file descriptors close-on-exec when possible (Bug#14803).
2262 This simplifies Emacs a bit, since it no longer needs to worry
2263 about closing file descriptors by hand in some cases.
2264 It also fixes some unlikely races. Not all such races, as
2265 libraries often open files internally without setting
2266 close-on-exec, but it's an improvement.
2267 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2268 * callproc.c (Fcall_process) [!MSDOS]:
2269 * emacs.c (main) [!DOS_NT]:
2270 * nsterm.m (ns_term_init):
2271 * process.c (create_process):
2272 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2273 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2274 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2275 Prefer mkostemp with O_CLOEXEC to mkstemp.
2276 * callproc.c (relocate_fd) [!WINDOWSNT]:
2277 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2278 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2279 now using pipe2.
2280 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2281 Make the resulting file descriptor close-on-exec.
2282 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2283 * lread.c (load_descriptor_list, load_descriptor_unwind):
2284 Remove; no longer needed. All uses removed.
2285 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2286 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2287 New functions.
2288 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2289 (Fmake_network_process, Fnetwork_interface_list):
2290 (Fnetwork_interface_info, server_accept_connection):
2291 Make newly-created socket close-on-exec.
2292 * sysdep.c (emacs_open, emacs_fopen):
2293 Make new-created descriptor close-on-exec.
2294 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2295 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2296
0da857dd
JD
22972013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2298
2299 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2300 for NS_IMPL_GNUSTEP.
2301
5f86adcd
PE
23022013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 Fix openp errno handling.
2305 * callproc.c (Fcall_process): Preserve openp errno around close.
2306 * lread.c (openp): Set errno when returning -1, as some callers
2307 expect this.
2308
1afb1d07
JD
23092013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2310
2311 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2312
2313 * nsterm.h (NSSavePanel): Update comment.
2314 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2315 (ns_run_file_dialog): Declare.
2316
2317 * nsfns.m: Remove panelOK.
2318 (ns_fd_data): New.
2319 (ns_run_file_dialog): New function.
2320 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2321 event loop, so file dialog is popped up by ns_run_file_dialog, called
2322 by sendEvent (Bug#14578).
2323 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2324
3323c263
EZ
23252013-07-06 Eli Zaretskii <eliz@gnu.org>
2326
fdda0220
EZ
2327 * xdisp.c (default_line_pixel_height): New function.
2328 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2329 (try_cursor_movement, redisplay_window, try_window)
2330 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2331
068f9124
SM
2332 * window.c (window_scroll_pixel_based):
2333 use default_line_pixel_height.
fdda0220
EZ
2334
2335 * dispextern.h (default_line_pixel_height): Add prototype.
2336
2337 * frame.c (x_set_line_spacing): Accept a float value for
2338 line-spacing parameter, per the documentation.
2339
3323c263
EZ
2340 * data.c (Fmultibyte_string_p): Doc fix.
2341
47ba6d43
PE
23422013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2343
406af475
PE
2344 Use emacs_open more consistently when opening files.
2345 This handles EINTR more consistently now, and makes it easier
2346 to introduce other uniform changes to file descriptor handling.
2347 * src/systdio.h: New file.
2348 * src/buffer.c (mmap_init):
2349 * cygw32.c (chdir_to_default_directory):
2350 * dispnew.c (Fopen_termscript):
2351 * emacs.c (Fdaemon_initialized):
2352 * fileio.c (Fdo_auto_save):
2353 * image.c (slurp_file, png_load_body, jpeg_load_body):
2354 * keyboard.c (Fopen_dribble_file):
2355 * lread.c (Fload):
2356 * print.c (Fredirect_debugging_output):
2357 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2358 * termcap.c (tgetent):
2359 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2360 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2361 * w32term.c (w32_initialize) [CYGWIN]:
2362 * xfaces.c (Fx_load_color_file):
2363 Use emacs_open instead of plain open, and emacs_fopen instead of
2364 plain fopen.
2365 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2366 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2367 * callproc.c (default_output_mode): New constant.
2368 (Fcall_process): Use it to call emacs_open instead of plain creat.
2369 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2370 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2371 (emacs_fopen): New function.
2372 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2373 Include <lisp.h>, for emacs_open.
2374 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2375
47ba6d43
PE
2376 Remove duplicate #include directives.
2377 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2378 * xfaces.c:
2379 Don't include stdio.h twice.
2380 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2381 Don't include sys/types.h or stdio.h twice.
2382 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2383 * lread.c: Don't include coding.h twice.
2384 * nsfont.m: Don't include frame.h twice.
2385 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2386 * ralloc.c: Don't include <unistd.h> twice.
2387 * xdisp.c: Don't include font.h twice.
2388 * xterm.c: Don't include fontset.h twice.
2389 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2390
b9ed53d5
PE
23912013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 Scale ImageMagick images more carefully.
2394 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2395 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2396 Be more careful about avoiding undefined behavior after
2397 integer overflow and division by zero.
2398
cf13177e
YM
23992013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2400
2401 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2402 (syms_of_w32fns): DEFSYM them.
2403 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2404 (CCHDEVICENAME): Define macros if not defined.
2405 (struct MONITOR_INFO_EX): New struct.
2406 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2407 (enum_display_monitors_fn): New variable.
2408 (globals_of_w32fns): Initialize it.
2409 (Fx_display_pixel_width, Fx_display_pixel_height)
2410 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2411 multi-monitor setups in docstrings.
2412 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2413 screen size by primary monitor's millimeter per pixel.
2414 (w32_monitor_enum, w32_display_monitor_attributes_list)
2415 (w32_display_monitor_attributes_list_fallback)
2416 (Fw32_display_monitor_attributes_list): New functions.
2417 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2418
2419 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2420 if not defined.
2421 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2422
86dfb7a8
MA
24232013-07-04 Michael Albinus <michael.albinus@gmx.de>
2424
2425 * fileio.c (Qfile_notify_error): New error symbol.
2426
2427 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2428 * inotify.c (inotify_callback, symbol_to_inotifymask)
2429 (Finotify_add_watch, Finotify_rm_watch): Use it.
2430 (inotifyevent_to_event): Exchange order of cookie and file name.
2431 (Finotify_add_watch): Adapt docstring.
2432
2433 * lisp.h (Qfile_notify_error): Declare.
2434
2c1c974b
PE
24352013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2438 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2439 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2440 which did not work (see <http://bugs.gnu.org/14569#307>).
2441 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2442 && (!noninteractive || initialized)). This attempts to thread
2443 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2444
7a35b20f
JB
24452013-07-04 Juanma Barranquero <lekktu@gmail.com>
2446
2447 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2448 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2449
1ce5cd04
PE
24502013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2453 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2454 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2455 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2456
57f8c490
PE
24572013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2460 Define to __sys_siglist.
2461
bcffb5ca
EZ
24622013-07-02 Eli Zaretskii <eliz@gnu.org>
2463
2464 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2465 word-wrap, so that overflow-newline-into-fringe would work in
2466 visual-line-mode. (Bug#2749)
2467 (move_it_in_display_line_to): When the last scanned display
2468 element fits exactly on the display line, and
2469 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2470 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2471 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2472 finding buffer position that corresponds to pixel coordinates,
2473 e.g. in buffer_posn_from_coords.
2474
2c41e781
JD
24752013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2476
2477 * process.c (handle_child_signal): Call catch_child_signal if
2478 NS_IMPL_GNUSTEP.
2479
c2418359
PE
24802013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2481
52a9bcae
PE
2482 Don't convert function pointers to void * and back.
2483 It isn't portable C, and it's easy enough to avoid.
2484 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2485 (make_save_value): Add support for SAVE_FUNCPOINTER.
2486 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2487 * print.c (print_object):
2488 Distinguish function from object pointers.
2489 * lisp.h (SAVE_FUNCPOINTER): New constant.
2490 (SAVE_SLOT_BITS): Adjust to it.
2491 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2492 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2493 (voidfuncptr): New typedef.
2494 (struct Lisp_Save_Value): New member data[0].funcpointer.
2495 (XSAVE_FUNCPOINTER): New function.
2496
c2418359
PE
2497 Simplify buildobj processing.
2498 * Makefile.in (buildobj.h): Make it a sequence of strings each
2499 followed by comma, rather than a single string. Put it into a
2500 .tmp file in case there's an error while generating it.
2501 (gl-stamp): Use .tmp for temp files.
2502 (mostlyclean): Clean .tmp files.
2503 * doc.c (buildobj): Move to just the routine that needs it.
2504 It's now an array of strings, so processing is simpler.
2505
8f43ce49
PE
25062013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2509 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2510 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2511 Invoke malloc_enable_thread even when not interactive.
2512 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2513 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2514 in this case, since the underlying bug has now been fixed.
2515
24827db9
JB
25162013-07-01 Juanma Barranquero <lekktu@gmail.com>
2517
2518 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2519 unlinking it (bug#14691).
2520
ef099a94
MN
25212013-06-30 Michal Nazarewicz <mina86@mina86.com>
2522
2523 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2524 before checking whether buffer is modified. This lets
2525 `kill-buffer-query-functions' cancel killing of the buffer or save
2526 its content before `kill-buffer' asks user the "Buffer %s
2527 modified; kill anyway?" question.
2528
9d3f2fc2
JD
25292013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2530
2531 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2532 Let the super performKeyEquivalent deal with them (Bug#14747).
2533
e6c6c8c7
PE
25342013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2535
1d71c1d9
PE
2536 * widget.c (resize_cb): Remove unused local.
2537
8f5f35cc
PE
2538 Do not use GTK 3 if it exists but cannot be compiled.
2539 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2540 * xterm.c (x_error_handler) [!USE_GTK]:
2541 Do not use GTK 3.
2542
e6c6c8c7
PE
2543 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2544
0ba54312
EZ
25452013-06-30 Eli Zaretskii <eliz@gnu.org>
2546
5d1c3286
EZ
2547 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2548 to the valid range of values. (Bug#14753)
2549
0ba54312
EZ
2550 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2551 when moving point by using the current glyph matrix. This avoids
2552 the need to force redisplay when this function is called in a
2553 loop.
2554
9c90cc06
PE
25552013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 Fix minor problems found by static checking.
2558 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2559 Redo the latter's body to sidestep GCC parenthesization warnings.
2560 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2561 * coding.c (detect_coding, detect_coding_system):
2562 * coding.h (struct undecided_spec):
2563 Use bool for boolean.
2564 * image.c (QCmax_width, QCmax_height): Now static.
2565 * xdisp.c (Fmove_point_visually): Remove unused local.
2566
4c672a0f
EZ
25672013-06-29 Eli Zaretskii <eliz@gnu.org>
2568
2569 * xdisp.c (Fmove_point_visually): New function.
2570
c1ea3abf
JB
25712013-06-28 Kenichi Handa <handa@gnu.org>
2572
2573 * coding.h (define_coding_undecided_arg_index): New enum.
2574 (coding_attr_index): New members
2575 coding_attr_undecided_inhibit_null_byte_detection,
2576 coding_attr_undecided_inhibit_iso_escape_detection,
2577 coding_attr_undecided_prefer_utf_8.
2578 (undecided_spec): New struct.
2579 (struct coding_system): New member `undecided' of the member
2580 `spec'.
2581
2582 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2583 (detect_coding): Likewise.
2584 (detect_coding_system): Likewise.
2585 (Fdefine_coding_system_internal): New coding system properties
2586 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2587 :prefer-utf-8.
2588 (syms_of_coding): Adjust for coding_arg_undecided_max.
2589
ba3de9e6
PE
25902013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 * image.c (x_from_xcolors): Remove unused local.
2593
547c9269
YM
25942013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2595
2596 Defer image data transfer between X client and server until actual
2597 display happens.
2598
2599 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2600 and `mask_img'.
2601
2602 * image.c (Destroy_Image): Remove.
2603 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2604 `mask_p', and `colors_p'. All uses changed.
2605 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2606 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2607 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2608 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2609 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2610 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2611 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2612 (image_get_x_image, image_unget_x_image): New functions or macros.
2613 (image_background, image_background_transparent, x_to_xcolors)
2614 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2615 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2616 instead of Destroy_Image.
2617 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2618 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2619 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2620 (imagemagick_load_image, svg_load_image): Use them instead of
2621 x_create_x_image_and_pixmap, and x_put_x_image followed by
2622 x_destroy_x_image, respectively.
2623 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2624 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2625 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2626 background_transparent fields.
2627 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2628 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2629
dae2f5ef
PE
26302013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2631
2632 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2633 This mostly consists of undoing recent changes.
2634 * callproc.c (Fcall_process):
2635 * process.c (create_process):
2636 Do not worry about catching SIGCHLD here, undoing previous change.
2637 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2638 * process.c, process.h (catch_child_signal):
2639 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2640 * process.c (catch_child_handler): Don't worry about being called
2641 lazily and do not assume caller has blocked SIGCHLD, undoing
2642 previous change. Move first-time stuff back to
2643 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2644 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2645 set lib_child_handler if it's already initialized, which may
2646 help avoid problems on GNUStep.
2647
fa55d2aa
PE
26482013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2649
2650 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2651 * callproc.c (Fcall_process):
2652 * process.c (create_process):
2653 Make sure SIGCHLD is caught before we fork,
2654 since Emacs startup no arranges to catch SIGCHLD.
2655 * process.c (lib_child_handler): Initialize to null, not to
2656 dummy_handler.
2657 (catch_child_signal): Allow self to be called lazily.
2658 Do nothing if it's already been called.
2659 Assume caller has blocked SIGCHLD (all callers do now).
2660 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2661 just before it's really needed.
2662 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2663 since it hasn't been caught yet.
2664
f3f9606c
LMI
26652013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2666
2667 * image.c (compute_image_size): New function to implement
2668 :max-width and :max-height.
2669 (imagemagick_load_image): Use it.
2670
c7041908
PE
26712013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2674 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2675 Now extern.
2676 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2677 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2678 the SIGCHLD handler, since the code is not atomic and (due to glib)
2679 signals may be arriving now.
2680 * sysdep.c (init_signals): Do not catch child signals here;
2681 'main' now does that later, at a safer time.
2682
f86852b4
PE
26832013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2684
0dfeed58
PE
2685 Clean up SIGCHLD handling a bit (Bug#14569).
2686 * process.c, process.h (catch_child_signal):
2687 Now always extern, even if !NS_IMPL_GNUSTEP.
2688 * process.c (catch_child_signal): Move glib tickler here from
2689 init_process_emacs, so that it's done earlier in Emacs
2690 initialization. Also move the noninteractive && !initialized
2691 check here from init_process_emacs. This is all a bit cleaner for
2692 GNUish platforms, and I hope it works around the Cygwin bug.
2693 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2694 that glib signal handling is tickled before glib creates threads.
2695
f86852b4
PE
2696 * process.c (wait_reading_process_output): Avoid int overflow
2697 when reading more than 2 GiB total from a process.
2698
cbd6509c
PE
26992013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 * process.c (create_process): Handle a couple more cases,
2702 i.e., work even if new_argv and wait_child_setup[i] are cached.
2703 Use Fcall_process's style for volatile vars.
2704
9de1114a
AS
27052013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2706
2707 * process.c (create_process): Mark PROCESS volatile.
2708
fbe9e0b9
PE
27092013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 Use C99-style flexible array members if available.
2712 This avoids some subtle aliasing issues, which typically
2713 aren't a problem with GCC but may be a problem elsewhere.
2714 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2715 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2716 In either case, it uses a flexible array member rather than
2717 the old struct hack. All uses changed.
2718 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2719 Adjust to sdata reorganization.
2720 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2721 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2722 that ports better to pre-C99 non-GCC.
2723 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2724 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2725 as the latter has changed.
2726 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2727 and port better to pre-C99 GCC.
2728 * image.c (struct xpm_cached_color):
2729 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2730 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2731 Use FLEXIBLE_ARRAY_MEMBER.
2732 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2733 Move decl to top level so it gets checked against implementation.
2734 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2735 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2736
1fc71008
PE
27372013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 * syntax.c: Integer cleanups.
2740 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2741 All uses that need 0-or-2 changed to:
2742 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2743 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2744 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2745 (char_quoted, prev_char_comend_first, back_comment)
2746 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2747 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2748 Use bool for boolean.
2749 (update_syntax_table, skip_chars, skip_syntaxes):
2750 Prefer int to unsigned when either will do.
2751 (back_comment): Return boolean success flag, like forw_comment,
2752 instead of positive-or-minus-1 (which might have overflowed int anyway).
2753 Don't stuff ptrdiff_t into int.
2754 (syntax_spec_code, syntax_code_spec): Now const.
2755 (Fmatching_paren, scan_lists, scan_sexps_forward):
2756 Use enum syntaxcode for syntax code.
2757 (Fmatching_paren): Check that arg is a character, not just an integer.
2758 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2759 (Finternal_describe_syntax_value): Omit no-longer-needed
2760 comparison to 0.
2761 (skip_chars): Use char, not unsigned char, when the distinction
2762 doesn't matter.
2763 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2764 * bytecode.c (exec_byte_code):
2765 * syntax.c (syntax_spec_code, Fchar_syntax)
2766 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2767 (init_syntax_once):
2768 * syntax.h (SYNTAX_WITH_FLAGS):
2769 Omit unnecessary casts.
2770
b932cad7
EZ
27712013-06-20 Eli Zaretskii <eliz@gnu.org>
2772
2773 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2774 line dimensions here, to avoid race conditions with the main
2775 thread. (Bug#14062, bug#14630, bug#14669)
2776
2777 * w32term.c (w32_draw_window_cursor): Compute the header line and
2778 mode line dimensions here.
2779 <w32_system_caret_window, w32_system_caret_hdr_height>:
2780 <w32_system_caret_mode_height>: New variables.
2781
2782 * w32term.h: Declare them.
2783
89561f72
PE
27842013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2785
5013fc08
PE
2786 * alloc.c (die): Move "assertion failed" string here ...
2787 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2788 COND when SUPPRESS_CHECKING. This shrinks the executable text
2789 size by 0.8% to 2.2% when configured with --enable-checking,
2790 depending on optimization flags (GCC 4.8.1 x86-64).
2791
89561f72
PE
2792 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2793
763a086d 27942013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2795
2796 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2797 base is 2; this is more accurate.
2798
983aeb9a
JB
27992013-06-19 Juanma Barranquero <lekktu@gmail.com>
2800
2801 * sound.c (string_default): Move to !WINDOWSNT section.
2802 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2803
178ba3e6
PE
28042013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2805
bbc51b15
PE
2806 * sound.c: Integer cleanups.
2807 Remove unnecessary forward decls.
2808 (struct sound_device): The 'file' member is now a Lisp_Object, not
2809 a char *, so that we needn't invoke alloca on a huge size.
2810 (Fplay_sound_internal): Adjust to this.
2811 (string_default): New function.
2812 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2813 Use it to adjust to the struct sound_device change.
2814 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2815 (be2hs) [0]: Remove.
2816
178ba3e6
PE
2817 * syntax.c (skip_chars): Don't use uninitialized storage
2818 when searching a multibyte buffer for characters that are not in a
2819 unibyte string that contains non-ASCII characters.
2820
69f60cdc
JD
28212013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2822
2823 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2824 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2825
0d6224d4
PE
28262013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2829
3c542890
KH
28302013-06-18 Kenichi Handa <handa@gnu.org>
2831
f7e3f7cd
KH
2832 * font.c (Ffont_spec): Signal an error for an invalid font name
2833 (Bug#14648).
3c542890 2834
9349e5f7
PE
28352013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2838 In particular this ports to 32-bit sparc Sun cc.
2839 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2840 array with a dummy element at specpdl[-1], so that its address can
2841 be taken portably.
2842 (unbind_to): Do not copy the binding; not needed, now that we
2843 copy old_value in the one place where the copy is needed.
2844 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2845 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2846 (union specbinding): Rename from struct specbinding. Redo layout
2847 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2848 which is not portable. With Sun C 5.12 32-bit sparc, the
2849 declaration causes nargs to be an unsigned bitfield, a behavior
2850 that the C standard allows; but Emacs wants nargs to be signed.
2851 The overall type is now a union of structures rather than a
2852 structure of union of structures, and the 'kind' member is now a
2853 bitfield, so that the overall type doesn't grow. All uses changed.
2854 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2855
0a4df6a5
PE
28562013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2857
ec6ecaad
PE
2858 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2859 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2860
0a4df6a5
PE
2861 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2862
7bfe8dbc
EZ
28632013-06-17 Eli Zaretskii <eliz@gnu.org>
2864
2865 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2866 unless we know that the window w's frame is a frame object.
2867 Another attempt at solving bug#14062 and bug#14630.
2868
708e05f6
LMI
28692013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2870
2871 * textprop.c (property_set_type): New enum.
2872 (add_properties): Allow appending/prepending text properties.
2873 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2874 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2875 add_text_properties_1.
2876 (Fadd_face_text_property): New function that calls
2877 add_text_properties_1.
2878
84575e67
PE
28792013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2880
2881 Move functions from lisp.h to individual modules when possible.
2882 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2883 * alloc.c (XFLOAT_INIT, set_symbol_name):
2884 * buffer.c (CHECK_OVERLAY):
2885 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2886 (set_char_table_parent):
2887 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2888 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2889 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2890 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2891 (set_blv_valcell):
2892 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2893 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2894 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2895 (backtrace_args, backtrace_debug_on_exit):
2896 * floatfns.c (CHECK_FLOAT):
2897 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2898 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2899 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2900 (set_hash_index_slot):
2901 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2902 * marker.c (CHECK_MARKER):
2903 * textprop.c (CHECK_STRING_OR_BUFFER):
2904 * window.c (CHECK_WINDOW_CONFIGURATION):
2905 Move here from lisp.h, and make these functions static rather than
2906 extern inline.
2907 * buffer.c (Qoverlayp):
2908 * data.c (Qsubrp):
2909 * fns.c (Qhash_table_p):
2910 * window.c (Qwindow_configuration_p):
2911 Now static.
2912 * lisp.h: Remove the abovementioned defns and decls.
2913
44e18199 2914 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2915 In lisp.h, prefer functions to function-like macros, and
2916 constants to object-like macros, when either will do. This:
2917 . simplifies use, as there's no more need to worry about
2918 arguments' side effects being evaluated multiple times.
2919 . makes the code easier to debug on some platforms.
2920 However, when using gcc -O0, keep using function-like macros
2921 for a few critical operations, for performance reasons.
2922 This sort of thing isn't needed with gcc -Og, but -Og
2923 is a GCC 4.8 feature and isn't widely-enough available yet.
2924 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2925 Remove enum lsb_bits; no longer needed.
2926 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2927 * buffer.c (Qoverlap):
2928 * data.c (Qsubrp):
2929 * fns.c (Qhash_table_p):
2930 Now extern, so lisp.h can use these symbols.
2931 * dispextern.h: Include character.h, for MAX_CHAR etc.
2932 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2933 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2934 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2935 (GLYPH_CODE_P): Move here from lisp.h.
2936 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2937 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2938 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2939 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2940 XUNTAG now returns void *.
2941 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2942 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2943 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2944 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2945 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2946 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2947 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2948 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2949 New macros, renamed from their sans-lisp_h_ counterparts.
2950 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2951 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2952 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2953 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2954 If compiling via GCC without optimization, define these as macros
2955 in addition to inline functions.
2956 To disable this, compile with -DINLINING=0.
2957 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2958 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2959 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2960 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2961 (INTMASK, VALMASK): Now macros, since static values cannot be
2962 accessed from extern inline functions.
2963 (VALMASK): Also a constant, for benefit of old GDB.
2964 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2965 is INTEGERP, which can fold it in.
5165d44a 2966 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2967 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2968 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2969 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2970 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2971 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2972 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2973 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2974 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2975 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2976 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2977 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2978 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2979 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2980 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2981 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2982 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2983 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2984 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2985 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2986 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2987 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2988 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2989 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2990 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2991 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2992 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2993 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2994 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2995 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2996 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2997 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2998 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2999 Now functions.
3000 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3001 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3002 (VALMASK): Define in one place rather than in two, merging the
3003 USE_LSB_TAG parts; this is simpler.
3004 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3005 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3006 Move up, to avoid use before definition.
3007 Also include "globals.h" earlier, for the same reason.
3008 (make_natnum): New function.
3009 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3010 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3011 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3012 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3013 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3014 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3015 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3016 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3017 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3018 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3019 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3020 (Qwindow_configuration_p, Qimage): New forward declarations.
3021 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3022 (STRING_COPYIN): Remove; unused.
3023 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3024 (xcar_addr, xcdr_addr): New functions. All uses changed.
3025 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3026 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3027 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3028 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3029 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3030 (TYPE_RANGED_INTEGERP): Simplify.
3031 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3032 (setlocale, fixup_locale, synchronize_system_messages_locale)
3033 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3034 Now empty functions, not macros.
3035 (functionp): Return bool, not int.
3036 * window.c (Qwindow_configuration_p): Now extern,
3037 so window.h can use it.
3038 * window.h (Qwindowp): Move decl back to lisp.h.
3039
9583ec36
EZ
30402013-06-15 Eli Zaretskii <eliz@gnu.org>
3041
3042 * xdisp.c (Fline_pixel_height): New function, required for solving
3043 bug #14567.
3044
210272ce
PE
30452013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3046
3047 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3048
de0503df
SM
30492013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3050
3051 * lread.c (syms_of_lread):
3052 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3053
afbfe143
KD
30542013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3055
3056 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3057
d177e213
XF
30582013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3059
3060 * fileio.c (expand_file_name): Doc fix.
3061
05e3e412
PE
30622013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3063
f7394b12
PE
3064 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3065 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3066 Wait for self, not for 0. This can't hurt on GNU or similar
3067 system, and may help with Cygwin.
3068
05e3e412
PE
3069 * keyboard.c: Don't use PROP (...) as an lvalue.
3070 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3071 Use set_prop (A, B), not PROP (A) = B.
3072
17dd3097
EZ
30732013-06-10 Eli Zaretskii <eliz@gnu.org>
3074
3075 * xdisp.c (get_it_property): Use it->window instead of generating
3076 a Lisp object from it->w.
3077
52fab9c9
EZ
30782013-06-09 Eli Zaretskii <eliz@gnu.org>
3079
3080 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3081 get-char-property the window that is being rendered, instead of
3082 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3083 (compute_display_string_pos): When W is NULL, use the current
3084 buffer as the object to pass to get-char-property.
3085 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3086 pointer member of the bidi iterator, since no window is pertinent
3087 to this function.
52fab9c9 3088
5bf97bfc
EZ
30892013-06-08 Eli Zaretskii <eliz@gnu.org>
3090
3091 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3092 being displayed, and pass it to compute_display_string_pos.
3093 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3094 (bidi_paragraph_init): All callers changed.
3095
3096 * xdisp.c (init_from_display_pos, init_iterator)
3097 (handle_single_display_spec, next_overlay_string)
3098 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3099 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3100 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3101 (compute_display_string_pos): Accept additional argument, the
3102 window being displayed, and pass it to Fget_char_property.
3103 (Bug#14575)
3104
3105 * dispextern.h (struct bidi_it): New member w, the window being
3106 displayed.
3107 (compute_display_string_pos): Adjust prototype.
3108
5de0e011
JD
31092013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3110
e7b41c4c 3111 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3112
3113 * process.c (wait_reading_process_output): Check for NS before GLIB.
3114 GLIB may be linked in due to rsvg, but ns_select must be called.
3115
5de0e011
JD
3116 * xgselect.c (xg_select): Remove call to window_system_available
3117 and g_main_context_pending at the top, so Gdk events (i.e. file
3118 notify) are processed when Emacs is started with -nw.
3119
a822acff
EZ
31202013-06-07 Eli Zaretskii <eliz@gnu.org>
3121
3122 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3123 (ctagsfiles3): New variable, includes only *.m files.
3124 (TAGS): Use an explicit language name in the regular expressions,
3125 to avoid transformation of '/SOMETHING' by MSYS to
3126 'c:\MSYS\SOMETHING'.
3127
6c0a9ed1
RC
31282013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3129
3130 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3131
9ef6111b
EZ
31322013-06-06 Eli Zaretskii <eliz@gnu.org>
3133
3134 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3135 still need to set the mouse pointer shape and activate help-echo.
3136 (Bug#14558)
3137
7d300d64
PE
31382013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3139
3140 A few porting etc. fixes for the new file monitor code.
3141 See the thread containing
3142 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3143 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3144 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3145 (dir_monitor_callback, Fgfile_rm_watch):
3146 Use assq_no_quit instead of Fassoc, for speed.
3147 (dir_monitor_callback, Fgfile_rm_watch):
3148 eassert that the monitor is a fixnum.
3149 (dir_monitor_callback): No need for CDR_SAFE.
3150 Simplify building of lisp with alternative tails.
3151 (Fgfile_add_watch, Fgfile_rm_watch):
3152 Do not assume glib functions set errno reliably on failure.
3153 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3154 and signal an error otherwise.
3155 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3156 Use Fdelq instead of Fdelete, for speed.
3157
817ebfcf
EZ
31582013-06-05 Eli Zaretskii <eliz@gnu.org>
3159
3160 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3161 don't insist on being invoked on a highlighted tool-bar button.
3162 Avoids losing tool-bar functionality when mouse-highlight is nil.
3163 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3164 Don't highlight when mouse-highlight is nil.
3165 (note_mouse_highlight): When mouse-highlight is nil, don't return
3166 right away; instead, run tool-bar and mode-line highlight
3167 subroutine, clear any existing highlight, and revert the mouse
3168 pointer to its default shape. (Bug#14558)
3169
55577e7c
SM
31702013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3171
3172 * lisp.mk (lisp): Add prog-mode.el.
3173
f019a684
PE
31742013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3177 * process.c (dummy_handler): New function.
3178 (lib_child_handler): New static var.
3179 (handle_child_signal): Invoke it.
3180 (catch_child_signal): If a library has set up a signal handler,
3181 save it into lib_child_handler.
3182 (init_process_emacs): If using glib and not on Windows, tickle glib's
3183 child-handling code so that it initializes its private SIGCHLD handler.
3184 * syssignal.h (SA_SIGINFO): Default to 0.
3185 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3186 31; it should no longer be needed now.
3187
90db8702
MA
31882013-06-05 Michael Albinus <michael.albinus@gmx.de>
3189
3190 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3191
3192 * gfilenotify.c (globals_of_gfilenotify): New function.
3193 (syms_of_gfilenotify): Move global initialization there.
3194
3195 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3196
bfa3acd6
SM
31972013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3198
3199 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3200 * keyboard.c (menu_bar_items, tool_bar_items):
3201 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3202 not override local keymaps any more.
3203
ba59bd80
EZ
32042013-06-04 Eli Zaretskii <eliz@gnu.org>
3205
3206 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3207
7f203aa1
EZ
32082013-06-03 Eli Zaretskii <eliz@gnu.org>
3209
9337e206
EZ
3210 * w32console.c (initialize_w32_display): Return the dimensions of
3211 the console window via 2 additional arguments, not via the current
3212 frame. This avoids crashes due to overrunning the bounds of
3213 frame's decode_mode_spec_buffer, which is not resized following
3214 the change of the frame dimensions from the initial 10x10.
3215
3216 * w32term.h (w32_initialize_display_info): Adjust prototype.
3217
3218 * term.c (init_tty): Take dimensions of the frame from the values
3219 returned by initialize_w32_display.
3220
7f203aa1
EZ
3221 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3222 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3223 (LIBES): Add $(GFILENOTIFY_LIBS).
3224
3225 * w32inevt.c (handle_file_notifications): Add dummy implementation
3226 for !HAVE_W32NOTIFY.
3227
3228 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3229
55a87246
JD
32302013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3231
3232 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3233
3234 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3235
3236 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3237
3d5ee10a
PE
32382013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 Fix minor problems found by static checking.
3241 * data.c (pure_write_error):
3242 Use xsignal2, not Fsignal, as Fsignal might return.
3243 * eval.c (set_backtrace_debug_on_exit): Now static.
3244 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3245 No longer inline. EXTERN_INLINE is needed only for functions
3246 defined in .h files. Reindent function header as per GNU style.
3247 (backtrace_p, backtrace_top, backtrace_next):
3248 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3249 compiler or linker. Add extern decls to pacify gcc -Wall.
3250 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3251 Now static.
3252 * frame.c (free_monitors): Define only on platforms that need it.
3253 * nsterm.m (ns_term_init):
3254 * process.c (catch_child_signal):
3255 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3256 defined on all porting targets these days.
3257 * process.c, process.h (catch_child_signal):
3258 Make it extern only if NS_IMPL_GNUSTEP is defined.
3259
e2d8a6f0
EZ
32602013-06-03 Eli Zaretskii <eliz@gnu.org>
3261
3262 * w32.c (gettimeofday): Make the signature identical to prototype
3263 in nt/inc/sys/time.h.
3264
a8a7c5f6
SM
32652013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3266
3267 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3268 .gdbinit.
3269
3270 * keyboard.c (safe_run_hooks_error): Improve error message.
3271
3272 * data.c (pure_write_error): Add `object' argument.
3273 * puresize.h (CHECK_IMPURE): Use it.
3274
c9628c79
MA
32752013-06-03 Michael Albinus <michael.albinus@gmx.de>
3276
3277 * Makefile.in (NOTIFY_OBJ): New variable.
3278 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3279
3280 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3281 Call syms_of_gfilenotify.
3282
3283 * gfilenotify.c: New file.
3284
3285 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3286 and Qfile_w32notify.
3287 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3288 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3289
3290 * lisp.h: Declare syms_of_gfilenotify.
3291
3292 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3293
2f592f95
SM
32942013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3295
3296 Merge the specpdl and backtrace stacks. Make the structure of the
3297 specpdl entries more obvious via a tagged union of structs.
3298 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3299 (enum specbind_tag): New enum.
3300 (struct specbinding): Make it a tagged union of structs.
3301 Add a case for backtrace records.
3302 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3303 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3304 (backtrace_debug_on_exit): New accessors.
3305 (struct backtrace): Remove.
3306 (struct catchtag): Remove backlist field.
3307 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3308 Move to eval.c.
3309 (Flocal_variable_p): Speed up the common case where the binding is
3310 already loaded.
3311 * eval.c (backtrace_list): Remove.
3312 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3313 (set_backtrace_args, set_backtrace_nargs)
3314 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3315 (backtrace_next): New functions.
3316 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3317 (unwind_to_catch, internal_lisp_condition_case)
3318 (internal_condition_case, internal_condition_case_1)
3319 (internal_condition_case_2, internal_condition_case_n): Don't bother
3320 with backtrace_list any more.
3321 (Fsignal): Adjust to new backtrace format.
3322 (grow_specpdl): Move up.
3323 (record_in_backtrace): New function.
3324 (eval_sub, Ffuncall): Use it.
3325 (apply_lambda): Adjust to new backtrace format.
3326 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3327 data.c.
3328 (specbind): Adjust to new specpdl format. Simplify.
3329 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3330 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3331 backtrace format.
3332 (mark_backtrace): Remove.
3333 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3334 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3335 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3336 Use mark_specpdl.
3337 * profiler.c (record_backtrace): Use get_backtrace.
3338 (handle_profiler_signal): Use backtrace_top_function.
3339 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3340 accessor functions.
3341
c0342369
JD
33422013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3343
3344 * process.h (catch_child_signal): Declare.
3345
3346 * process.c (catch_child_signal): New function.
3347 (init_process_emacs): Call it.
3348
3349 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3350 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3351 NS_IMPL_COCOA.
3352 (x_set_cursor_type): Remove declaration.
3353 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3354 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3355 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3356 (ns_get_color): Use F suffix on float.
3357 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3358 (ns_get_rgb_color): Remove.
3359 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3360 (note_mouse_movement): x and y are CGFloat.
3361 (ns_draw_fringe_bitmap): Remove unused rowY.
3362 Change #if to COCOA && >= 10_6.
3363 (ns_draw_window_cursor): Remove unused overspill.
3364 (ns_draw_underwave): width and x are EamcsCGFloat.
3365 (ns_draw_box): thickness is CGFloat.
3366 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3367 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3368 if not in main thread.
3369 (ns_get_pending_menu_title, ns_check_menu_open)
3370 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3371 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3372 (sendFromMainThread:): New method.
3373 (changeFont:): size is CGFloat.
3374 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3375 Disable warning about permanent text.
3376 (characterIndexForPoint:): Adjust return type depending on GNUStep
3377 version.
3378 (mouseDown:): delta is CGFloat.
3379 (updateFrameSize): Remove unised variable f.
3380 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3381 Cast float to EmacsCGFloat.
3382 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3383 also to -1 when restoring.
3384 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3385 inside NS_IMPL_COCOA.
3386 (toggleFullScreen:): Put call to toggleFullScreen inside
3387 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3388 (setPosition:portion:whole:): por is CGFloat.
3389 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3390 (mouseDown:): Use CGFloat.
3391 (mouseDragged:): Remove unised variable edge.
3392 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3393
3394 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3395 of CGFloat differs.
3396 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3397 when NS_IMPL_GNUSTEP.
3398 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3399 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3400 (EmacsToolbar): Add clearAll. Add tag argument to
3401 addDisplayItemWithImage.
3402 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3403
3404 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3405
3406 * nsmenu.m (ns_update_menubar): Make static.
3407 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3408 (fillWithWidgetValue:): Add cast to SEL for setAction.
3409 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3410 (update_frame_tool_bar): Update code for GNUStep.
3411 (clearAll): New method.
3412 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3413 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3414 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3415 call to insertItemWithItemIdentifier.
3416 (validateVisibleItems): Fix indentation.
3417 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3418 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3419 UtilityWindow to aStyle, remove call to setStyleMask.
3420
3421 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3422
3423 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3424 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3425 Use F suffix on floats.
3426 (ns_char_width): Returns CGFloat.
3427 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3428 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3429 DPSxshow.
3430 (ns_glyph_metrics): CGFloat instead of float.
3431
a0eb10b3
JB
3432 * nsfns.m (x_set_foreground_color, x_set_background_color):
3433 Use EmacsCGFloat.
3434 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3435 remove unused variables.
3436 (Fns_read_file_name): Keep track if panel is for save.
3437 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3438 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3439 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3440 Just return the input if GNUStep.
c0342369
JD
3441 (x_screen_planes): Remove.
3442 (Fxw_color_values): Use EmacsCGFloat
3443 (Fns_display_monitor_attributes_list): Only get screen number for
3444 Cocoa.
ef099a94 3445 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3446 EmacsSavePanel.
3447 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3448 ns_directory_from_panel.
3449
da9aff11
PE
34502013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3451
3452 * process.c (handle_child_signal): Also use WCONTINUED.
3453 This is so that list-processes doesn't mistakenly list the process
3454 as stopped, when the process has actually been continued and is
3455 now running.
3456
0e64479a
PE
34572013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3458
fc186a96
PE
3459 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3460 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3461 not already configured.
3462
0e64479a
PE
3463 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3464
38b787fa
EZ
34652013-05-29 Eli Zaretskii <eliz@gnu.org>
3466
3467 * Makefile.in (mostlyclean): Remove *.res files.
3468
22513e52
SM
34692013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3470
3471 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3472 a buffer (bug#8447).
3473
6ef3db10
EZ
34742013-05-27 Eli Zaretskii <eliz@gnu.org>
3475
3476 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3477 display vector, and we backtrack, handle the case that the
3478 previous character position is also displayed from a display
3479 vector or covered by a display string or image. (Bug#14476)
3480
6799bb26
JD
34812013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3482
3483 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3484 (struct MonitorInfo, free_monitors): Remove.
3485 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3486 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3487 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3488 Qframes, Qsource.
3489
3490 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3491 (struct MonitorInfo, free_monitors): Remove.
3492 (ns_screen_name): Make static.
3493 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3494 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3495 Qframes, Qsource.
3496
3497 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3498 (struct MonitorInfo): New struct.
3499 (free_monitors, make_monitor_attribute_list): Declare.
3500
22513e52
SM
3501 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3502 New Lisp_Object:s.
6799bb26
JD
3503 (free_monitors, make_monitor_attribute_list): New functions.
3504 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3505 Qsource.
3506
38cd43eb
XF
35072013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3508
3509 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3510
2af0948d
SM
35112013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3512
a7eb9b0f
SM
3513 * keyboard.c: Apply keyboard decoding only to events that come directly
3514 from the tty, not from unread-command-events (bug#14368).
3515 (read_event_from_main_queue): New function, extracted from read_char).
3516 (read_decoded_char): Remove.
3517 (read_decoded_event_from_main_queue): New function to replace it.
3518 (read_char): Use it.
3519 (read_key_sequence): Use read_char rather than read_decoded_char.
3520
2af0948d
SM
3521 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3522
1413e9a5
BR
35232013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3524
3525 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3526
e6d2f155
KH
35272013-05-22 Kenichi Handa <handa@gnu.org>
3528
3529 The following changes are to fix the setting of
3530 buffer-file-coding-system on, for instance, C-x RET c unix RET
3531 _FILE_OF_DOS_EOL_TYPE_ RET.
3532
3533 * coding.h (struct coding_system): New member detected_utf8_chars.
3534
3535 * coding.c (detect_coding_utf_8): Count characters and check EOL
3536 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3537 BOM is there.
3538 (setup_coding_system): Do not initialize coding->head_ascii.
3539 (check_ascii): Do not set coding->eol_seen but update it. Do not
3540 call adjust_coding_eol_type here.
1413e9a5
BR
3541 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3542 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3543 of the found coding-system.
3544 (decode_coding_gap): Cancel previous change. Utilize the
3545 character numbers counted by detect_coding_utf_8. Fix detection
3546 of BOM for utf-8.
3547
ab56a6f4 35482013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3549
3550 * search.c (looking_at_1): Only set last_thing_searched if the match
3551 changed the match-data (bug#14281).
3552
ecc3c6ed
DA
35532013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3554
3555 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3556 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3557 (move_it_vertically_backward): Likewise.
3558
5ba8bf35
YM
35592013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3560
3561 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3562 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3563 (Fx_display_mm_width, Fx_display_mm_height):
3564 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3565
91e8418b 3566 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3567 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3568 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3569 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3570 (Fx_display_backing_store, Fx_display_visual_class)
3571 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3572 (Fx_display_grayscale_p, Fx_display_pixel_width)
3573 (Fx_display_pixel_height, Fx_display_planes)
3574 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3575 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3576 (Fx_display_mm_width, Fx_display_mm_height)
3577 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3578 height for all physical monitors as in X11.
3579
fc30d803
SM
3580 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3581 Return pixel width or height for all physical monitors as in X11.
91e8418b 3582
31ff141c
PE
35832013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 Port --enable-gcc-warnings to clang.
3586 * bytecode.c (exec_byte_code):
3587 * regex.c:
3588 Redo diagnostic pragmas to pacify clang, too.
3589 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3590 * editfns.c (Fencode_time):
3591 * fileio.c (file_accessible_directory_p):
3592 * font.c (font_unparse_xlfd):
3593 Use '&"string"[index]' instead of '"string" + (index)'.
3594 * undo.c (user_error): Remove; unused.
3595
df065a0b
EZ
35962013-05-16 Eli Zaretskii <eliz@gnu.org>
3597
04d360e7
EZ
3598 * insdel.c (insert_1_both): Document the arguments, instead of
3599 referring to insert_1, which no longer exists.
3600
5bb98290
EZ
3601 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3602 some window, increment windows_or_buffers_changed, so that
3603 *Messages* display in that window is updated. (Bug#14408)
3604
df065a0b
EZ
3605 * w32.c: Include epaths.h.
3606 (init_environment): Use cmdproxy.exe without leading directories.
3607 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3608 case.
3609 (gettimeofday): Adjust signature and return value to Posix
3610 expectations.
3611
3612 * unexw32.c (open_output_file): Delete the existing emacs.exe
3613 before creating it, to break the hard link to the versioned
3614 executable.
3615
3616 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3617 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3618 (FIRSTFILE_OBJ): New variables.
3619 (W32_RES): Rename to EMACSRES. All users changed.
3620 (base_obj): Use $(CM_OBJ).
3621 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3622 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3623 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3624 $(W32_RES_LINK) before $(LIBES).
3625 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3626
1aa8d505
SM
36272013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3628
6e911150
SM
3629 * makefile.w32-in (DOC): Use just "DOC".
3630
3631 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3632
1aa8d505
SM
3633 * process.c: Export default filters and sentinels to Elisp.
3634 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3635 New constants.
3636 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3637 (Fset_process_sentinel, Fformat_network_address):
3638 Default to them instead of nil.
3639 (server_accept_connection): Sentinels can't be nil any more.
3640 (read_and_dispose_of_process_output): New function, extracted from
3641 read_process_output.
3642 (read_process_output): Use it; filters can't be nil.
3643 (Finternal_default_process_filter): New function, extracted from
3644 read_process_output.
3645 (exec_sentinel_unwind): Remove function.
3646 (exec_sentinel): Don't zilch sentinel while running.
3647 (status_notify): Sentinels can't be nil.
3648 (Finternal_default_process_sentinel): New function extracted from
3649 status_notify.
3650 (setup_process_coding_systems): Default filter is not nil any more.
3651 (syms_of_process): Export new Elisp functions and initialize
3652 new constants.
3653 * lisp.h (make_lisp_proc): New function.
3654
5ac2eb34
SM
36552013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3656
3657 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3658
eda9c7d7
EZ
36592013-05-14 Eli Zaretskii <eliz@gnu.org>
3660
3661 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3662 unless we know that the window w is a leaf window.
3663 Another attempt at solving bug#14062.
eda9c7d7 3664
8fdeaad5
JD
36652013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3666
3667 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3668 fdesc (Bug#14375).
3669
44aa9ee6
PE
36702013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3671
3672 * image.c (gif_load): Check that subimages fit (Bug#14345).
3673
759fd763
SM
36742013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3675
3676 * lread.c (skip_dyn_eof): New function.
3677 (read1): Use it to skip the end of a file in response to #@00.
3678
3679 * doc.c (get_doc_string): Slightly relax the sanity checking.
3680
4465bfb4
JD
36812013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3682
3683 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3684 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3685 (MonitorInfo): New struct.
3686 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3687 (Fns_display_monitor_attributes_list): New functions.
3688 (display-usable-bounds): Remove.
3689 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3690 Qsource.
3691
7583e2a0
PE
36922013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3693
3694 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3695 (GTK_CHECK_VERSION): New macro, if not already defined.
3696 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3697 replaced by GTK_CHECK_VERSION.
3698
ad75d77e
PE
36992013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3700
3701 * xterm.h (GTK_PREREQ): New macro.
3702 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3703 to use this macro instead, for consistency and clarity.
3704
07525f77
EZ
37052013-05-08 Eli Zaretskii <eliz@gnu.org>
3706
3707 * xdisp.c (row_for_charpos_p): New function, with code of
3708 cursor_row_p, but accepts an additional argument CHARPOS instead
3709 of using a hardcoded PT.
3710 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3711 (row_containing_pos): Call row_for_charpos_p instead of partially
3712 doing the same. Fixes cursor positioning under longlines-mode
3713 when longlines-show-effect includes more than one newline, when
3714 moving the cursor vertically up.
3715
d901fc8d
JB
37162013-05-08 Juanma Barranquero <lekktu@gmail.com>
3717
3718 * makefile.w32-in (ACL_H): New macro.
3719 ($(BLD)/fileio.$(O)): Update dependencies.
3720
f269bc61
PE
37212013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3722
e7b41c4c 3723 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3724 * Makefile.in (LIB_ACL): New macro.
3725 (LIBACL_LIBS): Remove.
3726 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3727 * fileio.c: Include <acl.h>.
3728 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3729 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3730 !acl_errno_valid.
3731 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3732 it ourselves.
3733
f269bc61
PE
3734 * unexelf.c: Don't assume ElfW (Half) fits in int.
3735 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3736 when dealing with ElfW (Half) values, since they can exceed 2**31
3737 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3738 (entry_address): Omit unused NUM arg. All uses changed.
3739
a261c53e
JL
37402013-05-07 Juri Linkov <juri@jurta.org>
3741
3742 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3743 to the string converted from number with `Fnumber_to_string'.
3744 (Bug#14254)
3745
2b66427d
PE
37462013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3747
3748 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3749 This fixes a problem introduced by my previous change.
3750
15acfe41
GM
37512013-05-07 Glenn Morris <rgm@gnu.org>
3752
3753 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3754
5ea03bf5
JD
37552013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3756
3757 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3758
e0c9d565
PE
37592013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3760
3761 Static checking by GCC 4.8.0.
3762 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3763 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3764 (x_get_monitor_attributes_fallback)
3765 (x_get_monitor_attributes_xinerama)
3766 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3767 Define only if USE_GTK.
3768 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3769 (x_get_monitor_attributes_fallback): Omit unused locals.
3770 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3771 Use double, not float, to avoid mixed-mode floating point arithmetic.
3772
4e3f9230
YM
37732013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3774 Jan Djärv <jan.h.d@swipnet.se>
3775
3776 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3777 (XINERAMA_CFLAGS): New macros.
3778 (ALL_CFLAGS, LIBES): Use them.
3779
3780 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3781 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3782 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3783 (syms_of_xfns): DEFSYM them.
3784 (struct MonitorInfo): New struct.
3785 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3786 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3787 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3788 (x_get_monitor_attributes_xinerama): New functions.
3789 (Fx_display_monitor_attributes_list): New primitive.
3790 (syms_of_xfns): Defsubr it.
3791
3792 * xterm.h (x_display_info): Add Xatom_net_workarea and
3793 Xatom_net_current_desktop.
3794
3795 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3796 and dpyinfo->Xatom_net_current_desktop.
3797
05839b6a
EZ
37982013-05-06 Eli Zaretskii <eliz@gnu.org>
3799
3800 * xdisp.c (pos_visible_p): Use the special code for finding the
3801 beginning of a display property or overlay for any "replacing"
3802 display property, not just for display strings. This solves
3803 incorrect reporting of position by posn-at-point. (Bug#14241)
3804
dc4a2ee0
PE
38052013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3806
5ee94506
PE
3807 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3808 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3809 Verify that ElfW (Half) fits in int.
3810 (fatal): Use same signature as lisp.h.
3811 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3812 configure and build with -DUNEXELF_DEBUG without worrying about
3813 other modules that use DEBUG.
3814 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3815 possibly-wide integers now uses it instead of plain fprintf.
3816 (entry_address): New function, which avoids problems with 32-bit
3817 overflow on 64-bit hosts.
3818 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3819 (round_up): Don't assume the remainder fits in int.
3820 (find_section): Use bool for boolean. Simplify debug code.
3821 (unexec): Don't assume file sizes fit in int or size_t.
3822 Omit unnecessary trailing newline in 'fatal' format.
3823 Use strerror rather than outputting decimal error number.
3824 Remove unused code when emacs is not defined;
3825 this file relies on Emacs now.
3826 Don't assume e_phnum and e_shnum are positive.
3827
dc4a2ee0
PE
3828 * regex.c: Fix problems when DEBUG is defined.
3829 (extract_number, extract_number_and_incr): Define regardless of
3830 whether DEBUG is defined; that's simpler and makes the code less
3831 likely to go stale in the normal case when DEBUG is not defined.
3832 Return int rather than taking an int * arg. All callers changed.
3833 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3834 Remove, replacing with ...
3835 (DEBUG_PRINT): New macro. All callers changed.
3836 (DEBUG_COMPILES_ARGUMENTS): New macro.
3837 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3838 (print_compiled_pattern, print_double_string) [DEBUG]:
3839 Use prototype rather than old-style definition.
3840 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3841 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3842 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3843 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3844 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3845 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3846 This matters only when DEBUG is defined.
3847
14c7ed05
EZ
38482013-05-05 Eli Zaretskii <eliz@gnu.org>
3849
3850 * xdisp.c (set_iterator_to_next): Set the
3851 ignore_overlay_strings_at_pos_p flag only if we are _really_
3852 iterating over an overlay string, as indicated by the
3853 current.overlay_string_index member. (Bug#14306)
3854
e6076b1b
JD
38552013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3856
3857 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3858 to where it is used, to avoid autorelease issues (Bug#14050).
3859
cbee2131
PE
38602013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3861
3862 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3863 * fileio.c (syms_of_fileio): Implement this.
3864 * filelock.c (create_lock_file): If symbolic links don't work, so
3865 we use a regular file as a lock file, do not fsync the lock file;
3866 it's not needed.
3867
30c7e542
SM
38682013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3869
3870 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3871 (syms_of_minibuf): Adjust accodingly.
3872 * lread.c (Fread):
3873 * callint.c (Fcall_interactively): Adjust calls accordingly.
3874
5bebd186
EZ
38752013-05-04 Eli Zaretskii <eliz@gnu.org>
3876
3877 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3878 w->contents is a buffer before computing everything else.
3879 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3880
3881 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3882 assertion violations. (Bug#14062)
3883
0fb0a4f3
DR
38842013-05-01 David Reitter <david.reitter@gmail.com>
3885
3886 * nsfns.m (ns_tooltip): Initialize.
3887
9e63b4a5
EZ
38882013-04-28 Eli Zaretskii <eliz@gnu.org>
3889
3890 * coding.c (decode_coding_gap): Don't remove the character before
3891 a newline unless it's a CR character. (Bug#14287)
3892
ad60824e
DN
38932013-04-28 Dan Nicolaescu <dann@gnu.org>
3894
3895 * dispextern.h (struct face): Move enum face_underline_type
3896 earlier so that bitfields can be in the same word.
3897
edbdcec0
JD
38982013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3899
3900 * nsfns.m (handlePanelKeys): New function.
3901 (EmacsOpenPanel:performKeyEquivalent:)
3902 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3903 arrows/function/control and copy/paste keys (Bug#14296).
3904
0208ede7
JL
39052013-04-27 Juri Linkov <juri@jurta.org>
3906
3907 * callint.c (Fcall_interactively): Call `Qread_number' for
3908 interactive code letter `n' instead of using duplicate code.
3909 (Bug#14254)
3910
b8dd59f7
PE
39112013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 * systime.h (make_timeval): Declare as 'const'.
3914
8bd722db
KH
39152013-04-27 Kenichi Handa <handa@gnu.org>
3916
3917 * font.c (font_open_entity): Always open a font of manageable
3918 size.
3919
13d0e56f 39202013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3921
f780d632
PE
3922 Port better to AIX (Bug#14258).
3923 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3924 to pacify AIX xlc.
3925
ec509856
KH
39262013-04-24 Kenichi Handa <handa@gnu.org>
3927
3928 * coding.c (decode_coding_iso_2022): When an invalid escape
3929 sequence is encountered, reset the invocation and designation
3930 status to the safest one.
3931
84fc48e5
PE
39322013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3933
3934 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3935 Without this fix, "make distclean" leaves stamp-h1 behind.
3936
806bda47
EC
39372013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3938
3939 * w32fns.c (w32_fullscreen_rect): New function to compute the
3940 window rectangle for the given fullscreen mode.
3941 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3942 longer tunes the window size. This keeps the window's edges flush
3943 with the screen and allows the taskbar to hide itself in fullboth.
3944
3945 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3946 window decorations and uses the entire screen.
3947
3948 * w32term.h (w32_fullscreen_rect) Add prototype.
3949 (struct w32_output): Replace normal_width, normal_height,
3950 normal_top, and normal_left members with a single normal_placement
3951 struct.
3952 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3953 Remove macros.
3954 (FRAME_NORMAL_PLACEMENT): New macro.
3955
9cc2810b
JB
39562013-04-16 Juanma Barranquero <lekktu@gmail.com>
3957
3958 * minibuf.c (Ftest_completion): Silence compiler warning.
3959
fd16b54c
EZ
39602013-04-15 Eli Zaretskii <eliz@gnu.org>
3961
3962 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3963 bug#14062.
fd16b54c
EZ
3964
3965 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3966 parentheses.
3967
3968 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3969 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3970 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3971 parentheses where appropriate.
3972
9e3379a0
PE
39732013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3974
3975 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3976
ddd6b685
EZ
39772013-04-14 Eli Zaretskii <eliz@gnu.org>
3978
3979 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3980 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3981 Mention in the doc string that setting these variables takes
3982 effect only after a call to set-window-buffer. (Bug#14200)
3983
29b79ba1
EZ
39842013-04-13 Eli Zaretskii <eliz@gnu.org>
3985
3986 * indent.c (Fvertical_motion): Don't consider display strings on
3987 overlay strings as display strings on the buffer position we
3988 started from. This prevents vertical cursor motion from jumping
3989 more than one line when there's an overlay string with a display
3990 property at end of line.
3991 Reported by Karl Chen <Karl.Chen@quarl.org> in
3992 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3993
562c6ee9
SM
39942013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3995
3996 * window.c (select_window): `record_buffer' even if window is
3997 already selected (bug#14191).
3998
fcc1fe85
EZ
39992013-04-11 Eli Zaretskii <eliz@gnu.org>
4000
4001 * window.c (Fwindow_end): Test more flags, including the buffer's
4002 last_overlay_modified flag, to determine whether the window's
4003 display is really up-to-date. Prevents the function from
4004 returning a stale value. (Bug#14170)
4005 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4006 current matrix.
4007
f009190a
EZ
40082013-04-10 Eli Zaretskii <eliz@gnu.org>
4009
4010 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4011 garbaged only if it is not already the top frame on its TTY.
4012 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4013 there are GUI frames open in the same session. (Bug#13864)
4014
78ce603d
SM
40152013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4016
4017 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4018 of marking the idle timers directly.
4019
a8036e40
SM
40202013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4021
4022 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4023 tables (bug#14054).
4024
7ffe7ef6
SM
40252013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4026
4027 * window.c (select_window): Don't record_buffer while the invariant is
4028 temporarily broken (bug#14161).
4029
4030 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4031
7d9f6883
EZ
40322013-04-07 Eli Zaretskii <eliz@gnu.org>
4033
4034 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4035
5406cfd9
RF
40362013-04-07 Romain Francoise <romain@orebokech.com>
4037
4038 Ignore additional platform-specific ACL errors (Bug#13702).
4039 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4040 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4041
95c0e83b
JD
40422013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4043
4044 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4045 f->output_data.ns.
4046
876da980
PE
40472013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4048
4049 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4050 This bug was introduced by my 2013-02-25 change that simplified
4051 data_start configuration. Without this change, on GNU/Linux
4052 an Emacs configured with --enable-profiling fails immediately
4053 due to a profiler signal.
4054 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4055 with these flags. On platforms where special flags are needed
4056 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4057 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4058 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4059
7452b7bd
DA
40602013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4061
4062 Get rid of some platform-specific functions examining window
4063 system and its capabilities. This is a partial rework of the
4064 2013-04-05 change.
4065 * lisp.h (have_menus_p): Remove prototype. This function is
4066 replaced with platform-independent window_system_available.
4067 (check_window_system): Move to...
4068 * frame.h (decode_window_system_frame, window_system_available):
4069 ...here, add new prototypes.
4070 * frame.c (window_system_available, decode_window_system_frame):
4071 New functions.
4072 (check_window_system): Platform-independent now.
4073 * xterm.h (x_in_use): Remove declaration.
4074 (check_x_frame):
4075 * w32term.h (check_x_frame):
4076 * nsterm.h (check_x_frame): Remove prototypes. This function
4077 is replaced with platform-independent decode_window_system_frame.
4078 * msdos.c (have_menus_p): Remove.
4079 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4080 Remove platform-specific functions. Use check_window_system,
4081 decode_window_system_frame and check_ns_display_info where
4082 appropriate. Minor style and comment tweaks.
4083 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4084 (check_x_frame): Likewise.
4085 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4086 Likewise.
4087 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4088 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4089 * xmenu.c, xselect.c: All related users changed.
4090
251e9147
KH
40912013-04-03 Kenichi Handa <handa@gnu.org>
4092
4093 The following changes is to optimize the code for reading UTF-8
4094 files.
4095
562c6ee9 4096 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4097 changed. Check EOL format. Do not call adjust_coding_eol_type
4098 here.
4099 (check_utf_8): New function.
4100 (adjust_coding_eol_type): Do nothing if already adjusted.
4101 (detect_coding): Compare the return value of check_ascii with
4102 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4103 (decode_coding_gap): Optimize for valid UTF-8.
4104
8bc369d4
KH
41052013-03-21 Kenichi Handa <handa@gnu.org>
4106
4107 * coding.c (syms_of_coding): Cancel previous change.
4108
4109 * insdel.c (insert_from_gap): Fix previous change.
4110
73931ad1
DA
41112013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4112
4113 Consistently use platform-specific function to detect window system.
4114 * lisp.h (check_window_system): New prototype. This function is
4115 going to replace check_x, check_w32 and check_ns.
4116 (have_menus_p): Mention msdos.c in comment.
4117 * fontset.c (check_window_system_func): Remove. Adjust all users.
4118 * fontset.h (check_window_system_func): Remove prototype.
4119 * nsterm.h (check_ns):
4120 * xterm.h (check_x):
4121 * w32term.h (check_w32): Likewise.
4122 * menu.c (Fx_popup_menu): Use check_window_system.
4123 * msdos.c (check_window_system): Define for MS-DOS.
4124 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4125 * w32fns.c (check_window_system): Likewise for MS-Windows.
4126 * xfns.c (check_window_system): Likewise for X.
4127 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4128 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4129
7216e43b
PE
41302013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4131
4132 Prefer < to > in range checks such as 0 <= i && i < N.
4133 This makes it easier to visualize quantities on a number line.
4134 This patch doesn't apply to all such range checks,
4135 only to the range checks affected by the 2013-03-24 change.
4136 This patch reverts most of the 2013-03-24 change.
4137 * alloc.c (xpalloc, Fgarbage_collect):
4138 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4139 * character.c (string_escape_byte8):
4140 * charset.c (read_hex):
4141 * data.c (cons_to_unsigned):
4142 * dispnew.c (update_frame_1):
4143 * doc.c (Fsubstitute_command_keys):
4144 * doprnt.c (doprnt):
4145 * editfns.c (hi_time, decode_time_components):
4146 * fileio.c (file_offset):
4147 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4148 * font.c (font_intern_prop):
4149 * frame.c (x_set_alpha):
4150 * gtkutil.c (get_utf8_string):
4151 * indent.c (check_display_width):
4152 * keymap.c (Fkey_description):
4153 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4154 * lread.c (read1):
4155 * minibuf.c (read_minibuf_noninteractive):
4156 * process.c (wait_reading_process_output):
4157 * search.c (Freplace_match):
4158 * window.c (get_phys_cursor_glyph):
4159 * xdisp.c (redisplay_internal):
4160 * xsmfns.c (smc_save_yourself_CB):
4161 Prefer < to > for range checks.
4162 * dispnew.c (sit_for): Don't mishandle NaNs.
4163 This fixes a bug introduced in the 2013-03-24 change.
4164 * editfns.c (decode_time_components): Don't hoist comparison.
4165 This fixes another bug introduced in the 2013-03-24 change.
4166
92759988
DA
41672013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4168
4169 * frame.h (struct frame): Drop scroll_bottom_vpos
4170 member becaue all real users are dead long ago.
4171 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4172 * xdisp.c (redisplay_internal): Adjust user.
4173
9a1971bb
GM
41742013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4175
f38ab167
JD
4176 * nsmenu.m (showAtX:Y:for:): setLevel to
4177 NSPopUpMenuWindowLevel (Bug#13998).
4178
6d01f1fe
JD
41792013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4180
4181 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4182 (ns_check_pending_open_menu): Declare.
4183
4184 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4185 (x_activate_menubar): Update the menu with title that matches
4186 ns_get_pending_menu_title, and call
4187 ns_check_pending_openmenu (Bug#12698).
4188 (menuWillOpen:): New method.
4189 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4190
4191 * nsterm.m (menu_will_open_state, menu_mouse_point)
4192 (menu_pending_title): New varaibles.
4193 (ns_get_pending_menu_title, ns_check_menu_open)
4194 (ns_check_pending_open_menu): New functions.
4195
781f4782
DA
41962013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4197
4198 * indent.c (current_column_bol_cache): Remove leftover which is not
4199 used in Fmove_to_column any more.
4200 (current_column, scan_for_column): Adjust users.
4201 * keyboard.c (last_point_position_buffer, last_point_position_window):
4202 Remove leftovers which are not used for recording undo any more.
4203 (command_loop_1, syms_of_keyboard): Adjust users.
4204 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4205 redisplay_window any more.
4206 (move_it_to): Adjust user.
4207
1921c31b
JB
42082013-03-29 Juanma Barranquero <lekktu@gmail.com>
4209
4210 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4211 Update dependencies.
4212
717b8bcd
SM
42132013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4214
4215 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4216 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4217 forward references.
4218
e74aeda8
DA
42192013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4220
4221 * window.h (struct window): Replace hchild, vchild and buffer slots
4222 with the only contents slot. This is possible because each valid
4223 window may have either the child window (in vertical or horizontal
4224 combination) or buffer to display (for the leaf window). Using that,
4225 a lof of operations to traverse and/or change window hierarchies may
4226 be simplified. New member horizontal is used to distinguish between
4227 horizontal and vertical combinations of internal windows.
4228 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4229 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4230 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4231 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4232 Use contents slot, not buffer, where appropriate.
4233 (wset_combination): New function.
4234 (wset_buffer): Add eassert.
4235 (Fframe_first_window): Simplify the loop reaching first window.
4236 (Fwindow_buffer): Use WINDOW_LEAF_P.
4237 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4238 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4239 (unshow_buffer): Convert initial debugging check to eassert.
4240 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4241 (make_parent_window, window_resize_check, window_resize_apply)
4242 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4243 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4244 Adjust to match struct window changes.
4245 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4246 (mark_window_cursors_off, count_windows, get_leaf_windows)
4247 (foreach_window_1): Simplify the loop.
4248 * alloc.c (mark_object): Do not check for the leaf window because
4249 internal windows has no glyph matrices anyway.
4250 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4251 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4252 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4253 (build_frame_matrix_from_window_tree, mirror_make_current)
4254 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4255 (update_window_tree, set_window_update_flags): Simplify the loop.
4256 (sync_window_with_frame_matrix_rows): Enforce live window.
4257 Use contents slot, not buffer, where appropriate.
4258 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4259 and WINDOW_HORIZONTAL_COMBINATION_P.
4260 (make_frame_visible_1): Simplify the loop.
4261 Use contents slot, not buffer, where appropriate.
4262 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4263 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4264 (expose_window_tree): Likewise.
4265 Use contents slot, not buffer, where appropriate.
4266 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4267 to avoid deleted windows. Use contents slot instead of buffer.
4268 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4269 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4270 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4271 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4272
121ab1cd
EZ
42732013-03-28 Eli Zaretskii <eliz@gnu.org>
4274
ef454cf7
EZ
4275 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4276 identify the reasons for assertion violations in bug#14062 and
4277 similar ones.
21e930f8
EZ
4278 (Fx_show_tip): Fix compilation error under
4279 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4280
121ab1cd
EZ
4281 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4282 Reported by <rzl24ozi@gmail.com>.
4283
5c89ca24
DA
42842013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4285
4286 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4287 start marker...
562c6ee9
SM
4288 (unwind_with_echo_area_buffer): ...to restore it here.
4289 This is needed to ensure that...
5c89ca24
DA
4290 (redisplay_window): ...both window markers are valid here,
4291 which is verified by eassert.
4292 * editfns.c (save_excursion_save): Do not assume that
4293 selected_window always displays the buffer.
c7f53895
DA
4294 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4295 Fix comment.
5c89ca24 4296
f557c1b1
SM
42972013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4298
4299 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4300 the upcase table.
4301
40693bba 43022013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4303
4304 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4305
c86f791f
EZ
43062013-03-27 Eli Zaretskii <eliz@gnu.org>
4307
4308 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4309 since MinGW's w32api headers do. This avoids compiler warnings.
4310
4311 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4312 if already defined.
4313
c6e72e17
EZ
43142013-03-26 Eli Zaretskii <eliz@gnu.org>
4315
4316 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4317
54e95010
JD
43182013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4319
4320 * gtkutil.c (style_changed_cb): Check if frame is live and an
4321 X frame (Bug#14038).
4322
b88b62de
EZ
43232013-03-26 Eli Zaretskii <eliz@gnu.org>
4324
a18d7de6
EZ
4325 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4326 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4327 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4328 MinGW64.
8f5e14c8
EZ
4329 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4330 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4331
b88b62de
EZ
4332 Fix incompatibilities between MinGW.org and MinGW64 headers.
4333 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4334
4335 * w32.c (REPARSE_DATA_BUFFER): Guard with
4336 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4337
c074e458
JD
43382013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4339
4340 * xterm.c: Include X11/XKBlib.h
4341 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4342
908589fd
AS
43432013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4344
4345 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4346 written backwards.
4347 * blockinput.h (input_blocked_p): Likewise.
4348 * bytecode.c (exec_byte_code): Likewise.
4349 * callproc.c (call_process_kill, call_process_cleanup)
4350 (Fcall_process): Likewise.
4351 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4352 (Fccl_execute_on_string): Likewise.
4353 * character.c (string_escape_byte8): Likewise.
4354 * charset.c (read_hex): Likewise.
4355 * cm.c (calccost): Likewise.
4356 * data.c (cons_to_unsigned): Likewise.
4357 * dired.c (directory_files_internal, file_name_completion):
4358 Likewise.
4359 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4360 (sit_for): Likewise.
4361 * doc.c (Fsubstitute_command_keys): Likewise.
4362 * doprnt.c (doprnt): Likewise.
4363 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4364 * emacsgtkfixed.c: Likewise.
4365 * fileio.c (file_offset, Fwrite_region): Likewise.
4366 * floatfns.c (Fexpt, fmod_float): Likewise.
4367 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4368 Likewise.
4369 * font.c (font_intern_prop): Likewise.
4370 * frame.c (x_set_alpha): Likewise.
4371 * gtkutil.c (get_utf8_string): Likewise.
4372 * indent.c (check_display_width): Likewise.
4373 * intervals.c (create_root_interval, rotate_right, rotate_left)
4374 (split_interval_right, split_interval_left)
4375 (adjust_intervals_for_insertion, delete_node)
4376 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4377 (merge_interval_right, merge_interval_left, copy_intervals)
4378 (set_intervals_multibyte_1): Likewise.
4379 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4380 * keymap.c (Fkey_description): Likewise.
4381 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4382 * lread.c (openp, read_integer, read1, string_to_number):
4383 Likewise.
4384 * menu.c (ensure_menu_items): Likewise.
4385 * minibuf.c (read_minibuf_noninteractive): Likewise.
4386 * print.c (printchar, strout): Likewise.
4387 * process.c (create_process, Faccept_process_output)
4388 (wait_reading_process_output, read_process_output, send_process)
4389 (wait_reading_process_output): Likewise.
4390 * profiler.c (make_log, handle_profiler_signal): Likewise.
4391 * regex.c (re_exec): Likewise.
4392 * regex.h: Likewise.
4393 * search.c (looking_at_1, Freplace_match): Likewise.
4394 * sysdep.c (get_child_status, procfs_ttyname)
4395 (procfs_get_total_memory): Likewise.
4396 * systime.h (EMACS_TIME_VALID_P): Likewise.
4397 * term.c (dissociate_if_controlling_tty): Likewise.
4398 * window.c (get_phys_cursor_glyph): Likewise.
4399 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4400 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4401 Likewise.
4402 * xfns.c (Fx_window_property): Likewise.
4403 * xmenu.c (set_frame_menubar): Likewise.
4404 * xselect.c (x_get_window_property, x_handle_dnd_message):
4405 Likewise.
4406 * xsmfns.c (smc_save_yourself_CB): Likewise.
4407 * xterm.c (x_scroll_bar_set_handle): Likewise.
4408
2bf7d27a
DA
44092013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4410
4411 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4412 to be optional or nil. Adjust comment and convert it to docstring.
4413 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4414 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4415
a9ebfa0b
PE
44162013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4417
4418 Static checking by GCC 4.8-20130319.
4419 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4420 * process.c (Fset_process_datagram_address)
4421 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4422 * xdisp.c (get_char_face_and_encoding):
4423 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4424 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4425 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4426
4f3576ee
KB
44272013-03-24 Ken Brown <kbrown@cornell.edu>
4428
789b5e9a
KB
4429 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4430 fix compilation on 64-bit Cygwin, where underscores are not
4431 automatically prepended.
4432
4f3576ee
KB
4433 * w32term.c (w32_initialize): Silence compiler warning.
4434
b5b7745f
EZ
44352013-03-23 Eli Zaretskii <eliz@gnu.org>
4436
cdc0d0bd
EZ
4437 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4438 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4439 variables, to save and restore frame dimensions.
4440 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4441 after returning from a 'fullscreen' configuration.
4442 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4443 to avoid races between the main thread and the input thread.
4444
4445 * w32term.h (struct w32_output): New members normal_width,
4446 normal_height, normal_top, normal_left, and prev_fsmode.
4447 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4448 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4449 members of a frame.
4450
b5b7745f
EZ
4451 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4452 'fullscreen' parameter. Always record previous width and height
4453 of the frame, except when switching out of maximized modes, so
4454 that they could be restored correctly, instead of resetting to the
4455 default frame dimensions. Send SC_RESTORE command to the frame,
4456 unless we are going to send SC_MAXIMIZE, to restore the frame
4457 resize hints in the mouse pointer shown by the window manager.
4458 (Bug#14032)
4459
4460 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4461
4462 * lisp.h (get_frame_param): Adjust conditions for prototype
4463 declaration.
4464
a3454eed
KB
44652013-03-22 Ken Brown <kbrown@cornell.edu>
4466
4467 * unexcw.c: Drop unneeded inclusion of w32common.h.
4468 (report_sheap_usage): Declare.
4469 (read_exe_header): Add magic numbers for x86_64.
4470 (fixup_executable): Fix printf format specifier for unsigned long
4471 argument.
4472
5a49b79c
DA
44732013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4474
4475 * frame.h (struct frame): Put menu_bar_window under #ifdef
4476 because this member is not needed when X toolkit is in use.
4477 (fset_menu_bar_window):
4478 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4479 (free_glyphs, update_frame):
4480 * xdisp.c (expose_frame): Likewise.
4481 (display_menu_bar): Likewise. Remove redundant eassert.
4482 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4483 toolkit is in use.
4484
d6723bf7
PE
44852013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4486
7b1123d8
PE
4487 Use functions and constants to manipulate Lisp_Save_Value objects.
4488 This replaces code that used macros and strings and token-pasting.
4489 The change makes the C source a bit easier to follow,
4490 and shrinks the Emacs executable a bit.
4491 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4492 (make_save_value): Change 1st arg from string to enum. All callers
4493 changed.
4494 (INTX): Remove.
4495 (mark_object): Use if, not #if, for GC_MARK_STACK.
4496 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4497 (XSAVE_OBJECT): Now functions, not macros.
4498 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4499 the constant was never used.
4500 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4501 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4502 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4503 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4504 New constants.
4505 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4506 type3 with a single member save_type. All uses changed.
4507 (save_type, set_save_pointer, set_save_integer): New functions.
4508 * print.c (PRINTX): Remove.
4509
d6723bf7
PE
4510 * alloc.c: Remove redundant static declarations.
4511
5f24fa51
DA
45122013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4513
4514 * window.h (struct window): Convert left_col, top_line, total_lines
4515 and total_cols from Lisp_Objects to integers. Adjust comments.
4516 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4517 Remove.
4518 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4519 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4520 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4521 Adjust users where appropriate.
4522
42143acd
DA
45232013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4524
4525 * frame.h (struct frame): Drop resx and resy because the same data is
4526 available from window system-specific output context. Adjust users.
562c6ee9
SM
4527 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4528 New functions to provide defaults when no window system available.
42143acd 4529 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4530 (NUMVAL): Move from xdisp.c.
42143acd
DA
4531 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4532 (Ffont_face_attributes, Fopen_font):
4533 * image.c (gs_load):
4534 * w32font.c (fill_in_logfont):
4535 * xdisp.c (calc_pixel_width_or_height):
4536 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4537 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4538
c0a17406
KH
45392013-03-20 Kenichi Handa <handa@gnu.org>
4540
4541 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4542 to 1 (temporary workaround until a bug related to ASCII
4543 optimization is fixed).
4544
095d384d
DA
45452013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4546
4547 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4548 Signal error if window is not internal. Adjust docstring.
4549 (delete_all_child_windows): Use combination_limit to save the buffer.
4550 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4551 * print.c (syms_of_print): Initialize debugging output not here...
4552 (init_print_once): ...but in a new function here.
4553 * lisp.h (init_print_once): Add prototype.
4554 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4555
748fa866
DA
45562013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4557
4558 * window.c (window_resize_check, window_resize_apply)
4559 (window_from_coordinates, recombine_windows, set_window_buffer)
4560 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4561 (Fsplit_window_internal, Fdelete_window_internal)
4562 (freeze_window_starts): Use bool for booleans.
4563 * window.h (window_frame_coordinates, resize_frame_windows)
4564 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4565
81519fd2
SM
45662013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4567
4568 * dispnew.c (bitch_at_user): Use `user-error'.
4569
6db423a9
KB
45702013-03-17 Ken Brown <kbrown@cornell.edu>
4571
4572 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4573 as return type of image_background. (Bug#13981)
4574 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4575
8f2906f5
JD
45762013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4577
960ce480 4578 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4579 (ns_select): Don't return with result uninitialized.
960ce480 4580
8f2906f5
JD
4581 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4582 and getDirectory.
4583
81519fd2
SM
4584 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4585 New functions.
8f2906f5
JD
4586 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4587 directories. If filename is nil, get directory name (Bug#13932).
4588 Use getFilename and getDirectory.
4589 (getFilename, getDirectory): New methods for EmacsSavePanel and
4590 EmacsOpenPanel.
4591 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4592
cded56c1
PE
45932013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4594
4595 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4596
251e9147 45972013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4598
4599 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4600 (adjust_after_replace): Make it back to static. Delete the third
4601 arg text_at_gap_tail. Cancel the code for handling it.
4602
4603 * coding.h (struct coding_system): New member eol_seen.
4604
4605 * coding.c (detect_ascii): New function.
4606 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4607 when the source bytes are actually scanned. On detecting for
4608 coding_category_utf_8_auto, call detect_ascii instead of scanning
4609 source bytes directly.
4610 (produce_chars): Call insert_from_gap with the new arg 0.
4611 (encode_coding): Likewise.
4612 (decode_coding_gap): Control ASCII optimization by the variable
4613 disable_ascii_optimization instead of #ifndef .. #endif.
4614 Deccode EOL format according to coding->eol_seen.
4615 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4616 variable.
4617
8a44e6d1
KH
4618 * lisp.h (adjust_after_replace): Cancel externing it.
4619 (insert_from_gap): Adjust prototype.
4620
5f795e34
EZ
46212013-03-15 Eli Zaretskii <eliz@gnu.org>
4622
4623 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4624 FULLSCREEN_MAXIMIZED. (Bug#13935)
4625
f258b4be
DA
46262013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4627
4628 * region-cache.c (find_cache_boundary, move_cache_gap)
4629 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4630 Simplify debugging check and convert to eassert. Adjust comment.
4631 (pp_cache): Put under ENABLE_CHECKING.
4632
a5cc4dde
EZ
46332013-03-14 Eli Zaretskii <eliz@gnu.org>
4634
4635 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4636 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4637 and WM_ACTIVATEAPP.
4638 (w32fullscreen_hook): If the frame is visible, reset
4639 f->want_fullscreen flag after changing the frame size. If the
4640 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4641 (Bug#13953)
4642
3fc5e44a
DC
46432013-03-13 Daniel Colascione <dancol@dancol.org>
4644
4645 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4646 too so that these builds can use Cygwin's file conversion
4647 functions. (We've been building and linking cygw32.o all along
4648 and just not using it.)
4649
47d7532e
PE
46502013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4651
4652 File synchronization fixes (Bug#13944).
4653 * Makefile.in (LIB_FDATASYNC): New macro.
4654 (LIBES): Use it.
4655 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4656 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4657 Don't worry about HAVE_FSYNC, since a substitute fsync is
4658 available if the system lacks one.
4659 (Fwrite_regin): Retry fsync if interrupted.
4660
c7ffccaf
EZ
46612013-03-13 Eli Zaretskii <eliz@gnu.org>
4662
4e2df81d 4663 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4664 activated, call w32fullscreen_hook, to make sure the new frame
4665 dimensions are in effect. (Bug#13937)
4666
8a7debc1
DA
46672013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4668
4669 * xdisp.c (init_iterator): Simplify because both character and byte
4670 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4671 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4672 character and byte positions can be obtained from marker.
8a7debc1 4673
7fd8c501
PE
46742013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4675
d9df6f40
PE
4676 Static checking by Sun C 5.12.
4677 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4678 * bytecode.c (exec_byte_code):
4679 * dispnew.c (init_display):
4680 * eval.c (error):
4681 * fileio.c (Fsubstitute_in_file_name):
4682 * keyboard.c (Fevent_convert_list):
4683 * keymap.c (Fsingle_key_description):
4684 * term.c (maybe_fatal, fatal):
4685 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4686 * xsmfns.c (Fhandle_save_session):
4687 Omit unreachable code.
4688 * keymap.c (map_keymap_char_table_item): Cast void * to
4689 a function pointer type; the C Standard requires this.
4690
7fd8c501
PE
4691 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4692 Include <sys/param.h> unconditionally, as that works elsewhere and
4693 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4694 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4695 and FreeBSD now.
4696
a020afb9 4697See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4698
4699;; Local Variables:
4700;; coding: utf-8
aac0c6e3
MR
4701;; End:
4702
ab422c4d 4703 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4704
4705 This file is part of GNU Emacs.
4706
4707 GNU Emacs is free software: you can redistribute it and/or modify
4708 it under the terms of the GNU General Public License as published by
4709 the Free Software Foundation, either version 3 of the License, or
4710 (at your option) any later version.
4711
4712 GNU Emacs is distributed in the hope that it will be useful,
4713 but WITHOUT ANY WARRANTY; without even the implied warranty of
4714 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4715 GNU General Public License for more details.
4716
4717 You should have received a copy of the GNU General Public License
4718 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.